Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 21, 2004:

8:31 PM Changeset in webkit [8060] by mjs

• 2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3889655> HTMLCollectionImpl should use traverseNextNode to improve speed and save recursion

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::getNamedItem): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::nextNamedItemInternal): (HTMLFormCollectionImpl::nextNamedItemInternal):

Nov 20, 2004:

2:10 PM Changeset in webkit [8059] by mjs

• 3 edits in trunk/WebKit

WebKit:

Reviewed by John.

<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower

• Misc.subproj/WebNSURLExtras.h:

• Misc.subproj/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): New SPI to check if a URL string is already in user-visible form (i.e. converting it to an NSURL and then back via _web_userVisibleString would not change anything).

WebBrowser:

Reviewed by John,

<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower

• URLCompletionController.m: (_rawStringFromItem): use URLString from history item when possible, only convert to user visible string when we really have to.

1:44 PM Changeset in webkit [8058] by mjs

• 2 edits in trunk/WebKit

WebKit:

Reviewed by NOBODY (OOPS!).

<rdar://problem/3190977> closing window with many tabs in it can be quite slow

• WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): autorelease bridge instead of releasing it, to make window and tab closing more responsive - this way the deallocation happens after the windoow or tab appears to close.

WebBrowser:

Reviewed by NOBODY (OOPS!).

<rdar://problem/3190977> closing window with many tabs in it can be quite slow

• BrowserDocument.m: (-[BrowserDocument close]): Don't make an autorelease pool here. This should not be needed for PLT world leak detection any more, and it is necessary to make window closing responsive.

Nov 19, 2004:

6:24 PM Changeset in webkit [8057] by mjs

• 10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3482935> JavaScript so slow it seems like a hang (hrweb.apple.com) (HTMLCollection?)
<rdar://problem/3759149> PeopleSoft page in Safari twice as slow as Mozilla engine (HTMLFormCollection)
<rdar://problem/3888368> selecting an item on the Apache bugzilla query page can be improved 95% (HTMLFormCollection)

Many optimizations to HTMLFormCollection. Iterating it should not
be N^{2 any more, though finding items by name could still be.}

• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): (DOM::HTMLFormElementImpl::length): (DOM::HTMLFormElementImpl::submitClick): (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLFormElementImpl::radioClicked): (DOM::appendToVector): (DOM::removeFromVector): (DOM::HTMLFormElementImpl::registerFormElement): (DOM::HTMLFormElementImpl::removeFormElement): (DOM::HTMLFormElementImpl::makeFormElementDormant): (DOM::HTMLFormElementImpl::registerImgElement): (DOM::HTMLFormElementImpl::removeImgElement):
• khtml/html/html_formimpl.h:
• khtml/html/html_miscimpl.cpp: (HTMLFormCollectionImpl::FormCollectionInfo::FormCollectionInfo): (void::HTMLFormCollectionImpl::FormCollectionInfo::reset): (HTMLFormCollectionImpl::resetCollectionInfo): (HTMLFormCollectionImpl::calcLength): (HTMLFormCollectionImpl::item): (HTMLFormCollectionImpl::getNamedItem): (HTMLFormCollectionImpl::getNamedFormItem): (HTMLFormCollectionImpl::firstItem): (HTMLFormCollectionImpl::nextItem):
• khtml/html/html_miscimpl.h: (DOM::HTMLFormCollectionImpl::~HTMLFormCollectionImpl):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): (ElementImpl::setAttributeMap):
• kwq/KWQPtrVector.h: (QPtrVector::findRef):
• kwq/KWQVectorImpl.h:
• kwq/KWQVectorImpl.mm: (KWQVectorImpl::findRef):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementWithName:inForm:]): (-[WebCoreBridge controlsInForm:]):

5:36 PM Changeset in webkit [8056] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken and Darin.

<rdar://problem/3856215> Cannot remove bold from the beginning of a message

Problem is that KHTMLPart::computeAndSetTypingStyle always looked upstream
for the existing style, but in this case (hitting cmd-B with caret at top of
file) there is nothing upstream. Changed this to use the VisiblePosition
deepEquivalent instead.

• khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle):

5:13 PM Changeset in webkit [8055] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

* empty log message *

5:09 PM Changeset in webkit [8054] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/khtml/xml/dom_docimpl.cpp

Fixed by Maciej, merged by Darin for SUPanPlum <rdar://problem/3872586>.

2004-11-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

4:57 PM Changeset in webkit [8053] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (v172+)

The tree is OPEN!

4:48 PM Changeset in webkit [8052]

• 2 copies in tags/Safari-172

This commit was manufactured by cvs2svn to create tag 'Safari-172'.

4:48 PM Changeset in webkit [8051] by vicki

• 6 edits in trunk

Safari-172 stamp

3:21 PM Changeset in webkit [8050] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3880387> REGRESSION: www.shockplay.com site gives "Unexpected server response"

Reviewed by mjs.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[NSData _web_locationAfterFirstBlankLine]): support both formats ("\r\n\n" and "\r\n\r\n") for separating header data from body data because Shockwave still sends the prior format

1:25 PM Changeset in webkit [8049] by mjs

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

11:58 AM Changeset in webkit [8048] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Harrison

Fix some object lifetime issues in these two commands. This fixes some crashes
I am seeing in some new code I am working on, but have not yet reproduced otherwise.

• khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): No longer deref nodes in the ancestor list. They are not ref'ed when put on list. D'uh. (khtml::InsertParagraphSeparatorCommand::doApply): Ref all cloned nodes that are created by the command before putting them on the cloned nodes list. This are still deref'ed in the destructor. (khtml::InsertParagraphSeparatorInQuotedContentCommand::~InsertParagraphSeparatorInQuotedContentCommand): Ditto destructor comment. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto doApply comment.

10:43 AM Changeset in webkit [8047] by kocienda

• 9 edits in trunk

WebCore:

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3655241> setTypingStyle: does not set the real typing style, and typingStyle does not return it

• khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle): New helper that does the work of reducing a passed-in style declaration given the current selection, and then sets the minimum necessary style as the typing style on the part. (KHTMLPart::applyStyle): Call new computeAndSetTypingStyle. The guts of computeAndSetTypingStyle used to be here in the selection-as-caret case. But now [WebCoreBridge setTypingStyle:] needs this code as well.
• khtml/khtml_part.h: Declare new computeAndSetTypingStyle() function.
• kwq/WebCoreBridge.h: Declare new typingStyle and setTypingStyle: methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Calls through to the part to retrieve the typing style. (-[WebCoreBridge setTypingStyle:]): Calls through to the part to set the typing style.

WebKit:

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3655241> setTypingStyle: does not set the real typing style, and typingStyle does not return it

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): No longer call through to WebKit to set the typing style. The call was part of the misguided use of the setTypingStyle: and typingStyle as a cache of what was stored on the WebCore side. (-[WebBridge respondToChangedSelection]): Ditto.
• WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Object no longer has typingStyle ivar. (-[WebView setTypingStyle:]): Call over the bridge to set typing style. (-[WebView typingStyle]): Call over the bridge to retrieve typing style.
• WebView.subproj/WebViewInternal.h: Object no longer has typingStyle ivar.

Nov 18, 2004:

10:08 PM Changeset in webkit [8046] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed <rdar://problem/3886042> should save history file as binary XML so serialization, parsing, reading and writing is faster

• History.subproj/WebHistory.m: (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): convert dictionary to binary data before saving

6:03 PM Changeset in webkit [8045] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

Back out Darin's fix for <rdar://problem/3885729>, because the new exception gets triggered by Mail.app.
Filed <rdar://problem/3886832> against Mail.app.

• kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setProperty:::]):

5:40 PM Changeset in webkit [8044] by cblu

• 2 edits in trunk/WebCore

WebCore:

Fixed: <rdar://problem/3587481> Bug Reporter Login Page: Password AutoFill does not work reliably

Reviewed by john.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentForm): just return the current form, don't scan the entire document looking for a form if there is no current form

WebBrowser:

Fixed: <rdar://problem/3587481> Bug Reporter Login Page: Password AutoFill does not work reliably

Reviewed by john.

• FormCompletionController.m: (+[FormCompletionController firstFormInFrame:]): new, currentForm in WebCore used to do this work, but now currentForm just returns the current form (+[FormCompletionController currentOrFirstFrameAndForm:inWebView:]): renamed, if there is no current form, call firstFormInFrame (+[FormCompletionController autoFillInWebView:]): call renamed method (+[FormCompletionController autoFillPasswordInFrame:]): if there is no current form, find a password form from all the forms in the document rather than giving up when the first form is not a password form

5:10 PM Changeset in webkit [8043] by cblu

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation currentForm]): removed stray ";"

4:49 PM Changeset in webkit [8042] by mjs

• 2 edits in trunk/WebCore

Reviewed by Chris.

• fix recursive item traversal, use traverseNextNode() instead of the buggy hand-rolled traversal.

• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::recursiveItem):

4:12 PM Changeset in webkit [8041] by darin

• 35 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3885744> crash with XMLHttpRequest test page (reported by KDE folks)

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotFinished): Rolled in fix from KDE; make sure to set job to 0 before calling changeState.

• fixed <rdar://problem/3885729> attempting to modify a computed style does nothing, but should raise a DOM exception
• fixed <rdar://problem/3885731> style declarations use too many malloc blocks; switch to QValueList
• fixed <rdar://problem/3885739> DOM::NodeImpl accessor in DOM::Node class is hot; should be inlined
• changed NodeImpl calls like replaceChild to always ref/deref the parameter; this is a better way to fix an entire category of leaks we have been fixing one by one recently
• changed computed styles so they hold a reference to the DOM node; the old code could end up with a stale RenderObject pointer, although I never saw it do that in practice
• implemented the length and item methods for computed styles
• implemented querying additional properties in computed styles (29 more)

• khtml/khtml_part.h: Update forward declaration of CSSMutableStyleDeclarationImpl since it's now a separate class rather than a typedef. Changed the parameter type of setTypingStyle to take a mutable style.
• khtml/khtml_part.cpp: (KHTMLPart::setTypingStyle): Change parameter to take a mutable style. (KHTMLPart::applyStyle): Add code to make a mutable style in case we are passed a computed style; also change some types to mutable style. (updateState): Update iteration of CSSProperty objects in a style declaration to use the new valuesIterator interface. (KHTMLPart::selectionHasStyle): Add a call to makeMutable. (KHTMLPart::selectionStartHasStyle): Add call to makeMutable and update iteration. (editingStyle): Change type to mutable style, and simplify the style-creation calls, including accomodating the exception code that setCssText has now. (KHTMLPart::applyEditingStyleToElement): Change types to mutable style. (KHTMLPart::removeEditingStyleFromElement): Change code to call setChanged only if removing the style attributes really was a change, although it's not an important optimization it's good to do it right.

• khtml/css/css_base.h: Remove unneeded setParsedValue method.
• khtml/css/css_base.cpp: Remove unneeded setParsedValue method. All the places that were calling it were already removing the old property explicitly, so the code in here to remove the property again was redundant.

• khtml/css/css_computedstyle.h: Updated virtual functions for changes to parameters in base class. Moved all the "set"-type functions so they are private. Store a node pointer instead of a renderer.
• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): Hold a reference to the node we compute style for, so we don't end up with a pointer to a deallocated RenderObject. Before we had no guarantee the object would outlast us. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Add exception parameter, and set the exception to NO_MODIFICATION_ALLOWED_ERR. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Update to use node pointer rather than renderer pointer. Added implementation for box-align, box-direction, box-flex, box-flex-group, box-lines, box-ordinal-group, box-orient, box-pack, caption-side, clear, cursor, direction, list-style-image, list-style-position, list-style-type, marquee-direction, marquee-repetition, marquee-style, user-modify, opacity, orphans, outline-style, page-break-after, page-break-before, page-break-inside, position, unicode-bidi, widows, z-index. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Add exception parameter, and set the exception to NO_MODIFICATION_ALLOWED_ERR. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::length): Implemented. (DOM::CSSComputedStyleDeclarationImpl::item): Implemented, calls getPropertyValue. (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties): Changed return type to CSSMutableStyleDeclarationImpl. (DOM::CSSComputedStyleDeclarationImpl::copy): Added. (DOM::CSSComputedStyleDeclarationImpl::makeMutable): Added.

• khtml/css/css_ruleimpl.h: Update forward declaration of CSSMutableStyleDeclarationImpl since it's now a separate class rather than a typedef.
• khtml/css/cssparser.h: Ditto.

• khtml/css/css_valueimpl.h: Refactor CSSStyleDeclarationImpl into two classes. New derived class CSSMutableStyleDeclarationImpl has the guts, and the base class has only some virtual functions. Removed a bunch of redundant stuff from other classes in this file too. (DOM::DashboardRegionImpl::setNext): Ref new before deref'ing old to handle the set-to-same case. (DOM::CSSProperty::CSSProperty): Added new overload so you can create a CSSProperty with initial values. (DOM::CSSProperty::operator=): Added. (DOM::CSSProperty::setValue): Use ref-before-deref pattern to simplify slightly.

• khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::CSSStyleDeclarationImpl): Remove uneeded things. (DOM::CSSStyleDeclarationImpl::isStyleDeclaration): Put here now that it's no longer inline. (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl): Added. (DOM::CSSMutableStyleDeclarationImpl::operator=): Added. (DOM::CSSMutableStyleDeclarationImpl::~CSSMutableStyleDeclarationImpl): Updated. (DOM::CSSMutableStyleDeclarationImpl::getPropertyValue): Removed now-uneeded check. (DOM::CSSMutableStyleDeclarationImpl::get4Values): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue): Ditto. (DOM::CSSMutableStyleDeclarationImpl::getPropertyCSSValue): Update to use QValueList instead of QPtrList. (DOM::CSSMutableStyleDeclarationImpl::removeProperty): Added exception parameter, updated for QValueList. (DOM::CSSMutableStyleDeclarationImpl::setChanged): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setProperty): Added more overloads to match new parameters. (DOM::CSSMutableStyleDeclarationImpl::setStringProperty): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setImageProperty): Ditto. (DOM::CSSMutableStyleDeclarationImpl::parseProperty): Remove unneeded initialization code due to QValueList. (DOM::CSSMutableStyleDeclarationImpl::addParsedProperties): Added. (DOM::CSSMutableStyleDeclarationImpl::setLengthProperty): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::length): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::item): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::cssText): Return empty string rather than null string when there are no styles in the list. Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setCssText): Update to use QValueList and to take an exceptionCode parameter and set it. (DOM::CSSMutableStyleDeclarationImpl::merge): Update to use QValueList. (DOM::CSSStyleDeclarationImpl::diff): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::copyBlockProperties): Moved here from base class. Change return type. (DOM::CSSStyleDeclarationImpl::copyPropertiesInSet): Update to use QValueList and use stack, not new/delete. (DOM::CSSMutableStyleDeclarationImpl::makeMutable): Added. (DOM::CSSMutableStyleDeclarationImpl::copy): Added.

• khtml/css/cssparser.cpp: (CSSParser::parseValue): Changed to use addParsedProperties. (CSSParser::parseDeclaration): Ditto. (CSSParser::createStyleDeclaration): Use new constructor to create declaration in a more efficient manner.

• khtml/css/cssproperties.in: Removed unused font-size-adjust and -khtml-flow-mode.
• khtml/css/cssproperties.c: Regenerated.
• khtml/css/cssproperties.h: Regenerated.

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): Updated to use QValueList interface to CSSMutableStyleDeclarationImpl.

• khtml/dom/css_value.cpp: (DOM::CSSStyleDeclaration::cssText): Removed unneeded cast. (DOM::CSSStyleDeclaration::setCssText): Added exception code handling. (DOM::CSSStyleDeclaration::getPropertyValue): Changed to call getPropertyValue directly instead of first doing getPropertyCSSValue and then doing cssText. (DOM::CSSStyleDeclaration::getPropertyCSSValue): Removed unneeded cast. (DOM::CSSStyleDeclaration::removeProperty): Added exception code handling. (DOM::CSSStyleDeclaration::setProperty): Added exception code handling. (DOM::CSSStyleDeclaration::length): Removed unneeded cast. (DOM::CSSStyleDeclaration::item): Removed unneeded cast. (DOM::CSSStyleDeclaration::parentRule): Removed unneeded cast. (DOM::CSSValue::setCssText): Removed strange non-implementation (still not implemented).

• khtml/dom/dom_node.h: Made isNull and handle functions inline.
• khtml/dom/dom_node.cpp: Ditto.

• khtml/editing/htmlediting.h: Change some types to mutable style.
• khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::typingStyle): Change return type to mutable style. (khtml::EditCommandPtr::setTypingStyle): Change parameter to mutable style. (khtml::StyleChange::init): Convert parameter to mutable style. Update to use QValueList. (khtml::EditCommand::assignTypingStyle): Change parameter to mutable type. (khtml::EditCommand::setTypingStyle): Ditto. (khtml::ApplyStyleCommand::ApplyStyleCommand): Convert parameter to mutable style. (khtml::ApplyStyleCommand::doApply): Change local variables to mutable style. (khtml::ApplyStyleCommand::applyBlockStyle): Change parameter to mutable style. (khtml::ApplyStyleCommand::applyInlineStyle): Ditto. (khtml::ApplyStyleCommand::isHTMLStyleNode): Ditto. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. Also update to use QValueList. (khtml::ApplyStyleCommand::removeBlockStyle): Change parameter to mutable style. (khtml::ApplyStyleCommand::removeInlineStyle): Ditto. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::InsertLineBreakCommand::doApply): Convert locals to mutable style. (khtml::InsertTextCommand::prepareForTextInsertion): Ditto. (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Convert parameter to mutable style.

• khtml/editing/jsediting.cpp: Convert types to mutable styles where we create styles.
• khtml/html/html_baseimpl.h: Change type to mutable style.
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::createLinkDecl): Ditto.

• khtml/html/html_elementimpl.h: Make CSSMappedAttributeDeclarationImpl use the mutable style class as a base class, and change types to mutable style as needed.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createInlineStyleDecl): Change type to mutable style. (HTMLElementImpl::parseHTMLAttribute): Call parseProperty method. (HTMLElementImpl::getInlineStyleDecl): Change type to mutable style. (HTMLElementImpl::additionalAttributeStyleDecl): Ditto. (HTMLElementImpl::createContextualFragment): Add ref/deref to fix potential node leak. (HTMLElementImpl::setInnerHTML): Remove ref/deref pair because this leak is now fixed by changes to appendChild. (HTMLElementImpl::setOuterHTML): Remove ref/deref pair because this leak is now fixed by changes to replaceChild.

• khtml/html/html_tableimpl.h: Change types to mutable style.
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::additionalAttributeStyleDecl): Change type to mutable style. (HTMLTableElementImpl::getSharedCellDecl): Change type to mutable style. (HTMLTableCellElementImpl::additionalAttributeStyleDecl): Change type to mutable style.

• khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): Use a local variable to protect the node by ref'ing it. This is better than using an explicit delete to make the node go away, and is required for compatibility with the changes to the NodeImpl functions. (KHTMLParser::insertNode): Ditto. (KHTMLParser::createHead): Get rid of explicit delete, no longer needed because of changes to the NodeImpl functions.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createCSSStyleDeclaration): Call simpler constructor now that there's no need to make the property list explictly.

• kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setCssText:]): Raise exception when appropriate. (-[DOMCSSStyleDeclaration removeProperty:]): Ditto. (-[DOMCSSStyleDeclaration setProperty:::]): Dito.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::insertBefore): Always do a ref/deref, so callers don't have to worry about whether the function succeeded or not for ownership purposes. (NodeImpl::replaceChild): Ditto. (NodeImpl::appendChild): Ditto. (NodeBaseImpl::insertBefore): Ditto. (NodeBaseImpl::replaceChild): Ditto. (NodeBaseImpl::appendChild): Ditto. (NodeBaseImpl::addChild): Ditto.

• WebCore-tests.exp: Removed CSSStyleDeclaration::length; not sure why it was in here.
• WebCore-combined.exp: Regenerated.

4:08 PM Changeset in webkit [8040] by mjs

• 2 edits in trunk/WebCore

still even more build fixing

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::resetCollectionInfo):

3:09 PM Changeset in webkit [8039] by mjs

• 2 edits in trunk/WebCore

more build fixing

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::resetCollectionInfo):

2:38 PM Changeset in webkit [8038] by mjs

• 2 edits in trunk/WebCore

Fixed build problem.

• khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo): it's haslength, not hasLenght.

1:42 PM Changeset in webkit [8037] by mjs

• 12 edits in trunk/WebCore

Reviewed by Ken.

• merged and cleaned up HTMLCollection and HTMLFormCollection speedups from konqueror

<rdar://problem/3822992> VIP: Program listings pages at directv.com take a really long time to load [HTMLCollection]
<rdar://problem/3701991> Safari unresponsive loading (www.maxim-ic.com) (HTMLCollection)

This is also a start on fixing 5 other bugs, but those need additional work to make
HTMLFormCollection fast.

• khtml/html/html_documentimpl.h: (DOM::HTMLDocumentImpl::collectionInfo):
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): (DOM::HTMLFormElementImpl::isURLAttribute): (DOM::HTMLFormElementImpl::registerImgElement): (DOM::HTMLFormElementImpl::removeImgElement):
• khtml/html/html_formimpl.h:
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLImageElementImpl::~HTMLImageElementImpl):
• khtml/html/html_imageimpl.h:
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::HTMLCollectionImpl): (HTMLCollectionImpl::~HTMLCollectionImpl): (HTMLCollectionImpl::updateCollectionInfo): (HTMLCollectionImpl::length): (HTMLCollectionImpl::item): (HTMLCollectionImpl::firstItem): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::nextNamedItemInternal): (HTMLFormCollectionImpl::getNamedFormItem):
• khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::): (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::incDOMTreeVersion): (DOM::DocumentImpl::domTreeVersion):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::attach): (NodeImpl::detach):

12:50 PM Changeset in webkit [8036] by cblu

• 2 edits in trunk/WebKit

Fixed development build failure.

• Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): call LOG not Log

11:29 AM Changeset in webkit [8035] by kdecker

• 2 edits in trunk/WebCore

Reviewed by Chris.

fixed: <rdar://problem/3841842> getPropertyID expensive

• kwq/DOM-CSS.mm: (getPropertyID): avoid unnecessary memory allocations by using a fixed-sized stack based buffer.

10:20 AM Changeset in webkit [8034] by cblu

• 2 edits in trunk/WebKit

<rdar://problem/3885708> save memory in icon DB by not using NSSets when holding 1 object

Reviewed by sullivan.

• Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): added timing code (-[WebIconDatabase _clearDictionaries]): new (-[WebIconDatabase _loadIconDictionaries]): call _clearDictionaries in 2 places before we bail, use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary (-[WebIconDatabase _updateFileDatabase]): fixed comment (-[WebIconDatabase _setIconURL:forURL:]): use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary (-[WebIconDatabase _releaseIconForIconURLString:]): handle NSString objects retured from iconURLToURLs (-[NSMutableDictionary _web_setObjectUsingSetIfNecessary:forKey:]): new, puts a set on the dictionary when there are 2 or more object for s key

Nov 17, 2004:

7:20 PM Changeset in webkit [8033] by rjw

• 4 edits in trunk/WebKit

Fixed <rdar://problem/3885073> REGRESSION: Tab images at top of news.com.com replicated and squished

Correctly account for scaled image size and clipping.

Reviewed by Maciej.

• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m:
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

6:48 PM Changeset in webkit [8032] by mjs

• 2 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3885076> Don't make IDN calls for all-ascii URLs to save about 3 pages
at Safari startup.

• Misc.subproj/WebNSURLExtras.m: (mapHostNames): If encoding and not decoding, then bail early if the URL is all ascii. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Remove earlier special-case check for localhost, no longer needed.

5:42 PM Changeset in webkit [8031] by hyatt

• 9 edits in trunk/WebCore

Improve responsiveness by being willing to break out of the tokenizer. (This patch was landed already
and subsequently backed out).

Reviewed by kocienda

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument):
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::notifyFinished):
• khtml/html/htmltokenizer.h:
• khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::clear): (KHTMLView::layout): (KHTMLView::timerEvent): (KHTMLView::scheduleRelayout): (KHTMLView::layoutPending): (KHTMLView::haveDelayedLayoutScheduled): (KHTMLView::unscheduleRelayout):
• khtml/khtmlview.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::close): (DocumentImpl::setParsing): (DocumentImpl::shouldScheduleLayout): (DocumentImpl::minimumLayoutDelay): (DocumentImpl::write): (DocumentImpl::finishParsing): (DocumentImpl::stylesheetLoaded): (DocumentImpl::updateStyleSelector):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::parsing):
• kwq/KWQDateTime.mm: (KWQUIEventTime::uiEventPending):

4:35 PM Changeset in webkit [8030] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

Make sure previousLineStart is non-null before calling compareBoundaryPoints.
Treat null case as meaning no post-move merge is needed.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):

3:02 PM Changeset in webkit [8029] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3863601> Legacy font cache code in [WebTextRendererFactory createSharedFactory] may be unnecesary

and added call to SPI for

<rdar://problem/3884448> WebKit should turn on CG local font cache

currently disabled until a Tiger build shows up with the SPI.

Reviewed by David Harrison.

• WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):

12:31 PM Changeset in webkit [8028] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3882212> REGRESSION: Images clipped instead of scaled
Fixed <rdar://problem/3884088> Crash terminating image load

Also added code to turn off color correction for images created
via CGImageSources. This code is currently disabled because CG
can't change the color space of images loaded progressively.
Further, according to Dave Hayward, CG will no longer attempt
to color correct images that don't have embedded profiles as of
Tiger 8A306.

Reviewed by Chris.

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData _invalidateImageProperties]): (-[WebImageData imageAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:]): (-[WebImageData propertiesAtIndex:]):

11:33 AM Changeset in webkit [8027] by harrison

• 3 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Added displayNode and displayTree methods for debugging. Fixed comment typo in dispatchChildRemovalEvents.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): (NodeImpl::displayTree): (NodeBaseImpl::dispatchChildRemovalEvents):
• khtml/xml/dom_nodeimpl.h:

Nov 16, 2004:

4:17 PM Changeset in webkit [8026] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3882034> REGRESSION: Context menu incorrect for PDF content

Reviewed by darin.

• WebView.subproj/WebPDFView.m: (-[WebPDFView hitTest:]): return self if the current event is a context menu event (-[WebPDFView menuForEvent:]): use the PDFView subview

11:52 AM Changeset in webkit [8025] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Richard.

• fixed <rdar://problem/3881929> 32 byte leak in editingStyle() in KHTMLPart (one-time only)

• khtml/khtml_part.cpp: (editingStyle): delete the list we created when we're done with it

11:04 AM Changeset in webkit [8024]

• 19 copies
  2 deletes in tags/WebCore-85~6~5

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~5'.

11:04 AM Changeset in webkit [8023] by vicki

• 2 edits in branches/Safari-1-0-branch/WebCore

versioning for December Security Update on Jaguar, WebCore-85.6.5

10:54 AM Changeset in webkit [8022] by vicki

• 3 edits in branches/Safari-1-0-branch/WebCore

• changes by Darin, reviewed by Vicki

• Jaguar fix for 3867082: Safari URL status bar spoofing using nested <a> links in a table

• khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint):
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):

8:48 AM Changeset in webkit [8021] by kocienda

• 3 edits in trunk/WebCore

Reviewed by John

It is unwise to use the QPtrList autodelete feature on shared objects like DOM nodes.
Instead, I replaced this with a helper function that derefs DOM nodes stored in a
QPtrList when the list goes out of scope.

• khtml/editing/htmlediting.cpp: (khtml::derefNodesInList): New helper to deref DOM nodes stored in a QPtrList. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): No longer set lists to autodelete. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Call new derefNodesInList helper. (khtml::InsertParagraphSeparatorInQuotedContentCommand::InsertParagraphSeparatorInQuotedContentCommand): No longer set lists to autodelete. (khtml::InsertParagraphSeparatorInQuotedContentCommand::~InsertParagraphSeparatorInQuotedContentCommand): Call new derefNodesInList helper.
• khtml/editing/htmlediting.h: Add virtual destructor for InsertParagraphSeparatorCommand. It had no need of one before, but now it does.

Nov 15, 2004:

5:34 PM Changeset in webkit [8020] by harrison

• 2 edits in trunk/WebCore

Reviewed by Chris and Darin.

<rdar://problem/3880304> Non-linear performance hit for style changes

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): (NodeImpl::traverseNextSibling): (NodeImpl::traversePreviousNodePostOrder): Return 0 rather than traversing beyond stayWithin when this == stayWithin. Add asserts that stayWithin is an ancestor of the returned node.

5:24 PM Changeset in webkit [8019] by rjw

• 4 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3880561> Default string value of ObjC object in JS should be [obj description].

Reviewed by Hyatt.

• bindings/objc/objc_instance.mm: (ObjcInstance::stringValue):
• bindings/objc/objc_utility.h:
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): (KJS::Bindings::convertObjcValueToValue):

5:04 PM Changeset in webkit [8018] by darin

• 6 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3880036> Many leaks from CSSComputedStyleDeclarationImpl::getPropertyCSSValue, seen in Mail and Blot

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Ref and deref the value returned from getPropertyCSSValue, since there's no guarantee it's already ref'd.
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::getPropertyValue): Wrap result in a CSSValue to ref/deref. (CSSStyleDeclarationImpl::get4Values): Ref/deref explicitly. (CSSStyleDeclarationImpl::getShortHandValue): Ditto. (CSSStyleDeclarationImpl::merge): Ditto. (CSSStyleDeclarationImpl::diff): Ditto.
• khtml/editing/htmlediting.cpp: (khtml::StyleChange::currentlyHasStyle): Ditto. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto.
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseHTMLAttribute): Ditto.
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseHTMLAttribute): Ditto.

4:47 PM Changeset in webkit [8017] by darin

• 24 edits in trunk/WebCore

Reviewed by Ken.

Use separate mutable style and computed style types as appropriate.
For now this should have no effect, but it prepares us for refactoring later.
Also remove some unnecessary "DOM::" prefixes and in one case factor out
some shared code.

• khtml/khtml_part.cpp: (KHTMLPart::typingStyle): (KHTMLPart::setTypingStyle): (updateState): (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle):
• khtml/khtml_part.h:
• khtml/khtmlpart_p.h:

• khtml/css/css_base.h:
• khtml/css/css_ruleimpl.cpp: (CSSStyleRuleImpl::setDeclaration):
• khtml/css/css_ruleimpl.h: (DOM::CSSFontFaceRuleImpl::style): (DOM::CSSPageRuleImpl::style): (DOM::CSSStyleRuleImpl::style): (DOM::CSSStyleRuleImpl::declaration):
• khtml/css/css_valueimpl.h: (DOM::CSSPrimitiveValueImpl::):
• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseColor): (CSSParser::parseDeclaration): (CSSParser::createStyleDeclaration):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::addMatchedDeclaration): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::applyDeclarations):
• khtml/css/cssstyleselector.h:
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/dom/css_rule.h:
• khtml/dom/css_stylesheet.h:
• khtml/dom/css_value.h:
• khtml/dom/dom2_views.cpp:
• khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): (DocumentImpl::setStyleSheet):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::setStyleSheet):
• khtml/xml/dom_xmlimpl.h:

• khtml/dom/css_value.cpp: (DOM::throwException): Added. (DOM::CSSStyleDeclaration::setCssText): Call throwException, but always on 0 for now. The real thing is coming with the next change to refactor. (DOM::CSSPrimitiveValue::setFloatValue): Call throwException. (DOM::CSSPrimitiveValue::setStringValue): Ditto.

4:29 PM Changeset in webkit [8016] by darin

• 4 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3878489> REGRESSION: modifying attribute of <textarea> blows away edited text (breaks simplemachines.org forum)

• khtml/xml/dom_nodeimpl.h: Added boolean "children changed" parameter to dispatchSubtreeModifiedEvent, so it can be called in cases where only the node's attributes changed without sending a misleading childrenChanged call, but the childrenChanged call can happen at the exact right moment.
• khtml/xml/dom_nodeimpl.cpp: Removed some uneeded "DOM::". (NodeImpl::dispatchSubtreeModifiedEvent): Only call "children changed" if the boolean true is passed in.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::addAttribute): Pass false for "children changed". (NamedAttrMapImpl::removeAttribute): Ditto.

4:25 PM Changeset in webkit [8015] by cblu

• 6 edits in trunk/WebKit

Fixed: <rdar://problem/3880410> save 5 dirty pages by soft-linking against PDFKit framework

Reviewed by john.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebPDFRepresentation.m: (+[WebPDFRepresentation PDFDocumentClass]): new (-[WebPDFRepresentation finishedLoadingWithDataSource:]): use PDFDocumentClass
• WebView.subproj/WebPDFView.h:
• WebView.subproj/WebPDFView.m: (+[WebPDFView PDFKitBundle]): new (+[WebPDFView PDFViewClass]): new (-[WebPDFView initWithFrame:]): create a PDFView subview (-[WebPDFView dealloc]): release the PDFView subview (-[WebPDFView PDFSubview]): new

3:36 PM Changeset in webkit [8014] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3879891> WebKit should link against PDFKit instead of Quartz

Reviewed by darin.

• WebKit.pbproj/project.pbxproj: link against PDFKit if it is present instead of Quartz.framework

2:52 PM Changeset in webkit [8013]

• 71 copies
  2 deletes in tags/WebCore-125~8~11

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~11'.

2:52 PM Changeset in webkit [8012] by vicki

• 2 edits in branches/Safari-1-2-branch/WebCore

versioning for December Security Update, WebCore-125.8.11

2:08 PM Changeset in webkit [8011] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3880075> leak in CSSStyleDeclarationImpl::copyPropertiesInSet, seen often in Mail and Blot

• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::copyPropertiesInSet): delete temporary list after we're done using it

12:33 PM Changeset in webkit [8010] by rjw

• 2 edits in trunk/WebCore

Fixed leak (3879883) that John found. Early return leaked
allocated instance.

Reviewed by John.

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):

12:29 PM Changeset in webkit [8009] by rjw

• 3 edits in trunk/WebKit

Fixed missing retain of image property data.

Reviewed by John.

• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData dealloc]): (-[WebImageData _invalidateImages]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _frameDuration]):

11:53 AM Changeset in webkit [8008] by kocienda

• 4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3879569> Many leaks in EditCommand mechanism, seen in Mail

Fixed a couple of object lifetime issues. The EditCommand class used to hold an
EditCommandPtr to its parent, but this caused a a reference cycle in composite
commands as the children held a ref to their parent. Now, the parent variable
is a non-retained reference to an EditCommand *. It would be nice to have a
weak reference to the parent or even override deref in composite commands (but I
can't since deref() is not virtual). However, this should be OK since any
dangling parent pointer is a sign of a bigger object lifetime problem that
would need to be addressed anyway.

• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::CSSStyleDeclarationImpl): Fix bug in constructor that takes a QPtrList<CSSProperty> *. List values must be copied into newly-allocated list, rather than just assigning the list variable passed in to the local list variable, or the list will be double-deleted.
• khtml/editing/htmlediting.cpp: (khtml::EditCommand::setStartingSelection): No longer call get(). m_parent is no longer a smart pointer. (khtml::EditCommand::setEndingSelection): Ditto. (khtml::EditCommand::assignTypingStyle): Short-circuit if passed in style is identical to current style. Unrelated to the change, but saves some ref's and deref's. (khtml::EditCommand::setTypingStyle): No longer call get(). m_parent is no longer a smart pointer.
• khtml/editing/htmlediting.h: Change m_parent to a EditCommand *. Was an EditCommandPtr. Using an EditCommandPtr caused a reference cycle in composite commands as the children held a ref to their parent. (khtml::EditCommand::parent): No longer call get(). m_parent is no longer a smart pointer.

11:50 AM Changeset in webkit [8007] by mjs

• 3 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3807080> Safari so slow it seems like a hang accessing a page on an IBM website

• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::NodeListImpl): Initialize isItemCacheValid, renamed isCacheValid to isLengthCacheValid. (NodeListImpl::recursiveLength): Adjusted for rename. (NodeListImpl::recursiveItem): Cache the last item accessed and its offset. If the same offset is looked up again, just return it, otherwise, if looking up a later offset, start at the last item and proceed from there. (NodeListImpl::itemById): Apply the special document optimization to all nodes that are either a document or in a document - just walk up to make sure the node found by ID has the root node as an ancestor. (NodeListImpl::rootNodeSubtreeModified): Adjust both cache bits.
• khtml/xml/dom_nodeimpl.h: Prototype new stuff.

11:16 AM Changeset in webkit [8006] by rjw

• 5 edits in trunk/WebKit

Cache image properties and frame durations.
Create NSImage and TIFF representations from CGImage, lazily, as needed for
dragging and element info dictionary.

Reviewed by John.

• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData dealloc]): (-[WebImageData size]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _frameDuration]):
• WebCoreSupport.subproj/WebImageRenderer.h:
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): (-[WebImageRenderer TIFFRepresentation]): (-[WebImageRenderer image]):

10:53 AM Changeset in webkit [8005] by mjs

• 3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3879226> WebKit needlessly uses extra memory to store icon refcounts as NSNumbers

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForURL:]): (-[WebIconDatabase _releaseFutureIconForURL:]):
• Misc.subproj/WebIconDatabasePrivate.h:

9:20 AM Changeset in webkit [8004] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3879539> leak of NSString after pasting into editable HTML (e.g. Mail)

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentFragmentWithText): release mutable copy of string after we're done using it

8:54 AM Changeset in webkit [8003] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Ken.

• fixed <rdar://problem/3879513> leak in [WebArchive _propertyListRepresentation] copying HTML to pasteboard

• WebView.subproj/WebArchive.m: (-[WebArchive _propertyListRepresentation]): the array holding the subresources was not released after use, oops!

Nov 14, 2004:

9:18 PM Changeset in webkit [8002] by kdecker

• 2 edits in trunk/WebCore

Reviewed by mjs.

fixed: <rdar://problem/3823038> LEAK: huge leak in DOM::HTMLElementImpl::createContextualFragment(DOM::DOMString const&, bool)

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setInnerHTML): uses the ref counting system to deallocate fragments instead of explicitly invoking a destructor. (HTMLElementImpl::setOuterHTML): function is responsible for derefing the fragment prior to returning. Now it does.

Nov 13, 2004:

6:07 PM Changeset in webkit [8001] by mjs

• 6 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3878766> VIP: Program listings pages at directv.com takes 75% of time traversing NodeLists

• khtml/dom/dom_node.cpp: (NodeList::itemById): New method, just forward to impl.
• khtml/dom/dom_node.h: Prototype it.
• khtml/ecma/kjs_dom.cpp: (DOMNodeList::tryGet): Instead of looping over the whole list to do by-id access, let the NodeList do it. The NodeList might be able to do it more efficiently.
• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::itemById): Optimize for the case where the NodeList covers the whole document. In this case, just use getElementById, then check that the element satisfies the list criteria. (ChildNodeListImpl::nodeMatches): Return true only if the node is our child. (TagNodeListImpl::TagNodeListImpl): Irrelevant change to reformat initializers.
• khtml/xml/dom_nodeimpl.h:

Nov 12, 2004:

6:54 PM Changeset in webkit [8000] by mjs

• 2 edits in trunk/WebCore

Reviewed by Gramps.

• fixed another bug in the last checkin, isCacheValid was unitialized, resulting in sometimes using a huge bogus length value.

• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::NodeListImpl): Initialize isCacheValid.

6:53 PM Changeset in webkit [7999] by mjs

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by NOBODY (OOPS!).

• fixed another bug in the last checkin, isCacheValid was unitialized, resulting in sometimes using a huge bogus length value.

• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::NodeListImpl): Initialize isCacheValid.

6:12 PM Changeset in webkit [7998] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed an infinite loop in that last check-in

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::notifyLocalNodeListsSubtreeModified): Added a ++i to the loop so it won't get stuck on the first element in the list.

5:12 PM Changeset in webkit [7997] by mjs

• 3 edits in trunk/WebCore

Reviewed by Kevin.

• fixed <rdar://problem/3878183> Safari is 77% slower than it should be on a page on an IBM website due to NodeListImpl length

I fixed this by changing NodeLists to cache their length, but
invalidate it whenever there is a change in the DOM subtree at
which they are rooted. This makes NodeListImpl::recursiveLength()
drop completely off the profile, since we were repeatedly getting
a length for the same NodeList over and over.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::~NodeImpl): (NodeImpl::registerNodeList): (NodeImpl::unregisterNodeList): (NodeImpl::notifyLocalNodeListsSubtreeModified): (NodeImpl::notifyNodeListsSubtreeModified): (NodeImpl::dispatchSubtreeModifiedEvent): (NodeListImpl::NodeListImpl): (NodeListImpl::~NodeListImpl): (NodeListImpl::recursiveLength): (NodeListImpl::recursiveItem): (NodeListImpl::rootNodeSubtreeModified): (ChildNodeListImpl::ChildNodeListImpl): (ChildNodeListImpl::length): (ChildNodeListImpl::item): (TagNodeListImpl::TagNodeListImpl): (TagNodeListImpl::length): (TagNodeListImpl::item): (NameNodeListImpl::NameNodeListImpl): (NameNodeListImpl::length): (NameNodeListImpl::item):
• khtml/xml/dom_nodeimpl.h:

2:04 PM Changeset in webkit [7996] by darin

• 12 edits in trunk/WebCore

Reviewed by Maciej.

• various small cleanups

• khtml/xml/dom_docimpl.h: Added policyBaseURL and setPolicyBaseURL.
• khtml/html/html_documentimpl.h: Removed policyBaseURL and setPolicyBaseURL.

• khtml/xml/xml_tokenizer.h: Marked isWaitingForScripts const.
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::isWaitingForScripts): Marked const.
• khtml/html/htmltokenizer.h: Marked isWaitingForScripts const.
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::isWaitingForScripts): Marked const. (khtml::HTMLTokenizer::setOnHold): Took out extraneous line of code.

• khtml/khtml_part.h: Removed docImpl function.
• khtml/khtml_part.cpp: Ditto.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Simplified code that implements the "redirect during onload" optimization. Now uses isScheduledLocationChangePending.

• kwq/KWQKHTMLPart.h: Removed now-unused _firstResponderAtMouseDownTime.
• kwq/KWQKHTMLPart.mm: Removed _firstResponderAtMouseDownTime (forgot to land this part of the change last time, which is why the build broke). (KWQKHTMLPart::updatePolicyBaseURL): Use xmlDocImpl instead of docImpl. (KWQKHTMLPart::setPolicyBaseURL): Ditto. (KWQKHTMLPart::keyEvent): Ditto. (KWQKHTMLPart::dispatchCPPEvent): Ditto. (KWQKHTMLPart::bodyBackgroundColor): Ditto.

12:49 PM Changeset in webkit [7995] by cblu

• 2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3874577> Opening restricted (parental) content in new window/tab reveals Safari's "Resources" folder

Reviewed by john.

• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openFrameInNewWindow:]): use the unreachable URL if there is one

WebBrowser:

Fixed: <rdar://problem/3874577> Opening restricted (parental) content in new window/tab reveals Safari's "Resources" folder

Reviewed by john.

• ContextMenuHandler.m: (-[BrowserWebView openFrameInNewTab:]): use the unreachable URL if there is one

12:19 PM Changeset in webkit [7994] by cblu

• 2 edits in trunk/WebCore

<rdar://problem/3843312> REGRESSION: Tabbing into content area puts insertion point at start, should go to where it last was

Reviewed by rjw.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): only blow away selection when another view is focused

12:06 PM Changeset in webkit [7993] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (171+)

12:00 PM Changeset in webkit [7992]

• 2 copies in tags/Safari-171

This commit was manufactured by cvs2svn to create tag 'Safari-171'.

12:00 PM Changeset in webkit [7991] by vicki

• 6 edits in trunk

Safari-171 stamp

10:35 AM Changeset in webkit [7990] by darin

• 2 edits in trunk/WebCore

Reviewed by Kevin.

• fixed a couple places that would not work for XML documents

• khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Use xmlDocImpl instead of docImpl, since the function we're using is present on the base class. (WindowFunc::tryCall): More of the same.

9:58 AM Changeset in webkit [7989] by darin

• 8 edits in trunk/WebCore

• land versions of these files generated by the newer gperf

People building on Panther will continue to see these files modified.
A workaround would be to install the newer gperf on our Tiger build machines.

• khtml/css/cssproperties.c: Regenerated.
• khtml/css/cssvalues.c: Regenerated.
• khtml/html/doctypes.cpp: Regenerated.
• khtml/html/kentities.c: Regenerated.
• khtml/misc/htmlattrs.c: Regenerated.
• khtml/misc/htmltags.c: Regenerated.
• kwq/KWQColorData.c: Regenerated.

Nov 11, 2004:

6:55 PM Changeset in webkit [7988] by rjw

• 2 edits in trunk/WebKit

Report actual size (not partial size) but use partial size
when drawing.

Reviewed by Maciej.

• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData size]):

6:22 PM Changeset in webkit [7987] by rjw

• 2 edits in trunk/WebCore

Fix build horkage from previous checkin.

• kwq/KWQKHTMLPart.h:

5:49 PM Changeset in webkit [7986] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3846152> REGRESSION (125-166): can't drag text out of <input type=text> fields

• kwq/WebCoreBridge.h: Added wasFirstResponderAtMouseDownTime: method.

• kwq/KWQKHTMLPart.h: Removed _firstResponderAtMouseDownTime.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Use the new wasFirstResponderAtMouseDownTime: method on the bridge instead of _firstResponderAtMouseDownTime. This will return YES for the case where we started with the NSTextField as first responder, and then took focus away and gave it back, which makes dragging text work again. (KWQKHTMLPart::mouseDown): Removed code to set _firstResponderAtMouseDownTime.

5:29 PM Changeset in webkit [7985] by darin

• 5 edits in trunk/WebKit

Reviewed by John.

• added _wasFirstResponderAtMouseDownTime method to bridge so we can fix <rdar://problem/3846152> REGRESSION (125-166): can't drag text out of <input type=text> fields with a subsequent change to WebCore.

• WebCoreSupport.subproj/WebBridge.m: (wasFirstResponderAtMouseDownTime:): Added. Calls _wasFirstResponderAtMouseDownTime on the WebHTMLView. (_getPreSmartSet): Move global inside the function, add (void) for cleanliness. (_getPostSmartSet): Ditto.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): Release firstResponderAtMouseDownTime. (-[WebHTMLView _setMouseDownEvent:]): Early exit if event is not changing. Set firstResponderAtMouseDownTime to the first responder. (-[WebHTMLView mouseDown:]): Release firstResponderAtMouseDownTime after handling the mouseDown event. (-[WebHTMLView _wasFirstResponderAtMouseDownTime:]): Added. Uses the firstResponderAtMouseDownTime field.
• WebView.subproj/WebHTMLViewInternal.h: Added firstResponderAtMouseDownTime field and _wasFirstResponderAtMouseDownTime method.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

5:11 PM Changeset in webkit [7984] by rjw

• 3 edits in trunk/WebKit

Reviewed by Chris.

Work-around to minimize impact of 3876764. Cache frame durations
after first call. So we'll still leak 1K for each animated
image, but that's better than 1K each time the frame is drawn!

• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _frameDuration]):

Simplified animation cleanup code. Fixed leak due to
incorrect key passed to CFDictionaryRemoveValue.

(+[WebImageData stopAnimationsInView:]):
(-[WebImageData addAnimatingRenderer:inView:]):
(-[WebImageData removeAnimatingRenderer:]):
(-[WebImageData _stopAnimation]):

3:55 PM Changeset in webkit [7983] by hyatt

• 2 edits in trunk/WebCore

Disable the tokenizer deferral, since it hurts the PLT by 3% or so.

Reviewed by vicki

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::continueProcessing):

3:49 PM Changeset in webkit [7982] by kocienda

• 5 edits in trunk/WebCore

Reviewed by Maciej

• khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Use new isLastVisiblePositionInBlock() helper instead of old isLastInBlock() member function on VisiblePosition. This is a cosmetic change in keeping with the prevailing style for the VisiblePosition class.
• khtml/editing/htmlediting.h: Move isLastVisiblePositionInNode() function to visible_position.[cpp|h] files.
• khtml/editing/visible_position.cpp: Removed isLastInBlock() helper. Renamed to isLastVisiblePositionInBlock(). (khtml::visiblePositionsInDifferentBlocks): New helper method. (khtml::isLastVisiblePositionInBlock): Ditto. (khtml::isLastVisiblePositionInNode): Ditto.
• khtml/editing/visible_position.h: Add declarations for new functions.

3:15 PM Changeset in webkit [7981] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): Call new compareBoundaryPoints convenience. (khtml::ApplyStyleCommand::removeBlockStyle): Ditto. (khtml::ApplyStyleCommand::removeInlineStyle): Ditto. (khtml::ApplyStyleCommand::nodeFullySelected): Ditto. (khtml::DeleteSelectionCommand::initializePositionData): Ditto.
• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::compareBoundaryPoints): New convenience variant of this function which takes two Position objects.
• khtml/xml/dom2_rangeimpl.h: Ditto.

2:59 PM Changeset in webkit [7980] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• fixed <rdar://problem/3605906> Flash scrolled off the top and bottom cause CPU spin when combined with something dirty on the visible part of the page

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Work around AppKit bug by using rectangles from getRectsBeingDrawn:count: instead of using the passed-in rectangle.

2:23 PM Changeset in webkit [7979] by kocienda

• 4 edits
  24 adds in trunk

Reviewed by Harrison

Some improvements to deleting when complete lines are selected.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Detect when the line containing the end of a selection is fully selected. Turn off block merging in this case. (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete): Fix a bug in the check for whether a BR immediately followed a block. The old code could erroneously skip nodes. (khtml::DeleteSelectionCommand::handleGeneralDelete): Add a case for when the entire start block is selected. This new code will now delete this block in one call, rather than iterating over each child.
• khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines): New helper called in initializePositionData() to do the work mentioned above in the comment for that function. (khtml::isFirstVisiblePositionOnLine): Ditto. (khtml::isLastVisiblePositionOnLine): Ditto.
• khtml/editing/visible_position.h: Add new functions.
• layout-tests/editing/deleting/delete-line-001-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-001.html: Added.
• layout-tests/editing/deleting/delete-line-002-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-002.html: Added.
• layout-tests/editing/deleting/delete-line-003-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-003.html: Added.
• layout-tests/editing/deleting/delete-line-004-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-004.html: Added.
• layout-tests/editing/deleting/delete-line-005-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-005.html: Added.
• layout-tests/editing/deleting/delete-line-006-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-006.html: Added.
• layout-tests/editing/deleting/delete-line-007-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-007.html: Added.
• layout-tests/editing/deleting/delete-line-008-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-008.html: Added.
• layout-tests/editing/deleting/delete-line-009-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-009.html: Added.
• layout-tests/editing/deleting/delete-line-010-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-010.html: Added.
• layout-tests/editing/deleting/delete-line-011-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-011.html: Added.
• layout-tests/editing/deleting/delete-line-012-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-012.html: Added.

1:35 PM Changeset in webkit [7978] by rjw

• 1 edit in trunk/WebKit/ChangeLog

Replaced NOBODY with John.

1:35 PM Changeset in webkit [7977] by rjw

• 2 edits in trunk/WebKit

Work-arounds to make new ImageIO code work correctly. Still
disabled for now. Requires at least Tiger 300. Testing does
show a 3% improvement in PLT tests! That's huge!

Reviewed by NOBODY (OOPS!).

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData imageAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:]): (-[WebImageData isNull]):

10:09 AM Changeset in webkit [7976] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Adele

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Add some comments and a new piece of debugging output.

9:49 AM Changeset in webkit [7975] by kocienda

• 3 edits
  4 adds in trunk

Reviewed by John

Fix for these bugs:

<rdar://problem/3875618> REGRESSION (Mail): Hitting down arrow with full line selected skips line (br case)
<rdar://problem/3875641> REGRESSION (Mail): Hitting down arrow with full line selected skips line (div case)

• khtml/editing/selection.cpp: (khtml::Selection::modifyMovingRightForward): Fixed by juggling the position as the starting point for the next line position when necessary.
• layout-tests/editing/selection/move-3875618-fix-expected.txt: Added.
• layout-tests/editing/selection/move-3875618-fix.html: Added.
• layout-tests/editing/selection/move-3875641-fix-expected.txt: Added.
• layout-tests/editing/selection/move-3875641-fix.html: Added.

7:35 AM Changeset in webkit [7974] by kocienda

• 3 edits in trunk/WebCore

Reviewed by John

Improved some function names, at John's urging. No changes to the
functions themselves.

canPerformSpecialCaseAllContentDelete() --> handleSpecialCaseAllContentDelete()
canPerformSpecialCaseBRDelete() --> handleSpecialCaseBRDelete()
performGeneralDelete() --> handleGeneralDelete()

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleSpecialCaseAllContentDelete) (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete) (khtml::DeleteSelectionCommand::handleGeneralDelete) (khtml::DeleteSelectionCommand::doApply)
• khtml/editing/htmlediting.h

7:28 AM Changeset in webkit [7973] by kocienda

• 3 edits
  2 adds in trunk

Reviewed by John

Updated some layout test results that changed as a result of my last checking.
Added a new test that has been in my tree for a few days.

• layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
• layout-tests/editing/deleting/delete-3800834-fix-expected.txt:
• layout-tests/editing/inserting/insert-3851164-fix-expected.txt: Added.
• layout-tests/editing/inserting/insert-3851164-fix.html: Added.

7:26 AM Changeset in webkit [7972] by kocienda

• 3 edits in trunk/WebCore

Reviewed by John

• khtml/editing/htmlediting.cpp: (khtml::debugNode): New debugging helper. (khtml::DeleteSelectionCommand::initializePositionData): No longer call obsoleted startPositionForDelete() and endPositionForDelete() functions. Just use the m_selectionToDelete object to determine start and end positions for the delete. (khtml::DeleteSelectionCommand::canPerformSpecialCaseAllContentDelete): New function that creates a special case for deleting all the content in a root editable element. (khtml::DeleteSelectionCommand::doApply): Call canPerformSpecialCaseAllContentDelete() function before BR special case and the general case delete functions.
• khtml/editing/htmlediting.h: Updated for changed functions.

Nov 10, 2004:

6:08 PM Changeset in webkit [7971] by kdecker

• 2 edits in trunk/WebCore

Reviewed by mjs.

Fixed <rdar://problem/3875011> DOMNodeList::tryGet() performs unnecessary (and expensive) dom tree traversals. Improved a loop from 2-n-squared to just n-squared.

• khtml/ecma/kjs_dom.cpp: (DOMNodeList::tryGet): Got rid of an unnecessary node traversal.

2:39 PM Changeset in webkit [7970] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3396872> ICONS: icon DB inconsistencies can cause slowness during startup, idle and quit

Reviewed by john.

• Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:]): added logging code
• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): use alloc, init rather than autorelease, retain (-[WebIconDatabase _loadIconDictionaries]): use 1 object for mapping icon URLs to site URLs and vice versa rather than 3. This avoids inconsistencies and is faster. (-[WebIconDatabase _updateFileDatabase]): write 1 object out

2:03 PM Changeset in webkit [7969] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Chris

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Move position adjustments for smart delete from the two functions below to here. There was an unnecessary double calculation of the leading and trailing whitespace positions. Also refined the trailing case so it only acts when the leading position is null (which seems to match TextEdit in my tests). Also removed some unnecessary copying of Position objects. (khtml::DeleteSelectionCommand::startPositionForDelete): Move out smart delete adjustment from here. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto.

11:04 AM Changeset in webkit [7968] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Harrison

(khtml::DeleteSelectionCommand::performGeneralDelete): Add some more comments to
make things more clear.

• khtml/editing/selection.cpp: (khtml::Selection::toRange): Fixed the upstream and downstream calls so that the resulting positions do not cross block boundaries. This was a bug and caused some delete problems when whole blocks were selected. I will be addressing that issue more fully in upcoming changes.

8:58 AM Changeset in webkit [7967] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Harrison

Some cleanups and fixes in upstream and downstream functions.

Removed redundant checks for isBlockFlow() when calling enclosingBlockFlowElement().
Blocks do not need to skip the call to enclosingBlockFlowElement() for fear that the
block's enclosing block will be returned.

Remove code from upstream that confined the serach to block boundaries outside of
the code which runs in the StayInBlock case. This code was redundant, and caused
incorrect results to be returned in the DoNotStayInBlock case.

In downstream, the check for crossing into a new block should use the equivalentDeepPosition()
node, not the the this pointer's node.

• khtml/xml/dom_position.cpp: (DOM::Position::upstream) (DOM::Position::downstream)

Nov 9, 2004:

7:47 PM Changeset in webkit [7966] by hyatt

• 14 edits in trunk/WebCore

Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.

Reviewed by mjs

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopped): (khtml::HTMLTokenizer::processingData): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::allDataProcessed): (khtml::HTMLTokenizer::end): (khtml::HTMLTokenizer::finish): (khtml::HTMLTokenizer::notifyFinished):
• khtml/html/htmltokenizer.h:
• khtml/khtml_part.cpp: (KHTMLPart::slotFinished): (KHTMLPart::end): (KHTMLPart::stop):
• khtml/khtml_part.h: (KHTMLPart::tokenizerProcessedData):
• khtml/khtmlview.cpp:
• khtml/xml/dom_docimpl.cpp:
• khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::stopped): (khtml::Tokenizer::processingData):
• kwq/KWQDateTime.h:
• kwq/KWQDateTime.mm: (QDateTime::secsTo): (KWQUIEventTime::uiEventPending):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tokenizerProcessedData):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge stop]): (-[WebCoreBridge numPendingOrLoadingRequests]): (-[WebCoreBridge doneProcessingData]):

7:46 PM Changeset in webkit [7965] by hyatt

• 3 edits in trunk/WebKit

Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.

Reviewed by mjs

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge tokenizerProcessedData]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource isLoading]):

5:04 PM Changeset in webkit [7964] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3865837> Wrong text style after delete to start of document

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState): Sample computedStyle of m_selectionToDelete.start instead of m_downstreamStart.

4:28 PM Changeset in webkit [7963] by cblu

• 2 edits
  1 add in trunk/JavaScriptCore

Fixed: <rdar://problem/3872724> soft link against JavaVM to save ~2MB RSHRD

Reviewed by rjw.

• ChangeLog:
• JavaScriptCore.pbproj/project.pbxproj: don't link against JavaVM
• bindings/softlinking.c: Added. (loadFramework): new (getFunctionPointer): new (JNI_GetCreatedJavaVMs): load JavaVM if not already loaded, get _JNI_GetCreatedJavaVMs symbol if we don't already have it, call JNI_GetCreatedJavaVMs

1:52 PM Changeset in webkit [7962] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/3872440> NSTimer prematurely released.

Reviewed by Darin.

• kwq/KWQTimer.mm: (QTimer::fire):
• kwq/KWQWidget.mm: (QWidget::paint):

12:57 PM Changeset in webkit [7961] by rjw

• 3 edits in trunk/WebKit

Fixed <rdar://problem/3870964> 8A300: Safari not recognizing a PDF link (it displays raw data)

Add "text/pdf" as an acceptable PDF MIME type.

Reviewed by Chris.

• WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
• WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):

12:52 PM Changeset in webkit [7960] by cblu

• 2 edits in trunk/WebCore

Reviewed by vicki.

• WebCore.pbproj/project.pbxproj: explicitly link against libxml2.2.6.14.dylib since the version number has been bumped

Nov 8, 2004:

7:46 PM Changeset in webkit [7959] by harrison

• 2 edits
  2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3865854> Deleting first line deletes all lines

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::performGeneralDelete): Problem was that the code that deletes fully selected m_downstreamEnd.node() by deleting one of its ancestors, failed to end the loop that deletes all fully selected nodes. Also, fixed this code to clear m_trailingWhitespaceValid. Also removed dead m_endingPosition update because it is handled in calculateEndingPosition now.
• layout-tests/editing/deleting/delete-3865854-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-3865854-fix.html: Added.

4:32 PM Changeset in webkit [7958] by kocienda

• 7 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Now takes flag to control whether comments are added to the DOM.
• khtml/html/html_elementimpl.h: Ditto.
• khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Ditto. (KHTMLParser::getElement): Remove ifdef for comment processing. Replace with flag check.
• khtml/html/htmlparser.h: Add flag to constructor so callers can request comment nodes.
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): Add flag to constructor so callers can request comment nodes. (khtml::HTMLTokenizer::parseComment): Fix code to handle parsing out comment text correctly. There were a couple of indexing errors that resulted in the comment text containing part of the comment markers. (khtml::HTMLTokenizer::processToken): Don't let token id be reset to ID_TEXT if token is a comment.
• khtml/html/htmltokenizer.h: Add flag to constructor so callers can request comment nodes.

4:22 PM Changeset in webkit [7957] by cblu

• 4 edits in trunk/WebCore

Fixed: <rdar://problem/3870907> WebCore unnecessary links against JavaVM and Security

Reviewed by darin.

• WebCore.pbproj/project.pbxproj: stop unnecessary linking
• khtml/html/html_objectimpl.h: don't unnecessarily include JavaVM header
• kwq/KWQKHTMLPart.h: ditto

4:02 PM Changeset in webkit [7956] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3825966> 8A274 Safari crashes closing window: QTimer::fire() with MallocStackLogging and MallocScribble enabled

• kwq/KWQTimer.mm: (QTimer::fire): Rearrange so we don't access the QTimer object after calling code that possibly deletes the QTimer.

11:11 AM Changeset in webkit [7955] by cblu

• 7 edits in trunk

WebCore:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): let the bridge have a crack at the event so that it can swallow the newline if it wants to
• kwq/WebCoreBridge.h:

WebKit:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge control:textView:shouldHandleEvent:]): new
• WebView.subproj/WebFormDelegate.h:
• WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate control:textView:shouldHandleEvent:inFrame:]): new

WebBrowser:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• BrowserWebController.m: (-[FormDelegate control:textView:shouldHandleEvent:inFrame:]): new
• CompletionController.h:
• CompletionController.m: (-[CompletionController handleInsertNewline]): new, factored out from next method (-[CompletionController control:textView:doCommandBySelector:]): call handleInsertNewline
• FormCompletionController.h:
• FormCompletionController.m: (-[FormCompletionController control:textView:shouldHandleEvent:]): new, call handleInsertNewline so that WebCore does not submit the form when a newline is entered

10:31 AM Changeset in webkit [7954] by harrison

• 4 edits in trunk/WebCore

Reviewed by Darin.

Renamed NodeImpl::enclosingNonBlockFlowElement to NodeImpl::enclosingInlineElement, per Hyatt.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement):
• khtml/xml/dom_nodeimpl.h:

Nov 5, 2004:

4:45 PM Changeset in webkit [7953] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3854218> Safari is sometimes really slow because of increased null events to plug-ins

• Plugins.subproj/WebBaseNetscapePluginView.m: reverted null event interval to 0.02

4:36 PM Changeset in webkit [7952] by cblu

• 7 edits in trunk/WebCore

Fixed: <rdar://problem/3838413> REGRESSION (Mail): "Smart" word paste adds spaces before/after special characters

Reviewed by rjw.

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): call isCharacterSmartReplaceExempt on the part to see if a space should be inserted
• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::character): new, returns the character for the position
• khtml/editing/visible_position.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isCharacterSmartReplaceExempt): new, calls the bridge
• kwq/WebCoreBridge.h:

4:36 PM Changeset in webkit [7951] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3838413> REGRESSION (Mail): "Smart" word paste adds spaces before/after special characters

Reviewed by rjw.

• WebCoreSupport.subproj/WebBridge.m: (_getPreSmartSet): copied from AppKit (_getPostSmartSet): ditto (-[WebBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): new

3:31 PM Changeset in webkit [7950] by rjw

• 4 edits in trunk/WebKit

Fixed <rdar://problem/3810702> _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector: ASSERTS when reentered from Xcode's man page viewer

Reviewed by Maciej (a long time ago).

• WebView.subproj/WebFrame.m: (-[WebFrame _loadDataSource:withLoadType:formState:]):

Fixed <rdar://problem/3845307> WebKit needs to export _HIWebViewRegisterClass so HIWebViews can work in Carbon nib files

As suggested in the bug, the fix is to actually call
HIWebViewRegisterClass in WebKitInitForCarbon, rather than
exporting the symbol.

Reviewed by Chris.

• Carbon.subproj/CarbonUtils.m: (WebInitForCarbon):
• Carbon.subproj/HIWebView.m:
• WebKit.pbproj/project.pbxproj:

2:11 PM Changeset in webkit [7949] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (170+)

1:59 PM Changeset in webkit [7948]

• 2 copies in tags/Safari-170

This commit was manufactured by cvs2svn to create tag 'Safari-170'.

1:59 PM Changeset in webkit [7947] by vicki

• 6 edits in trunk

Safari-170 stamp

1:14 PM Changeset in webkit [7946] by rjw

• 2 edits in trunk/WebKit/Carbon.subproj

Backing out change because tree is closed.

12:38 PM Changeset in webkit [7945] by rjw

• 3 edits in trunk/WebKit

Fixed <rdar://problem/3845307> WebKit needs to export _HIWebViewRegisterClass so HIWebViews can work in Carbon nib files

Reviewed by Chris.

• Carbon.subproj/CarbonUtils.m: (WebInitForCarbon):
• Carbon.subproj/HIWebView.m:

10:45 AM Changeset in webkit [7944] by adele

• 4 edits in trunk/WebCore

Reviewed by Darin

Fix for <rdar://problem/3854383> REGRESSION(166-168) input fields show black background when background color is set to transparent
and a workaround for displaying transparent backgrounds for textareas.

• kwq/KWQLineEdit.mm: (QLineEdit::setPalette): If the background color is transparent (we check the alpha value) then we set the background to white
• kwq/KWQTextEdit.mm: (QTextEdit::setPalette): If the background color is transparent then we don't draw the background
• kwq/KWQTextArea.mm: (-[KWQTextArea setDrawsBackground:]): added setDrawsBackground function which calls setDrawsBackground on the super class, on the contentView, and on the textView.

10:00 AM Changeset in webkit [7943] by darin

• 2 edits in trunk/WebKit

Reviewed by Chris.

• fixed <rdar://problem/3857151> Assertion failure in "trackingRectOwner" while moving mouse over Slashdot.org page

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Changed to no longer call addTrackingRect to do the work for consistency with the new method below. Not too much copied and pasted code. (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Added an override for this new method in Tiger. No harm in implementing it on Panther, although it won't be called. (-[WebHTMLView _removeTrackingRects:count:]): Ditto.

Nov 4, 2004:

7:09 PM Changeset in webkit [7942] by hyatt

• 13 edits in trunk/LayoutTests

land updated layout tests for the relpositioned change, the ex unit change, and the text-top vertical-align change

6:59 PM Changeset in webkit [7941] by hyatt

• 9 edits in trunk/WebCore

Fix for relpositioned inlines. This was reviewed a long time ago, but I can't recall who reviewed it (either
darin or ken).

Reviewed by darin or ken

• khtml/rendering/bidi.cpp: (khtml::appendRunsForObject): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
• khtml/rendering/render_box.cpp: (RenderBox::position):
• khtml/rendering/render_box.h: (khtml::RenderBox::staticX): (khtml::RenderBox::staticY):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::convertToLayerCoords):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally):
• khtml/rendering/render_object.h: (khtml::RenderObject::staticX): (khtml::RenderObject::staticY):

Finish turning on XSLT. Make sure child stylesheets can load.

• khtml/xsl/xslt_processorimpl.cpp: (DOM::stylesheetLoadFunc): (DOM::XSLTProcessorImpl::transformDocument):

5:19 PM Changeset in webkit [7940] by hyatt

• 2 edits in trunk/WebKit

Make sure the dominant line direction is properly set for RTL runs so that spaces will reverse.

Change xHeight to measure the ascent of the x glyph, since the xHeight metrics appear to be
totally bogus in both CG and AppKit.

Reviewed by darin

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): (-[WebTextRenderer _createATSUTextLayoutForRun:style:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):

5:18 PM Changeset in webkit [7939] by hyatt

• 15 edits in trunk/WebCore

Implement CSS3 support for multiple backgrounds. Also fix a bug with background propagation so that it only
happens (from the <body> to the root) for HTML documents. Fixed background-position to handle a mixture of
keyword and length values.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::addBackgroundValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseBackgroundColor): (CSSParser::parseBackgroundImage): (CSSParser::parseBackgroundPositionXY): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty): (CSSParser::parseColorFromValue):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::mapBackgroundAttachment): (khtml::CSSStyleSelector::mapBackgroundImage): (khtml::CSSStyleSelector::mapBackgroundRepeat): (khtml::CSSStyleSelector::mapBackgroundXPosition): (khtml::CSSStyleSelector::mapBackgroundYPosition):
• khtml/css/cssstyleselector.h:
• khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgrounds): (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended):
• khtml/rendering/render_box.h:
• khtml/rendering/render_form.cpp: (RenderFieldset::paintBoxDecorations):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder):
• khtml/rendering/render_line.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::updateBackgroundImages): (RenderObject::getVerticalPosition):
• khtml/rendering/render_object.h: (khtml::RenderObject::paintBackgroundExtended):
• khtml/rendering/render_style.cpp: (m_next): (BackgroundLayer::BackgroundLayer): (BackgroundLayer::~BackgroundLayer): (BackgroundLayer::operator=): (BackgroundLayer::operator==): (BackgroundLayer::fillUnsetProperties): (BackgroundLayer::cullEmptyLayers): (StyleBackgroundData::StyleBackgroundData): (StyleBackgroundData::operator==): (RenderStyle::diff): (RenderStyle::adjustBackgroundLayers):
• khtml/rendering/render_style.h: (khtml::OutlineValue::operator==): (khtml::OutlineValue::operator!=): (khtml::BackgroundLayer::backgroundImage): (khtml::BackgroundLayer::backgroundXPosition): (khtml::BackgroundLayer::backgroundYPosition): (khtml::BackgroundLayer::backgroundAttachment): (khtml::BackgroundLayer::backgroundRepeat): (khtml::BackgroundLayer::next): (khtml::BackgroundLayer::isBackgroundImageSet): (khtml::BackgroundLayer::isBackgroundXPositionSet): (khtml::BackgroundLayer::isBackgroundYPositionSet): (khtml::BackgroundLayer::isBackgroundAttachmentSet): (khtml::BackgroundLayer::isBackgroundRepeatSet): (khtml::BackgroundLayer::setBackgroundImage): (khtml::BackgroundLayer::setBackgroundXPosition): (khtml::BackgroundLayer::setBackgroundYPosition): (khtml::BackgroundLayer::setBackgroundAttachment): (khtml::BackgroundLayer::setBackgroundRepeat): (khtml::BackgroundLayer::clearBackgroundImage): (khtml::BackgroundLayer::clearBackgroundXPosition): (khtml::BackgroundLayer::clearBackgroundYPosition): (khtml::BackgroundLayer::clearBackgroundAttachment): (khtml::BackgroundLayer::clearBackgroundRepeat): (khtml::BackgroundLayer::setNext): (khtml::BackgroundLayer::operator!=): (khtml::BackgroundLayer::containsImage): (khtml::BackgroundLayer::hasImage): (khtml::BackgroundLayer::hasFixedImage): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::hasBackground): (khtml::RenderStyle::hasFixedBackgroundImage): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineColor): (khtml::RenderStyle::backgroundColor): (khtml::RenderStyle::backgroundImage): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundAttachment): (khtml::RenderStyle::backgroundXPosition): (khtml::RenderStyle::backgroundYPosition): (khtml::RenderStyle::accessBackgroundLayers): (khtml::RenderStyle::backgroundLayers): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::resetOutline): (khtml::RenderStyle::setBackgroundColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineColor): (khtml::RenderStyle::clearBackgroundLayers): (khtml::RenderStyle::inheritBackgroundLayers): (khtml::RenderStyle::setOutlineOffset):
• khtml/rendering/render_table.cpp: (RenderTable::paintBoxDecorations): (RenderTableCell::paintBoxDecorations):

4:32 PM Changeset in webkit [7938] by hyatt

• 2 edits in trunk/WebCore

Make sure the text decoder returns empty strings rather than null strings when the utf8 char ptr is non-null.
Ensures that <a href=""> works with libxml (which returns data in utf-8 buffers).

Reviewed by darin

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertLatin1): (KWQTextDecoder::convertUTF16): (KWQTextDecoder::convertUsingTEC): (KWQTextDecoder::toUnicode):

4:30 PM Changeset in webkit [7937] by hyatt

• 2 edits in trunk/WebCore

Make sure line-height returns the correct value for normal.

Reviewed by darin

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):

1:07 PM Changeset in webkit [7936] by darin

• 1 delete in trunk/LayoutTests/.cvsignore

Don't ignore results file since it's not here any more.

10:29 AM Changeset in webkit [7935] by harrison

• 4 edits
  2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3857753> REGRESSION (Mail): Delete incorrectly causes text to take on new style

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Fixed to move entire source subtree (up to, but not including, the enclosingBlockFlowElement) rather than just the source element. Fixed to insert after the destination subtree, rather than the destination element. Handles edge case of deleting back to the top of the tree, where there is nothing left to insert after.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingNonBlockFlowElement): New method to support moveNodesAfterNode changes.
• khtml/xml/dom_nodeimpl.h: Declare NodeImpl::enclosingNonBlockFlowElement
• layout-tests/editing/deleting/delete-3857753-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-3857753-fix.html: Added.

9:16 AM Changeset in webkit [7934] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed <rdar://problem/3865365> since -[WebScriptObject dealloc] does not call [super dealloc], the build will fail due to a warning
• fixed behavior so that [[WebScriptObject alloc] initWithCoder:] doesn't leak WebUndefined instances and incidentally so that [[WebScriptObject alloc] init] returns the single shared instance rather than allocating a new one

• bindings/objc/WebScriptObject.mm: Removed some stray semicolons. (+[WebUndefined allocWithZone:]): Made this the common bottleneck that returns the single instance of WebUndefined, since it's the single method that normally allocates new instances. Calls super to actually allocate only the very first time it's called. (-[WebUndefined initWithCoder:]): Simplified to just return self (no reason to re-lookup the single shared instance since there can be only one). (-[WebUndefined copyWithZone:]): Ditto. (-[WebUndefined retain]): Ditto. (-[WebUndefined retainCount]): Use UINT_MAX constant here (matches usage in NSObject.m for retain count of class). (-[WebUndefined autorelease]): Simplified to just return self (see above). (-[WebUndefined copy]): No need to override this since it just turns around and calls copyWithZone:. (-[WebUndefined dealloc]): Added an assertion since this method should never be called. Also added a call to [super dealloc] after return; to make the new -Wdealloc-check compiler happy (fixing the bug mentioned above). (+[WebUndefined undefined]): Reimplemented; calls allocWithZone:NULL to get to the shared instance. No need to call init, since that's a no-op for this class.

Nov 3, 2004:

4:40 PM Changeset in webkit [7933] by harrison

• 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Eliminate the use of a marker file to determine how to build.

• .cvsignore:
• Makefile.am:

7:58 AM Changeset in webkit [7932] by kocienda

• 1 edit
  6 adds in trunk

Reviewed by me

More layout tests.

• layout-tests/editing/deleting/delete-br-008-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-008.html: Added.
• layout-tests/editing/deleting/delete-br-009-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-009.html: Added.
• layout-tests/editing/deleting/delete-br-010-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-010.html: Added.

3:52 AM Changeset in webkit [7931] by mjs

• 2 edits in trunk/WebCore

Fix by Yasuo Kida, reviewed by me.

<rdar://problem/3819004> REGRESSION (Mail): Can't move cursor / delete character after deleting the active input area

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setMarkedTextRange): Treat a collapsed range the same as a nil range - setting an empty marked range should clear the marked range entirely.

3:19 AM Changeset in webkit [7930] by mjs

• 15 edits in trunk

WebCore:

Reviewed by Dave Hyatt (when I originally coded it).

WebCore part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): New method to compute the rect for a DOMRange, or if the range is split into multiple lines, the rect for the part on the first line only.

• khtml/rendering/render_object.cpp: (RenderObject::caretRect): Added extraWidthToEndOfLine parameter and ditto for the overrides below.
• khtml/rendering/render_object.h:
• khtml/rendering/render_box.cpp: (RenderBox::caretRect):
• khtml/rendering/render_box.h:
• khtml/rendering/render_br.cpp: (RenderBR::caretRect):
• khtml/rendering/render_br.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_text.cpp: (RenderText::caretRect):

WebKit:

Reviewed by Dave Hyatt (when I originally coded it).

Redid WebKit part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method, and translate to screen coordinates.

Nov 2, 2004:

5:07 PM Changeset in webkit [7929] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Hyatt.

• [NSFont menuFontOfSize:], called from WebStringTruncator, was taking > 9% of the time creating a very large bookmarks menu, so I cached this one NSFont object.

• Misc.subproj/WebStringTruncator.m: (defaultMenuFont): new function, caches the font used when no font is specified (+[WebStringTruncator centerTruncateString:toWidth:]): call new function

3:22 PM Changeset in webkit [7928] by kocienda

• 9 edits in trunk

WebCore:

Reviewed by Hyatt

Implemented command to insert a block in response to typing a return key (even though
I am not turning that on by default with this patch....that will come later).

This new command is called InsertParagraphSeparatorCommand.

Reworked the command and function names associated with inserting content into a
document. Before this patch, there were inputXXX and insertXXX variants, with the
former used for more high-level actions and the latter used for lower-level stuff.
However, this was confusing as the AppKit uses insertXXX for everything. This resulted
in an insertXXX command going through an inputXXX WebCore step and then finally to an
insertXXX WebCore step. To make this less confusing, I have changes all the names to
be insertXXX, and modified the lower-level operations so that it is clear what they do.

• khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::isInsertTextCommand): Name change. (khtml::EditCommand::isInsertTextCommand): Ditto. (khtml::CompositeEditCommand::inputText): Ditto. (khtml::CompositeEditCommand::insertTextIntoNode): Ditto. (khtml::CompositeEditCommand::deleteTextFromNode): Ditto. (khtml::CompositeEditCommand::replaceTextInNode): Ditto. (khtml::CompositeEditCommand::deleteInsignificantText): Name changes in implementation. (khtml::CompositeEditCommand::isLastVisiblePositionInNode): Ditto. (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Class name change, was DeleteTextCommand. (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand): Ditto. (khtml::DeleteFromTextNodeCommand::doApply): Ditto. (khtml::DeleteFromTextNodeCommand::doUnapply): Ditto. (khtml::DeleteSelectionCommand::performGeneralDelete): Ditto. (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto. (khtml::InsertIntoTextNode::InsertIntoTextNode): Class name change. (khtml::InsertIntoTextNode::~InsertIntoTextNode): Ditto. (khtml::InsertIntoTextNode::doApply): Ditto. (khtml::InsertIntoTextNode::doUnapply): Ditto. (khtml::InsertLineBreakCommand::InsertLineBreakCommand): Class name change, was InsertNewlineCommand. (khtml::InsertLineBreakCommand::insertNodeAfterPosition): (khtml::InsertLineBreakCommand::insertNodeBeforePosition): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Code moved. No changes. (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand): Ditto. (khtml::InsertNodeBeforeCommand::doApply): Ditto. (khtml::InsertNodeBeforeCommand::doUnapply): Ditto. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): New command. (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::InsertParagraphSeparatorInQuotedContentCommand): Class name change, was InsertNewlineCommandInQuotedContentCommand. (khtml::InsertParagraphSeparatorInQuotedContentCommand::~InsertParagraphSeparatorInQuotedContentCommand): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::isMailBlockquote): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto. (khtml::InsertTextCommand::InsertTextCommand): Class name change, was InputTextCommand. (khtml::InsertTextCommand::doApply): Ditto. (khtml::InsertTextCommand::deleteCharacter): Ditto. (khtml::InsertTextCommand::prepareForTextInsertion): Ditto. (khtml::InsertTextCommand::input): Ditto. (khtml::InsertTextCommand::insertSpace): Ditto. (khtml::InsertTextCommand::isInsertTextCommand): Ditto. (khtml::TypingCommand::insertLineBreak): Name change, was insertNewline. (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): Name change, was insertNewlineInQuotedContent. (khtml::TypingCommand::insertParagraphSeparator): New function. (khtml::TypingCommand::doApply): Name changes, as above. (khtml::TypingCommand::insertText): Ditto. (khtml::TypingCommand::deleteKeyPressed): Ditto. (khtml::TypingCommand::preservesTypingStyle): Ditto.
• khtml/editing/htmlediting.h: (khtml::DeleteFromTextNodeCommand::node): Name change. (khtml::DeleteFromTextNodeCommand::offset): Ditto. (khtml::DeleteFromTextNodeCommand::count): Ditto. (khtml::InsertIntoTextNode::text): Ditto. (khtml::InsertNodeBeforeCommand::insertChild): Ditto. (khtml::InsertNodeBeforeCommand::refChild): Ditto. (khtml::TypingCommand::): Ditto.
• khtml/editing/jsediting.cpp: Name changes, as above.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge insertLineBreak]): Name change, was insertNewline. (-[WebCoreBridge insertParagraphSeparator]): New function. (-[WebCoreBridge insertParagraphSeparatorInQuotedContent]): Name change, was insertNewlineInQuotedContent.

WebKit:

Reviewed by Hyatt

WebCore now implements a command to insert a block in response to typing a return key, and
some names were improved in the course of this work.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView insertNewline:]): Now calls insertLineBreak on bridge object. (-[WebHTMLView insertLineBreak:]): New method. (-[WebHTMLView insertParagraphSeparator:]): Now implemented.
• WebView.subproj/WebView.m:

Nov 1, 2004:

3:46 PM Changeset in webkit [7927] by rjw

• 3 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3861469> Latest Real player crashes Safari on some sites.

Reviewed by Ken.

• bindings/c/c_instance.cpp: (CInstance::invokeMethod): (CInstance::invokeDefaultMethod): Initialize out parameters to void type.

• bindings/c/c_runtime.cpp: (CField::valueFromInstance): (CField::setValueToInstance): Initialize out parameters to void type. Also added additional checks to protect against classes that don't implement all functions.

2:33 PM Changeset in webkit [7926] by rjw

• 3 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3861257> WebUndefined should be returned for undefined values

Reviewed by John.

• ChangeLog:
• bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): Added additional conversion Undefined -> WebUndefined.
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): Added additional conversion WebUndefined -> Undefined.

2:21 PM Changeset in webkit [7925] by cblu

• 2 edits in branches/Safari-1-2-branch/WebCore

Fixed: <rdar://problem/3860882> Safari URI status bar spoofing using a nested <a> links in a table

Rolled fix from TOT to 1.2 branch.

Reviewed by adele.

• khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPoint): Make sure the URL element is the innermost one, by not setting it once it's already set.

2:20 PM Changeset in webkit [7924] by kdecker

• 2 edits in trunk/WebCore

Reviewed by rjw.

fixed <rdar://problem/3681094> Crash in KJS::WindowFunc::tryCall with application/xhtml+xml Content-Type
once and for all.

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Added a nil check in the case of an empty document lacking a baseURL().

1:23 PM Changeset in webkit [7923] by darin

• 2 edits in trunk/JavaScriptCore

• fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments

• bindings/objc/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.

11:21 AM Changeset in webkit [7922] by darin

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

• fixed <rdar://problem/3859381> REGRESSION (167-168): text in form fields should not use body's text color

• khtml/css/html4.css: Use color: initial for textarea and related ones.

9:56 AM Changeset in webkit [7921] by kocienda

• 9 edits
  6 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3775920> REGRESSION (Mail): Centering doesn't work in HTML mail

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties): Factor out the implementation here into new copyPropertiesInSet helper. This now calls the generalized copyPropertiesInSet function with the arguments needed to make copying inheritable work.
• khtml/css/css_computedstyle.h:
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::diff): Move this function here from css_computedstyle.cpp. In order to do apply block properties, "regular" style declarations need to do style diffs as well. (CSSStyleDeclarationImpl::copyBlockProperties): New helper. Just like copyInheritableProperties except that it uses a different set of properties that apply only to blocks. (CSSStyleDeclarationImpl::copyPropertiesInSet): New helper that looks at a style declaration and copies out those properties listed in a pre-defined set.
• khtml/css/css_valueimpl.h:
• khtml/editing/htmlediting.cpp: (khtml::StyleChange::StyleChange): Modified to work with style changes that apply to a whole block, factoring out some of the special case code that should now only run in the inline case. (khtml::StyleChange::init): Factored out the code that now is in checkForLegacyHTMLStyleChange. (khtml::StyleChange::checkForLegacyHTMLStyleChange): New helper for case where we want special handling for "legacy" HTML styles like <B> and <I>. (khtml::ApplyStyleCommand::doApply): Much refactoring in this class to divide up the work of style changes into different kinds. CSS specifies certain properties only apply to certain element types. This set of changes now recognizes two such separate cases: styles that apply to blocks, and styles that apply to inlines. (khtml::ApplyStyleCommand::applyBlockStyle): New function to handle apply styles to whole blocks. (khtml::ApplyStyleCommand::applyInlineStyle): New function to handle apply styles to inlines. (khtml::ApplyStyleCommand::isHTMLStyleNode): Is now passed a CSSStyleDeclarationImpl to work with rather than working on the CSSStyleDeclarationImpl member variable of the class. This is done so that the function can be passed a portion of the styles being applied so that block styles and inline styles can be handled separately. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. (khtml::ApplyStyleCommand::removeBlockStyle): New function to handle removing styles from whole blocks. (khtml::ApplyStyleCommand::removeInlineStyle): New function to removing styles from inlines. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): New function to handle applying style to whole blocks. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): New function to handle applying style to inlines.
• khtml/editing/htmlediting.h: (khtml::StyleChange::): Changed as described above. (khtml::StyleChange::usesLegacyStyles): (khtml::EditCommand::setEndingSelectionNeedsLayout): New function to that tells the ending selection it needs to layout, even though it has not changed position in the DOM. For instance, this is needed when text align changes.
• khtml/khtml_part.cpp: (KHTMLPart::setTypingStyle): Put in an early bail-out in the case where the current style matches the passed-in argument. (KHTMLPart::applyStyle): Modify this function so that block styles are applied when the selection is a caret. Formerly, this just set typing style and made no visible changes to the document.

New tests.

• layout-tests/editing/editing.js: Added some glue to change text align.
• layout-tests/editing/style/block-style-001-expected.txt: Added.
• layout-tests/editing/style/block-style-001.html: Added.
• layout-tests/editing/style/block-style-002-expected.txt: Added.
• layout-tests/editing/style/block-style-002.html: Added.
• layout-tests/editing/style/block-style-003-expected.txt: Added.
• layout-tests/editing/style/block-style-003.html: Added.

Oct 29, 2004:

4:51 PM Changeset in webkit [7920] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (170u)

4:42 PM Changeset in webkit [7919]

• 2 copies in tags/Safari-169

This commit was manufactured by cvs2svn to create tag 'Safari-169'.

4:42 PM Changeset in webkit [7918] by vicki

• 6 edits in trunk

Safari-169 stamp

2:53 PM Changeset in webkit [7917] by darin

• 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

• fixed <rdar://problem/3751619> Safari crash in khtml::CircularSearchBuffer::append(QChar const&)

• khtml/editing/visible_text.cpp: (khtml::findPlainText): Fix exit condition to check for break before advancing one character; before it did it backwards.

2:48 PM Changeset in webkit [7916] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3853262> REGRESSION(166-168) gmail gets blank page when loading

Reviewed by kocienda, adele.

• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): remove infinite frame recursion check for iframes

1:16 PM Changeset in webkit [7915] by cblu

• 2 edits in trunk/WebKit

• WebKit.exp: added _WebPlugInModeKey, forgot to add it earlier

11:59 AM Changeset in webkit [7914] by darin

• 3 edits in trunk/WebCore

Reviewed by Chris.

• fixed <rdar://problem/3857395> clicking on calendar in Apple Travel site crashes Safari in invalidateClick (getthere.net)

• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Use a SharedPtr<KHTMLView> to make sure the KHTMLView is not deleted before this function finishes running. (KHTMLView::viewportMouseDoubleClickEvent): Ditto. (KHTMLView::viewportMouseReleaseEvent): Ditto. (KHTMLView::dispatchMouseEvent): Removed ref/deref pairs that aren't needed since dispatchEvent is guaranteed to do ref/deref as needed.

• kwq/KWQObject.mm: (QObject::startTimer): Fixed a comment.

11:11 AM Changeset in webkit [7913] by darin

• 2 edits in trunk/WebKit

• fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments

• Plugins.subproj/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.

Oct 28, 2004:

4:14 PM Changeset in webkit [7912] by cblu

• 3 edits in trunk/WebCore

Enabled XSLT on Panther. See intrigue mail for compiling instructions.

Reviewed by darin.

• WebCore.pbproj/project.pbxproj: link against xslt unconditionally, link against specific version of libxml on Panther
• WebCorePrefix.h: always use XSLT

3:35 PM Changeset in webkit [7911] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Chris

Fix for these bugs:

<rdar://problem/3854848> Tiger Mail Crash in WebCore - khtml::CompositeEditCommand::insertNodeAfter
<rdar://problem/3803832> REGRESSION (Mail): incorrect behavior after Return + Delete in quoted text

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Added node pointer class members to initialization list, zeroing them out. (khtml::DeleteSelectionCommand::canPerformSpecialCaseBRDelete): New special-case helper to handle a delete of content in special cases where the only thing selected is a BR. This code path is much simpler than the newly-named performGeneralDelete, and detects when no content merging should be done between blocks. This aspect of the change fixes 3854848. One of the special cases added fixes 3803832. (khtml::DeleteSelectionCommand::performGeneralDelete): Renamed, from performDelete. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Made this helper be a no-arg function, just like the other helpers in this class. (khtml::DeleteSelectionCommand::clearTransientState): Fix cut and paste error in deref code. (khtml::DeleteSelectionCommand::doApply): Updated for changed helpers.
• khtml/editing/htmlediting.h: Added new helper and changed an old one.

3:05 PM Changeset in webkit [7910] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front page of store.apple.com

Reviewed by darin.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it

1:07 PM Changeset in webkit [7909] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Harrison

Reorganization of delete command functionality so that doApply is not
several hundred lines long. This is not a squeaky-clean cleanup, but
it is a step in the right direction. No functionality changes.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): (khtml::DeleteSelectionCommand::initializePositionData): New helper. (khtml::DeleteSelectionCommand::saveTypingStyleState): Ditto. (khtml::DeleteSelectionCommand::performDelete): Ditto. (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto. (khtml::DeleteSelectionCommand::calculateEndingPosition): Ditto. (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto. (khtml::DeleteSelectionCommand::clearTransientState): Ditto. (khtml::DeleteSelectionCommand::doApply): Factor out code into new helpers.
• khtml/editing/htmlediting.h:

9:38 AM Changeset in webkit [7908] by kocienda

• 2 edits in trunk/WebCore

Reviewed by me

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Typo in initializer caused new mergeBlocksAfterDelete flag to be set improperly, causing layout regressions.

Oct 27, 2004:

3:41 PM Changeset in webkit [7907] by kocienda

• 8 edits in trunk

WebCore:

Reviewed by Chris

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteSelection): Added new mergeBlocksAfterDelete flag to control whether content not in the block containing the start of the selection is moved to that block after the selection is deleted. (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Ditto. (khtml::DeleteSelectionCommand::doApply): Ditto. (khtml::InputNewlineInQuotedContentCommand::InputNewlineInQuotedContentCommand): New command to handle the case of inserting a newline when in quoted content in Mail. (khtml::InputNewlineInQuotedContentCommand::~InputNewlineInQuotedContentCommand): Ditto. (khtml::InputNewlineInQuotedContentCommand::isMailBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::isLastVisiblePositionInBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::doApply): Ditto. (khtml::TypingCommand::insertNewlineInQuotedContent): Support for new newline command. (khtml::TypingCommand::doApply): Ditto. (khtml::TypingCommand::preservesTypingStyle): Ditto.
• khtml/editing/htmlediting.h: Add new delclarations. (khtml::TypingCommand::): Ditto.
• kwq/WebCoreBridge.h: Added new bridge method called from WebKit.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge insertNewlineInQuotedContent]): Ditto.

WebKit:

Reviewed by Chris

Added new SPI for Mail so it can get the behavior it needs when the user hits
the return key with the selection in quoted content.

• WebView.subproj/WebView.m
• WebView.subproj/WebViewPrivate.h

3:09 PM Changeset in webkit [7906]

• 11 copies
  3 deletes in tags/WebKit-146~2

This commit was manufactured by cvs2svn to create tag 'WebKit-146~2'.

3:09 PM Changeset in webkit [7905] by vicki

• 2 edits in branches/WWDC-2004-branch/WebKit

WebKit:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebKit.pbproj/project.pbxproj:

WebBrowser:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebBrowser.pbproj/project.pbxproj:

3:01 PM Changeset in webkit [7904]

• 11 copies
  2 deletes in tags/WebCore-146~3

This commit was manufactured by cvs2svn to create tag
'WebCore-146~3'.

3:01 PM Changeset in webkit [7903]

• 16 copies
  3 deletes in tags/JavaScriptCore-146~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~3'.

3:01 PM Changeset in webkit [7902] by vicki

• 4 edits in branches/WWDC-2004-branch

JavaScriptCore:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• JavaScriptCore.pbproj/project.pbxproj:

WebCore:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebCore.pbproj/project.pbxproj:

Oct 26, 2004:

3:13 PM Changeset in webkit [7901] by cblu

• 4 edits in trunk/WebCore

Fixed: <rdar://problem/3774243> page up/down, arrow up/down, etc in Safari RSS should scroll main content

Reviewed by dave.

• khtml/ecma/kjs_dom.cpp: (DOMElementProtoFunc::tryCall): added scrollByLines and scrollByPages to HTML element for Safari RSS
• khtml/ecma/kjs_dom.h: (KJS::DOMElement::):
• khtml/ecma/kjs_dom.lut.h: (KJS::):

2:08 PM Changeset in webkit [7900] by hyatt

• 2 edits in trunk/WebCore

Fix for 3848214, deleting a partial word left a repaint artifact if the partial word was pulled back onto
the previous line.

Reviewed by kocienda

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):

1:15 PM Changeset in webkit [7899] by hyatt

• 3 edits in trunk/WebCore

Convert selectionRect() from using a list to a dict and patch it to be like setSelection. It was still trying
to use the old dirty bit optimization (which had been removed), and so it was pathologically slow on large documents.

Reviewed by kocienda

• khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
• khtml/rendering/render_object.h: (khtml::RenderObject::hasSelectedChildren):

12:57 PM Changeset in webkit [7898] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug

<rdar://problem/3851164> mail crashed when I pasted a large amount of text into a reply

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): This now returns bool to let the caller know if a placeholder was removed. (khtml::ReplaceSelectionCommand::doApply): Use the bool return value from the call to removeBlockPlaceholderIfNeeded. If true, shift the selection to the now-empty block. In some cases, the selection was still set on the removed BR, and this was the cause of the crash.
• khtml/editing/htmlediting.h: Change removeBlockPlaceholderIfNeeded return type.

11:26 AM Changeset in webkit [7897] by darin

• 2 edits in trunk/WebCore

Reviewed by Chris.

• fixed <rdar://problem/3851301> leak of one NSCFDictionary for each XMLHttpRequest issued

• kwq/KWQLoader.mm: (KWQServeSynchronousRequest): Add a release.

10:40 AM Changeset in webkit [7896] by cblu

• 2 edits in trunk/WebKit

Fixed exception that Darin encountered in Mail.

Reviewed by darin.

• Plugins.subproj/WebPluginController.m: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): if the plug-in returns a nil view, return nil

10:08 AM Changeset in webkit [7895] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): Do not call replaceText with a zero-length string. That triggers an assert. Call deleteText instead, using the same indices that are passed to replaceText.

Cleaned up the asserts in these three functions below, making them
more consistent. This is not needed for the fix, but I tripped over
these in the course of debugging.

(khtml::InsertTextCommand::InsertTextCommand):
(khtml::InsertTextCommand::doApply):
(khtml::InsertTextCommand::doUnapply):

Oct 25, 2004:

5:46 PM Changeset in webkit [7894] by adele

• 3 edits in trunk/WebCore

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::inDesignMode): made inDesignMode const
• khtml/xml/dom_docimpl.h:

4:42 PM Changeset in webkit [7893] by cblu

• 2 edits in trunk/WebKit

Darin made an internal notification have the Web prefix.

Reviewed by me.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (ConsoleConnectionChangeNotifyProc):

4:02 PM Changeset in webkit [7892] by adele

• 2 edits in trunk/WebCore

Reviewed by me, code change by Darin.

• khtml/xml/dom_docimpl.cpp: Moved design mode code outside the XSLT ifdef.

3:05 PM Changeset in webkit [7891] by kocienda

• 3 edits in trunk

Reviewed by me

Oops. These two test results changed with my last checkin, for the better.

• layout-tests/editing/deleting/delete-3800834-fix-expected.txt
• layout-tests/editing/inserting/insert-3775316-fix-expected.txt

2:52 PM Changeset in webkit [7890] by kocienda

• 3 edits
  6 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3820349> REGRESSION (Mail): select all, delete does not always delete everything

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::startPositionForDelete): New helper that determines when to expand the selection outwards when the selection is on the visible boundary of a root editable element. This fixes the bug. Note that this function also contains a little code I factored out of doApply: it also takes care of adjusting the selection in the smart delete case. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto. (khtml::DeleteSelectionCommand::doApply): Call new helpers. Refactored out the code as described.
• khtml/editing/htmlediting.h: Declare new helpers.
• layout-tests/editing/deleting/delete-select-all-001-expected.txt: Added.
• layout-tests/editing/deleting/delete-select-all-001.html: Added.
• layout-tests/editing/deleting/delete-select-all-002-expected.txt: Added.
• layout-tests/editing/deleting/delete-select-all-002.html: Added.
• layout-tests/editing/deleting/delete-select-all-003-expected.txt: Added.
• layout-tests/editing/deleting/delete-select-all-003.html: Added.

11:49 AM Changeset in webkit [7889] by kocienda

• 1 edit
  10 adds in trunk

Reviewed by me

Added some more editing layout tests.

• layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
• layout-tests/editing/deleting/delete-ws-fixup-001.html: Added.
• layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
• layout-tests/editing/deleting/delete-ws-fixup-002.html: Added.
• layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
• layout-tests/editing/deleting/delete-ws-fixup-003.html: Added.
• layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
• layout-tests/editing/deleting/delete-ws-fixup-004.html: Added.
• layout-tests/editing/inserting/typing-003-expected.txt: Added.
• layout-tests/editing/inserting/typing-003.html: Added.

11:48 AM Changeset in webkit [7888] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): I did not get my fix for 3848343 and 3848224

yesterday quite right: words that should have been placed on the next line were instead

appearing on the line before, beyond the right margin. This was a one-word only error
based on moving the line break object when it should have stayed put. Here is the rule:
The line break object only moves to after the whitespace on the end of a line if that
whitespace caused line overflow when its width is added in.

11:26 AM Changeset in webkit [7887] by adele

• 7 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3619890> Feature request: designMode

This change implements the designMode property of a document. This is an IE property that is also supported by Mozilla.
This will enable more JS editing compatibility.

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): added case for designMode (KJS::HTMLDocument::putValue): added case for designMode
• khtml/ecma/kjs_html.lut.h: (KJS::): regenerated
• khtml/khtml_part.cpp: (KHTMLPart::isContentEditable): Now returns designMode value
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_designMode member variable (DocumentImpl::setDesignMode): added function to assign m_designMode value (DocumentImpl::getDesignMode): return m_designMode value (DocumentImpl::inDesignMode): if designMode is inherited, this will find the appropriate parent document designMode and return that value.

Otherwise, it will just return the m_designMode value.

(DocumentImpl::parentDocument):

• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::): added InheritedBool enum, prototypes, and m_designMode member variable.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isContentEditable): added check for isContentEditable function in KHTMLPart

10:52 AM Changeset in webkit [7886] by sullivan

• 3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

• Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object; eliminated notificationsSuppressed mechanism, which was used only by WebBookmark

• History.subproj/WebHistoryItem.m: removed notificationsSuppressed ivar from private data object (-[WebHistoryItem setAlternateTitle:]): remove notificationsSuppressed guard (-[WebHistoryItem setURLString:]): ditto (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto (-[WebHistoryItem setNotificationsSuppressed:]): removed this method (-[WebHistoryItem notificationsSuppressed]): ditto

• History.subproj/WebHistoryItemPrivate.h: removed notificationsSuppressed and setNotificationsSuppressed

WebBrowser:

Reviewed by Chris.

• fixed these bugs: <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object <rdar://problem/3852373> Could eliminate -[WebBookmark lastVisitedTimeInterval] for performance

This reduced RPRVT after launch with the standard set of built-in bookmarks on my machine from
4.12M to 4.09M, and sped up reading bookmarks a little also.

• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Don't set lastVisitedTimeInterval here

• URLCompletionController.m: (-[URLCompletionController _addStatsForURL:]): Added comment to this #defined-away method explaining that it wouldn't work as-is anymore since it calls the obsolete setLastVisitedTimeInterval

• WebBookmark.h: remove lastVisitedTimeInterval and setLastVisitedTimeInterval

• WebBookmark.m: removed _URL, setLastVisitedTimeInterval, and lastVisitedTimeInterval

• WebBookmarkExporter.m: (-[WebBookmarkExporter stringForBookmarkLeaf:withIndentLevel:]): Don't export last visited time anymore

• WebBookmarkGroup.m: (-[WebBookmarkGroup _addBookmarkToURLStringDictionary:]): use [bookmark URLString] instead of [bookmark _URL]. The latter was getting the URL from its WebHistoryItem, which no longer exists.

• WebBookmarkLeaf.h: remove _entry ivar, add _title ivar
• WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): removed this method, which set up _entry (-[WebBookmarkLeaf initWithURLString:title:group:]): weaned from _entry, also calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf initFromDictionaryRepresentation:topLevelOnly:withGroup:]): ditto (-[WebBookmarkLeaf dictionaryRepresentation]): weaned from _entry (-[WebBookmarkLeaf dealloc]): calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf copyWithZone:]): ditto (-[WebBookmarkLeaf title]): weaned from _entry (-[WebBookmarkLeaf setTitle:]): ditto (-[WebBookmarkLeaf icon]): ditto (-[WebBookmarkLeaf URLString]): ditto (-[WebBookmarkLeaf setURLString:]): ditto, also updates WebIconDatabase (-[WebBookmarkLeaf setLastVisitedTimeInterval:]): removed this method (-[WebBookmarkLeaf lastVisitedTimeInterval]): ditto (-[WebBookmarkLeaf _computeIsRSSBookmark]): use isSyndicationURLString on a string instead of isSyndicationURL on a URL

• WebBookmarkPrivate.h: removed _URL method

Oct 22, 2004:

5:19 PM Changeset in webkit [7885] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins

Reviewed by mjs.

• WebView.subproj/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins

3:26 PM Changeset in webkit [7884] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3844662> REGRESSION (Mail): Style changes can affect adjacent, unselected text

• khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::doApply): Move end position downstream to be sure we remove style from everything that could be affected. (khtml::ApplyStyleCommand::removeCSSStyle): Comma in intended function call was outside the braces, making it act as a comma operator, with a zero value as the right value!!! This made an important check always fail!!! It turns out that we do not want the constant at all, since that constant is only needed when checking a computed style, not an inline style as is being done here. (khtml::ApplyStyleCommand::removeStyle): Call nodeFullySelected with new interface. (khtml::ApplyStyleCommand::nodeFullySelected): Change interface and implementation to rely on RangeImpl::compareBoundaryPoints to perform the required check.
• khtml/editing/htmlediting.h: Changed nodeFullySelected function interface.

1:07 PM Changeset in webkit [7883] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bugs:

<rdar://problem/3848343> REGRESSION (Mail, 166-168u): Typed text after space at end of line before block quote does not appear
<rdar://problem/3848224> REGRESSION (Mail): space typed at end of line vanishes after typing next character

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): When the khtmlLineBreak is in AFTER_WHITE_SPACE mode, as it is when we are editing, add in the space of the current character when calculating the width of committed plus uncommitted characters. If this value exceeds the width of the line, move up the line break object and call skipWhitespace to move past the end of the whitespace.

12:14 PM Changeset in webkit [7882] by vicki

• 3 edits in trunk

versioning for TOT. the tree is open!

12:04 PM Changeset in webkit [7881]

• 2 copies in tags/Safari-168

This commit was manufactured by cvs2svn to create tag 'Safari-168'.

12:04 PM Changeset in webkit [7880] by vicki

• 6 edits in trunk

Safari-168 stamp

9:20 AM Changeset in webkit [7879] by kocienda

• 6 edits in trunk

JavaScriptCore:

Reviewed by me

• JavaScriptCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebCore:

Reviewed by me

• WebCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebKit:

Reviewed by me

• WebKit.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.