Context Navigation

← Previous Period
Next Period →

Timeline

Dec 22, 2004:

4:45 PM Changeset in webkit [8280]

1 copy in tags/Safari-177

This commit was manufactured by cvs2svn to create tag 'Safari-177'.

4:45 PM Changeset in webkit [8279] by adele

6 edits in trunk

Safari-177 stamp

3:18 PM Changeset in webkit [8278] by darin

20 edits in trunk/WebCore

rolled out my custom tag name change -- it broke amazon.com

khtml/css/cssstyleselector.cpp:
khtml/editing/htmlediting.cpp:
khtml/editing/selection.cpp:
khtml/editing/visible_position.cpp:
khtml/html/dtd.cpp:
khtml/html/htmlparser.cpp:
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp:
khtml/misc/htmlhashes.cpp:
khtml/misc/htmlhashes.h:
khtml/misc/htmltags.c:
khtml/misc/htmltags.h:
khtml/misc/maketags:
khtml/xml/dom_docimpl.cpp:
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_position.cpp:
kwq/KWQRenderTreeDebug.cpp:

1:37 PM Changeset in webkit [8277] by harrison

3 edits in trunk/WebCore

Reviewed by Darin Adler.

khtml/editing/selection.cpp: (khtml::Selection::validate): The selecting/deselecting bad behavior is because the Selection code that expands by words had an inaccurate test for being at the end of the document (where double-clicking needs to select the last word). Fixed that check.

10:23 AM Changeset in webkit [8276] by adele

2 edits in trunk/WebCore

Reviewed by Chris.

Fix for <rdar://problem/3911650> tabs at safeway.com stop working after a while

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): removed call to cancelRedirection so that we match Firefox and WinIE behavior.

9:58 AM Changeset in webkit [8275] by darin

28 edits in trunk

Reviewed by Ken.

fixed <rdar://problem/3760910> Request to include support for custom tag names in HTML (they already work in XML)

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.

khtml/editing/htmlediting.cpp: (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for per-document tags and is just better all around for things like the document. (khtml::debugNode): Ditto.
khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.

khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows non-HTML elements to be nested as desired.

khtml/html/htmlparser.h: Change forbidden tag array to be allocated in the object rather than on the heap. Also use ID_LAST_TAG for the array size; the old code used ID_CLOSE_TAG which is now a much larger number.
khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Remove code that creates the forbidden tag array on the heap; makes more sense to just have the array be a member so we don't have to use new and delete on it. Also needed to eliminate code that used ID_CLOSE_TAG for an array size. (KHTMLParser::~KHTMLParser): Remove code that deletes the forbidden tag array. Also changed the code that manages isindex to use deref instead of delete. (KHTMLParser::reset): Use safer sizeof for clearing the forbidden tag array. Old code had the mistake of using ID_CLOSE_TAG for the array size too. (KHTMLParser::parseToken): Removed code that checks for bogus tags; it's not clear why it was ever there and it would prevent custom tags from working. Added range check before using the forbidden tag array with the token ID since custom tags will use index values past the end of the array. (KHTMLParser::getElement): Removed most of the code that makes an element by ID; now the work is done inside the DocumentImpl createHTMLElement. Any code that needs to be different than a dynamic createElement call is still here.
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Call the tagId function in the document if getTagID fails; this creates a unique per-document ID.

khtml/misc/htmlhashes.h: Changed return types to unsigned short.
khtml/misc/htmlhashes.cpp: (khtml::getTagID): Changed return type to unsigned short. (khtml::getAttrID): Ditto.

khtml/misc/htmltags.c: Regenerated.
khtml/misc/htmltags.h: Regenerated.

khtml/misc/maketags: Changed the generated constants to use "const unsigned short" instead of "#define". Changed ID_CLOSE_TAG to be a fixed value of 32000 rather than being just past the IDs of the HTML tags. Also rewrote getTagName to work with the new scheme.

khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID. Also updated for a few tags that the parser handled but this did not.

kwq/KWQRenderTreeDebug.cpp: (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on the tag ID directly, which only works for standard nodes. (operator<<): Update to call getTagName. (nodePositionRelativeToRoot): Ditto. (writeSelection): Ditto.

Dec 21, 2004:

5:05 PM Changeset in webkit [8274] by harrison

4 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3924934> REGRESSION: double click at end of line selects start of next line

Problem was the TextIterator was not handling exitNode() from a P block properly.

khtml/editing/visible_text.cpp: (khtml::TextIterator::TextIterator): Add new param that specifies whether the iterator is for content or for searching. Search iterators do not prevent newlines at the beginning. (khtml::TextIterator::advance): Added some comments. (khtml::TextIterator::handleTextNode): Added some comments. (khtml::TextIterator::exitNode): Emit newline for P (and other) blocks with position following the block, instead of the m_lastTextNode. (khtml::TextIterator::emitCharacter): Added some comments. (khtml::TextIterator::range): Added some comments. (khtml::CharacterIterator::CharacterIterator): Specify search type TextIterator. (khtml::CharacterIterator::advance):
khtml/editing/visible_text.h: (khtml::): Add new TextIterator::TextIterator param that specifies whether the iterator is for content or for searching.
khtml/editing/visible_units.cpp: (khtml::nextWordBoundary): Specify search type TextIterator.

4:52 PM Changeset in webkit [8273] by harrison

2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3924695> REGRESSION (Mail): double-clicking past end of line shows no selection, should select to EOL

Problem was that RenderText::setSelectionState did not handle the SelectionStart case where start and end are the end of the line.
Fixed by pretending the start == end-1 in that situation, as long as end > 0.

khtml/rendering/render_text.cpp: (RenderText::setSelectionState)

4:44 PM Changeset in webkit [8272] by mjs

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3929187> WebKit needs to restrict access to certain window operations by domain

khtml/ecma/kjs_window.cpp: (Window::get): Change most window functions to be restricted by XSS domain check.

11:45 AM Changeset in webkit [8271] by kocienda

3 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3928305> selecting an entire line and typing over causes new inserted text at top of document

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): New function to detect case formerly undetected and unhandled. This is the crux of the bug fix. (khtml::DeleteSelectionCommand::doApply): Call insertPlaceholderForAncestorBlockContent() during execution of command.
khtml/editing/htmlediting.h: Declare new function.
layout-tests/editing/deleting/delete-3928305-fix-expected.txt: Added.
layout-tests/editing/deleting/delete-3928305-fix.html: Added.

11:29 AM Changeset in webkit [8270] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Note to self: Must compile code before checking in (aka must return false from function returning bool).

11:23 AM Changeset in webkit [8269] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3927752> Crash in khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded(DOM::NodeImpl*)

khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Added some null checks. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Ditto.

11:05 AM Changeset in webkit [8268] by kocienda

2 edits
6 adds in trunk

Reviewed by Darin

khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::mergeStartNode): Refine concept of how this node is found based on further experiements. (khtml::ReplaceSelectionCommand::doApply): Add a special case for determining merges that need to be done if the insertion point is in an empty block.
layout-tests/editing/pasteboard/paste-text-012-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-012.html: Added.
layout-tests/editing/pasteboard/paste-text-013-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-013.html: Added.
layout-tests/editing/pasteboard/paste-text-014-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-014.html: Added.

9:38 AM Changeset in webkit [8267] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3899133> text search in a Safari window takes a very long time on Tiger updates page (and some other pages)

khtml/editing/visible_text.h: Add an "offset base node" parameter to emitCharacter, and also add a field to track it. Must make a few things mutable so we can update them in the range accessor.
khtml/editing/visible_text.cpp: (khtml::TextIterator::advance): Pass in base node and offsets rather than computing actual offsets using the node's index. We only compute the node index if actually asked for the range. (khtml::TextIterator::handleTextNode): Pass 0 for base node and set base node to 0 when setting up the offsets. (khtml::TextIterator::handleTextBox): Ditto. (khtml::TextIterator::handleReplacedElement): Pass base node and set base node instead of calling nodeIndex. (khtml::TextIterator::handleNonTextNode): Pass 0 for offset. (khtml::TextIterator::exitNode): More of the same. (khtml::TextIterator::emitCharacter): Ditto. (khtml::TextIterator::range): If an offset base node is stored, then get its node index, and then add that in to the offsets. Doing the work here guarantees it's done only once when doing a text search.

another small fix

khtml/khtml_part.cpp: Removed SPEED_DEBUG define. Not sure why it was on.

Dec 20, 2004:

7:01 PM Changeset in webkit [8266] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (176+)

6:34 PM Changeset in webkit [8265]

2 copies in tags/Safari-176

This commit was manufactured by cvs2svn to create tag 'Safari-176'.

6:34 PM Changeset in webkit [8264] by vicki

6 edits in trunk

Safari-176 stamp

5:15 PM Changeset in webkit [8263] by rjw

2 edits in trunk/WebKit

Add call to new API. ImageIO deprecated some older (although
quite new!) API. This caused us to fail to build on 337 or later.

Developers wanting to build on older versions of Tiger must define
USE_DEPRECATED_IMAGESOURCE_API in WebImageData.m.

Reviewed by Vicki.

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData propertiesAtIndex:]):

5:03 PM Changeset in webkit [8262] by rjw

2 edits in trunk/WebKit

Don't call Tiger SPI on Panther.

Reviewed by Vicki.

WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):

4:25 PM Changeset in webkit [8261] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): My one-liner for this bug introduced layout test regressions: <rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level Rolling out until I can develop a real fix.

3:54 PM Changeset in webkit [8260] by harrison

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Dave Hyatt.

Initial checkin of AXTextMarkerRef support.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): (DocumentImpl::setFocusNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject anchorElement]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject textMarkerRangeFromMarkers:andEndMarker:]): (-[KWQAccObject textMarkerForVisiblePosition:]): (-[KWQAccObject visiblePositionForTextMarker:]): (-[KWQAccObject AXTextMarkerRangeCopyStartMarkerWrapper:]): (-[KWQAccObject AXTextMarkerRangeCopyEndMarkerWrapper:]): (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): (-[KWQAccObject getSelectedTextMarkerRange]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXStringForTextMarkerRange:]): (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]): (-[KWQAccObject accessibilityFocusedUIElement]): (-[KWQAccObject clearChildren]): (-[KWQAccObject accObjectID]): (-[KWQAccObject setAccObjectID:]): (-[KWQAccObject removeAccObjectID]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::getAccObjectID): (KWQAccObjectCache::removeAccObjectID): (KWQAccObjectCache::textMarkerForVisiblePosition): (KWQAccObjectCache::visiblePositionForTextMarker):

3:51 PM Changeset in webkit [8259] by harrison

5 edits in trunk/WebCore

ChangeLog

3:36 PM Changeset in webkit [8258] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3884448> WebKit should turn on CG local font cache

Enable mutli-tier font caching. We should see a performance boost with this
change.

Reviewed by Chris.

WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):

2:34 PM Changeset in webkit [8257] by rjw

4 edits in trunk/WebKit

Fix image decoding to separately decode image meta data from actual image bits. I
incorrectly consolidated decode of meta data and image bits resulting in a huge
performance regression.

Double size of WebCore cache on lower end machines. On the PLT run on machines with
256MB of memory, too many images were being evicted, causing a re-decode on the PLT.
Upping the lower limit of the cache size ensure that no images are evicted (this
goes hand-in-hand with the change to the minimum object size from 32K to 40K).

Reviewed by Ken.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (+[WebImageData initialize]): (-[WebImageData _commonTermination]): (-[WebImageData _invalidateImages]): (-[WebImageData _invalidateImageProperties]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _cacheImages:allImages:]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

12:34 PM Changeset in webkit [8256] by rjw

2 edits in trunk/WebKit

Fixed build problem caused by change to ImageIO API.

Reviewed by Adele.

WebCoreSupport.subproj/WebImageData.m:

Dec 19, 2004:

12:40 PM Changeset in webkit [8255] by darin

5 edits in trunk/WebKit

Reviewed by Kevin.

some garbage collection fixes

Misc.subproj/WebNSObjectExtras.h: (WebCFAutorelease): Replaced the old WebNSRetainCFRelease with this much-easier-to-understand function cribbed from what David Harrison did in WebCore.

Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Use CFRelease here to get rid of an unnecessary use of WebNSRetainCFRelease.
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Use WebCFAutorelease instead of WebNSRetainCFRelease and autorelease. (-[NSURL _web_URLWithLowercasedScheme]): Ditto. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Use WebCFAutorelease here; the old code would not work correctly under GC.
Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): Use WebCFAutorelease here; the old code would not work correctly under GC.

12:35 PM Changeset in webkit [8254] by darin

2 edits in trunk/WebCore

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): Added nil check.

12:30 PM Changeset in webkit [8253] by darin

3 edits in trunk/WebCore

Reviewed by Kevin.

a garbage collection fix

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): Added a more-extensive comment and fixed the BUILDING_ON_PANTHER #ifndef to use #if (in practice, either is OK).
kwq/KWQKURL.mm: (KURL::getNSURL): Use KWQCFAutorelease instead of autorelease.

11:09 AM Changeset in webkit [8252] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3766915> PDF content needs search to work

Reviewed by kevin, john.

WebView.subproj/WebPDFView.m: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): implemented (-[WebPDFView takeFindStringFromSelection:]): new (-[WebPDFView jumpToSelection:]): new (-[WebPDFView validateUserInterfaceItem:]): new

Dec 17, 2004:

7:30 PM Changeset in webkit [8251] by rjw

1 edit in trunk/WebCore/khtml/misc/loader.cpp

Use 40K, not 40MB as min max cacheable object size.

5:31 PM Changeset in webkit [8250] by hyatt

3 edits in trunk/WebCore

Fix for 3923255, specified percentage heights of divs with overflow auto inside tables not honored.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

4:43 PM Changeset in webkit [8249] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Kevin.

<rdar://problem/3926869> Opening caches window after running PLT causes crash

kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): Don't include simple numbers in the protected value table. (KJS::ProtectedValues::increaseProtectCount): Ditto. (KJS::ProtectedValues::decreaseProtectCount): Ditto.

4:38 PM Changeset in webkit [8248] by harrison

2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3924930> REGRESSION: triple click does not select to end of line

khtml/editing/visible_units.cpp: (khtml::endOfParagraph): When includeLineBreak is true, allow traversal to next node after enclosingBlockFlowElement.

4:16 PM Changeset in webkit [8247] by hyatt

1 edit in trunk/WebCore/kwq/KWQFoundationExtras.h

Fix Panther build bustage.

3:32 PM Changeset in webkit [8246] by kocienda

2 edits in trunk/WebCore

Reviewed by Vicki

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Missed deleting some now-obsolete expcetion codes when I added the createBreakElement() function.

3:01 PM Changeset in webkit [8245] by rjw

3 edits in trunk/WebKit

Make image decoding as lazy as possible for non-threaded case; in some cases
can avoid unnecessary decoding work.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):

2:56 PM Changeset in webkit [8244] by rjw

2 edits in trunk/WebCore

Set the floor of max cacheable object size to 40K. This restores
the long standing floor. Lower floor deleteriously impacts the PLT.
Reviewed by Hyatt.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):
khtml/misc/loader.cpp: (Cache::setSize):

2:21 PM Changeset in webkit [8243] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Stop merging nodes when a is hit. Formerly checked only for block boundary.

1:58 PM Changeset in webkit [8242] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Add KWQCFAutorelease for autoreleasing CF objects.

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): New.

1:56 PM Changeset in webkit [8241] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Fix GC compatibility in getNSString.

kwq/KWQString.mm: (QString::getNSString):

Use NSString allocator instead of CFString, so that autorelease works under GC.

11:58 AM Changeset in webkit [8240] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3890973> REGRESSION (Mail): Deleting reorders remaining text

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Added check to ensure that moving content will not move it after the <body> element.

10:57 AM Changeset in webkit [8239] by kocienda

1 edit
8 adds in trunk

Reviewed by me

Added new layout tests covering cases from recent bug fixes.

layout-tests/editing/inserting/insert-div-018-expected.txt: Added.
layout-tests/editing/inserting/insert-div-018.html: Added.
layout-tests/editing/inserting/insert-div-019-expected.txt: Added.
layout-tests/editing/inserting/insert-div-019.html: Added.
layout-tests/editing/inserting/insert-div-020-expected.txt: Added.
layout-tests/editing/inserting/insert-div-020.html: Added.
layout-tests/editing/inserting/insert-div-021-expected.txt: Added.
layout-tests/editing/inserting/insert-div-021.html: Added.

10:31 AM Changeset in webkit [8238] by kocienda

3 edits in trunk

Reviewed by me

Changes in layout resulting from giving elements no margin rather than 0.1em margin.

layout-tests/editing/inserting/insert-div-013-expected.txt
layout-tests/editing/inserting/insert-div-014-expected.txt

10:01 AM Changeset in webkit [8237] by kocienda

3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3925317> Increase quote in email and with cursor below the quote the new line appears above the quote

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
khtml/editing/visible_position.cpp: Refine rules for whether to use the starting node or the starting block as the reference node for the insertion of the new block. (khtml::isLastVisiblePositionInBlock): Tweak rules again. Descendants of following blocks should answer true. I worked this all out on the whiteboard this time. This should be the last tweak.

8:29 AM Changeset in webkit [8236] by kdecker

2 edits in trunk/WebCore

Reviewed by Ken.

Fixed <rdar://problem/3824438> Need a clean way for Dashboard to detect when an XML parsing error occurs

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock): In the xml error report, instead of a generic <div>, use <parsererror> to match Mozilla.

Dec 16, 2004:

5:05 PM Changeset in webkit [8235] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3924888> REGRESSION (Mail): Hitting return key at end of line does not insert visible newline

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Tweaked code I added just before to fix 3924486, so that it checks the downstream node for the starting position.

4:57 PM Changeset in webkit [8234] by kocienda

3 edits in trunk/WebCore

Reviewed by Chris

Added new createBreakElement() function that makes creating a element a one-liner.
Converted all the code that used to call the DocumentImpl, and dealt with the exceptionCode,
over to this new helper.

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Now uses new helper function. (khtml::InsertLineBreakCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Ditto. (khtml::createBreakElement): New helper.
khtml/editing/htmlediting.h: Ditto.

4:10 PM Changeset in webkit [8233] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed <rdar://problem/3920764> Unimplemented String methods toLocaleLowerCase and toLocaleUpperCase

kjs/string_object.h: Added toLocaleLowerCase and toLocaleUpperCase.
kjs/string_object.cpp: (StringProtoFuncImp::call): Made locale versions be synonmyms for the non-locale-specific versions.
kjs/string_object.lut.h: Regenerated.

4:03 PM Changeset in webkit [8232] by hyatt

2 edits
2 adds in trunk

Fix a bug where vertical-align values that depended on their parent's value went crazy if the parent was
vertical-align top or bottom. The bug is 3771007, bankofamerica's ebills page.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):

3:39 PM Changeset in webkit [8231] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for these bugs:

<rdar://problem/3924486> REGRESSION (Mail): Hitting return key does not insert visible newline
<rdar://problem/3924579> REGRESSION (Mail): After deleting, hitting return key does not insert visible newline

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): For the first bug, detect when inserting a will make a visible collapse. For the second bug, move the code that inserts the new after a check which may move the node used as the reference node for the insertion. Also change this code to insert the after the last sibling of the starting position, to move it past the nodes we're going to want to shift into the new .

2:44 PM Changeset in webkit [8230] by sullivan

2 edits in trunk/WebKit

Reviewed by Chris.

One of the assertions from my previous checkin fired, so
I made this code more robust.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _preferences]): new helper method, returns global preferences if webView is nil, otherwise returns webView's preferences (-[WebBridge getObjectCacheSize]): use new helper method, remove now-unnecessary assert (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): ditto

2:10 PM Changeset in webkit [8229] by darin

8 edits in trunk/WebCore

Reviewed by Ken.

use elements rather than when pasting plain text; also use margin of 0 rather than 0.1 em after talking this over with Dave and Ken

khtml/editing/htmlediting.h: Added createDefaultParagraphElement and createBlockPlaceholderElement.
khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Use new createBlockPlaceholderElement helper so this can share code with the plain-text conversion code. (khtml::InsertParagraphSeparatorCommand::createParagraphElement): Use new createDefaultParagraphElement helper so this can share code with the plain-text conversion code. (khtml::createDefaultParagraphElement): Added. (khtml::createBlockPlaceholderElement): Added.

khtml/editing/markup.cpp: (khtml::createFragmentFromText): Use paragraphs rather than elements for pasting plain text.

regenerated these files with the newer gperf

khtml/css/cssproperties.c: Regenerated.
khtml/css/cssvalues.c: Regenerated.
khtml/misc/htmlattrs.c: Regenerated.
khtml/misc/htmltags.c: Regenerated.

1:33 PM Changeset in webkit [8228] by sullivan

12 edits in trunk/WebKit

Reviewed by Darin.

fixed <rdar://problem/3913523> Mail needs SPI for adding tooltips to links
cleaned up some calls to +[WebPreferences standardPreferences] that should have been using -[WebView preferences]

This adds a (currently SPI-only) new feature that shows the URL of the link
under the mouse in a toolTip. I tested this in Safari, but we're adding this
feature for Mail, and Safari won't use it (unless of course you know the
magic defaults command)

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): use -[WebView preferences] instead of +[WebPreferences standardPreferences]

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]): ditto (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): ditto

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willCacheResponse:]): ditto

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): ditto (-[WebFrame _loadItem:withLoadType:]): ditto

WebView.subproj/WebHTMLViewInternal.h: private struct now keeps ivar for cached value of showsURLsInToolTips so it doesn't have look it up in preferences a zillion times

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): if private->showsURLsInToolTips is true, set the toolTip from the URL. Fall back to showing the title attribute in case some element has a title attribute but no URL. (-[WebHTMLView _mayStartDragAtEventLocation:]): use -[WebView preferences] instead of +[WebPreferences standardPreferences] (-[WebHTMLView _resetCachedWebPreferences:]): get a fresh value for private->showsURLsInToolTips (-[WebHTMLView initWithFrame:]): call _resetCachedWebPreferences the first time, and listen for WebPreferencesChanged notifications (-[WebHTMLView _handleStyleKeyEquivalent:]): use -[WebView preferences] instead of +[WebPreferences standardPreferences]

WebView.subproj/WebPreferenceKeysPrivate.h: added WebKitShowsURLsInToolTipsPreferenceKey

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitShowsURLsInToolTipsPreferenceKey to 0 (-[WebPreferences showsURLsInToolTips]): return WebKitShowsURLsInToolTipsPreferenceKey value (-[WebPreferences setShowsURLsInToolTips:]): set WebKitShowsURLsInToolTipsPreferenceKey value

WebView.subproj/WebPreferencesPrivate.h: add declarations for showsURLsInToolTips and setter

WebView.subproj/WebTextView.m: (-[WebTextView _preferences]): new helper method that gets preferences from webView if there is a webView, otherwise gets global preferences (-[WebTextView setFixedWidthFont]): use new helper method rather than always using global preferences (-[WebTextView initWithFrame:]): observe WebPreferencesChangedNotification instead of unnecessarily general NSUserDefaultsChangedNotification

1:15 PM Changeset in webkit [8227] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3924291> REGRESSION (Mail): Crash deleting content following a element

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement): Fixed problem in this function where recursive search for parent that is not an inline would skip past previous siblings of nodes which were blocks. Now it stops looking in this situation. This problem eventually caused the delete code to try to merge a node under a descendent.

11:21 AM Changeset in webkit [8226] by adele

2 edits in trunk/WebCore

Change by Richard, reviewed by me.

Fix for: <rdar://problem/3923983> background image decoding prevents page with 0Kb image from finishing to load

khtml/misc/loader.cpp: (CachedImage::data): Added call to notifyFinished so the 0Kb image case finishes loading.

10:53 AM Changeset in webkit [8225] by adele

2 edits in trunk/WebCore

Reviewed by Chris.

Fix for: <rdar://problem/3534824> VIP: some navigation links on safeway.com don't work due to a JavaScript quirk

Added a call to ObjectImp::get before Window::get just returns Undefined.
This was preventing us from getting the toString function from a Window object.

khtml/ecma/kjs_window.cpp: (Window::get):

10:46 AM Changeset in webkit [8224] by kocienda

3 edits
16 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3918351> REGRESSION (Mail, 173-175+): Return before first char of line leaves insertion point in wrong place

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Basically, did a rewrite of this function to do a better job than it was doing before. Added several test cases to prove I am on a better track.
khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInBlock): Tweaked the rules a bit to fix an issue very similar to the leaving-the-bar-node case problem I just fixed in a recent checkin (relevant markup: foobar). This function was returning true for the first position in "bar". Wrong. Also tightened up other rule: Should not report true when relationship between blocks cannot be determined. (khtml::isLastVisiblePositionInBlock): Tightened up rule as above: Should not report true when relationship between blocks cannot be determined.
layout-tests/editing/inserting/insert-div-010-expected.txt: Added.
layout-tests/editing/inserting/insert-div-010.html: Added.
layout-tests/editing/inserting/insert-div-011-expected.txt: Added.
layout-tests/editing/inserting/insert-div-011.html: Added.
layout-tests/editing/inserting/insert-div-012-expected.txt: Added.
layout-tests/editing/inserting/insert-div-012.html: Added.
layout-tests/editing/inserting/insert-div-013-expected.txt: Added.
layout-tests/editing/inserting/insert-div-013.html: Added.
layout-tests/editing/inserting/insert-div-014-expected.txt: Added.
layout-tests/editing/inserting/insert-div-014.html: Added.
layout-tests/editing/inserting/insert-div-015-expected.txt: Added.
layout-tests/editing/inserting/insert-div-015.html: Added.
layout-tests/editing/inserting/insert-div-016-expected.txt: Added.
layout-tests/editing/inserting/insert-div-016.html: Added.
layout-tests/editing/inserting/insert-div-017-expected.txt: Added.
layout-tests/editing/inserting/insert-div-017.html: Added.

10:18 AM Changeset in webkit [8223] by kocienda

1 edit in trunk/WebCore/khtml/editing/visible_text.h

Failed to check in this file after changing it; I hate having too many changes in my tree at once

10:04 AM Changeset in webkit [8222] by kocienda

1 edit
2 adds in trunk

Reviewed by me

Added a layout test based on my last checkin.

layout-tests/editing/selection/move-by-word-001-expected.txt: Added.
layout-tests/editing/selection/move-by-word-001.html: Added.

9:57 AM Changeset in webkit [8221] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3917929> REGRESSION (Mail): Command-left-arrow leaves insertion point too high after specific steps

khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance): Add new check for leaving a text node and iterating backwards into a different block that is an descendent of the block containing the text node (as in leaving the "bar" node in this example: foobar). (khtml::SimplifiedBackwardsTextIterator::handleNonTextNode): Call new emitNewlineForBROrText helper. (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText): Factor out code from handleNonTextNode, since it is called from there, and now also from advance().

Dec 15, 2004:

5:02 PM Changeset in webkit [8220] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed problem where plain-text would put a blank line between each even when they have no margins

khtml/editing/visible_text.cpp: (khtml::TextIterator::exitNode): Add more checks and only set the "add one more newline" flag if the margin is sufficient. A more complete fix would ignore the node type altogether and use the render tree instead.

11:13 AM Changeset in webkit [8219] by sullivan

12 edits
2 adds in trunk

WebCore:

Reviewed by Ken.

rest of WebCore fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

khtml/editing/edit_actions.h: new header, contains EditAction enum (renamed from HTMLEditAction, formerly in htmlediting.h)

ForwardingHeaders/editing/edit_actions.h: new forwarding header

khtml/editing/htmlediting.h:

removed HTMLEditAction enum in favor of including edit_actions.h; …: namespace to EditAction usages; added m_editingAction ivar to ApplyStyleCommand

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::editingAction): update for enum name change (khtml::EditCommand::editingAction): ditto (khtml::ApplyStyleCommand::ApplyStyleCommand): added editingAction parameter to this constructor (khtml::ApplyStyleCommand::editingAction): return new ivar (khtml::DeleteSelectionCommand::editingAction): update for enum name change (khtml::MoveSelectionCommand::editingAction): ditto (khtml::TypingCommand::editingAction): ditto (khtml::ReplaceSelectionCommand::editingAction): ditto

khtml/khtml_part.h: added EditAction parameter to applyStyle and computeAndSetTypingStyle
khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle): added EditAction parameter (KHTMLPart::applyStyle): ditto

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::registerCommandForUndoOrRedo): do the cast from EditAction to WebUndoAction a different way to match other code

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setTypingStyle:withUndoAction:]): added WebUndoAction parameter, passed into ApplyStyleCommand constructor (-[WebCoreBridge applyStyle:withUndoAction:]): ditto

WebCore.pbproj/project.pbxproj: updated for new files

WebKit:

Reviewed by Ken.

rest of WebKit fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

I only know of one loose end currently, which I wrote up as <rdar://problem/3920971> Edit menu
says "Undo Change Attributes" when it should say "Undo Set Color", from font panel

WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): use WebUndoActionSetColor when dragging color swatch (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): new WebUndoAction parameter, passed across bridge (-[WebHTMLView _toggleBold]): use WebUndoActionSetFont (-[WebHTMLView _toggleItalic]): use WebUndoActionSetFont (-[WebHTMLView pasteFont:]): use WebUndoActionPasteFont (-[WebHTMLView changeFont:]): use WebUndoActionSetFont (-[WebHTMLView changeAttributes:]): use WebUndoActionChangeAttributes (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): new method, returns WebUndoActionSetBackgroundColor or WebUndoActionSetColor (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): now calls _undoActionFromColorPanelWithSelector (-[WebHTMLView changeColor:]): use WebUndoActionSetColor (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): new WebUndoAction parameter, passed through (-[WebHTMLView alignCenter:]): use WebUndoActionCenter (-[WebHTMLView alignJustified:]): use WebUndoActionJustify (-[WebHTMLView alignLeft:]): use WebUndoActionAlignLeft (-[WebHTMLView alignRight:]): use WebUndoActionAlignRight (-[WebHTMLView subscript:]): use WebUndoActionAlignSubscript (-[WebHTMLView superscript:]): use WebUndoActionAlignSuperscript (-[WebHTMLView unscript:]): use WebUndoActionAlignUnscript (-[WebHTMLView underline:]): use WebUndoActionAlignUnderline

WebView.subproj/WebView.m: (-[WebView setTypingStyle:]): pass WebUndoActionUnspecified through as new parameter since we don't have any more specific info (-[WebView applyStyle:]): ditto

Dec 14, 2004:

6:42 PM Changeset in webkit [8218] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add layout test for large rowspans.

6:41 PM Changeset in webkit [8217] by hyatt

4 edits in trunk/WebCore

Fix for 3562458, rowspan and colspan converted to ints so that large values will work for them. Remove
the ridiculous 1024 limit on the span values.

khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::collapsedBottomBorder):
khtml/rendering/render_table.h: (khtml::RenderTableCell::colSpan): (khtml::RenderTableCell::setColSpan): (khtml::RenderTableCell::rowSpan): (khtml::RenderTableCell::setRowSpan): (khtml::RenderTableCol::span): (khtml::RenderTableCol::setSpan):

6:27 PM Changeset in webkit [8216] by hyatt

3 edits in trunk/WebCore

Make sure <col> and <colgroup> can have spans updated dynamically as well.

Reviewed by rjw

khtml/html/html_tableimpl.cpp: (HTMLTableColElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::updateFromElement): (RenderTableCol::updateFromElement):

6:20 PM Changeset in webkit [8215] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_table.cpp

Fix crasher caused by lack of null style check.

6:09 PM Changeset in webkit [8214] by hyatt

3 edits
2 adds in trunk

Fix for 3833123, setting a cell's colspan does not update rendering like it should.

Reviewed by rjw

khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::RenderTableCell): (RenderTableCell::updateFromElement):

6:00 PM Changeset in webkit [8213] by rjw

4 edits in trunk

WebKit:

Helper method to get URL of plugin view.

Reviewed by Chris.

Misc.subproj/WebNSViewExtras.m: (-[NSView _webViewURL]):

JavaScriptCore:

Pass URL of plugin view when call into JNI.

Reviewed by Chris.

bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):

5:53 PM Changeset in webkit [8212] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3864536> crash copying text from other apps and pasting in a sticky in dashboard

Reviewed by hyatt.

khtml/editing/markup.cpp: (khtml::createFragmentFromText): ref and deref the fragment since calling appendChild can completely deref it

5:13 PM Changeset in webkit [8211] by hyatt

2 edits
5 adds in trunk

Fix for 3785211. Make sure to do a layout with the old position before doing a layout after changing to the new position.
This is actually a regression from my positioned object DHTML optimization.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

4:36 PM Changeset in webkit [8210] by hyatt

4 edits
2 adds in trunk

Make sure the class attribute works when newlines are present in the attribute.

Reviewed by kocienda

khtml/html/html_elementimpl.cpp: (HTMLNamedAttrMapImpl::parseClassAttribute):

2:34 PM Changeset in webkit [8209] by vicki

2 edits in trunk/WebKit

Reviewed by rjw.

<rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments

Plugins.subproj/WebPlugin.h: changed instances of "WebScriptMethods" to "WebScripting" in this file as well, as requested in the bug report

1:23 PM Changeset in webkit [8208] by mjs

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3912488> Mail throws an exception after backspacing "away" inline input

WebView.subproj/WebHTMLView.m: (-[WebHTMLView setMarkedText:selectedRange:]): Don't try to set a selection if we end up with no marked text, since that case fails and is unnecessary.

11:52 AM Changeset in webkit [8207] by sullivan

3 edits in trunk/WebCore

Reviewed by Ken.

added Undo action names for Cut, Paste, and Drag

khtml/editing/htmlediting.h:
khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::editingAction): overridden to return HTMLEditActionCut (khtml::MoveSelectionCommand::editingAction): overridden to return HTMLEditActionDrag (khtml::ReplaceSelectionCommand::editingAction): overridden to return HTMLEditActionPaste

11:17 AM Changeset in webkit [8206] by sullivan

8 edits in trunk

WebCore:

Reviewed by Ken.

architecture for WebCore part of fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

The remaining step is to make each EditCommand subclass override editingAction() to return an
appropriate value. (Unfortunately the mapping between subclass and user-distinguishable action
is not completely straightforward, so this next step isn't trivial.)

khtml/editing/htmlediting.h: new enum for HTMLEditAction

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::editingAction): new method, calls through to EditCommand (khtml::EditCommand::editingAction): new method for subclasses to override, returns HTMLEditActionUnspecified at this level (khtml::TypingCommand::editingAction): proof of concept override, returns HTMLEditActionTyping

kwq/KWQKHTMLPart.h: declare new private bottleneck method registerCommandForUndoOrRedo
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::registerCommandForUndoOrRedo): new bottleneck method to reduce code duplication; now calls over the bridge to get the localized string to use for the Undo action name (KWQKHTMLPart::registerCommandForUndo): now calls new bottleneck method (KWQKHTMLPart::registerCommandForRedo): now calls new bottleneck method

kwq/WebCoreBridge.h: new enum for WebUndoAction, maps directly to HTMLEditAction. Declaration of nameForUndoAction:

WebKit:

Reviewed by Ken.

WebKit part of fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge nameForUndoAction:]): renamed from setUndoActionNamePlaceholder, replaced arbitrary integers with enum values, and handled new "unspecified" case as a fallback

9:26 AM Changeset in webkit [8205] by darin

2 edits in trunk/WebCore

Reviewed by John.

added a bunch of missing nil checks; our old version of inherits used to work for nil (by accident)

khtml/rendering/render_frames.cpp: (RenderPart::~RenderPart): Check widget for nil. (RenderPart::setWidget): Ditto. (RenderFrame::slotViewCleared): Ditto. (RenderPartObject::slotViewCleared): Ditto.

Dec 13, 2004:

8:08 PM Changeset in webkit [8204]

5 copies
2 deletes in tags/WebCore-175~1

This commit was manufactured by cvs2svn to create tag
'WebCore-175~1'.

8:08 PM Changeset in webkit [8203] by vicki

2 edits in branches/Safari-175-branch/WebCore

versioning for dot submission, WebCore-175.1

8:00 PM Changeset in webkit [8202] by vicki

2 edits in branches/Safari-175-branch/WebCore

fix <rdar://problem/3915008> REGRESSION (Mail): Too much white space between lines separated by carriage returns for dot submission to Tiger.

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):

6:44 PM Changeset in webkit [8201] by rjw

6 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3827799> repro. crash with IBM Rational ClearCase Web under Safari (Java/LiveConnect-related)

Add support for calling static Java methods from JavaScript.

Reviewed by Maciej.

bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::isStatic):
bindings/jni/jni_utility.cpp: (callJNIStaticMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIStaticBooleanMethod):
bindings/jni/jni_utility.h:

4:29 PM Changeset in webkit [8200] by rjw

7 edits in trunk

WebKit:

Fixed <rdar://problem/3887767> LiveConnect doesn't propagate Java exceptions back to JavaScript (prevents security suite from running)

Reviewed by John.

Plugins.subproj/WebJavaPlugIn.h:

JavaScriptCore:

Fixed <rdar://problem/3887767> LiveConnect doesn't propagate Java exceptions back to JavaScript (prevents security suite from running)

Reviewed by John.

bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
bindings/jni/jni_runtime.h:
bindings/jni/jni_utility.h:

4:15 PM Changeset in webkit [8199] by sullivan

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed <rdar://problem/3744583> Safari can not quit when a webpage has a login sheet that can't be cancelled.

The proper fix for this would be to change the class of the NSPanel in the nib file.
But since this would require a localization change, I did a run-time hack instead.
I'll file a bug about fixing this when we're out of localization freeze.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel replacePanelWithSubclassHack]): new method, creates a new panel that is identical to the original one except that it's our subclass, and moves all the subviews of the original panel into the new one. (-[WebAuthenticationPanel loadNib]): call replacePanelWithSubclassHack (-[NonBlockingPanel _blocksActionWhenModal:]): only method of new NSPanel subclass; overrides this SPI to allow the user to quit when one of these panels/sheets is on-screen

4:10 PM Changeset in webkit [8198] by darin

34 edits
3 adds in trunk/WebCore

Reviewed by Ken.

moved markup-related functions into new sources files in the editing directory
removed all of the uses of dynamic_cast, preparing to turn off RTTI to make our code smaller and slightly faster

ForwardingHeaders/editing/markup.h: Added.
khtml/editing/markup.h: Added.
khtml/editing/markup.cpp: Added.

WebCore.pbproj/project.pbxproj: Added markup.h/cpp.

khtml/dom/dom_node.cpp: (Node::toHTML): Call createMarkup since there's no toHTML in NodeImpl any more.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerHTML): Changed to call createMarkup. (HTMLElementImpl::outerHTML): Ditto.

khtml/ecma/kjs_window.cpp: (Window::retrieveWindow): Comment out assert that uses dynamic_cast. (Window::retrieveActive): Ditto.

khtml/editing/htmlediting.h: Added forward class declaration needed now that I removed one elsewhere.
khtml/xml/dom_docimpl.h: Ditto.

khtml/khtml_part.cpp: (KHTMLPart::slotDebugDOMTree): Use createMarkup instead of toHTML. (KHTMLPart::processObjectRequest): Use inherits instead of dynamic_cast.

khtml/rendering/render_image.cpp: (RenderImage::paint): Add an explicit QChar conversion so this code still works even with the additional replace overloads added to QString.
kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Ditto.

khtml/rendering/render_object.h: Removed the version of arenaDelete that does not take an object base pointer, because it used dynamic_cast in its implementation. Made the other version public.
khtml/rendering/render_object.cpp: Ditto.
khtml/rendering/render_replaced.cpp: (RenderWidget::deref): Pass object base pointer to arenaDelete.

khtml/xml/dom2_rangeimpl.h: Removed extra parameters from toHTML, and unneeded includes and declarations.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Changed to call createMarkup, and moved all the support code into markup.cpp.

khtml/xml/dom_nodeimpl.h: Moved toHTML and related functions into markup.cpp.
khtml/xml/dom_nodeimpl.cpp: Ditto.

khtml/xml/dom_position.cpp: (DOM::startPosition): Implemented the version of this that takes a RangeImpl. Also added null checks so these return null positions rather than raising exceptions. (DOM::endPosition): Ditto.

khtml/khtmlview.h: Added an APPLE_CHANGES function so inherits can detect this class without dynamic_cast.
kwq/KWQFrame.h: Ditto.
kwq/KWQFrame.mm: (QFrame::isQFrame): Ditto.
kwq/KWQKPartsPart.h: Ditto.
kwq/KWQKPartsPart.mm: (KParts::ReadOnlyPart::isKPartsReadOnlyPart): Ditto.
kwq/KWQScrollView.h: Ditto.
kwq/KWQScrollView.mm: (QScrollView::isQScrollView): Ditto.
kwq/KWQKHTMLPart.h: Ditto.
kwq/KWQKHTMLPart.mm: (KHTMLView::isKHTMLView): Ditto. (KWQKHTMLPart::setTitle): Added an explicit QChar conversion so this code still works even with the additional replace overloads added to QString. (KWQKHTMLPart::setStatusBarText): Ditto. (KWQKHTMLPart::runJavaScriptAlert): Ditto. (KWQKHTMLPart::runJavaScriptConfirm): Ditto. (KWQKHTMLPart::runJavaScriptPrompt): Ditto. (KWQKHTMLPart::attributedString): Ditto. (KWQKHTMLPart::isCharacterSmartReplaceExempt): Ditto. (KWQKHTMLPart::isKHTMLPart): That dynamic_cast thing (see above).

kwq/KWQObject.h: Added virtual methods for the few cases where we need dynamic_cast-like behavior.
kwq/KWQObject.mm: (QObject::inherits): Changed to not use dynamic cast. (QObject::isKHTMLPart): Added. Returns false. (QObject::isKHTMLView): Ditto. (QObject::isKPartsReadOnlyPart): Ditto. (QObject::isQFrame): Ditto. (QObject::isQScrollView): Ditto.

kwq/KWQRenderTreeDebug.cpp: (write): Changed to use inherits rather than dynamic_cast. (writeSelection): Ditto.

kwq/KWQSlot.mm: (KWQSlot::call): Call through to the version with just a job pointer parameter rather than going straight on to the "no parameters at all" version.

kwq/KWQString.h:
kwq/KWQString.mm: (QString::replace): Added overloads.
kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]): Changed to call functions in markup.h. (-[WebCoreBridge markupStringFromRange:nodes:]): Ditto. (-[WebCoreBridge selectedString]): Added an explicit QChar conversion so this code still works even with the additional replace overloads added to QString. (-[WebCoreBridge stringForRange:]): Ditto. (-[WebCoreBridge copyDOMNode:copier:]): Changed to call functions in markup.h. (-[WebCoreBridge elementAtPoint:]): QChar conversion. (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): Changed to call functions in markup.h. (-[WebCoreBridge documentFragmentWithText:]): Changed to call functions in markup.h.

3:17 PM Changeset in webkit [8197] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3917956> REGRESSION (Mail): pasting can leave insertion point inside pasted text

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Fix coding mistake. Calculations of bool flag based on leading and trailing whitespace positions was reversed! I must have introduced this error recently when changing around this code.

2:59 PM Changeset in webkit [8196] by hyatt

3 edits in trunk/WebCore

Fix for 3915787, macobserver doesn't paint. floatRect() needed to be const in the base class. Also hit-testing
and painting was using the wrong rect when setting up the x/y of the rect.

Reviewed by mjs

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::nodeAtPoint):
khtml/rendering/render_object.h: (khtml::RenderObject::floatRect):

2:41 PM Changeset in webkit [8195] by kocienda

3 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3917863> REGRESSION (Mail): pasting two lines of plain text copied from an RTF document results in two styles

Code to figuire out the end node to merge was missing the font tag in the second paragraph
written out by AppKit convert-to-HTML function. I refined the algorithm to be smarter.

khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::mergeEndNode): Refine algorithm used to walk through the fragment being pasted looking for the node that is the last inline in the last block of the fragment. The old algorithm was insufficiently powerful. (khtml::ReplacementFragment::enclosingBlock): New helper function.
khtml/editing/htmlediting.h: Add declaration for new helper function.
layout-tests/editing/pasteboard/paste-text-011-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-011.html: Added.

1:01 PM Changeset in webkit [8194] by kocienda

8 edits in trunk/WebCore

Reviewed by John

WebCore side of fix for this bug:

<rdar://problem/3768372> REGRESSION (Mail): paste of text ending in whitespace loses whitespace

Note that we are coordinating with Doug Davidson on the AppKit team to make a complete fix for this
bug. This change involves our half of the needed changes.

Note that a lot of this change has to do with changing code to use a element instead of
a comment node as the mechanism to annotate HTML with information used to fix the bug. In some
other places, code to handle comments in markup can be removed since we do not use comments for
such annotations after this change.

khtml/editing/htmlediting.cpp: Remove isComment() helper; no longer needed. (khtml::ReplacementFragment::ReplacementFragment): Change m_hasInterchangeNewlineComment name to m_hasInterchangeNewline. (khtml::ReplacementFragment::isInterchangeNewlineNode): Name changed from isInterchangeNewlineComment. (khtml::ReplacementFragment::isInterchangeConvertedSpaceSpan): Local variable name convertedSpaceSpanClass changed to convertedSpaceSpanClassString to match other uses of the idiom used here. (khtml::ReplaceSelectionCommand::doApply): Change hasInterchangeNewlineComment() name to hasInterchangeNewline().
khtml/editing/htmlediting.h: Change names as noted in .cpp file. Remove isComment() helper; no longer needed. (khtml::ReplacementFragment::hasInterchangeNewline): Change hasInterchangeNewlineComment() name to hasInterchangeNewline().
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): No longer has includeCommentsInDOM flag; no longer needed as we do not annotate fragments with comments any longer.
khtml/html/html_elementimpl.h: Ditto.
khtml/xml/dom2_rangeimpl.cpp: Remove addCommentToHTMLMarkup() helper. No longer needed. (DOM::interchangeNewlineMarkupString): New helper to return element markup we use to annotate content for interchange. (DOM::RangeImpl::toHTML): No longer uses addCommentToHTMLMarkup; now calls interchangeNewlineMarkupString(). Remove spurious semi-colon.
khtml/xml/dom2_rangeimpl.h: Remove obsolete addCommentToHTMLMarkup() function and EAddToMarkup enum.
kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): No longer pass bool to ask for including comments in DOM when calling createContextualFragment().

12:59 PM Changeset in webkit [8193] by vicki

3 edits in trunk

Versions were backwards in TOT. They should read Safari 2.0 (175+), not Safari 175+ (2.0).

Dec 10, 2004:

5:48 PM Changeset in webkit [8192] by sullivan

2 edits in trunk/WebCore

fixed deployment build bustage that John Louch ran into

kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): move bool declaration inside exception-handling block to avoid obscure compiler error

3:15 PM Changeset in webkit [8191] by mjs

2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3907484> REGRESSION (125-173): crash when KWQTextField is dealloc'ed while setting focus (profoundlearning.com)

kwq/KWQWidget.mm: (QWidget::setFocus): Handle the case where setting focus removed us from the superview - this can happen due to style changes on focus change.

3:02 PM Changeset in webkit [8190] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3915008> REGRESSION (Mail): Too much white space between lines separated by carriage returns

There are a number of interesting things we could do to fix this bug, including SPI and involving
the WebKit delegate, etc., however it seems reasonable to start with a hard-coded default that
will fix the bug in the general case until such time as we can come up with more specific
solutions.

So, I added a helper method to create elements with an inline style that sets top and bottom margins
to 0.1em.

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::createParagraphElement): New factory method to create paragraph elements to insert. Also adds style information to keep the from having "too-big" margins. (khtml::InsertParagraphSeparatorCommand::doApply): Call new factory method.
khtml/editing/htmlediting.h: Add createParagraphElement() declaration.

2:15 PM Changeset in webkit [8189] by darin

6 edits in trunk/WebCore

Reviewed by Hyatt.

fixed <rdar://problem/3910419> setting style={overflow:hidden} for <textarea> does not prevent appearance of scrollbars

khtml/rendering/render_form.h: Remove now-unneeded wrap parameter.
khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Convert to QChar explicitly. (RenderLineEdit::updateFromElement): Ditto. (RenderLineEdit::slotTextChanged): Ditto. (RenderSelect::updateFromElement): Ditto. (TextAreaWidget::TextAreaWidget): Moved out most of the initialization since it's not something that requires a derived class. Now we don't use this class at all for WebCore, but they still have it for KDE. (TextAreaWidget::event): Moved out the ifdefs. (RenderTextArea::RenderTextArea): Moved setting code from TextAreaWidget here. Put a bunch that we don't need at all inside !APPLE_CHANGES, and removed the setting for scroll bars, since that's now done in setStyle. (RenderTextArea::handleFocusOut): Use type QTextEdit instead of TextAreaWidget since that's all that's needed and WebCore no longer has TextAreaWidget. (RenderTextArea::calcMinMaxWidth): Ditto. (RenderTextArea::setStyle): Add code to set scroll bar modes based on wrap setting combined with overflow style. (RenderTextArea::updateFromElement): Use type QTextEdit. (RenderTextArea::text): Ditto. (RenderTextArea::select): Ditto.

kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Don't set horizontal scroller visibility here, since it's now handled by QTextEdit. (-[KWQTextArea initWithFrame:]): Don't set vertical scroller visibility or scroller auto-hiding.

kwq/KWQTextEdit.h: Add setScrollBarModes function to be used instead of separate setter for the horizontal and vertical mode; needed because AppKit switches "autohide" for both at once.
kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Added.

1:57 PM Changeset in webkit [8188] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3915047> HItting return in empty document inserts but
insertion point does not move

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): The issue is that the code to insert the element for the return is not detecting the fact that the document is empty. Inserting a into an empty body will not "add a new line" as the user expects. With this change, we'll add a second when the root editable element has no rendered kids.

1:13 PM Changeset in webkit [8187] by mjs

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3912979> REGRESSION (125-173): repro crash in HTMLCollectionImpl code (www.clubtravel.ie)

khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Pass base when traversing the initial one step, otherwise we might inadvertantly step outside the collection base, thereby causing assertion failures or other badness later.

1:10 PM Changeset in webkit [8186] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): There is a starting block which is supposed to act as the root node for this operation. However, a loop was incorrectly coded, and a parent node search could escape this node. Also, one other piece to code to move nodes to the new element should do nothing if the starting point for the selection is itself the starting block. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Similar changes, in spirit, to the above function, though the names and concepts are slightly different.

1:09 PM Changeset in webkit [8185] by mjs

6 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3907705> REGRESSION (172-173): DHTML menus are broken at hrweb.apple.com

khtml/dom/html_document.cpp: (HTMLDocument::nameableItems): New method, wrapper for HTMLCollection creation.
khtml/dom/html_document.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): use doc.nameableItems(), not doc.all()!
khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Added new DOC_NAMEABLE_ITEMS type, this represents the items that can be accessed directly as a document propery, in particular forms, images, objects, applets and embeds. (HTMLCollectionImpl::updateNameCache): Fix some nameCache/idCache confusion. (HTMLFormCollectionImpl::updateNameCache): Ditto.
khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::): Added new type.

12:23 PM Changeset in webkit [8184] by rjw

5 edits in trunk/WebKit

Fixed <rdar://problem/3898708> REGRESSION (8A314-8A317): World Clock's short hand not displayed (ImageIO problem with PDF?)
Fixed <rdar://problem/3914012> use CG directly for pdf images not ImageIO

Create a PDF document and draw that instead of using ImageIO to create a rasterized image.

Reviewed by Maciej.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData setIsPDF:]): (-[WebImageData isPDF]): (-[WebImageData dealloc]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageData size]): (-[WebImageData animate]): (-[WebImageData _createPDFWithData:]): (-[WebImageData _PDFDocumentRef]): (-[WebImageData _PDFDrawInContext:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (_createImageRef):

10:53 AM Changeset in webkit [8183] by sullivan

2 edits in trunk/WebKit

Reviewed by Ken.

fixed <rdar://problem/3855127> Error while printing w/o sheet, then window is left in a bad state, if there's no default printer set

WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Our implementation of knowsPageRange puts the WebHTMLView into a special "printing mode". We must exit the "printing mode" to return to normal behavior. This is normally done in endDocument. However, it turns out that if there's an exception in [super beginDocument], then endDocument will not be called (lame-o AppKit API). So, we handle that case by catching the exception and exiting the "printing mode" in beginDocument when it occurs.

10:45 AM Changeset in webkit [8182] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3914779> REGRESSION (Mail): Cannot arrow navigate to position before last character on text-wrapped line

khtml/rendering/render_text.cpp: (RenderText::caretRect): Code was not detecting space at the end of a line correctly. Now it does.

9:11 AM Changeset in webkit [8181] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3914755> REGRESSION (Mail): Insertion point disappears after pasting paragraph

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Selection could end up in a "placeholder" node that was removed from the document when pasting. This caused the disappearance. Now this is detected, and the selection is shifted to a node that is in the document.

8:29 AM Changeset in webkit [8180] by kocienda

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Remove conflict marker

Dec 9, 2004:

8:38 PM Changeset in webkit [8179] by rjw

2 edits in trunk/WebCore

Check to disable threaded decoding during
layout tests wasn't invoking function, just checking address of
function, which would always return true.

kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]):

7:09 PM Changeset in webkit [8178] by rjw

4 edits in trunk/WebKit

Fixed <rdar://problem/3905789> Burn Disc image vibrates rapidly

Restrict our support for animated images to GIF. We used to
use presence of more than one image in a resource to determine
if an image should be animated. This caused us to animate icns!
If we ever support any other animated image formats we'll have
to extend.

Reviewed by Hyatt.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData shouldAnimate]):
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):

7:05 PM Changeset in webkit [8177] by hyatt

3 edits in trunk/WebCore

Fix for 3892686, left/top overflow was not being propagated properly up to containing blocks because of a math
error.

Also fix a bug I noticed on the same page where relative position offsets were not being added in properly for
all inlines when repainting.

Reviewed by rjw

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):

5:46 PM Changeset in webkit [8176] by rjw

2 edits in trunk/WebKit

Make WebPluginDatabase.h private (Dashboard needs SPI).

WebKit.pbproj/project.pbxproj:

5:38 PM Changeset in webkit [8175] by hyatt

1 add in trunk/LayoutTests/fast/block/float/tableshifting-expected.txt

New layout test to cover more details of tables shifting below floats.

5:38 PM Changeset in webkit [8174] by hyatt

6 edits
1 add in trunk

Fix for 3867545, finance.yahoo.com lays out incorrectly. Add a quirk that will prevent tables from moving
down below floats when there is insufficient space. Instead we will match Gecko and just spill out of the
containing block to the right. This appears to be the more common desired behavior, despite being wrong.
WinIE sometimes wraps and sometimes doesn't, but it's really hard for us to match its inconsistency.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::getClearDelta):
layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
layout-tests/apple-only/base/www.excite.com/index-expected.txt:
layout-tests/fast/block/margin-collapse/102-expected.txt:
layout-tests/fast/block/margin-collapse/102.html:

5:15 PM Changeset in webkit [8173] by rjw

2 edits in trunk/WebCore

Fixed <rdar://problem/3914078> worldclock crashing gc related

Use ProtectedValue for Context2D instance members.

Reviewed by Maciej.

khtml/ecma/kjs_html.h:

4:37 PM Changeset in webkit [8172] by sullivan

2 edits in trunk/WebCore

Reviewed by Dave.

fixed <rdar://problem/3731099> Move AXTitle string for image elements to AXDescription

kwq/KWQAccObject.mm: (-[KWQAccObject title]): moved image alt tag code out of here (-[KWQAccObject accessibilityDescription]): moved image alt tag code into this new method (-[KWQAccObject accessibilityAttributeNames]): include AXDescription in the set of attributes that ordinary elements return; this means that ordinary elements that aren't images will return a nil description, which isn't ideal, but is in keeping with the way the rest of these attributes work here. (-[KWQAccObject accessibilityAttributeValue:]): call accessibilityDescription when asked for AXDescription

4:10 PM Changeset in webkit [8171] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref

khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.

4:00 PM Changeset in webkit [8170] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (175+)

3:53 PM Changeset in webkit [8169]

2 copies in branches/Safari-175-branch

This commit was manufactured by cvs2svn to create branch
'Safari-175-branch'.

3:53 PM Changeset in webkit [8168]

2 copies in tags/Safari-175

This commit was manufactured by cvs2svn to create tag 'Safari-175'.

3:53 PM Changeset in webkit [8167] by vicki

6 edits in trunk

Safari-175 stamp (skipped Safari-174 because it ends in a "4")

2:41 PM Changeset in webkit [8166] by kocienda

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Rolling out change. Tree was closed.

2:40 PM Changeset in webkit [8165] by kocienda

2 edits in trunk/WebCore

Rolling out change. Tree was closed.

2:37 PM Changeset in webkit [8164] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref

khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.

11:49 AM Changeset in webkit [8163] by cblu

2 edits in trunk/WebKit

Workaround for this exception being raised during download:
[WebDownload connection:willStopBufferingData:]: selector not recognized

Reviewed by john.

Misc.subproj/WebDownload.m: (-[WebDownload connection:willStopBufferingData:]): implement this method so no exception is raised. It is a bug in Foundation that this method is being called, but it's too late to fix Foundation since it has already been submitted this week. This workaround will prevent any problems from affecting users.

11:21 AM Changeset in webkit [8162] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3912841> REGRESSION (173-TOT): Some images report 0x0 dimensions on layout tests, causes spurious test failures

The new threaded image decoding capability can throw off layout tests. The issue is that the decoding
callback may not be delivered before the program asks for the dimensions of an image in order to
wrote the layout dimensions. More generally, I think we need to ensure that there are no races in
layout tests, so I have added a flag to the render tree debug code that we can set when debugging.

kwq/KWQRenderTreeDebug.cpp: (debuggingRenderTree): New function. Returns flag which tells whether the program is debugging the render tree. (externalRepresentation): Sets debuggingRenderTree flag to true;
kwq/KWQRenderTreeDebug.h:
kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): Checks debuggingRenderTree flag and will not do threaded decoding in any case if the flag is set.

10:57 AM Changeset in webkit [8161] by cblu

5 edits in trunk/WebCore

Fix for busting XMLHTTPRequest.

Reviewed by kocienda.

khtml/misc/loader.cpp: (Loader::servePendingRequests): pass true for deliverAllData
kwq/KWQKJob.h: (KIO::get): take deliverAllData param (KIO::http_post): ditto
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): if deliverAllData, create signal with data param (KIO::TransferJob::emitResult): if deliverAllData, call signal with data param

7:32 AM Changeset in webkit [8160] by kocienda

2 edits in trunk/WebCore

Reviewed by John

<rdar://problem/3911011> REGRESSION (Mail): Spaces at end of line causing word wrap lost when copied/pasted

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::renderedText): Fixed the code so that spaces at the end of lines are not skipped.

Dec 8, 2004:

5:20 PM Changeset in webkit [8159] by rjw

3 edits in trunk/WebKit

Fixed <rdar://problem/3911719> REGRESSION: Images no longer scale vertically
Account for scaling correctly when taking into account progressively

loaded images.

Also added implementation of repetition count for animated GIF images.
Also replaced strings with new constants from CFImageProperties.h

Also fixed possible problem with -(NSSize)size implementation,
relevant to Panther only.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _floatProperty:type:at:]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _repetitionCount]):
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):

2:54 PM Changeset in webkit [8158] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/3908017> REGRESSION (172-173): assertion in ObjectImp::construct trying to create JS error (24hourfitness.com)

The fix was to implement copy constructor and assignment operator,
the ones that worked on the base class did not replace the
defaults apparently!

kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::operator=):

Also fixed a bug in the GC test mode that compares the results of
the old collector and the new collector.

kjs/value.cpp: (ValueImp::mark):

1:58 PM Changeset in webkit [8157] by cblu

4 edits in trunk/WebKit

Removed NPN wrappers since these no longer need to be defined to make the QT plug-in work
since 3828925 has been fixed.

Reviewed by john.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): use under-bar symbols since non-under-bar wrappers have been removed
Plugins.subproj/npapi.m: removed NPN wrappers
WebKit.exp: removed symbols

8:30 AM Changeset in webkit [8156] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Work around for this bug: <rdar://problem/3908282> REGRESSION (Mail): No drag image dragging selected text in Blot and Mail The reason for the workaround is that this method is called explicitly from the code to generate a drag image, and at that time, getRectsBeingDrawn:count: will return a zero count. This code change uses the passed-in rect when the count is zero.

Dec 7, 2004:

4:27 PM Changeset in webkit [8155] by cblu

3 edits in trunk/WebKit

WebKit:

Support for fix for:
<rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click

Reviewed by john.

Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): renamed to take relativeToURL parameter (+[NSURL _web_URLWithUserTypedString:]): call _web_URLWithUserTypedString:relativeToURL: with nil for URL

WebBrowser:

Fixed: <rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click

Reviewed by john.

TitleBarButton.m:

(-[TitleBarButton showPathRepresentingPopUpMenu]): use …: since the path returned by [NSURL path] is of the "user typed" variety

3:39 PM Changeset in webkit [8154] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3905564> REGRESSION (Tiger); in History menu, pixel size appears but is wrong for standalone images in Safari.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):

3:06 PM Changeset in webkit [8153] by rjw

17 edits
4 adds in trunk

WebCore:

Support threaded image decoding on machines w/ > 2 CPUs.

Reviewed by Maciej and Chris.

khtml/misc/loader.cpp: (CachedImageCallback::notifyUpdate): (CachedImageCallback::notifyFinished): (CachedImageCallback::notifyDecodingError): (CachedImageCallback::handleError): (CachedImageCallback::clear): (CachedImage::CachedImage): (CachedImage::clear): (CachedImage::data): (CachedImage::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::numRequests): (Loader::cancelRequests): (Loader::removeBackgroundDecodingRequest):
khtml/misc/loader.h: (khtml::CachedImageCallback::CachedImageCallback): (khtml::CachedImageCallback::ref): (khtml::CachedImageCallback::deref): (khtml::CachedImage::decoderCallback):
khtml/rendering/render_object.cpp: (RenderObject::setPixmap):
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (-[WebImageCallback initWithCallback:khtml::]): (-[WebImageCallback _commonTermination]): (-[WebImageCallback dealloc]): (-[WebImageCallback finalize]): (-[WebImageCallback notify]): (-[WebImageCallback setImageSourceStatus:]): (-[WebImageCallback status]): (QPixmap::shouldUseThreadedDecoding): (QPixmap::receivedData):
kwq/WebCoreImageRenderer.h:
kwq/WebCoreImageRendererFactory.h:
kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): (+[WebCoreImageRendererFactory setShouldUseThreadedDecoding:]):

WebKit:

Support threaded image decoding on machines w/ > 2 CPUs.

Reviewed by Maciej and Chris.

Misc.subproj/WebKitSystemBits.h:
Misc.subproj/WebKitSystemBits.m: (WebSystemMainMemory): (WebNumberOfCPUs):
WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (+[WebImageData initialize]): (-[WebImageData init]): (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData _invalidateImages]): (-[WebImageData _imageSourceOptions]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _createImages]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _frameDuration]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]):
WebCoreSupport.subproj/WebImageDecodeItem.h: Added.
WebCoreSupport.subproj/WebImageDecodeItem.m: Added. (+[WebImageDecodeItem decodeItemWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem initWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem finalize]): (-[WebImageDecodeItem dealloc]):
WebCoreSupport.subproj/WebImageDecoder.h: Added.
WebCoreSupport.subproj/WebImageDecoder.m: Added. (decoderNotifications): (+[WebImageDecoder initialize]): (+[WebImageDecoder notifyMainThread]): (+[WebImageDecoder sharedDecoder]): (+[WebImageDecoder performDecodeWithImage:data:isComplete:callback:]): (+[WebImageDecoder imageDecodesPending]): (+[WebImageDecoder decodeComplete:status:]): (-[WebImageDecoder init]): (-[WebImageDecoder dealloc]): (-[WebImageDecoder finalize]): (-[WebImageDecoder removeItem]): (-[WebImageDecoder addItem:]): (-[WebImageDecoder decodeItem:]): (decoderThread): (startDecoderThread):
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebInternalImage incrementalLoadWithBytes:length:complete:callback:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation receivedData:withDataSource:]): (-[WebImageRepresentation receivedError:withDataSource:]): (-[WebImageRepresentation finishedLoadingWithDataSource:]):

WebBrowser:

Added a menu item to enable/disable threaded image decoding.

Reviewed by Maciej and Chris.

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]): (-[BrowserDocument toggleUseThreadedImageDecoding:]): (-[BrowserDocument validate_toggleUseThreadedImageDecoding:]):

12:46 PM Changeset in webkit [8152] by cblu

2 edits in trunk/WebKit

Fix for performance regression.

Reviewed by kevin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): construct the WebResource without copying the data

12:05 PM Changeset in webkit [8151] by cblu

5 edits in trunk/WebKit

Fixed: <rdar://problem/3909243> REGRESSION: large standalone images stop loading part way through

Reviewed by kevin.

WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): call super so it buffers the data

11:01 AM Changeset in webkit [8150] by kocienda

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix my NOBODY (OOPS!). John reviewed.

10:13 AM Changeset in webkit [8149] by kocienda

2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Fix a problem with my change in thei code yesterday. Call to insertBlockPlaceholderIfNeeded() must be done after new block has been inserted, otherwise a crash can result. Shuffle down call to insertBlockPlaceholderIfNeeded() a couple of lines (where the node is inserted), and all is good.

10:01 AM Changeset in webkit [8148] by kocienda

2 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3907422> REGRESSION (Mail): Pasting quoted content can place content after body element

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Detect when the body element is the "reference block" used for determining the location for inserting content. Do not allow an insert before or after if the reference block is the body. Perform insertNodeAt(0) and appendNode, respectively, in the block-is-body case.
layout-tests/editing/inserting/insert-3907422-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3907422-fix.html: Added.

9:45 AM Changeset in webkit [8147] by darin

2 edits in trunk/WebCore

Reviewed by Don.

fixed <rdar://problem/3908701> REGRESSION: Cursor does not change to "hand" over active links

kwq/KWQEvent.mm: (positionForEvent): Add NSMouseMoved to list of events that have mouse location.

9:02 AM Changeset in webkit [8146] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Changed name of constant from KHTMLInterchangeNewline to AppleInterchangeNewline.
I discussed this with Hyatt and he agreed that going with "Apple" names was OK.

khtml/editing/html_interchange.h: Name change, as described above.
khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::isInterchangeNewlineComment): Ditto.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Ditto.

7:09 AM Changeset in webkit [8145] by kocienda

1 edit
4 adds in trunk

Reviewed by me

Added a couple more layout tests.

layout-tests/editing/deleting/delete-line-013-expected.txt: Added.
layout-tests/editing/deleting/delete-line-013.html: Added.
layout-tests/editing/deleting/delete-line-014-expected.txt: Added.
layout-tests/editing/deleting/delete-line-014.html: Added.

Dec 6, 2004:

8:11 PM Changeset in webkit [8144] by rjw

2 edits in trunk/WebKit

Use the AppKit's font rendering mode. This fixes 3905347, but we still need to track down
and resolve why metrics have changed for Courier. This may be caused by changes in
AppKit for 3902394.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (_AppkitGetCGRenderingMode): (getUncachedWidth): (_drawGlyphs):

6:26 PM Changeset in webkit [8143] by mjs

2 edits in trunk/WebCore

Reviewed by Hyatt.

fixed <rdar://problem/3906974> assertion failure in QWidget::beforeMouseDown clicking on <select multiple>

kwq/KWQListBox.mm: (QListBox::QListBox): Initialize KWQListBoxScrollView with this. (-[KWQListBoxScrollView initWithListBox:]): Make this class a KWQWidgetHolder. (-[KWQListBoxScrollView widget]): See above. (-[KWQTableView mouseDown:]): Pass outerView rather than self to beforeMouseDown and afterMouseDown, to avoid triggering an assertion failure.

6:09 PM Changeset in webkit [8142] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add table test to cover the document.write line layout bug.

6:09 PM Changeset in webkit [8141] by hyatt

5 edits in trunk/WebCore

Fix for 3615411, the linesAppended optimization was old and broken, and it's easier with the new code fixes
made by me, kocienda and harrison to just remove it.

Reviewed by mjs

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
khtml/rendering/render_block.cpp: (khtml:::RenderFlow):
khtml/rendering/render_block.h:
khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):

5:36 PM Changeset in webkit [8140] by hyatt

5 edits in trunk/WebCore

Fix for 3787133, some web pages print with many blank pages. Make sure to use the real page print rect and
not a damage rect that can be changed when intersected with the clip regions of the web page.

Reviewed by john

khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printRect): (khtml::RenderCanvas::setPrintRect):
khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
khtml/rendering/render_list.cpp: (RenderListMarker::paint):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::adjustPageHeight):

4:47 PM Changeset in webkit [8139] by cblu

2 edits in trunk/WebKit

Forgot to commit copied header.

DOM.subproj/DOMPrivate.h:

4:45 PM Changeset in webkit [8138] by harrison

2 edits in trunk/WebCore

Reviewed by Ken Kocienda and Dave Hyatt (OOPS!).

<rdar://problem/3849947> Typing after pasting line does not appear until after window resize.

khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):

Dirty the line above because new child can inval the cached line break position of previous line.

4:34 PM Changeset in webkit [8137] by hyatt

15 edits in trunk/WebCore

Fix for 3254464, radio buttons do not work for quiz on netscape.com. Left/top overflow needed to be implemented.
This also fixes 3106907, link hover color only partially set on rollover and the more general architecture bug
3126929, handle top/left overflow.

This patch also fixes 3902891, scroll bar of position:fixed content moves when a page is scrolled.

Finally, the Emerson regression 3869718 (error involving computing the rightmost/lowest position of overflow:auto
regions and web pages) has been fixed.

Reviewed by mjs

khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::checkLinesForOverflow):
khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::overflowHeight): (khtml::RenderBlock::overflowWidth): (khtml::RenderBlock::overflowLeft): (khtml::RenderBlock::overflowTop): (khtml::RenderBlock::overflowRect): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paint): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition): (khtml::RenderBlock::nodeAtPoint):
khtml/rendering/render_block.h:
khtml/rendering/render_box.h: (khtml::RenderBox::borderBox): (khtml::RenderBox::borderTopExtra): (khtml::RenderBox::borderBottomExtra):
khtml/rendering/render_layer.cpp: (RenderLayer::paintScrollbars): (mustExamineRenderer): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally): (khtml::InlineFlowBox::verticallyAlignBoxes):
khtml/rendering/render_line.h: (khtml::InlineBox::leftOverflow): (khtml::InlineBox::rightOverflow): (khtml::InlineFlowBox::setVerticalOverflowPositions): (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::leftOverflow): (khtml::RootInlineBox::rightOverflow): (khtml::RootInlineBox::setVerticalOverflowPositions): (khtml::RootInlineBox::setHorizontalOverflowPositions):
khtml/rendering/render_object.h: (khtml::RenderObject::borderBox): (khtml::RenderObject::overflowLeft): (khtml::RenderObject::overflowTop): (khtml::RenderObject::overflowRect): (khtml::RenderObject::floatRect):
khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint): (RenderTable::paintBoxDecorations): (RenderTable::calcMinMaxWidth):
khtml/rendering/render_table.h: (khtml::RenderTableCell::borderTopExtra): (khtml::RenderTableCell::borderBottomExtra):
kwq/KWQRect.h:
kwq/KWQRect.mm: (QRect::inflate):

4:24 PM Changeset in webkit [8136] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.

I considered a few other possible exploits and made no change:

document.location is already protected because the document object itself is protected

frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):

3:57 PM Changeset in webkit [8135] by kocienda

4 edits in trunk

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3890955> 8A314: Forward delete sometimes fails to delete the selected quoted text

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete): Fixed bonehead coding mistake in the check for one of the special cases being checked for in this function. The specific case intends to check for a selection that is only a after a block ends (as in </div> ). If it sees such markup, it deletes only the and bails. However, this code would run in *any* case where a selection ended in a after a block and would not delete any part of the selection preceding the . Bad. I have tightened the check to see that only a is selected.

Fixing the bug above was accomplished with an additional call to DOM::Position::downstream. This
new use of the function exposed this bug:

<rdar://problem/3907666> Incorrectly coded loop in Position::downstream can lead to infinite loop

khtml/xml/dom_position.cpp: (DOM::Position::downstream): I am ashamed of my first cut at this. Rewrote the loop so it does not have this fatal flaw. It is a much better design as well.

layout-tests/editing/deleting/delete-3800834-fix-expected.txt: Changes made this test have what I consider to be a better result. Going with it.

3:39 PM Changeset in webkit [8134] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3871718> REGRESSION (125-168): text marked bold with font that does not have bold variant copies as non-bold

Reviewed by hyatt.

kwq/DOM.mm: (-[DOMElement _font]): new SPI for AppKit
kwq/DOMPrivate.h:

2:59 PM Changeset in webkit [8133]

3 copies
3 deletes in tags/WebKit-173~1

This commit was manufactured by cvs2svn to create tag 'WebKit-173~1'.

2:59 PM Changeset in webkit [8132] by vicki

1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Bump version number to 173.1. We're doing a dot submission today for <rdar://problem/3903749>.

2:20 PM Changeset in webkit [8131] by cblu

11 edits in trunk/WebKit

Fixed: <rdar://problem/3907381> NSURLConnection and WebKit buffer 2 copies of incoming data

Reviewed by darin.

WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (+[WebBaseResourceHandleDelegate initialize]): cache check to see if Foundation supports access to its buffered data (-[WebBaseResourceHandleDelegate addData:]): don't buffer data if Foundation is buffering it for us (-[WebBaseResourceHandleDelegate saveResource]): when creating a WebResource, pass NO for copyData since we know it won't be mutated (-[WebBaseResourceHandleDelegate resourceData]): return the buffered data from the connection if it supports it (-[WebBaseResourceHandleDelegate willStopBufferingData:]): make a mutable copy of the data from NSURLConnection so we can continue buffering (-[WebBaseResourceHandleDelegate willCacheResponse:]): removed optimization that used the cached response data to save the resource since that is obsolete by this change (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): new callback from NSURLConnection, informs us that NSURLConnection has given up buffering
WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedData:]): removed buffering code since that's done by NSURLConnection and the main client (-[WebDataSource _setData:]): removed unnecessary cast since the resourceData ivar is now an NSData instead of NSMutableData (-[WebDataSource data]): return resourceData ivar, else return the resourceData from the main client
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient releaseResources]): store resourceData on the data source so it can continue to have data after the main client has gone away (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):don't call [dataSource data] just to get the length of data received since [dataSource data] can now cause data to be copied (-[WebMainResourceClient connectionDidFinishLoading:]): ditto
WebView.subproj/WebResource.m: (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call following method with YES for copyData (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:copyData:]): new initializer, allows caller to choose whether or not the data is copied
WebView.subproj/WebResourcePrivate.h:

1:49 PM Changeset in webkit [8130] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3906327> Select All of a large document is slow (>15 secs on my machine for attached specimen)

kwq/KWQScrollView.mm: (QScrollView::updateContents): Intersect with visibleRect before calling through to NSView to dirty; NSView could also be more efficient in this case (I filed 3906343).

1:09 PM Changeset in webkit [8129] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3903749> REGRESSION (8A321): WebKit gets incorrect glyph metrics due to change in how AppKit uses CGFont

Use CGFontRef direction when both getting font metrics and drawing
glyphs, instead on depending on [NSFont set].

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (_drawGlyphs):

11:48 AM Changeset in webkit [8128] by sullivan

2 edits in trunk/WebCore

Darin found what appears to be the real leak that we were falsely blaming
on the 'leaks' tool (3880245). I made the change, and ran layout tests and PLT to make
sure nothing barfed.

khtml/css/cssparser.cpp: (CSSParser::parseValue): call clearProperties() instead of just setting numParsedProperties to 0 (CSSParser::parseDeclaration): ditto (CSSParser::createStyleDeclaration): ditto

10:38 AM Changeset in webkit [8127] by kocienda

1 edit
18 adds in trunk

Reviewed by me

New layout tests.

layout-tests/editing/inserting/insert-div-001-expected.txt: Added.
layout-tests/editing/inserting/insert-div-001.html: Added.
layout-tests/editing/inserting/insert-div-002-expected.txt: Added.
layout-tests/editing/inserting/insert-div-002.html: Added.
layout-tests/editing/inserting/insert-div-003-expected.txt: Added.
layout-tests/editing/inserting/insert-div-003.html: Added.
layout-tests/editing/inserting/insert-div-004-expected.txt: Added.
layout-tests/editing/inserting/insert-div-004.html: Added.
layout-tests/editing/inserting/insert-div-005-expected.txt: Added.
layout-tests/editing/inserting/insert-div-005.html: Added.
layout-tests/editing/inserting/insert-div-006-expected.txt: Added.
layout-tests/editing/inserting/insert-div-006.html: Added.
layout-tests/editing/inserting/insert-div-007-expected.txt: Added.
layout-tests/editing/inserting/insert-div-007.html: Added.
layout-tests/editing/inserting/insert-div-008-expected.txt: Added.
layout-tests/editing/inserting/insert-div-008.html: Added.
layout-tests/editing/inserting/insert-div-009-expected.txt: Added.
layout-tests/editing/inserting/insert-div-009.html: Added.

10:21 AM Changeset in webkit [8126] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3906948> REGRESSION (Mail): Insert paragraph code can make the insertion point "stick" in place.

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Call insertBlockPlaceholderIfNeeded(), passing block being added to this function. This ensures that the added block has a height. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto.

10:21 AM Changeset in webkit [8125] by kocienda

2 edits in trunk/WebKit

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3906930> Hitting return key in editable content inserts br elements instead of blocks

WebView.subproj/WebHTMLView.m: (-[WebHTMLView insertNewline:]): One-line change to call insert-block rather than insert-br method on bridge.

9:39 AM Changeset in webkit [8124] by kocienda

6 edits in trunk

Reviewed by John

khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Expose method already on DOMStrimgImpl.
khtml/dom/dom_string.h: Ditto.
khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::rebalanceWhitespace): New helper to create and execute a RebalanceWhitespaceCommand instance. (khtml::DeleteSelectionCommand::doApply): Call rebalanceWhitespace() after running command. (khtml::InsertLineBreakCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto. (khtml::InsertTextCommand::input): Ditto. (khtml::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): New command. (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand): Ditto. (khtml::RebalanceWhitespaceCommand::doApply): Ditto. (khtml::RebalanceWhitespaceCommand::doUnapply): Ditto. (khtml::RebalanceWhitespaceCommand::preservesTypingStyle): Ditto. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
khtml/editing/htmlediting.h: Ditto. (khtml::RebalanceWhitespaceCommand::): Ditto.

Dec 5, 2004:

12:40 PM Changeset in webkit [8123] by darin

2 edits in trunk/WebCore

fixed small problem in my check-in from yesterday

kwq/KWQEvent.mm: (positionForEvent): Get location from event without raising exception if it's the wrong type. (clickCountForEvent): Same, for clickCount. (QMouseEvent::QMouseEvent): Use the new helper functions so this can be constructed even with the wrong type of NSEvent. Required for cases where a keyboard event causes a "click" and we need to synthesize a QMouseEvent for KHTML internal use, using the key down NSEvent.

Dec 4, 2004:

2:31 PM Changeset in webkit [8122] by darin

15 edits in trunk

WebCore:

Reviewed by John.

fixed <rdar://problem/3878329> REGRESSION (169-170): colors are wrong for my.yahoo.com due to CSS background parsing changes

khtml/css/cssparser.cpp: (CSSParser::parseBackgroundShorthand): Changed function so it doesn't rely on the position attribute being at the end of the array and then moved position attribute before color attribute so it takes precedence. Since "0" can be both the X coordinate of a position and a legal color (meaning black), we need to do position first.

fixed <rdar://problem/3760869> click events for input type=button or type=checkbox don't have flags like shiftKey set

khtml/rendering/render_form.h: Remove unused RenderFormElement fields.
khtml/rendering/render_form.cpp: (RenderFormElement::RenderFormElement): Take out code to set a bunch of unused fields. (RenderFormElement::slotClicked): Change to create the QMouseEvent from the actual mouse event rather than creating it with all the flags set to 0, using the new QMouseEvent constructor that does so.

kwq/KWQEvent.h: Added constructor that takes no parameters which uses the current event from AppKit. Made the click count getter const and added an isDoubleClick that matches the logic used elsewhere. Added a fixState helper method so the constructors can save code.
kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent): Factored out the state-fixing code that was in the two existing constructors and added a third constructor that uses the "current event" from AppKit (used above). (QMouseEvent::fixState): Compute state and click count based on event type.

fixed first symptom of <rdar://problem/3830936> REGRESSION (125-165): crash due to null font family, hang at changeforamerica.com

kwq/KWQFontFamily.mm: (KWQFontFamily::getNSFamily): Handle empty strings specially so we don't run into trouble when the family name is a null string. This prevents the crash, but there are still other problems that may have the same underlying cause in CSS.

fixed <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Added nil check before calling scheduleRelayout. This is new code so the nil-dereference is a recent regression.

WebKit:

Reviewed by John.

fixed <rdar://problem/3846079> assertion failure in WebHTMLView(WebPrivate) removeTrackingRect at boots.com
fixed <rdar://problem/3857737> REGRESSION (165-166): clicking in a text field that's scrolled to the right causes it to scroll all the way left
fixed <rdar://problem/3861952> REGRESSION (165-166): selection is cleared when you start to scroll a frame

WebView.subproj/WebHTMLViewInternal.h: Added handlingMouseDown flag.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Allow passing in a tracking number of 0, which means no existing tracking number. (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Ditto. (-[WebHTMLView removeTrackingRect:]): Allow removing a tracking number of 0, which is a no-op. (-[WebHTMLView _removeTrackingRects:count:]): Ditto. (-[WebHTMLView acceptsFirstResponder]): Changed check to use handlingMouseDown flag instead of mouseDownEvent field since that field is set up too early in the mouse down event handling process. (-[WebHTMLView mouseDown:]): Added code to set handlingMouseDown flag.

fixed part of <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Changed code around so that it won't try to create a WebResource when the load fails.

moved next/previous links into private structure with the rest of WebFrame fields (We have a rule against putting new fields into obejcts that are part of our public API.)

WebView.subproj/WebFrame.h: Remove _nextSibling and _previousSibling.
WebView.subproj/WebFramePrivate.h: Added nextSibling and previousSibling fields to private class.
WebView.subproj/WebFrame.m: Got rid of some tabs in this file. (-[WebFrame _addChild:]): Changed code to use fields inside _private. (-[WebFrame _removeChild:]): Ditto. (-[WebFrame _nextFrameWithWrap:]): Ditto. (-[WebFrame _previousFrameWithWrap:]): Ditto.

10:37 AM Changeset in webkit [8121] by cblu

22 edits in trunk

WebCore:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response): (khtml::CachedObject::allData):
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQCacheObjectExpiresTime): (khtml::CachedObject::setResponse): (khtml::CachedObject::setAllData):
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (QPixmap::QPixmap):
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finishWithData:]):
kwq/KWQSignal.h:
kwq/KWQSignal.mm: (KWQSignal::call):
kwq/KWQSlot.h:
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
kwq/WebCoreBridge.h:
kwq/WebCoreResourceLoader.h:

WebKit:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]): (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]):
WebView.subproj/WebFrameInternal.h:

10:30 AM Changeset in webkit [8120] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3876093> REGRESSION (166-167): Setting slider control's value from JavaScript has no effect (breaks RSS)

khtml/rendering/render_form.cpp: (RenderSlider::updateFromElement): Call setValue to update the value of the DOM element rather than modifying the m_value data member directly. We don't use m_value at all for sliders now, and in fact the code relies on the fact that m_value is null. Setting m_value to a non-null value was causing the bug. (RenderSlider::slotSliderValueChanged): Ditto.

7:31 AM Changeset in webkit [8119] by darin

3 edits in trunk/WebKit

Reviewed by Maciej.

fixed remaining bit of <rdar://problem/3814237> REGRESSION (Mail): Copy/paste style does not set color in Mail compose window

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): When translating from an attribute dictionary to a CSS declaration, treat missing values according to the defaults defined in <AppKit/NSAttributedString.h>. Before the code was treating them as "no change", which is incorrect.

English.lproj/StringsNotToBeLocalized.txt: Add a string from the above change.

Dec 3, 2004:

5:56 PM Changeset in webkit [8118] by sullivan

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3889411> REGRESSION (125-172): repro crash in khtml::BackgroundLayer::cullEmptyLayers

khtml/rendering/render_style.cpp: (BackgroundLayer::cullEmptyLayers): added missing nil check

5:54 PM Changeset in webkit [8117] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (v173+)
The tree is open!

5:42 PM Changeset in webkit [8116]

2 copies in tags/Safari-173

This commit was manufactured by cvs2svn to create tag 'Safari-173'.

5:42 PM Changeset in webkit [8115] by vicki

6 edits in trunk

Safari-173 stamp

2:53 PM Changeset in webkit [8114] by kocienda

26 edits in trunk

WebCore:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
khtml/misc/htmltags.c: (hash_tag): (findTag):
khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response):
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQResponseTextEncodingName): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime): (KWQLoader::KWQLoader):
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (QPixmap::QPixmap):
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finish]):
kwq/KWQSignal.h:
kwq/KWQSignal.mm: (KWQSignal::call):
kwq/KWQSlot.h:
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
kwq/WebCoreBridge.h:
kwq/WebCoreResourceLoader.h:

WebKit:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]):
WebView.subproj/WebFrameInternal.h:

2:01 PM Changeset in webkit [8113] by sullivan

2 edits in trunk/WebCore

Vicki gave me special dispensation to check this in though the tree is closed.

Reviewed by Chris.

fixed <rdar://problem/3903990> can't tab to all items on www.google.com any more (other pages too?)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): when checking whether we moved the focus to another view, make sure we didn't "move" it to our documentView, because that's no move at all.

1:01 PM Changeset in webkit [8112] by darin

4 edits in trunk/WebCore

Reviewed by Vicki.

fixed <rdar://problem/3901109> REGRESSION (171-172): repro crash in DOM::NodeImpl::setChanged at chick-fil-a.com

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl): Added missing initialization for base class and node pointer.

fixed a few places that could leave dangling node pointers

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl): Clear out the node pointer when the node is destroyed.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::~HTMLElementImpl): Ditto.

12:06 PM Changeset in webkit [8111] by cblu

11 edits in trunk/WebCore

Fix for performance regression. My original patch added a signal for passing the data of a resource to its WebCore cache object. This patch passes the data with the preexisting "finished" symbol so we make less calls.
Fixed: <rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account

Reviewed by rjw.

khtml/misc/loader.cpp: (Loader::servePendingRequests): pass data param to slotFinished, removed allData signal (Loader::slotFinished): take data param
khtml/misc/loader.h:
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): have m_result take a data param, removed m_allData (KIO::TransferJob::emitResult): take data param and pass it
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): take data param and pass it (-[KWQResourceLoader cancel]): pass nil for data (-[KWQResourceLoader reportError]): ditto (-[KWQResourceLoader finishWithData:]): pass data
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): pass data param to slotFinished (KWQSlot::call): added support for slotFinished_Loader, removed slotAllData

10:57 AM Changeset in webkit [8110] by kocienda

5 edits in trunk/WebCore

Reviewed by John

Did some clean up in the Position class as a result of trying to write some new layout
tests and discovering a bug along the way.

I removed these three functions from the Position class:

bool isFirstRenderedPositionOnLine() const;
bool isLastRenderedPositionOnLine() const;
static bool renderersOnDifferentLine(RenderObject *r1, long o1, RenderObject *r2, long o2);
bool inFirstEditableInRootEditableElement() const;

The first two have replacements in the VisiblePosition class, and some code has been
moved to use these new variants. The third function was a helper used only by these
first two function, and can be removed as well. The fourth function was not used by anyone.

khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Change over to use VisiblePosition isFirstVisiblePositionOnLine().
khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines): Added an additional check for blocks to this function. Incorrect results were being returned when asking about positions at the starts of blocks.
khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): Change over to use VisiblePosition isFirstVisiblePositionOnLine(). (DOM::Position::nextCharacterPosition): Change over to use VisiblePosition isLastVisiblePositionOnLine(). (DOM::Position::rendersInDifferentPosition): Removed use of #3 helper in a log message. We can live without it.
khtml/xml/dom_position.h: Update header for deletions.

9:31 AM Changeset in webkit [8109] by kocienda

19 edits in trunk

Reviewed by John

Terminology change in execCommand command identifiers. Specifically, the name of
"InsertNewline" command has been changed to "InsertLineBreak". This matches the
terminology used by AppKit. It is also more accurate, since the insertion of a
"br" element is what the command does. The inspiration for this change is so the
-insertNewline AppKit method can be mapped to insert a new "div" element in
a document and avoid ambiguity with what the javascript editing command does.

khtml/editing/jsediting.cpp
layout-tests/editing/deleting/delete-tab-004.html
layout-tests/editing/editing.js
layout-tests/editing/inserting/insert-3654864-fix.html
layout-tests/editing/inserting/insert-3659587-fix.html
layout-tests/editing/inserting/insert-3775316-fix.html
layout-tests/editing/inserting/insert-3800346-fix.html
layout-tests/editing/inserting/insert-br-001.html
layout-tests/editing/inserting/insert-br-002.html
layout-tests/editing/inserting/insert-br-003.html
layout-tests/editing/inserting/insert-br-004.html
layout-tests/editing/inserting/insert-br-005.html
layout-tests/editing/inserting/insert-br-006.html
layout-tests/editing/inserting/insert-br-007.html
layout-tests/editing/inserting/insert-br-008.html
layout-tests/editing/inserting/insert-tab-004.html
layout-tests/editing/inserting/insert-text-with-newlines.html
layout-tests/editing/pasteboard/paste-text-010.html

Dec 2, 2004:

4:33 PM Changeset in webkit [8108] by kocienda

2 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3786362> REGRESSION (Mail): pasted text loses one newline

khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Added check for strict mode before adding an extra br element at the end of a block. This is only necessary in quirks mode. Also, lower-case "br" used to make element. (khtml::ReplaceSelectionCommand::doApply): If the replacement adds a br element as the last element in a block and the document is in quirks mode, add an additional br to make the one in the replacement content show up. This turns out to be much the same logic as is done in InsertLineBreakCommand.
layout-tests/editing/inserting/insert-3786362-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3786362-fix.html: Added.

4:24 PM Changeset in webkit [8107] by rjw

5 edits in trunk

WebKit:

Fixed <rdar://problem/3841332> REGRESSION (125.9-167u): repro crash in -[KWQPageState invalidate] involving .Mac images

Ensure that the document is cleared when leaving a non-HTML page. This ensures that
the b/f cache won't incorrectly trash the previous state when restoring.

Reviewed by John.

WebView.subproj/WebFrame.m: (-[WebFrame _setState:]):

WebCore:

Fixed <rdar://problem/3841332> REGRESSION (125.9-167u): repro crash in -[KWQPageState invalidate] involving .Mac images

Ensure that the document is cleared when leaving a non-HTML page. This ensures that
the b/f cache won't incorrectly trash the previous state when restoring.

Reviewed by John.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge canCachePage]): (-[WebCoreBridge clear]):

3:08 PM Changeset in webkit [8106] by kocienda

2 edits in trunk/WebKit

Reviewed by Richard

<rdar://problem/3748323> Problem with -[WebView editableDOMRangeForPoint:] (-isFlipped not taken into account?)
<rdar://problem/3852590> REGRESSION (Mail): Dropped content appears in wrong place if Mail message is scrolled down

When implementing drag and drop, moveDragCaretToPoint: and editableDOMRangeForPoint: are used in
concert to track the mouse and determine a drop location, respectively. However, moveDragCaretToPoint:
did a conversion of the passed-in point to the document view's coordinate space, whereas
editableDOMRangeForPoint: did not. Now it does.

Note that I will need to coordinate with Grant to have him roll out some code in Mail that
attempts to work around this problem (unsuccessfully), and actually manages to block the
real fix (which needs to be in WebKit).

WebView.subproj/WebView.m: (-[WebView editableDOMRangeForPoint:]): Convert the passed-in point to the document view's coordinate space.

2:17 PM Changeset in webkit [8105] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3895810> FATAL ERROR: <WebTextRenderer: 0x9328a20> unable to initialize with font "Times-Roman 16.00 pt. S ....

We have a hack to replace Times with Times New Roman if we fail
to setup Times. If we then fail to setup Times New Roman we
don't attempt to further fallback to the system font. Added
that additional fallback.

Reviewed by Ken.

WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer webFallbackFontFamily]): (-[WebTextRenderer initWithFont:usingPrinterFont:]):

1:37 PM Changeset in webkit [8104] by rjw

2 edits in trunk/WebKit

Fixed build problem on Tiger8A821. Private macro and function
we were using have been deprecated,

Reviewed by Vicki.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

1:04 PM Changeset in webkit [8103] by kocienda

2 edits in trunk/WebCore

Reviewed by Richard

Fix for this bug:

<rdar://problem/3857775> 8A293: Mail.app crashes converting copy-pasted text into plain text

khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::commonAncestorContainer): Return the document element if no common ancestor container was found. This can happen in cases where the DOM was built from malformed markup (as in the case of this bug where there is content after the body tag). Did a little code clean up as well. (DOM::RangeImpl::compareBoundaryPoints): Made code more robust by adding some null checks.

11:05 AM Changeset in webkit [8102] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3668157> REGRESSION (Mail): shift-click deselects when selection was created right-to-left

khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick): Use RangeImpl::compareBoundaryPoints to figure out which end of the selection to extend.

10:22 AM Changeset in webkit [8101] by harrison

4 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3834917> REGRESSION (Mail): double-clicking blank line selects end of previous line
Fixed originally reported bug plus the case of double-clicking whitespace at the beginning of a line, which has a similar result.

khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (khtml::SimplifiedBackwardsTextIterator::handleTextNode): (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement): (khtml::SimplifiedBackwardsTextIterator::handleNonTextNode): (khtml::SimplifiedBackwardsTextIterator::emitCharacter): Distinguish BR from whitespace.
khtml/editing/visible_text.h: Distinguish BR from whitespace.
khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Use UPSTREAM visible position now that SimplifiedBackwardsTextIterator distinguishes BR from whitespace. Otherwise, double-clicking at end of line would result in caret selection at start of next line.

9:43 AM Changeset in webkit [8100] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3900996> Crash dragging past end of contentEditable DIV, at DOM::RangeImpl::pastEndNode() const + 24

khtml/xml/dom_position.cpp: (DOM::Position::equivalentRangeCompliantPosition): Fixed this function so that it constrains the offset of the position to be >= 0 and <= number of kids of its node. Not doing this constraining led to a DOM exception trying to use a Position returned from this function to set the boundary point of a Range (which eventually led to the crash). Since this crash happened, it seems like this function was failing in its contract to return a range-compliant position, hence the need for this fix.

Dec 1, 2004:

2:44 PM Changeset in webkit [8099] by cblu

6 edits in trunk/WebKit

Fixed: <rdar://problem/3879870> Flash Player unable to stop data stream from continuing to download by returning -1 from NPP_Write
Also improved and cleaned-up the plug-in stream termination code.

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (+[WebBaseNetscapePluginStream reasonForError:]): return NPRES_DONE for a nil error (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): new, factored out from other methods (-[WebBaseNetscapePluginStream errorForReason:]): new (-[WebBaseNetscapePluginStream dealloc]): release MIME type (-[WebBaseNetscapePluginStream setMIMEType:]): new (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): call setMIMEType so we can use it in _pluginCancelledConnectionError, call renamed methods (-[WebBaseNetscapePluginStream _destroyStream]): prepended underscore, replaced some early returns with asserts as the callers are now smarter (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): prepended underscore, only call _destroyStream if there is an error or if the load is complete and there is no more data to be streamed (-[WebBaseNetscapePluginStream cancelLoadWithError:]): new, overridden by subclasses to cancel the actual NSURLConnection (-[WebBaseNetscapePluginStream destroyStreamWithError:]): new, calls _destroyStreamWithReason (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call renamed methods (-[WebBaseNetscapePluginStream _deliverData]): prepended underscore, call cancelLoadAndDestroyStreamWithError if NPP_Write returns a negative number
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelLoadAndDestroyStreamWithError
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call destroyStreamWithError (-[WebNetscapePluginRepresentation cancelLoadWithError:]): new, override method, tell the data source to stop loading
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelLoadWithError:]): new, override method, tell the loader to stop (-[WebNetscapePluginStream stop]): call cancelLoadAndDestroyStreamWithError (-[WebNetscapePluginConnectionDelegate isDone]): new (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]): call cancelLoadAndDestroyStreamWithError (-[WebNetscapePluginConnectionDelegate didFailWithError:]): call destroyStreamWithError

2:11 PM Changeset in webkit [8098] by hyatt

1 edit in trunk/WebCore/kwq/KWQScrollView.mm

Fix deployment build bustage

1:59 PM Changeset in webkit [8097] by kocienda

3 edits in trunk/WebCore

Reviewed by me

Moving code only.

khtml/editing/htmlediting.cpp: Move ReplaceSelectionCommand into alphabetical order with regard to other editing commands. The class had a name change ages ago, and it was never moved.
khtml/editing/htmlediting.h: Ditto.

1:52 PM Changeset in webkit [8096] by kocienda

8 edits
3 adds in trunk

Reviewed by Hyatt

Some improvements for paste, including some new code to annotate
whitespace when writing to the pasteboard to ensure that the meaning
of the markup on the pasteboard is unambiguous.

There is also new code for reading this annotated markup from the pasteboard,
removing the nodes that were added only to prevent ambiguity.

WebCore.pbproj/project.pbxproj: Added html_interchange.h and html_interchange.cpp files. The header should have been added earlier, but I did not do so.
khtml/editing/html_interchange.cpp: Added. (convertHTMLTextToInterchangeFormat):
khtml/editing/html_interchange.h: Added some new constants for use with whitespace annotations.
khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::ReplacementFragment): Now looks for and removes annotations added for whitespace. Also fixed a bug in the code that counts blocks in a fragment. (khtml::ReplacementFragment::isInterchangeConvertedSpaceSpan): New helper. Recognizes annotation spans. (khtml::ReplacementFragment::insertNodeBefore): New helper. (khtml::ReplaceSelectionCommand::doApply): Fixed a bug in the code that sets the start position for the replacement after deleting. This was causing a bug when pasting at the end of a block.
khtml/editing/htmlediting.h: Add some new declarations.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Calls to startMarkup now pass true for the new annotate flag.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::stringValueForRange): New helper. (NodeImpl::renderedText): New helper to return only the rendered text in a node. (NodeImpl::startMarkup): Now takes an additional flag to control whether interchange annotations should be added. Called by the paste code.
khtml/xml/dom_nodeimpl.h: Added and modified function declarations.

New test to check the khtml::ReplaceSelectionCommand::doApply fix.

layout-tests/editing/pasteboard/paste-text-010-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-010.html: Added.

11:56 AM Changeset in webkit [8095] by kdecker

3 edits in trunk/WebKit

Reviewed by Harrison.

Fixed: <rdar://problem/3228878> potential performance problem in finding in large framesets

Got rid of O(N^{2) conditions in _nextSibling and _previousSibling of where we were looking up self in the parent array of frames.}

WebView.subproj/WebFrame.h: Added two new pointers, one for the previous kid and one for the next kid
WebView.subproj/WebFrame.m: (-[WebFrame _addChild:]): Updates the previous frame and the next frame after this child (-[WebFrame _removeChild:]): ditto (-[WebFrame _nextSibling]): just return the pointer now (-[WebFrame _previousSibling]): ditto

Nov 30, 2004:

5:25 PM Changeset in webkit [8094] by cblu

1 edit in trunk/WebCore/ChangeLog-2005-08-23

ChangeLog: removed conflict marker

5:23 PM Changeset in webkit [8093] by cblu

22 edits in trunk

WebCore:

Fixed:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)

Reviewed by darin.

khtml/misc/loader.cpp: (CachedObject::~CachedObject): release m_allData (CachedObject::setAllData): new (Loader::servePendingRequests): connect slotAllData (Loader::slotAllData): new (Cache::requestImage): tweak
khtml/misc/loader.h: (khtml::CachedObject::CachedObject): set allData to 0 (khtml::CachedObject::allData): new
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): set m_allData (KIO::TransferJob::emitAllData): new
kwq/KWQLoader.mm: (KWQCheckCacheObjectStatus): pass WebKit the data instead of the length of the resource
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishWithData:]): renamed to pass all data for the resource
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): support for slotAllData (KWQSlot::call):
kwq/WebCoreBridge.h:
kwq/WebCoreResourceLoader.h:

WebKit:

Fixed:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)

Reviewed by darin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): renamed to pass all data for the resource, moved delegate code to new method (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call renamed method
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]): call renamed method
WebView.subproj/WebFrame.m: (-[WebFrame _opened]): call _sendResourceLoadDelegateMessagesForURL:response:length:, not objectLoadedFromCacheWithURL:response:data: (-[WebFrame _internalLoadDelegate]): (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]): moved from objectLoadedFromCacheWithURL:response:data:
WebView.subproj/WebFrameInternal.h:

4:54 PM Changeset in webkit [8092] by mjs

3 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3805311> REGRESSION (159-163): onload in dynamically written document not called (causes blank search page at Japanese EPP site, many others)

khtml/khtml_part.cpp: (KHTMLPart::begin): call setParsing on document here after opening
from now on we'll only set parsing to true for a document open caused by page loading, not a programmatic one.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::open): don't setParsing to true here any more.

3:12 PM Changeset in webkit [8091] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fix recent regression from collection perf fixes.

khtml/html/html_miscimpl.cpp: (HTMLFormCollectionImpl::updateNameCache): Look up the name attribute in the name cache, not the id cache (d'oh!)

1:08 PM Changeset in webkit [8090] by darin

21 edits in trunk/WebCore

Reviewed by Ken.

rolled in a KDE fix for a problem that may underlie a number of crashes

khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::compareBoundaryPoints): Rolled in a change from the KDE guys to fix a subtle problem. Code said "n = n =".

rolled in a KDE fix for a containingBlock crash

khtml/rendering/render_object.cpp: Roll in a change from KDE that adds frameset to the list of elements that can not be a containingBlock. They said this fixes a crash, although I did not look into that further.

fixed <rdar://problem/3884660> 8A305: Repro crash in QScrollBar::setValue (affects Safari RSS)

kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Set up target and action here instead of in caller. (-[KWQButton detachQButton]): Added. (-[KWQButton sendConsumedMouseUpIfNeeded]): Check button for nil instead of checking target. (-[KWQButton mouseDown:]): Add calls to QWidget::beforeMouseDown/afterMouseDown. (-[KWQButton widget]): Added. (-[KWQButton becomeFirstResponder]): Added check to handle when button is 0. (-[KWQButton resignFirstResponder]): Ditto. (-[KWQButton canBecomeKeyView]): Ditto. (QButton::QButton): Remove target and action setup; handled in KWQButton now. (QButton::~QButton): Call detachQButton instead of setTarget:nil.

kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Call detachQComboBox. (-[KWQPopUpButtonCell detachQComboBox]): Added. (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Handle case where box is 0. (-[KWQPopUpButtonCell setHighlighted:]): Ditto. (-[KWQPopUpButton action:]): Ditto. (-[KWQPopUpButton widget]): Tweaked. (-[KWQPopUpButton mouseDown:]): Added. Calls QWidget::beforeMouseDown/afterMouseDown. (-[KWQPopUpButton becomeFirstResponder]): Handle case where widget is 0. (-[KWQPopUpButton resignFirstResponder]): Ditto. (-[KWQPopUpButton canBecomeKeyView]): Ditto.

kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit): Updated to use new detachQLineEdit name.

kwq/KWQListBox.mm: (-[KWQTableView mouseDown:]): Added. Calls QWidget::beforeMouseDown/afterMouseDown.

kwq/KWQScrollBar.h: Removed m_scroller field.
kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): Rearranged a little bit. (-[KWQScrollBar detachQScrollBar]): Added. (-[KWQScrollBar widget]): Added. (-[KWQScrollBar mouseDown:]): Added. Calls QWidget::beforeMouseDown and afterMouseDown. (QScrollBar::QScrollBar): Changed to no longer set m_scroller. (QScrollBar::~QScrollBar): Changed to call detachQScrollBar. No longer calls removeFromSuperview. (QScrollBar::setValue): Chagned to use getView instad of m_scrollBar. (QScrollBar::setKnobProportion): Ditto. (QScrollBar::scrollbarHit): Ditto.

kwq/KWQScrollView.mm: (QScrollView::addChild): Changed to call QWidget to add to superview to accomodate the hack where we don't remove right away when doing mouse tracking. (QScrollView::removeChild): Changed to call QWidget to remove from superview to accomodate the hack where we don't add right away when doing mouse tracking.

kwq/KWQSlider.h: Added destructor.
kwq/KWQSlider.mm: (-[KWQSlider initWithQSlider:]): Tweaked a little. (-[KWQSlider detachQSlider]): Added. (-[KWQSlider mouseDown:]): Added call to QWidget::beforeMouseDown/afterMouseDown. (-[KWQSlider widget]): Added. (QSlider::~QSlider): Added. Calls detachQSlider.

kwq/KWQTextArea.h: Added detachQTextEdit method.
kwq/KWQTextArea.mm: (-[KWQTextArea detachQTextEdit]): Added. (-[KWQTextArea textDidChange:]): Added check for widget of 0. (-[KWQTextArea becomeFirstResponder]): Ditto. (-[KWQTextArea nextKeyView]): Ditto. (-[KWQTextArea previousKeyView]): Ditto. (-[KWQTextArea drawRect:]): Ditto. (-[KWQTextAreaTextView insertTab:]): Ditto. (-[KWQTextAreaTextView insertBacktab:]): Ditto. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Ditto. (-[KWQTextAreaTextView selectedTextAttributes]): Ditto. (-[KWQTextAreaTextView mouseDown:]): Ditto. (-[KWQTextAreaTextView keyDown:]): Ditto. (-[KWQTextAreaTextView keyUp:]): Ditto.

kwq/KWQTextEdit.h: Added ~QTextEdit.
kwq/KWQTextEdit.mm: (QTextEdit::~QTextEdit): Added. Calls detachQTextEdit.

kwq/KWQTextField.h: Changed invalidate to detachQLineEdit.
kwq/KWQTextField.mm: (-[KWQTextFieldController detachQLineEdit]): Changed.

kwq/KWQWidget.h: Added addToSuperview/removeFromSuperview for use from QScrollView. Added beforeMouseDown and afterMouseDown for use in widget implementations. Removed unused hasMouseTracking function.
kwq/KWQWidget.mm: (QWidget::QWidget): Initialize two new fields. (QWidget::~QWidget): Added code to remove view when widget is destroyed. (QWidget::getOuterView): Remove unneeded exception blocking since we're just caling superview. (QWidget::addToSuperview): Added. (QWidget::removeFromSuperview): Added. (QWidget::beforeMouseDown): Added. (QWidget::afterMouseDown): Added.

khtml/rendering/render_layer.cpp: (RenderLayer::setHasHorizontalScrollbar): Remove parent parameter; let addChild call addSubview:. (RenderLayer::setHasVerticalScrollbar): Ditto.

8:33 AM Changeset in webkit [8089] by kocienda

5 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3863031> REGRESSION (Mail): caret continues flashing while mouse is down

khtml/khtml_part.cpp: (KHTMLPart::timerEvent): Add a check for whether the mouse is down. Keep the caret drawn with no blink if it is.

7:30 AM Changeset in webkit [8088] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::mergeEndNode): Fixed one-line coding mistake that created an endless loop. Seemed simple enough to land without review.

Nov 29, 2004:

4:07 PM Changeset in webkit [8087] by kocienda

6 edits
20 adds in trunk

Reviewed by Chris

Rewrite of paste code (specifically the ReplaceSelectionCommand class). Many more cases
are handled correctly now, including selections that span multiple blocks, and cases
where content on the pasteboard ends in newlines (or what appear to be newlines to a
user, really block ends or BRs). I also made one small, but important change in the
copy code to annotate the markup written to the pasteboard to support these selections
ending in newlines.

New header that defines a couple of constants used in copying and pasting.

ForwardingHeaders/editing/html_interchange.h: Added.
khtml/editing/html_interchange.h: Added.

Rewrite of the ReplaceSelectionCommand. There are several new helper functions, as well
as a new helper class, ReplacementFragment, which encapsulates information and functions
pertaining to a document fragment that is being inserted into a document.

khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::ReplacementFragment): (khtml::ReplacementFragment::~ReplacementFragment): (khtml::ReplacementFragment::firstChild): Simple accessor. (khtml::ReplacementFragment::lastChild): Ditto. (khtml::ReplacementFragment::mergeStartNode): Looks at the nodes in a fragment and determines the starting node to use for merging into the block containing the start of the selection. (khtml::ReplacementFragment::mergeEndNode): Same as above, but for the end of the selection. (khtml::ReplacementFragment::pruneEmptyNodes): Simple helper. (khtml::ReplacementFragment::isInterchangeNewlineComment): Determines if a node is the special annotation comment added in by the copy code. (khtml::ReplacementFragment::removeNode): Simple helper. (khtml::isComment): Simple helper. (khtml::isProbablyBlock): Determines if a node is of a type that is usually rendered as a block. I would like to do better than this some day, but this check will hold us until I can do better. (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Figures out the right ending selection.
khtml/editing/htmlediting.h: Declarations for the new ReplacementFragment class. (khtml::ReplacementFragment::root): (khtml::ReplacementFragment::type): (khtml::ReplacementFragment::isEmpty): (khtml::ReplacementFragment::isSingleTextNode): (khtml::ReplacementFragment::isTreeFragment): (khtml::ReplacementFragment::hasMoreThanOneBlock): (khtml::ReplacementFragment::hasLogicalNewlineAtEnd):

This smaller set of changes markup generation to add the newline annotation described in the
comment at the start of this entry.

khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::addCommentToHTMLMarkup): Simple helper. (DOM::RangeImpl::toHTML): Added new EAnnotateForInterchange default argument to control whether comment annotations are added to the markup generated.
khtml/xml/dom2_rangeimpl.h: Add some new declarations.
kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromRange:nodes:]): Request that markup resulting from call to DOM::RangeImpl::toHTML uses annotations when generating.

New tests.

layout-tests/editing/pasteboard/paste-text-001-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-001.html: Added.
layout-tests/editing/pasteboard/paste-text-002-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-002.html: Added.
layout-tests/editing/pasteboard/paste-text-003-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-003.html: Added.
layout-tests/editing/pasteboard/paste-text-004-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-004.html: Added.
layout-tests/editing/pasteboard/paste-text-005-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-005.html: Added.
layout-tests/editing/pasteboard/paste-text-006-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-006.html: Added.
layout-tests/editing/pasteboard/paste-text-007-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-007.html: Added.
layout-tests/editing/pasteboard/paste-text-008-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-008.html: Added.
layout-tests/editing/pasteboard/paste-text-009-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-009.html: Added.

3:13 PM Changeset in webkit [8086] by darin

4 edits in trunk/WebKit

Reviewed by John.

worked around bug in Panther where NSScroller calls _destinationFloatValueForScroller: on superview without first checking if it's implemented

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _destinationFloatValueForScroller:]): Implemented. Calls floatValue on the scroller.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

2:17 PM Changeset in webkit [8085] by kocienda

3 edits in trunk/WebCore

Reviewed by Harrison

Made two small changes that make it possible for comments to have DOM nodes made for them
when pasting. This relies on some earlier work I did some days ago.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::startMarkup): Get the string from the comment.
kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): Did some very minor rearranging. Now passes a flag when creating a contextual fragment, requesting that comments be included in the DOM.

2:17 PM Changeset in webkit [8084] by kocienda

3 edits in trunk/WebCore

Reviewed by Harrison

Added some new helpers to the VisiblePosition class. I will begin to use these when I check in
my improved paste code.

khtml/editing/visible_position.cpp: (khtml::blockRelationship) (khtml::visiblePositionsInDifferentBlocks) (khtml::isFirstVisiblePositionInBlock) (khtml::isFirstVisiblePositionInNode) (khtml::isLastVisiblePositionInBlock)
khtml/editing/visible_position.h

2:13 PM Changeset in webkit [8083] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

khtml/xml/dom_position.cpp: (DOM::Position::downstream): Fix a bug in downstream that prevented a call with DoNotStayInBlock specified from obeying that directive. The old code would stop at an outer block boundary in the case where that block had a block as its first child. The correct behavior is to drill into that inner block (and continue on drilling down, if possible), to find the correct position.

2:11 PM Changeset in webkit [8082] by kocienda

3 edits in trunk/WebCore

Reviewed by Harrison

Small improvements to the node-display debugging helpers.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayTree): Make the rootNode be this if there is no rootEditableElement.
khtml/xml/dom_nodeimpl.h: Make displayNode take a default argument of "" for its string.

2:05 PM Changeset in webkit [8081] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): The downstream position in this function may need to be adjusted when deleting text off the front part of a text node. This fixes a problem I discovered while improving the paste command, where the insertion poitn wound up in the wrong place after the delete.

2:03 PM Changeset in webkit [8080] by kocienda

3 edits in trunk/WebCore

Reviewed by Harrison

Add a new helper function to insert a paragraph separator. Will be used in my
upcoming paste improvments.

khtml/editing/htmlediting.cpp: Added function (khtml::CompositeEditCommand::insertParagraphSeparator)
khtml/editing/htmlediting.h: Ditto.

Nov 23, 2004:

5:06 PM Changeset in webkit [8079] by rjw

2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3890385> field and method cache incorrectly capped (c bindings)

Reviewed by Ken.

bindings/c/c_class.cpp: (CClass::_commonInit):

4:07 PM Changeset in webkit [8078] by harrison

2 edits in trunk/WebCore

Added various comments.

khtml/editing/htmlediting.cpp: (khtml::StyleChange::init): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyBlockStyle): (khtml::ApplyStyleCommand::applyInlineStyle):

10:50 AM Changeset in webkit [8077] by cblu

6 edits in trunk/WebKit

Fixed: <rdar://problem/3890944> disable icon database for Dashboard

Reviewed by kevin.

Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): don't create dictionaries if disabled (-[WebIconDatabase iconForURL:withSize:cache:]): return default icon if disabled (-[WebIconDatabase iconURLForURL:]): return nil if disabled (-[WebIconDatabase retainIconForURL:]): return if disabled (-[WebIconDatabase releaseIconForURL:]): ditto (-[WebIconDatabase delayDatabaseCleanup]): ditto (-[WebIconDatabase allowDatabaseCleanup]): ditto (-[WebIconDatabase _isEnabled]): new (-[WebIconDatabase _setIcon:forIconURL:]): assert if called when disabled, moved to own category implementation (-[WebIconDatabase _setHaveNoIconForIconURL:]): ditto (-[WebIconDatabase _setIconURL:forURL:]): ditto (-[WebIconDatabase _createFileDatabase]): tweak (-[WebIconDatabase _applicationWillTerminate:]): moved out of public code
Misc.subproj/WebIconDatabasePrivate.h:
Misc.subproj/WebIconLoader.m:
WebView.subproj/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): assert if called when icon DB is disabled (-[WebDataSource _loadIcon]): don't load icon if icon DB is disabled

12:22 AM Changeset in webkit [8076] by hyatt

2 edits in trunk/WebCore

Hit testing in table cells with top/bottom space from vertical alignment didn't work. I forgot about the
super-secret yPos() lie that table cells do. Use m_y instead of yPos().

khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):

Nov 22, 2004:

11:58 PM Changeset in webkit [8075] by hyatt

2 edits in trunk/WebCore

Make sure you can use document.createElement to make a <canvas> element.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):

11:45 PM Changeset in webkit [8074] by mjs

6 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3492044> performing JavaScript operations on form elements is slower than WinIE (HTMLFormCollection)
<rdar://problem/3489679> selecting an item on the Apache bugzilla query page is very slow (HTMLFormCollection)
<rdar://problem/3477810> checking 80 check boxes with JavaScript is 10x slower than in IE (HTMLFormCollection)
<rdar://problem/3760962> JavaScript that toggles checkboxes is slow (HTMLCollection,HTMLFormCollection)

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet):
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLFormElementImpl::~HTMLFormElementImpl):
khtml/html/html_formimpl.h:
khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::HTMLCollectionImpl): (HTMLCollectionImpl::~HTMLCollectionImpl): (HTMLCollectionImpl::CollectionInfo::CollectionInfo): (HTMLCollectionImpl::CollectionInfo::reset): (HTMLCollectionImpl::resetCollectionInfo): (HTMLCollectionImpl::checkForNameMatch): (appendToVector): (HTMLCollectionImpl::updateNameCache): (HTMLCollectionImpl::namedItems): (HTMLFormCollectionImpl::HTMLFormCollectionImpl): (HTMLFormCollectionImpl::~HTMLFormCollectionImpl): (HTMLFormCollectionImpl::item): (HTMLFormCollectionImpl::updateNameCache):
khtml/html/html_miscimpl.h:

11:23 PM Changeset in webkit [8073] by hyatt

2 edits in trunk/WebKit

Make sure the WebCore cache grows at 512mb and at 1024mb exactly.

Reviewed by mjs

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]):

11:21 PM Changeset in webkit [8072] by hyatt

3 edits in trunk/WebCore

Improve the WebCore cache so that the maximum cacheable object size is scaled based off the total cache
size.

Reviewed by mjs

khtml/misc/loader.cpp: (CachedObject::finish): (Cache::flush): (Cache::setSize):
khtml/misc/loader.h: (khtml::Cache::maxCacheableObjectSize):

9:50 PM Changeset in webkit [8071] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_frames.cpp

Fix mistake made with frameset hit testing from previous checkin.

9:08 PM Changeset in webkit [8070] by hyatt

30 edits in trunk/WebCore

Fix for 3673381, huge directory listing so slow it seems like a hang. Rework painting and hit testing so that
it crawls the line box tree instead of the render tree. This allows more precise intersection/containment testing
that lets us short circuit earlier when painting and hit testing.

Reviewed by mjs

khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::paintChildren): (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::nodeAtPoint):
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint):
khtml/rendering/render_box.h:
khtml/rendering/render_br.h:
khtml/rendering/render_canvas.cpp: (RenderCanvas::paint):
khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): (RenderFlow::hitTestLines): (RenderFlow::caretRect): (RenderFlow::addFocusRingRects): (RenderFlow::paintFocusRing): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
khtml/rendering/render_flow.h:
khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
khtml/rendering/render_frames.h:
khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
khtml/rendering/render_image.h:
khtml/rendering/render_inline.cpp: (RenderInline::paint): (RenderInline::nodeAtPoint):
khtml/rendering/render_inline.h:
khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer): (RenderLayer::hitTest): (RenderLayer::hitTestLayer):
khtml/rendering/render_layer.h:
khtml/rendering/render_line.cpp: (khtml::InlineBox::paint): (khtml::InlineBox::nodeAtPoint): (khtml::InlineFlowBox::flowObject): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paint): (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::InlineFlowBox::paintDecorations): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::paint): (khtml::RootInlineBox::nodeAtPoint):
khtml/rendering/render_line.h: (khtml::InlineRunBox::paintBackgroundAndBorder):
khtml/rendering/render_object.cpp: (RenderObject::hitTest): (RenderObject::setInnerNode): (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h: (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::PaintInfo::~PaintInfo): (khtml::RenderObject::paintingRootForChildren): (khtml::RenderObject::shouldPaintWithinRoot):
khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint):
khtml/rendering/render_text.cpp: (simpleDifferenceBetweenColors): (correctedTextColor): (InlineTextBox::nodeAtPoint): (InlineTextBox::paint): (InlineTextBox::selectionStartEnd): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::paintDecoration): (RenderText::posOfChar):
khtml/rendering/render_text.h: (khtml::RenderText::paint): (khtml::RenderText::layout): (khtml::RenderText::nodeAtPoint):
khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::computeLayerPos):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityHitTest:]):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::eventMayStartDrag): (KWQKHTMLPart::khtmlMouseMoveEvent):
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge _positionForPoint:]):

8:48 PM Changeset in webkit [8069] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3891737> WebPreferences do not work if they are set before set on the WebView

John found this problem and suggested the fix.

Reviewed by John Louch.

WebView.subproj/WebView.m: (-[WebView setPreferences:]):

7:02 PM Changeset in webkit [8068] by hyatt

1 edit in trunk/WebCore/khtml/html/html_formimpl.cpp

Remove bogus printf.

6:06 PM Changeset in webkit [8067] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by Ken.

<rdar://problem/3889696> Enable conservative garbage collection for JavaScript

kjs/collector.cpp: (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::initializeRegisteredThreadKey): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively):
kjs/collector.h:
kjs/internal.cpp: (lockInterpreter):
kjs/value.h:

5:44 PM Changeset in webkit [8066] by mjs

7 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3890961> selecting an item on the Apache bugzilla query page can be sped up 10% (HTMLFormCollection)
<rdar://problem/3890958> JavaScript that toggles checkboxes can be improved 73% (HTMLCollection,HTMLFormCollection)

This avoids the O(N^{2) penalty for named item traversal for form collections.}

It also combines the item traversal logic for all non-form
collection operations into a single traverseNextItem
function. This avoids having 5 copies of the big switch statement
for this.

Also fixed a bug that prevented the last form element from being removed properly.

khtml/html/html_formimpl.cpp: (DOM::removeFromVector):
khtml/dom/html_misc.cpp: (HTMLCollection::namedItems):
khtml/dom/html_misc.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::length): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::checkForNameMatch): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::namedItems): (HTMLCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::calcLength): (HTMLFormCollectionImpl::namedItem): (HTMLFormCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::namedItems):
khtml/html/html_miscimpl.h:

3:07 PM Changeset in webkit [8065]

71 copies
2 deletes in tags/WebCore-125~8~12

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~12'.

3:07 PM Changeset in webkit [8064] by adele

1 edit in branches/Safari-1-2-branch/WebCore/WebCore.pbproj/project.pbxproj

* empty log message *

3:07 PM Changeset in webkit [8063] by adele

1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Fixed by Maciej, merged by Darin for SUPanPlum <rdar://problem/3872586>.

2004-11-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

9:16 AM Changeset in webkit [8062] by kocienda

11 edits in trunk

WebCore:

Reviewed by Harrison

Change around the way we block the Javascript "Paste" command identifier from
being available. Formerly, this was done with an ifdef we never compiled in.
Now, this is done with a couple of cheap runtime checks. The advantage is that
we can now compile this command into development builds, and still yet switch
on the command in deployment builds through the use of WebCore SPI so we can
write and run layout tests with all of our builds.

khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported): Checks state of paste command in case command being queried is the paste command. (DOM::JSEditor::setSupportsPasteCommand): New SPI to turn on paste command.
khtml/editing/jsediting.h: Ditto.
khtml/khtml_part.cpp: (KHTMLPart::pasteFromPasteboard): Added. (KHTMLPart::canPaste): Added.
kwq/KWQKHTMLPart.mm: (KHTMLPart::canPaste): Added.
kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Turn on paste command.
kwq/WebCoreBridge.h: Add canPaste call so WebKit can fill in the answer.

WebKit:

Reviewed by Harrison

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canPaste]): Call WebView _canPaste.
WebView.subproj/WebView.m: (-[WebView _canPaste]): Try to forward to document view's implementation. Only WebHTMLView answers right now. Returns NO otherwise.
WebView.subproj/WebViewInternal.h: Add _canPaste method to WebView.

2:24 AM Changeset in webkit [8061] by mjs

2 edits in trunk/WebKit

Back out the window closing fix, it seems to be causing crashes.

WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed