⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 21, 2005:

4:48 PM Changeset in webkit [8433] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3759399> Javascript / Liveconnect problems ((event handler):Undefined value)

Java applets specified with <object> or <embed> weren't scriptable. Now they are.

Reviewed by Chris.

  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::getEmbedInstance): (HTMLObjectElementImpl::getObjectInstance):
4:16 PM Changeset in webkit [8432] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3959464> REGRESSION (Mail): Insertion point goes back to beginning of document after deleting

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Add special case to handle retaining a fully-selected block. This fixes the bug.
  • layout-tests/editing/deleting/delete-3959464-fix-expected.txt: Added.
  • layout-tests/editing/deleting/delete-3959464-fix.html: Added.
3:01 PM Changeset in webkit [8431]
  • 4 copies in tags/Safari-180

This commit was manufactured by cvs2svn to create tag 'Safari-180'.

3:01 PM Changeset in webkit [8430] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3966998> REGRESSION(179-TOT) clicking on gmail message brings me to blank screen

getElementById() sometimes returns Undefined() instead of Null().

Reviewed by Hyatt.

  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
2:45 PM Changeset in webkit [8429] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3773809, make sure that overflow regions never end up at an invalid scroll offset because of a layout change.

Reviewed by kocienda

  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
2:43 PM Changeset in webkit [8428] by darin
  • 3 edits in trunk/WebKit

Reviewed by Kristin Forster.

  • fixed <rdar://problem/3964972> update _initWithCGSEvent:eventRef: call in mouse moved workaround (breaks cursors in Carbon WebKit applications)
  • Carbon.subproj/HIWebView.m: (MouseMoved): Instead of munging the event record's window number directly before calling _initWithCGSEvent, on Tiger we call _eventRelativeToWindow on the event after creating it. Also added a check so that with Macromedia Contribute's workaround in place we don't do anything at all to the event. Tested with both Contribute and CarbonWeb.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
1:45 PM Changeset in webkit [8427] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3966349, hang loading page. Make sure that loops using popOneBlock properly check for a null
blockStack to avoid an infinite loop.

Reviewed by kocienda

  • khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): (KHTMLParser::insertNode): (KHTMLParser::popInlineBlocks):
10:55 AM Changeset in webkit [8426] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3957204> Mail crashed when sending a message in ~InsertParagraphSeparatorInQuotedContentCommand

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::InsertParagraphSeparatorInQuotedContentCommand): InsertParagraphSeparatorInQuotedContentCommand has this member variable: DOM::ElementImpl *m_breakNode; I failed to initialize this variable to null in the constructor, and there is an uncommonly-traveled code path which does not set this variable to something good. In the destructor, we check for null, and deref if non-null. Obvious "BOOM" potential. Fixed.
9:29 AM Changeset in webkit [8425] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3966311> REGRESSION (Mail): Hitting return makes space character disappear

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): When writing the code to insert a block in response to the return key, I did not write code to cover the case described in the bug. Now I have.
  • layout-tests/editing/inserting/insert-div-025-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-025.html: Added.

Jan 20, 2005:

6:25 PM Changeset in webkit [8424] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3815672> REGRESSION (Mail): Japanese text cannot be made bold

The AppKit's font substitution API doesn't match font traits!
It only find fonts that contain the appropriate glyphs. This
patch attempts to find the best variation within a family.

Also, made unrelated change to return printer/screen version of
substituted font.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _substituteFontForString:families:]):
5:50 PM Changeset in webkit [8423] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3965196> security fix for javascript: exploit missed one case (already fixed in updates)

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): correct mistake in earlier fix for the following bug, caught by Adele:

<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration

5:36 PM Changeset in webkit [8422] by mjs
  • 4 edits in trunk

Reviewed by Ken.

<rdar://problem/3965466> editing needs to insert text before applying typing style

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Remove a FIXME comment. (khtml::InsertLineBreakCommand::doApply): Apply style to the BR node after inserting it. (khtml::InsertTextCommand::prepareForTextInsertion): Don't try to apply style to any new nodes created before inserting. (khtml::InsertTextCommand::input): Apply style to the inserted range after doing the text insert.
  • khtml/editing/htmlediting.h:

This change leads to improved results on one of the layout tests:

  • layout-tests/editing/inserting/insert-div-024-expected.txt:
5:22 PM Changeset in webkit [8421] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by me, changes by Han Ming Ong.

  • <rdar://problem/3964302> SWB: A few files need to be updated to be compilable under GCC 4.0
  • bindings/objc/WebScriptObjectPrivate.h: Make members public.
  • kjs/lookup.h: Change "value.h" to "object.h" because we need KJS::Object to compile a template.
4:58 PM Changeset in webkit [8420] by vicki
  • 1 edit in trunk/WebKit/ChangeLog

move the Safari-180 release-marker in the ChangeLog, since the fix for 3786659 will be included in Safari-180

4:50 PM Changeset in webkit [8419] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with "size up" and "size down" NSFontManager changes

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addToStyle:fontA:fontB:]): This is the WebKit side of the fix. Replaced unimplemented code blocks with FIXME's in them for make bigger and make smaller with real working code.
4:41 PM Changeset in webkit [8418] by rjw
  • 4 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3964634> undefined property value from binding seems to evaluate to true in an if statement

The comprehensive fix for this problem requires new API, as described in 3965326. However,
given that we can't add new API at this point, the 'ObjcFallbackObjectImp' will behave
like and Undefined object if invokeUndefinedMethodFromWebScript:withArguments: isn't
implemented on the bound object.

Reviewed by Chris.

  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::implementsCall): (ObjcFallbackObjectImp::toBoolean):
  • bindings/testbindings.mm: (+[MyFirstInterface isSelectorExcludedFromWebScript:]): (+[MyFirstInterface isKeyExcludedFromWebScript:]):
4:01 PM Changeset in webkit [8417] by kocienda
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Finished my thought in the changelog. I left a comment half-written earlier.

3:47 PM Changeset in webkit [8416] by vicki
  • 3 edits in trunk

Versioning for TOT, Safari 2.0 (180+).

The tree is open!

3:33 PM Changeset in webkit [8415] by vicki
  • 6 edits in trunk

Safari-180 stamp

2:02 PM Changeset in webkit [8414] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3964646> REGRESSION (179-180): Typing space at end of line makes following paragraph disappear

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Recent change to block placeholder removal code caused this regression. The code became too aggressive in removing block placeholders, and would remove them from blocks other than the block containing the selection.
  • layout-tests/editing/inserting/insert-div-023-expected.txt: This file had a spur
  • layout-tests/editing/inserting/insert-div-024-expected.txt:
12:36 PM Changeset in webkit [8413] by hyatt
  • 2 edits in trunk/WebCore

Fix for oddness on albertsons.com. Make sure not to crash when setting/removing style properties on a node
with no document. The bug # is 3813900.

Reviewed by john

11:34 AM Changeset in webkit [8412] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

PARTIAL fix for following bug. Create attributed string with fonts and links. Still need to add attachments.
<rdar://problem/3942606> AX: Support kAXAttributedStringForTextMarkerRangeParameterizedAttribute

  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): Touched up previous checkin to match code review comments.

(-[KWQAccObject value]):
Use plainText for this one instead of obsolete attributedString.

(-[KWQAccObject accessibilityParameterizedAttributeNames]):
Advertise AXAttributedStringForTextMarkerRange.

(AXAttributeStringAddFont):
(AXAttributeStringAddElement):
(-[KWQAccObject linkUIElementForNode:]):
(-[KWQAccObject _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[KWQAccObject accessibilityAttributedStringForRange:]):
New routines to support AXAttributedStringForTextMarkerRange.

(-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
Use new routines instead of obsolete attributedString.

11:01 AM Changeset in webkit [8411] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3960196> AX Crash in DOM::Range::setStartBefore

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::getAccObjectCache): Adjust when detecting cache in non-top level WebArea.
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject accessibilityAttributeValue:]): Make sure the elements document is the current one for the part.
10:05 AM Changeset in webkit [8410] by darin
  • 6 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3922980> Mail not crashing, just quitting itself suddenly in -[WebHTMLView(MailExtras) findString:options:]
  • khtml/dom/dom2_range.cpp: (DOM::operator==): Handle null and detached ranges without raising exceptions. The uncaught exception would make the entire program terminate.
  • fixed <rdar://problem/3885729> attempting to modify a computed style does nothing, but should raise a DOM exception
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setProperty:::]): Uncommented this code which I had to disable back in November because Mail was stumbling over it.
  • fixed <rdar://problem/3943049> focus() called during onload handler results in square text field on <input type=search>
  • kwq/KWQLineEdit.mm: (QLineEdit::baselinePosition): Change computation so it will work even for fields that position their text in a way that depends on vertical size. In the case of a search field, the text is centered, so the old logic was broken.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Set the frame size to something large enough to accomodate the field editor. If we start the frame at size 0,0 we run into AppKit trouble when it insets the frame to figure out the frame for the field editor. In the case of this bug this happens because we become first responder before being sized and positioned by the HTML layout code.
  • improved debugging output when using "po" from gdb with Objective-C DOM
  • kwq/DOM.mm: (-[DOMNode description]): Added. Includes node name ("<tr>") and node value (e.g., string for text node). (-[DOMRange description]): Tweaked format.

Jan 19, 2005:

6:09 PM Changeset in webkit [8409] by rjw
  • 2 edits in trunk/WebCore

After further discussion with Real we have decided to NOT include the
additional CLSID for the real plugin. See 3958601.

Reviewed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
5:39 PM Changeset in webkit [8408] by rjw
  • 5 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3853676> Browser Crash when accessing CCWeb Progress Page - KJS::Bindings::convertValueToJValue

Fixed the following problems with LiveConnect that are demonstrated by the application
described in 3853676.

  1. If a nil object is passed in an array from Java to JavaScript we will crash.
  2. We sometimes will incorrectly attempt to access a generic JavaScript as a Java runtime object wrapper.
  3. We will sometimes fail to find the correct static method ID.

Reviewed by Maciej.

  • bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue): (JSObject::listFromJArray):
  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getMethodID): (KJS::Bindings::convertValueToJValue):
  • bindings/runtime_array.h:
4:45 PM Changeset in webkit [8407] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line

Previous checkin for this bug was missing some of the patch. Editing snafu with multiple changes in tree.

  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):
4:05 PM Changeset in webkit [8406] by hyatt
  • 2 edits in trunk/WebKit

Fix for 3513067, spaces being lost when RTL text is rendered. Make sure not to allow hangers or spaces
in the margin.

Reviewed by john

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
4:01 PM Changeset in webkit [8405] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Small, cosmetic change John and I decided to do on my last checkin, but I forgot to do before landing.
3:54 PM Changeset in webkit [8404] by kocienda
  • 21 edits
    6 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::applyStyle): (khtml::CompositeEditCommand::insertBlockPlaceholder): New function that unconditionally adds a block placeholder. (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Now returns bool based on whether placeholder was added or not. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Now searches all the descendents of a block looking for a placeholder. The old code, which just looked at the last child of a node, started missing once block placeholders became styled (which started happening with this patch). (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Now handles applying typing style to a block placeholder at call time, rather than setting the typing style as a latent style that might be applied later. This is an important part of the bug fix. (khtml::DeleteSelectionCommand::doApply): Now uses bool return value from insertBlockPlaceholderIfNeeded() and passes it along to calculateStyleBeforeInsertion, so the case where a block placeholder needs to be styled can be detected. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Changed the way this class managed style. Before it would calculate and set typing style for the block added. This is not sufficient. Added blocks need to styled immediately. Some name changes to instance variables in this class due to the change to accommodate this change. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Name changes, as above. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Improve check for testing when a placeholder block can be removed in its entirety after the insertion.
  • khtml/editing/htmlediting.h: Update header accordingly.
  • khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle): Move position for computed style check downstream before doing check when the position is in an empty block (this makes sure any style on any block placeholder is accounted for).

New layout tests to check bug fix.

  • layout-tests/editing/style/block-style-004-expected.txt: Added.
  • layout-tests/editing/style/block-style-004.html: Added.
  • layout-tests/editing/style/block-style-005-expected.txt: Added.
  • layout-tests/editing/style/block-style-005.html: Added.
  • layout-tests/editing/style/block-style-006-expected.txt: Added.
  • layout-tests/editing/style/block-style-006.html: Added.

Results updated to reflect new block placeholder code.

  • layout-tests/editing/inserting/insert-div-004-expected.txt
  • layout-tests/editing/inserting/insert-div-005-expected.txt
  • layout-tests/editing/inserting/insert-div-006-expected.txt
  • layout-tests/editing/inserting/insert-div-008-expected.txt
  • layout-tests/editing/inserting/insert-div-011-expected.txt
  • layout-tests/editing/inserting/insert-div-012-expected.txt
  • layout-tests/editing/inserting/insert-div-013-expected.txt
  • layout-tests/editing/inserting/insert-div-014-expected.txt
  • layout-tests/editing/inserting/insert-div-015-expected.txt
  • layout-tests/editing/inserting/insert-div-016-expected.txt
  • layout-tests/editing/inserting/insert-div-017-expected.txt
  • layout-tests/editing/inserting/insert-div-018-expected.txt
  • layout-tests/editing/inserting/insert-div-019-expected.txt
  • layout-tests/editing/inserting/insert-div-021-expected.txt
  • layout-tests/editing/inserting/insert-div-022-expected.txt
  • layout-tests/editing/inserting/insert-div-023-expected.txt
  • layout-tests/editing/inserting/insert-div-024-expected.txt
2:57 PM Changeset in webkit [8403] by vicki
  • 2 edits in trunk/WebKit

Reviewed by vicki

  • fixed <rdar://problem/3962559> stopAnimationsInView leaks after cvs-base
  • WebCoreSupport.subproj/WebImageData.m: (+[WebImageData stopAnimationsInView:]): add a release
2:43 PM Changeset in webkit [8402] by hyatt
  • 2 edits in trunk/WebCore

Dont null-check the renderer before submitting, since a script can set it to display:none and still expect the
submission to occur. Fixes bug #3477282.

Reviewed by kdecker

(DOM::HTMLInputElementImpl::defaultEventHandler):

10:39 AM Changeset in webkit [8401] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL

Reviewed by john.

  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty

Jan 18, 2005:

6:34 PM Changeset in webkit [8400] by rjw
  • 22 edits in trunk

WebCore:

Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

Reviewed by Chris.

  • khtml/dom/html_document.cpp: (HTMLDocument::objects):
  • khtml/dom/html_document.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::getObjectInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getObjectInstanceForView):

JavaScriptCore:

Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

Reviewed by Chris.

  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::supportsSetValueOfUndefinedField):
  • bindings/runtime.h: (KJS::Bindings::Instance::supportsSetValueOfUndefinedField):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::fallbackObject):
  • kjs/object.cpp: (KJS::ObjectImp::ObjectImp):
  • kjs/object.h: (KJS::ObjectImp::forwardingScriptMessage): (KJS::ObjectImp::setForwardingScriptMessage):
3:08 PM Changeset in webkit [8399] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3948123, rolling over link erases nearby text. The repaint rect check for lines was wrong whenever
two lines overlapped.

Reviewed by kocienda

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
2:58 PM Changeset in webkit [8398] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3960116> Focus rings paint incorrectly for contenteditable blocks in web pages

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Fix painting of focus rings so that ring only paints around outermost contenteditable elements.
2:52 PM Changeset in webkit [8397] by rjw
  • 2 edits in trunk/JavaScriptCore

Back out a change that was incorrectly committed yesterday.

Reviewed by Chris.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
1:03 PM Changeset in webkit [8396] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3959668> accessibilityFocusedUIElement sometimes returns an ignored element; it must not

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityFocusedUIElement]): Return parentObjectUnignored if focused object is ignored.
10:11 AM Changeset in webkit [8395] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3952877> REGRESSION (Mail): Command-left/right-arrows don't work with file attachment

  • khtml/editing/selection.cpp: (khtml::nodeForInlineBox): New helper function used in reimplementation of function below. (khtml::selectionForLine): Reimplemented using line box smarts. I originally wrote this code when I had a less than full understanding of line layout. I can do better now, and my new version no longer fails to notice attachments when doing the kind of navigation mentioned in the bug.

Jan 17, 2005:

5:44 PM Changeset in webkit [8394] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
<rdar://problem/3949848> AX: paragraph marker routines do not work when given a paragraph end marker

Also fixed sentence support in the same way.

  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Move one position in desired direction before calling visible_units.cpp code.
5:33 PM Changeset in webkit [8393] by harrison
  • 8 edits in trunk

Updated expected test results.

<rdar://problem/3945880> line-ending space seems not to be present

  • layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
  • layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
  • layout-tests/editing/inserting/insert-div-020-expected.txt:
  • layout-tests/editing/inserting/insert-div-021-expected.txt:
  • layout-tests/editing/inserting/insert-div-022-expected.txt:
  • layout-tests/editing/inserting/insert-div-023-expected.txt:
  • layout-tests/editing/inserting/insert-div-024-expected.txt:
5:07 PM Changeset in webkit [8392] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).

<rdar://problem/3945880> line-ending space seems not to be present

  • khtml/editing/selection.cpp: (khtml::Selection::validate): Extend AFTER_WHITE_SPACE code to support white spac in the middle of paragraphs, not just the end.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Pick left/rightness of word selection based on being at the end of paragraph (i.e. after a hard line break).
5:06 PM Changeset in webkit [8391] by darin
  • 2 edits in trunk/WebKit
  • DOM.subproj/DOMPrivate.h: Check in generated file.
4:43 PM Changeset in webkit [8390] by darin
  • 5 edits in trunk/WebCore

Reviewed by John Louch.

  • fixed <rdar://problem/3958503> need screenX and screenY to use WebKit windowFrame delegate
  • khtml/ecma/kjs_window.cpp: (Window::get): Change screenX and screenY to use frameGeometry instead of using mapToGlobal and screen in a complicated way.
  • kwq/KWQKHTMLView.mm: Removed unused mapToGlobal function.
  • kwq/KWQWindowWidget.h: Ditto.
  • kwq/KWQWindowWidget.mm: Ditto.
3:30 PM Changeset in webkit [8389] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/float

Add layout test for overflow float bug.

3:27 PM Changeset in webkit [8388] by hyatt
  • 2 edits in trunk/WebCore

Fix a screwup in rightmost/lowets position computation. 3955207. Make sure floats with layers are still checked.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp
3:23 PM Changeset in webkit [8387] by darin
  • 7 edits
    1 add in trunk/WebKit

Reviewed by John and Richard.

  • fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output
  • WebView.subproj/WebFrameViewPrivate.h: Added.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers, and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does the work is compatible with our header and footer code. (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating the NSPrintOperation, and also the PDFKit SPI works this way.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
  • WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
  • WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO. (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.
  • WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.
3:08 PM Changeset in webkit [8386] by rjw
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_binding.cpp

Fixed build snafu.

2:54 PM Changeset in webkit [8385] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

<rdar://problem/3953366> Problems with typing attributes in HTML compose

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Remove misguided "optimization" that tried to sense when typing style could be cleared without actually doing a style diff between before-delete and after-delete positions. Removing this extra check and running the general-purpose code fixes the bug.
2:41 PM Changeset in webkit [8384] by rjw
  • 26 edits in trunk

WebCore:

Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

Reviewed by David Harrison.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isGlobalObject): (ScriptInterpreter::isSafeScript): (ScriptInterpreter::interpreterForGlobalObject):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_window.cpp: (Window::interpreter): (Window::isSafeScript):
  • khtml/ecma/kjs_window.h:
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::windowScriptNPObject):
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):

JavaScriptCore:

Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

Reviewed by David Harrison.

  • bindings/NP_jsobject.cpp: (_isSafeScript): (_NPN_CreateScriptObject): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
  • bindings/NP_jsobject.h:
  • bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::stringValue):
  • bindings/c/c_instance.h:
  • bindings/c/c_utility.cpp: (convertValueToNPVariant):
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
  • bindings/jni/jni_instance.h:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _initializeWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject _initWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject _setOriginExecutionContext:KJS::Bindings::]): (-[WebScriptObject _isSafeScript]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • bindings/runtime.cpp: (Instance::Instance): (Instance::operator=):
  • bindings/runtime.h: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
  • bindings/runtime_root.cpp: (RootObject::setInterpreter):
  • bindings/runtime_root.h:
  • kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
2:20 PM Changeset in webkit [8383] by kocienda
  • 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp

Roll out unintended work-in-progress change

2:18 PM Changeset in webkit [8382] by kocienda
  • 11 edits
    8 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with
"size up" and "size down" NSFontManager changes

  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Add support for parsing new font size delta property.
  • khtml/css/cssproperties.c: Generated file.
  • khtml/css/cssproperties.h: Ditto.
  • khtml/css/cssproperties.in: Add support for parsing new font size delta property.
  • khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): New helper function. Code existed before, but now factored out for convenient use. (khtml::CompositeEditCommand::removeNodeAttribute): Does check on value to see it exists before creating and running command to do the removal. (khtml::ApplyStyleCommand::doApply): Now calls new applyRelativeFontStyleChange() function as part of its work. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): New function that does the "heavy lifting" to handle relative font size changes. (khtml::ApplyStyleCommand::applyInlineStyle): Range check the start and end positions to make sure the start is before or equal to the end. Swap them if not true. I ran into this problem in some similar code in applyRelativeFontStyleChange(). Moving that goodness here too. (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): Uses a local variable to save a value used often. Code is the same, but reads better now. Function now returns bool as well, just like splitTextAtStartIfNeeded. I use the bool return value now (I obviously did not need it before). (khtml::ApplyStyleCommand::computedFontSize): New helper function. (khtml::ApplyStyleCommand::joinChildTextNodes): Ditto. (khtml::createStyleSpanElement): Ditto.
  • khtml/editing/htmlediting.h: Update header accordingly.
  • khtml/editing/jsediting.cpp: Add new command string to enable relative font size changes.
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): New convenience. (-[DOMCSSStyleDeclaration _setFontSizeDelta:]): Ditto.
  • kwq/DOMPrivate.h: Declare new conveniences.
  • layout-tests/editing/editing.js: Add new JS to enable relative font size changes, as well as explicit font size setting.
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-001.html: Added.
  • layout-tests/editing/style/relative-font-size-change-002-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-002.html: Added.
  • layout-tests/editing/style/relative-font-size-change-003-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-003.html: Added.
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-004.html: Added.

Jan 14, 2005:

3:55 PM Changeset in webkit [8381] by darin
  • 5 edits in trunk/WebCore
  • khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
  • khtml/css/cssvalues.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmlattrs.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmltags.c: Regenerated with gperf 3.0.1.
12:09 PM Changeset in webkit [8380] by cblu
  • 5 edits in trunk/WebCore

Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to return to RSS page

Reviewed by hyatt.

(KWQKHTMLPart::openURLFromPageCache): restore mousePressNode
(KWQKHTMLPart::mousePressNode): new

  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): save the mousePressNode (-[KWQPageState clear]): clear the mousePressNode (-[KWQPageState dealloc]): deref the mousePressNode (-[KWQPageState mousePressNode]): new

Jan 13, 2005:

6:14 PM Changeset in webkit [8379]
  • 25 copies
    2 deletes in tags/WebKit-85~8~5

This commit was manufactured by cvs2svn to create tag
'WebKit-85~8~5'.

6:14 PM Changeset in webkit [8378] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit

fixed mismatched_CFBundleShortVersionStrings verification failure by correcting

version string to 1.0.3

5:40 PM Changeset in webkit [8377] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • bump WebKit version number to 85.8.5; the tag "WebKit-85~8~3" is already taken, and

version numbers with a "4" are not allowed because of Netscape 4 compatibility

5:30 PM Changeset in webkit [8376] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit

versioning for January 2005 Security Update, WebKit-85.8.3

5:24 PM Changeset in webkit [8375]
  • 23 copies
    2 deletes in tags/WebCore-85~6~6

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~6'.

5:24 PM Changeset in webkit [8374] by adele
  • 3 edits in branches/Safari-1-0-branch/WebCore

versioning for January 2005 Security Update, WebCore-85.6.6

5:01 PM Changeset in webkit [8373] by cblu
  • 6 edits in trunk/WebKit

Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPluginMIMETypes key is not in the info.plist

Fixing this bug required that we allow WebKit plug-ins (as well as Netscape plug-ins) support BP_CreatePluginMIMETypesPreferences
which allows plug-ins create an auxiliary MIME types file.

Reviewed by adele.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): moved from WebNetscapePluginPackage (-[WebBasePluginPackage pListForPath:createFile:]): ditto (-[WebBasePluginPackage getPluginInfoFromPLists]): ditto (-[WebBasePluginPackage isLoaded]): return isLoaded ivar (-[WebBasePluginPackage load]): if loaded, get BP_CreatePluginMIMETypesPreferences symbol
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): call getPluginInfoFromPLists (-[WebPluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
4:29 PM Changeset in webkit [8372] by adele
  • 12 edits in branches/Safari-1-0-branch

WebCore:

<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another
<rdar://problem/3939484> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs
<rdar://problem/3943552> WebKit needs to restrict access to certain window operations by domain

merged these fixes from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

2004-12-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.

I considered a few other possible exploits and made no change:

  • document.location is already protected because the document object itself is protected
  • frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

<rdar://problem/3929187> WebKit needs to restrict access to certain window operations by domain

  • khtml/ecma/kjs_window.cpp: (Window::get): Change most window functions to be restricted by XSS domain check.

The following files were changed to complete the merge. Added compareIgnoringCaseForASCIIOnly and startsWith functions
to match how it is in later versions.

  • kwq/KWQString.h:
  • kwq/KWQString.mm: (compareIgnoringCaseForASCIIOnly): (QString::startsWith): (QString::find):

WebKit:

<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another

merged fix for this from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
  • WebView.subproj/WebViewPrivate.h:
4:17 PM Changeset in webkit [8371] by rjw
  • 1 edit in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h

Changed another place where the method name was incorrect in
the comment.

Reviewed (and found) by Darin.

4:11 PM Changeset in webkit [8370] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected (webPlugInCallJava)

Reviewed by Maciej.

  • Plugins.subproj/WebJavaPlugIn.h:
4:05 PM Changeset in webkit [8369] by vicki
  • 3 edits in trunk

Safari-179+ for TOT. The tree is open!

3:58 PM Changeset in webkit [8368]
  • 1 copy in tags/Safari-179

This commit was manufactured by cvs2svn to create tag 'Safari-179'.

3:58 PM Changeset in webkit [8367] by vicki
  • 6 edits in trunk

Safari-179 stamp

3:54 PM Changeset in webkit [8366] by vicki
  • 6 edits in trunk

Reviewed by Adele.

  • fix <rdar://problem/3946836> Safari about box lists 2004 instead of 2005
2:13 PM Changeset in webkit [8365] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts no longer update

Draw last image after animation loop terminates. (We
were drawing the image at index+1, which doesn't exist!)

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _nextFrame:]):
2:02 PM Changeset in webkit [8364] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover

Turn off use of new CGContextStrokeLineSegments API. We should
turn back on when 3952944 is fixed.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
1:17 PM Changeset in webkit [8363] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

fixed incorrect check-in date

11:45 AM Changeset in webkit [8362] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

Better fix for 3905066.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
11:41 AM Changeset in webkit [8361] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source

Reviewed by adele.

  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): if [WebImageRenderer image] returns nil, fallback to code that uses a file icon as the drag image
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): removed code that omits PDF and PostScript from the list since this omission is only needed in WebImageView
  • WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): added code that omits PDF and PostScript since we don't want WebImageView to render these types
11:09 AM Changeset in webkit [8360] by mjs
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

  • khtml/rendering/render_text.cpp: (InlineTextBox::paint): Support painting custom underline markers for marked text in place of generic yellow. (InlineTextBox::paintMarkedTextUnderline): New method that handles this.
  • khtml/rendering/render_text.h:
  • kwq/KWQKHTMLPart.h: Declare new methods and structs.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Clear marked test underlines. (KWQKHTMLPart::setMarkedTextRange): Takes attributes and ranges now. (convertAttributesToUnderlines): Converts NSAttributedString attributes to simplified and C++-friendly form. (KWQKHTMLPart::markedTextUsesUnderlines): New method. (KWQKHTMLPart::markedTextUnderlines): New method.
  • kwq/KWQPainter.mm: (QPainter::drawLineForText): Handle pen width.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): Take attributes and ranges.
  • kwq/WebCoreTextRenderer.h:

WebKit:

Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Changed to support underline thickness. Also added a bit of a hack here to move thickness 2 underlines down by .5 pixels, since the rendering engine can't give a fractional pixel offset.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]): Support underline, underline color and marked clause attributes. Others that NSText supports are unimplemented for now. (-[WebHTMLView firstRectForCharacterRange:]): Remove needless logging. (-[WebHTMLView unmarkText]): Updated for new WebCore SPI. (-[WebHTMLView _extractAttributes:ranges:fromAttributedString:]): New method to pull the attributes and ranges out of an attributed string. (-[WebHTMLView setMarkedText:selectedRange:]): Extract attributes and pass to WebCore. (-[WebHTMLView insertText:]): Add comment noting that we don't really handle attributed strings here.

Jan 12, 2005:

9:19 PM Changeset in webkit [8359]
  • 71 copies
    2 deletes in tags/WebCore-125~8~13

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~13'.

9:19 PM Changeset in webkit [8358] by adele
  • 2 edits in branches/Safari-1-2-branch/WebCore

Versioning for WebCore-125.8.13 for the Security Update

9:18 PM Changeset in webkit [8357]
  • 27 copies
    3 deletes in tags/WebKit-125~5~6

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~6'.

9:18 PM Changeset in webkit [8356] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

Versioning for WebKit-125.5.6 for the Security Update

8:24 PM Changeset in webkit [8355] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • fix for the following bug was incomplete, fixed error in one particular case

<rdar://problem/3939324> *SecUpd: Panther* frame naming allows malicious site to bring up a window when you click on a link in another

5:42 PM Changeset in webkit [8354] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

Missing part of last change.

5:31 PM Changeset in webkit [8353] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/3888973> AX: Parent AXWebArea of nested AXWebAreas is messed up

  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]): Use the widget's outer view.
5:19 PM Changeset in webkit [8352] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Add quotes around text node content. (NodeBaseImpl::childNode): Add nil check to return nil rather than crash when child node not found.
  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXStringForTextMarkerRange:]): Pass range compliant positions to TextIterator.
4:51 PM Changeset in webkit [8351] by mjs
  • 8 edits in branches/Safari-1-2-branch

WebCore:

<rdar://problem/3939324> *SecUpd: Panther* frame naming allows malicious site to bring up a window when you click on a link in another

  • merged fix for this from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

WebKit:

<rdar://problem/3939324> *SecUpd: Panther* frame naming allows malicious site to bring up a window when you click on a link in another

  • merged fix for this from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
  • WebView.subproj/WebViewPrivate.h:
4:39 PM Changeset in webkit [8350] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

<rdar://problem/3943553> *SecUpd: Panther* WebKit needs to restrict access to certain window operations by domain

  • merged the following fix from Tiger to fix this

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

<rdar://problem/3929187> WebKit needs to restrict access to certain window operations by domain

  • khtml/ecma/kjs_window.cpp: (Window::get): Change most window functions to be restricted by XSS domain check.
4:08 PM Changeset in webkit [8349] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

<rdar://problem/3939485> *SecUpd: Panther* scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

  • merged the following fix from Tiger to fix this

2004-12-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.

I considered a few other possible exploits and made no change:

  • document.location is already protected because the document object itself is protected
  • frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
3:55 PM Changeset in webkit [8348] by darin
  • 4 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3848257> WebView will draw more than AppKit asks it to, so views behind won't redraw enough (transparent WebView)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): As recommended by Troy Stephens, do the layouts here in this call, since it's before propagating the dirty rects to our ancestors. This fixes the bug, but we only do it if the WebView is not opaque, because otherwise we can optimize by only doing layouts you really need, and doing them later on is safe because we know we don't need to draw any of the views behind us. (-[WebHTMLView _layoutIfNeeded]): Added. Factored out from the method below. (-[WebHTMLView _web_layoutIfNeededRecursive]): Added. Like the other "layout if needed" call, but unconditional. (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): Factored out the guts into the _layoutIfNeeded method above. Otherwise unchanged. (-[NSView _web_layoutIfNeededRecursive]): Added.
  • WebView.subproj/WebFrame.m: (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground:NO on the scroll view when changing the frame to no longer be in "draws background" mode. This is needed because the frame manages the "draws background" mode of the scroll view. It won't have any effect if you call setDrawsBackground:NO before starting to use a WebView, but without it calling setDrawsBackground:NO later won't have an immediate effect (easily visible in Safari). This was hidden before because the HTML view was filling with transparent color, which blew away the fill that was done by NSScrollView.
  • fixed <rdar://problem/3921129> reproducible crash at www.funnychristmas.com in CFSet manipulation in WebImageData
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]): Changed types so we don't need a cast. (+[WebImageData stopAnimationsInView:]): Instead of building a set of sets, by putting in the sets with addObject, build a single set using unionSet, and then iterate the objects instead of having to iterate the sets and then the objects in each set. The old code ended up sharing the sets with the live code, when the whole idea was to gather all the renderers because the process of stopping modifies the active sets.
3:41 PM Changeset in webkit [8347] by rjw
  • 2 edits in trunk/JavaScriptCore

Avoid additional work on dealloc by adding early out to
removeNativeReference(). (This will save time on dealloc
for all ObjC DOM objects.)

Reviewed by Darin.

  • bindings/runtime_root.cpp: (KJS::Bindings::removeNativeReference):
3:33 PM Changeset in webkit [8346] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3951203, CSS border style incorrectly clipped on inline elements. Make sure the repaint rect set during
line layout is smarter about including the overflow for both old states and new states.

Reviewed by john

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
3:24 PM Changeset in webkit [8345] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3923356> REGRESSION: Java/JavaScript security checks working incorrectly

We were always returning the first "root" object for all runtime
objects. Changed 0 in loop to i, the index.

Reviewed by David Harrison.

  • bindings/runtime_root.cpp: (KJS::Bindings::rootForImp):
2:03 PM Changeset in webkit [8344] by rjw
  • 5 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3887930> Must use new Java plug-in API to get/set fields so exception handling works (fixes many LiveConnect crashes)

Use the new dispatching API to invoke JNI, rather than calling JNI
directly.

Reviewed by David Harrison.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
1:41 PM Changeset in webkit [8343] by rjw
  • 3 edits in trunk/WebKit

Fixed <rdar://problem/3926825> Safari ignores GIF loop count

Get loop count from file properties, not image properties.

Reviewed by Ken Kocienda.

  • WebCoreSupport.subproj/WebImageData.h:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _commonTermination]): (-[WebImageData fileProperties]): (-[WebImageData _floatProperty:type:at:]): (-[WebImageData _floatFileProperty:type:]): (-[WebImageData _repetitionCount]):
11:13 AM Changeset in webkit [8342] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 3937608, versiontracker.com flashes and displays the right column below content. Make sure to move
tables/overflows that dont fit within a block only in strict mode.

Fix for bug 3931049, characters dont show up when typing. Make sure to dirty the right lines when this specific
case in editing is hit.

Reviewed by darin (first one), kocienda (second one)

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::getClearDelta):
  • khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::verticallyAlignBoxes):
9:55 AM Changeset in webkit [8341] by kocienda
  • 7 edits
    8 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Change test that will prevent block merging. End-of-line test was just wrong. Call new start-of and end-of paragraph functions added to visible_position files. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Add tests for BR elements, which makes tests to determine when to stop moving nodes more complete and correct. Also improved comments.
  • khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInParagraph): New function. (khtml::isLastVisiblePositionInParagraph): New function.
  • khtml/editing/visible_position.h: Update header accordingly.
  • layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt: New results, slightly different from former results but still correct.
  • layout-tests/editing/deleting/delete-block-merge-contents-007-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-block-merge-contents-018-expected.txt: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-018.html: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-019-expected.txt: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-019.html: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-020-expected.txt: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-020.html: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-021-expected.txt: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-021.html: Added.
  • layout-tests/editing/deleting/delete-line-014-expected.txt: These new results are actually better, and fix a bug.

Jan 11, 2005:

4:49 PM Changeset in webkit [8340] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loading movie

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView
4:30 PM Changeset in webkit [8339] by rjw
  • 3 edits in trunk/WebCore

Fixed 3922875. Fall back to DOM object is EMBED element
has no associated runtime object.

Reviewed by Chris.

  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
3:46 PM Changeset in webkit [8338] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3882299, missing content on gibson.com. Change our handling of " and ' in certain states of the parser to match
other browsers.

Reviewed by Maciej

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
3:43 PM Changeset in webkit [8337] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fixed <rdar://problem/3446838> REGRESSION (Mail): text decorations don't print (e.g. <strike>, underline)
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): This bottleneck routine for drawing a line was setting the linewidth to 0 when the graphics context was not drawing to the screen. Thus, no lines. Now links are underlined when printing from Safari (as well as Mail).
2:50 PM Changeset in webkit [8336] by rjw
  • 2 edits in trunk/WebKit

Fixed 3949145. CG has a much faster API for drawing lines.
Switched over to that new API (CGContextStrokeLineSegments).

Reviewed by John Sullivan.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
2:44 PM Changeset in webkit [8335] by cblu
  • 5 edits in trunk/WebCore

Fixed: <rdar://problem/3930733> Mail prints second page of email blank

Reviewed by dave.

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::paint): cache the print rect since the dirty rect can get changed during printing
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): removed null check since the print rect should never be null
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): ditto
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::adjustPageHeight): don't set the print rect here since this method is not called for the last page
1:25 PM Changeset in webkit [8334] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3948862> REGRESSION: missing images when RTFD is pasted into editable WebView

This problem occurred because we were creating image elements before creating corresponding image resources. The fix is to have AppKit call us back to create the resources before it creates the elements.

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): don't deal with subresources since that's now done by the following method (-[WebHTMLView resourceForData:preferredFilename:]): new handler method called by AppKit

Jan 10, 2005:

3:40 PM Changeset in webkit [8333] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3943648> extra line is inserted after pressing return within quoted text of reply

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): This bug was the result of a simple coding mistake. A local variable was erroneously redefined in a deeper scope, and so the result calculated in that deeper scope was not available when tested.
3:28 PM Changeset in webkit [8332] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3946852> Option-e goes to next line

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Tweak case used to determine when merging content into the start line is done. We plan to change pretty substantially soon to better handle the problem described in <rdar://problem/3937352> Quote level not maintained when copied and pasted within a Mail message. In the meantime, this change does no harm, and fixes the bug.
10:47 AM Changeset in webkit [8331] by kocienda
  • 5 edits
    26 adds in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/3907005> Applying block styles to a line of text can unexpectedly affect other lines

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): New function which moves "paragraphs" to their own blocks if needed so that a block style can be applied. (khtml::CompositeEditCommand::isMailBlockquote): Moved this function to base class so it can be used more generally. (khtml::ApplyStyleCommand::applyBlockStyle): Pass a node instead of a block to addBlockStyleIfNeeded(). (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Now accepts a node instead of a block for styling. This function also now calls moveParagraphContentsToNewBlockIfNecessary() to make sure that only the current paragraph is styled. (khtml::SetNodeAttributeCommand::doUnapply): Should not assert on undo if old value of attribute was null. Should remove attributue instead.
  • khtml/editing/htmlediting.h: Touch function declarations accordingly.
  • layout-tests/editing/style/create-block-for-style-001-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-001.html: Added.
  • layout-tests/editing/style/create-block-for-style-002-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-002.html: Added.
  • layout-tests/editing/style/create-block-for-style-003-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-003.html: Added.
  • layout-tests/editing/style/create-block-for-style-004-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-004.html: Added.
  • layout-tests/editing/style/create-block-for-style-005-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-005.html: Added.
  • layout-tests/editing/style/create-block-for-style-006-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-006.html: Added.
  • layout-tests/editing/style/create-block-for-style-007-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-007.html: Added.
  • layout-tests/editing/style/create-block-for-style-008-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-008.html: Added.
  • layout-tests/editing/style/create-block-for-style-009-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-009.html: Added.
  • layout-tests/editing/style/create-block-for-style-010-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-010.html: Added.
  • layout-tests/editing/style/create-block-for-style-011-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-011.html: Added.
  • layout-tests/editing/style/create-block-for-style-012-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-012.html: Added.
  • layout-tests/editing/style/create-block-for-style-013-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-013.html: Added.

Unrelated updates to these expected results.

  • layout-tests/editing/inserting/insert-div-007-expected.txt
  • layout-tests/editing/pasteboard/paste-text-013-expected.txt
10:38 AM Changeset in webkit [8330] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print

Reviewed by john.

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): don't do pagination work if printRect is not set
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): ditto
10:22 AM Changeset in webkit [8329] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): Return empty string (AKA root locale) if locale pref can not be canonicalized.
9:07 AM Changeset in webkit [8328] by sullivan
  • 2 edits in trunk/WebCore

Fixed broken Panther build.

  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): This recently-added function was using code copy/pasted from CarbonCore UnicodeUtilities. That code used a Tiger-only function, CFLocaleCreateCanonicalLanguageIdentifierFromString. To fix the build, I added a BUILDING_ON_PANTHER #ifdef that avoids the call to the Tiger function. However, the Tiger-only code was wrong; the string generated using CFLocaleCreateCanonicalLanguageIdentifierFromString was not used at all, so I fixed that as well.

Jan 9, 2005:

1:42 PM Changeset in webkit [8327] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3786362> REGRESSION (Mail): pasted text loses one newline

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Tune check for need for insertParagraphSeparator when hasInterchangeNewline.
11:11 AM Changeset in webkit [8326] by darin
  • 2 edits in trunk/WebCore

Reviewed by Harrison.

  • fixed <rdar://problem/3939176> select() method does not work on <input type=search>
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::select): Changed if statement to a switch statement. Added SEARCH to the set of types that treat the renderer as a RenderLineEdit.
10:54 AM Changeset in webkit [8325] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3905066> REGRESSION (Mail): Hitting return key with caret in front of space causes space to become lost (resize fixes)

Problem was that InsertParagraphSeparatorCommand::doApply() was not collapsing
whitespace to a single non-breaking space when splitting a text node.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
10:40 AM Changeset in webkit [8324] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Ken.

Fixed: <rdar://problem/3924219> Calling setOuterHTML: on a DOMHTMLHtmlElement can crash a program

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): Added a nil check for fragments who don't have parents.

Jan 8, 2005:

8:09 PM Changeset in webkit [8323] by mjs
  • 4 edits in trunk

Reviewed by Darin.

<rdar://problem/3807144> REGRESSION (125-TOT): my bank's website doesn't work (Societe Generale, socgen.com)

  • Khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): If the document is NULL, assume this frame has not started loading yet so it could not possibly be finishing here... (KHTMLPart::stop): ...unless the part is explicitly stopped and there is still no document, in this case we must have hit an error or been loading a non-HTML frame.
  • khtml/khtml_part.h:
12:42 PM Changeset in webkit [8322] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3943415> REGRESSION (Mail): double-clicking past word selects previous word instead of only blank space

  • khtml/editing/selection.cpp: (khtml::Selection::validate): Tune word selections left/right choice to use right if on empty last line.

Jan 7, 2005:

4:17 PM Changeset in webkit [8321] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942619> AX: Support sentence ax attributes

Needed to use the unicode utilities properly. Twas lame before.

  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfWord): (khtml::endOfWord): (khtml::previousWordPosition): (khtml::nextWordPosition): (khtml::startOfSentence): (khtml::endOfSentence): (khtml::previousSentencePosition): (khtml::nextSentencePosition):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): (KWQFindSentenceBoundary): (KWQFindNextSentenceFromIndex):
2:42 PM Changeset in webkit [8320] by kocienda
  • 2 edits
    4 adds in trunk

Reviewed by Kevin

Fix for these bugs:

<rdar://problem/3939523> in some cases, text does not retain style info after pressing return twice
<rdar://problem/3944492> after pressing return twice, text is bold when it shouldn't be

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): Merge the typing style with the computed style for the current position. Fixes both bugs.
  • khtml/editing/htmlediting.h:
  • layout-tests/editing/inserting/insert-div-023-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-023.html: Added.
  • layout-tests/editing/inserting/insert-div-024-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-024.html: Added.
12:38 PM Changeset in webkit [8319] by hyatt
  • 5 edits in trunk/LayoutTests/fast

Fix the layout tests.

12:22 PM Changeset in webkit [8318] by hyatt
  • 7 edits in trunk/WebCore

Fix for 3941364, make sure tables reset overflowWidth/Height when they lay out again. Fixes the odd scrolling
behavior on worldofwarcraft.com.

Reviewed by kevin

  • ChangeLog:
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
12:13 PM Changeset in webkit [8317] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3848412> for forwarded message, tabbing to message view scrolls to bottom of view

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Don't scroll the focus node to visible if it is not in the document, or if it is not a descendent of the document element. In the case of the bug, since the selection has not yet been set up, the focus node passed here is the HTML element, and that does not yield a rect that is useful to us here. So now, in the case the bug mentions, we do nothing.

Jan 6, 2005:

6:30 PM Changeset in webkit [8316] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by mjs.

Fixed: <rdar://problem/3932215> REGRESSION (125-177): iFrame example at developer.apple.com fails in Safari

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): m_bComplete was never true for frames generated by Javascript due to our synchronous loading and as a result, scheduled redirects wouldn't fire in KHTMLPart::scheduleLocationChange(). By virtue of being an empty document, a document is complete. In this special case it's safe at this point to call checkCompleted() which sets m_bComplete true.
4:35 PM Changeset in webkit [8315] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (178+)

4:27 PM Changeset in webkit [8314]
  • 1 copy in tags/Safari-178

This commit was manufactured by cvs2svn to create tag 'Safari-178'.

4:27 PM Changeset in webkit [8313] by vicki
  • 6 edits in trunk

Safari-178 stamp

1:56 PM Changeset in webkit [8312] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Chris.

(addendum to previous checkin for this bug)
<rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText

Fix line navigation. Add AXUIElementForTextMarker.

  • ChangeLog:
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXUIElementForTextMarker:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]):
1:13 PM Changeset in webkit [8311] by darin
  • 7 edits in trunk/WebCore

Reviewed by Ken.

  • re-fixed <rdar://problem/3760910> Request to include support for custom tag names in HTML (they already work in XML)

(turns out the PLT regression was a false alarm)

  • khtml/html/htmlparser.h: Change forbidden tag array to be allocated in the object rather than on the heap. Also use ID_LAST_TAG for the array size; the old code used ID_CLOSE_TAG which is now a much larger number.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Remove code that creates the forbidden tag array on the heap; makes more sense to just have the array be a member so we don't have to use new and delete on it. Also needed to eliminate code that used ID_CLOSE_TAG for an array size. (KHTMLParser::~KHTMLParser): Remove code that deletes the forbidden tag array. Also changed the code that manages isindex to use deref instead of delete. (KHTMLParser::reset): Use safer sizeof for clearing the forbidden tag array. Old code had the mistake of using ID_CLOSE_TAG for the array size too. (KHTMLParser::parseToken): Removed code that checks for bogus tags; it's not clear why it was ever there and it would prevent custom tags from working. Added range check before using the forbidden tag array with the token ID since custom tags will use index values past the end of the array. (KHTMLParser::getElement): Removed most of the code that makes an element by ID; now the work is done inside the DocumentImpl createHTMLElement. Any code that needs to be different than a dynamic createElement call is still here. Last time I left out a few form element types from this switch; fixed now.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Call the tagId function in the document if getTagID fails; this creates a unique per-document ID.
  • khtml/misc/htmltags.c: Regenerated.
  • khtml/misc/htmltags.h: Regenerated.
  • khtml/misc/maketags: Changed the generated constants to use "const unsigned short" instead of "#define". Changed ID_CLOSE_TAG to be a fixed value of 32000 rather than being just past the IDs of the HTML tags. Also rewrote getTagName to work with the new scheme.
11:04 AM Changeset in webkit [8310] by harrison
  • 2 edits in trunk/WebCore

Fixed Panther build. Also, do not advertize sentence support since it is incomplete.

  • kwq/KWQAccObject.mm: (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject accessibilityIsAttributeSettable:]):
10:20 AM Changeset in webkit [8309] by harrison
  • 17 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText
<rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work

Many more AX attributes supported. Numerous fixes to previous AX work.

  • khtml/editing/visible_units.cpp: (khtml::startSentenceBoundary): (khtml::startOfSentence): (khtml::endSentenceBoundary): (khtml::endOfSentence): (khtml::previousSentencePositionBoundary): (khtml::previousSentencePosition): (khtml::nextSentencePositionBoundary): (khtml::nextSentencePosition):
  • khtml/editing/visible_units.h:
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/misc/helper.cpp: (khtml::findSentenceBoundary): (khtml::nextSentenceFromIndex):
  • khtml/misc/helper.h:
  • khtml/misc/htmltags.c: (hash_tag): (findTag):
  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_object.cpp: (RenderObject::remove):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::getAccObjectCache): (DocumentImpl::updateSelection): (DocumentImpl::close): (DocumentImpl::setFocusNode): (DocumentImpl::parentDocument): (DocumentImpl::topDocument):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityShouldUseUniqueId]): (-[KWQAccObject detach]): (-[KWQAccObject anchorElement]): (-[KWQAccObject firstChild]): (-[KWQAccObject lastChild]): (-[KWQAccObject previousSibling]): (-[KWQAccObject nextSibling]): (-[KWQAccObject parentObject]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject textMarkerForVisiblePosition:]): (-[KWQAccObject visiblePositionForTextMarker:]): (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): (-[KWQAccObject topDocument]): (-[KWQAccObject topRenderer]): (-[KWQAccObject topView]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXStringForTextMarkerRange:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXBoundsForTextMarkerRange:]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]): (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]): (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXLengthForTextMarkerRange:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]): (-[KWQAccObject accessibilityHitTest:]): (-[KWQAccObject accessibilityFocusedUIElement]): (-[KWQAccObject accessibilityIsAttributeSettable:]): (-[KWQAccObject doSetAXSelectedTextMarkerRange:]): (-[KWQAccObject setAccObjectID:]): (-[KWQAccObject removeAccObjectID]):
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::visiblePositionForTextMarker): (KWQAccObjectCache::postNotificationToTopWebArea): (KWQAccObjectCache::postNotification): (KWQAccObjectCache::handleFocusedUIElementChanged):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedContents):
  • kwq/KWQTextUtilities.h:
  • kwq/KWQTextUtilities.mm: (KWQFindNextWordFromIndex): (KWQFindSentenceBoundary): (KWQFindNextSentenceFromIndex):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):
10:19 AM Changeset in webkit [8308] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Dave Hyatt

<rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView accessibilityFocusedUIElement]): Implement this so that AppKit can use it from NSAccessibilityHandleFocusChanged.

Jan 5, 2005:

4:46 PM Changeset in webkit [8307] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix changelog

2:56 PM Changeset in webkit [8306] by darin
  • 14 edits in trunk/WebCore

Reviewed by Ken.

  • re-landing a subset of my custom tag change that does not fix the bug, but also does not introduce a performance regression
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.
  • khtml/editing/htmlediting.cpp: (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for per-document tags and is just better all around for things like the document. (khtml::debugNode): Ditto.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows non-HTML elements to be nested as desired.
  • khtml/misc/htmlhashes.h: Changed return types to unsigned short.
  • khtml/misc/htmlhashes.cpp: (khtml::getTagID): Changed return type to unsigned short. (khtml::getAttrID): Ditto.
  • khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID. Also updated for a few tags that the parser handled but this did not.
  • kwq/KWQRenderTreeDebug.cpp: (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on the tag ID directly, which only works for standard nodes. (operator<<): Update to call getTagName. (nodePositionRelativeToRoot): Ditto. (writeSelection): Ditto.
2:43 PM Changeset in webkit [8305] by kocienda
  • 5 edits
    2 adds in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3941203> REGRESSION (Mail): Paste inserts content in wrong place

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Some cleanup and refinement of the concepts used to make this operation work correctly, particularly in the logic to figure out whether to merge content, and also performing merges.
  • khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInBlock): Simplification of test used to make this determination.
  • khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): New helper, used in khtml::ReplaceSelectionCommand::doApply(). (khtml::isEndOfParagraph): Ditto.
  • khtml/editing/visible_units.h: Declare new functions.
1:08 PM Changeset in webkit [8304] by vicki
  • 3 edits in trunk

change all version numbers to 177+

12:50 PM Changeset in webkit [8303]
  • 3 copies
    3 deletes in tags/WebKit-177~1

This commit was manufactured by cvs2svn to create tag 'WebKit-177~1'.

12:50 PM Changeset in webkit [8302] by vicki
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

versioning for today's WebKit dot submission, WebKit-177.1

11:01 AM Changeset in webkit [8301] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3936865> REGRESSION: canvas.drawImage no longer scales properly

Reviewed by john.

  • WebCoreSupport.subproj/WebImageData.m: use the height of the inRect instead of the fromRect when setting the origin of the context
7:59 AM Changeset in webkit [8300] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3926522> Pressing return in a quoted block inserts too many newlines

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Call to insertBlockPlaceholderIfNeeded() for the block we are adding was being done at the wrong time, which led to the placeholder remaining in the document when it was not needed. This resulted in the extra space reported in the bug.

Jan 4, 2005:

3:25 PM Changeset in webkit [8299] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixed: <rdar://problem/3936879> nil-deref, crash in InlineFlowBox::nodeAtPoint closing DHTML menus at hrweb.apple.com

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillInlineSelectionGaps): Added a nil check. If there is no selection, don't try to get the selection's containing block. If we do, we'll crash.
3:21 PM Changeset in webkit [8298] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3928329> WebKit should pass nil for "language" to checkSpellingOfString:

Reviewed by kocienda.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): pass nil not @"" for language
3:19 PM Changeset in webkit [8297] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3937203, force an update of the dashboard regions when scrollbars are added/removed.

Reviewed by kevin

  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
2:55 PM Changeset in webkit [8296] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for these two bugs:

<rdar://problem/3938935> REGRESSION (Mail): Pasting into an empty document mangles content
<rdar://problem/3939148> REGRESSION (Mail): Pasting mistakenly reverses lines

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): For 3938935, add one more case to handle an empty document; merge neither start nor end. For 3939148, improve the code which adjusts the insertion point during the process of pasting. It formerly handled only one of the possible cases.
  • layout-tests/editing/pasteboard/paste-text-015-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-text-015.html: Added.
2:34 PM Changeset in webkit [8295] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3936571, placeholder attribute should work for normal inputs for Dashboard.

Reviewed by john

  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement):
  • kwq/KWQLineEdit.mm: (QLineEdit::setPlaceholderString):
12:08 PM Changeset in webkit [8294] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3830936, hang on changeforamerica.com. Make sure to ignore the style not yet available option when
returning pseudo-styles.

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::pseudoStyleForElement):
  • khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):
11:12 AM Changeset in webkit [8293] by darin
  • 20 edits in trunk/WebCore
  • rolled out my custom tag name change again -- it caused a 1 ms PLT regression
  • khtml/css/cssstyleselector.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/selection.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/html/dtd.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/htmlhashes.cpp:
  • khtml/misc/htmlhashes.h:
  • khtml/misc/htmltags.c:
  • khtml/misc/htmltags.h:
  • khtml/misc/maketags:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_position.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
10:35 AM Changeset in webkit [8292] by kocienda
  • 3 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3927554> Style info applied to remainder of document after a newline is entered

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Clean up and simplification in code that inserts a paragraph separator. The bug was all about applying styles to the new paragraph that did not need to be applied. Now the code will detect when at the end of a style run and will not move and apply that ending style to the new paragraph, though it will place that style into the typing style. This seems to match NSText behavior.
  • layout-tests/editing/inserting/insert-div-021-expected.txt: This test result exhibited the bug fixed here. The only reason it was not noticed is that the erroneously copied inline was a span, and so did not have any visible effect on the document.
  • layout-tests/editing/inserting/insert-div-022-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-022.html: Added.
10:11 AM Changeset in webkit [8291] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3904562, make sure to clear the outline dictionary when drawing so that random focus rings dont get drawn
all over the place.

Reviewed by john

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):

Jan 3, 2005:

10:04 PM Changeset in webkit [8290] by hyatt
  • 4 edits in trunk/WebCore

Fix for float painting regressions 3932524, 3931664, and 3933068. Make the noPaint flag setting more
robust and make it work regardless of which objects get a layout or not.

Reviewed by mjs

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::insertFloatingObject): (khtml::RenderBlock::addOverhangingFloats): (khtml::RenderBlock::addIntrudingFloats):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::FloatingObject::FloatingObject):
7:24 PM Changeset in webkit [8289] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3935390> Tiger 8A341: nil deref crash in DOM::NodeImpl::traverseNextNode

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Assert that the starting point is not nil, it should not ever be (now). (HTMLCollectionImpl::item): When traversing items stop when we hit nil, meaning the end to avoid triggering above assert (formerly crash).
7:10 PM Changeset in webkit [8288] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John and Kevin.

<rdar://problem/3870317> REGRESSION(125.9-125.11) broken behavior at test.profoundlearning.com - used to

  • khtml/ecma/kjs_window.cpp: (Window::get): Look up frame names before buitin window properties to match other browsers. This regressed because we added a builtin "toolbar" property but this site had a frame with that name.
5:44 PM Changeset in webkit [8287] by mjs
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp

Back out accidentally committed change.

5:28 PM Changeset in webkit [8286] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

WebKit:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
  • WebView.subproj/WebViewPrivate.h:
2:08 PM Changeset in webkit [8285] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3933926> Tiger8A341: Mail crashes while forwarding embedded HTML message in -[WebCoreBridge ensureSelectionVisible]

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): Put in some null checks to prevent crash experienced in bug.
1:43 PM Changeset in webkit [8284] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutPositionedObjects):
1:38 PM Changeset in webkit [8283] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3928250> REGRESSION (Mail): Typing style lost after hitting return key

  • khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Initialize new typing style member variable. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Deref new typing style member variable. (khtml::InsertParagraphSeparatorCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): New function to set the typing style (khtml::InsertParagraphSeparatorCommand::calculateAndSetTypingStyleAfterInsertion): Function called after the <p> insertion is done. This function diffs the style created in setFullTypingStyleBeforeInsertion() with the style of the new <p> and only sets those styles needed to preserve the style in effect before the insertion. (khtml::InsertParagraphSeparatorCommand::doApply): Call new functions. (khtml::TypingCommand::preservesTypingStyle): Now yes for inserting line breaks and paragraphs.
    • khtml/editing/htmlediting.h: Declare new functions.
11:49 AM Changeset in webkit [8282] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixed: <rdar://problem/3505072> hang in KHTMLParser::parseToken (consulting.soroos.net)

  • khtml/html/dtd.cpp: <label> needed a much higher priority such that it will close block elements. Malformed HTML (ugh) is the only reason why we need to do this.

Dec 23, 2004:

4:06 PM Changeset in webkit [8281] by darin
  • 21 edits in trunk

Reviewed by Ken.

  • re-fixed <rdar://problem/3760910> Request to include support for custom tag names in HTML (they already work in XML)
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.
  • khtml/editing/htmlediting.cpp: (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for per-document tags and is just better all around for things like the document. (khtml::debugNode): Ditto.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows non-HTML elements to be nested as desired.
  • khtml/html/htmlparser.h: Change forbidden tag array to be allocated in the object rather than on the heap. Also use ID_LAST_TAG for the array size; the old code used ID_CLOSE_TAG which is now a much larger number.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Remove code that creates the forbidden tag array on the heap; makes more sense to just have the array be a member so we don't have to use new and delete on it. Also needed to eliminate code that used ID_CLOSE_TAG for an array size. (KHTMLParser::~KHTMLParser): Remove code that deletes the forbidden tag array. Also changed the code that manages isindex to use deref instead of delete. (KHTMLParser::reset): Use safer sizeof for clearing the forbidden tag array. Old code had the mistake of using ID_CLOSE_TAG for the array size too. (KHTMLParser::parseToken): Removed code that checks for bogus tags; it's not clear why it was ever there and it would prevent custom tags from working. Added range check before using the forbidden tag array with the token ID since custom tags will use index values past the end of the array. (KHTMLParser::getElement): Removed most of the code that makes an element by ID; now the work is done inside the DocumentImpl createHTMLElement. Any code that needs to be different than a dynamic createElement call is still here. Last time I left out a few form element types from this switch; fixed now.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Call the tagId function in the document if getTagID fails; this creates a unique per-document ID.
  • khtml/misc/htmlhashes.h: Changed return types to unsigned short.
  • khtml/misc/htmlhashes.cpp: (khtml::getTagID): Changed return type to unsigned short. (khtml::getAttrID): Ditto.
  • khtml/misc/htmltags.c: Regenerated.
  • khtml/misc/htmltags.h: Regenerated.
  • khtml/misc/maketags: Changed the generated constants to use "const unsigned short" instead of "#define". Changed ID_CLOSE_TAG to be a fixed value of 32000 rather than being just past the IDs of the HTML tags. Also rewrote getTagName to work with the new scheme.
  • khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID. Also updated for a few tags that the parser handled but this did not.
  • kwq/KWQRenderTreeDebug.cpp: (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on the tag ID directly, which only works for standard nodes. (operator<<): Update to call getTagName. (nodePositionRelativeToRoot): Ditto. (writeSelection): Ditto.
Note: See TracTimeline for information about the timeline view.