Context Navigation

← Previous Period
Next Period →

Timeline

Apr 25, 2005:

4:35 PM Changeset in webkit [9049] by sullivan

2 edits in trunk/WebCore

Reviewed by Dave Harrison.

fixed <rdar://problem/4098731> [DOMHTMLTextAreaElement cols] returns wrong value (usually zero)

kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): use ATTR_COLS instead of ATTR_ACCESSKEY (D'oh!) (-[DOMHTMLTextAreaElement setCols:]): fixed whitespace

11:37 AM Changeset in webkit [9048]

3 copies
3 deletes in tags/JavaScriptCore-412~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~1'.

11:37 AM Changeset in webkit [9047] by vicki

2 edits in trunk/JavaScriptCore

JavaScriptCore-412.1

8:55 AM Changeset in webkit [9046] by darin

6 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work

khtml/xml/dom_docimpl.h: Add virtual functions HTMLElementNamespace and isHTMLNamespace.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Rearranged this function and fixed the following problems: 1) made sure to ref node while attributes are being set on it so it doesn't get destroyed; 2) fixed code to get namespace from the element we are importing to use the IDs from the source document, not the destination document; 3) removed unneeded getDocument() call which just returns this; 4) fixed error handling for cases where an exception happens while processing the children. (DocumentImpl::HTMLElementNamespace): Added. Returns XHTML_NAMESPACE. (DocumentImpl::isHTMLNamespace): Added. Returns true for any namespace that matches XHTML_NAMESPACE (case insensitive). (DocumentImpl::createElementNS): Changed to call isHTMLNamespace, which will cause it to accept the null namespace in an HTML document. This is the change that fixes the bug. Also fixed the code path to do a little less wasteful work in the non-XHTML case. (DocumentImpl::createHTMLElement): Pass in HTMLElementNamespace() rather than 0 to tagId. (DocumentImpl::attrId): Use isHTMLNamespace instead of allowing the null namespace explicitly. (DocumentImpl::tagId): Ditto.

khtml/html/html_documentimpl.h: Add overrides for HTMLElementNamespace and isHTMLNamespace.
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLElementNamespace): Added. Returns 0 so we use the null string for HTML elements inside HTML documents (as before). (HTMLDocumentImpl::isHTMLNamespace): Added. Allows 0, and then calls base class to check for the actual XHTML namespace. Thus, we allow both no namespace at all and the XHTML namespace inside HTML documents.

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::namespaceURI): Changed to call HTMLElementNamespace rather than checking isHTMLDocument. Same result as before, but better division of responsibilities.

8:43 AM Changeset in webkit [9045] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item

kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.

Apr 22, 2005:

5:42 PM Changeset in webkit [9044] by hyatt

2 edits
4 adds in trunk

Fix for 4096878, drop shadow effect not displayed correctly on tbray.org/ongoing/. Block minmaxwidth was
broken when negative margins were used and did not properly decrease the max width.

Reviewed by Maciej

khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcBlockMinMaxWidth):
layout-tests/fast/block/float/034-expected.txt: Added.
layout-tests/fast/block/float/034.html: Added.
layout-tests/fast/block/float/035-expected.txt: Added.
layout-tests/fast/block/float/035.html: Added.

5:08 PM Changeset in webkit [9043] by hyatt

3 edits in trunk/WebCore

Remove some dead code from css_valueimpl. It wasn't used at all.

khtml/css/css_valueimpl.cpp:
khtml/css/css_valueimpl.h:

2:53 PM Changeset in webkit [9042] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.

2:19 PM Changeset in webkit [9041] by darin

2 edits in trunk/WebCore

khtml/ecma/kjs_html.h: Removed unnecessary bogus class name qualifiers.

11:12 AM Changeset in webkit [9040] by hyatt

2 edits
3 adds in trunk

Fix for 4096681, fix regression in how the list-style property is parsed. It no longer parses when it hits
a url in the property value list now, because the list pointer did not get advanced. This fixes alistapart.com.

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
layout-tests/fast/lists/009-expected.txt: Added.
layout-tests/fast/lists/009.html: Added.
layout-tests/fast/lists/resources/listmark.gif: Added.

9:48 AM Changeset in webkit [9039] by darin

3 edits in trunk/JavaScriptCore

Reviewed by John.

fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present

kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.

kjs/grammar.cpp: Regenerated.

9:30 AM Changeset in webkit [9038] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"

khtml/ecma/kjs_window.h: Added FrameElement.
khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
khtml/ecma/kjs_window.lut.h: Regenerated.

9:29 AM Changeset in webkit [9037] by darin

3 edits in trunk/WebCore

Reviewed by John.

a small editing-related code cleanup

khtml/rendering/render_text.h: Added positionForOffset and made offsetForPosition const.
khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Made const. (InlineTextBox::positionForOffset): Added. Moved code here from caretRect. (RenderText::caretRect): Call positionForOffset instead of doing the work here.

Apr 21, 2005:

1:55 PM Changeset in webkit [9036] by hyatt

6 edits in trunk/WebCore

Fix for 4095839, wrong background image used on flechtwerk.de. Make sure that the global mapped
attribute cache hashed background attributes into per-document buckets.

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::mapToEntry):
khtml/html/html_elementimpl.h: (DOM::):
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::mapToEntry): (HTMLTablePartElementImpl::mapToEntry):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::docID):

9:07 AM Changeset in webkit [9035] by vicki

1 edit
2 adds in trunk

layout test for 4065447, outerHTML on images

layout-tests/fast/dynamic/outerHTML-img-expected.txt: Added.
layout-tests/fast/dynamic/outerHTML-img.html: Added.

9:02 AM Changeset in webkit [9034] by vicki

2 edits in trunk/WebCore

Reviewed by hyatt.

fixed <rdar://problem/4065447> support outerHTML on IMG elements

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):

Apr 20, 2005:

3:14 AM Changeset in webkit [9033] by darin

20 edits in trunk/JavaScriptCore

Reviewed by Maciej.

speedups, total 12% on JavaScript iBench

I ran the benchmark under Shark and followed its advice a lot, mainly.

kjs/collector.cpp: (KJS::Collector::allocate): Take out special case for 0; costing speed but unexercised. Use numLiveObjectsAtLastCollect instead of numAllocationsSinceLastCollect so we don't have to bump it each time we call allocate. Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset rather than a pointer so we don't need a special case for NULL. Allow freeList to point to some bogus item when the entire block is full rather than going out of our way to make it point to NULL. (KJS::Collector::markProtectedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::collect): Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset as above. Put numLiveObjects into a local variable to cut down on global variable accesses. Set numLiveObjectsAtLastCollect rather than numAllocationsSinceLastCollect. (KJS::Collector::numReferencedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::rootObjectClasses): Ditto.

kjs/internal.h: Make Value be a friend of NumberImp so it can construct number objects directly, avoiding the conversion from Number to Value.

kjs/internal.cpp: (StringImp::toObject): Don't use Object::dynamicCast, because we know the thing is an object and we don't want to do all the extra work; just cast directly.

kjs/list.cpp: (KJS::List::List): Construct valueRefCount in a way that avoids the need for a branch -- in the hot case this just meant avoiding checking a variable we just set to false.

kjs/lookup.cpp: (keysMatch): Marked this inline.

kjs/nodes.cpp: Disabled KJS_BREAKPOINT, to avoid calling hitStatement all the time. (BooleanNode::evaluate): Make a Value directly, rather than making a Boolean which is converted into a Value. (NumberNode::evaluate): Ditto. (StringNode::evaluate): Ditto. (ArrayNode::evaluate): Ditto. (FunctionCallNode::evaluate): Use new inline baseIfMutable to avoid unnecessary getBase function. Also just use a pointer for func, rather than an Object. (PostfixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (DeleteNode::evaluate): Make a Value directly. (TypeOfNode::evaluate): Use new inline baseIfMutable and make Value directly. (PrefixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (UnaryPlusNode::evaluate): Make a Value directly. (NegateNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (BitwiseNotNode::evaluate): Make a Value directly. (LogicalNotNode::evaluate): Ditto. (ShiftNode::evaluate): Don't convert to a double before making a Value. (RelationalNode::evaluate): Make a Value directly. (EqualNode::evaluate): Ditto. (BitOperNode::evaluate): Ditto. (AssignNode::evaluate): Make a Value directly. Change code so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (VarDeclNode::evaluate): Make a Value directly. (ForNode::execute): Remove unused local variable.

kjs/operations.h: (KJS::isNaN): Inlined. (KJS::isInf): Ditto. (KJS::isPosInf): Ditto. (KJS::isNegInf): Ditto.

kjs/operations.cpp: Change isNaN, isInf, isPosInf, and isNegInf to be inlines. (KJS::equal): Rewrite to avoid creating values and recursing back into the function. (KJS::relation): Rearranged code so that we don't need explicit isNaN checks. (KJS::add): Changed code to make Value directly, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (KJS::mult): Ditto.

kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::clear): Ditto. Clear value pointer in addition to key, so we can just look at the value pointer in the mark function. (KJS::PropertyMap::get): Get sizeMask and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::put): Ditto. (KJS::PropertyMap::insert): Ditto. (KJS::PropertyMap::remove): Ditto. (KJS::PropertyMap::mark): Get size and entries pointer outside loop to avoid re-getting them inside the loop. Don't bother checking key for 0, since we already have to check value for 0. (Also had to change clear() to set value to 0.) (KJS::PropertyMap::addEnumerablesToReferenceList): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Ditto. (KJS::PropertyMap::save): Ditto.

other changes

kjs/protected_values.h: Remove unneeded class name qualifiers.

kjs/reference.h: (KJS::Reference::baseIfMutable): New inline function: replaces isMutable(). (KJS::Reference::Reference): Inlined.
kjs/reference.cpp: (KJS::Reference::getValue): Rewrite to not use getBase. (KJS::Reference::putValue): Ditto. (KJS::Reference::deleteValue): Dittol

kjs/simple_number.h: (KJS::SimpleNumber::integerFits): Added. For use when the parameter is known to be integral.

kjs/string_object.cpp: (StringProtoFuncImp::call): Create the number without first converting to double in various cases that involve integers.

kjs/ustring.h: (KJS::UString::attach): Inlined. (KJS::UString::release): Inlined.
kjs/ustring.cpp: (KJS::UString::find): Get first character outside the loop instead of re-fetching it each time.

kjs/value.cpp: (Value::Value): Added overloads for all the various specific types of values, so you don't have to convert from, say, Number to Value, just to create one. (Number::Number): Added an overload that takes a boolean to indicate the number is already known to be an integer.

kjs/value.h: Added more Value constructors, added a version of toNumber that returns a boolean to indicate if the number is known to be an integer (because it was a "simple number"). (KJS::ValueImp::marked): Inlined. (KJS::ValueImp::dispatchType): Inlined. (KJS::ValueImp::dispatchToPrimitive): Inlined. (KJS::ValueImp::dispatchToBoolean): Inlined. (KJS::ValueImp::dispatchToNumber): Inlined. (KJS::ValueImp::dispatchToString): Inlined. (KJS::ValueImp::dispatchToUInt32): Inlined.

Apr 18, 2005:

6:17 PM Changeset in webkit [9032] by darin

2 edits in trunk/WebKit

Reviewed by Hyatt.

fixed <rdar://problem/4092614> REGRESSION (Tiger): progressively loaded background images "scroll around" instead of just appearing

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]): Moved a global inside this function, since it's only used here. (-[WebImageData _cacheImages:allImages:]): Fixed a sizeof that was getting the size of the wrong thing. (-[WebImageData _isSizeAvailable]): Used calloc in a more consistent way. (drawPattern): Removed an unneeded cast. (-[WebImageData tileInRect:fromPoint:context:]): Here's the actual bug fix. Don't use the image size when deciding whether the image needs to be tiled as a pattern nor when creating the pattern: in both cases, use the tile size. The old way was wrong, and the new way works perfectly. Also removed uneeded error message when the image is not yet loaded enough to create a CGImageRef for it -- it's fine to draw nothing in that case.

3:36 PM Changeset in webkit [9031] by sullivan

7 edits in branches/experimental-ui-branch

WebCore:

WebCore support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).

Reviewed by Maciej.

kwq/WebCoreBridge.h: add textDidChange: method

kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): call through to bridge

WebKit:

WebKit support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).

Reviewed by Maciej.

WebView.subproj/WebFormDelegate.h:
WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textDidChange:inFrame:]): new form delegate method

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textDidChange:]): new method, calls through to form delegate

WebBrowser:

Made form-text-changed confirmation work for textareas as well as textfields.

Reviewed by Maciej.

BrowserWebController.m: (-[FormDelegate textDidChange:inFrame:]): implement this new FormDelegate method to set the dirty bit

Confirmation sheet notes.html: updated

1:57 PM Changeset in webkit [9030] by hyatt

2 edits in trunk/WebCore

Fix min-height so that when it resolves to auto it does not use the box's intrinsic height.

khtml/rendering/render_box.cpp: (RenderBox::calcHeight): (RenderBox::calcHeightUsing):

1:56 PM Changeset in webkit [9029] by hyatt

1 edit in trunk/LayoutTests/fast/table/border-collapsing/003-expected.txt

Fix layout test.

11:12 AM Changeset in webkit [9028] by hyatt

2 edits in trunk/WebCore

Back out fix for 4032346, since it is causing garbled image content on many sites.

The bug tracking the fix is 4069093.

(khtml::RenderBlock::matchedEndLine):

4:07 AM Changeset in webkit [9027] by hyatt

4 edits in trunk/WebCore

Fix the smile in the Acid2 test. Floats should not grow to contain other floats unless height is auto. Otherwise
the float should use the specified height.

Also fix row 14 of the Acid2 test. Although ambiguous, just modify the table cell baseline alignment code to align
to the bottom of the cell's content height if no suitable baseline could be found.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox):
khtml/rendering/render_table.cpp: (RenderTableSection::calcRowHeight): (RenderTableCell::baselinePosition):

Apr 15, 2005:

5:18 PM Changeset in webkit [9026]

10 copies
2 deletes in tags/WebCore-315~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~1'.

5:18 PM Changeset in webkit [9025] by adele

2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Chancery Seed (WebCore-315.1)

5:14 PM Changeset in webkit [9024] by adele

8 edits in branches/Safari-1-3-branch/WebCore

Merged elementFromPoint fix from TOT for Chancery Seed.

2005-04-12 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function

khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
khtml/dom/dom_doc.h:
khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
khtml/xml/dom_docimpl.h:

5:14 PM Changeset in webkit [9023]

3 copies in branches/Safari-1-3-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-3-branch'.

3:00 PM Changeset in webkit [9022] by hyatt

2 edits in trunk/WebCore

Make sure empty tables honor CSS-specified heights when they have no rows or sections. This is done only
in strict mode, since it is not compatible with WinIE.

khtml/rendering/render_table.cpp: (RenderTable::layout):

2:45 PM Changeset in webkit [9021] by hyatt

20 edits in trunk/LayoutTests

Update layout tests for Tiger.

1:36 PM Changeset in webkit [9020] by hyatt

2 edits in trunk/WebCore

Fix for row 13 of the Acid2 test. Change HTML comment parsing in strict mode to do proper SGML parsing,
checking for pairs of -- and only being willing to close the comment if every -- is paired up.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):

9:45 AM Changeset in webkit [9019] by mjs

4 edits in trunk/WebCore

Reviewed by Richard.

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

khtml/ecma/kjs_binding.cpp: (UString::UString):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):

3:53 AM Changeset in webkit [9018] by hyatt

2 edits in trunk/WebCore

Fix the six pixel gap between rows nine and ten of the Acid2 test. Make sure that percentage heights that
resolve to auto are properly treated as though they have auto height by the self-collapsing block check (as per
section 8.3.1, paragraph 7 of the CSS2.1 spec).

khtml/rendering/render_block.cpp: (khtml::RenderBlock::isSelfCollapsingBlock):

3:51 AM Changeset in webkit [9017] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Fix a mistake in render_box.cpp.

3:05 AM Changeset in webkit [9016] by hyatt

1 edit in trunk/WebCore/khtml/khtmlview.cpp

Add bulletproof null check to previous check-in

2:52 AM Changeset in webkit [9015] by hyatt

4 edits in trunk/WebCore

The Acid2 test and the reference rendering both make use of overflow:hidden on the <html> element. Turns out
the CSS2.1 wording for this behavior has been revised (based off WinIE/Mozilla behavior). Change our behavior
to match and make <html> overflow apply to the viewport.

khtml/khtmlview.cpp: (KHTMLView::applyOverflowToViewport): (KHTMLView::layout):
khtml/khtmlview.h:
khtml/rendering/render_box.cpp: (RenderBox::setStyle):

Apr 14, 2005:

6:30 PM Changeset in webkit [9014] by mjs

2 edits in trunk/JavaScriptCore

make fast_malloc.h a private header, not project

JavaScriptCore.pbproj/project.pbxproj:

6:26 PM Changeset in webkit [9013]

5 copies in branches/gcc-4-0-branch

This commit was manufactured by cvs2svn to create branch
'gcc-4-0-branch'.

6:26 PM Changeset in webkit [9012]

5 copies in tags/gcc-4-0-anchor

This commit was manufactured by cvs2svn to create tag
'gcc-4-0-anchor'.

6:26 PM Changeset in webkit [9011]

5 copies in branches/Pan-2005-007-branch

This commit was manufactured by cvs2svn to create branch
'Pan-2005-007-branch'.

6:26 PM Changeset in webkit [9010]

5 copies in tags/Pan-2005-007-anchor

This commit was manufactured by cvs2svn to create tag
'Pan-2005-007-anchor'.

6:26 PM Changeset in webkit [9009] by mjs

9 edits
2 adds in trunk/JavaScriptCore

Reviewed by Richard.

<rdar://problem/4089734> JavaScript iBench can be sped up ~10% with custom allocator

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

JavaScriptCore.pbproj/project.pbxproj:
kjs/collector.cpp: (KJS::Collector::allocate): Use dlmalloc to allocate the collector blocks. (KJS::Collector::collect): And dlfree to free it.
kjs/fast_malloc.cpp: Added, just the standard dlmalloc here.
kjs/fast_malloc.h: Added. Declarations for the functions. Also added a handy macro to give a class custom operator new/delete
kjs/identifier.cpp: (KJS::Identifier::add): Use dlmalloc/dlfree.
kjs/nodes.h: make nodes KJS_FAST_ALLOCATED.
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Use dlmalloc/dlfree. (KJS::PropertyMap::rehash): ditto
kjs/scope_chain.h:
kjs/ustring.cpp: (KJS::UString::Rep::createCopying): New named constructor that copies a passed-in buffer, to hide allocation details from webcore. (KJS::UString::UString): use createCopying when appropriate. (KJS::UString::Rep::destroy): Use dlmalloc/dlfree. (KJS::UString::expandedSize): likewise (KJS::UString::expandCapacity): likewise (KJS::UString::expandPreCapacity): likewise (KJS::UString::spliceSubstringsWithSeparators): likewise (KJS::UString::append): likewise (KJS::UString::operator=): likewise (KJS::UString::detach): likewise
kjs/ustring.h: make UString and UString::Rep KJS_FAST_ALLOCATED.

11:33 AM Changeset in webkit [9008]

1 copy in branches/experimental-db

This commit was manufactured by cvs2svn to create branch
'experimental-db'.

11:33 AM Changeset in webkit [9007] by hyatt

3 edits in trunk/WebCore

3258403 and 3258402 can now be fixed. min/max-width/height support is now complete. This patch makes them
work for positioned elements and enables us to pass row one of the Acid2 test.

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
khtml/rendering/render_box.h:

10:19 AM Changeset in webkit [9006] by sullivan

3 edits in trunk/WebKit

Reviewed by Chris.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Beefed up assertion that's been bugging me and Chris to include the two troublemaking values.

Apr 12, 2005:

3:49 PM Changeset in webkit [9005] by hyatt

6 edits in trunk/WebCore

Working on the Acid2 test, Row 1.

Improve checkChild for the DTD so that it knows what mode a document is in. This allows it to adhere more
strictly to the actual DTD in strict mode and almost strict mode.

Change the <table>-inside-<p> check so that <table> is disallowed inside <p> in
strict mode and almost strict mode. This matches Firefox behavior, which allows <table>
inside <p> only in quirks mode.

khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/dtd.h:
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
khtml/xml/dom_elementimpl.cpp: (ElementImpl::childAllowed):

3:37 PM Changeset in webkit [9004] by vicki

8 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function

khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
khtml/dom/dom_doc.h:
khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
khtml/xml/dom_docimpl.h:

3:18 PM Changeset in webkit [9003] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/4086819> Avoid using protect count hash table so much for 5.6% JS iBench speedup

Avoid using protected values hash for the two most common cases
Bump up ListImp high water mark, new testing shows 508 ListImps are created during JS iBench.

Net result is a 5.6% speedup on JavaScript iBench

kjs/collector.cpp: (KJS::Collector::collect): mark protected lists as appropriate.
kjs/context.h:
kjs/list.cpp: (KJS::ListImp::markValues): Moved implementation from List::markValues (KJS::List::markProtectedLists): Implemented - scan pool and overflow list. (KJS::allocateListImp): link lists outside the pool into a separate doubly linked list to be able to mark protected lists (KJS::deallocateListImp): do the corresponding delinking (KJS::List::derefValues): do nothing in conservative GC mode (KJS::List::refValues): do nothing in conservative GC mode (KJS::List::markValues): call ListImp version (KJS::List::append):
kjs/list.h:

3:11 PM Changeset in webkit [9002] by hyatt

3 edits in trunk/WebCore

Beginning of work to support the Acid2 CSS test put forward by the Web Standards Project. Fix
our handling of the rel attribute on <link> elements to do a proper tokenization so that stylesheets
can be recognized even when other keywords are present in the rel attribute.

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseHTMLAttribute): (HTMLLinkElementImpl::tokenizeRelAttribute): (HTMLLinkElementImpl::process):
khtml/html/html_headimpl.h:

8:56 AM Changeset in webkit [9001] by sullivan

1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

Left out an #import in previous checkin.

8:53 AM Changeset in webkit [9000] by sullivan

2 edits in trunk/WebCore

fixed these two bugs (I also fixed these on the experimental-ui-branch) <rdar://problem/3154293> Find Next should not scroll page if the next target is already visible <rdar://problem/3121828> scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Reviewed by Chris.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Trey had written code to address these issues, but left it commented out due to other problems. The other problems no longer occur, so I uncommented Trey's code, and then discovered that I could make it behave more like TextEdit with many fewer lines of code.

8:43 AM Changeset in webkit [8999] by sullivan

2 edits in branches/experimental-ui-branch/WebCore

fixed these two bugs (this is on the branch; I need to roll these into TOT also): <rdar://problem/3154293> Find Next should not scroll page if the next target is already visible <rdar://problem/3121828> scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Reviewed by Chris.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Trey had written code to address these issues, but left it commented out due to other problems. The other problems no longer occur, so I uncommented Trey's code, and then discovered that I could make it behave more like TextEdit with many fewer lines of code.

Apr 11, 2005:

9:07 AM Changeset in webkit [8998] by sullivan

2 edits in branches/experimental-ui-branch/WebKit

Fixed inability to wrap around in Find in Page

WebView.subproj/WebView.m: (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): changed wrapFlag from NO to YES on two lines (copy/paste error)

Apr 8, 2005:

5:05 PM Changeset in webkit [8997] by harrison

2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4084106> Remove NSAccessibilityForegroundColorTextAttributeWrapper

kwq/KWQAccObject.mm: (AXAttributeStringSetStyle): Use NSAccessibilityForegroundColorTextAttribute directly.

Apr 7, 2005:

5:02 PM Changeset in webkit [8996] by sullivan

8 edits in branches/experimental-ui-branch

WebCore:

WebCore support for find-as-you-type; needed an additional parameter
to findString and searchFor:...

Reviewed by Dave Hyatt.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): new findInSelection parameter; if true, start from the beginning of the selection when searching forward, or the end of the selection when searching backward

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:findInSelection:]): new findInSelection parameter; passed through to findString

WebKit:

WebKit support for find-as-you-type. Needed an additional parameter on
a method from WebDocumentSearching protocol. Since that's a public protocol,
I couldn't just add the parameter. For now I hacked it with an undeclared
internal method that's discovered via respondsToSelector. Probably the right
long-term approach is to deprecate the WebDocumentSearching protocol and introduce
a replacement that has a more flexible set of parameters for possible future
expansion.

Reviewed by Dave Hyatt.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through to bridge

WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through

WebBrowser:

Fixed problem where each letter typed in find-as-you-type would jump to
the next instance of the text to find, instead of extending the selection
when appropriate.

Reviewed by Dave Hyatt.

FindBanner.m: (-[FindBanner _doSearchForString:direction:caseSensitive:findInSelection:inTarget:]): added findInSelection parameter, passes through to WebKit (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): added findInSelection parameter, passes through to _doSearchForString: (-[FindBanner findFromSearchField:]): pass YES for findInSelection parameter (-[FindBanner findNext:]): pass NO for findInSelection parameter (-[FindBanner findPrevious:]): pass NO for findInSelection parameter

11:33 AM Changeset in webkit [8995] by sullivan

4 edits in branches/experimental-ui-branch/WebKit

WebKit:

WebKit support to allow clients to control whether the selection is still
drawn when the first responder is elsewhere. Formerly this was hardwired
to be true only when -[WebView isEditable] was true.

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): check [WebView maintainsInactiveSelection] rather than just [WebView isEditable]

WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebView.m: (-[WebView maintainsInactiveSelection]): new method for clients to override, returns -[self isEditable]

WebBrowser:

First draft at search-as-you-type using the Find banner. There are some
obvious flaws, perhaps the most obvious being that adding a letter will start
the new search from the end of the current selection. But it works well enough
to start seeing the flaws, so that's a good thing.

Reviewed by Darin.

BrowserDocument.h: declare findNext: and findPrevious: methods
BrowserDocument.m: (-[BrowserDocument findNext:]): call through to FindBanner (or AppController if the pref is set to not use banner) (-[BrowserDocument findPrevious:]): ditto (-[BrowserDocument validateUserInterfaceItem:]): findNext: and findPrevious: are enabled if the Find banner returns YES for readyToFind

BrowserWebController.h: the findInPageBanner is now declared as a FindBanner*
BrowserWebController.m: (-[BrowserWebView findInPageBanner]): now returns a FindBanner* rather than just a WebPageBanner* (-[BrowserWebView maintainsInactiveSelection]): override this new WebView method to return YES if the first responder is in a banner on the page.

English.lproj/FindBanner.nib: Turn off the "sendsWholeSearchString" bit so the searching is as-you-type

English.lproj/MainMenu.nib: make "Find Again" and "Find Previous" target the first responder rather than the AppController, so BrowserDocument can intercept them.

FindBanner.h: made -readyToFind public so it can be used in -[BrowserDocument validateUserInterfaceItem:]
FindBanner.m: (-[FindBanner _findWithDirection:caseSensitive:]): remove the #if guards around the code that forces the first responder to stay in the textfield as you type.

Apr 5, 2005:

4:41 PM Changeset in webkit [8994] by hyatt

3 edits in trunk/WebCore

Fix for 4077106, make sure that mouse wheeling in overflow sections uses 40 rather than 10 as the base line
step.

Reviewed by darin

khtml/rendering/render_layer.cpp: (RenderLayer::positionScrollbars):
kwq/KWQScrollBar.mm: (QScrollBar::scroll):

4:38 PM Changeset in webkit [8993] by hyatt

2 edits in trunk/WebKit

Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.

Reviewed by darin

WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):

Apr 4, 2005:

11:01 PM Changeset in webkit [8992] by vicki

8 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3871669> no focus or blur methods on HTML button elements

khtml/dom/html_form.cpp: (HTMLButtonElement::focus): (HTMLButtonElement::blur):
khtml/dom/html_form.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
khtml/ecma/kjs_html.lut.h: (KJS::):
khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::blur): (DOM::HTMLButtonElementImpl::focus):
khtml/html/html_formimpl.h:

Apr 1, 2005:

12:42 PM Changeset in webkit [8991]

1 copy
3 deletes in tags/WebKit-312~1

This commit was manufactured by cvs2svn to create tag 'WebKit-312~1'.

12:42 PM Changeset in webkit [8990] by vicki

2 edits in trunk/WebKit

WebKit-312.1 stamp for <rdar://problem/4070729>

Mar 31, 2005:

5:07 PM Changeset in webkit [8989] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/4070729> REGRESSION (125-311, Panther-only?): Safari crashes while reloading "My eBay" page

Reviewed by rjw.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resourceData]): retain and autorelease resourceData since releaseResources (which releases resourceData) may be called before the caller of this method has an opporuntity to retain the returned data