Timeline
May 26, 2005:
- 6:17 PM Changeset in webkit [9222] by
-
- 2 edits2 adds in trunk
Reviewed by me, patch by Mitz Pettel.
- fixed <rdar://problem/4106907> bidi algorithm bug fixed for KHTML should be fixed in WebCore too
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Integrated the patch that Mitz did for the KDE bug, details at <http://www.mitzpettel.com/software/WebCorePatch2.html>.
Test cases added:
- layout-tests/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
- layout-tests/fast/text/international/bidi-neutral-directionality-paragraph-start.html: Added.
- 5:03 PM Changeset in webkit [9221] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fix build failure from when I removed WebCoreUnicode
- WebCoreSupport.subproj/WebTextRenderer.m: Removed import of WebUnicode.h that I missed. (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Switch from our own macros to the ICU macros for surrogate pairs. (widthForNextCharacter): Ditto.
- 3:48 PM Changeset in webkit [9220] by
-
- 2 edits in trunk/WebKit
<rdar://problem/4120518> Mail: control-T in an empty message crashes mail
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issueTransposeCommand]): New, to support transpose in JS.
- 3:15 PM Changeset in webkit [9219] by
-
- 10 edits6 deletes in trunk
top level:
Reviewed by Richard and Dave Harrison.
- configure.in: Turn off exceptions and RTTI for C++ test programs. This makes them work with WebCore, which now has them off, under gcc 4.0.
Tests:
Reviewed by Richard and Dave Harrison.
- qt/Makefile.am: Add -licucore so we can continue to compile with the changed QChar.
WebCore:
Reviewed by Richard and Dave Harrison.
No new test cases needed for this change.
- eliminate WebCoreUnicode and use ICU directly instead
- fixed compiling with gcc 4.0 (was broken for Development only)
- WebCore.exp: Removed the WebCoreXXXFunction exports.
- WebCore-tests.exp: Removed some QChar functions that are now inlines. Removed some typeinfo exports that are no longer appropriate since we use -fno-rtti.
- kwq/KWQString.h: (QChar::isDigit): Changed to call u_isdigit when non-ASCII. We should probably phase this out since it's only used in places where we don't want to handle non-ASCII decimal digits. (QChar::isLetter): Changed to call u_isalpha when non-ASCII. (QChar::isNumber): Changed to call u_isdigit when non-ASCII. This probably should be removed, since we always want to call isDigit instead. (QChar::isLetterOrNumber): Changed to call u_isalnum when non-ASCII. (QChar::isPunct): Changed to call u_ispunct when non-ASCII. (QChar::digitValue): Changed to call u_charDigitValue when not '0'-'9'. We should probably phase this out since it's only used in places where we don't want to handle non-ASCII decimal digits. (QChar::lower): Changed to call u_tolower when non-ASCII. (QChar::upper): Changed to call u_toupper when non-ASCII. (QChar::direction): Made inline. Calls u_charDirection. (QChar::mirrored): Made inline. Calls u_isMirrored. (QChar::mirroredChar): Made inline. Calls u_charMirror.
- kwq/KWQChar.mm: Removed.
- kwq/WebCoreUnicode.cpp: Removed.
- kwq/WebCoreUnicode.h: Removed.
- WebCore.pbproj/project.pbxproj: Removed files.
WebKit:
Reviewed by Richard and Dave Harrison.
- eliminate WebCoreUnicode and use ICU directly instead
- Misc.subproj/WebKitNSStringExtras.m: (canUseFastRenderer): Use u_charDirection directly.
- WebCoreSupport.subproj/WebTextRenderer.m: Removed import of <WebCore/WebCoreUnicode.h>.
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): Removed call to WebKitInitializeUnicode.
- Misc.subproj/WebUnicode.h: Removed.
- Misc.subproj/WebUnicode.m: Removed.
- Misc.subproj/WebUnicodeTables.m: Removed.
- WebKit.pbproj/project.pbxproj: Removed files.
- 1:32 PM Changeset in webkit [9218] by
-
- 1 edit in trunk/WebCore/khtml/khtml_part.h
Missed this in previous commit.
- 1:30 PM Changeset in webkit [9217] by
-
- 10 edits2 adds in trunk
Reviewed by John.
<rdar://problem/4120518> Mail: control-T in an empty message crashes mail
- kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeOfCharactersAroundCaret]): Nil-check result of VisiblePosition previous() and next().
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::VisiblePosition::previousVisiblePosition): Make sure previous() does not return the original position. Also, simplified. Commented odd, but required, behavior in previousVisiblePosition().
- khtml/editing/visible_units.cpp: (khtml::startOfEditableContent): (khtml::endOfEditableContent): Removed redundant check for isEditableContent().
- khtml/editing/jsediting.cpp:
- khtml/khtml_part.cpp: (KHTMLPart::transpose):
- khtml/khtml_part.h:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issueTransposeCommand):
- layout-tests/editing/editing.js:
- kwq/WebCoreBridge.h: Add support for transpose command in JavaScript and therefore layout tests.
- layout-tests/editing/deleting/transpose-empty-expected.txt: Added.
- layout-tests/editing/deleting/transpose-empty.html: Added. New test for this bug.
- 1:26 PM Changeset in webkit [9216] by
-
- 2 edits in branches/Safari-2-0-branch/JavaScriptCore
Merged fix for <rdar://problem/4086570> from TOTO to SUTiCambridge.
2005-05-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/4086570> Crash in JavaScriptCore with RSS Visualizer
- kjs/internal.cpp: (InterpreterImp::mark): mark staticNaN, it is usually protected by the Number prototype but there is a small window where it can get collected.
- 11:31 AM Changeset in webkit [9215]
-
- 9 copies3 deletes in tags/JavaScriptCore-412~2
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~2'.
- 11:31 AM Changeset in webkit [9214] by
-
- 2 edits in branches/Safari-2-0-branch/JavaScriptCore
Versioning for SUTiCambridge - JavaScriptCore-412.2
(JavaScriptCore-412.1 is already in use in TOT)
May 24, 2005:
- 6:33 PM Changeset in webkit [9213] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/4127061> <canvas> backing store should be zero filled
Use calloc instead of malloc to ensure zero filled backing store.
Reviewed by Darin.
- khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):
- 6:28 PM Changeset in webkit [9212] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/4097289> -[WebView elementAtPoint:] failing when WebView is nested and offset
Code to determine the correct frame under the window point was
converting the point incorrectly.
Reviewed by Chris.
- WebView.subproj/WebView.m: (-[WebView _frameViewAtWindowPoint:]):
- 5:06 PM Changeset in webkit [9211] by
-
- 52 edits in branches/gcc-4-0-branch
Rolled in changes to compile with gcc 4.0 from TOT.
2005-05-16 Darin Adler <Darin Adler>
Reviewed by Adele.
- fixed issues preventing us from compiling with newer versions of gcc 4.0
- kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.
2005-05-04 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
- another gcc-4.0-related fix
- bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.
2005-04-28 Darin Adler <Darin Adler>
Reviewed by Dave Harrison.
- fixed problems preventing us from compiling with gcc 4.0
- JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
- bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
- bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
- kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
- kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
- kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
- kjs/string_object.cpp: (replace): Ditto.
WebCore:
Rolled in changes to compile with gcc 4.0 from TOT.
2005-05-16 Darin Adler <Darin Adler>
Reviewed by Adele.
- fixed issues preventing us from compiling with newer versions of gcc 4.0
- khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
- khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
- khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
- khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
- khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
- khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
- khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
- khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
- khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
- kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.
2005-04-28 Darin Adler <Darin Adler>
Reviewed by Dave Harrison.
- fixed problems preventing us from compiling with gcc 4.0
- WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
- khtml/css/parser.cpp: Regenerated.
- khtml/css/parser.h: Regenerated.
- khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
- khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
- khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
- khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
- kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
- kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
- kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
- kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
- kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- WebCore-combined.exp: Regenerated.
- WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.
WebKit:
Rolled in changes to compile with gcc 4.0 from TOT.
2005-04-28 Darin Adler <Darin Adler>
Reviewed by Maciej.
- fixed problems preventing us from compiling with gcc 4.0
- WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
- WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
- WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.
WebBrowser:
Rolled in changes to compile with gcc 4.0 from TOT.
2005-04-28 Darin Adler <Darin Adler>
Reviewed by Maciej.
- fixed problems preventing us from compiling with gcc 4.0
- AccessibilityButtonInfo.m: (+[AccessibilityButtonInfo infoWithParent:identifier:]): Fixed return type to match declaration.
- AppController.m: Added forward declaration of "struct mach_header".
- BrowserNSDataExtras.m: (-[NSData indexOfCString:startOffset:]): Added a cast to convert a char * to a UInt8 *.
- BrowserNSStringExtras.m: (-[NSString encodeStringBase64]): Ditto.
- BrowserNSWorkspaceExtras.m: (-[NSWorkspace noteDirectoryContentsChangedAtPath:]): Ditto.
- BrowserWebController.m: (-[BrowserWebView setSheetRequest:]): Fixed parameter type to match declaration.
- HTMLSourceController.m: (-[HTMLSourceController rangeForLine:]): Changed from int to unsigned.
- InternetConfigUtilities.m: (setDownloadPath): Added a cast to convert a char * to a UInt8 *. (downloadPathForICInstance): Same thing, in the other direction.
- LocationChangeHandler.m: (-[Logger initWithWebView:]): Fixed parameter type to match declaration.
- MenuIconRefFactory.m: (_NSAddQuickDrawIconFamilyColorElement): Added a cast to convert a UInt8 * to a char *. (_NSAddQuickDrawIconFamilyMaskElement): Ditto.
- NetworkController.m: (+[NetworkController sharedInstance]): Fixed return type to match declaration.
- Preferences.subproj/AdvancedPreferences.m: (systemIsInFullKeyboardAccessMode): Fix a BOOL that should have been a Boolean.
- WebBrowserPrefix.h: Use <malloc/malloc.h> rather than <obc/malloc.h>.
- Test/PageLoadTestRunner.m: Ditto.
- 4:49 PM Changeset in webkit [9210] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fixed these bugs: <rdar://problem/4118510> Textareas with a vertical scroll bar should have their resize corner under the scroll bar <rdar://problem/4118523> Resize image in textareas is drawn repeatedly when scrolling vertically with scrollbar
Test cases added: none; doesn't affect page layout
- kwq/KWQTextArea.h: added inInitWithFrame ivar
- kwq/KWQTextArea.mm: (+[KWQTextArea _resizeCornerImage]): moved here from KWQTextAreaTextView; now it's a class method so we only look up the image once. (-[KWQTextArea initWithFrame:]): set and clear inInitWithFrame ivar, used by -tile (-[KWQTextArea _isResizableByUser]): renamed with an underscore for consistency (-[KWQTextArea _textViewShouldHandleResizing]): new method, returns YES if the textarea is user-resizable and the enclosed textview is responsible for drawing and tracking the resize corner. (-[KWQTextArea tile]): shrink the vertical scroller if appropriate to account for the resize corner (-[KWQTextArea _resizeCornerRect]): new method, returns the bottom-right corner rect, where the resize image goes (-[KWQTextArea _trackResizeFromMouseDown:]): moved here from KWQTextAreaTextView. The only changes were to move the [NSCursor set] call inside here (was in the caller), and to use self where it was using [self _enclosingTextArea], and to move a comment in here that was in the caller (-[KWQTextArea mouseDown:]): track resizing if appropriate (-[KWQTextArea drawRect:]): draw the resize corner if appropriate (-[KWQTextAreaTextView _resizeCornerRect]): get the resize image from KWQTextArea (-[KWQTextAreaTextView resetCursorRects]): check _textViewShouldHandleResizing (-[KWQTextAreaTextView drawRect:]): ditto (-[KWQTextAreaTextView mouseDown:]): ditto; also, make the textarea handle the resize tracking now
- 3:46 PM Changeset in webkit [9209]
-
- 11 copies3 deletes in tags/WebKit-412~2
This commit was manufactured by cvs2svn to create tag 'WebKit-412~2'.
- 3:46 PM Changeset in webkit [9208] by
-
- 2 edits in branches/Safari-2-0-branch/WebKit
Versioning for SUTiCambridge - WebKit-412.2
- 3:37 PM Changeset in webkit [9207]
-
- 48 copies2 deletes in tags/WebCore-415~6
This commit was manufactured by cvs2svn to create tag
'WebCore-415~6'.
- 3:37 PM Changeset in webkit [9206] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiCambridge - WebCore-415.6
- 3:31 PM Changeset in webkit [9205] by
-
- 2 edits in branches/Safari-2-0-branch/JavaScriptCore
Versioning for SutiCambridge - JavaScriptCore-412.1
- 3:08 PM Changeset in webkit [9204] by
-
- 5 edits in branches/Safari-2-0-branch
WebCore:
Merged fix for <rdar://problem/3598589> from TOT for SUTiCambridge
2005-05-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by John.
- fixed <rdar://problem/3598589> onunload handler doesn't fire when a window is closed
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Don't remove all event handlers from the document here...
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): ...instead do it here, after firing the unload event, but only if the document is not in the back/forward cache...
- kwq/KWQPageState.mm: (-[KWQPageState finalize]): ...and take care of the back/forward cache case here.
WebKit:
Merged fix for 4077106 from TOT to SUTiCambridge
2005-04-05 David Hyatt <hyatt@apple.com>
Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.
Reviewed by darin
- WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):
- 2:25 PM Changeset in webkit [9203] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Added a missing bug number.
- 2:16 PM Changeset in webkit [9202] by
-
- 2 edits in trunk/WebCore
- another gcc 4.0 fix
No new test cases needed.
- khtml/dom/dom2_events.cpp: Moved constants out of the KHTML_NO_CPLUSPLUS_DOM #if.
- 2:16 PM Changeset in webkit [9201] by
-
- 2 edits in trunk/WebCore
Reviewed by Vicki.
- WebCore.exp: Added exports for many classes in the public DOM headers that were omitted before. Also removed one symbol that was listed twice.
- 10:44 AM Changeset in webkit [9200] by
-
- 4 edits2 adds in trunk
Reviewed by John.
- fixed <rdar://problem/3598589> onunload handler doesn't fire when a window is closed
Test cases added:
- layout-tests/fast/events/onunload-expected.txt: Added.
- layout-tests/fast/events/onunload.html: Added.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Don't remove all event handlers from the document here...
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): ...instead do it here, after firing the unload event, but only if the document is not in the back/forward cache...
- kwq/KWQPageState.mm: (-[KWQPageState finalize]): ...and take care of the back/forward cache case here.
- 10:37 AM Changeset in webkit [9199] by
-
- 1 add in trunk/WebCore/khtml/editing/split_text_node_containing_element.cpp
Added missing file.
- 10:20 AM Changeset in webkit [9198] by
-
- 12 edits in trunk
WebCore:
Reviewed by Kevin.
- WebCore part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable
- kwq/KWQKHTMLSettings.h: (KHTMLSettings::textAreasAreResizable): new getter (KHTMLSettings::setTextAreasAreResizable): new setter
- kwq/KWQTextArea.h:
- kwq/KWQTextArea.mm: eliminated ALLOW_RESIZING_TEXT_AREAS #define in favor of using runtime setting (-[KWQTextArea isResizableByUser]): get value from settings, and cache it in KWQTextArea instance (-[KWQTextAreaTextView _enclosingTextArea]): new convenience method, extracted from _trackResizeFromMouseDown: (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): now uses extracted method
(-[KWQTextAreaTextView drawRect:]):
now checks isResizableByUser
(-[KWQTextAreaTextView mouseDown:]):
ditto
- kwq/WebCoreSettings.h:
- kwq/WebCoreSettings.mm: (-[WebCoreSettings setTextAreasAreResizable:]): new setter (-[WebCoreSettings textAreasAreResizable]): new getter
WebKit:
Reviewed by Kevin.
- WebKit part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable
- WebView.subproj/WebPreferencesPrivate.h: added private-for-now getter and setter for new preference
- WebView.subproj/WebPreferenceKeysPrivate.h: added private preference key controlling whether textareas are resizable
- WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initial value of new preference is NO, so other clients' behavior doesn't change (-[WebPreferences textAreasAreResizable]): new getter (-[WebPreferences setTextAreasAreResizable:]): new setter
- WebView.subproj/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): update this new setting in WebCore
- English.lproj/StringsNotToBeLocalized.txt: updated for these changes
WebBrowser:
Reviewed by Kevin.
- added debug menu item to toggle resizable textareas
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add "Allow Resizing Text Areas" item and separator (-[BrowserDocument toggleAllowResizingTextAreas:]): toggle WebPreferences setting (-[BrowserDocument validate_toggleAllowResizingTextAreas:]): sync checkmark with setting
- 10:06 AM Changeset in webkit [9197] by
-
- 15 edits in branches/Safari-2-0-branch
Merged addition fix for <rdar://problem/4058167> from TOT to SUTiCambridge
2005-05-18 Darin Adler <Darin Adler>
Reviewed by Maciej.
- fix a failure seen in the Mozilla JavaScript tests where a live object was garbage-collected when the only reference to it was in an argList on the stack
- kjs/list.h: Moved the operator= function into the .cpp file since it's too big to be a good choice to inline.
- kjs/list.cpp: (KJS::List::operator=): Moved this formerly-inline function into a separate file and added missing code to update valueRefCount. It's the latter that fixes the bug.
WebCore:
Merged fix for <rdar://problem/4058167> from TOT to SUTiCambridge
2005-05-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively
Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
- khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
- khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
- khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
- khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
- khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
- khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
- khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
- khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
- 12:21 AM Changeset in webkit [9196] by
-
- 8 edits37 adds in trunk/WebCore
Reviewed by John.
- split remaining editing command classes out of htmlediting.cpp
- rename InsertParagraphSeparatorInQuotedContentCommand to BreakBlockquoteCommand
No layout tests needed - this is a pure refactoring change.
- WebCore.pbproj/project.pbxproj:
- khtml/editing/apply_style_command.cpp:
- khtml/editing/break_blockquote_command.cpp: Added.
- khtml/editing/break_blockquote_command.h: Added.
- khtml/editing/composite_edit_command.cpp:
- khtml/editing/delete_selection_command.cpp:
- khtml/editing/edit_command.cpp:
- khtml/editing/htmlediting.cpp:
- khtml/editing/htmlediting.h:
- khtml/editing/insert_line_break_command.cpp: Added.
- khtml/editing/insert_line_break_command.h: Added.
- khtml/editing/insert_paragraph_separator_command.cpp: Added.
- khtml/editing/insert_paragraph_separator_command.h: Added.
- khtml/editing/insert_text_command.cpp: Added.
- khtml/editing/insert_text_command.h: Added.
- khtml/editing/join_text_nodes_command.cpp: Added.
- khtml/editing/join_text_nodes_command.h: Added.
- khtml/editing/merge_identical_elements_command.cpp: Added.
- khtml/editing/merge_identical_elements_command.h: Added.
- khtml/editing/move_selection_command.cpp: Added.
- khtml/editing/move_selection_command.h: Added.
- khtml/editing/rebalance_whitespace_command.cpp: Added.
- khtml/editing/rebalance_whitespace_command.h: Added.
- khtml/editing/remove_css_property_command.cpp: Added.
- khtml/editing/remove_css_property_command.h: Added.
- khtml/editing/remove_node_attribute_command.cpp: Added.
- khtml/editing/remove_node_attribute_command.h: Added.
- khtml/editing/remove_node_command.cpp: Added.
- khtml/editing/remove_node_command.h: Added.
- khtml/editing/remove_node_preserving_children_command.cpp: Added.
- khtml/editing/remove_node_preserving_children_command.h: Added.
- khtml/editing/replace_selection_command.cpp: Added.
- khtml/editing/replace_selection_command.h: Added.
- khtml/editing/set_node_attribute_command.cpp: Added.
- khtml/editing/set_node_attribute_command.h: Added.
- khtml/editing/split_element_command.cpp: Added.
- khtml/editing/split_element_command.h: Added.
- khtml/editing/split_text_node_command.cpp: Added.
- khtml/editing/split_text_node_command.h: Added.
- khtml/editing/split_text_node_containing_element_command.h: Added.
- khtml/editing/typing_command.cpp: Added.
- khtml/editing/typing_command.h: Added.
- khtml/editing/wrap_contents_in_dummy_span_command.cpp: Added.
- khtml/editing/wrap_contents_in_dummy_span_command.h: Added.
May 23, 2005:
- 6:38 PM Changeset in webkit [9195] by
-
- 5 edits in branches/Safari-2-0-branch
WebCore:
Merged fix for 4077106 from TOT to SUTiCambridge
2005-04-05 David Hyatt <hyatt@apple.com>
Fix for 4077106, make sure that mouse wheeling in overflow sections uses 40 rather than 10 as the base line
step.
Reviewed by darin
- khtml/rendering/render_layer.cpp: (RenderLayer::positionScrollbars):
- kwq/KWQScrollBar.mm: (QScrollBar::scroll):
WebKit:
Merged fix for 4077106 from TOT to SUTiCambridge
2005-04-05 David Hyatt <hyatt@apple.com>
Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.
Reviewed by darin
- WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):
- 6:22 PM Changeset in webkit [9194] by
-
- 6 edits in branches/Safari-2-0-branch/WebKit
Merged changes for <rdar://problem/4072280> from TOT to SUTiCambridge
2005-05-04 Chris Blumenberg <cblu@apple.com>
Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value
Reviewed by john.
Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
- WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
- WebView.subproj/WebResourcePrivate.h:
- 6:10 PM Changeset in webkit [9193] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Reviewed by Adele.
- khtml/ecma/kjs_window.cpp: (Window::get): Merged final change for frameElement from TOT.
- 5:52 PM Changeset in webkit [9192] by
-
- 10 edits in branches/Safari-2-0-branch
Merging fix for <rdar://problem/4098713> from TOT to SUTiCambridge
2005-04-26 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla
We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:
Their NPN_SetException has the following signature:
void NPN_SetException(NPObject *npobj, const NPUTF8 *message);
ours has:
void NPN_SetException (NPObject * npobj, const NPString *message);
Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.
I changed both behaviors to match Mozilla.
Reviewed by Chris.
- bindings/NP_jsobject.cpp: (_NPN_SetException):
- bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
- bindings/npruntime.h:
- bindings/npruntime_impl.h:
WebCore:
Merged fix for <rdar://problem/4091956> from TOT to SUTiCambridge
2005-04-25 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item
- kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.
WebKit:
Merged changes for <rdar://problem/4098713> from TOT to SUTiCambridge
2005-04-26 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla
Reviewed by Chris.
- Plugins.subproj/npfunctions.h:
- Plugins.subproj/npruntime.h:
- 5:34 PM Changeset in webkit [9191] by
-
- 2 edits in trunk/WebCore
- WebCore.exp: Sorted file for more readable diffs.
- 5:17 PM Changeset in webkit [9190] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4091082> from TOT for SUTiCambridge
2005-04-22 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"
- khtml/ecma/kjs_window.h: Added FrameElement.
- khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
- khtml/ecma/kjs_window.lut.h: Regenerated.
- 2:09 PM Changeset in webkit [9189] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
fix for <rdar://problem/4122661> Regression: 10.3.8-10.3.9: Next lesson doesn't work on Dale Carnegie Action Systems page
- khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::tryCall): added checks for NaN, in case it is passed into window.open for screenx, screeny, left, top, height, or width.
- 2:03 PM Changeset in webkit [9188] by
-
- 4 edits in trunk/WebKit
Changed type for identifier parameter in WebResourceLoadDelegate-related calls to id from NSString.
Reviewed by kevin.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _requestFromDelegateForRequest:identifier:error:]): (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]):
- WebView.subproj/WebFrameInternal.h:
- 1:39 PM Changeset in webkit [9187] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Prevent crash when going from no selection to selection with mispelling checks enabled.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellings): Repair check for null searchRange. Was inadvertently broken in recent checkin.
- 1:30 PM Changeset in webkit [9186] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fixed <rdar://problem/4123592> Can't resize textareas that have a width specified by a style
- kwq/KWQTextArea.mm: (-[KWQTextArea getNumColumns:andNumRows:forSize:]): removed this method, which I had added earlier to set cols and rows correctly (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): set width and height instead of cols and rows; handle the intrinsic margin that sometimes appears on form elements
May 22, 2005:
- 5:57 PM Changeset in webkit [9185] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
fix for <rdar://problem/4127101> REGRESSION(412-TOT) crash when creating Option element
- khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct): Changed ElementImpl pointer to a SharedPtr because it was getting destroyed before we were done with it.
May 20, 2005:
- 2:03 PM Changeset in webkit [9184] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris.
- fixed <rdar://problem/4126160> Crash sending mouse-exited event after reloading page with resizable textarea
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView resetCursorRects]): This was some side effect of tracking rect code used for resizable textareas. I discovered that I didn't need the tracking rect code at all (at least to achieve the level of only-somewhat-working cursor behavior that I already had). Removing it caused the bug to vanish.
- 1:50 PM Changeset in webkit [9183] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/4098786> sync. XMLHttpRequest works w/o AllowNetworkAccess key because load delegate is not consulted
Synchronous loads did not cause the willSendRequest method on the resource load delegate to be called. This is the method that Dashboard uses to enforce AllowNetworkAccess and this must be called to avoid exploits.
Reviewed by sullivan.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] so synthetic resource load delegate methods are called and the data is saved as a WebResource for resources in the WebCore cache.
(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:],
respect its result, do the load and then call [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]
for synchronous loads
- WebView.subproj/WebFrame.m: (-[WebFrame _opened]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:] so synthetic resource load delegate methods are called for subresrources in the page cache
(-[WebFrame _requestFromDelegateForRequest:identifier:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls identifierForInitialRequest and willSendRequest.
(-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls the remaining resource load delegate messages.
(-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]): new, saves the resource and calls
[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]
- WebView.subproj/WebFrameInternal.h:
May 19, 2005:
- 2:57 PM Changeset in webkit [9182] by
-
- 4 edits in trunk
Reviewed by Maciej.
- turned off exceptions and RTTI; seems to cut JavaScriptCore code size by about 22%
- JavaScriptCore.pbproj/project.pbxproj: Turn off exceptions and RTTI for both the framework and testkjs tool.
WebCore:
Reviewed by Maciej.
- turned off exceptions and RTTI; seems to cut WebCore code size by about 35%
- WebCore.pbproj/project.pbxproj: Turn off exceptions and RTTI for the framework.
- 11:32 AM Changeset in webkit [9181] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris Petersen.
- fixed a mistake I introduced in my previous check-in that caused a Deployment build failure
- kwq/DOM.mm: (-[DOMDocument createTreeWalker::::]): Initialize cppFilter to 0, which fixes both the build failure and a potential bug!
May 18, 2005:
- 5:53 PM Changeset in webkit [9180] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- got rid of code that depended on RTTI
- kjs/collector.cpp: (KJS::className): Added. Gets class name in a KJS way, rather than a C++ RTTI way. (KJS::Collector::rootObjectClasses): Use className instead of typeid names.
- 5:50 PM Changeset in webkit [9179] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fix a failure seen in the Mozilla JavaScript tests where a live object was garbage-collected when the only reference to it was in an argList on the stack
- kjs/list.h: Moved the operator= function into the .cpp file since it's too big to be a good choice to inline.
- kjs/list.cpp: (KJS::List::operator=): Moved this formerly-inline function into a separate file and added missing code to update valueRefCount. It's the latter that fixes the bug.
- 2:10 PM Changeset in webkit [9178] by
-
- 25 edits in trunk/WebCore
Reviewed by Maciej.
No new layout tests required.
- remove all dependencies on exceptions and RTTI (but don't turn them off yet, that will be in a later patch)
- WebCore.pbproj/project.pbxproj: Set a new KHTML_NO_CPLUSPLUS_DOM define. Removed all C++ DOM wrapper files that we don't need to compile any more.
- khtml/dom/css_stylesheet.h: Added more KHTML_NO_CPLUSPLUS_DOM checks so we don't include any headers when including this file.
- khtml/dom/dom2_events.h: Fixed up KHTML_NO_CPLUSPLUS_DOM checks so that everything but EventListener is turned off when that's on. Also moved the public so that the constants from KeyboardEvent are public.
- khtml/dom/dom2_events.cpp: Put everything except for EventListener inside KHTML_NO_CPLUSPLUS_DOM.
- khtml/dom/dom2_range.h: Added KHTML_NO_CPLUSPLUS_DOM checks so that only the constants are defined, no classes.
- khtml/dom/dom2_traversal.cpp: Put everything except for NodeFilterCondition inside KHTML_NO_CPLUSPLUS_DOM.
- khtml/dom/dom_node.h: Added more KHTML_NO_CPLUSPLUS_DOM checks so we don't include any headers when including this file.
- khtml/ecma/kjs_binding.cpp: (KJS::DOMObject::get): Removed exception-handling code. Now we can eliminate tryGet altogether. (KJS::DOMObject::put): Ditto. (KJS::DOMFunction::get): Ditto. (KJS::DOMFunction::call): Ditto.
- khtml/editing/visible_text.h: Added an include of <qstring.h>.
- khtml/misc/loader.h: Added isKHTMLLoader.
- khtml/misc/loader.cpp: (Loader::isKHTMLLoader): Added. Poor-man's replacement for dynamic_cast.
- khtml/rendering/render_form.h:
- khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): Added. Hack to make KWQSlot work for this function.
- khtml/xml/dom2_rangeimpl.h: Added a forward declaration of class DOMString, needed now that the C++ DOM wrappers aren't defining it.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Changed to call handleEventImpl so we don't have to make the C++ DOM wrapper for the event.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Ditto. (ContainerNodeImpl::insertBefore): Used SharedPtr<NodeImpl> rather than Node to protect the child node. (ContainerNodeImpl::replaceChild): Ditto. (ContainerNodeImpl::appendChild): Ditto. (ContainerNodeImpl::addChild): Ditto.
- kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode): Update to add a KHTML_NO_CPLUSPLUS_DOM check since FilterCondition has a different API depending on the state. (-[DOMDocument createNodeIterator::::]): Rewrote to use NodeFilterImpl instead of NodeFilter. (-[DOMDocument createTreeWalker::::]): Ditto.
- kwq/KWQAccObject.mm: (-[KWQAccObject role]): Use identifier instead of casting to Node and using elementId. (-[KWQAccObject title]): Ditto. (-[KWQAccObject accessibilityIsIgnored]): Ditto. (-[KWQAccObject rendererForView:]): Ditto.
- kwq/KWQFrame.mm: (QFrame::setFrameStyle): Use isKHTMLView instead of dynamic_cast.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentForm): Use focusNode instead of activeNode. (KWQKHTMLPart::nextKeyViewInFrame): Use isWidget instead of dynamic_cast. (KWQKHTMLPart::currentEventIsMouseDownInWidget): Use KHTMLView's nodeUnderMouse instead of our public one that uses a DOM C++ wrapper. (KWQKHTMLPart::partForWidget): Use isKHTMLView instead of dynamic_cast. (KWQKHTMLPart::passSubframeEventToSubframe): Use isWidget instead of dynamic_cast.
- kwq/KWQObject.h: Made isXXX functions all public since we use them in a few more places now. Also added isKHTMLLoader.
- kwq/KWQObject.mm: (QObject::isKHTMLLoader): Added. Returns false by default.
- kwq/KWQSlot.mm: Removed all uses of dynamic_cast.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge stringForRange:]): Used plainText instead of text. (-[WebCoreBridge copyRenderNode:copier:]): Used isWidget instead of dynamic_cast.
May 17, 2005:
- 10:55 AM Changeset in webkit [9177] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control
Reviewed by mjs.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
- WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
- 9:28 AM Changeset in webkit [9176] by
-
- 5 edits in trunk/WebKit
WebKit:
Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead
Reviewed by mjs.
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error
WebBrowser:
Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead
- BrowserWebView.m: (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]): download remote web archives
May 16, 2005:
- 3:11 PM Changeset in webkit [9175] by
-
- 4 edits in trunk
WebCore:
- attempt to get things building under "Saffron" development tools
- WebCore.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.
WebKit:
- attempt to get things building under "Saffron" development tools
- WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.
- 3:03 PM Changeset in webkit [9174] by
-
- 5 edits in trunk
Tests:
Changes by Darin. Reviewed by myself.
Added new layoutTestController method to dump the document as text.
- DumpRenderTree/main.m: (-[LayoutTestController dumpAsText]): new method on layoutTestController to dump the innerText of the body instead of dumping the render tree; better for tests that are not really about layout (+[LayoutTestController isSelectorExcludedFromWebScript:]): added new dumpAsText selector (dump): changed name of showRenderTree since it now sometimes dumps text instead (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): calls new dump function (-[LayoutTestController notifyDone]): calls new dump function (dumpRenderTree): initializes global variables dumpAsText and waitLayoutTest
WebCore:
Changes by Darin. Reviewed by myself.
Changed the Render Tree debug code to write out an indication that the affinity is upstream
when writing out caret position. Updated the one layout test with output affected by the change.
Also updated one test to use the new dumpAsText method in dumpRenderTree.
- kwq/KWQRenderTreeDebug.cpp: (writeSelection): writes out affinity if it's upstream in the caret case
- layout-tests/editing/style/create-block-for-style-004-expected.txt: new results that contain the affinity
- layout-tests/fast/js/char-at.html: now calls layoutController.dumpAsText()
- layout-tests/fast/js/char-at-expected.txt: plain text result (replaces old render tree result)
- 12:19 PM Changeset in webkit [9173] by
-
- 14 edits in trunk/WebCore
Reviewed by Adele.
- fixed issues preventing us from compiling with newer versions of gcc 4.0
- khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
- khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
- khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
- khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
- khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
- khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
- khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
- khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
- khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
- kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.
- 11:57 AM Changeset in webkit [9172] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adele.
- fixed issues preventing us from compiling with newer versions of gcc 4.0
- kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.
May 13, 2005:
- 11:44 AM Changeset in webkit [9171] by
-
- 2 edits in trunk/WebCore
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): added Radar numbers to FIXMEs about resizable textareas (-[KWQTextAreaTextView resetCursorRects]): ditto (-[KWQTextAreaTextView mouseDown:]): ditto
- 10:23 AM Changeset in webkit [9170] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin.
- fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series of authentication sheets
- Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as: <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down
- 9:48 AM Changeset in webkit [9169] by
-
- 33 edits in trunk/WebCore
Reviewed by Chris Blumenberg.
- more "getting off the C++ DOM wrappers" changes This pass involves replacing uses of DOM::Range with use of DOM::RangeImpl plus some more use of DOM::DocumentImpl instead of DOM::Document.
- khtml/dom/dom2_range.cpp:
- khtml/dom/dom2_range.h:
- khtml/ecma/kjs_window.cpp: (KJS::Window::get): (KJS::WindowFunc::tryCall): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Selection::toString):
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall):
- khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply):
- khtml/editing/selection.cpp: (khtml::Selection::Selection): (khtml::Selection::moveTo): (khtml::Selection::toRange):
- khtml/editing/selection.h:
- khtml/editing/visible_position.cpp: (khtml::makeRange): (khtml::startVisiblePosition): (khtml::endVisiblePosition): (khtml::setStart): (khtml::setEnd):
- khtml/editing/visible_position.h:
- khtml/editing/visible_range.h:
- khtml/editing/visible_text.cpp: (khtml::TextIterator::TextIterator): (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::CharacterIterator): (khtml::CharacterIterator::range): (khtml::WordAwareIterator::WordAwareIterator): (khtml::WordAwareIterator::advance): (khtml::TextIterator::rangeLength): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::plainText): (khtml::findPlainText):
- khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
- khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText):
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution):
- khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::selectedText): (KHTMLPart::shouldBeginEditing): (KHTMLPart::shouldEndEditing): (KHTMLPart::selectionComputedStyle):
- khtml/khtml_part.h:
- khtml/khtmlview.h:
- khtml/rendering/render_text.cpp: (InlineTextBox::paint):
- khtml/xml/dom2_rangeimpl.cpp: (DOM::operator==): (DOM::rangeOfContents):
- khtml/xml/dom2_rangeimpl.h: (DOM::operator!=):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::relinquishesEditingFocus): (DocumentImpl::acceptsEditingFocus): (DocumentImpl::addMarker): (DocumentImpl::removeMarker):
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_position.cpp: (DOM::startPosition):
- khtml/xml/dom_position.h:
- kwq/DOMHTML.mm: (-[DOMHTMLLinkElement href]): (-[DOMHTMLBaseElement href]): (-[DOMHTMLInputElement src]): (-[DOMHTMLAnchorElement href]): (-[DOMHTMLImageElement src]): (-[DOMHTMLAreaElement href]):
- kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject doAXStringForTextMarkerRange:]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
- kwq/KWQKHTMLPart.h: (KWQKHTMLPart::markedTextRange):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::respondToChangedSelection): (KWQKHTMLPart::shouldBeginEditing): (KWQKHTMLPart::shouldEndEditing): (convertAttributesToUnderlines): (KWQKHTMLPart::setMarkedTextRange):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreBridge selectedDOMRange]): (-[WebCoreBridge convertToNSRange:DOM::]): (-[WebCoreBridge convertToDOMRange:]): (-[WebCoreBridge convertToObjCDOMRange:]): (-[WebCoreBridge selectNSRange:]): (-[WebCoreBridge selectedNSRange]): (-[WebCoreBridge markDOMRange]): (-[WebCoreBridge markedTextDOMRange]): (-[WebCoreBridge markedTextNSRange]): (-[WebCoreBridge replaceMarkedTextWithText:]): (-[WebCoreBridge smartDeleteRangeForProposedRange:]): (-[WebCoreBridge dragCaretDOMRange]): (-[WebCoreBridge editableDOMRangeForPoint:]): (-[WebCoreBridge rangeOfCharactersAroundCaret]):
- 1:37 AM Changeset in webkit [9168] by
-
- 5 edits8 adds in trunk/WebCore
Reviewed by Dave.
- more splitting up of htmlediting.cpp
- WebCore.pbproj/project.pbxproj:
- khtml/editing/composite_edit_command.cpp:
- khtml/editing/delete_from_text_node_command.cpp: Added.
- khtml/editing/delete_from_text_node_command.h: Added.
- khtml/editing/delete_selection_command.cpp: Added.
- khtml/editing/delete_selection_command.h: Added.
- khtml/editing/htmlediting.cpp:
- khtml/editing/htmlediting.h:
- khtml/editing/insert_into_text_node_command.cpp: Added.
- khtml/editing/insert_into_text_node_command.h: Added.
- khtml/editing/insert_node_before_command.cpp: Added.
- khtml/editing/insert_node_before_command.h: Added.
May 12, 2005:
- 5:57 PM Changeset in webkit [9167] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
fix for <rdar://problem/4117656> deleting an input element in its onBlur handler crashes Safari
- khtml/rendering/render_form.cpp: (RenderLineEdit::handleFocusOut): added nil check for element
- 2:31 PM Changeset in webkit [9166] by
-
- 14 edits1 add in trunk
WebCore:
Reviewed by Kevin.
- rolled in changes from experimental-ui-branch to support resizable textareas and find-as-you-type. The files/functions modified are listed just below. After that are the ChangeLog comments from the branch.
- Resources/textAreaResizeCorner.tiff: Added.
- WebCore.pbproj/project.pbxproj:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString):
- kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): (-[KWQTextAreaTextView _resizeCornerImage]): (-[KWQTextAreaTextView _resizeCornerRect]): (-[KWQTextAreaTextView resetCursorRects]): (-[KWQTextAreaTextView drawRect:]): (-[KWQTextAreaTextView mouseDown:]):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:findInSelection:]):
2005-05-05 John Sullivan <sullivan@apple.com>
Reviewed by Chris.
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerRect]): Get corner rect from enclosing clipView, rather than using visibleRect. VisibleRect would return the wrong result when the textarea was clipped by the bottom of the window, leading to redraw schmutz among other things.
2005-05-02 John Sullivan <sullivan@apple.com>
Reviewed by Chris.
Improvements to resizable textarea experiment:
- resize image is now drawn in the resize corner
- cursor sometimes tracks to arrow when over resize corner (but usually not)
- cursor changes to arrow on mouse down in any case
- Resources/textAreaResizeCorner.tiff: Added.
- WebCore.pbproj/project.pbxproj: updated for added image file
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerImage]): new method, reads resize image once and caches it (-[KWQTextAreaTextView _resizeCornerRect]): new method, computes rect from image (-[KWQTextAreaTextView resetCursorRects]): overridden to attempt to make the cursor change to an arrow when over this corner. Only works sometimes, as explained in comments. (-[KWQTextAreaTextView drawRect:]): overridden to draw resize image (-[KWQTextAreaTextView mouseDown:]): now uses _resizeCornerRect, and sets cursor to arrow when pressed in resize corner
2005-04-18 John Sullivan <sullivan@apple.com>
WebCore support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).
Reviewed by Maciej.
- kwq/WebCoreBridge.h: add textDidChange: method
- kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): call through to bridge
2005-04-07 John Sullivan <sullivan@apple.com>
WebCore support for find-as-you-type; needed an additional parameter
to findString and searchFor:...
Reviewed by Dave Hyatt.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): new findInSelection parameter; if true, start from the beginning of the selection when searching forward, or the end of the selection when searching backward
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:findInSelection:]): new findInSelection parameter; passed through to findString
WebKit:
Reviewed by Kevin.
- rolled in changes from experimental-ui-branch to support resizable textareas and find-as-you-type and confirming unsubmitted form changes. The files/functions modified are listed just below. After that are the ChangeLog comments from the branch.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textDidChange:]):
- WebView.subproj/WebFormDelegate.h:
- WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textDidChange:inFrame:]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
- WebView.subproj/WebView.m: (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView makeTextStandardSize:]): (-[WebView maintainsInactiveSelection]):
- WebView.subproj/WebViewPrivate.h:
2005-04-18 John Sullivan <sullivan@apple.com>
WebKit support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).
Reviewed by Maciej.
- WebView.subproj/WebFormDelegate.h:
- WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textDidChange:inFrame:]): new form delegate method
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textDidChange:]): new method, calls through to form delegate
2005-04-11 John Sullivan <sullivan@apple.com>
Fixed inability to wrap around in Find in Page
- WebView.subproj/WebView.m: (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): changed wrapFlag from NO to YES on two lines (copy/paste error)
2005-04-07 John Sullivan <sullivan@apple.com>
WebKit support for find-as-you-type. Needed an additional parameter on
a method from WebDocumentSearching protocol. Since that's a public protocol,
I couldn't just add the parameter. For now I hacked it with an undeclared
internal method that's discovered via respondsToSelector. Probably the right
long-term approach is to deprecate the WebDocumentSearching protocol and introduce
a replacement that has a more flexible set of parameters for possible future
expansion.
Reviewed by Dave Hyatt.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through to bridge
- WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): now calls new one-more-parameter version passing NO for new parameter to match old behavior (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): new method, adds findInSelection parameter and passes it through
2005-04-07 John Sullivan <sullivan@apple.com>
WebKit support to allow clients to control whether the selection is still
drawn when the first responder is elsewhere. Formerly this was hardwired
to be true only when -[WebView isEditable] was true.
Reviewed by Darin.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): check [WebView maintainsInactiveSelection] rather than just [WebView isEditable]
- WebView.subproj/WebViewPrivate.h:
- WebView.subproj/WebView.m: (-[WebView maintainsInactiveSelection]): new method for clients to override, returns -[self isEditable]
WebBrowser:
Reviewed by Kevin.
- rolled in changes from experimental-ui-branch to support resizable textareas and find-as-you-type and confirmations when closing tab/window/app and full screen mode. I renamed "WebPageBannner" to just "Banner" at the same time, since the banner will have to be used on non-webpages (source documents) too. The files/functions modified are listed just below. After that are the ChangeLog comments from the branch. Note that I did not roll over the LabelBanner stuff, though we can of course do so later if we decide to.
- AppController.h:
- AppController.m: (-[AppController _OKToCloseBrowserWindows]): (-[AppController applicationShouldTerminate:]): (-[AppController validateUserInterfaceItem:]):
- Banner.h: Added.
- Banner.m: Added. (-[Banner init]): (-[Banner dealloc]): (-[Banner bannerView]): (-[Banner standardBannerColor]): (-[Banner bannerNibName]): (_loadCloseButtonImages): (-[Banner _closeButtonClicked:]): (-[Banner _createCloseButton]): (-[Banner _populateBannerViewFromNib:]): (-[Banner createBannerView]): (-[Banner _advanceAnimation]): (-[Banner _moveBannerIntoPlace:withAnimation:]): (-[Banner didInstallBannerView]): (-[Banner installIntoWebView:withAnimation:]): (-[Banner uninstallFromWebViewWithAnimation:]):
- BarBackground.h:
- BarBackground.m: (+[BarBackground defaultBottomBorderLineColor]): (-[BarBackground drawRect:]): (-[BarBackground setBackgroundColor:]): (-[BarBackground setBottomBorderColor:]):
- BrowserDocument.h:
- BrowserDocument.m: (-[BrowserDocument saveDocumentTo:]): (-[BrowserDocument showFindPanel:]): (-[BrowserDocument findNext:]): (-[BrowserDocument findPrevious:]): (-[BrowserDocument reportBugToApple:]): (-[BrowserDocument printWebFrameView:showingPrintPanel:useSheet:]): (-[BrowserDocument proposeBookmarkRespectingProvisionalPage:]): (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument mailPage:]): (-[BrowserDocument _reportLaunchFailureForMailApplicationAtPath:]): (-[BrowserDocument mailPageAddress:]):
- BrowserDocumentController.h:
- BrowserDocumentController.m: (-[BrowserDocumentController tabsWithUnsubmittedFormText]):
- BrowserTabViewItem.h:
- BrowserTabViewItem.m: (-[BrowserTabViewItem setView:]): (-[BrowserTabViewItem webView]):
- BrowserWebController.h:
- BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView dealloc]): (-[BrowserWebView findInPageBanner]): (-[BrowserWebView currentBanner]): (-[BrowserWebView setCurrentBanner:]): (-[BrowserWebView addFavoriteForParentControlledPageInFrame:]): (-[BrowserWebView containsEditedForm]): (-[BrowserWebView maintainsInactiveSelection]): (-[BrowserWebView dataSourceHasChanged:forFrame:]): (-[FormDelegate initWithDocument:]): (-[FormDelegate _setFormWasEdited:]): (-[FormDelegate controlTextDidChange:inFrame:]): (-[FormDelegate textDidChange:inFrame:]): (-[FormDelegate frameLayoutHasChanged:]): (-[FormDelegate dataSourceHasChangedForFrame:]): (-[FormDelegate formWasEdited]):
- BrowserWindow.m: (-[BrowserWindow canBecomeKeyWindow]): (-[BrowserWindow canBecomeMainWindow]):
- BrowserWindowController.h:
- BrowserWindowController.m: (-[BrowserWindowController _makeFirstResponder:]): (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateKeyboardLoop]): (-[BrowserWindowController webViewBannerHasChanged:]): (-[BrowserWindowController updateLabelForTab:evenIfTabBarHidden:]): (-[BrowserWindowController setUpTabForWebView:addToRightSide:]): (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController dealloc]): (-[BrowserWindowController _confirmCloseWindowDidEnd:returnCode:contextInfo:]): (-[BrowserWindowController _displayCloseConfirmation]): (-[BrowserWindowController windowShouldClose:]): (-[BrowserWindowController showLocationBarTemporarilyIfHidden]): (-[BrowserWindowController toggleTabBarWithAnimation:]): (-[BrowserWindowController _closeTabWithoutConfirming:]): (-[BrowserWindowController _confirmCloseTabForEditedFormDidEnd:returnCode:contextInfo:]): (-[BrowserWindowController _confirmClosingEditedTab:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController closeOtherTabs:]): (-[BrowserWindowController reloadTabsMatchingURLs:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebView:]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController reloadParentallyRestrictedFrames]): (-[BrowserWindowController updateDocumentIsEdited]): (-[BrowserWindowController defaultsDidChange]): (-[BrowserWindowController windowDidResignKey:]): (-[BrowserWindowController replaceTabSwitcher:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController tabBarView:performDragOperationForTabViewItem:URL:]): (-[BrowserWindowController tabsWithUnsubmittedFormText]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]): (-[BrowserWindowController validateMenuItem:]): (-[BrowserWindowController isFullScreen]): (-[BrowserWindowController firstResponderView]): (-[BrowserWindowController setFullScreen:]): (-[BrowserWindowController toggleFullScreen:]): (-[BrowserWindowController windowForSheet]): (-[NSTabView makeWebViewsPerformSelector:withObject:]):
- CoachMark.h: Added.
- CoachMark.m: Added. (-[CoachMark initWithBounds:forView:]): (-[CoachMark dealloc]): (-[CoachMark width]): (-[CoachMark setWidth:]): (-[CoachMark duration]): (-[CoachMark setDuration:]): (-[CoachMark fractionComplete]): (-[CoachMark invalidate]): (getHostTime): (-[CoachMark redrawTimer:]):
- CoachMarkController.h: Added.
- CoachMarkController.m: Added. (+[CoachMarkController sharedCoachMarkController]): (-[CoachMarkController init]): (-[CoachMarkController dealloc]): (-[CoachMarkController addCoachMarkWithBounds:forView:]): (-[CoachMarkController coachMarkExpired:]):
- CoachMarkView.h: Added.
- CoachMarkView.m: Added. (-[CoachMarkView dealloc]): (-[CoachMarkView setCoach:]): (-[CoachMarkView width]): (-[CoachMarkView setWidth:]): (-[CoachMarkView _color]): (-[CoachMarkView roundedRect:withRadius:]): (-[CoachMarkView drawRect:]):
- ContextMenuHandler.m: (-[BrowserWebView downloadURLUsingSavePanel:]): (-[BrowserWebView reportErrorForBadFileWrapper:]): (-[BrowserWebView saveFileWrapperToDownloadsFolder:]): (-[BrowserWebView reportiPhotoErrorWithMessage:]):
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleTransparentWindow:]): (-[BrowserDocument validate_toggleUseThreadedImageDecoding:]): (-[BrowserDocument toggleConfirmUnsubmittedFormText:]): (-[BrowserDocument toggleConfirmClosingMultiplePages:]): (-[BrowserDocument toggleUseFindBanner:]): (-[BrowserDocument toggleGradient:]): (-[BrowserDocument validate_toggleGradient:]): (-[BrowserDocument showFindBannerSettings:]): (-[BrowserDocument validate_toggleConfirmUnsubmittedFormText:]): (-[BrowserDocument validate_toggleConfirmClosingMultiplePages:]): (-[BrowserDocument validate_toggleUseFindBanner:]):
- Debug/FindBannerSettings.nib: Added.
- Debug/FindBannerSettingsController.h: Added.
- Debug/FindBannerSettingsController.m: Added. (+[FindBannerSettingsController sharedController]): (-[FindBannerSettingsController windowNibName]): (-[FindBannerSettingsController colorFromPopUp]): (-[FindBannerSettingsController selectOtherColor:]): (-[FindBannerSettingsController setOutlineColorFromSelectedItem]): (-[FindBannerSettingsController colorPickedInColorPanel:]): (-[FindBannerSettingsController takeOutlineColorFrom:]): (-[FindBannerSettingsController takeDurationFrom:]): (-[FindBannerSettingsController updateColorViews]): (-[FindBannerSettingsController toggleUseFadingOutline:]): (-[FindBannerSettingsController updateViews]): (-[FindBannerSettingsController windowDidLoad]):
- Defaults.plist:
- English.lproj/FindBanner.nib: Added.
- English.lproj/Localizable.strings:
- English.lproj/MainMenu.nib:
- English.lproj/StringsNotToBeLocalized.txt:
- FindBanner.h: Added.
- FindBanner.m: Added. (-[FindBanner bannerNibName]): (-[FindBanner _updateNextAndPreviousButtons]): (-[FindBanner _makeSearchFieldFirstResponder]): (-[FindBanner didInstallBannerView]): (-[FindBanner controlTextDidChange:]): (-[FindBanner _updateFindPasteboardFromSearchField]): (-[FindBanner _updateSearchFieldFromFindPasteboard]): (-[FindBanner _searchString]): (-[FindBanner _searchTarget]): (-[FindBanner _doSearchForString:direction:caseSensitive:findInSelection:inTarget:]): (-[FindBanner readyToFind]): (-[FindBanner _setStatus:]): (-[FindBanner _callAttentionToSelectedText]): (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): (-[FindBanner findFromSearchField:]): (-[FindBanner findNext:]): (-[FindBanner findPrevious:]): (-[FindBanner focusOrHide]):
- FormCompletionController.m: (+[FormCompletionController autoFillInWebView:]):
- LocationChangeHandler.m: (-[LocationChangeHandler handleCertificateError:forDataSource:]):
- PreferenceKeys.h:
- RendezvousController.m: (-[RendezvousController reportErrorForServiceName:]):
- WebBrowser.pbproj/project.pbxproj:
2005-05-05 John Sullivan <sullivan@apple.com>
Reviewed by Chris.
- preserve the first responder when going to full screen and back.
- BrowserWindowController.m: (-[BrowserWindowController firstResponderView]): new method, full of hideous AppKit inside knowledge, that returns the view that is first responder, if any. If the first responder is a field editor, this returns the associated control. The hideous AppKit inside knowledge is all straight from Andrew Platzer and Mike Engber. (-[BrowserWindowController setFullScreen:]): get the first responder before switching, then reset it if it was a view that survived the journey to the new window. Do some special case tomfoolery to restore the selected range also.
2005-05-03 John Sullivan <sullivan@apple.com>
Reviewed by Darin.
- make the full screen window textured so the bookmarks bar, tab bar, and status bar use the same background as in a standard browser window.
- BrowserWindowController.m: (-[BrowserWindowController setFullScreen:]): include textured window flag in style mask
2005-05-02 John Sullivan <sullivan@apple.com>
Reviewed by Chris.
Improvements to Find in Page experiment:
- get the close button images from NSSearchField. These look better in this context than the ones used for tabs.
- move close box to right side of banner.
- English.lproj/FindBanner.nib: Move views around to account for close button being moved to right side
- WebPageBanner.m: (_loadCloseButtonImages): get images from an NSSearchFieldCell (-[WebPageBanner _populateBannerViewFromNib:]): account for close button being on right side now
2005-04-22 John Sullivan <sullivan@apple.com>
Reviewed by John.
- first cut at full screen mode
- BrowserWindowController.h: Added _normalWindow and _fullScreenWindow fields, toggleFullScreen:, windowForSheet, setFullScreen:, and isFullScreen methods.
- BrowserWindowController.m: (-[BrowserWindowController _makeFirstResponder:]): Removed assertion that we end up stumbling over when switching to/from full screen mode. I think we can do without it. (-[BrowserWindowController dealloc]): Release the two new fields. (-[BrowserWindowController showLocationBarTemporarilyIfHidden]): Pop out of full screen mode whenever we would show the location bar, since right now it's not compatible with full screen. (-[BrowserWindowController windowDidResignKey:]): Pop out of full screen mode when a window comes in front of us. (-[BrowserWindowController validateMenuItem:]): Set state of toggle menu item based on current state of window. (-[BrowserWindowController isFullScreen]): Added. (-[BrowserWindowController setFullScreen:]): Added. This does the real bulk of the work. (-[BrowserWindowController toggleFullScreen:]): Added. (-[BrowserWindowController windowForSheet]): Added. Turns off full screen mode and then returns the window.
- BrowserWindow.m: (-[BrowserWindow canBecomeKeyWindow]): Override to return YES. Harmless for normal window, needed for full screen window. (-[BrowserWindow canBecomeMainWindow]): Ditto.
- BrowserDocument.m: (-[BrowserDocument saveDocumentTo:]): Get out of full screen mode before running a sheet. (-[BrowserDocument reportBugToApple:]): Use windowForSheet to get out of full screen mode before running a sheet. (-[BrowserDocument printWebFrameView:showingPrintPanel:useSheet:]): Ditto. (-[BrowserDocument proposeBookmarkRespectingProvisionalPage:]): Ditto. (-[BrowserDocument mailPage:]): Ditto. (-[BrowserDocument _reportLaunchFailureForMailApplicationAtPath:]): Ditto. (-[BrowserDocument mailPageAddress:]): Ditto.
- BrowserWebController.m: (-[BrowserWebView addFavoriteForParentControlledPageInFrame:]): Ditto.
- ContextMenuHandler.m: (-[BrowserWebView downloadURLUsingSavePanel:]): Use windowForSheet to get out of full screen mode before running a sheet. (-[BrowserWebView reportErrorForBadFileWrapper:]): Ditto. (-[BrowserWebView saveFileWrapperToDownloadsFolder:]): Ditto. (-[BrowserWebView reportiPhotoErrorWithMessage:]): Ditto.
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Include a Full-Screen-toggling menu item.
- FormCompletionController.m: (+[FormCompletionController autoFillInWebView:]): Use windowForSheet to get out of full screen mode before running a sheet.
- LocationChangeHandler.m: (-[LocationChangeHandler handleCertificateError:forDataSource:]): Ditto.
- RendezvousController.m: (-[RendezvousController reportErrorForServiceName:]): Ditto.
2005-04-21 John Sullivan <sullivan@apple.com>
Added confirmation on closing window with multiple tabs or quitting Safari
with multiple windows or tabs. This confirmation can be turned on and off
from the Debug menu; it defaults to on. Made state of "dirty dot" update
appropriately when the pref for confirming unsubmitted form text is toggled.
Fixed a few other bugs in this confirmation stuff.
Reviewed by Adele.
- PreferenceKeys.h: added new preference DebugConfirmClosingMultiplePagesPreferenceKey
- Defaults.plist: initial value for new preference is true
- AppController.m: (-[AppController _OKToCloseBrowserWindows]): Renamed from _OKToAbandonUnsubmittedFormText. Now considers multiple windows/tabs in addition to unsubmitted form text. Lots and lots of variations of the message text. (-[AppController applicationShouldTerminate:]): updated for name change
- BrowserWebController.m: (-[FormDelegate _setFormWasEdited:]): only turn on the "dirty dot" if the pref for confirming unsubmitted form text is on
- BrowserWindowController.h: added _confirmUnsubmittedFormText to cache value of this pref to avoid looking it up over and over
- BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): set value of _confirmUnsubmittedFormText from NSUserDefaults (-[BrowserWindowController _confirmCloseWindowDidEnd:returnCode:contextInfo:]): changed name from _confirmCloseForEditedFormDidEnd... (-[BrowserWindowController _displayCloseConfirmation]): Changed name from _displayConfirmationSheetForUnsubmittedFormText. Now considers multiple tabs in addition to unsubmitted form text. (-[BrowserWindowController windowShouldClose:]): updated for name change (-[BrowserWindowController _confirmClosingEditedTab:]): removed some extraneous periods following question marks in user messages (-[BrowserWindowController closeTab:]): fixed bug where the close-tab confirmation was being put up even in the case where the tab was closed with no confirmation (d'oh!) (-[BrowserWindowController updateDocumentIsEdited]): new method, synchronizes the "dirty dot" with current preferences and state (-[BrowserWindowController defaultsDidChange]): now calls updateDocumentIsEdited
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): added menu item "Confirm Closing Multiple Pages" (-[BrowserDocument toggleConfirmClosingMultiplePages:]): new method, toggles the pref (-[BrowserDocument validate_toggleConfirmClosingMultiplePages:]): new method, syncs check mark on menu item
- English.lproj/Localizable.strings: updated for these changes
2005-04-20 John Sullivan <sullivan@apple.com>
More work on confirmations for unsubmitted form text. Now it confirms for the current page
of any tab when closing a window. Now it confirms when closing a single tab rather than
closing the window. Now it confirms when quitting. Now it displays the "dirty dot" in the
close box if the window has unsubmitted form text in the current page of any tab.
Reviewed by Adele.
- AppController.m: (-[AppController _OKToAbandonUnsubmittedFormText]): new method, puts up app-modal dialog if necessary to confirm abandoning unsubmitted form text. Names one such page by title, and mentions how many others there are. (-[AppController applicationShouldTerminate:]): Check for unsubmitted form text before checking for downloads in progress.
- BrowserDocumentController.h:
- BrowserDocumentController.m: (-[BrowserDocumentController tabsWithUnsubmittedFormText]): new method, returns an array collected from all open windows.
- BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): now passes self's document as an init parameter to FormDelegate (-[FormDelegate initWithDocument:]): now takes a document as an init parameter (-[FormDelegate _setFormWasEdited:]): new method, sets the local flag and also tells the window controller to update its UI (the "dirty dot") (-[FormDelegate controlTextDidChange:inFrame:]): call new setter method rather than setting _formWasEdited ivar directly (-[FormDelegate textDidChange:inFrame:]): ditto (-[FormDelegate dataSourceHasChangedForFrame:]): ditto
- BrowserWindowController.h: new public method -tabsWithUnsubmittedFormText
- BrowserWindowController.m: (-[BrowserWindowController _displayConfirmationSheetForUnsubmittedFormText]): renamed from _confirmCloseForEditedForm; now handles the logic about whether confirmation is necessary that was formerly handled by the caller. Now names page by title instead of URL. Now handles 1, 2, and 3-or-more dirty tab cases (used to only check frontmost tab). Now brings dirty tab to front before showing sheet, if necessary. (-[BrowserWindowController windowShouldClose:]): moved some code into _displayConfirmationSheetForUnsubmittedFormText (-[BrowserWindowController _closeTabWithoutConfirming:]): new method, contains code formerly in -closeTab: (-[BrowserWindowController _confirmCloseTabForEditedFormDidEnd:returnCode:contextInfo:]): new method, called when sheet is dismissed. Closes the tab without confirming or does nothing. (-[BrowserWindowController _confirmClosingEditedTab:]): new method, puts up confirmation sheet for edited tab (-[BrowserWindowController closeTab:]): now checks whether confirmation is necessary instead of closing immediately as it did before (-[BrowserWindowController tabsWithUnsubmittedFormText]): new method, returns an array of tabs from this window; used when closing the window and when quitting
- English.lproj/Localizable.strings: updated for these changes
2005-04-18 John Sullivan <sullivan@apple.com>
Added Debug menu item to control whether to confirm before closing a window that
contains unsubmitted form text.
Reviewed by Kevin.
- PreferenceKeys.h: new default DebugConfirmTossingUnsubmittedFormTextPreferenceKey
- Defaults.plist: initial value of new default is true
- BrowserWindowController.m: (-[BrowserWindowController windowShouldClose:]): only confirm if the preference is set
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item "Confirm Unsubmitted Form Text" (-[BrowserDocument toggleConfirmUnsubmittedFormText:]): callback from menu item, toggles the default value (-[BrowserDocument validate_toggleConfirmUnsubmittedFormText:]): validate the menu item by adding a checkmark if appropriate
2005-04-18 John Sullivan <sullivan@apple.com>
Made form-text-changed confirmation work for textareas as well as textfields.
Reviewed by Maciej.
- BrowserWebController.m: (-[FormDelegate textDidChange:inFrame:]): implement this new FormDelegate method to set the dirty bit
2005-04-18 John Sullivan <sullivan@apple.com>
First cut at confirming before closing a window that contains edited form text.
Reviewed by Adele.
- BrowserWebController.h: new method -containsEditedForm
- BrowserWebController.m: (-[BrowserWebView containsEditedForm]): new method; asks FormDelegate object (-[BrowserWebView dataSourceHasChanged:forFrame:]): now calls dataSourceHasChangedForFrame: rather than frameLayoutHasChanged: on FormDelegate object (-[FormDelegate controlTextDidChange:inFrame:]): set _formWasEdited bit (-[FormDelegate dataSourceHasChangedForFrame:]): new method; calls frameLayoutHasChanged (to match old behavior), clears _formWasEdited bit (-[FormDelegate formWasEdited]): new method; returns _formWasEdited bit
- BrowserWindowController.m: (-[BrowserWindowController _confirmCloseForEditedFormDidEnd:returnCode:contextInfo:]): if user hit Close button, close the window now, else do nothing (-[BrowserWindowController _confirmCloseForEditedForm]): put up a confirmation sheet (-[BrowserWindowController windowShouldClose:]): if the current page returns yes for containsEditedForm
- English.lproj/Localizable.strings: Updated for text in confirmation sheet.
2005-04-13 John Sullivan <sullivan@apple.com>
Added a close box to all banners (using same art as tabs, which is pretty
ugly; we'll have to prettify this).
Fixed a small redraw bug with the sliding-in/out animation.
Reviewed by Dave Hyatt.
- WebPageBanner.m: (_loadCloseButtonImages): new function, loads the three images used by the close button into static variables so we don't load from the bundle every time a banner is used. (-[WebPageBanner _closeButtonClicked:]): new method, closes the banner (-[WebPageBanner _createCloseButton]): new method, creates a RolloverImageButton with the right attributes, images, and size (-[WebPageBanner _populateBannerViewFromNib:]): put the close button in as first subview, at a standard location (-[WebPageBanner _advanceAnimation]): use setFocusRingNeedsDisplayInRect: instead of just setNeedsDisplay: to avoid focus ring schmutz from being left behind during the animation
2005-04-13 John Sullivan <sullivan@apple.com>
Added support for tabbing through banners, and made it work for the Find banner.
Reviewed by Chris.
- BrowserWindowController.h: new webViewBannerHasChanged: method for BrowserWebView to call
- BrowserWindowController.m: (-[BrowserWindowController updateKeyboardLoop]): insert the current banner into the keyboard loop (-[BrowserWindowController webViewBannerHasChanged:]): call updateKeyboardLoop
- BrowserWebController.m: (-[BrowserWebView setCurrentBanner:]): call webViewBannerHasChanged:
- WebPageBanner.h: new outlets for first and last subviews for keyboard loop
- WebPageBanner.m: (-[WebPageBanner _populateBannerViewFromNib:]): use new outlets and BarBackgrounds support for keyboard loops to wire the subviews into the keyboard loop
- English.lproj/FindBanner.nib: Wired the nextKeyView connections up, and wired up the new firstChildSubview and lastChildSubview outlets.
2005-04-12 John Sullivan <sullivan@apple.com>
Made banners animate into and out of place (no animation occurs if
one banner is switching to another).
Reviewed by Maciej.
- WebPageBanner.h: added animation parameters to install and uninstall methods; some new animation-related ivars
- WebPageBanner.m: (-[WebPageBanner _advanceAnimation]): new method, repositions banner and resizes webview based on fraction complete of animation (-[WebPageBanner _moveBannerIntoPlace:withAnimation:]): new method, initializes and starts animation (-[WebPageBanner didInstallBannerView]): new method for subviews to override; does nothing here (-[WebPageBanner installIntoWebView:withAnimation:]): added withAnimation: parameter; removed the webView-sizing code that's now done in _advanceAnimation; calls didInstallBannerView right before animating (-[WebPageBanner uninstallFromWebViewWithAnimation:]): ditto
- FindBanner.m: (-[FindBanner didInstallBannerView]): set up initial state here rather than in installIntoWebView: so that views look correct during the animation
- BrowserWebController.m: (-[BrowserWebView setCurrentBanner:]): animate unless we're switching from one banner to another
2005-04-12 John Sullivan <sullivan@apple.com>
Disable Next/Previous buttons in Find banner appropriately.
Also, Command-F now focuses the find-in-page search field in all cases except
when it's already focused; in that case it hides the banner.
Reviewed by Chris.
- BrowserDocument.m: (-[BrowserDocument showFindPanel:]): If the Find banner is already showing, call new focusOrHide method on it.
- FindBanner.h: declare new focusOrHide method
- FindBanner.m: (-[FindBanner _updateNextAndPreviousButtons]): new method, enables the Next/Previous buttons if readyToFind returns YES (-[FindBanner _makeSearchFieldFirstResponder]): new method, extracted from installIntoWebView (-[FindBanner installIntoWebView:]): now calls extracted method; also now calls _updateNextAndPreviousButtons (-[FindBanner controlTextDidChange:]): new method, calls _updateNextAndPreviousButtons (-[FindBanner _updateFindPasteboardFromSearchField]): renamed to start with underscore for consistency (though I didn't make all the other ones consistent yet) (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): updated for name change (-[FindBanner findFromSearchField:]): ditto (-[FindBanner focusOrHide]): new method, hides the banner if the search field is focused, otherwise focuses the search field. (Makes Command-F do what seems natural to me.)
- WebPageBanner.h: Declare _webView a BrowserWebView*, not just a WebView*. Replace #import of WebView.h with a @class declaration of BrowserWebView
- WebPageBanner.m: add #import of BrowserWebController.h (-[WebPageBanner installIntoWebView:]): change parameter from WebView* to BrowserWebView* to match superclass
2005-04-12 John Sullivan <sullivan@apple.com>
Added slider to Find Banner Settings window to control fading-outline duration.
Made Next and Previous buttons in Find banner highlight on Command-G and Command-Shift-G
Reviewed by Vicki.
- PreferenceKeys.h:
- Defaults.plist: new preference DebugFindOutlineDurationPreferenceKey
- CoachMark.m: (-[CoachMark initWithBounds:forView:]): Read the duration from preferences
- Debug/FindBannerSettings.nib: added Duration slider
- Debug/FindBannerSettingsController.h:
- Debug/FindBannerSettingsController.m: (-[FindBannerSettingsController takeDurationFrom:]): new method, sets preference from duration slider (-[FindBannerSettingsController updateViews]): sets slider value from preferences
- English.lproj/FindBanner.nib: Added key equivalents for Next and Previous buttons
2005-04-11 Kevin Decker <kdecker@apple.com>
Reviewed by John.
- BarBackground.h: Need to be able to specify a different bottom line color. Added ivar and method to do this.
- BarBackground.m: Ditto (+[BarBackground defaultBottomBorderLineColor]): Renamed method. (-[BarBackground drawRect:]): If bottom border color hasn't been specified, use the default. (-[BarBackground setBottomBorderColor:]): Added
- Debug/DebugUtilities.m: Created a toggle for a gradient filled version of our banner. (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleGradient:]): Added. (-[BrowserDocument validate_toggleGradient:]): Added.
- PreferenceKeys.h: Added DebugGradientBannerKey.
- Resources/Images/BannerBackground.tiff: Added.
- WebPageBanner.h:
- WebPageBanner.m: Checked user preferences for the gradient look. (-[WebPageBanner dealloc]): Deallocate the gradient NSImageView. (-[WebPageBanner _populateBannerViewFromNib:]): (-[WebPageBanner createBannerView]): Checked user preferences for the gradient look. Also adds a one pixel border to the bottom of the banner.
2005-04-11 John Sullivan <sullivan@apple.com>
Added Debug-menu window to tweak with Find in Page settings. The new initial
setting is a bright red fading round rect. I think this works much better than
the "Alternate Selection Color" fading round rect that was used before (still a
choice in the settings window).
Reviewed by Chris.
- PreferenceKeys.h:
- Defaults.plist: New NSUserDefaults keys: DebugUseFindOutlinePreferenceKey DebugFindOutlineIsSelectionColorPreferenceKey DebugFindOutlineIsAlternateSelectionColorPreferenceKey DebugFindOutlineCustomColorPreferenceKey
- CoachMark.m: (-[CoachMark initWithBounds:forView:]): just added a comment
- CoachMarkView.m: (-[CoachMarkView _color]): new method, determines color by checking various new preferences (-[CoachMarkView drawRect:]): call new method
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add "Show Find Banner Settings" item (-[BrowserDocument showFindBannerSettings:]): new method, opens Find Banner Settings window
- Debug/FindBannerSettings.nib: Added. Nib for Find Banner Settings window. I'll be adding more stuff to this, but for now it has a checkbox for drawing the fading outlines, and a pop-up menu to choose a color.
- Debug/FindBannerSettingsController.h: Added.
- Debug/FindBannerSettingsController.m: Added. (+[FindBannerSettingsController sharedController]): new method, returns single instance (-[FindBannerSettingsController windowNibName]): returns name of nib file (-[FindBannerSettingsController colorFromPopUp]): new method, determines an NSColor from the selected item in the popup menu (-[FindBannerSettingsController selectOtherColor:]): new method, used by "Other..." item (-[FindBannerSettingsController setOutlineColorFromSelectedItem]): new method, sets the new preference based on the selected item in the popup (-[FindBannerSettingsController colorPickedInColorPanel:]): new method, updates the "Other" color (-[FindBannerSettingsController takeOutlineColorFrom:]): new method, callback from selected menu item in color menu (-[FindBannerSettingsController updateColorViews]): new method, synchronizes the color menu and with prefs values (-[FindBannerSettingsController toggleUseFadingOutline:]): new method, toggles pref that controls fading outline (CoachMark) (-[FindBannerSettingsController updateViews]): new method, just calls updateColorViews (will do more later) (-[FindBannerSettingsController windowDidLoad]): new method, sets up color menu and views
- FindBanner.m: (-[FindBanner _callAttentionToSelectedText]): new method, extracted from _findWithDirection:... Now respects new preference. (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): Now calls extracted method.
- WebBrowser.pbproj/project.pbxproj: updated for new files
2005-04-08 John Sullivan <sullivan@apple.com>
First cut at using the fading-oval approach to highlighting the found text. Kinda cool;
probably needs some tweaking.
Reviewed by Kevin.
- CoachMark.m: (getHostTime): remove cast to eliminate compiler warning
- FindBanner.m: (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): hackily determine the selection rect after finding text, and slap a fading oval around it.
2005-04-08 John Sullivan <sullivan@apple.com>
Checked in the CoachMark classes stolen from Preview.
I'll be using these as a Find in Page feedback experiment.
I checked these files in verbatim, and they aren't yet
used anywhere.
- CoachMark.h: Added.
- CoachMark.m: Added. (-[CoachMark initWithBounds:forView:]): (-[CoachMark dealloc]): (-[CoachMark width]): (-[CoachMark setWidth:]): (-[CoachMark duration]): (-[CoachMark setDuration:]): (-[CoachMark fractionComplete]): (-[CoachMark invalidate]): (getHostTime): (-[CoachMark redrawTimer:]):
- CoachMarkController.h: Added.
- CoachMarkController.m: Added. (+[CoachMarkController sharedCoachMarkController]): (-[CoachMarkController init]): (-[CoachMarkController dealloc]): (-[CoachMarkController addCoachMarkWithBounds:forView:]): (-[CoachMarkController coachMarkExpired:]):
- CoachMarkView.h: Added.
- CoachMarkView.m: Added. (-[CoachMarkView dealloc]): (-[CoachMarkView setCoach:]): (-[CoachMarkView width]): (-[CoachMarkView setWidth:]): (-[CoachMarkView roundedRect:withRadius:]): (-[CoachMarkView drawRect:]):
- WebBrowser.pbproj/project.pbxproj: updated for new files
2005-04-07 John Sullivan <sullivan@apple.com>
Fixed problem where each letter typed in find-as-you-type would jump to
the next instance of the text to find, instead of extending the selection
when appropriate.
Reviewed by Dave Hyatt.
- FindBanner.m: (-[FindBanner _doSearchForString:direction:caseSensitive:findInSelection:inTarget:]): added findInSelection parameter, passes through to WebKit (-[FindBanner _findWithDirection:caseSensitive:findInSelection:]): added findInSelection parameter, passes through to _doSearchForString: (-[FindBanner findFromSearchField:]): pass YES for findInSelection parameter (-[FindBanner findNext:]): pass NO for findInSelection parameter (-[FindBanner findPrevious:]): pass NO for findInSelection parameter
2005-04-07 John Sullivan <sullivan@apple.com>
First draft at search-as-you-type using the Find banner. There are some
obvious flaws, perhaps the most obvious being that adding a letter will start
the new search from the end of the current selection. But it works well enough
to start seeing the flaws, so that's a good thing.
Reviewed by Darin.
- BrowserDocument.h: declare findNext: and findPrevious: methods
- BrowserDocument.m: (-[BrowserDocument findNext:]): call through to FindBanner (or AppController if the pref is set to not use banner) (-[BrowserDocument findPrevious:]): ditto (-[BrowserDocument validateUserInterfaceItem:]): findNext: and findPrevious: are enabled if the Find banner returns YES for readyToFind
- BrowserWebController.h: the findInPageBanner is now declared as a FindBanner*
- BrowserWebController.m: (-[BrowserWebView findInPageBanner]): now returns a FindBanner* rather than just a WebPageBanner* (-[BrowserWebView maintainsInactiveSelection]): override this new WebView method to return YES if the first responder is in a banner on the page.
- English.lproj/FindBanner.nib: Turn off the "sendsWholeSearchString" bit so the searching is as-you-type
- English.lproj/MainMenu.nib: make "Find Again" and "Find Previous" target the first responder rather than the AppController, so BrowserDocument can intercept them.
- FindBanner.h: made -readyToFind public so it can be used in -[BrowserDocument validateUserInterfaceItem:]
- FindBanner.m: (-[FindBanner _findWithDirection:caseSensitive:]): remove the #if guards around the code that forces the first responder to stay in the textfield as you type.
2005-04-06 John Sullivan <sullivan@apple.com>
Refactored the code that populates the Find banner from the nib so
that other WebPageBanners can do the same thing. Kevin will take
advantage of this shortly.
Reviewed by Maciej.
- WebPageBanner.h: added bannerContents IBOutlet and -bannerNibName method, both used in nib loading
- WebPageBanner.m: (-[WebPageBanner bannerNibName]): new method, returns nil, subclasses can override to use built-in view population method (-[WebPageBanner _populateBannerViewFromNib:]): new method, generalized from FindBanner code, extracts all the subviews of a given nib object and sticks 'em in the banner (-[WebPageBanner createBannerView]): now calls _populateBannerViewFromNib:
- English.lproj/FindBanner.nib: wired up new bannerContents outlet
- FindBanner.m: removed override of createBannerView since superclass does this now (-[FindBanner bannerNibName]): implement this one-liner in its place
2005-04-06 John Sullivan <sullivan@apple.com>
First cut at making the Find Banner actually find. I copied/pasted/simplified
code from the existing Find dialog (which would eventually go away if we
adopt this new model, so I didn't feel guilty about duplicating the code).
I haven't cleaned this all up nicely yet, but I wanted to get this semi-working
version in. It's only semi-working because it doesn't do find-as-you-type, only
find-when-you-hit-return. That's because the found text is only drawn as selected
when the webview is first responder, which makes find-as-you-type useless. I'll
add WebKit support for showing the selection when not first responder soon, and
then make find-as-you-type work.
Reviewed by Kevin.
- English.lproj/FindBanner.nib: Added. Contains the views that will be in the banner.
- WebPageBanner.m: (-[WebPageBanner createBannerView]): used #defines for initial width and standard height for clarity (-[WebPageBanner installIntoWebView:]): removed obsolete comment
- FindBanner.h: Added.
- FindBanner.m: Added. (-[FindBanner createBannerView]): overridden to install subviews from nib (-[FindBanner installIntoWebView:]): overridden to set focus on search field
The following methods are all copied/pasted from FindPanelController,
then tweaked (mostly simplified) to work here.
(-[FindBanner updateFindPasteboardFromSearchField]):
(-[FindBanner _updateSearchFieldFromFindPasteboard]):
(-[FindBanner _searchString]):
(-[FindBanner _searchTarget]):
(-[FindBanner _doSearchForString:direction:caseSensitive:inTarget:]):
(-[FindBanner readyToFind]):
(-[FindBanner _setStatus:]):
(-[FindBanner _findWithDirection:caseSensitive:]):
(-[FindBanner findFromSearchField:]):
(-[FindBanner findNext:]):
(-[FindBanner findPrevious:]):
- BrowserWebController.m: (-[BrowserWebView findInPageBanner]): Create a FindBanner, not just a generic WebPageBanner. Took out the temporary hack contents.
- WebBrowser.pbproj/project.pbxproj: updated for new files
2005-04-05 John Sullivan <sullivan@apple.com>
Some work in the direction of making Find in the Edit menu
use the Find banner. The Debug menu now has a toggle item
that controls whether Find in Page (command-F) uses the
banner or not. I've left the Find dialog in for now so we
can compare behaviors easily.
Reviewed by Kevin.
- PreferenceKeys.h: new preference key to control whether Command-F "Find" uses Find bar
- AppController.h: declare NSUserInterfaceValidations protocol so other code can call through to [AppController validateUserInterfaceItem:] without making the compiler upset.
- AppController.m: (-[AppController validateUserInterfaceItem:]): Reset menu title and state to the old as-in-nib versions ("Find�, unchecked)
- BrowserDocument.h: declare showFindPanel: IBAction
- BrowserDocument.m: (-[BrowserDocument showFindPanel:]): if the new pref isn't set, just call through to AppController. if it is, toggle the Find panel (using code formerly in DebugUtilities) (-[BrowserDocument validateUserInterfaceItem:]): When Find banner is not showing, use "Find in Page�, unchecked. When Find banner is showing, use "Find in Page", checked. Probably we can come up with something less weird.
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): remove menu item for toggling Find bar; add menu item for toggling preference that controls whether Command-F "Find" uses Find bar (-[BrowserDocument toggleUseFindBanner:]): new method, toggles preference (-[BrowserDocument validate_toggleUseFindBanner:]): new method, checks or unchecks according to preference
- English.lproj/Localizable.strings: updated for these changes
- English.lproj/MainMenu.nib: changed target of "Find� menu item to be FirstResponder rather than AppController
2005-04-05 John Sullivan <sullivan@apple.com>
More work on banner mechanism. Made each BrowserWebView have its own
Find In Page banner (no content yet), in order to enable hiding that
particular banner rather than hiding whatever banner happened to be
showing. Renamed some methods and variables for clarity.
Reviewed by Kevin.
- BrowserWebController.h: added _findInPageBanner, renamed _banner -> _currentBanner; added -findInPageBanner, renamed -banner -> -currentBanner and -setBanner: -> -setCurrentBanner:
- BrowserWebController.m: (-[BrowserWebView dealloc]): updated for renamings, and now releases _findInPageBanner (-[BrowserWebView findInPageBanner]): new method, lazily creates banner that will be used for Find in Page (-[BrowserWebView currentBanner]): updated for renamings (-[BrowserWebView setCurrentBanner:]): ditto
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): changed Show/Hide Test Banner to Show/Hide Find Banner (this will go away entirely when I hook the Find banner up to the existing Find menu item) (-[BrowserDocument toggleFindInPageBanner:]): renamed from toggleBanner:; the code to create the banner is now in BrowserWebView. This method now checks for the specific banner rather than hiding whatever banner is showing. (-[BrowserDocument validate_toggleFindInPageBanner:]): updated for renamings, and now checks for the specific banner
2005-04-04 John Sullivan <sullivan@apple.com>
Reviewed by Maciej.
- BrowserTabViewItem.h: added _webView ivar
- BrowserTabViewItem.m: (-[BrowserTabViewItem setView:]): find webView inside passed-in view, stash in ivar (-[BrowserTabViewItem webView]): return cached webview
- BrowserWindowController.m: (-[BrowserWindowController setUpTabForWebView:addToRightSide:]): make tab item's view be a container holding the webview, rather than the webview itself. That way we can insert the banner later in a per-tab manner.
- Debug/DebugUtilities.m: (-[BrowserDocument toggleBanner:]): don't use a static banner anymore since there can be more than one.
- WebPageBanner.m: (-[WebPageBanner installIntoWebView:]): added support for unflipped parent view, works with generic NSView. I could have flipped the container view created in the tab, but this way is more general. (-[WebPageBanner uninstallFromWebView]): ditto
2005-04-04 John Sullivan <sullivan@apple.com>
To make the blue banners work with tabs, I'll have to make the BrowserTabItem's view
not be the webView itself but rather a new container view that holds the webView and
optionally a banner. This checkin refactors the code that assumes that
[BrowserTabItem view] is a webView to not assume that. I'll make the actual view
hierarchy change in a separate checkin.
- BrowserTabViewItem.h: Made -webView a public method. This method was implemented but not public and not used internally, so I guess it was either going to be public or used to be public. But regardless of the past, I wanted it public again, so public it shall be.
- BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): replaced code that casts [BrowserTabViewItem view] to a WebView with code to call [BrowserTabViewItem webView], since soon [BrowserTabViewItem view] won't be a webView. (-[BrowserWindowController updateKeyboardLoop]): (-[BrowserWindowController updateLabelForTab:evenIfTabBarHidden:]): (-[BrowserWindowController toggleTabBarWithAnimation:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController closeOtherTabs:]): (-[BrowserWindowController reloadTabsMatchingURLs:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebView:]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController reloadParentallyRestrictedFrames]): (-[BrowserWindowController replaceTabSwitcher:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController tabBarView:performDragOperationForTabViewItem:URL:]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]): (-[NSTabView makeWebViewsPerformSelector:withObject:]): ditto
- WebPageBanner.m: (-[WebPageBanner standardBannerColor]): Made #defines for the RGB values
2005-04-04 John Sullivan <sullivan@apple.com>
- first cut at transient blue bar to be used for page metadata, find, and pop-up banner experiments. It doesn't do anything yet other than show and hide itself on demand. It doesn't yet work with multiple tabs (I'll fix that next.)
I made the bar use the blue color that Kevin extracted from Mail's mailbox
tableview. To see a demo, choose "Show Banner" and then "Hide Banner" from
the Debug menu.
Reviewed by Kevin. (Reviews not strictly required for experimental checkins,
but it's never a bad idea.)
- WebPageBanner.h: Added.
- WebPageBanner.m: Added. (-[WebPageBanner init]): calls createBannerView (-[WebPageBanner dealloc]): cleans up (-[WebPageBanner bannerView]): returns ivar (-[WebPageBanner standardBannerColor]): returns standard color in case subclasses want to use it in a createBannerView override (-[WebPageBanner createBannerView]): creates new BarBackground with the standard color. Clients can add subviews to this view, or could subclass and override to create the view a completely different way. (-[WebPageBanner installIntoWebView:]): squeezes itself above the webview (no animation yet) (-[WebPageBanner uninstallFromWebView]): removes itself and restores webview (no animation yet)
- BrowserWebController.h:
- BrowserWebController.m: (-[BrowserWebView dealloc]): release _banner ivar (-[BrowserWebView banner]): returns ivar (-[BrowserWebView setBanner:]): sets the banner; call with nil to hide the banner. Currently only one banner can be showing at a time.
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item to test banner (-[BrowserDocument toggleBanner:]): show or hide banner (-[BrowserDocument validate_toggleBanner:]): change menu item text to "Show Banner" or "Hide Banner"
- WebBrowser.pbproj/project.pbxproj: updated for new class files
- 10:11 AM Changeset in webkit [9165] by
-
- 53 edits in trunk/WebCore
Reviewed by Maciej (except for some parts outside the ECMA directory).
- switch KJS wrappers over to using the DOM impl. classes rather than using the DOM wrappers; will allow us to not even compile the DOM wrappers and make the code smaller
- khtml/css/css_valueimpl.h: Added CSSStyleDeclarationImpl::isPropertyName, removed CSSStyleDeclarationImpl::propertyID.
- khtml/css/css_valueimpl.cpp: (DOM::propertyID): Added. Gets property ID given a DOM string. Replaces the previous version that had hacks that we want to leave in the JS wrapper for now. (DOM::CSSStyleDeclarationImpl::isPropertyName): Added.
- khtml/css/cssproperties.in: Fixed up comments.
- khtml/css/makeprop: Added new maxCSSPropertyNameLength constant, used for buffer size in the propertyID function.
- khtml/dom/dom2_events.h: Added handleEventImpl, making it easier to call handleEvent in a way that works either with or without the C++ DOM wrappers.
- khtml/dom/dom2_events.cpp: (EventListener::handleEventImpl): Added.
- khtml/dom/dom2_views.cpp: Added now-needed include.
- khtml/dom/dom_doc.cpp: Added now-needed include.
- khtml/dom/dom_element.cpp: Tweaked includes.
- khtml/editing/htmlediting.cpp: Removed now-unneeded include.
- khtml/html/html_baseimpl.cpp: Ditto.
- khtml/html/html_formimpl.h: Ditto.
- khtml/rendering/render_form.h: Ditto.
- khtml/rendering/render_style.h: Ditto.
- khtml/xml/dom2_eventsimpl.cpp: Ditto.
- khtml/xml/dom2_viewsimpl.h: Ditto.
- khtml/xml/dom_elementimpl.h: Ditto.
- khtml/xml/dom_stringimpl.h: Ditto.
- kwq/DOM.mm: Ditto.
- kwq/DOMHTML.mm: Ditto.
- khtml/khtml_part.cpp: Tweaked incluudes.
- khtml/khtmlpart_p.h: Ditto.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Change to use DOM impl. rather than C++ DOM.
- khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocumentType): Disabled the calls to the not-implemented name checks in the C++ DOM wrappers. If we add name changes, we'll want them inside the impl, not in the wrappers. (DOMImplementationImpl::createDocument): Ditto.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkSetPrefix): Ditto.
- khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture): (KJS::KJS::ValueToVariant): (KJS::setDOMException):
- khtml/ecma/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator): (KJS::DOMExceptionTranslator::~DOMExceptionTranslator): (KJS::DOMExceptionTranslator::operator int &): (KJS::cacheGlobalObject):
- khtml/ecma/kjs_css.cpp: (KJS::cssPropertyName): (KJS::isCSSPropertyName): (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (KJS::DOMCSSStyleDeclaration::~DOMCSSStyleDeclaration): (KJS::DOMCSSStyleDeclaration::hasProperty): (KJS::DOMCSSStyleDeclaration::tryGet): (KJS::DOMCSSStyleDeclaration::tryPut): (KJS::DOMCSSStyleDeclarationProtoFunc::tryCall): (KJS::getDOMCSSStyleDeclaration): (KJS::DOMStyleSheet::~DOMStyleSheet): (KJS::DOMStyleSheet::getValueProperty): (KJS::DOMStyleSheet::tryPut): (KJS::getDOMStyleSheet): (KJS::DOMStyleSheetList::~DOMStyleSheetList): (KJS::DOMStyleSheetList::tryGet): (KJS::getDOMStyleSheetList): (KJS::DOMStyleSheetListFunc::tryCall): (KJS::DOMMediaList::DOMMediaList): (KJS::DOMMediaList::~DOMMediaList): (KJS::DOMMediaList::tryGet): (KJS::DOMMediaList::tryPut): (KJS::getDOMMediaList): (KJS::KJS::DOMMediaListProtoFunc::tryCall): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheet::tryGet): (KJS::DOMCSSStyleSheetProtoFunc::tryCall): (KJS::DOMCSSRuleList::~DOMCSSRuleList): (KJS::DOMCSSRuleList::tryGet): (KJS::DOMCSSRuleListFunc::tryCall): (KJS::getDOMCSSRuleList): (KJS::DOMCSSRule::~DOMCSSRule): (KJS::DOMCSSRule::classInfo): (KJS::DOMCSSRule::tryGet): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSRule::putValue): (KJS::DOMCSSRuleFunc::tryCall): (KJS::getDOMCSSRule): (KJS::DOMCSSValue::~DOMCSSValue): (KJS::DOMCSSValue::tryGet): (KJS::DOMCSSValue::tryPut): (KJS::getDOMCSSValue): (KJS::DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (KJS::DOMCSSPrimitiveValue::tryGet): (KJS::DOMCSSPrimitiveValueProtoFunc::tryCall): (KJS::DOMCSSValueList::DOMCSSValueList): (KJS::DOMCSSValueList::tryGet): (KJS::DOMCSSValueListFunc::tryCall): (KJS::DOMRGBColor::getValueProperty): (KJS::getDOMRGBColor): (KJS::DOMRect::~DOMRect): (KJS::DOMRect::getValueProperty): (KJS::getDOMRect): (KJS::DOMCounter::~DOMCounter): (KJS::DOMCounter::getValueProperty): (KJS::getDOMCounter):
- khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleDeclaration::impl): (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheet::impl): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMStyleSheetList::impl): (KJS::DOMMediaList::impl): (KJS::DOMCSSStyleSheet::): (KJS::DOMCSSRuleList::DOMCSSRuleList): (KJS::DOMCSSRuleList::impl): (KJS::DOMCSSRule::DOMCSSRule): (KJS::DOMCSSRule::impl): (KJS::DOMCSSValue::DOMCSSValue): (KJS::DOMCSSValue::impl): (KJS::DOMCSSValueList::): (KJS::DOMRGBColor::DOMRGBColor): (KJS::DOMRect::DOMRect): (KJS::DOMCounter::DOMCounter):
- khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeListFunc::): (KJS::DOMNode::DOMNode): (KJS::DOMNode::toBoolean): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValue): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNode::setListener): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::tryCall): (KJS::toNode): (KJS::DOMNodeList::~DOMNodeList): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::tryGet): (KJS::DOMNodeList::tryCall): (KJS::DOMNodeListFunc::tryCall): (KJS::DOMAttr::DOMAttr): (KJS::DOMAttr::getValueProperty): (KJS::DOMAttr::putValue): (KJS::toAttr): (KJS::DOMDocument::DOMDocument): (KJS::DOMDocument::~DOMDocument): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValue): (KJS::DOMDocumentProtoFunc::tryCall): (KJS::DOMElement::DOMElement): (KJS::DOMElement::tryGet): (KJS::DOMElementProtoFunc::tryCall): (KJS::toElement): (KJS::DOMDOMImplementation::DOMDOMImplementation): (KJS::DOMDOMImplementation::~DOMDOMImplementation): (KJS::DOMDOMImplementationProtoFunc::tryCall): (KJS::DOMDocumentType::DOMDocumentType): (KJS::DOMDocumentType::getValueProperty): (KJS::toDocumentType): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMap::~DOMNamedNodeMap): (KJS::DOMNamedNodeMap::tryGet): (KJS::DOMNamedNodeMapProtoFunc::tryCall): (KJS::DOMProcessingInstruction::DOMProcessingInstruction): (KJS::DOMProcessingInstruction::getValueProperty): (KJS::DOMProcessingInstruction::tryPut): (KJS::DOMNotation::DOMNotation): (KJS::DOMNotation::getValueProperty): (KJS::DOMEntity::DOMEntity): (KJS::DOMEntity::getValueProperty): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getDOMNode): (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject): (KJS::getDOMNodeList): (KJS::getDOMDOMImplementation): (KJS::getNodeConstructor): (KJS::getDOMExceptionConstructor): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::tryGet): (KJS::DOMCharacterData::DOMCharacterData): (KJS::DOMCharacterData::getValueProperty): (KJS::DOMCharacterData::tryPut): (KJS::DOMCharacterDataProtoFunc::tryCall): (KJS::DOMText::DOMText): (KJS::DOMTextProtoFunc::tryCall):
- khtml/ecma/kjs_dom.h: (KJS::DOMNode::impl): (KJS::DOMNodeList::DOMNodeList): (KJS::DOMNodeList::impl): (KJS::DOMDOMImplementation::impl): (KJS::DOMNamedNodeMap::impl):
- khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::handleEvent): (KJS::getNodeEventListener): (KJS::DOMEvent::DOMEvent): (KJS::DOMEvent::~DOMEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEvent::putValue): (KJS::DOMEventProtoFunc::tryCall): (KJS::getDOMEvent): (KJS::toEvent): (KJS::DOMUIEvent::DOMUIEvent): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMUIEventProtoFunc::tryCall): (KJS::DOMMouseEvent::DOMMouseEvent): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::tryCall): (KJS::DOMKeyboardEvent::DOMKeyboardEvent): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::DOMKeyboardEventProtoFunc::tryCall): (KJS::DOMMutationEvent::DOMMutationEvent): (KJS::DOMMutationEvent::getValueProperty): (KJS::DOMMutationEventProtoFunc::tryCall): (KJS::DOMWheelEvent::DOMWheelEvent): (KJS::DOMWheelEvent::getValueProperty): (KJS::ClipboardProtoFunc::tryCall):
- khtml/ecma/kjs_events.h: (KJS::DOMEvent::impl): (KJS::DOMUIEvent::): (KJS::DOMMouseEvent::): (KJS::DOMKeyboardEvent::): (KJS::DOMMutationEvent::):
- khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::HTMLDocument): (KJS::HTMLDocument::hasProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLDocument::putValue): (KJS::KJS::HTMLElement::classInfo): (KJS::HTMLElement::HTMLElement): (KJS::KJS::HTMLElement::tryGet): (KJS::KJS::HTMLElement::implementsCall): (KJS::KJS::HTMLElement::call): (KJS::KJS::HTMLElement::getValueProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLElement::toString): (KJS::getForm): (KJS::KJS::HTMLElement::pushEventHandlerScope): (KJS::KJS::HTMLElementFunction::tryCall): (KJS::KJS::HTMLElement::tryPut): (KJS::HTMLElement::putValue): (KJS::toHTMLElement): (KJS::toHTMLTableCaptionElement): (KJS::toHTMLTableSectionElement): (KJS::HTMLCollection::HTMLCollection): (KJS::HTMLCollection::~HTMLCollection): (KJS::KJS::HTMLCollection::tryGet): (KJS::KJS::HTMLCollection::tryCall): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::KJS::HTMLCollectionProtoFunc::tryCall): (KJS::HTMLSelectCollection::HTMLSelectCollection): (KJS::KJS::HTMLSelectCollection::tryGet): (KJS::KJS::HTMLSelectCollection::tryPut): (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::OptionConstructorImp::construct): (KJS::ImageConstructorImp::ImageConstructorImp): (KJS::ImageConstructorImp::construct): (KJS::Image::notifyFinished): (KJS::Image::Image): (KJS::KJS::Context2DFunction::tryCall): (KJS::): (KJS::colorRefFromValue): (KJS::colorFromValue): (KJS::Context2D::putValue): (KJS::Context2D::Context2D): (KJS::Context2D::mark): (KJS::GradientFunction::tryCall): (KJS::ImagePattern::tryGet): (KJS::getHTMLCollection): (KJS::getSelectHTMLCollection):
- khtml/ecma/kjs_html.h: (KJS::HTMLDocument::): (KJS::HTMLElement::): (KJS::HTMLCollection::impl):
- khtml/ecma/kjs_navigator.cpp:
- khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): (KJSProxyImpl::finishedWithEvent):
- khtml/ecma/kjs_proxy.h:
- khtml/ecma/kjs_range.cpp: (KJS::DOMRange::DOMRange): (KJS::DOMRange::~DOMRange): (KJS::DOMRange::tryGet): (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::tryCall): (KJS::getDOMRange): (KJS::RangeConstructor::tryGet): (KJS::getRangeConstructor): (KJS::toRange):
- khtml/ecma/kjs_range.h: (KJS::DOMRange::impl):
- khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::DOMNodeIterator): (KJS::DOMNodeIterator::~DOMNodeIterator): (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::tryCall): (KJS::getDOMNodeIterator): (KJS::DOMNodeFilter::DOMNodeFilter): (KJS::DOMNodeFilter::~DOMNodeFilter): (KJS::DOMNodeFilterProtoFunc::tryCall): (KJS::getDOMNodeFilter): (KJS::toNodeFilter): (KJS::DOMTreeWalker::DOMTreeWalker): (KJS::DOMTreeWalker::~DOMTreeWalker): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalker::tryPut): (KJS::DOMTreeWalkerProtoFunc::tryCall): (KJS::getDOMTreeWalker): (KJS::JSNodeFilterCondition::acceptNode):
- khtml/ecma/kjs_traversal.h: (KJS::DOMNodeIterator::impl): (KJS::DOMNodeFilter::impl): (KJS::DOMTreeWalker::impl):
- khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::~DOMAbstractView): (KJS::DOMAbstractView::tryGet): (KJS::DOMAbstractViewFunc::tryCall): (KJS::getDOMAbstractView): (KJS::toAbstractView):
- khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::DOMAbstractView): (KJS::DOMAbstractView::impl):
- khtml/ecma/kjs_window.cpp: (KJS::Window::get): (KJS::Window::hasProperty): (KJS::Window::put): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::setCurrentEvent): (KJS::WindowFunc::tryCall): (KJS::Location::put): (KJS::LocationFunc::tryCall): (KJS::Selection::get): (KJS::SelectionFunc::tryCall):
- khtml/ecma/kjs_window.h:
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp): (KJS::XMLHttpRequestConstructorImp::~XMLHttpRequestConstructorImp): (KJS::XMLHttpRequestConstructorImp::construct): (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequestProtoFunc::tryCall):
- khtml/ecma/xmlhttprequest.h:
- khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::tryCall):
- khtml/ecma/xmlserializer.h:
- kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
- kwq/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
- 12:47 AM Changeset in webkit [9164] by
-
- 3 edits in trunk/WebCore
Improve the display of apple.com. innerWidth and innerHeight refer to the size of the visible view and
so they do not need to do a layout in order to yield correct values from JS. Removing this stops an
early layout and paint before the apple.com images are typically loaded.
This is an improvement of the fix for wired.com's FOUC. For that bug I eliminated the need to ignore pending
stylesheets, but now I'm going further and just eliminating the layout all together. This means that the old
updateLayout function can be reverted to how it was before the wired.com fix.
Reviewed by john
- khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
- khtml/ecma/kjs_window.h:
May 11, 2005:
- 9:00 PM Changeset in webkit [9163] by
-
- 6 edits6 adds in trunk/WebCore
Reviewed by Kevin.
- split some more individual classes out of htmlediting.cpp (CompositeEditcommand, AppendnodeCommand, ApplyStyleCommand)
Also moves StyleChange directly into ApplyStyleCommand
implementation file, it doesn't need to be in a header at all.
- WebCore.pbproj/project.pbxproj:
- khtml/editing/append_node_command.cpp: Added.
- khtml/editing/append_node_command.h: Added.
- khtml/editing/apply_style_command.cpp: Added.
- khtml/editing/apply_style_command.h: Added.
- khtml/editing/composite_edit_command.cpp: Added.
- khtml/editing/composite_edit_command.h: Added.
- khtml/editing/edit_command.cpp: Minor clean-ups.
- khtml/editing/edit_command.h:
- khtml/editing/htmlediting.cpp:
- khtml/editing/htmlediting.h:
- 6:16 PM Changeset in webkit [9162] by
-
- 4 edits6 adds in trunk
Reviewed by Darin.
fix for <rdar://problem/4061979> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp
- khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement): added a nil check for the document
- khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inDocument): added check for document in case the document has been destroyed before the node has been removed. A lot of code already assumes that if inDocument returns true, a document exists.
- layout-tests/fast/events/onload-re-entry.html: removed alert.
- layout-tests/fast/events/onload-re-entry-expected.txt: updated.
- layout-tests/fast/dom/attr_dead_doc-expected.txt: Added.
- layout-tests/fast/dom/attr_dead_doc.html: Added.
- layout-tests/fast/dom/resources/apple.gif: Added.
- layout-tests/fast/dom/resources/mozilla.gif: Added.
- layout-tests/fast/dom/resources/top.html: Added.
- 4:45 PM Changeset in webkit [9161] by
-
- 2 edits in trunk/WebCore/khtml/misc
Fix the newline error I made backing out changes to the .in files in misc.
May 10, 2005:
- 11:04 PM Changeset in webkit [9160] by
-
- 6 edits2 adds in trunk/WebCore
Reviewed by Kevin.
- start on splitting htmlediting.cpp into smaller files - pull EditCommand and EditCommandPtr out.
- WebCore.pbproj/project.pbxproj:
- khtml/editing/edit_command.cpp: Added.
- khtml/editing/edit_command.h: Added.
- khtml/editing/htmlediting.cpp: Took EditCommand and EditCommandPtr out.
- khtml/editing/htmlediting.h: Ditto.
- 10:56 PM Changeset in webkit [9159] by
-
- 2 edits in trunk/WebCore/khtml/misc
Back out unintentional additions to HTML attrs and tags.
- 10:49 PM Changeset in webkit [9158] by
-
- 33 edits in trunk/WebCore
Refactor the DOM so that the concept of class/style/id is no longer unique to HTML elements. This paves the way
for SVG and MathML elements to also support these capabilities. In addition the concept of presentational
attributes has also been factored out.
Reviewed by mjs
- khtml/css/css_ruleimpl.cpp: (CSSStyleRuleImpl::setDeclaration):
- khtml/css/cssstyleselector.cpp: (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::initElementAndPseudoState): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::locateSharedStyle): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::checkOneSelector):
- khtml/css/cssstyleselector.h:
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute): (HTMLIFrameElementImpl::parseMappedAttribute):
- khtml/html/html_baseimpl.h:
- khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseMappedAttribute): (HTMLHRElementImpl::parseMappedAttribute): (HTMLParagraphElementImpl::parseMappedAttribute): (HTMLMarqueeElementImpl::parseMappedAttribute):
- khtml/html/html_blockimpl.h:
- khtml/html/html_canvasimpl.cpp: (HTMLCanvasElementImpl::parseMappedAttribute):
- khtml/html/html_canvasimpl.h:
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::mapToEntry): (HTMLElementImpl::parseMappedAttribute): (HTMLElementImpl::addHTMLAlignment): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::toString):
- khtml/html/html_elementimpl.h:
- khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): (DOM::HTMLGenericFormElementImpl::parseMappedAttribute): (DOM::HTMLButtonElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::setType): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLLabelElementImpl::parseMappedAttribute): (DOM::HTMLSelectElementImpl::parseMappedAttribute): (DOM::HTMLKeygenElementImpl::parseMappedAttribute): (DOM::HTMLOptGroupElementImpl::parseMappedAttribute): (DOM::HTMLOptionElementImpl::parseMappedAttribute): (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): (DOM::HTMLIsIndexElementImpl::parseMappedAttribute):
- khtml/html/html_formimpl.h:
- khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::parseMappedAttribute): (HTMLLinkElementImpl::parseMappedAttribute): (HTMLMetaElementImpl::parseMappedAttribute): (HTMLStyleElementImpl::parseMappedAttribute):
- khtml/html/html_headimpl.h:
- khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseMappedAttribute): (HTMLMapElementImpl::parseMappedAttribute): (HTMLAreaElementImpl::parseMappedAttribute):
- khtml/html/html_imageimpl.h:
- khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::parseMappedAttribute): (DOM::HTMLBRElementImpl::parseMappedAttribute): (DOM::HTMLFontElementImpl::parseMappedAttribute):
- khtml/html/html_inlineimpl.h:
- khtml/html/html_listimpl.cpp: (DOM::HTMLUListElementImpl::parseMappedAttribute): (DOM::HTMLOListElementImpl::parseMappedAttribute): (DOM::HTMLLIElementImpl::parseMappedAttribute):
- khtml/html/html_listimpl.h:
- khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): (DOM::HTMLEmbedElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::parseMappedAttribute):
- khtml/html/html_objectimpl.h:
- khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTableElementImpl::additionalAttributeStyleDecl): (DOM::HTMLTableElementImpl::getSharedCellDecl): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableCellElementImpl::parseMappedAttribute): (DOM::HTMLTableColElementImpl::parseMappedAttribute): (DOM::HTMLTableCaptionElementImpl::parseMappedAttribute):
- khtml/html/html_tableimpl.h:
- khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
- khtml/misc/htmlattrs.in:
- khtml/misc/htmltags.in:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createAttribute): (DocumentImpl::createElementNS): (DocumentImpl::createHTMLElement):
- khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::cloneNode): (NamedAttrMapImpl::isMappedAttributeMap): (CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (StyledElementImpl::getMappedAttributeDecl): (StyledElementImpl::setMappedAttributeDecl): (StyledElementImpl::removeMappedAttributeDecl): (StyledElementImpl::invalidateStyleAttribute): (StyledElementImpl::updateStyleAttributeIfNeeded): (MappedAttributeImpl::~MappedAttributeImpl): (MappedAttributeImpl::clone): (m_mappedAttributeCount): (NamedMappedAttrMapImpl::clearAttributes): (NamedMappedAttrMapImpl::isMappedAttributeMap): (NamedMappedAttrMapImpl::declCount): (NamedMappedAttrMapImpl::mapsEquivalent): (NamedMappedAttrMapImpl::parseClassAttribute): (StyledElementImpl::StyledElementImpl): (StyledElementImpl::~StyledElementImpl): (StyledElementImpl::createAttribute): (StyledElementImpl::createInlineStyleDecl): (StyledElementImpl::destroyInlineStyleDecl): (StyledElementImpl::attributeChanged): (StyledElementImpl::mapToEntry): (StyledElementImpl::parseMappedAttribute): (StyledElementImpl::createAttributeMap): (StyledElementImpl::getInlineStyleDecl): (StyledElementImpl::style): (StyledElementImpl::additionalAttributeStyleDecl): (StyledElementImpl::getClassList): (isHexDigit): (toHex): (StyledElementImpl::addCSSProperty): (StyledElementImpl::addCSSStringProperty): (StyledElementImpl::addCSSImageProperty): (StyledElementImpl::addCSSLength): (StyledElementImpl::addCSSColor): (StyledElementImpl::createMappedDecl):
- khtml/xml/dom_elementimpl.h: (DOM::): (DOM::CSSMappedAttributeDeclarationImpl::CSSMappedAttributeDeclarationImpl): (DOM::CSSMappedAttributeDeclarationImpl::setMappedState): (DOM::MappedAttributeImpl::MappedAttributeImpl): (DOM::MappedAttributeImpl::decl): (DOM::MappedAttributeImpl::setDecl): (DOM::NamedMappedAttrMapImpl::getClassList): (DOM::NamedMappedAttrMapImpl::hasMappedAttributes): (DOM::NamedMappedAttrMapImpl::declRemoved): (DOM::NamedMappedAttrMapImpl::declAdded): (DOM::NamedMappedAttrMapImpl::attributeItem): (DOM::StyledElementImpl::isStyledElement): (DOM::StyledElementImpl::hasMappedAttributes): (DOM::StyledElementImpl::mappedAttributes): (DOM::StyledElementImpl::isMappedAttribute): (DOM::StyledElementImpl::inlineStyleDecl):
- khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isStyledElement):
- 7:10 PM Changeset in webkit [9157] by
-
- 14 edits in trunk/WebCore
Reviewed by Dave Hyatt.
No new layout tests needed.
- remove all remaining uses of QMIN/QMAX and KMIN/KMAX.
- kwq/KWQDef.h: Remove the macros.
Remove all use of the macros (and fix a few compile errors by changing the types of
some integer and floating point constants).
- khtml/css/cssparser.cpp: (CSSParser::parseColorFromValue):
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLColor):
- khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::parseHTMLAttribute):
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::nearestFloatBottom): (khtml::RenderBlock::calcMinMaxWidth):
- khtml/rendering/render_flow.cpp: (RenderFlow::paintOutlineForLine):
- khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderFieldset::layoutLegend): (RenderFileButton::calcMinMaxWidth): (RenderSelect::layout): (RenderTextArea::calcMinMaxWidth):
- khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
- khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget):
- khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
- khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): (AutoTableLayout::calcEffectiveWidth):
- 5:58 PM Changeset in webkit [9156] by
-
- 60 edits in trunk/WebCore
Reviewed by Chris Blumenberg.
- next pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step adds still more member functions missing from the DOM impl. and
changes some of the C++ and Objective-C DOM to call the new ones; also
changes various places that use the C++ DOM to use the DOM impl. instead)
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- khtml/css/css_computedstyle.h:
- khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::cssRules):
- khtml/css/css_stylesheetimpl.h:
- khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyCSSValue): (DOM::CSSStyleDeclarationImpl::getPropertyValue): (DOM::CSSStyleDeclarationImpl::getPropertyPriority): (DOM::CSSStyleDeclarationImpl::setProperty): (DOM::CSSStyleDeclarationImpl::removeProperty): (DOM::CSSMutableStyleDeclarationImpl::getPropertyValue): (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::operator==): (DOM::CSSStyleDeclarationImpl::propertyID):
- khtml/css/css_valueimpl.h: (DOM::CSSValueImpl::setCssText): (DOM::CSSPrimitiveValueImpl::getDashboardRegionValue):
- khtml/dom/css_rule.cpp:
- khtml/dom/css_rule.h:
- khtml/dom/css_stylesheet.h: (DOM::CSSException::):
- khtml/dom/css_value.cpp: (DOM::CSSStyleDeclaration::getPropertyValue): (DOM::CSSStyleDeclaration::getPropertyCSSValue): (DOM::CSSStyleDeclaration::removeProperty): (DOM::CSSStyleDeclaration::getPropertyPriority): (DOM::CSSStyleDeclaration::setProperty):
- khtml/dom/css_value.h:
- khtml/dom/dom2_events.cpp: (EventListener::handleEvent):
- khtml/dom/dom2_events.h:
- khtml/dom/dom2_traversal.h:
- khtml/dom/dom_doc.cpp: (DOM::DOMImplementation::createHTMLDocument): (DOM::DOMImplementation::createCSSStyleSheet): (DOM::Document::doctype): (DOM::Document::createAttribute): (DOM::Document::createAttributeNS): (DOM::Document::queryCommandValue): (DOM::Document::handle):
- khtml/dom/dom_doc.h:
- khtml/dom/dom_element.cpp: (Attr::name): (Attr::value): (Element::getAttribute): (Element::setAttribute): (Element::removeAttribute): (Element::getAttributeNode): (Element::setAttributeNode): (Element::removeAttributeNode): (Element::getElementsByTagName): (Element::getElementsByTagNameNS): (Element::getAttributeNS): (Element::setAttributeNS): (Element::removeAttributeNS): (Element::getAttributeNodeNS): (Element::setAttributeNodeNS): (Element::hasAttribute): (Element::hasAttributeNS): (Element::style):
- khtml/dom/dom_exception.h:
- khtml/dom/dom_misc.cpp: (DOM::DomShared::deleteMe):
- khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
- khtml/dom/dom_node.cpp: (NamedNodeMap::getNamedItemNS): (NamedNodeMap::setNamedItemNS): (NamedNodeMap::removeNamedItemNS): (Node::ownerDocument): (Node::hasAttributes): (Node::isSupported): (Node::addEventListener): (Node::removeEventListener):
- khtml/dom/dom_node.h:
- khtml/dom/html_document.cpp: (HTMLDocument::setTitle): (HTMLDocument::completeURL): (HTMLDocument::getElementsByName):
- khtml/dom/html_element.cpp: (HTMLElement::setInnerHTML): (HTMLElement::setInnerText): (HTMLElement::setOuterHTML): (HTMLElement::setOuterText):
- khtml/dom/html_form.cpp: (HTMLLabelElement::form): (HTMLSelectElement::setValue): (HTMLSelectElement::options): (HTMLOptionElement::setValue):
- khtml/dom/html_inline.cpp: (HTMLAnchorElement::accessKey): (HTMLAnchorElement::setAccessKey): (HTMLAnchorElement::charset): (HTMLAnchorElement::setCharset): (HTMLAnchorElement::coords): (HTMLAnchorElement::setCoords): (HTMLAnchorElement::href): (HTMLAnchorElement::setHref): (HTMLAnchorElement::hreflang): (HTMLAnchorElement::setHreflang): (HTMLAnchorElement::name): (HTMLAnchorElement::setName): (HTMLAnchorElement::rel): (HTMLAnchorElement::setRel): (HTMLAnchorElement::rev): (HTMLAnchorElement::setRev): (HTMLAnchorElement::shape): (HTMLAnchorElement::setShape): (HTMLAnchorElement::tabIndex): (HTMLAnchorElement::setTabIndex): (HTMLAnchorElement::target): (HTMLAnchorElement::setTarget): (HTMLAnchorElement::type): (HTMLAnchorElement::setType): (HTMLAnchorElement::blur): (HTMLAnchorElement::focus): (HTMLBRElement::clear): (HTMLBRElement::setClear): (HTMLFontElement::color): (HTMLFontElement::setColor): (HTMLFontElement::face): (HTMLFontElement::setFace): (HTMLFontElement::size): (HTMLFontElement::setSize): (HTMLModElement::cite): (HTMLModElement::setCite): (HTMLModElement::dateTime): (HTMLModElement::setDateTime): (HTMLQuoteElement::cite): (HTMLQuoteElement::setCite):
- khtml/dom/html_misc.cpp: (HTMLCollection::HTMLCollection): (HTMLCollection::base): (HTMLCollection::namedItems):
- khtml/dom/html_misc.h:
- khtml/editing/htmlediting.cpp:
- khtml/editing/selection.cpp:
- khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::determineParseMode): (DOM::HTMLDocumentImpl::doctype):
- khtml/html/html_documentimpl.h:
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setInnerHTML): (HTMLElementImpl::setOuterHTML): (HTMLElementImpl::setInnerText): (HTMLElementImpl::setOuterText): (HTMLElementImpl::style): (HTMLElementImpl::idDOM): (HTMLElementImpl::setId): (HTMLElementImpl::title): (HTMLElementImpl::setTitle): (HTMLElementImpl::lang): (HTMLElementImpl::setLang): (HTMLElementImpl::dir): (HTMLElementImpl::setDir): (HTMLElementImpl::className): (HTMLElementImpl::setClassName): (HTMLElementImpl::children): (HTMLGenericElementImpl::HTMLGenericElementImpl): (HTMLGenericElementImpl::id):
- khtml/html/html_elementimpl.h: (DOM::HTMLElementImpl::isGenericFormElement):
- khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseEnctype): (DOM::HTMLFormElementImpl::parseHTMLAttribute): (DOM::HTMLFormElementImpl::elements): (DOM::HTMLFormElementImpl::name): (DOM::HTMLFormElementImpl::setName): (DOM::HTMLFormElementImpl::acceptCharset): (DOM::HTMLFormElementImpl::setAcceptCharset): (DOM::HTMLFormElementImpl::action): (DOM::HTMLFormElementImpl::setAction): (DOM::HTMLFormElementImpl::setEnctype): (DOM::HTMLFormElementImpl::method): (DOM::HTMLFormElementImpl::setMethod): (DOM::HTMLFormElementImpl::target): (DOM::HTMLFormElementImpl::setTarget): (DOM::HTMLGenericFormElementImpl::HTMLGenericFormElementImpl): (DOM::HTMLGenericFormElementImpl::~HTMLGenericFormElementImpl): (DOM::HTMLGenericFormElementImpl::parseHTMLAttribute): (DOM::HTMLGenericFormElementImpl::name): (DOM::HTMLGenericFormElementImpl::setName): (DOM::HTMLGenericFormElementImpl::setOverrideName): (DOM::HTMLGenericFormElementImpl::setDisabled): (DOM::HTMLGenericFormElementImpl::setReadOnly): (DOM::HTMLGenericFormElementImpl::tabIndex): (DOM::HTMLGenericFormElementImpl::setTabIndex): (DOM::HTMLButtonElementImpl::accessKey): (DOM::HTMLButtonElementImpl::setAccessKey): (DOM::HTMLButtonElementImpl::value): (DOM::HTMLButtonElementImpl::setValue): (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLInputElementImpl::parseHTMLAttribute): (DOM::HTMLInputElementImpl::defaultValue): (DOM::HTMLInputElementImpl::setDefaultValue): (DOM::HTMLInputElementImpl::defaultChecked): (DOM::HTMLInputElementImpl::setDefaultChecked): (DOM::HTMLInputElementImpl::accept): (DOM::HTMLInputElementImpl::setAccept): (DOM::HTMLInputElementImpl::accessKey): (DOM::HTMLInputElementImpl::setAccessKey): (DOM::HTMLInputElementImpl::align): (DOM::HTMLInputElementImpl::setAlign): (DOM::HTMLInputElementImpl::alt): (DOM::HTMLInputElementImpl::setAlt): (DOM::HTMLInputElementImpl::setMaxLength): (DOM::HTMLInputElementImpl::sizeDOM): (DOM::HTMLInputElementImpl::setSize): (DOM::HTMLInputElementImpl::src): (DOM::HTMLInputElementImpl::setSrc): (DOM::HTMLInputElementImpl::useMap): (DOM::HTMLInputElementImpl::setUseMap): (DOM::HTMLLabelElementImpl::form): (DOM::HTMLLabelElementImpl::accessKey): (DOM::HTMLLabelElementImpl::setAccessKey): (DOM::HTMLLabelElementImpl::htmlFor): (DOM::HTMLLabelElementImpl::setHtmlFor): (DOM::HTMLLegendElementImpl::accessKey): (DOM::HTMLLegendElementImpl::setAccessKey): (DOM::HTMLLegendElementImpl::align): (DOM::HTMLLegendElementImpl::setAlign): (DOM::HTMLSelectElementImpl::setValue): (DOM::HTMLSelectElementImpl::optionsHTMLCollection): (DOM::HTMLSelectElementImpl::setMultiple): (DOM::HTMLSelectElementImpl::setSize): (DOM::HTMLOptGroupElementImpl::label): (DOM::HTMLOptGroupElementImpl::setLabel): (DOM::HTMLOptionElementImpl::setText): (DOM::HTMLOptionElementImpl::setIndex): (DOM::HTMLOptionElementImpl::setValue): (DOM::HTMLOptionElementImpl::defaultSelected): (DOM::HTMLOptionElementImpl::setDefaultSelected): (DOM::HTMLOptionElementImpl::label): (DOM::HTMLOptionElementImpl::setLabel): (DOM::HTMLTextAreaElementImpl::accessKey): (DOM::HTMLTextAreaElementImpl::setAccessKey): (DOM::HTMLTextAreaElementImpl::setCols): (DOM::HTMLTextAreaElementImpl::setRows): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl): (DOM::HTMLIsIndexElementImpl::parseHTMLAttribute): (DOM::HTMLIsIndexElementImpl::prompt): (DOM::HTMLIsIndexElementImpl::setPrompt):
- khtml/html/html_formimpl.h:
- khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::setHref): (HTMLBaseElementImpl::setTarget): (HTMLLinkElementImpl::disabled): (HTMLLinkElementImpl::setDisabled): (HTMLLinkElementImpl::charset): (HTMLLinkElementImpl::setCharset): (HTMLLinkElementImpl::href): (HTMLLinkElementImpl::setHref): (HTMLLinkElementImpl::hreflang): (HTMLLinkElementImpl::setHreflang): (HTMLLinkElementImpl::media): (HTMLLinkElementImpl::setMedia): (HTMLLinkElementImpl::rel): (HTMLLinkElementImpl::setRel): (HTMLLinkElementImpl::rev): (HTMLLinkElementImpl::setRev): (HTMLLinkElementImpl::target): (HTMLLinkElementImpl::setTarget): (HTMLLinkElementImpl::type): (HTMLLinkElementImpl::setType): (HTMLMetaElementImpl::content): (HTMLMetaElementImpl::setContent): (HTMLMetaElementImpl::httpEquiv): (HTMLMetaElementImpl::setHttpEquiv): (HTMLMetaElementImpl::name): (HTMLMetaElementImpl::setName): (HTMLMetaElementImpl::scheme): (HTMLMetaElementImpl::setScheme): (HTMLScriptElementImpl::id): (HTMLScriptElementImpl::isURLAttribute): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::notifyFinished): (HTMLScriptElementImpl::text): (HTMLScriptElementImpl::setText): (HTMLScriptElementImpl::htmlFor): (HTMLScriptElementImpl::setHtmlFor): (HTMLScriptElementImpl::event): (HTMLScriptElementImpl::setEvent): (HTMLScriptElementImpl::charset): (HTMLScriptElementImpl::setCharset): (HTMLScriptElementImpl::defer): (HTMLScriptElementImpl::setDefer): (HTMLScriptElementImpl::src): (HTMLScriptElementImpl::setSrc): (HTMLScriptElementImpl::type): (HTMLScriptElementImpl::setType): (HTMLStyleElementImpl::disabled): (HTMLStyleElementImpl::setDisabled): (HTMLStyleElementImpl::media): (HTMLStyleElementImpl::setMedia): (HTMLStyleElementImpl::type): (HTMLStyleElementImpl::setType): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged): (HTMLTitleElementImpl::text): (HTMLTitleElementImpl::setText):
- khtml/html/html_headimpl.h:
- khtml/html/html_miscimpl.cpp: (DOM::HTMLBaseFontElementImpl::id): (DOM::HTMLBaseFontElementImpl::color): (DOM::HTMLBaseFontElementImpl::setColor): (DOM::HTMLBaseFontElementImpl::face): (DOM::HTMLBaseFontElementImpl::setFace): (DOM::HTMLBaseFontElementImpl::size): (DOM::HTMLBaseFontElementImpl::setSize): (DOM::HTMLCollectionImpl::HTMLCollectionImpl): (DOM::HTMLCollectionImpl::~HTMLCollectionImpl): (DOM::HTMLCollectionImpl::resetCollectionInfo): (DOM::HTMLCollectionImpl::traverseNextItem): (DOM::HTMLCollectionImpl::calcLength): (DOM::HTMLCollectionImpl::item): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLCollectionImpl::updateNameCache): (DOM::HTMLCollectionImpl::namedItems): (DOM::HTMLCollectionImpl::nextNamedItem): (DOM::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (DOM::HTMLFormCollectionImpl::calcLength): (DOM::HTMLFormCollectionImpl::item): (DOM::HTMLFormCollectionImpl::getNamedFormItem): (DOM::HTMLFormCollectionImpl::nextNamedItemInternal): (DOM::HTMLFormCollectionImpl::namedItem): (DOM::HTMLFormCollectionImpl::updateNameCache):
- khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::base):
- khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): (KHTMLParser::insertNode):
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution):
- khtml/khtml_events.cpp: (khtml::MouseEvent::MouseEvent): (khtml::MouseEvent::offset):
- khtml/khtml_events.h: (khtml::MouseEvent::innerNode): (khtml::MousePressEvent::MousePressEvent): (khtml::MouseDoubleClickEvent::MouseDoubleClickEvent): (khtml::MouseMoveEvent::MouseMoveEvent): (khtml::MouseReleaseEvent::MouseReleaseEvent):
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): (KHTMLPart::executeScript): (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::handleMouseMoveEventDrag): (KHTMLPart::handleMouseMoveEventOver): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle):
- khtml/khtml_part.h:
- khtml/khtmlpart_p.h:
- khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::contentsContextMenuEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop): (KHTMLView::focusNextPrevNode):
- kwq/DOM-CSS.mm: (-[DOMCSSStyleSheet cssRules]): (-[DOMCSSStyleDeclaration getPropertyValue:]): (-[DOMCSSStyleDeclaration getPropertyCSSValue:]): (-[DOMCSSStyleDeclaration removeProperty:]): (-[DOMCSSStyleDeclaration getPropertyPriority:]): (-[DOMCSSStyleDeclaration setProperty:::]): (-[DOMCSSValue setCssText:]):
- kwq/DOMCSS.h:
- kwq/DOMHTML.mm: (-[DOMHTMLElement setInnerHTML:]): (-[DOMHTMLElement setOuterHTML:]): (-[DOMHTMLElement setInnerText:]): (-[DOMHTMLElement setOuterText:]): (-[DOMHTMLSelectElement setLength:]): (-[DOMHTMLTableSectionElement insertRow:]):
- kwq/DOMInternal.h:
- kwq/DOMInternal.mm: (raiseDOMException): (-[WebScriptObject _initializeScriptDOMNodeImp]):
- kwq/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
- kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::scrollOverflow): (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::dispatchDragSrcEvent): (KWQKHTMLPart::eventMayStartDrag): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::sendContextMenuEvent): (listParent): (isTextFirstInListItem): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::mousePressNode):
- kwq/WebCoreBridge.mm: (updateRenderingForBindings): (-[WebCoreBridge _documentTypeString]):
- 3:25 PM Changeset in webkit [9155] by
-
- 12 edits in trunk/WebCore
Reviewed by John.
- rename hasAnchor method to isLink
- khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::checkOneSelector):
- khtml/editing/htmlediting.cpp: (khtml::isSpecialElement):
- khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseHTMLAttribute):
- khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isFocusable): (DOM::HTMLAnchorElementImpl::defaultEventHandler): (DOM::HTMLAnchorElementImpl::parseHTMLAttribute):
- khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
- khtml/rendering/render_layer.cpp: (RenderLayer::hitTest):
- khtml/rendering/render_object.cpp: (RenderObject::information):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
- khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isLink):
- kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):
- 3:24 PM Changeset in webkit [9154] by
-
- 7 edits in trunk/WebCore
Reviewed by John.
- remove init hint argument from VisiblePosition
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::init):
- khtml/editing/visible_position.h:
- khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]):
- 2:59 PM Changeset in webkit [9153] by
-
- 29 edits in trunk/WebCore
Reviewed by David Harrison.
- next pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step adds more member functions missing from the DOM impl. and
changes some of the Objective-C DOM to call the new ones; also changes some
parameter types in the DOM impl.)
- khtml/dom/dom2_events.cpp: (UIEvent::initUIEvent): (MouseEvent::initMouseEvent): (MutationEvent::initMutationEvent): (KeyboardEvent::initKeyboardEvent):
- khtml/dom/dom_doc.cpp: (DOM::DOMImplementation::createDocument): (DOM::Document::getElementsByTagName): (DOM::Document::getElementsByTagNameNS):
- khtml/dom/dom_element.cpp: (Element::removeAttributeNode): (Element::getElementsByTagName): (Element::getElementsByTagNameNS): (Element::setAttributeNodeNS):
- khtml/dom/dom_node.cpp: (NamedNodeMap::setNamedItemNS): (NamedNodeMap::removeNamedItemNS):
- khtml/ecma/kjs_binding.cpp:
- khtml/ecma/kjs_events.cpp: (ClipboardProtoFunc::tryCall):
- khtml/editing/jsediting.cpp:
- khtml/khtml_part.cpp: (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
- khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::dispatchMouseEvent):
- khtml/misc/shared.h: (khtml::SharedPtr::reset): (khtml::::operator): (khtml::static_pointer_cast): (khtml::const_pointer_cast):
- khtml/xml/dom2_eventsimpl.cpp: (UIEventImpl::initUIEvent): (UIEventImpl::keyCode): (UIEventImpl::charCode): (UIEventImpl::layerX): (UIEventImpl::layerY): (UIEventImpl::pageX): (UIEventImpl::pageY): (UIEventImpl::which): (MouseRelatedEventImpl::pageX): (MouseRelatedEventImpl::pageY): (MouseEventImpl::initMouseEvent): (MouseEventImpl::which): (KeyboardEventImpl::initKeyboardEvent): (KeyboardEventImpl::which): (MutationEventImpl::MutationEventImpl): (MutationEventImpl::initMutationEvent):
- khtml/xml/dom2_eventsimpl.h: (DOM::MutationEventImpl::relatedNode):
- khtml/xml/dom2_rangeimpl.h:
- khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeFilterImpl::acceptNode):
- khtml/xml/dom2_traversalimpl.h:
- khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DOMImplementationImpl::createCSSStyleSheet): (DOMImplementationImpl::createHTMLDocument): (DocumentImpl::createAttribute): (DocumentImpl::createHTMLElement): (DocumentImpl::getOverrideStyle): (DocumentImpl::defaultEventHandler): (DocumentImpl::completeURL): (DocumentImpl::topDocument): (DocumentImpl::createAttributeNS): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::nameableItems): (DocumentImpl::getElementsByName):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::realDocType): (DOM::DocumentImpl::createAttribute):
- khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeName): (AttrImpl::nodeValue): (AttrImpl::name): (AttrImpl::value): (ElementImpl::attributes): (ElementImpl::isURLAttribute): (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (ElementImpl::setAttributeNS): (ElementImpl::removeAttributeNS): (ElementImpl::getAttributeNodeNS): (ElementImpl::hasAttributeNS): (ElementImpl::style): (XMLElementImpl::cloneNode): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
- khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::hasAttribute): (DOM::ElementImpl::getAttribute): (DOM::ElementImpl::setAttribute): (DOM::ElementImpl::removeAttribute): (DOM::ElementImpl::getAttributeNode): (DOM::ElementImpl::setAttributeNodeNS):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): (NodeImpl::isAncestor): (NodeImpl::addEventListener): (NodeImpl::removeEventListener): (NodeImpl::getElementsByTagNameNS): (NodeImpl::isSupported): (NodeImpl::ownerDocument): (NodeImpl::hasAttributes): (NodeImpl::attributes): (ContainerNodeImpl::removeChildren): (NamedNodeMapImpl::~NamedNodeMapImpl): (NamedNodeMapImpl::getNamedItemNS): (NamedNodeMapImpl::removeNamedItemNS):
- khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::getNamedItem): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS): (DOM::NamedNodeMapImpl::isReadOnly):
- khtml/xml/dom_textimpl.h:
- khtml/xml/dom_xmlimpl.h:
- kwq/DOM.mm: (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode hasAttributes]): (-[DOMNamedNodeMap getNamedItem:]): (-[DOMNamedNodeMap setNamedItem:]): (-[DOMNamedNodeMap removeNamedItem:]): (-[DOMNamedNodeMap getNamedItemNS::]): (-[DOMNamedNodeMap setNamedItemNS:]): (-[DOMNamedNodeMap removeNamedItemNS::]): (-[DOMImplementation createDocument:::]): (-[DOMImplementation createCSSStyleSheet::]): (-[DOMDocument createAttribute:]): (-[DOMDocument getElementsByTagName:]): (-[DOMDocument createAttributeNS::]): (-[DOMDocument getElementsByTagNameNS::]): (-[DOMElement setAttribute::]): (-[DOMElement removeAttribute:]): (-[DOMElement getAttributeNode:]): (-[DOMElement setAttributeNode:]): (-[DOMElement removeAttributeNode:]): (-[DOMElement getElementsByTagName:]): (-[DOMElement getAttributeNS::]): (-[DOMElement setAttributeNS:::]): (-[DOMElement removeAttributeNS::]): (-[DOMElement getAttributeNodeNS::]): (-[DOMElement setAttributeNodeNS:]): (-[DOMElement getElementsByTagNameNS::]): (-[DOMElement hasAttribute:]): (-[DOMElement hasAttributeNS::]): (-[DOMElement style]): (-[DOMDocumentType _documentTypeImpl]): (ObjCNodeFilterCondition::acceptNode):
- kwq/DOMEvents.mm: (-[DOMMutationEvent relatedNode]):
- kwq/KWQClipboard.h:
- kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): (KWQClipboard::setDragImage): (KWQClipboard::dragImageElement): (KWQClipboard::setDragImageElement): (KWQClipboard::dragNSImage):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::passSubframeEventToSubframe): (KWQKHTMLPart::sendContextMenuEvent):
- 1:27 PM Changeset in webkit [9152] by
-
- 3 edits in trunk/WebKit
WebKit:
Reviewed by Kevin.
- WebKit support for <rdar://problem/3795701> Menu item/keyboard shortcut to restore text zoom to normal
- WebView.subproj/WebView.m: (-[WebView validateUserInterfaceItem:]): validate makeTextStandardSize by calling canMakeTextStandardSize (-[WebView canMakeTextStandardSize]): new method, returns YES unless text size multiplier is currently 1 (-[WebView makeTextStandardSize:]): new method, sets text size multiplier to 1
- WebView.subproj/WebViewPrivate.h: add makeTextStandardSize: and canMakeTextStandardSize to pending public category
WebBrowser:
Reviewed by Chris.
- fixed <rdar://problem/3795701> Menu item/keyboard shortcut to restore text zoom to normal
- BrowserDocument.h: added -makeTextStandardSize:
- BrowserDocument.m: (-[BrowserDocument makeTextStandardSize:]): call through to webview (-[BrowserDocument validateUserInterfaceItem:]): call through to webview
- BrowserWebController.m: (-[BrowserWebView canMakeTextStandardSize]): new method, special case bookmarks view, as with other text size methods (-[BrowserWebView makeTextStandardSize:]): new method, bail out if canMakeTextStandardSize fails, as with other text size methods
- BrowserWindowController.h: added -makeTextStandardSize:
- BrowserWindowController.m: (-[BrowserWindowController validateUserInterfaceItem:]): call through to webview (-[BrowserWindowController makeTextStandardSize:]): ditto
- English.lproj/MainMenu.nib: Added Make Text Normal Size menu item with keyboard equivalent of command-0, in between Make Text Bigger and Make Text Smaller
- HTMLSourceDocument.m: (-[HTMLSourceDocument canMakeTextStandardSize]): new method, imitates WebView code (-[HTMLSourceDocument makeTextStandardSize:]): ditto (-[HTMLSourceDocument validateUserInterfaceItem:]): validate new method
- 11:42 AM Changeset in webkit [9151] by
-
- 22 edits in trunk/WebCore
Reviewed by David Harrison.
- first pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step mostly adds member functions missing from the DOM impl.; later steps
will change the C++, JavaScript, and ObjC wrappers to call these functions)
- khtml/css/parser.y:
- khtml/css/css_ruleimpl.cpp: (CSSRuleListImpl::CSSRuleListImpl):
- khtml/css/css_ruleimpl.h: (DOM::CSSRuleListImpl::CSSRuleListImpl):
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::aLink): (HTMLBodyElementImpl::setALink): (HTMLBodyElementImpl::background): (HTMLBodyElementImpl::setBackground): (HTMLBodyElementImpl::bgColor): (HTMLBodyElementImpl::setBgColor): (HTMLBodyElementImpl::link): (HTMLBodyElementImpl::setLink): (HTMLBodyElementImpl::text): (HTMLBodyElementImpl::setText): (HTMLBodyElementImpl::vLink): (HTMLBodyElementImpl::setVLink): (HTMLFrameElementImpl::HTMLFrameElementImpl): (HTMLFrameElementImpl::updateForNewURL): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseHTMLAttribute): (HTMLFrameElementImpl::rendererIsNeeded): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::setLocation): (HTMLFrameElementImpl::contentPart): (HTMLFrameElementImpl::frameBorder): (HTMLFrameElementImpl::setFrameBorder): (HTMLFrameElementImpl::longDesc): (HTMLFrameElementImpl::setLongDesc): (HTMLFrameElementImpl::marginHeight): (HTMLFrameElementImpl::setMarginHeight): (HTMLFrameElementImpl::marginWidth): (HTMLFrameElementImpl::setMarginWidth): (HTMLFrameElementImpl::name): (HTMLFrameElementImpl::setName): (HTMLFrameElementImpl::setNoResize): (HTMLFrameElementImpl::scrolling): (HTMLFrameElementImpl::setScrolling): (HTMLFrameElementImpl::src): (HTMLFrameElementImpl::setSrc): (HTMLFrameSetElementImpl::parseHTMLAttribute): (HTMLFrameSetElementImpl::cols): (HTMLFrameSetElementImpl::setCols): (HTMLFrameSetElementImpl::rows): (HTMLFrameSetElementImpl::setRows): (HTMLHeadElementImpl::profile): (HTMLHeadElementImpl::setProfile): (HTMLHtmlElementImpl::version): (HTMLHtmlElementImpl::setVersion): (HTMLIFrameElementImpl::HTMLIFrameElementImpl): (HTMLIFrameElementImpl::rendererIsNeeded): (HTMLIFrameElementImpl::attach): (HTMLIFrameElementImpl::isURLAttribute): (HTMLIFrameElementImpl::align): (HTMLIFrameElementImpl::setAlign): (HTMLIFrameElementImpl::height): (HTMLIFrameElementImpl::setHeight): (HTMLIFrameElementImpl::src): (HTMLIFrameElementImpl::width): (HTMLIFrameElementImpl::setWidth):
- khtml/html/html_baseimpl.h: (DOM::HTMLFrameElementImpl::noResize): (DOM::HTMLFrameElementImpl::scrollingMode): (DOM::HTMLFrameElementImpl::getMarginWidth): (DOM::HTMLFrameElementImpl::getMarginHeight):
- khtml/html/html_blockimpl.cpp: (HTMLBlockquoteElementImpl::cite): (HTMLBlockquoteElementImpl::setCite): (HTMLDivElementImpl::align): (HTMLDivElementImpl::setAlign): (HTMLHRElementImpl::align): (HTMLHRElementImpl::setAlign): (HTMLHRElementImpl::noShade): (HTMLHRElementImpl::setNoShade): (HTMLHRElementImpl::size): (HTMLHRElementImpl::setSize): (HTMLHRElementImpl::width): (HTMLHRElementImpl::setWidth): (HTMLHeadingElementImpl::align): (HTMLHeadingElementImpl::setAlign): (HTMLParagraphElementImpl::align): (HTMLParagraphElementImpl::setAlign): (HTMLPreElementImpl::width): (HTMLPreElementImpl::setWidth):
- khtml/html/html_blockimpl.h:
- khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::name): (HTMLImageElementImpl::setName): (HTMLImageElementImpl::align): (HTMLImageElementImpl::setAlign): (HTMLImageElementImpl::alt): (HTMLImageElementImpl::setAlt): (HTMLImageElementImpl::border): (HTMLImageElementImpl::setBorder): (HTMLImageElementImpl::setHeight): (HTMLImageElementImpl::hspace): (HTMLImageElementImpl::setHspace): (HTMLImageElementImpl::isMap): (HTMLImageElementImpl::setIsMap): (HTMLImageElementImpl::longDesc): (HTMLImageElementImpl::setLongDesc): (HTMLImageElementImpl::src): (HTMLImageElementImpl::setSrc): (HTMLImageElementImpl::useMap): (HTMLImageElementImpl::setUseMap): (HTMLImageElementImpl::vspace): (HTMLImageElementImpl::setVspace): (HTMLImageElementImpl::setWidth): (HTMLImageElementImpl::x): (HTMLImageElementImpl::y): (HTMLMapElementImpl::parseHTMLAttribute): (HTMLMapElementImpl::areas): (HTMLMapElementImpl::name): (HTMLMapElementImpl::setName): (HTMLAreaElementImpl::HTMLAreaElementImpl): (HTMLAreaElementImpl::parseHTMLAttribute): (HTMLAreaElementImpl::getRegion): (HTMLAreaElementImpl::accessKey): (HTMLAreaElementImpl::setAccessKey): (HTMLAreaElementImpl::alt): (HTMLAreaElementImpl::setAlt): (HTMLAreaElementImpl::coords): (HTMLAreaElementImpl::setCoords): (HTMLAreaElementImpl::href): (HTMLAreaElementImpl::setHref): (HTMLAreaElementImpl::noHref): (HTMLAreaElementImpl::setNoHref): (HTMLAreaElementImpl::shape): (HTMLAreaElementImpl::setShape): (HTMLAreaElementImpl::tabIndex): (HTMLAreaElementImpl::setTabIndex): (HTMLAreaElementImpl::target): (HTMLAreaElementImpl::setTarget):
- khtml/html/html_imageimpl.h: (DOM::HTMLImageElementImpl::pixmap): (DOM::HTMLAreaElementImpl::isDefault): (DOM::HTMLMapElementImpl::getName):
- khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::accessKey): (DOM::HTMLAnchorElementImpl::setAccessKey): (DOM::HTMLAnchorElementImpl::charset): (DOM::HTMLAnchorElementImpl::setCharset): (DOM::HTMLAnchorElementImpl::coords): (DOM::HTMLAnchorElementImpl::setCoords): (DOM::HTMLAnchorElementImpl::href): (DOM::HTMLAnchorElementImpl::setHref): (DOM::HTMLAnchorElementImpl::hreflang): (DOM::HTMLAnchorElementImpl::setHreflang): (DOM::HTMLAnchorElementImpl::name): (DOM::HTMLAnchorElementImpl::setName): (DOM::HTMLAnchorElementImpl::rel): (DOM::HTMLAnchorElementImpl::setRel): (DOM::HTMLAnchorElementImpl::rev): (DOM::HTMLAnchorElementImpl::setRev): (DOM::HTMLAnchorElementImpl::shape): (DOM::HTMLAnchorElementImpl::setShape): (DOM::HTMLAnchorElementImpl::tabIndex): (DOM::HTMLAnchorElementImpl::setTabIndex): (DOM::HTMLAnchorElementImpl::target): (DOM::HTMLAnchorElementImpl::setTarget): (DOM::HTMLAnchorElementImpl::type): (DOM::HTMLAnchorElementImpl::setType): (DOM::HTMLAnchorElementImpl::blur): (DOM::HTMLAnchorElementImpl::focus): (DOM::HTMLBRElementImpl::clear): (DOM::HTMLBRElementImpl::setClear): (DOM::HTMLFontElementImpl::parseHTMLAttribute): (DOM::HTMLFontElementImpl::color): (DOM::HTMLFontElementImpl::setColor): (DOM::HTMLFontElementImpl::face): (DOM::HTMLFontElementImpl::setFace): (DOM::HTMLFontElementImpl::size): (DOM::HTMLFontElementImpl::setSize): (DOM::HTMLModElementImpl::HTMLModElementImpl): (DOM::HTMLModElementImpl::cite): (DOM::HTMLModElementImpl::setCite): (DOM::HTMLModElementImpl::dateTime): (DOM::HTMLModElementImpl::setDateTime): (DOM::HTMLQuoteElementImpl::HTMLQuoteElementImpl): (DOM::HTMLQuoteElementImpl::id): (DOM::HTMLQuoteElementImpl::cite): (DOM::HTMLQuoteElementImpl::setCite):
- khtml/html/html_inlineimpl.h:
- khtml/html/html_listimpl.cpp: (DOM::HTMLUListElementImpl::compact): (DOM::HTMLUListElementImpl::setCompact): (DOM::HTMLUListElementImpl::type): (DOM::HTMLUListElementImpl::setType): (DOM::HTMLDirectoryElementImpl::compact): (DOM::HTMLDirectoryElementImpl::setCompact): (DOM::HTMLMenuElementImpl::compact): (DOM::HTMLMenuElementImpl::setCompact): (DOM::HTMLOListElementImpl::compact): (DOM::HTMLOListElementImpl::setCompact): (DOM::HTMLOListElementImpl::setStart): (DOM::HTMLOListElementImpl::type): (DOM::HTMLOListElementImpl::setType): (DOM::HTMLLIElementImpl::type): (DOM::HTMLLIElementImpl::setType): (DOM::HTMLLIElementImpl::value): (DOM::HTMLLIElementImpl::setValue): (DOM::HTMLDListElementImpl::compact): (DOM::HTMLDListElementImpl::setCompact):
- khtml/html/html_listimpl.h: (DOM::HTMLUListElementImpl::start): (DOM::HTMLDirectoryElementImpl::HTMLDirectoryElementImpl): (DOM::HTMLMenuElementImpl::HTMLMenuElementImpl): (DOM::HTMLOListElementImpl::HTMLOListElementImpl): (DOM::HTMLOListElementImpl::start):
- khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::align): (DOM::HTMLAppletElementImpl::setAlign): (DOM::HTMLAppletElementImpl::alt): (DOM::HTMLAppletElementImpl::setAlt): (DOM::HTMLAppletElementImpl::archive): (DOM::HTMLAppletElementImpl::setArchive): (DOM::HTMLAppletElementImpl::code): (DOM::HTMLAppletElementImpl::setCode): (DOM::HTMLAppletElementImpl::codeBase): (DOM::HTMLAppletElementImpl::setCodeBase): (DOM::HTMLAppletElementImpl::height): (DOM::HTMLAppletElementImpl::setHeight): (DOM::HTMLAppletElementImpl::hspace): (DOM::HTMLAppletElementImpl::setHspace): (DOM::HTMLAppletElementImpl::name): (DOM::HTMLAppletElementImpl::setName): (DOM::HTMLAppletElementImpl::object): (DOM::HTMLAppletElementImpl::setObject): (DOM::HTMLAppletElementImpl::vspace): (DOM::HTMLAppletElementImpl::setVspace): (DOM::HTMLAppletElementImpl::width): (DOM::HTMLAppletElementImpl::setWidth): (DOM::HTMLObjectElementImpl::code): (DOM::HTMLObjectElementImpl::setCode): (DOM::HTMLObjectElementImpl::align): (DOM::HTMLObjectElementImpl::setAlign): (DOM::HTMLObjectElementImpl::archive): (DOM::HTMLObjectElementImpl::setArchive): (DOM::HTMLObjectElementImpl::border): (DOM::HTMLObjectElementImpl::setBorder): (DOM::HTMLObjectElementImpl::codeBase): (DOM::HTMLObjectElementImpl::setCodeBase): (DOM::HTMLObjectElementImpl::codeType): (DOM::HTMLObjectElementImpl::setCodeType): (DOM::HTMLObjectElementImpl::data): (DOM::HTMLObjectElementImpl::setData): (DOM::HTMLObjectElementImpl::declare): (DOM::HTMLObjectElementImpl::setDeclare): (DOM::HTMLObjectElementImpl::height): (DOM::HTMLObjectElementImpl::setHeight): (DOM::HTMLObjectElementImpl::hspace): (DOM::HTMLObjectElementImpl::setHspace): (DOM::HTMLObjectElementImpl::name): (DOM::HTMLObjectElementImpl::setName): (DOM::HTMLObjectElementImpl::standby): (DOM::HTMLObjectElementImpl::setStandby): (DOM::HTMLObjectElementImpl::tabIndex): (DOM::HTMLObjectElementImpl::setTabIndex): (DOM::HTMLObjectElementImpl::type): (DOM::HTMLObjectElementImpl::setType): (DOM::HTMLObjectElementImpl::useMap): (DOM::HTMLObjectElementImpl::setUseMap): (DOM::HTMLObjectElementImpl::vspace): (DOM::HTMLObjectElementImpl::setVspace): (DOM::HTMLObjectElementImpl::width): (DOM::HTMLObjectElementImpl::setWidth): (DOM::HTMLParamElementImpl::isURLAttribute): (DOM::HTMLParamElementImpl::setName): (DOM::HTMLParamElementImpl::type): (DOM::HTMLParamElementImpl::setType): (DOM::HTMLParamElementImpl::setValue): (DOM::HTMLParamElementImpl::valueType): (DOM::HTMLParamElementImpl::setValueType):
- khtml/html/html_objectimpl.h: (DOM::HTMLParamElementImpl::name): (DOM::HTMLParamElementImpl::value):
- khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableElementImpl::align): (DOM::HTMLTableElementImpl::setAlign): (DOM::HTMLTableElementImpl::bgColor): (DOM::HTMLTableElementImpl::setBgColor): (DOM::HTMLTableElementImpl::border): (DOM::HTMLTableElementImpl::setBorder): (DOM::HTMLTableElementImpl::cellPadding): (DOM::HTMLTableElementImpl::setCellPadding): (DOM::HTMLTableElementImpl::cellSpacing): (DOM::HTMLTableElementImpl::setCellSpacing): (DOM::HTMLTableElementImpl::frame): (DOM::HTMLTableElementImpl::setFrame): (DOM::HTMLTableElementImpl::rules): (DOM::HTMLTableElementImpl::setRules): (DOM::HTMLTableElementImpl::summary): (DOM::HTMLTableElementImpl::setSummary): (DOM::HTMLTableElementImpl::width): (DOM::HTMLTableElementImpl::setWidth): (DOM::HTMLTableSectionElementImpl::align): (DOM::HTMLTableSectionElementImpl::setAlign): (DOM::HTMLTableSectionElementImpl::ch): (DOM::HTMLTableSectionElementImpl::setCh): (DOM::HTMLTableSectionElementImpl::chOff): (DOM::HTMLTableSectionElementImpl::setChOff): (DOM::HTMLTableSectionElementImpl::vAlign): (DOM::HTMLTableSectionElementImpl::setVAlign): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::cells): (DOM::HTMLTableRowElementImpl::setCells): (DOM::HTMLTableRowElementImpl::align): (DOM::HTMLTableRowElementImpl::setAlign): (DOM::HTMLTableRowElementImpl::bgColor): (DOM::HTMLTableRowElementImpl::setBgColor): (DOM::HTMLTableRowElementImpl::ch): (DOM::HTMLTableRowElementImpl::setCh): (DOM::HTMLTableRowElementImpl::chOff): (DOM::HTMLTableRowElementImpl::setChOff): (DOM::HTMLTableRowElementImpl::vAlign): (DOM::HTMLTableRowElementImpl::setVAlign): (DOM::HTMLTableCellElementImpl::abbr): (DOM::HTMLTableCellElementImpl::setAbbr): (DOM::HTMLTableCellElementImpl::align): (DOM::HTMLTableCellElementImpl::setAlign): (DOM::HTMLTableCellElementImpl::axis): (DOM::HTMLTableCellElementImpl::setAxis): (DOM::HTMLTableCellElementImpl::bgColor): (DOM::HTMLTableCellElementImpl::setBgColor): (DOM::HTMLTableCellElementImpl::ch): (DOM::HTMLTableCellElementImpl::setCh): (DOM::HTMLTableCellElementImpl::chOff): (DOM::HTMLTableCellElementImpl::setChOff): (DOM::HTMLTableCellElementImpl::setColSpan): (DOM::HTMLTableCellElementImpl::headers): (DOM::HTMLTableCellElementImpl::setHeaders): (DOM::HTMLTableCellElementImpl::height): (DOM::HTMLTableCellElementImpl::setHeight): (DOM::HTMLTableCellElementImpl::noWrap): (DOM::HTMLTableCellElementImpl::setNoWrap): (DOM::HTMLTableCellElementImpl::setRowSpan): (DOM::HTMLTableCellElementImpl::scope): (DOM::HTMLTableCellElementImpl::setScope): (DOM::HTMLTableCellElementImpl::vAlign): (DOM::HTMLTableCellElementImpl::setVAlign): (DOM::HTMLTableCellElementImpl::width): (DOM::HTMLTableCellElementImpl::setWidth): (DOM::HTMLTableColElementImpl::align): (DOM::HTMLTableColElementImpl::setAlign): (DOM::HTMLTableColElementImpl::ch): (DOM::HTMLTableColElementImpl::setCh): (DOM::HTMLTableColElementImpl::chOff): (DOM::HTMLTableColElementImpl::setChOff): (DOM::HTMLTableColElementImpl::setSpan): (DOM::HTMLTableColElementImpl::vAlign): (DOM::HTMLTableColElementImpl::setVAlign): (DOM::HTMLTableColElementImpl::width): (DOM::HTMLTableColElementImpl::setWidth): (DOM::HTMLTableCaptionElementImpl::parseHTMLAttribute): (DOM::HTMLTableCaptionElementImpl::align): (DOM::HTMLTableCaptionElementImpl::setAlign):
- khtml/html/html_tableimpl.h: (DOM::HTMLTableColElementImpl::span):
- khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
- khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): (RenderPartObject::updateWidget): (RenderPartObject::slotViewCleared):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::completeURL):
- khtml/xml/dom_docimpl.h:
- 11:01 AM Changeset in webkit [9150] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
- fixed <rdar://problem/4067981> Mail places RTF flavor before RTFD flavor when dragging mixed image/text content.
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): put RTFD type before RTF type in array of types to declare
May 9, 2005:
- 9:40 PM Changeset in webkit [9149] by
-
- 7 edits in trunk/WebCore
Reviewed by Kevin.
- remove more isFirst/isLast functions and use isStart/isEnd verions instead
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::setAffinityUsingLinePosition): (khtml::isFirstVisiblePositionInNode):
- khtml/editing/visible_position.h:
- khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::previousLinePosition):
- khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]):
- 9:03 PM Changeset in webkit [9148] by
-
- 7 edits in trunk/WebCore
Reviewed by Kevin.
- remove isFirstVisiblePositionInBlock and isLastVisiblePositionInBlock, in favor of isStartOfBlock and isEndOfBlock
It turned out that both isEndOfBlock and isLastVisiblePositionInBlock had (different) bugs,
and there was code relying on the bugs of each. So in addition I fixed isEndOfBlock and fixed
the parts of the code relying on buggy behavior.
I also removed the includeEndOfLine parameter to endOfBlock since no one used it and it's not
clear if it would ever be useful.
- khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Use new calls. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Don't gratuitously make an UPSTREAM VisiblePosition, as this will cause trouble comparing it to end of block. (khtml::InsertParagraphSeparatorCommand::doApply): Use new calls. (khtml::ReplaceSelectionCommand::doApply): Use new calls. Also, don't make a position <BR,0> and test if it is the end of a block, that can never be true, although the buggy code in isLastVisiblePositionInBlock would say it is. Make <BR,1> instead.
- khtml/editing/markup.cpp: (khtml::createMarkup): Instead of checking isEndOfBlock on the start position, check if the start's next is in a different block, to avoid relying on the buggy old isEndOfBlock behavior.
- khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInParagraph): Use isStartOfBlock. (khtml::isLastVisiblePositionInParagraph): Use isEndOfBlock.
- khtml/editing/visible_position.h:
- khtml/editing/visible_units.cpp: (khtml::endOfBlock): Greatly simplify, and no longer consider the start of a descendant block to be the end of the block. That's inconsistent with how startOfBlock works. Also remove include end of line parameter. (khtml::isEndOfBlock): Don't pass unneeded parameter.
- khtml/editing/visible_units.h:
- 6:15 PM Changeset in webkit [9147] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Merged fix for <rdar://problem/4110775> from TOT.
2005-05-09 Adele Peterson <adele@apple.com>
fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test
Reviewed by Darin.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
- 6:04 PM Changeset in webkit [9146] by
-
- 3 edits8 adds in trunk
fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test
Reviewed by Darin.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
- layout-tests/fast/dom/outerText-no-element.html: Added. Tests case where you try to set outerText on an element no longer in the DOM tree.
- layout-tests/fast/dom/outerText-no-element-expected.txt: Added.
- layout-tests/fast/dynamic/outerHTML-doc.html: Added. Tests case where someone tries to set outerHTML on the document.
- layout-tests/fast/dynamic/outerHTML-doc-expected.txt: Added..
- layout-tests/fast/dynamic/outerHTML-no-element.html: Added. Tests case where you try to set outerHTML on an element no longer in the DOM tree.
- layout-tests/fast/dynamic/outerHTML-no-element-expected.txt: Added.
- layout-tests/fast/dynamic/outerHTML-img.html: moved images to resources directory
- layout-tests/fast/dynamic/resources/apple.gif: Added.
- layout-tests/fast/dynamic/resources/mozilla.gif: Added.
- 4:57 PM Changeset in webkit [9145] by
-
- 14 edits in trunk/JavaScriptCore
Reviewed by John.
- turn on conservative GC unconditionally and start on SPI changes to eliminate the now-unneeded smart pointers since we don't ref count any more
- kjs/value.h: Removed macros to turn conservative GC on and off. Removed ref and deref functions. (KJS::ValueImp::ValueImp): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefined): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isNull): Ditto. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::Value::Value): Removed non-conservative-GC code path and made constructor no longer explicit so we can quietly create Value wrappers from ValueImp *; inexpensive with conservative GC and eases the transition. (KJS::Value::operator ValueImp *): Added. Quietly creates ValueImp * from Value. (KJS::ValueImp::marked): Removed non-conservative-GC code path.
- kjs/value.cpp: (KJS::ValueImp::mark): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefinedOrNull): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::asString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::undefined): Ditto. (KJS::null): Ditto. (KJS::boolean): Ditto. (KJS::string): Ditto. (KJS::zero): Ditto. (KJS::one): Ditto. (KJS::two): Ditto. (KJS::number): Ditto.
- kjs/object.h: Made constructor no longer explicit so we can quietly create Object wrappers from ObjectImp *; inexpensive with conservative GC and eases the transition. (KJS::Object::operator ObjectImp *): Added. Quietly creates ObjectImp * from Object. (KJS::ValueImp::isObject): Added. Implementation of new object-related ValueImp function. (KJS::ValueImp::asObject): Ditto.
- kjs/object.cpp: (KJS::ObjectImp::setInternalValue): Remove non-conservative-GC code path. (KJS::ObjectImp::putDirect): Ditto. (KJS::error): Added. Function in the new SPI style to create an error object.
- kjs/internal.h: Added the new number-constructing functions as friends of NumberImp. There may be a more elegant way to do this later; what's important now is the new SPI.
- kjs/collector.h: Remove non-conservative-GC code path and also take out some unneeded APPLE_CHANGES.
- bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): Remove non-conservative-GC code path. (KJS::Bindings::removeNativeReference): Ditto. (RootObject::removeAllNativeReferences): Ditto.
- bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): Ditto. (KJS::Bindings::RootObject::setRootObjectImp): Ditto.
- kjs/collector.cpp: (KJS::Collector::allocate): Ditto. (KJS::Collector::collect): Ditto. (KJS::Collector::numGCNotAllowedObjects): Ditto. (KJS::Collector::numReferencedObjects): Ditto. (KJS::Collector::rootObjectClasses): Ditto.
- kjs/internal.cpp: (NumberImp::create): Ditto. (InterpreterImp::globalInit): Ditto. (InterpreterImp::globalClear): Ditto.
- kjs/list.cpp: (KJS::List::markProtectedLists): Ditto. (KJS::List::clear): Ditto. (KJS::List::append): Ditto.
- kjs/list.h: (KJS::List::List): Ditto. (KJS::List::deref): Ditto. (KJS::List::operator=): Ditto.
- kjs/protect.h: (KJS::gcProtect): Ditto. (KJS::gcUnprotect): Ditto.
- 2:03 PM Changeset in webkit [9144] by
-
- 9 edits in trunk/WebCore
Reviewed by Kevin.
- remove code for DoNotStayInBlock variant of upstream/downstream and make the methods take no parameters
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::fixupWhitespace): (khtml::InsertLineBreakCommand::insertNodeAfterPosition): (khtml::InsertLineBreakCommand::insertNodeBeforePosition): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
- khtml/editing/selection.cpp: (khtml::Selection::toRange): (khtml::Selection::validate):
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): (khtml::isFirstVisiblePositionInParagraph): (khtml::isFirstVisiblePositionInBlock): (khtml::isLastVisiblePositionInParagraph):
- khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition):
- khtml/xml/dom_position.cpp: (DOM::isStreamer): (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
- khtml/xml/dom_position.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge smartDeleteRangeForProposedRange:]):
- 1:31 PM Changeset in webkit [9143] by
-
- 5 edits in trunk/WebKit
Turned assertion into error message to prevent crash when encountering this bug:
<rdar://problem/4067625> connection:willCacheResponse: is called inside of [NSURLConnection initWithRequest:delegate:]
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): set flag to track when we're initializing the connection (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): log error
- 12:04 PM Changeset in webkit [9142] by
-
- 5 edits in trunk/WebCore
Reviewed by Dave Harrison.
- remove remaining uses of upstream/downstream DoNotStayInBlock
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
- khtml/editing/visible_position.cpp: (khtml::enclosingBlockFlowElement): New helper function.
- khtml/editing/visible_position.h:
- khtml/editing/visible_units.cpp: (khtml::inSameBlock): Check enclosing block flows instead of comparing visible block starts. Two nested blocks may have the same visible start but different visible ends, so the old check would give false positives.
- 12:01 PM Changeset in webkit [9141] by
-
- 1 edit2 adds in trunk
Add layout test for <rdar://problem/4110366>.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-011.html: Added.
- 11:46 AM Changeset in webkit [9140] by
-
- 2 edits in trunk/JavaScriptCore
Workaround gcc 3.3 internal compiler errors.
Reviewed by darin.
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]): call [NSString stringWithCString:encoding] rather than using @""
- 9:23 AM Changeset in webkit [9139] by
-
- 1 edit1 add in trunk
- checked in a result for the Flash replacement test that Dave added
- layout-tests/fast/dynamic/flash-replacement-test-expected.txt: Added. Hope it's right! If not, Dave can update it.
- 9:10 AM Changeset in webkit [9138] by
-
- 7 edits in trunk
top level:
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
- configure.in: Ditto.
Tools:
- CommitLogEditor/Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
- HotSpotFinder/Makefile.am: Ditto.
- jst/Makefile.am: Ditto.
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
Tests:
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
- TestBindingsPlugin/Makefile.am: Ditto.
WebCore:
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
- WebCore.pbproj/project.pbxproj: Remove unneeded $(DSTROOT) in framework paths.
WebKit:
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
WebBrowser:
- Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
May 8, 2005:
- 2:02 PM Changeset in webkit [9137] by
-
- 5 edits in trunk/WebCore
Reviewed by Kevin.
- remove some of the uses of upstream/downstream DoNotStayInBlock
- khtml/editing/markup.cpp: (khtml::createMarkup): Instead of using upstream to decide if a line break should be added at the end, use inSameParagraph.
- khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Remove the code to print upstream and downstream, the selection endpoints themselves are adequate for debugging and are what we use for layout tests.
- khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition): Skip a possible paragraph break at the start of the selection in a more explicit way to avoid DoNotStayInBlock.
May 7, 2005:
- 10:53 AM Changeset in webkit [9136]
-
- 34 copies2 deletes in tags/WebCore-415~5
This commit was manufactured by cvs2svn to create tag
'WebCore-415~5'.
- 10:53 AM Changeset in webkit [9135] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiAtlanta - WebCore-415.5 (skipping the .4)
- 10:46 AM Changeset in webkit [9134] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4110366> from TOT for SUTiAtlanta
2005-05-07 David Harrison <harrison@apple.com>
Reviewed by John.
<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
- 10:37 AM Changeset in webkit [9133] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
- 5:24 AM Changeset in webkit [9132] by
-
- 2 edits in trunk/WebCore
Remove workaround for <rdar://problem/4103339>.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):
- 12:02 AM Changeset in webkit [9131] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave Harrison.
- make StayInBlock vs DoNotStayInBlock explicit in all calls to upstream/downstream, in preparation for phasing out the DoNotStayInBlock variant.
- khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
- khtml/editing/markup.cpp: (khtml::createMarkup):
- khtml/editing/selection.cpp: (khtml::Selection::debugPosition):
- khtml/xml/dom_position.h:
May 6, 2005:
- 5:45 PM Changeset in webkit [9130] by
-
- 11 edits2 deletes in trunk/WebCore
Reviewed by Maciej, Darin.
<rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order
- WebCore.pbproj/project.pbxproj: Removed dom_positioniterator.h and dom_positioniterator.cpp.
- khtml/editing/htmlediting.cpp: Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
- khtml/editing/selection.cpp: Removed unused include of dom_positioniterator.h.
- khtml/editing/visible_position.h:
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
- khtml/xml/dom_nodeimpl.h:
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::maxDeepOffset): Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
- khtml/xml/dom_position.h:
- khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atStart): (DOM::Position::atEnd): Moved here, replacing VisiblePosition's duplicate and PositionIterator. Fixed to return positions in order and not skip positions.
(DOM::Position::previousCharacterPosition):
(DOM::Position::nextCharacterPosition):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.
(DOM::isStreamer):
(DOM::Position::upstream):
(DOM::Position::downstream):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.
- khtml/xml/dom_positioniterator.cpp: Removed.
- khtml/xml/dom_positioniterator.h: Removed. Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
- 1:40 PM Changeset in webkit [9129] by
-
- 12 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively
Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
- khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
- khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
- khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
- khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
- khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
- khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
- khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
- khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
- 12:39 PM Changeset in webkit [9128] by
-
- 6 edits in trunk
top level:
Reviewed by Maciej.
- make building multiple trees with make work better
- configure.in: Update code to set up Xcode build directory instead of setting the Project Builder build directory.
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
Tools:
Reviewed by Maciej.
- make building multiple trees with make work better
- CommitLogEditor/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
- HotSpotFinder/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
- jst/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
Reviewed by Maciej.
- make building multiple trees with make work better
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
Tests:
Reviewed by Maciej.
- make building multiple trees with make work better
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
- TestBindingsPlugin/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
WebCore:
Reviewed by Maciej.
- make building multiple trees with make work better
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
WebKit:
Reviewed by Maciej.
- make building multiple trees with make work better
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
WebBrowser:
Reviewed by Maciej.
- make building multiple trees with make work better
- Makefile.am: Set up Xcode build directory before invoking xcodebuild.
May 5, 2005:
- 1:24 PM Changeset in webkit [9127] by
-
- 3 edits in trunk/WebCore
Eliminate the FOUCS on wired.com. innerWidth and innerHeight on window should not do a layout that ignores
pending stylesheets, since even if stylesheets are loading the correct window dimensions can be determined with
a normal layout.
The radar # is 4109888.
Reviewed by rjw
- khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
- khtml/ecma/kjs_window.h:
- 11:35 AM Changeset in webkit [9126] by
-
- 3 edits1 add in trunk
Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.
The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.
Reviewed by John Sullivan
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
- khtml/xml/dom_docimpl.h:
- layout-tests/fast/dynamic/flash-replacement-test.html: Added.
- 11:28 AM Changeset in webkit [9125]
-
- 34 copies2 deletes in tags/WebCore-415~3
This commit was manufactured by cvs2svn to create tag
'WebCore-415~3'.
- 11:28 AM Changeset in webkit [9124] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiAtlanta - WebCore-415.3
- 11:27 AM Changeset in webkit [9123] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Merging fix for <rdar://problem/4109564> from TOT for SUTiAtlanta.
2005-05-05 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
- fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
- khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
- 11:13 AM Changeset in webkit [9122]
-
- 15 copies2 deletes in tags/WebCore-315~3
This commit was manufactured by cvs2svn to create tag
'WebCore-315~3'.
- 11:13 AM Changeset in webkit [9121] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning for Oracle Seed - WebCore-315.3
- 11:11 AM Changeset in webkit [9120] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Merged fix for <rdar://problem/4065447> from TOT for Oracle Seed.
2005-04-20 Vicki Murley <vicki@apple.com>
Reviewed by hyatt.
- fixed <rdar://problem/4065447> support outerHTML on IMG elements
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
- 10:55 AM Changeset in webkit [9119] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
- khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
- 10:01 AM Changeset in webkit [9118] by
-
- 2 edits in trunk/WebCore
Reviewed by me.
Restore fixed setEndingSelection. Fixed method was ifdef'd out
because change was at end of Tiger development, but method is
unused. You just can never be _too_ safe.
- khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setEndingSelection):
- 9:09 AM Changeset in webkit [9117] by
-
- 2 edits in branches/experimental-ui-branch/WebCore
Reviewed by Chris.
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerRect]): Get corner rect from enclosing clipView, rather than using visibleRect. VisibleRect would return the wrong result when the textarea was clipped by the bottom of the window, leading to redraw schmutz among other things.
May 4, 2005:
- 11:04 PM Changeset in webkit [9116] by
-
- 12 edits in trunk/WebCore
Reviewed by Vicki.
- renamed NodeBaseImpl to ContainerNodeImpl
- khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Avoid use of NodeBaseImpl and avoid use of obsolete checkNoOwner call, use isAncestor instead.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterText): Avoid gratuitous use of NodeBaseImpl.
- khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::checkNoOwner): Removed.
Ther rest is all just simple renaming.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::attach): (DocumentImpl::detach): (DocumentFragmentImpl::DocumentFragmentImpl):
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): (ElementImpl::ElementImpl): (ElementImpl::insertedIntoDocument): (ElementImpl::removedFromDocument): (ElementImpl::attach): (ElementImpl::dump):
- khtml/xml/dom_elementimpl.h:
- khtml/xml/dom_nodeimpl.cpp: (ContainerNodeImpl::ContainerNodeImpl): (ContainerNodeImpl::~ContainerNodeImpl): (ContainerNodeImpl::firstChild): (ContainerNodeImpl::lastChild): (ContainerNodeImpl::insertBefore): (ContainerNodeImpl::replaceChild): (ContainerNodeImpl::removeChild): (ContainerNodeImpl::removeChildren): (ContainerNodeImpl::appendChild): (ContainerNodeImpl::hasChildNodes): (ContainerNodeImpl::setFirstChild): (ContainerNodeImpl::setLastChild): (ContainerNodeImpl::checkSameDocument): (ContainerNodeImpl::checkIsChild): (ContainerNodeImpl::addChild): (ContainerNodeImpl::attach): (ContainerNodeImpl::detach): (ContainerNodeImpl::insertedIntoDocument): (ContainerNodeImpl::removedFromDocument): (ContainerNodeImpl::cloneChildNodes): (ContainerNodeImpl::getElementsByTagNameNS): (ContainerNodeImpl::getUpperLeftCorner): (ContainerNodeImpl::getLowerRightCorner): (ContainerNodeImpl::getRect): (ContainerNodeImpl::setFocus): (ContainerNodeImpl::setActive): (ContainerNodeImpl::childNodeCount): (ContainerNodeImpl::childNode): (ContainerNodeImpl::dispatchChildInsertedEvents): (ContainerNodeImpl::dispatchChildRemovalEvents):
- khtml/xml/dom_nodeimpl.h:
- khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::EntityReferenceImpl::EntityReferenceImpl): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl):
- khtml/xml/dom_xmlimpl.h:
- 5:29 PM Changeset in webkit [9115] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
<rdar://problem/4086570> Crash in JavaScriptCore with RSS Visualizer
- kjs/internal.cpp: (InterpreterImp::mark): mark staticNaN, it is usually protected by the Number prototype but there is a small window where it can get collected.
- 5:19 PM Changeset in webkit [9114]
-
- 14 copies2 deletes in tags/WebCore-315~2
This commit was manufactured by cvs2svn to create tag
'WebCore-315~2'.
- 5:19 PM Changeset in webkit [9113] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning for Oracle Seed - WebCore-315.2
- 5:16 PM Changeset in webkit [9112] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix mismatched parentheses in one of the ifdefs
- khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::childrenChanged):
- 5:15 PM Changeset in webkit [9111] by
-
- 5 edits in branches/Safari-1-3-branch/WebCore
Merged fix for <rdar://problem/3986228> from TOT for Oracle Seed.
2005-05-04 Vicki Murley <vicki@apple.com>
Reviewed by darin.
- fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically
Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.
- khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
- khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
- khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
- 5:07 PM Changeset in webkit [9110] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Dave Hyatt.
- another gcc-4.0-related fix
- bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.
- 4:52 PM Changeset in webkit [9109] by
-
- 3 edits in trunk/WebKit
Reviewed by Dave Hyatt.
- fixed layout tests
- WebKit.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3. Because our deployment target was not set, we ran into this bug:
<rdar://problem/4108717> CTFontGetGlyphWithName doesn't work with some strings
- Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
- 4:51 PM Changeset in webkit [9108] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fixed build rules to match other projects
- WebCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.
- Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
- 4:50 PM Changeset in webkit [9107] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Dave Hyatt.
- fixed build rules to match other projects
- JavaScriptCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.
- Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
- 2:37 PM Changeset in webkit [9106] by
-
- 2 edits in trunk/JavaScriptCore
- revert presumably accidental change to mozilla JS test expected results, this was making the tests fail.
- tests/mozilla/expected.html:
- 2:11 PM Changeset in webkit [9105] by
-
- 5 edits in trunk/WebCore
Reviewed by darin.
- fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically
Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.
- khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
- khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
- khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
- 11:50 AM Changeset in webkit [9104] by
-
- 6 edits in trunk/WebKit
Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value
Reviewed by john.
Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
- WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
- WebView.subproj/WebResourcePrivate.h:
May 3, 2005:
- 5:16 PM Changeset in webkit [9103] by
-
- 1 edit in trunk/WebCore/khtml/css/css_valueimpl.cpp
Fix build bustage.
- 5:09 PM Changeset in webkit [9102] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/4102644> Crash in LiveConnect below KJS::Bindings::JavaInstance::stringValue() const
Correctly handle accessing nil objects from a Java object array.
Reviewed by John.
- bindings/jni/jni_runtime.cpp: (JavaArray::valueAt):
- 4:08 PM Changeset in webkit [9101] by
-
- 7 edits in trunk/WebCore
Normalize all our custom properties in our implementation to be -khtml (remove all the -apple).
Make sure that -apple, -khtml, and -moz are all able to be used. -apple and -moz just map to -khtml.
Add support for automatically converting -khtml-opacity to opacity (for legacy Safari 1.1 compat).
Reviewed by darin
- khtml/css/css_computedstyle.cpp: (DOM::): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- khtml/css/cssproperties.in:
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty):
- khtml/css/parser.y:
- khtml/ecma/kjs_css.cpp: (cssPropertyName):
- 3:50 PM Changeset in webkit [9100] by
-
- 2 edits in trunk/WebCore
- fix the build
- WebCore.pbproj/project.pbxproj: Fix some SYMROOTS that should have been SYMROOT.
- 2:46 PM Changeset in webkit [9099] by
-
- 2 edits2 adds in trunk
Fix for 4098281, news.com missing a bunch of content. Make sure not to apply strict SGML parsing
when stripping comments out of scripts.
New test is comments-in-script.html
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
- 2:34 PM Changeset in webkit [9098] by
-
- 4 edits in trunk/WebCore
Remove unused notification to avoid ERROR messages spewing on the acid2 test.
Reviewed by darin
- khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest):
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
- khtml/rendering/render_frames.h:
- 1:57 PM Changeset in webkit [9097] by
-
- 2 adds in trunk/LayoutTests/fast/css
Adding acid2 test to layout tests.
- 1:55 PM Changeset in webkit [9096] by
-
- 11 edits in trunk/WebCore
Reviewed by Dave Hyatt.
No new layout tests needed.
- eliminated the bogus kMin/kMax macros that we had in addition to inline functions of the same name
- kwq/KWQKGlobal.h: Remove the kMin/kMax macros.
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Change type of constant so both sides of kMin calls match. (khtml::CSSStyleSelector::fontSizeForKeyword): Ditto.
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Ditto.
- remove unused parameter to dirtyLinesFromChangedChild for clarity
- khtml/rendering/render_object.h: Don't take the parameter.
- khtml/rendering/render_object.cpp: (RenderObject::dirtyLinesFromChangedChild): Ditto.
- khtml/rendering/render_flow.h: Don't take the parameter.
- khtml/rendering/render_flow.cpp: (RenderFlow::detach): Don't pass the parameter. (RenderFlow::dirtyLinesFromChangedChild): Don't take the parameter.
- khtml/rendering/render_text.cpp: (RenderText::detach): Don't pass the parameter.
- convert DOM::NodeImpl into an abstract base class by making a couple of functions pure virtual for clarity
- khtml/xml/dom_nodeimpl.h: Made nodeName and nodeType pure virtual.
- khtml/xml/dom_nodeimpl.cpp: Remove bodies of nodeName and nodeType.
- 1:47 PM Changeset in webkit [9095] by
-
- 13 edits in trunk/WebCore
Fix for object element to support fallback content. WIth this change Safari passes the Acid2 test.
Reviewed by Maciej
- khtml/css/html4.css:
- khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::parseHTMLAttribute): (HTMLObjectElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::createRenderer): (HTMLObjectElementImpl::attach): (HTMLObjectElementImpl::detach): (HTMLObjectElementImpl::recalcStyle): (HTMLObjectElementImpl::childrenChanged): (HTMLObjectElementImpl::isURLAttribute): (HTMLObjectElementImpl::isImageType): (HTMLObjectElementImpl::renderFallbackContent):
- khtml/html/html_objectimpl.h:
- khtml/khtml_part.cpp: (KHTMLPart::requestObject): (KHTMLPart::selectFrameElementInParentIfFullySelected): (KHTMLPart::handleFallbackContent):
- khtml/khtml_part.h:
- khtml/khtmlpart_p.h: (khtml::ChildFrame::ChildFrame):
- khtml/rendering/render_frames.cpp: (RenderPartObject::RenderPartObject): (RenderPartObject::updateWidget):
- khtml/rendering/render_frames.h: (khtml::RenderPart::hasFallbackContent):
- khtml/rendering/render_replaced.cpp: (RenderReplaced::RenderReplaced):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge mainResourceError]):
- 1:44 PM Changeset in webkit [9094] by
-
- 5 edits in trunk/WebKit
Fix object element support so that fallback content works. With this change Safari passes the Acid2 test.
Reviewed by Maciej
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):
- WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):
- 1:32 PM Changeset in webkit [9093] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebUIDelegate.h: Fixed incorrect comment.
May 2, 2005:
- 6:17 PM Changeset in webkit [9092] by
-
- 16 edits5 adds73 deletes in trunk
top level:
- move to Xcode native targets and stop checking in generated files
- configure.in: Removed gperf and yacc sections, and all the makefile paths for subdirectories of JavaScriptCore and WebCore, since those directories no longer have makefiles.
Tools:
- move to Xcode native targets and stop checking in generated files
- CommitLogEditor/CommitLogEditor.pbproj/project.pbxproj: Updated to use native targets.
- CommitLogEditor/Info.plist: Added. Native targets use a separate file for this.
- HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: Updated to use native targets.
- HotSpotFinder/Info.plist: Added. Native targets use a separate file for this.
- move to Xcode native targets and stop checking in generated files
- JavaScriptCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
- Info.plist: Added. Native targets use a separate file for this.
- Makefile.am: Removed pcre and kjs SUBDIRS. Also removed code that deleted the embedded copy of this framework, since we haven't been embedding it for some time.
- kjs/grammar_wrapper.cpp: Added. Shell used to compile grammar.cpp since we can't add a generated file easily to the list of files to be compiled.
- kjs/.cvsignore: Removed.
- kjs/Makefile.am: Removed.
- kjs/array_object.lut.h: Removed.
- kjs/date_object.lut.h: Removed.
- kjs/grammar.cpp: Removed.
- kjs/grammar.cpp.h: Removed.
- kjs/grammar.h: Removed.
- kjs/lexer.lut.h: Removed.
- kjs/math_object.lut.h: Removed.
- kjs/number_object.lut.h: Removed.
- kjs/string_object.lut.h: Removed.
- pcre/.cvsignore: Removed.
- pcre/Makefile.am: Removed.
- pcre/chartables.c: Removed.
WebCore:
- move to Xcode native targets and stop checking in generated files
- WebCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
- Info.plist: Added. Native targets use a separate file for this.
- Makefile.am: Removed rule to generate WebCore-combined.exp since this is now handled by the Xcode project. Removed the code to remove the embedded copy of the framework since we don't do that any more. Removed timestamp cleaning rules since we don't use those any more.
- WebCore-tests.exp: Removed symbols that aren't really needed. The native target gives an error when you mention a nonexistent symbol, so we can't have them any more.
- khtml/css/parser_wrapper.cpp: Added. Shell used to compile parser.cpp since we can't add a generated file easily to the list of files to be compiled.
- .cvsignore: Removed various timestamp files.
- WebCore-combined.exp: Removed.
- force-clean-timestamp: Removed.
- force-js-clean-timestamp: Removed.
- khtml/.cvsignore: Removed.
- khtml/Makefile.am: Removed.
- khtml/css/.cvsignore: Removed.
- khtml/css/Makefile.am: Removed.
- khtml/css/cssproperties.c: Removed.
- khtml/css/cssproperties.h: Removed.
- khtml/css/cssvalues.c: Removed.
- khtml/css/cssvalues.h: Removed.
- khtml/css/parser.cpp: Removed.
- khtml/css/parser.h: Removed.
- khtml/css/tokenizer.cpp: Removed.
- khtml/ecma/.cvsignore: Removed.
- khtml/ecma/Makefile.am: Removed.
- khtml/ecma/kjs_css.lut.h: Removed.
- khtml/ecma/kjs_dom.lut.h: Removed.
- khtml/ecma/kjs_events.lut.h: Removed.
- khtml/ecma/kjs_html.lut.h: Removed.
- khtml/ecma/kjs_navigator.lut.h: Removed.
- khtml/ecma/kjs_range.lut.h: Removed.
- khtml/ecma/kjs_traversal.lut.h: Removed.
- khtml/ecma/kjs_views.lut.h: Removed.
- khtml/ecma/kjs_window.lut.h: Removed.
- khtml/ecma/xmlhttprequest.lut.h: Removed.
- khtml/ecma/xmlserializer.lut.h: Removed.
- khtml/html/.cvsignore: Removed.
- khtml/html/Makefile.am: Removed.
- khtml/html/doctypes.cpp: Removed.
- khtml/html/kentities.c: Removed.
- khtml/misc/.cvsignore: Removed.
- khtml/misc/Makefile.am: Removed.
- khtml/misc/htmlattrs.c: Removed.
- khtml/misc/htmlattrs.h: Removed.
- khtml/misc/htmltags.c: Removed.
- khtml/misc/htmltags.h: Removed.
- kwq/.cvsignore: Removed.
- kwq/KWQCharsetData.c: Removed.
- kwq/KWQColorData.c: Removed.
- kwq/Makefile.am: Removed.
WebKit:
- move to Xcode native targets and stop checking in generated files
- WebKit.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
- Info.plist: Added. Native targets use a separate file for this.
- Plugins.subproj/npapi.m: Fixed import statement to get npapi.h from <WebKit/> rather than current directory.
- Makefile.am: Removed timestamp cleaning rules since we don't use it any more.
- .cvsignore: Removed various timestamp files.
- DOM.subproj/DOM-compat.h: Removed.
- DOM.subproj/DOM.h: Removed.
- DOM.subproj/DOMCSS.h: Removed.
- DOM.subproj/DOMCore.h: Removed.
- DOM.subproj/DOMEvents.h: Removed.
- DOM.subproj/DOMExtensions.h: Removed.
- DOM.subproj/DOMHTML.h: Removed.
- DOM.subproj/DOMPrivate.h: Removed.
- DOM.subproj/DOMRange.h: Removed.
- DOM.subproj/DOMStylesheets.h: Removed.
- DOM.subproj/DOMTraversal.h: Removed.
- DOM.subproj/DOMViews.h: Removed.
- Plugins.subproj/WebScriptObject.h: Removed.
- Plugins.subproj/npapi.h: Removed.
- Plugins.subproj/npruntime.h: Removed.
- copy-webcore-files-to-webkit: Removed.
- embed-frameworks.sh: Removed.
- force-clean-timestamp: Removed.
WebBrowser:
- move to Xcode native targets and stop checking in generated files
- WebBrowser.pbproj/project.pbxproj: Updated to use native target.
- Info.plist: Added. Native targets use a separate file for this.
- .cvsignore: Took out .DS_Store, since that's always ignored server-wide.
- English.lproj/.cvsignore: Removed.
- Preferences.subproj/.cvsignore: Removed.
- Resources/.cvsignore: Removed.
- Resources/Images/.cvsignore: Removed.
WebKitExamples:
- move to Xcode native targets and stop checking in generated files
- Blot/Blot.xcode/project.pbxproj: Updated to use a native target.
- 4:05 PM Changeset in webkit [9091] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix layout test paths.
- 2:37 PM Changeset in webkit [9090] by
-
- 4 edits1 add in branches/experimental-ui-branch/WebCore
Reviewed by Chris.
Improvements to resizable textarea experiment:
- resize image is now drawn in the resize corner
- cursor sometimes tracks to arrow when over resize corner (but usually not)
- cursor changes to arrow on mouse down in any case
- Resources/textAreaResizeCorner.tiff: Added.
- WebCore.pbproj/project.pbxproj: updated for added image file
- kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): Rolled in a fix to this method from tip of tree since it affects the demo.
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerImage]): new method, reads resize image once and caches it (-[KWQTextAreaTextView _resizeCornerRect]): new method, computes rect from image (-[KWQTextAreaTextView resetCursorRects]): overridden to attempt to make the cursor change to an arrow when over this corner. Only works sometimes, as explained in comments. (-[KWQTextAreaTextView drawRect:]): overridden to draw resize image (-[KWQTextAreaTextView mouseDown:]): now uses _resizeCornerRect, and sets cursor to arrow when pressed in resize corner
- 12:04 PM Changeset in webkit [9089]
-
- 34 copies2 deletes in tags/WebCore-415~2
This commit was manufactured by cvs2svn to create tag
'WebCore-415~2'.
- 12:04 PM Changeset in webkit [9088] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiAtlanta - WebCore-415.2
- 11:54 AM Changeset in webkit [9087] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Reviewed by Adele. Merging changes for SUTiAtlanta.
2005-04-29 David Harrison <harrison@apple.com>
Reviewed by Darin.
<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.
(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.
- 11:39 AM Changeset in webkit [9086] by
-
- 2 edits5 adds in trunk
Reviewed by Vicki.
Added two layout tests for regression testing.
- redid frameElement (fix for 4091082 below)
The first version lacked a security check, and was also broken.
- khtml/ecma/kjs_window.cpp: (frameElement): Refactored into separate function; added isSafeScript check. (Window::get): Call the new frameElement function.
- fast/frames/frameElement-frame.html: Added.
- fast/frames/frameElement-frame-expected.txt: Added.
- fast/frames/frameElement-iframe.html: Added.
- fast/frames/frameElement-iframe-expected.txt: Added.
- fast/frames/resources/frameElement-contents.html: Added.
- 10:11 AM Changeset in webkit [9085] by
-
- 2 edits in trunk/WebCore
Reviewed by Vicki.
Fix isStartOfEditableContent and isEndOfEditableContent to return actual, rather than inverted, answers.
No Radar. Found this when trying to use isEndOfEditableContent() in some new code.
- khtml/editing/visible_units.cpp: (khtml::isStartOfEditableContent): (khtml::isEndOfEditableContent): Flip expressions.
Apr 29, 2005:
- 3:34 PM Changeset in webkit [9084] by
-
- 2 edits in trunk/WebCore
Reviewed by David Harrison.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Turn newlines into \n for better dumping.
- 1:13 PM Changeset in webkit [9083] by
-
- 2 edits2 adds in trunk
Reviewed by Darin.
<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.
(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.
- layout-tests/editing/deleting/delete-4083333-fix-expected.txt: Added.
- layout-tests/editing/deleting/delete-4083333-fix.html: Added.
- 12:10 PM Changeset in webkit [9082] by
-
- 294 edits in trunk
Reviewed by Dave Harrison.
- changed layout tests to dump more minimal information about caret and selection
- kwq/KWQRenderTreeDebug.cpp: (nodePosition): Changed name; now does position relative to document. (writeSelection): Removed upstream/downstream code and changed format slightly.
- layout-tests/editing/*-expected.txt: Regenerated in new format.
- 10:28 AM Changeset in webkit [9081] by
-
- 7 edits4 adds in trunk
Reviewed by Chris Blumenberg.
Added two layout tests for regression testing.
- fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Reorganized and partly rewrote this. The change that fixes the bug at hand is to explicitly use XHTML_NAMESPACE for HTML elements, since the old way of getting the namespace will return the null string for HTML elements, and createElementNS will not create an HTML element if passed a null string for the namespace. (DocumentImpl::processHttpEquiv): Removed some bogus getDocument() calls -- no need to call getDocument() in a document object. (DocumentImpl::attrName): Ditto. (DocumentImpl::tagName): Ditto. (DocumentImpl::setFocusNode): Ditto.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Moved the actual cloning here from ElementImpl::cloneNode, because XMLElementImpl already had its own version, and in here we can use createHTMLElement, which will work properly even in an XML document, and is also slightly more efficient.
- khtml/xml/dom_nodeimpl.h: Added a namespaceURI method function to go along with localName.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::namespaceURI): Added. Returns null string to be consistent with localName (only works on certain types of elements as documented).
- khtml/xml/dom_elementimpl.h: Removed ElementImpl::cloneNode (see above). Added an override of namespaceURI for XMLElementImpl.
- khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::namespaceURI): Added. Returns the namespace (consistent with localName).
- layout-tests/fast/dom/importNodeHTML.html: Added. Tests both importNode and cloneNode (for comparison).
- layout-tests/fast/dom/importNodeHTML-expected.txt: Added.
- layout-tests/fast/dom/importNodeXML.xhtml: Added. XML version of the same test as above. Tests a different code path, so useful to have.
- layout-tests/fast/dom/importNodeXML-expected.txt: Added.
Apr 28, 2005:
- 6:13 PM Changeset in webkit [9080] by
-
- 7 edits in trunk/WebKit
Reviewed by Maciej.
- fixed problems preventing us from compiling with gcc 4.0
- WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
- WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
- WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.
- 5:31 PM Changeset in webkit [9079] by
-
- 21 edits in trunk/WebCore
Reviewed by Dave Harrison.
- fixed problems preventing us from compiling with gcc 4.0
- WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
- khtml/css/parser.cpp: Regenerated.
- khtml/css/parser.h: Regenerated.
- khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
- khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
- khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
- khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
- kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
- kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
- kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
- kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
- kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
- WebCore-combined.exp: Regenerated.
- WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.
- 5:22 PM Changeset in webkit [9078] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by Dave Harrison.
- fixed problems preventing us from compiling with gcc 4.0
- JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
- bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
- bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
- bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
- kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
- kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
- kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
- kjs/string_object.cpp: (replace): Ditto.
- 5:07 PM Changeset in webkit [9077] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix ChangeLog
- 5:07 PM Changeset in webkit [9076] by
-
- 2 edits in trunk/WebCore
- WebCore.pbproj/project.pbxproj: Add back the main_thread_malloc files, rolled out by accident.
Apr 27, 2005:
- 6:04 PM Changeset in webkit [9075] by
-
- 6 edits in trunk/WebCore
Rolling out fix for <rdar://problem/4097849> because the following layout tests were failing:
fast/css/namespaces/001
fast/css/namespaces/002
fast/css/namespaces/004
fast/css/namespaces/005
fast/css/namespaces/006
fast/overflow/003
- khtml/html/html_documentimpl.cpp:
- khtml/html/html_documentimpl.h:
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::namespaceURI):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): (DocumentImpl::createElementNS): (DocumentImpl::createHTMLElement): (DocumentImpl::attrId): (DocumentImpl::tagId):
- khtml/xml/dom_docimpl.h:
- 6:03 PM Changeset in webkit [9074]
-
- 4 copies2 deletes in tags/WebCore-413~1
This commit was manufactured by cvs2svn to create tag
'WebCore-413~1'.
- 6:03 PM Changeset in webkit [9073] by
-
- 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj
one more tweak
- 5:06 PM Changeset in webkit [9072] by
-
- 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj
WebCore-413.1
- 4:14 PM Changeset in webkit [9071]
-
- 34 copies2 deletes in tags/WebCore-415~1
This commit was manufactured by cvs2svn to create tag
'WebCore-415~1'.
- 4:14 PM Changeset in webkit [9070] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
- merge this fix from HEAD
This fix was included in WebCore-413, which shipped in Tiger GM (8A428). However,
Safari-2-0-anchor was mistakenly placed at WebCore-412. Merging this fix to
the branch so that this fix isn't lost in the SU.
2005-03-27 Darin Adler <Darin Adler>
Reviewed by me, fix by Kida-san.
- fixed <rdar://problem/4067474> 8A424: Safari immediately quit by Cmd+Ctrll+'D'
- kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]): Added nil check.
- 2:53 PM Changeset in webkit [9069] by
-
- 2 edits in branches/experimental-ui-branch/WebCore
Rolled in the resizable textarea change from tip of tree, so all three of my
experimental prototypes are on the same branch, for ease of demoing. For the
experimental-ui-branch, ALLOW_RESIZING_TEXTAREAS is on unless you recompile
it away.
===
This code allows you to press near the bottom-right corner of any textarea and drag
to resize the textarea on the page. It works correctly with textareas in left-aligned
or centered blocks, but is weird in right-aligned blocks. It also does something
sensible if the width is specified as a % (in that case, you can resize vertically only).
The user-created-size survives resizing the window and survives the back/forward cache.
It does not survive reloading the page.
This complete-lack-of-affordance UI is obviously not shippable, but this proof of concept
code could lead to a real user feature.
- kwq/KWQTextArea.mm: (-[KWQTextArea getNumColumns:andNumRows:forSize:]): new method that determines cols and rows for a given textarea frame size (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): new method that tracks a drag and does a live resize-and-relayout (-[KWQTextAreaTextView mouseDown:]): if the mouse down is in the bottom-right corner, call _trackResizeFromMouseDown:
- 2:41 PM Changeset in webkit [9068] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Merging John's fix for alt/shift bug in <rdar://problem/3655817> fix from TOT.
2005-04-27 John Sullivan <sullivan@apple.com>
Reviewed by Adele.
- fixed problem with mouse wheel patch where alt and shift keys were switched
- khtml/xml/dom2_eventsimpl.h: use the order cntl, alt, shift, meta in KeyboardEventImpl constructors to match superclass. This isn't necessary to fix the bug, but is better for clarity.
- khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): switch parameter order to match superclass. Then pass the parameters to superclass's constructor in the right order. (KeyboardEventImpl::initKeyboardEvent): Pass parameters to superclass's constructor in the right order.
- 2:34 PM Changeset in webkit [9067] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Experimental prototype of user-resizable textareas. All the new code is guarded by
#if ALLOW_RESIZING_TEXTAREAS, which is false unless you remove a comment and rebuild.
This code allows you to press near the bottom-right corner of any textarea and drag
to resize the textarea on the page. It works correctly with textareas in left-aligned
or centered blocks, but is weird in right-aligned blocks. It also does something
sensible if the width is specified as a % (in that case, you can resize vertically only).
The user-created-size survives resizing the window and survives the back/forward cache.
It does not survive reloading the page.
This complete-lack-of-affordance UI is obviously not shippable, but this proof of concept
code could lead to a real user feature.
- kwq/KWQTextArea.mm: (-[KWQTextArea getNumColumns:andNumRows:forSize:]): new method that determines cols and rows for a given textarea frame size (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): new method that tracks a drag and does a live resize-and-relayout (-[KWQTextAreaTextView mouseDown:]): if the mouse down is in the bottom-right corner, call _trackResizeFromMouseDown:
- 2:32 PM Changeset in webkit [9066] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
- fixed problem with mouse wheel patch where alt and shift keys were switched
- khtml/xml/dom2_eventsimpl.h: use the order cntl, alt, shift, meta in KeyboardEventImpl constructors to match superclass. This isn't necessary to fix the bug, but is better for clarity.
- khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): switch parameter order to match superclass. Then pass the parameters to superclass's constructor in the right order. (KeyboardEventImpl::initKeyboardEvent): Pass parameters to superclass's constructor in the right order.
- 11:36 AM Changeset in webkit [9065] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiAtlanta - WebCore-415.1
- 10:59 AM Changeset in webkit [9064] by
-
- 2 edits in trunk/WebKit
Reviewed by Dave Harrison.
- fixed <rdar://problem/3547489> pop-up window blocking preference and menu item can easily get out of sync.
- WebView.subproj/WebPreferences.m: (-[WebPreferences _setStringValue:forKey:]): save local value before setting value in NSUserDefaults, so clients reacting to NSUserDefaults change notification but calling back on WebPreferences API will see the updated value. (-[WebPreferences _setIntegerValue:forKey:]): ditto (-[WebPreferences _setBoolValue:forKey:]): ditto
- 9:58 AM Changeset in webkit [9063] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Removed fix for 4032346 and merged new fix as described in 4097842.
2005-04-18 David Hyatt <hyatt@apple.com>
Back out fix for 4032346, since it is causing garbled image content on many sites.
The bug tracking the fix is 4069093.
(khtml::RenderBlock::matchedEndLine):
2005-04-25 David Hyatt <hyatt@apple.com>
Fix for 4097842, changing 1st line of a url that wraps doesn't update the second line. Make sure to
update line break info for the last dirty line so that when a clean line tries to figure out where it
started, it will get an accurate position taking into account the updated string. By doing this, the code
will be able to properly distinguish between the old and new positions and not accidentally assume they are
the same.
Reviewed by darin
- khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
Apr 26, 2005:
- 10:52 PM Changeset in webkit [9062] by
-
- 8 edits in trunk
Fixed by Darin, reviewed by me.
Fix for <rdar://problem/4084029> designMode doesn't allow editing when iframe src = "" or = about:blank
This change will add an HTML element for empty documents. Now that there will be an HTMLDocument in this case,
a body will also be created (see rdar://problem/3758785). This was preventing frames with empty documents from
being editable.
- khtml/html/htmlparser.cpp: (KHTMLParser::finished):
Updated these tests to expect the HTML and BODY elements
- layout-tests/fast/flexbox/016-expected.txt:
- layout-tests/fast/frames/001-expected.txt:
- layout-tests/fast/frames/002-expected.txt:
- layout-tests/fast/frames/contentWindow_Frame-expected.txt:
- layout-tests/fast/frames/contentWindow_iFrame-expected.txt:
- layout-tests/fast/frames/empty-frame-src-expected.txt:
- 6:03 PM Changeset in webkit [9061] by
-
- 8 edits in trunk
Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla
We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:
Their NPN_SetException has the following signature:
void NPN_SetException(NPObject *npobj, const NPUTF8 *message);
ours has:
void NPN_SetException (NPObject * npobj, const NPString *message);
Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.
I changed both behaviors to match Mozilla.
Reviewed by Chris.
- bindings/NP_jsobject.cpp: (_NPN_SetException):
- bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
- bindings/npruntime.h:
- bindings/npruntime_impl.h:
WebKit:
Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla
Reviewed by Chris.
- Plugins.subproj/npfunctions.h:
- Plugins.subproj/npruntime.h:
- 5:58 PM Changeset in webkit [9060] by
-
- 25 edits in branches/Safari-2-0-branch/WebCore
Merged for 3655817 from TOT
Reviewed by Adele.
2005-04-26 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler
Loose ends:
- need to test behavior of Windows IE with horizontal scroll wheeling; we currently send a distinct event for that relatively obscure case, which means the event handlers won't fire at all; might be incorrect
- overflow scrolling is done after all DOM event handling, but ideally should be done in the overflowing element's default event handler; not important in practice
- frame scrolling is done after all DOM event handling, but probably should be done in a default event handler; not sure about this, but it's probably not important in practice and definitely not required
- JavaScript
- khtml/ecma/kjs_events.h: Added DOMWheelEvent.
- khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added a case for wheel event. To be forward looking, I use the event's impl pointer instead of a C++ DOM wrapper. Eventually it will all work this way. (offsetFromTarget): Added. Factored out code to compute offsetX/Y for an event. (DOMMouseEvent::getValueProperty): Changed to call offsetFromTarget for offsetX/Y. (DOMWheelEvent::DOMWheelEvent): Added. (DOMWheelEvent::tryGet): Added. (DOMWheelEvent::getValueProperty): Added. (DOMWheelEventProtoFunc::tryCall): Added. Nothing at the moment, but might get contents later.
- khtml/ecma/kjs_dom.h: Added OnMouseWheel to the enum with the list of properties.
- khtml/ecma/kjs_dom.cpp: Added onmousewheel as a property of DOM nodes. (DOMNode::getValueProperty): Return the mouse wheel event handler. (DOMNode::putValue): Set the mouse wheel event handler.
- khtml/ecma/kjs_window.cpp: Added onmousewheel as a property of the window. (Window::get): Return the mouse wheel event handler. (Window::put): Set the mouse wheel event handler.
- khtml/ecma/kjs_window.h: Added OnWindowMouseWheel to the enum with the list of properties. (Other properties distinguish the window handler by lower-casing the initial letter, way too subtle, so I did this one a good way.)
- khtml/dom/dom2_events.h: Made the constructors for Event and UIEvent public. There's no good reason for them to be private, and I had to use the UIEvent one in the JavaScript implementation.
- DOM
- khtml/xml/dom2_eventsimpl.h: Added events for mouse wheel and horizontal mouse wheel. Added isWheelEvent function to EventImpl. (DOM::UIEventWithKeyStateImpl): Added. Base class shared by mouse, wheel, and keyboard events. (DOM::MouseRelatedEventImpl): Added. Base class shared by mouse and wheel events. (DOM::WheelEventImpl): Added.
- khtml/xml/dom2_eventsimpl.cpp: Added "mousewheel" to list of event names and a placeholder for the horizontal mouse wheel. (EventImpl::isWheelEvent): Added. Returns false. (MouseRelatedEventImpl::MouseRelatedEventImpl): Added. Factored out what's shared between mouse events and wheel events to avoid duplicated code. (MouseRelatedEventImpl::computeLayerPos): Moved to MouseRelatedWheelEventImpl. (MouseEventImpl::MouseEventImpl): Changed since MouseRelatedWheelEventImpl is now the base class so we can share more code with wheel events. (KeyboardEventImpl::KeyboardEventImpl): Changed since UIEventWithKeyStateImpl is now the base class so we can share more code with mouse and wheel events. (WheelEventImpl::WheelEventImpl): Added. (WheelEventImpl::isWheelEvent): Added. Returns true.
- khtml/misc/htmlattrs.in: Added "onmousewheel" attribute name.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Added parsing of the "onmousewheel" atribute, consistent with other event handler attributes.
- event handling
- kwq/WebCoreBridge.h: Renamed scrollOverflowWithScrollWheelEvent to sendScrollWheelEvent.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollWheelEvent:]): Renamed.
- kwq/KWQEvent.h: Added Wheel as an event type value. (QWheelEvent::QWheelEvent): Added.
- kwq/KWQEvent.mm: (positionForEvent): Updated to know that wheel events have valid positions in them. (orientationForEvent): Added. (deltaForEvent): Added. (QWheelEvent::QWheelEvent): Added.
- kwq/KWQKHTMLPart.h: Renamed scrollOverflowWithScrollWheelEvent to wheelEvent.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): Renamed and added code to construct a QWheelEvent and send it along to KHTMLView::viewportWheelEvent, consistent with how mouse events work.
- khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): Do a hit test to figure out which node to send the event to, and then call dispatchWheelEvent.
- khtml/xml/dom_nodeimpl.h: Added dispatchWheelEvent.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWheelEvent): Added.
- generated files
- khtml/ecma/kjs_dom.lut.h: Regenerated.
- khtml/ecma/kjs_events.lut.h: Regenerated.
- khtml/ecma/kjs_window.lut.h: Regenerated.
- khtml/misc/htmlattrs.c: Regenerated.
- khtml/misc/htmlattrs.h: Regenerated.
- 5:18 PM Changeset in webkit [9059] by
-
- 3 edits2 adds in trunk
Reviewed by Chris.
<rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com
- kjs/string_object.cpp: (StringObjectFuncImp::call): Allocate adopted ustring buffer properly.
WebCore:
New test case for <rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com
- layout-tests/fast/js/string-from-char-code-expected.txt: Added.
- layout-tests/fast/js/string-from-char-code.html: Added.
- 5:11 PM Changeset in webkit [9058] by
-
- 5 edits in branches/Safari-2-0-branch
Merging fix for <rdar://problem/4075576> from TOT
Reviewed by Adele.
2005-04-26 David Harrison <harrison@apple.com>
Reviewed by Darin, Maciej.
<rdar://problem/4075576> Deleting text in new message borks content
Fixed by removing the methods that attempted to preserve the position. The idea
of preserving position is a very recent one, and turned out to not actually address
the problem it was intended to fix (see below). Further, is unclear how the position
could be preserved in a form that could be properly used later on. Therefore,
removing the code to work like before is the preferred alternative for this software
update. I've written <rdar://problem/4099839> to cover the bug that position
preservation was supposed to fix (but did not). Added layout tests for
both this bug and 4099839. Also, updated existing tests with correct expected results
(delete-at-paragraph-boundaries-003 and 004).
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeFullySelectedNode): (khtml::CompositeEditCommand::removeChildrenInRange): (khtml::DeleteSelectionCommand::handleGeneralDelete):
- khtml/editing/htmlediting.h:
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- 4:36 PM Changeset in webkit [9057] by
-
- 28 edits in trunk
WebCore:
Reviewed by John.
- fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler
Loose ends:
- need to test behavior of Windows IE with horizontal scroll wheeling; we currently send a distinct event for that relatively obscure case, which means the event handlers won't fire at all; might be incorrect
- overflow scrolling is done after all DOM event handling, but ideally should be done in the overflowing element's default event handler; not important in practice
- frame scrolling is done after all DOM event handling, but probably should be done in a default event handler; not sure about this, but it's probably not important in practice and definitely not required
- JavaScript
- khtml/ecma/kjs_events.h: Added DOMWheelEvent.
- khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added a case for wheel event. To be forward looking, I use the event's impl pointer instead of a C++ DOM wrapper. Eventually it will all work this way. (offsetFromTarget): Added. Factored out code to compute offsetX/Y for an event. (DOMMouseEvent::getValueProperty): Changed to call offsetFromTarget for offsetX/Y. (DOMWheelEvent::DOMWheelEvent): Added. (DOMWheelEvent::tryGet): Added. (DOMWheelEvent::getValueProperty): Added. (DOMWheelEventProtoFunc::tryCall): Added. Nothing at the moment, but might get contents later.
- khtml/ecma/kjs_dom.h: Added OnMouseWheel to the enum with the list of properties.
- khtml/ecma/kjs_dom.cpp: Added onmousewheel as a property of DOM nodes. (DOMNode::getValueProperty): Return the mouse wheel event handler. (DOMNode::putValue): Set the mouse wheel event handler.
- khtml/ecma/kjs_window.cpp: Added onmousewheel as a property of the window. (Window::get): Return the mouse wheel event handler. (Window::put): Set the mouse wheel event handler.
- khtml/ecma/kjs_window.h: Added OnWindowMouseWheel to the enum with the list of properties. (Other properties distinguish the window handler by lower-casing the initial letter, way too subtle, so I did this one a good way.)
- khtml/dom/dom2_events.h: Made the constructors for Event and UIEvent public. There's no good reason for them to be private, and I had to use the UIEvent one in the JavaScript implementation.
- DOM
- khtml/xml/dom2_eventsimpl.h: Added events for mouse wheel and horizontal mouse wheel. Added isWheelEvent function to EventImpl. (DOM::UIEventWithKeyStateImpl): Added. Base class shared by mouse, wheel, and keyboard events. (DOM::MouseRelatedEventImpl): Added. Base class shared by mouse and wheel events. (DOM::WheelEventImpl): Added.
- khtml/xml/dom2_eventsimpl.cpp: Added "mousewheel" to list of event names and a placeholder for the horizontal mouse wheel. (EventImpl::isWheelEvent): Added. Returns false. (MouseRelatedEventImpl::MouseRelatedEventImpl): Added. Factored out what's shared between mouse events and wheel events to avoid duplicated code. (MouseRelatedEventImpl::computeLayerPos): Moved to MouseRelatedWheelEventImpl. (MouseEventImpl::MouseEventImpl): Changed since MouseRelatedWheelEventImpl is now the base class so we can share more code with wheel events. (KeyboardEventImpl::KeyboardEventImpl): Changed since UIEventWithKeyStateImpl is now the base class so we can share more code with mouse and wheel events. (WheelEventImpl::WheelEventImpl): Added. (WheelEventImpl::isWheelEvent): Added. Returns true.
- khtml/misc/htmlattrs.in: Added "onmousewheel" attribute name.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Added parsing of the "onmousewheel" atribute, consistent with other event handler attributes.
- event handling
- kwq/WebCoreBridge.h: Renamed scrollOverflowWithScrollWheelEvent to sendScrollWheelEvent.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollWheelEvent:]): Renamed.
- kwq/KWQEvent.h: Added Wheel as an event type value. (QWheelEvent::QWheelEvent): Added.
- kwq/KWQEvent.mm: (positionForEvent): Updated to know that wheel events have valid positions in them. (orientationForEvent): Added. (deltaForEvent): Added. (QWheelEvent::QWheelEvent): Added.
- kwq/KWQKHTMLPart.h: Renamed scrollOverflowWithScrollWheelEvent to wheelEvent.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): Renamed and added code to construct a QWheelEvent and send it along to KHTMLView::viewportWheelEvent, consistent with how mouse events work.
- khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): Do a hit test to figure out which node to send the event to, and then call dispatchWheelEvent.
- khtml/xml/dom_nodeimpl.h: Added dispatchWheelEvent.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWheelEvent): Added.
- generated files
- khtml/ecma/kjs_dom.lut.h: Regenerated.
- khtml/ecma/kjs_events.lut.h: Regenerated.
- khtml/ecma/kjs_window.lut.h: Regenerated.
- khtml/misc/htmlattrs.c: Regenerated.
- khtml/misc/htmlattrs.h: Regenerated.
WebKit:
Reviewed by John.
- fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollWheel:]): Call sendScrollWheelEvent: method instead of the old scrollOverflowWithScrollWheelEvent: (just a name change).
- 3:50 PM Changeset in webkit [9056] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
2005-04-26 chris petersen <cpetersen@apple.com>
Merging fix for <rdar://problem/4069161> from TOT
Reviewed by Adele.
2005-03-28 David Harrison <harrison@apple.com>
Reviewed by Darin.
<rdar://problem/4069161> REGRESSION (8A416-8A419): Safari crash bringing up context menu for non-HTML content in a frame
- kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]): Nil-check node variable instead of rechecking document variable.
- 3:50 PM Changeset in webkit [9055]
-
- 6 copies in branches/Safari-2-0-branch
This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.
- 3:39 PM Changeset in webkit [9054] by
-
- 5 edits8 adds in trunk
Reviewed by Darin, Maciej.
<rdar://problem/4075576> Deleting text in new message borks content
Fixed by removing the methods that attempted to preserve the position. The idea
of preserving position is a very recent one, and turned out to not actually address
the problem it was intended to fix (see below). Further, is unclear how the position
could be preserved in a form that could be properly used later on. Therefore,
removing the code to work like before is the preferred alternative for this software
update. I've written <rdar://problem/4099839> to cover the bug that position
preservation was supposed to fix (but did not). Added layout tests for
both this bug and 4099839. Also, updated existing tests with correct expected results
(delete-at-paragraph-boundaries-003 and 004).
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeFullySelectedNode): (khtml::CompositeEditCommand::removeChildrenInRange): (khtml::DeleteSelectionCommand::handleGeneralDelete):
- khtml/editing/htmlediting.h:
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-007.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-008.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-009.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-010.html: Added.
- 2:20 PM Changeset in webkit [9053] by
-
- 2 edits in trunk/WebCore
- fixed development builds
- khtml/misc/main_thread_malloc.h: Use inlines instead of macros for allocation functions.
- 2:12 PM Changeset in webkit [9052] by
-
- 2 edits in trunk/WebCore
Fix for 4097842, changing 1st line of a url that wraps doesn't update the second line. Make sure to
update line break info for the last dirty line so that when a clean line tries to figure out where it
started, it will get an accurate position taking into account the updated string. By doing this, the code
will be able to properly distinguish between the old and new positions and not accidentally assume they are
the same.
Reviewed by darin
- khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
- 2:02 PM Changeset in webkit [9051] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed <rdar://problem/4098826> Bezier curves broken in new Safari canvas object (last two parameters parsed incorrectly)
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Fixed incorrect argument indices. Thanks to Brian Campbell who figured out what was wrong.
- 11:46 AM Changeset in webkit [9050] by
-
- 21 edits3 adds in trunk/WebCore
Reviewed by Darin.
- use single-threaded malloc in places where malloc is hot for an 8% speed improvement on cvs-base
- ForwardingHeaders/misc/fast_malloc.h: Added.
- WebCore.pbproj/project.pbxproj:
- khtml/css/css_base.h:
- khtml/css/css_ruleimpl.h:
- khtml/css/css_valueimpl.h:
- khtml/css/cssstyleselector.h:
- khtml/misc/arena.cpp: (ArenaAllocate): (FreeArenaList): (ArenaFinish):
- khtml/misc/main_thread_malloc.cpp: Added.
- khtml/misc/main_thread_malloc.h: Added.
- khtml/rendering/render_style.h:
- khtml/xml/dom2_eventsimpl.h:
- khtml/xml/dom2_rangeimpl.h:
- khtml/xml/dom2_traversalimpl.h:
- khtml/xml/dom2_viewsimpl.h:
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::NamedAttrMapImpl): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
- khtml/xml/dom_elementimpl.h:
- khtml/xml/dom_nodeimpl.h:
- khtml/xml/dom_stringimpl.h:
- kwq/KWQFontFamily.h:
- kwq/KWQListImpl.mm:
- kwq/KWQString.h:
- kwq/KWQString.mm: (ALLOC_CHAR): (ALLOC_QCHAR): (QString::setBufferFromCFString): (allocatePageNode):
Note:
See TracTimeline
for information about the timeline view.
