⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 26, 2005:

10:33 PM Changeset in webkit [9488] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/build-dumprendertree: Pass -project option so that having a second copy of the project (like the one Xcode 2.1 offers to make for you) that's out of date won't screw you up.
  • Scripts/build-webkit: Ditto.

Jun 25, 2005:

10:21 AM Changeset in webkit [9487] by darin
  • 2 edits
    2 adds in trunk
  • updated a layout test so that it doesn't depend on a remote resource via http
  • layout-tests/fast/backgrounds/001.html: Change image URL to be relative.
  • layout-tests/fast/backgrounds/resources/bg_position_larger.gif: Added.

Jun 24, 2005:

10:17 PM Changeset in webkit [9486] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-explicit-embedding.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::embed): Set up the new run correctly following an embed/pop. (khtml::RenderBlock::bidiReorderLine): Close the "dangling" run when we see an explicit embedding character (or PDF).
9:47 PM Changeset in webkit [9485] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-CS-after-AN.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Rolled in the patch from the KDE tree.
2:05 PM Changeset in webkit [9484] by justing
  • 3 edits in trunk/WebCore

Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer, and adds a QBuffer(QByteArray) constructor.

Reviewed by Darin

Test cases added: Non required

  • kwq/KWQBuffer.h: (QBuffer::QBuffer):
  • kwq/KWQBuffer.mm: (QBuffer::setBuffer):
1:48 PM Changeset in webkit [9483] by justing
  • 2 edits in trunk/WebKit

Patch contributed by Duncan Wilcox <​duncan@mclink.it>

Reviewed by Darin

Spelling suggestions in the context menu don't call the should* delegate methods

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _changeSpellingFromMenu:]): give delegate's webView:shouldInsertText:replacingDOMRange:givenAction: a chance to prevent replacing of selected text
11:57 AM Changeset in webkit [9482] by justing
  • 4 edits in trunk/WebCore

Reviewed by Darin

Test cases added: None required

  • kwq/KWQRect.h: (QRect::contains):
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::topRight): (QRect::bottomLeft): (QRect::normalize): (QRect::operator CGRect):
  • kwq/KWQString.h: (QChar::): (QString::remove):
9:48 AM Changeset in webkit [9481] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Justin Garcia.

  • fixed <rdar://problem/4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"

Test cases added:

  • layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
  • layout-tests/fast/dom/anchor-backslash.html: Added.
  • kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore "?" and "#" characters if they were the first character in the string.

Jun 23, 2005:

10:59 PM Changeset in webkit [9480] by darin
  • 2 edits in trunk/WebCore
  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue): Took out an unneeded type cast (meant to do that before committing).
10:53 PM Changeset in webkit [9479] by darin
  • 15 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/forms/selection-functions-expected.txt: Added.
  • layout-tests/fast/forms/selection-functions.html: Added.
  • layout-tests/fast/forms/textarea-crlf-expected.txt: Added.
  • layout-tests/fast/forms/textarea-crlf.html: Added.
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.cpp: (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::KJS::HTMLElement::getValueProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLElementFunction::tryCall): (KJS::HTMLElement::putValue):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::canHaveSelection): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::setValue): (DOM::HTMLTextAreaElementImpl::selectionStart): (DOM::HTMLTextAreaElementImpl::selectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionStart): (DOM::HTMLTextAreaElementImpl::setSelectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionRange): (DOM::HTMLTextAreaElementImpl::setValue):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::setSelectionRange): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::select): (RenderTextArea::setSelectionRange):
  • khtml/rendering/render_form.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setCursorPosition): (QLineEdit::cursorPosition): (QLineEdit::selectAll): (QLineEdit::selectionStart): (QLineEdit::selectedText): (QLineEdit::setSelection):
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextArea setSelectedRange:]): (-[KWQTextArea selectedRange]): (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::getCursorPosition): (QTextEdit::selectionStart): (QTextEdit::selectionEnd): (QTextEdit::setSelectionStart): (QTextEdit::setSelectionEnd): (QTextEdit::selectAll): (QTextEdit::setSelectionRange):
  • kwq/KWQTextField.h:
  • kwq/KWQTextField.mm: (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]):
2:52 PM Changeset in webkit [9478] by justing
  • 2 edits in trunk/WebCore

Patch by Eric Seidel <​macdome@opendarwin.org>

Adds QTextIStream, QTextOStream to KWQ

Reviewed by Darin

Test cases added: None required

  • kwq/KWQTextStream.h: (QTextIStream::QTextIStream): (QTextOStream::QTextOStream):
2:25 PM Changeset in webkit [9477] by justing
  • 6 edits in trunk/WebCore

Patch by Eric Seidel <​macdome@opendarwin.org>

This patch contains several small additions to KWQ

Reviewed by Darin

Test cases added: None required

  • kwq/KWQApplication.h: (QApplication::palette):
  • kwq/KWQDateTime.h: (QDateTime::time):
  • kwq/KWQDict.h: (QDict::operator[]): (QDictIterator::operator*):
  • kwq/KWQKDebug.h: (kdbgstream::operator<<):
  • kwq/KWQMemArray.h: (QMemArray::duplicate):
12:47 PM Changeset in webkit [9476] by harrison
  • 13 edits in trunk/WebCore

Test cases added: None needed for this debug-only utility code.

  • Make showTree() const.
  • Add showTree() for InlineBox.
  • Add showTree() for RenderObject.
  • khtml/editing/selection.cpp: (khtml::Selection::showTree):
  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::showTree):
  • khtml/editing/visible_position.h: Make showTree() const.
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::showTree):
  • khtml/rendering/render_line.h: Add showTree() for InlineBox.
  • khtml/rendering/render_object.cpp: (RenderObject::showTree):
  • khtml/rendering/render_object.h: Add showTree() for RenderObject.
  • khtml/xml/dom_nodeimpl.cpp: (appendAttributeDesc): (NodeImpl::showNode): (NodeImpl::showTree): (NodeImpl::showTreeAndMark):
  • khtml/xml/dom_nodeimpl.h: Make showTree() const.
12:13 PM Changeset in webkit [9475] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • added template to be used when writing manual tests
  • manual-tests/template.html: Added.
8:00 AM Changeset in webkit [9474] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Fixed a regular expression in the code I just landed.
7:53 AM Changeset in webkit [9473] by darin
  • 3 edits in trunk/WebKitTools

Changes based on input from Michael Kahl.

  • Scripts/cvs-create-patch: Added code to handle getting changes in the top-level directory passed in.
  • Scripts/webkitdirs.pm: Eliminate use of changing the current directory and using getcwd() in the code to find the base product dir. Added code to handle unusual base product directory values that use SRCROOT.

Jun 22, 2005:

8:15 PM Changeset in webkit [9472] by darin
  • 2 edits
    4 adds in trunk/WebCore
  • ForwardingHeaders/kjs/value.h: Added.
  • ForwardingHeaders/qintdict.h: Added an include.
  • ForwardingHeaders/qptrcollection.h: Added.
  • ForwardingHeaders/qsize.h: Added.
  • kwq/KWQIntDict.h: Added. Empty file.
2:32 PM Changeset in webkit [9471] by sullivan
  • 9 edits
    1 add in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/3764645> please add a way to allow WebKit clients to override the WebPDFView context menu
  • PublicHeaderChangesFromTiger.txt: Added. New file to keep track of changes made to public headers that haven't been through API review yet. Initially lists the WebMenuItem enum tags added to WebUIDelegate.h as part of this change.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate appendDefaultItems:toArray:]): new method, handles initial separator (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): now has defaultMenuItems: parameter. Any menu items in this array are appended at the end of the standard set. (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): This had a defaultMenuItems parameter before but it was always nil. Now it passes the defaultMenuItems parameter on to the two methods that construct lists (one for editing, the other for viewing). Also tweaked variable name and type for clarity.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): passes nil for new defaultItems parameter of _menuForElement:
  • WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): ditto
  • WebView.subproj/WebPDFView.m: (-[WebPDFView elementAtPoint:]): new method to create the element dictionary needed for _menuForElement:defaultItems:. Only supplies the webFrame at this point. (-[WebPDFView _menuItemsFromPDFKitForEvent:]): new method to return copies of the menu items that PDFKit would include in the context menu, with WebKit tags applied (-[WebPDFView menuForEvent:]): now calls standard WebKit context menu mechanism, so clients' delegates can modify the context menu as desired. The initial set of items are the ones WebKit was already displaying for PDF context menus.
  • WebView.subproj/WebUIDelegate.h: added enum values for the menu items in the PDF context menu
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]): Added the defaultItems: parameter to this method, which is then passed along to WebDefaultUIDelegate. All callers pass nil except for WebPDFView, at least for now.
2:05 PM Changeset in webkit [9470] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Vicki.

Test cases added:

  • layout-tests/fast/css/apple-prefix-expected.txt: Added.
  • layout-tests/fast/css/apple-prefix.html: Added.
  • fixed <rdar://problem/4141650> REGRESSION: Safari RSS slider broken with TOT WebCore
  • khtml/css/parser.y: (getPropertyID): Fix lifetime problem on the QString. Also construct the QString using length, since the passed-in char * is not necessarily null-terminated. Also do the mapping only if it's a "-apple-" prefix -- the old code would do it for, e.g., "-applex-" too. The old code would not successfully map the "apple" in "appleLineClamp" to "khtml", and Dave changed things so that the internal name of all CSS attributes is "khtml" back in his 2005-05-03 check-in, breaking the use of appleLineClamp in RSS. (getValueID): Ditto.
11:37 AM Changeset in webkit [9469]
  • 35 copies
    2 deletes in tags/WebCore-413~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~1'.

11:37 AM Changeset in webkit [9468] by adele
  • 2 edits in branches/gcc-4-0-branch/WebCore

Fix versioning for gcc-4-0-branch - WebCore-413.0.1

11:23 AM Changeset in webkit [9467] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added more bug numbers to the change log.

11:22 AM Changeset in webkit [9466] by darin
  • 5 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/dom/title-text-property-expected.txt: Added
  • layout-tests/fast/dom/title-text-property.html: Added
  • layout-tests/fast/dom/title-text-property-expected-2.txt: Added
  • layout-tests/fast/dom/title-text-property-2.html: Added

Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3586>
Setting and getting title's text attribute does not work

  • khtml/dom/html_head.cpp: (HTMLTitleElement::text): (HTMLTitleElement::setText): Call HTMLTitleElementImpl::text() and ::setText().
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::HTMLTitleElementImpl): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::removedFromDocument): (HTMLTitleElementImpl::childrenChanged): Pass the current title node to DocumentImpl::setTitle and ::removeTitle.

(HTMLTitleElementImpl::text):
Return the title.

(HTMLTitleElementImpl::setText):
Set the new title.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::setTitle): (DocumentImpl::removeTitle):
  • khtml/xml/dom_docimpl.h: Only update the title if it's done by setting document.title or by changing the child nodes of the title element.
11:01 AM Changeset in webkit [9465] by darin
  • 2 edits in trunk/WebKitTools

Change by Anders Carlsson.

  • added support for dumping title changes
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didReceiveTitle:forFrame:]): Added. Dump title change if requested by JavaScript. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added dumpTitleChanges. (-[LayoutTestController dumpTitleChanges]): Added, sets flag. (dumpRenderTree): Start flag as NO.
10:39 AM Changeset in webkit [9464] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-L2-run-reordering-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-L2-run-reordering.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Fixed mistake where we'd advance too far after reversing a run.
10:29 AM Changeset in webkit [9463] by darin
  • 1 edit
    2 adds in trunk
  • layout-tests/fast/js/string-replace-2-expected.txt: Added.
  • layout-tests/fast/js/string-replace-2.html: Added.
10:26 AM Changeset in webkit [9462] by darin
  • 4 edits in trunk/JavaScriptCore

Change by Anders Carlsson.
Reviewed by me.

  • kjs/string_object.cpp: (replace): Added code to handle functions.
  • tests/mozilla/expected.html: Updated since ecma_3/RegExp/regress-209067.js is fixed now.
  • tests/mozilla/run-mozilla-tests: Fix a minor coding style issue that leads to a warning each time we run the tests.
9:44 AM Changeset in webkit [9461] by darin
  • 2 edits in trunk/WebKit

Change by Mitz Pettel.
Reviewed by me.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]): Fix off-by-one mistake in order-swapping loops.
9:38 AM Changeset in webkit [9460] by darin
  • 3 edits
    2 adds in trunk

Reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/dom/css-set-property-exception-expected.txt: Added.
  • layout-tests/fast/dom/css-set-property-exception.html: Added.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::tryPut): Ignore exceptions when setting properties.
  • layout-tests/fast/js/exception-linenums.html: Changed test case that involved setting style to one that involved setting another property that raises an exception when you try to set it (setting prefix on a text node).
9:20 AM Changeset in webkit [9459] by darin
  • 3 edits in trunk/WebKit

Change by Michael Gaiman.
Reviewed by me.

  • Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _webkit_parseRFC822HeaderFields]): Fixed method name.
8:31 AM Changeset in webkit [9458] by darin
  • 2 edits in trunk/WebCore

Change proposed by Eric Seidel.

  • WebCore.pbproj/project.pbxproj: Fix build rule to match the one in JavaScriptCore. The one here accidentally had hard-coded paths in it and also had the $() vs. ${} issue that broke building on Xcode 2.1 for no good reason (it didn't need $() or ${}).

Jun 21, 2005:

9:38 PM Changeset in webkit [9457] by mjs
  • 2 edits in trunk/WebCore

Patch from KevinBallard <Lily Ballard>, reviewed by me.

  • fix build for Xcode 2.1, use ${} for INPUT_FILE_BASE to fix build with Xcode 2.1
  • WebCore.pbproj/project.pbxproj:
6:15 PM Changeset in webkit [9456] by justing
  • 2 edits in trunk/WebCore
  • Fixes <rdar://problem/4114192>.
  • Fixes a crash in TOT Mail/Blot if you Edit -> Add Hyperlink on a Selection

that ends at the end of the document

  • Fixes a problem in TOT Mail/Blot where Edit -> Add Hyperlink creates

a link one character beyond what is expected.

In replacement, during insertion, some special case code was being called inappropriately.

Reviewed by Harrison

Test cases added: None, requires manual interaction

  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): In "step 2" of a replacement, we should only next() the insertion point if the special pre-insertion-merge actually occured. mergeStart used to be the correct check for the occurence of a pre-insertion-merge, but a bug fix made this not the case. A non-null m_lastNodeInserted correctly signals that some pre-insertion merging occured.
5:48 PM Changeset in webkit [9455] by adele
  • 28 edits
    4 deletes in trunk

JavaScriptCore:

rolling out fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress

  • ChangeLog:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasProperty): (KJS::ActivationImp::hasProperty):
  • kjs/function.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty):
  • kjs/object.h:
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasProperty):
  • kjs/string_object.h:
  • tests/mozilla/expected.html:

WebCore:

rolling out fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress

  • ChangeLog:
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasProperty): (KJS::DOMNamedNodeMap::hasProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLCollection::hasProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasProperty): (KJS::Konqueror::hasProperty):
  • khtml/ecma/kjs_window.h:
  • layout-tests/fast/js/eval-var-decl-expected.txt: Removed. This test used hasOwnProperty
  • layout-tests/fast/js/eval-var-decl.html: Removed. This test used hasOwnProperty
  • layout-tests/fast/js/hasOwnProperty-expected.txt: Removed.
  • layout-tests/fast/js/hasOwnProperty.html: Removed.
5:23 PM Changeset in webkit [9454] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • WebCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for the .y files -- this gets rid of the problem where modifying the .y file would not cause sufficient compilation.
  • khtml/css/parser_wrapper.cpp: Removed.
5:22 PM Changeset in webkit [9453] by darin
  • 2 edits
    1 delete in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for .y files -- this gets rid of the problem where modifying the .y file would not cause sufficient compilation.
  • kjs/grammar_wrapper.cpp: Removed.
4:02 PM Changeset in webkit [9452] by adele
  • 2 edits in trunk/JavaScriptCore

Patch from Anders Carlsson <​andersca@mac.com>, reviewed by Darin.

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

  • pcre/pcre.c: (pcre_compile): Remember the last char length so it can be subtracted correctly if needed.
4:02 PM Changeset in webkit [9451] by adele
  • 1 edit
    2 adds in trunk

Test cases for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

  • layout-tests/fast/js/string_replace-expected.txt: Added.
  • layout-tests/fast/js/string_replace.html: Added.
3:27 PM Changeset in webkit [9450] by ggaren
  • 7 edits
    4 adds in trunk

Patch contributed by Niels Leenheer <​niels.leenheer@gmail.com>

Reviewed by Darin.

  • khtml/dom/dom_string.cpp: (DOM::DOMString::toCoordsArray):
  • khtml/dom/dom_string.h:
  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::parseMappedAttribute):
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::toCoordsArray):
  • khtml/xml/dom_stringimpl.cpp: (DOM::parseLength): (DOM::DOMStringImpl::toCoordsArray): (DOM::DOMStringImpl::toLengthArray):
  • khtml/xml/dom_stringimpl.h:

Test cases added:

  • layout-tests/fast/frames/invalid-expected.txt: Added.
  • layout-tests/fast/frames/invalid.html: Added.
  • layout-tests/fast/frames/valid-expected.txt: Added.
  • layout-tests/fast/frames/valid.html: Added.
11:44 AM Changeset in webkit [9449] by ggaren
  • 1 edit
    2 adds in trunk
  • fixed <rdar://problem/4155049> javascript function named as "opener" doesn't get called because of window.opener property

Test cases only, fix is in JavaScriptCore

Reviewed by cblu.

Test cases added:

  • layout-tests/fast/js/global-opener-function-expected.txt: Added.
  • layout-tests/fast/js/global-opener-function.html: Added.
11:42 AM Changeset in webkit [9448] by ggaren
  • 3 edits in trunk/JavaScriptCore
  • fixed <rdar://problem/4155532> 'delete' succeeds on functions
  • fixed <rdar://problem/4155049> javascript function named as "opener" doesn't get called because of window.opener property

Reviewed by cblu.

  • kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Functions now have DontDelete and Internal attributes set when appropriate.

Test cases:

  • tests/mozilla/expected.html: Updated for one new success.
  • see also test case added in WebCore.
11:11 AM Changeset in webkit [9447] by harrison
  • 7 edits in trunk/WebCore

Reviewed by Justin.

  • show class and style attributes for element nodes
  • nil check the node being showTree'd
  • add Position::showTree()

Test cases added: None needed for this debug-only utility code.

  • khtml/editing/selection.cpp: (khtml::Selection::showTree):
  • nil check the node
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition):
  • comments (khtml::VisiblePosition::showTree):
  • nil check the node
  • khtml/xml/dom_nodeimpl.cpp: (appendAttributeDesc): (NodeImpl::showNode):
  • show class and style attributes for element nodes
  • khtml/xml/dom_position.cpp: (DOM::Position::showTree):
  • khtml/xml/dom_position.h:
  • add Position::showTree()
11:05 AM Changeset in webkit [9446] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley

  • fixed assertion failure Vicki ran into
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _forgetIconForIconURLString:]): Handle the case where there are no associated page URLs for the icon URL
1:25 AM Changeset in webkit [9445] by mjs
  • 8 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin(first pass) and Hyatt.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3576 (roll in support for "const" keyword from KDE tree)
  • make processVarDecls handle deletability of variables declared in an eval block the same as evaluate would
  • make eval() call processVarDecls - needed to match mozilla and to make the second change testable

I started with the KDE implementation of const but I ended up changing it a bit
to avoid the use of a global variable. Now instead of the global variable it distinguishes
const and var at the grammar level so the appropriate node can know the right kind of
declaration.

Test cases:

  • tests/mozilla/expected.html: Updated for one new test that is failing - we used to bail on it entirely because it checks for const support before starting.
  • see also test cases added in WebCore
  • kjs/grammar.y: Add rules for const declarations.
  • kjs/keywords.table: Add const keyword.
  • kjs/nodes.cpp: (VarDeclNode::VarDeclNode): Add parameter. (VarDeclNode::evaluate): Add const support. (VarDeclNode::processVarDecls): Add const support. (VarStatementNode::execute): Irrelevant change. (ForInNode::ForInNode): Tell our variable node that it's a variable.
  • kjs/nodes.h: (KJS::VarDeclNode::): Add declaration of type enum, extra constructor parameter. (KJS::VarStatementNode::VarStatementNode): Irrelevant change.
  • kjs/function.cpp: (KJS::GlobalFuncImp::call): Process var decls before evaluating.

WebCore:

Reviewed by Darin(first pass) and Hyatt.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3576 (roll in support for "const" keyword from KDE tree)
  • make processVarDecls handle deletability of variables declared in an eval block the same as evaluate would
  • make eval() call processVarDecls - needed to match mozilla and to make the second change testable

Test cases only, fix is in JavaScriptCore

Test cases added:

  • layout-tests/fast/js/const-expected.txt: Added.
  • layout-tests/fast/js/const.html: Added.
  • layout-tests/fast/js/eval-var-decl-expected.txt: Added.
  • layout-tests/fast/js/eval-var-decl.html: Added.

Jun 20, 2005:

5:08 PM Changeset in webkit [9444] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4155182> icon database retain counts can be incorrect after removing all icons

Replaced the concept of "future retain count per page URL" with a simpler concept of "retain count per
page URL", which is maintained even after the icon is actually loaded (unlike the future retain count).
The total retain count for an icon is now the sum of the retain counts per page URL along with any retain
count not associated with a page URL -- this is still needed for some internal housekeeping purposes.

  • Misc.subproj/WebIconDatabasePrivate.h: renamed iconURLToURLs -> iconURLToPageURLs for clarity renamed URLToIconURL -> pageURLToIconURL for clarity renamed futureURLToRetainCount -> pageURLToRetainCount (there's no more "future" aspect) renamed iconURLToRetainCount -> iconURLToExtraRetainCount (it now maintains only some of the retain count)
  • Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): updated for name changes only (-[WebIconDatabase init]): ditto (-[WebIconDatabase iconForURL:withSize:cache:]): ditto (-[WebIconDatabase iconURLForURL:]): ditto (-[WebIconDatabase retainIconForURL:]): just bump the retain count in pageURLToRetainCount, instead of behaving differently based on whether an icon had been loaded for this URL; this let me delete the internal method _retainFutureIconForURL: (-[WebIconDatabase releaseIconForURL:]): decrement the retain count in pageURLToRetainCount, then handle the case where the retain count for this page has gone to zero. I deleted the internal method _releaseFutureIconForURL: formerly called here. (-[WebIconDatabase removeAllIcons]): remove all the code that dealt with retain counts; this operation no longer affects retain counts (-[WebIconDatabase _setIconURL:forURL:]): remove the code that consolidated multiple retain counts for different page URLs into a single retain count; the multiple retain counts are now maintained even after the icon is loaded (-[WebIconDatabase _clearDictionaries]): updated for name changes only (-[WebIconDatabase _loadIconDictionaries]): ditto (-[WebIconDatabase _updateFileDatabase]): ditto (-[WebIconDatabase _totalRetainCountForIconURLString:]): new method, sums the retain counts associated with specific page URLs and the extra retain count not associated with specific page URLs (-[WebIconDatabase _retainIconForIconURLString:]): updated for name changes (-[WebIconDatabase _forgetIconForIconURLString:]): no longer affects retain counts at all; this is up to callers (-[WebIconDatabase _releaseIconForIconURLString:]): this now distinguishes the case where the retain count not associated with any page URLs hits zero from the case where the total retain count hits zero, and handles both
3:40 PM Changeset in webkit [9443] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Justin Garcia.

  • Scripts/run-webkit-tests: Report number of tests when they succeed.
3:00 PM Changeset in webkit [9442] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • added support for emptying the icon database
  • Misc.subproj/WebIconDatabase.h: just fixed a typo
  • Misc.subproj/WebIconDatabasePrivate.h: added WebPendingPublic category with method removeAllIcons, and declared WebIconDatabaseDidRemoveAllIconsNotification string.
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): new method, removes all known icons from memory and disk. There's one loose end, covered by radar bug 4155182, where it's possible for the icon database's retain counts to get off after this operation. I plan to fix this next. (-[WebIconDatabase _setIconURL:forURL:]): just fixed some extra whitespace (-[WebIconDatabase _forgetIconForIconURLString:]): new method, extracted from _releaseIconForIconURLString (-[WebIconDatabase _releaseIconForIconURLString:]): now calls extracted method
  • WebKit.exp: added _WebIconDatabaseDidRemoveAllIconsNotification
2:59 PM Changeset in webkit [9441] by mjs
  • 28 edits
    2 adds in trunk

JavaScriptCore:

Patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.

Test cases added:

  • tests/mozilla/expected.html: Updated for two fixed tests.
  • also added a layout test
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasOwnProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasOwnProperty): (KJS::ActivationImp::hasOwnProperty):
  • kjs/function.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty): (KJS::ObjectImp::hasOwnProperty):
  • kjs/object.h: (KJS::Object::hasOwnProperty):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasOwnProperty):
  • kjs/string_object.h:

WebCore:

Patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.

Test cases added:

  • layout-tests/fast/js/hasOwnProperty-expected.txt: Added.
  • layout-tests/fast/js/hasOwnProperty.html: Added.
  • also fixed two mozilla JS tests
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMNamedNodeMap::hasOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
  • khtml/ecma/kjs_window.h:
11:20 AM Changeset in webkit [9440] by ggaren
  • 2 edits
    2 adds in trunk

Changes by Darin. Layout tests by me. Reviewed by me.

Fixed <rdar://problem/4152454> crash in KJS::ExprStatementNode::execute(KJS::ExecState*) in World Clock widget with TOT.

Test cases added:

  • layout-tests/fast/dom/gc-4-expected.txt: Added.
  • layout-tests/fast/dom/gc-4.html: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2D::mark): mark now (1) checks for NULL pointers and (2) calls mark on its parent class (DOMObject::mark).

Jun 19, 2005:

10:52 PM Changeset in webkit [9439] by darin
  • 3 edits
    2 adds in trunk

Changes by both Anders Carlsson and me.
Reviewed by Maciej and me.

Test cases added:

  • layout-tests/fast/forms/element-order-expected.txt: Added.
  • layout-tests/fast/forms/element-order.html: Added.
  • khtml/html/html_formimpl.h: Added formElementIndex.
  • khtml/html/html_formimpl.cpp: (DOM::insertIntoVector): Added. (DOM::HTMLFormElementImpl::formElementIndex): Added. Computes an appropriate index for a form element, given the document position relative to the other elements. (DOM::HTMLFormElementImpl::registerFormElement): Use formElementIndex to determine where to insert the element in the formElements array.
10:24 PM Changeset in webkit [9438] by darin
  • 13 edits in trunk/WebCore

Changes by Anders Carlsson and me.
Reviewed by Maciej and me.

Test cases added: None. Could not figure out how to automate a test without
making enhancements to DumpRenderTree.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::select): Remove unneeded explicit call to onSelect() here -- now handled by the renderer.
  • khtml/rendering/render_form.h: Added declarations as needed below.
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotSelectionChanged): Add base class implementation that does nothing. (RenderLineEdit::RenderLineEdit): Connect the selection changed signal to our slot. (RenderLineEdit::slotSelectionChanged): Call onSelect when selection changes to something that's a selection (not a caret). (RenderTextArea::RenderTextArea): Connect as above. (RenderTextArea::slotSelectionChanged): Call as above.
  • kwq/KWQLineEdit.h: Added declarations as needed below.
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Added selectionChanged signal. (QLineEdit::hasSelectedText): Added.
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Make selectionChanged work on any form element. (KWQSlot::call): ditto.
  • kwq/KWQTextArea.h: Added hasSelection method.
  • kwq/KWQTextArea.mm: (-[KWQTextArea textViewDidChangeSelection:]): Added. Sends selectionChanged signal, except if we're in the middle of gaining or losing first responder. (-[KWQTextArea hasSelection]): Added. (-[KWQTextAreaTextView becomeFirstResponder]): Added. Sets flag to tell us we're in a responder change (using a count to avoid trouble if we reenter). (-[KWQTextAreaTextView resignFirstResponder]): Ditto. (-[KWQTextAreaTextView inResponderChange]): Added.
  • kwq/KWQTextEdit.h: Added declarations as needed below.
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Added selectionChanged signal. (QTextEdit::hasSelectedText): Added.
  • kwq/KWQTextField.h: Added declarations as needed below.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Fixed up to do the right thing with the result of the init function we call. (-[KWQTextFieldController controlTextDidEndEditing:]): Removed call to setHasFocus:NO since it's a little too late by the time the control is called; now handled by the text view delegate methods below. (-[KWQTextFieldController hasSelection]): Added. (-[KWQTextFieldController setHasFocus:]): Sets the new hasFocusAndSelectionSet after new focus and selection are both set up. (-[KWQTextFieldController textViewDidChangeSelection:]): Added. Sends the selection changed signal. (-[KWQTextField initWithQLineEdit:]): Fixed up to do the right thing with the result of the init function we call. (-[KWQTextField textViewDidChangeSelection:]): Added. Calls super and then calls the controller. (-[KWQTextField textDidEndEditing:]): Added. Calls setHasFocus:NO and then calls super. (-[KWQSecureTextField initWithQLineEdit:]): Same as above, but for secure text fields. (-[KWQSecureTextField textViewDidChangeSelection:]): Ditto. (-[KWQSecureTextField textDidEndEditing:]): Ditto. (-[KWQSearchField initWithQLineEdit:]): Same as above, but for search fields. (-[KWQSearchField textViewDidChangeSelection:]): Ditto. (-[KWQSearchField textDidEndEditing:]): Ditto. (-[KWQTextFieldFormatter init]): Fixed up to do the right thing with the result of the init function we call.
6:20 PM Changeset in webkit [9437] by darin
  • 2 edits in trunk/WebKit

Changes by Mitz Pettel
Reviewed by me.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Translate the matrix of the CGContext instead of passing the appropriate coordinates to ATSU.

Jun 18, 2005:

11:42 PM Changeset in webkit [9436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Add more auto-release pools in the hope of making the tool use less memory and run faster.
11:38 PM Changeset in webkit [9435] by darin
  • 2 edits
    2 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/dom/css-dom-read-expected.txt: Added.
  • layout-tests/fast/dom/css-dom-read.html: Added.
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::item): Get the style from the m_values list.
11:21 PM Changeset in webkit [9434] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

  • pcre/get.c: (pcre_get_substring): Fix some computations so this works for UTF-16. This is unused in the current JavaScriptCore, but still good to fix.
11:03 PM Changeset in webkit [9433] by darin
  • 2 edits in trunk/WebCore
  • undid a last minute change I made that broke a patch I landed (layout tests caught the mistake, all should work again now)
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Don't include this when iterating. (DOM::HTMLLegendElementImpl::formElement): Ditto.
10:50 PM Changeset in webkit [9432] by darin
  • 1 edit
    6 deletes in trunk
  • disabling the applet tests, since they are causing other tests to fail
  • layout-tests/fast/replaced/applet-hspace-expected.txt: Removed.
  • layout-tests/fast/replaced/applet-hspace.html: Removed.
  • layout-tests/fast/replaced/applet-vspace-expected.txt: Removed.
  • layout-tests/fast/replaced/applet-vspace.html: Removed.
  • layout-tests/fast/replaced/resources/applet.class: Removed.
  • layout-tests/fast/replaced/resources/applet.java: Removed.
10:44 PM Changeset in webkit [9431] by darin
  • 4 edits
    5 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/dom/resources/script3.js: Added.
  • layout-tests/fast/dom/resources/script4.js: Added.
  • layout-tests/fast/dom/resources/script5.js: Added.
  • layout-tests/fast/dom/script-add-expected.txt: Added.
  • layout-tests/fast/dom/script-add.html: Added.
  • khtml/html/html_headimpl.h: Added override of childrenChanged, new evaluateScript function, and m_evaluated boolean.
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): Init m_evaluated to false. (HTMLScriptElementImpl::childrenChanged): Added code to evaluate the script the first time a child is added (except for nodes created by parsing). (HTMLScriptElementImpl::insertedIntoDocument): Refactored to use the new text and evaluateScript functions. Also changed to not try to evaluate the script if the element is entirely empty. This allows you to declare an empty <script> element and fill the content in later using DHTML. (HTMLScriptElementImpl::notifyFinished): Refactored to use the new evaluateScript function. (HTMLScriptElementImpl::evaluateScript): Added. Checks and sets a new m_evaluated boolean to implement the "evaluate each script only once" rule. (HTMLScriptElementImpl::text): Replaced bogus implementation with one that works. (HTMLScriptElementImpl::setText): Ditto.
  • khtml/dom/html_head.cpp: (HTMLScriptElement::text): Replaced bogus implementation with one that calls through to the implementation class. This change doesn't really matter since we don't compile this file. (HTMLScriptElement::setText): Ditto.
10:31 PM Changeset in webkit [9430] by darin
  • 2 edits in trunk/WebCore
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Oops, checked in a version that didn't even compile! Fixed now.
10:00 PM Changeset in webkit [9429] by darin
  • 6 edits
    4 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/forms/focus-expected.txt: Added.
  • layout-tests/fast/forms/focus.html: Added.
  • layout-tests/fast/forms/legend-access-key-expected.txt: Added.
  • layout-tests/fast/forms/legend-access-key.html: Added.
  • fixed <rdar://problem/3481846> HTML4: accesskey not supported by HTML legend elements also <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3407>
  • added focus methods for <label> and <legend> elements
  • fixed crash when using JavaScript-created events that prevented tests from running
  • khtml/ecma/kjs_html.h: Added focus methods.
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElementFunction::tryCall): Added bindings for focus for <label> and <legend>. (Sorry about the merging, Dave.)
  • khtml/html/html_formimpl.h: Added new functions.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::focus): Added. (DOM::HTMLLegendElementImpl::formElement): Added. (DOM::HTMLLegendElementImpl::focus): Added. (DOM::HTMLLegendElementImpl::accessKeyAction): Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): If there's no QKeyEvent, then get the key name from keyIdentifier() instead of the QKeyEvent's unmodifiedText(). The old code would just do a nil-deref.
8:39 PM Changeset in webkit [9428] by darin
  • 2 edits
    3 adds in trunk

Change by Niels Leenheer (also done by Dave Hyatt on stage at WWDC).
Reviewed by me.

Test cases added:

  • layout-tests/fast/replaced/object-align-hspace-vspace-expected.txt: Added.
  • layout-tests/fast/replaced/object-align-hspace-vspace.html: Added.
  • layout-tests/fast/replaced/resources/webkit-background.png: Added.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::mapToEntry): Add cases for ATTR_ALIGN, ATTR_VSPACE and ATTR_HSPACE. (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
7:57 PM Changeset in webkit [9427] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Finlay Dobbie.
Reviewed by me.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]): Undo change we did a while back to work around the gcc 3.3 compiler error. It no longer seems to happen, and the workaround code was 10.4-specific.
7:28 PM Changeset in webkit [9426] by darin
  • 2 adds in trunk/LayoutTests/fast/replaced

Oops, forgot these files.

7:27 PM Changeset in webkit [9425] by darin
  • 2 edits
    4 adds in trunk

Change by Niels Leenheer (also done by Dave Hyatt on stage at WWDC).
Reviewed by me.

Test cases added:

  • layout-tests/fast/replaced/applet-hspace-expected.txt: Added.
  • layout-tests/fast/replaced/applet-hspace.html: Added.
  • layout-tests/fast/replaced/applet-vspace-expected.txt: Added.
  • layout-tests/fast/replaced/applet-vspace.html: Added.
  • layout-tests/fast/replaced/resources/applet.class: Added.
  • layout-tests/fast/replaced/resources/applet.java: Added.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::mapToEntry): Add cases for ATTR_VSPACE and ATTR_HSPACE. (DOM::HTMLAppletElementImpl::parseMappedAttribute): Ditto.
7:08 PM Changeset in webkit [9424] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Improve handling of patches with CR characters in them.
  • Scripts/cvs-unapply: Ditto.
6:58 PM Changeset in webkit [9423] by darin
  • 2 edits
    2 adds in trunk
  • removed some unused code from one of the KWQ headers
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • added a layout test for a bug that's already fixed
  • layout-tests/fast/forms/element-by-name-expected.txt: Added.
  • layout-tests/fast/forms/element-by-name.html: Added.
6:49 PM Changeset in webkit [9422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Tiny formatting tweak.

Jun 17, 2005:

4:02 PM Changeset in webkit [9421] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test cases added: None, since this test requires manual interaction.

  • fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements do not resize when options are added via javascript
  • khtml/rendering/render_form.cpp: (RenderSelect::layout): remove call setting setNeedsLayout to true. setNeedsLayout is already true at this point, and this addtional call has the negative effect of marking m_normalChildNeedsLayout on the element's parent, which keeps layout from propagating all the way up to the root later on.
2:55 PM Changeset in webkit [9420] by justing
  • 3 edits
    2 adds in trunk

Bug #:
Submitted by:
Reviewed by:

2:51 PM Changeset in webkit [9419]
  • 53 copies in tags/Safari-412~0~1

This commit was manufactured by cvs2svn to create tag
'Safari-412~0~1'.

2:51 PM Changeset in webkit [9418] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/JavaScriptCore

Versioning for GCC 4 - Safari-412.0.1

2:41 PM Changeset in webkit [9417] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebKit

Versioning for GCC 4 - Safari-412.0.1

2:29 PM Changeset in webkit [9416] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebCore

Versioning for GCC 4 - Safari-412.0.1

2:20 PM Changeset in webkit [9415] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebCore

Rolled in changes to compile with gcc 4.0 from TOT.

2005-05-16 Darin Adler <Darin Adler>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
  • khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
  • khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
  • khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
  • khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
  • khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
  • khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
  • khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
  • khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
  • kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

2005-04-28 Darin Adler <Darin Adler>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
  • khtml/css/parser.cpp: Regenerated.
  • khtml/css/parser.h: Regenerated.
  • khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
  • kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
  • kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
  • kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
  • kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • WebCore-combined.exp: Regenerated.
  • WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.
1:00 PM Changeset in webkit [9414] by adele
  • 2 edits
    7 adds in trunk

Reviewed by Maciej.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): set 'script' flag when parsing <script src="foo" /> case. In this case, parseTag calls the scriptHandler function which expects that flag to be set, and sets it back to false at the appropriate time.

Test cases added: These still don't test the cached script cases, but they're good regression
tests for the tokenizer. We'll have to come up with a good way to test the cached cases later.

  • layout-tests/fast/tokenizer/external-script-document-write_2-expected.txt: Added.
  • layout-tests/fast/tokenizer/external-script-document-write_2.html: Added.
  • layout-tests/fast/tokenizer/resources/empty_script.js: Added.
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt: Added.
  • layout-tests/fast/tokenizer/script_extra_close.html: Added.
  • layout-tests/fast/tokenizer/script_quirk-expected.txt: Added.
  • layout-tests/fast/tokenizer/script_quirk.html: Added.
11:50 AM Changeset in webkit [9413] by justing
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:42 AM Changeset in webkit [9412] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Patch contributed by Anders Carlsson<​andersca@mac.com>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

  • khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
  • khtml/html/html_formimpl.h: Ditto.
11:14 AM Changeset in webkit [9411]
  • 1 copy
    1 delete in tags/Safari-2-0-anchor-1P

This commit was manufactured by cvs2svn to create tag
'Safari-2-0-anchor-1P'.

11:14 AM Changeset in webkit [9410] by ggaren
  • 3 edits in trunk/WebCore

Patch contributed by Joos de Valk <​webkit@joostdevalk.nl>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

  • khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
  • khtml/html/html_formimpl.h: Ditto.
10:09 AM Changeset in webkit [9409] by rjw
  • 2 edits in trunk/WebKit

Bug #:
Submitted by:
Reviewed by:

Changes by Mitz Pettel
Reviewed by Richard Williamson.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3545

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
9:41 AM Changeset in webkit [9408] by darin
  • 2 edits
    2 adds in trunk

Reviewed by John.

Test cases added:

  • layout-tests/fast/encoding/invalid-UTF-8-expected.txt: Added.
  • layout-tests/fast/encoding/invalid-UTF-8.html: Added.
  • kwq/KWQTextCodec.mm: (unwanted): Added. Returns true for BOM, replacement, and null characters. (KWQTextDecoder::appendOmittingUnwanted): Renamed from appendOmittingNullsAndBOMs and changed to use the new "unwanted" function, which causes it to omit replacement characters. (KWQTextDecoder::convertUsingTEC): Call append function by its new name.
8:06 AM Changeset in webkit [9407] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed <rdar://problem/4151001> Reloading javascript-spawned window with no URL erases its contents
  • WebView.subproj/WebFrame.m: (-[WebFrame reload]): do nothing if URL is zero-length
12:49 AM Changeset in webkit [9406] by mjs
  • 1 edit
    1 add in trunk/WebKitTools
  • added prepare-ChangeLog script which we use internally to make ChangeLogs, for benefit of all WebKit hackerdom
  • Scripts/prepare-ChangeLog: Added.

Jun 16, 2005:

7:13 PM Changeset in webkit [9405] by justing
  • 9 edits in trunk/WebCore

Added a few debugging methods to highlight Selections, VisiblePositions and Nodes in the DOM tree.

Reviewed by Dave Harrison

Test cases added: None, changes are only to aid debugging

  • khtml/editing/selection.cpp:

(khtml::Selection::showTree):

  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp:

(khtml::VisiblePosition::showTree):

  • khtml/editing/visible_position.h:
  • khtml/xml/dom_nodeimpl.cpp:

(NodeImpl::showNode):
(NodeImpl::showTree):
(NodeImpl::showTreeAndMark):

  • khtml/xml/dom_nodeimpl.h:
5:57 PM Changeset in webkit [9404] by ggaren
  • 5 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4151759> 'delete' fails on variables declared inside 'eval' statements.

Reviewed by cblu.

  • kjs/context.h: (KJS::ContextImp::codeType): Added code type accessor for execution context objects.
  • kjs/internal.cpp: (ContextImp::ContextImp): Reflects change to ContextImp::codeType.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Added separate code path for variable declarations inside 'eval' statements.
  • tests/mozilla/expected.html: Updated expected test results to reflect fix.
2:06 PM Changeset in webkit [9403] by hyatt
  • 2 edits in trunk/WebCore/khtml/xml

Fix build bustage

1:33 PM Changeset in webkit [9402] by hyatt
  • 2 edits in trunk/WebCore/khtml/html

Fix build bustage

12:42 PM Changeset in webkit [9401] by hyatt
  • 2 edits
    4 adds
    1 delete in trunk/WebCore

Add an initial implementation of QualifiedName and HTMLNames. These classes are not used by anyone yet.
Progress being recorded in bugzilla bug 3405.

Reviewed by mjs

Test cases added: (None, does not affect build yet)

  • WebCore.pbproj/project.pbxproj:
  • khtml/xml/dom_qname.h,.cpp
  • khtml/html/htmlnames.h,.cpp
9:45 AM Changeset in webkit [9400] by darin
  • 3 edits in trunk/WebKitTools
  • recent changes to XcodeOptions made it depend on the current directory The intent was to have the WebKitBuild directory be next to WebKitTools, not inside the various build directories. Workaround for now is to call XcodeOptions when the directory is set to the WebKit directory.
  • Scripts/build-dumprendertree: Use a local variable for XcodeOptions and get it at the start of the script.
  • Scripts/build-webkit: Ditto.

Jun 15, 2005:

8:41 PM Changeset in webkit [9399] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Recognize all 1.X versions of Xcode as old too, not just 2.0.

Jun 14, 2005:

3:50 PM Changeset in webkit [9398]
  • 27 copies
    2 deletes in tags/WebCore-315~6

This commit was manufactured by cvs2svn to create tag
'WebCore-315~6'.

3:50 PM Changeset in webkit [9397] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • versioning for WebCore-315.6
3:37 PM Changeset in webkit [9396] by hyatt
  • 288 edits
    2 adds in trunk

The behavior of <pre> is broken so that the newline
is not always properly being eaten after the open of the tag. In addition we were eating the first newline
after all other tags. This patch stops eating newlines after other tags and refines the behavior for pre
to catch all cases.

Reviewed by sullivan

Test cases added: fast/text/whitespace/030.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write):
11:45 AM Changeset in webkit [9395] by darin
  • 1 edit
    1 add in trunk/WebKitTools

Changes by Anders Carlsson.
Reviewed by me.

  • Scripts/gdb-safari: Added.
11:06 AM Changeset in webkit [9394] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • merged this fix from HEAD

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
11:06 AM Changeset in webkit [9393] by sullivan
  • 3 edits in trunk/WebKit

Changes by Devin Lane.
Reviewed by me.

  • fixed <rdar://problem/3766909> PDF viewing could use a zoom control other than the one in the context menu
  • WebView.subproj/WebPDFView.h: now implements protocol _web_WebDocumentTextSizing
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _updateScalingToReflectTextSize]): new method, sets the PDF scaling from the text size multiplier (-[WebPDFView setDataSource:]): call _updateScalingToReflectTextSize (-[WebPDFView _web_textSizeMultiplierChanged]): implementation of protocol _web_WebDocumentTextSizing, calls _updateScalingToReflectTextSize
10:59 AM Changeset in webkit [9392] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated expected.html to reflect fix to <rdar://problem/4147745>.

Reviewed by cblu.

  • tests/mozilla/expected.html:
10:36 AM Changeset in webkit [9391] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _delayedEndPrintMode:]): After discussing this with Dave, I made this method both more debugger-friendly with asserts for the cases we don't think could ever happen, and more paranoid by handling these cases in deployment builds.
9:36 AM Changeset in webkit [9390] by ggaren
  • 3 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4147745> JavaScript discards locally defined "arguments" property

No layout tests added because this change fixes existing tests:
ecma/ExecutionContexts/10.1.6.js
ecma_3/Function/regress-94506.js
js1_4/Functions/function-001.js

Reviewed by cblu.

  • kjs/function.cpp: (KJS::ActivationImp::get): get now checks for an "arguments" property defined in the local variable object before trying to return the built-in arguments array.
  • kjs/function.h: ActivationImp::put no longer overrides ObjectImp::put
9:19 AM Changeset in webkit [9389] by darin
  • 2 edits in trunk/WebKit
  • fixed build for Xcode 2.1
  • WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT to search for the WebKitSystemInterface.h file. We could re-jigger this again later, but for now this is consistent with both the .a file's location and where build-webkit puts the file.

Jun 13, 2005:

7:12 PM Changeset in webkit [9388] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison and Maciej.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _endPrintMode]): new method, extracted from identical code in beginDocument and endDocument. This method must be called once to counterbalance the code called from knowsPageRange that turns on "printing mode". (-[WebHTMLView _delayedEndPrintMode:]): new method, called from "perform after delay". Checks whether the same print operation is still underway and, if so, delays further. Otherwise calls _endPrintMode directly. (-[WebHTMLView knowsPageRange:]): after turning on "printing mode", queue up a delayed call to _delayedEndPrintMode:. If there's an early error in the print mechanism such that beginDocument is never called, this will cleanly end "printing mode" and make the webview usable again. (-[WebHTMLView beginDocument]): cancel any delayed call to _delayedEndPrintMode:. If we get this far along in printing, then we don't need the failsafe call to _delayedEndPrintMode: that was set up in knowsPageRange:. Also, call extracted method. (-[WebHTMLView endDocument]): call extracted method
6:31 PM Changeset in webkit [9387]
  • 55 copies
    2 deletes in tags/WebCore-415~11

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11'.

6:31 PM Changeset in webkit [9386]
  • 77 copies in branches/Safari-Cam-branch

This commit was manufactured by cvs2svn to create branch
'Safari-Cam-branch'.

6:31 PM Changeset in webkit [9385]
  • 77 copies in tags/Safari-Cam-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-Cam-anchor'.

6:31 PM Changeset in webkit [9384] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11

6:28 PM Changeset in webkit [9383]
  • 14 copies
    3 deletes in tags/WebKit-412~6

This commit was manufactured by cvs2svn to create tag 'WebKit-412~6'.

6:28 PM Changeset in webkit [9382] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6

6:27 PM Changeset in webkit [9381] by adele
  • 8 edits in branches/Safari-2-0-branch

WebCore:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).

WebKit:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:29 PM Changeset in webkit [9380] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
5:25 PM Changeset in webkit [9379] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:23 PM Changeset in webkit [9378] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).
5:08 PM Changeset in webkit [9377] by cpeterse
  • 3 edits in trunk/WebKit

Changes by Darin.
Reviewed by me.

  • fixed problems building deployment due to recent init change
  • WebView.subproj/WebArchive.m: (-[WebArchive initWithCoder:]): Put the [super init] call and check for nil outside the exception handler.
  • WebView.subproj/WebResource.m: (-[WebResource initWithCoder:]): Ditto.
8:33 AM Changeset in webkit [9376] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebImageData.m: Got rid of use of tabs instead of spaces throughout the file. (-[WebImageData _checkSolidColor:]): Wrap use of NSGraphicsContext with an autorelease pool. (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): Ditto. (-[WebImageData tileInRect:fromPoint:context:]): Ditto. (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]): Ditto.
12:27 AM Changeset in webkit [9375] by mjs
  • 2 edits in trunk/WebCore

Patch from Andrew Wellington <​proton@wiretapped.net>
Reviewed by me.

No test cases addded since the repro steps require use of tabbed browsing.

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): check for nil

Jun 12, 2005:

8:28 PM Changeset in webkit [9374] by darin
  • 13 edits in trunk/WebKit

Changes by Nick Zitzmann.
Reviewed by me.

  • fixed init methods that don't handle return values from the init methods they call
  • WebView.subproj/WebArchive.m: (-[WebArchive init]): Use value returned by init, check it for nil too. (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Ditto. (-[WebArchive _initWithPropertyList:]): Ditto. (-[WebArchive initWithCoder:]): Ditto.
  • WebView.subproj/WebClipView.m: (-[WebClipView initWithFrame:]): Ditto.
  • WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithName:value:source:children:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFormState initWithForm:values:sourceFrame:]): Ditto. (-[WebFrame initWithName:webFrameView:webView:]): Ditto.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): Ditto.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Ditto. (-[WebTextCompleteController initWithHTMLView:]): Ditto.
  • WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): Ditto.
  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Ditto.
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): Ditto.
  • WebView.subproj/WebResource.m: (-[WebResource init]): Ditto. (-[WebResource initWithCoder:]): Ditto.
  • WebView.subproj/WebView.m: (-[WebViewPrivate init]): Call super init. (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): Use value returned by init, check it for nil too. (-[WebView initWithFrame:]): Ditto.
8:26 PM Changeset in webkit [9373] by darin
  • 7 edits in trunk/WebKitTools

Changes by Stuart Morgan.
Reviewed by me.

  • Scripts/cvs-abandon: Use cwd instead of pwd.
  • Scripts/cvs-apply: Ditto.
  • Scripts/cvs-create-patch: Ditto.
  • Scripts/cvs-unapply: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/webkitdirs.pm: Ditto. Also improve handling when there's no "Configuration" file.
8:12 PM Changeset in webkit [9372] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Handle case of an empty patch better.
  • Scripts/cvs-unapply: Ditto.
7:45 PM Changeset in webkit [9371] by darin
  • 2 edits in trunk/WebKitTools

Changes by Michael Gaiman.
Reviewed by me.

  • Scripts/webkitdirs.pm: Chomp off the result of pwd, and don't die when no Configuration file.
5:55 PM Changeset in webkit [9370] by darin
  • 1 edit
    3 adds in trunk
  • added expected test results for new tests
  • layout-tests/fast/selectors/159-expected.txt: Added.
  • layout-tests/fast/selectors/177a-expected.txt: Added.
  • layout-tests/fast/selectors/177b-expected.txt: Added.
5:40 PM Changeset in webkit [9369]
  • 13 copies
    3 deletes in tags/WebKit-412~5

This commit was manufactured by cvs2svn to create tag 'WebKit-412~5'.

5:40 PM Changeset in webkit [9368] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.5

5:10 PM Changeset in webkit [9367] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/update-webkit: Make this script work when called from any directory.
3:48 PM Changeset in webkit [9366] by darin
  • 7 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.
Includes changes by Stuart Morgan as well as my own.

  • Scripts/build-dumprendertree: Call the new setConfiguration function, and use XcodeOptions instead of symrootXcodeOptions to set the -buildstyle option.
  • Scripts/build-webkit: Ditto. Also remove the old way of supporting Xcode 2.1 and the old --debug option. The new --development option does the same thing.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
  • Scripts/set-webkit-configuration: Added. Sets the default configuration to Development or Deployment.
  • Scripts/webkitdirs.pm: use FindBin to find the WebKit directory; works no matter what the current directory is when invoking a script. Add code to determine the Xcode version so we can do the right thing for 2.0 and 2.1. Change the productDir function to return the appropriate per-configuration product directory. Read the default configuration from a file, overridable by a passed-in command-line option.
2:06 PM Changeset in webkit [9365] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.
1:27 PM Changeset in webkit [9364] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.

Jun 11, 2005:

10:56 PM Changeset in webkit [9363] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/cvs-create-patch: Improve handling of directories with mixed CVS roots by going into each directory to execute the cvs diff commands.
10:41 PM Changeset in webkit [9362] by darin
  • 1 edit
    4 adds in trunk/WebKitTools
  • added first cuts at some cvs scripts

cvs-abandon is for throwing away changes; discards any local changes, reverting to the state in CVS
cvs-create-patch is for making patches; runs cvs diff with all the right options and handles added/deleted files
cvs-apply is for applying patches; runs patch and cvs add and cvs rm
cvs-unapply is for unapplying patches; does the opposite of cvs-apply

An argument against these is "waste of time if we switch to Subversion", but they should be good for a while.

  • Scripts/cvs-abandon: Added.
  • Scripts/cvs-apply: Added.
  • Scripts/cvs-create-patch: Added.
  • Scripts/cvs-unapply: Added.
9:07 PM Changeset in webkit [9361] by mjs
  • 5 edits
    3 adds in trunk

Patch from Nicholas Shanks <​contact@nickshanks.com>, by me.

Merge of svn log -v -r 399829 ​svn://anonsvn.kde.org/home/kde

Test cases added: Added the following from CSS selector test suite,
unfortunately 159 and 117a do not show any difference with and without the
patch since layout tests do not dump selection style (yet).

  • layout-tests/fast/selectors/159.html: Added.
  • layout-tests/fast/selectors/177a.html: Added.
  • layout-tests/fast/selectors/177b.html: Added.
  • khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::): (DOM::CSSSelector::pseudoType):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/parser.y:
2:51 AM Changeset in webkit [9360] by mjs
  • 2 edits
    2 adds in trunk

Patch from Timothy Hatcher <​timothy@colloquy.info>, reviewed by me.

Test cases added:

  • layout-tests/fast/dom/children-nodes-expected.txt: Added.
  • layout-tests/fast/dom/children-nodes.html: Added.
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::traverseNextItem): For "children" collection, use nextSibling() instead of traverseNextNext() to avoid doing deep traversal.
2:41 AM Changeset in webkit [9359] by mjs
  • 1 edit
    1 add in trunk

Added missing expected results from the background image patch.

  • layout-tests/fast/backgrounds/001-expected.txt: Added.

Jun 10, 2005:

10:31 PM Changeset in webkit [9358] by hyatt
  • 5 edits
    2 adds in trunk

Fix for bugzilla bug 3335, add support for the CSS3 indirect adjacent sibling selector. Patch merge
from KHTML tree by Nick Shanks.

Reviewed by hyatt

Test cases added: fast/selectors/046.html

  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector):
  • khtml/css/parser.y:
  • layout-tests/fast/selectors/046-expected.txt: Added.
  • layout-tests/fast/selectors/046.html: Added.
10:01 PM Changeset in webkit [9357] by hyatt
  • 2 edits
    2 adds in trunk

Fix for 3237, background image repeats when it shouldn't. The Radar bug is 4005553. Patch from
Nate Cook.

Reviewed by darin and hyatt

Test cases added: fast/backgrounds/001.html

  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
  • layout-tests/fast/backgrounds/001.html: Added.
6:58 PM Changeset in webkit [9356] by hyatt
  • 3 edits in trunk/WebCore

Merge Allan Jensen's fix for 3236.

Reviewed by hyatt

Test cases added: None, test case already added for the bug.

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent):
5:42 PM Changeset in webkit [9355] by sullivan
  • 2 edits in trunk/WebKit

reviewed by Dave Harrison (first & second drafts) and Darin Adler (third draft)

  • WebKit part of fix for <rdar://problem/4145214> REGRESSION (412+): Can't drag URLs from the location bar
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): Reinstate variation of old code that uses CreatePasteboardFlavorTypeName to set up our new pasteboard types. The newfangled way didn't work.
5:40 PM Changeset in webkit [9354] by sullivan
  • 2 edits in trunk/WebKitLibraries

Updated copies of WebKitSystemInterface.h and libWebKitSystemInterface.a that include the new functions needed to fix 3446192.

11:02 AM Changeset in webkit [9353] by darin
  • 1 edit
    2 adds in trunk

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Refined and reviewed by me.

  • layout-tests/fast/js/exception-linenums-expected.txt: Added.
  • layout-tests/fast/js/exception-linenums.html: Added.
11:02 AM Changeset in webkit [9352] by darin
  • 3 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • further improvements to exception file/line number fix
  • kjs/nodes.h: Added setExceptionDetailsIfNeeded function.
  • kjs/nodes.cpp: Updated macros to call the new setExceptionDetailsIfNeeded function. (Node::setExceptionDetailsIfNeeded): Added.

Jun 9, 2005:

11:47 PM Changeset in webkit [9351] by hyatt
  • 2 edits
    2 adds in trunk

Fix from Carston Guenther for bugzilla bug 3236.

attr(x) should work even if x is not present on the element.

This is Radar bug #3584466

Reviewed by hyatt

Test cases added: fast/css-generated-content/013.html

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • layout-tests/fast/css-generated-content/013-expected.txt: Added.
  • layout-tests/fast/css-generated-content/013.html: Added.
9:27 PM Changeset in webkit [9350] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Tested by Mark Rowe.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
9:23 PM Changeset in webkit [9349] by darin
  • 2 edits in trunk

Tested by Brian Dash.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
4:17 PM Changeset in webkit [9348] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Change type from "folder" to "wrapper.framework" for Foundation.framework. How was it ever wrong?
  • finally, I tested making the default build directory work; it works now
  • Scripts/webkitdirs.pm: Changed structure of the code a little bit, added symrootXcodeOptions function that sets SYMROOT on the command line in case there's no product directory set in Xcode preferences.
  • Scripts/build-webkit: Pass symrootXcodeOptions when invoking Xcode.
  • Scripts/build-dumprendertree: Ditto.
6:03 AM Changeset in webkit [9347] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Get rid of unneeded this->.
6:03 AM Changeset in webkit [9346] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Another try at making the default build directory of ~/WebKitBuild work. Someone should try building without setting the Xcode build product directory now, and let me know if it works.

Jun 8, 2005:

11:14 PM Changeset in webkit [9345] by darin
  • 6 edits in trunk/WebKitTools
  • quick fix to try to get build scripts working again
  • Scripts/build-dumprendertree: Add FindBin.
  • Scripts/build-webkit: Ditto.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
10:43 PM Changeset in webkit [9344] by darin
  • 6 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.

  • some build script enhancements
  • Scripts/build-dumprendertree: Changed to use webkitdirs.
  • Scripts/build-webkit: Changed to use webkitdirs, also only copy files from WebKitLibraries if they are newer.
  • Scripts/run-safari: Reduce number of log messages, change to respect "-d" flag and get Development before Deplyment in that case.
  • Scripts/run-webkit-tests: Changed to use webkitdirs.
  • Scripts/update-webkit: Changed to use webkitdirs.
  • Scripts/webkitdirs.pm: Added.
2:55 AM Changeset in webkit [9343] by mjs
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Oops, i missed the project file changes too.

2:16 AM Changeset in webkit [9342]
  • 7 copies in tags/Safari-1-3-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-3-anchor'.

2:16 AM Changeset in webkit [9341] by mjs
  • 2 adds in trunk/WebCore/khtml/ecma

Add new files that I forgot to check in with the last change.

2:00 AM Changeset in webkit [9340] by mjs
  • 2 edits in trunk/WebKitTools

Code change by Toby Peterson <​toby@opendarwin.org>
Reviewed by me.

  • Scripts/run-safari: Fix to work with Xcode 2.0 again. The script would get confused because build-webkit now makes even 2.0 build directories look like 2.1.
1:39 AM Changeset in webkit [9339] by mjs
  • 3 edits
    4 adds in trunk

Reviewed and committed by Maciej.

<rdar://problem/3533735> implement Mozilla "DOMParser" extension for use with XMLHTTPRequest

Test cases added:

  • layout-tests/fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize-display.html: Added.
  • layout-tests/fast/dom/dom-parse-serialize-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize.html: Added.
  • khtml/ecma/domparser.h:
  • khtml/ecma/domparser.cpp: Add files implementing the DOMParser object.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: Expose DOMParser object.
12:09 AM Changeset in webkit [9338] by mjs
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Include source file and line number when making exception in KJS_CHECKEXCEPTIONVALUE.

Jun 7, 2005:

5:41 PM Changeset in webkit [9337] by hyatt
  • 2 edits in trunk/WebCore

Patch from Brian Campbell. Make sure the min and max values of slider properly update.
Fixes bugilla bug 3323, internal Radar # is 4098892.

Reviewed by hyatt

Test cases added: (Not testable with a layout test)

  • kwq/KWQSlider.mm: (QSlider::setMinValue): (QSlider::setMaxValue):
5:27 PM Changeset in webkit [9336] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Adele Peterson.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added Deployment build style.
  • Scripts/build-dumprendertree: For now, always use Deployment build style. This may fix things so we can run tests with Xcode 2.1.
3:51 PM Changeset in webkit [9335]
  • 53 copies
    2 deletes in tags/WebCore-415~10

This commit was manufactured by cvs2svn to create tag
'WebCore-415~10'.

3:51 PM Changeset in webkit [9334] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.10

3:46 PM Changeset in webkit [9333] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, forgot to use Adele's married name.

3:45 PM Changeset in webkit [9332] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Adele Amchan.

  • Scripts/run-webkit-tests: Pass -L to find command to follow symlinks. This allows symlinks in the layout-tests directory to include additional sets of tests.
3:42 PM Changeset in webkit [9331] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4139800> from TOT to Safari-2-0-branch

2005-06-07 Adele Peterson <​adele@apple.com>

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:12 PM Changeset in webkit [9330] by adele
  • 2 edits in trunk/WebCore

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:02 PM Changeset in webkit [9329] by darin
  • 5 edits in trunk/WebKitTools
  • checkout: Added license.
  • Scripts/build-dumprendertree: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
2:58 PM Changeset in webkit [9328] by darin
  • 3 edits in trunk/WebKitTools

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • Scripts/build-webkit: Changes so you can build with Xcode 2.1. (I also added a license to this file.)
  • Scripts/run-safari: Ditto.
2:48 PM Changeset in webkit [9327] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
11:34 AM Changeset in webkit [9326] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • JavaScriptCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
9:07 AM Changeset in webkit [9325] by darin
  • 2 edits in trunk/WebKit

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • WebKit.pbproj/project.pbxproj: Quote DERIVED_FILE_DIR when it is substituted into FRAMEWORK_SEARCH_PATHS, and SYMROOT when into HEADER_SEARCH_PATHS.
9:05 AM Changeset in webkit [9324] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fixed name in ChangeLog.

9:00 AM Changeset in webkit [9323] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Add quotes to make LIBRARY_SEARCH_PATHS work even when the path has a space in it.
8:55 AM Changeset in webkit [9322] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • kjs/grammar.y: Remove bogus extra line from grammar.y. Toby got this change from KDE KJS.
8:34 AM Changeset in webkit [9321] by hyatt
  • 2 edits in trunk/WebCore

Patch from Mark Rowe to fix a minor memory leak in WebCoreSettings.

Reviewed by hyatt

  • kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]):

Jun 6, 2005:

10:25 PM Changeset in webkit [9320] by darin
  • 2 edits in trunk/JavaScriptCore
  • tests/mozilla/run-mozilla-tests: Wrote a perl version of this so we don't require the "jst" tool to run the tests.
10:21 PM Changeset in webkit [9319] by mjs
  • 2 edits in trunk

purify the ChangeLog's essence

9:07 PM Changeset in webkit [9318] by darin
  • 2 edits in trunk/WebKit
  • Info.plist: Bumped version to 412+. For some reason it was set to 312.1!
8:07 PM Changeset in webkit [9317] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: run ranlib on libWebKitSystemInterface.a
7:54 PM Changeset in webkit [9316] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: Chop newline off of $productDir to avoid problems with logic to copy files ther.
7:26 PM Changeset in webkit [9315] by mjs
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: Install WebKitSystemInterface stuff into build products dir.
6:48 PM Changeset in webkit [9314] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Remove mention of SPI removal work from ChangeLog per request.

5:54 PM Changeset in webkit [9313] by mjs
  • 2 edits in trunk/WebKit
  • fix crashing problem in last change
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
5:51 PM Changeset in webkit [9312] by mjs
  • 2 edits in trunk/WebKitLibraries
  • updated for crashing bugfix
  • libWebKitSystemInterface.a:
5:37 PM Changeset in webkit [9311] by mjs
  • 3 edits in trunk/WebKit
  • removed carbon and text SPI
  • Carbon.subproj/HIWebView.m: (-[MenuItemProxy initWithAction:]): (-[MenuItemProxy action]): (-[MenuItemProxy tag]): (GetWindowRef): (Click): (MouseUp): (MouseMoved): (MouseDragged): (MouseWheelMoved): (WindowHandler): (HIWebViewEventHandler): (UpdateObserver):
  • WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer finalize]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _initializeATSUStyle]): (fillStyleWithAttributes):
5:35 PM Changeset in webkit [9310] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
7:53 AM Changeset in webkit [9309] by mjs
  • 2 edits in trunk/WebKit
  • remove plugin-related SPI calls
  • Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
7:51 AM Changeset in webkit [9308] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
6:47 AM Changeset in webkit [9307] by mjs
  • 2 edits in trunk/WebKit
  • remove graphics SPI use
  • WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): (-[WebGraphicsBridge setDraggingImage:at:]):
6:45 AM Changeset in webkit [9306] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
6:26 AM Changeset in webkit [9305] by mjs
  • 3 edits in trunk/WebKit
  • more SPI removal, for font cache and CFStream
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (getLCDScaleParameters): (+[WebTextRendererFactory createSharedFactory]):
  • WebView.subproj/WebFormDataStream.m: (formCanRead): (formEventCallback): (webSetHTTPBody):
6:24 AM Changeset in webkit [9304] by mjs
  • 3 edits in trunk/WebKitLibraries

Reviewed by NOBODY (OOPS!).

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
5:48 AM Changeset in webkit [9303] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
5:48 AM Changeset in webkit [9302] by mjs
  • 2 edits in trunk/WebKit
  • remove use of AX SPI
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): (-[WebViewFactory objectIsTextMarkerRange:]): (-[WebViewFactory textMarkerWithBytes:length:]): (-[WebViewFactory getBytes:fromTextMarker:length:]): (-[WebViewFactory textMarkerRangeWithStart:end:]): (-[WebViewFactory startOfTextMarkerRange:]): (-[WebViewFactory endOfTextMarkerRange:]): (-[WebViewFactory accessibilityHandleFocusChanged]): (-[WebViewFactory AXUIElementForElement:]): (-[WebViewFactory unregisterUniqueIdForUIElement:]):
5:16 AM Changeset in webkit [9301] by mjs
  • 3 edits in trunk/WebKit
  • removed more SPI
  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _postFlagsChangedEvent:]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView _interceptEditingKeyEvent:]):
5:14 AM Changeset in webkit [9300] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:43 AM Changeset in webkit [9299] by mjs
  • 8 edits in trunk/WebKit
  • more SPI use removal
  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]):
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]):
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
4:42 AM Changeset in webkit [9298] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:16 AM Changeset in webkit [9297] by mjs
  • 2 edits in trunk/WebKit
  • remove unneeded header include
  • WebCoreSupport.subproj/WebImageRenderer.m:
4:12 AM Changeset in webkit [9296] by mjs
  • 8 edits in trunk/WebKit
  • removed even more SPI use
  • Misc.subproj/WebDownload.m:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didReceiveResponse:]): (-[WebMainResourceClient didReceiveData:lengthReceived:]): (-[WebMainResourceClient didFinishLoading]): (-[WebMainResourceClient didFailWithError:]):
4:11 AM Changeset in webkit [9295] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:

Jun 5, 2005:

11:05 PM Changeset in webkit [9294] by darin
  • 4 edits
    1 add in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Tweak, simplify.
  • Scripts/build-dumprendertree: Added.
  • Scripts/build-webkit: Build All in the JavaScriptCore directory.
  • Scripts/run-webkit-tests: Build DumpRenderTree before running.
10:46 PM Changeset in webkit [9293] by hyatt
  • 2 edits
    2 adds in trunk/LayoutTests/fast/css-generated-content

Change layout test #10 to use a smaller bullet image.

10:15 PM Changeset in webkit [9292] by darin
  • 3 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed hang we were seeing in Safari and layout tests
  • Misc.subproj/WebNSUserDefaultsExtras.m: (+[NSUserDefaults _webkit_ensureAndLockPreferredLanguageLock]): Change name to avoid conflict with Foundation function. This was causing the hang. (+[NSUserDefaults _webkit_defaultsDidChange]): Update caller. (+[NSUserDefaults _webkit_preferredLanguageCode]): Ditto.
  • WebCoreSupport.subproj/WebGraphicsBridge.m: Remove some unneeded includes.
8:44 PM Changeset in webkit [9291] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed crash in Acid2 layout test
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Added nil check for CFBundleRef.
8:25 PM Changeset in webkit [9290] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • remove more SPI usage
  • Carbon.subproj/CarbonWindowAdapter.m: Remove a bunch of stuff. (+[CarbonWindowAdapter frameViewClassForStyleMask:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): (-[CarbonWindowAdapter _oldPlaceWindow:]): (-[CarbonWindowAdapter _termWindowIfOwner]): (-[CarbonWindowAdapter _windowMovedToRect:]): (-[CarbonWindowAdapter makeKeyWindow]):
7:39 PM Changeset in webkit [9289] by mjs
  • 2 edits in trunk/WebKit
  • remove another forgotten include
  • Plugins.subproj/WebPluginDatabase.m:
7:27 PM Changeset in webkit [9288] by mjs
  • 2 edits in trunk/WebKit
  • remove include that I forgot in last checkin
  • Misc.subproj/WebNSPasteboardExtras.m:
7:21 PM Changeset in webkit [9287] by mjs
  • 3 edits in trunk/WebKitLibraries
  • added a few more bits of SPI
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
7:21 PM Changeset in webkit [9286] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Don.

  • remove more SPI usage
  • fix <rdar://problem/3446192> CoreTranslation SPI is going away
  • History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releasePageCache:]):
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]):
7:00 PM Changeset in webkit [9285] by mjs
  • 1 delete in trunk/WebKit/WebKitSecurityDummy.c

* empty log message *

5:34 PM Changeset in webkit [9284] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-safari: Fix path to Safari executable. Add check for frameworks.
5:15 PM Changeset in webkit [9283] by mjs
  • 16 edits in trunk/WebKit

Reviewed by Darin.

  • use WebKitSystemInterface wrappers for NSURLFileTypeMappings and NSURLResponse SPI
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]):
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]):
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): (-[WebBridge determineObjectFromMIMEType:URL:]): (-[WebBridge MIMETypeForPath:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _commitIfReady:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView resourceForData:preferredFilename:]):
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]): (+[WebView suggestedFileExtensionForMIMEType:]): (+[WebView _MIMETypeForFile:]):
5:12 PM Changeset in webkit [9282] by mjs
  • 3 edits in trunk/WebKitLibraries
  • added file type and NSURLResponse caching SPI
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:34 PM Changeset in webkit [9281] by darin
  • 1 edit
    7 adds in trunk/WebKitTools
  • add run-webkit-tests script; not working yet but the pieces are there
  • Scripts/run-webkit-tests: Added.
  • DumpRenderTree/DumpRenderTree.m: Added.
  • DumpRenderTree/DumpRenderTree.xcode/.cvsignore: Added.
  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added.
  • DumpRenderTree/DumpRenderTreePrefix.h: Added.
4:14 PM Changeset in webkit [9280] by darin
  • 7 adds in trunk/WebKitTools
  • created module, first cut at Web Kit Open Source Project scripts
  • ChangeLog: Added.
  • Scripts/build-webkit: Added.
  • Scripts/run-safari: Added.
  • Scripts/update-webkit: Added.
  • checkout: Added.
2:17 PM Changeset in webkit [9279] by mjs
  • 4 adds in trunk/WebKitLibraries
  • initial checkin of WebKitSystemInterface binary
  • WebKitSystemInterface.h: Added.
  • libWebKitSystemInterface.a: Added.
1:57 PM Changeset in webkit [9278] by darin
  • 7 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed build that I broke with the license change (some includes of WebException were still around)
  • WebKit.pbproj/project.pbxproj: Removed references to WebException.h/m.
  • WebView.subproj/WebDataSource.m: Removed include of WebException.h.
  • WebView.subproj/WebHTMLView.m: Ditto.
  • WebView.subproj/WebView.m: Ditto.
  • fixed build under gcc 4.0 (some code moved here from Foundation had warnings)
  • Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use char instead of UInt8. (-[NSData _webkit_guessedMIMEType]): Use char instead of UInt8, and take out now- unneeded type casts.
1:42 PM Changeset in webkit [9277] by mjs
  • 3 edits
    2 deletes in trunk/WebKit

Reviewed by Don.

  • remove security code and use the stuff from WebKitSystemInterface instead
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
  • WebCoreSupport.subproj/WebNewKeyGeneration.c: Removed.
  • WebCoreSupport.subproj/WebNewKeyGeneration.h: Removed.
  • WebKit.pbproj/project.pbxproj:
10:54 AM Changeset in webkit [9276] by darin
  • 268 edits
    1 add
    4 deletes in trunk/WebKit
  • added appropriate license headers to most files and updated copyright to reflect publication dates
  • LICENSE: Added.
  • <lots of files>: Added license header.
  • WebKit.pbproj/project.pbxproj: Removed references to NP_objc.h.
  • API-Issues.rtf: Removed.
  • Misc.subproj/WebException.h: Removed.
  • Misc.subproj/WebException.m: Removed.
  • Plugins.subproj/NP_objc.h: Removed.
2:22 AM Changeset in webkit [9275] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Hyatt.

  • link against libWebKitSystemInterface and use the first function in it.
  • Misc.subproj/WebNSUserDefaultsExtras.m: (-[NSString _webkit_HTTPStyleLanguageCode]): use WKCopyCFLocalizationPreferredName
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): ditto
  • WebKit.pbproj/project.pbxproj: link in libWebKitSystemInterface.a and find headers.
12:06 AM Changeset in webkit [9274] by darin
  • 9 edits
    19 adds in trunk

WebCore:

Reviewed by Don.

  • got rid of the rest of the dependencies on Apple Internal headers
  • kwq/WebCoreBridge.mm: Remove include of unused SPI header.
  • kwq/KWQAccObjectCache.h: Remove include of SPI header. Change use of AXTextMarkerRef to use WebCoreTextMarker instead. Also ifdef less.
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::textMarkerForVisiblePosition): Change types, call new WebCoreViewFactory methods. (KWQAccObjectCache::visiblePositionForTextMarker): Ditto. (KWQAccObjectCache::handleFocusedUIElementChanged): Ditto.
  • kwq/WebCoreViewFactory.h: Add new methods we can use instead of Accessibility SPI.
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Call new WebCoreViewFactory method instead of SPI. (-[KWQAccObject accessibilityAttributeNames]): Use strings instead of constants only in SPI header. (-[KWQAccObject textMarkerRangeFromMarkers:andEndMarker:]): Change parameter types from SPI type to a new type defined by WebCoreViewFactory, use WebCoreViewFactory method. (-[KWQAccObject textMarkerForVisiblePosition:]): Ditto. (-[KWQAccObject visiblePositionForTextMarker:]): Ditto. (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): Ditto. (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): Ditto. (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): Just change type. (-[KWQAccObject textMarkerRange]): Ditto. (-[KWQAccObject accessibilityAttributeValue:]): String instead of constant. (-[KWQAccObject accessibilityParameterizedAttributeNames]): Ditto. (-[KWQAccObject doAXUIElementForTextMarker:]): Just change type. (-[KWQAccObject doAXLineForTextMarker:]): Ditto. (-[KWQAccObject doAXStringForTextMarkerRange:]): Ditto. (-[KWQAccObject doAXBoundsForTextMarkerRange:]): Ditto. (AXAttributeStringSetElement): Call new method. (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]): Just change type. (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]): Ditto. (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLengthForTextMarkerRange:]): Ditto. (-[KWQAccObject accessibilityAttributeValue:forParameter:]): Change types, use new methods, use strings instead of constants. (-[KWQAccObject accessibilityIsAttributeSettable:]): String instead of constant. (-[KWQAccObject doSetAXSelectedTextMarkerRange:]): New type. (-[KWQAccObject accessibilitySetValue:forAttribute:]): New types, methods.

WebKit:

Reviewed by Don.

  • did some work to move SPI use from WebCore here (to be moved from here into WebKitSystemInterface)
  • fixed so we can compile ICU includes without Apple Internal headers installed
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): Added. (-[WebViewFactory objectIsTextMarkerRange:]): Added. (-[WebViewFactory textMarkerWithBytes:length:]): Added. (-[WebViewFactory getBytes:fromTextMarker:length:]): Added. (-[WebViewFactory textMarkerRangeWithStart:end:]): Added. (-[WebViewFactory startOfTextMarkerRange:]): Added. (-[WebViewFactory endOfTextMarkerRange:]): Added. (-[WebViewFactory accessibilityHandleFocusChanged]): Added. (-[WebViewFactory AXUIElementForElement:]): Added. (-[WebViewFactory unregisterUniqueIdForUIElement:]): Added.
  • WebKit.pbproj/project.pbxproj: Added icu to the header search files. Removed bogus DSTROOT thing from the framework paths (I meant to remove that a while back).
  • icu/README: Added.
  • icu/unicode/parseerr.h: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/uidna.h: Added.
  • icu/unicode/uiter.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/unorm.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/uscript.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.

Jun 4, 2005:

5:44 PM Changeset in webkit [9273] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix silly ChangeLog typo.

5:42 PM Changeset in webkit [9272] by darin
  • 2 edits
    22 adds in trunk/WebCore

Reviewed by Maciej.

  • first fix on the road to can compile without Apple Internal headers installed
  • WebCore.pbproj/project.pbxproj: Added icu directory to header search path.
  • icu/README: Added.
  • icu/unicode/parseerr.h: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/putil.h: Added.
  • icu/unicode/ubrk.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/uenum.h: Added.
  • icu/unicode/uidna.h: Added.
  • icu/unicode/uiter.h: Added.
  • icu/unicode/uloc.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/ustring.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.
5:41 PM Changeset in webkit [9271] by darin
  • 2 edits
    14 adds in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed so we can compile without Apple Internal headers installed
  • JavaScriptCore.pbproj/project.pbxproj: Added icu directory to header search path.
  • icu/README: Added.
  • icu/unicode/platform.h: Added.
  • icu/unicode/uchar.h: Added.
  • icu/unicode/uconfig.h: Added.
  • icu/unicode/umachine.h: Added.
  • icu/unicode/urename.h: Added.
  • icu/unicode/utf.h: Added.
  • icu/unicode/utf16.h: Added.
  • icu/unicode/utf8.h: Added.
  • icu/unicode/utf_old.h: Added.
  • icu/unicode/utypes.h: Added.
  • icu/unicode/uversion.h: Added.
3:46 PM Changeset in webkit [9270] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Vicki.

  • replace more use of CGCompositeOperation that I missed.
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage _PDFDrawFromRect:toRect:operation:alpha:flipped:]):

Jun 3, 2005:

4:25 PM Changeset in webkit [9269] by mjs
  • 5 edits in trunk/WebKit

Reviewed by NOBODY (OOPS!).

  • replace use of CGCompositeOperation SPI with NSCompositingOperation API
  • WebCoreSupport.subproj/WebImageData.h:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory CGCompositeOperationInContext:]): (-[WebImageRendererFactory setCGCompositeOperation:inContext:]): (-[WebImageRendererFactory setCGCompositeOperationFromString:inContext:]):
2:34 PM Changeset in webkit [9268]
  • 53 copies
    2 deletes in tags/WebCore-415~9

This commit was manufactured by cvs2svn to create tag
'WebCore-415~9'.

2:34 PM Changeset in webkit [9267] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiCambridge - WebCore-415.9

2:11 PM Changeset in webkit [9266] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4109667> from TOT for SUTiCambridge.
Our fix for the Cingular bug (<rdar://problem/4121747>)relies on this.

2005-05-05 David Hyatt <​hyatt@apple.com>

Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.

The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.

Reviewed by John Sullivan

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
  • khtml/xml/dom_docimpl.h:

Jun 2, 2005:

10:56 PM Changeset in webkit [9265] by mjs
  • 11 edits in trunk/WebKit

Reviewed by Kevin.

  • removed dependencies on NSError SPI
  • Misc.subproj/WebKitErrors.m: (-[NSError _webkit_initWithDomain:code:URL:]): (+[NSError _webkit_errorWithDomain:code:URL:]): (+[NSError _webKitErrorWithDomain:code:URL:]): (+[NSError _webKitErrorWithCode:failingURL:]): (+[NSError _webkit_addErrorsWithCodesAndDescriptions:inDomain:]): (registerErrors):
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didFailWithError:]):
9:46 PM Changeset in webkit [9264] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Vicki.

  • remove use of _cfBundle SPI
  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
9:16 PM Changeset in webkit [9263] by mjs
  • 17 edits
    4 adds in trunk/WebKit

Reviewed by Adele.

  • remove use of NSURLRequest and NSUserDefaults SPI
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
  • Misc.subproj/WebNSURLRequestExtras.h: Added.
  • Misc.subproj/WebNSURLRequestExtras.m: Added. (-[NSURLRequest _web_HTTPReferrer]): (-[NSURLRequest _web_HTTPContentType]): (-[NSMutableURLRequest _web_setHTTPContentType:]): (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
  • Misc.subproj/WebNSUserDefaultsExtras.h: Added.
  • Misc.subproj/WebNSUserDefaultsExtras.m: Added. (-[NSString _webkit_HTTPStyleLanguageCode]): (makeLock): (+[NSUserDefaults _ensureAndLockPreferredLanguageLock]): (+[NSUserDefaults _webkit_defaultsDidChange]): (addDefaultsChangeObserver): (+[NSUserDefaults _webkit_addDefaultsChangeObserver]): (+[NSUserDefaults _webkit_preferredLanguageCode]):
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge incomingReferrer]): (-[WebBridge createModalDialogWithURL:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebView.m: (-[WebView _cachedResponseForURL:]): (-[WebView userAgentForURL:]):
8:36 PM Changeset in webkit [9262] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Don.

  • move private gunk from header to implementation file.
  • WebCoreSupport.subproj/WebNewKeyGeneration.c:
  • WebCoreSupport.subproj/WebNewKeyGeneration.h:
8:12 PM Changeset in webkit [9261] by mjs
  • 10 edits
    4 adds in trunk/WebKit

Reviewed by Kevin.

  • remove dependency on NSFileManager and NSCalendarDate private extras from WebFou
  • History.subproj/WebHistory.m: (-[WebHistoryPrivate findIndex:forDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]):
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_fixedCarbonPOSIXPath]):
  • Misc.subproj/WebNSCalendarDateExtras.h: Added.
  • Misc.subproj/WebNSCalendarDateExtras.m: Added. (-[NSCalendarDate _webkit_compareDay:]):
  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.h: Added.
  • Misc.subproj/WebNSFileManagerExtras.m: Added. (-[NSFileManager _webkit_fileExistsAtPath:isDirectory:traverseLink:]): (-[NSFileManager _webkit_createIntermediateDirectoriesForPath:attributes:]): (-[NSFileManager _webkit_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _webkit_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]): (-[NSFileManager _webkit_removeFileOnlyAtPath:]): (-[NSFileManager _webkit_backgroundRemoveFileAtPath:]): (-[NSFileManager _webkit_backgroundRemoveLeftoverFiles:]): (-[NSFileManager _webkit_carbonPathForPath:]): (-[NSFileManager _webkit_startupVolumeName]): (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
4:54 PM Changeset in webkit [9260] by mjs
  • 21 edits
    2 adds in trunk/WebKit

Reviewed by Adele.

  • remove dependencies on NSDictionary and NSURL extras
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]):
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
  • Misc.subproj/WebNSDictionaryExtras.h: Added.
  • Misc.subproj/WebNSDictionaryExtras.m: Added. (-[NSDictionary _webkit_numberForKey:]): (-[NSDictionary _webkit_intForKey:]): (-[NSDictionary _webkit_stringForKey:]): (-[NSDictionary _webkit_objectForMIMEType:]): (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[NSMutableDictionary _webkit_setInt:forKey:]): (-[NSMutableDictionary _webkit_setBool:forKey:]):
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFileURL]): (-[NSURL _web_hostString]): (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _setBoolValue:forKey:]):
  • WebView.subproj/WebResource.m: (-[WebResource _initWithPropertyList:]): (-[WebResource _fileWrapperRepresentation]):
  • WebView.subproj/WebView.m:
3:09 PM Changeset in webkit [9259] by mjs
  • 16 edits in trunk/WebKit

Reviewed by Vicki.

  • remove dependencies on NSString and NSData extras from Foundation
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_isCaseInsensitiveEqualToString:]): (-[NSString _webkit_hasCaseInsensitivePrefix:]): (-[NSString _webkit_stringByTrimmingWhitespace]): (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): (-[NSString _webkit_fixedCarbonPOSIXPath]):
  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): (-[NSData _web_isCaseInsensitiveEqualToCString:]): (_findEOL): (-[NSData _web_parseRFC822HeaderFields]): (-[NSData _webkit_guessedMIMETypeForXML]): (-[NSData _webkit_guessedMIMEType]):
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToURLString): (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (-[NSURL _webkit_shouldLoadAsEmptyDocument]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]): (-[NSString _webkit_isFTPDirectoryURL]): (-[NSString _web_encodeHostName]): (-[NSString _webkit_rangeOfURLScheme]): (-[NSString _webkit_looksLikeAbsoluteURL]): (-[NSString _webkit_URLFragment]):
  • Misc.subproj/WebNSViewExtras.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
  • Plugins.subproj/WebPluginDatabase.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]):
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]):
  • WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
2:19 PM Changeset in webkit [9258] by mjs
  • 33 edits in trunk/WebKit

Reviewed by John.

  • first stage of cleaning up SPI usage in WebKit
  • Carbon.subproj/CarbonUtils.m:
  • DOM.subproj/WebDOMOperations.m: (-[DOMHTMLLinkElement _subresourceURLs]): (-[DOMHTMLParamElement _subresourceURLs]):
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
  • Misc.subproj/WebDatabase.m: (-[WebDatabase setObject:forKey:]): (-[WebDatabase removeObjectForKey:]): (-[WebDatabase removeAllObjects]): (-[WebDatabase objectForKey:]): (-[WebDatabase open]): (-[WebDatabase close]): (-[WebDatabase sync]): (-[WebDatabase count]): (-[WebDatabase setSizeLimit:]):
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase _iconForFileURL:withSize:]):
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): (-[NSString _webkit_isCaseInsensitiveEqualToString:]):
  • Misc.subproj/WebNSEventExtras.h:
  • Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isTabKeyEvent]):
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]):
  • Panels.subproj/WebPanelAuthenticationHandler.m: (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]): (-[WebPanelAuthenticationHandler startAuthentication:window:]):
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): (-[WebBridge valueForKey:keys:values:]):
  • WebCoreSupport.subproj/WebGlyphBuffer.m:
  • WebCoreSupport.subproj/WebImageDecodeItem.h:
  • WebCoreSupport.subproj/WebImageDecodeItem.m:
  • WebCoreSupport.subproj/WebImageDecoder.h:
  • WebCoreSupport.subproj/WebImageDecoder.m:
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebKitPrefix.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]):
  • WebView.subproj/WebDataProtocol.m: (+[WebDataProtocol _webIsDataProtocolURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame reload]):
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation _isDisplayingWebArchive]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient didReceiveResponse:]):
  • WebView.subproj/WebPDFView.m:
  • WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
12:26 PM Changeset in webkit [9257]
  • 11 copies
    3 deletes in tags/WebKit-312~2

This commit was manufactured by cvs2svn to create tag 'WebKit-312~2'.

12:26 PM Changeset in webkit [9256] by adele
  • 2 edits in branches/Safari-1-3-branch/WebKit

change by Darin, reviewed by me.

  • WebCoreSupport.subproj/WebBridge.m:

(-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer]
(-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto

9:35 AM Changeset in webkit [9255]
  • 27 copies
    2 deletes in tags/WebCore-315~5

This commit was manufactured by cvs2svn to create tag
'WebCore-315~5'.

9:35 AM Changeset in webkit [9254] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.5 (skipped .4)

9:33 AM Changeset in webkit [9253] by adele
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.2

8:49 AM Changeset in webkit [9252] by adele
  • 13 edits in branches/Safari-1-3-branch/WebCore

Merge for WebCore part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch.

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.

  • WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
  • khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
  • khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
  • khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
  • kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
  • kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
  • kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
  • kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.
8:44 AM Changeset in webkit [9251] by adele
  • 9 edits in branches/Safari-1-3-branch/WebKit

Merged WebKit part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
  • WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.

Jun 1, 2005:

4:49 PM Changeset in webkit [9250] by darin
  • 21 edits in trunk

WebCore:

Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.

  • WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
  • khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
  • khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
  • khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
  • kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
  • kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
  • kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
  • kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.

WebKit:

Reviewed by John Sullivan.

  • WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
  • WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.

WebBrowser:

Reviewed by John.

  • WebBrowser part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • AppController.m: (-[AppController validateUserInterfaceItem:]): Disable the find panel when there's a modal panel up.
  • BrowserApplication.m: (-[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:]): Force the event loop to use the default run loop mode instead of the modal panel mode for modal BrowserWindows. This is required to work around the WebFoundation issue where it will only give us data in the default run loop mode.
  • BrowserDocument.m: (-[BrowserDocument canAddBookmark]): Return NO when a modal window is up. (-[BrowserDocument canViewSource]): Ditto. (-[BrowserDocument canMailPage]): Ditto. (-[BrowserDocument canMailPageAddress]): Ditto. (-[BrowserDocument canOpenInDashboard]): Ditto. (-[BrowserDocument canSave]): Ditto. (-[BrowserDocument validateUserInterfaceItem:]): Disable save commands when modal window is up. Also implement validation for all three of the save commands that we implement.
  • BrowserDocumentController.m: (-[BrowserDocumentController validateUserInterfaceItem:]): Disable newTab: when modal window is up.
  • BrowserWebView.m: (-[BrowserWebView webView:createWebViewModalDialogWithRequest:]): Added. Creates a window that has no toolbar, which is an efficient way to disable all the toolbar-related commands for that window, even ones built into AppKit which otherwise would be difficult to disable. (-[BrowserWebView webViewRunModal:]): Added. Currently just calls -[NSApplication runModalForWindow:] but could do more in the future. More importantly, having this implemented is how the Web Kit can tell that this application supports modal web dialogs. (-[BrowserWebView validateUserInterfaceItem:]): Disable setPageForSnapBackToCurrentPage: for modal windows.
  • BrowserWindow.m: (-[BrowserWindow close]): Abort the modal session if the window being closed is the modal window. This is the only way we return from webViewRunModal:.
  • BrowserWindowController.m: (-[BrowserWindowController canShowInputFields]): Return no when this window is modal. (-[BrowserWindowController validateUserInterfaceItem:]): Disable newTab: and newBookmarkFolder: when modal window is up. (-[BrowserWindowController validateMenuItem:]): Disable Show/Hide of address bar, bookmarks bar, bookmarks collection, and toggleFullScreen: when modal window is up. (-[BrowserWindowController showWindow:]): Change code so that a new window always comes up behind a modal window. Also rearranged things so that setWindowFocusDisabled:YES will be called in any case where the window does not start out as key.
4:03 PM Changeset in webkit [9249]
  • 52 copies
    2 deletes in tags/WebCore-415~8

This commit was manufactured by cvs2svn to create tag
'WebCore-415~8'.

4:03 PM Changeset in webkit [9248] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiCambridge - WebCore-415.8

4:01 PM Changeset in webkit [9247]
  • 12 copies
    3 deletes in tags/WebKit-412~3

This commit was manufactured by cvs2svn to create tag 'WebKit-412~3'.

4:01 PM Changeset in webkit [9246] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for SUTiCambridge - WebKit-412.3

3:47 PM Changeset in webkit [9245] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix for 4097289 from TOT for SUTiCambridge.

2005-05-24 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4097289> -[WebView elementAtPoint:] failing when WebView is nested and offset

Code to determine the correct frame under the window point was
converting the point incorrectly.

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView _frameViewAtWindowPoint:]):
3:34 PM Changeset in webkit [9244] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Re-adding fix for <rdar://problem/4067761>, including fix for <rdar://problem/4135705>

2005-06-01 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()

Reviewed by Darin.

Synchronous loads don't get added to our requestsByDocument dictionary, so we should try to remove the request in this case.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::removeFromRequestsByDocument): added checks to make sure request exists before trying to remove it.
3:23 PM Changeset in webkit [9243] by adele
  • 2 edits in trunk/WebCore

fix for <rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()

Reviewed by Darin.

Synchronous loads don't get added to our requestsByDocument dictionary, so we should try to remove the request in this case.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::removeFromRequestsByDocument): added checks to make sure request exists before trying to remove it.
10:00 AM Changeset in webkit [9242]
  • 52 copies
    2 deletes in tags/WebCore-415~7

This commit was manufactured by cvs2svn to create tag
'WebCore-415~7'.

10:00 AM Changeset in webkit [9241] by cpetersen
  • 4 edits in branches/Safari-2-0-branch/WebCore

Backing out fix for <rdar://problem/4067761> because it caused
<rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()

May 31, 2005:

4:48 PM Changeset in webkit [9240] by cpetersen
  • 3 edits in branches/Safari-2-0-branch/WebCore

Change by Adele, Reviewed by Maciej.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::mark): added nil check.
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark): added nil check.
3:45 PM Changeset in webkit [9239] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

Change by Adele, Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (DOMNode::~DOMNode): Added nil check. On the branch, its possible to create a node with no impl.
12:48 PM Changeset in webkit [9238] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiCambridge - WebCore-415.7

12:43 PM Changeset in webkit [9237]
  • 10 copies
    3 deletes in tags/JavaScriptCore-412~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~3'.

12:43 PM Changeset in webkit [9236] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Version for SUTiCambridge - JavaScriptCore-412.3

12:37 PM Changeset in webkit [9235] by cpetersen
  • 7 edits in branches/Safari-2-0-branch/WebCore

Merged fix for 4125222 from TOT for SUTiCambridge

2005-05-30 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • fixed <rdar://problem/4125222> Dashboard heap size grows over time (leak caused by JavaScript DOM node wrappers?)
  • changed per-document DOMObject caching to work with DOMNodes, since that is all it was used for anyway.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObjectForDocument): New function - allows nodes that get removed from the document to go away from the cache if not referenced. (KJS::ScriptInterpreter::mark): Don't mark nodes that aren't in the document, they can stay in the cache but only if they have another source of life. (KJS::ScriptInterpreter::domNodesPerDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::getDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::putDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::updateDOMNodeDocument): Renamed and changed parameter types.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): call forgetDOMObjectForDocument. (KJS::DOMNode::mark): If the node is not in the document, make sure to mark all wrappers in its detached piece of the tree. (KJS::getDOMNode): Updated for renames
  • khtml/ecma/kjs_dom.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Updated for renames.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Updated for renames.
10:10 AM Changeset in webkit [9234] by cpetersen
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4067761> from TOT to SUTiCambridge.

2005-05-27 Adele Peterson <​adele@apple.com>

Change by Darin, reviewed by me.

fix for <rdar://problem/4067761> 8A425: reload stock widget over and over and crash in XMLHttpRequest::changeState

  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): now cancels XMLHttpRequests
  • khtml/ecma/xmlhttprequest.h: Added cancelRequests, addToRequestsByDocument, and RemoveFromRequestsByDocument methods. Added requestsByDocument dictionary.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): calls addToRequestsByDocument (KJS::XMLHttpRequest::abort): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::slotFinished): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::requestsByDocument): creates dictionary to manage requests. (KJS::XMLHttpRequest::addToRequestsByDocument): adds this request to dict. (KJS::XMLHttpRequest::removeFromRequestsByDocument): removes this request from dict. (KJS::XMLHttpRequest::cancelRequests): goes and cancels requests in the doc
9:57 AM Changeset in webkit [9233] by cpetersen
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4121747> from TOT for SUTiCambridge.

2005-05-27 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)

  • khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
  • khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.

May 30, 2005:

10:48 PM Changeset in webkit [9232] by darin
  • 5 edits
    4 adds in trunk

Reviewed by John (fix for Radar bug) and Vicki (all the rest).

  • fixed <rdar://problem/4105097> REGRESSION (138-139): Hitting Enter on a checkbox toggles check mark instead of submitting form
  • fixed other problems discovered while trying to make a layout test to test this work:
    • added newer DOM 3 event type constants
    • fixed prototype setup bug preventing event initialization functions from being called
    • fixed bug where any function taking an event parameter would crash with a nil-deref
    • fixed incorrect ref/deref bug in MutationEventImpl that would cause a crash crash

Test cases added:

  • layout-tests/fast/forms/check-box-enter-key-expected.txt: Added.
  • layout-tests/fast/forms/check-box-enter-key.html: Added.
  • layout-tests/fast/events/event-creation-expected.txt: Added.
  • layout-tests/fast/events/event-creation.html: Added.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): Separate the checks for the space bar and the Enter key and make Enter submit the form on a check box or radio button.
  • khtml/ecma/kjs_events.cpp: (KJS::toEvent): Fixed bug where this was checking for DOMNode rather than DOMEvent, so always returning 0. Without this, both test cases above will crash. (KJS::DOMUIEvent::DOMUIEvent): Set prototype; without this, the event-creation test case will fail. (KJS::DOMMouseEvent::DOMMouseEvent): Set prototype; without this, the event-creation test case will fail. (KJS::DOMKeyboardEvent::DOMKeyboardEvent): Set prototype; without this, both test cases above will fail. (KJS::DOMMutationEvent::DOMMutationEvent): Set prototype; without this, both test cases above will fail.
  • khtml/xml/dom2_eventsimpl.cpp: (MutationEventImpl::MutationEventImpl): Fix typo where the wrong object was ref'd. (MutationEventImpl::initMutationEvent): Ditto. This was causing the layout tests to crash with the new tests above.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Added new event types to match the current DOM Level 3 specification. The test above tests both the new event types and the old ones.
8:08 PM Changeset in webkit [9231] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.
No test case added because our layout test system doesn't allow us to do inline input.

  • fixed <rdar://problem/4094066> REGRESSION (1.2.5-1.3): unconfirmed inline input is ignored in <textarea>, lost when form is submitted
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Call setWantsNotificationForMarkedText:YES.
6:20 PM Changeset in webkit [9230] by mjs
  • 7 edits
    6 adds in trunk

Reviewed by Darin.

  • fixed <rdar://problem/4125222> Dashboard heap size grows over time (leak caused by JavaScript DOM node wrappers?)
  • changed per-document DOMObject caching to work with DOMNodes, since that is all it was used for anyway.

Test cases added: (these tests actually ensure that DOM wrappers
are sufficiently protected from GC to match other browsers, they
do not verify that the leak is fixed since there's no way to test
that with layout tests).

  • layout-tests/fast/dom/gc-1-expected.txt: Added.
  • layout-tests/fast/dom/gc-1.html: Added.
  • layout-tests/fast/dom/gc-2-expected.txt: Added.
  • layout-tests/fast/dom/gc-2.html: Added.
  • layout-tests/fast/dom/gc-3-expected.txt: Added.
  • layout-tests/fast/dom/gc-3.html: Added.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObjectForDocument): New function - allows nodes that get removed from the document to go away from the cache if not referenced. (KJS::ScriptInterpreter::mark): Don't mark nodes that aren't in the document, they can stay in the cache but only if they have another source of life. (KJS::ScriptInterpreter::domNodesPerDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::getDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::putDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::updateDOMNodeDocument): Renamed and changed parameter types.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): call forgetDOMObjectForDocument. (KJS::DOMNode::mark): If the node is not in the document, make sure to mark all wrappers in its detached piece of the tree. (KJS::getDOMNode): Updated for renames
  • khtml/ecma/kjs_dom.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Updated for renames.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Updated for renames.
5:15 PM Changeset in webkit [9229] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.
Could not figure out how to make an <object> fallback, so for now, no layout test.

  • fixed <rdar://problem/4134124> REGRESSION (tip of tree): crash in QWidget::getView handling onunload event (yahoo.com)
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::getObjectInstance): Check type of RenderObject to be sure it is a RenderWidget before calling widget() on it.

May 27, 2005:

5:42 PM Changeset in webkit [9228] by adele
  • 4 edits in trunk/WebCore

Change by Darin, reviewed by me.

fix for <rdar://problem/4067761> 8A425: reload stock widget over and over and crash in XMLHttpRequest::changeState

  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): now cancels XMLHttpRequests
  • khtml/ecma/xmlhttprequest.h: Added cancelRequests, addToRequestsByDocument, and RemoveFromRequestsByDocument methods. Added requestsByDocument dictionary.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): calls addToRequestsByDocument (KJS::XMLHttpRequest::abort): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::slotFinished): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::requestsByDocument): creates dictionary to manage requests. (KJS::XMLHttpRequest::addToRequestsByDocument): adds this request to dict. (KJS::XMLHttpRequest::removeFromRequestsByDocument): removes this request from dict. (KJS::XMLHttpRequest::cancelRequests): goes and cancels requests in the doc
5:26 PM Changeset in webkit [9227] by adele
  • 2 edits in trunk/WebCore

Reviewed by me, done by Darin.

  • Darin fixed a regression I found from Darin's recent DOM change that broke GMail
  • khtml/ecma/kjs_window.cpp: (KJS::Window::get): Added nil check for document. (KJS::Window::hasProperty): Ditto.

Test cases added: None (Darin should write one).

3:55 PM Changeset in webkit [9226] by adele
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)

  • khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
  • khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.

Test cases added:

  • layout-tests/fast/loader/loadInProgress.html: Added
  • layout-tests/fast/loader/loadInProgress-expected.html: Added
3:48 PM Changeset in webkit [9225] by darin
  • 2 edits
    3 adds in trunk

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

Test cases added:

  • layout-tests/fast/events/xsl-onload-expected.txt: Added.
  • layout-tests/fast/events/xsl-onload.xhtml: Added.
  • layout-tests/fast/events/xsl-onload.xsl: Added.
2:39 PM Changeset in webkit [9224] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin

  • WebCore-tests.exp: took out symbol ZNK5QChar7isPunctEv; it was obsolete and causing build trouble
1:54 PM Changeset in webkit [9223] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • remove HAVE_ICU_LIBRARY ifdefs
  • khtml/rendering/render_text.cpp: Just use ICU all the time; no ifdef.
  • kwq/KWQKURL.mm: Ditto.
Note: See TracTimeline for information about the timeline view.