Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 28, 2005:

6:11 PM Changeset in webkit [11327] by eseidel

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: none
Submitted by: eseidel
Reviewed by: none

• ChangeLog: added bug numbers for last two commits.

6:03 PM Changeset in webkit [11326] by eseidel

• 9 edits in trunk/WebCore

Bug #: 5359
Submitted by: Julien Palmas <​julien.palmas@gmail.com>
Reviewed by: eseidel

Fixes 2 marker test cases.

This patch makes WebCore+SVG's marker support 90% complete
This fixes marker drawing as well as auto-orientation & scaling.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5359

• kcanvas/KCanvasResources.cpp: (KCanvasMarker::setRef): combined setRefX and setRefY (KCanvasMarker::setScale): combined setScaleX and setScaleY (KCanvasMarker::draw): updated post-merger
• kcanvas/KCanvasResources.h:
• kcanvas/device/quartz/KCanvasItemQuartz.h:
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (DrawMarkersData::DrawMarkersData): new struct (drawMarkerWithData): added, draws one marker (updateMarkerDataForElement): added, helper function during draw (DrawStartAndMidMarkers): added, CGPathApply helper function (KCanvasItemQuartz::drawMarkersIfNeeded): updated (KCanvasItemQuartz::paint): updated.
• kcanvas/device/quartz/QuartzSupport.h: (CGPointSubtractPoints): added
• ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateStroke): updated to use static method (KCanvasRenderingStyle::cssPrimitiveToLength): now static
• ksvg2/misc/KCanvasRenderingStyle.h:
• ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::parseMappedAttribute): updated (SVGMarkerElementImpl::canvasResource): fixed

5:43 PM Changeset in webkit [11325] by adele

• 2 edits in trunk/WebCore

Reviewed by Justin.

• <rdar://problem/4356593> Regression: Crash in scrollRectToVisible

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.

5:35 PM Changeset in webkit [11324] by justing

• 7 edits
  4 adds in trunk/LayoutTests

Fixed/added layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
Corner case where you can select outside the bounds of an editable block.

Reviewed by darin

• editing/inserting/insert-div-023-expected.txt:
• editing/pasteboard/paste-4035648-fix-expected.txt:
• editing/selection/3690719-expected.checksum:
• editing/selection/3690719-expected.png:
• editing/selection/3690719-expected.txt:
• editing/selection/leave-requested-block-expected.checksum: Added.
• editing/selection/leave-requested-block-expected.png: Added.
• editing/selection/leave-requested-block-expected.txt: Added.
• editing/selection/leave-requested-block.html: Added.
• editing/style/block-style-004-expected.txt:

5:35 PM Changeset in webkit [11323] by justing

• 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
Corner case where you can select outside the bounds of an editable block.

Reviewed by darin

Updated/added editing test cases to reflect fix.

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): It's ok to do some hunting to find a valid VisblePosition given a position that is not somewhere visible, like inside an empty div, but only leave the block containing the position used to construct the VisiblePosition if we can't find a VisiblePosition inside that block. We weren't using the equivalentDeepPosition of the input position to make the initUpstream/initDownstream decision, so we were sometimes moving past [br, 0], which is what having initUpstream around is supposed to prevent. I got rid of initUpstream and included the check to prevent moving past [br, 0] inside the now generalized init().

• khtml/editing/visible_units.cpp: (khtml::endOfParagraph): After the changes to VisiblePosition::init(), asking for the visible position at [br, 1] isn't the right way to include a line break.

4:17 PM Changeset in webkit [11322] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore/khtml/ecma

Build fix, missing generated files.

3:57 PM Changeset in webkit [11321] by eseidel

• 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, WebCore+SVG build fix only.

Corrected typo in last commit causing WebKit+SVG build failure.

• kcanvas/KCanvasFilters.h: (QSizeF::QSizeF): fixed typo.

3:34 PM Changeset in webkit [11320] by eseidel

• 12 edits
  36 adds in trunk/WebCore

Bug #: 5192
Submitted by: oliver hunt
Reviewed by: eseidel

Fixes 2 lighting test cases.

First-pass lighting filter implementation from Oliver.
Also incomplete first-pass feConvolveMatrix
Adding temporary QPointF, QSizeF for filter use.

• WebCore.xcodeproj/project.pbxproj: added lighting classes
• kcanvas/KCanvasFilters.cpp: (KCanvasPoint3F::normalize): added (operator<<): (KCPointLightSource::externalRepresentation): added (KCSpotLightSource::externalRepresentation): added (KCDistantLightSource::externalRepresentation): added (KCanvasFEConvolveMatrix::externalRepresentation): added (KCanvasFEDiffuseLighting::externalRepresentation): added
• kcanvas/KCanvasFilters.h: (KCanvasPoint3F::KCanvasPoint3F): added (KCanvasPoint3F::x): added (KCanvasPoint3F::setX): added (KCanvasPoint3F::y): added (KCanvasPoint3F::setY): added (KCanvasPoint3F::z): added (KCanvasPoint3F::setZ): added (QPointF::QPointF): added (QPointF::x): added (QPointF::setX): added (QPointF::y): added (QPointF::setY): added (QSizeF::QPointF): added (QSizeF::width): added (QSizeF::setWidth): added (QSizeF::height): added (QSizeF::setHeight): added (KCanvasFEConvolveMatrix::kernelSize): added (KCanvasFEConvolveMatrix::setKernelSize): added (KCanvasFEConvolveMatrix::kernel): added (KCanvasFEConvolveMatrix::setKernel): added (KCanvasFEConvolveMatrix::divisor): added (KCanvasFEConvolveMatrix::setDivisor): added (KCanvasFEConvolveMatrix::bias): added (KCanvasFEConvolveMatrix::setBias): added (KCanvasFEConvolveMatrix::targetOffset): added (KCanvasFEConvolveMatrix::setTargetOffset): added (KCanvasFEConvolveMatrix::edgeMode): added (KCanvasFEConvolveMatrix::setEdgeMode): added (KCanvasFEConvolveMatrix::kernelUnitLength): added (KCanvasFEConvolveMatrix::setKernelUnitLength): added (KCanvasFEConvolveMatrix::preserveAlpha): added (KCanvasFEConvolveMatrix::setPreserveAlpha): added (KCLightSource::KCLightSource): added (KCLightSource::~KCLightSource): added (KCLightSource::type): added (KCDistantLightSource::KCDistantLightSource): added (KCDistantLightSource::azimuth): added (KCDistantLightSource::elevation): added (KCPointLightSource::KCPointLightSource) added: (KCPointLightSource::position): added (KCSpotLightSource::KCSpotLightSource): added (KCSpotLightSource::position): added (KCSpotLightSource::direction): added (KCSpotLightSource::specularExponent): added (KCSpotLightSource::limitingConeAngle): added (KCanvasFEDiffuseLighting::lightingColor): added (KCanvasFEDiffuseLighting::setLightingColor): added (KCanvasFEDiffuseLighting::surfaceScale): added (KCanvasFEDiffuseLighting::setSurfaceScale): added (KCanvasFEDiffuseLighting::diffuseConstant): added (KCanvasFEDiffuseLighting::setDiffuseConstant): added (KCanvasFEDiffuseLighting::kernelUnitLengthX): added (KCanvasFEDiffuseLighting::setKernelUnitLengthX): added (KCanvasFEDiffuseLighting::kernelUnitLengthY): added (KCanvasFEDiffuseLighting::setKernelUnitLengthY): added (KCanvasFEDiffuseLighting::lightSource): added (KCanvasFEDiffuseLighting::setLightSource): added (KCanvasFESpecularLighting::lightingColor): added (KCanvasFESpecularLighting::setLightingColor): added (KCanvasFESpecularLighting::surfaceScale): added (KCanvasFESpecularLighting::setSurfaceScale): added (KCanvasFESpecularLighting::specularConstant): added (KCanvasFESpecularLighting::setSpecularConstant): added (KCanvasFESpecularLighting::specularExponent): added (KCanvasFESpecularLighting::setSpecularExponent): added (KCanvasFESpecularLighting::kernelUnitLengthX): added (KCanvasFESpecularLighting::setKernelUnitLengthX): added (KCanvasFESpecularLighting::kernelUnitLengthY): added (KCanvasFESpecularLighting::setKernelUnitLengthY): added (KCanvasFESpecularLighting::lightSource): added (KCanvasFESpecularLighting::setLightSource): added
• kcanvas/KCanvasTreeDebug.cpp:
• kcanvas/device/quartz/KCanvasFilterQuartz.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciColor): uncommented (ciVector): added (KCanvasFECompositeQuartz::getCIFilter): spacing fix (getPointLightVectors): added (getLightVectors): added (getNormalMap): added (KCanvasFEDiffuseLightingQuartz::getCIFilter): added (KCanvasFEGaussianBlurQuartz::getCIFilter): changed CI filter (KCanvasFESpecularLightingQuartz::getCIFilter): added
• kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createFilterEffect): added lighting
• kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKArithmeticFilter.h: Added.
• kcanvas/device/quartz/filters/WKArithmeticFilter.m: Added. (+[WKArithmeticFilter initialize]): added (+[WKArithmeticFilter filterWithName:]): added (-[WKArithmeticFilter init]): added (-[WKArithmeticFilter outputImage]): added
• kcanvas/device/quartz/filters/WKDiffuseLightingFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKDiffuseLightingFilter.h: Added.
• kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: Added. (+[WKDiffuseLightingFilter initialize]): added (+[WKDiffuseLightingFilter filterWithName:]): added (-[WKDiffuseLightingFilter init]): added (-[WKDiffuseLightingFilter outputImage]): added
• kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKDistantLightFilter.h: Added.
• kcanvas/device/quartz/filters/WKDistantLightFilter.m: Added. (+[WKDistantLightFilter initialize]): added (+[WKDistantLightFilter filterWithName:]): added (-[WKDistantLightFilter init]): added (-[WKDistantLightFilter outputImage]): added
• kcanvas/device/quartz/filters/WKNormalMapFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKNormalMapFilter.h: Added.
• kcanvas/device/quartz/filters/WKNormalMapFilter.m: Added. (+[WKNormalMapFilter initialize]): added (+[WKNormalMapFilter filterWithName:]): added (-[WKNormalMapFilter init]): added (-[WKNormalMapFilter xConvolveArgsWithBumpMap:]): added (-[WKNormalMapFilter yConvolveArgsWithBumpMap:]): added (-[WKNormalMapFilter outputImage]): added
• kcanvas/device/quartz/filters/WKPointLightFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKPointLightFilter.h: Added.
• kcanvas/device/quartz/filters/WKPointLightFilter.m: Added. (+[WKPointLightFilter initialize]): added (+[WKPointLightFilter filterWithName:]): added (-[WKPointLightFilter init]): added (-[WKPointLightFilter outputImage]): added
• kcanvas/device/quartz/filters/WKSpecularLightingFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKSpecularLightingFilter.h: Added.
• kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: Added. (+[WKSpecularLightingFilter initialize]): added (+[WKSpecularLightingFilter filterWithName:]): added (-[WKSpecularLightingFilter init]): added (-[WKSpecularLightingFilter outputImage]): added
• kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel: Added.
• kcanvas/device/quartz/filters/WKSpotLightFilter.h: Added.
• kcanvas/device/quartz/filters/WKSpotLightFilter.m: Added. (+[WKSpotLightFilter initialize]): added (+[WKSpotLightFilter filterWithName:]): added (-[WKSpotLightFilter init]): added (-[WKSpotLightFilter outputImage]): added
• ksvg2/scripts/make_names.pl: now creates lighting elements
• ksvg2/svg/SVGAnimatedColorImpl.cpp: Added. (SVGAnimatedColorImpl::SVGAnimatedColorImpl): added (SVGAnimatedColorImpl::~SVGAnimatedColorImpl): added (SVGAnimatedColorImpl::create): added (SVGAnimatedColorImpl::assign): added
• ksvg2/svg/SVGAnimatedColorImpl.h: Added.
• ksvg2/svg/SVGElementImpl.cpp: HTMLNames -> htmlnames
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::parseMappedAttribute): spelling fix
• ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: Added. (SVGFEDiffuseLightingElementImpl::SVGFEDiffuseLightingElementImpl): (SVGFEDiffuseLightingElementImpl::~SVGFEDiffuseLightingElementImpl): (SVGFEDiffuseLightingElementImpl::in1): added (SVGFEDiffuseLightingElementImpl::diffuseConstant): added (SVGFEDiffuseLightingElementImpl::surfaceScale): added (SVGFEDiffuseLightingElementImpl::kernelUnitLengthX): added (SVGFEDiffuseLightingElementImpl::kernelUnitLengthY): added (SVGFEDiffuseLightingElementImpl::lightingColor): added (SVGFEDiffuseLightingElementImpl::parseMappedAttribute): added (SVGFEDiffuseLightingElementImpl::filterEffect): added (SVGFEDiffuseLightingElementImpl::updateLights): added
• ksvg2/svg/SVGFEDiffuseLightingElementImpl.h: Added.
• ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added. (SVGFEDistantLightElementImpl::SVGFEDistantLightElementImpl): (SVGFEDistantLightElementImpl::~SVGFEDistantLightElementImpl): (SVGFEDistantLightElementImpl::lightSource): added
• ksvg2/svg/SVGFEDistantLightElementImpl.h: Added.
• ksvg2/svg/SVGFELightElementImpl.cpp: Added. (SVGFELightElementImpl::SVGFELightElementImpl): added (SVGFELightElementImpl::~SVGFELightElementImpl): added (SVGFELightElementImpl::azimuth): added (SVGFELightElementImpl::elevation): added (SVGFELightElementImpl::x): added (SVGFELightElementImpl::y): added (SVGFELightElementImpl::z): added (SVGFELightElementImpl::pointsAtX): added (SVGFELightElementImpl::pointsAtY): added (SVGFELightElementImpl::pointsAtZ): added (SVGFELightElementImpl::specularExponent): added (SVGFELightElementImpl::limitingConeAngle): added (SVGFELightElementImpl::parseMappedAttribute): added
• ksvg2/svg/SVGFELightElementImpl.h: Added.
• ksvg2/svg/SVGFEPointLightElementImpl.cpp: Added. (SVGFEPointLightElementImpl::SVGFEPointLightElementImpl): added (SVGFEPointLightElementImpl::~SVGFEPointLightElementImpl): added (SVGFEPointLightElementImpl::lightSource): added
• ksvg2/svg/SVGFEPointLightElementImpl.h: Added.
• ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: Added. (SVGFESpecularLightingElementImpl::SVGFESpecularLightingElementImpl): (SVGFESpecularLightingElementImpl::~SVGFESpecularLightingElementImpl): (SVGFESpecularLightingElementImpl::in1): added (SVGFESpecularLightingElementImpl::specularConstant): added (SVGFESpecularLightingElementImpl::specularExponent): added (SVGFESpecularLightingElementImpl::surfaceScale): added (SVGFESpecularLightingElementImpl::kernelUnitLengthX): added (SVGFESpecularLightingElementImpl::kernelUnitLengthY): added (SVGFESpecularLightingElementImpl::lightingColor): added (SVGFESpecularLightingElementImpl::parseMappedAttribute): added (SVGFESpecularLightingElementImpl::filterEffect): added (SVGFESpecularLightingElementImpl::updateLights): added
• ksvg2/svg/SVGFESpecularLightingElementImpl.h: Added.
• ksvg2/svg/SVGFESpotLightElementImpl.cpp: Added. (SVGFESpotLightElementImpl::SVGFESpotLightElementImpl): added (SVGFESpotLightElementImpl::~SVGFESpotLightElementImpl): added (SVGFESpotLightElementImpl::lightSource): added
• ksvg2/svg/SVGFESpotLightElementImpl.h: Added.
• ksvg2/svg/SVGSVGElementImpl.cpp: HTMLNames -> htmlnames

2:39 PM Changeset in webkit [11319] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin. Committed by Maciej.

• fixed "Word completion doesn't work at end of word (unless last word)" (​http://bugzilla.opendarwin.org/show_bug.cgi?id=4062)

• WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController doCompletion]):

2:16 PM Changeset in webkit [11318] by mjs

• 2 edits in trunk/WebKitTools

Reviewed by Darin. Committed by Maciej.

• fixed "DumpRenderTree should test for Ahem before doing anything else" (​http://bugzilla.opendarwin.org/show_bug.cgi?id=5838)

• DumpRenderTree/DumpRenderTree.m: (main):

2:13 PM Changeset in webkit [11317] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore/khtml/css

Checking in generated files for build fix.

2:01 PM Changeset in webkit [11316] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore/khtml

Build fix and new generated files.

12:24 PM Changeset in webkit [11315] by sullivan

• 3 edits in trunk/WebKit

Reviewed by Tim Omernick.

Probable fix for <rdar://problem/4356060> crash in -[WebHistoryItem _mergeAutoCompleteHints:]

• History.subproj/WebHistory.m: (-[WebHistoryPrivate addItem:]): retain/release oldEntry until we're done with it, since removing it from dictionary might cause it to be dealloc'ed otherwise.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem _mergeAutoCompleteHints:]): added an assert

12:04 PM Changeset in webkit [11314] by justing

• 2 edits in trunk/LayoutTests

I overlooked this layout test when fixing 4108909.

• fast/forms/attributed-strings-expected.txt:

11:44 AM Changeset in webkit [11313] by adele

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Fix by Darin, reviewed by me.

fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)

Changed the constructors to return the emtpy string if the string is null.

• kjs/value.cpp: (String::String):

10:50 AM Changeset in webkit [11312] by thatcher

• 19 edits in branches/Safari-1-3-branch

WebCore:

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
• khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
• khtml/ecma/kjs_window.h: (KJS::Window::):
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
• khtml/html/htmlnames.h:
• khtml/xml/EventNames.h:
• khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
• khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

WebKit:

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
• WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
• WebView.subproj/WebUIDelegatePrivate.h:
• WebView.subproj/WebView.m: (-[WebView shouldClose]):
• WebView.subproj/WebViewPrivate.h:

10:32 AM Changeset in webkit [11311] by eseidel

• 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: sullivan and GGAREN

Minor additions to make error messages more clear from cvs-apply.

• Scripts/cvs-apply: make errors more clear

10:23 AM Changeset in webkit [11310] by bdakin

• 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

Nov 27, 2005:

10:21 PM Changeset in webkit [11309] by mjs

• 2 edits in trunk/WebKitTools

Reviewed and committed by Maciej.

• fixed cvs-create-patch --include produces incorrect paths (​http://bugzilla.opendarwin.org/show_bug.cgi?id=5846)

• Scripts/cvs-create-patch: produce proper paths for new files.

8:37 PM Changeset in webkit [11308] by mjs

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin. Committed by Maciej.

• test case for Bidi algorithm: AN after L has incorrect resolved level (​http://bugzilla.opendarwin.org/show_bug.cgi?id=5573)

• fast/text/international/bidi-AN-after-L-expected.txt: Added.
• fast/text/international/bidi-AN-after-L.html: Added.

WebCore:

Reviewed by Darin. Committed by Maciej.

• fixed Bidi algorithm: AN after L has incorrect resolved level (​http://bugzilla.opendarwin.org/show_bug.cgi?id=5573)

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine):

2:53 PM Changeset in webkit [11307] by eseidel

• 1 edit
  4 adds in trunk/LayoutTests

Bug #: 5172
Submitted by: mitz
Reviewed by: hyatt

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5172

• fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
• fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
• fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
• fast/text/international/bidi-layout-across-linebreak.html: Added.

2:52 PM Changeset in webkit [11306] by eseidel

• 6 edits in trunk/WebCore

Bug #: 5172
Submitted by: mitz
Reviewed by: hyatt

One test case added:
fast/text/international/bidi-layout-across-linebreak.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5172

• khtml/rendering/bidi.cpp: (khtml::BidiState::BidiState): (khtml::operator==): (khtml::operator!=): (khtml::BidiIterator::increment): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::computeVerticalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::determineEndPosition): (khtml::RenderBlock::matchedEndLine): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/bidi.h: (khtml::BidiStatus::BidiStatus):
• khtml/rendering/render_block.h:
• khtml/rendering/render_line.cpp: (khtml::RootInlineBox::childRemoved): (khtml::RootInlineBox::setLineBreakInfo):
• khtml/rendering/render_line.h: (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::lineBreakBidiStatus): (khtml::RootInlineBox::lineBreakBidiContext):

3:02 AM Changeset in webkit [11305] by eseidel

• 42 edits in trunk/WebCore

Bug #: 5839
Submitted by: eseidel
Reviewed by: mjs

No additional test cases necessary, fixes text dumps for all tests.

Fixes included in this patch:

• Closes all known leaks in WebKit+SVG
• adds static KRenderingDevice *QPainter::renderingDevice()
• removes RenderCanvas::renderingDevice()
• removed RenderCanvas usage from KCanvasRenderingStyle Bug: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5839

• kcanvas/KCanvasItem.cpp: (RenderPath::RenderPath): remove canvas from KCanvasRenderingStyle (RenderPath::~RenderPath): use QPainter::renderingDevice() (RenderPath::fillContains): remove unnecessary code. (RenderPath::strokeContains): remove unnecessary code. (RenderPath::relativeBBox): remove unnecessary code. (RenderPath::setupForDraw): remove unnecessary code. (RenderPath::changePath): added ASSERT
• kcanvas/KCanvasTreeDebug.cpp: (operator<<): print absolute bbox instead of relative

(getTagName): removed KSVG

(writeRenderResources): added

• kcanvas/KCanvasTreeDebug.h: added writeRenderResources
• kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): style update
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): delete filter context
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): only push context if necessary
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): only push context if necessary
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): use QPainter
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): spacing cleanup
• khtml/rendering/render_canvas.cpp: remove renderingDevice() (RenderCanvas::RenderCanvas): remove m_renderingDevice (RenderCanvas::~RenderCanvas): remove m_renderingDevice
• khtml/rendering/render_canvas.h:
• khtml/rendering/render_style.cpp: (RenderStyle::~RenderStyle): delete SVGRenderStyle
• ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::~SVGRenderStyle): added
• ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::KCanvasRenderingStyle): remove canvas arg (KCanvasRenderingStyle::updateFill): use QPainter (KCanvasRenderingStyle::updateStroke): use QPainter
• ksvg2/misc/KCanvasRenderingStyle.h:
• ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer): use QPainter
• ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::~SVGClipPathElementImpl): delete resource (SVGClipPathElementImpl::canvasResource): use QPainter
• ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::~SVGFEBlendElementImpl): delete resource (SVGFEBlendElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::~SVGFEColorMatrixElementImpl): (SVGFEColorMatrixElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::~SVGFEComponentTransferElementImpl): (SVGFEComponentTransferElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::~SVGFECompositeElementImpl): delete rsc (SVGFECompositeElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::~SVGFEFloodElementImpl): delete resource (SVGFEFloodElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::~SVGFEGaussianBlurElementImpl): (SVGFEGaussianBlurElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): delete resource (SVGFEImageElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::~SVGFEMergeElementImpl): delete resource (SVGFEMergeElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::~SVGFEOffsetElementImpl): delete resource (SVGFEOffsetElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::~SVGFETileElementImpl): delete resource (SVGFETileElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::~SVGFETurbulenceElementImpl): (SVGFETurbulenceElementImpl::filterEffect): use QPainter
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::~SVGFilterElementImpl): delete resource (SVGFilterElementImpl::canvasResource): use QPainter
• ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer): use QPainter
• ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::~SVGGradientElementImpl): delete resource (SVGGradientElementImpl::canvasResource): use QPainter (SVGGradientElementImpl::rebuildStops): deref style
• ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): use QPainter (SVGImageElementImpl::notifyFinished): use QPainter
• ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::~SVGMarkerElementImpl): delete resource (SVGMarkerElementImpl::canvasResource): use QPainter (SVGMarkerElementImpl::createRenderer): use QPainter
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::~SVGPatternElementImpl): delete resource (SVGPatternElementImpl::drawPatternContentIntoTile): use QPainter (SVGPatternElementImpl::createRenderer): use QPainter (SVGPatternElementImpl::canvasResource): use QPainter
• ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::createRenderer): use QPainter
• ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer): use QPainter (SVGStyledElementImpl::updateCanvasItem): use QPainter (SVGStyledElementImpl::pushAttributeContext): use QPainter
• ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer): use QPainter
• ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): use QPainter
• kwq/KWQPainter.h:
• kwq/KWQPainter.mm: (QPainter::renderingDevice): added
• kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): call writeRenderResources

Nov 26, 2005:

11:54 PM Changeset in webkit [11304] by mjs

• 29 edits in trunk

JavaScriptCore:

Rubber stamped by Eric.

• renamed InterpreterLock to JSLock

• bindings/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
• bindings/jni/jni_jsobject.cpp: (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::convertJObjectToValue):
• bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
• bindings/runtime.cpp: (Instance::createRuntimeObject):
• bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
• bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):
• bindings/testbindings.cpp: (main):
• bindings/testbindings.mm: (main):
• kjs/JSLock.cpp: (KJS::initializeJSLock): (KJS::JSLock::lock): (KJS::JSLock::unlock): (KJS::JSLock::lockCount): (KJS::JSLock::DropAllLocks::DropAllLocks): (KJS::JSLock::DropAllLocks::~DropAllLocks):
• kjs/JSLock.h: (KJS::JSLock::JSLock): (KJS::JSLock::~JSLock):
• kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):
• kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
• kjs/interpreter.cpp: (Interpreter::evaluate):
• kjs/protect.h: (KJS::::ProtectedPtr): (KJS::::~ProtectedPtr): (KJS::::operator):
• kjs/protected_reference.h: (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=):
• kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount):
• kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (main):

WebCore:

Rubber stamped by Eric.

• renamed InterpreterLock to JSLock

• khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode): (KJS::getDOMEvent):
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::~KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
• khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
• khtml/ecma/kjs_window.cpp: (KJS::Window::clear): (KJS::ScheduledAction::execute):
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::cleanupPluginRootObjects):
• kwq/KWQPageState.mm: (-[KWQPageState clear]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
• kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):
• kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):

10:36 PM Changeset in webkit [11303] by eseidel

• 2 edits in trunk/WebKit

Bug #: 5230
Submitted by: ap
Reviewed by: mjs

Reviewed by mjs. Committed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5230
"characterIndexForPoint: not yet implemented"

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]):

7:10 PM Changeset in webkit [12216] by mjs

• 5 edits in trunk/JavaScriptGlue

Rubber stamped by Eric.

• renamed InterpreterLock to JSLock

• JSUtils.cpp: (CFStringToUString): (JSObjectKJSValue): (KJSValueToCFTypeInternal):
• JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
• JavaScriptGlue.cpp: (JSRunCreate): (JSCollect): (JSLockInterpreter): (JSUnlockInterpreter):
• UserObjectImp.cpp: (UserObjectImp::callAsFunction):

6:26 PM Changeset in webkit [11302] by eseidel

• 2 edits in trunk/WebCore

Bug #: 5548
Submitted by: ap
Reviewed by: darin

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5548
Allow <meta> to override encoding.

• khtml/misc/decoder.cpp: (Decoder::decode):

6:23 PM Changeset in webkit [11301] by eseidel

• 1 edit
  6 adds in trunk/LayoutTests

Bug #: 5548
Submitted by: ap
Reviewed by: darin

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5548

• fast/encoding/charset-unicode-expected.txt: Added.
• fast/encoding/charset-unicode.html: Added.
• fast/encoding/charset-utf16-expected.txt: Added.
• fast/encoding/charset-utf16.html: Added.
• fast/encoding/xml-charset-utf16-expected.txt: Added.
• fast/encoding/xml-charset-utf16.html: Added.

6:20 PM Changeset in webkit [11300] by eseidel

• 1 edit
  2 adds in trunk/LayoutTests

Bug #: 5710
Submitted by: mitz
Reviewed by: ggaren

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5710
item(i) should return the same result as [i]

• fast/js/array-special-accessors-should-ignore-items-expected.txt: Added.
• fast/js/array-special-accessors-should-ignore-items.html: Added.

6:06 PM Changeset in webkit [11299] by eseidel

• 2 edits in trunk/WebCore

Bug #: 5710
Submitted by: mitz
Reviewed by: ggaren

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5710
item(i) should work like item[i]

• khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):

5:50 PM Changeset in webkit [11298] by eseidel

• 3 edits in trunk/WebCore

Bug #: 5230
Submitted by: ap
Reviewed by: mjs

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5230
"characterIndexForPoint: not yet implemented"

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): (-[WebCoreBridge convertNSRangeToDOMRange:]): (-[WebCoreBridge convertDOMRangeToNSRange:]): (-[WebCoreBridge characterRangeAtPoint:]):

5:46 PM Changeset in webkit [11297] by eseidel

• 1 edit
  2 adds in trunk/LayoutTests

Bug #: 5230
Submitted by: ap
Reviewed by: mjs

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5230

• fast/dom/character-index-for-point-expected.txt: Added.
• fast/dom/character-index-for-point.html: Added.

5:28 PM Changeset in webkit [11296] by eseidel

• 4 edits in trunk/JavaScriptCore

Bug #: 5687
Submitted by: darin
Reviewed by: eseidel

Inline ScopeChain functions for speed.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5687

• kjs/object.h: (KJS::ScopeChain::mark):
• kjs/scope_chain.cpp:
• kjs/scope_chain.h: (KJS::ScopeChain::ref): (KJS::ScopeChain::operator=): (KJS::ScopeChain::bottom): (KJS::ScopeChain::push): (KJS::ScopeChain::pop):

5:10 PM Changeset in webkit [11295] by eseidel

• 2 edits in trunk/WebCore

Bug #: 5822
Submitted by: mitz
Reviewed by: darin

• khtml/rendering/render_table.cpp: <col>, <colgroup> <caption> fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5822

5:06 PM Changeset in webkit [11294] by eseidel

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: 5829
Submitted by: mitz
Reviewed by: darin

• khtml/rendering/render_table.cpp: <col>, <colgroup> <caption> fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5829

5:02 PM Changeset in webkit [11293] by eseidel

• 1 edit
  4 adds in trunk/LayoutTests

Bug #: 5822
Submitted by: mitz
Reviewed by: darin

<col> <colgroup> tests from mitz.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5822

• fast/table/colgroup-preceded-by-caption-expected.checksum: Added.
• fast/table/colgroup-preceded-by-caption-expected.png: Added.
• fast/table/colgroup-preceded-by-caption-expected.txt: Added.
• fast/table/colgroup-preceded-by-caption.html: Added.

2:35 PM Changeset in webkit [11292] by eseidel

• 33 edits in trunk/WebCore

Bug #: 5810
Submitted by: eseidel
Reviewed by: mjs

Fix support for <switch>:
(by fixing isValid and adding childShouldCreateRenderer)
Added remedial on* event support.
Added basic <script> processing support.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5810

• kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose):
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::createRendererIfNeeded):
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::childShouldCreateRenderer):
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::finish): (khtml::XMLTokenizer::addScripts): (khtml::xmlDocPtrForString):
• ksvg2/svg/SVGAElementImpl.h: (KSVG::SVGAElementImpl::isValid): (KSVG::SVGAElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGAnimationElementImpl.h: (KSVG::SVGAnimationElementImpl::isValid):
• ksvg2/svg/SVGCircleElementImpl.h: (KSVG::SVGCircleElementImpl::isValid):
• ksvg2/svg/SVGClipPathElementImpl.h: (KSVG::SVGClipPathElementImpl::isValid):
• ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::isValid):
• ksvg2/svg/SVGDefsElementImpl.h: (KSVG::SVGDefsElementImpl::isValid):
• ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGEllipseElementImpl.h: (KSVG::SVGEllipseElementImpl::isValid):
• ksvg2/svg/SVGGElementImpl.h: (KSVG::SVGGElementImpl::isValid):
• ksvg2/svg/SVGImageElementImpl.h: (KSVG::SVGImageElementImpl::isValid):
• ksvg2/svg/SVGLineElementImpl.h: (KSVG::SVGLineElementImpl::isValid):
• ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
• ksvg2/svg/SVGPathElementImpl.h: (KSVG::SVGPathElementImpl::isValid):
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile):
• ksvg2/svg/SVGPatternElementImpl.h: (KSVG::SVGPatternElementImpl::isValid):
• ksvg2/svg/SVGPolyElementImpl.h: (KSVG::SVGPolyElementImpl::isValid):
• ksvg2/svg/SVGRectElementImpl.h: (KSVG::SVGRectElementImpl::isValid):
• ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGSVGElementImpl.h: (KSVG::SVGSVGElementImpl::isValid):
• ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::updateCanvasItem):
• ksvg2/svg/SVGStyledElementImpl.h:
• ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::childShouldCreateRenderer):
• ksvg2/svg/SVGSwitchElementImpl.h: (KSVG::SVGSwitchElementImpl::isValid):
• ksvg2/svg/SVGSymbolElementImpl.h: (KSVG::SVGSymbolElementImpl::shouldAttachChild):
• ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::parseMappedAttribute):
• ksvg2/svg/SVGTextContentElementImpl.h: (KSVG::SVGTextContentElementImpl::isValid):
• ksvg2/svg/SVGUseElementImpl.h: (KSVG::SVGUseElementImpl::isValid):

2:27 PM Changeset in webkit [11291] by eseidel

• 10 edits in trunk/WebCore

Bug #: 5810
Submitted by: eseidel
Reviewed by: mjs

No additional test cases needed, this fixes 5 existing tests.

This patch fixes feImage (to scale and flip).
Also fixes feColorMatrix (previously inadvertently disabled)
Fixes <svg> in <svg> (sub-elements establishing viewports)
Fixes clip-rule, by fixing style resolution on <clipPath> children

• WebCore.xcodeproj/project.pbxproj: removed svgattr.[ch]
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEFloodQuartz::getCIFilter): respect subregion (KCanvasFEImageQuartz::getCIFilter): respect subregion, scale, flip
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (CGPathFromKCPathDataList): style/spacing update (KCanvasContainerQuartz::paint): handle viewport, singular filters
• khtml/rendering/render_object.cpp: (RenderObject::absoluteTransform): use QMatrix operator *
• ksvg2/scripts/make_names.pl: allow FEColorMatrixElementImpl
• ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource): resolve style manually
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect): spacing fix
• kwq/KWQWMatrix.h:
• kwq/KWQWMatrix.mm: (QWMatrix::operator* ): added

2:19 PM Changeset in webkit [11290] by eseidel

• 106 edits in trunk/WebCore

Bug #: 5825
Submitted by: eseidel
Reviewed by: darin

Removed all usage of ref(), deref() from ksvg2
Instead everything uses SharedPtr now.
Also updated lazy_create to be SharedPtr aware.
And removed KDOM_SAFE_SET.

No additional test cases needed.

• WebCore+SVG/KDOMStubClasses.h:
• ksvg2/events/SVGZoomEventImpl.cpp: (SVGZoomEventImpl::SVGZoomEventImpl): (SVGZoomEventImpl::~SVGZoomEventImpl): (SVGZoomEventImpl::zoomRectScreen): (SVGZoomEventImpl::previousTranslate): (SVGZoomEventImpl::newTranslate):
• ksvg2/events/SVGZoomEventImpl.h:
• ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
• ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::SVGAElementImpl): (SVGAElementImpl::~SVGAElementImpl):
• ksvg2/svg/SVGAElementImpl.h:
• ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::SVGAnimateColorElementImpl): (SVGAnimateColorElementImpl::~SVGAnimateColorElementImpl): (SVGAnimateColorElementImpl::handleTimerEvent):
• ksvg2/svg/SVGAnimateColorElementImpl.h:
• ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::parseTransformValue):
• ksvg2/svg/SVGAnimateTransformElementImpl.h:
• ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::~SVGAnimatedTemplate): (KSVG::SVGAnimatedTemplate::baseVal): (KSVG::SVGAnimatedTemplate::setBaseVal): (KSVG::SVGAnimatedTemplate::animVal): (KSVG::SVGAnimatedTemplate::setAnimVal): (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
• ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::SVGAnimationElementImpl): (SVGAnimationElementImpl::~SVGAnimationElementImpl): (SVGAnimationElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGAnimationElementImpl.h:
• ksvg2/svg/SVGCircleElementImpl.cpp: (SVGCircleElementImpl::SVGCircleElementImpl): (SVGCircleElementImpl::~SVGCircleElementImpl):
• ksvg2/svg/SVGCircleElementImpl.h:
• ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::SVGClipPathElementImpl): (SVGClipPathElementImpl::~SVGClipPathElementImpl): (SVGClipPathElementImpl::clipPathUnits):
• ksvg2/svg/SVGClipPathElementImpl.h:
• ksvg2/svg/SVGColorImpl.cpp: (SVGColorImpl::SVGColorImpl): (SVGColorImpl::~SVGColorImpl): (SVGColorImpl::setRGBColor):
• ksvg2/svg/SVGColorImpl.h:
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::SVGComponentTransferFunctionElementImpl): (SVGComponentTransferFunctionElementImpl::~SVGComponentTransferFunctionElementImpl):
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
• ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::SVGCursorElementImpl): (SVGCursorElementImpl::~SVGCursorElementImpl):
• ksvg2/svg/SVGCursorElementImpl.h:
• ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl):
• ksvg2/svg/SVGDocumentImpl.h:
• ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGElementImpl.h:
• ksvg2/svg/SVGEllipseElementImpl.cpp: (KSVG::SVGEllipseElementImpl::SVGEllipseElementImpl): (KSVG::SVGEllipseElementImpl::~SVGEllipseElementImpl):
• ksvg2/svg/SVGEllipseElementImpl.h:
• ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp: (SVGExternalResourcesRequiredImpl::SVGExternalResourcesRequiredImpl): (SVGExternalResourcesRequiredImpl::~SVGExternalResourcesRequiredImpl):
• ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
• ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::SVGFEBlendElementImpl): (SVGFEBlendElementImpl::~SVGFEBlendElementImpl):
• ksvg2/svg/SVGFEBlendElementImpl.h:
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::SVGFEColorMatrixElementImpl): (SVGFEColorMatrixElementImpl::~SVGFEColorMatrixElementImpl):
• ksvg2/svg/SVGFEColorMatrixElementImpl.h:
• ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::SVGFEComponentTransferElementImpl): (SVGFEComponentTransferElementImpl::~SVGFEComponentTransferElementImpl):
• ksvg2/svg/SVGFEComponentTransferElementImpl.h:
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::SVGFECompositeElementImpl): (SVGFECompositeElementImpl::~SVGFECompositeElementImpl):
• ksvg2/svg/SVGFECompositeElementImpl.h:
• ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::SVGFEFloodElementImpl): (SVGFEFloodElementImpl::~SVGFEFloodElementImpl):
• ksvg2/svg/SVGFEFloodElementImpl.h:
• ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::SVGFEGaussianBlurElementImpl): (SVGFEGaussianBlurElementImpl::~SVGFEGaussianBlurElementImpl):
• ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::SVGFEImageElementImpl): (SVGFEImageElementImpl::~SVGFEImageElementImpl):
• ksvg2/svg/SVGFEImageElementImpl.h:
• ksvg2/svg/SVGFEMergeNodeElementImpl.cpp: (SVGFEMergeNodeElementImpl::SVGFEMergeNodeElementImpl): (SVGFEMergeNodeElementImpl::~SVGFEMergeNodeElementImpl):
• ksvg2/svg/SVGFEMergeNodeElementImpl.h:
• ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::SVGFEOffsetElementImpl): (SVGFEOffsetElementImpl::~SVGFEOffsetElementImpl):
• ksvg2/svg/SVGFEOffsetElementImpl.h:
• ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::SVGFETileElementImpl): (SVGFETileElementImpl::~SVGFETileElementImpl):
• ksvg2/svg/SVGFETileElementImpl.h:
• ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::SVGFETurbulenceElementImpl): (SVGFETurbulenceElementImpl::~SVGFETurbulenceElementImpl):
• ksvg2/svg/SVGFETurbulenceElementImpl.h:
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::SVGFilterElementImpl): (SVGFilterElementImpl::~SVGFilterElementImpl): (SVGFilterElementImpl::filterUnits): (SVGFilterElementImpl::primitiveUnits): (SVGFilterElementImpl::x): (SVGFilterElementImpl::y): (SVGFilterElementImpl::width): (SVGFilterElementImpl::height):
• ksvg2/svg/SVGFilterElementImpl.h:
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::SVGFilterPrimitiveStandardAttributesImpl): (SVGFilterPrimitiveStandardAttributesImpl::~SVGFilterPrimitiveStandardAttributesImpl): (SVGFilterPrimitiveStandardAttributesImpl::width): (SVGFilterPrimitiveStandardAttributesImpl::height):
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
• ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::SVGGradientElementImpl): (SVGGradientElementImpl::~SVGGradientElementImpl): (SVGGradientElementImpl::gradientUnits):
• ksvg2/svg/SVGGradientElementImpl.h:
• ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
• ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::SVGImageElementImpl): (SVGImageElementImpl::~SVGImageElementImpl):
• ksvg2/svg/SVGImageElementImpl.h:
• ksvg2/svg/SVGLineElementImpl.cpp: (SVGLineElementImpl::SVGLineElementImpl): (SVGLineElementImpl::~SVGLineElementImpl):
• ksvg2/svg/SVGLineElementImpl.h:
• ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::SVGLinearGradientElementImpl): (SVGLinearGradientElementImpl::~SVGLinearGradientElementImpl): (SVGLinearGradientElementImpl::x2):
• ksvg2/svg/SVGLinearGradientElementImpl.h:
• ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::SVGMarkerElementImpl): (SVGMarkerElementImpl::~SVGMarkerElementImpl): (SVGMarkerElementImpl::markerUnits):
• ksvg2/svg/SVGMarkerElementImpl.h:
• ksvg2/svg/SVGPaintImpl.cpp: (SVGPaintImpl::SVGPaintImpl): (SVGPaintImpl::~SVGPaintImpl): (SVGPaintImpl::uri): (SVGPaintImpl::setUri): (SVGPaintImpl::cssText):
• ksvg2/svg/SVGPaintImpl.h:
• ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::SVGPathElementImpl): (KSVG::SVGPathElementImpl::~SVGPathElementImpl): (KSVG::SVGPathElementImpl::pathLength):
• ksvg2/svg/SVGPathElementImpl.h:
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::SVGPatternElementImpl): (SVGPatternElementImpl::~SVGPatternElementImpl): (SVGPatternElementImpl::patternUnits): (SVGPatternElementImpl::patternContentUnits): (SVGPatternElementImpl::getCTM):
• ksvg2/svg/SVGPatternElementImpl.h:
• ksvg2/svg/SVGPolyElementImpl.cpp: (SVGPolyElementImpl::SVGPolyElementImpl): (SVGPolyElementImpl::~SVGPolyElementImpl):
• ksvg2/svg/SVGPolyElementImpl.h:
• ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::SVGRadialGradientElementImpl): (SVGRadialGradientElementImpl::~SVGRadialGradientElementImpl): (SVGRadialGradientElementImpl::cx): (SVGRadialGradientElementImpl::cy): (SVGRadialGradientElementImpl::r):
• ksvg2/svg/SVGRadialGradientElementImpl.h:
• ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::SVGRectElementImpl): (SVGRectElementImpl::~SVGRectElementImpl):
• ksvg2/svg/SVGRectElementImpl.h:
• ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::SVGSVGElementImpl): (SVGSVGElementImpl::~SVGSVGElementImpl): (SVGSVGElementImpl::width): (SVGSVGElementImpl::height): (SVGSVGElementImpl::viewport):
• ksvg2/svg/SVGSVGElementImpl.h:
• ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::SVGScriptElementImpl): (SVGScriptElementImpl::~SVGScriptElementImpl): (SVGScriptElementImpl::type): (SVGScriptElementImpl::setType): (SVGScriptElementImpl::executeScript):
• ksvg2/svg/SVGScriptElementImpl.h:
• ksvg2/svg/SVGStopElementImpl.cpp: (SVGStopElementImpl::SVGStopElementImpl): (SVGStopElementImpl::~SVGStopElementImpl):
• ksvg2/svg/SVGStopElementImpl.h:
• ksvg2/svg/SVGStringListImpl.cpp: (SVGStringListImpl::reset):
• ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::SVGStyledElementImpl): (SVGStyledElementImpl::~SVGStyledElementImpl): (SVGStyledElementImpl::className):
• ksvg2/svg/SVGStyledElementImpl.h:
• ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::SVGStyledTransformableElementImpl): (SVGStyledTransformableElementImpl::~SVGStyledTransformableElementImpl): (SVGStyledTransformableElementImpl::getCTM): (SVGStyledTransformableElementImpl::getScreenCTM): (SVGStyledTransformableElementImpl::updateLocalTransform):
• ksvg2/svg/SVGStyledTransformableElementImpl.h:
• ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::SVGTestsImpl): (SVGTestsImpl::~SVGTestsImpl):
• ksvg2/svg/SVGTestsImpl.h:
• ksvg2/svg/SVGTextContentElementImpl.cpp: (SVGTextContentElementImpl::SVGTextContentElementImpl): (SVGTextContentElementImpl::~SVGTextContentElementImpl):
• ksvg2/svg/SVGTextContentElementImpl.h:
• ksvg2/svg/SVGTextPositioningElementImpl.cpp: (SVGTextPositioningElementImpl::SVGTextPositioningElementImpl): (SVGTextPositioningElementImpl::~SVGTextPositioningElementImpl):
• ksvg2/svg/SVGTextPositioningElementImpl.h:
• ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl): (SVGTransformImpl::~SVGTransformImpl): (SVGTransformImpl::matrix): (SVGTransformImpl::setMatrix):
• ksvg2/svg/SVGTransformImpl.h:
• ksvg2/svg/SVGURIReferenceImpl.cpp: (SVGURIReferenceImpl::SVGURIReferenceImpl): (SVGURIReferenceImpl::~SVGURIReferenceImpl):
• ksvg2/svg/SVGURIReferenceImpl.h:
• ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::SVGUseElementImpl): (SVGUseElementImpl::~SVGUseElementImpl):
• ksvg2/svg/SVGUseElementImpl.h:
• ksvg2/svg/SVGViewElementImpl.cpp: (SVGViewElementImpl::SVGViewElementImpl): (SVGViewElementImpl::~SVGViewElementImpl):
• ksvg2/svg/SVGViewElementImpl.h:

Nov 25, 2005:

3:14 AM Changeset in webkit [11289] by eseidel

• 196 edits
  2 deletes in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: rubber-stamped by mjs

Updated test results after DOM merger.

• svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
• svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
• svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-01-b.svg: Removed.
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
• svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-03-t.svg: Removed.
• svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
• svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
• svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
• svg/W3C-SVG-1.1/struct-frag-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
• svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-01-b-expected.png:
• svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:

2:39 AM Changeset in webkit [11288] by eseidel

• 28 edits
  2 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: rubber-stamped by mjs

Test cases hrefs fixed from "../Images/" to "resources/"
Disabled two tests which were crashing in libxml2.

• svg/W3C-SVG-1.1/color-prof-01-f.svg:
• svg/W3C-SVG-1.1/coords-viewattr-01-b.svg: Removed.
• svg/W3C-SVG-1.1/coords-viewattr-01-b.svg-disabled: Added.
• svg/W3C-SVG-1.1/filters-conv-01-f.svg:
• svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
• svg/W3C-SVG-1.1/filters-displace-01-f.svg:
• svg/W3C-SVG-1.1/filters-image-01-b.svg:
• svg/W3C-SVG-1.1/filters-light-01-f.svg:
• svg/W3C-SVG-1.1/filters-specular-01-f.svg:
• svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
• svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
• svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
• svg/W3C-SVG-1.1/interact-order-02-b.svg:
• svg/W3C-SVG-1.1/interact-order-03-b.svg:
• svg/W3C-SVG-1.1/linking-a-01-b.svg:
• svg/W3C-SVG-1.1/linking-a-02-b.svg:
• svg/W3C-SVG-1.1/linking-a-03-b.svg:
• svg/W3C-SVG-1.1/linking-a-04-t.svg:
• svg/W3C-SVG-1.1/linking-uri-02-b.svg:
• svg/W3C-SVG-1.1/linking-uri-03-t.svg:
• svg/W3C-SVG-1.1/masking-path-04-b.svg:
• svg/W3C-SVG-1.1/render-elems-03-t.svg: Removed.
• svg/W3C-SVG-1.1/render-elems-03-t.svg-disabled: Added.
• svg/W3C-SVG-1.1/render-groups-01-b.svg:
• svg/W3C-SVG-1.1/render-groups-03-t.svg:
• svg/W3C-SVG-1.1/struct-image-01-t.svg:
• svg/W3C-SVG-1.1/struct-image-02-b.svg:
• svg/W3C-SVG-1.1/struct-image-03-t.svg:
• svg/W3C-SVG-1.1/struct-image-05-b.svg:
• svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
• svg/W3C-SVG-1.1/text-tref-01-b.svg:

Nov 23, 2005:

7:14 AM Changeset in webkit [11287] by eseidel

• 30 edits in trunk/WebCore

Bug #: 4780
Submitted by: eseidel
Reviewed by: mjs

No additional test cases needed, this fixes 15+ existing tests.

This latest set of changes fixes <image> loading (mostly)
(There still seems to be an image loading race condition.)
This also fixes viewBox support (for many tests)
Fixes a Safari crasher when using patterns
Fixes bbox() handling throughout code (for spec conformance)

• kcanvas/KCanvasContainer.cpp: (KCanvasContainer::Private::Private): renamed drawContents (KCanvasContainer::drawsContents): renamed drawContents (KCanvasContainer::setDrawsContents): renamed drawContents (KCanvasContainer::relativeBBox): renamed bbox(), fixed
• kcanvas/KCanvasContainer.h:
• kcanvas/KCanvasFilters.h:
• kcanvas/KCanvasItem.cpp: (RenderPath::relativeBBox): renamed bbox()
• kcanvas/KCanvasItem.h:
• kcanvas/KCanvasPath.cpp: (operator<<): removed deprecated "viewportClip" support
• kcanvas/KCanvasPath.h: (KCClipDataList::addPath): removed "viewportClip" support
• kcanvas/KCanvasResources.cpp: (KCanvasClipper::KCanvasClipper): removed "viewportClip" support (KCanvasClipper::addClipData): removed "viewportClip" support (KCanvasClipper::externalRepresentation): removed "viewportClip"
• kcanvas/KCanvasResources.h:
• kcanvas/KCanvasTreeDebug.cpp: (operator<<): removed "viewportClip" support
• kcanvas/device/quartz/KCanvasFilterQuartz.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): combined, simplified (KCanvasFilterQuartz::applyFilter): combined, simplified (KCanvasFilterQuartz::filterBBoxForItemBBox): simplified
• kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect): added
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): updated for bbox() changes (getSharedContext): simplified (KCanvasItemQuartz::bboxForPath): name change (KCanvasItemQuartz::hitsPath): fixed for absoluteTransform()
• kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect): added
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::layout): call RenderContainer::layout() (KCanvasContainerQuartz::paint): drawsContents() && viewbox() (KCanvasContainerQuartz::absoluteTransform): added (KCanvasClipperQuartz::applyClip): simplified
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw): added stretch/scale
• khtml/rendering/render_object.cpp: added absoluteTransform() (RenderObject::absoluteTransform):
• khtml/rendering/render_object.h: added absoluteTransform() (khtml::RenderObject::relativeBBox): rename (khtml::RenderObject::localTransform): better default behavior
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): simpler code
• ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::viewportElement): use isElementNode()
• ksvg2/svg/SVGImageElementImpl.cpp: removed finalizeStyle() (SVGImageElementImpl::attach): (SVGImageElementImpl::notifyFinished):
• ksvg2/svg/SVGImageElementImpl.h:
• ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value): bbox() rename
• ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox): fixed bbox() behavior
• ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::createRenderer): drawsContents rename
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): fixed crash (SVGPatternElementImpl::createRenderer): drawsContents rename
• ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::x): simplified code (SVGSVGElementImpl::y): simplified code (SVGSVGElementImpl::width): simplified code (SVGSVGElementImpl::height): simplified code (SVGSVGElementImpl::parseMappedAttribute): add width/height to DOM
• kwq/KWQWMatrix.mm: (QWMatrix::mapRect): simplified code

1:48 AM Changeset in webkit [11286] by andersca

• 33 edits
  1 add
  1 delete in trunk/LayoutTests

2005-11-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Update tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5805>
Implement adoptNode.

• dom/xhtml/level3/core/documentadoptnode01-expected.txt:
• dom/xhtml/level3/core/documentadoptnode02-expected.txt:
• dom/xhtml/level3/core/documentadoptnode03-expected.txt:
• dom/xhtml/level3/core/documentadoptnode04-expected.txt:
• dom/xhtml/level3/core/documentadoptnode05-expected.txt:
• dom/xhtml/level3/core/documentadoptnode06-expected.txt:
• dom/xhtml/level3/core/documentadoptnode07-expected.txt:
• dom/xhtml/level3/core/documentadoptnode08-expected.txt:
• dom/xhtml/level3/core/documentadoptnode09-expected.txt:
• dom/xhtml/level3/core/documentadoptnode10-expected.txt:
• dom/xhtml/level3/core/documentadoptnode11-expected.txt:
• dom/xhtml/level3/core/documentadoptnode12-expected.txt:
• dom/xhtml/level3/core/documentadoptnode13-expected.txt:
• dom/xhtml/level3/core/documentadoptnode14-expected.txt:
• dom/xhtml/level3/core/documentadoptnode15-expected.txt:
• dom/xhtml/level3/core/documentadoptnode16-expected.txt:
• dom/xhtml/level3/core/documentadoptnode21-expected.txt:
• dom/xhtml/level3/core/documentadoptnode23-expected.txt:
• dom/xhtml/level3/core/documentadoptnode24-expected.txt:
• dom/xhtml/level3/core/documentadoptnode25-expected.txt:
• dom/xhtml/level3/core/documentadoptnode26-expected.txt:
• dom/xhtml/level3/core/documentadoptnode27-expected.txt:
• dom/xhtml/level3/core/documentadoptnode28-expected.txt:
• dom/xhtml/level3/core/documentadoptnode30-expected.txt:
• dom/xhtml/level3/core/documentadoptnode31-expected.txt:
• dom/xhtml/level3/core/documentadoptnode32-expected.txt:
• dom/xhtml/level3/core/documentadoptnode33-expected.txt:
• dom/xhtml/level3/core/documentadoptnode34-expected.txt:
• dom/xhtml/level3/core/documentadoptnode35-expected.txt:
• dom/xhtml/level3/core/documentadoptnode36-expected.txt: These tests pass now.

• dom/xhtml/level3/core/documentadoptnode22.xhtml: Removed.
• dom/xhtml/level3/core/documentadoptnode22.xhtml-disabled: Added. Disable this test for now. It removes the entire document tree which makes it hard to show the test result.

• dom/xhtml/level3/core/documentrenamenode09-expected.txt: This now fails because renameNode is undefined.

• dom/xhtml/level3/core/nodeisequalnode18-expected.txt: This now passes.

1:46 AM Changeset in webkit [11285] by andersca

• 7 edits in trunk/WebCore

2005-11-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5805>
Implement adoptNode.

• khtml/ecma/kjs_dom.cpp: (KJS::DOMDocumentProtoFunc::callAsFunction):
• khtml/ecma/kjs_dom.h: (KJS::DOMDocument::): Add JS wrapper for adoptNode.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode):
• khtml/xml/dom_docimpl.h: Implement adoptNode.

• kwq/DOM.mm: (-[DOMDocument adoptNode:]):
• kwq/DOMPrivate.h: Add Objective C wrapper for adoptNode.

Nov 22, 2005:

9:41 PM Changeset in webkit [11284] by mjs

• 15 edits
  2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4139620> Seed: WebKit: hang when sending XMLHttpRequest if automatic proxy config is used

Also factored locking code completely into a separate class, and
added a convenient packaged way to temporarily drop locks.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/JSLock.cpp: Added. (KJS::initializeInterpreterLock): (KJS::InterpreterLock::lock): (KJS::InterpreterLock::unlock): (KJS::InterpreterLock::lockCount): (KJS::InterpreterLock::DropAllLocks::DropAllLocks): (KJS::InterpreterLock::DropAllLocks::~DropAllLocks):
• kjs/JSLock.h: Added. (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock):
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/interpreter.cpp:
• kjs/interpreter.h:
• kjs/protect.h:
• kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

WebCore:

Reviewed by Geoff.

<rdar://problem/4139620> Seed: WebKit: hang when sending XMLHttpRequest if automatic proxy config is used

• khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send):
• kwq/WebCoreJavaScript.mm:

9:40 PM Changeset in webkit [12215] by mjs

• 3 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

Updated to use new API to drop all locks.

• JavaScriptGlue.cpp: (JSLockInterpreter): (JSUnlockInterpreter):
• UserObjectImp.cpp: (UserObjectImp::callAsFunction):

3:04 PM Changeset in webkit [11283] by eseidel

• 35 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review required, svg target only.

No additional test cases needed, this fixes 10+ existing tests.

Fixed filters by fixing how KCanvasDeviceContexts are pushed/poped
They now properly update the NSGrapicsContext currentContext, when
being pushed/poped which allows for QPainter to notice the change.
I also fixed <feImage> while there and updated all of the
subclassed filterEffect() methods to return to proper subclass.

• kcanvas/KCanvasFilters.h:
• kcanvas/device/KRenderingDevice.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::KCanvasFilterQuartz): (KCanvasFilterQuartz::~KCanvasFilterQuartz): (KCanvasFilterQuartz::prepareFilter): fixed to push context (KCanvasFilterQuartz::applyFilter): fixed to pop context (KCanvasFEImageQuartz::getCIFilter): fixed :)
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): fixed to push/pop context
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): fixed to push/pop context
• kcanvas/device/quartz/KRenderingDeviceQuartz.h: (KRenderingDeviceContextQuartz::cgContext):
• kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz): (KRenderingDeviceContextQuartz::nsGraphicsContext): added (KRenderingDeviceQuartz::currentCGContext): (KRenderingDeviceQuartz::pushContext): now updates NSGraphicsContext (KRenderingDeviceQuartz::popContext): now updates NSGraphicsContext (KRenderingDeviceQuartz::contextForImage): fixed spacing (KRenderingDeviceQuartz::createPaintServer): removed comment
• ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEBlendElementImpl.h:
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEColorMatrixElementImpl.h:
• ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect): returns sublcass
• ksvg2/svg/SVGFEComponentTransferElementImpl.h:
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFECompositeElementImpl.h:
• ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEFloodElementImpl.h:
• ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::notifyFinished): updates filterEffect on load (SVGFEImageElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEImageElementImpl.h:
• ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEMergeElementImpl.h:
• ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFEOffsetElementImpl.h:
• ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFETileElementImpl.h:
• ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect): now returns subclass
• ksvg2/svg/SVGFETurbulenceElementImpl.h:
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
• ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::attach): simplified
• kwq/KWQPainter.h:
• kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): removed cached quartz context (QPainterPrivate::~QPainterPrivate): removed cached quartz context (QPainter::createRenderingDeviceContext): changed method name

7:27 AM Changeset in webkit [11282] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebView.h: Fixed incorrect comment in public header.

4:25 AM Changeset in webkit [11281] by eseidel

• 3 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

No additional tests needed, this fixes bbox printing for all tests.

• kcanvas/device/quartz/KCanvasFilterQuartz.h: removed space
• khtml/rendering/render_object.h: (khtml::RenderObject::bbox): added const (unbreaking bbox() calls)

4:03 AM Changeset in webkit [11280] by eseidel

• 34 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

No additional test cases needed, this fixes 10+ existing tests.

Moved filter code off of createRenderer format, fixing filters.
Hacked in support for <image> and <feImage> (Pixmap only)
Simplified FEComponentTransfer function construction.

• kcanvas/KCanvasFilters.cpp:
• kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::pixmap): added (KCanvasFEImage::setPixmap): added
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter): added
• kcanvas/device/quartz/KCanvasResourcesQuartz.h:
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw): added
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::transferFunction):
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
• ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
• ksvg2/svg/SVGFEBlendElementImpl.h:
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
• ksvg2/svg/SVGFEColorMatrixElementImpl.h:
• ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
• ksvg2/svg/SVGFEComponentTransferElementImpl.h:
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
• ksvg2/svg/SVGFECompositeElementImpl.h:
• ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
• ksvg2/svg/SVGFEFloodElementImpl.h:
• ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
• ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
• ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
• ksvg2/svg/SVGFEMergeElementImpl.h:
• ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
• ksvg2/svg/SVGFEOffsetElementImpl.h:
• ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
• ksvg2/svg/SVGFETileElementImpl.h:
• ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
• ksvg2/svg/SVGFETurbulenceElementImpl.h:
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::x): (SVGFilterElementImpl::y): (SVGFilterElementImpl::width): (SVGFilterElementImpl::height): (SVGFilterElementImpl::canvasResource):
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
• ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished): (SVGImageElementImpl::finalizeStyle):
• ksvg2/svg/SVGStyledElementImpl.h:
• ksvg2/svg/SVGURIReferenceImpl.cpp: (SVGURIReferenceImpl::parseMappedAttribute):

2:03 AM Changeset in webkit [11279] by eseidel

• 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: SVG build fix only, no review.

I used debug-only method DOMString::ascii(), broke Deployment.

• kcanvas/KCanvasResources.cpp: (getResourceById):

Nov 21, 2005:

6:22 PM Changeset in webkit [11278] by eseidel

• 4 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review required, svg target only.

Fixed (hacked?) gradient stop style inheritance since style is not
currently resolved for nodes which do not create renderers,
breaking style resolution across resource-creating nodes
such as gradients, patterns, use, filters, etc.
Also fixed SVG CSS values to be case-insensitive.

• WebCore.xcodeproj/project.pbxproj: case insensitivity
• ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource): alternative style call
• ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops): manual style resolution

4:09 PM Changeset in webkit [11277] by eseidel

• 18 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review required, svg target only.

No additional test cases needed, this fixes 30 or so existing tests

Standardized all isFoo() methods to use const, which actually
fixes svg_dynmaic_cast
Fixed crasher in SVGGradientElementImpl (missing 0 init)
Broke up SVGPatternElementImpl::notifyAttributeChange

• kcanvas/KCanvasFilters.cpp: (KCanvasFilter::addFilterEffect): now asserts !0
• kcanvas/KCanvasFilters.h: (KCanvasFilter::isFilter): added (KCanvasFEImage::image): now RenderObject * (KCanvasFEImage::setImage): now RenderObject *
• kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): now uses paint() (getResourceById): added debug loggging
• kcanvas/KCanvasResources.h: (KCanvasResource::isPaintServer): const (KCanvasResource::isFilter): const (KCanvasResource::isClipper): const (KCanvasResource::isMarker): const (KCanvasClipper::isClipper): added (KCanvasMarker::isMarker): added
• kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::isPaintServer): added
• ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): removed extra doc check
• ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isSVGElement): const (KSVG::SVGElementImpl::isFilterEffect): const (KSVG::SVGElementImpl::isGradientStop): const (KSVG::SVGElementImpl::isValid): const (KSVG::SVGElementImpl::isClosed): const
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): load image (SVGFEImageElementImpl::notifyFinished): moved logic (SVGFEImageElementImpl::filterEffect): lazy create
• ksvg2/svg/SVGFEImageElementImpl.h:
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource): added
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h: (KSVG::SVGFilterPrimitiveStandardAttributesImpl::isFilterEffect):
• ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::SVGGradientElementImpl): init to 0
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::fillAttributesFromReferencePattern): (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::notifyClientsToRepaint): (SVGPatternElementImpl::notifyAttributeChange): split into pieces
• ksvg2/svg/SVGPatternElementImpl.h:
• ksvg2/svg/SVGStopElementImpl.h: (KSVG::SVGStopElementImpl::isGradientStop): const
• ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid): const
• ksvg2/svg/SVGTestsImpl.h:

3:59 AM Changeset in webkit [11276] by eseidel

• 7 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review required, SVG target only.

Fix SVG from having duplicate entries (with khtml) in its
cssproperties.in and cssvalues.in files. I've added an explicit
check in the build phase for duplicates to prevent this in the
future. Minor code adjustments were necessary to use these
the khtml value & property ids.

No additional test cases needed, this change fixes:
W3C-SVG-1.1/painting-stroke-02-t
W3C-SVG-1.1/painting-stroke-03-t

• WebCore.xcodeproj/project.pbxproj: duplicate id check
• ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue):
• ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
• ksvg2/css/cssproperties.in: commented out duplicates
• ksvg2/css/cssvalues.in: commented out duplicates
• ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::parseMappedAttribute):

1:39 AM Changeset in webkit [11275] by eseidel

• 2 edits in trunk/JavaScriptCore

Bug #: 5788
Submitted by: eseidel
Reviewed by: Rubber-stamped by hyatt.

Removed JavaScriptCore+SVG target.

• JavaScriptCore.xcodeproj/project.pbxproj:

1:36 AM Changeset in webkit [11274] by eseidel

• 6 edits in trunk/WebKitTools

Bug #: 5788
Submitted by: eseidel
Reviewed by: hyatt

Some simple fixes to the build/test scripts now that SVG uses the
WebCore DOM. JSC+SVG is no longer needed, nor is RTTI support
or symlinks for KDOM.

• Scripts/build-webkit: No longer builds JavaScriptCore+SVG
• Scripts/prepare-ChangeLog: handles missing LayoutTests directory
• Scripts/run-webkit-tests: now runs SVG tests using DRT
• Scripts/webkitdirs.pm: use SVG symbols instead of RTTI
• checkout: no longer symlink kdom

12:29 AM Changeset in webkit [11273] by eseidel

• 210 edits
  29 adds
  33 deletes in trunk

Bug #: 3249
Submitted by: eseidel
Reviewed by: Only affects SVG; no review required (or possible due to size).

The KSVG/KCanvas section of the big DOM merger.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3249
At least the following were addressed in this patch:

• Namespace mapping (KDOM -> DOM, khtml)
• Forwarding Headers (temp. all kdom .h map to all webcore .h)
• Various KDOM stub classes added to WebCore+SVG folder
• Various DOMStringImpl -> DOMString changes
• DOMString::string() -> DOMString::qstring() in ksvg2
• DOMString::handle() -> DOMString::impl() in ksvg2
• DocumentImpl, DocumentType ::impl() -> ::implentation() in khtml
• Moved NodeImpl::Id to QualifiedString/AtomicString in ksvg2
• SVGNames.*, SVGElementFactory.* (and generating perl script)
• EventImpl::id() -> type() with AtomicString
• Removal of SVGEventImpl
• Adding svg document and event creation in xml_docimpl.h
• All in SVGDocumentImpl, also now using SharedPtr
• Mapped KSVGPart, KDOMPart, KSVGView, KDOMView to KHTML*
• Removed all throw calls, replacing with exceptioncode parameters
• SVGElement now derives from StyledElementImpl
• Corrected SVGNames cases (viewBoxAttr vs. viewboxAttr)
• Moved TimeScheduler from Doc -> SVGSVGElement (temp. & wrong)
• Moved off of DocPtr onto DocumentImpl * directly in ksvg2
• Made SVGRenderStyle a member of khtml::RenderStyle
• Worked KSVGCSSParser into CSSParser
• Worked SVGCSSStyleSelector into CSSStyleSelector
• Changed parseAttribute -> parseMappedAttribute
• Moved KCanvasContainer onto RenderContainer
• Renamed KCanvasItem, RenderPath, now subclass of RenderObject
• Added RenderObject: bbox(), isRenderPath(), isKCanvasContainer()
• Moved KCanvasContainer and RenderPath from draw() -> paint()
• Removed RenderSVGBox && render_kcanvaswrapper hacks
• Gutted KCanvasItem (now RenderPath) and KCanvasContainer
• Merged KCanvasTreeDebug into KWQRenderTreeDebug
• Made SVGNames.* SVGElementFactory.* generation a build phase
• Removed KRenderingStyle
• Gutted KCanvasRenderingStyle
• Moved objectTransform onto RenderObject as "localTransform"
• Removed KCanvasRegistry
• Changed the way Graidents build their stop lists
• Removed all dynamic_cast, turned off RTTI and Exceptions
• Picked up recent marker fix & relative transform fixes from KDE

• ForwardingHeaders/kcanvas/KCanvas.h: Added.
• ForwardingHeaders/kcanvas/RenderPath.h: Added.
• ForwardingHeaders/kdom/core/AttrImpl.h: Added.
• ForwardingHeaders/kdom/core/CDFInterface.h: Added.
• ForwardingHeaders/kdom/core/DOMConfigurationImpl.h: Added.
• ForwardingHeaders/kdom/core/DOMExceptionImpl.h: Added.
• ForwardingHeaders/kdom/core/DOMImplementationImpl.h: Added.
• ForwardingHeaders/kdom/core/DOMList.h: Added.
• ForwardingHeaders/kdom/core/DOMStringImpl.h: Added.
• ForwardingHeaders/kdom/core/DocumentImpl.h: Added.
• ForwardingHeaders/kdom/core/DocumentTypeImpl.h: Added.
• ForwardingHeaders/kdom/core/ElementImpl.h: Added.
• ForwardingHeaders/kdom/core/NamedAttrMapImpl.h: Added.
• ForwardingHeaders/kdom/core/NodeImpl.h: Added.
• ForwardingHeaders/kdom/core/NodeListImpl.h: Added.
• ForwardingHeaders/kdom/core/ProcessingInstructionImpl.h: Added.
• ForwardingHeaders/kdom/core/XMLElementImpl.h: Added.
• ForwardingHeaders/kdom/core/domattrs.h: Added.
• WebCore+SVG/DrawCanvasItem.mm: (-[DrawCanvasItem dragAnchorPointForControlPointIndex:]): (-[DrawCanvasItem controlPoints]): (-[DrawCanvasItem fitToNewBBox:]): (-[DrawCanvasItem valueForKey:]): (-[DrawCanvasItem attributedXMLString]):
• WebCore+SVG/DrawDocument.mm: (-[DrawView initWithSVGData:]): (-[DrawView svgText]): (-[DrawDocument documentListensForMouseMovedEvents]): (-[DrawDocument documentListensForMouseDownEvents]): (-[DrawDocument documentListensForMouseUpEvents]): (-[DrawDocument KDOM::newMouseEventWithEventId:KDOM::qMouseEvent:]): (cursorForStyle): (-[DrawDocument cursorAfterPropagatingMouseMovedEvent:fromView:]): (-[DrawDocument removeItemFromDOM:]): (-[DrawDocument createItemForTool:atPoint:]):
• WebCore+SVG/KDOMHeaders.h:
• WebCore+SVG/KDOMSettings.cpp:
• WebCore+SVG/SVGElementFactoryWrapper.cpp: Added.
• WebCore+SVG/SVGNames.cpp: Removed.
• WebCore+SVG/SVGNames.h: Removed.
• WebCore+SVG/SVGNamesWrapper.cpp: Added.
• WebCore+SVG/dom_kdomdocumentwrapper.cpp: Removed.
• WebCore+SVG/dom_kdomdocumentwrapper.h: Removed.
• WebCore+SVG/dom_kdomnodetreewrapper.cpp: Removed.
• WebCore+SVG/dom_kdomnodetreewrapper.h: Removed.
• WebCore+SVG/render_kcanvaswrapper.cpp: Removed.
• WebCore+SVG/render_kcanvaswrapper.h: Removed.
• WebCore+SVG/xml_kdomtokenizer.cpp: Removed.
• WebCore.xcodeproj/project.pbxproj:
• kcanvas/KCanvas.cpp: Removed.
• kcanvas/KCanvas.h: Removed.
• kcanvas/KCanvasContainer.cpp: (KCanvasContainer::Private::Private): (KCanvasContainer::KCanvasContainer): (KCanvasContainer::~KCanvasContainer): (KCanvasContainer::localTransform): (KCanvasContainer::setLocalTransform): (KCanvasContainer::fillContains): (KCanvasContainer::strokeContains): (KCanvasContainer::bbox): (KCanvasContainer::setSlice): (KCanvasContainer::slice): (KCanvasContainer::getAspectRatio):
• kcanvas/KCanvasContainer.h: (KCanvasContainer::isKCanvasContainer): (KCanvasContainer::renderName):
• kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createCanvasPathData):
• kcanvas/KCanvasCreator.h:
• kcanvas/KCanvasFilters.cpp: (getFilterById):
• kcanvas/KCanvasFilters.h: (KCanvasFEImage::image): (KCanvasFEImage::setImage):
• kcanvas/KCanvasItem.cpp: (RenderPath::Private::Private): (RenderPath::Private::~Private): (RenderPath::RenderPath): (RenderPath::~RenderPath): (RenderPath::setStyle): (RenderPath::localTransform): (RenderPath::setLocalTransform): (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::bbox): (RenderPath::hitsPath): (RenderPath::bboxPath): (RenderPath::setupForDraw): (RenderPath::changePath): (RenderPath::path): (RenderPath::canvasStyle): (RenderPath::commonArgs):
• kcanvas/KCanvasItem.h: (RenderPath::isRenderPath): (RenderPath::renderName):
• kcanvas/KCanvasResources.cpp: (KCanvasResource::addClient): (KCanvasResource::invalidate): (KCanvasMarker::KCanvasMarker): (KCanvasMarker::setMarker): (KCanvasMarker::setUseStrokeWidth): (KCanvasMarker::useStrokeWidth): (KCanvasMarker::setScaleX): (KCanvasMarker::scaleX): (KCanvasMarker::setScaleY): (KCanvasMarker::scaleY): (KCanvasMarker::draw): (getResourceById): (getMarkerById): (getClipperById): (getPaintServerById):
• kcanvas/KCanvasResources.h: (KCanvasResource::isPaintServer): (KCanvasResource::isFilter): (KCanvasResource::isClipper): (KCanvasResource::isMarker):
• kcanvas/KCanvasTreeDebug.cpp: (operator<<): (writeStyle): (getTagName): (write):
• kcanvas/KCanvasTreeDebug.h:
• kcanvas/KCanvasTypes.h:
• kcanvas/KCanvasView.cpp: Removed.
• kcanvas/KCanvasView.h: Removed.
• kcanvas/KCanvasView.moc: Removed.
• kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::KCanvasCommonArgs): (KCanvasCommonArgs::canvasStyle): (KCanvasCommonArgs::setStyle):
• kcanvas/device/KRenderingDevice.h:
• kcanvas/device/KRenderingDeviceFactory.cpp: Removed.
• kcanvas/device/KRenderingDeviceFactory.h: Removed.
• kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::activeClient): (KRenderingPaintServer::setActiveClient):
• kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerGradient::externalRepresentation):
• kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::externalRepresentation):
• kcanvas/device/KRenderingStrokePainter.h:
• kcanvas/device/KRenderingStyle.cpp: Removed.
• kcanvas/device/KRenderingStyle.h: Removed.
• kcanvas/device/quartz/KCanvasFilterQuartz.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter):
• kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::requiresLayer): (KCanvasItemQuartz::layout):
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::KCanvasItemQuartz): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::paint): (KCanvasItemQuartz::nodeAtPoint): (KCanvasItemQuartz::bboxPath): (KCanvasItemQuartz::hitsPath):
• kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::KCanvasContainerQuartz): (KCanvasContainerQuartz::canHaveChildren): (KCanvasContainerQuartz::requiresLayer):
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::calcMinMaxWidth): (KCanvasContainerQuartz::layout): (KCanvasContainerQuartz::paint): (KCanvasContainerQuartz::setViewport): (KCanvasContainerQuartz::viewport): (KCanvasContainerQuartz::setViewBox): (KCanvasContainerQuartz::viewBox): (KCanvasContainerQuartz::setAlign): (KCanvasContainerQuartz::align): (KCanvasClipperQuartz::applyClip):
• kcanvas/device/quartz/KCanvasViewQuartz.h: Removed.
• kcanvas/device/quartz/KCanvasViewQuartz.mm: Removed.
• kcanvas/device/quartz/KRenderingDeviceQuartz.h:
• kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::concatCTM): (KRenderingDeviceContextQuartz::ctm): (KRenderingDeviceQuartz::stringForPath): (KRenderingDeviceQuartz::createContainer): (KRenderingDeviceQuartz::createItem):
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw):
• kcanvas/device/quartz/QuartzSupport.h:
• kcanvas/device/quartz/QuartzSupport.mm: (CFStringFromCGAffineTransform): (CGAffineTransformMakeMapBetweenRects): (CGPathTransformCallback): (CGPathApplyTransform): (applyStrokeStyleToContext): (CGPathToCFStringApplierFunction): (CFStringFromCGPath):
• kdom/bindings/DocParser.pm: Removed.
• kdom/bindings/IDLCodeGenerator.pm: Removed.
• kdom/bindings/IDLCodeGeneratorCpp.pm: Removed.
• kdom/bindings/IDLCodeGeneratorEcmaInterface.pm: Removed.
• kdom/bindings/IDLCodeGeneratorJs.pm: Removed.
• kdom/bindings/IDLParser.pm: Removed.
• kdom/bindings/IDLStructure.pm: Removed.
• kdom/bindings/idl/core/Attr.idl: Removed.
• kdom/bindings/idl/core/CDATASection.idl: Removed.
• kdom/bindings/idl/core/CharacterData.idl: Removed.
• kdom/bindings/idl/core/Comment.idl: Removed.
• kdom/bindings/idl/core/DOMConfiguration.idl: Removed.
• kdom/bindings/idl/core/DOMError.idl: Removed.
• kdom/bindings/idl/core/DOMErrorHandler.idl: Removed.
• kdom/bindings/idl/core/DOMException.idl: Removed.
• kdom/bindings/idl/core/DOMImplementation.idl: Removed.
• kdom/bindings/idl/core/DOMLocator.idl: Removed.
• kdom/bindings/idl/core/DOMObject.idl: Removed.
• kdom/bindings/idl/core/DOMStringList.idl: Removed.
• kdom/bindings/idl/core/DOMUserData.idl: Removed.
• kdom/bindings/idl/core/Document.idl: Removed.
• kdom/bindings/idl/core/DocumentFragment.idl: Removed.
• kdom/bindings/idl/core/DocumentType.idl: Removed.
• kdom/bindings/idl/core/Element.idl: Removed.
• kdom/bindings/idl/core/Entity.idl: Removed.
• kdom/bindings/idl/core/EntityReference.idl: Removed.
• kdom/bindings/idl/core/NamedNodeMap.idl: Removed.
• kdom/bindings/idl/core/Node.idl: Removed.
• kdom/bindings/idl/core/NodeList.idl: Removed.
• kdom/bindings/idl/core/Notation.idl: Removed.
• kdom/bindings/idl/core/ProcessingInstruction.idl: Removed.
• kdom/bindings/idl/core/Text.idl: Removed.
• kdom/bindings/idl/core/TypeInfo.idl: Removed.
• kdom/bindings/idl/core/kdomdefs.idl: Removed.
• kdom/bindings/idl/css/CSS2Properties.idl: Removed.
• kdom/bindings/idl/css/CSSCharsetRule.idl: Removed.
• kdom/bindings/idl/css/CSSFontFaceRule.idl: Removed.
• kdom/bindings/idl/css/CSSImportRule.idl: Removed.
• kdom/bindings/idl/css/CSSMediaRule.idl: Removed.
• kdom/bindings/idl/css/CSSPageRule.idl: Removed.
• kdom/bindings/idl/css/CSSPrimitiveValue.idl: Removed.
• kdom/bindings/idl/css/CSSRule.idl: Removed.
• kdom/bindings/idl/css/CSSRuleList.idl: Removed.
• kdom/bindings/idl/css/CSSStyleDeclaration.idl: Removed.
• kdom/bindings/idl/css/CSSStyleRule.idl: Removed.
• kdom/bindings/idl/css/CSSStyleSheet.idl: Removed.
• kdom/bindings/idl/css/CSSUnknownRule.idl: Removed.
• kdom/bindings/idl/css/CSSValue.idl: Removed.
• kdom/bindings/idl/css/CSSValueList.idl: Removed.
• kdom/bindings/idl/css/Counter.idl: Removed.
• kdom/bindings/idl/css/DocumentCSS.idl: Removed.
• kdom/bindings/idl/css/ElementCSSInlineStyle.idl: Removed.
• kdom/bindings/idl/css/RGBColor.idl: Removed.
• kdom/bindings/idl/css/Rect.idl: Removed.
• kdom/bindings/idl/css/kdomdefs.idl: Removed.
• kdom/bindings/idl/events/DocumentEvent.idl: Removed.
• kdom/bindings/idl/events/Event.idl: Removed.
• kdom/bindings/idl/events/EventException.idl: Removed.
• kdom/bindings/idl/events/EventListener.idl: Removed.
• kdom/bindings/idl/events/EventTarget.idl: Removed.
• kdom/bindings/idl/events/MouseEvent.idl: Removed.
• kdom/bindings/idl/events/MutationEvent.idl: Removed.
• kdom/bindings/idl/events/UIEvent.idl: Removed.
• kdom/bindings/idl/events/kdomdefs.idl: Removed.
• kdom/bindings/idl/ls/DOMImplementationLS.idl: Removed.
• kdom/bindings/idl/ls/LSException.idl: Removed.
• kdom/bindings/idl/ls/LSInput.idl: Removed.
• kdom/bindings/idl/ls/LSOutput.idl: Removed.
• kdom/bindings/idl/ls/LSParser.idl: Removed.
• kdom/bindings/idl/ls/LSParserFilter.idl: Removed.
• kdom/bindings/idl/ls/LSResourceResolver.idl: Removed.
• kdom/bindings/idl/ls/LSSerializer.idl: Removed.
• kdom/bindings/idl/ls/LSSerializerFilter.idl: Removed.
• kdom/bindings/idl/ls/kdomdefs.idl: Removed.
• kdom/bindings/idl/range/DocumentRange.idl: Removed.
• kdom/bindings/idl/range/Range.idl: Removed.
• kdom/bindings/idl/range/RangeException.idl: Removed.
• kdom/bindings/idl/range/kdomdefs.idl: Removed.
• kdom/bindings/idl/stylesheets/DocumentStyle.idl: Removed.
• kdom/bindings/idl/stylesheets/LinkStyle.idl: Removed.
• kdom/bindings/idl/stylesheets/MediaList.idl: Removed.
• kdom/bindings/idl/stylesheets/StyleSheet.idl: Removed.
• kdom/bindings/idl/stylesheets/StyleSheetList.idl: Removed.
• kdom/bindings/idl/stylesheets/kdomdefs.idl: Removed.
• kdom/bindings/idl/traversal/DocumentTraversal.idl: Removed.
• kdom/bindings/idl/traversal/NodeFilter.idl: Removed.
• kdom/bindings/idl/traversal/NodeIterator.idl: Removed.
• kdom/bindings/idl/traversal/TreeWalker.idl: Removed.
• kdom/bindings/idl/traversal/kdomdefs.idl: Removed.
• kdom/bindings/idl/views/AbstractView.idl: Removed.
• kdom/bindings/idl/views/DocumentView.idl: Removed.
• kdom/bindings/idl/views/kdomdefs.idl: Removed.
• kdom/bindings/idl/xpath/XPathEvaluator.idl: Removed.
• kdom/bindings/idl/xpath/XPathException.idl: Removed.
• kdom/bindings/idl/xpath/XPathExpression.idl: Removed.
• kdom/bindings/idl/xpath/XPathNSResolver.idl: Removed.
• kdom/bindings/idl/xpath/XPathNamespace.idl: Removed.
• kdom/bindings/idl/xpath/XPathResult.idl: Removed.
• kdom/bindings/idl/xpath/kdomdefs.idl: Removed.
• kdom/bindings/idl/xpointer/XPointerEvaluator.idl: Removed.
• kdom/bindings/idl/xpointer/XPointerException.idl: Removed.
• kdom/bindings/idl/xpointer/XPointerExpression.idl: Removed.
• kdom/bindings/idl/xpointer/XPointerResult.idl: Removed.
• kdom/bindings/idl/xpointer/kdomdefs.idl: Removed.
• kdom/bindings/kdombinder.sh: Removed.
• kdom/bindings/kdomidl.pl: Removed.
• kdom/ls/DOMImplementationLSImpl.cpp: Removed.
• kdom/ls/DOMImplementationLSImpl.h: Removed.
• kdom/ls/LSExceptionImpl.cpp: Removed.
• kdom/ls/LSExceptionImpl.h: Removed.
• kdom/ls/LSInputImpl.cpp: Removed.
• kdom/ls/LSInputImpl.h: Removed.
• kdom/ls/LSOutputImpl.cpp: Removed.
• kdom/ls/LSOutputImpl.h: Removed.
• kdom/ls/LSParserFilterImpl.cpp: Removed.
• kdom/ls/LSParserFilterImpl.h: Removed.
• kdom/ls/LSParserImpl.cpp: Removed.
• kdom/ls/LSParserImpl.h: Removed.
• kdom/ls/LSResourceResolverImpl.cpp: Removed.
• kdom/ls/LSResourceResolverImpl.h: Removed.
• kdom/ls/LSSerializerFilterImpl.cpp: Removed.
• kdom/ls/LSSerializerFilterImpl.h: Removed.
• kdom/ls/LSSerializerImpl.cpp: Removed.
• kdom/ls/LSSerializerImpl.h: Removed.
• kdom/ls/kdomls.h: Removed.
• kdom/scripts/cssmakeprops: Removed.
• kdom/scripts/cssmakevalues: Removed.
• ksvg2/KSVGFactory.cpp: Removed.
• ksvg2/KSVGFactory.h: Removed.
• ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue): (DOM::CSSParser::parseSVGStrokeDasharray): (DOM::CSSParser::parseSVGPaint): (DOM::CSSParser::parseSVGColor):
• ksvg2/css/SVGCSSStyleDeclarationImpl.cpp: Removed.
• ksvg2/css/SVGCSSStyleDeclarationImpl.h: Removed.
• ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
• ksvg2/css/SVGCSSStyleSheetImpl.cpp: Removed.
• ksvg2/css/SVGCSSStyleSheetImpl.h: Removed.
• ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): (SVGRenderStyle::equals): (SVGRenderStyle::inheritFrom):
• ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::SVGRenderStyle):
• ksvg2/css/SVGRenderStyleDefs.cpp: (StyleMiscData::StyleMiscData): (StyleMiscData::operator==):
• ksvg2/css/SVGRenderStyleDefs.h:
• ksvg2/ecma/Ecma.cpp: (Ecma::inheritedGetDOMNode):
• ksvg2/ecma/GlobalObject.cpp:
• ksvg2/events/SVGZoomEventImpl.cpp: (SVGZoomEventImpl::SVGZoomEventImpl):
• ksvg2/events/SVGZoomEventImpl.h:
• ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::updateFill): (KCanvasRenderingStyle::updateStroke): (KCanvasRenderingStyle::updateStyle): (KCanvasRenderingStyle::cssPrimitiveToLength):
• ksvg2/misc/KCanvasRenderingStyle.h: (KSVG::KCanvasRenderingStyle::renderStyle):
• ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll): (KSVG::TimeScheduler::TimeScheduler):
• ksvg2/misc/KSVGTimeScheduler.h: (KSVG::TimeScheduler::document):
• ksvg2/scripts/cssmakeprops: Added.
• ksvg2/scripts/cssmakevalues: Added.
• ksvg2/scripts/make_names.pl: Added.
• ksvg2/svg/CDFInterface.cpp: Removed.
• ksvg2/svg/CDFInterface.h: Removed.
• ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::SVGAElementImpl): (SVGAElementImpl::parseMappedAttribute): (SVGAElementImpl::createRenderer): (SVGAElementImpl::defaultEventHandler):
• ksvg2/svg/SVGAElementImpl.h: (KSVG::SVGAElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::setValueAsString): (SVGAngleImpl::valueAsString):
• ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::SVGAnimateColorElementImpl): (SVGAnimateColorElementImpl::handleTimerEvent):
• ksvg2/svg/SVGAnimateColorElementImpl.h:
• ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::SVGAnimateElementImpl): (SVGAnimateElementImpl::handleTimerEvent):
• ksvg2/svg/SVGAnimateElementImpl.h:
• ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::SVGAnimateTransformElementImpl): (SVGAnimateTransformElementImpl::~SVGAnimateTransformElementImpl): (SVGAnimateTransformElementImpl::parseMappedAttribute): (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::initialMatrix): (SVGAnimateTransformElementImpl::transformMatrix):
• ksvg2/svg/SVGAnimateTransformElementImpl.h:
• ksvg2/svg/SVGAnimatedLengthListImpl.cpp:
• ksvg2/svg/SVGAnimatedLengthListImpl.h:
• ksvg2/svg/SVGAnimatedNumberListImpl.cpp:
• ksvg2/svg/SVGAnimatedNumberListImpl.h:
• ksvg2/svg/SVGAnimatedStringImpl.cpp: (SVGAnimatedStringImpl::create):
• ksvg2/svg/SVGAnimatedStringImpl.h:
• ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::setBaseVal): (KSVG::SVGAnimatedTemplate::setAnimVal):
• ksvg2/svg/SVGAnimatedTransformListImpl.cpp:
• ksvg2/svg/SVGAnimatedTransformListImpl.h:
• ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::SVGAnimationElementImpl): (SVGAnimationElementImpl::targetElement): (SVGAnimationElementImpl::parseMappedAttribute): (SVGAnimationElementImpl::closeRenderer): (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
• ksvg2/svg/SVGAnimationElementImpl.h: (KSVG::SVGAnimationElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGCircleElementImpl.cpp: (SVGCircleElementImpl::SVGCircleElementImpl): (SVGCircleElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGCircleElementImpl.h: (KSVG::SVGCircleElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::SVGClipPathElementImpl): (SVGClipPathElementImpl::parseMappedAttribute): (SVGClipPathElementImpl::canvasResource):
• ksvg2/svg/SVGClipPathElementImpl.h:
• ksvg2/svg/SVGColorImpl.cpp: (SVGColorImpl::rgbColor): (SVGColorImpl::setRGBColor): (SVGColorImpl::cssText):
• ksvg2/svg/SVGColorImpl.h:
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::SVGComponentTransferFunctionElementImpl): (SVGComponentTransferFunctionElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
• ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::SVGCursorElementImpl): (SVGCursorElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGCursorElementImpl.h:
• ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::~SVGDOMImplementationImpl): (SVGDOMImplementationImpl::hasFeature): (SVGDOMImplementationImpl::createDocumentType): (SVGDOMImplementationImpl::createDocument): (SVGDOMImplementationImpl::createCSSStyleSheet):
• ksvg2/svg/SVGDOMImplementationImpl.h:
• ksvg2/svg/SVGDefsElementImpl.cpp: (SVGDefsElementImpl::SVGDefsElementImpl):
• ksvg2/svg/SVGDefsElementImpl.h:
• ksvg2/svg/SVGDescElementImpl.cpp: (SVGDescElementImpl::SVGDescElementImpl): (SVGDescElementImpl::description):
• ksvg2/svg/SVGDescElementImpl.h:
• ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl): (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::title): (SVGDocumentImpl::createElement): (SVGDocumentImpl::rootElement): (SVGDocumentImpl::notifyFinished): (SVGDocumentImpl::dispatchRecursiveEvent): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::createStyleSelector): (SVGDocumentImpl::addScripts): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
• ksvg2/svg/SVGDocumentImpl.h:
• ksvg2/svg/SVGElementFactory.cpp: Removed.
• ksvg2/svg/SVGElementFactory.h: Removed.
• ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::SVGElementImpl): (SVGElementImpl::isSupported): (SVGElementImpl::ownerSVGElement): (SVGElementImpl::viewportElement): (SVGElementImpl::tryGetAttribute): (SVGElementImpl::tryGetAttributeNS): (SVGElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isSVGElement): (KSVG::SVGElementImpl::adjustViewportClipping): (KSVG::SVGElementImpl::isStyledTransformable): (KSVG::SVGElementImpl::isStyledLocatable): (KSVG::SVGElementImpl::isFilterEffect): (KSVG::SVGElementImpl::isGradientStop): (KSVG::SVGElementImpl::isValid): (KSVG::SVGElementImpl::closeRenderer): (KSVG::SVGElementImpl::rendererIsNeeded): (KSVG::SVGElementImpl::isClosed):
• ksvg2/svg/SVGEllipseElementImpl.cpp: (KSVG::SVGEllipseElementImpl::SVGEllipseElementImpl): (KSVG::SVGEllipseElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGEllipseElementImpl.h: (KSVG::SVGEllipseElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp: (SVGExternalResourcesRequiredImpl::parseMappedAttribute):
• ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
• ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::SVGFEBlendElementImpl): (SVGFEBlendElementImpl::parseMappedAttribute): (SVGFEBlendElementImpl::createRenderer):
• ksvg2/svg/SVGFEBlendElementImpl.h: (KSVG::SVGFEBlendElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::SVGFEColorMatrixElementImpl): (SVGFEColorMatrixElementImpl::parseMappedAttribute): (SVGFEColorMatrixElementImpl::createRenderer):
• ksvg2/svg/SVGFEColorMatrixElementImpl.h: (KSVG::SVGFEColorMatrixElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::SVGFEComponentTransferElementImpl): (SVGFEComponentTransferElementImpl::parseMappedAttribute): (SVGFEComponentTransferElementImpl::createRenderer): (SVGFEComponentTransferElementImpl::closeRenderer):
• ksvg2/svg/SVGFEComponentTransferElementImpl.h: (KSVG::SVGFEComponentTransferElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::SVGFECompositeElementImpl): (SVGFECompositeElementImpl::parseMappedAttribute): (SVGFECompositeElementImpl::createRenderer):
• ksvg2/svg/SVGFECompositeElementImpl.h: (KSVG::SVGFECompositeElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::SVGFEFloodElementImpl): (SVGFEFloodElementImpl::parseMappedAttribute): (SVGFEFloodElementImpl::createRenderer):
• ksvg2/svg/SVGFEFloodElementImpl.h: (KSVG::SVGFEFloodElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEFuncAElementImpl.cpp: (SVGFEFuncAElementImpl::SVGFEFuncAElementImpl):
• ksvg2/svg/SVGFEFuncAElementImpl.h:
• ksvg2/svg/SVGFEFuncBElementImpl.cpp: (SVGFEFuncBElementImpl::SVGFEFuncBElementImpl):
• ksvg2/svg/SVGFEFuncBElementImpl.h:
• ksvg2/svg/SVGFEFuncGElementImpl.cpp: (SVGFEFuncGElementImpl::SVGFEFuncGElementImpl):
• ksvg2/svg/SVGFEFuncGElementImpl.h:
• ksvg2/svg/SVGFEFuncRElementImpl.cpp: (SVGFEFuncRElementImpl::SVGFEFuncRElementImpl):
• ksvg2/svg/SVGFEFuncRElementImpl.h:
• ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::SVGFEGaussianBlurElementImpl): (SVGFEGaussianBlurElementImpl::parseMappedAttribute): (SVGFEGaussianBlurElementImpl::createRenderer):
• ksvg2/svg/SVGFEGaussianBlurElementImpl.h: (KSVG::SVGFEGaussianBlurElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): (SVGFEImageElementImpl::finalizeStyle): (SVGFEImageElementImpl::createRenderer):
• ksvg2/svg/SVGFEImageElementImpl.h: (KSVG::SVGFEImageElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::SVGFEMergeElementImpl): (SVGFEMergeElementImpl::createRenderer): (SVGFEMergeElementImpl::closeRenderer):
• ksvg2/svg/SVGFEMergeElementImpl.h: (KSVG::SVGFEMergeElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFEMergeNodeElementImpl.cpp: (SVGFEMergeNodeElementImpl::SVGFEMergeNodeElementImpl): (SVGFEMergeNodeElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGFEMergeNodeElementImpl.h:
• ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::SVGFEOffsetElementImpl): (SVGFEOffsetElementImpl::parseMappedAttribute): (SVGFEOffsetElementImpl::createRenderer):
• ksvg2/svg/SVGFEOffsetElementImpl.h: (KSVG::SVGFEOffsetElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::SVGFETileElementImpl): (SVGFETileElementImpl::parseMappedAttribute): (SVGFETileElementImpl::createRenderer):
• ksvg2/svg/SVGFETileElementImpl.h: (KSVG::SVGFETileElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::SVGFETurbulenceElementImpl): (SVGFETurbulenceElementImpl::parseMappedAttribute): (SVGFETurbulenceElementImpl::createRenderer):
• ksvg2/svg/SVGFETurbulenceElementImpl.h: (KSVG::SVGFETurbulenceElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::SVGFilterElementImpl): (SVGFilterElementImpl::x): (SVGFilterElementImpl::y): (SVGFilterElementImpl::width): (SVGFilterElementImpl::height): (SVGFilterElementImpl::parseMappedAttribute): (SVGFilterElementImpl::canvasResource):
• ksvg2/svg/SVGFilterElementImpl.h:
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::SVGFilterPrimitiveStandardAttributesImpl): (SVGFilterPrimitiveStandardAttributesImpl::width): (SVGFilterPrimitiveStandardAttributesImpl::height): (SVGFilterPrimitiveStandardAttributesImpl::parseMappedAttribute): (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
• ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h: (KSVG::SVGFilterPrimitiveStandardAttributesImpl::isFilterEffect):
• ksvg2/svg/SVGFitToViewBoxImpl.cpp: (SVGFitToViewBoxImpl::SVGFitToViewBoxImpl): (SVGFitToViewBoxImpl::~SVGFitToViewBoxImpl): (SVGFitToViewBoxImpl::viewBox): (SVGFitToViewBoxImpl::preserveAspectRatio): (SVGFitToViewBoxImpl::parseViewBox): (SVGFitToViewBoxImpl::parseMappedAttribute):
• ksvg2/svg/SVGFitToViewBoxImpl.h:
• ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::SVGGElementImpl): (SVGGElementImpl::parseMappedAttribute): (SVGGElementImpl::setChanged): (SVGGElementImpl::createRenderer): (SVGDummyElementImpl::SVGDummyElementImpl): (SVGDummyElementImpl::localName):
• ksvg2/svg/SVGGElementImpl.h: (KSVG::SVGGElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::SVGGradientElementImpl): (SVGGradientElementImpl::parseMappedAttribute): (SVGGradientElementImpl::notifyAttributeChange): (SVGGradientElementImpl::canvasResource): (SVGGradientElementImpl::resourceNotification): (SVGGradientElementImpl::rebuildStops):
• ksvg2/svg/SVGGradientElementImpl.h:
• ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
• ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::SVGImageElementImpl): (SVGImageElementImpl::parseMappedAttribute): (SVGImageElementImpl::createRenderer): (SVGImageElementImpl::notifyFinished): (SVGImageElementImpl::finalizeStyle):
• ksvg2/svg/SVGImageElementImpl.h: (KSVG::SVGImageElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGLangSpaceImpl.cpp: (SVGLangSpaceImpl::SVGLangSpaceImpl): (SVGLangSpaceImpl::~SVGLangSpaceImpl): (SVGLangSpaceImpl::xmllang): (SVGLangSpaceImpl::setXmllang): (SVGLangSpaceImpl::xmlspace): (SVGLangSpaceImpl::setXmlspace): (SVGLangSpaceImpl::parseMappedAttribute):
• ksvg2/svg/SVGLangSpaceImpl.h:
• ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value): (SVGLengthImpl::setValueAsString): (SVGLengthImpl::updateValue):
• ksvg2/svg/SVGLengthImpl.h:
• ksvg2/svg/SVGLengthListImpl.cpp: (SVGLengthListImpl::parse):
• ksvg2/svg/SVGLineElementImpl.cpp: (SVGLineElementImpl::SVGLineElementImpl): (SVGLineElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGLineElementImpl.h: (KSVG::SVGLineElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::SVGLinearGradientElementImpl): (SVGLinearGradientElementImpl::parseMappedAttribute): (SVGLinearGradientElementImpl::buildGradient):
• ksvg2/svg/SVGLinearGradientElementImpl.h: (KSVG::SVGLinearGradientElementImpl::gradientType):
• ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement): (SVGLocatableImpl::getBBox): (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
• ksvg2/svg/SVGLocatableImpl.h:
• ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::SVGMarkerElementImpl): (SVGMarkerElementImpl::parseMappedAttribute): (SVGMarkerElementImpl::canvasResource): (SVGMarkerElementImpl::createRenderer):
• ksvg2/svg/SVGMarkerElementImpl.h: (KSVG::SVGMarkerElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGNames.cpp: Removed.
• ksvg2/svg/SVGNames.h: Removed.
• ksvg2/svg/SVGPaintImpl.cpp: (SVGPaintImpl::setUri): (SVGPaintImpl::cssText):
• ksvg2/svg/SVGPaintImpl.h:
• ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::SVGPathElementImpl): (KSVG::SVGPathElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGPathElementImpl.h: (KSVG::SVGPathElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::SVGPatternElementImpl): (SVGPatternElementImpl::~SVGPatternElementImpl): (SVGPatternElementImpl::parseMappedAttribute): (SVGPatternElementImpl::notifyAttributeChange): (SVGPatternElementImpl::createRenderer): (SVGPatternElementImpl::canvasResource):
• ksvg2/svg/SVGPatternElementImpl.h: (KSVG::SVGPatternElementImpl::allowAttachChildren): (KSVG::SVGPatternElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPolyElementImpl.cpp: (SVGPolyElementImpl::SVGPolyElementImpl): (SVGPolyElementImpl::parseMappedAttribute): (SVGPolyElementImpl::notifyAttributeChange):
• ksvg2/svg/SVGPolyElementImpl.h: (KSVG::SVGPolyElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::SVGPolygonElementImpl):
• ksvg2/svg/SVGPolygonElementImpl.h:
• ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::SVGPolylineElementImpl):
• ksvg2/svg/SVGPolylineElementImpl.h:
• ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::parsePreserveAspectRatio):
• ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::SVGRadialGradientElementImpl): (SVGRadialGradientElementImpl::parseMappedAttribute): (SVGRadialGradientElementImpl::buildGradient):
• ksvg2/svg/SVGRadialGradientElementImpl.h: (KSVG::SVGRadialGradientElementImpl::gradientType):
• ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::SVGRectElementImpl): (SVGRectElementImpl::parseMappedAttribute): (SVGRectElementImpl::toPathData):
• ksvg2/svg/SVGRectElementImpl.h: (KSVG::SVGRectElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::SVGSVGElementImpl): (SVGSVGElementImpl::~SVGSVGElementImpl): (SVGSVGElementImpl::width): (SVGSVGElementImpl::height): (SVGSVGElementImpl::contentScriptType): (SVGSVGElementImpl::setContentScriptType): (SVGSVGElementImpl::contentStyleType): (SVGSVGElementImpl::setContentStyleType): (SVGSVGElementImpl::currentScale): (SVGSVGElementImpl::setCurrentScale): (SVGSVGElementImpl::currentTranslate): (SVGSVGElementImpl::parseMappedAttribute): (SVGSVGElementImpl::pauseAnimations): (SVGSVGElementImpl::unpauseAnimations): (SVGSVGElementImpl::animationsPaused): (SVGSVGElementImpl::getCurrentTime): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM): (SVGSVGElementImpl::createRenderer): (SVGSVGElementImpl::setZoomAndPan):
• ksvg2/svg/SVGSVGElementImpl.h: (KSVG::SVGSVGElementImpl::rendererIsNeeded): (KSVG::SVGSVGElementImpl::timeScheduler):
• ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::SVGScriptElementImpl): (SVGScriptElementImpl::parseMappedAttribute): (SVGScriptElementImpl::executeScript):
• ksvg2/svg/SVGScriptElementImpl.h:
• ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::SVGSetElementImpl): (SVGSetElementImpl::handleTimerEvent):
• ksvg2/svg/SVGSetElementImpl.h:
• ksvg2/svg/SVGStopElementImpl.cpp: (SVGStopElementImpl::SVGStopElementImpl): (SVGStopElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGStopElementImpl.h: (KSVG::SVGStopElementImpl::isGradientStop):
• ksvg2/svg/SVGStylableImpl.h:
• ksvg2/svg/SVGStyleElementImpl.cpp: (SVGStyleElementImpl::SVGStyleElementImpl): (SVGStyleElementImpl::~SVGStyleElementImpl): (SVGStyleElementImpl::xmlspace): (SVGStyleElementImpl::setXmlspace): (SVGStyleElementImpl::type): (SVGStyleElementImpl::setType): (SVGStyleElementImpl::media): (SVGStyleElementImpl::setMedia): (SVGStyleElementImpl::title): (SVGStyleElementImpl::setTitle): (SVGStyleElementImpl::sheet): (SVGStyleElementImpl::childrenChanged):
• ksvg2/svg/SVGStyleElementImpl.h:
• ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::SVGStyledElementImpl): (SVGStyledElementImpl::~SVGStyledElementImpl): (SVGStyledElementImpl::createRenderer): (SVGStyledElementImpl::parseMappedAttribute): (SVGStyledElementImpl::finalizeStyle): (SVGStyledElementImpl::attach): (SVGStyledElementImpl::canvas): (SVGStyledElementImpl::updateCanvasItem): (SVGStyledElementImpl::pushAttributeContext):
• ksvg2/svg/SVGStyledElementImpl.h: (KSVG::SVGStyledElementImpl::rendererIsNeeded): (KSVG::SVGStyledElementImpl::canvasResource):
• ksvg2/svg/SVGStyledLocatableElementImpl.cpp: Added. (SVGStyledLocatableElementImpl::SVGStyledLocatableElementImpl): (SVGStyledLocatableElementImpl::~SVGStyledLocatableElementImpl): (SVGStyledLocatableElementImpl::nearestViewportElement): (SVGStyledLocatableElementImpl::farthestViewportElement): (SVGStyledLocatableElementImpl::getBBox): (SVGStyledLocatableElementImpl::getCTM): (SVGStyledLocatableElementImpl::getScreenCTM): (SVGStyledLocatableElementImpl::getTransformToElement):
• ksvg2/svg/SVGStyledLocatableElementImpl.h: Added. (KSVG::SVGStyledLocatableElementImpl::isStyledLocatable):
• ksvg2/svg/SVGStyledTransformableElementImpl.cpp: Added. (SVGStyledTransformableElementImpl::SVGStyledTransformableElementImpl): (SVGStyledTransformableElementImpl::~SVGStyledTransformableElementImpl): (SVGStyledTransformableElementImpl::transform): (SVGStyledTransformableElementImpl::localMatrix): (SVGStyledTransformableElementImpl::getCTM): (SVGStyledTransformableElementImpl::getScreenCTM): (SVGStyledTransformableElementImpl::updateLocalTransform): (SVGStyledTransformableElementImpl::parseMappedAttribute): (SVGStyledTransformableElementImpl::nearestViewportElement): (SVGStyledTransformableElementImpl::farthestViewportElement): (SVGStyledTransformableElementImpl::getBBox): (SVGStyledTransformableElementImpl::getTransformToElement): (SVGStyledTransformableElementImpl::attach):
• ksvg2/svg/SVGStyledTransformableElementImpl.h: Added. (KSVG::SVGStyledTransformableElementImpl::isStyledTransformable):
• ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::SVGSwitchElementImpl): (SVGSwitchElementImpl::allowAttachChildren): (SVGSwitchElementImpl::createRenderer):
• ksvg2/svg/SVGSwitchElementImpl.h: (KSVG::SVGSwitchElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGSymbolElementImpl.cpp: (SVGSymbolElementImpl::SVGSymbolElementImpl): (SVGSymbolElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGSymbolElementImpl.h:
• ksvg2/svg/SVGTSpanElementImpl.cpp: (SVGTSpanElementImpl::SVGTSpanElementImpl):
• ksvg2/svg/SVGTSpanElementImpl.h:
• ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid): (SVGTestsImpl::parseMappedAttribute):
• ksvg2/svg/SVGTestsImpl.h:
• ksvg2/svg/SVGTextContentElementImpl.cpp: (SVGTextContentElementImpl::SVGTextContentElementImpl): (SVGTextContentElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGTextContentElementImpl.h:
• ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::SVGTextElementImpl): (SVGTextElementImpl::parseMappedAttribute): (SVGTextElementImpl::nearestViewportElement): (SVGTextElementImpl::farthestViewportElement): (SVGTextElementImpl::getBBox): (SVGTextElementImpl::getScreenCTM): (SVGTextElementImpl::getCTM):
• ksvg2/svg/SVGTextElementImpl.h: (KSVG::SVGTextElementImpl::getTransformToElement): (KSVG::SVGTextElementImpl::transform): (KSVG::SVGTextElementImpl::localMatrix): (KSVG::SVGTextElementImpl::updateLocalTransform):
• ksvg2/svg/SVGTextPositioningElementImpl.cpp: (SVGTextPositioningElementImpl::SVGTextPositioningElementImpl): (SVGTextPositioningElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGTextPositioningElementImpl.h:
• ksvg2/svg/SVGTitleElementImpl.cpp: (SVGTitleElementImpl::SVGTitleElementImpl): (SVGTitleElementImpl::title):
• ksvg2/svg/SVGTitleElementImpl.h:
• ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::setMatrix):
• ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::SVGTransformableImpl): (SVGTransformableImpl::~SVGTransformableImpl): (SVGTransformableImpl::parseTransformAttribute):
• ksvg2/svg/SVGTransformableImpl.h:
• ksvg2/svg/SVGURIReferenceImpl.cpp: (SVGURIReferenceImpl::href): (SVGURIReferenceImpl::parseMappedAttribute):
• ksvg2/svg/SVGURIReferenceImpl.h:
• ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::SVGUseElementImpl): (SVGUseElementImpl::parseMappedAttribute): (SVGUseElementImpl::closeRenderer): (SVGUseElementImpl::createRenderer):
• ksvg2/svg/SVGUseElementImpl.h: (KSVG::SVGUseElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGViewElementImpl.cpp: (SVGViewElementImpl::SVGViewElementImpl): (SVGViewElementImpl::parseMappedAttribute):
• ksvg2/svg/SVGViewElementImpl.h:
• ksvg2/svg/SVGZoomAndPanImpl.cpp: (SVGZoomAndPanImpl::parseMappedAttribute):
• ksvg2/svg/SVGZoomAndPanImpl.h:

Nov 20, 2005:

8:02 PM Changeset in webkit [11272] by eseidel

• 41 edits in trunk/WebCore

Bug #: 3249
Submitted by: eseidel
Reviewed by: hyatt

The first part of the big KDOM-DOM merger.
This section covers the additions necessary to the khtml/kwq side
in order to support ksvg2 on top of WebCore's DOM. All changes
are enclosed within SVG_SUPPORT blocks for easy disabling.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3249

• ForwardingHeaders/ksvg2/KSVGPart.h: to KDOMHeaders.h
• ForwardingHeaders/ksvg2/KSVGView.h: to KDOMHeaders.h
• WebCore-svg.exp: removed Draw* symbols
• WebCorePrefix.h: map KDOM to DOM
• khtml/css/css_valueimpl.h: (DOM::CSSValueImpl::cssValueType): defaults to CSS_CUSTOM
• khtml/css/cssparser.cpp: (CSSParser::parseValue): calls parseSVGValue as necessary (DOM::CSSParser::lex):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: svg specific support (khtml::CSSStyleSelector::loadDefaultStyle): loads svg UA sheet (khtml::CSSStyleSelector::applyProperty): calls applySVGProperty
• khtml/css/cssstyleselector.h:
• khtml/css/parser.y: calls KSVG::get(Property|Value)ID
• khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction): use isXMLMIMEType
• khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): impl -> implementation
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): use isXMLMIMEType
• khtml/html/html_documentimpl.cpp: remove referrer
• khtml/html/html_documentimpl.h: remove referrer
• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::begin):
• khtml/khtml_part.h:
• khtml/rendering/render_canvas.cpp: m_renderingDevice && m_registry support. (RenderCanvas::RenderCanvas): (RenderCanvas::~RenderCanvas): (RenderCanvas::renderingDevice): new method for svg (RenderCanvas::registry): new method for svg
• khtml/rendering/render_canvas.h:
• khtml/rendering/render_container.h: private -> protected (child manipulation)
• khtml/rendering/render_object.h: (khtml::RenderObject::isKCanvasContainer): new for svg (khtml::RenderObject::isRenderPath): new for svg (khtml::RenderObject::bbox): new for svg
• khtml/rendering/render_style.cpp: svg support (m_affectedByAttributeSelectors): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::operator==): (RenderStyle::contentDataEquivalent):
• khtml/rendering/render_style.h: add m_svgStyle (khtml::RenderStyle::svgStyle):
• khtml/xml/EventNames.h: add zoom event
• khtml/xml/dom_docimpl.cpp: add referrer (DOMImplementationImpl::hasFeature): made const (DOMImplementationImpl::createDocument): (DOMImplementationImpl::isXMLMIMEType): new function (DocumentImpl::implementation): renamed function (DocumentImpl::createElementNS): svg support (DocumentImpl::recalcStyleSelector): svg <style> support (DocumentImpl::createEvent): SVGEvent support (DocumentImpl::referrer): moved from HTMLDocument
• khtml/xml/dom_docimpl.h: (DOM::DocumentTypeImpl::implementation): renamed function
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::hasAttribute): convenience function (ElementImpl::rendererIsNeeded): disable renderers for unknown elements in svg
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::createRendererIfNeeded): null check on returned rederer
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isSVGElement): added for svg
• khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): init from QString
• khtml/xml/dom_stringimpl.h:
• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded): don't create RenderText in SVG trees
• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): impl -> implementation
• kwq/DOM.mm: (-[DOMDocument implementation]): impl -> implementation
• kwq/KWQRenderTreeDebug.cpp: (write): dispatch to kcanvas write functions (externalRepresentation): dump registry
• kwq/KWQRenderTreeDebug.h: export write function for kcanvas to use

5:20 PM Changeset in webkit [11271] by eseidel

• 110 edits in trunk/WebCore

Bug #: 5711
Submitted by: eseidel
Reviewed by: mjs

Remove #if !APPLE_CHANGES and #if 0 blocks. No functional changes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5711

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
• khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setProperty): (DOM::CSSPrimitiveValueImpl::computeLength): (DOM::CSSPrimitiveValueImpl::computeLengthFloat): (DOM::CSSPrimitiveValueImpl::cssText): (DOM::FontFamilyValueImpl::FontFamilyValueImpl):
• khtml/css/css_valueimpl.h:
• khtml/css/cssparser.cpp: (qFatal): (CSSParser::parseValue): (CSSParser::parseDashboardRegions):
• khtml/css/cssstyleselector.cpp: (khtml::): (khtml::colorForCSSValue): (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::checkForTextSizeAdjust):
• khtml/css/cssstyleselector.h:
• khtml/dom/dom_node.h:
• khtml/ecma/kjs_binding.cpp:
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheetList::getOwnPropertySlot):
• khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::NodeConstructor::getValueProperty): (KJS::DOMExceptionConstructor::getValueProperty):
• khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLElement::put):
• khtml/ecma/kjs_html.h:
• khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::refresh):
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): (KJSProxyImpl::initScript):
• khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::resumeTimeouts): (KJS::Window::scheduleClose): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::WindowQObject::hasTimeouts): (KJS::Location::put): (KJS::LocationFunc::callAsFunction): (KJS::BarInfo::getValueProperty):
• khtml/ecma/kjs_window.h:
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestQObject::slotData): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotData):
• khtml/ecma/xmlhttprequest.h:
• khtml/editing/SelectionController.cpp: (khtml::SelectionController::debugPosition):
• khtml/editing/append_node_command.cpp:
• khtml/editing/apply_style_command.cpp:
• khtml/editing/break_blockquote_command.cpp:
• khtml/editing/composite_edit_command.cpp:
• khtml/editing/delete_from_text_node_command.cpp:
• khtml/editing/delete_selection_command.cpp:
• khtml/editing/edit_command.cpp:
• khtml/editing/htmlediting.cpp:
• khtml/editing/insert_into_text_node_command.cpp:
• khtml/editing/insert_line_break_command.cpp:
• khtml/editing/insert_node_before_command.cpp:
• khtml/editing/insert_paragraph_separator_command.cpp:
• khtml/editing/insert_text_command.cpp:
• khtml/editing/join_text_nodes_command.cpp:
• khtml/editing/jsediting.cpp:
• khtml/editing/markup.cpp:
• khtml/editing/merge_identical_elements_command.cpp:
• khtml/editing/move_selection_command.cpp:
• khtml/editing/rebalance_whitespace_command.cpp:
• khtml/editing/remove_css_property_command.cpp:
• khtml/editing/remove_node_attribute_command.cpp:
• khtml/editing/remove_node_command.cpp:
• khtml/editing/remove_node_preserving_children_command.cpp:
• khtml/editing/replace_selection_command.cpp:
• khtml/editing/set_node_attribute_command.cpp:
• khtml/editing/split_element_command.cpp:
• khtml/editing/split_text_node_command.cpp:
• khtml/editing/split_text_node_containing_element.cpp:
• khtml/editing/typing_command.cpp:
• khtml/editing/visible_position.cpp:
• khtml/editing/wrap_contents_in_dummy_span_command.cpp:
• khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::referrer): (DOM::HTMLDocumentImpl::cookie): (DOM::HTMLDocumentImpl::setCookie):
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::attach): (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::parseMappedAttribute): (DOM::HTMLGenericFormElementImpl::isMouseFocusable): (DOM::HTMLGenericFormElementImpl::defaultEventHandler): (DOM::HTMLInputElementImpl::setInputType): (DOM::HTMLInputElementImpl::type): (DOM::HTMLInputElementImpl::canHaveSelection): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::select): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::click): (DOM::HTMLInputElementImpl::accessKeyAction): (DOM::HTMLInputElementImpl::rendererIsNeeded): (DOM::HTMLInputElementImpl::createRenderer): (DOM::HTMLInputElementImpl::attach): (DOM::HTMLInputElementImpl::altText): (DOM::HTMLInputElementImpl::appendFormData): (DOM::HTMLInputElementImpl::valueWithDefault): (DOM::HTMLInputElementImpl::storesValueSeparateFromAttribute): (DOM::HTMLInputElementImpl::defaultEventHandler): (DOM::HTMLSelectElementImpl::state): (DOM::HTMLSelectElementImpl::restoreState): (DOM::HTMLKeygenElementImpl::appendFormData):
• khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::):
• khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement): (HTMLImageElementImpl::parseMappedAttribute):
• khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isMouseFocusable):
• khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::getMember): (DOM::HTMLAppletElementImpl::callMember): (DOM::HTMLAppletElementImpl::allParamsAvailable): (DOM::HTMLEmbedElementImpl::getEmbedInstance): (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::getObjectInstance): (DOM::HTMLObjectElementImpl::rendererIsNeeded):
• khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isDocNamedItem):
• khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::HTMLTableElementImpl): (DOM::HTMLTableElementImpl::parseMappedAttribute):
• khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex):
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution):
• khtml/html/htmltokenizer.h:
• khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::stopLoading): (KHTMLPart::createJavaContext): (KHTMLPart::setAutoloadImages): (KHTMLPart::clear): (KHTMLPart::receivedFirstData): (KHTMLPart::slotFinished): (KHTMLPart::childBegin): (KHTMLPart::begin): (KHTMLPart::write): (KHTMLPart::gotoAnchor): (KHTMLPart::slotLoaderRequestStarted): (KHTMLPart::slotLoaderRequestDone): (KHTMLPart::checkCompleted): (KHTMLPart::completeURL): (KHTMLPart::scheduleHistoryNavigation): (KHTMLPart::urlCursor): (KHTMLPart::text): (KHTMLPart::selectedText): (KHTMLPart::hasSelection): (KHTMLPart::setSelection): (KHTMLPart::urlSelected): (KHTMLPart::requestFrameName): (KHTMLPart::requestObject): (KHTMLPart::processObjectRequest): (KHTMLPart::submitForm): (KHTMLPart::slotChildStarted): (KHTMLPart::slotChildCompleted): (KHTMLPart::childFrame): (KHTMLPart::findFrame): (KHTMLPart::frameExists): (KHTMLPart::parentPart): (KHTMLPart::emitSelectionChanged): (KHTMLPart::setZoomFactor): (KHTMLPart::reparseConfiguration): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::startAutoScroll): (KHTMLPart::stopAutoScroll): (KHTMLPart::shouldChangeSelection): (KHTMLPart::appliedEditing): (KHTMLPart::unappliedEditing): (KHTMLPart::reappliedEditing): (KHTMLPart::copyToPasteboard): (KHTMLPart::cutToPasteboard): (KHTMLPart::pasteFromPasteboard): (KHTMLPart::pasteAndMatchStyle): (KHTMLPart::transpose): (KHTMLPart::redo): (KHTMLPart::undo):
• khtml/khtml_part.h: (KHTMLPart::didFirstLayout):
• khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
• khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::resetScrollBars): (KHTMLView::init): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::initScrollBars): (KHTMLView::layout): (KHTMLView::updateDashboardRegions): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::keyPressEvent): (KHTMLView::contentsContextMenuEvent): (KHTMLView::dispatchDragEvent): (KHTMLView::focusNextPrevNode): (KHTMLView::mediaType): (KHTMLView::setScrollBarsMode): (KHTMLView::restoreScrollBar): (KHTMLView::viewportWheelEvent):
• khtml/khtmlview.h:
• khtml/misc/decoder.cpp: (Decoder::setEncoding): (Decoder::decode): (Decoder::flush):
• khtml/misc/decoder.h:
• khtml/misc/helper.cpp: (khtml::findWordBoundary): (khtml::nextWordFromIndex): (khtml::findSentenceBoundary): (khtml::nextSentenceFromIndex):
• khtml/misc/helper.h:
• khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedImageCallback::clear): (CachedImage::CachedImage): (CachedImage::tiled_pixmap): (CachedImage::pixmap): (CachedImage::setShowAnimations): (CachedImage::clear): (CachedImage::data): (CachedImage::error): (DocLoader::DocLoader): (DocLoader::requestImage): (DocLoader::requestStyleSheet): (DocLoader::requestScript): (DocLoader::requestXSLStyleSheet): (DocLoader::requestXBLDocument): (Loader::Loader): (Loader::~Loader): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotData): (Loader::numRequests): (Loader::cancelRequests): (Loader::removeBackgroundDecodingRequest): (Cache::init): (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript): (Cache::requestXSLStyleSheet): (Cache::requestXBLDocument):
• khtml/misc/loader.h: (khtml::CachedObject::CachedObject):
• khtml/misc/stringit.h: (khtml::TokenizerSubstring::TokenizerSubstring):
• khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): (RenderApplet::layout): (RenderEmptyApplet::RenderEmptyApplet): (RenderEmptyApplet::layout):
• khtml/rendering/render_applet.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::setBestTruncatedAt):
• khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printImages):
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): (RenderFlow::paintFocusRing):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): (RenderFormElement::setStyle): (RenderFormElement::updateFromElement): (RenderFormElement::layout): (RenderLineEdit::RenderLineEdit): (RenderLineEdit::slotReturnPressed): (RenderLineEdit::addSearchResult): (RenderLineEdit::calcMinMaxWidth): (RenderLineEdit::setStyle): (RenderLineEdit::updateFromElement): (RenderFileButton::RenderFileButton): (RenderFileButton::calcMinMaxWidth): (RenderFileButton::slotClicked): (RenderFileButton::updateFromElement): (RenderFileButton::select): (ComboBoxWidget::event): (ComboBoxWidget::eventFilter): (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderTextArea::RenderTextArea): (RenderTextArea::calcMinMaxWidth): (RenderTextArea::setStyle): (RenderTextArea::updateFromElement): (RenderTextArea::text): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::setSelectionRange):
• khtml/rendering/render_form.h: (khtml::RenderFormElement::intrinsicMargin): (khtml::RenderLineEdit::canHaveIntrinsicMargins): (khtml::RenderSelect::canHaveIntrinsicMargins): (khtml::RenderTextArea::canHaveIntrinsicMargins):
• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared): (RenderPartObject::layout): (RenderPartObject::slotViewCleared):
• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::resetAnimation): (RenderImage::paint): (RenderImage::layout):
• khtml/rendering/render_image.h:
• khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollToOffset): (khtml::RenderLayer::updateScrollInfoAfterLayout): (khtml::RenderLayer::paintScrollbars): (khtml::setClip): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTest):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paintDecorations):
• khtml/rendering/render_list.cpp: (RenderListMarker::paint):
• khtml/rendering/render_list.h: (khtml::RenderListItem::markerStringValue):
• khtml/rendering/render_object.cpp: (RenderObject::addFocusRingRects): (RenderObject::paintOutline): (RenderObject::setStyle): (RenderObject::removeFromObjectLists): (RenderObject::remove): (RenderObject::backslashAsCurrencySymbol):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): (RenderWidget::sendConsumedMouseUp): (RenderWidget::setStyle):
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (StyleCSS3NonInheritedData::operator==): (textSizeAdjust): (StyleCSS3InheritedData): (StyleCSS3InheritedData::operator==): (RenderStyle::diff):
• khtml/rendering/render_style.h: (khtml::StyleVisualData::operator==): (khtml::RenderStyle::textSizeAdjust): (khtml::RenderStyle::setDashboardRegion): (khtml::RenderStyle::setTextSizeAdjust):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::recalcStyle): (DocumentImpl::updateRendering): (DocumentImpl::attach): (DocumentImpl::detach): (DocumentImpl::getAccObjectCache): (DocumentImpl::updateSelection): (DocumentImpl::implicitClose): (DocumentImpl::processHttpEquiv): (DocumentImpl::updateStyleSelector): (DocumentImpl::setFocusNode):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::createRendererIfNeeded):
• khtml/xml/dom_position.cpp:
• khtml/xml/dom_textimpl.h:
• khtml/xml/dom_xmlimpl.h:
• khtml/xml/xml_tokenizer.cpp: (khtml::Tokenizer::Tokenizer): (khtml::Tokenizer::finishedParsing): (khtml::XMLTokenizer::error):
• khtml/xml/xml_tokenizer.h:

1:34 PM Changeset in webkit [11270] by eseidel

• 11 edits in trunk/WebCore

Bug #: 5777
Submitted by: eseidel
Reviewed by: none

Rolling out the getMatchedCSSRules change, as it caused

many layout tests to crash on TOT:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5777

• khtml/css/cssparser.cpp:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve):
• khtml/css/cssstyleselector.h:
• khtml/css/parser.y:
• khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
• khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
• khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle):
• khtml/xml/dom2_viewsimpl.h:
• kwq/DOM-CSS.mm:
• kwq/DOMCSS.h:

Nov 18, 2005:

7:51 PM Changeset in webkit [11269]

• 55 copies
  22 deletes in tags/WebKit-417~5

This commit was manufactured by cvs2svn to create tag 'WebKit-417~5'.

7:51 PM Changeset in webkit [11268]

• 210 copies
  17 deletes in tags/WebCore-417~7

This commit was manufactured by cvs2svn to create tag
'WebCore-417~7'.

7:51 PM Changeset in webkit [11267]

• 72 copies
  5 deletes in tags/JavaScriptCore-417~8

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~8'.

7:51 PM Changeset in webkit [11266] by thatcher

• 6 edits in branches/Safari-2-0-branch

Versioning

6:47 PM Changeset in webkit [11265] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 David Harrison <​harrison@apple.com>

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:46 PM Changeset in webkit [11264] by thatcher

• 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <​harrison@apple.com>

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:36 PM Changeset in webkit [11263] by harrison

• 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:36 PM Changeset in webkit [11262] by thatcher

• 19 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
• khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
• khtml/ecma/kjs_window.h: (KJS::Window::):
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
• khtml/html/htmlnames.h:
• khtml/xml/EventNames.h:
• khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
• khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
• WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
• WebView.subproj/WebUIDelegatePrivate.h:
• WebView.subproj/WebView.m: (-[WebView shouldClose]):
• WebView.subproj/WebViewPrivate.h:

6:08 PM Changeset in webkit [11261] by vicki

• 2 edits in trunk/WebKit

Changes by Tim H, reviewed by Vicki.

• call shouldClose on the bridge for the main frame

• WebView.subproj/WebView.m: (-[WebView shouldClose]):

5:27 PM Changeset in webkit [11260] by vicki

• 6 edits in trunk/WebKit

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
• WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
• WebView.subproj/WebUIDelegatePrivate.h:
• WebView.subproj/WebView.m: (-[WebView shouldClose]):
• WebView.subproj/WebViewPrivate.h:

5:26 PM Changeset in webkit [11259] by vicki

• 13 edits in trunk/WebCore

Changes by Darin, reviewed by Beth and Vicki.

• fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

• khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
• khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
• khtml/ecma/kjs_window.h: (KJS::Window::):
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
• khtml/html/htmlnames.h:
• khtml/xml/EventNames.h:
• khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
• khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

4:19 PM Changeset in webkit [11258] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-16 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrson.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

• khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

4:12 PM Changeset in webkit [11257] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

• khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):

4:11 PM Changeset in webkit [11256] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

• khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):

3:42 PM Changeset in webkit [11255] by bdakin

• 2 edits
  1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:39 PM Changeset in webkit [11254] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 David Harrison <​harrison@apple.com>

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

3:38 PM Changeset in webkit [11253] by thatcher

• 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <​harrison@apple.com>

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

2:46 PM Changeset in webkit [11252] by thatcher

• 17 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 David Hyatt <​hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
• khtml/css/html4.css:
• khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
• khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
• khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
• khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
• khtml/rendering/render_style.h: (khtml::):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
• kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):

2:41 PM Changeset in webkit [11251] by thatcher

• 17 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-29 David Hyatt <​hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
• khtml/css/html4.css:
• khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
• khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
• khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
• khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
• khtml/rendering/render_style.h: (khtml::):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
• kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):

1:35 PM Changeset in webkit [11250] by harrison

• 1 edit
  4 adds in trunk/LayoutTests

Layout tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>

• editing/deleting/move-nodes-001-expected.checksum: Added.
• editing/deleting/move-nodes-001-expected.png: Added.
• editing/deleting/move-nodes-001-expected.txt: Added.
• editing/deleting/move-nodes-001.html: Added.

1:34 PM Changeset in webkit [11249] by harrison

• 4 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

10:27 AM Changeset in webkit [11248] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629 REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

• khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()

10:26 AM Changeset in webkit [11247] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629 REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

• khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()

10:02 AM Changeset in webkit [11246] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

• fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

10:01 AM Changeset in webkit [11245] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

• fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

Nov 17, 2005:

4:57 PM Changeset in webkit [11244]

• 24 copies
  3 deletes in tags/WebKit-312~6

This commit was manufactured by cvs2svn to create tag 'WebKit-312~6'.

4:57 PM Changeset in webkit [11243]

• 105 copies
  5 deletes in tags/WebCore-315~11

This commit was manufactured by cvs2svn to create tag
'WebCore-315~11'.

4:57 PM Changeset in webkit [11242]

• 9 copies
  3 deletes in tags/JavaScriptCore-312~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~2'.

4:57 PM Changeset in webkit [11241] by thatcher

• 3 edits in branches/Safari-1-3-branch

Versioning

4:49 PM Changeset in webkit [11240] by thatcher

• 3 edits in branches/Safari-1-3-branch

Versioning

3:40 PM Changeset in webkit [11239] by bdakin

• 3 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:17 PM Changeset in webkit [11238] by adele

• 2 edits in trunk/WebCore

Reviewed by Beth.

• fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

2:44 PM Changeset in webkit [11237] by adele

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Fix by Darin, reviewed by me.

fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)

Changed the constructors to return the emtpy string if the string is null.

• kjs/value.cpp: (Value::Value): (String::String):

2:36 PM Changeset in webkit [11236] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

• khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

• khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
• khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

2:29 PM Changeset in webkit [11235] by hyatt

• 4 edits in trunk/WebCore

Add support for getting a style property off of a DOMAttr. This is an API that allows
access to the style declaration for HTML presentational attributes like width and height. This API exists only
in Objective-C, since JS would have to make the declaration readonly before it could be safely
returned.

Reviewed by darin

• khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::style): (DOM::AttrImpl::style): (DOM::MappedAttributeImpl::style):
• kwq/DOM.mm: (-[DOMAttr style]):
• kwq/DOMPrivate.h:

2:24 PM Changeset in webkit [11234] by thatcher

• 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

• khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

• khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
• khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

1:28 PM Changeset in webkit [11233] by hyatt

• 11 edits in trunk/WebCore

Add support for getMatchedCSSRules, an API that can be used to
inspect the set of rules that match on an element. From Obj-C
you see all rules (user agent, author, user). From JS you just
see author rules.

Reviewed by darin

• khtml/css/cssparser.cpp:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
• khtml/css/cssstyleselector.h:
• khtml/css/parser.y:
• khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
• khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
• khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
• khtml/xml/dom2_viewsimpl.h:
• kwq/DOM-CSS.mm: (-[DOMDocument getMatchedCSSRules::]):
• kwq/DOMCSS.h:

10:45 AM Changeset in webkit [11232] by bdakin

• 5 edits
  4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:32 AM Changeset in webkit [11231] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

• fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

• kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
• kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

10:29 AM Changeset in webkit [11230] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

• fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

• kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
• kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

Nov 16, 2005:

7:37 PM Changeset in webkit [11229] by justing

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Fixed the line endings in my previous ChangeLog entry.

6:10 PM Changeset in webkit [11228]

• 212 copies
  17 deletes in tags/WebCore-417~6

This commit was manufactured by cvs2svn to create tag
'WebCore-417~6'.

6:10 PM Changeset in webkit [11227] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Version to WebCore-417.6

6:01 PM Changeset in webkit [11226] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

More workarounds for <rdar://problem/4213314> WebCore build fails with gcc-5216 or later

5:17 PM Changeset in webkit [11225] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-16 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrson.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

• khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

5:05 PM Changeset in webkit [11224] by justing

• 293 edits in trunk/LayoutTests

Reviewed by harrison

Updated editing tests to reflect changes for:

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

5:04 PM Changeset in webkit [11223] by justing

• 3 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

Editing operations used to set an empty selection on the part before
doing work. Doing this 1) isn't necessary* 2) creates an extra didChangeSelection
notification (4108909) 3) produces a strange shouldChangeSelection call after the
editing operation is complete, i.e. "shouldChangeSelection from null to ...?"

There are still strange shouldChangeSelection calls after this change. For example,
after a delete, the selection before the delete no longer exists, so it probably
doesn't make sense to ask the delegate if WebKit shouldChangeSelection. This is filed
as 4343068.

• This was added on 2004-09-28 in order to mark misspellings in the selection to be operated on (marking misspellings is a side effect of setting a selection). Misspellings in the old selection are still marked, but not until after the operation is complete. Since some editing operations remove the selection from the document (i.e. delete or undo-typing), respondToChangedSelection no longer assumes that the old selection is in the document.

Updated layout tests to reflect this change.

• khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): Don't set the part's selection to empty before editing. (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): Don't assume that the old selection is still in the document.

4:39 PM Changeset in webkit [11222] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/khtml/xsl/xslt_processorimpl.cpp

Merge fix, was missing one line.

4:32 PM Changeset in webkit [11221] by adele

• 3 edits in trunk/WebCore

Reviewed by Dave Harrson.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

• khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
• khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

4:30 PM Changeset in webkit [11220]

• 72 copies
  5 deletes in tags/JavaScriptCore-417~7

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~7'.

4:30 PM Changeset in webkit [11219] by thatcher

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.7

2:07 PM Changeset in webkit [11218] by thatcher

• 3 edits
  1 add in branches/Safari-2-0-branch/JavaScriptCore

Fixes build failures on Glendale and Chardonnay.
We now use an export file for whatever compiler is selected (since the exported symbols differ.)

• JavaScriptCore.xcodeproj: use GCC_VERSION_IDENTIFIER to pick the proper export file
• JavaScriptCore.exp: added the 4 type infos that GCC 4 adds.
• JavaScriptCore-3.3.exp: the GCC 3.3 export file that excluded GCC 4 symbols

1:45 AM Changeset in webkit [11217] by andersca

• 45 edits in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Updated tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5737>
Implement DOM3 namespace functions.

• dom/xhtml/level3/core/nodeisdefaultnamespace01-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace02-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace06-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace07-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace08-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace09-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace10-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace11-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace13-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace14-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace15-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace16-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri02-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri03-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri06-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri07-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri10-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri11-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri13-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri14-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri15-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri18-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri19-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix01-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix02-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix03-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix06-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix07-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix08-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix09-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix10-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix11-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix13-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix14-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix15-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix16-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix18-expected.txt: These tests pass now.

1:43 AM Changeset in webkit [11216] by andersca

• 6 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

• fix <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5737> Implement DOM3 namespace functions.

• khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
• khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add JavaScript wrappers for new Node namespace functions.

• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isDefaultNamespace): (DOM::NodeImpl::lookupPrefix): (DOM::NodeImpl::lookupNamespaceURI): (DOM::NodeImpl::lookupNamespacePrefix): (DOM::NodeImpl::getAncestorElement): Implement Node namespace functions.

• khtml/xml/dom_nodeimpl.h: Add definitions for Node namespace functions.

• kwq/DOM.mm: (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): Add objective C wrappers for new Node namespace functions.

Nov 15, 2005:

6:15 PM Changeset in webkit [11215]

• 2 copies
  6 deletes in tags/JavaScriptCore-521~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-521~2'.

6:15 PM Changeset in webkit [11214] by thatcher

• 1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning

5:45 PM Changeset in webkit [12214] by ggaren

• 2 edits in trunk/JavaScriptGlue

Reviewed by mjs.

• Part of the fix for <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

Added locking in JSRunCreate, since JSRun::JSRun constructs an object.

• JavaScriptGlue.cpp: (JSRunCreate):

5:45 PM Changeset in webkit [11213] by ggaren

• 6 edits in trunk/JavaScriptCore

Reviewed by mjs.

• Fixed <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

I took responsibility for initializing and marking ConstantValues away
from InterpreterImp, since it's possible to reference such a value
before any interpreter has been created and after the last interpreter
has been destroyed.

InterpreterImp::lock now initializes ConstantValues. It's a good
place for the initialization because you have to call it before
creating any objects. Since ::lock can be called more than once,
I added a check in ConstantValues::init to ensure that it executes
only once.

Collector:collect is now responsible for marking ConstantValues.

We no longer clear the ConstantValues since we can't guarantee that no
one has a reference to them.

FIXME: This is hackery. The long-term plan is to make ConstantValues
use immediate values that require no initialization.

• ChangeLog:
• kjs/collector.cpp: (KJS::Collector::collect):
• kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::lock): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::mark):
• kjs/internal.h:
• kjs/value.cpp: (KJS::ConstantValues::initIfNeeded):
• kjs/value.h:

5:39 PM Changeset in webkit [11212] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Vicki Murley <​vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:36 PM Changeset in webkit [11211] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Vicki Murley <​vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:23 PM Changeset in webkit [11210] by thatcher

• 1 edit in branches/Safari-1-3-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

5:20 PM Changeset in webkit [11209] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

4:24 PM Changeset in webkit [11208] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-13 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:23 PM Changeset in webkit [11207] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-13 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:12 PM Changeset in webkit [11206] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOMExtensions.h

Rolling out the header change from Adele's patch. We can't add to the public API in Glendale.

4:11 PM Changeset in webkit [11205] by thatcher

• 9 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-14 Adele Peterson <​adele@apple.com>

Reviewed by Maciej and Darin.

• fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
• fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

• fast/dom/focus-contenteditable.html
• fast/dom/blur-contenteditable.html

• khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
• khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
• khtml/xml/dom_elementimpl.h: Added focus and blur functions
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
• khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
• kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
• kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

2:53 PM Changeset in webkit [11204] by vicki

• 2 edits in trunk/WebCore

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

12:02 PM Changeset in webkit [11203] by adele

• 3 edits in trunk/WebCore

Reviewed by Darin.

• fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

• kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
• kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

12:00 PM Changeset in webkit [11202] by harrison

• 7 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.
(updated png and checksums)

• editing/deleting/delete-block-merge-contents-019-expected.checksum:
• editing/deleting/delete-block-merge-contents-019-expected.png:
• editing/deleting/delete-line-011-expected.checksum:
• editing/deleting/delete-line-011-expected.png:
• editing/deleting/delete-line-012-expected.checksum:
• editing/deleting/delete-line-012-expected.png:

11:15 AM Changeset in webkit [11201] by justing

• 2 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes

Reviewed by justin

• kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.

Nov 14, 2005:

11:31 PM Changeset in webkit [11200] by adele

• 10 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-14 Adele Peterson <​adele@apple.com>

Reviewed by Maciej and Darin.

• fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
• fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

• fast/dom/focus-contenteditable.html
• fast/dom/blur-contenteditable.html

• khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
• khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
• khtml/xml/dom_elementimpl.h: Added focus and blur functions
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
• khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
• kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
• kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

9:09 PM Changeset in webkit [11199]

• 71 copies
  5 deletes in tags/JavaScriptCore-417~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~6'.

9:09 PM Changeset in webkit [11198] by thatcher

• 3 edits in branches/Safari-2-0-branch/JavaScriptCore

• JavaScriptCore.exp: removed type info sysmbols that we no longer export according to B&I.

7:26 PM Changeset in webkit [11197]

• 55 copies
  22 deletes in tags/WebKit-417~4

This commit was manufactured by cvs2svn to create tag 'WebKit-417~4'.

7:26 PM Changeset in webkit [11196]

• 210 copies
  17 deletes in tags/WebCore-417~5

This commit was manufactured by cvs2svn to create tag
'WebCore-417~5'.

7:26 PM Changeset in webkit [11195]

• 71 copies
  5 deletes in tags/JavaScriptCore-417~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~5'.

7:26 PM Changeset in webkit [11194] by thatcher

• 6 edits in branches/Safari-2-0-branch

Versioning.

6:05 PM Changeset in webkit [11193] by adele

• 11 edits
  8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Added layout tests for:
<rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
<rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

• fast/dom/blur-contenteditable-expected.checksum: Added.
• fast/dom/blur-contenteditable-expected.png: Added.
• fast/dom/blur-contenteditable-expected.txt: Added.
• fast/dom/blur-contenteditable.html: Added.
• fast/dom/focus-contenteditable-expected.checksum: Added.
• fast/dom/focus-contenteditable-expected.png: Added.
• fast/dom/focus-contenteditable-expected.txt: Added.
• fast/dom/focus-contenteditable.html: Added.

WebCore:

Reviewed by Maciej and Darin.

• fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
• fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

• fast/dom/focus-contenteditable.html
• fast/dom/blur-contenteditable.html

• khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
• khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
• khtml/xml/dom_elementimpl.h: Added focus and blur functions
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
• khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
• kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
• kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

5:12 PM Changeset in webkit [11192] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Add copyright for box-sizing render code from Allan Jensen at KDE

3:04 PM Changeset in webkit [11191] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

• fast/forms/radio_checked.html

• khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
• khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

3:03 PM Changeset in webkit [11190] by thatcher

• 4 edits in branches/Safari-2-0-branch/WebCore

Applied fix for the Safari-2-0-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

• fast/forms/radio_checked.html

• khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
• khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

2:09 PM Changeset in webkit [11189] by justing

• 31 edits
  4 adds in trunk/LayoutTests

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Added/update layout test results:

• editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
• editing/pasteboard/block-wrappers-necessary-expected.png: Added.
• editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
• editing/pasteboard/block-wrappers-necessary.html: Added.
• editing/style/create-block-for-style-001-expected.checksum:
• editing/style/create-block-for-style-001-expected.png:
• editing/style/create-block-for-style-001-expected.txt:
• editing/style/create-block-for-style-002-expected.checksum:
• editing/style/create-block-for-style-002-expected.png:
• editing/style/create-block-for-style-002-expected.txt:
• editing/style/create-block-for-style-003-expected.checksum:
• editing/style/create-block-for-style-003-expected.png:
• editing/style/create-block-for-style-003-expected.txt:
• editing/style/create-block-for-style-004-expected.checksum:
• editing/style/create-block-for-style-004-expected.png:
• editing/style/create-block-for-style-004-expected.txt:
• editing/style/create-block-for-style-007-expected.checksum:
• editing/style/create-block-for-style-007-expected.png:
• editing/style/create-block-for-style-007-expected.txt:
• editing/style/create-block-for-style-009-expected.checksum:
• editing/style/create-block-for-style-009-expected.png:
• editing/style/create-block-for-style-009-expected.txt:
• editing/style/create-block-for-style-010-expected.checksum:
• editing/style/create-block-for-style-010-expected.png:
• editing/style/create-block-for-style-010-expected.txt:
• editing/style/create-block-for-style-011-expected.checksum:
• editing/style/create-block-for-style-011-expected.png:
• editing/style/create-block-for-style-011-expected.txt:
• editing/style/create-block-for-style-012-expected.checksum:
• editing/style/create-block-for-style-012-expected.png:
• editing/style/create-block-for-style-012-expected.txt:
• editing/style/create-block-for-style-013-expected.checksum:
• editing/style/create-block-for-style-013-expected.png:
• editing/style/create-block-for-style-013-expected.txt:

2:09 PM Changeset in webkit [11188] by justing

• 3 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Updated layout test results in editing/style
Added layout test in editing/pasteboard

• khtml/css/css_valueimpl.cpp: Fixed a comment.
• khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Don't use clones of paragraphs already in the document to hold paragraph contents, since they are likely to introduce unwanted styles, just use a generic paragraph element. It's less likely, but still possible that a generic paragraph element will have unwanted style, so we may want to eventually use class=Apple-style-block.

11:53 AM Changeset in webkit [11187] by harrison

• 5 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.

• editing/deleting/delete-block-merge-contents-019-expected.txt:
• editing/deleting/delete-block-merge-contents-019.html:
• editing/deleting/delete-line-011-expected.txt:
• editing/deleting/delete-line-012-expected.txt:

11:53 AM Changeset in webkit [11186] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4337532> Paragraph concatenation fails

Updated editing/deleting tests to correctly check this behavior.

• khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Remove erroneous check for isStartOfParagraph(visibleEnd) when deciding whether to clear m_mergeBlocksAfterDelete.

11:32 AM Changeset in webkit [11185] by thatcher

• 4 edits in branches/Safari-1-3-branch

Build fix.

1:55 AM Changeset in webkit [11184] by andersca

• 1 edit in trunk/LayoutTests/ChangeLog

2005-11-14 Anders Carlsson <​andersca@mac.com>

• ChangeLog: Add bug numbers for recent fixes.

1:51 AM Changeset in webkit [11183] by andersca

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Actually save the document.

1:44 AM Changeset in webkit [11182] by andersca

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-11-14 Anders Carlsson <​andersca@mac.com>

• ChangeLog: Add bug numbers for recent fixes.

Nov 13, 2005:

11:43 PM Changeset in webkit [11181] by mjs

• 2 edits in trunk/WebCore

• fix Deployment build

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

10:46 PM Changeset in webkit [11180] by vicki

• 2 edits in trunk/WebCore

Reviewed by Adele.

• fix <rdar://problem/4341389> crash in elementAtPoint code quitting Safari, and make this code slightly more readable

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): add a nil check

7:49 PM Changeset in webkit [11179] by vicki

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fix <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

3:56 PM Changeset in webkit [11178] by andersca

• 1 edit
  2 adds in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test to make sure that importNode preserves element prefixes.

• fast/dom/importNode-prefix-expected.txt: Added.
• fast/dom/importNode-prefix.html: Added.

3:52 PM Changeset in webkit [11177] by andersca

• 2 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Use tagName() instead of localName() so the prefix will be preserved.

12:42 PM Changeset in webkit [11176] by bdakin

• 1 edit
  1 add in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

11:45 AM Changeset in webkit [11175] by andersca

• 12 edits
  2 adds in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Update tests for change to createDocument which now creates a document element.

• dom/xhtml/level3/core/documentadoptnode14-expected.txt:
• dom/xhtml/level3/core/documentadoptnode26-expected.txt:
• dom/xhtml/level3/core/documentadoptnode27-expected.txt:
• dom/xhtml/level3/core/infoset07-expected.txt:
• dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
• dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
• dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
• dom/xhtml/level3/core/wellformed03-expected.txt:
• dom/xhtml/level3/core/wellformed04-expected.txt: These tests still fail, but elsewhere now.

• dom/xhtml/level3/core/nodereplacechild14-expected.txt:
• dom/xhtml/level3/core/nodesettextcontent02-expected.txt: These tests now succeed.

• fast/dom/createDocument.html: Added.
• fast/dom/createDocument-expected.txt: Added.

11:44 AM Changeset in webkit [11174] by andersca

• 2 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Make sure to create a document element.

11:26 AM Changeset in webkit [11173] by andersca

• 1 add in trunk/LayoutTests/fast/dom/setAttributeNS-expected.txt

Forgot this.

10:53 AM Changeset in webkit [11172] by andersca

• 1 edit
  1 add in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test for setAttributeNS with null namespaceURI.

• fast/dom/setAttributeNS.html: Added.

10:52 AM Changeset in webkit [11171] by andersca

• 6 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

• khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
• khtml/ecma/kjs_binding.h: Add function which converts a JavaScript value to a DOMString, converting the null value to a null DOMString.

• khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Use valueToStringWithNullCheck in setAttributeNS and the textContent setter.

• khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::insertedIntoDocument): Don't try to evaluate scripts for viewless documents.

• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isEqualNode): Get the attribute map from the correct element.

Nov 12, 2005:

7:22 PM Changeset in webkit [11170] by thatcher

• 6 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-06 Beth Dakin <Beth Dakin>

Reviewed by Vicki.

Fix for <rdar://problem/4145535> Crash in khtml::RenderBlock::addOverhangingFloats
with simple HTML test file.

• khtml/rendering/render_block.cpp: Added nil check (khtml::RenderBlock::addOverhangingFloats):

WebKit:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

• WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto

• WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.

5:17 PM Changeset in webkit [11169] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-09-16 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick

• fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at com.apple.AppKit: -[NSPasteboard setData:forType:] + 188

• WebView.subproj/WebImageView.m: (-[WebImageView copy:]): declare types to pasteboard before starting to set their data (-[WebImageView writeSelectionToPasteboard:types:]): ditto

5:10 PM Changeset in webkit [11168] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 Geoffrey Garen <​ggaren@apple.com>

Fixed:
<rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function
<rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided
<rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided
<rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

Reviewed by darin.

Test cases added:

• manual-tests/resources/write-after-open-popup.html: Added.

• khtml/khtml_part.cpp: (KHTMLPart::didExplicitOpen): now cancels any pending redirection

5:03 PM Changeset in webkit [11167] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
Vicki thinks this fixes <rdar://problem/3562729> location.replace with dynamically written frameset doesn't change view (3621)

2005-08-01 Geoffrey Garen <​ggaren@apple.com>

Fixed <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Reviewed by darin.

Test cases added:

• manual-tests/open-after-close.html: Added.
• manual-tests/resources/open-after-close-popup.html: Added.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): We now remove a WebView from WebViewSets when the WebView is *scheduled* to close.

4:20 PM Changeset in webkit [11166] by thatcher

• 9 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

• khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
• khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
• khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
• khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
• khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
• khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
• khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
• khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
• layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
• layout-tests/fast/table/overflowHidden-expected.txt: Added.
• layout-tests/fast/table/overflowHidden.html: Added.

4:18 PM Changeset in webkit [11165] by thatcher

• 9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

• khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
• khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
• khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
• khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
• khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
• khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
• khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
• khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
• layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
• layout-tests/fast/table/overflowHidden-expected.txt: Added.
• layout-tests/fast/table/overflowHidden.html: Added.

3:37 PM Changeset in webkit [11164] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

• khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.

3:36 PM Changeset in webkit [11163] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

• khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.

Nov 11, 2005:

6:32 PM Changeset in webkit [11162] by eseidel

• 2 edits in trunk/WebCore

Bug #: 4187169
Submitted by: eseidel
Reviewed by: mjs

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

• khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.

5:57 PM Changeset in webkit [11161] by thatcher

• 17 edits
  2 deletes in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-03 Adele Peterson <​adele@apple.com>

Reviewed by Hyatt.

Clean up of layer scrolling code. Now we can clearly define what to do if a rectangle is fully visible, partially visible, or hidden.
This also fixes a bug with the previous implementation where nested layers/frames would get passed a rect that was too large.

Added fast/overflow/scrollRevealButton.html

• khtml/rendering/render_layer.h: (khtml::RenderLayer::): Added ScrollBehavior enum, ScrollAlignment struct, and ScrollAlignment static members to describe specific scrolling behaviors depending on how visible the rectangle is. In the future, we can add other statics to easily describe desired behaviors.
• khtml/rendering/render_layer.cpp: (khtml::): initialize ScrollAlignment static members: alignCenterIfNeeded, alignToEdgeIfNeeded, alignCenterAlways, alignTopAlways, alignBottomAlways (khtml::RenderLayer::scrollRectToVisible): alignCenterIfNeeded is the default behavior for both directions. Pass the original rect (adjusted if scrolling has occurred) when recursively calling this function. (khtml::RenderLayer::getRectToExpose): Adjusted for new ScrollAlignment parameters.
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Use the node's rect to determine where to scroll. We used to just use the origin, but this helps us match other browsers better. (KHTMLPart::setActiveNode): Removed scrolling code, since this is now also done in setFocusNode
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Removed scrolling code, since this is now also done in setFocusNode (KWQKHTMLPart::centerSelectionInVisibleArea): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): ditto.
• kwq/KWQScrollView.h: Removed ensureRectVisible, since we no longer use this.
• kwq/KWQScrollView.mm: ditto.
• khtml/khtmlview.cpp: (KHTMLView::doAutoScroll): Removed unnecessary nil checks for enclosingLayer (KHTMLView::focusNextPrevNode): ditto.

5:57 PM Changeset in webkit [11160] by thatcher

• 19 edits
  2 deletes in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-03 Adele Peterson <​adele@apple.com>

Reviewed by Hyatt.

Clean up of layer scrolling code. Now we can clearly define what to do if a rectangle is fully visible, partially visible, or hidden.
This also fixes a bug with the previous implementation where nested layers/frames would get passed a rect that was too large.

Added fast/overflow/scrollRevealButton.html

• khtml/rendering/render_layer.h: (khtml::RenderLayer::): Added ScrollBehavior enum, ScrollAlignment struct, and ScrollAlignment static members to describe specific scrolling behaviors depending on how visible the rectangle is. In the future, we can add other statics to easily describe desired behaviors.
• khtml/rendering/render_layer.cpp: (khtml::): initialize ScrollAlignment static members: alignCenterIfNeeded, alignToEdgeIfNeeded, alignCenterAlways, alignTopAlways, alignBottomAlways (khtml::RenderLayer::scrollRectToVisible): alignCenterIfNeeded is the default behavior for both directions. Pass the original rect (adjusted if scrolling has occurred) when recursively calling this function. (khtml::RenderLayer::getRectToExpose): Adjusted for new ScrollAlignment parameters.
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Use the node's rect to determine where to scroll. We used to just use the origin, but this helps us match other browsers better. (KHTMLPart::setActiveNode): Removed scrolling code, since this is now also done in setFocusNode
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Removed scrolling code, since this is now also done in setFocusNode (KWQKHTMLPart::centerSelectionInVisibleArea): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): ditto.
• kwq/KWQScrollView.h: Removed ensureRectVisible, since we no longer use this.
• kwq/KWQScrollView.mm: ditto.
• khtml/khtmlview.cpp: (KHTMLView::doAutoScroll): Removed unnecessary nil checks for enclosingLayer (KHTMLView::focusNextPrevNode): ditto.

5:31 PM Changeset in webkit [11159] by thatcher

• 9 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-27 David Harrison <​harrison@apple.com>

Reviewed by Justin Garcia and Dave Hyatt.

<rdar://problem/4134884> crash trying to forward msg - khtml::RenderBlock::addChildToFlow

Problem was that onunload events were being fired while in the middle of trying to detach, which resulted in updateDocumentsRendering re-attaching the previously detached nodes. Similar problem with load events while attaching.

Solved by eliminating load and unload for object nodes, pre-sending unload before detach, and sending dom mutation and load events after attaching.

Also, added asserts to catch this problem more easily in the future.

Added test:

• fast/events/event-targets.html Make sure that load and unload events do not fire on certain objects.

• khtml/ecma/kjs_html.cpp: (KJS::Image::notifyFinished): Use constant string for "load" event name.
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): Use constant strings for "load" and "readystatechange" event names.
• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::close): (HTMLFrameElementImpl::willRemove): (HTMLFrameElementImpl::detach): Add willRemove() function.
• khtml/html/html_baseimpl.h: Add willRemove() function.
• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::attach): (DOM::HTMLObjectElementImpl::detach): Stop needlessly sending load and unload events for OBJECT elements.
• khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::notifyBeforeNodeRemoval): Rename local variable from willRemove to removedNode for clarity.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::forbidEventDispatch): (DocumentImpl::allowEventDispatch): (DocumentImpl::eventDispatchForbidden): (DocumentImpl::createEvent): Add mechanism to prevent event dispatch.
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::NodeImpl::willRemove): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::willRemove): (DOM::ContainerNodeImpl::willRemoveChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents): Prevent event dispatch during DOM node removals and additions.
• khtml/xml/dom_nodeimpl.h:

5:24 PM Changeset in webkit [11158] by thatcher

• 9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-27 David Harrison <​harrison@apple.com>

Reviewed by Justin Garcia and Dave Hyatt.

<rdar://problem/4134884> crash trying to forward msg - khtml::RenderBlock::addChildToFlow

Problem was that onunload events were being fired while in the middle of trying to detach, which resulted in updateDocumentsRendering re-attaching the previously detached nodes. Similar problem with load events while attaching.

Solved by eliminating load and unload for object nodes, pre-sending unload before detach, and sending dom mutation and load events after attaching.

Also, added asserts to catch this problem more easily in the future.

Added test:

• fast/events/event-targets.html Make sure that load and unload events do not fire on certain objects.

• khtml/ecma/kjs_html.cpp: (KJS::Image::notifyFinished): Use constant string for "load" event name.
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): Use constant strings for "load" and "readystatechange" event names.
• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::close): (HTMLFrameElementImpl::willRemove): (HTMLFrameElementImpl::detach): Add willRemove() function.
• khtml/html/html_baseimpl.h: Add willRemove() function.
• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::attach): (DOM::HTMLObjectElementImpl::detach): Stop needlessly sending load and unload events for OBJECT elements.
• khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::notifyBeforeNodeRemoval): Rename local variable from willRemove to removedNode for clarity.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::forbidEventDispatch): (DocumentImpl::allowEventDispatch): (DocumentImpl::eventDispatchForbidden): (DocumentImpl::createEvent): Add mechanism to prevent event dispatch.
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::NodeImpl::willRemove): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::willRemove): (DOM::ContainerNodeImpl::willRemoveChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents): Prevent event dispatch during DOM node removals and additions.
• khtml/xml/dom_nodeimpl.h:

3:35 PM Changeset in webkit [11157] by tomernic

• 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4202650> crash in QWidget::afterMouseDown selecting "Departure box"; ​http://www.funjet.com/ (works in Firefox)

This crash was caused by a script which replaced the QWidget for a RenderSelect while the user was clicking on that widget.
RenderSelect has the interesting property that it dynamically recreates its QWidget based on how many items there are and
whether the select is "multiple". Any script which caused a change to those attributes in mouseDown could have triggered
this crash.

The problem was simply that of a stale pointer; KWQTableView and KWQListBoxScrollView both kept a pointer to the associated
QListBox, but only KWQTableView had any logic to clear the pointer when the QListBox was deallocated. Instead of adding
similar functionality to KWQTableViewListBox (this duplicating code), I removed KWQTableViewListBox's "_box" pointer and
changed its -widget method to get the widget via the KWQTableView.

• kwq/KWQListBox.mm: (QListBox::QListBox): (-[KWQListBoxScrollView widget]): Instead of keeping a pointer to the QListBox, get the QListBox from the KWQTableView, which is always this view's documentView. (-[KWQListBoxScrollView initWithListBox:]): Removed this method, since we can get at the QListBox by simply asking the KWQTableView for it.

1:15 PM Changeset in webkit [11156] by thatcher

• 2 edits in branches/Safari-2-0-branch

Changes to let build-root work.

1:14 PM Changeset in webkit [12213] by thatcher

• 2 edits in branches/Safari-2-0-branch/JavaScriptGlue

Upgraded to a native target so build-root works.

12:27 PM Changeset in webkit [11155] by thatcher

• 1 edit in branches/Safari-1-3-branch/WebCore/khtml/rendering/render_replaced.cpp

Build fix. isVariable should be used on the branch.

12:26 PM Changeset in webkit [11154] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/khtml/rendering/render_replaced.cpp

Build fix. isVariable should be used on the branch.

11:40 AM Changeset in webkit [11153] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4170
and <rdar://problem/3849434> SLIDER: Article length goes from a
subject line, back to the whole article, when decreasing (4170)

Patch by Ricci Adams
Reviewed by Dave Hyatt

• khtml/rendering/render_flexbox.cpp: (RenderFlexibleBox::layoutVerticalBox): clamp the value

11:38 AM Changeset in webkit [11152] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4170
and <rdar://problem/3849434> SLIDER: Article length goes from a
subject line, back to the whole article, when decreasing (4170)

Patch by Ricci Adams
Reviewed by Dave Hyatt

• khtml/rendering/render_flexbox.cpp: (RenderFlexibleBox::layoutVerticalBox): clamp the value

11:18 AM Changeset in webkit [11151] by thatcher

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Merges fixes from TOT to Safari-1-3-branch

2005-06-20 Anders Carlsson <​andersca@mac.com>

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3294>

• kjs/string_object.cpp: (replace): Handle the second argument of replace being a function.

11:09 AM Changeset in webkit [11150] by thatcher

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-06-20 Anders Carlsson <​andersca@mac.com>

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3294>

• kjs/string_object.cpp: (replace): Handle the second argument of replace being a function.

10:24 AM Changeset in webkit [11149] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-11 Beth Dakin <Beth Dakin>

Reviewed by Hyatt.

Fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488).

Replaced elements with a percentage width used to be given a minimum
width of 0. This caused buttons etc with width:100% to overlap when
they shouldn't. Textareas and text boxes are still given a minimum
width of 0 because they need slightly different behavior to match
WinIE. I filed <rdar://problem/4339518> to track this remaining problem.

• khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): Still give text fields a m_minWidth of 0. (RenderTextArea::calcMinMaxWidth): And textareas.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): Remove the check for width().isPercent() when making m_minWidth 0.

10:21 AM Changeset in webkit [11148] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-11 Beth Dakin <Beth Dakin>

Reviewed by Hyatt.

Fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488).

Replaced elements with a percentage width used to be given a minimum
width of 0. This caused buttons etc with width:100% to overlap when
they shouldn't. Textareas and text boxes are still given a minimum
width of 0 because they need slightly different behavior to match
WinIE. I filed <rdar://problem/4339518> to track this remaining problem.

• khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): Still give text fields a m_minWidth of 0. (RenderTextArea::calcMinMaxWidth): And textareas.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): Remove the check for width().isPercent() when making m_minWidth 0.

9:44 AM Changeset in webkit [11147] by bdakin

• 4 edits
  4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

8:40 AM Changeset in webkit [11146] by thatcher

• 17 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-06-22 Kevin Ballard <Lily Ballard>

Reviewed by Darin.

Test cases added:

• crlf.html
• text-selection.html Both of these are attached to the bug separately from the patch, because I can't cvs add. Reviewer: feel free to remove this comment and tweak the test cases added lines to reflect wherever you place these cases in the hierarchy

• Fixes bug <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3401>. Also fixes issue where setting text of a textarea in code and then retrieving it would leave the \r\n sequences in the text, despite the textarea translating to \n in all other cases.

• khtml/ecma/kjs_html.cpp: (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::KJS::HTMLElement::getValueProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLElementFunction::tryCall): (KJS::HTMLElement::putValue):
• khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::canHaveSelection): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::setValue): (DOM::HTMLTextAreaElementImpl::selectionStart): (DOM::HTMLTextAreaElementImpl::selectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionStart): (DOM::HTMLTextAreaElementImpl::setSelectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionRange): (DOM::HTMLTextAreaElementImpl::setValue):
• khtml/html/html_formimpl.h:
• khtml/rendering/render_form.cpp: (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::setSelectionRange): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::select): (RenderTextArea::setSelectionRange):
• khtml/rendering/render_form.h:
• kwq/KWQLineEdit.h:
• kwq/KWQLineEdit.mm: (QLineEdit::setCursorPosition): (QLineEdit::cursorPosition): (QLineEdit::selectAll): (QLineEdit::selectionStart): (QLineEdit::selectedText): (QLineEdit::setSelection):
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextArea setSelectedRange:]): (-[KWQTextArea selectedRange]): (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph):
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::getCursorPosition): (QTextEdit::selectionStart): (QTextEdit::selectionEnd): (QTextEdit::setSelectionStart): (QTextEdit::setSelectionEnd): (QTextEdit::selectAll): (QTextEdit::setSelectionRange):
• kwq/KWQTextField.h:
• kwq/KWQTextField.mm: (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]):

12:17 AM Changeset in webkit [11145] by thatcher

• 5 edits in branches/Safari-2-0-branch/WebCore

Build fix for merge differences with the TOT version.

Nov 10, 2005:

10:39 PM Changeset in webkit [11144] by thatcher

• 15 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-06-22 Kevin Ballard <Lily Ballard>

Reviewed by Darin.

Test cases added:

• crlf.html
• text-selection.html Both of these are attached to the bug separately from the patch, because I can't cvs add. Reviewer: feel free to remove this comment and tweak the test cases added lines to reflect wherever you place these cases in the hierarchy

• Fixes bug <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3401>. Also fixes issue where setting text of a textarea in code and then retrieving it would leave the \r\n sequences in the text, despite the textarea translating to \n in all other cases.

• khtml/ecma/kjs_html.cpp: (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::KJS::HTMLElement::getValueProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLElementFunction::tryCall): (KJS::HTMLElement::putValue):
• khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::canHaveSelection): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::setValue): (DOM::HTMLTextAreaElementImpl::selectionStart): (DOM::HTMLTextAreaElementImpl::selectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionStart): (DOM::HTMLTextAreaElementImpl::setSelectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionRange): (DOM::HTMLTextAreaElementImpl::setValue):
• khtml/html/html_formimpl.h:
• khtml/rendering/render_form.cpp: (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::setSelectionRange): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::select): (RenderTextArea::setSelectionRange):
• khtml/rendering/render_form.h:
• kwq/KWQLineEdit.h:
• kwq/KWQLineEdit.mm: (QLineEdit::setCursorPosition): (QLineEdit::cursorPosition): (QLineEdit::selectAll): (QLineEdit::selectionStart): (QLineEdit::selectedText): (QLineEdit::setSelection):
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextArea setSelectedRange:]): (-[KWQTextArea selectedRange]): (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph):
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::getCursorPosition): (QTextEdit::selectionStart): (QTextEdit::selectionEnd): (QTextEdit::setSelectionStart): (QTextEdit::setSelectionEnd): (QTextEdit::selectAll): (QTextEdit::setSelectionRange):
• kwq/KWQTextField.h:
• kwq/KWQTextField.mm: (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]):

10:08 PM Changeset in webkit [11143] by mjs

• 1 edit
  1 add in trunk/WebKit

Build fix, not reviewed.

• Plugins.subproj/WebBaseNetscapePluginViewInternal.h: Added.

9:58 PM Changeset in webkit [11142] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
All the changes were applied to khtml/editing/htmlediting.[m|h]
None of the other files exist on the branch, they were split off later.

2005-11-09 David Harrison <​harrison@apple.com>

Reviewed by Justin.

<rdar://problem/4313925> Denver Regression: Mail: "TAB+paste+insert before" actually inserts after the pasted text

• added tab span editing functions in composite_edit_command.cpp
• called them from insertText, insertLineBreak, and replaceSelection commands
• also exposed some handy tab span funcs from htmlediting.cpp

Tests added in editing/insertion and editing/pasteboard.

• khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::positionOutsideTabSpan): (khtml::CompositeEditCommand::insertNodeAtTabSpanPosition):
• khtml/editing/composite_edit_command.h:
• khtml/editing/htmlediting.cpp: (khtml::positionBeforeNode): (khtml::positionAfterNode): (khtml::tabSpanNode): (khtml::positionBeforeTabSpan):
• khtml/editing/htmlediting.h:
• khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion):
• khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply):

9:15 PM Changeset in webkit [12212] by ggaren

• 3 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

• Fixed <rdar://problem/4334445> installer crashed on my dual g4 450Mhz after clicking language

• Reversed backwards NULL check.
• Inserted guards against NULL fJSUserObject data member.
• Cleaned up some style.

• JSUtils.cpp: (KJSValueToCFTypeInternal):
• UserObjectImp.cpp: (UserObjectImp::~UserObjectImp): (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::mark):

9:12 PM Changeset in webkit [11141] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-10-12 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self dependency from this function

9:09 PM Changeset in webkit [11140] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-10-12 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self dependency from this function

9:06 PM Changeset in webkit [11139] by thatcher

• 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-02 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

fix <rdar://problem/4303587> REGRESSION (TOT): Scrollwheel doesn't work on frameset pages (5450)

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): set _currentEvent to the wheel event (KWQKHTMLPart::passWheelEventToChildWidget): New. Pass the event to the child widget, if we haven't already handled the event
• khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): add passWheelEventToChildWidget check, and accept the event if we're passing to the child widget

8:32 PM Changeset in webkit [11138] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

• fixed <rdar://problem/4327363> GAP: tabs not treated as whitespace in option element

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): call simplifyWhiteSpace() on the itemText or label to collapse whitespace.

8:29 PM Changeset in webkit [11137] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

• fixed <rdar://problem/4327363> GAP: tabs not treated as whitespace in option element

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): call simplifyWhiteSpace() on the itemText or label to collapse whitespace.

7:16 PM Changeset in webkit [11136] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Layout test for <rdar://problem/4327363> GAP: tabs not treated as whitespace in option element

• fast/forms/option-strip-whitespace-expected.checksum: Added.
• fast/forms/option-strip-whitespace-expected.png: Added.
• fast/forms/option-strip-whitespace-expected.txt: Added.
• fast/forms/option-strip-whitespace.html: Added.

WebCore:

Reviewed by Maciej.

• fixed <rdar://problem/4327363> GAP: tabs not treated as whitespace in option element

Added

• fast/forms/option-strip-whitespace.html

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): call simplifyWhiteSpace() on the itemText or label to collapse whitespace.

6:15 PM Changeset in webkit [11135] by adele

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Layout test for <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

• fast/forms/radio_checked-expected.checksum: Added.
• fast/forms/radio_checked-expected.png: Added.
• fast/forms/radio_checked-expected.txt: Added.
• fast/forms/radio_checked.html: Added.

WebCore:

Reviewed by Maciej.

-fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

• fast/forms/radio_checked.html

• khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
• khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

5:51 PM Changeset in webkit [11134] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-21 Vicki Murley <​vicki@apple.com>

Changes by Romain Brestac, reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3418 (unicode characters not preserved after a xslt transformation)

• khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::data):
• khtml/misc/loader.h:
• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

5:45 PM Changeset in webkit [11133] by thatcher

• 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-21 Vicki Murley <​vicki@apple.com>

Changes by Romain Brestac, reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3418 (unicode characters not preserved after a xslt transformation)

• khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::data):
• khtml/misc/loader.h:
• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

5:28 PM Changeset in webkit [11132] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/kwq/KWQTextArea.mm

Removing an ASSERT since this file doesn't use them.

5:27 PM Changeset in webkit [11131] by thatcher

• 1 edit in branches/Safari-1-3-branch/WebCore/kwq/KWQTextArea.mm

Removing an ASSERT since this file doesn't use them.

5:18 PM Changeset in webkit [11130] by thatcher

• 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Beth Dakin <Beth Dakin>

Reviewed by Darin.

Fix for <rdar://problem/4235722> line-height style settings not reflected in
textarea.

• khtml/rendering/render_form.cpp: (RenderTextArea::setStyle): Make setStyle call new setLineHeight function and computer correct line height using RenderObject::lineHeight
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): setFont updates lineHeight if necessary. (-[KWQTextAreaTextView setLineHeight:]): sets the line height (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:fontHeight:]): Applies the new line height to the paragraph style attributes.
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::setLineHeight): calls setLineHeight in KWQTextAreaTextView

5:17 PM Changeset in webkit [11129] by thatcher

• 6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-03 Beth Dakin <Beth Dakin>

Reviewed by Darin.

Fix for <rdar://problem/4235722> line-height style settings not reflected in
textarea.

• khtml/rendering/render_form.cpp: (RenderTextArea::setStyle): Make setStyle call new setLineHeight function and computer correct line height using RenderObject::lineHeight
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): setFont updates lineHeight if necessary. (-[KWQTextAreaTextView setLineHeight:]): sets the line height (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:fontHeight:]): Applies the new line height to the paragraph style attributes.
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::setLineHeight): calls setLineHeight in KWQTextAreaTextView

5:15 PM Changeset in webkit [11128] by tomernic

• 6 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4237941> Dashboard needs a way to stop Netscape plug-ins from getting null events

• Plugins.subproj/WebBaseNetscapePluginViewInternal.h: Added. Added WebInternal category, with -stopNullEvents and -restartNullEvents. These methods already exist on WebBaseNetscapePluginView. I am just exposing them to callers elsewhere within WebKit.

• WebKit.xcodeproj/project.pbxproj: Added WebBaseNetscapePluginViewInternal.h.

• WebView.subproj/WebFrame.m: (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Walks down the web frame hierarchy and calls -_pauseNullEventsForAllNetscapePlugins on each WebHTMLView. (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Same as above, but calls -_resumeNullEventsForAllNetscapePlugins.

• WebView.subproj/WebFramePrivate.h: Declared -_recursive_pauseNullEventsForAllNetscapePlugins and -_recursive_pauseNullEventsForAllNetscapePlugins.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Checks subviews for WebBaseNetscapePluginViews, and calls -stopNullEvents on them. (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Same as above, but calls -restartNullEvents.

• WebView.subproj/WebHTMLViewInternal.h: Declared -_pauseNullEventsForAllNetscapePlugins and -_resumeNullEventsForAllNetscapePlugins.

4:52 PM Changeset in webkit [11127] by thatcher

• 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:51 PM Changeset in webkit [11126] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:24 PM Changeset in webkit [11125] by harrison

• 2 edits in trunk/WebCore

Reviewed by Tim Omernick.

<rdar://problem/3766883> AX: Should be able to tell whether an AXLink has been visited to or not

No test cases because this does not affect layout.

• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): Added "AXVisited" attribute.

4:23 PM Changeset in webkit [11124] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:21 PM Changeset in webkit [11123] by thatcher

• 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

3:51 PM Changeset in webkit [11122] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-10 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

• khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): resolve relative urls in Image::src ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3473 <rdar://problem/3787988> Preloaded Image objects .src field is not a fully resolved path (3473)

3:50 PM Changeset in webkit [11121] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-10 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

• khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): resolve relative urls in Image::src ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3473 <rdar://problem/3787988> Preloaded Image objects .src field is not a fully resolved path (3473)

3:40 PM Changeset in webkit [11120] by thatcher

• 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-01 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Dave Hyatt.
Commited by Tim Hatcher.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5256
Relayout during load causes duplicate plugin part.

This was a problem with <OBJECT>s that contain an <EMBED>, if
layout happened in the middle of the OBJECT but before the EMBED.

No test case added, requires manual testing.

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::closeRenderer): (DOM::HTMLObjectElementImpl::setComplete):
• khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isComplete):
• khtml/html/htmlfactory.cpp: (DOM::objectConstructor):
• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):

3:29 PM Changeset in webkit [11119] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-07-12 Geoffrey Garen <​ggaren@apple.com>

Patch by Mitz Pettel

Added layout test for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3435
Parentheses are backwards in Hebrew text (no bidi mirroring?)

Test is manual because results only reflect visually -
the layout is the same either way.

Test cases added:

• manual-tests/bidi-parens.html: Added.

3:04 PM Changeset in webkit [11118] by thatcher

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-09 Dave Hyatt <​hyatt@apple.com>

Fixed <rdar://problem/4237617> selects should be in the tab order
in all keyboard modes

Reviewed by Vicki

• kwq/KWQComboBox.mm: (QComboBox::focusPolicy):
• kwq/KWQListBox.mm: (QListBox::focusPolicy):

3:02 PM Changeset in webkit [11117] by thatcher

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-09 Dave Hyatt <​hyatt@apple.com>

Fixed <rdar://problem/4237617> selects should be in the tab order
in all keyboard modes

Reviewed by Vicki

• kwq/KWQComboBox.mm: (QComboBox::focusPolicy):
• kwq/KWQListBox.mm: (QListBox::focusPolicy):

2:55 PM Changeset in webkit [11116] by eseidel

• 2 edits in trunk/WebCore

Bug #: 3473
Submitted by: eseidel
Reviewed by: ggaren

• khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): resolve relative urls in Image::src ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3473 <rdar://problem/3787988> Preloaded Image objects .src field is not a fully resolved path (3473)

2:54 PM Changeset in webkit [11115] by eseidel

• 1 edit
  3 adds in trunk/LayoutTests

Bug #: 3473
Submitted by: eseidel
Reviewed by: ggaren

• fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt: Added.
• fast/dom/HTMLImageElement/image-src-absolute-url.html: Added. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3473 <rdar://problem/3787988> Preloaded Image objects .src field is not a fully resolved path (3473)

2:38 PM Changeset in webkit [11114] by eseidel

• 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: ggaren

• Scripts/build-webkit: Pass through options to xcodebuild

12:28 PM Changeset in webkit [11113] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-10 Geoffrey Garen <​ggaren@apple.com>

• Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes in Safari at com.apple.WebCore: KJS::Window::clear + 132

Reviewed by mjs.

No test case because this crash isn't reliably reproducible.

• khtml/ecma/kjs_window.cpp: (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we know not to write to it until it's explicitly set to a valid address.

12:28 PM Changeset in webkit [11112] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-10 Geoffrey Garen <​ggaren@apple.com>

• Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes in Safari at com.apple.WebCore: KJS::Window::clear + 132

Reviewed by mjs.

No test case because this crash isn't reliably reproducible.

• khtml/ecma/kjs_window.cpp: (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we know not to write to it until it's explicitly set to a valid address.

12:22 PM Changeset in webkit [11111] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-09-16 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick

• fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at com.apple.AppKit: -[NSPasteboard setData:forType:] + 188

• WebView.subproj/WebImageView.m: (-[WebImageView copy:]): declare types to pasteboard before starting to set their data (-[WebImageView writeSelectionToPasteboard:types:]): ditto

10:38 AM Changeset in webkit [11110] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin

<rdar://problem/4060947> Safari crashes trying to save PDF file as web archive (NULL KHTMLPart)

• kwq/WebCoreBridge.mm: (+[WebCoreBridge bridgeForDOMDocument:]): Added a check for a null part.

10:22 AM Changeset in webkit [11109] by thatcher

• 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

• kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
• kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
• kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.

9:36 AM Changeset in webkit [11108] by thatcher

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from Ti-2005-009-branch to Safari-2-0-branch

2005-11-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by darin.

• Fixed <rdar://problem/4317701> *SecUpd: Tiger* PCRE heap overflow in Safari JavaScriptCore

• pcre/pcre.c: (read_repeat_counts): We now return an error for negative repeat counts in regular expressions. This matches Firefox exactly, and Win IE by effect (Win IE doesn't return an error, but it does refuse to match anything).

9:26 AM Changeset in webkit [11107] by thatcher

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Reviewed by Darin.

• Fixed <rdar://problem/4323773> REGRESSION (412.2-416.12): xxx appears on page due to JS regexp with char > 255 (5597) (tiddlywiki.com)

Previously, we fixed a buffer overflow by returning an error when
compiling character classes with characters > 255. But that broke
the internet.

Plan B here is to work around such classes, skipping single characters

255, skipping character ranges beginning > 255, and truncating

character ranges at 255.

I removed the early returns we added and the early returns in the
original library. Now, funky expressions compile normally, tweaked
by our special rules.

I also merged the UTF8 and UTF16 checks for out of range characters.
I remember we kept them separate before because we were purist about
marking off our code changes inside UTF16 #ifdefs. Since this patch
applies equally to UTF8 and UTF16, we've already lost that innocence,
so why not have a little fun?

• ChangeLog:
• pcre/pcre.c: (compile_branch):
• tests/mozilla/jsDriver.pl: Oh, by the way, I modified this to look inside of $SYMROOTS/Development. Not perfect, but certainly better than $SYMROOTS/, which is always wrong with XCode 2.1.

Nov 9, 2005:

3:05 PM Changeset in webkit [11106] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-21 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

• fix these bugs <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043) <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index

• khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): if the index is the same as the number of rows in the section, we should append

Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.

• layout-tests/fast/dynamic/013-expected.checksum:
• layout-tests/fast/dynamic/013-expected.png:
• layout-tests/fast/dynamic/013-expected.txt:

Test cases added:

• layout-tests/fast/dynamic/014-expected.checksum: Added.
• layout-tests/fast/dynamic/014-expected.png: Added.
• layout-tests/fast/dynamic/014-expected.txt: Added.
• layout-tests/fast/dynamic/014.html: Added.
• layout-tests/fast/dynamic/015-expected.checksum: Added.
• layout-tests/fast/dynamic/015-expected.png: Added.
• layout-tests/fast/dynamic/015-expected.txt: Added.
• layout-tests/fast/dynamic/015.html: Added.

3:05 PM Changeset in webkit [11105] by hyatt

• 4 edits in trunk/WebCore

Fix hit testing of relative positioned inline flows inside
clipped overflow blocks so that they aren't mistakenly included
in hit testing.

Reviewed by Beth.

• khtml/rendering/render_layer.cpp: (khtml::RenderLayer::containsPoint):
• kwq/KWQComboBox.mm: (QComboBox::focusPolicy):
• kwq/KWQListBox.mm: (QListBox::focusPolicy):

3:00 PM Changeset in webkit [11104] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-21 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

• fix these bugs <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043) <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index

• khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): if the index is the same as the number of rows in the section, we should append

Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.

• layout-tests/fast/dynamic/013-expected.checksum:
• layout-tests/fast/dynamic/013-expected.png:
• layout-tests/fast/dynamic/013-expected.txt:

Test cases added:

• layout-tests/fast/dynamic/014-expected.checksum: Added.
• layout-tests/fast/dynamic/014-expected.png: Added.
• layout-tests/fast/dynamic/014-expected.txt: Added.
• layout-tests/fast/dynamic/014.html: Added.
• layout-tests/fast/dynamic/015-expected.checksum: Added.
• layout-tests/fast/dynamic/015-expected.png: Added.
• layout-tests/fast/dynamic/015-expected.txt: Added.
• layout-tests/fast/dynamic/015.html: Added.

2:51 PM Changeset in webkit [11103] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-16 Tim Omernick <​tomernick@apple.com>

Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.

<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)

Test cases added:

• manual-tests/show-hide-object.html: Added.
• manual-tests/resources/spinbox.swf: Added.

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::detach): Set needWidgetUpdate to true so that the widget is updated on the next attach().

2:37 PM Changeset in webkit [11102] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-16 Tim Omernick <​tomernick@apple.com>

Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.

<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)

Test cases added:

• manual-tests/show-hide-object.html: Added.
• manual-tests/resources/spinbox.swf: Added.

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::detach): Set needWidgetUpdate to true so that the widget is updated on the next attach().

11:57 AM Changeset in webkit [11101] by harrison

• 1 edit
  36 adds in trunk/LayoutTests

Layout tests for <rdar://problem/4313925>
Denver Regression: Mail: "TAB+paste+insert before" actually inserts after the pasted text

• editing/inserting/insert-br-at-tabspan-001-expected.checksum: Added.
• editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
• editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
• editing/inserting/insert-br-at-tabspan-001.html: Added.
• editing/inserting/insert-br-at-tabspan-002-expected.checksum: Added.
• editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
• editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
• editing/inserting/insert-br-at-tabspan-002.html: Added.
• editing/inserting/insert-br-at-tabspan-003-expected.checksum: Added.
• editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
• editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
• editing/inserting/insert-br-at-tabspan-003.html: Added.
• editing/inserting/insert-text-at-tabspan-001-expected.checksum: Added.
• editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
• editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
• editing/inserting/insert-text-at-tabspan-001.html: Added.
• editing/inserting/insert-text-at-tabspan-002-expected.checksum: Added.
• editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
• editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
• editing/inserting/insert-text-at-tabspan-002.html: Added.
• editing/inserting/insert-text-at-tabspan-003-expected.checksum: Added.
• editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
• editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
• editing/inserting/insert-text-at-tabspan-003.html: Added.
• editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Added.
• editing/pasteboard/paste-text-at-tabspan-001-expected.png: Added.
• editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Added.
• editing/pasteboard/paste-text-at-tabspan-001.html: Added.
• editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Added.
• editing/pasteboard/paste-text-at-tabspan-002-expected.png: Added.
• editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Added.
• editing/pasteboard/paste-text-at-tabspan-002.html: Added.
• editing/pasteboard/paste-text-at-tabspan-003-expected.checksum: Added.
• editing/pasteboard/paste-text-at-tabspan-003-expected.png: Added.
• editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Added.
• editing/pasteboard/paste-text-at-tabspan-003.html: Added.

11:56 AM Changeset in webkit [11100] by harrison

• 8 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4313925> Denver Regression: Mail: "TAB+paste+insert before" actually inserts after the pasted text

• added tab span editing functions in composite_edit_command.cpp
• called them from insertText, insertLineBreak, and replaceSelection commands
• also exposed some handy tab span funcs from htmlediting.cpp

Tests added in editing/insertion and editing/pasteboard.

• khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::positionOutsideTabSpan): (khtml::CompositeEditCommand::insertNodeAtTabSpanPosition):
• khtml/editing/composite_edit_command.h:
• khtml/editing/htmlediting.cpp: (khtml::positionBeforeNode): (khtml::positionAfterNode): (khtml::tabSpanNode): (khtml::positionBeforeTabSpan):
• khtml/editing/htmlediting.h:
• khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion):
• khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply):

Nov 8, 2005:

10:34 PM Changeset in webkit [11099] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

This patch fixes some naughty naughty code -- 5 crashes and 2
may-go-haywire-in-the-futures.

One such crash is <rdar://problem/4247330> 8C46 Crash with with
incomplete parameter list to webScript object function.

I replaced early returns from within NS_DURINGs with calls to
NS_VALUERETURN because the doc says, "You cannot use goto or
return to exit an exception handling domain -- errors will result."

I replaced hard-coded analyses of -[NSMethodSignature
methodReturnType] with more abstracted alternatives, since
the documentation says "This encoding is implementation-specific,
so applications should use it with caution," and then emits an
evil cackle.

I removed the early return in the case where a JavaScript caller
supplies an insufficient number of arguments, because the right
thing to do in such a case is to use JavaScript's defined behavior
of supplying "undefined" for any missing arguments.

I also changed ObjcInstance::invokeMethod so that it no longer
deletes the method passed to it. It doesn't create the method,
so it shouldn't delete it. A friend of mine named
KERNEL_PROTECTION_FAILURE agrees with me on this point.

Finally, I changed an assert(true) to assert(false) because
all the other asserts were making fun of it.

• bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod):

6:46 PM Changeset in webkit [11098] by tomernic

• 12 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5665> (REGRESSION: Crash in deleteTimer)

Rolled back Darin's timer changes from 2005-11-07, as they caused a couple of regressions.

1:54 PM Changeset in webkit [11097] by adele

• 2 edits in trunk/WebCore

Reviewed by Darin.

• fixed <rdar://problem/4333862> REGRESSION: Crash in new JavaScript timer implementation (5661) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5661

• kwq/KWQObject.mm: (sendDeferredTimerEvents): Added nil check for timers.

12:11 AM Changeset in webkit [11096] by mjs

• 57 edits
  5 adds in trunk

LayoutTests:

Reviewed by Eric, Geoff and Darin.

• added test cases for <rdar://problem/4118258> XML DOM trees freed prematurely unless reference held to document node (causes crash)

Also updated the GC tests to try a little harder to trigger GC,
the old way might not work as well with the reworking of SimpleNumber.

• fast/dom/gc-1.html:
• fast/dom/gc-2.html:
• fast/dom/gc-3.html:
• fast/dom/gc-5.html:
• fast/dom/gc-6-expected.txt: Added.
• fast/dom/gc-6.html: Added.
• fast/dom/gc-7-expected.txt: Added.
• fast/dom/gc-7.html: Added.

WebCore:

Reviewed by Eric, Geoff and Darin.

• fixed <rdar://problem/4118258> XML DOM trees freed prematurely unless reference held to document node (causes crash)

I changed the design for how DOM nodes maintain their reference to
the document. Instead of using DocumentPtr, an indirect reference
which would go null in a clean way when the document is destroyed,
they now have a different strategy.

Nodes that belong to the document now hold a special kind of
reference on the document - a "self only reference". When a
document has no regular references but still has self-only
references, it won't be destroyed, but it will drop all its
children. This allows detached nodees to still have a valid
document reference, but they won't keep the rest of the DOM alive
or cause circular references.

• khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
• khtml/editing/visible_position.cpp: (khtml::makeRange):
• khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range):
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::HTMLBodyElementImpl): (HTMLFrameElementImpl::HTMLFrameElementImpl): (HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): (HTMLHeadElementImpl::HTMLHeadElementImpl): (HTMLHtmlElementImpl::HTMLHtmlElementImpl): (HTMLIFrameElementImpl::HTMLIFrameElementImpl):
• khtml/html/html_baseimpl.h:
• khtml/html/html_blockimpl.cpp: (HTMLBlockquoteElementImpl::HTMLBlockquoteElementImpl): (HTMLDivElementImpl::HTMLDivElementImpl): (HTMLHRElementImpl::HTMLHRElementImpl): (HTMLHeadingElementImpl::HTMLHeadingElementImpl): (HTMLParagraphElementImpl::HTMLParagraphElementImpl): (HTMLPreElementImpl::HTMLPreElementImpl): (HTMLMarqueeElementImpl::HTMLMarqueeElementImpl):
• khtml/html/html_blockimpl.h:
• khtml/html/html_canvasimpl.cpp: (HTMLCanvasElementImpl::HTMLCanvasElementImpl):
• khtml/html/html_canvasimpl.h:
• khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::createTokenizer): (DOM::HTMLDocumentImpl::determineParseMode):
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::createContextualFragment): (HTMLElementImpl::setInnerText): (HTMLElementImpl::setOuterText):
• khtml/html/html_elementimpl.h:
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLGenericFormElementImpl::HTMLGenericFormElementImpl): (DOM::HTMLButtonElementImpl::HTMLButtonElementImpl): (DOM::HTMLFieldSetElementImpl::HTMLFieldSetElementImpl): (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLLabelElementImpl::HTMLLabelElementImpl): (DOM::HTMLLegendElementImpl::HTMLLegendElementImpl): (DOM::HTMLSelectElementImpl::HTMLSelectElementImpl): (DOM::HTMLKeygenElementImpl::HTMLKeygenElementImpl): (DOM::HTMLOptGroupElementImpl::HTMLOptGroupElementImpl): (DOM::HTMLOptionElementImpl::HTMLOptionElementImpl): (DOM::HTMLOptionElementImpl::setText): (DOM::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl):
• khtml/html/html_formimpl.h:
• khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::HTMLBaseElementImpl): (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLMetaElementImpl::HTMLMetaElementImpl): (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLStyleElementImpl::HTMLStyleElementImpl): (HTMLTitleElementImpl::HTMLTitleElementImpl):
• khtml/html/html_headimpl.h:
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLMapElementImpl::HTMLMapElementImpl): (HTMLAreaElementImpl::HTMLAreaElementImpl):
• khtml/html/html_imageimpl.h:
• khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::HTMLAnchorElementImpl): (DOM::HTMLBRElementImpl::HTMLBRElementImpl): (DOM::HTMLFontElementImpl::HTMLFontElementImpl): (DOM::HTMLModElementImpl::HTMLModElementImpl): (DOM::HTMLQuoteElementImpl::HTMLQuoteElementImpl):
• khtml/html/html_inlineimpl.h:
• khtml/html/html_listimpl.h: (DOM::HTMLUListElementImpl::HTMLUListElementImpl): (DOM::HTMLDirectoryElementImpl::HTMLDirectoryElementImpl): (DOM::HTMLMenuElementImpl::HTMLMenuElementImpl): (DOM::HTMLOListElementImpl::HTMLOListElementImpl): (DOM::HTMLLIElementImpl::HTMLLIElementImpl): (DOM::HTMLDListElementImpl::HTMLDListElementImpl):
• khtml/html/html_miscimpl.cpp: (DOM::HTMLBaseFontElementImpl::HTMLBaseFontElementImpl):
• khtml/html/html_miscimpl.h:
• khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::HTMLAppletElementImpl): (DOM::HTMLEmbedElementImpl::HTMLEmbedElementImpl): (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLParamElementImpl::HTMLParamElementImpl):
• khtml/html/html_objectimpl.h:
• khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::HTMLTableElementImpl): (DOM::HTMLTableElementImpl::createTHead): (DOM::HTMLTableElementImpl::createTFoot): (DOM::HTMLTableElementImpl::createCaption): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::HTMLTableSectionElementImpl): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableCellElementImpl::HTMLTableCellElementImpl): (DOM::HTMLTableColElementImpl::HTMLTableColElementImpl):
• khtml/html/html_tableimpl.h: (DOM::HTMLTablePartElementImpl::HTMLTablePartElementImpl): (DOM::HTMLTableRowElementImpl::HTMLTableRowElementImpl): (DOM::HTMLTableCaptionElementImpl::HTMLTableCaptionElementImpl):
• khtml/html/htmlfactory.cpp: (DOM::htmlConstructor): (DOM::headConstructor): (DOM::bodyConstructor): (DOM::baseConstructor): (DOM::linkConstructor): (DOM::metaConstructor): (DOM::styleConstructor): (DOM::titleConstructor): (DOM::frameConstructor): (DOM::framesetConstructor): (DOM::iframeConstructor): (DOM::formConstructor): (DOM::buttonConstructor): (DOM::inputConstructor): (DOM::isindexConstructor): (DOM::fieldsetConstructor): (DOM::labelConstructor): (DOM::legendConstructor): (DOM::optgroupConstructor): (DOM::optionConstructor): (DOM::selectConstructor): (DOM::textareaConstructor): (DOM::dlConstructor): (DOM::ulConstructor): (DOM::olConstructor): (DOM::dirConstructor): (DOM::menuConstructor): (DOM::liConstructor): (DOM::blockquoteConstructor): (DOM::divConstructor): (DOM::headingConstructor): (DOM::hrConstructor): (DOM::paragraphConstructor): (DOM::preConstructor): (DOM::basefontConstructor): (DOM::fontConstructor): (DOM::modConstructor): (DOM::anchorConstructor): (DOM::imageConstructor): (DOM::mapConstructor): (DOM::areaConstructor): (DOM::canvasConstructor): (DOM::appletConstructor): (DOM::embedConstructor): (DOM::objectConstructor): (DOM::paramConstructor): (DOM::scriptConstructor): (DOM::tableConstructor): (DOM::tableCaptionConstructor): (DOM::tableColConstructor): (DOM::tableRowConstructor): (DOM::tableCellConstructor): (DOM::tableSectionConstructor): (DOM::brConstructor): (DOM::quoteConstructor): (DOM::marqueeConstructor): (DOM::HTMLElementFactory::createHTMLElement):
• khtml/html/htmlparser.cpp: (HTMLParser::HTMLParser): (HTMLParser::~HTMLParser):
• khtml/html/htmlparser.h: (HTMLParser::doc):
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::parseTag): (khtml::parseHTMLDocumentFragment):
• khtml/html/htmltokenizer.h:
• khtml/misc/loader.h:
• khtml/misc/shared.h: (khtml::TreeShared::~TreeShared): (khtml::TreeShared::destroy): (khtml::TreeShared::deref):
• khtml/xbl/xbl_tokenizer.cpp: (XBL::XBLTokenHandler::XBLTokenHandler):
• khtml/xbl/xbl_tokenizer.h: (XBL::):
• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::RangeImpl): (DOM::RangeImpl::setStart): (DOM::RangeImpl::setEnd): (DOM::RangeImpl::processContents): (DOM::RangeImpl::cloneRange): (DOM::RangeImpl::setStartAfter): (DOM::RangeImpl::setEndBefore): (DOM::RangeImpl::setEndAfter): (DOM::RangeImpl::setStartBefore): (DOM::rangeOfContents):
• khtml/xml/dom2_rangeimpl.h:
• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocumentType): (DOMImplementationImpl::createDocument): (DocumentImpl::DocumentImpl): (DocumentImpl::destroy): (DocumentImpl::~DocumentImpl): (DocumentImpl::createDocumentFragment): (DocumentImpl::createTextNode): (DocumentImpl::createComment): (DocumentImpl::createCDATASection): (DocumentImpl::createProcessingInstruction): (DocumentImpl::createEntityReference): (DocumentImpl::createEditingTextNode): (DocumentImpl::createElementNS): (DocumentImpl::setTitle): (DocumentImpl::removeTitle): (DocumentImpl::createRange): (DocumentImpl::createTokenizer): (DocumentImpl::implicitClose): (DocumentImpl::setHoverNode): (DocumentImpl::setActiveNode): (DocumentImpl::setFocusNode): (DocumentImpl::createAttributeNS): (DocumentFragmentImpl::DocumentFragmentImpl): (DocumentFragmentImpl::cloneNode): (DocumentTypeImpl::DocumentTypeImpl):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::selfOnlyRef): (DOM::DocumentImpl::selfOnlyDeref): (DOM::DocumentImpl::focusNode): (DOM::DocumentImpl::hoverNode): (DOM::DocumentImpl::activeNode):
• khtml/xml/dom_elementimpl.cpp: (AttributeImpl::allocateImpl): (AttrImpl::AttrImpl): (AttrImpl::cloneNode): (ElementImpl::ElementImpl): (StyledElementImpl::StyledElementImpl):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): (DOM::NodeImpl::setDocument): (DOM::NodeImpl::~NodeImpl): (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::checkAddChild): (DOM::ContainerNodeImpl::ContainerNodeImpl): (DOM::ContainerNodeImpl::removeAllChildren): (DOM::ContainerNodeImpl::~ContainerNodeImpl):
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inDocument): (DOM::NodeImpl::getDocument):
• khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): (CommentImpl::CommentImpl): (TextImpl::TextImpl): (TextImpl::createNew): (CDATASectionImpl::CDATASectionImpl): (CDATASectionImpl::createNew): (EditingTextImpl::EditingTextImpl):
• khtml/xml/dom_textimpl.h:
• khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::EntityReferenceImpl::EntityReferenceImpl): (DOM::EntityReferenceImpl::cloneNode): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl): (DOM::ProcessingInstructionImpl::cloneNode):
• khtml/xml/dom_xmlimpl.h:
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElementNs): (khtml::XMLTokenizer::enterText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::cdataBlock): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::internalSubset): (khtml::XMLTokenizer::finish): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::newXMLTokenizer):
• khtml/xml/xml_tokenizer.h:
• khtml/xsl/xslt_processorimpl.cpp: (DOM::createFragmentFromSource):

Nov 7, 2005:

4:49 PM Changeset in webkit [11095] by harrison

• 1 edit
  4 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3739
Unreproducible - Assertion failure in isEqualIgnoringAffinity on double-click

• editing/selection/doubleclick-crash-expected.checksum: Added.
• editing/inserting/doubleclick-crash-expected.png: Added.
• editing/inserting/doubleclick-crash-expected.txt: Added.
• editing/inserting/doubleclick-crash.html: Added.

4:49 PM Changeset in webkit [11094] by harrison

• 3 edits in trunk/WebCore

Reviewed by Justin and Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3739
Unreproducible - Assertion failure in isEqualIgnoringAffinity on double-click

Test case added:

• editing/inserting/doubleclick-crash.html

• khtml/rendering/render_text.cpp: (RenderText::atLineWrap): New utility function. (RenderText::caretRect): Use atLineWrap. Remove dead code. (RenderText::inlineBox): Use atLineWrap.
• khtml/rendering/render_text.h: Add atLineWrap.

3:24 PM Changeset in webkit [11093] by hyatt

• 3 edits in trunk/WebCore

Fix for sluggish loading of large pages due to excessive
repaints. Large pages still need a lot of work while
loading, but this helps.

Reviewed by darin

• khtml/rendering/render_object.cpp: (RenderObject::mustRepaintBackgroundOrBorder): (RenderObject::repaintAfterLayoutIfNeeded):
• khtml/rendering/render_object.h:

2:30 PM Changeset in webkit [11092] by adele

• 3 edits
  4 adds in trunk

Reviewed by Darin Adler.
Committed by Adele Peterson.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5398 source visible when <script> used inside <option>

Added:

• fast/forms/option-select.html

• khtml/html/html_formimpl.h: (DOM::HTMLOptionElementImpl::checkDTD): Allow <script> tags to be children of option elements
• khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::text): Skip the script content when creating text string

1:32 PM Changeset in webkit [11091] by darin

• 2 edits in trunk/WebKitTools

• Scripts/cvs-apply: Fix case where the patch has files at the top level.

1:21 PM Changeset in webkit [11090] by ggaren

• 1 edit
  3 adds in trunk/WebCore

• Added manual test cases for <rdar://problem/4161660> window.close followed by window.print in onload handler crashes Safari in KJS::ScopeChain::bottom (redmccombstoyota.com)

• manual-tests/resources/window-close-during-parsing-popup1.html: Added.
• manual-tests/resources/window-close-during-parsing-popup2.html: Added.
• manual-tests/window-close-during-parsing.html: Added.

1:18 PM Changeset in webkit [11089] by ggaren

• 2 edits in trunk/WebKit

Darin reviewed this a while back.

• Fixed <rdar://problem/4161660> window.close followed by window.print in onload handler crashes Safari in KJS::ScopeChain::bottom (redmccombstoyota.com)

Added a call to stopLoading inside closeWindowSoon to prevent load
events from firing after a window has torn down.

Manual test case: WebCore/manual-tests/window-close-during-parsing.html

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]):

12:52 PM Changeset in webkit [11088] by darin

• 12 edits in trunk/WebCore

Reviewed by Tim Omernick.

• speed up timers by using CFTimerRunLoopRef instead of NSTimer

• kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and restartTimer. Made KWQObjectSenderScope functions be inline.
• kwq/KWQObject.mm: (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent on the target. (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new timer ID and calls restartTimer. (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary. That includes creating a CFRunLoopTimer and scheduling it on the current run loop. (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to fire and the "fire again" interval. (deleteTimer): Added. Invalidates and then removes a timer. (QObject::killTimer): Changed to use deleteTimer to do most of its work. (deleteOneTimer): Added. Calls deleteTimer. (QObject::killTimers): Changed to use deleteOneTimer to do most of its work. (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target. (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers. (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.

• kwq/KWQTimer.h: (QTimer::QTimer): Made constructor inline and removed the optional parameter. (QTimer::isActive): Made inline. (QTimer::fireDate): Added. Inline function. Got rid of the NSTimer and added a CFRunLoopTimer.
• kwq/KWQTimer.mm: (timerFired): Added. Calls fire on the QTimer object. (QTimer::start): Changed to create a CFRunLoopTimer. (QTimer::stop): Changed to use CFRunLoopTimer functions. (QTimer::fire): Ditto. (deleteKWQSlot): Added. Used as delete function for the CFRunLoopTimerContext below. (singleShotTimerFired): Added. Used as the fire function for the CFRunLoopTimerContext below. (QTimer::singleShot): Changed to create, schedule, and release a CFRunLoopTimer.

• khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the file so it can be used inline in the implementation of the Window class, and changed to use the PausedTimeouts class intead of a QMap to store the paused timeouts.
• khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces a check in the caller and a check partway down this function (after the part was already dereferenced). Fixed message handling so the message is not converted to ascii and back. Added an isObject() check so we won't crash if the passed function is a value that's not an object. Changed check for function vs. script to check for a function of nil instead of using a separate boolean. (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object, using the new QObject::timerIntervals function rather than the old QObject::pauseTimer function. This means that the paused timers are entirely stored in the PausedTimeouts object instead of being half in a QMap and the other half inside the QObject itself. (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function. (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including the scheduled actions, unless the timeouts have already been resumed (in which case the m_array field will be 0).

• kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them use the PausedTimeouts class and no longer take a key parameter.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than the old getNSTimer() function to get the fire date. (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter. (KWQKHTMLPart::resumeTimeouts): Remove the key parameter. (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead of a QMap for the paused timeouts.

• kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts. Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
• kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]): Added code where it sets the pausedTimouts. (-[KWQPageState pausedTimeouts]): Added. (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode. (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0. (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method. (-[KWQPageState finalize]): Set document to 0 after deref for consistency.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the paused timeouts using the new pauseTimeouts function.

11:59 AM Changeset in webkit [11087] by justing

• 6 edits
  8 adds in trunk/LayoutTests

Reviewed by harrison

New/updated layout tests for fixes for:

<rdar://problem/4125131> REGRESSION (Mail): after certain steps,
extra blank line appears when typing past end of reply-quoted text
<rdar://problem/4024996> Applying block styles can cause assertion
failure in inline style removal

• editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• editing/deleting/delete-br-011-expected.checksum:
• editing/deleting/delete-br-011-expected.png:
• editing/deleting/delete-br-011-expected.txt:
• editing/inserting/insert-3786362-fix-expected.txt:
• editing/inserting/insert-at-end-01-expected.checksum: Added.
• editing/inserting/insert-at-end-01-expected.png: Added.
• editing/inserting/insert-at-end-01-expected.txt: Added.
• editing/inserting/insert-at-end-01.html: Added.
• editing/inserting/insert-at-end-02-expected.checksum: Added.
• editing/inserting/insert-at-end-02-expected.png: Added.
• editing/inserting/insert-at-end-02-expected.txt: Added.
• editing/inserting/insert-at-end-02.html: Added.

11:59 AM Changeset in webkit [11086] by justing

• 6 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4125131> REGRESSION (Mail): after certain steps,
extra blank line appears when typing past end of reply-quoted text
<rdar://problem/4024996> Applying block styles can cause assertion
failure in inline style removal

Prevent VisiblePositions at [br, 1] at the end of root editable elements.

Layout tests added:

• inserting/insert-at-end-01.html
• inserting/insert-at-end-02.html

Layout tests changed (fixed):

• editing/deleting/delete-br-011.html
• editing/deleting/delete-at-paragraph-boundaries-011.html
• editing/inserting/insert-3786362-fix.html

• khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::applyInlineStyle): Do the layout before calculating start/end positions, not after, since upstream/downstream need to know who is rendered/unrendered. Don't do equivalentRangeCompliantPosition() on the start position in addition to downstream(), since it a) is confusing, b) frequently causes start/end to be equal, making removeInlineStyle a no-op and c) causes an assertion to fire. Only reset start/end using endingSelection() if splitTextElement was needed, since reseting start/end negates the work done above to swap start/end if they are backwards. When the start position points off the end of a node, that node should be skipped in all cases, not just the start.node() != end.node() case.

• khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::appendBlockPlaceholder): (khtml::CompositeEditCommand::insertBlockPlaceholder): Placeholders should be allowed in nodes that aren't blockFlow, for example, deleting the b in <div><span>b</span></div> should insert a placeholder.

The assertion here should really be something like isBlockFlow

isInlineFlow, but I can't assert those until deletion improves (4244964).

• khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Don't try to select the placeholder when applying style to it. It isn't necessary, and it's now impossible to do at the end of the document in any case.

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::initDownstream): Don't create VisiblePositions at [br, 1] at the end of editable blocks, it produces strange/inconsistent editing behavior at the end of the document.

• khtml/khtml_part.cpp: Fixed a comment.

Nov 6, 2005:

7:07 PM Changeset in webkit [11085] by ggaren

• 1 edit in trunk/JavaScriptCore/ChangeLog

changelog fixup

1:47 PM Changeset in webkit [11084] by andersca

• 3 edits in trunk/WebCore

2005-11-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

• kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Get the NSImage from the image renderer.

• kwq/WebCoreImageRenderer.h: Add image method. This already exists in WebImageRenderer in WebKit.

12:44 PM Changeset in webkit [11083] by ggaren

• 1 edit
  4 adds
  2 deletes in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5571
REGRESSION (412.5-TOT): duplicated words/sentences at
shakespeer.sourceforge.net

Also renamed previous test for consistency.

• fast/js/regexp-big-unicode-ranges-expected.txt: Removed.
• fast/js/regexp-big-unicode-ranges.html: Removed.
• fast/js/regexp-extended-characters-crash-expected.txt: Added.
• fast/js/regexp-extended-characters-crash.html: Added.
• fast/js/regexp-extended-characters-match-expected.txt: Added.
• fast/js/regexp-extended-characters-match.html: Added.

12:41 PM Changeset in webkit [11082] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5571 REGRESSION (412.5-TOT): duplicated words/sentences at shakespeer.sourceforge.net

Our UTF16-modified PCRE didn't work with extended character classes
(classes involving characters > 255) because it used the GETCHARINC
macro to read through them. In UTF16 mode, GETCHARINC expects UTF16
input, but PCRE encodes character classes in UTF8 regardless of the
input mode of the subject string.

The fix is to explicitly define GETUTF8CHARINC, and to use it,
rather than GETCHARINC, when reading extended character classes.

In UTF8 mode, we simply define GETCHARINC to be GETUTF8CHARINC.

• pcre/pcre_internal.h:
• pcre/pcre_xclass.c: (_pcre_xclass):

Nov 5, 2005:

10:22 PM Changeset in webkit [11081] by ggaren

• 1 edit
  2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5357
REGRESSION: Scriptable plugin hides properties of OBJECT element

• fast/dom/object-plugin-hides-properties.html: Added.
• fast/js/object-plugin-hides-properties-expected.txt: Added.

10:20 PM Changeset in webkit [11080] by ggaren

• 2 edits in trunk/JavaScriptCore

Patch by Mitz Pettel, reviewed by Maciej.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5357 REGRESSION: Scriptable plugin hides properties of OBJECT element

• bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::fallbackObject):

9:58 PM Changeset in webkit [11079] by ggaren

• 1 edit in trunk/LayoutTests/ChangeLog

changelog fixup

9:52 PM Changeset in webkit [11078] by ggaren

• 1 edit
  2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5409
slice() testcase doesn't pass

• fast/js/string-slice-abnormal-values.html: Added.
• fast/js/string-slice-abnormal-values-expected.txt: Added.

9:48 PM Changeset in webkit [11077] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5409 slice() testcase doesn't pass

Modified String.slice to deal with funky values.
Updated test results. We now pass <js1_2/String/slice.js>.

• kjs/string_object.cpp: (StringProtoFuncImp::callAsFunction):
• tests/mozilla/expected.html:

9:07 PM Changeset in webkit [11076] by ggaren

• 2 edits in branches/Ti-2005-009-branch/JavaScriptCore

• Rolled out the pcre changes in my previous checkin because I applied them to the wrong branch.

Reviewed by TimH.

• pcre/pcre.c: (compile_branch):

8:09 PM Changeset in webkit [11075] by ggaren

• 1 edit in branches/Ti-2005-009-branch/JavaScriptCore/ChangeLog

changelog fixup

8:05 PM Changeset in webkit [11074] by ggaren

• 3 edits in branches/Ti-2005-009-branch/JavaScriptCore

Reviewed by NOBODY (OOPS!).

• Fixed <rdar://problem/4323773> REGRESSION (412.2-416.12): xxx appears on page due to JS regexp with char > 255 (5597) (tiddlywiki.com)

Previously, we fixed a buffer overflow by returning an error when
compiling character classes with characters > 255. But that broke
the internet.

Plan B here is to work around such classes, skipping single characters

255, skipping character ranges beginning > 255, and truncating

character ranges at 255.

I removed the early returns we added and the early returns in the
original library. Now, funky expressions compile normally, tweaked
by our special rules.

I also merged the UTF8 and UTF16 checks for out of range characters.
I remember we kept them separate before because we were purist about
marking off our code changes inside UTF16 #ifdefs. Since this patch
applies equally to UTF8 and UTF16, we've already lost that innocence,
so why not have a little fun?

• ChangeLog:
• pcre/pcre.c: (compile_branch):
• tests/mozilla/jsDriver.pl: Oh, by the way, I modified this to look inside of $SYMROOTS/Development. Not perfect, but certainly better than $SYMROOTS/, which is always wrong with XCode 2.1.

Nov 4, 2005:

10:49 PM Changeset in webkit [11073] by darin

• 1 edit
  32 adds in trunk/LayoutTests

• added pixel results for a bunch of tests that didn't have them

• fast/block/basic/021-expected.checksum: Added.
• fast/block/basic/021-expected.png: Added.
• fast/block/positioning/062-expected.checksum: Added.
• fast/block/positioning/062-expected.png: Added.
• fast/box-sizing/box-sizing-expected.checksum: Added.
• fast/box-sizing/box-sizing-expected.png: Added.
• fast/box-sizing/panels-one-expected.checksum: Added.
• fast/box-sizing/panels-one-expected.png: Added.
• fast/box-sizing/panels-two-expected.checksum: Added.
• fast/box-sizing/panels-two-expected.png: Added.
• fast/box-sizing/percentage-height-expected.checksum: Added.
• fast/box-sizing/percentage-height-expected.png: Added.
• fast/css-generated-content/014-expected.checksum: Added.
• fast/css-generated-content/014-expected.png: Added.
• fast/events/event-targets-expected.checksum: Added.
• fast/events/event-targets-expected.png: Added.
• fast/forms/blankbuttons-expected.checksum: Added.
• fast/forms/blankbuttons-expected.png: Added.
• fast/forms/button-positioned-expected.checksum: Added.
• fast/forms/button-positioned-expected.png: Added.
• fast/forms/indeterminate-expected.checksum: Added.
• fast/forms/indeterminate-expected.png: Added.
• fast/frames/calculate-fixed-expected.checksum: Added.
• fast/frames/calculate-fixed-expected.png: Added.
• fast/frames/calculate-order-expected.checksum: Added.
• fast/frames/calculate-order-expected.png: Added.
• fast/frames/calculate-percentage-expected.checksum: Added.
• fast/frames/calculate-percentage-expected.png: Added.
• fast/frames/calculate-relative-expected.checksum: Added.
• fast/frames/calculate-relative-expected.png: Added.
• fast/frames/calculate-round-expected.checksum: Added.
• fast/frames/calculate-round-expected.png: Added.

4:20 PM Changeset in webkit [11072] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_block.cpp

Fix build bustage.

4:13 PM Changeset in webkit [11071]

• 82 copies
  5 deletes in tags/JavaScriptCore-416~14

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~14'.

4:13 PM Changeset in webkit [11070] by thatcher

• 2 edits in branches/Ti-2005-009-branch/JavaScriptCore

Versioning to JavaScriptCore-416.14

4:05 PM Changeset in webkit [11069]

• 8 copies
  3 deletes in tags/JavaScriptCore-312~1~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~1~1'.

4:05 PM Changeset in webkit [11068] by thatcher

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning JavaScriptCore-312.1.1

4:02 PM Changeset in webkit [11067] by thatcher

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Merging fix from Ti-2005-009-branch to Safari-1-3-branch

2005-11-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by darin.

• Fixed <rdar://problem/4317701> *SecUpd: Tiger* PCRE heap overflow in Safari JavaScriptCore

• pcre/pcre.c: (read_repeat_counts): We now return an error for negative repeat counts in regular expressions. This matches Firefox exactly, and Win IE by effect (Win IE doesn't return an error, but it does refuse to match anything).

3:26 PM Changeset in webkit [11066] by ggaren

• 2 edits in branches/Ti-2005-009-branch/JavaScriptCore

Reviewed by darin.

• Fixed <rdar://problem/4317701> *SecUpd: Tiger* PCRE heap overflow in Safari JavaScriptCore

• pcre/pcre.c: (read_repeat_counts): We now return an error for negative repeat counts in regular expressions. This matches Firefox exactly, and Win IE by effect (Win IE doesn't return an error, but it does refuse to match anything).

1:13 PM Changeset in webkit [11065] by hyatt

• 2 edits in trunk/WebCore

Fix for bug 5626, ghosted float steals mouse events. Make sure
that the floatRect() method deals with overflow.

Reviewed by john

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::nodeAtPoint):

1:02 PM Changeset in webkit [11064] by harrison

• 2 edits
  1 add in trunk/WebCore

Reviewed by John Sullivan.

Test case added:

• manual-tests/whitespace-pre-affinity.html

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3739

This patch addresses the root cause of the problem by making
RenderText::inlineBox() cope with the fact that in white-space:pre text the
newline characters are not part of any InlineTextBox... they lie "between"
them. Now DOWNSTREAM affinity selects the next text box only if the offset
that is past the current box is actually _in_ the next box.

• khtml/rendering/render_text.cpp: (RenderText::inlineBox):

12:40 PM Changeset in webkit [11063] by darin

• 1 edit
  7 deletes in trunk/WebCore

• removed unused duplicate copy of hash table code

• khtml/misc/hashfunctions.h: Removed.
• khtml/misc/hashmap.h: Removed.
• khtml/misc/hashset.h: Removed.
• khtml/misc/hashtable.cpp: Removed.
• khtml/misc/hashtable.h: Removed.
• khtml/misc/hashtraits.h: Removed.
• khtml/misc/pointerhash.h: Removed.

12:12 PM Changeset in webkit [11062]

• 22 copies
  3 deletes in tags/WebKit-312~5~2

This commit was manufactured by cvs2svn to create tag
'WebKit-312~5~2'.

12:12 PM Changeset in webkit [11061]

• 70 copies
  3 deletes in tags/WebCore-315~10~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~10~1'.

12:12 PM Changeset in webkit [11060] by thatcher

• 4 edits in branches/Safari-1-3-branch

Versioning to WebKit-312.5.2 and WebCore-315.10.1

12:04 PM Changeset in webkit [11059]

• 53 copies
  22 deletes in tags/WebKit-416~12

This commit was manufactured by cvs2svn to create tag
'WebKit-416~12'.

12:04 PM Changeset in webkit [11058]

• 210 copies
  15 deletes in tags/WebCore-416~14

This commit was manufactured by cvs2svn to create tag
'WebCore-416~14'.

12:04 PM Changeset in webkit [11057] by thatcher

• 4 edits in branches/Ti-2005-009-branch

Versioning to WebCore-416.14 and WebKit-416.12

9:45 AM Changeset in webkit [11056]

• 10 copies
  7 deletes in tags/Safari-521

This commit was manufactured by cvs2svn to create tag 'Safari-521'.

9:45 AM Changeset in webkit [11055] by thatcher

• 1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning to 521.1

9:30 AM Changeset in webkit [11054] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

• kxmlcore/HashSet.h: Fixed case of "hashfunctions.h" -- needs to be "HashFunctions.h".

9:02 AM Changeset in webkit [12211] by thatcher

• 2 edits in trunk/JavaScriptGlue

Reviewed by Darin.

• JavaScriptGlue.xcodeproj/project.pbxproj: Fixed the FRAMEWORK_SEARCH_PATHS to look in the WebKit Frameworks for the Default config.

12:07 AM Changeset in webkit [11053] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

• WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto

• WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.

Nov 3, 2005:

11:47 PM Changeset in webkit [11052] by thatcher

• 4 edits in branches/Ti-2005-009-branch/WebKit

Merged fix from TOT to Ti-2005-009-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

• WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto

• WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.

10:05 PM Changeset in webkit [11051] by thatcher

• 1 edit
  1 add in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-06 Beth Dakin <Beth Dakin>

Reviewed by Vicki.

Fix for <rdar://problem/4145535> Crash in khtml::RenderBlock::addOverhangingFloats
with simple HTML test file.

• khtml/rendering/render_block.cpp: Added nil check (khtml::RenderBlock::addOverhangingFloats):

9:59 PM Changeset in webkit [11050] by thatcher

• 2 edits in branches/Ti-2005-009-branch/WebCore

Merged fix from TOT to Ti-2005-009-branch

2005-10-06 Beth Dakin <Beth Dakin>

Reviewed by Vicki.

Fix for <rdar://problem/4145535> Crash in khtml::RenderBlock::addOverhangingFloats
with simple HTML test file.

• khtml/rendering/render_block.cpp: Added nil check (khtml::RenderBlock::addOverhangingFloats):

9:58 PM Changeset in webkit [11049] by thatcher

• in /

file ChangeLog was added on branch Safari-1-3-branch on 2005-11-04 06:04:56 +0000

9:58 PM Changeset in webkit [11048] by justing

• 2 edits in trunk/WebCore

Bugzilla 5604: plainText (visible_text.cpp) performance improvement

Reviewed by justin and darin

Optimized plainText for a ~100% speedup in most cases.

No test cases added, change only effects performance.

• khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeLength): Removed an extraneous comment. (khtml::plainText): The length of the string to be created was pre-calculated to avoid the expense of many QString::append() calls. Removed this since TextIterator::advance() is much more expensive than append.

6:33 PM Changeset in webkit [11047] by ggaren

• 1 edit in trunk/JavaScriptCore/ChangeLog

changelog fixup in response to email from Darin

5:38 PM Changeset in webkit [11046] by thatcher

• 6 edits in trunk

JavaScriptCore:

Reviewed by Darin and Vicki.

• JavaScriptCore.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

WebCore:

Reviewed by Darin and Vicki.

• WebCore.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

WebKit:

Reviewed by Darin and Vicki.

• WebKit.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

5:36 PM Changeset in webkit [12210] by thatcher

• 2 edits in trunk/JavaScriptGlue

Tools:

Reviewed by Darin and Vicki.

• Scripts/build-root: now builds in a sandbox and wont replace your system WebKit or Safari will now also build JavaScriptGlue and WebKitSystemInterface

JavaScriptGlue:

Reviewed by Darin and Vicki.

• JavaScriptGlue.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

WebBrowser:

Reviewed by Darin and Vicki.

• WebBrowser.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

WebKitSystemInterface:

Reviewed by Darin and Vicki.

• WebKitSystemInterface.xcodeproj/project.pbxproj: Change to use $(SYSTEM_LIBRARY_DIR) consistently and place $(NEXT_ROOT) in a few spots to make build-root work.

4:28 PM Changeset in webkit [11045]

• 18 copies in branches/kdom-dom-merger/WebCore

This commit was manufactured by cvs2svn to create branch
'kdom-dom-merger'.

4:28 PM Changeset in webkit [11044] by eseidel

• 4 edits
  8 deletes in /

Submitted by: eseidel
Reviewed by: none, SVG merger branch only.

3:53 PM Changeset in webkit [11043] by hyatt

• 2 edits in trunk/WebCore

Cleanup of bidi.cpp. This is bug 5532. I merged it nearly as is, although I
did one additional rename of my own (BidiIterator's "par" -> "block") and
I did not merge the * changes, since that particular style guideline is
"in dispute." :)

Reviewed by darin

• khtml/rendering/bidi.cpp: (khtml::BidiIterator::BidiIterator): (khtml::BidiIterator::pos): (khtml::BidiState::BidiState): (khtml::getBPMWidth): (khtml::BidiContext::BidiContext): (khtml::BidiContext::~BidiContext): (khtml::BidiContext::deref): (khtml::operator==): (khtml::operator!=): (khtml::bidiNext): (khtml::bidiFirst): (khtml::BidiIterator::increment): (khtml::BidiIterator::atEnd): (khtml::BidiIterator::current): (khtml::chopMidpointsAt): (khtml::checkMidpoints): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::constructLine): (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak):

1:05 PM Changeset in webkit [11042] by hyatt

• 3 edits in trunk/WebCore

Make pre-wrap collapse away spaces at the start of a line. There are
still several bugs, namely with overflow and with selection. This is bugzilla
bug 5593.

Reviewed by adele

fast/text/whitespace/pre-wrap.html

• khtml/rendering/bidi.cpp: (khtml::skipNonBreakingSpace): (khtml::shouldCollapseWhiteSpace): (khtml::RenderBlock::skipWhitespace):
• khtml/rendering/render_block.h:

12:04 PM Changeset in webkit [11041] by thatcher

• 3 edits in branches/Safari-Leo-branch

Versioning to 521.

12:00 PM Changeset in webkit [11040] by adele

• 3 edits in trunk/WebCore

Reviewed by Darin.

• khtml/rendering/render_layer.cpp: (khtml::): Made global ScrollAlignment members const (khtml::RenderLayer::scrollRectToVisible): Changed ScrollAlignment parameters to const ScrollAlignment& (khtml::RenderLayer::getRectToExpose): ditto.
• khtml/rendering/render_layer.h: (khtml::RenderLayer::): removed typedefs (khtml::RenderLayer::getVisibleBehavior): Made this static. (khtml::RenderLayer::getPartialBehavior): ditto. (khtml::RenderLayer::getHiddenBehavior): ditto.

11:31 AM Changeset in webkit [11039] by ggaren

• 2 edits in trunk/JavaScriptCore

• Updated JavaScriptCore test results to reflect recent fixes.

• tests/mozilla/expected.html:

11:12 AM Changeset in webkit [11038] by adele

• 11 edits
  5 adds in trunk

LayoutTests:

Test for...
<rdar://problem/3612121> setting focus, by tabbing, searching, or with JavaScript does not scroll overflow:auto/scroll/overlay to reveal focused element (3480)

• fast/overflow/resources/scrollButton1.html: Added.
• fast/overflow/scrollRevealButton-expected.checksum: Added.
• fast/overflow/scrollRevealButton-expected.png: Added.
• fast/overflow/scrollRevealButton-expected.txt: Added.
• fast/overflow/scrollRevealButton.html: Added.

WebCore:

Reviewed by Hyatt.

Clean up of layer scrolling code. Now we can clearly define what to do if a rectangle is fully visible, partially visible, or hidden.
This also fixes a bug with the previous implementation where nested layers/frames would get passed a rect that was too large.

Added fast/overflow/scrollRevealButton.html

• khtml/rendering/render_layer.h: (khtml::RenderLayer::): Added ScrollBehavior enum, ScrollAlignment struct, and ScrollAlignment static members to describe specific scrolling behaviors depending on how visible the rectangle is. In the future, we can add other statics to easily describe desired behaviors.
• khtml/rendering/render_layer.cpp: (khtml::): initialize ScrollAlignment static members: alignCenterIfNeeded, alignToEdgeIfNeeded, alignCenterAlways, alignTopAlways, alignBottomAlways (khtml::RenderLayer::scrollRectToVisible): alignCenterIfNeeded is the default behavior for both directions. Pass the original rect (adjusted if scrolling has occurred) when recursively calling this function. (khtml::RenderLayer::getRectToExpose): Adjusted for new ScrollAlignment parameters.
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Use the node's rect to determine where to scroll. We used to just use the origin, but this helps us match other browsers better. (KHTMLPart::setActiveNode): Removed scrolling code, since this is now also done in setFocusNode
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Removed scrolling code, since this is now also done in setFocusNode (KWQKHTMLPart::centerSelectionInVisibleArea): Use new ScrollAlignment values to describe scrolling behavior.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): ditto.
• kwq/KWQScrollView.h: Removed ensureRectVisible, since we no longer use this.
• kwq/KWQScrollView.mm: ditto.
• khtml/khtmlview.cpp: (KHTMLView::doAutoScroll): Removed unnecessary nil checks for enclosingLayer (KHTMLView::focusNextPrevNode): ditto.

10:47 AM Changeset in webkit [11037] by sullivan

• 3 edits in trunk/WebKitTools

Reviewed by Darin.

• Scripts/run-safari: changed message to say "Starting Safari" instead of odd "Start Safari"
• Scripts/run-webkit-tests: changed the way we pass the file parameter to use -NSOpen rather than relying on unlabeled arguments being treated as files. This was failing on some machines that (mysteriously) had NSTreatUnknownArgumentsAsOpen set to NO in com.apple.Safari.plist.

10:16 AM Changeset in webkit [11036] by harrison

• 2 edits
  6 adds in trunk/LayoutTests

Other files that should have been included with my previous commit.

• editing/editing.js:
• editing/inserting/insert-br-quoted-001-expected.checksum: Added.
• editing/inserting/insert-br-quoted-002-expected.checksum: Added.
• editing/inserting/insert-br-quoted-003-expected.checksum: Added.
• editing/inserting/insert-br-quoted-004-expected.checksum: Added.
• editing/inserting/insert-br-quoted-005-expected.checksum: Added.
• editing/inserting/insert-br-quoted-006-expected.checksum: Added.

10:13 AM Changeset in webkit [11035] by ggaren

• 1 edit
  2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5602
REGRESSION: RegExp("[
^{s$]+", "g") returns extra matches}

• fast/js/regexp-lastindex.html: Added.
• fast/js/regexp-lastindex-expected.txt: Added.

10:11 AM Changeset in webkit [11034] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by darin.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5602 REGRESSION: RegExp("[
  ^{s$]+", "g") returns extra matches}

We now update lastIndex relative to the start of the last match,
rather than the start of the last search. We used to assume that
the two were equal, but that may not be the case in $ matches.

• kjs/regexp_object.cpp: (RegExpProtoFuncImp::callAsFunction):

2:28 AM Changeset in webkit [11033] by eseidel

• 187 edits
  70 adds
  46 deletes in /

Bug #: 3249
Submitted by: eseidel
Reviewed by: none, intermediate branch only.

first steps in KDOM -> DOM merger.

Integration issues:

• Headers (temporarily every kdom header maps to all webcore headers)
• Namespace mapping (KDOM -> DOM, khtml)
• Various KDOM stub classes (temporary)
• Various DOMStringImpl -> DOMString changes
• DOMString::string() -> DOMString::qstring()
• DOMString::handle() -> DOMString::impl()
• DocumentImpl, DocumentType ::impl() -> ::implentation()
• Moving NodeImpl::Id to QualifiedString/AtomicString
• SVGNames.*, SVGElementFactory.* (and perl script to generate them)
• EventImpl::id() -> type() with AtomicString, removal of SVGEventImpl
• Adding svg document and event creation in xml_docimpl.h
• Cleanup event dispatch, in SVGDocumentImpl, using SharedPtr
• exceptioncode additions, for appendNode, createEvent, dispatchEvent, etc.
• Mapped KSVGPart, KDOMPart, KSVGView, KDOMView to KHTMLPart, KHTMLView
• Removed all throw calls, replacing with exceptioncode parameters
• SVGElement derives from StyledElementImpl for now.
• Removed CDFInterface (for now)

Outstanding:

• DocumentBuilder vs. Tokenizer
• Merger of the Ecma systems
• CSS Parsing systems
• Event dispatch/Listening issues
• Merge KSVGView properties into KHTMLView
• requestDocument & CachedDocument vs. requestFrame and CachedObject...

2:28 AM Changeset in webkit [11032]

• 1 copy
  11 deletes in branches/kdom-dom-merger

This commit was manufactured by cvs2svn to create branch
'kdom-dom-merger'.

Nov 2, 2005:

6:21 PM Changeset in webkit [11031] by harrison

• 1 edit
  18 adds in trunk/LayoutTests

Reviewed by Justin.

Tests for...
<rdar://problem/4017861> in reply, extra line is inserted after pressing return on blank quoted line

• editing/editing.js:
• editing/inserting/insert-br-quoted-001-expected.png: Added.
• editing/inserting/insert-br-quoted-001-expected.txt: Added.
• editing/inserting/insert-br-quoted-001.html: Added.
• editing/inserting/insert-br-quoted-002-expected.png: Added.
• editing/inserting/insert-br-quoted-002-expected.txt: Added.
• editing/inserting/insert-br-quoted-002.html: Added.
• editing/inserting/insert-br-quoted-003-expected.png: Added.
• editing/inserting/insert-br-quoted-003-expected.txt: Added.
• editing/inserting/insert-br-quoted-003.html: Added.
• editing/inserting/insert-br-quoted-004-expected.png: Added.
• editing/inserting/insert-br-quoted-004-expected.txt: Added.
• editing/inserting/insert-br-quoted-004.html: Added.
• editing/inserting/insert-br-quoted-005-expected.png: Added.
• editing/inserting/insert-br-quoted-005-expected.txt: Added.
• editing/inserting/insert-br-quoted-005.html: Added.
• editing/inserting/insert-br-quoted-006-expected.png: Added.
• editing/inserting/insert-br-quoted-006-expected.txt: Added.
• editing/inserting/insert-br-quoted-006.html: Added.

6:20 PM Changeset in webkit [11030] by harrison

• 4 edits in trunk/WebCore

Reviewed by Justin.

Tests added in editing/inserting.

<rdar://problem/4017861> in reply, extra line is inserted after pressing return on blank quoted line
Also, did some minor cleanup.

• khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::BreakBlockquoteCommand): (khtml::BreakBlockquoteCommand::doApply): Make sure not to clone parent of skipped BR unless there are siblings to move over.
• khtml/editing/break_blockquote_command.h:
• khtml/editing/jsediting.cpp:

10:54 AM Changeset in webkit [11029] by vicki

• 4 edits in trunk/WebCore

Reviewed by Darin.

• fix <rdar://problem/4303587> REGRESSION (TOT): Scrollwheel doesn't work on frameset pages (5450)

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): set _currentEvent to the wheel event (KWQKHTMLPart::passWheelEventToChildWidget): New. Pass the event to the child widget, if we haven't already handled the event
• khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): add passWheelEventToChildWidget check, and accept the event if we're passing to the child widget

12:52 AM Changeset in webkit [11028] by hyatt

• 24 edits in trunk/WebCore

Fix for 5587, implement pre-wrap and pre-line white-space values.

Reviewed by mjs

Tests Added in fast/text/whitespace

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
• khtml/css/cssvalues.in:
• khtml/css/html4.css:
• khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::preGetter): (KJS::HTMLElement::preSetter):
• khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
• khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):
• khtml/editing/visible_units.cpp: (khtml::startOfParagraph): (khtml::endOfParagraph):
• khtml/html/html_blockimpl.cpp: (HTMLPreElementImpl::mapToEntry): (HTMLPreElementImpl::parseMappedAttribute): (HTMLPreElementImpl::wrap): (HTMLPreElementImpl::setWrap):
• khtml/html/html_blockimpl.h:
• khtml/rendering/bidi.cpp: (khtml::checkMidpoints): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::skipNonBreakingSpace): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::setStyle): (khtml::RenderBlock::calcMinMaxWidth): (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::RenderBlock::dump):
• khtml/rendering/render_block.h:
• khtml/rendering/render_layer.h: (khtml::):
• khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration):
• khtml/rendering/render_object.cpp: (RenderObject::tabWidth):
• khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::autoWrap): (khtml::RenderStyle::preserveNewline): (khtml::RenderStyle::collapseWhiteSpace): (khtml::RenderStyle::isCollapsibleWhiteSpace): (khtml::RenderStyle::breakOnlyAfterWhiteSpace):
• khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):
• khtml/rendering/render_text.cpp: (RenderText::caretRect): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::width):
• khtml/xml/dom_elementimpl.h: (DOM::):
• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):

Nov 1, 2005:

5:59 PM Changeset in webkit [11027] by tomernic

• 4 edits
  2 adds in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4318632>

I've added a new notification, WebPluginWillPresentNativeUserInterfaceNotification. Plugins are expected to post this
notification before presenting "native UI", such as dialog boxes. A Dashboard client can observe this notification to
hide the Dashboard layer when plugins present external UI.

• English.lproj/StringsNotToBeLocalized.txt: Added "WebPluginWillPresentNativeUserInterface".

• Plugins.subproj/WebPluginsPrivate.h: Added.
• Plugins.subproj/WebPluginsPrivate.m: Added. Declare WebPluginWillPresentNativeUserInterfaceNotification.

• WebKit.xcodeproj/project.pbxproj: Added WebPluginsPrivate.[hm]

• WebKit.exp: Added _WebPluginWillPresentNativeUserInterfaceNotification.

5:41 PM Changeset in webkit [11026] by darin

• 2 edits in trunk/WebKitLibraries

• libWebKitSystemInterface.a: Updated.

4:53 PM Changeset in webkit [12209] by mjs

• 5 edits in trunk/JavaScriptGlue

top level:

Reviewed by: Eric.

<rdar://problem/4324107> get JavaScriptGlue working with TOT JavaScriptCore again

• Makefile.am: re-enable JavaScriptGlue in the build

JavaScriptGlue:

Reviewed by: Eric.

<rdar://problem/4324107> get JavaScriptGlue working with TOT JavaScriptCore again

• reverted all this stuff to use ReferenceList instead of IdentifierSequencedSet

• JSUtils.cpp: (KJSValueToCFTypeInternal):
• JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
• UserObjectImp.cpp: (UserObjectImp::propList):
• UserObjectImp.h:

4:49 PM Changeset in webkit [11025] by hyatt

• 2 edits in trunk/WebCore

Fix for bug 5580, slashdot regression with percentage height
blocks.

Reviewed by darin

Added fast/block/basic/021.html

• khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):

4:41 PM Changeset in webkit [11024] by hyatt

• 2 adds in trunk/LayoutTests/fast/block/basic

Add results for new layout test for slashdot regression

4:27 PM Changeset in webkit [11023] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin Adler.

fixed deployment build by hiding local variables used only in ASSERTs on builds for
which ASSERT_DISABLED is true.

• History.subproj/WebHistory.m: (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]):

2:29 PM Changeset in webkit [11022] by justing

• 3 edits in trunk/WebCore

Reviewed by harrison

Tweaked my previous fix for caret movement while scrolling.

• khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): Forgot to copy m_caretPositionOnLayout. (khtml::SelectionController::operator=): Ditto. (khtml::SelectionController::layout): Initialize m_caretPositionOnLayout to a dummy value when the selection isNone.
• khtml/editing/SelectionController.h: Tweaked my comment.

11:24 AM Changeset in webkit [11021] by sullivan

• 6 edits in trunk/WebKit

Reviewed by Tim Omernick.

• fixed <rdar://problem/4324104> Assertion failure (foundDate) in WebHistory

WebFrame was updating the last visited date on a WebHistoryItem behind WebHistory's
back, causing WebHistory's caches of items by date to get out of sync with reality.
Changed to set the date through WebHistory rather than directly.

• History.subproj/WebHistory.m: (-[WebHistoryPrivate _removeItemFromDateCaches:]): New method, extracted from removeItemForURLString. (-[WebHistoryPrivate removeItemForURLString:]): Now calls extracted method. Cleaned up white space a little. (-[WebHistoryPrivate _addItemToDateCaches:]): New method, extracted from addItem: (-[WebHistoryPrivate addItem:]): Now calls extracted method. Cleaned up white space a little. (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): New method, removes item from date caches, changes date, then adds item back to date caches and sends notification. (-[WebHistory setLastVisitedTimeInterval:forItem:]): New method, cover for WebHistoryPrivate version.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setLastVisitedTimeInterval:]): Don't send notification here; send from new WebHistory method instead.

• History.subproj/WebHistoryItemPrivate.h: Added comment about avoiding incorrect use of _setLastVisitedTimeInterval:
• History.subproj/WebHistoryPrivate.h: Added declarations for WebHistory and WebHistoryPrivate versions of setLastVisitedTimeInterval:forItem:

• WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): change history item's date via new WebHistory method rather than directly

11:20 AM Changeset in webkit [11020] by justing

• 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Tweaked my ChangeLog entry.

11:19 AM Changeset in webkit [11019] by justing

• 2 edits in trunk/WebCore

Reviewed by darin

No test cases added, requires Mail

• kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Crashes were happening after a style was merged with itself. Mail was doing a setTypingStyle with a pointer to our internal typing style. Fix is to only hand out copies of our typingStyle.

11:04 AM Changeset in webkit [11018] by justing

• 5 edits
  1 add in trunk/WebCore

Reviewed by harrison

Fixed <rdar://problem/3690705> caret does not move when scrolling overflow: auto editable area

• manual-tests/caretScrolling.html: Added.

• khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): Removed the unused expectedVisibleRect (khtml::SelectionController::operator=): Ditto. (khtml::SelectionController::layout): Save the caret's absolute position on layout. (khtml::SelectionController::caretRect): Adjust the returned caret rect for offset due to scrolling since the last layout. (khtml::SelectionController::paintCaret):
• khtml/editing/SelectionController.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Small tweak to a previous change.
• kwq/KWQRect.h: (QRect::moveTopLeft): Added.

10:36 AM Changeset in webkit [11017] by thatcher

• 5 edits in trunk/WebCore

Reviewed by Dave Hyatt.
Commited by Tim Hatcher.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5256
Relayout during load causes duplicate plugin part.

This was a problem with <OBJECT>s that contain an <EMBED>, if
layout happened in the middle of the OBJECT but before the EMBED.

No test case added, requires manual testing.

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::closeRenderer): (DOM::HTMLObjectElementImpl::setComplete):
• khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isComplete):
• khtml/html/htmlfactory.cpp: (DOM::objectConstructor):
• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):

9:33 AM Changeset in webkit [11016] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.
Commited by Tim Hatcher.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5541

HTMLNames constants are not yet initialized at Safari startup,
when bookmarks are imported, which caused a crash in Decoder::decode().

• kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]):

9:21 AM Changeset in webkit [11015] by sullivan

• 2 edits in trunk/WebCore

Change by Alexey Proskuryakov, reviewed by Darin Adler.

• kwq/KWQKURL.mm: (encodeRelativeString): don't use strdup, as it has problems with a curly quote in the string

9:02 AM Changeset in webkit [11014] by andersca

• 13 edits in trunk/LayoutTests

2005-11-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

• dom/xhtml/level3/core/nodegettextcontent06-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent07-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent08-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent09-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent10-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent11-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent12-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent13-expected.txt:
• dom/xhtml/level3/core/nodegettextcontent14-expected.txt:
• dom/xhtml/level3/core/nodesettextcontent03-expected.txt:
• dom/xhtml/level3/core/nodesettextcontent12-expected.txt: These now pass.

• dom/xhtml/level3/core/nodegettextcontent17-expected.txt: This still fails, but now because entity references are unsupported.

8:59 AM Changeset in webkit [11013] by andersca

• 6 edits in trunk/WebCore

2005-11-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

• khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty):
• khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add setter and setter for textContent.

• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::textContent): (DOM::NodeImpl::setTextContent):
• khtml/xml/dom_nodeimpl.h: Implement textContent and setTextContent.

• kwq/DOM.mm: (-[DOMNode textContent]): (-[DOMNode setTextContent:]): Add Objective C wrappers.

Oct 31, 2005:

11:25 PM Changeset in webkit [11012] by eseidel

• 1 edit
  4 adds in trunk/LayoutTests

Bug #: 5529
Submitted by: eseidel
Reviewed by: hyatt

Test cases for XLST recursion check.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5529

• fast/xsl/resources/xslt-recursion-chain1.xsl: Added.
• fast/xsl/resources/xslt-recursion-chain2.xsl: Added.
• fast/xsl/xslt-recursion-expected.txt: Added.
• fast/xsl/xslt-recursion.xml: Added.

11:16 PM Changeset in webkit [11011] by eseidel

• 3 edits in trunk/WebCore

Bug #: 5529
Submitted by: eseidel
Reviewed by: hyatt

Now ignores XSLT PIs in documents resulting from transforms.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5529

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::processingInstruction):

2:11 PM Changeset in webkit [11010] by thatcher

• 3 edits in trunk/LayoutTests

Added a correct expected image.

• fast/dom/dom-parse-serialize-display-expected.checksum:
• fast/dom/dom-parse-serialize-display-expected.png:

11:04 AM Changeset in webkit [11009] by harrison

• 3 edits in trunk/WebCore

Remove conditionalized away code added as part of tab character support.

• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::insertTab):
• khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString):

Oct 29, 2005:

10:26 PM Changeset in webkit [11008] by hyatt

• 4 edits in trunk/WebCore

Fix the performance regression caused by doing too much copying of background/border values. This patch attempts to rectify things by doing the following:

(1) Don't initialize the border/background cached values on every single style resolution.
(2) Only cache the border/background values just after user agent styles have been resolved if the user agent set an appearance.
(3) Only check for appearance disabling if you had a UA appearance originally (and then continue to have an appearance after author/user styles have been resolved too)
(4) Make sure to patch the pseudoStyleForElement method too. With the removal of the initialization code for the values running over and over again, I needed to make sure to patch this function to match styleForElement.

Reviewed by sullivan

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::adjustRenderStyle):
• khtml/css/cssstyleselector.h: