⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 29, 2005:

11:38 PM Changeset in webkit [11830] by eseidel
  • 65 edits in trunk/LayoutTests

Bug #: 6155
Submitted by: eseidel
Reviewed by: none, just updating pixel results

Updating results, after landing color-matching change.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/custom/conditional-processing-outside-switch-expected.checksum:
  • svg/custom/conditional-processing-outside-switch-expected.png:
  • svg/custom/control-points-for-S-and-T-expected.checksum:
  • svg/custom/control-points-for-S-and-T-expected.png:
  • svg/custom/fill-update-expected.checksum:
  • svg/custom/fill-update-expected.png:
  • svg/custom/junk-data-expected.checksum:
  • svg/custom/junk-data-expected.png:
  • svg/custom/missing-xlink-expected.checksum:
  • svg/custom/missing-xlink-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • svg/custom/path-update-expected.checksum:
  • svg/custom/path-update-expected.png:
  • svg/custom/simpleCDF-expected.checksum:
  • svg/custom/simpleCDF-expected.png:
  • svg/custom/simpleCDF-expected.txt:
  • svg/custom/transform-ignore-after-invalid-expected.checksum:
  • svg/custom/transform-ignore-after-invalid-expected.png:
  • svg/custom/transform-ignore-after-invalid.svg:
  • svg/custom/transform-invalid-expected.checksum:
  • svg/custom/transform-invalid-expected.png:
  • svg/custom/transform-with-ending-space-expected.checksum:
  • svg/custom/transform-with-ending-space-expected.png:
  • svg/custom/use-forward-refs-expected.checksum:
  • svg/custom/use-forward-refs-expected.png:
11:33 PM Changeset in webkit [11829] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel

WebCore+SVG has some problems with rounded rectangles
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

  • svg/custom/rounded-rects-expected.checksum: Added.
  • svg/custom/rounded-rects-expected.png: Added.
  • svg/custom/rounded-rects-expected.txt: Added.
  • svg/custom/rounded-rects.svg: Added.
11:05 PM Changeset in webkit [11828] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric, committed by Maciej.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Use previous character from the buffer instead of ch which may be uninitialized on the first iteration.
11:04 PM Changeset in webkit [11827] by eseidel
  • 3 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Move WebView width/height logic into DumpRenderTree to support
running the W3C SVG 1.1 tests along side other tests. The W3C
SVG 1.1 tests require a 480x360 view.

  • DumpRenderTree/DumpRenderTree.m: (main): don't accept width/height (dump): override width/height for SVG/W3C
  • Scripts/run-webkit-tests: don't pass width/height
10:46 PM Changeset in webkit [11826] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and refined by Darin.

  • fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • fast/css/margin-top-bottom-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

  • khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues): Set all margin values in all cases.
10:43 PM Changeset in webkit [11825] by eseidel
  • 1 edit
    1 delete in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: No review, only removing dead code.

  • DumpKCanvasTree/DumpKCanvasTree.m: Removed.
  • DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.
10:38 PM Changeset in webkit [11824] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 6155
Submitted by: eseidel
Reviewed by: darin

DumpRenderTree should set a consistent color profile while running
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

Creates consistent colormatched renderings on every test machine
using the only way possible with Tiger APIs: by setting the
system color profile on the test machine for the duration of the
tests. This will (unfortunately) cause colors to change while
running DumpRenderTree. This can also cause "permanent" color
changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
This is far from ideal, but it's be best way we've found to deal
with the issue for now.

  • DumpRenderTree/DumpRenderTree.m: (restoreColorSpace): (setDefaultColorProfileToRGB): (main):
9:51 PM Changeset in webkit [11823] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs

XML documents with "html" in dtd name use XHTML entities when they shouldn't
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

  • fast/parser/xhtml-alternate-entities-expected.txt: Added.
  • fast/parser/xhtml-alternate-entities.xml: Added.
9:43 PM Changeset in webkit [11822] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs

XML documents with "html" in dtd name use XHTML entities when they shouldn't
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

  • khtml/xml/xml_tokenizer.cpp: (khtml::externalSubsetHandler): check for exact xhtml types
9:40 PM Changeset in webkit [11821] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6295
Submitted by: eseidel
Reviewed by: mjs

Close leak in CollectionInfo due to HashMap migration
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6295

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
  • khtml/html/html_miscimpl.h:
9:33 PM Changeset in webkit [11820] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6101
Submitted by: eseidel
Reviewed by: mjs

Leaks in XSLTProcessorImpl due to early exit in failure case
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6101

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xmlDocPtrFromNode): add "shouldDelete" argument (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
9:11 PM Changeset in webkit [11819] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Eric.

  • kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol since it is not actually used.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Removed (this was unused)
  • WebView.subproj/WebFrame.m: (-[WebFrame _removeChild::]): Moved to FrameTraversal category. (-[WebFrame _childFrameCount]): New frame traversal method to avoid getting the count from the array directly. (-[WebFrame _appendChild:]): Factored out the parts of addChild: that seem directly relevant to adding a child. (-[WebFrame _removeChild:]): Moved to FrameTraversal category. (-[WebFrame _detachChildren]): Don't deallocate children array because there's no particular need to. (-[WebFrame _setDataSource:]): make the assert use _childFrameCount (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting from the main frame, check this frame and all ancestors. If a resource for a frame completes, that con only possibly finish loading for that frame and its ancestors, not any other frame in the tree. (-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed. (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new approved way. (-[WebFrame _internalChildFrames]): removed (-[WebFrame _addChild:]): Use _appendChild: for most of the work. (-[WebFrame _generateFrameName]): Get child frame count in the new approved way. (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms, upon further consideration there's no need to copy part of the frame tree here. (-[WebFrame findFrameNamed:]): Remove extra braces. (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
  • WebView.subproj/WebFramePrivate.h: Remove some methods.
  • WebView.subproj/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current frame not the main frame (before there was no difference and now the new version is what is desired).
  • WebView.subproj/WebView.m: (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces and update FIXME comment. (-[WebView _receivedError:fromDataSource:]): Remove stray space
8:11 PM Changeset in webkit [11818] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6230
Submitted by: eseidel
Reviewed by: build fix only.

File accidentally omitted from previous commit.

Remove QDict from khtml/html
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6230

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLCollection::getNamedItems):
7:33 PM Changeset in webkit [11817] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6230
Submitted by: eseidel
Reviewed by: mjs

Remove QDict from khtml/html
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
Uses HashMap instead.

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo): (DOM::HTMLCollectionImpl::CollectionInfo::reset): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLCollectionImpl::updateNameCache): (DOM::HTMLCollectionImpl::namedItems): (DOM::HTMLCollectionImpl::nextNamedItem): (DOM::HTMLFormCollectionImpl::nextNamedItemInternal): (DOM::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/html_miscimpl.h:
7:27 PM Changeset in webkit [11816] by eseidel
  • 15 edits in trunk/WebCore

Bug #: 6228
Submitted by: eseidel
Reviewed by: mjs

DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
Added find(), contains(), startsWith() and endsWith() to DOMString
Uses the above functions throughout the code.
Small performance boost.

  • khtml/css/css_base.cpp: (CSSSelector::print):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSImportRuleImpl::init):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::setProperty):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::parseContent):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::setEncodedURL): (khtml::parseUASheet): (khtml::cleanpath): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSRuleSet::addRulesFromSheet): (khtml::CSSStyleSelector::applyProperty):
  • khtml/dom/dom_string.cpp:
  • khtml/dom/dom_string.h: (DOM::DOMString::contains): (DOM::DOMString::find): (DOM::DOMString::startsWith): (DOM::DOMString::endsWith):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseEnctype):
  • khtml/khtml_part.cpp: (KHTMLPart::requestFrame): (KHTMLPart::submitForm):
  • khtml/misc/decoder.cpp: (Decoder::decode):
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::length): (DOM::AtomicString::operator []): (DOM::AtomicString::contains): (DOM::AtomicString::find): (DOM::AtomicString::startsWith): (DOM::AtomicString::endsWith):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_stringimpl.cpp: (DOM::equal): (DOM::equalCaseInsensitive): (DOM::DOMStringImpl::find): (DOM::DOMStringImpl::endsWith):
  • khtml/xml/dom_stringimpl.h: (DOM::DOMStringImpl::startsWith):
7:23 PM Changeset in webkit [11815] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel

WebCore+SVG has some problems with rounded rectangles
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

  • ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::toPathData): fixed round rect calculations
6:42 PM Changeset in webkit [11814] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
Support HTML entities on pages parsed as XHTML

  • fast/parser/entities-in-xhtml-expected.txt: Added.
  • fast/parser/entities-in-xhtml.xhtml: Added.
4:43 PM Changeset in webkit [11813] by ggaren
  • 4 edits
    5 adds in trunk/LayoutTests

Updated test results for the last few JavaScriptCore patches
I checked in.

  • ChangeLog:
  • fast/js/array-float-delete-expected.txt: Added.
  • fast/js/kde/Date-expected.txt:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/StringObject-expected.txt:
4:37 PM Changeset in webkit [11812] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Rewrote most of the frame traversal code in WebFrame to use DOM-style
first/last/next/previous methods, to abstract access better in preparation
for moving it down.

As an added bonus, many formerly recursive methods are now iterative.

  • WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that variables can be declared in for loop initializers.
  • added new frame traversal methods, to avoid dealing with the children array directly:
  • WebView.subproj/WebFrame.m: (-[WebFrame _firstChildFrame]): New method. (-[WebFrame _lastChildFrame]): New method. (-[WebFrame _previousSiblingFrame]): New method. (-[WebFrame _nextSiblingFrame]): New method. (-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM; uses some of the previous.
  • apply the new methods

(-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
to use new traversal methods.
(-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
(-[WebFrame _setName:]): Improved comment, removed gratuitous brace
(-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
of looking in child arrays (duh)
(-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
still walk backwards for now.
(-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
(-[WebFrame _childFramesMatchItem:]): ditto
(-[WebFrame _defersCallbacksChanged]): ditto
(-[WebFrame _viewWillMoveToHostWindow:]): ditto
(-[WebFrame _viewDidMoveToHostWindow]): ditto
(-[WebFrame _addChild:]): don't use childFrames method
(-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list,
not obvious if anything needs this but it seems like the right thing to do.
(-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
calling count on nil still gives 0.
(-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
(-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
traversal methods.
(-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
a thin wrapper on _traverseNextFrameStayWithin:
(-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
(-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
(-[WebFrame _reloadForPluginChanges]): ditto
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _documentViews]): ditto
(-[WebFrame _updateDrawsBackground]): ditto
(-[WebFrame _unmarkAllMisspellings]): ditto
(-[WebFrame _atMostOneFrameHasSelection]): ditto
(-[WebFrame _findFrameWithSelection]): ditto
(-[WebFrame _stopLoadingSubframes]): ditto
(-[WebFrame _subframeIsLoading]): ditto
(-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto

3:49 PM Changeset in webkit [11811] by eseidel
  • 4 edits
    1 add in trunk/WebCore

Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel, ggaren, darin

Added layout tests:

  • fast/parser/entities-in-xhtml.xhtml
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML. (khtml::XMLTokenizer::isXHTMLDocument): Ditto. (khtml::externalSubsetHandler): Ditto. (khtml::XMLTokenizer::finish): Ditto. (khtml::getXHTMLEntity): Look up the HTML entity. (khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
  • khtml/html/kentities.h: Added.
  • khtml/html/kentities.gperf: changed entity to Entity
2:02 PM Changeset in webkit [11810] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]): Removed unused "draggingTypes" instance variable.
1:59 PM Changeset in webkit [11809]
  • 212 copies
    17 deletes in tags/WebCore-417~18

This commit was manufactured by cvs2svn to create tag
'WebCore-417~18'.

1:59 PM Changeset in webkit [11808] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.18

3:51 AM Changeset in webkit [11807] by ggaren
  • 2 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, reviewed and landed by me.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
3:45 AM Changeset in webkit [11806] by ggaren
  • 3 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, Reviewed and landed by me.

  • kjs/number_object.cpp:
  • kjs/regexp_object.cpp:
3:38 AM Changeset in webkit [11805] by ggaren
  • 3 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, reviewed by mjs.

This has 2 very minor fixes, covered by KJS testsuite:

  1. Enumerates string indices in property list (with the same bug as array object has in corresponding code). This is a mozilla emulation thing.
  2. Permits properties with integer names in prototypes to be found
  • kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): (StringInstanceImp::propList):
  • kjs/string_object.h:
3:30 AM Changeset in webkit [11804] by ggaren
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRenderer.m

forgot to remove the redundant (float) cast, as specified by reviewer

3:27 AM Changeset in webkit [11803] by ggaren
  • 4 edits in trunk

WebCore:

Reviewed by darin

  • khtml/rendering/font.h: (khtml::Font::checkSelectionPoint): Make sure the complete run, used for counting spaces and determining padding per space does not go beyond the text box.

WebKit:

Reviewed by darin

Test: fast/text/atsui-spacing-features.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Add letter- and word-spacing and padding for justification. (createATSULayoutParameters): Compute padding per space.
3:16 AM Changeset in webkit [11802] by ggaren
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by mjs.

This patch does four things:
(1) Standardizes all our linked list nodes to use "next" as their next
pointers.
(2) Creates the ListRefPtr<T> class, a subclass of RefPtr<T> specialized
to iteratively deref "next" pointers.
(3) Standardizes our linked list nodes to use ListRefPtr<T> and
implement the releaseNext() function used by ~ListRefPtr<T>().
(4) Adds to RefPtr<T> the release() method used by releaseNext().

  • Modified existing mozilla test to ensure it would make deployment builds crash as well.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/nodes.cpp: (ElementNode::evaluate): (PropertyListNode::evaluate): (ArgumentListNode::evaluateList): (StatListNode::StatListNode): (StatListNode::execute): (StatListNode::processVarDecls): (VarDeclListNode::evaluate): (VarDeclListNode::processVarDecls): (VarStatementNode::execute): (VarStatementNode::processVarDecls): (BlockNode::BlockNode): (CaseClauseNode::evalStatements): (CaseClauseNode::processVarDecls): (ClauseListNode::processVarDecls): (CaseBlockNode::CaseBlockNode): (CaseBlockNode::evalBlock): (SourceElementsNode::SourceElementsNode): (SourceElementsNode::execute): (SourceElementsNode::processFuncDecl): (SourceElementsNode::processVarDecls):
  • kjs/nodes.h: (KJS::ElementNode::ElementNode): (KJS::ElementNode::releaseNext): (KJS::ArrayNode::ArrayNode): (KJS::PropertyListNode::PropertyListNode): (KJS::PropertyListNode::releaseNext): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentListNode::releaseNext): (KJS::ArgumentsNode::ArgumentsNode): (KJS::StatListNode::releaseNext): (KJS::VarDeclListNode::VarDeclListNode): (KJS::VarDeclListNode::releaseNext): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ClauseListNode::getClause): (KJS::ClauseListNode::getNext): (KJS::ClauseListNode::releaseNext): (KJS::ParameterNode::ParameterNode): (KJS::ParameterNode::releaseNext): (KJS::SourceElementsNode::releaseNext):
  • kjs/nodes2string.cpp: (ElementNode::streamTo): (PropertyListNode::streamTo): (ArgumentListNode::streamTo): (StatListNode::streamTo): (VarDeclListNode::streamTo): (VarStatementNode::streamTo): (CaseClauseNode::streamTo): (ClauseListNode::streamTo): (CaseBlockNode::streamTo): (SourceElementsNode::streamTo):
  • kxmlcore/ListRefPtr.h: Added. (KXMLCore::ListRefPtr::ListRefPtr): (KXMLCore::ListRefPtr::~ListRefPtr): (KXMLCore::ListRefPtr::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::release):
3:02 AM Changeset in webkit [11801] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by mjs.

Added call to sranddev() -- it executes the first time a process
calls Math.random().

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
2:36 AM Changeset in webkit [11800] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by mjs.

We had code that checked for whether a call came from a live PlugIn,
but the live PlugIn dictionary would only get cleared when the
KWQKHTMLPart was destroyed. Since a single part can service multiple
loads, the dictionary needs to clear after each one.

No layout test because this bug is difficult to reproduce.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (1) Unrelated cleanup: Removed manual clearing of form values, replaced with call to clearRecordedFormValues(). (2) Replaced PlugIn dictionary cleanup code and view deref call with call to setView(0), since much of this code was duplicated in setView, and the stuff that wasn't duplicated needed to be.

(KWQKHTMLPart::setView):
(1) Removed some unnecessary braces.
(2) Added PlugIn dictionary cleanup code.
(3) New behavior: clear _bindingRoot and _windowScriptObject after
each view change. This is needed because after a call to
clenaupPluginRootObjects(), both objects have stale references.
(4) Changed a NULL to a 0.

(KWQKHTMLPart::cleanupPluginRootObjects): Removed extra space.

2:11 AM Changeset in webkit [11799] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Changed strings passed to Java back to original "JSObject".

  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
12:58 AM Changeset in webkit [11798] by hyatt
  • 3 edits
    2 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Improvements to the Visual Studio project files. Have dftables generating chartables.c and have set up separate intermediate/output/derivedsources dirs to match the Mac XCode structure.

12:22 AM Changeset in webkit [11797] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • fast/dom/undetectable-document-all-expected.txt: Added.
  • fast/dom/undetectable-document-all.html: Added.
12:20 AM Changeset in webkit [11796] by andersca
  • 3 edits in trunk/WebCore

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::getValueProperty): If "all" has been set to a new value, return the new value.

(KJS::KJS::HTMLDocument::putValueProperty):
Allow "all" to be set to a new value.

(KJS::HTMLAllCollection::toPrimitive):
Return jsNull() if the preferred type is NullType.

(KJS::getAllHTMLCollection):

  • khtml/ecma/kjs_html.h: (KJS::HTMLAllCollection::HTMLAllCollection): Add HTMLAllCollection, a subclass of HTMLCollection which should be undetectable.

(KJS::HTMLAllCollection::toBoolean):
Return false.

12:18 AM Changeset in webkit [11795] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/operations.cpp: (KJS::equal): When comparing an object with null or undefined, call toPrimitive with NullType as the preferred type.

Dec 28, 2005:

11:02 AM Changeset in webkit [11794] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Eric, landed by ap.

  • fast/block/basic/text-indent-rtl-expected.checksum: Added.
  • fast/block/basic/text-indent-rtl-expected.png: Added.
  • fast/block/basic/text-indent-rtl-expected.txt: Added.
  • fast/block/basic/text-indent-rtl.html: Added.
10:59 AM Changeset in webkit [11793] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by ap.

Test: fast/block/basic/text-indent-rtl.html

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::rightRelOffset): Subtract the indent instead of adding it.
10:48 AM Changeset in webkit [11792] by ap
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin, landed by ap.

  • fast/dom/HTMLScriptElement/resources/script-load.js: Added.
  • fast/dom/HTMLScriptElement/script-load-events-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-load-events.html: Added.
10:46 AM Changeset in webkit [11791] by ap
  • 8 edits in trunk/WebCore

Reviewed by Darin, landed by ap.

Test: fast/dom/HTMLScriptElement/script-load-events.html

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Parse the onload and onerror attributes. (HTMLScriptElementImpl::closeRenderer): Call base class's implementation. (HTMLScriptElementImpl::notifyFinished): Dispatch load and error events.
  • khtml/html/htmlparser.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Return the node that was inserted.
  • khtml/html/htmltokenizer.h: Added scriptNode, a RefPtr to the node corresponding to the current load request.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): Reset scriptNode if a load request was not made. (HTMLTokenizer::parseTag): Set scriptNode to the node created from the script tag. (HTMLTokenizer::processToken): Return the node that was inserted. (HTMLTokenizer::notifyFinished): Reset scriptNode and dispatch load and error events.
  • khtml/misc/loader.h: (CachedScript::errorOccurred): Added.
  • khtml/misc/loader.cpp: (CachedScript::CachedScript): (CachedScript::error):
10:23 AM Changeset in webkit [11790] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

  • editing/input/range-for-empty-document-expected.txt: Added.
  • editing/input/range-for-empty-document.html: Added.
10:21 AM Changeset in webkit [11789] by ap
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: editing/input/range-for-empty-document.html

  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Handle the case of an empty document and (0, 0) requested range.
10:18 AM Changeset in webkit [11788] by ggaren
  • 2 edits in trunk/WebCore

Reviewed and landed by Geoff.

  • khtml/rendering/render_text.cpp: (khtml::RenderText::setText): Remove deref().

Dec 27, 2005:

7:47 PM Changeset in webkit [11787] by mjs
  • 3 edits in trunk/LayoutTests

Rubber stamped by Eric.

  • proper length for Array concat function is 1, not 0; also add test for String concat.
  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/resources/function_length.js:
12:06 PM Changeset in webkit [11786] by andersca
  • 5 edits in trunk/LayoutTests

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/array-every-expected.txt:
  • fast/js/array-every.html:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Modify these tests since Array.every and Array.foreach now follow Mozilla and treat arrays as sparse, not visiting non-existing properties.
12:02 PM Changeset in webkit [11785] by andersca
  • 4 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement filter and map. Also, make the existing array iteration functions not invoke the callback for non-existing properties, just as Mozilla does now.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Add filter and map.
  • tests/mozilla/expected.html: Update, two 1.6 tests now pass.
11:13 AM Changeset in webkit [11784] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the size changed and not everything was repainted.
  • manual-tests/bugzilla-5699.html: Added.
11:06 AM Changeset in webkit [11783] by darin
  • 25 edits in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
  • fast/text/international/bidi-AN-after-L-expected.png: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.png: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
  • fast/text/international/bidi-innertext-expected.checksum: Updated.
  • fast/text/international/bidi-innertext-expected.png: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
  • fast/text/international/bidi-override-expected.checksum: Updated.
  • fast/text/international/bidi-override-expected.png: Updated.

WebKit:

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
10:39 AM Changeset in webkit [11782] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • fast/replaced/absolute-image-sizing-expected.png: Added.
  • fast/replaced/absolute-image-sizing-expected.txt: Added.
  • fast/replaced/absolute-image-sizing.html: Added.

WebCore:

Reviewed by Maciej, landed by Darin.

Added layout tests:

  • fast/replaced/absolute-image-sizing.html
  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth() for replaced elements. (RenderBox::calcAbsoluteVerticalValues): Same thing for height.
10:26 AM Changeset in webkit [11781] by darin
  • 8 edits in trunk/WebCore

Reviewed by Geoff and Eric.

  • khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token. Also removed use of bitfields in Token, since there's no need to optimize storage here.
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Update for use of RefPtr in Token. (HTMLParser::textCreateErrorCheck): Ditto. (HTMLParser::commentCreateErrorCheck): Ditto. (HTMLParser::handleIsindex): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): Ditto. (khtml::HTMLTokenizer::processToken): Ditto.
  • khtml/rendering/render_text.h: Reduce the number of includes, change SOFT_HYPHEN from a macro into a constant. Change originalString function to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr member be a RefPtr.
  • khtml/rendering/render_text.cpp: (khtml::RenderText::previousOffset): Update for use of RefPtr for str. (khtml::RenderText::nextOffset): Ditto. (khtml::RenderText::RenderText): Ditto. (khtml::RenderText::originalString): Change to return PassRefPtr, even though it's not necessary at this level (since it's a virtual function). (khtml::RenderText::posOfChar): Update for use of RefPtr for str. (khtml::RenderText::setText): Ditto. (khtml::RenderTextFragment::RenderTextFragment): Ditto. (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.
  • khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
  • kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer included by render_text.h.
10:05 AM Changeset in webkit [11780] by darin
  • 2 edits in trunk/WebCore

Fix suggested by Mitz.

  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions): Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part of my fix for clientX/Y in the original patch.
4:56 AM Changeset in webkit [11779] by mjs
  • 2 edits in trunk/JavaScriptCore
  • updated test results for new JS 1.6 tests
  • tests/mozilla/expected.html:
4:29 AM Changeset in webkit [11778] by andersca
  • 1 edit
    27 adds in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

Add Mozilla JS 1.6 tests.

  • tests/mozilla/js1_6/Array/browser.js: Added.
  • tests/mozilla/js1_6/Array/regress-290592.js: Added.
  • tests/mozilla/js1_6/Array/regress-304828.js: Added.
  • tests/mozilla/js1_6/Array/regress-305002.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
  • tests/mozilla/js1_6/Array/regress-320887.js: Added.
  • tests/mozilla/js1_6/Array/shell.js: Added.
  • tests/mozilla/js1_6/README: Added.
  • tests/mozilla/js1_6/Regress/browser.js: Added.
  • tests/mozilla/js1_6/Regress/regress-301574.js: Added.
  • tests/mozilla/js1_6/Regress/regress-309242.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
  • tests/mozilla/js1_6/Regress/regress-314887.js: Added.
  • tests/mozilla/js1_6/Regress/regress-320172.js: Added.
  • tests/mozilla/js1_6/Regress/shell.js: Added.
  • tests/mozilla/js1_6/String/browser.js: Added.
  • tests/mozilla/js1_6/String/regress-306591.js: Added.
  • tests/mozilla/js1_6/String/shell.js: Added.
  • tests/mozilla/js1_6/browser.js: Added.
  • tests/mozilla/js1_6/shell.js: Added.
  • tests/mozilla/js1_6/template.js: Added.
4:24 AM Changeset in webkit [11777] by mjs
  • 6 edits in trunk/LayoutTests

No review, just a test harness change.

  • avoid bombing out if a shouldBe test case unexpectedly throws an exception
  • fast/js/kde/resources/base.js:
  • this lets some of the tests get a bit further, so new results:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/parse-expected.txt:
4:05 AM Changeset in webkit [11776] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/forms/button-in-forms-collection-expected.txt: Added.
  • fast/forms/button-in-forms-collection.html: Added.

WebCore:

Reviewed and landed by Maciej.

Test: fast/forms/button-in-forms-collection.html

  • khtml/html/html_formimpl.h: (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
3:07 AM Changeset in webkit [11775] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed and landed by Maciej.

  • kjs/array_object.cpp: (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when looking for array properties.

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/js/array-float-delete.html: Added.
2:35 AM Changeset in webkit [11774] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.cpp: (KJS::JSObject::defineSetter): Remove duplicate call to putDirect.
1:24 AM Changeset in webkit [11773] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

Changes by me and Anders.

  • also fixed some warnings reported by -Winline
  • JavaScriptCorePrefix.h: Move new and delete definitions higher so there aren't conflicts with use in standard C++ headers
  • kjs/object.cpp: (KJS::throwSetterError): Moved this piece of put into a seprate function to avoid the PIC branch. (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff when not needed. Also use GetterSetter properties attribute. (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter properties any more, if this one was one. (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter properties now (and use the new attribute). (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot, to avoid global variable access in the hot code path.
  • kjs/object.h: (KJS::): Added GetterSetter attribute. (KJS::JSCell::isObject): Moved lower to be after inline methods it uses. (KJS::JSValue::isObject): ditto (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters as much as possible in the case where they are not being used
  • kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): Ditto (KJS::PropertyMap::setHasGetterSetterProperties): Ditto (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the global "has getter/setter properties" flag in the property map single entry, to avoid making objects any bigger.
  • kjs/value.h: Moved some things to object.h to make -Winline happier

Dec 26, 2005:

3:33 PM Changeset in webkit [11772] by hyatt
  • 5 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the beginnings of a VC 2005 project for JSCore dll.

3:07 PM Changeset in webkit [11771] by mjs
  • 1 edit
    162 adds in trunk/LayoutTests

Rubber stamped by Geoff.

  • land JavaScript tests from the kde version of kjs
  • fast/js/kde/Array-expected.txt: Added.
  • fast/js/kde/Array.html: Added.
  • fast/js/kde/Boolean-expected.txt: Added.
  • fast/js/kde/Boolean.html: Added.
  • fast/js/kde/Date-expected.txt: Added.
  • fast/js/kde/Date.html: Added.
  • fast/js/kde/Error-expected.txt: Added.
  • fast/js/kde/Error.html: Added.
  • fast/js/kde/GlobalObject-expected.txt: Added.
  • fast/js/kde/GlobalObject.html: Added.
  • fast/js/kde/Number-expected.txt: Added.
  • fast/js/kde/Number.html: Added.
  • fast/js/kde/Object-expected.txt: Added.
  • fast/js/kde/Object.html: Added.
  • fast/js/kde/Prototype-expected.txt: Added.
  • fast/js/kde/Prototype.html: Added.
  • fast/js/kde/RegExp-expected.txt: Added.
  • fast/js/kde/RegExp.html: Added.
  • fast/js/kde/StringObject-expected.txt: Added.
  • fast/js/kde/StringObject.html: Added.
  • fast/js/kde/assignments-expected.txt: Added.
  • fast/js/kde/assignments.html: Added.
  • fast/js/kde/cast-expected.txt: Added.
  • fast/js/kde/cast.html: Added.
  • fast/js/kde/comment-1-expected.txt: Added.
  • fast/js/kde/comment-1.html: Added.
  • fast/js/kde/comment-2-expected.txt: Added.
  • fast/js/kde/comment-2.html: Added.
  • fast/js/kde/completion-expected.txt: Added.
  • fast/js/kde/completion.html: Added.
  • fast/js/kde/conditional-expected.txt: Added.
  • fast/js/kde/conditional.html: Added.
  • fast/js/kde/const-expected.txt: Added.
  • fast/js/kde/const.html: Added.
  • fast/js/kde/constructor_length-expected.txt: Added.
  • fast/js/kde/constructor_length.html: Added.
  • fast/js/kde/crash-1-expected.txt: Added.
  • fast/js/kde/crash-1.html: Added.
  • fast/js/kde/crash-2-expected.txt: Added.
  • fast/js/kde/crash-2.html: Added.
  • fast/js/kde/delete-expected.txt: Added.
  • fast/js/kde/delete.html: Added.
  • fast/js/kde/empty-expected.txt: Added.
  • fast/js/kde/empty.html: Added.
  • fast/js/kde/encode_decode_uri-expected.txt: Added.
  • fast/js/kde/encode_decode_uri.html: Added.
  • fast/js/kde/eval-expected.txt: Added.
  • fast/js/kde/eval.html: Added.
  • fast/js/kde/evil-n-expected.txt: Added.
  • fast/js/kde/evil-n.html: Added.
  • fast/js/kde/exception_propagation-expected.txt: Added.
  • fast/js/kde/exception_propagation.html: Added.
  • fast/js/kde/exceptions-expected.txt: Added.
  • fast/js/kde/exceptions.html: Added.
  • fast/js/kde/function-expected.txt: Added.
  • fast/js/kde/function.html: Added.
  • fast/js/kde/function_arguments-expected.txt: Added.
  • fast/js/kde/function_arguments.html: Added.
  • fast/js/kde/function_constructor-expected.txt: Added.
  • fast/js/kde/function_constructor.html: Added.
  • fast/js/kde/function_length-expected.txt: Added.
  • fast/js/kde/function_length.html: Added.
  • fast/js/kde/garbage-n-expected.txt: Added.
  • fast/js/kde/garbage-n.html: Added.
  • fast/js/kde/inbuilt_function_proto-expected.txt: Added.
  • fast/js/kde/inbuilt_function_proto.html: Added.
  • fast/js/kde/inbuilt_function_tostring-expected.txt: Added.
  • fast/js/kde/inbuilt_function_tostring.html: Added.
  • fast/js/kde/iteration-expected.txt: Added.
  • fast/js/kde/iteration.html: Added.
  • fast/js/kde/j-comment-3-expected.txt: Added.
  • fast/js/kde/j-comment-3.html: Added.
  • fast/js/kde/j-comment-4-expected.txt: Added.
  • fast/js/kde/j-comment-4.html: Added.
  • fast/js/kde/literals-expected.txt: Added.
  • fast/js/kde/literals.html: Added.
  • fast/js/kde/math-expected.txt: Added.
  • fast/js/kde/math.html: Added.
  • fast/js/kde/md5-1-expected.txt: Added.
  • fast/js/kde/md5-1.html: Added.
  • fast/js/kde/md5-2-expected.txt: Added.
  • fast/js/kde/md5-2.html: Added.
  • fast/js/kde/object_prototype-expected.txt: Added.
  • fast/js/kde/object_prototype.html: Added.
  • fast/js/kde/object_prototype_tostring-expected.txt: Added.
  • fast/js/kde/object_prototype_tostring.html: Added.
  • fast/js/kde/operators-expected.txt: Added.
  • fast/js/kde/operators.html: Added.
  • fast/js/kde/parse-expected.txt: Added.
  • fast/js/kde/parse.html: Added.
  • fast/js/kde/prototype_length-expected.txt: Added.
  • fast/js/kde/prototype_length.html: Added.
  • fast/js/kde/prototype_proto-expected.txt: Added.
  • fast/js/kde/prototype_proto.html: Added.
  • fast/js/kde/resources/Array.js: Added.
  • fast/js/kde/resources/Boolean.js: Added.
  • fast/js/kde/resources/Date.js: Added.
  • fast/js/kde/resources/Error.js: Added.
  • fast/js/kde/resources/GlobalObject.js: Added.
  • fast/js/kde/resources/KNOWN_FAILURES: Added.
  • fast/js/kde/resources/Number.js: Added.
  • fast/js/kde/resources/Object.js: Added.
  • fast/js/kde/resources/Prototype.js: Added.
  • fast/js/kde/resources/README: Added.
  • fast/js/kde/resources/RegExp.js: Added.
  • fast/js/kde/resources/StringObject.js: Added.
  • fast/js/kde/resources/assignments.js: Added.
  • fast/js/kde/resources/base.js: Added.
  • fast/js/kde/resources/cast.js: Added.
  • fast/js/kde/resources/comment-1.js: Added.
  • fast/js/kde/resources/comment-2.js: Added.
  • fast/js/kde/resources/completion.js: Added.
  • fast/js/kde/resources/conditional.js: Added.
  • fast/js/kde/resources/const.js: Added.
  • fast/js/kde/resources/constructor_length.js: Added.
  • fast/js/kde/resources/crash-1.js: Added.
  • fast/js/kde/resources/crash-2.js: Added.
  • fast/js/kde/resources/delete.js: Added.
  • fast/js/kde/resources/empty.js: Added.
  • fast/js/kde/resources/encode_decode_uri.js: Added.
  • fast/js/kde/resources/eval.js: Added.
  • fast/js/kde/resources/evil-n.js: Added.
  • fast/js/kde/resources/exception_propagation.js: Added.
  • fast/js/kde/resources/exceptions.js: Added.
  • fast/js/kde/resources/function.js: Added.
  • fast/js/kde/resources/function_arguments.js: Added.
  • fast/js/kde/resources/function_constructor.js: Added.
  • fast/js/kde/resources/function_length.js: Added.
  • fast/js/kde/resources/garbage-n.js: Added.
  • fast/js/kde/resources/inbuilt_function_proto.js: Added.
  • fast/js/kde/resources/inbuilt_function_tostring.js: Added.
  • fast/js/kde/resources/iteration.js: Added.
  • fast/js/kde/resources/j-comment-3.js: Added.
  • fast/js/kde/resources/j-comment-4.js: Added.
  • fast/js/kde/resources/literals.js: Added.
  • fast/js/kde/resources/math.js: Added.
  • fast/js/kde/resources/md5-1.js: Added.
  • fast/js/kde/resources/md5-2.js: Added.
  • fast/js/kde/resources/object_prototype.js: Added.
  • fast/js/kde/resources/object_prototype_tostring.js: Added.
  • fast/js/kde/resources/operators.js: Added.
  • fast/js/kde/resources/parse.js: Added.
  • fast/js/kde/resources/prototype_length.js: Added.
  • fast/js/kde/resources/prototype_proto.js: Added.
  • fast/js/kde/resources/scope.js: Added.
  • fast/js/kde/resources/shell.js: Added.
  • fast/js/kde/resources/statements.js: Added.
  • fast/js/kde/resources/string-1-n.js: Added.
  • fast/js/kde/resources/string-2-n.js: Added.
  • fast/js/kde/resources/var_decl_init.js: Added.
  • fast/js/kde/scope-expected.txt: Added.
  • fast/js/kde/scope.html: Added.
  • fast/js/kde/statements-expected.txt: Added.
  • fast/js/kde/statements.html: Added.
  • fast/js/kde/string-1-n-expected.txt: Added.
  • fast/js/kde/string-1-n.html: Added.
  • fast/js/kde/string-2-n-expected.txt: Added.
  • fast/js/kde/string-2-n.html: Added.
  • fast/js/kde/var_decl_init-expected.txt: Added.
  • fast/js/kde/var_decl_init.html: Added.
2:47 PM Changeset in webkit [11770] by hyatt
  • 1 edit in trunk/JavaScriptCore/Makefile.vc

Undo my accidental commit of Makefile.vc

2:23 PM Changeset in webkit [11769] by hyatt
  • 2 edits in trunk/JavaScriptCore/kjs

Make sure assert.h is included by including it in config.h

2:08 PM Changeset in webkit [11768] by hyatt
  • 2 edits in trunk/JavaScriptCore

Fix win32 bustage. ifdef the swap function for std pairs.

1:46 PM Changeset in webkit [11767] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Geoff.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's parent pointer.

WebKit:

Reviewed by Geoff

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly asking for parent via WebFrame (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more because WebFame's _detachFromParent takes care of that now.
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they can remove themselves. (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge until we are done with it. (-[WebFrame _transitionToCommitted:]): Remove some extra braces. (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent field directly. (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private since it is not there any more. (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer explicitly any more. (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field. (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces. (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the coding style. (-[WebFrame _previousFrameWithWrap:]): Ditto. (-[WebFrame parentFrame]): Get parent from the bridge.
12:06 AM Changeset in webkit [11766] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): don't retain self until after the possible early return.

Dec 25, 2005:

10:28 AM Changeset in webkit [11765] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:05 AM Changeset in webkit [11764] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the data source is committed, doesn't make sense to archive otherwise. (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method. (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source is committed. Use the helper. (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that defers callback changed. (-[WebDataSource _startLoading]): Remove stray space. (-[WebDataSource _stopLoading]): Only handle local _stopLoading business. Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal and remove _recursiveStopLoading. (-[WebDataSource _startLoading:]): Clean up an assert slightly. (-[WebDataSource _setTitle:]): Remove stray spaces. (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame can do that. (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame. (-[WebDataSource webArchive]): Return nil if the data source is not yet committed. It makes no sense to archive a provisional data source since it has no data yet. (-[WebDataSource addSubresource:]): Replace an assert with an early return, ASSERT is not an appropriate way to flag problems with the argument of a public method.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _setLoadType:]): Remove stray space. (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes manually and add a FIXME about confusingness of stopping loading here. (-[WebFrame _defersCallbacksChanged]): Tell our subframes. (-[WebFrame _addChild:]): Remove stray space. (-[WebFrame _stopLoadingSubframes]): New helper method. (-[WebFrame _subframeIsLoading]): New helper method, code moved from WebDataSource. (-[WebFrame stopLoading]): Tell subframes to stop loading. (-[WebFrame reload]): Remove extra braces.
  • WebView.subproj/WebFrameInternal.h:
1:22 AM Changeset in webkit [11763] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Eric and Dave Hyatt.

This is a somewhat cheesy change. Having to use PassRefPtr_Ref creates ambiguities
in assignment and copy construction. And this makes life way easier and removes
the need for pass(). It is not really correct, but we pretty much never need a real
const PassRefPtr, and this takes care of things for PassRefPtr temporaries.

  • kjs/identifier.cpp: (KJS::Identifier::add): No more need for pass()
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): No more need for pass()
  • kjs/ustring.cpp: (KJS::UString::Rep::create): Use adoptRef (KJS::UString::UString): No more need for pass (KJS::UString::append): No more need for pass (KJS::UString::substr): No more need for pass
  • kxmlcore/PassRefPtr.h: made m_ptr mutable (ugh) (KXMLCore::PassRefPtr::PassRefPtr): Take a const PassRefPtr reference (KXMLCore::PassRefPtr::release): Made this a const method (ugh) (KXMLCore::PassRefPtr::operator=): clean up appropriately (KXMLCore::adoptRef): Added this to use instead of PassRefPtr<T>::adopt, I think it makes the behavior more clear and it is less verbose. (KXMLCore::static_pointer_cast): use adoptRef (KXMLCore::const_pointer_cast): use adoptRef
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): take const PassRefPtr& (KXMLCore::PassRefPtr::operator=): take const PassRefPtr&
12:11 AM Changeset in webkit [11762] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Unbreak HashTableConstIterator++ by returning const_iterator

  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator++): use const_iterator

Dec 24, 2005:

11:52 PM Changeset in webkit [11761] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Un-break HashTable copy constructor.

  • kxmlcore/HashTable.h: (KXMLCore::::HashTable): use const_iterator instead
9:11 PM Changeset in webkit [11760] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 6236
Submitted by: mitz
Reviewed by: eseidel

  • fast/forms/domstring-replace-crash-expected.txt: Added.
  • fast/forms/domstring-replace-crash.html: Added.
9:11 PM Changeset in webkit [11759] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6326
Submitted by: mitz
Reviewed by: eseidel

Test: fast/forms/domstring-replace-crash.html

  • khtml/dom/dom_string.h: (DOMString::replace): Added check for null m_impl.
2:45 PM Changeset in webkit [11758] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::accessors): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::putValueProperty):
  • khtml/ecma/kjs_html.h:
2:06 PM Changeset in webkit [11757] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap): In all methods, explicitly cast all pointers to void * before passing to internal implementation. Use C-style casts instead of new-style casts, because the real solution would require a combo of reinterpret_cast anc const_cast.
2:00 PM Changeset in webkit [11756] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6231

  • Fixed assertion failure in QString::mid caused by my last checkin. parseWindowFeatuers() sometimes called QString::mid() with a start index past the end of the string but a length of 0. There were two problems there. (1) parseWindowString() shouldn't have gotten past the end of the string. (2) QString had range truncating code that was borked. So I fixed both.
  • khtml/ecma/kjs_window.cpp: (KJS::parseWindowFeatures): One of the "past the end" tests was > instead of >=.
  • kwq/KWQString.mm: (QString::mid): Truncate length *before* deciding whether to return early. Also, compare start and data._length before computing data._length - start, because the error case we're trying to catch will almost certainly cause unsigned overflow.
  • manual-tests/window-open-features-parsing.html: Added trailing ',' to uber-test to catch this failure, too.
2:02 AM Changeset in webkit [11755] by ap
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Changed the parameter type of slotTextChanged to const DOMString &
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): ditto. (RenderLineEdit::slotTextChanged): ditto. (RenderFileButton::RenderFileButton): ditto. (RenderFileButton::slotTextChanged): ditto.

Dec 23, 2005:

5:05 PM Changeset in webkit [11754] by ggaren
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Darin, reviewed and landed by me.

  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
4:54 PM Changeset in webkit [11753] by mjs
  • 8 edits in trunk/WebKit

Reviewed by John.

  • move more frame tree traversal code from WebView to WebFrame
  • WebView.subproj/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]): Moved this debug method from WebView, renamed it and changed it to return a boolean so it is appropriate for use in assertions instead of giving its own errors. (-[WebFrame _accumulateFramesWithSelection:]): Helper for the above. (-[WebFrame _findFrameWithSelection]): Moved from WebView and renamed from _findSelectedFrame, also removed the skipping variant. (-[WebFrame _clearSelectionInOtherFrames]): Moved from WebView and changed how the logic works. Instead of clearing selection in any frame but the focus frame, it clears selection in all but this one.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Stop getting WebFrame in needlessly roundabout way. (-[WebPDFView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebTextView.m: (-[WebTextView _webFrame]): New helper method. (-[WebTextView _elementAtWindowPoint:]): Use it. (-[WebTextView becomeFirstResponder]): Call _clearSelectionInOtherFrames (-[WebTextView resignFirstResponder]): Fix style issue (-[WebTextView clickedOnLink:atIndex:]): Use new helkper
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): Call to WebFrame as appropriate (-[WebView _selectedOrMainFrame]): Fix style issue
  • WebView.subproj/WebViewInternal.h:
3:04 PM Changeset in webkit [11752] by ggaren
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by vicki (yay!), eric.

  • Fixed: <rdar://problem/4377597> parsing of window.open features strings needs to be more forgiving

Manual test case: WebCore/manual-tests/window-open-features-parsing.html
Also fixed: WebCore/manual-tests/window-open-features.html, which had an incorrect URL in it.

This patch is long. Luckily, it's also complicated.

The main thing I've done is to change our parsing of the window.open 'features' argument to match Win IE. This is important because we now implement the correct defaults for window.open, and resizing and scrolling are turned off by default. So, if we parse the 'features' string incorrectly, we'll end up with an annoying, incorrectly sized window that can't resize or scroll.

To honor a long-standing request by Eric, I factored out the parsing into two new functions: parseWindowFeatures and constrainToScreen. I also added support for "innerWidth" and "innerHeight," since they're just synonyms for "width" and "height."

  • khtml/ecma/kjs_window.cpp: removed "emit" statements, since emit is #defined as "" (KJS::parseDialogFeatures): renamed from parseFeatures, since we now have a 'parseWindowFeatures'. (KJS::showModalDialog): ditto on parseFeatures. Also added some missing initializations for WindowArgs data members. (KJS::parseWindowFeatures): new function, all new functionality. (KJS::constrainToScreen): new function, no new functionality -- just cut and pasted code that used to run as part of our parsing routine. (KJS::WindowFunc::callAsFunction): (1) Factored out previous parsing code. (2) Factored 17 lines of custom popup-blocking code into 3 lines that use pre-existing 'allowPopUp' function. Gratuitous, but it cried out to me. (3) Changed URL parsing to substitute "" for undefined *and* null values (we already did this for undefined), to avoid trying to navigate to '​http://null'. (4) Factore a multiline if () { if () {}} into an if ( && ) (4) Removed the main body of code from a giant 'else' block by inserting early returns for the exceptional cases. This caused some things to show up in the diff even though they're just whitespace changes. I didn't actually change any code past the line "if (!str.isEmpty() && activePart)"
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Added code to set toolbars to visible if toolBarVisible is true *or* locationBarVisible is true. The parser used to do this for us, but it's really the browser that's responsible for saying that the toolbar and the locationbar are the same thing. Hopefully, we can add a setLocationBarVisible delegate in the future so that other webkit clients can make their own UI decisions.
  • kwq/KWQKPartsBrowserExtension.h: Added locationBarVisible data member to WindowArgs structure and renamed toolBarsVisible to toolBarVisible (see above). Removed initialization code from WindowArgs structure because this file is for platform-specific code, and what defaults to use for window arguments is purely engine stuff.
10:44 AM Changeset in webkit [11751] by eseidel
  • 59 edits
    6 deletes in trunk/WebCore

Bug #: 6138
Submitted by: eseidel
Reviewed by: mjs

Remove many use of .qstring()
Convert several instances of QStrings to DOMStrings
Add DOMString::replace(QChar, QChar)
Remove (unused) KWQLabel, KWQKGlobal
Slight performance improvement.
Also fixed ChangeLog line endings from previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6138

No tests needed, no functionality changes.

  • ChangeLog: Fixed line endings
  • ForwardingHeaders/kglobal.h: Removed.
  • ForwardingHeaders/qlabel.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: removed KWQLabel
  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_stylesheetimpl.cpp: (MediaListImpl::setMediaText):
  • khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState):
  • khtml/dom/dom_string.h: (DOM::DOMString::replace):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::put): (KJS::DOMAttr::put): (KJS::DOMDocument::put):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLElement::put): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported):
  • khtml/editing/markup.cpp: (khtml::stringValueForRange): (khtml::startMarkup):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLInputElementImpl::appendFormData): (DOM::HTMLTextAreaElementImpl::updateValue):
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::isURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableSectionElementImpl::addChild): (DOM::HTMLTableRowElementImpl::addChild):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::checkEmitLoadEvent):
  • khtml/misc/loader.cpp: (CachedObject::finish): (CachedCSSStyleSheet::checkNotify): (CachedXSLStyleSheet::checkNotify): (CachedXBLDocument::checkNotify): (DocLoader::requestImage): (DocLoader::requestStyleSheet): (DocLoader::requestScript): (Loader::servePendingRequests): (Loader::cancelRequests):
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::~RenderBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): (RenderLineEdit::updateFromElement): (RenderTextArea::updateFromElement): (RenderTextArea::text):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListMarker::paint):
  • khtml/rendering/render_text.cpp: (khtml::RenderText::RenderText): (khtml::RenderText::position):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): (DocumentImpl::getElementByAccessKey): (DocumentImpl::recalcStyleSelector): (DocumentImpl::defaultEventHandler):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dump): (DOM::appendAttributeDesc): (DOM::NodeImpl::showNode):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::lower):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::executeScripts):
  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentViewForNode): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::addMessageToConsole): (KWQKHTMLPart::passWheelEventToChildWidget): (KWQKHTMLPart::shouldDragAutoNode): (KWQKHTMLPart::snapshotDragImage): (convertAttributesToUnderlines): (KWQKHTMLPart::setMarkedTextRange): (KWQKHTMLPart::mousePressNode):
  • kwq/KWQKGlobal.h: Removed.
  • kwq/KWQKGlobal.mm: Removed.
  • kwq/KWQLabel.h: Removed.
  • kwq/KWQLabel.mm: Removed.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setAutoSaveName): (QLineEdit::setPlaceholderString):
  • kwq/KWQPainter.mm: (QPainter::compositeOperatorFromString):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::call):
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • ksvg2/scripts/cssmakeprops: removed kglobal.h
  • ksvg2/scripts/cssmakevalues: removed kglobal.h
12:55 AM Changeset in webkit [11750] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp (KJS::XMLHttpRequest::slotFinished): Make sure to fetch response headers and set the state to Loaded, if this hasn't been done already.
12:50 AM Changeset in webkit [11749] by ap
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): Set application/xml as a default Content-Type; use a proper codec for request body if a charset is specified. (KJS::XMLHttpRequest::getRequestHeader): Use getSpecificHeader. (KJS::XMLHttpRequest::getResponseHeader): Ditto. (KJS::XMLHttpRequest::getSpecificHeader): Factored out code from getResponseHeader. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Removed a FIXME (this is done in send() now).
  • khtml/ecma/xmlhttprequest.h:
12:35 AM Changeset in webkit [11748] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

ChangeLog entry for the previous checkin

12:34 AM Changeset in webkit [11747] by mjs
  • 2 edits in trunk/JavaScriptCore
  • this time for sure
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
12:28 AM Changeset in webkit [11746] by ap
  • 6 adds in trunk/LayoutTests/fast/encoding

Reviewed by Darin Adler.

  • fast/encoding/frame-default-enc-expected.checksum: Added.
  • fast/encoding/frame-default-enc-expected.png: Added.
  • fast/encoding/frame-default-enc-expected.txt: Added.
  • fast/encoding/frame-default-enc.html: Added.
  • fast/encoding/resources/frame-default-enc-frame.html: Added.
12:19 AM Changeset in webkit [11745] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Eric.

  • move a few more methods from WebView to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _hasSelection]): Renamed from _frameIsSelected: and moved from WebView. (-[WebFrame _clearSelection]): Renamed from _deselectFrame: and moved from WebView.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Update for renames. (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): Ditto. (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]): Ditto. (-[WebView _selectedFrameDidChange]):
12:05 AM Changeset in webkit [11744] by justing
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6211>
fast/text/attributed-substring-from-range-lines needs LayoutTests/editing/editing.js

  • editing/input/attributed-substring-from-range-lines-expected.txt: Added.
  • editing/input/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-lines.html: Removed.
12:02 AM Changeset in webkit [11743] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Eric.

  • updated for WebCore changes to make XSLT params partially work
  • fast/xsl/xslt-processer-expected.txt:

Dec 22, 2005:

11:55 PM Changeset in webkit [11742] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • khtml/khtml_part.cpp (KHTMLPart::write): Do not use the parent frame encoding as a default for sub-frames (revert rdar://3100151).
11:35 PM Changeset in webkit [11741] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix build problem from last commit.
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
7:57 PM Changeset in webkit [11740] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Eric.

  • made RefPtr<DOMStringImpl> usable as a hashtable key/value
  • changed XSLTProcessorImpl to make use of this instead of a QDict.
  • partially fixed broken param handling for xslt

See LayoutTests for updated test case.

  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h: (KXMLCore::): Set things up so you can use RefPtr<DOMStringImpl> as a hashtable key (should already be usable as a value).
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): Updated to use a HashMap of RefPtrs instead of QDict. Also, fixed bugs that would have kept this from ever working at all. (DOM::XSLTProcessorImpl::transformToString): ditto (DOM::XSLTProcessorImpl::setParameter): ditto (DOM::XSLTProcessorImpl::getParameter): ditto (DOM::XSLTProcessorImpl::removeParameter): ditto
  • khtml/xsl/xslt_processorimpl.h:
5:52 PM Changeset in webkit [11739] by mjs
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The changes for support are relatively simple, but I also made extensive changes to
avoid copying, so that there isn't refcount thrash when you put RefPtrs into a HashMap.

  • kxmlcore/HashTable.h: (KXMLCore::swap): specialize swap for pairs, to swap elements individually, so that excess copies can be avoided. (KXMLCore::Mover::move): Template function to either copy or swap, used when transferring elements from old table to new. (KXMLCore::IdentityHashTranslator::hash): The old "converting lookup" templates that took two or three function parameters now take a class parameter, this is the class used to do a normal lookup. (KXMLCore::IdentityHashTranslator::equal): Ditto. (KXMLCore::IdentityHashTranslator::translate): Ditto. Translate now takes a reference to write into instead of returning a value to avoid redundant copies. (KXMLCore::HashTable::~HashTable): Use deallocateTable instead of freeing directly. (KXMLCore::HashTable::insert): Based on HashTranslator now instead of separate functions. Added a FIXME about a remaining rare excess copy. (KXMLCore::HashTable::isEmptyBucket): Use KeyTraits directly instead of unwrapping the key from Traits, to avoid creating and destroying pair, which copies. (KXMLCore::HashTable::isDeletedBucket): ditto (KXMLCore::HashTable::lookup): Use HashTranslator now instead of separate functions. (KXMLCore::HashTable::initializeBucket): Renamed from emptyBucket. Use placement new to work right for non-POD types. (KXMLCore::HashTable::deleteBucket): Use assignDeleted to avoid excess copies. (KXMLCore::HashTable::reinsert): use Mover template to copy or swap as appropriate (KXMLCore::HashTable::allocateTable): Initialize every bucket if calloc won't do. (KXMLCore::HashTable::deallocateTable): Destruct every bucket if needed. (KXMLCore::HashTable::rehash): Avoid copy before reinserting, so that swap can do its magic. (KXMLCore::HashTable::clear): use deallocateTable instead of freeing directly. (KXMLCore::HashTable::HashTable): be more dumb when copying to ensure that non-POD types work right
  • kxmlcore/HashFunctions.h: (KXMLCore::PointerHash): Specialize PointerHash for RefPtr
  • kxmlcore/HashMap.h: (KXMLCore::extractFirst): Return a reference not a full object to avoid copies. (KXMLCore::HashMapTranslator::hash): Use a special translator for insertion to defer making the pair as long as possible, thus avoiding needless copies. (KXMLCore::HashMapTranslator::equal): ditto (KXMLCore::HashMapTranslator::translate): ditto (KXMLCore::::inlineAdd): Shared by set and add to insert using HashMapTranslator (KXMLCore::::set): Use inlineAdd (KXMLCore::::add): Use inlineAdd
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::): Pass KeyTraits along
  • kxmlcore/HashSet.h: (KXMLCore::identityExtract): Return a reference not a full object to avoid copies. (KXMLCore::HashSetTranslatorAdapter::hash): Redo adapter stuff to work with the new HashTranslator approach. (KXMLCore::HashSetTranslatorAdapter::equal): ditto (KXMLCore::HashSetTranslatorAdapter::translate): ditto (KXMLCore::::insert): ditto
  • kxmlcore/HashTraits.h: (KXMLCore::GenericHashTraits): This is intended be used as a base class for customized traits: sensible defaults. (KXMLCore::): Use it a bunch (KXMLCore::assignDeleted): template function to allow pairs to be assigned the deleted value w/o excess copies. (KXMLCore::PairHashTraits::emptyValue): Updated (KXMLCore::PairHashTraits::deletedValue): Updated (KXMLCore::PairHashTraits::assignDeletedValue): part of assignDeleted hack (KXMLCore::DeletedValueAssigner::assignDeletedValue): Use template magic to either use use deletedValue or assignDeletedValue for the cases where we care.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::swap): Added swap method. (KXMLCore::swap): Added swap free function.
  • kjs/identifier.cpp: (KJS::CStringTranslator::hash): Use new HashTranslator class approach to alternate type based insertion. (KJS::CStringTranslator::equal): ditto (KJS::CStringTranslator::translate): ditto (KJS::Identifier::add): ditto (KJS::UCharBufferTranslator::hash): ditto (KJS::UCharBufferTranslator::equal): ditto (KJS::UCharBufferTranslator::translate): ditto
  • irrelevant change:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Removed a stray space.

WebCore:

Reviewed by Darin.

  • update for new HashTranslator stuff
  • khtml/xml/dom_atomicstring.cpp: (DOM::CStringTranslator::hash): (DOM::CStringTranslator::equal): (DOM::CStringTranslator::translate): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::QCharBufferTranslator::hash): (DOM::QCharBufferTranslator::equal): (DOM::QCharBufferTranslator::translate):
  • khtml/xml/dom_qname.cpp: (DOM::QNameComponentsTranslator::hash): (DOM::QNameComponentsTranslator::equal): (DOM::QNameComponentsTranslator::translate): (DOM::QualifiedName::QualifiedName):
5:13 PM Changeset in webkit [11738] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Cleaned up a previous checkin by defining global const defaultForm.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): (DocumentImpl::checkedRadioButtonForGroup): (DocumentImpl::removeRadioButtonGroup):
4:14 PM Changeset in webkit [11737] by vicki
  • 3 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Eric.

  • fix <rdar://problem/4379899> *Panther* REGRESSION (TOT): Scrollwheel doesn't work on frameset pages (5450) and <rdar://problem/4379906> *Pan EU2* 10.4.4 Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com

Basically plug in the TOT fixes for Panther. Add passWheelEventToChildWidget, but add the event as a
parameter - since there's no concept of _currentEvent on the branch, we have to pass the event around.
Return true when passing the wheel event to the child widget, since we don't want to send the event on
to the nextResponder for this case.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::passWheelEventToChildWidget):
3:06 PM Changeset in webkit [11736] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

Tests for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • fast/forms/radio_checked_dynamic-expected.checksum: Added.
  • fast/forms/radio_checked_dynamic-expected.png: Added.
  • fast/forms/radio_checked_dynamic-expected.txt: Added.
  • fast/forms/radio_checked_dynamic.html: Added.

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): update radio button hash map when moving form elements around. (DOM::HTMLGenericFormElementImpl::insertedIntoTree): ditto.
  • khtml/html/html_formimpl.h: (DOM::HTMLGenericFormElementImpl::isRadioButton): Added. (DOM::HTMLInputElementImpl::isRadioButton): Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): Added comment explaining that we use 1 for the default form. We can't use a null pointer as a key for the hash map. (DocumentImpl::checkedRadioButtonForGroup): Added conversion of null form pointer to 1. (DocumentImpl::removeRadioButtonGroup): ditto.
2:38 PM Changeset in webkit [11735] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-21 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
2:36 PM Changeset in webkit [11734] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-20 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
1:10 PM Changeset in webkit [11733] by andersca
  • 14 edits in trunk/WebCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/XSLTProcessor.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp: Update for changes to JSC.
1:08 PM Changeset in webkit [11732] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove conflict markers

1:07 PM Changeset in webkit [11731] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric and Darin.

  • kjs/lookup.h: Move ClassName from KJS_DECLARE_PROTOTYPE to KJS_IMPLEMENT_PROTOTYPE. Also, namespace all macros by prefixing them with KJS_.
11:59 AM Changeset in webkit [11730] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/rendering/render_table.cpp

Fixing a merge issue with <rdar://problem/4364640> *PanEu2* REGRESSION: Table layout issue occurs at ​http://www.pixar.com/shorts/index.html

8:53 AM Changeset in webkit [11729] by darin
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Eric.

  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::self): Don't use static deleter for two reasons: (1) We don't want any globals with constructors in any of our frameworks because they slow down framework load time. (2) There's no need to destroy this object at process termination time -- it's extra work with no benefit. Because of both these reasons, our KStaticDeleter implementation was basically a no-op.
  • ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::self): Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setDocumentChanged): Ditto.
  • khtml/html/html_canvasimpl.cpp: Removed include of kstringhandler.h.
  • khtml/html/html_imageimpl.cpp: Ditto.
  • khtml/khtmlpart_p.h: Removed something that was in an "APPLE_CANGES" ifdef.
  • ForwardingHeaders/kstaticdeleter.h: Removed.
  • ForwardingHeaders/kstringhandler.h: Removed.
  • kwq/KWQKStaticDeleter.h: Removed.
  • kwq/KWQKStringHandler.h: Removed.
  • kwq/KWQKStringHandler.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
8:50 AM Changeset in webkit [11728] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/parser/nsup-entity-expected.txt: Added.
  • fast/parser/nsup-entity.html: Added.

WebCore:

Reviewed by Eric.

  • khtml/html/kentities.gperf: Add "nsup" to table.
  • khtml/html/htmltokenizer.cpp: Removed old workaround for inlining issue that no longer seems to be necessary; also touches the file which is important because Xcode doesn't seem to understand the dependency on kentities.gperf and the need to recompile.
8:48 AM Changeset in webkit [11727] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Remove non-template constructor that takes RefPtr since the constructor template that takes RefPtr should be sufficient. Add a constructor template that takes PassRefPtr&. (KXMLCore::PassRefPtr::adopt): Use PassRefPtr_Ref to avoid setting pointer first to 0 and then to the pointer. (KXMLCore::PassRefPtr::operator=): Added template versions that take PassRefPtr& and RefPtr parameters. (KXMLCore::PassRefPtr::operator PassRefPtr<U>): Changed to fix leak -- old version would release and then ref. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Add constructor template that takes PassRefPtr. (KXMLCore::RefPtr::operator=): Add assignment operator templates that take RefPtr and PassRefPtr. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
8:46 AM Changeset in webkit [11726] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/rendering/DataRef.h: (khtml::DataRef::operator=): Eliminate an extra branch by doing ref before deref instead of == check.
  • khtml/rendering/render_style.cpp: (khtml::initDefaultStyle): Added. Function to initialize the default style for use in constructor. (khtml::RenderStyle::RenderStyle): Changed constructor to initalize all the members with constructor syntax instead of using assignment on all of them.
  • khtml/rendering/render_style.h: Removed static data member _default -- it's now a file scope global instead.

Dec 21, 2005:

11:39 PM Changeset in webkit [11725] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/cvs-create-patch: Handle newly-added directories using chdir.
10:55 PM Changeset in webkit [11724] by darin
  • 3 edits in trunk/LayoutTests
  • fast/text/attributed-substring-from-range-expected.txt: Updated.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Updated.
8:11 PM Changeset in webkit [11723] by darin
  • 14 edits in trunk/WebCore

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Call new updateLayout member function. (khtml::ApplyStyleCommand::applyInlineStyle): Ditto. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Ditto.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto. (khtml::CompositeEditCommand::findBlockPlaceholder): Ditto. (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Ditto.
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto.
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto. (khtml::EditCommand::updateLayout): Added. Calls updateLayoutIgnorePendingStylesheets on the document.
  • khtml/editing/edit_command.h: Added updateLayout member function.
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply): Call new updateLayout member function.
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Ditto.
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::execCommand): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (DOM::JSEditor::queryCommandEnabled): Ditto. (DOM::JSEditor::queryCommandIndeterm): Ditto. (DOM::JSEditor::queryCommandState): Ditto. (DOM::JSEditor::queryCommandValue): Ditto.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Ditto.
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::insertFragmentForTestRendering): Ditto. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Call new updateLayout member function. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::ReplaceSelectionCommand::doApply): Call new updateLayout member function. (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::nextLinePosition): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]): Ditto. (-[WebCoreBridge smartDeleteRangeForProposedRange:]): Ditto.
8:06 PM Changeset in webkit [11722] by darin
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/ecma/kjs_events.cpp: (KJS::DOMMouseEvent::getValueProperty): Change everything to just call through instead of doing the work here. (KJS::DOMWheelEvent::getValueProperty): Ditto.
  • khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::offsetX): (DOM::MouseRelatedEventImpl::offsetY):
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Initialize new m_pageX, m_pageY, m_layerX, m_layerY, m_offsetX, and m_offsetY. (DOM::MouseRelatedEventImpl::computePositions): Renamed from computeLayerPos since it handles page position andoffset position too now. (DOM::MouseRelatedEventImpl::pageX): Added. Not in header since it's virtual. (DOM::MouseRelatedEventImpl::pageY): Ditto. (DOM::MouseRelatedEventImpl::x): Added, with FIXME since it should change eventually. (DOM::MouseRelatedEventImpl::y): Ditto. (DOM::MouseEventImpl::initMouseEvent): Call computePositions instead of computeLayerPos. (DOM::MouseEventImpl::toElement): Added. (DOM::MouseEventImpl::fromElement): Added.
5:40 PM Changeset in webkit [11721] by thatcher
  • 6 edits in trunk

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:32 PM Changeset in webkit [12226] by thatcher
  • 2 edits in trunk/JavaScriptGlue

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebBrowser:

  • WebBrowser.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKitSystemInterface:

  • WebKitSystemInterface.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:25 PM Changeset in webkit [11720] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick and Darin Adler.

  • fixed HiDPI problem with forms auto-fill menu width

No test cases added; this code is used for "chrome" only.

  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): convert entire rect to window coordinates, not just origin
4:55 PM Changeset in webkit [11719] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Removed evil hack for determining if a type is an integer, replaced
with template metaprogramming.

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab size to 2 for testkjs.cpp
  • kjs/testkjs.cpp: (main): Inserted asserts to test IsInteger. FIXME: Move these to KXMLCore unit tests directory when we create one.
  • kxmlcore/HashTraits.h: (KXMLCore::): Added IsInteger class for querying types.
2:51 PM Changeset in webkit [11718] by harrison
  • 13 edits in trunk/WebCore

Reviewed by Justin).

<rdar://problem/4039777> Pasting particular snippet of HTML containing list items and a link creates too many list items

  • Fixed paste crash by making calling RenderBox::deleteLineBoxWrapper() from RenderObject::remove(), so that the connection is broken before the InlineBox's parent gets deleted.
  • Fixed overzealous style changes when setting the style on a specific range of elements. These specific ranges are derived programmatically, e.g. as a part of pasting, so they must be respected exactly rather than modified by converting the endpoints to VisiblePositions.

Test cases coming soon.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): (khtml::ApplyStyleCommand::updateStartEnd): (khtml::ApplyStyleCommand::startPosition): (khtml::ApplyStyleCommand::endPosition): (khtml::ApplyStyleCommand::applyBlockStyle): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical): (khtml::ApplyStyleCommand::joinChildTextNodes):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::applyStyle):
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/rendering/render_box.cpp: (RenderBox::destroy): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListMarker::~RenderListMarker): (RenderListMarker::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::remove):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy):
2:42 PM Changeset in webkit [11717]
  • 212 copies
    17 deletes in tags/WebCore-417~17

This commit was manufactured by cvs2svn to create tag
'WebCore-417~17'.

2:42 PM Changeset in webkit [11716] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:57 PM Changeset in webkit [11715] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
9:43 AM Changeset in webkit [11714] by thatcher
  • 1 add in branches/Safari-1-3-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

8:51 AM Changeset in webkit [11713] by thatcher
  • 1 delete in branches/Safari-1-3-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-1-3-branch on 2005-12-21 17:43:18 +0000

8:50 AM Changeset in webkit [11712]
  • 1 copy in branches/Safari-1-3-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-1-3-branch'.

8:50 AM Changeset in webkit [11711] by adele
  • 19 edits in trunk

LayoutTests:

Reviewed by Darin.

Updating results for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

These results all changed because we now select all for contenteditable elements when focus() is called on them.

  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:
  • fast/dom/blur-contenteditable-expected.txt:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/dom/focus-contenteditable-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:

WebCore:

Reviewed by Darin.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

I moved the scrolling code out of setFocusNode, and consolidated some of the focus code to scroll when necessary.

  • khtml/html/html_formimpl.cpp: Removed HTMLButtonElementImpl::blur, HTMLButtonElementImpl::focus, HTMLInputElementImpl::blur, HTMLInputElementImpl::focus. New code in ElementImpl::focus will now handle these cases. This allows tabbing through the elements to go through the same code path as calling focus() on an element. Before, focus() would scroll to reveal for any form elements that had a RenderWidget, but wouldn't scroll for anchor elements, or any of the new form elements. Now the behavior will be more consistent. (DOM::HTMLLabelElementImpl::focus): calls ElementImpl::focus. (DOM::HTMLLegendElementImpl::focus): ditto.
  • khtml/html/html_formimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectAll): calls new function selectContentsOfNode (KHTMLPart::selectContentsOfNode): factored out code to selectAll for a particular node- which is useful for contenteditable elements.
  • khtml/khtml_part.h: added selectContentsOfNode
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): removed scrolling code.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Calls updateLayout in case focus() is called before there's a renderer. Makes a selection for editable elements (right now we select all, but this will change). Doesn't scroll if the renderer is a RenderWidget, since that is handled when the view becomes first responder. This will go away when we convert the rest of our form elements.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::revealSelection): Made this more like centerSelectionInVisibleArea where we get the right rectangle if the selection is a caret. (KWQKHTMLPart::nextKeyViewInFrame): call ElementImpl::focus() for the node. This will set the selection too, which used to be done here.
2:53 AM Changeset in webkit [11710] by eseidel
  • 1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

Fixed ChangeLog typo.

2:44 AM Changeset in webkit [11709] by eseidel
  • 3 edits
    2 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Beef up our XSLT processor tests to include a test which passes
a parameter into the transform. I also took this opportunity
to clean up the output a bit, and in the process found another
bug and file: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6180

  • fast/xsl/resources/xslt-param.xml: Added.
  • fast/xsl/resources/xslt-param.xsl: Added.
  • fast/xsl/xslt-processer-expected.txt:
  • fast/xsl/xslt-processer.html:

Dec 20, 2005:

6:06 PM Changeset in webkit [11708] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by justin

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • editing/input/firstrectforcharacterrange-plain-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-plain.html: Added.
  • editing/input/firstrectforcharacterrange-styled-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-styled.html: Added.
6:05 PM Changeset in webkit [11707] by justing
  • 3 edits in trunk/WebCore

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

Added layout tests:

  • editing/input/firstrectforcharacterrange-styled
  • editing/input/firstrectforcharacterrange-plain
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Return null if the range isn't found, instead of a startless/endless range. Set the end if the requested location+length is out of bounds.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToDOMRange:]): Handle larged unsigned values before calling rangeWithLocationAndLength, which expects signed ints.
6:04 PM Changeset in webkit [11706] by justing
  • 2 edits in trunk/WebKit

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Handle some large unsigned values the way NSTextView does. Actually use the range passed in instead of _selectedRange, use of _selectedRange was a workaround that is no longer necessary.
5:41 PM Changeset in webkit [11705]
  • 222 copies
    18 deletes in tags/WebCore-417~16

This commit was manufactured by cvs2svn to create tag
'WebCore-417~16'.

5:41 PM Changeset in webkit [11704] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.16

5:36 PM Changeset in webkit [11703] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
5:31 PM Changeset in webkit [11702] by thatcher
  • 1 add in branches/Safari-2-0-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

5:16 PM Changeset in webkit [11701] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

This is a problem with a particular font that was installed by Microsoft Office X. Though the
font and/or lower levels of font-handling code in the system are buggy, this bad symptom will
occur for users of Safari and other WebKit clients who happen to have one of these bad fonts.
This adds a workaround to avoid the problem.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]): When we're going to synthesize bold or italic, yet the font we looked up was apparently a match for the traits, try to look up a font that without the to-be-synthesized traits. This way, instead of applying synthetic bold over Arial Bold, we'll apply synthetic bold over Arial Regular, which is uglier than just using Arial Bold, but far less ugly than using Arial Bold with synthetic bold too.

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:48 PM Changeset in webkit [11700] by thatcher
  • 1 delete in branches/Safari-2-0-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-2-0-branch on 2005-12-21 01:31:19 +0000

4:48 PM Changeset in webkit [11699]
  • 1 copy in branches/Safari-2-0-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

4:48 PM Changeset in webkit [11698] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
4:23 PM Changeset in webkit [11697] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin

Layout test for:
<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)

<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

  • editing/selection/selection-actions-expected.checksum: Added.
  • editing/selection/selection-actions-expected.png: Added.
  • editing/selection/selection-actions-expected.txt: Added.
  • editing/selection/selection-actions.html: Added.
4:23 PM Changeset in webkit [11696] by justing
  • 3 edits in trunk/WebKit

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:00 PM Changeset in webkit [11695] by justing
  • 12 edits in trunk/WebCore

Reviewed by: eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

3:05 PM Changeset in webkit [11694] by justing
  • 2 edits in trunk/WebCore

Reviewed by eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEImageQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter):
  • kwq/KWQExceptions.h:
  • kwq/KWQExceptions.mm: (KWQReportBlockedException):
  • kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:_WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::sendContextMenuEvent): (KWQKHTMLPart::fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::imageFromRect):
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQLoader.mm: (KWQCheckCacheObjectStatus):
  • kwq/KWQWidget.mm: (QWidget::frameGeometry): (QWidget::mapFromGlobal):
2:31 PM Changeset in webkit [11693] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4294417> Cannot un-italicize some text after triple clicking it

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.
1:36 PM Changeset in webkit [11692] by justing
  • 2 edits in trunk/WebKit

Reviewed by mitz

Fixed more uninitialized variable warnings, and
removed an extra semicolon.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): (createATSULayoutParameters):
1:18 PM Changeset in webkit [11691] by justing
  • 2 edits in trunk/WebCore

<rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6160> REGRESSION: Crash when running editing/deleting/delete-3800834-fix.html
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6161> REGRESSION: crash when pressing tab in editable WebHTMLView

Reviewed by darin

Some callers call setAttribute on a floating element. So, using
a RefPtr for the element inside addAttribute can destroy
it.

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::addAttribute):
12:48 PM Changeset in webkit [11690] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix bug numbers in last two entries.

12:42 PM Changeset in webkit [11689] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Added bugzilla link.

12:41 PM Changeset in webkit [11688] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.

  • push more of frame lookup and management from WebView to WebFrame, this is in preparation for shifting this to WebCore
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces (-[WebBridge runModal]): ditto
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addFrame:toNamespace:]): This now operates in terms of WebFrames (expected to be the main frame) not WebViews. (+[WebFrameNamespaces framesInNamespace:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame _setFrameNamespace:]): Set self, not WebView. (-[WebFrame _shouldAllowAccessFrom:]): Moved this code above use to avoid prototyping the method. (-[WebFrame _descendantFrameNamed:sourceFrame:]): Ditto. (-[WebFrame _frameInAnyWindowNamed:sourceFrame:]): Copied logic over from WebView. (-[WebFrame findFrameNamed:]): Do it all here, don't call WebView.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
12:40 PM Changeset in webkit [11687] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/xml/dom_elementimpl.cpp: (StyledElementImpl::createAttributeMap): the new attribute map is going in a RefPtr, don't also ref it manually.
12:27 PM Changeset in webkit [11686] by mjs
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Remove accidentally committed change (which I am about to recommit, so no ChangeLog
comment for the revert).

12:18 PM Changeset in webkit [11685] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kxmlcore/AlwaysInline.h:
12:12 PM Changeset in webkit [11684] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • fixed a leak in the assignment operator from PassRefPtr to RefPtr
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::operator=):
  • fix problem with PassRefPtr that darin spotted - it lacked a copy constructor and therefore was using the default one, which can lead to excess derefs

I fixed this by adding a copy constructor from non-const
reference, and by adding a template pass() function that you have
to use when raw pointer or RefPtr are passed where PassRefPtr is
expected.

  • kjs/identifier.cpp: (KJS::Identifier::add): Changed to have PassRefPtr return type and pass() the results.
  • kjs/identifier.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Use pass() where required.
  • kjs/ustring.cpp: (KJS::UString::UString): Use pass() as needed. (KJS::UString::append): ditto (KJS::UString::substr): ditto
  • kjs/ustring.h: (KJS::UString::UString): Use initializer instead of assignment
  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Added copy constructor (KXMLCore::pass): new template function to make it convenient to pass a PassRefPtr

WebCore:

Reviewed by Darin.

  • change an assignment to a contructor declaration to build with PassRefPtr leak fix changes
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
10:47 AM Changeset in webkit [11683] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by adele.

Fixed build failure due to missing 'b's in my last checkin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isStatusbarVisible]): changed 'B' to 'b' (-[WebBridge setStatusbarVisible:]): ditto
10:34 AM Changeset in webkit [11682] by ggaren
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):

LayoutTests:

Layout test for <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

  • fast/js/objc-big-method-name-expected.txt: Added.
  • fast/js/objc-big-method-name.html: Added.
10:29 AM Changeset in webkit [11681] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin, committed by Adele.

  • WebCoreSupport.subproj/WebTextRenderer.m: (createATSULayoutParameters): Assign initial values, which will never be used, to substituteRenderer and firstSmallCap, to avoid uninitialized variable warnings.
9:06 AM Changeset in webkit [11680] by ggaren
  • 8 edits
    3 adds in trunk

WebCore:

Reviewed by John.

Fixed <rdar://problem/4310363> JavaScript window.open: Height is 1
pixel short, and related bugs.

There were a few bugs here.
(1) Our code took size arguments and applied them to the window's

content rect. That's incorrect. The Rhino book says the arguments
should apply to the WebView. Other things that occupy the content
rect include the tab bar, the status bar, and the 1 pixel border
between brushed metal and document. All of these used to impinge
on the web page's display area.

The fix is to calculate sizing based on the WebView instead of
the content rect. This means that the webViewContentRect and
setContentRect delegate methods are obsolete and no longer called
by any of our code. (setContentRect was never called in the
first place.)

(2) None of our sizing accounted for scaled resolutions.

The fix is to ask the WebView to scale all coordintes for us.

(3) Our code assumed that all window accoutrements were on by default.

Safari works that way, but other WebKit clients might not.

The fix is always to explicitly set an on/off state.

(a) To facilitate scaling, I added a new bridge method, webView, to
access the webView.

(b) For internal consistency, I changed _Bars to _bars in bridge
methods, and _bars to _Bars in WinArgs data members. (Interestingly,
the different classes in our code are evenly divided on which format to
use.)

Added manual test:

  • manual-tests/window-open-features.html: Added.
  • manual-tests/resources/200x200.png: Added.
  • manual-tests/resources/popup200x200.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::showModalDialog): see (b) (KJS::WindowFunc::callAsFunction): see (b)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::statusbarVisible): see (b)
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): At the top of this method, I just did some formatting cleanup and moved the 'referrer' variable closer to where it's used. The changes in the middle of the method are (3), the bottom, (2).
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs): see (b)
  • kwq/WebCoreBridge.h: see (a)

WebKit:

Reviewed by John.

Part of fix for <rdar://problem/4310363> JavaScript window.open: Height
is 1 pixel short, and related bugs. See WebCore ChageLog.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge webView]): Added method.
2:08 AM Changeset in webkit [11679] by eseidel
  • 2 edits in trunk/WebKit

Submitted by: eseidel
Reviewed by: mjs

Development-only build fix.

  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): fixed typo
1:59 AM Changeset in webkit [11678] by mjs
  • 2 edits in trunk/WebKit

Not reviewed.

  • revert accidental commit of this file.
1:30 AM Changeset in webkit [11677] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 6156
Submitted by: eseidel
Reviewed by: mjs

Leaks when running SVG tests
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6156
No additional tests necessary, leaks already caught by other tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEDiffuseLighting::setLightSource): takes ownership (KCanvasFESpecularLighting::setLightSource): takes ownership
  • kcanvas/KCanvasFilters.h: (KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::~KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::lightSource): fixed spacing (KCanvasFESpecularLighting::KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::~KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::lightSource): fixed spacing
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::stringForPath): added missing CFRelease
1:16 AM Changeset in webkit [11676] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5931
Submitted by: eseidel
Reviewed by: darin

Remove additional bit-rotted DEBUG* ifdefs from WebCore.
This removes PARSER_DEBUG, FORMS_DEBUG and CSS_STYLESHEET_DEBUG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5931
No tests possible, only removing dead code.

  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::parseString): (CSSStyleSheetImpl::isLoading):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLGenericFormElementImpl::getForm):
  • khtml/html/htmlparser.cpp: (HTMLParser::processCloseTag): (HTMLParser::createHead):
12:49 AM Changeset in webkit [11675] by eseidel
  • 12 edits in trunk/WebCore

Bug #: 6107
Submitted by: eseidel
Reviewed by: darin

Move Decoder onto Shared<T> and clients onto RefPtr.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6107
No test cases possible, no functional changes.

  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished): (KJS::XMLHttpRequest::slotData):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::begin): (KHTMLPart::write):
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
  • khtml/misc/decoder.h:
  • khtml/misc/loader.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setDecoder):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::decoder):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
12:32 AM Changeset in webkit [11674] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.

  • Move handling of frame namespaces down to WebFrame.
  • Put some internal class declarations in the implementation file.
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _setFrameNamespace:]): (-[WebFrame _frameNamespace]):
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView setGroupName:]): (-[WebView groupName]):
  • WebView.subproj/WebViewInternal.h:

Dec 19, 2005:

2:16 PM Changeset in webkit [11673] by adele
  • 35 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • fast/text/atsui-multiple-renderers-expected.png: Added.
  • fast/text/atsui-multiple-renderers-expected.txt: Added.
  • fast/text/atsui-multiple-renderers.html: Added.
  • css1/text_properties/text-transCapitalize-expected.checksum:
  • css1/text_properties/text-transCapitalize-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.checksum:
  • fast/text/international/bidi-AN-after-L-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • fast/text/international/bidi-L2-run-reordering-expected.png:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • fast/text/international/bidi-LDB-2-CSS-expected.png:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • fast/text/international/bidi-LDB-2-HTML-expected.png:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-european-terminators-expected.checksum:
  • fast/text/international/bidi-european-terminators-expected.png:
  • fast/text/international/bidi-european-terminators-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • fast/text/international/bidi-fallback-font-weight-expected.png:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • fast/text/international/bidi-innertext-expected.checksum:
  • fast/text/international/bidi-innertext-expected.png:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-override-expected.checksum:
  • fast/text/international/bidi-override-expected.png:
  • fast/text/international/bidi-override-expected.txt:

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-multiple-renderers.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Fetch renderer info from the renderers array; add synthetic bold offset; render only synthetic bold in the synthetic bold pass. (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define. (initializeATSUStyle): Apply a skewing transform for synthetic oblique. (createATSUTextLayout): Merged into createATSUTextLayout. (createATSULayoutParameters): Merged in createATSUTextLayout; allocate and fill a renderers array and a character buffer for small caps and mirroring; (applyMirroringToRun): Merged into createATSULayoutParameters. (ATSU_drawHighlight): Deleted mirroring code. (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold. (ATSU_pointToOffset): Deleted mirroring code.
1:03 PM Changeset in webkit [11672] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: darin

  • Scripts/run-webkit-tests: stop /etc/catalog warnings
12:54 PM Changeset in webkit [11671] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-kerning-and-ligatures-expected.checksum: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.txt: Added.
  • fast/text/atsui-kerning-and-ligatures.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-kerning-and-ligatures.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeATSUStyle): Disable kerning; disable ligatures unless the font does not contain 'a', in which case it is assumed to never be rendered by the CG code path.
12:48 PM Changeset in webkit [11670] by darin
  • 3 edits in trunk/JavaScriptCore

Originally done by both George Staikos and Alexey Proskuryakov.

Our coding guidelines say "use 0 instead of NULL" and both RefPtr and
PassRefPtr were using NULL, which required including a header that
defines NULL.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Use 0 instead of NULL. (KXMLCore::PassRefPtr::operator!): Use ! instead of == NULL.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Use 0 instead of NULL. (KXMLCore::RefPtr::operator!): Use ! instead of == NULL. Also did some reformatting.
12:41 PM Changeset in webkit [11669] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Remove code to initialize the pointer; not needed since RefPtr gets initialized to 0. (ElementImpl::~ElementImpl): Remove code to deref the pointer; RefPtr handles that. (ElementImpl::attributes): Add get() call to get raw pointer. (ElementImpl::setAttributeMap): Remove code to deref the old map and set the new map. But added code to clear the element pointer from the old map (missing in the old version). Also added a FIXME. (ElementImpl::createAttributeMap): Remove ref(); RefPtr handles that. (NamedAttrMapImpl::addAttribute): Use a RefPtr to guarantee the element does not go away in the middle of dispatching DOM events. (StyledElementImpl::attributeChanged): Clean up code by using the inline function mappedAttributes() instead of doing type casts. (StyledElementImpl::parseMappedAttribute): Ditto. (StyledElementImpl::getClassList): Ditto.
  • khtml/xml/dom_elementimpl.h: Make ElementImpl::namedAttrMap be a RefPtr instead of raw pointer. Added an overload of StyledElementImpl::mappedAttributes for both const and non-const.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addChild): Use a RefPtr to ref/deref the child so that it doesn't leak.
  • khtml/html/htmlparser.h: Changed isindex to use a RefPtr.
  • khtml/html/htmlparser.cpp: (HTMLParser::~HTMLParser): Removed now-unneeded ref. (HTMLParser::isindexCreateErrorCheck): Remove now-unneeded deref/ref. (HTMLParser::handleIsindex): Put isindex element into a RefPtr. This prevents a crash that was otherwise happening during layout tests (caused indirectly by the changes above). (HTMLParser::startBody): Added call to get().
11:56 AM Changeset in webkit [11668] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Call poseAs to substitute our NSPasteboard class for the default one. Create a local pasteboard (really a global one with a unique name) and release it when exiting from the function so we don't leave it in the pasteboard server. (dumpRenderTree): Added an autorelease pool around one small bit of code that ddn't have one. Fixed a leak in an unlikely error case. (+[DumpRenderTreePasteboard generalPasteboard]): Override the default version of this method to return our local pasteboard.
11:53 AM Changeset in webkit [11667] by darin
  • 42 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff Garen and Eric Seidel.

  • kjs/simple_number.h: Removed many unnecessary includes, including the <cmath> one to work around GCC library header bugs. We may have to add some includes elsewhere for platforms other than OS X, since our prefix header takes care of some things.
  • kxmlcore/AlwaysInline.h: Added. Now clients that don't include simple_number.h can still get the ALWAYS_INLINE macro.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added AlwaysInline.h.
  • bindings/NP_jsobject.h: Removed a lot of unnecessary includes and removed C-specific stuff from this C++-only header.
  • bindings/jni/jni_jsobject.h: Removed a lot of unnecessary includes and did some reformatting.
  • bindings/objc/objc_runtime.h: Removed an unnecessary include.
  • bindings/runtime.h: Removed some unneeded includes. Reformatted.
  • bindings/runtime.cpp: Updated to compile with header changes, including a lot of reformatting.
  • bindings/runtime_object.h: Removed an unnecessary include.

WebCore:

Reviewed by Geoff Garen and Eric Seidel.

  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Added.
  • WebCorePrefix.h: Removed the use of <ostream>.
  • kwq/KWQDef.h: Removed now-unused Q_INT64, Q_INT16, Q_UINT16, qRound, and _KWQ_IOSTREAM_.
  • kwq/KWQKHTMLPart.h: Removed some unneeded headers and added forward-declarations of classes instead. Corrected some incorrect member function declarations.
  • kwq/KWQKHTMLPart.mm: Added a now-needed header.
  • khtml/ecma/kjs_window.cpp: Removed the <cmath> workaround.
  • khtml/rendering/bidi.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • khtml/rendering/render_canvasimage.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_image.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_text.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::calculateColor):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): Replaced use of qRound with use of lroundf or lround as appropriate.
  • kwq/KWQCString.h:
  • kwq/KWQCString.mm:
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm:
  • kwq/KWQMap.h:
  • kwq/KWQMemArray.h:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.h:
  • kwq/KWQPtrList.h:
  • kwq/KWQPtrStack.h:
  • kwq/KWQPtrVector.h:
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm:
  • kwq/KWQSize.h:
  • kwq/KWQSize.mm:
  • kwq/KWQValueList.h: Removed _KWQ_IOSTREAM_ code that was used at one time for unit tests, but is now unneeded, and requires <ostream>.
11:51 AM Changeset in webkit [12225] by darin
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Geoff Garen and Eric Seidel.

  • kxmlcore/AlwaysInline.h: Added.
11:50 AM Changeset in webkit [11666] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen and John Sullivan.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:_webcore_dictionaryWithHeaderString:]): Check length of string before calling characterAtIndex:0 since it will fail for an empty string.
11:41 AM Changeset in webkit [11665] by bdakin
  • 2 edits
    1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:37 AM Changeset in webkit [11664] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/should-use-atsui-expected.checksum: Added.
  • fast/text/should-use-atsui-expected.png: Added.
  • fast/text/should-use-atsui-expected.txt: Added.
  • fast/text/should-use-atsui.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/should-use-atsui.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Always start scanning from 0 since drawing and highlighting also measure everything up to run->from.
11:17 AM Changeset in webkit [11663] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

  • khtml/ecma/xmlhttprequest.cpp: (getMIMEType): A helper function to get MIME type from a Content-Type string. (getCharset): A helper function to get charset from a Content-Type string. (KJS::XMLHttpRequest::getValueProperty): Factored out responseIsXML(). (KJS::XMLHttpRequest::getResponseHeader): Return QString instead of JSValue (to get rid of unnecessary JSLocks). (KJS::XMLHttpRequest::responseIsXML): A new method that analyses Content-Type. (KJS::XMLHttpRequest::slotData): Use a correct charset for responses, see bug for details. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Update for getResponseHeader() changes
  • khtml/ecma/xmlhttprequest.h:
11:16 AM Changeset in webkit [11662] by thatcher
  • 1 add in trunk/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

2:38 AM Changeset in webkit [11661] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adele

  • replaced custom Identifier hashtable with HashSet
  • kjs/identifier.cpp: (KXMLCore::): (KJS::identifierTable): (KJS::Identifier::equal): (KJS::hash): (KJS::equal): (KJS::convert): (KJS::Identifier::add): (KJS::Identifier::remove):
  • kjs/identifier.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
2:32 AM Changeset in webkit [11660] by mjs
  • 4 edits
    4 deletes in trunk

WebCore:

Rubber stamped by Eric.

  • removed unused SPI headers
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/DOM-compat.h: Removed.

WebKit:

Rubber stamped by Eric.

  • remove some unused SPI headers.
  • DOM.subproj/WebDOMDocument.h: Removed.
  • DOM.subproj/WebDOMElement.h: Removed.
  • DOM.subproj/WebDOMNode.h: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Dec 18, 2005:

4:27 PM Changeset in webkit [11659] by darin
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed, tweaked, and landed by Darin.

  • kjs/array_object.h:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added implementation of indexOf.

LayoutTests:

Reviewed, tweaked, and landed by Darin.

  • fast/js/array-indexof-expected.txt: Added.
  • fast/js/array-indexof.html: Added.
3:41 PM Changeset in webkit [11658] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.
3:40 PM Changeset in webkit [11657] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast pointer to a TextImpl before calling containsOnlyWhitespace; the code already checked isTextNode.
  • khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an if statement into a few separate ones for slight additional clarity. Added a check of isTextNode and cast pointer to a TextImpl.
  • khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.
  • khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.
2:55 PM Changeset in webkit [11656] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

Test: fast/text/international/bidi-ignored-for-first-child-inline.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiNext): Adjust embedding at inline containers' boundaries instead of inside. (khtml::RenderBlock::bidiFirst): (khtml::RenderBlock::determineStartPosition):
2:37 PM Changeset in webkit [11655] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • test of a particular character set name that is not in the WebCore table but is in the ICU table (see bugzilla 5932)
  • fast/encoding/charset-cp1251-expected.txt: Added.
  • fast/encoding/charset-cp1251.html: Added.

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName): Fall back on ICU encoding names if we don't find the name in the WebCore encoding names table.
2:23 PM Changeset in webkit [11654] by darin
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • XSLT document encoding tests
  • fast/xsl/xslt-doc-enc-expected.txt: Added.
  • fast/xsl/xslt-doc-enc.xml: Added.
  • fast/xsl/xslt-doc-enc.xsl: Added.
  • fast/xsl/xslt-doc-noenc-expected.txt: Added.
  • fast/xsl/xslt-doc-noenc.xml: Added.
  • fast/xsl/xslt-doc-noenc.xsl: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform): Get encoding from transform and pass in to XSLTProcessor.
  • khtml/xsl/xslt_processorimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter. Create a Decoder and use it to decode the source document (default encoding UTF-8). (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the encoding from the libxml2 document object. (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass in to XSLTProcessor. (DOM::XSLTProcessorImpl::transformToFragment): Ditto.
2:13 PM Changeset in webkit [11653] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Fix incorrectly nested else.
5:28 AM Changeset in webkit [11652] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date

5:27 AM Changeset in webkit [11651] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4000
Object.prototype is missing isPrototypeOf

  • fast/js/test-isPrototypeOf-expected.txt: Added.
  • fast/js/test-isPrototypeOf.html: Added.
5:27 AM Changeset in webkit [11650] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add isPrototypeOf to object prototype.

(ObjectProtoFunc::callAsFunction):
Implement isPrototypeOf

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add id for isPrototypeOf.
1:20 AM Changeset in webkit [11649] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

updaated changelog to remove previous suggestion that darin was a nobody

Dec 17, 2005:

9:01 PM Changeset in webkit [11648] by darin
  • 2 edits
    3 adds in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
  • manual-tests/resources/frame1.html: Added.
  • manual-tests/resources/frame2.html: Added.
7:09 PM Changeset in webkit [11647] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

  • fast/js/string-split-ignore-case-expected.txt: Added.
  • fast/js/string-split-ignore-case.html: Added.
7:09 PM Changeset in webkit [11646] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

Glossary:
RegExpImp: The C++ object you get when JavaScript executes

"new RegExp()".

RegExp: A C++ wrapper object that performs regular expression

matching on behalf of a RegExpImp.

Instead of unnecessarily constructing a RegExp which (wrongly) lacks
any modifiers, String.split() now uses the RegExp built in to the
RegExpImp passed to it, which has the right modifiers already.

I also cleaned up other bits of the string code to standardized how
we handle RegExpImp arguments.

  • ChangeLog:
  • kjs/string_object.cpp: (replace): (StringProtoFunc::callAsFunction):
12:12 PM Changeset in webkit [11645] by andersca
  • 2 edits in trunk/WebCore

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
12:09 PM Changeset in webkit [11644] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
10:10 AM Changeset in webkit [11643] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/text/atsui-rtl-override-selection-expected.checksum: Added.
  • fast/text/atsui-rtl-override-selection-expected.png: Added.
  • fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • fast/text/atsui-rtl-override-selection.html: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing it with a text direction parameter.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
  • kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag in the style instead.
  • kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

WebKit:

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Update since the layout only includes from -> to now. (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove reversed parameter. (CG_floatWidthForRun): Add code to handle RTL case. (addDirectionalOverride): Put the override around the entire run. (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work. Also round. (ATSU_pointToOffset): Remove reversed parameter and run swapping. (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.

Dec 16, 2005:

4:46 PM Changeset in webkit [11642]
  • 211 copies
    17 deletes in tags/WebCore-417~15

This commit was manufactured by cvs2svn to create tag
'WebCore-417~15'.

4:46 PM Changeset in webkit [11641] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.15

3:01 PM Changeset in webkit [11640] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:56 PM Changeset in webkit [11639] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:48 PM Changeset in webkit [11638] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/ustring.cpp

Add assert.h include to ustring.cpp

2:45 PM Changeset in webkit [11637] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

ifdef out the getpid call on windows.

2:27 PM Changeset in webkit [11636] by hyatt
  • 2 edits in trunk/JavaScriptCore

Remove unused RefPtr constructors that can create an ambiguity in ustring on some platforms.

Reviewed by mjs

  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr):
2:26 PM Changeset in webkit [11635] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6106
Submitted by: eseidel
Reviewed by: darin

DOMString should hold its impl in a RefPtr
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6106
I also cleaned up spacing in dom_string.cpp
No tests needed (no functionality changes).

  • khtml/dom/dom_string.cpp: (DOM::DOMString::DOMString): (DOM::DOMString::operator += ): (DOM::DOMString::insert): (DOM::DOMString::operator []): (DOM::DOMString::find): (DOM::DOMString::length): (DOM::DOMString::truncate): (DOM::DOMString::remove): (DOM::DOMString::split): (DOM::DOMString::lower): (DOM::DOMString::upper): (DOM::DOMString::percentage): (DOM::DOMString::unicode): (DOM::DOMString::qstring): (DOM::DOMString::toInt): (DOM::DOMString::copy): (DOM::strcasecmp): (DOM::DOMString::toCoordsArray): (DOM::DOMString::toLengthArray): (DOM::operator==):
  • khtml/dom/dom_string.h: (DOM::DOMString::DOMString): (DOM::DOMString::impl):
2:16 PM Changeset in webkit [11634]
  • 26 copies
    3 deletes in tags/WebKit-312~8

This commit was manufactured by cvs2svn to create tag 'WebKit-312~8'.

2:16 PM Changeset in webkit [11633] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning.

1:43 PM Changeset in webkit [11632] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6110
Submitted by: eseidel
Reviewed by: darin

No test cases needed (no functionality changes).

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::XSLImportRuleImpl): (DOM::XSLImportRuleImpl::~XSLImportRuleImpl): (DOM::XSLImportRuleImpl::setStyleSheet):
  • khtml/xsl/xsl_stylesheetimpl.h: (DOM::XSLImportRuleImpl::styleSheet):
1:30 PM Changeset in webkit [11631] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
1:21 PM Changeset in webkit [11630] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim O.

  • fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari
  • khtml/ecma/kjs_window.cpp:
12:35 PM Changeset in webkit [11629] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
12:33 PM Changeset in webkit [11628] by hyatt
  • 1 edit in trunk/JavaScriptCore/kxmlcore/HashTraits.h

Don't include bits/cpp_type_traits on win32

12:27 PM Changeset in webkit [11627]
  • 120 copies
    5 deletes in tags/WebCore-315~13

This commit was manufactured by cvs2svn to create tag
'WebCore-315~13'.

12:27 PM Changeset in webkit [11626] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.13

11:30 AM Changeset in webkit [11625] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
10:35 AM Changeset in webkit [11624] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

Layout test added:

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): Changed initialization of KConfig from empty string to pluginsinfo.
10:34 AM Changeset in webkit [11623] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
10:20 AM Changeset in webkit [11622] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • fast/text/international/bidi-european-terminators-expected.png: Added.
  • fast/text/international/bidi-european-terminators-expected.txt: Added.
  • fast/text/international/bidi-european-terminators.html: Added.
10:18 AM Changeset in webkit [11621] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin.

Test: fast/text/international/bidi-european-terminators.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Keep track of the last position before the current run of ETs directly using a new BidiState member, lastBeforeET.
8:51 AM Changeset in webkit [11620] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • Added layout tests Evan Gross contributed about converting to attributed string. The results here currently seem wrong, but are what I get with TOT.
  • fast/text/attributed-substring-from-range-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range.html: Added.
8:51 AM Changeset in webkit [11619] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]): Implement by calling the same RTF conversion used when copying to the pasteboard.
8:40 AM Changeset in webkit [11618] by darin
  • 20 edits in trunk

LayoutTests:

Reviewed and landed by Darin.

Updated tests that include RTL or "bidi override" runs since DumpRenderTree now
dumps those runs.

  • fast/block/basic/016-expected.txt:
  • fast/block/float/026-expected.txt:
  • fast/block/float/028-expected.txt:
  • fast/block/positioning/auto/006-expected.txt:
  • fast/dom/HTMLElement/bdo-expected.txt:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-CS-after-AN-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-explicit-embedding-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • fast/text/international/bidi-override-expected.txt:

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.
8:18 AM Changeset in webkit [11617] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed and landed by Darin.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6043
Incorrect selection highlighting in pre-formatted text with tabs

  • khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width(). (InlineTextBox::selectionRect): (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::paintMarker): (InlineTextBox::paintMarkedTextUnderline):
  • manual-tests/pre-tab-selection-rect.html: Added.
8:13 AM Changeset in webkit [11616] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • fast/js/replace-child-siblings-expected.txt: Added.
  • fast/js/replace-child-siblings.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/js/replace-child-siblings.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::replaceChild): If the new child was right before or right after the old child, then it just stays.
8:11 AM Changeset in webkit [11615] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebImageView.m: (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey for the image renderer and WebElementImageKey for the image.
12:08 AM Changeset in webkit [11614] by darin
  • 30 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/internal.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::evaluate): Change to take a character pointer and length rather than a UString.
  • kjs/interpreter.h:
  • kjs/interpreter.cpp: (Interpreter::evaluate): Ditto.
  • kjs/protect.h: Remove uneeded "convert to bool" operator since we already have a "convert to raw pointer" operator in this class.

WebCore:

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of listenerObjImp.
  • khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getListener): Ditto. (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.
  • khtml/ecma/kjs_events.cpp: (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file. (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double logging, and fixed code path to not use UString::ascii(). (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type of the window object is now Window. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto. (KJS::JSUnprotectedEventListener::windowObj): Ditto. (KJS::JSEventListener::JSEventListener): Ditto. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSEventListener::windowObj): Ditto. (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be a DOMString instead of a QString. (KJS::JSLazyEventListener::handleEvent): Removed function because the base class handleEvent already calls listenerObj which takes care of parseCode -- no need to do an additional parseCode here. (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now a DOMString instead of a QString. (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for the clipboard object. (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.
  • khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed destructors from many classes that don't need them. Used a RefPtr for the ClipboardImpl in a Clipboard object.
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString. (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code. (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute pointer. Calls through after extracting the code from the attribute value.
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New version of function that takes an attribute pointer; calls through to the base class after extracting the code from the attribute value.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener and setHTMLEventListener that takes an attribute pointer. (HTMLFrameElementImpl::parseMappedAttribute): Ditto. (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_headimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take a DOMString. (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.
  • khtml/khtml_part.h:
  • khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code.
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript machinery. Use QString::fromNSString instead for now.
12:04 AM Changeset in webkit [12224] by darin
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • JSRun.cpp: (JSRun::Evaluate): Updated for change to Interpreter::evaluate.

Dec 15, 2005:

11:51 PM Changeset in webkit [11613] by darin
  • 2 edits in trunk/WebCore
  • fix crash caused by my last check-in
  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction): Use RefPtr to ref/deref the tokenizer.
11:28 PM Changeset in webkit [11612] by darin
  • 2 edits in trunk/WebCore
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText): Add missing null check.
10:39 PM Changeset in webkit [11611] by ggaren
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/4381444> Remove GMail-specific work-around
previously added.

Reviewed by Darin.

No test case because this patch just turns on already-tested behavior
for GMail.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Removed code that hid the selectionEnd property from sites on the GMail domain.
10:33 PM Changeset in webkit [11610] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer): Initialize the new m_currentNodeIsReferenced field to false for the document case, and true for the non-0 fragment case. Also don't reference the document in the document tokenizer case to avoid a circular reference -- HTML parser already does both of these things. (khtml::XMLTokenizer::~XMLTokenizer): Call setCurrentNode(0) to release the current node in case the tokenizer is being destroyed without finishing parsing. Only call deref on the document inthe fragment-parsing case. (khtml::XMLTokenizer::setCurrentNode): Added. Reference the current node only if it's not the document. Just as with the HTML parser, use a boolean to track whether the current node needs a deref or not. (khtml::XMLTokenizer::startElementNs): Use a RefPtr to keep the newly created element alive at least until setCurrentNode is called. Remove the bogus explicit delete of of the node after calling addChild, since reference counting takes care of it. Stop parsing if we fail to create an element. (khtml::XMLTokenizer::endElementNs): Use setCurrentNode and use a local variable to avoid reference count thrash. (khtml::XMLTokenizer::characters): Changed to only support text nodes. CDATA no longer calls this function. (khtml::XMLTokenizer::enterText): Use setCurrentNode, and remove bogus delete call. (khtml::XMLTokenizer::exitText): Add checks for stopped parser and for whether the current node is a text node so this can be called unconditionally. (khtml::XMLTokenizer::cdataBlock): Use setCurrentNode and move the call before the call to attach to make sure the node is already ref'd when attach is called. (khtml::XMLTokenizer::finish): Call setCurrentNode(0) to release the nodes we've been parsing. (khtml::XMLTokenizer::executeScripts): Fixed incorrect cast to TextImpl to cast to the base class CharacterDataImpl instead.
6:30 PM Changeset in webkit [11609] by eseidel
  • 9 edits
    1 delete in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim hatcher

Made SVG on by default!
Also removed last two KHTML_NO_CPLUSPLUS_DOM #ifs and turned off.
Removed APPLE_COMPILE_HACK, fixing or replacing with #if 0 for now.

  • WebCore.xcodeproj/project.pbxproj: Made SVG default!
  • ksvg2/KSVGSettings.cpp: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp: fixed copyright.
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished): fixed
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): removed dead code.
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): #if 0 (SVGImageElementImpl::notifyFinished): #if 0
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::pixelUnitToMillimeterX): #if 0 (SVGSVGElementImpl::pixelUnitToMillimeterY): #if 0
  • kwq/DOM.mm: removed KHTML_NO_CPLUSPLUS_DOM (ObjCNodeFilterCondition::acceptNode):
  • kwq/KWQKHTMLPart.mm: removed KHTML_NO_CPLUSPLUS_DOM
6:21 PM Changeset in webkit [11608] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

  • Scripts/build-webkit: --svg is now default!
6:16 PM Changeset in webkit [11607] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Don't run svg test automatically if +SVG is built (yet).

  • Scripts/run-webkit-tests:
4:17 PM Changeset in webkit [11606]
  • 211 copies
    17 deletes in tags/WebCore-417~14

This commit was manufactured by cvs2svn to create tag
'WebCore-417~14'.

4:17 PM Changeset in webkit [11605] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:08 PM Changeset in webkit [11604] by eseidel
  • 5 edits in trunk/WebCore

Bug #:
Submitted by: eseidel
Reviewed by: none

Fix build break. (Files missed in previous commit.)

  • khtml/css/csshelper.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/rendering/render_canvasimage.cpp:
  • khtml/rendering/render_image.cpp:
3:40 PM Changeset in webkit [11603] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Test for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - ​http://www.mattkruse.com/javascript/datadumper/

  • fast/forms/option-index-expected.checksum: Added.
  • fast/forms/option-index-expected.png: Added.
  • fast/forms/option-index-expected.txt: Added.
  • fast/forms/option-index.html: Added.

WebCore:

Reviewed by John.

Test: fast/forms/option-index.html

  • khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::index): nil check for select element.
2:31 PM Changeset in webkit [11602] by eseidel
  • 36 edits
    60 deletes in trunk/WebCore

Bug #: 6091
Submitted by: eseidel
Reviewed by: darin

Remove more legacy code from khtml/kwq
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6091

No tests needed, no functionality changes.

  • ForwardingHeaders/kapplication.h: Removed.
  • ForwardingHeaders/kcompletionbox.h: Removed.
  • ForwardingHeaders/kdatastream.h: Removed.
  • ForwardingHeaders/kfiledialog.h: Removed.
  • ForwardingHeaders/kfileitem.h: Removed.
  • ForwardingHeaders/khtml_iface.h: Removed.
  • ForwardingHeaders/khtml_pagecache.h: Removed.
  • ForwardingHeaders/khtml_printsettings.h: Removed.
  • ForwardingHeaders/khtml_run.h: Removed.
  • ForwardingHeaders/kiconloader.h: Removed.
  • ForwardingHeaders/kio/kprotocolmanager.h: Removed.
  • ForwardingHeaders/kio/netaccess.h: Removed.
  • ForwardingHeaders/kmessagebox.h: Removed.
  • ForwardingHeaders/kmimetype.h: Removed.
  • ForwardingHeaders/kmultipledrag.h: Removed.
  • ForwardingHeaders/kparts/partmanager.h: Removed.
  • ForwardingHeaders/kprinter.h: Removed.
  • ForwardingHeaders/kprotocolmanager.h: Removed.
  • ForwardingHeaders/ksimpleconfig.h: Removed.
  • ForwardingHeaders/ksslcertchain.h: Removed.
  • ForwardingHeaders/ksslinfodlg.h: Removed.
  • ForwardingHeaders/kstdaction.h: Removed.
  • ForwardingHeaders/ktempfile.h: Removed.
  • ForwardingHeaders/ktrader.h: Removed.
  • ForwardingHeaders/kurldrag.h: Removed.
  • ForwardingHeaders/kxmlguifactory.h: Removed.
  • ForwardingHeaders/netaccess.h: Removed.
  • ForwardingHeaders/private/qucomextra_p.h: Removed.
  • ForwardingHeaders/qasyncimageio.h: Removed.
  • ForwardingHeaders/qbitmap.h: Removed.
  • ForwardingHeaders/qclipboard.h: Removed.
  • ForwardingHeaders/qdir.h: Removed.
  • ForwardingHeaders/qdrawutil.h: Removed.
  • ForwardingHeaders/qfontdatabase.h: Removed.
  • ForwardingHeaders/qfontinfo.h: Removed.
  • ForwardingHeaders/qglobal.h: Removed.
  • ForwardingHeaders/qhbox.h: Removed.
  • ForwardingHeaders/qinputdialog.h: Removed.
  • ForwardingHeaders/qintcache.h: Removed.
  • ForwardingHeaders/qmetaobject.h: Removed.
  • ForwardingHeaders/qmovie.h: Removed.
  • ForwardingHeaders/qobjectlist.h: Removed.
  • ForwardingHeaders/qtooltip.h: Removed.
  • ForwardingHeaders/scheduler.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/kjs_window.moc: Removed.
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::HTMLDocumentImpl):
  • khtml/html/html_documentimpl.moc: Removed.
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/html/htmltokenizer.moc: Removed.
  • khtml/khtml_part.cpp: (KHTMLPart::didOpenURL): (KHTMLPart::stopLoading): (KHTMLPart::createJavaContext): (KHTMLPart::begin): (KHTMLPart::slotRedirection): (KHTMLPart::setSelection): (KHTMLPart::handleFallbackContent):
  • khtml/khtml_part.h:
  • khtml/khtml_part.moc: Removed.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLView::KHTMLView): (KHTMLView::init): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
  • khtml/khtmlview.h:
  • khtml/khtmlview.moc: Removed.
  • khtml/misc/loader.cpp: (CachedImage::CachedImage): (CachedImage::ref): (CachedImage::deref): (CachedImage::pixmap_size): (CachedImage::valid_rect): (CachedImage::clear): (CachedXSLStyleSheet::CachedXSLStyleSheet): (Cache::clear): (Cache::flush): (Cache::getStatistics): (Cache::setCacheDisabled):
  • khtml/misc/loader.h:
  • khtml/misc/loader.moc: Removed.
  • khtml/rendering/render_form.cpp: (ComboBoxWidget::ComboBoxWidget): (RenderSelect::createListBox): (RenderSlider::slotClicked):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.moc: Removed.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
  • khtml/rendering/render_frames.moc: Removed.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy): (RenderWidget::setSelectionState):
  • khtml/rendering/render_replaced.moc: Removed.
  • khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::cloneNode):
  • khtml/xml/dom_docimpl.moc: Removed.
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xml/xml_tokenizer.moc: Removed.
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • kwq/KWQApplication.h: (QApplication::sendEvent):
  • kwq/KWQComboBox.h:
  • kwq/KWQKApplication.h: Removed.
  • kwq/KWQKHTMLPageCache.h: Removed.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKHistoryProvider.mm:
  • kwq/KWQKJavaAppletContext.h: (KJavaAppletContext::KJavaAppletContext):
  • kwq/KWQKPartsHistoryProvider.h:
  • kwq/KWQKPartsPartManager.h: Removed.
  • kwq/KWQMovie.h: Removed.
  • kwq/KWQMovie.mm: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm:
  • kwq/KWQWidget.h:
2:17 PM Changeset in webkit [11601] by mjs
  • 7 edits in trunk/WebKit

Reviewed by Darin.

  • remove _frameForView: method from WebView and replace with a direct pointer on the WebFrameView in the WebFrame
  • Misc.subproj/WebNSViewExtras.m:
  • WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame initWithName:webFrameView:webView:]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _setWebFrame:]): (-[WebFrameView webFrame]):
  • WebView.subproj/WebFrameViewInternal.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
1:39 PM Changeset in webkit [11600] by eseidel
  • 10 edits in trunk/WebCore

Bug #: 6094
Submitted by: eseidel
Reviewed by: darin

khtml/css should use RefPtr instead of manual ref() deref()
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6094

No functionality changes, thus no tests.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSFontFaceRuleImpl::CSSFontFaceRuleImpl): (DOM::CSSFontFaceRuleImpl::~CSSFontFaceRuleImpl): (DOM::CSSImportRuleImpl::CSSImportRuleImpl): (DOM::CSSImportRuleImpl::~CSSImportRuleImpl): (DOM::CSSImportRuleImpl::setStyleSheet): (DOM::CSSMediaRuleImpl::CSSMediaRuleImpl): (DOM::CSSMediaRuleImpl::~CSSMediaRuleImpl): (DOM::CSSPageRuleImpl::CSSPageRuleImpl): (DOM::CSSPageRuleImpl::~CSSPageRuleImpl): (DOM::CSSStyleRuleImpl::CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::~CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::setDeclaration):
  • khtml/css/css_ruleimpl.h: (DOM::CSSFontFaceRuleImpl::style): (DOM::CSSImportRuleImpl::media): (DOM::CSSImportRuleImpl::styleSheet): (DOM::CSSMediaRuleImpl::cssRules): (DOM::CSSPageRuleImpl::style): (DOM::CSSStyleRuleImpl::style): (DOM::CSSStyleRuleImpl::declaration):
  • khtml/css/css_stylesheetimpl.cpp: (StyleSheetImpl::StyleSheetImpl): (StyleSheetImpl::~StyleSheetImpl): (StyleSheetImpl::setMedia):
  • khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::media):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue): (DOM::CSSMutableStyleDeclarationImpl::merge): (DOM::CSSStyleDeclarationImpl::diff): (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::CSSPrimitiveValueImpl::cleanup): (DOM::CSSPrimitiveValueImpl::cssText): (DOM::RectImpl::RectImpl): (DOM::RectImpl::~RectImpl): (DOM::RectImpl::setTop): (DOM::RectImpl::setRight): (DOM::RectImpl::setBottom): (DOM::RectImpl::setLeft): (DOM::PairImpl::PairImpl): (DOM::PairImpl::~PairImpl): (DOM::PairImpl::setFirst): (DOM::PairImpl::setSecond): (DOM::CSSBorderImageValueImpl::CSSBorderImageValueImpl): (DOM::CSSBorderImageValueImpl::~CSSBorderImageValueImpl):
  • khtml/css/css_valueimpl.h: (DOM::RectImpl::top): (DOM::RectImpl::right): (DOM::RectImpl::bottom): (DOM::RectImpl::left): (DOM::PairImpl::first): (DOM::PairImpl::second): (DOM::DashboardRegionImpl::setNext): (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::value):
  • khtml/css/cssparser.cpp: (CSSParser::parseColor):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::transformToString):
1:37 PM Changeset in webkit [11599] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.
1:36 PM Changeset in webkit [11598] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.
1:06 PM Changeset in webkit [11597] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Test for <rdar://problem/4381360>, ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6100
REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)

  • fast/overflow/overflow-focus-ring-expected.checksum: Added.
  • fast/overflow/overflow-focus-ring-expected.png: Added.
  • fast/overflow/overflow-focus-ring-expected.txt: Added.
  • fast/overflow/overflow-focus-ring.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Fixed <rdar://problem/4381360> REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6100

Test: fast/overflow/overflow-focus-ring.html

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): For overflow, we don't need to compute the rects for the children.
12:20 PM Changeset in webkit [11596] by darin
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • removed unnecessary conversion between AtomicString and QString
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions. (HTMLScriptElementImpl::insertedIntoDocument): Ditto.
12:10 PM Changeset in webkit [12223] by darin
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Tim Hatcher.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed some redundant build settings, turned off prebinding explicitly for our Development and Deployment builds, remove .exp file from sources. All "clean-up".
11:37 AM Changeset in webkit [11595] by hyatt
  • 1 edit in trunk/WebCore/ksvg2/css/svg.css

Bug #:
Submitted by:
Reviewed by:

11:07 AM Changeset in webkit [11594]
  • 211 copies
    17 deletes in tags/WebCore-417~13

This commit was manufactured by cvs2svn to create tag
'WebCore-417~13'.

11:07 AM Changeset in webkit [11593] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

9:42 AM Changeset in webkit [11592] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't run tests in directories named "svg" if SVG support is not compiled in. Report the 10 slowest tests if "--slowest" is passed on the command line.
9:14 AM Changeset in webkit [11591] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result -- this test now succeeds due to some recent change
  • dom/xhtml/level2/html/HTMLTextAreaElement12-expected.txt: Regenerated.

Dec 14, 2005:

8:51 PM Changeset in webkit [11590] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
8:29 PM Changeset in webkit [11589] by adele
  • 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
3:32 PM Changeset in webkit [11588] by eseidel
  • 46 edits
    4 deletes in trunk/WebCore

Bug #: 6078
Submitted by: eseidel
Reviewed by: darin

SVG test cases changed (now the svg.css is loaded properly).
No other functionality changes, just code removal.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6078

  • ForwardingHeaders/klibloader.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::eventParameterName): (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::implementsCall):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_proxy.h: (KJSProxyImpl::setEventHandlerLineno):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieve): (KJS::Window::clear): (KJS::ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData):
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::evaluateScript):
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::processToken):
  • khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::jScript): (KHTMLPart::executeScript): (KHTMLPart::write): (KHTMLPart::reparseConfiguration): (KHTMLPart::createHTMLEventListener):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/misc/decoder.cpp:
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript):
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/table_layout.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitOpen): (DocumentImpl::write):
  • khtml/xml/dom_nodeimpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid):
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQKGlobal.h:
  • kwq/KWQKHTMLFactory.h: (KHTMLFactory::vLinks):
  • kwq/KWQKHTMLFactory.mm:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::userGestureHint): (KWQKHTMLPart::bindingRootObject):
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::fantasyFontName): (KHTMLSettings::isJavaScriptEnabled):
  • kwq/KWQKInstance.h: Removed.
  • kwq/KWQKLibrary.h: Removed.
  • kwq/KWQKPartsFactory.h: Removed.
  • kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::name):
  • kwq/KWQKStandardDirs.h:
  • kwq/KWQKStandardDirs.mm: (locate):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge executionContextForView:]):
2:49 PM Changeset in webkit [11587] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:45 PM Changeset in webkit [11586] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:39 PM Changeset in webkit [11585] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:21 PM Changeset in webkit [11584] by bdakin
  • 3 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:46 AM Changeset in webkit [11583] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Layout test for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • fast/overflow/overflow-text-hit-testing-expected.checksum: Added.
  • fast/overflow/overflow-text-hit-testing-expected.png: Added.
  • fast/overflow/overflow-text-hit-testing-expected.txt: Added.
  • fast/overflow/overflow-text-hit-testing.html: Added.

WebCore:

Reviewed by Darin & Geoff, committed by Adele.

Test: fast/overflow/overflow-text-hit-testing.html

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Adjust for containing block scroll
10:19 AM Changeset in webkit [11582] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4362
Add mac-cyrillic to the list of encodings

  • kwq/mac-encodings.txt: Added maccyrillic

Dec 13, 2005:

11:48 PM Changeset in webkit [11581] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

  • fast/forms/checkbox-radio-onchange-expected.checksum: Added.
  • fast/forms/checkbox-radio-onchange-expected.png: Added.
  • fast/forms/checkbox-radio-onchange-expected.txt: Added.
  • fast/forms/checkbox-radio-onchange.html: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

Test: fast/forms/checkbox-radio-onchange.html

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state. This will match our old behavior, and Firefox behavior. This will also fire onChange for radio buttons which matches Firefox behavior.
10:16 PM Changeset in webkit [11580] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
6:22 PM Changeset in webkit [11579] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

5:14 PM Changeset in webkit [11578]
  • 5 copies in tags/Safari-521~5

This commit was manufactured by cvs2svn to create tag 'Safari-521~5'.

5:14 PM Changeset in webkit [11577] by thatcher
  • 3 edits in trunk

Adding release markers.

5:12 PM Changeset in webkit [12222] by thatcher
  • 1 edit in trunk/JavaScriptGlue/ChangeLog

Adding release markers.

5:00 PM Changeset in webkit [12221] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by darin.

  • UserObjectImp.cpp: (UserObjectImp::userObjectGetter): Updated to reflect new argument that getters take (unused here).
  • UserObjectImp.h:
4:40 PM Changeset in webkit [11576] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS shorthand serialization.

  • fast/dom/css-shortHands-expected.checksum: Added.
  • fast/dom/css-shortHands-expected.png: Added.
  • fast/dom/css-shortHands-expected.txt: Added.
  • fast/dom/css-shortHands.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-shortHands.html

First cut at leaving off implicit values in shorthand properties.
Need to account for multipl backgrounds and "border" later.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue):
3:29 PM Changeset in webkit [11575] by thatcher
  • 3 edits in branches/Safari-Leo-branch

Versioning

2:05 PM Changeset in webkit [11574] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated test results to match Anders's last fix.

  • tests/mozilla/expected.html:
1:42 PM Changeset in webkit [11573] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles to the recent bugzilla bugs.
1:38 PM Changeset in webkit [11572] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Correct a date.

1:37 PM Changeset in webkit [11571] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles for my bugzilla bugs.
1:37 PM Changeset in webkit [11570] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/property-getters-and-setters-expected.txt: Added.
  • fast/js/property-getters-and-setters.html: Added.
  • ChangeLog: Add titles for the bugzilla urls.
1:29 PM Changeset in webkit [11569] by andersca
  • 10 edits in trunk/WebCore

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMMediaList::indexGetter): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSValueList::indexGetter):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMElement::attributeGetter): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::formNameGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::HTMLCollection::lengthGetter): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::nameGetter): (KJS::HTMLSelectCollection::selectedIndexGetter):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::indexGetter): (KJS::Plugins::nameGetter): (KJS::MimeTypes::indexGetter): (KJS::MimeTypes::nameGetter): (KJS::Plugin::indexGetter): (KJS::Plugin::nameGetter):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
  • khtml/ecma/kjs_window.h: Update for changes to PropertySlot::GetValueFunc.
1:26 PM Changeset in webkit [11568] by eseidel
  • 1 edit
    12 adds in trunk/LayoutTests

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

3 tests checking expected behavior for bad transform.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • svg/custom/transform-ignore-after-invalid-expected.checksum: Added.
  • svg/custom/transform-ignore-after-invalid-expected.png: Added.
  • svg/custom/transform-ignore-after-invalid-expected.txt: Added.
  • svg/custom/transform-ignore-after-invalid.svg: Added.
  • svg/custom/transform-invalid-expected.checksum: Added.
  • svg/custom/transform-invalid-expected.png: Added.
  • svg/custom/transform-invalid-expected.txt: Added.
  • svg/custom/transform-invalid.svg: Added.
  • svg/custom/transform-with-ending-space-expected.checksum: Added.
  • svg/custom/transform-with-ending-space-expected.png: Added.
  • svg/custom/transform-with-ending-space-expected.txt: Added.
  • svg/custom/transform-with-ending-space.svg: Added.
1:25 PM Changeset in webkit [11567] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

Fix crash on malformed transform attributes and transforms with
trailing spaces:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
1:24 PM Changeset in webkit [11566] by andersca
  • 27 edits in trunk/JavaScriptCore

2005-12-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter):
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (getProperty): Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/collector.cpp: (KJS::className): Handle GetterSetterType.
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter):
  • kjs/function.h: Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/grammar.y: Rework grammar parts for get set declarations directly in the object literal.
  • kjs/internal.cpp: (KJS::GetterSetterImp::mark): (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean): (KJS::GetterSetterImp::toNumber): (KJS::GetterSetterImp::toString): (KJS::GetterSetterImp::toObject): Add type conversion functions. These aren't meant to be called.

(KJS::printInfo):
Handle GetterSetterType.

  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter): Update for changes to PropertySlot::GetValueFunc.
  • kjs/nodes.cpp: Refactor they way properties nodes are implemented. We now have a PropertyListNode which is a list of PropertyNodes. Each PropertyNode has a name (which is a PropertyNameNode) and an associated value node. PropertyNodes can be of different types. The Constant type is the old constant declaration and the Getter and Setter types are for property getters and setters. (ResolveNode::evaluate): Update for changes to PropertySlot::getValue.

(PropertyListNode::evaluate):
Go through all property nodes and set them on the newly created object. If the
property nodes are of type Getter or Setter, define getters and setters. Otherwise,
just add the properties like before.

(PropertyNode::evaluate):
This should never be called directly.

(PropertyNameNode::evaluate):
Rename from PropertyNode::evaluate.

(FunctionCallResolveNode::evaluate):
(FunctionCallBracketNode::evaluate):
(FunctionCallDotNode::evaluate):
(PostfixResolveNode::evaluate):
(PostfixBracketNode::evaluate):
(PostfixDotNode::evaluate):
(TypeOfResolveNode::evaluate):
(PrefixResolveNode::evaluate):
(PrefixBracketNode::evaluate):
(PrefixDotNode::evaluate):
(AssignResolveNode::evaluate):
(AssignDotNode::evaluate):
(AssignBracketNode::evaluate):
Update for changes to PropertySlot::getValue.

  • kjs/nodes.h: (KJS::PropertyNameNode::PropertyNameNode): Rename from PropertyNode.

(KJS::PropertyNode::):
(KJS::PropertyNode::PropertyNode):
New class, representing a single property.

(KJS::PropertyListNode::PropertyListNode):
Rename from PropertyValueNode.

(KJS::FuncExprNode::FuncExprNode):
Put ParameterNode parameter last, and make it optional.

(KJS::ObjectLiteralNode::ObjectLiteralNode):
Use a PropertyListNode here now.

  • kjs/nodes2string.cpp: (PropertyListNode::streamTo): Iterate through all property nodes.

(PropertyNode::streamTo):
Print out the name and value. Doesn't handle getters and setters currently.

(PropertyNameNode::streamTo):
Rename from PropertyNode::streamTo.

  • kjs/object.cpp: (KJS::JSObject::get): Update for changes to PropertySlot::getValue.

(KJS::JSObject::put):
If the property already exists and has a Setter, invoke
the setter function instead of setting the property directly.

(KJS::JSObject::defineGetter):
(KJS::JSObject::defineSetter):
New functions for defining property getters and setters on the object.

  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::GetterSetterImp::GetterSetterImp): (KJS::GetterSetterImp::getGetter): (KJS::GetterSetterImp::setGetter): (KJS::GetterSetterImp::getSetter): (KJS::GetterSetterImp::setSetter): New class for properties which have getters and setters defined. This class is only used internally and should never be seen from the outside.

(KJS::JSObject::getOwnPropertySlot):

If the property is a getter, call setGetterSlot on the property slot.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add defineGetter, defineSetter, lookupGetter, lookupSetter to prototype.

(ObjectProtoFunc::callAsFunction):
Implement handlers for new functions.

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add ids for new functions.
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): Update for changes to PropertySlot::GetValueFunc.

(KJS::PropertySlot::functionGetter):
Call the function getter object and return its value.

  • kjs/property_slot.h: (KJS::PropertySlot::getValue): Add a new argument which is the original object that getPropertySlot was called on.

(KJS::PropertySlot::setGetterSlot):
(KJS::PropertySlot::):
New function which sets a getter slot. When getValue is called on a
getter slot, the getter function object is invoked.

  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter):
  • kjs/string_object.h: Update for changes to PropertySlot::GetValueFunc.
  • kjs/value.h: (KJS::): Add GetterSetterType and make GetterSetterImp a friend class of JSCell.
1:12 PM Changeset in webkit [11565]
  • 56 copies
    22 deletes in tags/WebKit-417~9

This commit was manufactured by cvs2svn to create tag 'WebKit-417~9'.

1:12 PM Changeset in webkit [11564]
  • 211 copies
    17 deletes in tags/WebCore-417~12

This commit was manufactured by cvs2svn to create tag
'WebCore-417~12'.

1:12 PM Changeset in webkit [11563] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning:
WebCore-417.12
WebKit-417.9

3:46 AM Changeset in webkit [11562] by mjs
  • 2 edits in trunk/WebCore
  • build fix for last-minute part of previous change
  • khtml/ecma/kjs_binding.cpp:
3:06 AM Changeset in webkit [11561] by mjs
  • 11 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • added a new HashCountedSet class for the common pattern of mapping items to counts that can change
  • kxmlcore/HashCountedSet.h: Added. (KXMLCore::HashCountedSet::*): Implemented, on top of HashMap.
  • kxmlcore/HashMap.h: (KXMLCore::HashMap::add): New method - does not replace existing value if key already present but otherwise like set(). (KXMLCore::HashMap::set): Improved comments.
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap::add): Added to specializations too.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
  • kxmlcore/HashFunctions.h: Added include of stdint.h
  • replaced the custom hashtable for values protected from GC with HashCountedSet
  • kjs/collector.cpp: (KJS::Collector::protect): Moved code here from ProtectedValues::increaseProtectCount since the code is so simple now. (KJS::Collector::unprotect): Ditto for ProtectedValues::decreaseProtectCount. (KJS::Collector::markProtectedObjects): Updated for new way of doing things, now simpler and safer. (KJS::Collector::numReferencedObjects): ditto (KJS::Collector::rootObjectClasses): ditto
  • kjs/collector.h: Added protect and unprotect static methods
  • kjs/protect.h: (KJS::gcProtect): Updated for removal of ProtectedValues class (KJS::gcUnprotect): likewise
  • kjs/protected_values.cpp: Removed.
  • kjs/protected_values.h: Removed.

WebCore:

Reviewed by Eric.

  • updated for new HashCountedSet class
  • ForwardingHeaders/kxmlcore/HashCountedSet.h: Added forwarding header.
  • khtml/ecma/kjs_binding.cpp: Moved #define to disable pointer specialization higher in the file.
3:04 AM Changeset in webkit [12220] by mjs
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Eric.

  • added forwarding header for HashCountedSet
  • kxmlcore/HashCountedSet.h: Added.

Dec 12, 2005:

8:39 PM Changeset in webkit [11560] by thatcher
  • 3 edits in trunk/WebKit

Revised fix.

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with GCC 3.3.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
  • WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
6:01 PM Changeset in webkit [11559] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with 3.3.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
  • WebCoreSupport.subproj/WebImageRenderer.h: Added missing methods for image and imageRef.
  • WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
5:50 PM Changeset in webkit [11558] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison

  • editing/selection/previous-line-position-expected.checksum: Added.
  • editing/selection/previous-line-position-expected.png: Added.
  • editing/selection/previous-line-position-expected.txt: Added.
  • editing/selection/previous-line-position.html: Added.
5:50 PM Changeset in webkit [11557] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original

This bug was filed as a reminder to remove the workaround for
<rdar://problem/4033202>. We fixed the problems with
VisiblePosition causing 4033202, so I removed the workaround
and added a layout test.

  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition):
5:36 PM Changeset in webkit [11556] by harrison
  • 2 edits
    8 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure
<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

  • editing/pasteboard/block-wrappers-necessary.html:

Removed empty p tag.

  • editing/pasteboard/paste-list-001-expected.checksum: Added.
  • editing/pasteboard/paste-list-001-expected.png: Added.
  • editing/pasteboard/paste-list-001-expected.txt: Added.
  • editing/pasteboard/paste-list-001.html: Added.
  • editing/pasteboard/paste-table-001-expected.checksum: Added.
  • editing/pasteboard/paste-table-001-expected.png: Added.
  • editing/pasteboard/paste-table-001-expected.txt: Added.
  • editing/pasteboard/paste-table-001.html: Added.
5:28 PM Changeset in webkit [11555] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

Fixed by having ReplaceSelectionCommand remove empty nodes just
from the ancestors of the node(s) moved by mergeStart, rather
than scanning the whole fragment.

Layout tests added:

editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-list-001.html

  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::isProbablyTableStructureNode): (khtml::ReplaceSelectionCommand::pruneEmptyNodes): Removed no longer needed functions.

(khtml::ReplaceSelectionCommand::doApply):
Remove ancestor nodes emptied by mergeStart.
Do that instead of calling pruneEmptyNodes().

  • khtml/editing/replace_selection_command.h: (khtml::ReplacementFragment::desiredStyles): Removed pruneEmptyNodes().
4:35 PM Changeset in webkit [11554] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-12-06 David Harrison <​harrison@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
4:21 PM Changeset in webkit [11553] by thatcher
  • 6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
4:12 PM Changeset in webkit [11552] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 David Harrison <​harrison@apple.com>

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

4:05 PM Changeset in webkit [11551] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
3:54 PM Changeset in webkit [11550] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
3:53 PM Changeset in webkit [11549] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
3:49 PM Changeset in webkit [11548] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
3:48 PM Changeset in webkit [11547] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-12 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
3:22 PM Changeset in webkit [11546] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
-performSelector:withObject:'s return value should only be checked if the method returns an object.

  • Carbon.subproj/HIWebView.m: (UpdateCommandStatus):
2:22 PM Changeset in webkit [11545] by thatcher
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS seletorText serialization.

  • fast/dom/css-selectorText-expected.checksum: Added.
  • fast/dom/css-selectorText-expected.png: Added.
  • fast/dom/css-selectorText-expected.txt: Added.
  • fast/dom/css-selectorText.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-selectorText.html

Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.

  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):
1:01 PM Changeset in webkit [11544] by sullivan
  • 2 edits in trunk/WebKit

Reviewed and checked in by John Sullivan.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6053
WebIconDatabase returns the Accessibility Verifier app icon instead of
a generic document icon

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): use file type iconForFileType:NSFileTypeForHFSTypeCode(kGenericDocumentIcon) instead of '????' to get the generic document icon.
11:42 AM Changeset in webkit [11543] by sullivan
  • 7 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • Made protocol <WebDocumentSelection> include protocol <WebDocumentText>, for clarity. This required moving some methods from WebTextView, which conformed to <WebDocumentText>, up into superclass WebSearchableTextView, which conformed to <WebDocumentSelection>.
  • Misc.subproj/WebSearchableTextView.m: (-[NSString supportsTextEncoding]): moved this method (unchanged) from subclass WebTextView (-[NSString string]): ditto (-[NSString attributedString]): ditto (-[NSString selectedString]): ditto (-[NSString selectedAttributedString]): ditto (-[NSString selectAll]): ditto (-[NSString deselectAll]): ditto
  • WebView.subproj/WebDocumentPrivate.h: made <WebDocumentSelection> incorporate <WebDocumentText> rather than just <NSObject>
  • WebView.subproj/WebHTMLView.h: removed <WebDocumentText> from protocol list since it's covered by <WebDocumentSelection>
  • WebView.subproj/WebPDFView.h: ditto
  • WebView.subproj/WebTextView.h: ditto
  • WebView.subproj/WebTextView.m: removed the methods that were moved into WebSearchableTextView.m
11:22 AM Changeset in webkit [11542] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
11:20 AM Changeset in webkit [11541] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

11:07 AM Changeset in webkit [11540] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
11:04 AM Changeset in webkit [11539] by adele
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
9:40 AM Changeset in webkit [11538] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

"S" and "T" path types handle control points incorrectly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

  • svg/custom/control-points-for-S-and-T-expected.checksum: Added.
  • svg/custom/control-points-for-S-and-T-expected.png: Added.
  • svg/custom/control-points-for-S-and-T-expected.txt: Added.
  • svg/custom/control-points-for-S-and-T.svg: Added.
9:37 AM Changeset in webkit [11537] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

Test: svg/custom/control-points-for-S-and-T.svg

"S" and "T" path types handle control points incorrectly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
9:25 AM Changeset in webkit [11536] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 6039
Submitted by: eseidel
Reviewed by: darin

No test cases needed, no functionality change.
Corrected spacing, and conformance with style guidelines.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6039

  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h: (KCanvasFEComponentTransfer::setRedFunction): (KCanvasFEComponentTransfer::setGreenFunction): (KCanvasFEComponentTransfer::setBlueFunction): (KCanvasFEComponentTransfer::setAlphaFunction):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector): (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): (KCanvasFilterQuartz::filterBBoxForItemBBox): (KCanvasFilterQuartz::getCIFilterStack): (KCanvasFilterQuartz::imageForName): (KCanvasFilterQuartz::setImageForName): (KCanvasFilterQuartz::setOutputImage): (alphaImageForImage): (KCanvasFilterQuartz::inputImage): (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEGaussianBlurQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFEOffsetQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter): (KCanvasFETileQuartz::getCIFilter):
9:01 AM Changeset in webkit [11535] by darin
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Eric.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5538

  • fast/xsl/resources/xslt-entity.xsl: Added.
  • fast/xsl/xslt-entity-expected.checksum: Added.
  • fast/xsl/xslt-entity-expected.png: Added.
  • fast/xsl/xslt-entity-expected.txt: Added.
  • fast/xsl/xslt-entity.xml: Added.

WebCore:

Reviewed by Eric.

Added the crashing specimen as a layout test.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets): Check that the node is an element node before calling IS_XSLT_ELEM.

Dec 11, 2005:

8:23 PM Changeset in webkit [11534] by eseidel
  • 1 edit
    6 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none

Adding pixel results omitted from previous commits.

  • fast/block/positioning/leftmargin-topmargin-expected.checksum: Added.
  • fast/block/positioning/leftmargin-topmargin-expected.png: Added.
  • fast/clip/017-expected.checksum: Added.
  • fast/clip/017-expected.png: Added.
  • fast/inspector/style-expected.checksum: Added.
  • fast/inspector/style-expected.png: Added.
8:15 PM Changeset in webkit [11533] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Adding resources overlooked in previous commit.

  • fast/xsl/resources/xslt-extra-content-at-end.xsl: Added.
  • fast/xsl/resources/xslt-mismatched-tags-in-xslt.xsl: Added.
  • fast/xsl/resources/xslt-missing-namespace-in-xslt.xsl: Added.
3:47 AM Changeset in webkit [11532] by eseidel
  • 1 edit
    28 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

  • fast/invalid/junk-data-expected.checksum: Added.
  • fast/invalid/junk-data-expected.png: Added.
  • fast/invalid/junk-data-expected.txt: Added.
  • fast/invalid/junk-data.xml: Added.
  • fast/invalid/missing-end-tag-expected.checksum: Added.
  • fast/invalid/missing-end-tag-expected.png: Added.
  • fast/invalid/missing-end-tag-expected.txt: Added.
  • fast/invalid/missing-end-tag.xhtml: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.checksum: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.png: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.txt: Added.
  • fast/xsl/xslt-extra-content-at-end.xml: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.checksum: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt.xml: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.checksum: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt.xml: Added.
  • svg/custom/junk-data-expected.checksum: Added.
  • svg/custom/junk-data-expected.png: Added.
  • svg/custom/junk-data-expected.txt: Added.
  • svg/custom/junk-data.svg: Added.
  • svg/custom/missing-xlink-expected.checksum: Added.
  • svg/custom/missing-xlink-expected.png: Added.
  • svg/custom/missing-xlink-expected.txt: Added.
  • svg/custom/missing-xlink.svg: Added.
3:42 AM Changeset in webkit [11531] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

  • khtml/xml/xml_tokenizer.cpp: (khtml::createXHTMLParserErrorHeader): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts):
  • ksvg2/svg/SVGStyledElementImpl.h: removed broken code
  • ksvg2/svg/SVGStyledElementImpl.cpp: removed broken attach()
1:28 AM Changeset in webkit [11530] by eseidel
  • 2 edits
    4 adds in trunk/LayoutTests

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

  • svg/custom/conditional-processing-outside-switch-expected.checksum: Added.
  • svg/custom/conditional-processing-outside-switch-expected.png: Added.
  • svg/custom/conditional-processing-outside-switch-expected.txt: Added.
  • svg/custom/conditional-processing-outside-switch.svg: Added.
  • svg/custom/simpleCDF-expected.txt:
1:26 AM Changeset in webkit [11529] by eseidel
  • 24 edits in trunk/WebCore

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

One test case added for conditional processing directives
used outside of switch statements.

  • WebCore+SVG/DrawDocument.mm: (-[DrawView description]):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEGaussianBlurQuartz::getCIFilter):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
  • khtml/khtml_part.h:
  • khtml/rendering/DataRef.h: (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_object.h: (khtml::RenderObject::localTransform):
  • khtml/rendering/render_style.cpp: (RenderStyle::diff):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): (DocumentImpl::createEvent):
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue):
  • ksvg2/css/svg.css:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::childShouldCreateRenderer):
  • ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isValid):

Dec 10, 2005:

11:28 PM Changeset in webkit [11528] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • fix SVG build for recent QTimer changes.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::SVGTimer):
6:06 PM Changeset in webkit [11527] by darin
  • 134 edits in trunk

JavaScriptCore:

Rubber stamped by Maciej.

  • did long-promised KJS renaming:

ValueImp -> JSValue
ObjectImp -> JSObject
AllocatedValueImp -> JSCell

A renaming to get a class out of the way

KJS::Bindings::JSObject -> JavaJSObject

and some other "imp-reduction" renaming

*InstanceImp -> *Instance
*ProtoFuncImp -> *ProtoFunc
*PrototypeImp -> *Prototype
ArgumentsImp -> Arguments
RuntimeArrayImp -> RuntimeArray
RuntimeMethodImp -> RuntimeMethod

  • most files and functions

WebCore:

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
6:03 PM Changeset in webkit [12219] by darin
  • 10 edits in trunk/JavaScriptGlue

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
5:44 PM Changeset in webkit [11526] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin and Eric.

  • Makefile.am: Support --enable-svg
4:38 PM Changeset in webkit [11525] by darin
  • 53 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • bindings/NP_jsobject.cpp: (_NPN_Evaluate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: (CField::valueFromInstance):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp: (JSObject::eval): (JSObject::convertJObjectToValue):
  • bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcFallbackObjectImp::callAsFunction):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::valueOf):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::lengthGetter):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::lengthGetter): (RuntimeMethodImp::callAsFunction): (RuntimeMethodImp::execute):
  • kjs/array_object.cpp: (ArrayInstanceImp::lengthGetter): (CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (ArrayPrototypeImp::ArrayPrototypeImp): (ArrayProtoFuncImp::ArrayProtoFuncImp): (ArrayProtoFuncImp::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
  • kjs/bool_object.cpp: (BooleanPrototypeImp::BooleanPrototypeImp): (BooleanProtoFuncImp::callAsFunction): (BooleanObjectImp::BooleanObjectImp): (BooleanObjectImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorPrototypeImp::ErrorPrototypeImp): (ErrorProtoFuncImp::ErrorProtoFuncImp): (ErrorProtoFuncImp::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::DeclaredFunctionImp::execute): (KJS::encode): (KJS::decode): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): (FunctionPrototypeImp::callAsFunction): (FunctionProtoFuncImp::callAsFunction): (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
  • kjs/interpreter.h:
  • kjs/lookup.h:
  • kjs/math_object.cpp: (MathObjectImp::getValueProperty): (MathFuncImp::callAsFunction):
  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): (NullNode::evaluate): (PropertyNode::evaluate): (FunctionCallBracketNode::evaluate): (FunctionCallDotNode::evaluate): (PostfixBracketNode::evaluate): (PostfixDotNode::evaluate): (VoidNode::evaluate): (PrefixBracketNode::evaluate): (PrefixDotNode::evaluate): (ShiftNode::evaluate): (valueForReadModifyAssignment): (AssignDotNode::evaluate): (AssignBracketNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (VarDeclListNode::evaluate): (ReturnNode::execute): (CaseClauseNode::evalStatements): (ParameterNode::evaluate): (FuncDeclNode::processFuncDecl):
  • kjs/nodes.h: (KJS::StatementNode::evaluate):
  • kjs/number_object.cpp: (NumberPrototypeImp::NumberPrototypeImp): (NumberProtoFuncImp::callAsFunction): (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getValueProperty): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::ObjectImp::get): (KJS::Error::create):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction): (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter):
  • kjs/regexp_object.cpp: (RegExpPrototypeImp::RegExpPrototypeImp): (RegExpProtoFuncImp::callAsFunction): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::construct):
  • kjs/string_object.cpp: (StringInstanceImp::StringInstanceImp): (StringPrototypeImp::StringPrototypeImp): (replace): (StringProtoFuncImp::callAsFunction): (StringObjectImp::StringObjectImp): (StringObjectImp::callAsFunction): (StringObjectFuncImp::StringObjectFuncImp): (StringObjectFuncImp::callAsFunction):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (VersionFunctionImp::callAsFunction):
  • kjs/value.h:

WebCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrNull): (KJS::setDOMException):
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheet::getValueProperty): (KJS::getDOMStyleSheet): (KJS::DOMStyleSheetList::getValueProperty): (KJS::getDOMStyleSheetList): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMMediaList::getValueProperty): (KJS::DOMMediaList::indexGetter): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRuleList::getValueProperty): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::CSSRuleConstructor::getValueProperty): (KJS::DOMCSSValue::getValueProperty): (KJS::getDOMCSSValue): (KJS::CSSValueConstructor::getValueProperty): (KJS::DOMCSSPrimitiveValue::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::CSSPrimitiveValueConstructor::getValueProperty): (KJS::DOMCSSValueList::getValueProperty): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMCounter::getValueProperty):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::callAsFunction): (KJS::DOMAttr::getValueProperty): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::attributeGetter): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::DOMDOMImplementationProtoFunc::callAsFunction): (KJS::DOMDocumentType::getValueProperty): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMProcessingInstruction::getValueProperty): (KJS::DOMNotation::getValueProperty): (KJS::DOMEntity::getValueProperty): (KJS::getDOMNode): (KJS::NodeConstructor::getValueProperty): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMCharacterData::getValueProperty): (KJS::DOMCharacterDataProtoFunc::callAsFunction): (KJS::DOMTextProtoFunc::callAsFunction):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::EventConstructor::getValueProperty): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::getDOMEvent): (KJS::EventExceptionConstructor::getValueProperty): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::MutationEventConstructor::getValueProperty): (KJS::DOMMutationEvent::getValueProperty): (KJS::DOMMutationEventProtoFunc::callAsFunction): (KJS::DOMWheelEvent::getValueProperty): (KJS::DOMWheelEventProtoFunc::callAsFunction): (KJS::stringOrUndefined): (KJS::Clipboard::getValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::htmlGetter): (KJS::HTMLElement::headGetter): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::titleGetter): (KJS::HTMLElement::metaGetter): (KJS::HTMLElement::baseGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::formGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optGroupGetter): (KJS::HTMLElement::optionGetter): (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::uListGetter): (KJS::HTMLElement::oListGetter): (KJS::HTMLElement::dListGetter): (KJS::HTMLElement::dirGetter): (KJS::HTMLElement::menuGetter): (KJS::HTMLElement::liGetter): (KJS::HTMLElement::divGetter): (KJS::HTMLElement::paragraphGetter): (KJS::HTMLElement::headingGetter): (KJS::HTMLElement::blockQuoteGetter): (KJS::HTMLElement::quoteGetter): (KJS::HTMLElement::preGetter): (KJS::HTMLElement::brGetter): (KJS::HTMLElement::baseFontGetter): (KJS::HTMLElement::fontGetter): (KJS::HTMLElement::hrGetter): (KJS::HTMLElement::modGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::imageGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::paramGetter): (KJS::HTMLElement::appletGetter): (KJS::HTMLElement::mapGetter): (KJS::HTMLElement::areaGetter): (KJS::HTMLElement::scriptGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::tableCaptionGetter): (KJS::HTMLElement::tableColGetter): (KJS::HTMLElement::tableSectionGetter): (KJS::HTMLElement::tableRowGetter): (KJS::HTMLElement::tableCellGetter): (KJS::HTMLElement::frameSetGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::marqueeGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLCollection::lengthGetter): (KJS::KJS::HTMLCollection::callAsFunction): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::selectedIndexGetter): (KJS::HTMLSelectCollection::getOwnPropertySlot): (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::Image::getValueProperty): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::getValueProperty): (KJS::Context2D::Context2D): (KJS::GradientFunction::callAsFunction): (KJS::Gradient::getValueProperty): (KJS::ImagePattern::getValueProperty): (KJS::getSelectHTMLCollection):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::MimeType::getValueProperty): (KJS::PluginsFunc::callAsFunction): (KJS::NavigatorFunc::callAsFunction):
  • khtml/ecma/kjs_proxy.cpp: (TestFunctionImp::callAsFunction):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::RangeConstructor::getValueProperty):
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::NodeFilterConstructor::getValueProperty): (KJS::DOMNodeFilterProtoFunc::callAsFunction): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::Window::retrieve): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::Location::getValueProperty): (KJS::Location::toPrimitive): (KJS::LocationFunc::callAsFunction): (KJS::Selection::getValueProperty): (KJS::Selection::toPrimitive): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::getValueProperty): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::getAllResponseHeaders): (KJS::XMLHttpRequest::getResponseHeader): (KJS::XMLHttpRequest::getStatus): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • ksvg2/ecma/Ecma.cpp: (KSVG::getSVGPathSeg):
  • ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:35 PM Changeset in webkit [12218] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • JSUtils.cpp: (JSObjectKJSValue):
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::toPrimitive):
4:07 PM Changeset in webkit [11524] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin and Tim Hatcher.

  • fix WebCore SVG build for gcc 3.3 (don't know why it has these complaints)
  • kcanvas/KCanvasFilters.h: (QPointF::QPointF): Add a default constructor (KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): ditto
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): Move a variable declaration instead exception blocking (KCanvasFECompositeQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto
12:40 PM Changeset in webkit [11523] by darin
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore.exp: Export the new WebCoreElementImageRendererKey and remove the old WebCoreElementImageKey.
  • kwq/WebCoreBridge.h: Add WebCoreElementImageRendererKey, remove WebCoreElementImageKey.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Pass the image renderer in the dictionary, but not the NSImage.

WebKit:

Reviewed by John Sullivan.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Pass the image renderer, not the NSImage. (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from WebCore with only an image renderer.
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): Pass the image renderer, not the NSImage.
12:34 PM Changeset in webkit [11522] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
plainText() returns a partial result when the node contains RTL text

  • fast/dom/inner-text-rtl-expected.txt: Added.
  • fast/dom/inner-text-rtl.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/dom/inner-text-rtl.html

  • khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox): Avoid advancing m_sortedTextBoxes if textBoxEnd wasn't reached.
  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::getNext): Added. (KWQListImpl::getPrev): Added.
  • kwq/KWQPtrList.h: (QPtrList::getNext): Added. (QPtrList::getPrev): Added.
12:21 PM Changeset in webkit [11521] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5826

  • fast/overflow/overflow-rtl-expected.checksum: Added.
  • fast/overflow/overflow-rtl-expected.png: Added.
  • fast/overflow/overflow-rtl-expected.txt: Added.
  • fast/overflow/overflow-rtl.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::RenderLayer): Initialize (khtml::RenderLayer::scrollOffset): (khtml::RenderLayer::subtractScrollOffset): (khtml::RenderLayer::scrollToOffset): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::updateScrollPositionFromScrollbars): (khtml::RenderLayer::computeScrollDimensions): (khtml::RenderLayer::updateScrollInfoAfterLayout):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollToYOffset):
11:56 AM Changeset in webkit [11520] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3983

  • fast/css/outline-auto-location-expected.checksum: Added.
  • fast/css/outline-auto-location-expected.png: Added.
  • fast/css/outline-auto-location-expected.txt: Added.
  • fast/css/outline-auto-location.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Only add the rect if this is a RenderBlock.
11:05 AM Changeset in webkit [11519] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::callAsFunction): Added set of visited objects -- don't recurse if item is already in the set.

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

  • fast/js/cyclic-ref-toString-expected.txt: Added.
  • fast/js/cyclic-ref-toString.html: Added.
10:56 AM Changeset in webkit [11518] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5784

  • fast/parser/duplicate-html-body-element-IDs-expected.txt: Added.
  • fast/parser/duplicate-html-body-element-IDs.html: Added.

WebCore:

Reviewed and landed by Darin.

Added a new layout test that checks for at least one symptom of the bug.

  • khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use setAttribute here instead of using insertAttribute and calling recalcStyle explicitly. That's because setAttribute does other things that are needed to change an attribute in an attribute map that's already connected to an element, including updating the ID map if the attribute is the ID attribute.
  • khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::insertAttribute): Assert that this parser-only function is only used on attribute maps that aren't yet attached to elements.
9:14 AM Changeset in webkit [11517] by darin
  • 12 edits in trunk/WebCore

Reviewed by Eric and Tim Omernick.

  • kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and restartTimer. Made KWQObjectSenderScope functions be inline.
  • kwq/KWQObject.mm: (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent on the target. (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new timer ID and calls restartTimer. (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary. That includes creating a CFRunLoopTimer and scheduling it on the current run loop. (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to fire and the "fire again" interval. (deleteTimer): Added. Invalidates and then removes a timer. (QObject::killTimer): Changed to use deleteTimer to do most of its work. (deleteOneTimer): Added. Calls deleteTimer. (QObject::killTimers): Changed to use deleteOneTimer to do most of its work. (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target. (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers. (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.
  • kwq/KWQTimer.h: (QTimer::QTimer): Made constructor inline and removed the optional parameter. (QTimer::isActive): Made inline. (QTimer::fireDate): Added. Inline function. Got rid of the NSTimer and added a CFRunLoopTimer.
  • kwq/KWQTimer.mm: (timerFired): Added. Calls fire on the QTimer object. (QTimer::start): Changed to create a CFRunLoopTimer. (QTimer::stop): Changed to use CFRunLoopTimer functions. (QTimer::fire): Ditto.
  • khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the file so it can be used inline in the implementation of the Window class, and changed to use the PausedTimeouts class intead of a QMap to store the paused timeouts.
  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces a check in the caller and a check partway down this function (after the part was already dereferenced). Fixed message handling so the message is not converted to ascii and back. Added an isObject() check so we won't crash if the passed function is a value that's not an object. Changed check for function vs. script to check for a function of nil instead of using a separate boolean. (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object, using the new QObject::timerIntervals function rather than the old QObject::pauseTimer function. This means that the paused timers are entirely stored in the PausedTimeouts object instead of being half in a QMap and the other half inside the QObject itself. (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function. (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including the scheduled actions, unless the timeouts have already been resumed (in which case the m_array field will be 0).
  • kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them use the PausedTimeouts class and no longer take a key parameter.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than the old getNSTimer() function to get the fire date. (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter. (KWQKHTMLPart::resumeTimeouts): Remove the key parameter. (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead of a QMap for the paused timeouts.
  • kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts. Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]): Added code where it sets the pausedTimouts. (-[KWQPageState pausedTimeouts]): Added. (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode. (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0. (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method. (-[KWQPageState finalize]): Set document to 0 after deref for consistency.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the paused timeouts using the new pauseTimeouts function.
7:27 AM Changeset in webkit [11516] by darin
  • 2 edits in trunk/WebKit

Was getting build failures related to "count" methods.
Made Tim's build fix Leopard-only.

  • WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.

Dec 9, 2005:

8:52 PM Changeset in webkit [11515] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
  • WebView.subproj/WebView.m: (-[WebView _frameForCurrentSelection]): I removed this method many moons ago when restructuring the code involving frames and selection. Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
6:59 PM Changeset in webkit [11514] by justing
  • 5 edits in trunk/WebCore

<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections
Some preparation for a fix for:
<radar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

There were a few bugs in endOfParagraph's and endOfLine's handling of IncludeLineBreak.
The IncludeLinebreak concept also doesn't make sense: when asked to
IncludeLineBreak, "endOfParagraph" would return the start of the next paragraph.
Callers that want this funtionality should just call endOfParagraph and then get next()
if it exists.
In endOfParagraph's whitespace:pre handling, when the input visible position
was at the end of a text node with whitespace:pre, that text node was searched
for '/n'. It should be skipped.

Reviewed by harrison

Added new layout tests in editing/pasting and editing/selection

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::validate):
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::isEndOfLine): (khtml::endOfParagraph): (khtml::isEndOfParagraph):
  • khtml/editing/visible_units.h:
6:59 PM Changeset in webkit [11513] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections

Reviewed by harrison

  • editing/pasteboard/paste-pre-002-expected.checksum: Added.
  • editing/pasteboard/paste-pre-002-expected.png: Added.
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html: Added.
  • editing/selection/triple-click-in-pre-expected.checksum: Added.
  • editing/selection/triple-click-in-pre-expected.png: Added.
  • editing/selection/triple-click-in-pre-expected.txt: Added.
  • editing/selection/triple-click-in-pre.html: Added.
6:13 PM Changeset in webkit [11512] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Carbon.subproj/HIWebView.m: (UpdateCommandStatus): Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures. -performSelector:withObject:'s return value should only be checked if the method returns an object.
3:48 PM Changeset in webkit [11511] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
2:06 PM Changeset in webkit [11510]
  • 55 copies
    22 deletes in tags/WebKit-417~8

This commit was manufactured by cvs2svn to create tag 'WebKit-417~8'.

2:06 PM Changeset in webkit [11509]
  • 211 copies
    17 deletes in tags/WebCore-417~11

This commit was manufactured by cvs2svn to create tag
'WebCore-417~11'.

2:06 PM Changeset in webkit [11508] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning.

10:59 AM Changeset in webkit [11507] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by nobody, build fix.

Using <PDFKit/PDFKit.h> was causing build failures for the Mail team.
The comment about getting an ambiguous signature conflict anywhere the
method "count" is used seems to no longer be an issue.

  • WebView.subproj/WebPreferencesPrivate.h: Use <Quartz/Quartz.h>

Dec 8, 2005:

8:10 PM Changeset in webkit [11506] by adele
  • 6 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
6:12 PM Changeset in webkit [11505] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Some cleanup of how selection rects are associated with NSViews.

  • WebView.subproj/WebDocumentPrivate.h: Added a -selectionView method to <WebDocumentSelection>, and clarified that the selectionRect is in the coordinate system of this view.
  • Misc.subproj/WebSearchableTextView.m: (-[WebSearchableTextView selectionView]): new method, returns self
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectionView]): new method, returns self
  • WebView.subproj/WebPDFView.m: (-[WebPDFView selectionRect]): translate result into coordinate system of [PDFSubview documentView] (-[WebPDFView selectionView]): new method, returns [PDFSubview documentView]
6:10 PM Changeset in webkit [11504] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4311703> Crash in NPN_Invoke receiving contents of ​http://www.woodieschilidogs.com/ in Mail.app

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptNPObject): The window script object can be 0 if JavaScript is disabled. However, callers (like plugins) expect us to always return a window script object here. By substituting a plain ObjectImp for the window's ObjectImp, we can satisfy callers' assumptions and let them try to manipulate the dummy object when JavaScript is disabled.
4:06 PM Changeset in webkit [11503] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

  • fixed these semi-legendary bugs: <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now passes the focus down to that view.
3:13 PM Changeset in webkit [11502] by tomernic
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

Reviewed and landed by Maciej.

  • some simple changes that amount to a < 1% speedup.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • kwq/KWQKURL.mm: (hasSlashDotOrDotDot):
  • kwq/KWQString.mm: (QString::~QString):
3:05 PM Changeset in webkit [11501] by tomernic
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch.

Bug #: none
Submitted by: timo
Reviewed by: eseidel & darin

Changed some of the run measurement methods to C functions
to avoid overhead associated with objc_msgSend().

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForRun:style:widths:]): Updated to call new run measurement functions instead of calling ObjC methods. (-[WebTextRenderer CG_drawRun:style:geometry:]): ditto (floatWidthForRun): ditto (CG_floatWidthForRun): ditto (ATSU_floatWidthForRun): ditto (widthForNextCharacter): ditto
2:22 PM Changeset in webkit [11500] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)"
crashed when going from the "Open a template" menu to "Select recent
Document" in the "Welcome to Corel XI!" window.

These are the parts of that bug fix that were not already fixed in TOT.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...]
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Allow for the event not being leftmousedown or keydown
1:44 PM Changeset in webkit [11499] by harrison
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

11:44 AM Changeset in webkit [11498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.
10:33 AM Changeset in webkit [11497] by mjs
  • 7 edits in trunk/WebKit

Reviewed by John.

  • some small changes towards frame tree refactoring

Renamed WebViewSets to WebFrameNamespaces, and put the method for
performing a selector on all extant WebViews to WebView itself,
with a separate set tracking live WebViews. This should allow
moving the storage of this info down to WebCore more easily.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): (-[WebBridge runModal]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (webView::if): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebView.m: (+[WebView _makeAllWebViewsPerformSelector:]): (-[WebView _removeFromAllWebViewsSet]): (-[WebView _addToAllWebViewsSet]): (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setGroupName:]):
  • WebView.subproj/WebViewInternal.h:
10:19 AM Changeset in webkit [11496] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • fix major memory leak and resultant slowdown on JavaScript iBench from my PassRefPtr changes
  • kjs/ustring.cpp: (KJS::UString::Rep::create): I forgot to change one of the two overloads to create with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt to adopt the initial refcount, this may be a hair more efficient.
  • made the assignment operators for smart pointers inline because Shark said so
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::::operator=):
2:20 AM Changeset in webkit [11495] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5997
Submitted by: mitz
Reviewed by: eseidel

No test possible since this fixes random behavior.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5997
REGRESSION: Focus rings around links are not erased when focus is lost

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inDetach to false.
1:30 AM Changeset in webkit [11494] by eseidel
  • 17 edits in trunk/LayoutTests

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
1:17 AM Changeset in webkit [11493] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

No applet test (mjs says DRT has kittens in that case)
SVG is covered by <use> test cases (5 tests).

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::endElementNs): call closeRenderer()
12:54 AM Changeset in webkit [11492] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/misc/shared.h: Rewrote both Shared and TreeShared to be functionally the same, but used signed reference counts and remove the extra check inside deref that handles the case of extra derefs (a programming mistake in any case). This elimnates a branch from a hot code path. Also added license header. New versions have private data members, unlike the old ones that used protected.
  • khtml/rendering/render_replaced.h: Removed private inheritance from Shared, and instead just declared a variable that holds a reference count, because that's the only thing that was being used from Shared.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initialized m_refCount. (RenderWidget::~RenderWidget): Use m_refCount. (RenderWidget::eventFilter): Ditto. (RenderWidget::deref): Use m_refCount and the new faster idiom (although here it's not important becaue the function isn't even inlined).
12:44 AM Changeset in webkit [11491] by eseidel
  • 5 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, svg build fix only.

  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue): parseShorthand rename
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: missing header
  • ksvg2/svg/SVGFELightElementImpl.cpp: missing header
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: missing header
12:40 AM Changeset in webkit [11490] by darin
  • 20 edits in trunk

WebCore:

Reviewed by Eric.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code to the CSS_PROP_CURSOR case to handle cursor images.
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Allow and parse a URL for the cursor for the image case.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Do the appropriate inherit and initial for CSS_PROP_CURSOR, and allow either an identifier or a URL for the value.
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler): Removed inappropriate call to resetCursor. We don't change the cursor shape just because we're following a link.
  • khtml/khtmlview.cpp: (selectCursor): Added. New function that chooses the appropriate cursor. Includes new logic to handle image cursors. (KHTMLView::viewportMouseMoveEvent): Refactored to use selectCursor to choose the appropriate cursor.
  • kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Call the function to get an image renderer by its new name, imageRenderer().
  • kwq/KWQCursor.mm: (createCustomCursor): Added. (QCursor::QCursor): Changed constructor that takes a QPixmap to call createCustomCursor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Replaced a call to resetCursor with a call to setCursor(QCursor()). (KWQKHTMLPart::fileWrapperForElement): Fixed code that assumed the render object is always a RenderImage. Call TIFFRepresentation on the image renderer instead of incorrectly assuming it's always an NSImage.
  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap): Call imageRenderer function instead of getting right at the data member. (QPainter::drawTiledPixmap): Ditto. (QPainter::drawScaledAndTiledPixmap): Ditto.
  • kwq/KWQPixmap.h: Removed convertToImage(), renamed image() to imageRenderer().
  • kwq/KWQPixmap.mm: Similar name changes.
  • kwq/KWQWidget.mm: (QWidget::setCursor): To workaround extra work done by AppKit when you set the cursor to the same one, check if the cursor is already set before calling setDocumentCursor.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Call the image method on the image renderer instead of incorrectly assuming the renderer itself is an image.
  • kwq/WebCoreImageRenderer.h: Added a TIFFRepresentation method to this protocol.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and image methods since both are required by the WebCoreImageRenderer protocol now and we don't have to re-declare them.
  • Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file since we need to use methods inherited from that protocol.
  • Misc.subproj/WebNSViewExtras.m: Ditto.
  • WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)

Dec 7, 2005:

11:42 PM Changeset in webkit [11489] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Landed by Darin.

  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • fast/text/atsui-pointtooffset-calls-cg.html: Added.
11:41 PM Changeset in webkit [11488] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Added the missing "return".
4:19 PM Changeset in webkit [11487] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] @ home.netscape.com
  • WebView.subproj/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assert that I added a while back. In this case at least, the assertion is overzealous, and I can't recreate the tortured chain of logic that led me to adding this assertion in the first place.
3:19 PM Changeset in webkit [11486] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Add Radar bug # to an old commit.

2:48 PM Changeset in webkit [11485] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work. This was just a silly regression
from my pre-wrap/pre-line implementation. I accidentally changed
code to examine the wrong style().

Reviewed by harrison

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [11484] by hyatt
  • 2 edits in trunk/WebCore

Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects that
have corresponding DOM elements.

Reviewed by Eric Seidel

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
2:31 AM Changeset in webkit [11483] by eseidel
  • 1 edit
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.

Removing unused files.

  • kcanvas/KCanvasRegistry.cpp: Removed.
  • kcanvas/KCanvasRegistry.h: Removed.

Dec 6, 2005:

5:16 PM Changeset in webkit [11482] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Removed change marker.

5:12 PM Changeset in webkit [11481] by hyatt
  • 16 edits in trunk/WebCore

Add support for more methods for exposing more useful style information.

getMatchedCSSRules can be used to obtain the matched sheet rules for an element. In Obj-C
it will also include user/user agent sheet rules.

Also add support for tracking the original shorthand in which a property was declared, as well
as whether the property was just implicitly set rather than explicitly mentioned (e.g., if it was
an omitted piece of a shorthand). The new methods on CSSStyleDeclaration are getPropertyShorthand
and isPropertyImplicit.

Reviewed by mjs

Test: fast/inspector/style.html

  • khtml/css/css_computedstyle.h: (DOM::CSSComputedStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSComputedStyleDeclarationImpl::isPropertyImplicit):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): (DOM::CSSMutableStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSMutableStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSProperty::cssText): (DOM::operator==):
  • khtml/css/css_valueimpl.h: (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::shorthandID): (DOM::CSSProperty::isImportant): (DOM::CSSProperty::isImplicit):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::addProperty): (CSSParser::parseValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseShorthand): (CSSParser::parse4Values): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty):
  • khtml/css/cssparser.h: (DOM::CSSParser::enterShorthand): (DOM::CSSParser::exitShorthand): (DOM::CSSParser::inShorthand):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleDeclaration::):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
  • khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
  • khtml/xml/dom2_viewsimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration getPropertyShorthand:]): (-[DOMCSSStyleDeclaration isPropertyImplicit:]): (-[DOMDocument getMatchedCSSRules::]):
  • kwq/DOMPrivate.h:
5:11 PM Changeset in webkit [11480] by hyatt
  • 3 adds in trunk/LayoutTests/fast/inspector

Land layout test for style inspection.

3:34 PM Changeset in webkit [11479]
  • 55 copies
    22 deletes in tags/WebKit-417~7

This commit was manufactured by cvs2svn to create tag 'WebKit-417~7'.

3:34 PM Changeset in webkit [11478]
  • 211 copies
    17 deletes in tags/WebCore-417~10

This commit was manufactured by cvs2svn to create tag
'WebCore-417~10'.

3:34 PM Changeset in webkit [11477] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning to WebKit-417.7 and WebCore-417.10

2:12 PM Changeset in webkit [11476] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
2:06 PM Changeset in webkit [11475] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
1:54 PM Changeset in webkit [11474] by sullivan
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog: Remove special-case handling for nib files. This avoided trouble with cvs diff when we were using wrappers for nib files. Now that we aren't using wrappers, there's no reason to avoid adding the modified nib files to the file list that gets diffed.
11:38 AM Changeset in webkit [11473] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fix build when using gcc 4
  • kjs/ustring.h: Make Rep public.
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator): Fix a typo.
1:21 AM Changeset in webkit [11472] by mjs
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • cleaned up UString a little so that it doesn't need to have so many friend classes
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kjs/identifier.h: (KJS::Identifier::Identifier): (KJS::Identifier::equal):
  • kjs/property_map.cpp: (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::remove):
  • kjs/ustring.cpp: (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::substr): (KJS::UString::copyForWriting): (KJS::operator==):
  • kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString): (KJS::UString::data): (KJS::UString::isNull): (KJS::UString::isEmpty): (KJS::UString::size): (KJS::UString::rep):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::operator*): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):

WebCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):

Dec 5, 2005:

11:20 PM Changeset in webkit [11471] by eseidel
  • 4 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Script updates for SVG files move (remove references to SVGSupport)

  • Scripts/build-webkit: remove SVGSupport
  • Scripts/run-webkit-tests: Resources -> resources for --svg
  • Scripts/update-webkit: remove SVGSupport
10:29 PM Changeset in webkit [11470] by eseidel
  • 28 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Changed "Resources" to "resources" to match other layout tests.

  • svg/W3C-SVG-1.1/color-prof-01-f.svg:
  • svg/W3C-SVG-1.1/filters-conv-01-f.svg:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
  • svg/W3C-SVG-1.1/filters-displace-01-f.svg:
  • svg/W3C-SVG-1.1/filters-image-01-b.svg:
  • svg/W3C-SVG-1.1/filters-light-01-f.svg:
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg:
  • svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
  • svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
  • svg/W3C-SVG-1.1/interact-order-02-b.svg:
  • svg/W3C-SVG-1.1/interact-order-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-01-b.svg:
  • svg/W3C-SVG-1.1/linking-a-02-b.svg:
  • svg/W3C-SVG-1.1/linking-a-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-04-t.svg:
  • svg/W3C-SVG-1.1/linking-uri-02-b.svg:
  • svg/W3C-SVG-1.1/linking-uri-03-t.svg:
  • svg/W3C-SVG-1.1/masking-path-04-b.svg:
  • svg/W3C-SVG-1.1/render-groups-01-b.svg:
  • svg/W3C-SVG-1.1/render-groups-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-01-t.svg:
  • svg/W3C-SVG-1.1/struct-image-02-b.svg:
  • svg/W3C-SVG-1.1/struct-image-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-05-b.svg:
  • svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
  • svg/W3C-SVG-1.1/text-tref-01-b.svg:
10:08 PM Changeset in webkit [11469] by eseidel
  • 81 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Updating all the SVG tests with their latest post-merger results.
There are still issues which will prevent these from passing on
all machines:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4515
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5962

  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-frag-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • svg/custom/fill-update-expected.checksum:
  • svg/custom/fill-update-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • svg/custom/path-update-expected.checksum:
  • svg/custom/path-update-expected.png:
  • svg/custom/simpleCDF-expected.checksum:
  • svg/custom/simpleCDF-expected.png:
  • svg/custom/use-forward-refs-expected.checksum:
  • svg/custom/use-forward-refs-expected.png:
  • svg/custom/use-forward-refs-expected.txt:
8:29 PM Changeset in webkit [11468] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrsion

  • editing/selection/paragraph-granularity-expected.checksum: Added.
  • editing/selection/paragraph-granularity-expected.png: Added.
  • editing/selection/paragraph-granularity-expected.txt: Added.
  • editing/selection/paragraph-granularity.html: Added.
  • editing/selection/word-granularity-expected.checksum: Added.
  • editing/selection/word-granularity-expected.png: Added.
  • editing/selection/word-granularity-expected.txt: Added.
  • editing/selection/word-granularity.html: Added.
8:29 PM Changeset in webkit [11467] by justing
  • 4 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrison

Rolled back previous change, simplified expansion, fixed
adjustForEditableContent to work in cases where start/end are
distinct from base/extent, renamed m_baseIsStart to m_baseIsFirst.

Added two new layout tests in editing/selection to test
modifying selections created with double and triple clicks.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::init): (khtml::SelectionController::operator=): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::adjustForEditableContent): (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseMoveEvent):
6:41 PM Changeset in webkit [11466] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • WebCore.xcodeproj/project.pbxproj: updated paths for SVG move.
6:35 PM Changeset in webkit [12217] by mjs
  • 1 edit
    2 adds in trunk/JavaScriptGlue
  • added new forwarding headers
  • kxmlcore/PassRefPtr.h: Added.
  • kxmlcore/RefPtr.h: Added.
6:16 PM Changeset in webkit [11465] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • checkout: remove --svg support, SVG is now checked out by default
6:04 PM Changeset in webkit [11464] by eseidel
  • 6 edits in trunk/LayoutTests

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

Updated results for KCanvaPath changes:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
5:53 PM Changeset in webkit [11463] by eseidel
  • 54 edits
    1 add
    6 deletes in trunk/WebCore

Bug #: 5942, 5943
Submitted by: eseidel
Reviewed by: darin

No test cases possible/necessary.

Removing unused ForwardingHeaders, as well as header cleanup in SVG
Fixed KSVG2 files to include proper KDOM headers.
Fixed KDOM forwarding headers to point to correct khtml headers.
Added DataRef.h to hold khtml::DataRef.
Made SVGRenderStyle a DataRef on RenderStyle.
(Landing two bugs at once as their project file changes intertwine)

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5942
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5943

  • ForwardingHeaders/kdom/DOMString.h:
  • ForwardingHeaders/kdom/KDOMSettings.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedDocument.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h:
  • ForwardingHeaders/kdom/cache/KDOMLoader.h:
  • ForwardingHeaders/kdom/core/AttrImpl.h:
  • ForwardingHeaders/kdom/core/CDFInterface.h: Removed.
  • ForwardingHeaders/kdom/core/DOMImplementationImpl.h:
  • ForwardingHeaders/kdom/core/DOMStringImpl.h:
  • ForwardingHeaders/kdom/core/DocumentImpl.h:
  • ForwardingHeaders/kdom/core/ElementImpl.h:
  • ForwardingHeaders/kdom/core/NodeImpl.h:
  • ForwardingHeaders/kdom/core/XMLElementImpl.h:
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h:
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h:
  • ForwardingHeaders/kdom/css/CSSValueImpl.h:
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h:
  • ForwardingHeaders/kdom/css/RGBColorImpl.h:
  • ForwardingHeaders/kdom/events/UIEventImpl.h:
  • ForwardingHeaders/kdom/events/kdomevents.h:
  • ForwardingHeaders/kdom/kdom.h:
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/KDOMStubClasses.h: Removed.
  • WebCore+SVG/kdomcss.h: Removed.
  • WebCore+SVG/kdomls.h: Removed.
  • WebCore+SVG/kdomrange.h: Removed.
  • WebCore+SVG/kdomtraversal.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::drawMarkersIfNeeded):
  • khtml/rendering/DataRef.h: Added. (khtml::DataRef::DataRef): (khtml::DataRef::~DataRef): (khtml::DataRef::operator->): (khtml::DataRef::get): (khtml::DataRef::access): (khtml::DataRef::init): (khtml::DataRef::operator=): (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
  • khtml/rendering/render_style.cpp: (m_affectedByAttributeSelectors): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::~RenderStyle): (RenderStyle::operator==): (RenderStyle::inheritedNotEqual): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::svgStyle): (khtml::RenderStyle::accessSVGStyle):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): (SVGRenderStyle::inheritedNotEqual):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::operator!=):
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGZoomAndPanImpl.h:
5:46 PM Changeset in webkit [11462] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): one more tweak: moved jumpToSelection: to be validated the same way as centerSelectionInVisibleArea:, since it now calls the same code. Might not make a difference in any real code, but you never know.
5:23 PM Changeset in webkit [11461] by eseidel
  • 39 edits
    2 adds in trunk/WebCore

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

5 test cases updated, no additional tests needed.

Removed KCPathData, KCPathDataList and KCanvasUserData.
Added KCanvasPath and KCanvasPathQuartz instead.
Updated methods to expect KCanvasPath* types and use RefPtr.
Removed no longer needed KCPathDataList -> KCanvasUserData routines
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • WebCore.xcodeproj/project.pbxproj: added KCanvasPath(Quartz)
  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createRoundedRectangle): updated to KCanvasPath* (KCanvasCreator::createRectangle): updated to KCanvasPath* (KCanvasCreator::createEllipse): updated to KCanvasPath* (KCanvasCreator::createCircle): updated to KCanvasPath* (KCanvasCreator::createLine): updated to KCanvasPath*
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp: (RenderPath::Private::Private): updated to KCanvasPath* (RenderPath::~RenderPath): (RenderPath::changePath): (RenderPath::path): updated to KCanvasPath*
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp: (operator<<): updated to call device->stringForPath()
  • kcanvas/KCanvasPath.h: (KCanvasPath::~KCanvasPath): (KCClipDataList::addPath): updated to KCanvasPath*
  • kcanvas/KCanvasResources.cpp: (KCanvasClipper::addClipData): updated to KCanvasPath*
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::path): updated to KCanvasPath* (KCanvasCommonArgs::setPath): updated to KCanvasPath* (KRenderingDevice::KRenderingDevice):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): updated to KCanvasPath* (KCanvasItemQuartz::bboxForPath): updated to KCanvasPath* (KCanvasItemQuartz::hitsPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.h: Added. (KCanvasPathQuartz::cgPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: Added. (KCanvasPathQuartz::KCanvasPathQuartz): added (KCanvasPathQuartz::~KCanvasPathQuartz): added (KCanvasPathQuartz::isEmpty): added (KCanvasPathQuartz::moveTo): added (KCanvasPathQuartz::lineTo): added (KCanvasPathQuartz::curveTo): added (KCanvasPathQuartz::closeSubpath): added
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasClipperQuartz::applyClip): updated to KCanvasPath*
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createPath): added (KRenderingDeviceQuartz::stringForPath): updated to KCanvasPath* (KRenderingDeviceQuartz::createItem): updated to KCanvasPath*
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/svg/SVGCircleElementImpl.cpp: (SVGCircleElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.cpp: (KSVG::SVGEllipseElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.cpp: (SVGLineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolygonElementImpl.h:
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolylineElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer): updated to KCanvasPath* (SVGStyledElementImpl::updateCanvasItem): updated to KCanvasPath* (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledElementImpl.h: (KSVG::SVGStyledElementImpl::toPathData): updated to KCanvasPath*
5:10 PM Changeset in webkit [11460] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Do the same "skip text node" logic for the "oldUnder" variable as for the "targetNode" variable.
4:23 PM Changeset in webkit [11459] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed a problem from the patch to fix <rdar://problem/4365690>. After that checkin, KWQKHTMLPart was
inadvertently left with both centerSelectionInVisibleArea() and centerSelectionInVisibleArea() const.

  • kwq/KWQKHTMLPart.h: renamed centerSelectionInVisibleArea() to revealSelection(). This is the method that was named jumpToSelection() before my recent checkin.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin. (KWQKHTMLPart::revealSelection): renamed from centerSelectionInVisibleArea() (KWQKHTMLPart::advanceToNextMisspelling): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin.
  • kwq/WebCoreBridge.h: removed one of the two declarations of centerSelectionInVisibleArea()
4:14 PM Changeset in webkit [11458] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): removed double handling of centerSelectionInVisibleArea
3:48 PM Changeset in webkit [11457] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): Reimplement jumpToSelection: to call centerSelectionInVisibleArea:, and added a comment explaining why jumpToSelection: exists at all. Note that centerSelectionInVisibleArea: was already implemented here; it was added as part of HTML editing implementation without us realizing that it was the API replacement for jumpToSelection:. (-[WebHTMLView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection: (we should have done this when centerSelectionInVisibleArea: was implemented)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView centerSelectionInVisibleArea:]): new method, same code that jumpToSelection: used to have (-[WebPDFView jumpToSelection:]): now calls centerSelectionInVisibleArea:, and there's now a comment about why it exists at all. (-[WebPDFView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection:
2:56 PM Changeset in webkit [11456] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:31 PM Changeset in webkit [11455] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison, John Sullivan.

<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)

I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
initialized. Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
has been "committed" (inserted into the view hierarchy).

My fix is to ensure that the plugin is initialized where we previously would have created that second
WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.

  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy. We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView has been committed.
2:19 PM Changeset in webkit [11454] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Removed some dead code I happened to stumble across. No test cases added.

  • kwq/KWQTimer.h: removed unused immediateSingleShotOnMainThread()
  • kwq/KWQTimer.mm: removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget that was used to implement it.
2:01 PM Changeset in webkit [11453] by sullivan
  • 5 edits in trunk/WebCore

Reviewed by Tim Omernick.

  • WebCore part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)

No behavioral changes here. This patch just eliminates the name "jumpToSelection" in favor of
"centerSelectionInVisibleArea" to match WebKit and AppKit.

  • kwq/KWQKHTMLPart.h: eliminate jumpToSelection(); add centerSelectionInVisibleArea()
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): use centerSelectionInVisibleArea() instead of jumpToSelection() (KWQKHTMLPart::centerSelectionInVisibleArea): renamed from jumpToSelection (KWQKHTMLPart::advanceToNextMisspelling): use centerSelectionInVisibleArea() instead of jumpToSelection()
  • kwq/WebCoreBridge.h: eliminate jumpToSelection; add centerSelectionInVisibleArea
  • kwq/WebCoreBridge.mm: eliminate jumpToSelection. We had been implementing both jumpToSelection and centerSelectionInVisibleArea here, but jumpToSelection now has no more callers.
11:57 AM Changeset in webkit [11452] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
11:56 AM Changeset in webkit [11451] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
9:40 AM Changeset in webkit [11450] by vicki
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling

Dec 4, 2005:

3:45 PM Changeset in webkit [11449] by ggaren
  • 2 edits in trunk/JavaScriptCore

Update test results to match Anders's last checkin.

  • tests/mozilla/expected.html:
3:30 PM Changeset in webkit [11448] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

Add new tests for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

  • fast/js/test-propertyIsEnumerable-expected.txt: Added.
  • fast/js/test-propertyIsEnumerable.html: Added.
3:28 PM Changeset in webkit [11447] by andersca
  • 5 edits in trunk/JavaScriptCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • kjs/object.cpp: (KJS::ObjectImp::canPut): Refactor to use getPropertyAttributes.

(KJS::ObjectImp::propertyIsEnumerable):
New function which checks if a property is enumerable.

(KJS::ObjectImp::getPropertyAttributes):

  • kjs/object.h: Add getPropertyAttributes and propertyIsEnumerable.
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::): Add propertyIsEnumerable to the Object prototype.
3:14 PM Changeset in webkit [11446] by eseidel
  • 11 edits
    60 deletes in trunk/WebCore

Bug #: 5930
Submitted by: eseidel
Reviewed by: ggaren

No additional test cases needed (or possible).

Further dom/* cleanup, also removing extra forwarding headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5930

  • ForwardingHeaders/dom/dom2_views.h: Removed.
  • ForwardingHeaders/dom/dom_core.h: Removed.
  • ForwardingHeaders/dom/dom_doc.h: Removed.
  • ForwardingHeaders/dom/dom_element.h: Removed.
  • ForwardingHeaders/dom/dom_misc.h: Removed.
  • ForwardingHeaders/dom/dom_text.h: Removed.
  • ForwardingHeaders/dom/dom_xml.h: Removed.
  • ForwardingHeaders/dom/html_base.h: Removed.
  • ForwardingHeaders/dom/html_block.h: Removed.
  • ForwardingHeaders/dom/html_document.h: Removed.
  • ForwardingHeaders/dom/html_element.h: Removed.
  • ForwardingHeaders/dom/html_form.h: Removed.
  • ForwardingHeaders/dom/html_head.h: Removed.
  • ForwardingHeaders/dom/html_image.h: Removed.
  • ForwardingHeaders/dom/html_inline.h: Removed.
  • ForwardingHeaders/dom/html_list.h: Removed.
  • ForwardingHeaders/dom/html_misc.h: Removed.
  • ForwardingHeaders/dom/html_object.h: Removed.
  • ForwardingHeaders/dom/html_table.h: Removed.
  • ForwardingHeaders/ecma/kjs_css.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_window.h: Removed.
  • ForwardingHeaders/html/dtd.h: Removed.
  • ForwardingHeaders/kdom/KDOMPart.h: Removed.
  • ForwardingHeaders/kdom/KDOMView.h: Removed.
  • ForwardingHeaders/kdom/core/NodeListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSMediaRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/cssproperties.h: Removed.
  • ForwardingHeaders/kdom/css/cssvalues.h: Removed.
  • ForwardingHeaders/kdom/events/DocumentEventImpl.h: Removed.
  • ForwardingHeaders/kdom/parser/KDOMDocumentBuilder.h: Removed.
  • ForwardingHeaders/kdomcssproperties.h: Removed.
  • ForwardingHeaders/kdomcssvalues.h: Removed.
  • ForwardingHeaders/kinstance.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/property_map.h: Removed.
  • ForwardingHeaders/kjs/protected_object.h: Removed.
  • ForwardingHeaders/kjs/scope_chain.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • ForwardingHeaders/ksvg2/svg/svgtags.h: Removed.
  • ForwardingHeaders/q3intdict.h: Removed.
  • ForwardingHeaders/q3memarray.h: Removed.
  • ForwardingHeaders/q3ptrcollection.h: Removed.
  • ForwardingHeaders/q3ptrdict.h: Removed.
  • ForwardingHeaders/qcstring.h: Removed.
  • ForwardingHeaders/qcursor.h: Removed.
  • ForwardingHeaders/qintdict.h: Removed.
  • ForwardingHeaders/qpair.h: Removed.
  • ForwardingHeaders/qprinter.h: Removed.
  • ForwardingHeaders/qptrcollection.h: Removed.
  • ForwardingHeaders/qsize.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
  • ForwardingHeaders/qvaluevector.h: Removed.
  • ForwardingHeaders/xml/dom_positioniterator.h: Removed.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/dom/css_value.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.h:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/kjs_traversal.cpp:
3:07 PM Changeset in webkit [11445]
  • 210 copies
    17 deletes in tags/WebCore-417~9

This commit was manufactured by cvs2svn to create tag
'WebCore-417~9'.

3:07 PM Changeset in webkit [11444] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.9

2:01 PM Changeset in webkit [11443]
  • 26 copies
    3 deletes in tags/WebKit-312~7

This commit was manufactured by cvs2svn to create tag 'WebKit-312~7'.

2:01 PM Changeset in webkit [11442] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning to WebKit-312.7

1:59 PM Changeset in webkit [11441]
  • 118 copies
    5 deletes in tags/WebCore-315~12

This commit was manufactured by cvs2svn to create tag
'WebCore-315~12'.

1:59 PM Changeset in webkit [11440] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.12

1:58 PM Changeset in webkit [11439] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

1:56 PM Changeset in webkit [11438]
  • 10 copies
    3 deletes in tags/JavaScriptCore-312~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3'.

1:56 PM Changeset in webkit [11437] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning to JavaScriptCore-312.3

1:12 PM Changeset in webkit [11436] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2005-12-02 Adele Peterson <​adele@apple.com>

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
1:02 PM Changeset in webkit [11435] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
1:01 PM Changeset in webkit [11434] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
12:55 PM Changeset in webkit [11433] by andersca
  • 4 edits
    1 add in trunk/WebCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Don't send onblur to a node if m_inDetach is true.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach): Set m_inDetach to true while calling RenderObject::destroy.
  • khtml/xml/dom_nodeimpl.h:

Add m_inDetach flag.

  • manual-tests/onblur-remove.html: Added.
5:08 AM Changeset in webkit [11432] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: No review needed, WebCore+SVG build fix only.

I broke the WebCore+SVG build when removing dom_misc.h, fixing.

  • WebCore+SVG/KDOMHeaders.h: remove reference to dom_misc.h
4:43 AM Changeset in webkit [11431] by eseidel
  • 10 edits
    2 deletes in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no test cases possible or necessary.

Removed dom_misc.* and changed to use Shared instead of DOMShared.
Also removed FilterNode typedef, now using NodeImpl* directly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5929

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.cpp: (DOM::NodeFilterCondition::acceptNode):
  • khtml/dom/dom2_traversal.h:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_misc.cpp: Removed.
  • khtml/dom/dom_misc.h: Removed.
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode):
3:35 AM Changeset in webkit [11430] by eseidel
  • 21 edits in trunk/WebCore

Bug #: 5877
Submitted by: eseidel
Reviewed by: mjs

No test cases needed/possible, only removing dead code.

Remove rotten #ifdef'd code from the source:
APPLE_CHANGES & KHTML_NO_CPLUSPLUS_DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

  • khtml/dom/css_rule.h: (DOM::CSSRule::):
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.h: (DOM::CSSValue::): (DOM::CSSPrimitiveValue::):
  • khtml/dom/dom2_events.cpp: (DOM::EventListener::handleEventImpl):
  • khtml/dom/dom2_events.h: (DOM::Event::): (DOM::EventException::): (DOM::MutationEvent::):
  • khtml/dom/dom2_range.h: (DOM::RangeException::): (DOM::Range::):
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom2_traversal.h: (DOM::NodeFilter::):
  • khtml/dom/dom_exception.h: (DOM::DOMException::):
  • khtml/dom/dom_misc.cpp: (DOM::DomShared::~DomShared):
  • khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_node.h: (DOM::Node::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::focusNextPrevNode):
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKHTMLPageCache.h:
  • kwq/KWQPointArray.h:

Dec 3, 2005:

5:22 PM Changeset in webkit [11429] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
5:21 PM Changeset in webkit [11428] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
4:53 PM Changeset in webkit [11427] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
4:48 PM Changeset in webkit [11426] by justing
  • 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
4:32 PM Changeset in webkit [11425] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<​http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 PM Changeset in webkit [11424] by andersca
  • 5 edits in trunk/WebCore/khtml

Didn't mean to commit this.

12:16 PM Changeset in webkit [11423] by andersca
  • 11 edits
    1 add in trunk/WebCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
8:56 AM Changeset in webkit [11422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Improved ChangeLog comment.

Dec 2, 2005:

6:33 PM Changeset in webkit [11421] by bdakin
  • 4 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

5:44 PM Changeset in webkit [11420] by eseidel
  • 9 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Added ending newlines to files missing them.

  • ForwardingHeaders/kjs/property_map.h:
  • khtml/rendering/break_lines.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • kwq/DOM-compat.h:
  • kwq/KWQTextUtilities.h:
  • kwq/WebCoreKeyboardAccess.h:
5:32 PM Changeset in webkit [11419] by eseidel
  • 54 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.

SVG Build fix after SharedPtr -> RefPtr changes.

  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/svg/SVGAElementImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
  • ksvg2/svg/SVGFitToViewBoxImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.h:
  • ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGLinearGradientElementImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.h:
  • ksvg2/svg/SVGPolyElementImpl.h:
  • ksvg2/svg/SVGRadialGradientElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGStopElementImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGStyledTransformableElementImpl.h:
  • ksvg2/svg/SVGTestsImpl.h:
  • ksvg2/svg/SVGTextContentElementImpl.h:
  • ksvg2/svg/SVGTextPositioningElementImpl.h:
  • ksvg2/svg/SVGTransformImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGUseElementImpl.h:
  • ksvg2/svg/SVGViewElementImpl.h:
5:30 PM Changeset in webkit [11418] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

No review needed.

  • ksvg2/scripts/make_names.pl: Add standard license header.
5:18 PM Changeset in webkit [11417]
  • 55 copies
    22 deletes in tags/WebKit-417~6

This commit was manufactured by cvs2svn to create tag 'WebKit-417~6'.

5:18 PM Changeset in webkit [11416] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.6

5:17 PM Changeset in webkit [11415]
  • 210 copies
    17 deletes in tags/WebCore-417~8

This commit was manufactured by cvs2svn to create tag
'WebCore-417~8'.

5:17 PM Changeset in webkit [11414] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.8

5:06 PM Changeset in webkit [11413] by adele
  • 8 edits in trunk

LayoutTests:

Updating test for latest changes in:
<rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/replaced/width100percent.html:

WebCore:

Reviewed by Hyatt.

  • fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

We're backing out the fix for <rdar://problem/3952698>.
With the new button implementation, the buttons will
not overlap for the telia webmail case. We may need to address
the minWidth behavior for other elements at a later time.

  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
5:06 PM Changeset in webkit [11412] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
4:54 PM Changeset in webkit [11411] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:00 PM Changeset in webkit [11410] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:58 PM Changeset in webkit [11409] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:19 PM Changeset in webkit [11408] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
2:53 PM Changeset in webkit [11407] by justing
  • 3 edits in trunk/WebKit

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:44 PM Changeset in webkit [11406] by mjs
  • 12 edits in trunk/WebCore

SVG build fix, not reviewed.

  • land the ksvg2 part of my SharedPtr --> RefPtr change, which I forgot about before.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::parseTransformValue): (SVGAnimateTransformElementImpl::initialMatrix):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::canvasResource):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::getCTM):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::viewport): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::updateLocalTransform):
1:26 PM Changeset in webkit [11405] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:17 PM Changeset in webkit [11404] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:16 PM Changeset in webkit [11403] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:13 PM Changeset in webkit [11402] by vicki
  • 2 edits
    3 adds in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:13 PM Changeset in webkit [11401] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
12:58 PM Changeset in webkit [11400] by aboule
  • 2 edits in trunk/WebCore

Reviewed by rjw.

Added #else for XSLT ifdef to make sure switch case
doesn't fall through when feature turned off.

  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
12:32 PM Changeset in webkit [11399] by hyatt
  • 2 adds in trunk/LayoutTests/fast/clip

Add layout test for new clipping behavior.

12:23 PM Changeset in webkit [11398] by hyatt
  • 2 edits in trunk/WebCore

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

fast/clip/018.html

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:19 AM Changeset in webkit [11397] by andersca
  • 3 edits in trunk/WebCore

2005-12-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy.

  • WebCore.xcodeproj/project.pbxproj: Remove KWQRefPtr.h
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Remove a call to notNull here.
1:13 AM Changeset in webkit [11396] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Cache the lastItem and lastItemOffset for fast retrieval of the
same index or indeicies greater than lastItemOffset. Also cache
the length. Like other node lists these cached values rest when the
subtree under the root node changes.

  • khtml/xml/dom_nodeimpl.cpp: (ChildNodeListImpl::length): Use cachedLength when possible. (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.
1:00 AM Changeset in webkit [11395] by justing
  • 2 edits
    4 adds in trunk/LayoutTests

Reviewed by justin

Updated/added tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

  • editing/deleting/delete-3775172-fix-expected.txt: Fixed.
  • editing/inserting/editing-empty-divs-expected.checksum: Added.
  • editing/inserting/editing-empty-divs-expected.png: Added.
  • editing/inserting/editing-empty-divs-expected.txt: Added.
  • editing/inserting/editing-empty-divs.html: Added.
1:00 AM Changeset in webkit [11394] by justing
  • 2 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

Reviewed/tweaked/landed by justin

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): A position at the original block shouldn't be considered 'outside' the original block. (khtml::hasRenderedChildrenWithHeight): Added. (khtml::VisiblePosition::isCandidate): A block flow element with rendered children may be considered a candidate for a visible position, as long as its children do not have a positive height.
12:33 AM Changeset in webkit [11393] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Remove duplicate entry

Dec 1, 2005:

7:48 PM Changeset in webkit [11392] by mjs
  • 29 edits
    1 delete in trunk

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
4:41 PM Changeset in webkit [11391] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:38 PM Changeset in webkit [11390] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:04 PM Changeset in webkit [11389] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:57 PM Changeset in webkit [11388] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
3:55 PM Changeset in webkit [11387] by thatcher
  • 8 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
3:50 PM Changeset in webkit [11386] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:45 PM Changeset in webkit [11385] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
3:25 PM Changeset in webkit [11384] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
3:16 PM Changeset in webkit [11383] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
3:15 PM Changeset in webkit [11382] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
1:59 PM Changeset in webkit [11381] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 PM Changeset in webkit [11380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 AM Changeset in webkit [11379] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 AM Changeset in webkit [11378] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
9:59 AM Changeset in webkit [11377] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
9:58 AM Changeset in webkit [11376] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
2:32 AM Changeset in webkit [11375] by mjs
  • 76 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
12:38 AM Changeset in webkit [11374] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):

Nov 30, 2005:

3:04 PM Changeset in webkit [11373] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5890
Submitted by: eseidel
Reviewed by: darin

No additional tests needed, acid2 covers this case.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
2:46 PM Changeset in webkit [11372] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:44 PM Changeset in webkit [11371] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:40 PM Changeset in webkit [11370] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:39 PM Changeset in webkit [11369] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:25 PM Changeset in webkit [11368] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:24 PM Changeset in webkit [11367] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:15 PM Changeset in webkit [11366] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
2:14 PM Changeset in webkit [11365] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
1:53 PM Changeset in webkit [11364] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Added layout test for <rdar://problem/4344760> REGRESSION
(Safari 416.12-417.2) gmail 'reply' does not fill in to: field or
quoted message (3751)

  • fast/forms/textarea-setvalue-without-renderer-expected.txt: Added.
  • fast/forms/textarea-setvalue-without-renderer.html: Added.
3:49 AM Changeset in webkit [11363] by eseidel
  • 9 edits
    2 adds in trunk/WebCore

Bug #: 5887
Submitted by: eseidel
Reviewed by: mjs

No functionality change, no tests needed.

Make make_names.pl namespace agnostic and add XLinkNames.* for SVG

  • WebCore+SVG/XLinkNamesWrapper.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: added files, build rule.
  • khtml/khtml_part.cpp: (KHTMLPart::init): init XLinkNames
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): remove foreignObjectTag (temp.)
  • ksvg2/misc/xlinkattrs.in: Added.
  • ksvg2/scripts/make_names.pl: make namespace agnostic
  • ksvg2/svg/SVGLocatableImpl.cpp: remove foreignObjectTag (temp.) (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
  • ksvg2/svg/SVGURIReferenceImpl.cpp: use XLinkNames (SVGURIReferenceImpl::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: remove href
  • ksvg2/svg/svgtags.in: comment out unused tags
3:07 AM Changeset in webkit [11362] by eseidel
  • 1 edit
    117 deletes in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none neede, removing unused test results only.

Removing erroneously committed results content.

  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt: Removed.
1:21 AM Changeset in webkit [11361] by eseidel
  • 18 edits in trunk

Bug #: 5881
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes 5 test cases:

  • paths-data-02-t.svg (most noticeable)
  • fonts-elem-01-t.svg
  • fonts-elem-02-t.svg
  • fonts-elem-03-t.svg
  • fonts-elem-04-t.svg

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5881
Quadratic bezier path render error

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):

Nov 29, 2005:

7:12 PM Changeset in webkit [11360] by eseidel
  • 1 edit
    16 adds in trunk/LayoutTests

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • fast/dom/HTMLScriptElement/resources/script-set-src-p1fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p2fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p3pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p4pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p6pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p7pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p8pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failAfter.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failBefore.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9pass.js: Added.
  • fast/dom/HTMLScriptElement/script-set-src-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-set-src.html: Added.
7:12 PM Changeset in webkit [11359] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test: fast/dom/HTMLScriptElement/script-set-src.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): (HTMLScriptElementImpl::closeRenderer):
  • khtml/html/html_headimpl.h:
6:55 PM Changeset in webkit [11358] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820

  • fast/table/cell-width-auto-expected.checksum: Added.
  • fast/table/cell-width-auto-expected.png: Added.
  • fast/table/cell-width-auto-expected.txt: Added.
  • fast/table/cell-width-auto.html: Added.
6:51 PM Changeset in webkit [11357] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test: fast/table/cell-width-auto.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820
Table cells with width:auto should use width from their <col>

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_table.cpp: (RenderTableCell::styleOrColWidth): (RenderTableCell::calcMinMaxWidth):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (AutoTableLayout::recalcColumn): (AutoTableLayout::calcEffectiveWidth):
6:42 PM Changeset in webkit [11356] by eseidel
  • 4 edits
    4 adds in trunk/LayoutTests

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Updated results for word space fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695

  • fast/css/word-space-extra-expected.checksum:
  • fast/css/word-space-extra-expected.png:
  • fast/css/word-space-extra-expected.txt:
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.checksum: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow.html: Added.
6:40 PM Changeset in webkit [11355] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Test: fast/text/span-in-word-space-causes-overflow.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695
<span> in word-spaced text breaks width calc, causes overflow

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
6:07 PM Changeset in webkit [11354] by eseidel
  • 2 edits in trunk/WebKit

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentWithPaths:]):
6:06 PM Changeset in webkit [11353] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

No automated test possible.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • khtml/editing/markup.cpp: (khtml::createFragmentFromNodeList):
  • khtml/editing/markup.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
5:58 PM Changeset in webkit [11352] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5800
Submitted by: mitz
Reviewed by: eseidel

Test case: fast/css/absolute-poition-in-rtl-parent.html
Fix for bug: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
5:53 PM Changeset in webkit [11351] by eseidel
  • 1 edit
    6 adds in trunk/LayoutTests

Bug #: 5800
Submitted by: mitz
Reviewed by: darin

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • fast/css/absolute-poition-in-rtl-parent-expected.checksum: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.txt: Added.
  • fast/css/absolute-poition-in-rtl-parent.html: Added.
4:57 PM Changeset in webkit [11350] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

4:29 PM Changeset in webkit [11349] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5879
Submitted by: mitz
Reviewed by: eseidel

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5879
REGRESSION: Buttons go into pushed state when moused over when text field has focus

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inActiveChain to false.
4:11 PM Changeset in webkit [11348] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Fixes W3C events tests, no additional tests necessary.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5876

  • ksvg2/css/svg.css: added namespace declaration
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): added support of on* attrs
4:03 PM Changeset in webkit [11347] by eseidel
  • 6 edits
    1 delete in trunk/WebKitTools

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Update scripts to run SVG tests automatically (w/o --svg) if
WebCore is built with SVG support.

  • Scripts/build-drawtest: SVG support required
  • Scripts/build-dumpkcanvastree: Removed.
  • Scripts/run-drawtest: SVG support required to run
  • Scripts/run-webkit-tests: pass *.svg files if WebCore has support
  • Scripts/webkitdirs.pm: changed CheckWebCoreSVGSupport
2:34 PM Changeset in webkit [11346] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan, Eric Seidel

<rdar://problem/4340787> Safari sometimes creates 2 instances of plug-ins

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView of the appropriate class. Right now, this can only happen when the loading document is a standalone WebKit plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that kind of page load.

I have verified that this does not affect other kinds of page loads; in all other cases, the representation
class is distinct from the document view class.

I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
approach.

2:14 PM Changeset in webkit [11345] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

Test cases added: None. Manual testing is way to awkward, and automated testing
is not possible. See following bug...
<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::removedFromTree): Replace tab with spaces. Remove braces from one line "if".
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Send unregisterUniqueIdForUIElement unconditionally, for safety. (-[KWQAccObject dealloc]): New. Send [self detach] so KWQObject gets unregistered and other cleanup happens as well. (CreateCGColorIfDifferent): Replace tab with spaces. (-[KWQAccObject removeAccObjectID]): Early to prevent a crash if called on a detached KWQAccObject (i.e. m_renderer == 0).
11:55 AM Changeset in webkit [11344] by vicki
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

fixed a typo in the Changelog

11:49 AM Changeset in webkit [11343] by vicki
  • 2 edits
    1 add in trunk/WebCore

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
9:52 AM Changeset in webkit [11342] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQKURL.h: Added declaration of createCFURL function.
  • kwq/KWQKURL.mm: (KURL::createCFURL): Moved body of getNSURL in here. (KURL::getNSURL): Changed to createCFURL.
9:44 AM Changeset in webkit [11341] by darin
  • 2 edits in trunk/WebCore
  • fixed broken tree (from my last check-in)
  • kwq/DOM-CSS.mm: Added "using namespace DOM" and an import of "dom_docimpl.h".
9:28 AM Changeset in webkit [11340] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/DOM.mm: Removed extra implementation of -[DOMDocument getComputedStyle::].
  • kwq/DOM-CSS.mm: (-[DOMDocument getComputedStyle::]): Copied slightly better implementation from DOM.mm in here.
9:22 AM Changeset in webkit [11339] by darin
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/KWQFontFamily.h: Replace _NSFamily with _CFFamily.
  • kwq/KWQFontFamily.mm: (KWQFontFamily::KWQFontFamily): Ditto. (KWQFontFamily::operator=): Ditto. (KWQFontFamily::getNSFamily): More of the same. (KWQFontFamily::setFamily): Ditto.
9:17 AM Changeset in webkit [11338] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQDateTime.mm: (QTime::msec): Just multiply and mod the time in seconds, don't bother converting to a Gregorian date first, since that won't affect fractional seconds. (QTime::addMSecs): Multiply by 1/1000 instead of dividing by 1000.
9:14 AM Changeset in webkit [11337] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQEvent.mm: (WindowsKeyCodeForKeyEvent): Add case for tab key. (QKeyEvent::QKeyEvent): Force use of character code 9 for tab key regardless of what AppKit returns.
  • manual-tests/log-keypress-events.html: Added.
9:03 AM Changeset in webkit [11336] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/html/html_imageimpl.h: Removed unused currentImage function.
  • khtml/html/html_imageimpl.cpp: Bits of cleanup in many functins, and: (DOM::HTMLMapElementImpl::mapMouseEvent): Simplified by using traverseNextNode. (DOM::HTMLMapElementImpl::parseMappedAttribute): Fixed bug where parsing a name or attribute value with a "#" prefix would actually modify the value itself by changing the DOMString. Changed the code to make a copy in this case. (DOM::HTMLAreaElementImpl::getRegion): Rearranged to be more readable.
8:35 AM Changeset in webkit [11335] by darin
  • 2 edits in trunk/LayoutTests
8:15 AM Changeset in webkit [11334] by darin
  • 2 edits in trunk/WebCore
  • fixed deployment builds
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): Put decoder local variable inside if statement.
3:20 AM Changeset in webkit [11333] by eseidel
  • 51 edits
    12 adds in trunk

Bug #: 5842
Submitted by: eseidel
Reviewed by: mjs

3 test cases added to cover CSS updates and CDF support.
Updated all test results for absolute bbox change.

Fixed in this patch:

  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::KCanvasContainer): make "replaced" element
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): added parent offset ASSERT
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): account for parent offset (KCanvasContainerQuartz::absoluteTransform): reflect viewport
  • khtml/css/css_valueimpl.cpp: remove HTML special case (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  • khtml/css/cssstyleselector.cpp: remove HTML special case (khtml::CSSStyleSelector::locateCousinList):
  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock): special case KCanvasContainer
  • khtml/rendering/render_style.cpp: (RenderStyle::operator==): fix call into SVGRenderStyle (RenderStyle::inheritedNotEqual): calls into SVGRenderStyle (RenderStyle::diff): calls into SVGRenderStyle
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::equals): include flags in comparison (SVGRenderStyle::inheritedNotEqual): added
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::parseMappedAttribute): clear path first
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attributeChanged): map to ksvg2 attributes
  • ksvg2/svg/SVGStyledElementImpl.h:
2:36 AM Changeset in webkit [11332] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Tests for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • fast/js/date-DST-pre-1970-expected.txt: Added.
  • fast/js/date-DST-pre-1970.html: Added.
2:33 AM Changeset in webkit [11331] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Date conversion to local time gets the DST flag wrong sometimes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • kjs/date_object.cpp: (KJS::isTime_tSigned): (KJS::DateProtoFuncImp::callAsFunction):
2:11 AM Changeset in webkit [11330] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5310
Submitted by: mitz
Reviewed by: hyatt

Not possible to test (functionality shouldn't change).

Switch QRegion from using NSBezierPath to CGPath
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5310

  • kwq/KWQRegion.h:
  • kwq/KWQRegion.mm: (QRegion::QRegion): (QRegion::~QRegion): (QRegion::operator=): (QRegion::contains): (QRegion::translate): (QRegion::boundingRect):
1:55 AM Changeset in webkit [11329] by eseidel
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

Bug #: 5316
Submitted by: darin
Reviewed by: eseidel

Re-enabling hc_noderemovechild.xhtml and fixing bug (hang).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5316

  • dom/xhtml/level1/core/hc_noderemovechild-expected.txt: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.js: hang workaround.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml-disabled: Removed.
1:07 AM Changeset in webkit [11328] by mjs
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin. Commited by Maciej.

  • fast/dom/Document/document-charset-expected.txt: Added.
  • fast/dom/Document/document-charset.html: Added.

WebCore:

Reviewed by Darin. Commited by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
Note: See TracTimeline for information about the timeline view.