⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 29, 2006:

11:27 PM Changeset in webkit [12474] by darin
  • 32 edits
    6 deletes in trunk/WebCore

Reviewed by Maciej.

  • killed more KWQ, KWinModule and QVariant
  • ForwardingHeaders/kwinmodule.h: Removed.
  • ForwardingHeaders/qvariant.h: Removed.
  • kwq/KWQKWinModule.h: Removed.
  • kwq/KWQKWinModule.mm: Removed.
  • kwq/KWQVariant.cpp: Removed.
  • kwq/KWQVariant.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removal.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_binding.cpp: Remove QVariant stuff.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
  • page/Frame.h:
  • page/Frame.cpp: (getString): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::executeScheduledScript): (Frame::changeLocation): (Frame::urlSelected): (Frame::submitForm): Changed to use JSValue instead of QVariant for result of executing JavaScript.
  • kwq/KWQObject.h: Removed a bunch of unneeded includes and forward declarations.
  • bridge/mac/MacFrame.mm:
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQObject.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextField.mm:
  • loader/CachedImage.h:
  • page/FrameView.h:
  • page/FrameView.cpp:
  • rendering/render_form.cpp: Updated includes, since KWQObject.h now includes less. Also updated callers to executeScript since one overload was removed.
11:18 PM Changeset in webkit [12473] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • properly define Vector assignment operator; the private version was accidentally left in, and the template version is not enough to replace the default
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator=):
11:13 PM Changeset in webkit [12472] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Added back #include <qvaluelist.h> to fix WIN32 build.

  • rendering/render_style.h:
10:06 PM Changeset in webkit [12471] by darin
  • 50 edits
    2 adds
    11 deletes in trunk/WebCore

Reviewed by Hyatt (drag image fix) and Maciej (the rest).

  • fixed just-introduced crash dragging images

I don't know how to make a layout test for this.

  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): Fixed crash on dragging by initializing m_dragImage to 0.
  • kwq/KWQApplication.h: Removed.
  • kwq/KWQApplication.mm: Removed.
  • kwq/KWQGlobal.cpp: Removed.
  • kwq/KWQKPartsEvent.cpp: Removed.
  • kwq/KWQKPartsEvent.h: Removed.
  • kwq/KWQPair.h: Removed.
  • kwq/KWQStyle.cpp: Removed.
  • kwq/KWQStyle.h: Removed.
  • ForwardingHeaders/kparts/event.h: Removed.
  • ForwardingHeaders/qapplication.h: Removed.
  • ForwardingHeaders/qstyle.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Screen.h: Added. Replaces the desktop widget stuff in KWQApplication.mm.
  • platform/mac/Screen.mm: Added.
  • kwq/KWQDef.h: Removed everything except for kMin and kMax from here. We should port to std::min and std::max, and then we can get rid of this header altogether.
  • kwq/KWQKCursor.h: Removed setAutoHideCursor.
  • kwq/KWQKCursor.mm: Ditto.
  • kwq/KWQWidget.h: Removed style() and setStyle() functions.
  • kwq/KWQWidget.mm: Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::Screen): Store a pointer to the Frame. (KJS::Screen::getValueProperty): Port to use the new Screen.h functions. (KJS::showModalDialog): Ditto. (KJS::Window::getValueProperty): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/khtml_events.h:
  • khtml/khtml_events.cpp: Removed much of the code here. This can be cut down even more.
  • khtml/misc/khtmllayout.h: Removed unused stuff and updated for KWQ changes.
  • kwq/KWQCString.cpp:
  • kwq/KWQKURL.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextCodec.cpp:
  • WebCore+SVG/KDOMSettings.cpp:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssparser.cpp:
  • kcanvas/KCanvasItem.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • page/Frame.h:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/IntPointArray.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderTable.cpp:
  • rendering/bidi.cpp:
  • rendering/bidi.h:
  • rendering/render_form.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
  • rendering/render_style.h:
  • rendering/table_layout.cpp: Updated for above KWQ changes. Changed tabs to spaces.
9:58 PM Changeset in webkit [12470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix the build by applying a GCC-specific namespace hack.

  • kjs/lookup.h:
8:52 PM Changeset in webkit [12469] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
8:50 PM Changeset in webkit [12468] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build on Win32.

  • kjs/lookup.h: fixed ::cacheGlobalObject
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): use unsigned long
4:54 PM Changeset in webkit [12467] by hyatt
  • 15 edits in trunk/WebCore

Fix for bug 6910, don't let Image be assignable or copiable. It will soon represent the actual
original Image (including the data) and as such must remain unique.

Reviewed by darin

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::setCachedImage):
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::cachedImage):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::~ImagePattern): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::cachedImage):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::cachedImage):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::~SVGCursorElementImpl): (SVGCursorElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::cachedImage):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): (SVGFEImageElementImpl::notifyFinished):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement): (WebCore::KWQClipboard::imageChanged): (WebCore::KWQClipboard::dragNSImage):
  • platform/Image.h:
3:40 PM Changeset in webkit [12466] by darin
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/render_image.h: (WebCore::RenderImage::image): Return a null image when m_cachedImage is 0. (WebCore::RenderImage::errorOccurred): Return false when m_cachedImage is 0.
  • rendering/render_image.cpp: (WebCore::RenderImage::nullImage): Added. Returns a global null image for use when we have no cached image.
  • rendering/render_object.h: Renamed the old setImage to imageChanged, the new name for the same function.
  • rendering/render_object.cpp: (WebCore::RenderObject::imageChanged): Ditto.
  • rendering/render_list.cpp: (RenderListMarker::imageChanged): Changed the call to parent to call the new imageChanged instead of the old setImage.
  • fixed something else that was causing some layout test crashes
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Rearrange so we won't ever dereference a null pointer here.
2:24 PM Changeset in webkit [12465] by darin
  • 15 edits
    3 adds in trunk/LayoutTests

Reviewed by Darin.

  • fixed some tests that were missing test images
  • fast/replaced/resources/sample.gif: Added.
  • fast/replaced/resources/1x1-green.png: Added.
  • fast/replaced/resources/1x1-red.png: Added.
  • fast/replaced/001.html: Changed images to point to actual images.
  • fast/replaced/002.html: Ditto.
  • fast/replaced/003.html: Ditto.
  • fast/replaced/004.html: Ditto.
  • fast/replaced/002-expected.txt: Updated.
  • fast/replaced/003-expected.txt: Updated.
  • fast/replaced/001-expected.png: Updated.
  • fast/replaced/001-expected.checksum: Updated.
  • fast/replaced/002-expected.png: Updated.
  • fast/replaced/002-expected.checksum: Updated.
  • fast/replaced/003-expected.png: Updated.
  • fast/replaced/003-expected.checksum: Updated.
  • fast/replaced/004-expected.png: Updated.
  • fast/replaced/004-expected.checksum: Updated.
1:12 PM Changeset in webkit [12464] by mjs
  • 17 edits
    7 deletes in trunk/WebCore

Reviewed by Darin.

  • ForwardingHeaders/q3valuevector.h: Removed.
  • ForwardingHeaders/qptrvector.h: Removed.
  • ForwardingHeaders/qvector.h: Removed.
  • WebCore+SVG/KDOMSettings.cpp: (KDOMSettings::init): (KDOMSettings::isAdFiltered):
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge controlsInForm:]):
  • css/cssstyleselector.h:
  • khtml/html/HTMLCollectionImpl.cpp: (WebCore::HTMLCollectionImpl::updateNameCache): (WebCore::HTMLCollectionImpl::namedItems):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (WebCore::HTMLFormCollectionImpl::calcLength): (WebCore::HTMLFormCollectionImpl::item): (WebCore::HTMLFormCollectionImpl::getNamedFormItem): (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::~HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::length): (WebCore::HTMLFormElementImpl::submitClick): (WebCore::HTMLFormElementImpl::formData): (WebCore::HTMLFormElementImpl::submit): (WebCore::HTMLFormElementImpl::reset): (WebCore::insertIntoVector): (WebCore::removeFromVector): (WebCore::HTMLFormElementImpl::formElementIndex): (WebCore::HTMLFormElementImpl::registerImgElement):
  • khtml/html/HTMLFormElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • kwq/KWQComboBox.h:
  • kwq/KWQListBox.h:
  • kwq/KWQPtrVector.h: Removed.
  • kwq/KWQRenderTreeDebug.cpp: (writeLayers):
  • kwq/KWQValueVector.h: Removed.
  • kwq/KWQVectorImpl.cpp: Removed.
  • kwq/KWQVectorImpl.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::compareZIndex): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/render_layer.h: (khtml::RenderLayer::posZOrderList): (khtml::RenderLayer::negZOrderList):
10:59 AM Changeset in webkit [12463] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/border-collapsing/rtl-border-collapsing.html: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.checksum: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.png: Added.
10:59 AM Changeset in webkit [12462] by darin
  • 5 edits in trunk/WebCore

Test: fast/table/border-collapsing/rtl-border-collapsing.html

Reviewed by Darin.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::cellBefore): Renamed cellLeft to this. (WebCore::RenderTable::cellAfter): Renamed cellRight to this.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): Added the RTL case. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::borderLeft): (WebCore::RenderTableCell::borderRight): (WebCore::RenderTableCell::collectBorders): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
10:19 AM Changeset in webkit [12461] by darin
  • 1 edit
    10 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • fast/dom/Window/resources: Added.
  • fast/dom/Window/resources/destination.html: Added.
  • fast/dom/Window/window-open-parent-expected.txt: Added.
  • fast/dom/Window/window-open-parent-no-parent-expected.txt: Added.
  • fast/dom/Window/window-open-self-expected.txt: Added.
  • fast/dom/Window/window-open-top-expected.txt: Added.
10:18 AM Changeset in webkit [12460] by darin
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Roll out file that was checked in by accident.

10:15 AM Changeset in webkit [12459] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix check for special frame names. These special frame names are supposed to always be unaffected by pop-up blocking. But the code instead was saying that the special frame names are always blocked. Oops!
10:11 AM Changeset in webkit [12458] by darin
  • 2 edits
    5 adds in trunk/LayoutTests
  • added a test for the names of range exceptions, which were wrong in my last commit until I made the fix Alexey suggested
  • fast/dom/Range: Added.
  • fast/dom/Range/range-exceptions.html: Added.
  • fast/dom/Range/resources: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
  • fast/dom/Range/resources/TEMPLATE.html: Added.
  • fast/js/resources/js-test-pre.js: Escape & and < characters in the output so you can have tests with HTML fragments as expected results.
10:10 AM Changeset in webkit [12457] by darin
  • 2 edits in trunk/WebCore

Suggested by Alexey.

  • fixed something Alexey noticed in the new exception names

Test: fast/dom/Range/range-exceptions.html

  • khtml/ecma/kjs_binding.cpp: Added 0 to fix an off-by-one error for the names of the two DOM range exceptions.
7:11 AM Changeset in webkit [12456] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Adding test cases for:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

  • editing/selection/move-by-line-002-expected.png: Added.
  • editing/selection/move-by-line-002-expected.checksum: Added.
  • editing/selection/move-by-line-002-expected.txt: Added.
  • editing/selection/move-by-line-002.html: Added.
  • editing/deleting/delete-listitem-002-expected.checksum: Added.
  • editing/deleting/delete-listitem-002-expected.png: Added.
  • editing/deleting/delete-listitem-002-expected.txt: Added.
  • editing/deleting/delete-listitem-002.html: Added.
7:06 AM Changeset in webkit [12455] by harrison
  • 4 edits in trunk/WebCore

Reviewed by John.

Fix two problems with editing around empty list items:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

Added tests:

  • selection/move-by-line-002.html
  • deleting/delete-listitem-002.html


  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • special check for empty list item because list marker assures non-zero height()


  • khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent):
  • fix check wrt BRs because text box is not required


  • rendering/bidi.cpp: (khtml::RenderBlock::constructLine):
  • make sure that br by itself in a list item gets a text-style box


(khtml::RenderBlock::findNextLineBreak):

  • make sure that br by itself in a list item gets a box at all
6:40 AM Changeset in webkit [12454] by eseidel
  • 78 edits in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt & darin.

There are a few small, but intertwined fixes in this patch:

Remaining fixes for SVGTetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

Fix for CDF support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

Updated test: svg/custom/simpleCDF.xml

Fix for filter updating:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

Also, as a side effect of 6849, fixed double-apply of filters, improving:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

Results updated for most tests, pixel results improved for filter tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
  • kcanvas/KCanvasFilters.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): use relativeBBox (RenderSVGImage::relativeBBox): added (RenderSVGImage::imageChanged): added (RenderSVGImage::getAbsoluteRepaintRect): fixed
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::imageChanged): added.
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): use new baseclass method (KCanvasFEFloodQuartz::getCIFilter): fixed.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout): update width/height (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed. (KCanvasItemQuartz::requiresLayer): moved to .cpp (KCanvasItemQuartz::lineHeight): added. (KCanvasItemQuartz::baselinePosition): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::canHaveChildren): moved to .cpp (KCanvasContainerQuartz::requiresLayer): moved to .cpp (KCanvasContainerQuartz::lineHeight): added. (KCanvasContainerQuartz::baselinePosition): added. (KCanvasContainerQuartz::paint): fixed. (KCanvasContainerQuartz::viewportTransform): fixed. (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed. (KCanvasContainerQuartz::absoluteTransform): fixed.
  • rendering/render_object.cpp: (WebCore::RenderObject::absoluteTransform): fixed apply order.
3:19 AM Changeset in webkit [12453] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): Add unsigned overload
1:40 AM Changeset in webkit [12452] by eseidel
  • 4 edits
    4 adds in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

First set of fixes for SVG Tetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Tests:

  • bridge/mac/MacFrame.mm: (MacFrame::keyEvent): pass key events to things other than HTML
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::parseMappedAttribute): update viewport
1:09 AM Changeset in webkit [12451] by darin
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt

Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.

12:57 AM Changeset in webkit [12450] by darin
  • 21 edits
    10 deletes in trunk/LayoutTests
  • dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
  • dom/xhtml/level3/core/canonicalform06-expected.txt:
  • dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
  • dom/xhtml/level3/core/infoset06-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
  • dom/xhtml/level3/core/noderemovechild04-expected.txt:
  • dom/xhtml/level3/core/noderemovechild05-expected.txt:
  • dom/xhtml/level3/core/nodereplacechild13-expected.txt:
  • dom/xhtml/level3/core/wellformed01-expected.txt:
  • dom/xhtml/level3/core/wellformed02-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt:
  • for these, also changed the tests to be dumpAsText at the same time
  • fast/dom/outerText-no-element.html:
  • fast/dom/outerText-no-element-expected.txt:
  • fast/dynamic/outerHTML-no-element.html:
  • fast/dynamic/outerHTML-no-element-expected.txt:
  • fast/dom/outerText-no-element-expected.checksum: Removed.
  • fast/dom/outerText-no-element-expected.png: Removed.
  • fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
  • fast/dynamic/outerHTML-no-element-expected.png: Removed.
  • removed test results for tests that are either disabled or not checked in
  • dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
  • dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
  • editing/execCommand/boldCharacter-expected.txt: Removed.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
  • fast/parser/remove-block-in-residual-style-expected.png: Removed.
  • fast/parser/remove-block-in-residual-style-expected.txt: Removed.
  • fast/plugins: Removed.
  • fast/plugins/netscape-back-forward-expected.txt: Removed.
  • fast/plugins/resources: Removed.
  • fast/plugins/resources/go-back.html: Removed.
12:26 AM Changeset in webkit [12449] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix SVG layout tests crash due to Vector change.

  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): check isEmpty, return 0
12:04 AM Changeset in webkit [12448] by eseidel
  • 2 edits in trunk/WebCore

2006-01-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove bogus IntRect operator.

  • platform/FloatRect.h:

Jan 28, 2006:

11:45 PM Changeset in webkit [12447] by hyatt
  • 27 edits in trunk

WebCore:

Cleanup of RenderImage. Eliminate unneeded members and methods.

Reviewed by darin

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::attach):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::attach):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::compositeOperator):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/WebCoreImageRenderer.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged):
  • platform/Image.h: (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::Image::Image): (WebCore::Image::resetAnimation): (WebCore::Image::operator=): (WebCore::Image::stopAnimations): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::image): (WebCore::RenderImage::errorOccurred):
  • rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:

WebKit:

Clean up RenderImage, eliminating unneeded members and methods.


Reviewed by darin

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer size]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
11:42 PM Changeset in webkit [12446] by darin
  • 2 edits
    3 adds in trunk/LayoutTests

Reviewed by John Sullivan.

  • fast/js/date-constructor.html: Added.
  • fast/js/date-constructor-expected.txt: Added.
  • fast/js/resources/date-constructor.js: Added.
  • fast/js/resources/date-big-constructor.js: Formatting tweak.
11:42 PM Changeset in webkit [12445] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
11:38 PM Changeset in webkit [12444] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/events/dispatch-to-handle-event.html: Added.
  • fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

Reviewed by Eric.

Test: fast/events/dispatch-to-handle-event.html

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Remove boolean that is always false, and correct the one place that was checking it to check the correct pointer instead.
10:52 PM Changeset in webkit [12443] by mjs
  • 9 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • remove QPtrStack, replace with Vector or traverseNextNode as appropriate
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): (KRenderingDevice::popContext): (KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]):
  • kwq/KWQPainter.mm: (WebCore::QPainter::save): (WebCore::QPainter::restore):
  • kwq/KWQPtrStack.h: Removed.
  • ForwardingHeaders/qptrstack.h: Removed.
  • ForwardingHeaders/q3ptrstack.h: Removed.
10:47 PM Changeset in webkit [12442] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • miscellaneous Vector improvements
  • kxmlcore/Vector.h: (KXMLCore::Vector::at): Add range-checking asserts. (KXMLCore::Vector::first): Added as a convenience. (KXMLCore::Vector::last): Convenience for stack-style use. (KXMLCore::Vector::removeLast): ditto
10:25 PM Changeset in webkit [12441] by mjs
  • 1 edit
    1 add
    2 deletes in trunk/WebCore
  • added missing forwarding header to fix build.


  • ForwardingHeaders/kxmlcore/Vector.h: Added.
9:26 PM Changeset in webkit [12440] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter to fix the build.
9:23 PM Changeset in webkit [12439] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • converted KWQKURL to use Vector :bugzilla.opendarwin.org/show_bug.cgi?id=6900

Use Vector in place of Array, and in place of the custom stack
buffers with overflow.


  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (findHostnamesInMailToURL): (encodeHostnames):
8:30 PM Changeset in webkit [12438] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
8:18 PM Changeset in webkit [12437] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/create_hash_table: Added missing license.
8:17 PM Changeset in webkit [12436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not already there, even if the checksum is correct.
8:12 PM Changeset in webkit [12435] by mjs
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Dave Hyatt.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): Apply Vector. (KJS::clearNewNodes): ditto
  • kjs/number_object.cpp: (integer_part_noexp): ditto (char_sequence): ditto
  • kjs/ustring.cpp: (KJS::UString::UTF8String): ditto
  • kxmlcore/HashMap.h: (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap, other versions are useful for other containers.
  • kxmlcore/Vector.h: Added. Implemented a Vector class, which should be usable for all Array/QVector style purposes, and also as a stack buffer with oversize handling. Also some helper classes to make vector operations as efficient as possible for POD types and for simple non-PODs like RefPtr. (KXMLCore::): (KXMLCore::VectorTypeOperations::destruct): (KXMLCore::VectorTypeOperations::initialize): (KXMLCore::VectorTypeOperations::move): (KXMLCore::VectorTypeOperations::uninitializedCopy): (KXMLCore::VectorTypeOperations::uninitializedFill): (KXMLCore::VectorBuffer::VectorBuffer): (KXMLCore::VectorBuffer::~VectorBuffer): (KXMLCore::VectorBuffer::deallocateBuffer): (KXMLCore::VectorBuffer::inlineBuffer): (KXMLCore::Vector::Vector): (KXMLCore::Vector::~Vector): (KXMLCore::Vector::size): (KXMLCore::Vector::capacity): (KXMLCore::Vector::isEmpty): (KXMLCore::Vector::at): (KXMLCore::Vector::operator[]): (KXMLCore::Vector::data): (KXMLCore::Vector::operator T*): (KXMLCore::Vector::operator const T*): (KXMLCore::Vector::begin): (KXMLCore::Vector::end): (KXMLCore::Vector::clear): (KXMLCore::Vector::fill): (KXMLCore::Vector::operator=): (KXMLCore::::Vector): (KXMLCore::::operator): (KXMLCore::::fill): (KXMLCore::::expandCapacity): (KXMLCore::::resize): (KXMLCore::::reserveCapacity): (KXMLCore::::append): (KXMLCore::deleteAllValues):
  • kxmlcore/VectorTraits.h: Added. (KXMLCore::VectorTraits): Traits to enable making Vector efficient for simple types.
5:50 PM Changeset in webkit [12434] by hyatt
  • 6 edits in trunk/WebCore

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:50 PM Changeset in webkit [12433] by hyatt
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebImageRenderer.m

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:32 PM Changeset in webkit [12432] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/add-before-anonymous-child.html: Added.
  • fast/table/add-before-anonymous-child-expected.txt: Added.
  • fast/table/add-before-anonymous-child-expected.png: Added.
  • fast/table/add-before-anonymous-child-expected.checksum: Added.
5:29 PM Changeset in webkit [12431] by darin
  • 3 edits in trunk/WebCore

Test: fast/table/add-before-anonymous-child.html

Reviewed by Darin.

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): If beforeChild is inside an anonymous cell, insert into the cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed comment.
4:58 PM Changeset in webkit [12430] by hyatt
  • 3 edits in trunk/WebCore

Eliminate the mask() method on Image. It's unused.

  • platform/Image.h:
  • platform/mac/Image.mm:
4:16 PM Changeset in webkit [12429] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix Changelog typo.

4:15 PM Changeset in webkit [12428] by hyatt
  • 7 edits in trunk/WebCore

Clean up the Image class. Eliminate the MIME type memebr variable.
Eliminate an unused constructor. Fix the constructor to take
a QString rather than an NSString so that it's portable. Rename
the receivedData method to decode. Move canRenderImageType into
the Image class as a static method.

Reviewed by mjs

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::isImageType):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseMIMEType):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::supportsType): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::decode): (WebCore::Image::operator=):
2:18 AM Changeset in webkit [12427] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-28 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

SourceAlpha does not display until window is redrawn (resized)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6375

Test: svg/custom/filter-source-alpha.svg

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage):`
12:53 AM Changeset in webkit [12426] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fallback to kCFStringEncodingWindowsLatin1 if the passed buffer is not valid UTF-8, preventing crashes.
12:52 AM Changeset in webkit [12425] by hyatt
  • 13 edits
    2 deletes in trunk/WebCore

Fix CachedImage.h/.cpp up. Lots of cleanup. Eliminated
unused code and cleaned up method and member names.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::deref): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::decodedRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify):
  • loader/CachedImage.h: (WebCore::CachedImage::isDecoded): (WebCore::CachedImage::isErrorImage): (WebCore::CachedImage::schedule): (WebCore::CachedImage::isImage):
  • loader/CachedImageCallback.cpp: Removed.
  • loader/CachedImageCallback.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::receivedData):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::setImage):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):

Jan 27, 2006:

7:26 PM Changeset in webkit [12424] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • ForwardingHeaders/JSLock.h: added
  • page/Page.cpp: (Page::~Page): In debug mode, when destroying the last page, 0 out m_mainFrame to destroy the very last frame and then garbage collect, so a GC happens at a time when the stack won't have references into the JS heap for the conservative GC to catch.
7:07 PM Changeset in webkit [12423] by mjs
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Eric.

  • ForwardingHeaders/kjs/JSLock.h: Added.
  • bridge/mac/MacFrame.mm: (Plugin::Plugin): renamed from KWQPluginPart, make it able to store a view. (Plugin::view): And return the QWidget* view. (MacFrame::createPart): Use Plugin instead of KWQPluginPart, avoid setWidget. (MacFrame::setView): Don't use m_url directly so much, and use through d-> if needed. (MacFrame::userAgent): ditto (MacFrame::openURLFromPageCache): ditto
  • kwq/KWQObject.cpp: (QObject::inherits): Removed case for ObjectContents, which is not long for this world.
  • kwq/KWQObject.h:
  • page/Frame.cpp: (Frame::init): Don't pass parent() to FramePrivate, we can't possibly have one yet. (Frame::restoreURL): d->m_url, not m_url (Frame::didOpenURL): ditto (Frame::executeScript): ditto (Frame::receivedFirstData): ditto (Frame::begin): ditto (Frame::gotoAnchor): ditto (Frame::requestObject): ditto, plus only use Frame methods when we really have a Frame. (Frame::processObjectRequest): ditto, also get view() not widget(). (Frame::childFrame): remove excess spaces and pointless assert. (Frame::parentFrame): just call parent() (could probably remove this). (Frame::reparseConfiguration): d->m_url not m_url (Frame::canCachePage): ditto (Frame::updatePolicyBaseURL): ditto (Frame::scrollToAnchor): ditto (Frame::setName): set in FramePrivate (Frame::name): get from FramePrivate (Frame::setParent): similarly (Frame::parent): similarly (Frame::url): similarly
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Added m_parent, m_name and m_url.
  • page/FrameView.cpp: (FrameView::viewportMousePressEvent): Call frame directly instead of sending through QApplication. (FrameView::viewportMouseDoubleClickEvent): ditto (FrameView::viewportMouseMoveEvent): ditto (FrameView::viewportMouseReleaseEvent): ditto
  • page/ObjectContents.h: (ObjectContents::ObjectContents): Removed url, setParent, parent, name, setName, openURL, closeURL, widget, setWidget, event and customEvent methods, and corresponding fields. Add pure virtual view() method.
5:19 PM Changeset in webkit [12422] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adele.

  • fast/events/related-target-expected.txt: Added.
  • fast/events/related-target.html: Added.
5:18 PM Changeset in webkit [12421] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

Test: fast/events/related-target.html

  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Added a relatedTarget parameter to a couple overloads.
  • page/FrameView.cpp: (FrameView::viewportMouseMoveEvent): Moved code to set prevMouseX/Y out of here and into dispatchMouseEvent, because it now handles mouseout and mouseover events, and that's what these globals are used for. This fixes DumpRenderTree to work properly with mouseout and mouseover (because it delivers only mouse down and up, no mouse move events). (FrameView::dispatchMouseEvent): Passed in the "other" node as the related target for mouseout and mouseover events. Also set prevMouseX/Y.
5:05 PM Changeset in webkit [12420] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: make new tests use absolute urls
3:41 PM Changeset in webkit [12419] by adele
  • 2 edits
    4 adds in trunk

LayoutTests:

Adding test for
<rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

  • fast/forms/input-no-renderer-expected.checksum: Added.
  • fast/forms/input-no-renderer-expected.png: Added.
  • fast/forms/input-no-renderer-expected.txt: Added.
  • fast/forms/input-no-renderer.html: Added.

WebCore:

Adding comment for added layout test.

3:06 PM Changeset in webkit [12418] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to mention layout tests landed with previous commits.

2:39 PM Changeset in webkit [12417] by adele
  • 1 edit in trunk/WebCore/ChangeLog

Updating ChangeLog with explanation of missing test case.

1:18 PM Changeset in webkit [12416] by tomernic
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to explain why my last commit did not include a test case.

2:52 AM Changeset in webkit [12415] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

make run-webkit-tests output total leaks count

  • Scripts/run-webkit-tests:
2:22 AM Changeset in webkit [12414] by hyatt
  • 76 edits
    2 moves
    7 deletes in trunk/WebCore

Fix for 6867. Rename QPixmap to Image and move it to platform/.
Eliminate QPaintDevice and QPaintDeviceMetrics completely, since
they aren't necessary.

Reviewed by anders

  • ForwardingHeaders/q3paintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpaintdevice.h: Removed.
  • ForwardingHeaders/qpaintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpixmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge elementAtPoint:]):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLength): (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/css_valueimpl.h:
  • css/csshelper.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • css/cssstyleselector.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::image): (KCanvasFEImage::setImage):
  • kcanvas/KCanvasImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasImageQuartz::init):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::image):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::image):
  • khtml/misc/helper.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::~DocumentImpl): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach):
  • khtml/xml/DocumentImpl.h: (WebCore::DocumentImpl::printing): (WebCore::DocumentImpl::setPrinting):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::strokePainter):
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::image):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::notifyFinished):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenDepth):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement):
  • kwq/KWQComboBox.mm:
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQKPartsEvent.h:
  • kwq/KWQObject.h:
  • kwq/KWQPaintDevice.h: Removed.
  • kwq/KWQPaintDeviceMetrics.h: Removed.
  • kwq/KWQPaintDeviceMetrics.mm: Removed.
  • kwq/KWQPainter.h: (WebCore::QPainter::printing):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQPixmap.h: Removed.
  • kwq/KWQPixmap.mm: Removed.
  • kwq/KWQPrinter.h: (QPrinter::QPrinter):
  • kwq/KWQWidget.h:
  • loader/Cache.cpp: (khtml::Cache::init): (khtml::Cache::clear): (khtml::Cache::requestImage): (khtml::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::tiled_image): (WebCore::CachedImage::image): (WebCore::CachedImage::image_size): (WebCore::CachedImage::do_notify): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedImageCallback.cpp: (WebCore::CachedImageCallback::notifyUpdate): (WebCore::CachedImageCallback::notifyFinished): (WebCore::CachedImageCallback::handleError):
  • loader/CachedObject.h: (WebCore::CachedObject::):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::setImage):
  • loader/DocLoader.cpp: (khtml::DocLoader::setAutoloadImages): (khtml::DocLoader::setShowAnimations):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • page/Frame.cpp: (Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (selectCursor):
  • page/FrameView.h:
  • platform/Image.h: Added.
  • platform/mac/Image.mm: Added. (WebCore::Image::loadResource): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::imageRef): (WebCore::Image::resetAnimation): (WebCore::Image::setAnimationRect): (-[WebImageCallback initWithCallback:WebCore::]): (WebCore::Image::shouldUseThreadedDecoding): (WebCore::Image::receivedData): (WebCore::Image::mask): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::Image::resize): (WebCore::Image::operator=): (WebCore::Image::increaseUseCount): (WebCore::Image::decreaseUseCount): (WebCore::Image::stopAnimations): (WebCore::Image::flushRasterCache):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject):
  • rendering/RenderText.h:
  • rendering/font.cpp: (khtml::Font::update):
  • rendering/font.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (RenderFlow::paintLines):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::image): (WebCore::RenderImage::getImage):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::setImage): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
  • rendering/render_replaced.h:
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setFontFromControlSize):
2:20 AM Changeset in webkit [12413] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

run-webkit-test --leaks crashes (malloc logging runs out of memory)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6869

  • Scripts/run-webkit-tests: fix --leaks to not crash
1:39 AM Changeset in webkit [12412] by andersca
  • 2 edits in trunk

Somehow these ChangeLog entries weren't committed

1:35 AM Changeset in webkit [12411] by darin
  • 3 edits in trunk/LayoutTests
  • fast/forms/radio-button-no-change-event.html: Updated to add a second radio button.
  • fast/forms/radio-button-no-change-event-expected.txt: Updated.
1:29 AM Changeset in webkit [12410] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Revised test: fast/forms/radio-button-no-change-event.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked): Don't send a change event for a radio button getting unchecked (matches Gecko at least).
12:10 AM Changeset in webkit [12409] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

run-webkit-tests should produce a self-contained results directory
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6864

  • Scripts/run-webkit-tests: copy failing items to results dir.

Jan 26, 2006:

10:55 PM Changeset in webkit [12408] by eseidel
  • 4 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Leak fixes in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6588

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (teardownShadingWithStyle): delete image and context when through. (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): zero out cached mask (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): destroy cached mask image. (KRenderingPaintServerLinearGradientQuartz::setup): delete mask before making new (KRenderingPaintServerRadialGradientQuartz::setup): delete mask before making new
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer): forgot "static" keyword
  • ksvg2/svg/SVGPolyElementImpl.cpp: (SVGPolyElementImpl::notifyAttributeChange): use RefPtr
10:05 PM Changeset in webkit [12407] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
9:42 PM Changeset in webkit [12406] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Tim Omernick.


(This bug was fixed independently by Dave Harrison but I'm landing the test
case anyway.)

  • fast/lists/list-style-none-crash-expected.checksum: Added.
  • fast/lists/list-style-none-crash-expected.png: Added.
  • fast/lists/list-style-none-crash-expected.txt: Added.
  • fast/lists/list-style-none-crash.html: Added.
5:35 PM Changeset in webkit [12405] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Test case for <rdar://problem/4256504>
khtml::RenderBlock::skipWhitespace crashes upon interaction with
radio buttons

5:12 PM Changeset in webkit [12404] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4256504> khtml::RenderBlock::skipWhitespace
crashes upon interaction with radio buttons.

The old code held an assumption that positioned elements would
always have line boxes. This is not necessarily the case, so this
patch makes sure that the lines are dirtied appropriately.

3:56 PM Changeset in webkit [12403] by andersca
  • 1 edit
    2 adds in trunk

2006-01-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Test: fast/dom/HTMLImageElement/image-without-renderer-width.html

Reviewed and landed by Anders.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): Return the image's dimensions only if it isn't null, but even if it hasn't finished loading. (WebCore::HTMLImageElementImpl::height): Ditto.
3:32 PM Changeset in webkit [12402] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4422365>

  • WebView.subproj/WebHTMLView.m: (-[NSArray addSuperviewObservers]): In addition to registering for frame/bounds change notifications, call -_frameOrBoundsChanged. It will check the current size/scroll against the previous layout's size/scroll. We need to do this here to catch the case where the WebView is laid out at one size, removed from its window, resized, and inserted into another window. Our frame/bounds changed notifications will not be sent in that situation, since we only watch for changes while in the view hierarchy.

I have verified that this does not cause unnecessary layouts while running the PLT.

2:45 PM Changeset in webkit [12401] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt and Vicki.

Fix for broken layout tests.

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus):
2:00 PM Changeset in webkit [12400] by andersca
  • 10 edits
    3 adds
    2 deletes in trunk

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.


This makes DocumentType and DOMImplementation autogenerated.


  • JSCore.cpp: Added.


  • WebCore.xcodeproj/project.pbxproj: Add JSCore.cpp


  • bindings/scripts/CodeGeneratorJS.pm: Add attributes for controlling how null values should be converted to and from DOMString objects.


  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm: Remove the extended attributes hash on attribute objects and use the one on the signature.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction): For isSupported, just convert the version argument to an empty string if null is passed in. The reason for this change is that the autogenerated binding for DOMImplementation::hasFeature does the same thing. This also makes us behave like Mozilla and Opera.


(KJS::toDocumentType):
(KJS::getDOMNode):
Use JSDocumentType.


(KJS::getDOMDOMImplementation):
Use JSDOMImplementation.


  • khtml/ecma/kjs_dom.h: Remove DOMDOMImplementation and DOMDocumentType


  • khtml/xml/DOMImplementation.idl: Added.
  • khtml/xml/DocumentType.idl: Added.
1:40 PM Changeset in webkit [12399] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-26 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<text> elements with a scale on a parent <g> breaks nodeAtPoint
Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6843

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint):
12:32 PM Changeset in webkit [12398] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

There were three basic problems here, any one of which was enough
to cause the leak.


1) If the filter function for a NodeFilter, NodeIterator or TreeWalker
had that object in scope, it would cause a GC reference cycle. I fixed
this by making these JS functions get marked by the corresponding JS object,
as for XMLHttpRequest.


2) The TraversalImpl class that's a base class for NodeIteratorImpl and
TreeWalkerImpl did not have a virtual destructor, leading the Shared
template to call the base class destructor on deref.


3) ref/deref on the document were mismatched, I fixed all that sort of nonsense
by using RefPtr instead of manual ref/deref.


  • khtml/dom/dom2_traversal.h: (DOM::NodeFilterCondition::mark): Add no-op virtual mark method, JS subclass will do something useful here.
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::mark): Mark the DOM-level filter. (KJS::DOMNodeFilter::mark): ditto (KJS::DOMTreeWalker::mark): ditto (KJS::JSNodeFilterCondition::JSNodeFilterCondition): reformatted. (KJS::JSNodeFilterCondition::mark): Mark the filter function.
  • khtml/ecma/kjs_traversal.h:
  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeFilterImpl::NodeFilterImpl): diligently applied RefPtr (DOM::TraversalImpl::TraversalImpl): ditto (DOM::TraversalImpl::~TraversalImpl): ditto (DOM::NodeIteratorImpl::NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::~NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::setReferenceNode): ditto (DOM::TreeWalkerImpl::TreeWalkerImpl): ditto (DOM::TreeWalkerImpl::setCurrentNode): ditto
  • khtml/xml/dom2_traversalimpl.h: (DOM::NodeFilterImpl::mark): call mark() on the codition (DOM::TraversalImpl::root): Use .get() (DOM::TraversalImpl::filter): ditto (DOM::NodeIteratorImpl::referenceNode): ditto (DOM::NodeIteratorImpl::document): ditto (DOM::TreeWalkerImpl::currentNode): ditto
12:18 PM Changeset in webkit [12397] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQPageState.mm: (-[KWQPageState clear]): Garbage collect after deleting a bunch of stuff that holds onto JS objects. This should avoid false positive leaks and is good in any case since page state deallocation is already deferred.
10:46 AM Changeset in webkit [12396] by adele
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fix for <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus): Nil check for renderer.
8:59 AM Changeset in webkit [12395] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test case for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6835

  • editing/deleting/delete-listitem-001-expected.checksum: Added.
  • editing/deleting/delete-listitem-001-expected.png: Added.
  • editing/deleting/delete-listitem-001-expected.txt: Added.
  • editing/deleting/delete-listitem-001.html: Added.
8:58 AM Changeset in webkit [12394] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Test added:
editing/deleting/delete-listitem-001.html


  • rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::resetMarkerValue): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
4:06 AM Changeset in webkit [12393] by ap
  • 3 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, landed by ap.


  • manual-tests/bugzilla-6388.html: Added.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::computeRepaintRects): Cache the object's absolute position before update. (WebCore::RenderLayer::updateLayerPositions): Use the cached position to determine if the object moved. If it did, do a full repaint.
  • rendering/render_layer.h:
3:32 AM Changeset in webkit [12392] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
3:11 AM Changeset in webkit [12391] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
2:57 AM Changeset in webkit [12390] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, committed by ap.


  • manual-tests/bugzilla-6278.html: Added.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): If during layout a cell changes from not needing layout to needing layout, call repaintObjectsBeforeLayout on it.
2:53 AM Changeset in webkit [12389] by eseidel
  • 9 edits
    4 adds in trunk

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

SVG shows up blank in WebKit+SVG
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6620

  • css/svg.css: default to width/height 100% for <svg>
1:53 AM Changeset in webkit [12388] by andersca
  • 1 edit in trunk/WebCore/khtml/xml/WheelEvent.idl

Force this to be re-generated

1:43 AM Changeset in webkit [12387] by andersca
  • 9 edits
    1 add in trunk/WebCore

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6805
Support constants in IDL files

  • bindings/scripts/CodeGeneratorJS.pm: If an interface has constants, generate a constructor object and add the constants as properties. Also add a getConstructor method to the interface object.


  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/generate-bindings.pl: Add a --force-generation flag to force regeneration of files even though nothing has changed.


  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h: Remove MutationEventConstructor and DOMMutationEvent, those are autogenerated now.


  • bindings/js/JSEvents.cpp: Include JSMutationEvent.cpp
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/ecma/kjs_window.h: (KJS::Window::): Add MutationEvent property.


  • khtml/xml/MutationEvent.idl: Added.
1:32 AM Changeset in webkit [12386] by eseidel
  • 34 edits
    4 adds in trunk

2006-01-25 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Percentage values for width, height are not rendered correctly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5331

Create items for even empty paths to prevent an empty render tree.
Calculate the viewport element on the fly rather than caching it,
unless there is no context from which to calculate it. Call
notifyAttributeChange() on layout to fix usage of viewport
percentages for lengths. Remove portion of code which appears to
do nothing but worsen the situation.

  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer):
1:23 AM Changeset in webkit [12385] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Disable <animateTransform> to stop layout test crashes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6780

  • ksvg2/misc/KSVGTimeScheduler.cpp: hack out animateTransform.
12:37 AM Changeset in webkit [12384] by eseidel
  • 16 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Deploy RefPtr throughout more of WebCore
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

  • bridge/mac/MacFrame.mm: (MacFrame::shouldClose): no need to call .get()
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::remove):
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::~HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::createLinkDecl): (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::~HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading): (WebCore::HTMLStyleElementImpl::HTMLStyleElementImpl): (WebCore::HTMLStyleElementImpl::childrenChanged): (WebCore::HTMLStyleElementImpl::isLoading):
  • khtml/html/html_headimpl.h: (DOM::HTMLLinkElementImpl::sheet): (DOM::HTMLStyleElementImpl::sheet):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): (WebCore::HTMLTableSectionElementImpl::insertRow): (WebCore::HTMLTableSectionElementImpl::deleteRow): (WebCore::HTMLTableRowElementImpl::deleteCell):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent): (WebCore::NodeImpl::dispatchMouseEvent): (WebCore::NodeImpl::dispatchKeyEvent): (WebCore::NodeImpl::createRendererIfNeeded):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeImpl::clone): (WebCore::StyledElementImpl::StyledElementImpl): (WebCore::StyledElementImpl::createInlineStyleDecl): (WebCore::StyledElementImpl::destroyInlineStyleDecl): (WebCore::StyledElementImpl::getInlineStyleDecl):
  • khtml/xml/dom_elementimpl.h: (DOM::MappedAttributeImpl::MappedAttributeImpl): (DOM::MappedAttributeImpl::style): (DOM::MappedAttributeImpl::decl): (DOM::MappedAttributeImpl::setDecl): (DOM::StyledElementImpl::inlineStyleDecl):
  • khtml/xml/dom_position.cpp: (DOM::Position::Position): (DOM::Position::clear):
  • khtml/xml/dom_position.h: (DOM::Position::node):

Jan 25, 2006:

11:10 PM Changeset in webkit [12383] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.


  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::~KJSProxyImpl): Garbage collect after destroying the script interpreter.
  • page/Frame.cpp: (Frame::clear): Add a boolean parameter to indicate whether properties of the window object should also be cleared (defaults to true). (Frame::~Frame): Call clear(false) instead of clear()
  • page/Frame.h:
8:44 PM Changeset in webkit [12382] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImplCounter::~NodeImplCounter): Uncomment node counter now tit won't give a lot of false positives.
8:40 PM Changeset in webkit [12381] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.



This fixes 175 reproducible node leaks in the editing layout tests.


  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::detach): Clear hover, focus and active nodes. It doesn't make sense to have these without a view anyway, and if any of them is the document it can cause a leak of the whole DOM.
8:36 PM Changeset in webkit [12380] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6816
Crash in dispatchMouseEvent - Missing nil check

  • page/FrameView.cpp: (FrameView::dispatchMouseEvent):
6:39 PM Changeset in webkit [12379] by justing
  • 164 edits
    8 adds in trunk/LayoutTests

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
TinyMCE: Undo operation crashes Safari
<rdar://problem/4343068>
Some shouldChangeSelection calls are nonsensical


Selections are blown away if their endpoints are removed from the document.
This changed the selections that editing delegates see during deletion/replacement.

  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-3608462-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3800834-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-3865854-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-br-008-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-001-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-003-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-005-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-009-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-line-013-expected.txt:
  • editing/deleting/delete-line-014-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-line-016-expected.txt:
  • editing/deleting/delete-line-017-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • editing/input/text-input-controller-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-3851164-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-div-001-expected.txt:
  • editing/inserting/insert-div-002-expected.txt:
  • editing/inserting/insert-div-003-expected.txt:
  • editing/inserting/insert-div-005-expected.txt:
  • editing/inserting/insert-div-007-expected.txt:
  • editing/inserting/insert-div-009-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/inserting/insert-div-020-expected.txt:
  • editing/inserting/insert-div-023-expected.txt:
  • editing/inserting/insert-div-024-expected.txt:
  • editing/inserting/insert-div-025-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/inserting/return-key-with-selection-003-expected.txt:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-018-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/selection/node-removal-1-expected.checksum: Added.
  • editing/selection/node-removal-1-expected.png: Added.
  • editing/selection/node-removal-1-expected.txt: Added.
  • editing/selection/node-removal-1.html: Added.
  • editing/selection/node-removal-2-expected.checksum: Added.
  • editing/selection/node-removal-2-expected.png: Added.
  • editing/selection/node-removal-2-expected.txt: Added.
  • editing/selection/node-removal-2.html: Added.
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-after-paragraph-expected.txt:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/style-3681552-fix-001-expected.txt:
  • editing/style/style-3681552-fix-002-expected.txt:
  • editing/style/style-3690704-fix-expected.txt:
  • editing/style/style-3998892-fix-expected.txt:
  • editing/style/style-boundary-001-expected.txt:
  • editing/style/style-boundary-003-expected.txt:
  • editing/style/style-boundary-004-expected.txt:
  • editing/style/typing-style-001-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/list-delete-003-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/attributed-strings-expected.txt:
6:36 PM Changeset in webkit [12378] by justing
  • 5 edits in trunk/WebCore

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
TinyMCE: Undo operation crashes Safari
<rdar://problem/4343068>
Some shouldChangeSelection calls are nonsensical

Notify the SelectionController of node removals,
and blow away the selection when end points are removed.

Tests added:

  • editing/selection/remove-node-1.html
  • editing/selection/remove-node-2.html


  • khtml/editing/SelectionController.cpp: (WebCore::MutationListener::handleEvent): (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::~SelectionController): (WebCore::SelectionController::operator=): (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::clear): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
  • khtml/editing/SelectionController.h: (WebCore::MutationListener::MutationListener): (WebCore::MutationListener::selectionController): (WebCore::MutationListener::setSelectionController):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
  • rendering/render_flow.cpp: (RenderFlow::destroy):
6:30 PM Changeset in webkit [12377] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/MacFrame.mm

Build fix for i386.

6:09 PM Changeset in webkit [12376] by adele
  • 10 edits in trunk

LayoutTests:

Updating test results for aqua text fields.

  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:
  • fast/forms/input-appearance-focus-expected.txt:

WebCore:

Reviewed by Hyatt.

This change lets us display an aqua appearance for the new text fields.

Updated results for:

  • fast/forms/input-appearance-focus.html
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): remove styling of the div, since RenderTheme handles that now.
  • rendering/render_theme.cpp: (khtml::RenderTheme::adjustStyle): call adjustTextFieldStyle. (khtml::RenderTheme::paint): call paintTextField. (khtml::RenderTheme::adjustTextFieldStyle): added FIXME to turn off appearance later.
  • rendering/render_theme.h: added adjustTextFieldStyle, paintTextField
  • rendering/render_theme_mac.h: added paintTextField, setTextFieldState, and NSTextFieldCell.
  • rendering/render_theme_mac.mm: (khtml::): Added static textFieldMargins. (khtml::RenderThemeMac::adjustRepaintRect): update text field state and size. (khtml::RenderThemeMac::paintTextField): Added. Paints the NSTextFieldCell (khtml::RenderThemeMac::setTextFieldCellState): Initialize NSTextFieldCell, and update enabled state.
5:56 PM Changeset in webkit [12375] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Land project change so Brush is in the Win32 project.

5:53 PM Changeset in webkit [12374] by thatcher
  • 2 edits in branches/Safari-Leo-branch

Versioning.

5:52 PM Changeset in webkit [12373] by hyatt
  • 14 edits
    1 move
    3 deletes in trunk/WebCore

Rename QBrush to Brush and move it to platform/. Remove unused QPoint/Size/RectF forwarding
headers.

  • ForwardingHeaders/QPointF: Removed.
  • ForwardingHeaders/QRectF: Removed.
  • ForwardingHeaders/QSizeF: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kwq/KWQBrush.h: Removed.
  • kwq/KWQNamespace.h:
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::setBrush): (QPainter::brush): (QPainter::drawRect): (QPainter::drawEllipse): (QPainter::drawConvexPolygon): (QPainter::fillRect):
  • kwq/KWQPalette.h: (QColorGroup::brush):
  • platform/Brush.h: Added. (WebCore::Brush::): (WebCore::Brush::Brush::Brush): (WebCore::Brush::operator==): (WebCore::Brush::operator!=):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/render_box.cpp: (WebCore::RenderBox::outlineBox):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
5:50 PM Changeset in webkit [12372] by thatcher
  • 2 edits in branches/Safari-Leo-branch

Versioning.

5:14 PM Changeset in webkit [12371] by harrison
  • 9 edits in trunk/LayoutTests

Reviewed by Justin.


Updated pixel tests for my recent checkin.

  • editing/pasteboard/paste-list-001-expected.png:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690719-expected.png:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.png:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.png:
5:13 PM Changeset in webkit [12370] by vicki
  • 3 edits in trunk/WebKit

Reviewed by Beth Dakin.

  • fix <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)


  • WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): grab the redirect flag of the current load before calling _loadURL, which clears this flag, (-[WebFrame _transitionToCommitted:]): remove misleading comment
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setURL:]): release resources in the page cache when setting the URL on a WebHistoryItem
4:54 PM Changeset in webkit [12369] by andersca
  • 2 edits in trunk/WebCore

2006-01-25 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6807
generate-bindings.pl should not use find command


  • bindings/scripts/generate-bindings.pl: Use opendir and readdir instead of find.
4:21 PM Changeset in webkit [12368] by hyatt
  • 4 edits in trunk/WebCore

Fix Win32 build bustage. Make the autogeneration from idl work on windows.

3:44 PM Changeset in webkit [12367] by hyatt
  • 14 edits
    2 moves
    1 delete in trunk/WebCore

Rename QPen to Pen and move it to the platform/ directory.

  • ForwardingHeaders/qpen.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQNamespace.h: (Qt::):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::pen): (QPainter::setPen): (QPainter::drawRect): (QPainter::drawLine): (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::drawConvexPolygon):
  • kwq/KWQPen.cpp: Removed.
  • kwq/KWQPen.h: Removed.
  • platform/Pen.cpp: Added. (WebCore::Pen::Pen): (WebCore::Pen::color): (WebCore::Pen::width): (WebCore::Pen::style): (WebCore::Pen::setColor): (WebCore::Pen::setWidth): (WebCore::Pen::setStyle): (WebCore::Pen::operator==): (WebCore::Pen::operator!=):
  • platform/Pen.h: Added. (WebCore::Pen::):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox):
  • rendering/RenderText.cpp:
  • rendering/render_box.cpp: (WebCore::RenderBox::outlineBox):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp:
  • rendering/render_line.cpp:
  • rendering/render_list.cpp:
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder):
3:04 PM Changeset in webkit [12366] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Merge fix cast fix from KDE (reinterpret_cast can't change size)

2:53 PM Changeset in webkit [12365] by thatcher
  • 2 edits in tags/Safari-521.6.2/WebCore

Build fix.

2:53 PM Changeset in webkit [12364] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebKit/WebCoreSupport.subproj/WebFileButton.m

Build fix.

2:16 PM Changeset in webkit [12363] by thatcher
  • 5 edits in trunk

WebCore:

Move off of -[NSFont widthOfString:] since it is now deprecated.
Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

  • bridge/mac/MacFrame.mm: (MacFrame::attributedString):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView sizeWithColumns:rows:]):

WebKit:

Move off of -[NSFont widthOfString:] since it is now deprecated.
Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileChooserButton bestVisualFrameSizeForCharacterCount:]):
2:05 PM Changeset in webkit [12362] by tomernic
  • 3 edits in trunk/WebCore

Reviewed by Dave Harrison.

<rdar://problem/4339024>
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or embed
(and plugin view)"


  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl): Assert that appletInstance has been deleted by detach(). (WebCore::HTMLAppletElementImpl::detach): Delete appletInstance, because it references the widget owned by the renderer we're about to destroy. It is assumed elsewhere (getRuntimeObject(), kjs_dom.cpp) that the instance is owned by the applet element. Therefore, it is required that the element destroy the instance in its tear-down phase. (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl): Assert that embedInstance has been deleted by detach(). (WebCore::HTMLEmbedElementImpl::detach): Delete embedInstance, same reason. This is the one that fixes <rdar://problem/4339024>. (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl): Assert that objectInstance has been deleted by detach(). (WebCore::HTMLObjectElementImpl::detach): Delete embedInstance, same reason.
  • khtml/html/html_objectimpl.h: Declared HTMLAppletElementImpl::detach() and HTMLEmbedElementImpl::detach().
2:04 PM Changeset in webkit [12361] by andersca
  • 1 add in trunk/WebCore/bindings/js/JSEvents.cpp

Forgot to add this

1:57 PM Changeset in webkit [12360] by andersca
  • 4 edits
    7 adds in trunk/WebCore

2006-01-24 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


This is a first cut at an autogeneration framework based on
what KDOM uses, but with some changes to be able to move
gradually to using autogenerated files. Currently only Javascript
is supported, but ObjC support could be added by writing a new code
generator package.


  • WebCore.xcodeproj/project.pbxproj: Call generate-bindings.pl
  • bindings/js/JSEvents.cpp: Added. New file which #includes all generated files in the event module (Just JSWheelEvent.cpp for now)


  • khtml/xml/WheelEvent.idl: Added.


  • bindings/scripts: Added.
  • bindings/scripts/CodeGenerator.pm: Added.
  • bindings/scripts/CodeGeneratorJS.pm: Added.
  • bindings/scripts/IDLParser.pm: Added.
  • bindings/scripts/IDLStructure.pm: Added.
  • bindings/scripts/generate-bindings.pl: Added.


  • khtml/ecma/kjs_events.cpp: Remove DOMWheelEvent class.


(KJS::getDOMEvent):
Use JSWheelEvent here.


  • khtml/ecma/kjs_events.h: Remove DOMWheelEvent class.
1:11 PM Changeset in webkit [12359] by harrison
  • 30 edits in trunk/LayoutTests

Updated for fixes of:


<rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
<rdar://problem/3907647> Enhance list editing: return inserts <li></li>
<rdar://problem/4060158> deleting selection within table deletes more than intended
<rdar://problem/4061232> Deleting a list can delete unselected content
<rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
<rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
<rdar://problem/4259845> Table editing in design mode is broken
<rdar://problem/4287667> Insertion point goes before table instead of inside first cell
<rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
<rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
<rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
<rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
<rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

  • editing/deleting/delete-4083333-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-001.html:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-2.html:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/move-by-line-001-expected.txt:
  • editing/selection/move-by-line-001.html:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-after.html:
  • editing/unsupported-content/list-type-before-expected.txt:
  • editing/unsupported-content/list-type-before.html:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-001.html:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-002.html:
  • editing/unsupported-content/table-type-after-expected.txt:
  • editing/unsupported-content/table-type-after.html:
  • editing/unsupported-content/table-type-before-expected.txt:
  • editing/unsupported-content/table-type-before.html:
1:05 PM Changeset in webkit [12358] by harrison
  • 27 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
<rdar://problem/3907647> Enhance list editing: return inserts <li></li>
<rdar://problem/4060158> deleting selection within table deletes more than intended
<rdar://problem/4061232> Deleting a list can delete unselected content
<rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
<rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
<rdar://problem/4259845> Table editing in design mode is broken
<rdar://problem/4287667> Insertion point goes before table instead of inside first cell
<rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
<rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
<rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
<rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
<rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

...also added showTree() static functions because switch to gcc 4.0 makes calling instance methods unreliable

  • numerous small changes to handle empty list items
  • fix numeric list marker updating when adding/deleting list items
  • start to decompose "special element" handling, replacing it with appropriate handling of the different kinds of special elements in various situations, rather than giving a blanket treatment. I will do more of this in subsequent checkins.
  • numerous small editing/selection changes to handle VisiblePosition at table offset childNodeCount()
  • simplify and fix equivalentRangeCompliantPosition, rename it to rangeCompliantEquivalent and make it static
  • some minor reformatting to current standards
  • the comments in the list below are for changes not covered by the above comments


  • khtml/editing/Selection.cpp: (WebCore::Selection::toRange): (WebCore::Selection::validate):
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingLeftBackward):
  • character selection backward from after table selects the table (WebCore::showTree):
  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::removeFullySelectedNode):
  • make sure empty cell has some height (WebCore::CompositeEditCommand::positionOutsideTabSpan):
  • check for !isTabSpanTextNode() to make calling this function easier (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • khtml/editing/delete_selection_command.cpp: (WebCore::positionBeforePossibleContainingSpecialElement): (WebCore::positionAfterPossibleContainingSpecialElement): (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • new. more consistent handling of special element boundaries. (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • handle childless block (e.g. empty table cell)
  • allow merging across list items (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
  • use new isEmpty() method for renderers, to handle empty list items
  • khtml/editing/delete_selection_command.h:
  • khtml/editing/htmlediting.cpp: (WebCore::isAtomicNode): (WebCore::editingIgnoresContent):
  • new. smarter check than isReplaced() (WebCore::rangeCompliantEquivalent): (WebCore::maxDeepOffset): (WebCore::isFirstVisiblePositionInSpecialElement): (WebCore::positionBeforeContainingSpecialElement): (WebCore::isLastVisiblePositionInSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionOutsideContainingSpecialElement): (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::isListElement): (WebCore::isTableElement): (WebCore::isFirstVisiblePositionAfterTableElement): (WebCore::positionBeforePrecedingTableElement): (WebCore::positionAvoidingSpecialElementBoundary):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input):
  • khtml/editing/replace_selection_command.cpp: (WebCore::isMailPasteAsQuotationNode): (WebCore::ReplacementFragment::countRenderedBlocks): (WebCore::ReplaceSelectionCommand::doApply):
  • allow for fact that fragments have no VisiblePositions
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::isCandidate): (khtml::showTree): (khtml::makeRange): (khtml::setStart): (khtml::setEnd):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfLine):
  • allow for fact that renderers for list markers and other generated content have no corresponding NodeImpl. (khtml::endOfLine):
  • ditto (khtml::nextLinePosition): (khtml::startOfParagraph): (khtml::endOfParagraph):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): (WebCore::ContainerNodeImpl::childNode):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::childNode): (WebCore::NodeImpl::traversePreviousNode): (WebCore::NodeImpl::nextEditable): (WebCore::showTree):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::inRenderedContent): (DOM::showTree):
  • khtml/xml/dom_position.h:
  • rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
  • rendering/render_list.cpp: (RenderListItem::calcListValue): (RenderListItem::isEmpty): (getParentOfFirstLineBox): (RenderListItem::resetMarkerValue): (RenderListItem::updateMarkerLocation):
  • rendering/render_list.h: (khtml::RenderListMarker::isListMarker):
  • rendering/render_object.cpp: (WebCore::RenderObject::nextRenderer): (WebCore::RenderObject::previousRenderer): (WebCore::showTree):
  • rendering/render_object.h: (WebCore::RenderObject::getBaselineOfLastLineBox): (WebCore::RenderObject::isEmpty):
12:14 PM Changeset in webkit [12357] by hyatt
  • 3 edits in trunk/WebCore

Make Color compile on Win32.

11:58 AM Changeset in webkit [12356] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Make Win32 build again.

11:38 AM Changeset in webkit [12355] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebCore/kwq/KWQLineEdit.mm

Build fix.

11:37 AM Changeset in webkit [12354] by thatcher
  • 2 edits in trunk/WebCore

Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
We need to use -[NSLayoutManager defaultLineHeightForFont:] instead.

  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
11:33 AM Changeset in webkit [12353] by darin
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Quick update for Dave, who's working on getting this compiling again.

11:12 AM Changeset in webkit [12352] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/internal.cpp

Fix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.

11:09 AM Changeset in webkit [12351] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebKit/WebCoreSupport.subproj/WebFrameBridge.h

Build fix.

11:07 AM Changeset in webkit [12350] by thatcher
  • 1 copy in tags/Safari-521.6.2

New Tag.

10:20 AM Changeset in webkit [12349] by darin
  • 2 edits
    1 delete in trunk/JavaScriptCore
  • removed an unused source file
  • kjs/pointer_hash.h: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to pointer_hash.h.
4:36 AM Changeset in webkit [12348] by ap
  • 7 edits in trunk/LayoutTests

Reviewed by Darin.

Corrected a test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6385.

  • fast/frames/frame-element-name.html: Fix a reference to the left frame.
  • fast/frames/frame-element-name-expected.txt: Updated results.
  • fast/frames/frame-element-name-expected.png: Updated results.
  • fast/frames/frame-element-name-expected.checksum: Updated results.
  • fast/frames/resources/frame-element-name-left.html: Use escape() on the name.
  • fast/frames/resources/frame-element-name-right.html: Ditto.

Jan 24, 2006:

11:42 PM Changeset in webkit [12347] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/forms/radio-button-no-change-event.html: Added.
  • fast/forms/radio-button-no-change-event-expected.txt: Added.
11:41 PM Changeset in webkit [12346] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Test: fast/forms/radio-button-no-change-event.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked): One of many possible fixes: Don't send the event if the element is not yet in a document (as in when parsing the initial attributes).
11:35 PM Changeset in webkit [12345] by adele
  • 13 edits
    4 adds in trunk

LayoutTests:

Test for focus and blur for new text fields.

  • fast/forms/input-appearance-focus.html: Added.
  • fast/forms/input-appearance-focus-expected.txt: Added.
  • fast/forms/input-appearance-focus-expected.png: Added.
  • fast/forms/input-appearance-focus-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

This change will allow the new text field elements to get focus, and to respond to the focus and blur events.

Added: fast/forms/input-appearance-focus.html

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isFocusable): Removed recently added code that allowed editable elements with no parent to be focusable. We don't need to do this now that we try to focus the input element, instead of the inner div.
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Added case to for text fields.
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus): Added. Selects contents of text field. (WebCore::HTMLInputElementImpl::setSelectionStart): Added break; in switch statement. (WebCore::HTMLInputElementImpl::setSelectionEnd): ditto. (WebCore::HTMLInputElementImpl::select): ditto. (WebCore::HTMLInputElementImpl::setSelectionRange): ditto.
  • khtml/html/HTMLInputElementImpl.h: Added focus()
  • khtml/xml/dom_elementimpl.h: Made focus() virtual.
  • page/Frame.cpp: (Frame::setFocusNodeIfNeeded): Walk up the Render Tree instead of the DOM tree when trying to find a node to focus. This will let us choose the input node instead of one of the nodes in the shadow tree.
  • page/FrameView.cpp: (FrameView::dispatchMouseEvent): ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Corrected misspelling.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::select): Implemented. Select contents of inner div.
  • rendering/RenderTextField.h: (WebCore::RenderTextField::renderName): Changed order. (WebCore::RenderTextField::removeLeftoverAnonymousBoxes): ditto.
10:08 PM Changeset in webkit [12344] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Eric.

  • fast/dom/replace-first-child.html: Added.
  • fast/dom/replace-first-child-expected.txt: Added
10:07 PM Changeset in webkit [12343] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): Change one place that hands off ownership of as PassRefPtr that causes us to almost always return 0. Fix test that would screw up when both "prev" and "refChild->previousSibling()" were 0. (WebCore::ContainerNodeImpl::appendChild): Changed a nearly-identical place handing off ownership as above.
8:01 PM Changeset in webkit [12342] by mjs
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.


  • fast/parser/remove-block-in-residual-style-expected.checksum: Added.
  • fast/parser/remove-block-in-residual-style-expected.png: Added.
  • fast/parser/remove-block-in-residual-style-expected.txt: Added.

WebCore:

Reviewed by Dave Hyatt.


  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the block has been removed from the document, then do not remove it from its parent or add it to its new location. This prevents the crash and matches Mozilla.
7:35 PM Changeset in webkit [12341] by darin
  • 17 edits
    4 adds
    3 deletes in trunk/WebCore

Reviewed by John Sullivan.

  • ForwardingHeaders/qdatetime.h: Removed.
  • kwq/KWQDateTime.cpp: Removed.
  • kwq/KWQDateTime.h: Removed.
  • platform/SystemTime.h: Added.
  • platform/mac/SystemTime.cpp: (WebCore::currentTime): Added.
  • platform/win: Added.
  • platform/win/SystemTime.cpp: (WebCore::currentTime): Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added new files, removed old.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/css_base.h: Removed include of <qdatetime.h>.
  • css/cssstyleselector.cpp: Ditto.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: Convert tabs to spaces. (WebCore::HTMLTokenizer::continueProcessing): Change parameter from QTime to double. Use currentTime() instead of QTime::elapsed(). (WebCore::HTMLTokenizer::write): Use currentTime() instead of QTime::elapsed().
  • config.h: Added HAVE_FUNC_USLEEP for now, not sure this is really a good way to handle this.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::setActive): Use currentTime() instead of QTime::elapsed(). Use HAVE_FUNC_USLEEP for the if.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Use currentTime() instead of QTime::elapsed(). (WebCore::DocumentImpl::implicitClose): Ditto. (WebCore::DocumentImpl::minimumLayoutDelay): Ditto. (WebCore::DocumentImpl::elapsedTime): Ditto.
  • khtml/xml/dom2_eventsimpl.cpp: (WebCore::EventImpl::EventImpl): Use currentTime() instead of local function called currentTimeStamp().
  • khtml/xml/xml_tokenizer.h: Removed declaration of class QTime.
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::TimeScheduler::TimeScheduler): Use currentTime instead of QTime::elapsed. (KSVG::TimeScheduler::startAnimations): Ditto. (KSVG::TimeScheduler::toggleAnimations): Ditto. (KSVG::TimeScheduler::elapsed): Ditto.
  • page/Frame.cpp: (Frame::clear): Removed unused m_parsetime.
  • page/FramePrivate.h: Ditto.
6:58 PM Changeset in webkit [12340] by hyatt
  • 83 edits
    3 moves
    1 add
    1 delete in trunk/WebCore

Fix for bug 6781, convert QColor to Color (and QRgb to RGBA32). r=maciej.

  • ForwardingHeaders/qcolor.h: Removed.
  • WebCore+SVG/KDOMSettings.h:
  • WebCore+SVG/RGBColorImpl.cpp: (RGBColorImpl::RGBColorImpl): (RGBColorImpl::red): (RGBColorImpl::green): (RGBColorImpl::blue):
  • WebCore+SVG/RGBColorImpl.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor _initWithRGB:]): (+[DOMRGBColor _RGBColorWithRGB:]): (-[DOMRGBColor alpha]): (-[DOMRGBColor _color]):
  • bridge/mac/MacFrame.mm: (MacFrame::attributedString): (MacFrame::fontAttributesForSelectionStart): (MacFrame::bodyBackgroundColor): (convertAttributesToUnderlines):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (WebCore::CSSPrimitiveValueImpl::cssText):
  • css/csshelper.h:
  • css/cssparser.cpp: (CSSParser::parseColor): (CSSParser::parseColorFromValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::): (WebCore::colorForCSSValue): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEDiffuseLighting::lightingColor): (KCanvasFEDiffuseLighting::setLightingColor): (KCanvasFEFlood::floodColor): (KCanvasFEFlood::setFloodColor): (KCanvasFESpecularLighting::lightingColor): (KCanvasFESpecularLighting::setLightingColor):
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KCSortedGradientStopList::addStop):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (KRenderingPaintServerSolid::color): (KRenderingPaintServerSolid::setColor):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciColor):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (setupShadingWithStyle):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::setup):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::colorRefFromValue): (KJS::colorFromValue): (KJS::Context2D::putValueProperty): (KJS::GradientFunction::callAsFunction):
  • khtml/ecma/kjs_html.h:
  • khtml/editing/apply_style_command.cpp: (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/misc/helper.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::resetLinkColor): (WebCore::DocumentImpl::resetVisitedLinkColor):
  • khtml/xml/DocumentImpl.h: (WebCore::DocumentImpl::setTextColor): (WebCore::DocumentImpl::textColor): (WebCore::DocumentImpl::linkColor): (WebCore::DocumentImpl::visitedLinkColor): (WebCore::DocumentImpl::activeLinkColor): (WebCore::DocumentImpl::setLinkColor): (WebCore::DocumentImpl::setVisitedLinkColor): (WebCore::DocumentImpl::setActiveLinkColor):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent): (SVGAnimateColorElementImpl::clampColor): (SVGAnimateColorElementImpl::color): (SVGAnimateColorElementImpl::initialColor):
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGColorImpl.cpp: (SVGColorImpl::setRGBColor): (SVGColorImpl::color):
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQBrush.h: (QBrush::QBrush::QBrush): (QBrush::color): (QBrush::setColor):
  • kwq/KWQColor.h: Removed.
  • kwq/KWQColor.mm: Removed.
  • kwq/KWQColorData.gperf: Removed.
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKConfigBase.mm: (KConfig::readColorEntry):
  • kwq/KWQLineEdit.mm: (QLineEdit::setPalette):
  • kwq/KWQNamespace.h: (Qt::):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::setPen): (QPainter::setBrush): (QPainter::drawText): (QPainter::drawHighlightForText): (QPainter::selectedTextBackgroundColor): (_fillRectXX): (QPainter::setShadow): (QPainter::initFocusRing):
  • kwq/KWQPalette.h: (QColorGroup::QColorGroup): (QColorGroup::color): (QColorGroup::setColor): (QColorGroup::background): (QColorGroup::foreground): (QColorGroup::base): (QPalette::QPalette): (QPalette::background): (QPalette::foreground):
  • kwq/KWQPen.cpp: (QPen::QPen): (QPen::color): (QPen::setColor):
  • kwq/KWQPen.h:
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
  • kwq/KWQTextEdit.mm: (QTextEdit::setPalette):
  • loader/CachedImage.cpp: (WebCore::CachedImage::tiled_pixmap):
  • loader/CachedImage.h:
  • page/Frame.cpp: (Frame::paint):
  • page/Frame.h: (MarkedTextUnderline::MarkedTextUnderline):
  • platform/Color.cpp: Added. (WebCore::makeRGB): (WebCore::makeRGBA): (WebCore::parseHexColor): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::hsv): (WebCore::Color::setHsv): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::Color::getRgbaF):
  • platform/Color.h: Added. (WebCore::Color::Color): (WebCore::Color::rgb): (WebCore::Color::setRgb): (WebCore::operator==): (WebCore::operator!=):
  • platform/ColorData.gperf: Added.
  • rendering/InlineTextBox.cpp: (khtml::simpleDifferenceBetweenColors): (khtml::correctedTextColor): (khtml::InlineTextBox::paint): (khtml::InlineTextBox::paintSelection): (khtml::InlineTextBox::paintMarkedTextBackground): (khtml::InlineTextBox::paintDecoration):
  • rendering/RenderTable.h: (WebCore::RenderTable::bgColor):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/font.cpp: (khtml::Font::drawHighlightForText): (khtml::Font::drawText):
  • rendering/font.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_flow.cpp: (RenderFlow::paintFocusRing): (RenderFlow::paintOutlineForLine):
  • rendering/render_form.cpp: (RenderFieldset::paintBorderMinusLegend):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor): (WebCore::RenderObject::getTextDecorationColors):
  • rendering/render_object.h: (WebCore::RenderObject::paintBackgroundExtended):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h:
  • rendering/render_style.h: (khtml::BorderValue::isTransparent): (khtml::CollapsedBorderValue::color): (khtml::RenderStyle::hasBackground): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineColor): (khtml::RenderStyle::color): (khtml::RenderStyle::backgroundColor): (khtml::RenderStyle::setBackgroundColor): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineColor): (khtml::RenderStyle::setColor): (khtml::RenderStyle::initialColor):
  • rendering/render_theme.cpp: (khtml::RenderTheme::isControlStyled):
  • rendering/render_theme.h:
3:27 PM Changeset in webkit [12339] by darin
  • 5 edits in trunk/WebCore

Reviewed by John and Anders.

  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Clean up a bit, using PassRefPtr where appropriate. (KJS::JSXMLHttpRequest::mark): Remove get calls now that getter functions don't return PassRefPtr. (KJS::JSXMLHttpRequest::JSXMLHttpRequest): Put the object into the DOM objects map. (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): Remove the object from the DOM objects map. Also clear out both listeners so the implementation object isn't left with dangling pointers (since we won't be around to mark those objects any more). (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Tightened up the code a bit.
  • xml/xmlhttprequest.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Change to return just a plain old pointer. Remove the unnecessary typeIsXML boolean. (WebCore::XMLHttpRequest::onReadyStateChangeListener): Change to return just a plain old pointer. Update for name changes. (WebCore::XMLHttpRequest::setOnReadyStateChangeListener): Ditto. (WebCore::XMLHttpRequest::onLoadListener): Ditto. (WebCore::XMLHttpRequest::setOnLoadListener): Ditto. (WebCore::XMLHttpRequest::send): Protect the DOM wrapper if any as well as ourselves while the load is in progress. (WebCore::XMLHttpRequest::abort): Unprotect to balance out the above. (WebCore::XMLHttpRequest::slotFinished): Ditto.
  • khtml/ecma/JSXMLHttpRequest.h: Just formatting changes.
3:23 PM Changeset in webkit [12338] by darin
  • 3 edits in trunk/WebCore

Reviewed by Justin.

  • khtml/xml/ContainerNodeImpl.h: Remove some internals that don't need to be member functions.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): Improved algorithm to keep refs to more things so that we don't end up with a dangling pointer (fixes the crash) and so that we do not crash if someone modifies the tree inside a DOM mutation event handler (theoretical only at this point, needs test cases). (WebCore::ContainerNodeImpl::replaceChild): Ditto. (WebCore::willRemoveChild): Changed from member function to free function. (WebCore::ContainerNodeImpl::removeChild): Fix potential problem if the mutation event handler moves the node into a different parent. (WebCore::ContainerNodeImpl::appendChild): Made changes like those in insertBefore above. (WebCore::dispatchChildInsertionEvents): Changed from member function to free function. Tightened up handling of some edge cases. (WebCore::dispatchChildRemovalEvents): Ditto.
3:14 PM Changeset in webkit [12337] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix local variable "frame" that was shadowing another local variable named "frame" by naming the one for the new frame "newFrame".
10:25 AM Changeset in webkit [12336] by thatcher
  • 14 copies
    2 deletes in tags/Safari-521.6.1

new tag.

10:18 AM Changeset in webkit [12335] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

9:21 AM Changeset in webkit [12334] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • kjs/lookup.h:
Prefix all KJS types with KJS
in KJS_DEFINE_PROTOTYPE. (cacheGlobalObject): Move this out of the KJS namespace.
2:13 AM Changeset in webkit [12333] by darin
  • 1 edit in trunk/WebCore/WebCore+SVG/SVGElementFactoryWrapper.cpp

Touch the wrapper so it rebuilds. We need a better solution for this.

2:02 AM Changeset in webkit [12332] by mjs
  • 2 edits in trunk/WebCore
  • fix build
  • ksvg2/scripts/make_names.pl: Update script to generate code that works with the new HashMap.
1:04 AM Changeset in webkit [12331] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed a storage leak found by running run-webkit-tests fast --leak
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet): Removed bogus deref call, since the RefPtr handles it for us. Also deployed PassRefPtr in one place. (ProcessingInstructionImpl::setStyleSheet): Removed more bogus ref/deref calls.

Jan 23, 2006:

11:51 PM Changeset in webkit [12330] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • Made some functions return const AtomicString& instead of AtomicString because they could.


Result of Darin's and Eric's comments on the last patch.

  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
11:31 PM Changeset in webkit [12329] by mjs
  • 48 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): no need to mention PointerHash
  • kjs/collector.cpp: ditto
  • kjs/identifier.cpp: (KXMLCore::): declare DefaultHash the new way
  • kjs/internal.cpp: no need to mention PointerHash
  • kjs/ustring.h:
  • kxmlcore/HashCountedSet.h: change how we get the default hash to make it easier to specialize on PtrHash
  • kxmlcore/HashFunctions.h: (KXMLCore::): renamed PointerHash to PtrHash; changed DefaultHash so that it has a Hash typedef rather than being a hash function class itself; declared DefaultHash for int and partializy specialized for pointer types
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PtrHashIteratorAdapter::PtrHashIteratorAdapter): Slight tweaks for new way of handling pointer hash (KXMLCore::PtrHashConstIteratorAdapter::PtrHashConstIteratorAdapter): ditto (KXMLCore::): ditto
  • kxmlcore/HashMap.h: ditto
  • kxmlcore/HashSet.h: ditto

WebCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • bindings/objc/DOM.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]):
  • css/cssstyleselector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): (WebCore::CSSRuleSet::addToRuleSet):
  • khtml/dom/dom_string.h: (KXMLCore::):
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::classInfo): (KJS::HTMLElement::accessors): (KJS::HTMLElement::selectSetter): (KJS::HTMLElement::inputSetter): (KJS::HTMLElement::textAreaSetter): (KJS::HTMLElement::buttonSetter):
  • khtml/ecma/kjs_window.h:
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name): (WebCore::HTMLGenericFormElementImpl::setName):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::checkedRadioButtonForGroup): (WebCore::DocumentImpl::removeRadioButtonGroup):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::AtomicString): (DOM::AtomicString::impl): (KXMLCore::):
  • khtml/xml/dom_stringimpl.cpp: (DOM::equal):
  • khtml/xml/dom_stringimpl.h: (KXMLCore::):
  • khtml/xml/xml_tokenizer.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQObject.cpp:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/loader.h:
  • page/Frame.cpp: (Frame::endAllLifeSupport):
  • rendering/render_canvas.cpp: (RenderCanvas::selectionRect): (RenderCanvas::setSelection):
  • rendering/render_canvas.h:
  • rendering/render_object.h:
  • xml/xmlhttprequest.h:
10:24 PM Changeset in webkit [12328] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Tim Omernick.


  • kjs/array_object.cpp:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kxmlcore/HashMap.h: (KXMLCore::PairFirstExtractor::extract):
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::):
  • kxmlcore/HashSet.h: (KXMLCore::IdentityExtractor::extract):
  • kxmlcore/HashTable.h: (KXMLCore::addIterator): (KXMLCore::removeIterator): (KXMLCore::HashTable::add): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::add): (KXMLCore::HashTable::reinsert): (KXMLCore::HashTable::find): (KXMLCore::HashTable::contains): (KXMLCore::HashTable::remove): (KXMLCore::HashTable::allocateTable): (KXMLCore::HashTable::deallocateTable): (KXMLCore::HashTable::expand): (KXMLCore::HashTable::rehash): (KXMLCore::HashTable::clear): (KXMLCore::HashTable::swap): (KXMLCore::HashTable::operator): (KXMLCore::HashTable::checkTableConsistency): (KXMLCore::HashTable::checkTableConsistencyExceptSize): (KXMLCore::HashTable::invalidateIterators):
8:23 PM Changeset in webkit [12327] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/render_form.cpp: (RenderLineEdit::slotTextChanged): Made newText a DOMString. Assigning the empty DOMString to a QString and back to a DOMString resulted in a null string, which should be avoided here.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::qstring): Don't turn an empty DOMString into a null QString; make an empty QString instead.
8:20 PM Changeset in webkit [12326] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/update-webkit-localizable-strings: Added.
8:18 PM Changeset in webkit [12325] by darin
  • 4 edits in trunk/WebKit
  • fixed some small localizable strings issues
  • WebInspector.subproj/WebInspector.m: (-[DOMNode _nodeTypeName]): Changed so we don't have two localizable strings that are both "Document". I'm not sure we want to localize the DOM inspector UI at all, but this fixes things for now. (-[DOMNode _displayName]): Ditto.
  • English.lproj/Localizable.strings: Updated.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:08 PM Changeset in webkit [12324] by darin
  • 1 edit
    6 adds in trunk/LayoutTests
  • fast/frames/frame-element-name.html: Added.
  • fast/frames/frame-element-name-expected.txt: Added.
  • fast/frames/frame-element-name-expected.png: Added.
  • fast/frames/frame-element-name-expected.checksum: Added.
8:08 PM Changeset in webkit [12323] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/frames/frame-element-name.html

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot): Remove the quirk where frame and iframe elements reflect all the properties of the window inside the frame. Testing indicates that no other browser does this -- not sure why we were doing it.
5:38 PM Changeset in webkit [12322] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/BrowserExtensionMac.mm

Build fix to workaround 4213314.

4:56 PM Changeset in webkit [12321] by mjs
  • 24 edits in trunk

JavaScriptCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::protect):
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kxmlcore/HashCountedSet.h: (KXMLCore::::add):
  • kxmlcore/HashMap.h: (KXMLCore::::inlineAdd):
  • kxmlcore/HashSet.h: (KXMLCore::::add):
  • kxmlcore/HashTable.h: (KXMLCore::HashTable::add): (KXMLCore::::add): (KXMLCore::::HashTable):

WebCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::addElementById): (WebCore::DocumentImpl::registerDisconnectedNodeWithEventListeners):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList):
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add):
  • khtml/xml/dom_qname.cpp: (DOM::QualifiedName::QualifiedName):
  • loader/CachedObject.cpp: (WebCore::CachedObject::ref):
  • page/Frame.cpp: (Frame::keepAlive):
  • rendering/render_canvas.cpp: (RenderCanvas::addWidget):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paint):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addToRequestsByDocument):
4:25 PM Changeset in webkit [12320] by thatcher
  • 2 edits in trunk

Build fix.

4:23 PM Changeset in webkit [12319] by justing
  • 6 edits in trunk

Reviewed by thatcher
Turned on -O2 for Default and OptimizedWithSymbols.

3:38 PM Changeset in webkit [12318] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Fix for when building in a clean sandbox and WebKit isn't built yet.

1:41 PM Changeset in webkit [12317] by mjs
  • 74 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.


  • it's "Franklin Street", not "Franklin Steet"
  • kjs/array_instance.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.cpp:
  • kjs/collector.h:
  • kjs/completion.h:
  • kjs/context.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/debugger.cpp:
  • kjs/debugger.h:
  • kjs/dtoa.h:
  • kjs/error_object.cpp:
  • kjs/error_object.h:
  • kjs/function.cpp:
  • kjs/function.h:
  • kjs/function_object.cpp:
  • kjs/function_object.h:
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/identifier.h:
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp:
  • kjs/interpreter.h:
  • kjs/lexer.cpp:
  • kjs/lexer.h:
  • kjs/list.cpp:
  • kjs/list.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/object_object.cpp:
  • kjs/object_object.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/property_slot.cpp:
  • kjs/property_slot.h:
  • kjs/reference.cpp:
  • kjs/reference.h:
  • kjs/reference_list.cpp:
  • kjs/reference_list.h:
  • kjs/regexp.cpp:
  • kjs/regexp.h:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/scope_chain.cpp:
  • kjs/scope_chain.h:
  • kjs/simple_number.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/types.h:
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/PassRefPtr.h:
  • kxmlcore/RefPtr.h:
9:13 AM Changeset in webkit [12316] by darin
  • 1 edit
    2 adds in trunk/WebKitTools
  • added a couple of scripts -- more about these two soon
  • Scripts/extract-localizable-strings: Added.
  • Scripts/merge-changelog: Added.
9:10 AM Changeset in webkit [12315] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kxmlcore/PassRefPtr.h: Fix assignment operator from RefPtr of a different type by calling get() instead of going directly at m_ptr.
  • kxmlcore/RefPtr.h: Ditto.
  • other changes
  • JavaScriptCore.xcodeproj/project.pbxproj: Xcode decided to change this file. It's just a resorted list of keys in a dictionary.
  • kjs/fpconst.cpp: Wrap this file in #if APPLE since the alternate version in internal.cpp is in #if __APPLE. This file is to give us the "no init routine" property we want to have on OS X.
9:10 AM Changeset in webkit [12314] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Suggested by Anders.

  • fast/dom/clone-node-form-elements-with-attr.html: Added.
  • fast/dom/clone-node-form-elements-with-attr-expected.txt: Added.
9:07 AM Changeset in webkit [12313] by darin
  • 40 edits in trunk/WebCore

Reviewed by John Sullivan.

Test: fast/dom/clone-node-form-elements-with-attr.html

Changed cloneNode and some other functions to return PassRefPtr.
Also made m_render private and changed its name to m_renderer.

  • bindings/objc/DOM.mm: (-[DOMNode cloneNode:]): Add call to get() needed now that cloneNode returns a PassRefPtr.
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/split_element_command.cpp: (khtml::SplitElementCommand::doApply):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::reopenResidualStyleTags):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer): Use RefPtr and PassRefPtr as appropriate, since the result of cloneNode is now a referenced object in a PassRefPtr rather than a floating one and so needs to be kept referenced until used.
  • khtml/html/HTMLElementImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode): Changed to return a PassRefPtr. (WebCore::HTMLElementImpl::children): Ditto.
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/DocumentTypeImpl.cpp: (DOM::DocumentTypeImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/NamedNodeMapImpl.h: (WebCore::NamedNodeMapImpl::getNamedItem): Changed to return PassRefPtr. (WebCore::NamedNodeMapImpl::removeNamedItem): Ditto. (WebCore::NamedNodeMapImpl::setNamedItemNS): Ditto.
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::attach): Use renderer() instead of getting at m_render directly. (WebCore::HTMLGenericFormElementImpl::recalcStyle): Ditto. (WebCore::HTMLGenericFormElementImpl::isFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Ditto.
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::selectionStart): Ditto. (WebCore::HTMLInputElementImpl::selectionEnd): Ditto. (WebCore::HTMLInputElementImpl::setSelectionStart): Ditto. (WebCore::HTMLInputElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLInputElementImpl::select): Ditto. (WebCore::HTMLInputElementImpl::setSelectionRange): Ditto. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLInputElementImpl::setValue): Ditto. (WebCore::HTMLInputElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::recalcStyle): Ditto. (WebCore::HTMLSelectElementImpl::setRecalcListItems): Ditto. (WebCore::HTMLSelectElementImpl::reset): Ditto. (WebCore::HTMLSelectElementImpl::notifyOptionSelected): Ditto. (WebCore::HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::selectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::selectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::select): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionRange): Ditto. (WebCore::HTMLTextAreaElementImpl::updateValue): Ditto. (WebCore::HTMLTextAreaElementImpl::setValue): Ditto.
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::updateForNewURL): Ditto. (WebCore::HTMLFrameElementImpl::openURL): Ditto. (WebCore::HTMLFrameElementImpl::attach): Ditto. (WebCore::HTMLFrameElementImpl::close): Ditto. (WebCore::HTMLFrameElementImpl::willRemove): Ditto. (WebCore::HTMLFrameElementImpl::isFocusable): Ditto. (WebCore::HTMLFrameElementImpl::setFocus): Ditto. (WebCore::HTMLFrameElementImpl::frameWidth): Ditto. (WebCore::HTMLFrameElementImpl::frameHeight): Ditto. (WebCore::HTMLFrameSetElementImpl::defaultEventHandler): Ditto. (WebCore::HTMLFrameSetElementImpl::recalcStyle): Ditto. (WebCore::HTMLIFrameElementImpl::attach): Ditto. (WebCore::HTMLIFrameElementImpl::recalcStyle): Ditto.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLImageElementImpl::width): Ditto. (WebCore::HTMLImageElementImpl::height): Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::isFocusable): Ditto.
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLIElementImpl::attach): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::getAppletInstance): Ditto. (WebCore::HTMLAppletElementImpl::closeRenderer): Ditto. (WebCore::HTMLEmbedElementImpl::getEmbedInstance): Ditto. (WebCore::HTMLEmbedElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::getObjectInstance): Ditto. (WebCore::HTMLObjectElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLObjectElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::detach): Ditto. (WebCore::HTMLObjectElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLTableElementImpl::attach): Ditto.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Ditto. (WebCore::ContainerNodeImpl::getLowerRightCorner): Ditto. (WebCore::ContainerNodeImpl::setActive): Ditto. (WebCore::ContainerNodeImpl::setHovered): Ditto.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl): Ditto. (WebCore::DocumentImpl::elementFromPoint): Ditto. (WebCore::DocumentImpl::recalcStyle): Ditto. (WebCore::DocumentImpl::attach): Ditto. (WebCore::DocumentImpl::restoreRenderer): Ditto. (WebCore::DocumentImpl::detach): Ditto. (WebCore::DocumentImpl::setVisuallyOrdered): Ditto. (WebCore::DocumentImpl::updateSelection): Ditto. (WebCore::DocumentImpl::prepareMouseEvent): Ditto. (WebCore::DocumentImpl::cloneNode): Changed to return PassRefPtr. (WebCore::DocumentImpl::recalcStyleSelector): Use renderer() instead of getting at m_render directly. (WebCore::DocumentImpl::setInPageCache): Ditto.
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): Changed m_render to m_renderer. (WebCore::NodeImpl::~NodeImpl): Changed use of m_render to renderer(). (WebCore::NodeImpl::getRect): Ditto. (WebCore::NodeImpl::attach): Ditto. (WebCore::NodeImpl::detach): Ditto. (WebCore::NodeImpl::createRendererIfNeeded): Ditto. (WebCore::NodeImpl::getElementsByTagName): Changed to return PassRefPtr. (WebCore::NodeImpl::getElementsByTagNameNS): Ditto.
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::AttrImpl::cloneNode): Changed to return PassRefPtr. (WebCore::ElementImpl::cloneNode): Ditto. (WebCore::ElementImpl::scrollIntoView): Use renderer() instead of m_render. (WebCore::ElementImpl::scrollIntoViewIfNeeded): Ditto. (WebCore::ElementImpl::recalcStyle): Ditto. (WebCore::ElementImpl::setAttributeNode): Changed to return PassRefPtr. (WebCore::ElementImpl::removeAttributeNode): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto. (WebCore::NamedAttrMapImpl::setNamedItem): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto. (DOM::ElementImpl::setAttributeNodeNS): Ditto.
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): Changed use of m_render to renderer(). (CharacterDataImpl::appendData): Ditto. (CharacterDataImpl::insertData): Ditto. (CharacterDataImpl::deleteData): Ditto. (CharacterDataImpl::replaceData): Ditto. (CommentImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::splitText): Changed use of m_render to renderer(). (TextImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::recalcStyle): Changed use of m_render to renderer(). (CDATASectionImpl::cloneNode): Changed to return PassRefPtr.
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::cloneNode): Changed to return PassRefPtr. (DOM::EntityReferenceImpl::cloneNode): Ditto. (DOM::NotationImpl::cloneNode): Ditto. (DOM::ProcessingInstructionImpl::cloneNode): Ditto.
  • removed unused code
  • khtml/html/html_documentimpl.cpp: Removed unused slotHistoryChanged function.
  • khtml/html/html_documentimpl.h: Ditto.
  • kwq/KWQObject.cpp: (QObject::connect): Removed special case for slotHistoryChanged, no longer used.
  • fixed storage leak
  • bridge/mac/MacFrame.mm: (MacFrame::~MacFrame): Delete window widget.
7:30 AM Changeset in webkit [12312] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure

  • editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • editing/pasteboard/paste-4039777-fix-expected.png: Added.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • editing/pasteboard/paste-4039777-fix.html: Added.
4:00 AM Changeset in webkit [12311] by andersca
  • 1 edit
    1 add in trunk/WebCore

2006-01-23 Anders Carlsson <​andersca@mac.com>

Forgot to add this as part of
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869


  • manual-tests/resources/webkit-background.png: Added.
2:14 AM Changeset in webkit [12310] by darin
  • 2 edits in trunk/WebCore
  • fix layout tests
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added missing code to set wrapInAnonymousSection false in the case where adding a footer.
12:47 AM Changeset in webkit [12309] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add missing reviewer.

12:44 AM Changeset in webkit [12308] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

  • kjs/interpreter.h: make globalExec virtual so ScriptInterpreter can override it
12:36 AM Changeset in webkit [12307] by mjs
  • 17 edits
    4 adds in trunk/WebCore

Reviewed by Darin.


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::MacFrame): Initialize _bridge (MacFrame::~MacFrame): Clear the bridge's frame pointer and release it. (Frame::frameDetached): Reverse order of removing from old-style frames array and calling frameDetached. (MacFrame::createPart): Don't ref the part when creating it, since the child bridge is no longer going to own a ref. (MacFrame::setBridge): KWQRetain / KWQRelease since we know own the bridge. (MacFrame::detachFromView): New method; clear out the view.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (Bridge): Helper method to get a WebCoreFrameBridge from a Frame. (-[WebCoreFrameBridge firstChild]): Call through Frame. (-[WebCoreFrameBridge lastChild]): ditto (-[WebCoreFrameBridge childCount]): ditto (-[WebCoreFrameBridge previousSibling]): ditto (-[WebCoreFrameBridge nextSibling]): ditto (-[WebCoreFrameBridge isDescendantOfFrame:]): No need to cast parent pointer. (-[WebCoreFrameBridge appendChild:]): Call through Frame. (-[WebCoreFrameBridge _clearRenderPart]): New helper method to free the renderPart when removing a child. (-[WebCoreFrameBridge removeChild:]): Clear child's render part and call through to Frame. (-[WebCoreFrameBridge dealloc]): Remove unneeded m_frame-related code. (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge clearFrame]): New helper method, needed now that bridge can outlive frame. (-[WebCoreFrameBridge handleFallbackContent]): Make safe against a null frame. (-[WebCoreFrameBridge removeFromFrame]): ditto
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge initWithMainFrame:]): Create a Page instance. (-[WebCorePageBridge dealloc]): Delete the Page. (-[WebCorePageBridge mainFrame]): Get the main frame from the Page.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::globalExec): Override; keep frame alive, then call superclass.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::clear): Don't pass exec to window. (KJSProxyImpl::interpreter): Don't do keepAlive.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): If the active part's document is gone, use the frame's URL for security check purposes. (KJS::Window::clear): Don't take an ExecState parameter any more - it wasn't used.
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitOpen): If we've got a tokenizer, delete it before closing - you don't ever want to fire an onload handler because of an open.
  • page/Frame.cpp: (Frame::init): Pass `this' to FramePrivate constructor. (FrameCounter::~FrameCounter): Added debug counting of leftover Frame objects on exit. (Frame::Frame): Moved out-of-line. Increment debug counter. (Frame::~Frame): Assert that there is no life support going, either at the start or end of this method. Decrement frame counter. (Frame::stopLoading): tweaked for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::clear): ditto (Frame::stop): ditto (Frame::stopAnimations): ditto (Frame::checkEmitLoadEvent): ditto (Frame::processObjectRequest): ditto (Frame::childFrame): ditto (Frame::findFrame): ditto (Frame::setZoomFactor): ditto (Frame::frames): ditto (Frame::connectChild): ditto (Frame::disconnectChild): ditto (Frame::endAllLifeSupport): Method that, in debug mode, will clear all life suppor timers so the Frame exit counter works. (Frame::keepAlive): In debug mode, add proper support for endAllLifeSupport (Frame::slotEndLifeSupport): ditto (Frame::setPolicyBaseURL): Update for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::treeNode): New helper method, get the FrameTreeNode class that implements frame tree traversal. (Frame::nextSibling): Simple wrapper that calls through to treeNode(). (Frame::previousSibling): ditto (Frame::firstChild): ditto (Frame::lastChild): ditto (Frame::childCount): ditto (Frame::appendChild): ditto (Frame::removeChild): ditto (Frame::detachFromView): no-op, just a virtual base for the MAcFrame method.
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Add FrameTreeNode member.
  • page/FrameTreeNode.cpp: Added. (FrameTreeNode::~FrameTreeNode): detach all children from their view (FrameTreeNode::appendChild): implemented (FrameTreeNode::removeChild): implemented - make sure to detach child from its view.
  • page/FrameTreeNode.h: Added. (FrameTreeNode::FrameTreeNode): New; initialize fields tht need it. (FrameTreeNode::nextSibling): Trivial inline. (FrameTreeNode::previousSibling): ditto (FrameTreeNode::firstChild): ditto (FrameTreeNode::lastChild): ditto (FrameTreeNode::childCount): ditto
  • page/Page.cpp: Added. (Page::Page): Initialize mainFrame and bump pageCount appropriately. (Page::~Page): Detach main frame from view, handle ending life support when last frame is destroyed.
  • page/Page.h: Added. (Page::mainFrame): Trivial inline.
  • WebCore.xcodeproj/project.pbxproj: Add new files.

Jan 22, 2006:

11:23 PM Changeset in webkit [12306] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • Info.plist: Updated Apple copyright date. Need to update others too at some point.
  • WebCore-svg.exp: Removed unused empty file.
11:20 PM Changeset in webkit [12305] by staikos
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kxmlcore/Assertions.h: This file only works with APPLE right now
  • kjs/interpreter.cpp: ditto
  • kjs/simple_number.h: Add assert.h and remove from config.h
  • kjs/array_object.cpp: Use relative paths for kxmlcore includes
  • kjs/testkjs.cpp: Use relative paths for kxmlcore includes
11:01 PM Changeset in webkit [12304] by staikos
  • 2 edits in trunk/JavaScriptCore

Rubber stamp from Maciej:

  • Assertions is only valid in APPLE right now
11:00 PM Changeset in webkit [12303] by eseidel
  • 24 edits
    2 adds in trunk/WebCore

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make <animateColor> work again (broke during DOM merger).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5964

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::getAbsoluteRepaintRect): moved to .cpp file
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose): start svg animations (WebCore::DocumentImpl::svgExtensions): svg document extensions (WebCore::DocumentImpl::accessSVGExtensions): svg doc extensions
  • khtml/xml/DocumentImpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): cleanup
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent): update css lookup
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent): fix css property lookup
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer): use doc extensions (SVGAnimationElementImpl::targetAttribute): fix css properties (SVGAnimationElementImpl::setTargetAttribute): fix css properties
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::svgView): remove unnecessary static cast (SVGDocumentImpl::executeScripts):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp: (WebCore::SVGElementImpl::addSVGEventListener): helper function (WebCore::SVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGGElementImpl.cpp:
  • ksvg2/svg/SVGGElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::~SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::addSVGWindowEventListner): helper (WebCore::SVGSVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent): use doc extensions
  • ksvg2/svg/SVGStyledElementImpl.h:
  • page/Frame.cpp: (Frame::pauseTimeouts): pause svg animation (Frame::resumeTimeouts): resume svg animation
  • rendering/render_canvas.h:
10:55 PM Changeset in webkit [12302] by staikos
  • 2 edits in trunk/JavaScriptCore

unbreak preprocessor change
Reviewed by Maciej

10:10 PM Changeset in webkit [12301] by staikos
  • 17 edits in trunk/JavaScriptCore

Approved by Maciej and Darin.

  • kjs/:
  • kxmlcore/:

Update FSF address in license to make merging easier

9:44 PM Changeset in webkit [12300] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kjs/collector.cpp: merge major speedup from KDE on Linux

patch by Maks Orlovich, bug #6145
Also unify cpu detection

  • kjs/config.h: define simpler CPU macros
9:43 PM Changeset in webkit [12299] by darin
  • 2 edits in trunk/WebCore
  • fix deployment builds
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Init bool.
9:29 PM Changeset in webkit [12298] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/table/form-with-table-style.html: Added.
  • fast/table/form-with-table-style-expected.txt: Added.
  • fast/table/form-with-table-style-expected.png: Added.
  • fast/table/form-with-table-style-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

Test: fast/table/form-with-table-style.html

Hang was caused by the fact that RenderContainer has code to wrap table
styled elements in appropriate anonymous table elements, but the table
elements themselves have a special case for form elements that causes them
to call through, which led to infinite recursion as RenderContainer kept
making new tables which kept calling through to RenderContainer::addChild.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Improved logic about wrapping children in anonymous table sections in the following ways: (1) Do wrap a form properly it has a table display style (such as table-cell or table-row). (2) When an item has a particular display style, check that it has the right type of render object before casting it to that type. Also restructured the code a little to make it slightly more readable. (WebCore::RenderTable::layout): Added a FIXME about forms that have a display style that makes it a table section, since they will be skipped here in the loop to lay children out. (WebCore::RenderTable::recalcSections): Added checks similar to the ones in addChild above.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Moved form tag logic inside render object type check so that a table row that happens to be a form element won't be affected by the special form tag logic. Also added an explicit check for the table-cell style so we will wrap it in a row rather than just putting the form at this level.
  • rendering/RenderTableRow.h: Removed removeChildNode and dump functions that just called through to the base class.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Moved form tag logic inside render object type check so that a table cell that happens to be a form element won't be affected by the special form tag logic. Removed unnecessary null check of section() at end of function.
  • rendering/RenderTableCol.h: Removed addChild because all it did was assert (incorrectly) and then call through to the base class. Changed _span to be m_span.
  • rendering/RenderTableCol.cpp: Removed addChild function. Updated for change in name of m_span field.
9:07 PM Changeset in webkit [12297] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQListBox.mm: (QListBox::QListBox): Call setCopiesOnScroll:NO.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Ditto.
8:39 PM Changeset in webkit [12296] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej
Compile fix for FreeBSD 5.4 from KDE

6:53 PM Changeset in webkit [12295] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added a few Radar bug numbers for future searching purposes.

6:47 PM Changeset in webkit [12294] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/button-white-space-expected.checksum: Added.
  • fast/forms/button-white-space-expected.png: Added.
  • fast/forms/button-white-space-expected.txt: Added.
  • fast/forms/button-white-space.html: Added.

WebCore:

Reviewed by Maciej.

  • css/html4.css: Remove default white-space value for <button> tag to allow it to be inherited.
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.
  • css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild of html4.css work (shouldn't have to do this).
6:35 PM Changeset in webkit [12293] by darin
  • 2 edits in trunk/WebCore
  • css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch of whitespace that was supposed to go into a derived source file going to the console instead.
3:53 PM Changeset in webkit [12292] by eseidel
  • 17 edits
    6 adds in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

SVG needs to support "evt" instead of "event" in event handlers.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5874

  • WebCore.xcodeproj/project.pbxproj: added new classes
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::createHTMLEventHandler): simplified (WebCore::KJSProxyImpl::createSVGEventHandler): new
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createHTMLEventListener): simplified (WebCore::DocumentImpl::createSVGEventListener): new
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): use RefPtr
  • ksvg2/events/JSSVGLazyEventListener.cpp: Added. (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): added. (WebCore::JSSVGLazyEventListener::eventParameterName): added.
  • ksvg2/events/JSSVGLazyEventListener.h: Added.
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): use new SVG event handler
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::parseMappedAttribute): use new SVG event handler
  • page/Frame.cpp: updated KJSProxyImpl namespace
  • page/Frame.h: updated KJSProxyImpl namespace
  • page/FramePrivate.h: updated KJSProxyImpl namespace
2:57 PM Changeset in webkit [12291] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.


Makes the Inspector's Style pane take !important into account
when marking overloaded properties.

2:32 PM Changeset in webkit [12290] by darin
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/css/position-negative-top-margin.html: Added.
  • fast/css/position-negative-top-margin-expected.txt: Added.
  • fast/css/position-negative-top-margin-expected.png: Added.
  • fast/css/position-negative-top-margin-expected.checksum: Added.
  • fast/box-sizing/box-sizing-expected.txt: Updated, since absolute position box locations changed.
  • fast/box-sizing/box-sizing-expected.png: Ditto.
  • fast/box-sizing/box-sizing-expected.checksum: Ditto.
  • changed a few suitable tests to dump as text (in part to fix a failing pixel test in one)
  • fast/parser/entity-surrogate-pairs.html: Added a call to dumpAsText().
  • fast/parser/entity-surrogate-pairs-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/head-comment.html Added a call to dumpAsText().
  • fast/parser/head-comment-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/head-comment-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.

WebCore:

Reviewed by Maciej.

Test: fast/css/position-negative-top-margin.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustPositionedBlock): Fixed two different problems that contributed to the bug: (1) Added a call to calcVerticalMargins otherwise the margin will always be 0. (2) Corrected logic for the negative margin case, which was comparing a negative margin-top to a number representing the absolute value of the margin.
1:27 PM Changeset in webkit [12289] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Maciej mentioned he reviewed the change George just landed, so updating the log to reflect that.

12:32 PM Changeset in webkit [12288] by ap
  • 5 edits
    12 adds in trunk

Reviewed by Darin.

Also replaced tabs with spaces in the changed files.

Test cases:

  • fast/table/append-cells.html
  • fast/table/append-cells2.html
  • fast/table/remove-td-display-none.html
  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Shrink columns and columnPos to the actual number of columns.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::numColumns): New function. (WebCore::RenderTableSection::dump): Use gridRows instead of grid.size() for row count, preventing crashes.
  • rendering/RenderTableSection.h: Added numColumns() and a comment about cCol/cRow.
12:20 PM Changeset in webkit [12287] by darin
  • 22 edits in trunk/WebCore

Reviewed by Anders.

Once we do the same with cloneNode, I believe we'll fix one of our P1 bugs,
but cloneNode was a little too much to do without doing this first pass.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::childNodes): Updated for parameter changes. (WebCore::NodeImpl::insertBefore): Ditto. (WebCore::NodeImpl::replaceChild): Ditto. (WebCore::NodeImpl::removeChild): Ditto. (WebCore::NodeImpl::appendChild): Ditto. (WebCore::NodeImpl::addChild): Ditto. (WebCore::NodeImpl::addEventListener): Ditto. (WebCore::NodeImpl::setHTMLEventListener): Ditto. (WebCore::NodeImpl::isDefaultNamespace): Updated for changed name of ancestorElement. (WebCore::NodeImpl::lookupPrefix): Ditto. (WebCore::NodeImpl::lookupNamespaceURI): Ditto. (WebCore::NodeImpl::lookupNamespacePrefix): Ditto. (WebCore::NodeImpl::ancestorElement): Changed name from getAncestorElement.
  • khtml/xml/NodeImpl.h: Changed most functions where it makes sense to take and return PassRefPtr instead of raw pointers. Even non-obvious cases like appendChild, where the return value has to be PassRefPtr only because it might be removed when the JavaScript triggered by the DOM mutation event runs (normally, there's no need to return an "owning" pointer because the tree now owns the newly-inserted node). Made the ancestorElement function private.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): Updated for changes from _first to m_firstChild and _last to m_lastChild. (WebCore::ContainerNodeImpl::removeAllChildren): Ditto. (WebCore::ContainerNodeImpl::firstChild): Ditto. (WebCore::ContainerNodeImpl::lastChild): Ditto. (WebCore::ContainerNodeImpl::insertBefore): Updated for parameter changes. (WebCore::ContainerNodeImpl::replaceChild): Ditto. (WebCore::ContainerNodeImpl::willRemove): Updated for m_lastChild. (WebCore::ContainerNodeImpl::removeChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::removeChildren): Updated for m_first/lastChild. (WebCore::ContainerNodeImpl::appendChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::hasChildNodes): Updated for m_firstChild. (WebCore::ContainerNodeImpl::addChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::attach): Updated for m_firstChild. (WebCore::ContainerNodeImpl::detach): Ditto. (WebCore::ContainerNodeImpl::insertedIntoDocument): Ditto. (WebCore::ContainerNodeImpl::removedFromDocument): Ditto. (WebCore::ContainerNodeImpl::insertedIntoTree): Ditto. (WebCore::ContainerNodeImpl::removedFromTree): Ditto.
  • khtml/xml/ContainerNodeImpl.h: Removed unused checkSameDocument and checkIsChild. Made more things private, updated parameters for NodeImpl functions.
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::insertBefore): Ditto. (DOM::HTMLSelectElementImpl::replaceChild): Ditto. (DOM::HTMLSelectElementImpl::removeChild): Ditto. (DOM::HTMLSelectElementImpl::appendChild): Ditto. (DOM::HTMLSelectElementImpl::addChild): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Ditto.
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): Updated for parameter type change. Also changed to look at return value, not exception code, to check for success. (WebCore::HTMLOptGroupElementImpl::replaceChild): Ditto. (WebCore::HTMLOptGroupElementImpl::removeChild): Ditto. (WebCore::HTMLOptGroupElementImpl::appendChild): Ditto. (WebCore::HTMLOptGroupElementImpl::addChild): Ditto.
  • khtml/html/HTMLOptGroupElementImpl.h: Ditto.
  • WebCore+SVG/kdom.h: Renamed enum from ExceptionCode to ExceptionCodes to avoid conflict with a typedef ExceptionCode I added.
  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): Added get() call since return value is a PassRefPtr. (-[DOMNode replaceChild::]): Ditto. (-[DOMNode removeChild:]): Ditto. (-[DOMNode appendChild:]): Ditto.
  • khtml/ecma/kjs_dom.h: Changed getDOMNode to take PassRefPtr.
  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Changed to take PassRefPtr.
  • khtml/html/HTMLElementImpl.cpp: Added dom2_events.h include, now needed. Re-sorted includes.
  • ksvg2/svg/SVGElementImpl.cpp: Ditto.
  • khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::documentElement): Changed access to now-private data member _first to equivalent inline function fastFirstChild().
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle): Ditto.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::setCaption): Updated to work with new replaceChild that returns PassRefPtr. (WebCore::HTMLTableElementImpl::setTHead): Ditto. (WebCore::HTMLTableElementImpl::setTFoot): Ditto. (WebCore::HTMLTableElementImpl::setTBody): Ditto. (WebCore::HTMLTableElementImpl::addChild): Updated for parameter type change. (WebCore::HTMLTableSectionElementImpl::addChild): Ditto. (WebCore::HTMLTableRowElementImpl::addChild): Ditto.
  • khtml/html/html_tableimpl.h: Ditto.
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an unneeded explicit call to removeChild. appendChild already takes care of removing the child from its own location. This avoids the fact that removeChild was removing the parent, the only thing keeping the node alive. This is sort of the "flip side" of our removeChild leaks -- code that depended on the behavior that caused the leaks.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Removed unneeded isHTMLElement() calls from before the "qualified name" change.
11:22 AM Changeset in webkit [12286] by darin
  • 1 add in trunk/WebCore/manual-tests/bugzilla-3509.html

Somehow this file didn't get checked in before (even though it was
mentioned in the change log).

11:18 AM Changeset in webkit [12285] by ap
  • 2 edits in trunk/WebKitTools

Fix by Mark Rowe . Reviewed by Anders.


Build fix. build-webkit dies with "invalid build action: (empty string)"

  • Scripts/build-webkit: Use svgOptions in an array context so xcodebuild doesn't choke on an empty argument.
6:41 AM Changeset in webkit [12284] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix --no-svg option to use XCode flags instead of gcc flags.

  • Scripts/build-webkit:
6:08 AM Changeset in webkit [12283] by eseidel
  • 341 edits in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com

Rubber-stamped by anders.

Remove WebCore-no-SVG target and wrap files in #if SVG_SUPPORT
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6633

2:49 AM Changeset in webkit [12282] by ap
  • 8 edits
    2 copies
    2 moves
    1 add in trunk/WebCore

Reviewed by Maciej.

  • WebCore.xcodeproj/project.pbxproj: Adjusted for moved and renamed files. New group "xml" to match directory structure.
  • xml: Added.
  • khtml/ecma/JSXMLHttpRequest.cpp: Added.
  • khtml/ecma/JSXMLHttpRequest.h: Added.
  • khtml/ecma/xmlhttprequest.cpp: Removed.
  • khtml/ecma/xmlhttprequest.h: Removed.
  • xml/xmlhttprequest.cpp: Added.
  • xml/xmlhttprequest.h: Added.
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrUndefined): Moved from kjs_events.cpp.
  • khtml/ecma/kjs_binding.h: Added prototype for jsStringOrUndefined().
  • khtml/ecma/kjs_events.cpp: Removed jsStringOrUndefined().
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Use new class name for JSXMLHttpRequest.
  • kwq/KWQSlot.cpp: XMLHttpRequestQObject is now in WebCore, not KJS.
  • page/Frame.cpp: (Frame::stopLoading): XMLHttpRequest is now in WebCore, not KJS.
1:57 AM Changeset in webkit [12281] by eseidel
  • 119 edits
    1 delete in trunk

2006-01-22 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for custom fill/strokes on text.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6448

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint): use new painter setup/teardown infrastructure
  • kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::KRenderingPaintServer): (KRenderingPaintServer::setup): (KRenderingPaintServer::render): (KRenderingPaintServer::teardown): (KRenderingPaintServer::isPaintingText): (KRenderingPaintServer::setPaintingText):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (setupShadingWithStyle): (renderShadingWithStyle): (teardownShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::render): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::render): (KRenderingPaintServerRadialGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerPatternQuartz::KRenderingPaintServerPatternQuartz):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerQuartzHelper::strokePath): (KRenderingPaintServerQuartzHelper::clipToStrokePath): (KRenderingPaintServerQuartzHelper::fillPath): (KRenderingPaintServerQuartzHelper::clipToFillPath): (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerSolidQuartz::setup): (KRenderingPaintServerSolidQuartz::render): (KRenderingPaintServerSolidQuartz::teardown): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerPatternQuartz::setup): (KRenderingPaintServerPatternQuartz::render): (KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h: fix prototype
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KSVGPainterFactory::fillPaintServer): (KSVGPainterFactory::strokePaintServer): (KSVGPainterFactory::cssPrimitiveToLength): (KSVGPainterFactory::strokePainter): (KSVGPainterFactory::fillPainter):
  • ksvg2/misc/KCanvasRenderingStyle.h:

Jan 21, 2006:

10:20 PM Changeset in webkit [12280] by staikos
  • 5 edits in trunk/JavaScriptCore

Reviewed by Maciej

Merge some build fixes for various Perl and gcc versions from KDE SVN.

8:28 PM Changeset in webkit [12279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.


  • manual-tests/bugzilla-3509.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Force repaint if the child didn't move but didn't repaint correctly during layout because it was not at its final position then.
4:25 PM Changeset in webkit [12278] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.

Make sure shorthand properties get striked-out if
all the properties they expand into are overloaded.

2:11 PM Changeset in webkit [12277] by eseidel
  • 4 edits in trunk/WebKitTools

2006-01-20 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by eseidel.

  • Scripts/build-drawtest: Changed bareword 'true' to 1.
  • Scripts/run-drawtest: Changed bareword 'true' to 1.
1:58 PM Changeset in webkit [12276] by andersca
  • 7 edits
    7 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869
Should use HTML Image element instead of JS Image object

  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction): Don't check Image object. Instead, if the element passed in is an image element which isn't in any document, use its pixmap.


  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::imageGetter): Add complete.


(KJS::ImageConstructorImp::construct):
Take a QPixmap instead of an Image.


(KJS::KJS::Context2DFunction::callAsFunction):
Remove usage of Image and use HTMLImageElementImpl instead.

  • khtml/ecma/kjs_html.h: Remove Image class.


(KJS::HTMLElement::):
Add ImgComplete.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): If the element has no renderer but its image size is known return that instead.


(WebCore::HTMLImageElementImpl::complete):
New function, returns true if an image has finished loading.


  • khtml/html/html_imageimpl.h: Add complete.


  • manual-tests/drag-image.html: Added.
1:20 PM Changeset in webkit [12275] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-21 Anders Carlsson <​andersca@mac.com>

  • editing/editing.js: Fix typo which made editing test cases fail.
12:15 PM Changeset in webkit [12274] by andersca
  • 4 edits
    4 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/editing/jsediting.cpp: Add support for the "Strikethrough" command.


12:02 PM Changeset in webkit [12273] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/hovered-detach.html: Added.
  • fast/dynamic/hovered-detach-expected.txt: Added.

WebCore:

Test: fast/dynamic/hovered-detach.html

Reviewed by Darin.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Set m_hovered to false and set the document's hoverNode to an hovered ancestor that still has a renderer.
  • rendering/render_layer.cpp: Changed static method hoverAncestor() into a RenderObject instance method. (WebCore::commonAncestor): (WebCore::RenderLayer::updateHoverActiveState):
  • rendering/render_object.cpp: Ditto. (WebCore::RenderObject::hoverAncestor)
  • rendering/render_object.h: Ditto.
11:22 AM Changeset in webkit [12272] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Adds computed style to the Web Inspector.
Adds a "mapped style" link to the mapped attributes.

Jan 20, 2006:

7:47 PM Changeset in webkit [12271] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 6666, pseudo-element rules incorrectly displayed
in Web Inspector.


Reviewed by darin

Added fast/inspector/matchedrules.html as test case.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
7:45 PM Changeset in webkit [12270] by hyatt
  • 2 adds in trunk/LayoutTests/fast/inspector

Add a test case for Web Inspector style matching bug.

7:05 PM Changeset in webkit [12269] by thatcher
  • 7 edits
    2 deletes in trunk

WebCore:

Reviewed by John.

Removes code that is no longer needed with the new Web Inspector.

  • bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
  • bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

Reviewed by John, some parts by Darin.

Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
that menu item to prevent a crash.

  • WebKit.exp: adds WebInspector, removes WebDebugDOMNode
  • WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
  • WebView.subproj/WebDebugDOMNode.h: Removed.
  • WebView.subproj/WebDebugDOMNode.m: Removed.
  • WebView.subproj/WebView.m: (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item
5:03 PM Changeset in webkit [12268] by andersca
  • 17 edits in trunk/WebCore

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by David Hyatt.

Rename Frame::xmlDocImpl => Frame::document and
Frame::replaceDocImpl => Frame::setDocument


  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::keyEvent): (MacFrame::dispatchCPPEvent): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::bodyBackgroundColor): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::setMarkedTextRange): (MacFrame::dashboardRegionsDictionary): (MacFrame::shouldClose):
  • bridge/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): (frameHasSelection): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge saveDocumentState]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge saveDocumentToPageCache]): (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge deselectAll]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge copyDOMTree:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge unmarkAllMisspellings]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge DOMDocument]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge doneProcessingData]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/editing/jsediting.cpp:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::contentDocument):
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]):
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • page/Frame.cpp: (Frame::document): (Frame::setDocument): (Frame::setFocusNodeIfNeeded): (Frame::isPointInsideSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectionComputedStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::renderer): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayoutWithPageWidthRange): (Frame::sendScrollEvent): (Frame::clearTimers): (Frame::styleForSelectionStart): (Frame::setSelectionFromNone): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol):
  • page/Frame.h:
  • page/FrameView.cpp: (FrameView::~FrameView): (FrameView::clear): (FrameView::resizeEvent): (FrameView::adjustViewSize): (FrameView::layout): (FrameView::updateDashboardRegions): (FrameView::viewportMousePressEvent): (FrameView::viewportMouseDoubleClickEvent): (FrameView::viewportMouseMoveEvent): (FrameView::viewportMouseReleaseEvent): (FrameView::keyPressEvent): (FrameView::dispatchDragEvent): (FrameView::updateDragAndDrop): (FrameView::focusNextPrevNode): (FrameView::dispatchMouseEvent): (FrameView::viewportWheelEvent): (FrameView::timerEvent): (FrameView::scheduleRelayout): (FrameView::unscheduleRelayout):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
2:54 PM Changeset in webkit [12267] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

Corrects the cascade order for mapped attributes.
Shows "inline stylesheet" rather than "null" for rules in <style> tags.

1:48 PM Changeset in webkit [12266] by cpeterse
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Build fix.

  • khtml/xml/DocumentImpl.cpp:
12:20 PM Changeset in webkit [12265] by eseidel
  • 3 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Unbreak build (partial commit of animation patch)

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/DocumentImpl.h:
11:30 AM Changeset in webkit [12264] by eseidel
  • 4 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Missed the kcanvas directory in my previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
11:24 AM Changeset in webkit [12263] by eseidel
  • 28 edits
    8 copies
    6 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Break classes in render_table out into separate files.
Move render_block to RenderBlock.
Move render_container to RenderContainer.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::insertRow):
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_position.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • page/Frame.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp: Added.
  • rendering/RenderBlock.h: Added.
  • rendering/RenderContainer.cpp: Added. (WebCore::RenderContainer::addChild):
  • rendering/RenderContainer.h: Added.
  • rendering/RenderTable.cpp: Added. (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::updateFirstLetter):
  • rendering/RenderTable.h: Added.
  • rendering/RenderTableCell.cpp: Added. (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCell.h: Added.
  • rendering/RenderTableCol.cpp: Added. (WebCore::RenderTableCol::RenderTableCol): (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableCol.h: Added.
  • rendering/RenderTableRow.cpp: Added. (WebCore::RenderTableRow::RenderTableRow):
  • rendering/RenderTableRow.h: Added.
  • rendering/RenderTableSection.cpp: Added. (WebCore::RenderTableSection::RenderTableSection):
  • rendering/RenderTableSection.h: Added.
  • rendering/RenderText.cpp:
  • rendering/bidi.cpp:
  • rendering/render_block.cpp: Removed.
  • rendering/render_block.h: Removed.
  • rendering/render_box.cpp:
  • rendering/render_canvas.h:
  • rendering/render_container.cpp: Removed.
  • rendering/render_container.h: Removed.
  • rendering/render_flexbox.h:
  • rendering/render_flow.cpp:
  • rendering/render_flow.h:
  • rendering/render_form.h:
  • rendering/render_frames.h:
  • rendering/render_inline.cpp:
  • rendering/render_inline.h:
  • rendering/render_line.cpp:
  • rendering/render_list.h:
  • rendering/render_object.cpp:
  • rendering/render_replaced.h:
  • rendering/render_table.cpp: Removed.
  • rendering/render_table.h: Removed.
  • rendering/table_layout.cpp:
11:10 AM Changeset in webkit [12262] by mjs
  • 1 edit
    3 adds in trunk/LayoutTests
  • added test case for a parsing bug that was fixed in different ways in KJS and JSC. In older KJS versions, there would have been a parse error.
  • fast/js/parse-backslash-before-newline-expected.txt: Added.
  • fast/js/parse-backslash-before-newline.html: Added.
  • fast/js/resources/parse-backslash-before-newline.js: Added.
10:45 AM Changeset in webkit [12261] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/overflow/image-selection-highlight-expected.checksum: Added.
  • fast/overflow/image-selection-highlight-expected.png: Added.
  • fast/overflow/image-selection-highlight-expected.txt: Added.
  • fast/overflow/image-selection-highlight.html: Added.

WebCore:

Test: fast/overflow/image-selection-highlight.html

Reviewed by Darin, committed by Adele.


  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionRect): Subtract the containing block's scroll offset.
10:13 AM Changeset in webkit [12260] by thatcher
  • 5 copies in tags/Safari-521.6

Final Safari-521.6 tag. Ignore the diffs, they are wrong!

10:11 AM Changeset in webkit [12259] by thatcher
  • 1 delete in tags/Safari-521.6

This tag needs updated.

9:42 AM Changeset in webkit [12258] by thatcher
  • 1 edit in trunk/WebKitSite/contact.html

Add ​irc://irc.freenode.net/#webkit links.

9:26 AM Changeset in webkit [12257] by thatcher
  • 1 edit in trunk/WebKitSite/coding/contributing.html

Fixes the rest of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6535
add <tt></tt> around an instance of "svn diff".

12:18 AM Changeset in webkit [12256] by thatcher
  • 2 edits in trunk/WebKitSite

Replace all "cvs" references with "svn".

Jan 19, 2006:

11:45 PM Changeset in webkit [12255] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric.

Adds inline style reporting and mapped attribute support to the Inspector Style pane.
Cleans up the node attributes area with a more natural attr = "value" look.
Slight optimization to only update visible scrollbars during a window resize.

10:42 PM Changeset in webkit [12254] by thatcher
  • 1 edit in trunk

Add WebKitBuild to the svn:ignore

10:21 PM Changeset in webkit [12253] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix a typo that made WebCore build and link UserAgentStyleSheets.cpp every time, even if nothing changed.

9:10 PM Changeset in webkit [12252] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6631
Inspector window has inappropriate maximum height

5:40 PM Changeset in webkit [12251] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit.xcodeproj/project.pbxproj: made WebNSUserDefaultsExtras.h private (SPI) so its one method can be called from Safari, so Safari can stop calling the similar method in Foundation.
5:22 PM Changeset in webkit [12250] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<embed> and <object> tags show up blank when going back/forward.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6679

No test currently possible.

  • page/Frame.cpp: (Frame::canCachePage):
5:02 PM Changeset in webkit [12249] by sullivan
  • 5 edits
    1 add in trunk/WebKit

Reviewed by Tim Omernick.


Made _webKit_guessedMIMEType SPI so Safari can use it in order to stop using
the similar SPI method in Foundation. This involved splitting it out of the file
it was in, to avoid creating any other new SPI here. Poor svn diff got mighty
confused in the process.

  • Misc.subproj/WebNSDataExtras.h: removed _webkit_guessedMIMEType from here
  • Misc.subproj/WebNSDataExtrasPrivate.h: Added. Contains only _webkit_guessedMIMEType. This file is private (SPI), whereas WebNSDataExtras.h is project-internal. I could have renamed WebNSDateExtras.h to WebNSDateExtrasInternal.h also, but I minimized the gratuitous change level here by not doing that.


  • Misc.subproj/WebNSDataExtras.m: Despite the great confusion of svn diff, all I actually did here was move _webkit_guessedMIMEType and its helper _webkit_guessedMIMETypeForXML into a new category. No lines of code were harmed while creating this patch.
  • WebKit.xcodeproj/project.pbxproj: updated for new file
  • WebView.subproj/WebView.m: Added #import for new file since WebView uses _webkit_guessedMIMEType
4:29 PM Changeset in webkit [12248] by thatcher
  • 5 copies in tags/Safari-521.6

Trying the Safari-521.6 tag again

4:26 PM Changeset in webkit [12247] by thatcher
  • 1 delete in tags/Safari-521.6

Bad tag, not sure what happened.

4:22 PM Changeset in webkit [12246] by thatcher
  • 5 copies in tags/Safari-521.6

Tagging Safari-521.6

3:57 PM Changeset in webkit [12245] by thatcher
  • 8 adds in branches/Safari-Leo-branch

Versioning to 521.6

3:50 PM Changeset in webkit [12244] by thatcher
  • 1 add in branches/Safari-Leo-branch
3:50 PM Changeset in webkit [12243] by eseidel
  • 64 edits
    6 copies
    4 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Split html_miscimpl.* into separate files and move html_elementimpl
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6670

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_valueimpl.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/html/HTMLBaseFontElementImpl.cpp: Added.
  • khtml/html/HTMLBaseFontElementImpl.h: Added.
  • khtml/html/HTMLButtonElementImpl.cpp:
  • khtml/html/HTMLCollectionImpl.cpp: Added. (WebCore::HTMLCollectionImpl::traverseNextItem):
  • khtml/html/HTMLCollectionImpl.h: Added.
  • khtml/html/HTMLElementImpl.cpp: Added.
  • khtml/html/HTMLElementImpl.h: Added.
  • khtml/html/HTMLFieldSetElementImpl.cpp:
  • khtml/html/HTMLFormCollectionImpl.cpp: Added.
  • khtml/html/HTMLFormCollectionImpl.h: Added.
  • khtml/html/HTMLFormElementImpl.cpp:
  • khtml/html/HTMLFormElementImpl.h:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLIsIndexElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.h:
  • khtml/html/HTMLLegendElementImpl.cpp:
  • khtml/html/HTMLNameCollectionImpl.cpp: Added.
  • khtml/html/HTMLNameCollectionImpl.h: Added.
  • khtml/html/HTMLOptGroupElementImpl.cpp:
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLOptionElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp: Removed.
  • khtml/html/html_elementimpl.h: Removed.
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.h:
  • khtml/html/html_miscimpl.cpp: Removed.
  • khtml/html/html_miscimpl.h: Removed.
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_elementimpl.cpp:
  • kwq/KWQAccObject.mm:
  • loader/loader.cpp:
  • page/Frame.cpp: (Frame::restoreURL): (Frame::stopLoading): (Frame::receivedFirstData): (Frame::gotoAnchor): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::findFrame): (Frame::executeScript):
  • page/FrameView.cpp: (FrameView::useSlowRepaints):
  • rendering/render_applet.cpp:
  • rendering/render_applet.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
  • rendering/render_canvasimage.cpp:
  • rendering/render_canvasimage.h:
  • rendering/render_frames.cpp:
  • rendering/render_image.cpp:
  • rendering/render_image.h:
  • rendering/render_layer.cpp:
3:44 PM Changeset in webkit [12242] by thatcher
  • 1 delete in branches/Safari-Leo-branch

Redoing this branch so we only include Info.plists

3:08 PM Changeset in webkit [12241] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/report-include-statistics: Added a new script.
1:42 PM Changeset in webkit [12240] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Misc.subproj/WebNSURLExtras.h: added declaration of _webkit_rangeOfURLScheme so Safari can call it as a step towards weaning Safari from Foundation SPI.
11:45 AM Changeset in webkit [12239] by thatcher
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: include JavaScriptGlue in the build
10:57 AM Changeset in webkit [12238] by darin
  • 1 edit in trunk/Makefile

Build JavaScriptGlue.

9:14 AM Changeset in webkit [12237] by andersca
  • 7 edits in trunk

2006-01-19 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): if getCSSPropertyValue returns 0 (which is true for shorthand properties), try getPropertyValue instead.
1:35 AM Changeset in webkit [12236] by adele
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt and Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6665
Implement NSView-less version of <input type="text">


Initial implementation of new and improved text fields.
This will only be turned on if an input element has khtml-appearance: textfield.

  • WebCore.xcodeproj/project.pbxproj: Added RenderTextField.h and RenderTextField.cpp
  • css/cssvalues.in: Fixed omitted button-bevel value. This was causing an off-by-one error when getting khtml-appearance value.
  • khtml/html/HTMLInputElementImpl.cpp: Added checks for khtml-appearance to decide when to use RenderTextField instead of RenderLineEdit. (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::select): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::createRenderer): (DOM::HTMLInputElementImpl::defaultEventHandler):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Also allow editable elements with no parent to be focusable.
  • khtml/xml/NodeImpl.h: (WebCore::NodeImpl::setAttached): Added to set m_attached without having to call attach().
  • rendering/RenderTextField.cpp: Added. (khtml:::RenderBlock): (khtml::RenderTextField::~RenderTextField): (khtml::RenderTextField::addChild): (khtml::RenderTextField::removeChild): (khtml::RenderTextField::setStyle): (khtml::RenderTextField::getDivStyle): (khtml::RenderTextField::updateFromElement): (khtml::RenderTextField::selectionStart): (khtml::RenderTextField::selectionEnd): (khtml::RenderTextField::setSelectionStart): (khtml::RenderTextField::setSelectionEnd): (khtml::RenderTextField::select): (khtml::RenderTextField::setSelectionRange):
  • rendering/RenderTextField.h: Added. (khtml::RenderTextField::removeLeftoverAnonymousBoxes): (khtml::RenderTextField::renderName):
  • rendering/render_container.cpp: (RenderContainer::destroy): use renamed destroyLeftoverChildren. (RenderContainer::destroyLeftoverChildren): renamed from destroyLeftoverAnonymousChildren.
  • rendering/render_container.h:
  • rendering/render_flow.cpp: (RenderFlow::destroy): use renamed destroyLeftoverChildren.
1:20 AM Changeset in webkit [12235] by eseidel
  • 5 edits
    4 adds in trunk

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin & anders.

Fix opacity crasher for <text> and <image>.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6668
Even though the crash is fixed, opacity still doesn't work.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6669

  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint):
1:18 AM Changeset in webkit [12234] by darin
  • 21 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Changed SVG check to work even if the path has spaces in it by using the form of open that treats each argument as a string rather than backtick syntax for reading the output of the nm tool.
12:59 AM Changeset in webkit [12233] by darin
  • 43 edits
    4 deletes in trunk/WebCore

Reviewed by Hyatt.

  • removed all use of QMap
  • ForwardingHeaders/qmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQMap.h, KWQMapImpl.h, KWQMapImpl.cpp.
  • kwq/KWQMap.h: Removed.
  • kwq/KWQMapImpl.cpp: Removed.
  • kwq/KWQMapImpl.h: Removed.
  • bridge/BrowserExtension.h: (WebCore::URLArgs::metaData): Converted from QMap of QString to HashMap of DOMString.
  • bridge/mac/BrowserExtensionMac.mm: Ditto.
  • bridge/mac/MacFrame.mm: (MacFrame::openURLRequest): Ditto. (MacFrame::urlSelected): Ditto. (MacFrame::createPart): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::showModalDialog): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::createRenderer): Ditto.
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet): Ditto.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::toString): Added. Converts to DOMString instead of QString. (WebCore::attributesStartElementNsHandler): Converted from QMap of QString to HashMap of DOMString. (WebCore::parseAttributes): Ditto.
  • khtml/xml/xml_tokenizer.h: (WebCore::Tokenizer::setTransformSource): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll): Ditto.
  • kwq/KWQKJavaAppletWidget.h: Ditto.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): Ditto.
  • kwq/KWQKJobClasses.h: Ditto.
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::addMetaData): Ditto.
  • page/Frame.cpp: (Frame::didOpenURL): Ditto. (Frame::changeLocation): Ditto. (Frame::mark): Ditto. (Frame::setMark): Ditto. (Frame::urlSelected): Ditto. (Frame::requestObject): Ditto. (Frame::processObjectRequest): Ditto. (Frame::submitForm): Ditto.
  • rendering/render_applet.cpp: (WebCore::RenderApplet::RenderApplet): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto. (WebCore::RenderApplet::layout): Ditto.
  • rendering/render_applet.h: (WebCore::RenderApplet::renderName): Ditto. (WebCore::RenderApplet::element): Ditto. (WebCore::RenderEmptyApplet::renderName): Ditto.
  • khtml/dom/dom_string.h: (WebCore::DOMString::createCFString): Added. Not yet implemented or used. (WebCore::DOMString::operator NSString*): Updated to call through to DOMStringImpl. Added hash functions and hash traits so you can use DOMString in hash tables.
  • khtml/xml/dom_stringimpl.h: Added conversion to and from CFStringRef/NSString.
  • khtml/xml/dom_stringimpl.cpp: Took out an excess "DOM::".
  • bindings/objc/DOMInternal.mm: (DOMStringImpl::operator NSString *): Moved from DOMString to DOMStringImpl.
  • changed the mark from a SelectionController to a Selection (maybe it can be a Position instead?)
  • page/Frame.h: Changed mark() and setMark() to use a Selection.
  • page/FramePrivate.h: Changed mark to a Selection.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setMarkDOMRange:]): Updated for change from SelectionController to Selection.
  • removed extraneous includes
  • kwq/KWQKHTMLSettings.h: Removed include of "KWQMap.h".
  • kwq/KWQKIOGlobal.h: Ditto.
  • khtml/editing/htmlediting.h: Removed extraneous includes and namespace prefixes.
  • khtml/html/html_canvasimpl.h: Removed extraneous includes and moved into the WebCore namespace.
  • khtml/html/html_canvasimpl.cpp: Ditto.
  • khtml/html/htmltokenizer.cpp: Ditto.
  • khtml/html/htmltokenizer.h: Ditto.
  • khtml/xml/DocumentImpl.cpp: Ditto.
  • kwq/KWQEditCommand.mm: Ditto.
  • rendering/render_canvasimage.h: Ditto.
  • rendering/render_image.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Updated includes because of ones that were removed from headers.
  • khtml/editing/htmlediting.cpp: Ditto.
  • khtml/editing/jsediting.cpp: Ditto.
  • khtml/editing/replace_selection_command.cpp: Ditto.
  • rendering/render_canvasimage.cpp: Ditto.
  • rendering/render_image.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Removed code to add the cache control string, since that was hardcoded to empty string anyway.
12:59 AM Changeset in webkit [12232] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Hyatt.

  • hash table fixes needed for my WebCore changes
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator=): Added a missing return statement.
  • kxmlcore/HashTraits.h: Fix traits so they work properly for classes where you can't instantiate with a 0 by using traits rather than ? : to select the default emtpy value of hash table keys.
  • small cleanup of "runtime" code left over from recent JavaScript crash fix
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::RootObject): No explicit initialization of _imp needed since it's now a ProtectedPtr. (KJS::Bindings::RootObject::setRootObjectImp): Remove old code that relied on the fact that _imp was 0 and replaced with use of ProtectedPtr. (KJS::Bindings::RootObject::rootObjectImp): Updated since _imp is a ProtectedPtr.
12:16 AM Changeset in webkit [12231] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove CFDictionary usage from KWQObject.*
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6468

  • kwq/KWQObject.cpp: (KWQObjectTimer::KWQObjectTimer): (QObject::restartTimer): (QObject::timerIntervals): (KWQObjectTimer::deleteTimer): (QObject::killTimer): (QObject::killTimers): (sendDeferredTimerEvent):

Jan 18, 2006:

10:46 PM Changeset in webkit [12230] by hyatt
  • 56 edits in trunk

Rename KHTMLView to FrameView (since it's been moved to a file called FrameView already).

6:40 PM Changeset in webkit [12229] by thatcher
  • 15 edits
    1 add in trunk/JavaScriptGlue

Adding the license header to all files so we can
move JavaScriptGlue into the open source repository.

  • LICENSE: Added.
  • JSBase.cpp: license header added.
  • JSBase.h: ditto.
  • JSObject.cpp: ditto.
  • JSObject.h: ditto.
  • JSRun.cpp: ditto.
  • JSRun.h: ditto.
  • JSUtils.cpp: ditto.
  • JSUtils.h: ditto.
  • JSValueWrapper.cpp: ditto.
  • JSValueWrapper.h: ditto.
  • JavaScriptGlue.cpp: ditto.
  • JavaScriptGlue.h: ditto.
  • UserObjectImp.cpp: ditto.
  • UserObjectImp.h: ditto.
5:59 PM Changeset in webkit [12190] by thatcher
  • 1 move in tags/WebCore-417.19

Fix a typo.

5:54 PM Changeset in webkit [12189] by thatcher
  • 1 copy in tags/WebCore-417.9/WebCore

Tag for WebCore-417.9

5:53 PM Changeset in webkit [12188] by thatcher
  • 1 add in tags/WebCore-417.9

Tag directory for WebCore-417.9

5:43 PM Changeset in webkit [12187] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to 417.19.

5:34 PM Changeset in webkit [12186] by thatcher
  • 2 edits
    5 adds
    16 deletes in branches/Safari-2-0-branch
  • Removing the .cvsignore on the branch.
  • Added the new Makefiles.
5:30 PM Changeset in webkit [12185] by thatcher
  • 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-01-17 Beth Dakin <Beth Dakin>

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.

  • khtml/html/HTMLInputElementImpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): If the click is simulated, set xPos and yPos to 0.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Fix spacing. (HTMLElementImpl::click): It isn't necessary to check if there is a renderer.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTest): Call updateLayout().
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchSimulatedMouseEvent): Set isSimulated to true. (WebCore::NodeImpl::dispatchMouseEvent): Keep track of isSimulated.
  • khtml/xml/NodeImpl.h: Same.
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Add isSimulated to MouseRelatedEventImpl(). (DOM::MouseRelatedEventImpl::computePositions): Only change the offsets if it's not simulated. (DOM::MouseEventImpl::MouseEventImpl): Add isSimulated to MouseEventImpl()
  • khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::isSimulated): Declarations of isSimulated (DOM::MouseEventImpl::isSimulated): Same.
4:59 PM Changeset in webkit [12184] by hyatt
  • 1 edit in trunk/WebCore/page/Frame.h

It's called pure virtual for a reason. (Fingers crossed.)

4:51 PM Changeset in webkit [12183] by hyatt
  • 2 edits in trunk/WebCore

Umm. Yeah. Let's try making BrowserExtensionMac actually declare and use a class called BrowserExtensionMac.

4:43 PM Changeset in webkit [12182] by hyatt
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.mm

Remove KParts using from WebCoreFrameBridge.mm (yes, more bustage).

4:39 PM Changeset in webkit [12181] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

Make sure FrameView includes MacFrame.h on mac only.

4:30 PM Changeset in webkit [12180] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

More Mac build bustage. Fix the dashboard region call to still cast to MacFrame.

4:15 PM Changeset in webkit [12179] by hyatt
  • 3 edits in trunk/WebCore

OMG I BROKE THE MAC. (Fixed)

3:59 PM Changeset in webkit [12178] by hyatt
  • 30 edits
    3 moves
    2 deletes in trunk/WebCore

Eliminate uses of MacFrame in cross-platform code.

1:14 PM Changeset in webkit [12177] by hyatt
  • 3 edits in trunk/WebCore/kwq

Make the signals/stubs/slots compile on Win32 by removing #imports.

1:12 PM Changeset in webkit [12176] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • change KWQList to use qsort instead of CFArraySort
  • kwq/KWQListImpl.cpp: (compareFuncWrapper): Wrapper that uses global variables to overcome the lack of a "data" pointer in qsort. Could have used qsort_r but that would be less portable. (KWQListImpl::sort): Use qsort instead of CFArraySortValues.
12:19 PM Changeset in webkit [12175] by darin
  • 4 edits
    3 moves in trunk/WebCore

Reviewed by Beth.

  • changed the three signal/slot related files from ObjC++ to C++ files
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQSignal.cpp: Added.
  • kwq/KWQSignal.mm: Removed.
  • kwq/KWQSignalStubs.cpp: Added.
  • kwq/KWQSignalStubs.mm: Removed.
  • kwq/KWQSlot.cpp: Added.
  • kwq/KWQSlot.mm: Removed.
11:48 AM Changeset in webkit [12174] by hyatt
  • 2 edits in trunk/WebCore

Add KWQListImpl.cpp to Win32 but ifdef out all the LAME LAME LAME CF dependencies.

11:41 AM Changeset in webkit [12173] by thatcher
  • 11 edits
    2 adds in branches/Safari-2-0-branch/LayoutTests

Fix for binary files.

11:31 AM Changeset in webkit [12172] by hyatt
  • 3 edits in trunk/JavaScriptCore

Make testkjs.exe compile without warnings.

11:31 AM Changeset in webkit [12171] by hyatt
  • 5 edits in trunk/WebCore

Make Win32 WebCore build again.

9:19 AM Changeset in webkit [12170] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar.html: Added.

WebCore:

Test: fast/overflow/overflow-rtl-inline-scrollbar.html

Reviewed by Hyatt.



Inline flows were always returning 0 for leftmostPosition(). Their real leftmost
edges are determined by their inline boxes, which
RenderBlock::leftmostPosition already takes into account.

  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't descend into inline flows. (RenderFlow::rightmostPosition): Ditto. (RenderFlow::leftmostPosition): Ditto.
8:51 AM Changeset in webkit [12169] by andersca
  • 3 edits in trunk/WebCore

2006-01-18 Anders Carlsson <​andersca@mac.com>

Fix build.


  • khtml/ecma/kjs_navigator.cpp:
  • page/FrameView.cpp: Remove kstandarddirs.h includes.
12:57 AM Changeset in webkit [12168] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fixed change log.

12:56 AM Changeset in webkit [12167] by darin
  • 8 edits
    1 move
    2 adds
    6 deletes in trunk/WebCore

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • css/make-css-file-arrays.pl: Added. Used to generate C array forms of the ".css" files.
  • css/UserAgentStyleSheets.cpp: Added. Used to indirectly compile the generated file.
  • WebCore.xcodeproj/project.pbxproj: Added new source files. Added a build phase to invoke the make-css-file-arrays.pl script. Removed the .css files, which no longer need to be installed as part of the final package.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Removed code to read user agent sheets from disk. Replaced with code that gets them from compiled-in arrays instead. Uses a pretty lame DOMString hack that could be reworked some day. (WebCore::CSSStyleSelector::loadDefaultStyle): Change to load from arrays intead of disk.
  • css/html4.css: Added missing license header, tweaked format a bit.
  • css/quirks.css: Added missing license header, tweaked format.
  • css/svg.css: Moved from ksvg2/css directory.
  • ksvg2/css/svg.css: Moved to top level css directory.
  • page/Frame.cpp: Removed includes of qfile.h and kstandarddirs.h.
  • ForwardingHeaders/kstandarddirs.h: Removed.
  • ForwardingHeaders/qfile.h: Removed.
  • kwq/KWQFile.h: Removed.
  • kwq/KWQFile.mm: Removed.
  • kwq/KWQKStandardDirs.h: Removed.
  • kwq/KWQKStandardDirs.mm: Removed.

Jan 17, 2006:

10:41 PM Changeset in webkit [12166] by darin
  • 8 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

  • Remove the now-unused KRenderingPaintServerImage[Quartz].
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
  • kcanvas/device/KRenderingPaintServerImage.h: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • kwq/KWQPainter.mm:
10:16 PM Changeset in webkit [12165] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • bridge/mac/MacFrame.mm: (MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled. (MacFrame::windowScriptObject): Return 0 if JavaScript is disabled. (MacFrame::windowScriptNPObject): Ditto. (MacFrame::partClearedInBegin): Don't call the "window script object available" call if JavaScript is disabled.
9:55 PM Changeset in webkit [12164] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin


Layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclink

9:53 PM Changeset in webkit [12163] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclinks.html


Layout test added:

  • editing/selection/after-line-wrap.html
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): Don't stop at the first candidate, it may be visually equivalent to the original position.
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): Don't move to a position on a different line. (DOM::Position::downstream): Ditto.
8:33 PM Changeset in webkit [12162] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/HashTable.h: (KXMLCore::addIterator): Added. Helper function that adds an iterator to the list maintained by the specified hash table. (KXMLCore::removeIterator): Added. Helper function that removes an iterator from the list maintained by the hash table it's in. (KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable parameter, ignored when not debugging. Call addIterator. (KXMLCore::HashTableConstIterator::~HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator=): Call removeIterator. (KXMLCore::HashTableConstIterator::operator*): Call checkValidity. (KXMLCore::HashTableConstIterator::operator->): Ditto. (KXMLCore::HashTableConstIterator::operator++): Ditto. (KXMLCore::HashTableConstIterator::operator==): Ditto. (KXMLCore::HashTableConstIterator::operator!=): Ditto. (KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table pointer is not 0 and if there are two iterators that both point at the same table. (KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator as an implementation detail, to avoid having two separate iterator implementations. (KXMLCore::HashTableIterator::operator*): Ditto. (KXMLCore::HashTableIterator::operator->): Ditto. (KXMLCore::HashTableIterator::operator++): Ditto. (KXMLCore::HashTableIterator::operator==): Ditto. (KXMLCore::HashTableIterator::operator!=): Ditto. (KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list. (KXMLCore::HashTable::~HashTable): Added call to invalidateIterators. (KXMLCore::HashTable::makeIterator): Pass this pointer. (KXMLCore::HashTable::makeConstIterator): Ditto. (KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public entry point that modifies the hash table. (KXMLCore::HashTable::remove): Ditto. (KXMLCore::HashTable::clear): Ditto. (KXMLCore::HashTable::swap): Ditto. (KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and clears out the table, next, and previous pointers in all of them, and then clears the head so we have an empty list. (KXMLCore::addIterator): Added. Adds the iterator the the linked list in the passed-in table, and points the iterator at the table. (KXMLCore::removeIterator): Added. Removes the iterator from the linked list in the passed-in table.
  • kxmlcore/HashTraits.h: A bit of tweaking and formatting.
8:16 PM Changeset in webkit [12161] by justing
  • 7 edits in trunk

Deployment builds now use -O2

5:33 PM Changeset in webkit [12160] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects

The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.

5:18 PM Changeset in webkit [12159] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for <rdar://problem/4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232

3:56 PM Changeset in webkit [12158] by thatcher
  • 269 adds in trunk/WebKitSite

Moving the webkit.opendarwin.org site into our Subversion repository.

2:49 PM Changeset in webkit [12157] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix group path for rendering in project file.

2:46 PM Changeset in webkit [12156] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage caused by my partial commit.

1:07 PM Changeset in webkit [12155] by hyatt
  • 2 edits
    63 copies
    1 add
    1 delete in trunk/WebCore

Move khtml/rendering to WebCore/rendering.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/rendering: Removed.
  • khtml/rendering/DataRef.h: Removed.
  • khtml/rendering/InlineTextBox.cpp: Removed.
  • khtml/rendering/InlineTextBox.h: Removed.
  • khtml/rendering/RenderText.cpp: Removed.
  • khtml/rendering/RenderText.h: Removed.
  • khtml/rendering/RenderTextFragment.cpp: Removed.
  • khtml/rendering/RenderTextFragment.h: Removed.
  • khtml/rendering/bidi.cpp: Removed.
  • khtml/rendering/bidi.h: Removed.
  • khtml/rendering/break_lines.cpp: Removed.
  • khtml/rendering/break_lines.h: Removed.
  • khtml/rendering/font.cpp: Removed.
  • khtml/rendering/font.h: Removed.
  • khtml/rendering/render_applet.cpp: Removed.
  • khtml/rendering/render_applet.h: Removed.
  • khtml/rendering/render_arena.cpp: Removed.
  • khtml/rendering/render_arena.h: Removed.
  • khtml/rendering/render_block.cpp: Removed.
  • khtml/rendering/render_block.h: Removed.
  • khtml/rendering/render_box.cpp: Removed.
  • khtml/rendering/render_box.h: Removed.
  • khtml/rendering/render_br.cpp: Removed.
  • khtml/rendering/render_br.h: Removed.
  • khtml/rendering/render_button.cpp: Removed.
  • khtml/rendering/render_button.h: Removed.
  • khtml/rendering/render_canvas.cpp: Removed.
  • khtml/rendering/render_canvas.h: Removed.
  • khtml/rendering/render_canvasimage.cpp: Removed.
  • khtml/rendering/render_canvasimage.h: Removed.
  • khtml/rendering/render_container.cpp: Removed.
  • khtml/rendering/render_container.h: Removed.
  • khtml/rendering/render_flexbox.cpp: Removed.
  • khtml/rendering/render_flexbox.h: Removed.
  • khtml/rendering/render_flow.cpp: Removed.
  • khtml/rendering/render_flow.h: Removed.
  • khtml/rendering/render_form.cpp: Removed.
  • khtml/rendering/render_form.h: Removed.
  • khtml/rendering/render_frames.cpp: Removed.
  • khtml/rendering/render_frames.h: Removed.
  • khtml/rendering/render_image.cpp: Removed.
  • khtml/rendering/render_image.h: Removed.
  • khtml/rendering/render_inline.cpp: Removed.
  • khtml/rendering/render_inline.h: Removed.
  • khtml/rendering/render_layer.cpp: Removed.
  • khtml/rendering/render_layer.h: Removed.
  • khtml/rendering/render_line.cpp: Removed.
  • khtml/rendering/render_line.h: Removed.
  • khtml/rendering/render_list.cpp: Removed.
  • khtml/rendering/render_list.h: Removed.
  • khtml/rendering/render_object.cpp: Removed.
  • khtml/rendering/render_object.h: Removed.
  • khtml/rendering/render_replaced.cpp: Removed.
  • khtml/rendering/render_replaced.h: Removed.
  • khtml/rendering/render_style.cpp: Removed.
  • khtml/rendering/render_style.h: Removed.
  • khtml/rendering/render_table.cpp: Removed.
  • khtml/rendering/render_table.h: Removed.
  • khtml/rendering/render_theme.cpp: Removed.
  • khtml/rendering/render_theme.h: Removed.
  • khtml/rendering/render_theme_mac.h: Removed.
  • khtml/rendering/render_theme_mac.mm: Removed.
  • khtml/rendering/table_layout.cpp: Removed.
  • khtml/rendering/table_layout.h: Removed.
  • rendering: Added.
  • rendering/DataRef.h: Added.
  • rendering/InlineTextBox.cpp: Added.
  • rendering/InlineTextBox.h: Added.
  • rendering/RenderText.cpp: Added.
  • rendering/RenderText.h: Added.
  • rendering/RenderTextFragment.cpp: Added.
  • rendering/RenderTextFragment.h: Added.
  • rendering/bidi.cpp: Added.
  • rendering/bidi.h: Added.
  • rendering/break_lines.cpp: Added.
  • rendering/break_lines.h: Added.
  • rendering/font.cpp: Added.
  • rendering/font.h: Added.
  • rendering/render_applet.cpp: Added.
  • rendering/render_applet.h: Added.
  • rendering/render_arena.cpp: Added.
  • rendering/render_arena.h: Added.
  • rendering/render_block.cpp: Added.
  • rendering/render_block.h: Added.
  • rendering/render_box.cpp: Added.
  • rendering/render_box.h: Added.
  • rendering/render_br.cpp: Added.
  • rendering/render_br.h: Added.
  • rendering/render_button.cpp: Added.
  • rendering/render_button.h: Added.
  • rendering/render_canvas.cpp: Added.
  • rendering/render_canvas.h: Added.
  • rendering/render_canvasimage.cpp: Added.
  • rendering/render_canvasimage.h: Added.
  • rendering/render_container.cpp: Added.
  • rendering/render_container.h: Added.
  • rendering/render_flexbox.cpp: Added.
  • rendering/render_flexbox.h: Added.
  • rendering/render_flow.cpp: Added.
  • rendering/render_flow.h: Added.
  • rendering/render_form.cpp: Added.
  • rendering/render_form.h: Added.
  • rendering/render_frames.cpp: Added.
  • rendering/render_frames.h: Added.
  • rendering/render_image.cpp: Added.
  • rendering/render_image.h: Added.
  • rendering/render_inline.cpp: Added.
  • rendering/render_inline.h: Added.
  • rendering/render_layer.cpp: Added.
  • rendering/render_layer.h: Added.
  • rendering/render_line.cpp: Added.
  • rendering/render_line.h: Added.
  • rendering/render_list.cpp: Added.
  • rendering/render_list.h: Added.
  • rendering/render_object.cpp: Added.
  • rendering/render_object.h: Added.
  • rendering/render_replaced.cpp: Added.
  • rendering/render_replaced.h: Added.
  • rendering/render_style.cpp: Added.
  • rendering/render_style.h: Added.
  • rendering/render_table.cpp: Added.
  • rendering/render_table.h: Added.
  • rendering/render_theme.cpp: Added.
  • rendering/render_theme.h: Added.
  • rendering/render_theme_mac.h: Added.
  • rendering/render_theme_mac.mm: Added.
  • rendering/table_layout.cpp: Added.
  • rendering/table_layout.h: Added.
12:52 PM Changeset in webkit [12154] by hyatt
  • 3 edits in trunk/WebCore

Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.


Reviewed by xenon

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMAttr::getValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMAttr::):
11:40 AM Changeset in webkit [12153] by bdakin
  • 8 edits in trunk/WebCore

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`

10:14 AM Changeset in webkit [12152] by ap
  • 21 edits in trunk/WebCore

Patch by Duncan Wilcox, reviewed by Darin.

This patch replaces the use of SelectionController with Selection in the edit commands.

It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.

9:35 AM Changeset in webkit [12151] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/generic-form-element-assert.html: Added.
  • fast/dom/generic-form-element-assert-expected.txt: Added.

WebCore:

Test: fast/dom/generic-form-element-assert.html

Reviewed and reworked by Darin.


  • khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces a bit. Removed unneeded includes. (WebCore::findRoot): Added helper function. (WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check in a simpler way, since the two separate cases amounted to the same check.
9:29 AM Changeset in webkit [12150] by darin
  • 2 edits in trunk/JavaScriptCore/kxmlcore

Updated copyright dates (oops, forgot).

9:28 AM Changeset in webkit [12149] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/PassRefPtr.h: Always set m_ptr before calling deref.
  • kxmlcore/RefPtr.h: Ditto.
1:00 AM Changeset in webkit [12148] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

Fix second part of WebCore-no-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Mark three headers as private rather than project in the WebCore-no-SVG target.

Jan 16, 2006:

11:39 PM Changeset in webkit [12147] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by hyatt

  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Assign the new item to index m_count, not m_size.
10:53 PM Changeset in webkit [12146] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

WebCore-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new files omitted from the target.
10:50 PM Changeset in webkit [12145] by eseidel
  • 2 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Fixed test case to remove invisible chars (thus fixing test).

  • svg/custom/recursive-clippath.svg:
9:41 PM Changeset in webkit [12144] by hyatt
  • 19 edits
    25 copies
    1 add
    2 deletes in trunk/WebCore

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

  • ForwardingHeaders/kdom/css: Removed.
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
  • ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
  • ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
  • WebCore+SVG/RGBColorImpl.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • css: Added.
  • css/css_base.cpp: Added.
  • css/css_base.h: Added.
  • css/css_computedstyle.cpp: Added.
  • css/css_computedstyle.h: Added.
  • css/css_grammar.y: Added.
  • css/css_ruleimpl.cpp: Added.
  • css/css_ruleimpl.h: Added.
  • css/css_stylesheetimpl.cpp: Added.
  • css/css_stylesheetimpl.h: Added.
  • css/css_valueimpl.cpp: Added.
  • css/css_valueimpl.h: Added.
  • css/csshelper.cpp: Added.
  • css/csshelper.h: Added.
  • css/cssparser.cpp: Added.
  • css/cssparser.h: Added.
  • css/cssproperties.in: Added.
  • css/cssstyleselector.cpp: Added.
  • css/cssstyleselector.h: Added.
  • css/cssvalues.in: Added.
  • css/html4.css: Added.
  • css/makeprop: Added.
  • css/maketokenizer: Added.
  • css/makevalues: Added.
  • css/quirks.css: Added.
  • css/tokenizer.flex: Added.
  • khtml/css: Removed.
  • khtml/css/css_base.cpp: Removed.
  • khtml/css/css_base.h: Removed.
  • khtml/css/css_computedstyle.cpp: Removed.
  • khtml/css/css_computedstyle.h: Removed.
  • khtml/css/css_grammar.y: Removed.
  • khtml/css/css_ruleimpl.cpp: Removed.
  • khtml/css/css_ruleimpl.h: Removed.
  • khtml/css/css_stylesheetimpl.cpp: Removed.
  • khtml/css/css_stylesheetimpl.h: Removed.
  • khtml/css/css_valueimpl.cpp: Removed.
  • khtml/css/css_valueimpl.h: Removed.
  • khtml/css/csshelper.cpp: Removed.
  • khtml/css/csshelper.h: Removed.
  • khtml/css/cssparser.cpp: Removed.
  • khtml/css/cssparser.h: Removed.
  • khtml/css/cssproperties.in: Removed.
  • khtml/css/cssstyleselector.cpp: Removed.
  • khtml/css/cssstyleselector.h: Removed.
  • khtml/css/cssvalues.in: Removed.
  • khtml/css/html4.css: Removed.
  • khtml/css/makeprop: Removed.
  • khtml/css/maketokenizer: Removed.
  • khtml/css/makevalues: Removed.
  • khtml/css/quirks.css: Removed.
  • khtml/css/tokenizer.flex: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGMaskElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
9:41 PM Changeset in webkit [12143] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):
6:37 PM Changeset in webkit [12142] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

  • svg/custom/recursive-clippath-expected.checksum: Added.
  • svg/custom/recursive-clippath-expected.png: Added.
  • svg/custom/recursive-clippath-expected.txt: Added.
  • svg/custom/recursive-clippath.svg: Added.
6:20 PM Changeset in webkit [12141] by ggaren
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

  • fast/js/date-proto-generic-invocation-expected.txt: Added.
  • fast/js/date-proto-generic-invocation.html: Added.
  • fast/js/resources/date-proto-generic-invocation.js: Added.
4:35 PM Changeset in webkit [12140] by hyatt
  • 2 edits
    22 moves
    3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bindings: Added.
  • bindings/js: Added.
  • bindings/objc: Added.
  • bindings/objc/DOM.h: Added.
  • bindings/objc/DOM.mm: Added.
  • bindings/objc/DOMCSS.h: Added.
  • bindings/objc/DOMCSS.mm: Added.
  • bindings/objc/DOMCore.h: Added.
  • bindings/objc/DOMEvents.h: Added.
  • bindings/objc/DOMEvents.mm: Added.
  • bindings/objc/DOMEventsInternal.h: Added.
  • bindings/objc/DOMExtensions.h: Added.
  • bindings/objc/DOMHTML.h: Added.
  • bindings/objc/DOMHTML.mm: Added.
  • bindings/objc/DOMHTMLInternal.h: Added.
  • bindings/objc/DOMInternal.h: Added.
  • bindings/objc/DOMInternal.mm: Added.
  • bindings/objc/DOMPrivate.h: Added.
  • bindings/objc/DOMRange.h: Added.
  • bindings/objc/DOMStylesheets.h: Added.
  • bindings/objc/DOMTraversal.h: Added.
  • bindings/objc/DOMUtility.mm: Added.
  • bindings/objc/DOMViews.h: Added.
  • bindings/objc/DOMViews.mm: Added.
  • bindings/objc/DOMViewsInternal.h: Added.
  • kwq/DOM-CSS.mm: Removed.
  • kwq/DOM.h: Removed.
  • kwq/DOM.mm: Removed.
  • kwq/DOMCSS.h: Removed.
  • kwq/DOMCore.h: Removed.
  • kwq/DOMEvents.h: Removed.
  • kwq/DOMEvents.mm: Removed.
  • kwq/DOMEventsInternal.h: Removed.
  • kwq/DOMExtensions.h: Removed.
  • kwq/DOMHTML.h: Removed.
  • kwq/DOMHTML.mm: Removed.
  • kwq/DOMHTMLInternal.h: Removed.
  • kwq/DOMInternal.h: Removed.
  • kwq/DOMInternal.mm: Removed.
  • kwq/DOMPrivate.h: Removed.
  • kwq/DOMRange.h: Removed.
  • kwq/DOMStylesheets.h: Removed.
  • kwq/DOMTraversal.h: Removed.
  • kwq/DOMUtility.mm: Removed.
  • kwq/DOMViews.h: Removed.
  • kwq/DOMViews.mm: Removed.
  • kwq/DOMViewsInternal.h: Removed.
3:43 PM Changeset in webkit [12139] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca
  • 4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.


  • WebInspector.subproj/webInspector/inspector.css:
  • WebInspector.subproj/webInspector/inspector.html:
  • WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.
2:25 PM Changeset in webkit [12137] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley.


  • fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
2:01 PM Changeset in webkit [12136] by ap
  • 4 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

  • khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
  • manual-tests/bugzilla-6473.html: Added.
1:46 PM Changeset in webkit [12135] by ap
  • 2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.
12:34 PM Changeset in webkit [12134] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Justin.

Test: editing/input/wrapped-line-char-rect.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start
12:25 PM Changeset in webkit [12133] by justing
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

  • editing/selection/replaced-boundaries-1-expected.checksum: Added.
  • editing/selection/replaced-boundaries-1-expected.png: Added.
  • editing/selection/replaced-boundaries-1-expected.txt: Added.
  • editing/selection/replaced-boundaries-1.html: Added.
  • editing/selection/replaced-boundaries-2-expected.checksum: Added.
  • editing/selection/replaced-boundaries-2-expected.png: Added.
  • editing/selection/replaced-boundaries-2-expected.txt: Added.
  • editing/selection/replaced-boundaries-2.html: Added.
  • editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • editing/selection/replaced-boundaries-3-expected.png: Added.
  • editing/selection/replaced-boundaries-3-expected.txt: Added.
  • editing/selection/replaced-boundaries-3.html: Added.
12:24 PM Changeset in webkit [12132] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)


Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
  • khtml/rendering/render_replaced.h:
12:04 PM Changeset in webkit [12131] by tomernic
  • 7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • actually removed QPtrDict itself
  • ForwardingHeaders/qptrdict.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
  • kwq/KWQPtrDict.h: Removed.
  • kwq/KWQPtrDictImpl.cpp: Removed.
  • kwq/KWQPtrDictImpl.h: Removed.
9:52 AM Changeset in webkit [12129] by darin
  • 83 edits in trunk/WebCore

Reviewed by John Sullivan.

  • removed all uses of QPtrDict, most uses of QMap
  • khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
  • khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
  • khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
  • khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
  • khtml/ecma/kjs_window.h: Use HashMap.
  • khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
  • khtml/ecma/xmlhttprequest.h: Ditto.
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
  • khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
  • khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
  • khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
  • khtml/xml/dom_elementimpl.h: Use HashMap.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
  • khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.
  • khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
  • khtml/xml/dom_stringimpl.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
  • kcanvas/RenderForeignObject.cpp: Ditto.
  • kcanvas/RenderForeignObject.h: Ditto.
  • kcanvas/RenderSVGImage.h: Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
  • khtml/css/css_ruleimpl.cpp: Ditto.
  • khtml/css/css_valueimpl.h: Ditto.
  • khtml/ecma/kjs_dom.h: Ditto.
  • khtml/ecma/kjs_html.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Ditto.
  • khtml/editing/delete_selection_command.cpp: Ditto.
  • khtml/html/html_tableimpl.cpp: Ditto.
  • khtml/khtml_events.cpp: Ditto.
  • khtml/rendering/RenderText.cpp: Ditto.
  • khtml/rendering/render_block.cpp: Ditto.
  • khtml/rendering/render_br.cpp: Ditto.
  • khtml/rendering/render_inline.cpp: Ditto.
  • khtml/rendering/render_object.cpp: Ditto.
  • khtml/rendering/render_replaced.cpp: Ditto.
  • khtml/xml/dom2_rangeimpl.cpp: Ditto.
  • kwq/DOM.mm: Ditto.
  • page/Frame.cpp: Ditto.
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
  • kcanvas/RenderSVGText.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
  • khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
  • khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.
  • khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
  • khtml/xml/dom_xmlimpl.h: Ditto.
  • ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
  • ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
  • ksvg2/svg/SVGPointImpl.cpp: Ditto.
  • kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.
  • kwq/KWQPainter.h: Added newly-needed include.
  • kwq/KWQPtrVector.h: Added append function.
  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
  • kwq/KWQVectorImpl.h: Added append.
  • kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.
  • kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
  • kwq/KWQWMatrix.h: Ditto.
  • loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.
  • loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
  • loader/CachedCSSStyleSheet.h: Ditto.
  • loader/CachedImage.cpp: Ditto.
  • loader/CachedImage.h: Ditto.
  • loader/CachedImageCallback.cpp: Ditto.
  • loader/CachedObject.cpp: Ditto.
  • loader/CachedObject.h: Ditto.
  • loader/CachedObjectClient.h: Ditto.
  • loader/CachedObjectClientWalker.cpp: Ditto.
  • loader/CachedObjectClientWalker.h: Ditto.
  • loader/CachedScript.cpp: Ditto.
  • loader/CachedScript.h: Ditto.
  • loader/CachedXSLStyleSheet.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
  • loader/loader.h: Ditto.
1:03 AM Changeset in webkit [12128] by eseidel
  • 5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

  • fast/box-sizing/percentage-height-expected.checksum:
  • fast/box-sizing/percentage-height-expected.png:
  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
12:49 AM Changeset in webkit [12127] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.
12:30 AM Changeset in webkit [12126] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.
12:05 AM Changeset in webkit [12125] by andersca
  • 2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.

Jan 15, 2006:

11:50 PM Changeset in webkit [12124] by eseidel
  • 3 edits in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Update out-of-date pixel results.

  • fast/dom/dom-parse-serialize-expected.checksum:
  • fast/dom/dom-parse-serialize-expected.png:
6:45 PM Changeset in webkit [12123] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
6:42 PM Changeset in webkit [12122] by thatcher
  • 24 edits
    38 adds in trunk

WebCore:

Reviewed by Darin.

Support for the new DOM Inspector.

  • khtml/ecma/kjs_dom.cpp: exposes scrollIntoViewIfNeeded to JS
  • khtml/ecma/kjs_dom.h:
  • khtml/rendering/RenderText.cpp: (RenderText::lineBoxRects): returns text run rects
  • khtml/rendering/RenderText.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::lineBoxRects): returns all child line box rects
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_object.cpp: (RenderObject::lineBoxRects): returns an empty list
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoViewIfNeeded): scrolls only if needed, bool decides to center to align to nearest edge
  • khtml/xml/dom_elementimpl.h: Ditto
  • kwq/DOM.mm: (-[DOMNode boundingBox]): returns the bounding box for a node (-[DOMNode lineBoxRects]): returns text runs for a node
  • kwq/DOMCore.h: added missing @protocol DOMEventListener and @class DOMEvent
  • kwq/DOMExtensions.h: removes methods that haven't been API reviewed
  • kwq/DOMPrivate.h: new pending public API added for the Inspector

WebKit:

Reviewed by Darin.


New DOM Inspector that lives in WebKit and is accessible from any WebView.
Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.


To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6571

5:29 PM Changeset in webkit [12121] by darin
  • 21 edits
    1 move in trunk/WebCore

Reviewed by Eric.

  • changed WebCore namespace change to work on Win32 as well as Mac OS X
  • WebCorePrefix.h: Removed things needed cross-platform.
  • config.h: Moved from khtml subdirectory. Added defines from WebCorePrefix.h, and added a define that makes KSVG a synonym for WebCore.
  • khtml/config.h: Removed.
  • khtml/css/css_grammar.y: Changed SVG functions to use function name rather than namespace to avoid collision with the XML and HTML DOM. Changes tabs to spaces.
  • khtml/css/css_valueimpl.cpp: (WebCore::propertyID): Add SVG properties ot the ones understood here. This allows us to set SVG properties from JavaScript.
  • ksvg2/scripts/cssmakeprops: Put functions inside the namespace to avoid compiler warning, and renamed functions to include CSS and SVG.
  • ksvg2/scripts/cssmakevalues: Ditto.
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::parseMappedAttribute): Use property ID function by its new name.
  • ksvg2/ksvg.h: Renamed ExceptionCode to SVGExceptionCode.
  • khtml/ecma/XSLTProcessor.cpp: Moved "config.h" header up above the ifdef so that the ifdef works.
  • khtml/xbl/xbl_binding.cpp: Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Ditto.
  • khtml/xbl/xbl_docimpl.cpp: Ditto.
  • khtml/xbl/xbl_protobinding.cpp: Ditto.
  • khtml/xbl/xbl_tokenizer.cpp: Ditto.
  • khtml/xsl/xsl_stylesheetimpl.cpp: Ditto.
  • khtml/xsl/xslt_processorimpl.cpp: Ditto.
  • loader/CachedXBLDocument.cpp: Ditto.
  • ksvg2/svg/SVGFELightElementImpl.h: Removed include of "config.h". That's supposed to only be included by code files, not headers.
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added missing include of "config.h". Did a few other tweaks to the file.
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp: Ditto.
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp: Ditto.
4:38 PM Changeset in webkit [12120] by eseidel
  • 19 edits in trunk/WebCore

2006-01-15 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Updated files w/ missing copyrights from Oliver.

  • kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel:
  • kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKPointLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel:
  • ksvg2/svg/SVGAnimatedColorImpl.cpp:
  • ksvg2/svg/SVGAnimatedColorImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp:
  • ksvg2/svg/SVGFEDistantLightElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp:
  • ksvg2/svg/SVGFEPointLightElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp:
  • ksvg2/svg/SVGFESpotLightElementImpl.h:
3:37 PM Changeset in webkit [12119] by darin
  • 2 adds in trunk/WebCore/khtml/editing

Oops, didn't check in these two files!

3:32 PM Changeset in webkit [12118] by darin
  • 23 edits in trunk/WebCore

Reviewed and tweaked a bit by Darin.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6523>
"Extract data from SelectionController"

This patch refactors the data portions of SelectionController into its
own class, "Selection".

The extracted data are the base/extent/start/end positions and cursor
affinity. Also a couple cached values generated by validation are kept around
in the new class.

This patch does away with all the different affinities
(start/end/base/extent) that were never implemented properly, since affinity
only makes sense when the selection is a caret (as per discussion with mjs and
darin on #webkit).

No test cases added because this is a refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::respondToChangedSelection):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionState]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge selectionAffinity]): (-[WebCoreFrameBridge setMarkDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
  • khtml/editing/Selection.cpp: Added. (khtml::Selection::Selection): (khtml::Selection::clear): (khtml::Selection::toRange): (khtml::Selection::validate): (khtml::Selection::adjustForEditableContent): (khtml::Selection::debugPosition):
  • khtml/editing/Selection.h: Added. (khtml::Selection::): (khtml::Selection::state): (khtml::Selection::setAffinity): (khtml::Selection::affinity): (khtml::Selection::setBase): (khtml::Selection::setExtent): (khtml::Selection::setStart): (khtml::Selection::setEnd): (khtml::Selection::base): (khtml::Selection::extent): (khtml::Selection::start): (khtml::Selection::end): (khtml::Selection::isNone): (khtml::Selection::isCaret): (khtml::Selection::isRange): (khtml::Selection::isCaretOrRange): (khtml::Selection::isBaseFirst): (khtml::operator==): (khtml::operator!=):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::operator=): (khtml::SelectionController::moveTo): (khtml::SelectionController::setModifyBias): (khtml::SelectionController::modifyExtendingRightForward): (khtml::SelectionController::modifyMovingRightForward): (khtml::SelectionController::modifyExtendingLeftBackward): (khtml::SelectionController::modifyMovingLeftBackward): (khtml::SelectionController::modify): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::xPosForVerticalArrowNavigation): (khtml::SelectionController::clear): (khtml::SelectionController::setBase): (khtml::SelectionController::setExtent): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::frame): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::needsCaretRepaint): (khtml::SelectionController::paintCaret): (khtml::SelectionController::debugRenderer): (khtml::SelectionController::formatForDebugger): (khtml::SelectionController::showTree):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::state): (khtml::SelectionController::affinity): (khtml::SelectionController::base): (khtml::SelectionController::extent): (khtml::SelectionController::start): (khtml::SelectionController::end): (khtml::SelectionController::isNone): (khtml::SelectionController::isCaret): (khtml::SelectionController::isRange): (khtml::SelectionController::isCaretOrRange): (khtml::SelectionController::toRange): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::operator==):
  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::updateStartEnd):
  • khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::doApply):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::doApply):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::markMisspellingsAfterTyping):
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::updateSelection):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]):
  • kwq/KWQRenderTreeDebug.cpp: (writeSelection):
  • page/Frame.cpp: (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::revealSelection): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart):


  • <a few other files, including editing ones>: Added includes since Selection.h and SelectionController.h now include fewer things.
2:38 PM Changeset in webkit [12117] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-overflow-selection.html


Reviewed by Darin.

  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): Clip selection rect to the text box (khtml::InlineTextBox::paintSelection): Clip selection painting to the text box.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): Remove code that re-added border width, since it is already included in availableWidth.
1:52 PM Changeset in webkit [12116] by darin
  • 16 edits in trunk/WebCore

Reviewed by Anders.

  • fix regression in duplicate ID layout test
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::getElementById): Change to take AtomicString, so we can use the string pointer as a hash key and not worry about ref'ing the pointer or about object lifetime since the string will be stored for the lifetime of the ID attribute. Also update for the counted set formerly named m_idCount to use its new name, m_duplicateIds. (DocumentImpl::addElementById): Ditto. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::recalcStyleSelector): Pass a DOMStringImpl* (see below).
  • khtml/xml/DocumentImpl.h: Change functions to take AtomicString.
  • kcanvas/KCanvasFilters.cpp: (getFilterById): Use AtomicString.
  • kcanvas/KCanvasFilters.h: Ditto.
  • kcanvas/KCanvasResources.cpp: (getResourceById): Ditto. (getMarkerById): Ditto. (getClipperById): Ditto. (getMaskerById): Ditto. (getPaintServerById): Ditto.
  • kcanvas/KCanvasResources.h: Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): Ditto.
  • khtml/html/HTMLLabelElementImpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Ditto.
  • khtml/xml/NodeListImpl.cpp: (DOM::NodeListImpl::itemById): Ditto.
  • khtml/xml/NodeListImpl.h: Ditto. Also removed unnecessary "virtual".
  • khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheetList::nameGetter): Pass a DOMStringImpl*, which gets converted to an AtomicString implicitly, rather than a DOMString, which does not. (But that's a crazy rule -- we should change this around long term.) (KJS::DOMStyleSheetList::getOwnPropertySlot): Ditto.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::nameGetter): Ditto. (KJS::DOMNodeList::getOwnPropertySlot): Ditto. (KJS::DOMDocumentProtoFunc::callAsFunction): Ditto.
  • Merge khtml, DOM, and KDOM into one big namespace, WebCore.
  • WebCorePrefix.h: Use defined to map the old namespace names to WebCore. Now that this is done in the prefix, we can start actually calling it by that name, phase out the old names, then remove the defines.
  • other changes
  • khtml/xml/DocumentTypeImpl.cpp: Converted tabs to spaces.
  • khtml/xml/dom2_eventsimpl.cpp: Ditto.
12:04 PM Changeset in webkit [12115] by andersca
  • 18 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Remove KCanvasCommonArgs and pass around RenderPath objects instead.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTypes.h: Removed.
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerImageQuartz::draw):
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGPatternElementImpl.h:
7:14 AM Changeset in webkit [12114] by darin
  • 22 edits
    5 deletes in trunk/WebCore

Reviewed by Hyatt.

I ran performance tests and the change results in a slight improvement.

  • bridge/mac/MacFrame.h: Removed include of KWQDict.h. Changed didTellBridgeAboutLoad and haveToldBridgeAboutLoad functions to take DOMString instead of QString. Changed urlsBridgeKnowsAbout from a QDict to a HashMap.
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad): Updated to use QDict and DOMString. (MacFrame::haveToldBridgeAboutLoad): Ditto.
  • khtml/editing/jsediting.h: Removed include of qdict.h.
  • khtml/rendering/render_frames.cpp: Removed include of qdict.h. Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. (khtml::RenderPartObject::updateWidget): Changed the local variable uniqueParamNames to be a HashSet instead of a QDict.
  • khtml/xml/DocumentImpl.h: Removed include of qdict.h, changed m_elementsById, m_idCount, and m_elementsByAccessKey to use HashMap and HashCountedSet instead of QDict.
  • khtml/xml/DocumentImpl.cpp: Changed tabs to spaces. (DocumentImpl::getElementById): Updated to use HashMap for m_elementsById and HashCountedSet for m_idCount. (DocumentImpl::addElementById): Ditto. Remove code to clear m_accessKeyDictValid, since setDocumentChanged already takes care of that. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Updated to use HashMap for m_elementsByAccessKey. (DocumentImpl::setDocumentChanged): Rearranged to do a couple fewer branches. Clear out the m_elementsByAccessKey map when clearing m_accessKeyMapValid to avoid keeping stale pointers around.
  • ksvg2/svg/SVGDocumentImpl.cpp: Removed include of q3dict.h.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed obsolete QDict sources.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • ForwardingHeaders/q3dict.h: Removed.
  • ForwardingHeaders/qdict.h: Removed.
  • kwq/KWQDict.h: Removed.
  • kwq/KWQDictImpl.cpp: Removed.
  • kwq/KWQDictImpl.h: Removed.
  • WebCore+SVG/SVGNamesWrapper.cpp: Touched this file just so I could build again.
  • kwq/KWQKURL.h: Removed unused canonicalURL, _path, _user, _pass, and _host functions.
  • kwq/KWQKURL.mm: Changed tabs to spaces, removed unused functions, replaced NULL with 0.
  • kwq/KWQLoader.mm: Changed tabs to spaces. (KWQServeRequest): Removed QString conversion from call to didTellBridgeAboutLoad. (KWQServeSynchronousRequest): Ditto. (KWQCheckCacheObjectStatus): Ditto. Same for haveToldBridgeAboutLoad.
  • loader/Cache.h: Removed include of qdict.h. Changed declaration of the LRUList struct to just be a forward declaration. Changed tabs to spaces. Removed the static data member called "cache". Added a static member function called get. Renamed removeCacheEntry to remove.
  • loader/Cache.cpp: Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. Changed the main cache itself to a HashMap and made it a static variable local to this file instead of a static data member of Cache to hide its type from the header. Also made the LRUList type private to this file. (khtml::Cache::init): Create a HashMap instead of a QDict. (khtml::Cache::clear): To replace the use of setAutoDelete, write a loop to delete all the items in the cache map. (khtml::Cache::requestImage): Change code to use HashMap functions instead of QDict. (khtml::Cache::requestStyleSheet): Ditto. (khtml::Cache::preloadStyleSheet): Ditto. (khtml::Cache::requestScript): Ditto. (khtml::Cache::preloadScript): Ditto. (khtml::Cache::requestXSLStyleSheet): Ditto. (khtml::Cache::requestXBLDocument): Ditto. (khtml::Cache::removeCacheEntry): Ditto. (khtml::Cache::FastLog2): Fixed this for 64-bit compiles. (khtml::Cache::getStatistics): Ditto. (khtml::Cache::flushAll): Ditto. (khtml::Cache::get): Added. Function used by the loader.
  • loader/CachedObject.h: Removed include of qdict.h.
  • loader/DocLoader.h: Removed include of qdict.h.
  • loader/DocLoader.cpp: (khtml::DocLoader::needReload): Changed to use new get function of Cache instead of getting at the map directly. Also changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImage.cpp: (khtml::CachedImage::data): Changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImageCallback.cpp: (khtml::CachedImageCallback::handleError): Ditto.
  • loader/loader.cpp: (khtml::Loader::slotFinished): Ditto. (khtml::Loader::cancelRequests): Ditto.
6:39 AM Changeset in webkit [12113] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • JavaScriptCore/tests/mozilla/Getopt/Mixed.pm: Changed revision number to 1.8 (broken by svn migration).
4:28 AM Changeset in webkit [12112] by eseidel
  • 1 edit
    1 move in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until results can be consistent:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Added.
4:03 AM Changeset in webkit [12111] by eseidel
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until timezone bug is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6547

  • fast/js/kde/Date-expected.txt: Removed.
  • fast/js/kde/Date.html: Removed.
  • fast/js/kde/Date.html-disabled: Added.
3:48 AM Changeset in webkit [12110] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-14 David Kilzer <​ddkilzer@kilzer.net>

Reviewed and landed by Anders.

  • kjs/create_hash_table: Fixed comment typo.
3:47 AM Changeset in webkit [12109] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<mask> inside <defs> crashes Safari.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
2:47 AM Changeset in webkit [12108] by eseidel
  • 39 edits in trunk

2006-01-15 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add basic <tspan> support using RenderInline.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6428
Also fix <text transform=""> while we're at it.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6552

  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::parseMappedAttribute): cleanup
  • ksvg2/svg/SVGTSpanElementImpl.cpp: (SVGTSpanElementImpl::childShouldCreateRenderer): added. (SVGTSpanElementImpl::createRenderer): added.
  • ksvg2/svg/SVGTSpanElementImpl.h: (KSVG::SVGTSpanElementImpl::rendererIsNeeded): added.
  • ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::transform): added. (SVGTextElementImpl::localMatrix): added. (SVGTextElementImpl::parseMappedAttribute): support transform. (SVGTextElementImpl::updateLocalTransform): added. (SVGTextElementImpl::attach): added. (SVGTextElementImpl::childShouldCreateRenderer): allow tspan.
  • ksvg2/svg/SVGTextElementImpl.h:
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute): code cleanup.
  • ksvg2/svg/SVGTransformableImpl.h:

Jan 14, 2006:

11:56 PM Changeset in webkit [12107] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Append an '=' to the cookie string if it has none, so that +[NSHTTPCookie cookiesWithResponseHeaderFields:forURL:] can parse it.
11:32 PM Changeset in webkit [12106] by hyatt
  • 3 edits
    2 moves
    1 delete in trunk/WebCore

Move arena.cpp/.h out of khtml/misc and into platform/Arena.cpp/h. Also removed another unused
header, khtmldata.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/misc/arena.cpp: Removed.
  • khtml/misc/arena.h: Removed.
  • khtml/misc/khtmldata.h: Removed.
  • khtml/rendering/render_arena.h:
  • platform/Arena.cpp: Added.
  • platform/Arena.h: Added.
11:12 PM Changeset in webkit [12105] by hyatt
  • 6 edits
    2 moves in trunk/WebCore

Rename TokenizerString to SegmentedString and place it in the platform directory.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::setSrc):
  • khtml/html/htmltokenizer.h:
  • khtml/misc/stringit.cpp: Removed.
  • khtml/misc/stringit.h: Removed.
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::write):
  • khtml/xml/xml_tokenizer.h:
  • platform/SegmentedString.cpp: Added. (WebCore::SegmentedString::length): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString):
  • platform/SegmentedString.h: Added. (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedString::SegmentedString):
10:09 PM Changeset in webkit [12104] by mjs
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Eric.

  • added bridging infrastructure for Page class


The Page class itself is coming very soon.

  • WebCore.exp: Export WebCorePageBridge.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCorePageBridge.h: Added.
  • bridge/mac/WebCorePageBridge.mm: Added. (-[WebCorePageBridge initWithMainFrame:]): Added new class, obvious (-[WebCorePageBridge dealloc]): ditto (-[WebCorePageBridge mainFrame]): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]): Fixed style a bit.

WebKit:

Reviewed by Eric.

  • added bridging infrastructure for Page class


  • WebCoreSupport.subproj/WebPageBridge.h: Added.
  • WebCoreSupport.subproj/WebPageBridge.m: Added. (-[WebPageBridge initWithMainFrameName:view:]): New class, somewhat obvious.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Don't use _mainFrameBrige, use _pageBridge (-[WebView _close]): ditto (-[WebView _commonInitializationWithFrameName:groupName:]): ditto (-[WebView mainFrame]): ditto
9:43 PM Changeset in webkit [12103] by eseidel
  • 15 edits
    23 adds in trunk

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Implement basic <foreignObject> support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5974
Also fixed <image> to support clip, filter and mask
Updated <text> to support hit testing and clip, filter, mask

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/RenderForeignObject.cpp: Added. (RenderForeignObject::RenderForeignObject): (RenderForeignObject::translationForAttributes): (RenderForeignObject::paint): (RenderForeignObject::nodeAtPoint):
  • kcanvas/RenderForeignObject.h: Added. (RenderForeignObject::renderName): added. (RenderForeignObject::localTransform): added. (RenderForeignObject::setLocalTransform): added.
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): added filter, clip mask support
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::localTransform): added. (KSVG::RenderSVGImage::setLocalTransform): added.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::translationTopToBaseline): return qmatrix (RenderSVGText::translationForAttributes): return qmatrix (RenderSVGText::paint): added filter, clip, mask support (RenderSVGText::nodeAtPoint): added.
  • kcanvas/RenderSVGText.h: (RenderSVGText::localTransform): added. (RenderSVGText::setLocalTransform): added.
  • khtml/rendering/render_object.h: (khtml::RenderObject::setLocalTransform): added assert(0)
  • ksvg2/css/svg.css: added foreignObject display: block
  • ksvg2/svg/SVGForeignObjectElementImpl.cpp: Added. (KSVG::SVGForeignObjectElementImpl::SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::~SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::x): (KSVG::SVGForeignObjectElementImpl::y): (KSVG::SVGForeignObjectElementImpl::width): (KSVG::SVGForeignObjectElementImpl::height): (KSVG::SVGForeignObjectElementImpl::parseMappedAttribute): (KSVG::SVGForeignObjectElementImpl::createRenderer): (KSVG::SVGForeignObjectElementImpl::childShouldCreateRenderer):
  • ksvg2/svg/SVGForeignObjectElementImpl.h: Added. (KSVG::SVGForeignObjectElementImpl::isValid): added (KSVG::SVGForeignObjectElementImpl::rendererIsNeeded): added
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach): fixed static_cast
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::nearestViewportElement): foreignObject support (SVGLocatableImpl::farthestViewportElement): foreignObject support
  • ksvg2/svg/svgtags.in: added foreignObject
  • kwq/KWQWMatrix.cpp: (QWMatrix::isInvertible): fixed
8:55 PM Changeset in webkit [12102] by hyatt
  • 4 edits in trunk/WebCore

More khtml namespace bustage, this time on Win32 (caused by the removal of SHared from the khtml namespace.

8:48 PM Changeset in webkit [12101] by hyatt
  • 80 edits
    1 move
    1 delete in trunk/WebCore

Move shared.h from khtml/misc into the platform directory and move it into the WebCore namespace.

Reviewed by eseidel

  • ForwardingHeaders/kdom/Shared.h: Removed.
  • WebCore+SVG/DOMList.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/RGBColorImpl.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/htmlediting.h:
  • khtml/editing/visible_position.h:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/misc/shared.h: Removed.
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_style.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeListImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::SVGAngleImpl):
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimatedBooleanImpl.cpp: (SVGAnimatedBooleanImpl::SVGAnimatedBooleanImpl):
  • ksvg2/svg/SVGAnimatedBooleanImpl.h:
  • ksvg2/svg/SVGAnimatedEnumerationImpl.cpp: (SVGAnimatedEnumerationImpl::SVGAnimatedEnumerationImpl):
  • ksvg2/svg/SVGAnimatedEnumerationImpl.h:
  • ksvg2/svg/SVGAnimatedIntegerImpl.cpp: (SVGAnimatedIntegerImpl::SVGAnimatedIntegerImpl):
  • ksvg2/svg/SVGAnimatedIntegerImpl.h:
  • ksvg2/svg/SVGAnimatedLengthListImpl.h:
  • ksvg2/svg/SVGAnimatedNumberImpl.cpp: (SVGAnimatedNumberImpl::SVGAnimatedNumberImpl):
  • ksvg2/svg/SVGAnimatedNumberImpl.h:
  • ksvg2/svg/SVGAnimatedNumberListImpl.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimatedTransformListImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::SVGLengthImpl):
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl):
  • ksvg2/svg/SVGMatrixImpl.h:
  • ksvg2/svg/SVGNumberImpl.cpp: (SVGNumberImpl::SVGNumberImpl):
  • ksvg2/svg/SVGNumberImpl.h:
  • ksvg2/svg/SVGPathSegImpl.cpp: (SVGPathSegImpl::SVGPathSegImpl):
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
  • ksvg2/svg/SVGPointImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
  • ksvg2/svg/SVGPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGRectImpl.cpp: (SVGRectImpl::SVGRectImpl):
  • ksvg2/svg/SVGRectImpl.h:
  • ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl):
  • ksvg2/svg/SVGTransformImpl.h:
  • kwq/DOM-CSS.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate):
  • kwq/KWQVariant.cpp:
  • platform/ArrayImpl.h:
  • platform/Shared.h: Added.
7:33 PM Changeset in webkit [12100] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Fix build break. (oops!)

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
7:29 PM Changeset in webkit [12099] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Initialize m_isXHTMLDocument(false) properly.
No tests possible, random failure only.

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
6:57 PM Changeset in webkit [12098] by eseidel
  • 4 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for svg css property writing-mode.

  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::InheritedFlags::): (KSVG::SVGRenderStyle::setBitDefaults):
  • ksvg2/css/SVGRenderStyleDefs.h: (KSVG::):
6:42 PM Changeset in webkit [12097] by eseidel
  • 13 edits in trunk/WebCore

2006-01-14 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Refactor out cases of KCanvasRenderingStyle used as an instance to
store the current style. Temporarily unify the data passing via
KCanvasCommonArgs.

  • kcanvas/KCanvasItem.cpp: Removing override of setStyle used to hook into KCanvasRenderingStyle::updateStyle. (RenderPath::commonArgs):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::KCanvasCommonArgs): (KCanvasCommonArgs::renderStyle): (KCanvasCommonArgs::setRenderStyle): (KCanvasCommonArgs::renderPath): (KCanvasCommonArgs::setRenderPath):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): (KCanvasItemQuartz::bboxForPath): (KCanvasItemQuartz::hitsPath):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: Remove overrideFillPaintServer and overrideStrokePaintServer hacks and make most other methods static, remove most instance variables. (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::isFilled): (KCanvasRenderingStyle::fillPaintServer): (KCanvasRenderingStyle::isStroked): (KCanvasRenderingStyle::strokePaintServer): (KCanvasRenderingStyle::strokePainter): Merged stroke logic in from updateStyle. (KCanvasRenderingStyle::fillPainter): Merged fill logic in from updateStyle.
  • ksvg2/misc/KCanvasRenderingStyle.h:
6:39 PM Changeset in webkit [12096] by hyatt
  • 1 edit in trunk/WebCore/ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h

Fix mac bustage from kdom forwarding header.

6:38 PM Changeset in webkit [12095] by hyatt
  • 2 edits in trunk/WebCore

Fix win32 build bustage caused by the file moves all day.

6:38 PM Changeset in webkit [12094] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage caused by the file moves all day.

6:31 PM Changeset in webkit [12093] by eseidel
  • 1 edit
    4 moves
    12 deletes in trunk/LayoutTests

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Disabling text-intro* tests until font fallback is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6524

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Added.
6:15 PM Changeset in webkit [12092] by hyatt
  • 14 edits
    1 move in trunk/WebCore

Move loader_client.h to CachedObjectClient.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_html.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/rendering/render_object.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xsl_stylesheetimpl.h:
  • loader/CachedObject.h:
  • loader/CachedObjectClient.h: Added.
  • loader/CachedObjectClientWalker.h:
  • loader/loader_client.h: Removed.
6:13 PM Changeset in webkit [12091] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

6:09 PM Changeset in webkit [12090] by andersca
  • 9 edits
    8 deletes in trunk/WebCore

2006-01-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Dave.

  • ForwardingHeaders/kglobalsettings.h: Removed.
  • ForwardingHeaders/kimageio.h: Removed.
  • ForwardingHeaders/qasyncio.h: Removed.
  • ForwardingHeaders/qstylesheet.h: Removed.
  • kwq/KWQAsyncIO.h: Removed.
  • kwq/KWQKGlobalSettings.h: Removed.
  • kwq/KWQKImageIO.h: Removed.
  • kwq/KWQStyleSheet.h: Removed.


  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::recalcStyle):
  • loader/CachedImageCallback.cpp:
  • loader/CachedObject.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp: (KHTMLView::KHTMLView): Remove header inclusions


5:16 PM Changeset in webkit [12089] by hyatt
  • 64 edits
    25 moves
    1 add in trunk/WebCore

Shift the loader-related files out of the khtml/misc directory and into a new loader directory.
Remove the use of paths when including files from misc.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssparser.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_canvasimpl.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/Cache.cpp: Removed.
  • khtml/misc/Cache.h: Removed.
  • khtml/misc/CachedCSSStyleSheet.cpp: Removed.
  • khtml/misc/CachedCSSStyleSheet.h: Removed.
  • khtml/misc/CachedImage.cpp: Removed.
  • khtml/misc/CachedImage.h: Removed.
  • khtml/misc/CachedImageCallback.cpp: Removed.
  • khtml/misc/CachedImageCallback.h: Removed.
  • khtml/misc/CachedObject.cpp: Removed.
  • khtml/misc/CachedObject.h: Removed.
  • khtml/misc/CachedObjectClientWalker.cpp: Removed.
  • khtml/misc/CachedObjectClientWalker.h: Removed.
  • khtml/misc/CachedScript.cpp: Removed.
  • khtml/misc/CachedScript.h: Removed.
  • khtml/misc/CachedXBLDocument.cpp: Removed.
  • khtml/misc/CachedXBLDocument.h: Removed.
  • khtml/misc/CachedXSLStyleSheet.cpp: Removed.
  • khtml/misc/CachedXSLStyleSheet.h: Removed.
  • khtml/misc/DocLoader.cpp: Removed.
  • khtml/misc/DocLoader.h: Removed.
  • khtml/misc/Request.cpp: Removed.
  • khtml/misc/Request.h: Removed.
  • khtml/misc/loader.cpp: Removed.
  • khtml/misc/loader.h: Removed.
  • khtml/misc/loader_client.h: Removed.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvasimage.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.h:
  • khtml/xbl/xbl_binding.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp:
  • kwq/KWQVariant.cpp:
  • loader: Added.
  • loader/Cache.cpp: Added.
  • loader/Cache.h: Added.
  • loader/CachedCSSStyleSheet.cpp: Added.
  • loader/CachedCSSStyleSheet.h: Added.
  • loader/CachedImage.cpp: Added.
  • loader/CachedImage.h: Added.
  • loader/CachedImageCallback.cpp: Added.
  • loader/CachedImageCallback.h: Added.
  • loader/CachedObject.cpp: Added.
  • loader/CachedObject.h: Added.
  • loader/CachedObjectClientWalker.cpp: Added.
  • loader/CachedObjectClientWalker.h: Added.
  • loader/CachedScript.cpp: Added.
  • loader/CachedScript.h: Added.
  • loader/CachedXBLDocument.cpp: Added.
  • loader/CachedXBLDocument.h: Added.
  • loader/CachedXSLStyleSheet.cpp: Added.
  • loader/CachedXSLStyleSheet.h: Added.
  • loader/DocLoader.cpp: Added.
  • loader/DocLoader.h: Added.
  • loader/Request.cpp: Added.
  • loader/Request.h: Added.
  • loader/loader.cpp: Added.
  • loader/loader.h: Added.
  • loader/loader_client.h: Added.
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • page/FrameView.cpp:
5:12 PM Changeset in webkit [12088] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Missed ChangeLog in previous commit.

5:10 PM Changeset in webkit [12087] by eseidel
  • 55 edits
    9 copies
    2 moves
    1 delete in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

break classes in dom_nodeimpl.* into separate files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6543

  • ForwardingHeaders/kdom/core/NodeImpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/css/css_base.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/remove_node_attribute_command.h:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/set_node_attribute_command.h:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/khtml_events.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_object.h:
  • khtml/xml/ChildNodeListImpl.cpp: Added.
  • khtml/xml/ChildNodeListImpl.h: Added.
  • khtml/xml/ContainerNodeImpl.cpp: Added. (DOM::ContainerNodeImpl::removeAllChildren): (DOM::ContainerNodeImpl::checkSameDocument): (DOM::ContainerNodeImpl::getRect): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents):
  • khtml/xml/ContainerNodeImpl.h: Added.
  • khtml/xml/DocumentFragmentImpl.cpp:
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h: (DOM::DocumentImpl::setTextColor):
  • khtml/xml/DocumentTypeImpl.cpp:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/NameNodeListImpl.cpp: Added.
  • khtml/xml/NameNodeListImpl.h: Added.
  • khtml/xml/NamedNodeMapImpl.h: Added. (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::~NamedNodeMapImpl):
  • khtml/xml/NodeImpl.cpp: Added. (DOM::TagNodeListImpl::TagNodeListImpl): (DOM::TagNodeListImpl::length): (DOM::TagNodeListImpl::item): (DOM::TagNodeListImpl::nodeMatches): (DOM::NodeImpl::getRect):
  • khtml/xml/NodeImpl.h: Added.
  • khtml/xml/NodeListImpl.cpp: Added.
  • khtml/xml/NodeListImpl.h: Added.
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Removed.
  • khtml/xml/dom_nodeimpl.h: Removed.
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • kwq/DOM.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMUtility.mm:
  • kwq/KWQClipboard.h:
  • page/FrameView.cpp:
3:29 PM Changeset in webkit [12086] by hyatt
  • 35 edits
    3 moves
    1 delete in trunk/WebCore

Convert QMemArray to Array. QByteArray becomes ByteArray.
KWQArrayImpl becomes ArrayImpl.

Reviewed by anders

  • ForwardingHeaders/qmemarray.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::processSyncLoadResults):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/html/HTMLOptionElementImpl.cpp: (DOM::HTMLOptionElementImpl::index):
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::selectedIndex): (DOM::HTMLSelectElementImpl::setSelectedIndex): (DOM::HTMLSelectElementImpl::length): (DOM::HTMLSelectElementImpl::remove): (DOM::HTMLSelectElementImpl::value): (DOM::HTMLSelectElementImpl::setValue): (DOM::HTMLSelectElementImpl::state): (DOM::HTMLSelectElementImpl::restoreState): (DOM::HTMLSelectElementImpl::appendFormData): (DOM::HTMLSelectElementImpl::optionToListIndex): (DOM::HTMLSelectElementImpl::listToOptionIndex): (DOM::HTMLSelectElementImpl::reset): (DOM::HTMLSelectElementImpl::notifyOptionSelected):
  • khtml/html/HTMLSelectElementImpl.h: (DOM::HTMLSelectElementImpl::listItems):
  • khtml/misc/formdata.cpp: (khtml::FormData::flatten): (khtml::FormData::flattenToString):
  • khtml/misc/formdata.h: (khtml::FormDataElement::FormDataElement):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderSelect::slotSelected): (RenderSelect::slotSelectionChanged): (RenderSelect::updateSelection):
  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): (RenderTableSection::setCellWidths):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):
  • khtml/rendering/table_layout.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQArrayImpl.cpp: Removed.
  • kwq/KWQArrayImpl.h: Removed.
  • kwq/KWQBuffer.cpp: (QBuffer::setBuffer):
  • kwq/KWQBuffer.h: (QBuffer::QBuffer): (QBuffer::buffer):
  • kwq/KWQCString.cpp: (QCString::QCString): (QCString::resize): (QCString::append):
  • kwq/KWQCString.h:
  • kwq/KWQKURL.mm: (findHostnamesInMailToURL): (encodeHostnames):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
  • kwq/KWQMemArray.h: Removed.
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::receivedData):
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (QString::QString):
  • kwq/KWQTextCodec.cpp: (QTextCodec::toUnicode):
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.cpp: (QTextStream::QTextStream):
  • kwq/KWQTextStream.h:
  • page/Frame.h:
  • platform/Array.h: Added. (WebCore::Array::Array): (WebCore::Array::duplicate): (WebCore::Array::assign): (WebCore::Array::operator==): (WebCore::Array::operator!=):
  • platform/ArrayImpl.cpp: Added. (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate): (WebCore::ArrayImpl::ArrayPrivate::~ArrayPrivate): (WebCore::ArrayImpl::ArrayImpl): (WebCore::ArrayImpl::~ArrayImpl): (WebCore::ArrayImpl::operator=): (WebCore::ArrayImpl::data): (WebCore::ArrayImpl::resize): (WebCore::ArrayImpl::duplicate): (WebCore::ArrayImpl::detach): (WebCore::ArrayImpl::fill): (WebCore::ArrayImpl::operator==):
  • platform/ArrayImpl.h: Added. (WebCore::ArrayImpl::size):
  • platform/IntPointArray.cpp: (IntPointArray::setPoint):
  • platform/IntPointArray.h: (WebCore::IntPointArray::IntPointArray):
2:07 PM Changeset in webkit [12085] by hyatt
  • 124 edits
    4 moves
    2 adds
    1 delete in trunk/WebCore

Convert QRect/QRectF -> IntRect/FloatRect. Same drill as point
and size.

Reviewed by mjs

  • ForwardingHeaders/qrect.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::snapshotDragImage): (MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:withPainter:]): (-[WebCoreFrameBridge firstRectForDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]):
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::relativeBBox): (KCanvasContainer::getAspectRatio):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp: (KCanvasFilterEffect::subRegion): (KCanvasFilterEffect::setSubRegion):
  • kcanvas/KCanvasFilters.h: (KCanvasFilter::filterRect): (KCanvasFilter::setFilterRect):
  • kcanvas/KCanvasItem.cpp: (RenderPath::relativeBBox):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::setBbox): (KRenderingPaintServerPattern::bbox):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (drawMarkerWithData): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::bboxForPath):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::layout): (KCanvasContainerQuartz::paint): (KCanvasContainerQuartz::setViewport): (KCanvasContainerQuartz::viewport): (KCanvasContainerQuartz::setViewBox): (KCanvasContainerQuartz::viewBox): (KCanvasContainerQuartz::absoluteTransform): (KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::mapFromVisual): (KRenderingDeviceContextQuartz::mapToVisual):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::caretY): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::caretRepaintRect): (khtml::SelectionController::paintCaret):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::getRect):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isFocusable):
  • khtml/misc/CachedImage.cpp: (khtml::CachedImage::valid_rect): (khtml::CachedImage::do_notify): (khtml::CachedImage::error):
  • khtml/misc/CachedImage.h:
  • khtml/misc/khtmllayout.h: (khtml::GapRects::left): (khtml::GapRects::center): (khtml::GapRects::right): (khtml::GapRects::uniteLeft): (khtml::GapRects::uniteCenter): (khtml::GapRects::uniteRight): (khtml::GapRects::operator IntRect):
  • khtml/misc/loader_client.h: (khtml::CachedObjectClient::setPixmap):
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): (khtml::InlineTextBox::nodeAtPoint):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/RenderText.cpp: (khtml::RenderText::absoluteRects): (khtml::RenderText::caretRect): (khtml::RenderText::getAbsoluteRepaintRect): (khtml::RenderText::selectionRect):
  • khtml/rendering/RenderText.h:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/font.cpp: (khtml::Font::selectionRectForText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::overflowRect): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::paint): (khtml::RenderBlock::fillHorizontalSelectionGap): (khtml::RenderBlock::fillVerticalSelectionGap): (khtml::RenderBlock::fillLeftSelectionGap): (khtml::RenderBlock::fillRightSelectionGap): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::selectionRect):
  • khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgroundExtended): (RenderBox::getOverflowClipRect): (RenderBox::getClipRect): (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::caretRect):
  • khtml/rendering/render_box.h: (khtml::RenderBox::borderBox):
  • khtml/rendering/render_br.cpp: (khtml::RenderBR::caretRect):
  • khtml/rendering/render_br.h: (khtml::RenderBR::selectionRect):
  • khtml/rendering/render_button.cpp: (khtml::RenderButton::paintObject):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle): (RenderCanvas::getAbsoluteRepaintRect): (RenderCanvas::computeAbsoluteRepaintRect): (RenderCanvas::absoluteRects): (RenderCanvas::selectionRect): (RenderCanvas::viewRect):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printRect): (khtml::RenderCanvas::setPrintRect):
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint): (RenderCanvasImage::layout):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect): (RenderFlow::caretRect): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
  • khtml/rendering/render_image.cpp: (RenderImage::setImage): (RenderImage::setPixmap): (RenderImage::paint): (RenderImage::layout):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::updateLayerPositions): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::getRectToExpose): (khtml::RenderLayer::positionScrollbars): (khtml::RenderLayer::updateScrollInfoAfterLayout): (khtml::RenderLayer::paintScrollbars): (khtml::RenderLayer::paint): (khtml::setClip): (khtml::restoreClip): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTest): (khtml::RenderLayer::hitTestLayer): (khtml::RenderLayer::calculateClipRects): (khtml::RenderLayer::calculateRects): (khtml::mustExamineRenderer): (khtml::RenderLayer::intersectsDamageRect): (khtml::RenderLayer::containsPoint):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::m_refCnt): (khtml::ClipRects::overflowClipRect): (khtml::ClipRects::fixedClipRect): (khtml::ClipRects::posClipRect): (khtml::RenderLayer::repaintRect):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::canAccommodateEllipsis): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::EllipsisBox::nodeAtPoint):
  • khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::setPixmap):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorderImage): (RenderObject::paintBorder): (RenderObject::absoluteRects): (RenderObject::absoluteBoundingBoxRect): (RenderObject::addAbsoluteRectForLayer): (RenderObject::paintingRootRect): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::getAbsoluteRepaintRectWithOutline): (RenderObject::getAbsoluteRepaintRect): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::computeAbsoluteRepaintRect): (RenderObject::viewRect): (RenderObject::caretRect): (RenderObject::addDashboardRegions): (RenderObject::setPixmap):
  • khtml/rendering/render_object.h: (khtml::RenderObject::getOverflowClipRect): (khtml::RenderObject::getClipRect): (khtml::RenderObject::relativeBBox): (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::RepaintInfo::m_repaintRect): (khtml::RenderObject::borderBox): (khtml::RenderObject::overflowRect): (khtml::RenderObject::floatRect): (khtml::RenderObject::selectionRect): (khtml::RenderObject::SelectionInfo::rect):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::selectionRect): (RenderWidget::paint): (RenderWidget::updateWidgetPosition):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableRow::getAbsoluteRepaintRect): (RenderTableCell::computeAbsoluteRepaintRect): (RenderTableCell::getAbsoluteRepaintRect): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint):
  • khtml/rendering/render_theme.h: (khtml::RenderTheme::adjustRepaintRect):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustRepaintRect): (khtml::RenderThemeMac::inflateRect): (khtml::RenderThemeMac::paintCheckbox): (khtml::RenderThemeMac::setCheckboxCellState): (khtml::RenderThemeMac::paintRadio): (khtml::RenderThemeMac::setRadioCellState): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::getRect): (DOM::ContainerNodeImpl::getRect):
  • khtml/xml/dom_nodeimpl.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::createRenderer):
  • kwq/KWQAccObject.mm: (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject doAXBoundsForTextMarkerRange:]):
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): (QDesktopWidget::availableGeometry):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::selectionRectForText): (QFontMetrics::boundingRect):
  • kwq/KWQKWinModule.h:
  • kwq/KWQKWinModule.mm: (KWinModule::workArea):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::xForm): (QPainter::drawPixmap): (QPainter::fillRect): (QPainter::addClip): (QPainter::addRoundedRectClip):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::setAnimationRect): (QPixmap::rect):
  • kwq/KWQRect.h: Removed.
  • kwq/KWQRect.mm: Removed.
  • kwq/KWQRectF.h: Removed.
  • kwq/KWQRectF.mm: Removed.
  • kwq/KWQRegion.cpp: (QRegion::QRegion): (QRegion::boundingRect):
  • kwq/KWQRegion.h:
  • kwq/KWQRenderTreeDebug.cpp: (operator<<): (write): (writeLayers): (externalRepresentation):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::updateContents):
  • kwq/KWQWMatrix.cpp: (QWMatrix::mapRect):
  • kwq/KWQWMatrix.h:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::resize): (QWidget::move): (QWidget::frameGeometry): (QWidget::setFrameGeometry): (QWidget::paint):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): (KWQWindowWidget::setFrameGeometry):
  • page/Frame.cpp: (Frame::gotoAnchor): (Frame::paintCaret): (Frame::paintDragCaret): (Frame::selectionRect): (Frame::revealSelection): (Frame::paint): (Frame::adjustPageHeight): (Frame::centerSelectionInVisibleArea):
  • page/Frame.h:
  • page/FrameView.cpp: (KHTMLView::addRepaintInfo): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::repaintRectangle):
  • page/FrameView.h:
  • platform/FloatRect.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::isNull): (WebCore::FloatRect::isValid): (WebCore::FloatRect::isEmpty): (WebCore::FloatRect::right): (WebCore::FloatRect::bottom): (WebCore::FloatRect::topLeft): (WebCore::FloatRect::topRight): (WebCore::FloatRect::bottomRight): (WebCore::FloatRect::bottomLeft): (WebCore::FloatRect::size): (WebCore::FloatRect::unite): (WebCore::FloatRect::normalize): (WebCore::FloatRect::intersects): (WebCore::FloatRect::intersect): (WebCore::FloatRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/FloatRect.h: Added. (WebCore::FloatRect::contains): (WebCore::FloatRect::operator&): (WebCore::enclosingIntRect):
  • platform/IntPointArray.cpp: (IntPointArray::IntPointArray): (IntPointArray::boundingRect):
  • platform/IntPointArray.h:
  • platform/IntRect.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::isNull): (WebCore::IntRect::isValid): (WebCore::IntRect::isEmpty): (WebCore::IntRect::right): (WebCore::IntRect::bottom): (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::size): (WebCore::IntRect::unite): (WebCore::IntRect::normalize): (WebCore::IntRect::intersects): (WebCore::IntRect::intersect): (WebCore::IntRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/IntRect.h: Added. (WebCore::IntRect::contains): (WebCore::IntRect::operator&):
  • platform/mac/FloatRect.mm: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator NSRect): (WebCore::FloatRect::operator CGRect):
  • platform/mac/IntRect.mm: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator NSRect): (WebCore::IntRect::operator CGRect):

Jan 13, 2006:

10:56 PM Changeset in webkit [12084] by hyatt
  • 18 edits
    2 moves
    1 add in trunk/WebCore

Convert QPointF to FloatPoint and move it to the platform
directory.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::fillContains): (KCanvasContainer::strokeContains):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEConvolveMatrix::kernelUnitLength): (KCanvasFEConvolveMatrix::setKernelUnitLength):
  • kcanvas/KCanvasItem.cpp: (RenderPath::fillContains): (RenderPath::strokeContains):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerLinearGradient::gradientStart): (KRenderingPaintServerLinearGradient::setGradientStart): (KRenderingPaintServerLinearGradient::gradientEnd): (KRenderingPaintServerLinearGradient::setGradientEnd): (KRenderingPaintServerRadialGradient::gradientCenter): (KRenderingPaintServerRadialGradient::setGradientCenter): (KRenderingPaintServerRadialGradient::gradientFocal): (KRenderingPaintServerRadialGradient::setGradientFocal):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector):
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::nodeAtPoint): (KCanvasItemQuartz::hitsPath):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient):
  • kwq/KWQPointF.h: Removed.
  • kwq/KWQPointF.mm: Removed.
  • kwq/KWQRectF.h: (QRectF::contains):
  • kwq/KWQRectF.mm: (QRectF::QRectF): (QRectF::topLeft): (QRectF::topRight): (QRectF::bottomRight): (QRectF::bottomLeft):
  • platform/FloatPoint.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::yCoord): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
  • platform/FloatPoint.h: Added. (WebCore::FloatPoint::operator -=):
  • platform/mac/FloatPoint.mm: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator NSPoint): (WebCore::FloatPoint::operator CGPoint):
10:13 PM Changeset in webkit [12083] by hyatt
  • 50 edits
    3 moves
    2 adds
    2 deletes in trunk/WebCore

Convert QPoint and QPointArray to IntPoint and IntPointArray.
Factor out the Objective-C-specific logic into a .mm file
for IntPoint.


  • ForwardingHeaders/qpoint.h: Removed.
  • ForwardingHeaders/qpointarray.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLView.cpp: (KHTMLView::viewportToGlobal):
  • bridge/mac/KWQKPartsBrowserExtension.h:
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::khtmlMouseMoveEvent): (MacFrame::dragSourceMovedTo): (MacFrame::dragSourceEndedAt): (MacFrame::dispatchDragSrcEvent):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::layout): (khtml::SelectionController::caretRect):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::mapMouseEvent): (DOM::HTMLAreaElementImpl::getRegion):
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
  • ksvg2/svg/SVGPointImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::createSVGPoint):
  • ksvg2/svg/SVGSVGElementImpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (KWQClipboard::dragLocation): (KWQClipboard::setDragImage): (KWQClipboard::setDragImageElement):
  • kwq/KWQCursor.h:
  • kwq/KWQEvent.h: (QMouseEvent::pos): (QWheelEvent::QWheelEvent): (QWheelEvent::pos): (QWheelEvent::globalPos):
  • kwq/KWQEvent.mm: (positionForEvent): (globalPositionForEvent):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawConvexPolygon): (QPainter::drawPixmap):
  • kwq/KWQPixmap.mm: (QPixmap::rect):
  • kwq/KWQPoint.mm: Removed.
  • kwq/KWQPointArray.cpp: Removed.
  • kwq/KWQPointArray.h: Removed.
  • kwq/KWQPointF.h:
  • kwq/KWQPointF.mm: (yCoord):
  • kwq/KWQRect.h: (QRect::moveTopLeft): (QRect::contains):
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::topLeft): (QRect::topRight): (QRect::bottomRight): (QRect::bottomLeft):
  • kwq/KWQRegion.cpp: (QRegion::QRegion): (QRegion::contains):
  • kwq/KWQRegion.h:
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::contentsToViewport):
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::pos): (QWidget::move): (QWidget::mapFromGlobal):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::mapFromGlobal): (KWQWindowWidget::viewportToGlobal):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (KHTMLView::dispatchDragEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • page/FrameView.h:
  • platform/IntPoint.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
  • platform/IntPoint.h: Added. (WebCore::IntPoint::x): (WebCore::IntPoint::y): (WebCore::IntPoint::setX): (WebCore::IntPoint::setY): (WebCore::IntPoint::isNull): (WebCore::IntPoint::operator -=):
  • platform/IntPointArray.cpp: Added. (IntPointArray::IntPointArray): (IntPointArray::copy): (IntPointArray::boundingRect): (IntPointArray::point): (IntPointArray::setPoint): (IntPointArray::setPoints):
  • platform/IntPointArray.h: Added. (WebCore::IntPointArray::IntPointArray):
3:54 PM Changeset in webkit [12082] by hyatt
  • 1 edit in trunk/WebCore/kcanvas/KCanvasTreeDebug.h

Forgot to wrap FloatSize in a namespace. Fixing this.

3:41 PM Changeset in webkit [12081] by hyatt
  • 4 edits in trunk/WebCore

Forgot to wrap FloatSize in a namespace. Fixing this.

3:28 PM Changeset in webkit [12080] by hyatt
  • 7 edits
    2 moves
    1 add in trunk/WebCore

Convert QSizeF to FloatSize and move it to the platform
directory.


  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasFilters.h: (KCanvasFEConvolveMatrix::kernelSize): (KCanvasFEConvolveMatrix::setKernelSize): (KCanvasFEConvolveMatrix::targetOffset): (KCanvasFEConvolveMatrix::setTargetOffset):
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kwq/KWQRectF.h:
  • kwq/KWQRectF.mm: (QRectF::QRectF): (QRectF::size):
  • kwq/KWQSizeF.h: Removed.
  • kwq/KWQSizeF.mm: Removed.
  • platform/FloatSize.cpp: Added. (FloatSize::FloatSize): (FloatSize::isValid): (FloatSize::expandedTo): (operator+): (operator==): (operator!=):
  • platform/FloatSize.h: Added.
  • platform/mac/FloatSize.mm: Added. (FloatSize::FloatSize): (FloatSize::operator NSSize): (FloatSize::operator CGSize):
2:51 PM Changeset in webkit [12079] by hyatt
  • 1 edit in trunk/WebCore/kwq/KWQSizeF.mm

Fix the last bit of bustage.

2:32 PM Changeset in webkit [12078] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage from QSize -> IntSize change.


Reviewed by darin

  • kwq/KWQObject.h:
  • kwq/KWQSizeF.h:
2:04 PM Changeset in webkit [12077] by hyatt
  • 52 edits
    2 moves
    3 adds in trunk/WebCore

Eliminate QSize and add the new class IntSize in the
platform subdirectory. Factor out the Objective-C portion
of IntSize into a platform-specific IntSize.mm that resides
in the mac subdirectory.

Win32 can just compile IntSize.cpp and doesn't need any
platform-specific extension here.


Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasImage.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasImageQuartz::init): (KCanvasImageQuartz::size):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::contextForImage):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • khtml/misc/CachedImage.cpp: (khtml::CachedImage::pixmap_size): (khtml::CachedImage::data):
  • khtml/misc/CachedImage.h:
  • khtml/misc/CachedImageCallback.cpp: (khtml::CachedImageCallback::notifyUpdate): (khtml::CachedImageCallback::notifyFinished):
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderFileButton::calcMinMaxWidth): (RenderSelect::layout): (RenderTextArea::calcMinMaxWidth): (RenderSlider::calcMinMaxWidth):
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::borderTopLeftRadius): (khtml::RenderStyle::borderTopRightRadius): (khtml::RenderStyle::borderBottomLeftRadius): (khtml::RenderStyle::borderBottomRightRadius): (khtml::RenderStyle::setBorderTopLeftRadius): (khtml::RenderStyle::setBorderTopRightRadius): (khtml::RenderStyle::setBorderBottomLeftRadius): (khtml::RenderStyle::setBorderBottomRightRadius): (khtml::RenderStyle::setBorderRadius): (khtml::RenderStyle::initialBorderRadius):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::inflateRect): (khtml::RenderThemeMac::setControlSize): (khtml::RenderThemeMac::sizeForFont): (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::checkboxSizes): (khtml::RenderThemeMac::setCheckboxCellState): (khtml::RenderThemeMac::radioSizes): (khtml::RenderThemeMac::setRadioCellState): (khtml::RenderThemeMac::buttonSizes): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::attributeChanged): (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGPatternElementImpl.h:
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::size):
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::addRoundedRectClip):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::size): (QPixmap::resize):
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::size):
  • kwq/KWQSize.h: Removed.
  • kwq/KWQSize.mm: Removed.
  • kwq/KWQSizeF.h:
  • kwq/KWQSizeF.mm: (QSizeF::QSizeF):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::sizeHint):
  • kwq/KWQStyle.cpp: (QStyle::sizeFromContents):
  • kwq/KWQStyle.h:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows):
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::sizeHint): (QWidget::size): (QWidget::resize):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::sizeHint):
  • platform: Added.
  • platform/IntSize.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::isValid): (WebCore::IntSize::expandedTo): (WebCore::operator+): (WebCore::operator==): (WebCore::operator!=):
  • platform/IntSize.h: Added.
  • platform/mac: Added.
  • platform/mac/IntSize.mm: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator NSSize): (WebCore::IntSize::operator CGSize):
12:16 PM Changeset in webkit [12076] by ap
  • 5 edits
    3 adds in trunk

Mostly merging work by Peter Kelly. Reviewed by Maciej, landed by ap.

JavaScriptCore:

  • kjs/array_object.cpp: Don't treat 232-1 as a real array index property. (ArrayInstance::getOwnPropertySlot): Ditto. (ArrayInstance::deleteProperty): Ditto. (ArrayInstance::put): Ditto. (ArrayInstance::propList): Added a FIXME comment. (ArrayInstance::put): Throw exception on trying to set invalid array length. (ArrayProtoFunc::callAsFunction): Do not use a separator argument when doing toString/toLocalString.
  • kjs/array_object.h: Added MAX_ARRAY_INDEX.

LayoutTests:

  • fast/js/kde/Array-expected.txt: Updated for newly-passing tests.
  • fast/js/array-tostring-ignore-separator.html: Added.
  • fast/js/array-tostring-ignore-separator-expected.txt: Added.
  • fast/js/resources/array-tostring-ignore-separator.js: Added.
9:53 AM Changeset in webkit [12075] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Based on test cases provided by Maks Orlovich.

  • fast/table/rowindex.html: Added.
  • fast/table/rowindex-expected.checksum: Added.
  • fast/table/rowindex-expected.png: Added.
  • fast/table/rowindex-expected.txt: Added.

WebCore:

Reviewed, redone a bit, and landed by Darin (help from Eric too).

Test: fast/table/rowindex.html

  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableRowElementImpl::rowIndex): Change algorithm so the rows are numbered in this order: (a) all rows in the table header section, (b) all rows in all table body sections, (c) all rows in the table footer section. Rows in extra table header or footer sections don't get row numbers (rowIndex returns -1). This matches Firefox.
8:55 AM Changeset in webkit [12074] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/css-generated-content/no-openclose-quote.html: Added.
  • fast/css-generated-content/no-openclose-quote-expected.checksum: Added.
  • fast/css-generated-content/no-openclose-quote-expected.png: Added.
  • fast/css-generated-content/no-openclose-quote-expected.txt: Added.

WebCore:

Reviewed, tweaked, and landed by Darin.

Test: fast/css-generated-content/no-openclose-quote.html

  • khtml/css/cssparser.cpp: (CSSParser::parseContent): Make sure parsedValue is always initialized to 0 (in particular for the CSS_IDENT case which is currently unimplemented).
8:39 AM Changeset in webkit [12073] by darin
  • 7 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.



  • fast/replaced/inline-box-wrapper-handover.html: Updated test to not depend on the edge case behavior.
  • fast/replaced/inline-box-wrapper-handover-expected.checksum: Updated results.
  • fast/replaced/inline-box-wrapper-handover-expected.png: Ditto.
  • fast/replaced/inline-box-wrapper-handover-expected.txt: Ditto.
  • fast/text/basic/015.html: Added.
  • fast/text/basic/015-expected.checksum: Added.
  • fast/text/basic/015-expected.png: Added.
  • fast/text/basic/015-expected.txt: Added.
  • fast/dom/css-rule-functions-expected.checksum: Added.
  • fast/dom/css-rule-functions-expected.png: Added.

WebCore:

Reviewed and landed by Darin.



Test: fast/text/basic/015.html

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Avoid inconsistent width measurement when breaking in the middle of a word is allowed. Eliminate the relaxation by 1 of the width overflow check that was supposed to compensate for the inconsistency but didn't always work, and on the other hand sometimes resulted in allowing text to overflow its container by one pixel. Also applied start and end width correctly in the break-words case.
2:21 AM Changeset in webkit [12072] by mjs
  • 64 edits
    4 moves in trunk

WebCore:

Rubber stamped by Eric.

  • rename WebCoreBridge to WebCoreFrameBridge
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • bridge/mac/MacFrame.h: (MacFrame::bridge):
  • bridge/mac/MacFrame.mm: (MacFrame::submitForm): (MacFrame::createPart): (MacFrame::bridgeForWidget): (MacFrame::documentViewForNode): (MacFrame::setBridge):
  • bridge/mac/WebCoreBridge.h: Removed.
  • bridge/mac/WebCoreBridge.mm: Removed.
  • bridge/mac/WebCoreFrameBridge.h: Added.
  • bridge/mac/WebCoreFrameBridge.mm: Added. (-[WebCoreFrameBridge executionContextForView:]): (frameHasSelection): (-[WebCoreFrameBridge firstChild]): (-[WebCoreFrameBridge lastChild]): (-[WebCoreFrameBridge previousSibling]): (-[WebCoreFrameBridge nextSibling]): (-[WebCoreFrameBridge isDescendantOfFrame:]): (-[WebCoreFrameBridge traverseNextFrameStayWithin:]): (-[WebCoreFrameBridge appendChild:]): (-[WebCoreFrameBridge removeChild:]): (-[WebCoreFrameBridge childFrameNamed:]): (-[WebCoreFrameBridge _deepLastChildFrame]): (-[WebCoreFrameBridge nextFrameWithWrap:]): (-[WebCoreFrameBridge previousFrameWithWrap:]): (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge _descendantFrameNamed:sourceFrame:]): (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): (-[WebCoreFrameBridge findFrameNamed:]): (+[WebCoreFrameBridge bridgeForDOMDocument:]): (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (nowPrinting): (-[WebCoreFrameBridge opener]): (-[WebCoreFrameBridge setOpener:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
  • kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): (-[KWQTableView keyUp:]):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest): (KWQCheckCacheObjectStatus): (KWQCacheObjectExpiresTime):
  • kwq/KWQSlider.mm: (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView keyDown:]): (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textView:shouldHandleEvent:]):
  • kwq/KWQWidget.mm: (QWidget::setFocus):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget):
  • kwq/WebCoreFrameNamespaces.h:
  • kwq/WebCoreFrameNamespaces.m: (+[WebCoreFrameNamespaces addFrame:toNamespace:]):
  • kwq/WebCoreFrameView.h:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • kwq/WebCoreViewFactory.h:

WebKit:

Rubber stamped by Eric.

  • rename WebBridge to WebFrameBridge


  • also removed all tabs from WebFrameBridge.m
  • DOM.subproj/WebDOMOperations.m: (-[DOMNode _bridge]): (-[DOMNode webArchive]): (-[DOMRange _bridge]): (-[DOMRange webArchive]):
  • DOM.subproj/WebDOMOperationsPrivate.h:
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebCoreStatistics.m:
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _bridge]):
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
  • Plugins.subproj/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • Plugins.subproj/WebPluginController.h:
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController bridge]):
  • WebCoreSupport.subproj/WebBridge.h: Removed.
  • WebCoreSupport.subproj/WebBridge.m: Removed.
  • WebCoreSupport.subproj/WebFileButton.h:
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileChooserButton initWithBridge:delegate:]):
  • WebCoreSupport.subproj/WebFrameBridge.h: Added.
  • WebCoreSupport.subproj/WebFrameBridge.m: Added. (-[WebFrameBridge mainFrame]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge canTargetLoadInFrame:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (formDelegate): (-[WebFrameBridge createModalDialogWithURL:]):
  • WebCoreSupport.subproj/WebSubresourceLoader.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _bridge]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _stringWithData:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDebugDOMNode.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m: (-[WebFrame _traverseNextFrameStayWithin::]): (Frame): (-[WebFrame _detachFromParent]): (-[WebFrame _bridge]): (-[WebFrame _initWithWebFrameView:webView:bridge:]):
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView webCoreBridge]): (-[WebFrameView _bridge]):
  • WebView.subproj/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedMIMETypes]): (-[WebHTMLRepresentation _bridge]): (-[WebHTMLRepresentation documentSource]):
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): (-[WebHTMLView updateFocusState]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray attributedString]): (-[NSArray selectedAttributedString]): (-[NSArray concludeDragForDraggingInfo:actionMask:]): (-[NSArray keyDown:]): (-[NSArray _alterCurrentSelection:direction:granularity:]): (-[NSArray _alterCurrentSelection:verticalDistance:]): (-[NSArray _expandSelectionToGranularity:]): (-[NSArray cut:]): (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray pasteAsPlainText:]): (-[NSArray insertNewline:]): (-[NSArray insertLineBreak:]): (-[NSArray insertParagraphSeparator:]): (-[NSArray _changeWordCaseWithSelector:]): (-[NSArray startSpeaking:]): (-[NSArray selectToMark:]): (-[NSArray swapWithMark:]): (-[NSArray transpose:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView _selectMarkedText]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView _selectionIsInsideMarkedText]): (-[WebTextCompleteController _insertMatch:]): (-[WebTextCompleteController doCompletion]): (-[WebTextCompleteController endRevertingChange:moveLeft:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceLoader.m:
  • WebView.subproj/WebRenderNode.m:
  • WebView.subproj/WebResource.m: (-[WebResource _stringValue]):
  • WebView.subproj/WebScriptDebugDelegate.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m: (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView moveDragCaretToPoint:]): (-[WebView shouldClose]): (-[WebView editableDOMRangeForPoint:]): (-[WebView setEditable:]): (-[WebView deleteSelection]): (-[WebView _bridgeForSelectedOrMainFrame]): (-[WebView _bridgeAtPoint:]):
2:07 AM Changeset in webkit [12071] by darin
  • 183 edits in trunk/WebCore
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
2:06 AM Changeset in webkit [12070] by darin
  • 64 edits in trunk/WebKit
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
1:32 AM Changeset in webkit [12069] by darin
  • 54 edits in trunk/JavaScriptCore
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
1:05 AM Changeset in webkit [12068] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, removed bogus ChangeLog entry.

1:04 AM Changeset in webkit [12067] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Removed tabs to make the new pre-commit script happy.

1:01 AM Changeset in webkit [12066] by darin
  • 1 edit in trunk/WebKitLibraries/ChangeLog

Removed tabs from the ChangeLog file to make the pre-commit check happy.

12:36 AM Changeset in webkit [12065] by eseidel
  • 2 edits in trunk/WebCore

2006-01-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove CG dependencies from kcanvas/device/quartz
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6521
Adding file omitted from last commit.

  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): removed cg calls
12:33 AM Changeset in webkit [12064] by eseidel
  • 14 edits in trunk/WebCore

2006-01-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove CG dependencies from kcanvas/device/quartz
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6521

  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): removed parameter (KCanvasFilterQuartz::applyFilter): removed parameter
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::drawMarkersIfNeeded): removed cg call (KCanvasItemQuartz::paint): removed cg calls (getSharedContext): spacing
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (KCanvasMaskerQuartz::applyMask): removed parameter
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasClipperQuartz::KCanvasClipperQuartz): (KCanvasImageQuartz::KCanvasImageQuartz):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): removed CG calls (KCanvasClipperQuartz::applyClip): removed parameter (KCanvasImageQuartz::~KCanvasImageQuartz): (KCanvasImageQuartz::cgLayer): spacing (KCanvasImageQuartz::setCGLayer): spacing
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::clearPath): added. (KRenderingDeviceContextQuartz::addPath): added. (KRenderingDeviceQuartz::quartzContext): spacing
12:14 AM Changeset in webkit [12063] by darin
  • 1 edit in trunk/WebCore/kwq/KWQVectorImpl.cpp

Oops, land this file again (checked in wrong version last time).

12:12 AM Changeset in webkit [12062] by darin
  • 19 edits in trunk/WebCore

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Don't set APPLE_CHANGES or HAVE_CONFIG_H any more.
  • WebCore.xcodeproj/project.pbxproj: Don't set APPLE_CHANGES or KHTML_NO_CPLUSPLUS_DOM any more.
  • kcanvas/KCanvasFilters.h: Use APPLE instead of APPLE_CHANGES.
  • bridge/mac/MacFrame.mm: (MacFrame::respondToChangedContents):
  • kcanvas/KCanvasTreeDebug.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGElementImpl.h: (KSVG::svg_dynamic_cast):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • page/Frame.cpp: (Frame::paint): Make some APPLE_CHANGES code unconditional.
  • WebCore+SVG/kdom.h:
  • ksvg2/ecma/Ecma.cpp: (Ecma::setupDocument):
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp: Remove some !APPLE_CHANGES code.
  • ksvg2/svg/SVGDocumentImpl.h: Remove some unneeded APPLE_CHANGES code.
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox): Remove a misleading mention of APPLE_CHANGES in a comment.

Also changed tabs to spaces in files I am committing.

Jan 12, 2006:

11:22 PM Changeset in webkit [12061] by hyatt
  • 2 edits in trunk/WebCore

Land all of the KWQ .cpp files that have no Mac-specific dependencies (and thus compile as is on Win32)

11:05 PM Changeset in webkit [12060] by darin
  • 1 delete in trunk/JavaScriptCore/tests/test-file

Done testing.

11:04 PM Changeset in webkit [12059] by darin
  • 1 edit in trunk/JavaScriptCore/tests/test-file

testing pre-commit hook, please ignore

11:03 PM Changeset in webkit [12058] by darin
  • 1 add in trunk/JavaScriptCore/tests/test-file

testing pre-commit hook, please ignore

10:52 PM Changeset in webkit [12057] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add KWQArrayImpl.cpp to Win32 build.

9:54 PM Changeset in webkit [12056] by hyatt
  • 6 edits in trunk/WebCore

Make the misc directory compile on Win32.

9:39 PM Changeset in webkit [12055] by hyatt
  • 4 edits in trunk/WebCore

Make the page directory compile on Win32.

9:34 PM Changeset in webkit [12054] by hyatt
  • 14 edits in trunk/WebCore

Make the ecma directory compile on Win32.

5:51 PM Changeset in webkit [12053] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • kjs/create_hash_table: Use correct size variables.
5:36 PM Changeset in webkit [12052] by hyatt
  • 2 edits in trunk/WebCore

Make the XSL directory build on Win32.

5:32 PM Changeset in webkit [12051] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Hack the Visual Studio project file to use environment variables to properly locate the CSS grammar derived source on any machine.

5:31 PM Changeset in webkit [12050] by hyatt
  • 2 edits in trunk/WebCore

Flatten the includes in css_grammar.y. Fix clobber build bustage on Mac caused by the documentimpl rename. Make the CSS grammar file compile on Win32.

5:26 PM Changeset in webkit [12049] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Make the CSS directory compile on Win32.

5:24 PM Changeset in webkit [12048] by hyatt
  • 2 edits
    1 move in trunk/WebCore

Move the CSS parser.y file to css_grammar.y since parser.h is a header on Win32 that we don't want to conflict with.

5:12 PM Changeset in webkit [12047] by mjs
  • 2 edits
    2 deletes in trunk/WebCore

Reviewed by Dave Hyatt.

  • removed leftover files from form split, fix remaining include of the header.
  • khtml/html/html_formimpl.cpp: Removed.
  • khtml/html/html_formimpl.h: Removed.
  • page/Frame.cpp:
5:08 PM Changeset in webkit [12046] by hyatt
  • 5 edits in trunk/WebCore

Make the css directory nearly compile on Win32. One issue left with parser.h.

5:00 PM Changeset in webkit [12045] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh

Add a helpful log message when generating the JS grammar.

4:11 PM Changeset in webkit [12044] by hyatt
  • 3 edits in trunk/WebCore

Make the editing directory build on win32.

4:03 PM Changeset in webkit [12043] by hyatt
  • 1 add in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Add the bash script for construction of generated tables on Win32.

4:03 PM Changeset in webkit [12042] by hyatt
  • 14 edits in trunk/WebCore

Get the HTML directory compiling on win32.

4:01 PM Changeset in webkit [12041] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


  • make prepare-ChangeLog way faster by using svn diff instead of svn status to detect if there are any new tests
  • Scripts/prepare-ChangeLog:
3:25 PM Changeset in webkit [12040] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-01-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/create_hash_table: Don't create an empty entry array, instead add a entry with all fields set to null and set the hash table size to 1.


  • kjs/lookup.cpp: (findEntry): Remove the hash table size check
2:42 PM Changeset in webkit [12039] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.



  • fast/dom/DOMParser-assign-variable-expected.txt: Added.
  • fast/dom/DOMParser-assign-variable.html: Added.
2:39 PM Changeset in webkit [12038] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • JavaScriptCore.xcodeproj/project.pbxproj: Move lookup.cpp before lookup.h


  • kjs/lookup.cpp: (findEntry): If the hash table is empty, return 0 early.
1:47 PM Changeset in webkit [12037] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • fast/dom/css-rule-functions-expected.txt: Added.
  • fast/dom/css-rule-functions.html: Added.
1:44 PM Changeset in webkit [12036] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


  • fixed <rdar://problem/4406994> REGRESSION (TOT): zooming window at cnn.com makes window fill width of screen
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _largestChildWithScrollBars]): now skips zero-area frames, used by some evil ads
1:44 PM Changeset in webkit [12035] by andersca
  • 6 edits in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


This also makes updating the disabled flag on style sheets work.
It also adds the IE-only removeRule which is the counterpart to
the already existing addRule.


  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::insertRule): (CSSStyleSheetImpl::deleteRule): Call styleSheetChanged()


(CSSStyleSheetImpl::styleSheetChanged):
Call DocumentImpl::updateStyleSelector()


  • khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::setDisabled): Call styleSheetChanged();


(DOM::StyleSheetImpl::styleSheetChanged):
New function.


(DOM::CSSStyleSheetImpl::removeRule):
New IE extension function, simply calls deleteRule.


  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): Ignore disabled style sheets.


  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleSheet::): Add removeRule.
1:09 PM Changeset in webkit [12034] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

Fix win32 build bustage in interpreter.cpp

1:05 PM Changeset in webkit [12033] by hyatt
  • 1 edit
    1 add in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

Check in updated JSCore project that tracks generated file dependencies properly.

1:05 PM Changeset in webkit [12032] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim H.


  • fixed <rdar://problem/4265966> PDFs continue to show a (secondary) selection when the focus moves elsewhere
  • WebView.subproj/WebPDFView.h: added trackedFirstResponder ivar


  • WebView.subproj/WebPDFView.m: (-[WebPDFView dealloc]): assert that trackedFirstResponder is nil, as it was released/cleared in viewWillMoveToWindow: (-[WebPDFView _trackFirstResponder]): If the tracked first responder was the PDFView's documentView, and the current first responder isn't, deselect all. This is equivalent to overriding resignFirstResponder in the PDFView's documentView and deselecting all there, as other web document view classes do. Also, keep track of the new first responder for next time. (-[WebPDFView viewWillMoveToWindow:]): stop observing NSWindowDidUpdateNotification on the old window (-[WebPDFView viewDidMoveToWindow]): start observing NSWindowDidUpdateNotification on the new window, with _trackFirstResponder as the callback. Ideally we'd use a notification that tells us that the first responder is changing, but there is no such notification, so we have to use this very frequent one instead. The archaic 2573089 tracks the desire to have a responder-changed notification. (-[WebPDFView becomeFirstResponder]): removed comment about this bug that's now obsolete
11:01 AM Changeset in webkit [12031] by staikos
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add collector helper to interpreter in order to facilitate visibility rules in
KDE.

10:23 AM Changeset in webkit [12030] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.
Add missing assert.h and make it compile with the qmake file.

9:18 AM Changeset in webkit [12029] by darin
  • 1 edit
    4 deletes in trunk/WebKitTools
  • removed some of the cvs-specific scripts -- not needed for this project any more
  • Scripts/cvs-abandon: Removed.
  • Scripts/cvs-apply: Removed.
  • Scripts/cvs-create-patch: Removed.
  • Scripts/cvs-unapply: Removed.
8:58 AM Changeset in webkit [12028] by darin
  • 12 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Geoff.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed both APPLE_CHANGES and HAVE_CONFIG_H from all targets.
  • README: Removed. This had obsolete information in it and it wasn't clear what to replace it with.
  • kjs/collector.h: Removed an APPLE_CHANGES if around something that's not really platform-specific (although it does use a platform-specific API at the moment).
  • kjs/collector.cpp: Removed a mistaken comment.
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/object.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/ustring.h: Use APPLE instead of APPLE_CHANGES for code that should be used only on Mac OS X.
  • kjs/interpreter.cpp: Removed APPLE_CHANGES ifdef around the include of the runtime.h header. Even though that header isn't needed at the moment on platforms other than Mac OS X, the conditional stuff should be in the header itself, not in this one client.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed some code inside APPLE_CHANGES. I'm pretty sure this code isn't needed on any platform where pow is implemented corrrectly according to the IEEE standard. If it is needed on some, we can add it back with an appropriate #if for the platforms where it is needed.
8:48 AM Changeset in webkit [12027] by darin
  • 30 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.


  • fast/css/rtl-ordering-expected.checksum: Added.
  • fast/css/rtl-ordering-expected.png: Added.
  • fast/css/rtl-ordering-expected.txt: Added.
  • fast/css/rtl-ordering.html: Added.

WebCore:

Reviewed and landed by Darin.


Test: fast/css/rtl-ordering.html


  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Parse the new -khtml-rtl-ordering property.
  • khtml/css/cssproperties.in: Added -khtml-rtl-ordering property.
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyProperty): Apply the new property.
  • khtml/css/cssvalues.in: Added "logical" and "visual" values for the -khtml-rtl-ordering property.
  • khtml/css/html4.css: Force logical ordering in input-buttons.
  • khtml/css/makeprop: Fixed maximum property length computation.
  • khtml/rendering/render_style.h: Added initial value for visuallyOrdered.
  • ksvg2/scripts/cssmakeprops: Ensure no overlap between KHTML and SVG CSS properties.
  • ksvg2/scripts/cssmakevalues: Ensure no overlap between KHTML and SVG CSS values.
7:53 AM Changeset in webkit [12026] by darin
  • 3 edits in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_image.h: (khtml::RenderImage::pixmap): Return a const QPixmap&.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Avoid copying the QPixmap and its renderer.
7:47 AM Changeset in webkit [12025] by darin
  • 29 edits
    2 adds in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

  • bridge/mac/KWQKHTMLView.cpp:
  • kcanvas/RenderSVGText.cpp:
  • khtml/css/css_computedstyle.cpp:
  • kwq/KWQArrayImpl.cpp:
  • kwq/KWQBuffer.cpp:
  • kwq/KWQCString.cpp:
  • kwq/KWQCharsets.cpp:
  • kwq/KWQDateTime.cpp:
  • kwq/KWQDictImpl.cpp:
  • kwq/KWQGuardedPtr.cpp:
  • kwq/KWQKHTMLFactory.cpp:
  • kwq/KWQKPartsEvent.cpp:
  • kwq/KWQListImpl.cpp:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQObject.cpp:
  • kwq/KWQPen.cpp:
  • kwq/KWQPointArray.cpp:
  • kwq/KWQPtrDictImpl.cpp:
  • kwq/KWQRegion.cpp:
  • kwq/KWQStyle.cpp:
  • kwq/KWQTextCodec.cpp:
  • kwq/KWQTextStream.cpp:
  • kwq/KWQTimer.cpp:
  • kwq/KWQValueListImpl.cpp:
  • kwq/KWQVariant.cpp:
  • kwq/KWQVectorImpl.cpp:
  • kwq/KWQWMatrix.cpp: Replaced #import with #include.
  • kwq/KWQRegExp.cpp: Replaced #import with #include. Also changed <JavaScriptCore/pcre.h> to <pcre/pcre.h>.
  • ForwardingHeaders/pcre: Added.
  • ForwardingHeaders/pcre/pcre.h: Added.
7:25 AM Changeset in webkit [12024] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed, tweaked, and landed by Darin.

  • kjs/dtoa.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved dtoa.h include to the top. Changed system header includes to use angle brackets instead of quotes.
  • kjs/grammar.y: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets.
  • kjs/lexer.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved lexer.h include to the top.
  • kjs/ustring.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved ustring.h include to the top.
6:56 AM Changeset in webkit [12023] by sullivan
  • 2 edits in trunk/LayoutTests

Reviewed and committed by John Sullivan.


Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6500>
editing/selection/selection-actions layout test beeps annoyingly when run

  • editing/selection/selection-actions.html: Fixed two typos in selector names.
4:27 AM Changeset in webkit [12022] by eseidel
  • 125 edits
    6 copies
    2 moves
    3 deletes in trunk/WebCore

2006-01-12 Eric Seidel <​eseidel@apple.com>

Reviewed by anders & mjs.

Split dom_docimpl.* out into separate files (one per class):
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6502

  • ForwardingHeaders/kdom/core/DOMImplementationImpl.h: Removed.
  • ForwardingHeaders/kdom/core/DocumentImpl.h: Removed.
  • ForwardingHeaders/kdom/core/DocumentTypeImpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreBridge.mm:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/RenderSVGText.h:
  • khtml/css/css_base.cpp:
  • khtml/css/css_computedstyle.cpp:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/cssparser.cpp:
  • khtml/css/parser.y:
  • khtml/ecma/XSLTProcessor.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/markup.h:
  • khtml/editing/merge_identical_elements_command.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/editing/visible_units.cpp:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/Cache.cpp:
  • khtml/misc/DocLoader.cpp:
  • khtml/rendering/InlineTextBox.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_button.cpp:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/xml/DOMImplementationImpl.cpp: Added.
  • khtml/xml/DOMImplementationImpl.h: Added.
  • khtml/xml/DocumentFragmentImpl.cpp: Added.
  • khtml/xml/DocumentFragmentImpl.h: Added.
  • khtml/xml/DocumentImpl.cpp: Added. (DocumentImpl::setDocType): (DocumentImpl::getElementsByName):
  • khtml/xml/DocumentImpl.h: Added.
  • khtml/xml/DocumentTypeImpl.cpp: Added.
  • khtml/xml/DocumentTypeImpl.h: Added.
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_viewsimpl.cpp:
  • khtml/xml/dom_docimpl.cpp: Removed.
  • khtml/xml/dom_docimpl.h: Removed.
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_textimpl.cpp:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGPatternElementImpl.cpp:
  • ksvg2/svg/SVGPolyElementImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGStopElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • kwq/DOM-CSS.mm:
  • kwq/DOM.mm:
  • kwq/DOMEvents.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm:
  • kwq/DOMViews.mm:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQSlot.mm:
  • page/Frame.cpp:
3:48 AM Changeset in webkit [12021] by mjs
  • 2 edits in trunk/WebCore

Not reviewed.


  • fixed build breakage
  • ksvg2/misc/SVGImageLoader.cpp: Add dom_docimpl.h include
2:29 AM Changeset in webkit [12020] by mjs
  • 39 edits in trunk/WebCore

Reviewed by Eric.

  • remove dom_documentimpl.h include from other headers where possible, move down to impl files instead, so less rebuilds when you touch it
  • bridge/mac/MacFrame.mm: (MacFrame::openURLFromPageCache):
  • kcanvas/KCanvasResources.cpp:
  • khtml/css/css_computedstyle.cpp:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::frame):
  • khtml/editing/SelectionController.h:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/jsediting.h:
  • khtml/editing/markup.h:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/rendering/InlineTextBox.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_button.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::documentBeingDestroyed):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/xbl/xbl_docimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm:
2:22 AM Changeset in webkit [12019] by andersca
  • 2 edits in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Fix build

  • khtml/ecma/kjs_window.cpp: Remove include.
2:07 AM Changeset in webkit [12018] by andersca
  • 9 edits
    3 deletes in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6501

  • Merge KParts::BrowserInterface with KParts::BrowserExtension.


  • ForwardingHeaders/kparts/browserinterface.h: Removed.
  • bridge/mac/KWQKPartsBrowserInterface.mm: Removed.
  • kwq/KWQKPartsBrowserInterface.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.h:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): (KHTMLPartBrowserExtension::getHistoryLength): (KHTMLPartBrowserExtension::goBackOrForward):
  • bridge/mac/KWQKPartsBrowserExtension.h: (KParts::BrowserExtension::BrowserExtension):
  • khtml/ecma/kjs_window.cpp: (KJS::History::getValueProperty):
  • khtml/xml/xml_tokenizer.cpp:
  • page/Frame.cpp: (Frame::slotRedirect):
  • page/FrameView.cpp: Add getHistoryLength and goBackOrForward to BrowserExtension and use them.
1:21 AM Changeset in webkit [12017] by eseidel
  • 1 edit
    4 adds in trunk/WebCore

2006-01-12 Eric Seidel <​eseidel@apple.com>

Build fix, files missing from previous <image> commit:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • kcanvas/RenderSVGImage.cpp: Added. (RenderSVGImage::RenderSVGImage): (RenderSVGImage::~RenderSVGImage): (RenderSVGImage::paint): (RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h: Added.
  • ksvg2/misc/SVGImageLoader.cpp: Added. (SVGImageLoader::SVGImageLoader): (SVGImageLoader::~SVGImageLoader): (SVGImageLoader::updateFromElement):
  • ksvg2/misc/SVGImageLoader.h: Added.
12:57 AM Changeset in webkit [12016] by eseidel
  • 24 edits
    3 moves
    9 adds in trunk/LayoutTests

2006-01-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel.

Updated results from after <image> fixes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f.svg: Added.
  • svg/W3C-SVG-1.1/filters-light-01-f.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt Added.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png Added.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg: Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum Added.
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t.svg: Added.
  • svg/W3C-SVG-1.1/render-groups-03-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
12:46 AM Changeset in webkit [12015] by andersca
  • 15 edits
    1 move
    2 deletes in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6496

  • Merge KParts::Part with KParts::ReadOnly part and rename it to ObjectContents.


  • ForwardingHeaders/kparts/part.h: Removed.
  • kwq/KWQKPartsPart.h: Removed.
  • kwq/KWQKPartsPart.mm: Removed.
  • kwq/KWQObject.cpp:


page/ObjectContents.h: Added
(ObjectContents::ObjectContents):
(ObjectContents::url):
(ObjectContents::setName):
(ObjectContents::widget):
(ObjectContents::setWidget):
(ObjectContents::ref):
(ObjectContents::deref):
(ObjectContents::event):
(ObjectContents::customEvent):
(ObjectContents::isObjectContents):

Renames:


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.h:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • bridge/mac/KWQKPartsBrowserExtension.h:
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::createPart):
  • bridge/mac/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::indexGetter): (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (QObject::inherits): (QObject::isObjectContents):
  • kwq/KWQObject.h:
  • page/Frame.cpp: (Frame::stopLoading): (Frame::stopAnimations): (Frame::checkEmitLoadEvent): (Frame::processObjectRequest): (Frame::childFrame): (Frame::findFrame): (Frame::setZoomFactor): (Frame::frames): (Frame::customEvent): (Frame::slotPartRemoved): (Frame::connectChild): (Frame::disconnectChild): (Frame::setPolicyBaseURL): (Frame::setName):
  • page/Frame.h: (Frame::Frame):
  • page/FramePrivate.h:
12:33 AM Changeset in webkit [12014] by eseidel
  • 7 edits in trunk/WebCore

2006-01-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Refactor HTMLImageLoader to make subclassing possible. Implement
RenderSVGText-style RenderImage subclass. Use this to reimplement
SVGImageElementImpl.

As a side effect, this should fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/RenderSVGImage.cpp: Added. (RenderSVGImage::RenderSVGImage): (~RenderSVGImage::RenderSVGImage): (RenderSVGImage::paint): (RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h: Added.
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageLoader::setLoadingImage): trivial method extraction (DOM::HTMLImageLoader::updateFromElement): make virtual
  • khtml/html/html_imageimpl.h: (DOM::):
  • ksvg2/misc/SVGImageLoader.cpp: Added. (SVGImageLoader::SVGImageLoader): (~SVGImageLoader:SVGImageLoader): (SVGImageLoader::updateFromElement):
  • ksvg2/misc/SVGImageLoader.h: Added.
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::SVGImageElementImpl): (SVGImageElementImpl::parseMappedAttribute): (SVGImageElementImpl::createRenderer): (SVGImageElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.h:
12:19 AM Changeset in webkit [12013] by hyatt
  • 5 edits in trunk/WebCore

Get most of the XML dir compiling on Win32.

Jan 11, 2006:

11:49 PM Changeset in webkit [12012] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Nearly have the xml directory compiling on Win32. Just need to deal with the cssproperties.in file.

11:47 PM Changeset in webkit [12011] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Minor change to make the grammar.cpp end up in the DerivedSources directory instead of the main source tree.

10:22 PM Changeset in webkit [12010] by staikos
  • 1 edit
    1 add in trunk/JavaScriptCore

Reviewed by Maciej

Add QMake file

8:44 PM Changeset in webkit [12009] by justing
  • 2 edits in trunk/WebCore

Replaced two asserts that I accidently removed in
the build bustage fix.

  • page/Frame.cpp: (Frame::revealSelection): (Frame::centerSelectionInVisibleArea):
8:22 PM Changeset in webkit [12008] by justing
  • 5 edits in trunk/WebCore

Reviewed by kevin

The removal of Frame::clearSelection() broke a layout
test. clearSelection did setSelection(SelectionController()), which
is not the same as selection().clear(). setSelection() notifies
the editing delegate of a selection change. This is non obvious
and should be fixed. Filed:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6498>
SelectionController's setters should notify delegates of selection changes

  • bridge/mac/WebCoreBridge.mm: (-[WebCoreBridge deselectText]):
  • khtml/editing/jsediting.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::clearSelectionIfNeeded):
7:27 PM Changeset in webkit [12007] by justing
  • 5 edits in trunk/LayoutTests

Reviewed by bdash


I used apple.com as the iframe src in the last checkin,
oops. I just use another layout test for the src now.

  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/iframe-expected.txt:
  • editing/selection/iframe.html:
6:32 PM Changeset in webkit [12006] by justing
  • 4 edits
    12 adds in trunk/LayoutTests

Reviewed by darin


New/updated layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5870>
Double-clicking on an SVG dies in HTML editing code
<rdar://problem/4393815>
Assertion failure: result != *this (khtml::VisiblePosition::previous())

  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/selection/iframe-expected.checksum: Added.
  • editing/selection/iframe-expected.png: Added.
  • editing/selection/iframe-expected.txt: Added.
  • editing/selection/iframe.html: Added.
  • editing/selection/inline-table-expected.checksum: Added.
  • editing/selection/inline-table-expected.png: Added.
  • editing/selection/inline-table-expected.txt: Added.
  • editing/selection/inline-table.html: Added.
  • editing/selection/select-box-expected.checksum: Added.
  • editing/selection/select-box-expected.png: Added.
  • editing/selection/select-box-expected.txt: Added.
  • editing/selection/select-box.html: Added.
6:28 PM Changeset in webkit [12005] by justing
  • 18 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5870>
Double-clicking on an SVG dies in HTML editing code
<rdar://problem/4393815>
Assertion failure: result != *this (khtml::VisiblePosition::previous())
+ build bustage fix from previous checkin

Tests added (+ expected results):

  • editing/selection/iframe.html: Added.
  • editing/selection/inline-table.html: Added.
  • editing/selection/select-box.html: Added.


Test results changed (change looks funny but is correct):

  • editing/inserting/editing-empty-divs.html


Account for replaced elements with children in isCandidate and maxDeepOffset
Stop at candidates in VisiblePosition::deepEquivalent, descending will
yield positions that aren't visually equivalent.
Fixed a caret painting regression (removed downstreamDeepEquivalent)
Moved isAtomicNode and maxDeepOffset out of NodeImpl
Removed redundant code


Todo:
Move more editing functions out of NodeImpl
Improve the selection of VP candidates to fix 6476

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::xPosForVerticalArrowNavigation): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::layout): (khtml::SelectionController::adjustForEditableContent):
  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete): (khtml::DeleteSelectionCommand::handleGeneralDelete):
  • khtml/editing/htmlediting.cpp: (khtml::isAtomicNode): (khtml::maxDeepOffset): (khtml::isLastVisiblePositionInSpecialElement): (khtml::positionAfterContainingSpecialElement):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::isCandidate): (khtml::VisiblePosition::deepEquivalent): (khtml::VisiblePosition::character): (khtml::makeRange): (khtml::setStart): (khtml::setEnd): (khtml::enclosingBlockFlowElement): (khtml::isFirstVisiblePositionInNode): (khtml::isLastVisiblePositionInNode):
  • khtml/editing/visible_position.h: (khtml::VisiblePosition::setAffinity):
  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): (khtml::nextLinePosition):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::previousNodeConsideringAtomicNodes): (DOM::NodeImpl::nextNodeConsideringAtomicNodes): (DOM::NodeImpl::previousLeafNode): (DOM::NodeImpl::nextLeafNode): (DOM::NodeImpl::isBlockFlowOrBlockTable): (DOM::NodeImpl::enclosingBlockFlowOrTableElement):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atEnd): (DOM::isStreamer): (DOM::Position::upstream): (DOM::Position::downstream):
  • khtml/xml/dom_position.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXUIElementForTextMarker:]):
  • page/Frame.cpp: (Frame::selectContentsOfNode):
5:37 PM Changeset in webkit [12004] by mjs
  • 8 edits in trunk/WebCore

Reviewed by Darin.

  • remove some selection-related methods on Frame that are just simple wrappers of Selection methods.
  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling):
  • bridge/mac/WebCoreBridge.mm: (-[WebCoreBridge deselectText]): (-[WebCoreBridge selectedAttributedString]): (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]):
  • khtml/editing/jsediting.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::clearSelectionIfNeeded):
  • page/Frame.cpp: (Frame::selection): (Frame::currentForm): (Frame::revealSelection): (Frame::centerSelectionInVisibleArea):
  • page/Frame.h:
  • page/FrameView.cpp: (KHTMLView::clear):
5:28 PM Changeset in webkit [12003] by mjs
  • 19 edits in trunk/WebCore

Reviewed by Darin.

  • reduce the number of files that rebuild when you touch Frame.h
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (convertAttributesToUnderlines):
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp: (DOM::HTMLKeygenElementImpl::appendFormData):
  • khtml/html/html_imageimpl.cpp:
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::paintMarkedTextUnderline):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/render_layer.cpp:
  • khtml/xml/dom_docimpl.cpp:
  • kwq/KWQAccObject.mm: (-[KWQAccObject value]):
  • kwq/KWQFileButton.h:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQRenderTreeDebug.cpp: (write):
  • page/Frame.cpp: (Frame::markedTextUnderlines):
  • page/Frame.h: (MarkedTextUnderline::MarkedTextUnderline):
4:14 PM Changeset in webkit [12002] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
9:28 AM Changeset in webkit [12001] by darin
  • 53 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej and Darin, landed by Darin.

  • kjs/grammar.y: Added rule to allow trailing comma in object construction.

LayoutTests:

Reviewed by Maciej, reworked and landed by Darin.

  • fast/js/resources/object-extra-comma.js: Added.
  • fast/js/object-extra-comma.html: Added.
  • fast/js/object-extra-comma-expected.txt: Added.
  • fast/js/resources/js-test-pre.js: Fixed a typo.
  • fast/js/*: Set some MIME types.
9:00 AM Changeset in webkit [12000] by darin
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Geoff, landed by Darin.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Fixed a "<" that should have been a "<=".

LayoutTests:

Reviewed by Geoff, reworked and landed by Darin.

  • fast/js/resources/number-tofixed.js: Added some test cases for toFixed(1).
  • fast/js/number-tofixed-expected.txt: Updated.
8:47 AM Changeset in webkit [11999] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff, landed by Darin.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Fixed a ">" that should have been a ">=".

LayoutTests:

Reviewed by Geoff, reworked and landed by Darin.

  • fast/js/number-tofixed-expected.txt: Added.
  • fast/js/number-tofixed.html: Added.
  • fast/js/resources/number-tofixed.js: Added.
8:19 AM Changeset in webkit [11998] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed and landed by Darin.

  • kjs/config.h: Add USE_SYSTEM_MALLOC to the Win32 section.
2:08 AM Changeset in webkit [11997] by andersca
  • 2 edits in trunk/WebCore

2006-01-11 Anders Carlsson <​andersca@mac.com>

Build fix.


  • ForwardingHeaders/ksvg2/KSVGView.h: Rename KHTMLView to FrameView and include FrameView.h
1:36 AM Changeset in webkit [11996] by mjs
  • 55 edits
    3 moves in trunk/WebCore

Reviewed by Anders.

(also corresponding header renames, remove headers where not
needed, and a few substantive changes to allow more header removal)

  • khtml/xml/dom_docimpl.h: moved m_selectedStylesheetSet here from KHTMLPartPrivate, since this was the only class using it.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): ditto (DocumentImpl::selectedStylesheetSet): ditto (DocumentImpl::setSelectedStylesheetSet): ditto (DocumentImpl::recalcStyleSelector): ditto
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): Use new isCompleted method on Frame instead of accessing private field directly. (KJS::getDOMDocumentNode): remove gratuitous use of view()


Just the renames:


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLView.cpp:
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreBridge.mm:
  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQSignalStubs.mm:
  • kwq/KWQWidget.mm:
  • page/Frame.cpp: (Frame::init): (Frame::submitForm): (Frame::isComplete):
  • page/Frame.h:
  • page/FramePrivate.h: Added. (FramePrivate::FramePrivate): (FramePrivate::~FramePrivate):
  • page/FrameView.cpp: Added.
  • page/FrameView.h: Added.
  • page/khtmlpart_p.h: Removed.
  • page/khtmlview.cpp: Removed.
  • page/khtmlview.h: Removed.

Jan 10, 2006:

10:34 PM Changeset in webkit [12228] by darin
  • 26 edits in trunk/JavaScriptGlue

top level:

  • Makefile: Removed some unneeded stray characters.
  • <tons of files>: Updated flags (removed executable, set MIME types, etc.)

Tools:

  • Makefile: Removed some unneeded stray characters.
  • Tools/Scripts/commit-log-editor: Updated to handle paths with spaces.

Tests:

  • performance: Removed.
9:50 PM Changeset in webkit [11995] by darin
  • 8899 edits in trunk
  • Makefile: Took out unneeded "export" line.
  • <many-files>: Changed a lot of flags (cleared bogus executable bits, set MIME types, other small corrections).
6:48 PM Changeset in webkit [11994] by mjs
  • 4 edits
    14 moves
    3 adds in trunk/WebCore

Reviewed by Darin.

  • moved files related to the Frame class and the forthcoming Page class to WebCore/page


  • moved files related to the MacFrame class and other bridging-related classes to WebCore/bridge/mac
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge: Added.
  • bridge/mac: Added.
  • bridge/mac/KWQKHTMLPartBrowserExtension.h: Added.
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: Added.
  • bridge/mac/KWQKHTMLView.cpp: Added.
  • bridge/mac/KWQKPartsBrowserExtension.h: Added.
  • bridge/mac/KWQKPartsBrowserInterface.mm: Added.
  • bridge/mac/MacFrame.h: Added.
  • bridge/mac/MacFrame.mm: Added.
  • bridge/mac/WebCoreBridge.h: Added.
  • bridge/mac/WebCoreBridge.mm: Added.
  • khtml/Frame.cpp: Removed.
  • khtml/Frame.h: Removed.
  • khtml/khtmlpart_p.h: Removed.
  • khtml/khtmlview.cpp: Removed.
  • khtml/khtmlview.h: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.h: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.mm: Removed.
  • kwq/KWQKHTMLView.cpp: Removed.
  • kwq/KWQKPartsBrowserExtension.h: Removed.
  • kwq/KWQKPartsBrowserInterface.mm: Removed.
  • kwq/MacFrame.h: Removed.
  • kwq/MacFrame.mm: Removed.
  • kwq/WebCoreBridge.h: Removed.
  • kwq/WebCoreBridge.mm: Removed.
  • page: Added.
  • page/Frame.cpp: Added.
  • page/Frame.h: Added.
  • page/khtmlpart_p.h: Added.
  • page/khtmlview.cpp: Added.
  • page/khtmlview.h: Added.
4:32 PM Changeset in webkit [11993] by hyatt
  • 2 edits in trunk/WebCore

#if Win32 the KWQMemArray overloads, since they're working around
a Windows compiler bug.


  • kwq/KWQMemArray.h:
4:20 PM Changeset in webkit [11992] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/RenderText.cpp

Fix other gnuc spot.

4:19 PM Changeset in webkit [11991] by hyatt
  • 2 edits in trunk/WebCore

Fix the broken ifdef in KWQString.h

  • kwq/KWQString.h:
2:36 PM Changeset in webkit [11990] by hyatt
  • 93 edits in trunk/WebCore

Land fix for bug 6458.

2:20 PM Changeset in webkit [11989] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-10 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel. Committed by eseidel.

  • Scripts/run-webkit-tests: Add a command-line flag to prevent Safari being launched to display failed tests. Always exit with non-zero status when tests have failed.
2:18 PM Changeset in webkit [11988] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-10 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel. Committed by eseidel.

  • Scripts/build-webkit: Use correct bits of subprocess exit code when passing back through as build-webkit's exit code.
12:59 PM Changeset in webkit [11987] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Remove the need for the WebKitTools environment variable.

6:01 AM Changeset in webkit [11986] by eseidel
  • 2 edits in trunk/WebCore

2006-01-10 Eric Seidel <​eseidel@apple.com>

No review needed, build (linking deployment) fix only.

  • kwq/MacFrame.h: remove bogus KHTMLView *view() const delcaration
5:46 AM Changeset in webkit [11985] by eseidel
  • 4 edits in trunk/WebCore

2006-01-10 Eric Seidel <​eseidel@apple.com>

Roll out local changes committed by accident w/ Mitz's patch.

  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::getAccObjectID): (KWQAccObjectCache::removeAccObjectID): (KWQAccObjectCache::textMarkerForVisiblePosition): (KWQAccObjectCache::visiblePositionForTextMarker): (KWQAccObjectCache::childrenChanged):
  • kwq/KWQObject.cpp: (QObject::restartTimer): (QObject::timerIntervals): (deleteTimer): (QObject::killTimer): (deleteOneTimer): (QObject::killTimers): (sendDeferredTimerEvent):
5:35 AM Changeset in webkit [11984] by eseidel
  • 5 edits in trunk/WebCore

2006-01-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

No tests possible, no functionality changes.

Reviewed by darin. Committed by eseidel.


  • khtml/rendering/bidi.cpp: (khtml::operator==): Return true if BidiContexts match and both don't have a parent.
5:23 AM Changeset in webkit [11983] by eseidel
  • 2 edits
    16 adds in trunk/WebKitTools

2006-01-10 Eric Seidel <​eseidel@apple.com>

Restored corrupted nibs from TOT CVS.

  • DrawTest/English.lproj/DrawTestDocument.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/info.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/info.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/info.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/info.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/keyedobjects.nib: Replaced.
4:45 AM Changeset in webkit [11982] by eseidel
  • 13 edits in trunk/WebKitTools

2006-01-10 Nefaur Khandker <​nefaurk@gmail.com>

Reviewed by eseidel. Committed by eseidel.

DrawTestView now subclasses WebView instead of DrawView.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DrawTest/DrawTestDocument.h:
  • DrawTest/DrawTestDocument.m: (-[DrawTestDocument dealloc]): (-[DrawTestDocument readFromFile:ofType:]): (-[DrawTestDocument windowControllerDidLoadNib:]): (-[DrawTestDocument dumpSVGToConsole:]): (-[DrawTestDocument openSourceForSelection:]): (-[DrawTestDocument dataRepresentationOfType:]):
  • DrawTest/DrawTestToolbarController.h:
  • DrawTest/DrawTestToolbarController.m: (-[DrawTestToolbarController initWithDrawView:]): (-[DrawTestToolbarController clickedToolbarItem:]): (-[DrawTestToolbarController validateToolbarItem:]):
  • DrawTest/DrawTestView.h:
  • DrawTest/DrawTestView.m: (-[DrawTestView initWithFrame:]): (-[DrawTestView setDocument:]):
  • DrawTest/SVGTest.h:
  • DrawTest/SVGTest.m: (+[SVGTest sharedDrawView]): (-[SVGTest generateCompositeIfNecessary]):
  • DrawTest/TestController.h:
  • DrawTest/TestController.m: (-[TestController awakeFromNib]): (-[TestController setSelectedTest:]): (-[TestController openTestViewerForSelection:]): (-[TestController toggleViewersScaleRule:]):
  • DrawTest/TestViewerSplitView.m: (-[TestViewerSplitView drawRect:]):
4:40 AM Changeset in webkit [11981] by eseidel
  • 2 edits in trunk/WebCore

2006-01-10 Eric Seidel <​eseidel@apple.com>

Removed broken links in project file, no review need.

  • WebCore.xcodeproj/project.pbxproj:
3:03 AM Changeset in webkit [11980] by mjs
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Eric.

  • move C++-only methods down from Frame to MacFrame
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/Frame.cpp: (Frame::init): (Frame::setSettings): (Frame::provisionalLoadStarted): (Frame::userGestureHint): (Frame::renderer): (Frame::selectionRect): (Frame::isFrameSet): (Frame::openURL): (Frame::didNotOpenURL): (Frame::selectionStart): (scanForForm): (Frame::currentForm): (Frame::setEncoding): (Frame::addData): (Frame::revealSelection): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::pauseTimeouts): (Frame::resumeTimeouts): (Frame::canCachePage): (Frame::saveWindowProperties): (Frame::saveLocationProperties): (Frame::restoreWindowProperties): (Frame::restoreLocationProperties): (Frame::saveInterpreterBuiltins): (Frame::restoreInterpreterBuiltins): (Frame::frameForWidget): (Frame::frameForNode): (Frame::nodeForWidget): (Frame::setDocumentFocus): (Frame::clearDocumentFocus): (Frame::mutableInstances): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayout): (Frame::forceLayoutWithPageWidthRange): (Frame::sendResizeEvent): (Frame::sendScrollEvent): (Frame::scrollbarsVisible): (Frame::addMetaData): (Frame::scrollToAnchor): (Frame::closeURL): (Frame::canMouseDownStartSelect): (Frame::khtmlMouseDoubleClickEvent): (Frame::passWidgetMouseDownEventToWidget): (Frame::clearTimers): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart): (Frame::selectionStartOffset): (Frame::selectionEndOffset): (Frame::selectionEnd): (Frame::setMediaType): (Frame::setSelectionFromNone): (Frame::displaysWithFocusAttributes): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol): (Frame::setName): (Frame::markedTextUsesUnderlines): (Frame::markedTextUnderlines): (Frame::prepareForUserAction): (Frame::isFrame): (Frame::mousePressNode):
  • khtml/Frame.h: (Frame::instances): (Frame::MarkedTextUnderline::MarkedTextUnderline):
  • kwq/MacFrame.cpp: Removed.
  • kwq/MacFrame.h: (MacFrame::markedTextRange):
  • kwq/MacFrame.mm: - humped a bunch of stuff down to Frame
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): use Mac calls
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): ditto
1:33 AM Changeset in webkit [11979] by eseidel
  • 24 edits
    28 copies
    1 add in trunk/WebCore

2006-01-10 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Split html_formimpl.{cpp,h} into multiple files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6461

  • WebCore.xcodeproj/project.pbxproj: added files
  • khtml/ecma/kjs_html.cpp: updated includes
  • khtml/html/FormDataList.h: Added.
  • khtml/html/FormDataList.cpp: Added.
  • khtml/html/HTMLButtonElementImpl.cpp: Added.
  • khtml/html/HTMLButtonElementImpl.h: Added.
  • khtml/html/HTMLFieldSetElementImpl.cpp: Added.
  • khtml/html/HTMLFieldSetElementImpl.h: Added.
  • khtml/html/HTMLFormElementImpl.cpp: Added.
  • khtml/html/HTMLFormElementImpl.h: Added.
  • khtml/html/HTMLGenericFormElementImpl.cpp: Added.
  • khtml/html/HTMLGenericFormElementImpl.h: Added.
  • khtml/html/HTMLInputElementImpl.cpp: Added.
  • khtml/html/HTMLInputElementImpl.h: Added.
  • khtml/html/HTMLIsIndexElementImpl.cpp: Added.
  • khtml/html/HTMLIsIndexElementImpl.h: Added.
  • khtml/html/HTMLKeygenElementImpl.cpp: Added.
  • khtml/html/HTMLKeygenElementImpl.h: Added.
  • khtml/html/HTMLLabelElementImpl.cpp: Added.
  • khtml/html/HTMLLabelElementImpl.h: Added.
  • khtml/html/HTMLLegendElementImpl.cpp: Added.
  • khtml/html/HTMLLegendElementImpl.h: Added.
  • khtml/html/HTMLOptGroupElementImpl.cpp: Added.
  • khtml/html/HTMLOptGroupElementImpl.h: Added.
  • khtml/html/HTMLOptionElementImpl.cpp: Added.
  • khtml/html/HTMLOptionElementImpl.h: Added.
  • khtml/html/HTMLOptionsCollectionImpl.h: Added.
  • khtml/html/HTMLSelectElementImpl.cpp: Added.
  • khtml/html/HTMLSelectElementImpl.h: Added.
  • khtml/html/HTMLTextAreaElementImpl.cpp: Added.
  • khtml/html/HTMLTextAreaElementImpl.h: Added.
  • khtml/html/html_documentimpl.cpp: updated includes
  • khtml/html/html_imageimpl.cpp: updated includes
  • khtml/html/html_miscimpl.cpp: updated includes
  • khtml/html/html_objectimpl.cpp: updated includes
  • khtml/html/htmlfactory.cpp: updated includes
  • khtml/html/htmlparser.cpp: updated includes
  • khtml/khtmlview.cpp: updated includes
  • khtml/rendering/render_block.cpp: updated includes
  • khtml/rendering/render_button.cpp: updated includes
  • khtml/rendering/render_canvasimage.cpp: updated includes
  • khtml/rendering/render_flow.cpp: updated includes
  • khtml/rendering/render_form.cpp: updated includes
  • khtml/rendering/render_form.h: updated includes
  • khtml/rendering/render_image.cpp: updated includes
  • khtml/rendering/render_line.cpp: updated includes
  • khtml/rendering/render_theme.cpp: updated includes
  • khtml/xml/dom_docimpl.cpp: updated includes
  • kwq/DOMHTML.mm: updated includes
  • kwq/KWQAccObject.mm: updated includes
  • kwq/MacFrame.mm: updated includes
  • kwq/WebCoreBridge.mm: updated includes

Jan 9, 2006:

10:03 PM Changeset in webkit [11978] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

Test case: fast/parser/entity-surrogate-pairs.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Don't check if we got a surrogate.
9:52 PM Changeset in webkit [11977] by hyatt
  • 4 adds in trunk/WebCore/WebCore.vcproj

Commit the Visual Studio project for WebCore.

7:32 PM Changeset in webkit [11976] by eseidel
  • 5 edits in trunk/WebCore

2006-01-09 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Further code removal (and build fix!)

  • khtml/Frame.cpp: (Frame::init): (Frame::~Frame): (Frame::restoreURL): (Frame::didOpenURL): (Frame::baseURL): (Frame::baseTarget):
  • khtml/Frame.h: (Frame::khtmlMouseDoubleClickEvent): (Frame::khtmlDrawContentsEvent):
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
6:24 PM Changeset in webkit [11975] by eseidel
  • 5 edits in trunk/WebCore

2006-01-09 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove unused code from Frame.

  • khtml/Frame.cpp: (Frame::clear): (Frame::receivedFirstData): (Frame::checkCompleted): (Frame::completeURL): (Frame::khtmlMousePressEvent): (Frame::handleMouseMoveEventSelection): (Frame::khtmlMouseReleaseEvent):
  • khtml/Frame.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): (KHTMLView::focusOutEvent):
5:26 PM Changeset in webkit [11974] by eseidel
  • 21 edits
    9 deletes in trunk/WebCore

2006-01-09 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Remove khtml-specific forwarding headers.

  • ForwardingHeaders/css: Removed.
  • ForwardingHeaders/css/css_base.h: Removed.
  • ForwardingHeaders/css/css_computedstyle.h: Removed.
  • ForwardingHeaders/css/css_ruleimpl.h: Removed.
  • ForwardingHeaders/css/css_stylesheetimpl.h: Removed.
  • ForwardingHeaders/css/css_valueimpl.h: Removed.
  • ForwardingHeaders/css/csshelper.h: Removed.
  • ForwardingHeaders/css/cssparser.h: Removed.
  • ForwardingHeaders/css/cssproperties.h: Removed.
  • ForwardingHeaders/css/cssstyleselector.h: Removed.
  • ForwardingHeaders/css/cssvalues.h: Removed.
  • ForwardingHeaders/dom: Removed.
  • ForwardingHeaders/dom/css_rule.h: Removed.
  • ForwardingHeaders/dom/css_stylesheet.h: Removed.
  • ForwardingHeaders/dom/css_value.h: Removed.
  • ForwardingHeaders/dom/dom2_events.h: Removed.
  • ForwardingHeaders/dom/dom2_range.h: Removed.
  • ForwardingHeaders/dom/dom2_traversal.h: Removed.
  • ForwardingHeaders/dom/dom_exception.h: Removed.
  • ForwardingHeaders/dom/dom_node.h: Removed.
  • ForwardingHeaders/dom/dom_string.h: Removed.
  • ForwardingHeaders/ecma: Removed.
  • ForwardingHeaders/ecma/kjs_binding.h: Removed.
  • ForwardingHeaders/ecma/kjs_dom.h: Removed.
  • ForwardingHeaders/ecma/kjs_proxy.h: Removed.
  • ForwardingHeaders/editing: Removed.
  • ForwardingHeaders/editing/SelectionController.h: Removed.
  • ForwardingHeaders/editing/edit_actions.h: Removed.
  • ForwardingHeaders/editing/html_interchange.h: Removed.
  • ForwardingHeaders/editing/htmlediting.h: Removed.
  • ForwardingHeaders/editing/jsediting.h: Removed.
  • ForwardingHeaders/editing/markup.h: Removed.
  • ForwardingHeaders/editing/text_affinity.h: Removed.
  • ForwardingHeaders/editing/text_granularity.h: Removed.
  • ForwardingHeaders/editing/visible_position.h: Removed.
  • ForwardingHeaders/editing/visible_text.h: Removed.
  • ForwardingHeaders/editing/visible_units.h: Removed.
  • ForwardingHeaders/html: Removed.
  • ForwardingHeaders/html/html_baseimpl.h: Removed.
  • ForwardingHeaders/html/html_blockimpl.h: Removed.
  • ForwardingHeaders/html/html_canvasimpl.h: Removed.
  • ForwardingHeaders/html/html_documentimpl.h: Removed.
  • ForwardingHeaders/html/html_elementimpl.h: Removed.
  • ForwardingHeaders/html/html_formimpl.h: Removed.
  • ForwardingHeaders/html/html_headimpl.h: Removed.
  • ForwardingHeaders/html/html_imageimpl.h: Removed.
  • ForwardingHeaders/html/html_inlineimpl.h: Removed.
  • ForwardingHeaders/html/html_listimpl.h: Removed.
  • ForwardingHeaders/html/html_miscimpl.h: Removed.
  • ForwardingHeaders/html/html_objectimpl.h: Removed.
  • ForwardingHeaders/html/html_tableimpl.h: Removed.
  • ForwardingHeaders/html/htmlparser.h: Removed.
  • ForwardingHeaders/html/htmltokenizer.h: Removed.
  • ForwardingHeaders/misc: Removed.
  • ForwardingHeaders/misc/decoder.h: Removed.
  • ForwardingHeaders/misc/formdata.h: Removed.
  • ForwardingHeaders/misc/helper.h: Removed.
  • ForwardingHeaders/misc/khtmllayout.h: Removed.
  • ForwardingHeaders/misc/loader.h: Removed.
  • ForwardingHeaders/misc/loader_client.h: Removed.
  • ForwardingHeaders/misc/shared.h: Removed.
  • ForwardingHeaders/misc/stringit.h: Removed.
  • ForwardingHeaders/rendering: Removed.
  • ForwardingHeaders/rendering/font.h: Removed.
  • ForwardingHeaders/rendering/render_applet.h: Removed.
  • ForwardingHeaders/rendering/render_block.h: Removed.
  • ForwardingHeaders/rendering/render_box.h: Removed.
  • ForwardingHeaders/rendering/render_br.h: Removed.
  • ForwardingHeaders/rendering/render_canvas.h: Removed.
  • ForwardingHeaders/rendering/render_canvasimage.h: Removed.
  • ForwardingHeaders/rendering/render_flow.h: Removed.
  • ForwardingHeaders/rendering/render_form.h: Removed.
  • ForwardingHeaders/rendering/render_frames.h: Removed.
  • ForwardingHeaders/rendering/render_image.h: Removed.
  • ForwardingHeaders/rendering/render_layer.h: Removed.
  • ForwardingHeaders/rendering/render_line.h: Removed.
  • ForwardingHeaders/rendering/render_list.h: Removed.
  • ForwardingHeaders/rendering/render_object.h: Removed.
  • ForwardingHeaders/rendering/render_replaced.h: Removed.
  • ForwardingHeaders/rendering/render_style.h: Removed.
  • ForwardingHeaders/rendering/render_table.h: Removed.
  • ForwardingHeaders/rendering/table_layout.h: Removed.
  • ForwardingHeaders/xbl: Removed.
  • ForwardingHeaders/xbl/xbl_binding_manager.h: Removed.
  • ForwardingHeaders/xml: Removed.
  • ForwardingHeaders/xml/EventNames.h: Removed.
  • ForwardingHeaders/xml/dom2_eventsimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_rangeimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_traversalimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_viewsimpl.h: Removed.
  • ForwardingHeaders/xml/dom_atomicstring.h: Removed.
  • ForwardingHeaders/xml/dom_docimpl.h: Removed.
  • ForwardingHeaders/xml/dom_elementimpl.h: Removed.
  • ForwardingHeaders/xml/dom_nodeimpl.h: Removed.
  • ForwardingHeaders/xml/dom_position.h: Removed.
  • ForwardingHeaders/xml/dom_stringimpl.h: Removed.
  • ForwardingHeaders/xml/dom_textimpl.h: Removed.
  • ForwardingHeaders/xml/dom_xmlimpl.h: Removed.
  • ForwardingHeaders/xml/xml_tokenizer.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/khtml_part.cpp:
  • khtml/misc/decoder.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/xml/dom_elementimpl.cpp:
5:15 PM Changeset in webkit [11973] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the default language to "en", so language tests will work.
5:14 PM Changeset in webkit [11972] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

This is a test commit and a cleanup.

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: Set the default language to "en", so language tests will work.
4:22 PM Changeset in webkit [11971] by andersca
  • 2 edits in trunk/WebKitTools

2006-01-10 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the default language to "en", so language tests will work.
3:24 PM Changeset in webkit [11970] by andersca
  • 5 edits in trunk/WebCore

2006-01-10 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • renamed ChildFrame::m_frame to m_renderer and ChildFrame::m_part to m_frame which makes more sense.


This also fixes some bugs which were introduced in Maciej's
previous commit.


  • khtml/Frame.cpp: (Frame::stopLoading): (Frame::clear): (Frame::stopAnimations): (Frame::checkEmitLoadEvent): (Frame::requestFrame): (Frame::requestObject): (Frame::processObjectRequest): (Frame::childFrame): (Frame::findFrame): (Frame::frameExists): (Frame::setZoomFactor): (Frame::frames): (Frame::childFrameNamed): (Frame::connectChild): (Frame::disconnectChild): (Frame::handleFallbackContent):
  • khtml/khtmlpart_p.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement):
  • kwq/MacFrame.mm: (Frame::frameDetached): (MacFrame::createPart): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::setPolicyBaseURL):
3:21 PM Changeset in webkit [11969] by ggaren
  • 3 edits in trunk/WebKit

small terminology fixup recommended in review

2:31 PM Changeset in webkit [11968] by hyatt
  • 1 delete in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore.suo

Remove the .suo file. Not needed.

2:29 PM Changeset in webkit [11967] by hyatt
  • 3 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in a fixed JSCore project.

1:39 PM Changeset in webkit [11966] by mjs
  • 107 edits
    5 moves in trunk/WebCore

Reviewed by Darin.

  • renamed KHTMLPart to Frame (and KWQKHTMLPart to MacFrame for now)
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/Frame.cpp: Added. (khtml::PartStyleSheetLoader::PartStyleSheetLoader): (khtml::PartStyleSheetLoader::setStyleSheet): (Frame::Frame): (Frame::init): (Frame::~Frame): (Frame::restoreURL): (Frame::didOpenURL): (Frame::didExplicitOpen): (Frame::stopLoading): (Frame::closeURL): (Frame::browserExtension): (Frame::view): (Frame::setJScriptEnabled): (Frame::jScriptEnabled): (Frame::setMetaRefreshEnabled): (Frame::metaRefreshEnabled): (Frame::jScript): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::scheduleScript): (Frame::executeScheduledScript): (Frame::setJavaEnabled): (Frame::javaEnabled): (Frame::setPluginsEnabled): (Frame::pluginsEnabled): (Frame::slotDebugDOMTree): (Frame::slotDebugRenderTree): (Frame::setAutoloadImages): (Frame::autoloadImages): (Frame::clear): (Frame::openFile): (Frame::xmlDocImpl): (Frame::replaceDocImpl): (Frame::receivedFirstData): (Frame::slotFinished): (Frame::childBegin): (Frame::begin): (Frame::write): (Frame::end): (Frame::endIfNotLoading): (Frame::stop): (Frame::stopAnimations): (Frame::gotoAnchor): (Frame::slotFinishedParsing): (Frame::slotLoaderRequestStarted): (Frame::slotLoaderRequestDone): (Frame::checkCompleted): (Frame::checkEmitLoadEvent): (Frame::settings): (Frame::baseURL): (Frame::baseTarget): (Frame::completeURL): (Frame::scheduleRedirection): (Frame::scheduleLocationChange): (Frame::isScheduledLocationChangePending): (Frame::scheduleHistoryNavigation): (Frame::cancelRedirection): (Frame::changeLocation): (Frame::slotRedirect): (Frame::slotRedirection): (Frame::encoding): (Frame::setUserStyleSheet): (Frame::setStandardFont): (Frame::setFixedFont): (Frame::urlCursor): (Frame::onlyLocalReferences): (Frame::setOnlyLocalReferences): (Frame::selectedText): (Frame::hasSelection): (Frame::selection): (Frame::selectionGranularity): (Frame::setSelectionGranularity): (Frame::dragCaret): (Frame::mark): (Frame::setMark): (Frame::setSelection): (Frame::setDragCaret): (Frame::clearSelection): (Frame::invalidateSelection): (Frame::setCaretVisible): (Frame::clearCaretRectIfNeeded): (isFrameElement): (Frame::setFocusNodeIfNeeded): (Frame::selectionLayoutChanged): (Frame::setXPosForVerticalArrowNavigation): (Frame::xPosForVerticalArrowNavigation): (Frame::timerEvent): (Frame::paintCaret): (Frame::paintDragCaret): (Frame::urlSelected): (Frame::requestFrame): (Frame::requestFrameName): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitFormAgain): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::slotChildStarted): (Frame::slotChildCompleted): (Frame::childFrame): (Frame::findFrame): (Frame::frameExists): (Frame::parentFrame): (Frame::zoomFactor): (Frame::slotIncZoom): (Frame::slotDecZoom): (Frame::setZoomFactor): (Frame::setJSStatusBarText): (Frame::setJSDefaultStatusBarText): (Frame::jsStatusBarText): (Frame::jsDefaultStatusBarText): (Frame::referrer): (Frame::lastModified): (Frame::reparseConfiguration): (Frame::frameNames): (Frame::frames): (Frame::childFrameNamed): (Frame::setDNDEnabled): (Frame::dndEnabled): (Frame::shouldDragAutoNode): (Frame::customEvent): (Frame::isPointInsideSelection): (Frame::selectClosestWordFromMouseEvent): (Frame::handleMousePressEventDoubleClick): (Frame::handleMousePressEventTripleClick): (Frame::handleMousePressEventSingleClick): (Frame::khtmlMousePressEvent): (Frame::khtmlMouseDoubleClickEvent): (Frame::handleMouseMoveEventSelection): (Frame::khtmlMouseMoveEvent): (Frame::khtmlMouseReleaseEvent): (Frame::khtmlDrawContentsEvent): (Frame::startAutoScroll): (Frame::stopAutoScroll): (Frame::selectAll): (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::shouldBeginEditing): (Frame::shouldEndEditing): (Frame::isContentEditable): (Frame::lastEditCommand): (Frame::appliedEditing): (Frame::unappliedEditing): (Frame::reappliedEditing): (Frame::typingStyle): (Frame::setTypingStyle): (Frame::clearTypingStyle): (Frame::slotPartRemoved): (Frame::createHTMLEventListener): (Frame::opener): (Frame::setOpener): (Frame::openedByJS): (Frame::setOpenedByJS): (Frame::preloadStyleSheet): (Frame::preloadScript): (Frame::restored): (Frame::incrementFrameCount): (Frame::decrementFrameCount): (Frame::topLevelFrameCount): (Frame::tabsToLinks): (Frame::tabsToAllControls): (Frame::copyToPasteboard): (Frame::cutToPasteboard): (Frame::pasteFromPasteboard): (Frame::pasteAndMatchStyle): (Frame::transpose): (Frame::redo): (Frame::undo): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (updateState): (Frame::selectionHasStyle): (Frame::selectionStartHasStyle): (Frame::selectionStartStylePropertyValue): (Frame::selectionComputedStyle): (Frame::applyEditingStyleToBodyElement): (Frame::removeEditingStyleFromBodyElement): (Frame::applyEditingStyleToElement): (Frame::removeEditingStyleFromElement): (Frame::isCharacterSmartReplaceExempt): (Frame::connectChild): (Frame::disconnectChild): (Frame::keepAlive): (Frame::slotEndLifeSupport): (Frame::selectFrameElementInParentIfFullySelected): (Frame::handleFallbackContent):
  • khtml/Frame.h: Added.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::~ScriptInterpreter):
  • khtml/ecma/kjs_binding.h: (KJS::ScriptInterpreter::frame):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLDocument::getValueProperty): (KJS::KJS::HTMLDocument::putValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::implementsCall): (KJS::Image::notifyFinished):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::Navigator::getValueProperty): (KJS::NavigatorFunc::callAsFunction):
  • khtml/ecma/kjs_navigator.h: (KJS::Navigator::frame):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::interpreter): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::History::History): (KJS::FrameArray::FrameArray): (KJS::Screen::getValueProperty): (KJS::Window::Window): (KJS::Window::interpreter): (KJS::Window::retrieveWindow): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::allowPopUp): (KJS::createNewWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::toBoolean): (KJS::Window::scheduleClose): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::setCurrentEvent): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::WindowQObject::WindowQObject): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (KJS::Location::Location): (KJS::Location::getValueProperty): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::Selection::Selection): (KJS::Selection::getValueProperty): (KJS::Selection::getOwnPropertySlot): (KJS::Selection::toString): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::BarInfo): (KJS::BarInfo::getValueProperty): (KJS::BarInfo::getOwnPropertySlot): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • khtml/ecma/kjs_window.h: (KJS::Window::frame): (KJS::Location::frame): (KJS::Selection::frame): (KJS::BarInfo::frame):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::modify): (khtml::SelectionController::xPosForVerticalArrowNavigation):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::frame):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): (khtml::EditCommand::apply): (khtml::EditCommand::unapply): (khtml::EditCommand::reapply): (khtml::EditCommand::styleAtPosition):
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::execCommand): (DOM::JSEditor::queryCommandEnabled): (DOM::JSEditor::queryCommandIndeterm): (DOM::JSEditor::queryCommandState): (DOM::JSEditor::queryCommandValue):
  • khtml/editing/jsediting.h:
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/text_granularity.h:
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::insertText): (khtml::TypingCommand::insertLineBreak): (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): (khtml::TypingCommand::insertParagraphSeparator): (khtml::TypingCommand::markMisspellingsAfterTyping): (khtml::TypingCommand::typingAddedToOpenCommand): (khtml::TypingCommand::insertTextRunWithoutNewlines):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::close): (HTMLFrameElementImpl::contentPart): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::lastModified):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): (HTMLElementImpl::setContentEditable):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::prepareSubmit): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLGenericFormElementImpl::isKeyboardFocusable): (DOM::HTMLKeygenElementImpl::appendFormData):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process): (HTMLScriptElementImpl::parseMappedAttribute): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::evaluateScript):
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isKeyboardFocusable): (DOM::HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::createRenderer): (DOM::HTMLAppletElementImpl::getAppletInstance): (DOM::HTMLEmbedElementImpl::getEmbedInstance): (DOM::HTMLEmbedElementImpl::rendererIsNeeded): (DOM::HTMLObjectElementImpl::getObjectInstance): (DOM::HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlparser.cpp: (HTMLParser::noscriptCreateErrorCheck):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopParsing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::processToken):
  • khtml/khtml_part.cpp: Removed.
  • khtml/khtml_part.h: Removed.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::clearPart): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::adjustViewSize): (KHTMLView::layout): (KHTMLView::updateDashboardRegions): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (selectCursor): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::keyPressEvent): (KHTMLView::dispatchDragEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::focusNextPrevNode): (KHTMLView::mediaType): (KHTMLView::dispatchMouseEvent): (KHTMLView::viewportWheelEvent): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::scheduleRelayout): (KHTMLView::unscheduleRelayout):
  • khtml/khtmlview.h: (KHTMLView::frame):
  • khtml/misc/CachedImageCallback.cpp: (khtml::CachedImageCallback::notifyUpdate): (khtml::CachedImageCallback::notifyFinished): (khtml::CachedImageCallback::clear):
  • khtml/misc/CachedObject.h:
  • khtml/misc/DocLoader.cpp: (khtml::DocLoader::DocLoader): (khtml::DocLoader::requestImage): (khtml::DocLoader::requestStyleSheet): (khtml::DocLoader::requestScript): (khtml::DocLoader::requestXSLStyleSheet): (khtml::DocLoader::requestXBLDocument):
  • khtml/misc/DocLoader.h: (khtml::DocLoader::frame):
  • khtml/misc/loader.cpp: (khtml::Loader::slotReceivedResponse):
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::paintMarkedTextUnderline):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintCaret):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton):
  • khtml/rendering/render_frames.cpp: (isURLAllowed): (RenderPartObject::updateWidget):
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::draggableNode):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter):
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::frame): (DocumentImpl::recalcStyle): (DocumentImpl::updateSelection): (DocumentImpl::open): (DocumentImpl::close): (DocumentImpl::implicitClose): (DocumentImpl::processHttpEquiv): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector): (DocumentImpl::relinquishesEditingFocus): (DocumentImpl::acceptsEditingFocus): (DocumentImpl::clearSelectionIfNeeded): (DocumentImpl::createHTMLEventListener): (DocumentImpl::ownerElement): (DocumentImpl::referrer): (DocumentImpl::parentDocument):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent):
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::notifyFinished):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished):
  • kwq/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]): (-[KWQAccObject doSetAXSelectedTextMarkerRange:]):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): (KWQClipboard::dragNSImage):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]): (-[KWQPopUpButton nextKeyView]): (-[KWQPopUpButton previousKeyView]):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::focusPolicy): (KWQFileButton::focusChanged):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • kwq/KWQKHTMLFactory.h:
  • kwq/KWQKHTMLPart.cpp: Removed.
  • kwq/KWQKHTMLPart.h: Removed.
  • kwq/KWQKHTMLPart.mm: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): (KHTMLPartBrowserExtension::openURLRequest): (KHTMLPartBrowserExtension::createNewWindow): (KHTMLPartBrowserExtension::setIconURL): (KHTMLPartBrowserExtension::setTypedIconURL): (KHTMLPartBrowserExtension::canRunModal): (KHTMLPartBrowserExtension::canRunModalNow): (KHTMLPartBrowserExtension::runModal):
  • kwq/KWQKHTMLView.cpp: (KHTMLView::topLevelWidget):
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQKPartsBrowserInterface.h: (KParts::BrowserInterface::BrowserInterface):
  • kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::property): (KParts::BrowserInterface::callMethod):
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView becomeFirstResponder]): (-[KWQTableView keyDown:]): (-[KWQTableView keyUp:]): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView nextKeyView]): (-[KWQTableView previousKeyView]):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQCacheObjectExpiresTime):
  • kwq/KWQObject.cpp: (QObject::inherits): (QObject::isFrame):
  • kwq/KWQObject.h:
  • kwq/KWQPageState.mm: (-[KWQPageState dealloc]): (-[KWQPageState finalize]):
  • kwq/KWQRegExp.cpp: (QRegExp::KWQRegExpPrivate::compile):
  • kwq/KWQRenderTreeDebug.cpp: (write): (writeSelection):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (-[KWQSlider nextKeyView]): (-[KWQSlider previousKeyView]): (-[KWQSlider canBecomeKeyView]): (QSlider::focusPolicy):
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView _isResizableByUser]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView nextKeyView]): (-[KWQTextAreaTextView previousKeyView]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView drawRect:]): (-[KWQTextAreaTextView insertTab:]): (-[KWQTextAreaTextView insertBacktab:]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView shouldDrawInsertionPoint]): (-[KWQTextAreaTextView selectedTextAttributes]): (-[KWQTextAreaTextView keyDown:]): (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]):
  • kwq/KWQTimer.h:
  • kwq/KWQWidget.mm: (QWidget::setActiveWindow): (QWidget::hasFocus): (QWidget::setFocus): (QWidget::clearFocus): (QWidget::isVisible): (QWidget::mapFromGlobal): (QWidget::setIsSelected):
  • kwq/MacFrame.cpp: Added. (MacFrame::isFrameSet):
  • kwq/MacFrame.h: Added. (MacFrame::instances): (Mac):
  • kwq/MacFrame.mm: Added. (Frame::completed): (Frame::openURL): (Frame::onURL): (Frame::setStatusBarText): (Frame::started): (redirectionTimerMonitor): (MacFrame::MacFrame): (MacFrame::~MacFrame): (MacFrame::freeClipboard): (MacFrame::setSettings): (MacFrame::generateFrameName): (MacFrame::provisionalLoadStarted): (MacFrame::userGestureHint): (MacFrame::openURL): (MacFrame::openURLRequest): (MacFrame::didNotOpenURL): (MacFrame::currentForm): (MacFrame::searchForLabelsAboveCell): (MacFrame::searchForLabelsBeforeElement): (MacFrame::matchLabelsAgainstElement): (MacFrame::findString): (MacFrame::clearRecordedFormValues): (MacFrame::recordFormValue): (MacFrame::submitForm): (MacFrame::setEncoding): (MacFrame::addData): (Frame::frameDetached): (MacFrame::urlSelected): (MacFrame::createPart): (MacFrame::setView): (MacFrame::view): (MacFrame::setTitle): (MacFrame::setStatusBarText): (MacFrame::scheduleClose): (MacFrame::unfocusWindow): (MacFrame::revealSelection): (MacFrame::advanceToNextMisspelling): (MacFrame::scrollOverflow): (MacFrame::wheelEvent): (MacFrame::redirectionTimerStartedOrStopped): (MacFrame::paint): (MacFrame::adjustPageHeight): (MacFrame::renderer): (MacFrame::userAgent): (MacFrame::mimeTypeForFileName): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::nextKeyView): (MacFrame::nextKeyViewForWidget): (MacFrame::currentEventIsMouseDownInWidget): (MacFrame::currentEventIsKeyboardOptionTab): (MacFrame::handleKeyboardOptionTabInView): (MacFrame::tabsToLinks): (MacFrame::tabsToAllControls): (MacFrame::executionContextForDOM): (MacFrame::bindingRootObject): (MacFrame::windowScriptObject): (MacFrame::windowScriptNPObject): (MacFrame::partClearedInBegin): (MacFrame::pauseTimeouts): (MacFrame::resumeTimeouts): (MacFrame::canCachePage): (MacFrame::saveWindowProperties): (MacFrame::saveLocationProperties): (MacFrame::restoreWindowProperties): (MacFrame::restoreLocationProperties): (MacFrame::saveInterpreterBuiltins): (MacFrame::restoreInterpreterBuiltins): (MacFrame::openURLFromPageCache): (MacFrame::frameForWidget): (MacFrame::bridgeForWidget): (MacFrame::frameForNode): (MacFrame::documentViewForNode): (MacFrame::nodeForWidget): (MacFrame::setDocumentFocus): (MacFrame::clearDocumentFocus): (MacFrame::saveDocumentState): (MacFrame::restoreDocumentState): (MacFrame::mutableInstances): (MacFrame::updatePolicyBaseURL): (MacFrame::setPolicyBaseURL): (MacFrame::requestedURLString): (MacFrame::incomingReferrer): (MacFrame::forceLayout): (MacFrame::forceLayoutWithPageWidthRange): (MacFrame::sendResizeEvent): (MacFrame::sendScrollEvent): (MacFrame::runJavaScriptAlert): (MacFrame::runJavaScriptConfirm): (MacFrame::runJavaScriptPrompt): (MacFrame::locationbarVisible): (MacFrame::menubarVisible): (MacFrame::personalbarVisible): (MacFrame::scrollbarsVisible): (MacFrame::statusbarVisible): (MacFrame::toolbarVisible): (MacFrame::addMessageToConsole): (MacFrame::createEmptyDocument): (MacFrame::addMetaData): (MacFrame::keyEvent): (MacFrame::scrollToAnchor): (MacFrame::closeURL): (MacFrame::canMouseDownStartSelect): (MacFrame::khtmlMousePressEvent): (MacFrame::khtmlMouseDoubleClickEvent): (MacFrame::passWidgetMouseDownEventToWidget): (MacFrame::lastEventIsMouseUp): (MacFrame::mouseDownViewIfStillGood): (MacFrame::dragHysteresisExceeded): (MacFrame::dispatchDragSrcEvent): (MacFrame::eventMayStartDrag): (MacFrame::khtmlMouseMoveEvent): (MacFrame::dragSourceMovedTo): (MacFrame::dragSourceEndedAt): (MacFrame::dispatchCPPEvent): (MacFrame::mayCut): (MacFrame::mayCopy): (MacFrame::mayPaste): (MacFrame::tryCut): (MacFrame::tryCopy): (MacFrame::tryPaste): (MacFrame::khtmlMouseReleaseEvent): (MacFrame::clearTimers): (MacFrame::passSubframeEventToSubframe): (MacFrame::passWheelEventToChildWidget): (MacFrame::mouseDown): (MacFrame::mouseDragged): (MacFrame::mouseUp): (MacFrame::sendFakeEventsAfterWidgetTracking): (MacFrame::mouseMoved): (MacFrame::shouldDragAutoNode): (MacFrame::sendContextMenuEvent): (MacFrame::fileWrapperForElement): (MacFrame::attributedString): (MacFrame::selectionRect): (MacFrame::visibleSelectionRect): (MacFrame::centerSelectionInVisibleArea): (MacFrame::imageFromRect): (MacFrame::selectionImage): (MacFrame::snapshotDragImage): (MacFrame::styleForSelectionStart): (MacFrame::fontForSelection): (MacFrame::fontAttributesForSelectionStart): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::topLevelWidget): (MacFrame::tokenizerProcessedData): (MacFrame::selectionStartOffset): (MacFrame::selectionEndOffset): (MacFrame::selectionStart): (MacFrame::selectionEnd): (MacFrame::setBridge): (MacFrame::overrideMediaType): (MacFrame::setMediaType): (MacFrame::setSelectionFromNone): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::displaysWithFocusAttributes): (MacFrame::setWindowHasFocus): (MacFrame::backslashAsCurrencySymbol): (MacFrame::bodyBackgroundColor): (MacFrame::keyboardUIMode): (MacFrame::setName): (MacFrame::didTellBridgeAboutLoad): (MacFrame::haveToldBridgeAboutLoad): (MacFrame::clear): (Frame::print): (MacFrame::getAppletInstanceForWidget): (MacFrame::getEmbedInstanceForWidget): (MacFrame::getObjectInstanceForWidget): (MacFrame::addPluginRootObject): (MacFrame::cleanupPluginRootObjects): (MacFrame::registerCommandForUndoOrRedo): (MacFrame::registerCommandForUndo): (MacFrame::registerCommandForRedo): (MacFrame::clearUndoRedoOperations): (MacFrame::issueUndoCommand): (MacFrame::issueRedoCommand): (MacFrame::issueCutCommand): (MacFrame::issueCopyCommand): (MacFrame::issuePasteCommand): (MacFrame::issuePasteAndMatchStyleCommand): (MacFrame::issueTransposeCommand): (Frame::canUndo): (Frame::canRedo): (Frame::canPaste): (MacFrame::markMisspellingsInAdjacentWords): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::shouldChangeSelection): (MacFrame::respondToChangedContents): (MacFrame::isContentEditable): (MacFrame::shouldBeginEditing): (MacFrame::shouldEndEditing): (convertAttributesToUnderlines): (MacFrame::setMarkedTextRange): (MacFrame::markedTextUsesUnderlines): (MacFrame::markedTextUnderlines): (MacFrame::canGoBackOrForward): (MacFrame::prepareForUserAction): (MacFrame::didFirstLayout): (MacFrame::dashboardRegionsDictionary): (MacFrame::dashboardRegionsChanged): (MacFrame::isCharacterSmartReplaceExempt): (MacFrame::isFrame): (MacFrame::mousePressNode): (MacFrame::handledOnloadEvents): (MacFrame::shouldClose):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (frameHasSelection): (+[WebCoreBridge bridgeForDOMDocument:]): (-[WebCoreBridge init]): (-[WebCoreBridge initializeSettings:]): (-[WebCoreBridge dealloc]): (-[WebCoreBridge finalize]): (-[WebCoreBridge part]): (-[WebCoreBridge setParent:]): (-[WebCoreBridge parent]): (-[WebCoreBridge provisionalLoadStarted]): (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge setEncoding:userChosen:]): (-[WebCoreBridge addData:]): (-[WebCoreBridge closeURL]): (-[WebCoreBridge stopLoading]): (-[WebCoreBridge didNotOpenURL:pageCache:]): (-[WebCoreBridge saveDocumentState]): (-[WebCoreBridge restoreDocumentState]): (-[WebCoreBridge scrollToAnchorWithURL:]): (-[WebCoreBridge scrollOverflowInDirection:granularity:]): (-[WebCoreBridge sendScrollWheelEvent:]): (-[WebCoreBridge saveDocumentToPageCache]): (-[WebCoreBridge canCachePage]): (-[WebCoreBridge clear]): (-[WebCoreBridge end]): (-[WebCoreBridge stop]): (-[WebCoreBridge handleFallbackContent]): (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreBridge scrollToAnchor:]): (-[WebCoreBridge isSelectionEditable]): (-[WebCoreBridge selectionState]): (-[WebCoreBridge _documentTypeString]): (-[WebCoreBridge selectedString]): (-[WebCoreBridge stringForRange:]): (-[WebCoreBridge selectAll]): (-[WebCoreBridge deselectAll]): (-[WebCoreBridge deselectText]): (-[WebCoreBridge isFrameSet]): (-[WebCoreBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreBridge _setupRootForPrinting:]): (-[WebCoreBridge forceLayoutAdjustingViewSize:]): (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreBridge sendResizeEvent]): (-[WebCoreBridge sendScrollEvent]): (-[WebCoreBridge drawRect:withPainter:]): (-[WebCoreBridge drawRect:]): (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): (-[WebCoreBridge copyDOMTree:]): (-[WebCoreBridge copyRenderTree:]): (-[WebCoreBridge removeFromFrame]): (-[WebCoreBridge installInFrame:]): (-[WebCoreBridge setActivationEventNumber:]): (-[WebCoreBridge mouseDown:]): (-[WebCoreBridge mouseDragged:]): (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseMoved:]): (-[WebCoreBridge sendContextMenuEvent:]): (-[WebCoreBridge currentForm]): (-[WebCoreBridge searchForLabels:beforeElement:]): (-[WebCoreBridge matchLabels:againstElement:]): (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge URLWithAttributeString:]): (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): (-[WebCoreBridge advanceToNextMisspelling]): (-[WebCoreBridge advanceToNextMisspellingStartingJustBeforeSelection]): (-[WebCoreBridge unmarkAllMisspellings]): (-[WebCoreBridge setTextSizeMultiplier:]): (-[WebCoreBridge textEncoding]): (-[WebCoreBridge nextKeyView]): (-[WebCoreBridge previousKeyView]): (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]): (-[WebCoreBridge DOMDocument]): (-[WebCoreBridge selectedAttributedString]): (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): (-[WebCoreBridge selectionRect]): (-[WebCoreBridge visibleSelectionRect]): (-[WebCoreBridge centerSelectionInVisibleArea]): (-[WebCoreBridge selectionImage]): (-[WebCoreBridge setName:]): (-[WebCoreBridge name]): (-[WebCoreBridge URL]): (-[WebCoreBridge baseURL]): (-[WebCoreBridge referrer]): (-[WebCoreBridge domain]): (-[WebCoreBridge opener]): (-[WebCoreBridge setOpener:]): (-[WebCoreBridge needsLayout]): (-[WebCoreBridge setNeedsLayout]): (-[WebCoreBridge interceptKeyEvent:toView:]): (-[WebCoreBridge renderTreeAsExternalRepresentation]): (-[WebCoreBridge setSelectionFromNone]): (-[WebCoreBridge setDisplaysWithFocusAttributes:]): (-[WebCoreBridge setWindowHasFocus:]): (-[WebCoreBridge numPendingOrLoadingRequests]): (-[WebCoreBridge doneProcessingData]): (-[WebCoreBridge shouldClose]): (-[WebCoreBridge bodyBackgroundColor]): (-[WebCoreBridge selectionColor]): (-[WebCoreBridge adjustViewSize]): (-[WebCoreBridge accessibilityTree]): (-[WebCoreBridge setDrawsBackground:]): (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreBridge selectionGranularity]): (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreBridge selectedDOMRange]): (-[WebCoreBridge convertToNSRange:DOM::]): (-[WebCoreBridge convertToDOMRange:]): (-[WebCoreBridge selectNSRange:]): (-[WebCoreBridge selectedNSRange]): (-[WebCoreBridge selectionAffinity]): (-[WebCoreBridge setMarkDOMRange:]): (-[WebCoreBridge markDOMRange]): (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): (-[WebCoreBridge markedTextDOMRange]): (-[WebCoreBridge markedTextNSRange]): (-[WebCoreBridge replaceMarkedTextWithText:]): (-[WebCoreBridge smartDeleteRangeForProposedRange:]): (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]): (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreBridge documentFragmentWithText:]): (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreBridge insertLineBreak]): (-[WebCoreBridge insertParagraphSeparator]): (-[WebCoreBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreBridge insertText:selectInsertedText:]): (-[WebCoreBridge setSelectionToDragCaret]): (-[WebCoreBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreBridge _visiblePositionForPoint:]): (-[WebCoreBridge moveDragCaretToPoint:]): (-[WebCoreBridge removeDragCaret]): (-[WebCoreBridge dragCaretDOMRange]): (-[WebCoreBridge deleteSelectionWithSmartDelete:]): (-[WebCoreBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreBridge forwardDeleteKeyPressedWithSmartDelete:]): (-[WebCoreBridge typingStyle]): (-[WebCoreBridge setTypingStyle:withUndoAction:]): (-[WebCoreBridge applyStyle:withUndoAction:]): (-[WebCoreBridge applyParagraphStyle:withUndoAction:]): (-[WebCoreBridge selectionStartHasStyle:]): (-[WebCoreBridge selectionHasStyle:]): (-[WebCoreBridge applyEditingStyleToBodyElement]): (-[WebCoreBridge removeEditingStyleFromBodyElement]): (-[WebCoreBridge applyEditingStyleToElement:]): (-[WebCoreBridge removeEditingStyleFromElement:]): (-[WebCoreBridge fontForSelection:]): (-[WebCoreBridge fontAttributesForSelectionStart]): (-[WebCoreBridge baseWritingDirectionForSelectionStart]): (-[WebCoreBridge ensureSelectionVisible]): (-[WebCoreBridge eventMayStartDrag:]): (-[WebCoreBridge dragOperationForDraggingInfo:]): (-[WebCoreBridge dragExitedWithDraggingInfo:]): (-[WebCoreBridge concludeDragForDraggingInfo:]): (-[WebCoreBridge dragSourceMovedTo:]): (-[WebCoreBridge dragSourceEndedAt:operation:]): (-[WebCoreBridge mayDHTMLCut]): (-[WebCoreBridge mayDHTMLCopy]): (-[WebCoreBridge mayDHTMLPaste]): (-[WebCoreBridge tryDHTMLCut]): (-[WebCoreBridge tryDHTMLCopy]): (-[WebCoreBridge tryDHTMLPaste]): (-[WebCoreBridge rangeOfCharactersAroundCaret]): (-[WebCoreBridge dashboardRegions]): (-[WebCoreBridge executionContextForView:]):
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]):
1:01 PM Changeset in webkit [11965] by darin
  • 3 edits
    3 deletes in trunk

JavaScriptCore:

  • Makefile.am: Removed.

WebCore:

  • Makefile.am: Removed.

WebKit:

  • Makefile.am: Removed.
11:29 AM Changeset in webkit [11964] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Beth Dakin.


  • fixed <rdar://problem/4302263> CrashTracer: 504 crashes in Safari at com.apple.AppKit: NSTargetForSendAction + 1060


The problem was that back/forward/stop/reload context menu items had nil targets,
and thus were relying on AppKit to start from the context menu target (the clicked-upon
view) and use the responder chain to find the WebView to act as the target. In Tiger,
context menus don't retain their implicit target (the clicked-upon view again), and
there was a race condition where the WebHTMLView could be dealloc'ed while the menu item
was being processed, eventually crashing in AppKit. The fix is to explicitly set the
target of these four menu items to the WebView, since the WebView is not dealloc'ed
in the loading process.


This might be fixed in a future version of AppKit by making the context menu retain its
implicit target until it is dismissed, but with this change it will be fixed regardless
of potential AppKit changes.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:]): Added target: parameter and removed code that set the target for some menu items; now the caller is responsible for supplying the target. (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): Supply target (or nil) in calls to menuItemWithTag:target:. This matches existing behavior except for Back/Forward/Stop/Reload, which used to supply no target but now supply the WebView as the target. (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Supply target (or nil) in calls to menuItemWithTag:target:
10:35 AM Changeset in webkit [11963] by ggaren
  • 4 edits
    5 adds in trunk

LayoutTests:

Layout tests for

<rdar://problem/4268278> Submitting a form in onUnload event handler
causes crash in -[WebDataSource(WebPrivate) _commitIfReady:].)

and

  • fast/loader/form-events-back-forward-expected.txt: Added.
  • fast/loader/form-events-back-forward.html: Added.
  • fast/loader/onunload-form-submit-crash-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash.html: Added.
  • fast/loader/resources/onunload-form-submit-crash2.html: Added.

WebKit:

Reviewed by Darin.


  • Second cut at fixing <rdar://problem/4268278> Submitting a form in onUnload event handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:].)


  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): (1) If there are no resource loaders to signal the WebView that we've been canceled, manufacture the signal. Otherwise, the cancel gets ignored and nobody cleans up after the load. (We signal the WebView but not the WebFrame because we don't want the WebFrame to tear down the DataSource. Unlike most canceled DataSources, this one has valid data because it's in the back/forward cache.) (2) Update _private->stopping before returning because if the DataSource is in the back/forward cache it can be reused, so it needs to be in a consistent state. (We never encountered this situation before because we would always crash first.) (-[WebDataSource _commitLoadWithData:]): Move _commitIfReady call inside retain block because the commit may cause an unload event to fire, which may start a new load, deallocating the current DataSource. (This is the same reason the rest of the function is in the retain block.)
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): If the unload handler started a new load, return early to avoid stomping it. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Undo previous incorrect fix. (-[WebFrame stopLoading]): Remove misleading comment. Setting provisionalDataSource to nil is not optional but required for internal consistency.
8:52 AM Changeset in webkit [11962] by thatcher
  • 15987 edits in trunk

Removes svn:keywords from all files.

7:05 AM Changeset in webkit [11961] by sullivan
  • 2 edits in trunk/WebCore
  • khtml/misc/decoder.cpp: removed #include of recently-removed kcharsets.h to fix build
5:20 AM Changeset in webkit [11960] by eseidel
  • 357 edits
    15 adds in trunk/LayoutTests

2006-01-09 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel

Updated results for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5748
Also committed several missing results.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.png:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
  • svg/custom/conditional-processing-outside-switch-expected.png: Added.
  • svg/custom/control-points-for-S-and-T-expected.checksum:
  • svg/custom/control-points-for-S-and-T-expected.png: Added.
  • svg/custom/fill-update-expected.png: Added.
  • svg/custom/fractional-rects-expected.checksum:
  • svg/custom/grayscale-gradient-mask-expected.png: Added.
  • svg/custom/grayscale-gradient-mask-expected.txt:
  • svg/custom/junk-data-expected.checksum: Added.
  • svg/custom/junk-data-expected.png: Added.
  • svg/custom/path-bad-data-expected.png: Added.
  • svg/custom/path-update-expected.png: Added.
  • svg/custom/rounded-rects-expected.png: Added.
  • svg/custom/simpleCDF-expected.png: Added.
  • svg/custom/transform-ignore-after-invalid-expected.png: Added.
  • svg/custom/transform-invalid-expected.png: Added.
  • svg/custom/transform-with-ending-space-expected.png: Added.
  • svg/custom/use-forward-refs-expected.png: Added.
5:07 AM Changeset in webkit [11959] by eseidel
  • 14 edits in trunk/WebCore

2006-01-08 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel.

First set of refactors to fix
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5748.

Refactors to delay paintserver creation until usage and thereby
simplify much code in the process. Causes several changes in rendertree
output all of which are improvements rather than regressions.

  • kcanvas/KCanvasItem.cpp: setupForDraw() logic moved to KCanvasItemQuartz
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasResource::addClient): const-ify
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle): minor refactor/inline - keeps most output the same after patch, some minor const'ifications
  • kcanvas/device/KRenderingFillPainter.cpp: setter (KRenderingFillPainter::Private::Private):
  • kcanvas/device/KRenderingFillPainter.h: refactor out paintserver and draw()
  • kcanvas/device/KRenderingStrokePainter.cpp: refactor out paintserver and draw() (KRenderingStrokePainter::Private::Private):
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): (KCanvasItemQuartz::hitsPath):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::~KCanvasRenderingStyle): (KCanvasRenderingStyle::overrideFillPaintServer): (KCanvasRenderingStyle::isFilled): (KCanvasRenderingStyle::fillPaintServer): (KCanvasRenderingStyle::overrideStrokePaintServer): (KCanvasRenderingStyle::isStroked): (KCanvasRenderingStyle::strokePaintServer): (KCanvasRenderingStyle::updateStyle): remove paintserver constructions from update notification and instead create on usage, removing disable.*Painter() methods
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished): use paintserver override logic
4:58 AM Changeset in webkit [11958] by ap
  • 2 edits in trunk/WebCore

Fix broken build (CachedObject.cpp was still including kcharsets.h).
Proposed and reviewed by Eric Seidel.

4:29 AM Changeset in webkit [11957] by eseidel
  • 15 edits
    2 adds
    16 deletes in trunk/WebCore

Reviewed by mjs.

Remove more unused code from kwq.

  • ForwardingHeaders/dcopclient.h: Removed.
  • ForwardingHeaders/kaction.h: Removed.
  • ForwardingHeaders/kcharsets.h: Removed.
  • ForwardingHeaders/kcombobox.h: Removed.
  • ForwardingHeaders/klineedit.h: Removed.
  • ForwardingHeaders/klistbox.h: Removed.
  • ForwardingHeaders/kwin.h: Removed.
  • ForwardingHeaders/qcombobox.h: Added.
  • ForwardingHeaders/qlineedit.h: Added.
  • WebCore.xcodeproj/project.pbxproj: remove files.
  • khtml/css/csshelper.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::index): (DOM::HTMLOptionElementImpl::setIndex):
  • khtml/html/htmltokenizer.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp:
  • khtml/khtmlpart_p.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::setStyle): (RenderLineEdit::updateFromElement): (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::select): (RenderLineEdit::setSelectionRange): (ComboBoxWidget::ComboBoxWidget): (ComboBoxWidget::event): (ComboBoxWidget::eventFilter): (RenderSelect::setWidgetWritingDirection): (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderSelect::slotSelectionChanged): (RenderSelect::createListBox): (RenderSelect::updateSelection): (RenderTextArea::RenderTextArea):
  • khtml/rendering/render_form.h: (khtml::RenderLineEdit::widget):
  • kwq/KWQDCOPClient.h: Removed.
  • kwq/KWQKCharsets.cpp: Removed.
  • kwq/KWQKCharsets.h: Removed.
  • kwq/KWQKComboBox.h: Removed.
  • kwq/KWQKKAction.h: Removed.
  • kwq/KWQKLineEdit.h: Removed.
  • kwq/KWQKListBox.h: Removed.
  • kwq/KWQKWin.cpp: Removed.
  • kwq/KWQKWin.h: Removed.
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm:
3:41 AM Changeset in webkit [11956] by eseidel
  • 21 edits
    11 deletes in trunk/WebCore

Reviewed by mjs.

Removing more unused parts of KWQ.

  • ForwardingHeaders/java/kjavaappletcontext.h: Removed.
  • ForwardingHeaders/khtml_find.h: Removed.
  • ForwardingHeaders/qimage.h: Removed.
  • ForwardingHeaders/rendering/break_lines.h: Removed.
  • ForwardingHeaders/rendering/render_text.h: Removed.
  • ForwardingHeaders/xbl/xbl_docimpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::clear):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_applet.h:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • kwq/DOMHTML.mm:
  • kwq/KWQDummyView.h: Removed.
  • kwq/KWQDummyView.m: Removed.
  • kwq/KWQImage.h: Removed.
  • kwq/KWQKHTMLFind.h: Removed.
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKJavaAppletContext.h: Removed.
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQKPartsBrowserExtension.h:
  • kwq/KWQObject.h:
  • kwq/KWQRegion.h:
2:57 AM Changeset in webkit [11955] by mjs
  • 8 edits in trunk/LayoutTests
  • fix layout tests that I broke
  • fast/forms/button-in-forms-collection.html:
  • fast/js/date-parse-comments-test-expected.txt:
  • fast/js/date-parse-test-expected.txt:
  • fast/js/kde/Date-expected.txt:
  • fast/js/kde/resources/Date.js:
  • fast/js/resources/date-parse-comments-test.js:
  • fast/js/resources/date-parse-test.js:
2:11 AM Changeset in webkit [11954] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Affects many layout tests (when running with primary Russian language).

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Use glyphForCharacter() instead of -[NSFont glyphWithName:].
1:29 AM Changeset in webkit [11953] by eseidel
  • 43 edits
    22 copies
    1 delete in trunk/WebCore

Rubber stamped by mjs.

Broke out loader.{h,cpp} into multiple files, one per class.
This patch also updates all files which previously included
loader.h to only include the necessary renamed headers.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6444

  • ForwardingHeaders/kdom/cache/KDOMCachedDocument.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h: updated include
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h: updated include
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h: updated include
  • WebCore.xcodeproj/project.pbxproj: added files
  • khtml/css/css_computedstyle.cpp: updated includes
  • khtml/css/css_ruleimpl.cpp: updated includes
  • khtml/css/css_stylesheetimpl.h: updated includes
  • khtml/css/css_valueimpl.cpp: updated includes
  • khtml/css/cssstyleselector.cpp: updated includes
  • khtml/ecma/kjs_events.cpp: updated includes
  • khtml/ecma/kjs_html.cpp: updated includes
  • khtml/ecma/xmlhttprequest.cpp: updated includes
  • khtml/html/html_headimpl.cpp: updated includes
  • khtml/html/html_imageimpl.cpp: updated includes
  • khtml/html/html_imageimpl.h: updated includes
  • khtml/html/htmltokenizer.cpp: updated includes
  • khtml/khtml_part.cpp: updated includes
  • khtml/khtmlview.cpp: updated includes
  • khtml/misc/Cache.cpp: Added.
  • khtml/misc/Cache.h: Added.
  • khtml/misc/CachedCSSStyleSheet.cpp: Added.
  • khtml/misc/CachedCSSStyleSheet.h: Added.
  • khtml/misc/CachedImage.cpp: Added.
  • khtml/misc/CachedImage.h: Added.
  • khtml/misc/CachedImageCallback.cpp: Added.
  • khtml/misc/CachedImageCallback.h: Added.
  • khtml/misc/CachedObject.cpp: Added.
  • khtml/misc/CachedObject.h: Added, fixed tabs -> spaces.
  • khtml/misc/CachedObjectClientWalker.cpp: Added.
  • khtml/misc/CachedObjectClientWalker.h: Added.
  • khtml/misc/CachedScript.cpp: Added.
  • khtml/misc/CachedScript.h: Added.
  • khtml/misc/CachedXBLDocument.cpp: Added.
  • khtml/misc/CachedXBLDocument.h: Added.
  • khtml/misc/CachedXSLStyleSheet.cpp: Added.
  • khtml/misc/CachedXSLStyleSheet.h: Added.
  • khtml/misc/DocLoader.cpp: Added.
  • khtml/misc/DocLoader.h: Added.
  • khtml/misc/Request.cpp: Added.
  • khtml/misc/Request.h: Added.
  • khtml/misc/loader.cpp: updated includes
  • khtml/misc/loader.h: updated includes
  • khtml/misc/loader_client.h: updated includes
  • khtml/rendering/render_box.cpp: updated includes
  • khtml/rendering/render_line.cpp: updated includes
  • khtml/rendering/render_list.cpp: updated includes
  • khtml/rendering/render_object.cpp: updated includes
  • khtml/xml/dom_docimpl.cpp: updated includes
  • khtml/xml/dom_xmlimpl.cpp: updated includes
  • khtml/xml/xml_tokenizer.cpp: updated includes
  • khtml/xsl/xsl_stylesheetimpl.cpp: updated includes
  • khtml/xsl/xsl_stylesheetimpl.h: updated includes
  • khtml/xsl/xslt_processorimpl.cpp: updated includes
  • ksvg2/svg/SVGCursorElementImpl.cpp: updated includes
  • ksvg2/svg/SVGDocumentImpl.cpp: updated includes
  • ksvg2/svg/SVGFEImageElementImpl.cpp: updated includes
  • ksvg2/svg/SVGImageElementImpl.cpp: updated includes
  • ksvg2/svg/SVGImageElementImpl.h: updated includes
  • kwq/KWQKHTMLPart.mm: updated includes
  • kwq/KWQLoader.mm: updated includes
  • kwq/KWQPixmap.mm: updated includes
  • kwq/KWQTextArea.mm: updated includes
  • kwq/WebCoreBridge.mm: updated includes
  • kwq/WebCoreCache.mm: updated includes
12:59 AM Changeset in webkit [11952] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Maciej.

Test case: fast/frames/frameElement-widthheight.html

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::frameGetter):
  • khtml/ecma/kjs_html.h: Add FrameWidth, FrameHeight
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::frameWidth): (HTMLFrameElementImpl::frameHeight):
  • khtml/html/html_baseimpl.h: Add frameWidth, frameHeight
12:42 AM Changeset in webkit [11951] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Maciej, landed by ap.


Test: fast/replaced/inline-box-wrapper-handover.html



  • khtml/rendering/render_line.cpp: (khtml::InlineBox::deleteLine): Don't reset the inline box wrapper when deleting an extracted box.
12:37 AM Changeset in webkit [11950] by ap
  • 3 adds in trunk/LayoutTests

Re-added the files

12:36 AM Changeset in webkit [11949] by ap
  • 1 edit
    3 deletes in trunk/LayoutTests

Reviewed by Eric.


  • Updated tests broken by SVN conversion (CR/LF translation)


  • fast/encoding/utf-16-big-endian.html:
  • fast/encoding/utf-16-little-endian.html:
  • css1/text_properties/text-transCapitalize.html:

Jan 8, 2006:

9:28 PM Changeset in webkit [11948] by mjs
  • 192 edits
    1 copy
    28 moves
    52 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Eric.


  • fast/js/Plug-ins-expected.checksum: Removed.
  • fast/js/Plug-ins-expected.png: Removed.
  • fast/js/Plug-ins-expected.txt: Removed.
  • fast/js/Plug-ins.html: Removed.
  • fast/js/activation-proto-expected.txt:
  • fast/js/activation-proto.html:
  • fast/js/array-every-expected.txt:
  • fast/js/array-every.html:
  • fast/js/array-float-delete-expected.txt:
  • fast/js/array-float-delete.html:
  • fast/js/array-special-accessors-should-ignore-items-expected.txt: Removed.
  • fast/js/array-special-accessors-should-ignore-items.html: Removed.
  • fast/js/assign-expected.txt:
  • fast/js/assign.html:
  • fast/js/char-at-expected.txt:
  • fast/js/char-at.html:
  • fast/js/code-serialize-paren-expected.txt:
  • fast/js/code-serialize-paren.html:
  • fast/js/const-expected.txt:
  • fast/js/const.html:
  • fast/js/cyclic-ref-toString-expected.txt:
  • fast/js/cyclic-ref-toString.html:
  • fast/js/date-DST-pre-1970-expected.txt:
  • fast/js/date-DST-pre-1970.html:
  • fast/js/date-big-constructor-expected.txt:
  • fast/js/date-big-constructor.html:
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/date-big-setdate.html:
  • fast/js/date-big-setmonth-expected.txt:
  • fast/js/date-big-setmonth.html:
  • fast/js/date-negative-setmonth-expected.txt:
  • fast/js/date-negative-setmonth.html:
  • fast/js/date-parse-comments-test-expected.txt:
  • fast/js/date-parse-comments-test.html:
  • fast/js/date-parse-test-expected.txt:
  • fast/js/date-parse-test.html:
  • fast/js/date-preserve-milliseconds-expected.txt:
  • fast/js/date-preserve-milliseconds.html:
  • fast/js/declaration-in-block-expected.txt:
  • fast/js/declaration-in-block.html:
  • fast/js/delete-syntax-expected.txt:
  • fast/js/delete-syntax.html:
  • fast/js/eval-var-decl-expected.txt:
  • fast/js/eval-var-decl.html:
  • fast/js/exception-linenums-expected.txt:
  • fast/js/exception-linenums.html:
  • fast/js/for-in-to-text-expected.txt:
  • fast/js/for-in-to-text.html:
  • fast/js/global-opener-function-expected.txt: Removed.
  • fast/js/global-opener-function.html: Removed.
  • fast/js/has-own-property-expected.txt:
  • fast/js/has-own-property.html:
  • fast/js/integer-extremes-expected.txt:
  • fast/js/integer-extremes.html:
  • fast/js/isPrototypeOf-expected.txt: Added.
  • fast/js/isPrototypeOf.html: Added.
  • fast/js/kde/Array-expected.txt:
  • fast/js/kde/Array.html:
  • fast/js/kde/Boolean-expected.txt:
  • fast/js/kde/Boolean.html:
  • fast/js/kde/Date-expected.txt:
  • fast/js/kde/Date.html:
  • fast/js/kde/Error-expected.txt:
  • fast/js/kde/Error.html:
  • fast/js/kde/GlobalObject-expected.txt:
  • fast/js/kde/GlobalObject.html:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/Number.html:
  • fast/js/kde/Object-expected.txt:
  • fast/js/kde/Object.html:
  • fast/js/kde/Prototype-expected.txt:
  • fast/js/kde/Prototype.html:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/RegExp.html:
  • fast/js/kde/StringObject-expected.txt:
  • fast/js/kde/StringObject.html:
  • fast/js/kde/assignments-expected.txt:
  • fast/js/kde/assignments.html:
  • fast/js/kde/cast-expected.txt:
  • fast/js/kde/cast.html:
  • fast/js/kde/comment-1-expected.txt:
  • fast/js/kde/comment-1.html:
  • fast/js/kde/comment-2-expected.txt:
  • fast/js/kde/comment-2.html:
  • fast/js/kde/completion-expected.txt:
  • fast/js/kde/completion.html:
  • fast/js/kde/conditional-expected.txt:
  • fast/js/kde/conditional.html:
  • fast/js/kde/const-expected.txt:
  • fast/js/kde/const.html:
  • fast/js/kde/constructor_length-expected.txt:
  • fast/js/kde/constructor_length.html:
  • fast/js/kde/crash-1-expected.txt:
  • fast/js/kde/crash-1.html:
  • fast/js/kde/crash-2-expected.txt:
  • fast/js/kde/crash-2.html:
  • fast/js/kde/delete-expected.txt:
  • fast/js/kde/delete.html:
  • fast/js/kde/empty-expected.txt:
  • fast/js/kde/empty.html:
  • fast/js/kde/encode_decode_uri-expected.txt:
  • fast/js/kde/encode_decode_uri.html:
  • fast/js/kde/eval-expected.txt:
  • fast/js/kde/eval.html:
  • fast/js/kde/evil-n-expected.txt:
  • fast/js/kde/evil-n.html:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/exception_propagation.html:
  • fast/js/kde/exceptions-expected.txt:
  • fast/js/kde/exceptions.html:
  • fast/js/kde/function-expected.txt:
  • fast/js/kde/function.html:
  • fast/js/kde/function_arguments-expected.txt:
  • fast/js/kde/function_arguments.html:
  • fast/js/kde/function_constructor-expected.txt:
  • fast/js/kde/function_constructor.html:
  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/function_length.html:
  • fast/js/kde/garbage-n-expected.txt:
  • fast/js/kde/garbage-n.html:
  • fast/js/kde/inbuilt_function_proto-expected.txt:
  • fast/js/kde/inbuilt_function_proto.html:
  • fast/js/kde/inbuilt_function_tostring-expected.txt:
  • fast/js/kde/inbuilt_function_tostring.html:
  • fast/js/kde/iteration-expected.txt:
  • fast/js/kde/iteration.html:
  • fast/js/kde/j-comment-3-expected.txt:
  • fast/js/kde/j-comment-3.html:
  • fast/js/kde/j-comment-4-expected.txt:
  • fast/js/kde/j-comment-4.html:
  • fast/js/kde/literals-expected.txt:
  • fast/js/kde/literals.html:
  • fast/js/kde/math-expected.txt:
  • fast/js/kde/math.html:
  • fast/js/kde/md5-1-expected.txt:
  • fast/js/kde/md5-1.html:
  • fast/js/kde/md5-2-expected.txt:
  • fast/js/kde/md5-2.html:
  • fast/js/kde/object_prototype-expected.txt:
  • fast/js/kde/object_prototype.html:
  • fast/js/kde/object_prototype_tostring-expected.txt:
  • fast/js/kde/object_prototype_tostring.html:
  • fast/js/kde/operators-expected.txt:
  • fast/js/kde/operators.html:
  • fast/js/kde/parse-expected.txt:
  • fast/js/kde/parse.html:
  • fast/js/kde/prototype_length-expected.txt:
  • fast/js/kde/prototype_length.html:
  • fast/js/kde/prototype_proto-expected.txt:
  • fast/js/kde/prototype_proto.html:
  • fast/js/kde/resources/TEMPLATE-n.html: Added.
  • fast/js/kde/resources/TEMPLATE.html: Added.
  • fast/js/kde/resources/base.js: Removed.
  • fast/js/kde/resources/inbuilt_function_tostring.js:
  • fast/js/kde/resources/shell.js: Removed.
  • fast/js/kde/scope-expected.txt:
  • fast/js/kde/scope.html:
  • fast/js/kde/statements-expected.txt:
  • fast/js/kde/statements.html:
  • fast/js/kde/string-1-n-expected.txt:
  • fast/js/kde/string-1-n.html:
  • fast/js/kde/string-2-n-expected.txt:
  • fast/js/kde/string-2-n.html:
  • fast/js/kde/var_decl_init-expected.txt:
  • fast/js/kde/var_decl_init.html:
  • fast/js/location-assign-expected.txt: Removed.
  • fast/js/location-assign.html: Removed.
  • fast/js/named-function-expression-expected.txt:
  • fast/js/named-function-expression.html:
  • fast/js/objc-big-method-name-expected.txt: Removed.
  • fast/js/objc-big-method-name.html: Removed.
  • fast/js/object-by-name-or-id-expected.txt: Removed.
  • fast/js/object-by-name-or-id.html: Removed.
  • fast/js/object-prototype-constructor-expected.txt:
  • fast/js/object-prototype-constructor.html:
  • fast/js/object-prototype-toLocaleString-expected.txt:
  • fast/js/object-prototype-toLocaleString.html:
  • fast/js/postfix-syntax-expected.txt:
  • fast/js/postfix-syntax.html:
  • fast/js/prefix-syntax-expected.txt:
  • fast/js/prefix-syntax.html:
  • fast/js/property-getters-and-setters-expected.txt:
  • fast/js/property-getters-and-setters.html:
  • fast/js/propertyIsEnumerable-expected.txt: Added.
  • fast/js/propertyIsEnumerable.html: Added.
  • fast/js/regexp-caching-expected.txt:
  • fast/js/regexp-extended-characters-crash-expected.txt:
  • fast/js/regexp-extended-characters-crash.html:
  • fast/js/regexp-extended-characters-match-expected.txt:
  • fast/js/regexp-extended-characters-match.html:
  • fast/js/regexp-lastindex-expected.txt:
  • fast/js/regexp-lastindex.html:
  • fast/js/replace-child-siblings-expected.txt: Removed.
  • fast/js/replace-child-siblings.html: Removed.
  • fast/js/resources/TEMPLATE.html: Added.
  • fast/js/resources/activation-proto.js: Added.
  • fast/js/resources/array-every.js: Added.
  • fast/js/resources/array-float-delete.js: Added.
  • fast/js/resources/assign.js: Added.
  • fast/js/resources/char-at.js: Added.
  • fast/js/resources/child.html: Removed.
  • fast/js/resources/code-serialize-paren.js: Added.
  • fast/js/resources/const.js: Added.
  • fast/js/resources/cyclic-ref-toString.js: Added.
  • fast/js/resources/date-DST-pre-1970.js: Added.
  • fast/js/resources/date-big-constructor.js: Added.
  • fast/js/resources/date-big-setdate.js: Added.
  • fast/js/resources/date-big-setmonth.js: Added.
  • fast/js/resources/date-negative-setmonth.js: Added.
  • fast/js/resources/date-parse-comments-test.js: Added.
  • fast/js/resources/date-parse-test.js: Added.
  • fast/js/resources/date-preserve-milliseconds.js: Added.
  • fast/js/resources/declaration-in-block.js: Added.
  • fast/js/resources/delete-syntax.js: Added.
  • fast/js/resources/eval-var-decl.js: Added.
  • fast/js/resources/exception-linenums.js: Added.
  • fast/js/resources/for-in-to-text.js: Added.
  • fast/js/resources/has-own-property.js: Added.
  • fast/js/resources/integer-extremes.js: Added.
  • fast/js/resources/isPrototypeOf.js: Added.
  • fast/js/resources/js-test-post-n.js: Added.
  • fast/js/resources/js-test-post.js: Added.
  • fast/js/resources/js-test-pre.js: Added.
  • fast/js/resources/js-test-style.css: Added.
  • fast/js/resources/named-function-expression.js: Added.
  • fast/js/resources/new-location.html: Removed.
  • fast/js/resources/object-prototype-constructor.js: Added.
  • fast/js/resources/object-prototype-toLocaleString.js: Added.
  • fast/js/resources/postfix-syntax.js: Added.
  • fast/js/resources/prefix-syntax.js: Added.
  • fast/js/resources/property-getters-and-setters.js: Added.
  • fast/js/resources/propertyIsEnumerable.js: Added.
  • fast/js/resources/regexp-extended-characters-crash.js: Added.
  • fast/js/resources/regexp-extended-characters-match.js: Added.
  • fast/js/resources/regexp-lastindex.js: Added.
  • fast/js/resources/slash-lineterminator-parse.js: Added.
  • fast/js/resources/string-from-char-code.js: Added.
  • fast/js/resources/string-index-overflow.js: Added.
  • fast/js/resources/string-replace-2.js: Added.
  • fast/js/resources/string-slice-abnormal-values.js: Added.
  • fast/js/resources/string-split-ignore-case.js: Added.
  • fast/js/resources/string_replace.js: Added.
  • fast/js/resources/toString-overrides.js: Added.
  • fast/js/resources/toString-stack-overflow.js: Added.
  • fast/js/resources/typeof-syntax.js: Added.
  • fast/js/slash-lineterminator-parse-expected.txt:
  • fast/js/slash-lineterminator-parse.html:
  • fast/js/string-from-char-code-expected.txt:
  • fast/js/string-from-char-code.html:
  • fast/js/string-index-overflow-expected.txt:
  • fast/js/string-index-overflow.html:
  • fast/js/string-replace-2-expected.txt:
  • fast/js/string-replace-2.html:
  • fast/js/string-slice-abnormal-values-expected.txt:
  • fast/js/string-slice-abnormal-values.html:
  • fast/js/string-split-ignore-case-expected.txt:
  • fast/js/string-split-ignore-case.html:
  • fast/js/string_replace-expected.txt:
  • fast/js/string_replace.html:
  • fast/js/toString-overrides-expected.txt:
  • fast/js/toString-overrides.html:
  • fast/js/toString-stack-overflow-expected.txt:
  • fast/js/toString-stack-overflow.html:
  • fast/js/typeof-syntax-expected.txt:
  • fast/js/typeof-syntax.html:


  • move DOM tests from fast/js to fast/dom
  • fast/dom/HTMLDocument/object-by-name-or-id-expected.txt: Added.
  • fast/dom/HTMLDocument/object-by-name-or-id.html: Added.
  • fast/dom/Window/Plug-ins-expected.checksum: Added.
  • fast/dom/Window/Plug-ins-expected.png: Added.
  • fast/dom/Window/Plug-ins-expected.txt: Added.
  • fast/dom/Window/Plug-ins.html: Added.
  • fast/dom/Window/global-opener-function-expected.txt: Added.
  • fast/dom/Window/global-opener-function.html: Added.
  • fast/dom/array-special-accessors-should-ignore-items-expected.txt: Added.
  • fast/dom/array-special-accessors-should-ignore-items.html: Added.
  • fast/dom/location-assign-expected.txt: Added.
  • fast/dom/location-assign.html: Added.
  • fast/dom/objc-big-method-name-expected.txt: Added.
  • fast/dom/objc-big-method-name.html: Added.
  • fast/dom/replace-child-siblings-expected.txt: Added.
  • fast/dom/replace-child-siblings.html: Added.
  • fast/dom/resources/child.html: Added.
  • fast/dom/resources/new-location.html: Added.
  • fast/dom/resources/xmlhttprequest-get-data.xml: Added.
  • fast/dom/test-prototypes-expected.txt: Added.
  • fast/dom/test-prototypes.html: Added.
  • fast/dom/window-object-cross-frame-calls-expected.txt: Added.
  • fast/dom/window-object-cross-frame-calls.html: Added.
  • fast/dom/xmlhttprequest-get-expected.txt: Added.
  • fast/dom/xmlhttprequest-get.xhtml: Added.

WebKitTools:

Reviewed by Eric.


  • Scripts/make-js-test-wrappers: Added.
9:06 PM Changeset in webkit [11947] by mjs
  • 2 edits in trunk/WebKitTools

2006-01-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • Scripts/svn-create-patch: Fix to work when passed directory names.
8:13 PM Changeset in webkit [11945] by eseidel
  • 4 edits in trunk/WebCore

Reviewed by ggaren.

Remove all mention of NSView from khtml.

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::getAppletInstance): call w/ widget (DOM::HTMLEmbedElementImpl::getEmbedInstance): call w/ widget (DOM::HTMLObjectElementImpl::getObjectInstance): call w/ widget
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForWidget): renamed. (KWQKHTMLPart::getEmbedInstanceForWidget): renamed. (KWQKHTMLPart::getObjectInstanceForWidget): renamed.
8:08 PM Changeset in webkit [11946] by thatcher
  • 1 edit
    1539 adds in trunk

Rubber stamped by Eric.

Fixed corrupted PNGs after the Subversion import.

7:14 PM Changeset in webkit [11944] by eseidel
  • 28 edits
    4 copies
    2 moves
    1 add in trunk/WebCore

Rubber stamped by ggaren.

  • ForwardingHeaders/qsortedlist.h: Added. (a khtml file was referencing KWQ directly.)
  • WebCore.xcodeproj/project.pbxproj: added new files.
  • khtml/editing/SelectionController.cpp: updated includes
  • khtml/editing/composite_edit_command.cpp: updated includes
  • khtml/editing/htmlediting.cpp: updated includes
  • khtml/editing/markup.cpp: updated includes
  • khtml/editing/visible_position.cpp: updated includes
  • khtml/editing/visible_text.cpp: updated includes
  • khtml/editing/visible_text.h: updated includes
  • khtml/editing/visible_units.cpp: updated includes
  • khtml/khtml_part.cpp: updated includes
  • khtml/khtmlview.cpp: updated includes
  • khtml/rendering/InlineTextBox.cpp: Split out from render_text
  • khtml/rendering/InlineTextBox.h: Split out from render_text
  • khtml/rendering/RenderText.cpp: Split out from render_text (khtml::RenderText::position): removed DEBUG_LAYOUT
  • khtml/rendering/RenderText.h: Split out from render_text
  • khtml/rendering/RenderTextFragment.cpp: Split out from render_text
  • khtml/rendering/RenderTextFragment.h: Split out from render_text
  • khtml/rendering/bidi.cpp: updated includes
  • khtml/rendering/render_block.cpp: updated includes
  • khtml/rendering/render_br.cpp: updated includes
  • khtml/rendering/render_br.h: updated includes
  • khtml/rendering/render_button.cpp: updated includes
  • khtml/rendering/render_container.cpp: updated includes
  • khtml/rendering/render_flow.cpp: updated includes
  • khtml/rendering/render_line.cpp: updated includes
  • khtml/rendering/render_object.cpp: updated includes
  • khtml/rendering/render_text.cpp: Removed.
  • khtml/rendering/render_text.h: Removed.
  • khtml/xml/dom_docimpl.cpp: updated includes
  • khtml/xml/dom_nodeimpl.cpp: updated includes
  • khtml/xml/dom_position.cpp: updated includes
  • khtml/xml/dom_textimpl.cpp: updated includes
  • kwq/KWQAccObject.mm: updated includes
  • kwq/KWQKHTMLPart.mm: updated includes
  • kwq/KWQRenderTreeDebug.cpp: updated includes
6:28 PM Changeset in webkit [11943] by ggaren
  • 3 edits
    2 adds in trunk/WebKitTools

Reviewed by Eric.

  • Added back/forward navigation support to DumpRenderTree. Hopefully we can start writing automated loader tests now. I have one in the works.
  • DumpRenderTree/DumpRenderTree.m: (main): Construct global navigationController on entry, destroy on exit. Set frame to nil on exit too, to match all the other global objects. (Probably academic, since the process is exiting, anyway.) (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): Notify the navigationController, in case it wants to kick off a load. (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): Expose the navigationController to scripting.

New class, should be straightforward:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/NavigationController.h: Added.
  • DumpRenderTree/NavigationController.m: Added.

(+[NavigationController isSelectorExcludedFromWebScript:]):
(+[NavigationController webScriptNameForSelector:]):
(-[NavigationController setPendingScript:]):
(-[NavigationController setPendingRequest:]):
(-[NavigationController evaluateWebScript:afterBackForwardNavigation:]):
(-[NavigationController webView:didFinishLoadForFrame:]):
(-[NavigationController dealloc]):

4:56 PM Changeset in webkit [11942] by eseidel
  • 712 edits
    7 adds
    29 deletes in trunk/LayoutTests

Rubber stamped by mjs.

Remove svn:keywords property from all SVG tests.
Check in new results using old .svg files from CVS HEAD.
Enable previously disabled SVG tests.
Disable SVG <image> tests which fail intermittently due to:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

3:50 PM Changeset in webkit [11941] by thatcher
  • 1 edit in trunk/LayoutTests/css1/basic/comments-expected.png

Testing an image fix.

2:03 PM Changeset in webkit [11940] by ggaren
  • 2 edits in trunk/LayoutTests

Reviewed by eric.

New results for recently fixed test.

  • fast/js/kde/parse-expected.txt:
1:53 PM Changeset in webkit [11939] by eseidel
  • 1 edit
    71 adds in trunk/LayoutTests

Reviewed by ggaren.

Replace corrupted files from svn conversion.

  • css2.1/support/1x1-green.png: Replaced.
  • css2.1/support/1x1-lime.png: Replaced.
  • css2.1/support/1x1-red.png: Replaced.
  • css2.1/support/1x1-transparent.gif: Replaced.
  • css2.1/support/1x1-transparent.png: Replaced.
  • css2.1/support/a-green.css: Replaced.
  • css2.1/support/b-green.css: Replaced.
  • css2.1/support/c-red.css: Replaced.
  • css2.1/support/cat.png: Replaced.
  • css2.1/support/css1test412a.png: Replaced.
  • css2.1/support/css1test412b-a.png: Replaced.
  • css2.1/support/css1test412b-b.png: Replaced.
  • css2.1/support/css1test42a.png: Replaced.
  • css2.1/support/css1test44a.png: Replaced.
  • css2.1/support/css1test44b.png: Replaced.
  • css2.1/support/css1test44c.png: Replaced.
  • css2.1/support/css1test44d.png: Replaced.
  • css2.1/support/css1test544b.png: Replaced.
  • css2.1/support/css1test545.png: Replaced.
  • css2.1/support/css1test548d.png: Replaced.
  • css2.1/support/css1test548e.png: Replaced.
  • css2.1/support/css1test5510-i.png: Replaced.
  • css2.1/support/css1test5525b-0.png: Replaced.
  • css2.1/support/css1test5525b-1.png: Replaced.
  • css2.1/support/css1test5525b-2.png: Replaced.
  • css2.1/support/css1test5525b-3.png: Replaced.
  • css2.1/support/css1test5525b-4.png: Replaced.
  • css2.1/support/css1test5525b-5.png: Replaced.
  • css2.1/support/css1test5525b-6.png: Replaced.
  • css2.1/support/css1test5525ce-1.png: Replaced.
  • css2.1/support/css1test5525ce-2.png: Replaced.
  • css2.1/support/css1test5525cf-0.png: Replaced.
  • css2.1/support/css1test5525cf-1.png: Replaced.
  • css2.1/support/css1test5526.png: Replaced.
  • css2.1/support/css1test5526c.gif: Replaced.
  • css2.1/support/css1test5526c.png: Replaced.
  • css2.1/support/css1test562.png: Replaced.
  • css2.1/support/css1test566a.png: Replaced.
  • css2.1/support/css1test62-inner.png: Replaced.
  • css2.1/support/css1test62-outer.png: Replaced.
  • css2.1/support/css1test64a.css: Replaced.
  • css2.1/support/css1test64b.css: Replaced.
  • css2.1/support/pattern-gg-gr.png: Replaced.
  • css2.1/support/pattern-grg-rgr-grg.png: Replaced.
  • css2.1/support/pattern-grg-rrg-rgg.png: Replaced.
  • css2.1/support/pattern-rgr-grg-rgr.png: Replaced.
  • css2.1/support/pattern-tr.png: Replaced.
  • css2.1/support/ruler-h-50%.png: Replaced.
  • css2.1/support/ruler-h-50px.png: Replaced.
  • css2.1/support/ruler-v-100px.png: Replaced.
  • css2.1/support/ruler-v-50px.png: Replaced.
  • css2.1/support/square-purple.png: Replaced.
  • css2.1/support/square-teal.png: Replaced.
  • css2.1/support/square-white.png: Replaced.
  • css2.1/support/swatch-blue.png: Replaced.
  • css2.1/support/swatch-green.png: Replaced.
  • css2.1/support/swatch-lime.png: Replaced.
  • css2.1/support/swatch-orange.png: Replaced.
  • css2.1/support/swatch-red.png: Replaced.
  • css2.1/support/swatch-white.png: Replaced.
  • css2.1/support/swatch-yellow.png: Replaced.
  • css2.1/support/test-bl.gif: Replaced.
  • css2.1/support/test-bl.png: Replaced.
  • css2.1/support/test-br.gif: Replaced.
  • css2.1/support/test-br.png: Replaced.
  • css2.1/support/test-inner-half-size.png: Replaced.
  • css2.1/support/test-outer.png: Replaced.
  • css2.1/support/test-tl.gif: Replaced.
  • css2.1/support/test-tl.png: Replaced.
  • css2.1/support/test-tr.gif: Replaced.
  • css2.1/support/test-tr.png: Replaced.
1:45 AM Changeset in webkit [11938] by thatcher
  • 7 edits in trunk

Adding more .DS_Store ignores.

1:33 AM Changeset in webkit [11937] by thatcher
  • 1 edit
    1 delete in trunk/WebKitTools

Removed this script, no longer needs with the Subversion switch.

  • checkout: Removed.
1:32 AM Changeset in webkit [11936] by thatcher
  • 2 edits in trunk/WebKitTools

Removes some stray tabs.

  • Scripts/update-webkit:
1:24 AM Changeset in webkit [11935] by eseidel
  • 2 edits
    3 moves in trunk/WebCore

Reviewed by mjs & xenon.

Renamed a few in kwq/ from .mm to .cpp

  • WebCore.xcodeproj/project.pbxproj: updated paths
  • kwq/KWQDictImpl.cpp: Added.
  • kwq/KWQDictImpl.mm: Removed.
  • kwq/KWQKPartsEvent.cpp: Added.
  • kwq/KWQKPartsEvent.mm: Removed.
  • kwq/KWQListImpl.cpp: Added.
  • kwq/KWQListImpl.mm: Removed.
1:07 AM Changeset in webkit [11934] by eseidel
  • 11 edits
    26 moves
    3 deletes in trunk/WebCore

Reviewed by mjs.

Renamed several files in kwq/ from .mm to .cpp
Removed a few pieces of unused KWQ code.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::continueProcessing): removed KWQUIEventTime (khtml::HTMLTokenizer::write): removed KWQUIEventTime
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::slotFinished): removed KWQUIEventTime
  • khtml/misc/loader.cpp: (CachedObject::finish): removed KWQUIEventTime
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): removed KWQUIEventTime
  • kwq/KWQArrayImpl.cpp: Added.
  • kwq/KWQArrayImpl.mm: Removed.
  • kwq/KWQBuffer.cpp: Added.
  • kwq/KWQBuffer.mm: Removed.
  • kwq/KWQCString.cpp: Added.
  • kwq/KWQCString.mm: Removed.
  • kwq/KWQCharsets.cpp: Added.
  • kwq/KWQCharsets.mm: Removed.
  • kwq/KWQCollection.h: (QPtrCollection::~QPtrCollection): made inline
  • kwq/KWQCollection.mm: Removed.
  • kwq/KWQDateTime.cpp: Added, removed KWQUIEventTime
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm: Removed.
  • kwq/KWQGlobal.cpp: Added.
  • kwq/KWQGlobal.mm: Removed.
  • kwq/KWQGuardedPtr.cpp: Added.
  • kwq/KWQGuardedPtr.mm: Removed.
  • kwq/KWQKCharsets.cpp: Added.
  • kwq/KWQKCharsets.mm: Removed.
  • kwq/KWQKGlobalSettings.h: (KGlobalSettings::generalFont): made inline (KGlobalSettings::windowTitleFont): made inline (KGlobalSettings::menuFont): made inline (KGlobalSettings::contrast): made inline
  • kwq/KWQKGlobalSettings.mm: Removed.
  • kwq/KWQKHTMLFactory.cpp: Added.
  • kwq/KWQKHTMLFactory.mm: Removed.
  • kwq/KWQKHTMLView.cpp: Added.
  • kwq/KWQKHTMLView.mm: Removed.
  • kwq/KWQKJob.h:
  • kwq/KWQKJob.mm: Removed.
  • kwq/KWQKWin.cpp: Added.
  • kwq/KWQKWin.mm: Removed.
  • kwq/KWQMapImpl.cpp: Added.
  • kwq/KWQMapImpl.mm: Removed.
  • kwq/KWQObject.cpp: Added.
  • kwq/KWQObject.mm: Removed.
  • kwq/KWQPen.cpp: Added.
  • kwq/KWQPen.mm: Removed.
  • kwq/KWQPointArray.cpp: Added.
  • kwq/KWQPointArray.mm: Removed.
  • kwq/KWQPtrDictImpl.cpp: Added.
  • kwq/KWQPtrDictImpl.mm: Removed.
  • kwq/KWQRegExp.cpp: Added.
  • kwq/KWQRegExp.mm: Removed.
  • kwq/KWQRegion.cpp: Added.
  • kwq/KWQRegion.mm: Removed.
  • kwq/KWQStyle.cpp: Added.
  • kwq/KWQStyle.mm: Removed.
  • kwq/KWQTextCodec.cpp: Added.
  • kwq/KWQTextCodec.mm: Removed.
  • kwq/KWQTextStream.cpp: Added.
  • kwq/KWQTextStream.mm: Removed.
  • kwq/KWQTimer.cpp: Added.
  • kwq/KWQTimer.mm: Removed.
  • kwq/KWQValueListImpl.cpp: Added.
  • kwq/KWQValueListImpl.mm: Removed.
  • kwq/KWQVariant.cpp: Added.
  • kwq/KWQVariant.mm: Removed.
  • kwq/KWQVectorImpl.cpp: Added.
  • kwq/KWQVectorImpl.mm: Removed.
  • kwq/KWQWMatrix.cpp: Added.
  • kwq/KWQWMatrix.mm: Removed.
12:50 AM Changeset in webkit [11933] by mjs
  • 541 edits
    2 adds in trunk

WebCore:

2006-01-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.


Affects many test results in LayoutTests/svg.

  • kcanvas/RenderSVGText.cpp: Added. Simple subclass of RenderBlock for SVG text. (RenderSVGText::RenderSVGText): just call superclass constructor. (RenderSVGText::translateTopToBaseline): helper to account for the fact that y coordinates for <text> give the baseline position, but the render tree expects current y to be the top. (RenderSVGText::translateForAttributes): translate to account for x and y attributes. (RenderSVGText::paint): Apply appropriate CTM transform and then just let RenderBlock paint.
  • kcanvas/RenderSVGText.h: Added. (RenderSVGText::renderName):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::nsGraphicsContext): We want the context flipped.
  • ksvg2/css/svg.css: Give <svg:text> display: block
  • ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::createRenderer): Create a RenderSVGText renderer. (SVGTextElementImpl::childShouldCreateRenderer): Let child text nodes make renderers, but nothing else (for now).
  • ksvg2/svg/SVGTextElementImpl.h: (KSVG::SVGTextElementImpl::rendererIsNeeded): It sure is! :-)
  • WebCore.xcodeproj/project.pbxproj: Add new files.

LayoutTests:

2006-01-08 Maciej Stachowiak <​mjs@apple.com>

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:

Jan 7, 2006:

11:55 PM Changeset in webkit [11932] by eseidel
  • 2 edits
    11 deletes in trunk/WebCore

Reviewed by mjs

Removed old, unneeded code.

  • WebCore+SVG/DrawCanvasItem.h: Removed.
  • WebCore+SVG/DrawCanvasItem.mm: Removed.
  • WebCore+SVG/DrawCanvasItemPrivate.h: Removed.
  • WebCore+SVG/DrawDocument.h: Removed.
  • WebCore+SVG/DrawDocument.mm: Removed.
  • WebCore+SVG/DrawDocumentPrivate.h: Removed.
  • WebCore+SVG/DrawView.h: Removed.
  • WebCore+SVG/DrawView.mm: Removed.
  • WebCore+SVG/DrawViewPrivate.h: Removed.
  • WebCore+SVG/NSSVGImageRep.h: Removed.
  • WebCore+SVG/NSSVGImageRep.m: Removed.
  • WebCore.xcodeproj/project.pbxproj: remove files
11:39 PM Changeset in webkit [11931] by eseidel
  • 2 edits in trunk/WebKitTools

Reviewed by darin.

build-webkit should pass on build arguments from command line
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5854

  • Scripts/build-webkit:
11:11 PM Changeset in webkit [11930] by eseidel
  • 2 edits in trunk/WebKitTools

Reviewed by mjs & xenon.

  • Scripts/update-webkit: support Internal updates as well
10:02 PM Changeset in webkit [11929] by mjs
  • 2 edits in trunk/WebCore

2006-01-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • fixed WebCore build
  • khtml/rendering/render_canvasimage.h: Remove unneeded extern declarations.
8:38 PM Changeset in webkit [11928] by thatcher
  • 3 edits in trunk/WebKitTools/Scripts

Updated for Subversion.

8:19 PM Changeset in webkit [11927] by thatcher
  • 8 deletes in trunk

Removing the .cvsignore files, cvs@svn used these to add the svn:ignore prop.

8:14 PM Changeset in webkit [11926] by thatcher
  • 3 edits
    5 adds in trunk

adding the new Makefiles.

4:16 PM Changeset in webkit [0]
  • in /
1:31 PM Changeset in webkit [12227] by thatcher
  • 1 edit
    1 add
    3 deletes in trunk/JavaScriptGlue

The Internal repository is up and running.
Removing .cvsignore files, the cvs2svn script adds the svn:ignore property for us but leaves these files.
Modified the svn:ignore on some directories to not ignore Makefile and the automake/configure files that are being removed.
New Makefiles that use the OpenSource tools to know the Xcode configuration and build location.

3:27 AM Changeset in webkit [11925] by ap
  • 6 edits
    4 adds in trunk

Reviewed by Darin, landed by ap.

Test: fast/text/atsui-small-caps-punctuation-size.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (createATSULayoutParameters): Changed the characters for which size must not change from !u_isbase() to the M* categories.
2:33 AM Changeset in webkit [11924] by andersca
  • 3 edits in trunk/WebCore

2006-01-07 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_html.cpp: Remove toPrimitive.
  • khtml/ecma/kjs_html.h: (KJS::HTMLAllCollection::isEqualToNull): Implement isEqualToNull and have it return true.
2:32 AM Changeset in webkit [11923] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-01-07 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.h: (KJS::JSObject::isEqualToNull): Add new function which returns true if an object should be treated as null when doing comparisons.
  • kjs/operations.cpp: (KJS::equal): Use isEqualToNull.
2:22 AM Changeset in webkit [11922] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Assertions.h: Use VA_ARGS in variadic macros.

Jan 6, 2006:

6:15 PM Changeset in webkit [11921] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4386652
Submitted by: eseidel
Reviewed by: darin

<rdar://problem/4386652> Crash: SVG filter crash at w3schools.com

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEDiffuseLightingQuartz::getCIFilter): nil check (KCanvasFESpecularLightingQuartz::getCIFilter): nil check
3:51 PM Changeset in webkit [11920] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changes mostly thanks to Maks Orlovich, tweaked a little by me.

  • kjs/create_hash_table: Use the same hash as the one used buy Identifier.
  • kjs/function.cpp: (KJS::FunctionImp::processParameters): Use the new List::copyFrom (KJS::ActivationImp::ActivationImp): track variable while iterating
  • kjs/internal.cpp: (KJS::StringImp::toObject): create StringInstance directly
  • kjs/list.cpp: (KJS::List::copy): implement in terms of copyFrom (KJS::List::copyFrom): more efficient way to copy in another list
  • kjs/list.h:
  • kjs/lookup.cpp: (keysMatch): updated to work with identifier hash (findEntry): ditto (Lookup::findEntry): ditto (Lookup::find): ditto
  • kjs/lookup.h:
2:49 PM Changeset in webkit [11919] by hyatt
  • 3 edits in trunk/JavaScriptCore/kjs

Fix build bustage on Mac.

2:43 PM Changeset in webkit [11918] by hyatt
  • 16 edits in trunk/JavaScriptCore

Land all the changes to make JSCore build again on windows.

2:21 PM Changeset in webkit [11917] by hyatt
  • 4 edits
    2 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the remaining project changes for building with VC 2005

1:09 PM Changeset in webkit [11916] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley (full credit) and Tim Omernick (half credit).

  • fixed <rdar://problem/4401102> REGRESSION (420+): When displaying a PDF, tabbing around stops working after reaching page
  • WebView.subproj/WebPDFView.m: (-[WebPDFView setNextKeyView:]): Use [PDFSubview documentView] rather than PDFSubview here, since that's the view that we now hand off first-responderhood to.
12:02 PM Changeset in webkit [11915] by bdakin
  • 4 edits in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

11:24 AM Changeset in webkit [11914] by ggaren
  • 2 edits
    1 add in trunk/WebCore

Patch by Mitz, reviwed by Darin, layout tested and landed by me.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setName):
  • manual-tests/empty-link-target.html: Added.
10:13 AM Changeset in webkit [11913] by ggaren
  • 3 edits
    1 delete in trunk

LayoutTests:

Rolling out this layout test for now, until we can get plugin testing
working.

  • fast/plugins/netscape-back-forward.html: Removed.

WebKitTools:

Temporarily rolling out plugin support from DumpRenderTree because it
caused lots of layout test regressions.

  • DumpRenderTree/DumpRenderTree.m: (main): Remove invisible window added to support plugins.
7:50 AM Changeset in webkit [11912] by ap
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

Test cases:

  • fast/forms/form-get-multipart.html
  • fast/forms/form-get-multipart2.html
  • fast/forms/form-get-multipart3.html
  • fast/forms/form-post-urlencoded.html
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::submit): Reset m_multipart to false if not posting. (DOM::HTMLFormElementImpl::parseEnctype): multipart/form-data doesn't imply POST method.
6:35 AM Changeset in webkit [11911] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Eric.

Test case: fast/parser/entity-ignorable-whitespace.xhtml

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::finish): install an ignorableWhitespace callback to work around a libxml2 bug (khtml::ignorableWhitespaceHandler): no-op
3:03 AM Changeset in webkit [11910] by ap
  • 1 edit in trunk/JavaScriptCore/kjs/function.cpp

Same as the previous checkin, but should be for real now.

2:47 AM Changeset in webkit [11909] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove conflict marker

2:44 AM Changeset in webkit [11908] by ap
  • 2 edits in trunk/JavaScriptCore
  • fix development build failure from the previous checkin
  • kjs/function.cpp: (KJS::ActivationImp::put): Use prototype() accessor in assert.
2:44 AM Changeset in webkit [11907] by andersca
  • 3 edits in trunk/LayoutTests

2006-01-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/dom/set-innerHTML-expected.txt:
  • fast/dom/set-innerHTML.xhtml: Update these with the attached test case.
2:39 AM Changeset in webkit [11906] by andersca
  • 2 edits in trunk/WebCore

2006-01-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/xml_tokenizer.cpp: (khtml::balancedStartElementNsHandler): (khtml::balancedEndElementNsHandler): (khtml::balancedCharactersHandler): (khtml::balancedProcessingInstructionHandler): (khtml::balancedCdataBlockHandler): (khtml::balancedCommentHandler): (khtml::balancedWarningHandler): Add handlers.

(khtml::parseXMLDocumentFragment):
Change back into using xmlParseBalancedChunkMemory.

1:16 AM Changeset in webkit [11905] by eseidel
  • 2 edits
    4 adds in trunk/LayoutTests

Bug #: 5969
Submitted by: Alexander Kellett <​lypanov@kde.org>
Reviewed by: eseidel

Basic support for <mask> tag.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5969

  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: updated.
  • svg/custom/grayscale-gradient-mask-expected.checksum: Added.
  • svg/custom/grayscale-gradient-mask-expected.png: Added.
  • svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • svg/custom/grayscale-gradient-mask.svg: Added.
1:10 AM Changeset in webkit [11904] by eseidel
  • 17 edits
    4 adds in trunk/WebCore

Bug #: 5969
Submitted by: Alexander Kellett <​lypanov@kde.org>
Reviewed by: eseidel

Basic support for <mask> tag.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5969
Still missing attribute support for: maskUnits, maskContentUnits.

Mask pixel tests do not work in DumpRenderTree due to:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6327
Added test cases anyway.

This also tickles a (known) gradient update issue:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6052

  • WebCore.xcodeproj/project.pbxproj: added Mask files
  • kcanvas/KCanvasResources.cpp: (KCanvasMasker::KCanvasMasker): added. (KCanvasMasker::~KCanvasMasker): added. (KCanvasMasker::setMask): added. (KCanvasMasker::externalRepresentation): added. (getMaskerById): added.
  • kcanvas/KCanvasResources.h: (KCanvasResource::isMasker): added. (KCanvasMasker::isMasker): added. (KCanvasMasker::mask): added.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): added mask support
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Added. (KCanvasMaskerQuartz::KCanvasMaskerQuartz): added.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Added. (applyLuminanceToAlphaFilter): added. (applyExpandAlphatoGrayscaleFilter): added. (transformImageIntoGrayscaleMask): added. (KCanvasMaskerQuartz::applyMask): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): added mask support.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createResource): added mask support.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (debugDumpCGImageToFile): added, debug only. (debugDumpCGLayerToFile): added, debug only. (debugDumpCIImageToFile): added, debug only.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty): added mask support.
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): added mask support. (SVGRenderStyle::operator==): added mask support.
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleMaskData::StyleMaskData): added mask support. (StyleMaskData::operator==): added mask support.
  • ksvg2/css/SVGRenderStyleDefs.h: (KSVG::StyleMaskData::operator!=): added mask support.
  • ksvg2/ecma/Ecma.cpp: (Ecma::inheritedGetDOMNode): added mask support.
  • ksvg2/svg/SVGMaskElementImpl.cpp: Added. (KSVG::SVGMaskElementImpl::SVGMaskElementImpl): added. (KSVG::SVGMaskElementImpl::~SVGMaskElementImpl): added. (KSVG::SVGMaskElementImpl::x): added. (KSVG::SVGMaskElementImpl::y): added. (KSVG::SVGMaskElementImpl::width): added. (KSVG::SVGMaskElementImpl::height): added. (KSVG::SVGMaskElementImpl::attributeChanged): added. (KSVG::SVGMaskElementImpl::childrenChanged): added. (KSVG::SVGMaskElementImpl::parseMappedAttribute): added. (KSVG::SVGMaskElementImpl::drawMaskerContent): added. (KSVG::SVGMaskElementImpl::createRenderer): added. (KSVG::SVGMaskElementImpl::canvasResource): added.
  • ksvg2/svg/SVGMaskElementImpl.h: Added. (KSVG::SVGMaskElementImpl::isValid): added. (KSVG::SVGMaskElementImpl::rendererIsNeeded): added.
  • ksvg2/svg/svgtags.in: added <mask> support.
12:32 AM Changeset in webkit [11903] by mjs
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): Implement directly, thus skipping getter/setter handling and proto handling, as well as inlining needed superclass stuff. (KJS::ActivationImp::put): Implement directly, skipping getter/setter, proto, and do canPut directly in PropertyMap::put since there's no static property table either.
  • kjs/function.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::put): Allow optionally inlining canPut check.
  • kjs/property_map.h:

LayoutTests:

Reviewed by Eric.

  • fast/js/activation-proto-expected.txt: Added.
  • fast/js/activation-proto.html: Added.

Jan 5, 2006:

9:57 PM Changeset in webkit [11902] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4400804> Client-side redirect to a non-HTTP URL confuses Safari

  • WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): If we were waiting for a quick redirect, but the policy delegate decided to ignore it, then we need to report that the client redirect was cancelled.
6:30 PM Changeset in webkit [11901]
  • 13 copies
    3 deletes in tags/JavaScriptCore-312~3~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3~1'.

6:30 PM Changeset in webkit [11900] by thatcher
  • 1 edit in branches/Safari-1-3-branch/JavaScriptCore/bindings/objc/objc_utility.mm

Build fix.

6:26 PM Changeset in webkit [11899]
  • 73 copies
    5 deletes in tags/JavaScriptCore-417~8~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~8~1'.

6:26 PM Changeset in webkit [11898] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/bindings/objc/objc_utility.mm

Fix a build problem on the branch, different than TOT.

6:00 PM Changeset in webkit [11897] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.8.1

5:59 PM Changeset in webkit [11896] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-12-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):
5:49 PM Changeset in webkit [11895]
  • 212 copies
    17 deletes in tags/WebCore-417~18~1

This commit was manufactured by cvs2svn to create tag
'WebCore-417~18~1'.

5:49 PM Changeset in webkit [11894] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.18.1

5:48 PM Changeset in webkit [11893] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej

Fix for <rdar://problem/4148730> SureSec si#182 safari heap overflow.
When a table has a really huge rowSpan, Safari used to crash because
the malloc of the grid for the table failed. This fix just checks for
the success of the malloc.

  • khtml/rendering/render_table.cpp: (RenderTableSection::ensureRows): Return false if the grid resize is not successful. (RenderTableSection::addCell): Return early if ensureRows() returned false.
  • khtml/rendering/render_table.h: Make ensureRows() return a bool instead of void.
5:39 PM Changeset in webkit [11892] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Version to JavaScriptCore-312.3.1

5:35 PM Changeset in webkit [11891]
  • 121 copies
    5 deletes in tags/WebCore-315~14~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~14~1'.

5:35 PM Changeset in webkit [11890] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.14.1

5:33 PM Changeset in webkit [11889] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej

Fix for <rdar://problem/4148730> SureSec si#182 safari heap overflow.
When a table has a really huge rowSpan, Safari used to crash because
the malloc of the grid for the table failed. This fix just checks for
the success of the malloc.

  • khtml/rendering/render_table.cpp: (RenderTableSection::ensureRows): Return false if the grid resize is not successful. (RenderTableSection::addCell): Return early if ensureRows() returned false.
  • khtml/rendering/render_table.h: Make ensureRows() return a bool instead of void.
5:25 PM Changeset in webkit [11888] by thatcher
  • 4 edits in branches/Safari-1-3-branch/JavaScriptCore

Merges fixes from TOT to Safari-1-3-branch

2005-12-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):
4:12 PM Changeset in webkit [11887] by sullivan
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): Just added a FIXME comment about how to clean up this minor hack in the future.
3:57 PM Changeset in webkit [11886] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim O.

  • fixed these bugs: <rdar://problem/3021785> page up/down don't work on frameset pages unless you click <rdar://problem/3021788> Page Up/Down moves an unscrollable frame if you click on it first

and the WebKit part of this (need new Safari too for complete fix):
<rdar://problem/4378905> Page up/down don't work in PDFs when address field is focused

I moved some logic down from Safari that dealt with finding the largest scrollable child frame in a frameset,
and added support for standard scrolling-related selectors to WebPDFView. The latter was needed for 4378905;
the former was needed due to side effects of the Safari part of the change. As long as I was doing the former,
I also used that logic to fix 3021785 and 3021788.

  • WebView.subproj/WebFrameViewPrivate.h: new currently-private methods _hasScrollBars and _largestChildWithScrollBars
  • WebView.subproj/WebFrameView.m: (-[WebFrameView scrollToBeginningOfDocument:]): if we don't have scroll bars, operate on our largest child with scroll bars instead (-[WebFrameView scrollToEndOfDocument:]): ditto (-[WebFrameView _pageVertically:]): ditto (-[WebFrameView _pageHorizontally:]): ditto (-[WebFrameView _scrollLineVertically:]): ditto (-[WebFrameView _scrollLineHorizontally:]): ditto (-[WebFrameView keyDown:]): where we were bailing out if ![self allowsScrolling], also check for whether there's a child with scroll bars, and don't bail out if so (-[WebFrameView _area]): new helper method used to implement _largestChildWithScrollBars (code moved from Safari) (-[WebFrameView _hasScrollBars]): new method, just returns YES if either scroll bar is showing (code moved from Safari) (-[WebFrameView _largestChildWithScrollBars]): new method, returns the child with the largest area that is showing at least one scroll bar (code moved from Safari and tweaked a little)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): new method, hackaround for the fact that PDFView handles key downs from standard scrolling keys but does not implement the standard responder selectors (-[WebPDFView scrollPageDown:]): use _fakeKeyEventWithFunctionKey: to get the PDFView to scroll appropriately (-[WebPDFView scrollPageUp:]): ditto (-[WebPDFView scrollToBeginningOfDocument:]): ditto (-[WebPDFView scrollToEndOfDocument:]): ditto
  • WebView.subproj/WebView.m: add scrollToBeginningOfDocument and scrollToEndOfDocument to the list of responder operations that we hand off appropriately to the responder chain. These two aren't defined in any header but are generated by Home and End keys and used by the text system.
2:23 PM Changeset in webkit [11885] by ggaren
  • 6 edits
    10 adds in trunk

LayoutTests:

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
REGRESSION: Repro crash in JS called from Flash on bdash.net.nz

  • fast/plugins/netscape-back-forward-expected.txt: Added.
  • fast/plugins/netscape-back-forward.html: Added.
  • fast/plugins/resources/go-back.html: Added.

WebKit:

Reviewed by Darin.

  • WebKit.exp: export WebPluginDatabase class, which DumpRenderTree needs to add plugins to the runtime.

WebKitTools:

Reviewed by darin.

Also wrote first test plugin.

  • DumpRenderTree/DumpRenderTree.m: (main): (1) Put the WebView in an invisible window, because PlugIns are optimized not to load if there's no parent window. (2) Tell WebKit to load any PlugIns in the directory from which we loaded. This means we can build nasty PlugIns alongside DumpRenderTree and they'll load automagically during layout testing, but they won't be added to the user's system, hosing apps like Safari.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new test PlugIn to project.

PlugIn added to project:

  • DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added. (getPluginClass): (initializeIdentifiers): (pluginHasProperty): (pluginHasMethod): (pluginGetProperty): (pluginSetProperty): (pluginInvoke): (pluginInvokeDefault): (pluginInvalidate): (pluginAllocate): (pluginDeallocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
12:48 PM Changeset in webkit [11884] by ap
  • 454 edits in trunk/LayoutTests

Reviewed by Darin.

Added UTF-8 BOMs to css2.1 tests.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6312

9:44 AM Changeset in webkit [11883] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Move log message to top of file where it belongs.

Jan 4, 2006:

10:41 PM Changeset in webkit [11882] by mjs
  • 15 edits
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Eric.

Based on a patch by Eric.

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): (DOM::freeXsltParamArray): Use fastMalloc/fastFree.

(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.

WebKit:

Reviewed by Darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge, instead of having it bubble through the view and frame.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge initWithFrameName:view:]): don't pass name to frame, we own it now; set it on ourselves directly (-[WebBridge findFrameNamed:]): removed (-[WebBridge createWindowWithURL:frameName:]): set name on bridge, not webview (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge runModal]): remove excess braces
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebControllerSets.h: Removed.
  • WebView.subproj/WebControllerSets.m: Removed.
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate name]): removed (-[WebFramePrivate setName:]): removed (-[WebFramePrivate dealloc]): don't release name, we no longer have one (-[WebFrame _appendChild:]): removed (-[WebFrame _removeChild:]): removed (-[WebFrame _createItem:]): removed stray space (-[WebFrame _immediateChildFrameNamed:]): Just call the bridge (-[WebFrame _setName:]): removed (-[WebFrame _detachFromParent]): remove bridge from parent note self (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _addChild:]): Call appendChild: on bridge, not self (-[WebFrame _nextFrameWithWrap:]): just call bridge (and moved helpers there) (-[WebFrame _previousFrameWithWrap:]): just call bridge (and moved helpers there) (-[WebFrame _initWithWebFrameView:webView:bridge:]): don't take a name any more (-[WebFrame _setFrameNamespace:]): just call bridge (-[WebFrame _frameNamespace]): just call bridge (-[WebFrame _hasSelection]): remove excess braces (-[WebFrame _clearSelection]): ditto (-[WebFrame initWithName:webFrameView:webView:]): no more name (-[WebFrame name]): just call bridge (-[WebFrame findFrameNamed:]): just call bridge (and moved helpers there) (-[WebFrame parentFrame]): fixed for new style
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
5:13 PM Changeset in webkit [11881]
  • 121 copies
    5 deletes in tags/WebCore-315~14

This commit was manufactured by cvs2svn to create tag
'WebCore-315~14'.

5:13 PM Changeset in webkit [11880] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning.

1:44 PM Changeset in webkit [11879] by ggaren
  • 5 edits in trunk/JavaScriptCore

Patch by ​kimmo.t.kinnunen@nokia.com, reviewed by darin, tweaked by me.

  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/lexer.cpp: (Lexer::shift): (Lexer::lex): (Lexer::isWhiteSpace): (Lexer::isLineTerminator): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::scanRegExp):
  • kjs/lexer.h: (KJS::Lexer::):
  • tests/mozilla/expected.html: Updated test results.
1:32 PM Changeset in webkit [11878] by darin
  • 1 edit
    1 add in trunk/LayoutTests
  • added a missing test result
  • svg/custom/fractional-rects-expected.png: Added.
1:21 PM Changeset in webkit [11877] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/xsl/xslt-processer-expected.txt: Update.
1:17 PM Changeset in webkit [11876] by andersca
  • 2 edits in trunk/WebCore

2006-01-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Based on a patch by Eric.

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): (DOM::freeXsltParamArray): Use fastMalloc/fastFree.

(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.

1:10 PM Changeset in webkit [11875] by thatcher
  • 1 edit
    3 adds in trunk/WebKitTools

Reviewed by Darin.
Created by Eric.
Tweaked and tested by me.

New scripts to work with Subversion when the switch happens.
These will replace cvs-apply, cvs-unapply, and cvs-create-patch.

  • Scripts/svn-apply: Added.
  • Scripts/svn-create-patch: Added.
  • Scripts/svn-unapply: Added.
1:05 PM Changeset in webkit [11874] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
document.plugins doesn't exist

  • fast/dom/HTMLDocument/document-plugins-expected.txt: Added.
  • fast/dom/HTMLDocument/document-plugins.html: Added.

WebCore:

Reviewed by darin.

  • khtml/ecma/kjs_html.cpp: Added 'plugins' as synonym for 'embeds'
12:01 PM Changeset in webkit [11873] by ggaren
  • 3 edits
    3 adds in trunk

LayoutTests:

Layout test for <rdar://problem/4214080> document.embeds:
embeds[0].Play() undefined at languageguide.org prevents audio playing
on mouseover

  • fast/dom/object-embed-plugin-scripting-expected.txt: Added.
  • fast/dom/object-embed-plugin-scripting.html: Added.
  • fast/dom/resources/articles.m4a: Added.

WebCore:

Reviewed by darin.

  • Fixed <rdar://problem/4214080> document.embeds: embeds[0].Play() undefined at languageguide.org prevents audio playing on mouseover
  • Layout test: fast/dom/object-embed-plugin-scripting.html

A common idiom the kids like to use these days for plugins is to nest
an <embed> inside an <object>, and assume that IE will honor the first,
Mozilla the second. We happen to honor both, but the rules dictate that
only the outer <object> gets a plugin/renderer. (A plugin is a

renderer.) This is a problem because sites ID us as Mozilla and
therefore attempt to script their plugins through the <embed>, which
has no plugin/renderer. The fix here is to have an <embed> return its
parent node's plugin/renderer when queried, if and only if it has no
renderer of its own and its parent node is an <object>. We may decide
to restrict this further in the future.

One happy consequence of this patch is that all the apple.com Quicktime
websites we had previously broken with TOT are now fixed.

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLEmbedElementImpl::getEmbedInstance): The "if (!r)" clause implements the logic I just described. The code below it I changed just for style, to match the style in getObjectInstance().

(DOM::HTMLEmbedElementImpl::rendererIsNeeded): Assert that an <object>
parent has a renderer because we're going to use it later.

(DOM::HTMLObjectElementImpl::rendererIsNeeded): Changed to match style
of HTMLEmbedElementImpl counterpart.

6:42 AM Changeset in webkit [11872] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin, landed by ap.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Repaint parts of the border that moved.
  • manual-tests/border-repaint-glitch.html: Added.
12:23 AM Changeset in webkit [11871] by eseidel
  • 190 edits
    3 adds in trunk/LayoutTests

Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel

Updated layout tests after QRect (size & point) to Q*F change
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4462

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/fractional-rects-expected.checksum: Added.
  • svg/custom/fractional-rects-expected.txt: Added.
  • svg/custom/fractional-rects.svg: Added.
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/path-update-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
12:20 AM Changeset in webkit [11870] by eseidel
  • 34 edits
    9 adds in trunk/WebCore

Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel

Changed use of QRect to QRectF in the points where SVG can have
fractional numbers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4462

Added test cases:

  • svg/custom/fractional-rects.svg: copy of rounded-rects.svg with fractional coordinates.
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQWMatrix.h:
  • kwq/KWQWMatrix.mm: (QWMatrix::mapRect): mapRect for QRectF
  • kwq/KWQRectF.h:
  • kwq/KWQRectF.mm: Added. QRectF impl
  • kwq/KWQSizeF.h:
  • kwq/KWQSizeF.mm: Added.QSizeF impl
  • kwq/KWQPointF.h:
  • kwq/KWQPointF.mm: Added. QPointF impl
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::fillContains): (KCanvasContainer::strokeContains): (KCanvasContainer::relativeBBox): (KCanvasContainer::getAspectRatio): QRect -> QRectF
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp: (KCanvasFilterEffect::subRegion): (KCanvasFilterEffect::setSubRegion): QRect -> QRectF
  • kcanvas/KCanvasFilters.h: (KCanvasFilter::filterRect): (KCanvasFilter::setFilterRect): QRect -> QRectF (KCanvasFEConvolveMatrix::kernelSize): (KCanvasFEConvolveMatrix::setKernelSize): (KCanvasFEConvolveMatrix::targetOffset): (KCanvasFEConvolveMatrix::setTargetOffset): QSize -> QSizeF
  • kcanvas/KCanvasItem.cpp: (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::relativeBBox): QRect -> QRectF
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): QRect -> QRectF
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (hasFractions): helper function (operator<<): QSizeF operator, QRectF operator
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerLinearGradient::gradientStart): (KRenderingPaintServerLinearGradient::setGradientStart): (KRenderingPaintServerLinearGradient::gradientEnd): (KRenderingPaintServerLinearGradient::setGradientEnd): (KRenderingPaintServerRadialGradient::gradientCenter): (KRenderingPaintServerRadialGradient::setGradientCenter): (KRenderingPaintServerRadialGradient::gradientFocal): (KRenderingPaintServerRadialGradient::setGradientFocal): QPoint -> QPointF
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::Private::Private): x, y, width, height -> QRectF (KRenderingPaintServerPattern::setBbox): replaced get/set methods (KRenderingPaintServerPattern::bbox): replaced get/set methods (KRenderingPaintServerPattern::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): QRect -> QRectF
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect): QRect -> QRectF
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (drawMarkerWithData): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::paint): QRect -> QRectF (KCanvasItemQuartz::nodeAtPoint): QPoint -> QPointF (KCanvasItemQuartz::bboxForPath) :QRect -> QRectF (KCanvasItemQuartz::hitsPath):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect): QRect -> QRectF
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): QRect -> QRectF
  • khtml/rendering/render_object.h: (khtml::RenderObject::relativeBBox):QRect -> QRectF
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource): QRect -> QRectF
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value): QRect -> QRectF
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox): Rect -> QRectF
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): QRect -> QRectF
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::checkIntersection): QRect -> QRectF, removed integer conversions (SVGSVGElementImpl::checkEnclosure): QRect -> QRectF, removed integer conversions

Jan 3, 2006:

6:01 PM Changeset in webkit [11869] by bdakin
  • 2 edits in trunk/WebKit

Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:

5:02 PM Changeset in webkit [11868] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Vicki.

  • moved frame traversal code across from bridge, also dropped the children array
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge firstChild]): Moved from WebBridge. Use new _firstChild pointer. (-[WebCoreBridge lastChild]): Moved from WebBridge. Use new _lastChild pointer. (-[WebCoreBridge childCount]): Moved from WebBridge. Use _childCount variable. (-[WebCoreBridge previousSibling]): Moved from WebBridge. (-[WebCoreBridge nextSibling]): ditt (-[WebCoreBridge isDescendantOfFrame:]): ditto (-[WebCoreBridge traverseNextFrameStayWithin:]): ditto (-[WebCoreBridge appendChild:]): Moved from WebBridge, maintain count and first/last pointers. (-[WebCoreBridge removeChild:]): Moved from WebBridge, maintain count and first/last pointers.

WebKit:

Reviewed by Vicki.

  • moved frame traversal code across from bridge, also dropped the children array
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Don't release children array, that was moved down to WebCore. (-[WebBridge saveDocumentState:]):
  • many methods moved to WebCore.
  • WebView.subproj/WebFrame.m: (Frame): New convenience method to get a WebFrame * from a method that returns WebCoreBridge *. (-[WebFrame _firstChildFrame]): use Frame() (-[WebFrame _lastChildFrame]): ditto (-[WebFrame _previousSiblingFrame]): ditto (-[WebFrame _nextSiblingFrame]): ditto (-[WebFrame _traverseNextFrameStayWithin:]): ditto
3:21 PM Changeset in webkit [11867] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)

toString was defined as a method on the JS Selection object,
but it didn't return anything.

Added layout test:

  • editing/selection/toString.html
  • khtml/ecma/kjs_window.cpp: (KJS::SelectionFunc::callAsFunction):
3:06 PM Changeset in webkit [11866] by justing
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by harrison

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)

  • editing/selection/toString-expected.txt: Added.
  • editing/selection/toString.html: Added.
3:03 PM Changeset in webkit [11865] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6345
Submitted by: eseidel
Reviewed by: darin

REGRESSION: repro crash w/ invalid charset attribute on <script>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6345

  • fast/loader/invalid-charset-on-script-crashes-loader-expected.txt: Added.
  • fast/loader/invalid-charset-on-script-crashes-loader.html: Added.
  • fast/loader/resources/invalid-charset-on-script-crashes-loader.js: Added.
2:42 PM Changeset in webkit [11864] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by timo.

Since we clear all the plugin data structures in setView, we need to
clear the windowScriptObject as well. I had already done this in my
previous patch, but I didn't realize there are two windowScriptObjects
-- one for Netscape PlugIns, and one for WebKit PlugIns.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject as well.
2:34 PM Changeset in webkit [11863] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/js/test-prototypes-expected.txt: Added.
  • fast/js/test-prototypes.html: Added.
2:34 PM Changeset in webkit [11862] by andersca
  • 6 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.cpp: (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): Add "prototype" property in constructors.
2:02 PM Changeset in webkit [11861] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6345
Submitted by: eseidel
Reviewed by: darin

REGRESSION: repro crash w/ invalid charset attribute on <script>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
I also made some small spacing cleanup here.
I did *not* fix the usage in formData, as the move from KCharSet to
QTextCodec actually fixed a bug whereby if the first listed charset
in accept-charsets was invalid, we would assume latin1 instead of
checking for the next valid one before assuming system encoding.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): cleanup
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): null check (CachedScript::CachedScript): cleanup (CachedXSLStyleSheet::CachedXSLStyleSheet): null check (CachedXBLDocument::CachedXBLDocument): cleanup
1:51 PM Changeset in webkit [11860] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/frames/iframe-target-expected.txt: Added.
  • fast/frames/iframe-target.html: Added.
1:50 PM Changeset in webkit [11859] by andersca
  • 2 edits in trunk/WebKit

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebView.subproj/WebFrame.m: (-[WebFrame _descendantFrameNamed:sourceFrame:]): Return the correct frame.
4:37 AM Changeset in webkit [11858] by justing
  • 2 edits
    8 adds in trunk/LayoutTests

New/updated layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/4259818>
selection object incorrect after double-clicking a word

  • editing/selection/anchor-focus1-expected.txt: Added.
  • editing/selection/anchor-focus1.html: Added.
  • editing/selection/anchor-focus2-expected.txt: Added.
  • editing/selection/anchor-focus2.html: Added.
  • editing/selection/anchor-focus3-expected.txt: Added.
  • editing/selection/anchor-focus3.html: Added.
  • editing/selection/getRangeAt-expected.txt: Added.
  • editing/selection/getRangeAt.html: Added.
  • editing/selection/unrendered-001-expected.txt:
4:28 AM Changeset in webkit [11857] by justing
  • 7 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/4259818>
selection object incorrect after double-clicking a word

Reviewed by harrison

Changed the Selection object's anchor/focus properties to match
Mozilla's Selection object API, added getRangeAt and outlined the
rest of the API.
Cleaned up the JS Selection object (to do less work in the DOM binding).
Added an updateLayout call to VisiblePosition::init and removed some
updateLayout calls from other parts of the editing code.

Added layout tests:

  • editing/selection/getRangeAt.html
  • editing/selection/anchor-focus1.html
  • editing/selection/anchor-focus2.html
  • editing/selection/anchor-focus3.html Updated expected results:
  • editing/selection/unrendered-001-expected.txt
  • khtml/ecma/kjs_window.cpp: (KJS::Selection::getValueProperty): (KJS::Selection::toString): (KJS::SelectionFunc::callAsFunction):
  • khtml/ecma/kjs_window.h: (KJS::Selection::):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::modify): (khtml::SelectionController::type): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::setBaseAndExtent): (khtml::SelectionController::setPosition): (khtml::SelectionController::collapse): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::empty): (khtml::SelectionController::extend): (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::part): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::SelectionController::isCollapsed):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::isCandidate):
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick):
2:06 AM Changeset in webkit [11856] by andersca
  • 3 edits
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • dom/html/level2/core/createDocument08-expected.txt:
  • dom/xhtml/level2/core/createDocument08-expected.txt: These now fail.
  • fast/dom/createDocument-empty-expected.txt: Added.
  • fast/dom/createDocument-empty.html: Added.
2:05 AM Changeset in webkit [11855] by andersca
  • 3 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDOMImplementationProtoFunc::callAsFunction): When passing null to createDocument, pass a null DOMString, and not a DOMString containing the text "null".
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Only validate the qualifiedName if it's not null or empty. Also, do not create the document element if the qualifiedName is null or empty.
1:19 AM Changeset in webkit [11854] by eseidel
  • 57 edits in trunk/WebCore

Bug #: 6109
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no tests possible.

khtml/editing should use RefPtr instead of manual ref/deref
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6109

Results in a slight performance gain < 1% on the PLT.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/append_node_command.cpp: (khtml::AppendNodeCommand::AppendNodeCommand): (khtml::AppendNodeCommand::doApply): (khtml::AppendNodeCommand::doUnapply):
  • khtml/editing/append_node_command.h: (khtml::AppendNodeCommand::~AppendNodeCommand): (khtml::AppendNodeCommand::appendChild): (khtml::AppendNodeCommand::parentNode):
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::ApplyStyleCommand::removeInlineStyle):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::deleteInsignificantText):
  • khtml/editing/delete_from_text_node_command.cpp: (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
  • khtml/editing/delete_from_text_node_command.h: (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand): (khtml::DeleteFromTextNodeCommand::node):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::saveTypingStyleState): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::calculateEndingPosition): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::clearTransientState):
  • khtml/editing/delete_selection_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): (khtml::EditCommand::~EditCommand): (khtml::EditCommand::setTypingStyle): (khtml::EditCommand::styleAtPosition):
  • khtml/editing/edit_command.h: (khtml::EditCommand::document): (khtml::EditCommand::typingStyle):
  • khtml/editing/insert_into_text_node_command.cpp: (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
  • khtml/editing/insert_into_text_node_command.h: (khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand): (khtml::InsertIntoTextNodeCommand::node):
  • khtml/editing/insert_node_before_command.cpp: (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand): (khtml::InsertNodeBeforeCommand::doApply): (khtml::InsertNodeBeforeCommand::doUnapply):
  • khtml/editing/insert_node_before_command.h: (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand): (khtml::InsertNodeBeforeCommand::insertChild): (khtml::InsertNodeBeforeCommand::refChild):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
  • khtml/editing/insert_paragraph_separator_command.h:
  • khtml/editing/join_text_nodes_command.cpp: (khtml::JoinTextNodesCommand::JoinTextNodesCommand): (khtml::JoinTextNodesCommand::doApply): (khtml::JoinTextNodesCommand::doUnapply):
  • khtml/editing/join_text_nodes_command.h: (khtml::JoinTextNodesCommand::~JoinTextNodesCommand): (khtml::JoinTextNodesCommand::firstNode): (khtml::JoinTextNodesCommand::secondNode):
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp: (khtml::createMarkup): (khtml::createFragmentFromMarkup): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
  • khtml/editing/markup.h:
  • khtml/editing/merge_identical_elements_command.cpp: (khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): (khtml::MergeIdenticalElementsCommand::doApply): (khtml::MergeIdenticalElementsCommand::doUnapply):
  • khtml/editing/merge_identical_elements_command.h: (khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
  • khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::MoveSelectionCommand): (khtml::MoveSelectionCommand::~MoveSelectionCommand): (khtml::MoveSelectionCommand::doApply):
  • khtml/editing/move_selection_command.h:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/rebalance_whitespace_command.h: (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
  • khtml/editing/remove_css_property_command.cpp: (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
  • khtml/editing/remove_css_property_command.h: (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::styleDeclaration):
  • khtml/editing/remove_node_attribute_command.cpp: (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
  • khtml/editing/remove_node_attribute_command.h: (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::element):
  • khtml/editing/remove_node_command.cpp: (khtml::RemoveNodeCommand::RemoveNodeCommand): (khtml::RemoveNodeCommand::doApply): (khtml::RemoveNodeCommand::doUnapply):
  • khtml/editing/remove_node_command.h: (khtml::RemoveNodeCommand::~RemoveNodeCommand): (khtml::RemoveNodeCommand::node):
  • khtml/editing/remove_node_preserving_children_command.cpp: (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
  • khtml/editing/remove_node_preserving_children_command.h: (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::node):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::ReplacementFragment): (khtml::ReplacementFragment::~ReplacementFragment): (khtml::ReplacementFragment::enclosingBlock): (khtml::ReplacementFragment::removeNodePreservingChildren): (khtml::ReplacementFragment::removeNode): (khtml::ReplacementFragment::insertFragmentForTestRendering): (khtml::ReplacementFragment::restoreTestRenderingNodesToFragment): (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::computeAndStoreNodeDesiredStyle): (khtml::NodeDesiredStyle::NodeDesiredStyle): (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement): (khtml::ReplaceSelectionCommand::updateNodesInserted):
  • khtml/editing/replace_selection_command.h: (khtml::NodeDesiredStyle::node): (khtml::NodeDesiredStyle::style): (khtml::ReplacementFragment::root):
  • khtml/editing/set_node_attribute_command.cpp: (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
  • khtml/editing/set_node_attribute_command.h: (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::element):
  • khtml/editing/split_element_command.cpp: (khtml::SplitElementCommand::SplitElementCommand): (khtml::SplitElementCommand::doApply): (khtml::SplitElementCommand::doUnapply):
  • khtml/editing/split_element_command.h: (khtml::SplitElementCommand::~SplitElementCommand):
  • khtml/editing/split_text_node_command.cpp: (khtml::SplitTextNodeCommand::SplitTextNodeCommand): (khtml::SplitTextNodeCommand::doApply): (khtml::SplitTextNodeCommand::doUnapply):
  • khtml/editing/split_text_node_command.h: (khtml::SplitTextNodeCommand::~SplitTextNodeCommand): (khtml::SplitTextNodeCommand::node):
  • khtml/editing/split_text_node_containing_element.cpp: (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): (khtml::SplitTextNodeContainingElementCommand::doApply):
  • khtml/editing/split_text_node_containing_element_command.h: (khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: (khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): (khtml::WrapContentsInDummySpanCommand::doApply): (khtml::WrapContentsInDummySpanCommand::doUnapply):
  • khtml/editing/wrap_contents_in_dummy_span_command.h: (khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
  • kwq/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreBridge documentFragmentWithText:]): (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
12:23 AM Changeset in webkit [11853] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/dom/clone-node-form-elements-expected.txt: Added.
  • fast/dom/clone-node-form-elements.html: Added.
12:12 AM Changeset in webkit [11852] by andersca
  • 7 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Call copyNonAttributeProperties on the new node.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
  • khtml/html/html_formimpl.h: Copy m_value, m_checked and m_indeterminate here.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Call copyNonAttributeProperties on the new node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Call copyNonAttributeProperties on the new node.
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::copyNonAttributeProperties): Add function declaration.

Jan 2, 2006:

9:15 PM Changeset in webkit [11851] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Eric.

To do this, I had to invert the ownership so that WebBridge now
owns WebFrame instead of vice versa. As a result, WebView now owns
a WebBridge pointer and does not have a direct WebFrame pointer.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating the frame, so pass it what it needs to do that. (-[WebBridge dealloc]): The bridge now owns the frame, so release it. (-[WebBridge close]): ditto (-[WebBridge firstChild]): Moved from WebFrame (-[WebBridge lastChild]): ditto (-[WebBridge childCount]): ditto (-[WebBridge previousSibling]): ditto (-[WebBridge nextSibling]): ditto (-[WebBridge isDescendantOfFrame:]): ditto (-[WebBridge traverseNextFrameStayWithin:]): ditto (-[WebBridge appendChild:]): ditto (-[WebBridge removeChild:]): ditto
  • WebView.subproj/WebFrame.m: (-[WebFrame _removeChild::]): Call WebBridge version (-[WebFramePrivate dealloc]): ditto (-[WebFrame _firstChildFrame]): ditto (-[WebFrame _lastChildFrame]): ditto (-[WebFrame _childFrameCount]): ditto (-[WebFrame _previousSiblingFrame]): ditto (-[WebFrame _nextSiblingFrame]): ditto (-[WebFrame _traverseNextFrameStayWithin:]): ditto (-[WebFrame _appendChild:]): ditto (-[WebFrame _removeChild:]): ditto (-[WebFrame _isDescendantOfFrame:]): ditto, (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge pointer before the bridge is due to release us, and don't release the bridge any more since it now owns us (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer, we no longer create the bridge, instead it is passed in (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated initializer, but this method is no longer viable and should be deprecated.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: WebView was changed to hold onto the WebBridge for the main frame instead of the WebFrame.

(-[WebViewPrivate dealloc]): update for the fact that we hold
a bridge now, not a frame.
(-[WebView _close]): ditto
(-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
a bridge, not a frame.
(-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
(-[WebView setDefersCallbacks:]): get mainFrame via method
(-[WebView mainFrame]): Update to get the main frame properly

7:48 PM Changeset in webkit [11850] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Rubber stamped by Eric.

  • remove the no longer used QIntDict
  • kwq/KWQIntDict.h: Removed.
6:07 PM Changeset in webkit [11849] by ap
  • 3 edits
    5 adds in trunk

Reviewed by Eric.

Test case: fast/xsl/xslt-relative-path.xml

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs. (DOM::XSLTProcessorImpl::transformToString):
4:13 PM Changeset in webkit [11848] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)

We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
we fail to fire onmouseout events. Since the call to passSubframeEventToSubframe was originally added
to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
on passSubframeEventToSubframe.

  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):

Dec 30, 2005:

4:14 PM Changeset in webkit [11847] by darin
  • 23 edits in trunk/WebCore

Reviewed by Maciej.

Added new functions named equal and equalIgnoringCase.

  • khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a version of the hash function that works on char* to CaseInsensitiveHash as preparation for an atomic string change.
  • khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros here, and changed them into inline functions. (DOM::equal): Implemented. (DOM::equalIgnoringCase): Implemented. (DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar functions.
  • khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
  • khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.
  • khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary friend declarations. Removed AtomicString::equal. Filled out a larger set of == and != operator implementations, mostly with inlines calling through to DOMStringImpl. Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
  • khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==. Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.
  • khtml/html/html_listimpl.cpp: (DOM::HTMLOListElementImpl::parseMappedAttribute): (DOM::HTMLLIElementImpl::parseMappedAttribute): Use the "==" operator instead of strcmp.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Use equalIgnoringCase instead of equalsIgnoreCase.
  • khtml/rendering/render_form.cpp: (RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also used equalIgnoringCase instead of strcasecmp. (RenderSlider::slotSliderValueChanged): More of the same.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
(&& binds tighter than
) which fixes a crash when using a http-equiv pragma when there

is no part (not sure how to reproduce that).

  • khtml/khtml_part.cpp: (updateState): (KHTMLPart::selectionStartHasStyle):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::checkForLegacyHTMLStyleChange): (khtml::StyleChange::currentlyHasStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute):
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseMappedAttribute): (HTMLHRElementImpl::parseMappedAttribute): (HTMLParagraphElementImpl::parseMappedAttribute): (HTMLMarqueeElementImpl::parseMappedAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): (HTMLElementImpl::addHTMLAlignment): (HTMLElementImpl::setContentEditable):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): (DOM::HTMLButtonElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::setInputType): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLKeygenElementImpl::appendFormData): (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use equalIgnoringCase instead of strcasecmp.
2:17 PM Changeset in webkit [11846] by ap
  • 10 edits
    4 adds in trunk

Reviewed by Darin, landed by ap.

WebCore:

  • khtml/rendering/font.h:
  • khtml/rendering/font.cpp: (khtml::Font::selectionRectForText): Added.
  • khtml/rendering/render_text.cpp: (kthml::InlineTextBox::selectionRect): Use selectionRectForText. This works for justified text as well, and avoids intermediate rounding which resulted in selection rects narrower than AppKit's. (khtml::InlineTextBox::positionForOffset): Use selectionRectForText, which works for justified text as well.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::selectionRectForText): Added.
  • kwq/WebCoreTextRenderer.h:

WebKit:

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added. (CG_drawHighlight): Use new function CG_selectionRect. (CG_selectionRect): New function to compute the selection rect. Eliminated rounding hackery that was required for keeping the highlight rect within the selection rect computed by InlineTextBox::selectionRect, since the latter uses this function now. The new selection rect is wider and matches AppKit more closely, although the right hand side is roundf()ed instead of cielf()ed for optimal caret positioning. (ATSU_drawHighlight): Use new function ATSU_selectionRect. (ATSU_selectionRect): New function to compute the selection rect. Much like CG_selectionRect.

LayoutTests:

  • fast/text/justified-text-rect-expected.checksum: Added.
  • fast/text/justified-text-rect-expected.png: Added.
  • fast/text/justified-text-rect-expected.txt: Added.
  • fast/text/justified-text-rect.html: Added.
1:23 PM Changeset in webkit [11845] by ap
  • 2 edits in trunk/WebCore
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Only special-case (0, 0) ranges for empty documents.
1:22 PM Changeset in webkit [11844] by andersca
  • 1 edit in trunk/LayoutTests/fast/dom/dom-parse-serialize-expected.txt

Forgot to commit this

1:16 PM Changeset in webkit [11843] by eseidel
  • 2 edits in trunk/LayoutTests

Bug #: 6305
Submitted by: eseidel
Reviewed by: ggaren

Missing CSS Style sheets in one of the XHTML tests in WebCore
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6305

  • fast/parser/entities-in-xhtml.xhtml: removed <link> to css sheet
12:43 PM Changeset in webkit [11842] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

Remove conflict marker from ChangeLog

12:42 PM Changeset in webkit [11841] by ggaren
  • 3 edits
    1 add in trunk

WebCore:

Added test case for <rdar://problem/4268278> Submitting a form in onUnload event
handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]

  • manual-tests/onunload-form-submit-crash.html: Added.

WebKit:

Reviewed by Eric.

Manual testcase added:
WebCore/manual-tests/onunload-form-submit-crash.html

  • Fixed <rdar://problem/4268278> Submitting a form in onUnload event handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]

The problem is that the form submission in the unload event kicks off
a new load in the midst of the load that caused the unload event to
fire in the first place, so the two loads stomp each other.

The solution is to cancel the first load and let the unload handler's
load win. (Firefox does the same.)

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up the call stack to _continueLoadRequest. (See below.) This has the side-effect of always firing the unload event, even if the new datasource never becomes committed, which seems like a good thing.

(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
Call -closeURL here, instead of in _transitionToCommitted, so that the
unload handler can fire before we initialize any part of the load.

Check provisionalDataSource for nil to discover if the unload event
kicked off its own load.

Cleared up some coments.

(-[WebFrame _detachFromParent]):
It turns out that if you close the window instead of just navigating
to a new page, you get an alternate assertion failure/crash because
the load kicked off by the unload event handler generates resource
loader callbacks after the associated WebFrame/WebView has disappeared.

The nifty solution here is just to reverse the order of calls to
-stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
last word when you close a window.

6:53 AM Changeset in webkit [11840] by andersca
  • 6 edits in trunk/LayoutTests

2005-12-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

XMLSerializer should use createMarkup

  • fast/dom/XMLSerializer.html:
  • fast/dom/XMLSerializer-expected.txt: Create a document fragment and serialize it.
  • fast/dom/dom-parse-serialize.html:
  • fast/dom/dom-parse-serialize-expected.txt: Add some entities to attributes and text nodes.
  • fast/xsl/xslt-processer-expected.txt: Update test results.
6:51 AM Changeset in webkit [11839] by andersca
  • 3 edits in trunk/WebCore

2005-12-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):

Use createMarkup instead of NodeImpl::toString.

  • khtml/editing/markup.cpp: (khtml::startMarkup):

escape attribute values and ignore document fragment nodes.

1:57 AM Changeset in webkit [11838] by mjs
  • 2 edits in trunk/JavaScriptCore

No review, just test result update.

  • tests/mozilla/expected.html: Updated for newly passing test from recent fixes.
1:48 AM Changeset in webkit [11837] by eseidel
  • 7 edits in trunk/WebCore

Bug #: 6299
Submitted by: eseidel
Reviewed by: mjs

No functional changes, thus no layout test.

Just removes debug NSLog() calls from ksvg2/kcanvas.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6299

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): (KCanvasFilterQuartz::getCIFilterStack): (KCanvasFilterQuartz::imageForName): (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFEGaussianBlurQuartz::getCIFilter):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::mapFromVisual): (KRenderingDeviceContextQuartz::mapToVisual): (KRenderingDeviceQuartz::createResource): (KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw):
  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
1:44 AM Changeset in webkit [11836] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.cpp: (KJS::JSObject::put):

Rework the getter setter part. We now walk the prototype chain, checking for
getter/setter properties and only take the slow path if any are found.

1:27 AM Changeset in webkit [11835] by eseidel
  • 2 edits
    2 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: No review, just adding a couple missing results.

One missing pixel test.
One result which never was updated properly after rounded rect fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • fast/parser/xhtml-alternate-entities-expected.checksum: Added.
  • fast/parser/xhtml-alternate-entities-expected.png: Added.
12:51 AM Changeset in webkit [11834] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin, landed by Maciej.

  • fast/overflow/overflow-auto-table-expected.checksum: Added.
  • fast/overflow/overflow-auto-table-expected.png: Added.
  • fast/overflow/overflow-auto-table-expected.txt: Added.
  • fast/overflow/overflow-auto-table.html: Added.
12:49 AM Changeset in webkit [11833] by eseidel
  • 37 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none, just updating stale results

No review, updating stale results.
I went over all the interesting ones with mjs and hyatt.

  • css2.1/t040304-c64-uri-00-a-g-expected.checksum:
  • css2.1/t040304-c64-uri-00-a-g-expected.png:
  • css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
  • css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
  • css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.png:
  • dom/xhtml/level2/html/frame-expected.checksum:
  • dom/xhtml/level2/html/frame-expected.png:
  • dom/xhtml/level2/html/iframe-expected.checksum:
  • dom/xhtml/level2/html/iframe-expected.png:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • fast/css/imageTileOpacity-expected.checksum:
  • fast/css/imageTileOpacity-expected.png:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/frames/empty-frame-src-expected.checksum:
  • fast/frames/empty-frame-src-expected.png:
  • fast/frames/invalid-expected.checksum:
  • fast/frames/invalid-expected.png:
  • fast/frames/valid-expected.checksum:
  • fast/frames/valid-expected.png:
  • svg/custom/conditional-processing-outside-switch-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/fill-update-expected.txt:
  • svg/custom/junk-data-expected.txt:
  • svg/custom/missing-xlink-expected.txt:
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/path-update-expected.txt:
  • svg/custom/simpleCDF-expected.txt:
  • svg/custom/transform-ignore-after-invalid-expected.txt:
  • svg/custom/transform-invalid-expected.txt:
  • svg/custom/transform-with-ending-space-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
12:18 AM Changeset in webkit [11832] by mjs
  • 2 edits in trunk/LayoutTests

No review.

  • fast/js/kde/Number-expected.txt:
12:14 AM Changeset in webkit [11831] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed and committed by Maciej.

(Merged from KJS, original work by Harri Porten)

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): rewrote Number.toString(radix) to work with negative numbers, floating point and very large numbers.
Note: See TracTimeline for information about the timeline view.