⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 1, 2006:

10:24 PM Changeset in webkit [13085] by ap
  • 3 edits in trunk/WebKit

Fixed a typo in the comments added in the previous checkin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
9:58 PM Changeset in webkit [13084] by ap
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET. (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: Ditto. Also removed a stale comment about XMLHTTPRequests. (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
9:55 PM Changeset in webkit [13083] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Changed an Objective-C forward declaration from "class" to "@class".
This doesn't appear to fix any problems, though.

  • platform/StringImpl.h:
9:24 PM Changeset in webkit [13082] by justing
  • 2 edits in trunk/LayoutTests/editing/unsupported-content

harrison forgot to update these pixel results. We should probably move this test out of unsupported-content, since lists are no longer unsupported, but i'll let him do that when he gets back.

9:12 PM Changeset in webkit [13081] by justing
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • editing/resources/select-all-iframe-src.html: Added.
  • editing/selection/select-all-iframe-expected.checksum: Added.
  • editing/selection/select-all-iframe-expected.png: Added.
  • editing/selection/select-all-iframe-expected.txt: Added.
  • editing/selection/select-all-iframe.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • page/Frame.cpp: (WebCore::Frame::selectFrameElementInParentIfFullySelected):

WebKitTools:

Reviewed by darin


Give the events that eventSender sends a unique eventNumber

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):
7:33 PM Changeset in webkit [13080] by harrison
  • 3 edits in trunk/WebKit

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".


  • WebView/WebHTMLView.m: (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]):
  • WebView/WebHTMLViewPrivate.h:
7:32 PM Changeset in webkit [13079] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.
(missed these in my earlier commit for <rdar://problem/4359736>)

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
6:43 PM Changeset in webkit [13078] by eseidel
  • 1 edit
    14 adds in trunk/WebKitTools

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Add a stub win32 application to test WebCore drawing on windows.

  • Spinneret: Added.
  • Spinneret/Spinneret: Added.
  • Spinneret/Spinneret.sln: Added.
  • Spinneret/Spinneret/Resource.h: Added.
  • Spinneret/Spinneret/Spinneret.cpp: Added. (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (About):
  • Spinneret/Spinneret/Spinneret.h: Added.
  • Spinneret/Spinneret/Spinneret.ico: Added.
  • Spinneret/Spinneret/Spinneret.rc: Added.
  • Spinneret/Spinneret/Spinneret.vcproj: Added.
  • Spinneret/Spinneret/WebView.cpp: Added. (WebKit::WebView::WebViewPrivate::WebViewPrivate): (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WebView::windowHandle): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h: Added.
  • Spinneret/Spinneret/small.ico: Added.
  • Spinneret/Spinneret/stdafx.cpp: Added.
  • Spinneret/Spinneret/stdafx.h: Added.
6:17 PM Changeset in webkit [13077] by eseidel
  • 6 edits
    2 adds in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build, add IntRectWin and GraphicsContextCairo stub.

  • Viewer/ImageDocument.cpp:
  • Viewer/ImageMainFrame.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntRect.h:
  • platform/cairo/GraphicsContextCairo.cpp: Added.
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForText): (WebCore::GraphicsContext::fillRect): (WebCore::TransferJob::TransferJob): (GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
6:12 PM Changeset in webkit [13076] by harrison
  • 3 edits in trunk/LayoutTests

Updated test case after improving list deletion.

<rdar://problem/4359736> Support outlining ability with lists


  • unsupported-content/list-delete-002-expected.txt: Updated.
  • unsupported-content/list-delete-002.html: Updated.
6:05 PM Changeset in webkit [13075] by harrison
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".
Additional support is to end a list when return is typed on empty list item.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added ModifySelectionListLevelCommand.cpp and ModifySelectionListLevelCommand.h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): Supply list level calls in the bridge.


  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::createListItemElement): New. Creates an li.


(WebCore::InsertParagraphSeparatorCommand::doApply):

  • slight logic cleanup
  • on empty list item, end the list


  • editing/ModifySelectionListLevelCommand.cpp: Added. (WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand): (WebCore::ModifySelectionListLevelCommand::preservesTypingStyle): (WebCore::ModifySelectionListLevelCommand::doApply): (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeAfter): (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
  • editing/ModifySelectionListLevelCommand.h: Added. New editing command for adjusting the list level.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Slight logic cleanup
  • editing/htmlediting.cpp: (WebCore::isListElement): (WebCore::enclosingListChild): New helpers.


(WebCore::isTableElement):
Allow caller to pass 0... return false in that case.


  • editing/htmlediting.h: New helpers.


  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): Allow for list children that are not li nodes. Ignore and continue rather than stopping.


(WebCore::RenderContainer::addChild):
Allow for nil beforeChild, meaning "add at end".

6:00 PM Changeset in webkit [13074] by eseidel
  • 8 edits in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Update ESelectionGranulartiy enum to use newer CamelCase styling.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
  • editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::validate):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/jsediting.cpp:
  • editing/text_granularity.h: (WebCore::):
  • page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventSelection):
12:55 PM Changeset in webkit [13073] by lypanov
  • 7 edits in trunk

2006-03-01 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

Fixes already existing test:

svg/W3C-SVG-1.1/coords-viewattr-02-b.svg

  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGImage.h:

2006-03-01 Alexander Kellett <​lypanov@kde.org>

  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
9:56 AM Changeset in webkit [13072] by thatcher
  • 2 edits in trunk

Forgot to add the radar to my changelog entries.

9:54 AM Changeset in webkit [13071] by ap
  • 16 edits
    5 adds in trunk

Reviewed by Darin.

HEAD is currently unimplemented because of what seems to be a bug in NSURLConnection,
and does a GET instead.

WebCore:

  • kwq/KWQKJobClasses.h: Add a method parameter to TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::method):
  • bridge/mac/WebCoreFrameBridge.h: URL loading functions now take a method parameter.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • page/Frame.cpp: (WebCore::Frame::didOpenURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Honor the method passed in open().
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Don't serialize null as "null".

WebKit:

All WebKit changes are to use the method parameter passed from WebCore.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

LayoutTests:

  • http/tests/xmlhttprequest/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/methods-async.html: Added.
  • http/tests/xmlhttprequest/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/methods.cgi: Added.
  • http/tests/xmlhttprequest/methods.html: Added.
9:49 AM Changeset in webkit [13070] by thatcher
  • 17 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary

Support for WebKit. This removes the old elementAtPoint: on the bridge.
WebKit now uses the bridge method getInnerNonSharedNode:innerNode:URLElement:atPoint:

  • WebCore.exp: removes the WebCore* dictionary keys
  • bindings/objc/DOM.mm: (-[DOMElement image]): new method to get an NSImage if the element has an image renderer
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): new method that returns the title after doing the backslash as currency symbol conversion (-[DOMHTMLInputElement altDisplayString]): ditto for alt (-[DOMHTMLImageElement altDisplayString]): ditto (-[DOMHTMLAppletElement altDisplayString]): ditto (-[DOMHTMLAreaElement altDisplayString]): ditto (-[DOMHTMLAnchorElement absoluteLinkURL]): new method to get the absolute NSURL (-[DOMHTMLAreaElement absoluteLinkURL]): ditto (-[DOMHTMLLinkElement absoluteLinkURL]): ditto (-[DOMHTMLInputElement absoluteImageURL]): new method to get the absolute image location as an NSURL (-[DOMHTMLImageElement absoluteImageURL]): ditto (-[DOMHTMLObjectElement absoluteImageURL]): ditto
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:]): (-[WebCoreFrameBridge isPointInsideSelection:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::backslashAsCurrencySymbol):
  • dom/DocumentImpl.h:
  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTest):
  • rendering/render_object.h: (WebCore::RenderObject::NodeInfo::URLElement): (WebCore::RenderObject::NodeInfo::setURLElement):

WebKit:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary


elementAtPoint for WebHTMLView now returns a WebElementDictionary,
when objectForKey is called it will lookup in the DOM, cache and return the value

  • Misc/WebElementDictionary.h: Added.
  • Misc/WebElementDictionary.m: Added. (addLookupKey): (cacheValueForKey): (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary initWithInnerNonSharedNode:innerNode:URLElement:andPoint:]): (-[WebElementDictionary dealloc]): (-[WebElementDictionary _fillCache]): (-[WebElementDictionary count]): (-[WebElementDictionary keyEnumerator]): (-[WebElementDictionary objectForKey:]): (-[WebElementDictionary _domNode]): (-[WebElementDictionary _webFrame]): (-[WebElementDictionary _targetWebFrame]): (-[WebElementDictionary _title]): (-[WebElementDictionary _imageRect]): (-[WebElementDictionary _isSelected]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:
8:33 AM Changeset in webkit [13069] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/hover-subselector-expected.checksum: Added.
  • fast/css/hover-subselector-expected.png: Added.
  • fast/css/hover-subselector-expected.txt: Added.
  • fast/css/hover-subselector.html: Added.

WebCore:

Test: fast/css/hover-subselector.html

Reviewed by Hyatt.

  • css/cssstyleselector.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Pass flag to indicate sub-selector. (WebCore::CSSStyleSelector::checkOneSelector): Apply the *:hover and *:active quirks only when there are no sub-selectors.
1:12 AM Changeset in webkit [13068] by mjs
  • 3 edits in trunk/WebCore

Rubber stamped by Hyatt.

  • fix win32 build (and make dumprendertree run)
  • kwq/KWQComboBox.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::selectionEnd): (Widget::~Widget): (GraphicsContext::beginTransparencyLayer): (QComboBox::populate): (GraphicsContext::drawConvexPolygon): (QFontMetrics::selectionRectForText): (GraphicsContext::setShadow): (GraphicsContext::clearFocusRing): (GraphicsContext::drawImageInRect): (KWQFileButton::setFilename): (KWQFileButton::focusPolicy): (KWQFileButton::frameGeometry): (QSlider::focusPolicy): (WebCore::GraphicsContext::font): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (QFontMetrics::isFixedPitch): (WebCore::TransferJob::addMetaData):

Feb 28, 2006:

11:49 PM Changeset in webkit [13067] by darin
  • 106 edits
    2 copies
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

  • platform/GraphicsContext.h: Added.
  • platform/TextDirection.h: Added.
  • platform/cg/GraphicsContextCG.cpp: Added.
  • platform/mac/GraphicsContextMac.mm: Added.
  • kwq/KWQPainter.h: Removed.
  • kwq/KWQPainter.mm: Removed.
  • ForwardingHeaders/qpainter.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for moved files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for moved files.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • editing/SelectionController.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty): (KJS::drawPattern):
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight):
  • page/FrameView.h:
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintAllMarkersOfType): (WebCore::InlineTextBox::paintMarkedTextUnderline): (WebCore::InlineTextBox::offsetForPosition):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_button.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::paintObject):
  • rendering/render_button.h: (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintFocusRing): (WebCore::RenderFlow::paintOutlines): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/render_flow.h:
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderTextArea::setStyle):
  • rendering/render_form.h: (WebCore::RenderFieldset::renderName):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintScrollbars): (WebCore::RenderLayer::paint): (WebCore::setClip): (WebCore::restoreClip): (WebCore::RenderLayer::paintLayer): (WebCore::Marquee::direction):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor):
  • rendering/render_object.h: (WebCore::RenderObject::element): (WebCore::RenderObject::document): (WebCore::RenderObject::setNode): (WebCore::RenderObject::node): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::printBoxDecorations):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h: Updated to use GraphicsContext instead of QPainter.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setWritingDirection):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setWritingDirection):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::setWritingDirection):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setWritingDirection):
  • rendering/bidi.cpp: (khtml::bidiNext): (khtml::bidiFirst): Updated to use TextDirection instead of QPainter::TextDirection and EDirection.
  • kcanvas/device/KRenderingDevice.h: Added renderingDevice here to replace QPainter::renderingDevice for now.
  • khtml/ecma/kjs_html.h: Fixed comments to mention GraphicsContext.
  • khtml/html/html_imageimpl.h:
  • page/FrameView.cpp:
  • rendering/RenderBlock.cpp: Added include needed since I reduced includes elsewhere.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Changed QChar* to be const QChar*.
  • platform/FontDescription.h: Added include that was missing.
  • rendering/render_theme.cpp: Ditto.
  • platform/Image.h: Removed unnecessary forward declaration of QPainter.
  • rendering/RenderText.h: Clean up types, use const.
  • rendering/render_style.h: Removed EDirection and replaced it with TextDirection.
  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle): (WebCore::KCanvasCreator::createRectangle): (WebCore::KCanvasCreator::createEllipse): (WebCore::KCanvasCreator::createLine):
  • kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasContainerQuartz::paint): (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::pushContext): (WebCore::KRenderingDeviceQuartz::popContext): (WebCore::renderingDevice):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer):
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource):
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: (WebCore::SVGFEDiffuseLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: (SVGFESpecularLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer):
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::canvasResource):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (WebCore::SVGMarkerElementImpl::canvasResource): (WebCore::SVGMarkerElementImpl::createRenderer):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (WebCore::SVGMaskElementImpl::drawMaskerContent): (WebCore::SVGMaskElementImpl::createRenderer): (WebCore::SVGMaskElementImpl::canvasResource):
  • ksvg2/svg/SVGPathElementImpl.cpp: (WebCore::SVGPathElementImpl::toPathData):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (WebCore::SVGPatternElementImpl::drawPatternContentIntoTile): (WebCore::SVGPatternElementImpl::createRenderer): (WebCore::SVGPatternElementImpl::canvasResource):
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData):
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::createRenderer):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (WebCore::SVGStyledElementImpl::createRenderer):
  • ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): Updated to use renderingDevice instead of QPainter::renderingDevice.
11:19 PM Changeset in webkit [13066] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Fixed <rdar://problem/4448098> Switch PropertyMap deleted entry placeholder to -1 from UString::Rep::null

This turned out to be only a small speedup (.12%). That's within the
margin of error for super accurate JS iBench, but Shark confirms the
same, so I think it's worth landing.

FYI, I also confirmed that the single entry optimization in
PropertyMap is a 3.2% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::deletedSentinel):
10:37 PM Changeset in webkit [13065] by darin
  • 2 edits in trunk/WebCore
  • fixed part of the reason the build is broken
  • WebCore.xcodeproj/project.pbxproj: Updated project file.
10:23 PM Changeset in webkit [13064] by darin
  • 2 edits
    37 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved the WebCoreXXX files from kwq to appropriate directories

No changes to the contents of the files.

  • WebCore.xcodeproj/project.pbxproj: Updated project file.
  • bridge/mac/WebCoreCache.h: Added.
  • bridge/mac/WebCoreCache.mm: Added.
  • bridge/mac/WebCoreEncodings.h: Added.
  • bridge/mac/WebCoreEncodings.mm: Added.
  • bridge/mac/WebCoreFrameNamespaces.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m: Added.
  • bridge/mac/WebCoreFrameView.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Added.
  • bridge/mac/WebCoreJavaScript.mm: Added.
  • bridge/mac/WebCoreKeyboardAccess.h: Added.
  • bridge/mac/WebCoreResourceLoader.h: Added.
  • bridge/mac/WebCoreScriptDebugger.h: Added.
  • bridge/mac/WebCoreScriptDebugger.mm: Added.
  • bridge/mac/WebCoreSettings.h: Added.
  • bridge/mac/WebCoreSettings.mm: Added.
  • bridge/mac/WebCoreTextDecoder.h: Added.
  • bridge/mac/WebCoreTextDecoder.mm: Added.
  • bridge/mac/WebCoreViewFactory.h: Added.
  • bridge/mac/WebCoreViewFactory.m: Added.
  • bridge/mac/WebDashboardRegion.h: Added.
  • bridge/mac/WebDashboardRegion.m: Added.
  • kwq/WebCoreCache.h: Removed.
  • kwq/WebCoreCache.mm: Removed.
  • kwq/WebCoreCookieAdapter.h: Removed.
  • kwq/WebCoreCookieAdapter.m: Removed.
  • kwq/WebCoreEncodings.h: Removed.
  • kwq/WebCoreEncodings.mm: Removed.
  • kwq/WebCoreFrameNamespaces.h: Removed.
  • kwq/WebCoreFrameNamespaces.m: Removed.
  • kwq/WebCoreFrameView.h: Removed.
  • kwq/WebCoreGraphicsBridge.h: Removed.
  • kwq/WebCoreGraphicsBridge.m: Removed.
  • kwq/WebCoreHistory.h: Removed.
  • kwq/WebCoreHistory.m: Removed.
  • kwq/WebCoreImageRenderer.h: Removed.
  • kwq/WebCoreImageRendererFactory.h: Removed.
  • kwq/WebCoreImageRendererFactory.m: Removed.
  • kwq/WebCoreJavaScript.h: Removed.
  • kwq/WebCoreJavaScript.mm: Removed.
  • kwq/WebCoreKeyGenerator.h: Removed.
  • kwq/WebCoreKeyGenerator.m: Removed.
  • kwq/WebCoreKeyboardAccess.h: Removed.
  • kwq/WebCoreResourceLoader.h: Removed.
  • kwq/WebCoreScriptDebugger.h: Removed.
  • kwq/WebCoreScriptDebugger.mm: Removed.
  • kwq/WebCoreSettings.h: Removed.
  • kwq/WebCoreSettings.mm: Removed.
  • kwq/WebCoreTextDecoder.h: Removed.
  • kwq/WebCoreTextDecoder.mm: Removed.
  • kwq/WebCoreTextRenderer.h: Removed.
  • kwq/WebCoreTextRendererFactory.h: Removed.
  • kwq/WebCoreTextRendererFactory.mm: Removed.
  • kwq/WebCoreView.h: Removed.
  • kwq/WebCoreView.m: Removed.
  • kwq/WebCoreViewFactory.h: Removed.
  • kwq/WebCoreViewFactory.m: Removed.
  • kwq/WebDashboardRegion.h: Removed.
  • kwq/WebDashboardRegion.m: Removed.
  • platform/mac/WebCoreCookieAdapter.h: Added.
  • platform/mac/WebCoreCookieAdapter.m: Added.
  • platform/mac/WebCoreGraphicsBridge.h: Added.
  • platform/mac/WebCoreGraphicsBridge.m: Added.
  • platform/mac/WebCoreHistory.h: Added.
  • platform/mac/WebCoreHistory.m: Added.
  • platform/mac/WebCoreImageRenderer.h: Added.
  • platform/mac/WebCoreImageRendererFactory.h: Added.
  • platform/mac/WebCoreImageRendererFactory.m: Added.
  • platform/mac/WebCoreKeyGenerator.h: Added.
  • platform/mac/WebCoreKeyGenerator.m: Added.
  • platform/mac/WebCoreTextRenderer.h: Added.
  • platform/mac/WebCoreTextRendererFactory.h: Added.
  • platform/mac/WebCoreTextRendererFactory.mm: Added.
  • platform/mac/WebCoreView.h: Added.
  • platform/mac/WebCoreView.m: Added.
10:16 PM Changeset in webkit [13063] by hyatt
  • 46 edits
    3 deletes in trunk/WebCore

Fold QFont into Font and eliminate QFont completely.

Reviewed by eric

  • ForwardingHeaders/qfont.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setFont):
  • kwq/KWQFont.h: Removed.
  • kwq/KWQFont.mm: Removed.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetricsPrivate::~QFontMetricsPrivate): (QFontMetricsPrivate::getRenderer): (QFontMetricsPrivate::fontDescription): (QFontMetricsPrivate::setFontDescription): (QFontMetricsPrivate::getWebCoreFont): (QFontMetricsPrivate::isFixedPitch): (QFontMetricsPrivate::determinePitch): (QFontMetrics::QFontMetrics): (QFontMetrics::setFontDescription): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::selectionRectForText): (QFontMetrics::checkSelectionPoint): (QFontMetrics::getWebCoreFont): (QFontMetrics::isFixedPitch):
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (-[NSSearchField _addStringToRecentSearches:]): (QLineEdit::setFont):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): (QListBox::setFont): (-[KWQTableView drawRow:clipRect:]):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::font): (WebCore::QPainter::setFont): (WebCore::QPainter::fontMetrics): (WebCore::QPainter::_updateRenderer): (WebCore::QPainter::drawText): (WebCore::QPainter::drawHighlightForText):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::setFont):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setFont):
  • platform/Font.cpp: (khtml::Font::update):
  • platform/Font.h: (WebCore::): (WebCore::Font::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::operator!=): (WebCore::Font::fontMetrics): (WebCore::Font::pixelSize): (WebCore::Font::size): (WebCore::Font::letterSpacing): (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::isPrinterFont): (WebCore::Font::firstFamily): (WebCore::Font::family): (WebCore::Font::italic): (WebCore::Font::weight): (WebCore::Font::getNSFamily): (WebCore::Font::getNSFont): (WebCore::Font::getWebCoreFont):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription):
  • platform/FontFamily.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::font): (WebCore::Widget::setFont):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::font): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::findNextLineBreak):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::fontSize): (khtml::RenderStyle::fontMetrics): (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
9:31 PM Changeset in webkit [13062] by darin
  • 9 edits
    2 deletes in trunk

WebCore:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebCore.exp: Remove WebCoreScrollView class name.
  • kwq/WebCoreScrollView.h: Removed.
  • kwq/WebCoreScrollView.m: Removed.
  • WebCore.xcodeproj/project.pbxproj: Remove WebCoreScrollView source files.
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView autoforwardsScrollWheelEvents]): Added.
  • kwq/KWQTextArea.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView autoforwardsScrollWheelEvents]): Ditto.

WebKit:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebView/WebDynamicScrollBarsView.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView autoforwardsScrollWheelEvents]): Added.
6:54 PM Changeset in webkit [13061] by justing
  • 1 edit in trunk/LayoutTests/editing/editing.js

Forgot to check in my changes to editing.js

5:14 PM Changeset in webkit [13060] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): add ability to dump render tree and read from a local file.
5:14 PM Changeset in webkit [13059] by eseidel
  • 6 edits in trunk/WebCore

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix spacing/style on several of the stubs.
Reorganize stubs, separating empty stubs.
Remove the abort from certain stubs blocking DRT.
Add a virtual setView call to Frame baseclass.

  • bridge/mac/MacFrame.h: mark setView virtual
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): remove no-renderer hack
  • page/Frame.cpp: (WebCore::Frame::view): fix spacing (WebCore::Frame::setView): added.
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (notImplemented): make break directly into debugger. Moved, modified several other stubs not mentioned here.
1:00 PM Changeset in webkit [13058] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by mjs


Tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/editing.js:
  • editing/execCommand/insertHTML-expected.checksum: Added.
  • editing/execCommand/insertHTML-expected.png: Added.
  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html: Added.

WebCore:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/jsediting.cpp:
11:22 AM Changeset in webkit [13057] by mjs
  • 12 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.h: Added.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Initialize browser extension and settings.
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): Don't create renderers for now.
  • dom/EventNames.cpp: (WebCore::EventNames::init): use placement new even when not avoiding static constructors.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): ditto
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): ditto
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): Added default constructor but only in ifdef.
  • page/Frame.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init): use placement new even when not avoiding static constructors
  • platform/StaticConstructors.h: don't initialize when not avoiding static constructors, just default construct and let initialization happen normally
  • platform/win/TemporaryLinkStubs.cpp: Stub out some more things (Cursor::~Cursor): (QFont::~QFont): (QFontMetrics::~QFontMetrics): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::BrowserExtensionWin::getHistoryLength): (WebCore::BrowserExtensionWin::canRunModal): (WebCore::BrowserExtensionWin::openURLNotify): (WebCore::BrowserExtensionWin::canRunModalNow): (WebCore::BrowserExtensionWin::runModal): (WebCore::BrowserExtensionWin::goBackOrForward):
10:57 AM Changeset in webkit [13056] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Removed WKMouseIsDown()
  • libWebKitSystemInterface.a: ditto
10:48 AM Changeset in webkit [13055] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel


Wean WebKit from one more SPI call. We learned about this new-to-Tiger
API from filing Radar 4433222.

  • WebView/WebHTMLView.m: (-[WebHTMLView _autoscroll]): use public CGEventSourceButtonState() instead of WKMouseIsDown() (which was using SPI internally)
12:30 AM Changeset in webkit [13054] by eseidel
  • 121 edits in trunk

Fix line endings in two files, and apply svn:eol-style=native to all source files w/o it.

12:02 AM Changeset in webkit [13053] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove abort() from constructors to allow DRT to run.

  • platform/win/TemporaryLinkStubs.cpp: (QFont::QFont): (QFontMetrics::QFontMetrics):

Feb 27, 2006:

11:56 PM Changeset in webkit [13052] by eseidel
  • 1 edit in trunk/WebKitLibraries

Add svn:ignore property to ignore zip files

11:52 PM Changeset in webkit [13051] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped

  • fast/forms/textarea-hard-linewrap-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap.html: Added.
  • fast/forms/textarea-setvalue-submit-expected.txt: Added.
  • fast/forms/textarea-setvalue-submit.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped


Canonicalize line endings in textareas to avoid the workarounds that were a source of bugs,
Also call textWithHardLineWraps inside appendFormData (and nowhere else) if wrap="hard".

  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (WebCore::HTMLTextAreaElementImpl::select): (WebCore::HTMLTextAreaElementImpl::appendFormData): (WebCore::HTMLTextAreaElementImpl::rendererWillBeDestroyed): (WebCore::HTMLTextAreaElementImpl::updateValue): (WebCore::HTMLTextAreaElementImpl::value): (WebCore::HTMLTextAreaElementImpl::setValue): (WebCore::HTMLTextAreaElementImpl::defaultValue):
  • khtml/html/HTMLTextAreaElementImpl.h: (DOM::HTMLTextAreaElementImpl::invalidateValue):
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView text]): (-[KWQTextAreaTextView textWithHardLineBreaks]): (-[KWQTextAreaTextView setSelectedRange:]): (-[KWQTextAreaTextView selectedRange]): (-[KWQTextAreaTextView getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextAreaTextView textView:shouldChangeTextInRange:replacementString:]):
  • rendering/render_form.cpp: (WebCore::RenderTextArea::destroy): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks):
  • rendering/render_form.h:
11:06 PM Changeset in webkit [13050] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

  • Scripts/install-win-extras: fix dll permissions & download zlib too.
11:05 PM Changeset in webkit [13049] by eseidel
  • 5 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Copy missing dlls to build directory.

  • Viewer.cpp: fix line endings
  • Viewer/ImageView.cpp: fix line endings
  • Viewer/stdafx.cpp: fix line endings
  • WebCore.vcproj/WebCore/build-generated-files.sh:
10:39 PM Changeset in webkit [13048] by darin
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/css-selectorText-expected.checksum: Updated.
  • fast/dom/css-selectorText-expected.png: Updated.
  • fast/dom/css-selectorText-expected.txt: Updated.
  • fast/dom/css-selectorText.html: Added a case with multiple subselectors.

WebCore:

Test: added to fast/dom/css-selectorText.html

Reviewed by Darin.

  • css/css_base.cpp: (CSSSelector::selectorText): Iterate over subselectors
10:27 PM Changeset in webkit [13047] by darin
  • 1 edit in trunk/LayoutTests/editing/inserting/editing-empty-divs-expected.txt

Oops, this was in change log, but not committed.

10:17 PM Changeset in webkit [13046] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • write a portable ICU version of TextEncoding::fromUnicode for use on win32
  • platform/StreamingTextDecoder.h:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): added (WebCore::getConverter): helper (WebCore::cacheConverter): ditto (WebCore::effectiveEncoding): ditto
  • platform/mac/TextEncodingMac.cpp: Add comment
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode): remove
9:55 PM Changeset in webkit [13045] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • fast/text/in-rendered-text-rtl-expected.png: Added.
  • fast/text/in-rendered-text-rtl-expected.txt: Added.
  • fast/text/in-rendered-text-rtl.html: Added.

WebCore:

Test: fast/text/in-rendered-text-rtl.html

Reviewed by Darin.

  • dom/dom_position.cpp: (WebCore::Position::inRenderedText): If the RenderText contains reversed text, the text boxes are not necessarily ordered by start position, so iterate through all of them. (WebCore::Position::isRenderedCharacter): Ditto.
9:44 PM Changeset in webkit [13044] by darin
  • 3 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

The head-check.html document uses an iframe as a laboratory for loading each
head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
Live DOM Viewer: ​http://software.hixie.ch/utilities/js/live-dom-viewer/

Each of the four head-check-N.html files tests a different code path for
creating a document's head element in WebCore/khtml/html/htmlparser.cpp.

  • editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child index for <body> since the document previously had two <head> nodes.
  • fast/dom/HTMLHeadElement: Added.
  • fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
  • fast/dom/HTMLHeadElement/head-check.html: Added.
  • fast/dom/HTMLHeadElement/resources: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check.js: Added.

WebCore:

Reviewed by Darin.

  • khtml/html/htmlparser.cpp: Handle the head node like form and map nodes. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::headCreateErrorCheck):
9:38 PM Changeset in webkit [13043] by eseidel
  • 3 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add stub to make DRT link.
Make WebCore copy libxml.dll into build directory when building.

  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode):
9:03 PM Changeset in webkit [13042] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix regression in layout tests
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength): Fix some code that was not properly truncating. I broke it in my string change this morning.
9:02 PM Changeset in webkit [13041] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Remove fpconst.cpp, unused on win32 and the cause of linker warnings.

8:55 PM Changeset in webkit [13040] by mjs
  • 3 edits in trunk/WebCore

Rubber stamped by Eric.

  • add stubs for FrameWin overrides of pure virtual Frame methods
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::unfocusWindow): (WebCore::FrameWin::locationbarVisible): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::issueRedoCommand): (WebCore::FrameWin::canRedo): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::canUndo): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::print): (WebCore::FrameWin::issueCutCommand): (WebCore::FrameWin::issueCopyCommand): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::issueUndoCommand): (WebCore::FrameWin::clearRecordedFormValues): (WebCore::FrameWin::issuePasteCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::menubarVisible): (WebCore::FrameWin::personalbarVisible): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::statusbarVisible): (WebCore::FrameWin::toolbarVisible): (WebCore::FrameWin::issueTransposeCommand): (WebCore::FrameWin::userAgent): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::canGoBackOrForward): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::generateFrameName):
8:27 PM Changeset in webkit [13039] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add constructor and destructor.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
8:23 PM Changeset in webkit [13038] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric (sorta).

  • add return values where needed
  • platform/win/TemporaryLinkStubs.cpp: (KWQServeRequest): (KWQServeSynchronousRequest):
8:13 PM Changeset in webkit [13037] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix Assertions.cpp to compile on win32.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kxmlcore/Assertions.cpp:
8:12 PM Changeset in webkit [13036] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add a couple more stubs to make Win32 link.

  • platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): (WebCore::FrameView::topLevelWidget):
7:56 PM Changeset in webkit [13035] by eseidel
  • 6 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Move mac-specific logging logic up into WebCore (from JavaScriptCore).
Remove KWQ prefixes from default log channels.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • bridge/mac/WebCorePageBridge.mm: (initializeLogChannel): (initializeLoggingChannelsIfNecessary): (-[WebCorePageBridge init]):
  • page/Frame.h:
  • platform/Logging.cpp:
  • platform/Logging.h:
7:51 PM Changeset in webkit [13034] by eseidel
  • 3 edits
    1 move in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Made Assertions.cpp platform independent.
Moved mac-specific logging logic up into WebCore.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kxmlcore/Assertions.cpp: Added.
  • kxmlcore/Assertions.h:
  • kxmlcore/Assertions.mm: Removed.
7:41 PM Changeset in webkit [13033] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4104575> hang due to slow saveDocumentState method
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Change code that iterates a QStringList with indices to use iterator instead.
7:38 PM Changeset in webkit [13032] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • portable version of QString::utf8
  • platform/QString.cpp: (QString::utf8): moved here, rewritten to use TextCodec
  • platform/mac/QStringMac.mm: (QString::utf8): removed from here
6:53 PM Changeset in webkit [13031] by eseidel
  • 3 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Fix FrameWin.h to use consistant line endings.
Fix TemporaryLinkStubs to better match style guidelines.

  • bridge/win/FrameWin.h: (WebCore::Win):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (Widget::mapFromGlobal): (QPainter::addClip): (QLineEdit::cursorPosition): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (QPainter::drawFocusRing): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (QComboBox::clear): (QPainter::misspellingLineThickness): (QComboBox::setFrameGeometry): (QLineEdit::maxLength): (Widget::isEnabled): (KWQServeRequest): (QTextEdit::setText): (Widget::paint): (QPainter::addRoundedRectClip): (FrameView::viewportToGlobal): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (QPainter::drawEllipse): (QTextEdit::setReadOnly): (QListBox::appendItem): (QLineEdit::setPlaceholderString): (Cursor::Cursor): (Widget::focusPolicy): (ScrollView::removeChild): (QTextEdit::selectAll): (QPainter::fillRect): (QPainter::endTransparencyLayer): (QFont::QFont): (ScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (Widget::~Widget): (QPainter::xForm): (QListBox::sizeForNumberOfLines): (ScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (FrameView::updateBorder): (QLineEdit::hasSelectedText): (QScrollBar::QScrollBar): (QListBox::doneAppendingItems): (QTextEdit::QTextEdit): (ScrollView::inWindow): (QScrollBar::setValue): (QFont::setFirstFamily): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (ScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (QTextEdit::setLineHeight): (QScrollBar::setKnobProportion): (KWQFileButton::KWQFileButton): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (QPainter::beginTransparencyLayer): (QFontMetrics::setFont): (QComboBox::setFont): (Widget::frameGeometry): (QListBox::setSelected): (QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (QPainter::restore): (QFontMetrics::width): (Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (ScrollView::setStaticBackground): (QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (QPainter::drawText): (QPainter::pen): (KJavaAppletWidget::KJavaAppletWidget): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (Widget::setIsSelected): (QLineEdit::text): (Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (QPainter::paintingDisabled): (QComboBox::QComboBox): (QPainter::drawConvexPolygon): (Widget::setFont): (QSlider::setMaxValue): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QTextEdit::setSelectionRange): (ScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (ScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (Widget::setCursor): (QLineEdit::setAutoSaveName): (QComboBox::baselinePosition): (QComboBox::appendItem): (QPainter::setShadow): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (QSlider::QSlider): (ScrollView::setVScrollBarMode): (QPainter::drawScaledAndTiledImage): (ScrollView::scrollYOffset): (QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (ScrollView::setScrollBarsMode): (QComboBox::sizeHint): (QPainter::drawRect): (QFont::setPixelSize): (Widget::setFrameGeometry): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (QFont::operator==): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (QPainter::setFont): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (QPainter::drawLineForMisspelling): (QLineEdit::setText): (QSlider::value): (QListBox::setSelectionMode): (KWQFileButton::setFilename): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (ScrollView::updateContents): (QFontMetrics::floatWidth): (ScrollView::setHScrollBarMode): (KWQFileButton::focusPolicy): (QListBox::setFont): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (KWQFileButton::setFrameGeometry): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (QTextEdit::setFont): (QLineEdit::setFont): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QSlider::setFont): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar): (Path::operator=): (QLineEdit::setColors): (QTextEdit::setColors): (searchableIndexIntroduction): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookie): (WebCore::screenRect): (WebCore::Widget::clearFocus): (WebCore::historyContains): (KWQFindNextSentenceFromIndex): (KWQFindSentenceBoundary): (KWQFindNextWordFromIndex): (KWQFindWordBoundary): (submitButtonDefaultLabel): (inputElementAltText): (resetButtonDefaultLabel): (KWQKCookieJar::cookieEnabled): (WebCore::Widget::setFocus): (WebCore::QPainter::fillRect): (WebCore::QPainter::~QPainter): (WebCore::ScrollView::viewportToContents): (WebCore::TransferJob::kill): (WebCore::TransferJob::addMetaData): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::error): (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::TransferJob::TransferJob): (WebCore::Widget::hide): (KLocale::language): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::screenDepth): (QFont::italic): (QFontMetrics::operator=): (QFontMetrics::xHeight): (WebCore::usableScreenRect): (QFont::operator=): (Widget::setActiveWindow): (KWQCheckIfReloading): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (KWQCheckCacheObjectStatus):
5:17 PM Changeset in webkit [13030] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/4222043> Safari should reduce null events sent to invisible plugins

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Check to see if the plugin view is completely obscured (scrolled out of view, for example). If it is obscured and it wasn't before, or the other way around, then restart the null event timer so it can fire at the appropriate rate. (-[WebBaseNetscapePluginView viewHasMoved:]): If a plugin is obscured, send it null events as if it were in an inactive window.
5:00 PM Changeset in webkit [13029] by eseidel
  • 14 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Fix xcode project after previous KWQLogging move.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Logging.h:
4:41 PM Changeset in webkit [13028] by justing
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by darin


Test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

  • fast/events/onclick-list-marker-expected.txt: Added.
  • fast/events/onclick-list-marker.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker


Consider the case of outside list markers in nodeAtPoint. Had to pull
the code out of RenderListMarker::paint that computed the position/size
of the list marker.

Added:

  • fast/events/onclick-list-marker.html
  • rendering/render_list.cpp: (RenderListItem::nodeAtPoint): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::nodeAtPoint): (RenderListMarker::getRelativeMarkerRect):
  • rendering/render_list.h:
  • rendering/render_object.h:
4:19 PM Changeset in webkit [13027] by eseidel
  • 15 edits
    2 moves in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Move KWQLogging to platform and rename as Logging.*, fix headers.
This will break the mac build, which I will fix on my next commit.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • dom/DocumentImpl.cpp:
  • dom/dom_position.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/markup.cpp:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQLogging.h: Removed.
  • kwq/KWQLogging.m: Removed.
  • kwq/KWQRegExp.cpp:
  • kwq/KWQTextStream.cpp:
  • platform/Logging.cpp: Added.
  • platform/Logging.h: Added.
  • platform/QString.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::vScrollBarMode): (WebCore::theme):
4:05 PM Changeset in webkit [13026] by eseidel
  • 7 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix a bunch more link errors in the win32 build, mostly by adding stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
  • WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
  • platform/PlugInInfoStore.h:
  • platform/mac/PlugInInfoStoreMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs. (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::Widget::hide): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (QFont::QFont): (QFont::~QFont): (QFont::italic): (QFont::weight): (QFontMetrics::QFontMetrics): (QFontMetrics::~QFontMetrics): (QFontMetrics::xHeight): (Widget::setActiveWindow): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode):
3:47 PM Changeset in webkit [13025] by thatcher
  • 6 copies in tags/Safari-521.8

New tag.

3:43 PM Changeset in webkit [13024] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning

3:23 PM Changeset in webkit [13023] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Add missing include to fix build.

  • platform/win/TemporaryLinkStubs.cpp:
3:08 PM Changeset in webkit [13022] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

2006-02-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.


Test new PlugInInfoStore class (used to be KConfig).


  • plugins/plugin-javascript-access-expected.txt: Added.
  • plugins/plugin-javascript-access.html: Added.
3:08 PM Changeset in webkit [13021] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test new KConfig -> PlugInInfoStore change.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

  • DumpRenderTree/DumpRenderTree.m: (main): load test netscape plugin
  • Scripts/run-webkit-tests: style update
3:07 PM Changeset in webkit [13020] by eseidel
  • 4 edits
    2 moves
    1 delete in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Move KConfig to platform/PlugInInfoStore and add test.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

Test: plugins/plugin-javascript-access.html

  • ForwardingHeaders/kconfig.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: Removed.
  • kwq/KWQKConfigBase.mm: Removed.
  • platform/PlugInInfoStore.h: Added.
  • platform/mac/PlugInInfoStoreMac.mm: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::refreshPlugins):
2:43 PM Changeset in webkit [13019] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
2:42 PM Changeset in webkit [13018] by thatcher
  • 1 edit in trunk/WebCore/platform/mac/CursorMac.mm

Build fix for i386. Workaround for 4213314

1:55 PM Changeset in webkit [13017] by darin
  • 3 edits in trunk/JavaScriptCore
  • fixed Mac Debug build, there was an unused parameter
  • kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread): Remove parameter name.
  • kjs/debugger.h: Fixed comment.
1:40 PM Changeset in webkit [13016] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

  • kxmlcore/Vector.h: (KXMLCore::deleteAllValues): fix unused variable warning
1:36 PM Changeset in webkit [13015] by mjs
  • 44 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (jsAllocate): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bindings/c/c_class.h: (KJS::Bindings::CClass::constructorAt):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_objc.mm: (-[NSObject KJS::Bindings::]):
  • bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
  • bindings/objc/objc_class.h: (KJS::Bindings::ObjcClass::constructorAt):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fallbackObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::getOwnPropertySlot): (ObjcFallbackObjectImp::put): (ObjcFallbackObjectImp::canPut): (ObjcFallbackObjectImp::deleteProperty): (ObjcFallbackObjectImp::toBoolean):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createLanguageInstanceForValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField):
  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter): (RuntimeArray::put): (RuntimeArray::deleteProperty):
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::execute):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):
  • bindings/runtime_root.cpp: (performJavaScriptAccess):
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (ArrayInstance::getOwnPropertySlot): (ArrayPrototype::ArrayPrototype): (ArrayPrototype::getOwnPropertySlot):
  • kjs/bool_object.cpp: (BooleanObjectImp::BooleanObjectImp):
  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::DateObjectFuncImp): (KJS::DateObjectFuncImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorObjectImp::ErrorObjectImp): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::put):
  • kjs/function_object.cpp: (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
  • kjs/lexer.cpp: (Lexer::makeIdentifier): (Lexer::makeUString):
  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter):
  • kjs/nodes.cpp: (StatementNode::processFuncDecl): (PropertyNode::evaluate): (PropertyNameNode::evaluate):
  • kjs/number_object.cpp: (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getOwnPropertySlot):
  • kjs/object.cpp: (KJS::JSObject::defineGetter): (KJS::JSObject::defineSetter): (KJS::JSObject::hasInstance): (KJS::JSObject::propertyIsEnumerable):
  • kjs/object_object.cpp: (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): (KJS::PropertySlot::functionGetter):
  • kjs/reference.cpp: (KJS::Reference::getPropertyName):
  • kjs/reference_list.cpp: (ReferenceListIterator::operator++):
  • kjs/regexp_object.cpp: (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter): (StringPrototype::StringPrototype):
  • kxmlcore/Assertions.mm:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_PageHeap::CheckList):
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::checkValidity): (KXMLCore::IdentityHashTranslator::translate):
  • pcre/pcre_get.c: (pcre_get_stringnumber):
1:31 PM Changeset in webkit [13014] by eseidel
  • 6 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Reworked KConfig and plugin architecture to be much more sane.
This is part one. Once this lands, I'll move it under platform with a better name.

Darin had several great suggested further improvements as part of:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
I'll make some of those when I move this to platform.

No layout test possible (no way to control which plugins DRT sees).

  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: (WebCore::PluginInfoStore::PluginInfoStore):
  • kwq/KWQKConfigBase.mm: (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PluginInfoStore::pluginCount): (WebCore::refreshPlugins):
1:01 PM Changeset in webkit [13013] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Build fix: cast to unsigned from size_t.

  • platform/StreamingTextDecoder.cpp:
12:17 PM Changeset in webkit [13012] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
12:11 PM Changeset in webkit [13011] by mjs
  • 2 edits in trunk/WebCore
  • use proper header for std::min.
  • platform/StreamingTextDecoder.cpp:
11:30 AM Changeset in webkit [13010] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convertUTF16):
  • platform/TextEncoding.cpp:
9:58 AM Changeset in webkit [13009] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.
9:23 AM Changeset in webkit [13008] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling back to that; apologies for the churn.
9:06 AM Changeset in webkit [13007] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.
9:00 AM Changeset in webkit [13006] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.
8:55 AM Changeset in webkit [13005] by darin
  • 16 edits in trunk/WebCore

Reviewed by Maciej.

  • css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than manipulating the characters directly inside a StringImpl buffer.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse it rather than going out of our way to hack StringImpl to not copy the data. It would be better not to copy, but this is one-time work.
  • dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
  • dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): (WebCore::QCharBufferTranslator::equal): (WebCore::AtomicString::add):
  • platform/StringImpl.h: (WebCore::StringImpl::unicode): Added. (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::getCharacterBreakIterator): (WebCore::RenderText::RenderText): (WebCore::RenderText::atLineWrap): (WebCore::RenderText::allAscii): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::width): (WebCore::RenderText::selectionRect): (WebCore::RenderText::caretMaxOffset):
  • rendering/RenderTextFragment.cpp: (khtml::RenderTextFragment::RenderTextFragment): (khtml::RenderTextFragment::originalString): Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Use const. (WebCore::endOfParagraph): Ditto.
2:49 AM Changeset in webkit [13004] by mjs
  • 2 edits in trunk/WebCore
  • fix problem with a prototype that broke win32 build
  • platform/StreamingTextDecoder.h: (WebCore::StreamingTextDecoder::convert):
2:02 AM Changeset in webkit [13003] by mjs
  • 2 edits in trunk/WebCore
  • fix debug build (broken by my last commit)
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::StreamingTextDecoder::convertUsingICU):
1:17 AM Changeset in webkit [13002] by mjs
  • 27 edits
    3 copies
    8 moves
    2 adds
    1 delete in trunk/WebCore

Reviewed by Darin.


I renamed QTextCodec to TextEncoding and QTextDecoder to
StreamingTextDecoder. I also made a bunch of other changes to make
the API more sensible.


  • ForwardingHeaders/qtextcodec.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge textEncoding]): (+[WebCoreFrameBridge stringWithData:textEncoding:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::completeURL):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/html/FormDataList.cpp: (DOM::FormDataList::FormDataList): (DOM::FormDataList::appendString):
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::formData):
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::encodingName): (Decoder::decode):
  • khtml/misc/decoder.h: (khtml::Decoder::): (khtml::Decoder::visuallyOrdered): (khtml::Decoder::encoding):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQCharsets.cpp: Removed.
  • kwq/KWQCharsets.h: Removed.
  • kwq/KWQTextCodec.cpp: Removed.
  • kwq/KWQTextCodec.h: Removed.
  • kwq/WebCoreTextDecoder.h:
  • kwq/WebCoreTextDecoder.mm:
  • kwq/can-convert.mm: Removed.
  • kwq/character-sets.txt: Removed.
  • kwq/mac-encodings.txt: Removed.
  • kwq/make-charset-table.pl: Removed.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setCharset): (WebCore::CachedScript::data):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setCharset):
  • page/Frame.cpp: (WebCore::Frame::write): (WebCore::Frame::gotoAnchor): (WebCore::Frame::encoding): (WebCore::Frame::backslashAsCurrencySymbol):
  • platform/CharsetNames.cpp: Added. (KXMLCore::): (WebCore::EncodingHash::equal): (WebCore::EncodingHash::hash): (WebCore::buildDictionaries): (WebCore::textEncodingIDFromCharsetName): (WebCore::charsetNameFromTextEncodingID):
  • platform/CharsetNames.h: Added.
  • platform/KURL.cpp: (KURL::KURL): (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h:
  • platform/QString.cpp: (QString::fromUtf8):
  • platform/StreamingTextDecoder.cpp: Added. (WebCore::StreamingTextDecoder::StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertLatin1): (WebCore::StreamingTextDecoder::~StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertUTF16): (WebCore::effectiveEncoding): (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::unwanted): (WebCore::StreamingTextDecoder::appendOmittingUnwanted): (WebCore::StreamingTextDecoder::convertUsingICU): (WebCore::StreamingTextDecoder::convert): (WebCore::StreamingTextDecoder::toUnicode):
  • platform/StreamingTextDecoder.h: Added. (WebCore::StreamingTextDecoder::convert):
  • platform/TextEncoding.cpp: Added. (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::name): (WebCore::effectiveEncoding): (WebCore::TextEncoding::backslashAsCurrencySymbol): (WebCore::TextEncoding::toUnicode):
  • platform/TextEncoding.h: Added. (WebCore::): (WebCore::TextEncoding::): (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::isValid): (WebCore::TextEncoding::usesVisualOrdering): (WebCore::TextEncoding::isJapanese): (WebCore::TextEncoding::encodingID): (WebCore::TextEncoding::flags): (WebCore::operator==): (WebCore::operator!=):
  • platform/character-sets.txt: Added.
  • platform/mac/ExtraCFEncodings.h: Added.
  • platform/mac/QStringMac.mm:
  • platform/mac/TextEncodingMac.cpp: Added. (WebCore::effectiveEncoding): (WebCore::TextEncoding::fromUnicode):
  • platform/mac/can-convert.mm: Added.
  • platform/mac/mac-encodings.txt: Added.
  • platform/make-charset-table.pl: Added.
  • platform/win/win-encodings.txt: Added.
  • rendering/render_object.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::slotData):
12:24 AM Changeset in webkit [13001] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.
12:13 AM Changeset in webkit [13000] by darin
  • 26 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Maciej.

  • merged Job and TransferJob into TransferJob and moved it to WebCore namespace
  • changed TransferJob to use a TransferJobClient object instead of signals
  • ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
  • kwq/KWQKJob.h: Removed.
  • kwq/TransferJobClient.h: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".
  • kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor. Remove the signals from TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer. (WebCore::TransferJob::TransferJob): Store a client pointer, remove the deliverAllData boolean. (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse function; uses client instead of a signal. (WebCore::TransferJob::client): Added.
  • kwq/KWQLoader.h: Switched things to mention the WebCore namespace. Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQLoader.mm: Ditto.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Removed isKHTMLLoader.
  • kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on the job instead of emitReceivedResponse. (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the client directly instead of emitRedirection on the job. (-[KWQResourceLoader addData:]): Call receivedData function on the client directly instead of emitData on the job. (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the client directly instead of emitResult on the job. Also fixed a potential memory leak where the handle was not released if the job was 0.
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.cpp:
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.cpp: Removed the job-related signals and slots.
  • loader/CachedObject.h: Removed unneeded declaration of TransferJob.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get". Also don't connect signals. (WebCore::Loader::receivedAllData): New name for slotFinished. (WebCore::Loader::receivedResponse): New name for slotReceivedResponse. (WebCore::Loader::receivedData): New name for slotData. (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob. (WebCore::Loader::jobForRequest): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly cleaned up the logic. (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
  • page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • xml/xmlhttprequest.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject. (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions by their new names (names changed to use with TransferJobClient). (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished. (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection. (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.

Feb 26, 2006:

10:34 PM Changeset in webkit [12999] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej, landed by Geoff.

Change "Deployment" to "Release" and "Development" to "Debug".
Update latest Xcode version from 2.2 to 2.2.1.

  • building/build.html
10:30 PM Changeset in webkit [12998] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej, landed by Geoff.

  • fast/forms/form-hides-table-expected.checksum: Added.
  • fast/forms/form-hides-table-expected.png: Added.
  • fast/forms/form-hides-table-expected.txt: Added.
  • fast/forms/form-hides-table.html: Added.
10:22 PM Changeset in webkit [12997] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Test by Geoff, automated by me, reviewed by Darin.

  • fast/frames/empty-frame-document-expected.txt: Added.
  • fast/frames/empty-frame-document.html: Added.

WebKit:

Test: fast/frames/empty-frame-document.html

Reviewed by Darin.

The crash happened because an empty frame did not have a document.

  • WebView/WebFrame.m: (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty frames. This causes a document to be created for the frame.
8:08 PM Changeset in webkit [12996] by darin
  • 3 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data): Add APPLE ifdefs to two more uses of response.
7:50 PM Changeset in webkit [12995] by darin
  • 5 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedObject.cpp: (WebCore::CachedObject::~CachedObject):
  • loader/CachedObject.h: (WebCore::CachedObject::CachedObject):
  • loader/loader.cpp: Add APPLE ifdefs to calls to setResponse and setAllData.
  • platform/win/TemporaryLinkStubs.cpp: Add missing includes.
7:31 PM Changeset in webkit [12994] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • more Win32 link fixes
  • loader/CachedObject.h: Put some Mac-specific stuff inside APPLE ifdefs.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
7:08 PM Changeset in webkit [12993] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:08 PM Changeset in webkit [12992] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:03 PM Changeset in webkit [12991] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • work toward getting the Win32 build to link
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added KWQObject.cpp.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.

Feb 25, 2006:

8:51 PM Changeset in webkit [12990] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added reviewer to an old change; I just noticed it was missing.

5:14 PM Changeset in webkit [12989] by ggaren
  • 9 edits
    18 adds in trunk/LayoutTests

RS by mjs.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
Re-landing results after adding missing png's to the test.

  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.
  • fast/replaced/maxheight-percent-expected.checksum: Added.
  • fast/replaced/maxheight-percent-expected.png: Added.
  • fast/replaced/maxheight-percent-expected.txt:
  • fast/replaced/maxheight-pxs-expected.checksum: Added.
  • fast/replaced/maxheight-pxs-expected.png: Added.
  • fast/replaced/maxheight-pxs-expected.txt:
  • fast/replaced/maxwidth-percent-expected.checksum: Added.
  • fast/replaced/maxwidth-percent-expected.png: Added.
  • fast/replaced/maxwidth-percent-expected.txt:
  • fast/replaced/maxwidth-pxs-expected.checksum: Added.
  • fast/replaced/maxwidth-pxs-expected.png: Added.
  • fast/replaced/maxwidth-pxs-expected.txt:
  • fast/replaced/minheight-percent-expected.checksum: Added.
  • fast/replaced/minheight-percent-expected.png: Added.
  • fast/replaced/minheight-percent-expected.txt:
  • fast/replaced/minheight-pxs-expected.checksum: Added.
  • fast/replaced/minheight-pxs-expected.png: Added.
  • fast/replaced/minheight-pxs-expected.txt:
  • fast/replaced/minwidth-percent-expected.checksum: Added.
  • fast/replaced/minwidth-percent-expected.png: Added.
  • fast/replaced/minwidth-percent-expected.txt:
  • fast/replaced/minwidth-pxs-expected.checksum: Added.
  • fast/replaced/minwidth-pxs-expected.png: Added.
  • fast/replaced/minwidth-pxs-expected.txt:

Feb 24, 2006:

7:48 PM Changeset in webkit [12988] by antti
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/float/multiple-float-positioning-expected.checksum: Added.
  • fast/block/float/multiple-float-positioning-expected.png: Added.
  • fast/block/float/multiple-float-positioning-expected.txt: Added.
  • fast/block/float/multiple-float-positioning.html: Added.
7:46 PM Changeset in webkit [12987] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/block/float/multiple-float-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
6:57 PM Changeset in webkit [12986] by justing
  • 9 edits in trunk

LayoutTests:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

Reviewed by justin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their own selection gaps.
6:25 PM Changeset in webkit [12985] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
  • fast/dom/Window/redirect-with-timer.html: Added.
  • fast/dom/Window/redirect-with-timer-expected.txt: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

Test: fast/dom/Window/redirect-with-timer.html

  • platform/Timer.h: Made isActive no longer inline. Added inHeap function.
  • platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are.
5:07 PM Changeset in webkit [12984] by justing
  • 58 edits in trunk

LayoutTests:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/selection/extend-by-character-003-expected.txt:
  • editing/selection/extend-by-character-005-expected.txt:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-character-003-expected.txt:
  • editing/selection/move-by-character-005-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::setContentEditable):
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement):
2:48 PM Changeset in webkit [12983] by eseidel
  • 11 edits
    3 moves in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/css_base.h:
  • dom/AtomicStringList.h: Added. (WebCore::AtomicStringList::AtomicStringList):
  • dom/QualifiedName.cpp: Added.
  • dom/QualifiedName.h: Added.
  • dom/dom_atomicstringlist.h: Removed.
  • dom/dom_elementimpl.h:
  • dom/dom_qname.cpp: Removed.
  • dom/dom_qname.h: Removed.
  • editing/RemoveNodeAttributeCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • khtml/html/htmlnames.h:
  • khtml/html/htmltokenizer.h:
  • ksvg2/scripts/make_names.pl: update for new headers
2:36 PM Changeset in webkit [12982] by eseidel
  • 6 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Made a few methods on frame pure virtual.
Added a bunch of stub functions for win32 linking.

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::print): (WebCore::MacFrame::canUndo): (WebCore::MacFrame::canRedo): (WebCore::MacFrame::canPaste):
  • bridge/win/FrameWin.h:
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (QLineEdit::maxLength): (QPainter::drawEllipse): (QTextEdit::setLineHeight): (QPainter::beginTransparencyLayer): (QLineEdit::selectedText): (Widget::setIsSelected): (QPainter::paintingDisabled): (QFontMetrics::selectionRectForText): (QTextEdit::getCursorPosition): (QSlider::QSlider): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
2:07 PM Changeset in webkit [12981] by ggaren
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by Hyatt.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

  • fast/replaced/maxheight-percent.html: Added.
  • fast/replaced/maxheight-pxs.html: Added.
  • fast/replaced/maxwidth-percent.html: Added.
  • fast/replaced/maxwidth-pxs.html: Added.
  • fast/replaced/minheight-percent.html: Added.
  • fast/replaced/minheight-pxs.html: Added.
  • fast/replaced/minwidth-percent.html: Added.
  • fast/replaced/minwidth-pxs.html: Added.
  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.

WebCore:

Reviewed by Hyatt, tweaked and landed by ggaren.

This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
patch of ​http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
modifications to suit the Webcore tree. Makes images respect min/max
sizes and their intrinsic aspect ratios at the same time according to
CSS 2.1 (​http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).

Test: fast/replaced/maxheight-percent.html
Test: fast/replaced/maxheight-pxs.html
Test: fast/replaced/maxwidth-percent.html
Test: fast/replaced/maxwidth-pxs.html
Test: fast/replaced/minheight-percent.html
Test: fast/replaced/minheight-pxs.html
Test: fast/replaced/minwidth-percent.html
Test: fast/replaced/minwidth-pxs.html

  • rendering/render_box.cpp: (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
  • rendering/render_image.cpp: Respect aspect ratios and calculate max/min (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): Added (WebCore::RenderImage::calcAspectRatioHeight): Added (WebCore::RenderImage::calcMinMaxWidth): Added
  • rendering/render_image.h:
1:47 PM Changeset in webkit [12980] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • add missing resources for manual-tests/scrolling-nestedframesets.html
  • manual-tests/resources/testframe-link_text.html: Added.
  • manual-tests/resources/testframeset.html: Added.
1:31 PM Changeset in webkit [12979] by vicki
  • 1 edit
    1 add in trunk/WebCore
  • test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
  • manual-tests/onbeforeunload-close_with_javascript.html: Added.
1:25 PM Changeset in webkit [12978] by eseidel
  • 3 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add Path stubs for Win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (Path::Path): (Path::~Path): (Path::operator=): (Path::contains): (Path::translate): (Path::boundingRect):
1:13 PM Changeset in webkit [12977] by hyatt
  • 26 edits in trunk/WebCore

In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle. htmlFont() becomes simply
font(). The old font() method turns into qfont(). Also added a helper for obtaining the fontDescription() directly from
the RenderStyle (without first obtaining the htmlFont()).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::offsetForPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::font): (WebCore::RenderText::width): (WebCore::RenderText::htmlFont):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::font): (khtml::RenderStyle::fontDescription): (khtml::RenderStyle::qfont):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
11:49 AM Changeset in webkit [12976] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • add link stubs for symbols only referenced from the link stubs file
  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::focusPolicy): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar):
11:44 AM Changeset in webkit [12975] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • fix up font.h inclues to be Font.h to fix build.
  • css/css_computedstyle.cpp:
  • css/css_valueimpl.cpp:
  • platform/Font.cpp:
  • rendering/render_style.h:
11:28 AM Changeset in webkit [12974] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix mac build by changing constants to an enum.

  • khtml/dom/dom2_events.h: (DOM::KeyboardEvent::):
11:19 AM Changeset in webkit [12973] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against icu.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
11:15 AM Changeset in webkit [12972] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Move rendering/font to platform/Font.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp:
  • platform/Font.cpp: Added.
  • platform/Font.h: Added.
  • rendering/font.cpp: Removed.
  • rendering/font.h: Removed.
  • rendering/render_theme_mac.mm:
11:11 AM Changeset in webkit [12971] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove delcarations causing duplicate symbols on win32.

  • khtml/dom/dom2_events.cpp:
11:02 AM Changeset in webkit [12970] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

  • bridge/win/FrameWin.cpp: fix line endings
10:54 AM Changeset in webkit [12969] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against libxml, etc.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
10:36 AM Changeset in webkit [12968] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Removed WebCore
prefixes added using namespace WebCore, fixes win32 build.
  • platform/win/TemporaryLinkStubs.cpp: (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QTextEdit::textWithHardLineBreaks): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (iBeamCursor): (QPainter::misspellingLineThickness): (westResizeCursor): (Widget::isEnabled): (northWestResizeCursor): (QPainter::drawEllipse): (southWestResizeCursor): (Widget::focusPolicy): (waitCursor): (QPainter::endTransparencyLayer): (ScrollView::addChild): (Widget::~Widget): (QListBox::sizeForNumberOfLines): (FrameView::updateBorder): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (eastResizeCursor): (QFontMetrics::boundingRect): (QPainter::beginTransparencyLayer): (northEastResizeCursor): (Widget::frameGeometry): (QPainter::addFocusRingRect): (QPainter::restore): (Widget::setEnabled): (QPainter::font): (QPainter::pen): (crossCursor): (Widget::setIsSelected): (handCursor): (QLineEdit::text): (Widget::unlockDrawingFocus): (QPainter::paintingDisabled): (northResizeCursor): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QPainter::drawText): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (southResizeCursor): (moveCursor): (FrameView::isFrameView): (helpCursor): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (southEastResizeCursor): (QPainter::drawScaledAndTiledImage): (QPainter::drawImage): (QComboBox::setWritingDirection): (QComboBox::sizeHint): (QPainter::drawRect): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QPainter::drawLineForMisspelling): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (ScrollView::updateContents):
8:24 AM Changeset in webkit [12967] by darin
  • 20 edits
    1 copy
    2 moves in trunk/WebCore

Reviewed by Hyatt.

  • moved QScrollView from kwq to platform directory
  • kwq/KWQScrollView.h: Removed.
  • kwq/KWQScrollView.mm: Removed.
  • platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
  • platform/ScrollView.h: Added. The rest of the former QScrollView.
  • platform/mac/ScrollViewMac.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::init): (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::scrollbarsVisible): Changed scrolling constants to use new names.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter): Use FrameView instead of QScrollView for a local variable.
  • khtml/html/html_baseimpl.h: Use ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQListBox.h: Use WebCore::ScrollView instead of QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Ditto. (QTextEdit::focusPolicy): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode instead of QScrollView::ScrollBarMode. (WebCore::FrameView::FrameView): Remove mention of QScrollView. (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView. (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView. (WebCore::FrameView::setVScrollBarMode): Ditto. (WebCore::FrameView::setHScrollBarMode): Ditto. (WebCore::FrameView::restoreScrollBar): Ditto.
  • platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
  • platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle): Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to updateContents so we can remove the overload. (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView. (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto. (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
4:59 AM Changeset in webkit [12966] by andersca
  • 2 edits in trunk/WebKitTools

2006-02-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
getting called from the run loop, making the view render each test and thus slowing
down the tests.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the offscreen window to not autodisplay.
1:14 AM Changeset in webkit [12965] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix the win32 build.

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
1:10 AM Changeset in webkit [12964] by ap
  • 2 edits
    60 adds in trunk/LayoutTests

Reviewed by Darin.

  • http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
  • http/tests/xmlhttprequest/web-apps: Added (recursively).
12:01 AM Changeset in webkit [12963] by hyatt
  • 17 edits
    1 add in trunk/WebCore

Rename FontDef to FontDescription and move it into the platform directory.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize):
  • css/cssstyleselector.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • platform/FontDescription.h: Added. (WebCore::FontDescription::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::operator!=): (WebCore::FontDescription::family): (WebCore::FontDescription::firstFamily): (WebCore::FontDescription::specifiedSize): (WebCore::FontDescription::computedSize): (WebCore::FontDescription::italic): (WebCore::FontDescription::computedPixelSize): (WebCore::FontDescription::smallCaps): (WebCore::FontDescription::isAbsoluteSize): (WebCore::FontDescription::weight): (WebCore::FontDescription::genericFamily): (WebCore::FontDescription::usePrinterFont): (WebCore::FontDescription::setFamily): (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize): (WebCore::FontDescription::setItalic): (WebCore::FontDescription::setSmallCaps): (WebCore::FontDescription::setIsAbsoluteSize): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::setGenericFamily): (WebCore::FontDescription::setUsePrinterFont): (WebCore::FontDescription::operator==):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
  • rendering/font.cpp: (khtml::Font::selectionRectForText): (khtml::Font::drawHighlightForText): (khtml::Font::drawText): (khtml::Font::update):
  • rendering/font.h: (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::fontDescription): (WebCore::Font::isSmallCaps): (WebCore::Font::wordSpacing): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): (WebCore::Font::width):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
  • rendering/render_style.h: (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):

Feb 23, 2006:

11:16 PM Changeset in webkit [12962] by mjs
  • 6 edits in trunk/WebCore
  • fix build by making some pointless changes to files that Xcode doesn't rebuild otherwise
  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • dom/Element.idl:
  • dom/WheelEvent.idl:


  • add -Y 3 flag to linking; this makes the linker say what files reference unresolved symbols


  • WebCore.xcodeproj/project.pbxproj:
10:29 PM Changeset in webkit [12961] by darin
  • 2 edits in trunk/JavaScriptCore
  • try to fix buildbot failure
  • bindings/c/c_utility.cpp: Touch this file, which seems to not have been recompiled after additional inlining was introduced (Xcode bug?).
9:37 PM Changeset in webkit [12960] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
9:32 PM Changeset in webkit [12959] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs
  • remove unused forwarding headers
  • ForwardingHeaders/kurl.h: Removed.
  • ForwardingHeaders/qlist.h: Removed.
  • ForwardingHeaders/qregion.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
9:23 PM Changeset in webkit [12958] by darin
  • 24 edits
    2 moves
    1 add
    4 deletes in trunk/WebCore

Reviewed by Maciej.

  • removed QPalette, QRegion, QPrinter
  • added Path to replace QRegion
  • removed unused QScrollView functions
  • ForwardingHeaders/qpalette.h: Removed.
  • kwq/KWQPalette.h: Removed.
  • kwq/KWQPalette.mm: Removed.
  • kwq/KWQPrinter.h: Removed.
  • kwq/KWQRegion.cpp: Removed.
  • kwq/KWQRegion.h: Removed.
  • platform/Path.h: Added. Replaces QRegion.
  • platform/cg: Added.
  • platform/cg/PathCG.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h. (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
  • bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path. (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
  • khtml/html/html_imageimpl.h: Ditto.
  • kwq/KWQPainter.mm: Removed use of QRegion.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
  • kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(), hasHorizontalScrollBar(), childX(), childY().
  • kwq/KWQScrollView.mm: Ditto.
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): Removed use of QPalette that always yields white.
  • rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations): Ditto.
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: Removed palette() and setPalette().
  • kwq/KWQLineEdit.h: Replaced setPalette with setColors.
  • kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette. (WebCore::RenderLineEdit::updateFromElement): Added call to setColors. (WebCore::RenderTextArea::updateFromElement): Ditto.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint): Removed use of childX and childY functions.
9:10 PM Changeset in webkit [12957] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/KURL.cpp:
9:01 PM Changeset in webkit [12956] by mjs
  • 2 edits in trunk/WebCore
  • fix build (header name changed)
  • platform/mac/KURLMac.mm:
8:34 PM Changeset in webkit [12955] by mjs
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Eric.

This gets rid of a couple hundred link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQSignal.h: (KWQSignal::KWQSignal):
  • platform/win/TemporaryLinkStubs.cpp: Added. (notImplemented): (QLineEdit::selectAll): (WebCore::QPainter::save): (WebCore::Widget::enableFlushDrawing): (WebCore::QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (QLineEdit::cursorPosition): (WebCore::QPainter::setPen): (WebCore::QPainter::selectedTextBackgroundColor): (WebCore::QPainter::fontMetrics): (WebCore::Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (WebCore::iBeamCursor): (QComboBox::clear): (WebCore::QPainter::misspellingLineThickness): (QLineEdit::maxLength): (WebCore::westResizeCursor): (WebCore::Widget::isEnabled): (WebCore::northWestResizeCursor): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (WebCore::QPainter::drawEllipse): (WebCore::southWestResizeCursor): (QTextEdit::setReadOnly): (QListBox::appendItem): (WebCore::Widget::focusPolicy): (QTextEdit::selectAll): (WebCore::waitCursor): (WebCore::QPainter::endTransparencyLayer): (QScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (WebCore::Widget::~Widget): (QListBox::sizeForNumberOfLines): (QScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (WebCore::FrameView::updateBorder): (QLineEdit::hasSelectedText): (QListBox::doneAppendingItems): (QScrollView::inWindow): (QScrollBar::setValue): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (QScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (WebCore::QPainter::drawLineForText): (QObject::disconnect): (WebCore::QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::clearShadow): (QTextEdit::setLineHeight): (QMouseEvent::QMouseEvent): (WebCore::eastResizeCursor): (QScrollBar::setKnobProportion): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (WebCore::QPainter::beginTransparencyLayer): (WebCore::northEastResizeCursor): (WebCore::Widget::frameGeometry): (QListBox::setSelected): (WebCore::QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (WebCore::QPainter::restore): (QFontMetrics::width): (WebCore::Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (QScrollView::setStaticBackground): (WebCore::QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (WebCore::Widget::palette): (WebCore::QPainter::pen): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (WebCore::crossCursor): (WebCore::Widget::setIsSelected): (WebCore::handCursor): (QLineEdit::text): (WebCore::Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (WebCore::QPainter::paintingDisabled): (WebCore::northResizeCursor): (QComboBox::QComboBox): (QSlider::setMaxValue): (WebCore::Widget::lockDrawingFocus): (WebCore::QPainter::drawLine): (WebCore::QPainter::setBrush): (QTextEdit::setSelectionRange): (WebCore::QPainter::drawText): (QScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (WebCore::Cursor::~Cursor): (QFontMetrics::selectionRectForText): (WebCore::southResizeCursor): (QScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (WebCore::moveCursor): (WebCore::FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (QComboBox::baselinePosition): (QComboBox::appendItem): (WebCore::helpCursor): (QTextEdit::setWritingDirection): (WebCore::Widget::setDrawingAlpha): (QSlider::QSlider): (WebCore::southEastResizeCursor): (QScrollView::setVScrollBarMode): (WebCore::QPainter::drawScaledAndTiledImage): (QScrollView::scrollYOffset): (WebCore::QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (QScrollView::setScrollBarsMode): (QComboBox::sizeHint): (WebCore::QPainter::drawRect): (QFont::setPixelSize): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::clearFocusRing): (WebCore::Widget::Widget): (QTextEdit::text): (WebCore::QPainter::drawImageInRect): (WebCore::Widget::disableFlushDrawing): (WebCore::QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (WebCore::QPainter::drawLineForMisspelling): (QSlider::value): (QListBox::setSelectionMode): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (QScrollView::updateContents): (QFontMetrics::floatWidth): (QScrollView::setHScrollBarMode):
7:52 PM Changeset in webkit [12954] by mjs
  • 17 edits
    3 copies in trunk/WebCore

Reviewed by Eric.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_ruleimpl.cpp:
  • css/cssparser.cpp:
  • css/cssstyleselector.cpp:
  • dom/DocumentImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/xbl/xbl_binding.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQTextCodec.cpp: (QTextCodec::codecForName): (QTextCodec::utf8Codec): (QTextCodec::codecForNameEightBitOnly): (QTextCodec::codecForLocale): (QTextCodec::name): (QTextCodec::makeDecoder):
  • kwq/KWQTextCodec.h:
  • loader/CachedObject.cpp:
  • loader/DocLoader.cpp:
  • page/Frame.h:
  • platform/KURL.cpp: Added. (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h: Added.
  • platform/mac/KURLMac.mm: Added. (KURL::getNSURL):
  • xml/xmlhttprequest.h:
7:08 PM Changeset in webkit [12953] by darin
  • 97 edits
    5 copies
    5 moves
    2 adds
    5 deletes in trunk/WebCore

Reviewed by John Sullivan.

  • moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras" from kwq to platform directory
  • moved history function from kwq to bridge directory
  • eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent, MoveReleaseEvent, and DrawContents classes
  • merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into a single class in the page directory
  • broke khtmllayout.h out into a file for the Length structure in the css directory and a file for the GapRects structure in the rendering directory
  • redid the Length structure to work more portably by not relying on bitfield layout and improve the names to no longer explicitly mention "width"
  • reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
  • ForwardingHeaders/kparts: Removed.
  • ForwardingHeaders/qevent.h: Removed.
  • khtml/khtml_events.cpp: Removed.
  • khtml/khtml_events.h: Removed.
  • khtml/misc/khtmllayout.h: Removed.
  • kwq/KWQEvent.h: Removed.
  • kwq/KWQEvent.mm: Removed.
  • kwq/KWQFoundationExtras.h: Removed.
  • kwq/KWQKHistoryProvider.mm: Removed.
  • kwq/KWQKPartsHistoryProvider.h: Removed.
  • bridge/History.h: Added.
  • bridge/mac/HistoryMac.mm: Added.
  • css/Length.h: Added.
  • page/MouseEventWithHitTestResults.h: Added.
  • platform/KeyEvent.h: Added.
  • platform/MouseEvent.h: Added.
  • platform/WheelEvent.h: Added.
  • platform/mac/FoundationExtras.h: Added.
  • platform/mac/KeyEventMac.mm: Added.
  • platform/mac/MouseEventMac.mm: Added.
  • platform/mac/WheelEventMac.mm: Added.
  • rendering/GapRects.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for above changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions. Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent with MouseEventWithHitTestResults.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::urlSelected): Removed unused parameters. (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent. (WebCore::MacFrame::keyEvent): Changed to use KeyEvent. (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type. (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto. (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto. (WebCore::MacFrame::passSubframeEventToSubframe): Ditto. (WebCore::MacFrame::mouseDown): Changed to use MouseEvent. (WebCore::MacFrame::mouseDragged): Ditto. (WebCore::MacFrame::mouseUp): Ditto. (WebCore::MacFrame::mouseMoved): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Ditto.
  • css/csshelper.h: Removed a bunch of unused declarations.
  • dom/DocumentImpl.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent and return a MouseEventWithHitTestResults. (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
  • dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and detail values from the caller, never from the event. Changed to use MouseEvent. (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent. (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
  • dom/dom2_eventsimpl.h:
  • dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent. (WebCore::KeyboardEventImpl::charCode): Ditto.
  • dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
  • khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference to the document.
  • khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For use in the Frame destructor so we can get an existing KJS::Window object without creating a new interpreter and window object.
  • khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the guarded pointers to Frame to use plain old pointers that are cleared by the Frame explicitly (by the function disconnectFrame). Made the pointers to all the sub-objects of KJS::Window be mutable so we don't have to const_cast in the functions to get (and lazily create) them.
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*. (KJS::History::disconnectFrame): Added. Clears m_frame. (KJS::FrameArray::disconnectFrame): Added. Clears m_frame. (KJS::Window::Window): Removed code to create a WindowQObject. (KJS::Window::~Window): Removed code to delete a WindowQObject. (KJS::Window::location): Remove now-unneeded const_cast. (KJS::Window::selection): Ditto. (KJS::Window::locationbar): Ditto. (KJS::Window::menubar): Ditto. (KJS::Window::personalbar): Ditto. (KJS::Window::statusbar): Ditto. (KJS::Window::toolbar): Ditto. (KJS::Window::scrollbars): Ditto. (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer. (KJS::Window::getOwnPropertySlot): Ditto. (KJS::Window::toBoolean): Ditto. (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null. (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer. (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call to clearAllTimeouts instead. (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject destructor. (KJS::Window::installTimeout): Moved to Window from WindowQObject. (KJS::Window::pauseTimeouts): Ditto. (KJS::Window::resumeTimeouts): Ditto. (KJS::Window::clearTimeout): Ditto. (KJS::Window::timerFired): Ditto. (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0. (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer. (KJS::Location::getOwnPropertySlot): Ditto. (KJS::Location::put): Ditto. (KJS::Selection::getOwnPropertySlot): Ditto. (KJS::BarInfo::getOwnPropertySlot): Ditto.
  • khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
  • khtml/html/html_imageimpl.h: Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler): Changed to use KeyEvent and removed the code to extract the button and state from the DOM even to pass to urlSelected.
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use a RefPtr instead of a QGuardedPtr.
  • khtml/misc/helper.h:
  • khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent): Change to use KeyEvent.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusChanged):
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Updated to use new eventFilterFocusIn/Out instead of the general purpose eventFilter function. This allows us to remove QEvent and the focus events.
  • kwq/KWQNamespace.h: Removed ButtonState.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
  • kwq/KWQSlot.cpp: (KWQSlot::KWQSlot): Removed the parentDestroyed slot. (KWQSlot::call): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a raw Frame pointer instead of a QGuardedPtr, and count on the Frame to delete us when it's being deleted. (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer a virtual function. This is not a polymorphic class. (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete ourselves -- that's now the frame's responsibility. (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and delete m_userStyleSheetLoader. (WebCore::Frame::changeLocation): Update since urlSelected no longer takes button and state parameters. (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load in progress before starting a new load. Store reference to loader. (WebCore::Frame::urlSelected): Remove button and state parameters and unused local variable hasTarget. (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent to MouseEvent. (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent to MouseEventWithHitTestResults. (WebCore::Frame::handleMousePressEventTripleClick): Ditto. (WebCore::Frame::handleMousePressEventSingleClick): Ditto. (WebCore::Frame::khtmlMousePressEvent): Ditto. (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseMoveEvent): Ditto. (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults. (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
  • page/FramePrivate.h: Added m_userStyleSheetLoader.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto. (WebCore::selectCursor): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto. (WebCore::FrameView::viewportMouseReleaseEvent): Ditto. (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent. (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to WheelEvent. (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent parameters.
  • platform/Widget.h:
  • platform/Widget.cpp: Removed event function.
  • rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent. (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes to the Length class. (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of ComboBoxWidget. (WebCore::RenderSelect::slotSelected): Ditto. (WebCore::RenderSelect::createComboBox): Ditto.
  • rendering/render_replaced.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes a parameter. (WebCore::RenderWidget::setQWidget): Ditto. (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter. (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
  • css/css_computedstyle.cpp: (WebCore::valueForLength): (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRegion):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::getBPMWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderText.h: (khtml::RenderText::marginLeft): (khtml::RenderText::marginRight):
  • rendering/bidi.cpp: (khtml::getBPMWidth):
  • rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::relativePositionOffset): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcHeightUsing): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth): (khtml::RenderFlexibleBox::calcMinMaxWidth): (khtml::RenderFlexibleBox::allowedChildFlex):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_image.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
  • rendering/render_layer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start): (WebCore::Marquee::updateMarqueeStyle): (WebCore::Marquee::timerFired):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::addDashboardRegions):
  • rendering/render_style.h:
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::addIntrinsicMargins):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages): Updated for changes to the Length class. Also removed a check of the printpainter global, never used in WebCore.
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/csshelper.cpp:
  • editing/SelectionController.cpp:
  • khtml/ecma/kjs_html.h:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQClipboard.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPainter.mm:
  • kwq/WebCoreSettings.mm:
  • platform/StringImpl.cpp:
  • platform/mac/CursorMac.mm:
  • platform/mac/WidgetMac.mm:
  • rendering/RenderBlock.h:
  • rendering/render_canvas.cpp:
  • rendering/render_line.h:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Updated includes.
  • bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this didn't rebuild.
  • bindings/js/JSDOMEvents.cpp: Ditto.
6:00 PM Changeset in webkit [12952] by thatcher
  • 2 edits in trunk/WebKitLibraries

New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)

  • libWebKitSystemInterface.a:
5:11 PM Changeset in webkit [12951] by eseidel
  • 10 edits
    1 add in trunk/WebCore

2006-02-23 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix linking of static constructed globals on win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • dom/EventNames.cpp: (WebCore::EventNames::init):
  • dom/EventNames.h:
  • dom/dom_qname.cpp: (WebCore::QualifiedName::init):
  • dom/dom_qname.h:
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init):
  • khtml/html/htmlnames.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init):
  • platform/StaticConstructors.h: Added.
4:20 PM Changeset in webkit [12950] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick.


  • fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

Check shouldClose() before actually scheduling a close.

shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
result based on whether the user clicks "OK" or "Cancel". In cases where the window is closed with cmd-w
or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method. Since
windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
closes a window even gets started.

  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
11:52 AM Changeset in webkit [12949] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Darin, Maciej.

  • Inline some functions suggested by Shark. 2.9% speedup on super accurate JS iBench.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
<rdar://problem/4448116>

  • kjs/nodes.h: (KJS::ArgumentsNode::evaluateList):
  • kjs/object.cpp:
  • kjs/object.h: (KJS::ScopeChain::release): (KJS::JSObject::toPrimitive):
  • kjs/scope_chain.cpp:
  • kjs/ustring.cpp:
  • kjs/ustring.h: (KJS::UString::toArrayIndex):
  • kjs/value.cpp:
  • kjs/value.h: (KJS::JSValue::toObject):
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_ThreadCache_FreeList::Push): (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
11:46 AM Changeset in webkit [12948] by vicki
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.


  • fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
  • dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter
11:28 AM Changeset in webkit [12947] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Turn http tests back on by default.
  • Wait for Apache to actually start serving requests.
  • Get user id from a built-in variable rather than an external command; don't pass the group.
  • Scripts/run-webkit-tests:
9:25 AM Changeset in webkit [12946] by ap
  • 2 edits in trunk/WebKitTools

Suggested by Mitz Pettel, reviewed by Darin.

  • Scripts/run-webkit-tests: Pass User and Group directives, so that Apache can run CGIs even if the permissions are 700 or 600.
8:39 AM Changeset in webkit [12945] by darin
  • 2 edits in trunk/WebKitTools

Collaborating with Alexey.

  • turn off http tests by default until we figure out how to get them to run even when permissions on CGI files are 700 instead of 755
  • Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.
1:01 AM Changeset in webkit [12944] by eseidel
  • 6 edits in trunk

2006-02-23 Eric Seidel <​eseidel@apple.com>

Add *.user to ignore list.

12:55 AM Changeset in webkit [12943] by eseidel
  • 2 edits
    2 deletes in trunk/WebKitTools

2006-02-23 Eric Seidel <​eseidel@apple.com>

Remove binary file which shouldn't have been commited (and add to ignore list).

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.

Feb 22, 2006:

11:09 PM Changeset in webkit [12942] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/run-webkit-tests: Put Apache log files in the right directory.
8:10 PM Changeset in webkit [12941] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim Hatcher.

Fix install-win-extras to not try to re-install setx if installed.

  • Scripts/install-win-extras:
7:52 PM Changeset in webkit [12940] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

One more file possibly missing from previous commit?

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:38 PM Changeset in webkit [12939] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Files missing from previous commit.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
7:27 PM Changeset in webkit [12938] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by justing.

Corrected path for DumpRenderTree.intermediate files

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:14 PM Changeset in webkit [12937] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Fixed build-dumprendertree to exit with correct error codes.

  • Scripts/build-dumprendertree:
6:49 PM Changeset in webkit [12936] by eseidel
  • 5 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Update build scripts to generalize building on Win32, and allow
building of DumpRenderTree on Win32 from build-dumprendertree.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
5:34 PM Changeset in webkit [12935] by thatcher
  • 15 adds in branches/Safari-1-3-branch

Fixing binary files messed up by cvs2svn.

4:56 PM Changeset in webkit [12934] by eseidel
  • 2 edits
    7 adds in trunk/WebKitTools

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (_tmain):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
  • Scripts/build-webkit: make build-webkit cleanup after itself
4:36 PM Changeset in webkit [12933] by eseidel
  • 2 edits
    2 adds in trunk/WebCore

2006-02-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Adding stub FrameWin class to expose link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: Added.
  • bridge/win/FrameWin.h: Added. (WebCore::Win):
4:33 PM Changeset in webkit [12932] by mjs
  • 37 edits
    2 moves
    1 add
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • move QStringList to platform, make it portable
  • ForwardingHeaders/qstringlist.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentImpl.h:
  • kcanvas/KCanvasFilters.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLengthListImpl.cpp:
  • ksvg2/svg/SVGNumberListImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • kwq/KWQClipboard.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKLocale.h:
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQStringList.h: Removed.
  • kwq/KWQStringList.mm: Removed.
  • loader/DocLoader.h:
  • page/Frame.h:
  • platform/QStringList.cpp: Added. (QStringList::split): (QStringList::pop_front):
  • platform/QStringList.h: Added.
  • platform/mac/QStringListMac.mm: Added. (QStringList::getNSArray):

Feb 21, 2006:

10:10 PM Changeset in webkit [12931] by ap
  • 7 edits
    1 add in trunk

Reviewed by Darin.

LayoutTests:

  • http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now passed from run-webkit-tests.
  • http/tests/favicon.ico: Added.
  • http/tests/incremental/slow-utf8-text.text: Remove an unused variable,
  • http/tests/incremental/split-hex-entities.html: Ditto.
  • http/tests/xmlhttprequest/interactive-state.cgi: Ditto.

WebKitTools:

  • Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd.
4:55 PM Changeset in webkit [12930] by kdecker
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Backed out my previous check in. Since these methods are internal to WebKit (and not private)
it's perfectly OK for them to remain as categories.

  • ChangeLog:
  • WebView/WebPreferences.m: (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _floatValueForKey:]): (-[WebPreferences _setFloatValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]):
  • WebView/WebPreferencesPrivate.h:
3:49 PM Changeset in webkit [12929] by adele
  • 3 edits
    8 adds in trunk

Reviewed by Hyatt.

  • fast/forms/input-baseline-expected.checksum: Added.
  • fast/forms/input-baseline-expected.png: Added.
  • fast/forms/input-baseline-expected.txt: Added.
  • fast/forms/input-baseline.html: Added.
  • fast/inline-block/contenteditable-baseline-expected.checksum: Added.
  • fast/inline-block/contenteditable-baseline-expected.png: Added.
  • fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • fast/inline-block/contenteditable-baseline.html: Added.

Reviewed by Hyatt.

Tests:

  • fast/forms/input-baseline.html
  • fast/inline-block/contenteditable-baseline.html
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, and there are no children to give us the baseline. Instead, compute the baseline for the block itself, and factor in the border and the padding.
2:55 PM Changeset in webkit [12928] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Add a nil check for the renderer, and refetch the renderer for the old focus node
after dispatching the event.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode):
2:19 PM Changeset in webkit [12927] by eseidel
  • 2 edits
    1 add in trunk/JavaScriptCore

2006-02-21 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add grammarWrapper.cpp to work around visual studio bug plaguing buildbot.

1:51 PM Changeset in webkit [12926] by kdecker
  • 3 edits in trunk/WebKit

Reviewed by Timo O.

Moved these (already private) methods into the private WebPreferences header.
Slightly better style than sprinkling the code with categories.


  • WebView/WebPreferences.m: (-[WebPreferences _integerValueForKey:]): Moved to WebPreferences (WebPrivate). (-[WebPreferences _floatValueForKey:]): Ditto. (-[WebPreferences _boolValueForKey:]): Ditto. (-[WebPreferences _setBoolValue:forKey:]): Ditto. (-[WebPreferences _setFloatValue:forKey:]): Ditto. (-[WebPreferences _setIntegerValue:forKey:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Added the above methods.
11:34 AM Changeset in webkit [12925] by ggaren
  • 2 edits in trunk/WebKitSite

Accidentally wrote "Release" instead of "Debug" in my last patch.

  • quality/leakhunting.html:
11:17 AM Changeset in webkit [12924] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-21 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

  • kjs/testkjs.cpp: #if out timeval code on win32
11:12 AM Changeset in webkit [12923] by ap
  • 3 edits
    38 adds in trunk

Reviewed by Darin.

Added two run-webkit-tests options:

--http (--nohttp) - whether to launch Apache (defaults to yes);
--port - which port to listen on (defaults to 8000).

Tests in LayoutTests/http are not run directly, and Apache is used instead.
For example, http/tests/xmlhttprequest/post-content-type.html is loaded as
​http://127.0.0.1:8000/xmlhttprequest/post-content-type.html.

Also added support for .shtml and .text files. Text files give an empty
*-expected.txt, but a correct image.

Apache only listens on the loopback interface. It writes logs to /tmp/WebKit.

  • Scripts/run-webkit-tests:
9:04 AM Changeset in webkit [12922] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kxmlcore/TCPageMap.h: Added <string.h> include.
8:57 AM Changeset in webkit [12921] by darin
  • 27 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kjs/internal.h: Made InternalFunctionImp::callAsFunction pure virtual so that we'll get a compile error if some derived class neglects to implement it.
  • kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Remove unneeded initialization of param, which is an OwnPtr so it gets initialized by default.
  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/error_object.cpp:
  • kjs/error_object.h:
  • kjs/function.cpp:
  • kjs/function.h:
  • kjs/function_object.cpp:
  • kjs/function_object.h:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object_object.cpp:
  • kjs/object_object.h:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h: Removed many rendundant implementations of implementsCall from subclasses of InternalFunctionImp.
8:09 AM Changeset in webkit [12920] by darin
  • 2 edits in trunk/WebKitTools

Suggested by Mark Rowe.

  • Scripts/run-webkit-tests: Don't include the number of excluded leaks when reporting leak counts.
7:29 AM Changeset in webkit [12919] by darin
  • 2 edits in trunk/JavaScriptCore
  • fixed build
  • kjs/internal.cpp: (KJS::InternalFunctionImp::implementsCall): Oops, fixed name.
7:19 AM Changeset in webkit [12918] by darin
  • 3 edits in trunk/JavaScriptCore

Change suggested by Mitz.

  • kjs/internal.h: Add implementsHasCall to InternalFunctionImp.
  • kjs/internal.cpp: (KJS::InternalFunctionImp::implementsHasCall): Return true. All the classes derived from InternalFunctionImp need to return true from this -- later we can remove all the extra implementations too.
2:15 AM Changeset in webkit [12917] by mjs
  • 11 edits in trunk/WebCore

Rubber Stamped by Hyatt.

  • renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc


This avoids conflicting with win32 headers.

  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • editing/htmlediting.cpp: (WebCore::isSpecialElement):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/render_box.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/render_object.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::container):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff):
  • rendering/render_style.h: (khtml::): (khtml::RenderStyle::initialPosition):
1:59 AM Changeset in webkit [12916] by mjs
  • 2 edits in trunk/WebCore

Rubber Stamped by Hyatt.

  • remove KWQSignalStubs.cpp from project.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
1:23 AM Changeset in webkit [12915] by mjs
  • 2 edits in trunk/WebCore

Platform build fix, not reviewed.

  • undef min and max, and include <algorithm> so std::min works
  • rendering/font.h:
12:56 AM Changeset in webkit [12914] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix build breakage caused by last-minute change to my patch
  • kjs/lookup.h:
12:21 AM Changeset in webkit [12913] by mjs
  • 8 edits in trunk

LayoutTests:

Reviewed by Geoff and Darin.


Patch from Maks Orlovich, based on work by David Faure, hand-applied and
significantly reworked by me.



Updated test results, now showing correct function string.

  • fast/dom/xmlhttprequest-get-expected.txt:
  • fast/js/kde/function-expected.txt:
  • fast/js/kde/inbuilt_function_tostring-expected.txt:

WebCore:

Reviewed by Geoff and Darin.


Patch from Maks Orlovich, based on work by David Faure, hand-applied and
significantly reworked by me.


  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::HTMLElementFunction):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame functionName]):

Feb 20, 2006:

11:55 PM Changeset in webkit [12912] by ggaren
  • 2 edits in trunk/WebKitSite

Some quick proof-reading of the patch I just landed -- no review
necessary.

  • quality/leakhunting.html:
11:54 PM Changeset in webkit [12911] by mjs
  • 28 edits in trunk/JavaScriptCore

Reviewed by Geoff and Darin.


Patch from Maks Orlovich, based on work by David Faure, hand-applied and
significantly reworked by me.


  • tests/mozilla/expected.html: Updated for newly fixed test.
  • kjs/array_object.cpp: (ArrayProtoFunc::ArrayProtoFunc):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype): (BooleanProtoFunc::BooleanProtoFunc):
  • kjs/bool_object.h:
  • kjs/date_object.cpp: (KJS::DateProtoFunc::DateProtoFunc): (KJS::DateObjectImp::DateObjectImp): (KJS::DateObjectFuncImp::DateObjectFuncImp):
  • kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): (ErrorProtoFunc::ErrorProtoFunc):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::FunctionImp::FunctionImp): (KJS::GlobalFuncImp::GlobalFuncImp):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionPrototype::FunctionPrototype): (FunctionProtoFunc::FunctionProtoFunc): (FunctionProtoFunc::callAsFunction):
  • kjs/function_object.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject): (KJS::InternalFunctionImp::InternalFunctionImp):
  • kjs/internal.h: (KJS::InternalFunctionImp::functionName):
  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::HashEntryFunction::HashEntryFunction): (KJS::HashEntryFunction::implementsCall): (KJS::HashEntryFunction::toBoolean): (KJS::HashEntryFunction::implementsHasInstance): (KJS::HashEntryFunction::hasInstance):
  • kjs/math_object.cpp: (MathFuncImp::MathFuncImp):
  • kjs/math_object.h:
  • kjs/number_object.cpp: (NumberPrototype::NumberPrototype): (NumberProtoFunc::NumberProtoFunc):
  • kjs/number_object.h:
  • kjs/object.cpp: (KJS::JSObject::putDirectFunction): (KJS::Error::create):
  • kjs/object.h:
  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): (ObjectProtoFunc::ObjectProtoFunc):
  • kjs/object_object.h:
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::RegExpProtoFunc):
  • kjs/regexp_object.h:
  • kjs/string_object.cpp: (StringProtoFunc::StringProtoFunc): (StringObjectImp::StringObjectImp): (StringObjectFuncImp::StringObjectFuncImp):
  • kjs/string_object.h:
11:47 PM Changeset in webkit [12910] by ggaren
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by Darin, Geoff.

Added a page about leakhunting, based on the info Sullivan gave in two blogposts about it. (posts 20 and 24)

Added this page to the menu, adding in an extra section header

11:46 PM Changeset in webkit [12909] by darin
  • 18 edits in trunk/WebCore

Reviewed by Eric.

  • css/css_base.h: (WebCore::CSSSelector::append): Replaced recursive implementation with an iterative one. (WebCore::StyleBaseImpl::StyleBaseImpl): Changed to be a Shared, not a TreeShared; parents now ref children as needed. This change was vital to fix the storage leaks. Also removed unused multiLength bool. (WebCore::StyleBaseImpl::parent): Added. Needed now that there's no TreeShared base class. (WebCore::StyleBaseImpl::setParent): Ditto. (WebCore::StyleBaseImpl::insertedIntoParent): Added. Hook for notification when added to a parent -- used by import style rules. (WebCore::StyleListImpl::StyleListImpl): Changed to use a Vector instead of a QPtrList for children. Slower for dynamic insert and remove for the DOM API, faster and more efficient for everything else.
  • css/css_base.cpp: (WebCore::StyleListImpl::append): Now calls insertedIntoParent and uses Vector. (WebCore::StyleListImpl::insert): Added. Calls insertedIntoParent. (WebCore::StyleListImpl::remove): Added.
  • css/css_grammar.y: Removed obsolete "don't inline" stuff. Changed all code that creates new objects to use new functions on CSSParser. For CSSSelector, ValueList, Function, and Value, this means using new functions with a "floating" concept, but for reference-counted classes this just means asking the CSSParser to create the object instead of calling new. Remove all explicit "delete", which is now handled by the parser instead, which works when the Bison-generated parser fails too, not just when it hits error rules in the grammar.
  • css/css_ruleimpl.h:
  • css/css_ruleimpl.cpp: (WebCore::CSSImportRuleImpl::CSSImportRuleImpl): Remove call to init() which kicks off style sheet loading. We now do that when we are added to our parent instead of construction time. Also removed unused constructor. (WebCore::CSSImportRuleImpl::insertedIntoParent): Replaced init() with this function that does much the same thing at a different time. Changed code that sets m_loading to do it in a simple way that doesn't need a big comment. (WebCore::CSSMediaRuleImpl::insertRule): Use RefPtr.
  • css/css_stylesheetimpl.cpp: (StyleSheetImpl::StyleSheetImpl): Pass 0 for parent explicitly since the empty constructor was removed in the other patch. (CSSStyleSheetImpl::CSSStyleSheetImpl): Remove code to set up m_lstChildren; that's now handled by the base class. (CSSStyleSheetImpl::insertRule): Use length() instead of m_listChildren->count() and insert instead of m_lstChildren->insert. Also use RefPtr for the result of parseRule. (CSSStyleSheetImpl::addRule): Use length() instead of m_lstChildren->count(). (CSSStyleSheetImpl::deleteRule): Use length() instead of checking the result of take() for 0. Use remove() instead of m_lstChildren->take(). (CSSStyleSheetImpl::parseString): Use setStrictParsing instead of going at the strictParsing data member directly. (CSSStyleSheetImpl::isLoading): Use length() and item() instead of m_lstChildren->first() and m_lstChildren->next().
  • css/css_valueimpl.h: Add an include of QPtrList now that it's not used in any included file. Also added a constructor for CSSValueImpl, now that StyleBaseImpl has no empty constructor.
  • css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclarationImpl::setProperty): Use useStrictParsing() instead of looking at the strictParsing data member directly. (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration): Ditto. (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty): Ditto. (WebCore::CSSMutableStyleDeclarationImpl::setCssText): Ditto.
  • css/cssparser.h: (WebCore::ValueList): Changed to use a Vector and an index rather than using a QPtrList. (WebCore::CSSParser): Changed parseRule to return a PassRefPtr, removed the createStyleDeclaration function since that's now handled by createStyleRule, made clearProperties be private, and added a suite of functions to create the objects formerly made with "new" in the Bison grammar. Also put the Units enum here in the header, and added an operator so they can be or'ed together while staying with the enum type so we can use Units instead of int for a function arg.
  • css/cssparser.cpp: (WebCore::ValueList::~ValueList): Changed to use Vector. (WebCore::CSSParser::CSSParser): Removed initializer for rule now that it's a RefPtr. (WebCore::CSSParser::~CSSParser): Added code to delete all the items in the sets that track floating objects. Also removed an unneeded check before callling clearProperties. (WebCore::CSSParser::parseSheet): Removed "delete rule" since rule is now a RefPtr. (WebCore::CSSParser::parseRule): Changed code to use rule.release() since rule is now a RefPtr and this function now returns a PassRefPtr. (WebCore::CSSParser::parseValue): Removed "delete rule" since rule is now a RefPtr. (WebCore::CSSParser::parseColor): Ditto. (WebCore::CSSParser::parseDeclaration): Ditto. (WebCore::CSSParser::validUnit): Made this a static class member instead of a local function so it can be used by the SVG parser code. Also updated to use the new ValueList class that uses Vector. (WebCore::CSSParser::parse4Values): Updated to new ValueList. (WebCore::CSSParser::parseContent): Ditto. (WebCore::skipCommaInDashboardRegion): Ditto. (WebCore::CSSParser::parseDashboardRegions): Ditto. (WebCore::CSSParser::parseShape): Ditto. (WebCore::CSSParser::parseColorFromValue): Ditto. (WebCore::BorderImageParseContext::commitBorderImage): Ditto. (WebCore::CSSParser::createFloatingSelector): Added. Puts selector into floating set. (WebCore::CSSParser::sinkFloatingSelector): Added. Removes from floating set. (WebCore::CSSParser::createFloatingValueList): Added. Puts list into floating set. (WebCore::CSSParser::sinkFloatingValueList): Added. Removes from floating set. (WebCore::CSSParser::createFloatingFunction): Added. Puts function into floating set. (WebCore::CSSParser::sinkFloatingFunction): Added. Removes from floating set. (WebCore::CSSParser::sinkFloatingValue): Added. Removes function from floating set if value contains a function pointer. (WebCore::CSSParser::createMediaList): Added. Puts list in a vector of RefPtrs kept by the parser, so the object won't end up floating. (WebCore::CSSParser::createImportRule): Ditto. (WebCore::CSSParser::createMediaRule): Ditto. (WebCore::CSSParser::createRuleList): Ditto. (WebCore::CSSParser::createStyleRule): Ditto. The properties come from the parser's global state instead of from a parameter.
  • khtml/xsl/xsl_stylesheetimpl.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): Initialize the new m_stylesheetDocTaken bool to false. Also remove code to set up m_lstChildren since the base class takes care of that now. (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): Only call xmlFreeDoc if the document was not taken by libxslt. We used to leak XSLStyleSheetImpl objects, which is why we didn't notice this before; we'll try to double free without this change. (WebCore::XSLStyleSheetImpl::isLoading): Use length() and item() instead of m_lstChildren->first() and m_lstChildren->next(). (WebCore::XSLStyleSheetImpl::clearDocuments): Ditto. (WebCore::XSLStyleSheetImpl::parseString): Only call xmlFreeDoc if the document was not taken by libxslt. Also set m_stylesheetDocTaken for the new document. (WebCore::XSLStyleSheetImpl::loadChildSheet): Use RefPtr and append instead of m_lstChildren->append. (WebCore::XSLStyleSheetImpl::compileStyleSheet): Set m_stylesheetDocTaken to true if xsltParseStylesheetDoc is successful, since the stylesheet then owns the document. (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): Use length() and item() instead of m_lstChildren->first() and m_lstChildren->next(). (WebCore::XSLStyleSheetImpl::markAsProcessed): Set m_stylesheetDocTaken, since when this is called, the document is returned to libxslt which then attaches it to a stylesheet or parent document.
  • ksvg2/css/KSVGCSSParser.cpp: Changed to compile as separate file instead of being included in cssparser.cpp. (WebCore::CSSParser::parseSVGPaint): Take out unnnecessary check of number of args. Everything works fine without that check, and otherwise I'd have to change it for the change in data structure. (WebCore::CSSParser::parseSVGColor): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added KSVGCSSParser.cpp.
  • fixed another leak found by run-webkit-leaks --leaks
  • kwq/KWQLoader.mm: (KWQServeRequest): Delete the job if we can't do the I/O, because the caller is passing ownership to us.
  • updated other code to use new Vector insert and remove
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::removeFromVector): Changed to use Vector's remove. (WebCore::HTMLFormElementImpl::registerFormElement): Changed to use Vector's insert.
11:43 PM Changeset in webkit [12908] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin, with help from Eric, Maciej.

  • More changes to support super-accurate JS iBench. Doesn't work on Windows. (Doesn't break Windows, either.) I've filed [​http://bugzilla. opendarwin.org/show_bug.cgi?id= 7399] about that.
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Print line numbers with exception output
  • kjs/testkjs.cpp: Changed " *" to "* " because Eric says that's the way we roll with .cpp files. (StopWatch::StopWatch): New class. Provides microsecond-accurate timings. (StopWatch::~StopWatch): (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS): (TestFunctionImp::callAsFunction): Added missing return statement. Fixed up "run" to use refactored helper functions. Removed bogus return statement from "quit" case. Made "print" output to stdout instead of stderr because that makes more sense, and PERL handles stdout better. (main): Factored out KXMLCore unit tests. Removed custom exception printing code because the interpreter prints exceptions for you. Added a "delete" call for the GlobalImp we allocate. (testIsInteger): New function, result of refacotring. (createStringWithContentsOfFile): New function, result of refactoring. Renamed "code" to "buffer" to match factored-out-ness.
11:29 PM Changeset in webkit [12907] by darin
  • 11 edits
    4 adds in trunk

LayoutTests:

  • editing/selection/move-by-character-6.html: Added.
  • editing/selection/move-by-character-6-expected.txt: Added.
  • editing/selection/move-by-character-6-expected.checksum: Added.
  • editing/selection/move-by-character-6-expected.png: Added.

WebCore:

Collaborated with Graham Dennis <​Graham.Dennis@gmail.com> on this.

Test: editing/selection/move-by-character-6.html

The trick was to draw the focus ring clipped to a list of rectangles instead
of clipped to exactly one.

  • kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing.
  • kwq/KWQPainter.mm: (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from an NSBezierPath to a CGMutablePathRef. (WebCore::QPainterPrivate::~QPainterPrivate): Ditto. (WebCore::QPainter::initFocusRing): Removed color parameter, and made a CGPath instead of an NSBezierPath. (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath. (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to use new bridge method to draw the focus ring. (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath.
  • kwq/WebCoreGraphicsBridge.h:
  • kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced setFocusRingStyle: method with this one.
  • rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing):
  • rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): Pass color to drawFocusRing instead of initFocusRing.
  • fixed message on exit from the other patch I just landed
  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Renamed and made this leak intentionally.

WebKit:

Collaborated with Graham Dennis <​Graham.Dennis@gmail.com> on this.

  • WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced the old bridge function that set up style with this one that renders a path.
10:59 PM Changeset in webkit [12906] by darin
  • 108 edits
    2 moves
    1 add
    12 deletes in trunk/WebCore

Reviewed by Hyatt.

  • moved Cursor into the platform directory from KWQ
  • removed a lot of other unneeded stuff from KWQ
  • platform/Cursor.h: Added.
  • platform/mac/CursorMac.mm: Added.
  • platform/mac/CursorWin.cpp: Added.
  • kwq/KWQBuffer.cpp: Removed.
  • kwq/KWQBuffer.h: Removed.
  • kwq/KWQCursor.h: Removed.
  • kwq/KWQCursor.mm: Removed.
  • kwq/KWQIODevice.h: Removed.
  • kwq/KWQKCursor.h: Removed.
  • kwq/KWQKCursor.mm: Removed.
  • kwq/KWQKDebug.h: Removed.
  • kwq/KWQSignalStubs.cpp: Removed.
  • ForwardingHeaders/kcursor.h: Removed.
  • ForwardingHeaders/kdebug.h: Removed.
  • ForwardingHeaders/qbuffer.h: Removed.
  • kwq/KWQEvent.h: Removed unused constants and types QCustomEvent, QFocusEvent, QHideEvent, QShowEvent, QContextMenuEvent, and QResizeEvent.
  • kwq/KWQLoader.h: Removed KWQLoader class since signals are no longer needed.
  • kwq/KWQLoader.mm: Ditto.
  • kwq/KWQNamespace.h: Removed DontClip, ShowPrefix, WordBreak, LayoutDirection, LeftToRight, RightToLeft, RasterOp, CopyROP, OrROP, and XorROP.
  • kwq/KWQObject.h: Removed blockSignals, sender, _signalsBlocked, _sender, and KWQObjectSenderScope.
  • kwq/KWQObject.cpp: (QObject::QObject): Removed _signalsBlocked. (QObject::connect): Removed special-case signals to not complain about. All of them were either unused, converted to non-signal functions, or in one case (slotScrollBarMoved) turned into a FIXME.
  • kwq/KWQPainter.h: Removed rasterOp and setRasterOp.
  • kwq/KWQPainter.mm: Ditto.
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.cpp: (KWQSignal::disconnect): Removed special cases for various signals; all are now using plain function calls instead.
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.cpp: Removed slots that are no longer needed because they are using plain function calls instead of signals.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Updated for changed files.
  • bridge/mac/FrameViewMac.mm: Moved the contents of KWQKHTMLView.cpp in here.
  • bridge/mac/KWQKHTMLView.cpp: Removed.
  • bridge/mac/MacFrame.h: Removed signals, changed setStatusBarText to take String instead of QString.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): Removed signals. (WebCore::MacFrame::setStatusBarText): Changed parameter type. (WebCore::MacFrame::openURLFromPageCache): Removed parameter from started function. (WebCore::MacFrame::khtmlMouseMoveEvent): Changed from QCursor() to pointerCursor().
  • dom/DocumentImpl.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Removed signals. (WebCore::DocumentImpl::implicitOpen): Ditto. (WebCore::DocumentImpl::determineParseMode): Removed a use of kdDebug. (WebCore::DocumentImpl::finishedParsing): Added. Does a setParsing(false) and then calls finishedParsing on the frame. Replaces the old finishedParsing signal.
  • dom/xml_tokenizer.h:
  • dom/xml_tokenizer.cpp: Removed the finishedParsing signal since it's not just a function on the document. (WebCore::XMLTokenizer::finish): Call the function instead of emitting the signal.
  • khtml/html/htmlparser.h:
  • khtml/html/htmlparser.cpp: Moved the parser inside the WebCore namespace.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::end): Updated to call finishedParsing function on document rather than emitting a signal.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Use QEvent instead of QFocusEvent. (-[KWQPopUpButton resignFirstResponder]): Ditto.
  • kwq/KWQFileButton.mm: (KWQFileButton::focusChanged): Ditto.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Ditto. (-[KWQTableView resignFirstResponder]): Ditto.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Ditto. (-[KWQSlider resignFirstResponder]): Ditto.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Ditto. (-[KWQTextAreaTextView resignFirstResponder]): Ditto.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Ditto.
  • kwq/KWQTextStream.h: Removed the mode parameter from the QTextStream constructor. Removed the QTextIStream and QTextOStream classes.
  • kwq/KWQTextStream.cpp: (QTextStream::QTextStream): Removed the mode parameter.
  • loader/CachedCSSStyleSheet.h: Changed to take a ByteArray instead of a QBuffer.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data): Ditto.
  • loader/CachedImage.h: Ditto.
  • loader/CachedImage.cpp: (WebCore::CachedImage::data): Ditto.
  • loader/CachedObject.h: Ditto.
  • loader/CachedScript.h: Ditto.
  • loader/CachedScript.cpp: (WebCore::CachedScript::data): Ditto.
  • loader/CachedXBLDocument.h: Ditto.
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): Ditto.
  • loader/CachedXSLStyleSheet.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data): Ditto.
  • loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress): Added a call to loadDone on the frame. Replaces the requestFailed and requestDone signals.
  • loader/DocLoader.h: Removed include of <qbuffer.h>.
  • loader/Request.h:
  • loader/Request.cpp: Updated to use ByteArray instead of QBuffer.
  • loader/loader.h: Removed unused signals.
  • loader/loader.cpp: (WebCore::Loader::Loader): Removed use of KWQLoader. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::load): Removed code to emit unused requestStarted signal. (WebCore::Loader::slotFinished): Removed code to emit requestFailed and requestDone signals, now handled by DocLoader::setLoadInProgress(false). (WebCore::Loader::slotReceivedResponse): Use ByteArray instead of QBuffer. (WebCore::Loader::slotData): Ditto.
  • page/Frame.h: Removed setURLCursor, urlCursor, slotRestoreData, slotIncZoom, slotDecZoom, slotLoadImages, slotPartRemoved, slotActiveFrameChanged, slotChildURLRequest, slotShowDocument, slotAutoScroll, slotPrintFrame, slotSelectAll, slotProgressUpdate, slotJobPercent, slotJobSpeed.connectChild, disconnectChild, and changed a number of others from slots to plain old functions.
  • page/Frame.cpp: (WebCore::Frame::Frame): Don't connect to loader signals. (WebCore::Frame::~Frame): Don't disconnect from loader signals. (WebCore::Frame::didOpenURL): Call started function instead of emitting started signal. Don't connect to speed and percent signals (which never existed in WebCore anyway). (WebCore::Frame::stopLoading): Call finishedParsing function instead of calling slotFinishedParsing. (WebCore::Frame::executeScript): Removed redundant checks and let submitFormAgain do the checking. (WebCore::Frame::clear): Removed code to disconnect from finishedParsing signal; we now use a function. Also removed loop that calls disconnectChild, becase again we use functions now instead of signals. (WebCore::Frame::setDocument): Remove code to disconnect and connect to the finishedParsing signal. (WebCore::Frame::begin): Remove code to connect to the finishedParsing signal. (WebCore::Frame::finishedParsing): Moved code that does setParsing(false) into the document class. Also renamed from slotFinishedParsing. (WebCore::Frame::loadDone): Renamed from slotLoaderRequestDone. (WebCore::Frame::checkCompleted): Changed to call the completed function instead of emitting one of the two completed signals. (WebCore::Frame::loadSubframe): Removed call to connectChild because we now use functions instead of signals. Also change the call to completed to pass false instead of true. (WebCore::Frame::submitFormAgain): Change function around so we are less likely to leak if something strange happens inside submitForm. (WebCore::Frame::submitForm): Remove code to connect signal. We now call submitFormAgain from inside the completed function. (WebCore::Frame::parentCompleted): Renamed from slotParentCompleted. No longer a slot, now called from completed. (WebCore::Frame::childCompleted): Renamed from slotChildCompleted. (WebCore::Frame::setJSStatusBarText): Removed "emit" from function call. Changed to use String instead of QString. (WebCore::Frame::setJSDefaultStatusBarText): Ditto. (WebCore::Frame::sendResizeEvent): Changed to send DOM event directly instead of creating a QResizeEvent to send along to the FrameView. (WebCore::Frame::scrollToAnchor): Changed to not pass a parameter to the started function, which no longer takes one. (WebCore::Frame::frameDetached): Removed code that calls disconnectChild, since we no longer use signals. (WebCore::Frame::completed): Added. Calls childCompleted, parentCompleted, and submitFormAgain. (WebCore::Frame::setStatusBarText): Added. (WebCore::Frame::started): Added. Sets the complete flag to false for the frame and all its ancestors, which is what slotChildStarted did recursively.
  • page/FramePrivate.h: Removed m_activeFrame and changed m_kjsStatusBarText and m_kjsDefaultStatusBarText to String from QString.
  • page/FrameView.h: Removed resizeEvent, focusInEvent, focusOutEvent, and slotPaletteChanged. Changed cleared from a signal to a private function and slotScrollBarMoved to a private function named scrollBarMoved.
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Removed connect call here that was connecting a signal that's nonexistent in WebCore; we'll want to rig it up later. (WebCore::FrameView::~FrameView): Added a call to setQWidget(0) here to replace something that was done with a signal before. (WebCore::FrameView::clear): Call cleared as a function rather than a signal. (WebCore::selectCursor): Changed to use Cursor instead of QCursor. (WebCore::FrameView::scrollBarMoved): Renamed this function, which is never called. Added a FIXME about calling it. (WebCore::FrameView::cleared): Added. Calls viewCleared on the owner part, which used to be done with a signal.
  • platform/Widget.h: Changed to Cursor from QCursor.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setCursor): Ditto.
  • rendering/render_frames.h:
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Removed cursor-setting code here. We might want to use resize cursors for frames again, but it was mostly disabled anyway and it's not clear which cursors to use. (WebCore::RenderPart::setWidget): Removed code to connect to the cleared signal. Instead, FrameView takes care of it directly. (WebCore::RenderPart::viewCleared): Renamed from slotViewCleared. (WebCore::RenderFrame::viewCleared): Ditto. (WebCore::RenderPartObject::viewCleared): Ditto.
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): Removed use of WordBreak, which doesn't exist in WebCore text rendering. (WebCore::RenderImage::paint): Ditto.
  • rendering/render_list.cpp: (RenderListMarker::paint): Removed use of DontClip, which doesn't exist in WebCore text rendering. Also removed incorrect use of references to temporaries for the ". " and " ." strings.
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): Removed call to setRasterOp since it is a no-op in WebCore's painter. Added a FIXME. (WebCore::RenderObject::information): Remove mode parameter to QTextStream.
  • rendering/render_replaced.h: Removed slotWidgetDestructed, made setQWidget public,
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setQWidget): Removed code to connect slotWidgetDestructed to the destroyed signal. Instead FrameView calls setQWidget(0) on us. (WebCore::RenderWidget::eventFilter): Removed use of QFocusEvent::reason, which is never "popup" in WebCore.
  • WebCore+SVG/kdom.h:
  • css/css_stylesheetimpl.cpp:
  • css/css_valueimpl.cpp:
  • css/cssparser.cpp:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/RenderPath.cpp:
  • khtml/ecma/xmlserializer.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • ksvg2/svg/SVGTransformImpl.cpp:
  • platform/StringImpl.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/render_box.cpp:
  • rendering/render_canvas.cpp:
  • rendering/render_flow.cpp:
  • rendering/render_form.cpp:
  • rendering/render_layer.cpp:
  • rendering/render_style.cpp: Removed includes of <kdebug.h>.
  • css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSRule::putValueProperty):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMDocument::getValueProperty):
  • khtml/ecma/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::Clipboard::getValueProperty): (KJS::Clipboard::putValueProperty):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::getValueProperty): (KJS::KJS::HTMLDocument::putValueProperty): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::areaGetter): (KJS::KJS::HTMLElementFunction::callAsFunction):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMTreeWalker::getValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::Window::scheduleClose): (KJS::Window::isSafeScript): (KJS::Window::clear): (KJS::LocationFunc::callAsFunction): (KJS::History::getValueProperty):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::finishedParsing):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValueInSpecifiedUnits): Removed use of kdWarning, kdDebug, etc.
10:28 PM Changeset in webkit [12905] by mjs
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • port QString to win32
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/QString.cpp: (strncasecmp): (QString::mid): (freeHandle):
4:16 PM Changeset in webkit [12904] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-02-20 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix "Copy ICU DLLs..." phase.

12:27 PM Changeset in webkit [12903] by eseidel
  • 3 edits in trunk/WebCore

2006-02-20 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
Also cleaned up spacing a little.

No layout test possible (local loads are non incremental).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::slotData):
12:20 PM Changeset in webkit [12902] by thatcher
  • 1 edit in trunk/Makefile.shared
  • Makefile.shared: Remove use of XcodeOptionStringNoConfig. We don't need it because commands like "make debug" have a side effect of setting the current configuration anyway.
1:29 AM Changeset in webkit [12901] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Timers were stopping firing after a while.

My testing makes this look like a CFRunLoopTimer bug, and it would be nice to reproduce
this with a standalone test and report it to the CF team, but in the mean time, change
to create a new timer each time instead of reusing the existing timer.

  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFiredFunction): Added an assertion. (WebCore::setSharedTimerFireTime): Destroy the existing timer and create a new one every time. Also create a non-repeating timer rather than a repeating timer. (WebCore::stopSharedTimer): Destroy the existing timer rather than setting its fire date far into the future.
1:28 AM Changeset in webkit [12900] by mjs
  • 2 edits
    1 add in trunk/WebKitTools

Reviewed by Darin.

  • Added install-win-extras script which installs some extra programs and libraries, and does Windows first-time setup.
  • Scripts/build-webkit: Add a newline between build results.
  • Scripts/install-win-extras: Added.

Feb 19, 2006:

10:37 AM Changeset in webkit [12899] by darin
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Added WKDrawFocusRing.
  • libWebKitSystemInterface.a: Ditto.
9:37 AM Changeset in webkit [12898] by darin
  • 13 edits in trunk

WebCore:

Reviewed by Maciej.

  • cut out a little unneeded bridge code
  • bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method and changed it to return a page bridge. Also made createModalDialogWithURL: method return a page bridge. Removed the mainFrame and webView methods.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame. (-[WebCoreFrameBridge setFrameNamespace:]): Ditto. (-[WebCoreFrameBridge frameNamespace]): Ditto. (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto. (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto. (-[WebCoreFrameBridge findFrameNamed:]): Ditto. (-[WebCoreFrameBridge installInFrame:]): Ditto.
  • bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method on the frame bridge.
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Update to use a page bridge instead of frame bridge.

WebKit:

Reviewed by Maciej.

  • cut out a little unneeded bridge code
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge webView]): Added. Helper, since the WebCore side of the bridge no longer has this method. (-[WebFrameBridge createWindowWithURL:]): Removed the frameName parameter -- this is now handled on the WebCore side. Also return a page bridge instead of a frame bridge. (-[WebFrameBridge createModalDialogWithURL:]): Changed to return a page bridge instead of a frame bridge.
  • WebView/WebFrame.m: (-[WebFrame webView]): Change to get the webView from the page bridge instead of the frame bridge, since it's a per-page thing.
  • WebView/WebView.m: Removed init method since it just does what the default does (calls initWithFrame: with a zero rect). (-[WebView initWithCoder:]): Added checking so that if the obejcts have the wrong type we will fail gracefully instead of hitting "method not found" and the like. (-[WebView setPreferencesIdentifier:]): Fix storage leak. The WebPreferences object was not released. (-[WebView mainFrame]): Removed excess "return nil". (-[WebView _pageBridge]): Added. Helper to let you go from the WebView to the bridge from outside the WebView class.
  • WebView/WebViewInternal.h: Put _pageBridge into an internal header.
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Added. Replaces "webView" as public method to tell the WebCore side about the view everything's embedded in.
  • other cleanup
  • WebCoreSupport/WebPageBridge.h: Removed some unneeded declarations.
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Rearrange code so it doesn't have to get the main frame twice.
9:20 AM Changeset in webkit [12897] by darin
  • 4 edits in trunk/JavaScriptCore
  • renamed ERROR to LOG_ERROR to fix build presumably Maciej had this change and forgot to land it
  • kjs/collector.cpp: Removed now-unneeded #undef ERROR.
  • kxmlcore/Assertions.h: Renamed ERROR to LOG_ERROR.
  • kxmlcore/FastMalloc.cpp: Changed MESSAGE macro to use LOG_ERROR.
5:35 AM Changeset in webkit [12896] by mjs
  • 19 edits in trunk/WebCore

Rubber-stamped by Anders.


  • renamed ERROR to LOG_ERROR because some operating systems define ERROR in a system header
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::passMouseDownEventToWidget):
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • editing/Selection.cpp: (WebCore::Selection::toRange):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFEBlendQuartz::getCIFilter): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createResource):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): (KConfig::readUnsignedNumEntry):
  • kwq/KWQLineEdit.mm: (KWQNSTextAlignmentForAlignmentFlags):
  • kwq/KWQObject.cpp: (QObject::connect):
  • kwq/KWQPainter.mm: (WebCore::QPainter::restore): (WebCore::QPainter::drawFocusRing):
  • kwq/KWQRegExp.cpp: (QRegExp::KWQRegExpPrivate::compile): (QRegExp::match):
  • kwq/KWQSignal.cpp: (KWQSignal::connect): (KWQSignal::disconnect):
  • kwq/KWQSlot.cpp: (KWQSlot::KWQSlot):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::createICUConverter): (KWQTextDecoder::convertUsingICU):
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]): (-[WebCoreTextRendererFactory isFontFixedPitch:]): (-[WebCoreTextRendererFactory rendererWithFont:]):
  • page/Frame.cpp: (WebCore::Frame::paint):
1:49 AM Changeset in webkit [12895] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Handle tests starting with "​http://" as real URLs, not file system paths.
1:42 AM Changeset in webkit [12894] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/webkitdirs.pm: only call chomp if PBXProductDirectory is configured.
1:41 AM Changeset in webkit [12893] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Fix bogus line in ChangeLog.

Feb 18, 2006:

7:37 PM Changeset in webkit [12892] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix win32 build
  • css/css_grammar.y:
  • khtml/html/html_objectimpl.cpp: #ifdef out all bindings code (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl): (WebCore::HTMLObjectElementImpl::detach):
  • khtml/html/html_objectimpl.h:
5:34 PM Changeset in webkit [12891] by darin
  • 4 edits in trunk/WebKitSite

Reviewed by Darin.

Fixed Bugzilla URL's


  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/xslt/index.html:
5:31 PM Changeset in webkit [12890] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Test: fast/js/toString-exception.html

Reviewed by Maciej.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Remove the object from the visited elements set before returning an error.

LayoutTests:

Reviewed by Maciej.

  • fast/js/resources/toString-exception.js: Added.
  • fast/js/toString-exception-expected.txt: Added.
  • fast/js/toString-exception.html: Added.
5:24 PM Changeset in webkit [12889] by darin
  • 3 edits in trunk/WebKitSite

Reviewed by Darin.

Made line-height global instead of just for p

Editing:
fixed bugzilla link, added starting <p> to first paragraph
removed paragraph about tab-stops

  • css/main.css:
  • projects/editing/index.html:
4:21 PM Changeset in webkit [12888] by lypanov
  • 3 edits
    4 adds in trunk

2006-02-18 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

Testcase:

svg/custom/text-gradient-no-content.svg

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::teardown):

2006-02-18 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

  • svg/custom/text-gradient-no-content.svg: Added.
4:20 PM Changeset in webkit [12887] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/commit-log-editor: Added.
3:48 PM Changeset in webkit [12886] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Vector.h: Added "moveOverlapping", which is used in both insert and remove to slide elements within the vector. Also added "insert" and "remove" functions.
10:55 AM Changeset in webkit [12885] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4448212> _accessibilityTableCell please remove this.

Remove override of a defamed AX method.

  • kwq/KWQListBox.mm: Dump _accessibilityTableCell.
12:21 AM Changeset in webkit [12884] by mjs
  • 4 edits in trunk/WebKit

Not reviewed.


  • fix build broken by my last checkin, the remaining code was not doing anything.
  • WebView/WebDataSource.m:
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _createPageCacheForItem:]):

Feb 17, 2006:

9:47 PM Changeset in webkit [12883] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/ex-after-font-variant-expected.checksum: Added.
  • fast/css/ex-after-font-variant-expected.png: Added.
  • fast/css/ex-after-font-variant-expected.txt: Added.
  • fast/css/ex-after-font-variant.html: Added.

WebCore:

Test: fast/css/ex-after-font-variant.html

Reviewed by Darin.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): Added CSS_PROP_FONT_VARIANT to the properties that need to be applied first, since it dirties the font.
9:14 PM Changeset in webkit [12882] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • removed a few unused fields and methods of WebDataSource
  • WebView/WebDataSource.m:
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebView.m: (+[WebView _MIMETypeForFile:]): (-[WebView _updateWebCoreSettingsFromPreferences:]):
4:15 PM Changeset in webkit [12881] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Make Win32 have the same default "WebKitBuild" directory behavior.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
4:06 PM Changeset in webkit [12880] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Mention other non-function brace cases.
3:48 PM Changeset in webkit [12879] by justing
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Reviewed by eric


This test appears to be occasionally hanging. Disabling it while
I figure out why.

  • editing/selection/drag-to-contenteditable-iframe.html: Removed.
  • editing/selection/drag-to-contenteditable-iframe.html-disabled: Added.
3:36 PM Changeset in webkit [12878] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by Beth.

  • Scripts/build-webkit: make win32 actually report errors
3:08 PM Changeset in webkit [12877] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: Ignore quicktime plugin leaks
2:49 PM Changeset in webkit [12876] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: Ignore flash leaks
2:18 PM Changeset in webkit [12875] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Tim H.

Added left position and margin-bottom to blog footer.

  • css/main.css:
11:15 AM Changeset in webkit [12874] by adele
  • 3 edits in trunk/WebCore

Reviewed by Beth.

Adding isEdited/setEdited hooks so onChange will fire for the new text fields.

  • rendering/RenderTextField.cpp: (WebCore::m_dirty): (WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed. (WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
  • rendering/RenderTextField.h: (WebCore::RenderTextField::isEdited): (WebCore::RenderTextField::setEdited): (WebCore::RenderTextField::isTextField):
10:31 AM Changeset in webkit [12873] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

  • Fixed <rdar://problem/4448534> TOT REGRESSION: crash in KJS:: Bindings::Instance::deref when leaving page @ gigaom.com
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::~CInstance): Since we cache the class object globally, we shouldn't delete it, so don't.
1:54 AM Changeset in webkit [12872] by vicki
  • 7 edits in trunk/WebCore

Reviewed by Justin.


Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
  • rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
  • rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
  • rendering/render_replaced.h: Remove handleFocusOut().
  • rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.
1:49 AM Changeset in webkit [12871] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders Carlsson.

  • fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added.
  • fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
  • fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added.
  • fast/parser/nofoo-tags-inside-paragraph.html: Added.

WebCore:

Test: fast/parser/nofoo-tags-inside-paragraph.html

Reviewed by Anders Carlsson.

  • khtml/html/htmlparser.cpp: (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript as inline elements.
1:43 AM Changeset in webkit [12870] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/bugzilla-7235.html: Added.
  • rendering/render_box.cpp: (WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning relative to a relpositioned inline from RenderLayer::updateLayerPosition. (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
1:37 AM Changeset in webkit [12869] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/css/universal-hover-quirk-expected.checksum: Added.
  • fast/css/universal-hover-quirk-expected.png: Added.
  • fast/css/universal-hover-quirk-expected.txt: Added.
  • fast/css/universal-hover-quirk.html: Added.

WebCore:

Test: fast/css/universal-hover-quirk.html

Reviewed by Maciej.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active from matching anything in quirks mode.
1:31 AM Changeset in webkit [12868] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html

Reviewed by Dave Hyatt.

  • rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of resetBidiAtEnd now that the former is always correct. (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag. (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks caused by newlines as well. Added skipTrailingNewline flag.
12:02 AM Changeset in webkit [12867] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4193286> enabledPlugin returns a non-NULL object even when plugins are
disabled (4140)

  • khtml/ecma/kjs_navigator.cpp: (KJS::MimeType::getValueProperty): Only return a Plugin object for the "enabledPlugin" property if plugins are enabled. This matches what other browsers do.

Feb 16, 2006:

9:36 PM Changeset in webkit [12866] by thatcher
  • 28 edits
    2 adds in trunk/WebKitSite

Reviewed by Maciej.


Fixes PNGs with 8bit alpha on IE.

  • css/ie.css: attach the pngbehavior.htc to img tags
  • images/blank.png: Added.
  • index.html: add the width and height to the download img
  • pngbehavior.htc: Added.
5:08 PM Changeset in webkit [12865] by darin
  • 69 edits in trunk/WebCore

Reviewed by Eric and Justin.

  • bindings/objc/DOM.mm: (-[DOMDocument adoptNode:]): (-[DOMDocument createElement:]): (-[DOMDocument createDocumentFragment]): (-[DOMDocument createTextNode:]): (-[DOMDocument createComment:]): (-[DOMDocument createCDATASection:]): (-[DOMDocument createProcessingInstruction::]): (-[DOMDocument createEntityReference:]): (-[DOMDocument importNode::]): (-[DOMDocument createElementNS::]): (-[DOMDocument createRange]): (-[DOMDocument createCSSStyleDeclaration]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
  • bindings/objc/DOMEvents.mm: (-[DOMDocument createEvent:]):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::freeClipboard): (WebCore::MacFrame::setView): (WebCore::MacFrame::wheelEvent): (WebCore::MacFrame::openURLFromPageCache): (WebCore::MacFrame::mouseDownViewIfStillGood): (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::dispatchCPPEvent): (WebCore::MacFrame::mouseDown): (WebCore::MacFrame::mouseDragged): (WebCore::MacFrame::mouseUp): (WebCore::MacFrame::mouseMoved): (WebCore::MacFrame::sendContextMenuEvent): (WebCore::MacFrame::dispatchDragSrcEvent):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge convertNSRangeToDOMRange:]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge typingStyle]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): (WebCore::CSSComputedStyleDeclarationImpl::cssText): (WebCore::CSSComputedStyleDeclarationImpl::setCssText): (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): (WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue): (WebCore::CSSComputedStyleDeclarationImpl::removeProperty): (WebCore::CSSComputedStyleDeclarationImpl::setProperty): (WebCore::CSSComputedStyleDeclarationImpl::item): (WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties): (WebCore::CSSComputedStyleDeclarationImpl::copy): (WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
  • css/css_computedstyle.h:
  • css/css_grammar.y:
  • css/css_ruleimpl.cpp: (WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl): (WebCore::CSSStyleRuleImpl::setDeclaration):
  • css/css_ruleimpl.h: (DOM::CSSStyleRuleImpl::style): (DOM::CSSStyleRuleImpl::declaration):
  • css/css_valueimpl.cpp: (WebCore::propertyID): (WebCore::quoteStringIfNeeded): (WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue): (WebCore::CSSStyleDeclarationImpl::getPropertyValue): (WebCore::CSSStyleDeclarationImpl::getPropertyPriority): (WebCore::CSSStyleDeclarationImpl::getPropertyShorthand): (WebCore::CSSStyleDeclarationImpl::isPropertyImplicit): (WebCore::CSSStyleDeclarationImpl::setProperty): (WebCore::CSSStyleDeclarationImpl::removeProperty): (WebCore::CSSStyleDeclarationImpl::isPropertyName): (WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue): (WebCore::CSSMutableStyleDeclarationImpl::get4Values): (WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue): (WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue): (WebCore::CSSMutableStyleDeclarationImpl::removeProperty): (WebCore::CSSMutableStyleDeclarationImpl::setProperty): (WebCore::CSSMutableStyleDeclarationImpl::setStringProperty): (WebCore::CSSMutableStyleDeclarationImpl::setImageProperty): (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration): (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty): (WebCore::CSSMutableStyleDeclarationImpl::item): (WebCore::CSSMutableStyleDeclarationImpl::cssText): (WebCore::CSSMutableStyleDeclarationImpl::setCssText): (WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties): (WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet): (WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet): (WebCore::CSSMutableStyleDeclarationImpl::makeMutable): (WebCore::CSSMutableStyleDeclarationImpl::copy): (WebCore::CSSInheritedValueImpl::cssText): (WebCore::CSSInitialValueImpl::cssText): (WebCore::CSSValueListImpl::append): (WebCore::CSSValueListImpl::cssText): (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (WebCore::CSSPrimitiveValueImpl::cleanup): (WebCore::CSSPrimitiveValueImpl::setStringValue): (WebCore::CSSPrimitiveValueImpl::getStringValue): (WebCore::CSSPrimitiveValueImpl::parseString): (WebCore::CSSPrimitiveValueImpl::cssText): (WebCore::CSSImageValueImpl::CSSImageValueImpl): (WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl): (WebCore::CSSBorderImageValueImpl::cssText): (WebCore::FontFamilyValueImpl::FontFamilyValueImpl): (WebCore::FontFamilyValueImpl::cssText): (WebCore::FontValueImpl::cssText): (WebCore::ShadowValueImpl::ShadowValueImpl): (WebCore::ShadowValueImpl::cssText): (WebCore::CSSProperty::cssText):
  • css/css_valueimpl.h: (WebCore::CSSValueImpl::setCssText): (WebCore::CSSValueListImpl::item): (WebCore::CSSPrimitiveValueImpl::getFloatValue): (WebCore::CSSPrimitiveValueImpl::getCounterValue): (WebCore::CSSPrimitiveValueImpl::getRectValue): (WebCore::CSSPrimitiveValueImpl::getRGBColorValue): (WebCore::CSSPrimitiveValueImpl::getPairValue): (WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue): (WebCore::CSSPrimitiveValueImpl::): (WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl): (WebCore::CounterImpl::identifier): (WebCore::CounterImpl::listStyle): (WebCore::CounterImpl::separator): (WebCore::RectImpl::top): (WebCore::RectImpl::right): (WebCore::RectImpl::bottom): (WebCore::RectImpl::left): (WebCore::RectImpl::setTop): (WebCore::RectImpl::setRight): (WebCore::RectImpl::setBottom): (WebCore::RectImpl::setLeft): (WebCore::PairImpl::first): (WebCore::PairImpl::second): (WebCore::PairImpl::setFirst): (WebCore::PairImpl::setSecond): (WebCore::DashboardRegionImpl::DashboardRegionImpl): (WebCore::FontFamilyValueImpl::fontName): (WebCore::CSSProperty::CSSProperty): (WebCore::CSSProperty::value): (WebCore::CSSMutableStyleDeclarationImpl::setNode): (WebCore::CSSMutableStyleDeclarationImpl::setProperty): (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
  • css/cssparser.cpp: (CSSParser::createStyleDeclaration): (CSSParser::parseDashboardRegions):
  • css/cssparser.h: (WebCore::Value::): (WebCore::qString): (WebCore::domString): (WebCore::atomicString): (WebCore::ValueList::current): (WebCore::ValueList::next): (WebCore::CSSParser::current):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/DOMImplementationImpl.cpp: (DOM::DOMImplementationImpl::createDocument): (DOM::DOMImplementationImpl::instance):
  • dom/DOMImplementationImpl.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::~DocumentImpl): (WebCore::DocumentImpl::setDocType): (WebCore::DocumentImpl::createElement): (WebCore::DocumentImpl::createDocumentFragment): (WebCore::DocumentImpl::createTextNode): (WebCore::DocumentImpl::createComment): (WebCore::DocumentImpl::createCDATASection): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::createEntityReference): (WebCore::DocumentImpl::createEditingTextNode): (WebCore::DocumentImpl::createCSSStyleDeclaration): (WebCore::DocumentImpl::importNode): (WebCore::DocumentImpl::adoptNode): (WebCore::DocumentImpl::createElementNS): (WebCore::DocumentImpl::setTitle): (WebCore::DocumentImpl::createRange): (WebCore::DocumentImpl::createNodeIterator): (WebCore::DocumentImpl::createTreeWalker): (WebCore::DocumentImpl::setStyleSheet): (WebCore::DocumentImpl::setHoverNode): (WebCore::DocumentImpl::setActiveNode): (WebCore::DocumentImpl::setFocusNode): (WebCore::DocumentImpl::defaultView): (WebCore::DocumentImpl::createEvent): (WebCore::DocumentImpl::setHTMLWindowEventListener): (WebCore::DocumentImpl::addWindowEventListener): (WebCore::DocumentImpl::createHTMLEventListener): (WebCore::DocumentImpl::images): (WebCore::DocumentImpl::applets): (WebCore::DocumentImpl::embeds): (WebCore::DocumentImpl::objects): (WebCore::DocumentImpl::links): (WebCore::DocumentImpl::forms): (WebCore::DocumentImpl::anchors): (WebCore::DocumentImpl::all): (WebCore::DocumentImpl::windowNamedItems): (WebCore::DocumentImpl::documentNamedItems): (WebCore::DocumentImpl::getElementsByName):
  • dom/DocumentImpl.h: (WebCore::DocumentImpl::realDocType): (WebCore::DocumentImpl::createAttribute): (WebCore::DocumentImpl::title): (WebCore::DocumentImpl::styleSelector): (WebCore::DocumentImpl::setRestoreState): (WebCore::DocumentImpl::restoreState): (WebCore::DocumentImpl::view): (WebCore::DocumentImpl::docLoader): (WebCore::DocumentImpl::tokenizer): (WebCore::DocumentImpl::focusNode): (WebCore::DocumentImpl::hoverNode): (WebCore::DocumentImpl::activeNode): (WebCore::DocumentImpl::policyBaseURL): (WebCore::DocumentImpl::setPolicyBaseURL): (WebCore::DocumentImpl::): (WebCore::DocumentImpl::transformSourceDocument): (WebCore::DocumentImpl::domTreeVersion): (WebCore::DocumentImpl::decoder):
  • dom/NodeListImpl.cpp: (DOM::NodeListImpl::NodeListImpl): (DOM::NodeListImpl::~NodeListImpl): (DOM::NodeListImpl::recursiveLength): (DOM::NodeListImpl::recursiveItem): (DOM::NodeListImpl::itemById):
  • dom/NodeListImpl.h:
  • dom/dom2_eventsimpl.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/dom2_eventsimpl.h: (WebCore::operator!=):
  • dom/dom2_traversalimpl.cpp: (DOM::TraversalImpl::TraversalImpl): (DOM::NodeIteratorImpl::NodeIteratorImpl): (DOM::TreeWalkerImpl::TreeWalkerImpl):
  • dom/dom2_traversalimpl.h: (WebCore::TraversalImpl::root): (WebCore::TraversalImpl::filter): (WebCore::NodeIteratorImpl::referenceNode): (WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode): (WebCore::NodeIteratorImpl::setDetached): (WebCore::NodeIteratorImpl::document): (WebCore::TreeWalkerImpl::currentNode):
  • dom/dom_position.cpp: (WebCore::Position::computedStyle):
  • dom/dom_position.h:
  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • editing/ApplyStyleCommand.cpp: (WebCore::createFontElement): (WebCore::createStyleSpanElement): (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::updateStartEnd): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::extractTextDecorationStyle): (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): (WebCore::ApplyStyleCommand::computedFontSize):
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::style):
  • editing/EditCommand.cpp: (WebCore::EditCommandPtr::setTypingStyle): (WebCore::EditCommand::setTypingStyle): (WebCore::EditCommand::styleAtPosition):
  • editing/EditCommand.h: (WebCore::EditCommand::document): (WebCore::EditCommand::typingStyle):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::InsertLineBreakCommand): (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::computeAndStoreNodeDesiredStyle): (WebCore::NodeDesiredStyle::NodeDesiredStyle): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::NodeDesiredStyle::node): (WebCore::NodeDesiredStyle::style): (WebCore::ReplacementFragment::root):
  • editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::createDefaultParagraphElement): (WebCore::createBreakElement):
  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): (WebCore::createParagraphContentsFromString):
  • editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength):
  • editing/visible_text.h: (WebCore::isCollapsibleWhitespace): (WebCore::WordAwareIterator::range):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocumentProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLSelectCollection::put): (KJS::OptionConstructorImp::construct):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment): (WebCore::HTMLElementImpl::setInnerHTML): (WebCore::HTMLElementImpl::setOuterHTML): (WebCore::HTMLElementImpl::setOuterText):
  • khtml/html/HTMLElementImpl.h:
  • khtml/html/HTMLNameCollectionImpl.cpp: (WebCore::HTMLNameCollectionImpl::HTMLNameCollectionImpl): (WebCore::HTMLNameCollectionImpl::traverseNextItem):
  • khtml/html/HTMLNameCollectionImpl.h:
  • khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::createElement):
  • khtml/html/html_documentimpl.h: (WebCore::HTMLDocumentImpl::collectionInfo):
  • khtml/html/htmlfactory.cpp: (DOM::htmlConstructor): (DOM::headConstructor): (DOM::bodyConstructor): (DOM::baseConstructor): (DOM::linkConstructor): (DOM::metaConstructor): (DOM::styleConstructor): (DOM::titleConstructor): (DOM::frameConstructor): (DOM::framesetConstructor): (DOM::iframeConstructor): (DOM::formConstructor): (DOM::buttonConstructor): (DOM::inputConstructor): (DOM::isindexConstructor): (DOM::fieldsetConstructor): (DOM::labelConstructor): (DOM::legendConstructor): (DOM::optgroupConstructor): (DOM::optionConstructor): (DOM::selectConstructor): (DOM::textareaConstructor): (DOM::dlConstructor): (DOM::ulConstructor): (DOM::olConstructor): (DOM::dirConstructor): (DOM::menuConstructor): (DOM::liConstructor): (DOM::blockquoteConstructor): (DOM::divConstructor): (DOM::headingConstructor): (DOM::hrConstructor): (DOM::paragraphConstructor): (DOM::preConstructor): (DOM::basefontConstructor): (DOM::fontConstructor): (DOM::modConstructor): (DOM::anchorConstructor): (DOM::imageConstructor): (DOM::mapConstructor): (DOM::areaConstructor): (DOM::canvasConstructor): (DOM::appletConstructor): (DOM::embedConstructor): (DOM::objectConstructor): (DOM::paramConstructor): (DOM::scriptConstructor): (DOM::tableConstructor): (DOM::tableCaptionConstructor): (DOM::tableColConstructor): (DOM::tableRowConstructor): (DOM::tableCellConstructor): (DOM::tableSectionConstructor): (DOM::brConstructor): (DOM::quoteConstructor): (DOM::marqueeConstructor): (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlfactory.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::textCreateErrorCheck): (HTMLParser::commentCreateErrorCheck): (HTMLParser::headCreateErrorCheck): (HTMLParser::bodyCreateErrorCheck): (HTMLParser::framesetCreateErrorCheck): (HTMLParser::iframeCreateErrorCheck): (HTMLParser::formCreateErrorCheck): (HTMLParser::isindexCreateErrorCheck): (HTMLParser::selectCreateErrorCheck): (HTMLParser::ddCreateErrorCheck): (HTMLParser::dtCreateErrorCheck): (HTMLParser::nestedCreateErrorCheck): (HTMLParser::nestedStyleCreateErrorCheck): (HTMLParser::tableCellCreateErrorCheck): (HTMLParser::tableSectionCreateErrorCheck): (HTMLParser::noembedCreateErrorCheck): (HTMLParser::noframesCreateErrorCheck): (HTMLParser::noscriptCreateErrorCheck): (HTMLParser::mapCreateErrorCheck): (HTMLParser::getNode):
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • khtml/html/htmltokenizer.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::createDocumentType): (SVGDOMImplementationImpl::createDocument): (SVGDOMImplementationImpl::createCSSStyleSheet):
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::createElement): (WebCore::SVGDocumentImpl::dispatchZoomEvent): (WebCore::SVGDocumentImpl::dispatchKeyEvent): (WebCore::SVGDocumentImpl::dispatchUIEvent): (WebCore::SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp: (WebCore::SVGElementImpl::addSVGEventListener):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::addSVGWindowEventListner):
  • page/Frame.cpp: (WebCore::Frame::view): (WebCore::Frame::begin): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionHasStyle): (WebCore::Frame::selectionStartHasStyle): (WebCore::Frame::selectionStartStylePropertyValue): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::forceLayout): (WebCore::Frame::sendResizeEvent): (WebCore::Frame::sendScrollEvent): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart):
  • page/FramePrivate.h:
  • page/FrameTree.h: (WebCore::FrameTree::name):
4:34 PM Changeset in webkit [12864] by thatcher
  • 2 edits in tags/JavaScriptCore-521.7.1/JavaScriptCore

Adding -Wno-deprecated-declarations to the ObjC files. Versioning.

4:32 PM Changeset in webkit [12863] by justing
  • 2 edits in trunk/WebKitSite

Changed by Darin on my machine.

  • coding/coding-style.html: Re-merged in changes Darin made to the guidelines a few days back.
4:28 PM Changeset in webkit [12862] by harrison
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Test:

  • manual-tests/mail-attachments.html: Added. Automated test not currently possible because widgets do not actually draw when not in a window. Geoff and Justin are fixing that and will add this test.
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Fix unique param check when processing object tag attributes.
4:26 PM Changeset in webkit [12861] by thatcher
  • 1 copy in tags/JavaScriptCore-521.7.1/JavaScriptCore

New tag.

4:26 PM Changeset in webkit [12860] by thatcher
  • 1 add in tags/JavaScriptCore-521.7.1

New tag.

3:37 PM Changeset in webkit [12859] by thatcher
  • 3 edits in trunk/JavaScriptCore

Adding -Wno-deprecated-declarations to more files that include ObjC headers.

3:03 PM Changeset in webkit [12858] by thatcher
  • 1 edit in trunk/JavaScriptCore/bindings/objc/WebScriptObject.mm

Fix build failure.

3:01 PM Changeset in webkit [12857] by thatcher
  • 2 edits
    2 deletes in trunk/JavaScriptCore

Added -Wno-deprecated-declarations to all the ObjC binding files to prevent deprecation
warnings. Using <rdar://problem/4448350> to track this.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/objc/objc_jsobject.h: Removed empty file.
  • bindings/objc/objc_jsobject.mm: Removed empty file.
2:57 PM Changeset in webkit [12856] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge ensureSelectionVisible]): Changed scrollRectToVisible call so that it will align to the edge instead of trying to center the selection. Centering looks funny when it happens after typing, deleting, moving the cursor, etc.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Use scrollWidth() and scrollHeight() functions instead of m_scrollWidth and m_scrollHeight. These functions will cause the correct scroll dimensions to be calculated for overflow:hidden layers. Also subtracted scrollbar width and height when calculating the layer bounds. This was causing scroll problems in overflow:scroll. I also did some cleanup to use xPos() and yPos() instead of m_x and m_y, and to use scrollYOffset() instead of m_scrollY.
2:47 PM Changeset in webkit [12855] by adele
  • 7 edits in trunk

LayoutTests:

Updating results for fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6812
Missing focus ring on new text fields

  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:

WebCore:

Reviewed by Darin.

Tests:

  • fast/forms/input-appearance-focus.html: Updated.
  • rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): call supportsFocusRing instead of checking the appearance.
  • rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added. Checks appearance. Theme will draw focus ring if there's an appearance, but not for the new text fields.
  • rendering/render_theme.h:
11:35 AM Changeset in webkit [12854] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added a file and function to a change log entry.

11:27 AM Changeset in webkit [12853] by darin
  • 20 edits
    1 add
    2 deletes in trunk/WebCore

Reviewed by Hyatt.

  • eliminate QFrame and QObject::inherits, fix some strange stuff in RenderCanvas that showed up when I tested that change
  • kwq/KWQFrame.h: Removed.
  • kwq/KWQFrame.mm: Removed.
  • bridge/mac/FrameViewMac.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for adds and removes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removes.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
  • khtml/ecma/kjs_window.cpp: (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXTextMarkerForPosition:]):
  • kwq/KWQRenderTreeDebug.cpp: (write):
  • page/Frame.cpp: (WebCore::isFrameElement):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Change QObject::inherits callers to call the "is" functions directly.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Removed QObject::inherits, QObject::isQFrame, and QObject::isQScrollView.
  • kwq/KWQScrollView.h: Inherit from Widget instead of QFrame. Remove isQScrollView.
  • kwq/KWQScrollView.mm: Remove isQScrollView.
  • page/FrameView.h:
  • page/FrameView.cpp: Changed underMouse and clickNode to be RefPtr. Added m_hasBorder. (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::~FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::viewportMousePressEvent): (WebCore::FrameView::invalidateClick): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::keyPressEvent): (WebCore::FrameView::dispatchDragEvent): Use RefPtr for MouseEventImpl. (WebCore::FrameView::nodeUnderMouse): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::setHasBorder): Added. (WebCore::FrameView::hasBorder): Added. (WebCore::FrameView::borderWidth): Added.
  • rendering/render_canvas.h: Eliminated unneeded setWidth/Height overrides. Eliminated viewportWidth(), viewportHeight(), m_rootWidth, m_rootHeight, m_viewportWidth, and m_viewportHeight.
  • rendering/render_canvas.cpp: (RenderCanvas::calcHeight): Remove unneeded code to set height when there's no view. (RenderCanvas::calcWidth): Fix code to set width to visibleWidth(). Removed incorrect old width setting, and removed unneeded code to set width when there's no view. Also removed incorrect margin-setting code. (RenderCanvas::layout): Removed incorrect code to set width and height. Instead letting calcWidth and calcHeight do the job. (RenderCanvas::repaintViewRectangle): Use new FrameView::hasBorder instead of QFrame::frameStyle. (RenderCanvas::viewRect): Removed unneeded "root width" feature for a canvas without a view.
  • rendering/render_frames.cpp: (WebCore::RenderFrame::slotViewCleared): Use new setHasBorder. (WebCore::RenderPartObject::slotViewCleared): Ditto.
11:23 AM Changeset in webkit [12852] by eseidel
  • 3 edits in trunk/WebCore

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Close several age-old leaks in xslt code.
Tests already were catching these.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
10:33 AM Changeset in webkit [12851] by tomernic
  • 2 edits
    8 adds in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)

Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.


  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::windowScriptNPObject): Removed the check Darin added to return 0 when JavaScript is disabled. This method cannot return 0, because plugins are not guaranteed to check for that. Removed my old fix for Radar 4428609 (7015) in favor of a better solution. Instead of creating a "dummy" JSObject to represent the window script object when JavaScript is disabled, we use the new JavaScriptCore bindings API to create a "no script" NPObject. This solution is better because it does not cause entry into any JavaScript interpreter code.
  • manual-tests/NPN_Invoke: Added.
  • manual-tests/NPN_Invoke/English.lproj: Added.
  • manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
  • manual-tests/NPN_Invoke/Info.plist: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
  • manual-tests/NPN_Invoke/main.c: Added.
  • manual-tests/NPN_Invoke/test.html: Added.
10:32 AM Changeset in webkit [12850] by tomernic
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

  • bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto
  • bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().
9:53 AM Changeset in webkit [12849] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixing name to use "ue" since I can't figure out how to include
and umlaut in a change log message.

9:52 AM Changeset in webkit [12848] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by me, change by Peter Kummel.

  • kjs/operations.cpp: (KJS::isNegInf): Fix Windows code, which was checking for positive infinity (rolling in fix from KDE side).
9:09 AM Changeset in webkit [12847] by ap
  • 2 edits in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin.

  • platform/Timer.cpp: (WebCore::TimerBase::stop): Call setNextFireTime(0) unconditionally to make sure the timer is removed from timersReadyToFire so that fireTimers doesn't try to fire a deleted timer.
2:20 AM Changeset in webkit [12846] by mjs
  • 3 edits in trunk/WebKitSite

Reviewed and landed by Maciej.

Made the author name bold on the frontpage.
Moved the "Posted by" line up under the title and made the author name

1:22 AM Changeset in webkit [12845] by justing
  • 4 edits in trunk/LayoutTests
1:21 AM Changeset in webkit [12844] by justing
  • 8 edits in trunk

WebKit:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree


Added a UI delegate method so that DumpRenderTree can perform dragging on its own.
Made _updateFocusState SPI, to allow us to test the behavior and appearance of
windows that have or don't have focus.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): (-[NSArray viewDidMoveToWindow]): (-[NSArray windowDidBecomeKey:]): (-[NSArray windowDidResignKey:]): (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[NSArray becomeFirstResponder]): (-[NSArray resignFirstResponder]): (-[WebHTMLView _formControlIsResigningFirstResponder:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.m:

WebKitTools:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree


Intercept the drag start using the new UI delegate method, package an NSDraggingInfo,
and send dragging updates. Put DumpRenderTree's WebView into an offscreen window.

  • DumpRenderTree/DumpRenderTree.m: (main): (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (-[WaitUntilDoneDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): (-[WaitUntilDoneDelegate webViewFocus:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[EventSendingController init]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (dumpRenderTree): (-[DumpRenderTreeWindow isKeyWindow]): (-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]): (-[DumpRenderTreeDraggingInfo dealloc]): (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]): (-[DumpRenderTreeDraggingInfo draggingSourceOperationMask]): (-[DumpRenderTreeDraggingInfo draggingLocation]): (-[DumpRenderTreeDraggingInfo draggedImageLocation]): (-[DumpRenderTreeDraggingInfo draggedImage]): (-[DumpRenderTreeDraggingInfo draggingPasteboard]): (-[DumpRenderTreeDraggingInfo draggingSource]): (-[DumpRenderTreeDraggingInfo draggingSequenceNumber]): (-[DumpRenderTreeDraggingInfo slideDraggedImageTo:]): (-[DumpRenderTreeDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
  • DumpRenderTree/TextInputController.m: (-[TextInputController firstRectForCharactersFrom:length:]): (-[TextInputController characterIndexForPointX:Y:]):
1:20 AM Changeset in webkit [12843] by justing
  • 73 edits
    1 move in trunk/LayoutTests

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree

  • css1/basic/comments-expected.checksum:
  • css1/basic/comments-expected.png:
  • css1/basic/containment-expected.checksum:
  • css1/basic/containment-expected.png:
  • css1/basic/id_as_selector-expected.checksum:
  • css1/basic/id_as_selector-expected.png:
  • css1/basic/inheritance-expected.checksum:
  • css1/basic/inheritance-expected.png:
  • css1/box_properties/border-expected.checksum:
  • css1/box_properties/border-expected.png:
  • css1/box_properties/border_bottom-expected.checksum:
  • css1/box_properties/border_bottom-expected.png:
  • css1/box_properties/border_bottom_width-expected.checksum:
  • css1/box_properties/border_bottom_width-expected.png:
  • css1/box_properties/border_left-expected.checksum:
  • css1/box_properties/border_left-expected.png:
  • css1/box_properties/border_left_width-expected.checksum:
  • css1/box_properties/border_left_width-expected.png:
  • css1/box_properties/border_right_inline-expected.checksum:
  • css1/box_properties/border_right_inline-expected.png:
  • css1/box_properties/border_right_width-expected.checksum:
  • css1/box_properties/border_right_width-expected.png:
  • css1/box_properties/border_style-expected.checksum:
  • css1/box_properties/border_style-expected.png:
  • css1/box_properties/border_top-expected.checksum:
  • css1/box_properties/border_top-expected.png:
  • css1/box_properties/border_top_width-expected.checksum:
  • css1/box_properties/border_top_width-expected.png:
  • css1/box_properties/border_width-expected.checksum:
  • css1/box_properties/border_width-expected.png:
  • css1/box_properties/clear-expected.checksum:
  • css1/box_properties/clear-expected.png:
  • css1/box_properties/clear_float-expected.checksum:
  • css1/box_properties/clear_float-expected.png:
  • css1/box_properties/float_elements_in_series-expected.checksum:
  • css1/box_properties/float_elements_in_series-expected.png:
  • css1/box_properties/float_margin-expected.checksum:
  • css1/box_properties/float_margin-expected.png:
  • css1/box_properties/float_on_text_elements-expected.checksum:
  • css1/box_properties/float_on_text_elements-expected.png:
  • css1/box_properties/height-expected.checksum:
  • css1/box_properties/height-expected.png:
  • css1/box_properties/margin-expected.checksum:
  • css1/box_properties/margin-expected.png:
  • css1/box_properties/margin_bottom-expected.checksum:
  • css1/box_properties/margin_bottom-expected.png:
  • css1/box_properties/margin_inline-expected.checksum:
  • css1/box_properties/margin_inline-expected.png:
  • css1/box_properties/margin_left-expected.checksum:
  • css1/box_properties/margin_left-expected.png:
  • css1/box_properties/margin_right-expected.checksum:
  • css1/box_properties/margin_right-expected.png:
  • css1/box_properties/margin_top-expected.checksum:
  • css1/box_properties/margin_top-expected.png:
  • css1/box_properties/padding-expected.checksum:
  • css1/box_properties/padding-expected.png:
  • css1/box_properties/padding_bottom-expected.checksum:
  • css1/box_properties/padding_bottom-expected.png:
  • css1/box_properties/padding_inline-expected.checksum:
  • css1/box_properties/padding_inline-expected.png:
  • css1/box_properties/padding_left-expected.checksum:
  • css1/box_properties/padding_left-expected.png:
  • css1/box_properties/padding_right-expected.checksum:
  • css1/box_properties/padding_right-expected.png:
  • css1/box_properties/padding_top-expected.checksum:
  • css1/box_properties/padding_top-expected.png:
  • css1/box_properties/width-expected.checksum:
  • css1/box_properties/width-expected.png:
  • css1/cascade/cascade_order-expected.checksum:
  • css1/cascade/cascade_order-expected.png:
  • css1/classification/display-expected.checksum:
  • css1/classification/display-expected.png:
  • css1/classification/list_style_type-expected.checksum:
  • css1/classification/list_style_type-expected.png:
  • css1/classification/white_space-expected.checksum:
  • css1/classification/white_space-expected.png:
  • css1/color_and_background/background-expected.checksum:
  • css1/color_and_background/background-expected.png:
  • css1/color_and_background/background_attachment-expected.checksum:
  • css1/color_and_background/background_attachment-expected.png:
  • css1/color_and_background/background_position-expected.checksum:
  • css1/color_and_background/background_position-expected.png:
  • css1/color_and_background/background_repeat-expected.checksum:
  • css1/color_and_background/background_repeat-expected.png:
  • css1/conformance/forward_compatible_parsing-expected.checksum:
  • css1/conformance/forward_compatible_parsing-expected.png:
  • css1/font_properties/font-expected.checksum:
  • css1/font_properties/font-expected.png:
  • css1/font_properties/font_family-expected.checksum:
  • css1/font_properties/font_family-expected.png:
  • css1/font_properties/font_size-expected.checksum:
  • css1/font_properties/font_size-expected.png:
  • css1/font_properties/font_weight-expected.checksum:
  • css1/font_properties/font_weight-expected.png:
  • css1/formatting_model/floating_elements-expected.checksum:
  • css1/formatting_model/floating_elements-expected.png:
  • css1/formatting_model/height_of_lines-expected.checksum:
  • css1/formatting_model/height_of_lines-expected.png:
  • css1/formatting_model/horizontal_formatting-expected.checksum:
  • css1/formatting_model/horizontal_formatting-expected.png:
  • css1/formatting_model/inline_elements-expected.checksum:
  • css1/formatting_model/inline_elements-expected.png:
  • css1/formatting_model/replaced_elements-expected.checksum:
  • css1/formatting_model/replaced_elements-expected.png:
  • css1/formatting_model/vertical_formatting-expected.checksum:
  • css1/formatting_model/vertical_formatting-expected.png:
  • css1/pseudo/anchor-expected.checksum:
  • css1/pseudo/anchor-expected.png:
  • css1/pseudo/firstletter-expected.checksum:
  • css1/pseudo/firstletter-expected.png:
  • css1/pseudo/firstline-expected.checksum:
  • css1/pseudo/firstline-expected.png:
  • css1/pseudo/multiple_pseudo_elements-expected.checksum:
  • css1/pseudo/multiple_pseudo_elements-expected.png:
  • css1/text_properties/letter_spacing-expected.checksum:
  • css1/text_properties/letter_spacing-expected.png:
  • css1/text_properties/line_height-expected.checksum:
  • css1/text_properties/line_height-expected.png:
  • css1/text_properties/text-transCapitalize-expected.checksum:
  • css1/text_properties/text-transCapitalize-expected.png:
  • css1/text_properties/text_decoration-expected.checksum:
  • css1/text_properties/text_decoration-expected.png:
  • css1/text_properties/text_indent-expected.checksum:
  • css1/text_properties/text_indent-expected.png:
  • css1/text_properties/text_transform-expected.checksum:
  • css1/text_properties/text_transform-expected.png:
  • css1/text_properties/vertical_align-expected.checksum:
  • css1/text_properties/vertical_align-expected.png:
  • css1/text_properties/word_spacing-expected.checksum:
  • css1/text_properties/word_spacing-expected.png:
  • css1/units/color_units-expected.checksum:
  • css1/units/color_units-expected.png:
  • css1/units/length_units-expected.checksum:
  • css1/units/length_units-expected.png:
  • css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
  • css2.1/t0801-c412-hz-box-00-b-a-expected.png:
  • css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
  • css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
  • css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
  • css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
  • css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
  • css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • css2.1/t1002-c5523-width-02-b-g-expected.checksum:
  • css2.1/t1002-c5523-width-02-b-g-expected.png:
  • css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
  • css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
  • css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • css2.1/t1508-c527-font-07-b-expected.checksum:
  • css2.1/t1508-c527-font-07-b-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-and-undo-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.checksum:
  • editing/deleting/delete-line-end-ws-001-expected.png:
  • editing/deleting/delete-line-end-ws-002-expected.checksum:
  • editing/deleting/delete-line-end-ws-002-expected.png:
  • editing/inserting/insert-div-023-expected.checksum:
  • editing/inserting/insert-div-023-expected.png:
  • editing/selection/caret-and-focus-ring.html:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added.
  • editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
  • editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
  • editing/selection/drag-to-contenteditable-iframe.html: Added.
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/replaced-boundaries-3-expected.checksum:
  • editing/selection/replaced-boundaries-3-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-all-003-expected.checksum:
  • editing/selection/select-all-003-expected.png:
  • editing/selection/select-all-004-expected.checksum:
  • editing/selection/select-all-004-expected.png:
  • editing/selection/select-box-expected.checksum:
  • editing/selection/select-box-expected.png:
  • editing/selection/selection-background.html:
  • editing/selection/unrendered-001-expected.checksum:
  • editing/selection/unrendered-001-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/selection/unrendered-003-expected.checksum:
  • editing/selection/unrendered-003-expected.png:
  • editing/selection/unrendered-004-expected.checksum:
  • editing/selection/unrendered-004-expected.png:
  • editing/selection/unrendered-005-expected.checksum:
  • editing/selection/unrendered-005-expected.png:
  • editing/undo/4063751-expected.txt:
  • editing/undo/redo-typing-001-expected.txt:
  • editing/undo/undo-typing-001-expected.checksum:
  • editing/undo/undo-typing-001-expected.png:
  • editing/undo/undo-typing-001-expected.txt:
  • fast/block/basic/016-expected.checksum:
  • fast/block/basic/016-expected.png:
  • fast/block/basic/text-indent-rtl-expected.checksum:
  • fast/block/float/008-expected.checksum:
  • fast/block/float/008-expected.png:
  • fast/block/float/013-expected.checksum:
  • fast/block/float/013-expected.png:
  • fast/block/float/019-expected.checksum:
  • fast/block/float/019-expected.png:
  • fast/block/float/021-expected.checksum:
  • fast/block/float/021-expected.png:
  • fast/block/float/025-expected.checksum:
  • fast/block/float/025-expected.png:
  • fast/block/float/026-expected.checksum:
  • fast/block/float/026-expected.png:
  • fast/block/float/027-expected.checksum:
  • fast/block/float/027-expected.png:
  • fast/block/float/028-expected.checksum:
  • fast/block/float/028-expected.png:
  • fast/block/float/032-expected.checksum:
  • fast/block/float/032-expected.png:
  • fast/block/float/033-expected.checksum:
  • fast/block/float/033-expected.png:
  • fast/block/margin-collapse/103-expected.checksum:
  • fast/block/margin-collapse/103-expected.png:
  • fast/block/margin-collapse/104-expected.checksum:
  • fast/block/margin-collapse/104-expected.png:
  • fast/block/positioning/047-expected.checksum:
  • fast/block/positioning/047-expected.png:
  • fast/block/positioning/051-expected.checksum:
  • fast/block/positioning/051-expected.png:
  • fast/block/positioning/055-expected.checksum:
  • fast/block/positioning/055-expected.png:
  • fast/block/positioning/auto/007-expected.checksum:
  • fast/block/positioning/auto/007-expected.png:
  • fast/block/positioning/relayout-on-position-change-expected.checksum:
  • fast/box-sizing/box-sizing-expected.checksum:
  • fast/box-sizing/box-sizing-expected.png:
  • fast/clip/014-expected.checksum:
  • fast/clip/014-expected.png:
  • fast/css-generated-content/014-expected.checksum:
  • fast/css-generated-content/014-expected.png:
  • fast/css/005-expected.checksum:
  • fast/css/005-expected.png:
  • fast/css/MarqueeLayoutTest-expected.checksum:
  • fast/css/MarqueeLayoutTest-expected.png:
  • fast/css/imageTileOpacity-expected.checksum:
  • fast/css/imageTileOpacity-expected.png:
  • fast/css/word-space-extra-expected.checksum:
  • fast/css/word-space-extra-expected.png:
  • fast/dom/HTMLObjectElement/object-as-frame.html:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/dom/window-onFocus.html:
  • fast/dynamic/008-expected.checksum:
  • fast/dynamic/008-expected.png:
  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png:
  • fast/flexbox/009-expected.checksum:
  • fast/flexbox/009-expected.png:
  • fast/flexbox/016-expected.checksum:
  • fast/flexbox/016-expected.png:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/003-expected.checksum:
  • fast/forms/003-expected.png:
  • fast/forms/004-expected.checksum:
  • fast/forms/004-expected.png:
  • fast/forms/HTMLOptionElement_label01-expected.checksum:
  • fast/forms/HTMLOptionElement_label01-expected.png:
  • fast/forms/HTMLOptionElement_label02-expected.checksum:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label03-expected.checksum:
  • fast/forms/HTMLOptionElement_label03-expected.png:
  • fast/forms/HTMLOptionElement_label04-expected.checksum:
  • fast/forms/HTMLOptionElement_label04-expected.png:
  • fast/forms/button-sizes-expected.checksum:
  • fast/forms/button-sizes-expected.png:
  • fast/forms/checkbox-radio-onchange-expected.checksum:
  • fast/forms/checkbox-radio-onchange-expected.png:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/indeterminate-expected.checksum:
  • fast/forms/indeterminate-expected.png:
  • fast/forms/option-script-expected.checksum:
  • fast/forms/option-script-expected.png:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/radio_checked-expected.checksum:
  • fast/forms/radio_checked-expected.png:
  • fast/forms/radio_checked_dynamic-expected.checksum:
  • fast/forms/radio_checked_dynamic-expected.png:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/inline-block/tricky-baseline-expected.checksum:
  • fast/inline-block/tricky-baseline-expected.png:
  • fast/invalid/014-expected.checksum:
  • fast/invalid/014-expected.png:
  • fast/lists/008-expected.checksum:
  • fast/lists/008-expected.png:
  • fast/lists/li-br-expected.checksum:
  • fast/lists/li-br-expected.png:
  • fast/lists/olstart-expected.checksum:
  • fast/lists/olstart-expected.png:
  • fast/loader/form-events-back-forward.html: Removed.
  • fast/loader/form-events-back-forward.html-disabled: Added.
  • fast/overflow/002-expected.checksum:
  • fast/overflow/002-expected.png:
  • fast/overflow/003-expected.checksum:
  • fast/overflow/003-expected.png:
  • fast/overflow/005-expected.checksum:
  • fast/overflow/005-expected.png:
  • fast/overflow/006-expected.checksum:
  • fast/overflow/006-expected.png:
  • fast/overflow/007-expected.checksum:
  • fast/overflow/007-expected.png:
  • fast/overflow/image-selection-highlight-expected.checksum:
  • fast/overflow/image-selection-highlight-expected.png:
  • fast/overflow/overflow-auto-table-expected.checksum:
  • fast/overflow/overflow-auto-table-expected.png:
  • fast/overflow/overflow-rtl-expected.checksum:
  • fast/overflow/overflow-rtl-expected.png:
  • fast/overflow/overflow-text-hit-testing-expected.checksum:
  • fast/overflow/overflow-text-hit-testing-expected.png:
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/parser/comments-expected.checksum:
  • fast/parser/comments-expected.png:
  • fast/parser/document-write-option-expected.checksum:
  • fast/parser/document-write-option-expected.png:
  • fast/parser/entities-in-xhtml-expected.checksum:
  • fast/parser/entities-in-xhtml-expected.png:
  • fast/replaced/005-expected.checksum:
  • fast/replaced/005-expected.png:
  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/selectors/166-expected.checksum:
  • fast/selectors/166-expected.png:
  • fast/table/023-expected.checksum:
  • fast/table/023-expected.png:
  • fast/table/034-expected.checksum:
  • fast/table/034-expected.png:
  • fast/table/040-expected.checksum:
  • fast/table/040-expected.png:
  • fast/table/border-collapsing/004-expected.checksum:
  • fast/table/border-collapsing/004-expected.png:
  • fast/table/edge-offsets-expected.checksum:
  • fast/table/edge-offsets-expected.png:
  • fast/table/height-percent-test-expected.checksum:
  • fast/table/height-percent-test-expected.png:
  • fast/table/overflowHidden-expected.checksum:
  • fast/table/overflowHidden-expected.png:
  • fast/table/wide-colspan-expected.checksum:
  • fast/table/wide-colspan-expected.png:
  • fast/table/wide-column-expected.checksum:
  • fast/table/wide-column-expected.png:
  • fast/text/softHyphen-expected.checksum:
  • fast/text/softHyphen-expected.png:
  • fast/text/whitespace/024-expected.checksum:
  • fast/text/whitespace/024-expected.png:
  • fast/tokenizer/004-expected.checksum:
  • fast/tokenizer/004-expected.png:
  • svg/custom/feDisplacementMap-01-expected.png: Removed.
  • svg/custom/junk-data-expected.checksum:
  • svg/custom/junk-data-expected.png:
  • svg/custom/missing-xlink-expected.checksum:
  • svg/custom/missing-xlink-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • traversal/tree-walker-004-expected.checksum:
  • traversal/tree-walker-004-expected.png:
1:20 AM Changeset in webkit [12842] by justing
  • 140 edits
    7 adds in trunk/LayoutTests
1:16 AM Changeset in webkit [12841] by justing
  • 156 edits in trunk/LayoutTests

Feb 15, 2006:

10:34 PM Changeset in webkit [12840] by ggaren
  • 18 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • bindings/jni/jni_instance.cpp: Made _instance a RefPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref):
  • bindings/jni/jni_runtime.cpp: Made _array a RefPtr (JavaArray::~JavaArray): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=):
  • bindings/objc/objc_runtime.h:
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject):
  • bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
  • bindings/runtime_object.h:
  • Removed ownsInstance data member because RefPtr takes care of instance lifetime now.
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Eric.

  • Layout test for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()
  • plugins: Added.
  • plugins/undefined-property-crash-expected.txt: Added.
  • plugins/undefined-property-crash.html: Added.

WebCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a RefPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a RefPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made objectInstance a RefPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach):
  • bindings/js/JSDOMCore.cpp:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/html/html_objectimpl.h:

WebKitTools:

Reviewed by Eric.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): Added a dummy method for the sake of LayoutTests/plugins/ undefined-property-crash.html. (It tests a crash due to fallback object use. WebCore won't create a fallback object if the method is not defined.)
10:11 PM Changeset in webkit [12839] by thatcher
  • 47 edits
    31 adds
    10 deletes in trunk/WebKitSite

Reviewed by Tim H.

Updated the site to use the new layout.

  • .htaccess: Added.
  • ChangeLog:
  • blog/wp-content/themes/classic: Removed.
  • blog/wp-content/themes/classic/comments-popup.php: Removed.
  • blog/wp-content/themes/classic/comments.php: Removed.
  • blog/wp-content/themes/classic/footer.php: Removed.
  • blog/wp-content/themes/classic/header.php: Removed.
  • blog/wp-content/themes/classic/index.php: Removed.
  • blog/wp-content/themes/classic/sidebar.php: Removed.
  • blog/wp-content/themes/classic/style.css: Removed.
  • blog/wp-content/themes/default: Removed.
  • blog/wp-content/themes/default/404.php: Removed.
  • blog/wp-content/themes/default/archive.php: Removed.
  • blog/wp-content/themes/default/archives.php: Removed.
  • blog/wp-content/themes/default/comments-popup.php: Removed.
  • blog/wp-content/themes/default/comments.php: Removed.
  • blog/wp-content/themes/default/footer.php: Removed.
  • blog/wp-content/themes/default/header.php: Removed.
  • blog/wp-content/themes/default/images: Removed.
  • blog/wp-content/themes/default/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/default/index.php: Removed.
  • blog/wp-content/themes/default/links.php: Removed.
  • blog/wp-content/themes/default/page.php: Removed.
  • blog/wp-content/themes/default/search.php: Removed.
  • blog/wp-content/themes/default/searchform.php: Removed.
  • blog/wp-content/themes/default/sidebar.php: Removed.
  • blog/wp-content/themes/default/single.php: Removed.
  • blog/wp-content/themes/default/style.css: Removed.
  • blog/wp-content/themes/webkit/404.php:
  • blog/wp-content/themes/webkit/archive.php:
  • blog/wp-content/themes/webkit/archives.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
  • blog/wp-content/themes/webkit/images: Removed.
  • blog/wp-content/themes/webkit/images/bluebanner.png: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/webkit/images/separator.png: Removed.
  • blog/wp-content/themes/webkit/images/webkit-background.png: Removed.
  • blog/wp-content/themes/webkit/index.php:
  • blog/wp-content/themes/webkit/page.php:
  • blog/wp-content/themes/webkit/search.php:
  • blog/wp-content/themes/webkit/sidebar.php:
  • blog/wp-content/themes/webkit/single.php:
  • blog/wp-content/themes/webkit/style.css:
  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • css: Added.
  • css/blue.css: Added.
  • css/gray.css: Added.
  • css/green.css: Added.
  • css/ie.css: Added.
  • css/main.css: Added.
  • css/pink.css: Added.
  • css/purple.css: Added.
  • css/yellow.css: Added.
  • footer.inc: Added.
  • header.inc: Added.
  • images/blue-background.png: Added.
  • images/blue-bullet.png: Added.
  • images/bluebanner.png: Removed.
  • images/download.png: Added.
  • images/end.png: Added.
  • images/gray-background.png: Added.
  • images/green-background.png: Added.
  • images/green-bullet.png: Added.
  • images/icon-gold.png: Added.
  • images/icon.png: Added.
  • images/ie-nav.png: Added.
  • images/middle.png: Added.
  • images/nav.png: Added.
  • images/pink-background.png: Added.
  • images/pink-bullet.png: Added.
  • images/purple-background.png: Added.
  • images/purple-bullet.png: Added.
  • images/separator.png: Removed.
  • images/webkit-background.png: Removed.
  • images/welcomeopen.gif: Removed.
  • images/yellow-background.png: Added.
  • images/yellow-bullet.png: Added.
  • index.html:
  • nav.inc: Added.
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/bugzilla.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • sidebar.css: Removed.
  • sidebar.html: Removed.
  • webkitdev.css: Removed.
8:21 PM Changeset in webkit [12838] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Add files missing from previous commit.


  • svg/custom/feDisplacementMap-01-expected.checksum: Added.
  • svg/custom/feDisplacementMap-01-expected.png: Added.
  • svg/custom/feDisplacementMap-01-expected.txt: Added.
4:19 PM Changeset in webkit [12837] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

No test case because it requires manual mouse wheeling.

  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just leaking the WheelEventImpl.
4:16 PM Changeset in webkit [12836] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by John.

  • Applied the 4330457 change to CClass and ObjcClass as well.

Once plugins work in DumpRenderTree, running run-webkit-tests --leaks
will catch this.

This change isn't as critical because CClass and ObjcClass objects get
cached globally and never deleted, but it's good practice, in case we
ever do decide to delete CClass and ObjcClass objects.

This change requires prohibiting copying, because we don't do any
intelligent ref-counting -- when a Class is destroyed, it destroys its
methods and fields unconditionally. (Java classes already prohibited
copying.)

  • bindings/c/c_class.cpp:
  • Merged _commonInit and _commonDelete into constructor and destructor. (CClass::CClass): (CClass::~CClass): (CClass::methodsNamed): Added delete callbacks (CClass::fieldNamed): Added delete callbacks
  • bindings/c/c_class.h: Prohibited copying
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getClass): Changed to use the preferred class factory method, to take advantage of the global cache.

[ Repeated changes applied to CClass for ObjcClass: ]

  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::ObjcMethod): Initialized uninitialized variable to prevent bad CFRelease. (KJS::Bindings::ObjcMethod::~ObjcMethod): Removed erroneous ';' from if statement to prevent bad CFRelease.
  • bindings/objc/objc_runtime.cpp: Changed to use the preferred ObjectStructPtr, for clarity.
3:50 PM Changeset in webkit [12835] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • Fixed <rdar://problem/4330457> CrashTracer: [REGRESSION] 3763 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance:: getClass const + 56

This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.

The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): Added delete callbacks
  • bindings/runtime.cpp: Added definitions for delete callbacks (KJS::Bindings::deleteMethodList): (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField):
  • bindings/runtime.h: Added declarations for delete callbacks
3:04 PM Changeset in webkit [12834] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

3:02 PM Changeset in webkit [12833] by thatcher
  • 2 edits in tags/WebCore-521.7.2/WebCore

Build fix.

2:58 PM Changeset in webkit [12832] by hyatt
  • 2 edits in trunk/WebCore/platform/image-decoders

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:57 PM Changeset in webkit [12831] by hyatt
  • 12 edits in trunk/WebCore

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:55 PM Changeset in webkit [12830] by thatcher
  • 1 copy in tags/WebCore-521.7.2

New tag.

2:37 PM Changeset in webkit [12829] by hyatt
  • 6 edits
    2 moves
    1 add in trunk/WebCore

Make KWQFontFamily portable. Split it out into a cross-platform core and the Mac-specific version.
Move it to platform and rename it to FontFamily (and FontFamilyMac).

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQFont.h: (QFont::firstFamily):
  • kwq/KWQFont.mm: (QFont::setFirstFamily):
  • kwq/KWQFontFamily.h: Removed.
  • kwq/KWQFontFamily.mm: Removed.
  • platform/FontFamily.cpp: Added. (WebCore::FontFamily::FontFamily): (WebCore::FontFamily::~FontFamily): (WebCore::FontFamily::operator=): (WebCore::FontFamily::setFamily): (WebCore::FontFamily::operator==):
  • platform/FontFamily.h: Added. (WebCore::FontFamily::family): (WebCore::FontFamily::familyIsEmpty): (WebCore::FontFamily::next): (WebCore::FontFamily::appendFamily): (WebCore::FontFamily::operator!=): (WebCore::FontFamily::ref): (WebCore::FontFamily::deref):
  • platform/mac/FontFamilyMac.mm: Added. (WebCore::retainDOMStringImpl): (WebCore::releaseDOMStringImpl): (WebCore::): (WebCore::FontFamily::getNSFamily):
  • rendering/font.h: (khtml::FontDef::firstFamily):
2:30 PM Changeset in webkit [12828] by thatcher
  • 3 edits in tags/WebCore-417.19.1/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
2:26 PM Changeset in webkit [12827] by thatcher
  • 1 copy in tags/WebCore-417.19.1

New tag.

1:54 PM Changeset in webkit [12826] by thatcher
  • 4 copies in tags/WebCore-417.22/WebCore

Correct tag.

1:54 PM Changeset in webkit [12825] by thatcher
  • 1 delete in tags/WebCore-417.22/WebCore

Redoing this tag.

1:48 PM Changeset in webkit [12824] by thatcher
  • 1 copy in tags/WebCore-417.22

New tag.

1:46 PM Changeset in webkit [12823] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

1:44 PM Changeset in webkit [12822] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
8:36 AM Changeset in webkit [12821] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
6:47 AM Changeset in webkit [12820] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Tim H.

Updated page to show 10.4.4 or 10.4.5
Added support for recognizing Shiira.

  • quality/reporting.html:
2:30 AM Changeset in webkit [12819] by eseidel
  • 12 edits
    8 adds in trunk

2006-02-15 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.


Implemented feDisplacementMap.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5862

Test: svg/custom/feDisplacementMap-01.svg

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEDisplacementMap::xChannelSelector): (WebCore::KCanvasFEDisplacementMap::setXChannelSelector): (WebCore::KCanvasFEDisplacementMap::yChannelSelector): (WebCore::KCanvasFEDisplacementMap::setYChannelSelector): (WebCore::KCanvasFEDisplacementMap::scale): (WebCore::KCanvasFEDisplacementMap::setScale):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added. (+[WKDisplacementMapFilter initialize]): (+[WKDisplacementMapFilter filterWithName:]): (-[WKDisplacementMapFilter init]): (-[WKDisplacementMapFilter outputImage]):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added. (SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::in1): (SVGFEDisplacementMapElementImpl::in2): (SVGFEDisplacementMapElementImpl::xChannelSelector): (SVGFEDisplacementMapElementImpl::yChannelSelector): (SVGFEDisplacementMapElementImpl::scale): (SVGFEDisplacementMapElementImpl::stringToChannel): (SVGFEDisplacementMapElementImpl::parseMappedAttribute): (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added.
  • ksvg2/svg/svgtags.in:
1:54 AM Changeset in webkit [12818] by eseidel
  • 2 edits in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Update missing result from last commit.

  • fast/xsl/xslt-recursion-expected.txt:
1:44 AM Changeset in webkit [12817] by mjs
  • 1 edit
    1 delete in trunk/WebKit

Rubber stamped by Anders.

  • WebView/WebControllerPolicyHandlerDelegate.h: Removed.
1:20 AM Changeset in webkit [12816] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • remove some voodoo code
  • WebView/WebDataSource.m: (-[WebDataSource _setLoading:]): Removed useless ref/deref of self and WebView. A WebDataSource cannot be loading unless it is still connected to the WebView that owns it and retained by it, because getting disconnected stops loading.
1:16 AM Changeset in webkit [12815] by eseidel
  • 2 edits in trunk/WebCore

2006-02-15 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Commit change forgotten after editing directory move.

  • editing/markup.cpp: (khtml::startMarkup): add support for serializing DOCTYPEs in xml

Feb 14, 2006:

9:49 PM Changeset in webkit [12814] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Maciej.

Test case: fast/encoding/percent-escaping.html

  • kwq/KWQKURL.mm: (appendEscapingBadChars): Rather than adding support for %u, remove the existing "do what I mean" escaping of percent characters that do not look like a result of prior escaping.
7:30 PM Changeset in webkit [12813] by eseidel
  • 2 edits in trunk/WebCore

2006-02-14 Eric Seidel <​eseidel@apple.com>

Fix build failure from last minute edit.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
7:01 PM Changeset in webkit [12812] by eseidel
  • 19 edits
    3 adds in trunk

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add incremental parsing support to XMLTokenizer.
This patch also does a few other little things:

  • removes (unused) onHold support from Tokenizer
  • adds serialization of DOCTYPEs for xml documents
  • fixes xslt support to no longer depend on synchronous parsing
  • fixes css styling for pages where xsl recursion is blocked ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6057
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::recalcStyleSelector):
  • dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstructionImpl::checkStyleSheet):
  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::error): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::finish): (WebCore::xmlDocPtrForString): (WebCore::parseAttributes):
  • dom/xml_tokenizer.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup): DOCTYPE serialization
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold (WebCore::HTMLTokenizer::reset): removed onHold (WebCore::HTMLTokenizer::begin): removed onHold (WebCore::HTMLTokenizer::write): removed onHold (WebCore::HTMLTokenizer::finish): removed onHold
  • khtml/html/htmltokenizer.h: removed onHold support
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::document): (WebCore::XSLStyleSheetImpl::setDocument): (WebCore::XSLStyleSheetImpl::parseString): (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::compileStyleSheet): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
  • khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file
6:55 PM Changeset in webkit [12811] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Anders.


Improvements to frame loading:


  • remove LayoutAcceptable state entirely
  • fix WebImageView to work right without LayoutAcceptable state
  • move guts of commitIfReady: to WebFrame
  • try to separate page cache loading from normal loading a bit more
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebView/WebDataSource.m: (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _startLoading]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setupForReplaceByMIMEType:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView/WebFramePrivate.h:
  • WebView/WebImageRepresentation.h:
  • WebView/WebImageRepresentation.m:
  • WebView/WebImageView.m: (-[WebImageView dataSourceUpdated:]): (-[WebImageView setNeedsLayout:]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView mouseDragged:]):
  • WebView/WebView.m: (-[WebView _finishedLoadingResourceFromDataSource:]): (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
6:35 PM Changeset in webkit [12810] by adele
  • 9 edits
    8 adds in trunk

LayoutTests:

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

  • fast/forms/input-appearance-width.html: Added.
  • fast/forms/input-appearance-width-expected.txt: Added.
  • fast/forms/input-appearance-width-expected.png: Added.
  • fast/forms/input-appearance-width-expected.checksum: Added.
  • fast/forms/input-appearance-minWidth.html: Added.
  • fast/forms/input-appearance-minWidth-expected.txt: Added.
  • fast/forms/input-appearance-minWidth-expected.png: Added.
  • fast/forms/input-appearance-minWidth-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

Tests:
fast/forms/input-appearance-width.html
fast/forms/input-appearance-minWidth.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Remove fixed width for text field. (WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and then uses the size attribute to determine what the maxWidth should be.
  • rendering/RenderTextField.h: Added calcMinMaxWidth.
  • rendering/render_theme_mac.h: Added adjustTextFieldStyle.
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary. (WebCore::RenderThemeMac::paintTextField): ditto. (WebCore::RenderThemeMac::setTextFieldCellState): change true to YES. (WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the right padding and margins. When we flip the switch, this will go in html4.css.
6:07 PM Changeset in webkit [12809] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: added --results-directory (-o) option
5:36 PM Changeset in webkit [12808] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

removed -[DOMHTMLSelectElement _optionLabels], formerly used only by Safari, now unused.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMPrivate.h:
4:15 PM Changeset in webkit [12807] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • JavaScriptCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""

WebCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • WebCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
2:42 PM Changeset in webkit [12806] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

One more of the same (this one tests list boxes instead of pop-up menus)

  • fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label05-expected.png: Added.
  • fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label05.html: Added.
2:33 PM Changeset in webkit [12805] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Added another option element label test at Dave Hyatt's suggestion

  • fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label04.html: Added.
2:14 PM Changeset in webkit [12804] by adele
  • 1 edit
    12 moves in trunk/LayoutTests

Reviewed by Eric.

Moving these tests to a better location.

  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Removed.
  • fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label01.html: Added.
  • fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label02.html: Added.
  • fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label03.html: Added.
1:40 PM Changeset in webkit [12803] by darin
  • 27 edits
    58 copies
    1 move
    58 deletes in trunk/WebCore

Rubber-stamped by Eric.

  • moved editing sources from khtml/editing to editing, and renamed files with single classes
  • WebCore.xcodeproj/project.pbxproj: Added new, removed old.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/DocumentImpl.cpp:
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_position.cpp:
  • khtml/khtml_events.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQEditCommand.mm:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_br.cpp:
  • rendering/render_inline.cpp:
  • rendering/render_object.cpp:
  • rendering/render_replaced.cpp: Fixed up includes.
  • editing: Added.
  • editing/AppendNodeCommand.cpp: Added.
  • editing/AppendNodeCommand.h: Added.
  • editing/ApplyStyleCommand.cpp: Added.
  • editing/ApplyStyleCommand.h: Added.
  • editing/BreakBlockquoteCommand.cpp: Added.
  • editing/BreakBlockquoteCommand.h: Added.
  • editing/CompositeEditCommand.cpp: Added.
  • editing/CompositeEditCommand.h: Added.
  • editing/DeleteFromTextNodeCommand.cpp: Added.
  • editing/DeleteFromTextNodeCommand.h: Added.
  • editing/DeleteSelectionCommand.cpp: Added.
  • editing/DeleteSelectionCommand.h: Added.
  • editing/EditCommand.cpp: Added.
  • editing/EditCommand.h: Added.
  • editing/InsertIntoTextNodeCommand.cpp: Added.
  • editing/InsertIntoTextNodeCommand.h: Added.
  • editing/InsertLineBreakCommand.cpp: Added.
  • editing/InsertLineBreakCommand.h: Added.
  • editing/InsertNodeBeforeCommand.cpp: Added.
  • editing/InsertNodeBeforeCommand.h: Added.
  • editing/InsertParagraphSeparatorCommand.cpp: Added.
  • editing/InsertParagraphSeparatorCommand.h: Added.
  • editing/InsertTextCommand.cpp: Added.
  • editing/InsertTextCommand.h: Added.
  • editing/JoinTextNodesCommand.cpp: Added.
  • editing/JoinTextNodesCommand.h: Added.
  • editing/MergeIdenticalElementsCommand.cpp: Added.
  • editing/MergeIdenticalElementsCommand.h: Added.
  • editing/MoveSelectionCommand.cpp: Added.
  • editing/MoveSelectionCommand.h: Added.
  • editing/RebalanceWhitespaceCommand.cpp: Added.
  • editing/RebalanceWhitespaceCommand.h: Added.
  • editing/RemoveCSSPropertyCommand.cpp: Added.
  • editing/RemoveCSSPropertyCommand.h: Added.
  • editing/RemoveNodeAttributeCommand.cpp: Added.
  • editing/RemoveNodeAttributeCommand.h: Added.
  • editing/RemoveNodeCommand.cpp: Added.
  • editing/RemoveNodeCommand.h: Added.
  • editing/RemoveNodePreservingChildrenCommand.cpp: Added.
  • editing/RemoveNodePreservingChildrenCommand.h: Added.
  • editing/ReplaceSelectionCommand.cpp: Added.
  • editing/ReplaceSelectionCommand.h: Added.
  • editing/Selection.cpp:
  • editing/SelectionController.cpp:
  • editing/SetNodeAttributeCommand.cpp: Added.
  • editing/SetNodeAttributeCommand.h: Added.
  • editing/SplitElementCommand.cpp: Added.
  • editing/SplitElementCommand.h: Added.
  • editing/SplitTextNodeCommand.cpp: Added.
  • editing/SplitTextNodeCommand.h: Added.
  • editing/SplitTextNodeContainingElementCommand.cpp: Added.
  • editing/SplitTextNodeContainingElementCommand.h: Added.
  • editing/TypingCommand.cpp: Added.
  • editing/TypingCommand.h: Added.
  • editing/VisiblePosition.cpp: Added.
  • editing/VisiblePosition.h: Added.
  • editing/VisibleRange.cpp: Added.
  • editing/VisibleRange.h: Added.
  • editing/WrapContentsInDummySpanCommand.cpp: Added.
  • editing/WrapContentsInDummySpanCommand.h: Added.
  • editing/append_node_command.cpp: Removed.
  • editing/append_node_command.h: Removed.
  • editing/apply_style_command.cpp: Removed.
  • editing/apply_style_command.h: Removed.
  • editing/break_blockquote_command.cpp: Removed.
  • editing/break_blockquote_command.h: Removed.
  • editing/composite_edit_command.cpp: Removed.
  • editing/composite_edit_command.h: Removed.
  • editing/delete_from_text_node_command.cpp: Removed.
  • editing/delete_from_text_node_command.h: Removed.
  • editing/delete_selection_command.cpp: Removed.
  • editing/delete_selection_command.h: Removed.
  • editing/edit_command.cpp: Removed.
  • editing/edit_command.h: Removed.
  • editing/htmlediting.cpp:
  • editing/insert_into_text_node_command.cpp: Removed.
  • editing/insert_into_text_node_command.h: Removed.
  • editing/insert_line_break_command.cpp: Removed.
  • editing/insert_line_break_command.h: Removed.
  • editing/insert_node_before_command.cpp: Removed.
  • editing/insert_node_before_command.h: Removed.
  • editing/insert_paragraph_separator_command.cpp: Removed.
  • editing/insert_paragraph_separator_command.h: Removed.
  • editing/insert_text_command.cpp: Removed.
  • editing/insert_text_command.h: Removed.
  • editing/join_text_nodes_command.cpp: Removed.
  • editing/join_text_nodes_command.h: Removed.
  • editing/jsediting.cpp:
  • editing/markup.cpp:
  • editing/merge_identical_elements_command.cpp: Removed.
  • editing/merge_identical_elements_command.h: Removed.
  • editing/move_selection_command.cpp: Removed.
  • editing/move_selection_command.h: Removed.
  • editing/rebalance_whitespace_command.cpp: Removed.
  • editing/rebalance_whitespace_command.h: Removed.
  • editing/remove_css_property_command.cpp: Removed.
  • editing/remove_css_property_command.h: Removed.
  • editing/remove_node_attribute_command.cpp: Removed.
  • editing/remove_node_attribute_command.h: Removed.
  • editing/remove_node_command.cpp: Removed.
  • editing/remove_node_command.h: Removed.
  • editing/remove_node_preserving_children_command.cpp: Removed.
  • editing/remove_node_preserving_children_command.h: Removed.
  • editing/replace_selection_command.cpp: Removed.
  • editing/replace_selection_command.h: Removed.
  • editing/set_node_attribute_command.cpp: Removed.
  • editing/set_node_attribute_command.h: Removed.
  • editing/split_element_command.cpp: Removed.
  • editing/split_element_command.h: Removed.
  • editing/split_text_node_command.cpp: Removed.
  • editing/split_text_node_command.h: Removed.
  • editing/split_text_node_containing_element.cpp: Removed.
  • editing/split_text_node_containing_element_command.h: Removed.
  • editing/typing_command.cpp: Removed.
  • editing/typing_command.h: Removed.
  • editing/visible_position.cpp: Removed.
  • editing/visible_position.h: Removed.
  • editing/visible_range.cpp: Removed.
  • editing/visible_range.h: Removed.
  • editing/visible_units.cpp:
  • editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • editing/wrap_contents_in_dummy_span_command.h: Removed.
  • khtml/editing: Removed.
  • khtml/editing/Selection.cpp: Removed.
  • khtml/editing/Selection.h: Removed.
  • khtml/editing/SelectionController.cpp: Removed.
  • khtml/editing/SelectionController.h: Removed.
  • khtml/editing/append_node_command.cpp: Removed.
  • khtml/editing/append_node_command.h: Removed.
  • khtml/editing/apply_style_command.cpp: Removed.
  • khtml/editing/apply_style_command.h: Removed.
  • khtml/editing/break_blockquote_command.cpp: Removed.
  • khtml/editing/break_blockquote_command.h: Removed.
  • khtml/editing/composite_edit_command.cpp: Removed.
  • khtml/editing/composite_edit_command.h: Removed.
  • khtml/editing/delete_from_text_node_command.cpp: Removed.
  • khtml/editing/delete_from_text_node_command.h: Removed.
  • khtml/editing/delete_selection_command.cpp: Removed.
  • khtml/editing/delete_selection_command.h: Removed.
  • khtml/editing/edit_actions.h: Removed.
  • khtml/editing/edit_command.cpp: Removed.
  • khtml/editing/edit_command.h: Removed.
  • khtml/editing/html_interchange.cpp: Removed.
  • khtml/editing/html_interchange.h: Removed.
  • khtml/editing/htmlediting.cpp: Removed.
  • khtml/editing/htmlediting.h: Removed.
  • khtml/editing/insert_into_text_node_command.cpp: Removed.
  • khtml/editing/insert_into_text_node_command.h: Removed.
  • khtml/editing/insert_line_break_command.cpp: Removed.
  • khtml/editing/insert_line_break_command.h: Removed.
  • khtml/editing/insert_node_before_command.cpp: Removed.
  • khtml/editing/insert_node_before_command.h: Removed.
  • khtml/editing/insert_paragraph_separator_command.cpp: Removed.
  • khtml/editing/insert_paragraph_separator_command.h: Removed.
  • khtml/editing/insert_text_command.cpp: Removed.
  • khtml/editing/insert_text_command.h: Removed.
  • khtml/editing/join_text_nodes_command.cpp: Removed.
  • khtml/editing/join_text_nodes_command.h: Removed.
  • khtml/editing/jsediting.cpp: Removed.
  • khtml/editing/jsediting.h: Removed.
  • khtml/editing/markup.cpp: Removed.
  • khtml/editing/markup.h: Removed.
  • khtml/editing/merge_identical_elements_command.cpp: Removed.
  • khtml/editing/merge_identical_elements_command.h: Removed.
  • khtml/editing/move_selection_command.cpp: Removed.
  • khtml/editing/move_selection_command.h: Removed.
  • khtml/editing/rebalance_whitespace_command.cpp: Removed.
  • khtml/editing/rebalance_whitespace_command.h: Removed.
  • khtml/editing/remove_css_property_command.cpp: Removed.
  • khtml/editing/remove_css_property_command.h: Removed.
  • khtml/editing/remove_node_attribute_command.cpp: Removed.
  • khtml/editing/remove_node_attribute_command.h: Removed.
  • khtml/editing/remove_node_command.cpp: Removed.
  • khtml/editing/remove_node_command.h: Removed.
  • khtml/editing/remove_node_preserving_children_command.cpp: Removed.
  • khtml/editing/remove_node_preserving_children_command.h: Removed.
  • khtml/editing/replace_selection_command.cpp: Removed.
  • khtml/editing/replace_selection_command.h: Removed.
  • khtml/editing/set_node_attribute_command.cpp: Removed.
  • khtml/editing/set_node_attribute_command.h: Removed.
  • khtml/editing/split_element_command.cpp: Removed.
  • khtml/editing/split_element_command.h: Removed.
  • khtml/editing/split_text_node_command.cpp: Removed.
  • khtml/editing/split_text_node_command.h: Removed.
  • khtml/editing/split_text_node_containing_element.cpp: Removed.
  • khtml/editing/split_text_node_containing_element_command.h: Removed.
  • khtml/editing/text_affinity.h: Removed.
  • khtml/editing/text_granularity.h: Removed.
  • khtml/editing/typing_command.cpp: Removed.
  • khtml/editing/typing_command.h: Removed.
  • khtml/editing/visible_position.cpp: Removed.
  • khtml/editing/visible_position.h: Removed.
  • khtml/editing/visible_range.cpp: Removed.
  • khtml/editing/visible_range.h: Removed.
  • khtml/editing/visible_text.cpp: Removed.
  • khtml/editing/visible_text.h: Removed.
  • khtml/editing/visible_units.cpp: Removed.
  • khtml/editing/visible_units.h: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.h: Removed.
1:40 PM Changeset in webkit [12802] by sullivan
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by Adele Peterson.


  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Added.
1:39 PM Changeset in webkit [12801] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.



Test cases:

  • dom/html/level2/html/HTMLOptionElement_label01.html
  • dom/html/level2/html/HTMLOptionElement_label02.html
  • dom/html/level2/html/HTMLOptionElement_label03.html
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): use label attribute, if present, when setting text on the widget.
1:18 PM Changeset in webkit [12800] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Change formatting in this file to match the style guidelines. No spaces after
opening parentheses or before closing parentheses.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::createDocumentFragment): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::write): (WebCore::DocumentImpl::writeln): (WebCore::DocumentImpl::setUserStyleSheet): (WebCore::DocumentImpl::determineParseMode): (WebCore::DocumentImpl::processHttpEquiv): (WebCore::DocumentImpl::childAllowed): (WebCore::DocumentImpl::childTypeAllowed): (WebCore::DocumentImpl::recalcStyleSelector): (WebCore::DocumentImpl::dispatchImageLoadEventsNow): (WebCore::DocumentImpl::domain): (WebCore::DocumentImpl::setDomain): (WebCore::DocumentImpl::parseQualifiedName): (WebCore::DocumentImpl::addMarker): (WebCore::DocumentImpl::removeMarkers):
11:13 AM Changeset in webkit [12799] by sullivan
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

Some cleanup from the previous checkin, inspired by Darin's comments


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: moved highlightAllMatchesForString out of here


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): now converts NSString to QString here, rather than in Frame/MacFrame


  • dom/DocumentMarker.h: Added. (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator == ): (WebCore::DocumentMarker::operator != ): moved this struct to its own header file


  • dom/DocumentImpl.h: moved DocumentMarker out; now includes DocumentMarker.h


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): moved here from MacFrame.[h,mm]. I thought this used other code from MacFrame.mm but it doesn't.


  • rendering/InlineTextBox.h: removed unnecesssary variable names; use DocumentMarker::MarkerType in signature of paintAllMarkersOfType
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paintTextMatchMarker): better name for a variable, fixed bad indent (khtml::InlineTextBox::paintAllMarkersOfType): rewrote loop to bail out early if past end, for clarity; use DocumentMarker::MarkerType in signature


  • WebCore.xcodeproj/project.pbxproj: updated for new file
10:09 AM Changeset in webkit [12798] by thatcher
  • 5 edits in tags/WebCore-521.7.1/WebCore

Merge the build fixes for case-sensitive drives to the tag. The #include "String.h" does not fail on normal HFS+ drives. Bump version to 521.7.1.

10:04 AM Changeset in webkit [12797] by thatcher
  • 1 copy in tags/WebCore-521.7.1/WebCore

New tag.

10:04 AM Changeset in webkit [12796] by thatcher
  • 1 add in tags/WebCore-521.7.1

New tag.

10:01 AM Changeset in webkit [12795] by thatcher
  • 3 edits in trunk/WebCore

More build fixes for case-sensitive drives. The #include "String.h" does not fail on normal HFS+ drives.

9:55 AM Changeset in webkit [12794] by thatcher
  • 1 edit in trunk/WebCore/loader/DocLoader.h

Build fix for case-sensitive drives.

8:57 AM Changeset in webkit [12793] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView highlightAllMatchesForString:caseSensitive:]): new method, calls through to bridge (-[WebHTMLView clearHighlightedMatches]): ditto
  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView highlightAllMatchesForString:caseSensitive:]): new method, calls through to documentView. For now this is hardwired to only work with WebHTMLViews. (-[WebView clearHighlightedMatches]): ditto
8:57 AM Changeset in webkit [12792] by sullivan
  • 8 edits in trunk/WebCore

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • dom/DocumentImpl.h: (WebCore::DocumentMarker::): Added new marker type TextMatch
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): new method, calls through to MacFrame implementation (-[WebCoreFrameBridge clearHighlightedMatches]): new method, removes all markers of type TextMatch
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::highlightAllMatchesForString): new method, adds a document marker for each range that matches the given string
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): Moved DocumentMarker loop into separate method paintAllMarkersOfType. We now call that method twice, once for spelling markers (after drawing text) and once for text match markers (before drawing text) (khtml::InlineTextBox::paintTextMatchMarker): new method, paints a color behind a text match marker (khtml::InlineTextBox::paintSpellingMarker): renamed from paintMarker (khtml::InlineTextBox::paintAllMarkersOfType): new method, loops through all DocumentMarkers of a particular type and calls the appropriate painting method for each one

Feb 13, 2006:

8:19 PM Changeset in webkit [12791] by darin
  • 23 edits
    1 add in trunk

WebCore:

Reviewed by Maciej.

  • move pointer from frame to page here from WebKit
  • WebCore.xcodeproj/project.pbxproj: Added PageMac.h.
  • bridge/mac/PageMac.h: Added.
  • bridge/mac/MacFrame.h: Added a page parameter to the constructor.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): Pass the page and renderer to the Frame constructor. Moved the call to Cache::init up into Frame, and got rid of the call to Frame::init since that's now handled by the constructor. Also put the code to create the browser extension object here. (WebCore::MacFrame::submitForm): Update for new method name. (WebCore::MacFrame::createFrame): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Update since m_doc is a RefPtr.
  • bridge/mac/WebCoreFrameBridge.h: Changed parameters on init methods. Renamed the part method to impl. Added a page method.
  • bridge/mac/WebCoreFrameBridge.mm: (frameHasSelection): Change use of part method to impl. (-[WebCoreFrameBridge appendChild:]): Use m_frame directly instead of calling part method. (-[WebCoreFrameBridge removeChild:]): Ditto. (-[WebCoreFrameBridge initMainFrameWithPage:]): Added. Now does the first-time initialization only here and create a frame for a main frame. (-[WebCoreFrameBridge initSubframeWithRenderer:]): Added. Doesn't do the first-time initialization and creates a frame for a subframe. (-[WebCoreFrameBridge page]): Added. (-[WebCoreFrameBridge setOpener:]): Change to use impl method instead of part. (-[WebCoreFrameBridge executionContextForView:]): Ditto. (-[WebCoreFrameBridge impl]): Added.
  • bridge/mac/WebCorePageBridge.h: Removed init method and added setMainFrame: method and impl method.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge init]): Changed to create a PageMac. (-[WebCorePageBridge setMainFrame:]): Added. (-[WebCorePageBridge impl]): Added.
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQSlider.mm: (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _isResizableByUser]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): Change methods to get from bridge back to objects to be named "impl". The old one was named "part".
  • page/Frame.h: Added Page and RenderPart parameter to constructor. Added a page function. Removed the createBrowserExtension function.
  • page/Frame.cpp: (WebCore::parentFromOwnerRenderer): Added. Helper for constructor. (WebCore::Frame::Frame): Moved all the code from init into here. Also change to set the parent right from the start. (WebCore::Frame::stopLoading): Change since m_doc is now a RefPtr. (WebCore::Frame::clear): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::setDocument): Ditto. (WebCore::Frame::begin): Ditto. (WebCore::Frame::gotoAnchor): Ditto. (WebCore::Frame::typingStyle): Change since m_typingStyle is now a RefPtr. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::isFrameSet): Change since m_doc is now a RefPtr. (WebCore::Frame::page): Added.
  • page/FramePrivate.h: Changed initialization to use member-initialization syntax. Removed unused m_frames. Changed m_doc and m_typingStyle to use RefPtr. Added an m_frame.
  • page/Page.h: Made destructor virtual so we could have a Mac derived class. Added a setMainFrame function and removed the mainFrame parameter from the constructor.
  • page/Page.cpp: (WebCore::Page::Page): Removed the mainFrame parameter. (WebCore::Page::setMainFrame): Added.

WebKit:

Reviewed by Maciej.

  • move pointer from frame to page over to WebCore
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Call super init to create the page before creating the main frame and calling setMainFrame: with it.
  • WebCoreSupport/WebFrameBridge.h: Remove page pointer, and change init function parameters.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): New function that is used only for the main frame. Passes the page over to the other side of the bridge. (-[WebFrameBridge initSubframeWithRenderer:frameName:view:]): New function that is used only for subframes. Passes the renderer over to the other side of the bridge. (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]): Change all calls to [_page webView] to use [self webView] instead.
8:11 PM Changeset in webkit [12790] by harrison
  • 2 edits in trunk/LayoutTests

Updated test case after improving table deletion.


  • selection/move-between-blocks-no-001-expected.txt: Updated.
7:29 PM Changeset in webkit [12789] by harrison
  • 8 edits in trunk/WebCore

Reviewed by Justin.

  • merge VisiblePosition:isCandidate() into Position::inRenderedContent() These functions were answering the same question in different ways! We only need one implementation.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::deepEquivalent):
  • khtml/editing/visible_position.h:
  • dom/dom_position.cpp: (DOM::hasRenderedChildrenWithHeight): (DOM::Position::inRenderedContent):
  • improved table deletion. Fixes: delete back by word from just after table did not delete the table

delete forward by char or word did not delete the table
deleting back to a table and again did not delete the table

  • khtml/editing/htmlediting.cpp: (WebCore::isFirstVisiblePositionAfterTableElement): simpler implementation (WebCore::positionBeforePrecedingTableElement): simpler implementation (WebCore::isFirstVisiblePositionBeforeTableElement): new (WebCore::positionAfterFollowingTableElement): new
  • khtml/editing/htmlediting.h:
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): select following table if granularity is char or word (WebCore::SelectionController::modifyExtendingLeftBackward): select preceding table if granularity is char or word
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): simpler implementation, and let other deleteKeyPressed do boundary checking (khtml::TypingCommand::forwardDeleteKeyPressed): simpler implementation, and let other forwardDeleteKeyPressed do boundary checking (khtml::TypingCommand::insertText): standard formatting (khtml::TypingCommand::insertLineBreak): standard formatting (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): standard formatting (khtml::TypingCommand::insertParagraphSeparator): standard formatting (khtml::TypingCommand::insertTextRunWithoutNewlines): standard formatting (khtml::TypingCommand::deleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks (khtml::TypingCommand::forwardDeleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks
5:01 PM Changeset in webkit [12788] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 5605, XSLT fails to import to arbitrary depth. Make sure m_embedded is initialized to false
in the XSLTStyleSheetImpl constructor.

Reviewed by timo

Adding xslt-import-depth.xml to fast/xsl

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::XSLStyleSheetImpl):
5:00 PM Changeset in webkit [12787] by hyatt
  • 5 adds in trunk/LayoutTests/fast/xsl

Add layout test for import depth.

3:13 PM Changeset in webkit [12786] by hyatt
  • 5 edits in trunk/WebCore

Fix Win32 WebCore bustage.

3:02 PM Changeset in webkit [12785] by eseidel
  • 2 edits in trunk/WebCore

2006-02-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7207.

No testcases as this is not possible to reproduce via anything
other than manual interaction.

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
2:49 PM Changeset in webkit [12784] by hyatt
  • 5 edits in trunk/JavaScriptCore

Fix Win32 JavaScriptCore bustage.

2:08 PM Changeset in webkit [12783] by thatcher
  • 9 copies in tags/Safari-521.7

New Tag

2:02 PM Changeset in webkit [12782] by darin
  • 55 edits
    1 copy
    2 moves
    1 delete in trunk/WebCore

Reviewed by Hyatt.

  • moved QWidget to platform directory, renamed to Widget, split into cross-platform and platform-specific parts, removed some of the unused bits
  • ForwardingHeaders/qwidget.h: Removed.
  • kwq/KWQWidget.h: Removed.
  • kwq/KWQWidget.mm: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Update for file removals and adds.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Widget.h: Moved code here, fixed it up.
  • platform/Widget.cpp: Ditto.
  • platform/mac/WidgetMac.mm: Added.
  • bindings/objc/DOMHTML.mm: (viewForElement):
  • bridge/mac/KWQKHTMLView.cpp: (WebCore::FrameView::topLevelWidget):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createPlugin): (WebCore::MacFrame::nextKeyViewInFrame): (WebCore::MacFrame::nextKeyViewForWidget): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::bridgeForWidget): (WebCore::MacFrame::passMouseDownEventToWidget): (WebCore::MacFrame::passSubframeEventToSubframe): (WebCore::MacFrame::passWheelEventToChildWidget): (WebCore::MacFrame::getAppletInstanceForWidget): (WebCore::MacFrame::getEmbedInstanceForWidget): (WebCore::MacFrame::getObjectInstanceForWidget):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge copyRenderNode:copier:]): (-[WebCoreFrameBridge elementForView:]): (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
  • dom/DocumentImpl.cpp: (WebCore::widgetForNode): (WebCore::DocumentImpl::setFocusNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::WindowFunc::callAsFunction):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): (WebCore::HTMLGenericFormElementImpl::isMouseFocusable):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLObjectElementImpl::getObjectInstance):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject attachmentView]): (-[KWQAccObject doAXTextMarkerForPosition:]):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QComboBox::setFont): (QComboBox::focusPolicy): (-[KWQPopUpButtonCell widget]): (-[KWQPopUpButton widget]): (-[KWQPopUpButton mouseDown:]): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]): (-[KWQPopUpButton nextKeyView]): (-[KWQPopUpButton previousKeyView]):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQFrame.h:
  • kwq/KWQKCursor.h:
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setFont): (QLineEdit::setPalette): (QLineEdit::focusPolicy):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::focusPolicy): (QListBox::setFont): (-[KWQListBoxScrollView widget]): (-[KWQListBoxScrollView becomeFirstResponder]): (-[KWQTableView mouseDown:]): (-[KWQTableView widget]):
  • kwq/KWQPainter.h:
  • kwq/KWQRenderTreeDebug.cpp: (write):
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollBar.mm: (-[KWQScrollBar widget]): (-[KWQScrollBar mouseDown:]): (QScrollBar::QScrollBar): (QScrollBar::~QScrollBar):
  • kwq/KWQScrollView.h: (QScrollView::QScrollView):
  • kwq/KWQScrollView.mm: (QScrollView::viewport): (QScrollView::childX): (QScrollView::childY): (QScrollView::addChild): (QScrollView::removeChild):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider widget]): (QSlider::setFont): (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView widget]):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setFont): (QTextEdit::focusPolicy): (QTextEdit::setPalette):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController widget]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextField widget]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQSecureTextField widget]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField widget]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]):
  • kwq/KWQView.h:
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::topLevelWidget):
  • page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::frameForWidget): (WebCore::Frame::nodeForWidget): (WebCore::Frame::setDocumentFocus): (WebCore::Frame::clearDocumentFocus): (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::init):
  • page/FrameView.h:
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
  • platform/Screen.h:
  • platform/mac/ScreenMac.mm: (WebCore::screen): (WebCore::screenDepth): (WebCore::screenRect): (WebCore::usableScreenRect):
  • rendering/render_applet.cpp: (WebCore::RenderApplet::layout):
  • rendering/render_form.cpp: (WebCore::ComboBoxWidget::ComboBoxWidget): (WebCore::RenderSelect::createListBox):
  • rendering/render_form.h:
  • rendering/render_frames.cpp: (WebCore::RenderPart::setWidget):
  • rendering/render_frames.h:
  • rendering/render_object.cpp:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::resizeWidget): (WebCore::RenderWidget::setQWidget):
  • rendering/render_replaced.h: (WebCore::RenderWidget::widget): Change name from QWidget to Widget, a few other changes to get compiling.
1:57 PM Changeset in webkit [12781] by thatcher
  • 8 edits in /

Versioning to 521.7

11:34 AM Changeset in webkit [12780] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Replaced the old NS_DURING exception blocking with @try/@catch.

  • JavaScriptCorePrefix.h: undef try and catch to workaround a C++ conflict
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::setValueAt): (ObjcArray::valueAt):
1:34 AM Changeset in webkit [12779] by darin
  • 3 edits in trunk/JavaScriptCore
  • kjs/JSImmediate.h: Change code using non-standard u_int32/64_t types to the standard uint32/64_t. Also removed curious "isIEEE()" function that checked the sizes of some types (and type sizes alone don't tell you if the floating point conforms to the IEEE-standard). Added missing include of <stdint.h>.
  • kjs/property_slot.h: Added missing include of <assert.h>.

Feb 12, 2006:

9:31 PM Changeset in webkit [12778] by darin
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

  • fast/replaced/page-as-image.html: Added.
  • fast/replaced/page-as-image-expected.txt: Added.
  • fast/replaced/page-as-image-expected.png: Added.
  • fast/replaced/page-as-image-expected.checksum: Added.
  • fast/replaced/resources/image.pdf: Added.
9:27 PM Changeset in webkit [12777] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/replaced/page-as-image.html

  • platform/Image.cpp: (WebCore::Image::setNativeData): Return false in the case where the PDF document has not been created yet.
8:11 PM Changeset in webkit [12776] by mjs
  • 15 edits
    14 deletes in trunk/LayoutTests

Rubber stamped by Geoff.


  • comment out remote <base> URLs, these were making the tests hang for a long time

This also made the affected tests start passing.


  • dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement01.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement02.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement03.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement04.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement05.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement06.xhtml:
  • dom/xhtml/level2/html/body01-expected.checksum: Removed.
  • dom/xhtml/level2/html/body01-expected.png: Removed.
  • dom/xhtml/level2/html/body01-expected.txt:
  • dom/xhtml/level2/html/body01.xhtml:
7:06 PM Changeset in webkit [12775] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Cleaned up testkjs, added new "run" functionality to allow scripting
tests from within JS. ("run" is a part of my new super-accurate
JS iBench.)

No regressions in run-javascriptcore-tests.

  • kjs/testkjs.cpp: (GlobalImp::className): (TestFunctionImp::): (TestFunctionImp::callAsFunction): (main): (run):
6:43 PM Changeset in webkit [12774] by darin
  • 4 edits
    1 move
    3 adds
    1 delete in trunk/WebCore

Reviewed by Maciej.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed old files, added new.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Timer.h: Updated for new timer implementation.
  • platform/Timer.cpp: Added. Platform-independent implementation of timers in terms of a single shared timer. Uses a heap to implement a priority queue so we know which timer to fire first.
  • platform/SharedTimer.h: Added.
  • platform/mac/SharedTimerMac.cpp: Added.
  • platform/win/SharedTimerWin.cpp: Added.
  • platform/mac/TimerMac.cpp: Removed.
  • platform/win/TimerWin.cpp: Removed.
4:51 PM Changeset in webkit [12773] by eseidel
  • 2 edits in trunk/WebCore

2006-02-12 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • loader/CachedXSLStyleSheet.cpp: removed duplicate copy of xbl code.
2:07 PM Changeset in webkit [12772] by eseidel
  • 3 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed by eseidel.

Added a little piece of text to the page about reductions, pointing to the bugzilla page.

Changed "Sign up for a" into "Create a" bugzilla account.

  • quality/reduction.html:
  • quality/reporting.html:
8:31 AM Changeset in webkit [12771] by mjs
  • 2 edits in trunk/WebCore

Unreviewed build fix.

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Update for splitting of the dom_textimpl.h header.
2:11 AM Changeset in webkit [12770] by mjs
  • 7 edits
    2 adds in trunk/WebKit

Reviewed by Hyatt.


  • DOM/WebDOMOperations.m: (-[DOMNode webArchive]): (-[DOMRange webArchive]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.h: Added.
  • WebView/WebArchiver.m: Added. (+[WebArchiver _subframeArchivesForFrame:]): (+[WebArchiver archiveFrame:]): (+[WebArchiver _archiveCurrentStateForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveRange:]): (+[WebArchiver archiveNode:]): (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebDataSource.m: (-[WebDataSource webArchive]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): (-[WebHTMLView _writeSelectionToPasteboard:]):
  • WebView/WebHTMLViewPrivate.h:
2:07 AM Changeset in webkit [12769] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Correct tyop in ChangeLog

2:03 AM Changeset in webkit [12768] by mjs
  • 13 edits
    2 moves in trunk/WebCore

Reviewed by Darin.


This may be slightly less accurate, but reads better.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::submitForm): (WebCore::MacFrame::nextKeyViewInFrameHierarchy):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstChild]): (-[WebCoreFrameBridge lastChild]): (-[WebCoreFrameBridge childCount]): (-[WebCoreFrameBridge previousSibling]): (-[WebCoreFrameBridge nextSibling]): (-[WebCoreFrameBridge appendChild:]): (-[WebCoreFrameBridge removeChild:]): (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::findFrame): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::tree): (WebCore::Frame::frameDetached): (WebCore::Frame::updateBaseURLForEmptyDocument):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp: Added. (WebCore::FrameTree::~FrameTree): (WebCore::FrameTree::setName): (WebCore::FrameTree::appendChild): (WebCore::FrameTree::removeChild):
  • page/FrameTree.h: Added. (WebCore::FrameTree::FrameTree):
  • page/FrameTreeNode.cpp: Removed.
  • page/FrameTreeNode.h: Removed.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
12:50 AM Changeset in webkit [12767] by hyatt
  • 4 edits in trunk/WebCore

Fix bug 7182, animated GIFs don't clear previous animation frames.

Feb 11, 2006:

7:10 PM Changeset in webkit [12766] by ggaren
  • 3 edits in trunk/WebCore
  • Fixed bad free resulting from 0 legnth StringImpl

No test case because currently this bug only has the effect of a bad
free on exit().

  • platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Factored varied approaches to initialization into two common routines: initWithChar and initWithQChar. The common rule is: if we're not going to allocate a string, make sure to set s to 0 so fastFree doesn't try to free it later. For speed, initWithQChar uses memcpy() -- that's the only difference between the two. (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar):
  • platform/StringImpl.h:
5:18 PM Changeset in webkit [12765] by mjs
  • 40 edits
    8 copies
    2 moves in trunk/WebCore

Rubber stamped by Eric.

  • split dom_textimpl.{h,cpp} by class.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bridge/mac/MacFrame.mm:
  • dom/CDATASectionImpl.cpp: Added.
  • dom/CDATASectionImpl.h: Added.
  • dom/CharacterDataImpl.cpp: Added.
  • dom/CharacterDataImpl.h: Added.
  • dom/CommentImpl.cpp: Added.
  • dom/CommentImpl.h: Added.
  • dom/DocumentImpl.cpp:
  • dom/EditingTextImpl.cpp: Added.
  • dom/EditingTextImpl.h: Added.
  • dom/NodeImpl.cpp:
  • dom/TextImpl.cpp: Added.
  • dom/TextImpl.h: Added.
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_elementimpl.cpp:
  • dom/dom_textimpl.cpp: Removed.
  • dom/dom_textimpl.h: Removed.
  • dom/xml_tokenizer.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/html/HTMLElementImpl.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • page/Frame.cpp:
  • rendering/RenderText.h:
  • rendering/render_frames.cpp:
4:51 PM Changeset in webkit [12764] by eseidel
  • 15 edits
    4 adds in trunk

2006-02-11 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

  • Layout tests changes:

Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg
New: svg/custom/coords-relative-units-transforms.svg

4:21 PM Changeset in webkit [12763] by darin
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by Darin.

Added a Bugzilla page, which contains information about creating a Bugzilla account, what editbugs and canconfirm
bits are and how to get them.


Changed link in reporting page to link to Bugzilla page.


  • quality/bugzilla.html: Added.
  • quality/reporting.html:
4:09 PM Changeset in webkit [12762] by darin
  • 2 edits
    13 moves in trunk/WebCore

Rubber-stamped by Eric.

  • renamed all the platform/mac files to have a Mac suffix (Hyatt and I discussed this change recently)
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/Color.mm: Removed.
  • platform/mac/ColorMac.mm: Added.
  • platform/mac/FloatPoint.mm: Removed.
  • platform/mac/FloatPointMac.mm: Added.
  • platform/mac/FloatRect.mm: Removed.
  • platform/mac/FloatRectMac.mm: Added.
  • platform/mac/FloatSize.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Added.
  • platform/mac/Image.mm: Removed.
  • platform/mac/ImageMac.mm: Added.
  • platform/mac/ImageSource.cpp: Removed.
  • platform/mac/ImageSourceMac.cpp: Added.
  • platform/mac/IntPoint.mm: Removed.
  • platform/mac/IntPointMac.mm: Added.
  • platform/mac/IntRect.mm: Removed.
  • platform/mac/IntRectMac.mm: Added.
  • platform/mac/IntSize.mm: Removed.
  • platform/mac/IntSizeMac.mm: Added.
  • platform/mac/QString.mm: Removed.
  • platform/mac/QStringMac.mm: Added.
  • platform/mac/Screen.mm: Removed.
  • platform/mac/ScreenMac.mm: Added.
  • platform/mac/SystemTime.cpp: Removed.
  • platform/mac/SystemTimeMac.cpp: Added.
  • platform/mac/Timer.cpp: Removed.
  • platform/mac/TimerMac.cpp: Added.
3:54 PM Changeset in webkit [12761] by eseidel
  • 327 edits in trunk/WebCore

2006-02-11 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Push kcanvas into WebCore namespace.
Fix KSVG2 to use WebCore namespace.

Remove all uses of khtml
and KDOM:: from SVG code. Too many files changed to bother showing here.
3:38 PM Changeset in webkit [12760] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/events/event-targets.html: Fixed a small mistake in this test, noticed while checking that bug 3609 is fixed in tip of tree.
3:19 PM Changeset in webkit [12759] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed by eseidel.

  • Changed 10.2 paragraph to say Mac OS X instead of just OS X
  • Detabified the file.
  • quality/reporting.html:
12:11 PM Changeset in webkit [12758] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.



  • fast/replaced/width100percent-expected.checksum: Updated.
  • fast/replaced/width100percent-expected.png: Updated.
  • fast/replaced/width100percent-expected.txt: Updated.
  • fast/table/edge-offsets-expected.checksum: Added.
  • fast/table/edge-offsets-expected.png: Added.
  • fast/table/edge-offsets-expected.txt: Added.
  • fast/table/edge-offsets.html: Added.

WebCore:

Test: fast/table/edge-offsets.html


Reviewed by Hyatt.



  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): Override the superclass implementation to return the lowest of all the cells' lowest positions and the section's. (WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost. (WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost.
  • rendering/RenderTableSection.h:
11:56 AM Changeset in webkit [12757] by adele
  • 3 edits in trunk/WebCore

No test until we figure out how to make one.

Reviewed by Darin.



  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Removed the call to setParsing(false) from here since it stopped parsing prematurely. Now the frame will call it when the tokenizer is finished.
  • page/Frame.cpp: (WebCore::Frame::clear): Disconnect the finishedParsing signal handler from the document. (WebCore::Frame::setDocument): Disconnect the signal handler from the old document and connect it to the new document.
11:39 AM Changeset in webkit [12756] by adele
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.



  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::hoveredNodeDetached): Added this method. Moved the hover logic from NodeImpl::detach here, modified to use the DOM tree instead of hoverAncestor, to handle the case that the hover node is a text node, and to schedule an update of hover state. (WebCore::DocumentImpl::activeChainNodeDetached): Added this method to trim the active chain above the node being detached.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Moved most of the hover logic out of here into DocumentImpl. Reset m_active and m_inActiveChain and call activeChainNodeDetached when detaching an active node.
  • manual-tests/bugzilla-6821.html: Added.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added hover-state update timer. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::hoverTimerFired): Call DocumentImpl::prepareMouseEvent when the timer fires to cause hover state to update. (WebCore::FrameView::scheduleHoverStateUpdate): Added.
  • page/FrameView.h:
9:58 AM Changeset in webkit [12755] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated paths for recent changes in directory structure.
8:03 AM Changeset in webkit [12754] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

  • English.lproj/Localizable.strings: Added new UI_STRING().
  • Misc/WebKitErrors.m: Added #define for description. (registerErrors): Added dictionary entry.
2:48 AM Changeset in webkit [12753] by ap
  • 4 edits
    12 adds in trunk

Reviewed by Darin.

Test cases:

  • fast/frames/frame-set-same-location.html
  • fast/frames/frame-set-same-src.html
  • fast/frames/iframe-set-same-location.html
  • fast/frames/iframe-set-same-src.html
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::setLocation): Remove the check for the new URL being different from the current one. Moved updateForNewURL() code into setLocation().
  • khtml/html/html_baseimpl.h:
2:34 AM Changeset in webkit [12752] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use kCFStringEncodingISOLatin1 rather than kCFStringEncodingWindowsLatin1, because the latter encoding has holes, and conversion can still fail.
12:34 AM Changeset in webkit [12751] by eseidel
  • 1 edit
    9 adds in trunk/LayoutTests

2006-02-11 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • fast/parser/external-entities-expected.checksum: Added.
  • fast/parser/external-entities-expected.png: Added.
  • fast/parser/external-entities-expected.txt: Added.
  • fast/parser/external-entities-in-xslt-expected.txt: Added.
  • fast/parser/external-entities-in-xslt.xml: Added.
  • fast/parser/external-entities.xml: Added.
  • fast/parser/resources: Added.
  • fast/parser/resources/external-entities.dtd: Added.
  • fast/parser/resources/external-entities.xsl: Added.
12:15 AM Changeset in webkit [12750] by eseidel
  • 5 edits in trunk/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
  • dom/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h:

Feb 10, 2006:

11:35 PM Changeset in webkit [12749] by hyatt
  • 1 edit in trunk/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp

Make sure the GIF decoder behaves properly when the first frame of a GIF does not cover the entire image.

11:07 PM Changeset in webkit [12748] by hyatt
  • 14 edits in trunk/WebCore

Implement an optimization to detect whether or not an image has alpha and do a blit instead of a blend in that case. r=eric

6:16 PM Changeset in webkit [12747] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for <rdar://problem/4149655> Frequently reported crash,
repro at lastminute.se in khtml::RenderBlock::createLineBoxes

6:08 PM Changeset in webkit [12746] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4149655> Frequently reported crash, repro
at lastminute.se in khtml::RenderBlock::createLineBoxes

Some crazy combination of an anonymous table, an inline form, and
generated content caused table objects to be added to a flow and
then split. This is very bad. Once the crash was fixed, there were
still some rendering issues that this patch also fixes. We needed
to make sure we only special case forms for non-CSS tables so that
the form and generated content render as expected.

5:36 PM Changeset in webkit [12745] by thatcher
  • 2 edits in tags/WebCore-417.21/WebCore/khtml/ecma

Build fix

5:34 PM Changeset in webkit [12744] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore/khtml/ecma

Build fix.

5:18 PM Changeset in webkit [12743] by thatcher
  • 3 copies in tags/WebCore-417.21/WebCore

New tag.

5:17 PM Changeset in webkit [12742] by thatcher
  • 1 add in tags/WebCore-417.21

New tag

5:13 PM Changeset in webkit [12741] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.21

5:09 PM Changeset in webkit [12740] by eseidel
  • 2 edits in branches/Safari-2-0-branch/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4145813> hang in XMLHttpRequest::cancelRequests
No test case possible.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::removeFromRequestsByDocument): (KJS::XMLHttpRequest::removeFromRequestsByDocument): (KJS::XMLHttpRequest::cancelRequests):
2:57 PM Changeset in webkit [12739] by darin
  • 2 edits in trunk/WebKitSite
  • index.html: Fixed a typo in a link.
1:24 PM Changeset in webkit [12738] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim O.

Rolling out r11800 and reworked Tim's original fix
to call _NPN_DeallocateObject in the destructor.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::setView): (KWQKHTMLPart::cleanupPluginRootObjects):
10:47 AM Changeset in webkit [12737] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Inlined RefPtr assignment operators. .7% performance win on super-accurate JS iBench.
  • kxmlcore/RefPtr.h: (KXMLCore::::operator):
9:31 AM Changeset in webkit [12736] by darin
  • 2 edits in trunk/WebKitSite/coding

Some factual corrections and some updates to the coding style
document to reflect our current practices.

9:11 AM Changeset in webkit [12735] by darin
  • 2 edits in trunk/WebKitSite
  • building/checkout.html: Fixed a spelling mistake.
8:41 AM Changeset in webkit [12734] by darin
  • 4 edits in trunk/WebCore
  • fixed the build, this time for sure
  • bindings/js/JSDOMCore.cpp: Touch this file, since the project doesn't get the dependencies right.
  • bindings/js/JSDOMEvents.cpp: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Fix an uninitialized variable warning and also tightened the code for Boolean, String, and Number up a bit.
2:14 AM Changeset in webkit [12733] by andersca
  • 36 edits in trunk/WebKitSite

2006-02-10 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup

Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code

  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • index.html:
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • webkitdev.css:
1:49 AM Changeset in webkit [12732] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj

Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.

1:47 AM Changeset in webkit [12731] by hyatt
  • 9 edits in trunk/WebCore/platform/cairo

Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.

1:03 AM Changeset in webkit [12730] by ggaren
  • 2 edits in trunk/JavaScriptCore

No review needed, just a build fix. This time for sure.

  • kjs/JSType.h:
12:42 AM Changeset in webkit [12729] by ggaren
  • 13 edits in trunk

JavaScriptCore:

Reviewed by eric.


  • Fixed build. As it goes without saying, I will not mention that I blame Kevin.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toObject):

JavaScriptGlue:

Reviewed by eric.

  • Fixed build.
  • UserObjectImp.cpp: (UserObjectImp::toPrimitive):
  • UserObjectImp.h:

WebCore:

Reviewed by eric.

  • Fixed build.
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toPrimitive): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Location::toPrimitive): (KJS::Selection::toPrimitive):
  • khtml/ecma/kjs_window.h:

Feb 9, 2006:

10:42 PM Changeset in webkit [12728] by ggaren
  • 27 edits
    1 move
    2 adds in trunk/JavaScriptCore

Reviewed by mjs.

  • Fixed <rdar://problem/4343730> Should switch ConstantValues (null, undefined, true, false) from JS objects to immediate values similar to SimpleNumber

2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)

The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.

The rest pretty much explains itself.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h, added JSImmediate.h/.cpp.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue):
  • bindings/c/c_instance.h:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Standardized calls to use getXXX instead of hand-rolling JSValue functionality.
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::defaultValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h:
  • kjs/JSImmediate.h: Added. (KJS::JSImmediate::isImmediate): (KJS::JSImmediate::isNumber): (KJS::JSImmediate::isBoolean): (KJS::JSImmediate::isUndefinedOrNull): (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::toBoolean): (KJS::JSImmediate::trueImmediate): (KJS::JSImmediate::falseImmediate): (KJS::JSImmediate::NaNImmediate): (KJS::JSImmediate::undefinedImmediate): (KJS::JSImmediate::nullImmediate): (KJS::JSImmediate::tag): (KJS::JSImmediate::unTag): (KJS::JSImmediate::getTag): (KJS::JSImmediate::): (KJS::JSImmediate::isIEEE): (KJS::JSImmediate::is32bit): (KJS::JSImmediate::is64bit): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::zeroAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/JSLock.cpp: (KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
  • kjs/JSType.h: Added.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::StringImp::toPrimitive): (KJS::NumberImp::toPrimitive): (KJS::NumberImp::toBoolean): (KJS::GetterSetterImp::toPrimitive):
  • kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
  • kjs/object.cpp: (KJS::JSObject::type): (KJS::tryGetAndCallProperty): Replaced "Are you one of the six things I'm looking for?" test with "Are you not the one thing I'm not looking for" test. (KJS::JSObject::defaultValue): (KJS::JSObject::toPrimitive):
  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::JSValue::isObject):
  • kjs/operations.cpp: (KJS::equal): (KJS::strictEqual): (KJS::add):
  • kjs/reference.cpp: (KJS::Reference::deleteValue):
  • kjs/simple_number.h: Removed.
  • kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): fixed indentation
  • kjs/value.cpp: (KJS::JSValue::toObject): (KJS::jsNumberCell): New function to quarantine a PIC branch -- allows us to inline jsNumber without adding PIC branches to callers.
  • kjs/value.h: (KJS::jsUndefined): (KJS::jsNull): (KJS::jsNaN): (KJS::jsBoolean): (KJS::jsNumber): (KJS::JSValue::downcast): (KJS::JSValue::isUndefinedOrNull): (KJS::JSValue::isBoolean): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getBoolean): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion, resulting in a slight performance gain. Callers should always check !marked() before calling mark(), so it's impossible to call mark on a JSImmediate. (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString):
5:30 PM Changeset in webkit [12727] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56

I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.


  • Plugins/WebBaseNetscapePluginStream.h: Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could potentially be deallocated before the stream finishes loading.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream dealloc]): Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown phase. Release pluginView instead of plugin. (-[WebBaseNetscapePluginStream setPluginPointer:]): Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while the stream is running. This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer (and other ivars derived from it). (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]): Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called for every plugin view's stream when the plugin view is stopped/destroyed. (-[WebBaseNetscapePluginStream _deliverData]): Use pluginView instead of plugin.
5:20 PM Changeset in webkit [12726] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/4430614> RenderThemeMac crashes under GC
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers. (WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so we can retain a pointer to an ObjC object in a C++ class. (WebCore::RenderThemeMac::setRadioCellState): Ditto. (WebCore::RenderThemeMac::setButtonCellState): Ditto. (WebCore::RenderThemeMac::setTextFieldCellState): Ditto.
  • kwq/KWQResourceLoader.h: Remove unneeded forward declaration.
4:09 PM Changeset in webkit [12725] by darin
  • 33 edits in trunk/WebCore

Reviewed by Eric and Geoff.

  • changed basic DOM mutation calls to assert that "this" is not floating, then added more uses of RefPtr to prevent the assertion from firing (at least during my testing and layout tests)
  • removed use of PassRefPtr as the type of a local variable; after talking with Maciej and Eric, this type of use is now "deprecated"
  • bindings/js/JSDOMCore.cpp: Touched this file to get things to build.
  • bindings/objc/DOM.mm: (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange cloneRange]):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction):
  • khtml/editing/Selection.cpp: (WebCore::Selection::toRange):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
  • dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • dom/DocPtr.h: Removed uses of NULL and unused deprecated functions.
  • dom/dom2_rangeimpl.h:
  • dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::RangeImpl): (WebCore::RangeImpl::startContainer): (WebCore::RangeImpl::endContainer): (WebCore::RangeImpl::commonAncestorContainer): (WebCore::RangeImpl::setStart): (WebCore::RangeImpl::setEnd): (WebCore::RangeImpl::collapse): (WebCore::RangeImpl::compareBoundaryPoints): (WebCore::RangeImpl::boundaryPointsValid): (WebCore::RangeImpl::processContents): (WebCore::RangeImpl::extractContents): (WebCore::RangeImpl::cloneContents): (WebCore::RangeImpl::insertNode): (WebCore::RangeImpl::createContextualFragment): (WebCore::RangeImpl::detach): (WebCore::RangeImpl::cloneRange): (WebCore::RangeImpl::selectNodeContents): (WebCore::RangeImpl::surroundContents): (WebCore::RangeImpl::containedByReadOnly): (WebCore::RangeImpl::startPosition): (WebCore::RangeImpl::endPosition): (WebCore::RangeImpl::startNode): (WebCore::RangeImpl::editingStartPosition): (WebCore::rangeOfContents):
  • dom/dom_elementimpl.h:
  • dom/dom_elementimpl.cpp: (WebCore::AttrImpl::AttrImpl): (WebCore::AttrImpl::~AttrImpl): (WebCore::AttrImpl::setValue): (WebCore::AttrImpl::childTypeAllowed): (WebCore::AttrImpl::childrenChanged): (WebCore::ElementImpl::removeAttributeNode): (WebCore::NamedAttrMapImpl::clearAttributes): (WebCore::CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (WebCore::MappedAttributeImpl::clone):
  • dom/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityReferenceImpl::cloneNode): (WebCore::ProcessingInstructionImpl::ProcessingInstructionImpl): (WebCore::ProcessingInstructionImpl::checkStyleSheet): (WebCore::ProcessingInstructionImpl::setStyleSheet):
  • dom/dom_position.cpp:
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::createBlockPlaceholderElement):
  • khtml/editing/delete_selection_command.cpp: (WebCore::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): (WebCore::nonBreakingSpaceString): (WebCore::createDefaultParagraphElement): (WebCore::createBreakElement): (WebCore::createTabSpanElement):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::insertTab):
  • khtml/editing/markup.cpp: (khtml::createFragmentFromMarkup): (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_text.cpp: (khtml::CharacterIterator::range): (khtml::findPlainText):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer):
1:33 PM Changeset in webkit [12724] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Adding eol-style.

1:31 PM Changeset in webkit [12723] by thatcher
  • 1 copy
    1 add in trunk/WebKit

Rolling over the ChangeLog.

11:22 AM Changeset in webkit [12722] by ap
  • 3 edits in trunk/WebKitSite

Fixes by Mark Rowe and Joost de Valk. Reviewed by Darin. Landed by ap.



  • quality/reporting.html:
  • webkitdev.css: Added margin-bottom for li.
11:21 AM Changeset in webkit [12721] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4198378> Crash on a CFRelease when visiting ​http://www.akella.com/

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the Real Player plugin's fault. That has been filed as 4439591. However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1 to ISO Latin 1, so that any NULL-terminated string can be represented. (As Darin and I found out last night, Windows Latin 1 has "holes" in certain character ranges and thus cannot encode arbitrary C strings).
2:16 AM Changeset in webkit [12720] by mjs
  • 4 edits in trunk/WebCore

Reviewed and landed by Maciej.


Factor out common parts of Linear/Radial GradientQuartz
up into KRenderingPaintServerGradientQuartz.

Cleanup only, no layout tests needed or affected.

  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (KRenderingPaintServerGradientQuartz::draw): (KRenderingPaintServerGradientQuartz::setup): (KRenderingPaintServerGradientQuartz::renderPath): (KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerLinearGradientQuartz::renderPath): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::renderPath):
1:54 AM Changeset in webkit [12719] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • various Frame cleanup:


Make Frame-related classes Noncopyable.
Remove nearly all of Frame's friends.
Remove some unused stuff.
Remove unneeded class forward declarations from Frame.h

  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/FrameView.cpp: (WebCore::FrameView::viewportMouseMoveEvent):
  • page/Page.h: (WebCore::Page::mainFrame):
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
1:36 AM Changeset in webkit [12718] by mjs
  • 2 edits
    14 moves
    1 add in trunk/WebKit

Rubber stamped by Anders.


  • Moved all the default delegate classes to their own directory.
  • DefaultDelegates: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.h: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.h: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.m: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.h: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.m: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.h: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: Added.
  • DefaultDelegates/WebDefaultUIDelegate.h: Added.
  • DefaultDelegates/WebDefaultUIDelegate.m: Added.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDefaultContextMenuDelegate.h: Removed.
  • WebView/WebDefaultContextMenuDelegate.m: Removed.
  • WebView/WebDefaultEditingDelegate.h: Removed.
  • WebView/WebDefaultEditingDelegate.m: Removed.
  • WebView/WebDefaultFrameLoadDelegate.h: Removed.
  • WebView/WebDefaultFrameLoadDelegate.m: Removed.
  • WebView/WebDefaultPolicyDelegate.h: Removed.
  • WebView/WebDefaultPolicyDelegate.m: Removed.
  • WebView/WebDefaultResourceLoadDelegate.h: Removed.
  • WebView/WebDefaultResourceLoadDelegate.m: Removed.
  • WebView/WebDefaultScriptDebugDelegate.h: Removed.
  • WebView/WebDefaultScriptDebugDelegate.m: Removed.
  • WebView/WebDefaultUIDelegate.h: Removed.
  • WebView/WebDefaultUIDelegate.m: Removed.
1:09 AM Changeset in webkit [12717] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Minor image cleanup to the decoders. Doesn't affect Mac.

12:46 AM Changeset in webkit [12716] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj/WebCore

Update Win32 project to account for the khtml/xml to dom move.

12:26 AM Changeset in webkit [12715] by mjs
  • 50 edits
    1 move in trunk/WebCore

Rubber-stamped by Hyatt.


  • moved khtml/xml to dom
  • dom: moved from khtml/xml
  • WebCore.xcodeproj/project.pbxproj: Updated for new file locations.
  • WebCore+SVG/KDOMHeaders.h: Updated for new header locations.
  • dom/dom2_rangeimpl.cpp: ditto
  • dom/dom2_traversalimpl.cpp: ditto
  • dom/dom_textimpl.cpp: ditto
  • dom/dom_xmlimpl.cpp: ditto
  • khtml/dom/dom2_events.cpp: ditto
  • khtml/ecma/kjs_binding.cpp: ditto
  • khtml/ecma/kjs_dom.cpp: ditto
  • khtml/ecma/kjs_events.cpp: ditto
  • khtml/ecma/kjs_html.cpp: ditto
  • khtml/ecma/kjs_range.cpp: ditto
  • khtml/ecma/kjs_views.cpp: ditto
  • khtml/editing/Selection.cpp: ditto
  • khtml/editing/SelectionController.cpp: ditto
  • khtml/editing/delete_from_text_node_command.cpp: ditto
  • khtml/editing/edit_command.cpp: ditto
  • khtml/editing/insert_into_text_node_command.cpp: ditto
  • khtml/editing/insert_line_break_command.cpp: ditto
  • khtml/editing/insert_paragraph_separator_command.cpp: ditto
  • khtml/editing/insert_text_command.cpp: ditto
  • khtml/editing/join_text_nodes_command.cpp: ditto
  • khtml/editing/markup.cpp: ditto
  • khtml/editing/merge_identical_elements_command.cpp: ditto
  • khtml/editing/rebalance_whitespace_command.cpp: ditto
  • khtml/editing/remove_node_attribute_command.cpp: ditto
  • khtml/editing/set_node_attribute_command.cpp: ditto
  • khtml/editing/split_element_command.cpp: ditto
  • khtml/editing/split_text_node_command.cpp: ditto
  • khtml/editing/split_text_node_containing_element.cpp: ditto
  • khtml/editing/visible_position.cpp: ditto
  • khtml/editing/visible_position.h: ditto
  • khtml/editing/visible_text.cpp: ditto
  • khtml/editing/visible_text.h: ditto
  • khtml/editing/visible_units.cpp: ditto
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: ditto
  • khtml/html/HTMLElementImpl.h: ditto
  • khtml/html/html_documentimpl.cpp: ditto
  • khtml/html/html_headimpl.cpp: ditto
  • khtml/xbl/xbl_binding_manager.cpp: ditto
  • khtml/xbl/xbl_tokenizer.cpp: ditto
  • khtml/xbl/xbl_tokenizer.h: ditto
  • ksvg2/svg/SVGAElementImpl.cpp: ditto
  • rendering/InlineTextBox.cpp: ditto
  • rendering/RenderContainer.cpp: ditto
  • rendering/RenderText.h: ditto
  • rendering/RenderTextField.cpp: ditto
  • rendering/render_frames.cpp: ditto
  • rendering/render_layer.cpp: ditto
12:03 AM Changeset in webkit [12714] by eseidel
  • 2 edits
    1 move in trunk/WebKitTools

2006-02-09 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Renamed split-class to split-file-by-class.

  • Scripts/build-webkit: Updated copyright.
  • Scripts/split-class: Removed.
  • Scripts/split-file-by-class: Added.

Feb 8, 2006:

11:59 PM Changeset in webkit [12713] by eseidel
  • 2 edits
    2 adds in trunk/WebKitTools

2006-02-08 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Adding new script for splitting multi-class files.
Also adding supporting perl module with space removing heuristics.

  • Scripts/SpacingHeuristics.pm: Added.
  • Scripts/build-drawtest: updated copyright header
  • Scripts/split-class: Added.
11:50 PM Changeset in webkit [12712] by thatcher
  • 3 edits
    7 adds in trunk

Test: fast/block/positioning/window-height-change.html

Reviewed by Hyatt.


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Always relayout positioned children of the root, since their positions may depend on the viewport's height which may have changed.
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): Ditto.
11:08 PM Changeset in webkit [12711] by justing
  • 180 edits in trunk/LayoutTests/editing
11:06 PM Changeset in webkit [12710] by justing
  • 165 edits in trunk/LayoutTests/editing/pasteboard
11:05 PM Changeset in webkit [12709] by justing
  • 227 edits in trunk/LayoutTests/editing
11:04 PM Changeset in webkit [12708] by justing
  • 342 edits in trunk/LayoutTests/editing
11:02 PM Changeset in webkit [12707] by justing
  • 5 edits in trunk/LayoutTests/fast/overflow
11:01 PM Changeset in webkit [12706] by justing
  • 1 edit in trunk/LayoutTests/fast/events/div-focus-expected.txt
11:00 PM Changeset in webkit [12705] by justing
  • 5 edits
    4 adds in trunk/LayoutTests/fast/dom
10:56 PM Changeset in webkit [12704] by justing
  • 3 edits in trunk/LayoutTests/fast/forms
10:56 PM Changeset in webkit [12703] by justing
  • 2 edits in trunk/LayoutTests/fast/selectors
10:55 PM Changeset in webkit [12702] by justing
  • 15 edits in trunk/LayoutTests/fast/text
10:54 PM Changeset in webkit [12701] by justing
  • 158 edits
    8 adds in trunk/LayoutTests/editing/selection
10:53 PM Changeset in webkit [12700] by mjs
  • 1 edit
    1 add in trunk/LayoutTests

Add missing file from earlier added svg test.

  • svg/custom/resources/link-target.html: Added.
10:45 PM Changeset in webkit [12699] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Add reviewer to an old check-in (remove forbidden OOPS).

10:43 PM Changeset in webkit [12698] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

OK, OOPS-prevention is working now.

10:39 PM Changeset in webkit [12697] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add libjpeg to the Win32 project.

10:38 PM Changeset in webkit [12696] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
10:37 PM Changeset in webkit [12695] by hyatt
  • 42 adds in trunk/WebCore/platform/image-decoders/jpeg

Add libjpeg to the tree.

10:34 PM Changeset in webkit [12694] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Can't the damn pre-commit work!

10:33 PM Changeset in webkit [12693] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

I should not be able to check this change in because it has OOPS in a ChangeLog file.

10:33 PM Changeset in webkit [12692] by hyatt
  • 4 edits in trunk/WebCore

Tiling of images on Win32 is supported now.

10:31 PM Changeset in webkit [12691] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Since there's OOPS in ChangeLog this should fail.

10:27 PM Changeset in webkit [12690] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Testing new OOPS pre-commit action.

10:20 PM Changeset in webkit [12689] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added mention of test for the last check-in.

10:16 PM Changeset in webkit [12688] by darin
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

  • fast/dom/Element: Added.
  • fast/dom/Element/setAttribute-with-colon.html: Added.
  • fast/dom/Element/setAttribute-with-colon-expected.txt: Added.
10:16 PM Changeset in webkit [12687] by darin
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • khtml/xml/dom_elementimpl.h: (ElementImpl::setAttribute): Removed body
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): Changed code so that attribute is not parsed into prefix and local name.
9:51 PM Changeset in webkit [12686] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage. Added libjpeg prematurely to the project.

9:25 PM Changeset in webkit [12685] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
9:23 PM Changeset in webkit [12684] by justing
  • 4 edits in trunk/WebKit

Original patch by Graham Dennis, reviewed by me:


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate


Changes made by me, reviewed by thatcher:


Made _setWindowHasFocus: and _setDisplaysWithFocusAttributes: into private SPI to allow
for the testing of window.onFocus, window.onBlur, caret and focus halo painting, and
the focusing of content editable regions that happens as side effect of setting a selection,
but only if the window has focus (7128).

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didBeginEditing]): (-[WebFrameBridge didEndEditing]):
  • WebView/WebHTMLView.m: (-[WebHTMLView updateFocusState]): (-[WebHTMLView _setWindowHasFocus:]): (-[WebHTMLView _setDisplaysWithFocusAttributes:]):
  • WebView/WebHTMLViewPrivate.h:
9:18 PM Changeset in webkit [12683] by justing
  • 8 edits in trunk/WebCore

Original patch by Graham Dennis, reviewed by me
Changes made by me, reviewed by thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::didBeginEditing): (WebCore::MacFrame::didEndEditing):
  • bridge/mac/WebCoreFrameBridge.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::didBeginEditing): (WebCore::DocumentImpl::didEndEditing): (WebCore::DocumentImpl::setFocusNode):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::focus):
  • page/Frame.h: (WebCore::Frame::didBeginEditing): (WebCore::Frame::didEndEditing):
8:44 PM Changeset in webkit [12682] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/positioning/relayout-on-position-change-expected.checksum: Added.
  • fast/block/positioning/relayout-on-position-change-expected.png: Added.
  • fast/block/positioning/relayout-on-position-change-expected.txt: Added.
  • fast/block/positioning/relayout-on-position-change.html: Added.
8:42 PM Changeset in webkit [12681] by darin
  • 2 edits in trunk/WebCore

Test: fast/block/positioning/relayout-on-position-change.html

Reviewed by Hyatt.

  • rendering/render_object.cpp: (WebCore::RenderObject::setStyle): The second call to setNeedsLayoutAndMinMaxRecalc did not mark containing blocks for relayout based on the new position value since the object itself was already marked as needing layout. Changed the first call to only mark the containing blocks (based on the old position value) and not the object itself.
8:09 PM Changeset in webkit [12680] by darin
  • 2 edits in trunk/WebKitSite

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4914
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4282

8:05 PM Changeset in webkit [12679] by darin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebPDFRepresentation.m: (+[WebPDFRepresentation postScriptMIMETypes]): Added. (+[WebPDFRepresentation supportedMIMETypes]): Include PostScript MIME types. (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Added. (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Handle PostScript conversion using new convertPostScriptDataSourceToPDF method.
7:50 PM Changeset in webkit [12678] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests
  • added SVG path hit testing test
  • svg/custom/hit-test-path-expected.checksum: Added.
  • svg/custom/hit-test-path-expected.png: Added.
  • svg/custom/hit-test-path-expected.txt: Added.
  • svg/custom/hit-test-path.svg: Added.
7:02 PM Changeset in webkit [12677] by mjs
  • 14 edits
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

RenderPath refactoring:


  • Rename the files to RenderPath
  • Push the portable code from KCanvasItemQuartz down to RenderPath
  • Move most of the unportable code from KCanvasItemQuartz to KCanvasPathQuartz


The only thing left in KCanvasItemQuartz is marker support. That should be factored to separate
iterating the path elements (KCanvasPathQuartz needs to provide that) and drawing the markers
(which should be done in portable code).

  • ForwardingHeaders/kcanvas/RenderPath.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasItem.cpp: Removed.
  • kcanvas/KCanvasItem.h: Removed.
  • kcanvas/KCanvasPath.h:
  • kcanvas/RenderPath.cpp: Added. (RenderPath::mapAbsolutePointToLocal): (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::strokeBBox): (RenderPath::relativeBBox): (RenderPath::setPath): (RenderPath::layout): (RenderPath::getAbsoluteRepaintRect): (RenderPath::requiresLayer): (RenderPath::lineHeight): (RenderPath::baselinePosition): (RenderPath::paint): (RenderPath::nodeAtPoint):
  • kcanvas/RenderPath.h: Added.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasPathQuartz.h:
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: (KCanvasPathQuartz::boundingBox): (scratchContext): (KCanvasPathQuartz::strokeBoundingBox): (pathContainsPoint): (KCanvasPathQuartz::containsPoint): (KCanvasPathQuartz::strokeContainsPoint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createItem):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::updateCanvasItem): (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledLocatableElementImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
6:32 PM Changeset in webkit [12676] by adele
  • 2 edits in trunk/WebCore

Fix broken layout tests.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): iterator is null, so we have to reset it to the first node in the chain.
5:41 PM Changeset in webkit [12675] by adele
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)
  • fast/events/window-events-bubble-expected.txt: Added.
  • fast/events/window-events-bubble.html: Added.
  • fast/events/window-events-bubble2-expected.txt: Added.
  • fast/events/window-events-bubble2.html: Added.
  • fast/events/window-events-capture-expected.txt: Added.
  • fast/events/window-events-capture.html: Added.

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

  • fast/events/window-events-bubble.html
  • fast/events/window-events-bubble2.html
  • fast/events/window-events-capture.html
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
  • khtml/xml/DocumentImpl.h: Added handleWindowEvent.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
5:35 PM Changeset in webkit [12674] by thatcher
  • 1 edit in tags/WebCore-521.6.3/WebCore/Info.plist

Versioning.

5:32 PM Changeset in webkit [12673] by thatcher
  • 1 copy in tags/WebCore-521.6.3/WebCore

New tag.

5:32 PM Changeset in webkit [12672] by thatcher
  • 1 add in tags/WebCore-521.6.3

New tag.

5:30 PM Changeset in webkit [12671] by thatcher
  • 2 edits in tags/Safari-521.6.2/WebCore/css

Build fix when using sh 3.1

5:27 PM Changeset in webkit [12670] by thatcher
  • 2 edits in trunk/WebCore/css

Build fix to not use echo -e. This failed to build with sh 3.1.

3:49 PM Changeset in webkit [12669] by hyatt
  • 8 edits in trunk/WebCore/WebCore.vcproj/Image Viewer

Undo my checking of red painting that I landed by accident.

2:46 PM Changeset in webkit [12668] by hyatt
  • 7 edits in trunk/WebCore

Improved Cairo image rendering by only building the surface from the portion of the buffer that has been decoded so far.

2:08 PM Changeset in webkit [12667] by thatcher
  • 1 delete in Safari-417.9

Removing a mistake copy.

2:06 PM Changeset in webkit [12666] by thatcher
  • 8 copies in tags/Safari-417.9

Tagging.

1:54 PM Changeset in webkit [12665] by thatcher
  • 8 copies in Safari-417.9

Tagging.

1:47 PM Changeset in webkit [12664] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning the CHangeLogs.

1:44 PM Changeset in webkit [12663] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/JavaScriptCore-3.3.exp

Adding the NPN_DeallocateObject symbol.

11:17 AM Changeset in webkit [12662] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning

3:53 AM Changeset in webkit [12661] by andersca
  • 3 edits
    2 moves in trunk/WebCore

2006-02-08 Anders Carlsson <​andersca@mac.com>

Rubber stamped by Maciej.

Move JSCore.cpp to bindings/js/JSDOMCore.cpp and
rename JSEvents.cpp to JSDOMEvents.cpp


  • JSCore.cpp: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMCore.cpp: Added.
  • bindings/js/JSDOMEvents.cpp: Added.
  • bindings/js/JSEvents.cpp: Removed.
3:48 AM Changeset in webkit [12660] by andersca
  • 7 edits
    1 add in trunk/WebCore

2006-02-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • JSCore.cpp: Add JSElement.cpp.


  • bindings/scripts/CodeGeneratorJS.pm: Handle a bunch of new types.


  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::getValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Remove code that is autogenerated now.


(KJS::getDOMNode):
Create a JSElement instead of a DOMElement.


(KJS::getDOMNodeList):
Take a PassRefPtr like some of the other get methods.


  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Remove the now unused enums.


  • khtml/ecma/kjs_html.cpp: (KJS::): (KJS::HTMLElement::HTMLElement): (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::toString): (KJS::KJS::HTMLElement::put):
  • khtml/ecma/kjs_html.h: Have HTMLElement inherit from JSElement.
  • khtml/xml/Element.idl: Added.
3:46 AM Changeset in webkit [12659] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

I jumped the gun adding QString.cpp to the Win32 build. Still has some compile issues to work out. Removing it for now.

3:36 AM Changeset in webkit [12658] by hyatt
  • 1 delete in trunk/WebCore/ForwardingHeaders/qstring.h

Remove qstring.h forwarding header.

3:33 AM Changeset in webkit [12657] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Get the new string files added, but Win32 is still busted from the infinite include of qstring.h

2:50 AM Changeset in webkit [12656] by hyatt
  • 6 edits in trunk/WebCore

Land complete PNG support for Win32 (yay).

Feb 7, 2006:

9:31 PM Changeset in webkit [12655] by mjs
  • 57 edits
    2 moves
    1 add in trunk/WebCore

Rubber stamped by Hyatt.

  • move kwq/KWQString.mm to platform/QString.cpp, split out nonportable parts, speculative port of one remaining nonportable bit to windows.
  • ForwardingHeaders/qstring.h:
  • WebCore+SVG/KDOMSettings.h:
  • WebCore+SVG/kdom.h:
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/FormDataList.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/decoder.h:
  • khtml/misc/formdata.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • khtml/xml/dom_position.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQBuffer.h:
  • kwq/KWQEvent.h:
  • kwq/KWQFont.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKDebug.h:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQKURL.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQRegExp.h:
  • kwq/KWQRenderTreeDebug.h:
  • kwq/KWQString.h: Removed.
  • kwq/KWQString.mm: Removed.
  • kwq/KWQStringList.h:
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.h:
  • kwq/KWQTextUtilities.mm:
  • kwq/WebCoreScriptDebugger.mm:
  • loader/Cache.h:
  • platform/Color.cpp:
  • platform/Color.h:
  • platform/QString.cpp: Added. (allocateHandle): (KWQStringData::KWQStringData): (QString::QString): (QString::insert): (QString::detach): (QString::remove): (QString::setLength): (QString::fill): (initializeHandleNodeBlock): (allocateNode): (freeHandle):
  • platform/QString.h: Added.
  • platform/SegmentedString.h:
  • platform/StringImpl.h:
  • platform/mac/Image.mm:
  • platform/mac/QString.mm: Added. (QString::setBufferFromCFString): (QString::fromCFString): (QString::fromNSString): (QString::getNSString): (QString::utf8): (QString::fromUtf8):
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
7:05 PM Changeset in webkit [12654] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Update page directory in Win32 project to match what's there now.

7:01 PM Changeset in webkit [12653] by mjs
  • 12 edits
    1 delete in trunk/WebCore

Reviewed by Adele.

  • remove all remains of old-style frame tree, ChildFrame, ObjectContents and FrameList are all gone
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::indexGetter): (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::findFrame): (WebCore::Frame::frameExists): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::slotPartRemoved): (WebCore::Frame::connectChild): (WebCore::Frame::disconnectChild): (WebCore::Frame::canCachePage): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::treeNode): (WebCore::Frame::frameDetached):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/ObjectContents.h: Removed.
  • page/Plugin.h: (WebCore::Plugin::view):
6:39 PM Changeset in webkit [12652] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

  • test for <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid
  • fast/encoding/decoder-allow-null-chars.html
  • fast/encoding/decoder-allow-null-chars-expected.txt

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid

Test: fast/encoding/decoder-allow-null-chars.html

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::convertLatin1): Removed stripping of null characters (unwanted): ditto.
4:46 PM Changeset in webkit [12651] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Land the skeleton of a PNG decoder for Win32.

4:14 PM Changeset in webkit [12650] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add bindings/js/JSEvents.cpp to the win32 build.

3:08 PM Changeset in webkit [12649] by eseidel
  • 6 edits
    1 delete in trunk/WebCore

2006-02-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Removed ImageSubset, making ImageViewer link directly to WebCore.

  • Viewer.vcproj:
  • WebCore.vcproj/ImageSubset: Removed.
  • WebCore.vcproj/ImageSubset/ImageSubset.vcproj: Removed.
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
1:36 PM Changeset in webkit [12648] by hyatt
  • 1 edit
    2 adds in trunk/WebCore/WebCore.vcproj

Add Image Subset of WebCore as a project to the win32 build for the Image Viewer app to link against.

1:32 PM Changeset in webkit [12647] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by darin.

  • Fixed <rdar://problem/4425269> REGRESSION: wrong size pop-up when downloading attachment at webmail.mac.com (6882)

The bug was that the feature string parser didn't always initialize the
*Set variables, so WebCore assumed a height was set when it wasn't,
and used a garbage height variable.

While there, I fixed two other bugs: (1) The parser wasn't chewing up
as many characters as I thought it was. (Chewing up extra characters
is necessary to match Win IE.) (2) We considered \t and \f to be
whitespace, but Win IE doesn't.

  • manual-tests/window-open-features-parsing.html: Added these cases, fixed up comments.
  • bridge/BrowserExtension.h: Cleaned up declaration order a bit.
  • khtml/ecma/kjs_window.cpp: (KJS::isSeparator): New function, tells you if a character is a separator (KJS::parseWindowFeatures): Always initialize *Set to false. Drive parsing based on invalid characters ('separators') rather than valid ones, to match Win IE.
1:27 PM Changeset in webkit [12646] by darin
  • 8 edits in trunk/WebKitSite

Set more MIME types.

1:17 PM Changeset in webkit [12645] by darin
  • 81 edits in trunk/WebKitSite

Set a bunch of MIME types.

9:01 AM Changeset in webkit [12644] by ap
  • 10 edits
    9 adds in trunk

2006-02-07 Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Timothy.

Convert JavaScript objects to appropriate AppleScript types, instead of only strings
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7012

WebKit:

  • WebView/WebView.m: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
  • WebView/WebViewPrivate.h:

WebCore:

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added.

WebKitTools:

  • DumpRenderTree/AppleScriptController.h: Added.
  • DumpRenderTree/AppleScriptController.m: Added.
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

LayoutTests:

  • fast/AppleScript: Added.
  • fast/AppleScript/001-expected.txt: Added.
  • fast/AppleScript/001.html: Added.
  • fast/AppleScript/array-expected.txt: Added.
  • fast/AppleScript/array.html: Added.
  • fast/AppleScript/date-expected.txt: Added.
  • fast/AppleScript/date.html: Added.
3:31 AM Changeset in webkit [12643] by hyatt
  • 47 adds in trunk/WebCore/platform/image-decoders

Add libpng and the zlib supporting library in preparation for iplementing PNG decoding.

3:07 AM Changeset in webkit [12642] by hyatt
  • 3 edits
    5 moves in trunk/WebCore

FInal image renaming for Win32 gif stuff.

2:47 AM Changeset in webkit [12641] by hyatt
  • 6 edits
    3 moves
    1 delete in trunk/WebCore

Rename ImageDecoder to ImageSource.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::Image::cacheFrame): (WebCore::Image::size): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable):
  • platform/Image.h:
  • platform/ImageDecoder.h: Removed.
  • platform/ImageSource.h: Added.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawInRect):
  • platform/cairo/ImageDecoderCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Added. (WebCore::createDecoderPlugin): (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
  • platform/mac/Image.mm: (WebCore::Image::drawInRect):
  • platform/mac/ImageData.mm: Removed.
  • platform/mac/ImageDecoder.cpp: Removed.
  • platform/mac/ImageSource.cpp: Added. (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
2:17 AM Changeset in webkit [12640] by hyatt
  • 22 edits
    2 deletes in trunk/WebCore

Combine ImageData and Image (the result ends up in Image).

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::fileWrapperForElement):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • loader/CachedImage.cpp: (WebCore::CachedImage::image):
  • loader/CachedImage.h:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::invalidateData): (WebCore::Image::cacheFrame): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::setData): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable): (WebCore::Image::frameAtIndex): (WebCore::Image::frameDurationAtIndex): (WebCore::Image::shouldAnimate): (WebCore::Image::startAnimation): (WebCore::Image::stopAnimation): (WebCore::Image::resetAnimation): (WebCore::Image::advanceAnimation): (WebCore::Image::rect):
  • platform/Image.h: (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::Image::currentFrame): (WebCore::Image::animationObserver): (WebCore::Image::setIsPDF):
  • platform/ImageData.cpp: Removed.
  • platform/ImageData.h: Removed.
  • platform/cairo/ImageCairo.cpp: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/Image.mm: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::checkForSolidColor): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::getNSImage): (WebCore::Image::getCGImageRef): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::nullImage):
  • rendering/render_image.h: (WebCore::RenderImage::image):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
1:29 AM Changeset in webkit [12639] by mjs
  • 6 edits in trunk/WebKitSite

Reviewed by Darin. Landed by Maciej.


  • blog/wp-content/themes/webkit/style.css:
  • index.html:
  • quality/bugwriting.html:
  • quality/reduction.html:
  • webkitdev.css:
1:21 AM Changeset in webkit [12638] by mjs
  • 18 edits
    2 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Eric.


  • fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
  • fast/dom/HTMLObjectElement/object-as-frame.html: Added.


  • fast/events/event-targets-expected.checksum: Removed.
  • fast/events/event-targets-expected.png: Removed.
  • fast/events/event-targets-expected.txt:
  • fast/events/event-targets.html:

WebCore:

Reviewed by Eric.



  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): pass along renderer (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge removeChild:]): don't mess with renderer (-[WebCoreFrameBridge init]): call new designated initializer (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer (-[WebCoreFrameBridge dealloc]): don't mess with renderer (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge installInFrame:]): ditto
  • page/Frame.cpp: (WebCore::FrameList::find): get name from frame not ChildFrame (WebCore::Frame::init): take renderer parameter (WebCore::Frame::clear): clear m_plugins, not m_objects (WebCore::Frame::childBegin): updated comment (WebCore::Frame::stop): add check-completed for documentless case here (WebCore::Frame::checkCompleted): don't track separate completed flag in ChildFrame, use the sub Frame object's own (WebCore::Frame::checkEmitLoadEvent): ditto (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame, instead pass them along (WebCore::Frame::requestObject): ditto above (WebCore::Frame::loadPlugin): expect renderer parameter (WebCore::Frame::loadSubframe): expect renderer and name parameters (WebCore::Frame::slotChildStarted): don't mess with ChildFrame (WebCore::Frame::slotChildCompleted): ditto (WebCore::Frame::childFrame): don't check m_objects (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment (WebCore::Frame::frameNames): get name from frame (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner renderer now (WebCore::Frame::ownerRenderer): added (WebCore::Frame::canCachePage): check m_plugins not m_objects
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame): Remove constructor, most fields. (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr to requestObject.

WebKit:

Reviewed by Eric.


  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer. (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:

Feb 6, 2006:

11:48 PM Changeset in webkit [12637] by adele
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/event-listener-on-link.html: Added.
  • fast/events/event-listener-on-link-expected.txt: Added.
  • fast/events/event-listener-on-link-expected.png: Added.
  • fast/events/event-listener-on-link-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

Test: fast/events/event-listener-on-link.html

  • khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl, changed AttrImpl contructor to remove createTextChild bool, added createTextChild method, changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs. (DOM::ElementImpl::getAttributeNode):
  • khtml/xml/dom_elementimpl.cpp: (WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl. This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one, and will call the new createTextChild. (WebCore::AttrImpl::AttrImpl): Moved creation of text child to new createTextChild method. If done in the constructor, the ref count is still 0, and the act of appending the text node could cause the AttrImpl to be destroyed. (WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor. Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl. (WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning. (WebCore::ElementImpl::cloneNode): ditto. (WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr. (WebCore::NamedAttrMapImpl::getNamedItemNS): ditto. (WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded (WebCore::NamedAttrMapImpl::setNamedItem): ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): ditto. (WebCore::NamedAttrMapImpl::item): ditto.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call.
  • khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS. (WebCore::DocumentImpl::createAttribute):
  • khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item. (WebCore::NamedNodeMapImpl::getNamedItem):
  • bindings/objc/DOM.mm: (-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs. (-[DOMNamedNodeMap item:]): ditto. (-[DOMNamedNodeMap getNamedItemNS::]): ditto. (-[DOMDocument createAttribute:]): ditto. (-[DOMDocument createAttributeNS::]): ditto. (-[DOMElement getAttributeNode:]): ditto. (-[DOMElement getAttributeNodeNS::]): ditto.
11:37 PM Changeset in webkit [12636] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::parseMappedAttribute): connect onfocus/onblur to focus/blur, not DOMFocusIn/DOMFocusOut
11:14 PM Changeset in webkit [12635] by mjs
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/events/div-focus-expected.txt: Added.
  • fast/events/div-focus.html: Added.
11:07 PM Changeset in webkit [12634] by hyatt
  • 1 edit in trunk/WebCore/platform/Image.cpp

Fix build bustage on Mac.

11:06 PM Changeset in webkit [12633] by hyatt
  • 1 edit in trunk/WebCore/platform/Image.cpp

Fix build bustage on Mac.

10:57 PM Changeset in webkit [12632] by eseidel
  • 2 edits in trunk/WebCore

2006-02-06 Eric Seidel <​eseidel@apple.com>

Add svn:ignore properties for visual studio internals.

10:56 PM Changeset in webkit [12631] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-06 Eric Seidel <​eseidel@apple.com>

Add svn:ignore properties for visual studio internals.

10:52 PM Changeset in webkit [12630] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build-webkit for use on win32 (unblocks buildbot usage).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7122

  • Scripts/build-webkit: use ifCygwin() to conditionalize builds
  • Scripts/webkitdirs.pm: add ifOSX() and ifCygwin()
10:30 PM Changeset in webkit [12629] by hyatt
  • 1 move in trunk/WebCore/platform/win/SystemTimeWin.cpp

Rename SystemTime.cpp to SystemTimeWin.cpp

10:29 PM Changeset in webkit [12628] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Rename SystemTime.cpp to SystemTimeWin.cpp

10:28 PM Changeset in webkit [12627] by hyatt
  • 1 delete in trunk/WebCore/platform/win/ImageDecoderPlugin.h

Remove accidentally committed file.

10:15 PM Changeset in webkit [12626] by hyatt
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_html.cpp

Fix more build bustage.

10:13 PM Changeset in webkit [12625] by hyatt
  • 3 edits
    21 adds in trunk/WebCore

Land image viewer test app.

10:11 PM Changeset in webkit [12624] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • No tests added - only changed functionality on WIN32, which should be covered by existing tests.
  • kjs/date_object.cpp: (gmtoffset): On WIN32, use the recommended global (_timezone rather than timezone). Updated comments. (KJS::timeZoneOffset): Removed, was basically the same as the above. (KJS::formatTime): Pass an UTC flag - UTC/local cannot be correctly selected on Windows based on struct tm itself. (KJS::DateInstance::getTime): Added. (KJS::DateInstance::getUTCTime): Added. (KJS::millisecondsToTM): Factored out from DateProtoFunc::callAsFunction(). (KJS::DateObjectImp::callAsFunction): Use the new parameter to formatTime(). (KJS::DateProtoFunc::callAsFunction): Updated for the other changes. The code for GetTimezoneOffset was incorrect on WIN32 - _daylight global has nothing to do with daylight savings time being in effect.
  • kjs/date_object.h: Added prototypes for new functions.
9:55 PM Changeset in webkit [12623] by hyatt
  • 1 delete in trunk/WebCore/platform/cairo/.cvsignore

Remove stray .cvsignore file accidentally committed.

9:51 PM Changeset in webkit [12622] by hyatt
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_html.cpp

Fix build bustage. Missed a file.

9:37 PM Changeset in webkit [12621] by hyatt
  • 11 edits
    12 adds in trunk/WebCore

Land new image code (excluding the test app, work to do there still)

9:30 PM Changeset in webkit [12620] by hyatt
  • 8 adds
    1 delete in trunk/WebCore/platform/cairo/cairo

Commit remaining Cairo files.

9:13 PM Changeset in webkit [12619] by hyatt
  • 98 adds in trunk/WebCore/platform/cairo/cairo/src

Land Cairo itself.

9:10 PM Changeset in webkit [12618] by hyatt
  • 3 adds in trunk/WebCore/platform/cairo/pixman

Land pixman portion of Cairo.

9:04 PM Changeset in webkit [12617] by hyatt
  • 33 adds in trunk/WebCore/platform/cairo/pixman/src

Land pixman portion of Cairo.

8:51 PM Changeset in webkit [12616] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/pixman/src

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:51 PM Changeset in webkit [12615] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/pixman

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:50 PM Changeset in webkit [12614] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo/test

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:50 PM Changeset in webkit [12613] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo/src

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:48 PM Changeset in webkit [12612] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:48 PM Changeset in webkit [12611] by hyatt
  • 1 add in trunk/WebCore/platform/cairo

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

7:39 PM Changeset in webkit [12610] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Darin and Eric.

  • fix <rdar://problem/4414918> REGRESSION: images dragged into contenteditable area end up outside of editable area (6525)
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Moved code from elementAtPoint to this new method. This method takes a point and returns a NodeInfo for the deepest node at that point. (-[WebCoreFrameBridge elementAtPoint:]): Use new nodeInfoAtPoint method. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Ditto.
7:16 PM Changeset in webkit [12609] by eseidel
  • 1 edit
    2 adds in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin & mjs.

Added new support directory for build slave scripts.
Committing the first script, for use by the PLT's build slave.
This script is used to kick of the PLT (Page Load Test) slave.

  • BuildSlaveSupport: Added.
  • BuildSlaveSupport/run-performance-tests: Added.
6:47 PM Changeset in webkit [12608] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).

  • fast/overflow/scroll-vertical-not-horizontal.html: Added.
  • fast/overflow/scroll-vectical-not-horizontal-expected.txt: Added.
6:47 PM Changeset in webkit [12607] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Test: fast/overflow/scroll-vertical-not-horizontal.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::getRectToExpose): Fixed rectangle intersections so that the X and Y dimensions are independent, to fix the bug. Also restructured the function a bit so it's even easier to read and understand.
5:26 PM Changeset in webkit [12606] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-01 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin

Fixes <rdar://problem/4074536> Seed: Mail crash adjusting quote level - KHTMLPart::computeAndSetTypingStyle

No test cases added, requires Mail

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Crashes were happening after a style was merged with itself. Mail was doing a setTypingStyle with a pointer to our internal typing style. Fix is to only hand out copies of our typingStyle.
5:16 PM Changeset in webkit [12605] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a: removed WKExecutableLinkedInTigerOrEarlier
5:15 PM Changeset in webkit [12604] by harrison
  • 2 edits in trunk/WebCore

Suggested by Darin.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • make nextChild a RefPtr to survive possible DOM changes
5:10 PM Changeset in webkit [12603] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

  • WebView/WebPDFView.m: (-[WebPDFView menuForEvent:]): Removed use of WKExecutableLinkedInTigerOrEarlier() by modifying backward-compatibility hack involving PDF view context menus. Now we only bother to make sure that the PDFKit- supplied context menu items are present in Safari, for the benefit of the open source folks using tip of tree WebKit but older released Safari; it's possible that some other existing WebKit apps won't show all the PDF view context menu items.
4:57 PM Changeset in webkit [12602] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Adding setSourceDir for scripts stored in non-standard locations.

  • Scripts/webkitdirs.pm:
4:09 PM Changeset in webkit [12601] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/ChangeLog

Correct ChangeLog.

4:03 PM Changeset in webkit [12600] by thatcher
  • 8 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by John Sullivan.

JavaScriptCore part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • bindings/npruntime.cpp: (_NPN_ReleaseObject): Refactored part of this function out into _NPN_DeallocateObject. (_NPN_DeallocateObject): Forcibly deallocates the passed object, even if its refcount is greater than zero.
  • bindings/npruntime_impl.h: Declared _NPN_DeallocateObject().

WebCore:

Merged fix from TOT to Safari-2-0-branch

2006-01-16 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

WebCore part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • bridge/mac/MacFrame.mm: (MacFrame::setView): Call _NPN_DeallocateObject() instead of _NPN_ReleaseObject() so that we don't leak if a plugin fails to release the window script object properly. Our old NPN_GetValue() did not properly retain the returned window script object. Because of this, many plugins have WebKit-specific workarounds to not release said window script object. Forcibly deallocating it here should prevent any such issues. This shouldn't cause any problems for plugins, since they should already be stopped and destroyed at this point. This also fixes a preexisting leak of the window script NPObject -- it was never actually being freed!

WebKit:

Merged fix from TOT to Safari-2-0-branch

2006-01-16 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

WebKit part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView getVariable:value:]):

The returned window script object is expected to be retained, as described here:
<​http://www.mozilla.org/projects/plugins/npruntime.html#browseraccess>

3:35 PM Changeset in webkit [12599] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by John and Adele

Fix for <rdar://problem/4323167> REGRESSION (TOT): Crash in
RenderTable::colToEffCol entering text into text input field

Some of the autofill code assumes that the form's label is in a
table cell, but this is not necessarily the case. This fix checks
that the renderer is actually a table cell before treating it as
such.

11:56 AM Changeset in webkit [12598] by darin
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by John.

  • page/Frame.h: Make redirectionTimerFired virtual.
  • bridge/mac/MacFrame.h: Override redirectionTimerFired.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::redirectionTimerFired): Send the redirectionTimerCancelled callback here, even though it has fired rather than being cancelled.
  • manual-tests/redirect.html: Added.
  • manual-tests/redirection-target.html: Added.
10:29 AM Changeset in webkit [12597] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.


Fix TOT regression where Mail.app replies were getting truncated.
Was caused by 1/26/2006 checkin for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

No layout test because this code cannot be reached via JS operations.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • restore code that sampled nextSibling() before node is removed
  • also, add asserts that the DOM mutation methods yield a 0 exception code, so problems can be caught closer to the cause.
1:35 AM Changeset in webkit [12596] by mjs
  • 2 edits in trunk/WebKit

Remove remaining .subproj references to fix release build.

  • WebKit.xcodeproj/project.pbxproj:
12:58 AM Changeset in webkit [12595] by mjs
  • 2 edits
    2 copies
    9 moves in trunk/WebKit

Rubber stamped by Hyatt.


  • renamed subproject directories to not end with .subproj
  • Carbon: renamed from Carbon.subproj
  • DOM: renamed from DOM.subproj
  • History: renamed from History.subproj
  • Misc: renamed from Misc.subproj
  • Panels: renamed from Panels.subproj
  • Plugins: renamed from Plugins.subproj
  • WebCoreSupport: renamed from WebCoreSupport.subproj
  • WebInspector: renamed from WebInspector.subproj
  • WebView: renamed from WebView.subproj
12:10 AM Changeset in webkit [12594] by mjs
  • 3 edits in trunk/WebKit

Ooops, I made a last-minute change to my last patch that broke the build - fixed.

  • WebView.subproj/WebFrame.m: (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _handledOnloadEvents]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrame _clientRedirectCancelled:]):
  • WebView.subproj/WebFramePrivate.h:

Feb 5, 2006:

11:49 PM Changeset in webkit [12593] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.


  • kjs/internal.cpp: (KJS::Parser::noteNodeCycle): (KJS::Parser::removeNodeCycle): (KJS::clearNewNodes):
  • kjs/internal.h:
  • kjs/nodes.cpp: (ElementNode::breakCycle): (PropertyListNode::breakCycle): (ArgumentListNode::breakCycle): (StatListNode::StatListNode): (StatListNode::breakCycle): (VarDeclListNode::breakCycle): (BlockNode::BlockNode): (ClauseListNode::breakCycle): (CaseBlockNode::CaseBlockNode): (ParameterNode::breakCycle): (SourceElementsNode::SourceElementsNode): (SourceElementsNode::breakCycle):
  • kjs/nodes.h: (KJS::Node::breakCycle): (KJS::ElementNode::ElementNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyListNode::PropertyListNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarDeclListNode::VarDeclListNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ParameterNode::ParameterNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
11:25 PM Changeset in webkit [12592] by mjs
  • 11 edits in trunk/WebKit

Reviewed by Darin.


  • WebCoreSupport.subproj/WebFrameBridge.h:
  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:frameName:view:]): (-[WebFrameBridge page]): (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]):
  • WebCoreSupport.subproj/WebPageBridge.h:
  • WebCoreSupport.subproj/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): (-[WebPageBridge webView]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _webView]): (-[WebDataSource _setLoading:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _setWebFrame:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _traverseNextFrameStayWithin::]): (-[WebFrame _detachFromParent]): (-[WebFrame _setDataSource:]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame webView]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _webView]): (-[WebFrameView _goBack]): (-[WebFrameView _goForward]):
  • WebView.subproj/WebFrameViewInternal.h:
  • WebView.subproj/WebView.m: (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
11:06 PM Changeset in webkit [12591] by andersca
  • 5 edits
    6 adds in trunk/WebCore

2006-02-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • JSCore.cpp: Add new generated files.


  • bindings/scripts/CodeGeneratorJS.pm: Add "IsIndex" extended attribute for parameters. Any parameter that is "unsigned long" and has this attribute will be checked to make sure that it's not < 0. If it is, an index size error exception will be thrown.


  • khtml/ecma/kjs_dom.cpp: (KJS::toAttr): Use JSAttr::info.


(KJS::getDOMNode):
Use new constructors.


  • khtml/ecma/kjs_dom.h: Remove classes that are generated now.


  • khtml/xml/Attr.idl: Added.
  • khtml/xml/CharacterData.idl: Added.
  • khtml/xml/Entity.idl: Added.
  • khtml/xml/Notation.idl: Added.
  • khtml/xml/ProcessingInstruction.idl: Added.
  • khtml/xml/Text.idl: Added.
9:57 PM Changeset in webkit [12590] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

General update to SVG project page, also link to status page.

  • projects/svg/index.html:
9:36 PM Changeset in webkit [12589] by eseidel
  • 4 adds in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Rubber stamped by darin.

  • projects/svg/status.xml: Added.
  • projects/svg/svg-status.css: Added.
  • projects/svg/svg-status.xsl: Added.

2006-02-05 Eric Seidel <​eseidel@apple.com>

Adding ChangeLog :)


  • ChangeLog: Added.
6:36 PM Changeset in webkit [12588] by darin
  • 4 edits in trunk/LayoutTests
  • converted three more files from UTF-16 to ASCII that had no reason to be UTF-16
  • fast/dom/resources/top.html: Just straight conversion to ASCII.
  • fast/events/updateLayoutForHitTest.html: Converted one character to an entity, and reformatted the file a bit.
  • fast/text/line-breaks.html: Just straight conversion to ASCII.
3:07 PM Changeset in webkit [12587] by mjs
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Re-landing test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.


  • changed expected results and description for this test, unload should not fire in this case:


  • fast/events/onunload-body-property-expected.txt:
  • fast/events/onunload-body-property.html:


  • changed from UTF-16 to ASCII, there was no reason for this to be UTF-16.
  • fast/dom/attr_dead_doc.html:

WebCore:

Reviewed by Darin.


Re-landed the following with more fixes so it does not break tests:


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • dispatch window events on the document, not the body, and also for non-html
  • set onload, onunload, onbeforeunload from frameset tags on the window object
  • don't restrict load/unload events to HTML
  • send default handler to the dispatch object as previously
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::parseMappedAttribute): (WebCore::HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
  • page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::setWindowHasFocus):
12:31 PM Changeset in webkit [12586] by darin
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4197997> -[DOMHTMLSelectElement options] always returns an empty list
  • khtml/html/HTMLOptionsCollectionImpl.h: Changed to be a subclass of HTMLCollectionImpl.
  • khtml/html/HTMLOptionsCollectionImpl.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added new source file.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLOptionsCollection setLength:]): Handle possible exception. (-[DOMHTMLSelectElement options]): Add get() since this is now a PassRefPtr.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::selectIndexGetter): Call options() instead of optionsHTMLCollection(). (KJS::HTMLElement::selectGetter): Ditto. (KJS::KJS::HTMLElement::put): Ditto. (KJS::HTMLElement::selectSetter): Ditto. (KJS::KJS::HTMLSelectCollection::put): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Tweaked formatting. Eliminated m_options. Changed m_minwidth and m_size to int instead of short. Removed optionsHTMLCollection(). Changed options() to return a PassRefPtr.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl): Get rid of code to drop m_options. (WebCore::HTMLSelectElementImpl::remove): Remove unnecesssary RefPtr use, since that's handled fine by removeChild. (WebCore::HTMLSelectElementImpl::options): Change to create a new HTMLOptionsCollectionImpl each time, like other collection calls. Maybe we should change this eventually to use a HashMap so we can pass out the same collection over and over again, or could have a pointer stored in the select element that's managed by the collection itself.
11:34 AM Changeset in webkit [12585] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/forms/select-replace-option.html: Added.
  • fast/forms/select-replace-option-expected.txt: Added.
11:33 AM Changeset in webkit [12584] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to put reviewer name in.

11:33 AM Changeset in webkit [12583] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Test: fast/forms/select-replace-option.html

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLSelectCollection::put): Use optionsHTMLCollection, because options isn't really implemented yet.
11:18 AM Changeset in webkit [12582] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Add check for nil in case the blur event causes the KWQLineEdit to be destroyed.
11:17 AM Changeset in webkit [12581] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/replaced/object-param-no-name.html: Added.
  • fast/replaced/object-param-no-name-expected.txt: Added.
  • fixed test that I landed incorrectly earlier
  • fast/overflow/onscroll-layer-self-destruct.html: Removed Subversion property junk.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Ditto.
11:16 AM Changeset in webkit [12580] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/replaced/object-param-no-name.html

  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Check for empty name, and skip processing the name/value of that <param> element.
11:00 AM Changeset in webkit [12579] by darin
  • 1 edit
    2 deletes in trunk/LayoutTests
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

11:00 AM Changeset in webkit [12578] by darin
  • 4 edits in trunk/WebCore
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

10:19 AM Changeset in webkit [12577] by darin
  • 2 edits in trunk/WebCore
  • ksvg2/css/KSVGCSSParser.cpp: Remove config.h, since this is included by another .cpp file -- oops!
10:16 AM Changeset in webkit [12576] by darin
  • 7 edits
    2 deletes in trunk/WebCore

Discussed with Anders (didn't get real review).

  • fix build
  • WebCore+SVG/SVGNamesWrapper.cpp: Touch file, not getting rebuilt even though it includes config.h which changed.
  • WebCore+SVG/XLinkNamesWrapper.cpp: Ditto.
  • ksvg2/css/KSVGCSSParser.cpp: Added include of config.h.
  • platform/mac/ImageDecoder.cpp: Ditto.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed IntPoint.cpp and IntSize.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/IntPoint.cpp: Removed. Was empty.
  • platform/IntSize.cpp: Removed. Was empty.
9:21 AM Changeset in webkit [12575] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Maciej.

  • fast/overflow/onscroll-layer-self-destruct.html: Added.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Added.
3:48 AM Changeset in webkit [12574] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: onscroll-layer-self-destruct.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset): Don't send the scroll event until after we've done everything else we need to do.
2:37 AM Changeset in webkit [12573] by darin
  • 99 edits
    1 copy
    6 moves in trunk/WebCore

Rubber stamped by Maciej.

  • renamed DOMString and DOMStringImpl to String and StringImpl, and moved into platform
  • config.h: Put in transitional defines so old code can still refer to the classes as DOMString and DOMStringImpl.
  • platform/AtomicString.cpp: Added.
  • platform/AtomicString.h: Added.
  • platform/AtomicStringImpl.h: Added.
  • platform/PlatformString.h: Added.
  • platform/String.cpp: Added.
  • platform/StringImpl.cpp: Added.
  • platform/StringImpl.h: Added. Moved files here and renamed them. PlatformString.h would be named String.h except that conflicts with <string.h> on non-case-sensitive file systems.
  • khtml/xml/dom_atomicstring.cpp: Removed.
  • khtml/xml/dom_atomicstring.h: Removed.
  • khtml/xml/dom_stringimpl.cpp: Removed.
  • khtml/xml/dom_stringimpl.h: Removed.
  • khtml/dom/dom_string.cpp: Removed.
  • khtml/dom/dom_string.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for file adds and removes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/Namespace.h:
  • WebCore+SVG/kdom.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMInternal.mm:
  • bridge/BrowserExtension.h:
  • css/css_base.h:
  • css/css_computedstyle.cpp:
  • css/css_grammar.y:
  • css/css_ruleimpl.h:
  • css/css_stylesheetimpl.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/csshelper.cpp:
  • css/csshelper.h:
  • css/cssparser.h:
  • css/cssstyleselector.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/ecma/JSXMLHttpRequest.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/delete_from_text_node_command.h:
  • khtml/editing/insert_into_text_node_command.h:
  • khtml/editing/jsediting.h:
  • khtml/editing/rebalance_whitespace_command.h:
  • khtml/editing/remove_css_property_command.h:
  • khtml/editing/typing_command.h:
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLNameCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/khtml_events.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • khtml/xbl/xbl_protoimplementation.h:
  • khtml/xml/DOMImplementationImpl.cpp:
  • khtml/xml/EventNames.h:
  • khtml/xml/NameNodeListImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_atomicstringlist.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp:
  • ksvg2/svg/SVGAnimatedStringImpl.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.h:
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGPaintImpl.h:
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.h:
  • ksvg2/svg/SVGStylableImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGSymbolElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontFamily.mm:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • page/FrameTreeNode.h:
  • platform/SegmentedString.h:
  • rendering/render_image.h:
  • rendering/render_style.cpp:
  • xml/xmlhttprequest.cpp: Updated all includes to use new filenames.
1:53 AM Changeset in webkit [12572] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Hyatt.


  • fix default traits for classes to make sure default constructors get called
  • kxmlcore/VectorTraits.h: (KXMLCore::):
1:45 AM Changeset in webkit [12571] by mjs
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.

WebCore:

Reviewed by Darin.


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
12:49 AM Changeset in webkit [12570] by andersca
  • 3 edits in trunk/WebCore

2006-02-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed and landed by Anders.


12:29 AM Changeset in webkit [12569] by ap
  • 2 edits in trunk/WebCore

Fix by David Kilzer, reviewed by Darin, landed by ap (with a tweak suggested by Darin).

  • kwq/KWQPainter.mm: Include "FloatRect.h".

Feb 4, 2006:

9:44 PM Changeset in webkit [12568] by mjs
  • 14 edits in trunk/WebCore

Reviewed by Darin.

  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): (WebCore::HTMLOptGroupElementImpl::replaceChild): (WebCore::HTMLOptGroupElementImpl::removeChild): (WebCore::HTMLOptGroupElementImpl::appendChild):
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::insertBefore): (WebCore::HTMLSelectElementImpl::replaceChild): (WebCore::HTMLSelectElementImpl::removeChild): (WebCore::HTMLSelectElementImpl::appendChild):
  • khtml/html/HTMLSelectElementImpl.h:
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::createTFoot):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::insertBefore): (WebCore::NodeImpl::replaceChild): (WebCore::NodeImpl::removeChild): (WebCore::NodeImpl::appendChild):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
9:24 PM Changeset in webkit [12567] by mjs
  • 17 edits
    110 deletes in trunk

LayoutTests:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • fast/media/001-expected.checksum: Removed.
  • fast/media/001-expected.png: Removed.
  • fast/media/001-expected.txt: Removed.
  • fast/media/001.html: Removed.
  • fast/media/002-expected.checksum: Removed.
  • fast/media/002-expected.png: Removed.
  • fast/media/002-expected.txt: Removed.
  • fast/media/002.html: Removed.
  • fast/media/003-expected.checksum: Removed.
  • fast/media/003-expected.png: Removed.
  • fast/media/003-expected.txt: Removed.
  • fast/media/003.html: Removed.
  • fast/media/004-expected.checksum: Removed.
  • fast/media/004-expected.png: Removed.
  • fast/media/004-expected.txt: Removed.
  • fast/media/004.html: Removed.
  • fast/media/005-expected.checksum: Removed.
  • fast/media/005-expected.png: Removed.
  • fast/media/005-expected.txt: Removed.
  • fast/media/005.html: Removed.
  • fast/media/006-expected.checksum: Removed.
  • fast/media/006-expected.png: Removed.
  • fast/media/006-expected.txt: Removed.
  • fast/media/006.html: Removed.
  • fast/media/007-expected.checksum: Removed.
  • fast/media/007-expected.png: Removed.
  • fast/media/007-expected.txt: Removed.
  • fast/media/007.html: Removed.
  • fast/media/008-expected.checksum: Removed.
  • fast/media/008-expected.png: Removed.
  • fast/media/008-expected.txt: Removed.
  • fast/media/008.html: Removed.
  • fast/media/009-expected.checksum: Removed.
  • fast/media/009-expected.png: Removed.
  • fast/media/009-expected.txt: Removed.
  • fast/media/009.html: Removed.
  • fast/media/010-expected.checksum: Removed.
  • fast/media/010-expected.png: Removed.
  • fast/media/010-expected.txt: Removed.
  • fast/media/010.html: Removed.
  • fast/media/011-expected.checksum: Removed.
  • fast/media/011-expected.png: Removed.
  • fast/media/011-expected.txt: Removed.
  • fast/media/011.html: Removed.
  • fast/media/012-expected.checksum: Removed.
  • fast/media/012-expected.png: Removed.
  • fast/media/012-expected.txt: Removed.
  • fast/media/012.html: Removed.
  • fast/media/013-expected.checksum: Removed.
  • fast/media/013-expected.png: Removed.
  • fast/media/013-expected.txt: Removed.
  • fast/media/013.html: Removed.
  • fast/media/014-expected.checksum: Removed.
  • fast/media/014-expected.png: Removed.
  • fast/media/014-expected.txt: Removed.
  • fast/media/014.html: Removed.
  • fast/media/015-expected.checksum: Removed.
  • fast/media/015-expected.png: Removed.
  • fast/media/015-expected.txt: Removed.
  • fast/media/015.html: Removed.
  • fast/media/016-expected.checksum: Removed.
  • fast/media/016-expected.png: Removed.
  • fast/media/016-expected.txt: Removed.
  • fast/media/016.html: Removed.
  • fast/media/017-expected.checksum: Removed.
  • fast/media/017-expected.png: Removed.
  • fast/media/017-expected.txt: Removed.
  • fast/media/017.html: Removed.
  • fast/media/018-expected.checksum: Removed.
  • fast/media/018-expected.png: Removed.
  • fast/media/018-expected.txt: Removed.
  • fast/media/018.html: Removed.
  • fast/media/019-expected.checksum: Removed.
  • fast/media/019-expected.png: Removed.
  • fast/media/019-expected.txt: Removed.
  • fast/media/019.html: Removed.
  • fast/media/020-expected.checksum: Removed.
  • fast/media/020-expected.png: Removed.
  • fast/media/020-expected.txt: Removed.
  • fast/media/020.html: Removed.
  • fast/media/021-expected.checksum: Removed.
  • fast/media/021-expected.png: Removed.
  • fast/media/021-expected.txt: Removed.
  • fast/media/021.html: Removed.
  • fast/media/022-expected.checksum: Removed.
  • fast/media/022-expected.png: Removed.
  • fast/media/022-expected.txt: Removed.
  • fast/media/022.html: Removed.
  • fast/media/023-expected.checksum: Removed.
  • fast/media/023-expected.png: Removed.
  • fast/media/023-expected.txt: Removed.
  • fast/media/023.html: Removed.
  • fast/media/024-expected.checksum: Removed.
  • fast/media/024-expected.png: Removed.
  • fast/media/024-expected.txt: Removed.
  • fast/media/024.html: Removed.
  • fast/media/025-expected.checksum: Removed.
  • fast/media/025-expected.png: Removed.
  • fast/media/025-expected.txt: Removed.
  • fast/media/025.html: Removed.
  • fast/media/026-expected.checksum: Removed.
  • fast/media/026-expected.png: Removed.
  • fast/media/026.html: Removed.
  • fast/media/import-p-green.css: Removed.

WebCore:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Removed.
  • css/css_mediaqueryeval.h: Removed.
  • css/css_mediaqueryimpl.cpp: Removed.
  • css/css_mediaqueryimpl.h: Removed.
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::contains): (MediaListImpl::deleteMedium): (MediaListImpl::mediaText): (MediaListImpl::setMediaText):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::item): (DOM::MediaListImpl::appendMedium):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Removed.
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Removed.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm:
5:48 PM Changeset in webkit [12566] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts
5:43 PM Changeset in webkit [12565] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/js/for-in-var-scope.html: Added.
  • fast/js/resources/for-in-var-scope.js: Added.
  • fast/js/for-in-var-scope-expected.txt: Added.
5:43 PM Changeset in webkit [12564] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Test: fast/js/for-in-var-scope.html

  • kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.
  • other cleanup
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
  • kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.
5:09 PM Changeset in webkit [12563] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Oops, rolled out part that wasn't supposed to be here.

5:07 PM Changeset in webkit [12562] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result due to revised fix for <ol> number
  • fast/lists/olstart-expected.txt: Updated.
5:03 PM Changeset in webkit [12561] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Add a compatibilty hack for people with old Configuration files that say Development or Deployment in them.
4:49 PM Changeset in webkit [12560] by darin
  • 4 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • fixed regressions caused by fix for bug 5776 earlier today
  • rendering/render_list.h: Remove m_value from RenderListMarker, add it to RenderListItem. A few other tweaks, including getting rid of "friend" relationship.
  • rendering/render_list.cpp: (RenderListItem::RenderListItem): Initialize m_value. (RenderListItem::setStyle): Restore old behavior of making no marker for LNONE case. (RenderListItem::calcValue): Work on m_value, not m_marker->m_value. (RenderListItem::resetValue): Reset m_value, even if there's no marker. (RenderListMarker::RenderListMarker): Remove code to set up m_value. (RenderListMarker::calcMinMaxWidth): Get marker value from list item.
  • rendering/RenderContainer.cpp: (updateListMarkerNumbers): Call resetValue by its new name.
3:29 PM Changeset in webkit [12559] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Hyatt.



  • kjs/collector.cpp: (KJS::Collector::numProtectedObjects): renamed from numReferencedObjects (KJS::typeName): (KJS::Collector::rootObjectTypeCounts): renamed from rootObjectClasses, use HashSet
  • kjs/collector.h: (KJS::Collector::isOutOfMemory): Renamed from outOfMemory.
  • kjs/nodes.cpp:

WebCore:

Reviewed by Hyatt.

  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript protectedObjectCount]): Renamed from referencedObjectCounts (+[WebCoreJavaScript rootObjectTypeCounts]): Renamed from rootObjectClasses, changed from NSSet to NSCountedSet.

WebKit:

Reviewed by Hyatt.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.
2:59 PM Changeset in webkit [12558] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: reordered slightly.
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame): Don't take isObject parameter, just check tag name
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::prepareSubmit): remove obsolete hasOnlyLocalReferences check
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): remove obsolete hasOnlyLocalReferences check
  • loader/DocLoader.cpp: (khtml::DocLoader::requestImage): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestStyleSheet): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestScript): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestXSLStyleSheet): remove obsolete hasOnlyLocalReferences check
  • page/Frame.cpp: (WebCore::Frame::requestFrame): refactored and simplified (WebCore::Frame::requestObject): ditto (WebCore::Frame::shouldUsePlugin): ditto (WebCore::Frame::loadPlugin): ditto (WebCore::Frame::loadSubframe): ditto (WebCore::Frame::frameNames): remove obsolete m_bPreloaded check (WebCore::Frame::frames): ditto (WebCore::Frame::connectChild): check isFrame, not child type (WebCore::Frame::disconnectChild): ditto (WebCore::Frame::handleFallbackContent): greatly simplify using onwerElement (WebCore::Frame::updateBaseURLForEmptyDocument): use ownerElement, notChildFrame (WebCore::Frame::onlyLocalReferences): removed (WebCore::Frame::setOnlyLocalReferences): removed
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame::ChildFrame): remove most fields.
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Remove redundant setting of base URL for child document of iframe, Frame itself takes care of this already
10:51 AM Changeset in webkit [12557] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled wrapper already in the directory.
  • Scripts/svn-apply: Handle additions and deletions properly -- I've been noticing these haven't been working at all.
  • Scripts/svn-unapply: Ditto.
10:30 AM Changeset in webkit [12556] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed reviewer name.

8:42 AM Changeset in webkit [12555] by darin
  • 1 edit in trunk/WebCore/khtml/html/html_listimpl.cpp

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly

Feb 3, 2006:

8:57 PM Changeset in webkit [12554] by darin
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).


Layout tests for bug 5776: Generated numbers of ordered lists (OL) are
not calculated right

  • fast/lists/ol-display-types-expected.checksum: Added.
  • fast/lists/ol-display-types-expected.png: Added.
  • fast/lists/ol-display-types-expected.txt: Added.
  • fast/lists/ol-display-types.html: Added.
  • fast/lists/olstart-expected.checksum: Added.
  • fast/lists/olstart-expected.png: Added.
  • fast/lists/olstart-expected.txt: Added.
  • fast/lists/olstart.html: Added.
8:56 PM Changeset in webkit [12553] by darin
  • 2 edits in trunk/WebCore

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly
6:54 PM Changeset in webkit [12552] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Correct the ChangeLog to credit Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

6:14 PM Changeset in webkit [12551] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

beth felt like the changelog was judging her

6:12 PM Changeset in webkit [12550] by ggaren
  • 3 edits in trunk/WebCore

Reviewed beth.

  • Fixed <rdar://problem/4394868> window.open fails to parse "width=200px"

Cause: QString::toInt() is too aggressive; it parses letters as numbers.
The fix is to switch to DOMString. It's all the rage these days,
and its toInt() behavior matches what we want.

  • manual-tests/window-open-features-parsing.html: Added "px" case to giant evil string.
  • khtml/ecma/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::WindowFunc::callAsFunction):
6:01 PM Changeset in webkit [12549] by thatcher
  • 17 edits
    111 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt, Tim H.

Layout tests for:
Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

  • ChangeLog:
  • fast/media: Added.
  • fast/media/001-expected.checksum: Added.
  • fast/media/001-expected.png: Added.
  • fast/media/001-expected.txt: Added.
  • fast/media/001.html: Added.
  • fast/media/002-expected.checksum: Added.
  • fast/media/002-expected.png: Added.
  • fast/media/002-expected.txt: Added.
  • fast/media/002.html: Added.
  • fast/media/003-expected.checksum: Added.
  • fast/media/003-expected.png: Added.
  • fast/media/003-expected.txt: Added.
  • fast/media/003.html: Added.
  • fast/media/004-expected.checksum: Added.
  • fast/media/004-expected.png: Added.
  • fast/media/004-expected.txt: Added.
  • fast/media/004.html: Added.
  • fast/media/005-expected.checksum: Added.
  • fast/media/005-expected.png: Added.
  • fast/media/005-expected.txt: Added.
  • fast/media/005.html: Added.
  • fast/media/006-expected.checksum: Added.
  • fast/media/006-expected.png: Added.
  • fast/media/006-expected.txt: Added.
  • fast/media/006.html: Added.
  • fast/media/007-expected.checksum: Added.
  • fast/media/007-expected.png: Added.
  • fast/media/007-expected.txt: Added.
  • fast/media/007.html: Added.
  • fast/media/008-expected.checksum: Added.
  • fast/media/008-expected.png: Added.
  • fast/media/008-expected.txt: Added.
  • fast/media/008.html: Added.
  • fast/media/009-expected.checksum: Added.
  • fast/media/009-expected.png: Added.
  • fast/media/009-expected.txt: Added.
  • fast/media/009.html: Added.
  • fast/media/010-expected.checksum: Added.
  • fast/media/010-expected.png: Added.
  • fast/media/010-expected.txt: Added.
  • fast/media/010.html: Added.
  • fast/media/011-expected.checksum: Added.
  • fast/media/011-expected.png: Added.
  • fast/media/011-expected.txt: Added.
  • fast/media/011.html: Added.
  • fast/media/012-expected.checksum: Added.
  • fast/media/012-expected.png: Added.
  • fast/media/012-expected.txt: Added.
  • fast/media/012.html: Added.
  • fast/media/013-expected.checksum: Added.
  • fast/media/013-expected.png: Added.
  • fast/media/013-expected.txt: Added.
  • fast/media/013.html: Added.
  • fast/media/014-expected.checksum: Added.
  • fast/media/014-expected.png: Added.
  • fast/media/014-expected.txt: Added.
  • fast/media/014.html: Added.
  • fast/media/015-expected.checksum: Added.
  • fast/media/015-expected.png: Added.
  • fast/media/015-expected.txt: Added.
  • fast/media/015.html: Added.
  • fast/media/016-expected.checksum: Added.
  • fast/media/016-expected.png: Added.
  • fast/media/016-expected.txt: Added.
  • fast/media/016.html: Added.
  • fast/media/017-expected.checksum: Added.
  • fast/media/017-expected.png: Added.
  • fast/media/017-expected.txt: Added.
  • fast/media/017.html: Added.
  • fast/media/018-expected.checksum: Added.
  • fast/media/018-expected.png: Added.
  • fast/media/018-expected.txt: Added.
  • fast/media/018.html: Added.
  • fast/media/019-expected.checksum: Added.
  • fast/media/019-expected.png: Added.
  • fast/media/019-expected.txt: Added.
  • fast/media/019.html: Added.
  • fast/media/020-expected.checksum: Added.
  • fast/media/020-expected.png: Added.
  • fast/media/020-expected.txt: Added.
  • fast/media/020.html: Added.
  • fast/media/021-expected.checksum: Added.
  • fast/media/021-expected.png: Added.
  • fast/media/021-expected.txt: Added.
  • fast/media/021.html: Added.
  • fast/media/022-expected.checksum: Added.
  • fast/media/022-expected.png: Added.
  • fast/media/022-expected.txt: Added.
  • fast/media/022.html: Added.
  • fast/media/023-expected.checksum: Added.
  • fast/media/023-expected.png: Added.
  • fast/media/023-expected.txt: Added.
  • fast/media/023.html: Added.
  • fast/media/024-expected.checksum: Added.
  • fast/media/024-expected.png: Added.
  • fast/media/024-expected.txt: Added.
  • fast/media/024.html: Added.
  • fast/media/025-expected.checksum: Added.
  • fast/media/025-expected.png: Added.
  • fast/media/025-expected.txt: Added.
  • fast/media/025.html: Added.
  • fast/media/026-expected.checksum: Added.
  • fast/media/026-expected.png: Added.
  • fast/media/026.html: Added.
  • fast/media/import-p-green.css: Added.

WebCore:

Reviewed by Dave Hyatt and Tim H.

Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

​http://www.w3.org/TR/css3-mediaqueries/

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Added. (MediaQueryEvaluator): (MediaQueryEvaluator::~MediaQueryEvaluator): (MediaQueryEvaluator::mediaTypeMatch): (applyRestrictor): (MediaQueryEvaluator::eval): (parseAspectRatio):
  • css/css_mediaqueryeval.h: Added.
  • css/css_mediaqueryimpl.cpp: Added. (MediaQueryExpImpl::MediaQueryExpImpl): (MediaQueryExpImpl::~MediaQueryExpImpl): (MediaQueryExpImpl::mediaFeature): (MediaQueryExpImpl::value): (MediaQueryImpl::MediaQueryImpl): (MediaQueryImpl::~MediaQueryImpl): (MediaQueryImpl::restrictor): (MediaQueryImpl::expressions): (MediaQueryImpl::mediaType): (MediaQueryImpl::operator==):
  • css/css_mediaqueryimpl.h: Added. (DOM::MediaQueryExpImpl::operator==): (DOM::MediaQueryExpListImpl::MediaQueryExpListImpl): (DOM::MediaQueryExpListImpl::append): (DOM::MediaQueryExpListImpl::list): (DOM::MediaQueryImpl::):
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::deleteMedium): (mediaQueryAsDOMString): (MediaListImpl::mediaText): (MediaListImpl::setMediaText): (MediaListImpl::item): (MediaListImpl::appendMedium): (MediaListImpl::appendMediaQuery):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::mediaQueries):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Added.
  • css/cssparser.cpp: (CSSParser::parseMediaQuery):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::defaultStyleForRoot):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Added.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
5:48 PM Changeset in webkit [12548] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.


  • change spellchecker preflighting to happen via class methods instead of object methods.
  • WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]): (+[WebView _preflightSpellCheckerNow:]): (+[WebView _preflightSpellChecker]):
3:34 PM Changeset in webkit [12547] by thatcher
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

JavaScriptGlue:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/set-webkit-configuration:
  • Scripts/webkitdirs.pm:
2:46 PM Changeset in webkit [12546] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

No test cases added because this is an unreproducible crash.

This is a speculative fix for <rdar://problem/4048026>
CrashTracer: [BOUNCE BACK] 1219 crashes in Safari at
com.apple.WebCore: KHTMLParser::popOneBlock + 36

It seems possible that current could be nil when this function is
called, so the speculative fix is to add a nil check.

3:22 AM Changeset in webkit [12545] by hyatt
  • 4 edits
    6 adds in trunk/WebCore

Refactoring of the image classes to make them even more
portable.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • platform/ImageData.cpp: Added. (WebCore::FrameData::clear): (WebCore::ImageData::ImageData): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setNativeData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation):
  • platform/ImageData.h: Added. (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame):
  • platform/ImageDecoder.h:
  • platform/mac/Image.mm: (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::graphicsContext): (WebCore::setCompositingOperation): (WebCore::fillSolidColorInRect): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/ImageData.mm: Added. (WebCore::setCompositingOperation): (WebCore::ImageData::invalidateAppleSpecificData): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage):
  • platform/mac/PDFDocumentImage.h: Added.
  • platform/mac/PDFDocumentImage.mm: Added. (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw):
1:11 AM Changeset in webkit [12544] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Make a new class called ImageDecoder that wraps a CGImageSource.
This paves the way for ImageData to become portable as well.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ImageDecoder.h: Added.
  • platform/mac/Image.mm: (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::size): (WebCore::ImageData::setCFData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::drawInRect):
  • platform/mac/ImageDecoder.cpp: Added. (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::imageSourceOptions): (WebCore::ImageDecoder::initialized): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::createFrameAtIndex): (WebCore::ImageDecoder::frameDurationAtIndex):

Feb 2, 2006:

11:32 PM Changeset in webkit [12543] by hyatt
  • 5 edits
    1 add in trunk/WebCore

Move ImageAnimationObserver into its own file.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedImage.h:
  • platform/Image.h:
  • platform/ImageAnimationObserver.h: Added. (WebCore::ImageAnimationObserver::~ImageAnimationObserver):
  • platform/mac/Image.mm:
11:18 PM Changeset in webkit [12542] by mjs
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • remove all use of the ChildFrame from outside Frame.cpp, in preparation for removing it
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::frameDetached): Factor out the ChildFrame manipulations into a base class method. (WebCore::MacFrame::objectContentType): factored out from createPart, calls the bridge to determine contents for an Object tag. (WebCore::MacFrame::createPlugin): factor out code from createPart that makes a Plugin. (WebCore::MacFrame::createFrame): ditto for code that makes a Frame. (WebCore::MacFrame::createEmptyDocument): factored out part into the superclass
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): Call new ownerElement method on Frame instead of mucking at Frame internals.
  • page/Frame.cpp: (WebCore::Frame::createPart): Moved here from MacFrame, but some of the guts were factored out. (WebCore::Frame::ownerElement): New method, logic moved from DocumentImpl. (WebCore::Frame::frameDetached): New virtual method, the part of this that pokes at ChildFrame structures. (WebCore::Frame::updateBaseURLForEmptyDocument): Helper that looks at the ChildFrame array for the benefit of createEmptyDocument.
  • page/Frame.h:
  • page/Page.h: Fix up modeline.
  • page/Plugin.h: Added. (WebCore::Plugin::Plugin): Moved here from MacFrame.mm, since it is now used by Frame. (WebCore::Plugin::view): ditto
9:47 PM Changeset in webkit [12541] by hyatt
  • 2 edits in trunk/WebCore

Avoid extra copies of all the decoded image bytes.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::ImageData::setData):
5:16 PM Changeset in webkit [12540] by justing
  • 141 edits
    4 adds in trunk/LayoutTests

Reviewed by harrison


Turned on continuous spell checking to test the fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Added:

  • editing/selection/end-of-document.html

Pixel results for editing tests now include misspelling markers.
A few of them are incorrect, filed 7038 to cover this.

  • editing/deleting/delete-3928305-fix-expected.checksum:
  • editing/deleting/delete-3928305-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-block-contents-003-expected.checksum:
  • editing/deleting/delete-block-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • editing/deleting/delete-contiguous-ws-001-expected.png:
  • editing/deleting/delete-tab-002-expected.checksum:
  • editing/deleting/delete-tab-002-expected.png:
  • editing/deleting/delete-tab-003-expected.checksum:
  • editing/deleting/delete-tab-003-expected.png:
  • editing/deleting/delete-trailing-ws-002-expected.checksum:
  • editing/deleting/delete-trailing-ws-002-expected.png:
  • editing/deleting/delete-ws-fixup-001-expected.checksum:
  • editing/deleting/delete-ws-fixup-001-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/insert-3659587-fix-expected.checksum:
  • editing/inserting/insert-3659587-fix-expected.png:
  • editing/inserting/insert-br-004-expected.checksum:
  • editing/inserting/insert-br-004-expected.png:
  • editing/inserting/insert-br-005-expected.checksum:
  • editing/inserting/insert-br-005-expected.png:
  • editing/inserting/insert-br-007-expected.checksum:
  • editing/inserting/insert-br-007-expected.png:
  • editing/inserting/insert-div-007-expected.checksum:
  • editing/inserting/insert-div-007-expected.png:
  • editing/inserting/insert-div-012-expected.checksum:
  • editing/inserting/insert-div-012-expected.png:
  • editing/inserting/insert-div-013-expected.checksum:
  • editing/inserting/insert-div-013-expected.png:
  • editing/inserting/insert-div-014-expected.checksum:
  • editing/inserting/insert-div-014-expected.png:
  • editing/inserting/insert-div-015-expected.checksum:
  • editing/inserting/insert-div-015-expected.png:
  • editing/inserting/insert-div-016-expected.checksum:
  • editing/inserting/insert-div-016-expected.png:
  • editing/inserting/insert-div-017-expected.checksum:
  • editing/inserting/insert-div-017-expected.png:
  • editing/inserting/insert-div-018-expected.checksum:
  • editing/inserting/insert-div-018-expected.png:
  • editing/inserting/insert-div-019-expected.checksum:
  • editing/inserting/insert-div-019-expected.png:
  • editing/inserting/insert-div-020-expected.checksum:
  • editing/inserting/insert-div-020-expected.png:
  • editing/inserting/insert-div-021-expected.checksum:
  • editing/inserting/insert-div-021-expected.png:
  • editing/inserting/insert-div-022-expected.checksum:
  • editing/inserting/insert-div-022-expected.png:
  • editing/inserting/insert-div-025-expected.checksum:
  • editing/inserting/insert-div-025-expected.png:
  • editing/inserting/insert-div-027-expected.checksum:
  • editing/inserting/insert-div-027-expected.png:
  • editing/inserting/insert-tab-002-expected.checksum:
  • editing/inserting/insert-tab-002-expected.png:
  • editing/inserting/insert-tab-003-expected.checksum:
  • editing/inserting/insert-tab-003-expected.png:
  • editing/inserting/insert-text-with-newlines-expected.checksum:
  • editing/inserting/insert-text-with-newlines-expected.png:
  • editing/inserting/return-key-with-selection-001-expected.checksum:
  • editing/inserting/return-key-with-selection-001-expected.png:
  • editing/inserting/return-key-with-selection-002-expected.checksum:
  • editing/inserting/return-key-with-selection-002-expected.png:
  • editing/inserting/return-key-with-selection-003-expected.checksum:
  • editing/inserting/return-key-with-selection-003-expected.png:
  • editing/inserting/typing-002-expected.checksum:
  • editing/inserting/typing-002-expected.png:
  • editing/inserting/typing-around-br-001-expected.checksum:
  • editing/inserting/typing-around-br-001-expected.png:
  • editing/pasteboard/cut-text-001-expected.checksum:
  • editing/pasteboard/cut-text-001-expected.png:
  • editing/pasteboard/paste-list-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.png:
  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-013-expected.checksum:
  • editing/pasteboard/paste-text-013-expected.png:
  • editing/pasteboard/paste-text-014-expected.checksum:
  • editing/pasteboard/paste-text-014-expected.png:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/extend-by-word-001-expected.checksum:
  • editing/selection/extend-by-word-001-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/move-backwords-by-word-001-expected.checksum:
  • editing/selection/move-backwords-by-word-001-expected.png:
  • editing/selection/move-by-character-001-expected.checksum:
  • editing/selection/move-by-character-001-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/selection/move-by-word-001-expected.checksum:
  • editing/selection/move-by-word-001-expected.png:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/style/block-styles-007-expected.checksum:
  • editing/style/block-styles-007-expected.png:
  • editing/style/create-block-for-style-002-expected.checksum:
  • editing/style/create-block-for-style-002-expected.png:
  • editing/style/create-block-for-style-003-expected.checksum:
  • editing/style/create-block-for-style-003-expected.png:
  • editing/style/create-block-for-style-004-expected.checksum:
  • editing/style/create-block-for-style-004-expected.png:
  • editing/style/create-block-for-style-006-expected.checksum:
  • editing/style/create-block-for-style-006-expected.png:
  • editing/style/create-block-for-style-008-expected.checksum:
  • editing/style/create-block-for-style-008-expected.png:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-012-expected.checksum:
  • editing/style/create-block-for-style-012-expected.png:
  • editing/style/create-block-for-style-013-expected.checksum:
  • editing/style/create-block-for-style-013-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • fast/dom/blur-contenteditable-expected.checksum:
  • fast/dom/blur-contenteditable-expected.png:
5:14 PM Changeset in webkit [12539] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Enabled spell checking for layout tests.


  • DumpRenderTree/DumpRenderTree.m: (main):
5:14 PM Changeset in webkit [12538] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin, harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Calling range() on a WordIterator destroyed its RangeImpl, use
RefPtr instead of PassRefPtr.
Turned on continuous spell checking to test the fix, found
a crasher caused by invalid positions created in
previousBoundary.

Added layout test:

  • editing/selection/end-of-document.html
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary):
4:02 PM Changeset in webkit [12537] by hyatt
  • 2 edits in trunk/WebCore

Vectorize Image. Optimize so that we no longer throw away
all CGImageRefs. Now we just throw away the last frame.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::FrameData::clear): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex):
3:18 PM Changeset in webkit [12536] by ggaren
  • 6 edits in trunk/WebCore

Reviewed by mjs.

Cleaned up some stuff I came across when working with JS enabled/
disabled code:

(1) Renamed initScript to initScriptIfNeeded, because that's what it

does

(2) Removed dead or otherwise irrelevent code
(3) Fixed up comments
(4) Removed NULL checks for interpreter() since it never returns NULL,

replaced with single assert().

No test case because there's no change in behavior.

  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate): 1 (WebCore::KJSProxyImpl::createHTMLEventHandler): 1 (WebCore::KJSProxyImpl::createSVGEventHandler): 1 (WebCore::KJSProxyImpl::interpreter): 4 (WebCore::KJSProxyImpl::initScriptIfNeeded): 1
  • khtml/ecma/kjs_proxy.h: 1
  • page/Frame.cpp: (Frame::didOpenURL): 2, 3 (Frame::stopLoading): 2 (Frame::jScriptEnabled): 2 (Frame::jScript): changed method call to data member access to match

style of rest of class

(Frame::javaEnabled): 2
(Frame::pluginsEnabled): 2
(Frame::begin): 3
(Frame::userGestureHint): 4
(Frame::pauseTimeouts): collapsed a line
(Frame::resumeTimeouts): ditto
(Frame::saveInterpreterBuiltins): 4
(Frame::restoreInterpreterBuiltins): 4

  • page/Frame.h: 2
  • page/FramePrivate.h: 2 (FramePrivate::FramePrivate): 2
1:19 PM Changeset in webkit [12535] by hyatt
  • 2 edits in trunk/WebCore

Fix for PLT performance regression. Make sure that the document's load event timer
isn't started again if it's already active.

Reviewed by mjs

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::dispatchImageLoadEventSoon):
1:00 PM Changeset in webkit [12534] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/lookup.h: Fix compile, merged from KDE.
9:32 AM Changeset in webkit [12533] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • fast/events/onunload-body-property.html: Added.
  • fast/events/onunload-body-property-expected.txt: Added.
  • fast/events/onunload-window-property.html: Added.
  • fast/events/onunload-window-property-expected.txt: Added.
9:31 AM Changeset in webkit [12532] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/events/onunload-body-property.html
  • fast/events/onunload-window-property.html
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): Change onunload case to use unloadEvent, not scrollEvent. (KJS::DOMNode::putValueProperty): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::putValueProperty): Ditto.

Reviewed by Hyatt.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowQObject::installTimeout): When converting the timeout number from an integer ms to a double seconds, use a 10 ms minimum.
9:15 AM Changeset in webkit [12531] by darin
  • 2 edits in trunk/WebCore
  • added a FIXME about an incorrect change made to FloatRect to fix the Win32 compile
  • platform/FloatRect.cpp: (WebCore::enclosingIntRect): Added FIXME because this should do a ceil operation, not a round operation.
1:29 AM Changeset in webkit [12530] by hyatt
  • 3 edits in trunk/WebCore

Fix win32 bustage. #ifdef enclosingIntRect using. Remove floorf and ceilf from enclosingIntRect impl since it's not needed. Fix the bad #import in qmatrix.h

1:00 AM Changeset in webkit [12529] by darin
  • 2 deletes in trunk/WebCore/platform

Deleted these files, Dave checked them in by mistake.

12:52 AM Changeset in webkit [12528] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/006-expected.txt

Check in revised results for 006.html test.

12:40 AM Changeset in webkit [12527] by hyatt
  • 33 edits
    2 copies in trunk/WebCore

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).


Reviewed by darin

  • WebCore.exp:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::imageChanged):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::drawPattern):
  • kwq/KWQClipboard.h: (WebCore::KWQClipboard::setDragHasStarted):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor):
  • kwq/KWQPainter.h: (WebCore::QPainter::):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::inWindow):
  • kwq/WebCoreImageRendererFactory.h:
  • kwq/WebCoreImageRendererFactory.m:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::shouldStopAnimation): (WebCore::CachedImage::animationAdvanced):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged): (WebCore::CachedObjectClient::willRenderImage):
  • platform/Image.h: (WebCore::ImageAnimationObserver::~ImageAnimationObserver): (WebCore::Image::animationObserver): (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame): (WebCore::m_PDFDoc): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setCFData): (WebCore::ImageData::imageSourceOptions): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation): (WebCore::ImageData::setCompositingOperation): (WebCore::ImageData::fillSolidColorInRect): (WebCore::ImageData::drawInRect): (WebCore::drawPattern): (WebCore::): (WebCore::ImageData::tileInRect): (WebCore::ImageData::scaleAndTileInRect): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::graphicsContext): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged):
  • rendering/render_image.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::willRenderImage):
  • rendering/render_object.h:
12:37 AM Changeset in webkit [12526] by hyatt
  • 10 edits in trunk/WebKit

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).

Reviewed by darin

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]):
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData init]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (+[WebImageRendererFactory shouldUseThreadedDecoding]): (+[WebImageRendererFactory setShouldUseThreadedDecoding:]): (-[WebImageRendererFactory setPatternPhaseForContext:inUserSpace:]): (-[WebImageRendererFactory imageDataForName:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
12:36 AM Changeset in webkit [12525] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/block/positioning/height-change-expected.checksum: Added.
  • fast/block/positioning/height-change-expected.png: Added.
  • fast/block/positioning/height-change-expected.txt: Added.
  • fast/block/positioning/height-change.html: Added.
12:35 AM Changeset in webkit [12524] by darin
  • 3 edits in trunk/WebCore

Test: LayoutTests/fast/block/positioning/height-change.html

Reviewed by Hyatt.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Relayout positioned children if the block's height changed during layout.
  • rendering/render_flexbox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
12:22 AM Changeset in webkit [12523] by darin
  • 10 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kjs/function.h:
  • kjs/function.cpp: Use OwnPtr for Parameter pointers.
  • kjs/internal.h: Use Noncopyable for LabelStack.
  • kjs/list.cpp: Use OwnArrayPtr for overflow.
  • kjs/property_map.h:
  • kjs/property_map.cpp: Use OwnArrayPtr for SavedProperties. Use Vector for some stack buffers.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: Use OwnArrayPtr for lastOvector.
12:07 AM Changeset in webkit [12522] by darin
  • 1 edit
    4 adds in trunk/JavaScriptGlue
  • added some forwarding headers to make new JavaScriptCore changes work
  • kxmlcore/Assertions.h: Added.
  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.

Feb 1, 2006:

11:42 PM Changeset in webkit [12521] by mjs
  • 16 edits in trunk/WebCore

Reviewed by Darin.

  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::generateFrameName): (WebCore::MacFrame::submitForm): (WebCore::Frame::frameDetached): (WebCore::MacFrame::nextKeyViewInFrameHierarchy): (WebCore::MacFrame::createEmptyDocument):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): (WebCore::DocumentImpl::parentDocument):
  • page/Frame.cpp: (WebCore::Frame::checkCompleted): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::requestFrameName): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::handleFallbackContent): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • page/FrameTreeNode.cpp: (WebCore::FrameTreeNode::setName): (WebCore::FrameTreeNode::appendChild): (WebCore::FrameTreeNode::removeChild):
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent):
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
11:04 PM Changeset in webkit [12520] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/float/031.html

Back out the changes to 031.html's HTML because of the 4959 partial backout.

11:02 PM Changeset in webkit [12519] by hyatt
  • 4 deletes in trunk/LayoutTests/fast/parser

Remove residual style span form test case because of the backout.

10:45 PM Changeset in webkit [12518] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Back out half of the residual style fix for bug 4959, since treating <span> like residual style breaks fast/block/float/031.html (despite buildbot and people on the outside not seeing it... how weird is that).

9:16 PM Changeset in webkit [12517] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/dom/Window/clear-timeout.html: Added.
  • fast/dom/Window/clear-timeout-expected.txt: Added.
9:15 PM Changeset in webkit [12516] by darin
  • 2 edits in trunk/WebCore

Checking in without review because I *just* broke this with my last check-in.

Test: fast/dom/Window/clear-timeout.html

  • khtml/ecma/kjs_window.cpp: (WindowQObject::clearTimeout): Fixed a != that should have been a ==.
6:51 PM Changeset in webkit [12515] by darin
  • 30 edits
    3 adds
    3 deletes in trunk/WebCore

Reviewed by Hyatt.

  • use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Added.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Added.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Added.
  • ForwardingHeaders/qtimer.h: Removed.
  • kwq/KWQTimer.cpp: Removed.
  • kwq/KWQTimer.h: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Remove timer-related features.
  • kwq/KWQEvent.h: Remove QTimerEvent.
  • WebCore.xcodeproj/project.pbxproj: Updated for file changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/Timer.h: Change to use nextFireInterval rather than nextFireTime. More convenient and also no need to define what the epoch is. Change TimerBase to use a virtual function rather than a function pointer. Added setDeferringTimers function to ensure timers don't fire while handling an event.
  • platform/mac/Timer.cpp: (WebCore::timerFired): Added deferral support. (WebCore::fireDeferred): Added. (WebCore::TimerBase::TimerBase): Simplify to remove function pointer. (WebCore::TimerBase::~TimerBase): Put in here, no longer inline. (WebCore::TimerBase::start): Change to use interval. (WebCore::TimerBase::startRepeating): Change since we use interval now. (WebCore::TimerBase::startOneShot): Ditto. (WebCore::TimerBase::stop): Added deferral support. (WebCore::TimerBase::nextFireInterval): Added. (WebCore::TimerBase::fire): Added. (WebCore::isDeferringTimers): Added. (WebCore::setDeferringTimers): Added.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Update for change to Timer class. (WebCore::MacFrame::passMouseDownEventToWidget): Update to use setDeferringTimers instead of QObject::setDefersTimers.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer): Added. Class for JavaScript "timeout". (KJS::WindowQObject::parentDestroyed): Update to use DOMWindowTimer. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerFired): Ditto. (KJS::DOMWindowTimer::fired): Added.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): Use Timer instead of timer ID. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::continueProcessing): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::stopParsing): Ditto. (WebCore::HTMLTokenizer::processingData): Ditto. (WebCore::HTMLTokenizer::timerFired): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Updated for changes to use RefPtr more cases, and not use it for m_svgExtensions. (WebCore::DocumentImpl::~DocumentImpl): Delete m_svgExtensions instead of just deref'ing it since it's no longer shared. (WebCore::DocumentImpl::implementation): Update for RefPtr. (WebCore::DocumentImpl::elementSheet): Ditto. (WebCore::DocumentImpl::styleSheets): Ditto. (WebCore::DocumentImpl::recalcStyleSelector): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventSoon): Update to use new style timer. (WebCore::DocumentImpl::removeImage): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventsNow): Ditto. (WebCore::DocumentImpl::imageLoadEventTimerFired): Ditto. (WebCore::DocumentImpl::svgExtensions): Update for RefPtr. (WebCore::DocumentImpl::accessSVGExtensions): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.h: (WebCore::TimeScheduler::document):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::downcast): (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::start): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify): (WebCore::TimeScheduler::TimeScheduler): (WebCore::TimeScheduler::~TimeScheduler): (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired): Rework to use new timer.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp: Make SVGDocumentExtensions no longer be shared, be solely owned by the document.
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::createStyleSelector): Update for RefPtr use.
  • kwq/KWQSlot.cpp: Remove endLifeSupport and timerNotify slots.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Update to use new style timer. (WebCore::Frame::caretBlinkTimerFired): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Update to use new style timer. (WebCore::FrameView::clear): Ditto. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::layoutTimerFired): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::layoutPending): Ditto. (WebCore::FrameView::haveDelayedLayoutScheduled): Ditto. (WebCore::FrameView::unscheduleRelayout): Ditto.
  • page/ObjectContents.h: Remove unneeded includes.
  • rendering/render_frames.cpp: Removed include of <qtimer.h>.
  • rendering/render_layer.h:
  • rendering/render_layer.cpp: (WebCore::Marquee::Marquee): Use new style timers. (WebCore::Marquee::start): Ditto. (WebCore::Marquee::suspend): Ditto. (WebCore::Marquee::stop): Ditto. (WebCore::Marquee::updateMarqueeStyle): Ditto. (WebCore::Marquee::timerFired): Ditto.
2:36 PM Changeset in webkit [12514] by bdakin
  • 3 edits in trunk/WebCore

Patch by Darin. Reviewed by Beth.

Fix for <rdar://problem/4424126> REGRESSION(412-420+): yellow
highlight fails to follow cursor when mousing over star rating
(6232)

Event coordinates cannot be calculated until there is a target.
This patch restructures the code so that the coordinates are
initialized when the mouse event is created but are not calculated
until the target is set.

Jan 31, 2006:

10:30 PM Changeset in webkit [12513] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/layer-hit-test-crash-expected.checksum: Added.
  • fast/dynamic/layer-hit-test-crash-expected.png: Added.
  • fast/dynamic/layer-hit-test-crash-expected.txt: Added.
  • fast/dynamic/layer-hit-test-crash.html: Added.

WebCore:

Reviewed by Darin.

  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTestLayer): Iterate vectors in a way that won't break on empty ones.
10:24 PM Changeset in webkit [12512] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • fixed leak of hundreds of thousands of JS parser nodes on the layout tests, and added an exit counter that would catch them
  • kjs/nodes.cpp: (NodeCounter::~NodeCounter): Added debug-only node counter. (Node::Node): (Node::~Node):
  • kxmlcore/VectorTraits.h: Simple classes like RefPtr do in fact need destruction.
8:33 PM Changeset in webkit [12511] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • added deleteAllValues for HashSet as well as HashMap
  • fixed conversion from const_iterator to iterator, which I broke a while back
  • kxmlcore/HashMap.h: Updated copyright date.
  • kxmlcore/HashSet.h: (KXMLCore::deleteAllValues): Added.
  • kxmlcore/HashTable.h: (KXMLCore::HashTableIterator::operator const_iterator): Added.
6:44 PM Changeset in webkit [12510] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/input-changing-value-expected.txt: Added.
  • fast/forms/input-changing-value.html: Added.

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
Input's value doesn't get updated after typing in new text field

Added test:
fast/forms/input-changing-value.html

Added an event listener for a DOMCharacterDataModifiedEvent on the inner div.
When we get the event, then we update the input element's value field.

There may be performance problems with this approach that we will have to
address before flipping the switch to use these new text fields.

  • rendering/RenderTextField.cpp: (WebCore::InputMutationListener::handleEvent): calls subtreeHasChanged (WebCore::m_mutationListener): (WebCore::RenderTextField::~RenderTextField): remove the event listener. (WebCore::RenderTextField::setStyle): Remove unnecessary setStyle on text node. It should inherit style from the div already. (WebCore::RenderTextField::updateFromElement): add the event listener. (WebCore::RenderTextField::subtreeHasChanged): updates the input element's value.
  • rendering/RenderTextField.h: (WebCore::InputMutationListener::InputMutationListener): Added. (WebCore::InputMutationListener::renderTextField): Added. (WebCore::InputMutationListener::setInputElement): Added.
5:49 PM Changeset in webkit [12509] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4267144> REGRESSION (10.4.2): Safari pages auto-scroll too easily during drag over content [5853]


There were two issues here:
(1) dragging over a non-editable webview (such as a typical Safari page) should not have
auto-scrolled at all; the fact that it did was an uninentional side effect of making
auto-scroll work for editable webviews a la Blot.
(2) the speed & hot area of the auto-scroll changed between 10.4.1 and 10.4.2.


I have a fix for (1), which is the much more important issue. I'll modify the bugzilla bug
to be about the remaining issue.

  • WebView.subproj/WebView.m: (-[WebView _autoscrollForDraggingInfo:timeDelta:]): do nothing if not editable (-[WebView _shouldAutoscrollForDraggingInfo:]): return NO if not editable
5:18 PM Changeset in webkit [12508] by thatcher
  • 11 edits
    4 adds in trunk

LayoutTests:

Adding test cases for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

Updated older tests/results to work with the patch.
Some of the tests had an open <span> with no close.

  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-003.html:
  • editing/undo/redo-typing-001-expected.txt:
  • editing/undo/redo-typing-001.html:
  • editing/undo/undo-typing-001-expected.txt:
  • editing/undo/undo-typing-001.html:
  • fast/block/float/031.html:
  • fast/parser/residual-style-span-form-expected.checksum: Added.
  • fast/parser/residual-style-span-form-expected.png: Added.
  • fast/parser/residual-style-span-form-expected.txt: Added.
  • fast/parser/residual-style-span-form.html: Added.
  • fast/text/whitespace/006-expected.txt:

WebCore:

Reviewed by Dave Hyatt.
Landed by Timothy Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

  • khtml/html/htmlparser.cpp: (HTMLParser::isResidualStyleTag): add <span> as residual style tag (HTMLParser::isAffectedByResidualStyle): add <form> as tag affected by residual style
4:24 PM Changeset in webkit [12507] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Adding -Wno-long-double to avoid a warning.

3:59 PM Changeset in webkit [12506] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


Support for programmatic scrolling one line at a time for PDFs. (We already had support for
programmatic scrolling one page at a time, and to top/end.)

  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): generalized comment (-[WebPDFView scrollLineDown:]): pass a faked arrow-down key event (-[WebPDFView scrollLineUp:]): pass a faked arrow-up key event
3:38 PM Changeset in webkit [12505] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fixed an invalid assertion that UTF8Chars is not NULL. It is valid for it to be NULL as long as UTF8Length is 0. This fixes an assertion failure on TOT at <​http://www.musicindiaonline.com/p/x/tJO0OOBME9.As1NMvHdW/>, where JavaScript is getting a NULL string back from some call on the Real Player plugin.
1:50 PM Changeset in webkit [12504] by vicki
  • 3 edits
    4 adds
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4426668> REGRESSION: sometimes URLs with named anchors in a page don't jump to proper location in document (6916). Added test cases for this fix and past link jumping bug fixes.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Traverse up the parent node chain until you find one that has a sibling.
  • manual-tests/linkjump-1.html: Added a note here - the bug for this test case is still broken in TOT.
  • manual-tests/linkjump-2.html: Added. Renamed scrollToAnchor.html, to group it with the rest of the link jumping tests.
  • manual-tests/linkjump-3.html: Added. Test case for this bug, <rdar://problem/4426668>.
  • manual-tests/linkjump-4.html: Added. Test case for past fix, <rdar://problem/4247537>.
  • manual-tests/linkjump-5.html: Added. Test case for past fix, <rdar://problem/4256060>.
  • manual-tests/scrollToAnchor.html: Removed.
12:41 PM Changeset in webkit [12503] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test cases for:
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy


  • editing/pasteboard/paste-empty-startcontainer-expected.png: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.checksum: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Added.
  • editing/pasteboard/paste-empty-startcontainer.html: Added.
12:41 PM Changeset in webkit [12502] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy

Layout test added:

  • editing/pasteboard/paste-empty-startcontainer.html


  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::startNode):
  • use empty non-textual m_startContainer itself if m_startOffset is 0, rather then nextSibling()
10:55 AM Changeset in webkit [12501] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


  • fast/forms/selected-index-assert-expected.txt: Added.
  • fast/forms/selected-index-assert.html: Added.

WebCore:

Test: fast/forms/selected-index-assert.html.

Reviewed by Adele.


  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::selectedIndex): Removed bogus assert. -1 is the correct value to return if no option is selected.
10:14 AM Changeset in webkit [12500] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fixing build bustage. Removing include of khtml_factory.h since it
has been removed.

9:45 AM Changeset in webkit [12499] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • fast/forms/button-cannot-be-nested-expected.png: Added.
  • fast/forms/button-cannot-be-nested-expected.txt: Added.
  • fast/forms/button-cannot-be-nested.html: Added.
9:45 AM Changeset in webkit [12498] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • khtml/html/htmlparser.cpp: (HTMLParser::getNode): Add buttonTag to error handling table to take care of unclosed tags.
9:41 AM Changeset in webkit [12497] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.


  • fast/parser/script-after-frameset-assert-expected.txt: Added.
  • fast/parser/script-after-frameset-assert.html: Added.
9:41 AM Changeset in webkit [12496] by darin
  • 2 edits in trunk/WebCore

Test: fast/parser/script-after-frameset-assert.html

Reviewed by Darin.


  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Reset scriptNode to 0 if the script is being skipped.
9:36 AM Changeset in webkit [12495] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/fixed-table-non-cell-in-row.html: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.png: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.checksum: Added.
9:31 AM Changeset in webkit [12494] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): Remove the assertion.
9:18 AM Changeset in webkit [12493] by andersca
  • 5 edits in trunk

2006-01-31 Anders Carlsson <​andersca@mac.com>

Reviewed by John.


  • khtml/ecma/kjs_html.cpp: (KJS::ImagePattern::createPattern): Don't mirror the x coordinate when creating the pattern.
9:09 AM Changeset in webkit [12492] by darin
  • 66 edits
    2 adds
    3 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • added a Timer class
  • used the Timer class for the redirection timer
  • moved Frame, FrameView, MacFrame, and FrameNodeTree into WebCore namespace
  • removed more KWQ
  • ForwardingHeaders/khtml_factory.h: Removed.
  • kwq/KWQKHTMLFactory.cpp: Removed.
  • kwq/KWQKHTMLFactory.h: Removed.
  • platform/Timer.h: Added.
  • platform/mac/Timer.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for added and removed files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::init): Remove code to set up slotRedirect. (WebCore::Frame::checkCompleted): Call start/stopRedirectionTimer instead of using the redirection timer directly. (WebCore::Frame::scheduleRedirection): Ditto. (WebCore::Frame::scheduleLocationChange): Ditto. (WebCore::Frame::scheduleHistoryNavigation): Ditto. (WebCore::Frame::cancelRedirection): Ditto. (WebCore::Frame::redirectionTimerFired): Renamed from slotRedirect. (WebCore::Frame::slotParentCompleted): More startRedirectionTimer. (WebCore::Frame::startRedirectionTimer): Added. Virtual bottleneck to start the redirection timer. (WebCore::Frame::stopRedirectionTimer): Added. Virtual bottleneck to stop the redirection timer.
  • page/FramePrivate.h: Changed m_redirectionTimer from a QTimer to a Timer.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Added. Avoids the need for the QTimer "monitor" feature that I had added a while back to implement the client-redirected callback. (WebCore::MacFrame::stopRedirectionTimer): Ditto.
  • kwq/KWQSlot.cpp: Removed slotRedirected.
  • ForwardingHeaders/ksvg2/KSVGPart.h: Removed using to put Frame into various namespaces (all of which are WebCore now anyway).
  • bindings/objc/DOMInternal.mm:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/KWQKHTMLView.cpp:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/SelectionController.h:
  • khtml/editing/jsediting.h:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQClipboard.h:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.h:
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQListBox.mm:
  • kwq/KWQSignalStubs.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQWidget.mm:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • loader/DocLoader.h:
  • page/FrameTreeNode.cpp:
  • page/FrameTreeNode.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • rendering/InlineTextBox.h:
  • rendering/font.cpp:
  • rendering/render_canvas.h:
  • rendering/render_frames.h:
  • rendering/render_object.h:
  • rendering/render_replaced.h: Updated for namespace and header changes.

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Updated for name change.
5:21 AM Changeset in webkit [12491] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Added test case I forgot to commit earlier.


  • fast/parser/remove-block-in-residual-style.html: Added.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Added.
  • fast/parser/remove-block-in-residual-style-expected.png: Added.
  • fast/parser/remove-block-in-residual-style-expected.txt: Added.

Jan 30, 2006:

11:41 PM Changeset in webkit [12490] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Update test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • fast/dom/undetectable-document-all.html: Test that typeof document.all is undefined.
11:41 PM Changeset in webkit [12489] by andersca
  • 6 edits in trunk

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • kjs/nodes.cpp: (typeStringForValue): Return "undefined" if the given object should masquerade as undefined.


  • kjs/object.h: (KJS::JSObject::masqueradeAsUndefined): Rename from isEqualToNull.


  • kjs/operations.cpp: (KJS::equal): Update for name change.
10:08 PM Changeset in webkit [12488] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Added comments about things we should do to improve.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
10:08 PM Changeset in webkit [12487] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Pointed out by Dave Kilzer.

  • added test result I forgot to check in
  • fast/dom/Range/range-exceptions-expected.txt: Added.
6:52 PM Changeset in webkit [12486] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by mjs.

  • Speculative fix for <rdar://problem/4135845> Crash executing cross-frame script on timeout in KJS::ScheduledAction::execute

If we ever get a reproducible case of 4135845, I'll add a test for it.

This is a re-working of Maciej's fix for 3157014 (circa 2003!). Since
you can't reliably predict what the state of the page will be when
a timer fires, I've made the timer responsbile for making sure that
everything is OK to execute.

I tested @ ​http://www.javascriptkit.com/script/cut3.shtml with various
combinations of reload, back, and regular navigations with JS enabled/
disabled to ensure that the previous crash didn't return. I also ran a
leaks test and discovered some, but none unique to this patch. (See
<rdar://problem/4427420> TOT REGRESSION: Leaks seen on page with
JavaScript timer.)

  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Return early if there's no window object. (This happens when JavaScript is disabled.) (KJS::Window::retrieveWindow): Reversed a backwards ASSERT, increased prettiness. (The assert fired while I was testing. Not sure why we haven't seen it before.)
  • page/Frame.cpp: (Frame::didOpenURL): Returned setting of JavaScript enabled/disabled preference to its rightful place. This introduces a new behavior: now, the unload event does not fire after you've disabled JavaScript. That seems like a good thing. (See <rdar://problem/4426506> Disabling JavaScript should immediately end JavaScript execution.) (Frame::begin): Ditto.
5:03 PM Changeset in webkit [12485] by thatcher
  • 9 copies in tags/Safari-521.6.2

New tag.

5:00 PM Changeset in webkit [12484] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning and updated the copyright dates.

4:52 PM Changeset in webkit [12483] by thatcher
  • 1 delete in tags/Safari-521.6.2

Redoing this tag.

3:51 PM Changeset in webkit [12482] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

Add -Wno-deprecated-declarations to the compile flags for WebNetscapePluginPackage.m.
<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment now deprecated.
When we workaround these we can remove this compile flag.

  • WebKit.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [12481] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Remove the only use of -[NSFont glyphPacking]. This method was deprecated in Tiger
and always returns NSNativeShortGlyphPacking.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]):
12:14 PM Changeset in webkit [12480] by ggaren
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Dave Harrison.

  • Fixed <rdar://problem/4378159> crash in KWQKHTMLPart::userGestureHint from javascript enabled/disabled inconsistency when pasting webpage into email or blot
  • page/Frame.cpp: (Frame::userGestureHint): Check root frame's jScript() for NULL instead of checking inner frame's jScript().


After init() has been called on a frame, but before begin() has been
called, the frame can have JavaScript enabled when its parent doesn't.
(That seems wrong, so I've filed <rdar://problem/4426499> Child frame
momentarily has JavaScript enabled even though parent frame doesn't.)


Regardless, it's better programming practice to NULL check the actual
pointer you're going to use, so that's what I've done here.

  • manual-tests/paste-crash.html: Added. (No automated test because the crash depends on JavaScript being disabled.)
10:56 AM Changeset in webkit [12479] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4298052> Crash in
KWQCheckIfReloading at ​http://www.inquisitorx.com/beta/

10:45 AM Changeset in webkit [12478] by bdakin
  • 3 edits in trunk/WebCore

eviewed by Geoff

Fix for <rdar://problem/4298052> Crash in KWQCheckIfReloading at
​http://www.inquisitorx.com/beta/

It is possible for the DocLoader's frame to be nil when the
DocLoader is not nil, so we need nil checks.

10:31 AM Changeset in webkit [12477] by eseidel
  • 2 edits in trunk/WebCore

2006-01-30 Eric Seidel <​eseidel@apple.com>

Add #import "KWQFontMetrics.h" to fix no-svg build.

  • kwq/KWQPainter.mm:
1:03 AM Changeset in webkit [12476] by darin
  • 78 edits in trunk

LayoutTests:

  • updated test result for rect changes
  • fast/box-sizing/percentage-height-expected.txt: A bunch of strange empty clip rects are now dumping as (0,0) 0x0.

WebCore:

Reviewed by Eric.

  • cleanup of Int/Float-Size/Point/Rect classes

I did this as part of a redo of QMatrix, but I decided I should
land this part separately.

Eliminated the concept of a null rect or point, which used to be
indicated by negative width and height.

Changed right and bottom to to be, e.g., 2 for a rect at (0,0) 2x2.
The old code followed Qt's system that says right is 1 in those cases,
which is inappropriate for floating point, and old fashioned because
modern graphics systems use coordinates for lines between pixels, not
the pixels themselves.

Other API improvements to the point, size, and rect classes. For example,
functions named with verbs now always modify the object itself.

  • rendering/render_theme_mac.mm: (RenderThemeMac::paintButton): Fixed a bug where it said x() where it should say y().
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasContainer.cpp:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/misc/khtmllayout.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegion.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQScrollView.mm:
  • kwq/KWQWMatrix.cpp:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm:
  • kwq/KWQWindowWidget.mm:
  • loader/CachedImage.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/FloatPoint.cpp:
  • platform/FloatPoint.h:
  • platform/FloatRect.cpp:
  • platform/FloatRect.h:
  • platform/FloatSize.cpp:
  • platform/FloatSize.h:
  • platform/Image.h:
  • platform/IntPoint.cpp:
  • platform/IntPoint.h:
  • platform/IntPointArray.cpp:
  • platform/IntPointArray.h:
  • platform/IntRect.cpp:
  • platform/IntRect.h:
  • platform/IntSize.cpp:
  • platform/IntSize.h:
  • platform/mac/FloatPoint.mm:
  • platform/mac/FloatRect.mm:
  • platform/mac/FloatSize.mm:
  • platform/mac/Image.mm:
  • platform/mac/IntPoint.mm:
  • platform/mac/IntRect.mm:
  • platform/mac/IntSize.mm:
  • platform/mac/Screen.mm:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_box.cpp:
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp:
  • rendering/render_flow.cpp:
  • rendering/render_form.cpp:
  • rendering/render_frames.cpp:
  • rendering/render_layer.cpp:
  • rendering/render_line.cpp:
  • rendering/render_list.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
12:42 AM Changeset in webkit [12475] by mjs
  • 15 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): Implement for Vector<KCGradientStop> (KRenderingPaintServerGradient::gradientStops): Use a Vector, not a subclass of QPtrList that sorts on every insert (compareStopOffset): Comparison function for sorting. (KRenderingPaintServerGradient::setGradientStops): Add a version that takes a Vector which sorts, and another which knows how to copy from another gradient paint server.
  • kcanvas/device/KRenderingPaintServerGradient.h: (makeGradientStop): Make a gradient stop pair.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): use delete on stops cache (KRenderingPaintServerGradientQuartz::updateQuartzGradientStopsCache): adapt to Vector
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/editing/visible_text.cpp: (khtml::compareBoxStart): Comparison function for sorting. (khtml::TextIterator::handleTextNode): Use Vector and std::sort instead of QSortedList for sorting. Keep current position as an index. (khtml::TextIterator::handleTextBox): Adapt for Vector use.
  • khtml/editing/visible_text.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops): Use a Vector. Instead of modifying the existing one, make a fresh one and assign it.
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient): don't copy item by item, just assign directly.
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): ditto
  • ksvg2/svg/SVGStopElementImpl.h:
  • kwq/KWQListImpl.cpp:
  • kwq/KWQPtrList.h: (QPtrList::sort): Removed.
  • kwq/KWQSortedList.h: Removed.
  • rendering/InlineTextBox.h: Remove now unneeded operator< and operator=
Note: See TracTimeline for information about the timeline view.