Context Navigation

rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Consider border, padding, and the width of the caret properly in the calculation of the caret's X position.

rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Fixed some similar issues and rewrote this function for clarity. However, I suspect this function was and remains broken and is almost never called.

3:35 PM Changeset in webkit [13630] by darin

9 edits
3 adds in trunk

LayoutTests:

Reviewed by Justin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8106 REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
fast/forms/input-text-scroll-left-on-blur.html: Added.

WebCore:

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8106 REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

Test: fast/forms/input-text-scroll-left-on-blur.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events through to the RenderTextField, as well as mouse, drag, and wheel events.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to the left on a blur.

unrelated small changes

html/HTMLTextFieldInnerElement.cpp: Removed excess includes. (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.

dom/Element.cpp: (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call. (WebCore::Element::scrollIntoViewIfNeeded): Ditto.

page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.

WebKitTools:

Reviewed by Justin.

DumpRenderTree/EventSendingController.m: (-[EventSendingController keyDown:withModifiers:]): Fixed keyDown function so that it will work if you don't pass an array of modifiers or if elements in that array are not strings.

2:27 PM Changeset in webkit [13629] by darin

2 edits in trunk/WebKitLibraries

Reviewed by Beth.

libWebKitSystemInterface.a: Changed alpha in the focus-ring drawing code to use the system default alpha.

12:59 PM Changeset in webkit [13628] by mjs

1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Ooops, actually land the fix with this ChangeLog entry:

2006-03-31 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adele.

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.

11:39 AM Changeset in webkit [13627] by darin

62 edits in trunk/LayoutTests

re-updated many pixel results to try to create a new baseline

2:14 AM Changeset in webkit [13626] by mjs

2 edits
2 adds in trunk

LayoutTests:

Test cases for:

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

fast/forms/input-paste-undo-expected.txt: Added.
fast/forms/input-paste-undo.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.

1:40 AM Changeset in webkit [13625] by darin

4 edits
4 adds in trunk

LayoutTests:

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8063 REGRESSION: double clicking in new text fields won't select whole words

fast/forms/input-text-double-click-expected.checksum: Added.
fast/forms/input-text-double-click-expected.png: Added.
fast/forms/input-text-double-click-expected.txt: Added.
fast/forms/input-text-double-click.html: Added.

WebCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8063 REGRESSION: double clicking in new text fields won't select whole words

Test: fast/forms/input-text-double-click.html

editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by calling selectNodeContents rather than by calling setEndAfter. The problem with setEndAfter is that it doesn't do anything when the parent of the node is 0, and also it's not really what we want, since the boundary node is one with editable contents -- we want to stay inside the boundary node.

editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch I noticed at the same time.

1:32 AM Changeset in webkit [13624] by darin

3 edits
4 adds in trunk

LayoutTests:

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8105 REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

fast/forms/input-text-option-delete-expected.checksum: Added.
fast/forms/input-text-option-delete-expected.png: Added.
fast/forms/input-text-option-delete-expected.txt: Added.
fast/forms/input-text-option-delete.html: Added.

WebKit:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8105 REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

Test: fast/forms/input-text-option-delete.html

WebView/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Pass NO for smartDeleteOK. Smart deletion only applies to deleting a word at a time, and none of the callers of this function that delete a word at a time want smart deletion. (-[WebHTMLView deleteToEndOfLine:]): Fixed tiny formatting glitch.

Mar 31, 2006:

4:40 PM Changeset in webkit [13623] by thatcher

1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 3 to see if we come in under the BuildBot timeout.

4:12 PM Changeset in webkit [13622] by thatcher

1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 4 to see if we come in under the BuildBot timeout.

3:14 PM Changeset in webkit [13621] by sullivan

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)

bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.

2:39 PM Changeset in webkit [13620] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

We need to set reachedTerminalState to YES before we release
the resources to prevent a double dealloc of WebView

Fixes <rdar://problem/4372628> crash deallocating a WebView in -[WebFrame stopLoading]

WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): set reachedTerminalState earlier

1:50 PM Changeset in webkit [13619] by bdakin

3 edits
4 adds in trunk

Reviewed by John.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
REGRESSION (r13590-r13593): Floating table's cells don't paint
their background

This is a regression from my painting patch yesterday. Just a silly
error I didn't catch.

rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Change the phase of our new PaintInfo, not our old one.

1:36 PM Changeset in webkit [13618] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Omernick.

Some cleanup in the WebIconDatabase code in a fruitless search for the cause
of the mysterious -[WebFileDatabase performSetObject:forKey] crash

Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): removed obsolete comment (-[WebIconDatabase _loadIconDictionaries]): Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until the end of the method where they are retained, so that the early returns don't leak; added ASSERTs that the _private->dictionary values aren't being leaked. (-[WebIconDatabase _updateFileDatabase]): Added an ERROR for an unexpected early return, and made a trivial style fix.

12:58 PM Changeset in webkit [13617] by tomernic

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

Layout test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

fast/forms/input-appearance-readonly-expected.txt: Added.
fast/forms/input-appearance-readonly.html: Added.

WebCore:

Reviewed by Adele.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Set user modify based on the form element's readOnly(). (WebCore::RenderTextField::updateFromElement): ditto

12:44 PM Changeset in webkit [13616] by adele

3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Updating shadowAncestorNode so it doesn't check for rootEditableElement. Now we just walk
up the tree to look for a shadowNode, and then we find the shadowParent.

dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Updated assertion to check for shadowAncestorNode instead of rootEditableElement.

12:30 PM Changeset in webkit [13615] by ap

3 edits
2 copies
7 adds in trunk

Fix by Trey Matteson, reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html

The gist of this change is that we must cancel the load from the Webkit side when we
realize we're switching to the fallback content. This is somewhat a temp workaround
since control of loading will be moving to WebCore.

WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):

12:12 PM Changeset in webkit [13614] by adele

3 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8101 REGSRESSION: Fix for bug 7031 causes 30 layout tests to fail

rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions only if childAffectsTopBottomPos is true.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that wasn't committed with the rest of the patch.

11:16 AM Changeset in webkit [13613] by bdakin

3 edits
4 adds in trunk

Reviewed by Darin, landed by Beth.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
REGRESSION: Drop-down menu has gap at top

rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating the hypothetical vertical position in normal flow, skip table rows in the ancestor chain, since a table cell's Y position is relative to the table section, not the row.

11:03 AM Changeset in webkit [13612] by hyatt

4 edits in trunk/WebCore

FIx theme borders on win32.

10:51 AM Changeset in webkit [13611] by darin

14 edits
2 adds in trunk

LayoutTests:

updated results for tests that involve scrolling

editing/selection/focus_editable_html-expected.txt: Added expected scroll position.
fast/dom/focus-contenteditable-expected.txt: Ditto.
fast/overflow/scrollRevealButton.html: Ditto.

updated results for tests that involve new exception names

fast/dom/Element/attr-param-typechecking-expected.txt: Updated.

fast/dynamic/insertAdjacentElement-expected.txt: Updated.
fast/dynamic/insertAdjacentElement-expected.png: Added.
fast/dynamic/insertAdjacentElement-expected.checksum: Added.

WebCore:

Reviewed by John Sullivan.

khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in the mapping from error code to error name.

dom/Element.idl: Removed comment from bad old days where we had to touch these files to make them rebuild.

WebKitTools:

Reviewed by John Sullivan.

added a "--reset-results" option to run-webkit-tests so you can reset the results without first deleting expected results
<rdar://problem/4185878> add scroll position to dumpRenderTree

Scripts/run-webkit-tests: Rearranged the code a bit to make the sequence more logical. Moved all the subroutines to the end of the file. Added a "--force" option.

DumpRenderTree/DumpRenderTree.m: (main): Added a new --dump-all-pixels option, used when forcing run-webkit-tests to generate new output for all tests it runs. (dump): Dump the scroll position if it's non-zero. Always dump the image when the --dump-all-pixels option is passed. Also tightened up the image dumping code and replaced the incorrect use of +[NSGraphicsContext saveGraphicsState] with code to save and restore the context.

DumpRenderTree/DumpRenderTree.h: Tweaked includes a bit and added (void).
DumpRenderTree/EventSendingController.m: Added now-needed include.

10:02 AM Changeset in webkit [13610] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/4395622> API: WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript returns NO by default

bindings/objc/WebScriptObject.h: Fixed comment.

9:40 AM Changeset in webkit [13609] by bdakin

1 edit
4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
Focus ring around link in overflow:auto div isn't clipped to div

8:39 AM Changeset in webkit [13608] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Removed all the tabs and cleared the "allow tabs" bit.

3:45 AM Changeset in webkit [13607] by hyatt

1 edit in trunk/WebCore/rendering/RenderTheme.cpp

Fix my build bustage with themes.

3:32 AM Changeset in webkit [13606] by mjs

4 edits in trunk/WebCore

fixed Windows build breakage from previous change

platform/ScrollView.h:
platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy):

3:24 AM Changeset in webkit [13605] by mjs

22 edits in trunk/WebCore

Reviewed by Eric.

various Point / Size related cleanup

First, I clarified the semantics of some operations to keep a
better distinction between IntPoint and IntSize:

platform/IntPoint.h: (WebCore::IntPoint::move): new convenience to move a point by separate x and y deltas. (WebCore::operator+=): You can't add a point to a point, you can only add a size to a point. (WebCore::operator+): ditto (WebCore::operator-): point - point = size; point - size = point (WebCore::operator-=): only allow subtracting a size for the mutating version
platform/IntRect.h: (WebCore::IntRect::move): tweaked to use IntPoint::move, also, move by an IntSize, not an IntPoint.
platform/IntSize.h: (WebCore::IntSize::shrunkTo): analog to expandedTo (WebCore::IntSize::clampNegativeToZero): a handy helper (WebCore::operator-): Added unary minus operator

Made the same changes for FloatPoint:

platform/FloatPoint.h: (WebCore::FloatPoint::move): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-):
platform/FloatRect.h: (WebCore::FloatRect::move):
platform/FloatSize.h: (WebCore::operator-):

Then I changed a bunch of stuff to pass around IntPoint instead of separate x and y
coordinates. The main one was:

platform/ScrollView.h:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollOffset): new method, return an IntSize (WebCore::ScrollView::contentsToViewport): take and return an IntPoint (WebCore::ScrollView::viewportToContents): take and return an IntPoint
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents): handle things in terms of scrollOffset, not scrollPoint (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::updateScrollBars):

The rest is mainly updates for these changes.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isPointInsideSelection:]):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent):
khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
page/Frame.cpp: (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::isPointInsideSelection): (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventPart2): (WebCore::Frame::handleMouseReleaseEvent):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
rendering/RenderObject.h: (WebCore::RenderObject::positionForPoint):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):

3:18 AM Changeset in webkit [13604] by mjs

2 edits in trunk/WebCore

fixed windows build

platform/win/TemporaryLinkStubs.cpp: (Widget::unlockDrawingFocus):

1:15 AM Changeset in webkit [13603] by eseidel

8 edits in trunk/JavaScriptCore

2006-03-31 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/interpreter.cpp: (KJS::ExecState::lexicalInterpreter):
kjs/interpreter.h:
kjs/operations.cpp: (KJS::equal):

1:14 AM Changeset in webkit [13602] by eseidel

9 edits in trunk/WebCore

2006-03-31 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
kwq/WebCoreTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQSecureTextField selectText:]):
page/Frame.cpp: (WebCore::Frame::submitForm):
platform/Widget.h:
platform/mac/WidgetMac.mm:
rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):

Mar 30, 2006:

11:39 PM Changeset in webkit [13601] by mjs

11 edits
3 adds in trunk/WebCore

Reviewed by Eric.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::wheelEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::sendContextMenuEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
dom/Document.h:
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): (-[WebCoreAXObject accessibilityHitTest:]):
manual-tests/frame-hover.html: Added.
manual-tests/resources/hover-subframe-1.html: Added.
manual-tests/resources/hover-subframe-2.html: Added.
page/Frame.cpp: (WebCore::Frame::isPointInsideSelection):
page/FrameView.cpp: (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent):
platform/IntRect.h: (WebCore::IntRect::contains):
rendering/RenderLayer.cpp: (WebCore::isSubframeCanvas): (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::shouldApplyImplicitCapture): (WebCore::RenderLayer::hitTestLayer):
rendering/RenderLayer.h:

11:37 PM Changeset in webkit [13600] by andersca

1 edit
3 adds in trunk/LayoutTests

2006-03-31 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

Add getter/setter GC tests.

fast/js/getter-setter-gc-expected.txt: Added.
fast/js/getter-setter-gc.html: Added.
fast/js/resources/getter-setter-gc.js: Added.

11:25 PM Changeset in webkit [13599] by darin

185 edits in trunk/LayoutTests

2006-03-30 Darin Adler <Darin Adler>

updated pixel results to create a new baseline (on a 10.4.5 system)

10:52 PM Changeset in webkit [13598] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by anders.

Small code-style update.

kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf): (KJS::equal): (KJS::strictEqual): (KJS::relation): (KJS::maxInt): (KJS::minInt): (KJS::add): (KJS::mult):

10:48 PM Changeset in webkit [13597] by andersca

2 edits in trunk/JavaScriptCore

2006-03-31 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

Make sure the GetterSetterImp objects are marked as well.

kjs/internal.cpp: (KJS::GetterSetterImp::mark): Call JSCell::mark().

9:49 PM Changeset in webkit [13596] by adele

4 edits
8 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8056 Flexible boxes do not repaint their top, left and children's overflows

fast/repaint/flexible-box-overflow-expected.checksum: Added.
fast/repaint/flexible-box-overflow-expected.png: Added.
fast/repaint/flexible-box-overflow-expected.txt: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.checksum: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
fast/repaint/flexible-box-overflow-horizontal.html: Added.
fast/repaint/flexible-box-overflow.html: Added.

WebCore:

Tests: fast/repaint/flexible-box-overflow.html fast/repaint/flexible-box-overflow-horizontal.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8056 Flexible boxes do not repaint their top, left and children's overflows

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren):
rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutHorizontalBox): Update top overflow when determining vertical positions. Update horizontal overflows after horizontal positions are determined. (WebCore::RenderFlexibleBox::layoutVerticalBox): Update left overflow when determining horizontal positions. Update vertical overflows after vertical positions are determined. (WebCore::RenderFlexibleBox::allowedChildFlex):

9:23 PM Changeset in webkit [13595] by adele

7 edits
13 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7301 Text shadow does not repaint correctly

fast/repaint: Added.
fast/repaint/inline-block-overflow-expected.checksum: Added.
fast/repaint/inline-block-overflow-expected.png: Added.
fast/repaint/inline-block-overflow-expected.txt: Added.
fast/repaint/inline-block-overflow.html: Added.
fast/repaint/text-shadow-expected.checksum: Added.
fast/repaint/text-shadow-expected.png: Added.
fast/repaint/text-shadow-expected.txt: Added.
fast/repaint/text-shadow-horizontal-expected.checksum: Added.
fast/repaint/text-shadow-horizontal-expected.png: Added.
fast/repaint/text-shadow-horizontal-expected.txt: Added.
fast/repaint/text-shadow-horizontal.html: Added.
fast/repaint/text-shadow.html: Added.

WebCore:

Tests: fast/repaint/text-shadow.html fast/repaint/text-shadow-horizontal.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7301 Text shadow does not repaint correctly

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Paint the text box if it is within the maximum possible horizontal shadow overflow of the damage rect.
rendering/InlineTextBox.h: Removed unused function checkVerticalPoint().
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Use the vertical overflows instead of the selection vertical bounds. (WebCore::RenderFlow::hitTestLines):
rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include overflow due to text shadow in leftPosition and rightPosition and keep track of the maximum horizontal shadow on the inline. (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically): Include overflow due to shadow and inline-blocks' overflow in topPosition and bottomPosition but not in the selection vertical bounds. (WebCore::RootInlineBox::selectionTop):
rendering/render_line.h: (WebCore::InlineFlowBox:::InlineRunBox): (WebCore::InlineFlowBox::setVerticalSelectionPositions): (WebCore::InlineFlowBox::maxHorizontalShadow): (WebCore::RootInlineBox::setVerticalSelectionPositions): (WebCore::RootInlineBox::selectionBottom): (WebCore::RootInlineBox::selectionHeight):

7:12 PM Changeset in webkit [13594] by hyatt

6 edits in trunk/WebCore

Land focus ring bug fix and win theme improvements.

5:21 PM Changeset in webkit [13593] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

kjs/nodes.h: Some various small style fixes.

5:19 PM Changeset in webkit [13592] by bdakin

25 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4472371> REGRESSION(417.9-TOT): Focus ring
around link in overflow:auto div isn't clipped to div

Focus rings around the children off overflow:auto divs were not
being appropriately clipped because they were being painted with
the div's outlineRect, when they should be painted separately. This
patch adds two new PaintPhases -- PaintPhaseSelfOutline and
PaintPhaseChildOutlines -- to address this problem.

This patch also changes the name of PaintAction back to PaintPhase.
Because Hyatt said so.

5:13 PM Changeset in webkit [13591] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Clean-up style issues in node.h, remove redundant initializations.

kjs/nodes.h: (KJS::StatementNode::evaluate): (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::NewExprNode::NewExprNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncDeclNode::FuncDeclNode):

4:44 PM Changeset in webkit [13590] by tomernic

1 edit
3 adds in trunk/WebCore

Manual test case for the Java aspect of <rdar://problem/4212626> REGRESSION: LIVECONNECT:
JavaScript type for Java Strings is function, not object

manual-tests/java-string-object-type.html: Added.
manual-tests/resources/StringTypeTest.class: Added.
manual-tests/resources/StringTypeTest.java: Added.

4:15 PM Changeset in webkit [13589] by tomernic

9 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/4212626> REGRESSION: LIVECONNECT: JavaScript type for Java Strings is function,
not object

bindings/runtime.h: (KJS::Bindings::Instance::implementsCall): New method. Returns false by default. Concrete subclasses can override this return true when the bound object may be called as a function. (KJS::Bindings::Instance::invokeDefaultMethod): Since bound objects are no longer treated as functions by default, we can return jsUndefined() here instead of in concrete subclasses that decide not to implement the default method functionality.

bindings/runtime_object.cpp: (RuntimeObjectImp::implementsCall): Don't assume that the bound object is a function; instead, let the object instance decide whether it is callable.

bindings/c/c_instance.h:
bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::implementsCall): The object is callable if its class has an invokeDefault function.

bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::implementsCall): The object is callable if the ObjC instance responds to -invokeDefaultMethodWithArguments:.

bindings/jni/jni_instance.h:
bindings/jni/jni_instance.cpp: Moved bogus invokeDefaultMethod() to superclass.

4:13 PM Changeset in webkit [13588] by tomernic

1 edit
2 adds in trunk/LayoutTests

Reviewed by Geoff.

Test case for issues surrounding <rdar://problem/4212626> REGRESSION: LIVECONNECT:
JavaScript type for Java Strings is function, not object

Unfortunately, I can only test C and ObjC instances; Java does not run correctly
in DumpRenderTree.

plugins/bindings-test/bindings-test.html: Added.
plugins/bindings-test/bindings-test-expected.txt: Added.

3:48 PM Changeset in webkit [13587] by tomernic

5 edits in trunk/WebKitTools

Reviewed by NOBODY (just fixing copyrights)

DumpRenderTree/ObjCPlugin.h: Fixed copyright.
DumpRenderTree/ObjCPlugin.m: ditto
DumpRenderTree/ObjCPluginFunction.h: ditto
DumpRenderTree/ObjCPluginFunction.m: ditto

3:30 PM Changeset in webkit [13586] by tomernic

4 edits
4 adds in trunk/WebKitTools

Reviewed by Geoff.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): Add "objCPlugin", "objCPluginFunction" properties to the window. objCPlugin simulates an Objective C object exposed to JS; objCPluginFunction simulates an Objective C method exposed to JS as a callable object.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ObjCPlugin.[hm], ObjCPluginFunction.[hm].

DumpRenderTree/ObjCPlugin.h: Added.
DumpRenderTree/ObjCPlugin.m: Added.
DumpRenderTree/ObjCPluginFunction.h: Added.
DumpRenderTree/ObjCPluginFunction.m: Added.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added a new method, "removeDefaultMethod", which removes the default method from the plugin object's class. The effect is that the plugin object is mutated from a callable function to a simple object. (pluginInvoke): Handle "removeDefaultMethod". (pluginInvokeDefault): Made the default method actually do something (return 1).

2:16 PM Changeset in webkit [13585] by eseidel

4 edits in trunk/WebKitTools

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Remove WebFrame::viewImpl(), setMainFrame on page.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame):
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):

1:55 PM Changeset in webkit [13584] by eseidel

4 edits in trunk/WebKitTools

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix html editing input & basic form submission.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::submitForm): (WebKit::WebFrame::loadURL):
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):

1:44 PM Changeset in webkit [13583] by eseidel

6 edits in trunk/WebCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix text form controls, and add basic submit support!

bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
bridge/win/FrameWin.h:
platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

12:56 PM Changeset in webkit [13582] by adele

2 edits in trunk/WebCore

Reviewed by Justin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8083 REGRESSION: Repro crash when dragging to select over a new text field

editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): When searching for non-editable content, if the end of the selection is in a shadow tree, then we need to jump out of that first.

11:28 AM Changeset in webkit [13581] by justing

20 edits
6 adds in trunk

LayoutTests:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

fast/forms/plaintext-mode-1-expected.txt: Added.
fast/forms/plaintext-mode-1.html: Added.
fast/forms/plaintext-mode-2-expected.checksum: Added.
fast/forms/plaintext-mode-2-expected.png: Added.
fast/forms/plaintext-mode-2-expected.txt: Added.
fast/forms/plaintext-mode-2.html: Added.

WebCore:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionEditable]): (-[WebCoreFrameBridge isSelectionRichlyEditable]):
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
dom/Node.cpp: (WebCore::Node::isContentRichlyEditable):
dom/Node.h:
editing/EditCommand.cpp: (WebCore::EditCommand::apply):
editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::doApply):
editing/Selection.h: (WebCore::Selection::rootEditableElement): (WebCore::Selection::isContentEditable): (WebCore::Selection::isContentRichlyEditable):
editing/SelectionController.h: (WebCore::SelectionController::rootEditableElement): (WebCore::SelectionController::isContentEditable): (WebCore::SelectionController::isContentRichlyEditable):
html/HTMLElement.cpp: (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable): (WebCore::HTMLElement::setContentEditable):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle):
rendering/render_style.h: (WebCore::):

WebKit:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

WebView/WebHTMLView.m: (-[WebHTMLView _canEditRichly]): Added. (-[WebHTMLView _canIncreaseSelectionListLevel]): Use _canEditRichly (-[WebHTMLView _canDecreaseSelectionListLevel]): Ditto. (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]): (-[NSArray validateUserInterfaceItem:]): Split rich text editing actions off from ones that can be applied anywhere. (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _alignSelectionUsingCSSValue:withUndoAction:]):
WebView/WebHTMLViewPrivate.h:

11:21 AM Changeset in webkit [13580] by harrison

1 edit
12 adds in trunk/LayoutTests

Reviewed by Justin.

<rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

editing/deleting/delete-block-merge-contents-022-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-022-expected.png: Added.
editing/deleting/delete-block-merge-contents-022-expected.txt: Added.
editing/deleting/delete-block-merge-contents-022.html: Added.
editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-023-expected.png: Added.
editing/deleting/delete-block-merge-contents-023-expected.txt: Added.
editing/deleting/delete-block-merge-contents-023.html: Added.
editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-024-expected.png: Added.
editing/deleting/delete-block-merge-contents-024-expected.txt: Added.
editing/deleting/delete-block-merge-contents-024.html: Added.

11:20 AM Changeset in webkit [13579] by harrison

2 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Formatting. (WebCore::DeleteSelectionCommand::moveNodesAfterNode): Generalize check that preserves nesting when deleting to the beginning of an ancestor block.

editing/deleting/delete-block-merge-contents-022.html: Added.
editing/deleting/delete-block-merge-contents-023.html: Added.
editing/deleting/delete-block-merge-contents-024.html: Added.

10:40 AM Changeset in webkit [13578] by adele

3 edits
4 adds in trunk

LayoutTests:

Test: fast/forms/visual-hebrew-text-field.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8076 REGRESSION: native text fields are reversed on "visual Hebrew" pages

css/html4.css: Set the -kthml-rtl-ordering property to "logical" for all input elements. This should help also with future conversions from AppKit to native.

WebCore:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8076 REGRESSION: native text fields are reversed on "visual Hebrew" pages

fast/forms/visual-hebrew-text-field-expected.checksum: Added.
fast/forms/visual-hebrew-text-field-expected.png: Added.
fast/forms/visual-hebrew-text-field-expected.txt: Added.
fast/forms/visual-hebrew-text-field.html: Added.

9:35 AM Changeset in webkit [13577] by ap

3 edits
2 adds in trunk

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8051 Empty forms are submitted incorrectly

Test: fast/forms/empty-get.html

platform/KURL.cpp: (KURL::setQuery): Add a question mark for empty query strings, too.

2:55 AM Changeset in webkit [13576] by hyatt

1 edit in trunk/WebKitTools/Spinneret/Spinneret/WebView.cpp

Implement live scrolling on Win32.

2:53 AM Changeset in webkit [13575] by hyatt

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Add some ifdefed out paint flashing code for Win32 to the scroll view's updateContents method.

2:11 AM Changeset in webkit [13574] by hyatt

1 edit in trunk/WebCore/platform/String.cpp

Fix win32 sprintf method on string to not infinite loop. r=eric

2:02 AM Changeset in webkit [13573] by hyatt

2 edits in trunk/WebCore

Roll out the change to 7102.

1:23 AM Changeset in webkit [13572] by hyatt

8 edits in trunk/WebCore

Land support for JPEG image decoding on Win32.

Mar 29, 2006:

10:45 PM Changeset in webkit [13571] by justing

1 edit in trunk/WebCore/ChangeLog

Fixed a bug number.

10:38 PM Changeset in webkit [13570] by justing

15 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
REGRESSION: selectionRect includes next/previous replaced elements
<rdar://problems/4402375&4474871&4474871>

editing/selection/4402375-expected.checksum: Added.
editing/selection/4402375-expected.png: Added.
editing/selection/4402375-expected.txt: Added.
editing/selection/4402375.html: Added. Turned on dumpSelectionRect for these tests:
editing/selection/replaced-boundaries-1-expected.checksum:
editing/selection/replaced-boundaries-1-expected.png:
editing/selection/replaced-boundaries-1.html:
editing/selection/replaced-boundaries-2-expected.checksum:
editing/selection/replaced-boundaries-2-expected.png:
editing/selection/replaced-boundaries-2.html:
editing/selection/replaced-boundaries-3-expected.checksum:
editing/selection/replaced-boundaries-3-expected.png:
editing/selection/replaced-boundaries-3.html:
editing/selection/image-before-linebreak-expected.checksum: Added.
editing/selection/image-before-linebreak-expected.png: Added.
editing/selection/image-before-linebreak-expected.txt: Added.
editing/selection/image-before-linebreak.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
REGRESSION: selectionRect includes next/previous replaced elements
Also fixes: <rdar://problems/4402375&4474871&4474871>

In the case where a selection starts at the end or ends at the start
of o, o->selectionState() != SelectionNone, but o isn't really selected.
Constraining the selection with upstream and downstream eliminates these
types of endpoints, but constraining endpoints that occur at the
start or end of a paragraph creates positions inside containers - some
of which the selection painting code isn't equipped to handle.

dom/Document.cpp: (WebCore::Document::updateSelection):
rendering/render_replaced.cpp: (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::selectionRect): (WebCore::RenderReplaced::setSelectionState): (WebCore::RenderWidget::setSelectionState):

WebKitTools:

Reviewed by darin

<rdar://problem/4402375>
REGRESSION (417.8-TOT): selectionRect sometimes includes adjacent images

Added an option to draw the selectionRect.

DumpRenderTree/DumpRenderTree.m: (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpSelectionRect]): (dumpRenderTree):

10:16 PM Changeset in webkit [13569] by adele

3 edits in trunk/LayoutTests

Justin pointed out that this test should use an old-style form element,
so I changed the test to use <input type="password">.

fast/events/event-sender-mouse-click-expected.txt:
fast/events/event-sender-mouse-click.html:

6:39 PM Changeset in webkit [13568] by ggaren

20 edits in trunk

JavaScriptCore:

Reviewed by Darin.

JavaScriptCore side of fix for <rdar://problem/4308243> 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

The crash was a result of threaded deallocation of thread-unsafe
objects. Pure JS objects are thread-safe because all JS execution
is synchronized through JSLock. However, JS objects that wrap WebCore
objects are thread-unsafe because JS and WebCore execution are not
synchronized. That unsafety comes into play when the collector
deallocates a JS object that wraps a WebCore object, thus causing the
WebCore object to be deallocated.

The solution here is to have each JSCell know whether it is safe to
collect on a non-main thread, and to avoid collecting unsafe cells
when on a non-main thread.

We don't have a way to test PAC files yet, so there's no test
attached to this patch.

kjs/collector.cpp: (KJS::Collector::collect):

(1) Added the test "currentThreadIsMainThread

imp->m_destructorIsThreadSafe".

kjs/protect.h: (KJS::gcProtectNullTolerant): (KJS::gcUnprotectNullTolerant):
kjs/value.h: (KJS::JSCell::JSCell): The bools here must be bitfields, otherwise m_destructorIsThreadSafe becomes another whole word, ruining the collector optimizations we've made based on the size of a JSObject.
kxmlcore/FastMalloc.cpp: (KXMLCore::currentThreadIsMainThread): (KXMLCore::fastMallocRegisterThread):
kxmlcore/FastMalloc.h:

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986 Switch to use new text field implementation for <input type="text">

css/html4.css: Added default style info for new text fields.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla. (WebCore::RenderTextField::updateFromElement): Removed some outdated comments. Cleaned up the way we add text nodes to the div. (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange. (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred. (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border. (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css. We also add intrinsic margins here if the font size is large enough.
html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): ditto. (WebCore::HTMLInputElement::focus): ditto. (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::isMouseFocusable): Added. Old text fields relied on the widget to provide a focus policy. A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
html/HTMLInputElement.h: Added isMouseFocusable.
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable): Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

5:49 PM Changeset in webkit [13567] by adele

118 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated tests for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
Switch to use new text field implementation for <input type="text">

The new text field implementation uses RenderTextFielda instead of RenderLineEdits,
and this accounts for many of the changes here.

Also, background color and border properties are now dumped as part of the RenderTextField.

There is also an outstanding bug that affects many tests that make a selection in a text field.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8068
Editing delegate should not be notified when selection change involved new text field

Now that we support box-sizing, we count border and padding when calculating size, so some
of the tests that specify border size have different text field sizes.

editing/selection/3690703-2-expected.checksum:
editing/selection/3690703-2-expected.png:
editing/selection/3690703-2-expected.txt:
editing/selection/3690703-expected.checksum:
editing/selection/3690703-expected.png:
editing/selection/3690703-expected.txt:
editing/selection/3690719-expected.checksum:
editing/selection/3690719-expected.png:
editing/selection/3690719-expected.txt:
fast/block/float/032-expected.checksum:
fast/block/float/032-expected.png:
fast/block/float/032-expected.txt:
fast/block/margin-collapse/103-expected.txt:
fast/events/div-focus-expected.txt:
fast/events/event-sender-mouse-click-expected.txt:
fast/forms/access-key-expected.txt:
fast/forms/element-by-name-expected.txt:
fast/forms/focus-expected.txt:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/form-element-geometry-expected.txt:
fast/forms/indeterminate-expected.checksum:
fast/forms/indeterminate-expected.png:
fast/forms/input-appearance-bkcolor-expected.checksum:
fast/forms/input-appearance-bkcolor-expected.png:
fast/forms/input-appearance-bkcolor-expected.txt:
fast/forms/input-appearance-default-bkcolor-expected.checksum:
fast/forms/input-appearance-default-bkcolor-expected.png:
fast/forms/input-appearance-default-bkcolor-expected.txt:
fast/forms/input-appearance-disabled-expected.checksum:
fast/forms/input-appearance-disabled-expected.png:
fast/forms/input-appearance-disabled-expected.txt:
fast/forms/input-appearance-focus-expected.checksum:
fast/forms/input-appearance-focus-expected.png:
fast/forms/input-appearance-focus-expected.txt:
fast/forms/input-appearance-maxlength-expected.txt:
fast/forms/input-appearance-maxlength.html:
fast/forms/input-appearance-minWidth-expected.checksum:
fast/forms/input-appearance-minWidth-expected.png:
fast/forms/input-appearance-minWidth-expected.txt:
fast/forms/input-appearance-preventDefault-expected.checksum:
fast/forms/input-appearance-preventDefault-expected.png:
fast/forms/input-appearance-preventDefault-expected.txt:
fast/forms/input-appearance-selection-expected.checksum:
fast/forms/input-appearance-selection-expected.png:
fast/forms/input-appearance-selection-expected.txt:
fast/forms/input-appearance-visibility-expected.checksum:
fast/forms/input-appearance-visibility-expected.png:
fast/forms/input-appearance-visibility-expected.txt:
fast/forms/input-appearance-width-expected.checksum:
fast/forms/input-appearance-width-expected.png:
fast/forms/input-appearance-width-expected.txt:
fast/forms/input-baseline-expected.checksum:
fast/forms/input-baseline-expected.png:
fast/forms/input-baseline-expected.txt:
fast/forms/input-changing-value-expected.txt:
fast/forms/input-value-expected.txt:
fast/forms/input-width-expected.txt:
fast/forms/legend-access-key-expected.txt:
fast/forms/selection-functions-expected.txt:
fast/forms/textfield-focus-out-expected.txt:
fast/replaced/width100percent-expected.checksum:
fast/replaced/width100percent-expected.png:
fast/replaced/width100percent-expected.txt:
fast/table/003-expected.txt:
fast/table/colspanMinWidth-expected.txt:
fast/table/spanOverlapRepaint-expected.txt:
tables/mozilla/bugs/45621-expected.txt:
tables/mozilla/bugs/bug1188-expected.checksum:
tables/mozilla/bugs/bug1188-expected.png:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug12384-expected.checksum:
tables/mozilla/bugs/bug12384-expected.png:
tables/mozilla/bugs/bug12384-expected.txt:
tables/mozilla/bugs/bug18359-expected.checksum:
tables/mozilla/bugs/bug18359-expected.png:
tables/mozilla/bugs/bug18359-expected.txt:
tables/mozilla/bugs/bug24200-expected.txt:
tables/mozilla/bugs/bug2479-3-expected.txt:
tables/mozilla/bugs/bug2479-4-expected.txt:
tables/mozilla/bugs/bug28928-expected.txt:
tables/mozilla/bugs/bug4382-expected.txt:
tables/mozilla/bugs/bug4527-expected.txt:
tables/mozilla/bugs/bug46368-1-expected.txt:
tables/mozilla/bugs/bug46368-2-expected.txt:
tables/mozilla/bugs/bug51037-expected.txt:
tables/mozilla/bugs/bug55545-expected.checksum:
tables/mozilla/bugs/bug55545-expected.png:
tables/mozilla/bugs/bug55545-expected.txt:
tables/mozilla/bugs/bug59354-expected.txt:
tables/mozilla/bugs/bug7342-expected.checksum:
tables/mozilla/bugs/bug7342-expected.png:
tables/mozilla/bugs/bug7342-expected.txt:
tables/mozilla/bugs/bug96334-expected.checksum:
tables/mozilla/bugs/bug96334-expected.png:
tables/mozilla/bugs/bug96334-expected.txt:
tables/mozilla/bugs/bug99948-expected.txt:
tables/mozilla/dom/tableDom-expected.txt:
tables/mozilla/other/move_row-expected.txt:
tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
tables/mozilla_expected_failures/bugs/bug45621-expected.checksum:
tables/mozilla_expected_failures/bugs/bug45621-expected.png:
tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986 Switch to use new text field implementation for <input type="text">

css/html4.css: Added default style info for new text fields.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla. (WebCore::RenderTextField::updateFromElement): Removed some outdated comments. Cleaned up the way we add text nodes to the div. (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange. (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred. (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border. (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css. We also add intrinsic margins here if the font size is large enough.
html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): ditto. (WebCore::HTMLInputElement::focus): ditto. (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::isMouseFocusable): Added. Old text fields relied on the widget to provide a focus policy. A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
html/HTMLInputElement.h: Added isMouseFocusable.
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable): Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

3:47 PM Changeset in webkit [13566] by darin

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Eric.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8026 A particular animated SVG crashes in filter code <rdar://problem/4494775> A particular animated SVG crashes in filter code

svg/custom/empty-merge-expected.checksum: Added.
svg/custom/empty-merge-expected.png: Added.
svg/custom/empty-merge-expected.txt: Added.
svg/custom/empty-merge.svg: Added.

WebCore:

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8026 A particular animated SVG crashes in filter code <rdar://problem/4494775> A particular animated SVG crashes in filter code

fix some code that is not handling references correctly for GC

Test: svg/custom/empty-merge.svg

kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): Use KWQRetainNSRelease to properly retain a reference to an Objective-C object in a C++ class. (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): Use KWQRelease instead of release. (WebCore::KCanvasFilterQuartz::prepareFilter): Use KWQRetain instead of retain. (WebCore::KCanvasFilterQuartz::applyFilter): Use KWQRelease instead of release. (WebCore::KCanvasFilterQuartz::imageForName): Use objectForKey: instead of valueForKey: on the dictionary to sidestep a bug in valueForKey: on empty strings and because what we're doing with a dictionary here has nothing to do with key value encoding.

kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz): Use KWQRelease instead of release. (WebCore::KRenderingDeviceContextQuartz::nsGraphicsContext): Use KWQRetain instead of retain to properly retain a reference to an Objective-C object in a C++ class.

platform/mac/ImageMac.mm: (WebCore::Image::invalidateNativeData): Use CFRelease instead of release. (WebCore::Image::getNSImage): Use KWQRetainNSRelease to properly retain a reference to an Objective-C object in a C++ class.

3:42 PM Changeset in webkit [13565] by darin

2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

make the global initializer check work on Xcode 2.1 (although it's better on 2.2)

Scripts/check-for-global-initializers: Use NATIVE_ARCH if there is no CURRENT_ARCH.

2:13 PM Changeset in webkit [13564] by tomernic

2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4495316> REGRESSION (420+): After page has loaded, spinning progress indicator is displayed on
tab at versiontracker.com

WebView/WebFrame.m: (-[WebFrame _receivedMainResourceError:]): Call -_clientRedirectCancelledOrFinished: here so that the frame load delegate is notified that the redirect's status has changed, if there was a redirect. The frame load delegate may have saved some state about the redirect in its -webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:. Since we are definitely not going to use this provisional resource, as it was cancelled, notify the frame load delegate that the redirect has ended. The fix for 4432562 was similar to this, but only took care of the case where the redirect load was actually committed to the frame. The new call to -_clientRedirectCancelledOrFinished: handles the case where the redirect load was successful, but was not committed. This happens with downloads.

2:11 PM Changeset in webkit [13563] by ggaren

5 edits
2 adds in trunk

LayoutTests:

Layout test for <rdar://problem/4477126> TOT REGRESSION: with release build, maps.google.com zoom slider always zooms fully out

fast/events/mouseclick-target-and-positioning-expected.txt: Added.
fast/events/mouseclick-target-and-positioning.html: Added.

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/4477126> TOT REGRESSION: with release build, maps.google.com zoom slider always zooms fully out

There were 2 problems: (1) A syntax error in the UIEvent IDL file
prevented some things from showing up in the bindings; (2)
MouseEvent had a duplicate isSimulated property that shadowed
MouseRelatedEvent's isSimulated property, and MouseEvent failed to
initialize MouseRelatedEvent's isSimulated property.

dom/UIEvent.idl:
dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseEvent::MouseEvent):
dom/dom2_eventsimpl.h:

1:42 PM Changeset in webkit [13562] by tomernic

2 edits in trunk/WebCore

Reviewed by Darin.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): If the input type is dynamically changed, reevaluate whether the element maintains its state (this decision is based on the input's type). Fixes an assertion error when leaving a page with a text field that had been dynamically changed to a password field.

1:41 PM Changeset in webkit [13561] by sullivan

5 edits in trunk/WebKit

Reviewed by Tim Omernick.

fixed these bugs: <rdar://problem/4483806> REGRESSION (417.8-TOT): PDFs don't scale correctly with auto-size (5356) <rdar://problem/3874856> Safari PDF display should be full width by default rather than sized to show the entire page

WebView/WebPDFRepresentation.m: (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Let the WebPDFView handle setting the document, because that's the best time to apply the sizing-related preferences.

WebView/WebPDFView.h: eliminated firstLayoutDone ivar and -PDFSubview public method; added -setPDFDocument:

WebView/WebPDFView.m: (-[WebPDFView initWithFrame:]): eliminate use of obsolete firstLayoutDone ivar (-[WebPDFView _applyPDFDefaults]): renamed from _readPDFDefaults for clarity (-[WebPDFView layout]): removed code that applied the preferences here. This was too early to handle auto-sizing correctly, because -layout can be called before the document exists, and calling setAutoSize:YES at that point confuses PDFView into setting the scale factor to 20 (the maximum). (-[WebPDFView setPDFDocument:]): New method, does what WebPDFRepresentation used to do and also applies the preferences here. This is a good place to apply them because the document is guaranteed to now exist (of course). (-[WebPDFView PDFSubview]): Moved this into a new FileInternal category because it's still needed by another class in this file but no longer needs to be public.

WebView/WebPreferences.m: (+[WebPreferences initialize]): Change WebKitPDFScaleFactorPreferenceKey to 0, which represents auto-size. This fixes 3874856, but wasn't feasible until 4483806 was fixed.

9:37 AM Changeset in webkit [13560] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8055 Fix most CSS grammar conflicts.

Gets the number of shift/reduce and reduce/reduce conflicts down from 37+4 to 7+0.

I have fixed the reduce/reduce conflicts, then noticed that two of the fixes
were already made in KDE tree (the other two are different because declaration
blocks are described in quite different ways). Shift/reduce fixes are just
merged from KDE, r332845 by Michael Matz.

css/CSSGrammar.y:

7:57 AM Changeset in webkit [13559] by ap

3 edits
4 adds in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7157 An asterisk in a CSS property name breaks CSS handling (Many layout problems at letras.terra.com.br)

Test: fast/css/error-in-last-decl.html

css/CSSGrammar.y: Added a rule for the case when the last CSS rule has a syntax error, and doesn't end with a semicolon.

7:09 AM Changeset in webkit [13558] by darin

6 edits
1 add in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

Reviewed by Anders.

another cut at fixing the buildbot

generate-derived-sources: Fix if statement that was always following the Windows case. I believe this is the main problem.

WebCore.xcodeproj/project.pbxproj: Added CharsetData.h and added CharsetData.cpp to the target.
WebCore.vcproj/WebCore/WebCore.vcproj: Similar changes.

platform/CharsetData.h: Added.
platform/CharsetNames.cpp: Moved the actual character set data out into a separate source file instead of include a .cpp file.

platform/make-charset-table.pl: Changed to generate a file that can stand alone.

6:29 AM Changeset in webkit [13557] by darin

2 edits in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

an attempt to fix the buildbot

platform/mac/mac-encodings.txt: Touched this file so the character encodings files will be regenerated.

3:22 AM Changeset in webkit [13556] by darin

2 edits in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

a quick cut at fixing the windows build

WebCore.vcproj/WebCore/WebCore.vcproj: Added a few recently-added files.

1:38 AM Changeset in webkit [13555] by mjs

7 edits
3 adds in trunk

LayoutTests:

Reviewed by Anders.

Test cases for Element.contains, including testing fix for
<rdar://problem/4405353> JavaScript flickers popups onmouseover

fast/dom/Element/contains-method-expected.txt: Added.
fast/dom/Element/contains-method.html: Added.
fast/dom/Element/resources/contains-method.js: Added.
fast/events/capture-on-target.html:

WebCore:

Reviewed by Anders.

fixed <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating

Also fixed other issues with contains. The problem that caused the bug was:

contains should return true for the element itself, unlike isAncestor

Other problems I fixed:

contains shouldn't be present on non-Element nodes
contains should return false when passed a non-Element node
contains should return false when passed a non-Node

bindings/scripts/CodeGeneratorJS.pm: Handle Element as a parameter.
dom/Element.cpp: (WebCore::Element::contains): Added new implementation.
dom/Element.h: Added prototype for contains.
dom/Element.idl: Added IDL declaration for contains.
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction): Added old wrong contains().

Mar 28, 2006:

9:11 PM Changeset in webkit [13554] by bdakin

1 edit in trunk/WebCore/ChangeLog

Fixing typo from last commit.

9:07 PM Changeset in webkit [13553] by bdakin

7 edits
4 adds in trunk

Reviewed by Maciej

Fix for <rdar://problem/4493218> repro crash in
khtml::RenderBlock::repaintFloatingDescendants with giant
cellspacing value

Some callers of CSSPrimitiveValue::computeLength() expect an int,
and others a short. This patch splits computerLength() into
computeIntLength() and computeShortLength() so that the appropriate
bounds can be checked.

8:23 PM Changeset in webkit [13552] by ap

3 edits
2 adds in trunk

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4616 Setting nodeValue on a textnode with collapsed whitespace only has no visual effect

Test: fast/dom/space-to-text.html

dom/CharacterData.cpp: (WebCore::CharacterData::setData): Create a renderer if it's needed, but missing. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::replaceData): Ditto.

7:02 PM Changeset in webkit [13551] by tomernic

2 edits
2 adds in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
to another page while selecting inside textarea inside iframe

kwq/WebCoreTextArea.mm: (-[WebCoreTextArea mouseDown:]): Guard super's -mouseDown: with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(). Other widgets do this to protect against being removed from the page and deallocated while handling mouse down events. (-[WebCoreTextView mouseDown:]): ditto

manual-tests/textarea-iframe-navigation.html: Added.
manual-tests/textarea-iframe-navigation2.html: Added. Manual test case for this fix.

6:48 PM Changeset in webkit [13550] by eseidel

2 edits in trunk/WebCore

2006-03-28 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4402170> CrashTracer: 499 crashes in Safari at com.apple.WebCore: DOM::DocumentImpl::open + 16

dom/Document.cpp: (WebCore::Document::write): Fix unreproducible infinite recursion.

6:46 PM Changeset in webkit [13549] by eseidel

8 edits in trunk

2006-03-28 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove global initializers.

kcanvas/device/quartz/KCanvasFilterQuartz.mm:
ksvg2/svg/SVGAngle.cpp:
ksvg2/svg/SVGColor.cpp:
ksvg2/svg/SVGLength.cpp:

6:35 PM Changeset in webkit [13548] by eseidel

15 edits
3 adds in trunk

2006-03-28 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Switch UIEvent, MouseEvent and KeyboardEvent over to
be new auto-generated bindings.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7928

Updated test: fast/dom/prototype-chain.html

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMEvents.mm: (-[DOMEvent ::]): (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
bindings/scripts/CodeGeneratorJS.pm:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
dom/KeyboardEvent.idl: Added.
dom/MouseEvent.idl: Added.
dom/UIEvent.idl: Added.
dom/WheelEvent.idl:
dom/dom2_eventsimpl.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent):
dom/dom2_eventsimpl.h: (WebCore::MouseEvent::relatedTarget): (WebCore::MouseEvent::clipboard):
generate-derived-sources:
khtml/ecma/kjs_dom.cpp: (KJS::toEventTargetNode):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::toJS):
khtml/ecma/kjs_events.h:

6:23 PM Changeset in webkit [13547] by darin

9 edits in trunk/WebCore

Reviewed by Eric.

replace getDocument with document in a few places that Geoff missed

WebCore.xcodeproj/project.pbxproj:
dom/Attr.cpp: (WebCore::Attr::createTextChild): (WebCore::Attr::setValue): (WebCore::Attr::cloneNode):
dom/Attribute.cpp: (WebCore::Attribute::createAttrIfNeeded):
dom/Element.cpp: (WebCore::Element::cloneNode): (WebCore::inHTMLDocument): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::createStyleForRenderer): (WebCore::Element::createRenderer): (WebCore::Element::recalcStyle): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::updateId): (WebCore::Element::removeAttributeNode): (WebCore::Element::focus): (WebCore::Element::blur):
dom/NamedAttrMap.cpp: (WebCore::inHTMLDocument): (WebCore::NamedAttrMap::setNamedItem):
dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::parseClassAttribute):
dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::parseMappedAttribute): (WebCore::StyledElement::createMappedDecl):

added missing include that seems to be breaking the Windows build

platform/String.cpp: Include <stdarg.h>.

6:10 PM Changeset in webkit [13546] by eseidel

3 edits in trunk/LayoutTests

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Make plug-ins test dump as test.

fast/dom/Window/Plug-ins-expected.txt:
fast/dom/Window/Plug-ins.html:

6:01 PM Changeset in webkit [13545] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Darin.

Exit gracefully if $ENV{'CURRENT_ARCH'} is undefined. Rolling out my previous change.

Scripts/check-for-global-initializers:

5:50 PM Changeset in webkit [13544] by thatcher

2 edits in trunk/WebKitTools

Build fix. Turn off uninitialized warnings for the first block of code.

Scripts/check-for-global-initializers:

4:21 PM Changeset in webkit [13543] by ggaren

94 edits in trunk/WebCore

Reviewed by Beth.

Global replace of getDocument() with document(). Darin suggested this in his review of my EventTargetNode patch. It matches the style of methods like ownerDocument().

Changed getDocument() to document(); changed data member document to m_document; changed stack variable document to doc.

bindings/objc/DOM.mm: (-[DOMNode ownerDocument]): (-[DOMNode KJS::Bindings::]): (-[DOMElement _getURLAttribute:]):
bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): (-[DOMHTMLInputElement altDisplayString]): (-[DOMHTMLAnchorElement blur]): (-[DOMHTMLAnchorElement focus]): (-[DOMHTMLImageElement altDisplayString]): (-[DOMHTMLAppletElement altDisplayString]): (-[DOMHTMLAreaElement altDisplayString]):
bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateDashboardRegions):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithRenderer:]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/css_base.cpp: (WebCore::StyleBase::baseURL):
css/css_stylesheetimpl.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement): (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
dom/AbstractView.cpp: (WebCore::AbstractView::AbstractView):
dom/CDATASection.cpp: (WebCore::CDATASection::cloneNode): (WebCore::CDATASection::createNew):
dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::dispatchModifiedEvent):
dom/Comment.cpp: (WebCore::Comment::cloneNode):
dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createDocumentFragment): (WebCore::Document::adoptNode): (WebCore::Document::createElementNS): (WebCore::Document::nodeAbsIndex): (WebCore::Document::setFocusNode): (WebCore::Document::topDocument):
dom/DocumentFragment.cpp: (WebCore::DocumentFragment::cloneNode):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::~EventTargetNode): (WebCore::EventTargetNode::insertedIntoDocument): (WebCore::EventTargetNode::removedFromDocument): (WebCore::EventTargetNode::addEventListener): (WebCore::EventTargetNode::removeEventListener): (WebCore::EventTargetNode::dispatchGenericEvent): (WebCore::EventTargetNode::dispatchEvent): (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::removeHTMLEventListener):
dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setDocument): (WebCore::Node::setChanged): (WebCore::Node::checkSetPrefix): (WebCore::Node::checkAddChild): (WebCore::Node::attach): (WebCore::Node::detach): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::rendererIsNeeded): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::ownerDocument): (WebCore::Node::setTextContent):
dom/Node.h: (WebCore::Node::document): (WebCore::Node::inDocument):
dom/NodeList.cpp: (WebCore::NodeList::itemById):
dom/Position.cpp: (WebCore::Position::documentElement):
dom/Range.cpp: (WebCore::Range::commonAncestorContainer): (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::insertNode): (WebCore::Range::text): (WebCore::Range::setStartAfter): (WebCore::Range::setEndBefore): (WebCore::Range::setEndAfter): (WebCore::Range::surroundContents): (WebCore::Range::setStartBefore): (WebCore::rangeOfContents):
dom/Text.cpp: (WebCore::Text::cloneNode): (WebCore::Text::createNew):
dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
dom/dom2_traversalimpl.cpp: (WebCore::NodeIterator::NodeIterator):
dom/dom_elementimpl.cpp: (WebCore::Attribute::createAttrIfNeeded): (WebCore::Attr::createTextChild): (WebCore::Attr::setValue): (WebCore::Attr::cloneNode): (WebCore::Element::cloneNode): (WebCore::inHTMLDocument): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::createStyleForRenderer): (WebCore::Element::createRenderer): (WebCore::Element::recalcStyle): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::updateId): (WebCore::Element::removeAttributeNode): (WebCore::Element::focus): (WebCore::Element::blur): (WebCore::NamedAttrMap::setNamedItem): (WebCore::NamedMappedAttrMap::parseClassAttribute): (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::parseMappedAttribute): (WebCore::StyledElement::createMappedDecl):
dom/dom_xmlimpl.cpp: (WebCore::EntityReference::cloneNode): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::sheetLoaded): (WebCore::ProcessingInstruction::setStyleSheet):
dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode):
editing/Selection.cpp: (WebCore::Selection::toRange):
editing/SelectionController.cpp: (WebCore::SelectionController::~SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): (WebCore::SelectionController::frame): (WebCore::SelectionController::layout): (WebCore::SelectionController::needsCaretRepaint):
editing/TextIterator.cpp: (WebCore::TextIterator::range): (WebCore::SimplifiedBackwardsTextIterator::range):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): (WebCore::makeRange):
editing/markup.cpp: (WebCore::startMarkup): (WebCore::shouldSelfClose): (WebCore::markup): (WebCore::createMarkup):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::inSameDocument):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::resetCollectionInfo):
html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::cloneNode): (WebCore::HTMLElement::innerText): (WebCore::HTMLElement::createContextualFragment): (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::setOuterText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable): (WebCore::HTMLElement::toString): (WebCore::HTMLElement::childAllowed): (WebCore::HTMLElement::setHTMLEventListener):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): (WebCore::HTMLFormElement::attach): (WebCore::HTMLFormElement::insertedIntoDocument): (WebCore::HTMLFormElement::removedFromDocument): (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement):
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::attach): (WebCore::HTMLGenericFormElement::insertedIntoTree): (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::src):
html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::appendFormData):
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::formElement):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text): (WebCore::HTMLOptionElement::setText):
html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::~HTMLSelectElement):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::setDefaultValue):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer):
html/html_baseimpl.cpp: (WebCore::HTMLBodyElement::createLinkDecl): (WebCore::HTMLBodyElement::mapToEntry): (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLFrameElement::isURLAllowed): (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::close): (WebCore::HTMLFrameElement::contentFrame): (WebCore::HTMLFrameElement::frameWidth): (WebCore::HTMLFrameElement::frameHeight): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach): (WebCore::HTMLIFrameElement::src):
html/html_blockimpl.cpp: (WebCore::HTMLParagraphElement::checkDTD):
html/html_headimpl.cpp: (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet): (WebCore::HTMLLinkElement::sheetLoaded): (WebCore::HTMLLinkElement::href): (WebCore::HTMLMetaElement::process): (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::evaluateScript): (WebCore::HTMLScriptElement::setText): (WebCore::HTMLScriptElement::src): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded): (WebCore::HTMLTitleElement::insertedIntoDocument): (WebCore::HTMLTitleElement::removedFromDocument): (WebCore::HTMLTitleElement::childrenChanged): (WebCore::HTMLTitleElement::setText):
html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::insertedIntoDocument): (WebCore::HTMLImageElement::removedFromDocument): (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::src): (WebCore::HTMLMapElement::~HTMLMapElement): (WebCore::HTMLMapElement::parseMappedAttribute): (WebCore::HTMLAreaElement::href):
html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::href): (WebCore::HTMLAnchorElement::blur): (WebCore::HTMLAnchorElement::focus):
html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::insertedIntoDocument): (WebCore::HTMLAppletElement::removedFromDocument): (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::getAppletInstance): (WebCore::HTMLEmbedElement::getEmbedInstance): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::rendererIsNeeded): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLObjectElement::getObjectInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::updateDocNamedItem): (WebCore::HTMLParamElement::parseMappedAttribute):
html/html_tableimpl.cpp: (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTablePartElement::mapToEntry): (WebCore::HTMLTablePartElement::parseMappedAttribute): (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableRowElement::insertCell):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): (KJS::DOMNode::mark): (KJS::DOMElement::getValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity): (KJS::toJS):
khtml/ecma/kjs_html.cpp: (KJS::JSHTMLElement::implementsCall): (KJS::JSHTMLElement::bodyGetter): (KJS::JSHTMLElement::anchorGetter): (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::bodySetter):
khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/xbl/xbl_binding.cpp: (XBL::XBLBindingChain::failed): (XBL::m_nextBinding): (XBL::XBLBinding::setXBLDocument):
khtml/xbl/xbl_protobinding.cpp: (XBL::XBLPrototypeBinding::document):
khtml/xsl/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
khtml/xsl/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::xmlDocPtrFromNode): (WebCore::XSLTProcessor::transformToString):
ksvg2/svg/SVGAElement.cpp: (SVGAElement::defaultEventHandler):
ksvg2/svg/SVGAnimateColorElement.cpp: (SVGAnimateColorElement::handleTimerEvent):
ksvg2/svg/SVGAnimateElement.cpp: (SVGAnimateElement::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElement.cpp: (SVGAnimateTransformElement::handleTimerEvent):
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer):
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::addSVGWindowEventListner):
ksvg2/svg/SVGSetElement.cpp: (SVGSetElement::handleTimerEvent):
ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::canvas):
ksvg2/svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::closeRenderer): (WebCore::SVGTitleElement::insertedIntoDocument): (WebCore::SVGTitleElement::removedFromDocument): (WebCore::SVGTitleElement::childrenChanged):
ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]): (-[WebCoreAXObject accessibilityAttributeValue:]):
page/Frame.cpp: (WebCore::parentFromOwnerRenderer): (WebCore::Frame::frameForNode): (WebCore::Frame::clearDocumentFocus):
page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::RenderCanvas): (WebCore::RenderCanvas::paintBoxDecorations): (WebCore::RenderCanvas::repaintViewRectangle):
rendering/RenderImage.cpp: (WebCore::RenderImage::imageMap):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::backslashAsCurrencySymbol):
rendering/RenderObject.h: (WebCore::RenderObject::document):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused):
rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut):

4:11 PM Changeset in webkit [13542] by darin

6 edits in trunk

JavaScriptGlue:

Reviewed by Geoff.

added a build step that checks for init routines

JavaScriptGlue.xcodeproj/project.pbxproj: Added a custom build phase that invokes the check-for-global-initializers script.

WebCore:

Reviewed by Geoff.

added a build step that checks for init routines

WebCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that was replaced by the generate-derived-sources script a while back. Added a custom build phase that invokes the check-for-global-initializers script.

WebKit:

Reviewed by Geoff.

added a build step that checks for init routines

WebKit.xcodeproj/project.pbxproj: Added a custom build phase that invokes the check-for-global-initializers script.

4:09 PM Changeset in webkit [13541] by darin

5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

change some code that resulted in init routines on Mac OS X -- if the framework has init routines it will use memory and slow down applications that link with WebKit even in cases where those applications don't use WebKit

kjs/date_object.cpp: Changed constants that were derived by multiplying other constants to use immediate numbers instead. Apparently, double constant expressions of the type we had here are evaluated at load time.

kjs/list.cpp: Can't use OwnArrayPtr in ListImp because of the global instances of ListImp, so go back to using a plain old pointer. (KJS::List::List): Set overflow to 0 when initializing ListImp. (KJS::List::release): Replace a clear call with a delete and explicit set to 0. (KJS::List::append): Use raw pointers, and do a delete [] instead of finessing it with a swap of OwnArrayPtr. (KJS::List::copyFrom): Remove now-unneeded get(). (KJS::List::copyTail): Ditto.

kjs/ustring.cpp: Changed UString::Rep::empty initializer a bit so that it doesn't get a static initializer routine. Had to get rid of one level of constant to get the compiler to understand it could initialize without any code.

added a build step that checks for init routines

JavaScriptCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that was replaced by the generate-derived-sources script a while back. Added a custom build phase that invokes the check-for-global-initializers script.

4:03 PM Changeset in webkit [13540] by thatcher

5 copies in tags/Safari-521.9

New tag.

3:59 PM Changeset in webkit [13539] by darin

1 edit
1 add in trunk/WebKitTools

Reviewed by Geoff.

Scripts/check-for-global-initializers: Added.

3:58 PM Changeset in webkit [13538] by thatcher

1 delete in tags/Safari-521.9

Old tag that was never used. Will replace

3:52 PM Changeset in webkit [13537] by thatcher

2 edits in trunk/JavaScriptCore

Reviewed by Eric.

fixes <rdar://problem/4458539> Unable to include Security(public) and WebKit(private) headers

bindings/npapi.h: added #defines after the #ifndefs

3:37 PM Changeset in webkit [13536] by thatcher

3 edits in trunk/WebCore

Reviewed by Maciej.

Moved the derived sources script to an agregate target. Fixes internal builds.

WebCore.xcodeproj/project.pbxproj:
generate-derived-sources: was missing a use of $CREATE_HASH_TABLE

1:36 PM Changeset in webkit [13535] by eseidel

3 edits in trunk/WebCore

2006-03-28 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Build fix.

dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::error):

1:07 PM Changeset in webkit [13534] by tomernic

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView initWithFrame:]): Don't observe preferences changes here -- we only want to observe preferences while the view is installed in the view hierarchy. Plugins will appropriately start and stop themselves when added to or removed from a window. (-[WebBaseNetscapePluginView dealloc]): Don't remove observers here -- they should have been removed when the view was removed from its window. (-[WebBaseNetscapePluginView finalize]): ditto (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Stop observing preferences when the view is removed from its window. (-[WebBaseNetscapePluginView viewDidMoveToWindow]): Start observing preferences when the view is added to a window.

11:07 AM Changeset in webkit [13533] by darin

4 edits in trunk/WebCore

Reviewed, tweaked, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8023 Attribute.h missing class predeclaration

dom/Attribute.h: Add declarations for classes so that the friend declaration is not the only one. There's an issue with either an earlier or later version of gcc, which is why we see this only on certain platforms.

dom/Attr.cpp: (WebCore::Attr::Attr): (WebCore::Attr::~Attr):
dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::clearAttributes): (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute): Change places where practical to use attr() instead of m_impl in the vain hope of removing the need for the friend declarations.

10:34 AM Changeset in webkit [13532] by eseidel

50 edits in trunk/WebCore

2006-03-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
Add String::sprintf() and String::number()
http://bugzilla.opendarwin.org/show_bug.cgi?id=8009

bindings/objc/DOMHTML.mm: (-[DOMHTMLTextAreaElement setCols:]): (-[DOMHTMLTextAreaElement setRows:]): (-[DOMHTMLOListElement setStart:]): (-[DOMHTMLPreElement setWidth:]): (-[DOMHTMLImageElement setHeight:]): (-[DOMHTMLImageElement setHspace:]): (-[DOMHTMLImageElement setVspace:]): (-[DOMHTMLImageElement setWidth:]): (-[DOMHTMLObjectElement setHspace:]): (-[DOMHTMLObjectElement setTabIndex:]): (-[DOMHTMLObjectElement setVspace:]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAreaElement setTabIndex:]): (-[DOMHTMLTableColElement setSpan:]): (-[DOMHTMLTableCellElement setColSpan:]): (-[DOMHTMLTableCellElement setRowSpan:]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement setWidth:]):
bindings/objc/DOMInternal.mm: (String::String):
css/CSSComputedStyleDeclaration.cpp: (WebCore::numberAsString): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSPrimitiveValue::cssText):
dom/Position.cpp: (WebCore::Position::formatForDebugger):
dom/Range.cpp: (WebCore::Range::formatForDebugger):
dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::error):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::findMatchingState): (WebCore::HTMLGenericFormElement::setTabIndex):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setMaxLength): (WebCore::HTMLInputElement::setSize):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSize):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setCols): (WebCore::HTMLTextAreaElement::setRows):
html/html_baseimpl.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
html/html_blockimpl.cpp: (WebCore::HTMLHRElement::parseMappedAttribute): (WebCore::HTMLPreElement::setWidth):
html/html_imageimpl.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::setBorder): (WebCore::HTMLImageElement::setHeight): (WebCore::HTMLImageElement::setHspace): (WebCore::HTMLImageElement::setVspace): (WebCore::HTMLImageElement::setWidth): (WebCore::HTMLAreaElement::setTabIndex):
html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::setTabIndex):
html/html_listimpl.cpp: (WebCore::HTMLOListElement::setStart): (WebCore::HTMLLIElement::setValue):
html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setTabIndex):
html/html_tableimpl.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableCellElement::setColSpan): (WebCore::HTMLTableCellElement::setRowSpan): (WebCore::HTMLTableColElement::setSpan):
khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::Location::getValueProperty):
ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
ksvg2/svg/SVGAngle.cpp: (SVGAngle::setValueAsString): (SVGAngle::valueAsString):
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGLength.cpp: (SVGLength::setValueAsString): (SVGLength::valueAsString):
ksvg2/svg/SVGLength.h:
ksvg2/svg/SVGPathSeg.h: (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString):
ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::pathSegTypeAsLetter): (WebCore::SVGPathSegArcRel::toString):
ksvg2/svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter): (WebCore::SVGPathSegClosePath::toString):
ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicRel::toString):
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoRel::toString):
ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoVerticalRel::toString):
ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter): (WebCore::SVGPathSegMovetoRel::toString):
ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::notifyAttributeChange):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
platform/AtomicString.h: (WebCore::AtomicString::toInt):
platform/Color.cpp: (WebCore::Color::name):
platform/Color.h:
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::sprintf): (WebCore::String::number):
platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar): (WebCore::StringImpl::containsOnlyWhitespace):
platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
rendering/render_form.cpp: (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::valueChanged):

3:30 AM Changeset in webkit [13531] by justing

6 edits
8 adds in trunk

LayoutTests:

Reviewed by mjs

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7152>
REGRESSION: Select All does not highlight table if it's last in the document

editing/selection/7152-1-expected.checksum: Added.
editing/selection/7152-1-expected.png: Added.
editing/selection/7152-1-expected.txt: Added.
editing/selection/7152-1.html: Added.
editing/selection/7152-2-expected.checksum: Added.
editing/selection/7152-2-expected.png: Added.
editing/selection/7152-2-expected.txt: Added.
editing/selection/7152-2.html: Added.

WebCore:

Reviewed by mjs

<http://bugzilla.opendarwin.org/attachment.cgi?id=7322>
REGRESSION: Select All does not highlight table if it's last in the document

rendering/RenderCanvas.cpp: (WebCore::rendererAfterPosition): Added, returns the render object that a pre-order traversal over a range of render objects ending at the input position should stop at. (WebCore::RenderCanvas::selectionRect): Stop at rendererAfterPosition(m_selectionEnd, m_selectionEndPos), moved code for traversal to nextInPreOrder. Also, the travesal doesn't need to fetch the next object before doing work, since the work it does will never change what the next object in the traversal will be. (WebCore::RenderCanvas::setSelection): Ditto.
rendering/RenderObject.cpp: (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer, cleaned up the logic a little. (WebCore::RenderObject::nextInPreOrderAfterChildren): Added. (WebCore::RenderObject::previousInPreOrder): Renamed from previousRenderer. (WebCore::RenderObject::childAt): Added.
rendering/RenderObject.h:
rendering/RenderText.cpp: (WebCore::RenderText::setText):

2:37 AM Changeset in webkit [13530] by mjs

2 edits
1 add in trunk/WebCore

Reviewed by Justin.

fixed <rdar://problem/4483851> REGRESSION: parse mode gets set to strict after going back from non-HTML content (7102)

Reshuffled things to arrange for m_doc to be cleared somewhat earlier than before.

page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::endIfNotLoading):
manual-tests/accidental-strict-mode.html: Added. I don't think an automated test is possible.

1:33 AM Changeset in webkit [13529] by justing

3 adds in trunk/LayoutTests/editing/selection

Forgot to check in these results earlier today.

1:02 AM Changeset in webkit [13528] by eseidel

6 edits in trunk/WebCore

2006-03-28 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Convert a couple DeprecatedPtrList<T> to Vector<T*> and HashSet<T*>

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::regExpForLabels): (WebCore::FrameMac::addPluginRootObject): (WebCore::FrameMac::cleanupPluginRootObjects):
loader/Cache.cpp: (WebCore::Cache::init): (WebCore::Cache::clear): (WebCore::Cache::remove):
loader/Cache.h:
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader):

Mar 27, 2006:

10:32 PM Changeset in webkit [13527] by eseidel

14 edits in trunk/WebCore

2006-03-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Give StringImpl a little privacy.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

dom/CharacterData.cpp: (WebCore::CharacterData::length): (WebCore::CharacterData::appendData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::rendererIsNeeded):
dom/Range.cpp: (WebCore::Range::compareBoundaryPoints):
dom/Text.cpp: (WebCore::Text::splitText):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken):
platform/AtomicString.cpp: (WebCore::operator==):
platform/String.cpp: (WebCore::String::operator[]): (WebCore::String::length): (WebCore::String::percentage): (WebCore::String::unicode): (WebCore::String::deprecatedString): (WebCore::String::isEmpty):
platform/StringImpl.cpp: (WebCore::equal): (WebCore::equalIgnoringCase):
platform/StringImpl.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):

10:30 PM Changeset in webkit [13526] by mjs

5 edits
8 adds in trunk

LayoutTests:

Reviewed by Beth.

test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
fast/block/float/float-in-float-hit-testing-expected.png: Added.
fast/block/float/float-in-float-hit-testing-expected.txt: Added.
fast/block/float/float-in-float-hit-testing.html: Added.
fast/block/float/float-in-float-painting-expected.checksum: Added.
fast/block/float/float-in-float-painting-expected.png: Added.
fast/block/float/float-in-float-painting-expected.txt: Added.
fast/block/float/float-in-float-painting.html: Added.
fast/events/capture-on-target.html:

WebCore:

Reviewed by Beth.

fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

rendering/RenderBlock.cpp: (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects as well as their overflowRects.
platform/IntRect.h: (WebCore::unionRect): useful helper
platform/FloatRect.h: (WebCore::unionRect): added same for FloatRect just because

8:26 PM Changeset in webkit [13525] by tomernic

2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

ChangeLog:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Instead of calling -stop, assert that the plugin is not running. A plugin view cannot be deallocated until it is removed from its window. When a plugin view is removed from its window, it calls -stop on itself. Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the assertion will help catch any edge cases. (-[WebBaseNetscapePluginView finalize]): ditto

8:15 PM Changeset in webkit [13524] by tomernic

2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that the stream file path either never existed, or was deleted and NULL-ed out. The stream file is now deleted immediately after calling NPP_StreamAsFile(). (-[WebBaseNetscapePluginStream finalize]): ditto (-[WebBaseNetscapePluginStream _destroyStream]): Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize. It should be OK to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream() (the stream destruction function), so there can be no expectation that a plugin will read the stream file asynchronously after NPP_StreamAsFile() is called.

8:13 PM Changeset in webkit [13523] by tomernic

3 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it. Currently
the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
handling JavaScript's navigator.plugins.refresh().

Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that the plug-in has been unloaded by the time -dealloc is called. (-[WebBasePluginPackage finalize]): ditto

Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -unload on the plug-in packages before releasing them.

5:07 PM Changeset in webkit [13522] by darin

2 edits in trunk/WebCore

Based on a patch by Michael Emmel <mike.emmel@gmail.com>.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8012 TransferJob.cpp includes non-existent "String.h" (capital S)

platform/TransferJob.cpp: Remove unneeded include of "String.h".

4:57 PM Changeset in webkit [13521] by harrison

1 edit
8 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

editing/deleting/delete-block-merge-contents-022.html: Added.
editing/deleting/delete-block-merge-contents-023.html: Added.
editing/selection/selectNode-expected.checksum: Added.
editing/selection/selectNode-expected.png: Added.
editing/selection/selectNode-expected.txt: Added.
editing/selection/selectNode.html: Added.
editing/selection/selectNodeContents-expected.checksum: Added.
editing/selection/selectNodeContents-expected.png: Added.
editing/selection/selectNodeContents-expected.txt: Added.
editing/selection/selectNodeContents.html: Added.

4:54 PM Changeset in webkit [13520] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Better fix than previous checkin, since maxDeepOffset is really an editing hack.

editing/selection/selectNodeContents-textNode.html: Added.

dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxOffset if offsetInCharacters, otherwise use childNodeCount.

4:07 PM Changeset in webkit [13519] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebKit

Release tag for Mac OS X Update 10.4.3.

4:07 PM Changeset in webkit [13518] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebCore

Release tag for Mac OS X Update 10.4.3.

4:05 PM Changeset in webkit [13517] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/JavaScriptCore

Release tag for Mac OS X Update 10.4.3.

3:34 PM Changeset in webkit [13516] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13515] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebKit

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13514] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptGlue

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13513] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13512] by thatcher

2 adds in releases/Apple/Tiger

New release directories.

3:29 PM Changeset in webkit [13511] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebKit

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13510] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebCore

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13509] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptGlue

Release tag for Mac OS X Update 10.4.5.

3:28 PM Changeset in webkit [13508] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptCore

Release tag for Mac OS X Update 10.4.5.

3:24 PM Changeset in webkit [13507] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-001/WebKit

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13506] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-001/WebCore

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13505] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptGlue

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13504] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptCore

Release tag for Security Update 2006-001.

3:15 PM Changeset in webkit [13503] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-002/WebKit

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13502] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-002/WebCore

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13501] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptGlue

Release tag for Security Update 2006-002.

3:14 PM Changeset in webkit [13500] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptCore

Release tag for Security Update 2006-002.

3:01 PM Changeset in webkit [13499] by thatcher

5 adds in releases/Apple

New release directories. Will do server copies for the actual files.

2:21 PM Changeset in webkit [13498] by darin

2 edits in trunk/WebCore

At the request of Michael Emmel <mike.emmel@gmail.com>.

fix compilation for Linux http://bugzilla.opendarwin.org/show_bug.cgi?id=8013

rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked

formatting a bit and removed some extraneous WebCore: prefixes.

2:09 PM Changeset in webkit [13497] by thatcher

1 add in releases

New releases folder to hold tags of all WebKit versions released to the public. Reviewed by Darin.

2:07 PM Changeset in webkit [13496] by tomernic

3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
WebKit and WebBrowser

Carbon/HIViewAdapter.h: HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): Replace individual NSView methods instead of posing as NSView. (_webkit_NSView_setNeedsDisplay): Replacement implementation of -[NSView setNeedsDisplay:]. (_webkit_NSView_setNeedsDisplayInRect): Replacement implementation of -[NSView setNeedsDisplayInRect:] (_webkit_NSView_nextValidKeyView): Replacement implementation of -[NSView nextValidKeyView]

1:44 PM Changeset in webkit [13495] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin Adler and Tim Omernick

fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly confirmed while typing on Safari.

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _displayedValue]): Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but for now it fixes this regression.

1:33 PM Changeset in webkit [13494] by sullivan

3 edits in trunk/WebKit

Reviewed by Darin Adler.

Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
Improved comments to match.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.

WebView/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assertion that the frame should never be the main frame here.

1:20 PM Changeset in webkit [13493] by tomernic

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Removed tabs & reformatted code.

Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): (+[NSView getHIViewForNSView:]): (+[NSView unbindNSView:]): (-[NSView setNeedsDisplay:]): (-[NSView setNeedsDisplayInRect:]): (-[NSView nextValidKeyView]): (SetViewNeedsDisplay):

1:10 PM Changeset in webkit [13492] by lypanov

6 edits
2 adds in trunk

2006-03-27 Alexander Kellett <lypanov@kde.org>

Reviewed by darin

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6520 the IE extension insertAdjacentElement

fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27 Alexander Kellett <lypanov@kde.org>

Reviewed by darin

Implement the IE extension insertAdjacentElement
http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

bindings/scripts/CodeGeneratorJS.pm:
dom/Element.cpp: (WebCore::ElementImpl::insertAdjacentElement):
dom/Element.h:
dom/Element.idl:

9:34 AM Changeset in webkit [13491] by justing

1 edit
1 add in trunk/LayoutTests

Reviewed by beth and geoff

editing/selection/6476-expected.checksum: Added.
editing/selection/6476-expected.png: Added.
editing/selection/6476-expected.txt: Added.
editing/selection/6476.html: Added.

8:23 AM Changeset in webkit [13490] by harrison

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
nodes. Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
selectNodeContents on a text node.

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxDeepOffset instead of childNodeCount, so that text node content is selected.

5:17 AM Changeset in webkit [13489] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page

fast/css/outline-auto-empty-rects-expected.checksum: Added.
fast/css/outline-auto-empty-rects-expected.png: Added.
fast/css/outline-auto-empty-rects-expected.txt: Added.
fast/css/outline-auto-empty-rects.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page

platform/GraphicsContext.cpp: (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.

3:29 AM Changeset in webkit [13488] by mjs

3 edits
1 add in trunk

JavaScriptCore:

Reviewed by Anders.

fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

kjs/nodes.cpp: (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

Reviewed by Anders.

fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

manual-tests/empty-script-crash.html: Added.

1:32 AM Changeset in webkit [13487] by mjs

2 edits in trunk/WebCore

Build fix:

reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node It turns out that the behavior we had was standards-compliant and Moz will be changing to match.

Also added a note so this doesn't get reverted again.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):

12:34 AM Changeset in webkit [13486] by justing

8 edits in trunk

WebCore:

Reviewed by darn

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

bridge/mac/WebCoreFrameBridge.h:
editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::editingAction):
editing/EditAction.h:
editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):

WebKit:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

English.lproj/Localizable.strings:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):

Mar 26, 2006:

7:29 PM Changeset in webkit [13485] by eseidel

5 edits in trunk/WebCore

2006-03-26 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.

WebCore.vcproj/WebCore/WebCore.vcproj:
editing/CompositeEditCommand.cpp:
editing/InsertTextCommand.cpp:
generate-derived-sources:

5:30 PM Changeset in webkit [13484] by eseidel

2 edits in trunk/WebCore

2006-03-26 Eric Seidel <eseidel@apple.com>

dom/Element.cpp: fix include case, fixing build.

2:58 PM Changeset in webkit [13483] by eseidel

9 edits
1 add in trunk/WebCore

2006-03-25 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7916 Box repaint rect does not include the left overflow

manual-tests/left-overflow-repaint.html: Added.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
rendering/RenderBox.cpp: (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
rendering/RenderTableCell.cpp: Removed subclass implementation of getAbsoluteRepaintRect().
rendering/RenderTableCell.h:
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

Mar 25, 2006:

3:52 PM Changeset in webkit [13482] by eseidel

2 edits in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Build fix.

bindings/scripts/CodeGeneratorJS.pm: include Element.h

2:24 PM Changeset in webkit [13481] by eseidel

3 edits in trunk/WebKitTools

2006-03-24 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7947 Add repaint testing support to run-webkit-tests

DumpRenderTree/DumpRenderTree.m: (main): Added --repaint and --horizontal-sweep options. (dump): Repaint line-by-line or column-by-column when the appropriate option is selected. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint() and repaintSweepHorizontally() methods to layoutTestController. (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (dumpRenderTree):
Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options to force these settings on tests that do not ask for them.

2:20 PM Changeset in webkit [13480] by eseidel

111 edits
15 copies
2 moves
3 deletes in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Split dom_elementimpl.* into multiple files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

ForwardingHeaders/kdom/core/Attr.h: Removed.
ForwardingHeaders/kdom/core/Element.h: Removed.
ForwardingHeaders/kdom/core/XMLElement.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMHTML.mm:
bindings/scripts/CodeGeneratorJS.pm:
dom/AbstractView.cpp:
dom/Attr.cpp: Added.
dom/Attr.h: Added.
dom/Attribute.cpp: Added.
dom/Attribute.h: Added.
dom/CSSMappedAttributeDeclaration.cpp: Added.
dom/CSSMappedAttributeDeclaration.h: Added.
dom/DOMImplementation.cpp:
dom/Document.h:
dom/DocumentType.cpp:
dom/Element.cpp: Added. (WebCore::Element::Element): (WebCore::Element::~Element):
dom/Element.h: Added.
dom/EventNames.cpp:
dom/EventTargetNode.cpp:
dom/MappedAttribute.cpp: Added.
dom/MappedAttribute.h: Added.
dom/MappedAttributeEntry.h: Added. (WebCore::):
dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
dom/NamedAttrMap.cpp: Added.
dom/NamedAttrMap.h: Added.
dom/NamedMappedAttrMap.cpp: Added. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
dom/NamedMappedAttrMap.h: Added.
dom/Node.cpp:
dom/NodeList.cpp:
dom/Position.cpp:
dom/StyledElement.cpp: Added.
dom/StyledElement.h: Added.
dom/dom_elementimpl.cpp: Removed.
dom/dom_elementimpl.h: Removed.
editing/BreakBlockquoteCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/DeleteSelectionCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/InsertTextCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/ModifySelectionListLevelCommand.cpp:
editing/MoveSelectionCommand.cpp:
editing/RemoveCSSPropertyCommand.cpp:
editing/RemoveNodeAttributeCommand.cpp:
editing/Selection.cpp:
editing/SelectionController.cpp:
editing/SetNodeAttributeCommand.cpp:
editing/SplitElementCommand.cpp:
editing/SplitTextNodeContainingElementCommand.cpp:
editing/TextIterator.cpp:
editing/TypingCommand.cpp:
editing/VisiblePosition.cpp:
editing/visible_units.cpp:
html/HTMLElement.h:
html/HTMLTokenizer.h:
html/html_baseimpl.cpp:
kcanvas/RenderSVGImage.cpp:
khtml/ecma/kjs_views.cpp:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
khtml/xbl/xbl_binding_manager.cpp:
khtml/xbl/xbl_tokenizer.cpp:
ksvg2/misc/SVGImageLoader.cpp:
ksvg2/svg/SVGAElement.cpp:
ksvg2/svg/SVGAnimateTransformElement.cpp:
ksvg2/svg/SVGAnimationElement.cpp:
ksvg2/svg/SVGCircleElement.cpp:
ksvg2/svg/SVGClipPathElement.cpp:
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGCursorElement.cpp:
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement):
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGEllipseElement.cpp:
ksvg2/svg/SVGExternalResourcesRequired.cpp:
ksvg2/svg/SVGFEBlendElement.cpp:
ksvg2/svg/SVGFEColorMatrixElement.cpp:
ksvg2/svg/SVGFEComponentTransferElement.cpp:
ksvg2/svg/SVGFECompositeElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
ksvg2/svg/SVGFEDisplacementMapElement.cpp:
ksvg2/svg/SVGFEFloodElement.cpp:
ksvg2/svg/SVGFEGaussianBlurElement.cpp:
ksvg2/svg/SVGFEImageElement.cpp:
ksvg2/svg/SVGFELightElement.cpp:
ksvg2/svg/SVGFEMergeElement.cpp:
ksvg2/svg/SVGFEMergeNodeElement.cpp:
ksvg2/svg/SVGFEOffsetElement.cpp:
ksvg2/svg/SVGFESpecularLightingElement.cpp:
ksvg2/svg/SVGFETileElement.cpp:
ksvg2/svg/SVGFETurbulenceElement.cpp:
ksvg2/svg/SVGFilterElement.cpp:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
ksvg2/svg/SVGFitToViewBox.cpp:
ksvg2/svg/SVGGradientElement.cpp:
ksvg2/svg/SVGImageElement.cpp:
ksvg2/svg/SVGLangSpace.cpp:
ksvg2/svg/SVGLineElement.cpp:
ksvg2/svg/SVGLinearGradientElement.cpp:
ksvg2/svg/SVGMarkerElement.cpp:
ksvg2/svg/SVGMaskElement.cpp:
ksvg2/svg/SVGPathElement.cpp:
ksvg2/svg/SVGPatternElement.cpp:
ksvg2/svg/SVGPolyElement.cpp:
ksvg2/svg/SVGRadialGradientElement.cpp:
ksvg2/svg/SVGRectElement.cpp:
ksvg2/svg/SVGSVGElement.cpp:
ksvg2/svg/SVGScriptElement.cpp:
ksvg2/svg/SVGStopElement.cpp:
ksvg2/svg/SVGStyledElement.cpp:
ksvg2/svg/SVGStyledTransformableElement.cpp:
ksvg2/svg/SVGSwitchElement.cpp:
ksvg2/svg/SVGTests.cpp:
ksvg2/svg/SVGTextContentElement.cpp:
ksvg2/svg/SVGTextPositioningElement.cpp:
ksvg2/svg/SVGTransformable.cpp:
ksvg2/svg/SVGURIReference.cpp:
ksvg2/svg/SVGUseElement.cpp:
ksvg2/svg/SVGViewElement.cpp:
ksvg2/svg/SVGZoomAndPan.cpp:
kwq/WebCoreTextArea.mm:
platform/Widget.h:
rendering/RenderBlock.cpp:
rendering/RenderCanvas.cpp:
rendering/RenderContainer.cpp:
rendering/RenderObject.cpp:
rendering/RenderTextField.cpp:
rendering/RenderThemeMac.mm:
rendering/bidi.cpp:
rendering/render_replaced.cpp:

3:22 AM Changeset in webkit [13479] by eseidel

11 edits in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix RenderStyle creation to avoid floating RenderStyle objects.
This also fixes a bug, were SVG to ever start sharing RenderStyles
between elements, code would have crashed as there were improperly
paired style->deref() statements in SVG code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

No test possible (no functionality change).

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
css/cssstyleselector.h:
dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::createStyleForRenderer):
dom/Node.h:
dom/dom_elementimpl.cpp: (WebCore::Element::createStyleForRenderer): (WebCore::Element::recalcStyle):
dom/dom_elementimpl.h:
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::selectStartNode): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::getPseudoStyle):

2:46 AM Changeset in webkit [13478] by eseidel

3 edits
2 adds in trunk

2006-03-23 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Shave .2% on PLT by removing bogus strcmp.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

Test: fast/parser/tag-with-exclamation-point.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp

2:17 AM Changeset in webkit [13477] by justing

16 edits
4 adds
2 deletes in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

editing/editing.js:
editing/execCommand/createLink-expected.checksum: Removed.
editing/execCommand/createLink-expected.png: Removed.
editing/execCommand/createLink-expected.txt:
editing/execCommand/createLink.html:
editing/execCommand/unlink-expected.txt: Added.
editing/execCommand/unlink.html: Added.

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

Added code to push partially selected anchor elements down before
creating or removing links to create fully selected chunks that can be removed.
Changed create_link_command_h to CreateLinkCommand_h
Gave styled element application/removal its own ApplyStyleCommand constructor.
Still need to add new EditActions (7974).

WebCore.xcodeproj/project.pbxproj:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
editing/ApplyStyleCommand.h:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::enclosingAnchorElement): (WebCore::CompositeEditCommand::pushAnchorElementDown): (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
editing/CompositeEditCommand.h:
editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
editing/CreateLinkCommand.h:
editing/JSEditor.cpp:
editing/Selection.cpp: (WebCore::Selection::selectionFromContentsOfNode):
editing/Selection.h:
editing/UnlinkCommand.cpp: Added. (WebCore::UnlinkCommand::UnlinkCommand): (WebCore::UnlinkCommand::doApply):
editing/UnlinkCommand.h: Added.
page/Frame.cpp: (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):

Mar 24, 2006:

7:34 PM Changeset in webkit [13476] by justing

1 edit in trunk/WebCore/ChangeLog

7:28 PM Changeset in webkit [13475] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document

editing/pasteboard/7955-expected.checksum: Added.
editing/pasteboard/7955-expected.png: Added.
editing/pasteboard/7955-expected.txt: Added.
editing/pasteboard/7955.html: Added.

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document

There's no safe place in the document to keep the fragment while pasting, so I avoid
isProbablyBlock by saving whether or not something was blockFlow during the test
insertion.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): (WebCore::ReplacementFragment::isBlockFlow): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::isBlockFlow): (WebCore::ReplacementFragment::renderingInfo): (WebCore::ReplacementFragment::nodes):

7:11 PM Changeset in webkit [13474] by eseidel

3 edits in trunk/WebCore

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

generate-derived-sources: fix clean builds on mac.

5:47 PM Changeset in webkit [13473] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Dave Harrison.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7942 nightlies after r13387 break js createcontextualfragment

fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
fast/dom/Range/create-contextual-fragment-expected.png: Added.
fast/dom/Range/create-contextual-fragment-expected.txt: Added.
fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

Reviewed by Dave Harrison.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7942 nightlies after r13387 break js createcontextualfragment

Test: fast/dom/Range/create-contextual-fragment.html

dom/Range.idl: Add createContextualFragment.

2:42 AM Changeset in webkit [13472] by eseidel

1 edit in trunk/WebCore/ChangeLog

Fix typo

2:41 AM Changeset in webkit [13471] by eseidel

2 edits in trunk/WebKitTools

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Build fix.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::openURL): replace QString with DeprecatedString

2:40 AM Changeset in webkit [13470] by eseidel

13 edits in trunk/WebCore

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.
Uninify mac/win dependency handling.
Fix class vs. struct linker problem for win32.

WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
WebCore.vcproj/WebCore/build-generated-files.sh:
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.h:
generate-derived-sources:
kwq/AccessibilityObjectCache.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp:
platform/mac/GraphicsContextMac.mm:
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectedText): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

Mar 23, 2006:

11:17 PM Changeset in webkit [13469] by darin

2 edits in trunk/WebKitSite

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7918 Coding style doc uses illegal entity

coding/coding-style.html: Changed &emdash; to —.

11:15 PM Changeset in webkit [13468] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

JSObject in LiveConnect not working. http://bugzilla.opendarwin.org/show_bug.cgi?id=7917

bindings/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base class, and the GetFieldID was using the wrong signature.

11:07 PM Changeset in webkit [13467] by darin

10 edits in trunk/WebCore

Reviewed by Adele.

fix <rdar://problem/4484787> KWQAccObject dangles under GC

kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change from CF dictionaries to HashMap and HashSet.
kwq/AccessibilityObjectCache.mm: (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects and call CFRelease on all of them. (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting them in the HashMap, rather than assuming that retain == CFRetain. This is what fixes the GC issue. (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing. (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before. (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet. (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes. (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto. (WebCore::AccessibilityObjectCache::childrenChanged): Ditto. (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto. (WebCore::AccessibilityObjectCache::postNotification): Ditto.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]): Change to use functions by new names.

dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace. getAccObjectCache and ownerElement are const member functions, and m_accCache is a mutable data member.
dom/Document.cpp: (WebCore::Document::getAccObjectCache): Make const. (WebCore::Document::ownerElement): Make const.

kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject anchorElement]): Update for function name change. (-[WebCoreAXObject firstChild]): Ditto. (-[WebCoreAXObject lastChild]): Ditto. (-[WebCoreAXObject previousSibling]): Ditto. (-[WebCoreAXObject nextSibling]): Ditto. (-[WebCoreAXObject parentObject]): Ditto. (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto. (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto. (AXLinkElementForNode): Ditto. (AXAttributedStringAppendReplaced): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto. (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto. (-[WebCoreAXObject axObjectID]): Change field name to m_id. (-[WebCoreAXObject setAXObjectID:]): Ditto. (-[WebCoreAXObject removeAXObjectID]): Ditto.

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Remove ifdefs. (WebCore::RenderContainer::appendChildNode): Ditto. (WebCore::RenderContainer::insertChildNode): Ditto.
rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.

11:05 PM Changeset in webkit [13466] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix buildbot

JavaScriptCore.xcodeproj/project.pbxproj: Change target name to JavaScriptCore (it was "include"!?). Also add -Y 3 option for linker.

10:28 PM Changeset in webkit [13465] by darin

23 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

kjs/object.h: Take function name, as well as source URL and line number, when using the special overloaded construct for making functions.
kjs/object.cpp: (KJS::JSObject::construct): Ditto.
kjs/function_object.h: Ditto.
kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when constructing the function rather than null. Use "anonymous" when making a function using the default function constructor.

kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before a function declaration.

unrelated fix

kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

fast/js/resources/function-names.js: Added.
fast/js/function-names.html: Generated.
fast/js/function-names-expected.txt: Generated.

WebCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

Test: fast/js/function-names.html

dom/Document.h: Add function name parameter to createHTMLEventListener.
dom/Document.cpp: (WebCore::Document::createHTMLEventListener): Pass function name when calling createHTMLEventHandler. (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name when calling createHTMLEventListener.

html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute name as function name when calling createHTMLEventListener.

khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name. (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.

khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and createSVGEventHandler.
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating a JSLazyEventListener. (WebCore::KJSProxy::createSVGEventHandler): Ditto.

ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to JSSVGLazyEventListener.
ksvg2/events/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name on to the base class constructor.

ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when calling createSVGEventHandler.

ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner): Pass attribute name as function name when calling createSVGEventListener.

WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.

5:51 PM Changeset in webkit [13464] by tomernic

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Layout test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

fast/forms/button-default-title-expected.checksum: Added.
fast/forms/button-default-title-expected.png: Added.
fast/forms/button-default-title-expected.txt: Added.
fast/forms/button-default-title.html: Added.

WebCore:

Reviewed by Darin.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueWithDefault): Only use the default button title if no title was specified; previously we'd use the default button title if the specified title was empty, which is not what Firefox does.

5:20 PM Changeset in webkit [13463] by darin

14 edits in trunk/LayoutTests

removed merge artifacts from .checksum files

fast/block/float/vertical-move-relayout-expected.checksum:
fast/css/first-letter-detach-expected.checksum:
fast/css/hover-subselector-expected.checksum:
fast/dom/Element/class-attribute-whitespace-expected.checksum:
fast/events/event-sender-mouse-moved-expected.checksum:
fast/forms/form-hides-table-expected.checksum:
fast/invalid/missing-address-end-tag-expected.checksum:
fast/invalid/missing-dl-end-tag-expected.checksum:
fast/invalid/missing-dt-end-tag-expected.checksum:
fast/invalid/missing-font-end-tag-expected.checksum:
fast/text/in-rendered-text-rtl-expected.checksum:
fast/tokenizer/missing-title-end-tag-1-expected.checksum:
fast/tokenizer/missing-title-end-tag-2-expected.checksum:

5:08 PM Changeset in webkit [13462] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Beth.

test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

fast/css/max-height-none-expected.checksum: Added.
fast/css/max-height-none-expected.txt: Added.
fast/css/max-height-none.html: Added.
fast/css/max-height-none-expected.png: Added.

WebCore:

Reviewed by Beth.

fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.

2:44 PM Changeset in webkit [13461] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed, tweaked, and landed by Beth.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

2:27 PM Changeset in webkit [13460] by bdakin

2 edits in trunk/WebCore

Reviewed by Darin

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
REGRESSION: style change where :hover changes only an :after style
doesn't work

dom/Node.cpp: (WebCore::Node::diff): Need to call diff() on the before and after styles if we have them.

2:07 PM Changeset in webkit [13459] by tomernic

4 edits in trunk/WebKit

Reviewed by John Sullivan.

At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

WebView/WebFramePrivate.h: Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is cancelled and when a redirect is successfully committed.
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge reportClientRedirectCancelled:]): Call renamed WebFrame method.
WebView/WebFrame.m: Added sentRedirectNotification flag to WebFramePrivate. This flag is set when we notify the frame load delegate that a redirect will occur. We check this flag when committing a provisional load to ensure that the frame load delegate is notified that the redirect finished. (-[WebFrame _commitProvisionalLoad:]): After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending redirect. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Set the new sentRedirectNotification flag. (-[WebFrame _clientRedirectCancelledOrFinished:]): Renamed method. Clear the sentRedirectNotification flag. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Call renamed method.

1:58 PM Changeset in webkit [13458] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935 <rdar://problem/4489010> Infinite recursion in table code when button or new text fields get display:table-row

Added:

fast/forms/button-table-styles.txt: Added.
fast/forms/button-table-styles.png: Added.
fast/forms/button-table-styles.checksum: Added.
fast/forms/button-table-styles.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935 <rdar://problem/4489010> Infinite recursion in table code when button or new text fields get display:table-row

Test:
fast/forms/button-table-styles.html

rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): The theme should disallow table display styles form elements.

1:28 PM Changeset in webkit [13457] by tomernic

1 edit in trunk/WebKit/ChangeLog

Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

1:17 PM Changeset in webkit [13456] by tomernic

2 edits in trunk/WebKit

Reviewed by Eric.

fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

8:31 AM Changeset in webkit [13455] by darin

12 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7805 LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod

bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT, BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in one case and remove a _NPN_ReleaseObject in another because this should return a retained value. (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN, NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.

bindings/c/c_runtime.h: Removed implementations of CMethod::name and CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
bindings/c/c_runtime.cpp: (KJS::Bindings::CMethod::name): Added. Returns the string from inside the method object. (KJS::Bindings::CField::name): Added. Returns the string from inside the field object. (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue on the result of getProperty after using it to fix a storage leak. (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue after pasing a value to setProperty now that the conversion function does a retain.

bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local stack buffer. Removed special case for NPVARIANT_IS_VOID because the convertNPVariantToValue function handles that properly. (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.

bindings/NP_jsobject.h: Formatting changes only.
bindings/NP_jsobject.cpp: (jsDeallocate): Changed parameter type so we don't need a function cast. (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT. (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT. (_NPN_Evaluate): Use VOID_TO_NPVARIANT. (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.

bindings/c/c_class.cpp: Formatting changes only.
bindings/c/c_class.h: Formatting changes only.

bindings/npruntime_priv.h: Removed obsolete and now-unused functions: NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined, NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble, NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool, NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString, NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid, NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined, NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32, NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString, NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
bindings/npruntime.cpp: (getIntIdentifierDictionary): Don't bother creating custom callbacks for the integer dictionary since the default behavior is fine for integers.

8:08 AM Changeset in webkit [13454] by darin

2 edits in trunk/WebCore

generate-derived-sources: Tweaked formatting a tiny bit and removed a stray touch that was left in here.

7:36 AM Changeset in webkit [13453] by darin

2 edits in trunk/WebKit

Reviewed by Eric.

fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

12:21 AM Changeset in webkit [13452] by eseidel

3 edits in trunk/WebCore

2006-03-23 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

REGRESSION: Dashed borders paint with the wrong phase
http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

Test: Already covered by css1/box_properties/border_style.html

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):

Mar 22, 2006:

10:30 PM Changeset in webkit [13451] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

generate-derived-sources: Suppress warning.

10:13 PM Changeset in webkit [13450] by mjs

2 edits in trunk/WebCore

generate-derived-sources: Added.

10:03 PM Changeset in webkit [13449] by mjs

9 edits
1 add
4 deletes in trunk/WebCore

Reviewed by Eric.

Handle dependencies for derived sources properly.

Made a new generate-derived-sources script that does all the depedency checking and source generation.
Put this script in a subtarget instead of a phase.
Made derived sources go in the build root, not a source root.
Added derived sources to the project.
Removed files whose sole purpose was to include and compile derived sources, just compile those directly for now.
Tweaked the IDL code generator so it can handle one IDL at a time, to make it easier to get the dependencies right.

generate-derived-sources: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMCore.cpp: Removed.
bindings/js/JSDOMEvents.cpp: Removed.
bindings/js/JSDOMHTML.cpp: Removed.
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/generate-bindings.pl:
css/UserAgentStyleSheets.cpp: Removed.
dom/Range.cpp: (WebCore::Range::~Range):
dom/Range.h:
khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRuleList::DOMCSSRuleList): (KJS::DOMCSSRule::DOMCSSRule):
khtml/ecma/kjs_css.h:

9:46 PM Changeset in webkit [13448] by mjs

2 edits in trunk/JavaScriptCore

Reviewed and landed by Maciej.

WebKit no longer builds with bison 2.1 http://bugzilla.opendarwin.org/show_bug.cgi?id=7923

generate-derived-sources: Handle generated header named either grammar.cpp.h or grammar.hpp.

5:37 PM Changeset in webkit [13447] by justing

4 edits
5 adds
1 delete in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

Added:

editing/pasteboard/display-block-on-spans-expected.txt: Added.
editing/pasteboard/display-block-on-spans-expected.png: Added.
editing/pasteboard/display-block-on-spans-expected.checksum: Added.
editing/pasteboard/display-block-on-spans.html: Added.

I'm disabling this layout test because of 7899:

editing/pasteboard/paste-empty-startcontainer.html

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::computeAndStoreNodeStyles): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h: (WebCore::ReplacementFragment::root):

5:31 PM Changeset in webkit [13446] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Even better fix for <rdar://problem/4432562>. We need to notify the frame delegate of a finished redirect for both
"fast" and "slow" redirects, after committing the load. My previous change only notified for "fast", history-locking
redirects. Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
a fast redirect.

WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]):

5:21 PM Changeset in webkit [13445] by eseidel

3 edits
2 adds in trunk

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix attribute mutation events to not fire for "style" attributes.
We lazily update style attributes, so sending mutation events for them makes no sense anymore.
<rdar://problem/4474910> repro assertion failure @ apple.com/store: !eventDispatchForbidden()

Test: fast/events/delayed-style-mutation-event-crash.html

dom/dom_elementimpl.cpp: (WebCore::Element::dispatchAttrRemovalEvent): add assert (WebCore::Element::dispatchAttrAdditionEvent): add assert (WebCore::NamedAttrMap::addAttribute):

3:37 PM Changeset in webkit [13444] by eseidel

18 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove more DeprecatedString usage.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): (WebCore::FrameMac::fontForSelection): (WebCore::FrameMac::tokenizerProcessedData): (WebCore::FrameMac::registerCommandForUndoOrRedo): (WebCore::FrameMac::markMisspellings): (WebCore::FrameMac::respondToChangedSelection): (WebCore::FrameMac::dashboardRegionsDictionary): (WebCore::FrameMac::dragSourceMovedTo):
css/CSSGrammar.y:
css/css_valueimpl.h:
css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseColorFromValue): (WebCore::yyerror): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
css/cssparser.h: (WebCore::deprecatedString):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty):
ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine):
rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::absolutePosition): (WebCore::RenderCanvas::paint):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderObject.h:
rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
rendering/render_form.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
rendering/table_layout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):

3:33 PM Changeset in webkit [13443] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout text for <rdar://problem/4471984> repro crash CSS position
for html/table=relative causes crash when hiding table

2:42 PM Changeset in webkit [13442] by mjs

2 edits in trunk/JavaScriptCore

fix the build

JavaScriptCore.xcodeproj/project.pbxproj:

2:30 PM Changeset in webkit [13441] by tomernic

5 edits
4 adds in trunk

WebCore:

Reviewed by Kevin Decker.

Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: Removed redirectionTimerFired(). This was added as attempt to fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>. The aim was to cause Safari and WebKit to update their loading status after a redirect. Unfortunately, the fix had a bad side effect. Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed to lock history (i.e. reuse the current back/forward entry for the new page). The end result was that intermediate "quick" redirects were creating back/forward entries when they should not have been. See 4351664. That fix was almost correct, in that we do need to notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled. However, this is the wrong place to do it. WebCore's redirect notification logic did not need to change to fix 7058. The never-ending spinning indicators problem was actually caused by a bug at the WebKit level.

manual-tests/redirectHistory: Added.
manual-tests/redirectHistory/redir-1.html: Added.
manual-tests/redirectHistory/redir-2.html: Added.
manual-tests/redirectHistory/redir-3.html: Added. Manual test case. I couldn't figure out how to create a layout test for this, because it involves navigation through history and it was unclear how/when to tell DumpRenderTree to dump its output.

WebKit:

Reviewed by Kevin Decker.

Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]

WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect. This is a better fix for 7058 (<rdar://problem/4432562>). The original fix for 7058 changed the timing of the redirect cancel in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects. Clearing the redirect state here actually makes logical sense, as the redirect's target page is being committed at this point.

2:27 PM Changeset in webkit [13440] by eseidel

57 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7907

WebCore+SVG/kdom.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::setTypedIconURL):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::nsArray): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::bindingRootObject): (WebCore::FrameMac::windowScriptObject): (WebCore::FrameMac::windowScriptNPObject): (WebCore::FrameMac::partClearedInBegin): (WebCore::FrameMac::openURLFromPageCache):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreFrameBridge scrollToAnchor:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setMinimumLogicalFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setUserStyleSheetLocation:]):
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSGrammar.y:
css/css_stylesheetimpl.cpp: (WebCore::MediaList::setMediaText):
css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
css/cssparser.cpp: (WebCore::CSSParser::parseColor):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
css/cssstyleselector.h:
dom/Document.cpp: (WebCore::Document::resetActiveLinkColor): (WebCore::Document::nextState): (WebCore::Document::setUserStyleSheet): (WebCore::Document::processHttpEquiv): (WebCore::Document::recalcStyleSelector):
dom/Document.h: (WebCore::Document::userStyleSheet): (WebCore::Document::setPrintStyleSheet): (WebCore::Document::printStyleSheet):
editing/markup.cpp: (WebCore::createMarkup): (WebCore::createFragmentFromMarkup): (WebCore::createFragmentFromText):
editing/markup.h:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
html/html_baseimpl.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach):
html/html_headimpl.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
html/html_headimpl.h:
html/html_imageimpl.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
html/html_imageimpl.h: (WebCore::HTMLImageElement::compositeOperator):
html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::createRenderer):
ksvg2/svg/SVGStringList.cpp: (SVGStringList::reset):
kwq/AccessibilityObjectCache.h:
kwq/AccessibilityObjectCache.mm: (AccessibilityObjectCache::textMarkerForVisiblePosition): (AccessibilityObjectCache::postNotificationToTopWebArea): (AccessibilityObjectCache::postNotification):
kwq/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::userStyleSheetLocation): (KHTMLSettings::setUserStyleSheetLocation):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::selectedText):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref):
page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::jScriptEnabled): (WebCore::Frame::javaEnabled): (WebCore::Frame::pluginsEnabled): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheet): (WebCore::Frame::requestObject): (WebCore::Frame::loadPlugin): (WebCore::Frame::referrer): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
platform/DeprecatedString.cpp: (DeprecatedString::replace):
platform/GraphicsContext.h:
platform/Image.h:
platform/KURL.cpp:
platform/KURL.h:
platform/PlatformString.h: (WebCore::String::String): (WebCore::String::replace):
platform/String.cpp: (WebCore::operator+):
platform/StringImpl.cpp: (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::replace):
platform/StringImpl.h:
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
rendering/render_frames.cpp: (WebCore::isURLAllowed): (WebCore::mapClassIdToServiceType): (WebCore::RenderPartObject::updateWidget):
rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
xml/xmlhttprequest.cpp: (WebCore::getCharset): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::overrideMIMEType):

2:21 PM Changeset in webkit [13439] by bdakin

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4471984> repro crash CSS position for html/
table=relative causes crash when hiding table

2:10 PM Changeset in webkit [13438] by mjs

2 edits in trunk/JavaScriptCore

kjs/generate-derived-sources: Set executable property.

2:10 PM Changeset in webkit [13437] by hyatt

5 edits in trunk/WebCore

Fix for residual style problem where form elements lose their connection
to a degenerate table form because of a residual style fixup. This is
Radar bug #4330765.

Reviewed by eric

khtml/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
khtml/html/HTMLFormElement.h: (WebCore::HTMLFormElement::setPreserveFormConnectionAcrossRemove): (WebCore::HTMLFormElement::preserveFormConnectionAcrossRemove):
khtml/html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):

2:09 PM Changeset in webkit [13436] by adele

2 edits
4 adds in trunk/WebCore

Reviewed by Adele.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7747 REGRESSION: Background tab/window auto-refresh in GMail will take focus.

manual-tests/named-window-blank-target.html: Added.
manual-tests/resources/named-window-blank-target-step2.html: Added.
manual-tests/resources/named-window-blank-target-step3.html: Added.
manual-tests/resources/named-window-blank-target-step4.html: Added.
page/FrameTree.cpp: (WebCore::FrameTree::find): If the given name is empty, just return our frame, even if it has a name.

1:31 PM Changeset in webkit [13435] by mjs

2 edits
1 add in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that generated source dependencies are handled properly, as follows:

Made an external script that generates the sources into a DerivedSources dir in the build products directory.
Added a new build target that builds all the generated sources if needed. Sadly it has to be a target, not a phase for Xcode to notice changes.
Added the DerivedSources dir in question to the include path.
Added the new DerivedSources dir and its contents to the project as build-relative.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/generate-derived-sources: Added. Based on the windows version - maybe someday they can share more.

12:18 PM Changeset in webkit [13434] by darin

1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number.

12:16 PM Changeset in webkit [13433] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

fast/dom/Element/onclick-case-expected.txt: Added.
fast/dom/Element/onclick-case.html: Added.

WebCore:

Reviewed by Adele.

fix <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

Test: fast/dom/Element/onclick-case.html

We discussed this with Maciej. In the long run we may need to remove the "all attributes
show up as properties in JavaScript" feature entirely. Gecko does not do it, and it's
not really the same thing IE does either.

khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::attributeGetter): Use getAttributeNS so we're case sensitive. (KJS::DOMElement::getOwnPropertySlot): Ditto.

12:02 PM Changeset in webkit [13432] by eseidel

2 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

<rdar://problem/4486417> REGRESSION: Mail linked against TOT WebKit crashes when composing a message

No test possible.

bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings init]): call AtomicString::init()

Mar 21, 2006:

8:59 PM Changeset in webkit [13431] by darin

2 edits in trunk/WebKit

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3784 <rdar://problem/4483827> JavaScript save dialog disappears right away (sheet triggers blur event) (3784)

WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): Treat window as having focus if its sheet is key. (-[WebHTMLView addWindowObservers]): Observe all focus notifications, not just the ones involving this window. (-[WebHTMLView removeWindowObservers]): Ditto. (-[WebHTMLView windowDidBecomeKey:]): Add checks so that we call the methods only when appropriate, since this will now be called for all windows. (-[WebHTMLView windowDidResignKey:]): Ditto.

8:44 PM Changeset in webkit [13430] by darin

4 edits in trunk/WebCore

fix buildbot (and everyone else)

bindings/js/JSDOMCore.cpp: Touch, because Adele's change adds a virtual function, and Xcode doesn't know this needs recompiling.
bindings/js/JSDOMEvents.cpp: Ditto.
bindings/js/JSDOMHTML.cpp: Ditto.

8:38 PM Changeset in webkit [13429] by darin

7 edits in trunk/WebCore

Reviewed by Eric and Darin.

get Windows building again

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::userAgent):
bridge/win/FrameWin.h:
platform/GraphicsContext.h:
platform/cairo/ImageCairo.cpp: (WebCore::Image::supportsType):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::mimeTypeForFileName): (FrameWin::objectContentType): (FrameWin::createPlugin): (FrameWin::overrideMediaType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::incomingReferrer):

7:42 PM Changeset in webkit [13428] by darin

3 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7884 REGRESSION: Selecting a custom style sheet crashes 20/3 nightly

page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): This was calling the function that sets the stylesheet URL, passing it the actual stylesheet. (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheetLocation): Renamed the version of setUserStyleSheet() that takes a URL to this. (WebCore::Frame::reparseConfiguration):
page/Frame.h:

5:08 PM Changeset in webkit [13427] by adele

19 edits
10 adds in trunk

LayoutTests:

Tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
elementAtPoint needs to return input element when clicking on new text field
http://bugzilla.opendarwin.org/show_bug.cgi?id=7799
New text fields don't respect the disabled attribute

fast/forms/input-appearance-disabled-expected.checksum: Added.
fast/forms/input-appearance-disabled-expected.png: Added.
fast/forms/input-appearance-disabled-expected.txt: Added.
fast/forms/input-appearance-disabled.html: Added.
fast/forms/input-appearance-elementFromPoint-expected.txt: Added.
fast/forms/input-appearance-elementFromPoint.html: Added.
fast/forms/input-appearance-preventDefault-expected.checksum: Added.
fast/forms/input-appearance-preventDefault-expected.png: Added.
fast/forms/input-appearance-preventDefault-expected.txt: Added.
fast/forms/input-appearance-preventDefault.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6813 elementAtPoint needs to return input element when clicking on new text field http://bugzilla.opendarwin.org/show_bug.cgi?id=7799 New text fields don't respect the disabled attribute

Tests: fast/forms/input-appearance-disabled.html fast/forms/input-appearance-elementFromPoint.html fast/forms/input-appearance-preventDefault.html

bridge/mac/WebCoreFrameBridge.h: Added allowShadowContent parameter to getInnerNonSharedNode so new elementAtPoint method in WebKit can call this.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Passes allowShadowContent parameter to nodeInfoAtPoint. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Updated to call nodeInfoAtPoint allowing shadow content. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]): Added allowShadowContent parameter.

dom/Node.h: (WebCore::Node::isShadowNode): Added. (WebCore::Node::shadowParentNode): Added.
dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Added. If an ancestor is a shadow node, return its shadow parent node.
html/HTMLTextFieldInnerElement.h: (WebCore::HTMLTextFieldInnerElement::isShadowNode): Added.

dom/Document.cpp: (WebCore::Document::elementFromPoint): Gets the shadowAncestorNode (so we get the input element, and not the inner div).
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): If text fields are focusable, then they should be keyboard focusable. This works for the old text fields because HTMLGenericFormElement::isKeyboardFocusable does the right thing for RenderWidgets. That's not needed for the new form elements. (WebCore::HTMLInputElement::defaultEventHandler): let the renderer forward drag, mouse, and wheel events.

page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Send drag events to the shadowAncestorNode. (WebCore::FrameView::dispatchMouseEvent): Send mouse events to the shadowAncestorNode. (WebCore::FrameView::handleWheelEvent): Send wheel events to the shadowAncestorNode.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): forwards events to the inner div element.
rendering/RenderTextField.h: Added forwardEvent method.

kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityHitTest:]): Gets the shadowAncestorNode (so we get the input element, and not the inner div). (-[WebCoreAXObject role]): Gets the right role for text fields, since we no longer get that from AppKit. (-[WebCoreAXObject roleDescription]): Gets the right description for text fields.

WebKit:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6813 elementAtPoint needs to return input element when clicking on new text field

WebView/WebDocumentInternal.h: Added elementAtPoint:allowShadowContent:
WebView/WebHTMLView.m: (-[NSArray elementAtPoint:]): Does not allow shadow content. This way, by default, callers would get the input element instead of the inner div. (-[NSArray elementAtPoint:allowShadowContent:]): Allows callers to specify whether or not the element can be a shadow node. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Allows shadow content when getting element. (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto. (-[NSArray _isSelectionEvent:]): ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): ditto.
WebView/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Does not allow shadow content when getting element.
WebView/WebImageView.m: (-[WebImageView elementAtPoint:allowShadowContent:]): Added to conform to the WebDocumentElement protocol.
WebView/WebPDFView.m: (-[WebPDFView elementAtPoint:allowShadowContent:]): ditto.
WebView/WebTextView.m: (-[WebTextView elementAtPoint:allowShadowContent:]): ditto.

3:52 PM Changeset in webkit [13426] by darin

14 edits
5 adds in trunk

LayoutTests:

test for <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

fast/html: Added.
fast/html/listing-expected.checksum: Added.
fast/html/listing-expected.png: Added.
fast/html/listing-expected.txt: Added.
fast/html/listing.html: Added.

WebCore:

Reviewed by Tim O.

fixed <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

Test: fast/html/listing.html

html/HTMLNames.h: Add listing tag.

bindings/objc/DOM.mm: (+[DOMNode _nodeWith:]):
bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
css/html4.css:
editing/ReplaceSelectionCommand.cpp: (WebCore::isProbablyBlock):
editing/TextIterator.cpp: (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup):
html/HTMLElement.cpp: (WebCore::blockTagList):
html/HTMLElementFactory.cpp: (WebCore::addTag): (WebCore::createFunctionMap): (WebCore::HTMLElementFactory::createHTMLElement):
html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
khtml/ecma/kjs_html.cpp: (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): Add listing tags everywhere pre tags are listed.

3:41 PM Changeset in webkit [13425] by thatcher

12 edits in trunk/WebCore/dom

Touching the idl files to force a build after Maciej's change.

3:36 PM Changeset in webkit [13424] by mjs

6 edits in trunk/WebCore

Reviewed by Darin.

fix horrible build fallout from my attr fix

bindings/js/JSCanvasRenderingContext2DBase.cpp:
bindings/js/JSDOMCore.cpp:
bindings/js/JSDOMEvents.cpp:
bindings/js/JSDOMHTML.cpp:
bindings/scripts/CodeGeneratorJS.pm:

2:49 PM Changeset in webkit [13423] by tomernic

4 edits
2 adds in trunk/WebKit

Reviewed by Tim Hatcher and Darin.

<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment deprecated, used in Netscape
plugin code

Plugins/WebNetscapeDeprecatedFunctions.h: Added.
Plugins/WebNetscapeDeprecatedFunctions.c: Added. Added wrappers for deprecated CFM and LowMem functions. These exist in a separate file so that we can set -Wno-deprecated-declarations on this one file without ignoring other deprecated function usage elsewhere. (WebGetDiskFragment): (WebCloseConnection): (WebLMGetCurApRefNum): (WebLMSetCurApRefNum):

Plugins/WebNetscapePluginPackage.h: Don't include connID ivar in 64-bit, since CFM is not supported in 64-bit.
Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Don't bother setting the resource refNum in 64-bit, because the API to get and set it does not exist. A theoretical 64-bit plugin couldn't possibly rely this, since there is no API. (-[WebNetscapePluginPackage unloadWithoutShutdown]): No need to close the connID in 64-bit. (-[WebNetscapePluginPackage load]): Don't load CFM bundles in 64-bit, because CFM is not supported.

WebKit.xcodeproj/project.pbxproj: Added WebNetscapeDeprecatedFunctions.[hm].

11:36 AM Changeset in webkit [13422] by sullivan

5 edits in trunk/WebKit

Reviewed by Kevin Decker.

fixed <rdar://problem/4485637> Implementors of searchFor:direction:caseSensitive:wrap: should bail out early if search string is empty

This doesn't change any existing behavior, but avoids unnecessary work.

Misc/WebSearchableTextView.m: (-[WebSearchableTextView searchFor:direction:caseSensitive:wrap:]): bail out immediately (returning NO) if search string is empty

WebView/WebHTMLView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

WebView/WebPDFView.m: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): ditto

WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

10:12 AM Changeset in webkit [13421] by bdakin

2 edits in trunk/LayoutTests

Reducing the amount of time this test waits for the frame to fully
load per Justin's request.

9:36 AM Changeset in webkit [13420] by bdakin

6 edits
5 adds in trunk

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7223
Reproducible crash when tabbing to a frame that has not been loaded
Also adds support for keyDown() to DumpRenderTree.

2:53 AM Changeset in webkit [13419] by eseidel

3 edits
3 adds in trunk

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix a unsafe static cast causing intermittent crashes.
<rdar://problem/4411663> crash at KXMLCore::RefPtr<WebCore::DOMStringImpl>::get() const + 20 (RefPtr.h:45)

Test: fast/dom/NodeList/item-by-id-with-no-document.html

dom/NodeList.cpp: (WebCore::NodeList::itemById): fix unsafe static cast.

Mar 20, 2006:

11:57 PM Changeset in webkit [13418] by justing

1 edit
2 adds in trunk/LayoutTests

Reviewed by vicki

Testcase for fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7363>
REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

fast/forms/textfield-focus-out-expected.txt: Added.
fast/forms/textfield-focus-out.html: Added.

11:56 PM Changeset in webkit [13417] by mjs

2 edits in trunk/WebCore

touch this file in hopes of fixing build

bindings/js/JSDOMCore.cpp:

11:12 PM Changeset in webkit [13416] by mjs

1 edit in trunk/LayoutTests/ChangeLog

fix accidentally reversed changelog entries

11:08 PM Changeset in webkit [13415] by mjs

7 edits
5 adds in trunk

LayoutTests:

Reviewed by mjs.

Test for: <rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

fast/tokenizer/external-script-document-open-expected.txt: Added.
fast/tokenizer/external-script-document-open.html: Added.
fast/tokenizer/resources/external-script-document-open.js: Added.
fast/tokenizer/resources/write-external-script-open.js: Added.
fast/tokenizer/write-external-script-open-expected.txt: Added.
fast/tokenizer/write-external-script-open.html: Added.
fast/tokenizer/write-inline-script-open-expected.txt: Added.
fast/tokenizer/write-inline-script-open.html: Added.

WebCore:

Reviewed by Anders.

fixed <rdar://problem/4446749> 10.4.4: safari crash in DOM::NamedAttrMapImpl::setNamedItem

bindings/scripts/CodeGeneratorJS.pm: Add a framework for typechecking method arguments. For now only use it for parameters of type Attr.
dom/Element.idl: Arbitrary change to make it regenerate.
dom/dom_elementimpl.cpp: (WebCore::Element::setAttributeNode): ASSERT that attr is not null
khtml/ecma/kjs_dom.cpp: (KJS::toAttr): add bool ok parameter
khtml/ecma/kjs_dom.h:

11:02 PM Changeset in webkit [13414] by eseidel

1 edit
1 delete in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

ksvg2/css/SVGCSSParser.h: Removed unused file.

10:46 PM Changeset in webkit [13413] by eseidel

7 edits
8 adds in trunk

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix tokenizer crash when document.open() is called from an external script:
<rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

dom/Document.cpp: (WebCore::Document::open): Check to make sure the current tokenizer isn't executing a script
dom/xml_tokenizer.h: (WebCore::Tokenizer::executingScript): Add a way for others to know if scripts are executing.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Wire into existing m_executingScript member var.
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::executingScript):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): Unrelated code cleanup.

10:22 PM Changeset in webkit [13412] by justing

4 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/3997958>
REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode

dom/Position.cpp: (WebCore::Position::upstream): Avoid calling previous() when we know that it will 1) end the search and 2) be expensive to compute. (WebCore::Position::downstream): Removed some dead code. (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
dom/Position.h:
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose the one that occurs first in document order. Using upstream() to find the one that occurs first is much faster than the old code.

9:52 PM Changeset in webkit [13411] by mjs

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test case for <rdar://problem/4362396> REGRESSION: (417-420) stopPropagation is not working for click event listener (onclick works fine)

Make sure that capturing event listeners trigger on the target and that if they
stopPropagation, then bubbling listeners on ancestors do not trigger.

fast/events/capture-on-target-expected.txt: Added.
fast/events/capture-on-target.html: Added.

WebCore:

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.

<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):

8:23 PM Changeset in webkit [13410] by eseidel

4 edits in trunk

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.

<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):

7:52 PM Changeset in webkit [13409] by adele

2 edits in trunk/WebCore

Reviewed by Justin.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): When calculating the VisiblePosition for the first position in the text field, it makes more sense for the position to have a downstream affinity.

5:54 PM Changeset in webkit [13408] by eseidel

1 edit
1 move
1 add in trunk/LayoutTests

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Re-enable previously failing test.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Added.
dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Removed.

5:46 PM Changeset in webkit [13407] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4458568> WebCore should not disclose https referrers

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.

5:29 PM Changeset in webkit [13406] by tomernic

4 edits in trunk/WebKit

Reviewed by John Sullivan.

Moved -_contentView from WebFrameViewInternal to WebFrameViewPrivate. Safari
needs this.

WebView/WebFrameView.m: (-[WebFrameView _contentView]):
WebView/WebFrameViewInternal.h:
WebView/WebFrameViewPrivate.h:

5:15 PM Changeset in webkit [13405] by darin

84 edits
1 move
1 add in trunk/WebCore

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7867 get rid of macro hacks for DOM, KDOM, KSVG, khtml, DOMString, QString

config.h: Remove the defines for DOM, KDOM, KSVG, khtml, DOMString, QString, and qstring().

WebCore.xcodeproj/project.pbxproj: Pass in WebCore instead of KSVG as the namespace for SVG names.
ksvg2/scripts/make_names.pl: Made a couple changes to trick the SVG names into recompiling, since they are in a different namespace now.

ForwardingHeaders/kjs/identifier.h: Added.

dom/PlatformWheelEvent.idl: Removed.
dom/WheelEvent.idl: Added. This file was renamed by accident.

bindings/js/JSDOMCore.cpp:
bindings/js/JSDOMEvents.cpp:
bindings/js/JSDOMHTML.cpp:
dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
html/CanvasGradient.idl:
html/CanvasPattern.idl:
html/CanvasRenderingContext2D.idl: Touched, to get CodeGeneratorJS.pm changes to take effect.

css/CSSGrammar.y:
css/css_valueimpl.cpp: (WebCore::propertyID):

Changed calls to get CSS property values to use an explicit SVG: namespace, to match what the script writes out.

khtml/ecma/kjs_binding.h: Added forward declaration of WebCore::String.

ksvg2/scripts/cssmakeget rid of macro hacks for DOM, KDOM, KSVG, khtml, DOMString, QString props: Made this compile with warnings and strict turned on. Really just a trick to get properties to recompile, which turned out to be unneeded.
ksvg2/scripts/cssmakevalues: Ditto.

ksvg2/svg/SVGAElement.cpp: (SVGAElement::parseMappedAttribute): (SVGAElement::defaultEventHandler):
ksvg2/svg/SVGAnimateTransformElement.cpp: (SVGAnimateTransformElement::parseMappedAttribute):
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::parseMappedAttribute):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
ksvg2/svg/SVGExternalResourcesRequired.cpp: (SVGExternalResourcesRequired::parseMappedAttribute):
ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::parseMappedAttribute):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::parseMappedAttribute):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::parseMappedAttribute):
ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::parseMappedAttribute):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::stringToChannel): (SVGFEDisplacementMapElement::parseMappedAttribute): (SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.h:
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::parseMappedAttribute):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::parseMappedAttribute):
ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
ksvg2/svg/SVGFEMergeNodeElement.cpp: (SVGFEMergeNodeElement::parseMappedAttribute):
ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::parseMappedAttribute):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::parseMappedAttribute):
ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::parseMappedAttribute):
ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::parseMappedAttribute):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::parseMappedAttribute):
ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute):
ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::parseMappedAttribute):
ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::parseMappedAttribute):
ksvg2/svg/SVGViewElement.cpp: (SVGViewElement::parseMappedAttribute):
ksvg2/svg/SVGZoomAndPan.cpp: (SVGZoomAndPan::parseMappedAttribute): Changed code that converts an AtomicString to a String to do it in a more-efficient fashion that works even with all the new conversions.

page/Frame.cpp: (WebCore::getString): Removed unneeded .deprecatedString(). (WebCore::Frame::begin): Removed the only use of QSTRING_NULL.

platform/AtomicString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/AtomicString.cpp: (WebCore::AtomicString::add): Added overloads for Identifier and UString. (WebCore::AtomicString::operator Identifier): Added. (WebCore::AtomicString::operator UString): Added.

platform/DeprecatedString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/DeprecatedString.cpp: (DeprecatedString::DeprecatedString): Added overloads for Identifier and UString. (DeprecatedString::operator Identifier): Added. (DeprecatedString::operator UString): Added.

platform/PlatformString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/String.cpp: (WebCore::String::String): Added overloads for Identifier and UString. (WebCore::String::operator Identifier): Added. (WebCore::String::operator UString): Added.

platform/StringImpl.h: Added constructors that take KJS::Identifier and KJS::UString
platform/StringImpl.cpp: (WebCore::getWordBreakIterator): Changed a use of UChar to say ::UChar instead because of ambiguity with KJS::UChar. (WebCore::StringImpl::StringImpl): Added overloads for Identifier and String.

bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): (WebCore::toHTMLCanvasStyle):
bindings/scripts/CodeGeneratorJS.pm:
bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
dom/QualifiedName.cpp: (WebCore::QualifiedName::toString):
khtml/ecma/JSDOMParser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
khtml/ecma/kjs_css.cpp: (KJS::cssPropertyName): (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMStyleSheetList::getOwnPropertySlot): (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::DOMCSSValue::put): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::attributeGetter): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::Clipboard::putValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::putValueProperty): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::OptionConstructorImp::construct):
khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
khtml/ecma/kjs_range.cpp: (KJS::DOMRangeProtoFunc::callAsFunction):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog): (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Window::installTimeout): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction): Removed explicit calls to domString(), sometimes replacing with explicit calls to the String() constructor. Other similar changes for AtomicString and DeprecatedString use.

3:25 PM Changeset in webkit [13404] by eseidel

78 edits in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove many, many uses of DeprecatedString.
Fix various style issues throughout the touched code.

bindings/objc/DOM.mm: (-[DOMRange _text]):
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.h: (WebCore::FrameMac::bridge): (WebCore::FrameMac::markedTextRange): (WebCore::Mac):
bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::matchLabelsAgainstElement): (WebCore::FrameMac::findString): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::objectContentType): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::setTitle): (WebCore::FrameMac::setStatusBarText): (WebCore::FrameMac::advanceToNextMisspelling): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::mimeTypeForFileName): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::incomingReferrer): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::overrideMediaType): (WebCore::FrameMac::shouldClose):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge selectedString]): (-[WebCoreFrameBridge stringForRange:]): (-[WebCoreFrameBridge advanceToNextMisspelling]): (-[WebCoreFrameBridge advanceToNextMisspellingStartingJustBeforeSelection]): (-[WebCoreFrameBridge domain]):
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setFixedFontFamily:]): (-[WebCoreSettings setSerifFontFamily:]): (-[WebCoreSettings setSansSerifFontFamily:]): (-[WebCoreSettings setCursiveFontFamily:]): (-[WebCoreSettings setFantasyFontFamily:]): (-[WebCoreSettings setUserStyleSheetLocation:]): (-[WebCoreSettings setDefaultTextEncoding:]):
css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::cleanpath): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::convertToLength): (WebCore::colorForCSSValue): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
css/cssstyleselector.h:
dom/CDATASection.cpp: (WebCore::CDATASection::toString):
dom/Document.cpp: (WebCore::Document::recalcStyle):
dom/Document.h: (WebCore::Document::baseTarget): (WebCore::Document::setBaseTarget):
dom/dom_elementimpl.cpp: (WebCore::Element::openTagStartToString):
dom/xml_tokenizer.cpp: (WebCore::handleElementAttributes): (WebCore::XMLTokenizer::startElementNs):
editing/SelectionController.cpp: (WebCore::SelectionController::type):
editing/TextIterator.cpp: (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::CharacterIterator::advance): (WebCore::WordAwareIterator::advance): (WebCore::WordAwareIterator::length): (WebCore::WordAwareIterator::characters): (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append): (WebCore::TextIterator::rangeFromLocationAndLength): (WebCore::findPlainText):
editing/TextIterator.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
khtml/ecma/kjs_window.cpp: (KJS::Location::getValueProperty):
ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
ksvg2/svg/SVGAngle.cpp: (SVGAngle::calculate): (SVGAngle::setValueAsString): (SVGAngle::valueAsString): (SVGAngle::convertToSpecifiedUnits): (SVGAngle::shortestArcBisector):
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::targetElement): (SVGAnimationElement::parseMappedAttribute): (SVGAnimationElement::parseClockValue): (SVGAnimationElement::targetAttribute): (SVGAnimationElement::setTargetAttribute): (SVGAnimationElement::detectAnimationMode): (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
ksvg2/svg/SVGColor.cpp: (SVGColor::setRGBColor):
ksvg2/svg/SVGDOMImplementation.cpp: (svgFeatureSet): (SVGDOMImplementation::self): (SVGDOMImplementation::hasFeature): (SVGDOMImplementation::createDocumentType): (SVGDOMImplementation::createDocument):
ksvg2/svg/SVGDOMImplementation.h:
ksvg2/svg/SVGPaint.cpp: (SVGPaint::cssText):
ksvg2/svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::toString):
ksvg2/svg/SVGPreserveAspectRatio.cpp: (SVGPreserveAspectRatio::parsePreserveAspectRatio): (SVGPreserveAspectRatio::getCTM):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
ksvg2/svg/SVGURIReference.cpp: (SVGURIReference::getTarget):
kwq/ClipboardMac.mm: (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setEffectAllowed): (WebCore::cocoaOpFromIEOp): (WebCore::IEOpFromCocoaOp): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
kwq/KWQCString.cpp: (DeprecatedCString::append):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::stdFontName): (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName): (KHTMLSettings::sansSerifFontName): (KHTMLSettings::cursiveFontName): (KHTMLSettings::fantasyFontName): (KHTMLSettings::minFontSize): (KHTMLSettings::minLogicalFontSize): (KHTMLSettings::mediumFontSize): (KHTMLSettings::mediumFixedFontSize): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::JavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::isJavaEnabled): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::encoding): (KHTMLSettings::userStyleSheet): (KHTMLSettings::shouldPrintBackgrounds): (KHTMLSettings::textAreasAreResizable): (KHTMLSettings::setStdFontName): (KHTMLSettings::setFixedFontName): (KHTMLSettings::setSerifFontName): (KHTMLSettings::setSansSerifFontName): (KHTMLSettings::setCursiveFontName): (KHTMLSettings::setFantasyFontName): (KHTMLSettings::setMinFontSize): (KHTMLSettings::setMinLogicalFontSize): (KHTMLSettings::setMediumFontSize): (KHTMLSettings::setMediumFixedFontSize): (KHTMLSettings::setAutoLoadImages): (KHTMLSettings::setIsJavaScriptEnabled): (KHTMLSettings::setIsJavaEnabled): (KHTMLSettings::setArePluginsEnabled): (KHTMLSettings::setJavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::setEncoding): (KHTMLSettings::setUserStyleSheet): (KHTMLSettings::setShouldPrintBackgrounds): (KHTMLSettings::setTextAreasAreResizable):
kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
kwq/KWQTextStream.cpp: (QTextStream::QTextStream): (QTextStream::operator<<): (QTextStream::precision):
kwq/KWQTextStream.h:
kwq/RenderTreeAsText.cpp: (operator<<): (quoteAndEscapeNonPrintables): (writeTextRun): (write): (writeSelection):
loader/Cache.cpp: (WebCore::Cache::init): (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::preloadStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::preloadScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::error):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::error):
loader/CachedImage.h:
loader/CachedObject.h:
loader/CachedScript.cpp: (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::error):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::error):
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::needReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::setAutoloadImages): (WebCore::DocLoader::setShowAnimations): (WebCore::DocLoader::removeCachedObject):
loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::didOpenURL): (WebCore::Frame::setMetaRefreshEnabled): (WebCore::Frame::setAutoloadImages): (WebCore::Frame::autoloadImages): (WebCore::Frame::clear): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::write): (WebCore::Frame::baseTarget): (WebCore::Frame::completeURL): (WebCore::Frame::scheduleRedirection): (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::changeLocation): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::encoding): (WebCore::Frame::gotoAnchor): (WebCore::Frame::setStandardFont): (WebCore::Frame::setFixedFont): (WebCore::Frame::selectedText): (WebCore::Frame::selection): (WebCore::Frame::dragCaret): (WebCore::Frame::setSelection): (WebCore::Frame::setDragCaret): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::shouldUsePlugin): (WebCore::Frame::loadPlugin): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitForm): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): (WebCore::Frame::executeScript): (WebCore::updateState): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::openURL): (WebCore::Frame::didNotOpenURL): (WebCore::Frame::setEncoding): (WebCore::Frame::saveInterpreterBuiltins): (WebCore::Frame::restoreInterpreterBuiltins): (WebCore::Frame::mutableInstances): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::addMetaData): (WebCore::Frame::scrollToAnchor): (WebCore::Frame::setMediaType): (WebCore::Frame::highlightAllMatchesForString): (WebCore::Frame::tree):
page/Frame.h: (WebCore::Frame::instances):
page/FramePrivate.h:
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::init): (WebCore::FrameView::setMarginWidth): (WebCore::FrameView::setMarginHeight): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::scrollTo): (WebCore::FrameView::setMediaType): (WebCore::FrameView::mediaType): (WebCore::FrameView::setResizingFrameSet): (WebCore::FrameView::setIgnoreWheelEvents):
page/FrameView.h: (WebCore::FrameView::frameWidth): (WebCore::FrameView::marginWidth): (WebCore::FrameView::marginHeight): (WebCore::FrameView::ref): (WebCore::FrameView::deref):
page/ResourceRequest.h: (WebCore::ResourceRequest::contentType): (WebCore::ResourceRequest::setContentType):
platform/FontFamily.h:
platform/Image.h:
platform/KURL.cpp: (KURL::KURL): (KURL::parse): (urlcmp): (KURL::encode_string): (encodeHostname):
platform/KURL.h:
platform/PlatformString.h: (WebCore::String::left): (WebCore::String::right):
platform/String.cpp: (WebCore::String::toInt):
platform/StringImpl.cpp: (WebCore::StringImpl::toInt):
platform/TransferJob.cpp: (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
platform/TransferJob.h:
platform/mac/ImageMac.mm: (WebCore::Image::supportsType):
platform/mac/TransferJobMac.mm: (WebCore::TransferJob::start):
rendering/RenderObject.cpp: (WebCore::RenderObject::information):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement):
xml/xmlhttprequest.cpp: (WebCore::getMIMEType): (WebCore::getCharset): (WebCore::XMLHttpRequest::getReadyState): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
xml/xmlhttprequest.h:

1:27 PM Changeset in webkit [13403] by bdakin

5 edits in trunk/LayoutTests

Reviewed by Adele

I added a close comment tag to this layout test so that the layout
would not longer be affected by the unclosed <style> tag bug since
that is not the original aim of this test anyway.

12:46 PM Changeset in webkit [13402] by ap

7 edits
4 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3439 mouseover effects can get stuck sometimes due to missing events
http://bugzilla.opendarwin.org/show_bug.cgi?id=7701 mouseout sent to the wrong element when layout changes simultaneously

Implemented saving the previous node under the mouse, so that we don't need to
recalculate it, which is slow and even not really possible. This has fixed a number
of issues with mouse event dispatching when the content changes.
The code still needs refactoring and cleanup, see bug 3439 for comments.

Tests (both files perform multiple checks):

fast/events/mouseover-mouseout.html
fast/events/mouseover-mouseout2.html

page/Frame.h: Added a Frame parameter to passSubframeEventToSubframe(), used for mouseMoved events.
bridge/mac/FrameMac.h: Ditto.
bridge/mac/FrameMac.mm: (WebCore::FrameMac::passSubframeEventToSubframe): Use the passed subframe to target NSMouseMoved events.
page/FrameView.h: Added a prepareMouseEvent() helper that does viewportToContents translation.
page/FrameView.cpp: Added data members for storing the previous node and subframe under the mouse to FrameViewPrivate. Removed the now unused prevMouseX/prevMouseY. (WebCore::FrameViewPrivate::reset): Reset the new data members. (WebCore::subframeForEvent): A temporary place for the code that extracts a subframe pointer from MouseEventWithHitTestResults, moved from FrameMac::passSubframeEventToSubframe(). (WebCore::FrameView::prepareMouseEvent): The new helper. (WebCore::FrameView::handleMousePressEvent): Use the new helper. (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto. (WebCore::FrameView::handleMouseReleaseEvent): Ditto. (WebCore::FrameView::updateDragAndDrop): Ditto. (WebCore::FrameView::hoverTimerFired): Ditto. (WebCore::FrameView::dispatchMouseEvent): Store and use the oldUnder node, don't store or use prevMouseX/Y. (WebCore::FrameView::handleMouseMoveEvent): Rewrote dispatching events to subframes using a stored oldSubframe reference. Protect "this" from being removed while in this function.

11:58 AM Changeset in webkit [13401] by bdakin

5 edits
8 moves in trunk/LayoutTests

Reviewed by Adele

Updating pixel results for a few tables tests that have changed
with Hyatt's recent table work. Moving two of said tests into the
expected successes folder because they now completely pass. Yay!

9:04 AM Changeset in webkit [13400] by darin

25 edits
1 add
2 deletes in trunk/WebCore

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7875 autogenerate bindings for Range

dom/Range.idl: Added.
khtml/ecma/kjs_range.cpp: Removed.
khtml/ecma/kjs_range.h: Removed.

WebCore.vcproj/WebCore/build-generated-files.sh: Removed code to generate kjs_range.lut.h.

WebCore.xcodeproj/project.pbxproj: Added Range.idl source file. Removed kjs_range.h and kjs_range.cpp source files. Sorted the "dom" group. Removed rule to generate kjs_range.lut.h.

bindings/js/JSDOMCore.cpp: Added include of JSRange.cpp.

bindings/scripts/CodeGeneratorJS.pm: Added DocumentFragment, Range, CompareHow, and short to the types this script can handle. Added code to generate toRange functions and the like. Added separate code to handle exceptions for getters vs. setters for attributes. Changed return values for the "bad ID" case to 0 -- there's no need to generate the extra code to return jsUndefined() in such cases, which should be unreachable. Changed exception handling to use setDOMException directly instead of DOMExceptionTranslator; DOMExceptionTranslator was a trick to make it easier to convert existing bindings and shouldn't be used going forward. Fixed names of constructors to use the JavaScript class name (the interface name), not the name of the C++ implementation class. Fixed generation of code for functions that have no parameters but do raise exceptions.

bindings/scripts/IDLParser.pm: Added parsing for separate getter and setter exceptions in attributes. The syntax is not real IDL, but real IDL doesn't support declaring exceptions on attributes at all. We'll probably want to revisit our syntax for this some day.

bindings/scripts/IDLStructure.pm: Removed unused exceptionName field from domAttribute, and replaced raisesExceptions field with getterExceptions and setterExceptions. Added regular expressions for parsing getter/setter syntax. We'll probably have to redo this whole thing parse in a better way at some point -- the regular expressions allow any invalid syntax in between them.

dom/Attr.idl: Change exception declaration for setting the value attribute to use setter-specific exception syntax.
dom/CharacterData.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.
dom/ProcessingInstruction.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.

khtml/ecma/kjs_dom.cpp: Include JSRange.h instead of kjs_range.h.
khtml/ecma/kjs_window.cpp: Include JSRange.h instead of kjs_range.h. (KJS::Window::getValueProperty): Use JSRange::getConstructor instead of getRangeConstructor.

1:00 AM Changeset in webkit [13399] by eseidel

4 edits in trunk/WebKitTools

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix win32 build.

Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):

1:00 AM Changeset in webkit [13398] by eseidel

5 edits in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix win32 compile.

Viewer/ImageView.cpp:
platform/GraphicsContext.cpp: (WebCore::WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::WebCore::GraphicsContext::destroyGraphicsContextPrivate):
platform/cairo/GraphicsContextCairo.cpp: (WebCore::fillRectSourceOver): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawFocusRing):
platform/win/FontWin.cpp: (WebCore::Font::drawHighlightForText):

12:03 AM Changeset in webkit [13397] by darin

62 edits
72 copies
1 delete in trunk/WebCore

Rubber stamped by Eric.

moved khtml/html files all into html directory

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new paths.
WebCore.vcproj/WebCore/build-generated-files.sh: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

khtml/html: Removed.

html/DocTypeStrings.gperf: Moved.
html/FormDataList.cpp: Ditto.
html/FormDataList.h: Ditto.
html/HTMLBaseFontElement.cpp: Ditto.
html/HTMLBaseFontElement.h: Ditto.
html/HTMLButtonElement.cpp: Ditto.
html/HTMLButtonElement.h: Ditto.
html/HTMLCanvasElement.cpp: Ditto.
html/HTMLCanvasElement.h: Ditto.
html/HTMLCollection.cpp: Ditto.
html/HTMLCollection.h: Ditto.
html/HTMLDocument.cpp: Ditto.
html/HTMLDocument.h: Ditto.
html/HTMLElement.cpp: Ditto.
html/HTMLElement.h: Ditto.
html/HTMLElementFactory.cpp: Ditto.
html/HTMLElementFactory.h: Ditto.
html/HTMLEntityNames.gperf: Ditto.
html/HTMLFieldSetElement.cpp: Ditto.
html/HTMLFieldSetElement.h: Ditto.
html/HTMLFormCollection.cpp: Ditto.
html/HTMLFormCollection.h: Ditto.
html/HTMLFormElement.cpp: Ditto.
html/HTMLFormElement.h: Ditto.
html/HTMLGenericFormElement.cpp: Ditto.
html/HTMLGenericFormElement.h: Ditto.
html/HTMLInputElement.cpp: Ditto.
html/HTMLInputElement.h: Ditto.
html/HTMLIsIndexElement.cpp: Ditto.
html/HTMLIsIndexElement.h: Ditto.
html/HTMLKeygenElement.cpp: Ditto.
html/HTMLKeygenElement.h: Ditto.
html/HTMLLabelElement.cpp: Ditto.
html/HTMLLabelElement.h: Ditto.
html/HTMLLegendElement.cpp: Ditto.
html/HTMLLegendElement.h: Ditto.
html/HTMLNameCollection.cpp: Ditto.
html/HTMLNameCollection.h: Ditto.
html/HTMLNames.cpp: Ditto.
html/HTMLNames.h: Ditto.
html/HTMLOptGroupElement.cpp: Ditto.
html/HTMLOptGroupElement.h: Ditto.
html/HTMLOptionElement.cpp: Ditto.
html/HTMLOptionElement.h: Ditto.
html/HTMLOptionsCollection.cpp: Ditto.
html/HTMLOptionsCollection.h: Ditto.
html/HTMLParser.cpp: Ditto.
html/HTMLParser.h: Ditto.
html/HTMLSelectElement.cpp: Ditto.
html/HTMLSelectElement.h: Ditto.
html/HTMLTextAreaElement.cpp: Ditto.
html/HTMLTextAreaElement.h: Ditto.
html/HTMLTextFieldInnerElement.cpp: Ditto.
html/HTMLTextFieldInnerElement.h: Ditto.
html/HTMLTokenizer.cpp: Ditto.
html/HTMLTokenizer.h: Ditto.
html/html_baseimpl.cpp: Ditto.
html/html_baseimpl.h: Ditto.
html/html_blockimpl.cpp: Ditto.
html/html_blockimpl.h: Ditto.
html/html_headimpl.cpp: Ditto.
html/html_headimpl.h: Ditto.
html/html_imageimpl.cpp: Ditto.
html/html_imageimpl.h: Ditto.
html/html_inlineimpl.cpp: Ditto.
html/html_inlineimpl.h: Ditto.
html/html_listimpl.cpp: Ditto.
html/html_listimpl.h: Ditto.
html/html_objectimpl.cpp: Ditto.
html/html_objectimpl.h: Ditto.
html/html_tableimpl.cpp: Ditto.
html/html_tableimpl.h: Ditto.

bindings/objc/DOM.mm:
bridge/mac/WebCoreEncodings.mm:
bridge/mac/WebCoreFrameBridge.mm:
css/CSSGrammar.y:
css/cssstyleselector.cpp:
dom/Document.cpp:
dom/EventTargetNode.cpp:
dom/NameNodeList.cpp:
dom/Node.cpp:
dom/Position.cpp:
dom/dom_elementimpl.cpp:
dom/xml_tokenizer.cpp:
editing/ApplyStyleCommand.cpp:
editing/BreakBlockquoteCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteSelectionCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/TextIterator.cpp:
editing/VisiblePosition.cpp:
editing/htmlediting.cpp:
editing/markup.cpp:
editing/visible_units.cpp:
html/CanvasRenderingContext2D.cpp:
kcanvas/KCanvasTreeDebug.cpp:
khtml/ecma/JSDOMParser.cpp:
khtml/ecma/kjs_css.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_events.cpp:
khtml/misc/decoder.cpp:
khtml/xsl/XSLStyleSheet.cpp:
khtml/xsl/XSLTProcessor.cpp:
ksvg2/misc/SVGImageLoader.h:
ksvg2/svg/SVGElement.cpp:
ksvg2/svg/SVGSVGElement.cpp:
kwq/WebCoreAXObject.mm:
page/Frame.cpp:
page/FrameView.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBox.cpp:
rendering/RenderFlow.cpp:
rendering/RenderHTMLCanvas.cpp:
rendering/RenderImage.cpp:
rendering/RenderLayer.cpp:
rendering/RenderObject.cpp:
rendering/RenderTable.cpp:
rendering/RenderTableCell.cpp:
rendering/RenderTableCol.cpp:
rendering/RenderTableRow.cpp:
rendering/RenderTableSection.cpp:
rendering/RenderTextField.cpp:
rendering/RenderTheme.cpp:
rendering/render_applet.cpp:
rendering/render_button.cpp:
rendering/render_frames.cpp:
rendering/render_list.cpp: Updated includes.

Mar 19, 2006:

11:30 PM Changeset in webkit [13396] by eseidel

18 edits in trunk/WebCore

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Move Form code from MacFrame to Frame.
Move GraphicsContext code from GraphicsContextMac to GraphicsContext.
Use IntRect, FloatRect in more places throughout the code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7824

bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::searchForLabelsAboveCell): (WebCore::MacFrame::searchForLabelsBeforeElement): (WebCore::dictionaryFromHashMap): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::setView): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::currentEventIsKeyboardOptionTab): (WebCore::MacFrame::handleKeyboardOptionTabInView): (WebCore::MacFrame::tabsToAllControls): (WebCore::MacFrame::shouldDragAutoNode): (WebCore::MacFrame::selectionImage): (WebCore::MacFrame::snapshotDragImage):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::clearRecordedFormValues): (WebCore::Frame::recordFormValue): (WebCore::Frame::didNotOpenURL): (WebCore::scanForForm): (WebCore::Frame::paint): (WebCore::Frame::prepareForUserAction):
page/Frame.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::setUsesInactiveTextBackgroundColor): (WebCore::GraphicsContext::usesInactiveTextBackgroundColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::printing): (WebCore::GraphicsContext::drawImageAtPoint): (WebCore::GraphicsContext::drawImageInRect): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects):
platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm: (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::selectedTextBackgroundColor): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::drawFocusRing):
rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
rendering/render_image.cpp: (WebCore::RenderImage::paint):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage):

11:25 PM Changeset in webkit [13395] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7854 CanvasGradient leaks

html/CanvasGradient.cpp: (WebCore::CanvasGradient::platformShading): Don't make the CG shading object keep a reference to the DOM gradient object. I got confused because in the case of a CanvasPattern, the pattern does need to keep a reference to the DOM pattern object, but the object lifetime is handled differently here. The CG shading object is used right away, not set in a graphics context.

11:20 PM Changeset in webkit [13394] by darin

4 edits
2 adds in trunk/WebCore

Reviewed by Eric.

attempt to fix the buildbot by handling DOMImplementation another way

WebCore.xcodeproj/project.pbxproj: Added DOMImplementationFront.h/cpp.

bindings/objc/DOMImplementationFront.cpp: Added.
bindings/objc/DOMImplementationFront.h: Added.

bindings/objc/DOMInternal.h: Use DOMImplementationFront, not DOMImplementation.
bindings/objc/DOM.mm: (-[DOMImplementation dealloc]): Ditto. (-[DOMImplementation finalize]): Ditto. (-[DOMImplementation _initWithDOMImplementation:]): Ditto. (+[DOMImplementation _DOMImplementationWith:]): Ditto. (-[DOMImplementation _DOMImplementation]): Ditto. (-[DOMDocument implementation]): Call implementationFront from the DOMImplementationFront header instead of using the real implementation function on the Document.

6:57 PM Changeset in webkit [13393] by darin

453 edits
446 moves in trunk/WebCore

global rename, done by script

<lots of files>: Renamed XXXImpl to XXX, and a number of other renames. See WebKitTools/Scripts/do-webcore-rename version 13392 for details.

5:01 PM Changeset in webkit [13392] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of refinement. Ready to go now, but looks like I'm going to have to wait and do this next week.

10:55 AM Changeset in webkit [13391] by darin

3 edits in trunk/WebKitTools

Reviewed by Anders.

DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that we can test it in layout tests. We don't really need tests that run with pop-up blocking off at the moment. If we do some day, we can add some API for turning it off in the layout test controller.

Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more, don't ignore the leak; it should no longer show up.

10:40 AM Changeset in webkit [13390] by darin

11 edits
8 adds in trunk

LayoutTests:

changed these tests to be expected failures because I had to roll out the fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

fast/js/exception-linenums-in-html-3-expected.txt:
fast/js/exception-linenums-in-html-3-expected.png: Added.
fast/js/exception-linenums-in-html-3-expected.checksum: Added.

fast/js/missing-style-end-tag-js-expected.txt:
fast/js/missing-style-end-tag-js-expected.png: Added.
fast/js/missing-style-end-tag-js-expected.checksum: Added.

fast/tokenizer/missing-style-end-tag-1-expected.checksum:
fast/tokenizer/missing-style-end-tag-1-expected.png:
fast/tokenizer/missing-style-end-tag-1-expected.txt:
fast/tokenizer/missing-style-end-tag-2-expected.checksum:
fast/tokenizer/missing-style-end-tag-2-expected.png:
fast/tokenizer/missing-style-end-tag-2-expected.txt:

added some missing pixel-test results

tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
fast/dom/Element/class-attribute-whitespace-expected.png: Added.
fast/canvas/patternfill-repeat-expected.png: Added.

WebCore:

roll out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

This fix was breaking major sites -- details in the bug report.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Removed the bug fix, added a FIXME about the <title> code that has the same problem.

10:13 AM Changeset in webkit [13389] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round, believe it or not. About ready to go.

8:56 AM Changeset in webkit [13388] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of tweaks after another dry run.

Mar 18, 2006:

10:51 PM Changeset in webkit [13387] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

One more time.

10:48 PM Changeset in webkit [13386] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more fixes for things found during dry runs.

10:31 PM Changeset in webkit [13385] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Did another dry run of the renaming and had to fix a couple of things.

10:05 PM Changeset in webkit [13384] by darin

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7830 <canvas> createPattern 'repeat' options fail

fast/canvas/patternfill-repeat-expected.checksum: Added.
fast/canvas/patternfill-repeat-expected.png: Added.
fast/canvas/patternfill-repeat-expected.txt: Added.
fast/canvas/patternfill-repeat.html: Added.

WebCore:

Test: fast/canvas/patternfill-repeat.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7830 <canvas> createPattern 'repeat' options fail

CanvasPattern.cpp (CanvasPattern::createPattern) Change stepping so that repeat-x, repeat-y, and no-repeat repeat outside the view area by using large values for repeat interval.

10:00 PM Changeset in webkit [13383] by darin

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7761 Tabs in class attribute not treated as whitespace

fast/dom/Element/class-attribute-whitespace-expected.checksum: Added.
fast/dom/Element/class-attribute-whitespace-expected.png: Added.
fast/dom/Element/class-attribute-whitespace-expected.txt: Added.
fast/dom/Element/class-attribute-whitespace.html: Added. NOTE: This test will get broken if "eol-style" processing is done on it.

WebCore:

Test: fast/dom/Element/class-attribute-whitespace.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7761 Tabs in class attribute not treated as whitespace

dom/dom_elementimpl.cpp: (WebCore::isClassWhitespace): Helper function to check if a character in the class attribute should be treated as whitespace. Added \r and \t. (WebCore::NamedMappedAttrMapImpl::parseClassAttribute): Instead of creating a QStringList and iterating it, do everything in one pass over the string.

9:49 PM Changeset in webkit [13382] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6795 Slow image load causes render problem

fast/block/float/vertical-move-relayout-expected.checksum: Added.
fast/block/float/vertical-move-relayout-expected.png: Added.
fast/block/float/vertical-move-relayout-expected.txt: Added.
fast/block/float/vertical-move-relayout.html: Added.

WebCore:

Test: fast/block/float/vertical-move-relayout.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6795 Slow image load causes render problem

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Call markAllDescendantsWithFloatsForLayout when the child's vertical position changes.

9:47 PM Changeset in webkit [13381] by darin

4 edits
12 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

fast/js/exception-linenums-in-html-3-expected.txt: Added.
fast/js/exception-linenums-in-html-3.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <style> tag, which causes the code path for Bug 6314 to be tested.

fast/js/missing-style-end-tag-js-expected.txt: Added.
fast/js/missing-style-end-tag-js.html: Added.

While developing a fix for Bug 6314, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

fast/tokenizer/missing-style-end-tag-1-expected.checksum: Added.
fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
fast/tokenizer/missing-style-end-tag-1-expected.txt: Added.
fast/tokenizer/missing-style-end-tag-1.html: Added.
fast/tokenizer/missing-style-end-tag-2-expected.checksum: Added.
fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
fast/tokenizer/missing-style-end-tag-2-expected.txt: Added.
fast/tokenizer/missing-style-end-tag-2.html: Added.

The first test case contains an unclosed <style> tag in <head>, while the
second test case contains an unclosed <style> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

Test: fast/js/exception-linenums-in-html-3.html
Test: fast/js/missing-style-end-tag-js.html
Test: fast/tokenizer/missing-style-end-tag-1.html
Test: fast/tokenizer/missing-style-end-tag-2.html

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </style> tag and handle this condition if identified.
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </style> tag, reset the state of the tokenizer and retokenize with no special handling for <style>. The parser will handle the missing </style> tag in HTMLParser::handleError().

9:36 PM Changeset in webkit [13380] by darin

3 edits in trunk/WebCore

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5351:
SVG: Safari ignores <title> elements

Make SVGTitleElementImpl act the same as HTMLTitleElementImpl,
in the process setting the title on the right triggers.

ksvg2/svg/SVGTitleElementImpl.cpp: (SVGTitleElementImpl::SVGTitleElementImpl): (SVGTitleElementImpl::title): (SVGTitleElementImpl::closeRenderer): (SVGTitleElementImpl::insertedIntoDocument): (SVGTitleElementImpl::removedFromDocument): (SVGTitleElementImpl::childrenChanged):
ksvg2/svg/SVGTitleElementImpl.h:

9:28 PM Changeset in webkit [13379] by darin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3438

fast/replaced/img-1x1-expected.checksum: Added.
fast/replaced/img-1x1-expected.txt: Added.
fast/replaced/img-1x1.html: Added.
fast/replaced/img-1x1-expected.png: Added.

9:25 PM Changeset in webkit [13378] by darin

17 edits in trunk/LayoutTests

updated test results for tests affected by Hyatt's latest table fix

tables/mozilla/bugs/bug44505-expected.txt:
tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
tables/mozilla_expected_failures/bugs/bug106966-expected.png:
tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:

8:49 PM Changeset in webkit [13377] by darin

2 edits in trunk/WebCore

another try at fixing Windows build

WebCore.vcproj/WebCore/WebCore.vcproj: Added EventTargetNodeImpl.h and .cpp.

8:34 PM Changeset in webkit [13376] by darin

2 edits in trunk/WebCore

another try at fixing Windows build

bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Added EventTargetNodeCast.

8:21 PM Changeset in webkit [13375] by darin

4 edits in trunk/WebCore

try to fix Windows build

bridge/win/FrameWin.h: Remove KURL parameter.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Ditto.
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::canRunModal): Ditto.

8:19 PM Changeset in webkit [13374] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

fix leaks caused by the fix for Bugzilla bug 3560

rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with first-letter pseudo style are children of an existing first-letter inline that has been updated, and should be destroyed.

8:12 PM Changeset in webkit [13373] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more renaming refinements.

1:39 AM Changeset in webkit [13372] by hyatt

8 edits in trunk/WebCore

Fix for bug 7841, tables, table rows, and table row groups should
all support overflow:hidden.

Reviewed by eric

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getOverflowClipRect):
rendering/RenderTable.h:
rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/render_box.cpp: (WebCore::RenderBox::setStyle):
rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer):

Mar 17, 2006:

7:22 PM Changeset in webkit [13371] by aliceli1

2 edits in trunk/WebCore

Reviewed by Hyatt.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6999 "Dynamically added link-tag disables the use of change styles

dynamically"

khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
dynamically added link-tags for stylesheets were messing up the counting of pending stylesheets. If a head link element specifies a new stylesheet but the previously specified stylesheet is still loading, tell the document that stylesheets are loaded so that there are no remaining requests for it to be loaded.

7:19 PM Changeset in webkit [13370] by aliceli1

1 edit
4 adds in trunk/LayoutTests

Reviewed by Justin.

fast/dom/HTMLHeadElement/head-link-style-href-check-expected.checksum: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check-expected.txt: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check.html: Added.

6:04 PM Changeset in webkit [13369] by ggaren

62 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

fast/dom/prototype-chain-expected.txt: Updated to reflect new prototype chain.

WebCore:

Reviewed by Darin.

Fixed some crashes in event dispatch and settled the question of when getDocument() can return NULL, removing superfluous NULL checks.

I promise to check in a test case soon, but I need to land this before
the global rename happens, and I left the test file on my other machine.

Here's what I did:

(1) Removed NULL checks for getDocument() in cases where we know it
should not return NULL (which turned out to be all but one). Replaced
with ASSERT inside getDocument(). Tested to ensure there was no
regression @ albertsons.com.

(2) Added the EventTargetNode class, which represents Nodes that
implement the DOM EventTarget interface. Discussed this design with
Maciej and Hyatt. The previous dsign -- assuming that all Nodes were
EventTargets -- made it possible to crash WebKit by, for example,
dispatching a mouse event to a documentType node that was not
associated with a document.

(3) Reflected (2) into the JS bindings and touched JSDOMCore.cpp to
force a re-build.

(4) Using classInfo checking, strengthened type constraints on
JavaScript method dispatch so that you can't finagle JavaScript into,
for example, invoking a document-dependent method belonging to a
node type that's guaranteed to have a document on a node type that may
not have one.

(5) Pushed some IE-specific JS bindings that depend on a node having a
document down from DOMNode to DOMElement. (An element always has a
document.) Tested that Firefox's behavior matched. Confirmed with MSDN.

(6) Updated Objc bindigns to throw an exception if you try to use
the event interface on a node that doesn't support it. Discussed this
design with Maciej and TimH.

(7) Consolidated repeated documentElement-finding code in the Position
class into the Position::documentElement() method. Did the same for
repeated top-level document finding and DocumentImpl::topDocument().

WebCore+SVG/KDOMHeaders.h:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMCore.cpp:
bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMNode KJS::Bindings::]):
bridge/mac/MacFrame.mm: (WebCore::MacFrame::keyEvent): (WebCore::MacFrame::dispatchCPPEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
css/css_base.cpp: (WebCore::StyleBaseImpl::baseURL):
css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclarationImpl::removeProperty): (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
dom/Attr.idl:
dom/CharacterData.idl:
dom/CharacterDataImpl.cpp: (WebCore::CharacterDataImpl::CharacterDataImpl): (WebCore::CharacterDataImpl::rendererIsNeeded): (WebCore::CharacterDataImpl::dump):
dom/CharacterDataImpl.h:
dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::attach): (WebCore::ContainerNodeImpl::detach): (WebCore::ContainerNodeImpl::insertedIntoDocument): (WebCore::ContainerNodeImpl::removedFromDocument): (WebCore::ContainerNodeImpl::insertedIntoTree): (WebCore::ContainerNodeImpl::removedFromTree): (WebCore::ContainerNodeImpl::setFocus): (WebCore::ContainerNodeImpl::setActive): (WebCore::ContainerNodeImpl::setHovered): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
dom/ContainerNodeImpl.h:
dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::removeAllEventListenersFromAllNodes): (WebCore::DocumentImpl::removeAllDisconnectedNodeEventListeners): (WebCore::DocumentImpl::getAccObjectCache): (WebCore::DocumentImpl::setFocusNode): (WebCore::DocumentImpl::topDocument):
dom/Element.idl:
dom/EventTargetNodeImpl.cpp: Added. (WebCore::EventTargetNodeImpl::EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::~EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::insertedIntoDocument): (WebCore::EventTargetNodeImpl::removedFromDocument): (WebCore::EventTargetNodeImpl::addEventListener): (WebCore::EventTargetNodeImpl::removeEventListener): (WebCore::EventTargetNodeImpl::removeAllEventListeners): (WebCore::EventTargetNodeImpl::handleLocalEvents): (WebCore::EventTargetNodeImpl::dispatchGenericEvent): (WebCore::EventTargetNodeImpl::dispatchEvent): (WebCore::EventTargetNodeImpl::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNodeImpl::dispatchWindowEvent): (WebCore::EventTargetNodeImpl::dispatchUIEvent): (WebCore::EventTargetNodeImpl::dispatchKeyEvent): (WebCore::EventTargetNodeImpl::dispatchMouseEvent): (WebCore::EventTargetNodeImpl::dispatchSimulatedMouseEvent): (WebCore::EventTargetNodeImpl::dispatchWheelEvent): (WebCore::EventTargetNodeImpl::dispatchHTMLEvent): (WebCore::EventTargetNodeImpl::removeHTMLEventListener): (WebCore::EventTargetNodeImpl::setHTMLEventListener): (WebCore::EventTargetNodeImpl::getHTMLEventListener): (WebCore::EventTargetNodeImpl::disabled): (WebCore::EventTargetNodeImpl::defaultEventHandler): (WebCore::EventTargetNodeImpl::dump):
dom/EventTargetNodeImpl.h: Added. (WebCore::EventTargetNodeImpl::isEventTargetNode): (WebCore::EventTargetNodeImpl::preDispatchEventHandler): (WebCore::EventTargetNodeImpl::postDispatchEventHandler): (WebCore::EventTarget): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
dom/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): (WebCore::NodeImpl::~NodeImpl): (WebCore::NodeImpl::dump): (WebCore::NodeImpl::detach): (WebCore::NodeImpl::insertedIntoDocument): (WebCore::NodeImpl::removedFromDocument):
dom/NodeImpl.h: (WebCore::NodeImpl::isEventTargetNode): (WebCore::NodeImpl::isLink): (WebCore::NodeImpl::getDocument): (WebCore::NodeImpl::inDocument):
dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEventImpl::receivedTarget):
dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::commonAncestorContainer):
dom/dom_elementimpl.cpp: (WebCore::inHTMLDocument): (WebCore::ElementImpl::focus): (WebCore::ElementImpl::blur): (WebCore::StyledElementImpl::parseMappedAttribute):
dom/dom_position.cpp: (WebCore::Position::documentElement):
dom/dom_position.h:
editing/ReplaceSelectionCommand.cpp: (WebCore::computeAndStoreNodeDesiredStyle):
editing/SelectionController.cpp: (WebCore::SelectionController::needsCaretRepaint):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfDocument): (WebCore::endOfDocument):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::): (KJS::DOMDocument::DOMDocument): (KJS::DOMDocument::getOwnPropertySlot): (KJS::DOMDocument::put): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::DOMElement): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::put): (KJS::DOMElement::putValueProperty): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMEventTargetNode::): (KJS::DOMElement::):
khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::getNodeEventListener):
khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::bodySetter):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::registerFormElement): (WebCore::HTMLFormElementImpl::removeFormElement):
khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::insertedIntoTree):
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::~HTMLInputElementImpl): (WebCore::HTMLInputElementImpl::focus):
khtml/html/HTMLOptionElementImpl.cpp: (WebCore::HTMLOptionElementImpl::text):
khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl):
khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::~HTMLTextAreaElementImpl):
khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::insertedIntoDocument): (WebCore::HTMLFrameElementImpl::isURLAllowed): (WebCore::HTMLFrameElementImpl::openURL): (WebCore::HTMLFrameElementImpl::frameWidth): (WebCore::HTMLFrameElementImpl::frameHeight):
khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): (WebCore::HTMLMapElementImpl::~HTMLMapElementImpl):
khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchRecursiveEvent):
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGImageElementImpl.cpp:
ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent):
kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]): (-[KWQAccObject accessibilityPerformAction:]):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]):
page/Frame.cpp: (WebCore::dispatchKHTMLEditableContentChanged):
page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::viewportWheelEvent):
rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset):
rendering/render_object.cpp: (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::backslashAsCurrencySymbol):
rendering/render_replaced.cpp: (WebCore::RenderWidget::sendConsumedMouseUp):

5:24 PM Changeset in webkit [13368] by bdakin

1 edit
4 moves in trunk/LayoutTests

Reviewed by hyatt

This test should actually be in the failures folder. Moving.

5:05 PM Changeset in webkit [13367] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla/marvin/backgr_layers-opacity-expected.txt

Update the table opacity test case to reflect the now-correct results.

5:01 PM Changeset in webkit [13366] by hyatt

9 edits in trunk/WebCore

Fix for 7837, make opacity work with table rows. Make transparent backgrounds
stack properly in cells (so that the layers behind can show through like they
should).

Reviewed by beth

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
rendering/RenderTableCell.h:
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::transparentAncestor): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::absoluteBoundingBox):
rendering/render_object.cpp: (WebCore::RenderObject::requiresLayer):
rendering/render_object.h: (WebCore::RenderObject::isTransparent): (WebCore::RenderObject::opacity):

2:03 PM Changeset in webkit [13365] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

fixed "charAt layout test fails on intel macs; some NaNs are printed as -NaN" http://bugzilla.opendarwin.org/show_bug.cgi?id=7745

kjs/ustring.cpp: (KJS::UString::from): Use "NaN" for all NaN values, regardless of sign.

1:58 PM Changeset in webkit [13364] by mjs

13 edits in trunk/WebCore

Reviewed by Adele.

clean up ResourceRequest to be closer to a proper request interface

page/ResourceRequest.h: folded URL into ResourceRequest, other cleanup (WebCore::ResourceRequest::ResourceRequest): Add new explicit constructor that takes a KURL. (WebCore::ResourceRequest::url): getter for KURL (WebCore::ResourceRequest::setURL): corresponding setter (WebCore::ResourceRequest::referrer): new getter for referrer, instead of storing it in m_metaData (it was the only remaining real use of it) (WebCore::ResourceRequest::setReferrer): corresponding setter
bridge/BrowserExtension.h:
removed unused openURLRequest and openURLNotify methods
folded KURL parameter into ResourceRequest
bridge/mac/BrowserExtensionMac.h: remove KURL args from methods that also take a ResourceRequest
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): adjust for ResourceRequest changes.
bridge/mac/MacFrame.h: remove KURL args from methods that also take a ResourceRequest
bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLRequest): adjust for ResourceRequest changes (WebCore::MacFrame::submitForm): ditto (WebCore::MacFrame::urlSelected): ditto
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): adjust for ResourceRequest changes
bridge/win/BrowserExtensionWin.h:
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): adjust for ResourceRequest changes (KJS::WindowFunc::callAsFunction): ditto
page/Frame.cpp: (WebCore::Frame::didOpenURL): adjust for ResourceRequest changes (WebCore::Frame::receivedFirstData): ditto (WebCore::Frame::begin): ditto (WebCore::Frame::completeURL): ditto (WebCore::Frame::changeLocation): ditto (WebCore::Frame::urlSelected): ditto (WebCore::Frame::requestFrame): ditto (WebCore::Frame::submitForm): ditto
page/Frame.h:
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): ditto

12:32 PM Changeset in webkit [13363] by bdakin

5 edits
2 adds in trunk

Reviewed by Darin, landed by Beth.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7693 WebKit relies on unpredictable timing for onload events

12:11 PM Changeset in webkit [13362] by sullivan

2 edits in trunk/WebKit

Reviewed by Beth Dakin

fixed <rdar://problem/4239051> Sometimes "Copy Link" in Safari results in a URL on the pasteboard with no usable "title"

History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): trim whitespace from titles that are put on pasteboard. This leaves an empty string for the title in cases where there's no displayed text, like an image in an <a> element that happens to have whitespace in the source, e.g. <a href="foo"> <img whatever></a>

12:02 PM Changeset in webkit [13361] by adele

7 edits in trunk/LayoutTests

Updated results for background color change.

fast/forms/input-appearance-focus-expected.txt:
fast/forms/input-appearance-minWidth-expected.txt:
fast/forms/input-appearance-selection-expected.txt:
fast/forms/input-appearance-visibility-expected.txt:
fast/forms/input-appearance-width-expected.txt:
fast/forms/input-baseline-expected.txt:

11:42 AM Changeset in webkit [13360] by bdakin

1 edit
62 adds in trunk/LayoutTests

Reviewed by Geoff

A few more mozilla table tests.

11:20 AM Changeset in webkit [13359] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
fast/forms/input-appearance-default-bkcolor-expected.png: Added.
fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
fast/forms/input-appearance-default-bkcolor.html: Added.

WebCore:

Reviewed by Tim H.

Make default backgrounds for new text fields white
instead of transparent. This will move to html4.css
when we flip the switch.

Test added:

fast/forms/input-appearance-default-bkcolor.html

rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustTextFieldStyle):

11:06 AM Changeset in webkit [13358] by hyatt

2 edits in trunk/WebCore

Make table sections and table captions support opacity.

Reviewed by darin

Covered by some of the new Mozilla table tests.

rendering/RenderTable.cpp: (WebCore::RenderTable::paint):

10:39 AM Changeset in webkit [13357] by hyatt

2 adds
4 deletes in trunk/LayoutTests/tables

Fix table test that now passes.

9:47 AM Changeset in webkit [13356] by bdakin

6 edits
4 adds in trunk

Reviewed by Maciej, landed by Beth.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3560
page with use of first-letter crashes reproducibly in
RenderObject::renderArena()

9:42 AM Changeset in webkit [13355] by darin

2 edits in trunk/WebKit

missing bit of my check-in yesterday

Maciej moved setWindowFrame for me, but I also had removed
setWindowContentRect.

WebCoreSupport/WebFrameBridge.m: Removed unused setWindowContextRect and windowContentRect methods.

6:06 AM Changeset in webkit [13354] by eseidel

2 edits in trunk/WebKitLibraries

2006-03-17 Eric Seidel <eseidel@apple.com>

libWebKitSystemInterface.a: commit a universal binary.

4:36 AM Changeset in webkit [13353] by andersca

2 edits in trunk/WebKitTools

2006-03-17 Anders Carlsson <andersca@mac.com>

Reviewed by Eric.

Scripts/install-win-extras: Fetch "Program Files" location from the environment.

3:06 AM Changeset in webkit [13352] by adele

24 edits in trunk

LayoutTests:

Reviewed by Eric.

Updating test results for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7798
New text fields are much wider than they should be for a specified size

fast/forms/input-appearance-bkcolor-expected.checksum:
fast/forms/input-appearance-bkcolor-expected.png:
fast/forms/input-appearance-bkcolor-expected.txt:
fast/forms/input-appearance-focus-expected.checksum:
fast/forms/input-appearance-focus-expected.png:
fast/forms/input-appearance-focus-expected.txt:
fast/forms/input-appearance-minWidth-expected.checksum:
fast/forms/input-appearance-minWidth-expected.png:
fast/forms/input-appearance-minWidth-expected.txt:
fast/forms/input-appearance-selection-expected.checksum:
fast/forms/input-appearance-selection-expected.png:
fast/forms/input-appearance-selection-expected.txt:
fast/forms/input-appearance-visibility-expected.checksum:
fast/forms/input-appearance-visibility-expected.png:
fast/forms/input-appearance-visibility-expected.txt:
fast/forms/input-appearance-width-expected.checksum:
fast/forms/input-appearance-width-expected.png:
fast/forms/input-appearance-width-expected.txt:
fast/forms/input-baseline-expected.checksum:
fast/forms/input-baseline-expected.png:
fast/forms/input-baseline-expected.txt:

WebCore:

Reviewed by Eric.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7798 New text fields are much wider than they should be for a specified size

I changed the character we use to calculate the width from "w" back to "0",
which matches our old behavior. The original change was intentional, to try
to better match other browsers, but "w" is a little too wide. For now, lets
go back to the old behavior.

I also set the minWidth = maxWidth. We were trying to match a WinIE quirk,
but that caused some odd behavior with growth of the text field in table cells.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):

3:00 AM Changeset in webkit [13351] by eseidel

2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Fix Spinneret to pass Events as const & not as pointers.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress):

2:47 AM Changeset in webkit [13350] by eseidel

8 edits
2 adds in trunk/WebCore

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Fix win32 build.
Add PageWin class.
Add previously forgotten KeyEventWin class.
Pass MouseEvent() instead of 0 in a couple places to make compiler happy.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::keyPress):
bridge/win/FrameWin.h:
bridge/win/PageWin.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::hoverTimerFired):
page/Page.h: (WebCore::Page::mainFrame):
platform/win/KeyEventWin.cpp: Added. (WebCore::KeyEvent::KeyEvent):
platform/win/TemporaryLinkStubs.cpp: (WebCore::findNextWordFromIndex): (FrameWin::passMouseDownEventToWidget): (FrameWin::scheduleClose): (BrowserExtensionWin::createNewWindow): (WebCore::findWordBoundary): (FrameWin::registerCommandForUndo): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::respondToChangedContents):

2:40 AM Changeset in webkit [13349] by eseidel

2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Add support for basic HTML editing.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::keyPress):

2:28 AM Changeset in webkit [13348] by adele

3 edits in trunk/WebKitLibraries

WebKitSystemInterface.h: Added WKDrawBezeledTextFieldCell()
libWebKitSystemInterface.a: ditto

2:16 AM Changeset in webkit [13347] by hyatt

2 edits in trunk/WebCore

Fix pixel test regression in fast/table/overflowHidden.html. There was
a borderTopExtra error made in the new boundingBox code for layers that
caused the bottom half of cells with opacity set to be clipped out.

Reviewed by andersca

rendering/render_layer.cpp: (WebCore::RenderLayer::absoluteBoundingBox):

1:50 AM Changeset in webkit [13346] by hyatt

25 edits in trunk/WebCore

Give table rows and sections accurate dimensions. Fix absolutePosition
to work for table cells properly. Add an absolutePositionForContent method
to make sure callers that want to deal with the content of a cell handle
the cell's extra space correctly.

Reviewed by darin

Existing layout tests cover this change.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): (WebCore::ContainerNodeImpl::getLowerRightCorner):
dom/NodeImpl.cpp: (WebCore::NodeImpl::getRect):
editing/SelectionController.cpp: (WebCore::SelectionController::layout): (WebCore::SelectionController::caretRect):
editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::defaultEventHandler):
kwq/KWQRenderTreeDebug.cpp: (operator<<):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): (WebCore::RenderBlock::positionForCoordinates):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::nodeAtPoint):
rendering/RenderTableRow.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderTableSection.h:
rendering/RenderText.cpp: (WebCore::RenderText::lineBoxRects): (WebCore::RenderText::positionForCoordinates): (WebCore::RenderText::caretRect): (WebCore::RenderText::posOfChar): (WebCore::RenderText::selectionRect):
rendering/render_box.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::caretRect):
rendering/render_br.cpp: (WebCore::RenderBR::caretRect):
rendering/render_canvas.h:
rendering/render_flow.cpp: (WebCore::RenderFlow::caretRect):
rendering/render_frames.cpp: (WebCore::RenderPart::updateWidgetPosition):
rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition):
rendering/render_object.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::absolutePosition):
rendering/render_object.h: (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::offsetHeight):
rendering/render_replaced.cpp: (WebCore::RenderWidget::updateWidgetPosition):

1:13 AM Changeset in webkit [13345] by eseidel

5 edits
6 copies
1 add in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Rubber-stamped by ggaren.

Break DumpRenderTree.m up into several files to make the code more readable.

DumpRenderTree/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.m: (doneLoading): new accessor function for "done" global.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeDraggingInfo.h: Added.
DumpRenderTree/DumpRenderTreeDraggingInfo.m: Added.
DumpRenderTree/EditingDelegate.h: Added.
DumpRenderTree/EditingDelegate.m: Added. (-[EditingDelegate webViewDidChangeSelection:]):
DumpRenderTree/EventSendingController.h: Added.
DumpRenderTree/EventSendingController.m: Added.

1:10 AM Changeset in webkit [13344] by adele

10 edits
6 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

fast/forms/input-appearance-bkcolor-expected.checksum: Added.
fast/forms/input-appearance-bkcolor-expected.png: Added.
fast/forms/input-appearance-bkcolor-expected.txt: Added.
fast/forms/input-appearance-bkcolor.html: Added.
fast/forms/resources
fast/forms/resources/apple.gif

WebCore:

Reviewed by Hyatt.

WebCore part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Bezeled NSTextFieldCells always draw a background, so instead we'll use a new
WebKitSystemInterface function to just draw the border of the cell.

Since the theme is drawing the border and the engine is drawing the background
(which is different from the other form controls), we have to make sure we let the
theme paint the border after the engine paints the background.

platform/mac/WebCoreGraphicsBridge.h:
platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawBezeledTextFieldCell:enabled:]):
rendering/render_box.cpp: (WebCore::RenderBox::paintBoxDecorations):
rendering/render_theme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorder): (WebCore::RenderTheme::shouldPaintBorder):
rendering/render_theme.h:
rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::setTextFieldCellState):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Added function to draw bezeled text field without drawing background.

WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawBezeledTextFieldCell:enabled:]): Added.

Mar 16, 2006:

11:45 PM Changeset in webkit [13343] by mjs

3 edits in trunk/WebKit

Reviewed by Eric.

move setWindowFrame / windowFrame to WebPageBridge to fix build

WebCoreSupport/WebFrameBridge.m:
WebCoreSupport/WebPageBridge.m: (-[WebPageBridge setWindowFrame:]): (-[WebPageBridge windowFrame]):

4:19 PM Changeset in webkit [13342] by darin

33 edits
1 add
3 deletes in trunk/WebCore

Reviewed by Eric.

removed KWQWindowWidget
changed most event handling to use references instead of pointers
chagned PageMac to no longer be a subclass of Page

Yes, I know there's no detail in this ChangeLog entry.
No, I don't plan to make a habit of doing things this way.
Yes, this will probably break the Windows build again.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameViewMac.mm:
bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::~MacFrame): (WebCore::MacFrame::wheelEvent): (WebCore::MacFrame::keyEvent): (WebCore::MacFrame::khtmlMousePressEvent): (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::khtmlMouseReleaseEvent): (WebCore::MacFrame::mouseDown): (WebCore::MacFrame::mouseDragged): (WebCore::MacFrame::mouseUp): (WebCore::MacFrame::mouseMoved): (WebCore::MacFrame::sendContextMenuEvent): (WebCore::MacFrame::setBridge): (WebCore::MacFrame::dragSourceMovedTo): (WebCore::MacFrame::dragSourceEndedAt): (WebCore::MacFrame::dispatchDragSrcEvent):
bridge/mac/PageMac.h: Removed.
bridge/mac/PageMac.mm: Added. (WebCore::Page::Page): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge page]): (-[WebCoreFrameBridge initializeSettings:]): (globalPoint): (createMouseEventFromDraggingInfo): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
bridge/mac/WebCoreFrameNamespaces.mm: (WebCore::):
bridge/mac/WebCorePageBridge.h:
bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge init]):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::defaultEventHandler):
dom/DocumentImpl.h:
dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): (WebCore::NodeImpl::dispatchKeyEvent): (WebCore::NodeImpl::dispatchWheelEvent):
dom/NodeImpl.h:
dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEventImpl::KeyboardEventImpl):
dom/dom2_eventsimpl.h: (WebCore::KeyboardEventImpl::keyEvent):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::WindowFunc::callAsFunction):
khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: Removed.
page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::khtmlMousePressEvent): (WebCore::Frame::handleMouseMoveEventSelection): (WebCore::Frame::khtmlMouseMoveEvent): (WebCore::Frame::khtmlMouseReleaseEvent): (WebCore::Frame::khtmlMouseDoubleClickEvent): (WebCore::Frame::passWidgetMouseDownEventToWidget):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::viewportMousePressEvent): (WebCore::FrameView::viewportMouseDoubleClickEvent): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::viewportWheelEvent):
page/FrameView.h:
page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults): (WebCore::MouseEventWithHitTestResults::event):
page/Page.cpp: (WebCore::Page::init):
page/Page.h: (WebCore::Page::bridge):
platform/KeyEvent.h: (WebCore::KeyEvent::isAutoRepeat):
platform/MouseEvent.h: (WebCore::MouseEvent::MouseEvent):
platform/mac/KeyEventMac.mm: (WebCore::KeyEvent::KeyEvent):
platform/win/TemporaryLinkStubs.cpp: (FrameView::isFrameView):
rendering/render_form.cpp: (WebCore::RenderFormElement::clicked):

4:13 PM Changeset in webkit [13341] by bdakin

1 edit
848 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Another round of Mozilla table tests.

3:08 PM Changeset in webkit [13340] by eseidel

14 edits
1 add in trunk/WebCore

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add additional hackish Font, focusring and caret code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7803

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
bindings/js/JSCanvasRenderingContext2DBase.cpp:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
bridge/win/FrameWin.h:
html/CanvasRenderingContext2D.h:
platform/IntSize.h:
platform/KeyEvent.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawFocusRing):
platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::convertRange): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint): (WebCore::Font::drawLineForText): (WebCore::Font::misspellingLineThickness):
platform/win/IntSizeWin.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator SIZE):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRect):
platform/win/TemporaryLinkStubs.cpp: (Widget::disableFlushDrawing): (GraphicsContext::GraphicsContext): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (FrameWin::locationbarVisible): (FrameWin::canUndo): (FrameWin::mimeTypeForFileName): (FrameWin::issueTransposeCommand): (RenderCanvasImage::setNeedsImageUpdate): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::clearRecordedFormValues): (FrameWin::recordFormValue): (BrowserExtensionWin::getHistoryLength): (Widget::setIsSelected): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::addRoundedRectClip): (QScrollBar::QScrollBar): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setFont):
rendering/render_canvasimage.h:

3:06 PM Changeset in webkit [13339] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

tweaks to my change to redo KJS::Node refcounting

kjs/nodes.cpp: (Node::ref): (Node::deref): (Node::refcount): (Node::clearNewNodes):
kjs/nodes.h:

3:05 PM Changeset in webkit [13338] by eseidel

3 edits in trunk/WebKitTools

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add resize, scroll event support.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

3:00 PM Changeset in webkit [13337] by mjs

12 edits
1 copy in trunk/WebCore

Reviewed by Eric.

renamed URLArgs to ResourceRequest, split it into its own header
moved methods to get and set ResourceRequest to Frame

WebCore.xcodeproj/project.pbxproj:
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::openURLRequest): (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLRequest): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::urlSelected):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::receivedFirstData): (WebCore::Frame::setResourceRequest): (WebCore::Frame::resourceRequest): (WebCore::Frame::begin): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
page/Frame.h:
page/FramePrivate.h:
page/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::contentType): (WebCore::ResourceRequest::setContentType): (WebCore::ResourceRequest::doPost): (WebCore::ResourceRequest::setDoPost): (WebCore::ResourceRequest::lockHistory): (WebCore::ResourceRequest::setLockHistory): (WebCore::ResourceRequest::metaData):

1:24 PM Changeset in webkit [13336] by bdakin

1 edit
680 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Still adding more mozilla table tests.

10:54 AM Changeset in webkit [13335] by bdakin

1 edit
143 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Adding more mozilla table tests.

1:28 AM Changeset in webkit [13334] by darin

2 edits in trunk/WebCore

need to touch one more file to fix the build (Darn the lack of dependencies for autogenerated bindings!)

dom/Element.idl: Touch. (Really this time.)

1:21 AM Changeset in webkit [13333] by eseidel

2 edits in trunk/WebKitTools

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make build-webkit print correctly to stdout on windows.

Scripts/webkitdirs.pm: Fix to use devenv.com instead of devenv.exe

1:11 AM Changeset in webkit [13332] by darin

1 edit in trunk/WebCore/ChangeLog

need to touch one more file to fix the build (Darn the lack of dependencies for autogenerated bindings!)

dom/Element.idl: Touch.

12:59 AM Changeset in webkit [13331] by eseidel

7 edits in trunk/WebCore

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Pushed focus ring handling down into GraphicsContext.cpp

bridge/mac/MacFrame.mm: (WebCore::MacFrame::mouseDown):
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect):
platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::drawFocusRing):
rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects):
rendering/render_object.cpp: (WebCore::RenderObject::addFocusRingRects):

12:54 AM Changeset in webkit [13330] by darin

12 adds in trunk/WebCore/html

Oops, these files were supposed to go in.

12:41 AM Changeset in webkit [13329] by darin

43 edits
3 adds in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7749 canvas should be in DOM, not implemented in the JS bindings

WebCore.xcodeproj/project.pbxproj: Added new files. Changed bindings-generation code to work on the new html directory as well as the dom one.

bindings/js/JSCanvasRenderingContext2DBase.cpp: Added.
bindings/js/JSCanvasRenderingContext2DBase.h: Added.
bindings/js/JSDOMHTML.cpp: Added.
html: Added.
html/CanvasGradient.cpp: Added.
html/CanvasGradient.h: Added.
html/CanvasGradient.idl: Added.
html/CanvasPattern.cpp: Added.
html/CanvasPattern.h: Added.
html/CanvasPattern.idl: Added.
html/CanvasRenderingContext2D.cpp: Added.
html/CanvasRenderingContext2D.h: Added.
html/CanvasRenderingContext2D.idl: Added.
html/CanvasStyle.cpp: Added.
html/CanvasStyle.h: Added.

bindings/js/JSDOMCore.cpp: Touched so that it will recompile.
bindings/js/JSDOMEvents.cpp: Ditto.
dom/Attr.idl: Ditto.
dom/DOMImplementation.idl: Ditto.
dom/DocumentType.idl: Ditto.
dom/MutationEvent.idl: Ditto.
dom/ProcessingInstruction.idl: Ditto.
dom/Text.idl: Ditto.

khtml/ecma/kjs_binding.h: (KJS::toJS): Added. Template so that you can call toJS on a PassRefPtr as well as on a raw pointer.

bindings/scripts/CodeGeneratorJS.pm: Fixed handling of a class that has only a legacy parent, no conventional parents. Added JSCanvasRenderingContext2DBase as a legacy parent, and html as a legacy module. Added CanvasRenderingContext2D, CanvasGradient, and CanvasPattern to the "waht to include". Added a special case for strings beginning with Canvas to not add an "Impl" suffix. Made the generated impl() function be a const member function. Made m_mimpl be private instead of protected. Generate a toJS function for each class. Added flaot as a type. Generate String, not DOMString. Made the HashTable const.

bindings/scripts/IDLParser.pm: Fix a couple small things. I had started to try to make a missing semicolon trigger an error, but ended up giving up on that for now.

khtml/html/html_canvasimpl.h:
khtml/html/html_canvasimpl.cpp: (WebCore::HTMLCanvasElementImpl::HTMLCanvasElementImpl): Set m_2DContext to 0. (WebCore::HTMLCanvasElementImpl::~HTMLCanvasElementImpl): Call detachCanvas on m_2DContext, if any. (WebCore::HTMLCanvasElementImpl::detach): Call reset on m_2DContext, if any. (WebCore::HTMLCanvasElementImpl::getContext): Added. (WebCore::HTMLCanvasElementImpl::size): Added. (WebCore::HTMLCanvasElementImpl::createPlatformImage): Added.

platform/Image.h:
platform/Image.cpp: (WebCore::Image::compositeOperatorFromString): Changed to take a String instead of a const char*.

khtml/html/html_imageimpl.h:
khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::areas): Tweaked formatting. Changed to use PassRefPtr.

bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMStyleSheet::getValueProperty): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::DOMCSSValueList::indexGetter): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMRect::getValueProperty):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNodeListFunc::callAsFunction): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMNamedNodesCollection::indexGetter):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode): (KJS::DOMEvent::getValueProperty): (KJS::toJS): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMMouseEvent::getValueProperty):
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLDocument::put): (KJS::HTMLDocument::putValueProperty): (KJS::HTMLElement::classInfo): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::implementsCall): (KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optionGetter): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::toString): (KJS::HTMLElement::pushEventHandlerScope): (KJS::toJS): (KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLElement::put): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::callAsFunction): (KJS::HTMLCollection::getNamedItems): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::put): (KJS::OptionConstructorImp::construct): (KJS::ImageConstructorImp::construct):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::toJS):
khtml/ecma/kjs_range.h:
khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction): (KJS::JSNodeFilterCondition::acceptNode):
khtml/ecma/kjs_traversal.h:
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::getValueProperty): (KJS::DOMAbstractViewProtoFunc::callAsFunction): (KJS::toJS):
khtml/ecma/kjs_views.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Selection::getValueProperty): (KJS::SelectionFunc::callAsFunction): Rename uses and definitions of all the various converstions to JavaScript wrappers to the new common overloaded name: "toJS".

12:40 AM Changeset in webkit [13328] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed Vector so that you can pass a reference to something in the vector to the append or insert functions

kxmlcore/Vector.h: (KXMLCore::Vector::expandCapacity): Added new overloads that take a pointer to adjust and return the adjusted value of the pointer. (KXMLCore::Vector::append): Pass a pointer when expanding the vector, and use it when adding the new element. Makes the case where the element moves when the vector is expanded work. (KXMLCore::Vector::insert): Ditto.

12:10 AM Changeset in webkit [13327] by eseidel

8 edits in trunk/WebCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Push more of MacFrame down into Frame.
Add visibleContentRect method to ScrollView.

bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::imageFromRect): (WebCore::MacFrame::setDisplaysWithFocusAttributes): (WebCore::MacFrame::bodyBackgroundColor):
bridge/mac/WebCoreFrameBridge.mm:
page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setDisplaysWithFocusAttributes):
page/Frame.h:
platform/ScrollView.h:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::inWindow):

Mar 15, 2006:

11:15 PM Changeset in webkit [13326] by eseidel

5 edits in trunk/WebCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove unused code and clean-up style.

bridge/mac/MacFrame.mm: (WebCore::MacFrame::advanceToNextMisspelling): (WebCore::MacFrame::wheelEvent): (WebCore::MacFrame::nextKeyViewInFrame): (WebCore::MacFrame::nextKeyViewInFrameHierarchy): (WebCore::MacFrame::nextKeyView):
page/Frame.cpp:
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent):

10:21 PM Changeset in webkit [13325] by eseidel

15 edits
2 adds in trunk

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7790
addEventListener does not work with "dblclick" event.
Renamed khtmlDblclickEvent to dblclickEvent to fix.

Test: fast/events/dblclick-addEventListener.html

WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::mouseUp): (WebCore::MacFrame::mouseMoved): (WebCore::MacFrame::shouldDragAutoNode): (WebCore::MacFrame::sendContextMenuEvent):
dom/EventNames.h:
dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent):
dom/NodeImpl.h:
khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::parseMappedAttribute):
page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent):
page/FrameView.h:

10:12 PM Changeset in webkit [13324] by ap

5 edits
4 adds in trunk

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4395 REGRESSION: document.open doesn't clear the document

Test: fast/dom/Document/document-reopen.html
Test: fast/dom/Document/doc-open-while-parsing.html

dom/DocumentImpl.cpp: (WebCore::DocumentImpl::open): Only ignore open() while the frame is still loading the main resource.
page/Frame.cpp: (WebCore::Frame::isComplete): Added const specifier. (WebCore::Frame::isLoadingMainResource): New function.
page/Frame.h:

8:53 PM Changeset in webkit [13323] by darin

2 edits in trunk/WebKitTools

Reviewed by Maciej.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fix path that had a lowercase "i" in it so this builds on case-sensitive file systems.

7:44 PM Changeset in webkit [13322] by darin

5 deletes in trunk

Removed a few stray .cvsignore files that crept in.

6:00 PM Changeset in webkit [13321] by bdakin

1 edit
182 adds in trunk/LayoutTests

Rubber stamped by Geoff.

even more mozilla table tests.

5:44 PM Changeset in webkit [13320] by ggaren

1 edit
2 adds in trunk/WebKitTools

Reviewed by Eric.

Added run-testkjs and compare-timing-files scripts, to support super
accurate JS iBench.

Scripts/compare-timing-files: Added.
Scripts/run-testkjs: Added.

5:15 PM Changeset in webkit [13319] by darin

2 edits in trunk/WebKit

Fix by Patrick Beard, reviewed by me.

fix <rdar://problem/4478181> WebPluginController leaks NSArray and NSMutableSet objects

Plugins/WebPluginController.m: (-[WebPluginController initWithDocumentView:]): Call CFMakeCollectable on the CFSet so we can act like it's an NSSet. (-[WebPluginController dealloc]): Release _views and _checksInProgress.

4:44 PM Changeset in webkit [13318] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Build fix.

kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): use size() not "len()"

4:40 PM Changeset in webkit [13317] by adele

5 edits in trunk/WebCore

Reviewed by Eric.

Fixes win32 build.

page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Calls isMouseButtonDown instead of CG function.
platform/MouseEvent.h: Added isMouseButtonDown
platform/mac/MouseEventMac.mm: (WebCore::MouseEvent::isMouseButtonDown): Calls CG function to get state of mouse button.
platform/win/TemporaryLinkStubs.cpp: (MouseEvent::isMouseButtonDown): Added stub.

4:35 PM Changeset in webkit [13316] by bdakin

1 edit
848 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Even more Mozilla tables tests.

4:03 PM Changeset in webkit [13315] by bdakin

1 edit
849 adds in trunk/LayoutTests

Rubber stamped by Geoff

More Mozilla table tests.

3:01 PM Changeset in webkit [13314] by bdakin

1 edit
617 adds in trunk/LayoutTests

Rubber stamped by Geoff.

First round of committing Mozilla table tests to our tree.

2:46 PM Changeset in webkit [13313] by aliceli1

1 edit in trunk/WebKitSite/projects/compat/hitlist.html

forgot to change the date

2:28 PM Changeset in webkit [13312] by eseidel

2 edits in trunk/WebCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by geoff.

platform/KeyEvent.h: Fix #define from QEvent_H to KeyEvent_H

2:26 PM Changeset in webkit [13311] by eseidel

3 edits in trunk/JavaScriptCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix CString copy constructor, fixes Date.parse("") on Win32.

kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):
kjs/ustring.cpp: (KJS::CString::CString): (KJS::CString::operator=):

1:59 PM Changeset in webkit [13310] by aliceli1

1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added www.live.com to list and reordered by bug number.

1:29 PM Changeset in webkit [13309] by ggaren

2 edits in trunk/WebKitSite

Reviewed by TimH.

projects/compat/hitlist.html: Moved delta.com to the alumni list, added description of alumni list.

12:56 PM Changeset in webkit [13308] by hyatt

1 edit in trunk/LayoutTests/fast/box-sizing/percentage-height-expected.txt

Check in updated results for fast/box-sizing/percentage-height.html. All results for this test are wrong, but only in DumpRenderTree. Safari renders it correctly.

12:12 PM Changeset in webkit [13307] by hyatt

2 edits in trunk/WebCore

Fix the box-sizing layout test by stopping integer overflowing from
occurring in the flexbox code.

Reviewed by beth

rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::allowedChildFlex):

10:43 AM Changeset in webkit [13306] by bdakin

2 edits in trunk/WebCore

Reviewed by Eric

Fix for some leaks and intermittent broken pipes in the layout
tests after check-in for http://bugzilla.opendarwin.org/
show_bug.cgi?id=4171.

10:26 AM Changeset in webkit [13305] by darin

1 edit in trunk/LayoutTests/ChangeLog

Update information about when a bug was fixed.

2:21 AM Changeset in webkit [13304] by mjs

13 edits in trunk/JavaScriptCore

Reviewed by Anders.

KJS::Node and KJS::StatementNode are bigger than they need to be http://bugzilla.opendarwin.org/show_bug.cgi?id=7775

The memory usage of Node was reduced by 2 machine words per node:

sourceURL was removed and only kept on FunctionBodyNode. The source URL can only be distinct per function or top-level program node, and you always have one.

refcount was removed and kept in a separate hashtable when greater than 1. newNodes set represents floating nodes with refcount of 0. This helps because almost all nodes have a refcount of 1 for almost all of their lifetime.

bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): Pass null body, added FIXME.
kjs/Parser.cpp: (KJS::clearNewNodes): New nodes are tracked in nodes.cpp now, but still clear them at the appropriate time.
kjs/context.h: (KJS::ContextImp::currentBody): added; used to retrieve source URL and sid for current code. (KJS::ContextImp::pushIteration): moved here from LabelStack (KJS::ContextImp::popIteration): ditto (KJS::ContextImp::inIteration): ditto (KJS::ContextImp::pushSwitch): ditto (KJS::ContextImp::popSwitch): ditto (KJS::ContextImp::inSwitch): ditto
kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Add FunctionBodyNode* parameter. (KJS::FunctionImp::callAsFunction): Pass body to ContextImp. (KJS::FunctionImp::argumentsGetter): _context renamed to m_context. (KJS::DeclaredFunctionImp::DeclaredFunctionImp): Pass body to superclass constructor. (KJS::GlobalFuncImp::callAsFunction): Pass progNode as body for ContextImp in eval.
kjs/function.h: Move body field from DeclaredFunctionImp to FunctionImp.
kjs/grammar.y: Change DBG; statements no longer have a sourceid.
kjs/internal.cpp: (KJS::ContextImp::ContextImp): Initialize new m_currentBody, m_iterationDepth and m_switchDepth data members. New FunctionBodyNode* parameter - the function body provides source URL and SourceId. (KJS::InterpreterImp::mark): Use exception() function, not _exception directly. (KJS::InterpreterImp::evaluate): Pass progNode to ContextImp constructor to use as the body.
kjs/internal.h: (KJS::LabelStack::LabelStack): Remove iteration depth and switch depth; statement label stacks don't need these and it bloats their size. Put them in the ContextImp instead.
kjs/interpreter.cpp: (KJS::ExecState::lexicalInterpreter): Renamed _context to m_context.
kjs/interpreter.h: (KJS::ExecState::dynamicInterpreter): Renamed _context to m_context. (KJS::ExecState::context): ditto (KJS::ExecState::setException): Renamed _exception to m_exception (KJS::ExecState::clearException): ditto (KJS::ExecState::exception): ditto (KJS::ExecState::hadException): ditto (KJS::ExecState::ExecState): ditto both above renames
kjs/nodes.cpp: (Node::Node): Removed initialization of line, source URL and refcount. Add to local newNodes set instead of involving parser. (Node::ref): Instead of managing refcount directly, story refcount over 1 in a HashCountedSet, and keep a separate HashSet of "floating" nodes with refcount 0. (Node::deref): ditto (Node::refcount): ditto (Node::clearNewNodes): Destroy anything left in the new nodes set. (currentSourceId): Inline helper to get sourceId from function body via context. (currentSourceURL): ditto for sourceURL. (Node::createErrorCompletion): use new helper (Node::throwError): ditto (Node::setExceptionDetailsIfNeeded): ditto (StatementNode::StatementNode): remove initialization of l0 and sid, rename l1 to m_lastLine. (StatementNode::setLoc): Set own m_lastLine and Node's m_line. (StatementNode::hitStatement): Get sid, first line, last line in the proper new ways. (StatListNode::StatListNode): updated for setLoc changes (BlockNode::BlockNode): ditto (DoWhileNode::execute): excpect iteraton counts on ContextImp, not LabelStack (WhileNode::execute): ditto (ForNode::execute): ditto (ForInNode::execute): ditto (ContinueNode::execute): excpect inIteration on ContextImp, not LabelStack (BreakNode::execute): excpect inIteration and inSwitch on ContextImp, not LabelStack (SwitchNode::execute): expect switch counts on ContextImp, not LabelStack (FunctionBodyNode::FunctionBodyNode): update for new setLoc (FunctionBodyNode::processFuncDecl): reindent (SourceElementsNode::SourceElementsNode): update for new setLoc
kjs/nodes.h: (KJS::Node::lineNo): Renamed _line to m_line (KJS::StatementNode::firstLine): Use lineNo() (KJS::StatementNode::lastLine): Renamed l1 to m_lastLine (KJS::FunctionBodyNode::sourceId): added (KJS::FunctionBodyNode::sourceURL): added
kjs/testkjs.cpp:

1:41 AM Changeset in webkit [13303] by adele

2 edits in trunk/WebCore

Reviewed by Maciej.

Followup fix for previous checkin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7114
<rdar://problem/3695120> dragging to scroll doesn't work with overflow:auto/scroll/overlay areas

Many of the bugs related to the Radar bug have to do with autoscrolling in the RSS View.
This fix walks the layer tree to find the first scrollable layer, so that autoscrolling will
also work with nested layers, like those in the RSS View.

bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent):

1:05 AM Changeset in webkit [13302] by adele

7 edits in trunk/WebCore

Reviewed by Maciej.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7114 Dragging to scroll doesn't work for overflow areas

No test case. There doesn't appear to be a way to trigger the autoscroll with the EventSender.

bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent): If we have a layer that can scroll, let the layer handle its autoscroll. Otherwise, call over the bridge to let AppKit scroll the view. (WebCore::MacFrame::khtmlMouseReleaseEvent): Stops the autoscroll timer.
page/Frame.cpp: (WebCore::Frame::khtmlMouseReleaseEvent): Stops the autoscroll timer. (WebCore::Frame::handleAutoscroll): Added. Saves the layer, and starts the timer. (WebCore::Frame::autoscrollTimerFired): Added. Calls autoscroll() on the layer. (WebCore::Frame::startAutoscrollTimer): Added. (WebCore::Frame::stopAutoscrollTimer): Added.
page/Frame.h: Added new autoscroll methods.
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Initialize m_autoscrollTimer and m_autoscrollLayer.
rendering/render_layer.cpp: (WebCore::RenderLayer::autoscroll): Calculates how much the layer should scroll, and actually scrolls. (WebCore::RenderLayer::shouldAutoscroll): If the layer has overflow then it should be able to scroll. Except for overflow:hidden areas that aren't editable. In the future, we may want to have a css property that indicates an overflow:hidden style that should also scroll.
rendering/render_layer.h: Added new autoscroll methods.

Mar 14, 2006:

11:01 PM Changeset in webkit [13301] by justing

9 edits
6 adds in trunk

LayoutTests:

Reviewed by mjs

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7578>
TinyMCE: Implement execCommand CreateLink

editing/editing.js:
editing/execCommand/createLink-expected.checksum: Added.
editing/execCommand/createLink-expected.png: Added.
editing/execCommand/createLink-expected.txt: Added.
editing/execCommand/createLink.html: Added.

WebCore:

Reviewed by mjs

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7578>
TinyMCE: Implement execCommand CreateLink

Used ApplyStyleCommand so that creating a link from
a selection doesn't change document structure.

WebCore.xcodeproj/project.pbxproj:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::doApply): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
editing/ApplyStyleCommand.h:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle):
editing/CreateLinkCommand.cpp: Added. (WebCore::CreateLinkCommand::CreateLinkCommand): (WebCore::CreateLinkCommand::doApply):
editing/CreateLinkCommand.h: Added.
editing/jsediting.cpp:
page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):

10:40 PM Changeset in webkit [13300] by bdakin

12 edits in trunk

Reviewed by Maciej

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4171
This patch changes the word-break algorithm used to apply text-
transform:capitalize to use a UBreakIterator. This fixes some
existing edge cases we have in our text-transform:capitalize
support and generally makes our results more consistent.

7:41 PM Changeset in webkit [13299] by darin

7 edits in trunk/LayoutTests

Rubber stamped by Hyatt.

land new results for two tests affected by Hyatt's layer change

fast/encoding/utf-16-big-endian-expected.checksum: Updated.
fast/encoding/utf-16-big-endian-expected.png: Ditto.
fast/encoding/utf-16-big-endian-expected.txt: Ditto.
fast/encoding/utf-16-little-endian-expected.checksum: Ditto.
fast/encoding/utf-16-little-endian-expected.png: Ditto.
fast/encoding/utf-16-little-endian-expected.txt: Ditto.

7:25 PM Changeset in webkit [13298] by justing

5 edits in trunk/WebCore

Reviewed by adele

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7770>
Should only dispatch the khtmlTextInsertedEvent for high level editing operations

Dispatching this event for low level editing operations
isn't necessary and causes a big performance regression.
Also renamed the event because it's dispatched for changes
other than just text insertion.

dom/EventNames.h:
editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
khtml/html/HTMLTextFieldInnerElementImpl.cpp: (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler):
page/Frame.cpp: (WebCore::dispatchKHTMLEditableContentChanged): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):

6:47 PM Changeset in webkit [13297] by darin

3 edits in trunk/LayoutTests

land new results for tests affected by my setAttribute change

dom/xhtml/level3/core/nodeisequalnode15-expected.txt: Updated to reflect a new kind of failure.
dom/xhtml/level3/core/nodeisequalnode16-expected.txt: Updated to reflect success.

6:07 PM Changeset in webkit [13296] by ggaren

1 edit
1 add in trunk/LayoutTests

Oops, forgot to add this file.

fast/js/resources/string-sort.js: Added.

5:17 PM Changeset in webkit [13295] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

fix <rdar://problem/4478121> -[WebCoreFrameBridge finalize] crashes under GC

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge finalize]): Don't call setBridge(nil).

5:09 PM Changeset in webkit [13294] by ggaren

7 edits
2 adds in trunk

JavaScriptCore:

Fixed <rdar://problem/4478239> string sort puts "closed" before "close"

Reviewed by Eric.

kjs/ustring.cpp: (KJS::compare): Inverted a < in order to treat the longer string as > the shorter string.

LayoutTests:

Reviewed by Eric.

Layout test for <rdar://problem/4478239> string sort puts "closed"
before "close"

Also changed the engine to report data types when tests fail, so that
you don't get messages like, "should be A, was A."

Updated results for these files:

fast/js/kde/Array-expected.txt:
fast/js/kde/RegExp-expected.txt:
fast/js/kde/encode_decode_uri-expected.txt:
fast/js/resources/js-test-pre.js:

Added these files:

fast/js/string-sort-expected.txt: Added.
fast/js/string-sort.html: Added.

3:54 PM Changeset in webkit [13293] by darin

2 edits in trunk/WebCore

oops, didn't mean to check this in

dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::parseMappedAttribute): Reverted nil-document check that I didn't mean to remove.

3:53 PM Changeset in webkit [13292] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6796

3:50 PM Changeset in webkit [13291] by bdakin

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6796
This fix prevents infinite recursion when a block with overflow:
auto can't decide if it needs scrollbars or not. This fix puts a
guard in place in updateScrollInforAfterLayout that only allows you
to re-layout if you are not currently laying out.

3:01 PM Changeset in webkit [13290] by darin

1 edit
2 adds in trunk/LayoutTests

Reviewed by Maciej.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4059 Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings)

The fix occurred somewhere between r9638 (2005-07-09) and the first CVS
nightly build (WebKit-CVS-2005-10-01 03-27-01 GMT.dmg).

fast/dom/setAttribute-using-initial-input-value-expected.txt: Added.
fast/dom/setAttribute-using-initial-input-value.html: Added.

2:58 PM Changeset in webkit [13289] by darin

8 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff and Eric.

test for <http://bugzilla.opendarwin.org/show_bug.cgi?id=7765>, <rdar://problem/4474884> hasAttribute always returns false for uppercase attribute names like "STYLE"
also incidentally tests getAttributeNS and handling of null namespace parameters

fast/dom/Element/attribute-uppercase.html: Added.
fast/dom/Element/attribute-uppercase-expected.txt: Added.

WebCore:

Reviewed by Geoff and Eric.

fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=7765>, <rdar://problem/4474884> hasAttribute always returns false for uppercase attribute names like "STYLE"
re-add missing JavaScript binding for getAttributeNS
fixed handling of null namespace parameters in getAttributeNS and friends

Test: fast/dom/Element/attribute-uppercase.html

To match Gecko's behavior, the magic "lowercasing" of all attribute names
is only done when calling DOM Level 1 functions that lack an NS suffix.
The functions with an NS suffix are case sensitive, even in HTML documents.

dom/NamedNodeMapImpl.h: Changed getNamedItem and removeNamedItem to be pure virtual functions instead of calling through to getNamedItemNS and removeNamedItemNS.

dom/dom_elementimpl.h: Eliminated inline versions of non-NS functions that called the NS functions. They can't work that way any more since the lowercasing behavior is different.
dom/dom_elementimpl.cpp: (WebCore::ElementImpl::getAttribute): Added. Lowercases the name if the document is an HTML document, and then calls through to the qualified name version. Removed the null check since getDocument is guaranteed to never return 0 now that nodes hold a reference to their document. (WebCore::ElementImpl::getAttributeNS): Removed the lowercasing code. (WebCore::ElementImpl::setAttribute): More of the same. (WebCore::ElementImpl::setAttributeNS): Ditto. (WebCore::ElementImpl::removeAttribute): Ditto. (WebCore::ElementImpl::removeAttributeNS): Ditto. (WebCore::ElementImpl::getAttributeNode): Ditto. (WebCore::ElementImpl::getAttributeNodeNS): Ditto. (WebCore::ElementImpl::hasAttribute): Ditto. (WebCore::ElementImpl::hasAttributeNS): Ditto. (WebCore::NamedAttrMapImpl::getNamedItem): Ditto. (WebCore::NamedAttrMapImpl::getNamedItemNS): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto. (WebCore::StyledElementImpl::parseMappedAttribute): Removed another unneeded null check like the one mentioned above.

dom/Element.idl: Set ConvertNullToNullString for all the namespaceURI parameters, since we don't want null to turn into "null". Added a semicolon to the end of the hasAttributeNS line -- was causing the next declaration to be eaten up (so getAttributeNS was completely broken).

khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): Call valueToStringWithNullCheck to do the equivalent of ConvertNullToNullString for both getNamedItemNS and removeNamedItemNS.

bindings/js/JSDOMCore.cpp: Touched so that the changes above will take effect.

12:11 PM Changeset in webkit [13288] by tomernic

4 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4476873> Support printing for plugin documents (not embedded plugins)

WebView/WebFrameViewPrivate.h:
WebView/WebFrameView.m: (-[WebFrameView documentViewShouldHandlePrint]): Called by the host application before it initializes and runs a print operation. If NO is returned, the host application will abort its print operation and call -printDocumentView on the WebFrameView. The document view is then expected to run its own print operation. If YES is returned, the host application's print operation will continue as normal. (-[WebFrameView printDocumentView]): Called by the host application when the WebFrameView returns YES from -documentViewShouldHandlePrint.

Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView documentViewShouldHandlePrint]): Allow the plugin to take over printing if it defines an NPP_Print function (-[WebNetscapePluginDocumentView printDocumentView]): Print the plugin document.

3:21 AM Changeset in webkit [13287] by hyatt

1 edit in trunk/WebCore/rendering/render_layer.cpp

Fix the setpos to move screwup. Didn't realize move was a delta.

3:03 AM Changeset in webkit [13286] by hyatt

4 edits in trunk/WebCore

Fix for bug 7259, opacity performs badly.

Reviewed by mjs

Adding some tests in fast/opacity.

rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/render_layer.cpp: (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
rendering/render_layer.h: (WebCore::RenderLayer::root):

2:52 AM Changeset in webkit [13285] by eseidel

2 edits in trunk/WebKitTools

2006-03-14 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Make the URL bar relinquish focus on page load.

Spinneret/Spinneret/Spinneret.cpp: (MyEditProc):

2:33 AM Changeset in webkit [13284] by eseidel

2 edits in trunk/WebKitTools

2006-03-14 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix WebView to allow KeyFocus.
Add handling of space and shift-space for scrolling.

Spinneret/Spinneret/WebView.cpp: (WebKit::scrollMessageForKey): (WebKit::WebViewWndProc):

1:49 AM Changeset in webkit [13283] by eseidel

2 edits in trunk/WebCore

2006-03-14 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix Gif crasher.

platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Initialize array after new.

1:19 AM Changeset in webkit [13282] by eseidel

2 edits in trunk/WebCore

2006-03-14 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Make MouseEvents aware of current scroll position.

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport):

Mar 13, 2006:

11:40 PM Changeset in webkit [13281] by eseidel

2 edits in trunk/WebCore

2006-03-13 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix mouse events to be window-relative.

platform/win/MouseEventWin.cpp: (WebCore::positionForEvent): (WebCore::globalPositionForEvent): (WebCore::MouseEvent::MouseEvent):

11:05 PM Changeset in webkit [13280] by eseidel

3 edits in trunk/WebKitTools

2006-03-10 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Add scrolling support into Spinneret.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint):
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView): (WebKit::calculateScrollDelta): (WebKit::scrollMessageForKey): (WebKit::WebViewWndProc):

10:25 PM Changeset in webkit [13279] by eseidel

3 edits in trunk/WebCore

2006-03-13 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Close DeviceContext leaks in Font code.
Also add moveCursor stub to make maps.google.com not crash.

platform/win/FontWin.cpp: (WebCore::getFontData): (WebCore::Font::floatWidth): (WebCore::Font::drawText):
platform/win/TemporaryLinkStubs.cpp: (Cursor::Cursor): (WebCore::moveCursor):

8:50 PM Changeset in webkit [13278] by eseidel

4 edits in trunk/WebKitTools

2006-03-13 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix checksum generation on Intel machines.
Also moved to CGImage APIs instead of NSBitmapImageRep, may possibly
give a small speed boost now that it uses a shared buffer.

DumpRenderTree/DumpRenderTree.m: (main): (dump): (md5HashStringForBitmap):
DumpRenderTree/ImageDiff.m: (computePercentageDifferent):

7:30 PM Changeset in webkit [13277] by eseidel

3 edits
5 adds in trunk

2006-03-13 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):

6:26 PM Changeset in webkit [13276] by eseidel

8 edits
4 adds in trunk

2006-03-10 Rob Buis <buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7666:
dasharray on rounded rectangles is broken

Make sure the rounded rectangle is drawn clockwise, as outlined
in the specification.

Test: svg/custom/dashArrayOrigin.svg

kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle):

4:15 PM Changeset in webkit [13275] by thatcher

4 copies in tags/WebCore-417.24/WebCore

New tag (part 2).

4:14 PM Changeset in webkit [13274] by thatcher

1 add in tags/WebCore-417.24

New tag.

4:14 PM Changeset in webkit [13273] by thatcher

5 copies in tags/JavaScriptCore-417.11/JavaScriptCore

New tag (part 2).

4:14 PM Changeset in webkit [13272] by thatcher

1 add in tags/JavaScriptCore-417.11

New tag.

4:12 PM Changeset in webkit [13271] by thatcher

4 edits in branches/Safari-2-0-branch

Versioning

4:09 PM Changeset in webkit [13270] by thatcher

4 edits in branches/Safari-2-0-branch

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)

Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.

bridge/mac/MacFrame.mm: (WebCore::MacFrame::windowScriptNPObject): Removed the check Darin added to return 0 when JavaScript is disabled. This method cannot return 0, because plugins are not guaranteed to check for that. Removed my old fix for Radar 4428609 (7015) in favor of a better solution. Instead of creating a "dummy" JSObject to represent the window script object when JavaScript is disabled, we use the new JavaScriptCore bindings API to create a "no script" NPObject. This solution is better because it does not cause entry into any JavaScript interpreter code.

manual-tests/NPN_Invoke: Added.
manual-tests/NPN_Invoke/English.lproj: Added.
manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
manual-tests/NPN_Invoke/Info.plist: Added.
manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
manual-tests/NPN_Invoke/main.c: Added.
manual-tests/NPN_Invoke/test.html: Added.

2:16 PM Changeset in webkit [13269] by ggaren

4 edits in trunk/WebKit

Reviewed by timo.

Fixed the load progress indicator to give more incremental feedback, and to stop spending so much time near 100%.

I did two things:
(1) Fixed some bugs and a misspelling in the previous heuristic's
implementation
(2) Added two new rules to the heuristic:

(a) Treat the first layout as the half-way point.
(b) Just like we jump the first 10% to indicate that a load has
started, jump the last 10% to indicate that a load has finished.

Rule 2a is good for two reasons. First, it seems unnatural for loading
to be "more than half done" when you can't even see anything. Second,
in the early stages of laading our estimate of how much we'll need to
load is often off by as much as 6000% (e.g., cnn.com). So anything that
makes the progress indicator more conservative in the early stages of
loading is helpful.

Rule 2b is good because it's confusing for loading to be "100% done"
but still ongoing.

FIXME: The indicator still isn't perfect. For example, the old behavior
shows up @ moviefone.com. Two areas for future work:
(1) Estimate number of linked resources. Our code estimates the size
of a single resource, but does nothing to estimate the number of
resources that resource might link to. This is the key to why we're
so wrong at the beginning.
(2) Improve "when to do first layout" heuristic. A JavaScript query
for a style property forces layout, creating a phantom first layout
with no content, essentially nullifying 2a for certain pages.

Filed <rdar://problem/4475834> to track estimating the number of
linked resources. Phantom layouts are already on Hyatt's radar.

WebView/WebFrame.m: (-[WebFrame _setState:]): Update firstLayoutDone (-[WebFrame _numPendingOrLoadingRequests:]): Bug fix: In the recurisve case, query 'frame' instead of 'self', so that we actually recurse. (-[WebFrame _firstLayoutDone]): New method (-[WebFrame _didFirstLayout]): Update firstLayoutDone
WebView/WebFramePrivate.h: Added firstLayoutDone ivar
WebView/WebView.m: (-[WebView _incrementProgressForConnectionDelegate:data:]): (1) Implemented 2a and 2b (2) Bug fix: only update the 'last time I sent a notification' time if we actually send a notification. (3) Don't test for progress < 0 because ensuring progress < max also ensures max - progress > 0. (Do still test for progress > max because rounding errors make that a possibility -- although a very minor one.) (4) Query only the loading frame and its subframes for pending requests instead of defaulting to the main frame. This is a slight optimization in cases where the main frame did not begin the load, and it makes the code more consistent.

12:00 PM Changeset in webkit [13268] by darin

2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

Scripts/run-webkit-tests: Fix httpd handling to work on systems that have it named httpd-1.3 instead.

11:55 AM Changeset in webkit [13267] by ap

2 edits in trunk/WebKitTools

Fix proposed by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7718 run-webkit-tests fast/dom/HTMLObjectElement/ hangs

Scripts/run-webkit-tests: Make test paths canonical, to form proper URLs (sequences of slashes are equivalent to a single slash in POSIX paths, but not in URLs).

11:29 AM Changeset in webkit [13266] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Omernick.

fixed <rdar://problem/4475857> API: Setting a history item limit programmatically doesn't work

History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): use [self historyItemLimit], which prefers the explicitly-set value and falls back to the NSUserDefaults value, instead of using the NSUserDefaults value explicitly.

Mar 12, 2006:

2:17 PM Changeset in webkit [13265] by ap

3 edits
4 adds in trunk

Fix by Mitz Pettel, reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5923 REGRESSION: scrolling on Google maps continues after the mouse is released outside the window

Test: fast/events/drag-outside-window.html

rendering/render_layer.cpp: (WebCore::RenderLayer::containsPoint): Always return true for the root object to ensure that mouse events occurring outside the window target the document.

2:09 PM Changeset in webkit [13264] by ap

5 edits in trunk/WebCore

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7735 REGRESSION: crash on importing bookmarks

No test - only reproducible when Safari imports the bookmarks.

dom/EventNames.cpp: (WebCore::EventNames::init): Initialize AtomicString before using it.
dom/QualifiedName.cpp: (WebCore::QualifiedName::init): Ditto.
khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): Ditto.
ksvg2/scripts/make_names.pl: Ditto.

12:30 PM Changeset in webkit [13263] by ap

3 edits
2 adds in trunk

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7708 REGRESSION: Flash callback to JavaScript function not working.

Test: plugins/invoke.html

bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Return a correct string length.

12:29 AM Changeset in webkit [13262] by ap

3 edits
16 adds in trunk

Patch by David Kilzer, reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7724 Minor refactoring to HTMLParser::handleError() to remove duplicate code

WebCore:

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Refactored code.

LayoutTests:

These tests cover the changed code. No change in behavior.

fast/invalid/missing-address-end-tag-expected.checksum: Added.
fast/invalid/missing-address-end-tag-expected.png: Added.
fast/invalid/missing-address-end-tag-expected.txt: Added.
fast/invalid/missing-address-end-tag.html: Added.
fast/invalid/missing-dl-end-tag-expected.checksum: Added.
fast/invalid/missing-dl-end-tag-expected.png: Added.
fast/invalid/missing-dl-end-tag-expected.txt: Added.
fast/invalid/missing-dl-end-tag.html: Added.
fast/invalid/missing-dt-end-tag-expected.checksum: Added.
fast/invalid/missing-dt-end-tag-expected.png: Added.
fast/invalid/missing-dt-end-tag-expected.txt: Added.
fast/invalid/missing-dt-end-tag.html: Added.
fast/invalid/missing-font-end-tag-expected.checksum: Added.
fast/invalid/missing-font-end-tag-expected.png: Added.
fast/invalid/missing-font-end-tag-expected.txt: Added.
fast/invalid/missing-font-end-tag.html: Added.

Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin

2 edits in trunk/WebCore

fix Windows build

bridge/win/FrameWin.h: Removed declaration of generateFrameName.

7:30 PM Changeset in webkit [13260] by darin

9 edits in trunk

WebCore:

Reviewed by Adele.

removed some unused stuff from Frame and MacFrame

page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.

bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.

bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.

7:25 PM Changeset in webkit [13259] by darin

2 edits in trunk/WebCore

fix Windows build

page/FrameTree.cpp: Add include of <stdarg.h>.

7:21 PM Changeset in webkit [13258] by darin

4 edits in trunk/WebKit

Reviewed by Geoff.

change how frame namespacing works to be more completely on the WebCore side

WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
WebView/WebFrame.m: Ditto.

WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].

7:17 PM Changeset in webkit [13257] by darin

23 edits
1 move
8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3308 Pop-up blocking blocks window.open for already open windows

fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
fast/dom/Window/open-existing-pop-up-blocking.html: Added.
fast/dom/Window/resources/open-sibling-subframe.html: Added.
fast/dom/Window/resources/sibling-subframe-content.html: Added.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7422 Setting a frame name to the same value resets it to a generated one

fast/frames/frame-name-reset.html: Added.
fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3308 Pop-up blocking blocks window.open for already open windows

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7422 Setting a frame name to the same value resets it to a generated one

refactor frame-name-related functions into the FrameTree object

WebCore.xcodeproj/project.pbxproj: Update for rename.
bridge/mac/MacFrame.h: Remove generateFrameName.
bridge/mac/MacFrame.mm: Ditto.
bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.

bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.

bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
bridge/mac/WebCoreFrameNamespaces.m: Renamed.
bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.

bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.

khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.

khtml/html/html_baseimpl.h:
khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.

rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.

page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.

page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.

page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.

platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.

5:35 PM Changeset in webkit [13256] by justing

2 edits in trunk/WebCore

Reviewed by darin, harrison

~3x speedup pasting plain text from the console

dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):

4:19 PM Changeset in webkit [13255] by hyatt

3 edits
3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher

5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher

4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

fix win32 networking to properly use async load API

platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):

1:15 PM Changeset in webkit [13251] by eseidel

3 edits in trunk/WebCore

2006-03-10 Eric Seidel <eseidel@apple.com>

Fix build.

platform/win/FontWin.cpp: (WebCore::getFontData):
platform/win/TemporaryLinkStubs.cpp:

1:13 PM Changeset in webkit [13250] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

fast/forms/radio-attr-order-expected.checksum: Added.
fast/forms/radio-attr-order-expected.png: Added.
fast/forms/radio-attr-order-expected.txt: Added.
fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.

1:05 PM Changeset in webkit [13249] by eseidel

24 edits in trunk/WebCore

2006-03-10 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

platform/ScrollView.h:
platform/Widget.h:
platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const

11:28 AM Changeset in webkit [13248] by hyatt

6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
platform/Font.h:
platform/FontDataSet.h:
platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):

10:58 AM Changeset in webkit [13247] by hyatt

6 edits
1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

WebCore.xcodeproj/project.pbxproj:
platform/Font.cpp: (WebCore::Font::update):
platform/Font.h:
platform/FontDataSet.h: Added.
platform/FontRenderer.h: Removed.
platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):

10:40 AM Changeset in webkit [13246] by hyatt

2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Mar 9, 2006:

11:37 PM Changeset in webkit [13245] by justing

2 edits in trunk/WebCore

Reviewed by adele

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7692>
Should use an iterator in CompositeEditCommand::doUnapply()

~30% speedup of a big undo

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): (WebCore::CompositeEditCommand::doReapply):

6:20 PM Changeset in webkit [13244] by adele

3 edits in trunk/WebCore

Reviewed by Tim O.

Removed unnecessary alerts in TextIterator advance methods.
We want to be able to use advance() even if the iterator is already at the end.

editing/visible_text.cpp: (khtml::TextIterator::advance): remove assert since TextIterator will just do nothing if its already at the end. (khtml::CharacterIterator::advance): ditto.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): Since the asserts in the iterator are removed, we don't have to check for it.atEnd() before calling advance.

4:13 PM Changeset in webkit [13243] by thatcher

5 copies in tags/JavaScriptCore-417.10/JavaScriptCore

New tag (part two).

4:12 PM Changeset in webkit [13242] by thatcher

1 add in tags/JavaScriptCore-417.10

New tag.

3:39 PM Changeset in webkit [13241] by hyatt

2 edits in trunk/WebCore

Make text paint with the pen color on Win32. Force ClearType quality. Make the face validation case-insensitive.

3:30 PM Changeset in webkit [13240] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7675 When new text fields change from visibility:hidden to visibility:visible, value doesn't display

fast/forms/input-appearance-visibility-expected.checksum: Added.
fast/forms/input-appearance-visibility-expected.png: Added.
fast/forms/input-appearance-visibility-expected.txt: Added.
fast/forms/input-appearance-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7675 When new text fields change from visibility:hidden to visibility:visible, value doesn't display

Test: fast/forms/input-appearance-visibility.html

rendering/RenderTextField.cpp: (WebCore::RenderTextField::setStyle): Sets the style directly on the children of the inner div.

3:27 PM Changeset in webkit [13239] by thatcher

1 edit in branches/Safari-2-0-branch/JavaScriptCore/Info.plist

Versioning

3:21 PM Changeset in webkit [13238] by thatcher

3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto

bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().

2:48 PM Changeset in webkit [13237] by hyatt

1 edit in trunk/WebCore/platform/win/FontWin.cpp

SetBkMode to transparent so that TextOut doesn't erase the background when drawing text.

1:24 PM Changeset in webkit [13236] by hyatt

8 edits
2 adds in trunk/WebCore

Check in basic text rendering on Win32.

12:02 PM Changeset in webkit [13235] by justing

3 edits in trunk/WebCore

Reviewed by harrison

Fixed formatting and changed functions to take in
a const Selection& instead of a Selection.

editing/ModifySelectionListLevelCommand.cpp: (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
editing/ModifySelectionListLevelCommand.h:

11:43 AM Changeset in webkit [13234] by adele

4 edits
4 adds in trunk

LayoutTests:

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6814 Implement selection methods for RenderTextField

fast/forms/input-appearance-selection-expected.checksum: Added.
fast/forms/input-appearance-selection-expected.png: Added.
fast/forms/input-appearance-selection-expected.txt: Added.
fast/forms/input-appearance-selection.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6814 Implement selection methods for RenderTextField

Test: fast/forms/input-appearance-selection.html

rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): removed extra space. (WebCore::RenderTextField::select): Removed checks for document and m_div since there should always be a document and m_div will be initialized as the renderer gets attached. (WebCore::RenderTextField::selectionStart): Calls indexForVisiblePosition. (WebCore::RenderTextField::selectionEnd): ditto. (WebCore::RenderTextField::setSelectionStart): calls setSelectionRange. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::setSelectionRange): gets VisiblePositions for both indices, and sets the selection. (WebCore::RenderTextField::visiblePositionForIndex): Added helper method. (WebCore::RenderTextField::indexForVisiblePosition): Added helper method.
rendering/RenderTextField.h: Added new helper methods for selection.

9:19 AM Changeset in webkit [13233] by darin

5 edits in trunk/WebKitTools

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7681 memory leak in the plug-in tests

DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Added code to release the plug-in object. This is the leak fix. (NPP_SetWindow): Remove unneeded code to store the window pointer.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Moved the browser global in here since it's declared in this file's header. Changed the code to set up the pluginClass structure to not use function pointer casts. Those are dangerous because they can hide many types of mismatch. And indeed when I did this I discovered that many functions were missing their boolean return values or had parameter declarations with the wrong types. (pluginGetProperty): Use STRINGZ_TO_NPVARIANT macro for greater simplicity and clarity. Added boolean return value: return true when successful and false when not. (pluginSetProperty): Added boolean return value, return false since we have no properties we can set. (pluginInvoke): Added boolean return value. Return true when successful and false when not. Use NPVARIANT macros where appropriate. Added a missing release for the return value from calling the browser. Changed code to put the strings in malloc buffers instead of relying on GCC's extension that allows variable-sized arrays on the stack. (pluginInvokeDefault): Added boolean return value, return false since we have no default function to call. (pluginInvalidate): Added missing parameter. Removed comment. (pluginAllocate): Removed unneeded cast. This is C code, not C++, so you don't have to cast the result of malloc. (pluginDeallocate): Removed uneeded cast.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Removed some unneeded includes. Changed our PluginObject to use NPObject instead of re-declaring fields that match NPObject's fields. Removed unused NPWindow pointer.

8:35 AM Changeset in webkit [13232] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7583 DRT hangs when doing eventSender.mouseDown on native widgets

fast/events/event-sender-mouse-click-expected.txt: Added.
fast/events/event-sender-mouse-click.html: Added.

WebKitTools:

Test: fast/events/event-sender-mouse-click.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7583 DRT hangs when doing eventSender.mouseDown on native widgets

DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController mouseClick]): Simulates a click in a native widget by queueing a mouseUp before sending the mouseDown, so that the widget's mouse tracking event loop doesn't hang indefinitely.

8:32 AM Changeset in webkit [13231] by darin

3 edits
1 copy
8 moves
6 adds in trunk

LayoutTests:

Reviewed by Darin.

fast/canvas: Added.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6103 Rectangles are not filled according to the Web Applications Working Draft

fast/canvas/fillrect_gradient-expected.checksum: Added.
fast/canvas/fillrect_gradient-expected.png: Added.
fast/canvas/fillrect_gradient-expected.txt: Added.
fast/canvas/fillrect_gradient.html: Added.

moved other canvas tests here

fast/canvas/image-object-in-canvas-expected.checksum: Added.
fast/canvas/image-object-in-canvas-expected.png: Added.
fast/canvas/image-object-in-canvas-expected.txt: Added.
fast/canvas/image-object-in-canvas.html: Added.
fast/canvas/quadraticCurveTo-expected.checksum: Added.
fast/canvas/quadraticCurveTo-expected.png: Added.
fast/canvas/quadraticCurveTo-expected.txt: Added.
fast/canvas/quadraticCurveTo.xml: Added.
fast/canvas/resources: Added.
fast/canvas/resources/apple.gif: Added.

fast/dom/image-object-in-canvas-expected.checksum: Removed.
fast/dom/image-object-in-canvas-expected.png: Removed.
fast/dom/image-object-in-canvas-expected.txt: Removed.
fast/dom/image-object-in-canvas.html: Removed.
fast/dom/quadraticCurveTo-expected.checksum: Removed.
fast/dom/quadraticCurveTo-expected.png: Removed.
fast/dom/quadraticCurveTo-expected.txt: Removed.
fast/dom/quadraticCurveTo.xml: Removed.

WebCore:

Test: fast/canvas/fillrect_gradient.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6103 Rectangles are not filled according to the Web Applications Working Draft

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::callAsFunction): Modified fillrect function to check and use a gradient if set. Builds a path to fill rects with a gradient.

8:10 AM Changeset in webkit [13230] by darin

2 edits in trunk/WebCore

No test because this fixes an existing pixel test (and does not affect
the render tree).

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7664 REGRESSION: tests that include numeric list markers fail in pixel mode

platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Restored AlignRight behavior.

8:05 AM Changeset in webkit [13229] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7680 REGRESSION: Ellipsis painted over the chrome and in invalid contexts

rendering/render_line.cpp: (WebCore::EllipsisBox::paint): Replaced call to Font::drawText with GraphicsContext::drawText, which checks the paintingDisabled flag.

2:57 AM Changeset in webkit [13228] by mjs

10 edits in trunk

WebCore:

Reviewed by Eric.

make link clicks work by propagating them up to a client

Viewer/ImageView.cpp:
bridge/win/FrameWin.cpp:
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):

WebKitTools:

Reviewed by Eric.

make link clicks work by handling link click requests from WebCore

Spinneret/Spinneret/Spinneret.cpp: (updateLocationBar):
Spinneret/Spinneret/Spinneret.h:
Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::openURL): (WebKit::WebFrame::loadURL):
Spinneret/Spinneret/WebFrame.h:

1:52 AM Changeset in webkit [13227] by eseidel

4 edits in trunk/WebKitTools

2006-03-08 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Focus URL bar on Spinneret launch, remove border from WebView.
Stop WebFrame from deleting the job (prevent crash).

Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::receivedAllData): (WebKit::WebFrame::paint):
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView):

1:49 AM Changeset in webkit [13226] by eseidel

8 edits in trunk/WebCore

2006-03-09 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add support for Timers under 10ms.
Fix random crashers due to multi-threaded loading.

platform/TransferJob.h:
platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
platform/Widget.h:
platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::initializeOffScreenTimerWindow): (WebCore::setSharedTimerFireTime):
platform/win/TemporaryLinkStubs.cpp: (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::retrieveCharset):
platform/win/TransferJobWin.cpp: (WebCore::addToOutstandingJobs): (WebCore::removeFromOutstandingJobs): (WebCore::lookupTransferJob): (WebCore::TransferJobWndProc): (WebCore::initializeOffScreenTransferJobWindow): (WebCore::TransferJob::~TransferJob): (WebCore::transferJobStatusCallback): (WebCore::TransferJob::start): (WebCore::TransferJob::cancel):
platform/win/WidgetWin.cpp:

Mar 8, 2006:

9:49 PM Changeset in webkit [13225] by ap

6 edits
2 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7656 Query string always appended to Flash URLs, instead of being replaced.

WebKit:

Misc/WebNSURLExtras.h: Added _webkit_URLByRemovingResourceSpecifier.
Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Call _webkit_URLByRemovingResourceSpecifier to work around CFURL not removing non-path components from base URLs in some cases. (-[NSURL _webkit_URLByRemovingComponent:]): New generic function for removing URL components. (-[NSURL _webkit_URLByRemovingFragment]): Moved implementation to the above method. (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Added.

WebKitTools:

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Added a method to test getURL.

LayoutTests:

plugins/geturl-replace-query-expected.txt: Added.
plugins/geturl-replace-query.html: Added.

6:28 PM Changeset in webkit [13224] by darin

1 edit in trunk/LayoutTests/ChangeLog

Added log entry that somehow didn't get checked in last night.

4:20 PM Changeset in webkit [13223] by ggaren

2 edits in trunk/WebKitSite

Reviewed by Beth.

Clarified that sites on the list aren't necessarily "broken."

projects/compat/hitlist.html:

3:53 PM Changeset in webkit [13222] by hyatt

18 edits in trunk/WebCore/platform/cairo

merge cairo to the mozilla trunk.

3:07 PM Changeset in webkit [13221] by justing

8 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)

editing/editing.js:
editing/execCommand/insertImage-expected.checksum: Added.
editing/execCommand/insertImage-expected.png: Added.
editing/execCommand/insertImage-expected.txt: Added.
editing/execCommand/insertImage.html: Added.
editing/pasteboard/3976872-expected.txt:

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)

Implemented InsertImage and also changed paste to use a single
rule for when to remove junk that remains after node removal.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
editing/ReplaceSelectionCommand.h:
editing/htmlediting.cpp:
editing/jsediting.cpp:

2:51 PM Changeset in webkit [13220] by ggaren

2 edits in trunk/WebKitSite

Reviewed by Beth.

Updated links to gap and bananarepublic bugs.

projects/compat/hitlist.html:

2:39 PM Changeset in webkit [13219] by thatcher

3 copies in tags/WebKit-418/WebKit

New tag (part 2).

2:39 PM Changeset in webkit [13218] by thatcher

1 add in tags/WebKit-418

New tag.

2:36 PM Changeset in webkit [13217] by thatcher

2 edits in branches/Safari-2-0-branch/WebKit

<rdar://problem/4464698> 10.4.6 REGRESSION: Safari 417.9 no longer works with gap.com (417.8 did)

Info.plist: bump the version to 418 to allow GAP's >= check to work

2:20 PM Changeset in webkit [13216] by eseidel

2 edits in trunk/WebCore

2006-03-08 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix build script to properly copy dll files.

WebCore.vcproj/WebCore/build-generated-files.sh:

1:32 PM Changeset in webkit [13215] by eseidel

69 edits
4 adds in trunk

2006-03-08 Rob Buis <buis@kde.org>

Reviewed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6899
SVG <rect> does not respect display: none

For svg elements that can render, call StyledElementImpl::rendererIsNeeded
to decide whether the element should render. In particular this way
any setting of display="none" is handled.

ksvg2/svg/SVGAElementImpl.h: (WebCore::SVGAElementImpl::rendererIsNeeded):
ksvg2/svg/SVGCircleElementImpl.h: (WebCore::SVGCircleElementImpl::rendererIsNeeded):
ksvg2/svg/SVGEllipseElementImpl.h: (WebCore::SVGEllipseElementImpl::rendererIsNeeded):
ksvg2/svg/SVGForeignObjectElementImpl.h: (WebCore::SVGForeignObjectElementImpl::rendererIsNeeded):
ksvg2/svg/SVGGElementImpl.h: (WebCore::SVGGElementImpl::rendererIsNeeded):
ksvg2/svg/SVGImageElementImpl.h: (WebCore::SVGImageElementImpl::rendererIsNeeded):
ksvg2/svg/SVGLineElementImpl.h: (WebCore::SVGLineElementImpl::rendererIsNeeded):
ksvg2/svg/SVGMarkerElementImpl.h: (WebCore::SVGMarkerElementImpl::rendererIsNeeded):
ksvg2/svg/SVGMaskElementImpl.h: (WebCore::SVGMaskElementImpl::rendererIsNeeded):
ksvg2/svg/SVGPathElementImpl.h: (WebCore::SVGPathElementImpl::rendererIsNeeded):
ksvg2/svg/SVGPatternElementImpl.h: (WebCore::SVGPatternElementImpl::rendererIsNeeded):
ksvg2/svg/SVGPolyElementImpl.h: (WebCore::SVGPolyElementImpl::rendererIsNeeded):
ksvg2/svg/SVGRectElementImpl.h: (WebCore::SVGRectElementImpl::rendererIsNeeded):
ksvg2/svg/SVGSVGElementImpl.h: (WebCore::SVGSVGElementImpl::rendererIsNeeded):
ksvg2/svg/SVGSwitchElementImpl.h: (WebCore::SVGSwitchElementImpl::rendererIsNeeded):
ksvg2/svg/SVGTSpanElementImpl.h: (WebCore::SVGTSpanElementImpl::rendererIsNeeded):
ksvg2/svg/SVGTextElementImpl.h: (WebCore::SVGTextElementImpl::rendererIsNeeded):
ksvg2/svg/SVGUseElementImpl.h: (WebCore::SVGUseElementImpl::rendererIsNeeded):

3:59 AM Changeset in webkit [13214] by mjs

6 edits in trunk/WebKitTools

Reviewed by Eric.

load URLs, not file paths, in Spinneret

Spinneret/Spinneret/Spinneret.cpp: (MyEditProc):
Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadURL): (WebKit::WebFrame::receivedData): (WebKit::WebFrame::receivedAllData):
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):

3:56 AM Changeset in webkit [13213] by mjs

4 edits in trunk/WebCore

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):

3:40 AM Changeset in webkit [13212] by eseidel

4 edits
1 add in trunk/WebCore

2006-03-08 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):

2:59 AM Changeset in webkit [13211] by eseidel

3 edits in trunk/JavaScriptCore

2006-03-08 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Partially fix JS on win32 by fixing hash table generation.

kjs/create_hash_table: limit << results to 32 bits.
kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

1:55 AM Changeset in webkit [13210] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fix another instance of the bug I just fixed in the Macintosh-specific code path

platform/image-decoders/gif/GIFImageReader.h: Remove not-so-useful 100ms constant.
platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read): Use the correct rule for minimum frame durations.

1:43 AM Changeset in webkit [13209] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fix win32 build

platform/win/FontWin.cpp: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText):
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::clearFocusRing): (GraphicsContext::selectedTextBackgroundColor): (Font::selectionRectForText):

1:40 AM Changeset in webkit [13208] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fix one more thing from http://bugzilla.opendarwin.org/show_bug.cgi?id=7528 REGRESSION: GIF animation speeds are wrong on a page with many animated GIFs

No layout test because I don't know how to test animated GIF speed.

platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Use the correct rule for minimum frame durations. It's a bit non-intuitive, so I made the comment more explicit. The old code in WebKit had this rule.

1:26 AM Changeset in webkit [13207] by darin

3 edits in trunk

Reviewed by Eric.

fixed AppleScript layout test results to not be endian-dependent (Hyatt complained to me about this one)

DumpRenderTree/AppleScriptController.m: (-[AppleScriptController doJavaScript:]): Added specific code for dumping LongDateTime, instead of dumping the raw bytes (which are endian-dependent).

1:12 AM Changeset in webkit [13206] by hyatt

9 edits in trunk/WebCore

Make GraphicsContext call into Font to draw all text and eliminate
all knowledge of WebTextRenderers from it.

Reviewed by darin

platform/Font.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspelling): (WebCore::GraphicsContext::misspellingLineThickness):
platform/GraphicsContext.h: (WebCore::GraphicsContext::platformContext):
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::platformContext):
platform/mac/FontMac.mm: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness):
platform/mac/GraphicsContextMac.mm:
platform/win/FontWin.cpp: (WebCore::Font::drawText):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):

1:08 AM Changeset in webkit [13205] by darin

2 edits in trunk/JavaScriptCore

kxmlcore/Vector.h: Quick fix to try to get Windows compiling again.

12:59 AM Changeset in webkit [13204] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

fixed super-fast animation of many animated GIFs

No layout test because I don't know how to test animated GIF speed.

platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Always take the minimum duration into account, even if there's some kind of failure getting the duration from the GIF.

12:30 AM Changeset in webkit [13203] by darin

12 edits in trunk

JavaScriptCore:

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

kjs/lexer.cpp: (Lexer::lex): Turn off the "yylex: ERROR" message.
kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the code to log errors from PCRE to standard output. I think we should arrange for the error text to be in JavaScript exceptions instead at some point.
kxmlcore/Vector.h: Add a check for overflow so that we'll abort if we pass a too-large size rather than allocating a buffer smaller than requested.

WebCore:

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString): Pass XML_PARSE_NOERROR and XML_PARSE_NOWARNING. We don't want errors and warnings to be logged to stdout or stderr. If we later decide we want the error messages, then we should do the additional work to put them into the web page or the console (along with the JavaScript errors).

platform/ArrayImpl.cpp: (WebCore::ArrayImpl::resize): Add a preflight to protect against integer overflow due to large array size. Noticed this while looking into the malloc error message.

WebKit:

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

WebView/WebDataSourcePrivate.h:
WebView/WebDataSource.m: (-[WebDataSource _setRepresentation:]): Clear the flag that records whether we've sent all the data to the representation or not; need this to prevent telling the same representation both that we've succeeded and then later that we've failed. (-[WebDataSource _setMainDocumentError:]): Don't send an error if representationFinishedLoading is already YES. Set representationFinishedLoading. (-[WebDataSource _finishedLoading]): Set representationFinishedLoading. (-[WebDataSource _setupForReplaceByMIMEType:]): Ditto.

WebKitTools:

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

DumpRenderTree/DumpRenderTree.m: (checkedMalloc): Added. (checkedRealloc): Added. (makeLargeMallocFailSilently): Added. (main): Call makeLargeMallocFailSilently.

Mar 7, 2006:

5:37 PM Changeset in webkit [13202] by justing

2 edits in trunk/LayoutTests

Reviewed by harrison

I think this layout test is failing b/c the wait times are
right on the threshold of what is necessary to register a drag.

fast/lists/drag-into-marker.html:

4:08 PM Changeset in webkit [13201] by darin

4 edits in trunk/WebCore

Reviewed by Adele.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7647 Crash when typing into text contols

I missed a couple places that were still saying KWQWidgetHolder
in the change I landed late last night.

kwq/KWQTextArea.h:
kwq/KWQTextArea.mm:
kwq/KWQTextField.h: Changed them all to say WebCoreWidgetHolder.

3:35 PM Changeset in webkit [13200] by thatcher

1 edit in trunk/Makefile.shared

Add a prerequisite named 'force' to the debug and release rules to prevent the "debug is up-to-date" error. Reviewed by Eric.

2:26 PM Changeset in webkit [13199] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix cursor support on win32.

platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):

2:03 PM Changeset in webkit [13198] by hyatt

5 edits in trunk/WebCore

Eliminate two more unneeded arguments from drawText

1:49 PM Changeset in webkit [13197] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix basic text support.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawText):

1:43 PM Changeset in webkit [13196] by hyatt

6 edits in trunk/WebCore

Remove unused parameters from drawText.

1:28 PM Changeset in webkit [13195] by hyatt

1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Remove FontRendererWin.

1:21 PM Changeset in webkit [13194] by eseidel

4 edits
1 add in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Add very basic text support.
Sort a few more stubs.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::drawText):
platform/win/FontWin.cpp: Added. (WebCore::Font::drawText):
platform/win/TemporaryLinkStubs.cpp: (QComboBox::focusPolicy): (ScrollView::scrollXOffset): (Font::isFixedPitch): (Path::boundingRect):

12:48 PM Changeset in webkit [13193] by adele

3 edits in trunk/LayoutTests

Updating tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7319
Can't see caret at the end of a contenteditable div with overflow:hidden

fast/clip/outline-overflowClip-expected.txt:
fast/overflow/overflow-focus-ring-expected.txt:

11:54 AM Changeset in webkit [13192] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7319 Can't see caret at the end of a contenteditable div with overflow:hidden

No tests added since I don't think the blinking caret will show up in our tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::rightmostPosition): When calculating the rightmostPosition for editable blocks, we need to account for the caret that can be drawn 1 px past the last child inline box.

9:36 AM Changeset in webkit [13191] by darin

7 edits
14 adds
5 deletes in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

fast/js/exception-linenums-in-html-1-expected.txt: Added.
fast/js/exception-linenums-in-html-1.html: Added.

Tests line numbers from HTML source files instead of JavaScript source files
which is tested by fast/js/exception-linenums.html. This test does not test
changes made for Bug 3905, but was added for better coverage.

fast/js/exception-linenums-in-html-2-expected.txt: Added.
fast/js/exception-linenums-in-html-2.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <title> tag, which causes the code path for Bug 3905 to be tested.

fast/js/missing-title-end-tag-js-expected.txt: Added.
fast/js/missing-title-end-tag-js.html: Added.

While developing a fix for Bug 3905, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

fast/tokenizer/missing-title-end-tag-1-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-1-expected.png: Added.
fast/tokenizer/missing-title-end-tag-1-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-1.html: Added.
fast/tokenizer/missing-title-end-tag-2-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-2-expected.png: Added.
fast/tokenizer/missing-title-end-tag-2-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-2.html: Added.

The first test case contains an unclosed <title> tag in <head>, while the
second test case contains an unclosed <title> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/missing-title-end-tag-js.html
Test: fast/tokenizer/missing-title-end-tag-1.html
Test: fast/tokenizer/missing-title-end-tag-2.html

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </title> tag and handle this condition if identified.
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </title> tag, reset the state of the tokenizer and retokenize with no special handling for <title>. The parser will handle the missing </title> tag in HTMLParser::handleError().
platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): Added copy constructor. (WebCore::SegmentedString::operator=): Added assignment operator. Previously the compiler was generating a default method for the assignment operator, but it did not handle m_currentChar properly.
platform/SegmentedString.h: Added prototypes for copy constructor and assignment operator.

9:33 AM Changeset in webkit [13190] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming ideas.

1:28 AM Changeset in webkit [13189] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Fix win32 link stubs.

platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage):

1:21 AM Changeset in webkit [13188] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Still more tweaks to renaming.

1:03 AM Changeset in webkit [13187] by darin

43 edits
2 copies
7 moves
6 deletes in trunk/WebCore

Reviewed by Adele, except for the first change listed.

fix recently-introduced bug that GuardMalloc found while I was debugging my other change

rendering/render_frames.cpp: (WebCore::RenderPart::~RenderPart): Set m_widget to 0 before calling deref so we don't end up trying to do unwanted work.

removed 10 more files from KWQ

ForwardingHeaders/klocale.h: Removed.

khtml/misc/helper.cpp: Removed.
khtml/misc/helper.h: Removed.

kwq/KWQCollection.h: Removed.
kwq/KWQKCookieJar.h: Removed.
kwq/KWQKCookieJar.mm: Removed.
kwq/KWQKLocale.h: Removed.
kwq/KWQKLocale.mm: Removed.
kwq/KWQKURL.h: Removed.
kwq/KWQKURL.mm: Removed.
kwq/KWQTextUtilities.h: Removed.
kwq/KWQTextUtilities.mm: Removed.
kwq/KWQView.h: Removed.

platform/CookieJar.h: Added.
platform/Language.h: Added.
platform/LocalizedStrings.h: Added.
platform/TextBoundaries.h: Added.
platform/mac/CookieJar.mm: Added.
platform/mac/Language.mm: Added.
platform/mac/LocalizedStringsMac.mm: Added.
platform/mac/TextBoundaries.mm: Added.
platform/mac/WebCoreWidgetHolder.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removed and added files.

bridge/mac/WebCoreFrameBridge.mm: Updated includes. (-[WebCoreFrameBridge elementForView:]): Changed KWQWidgetHolder to WebCoreWidgetHolder.

editing/visible_units.cpp: (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): Call TextBoundaries.h functions instead of helper.h ones.

khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
ksvg2/svg/SVGTestsImpl.cpp: (WebCore::SVGTestsImpl::isValid): Changed to call defaultLanguage; cleaned up formatting.

khtml/html/HTMLFormElementImpl.cpp: Removed stray comment.

khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::cookie): (WebCore::HTMLDocumentImpl::setCookie): Call CookieJar.h functions.

css/css_valueimpl.cpp:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/DocumentImpl.cpp:
dom/dom_position.cpp:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLInputElementImpl.cpp:
khtml/html/html_headimpl.cpp:
khtml/html/htmlparser.cpp:
khtml/misc/decoder.cpp:
ksvg2/svg/SVGDocumentImpl.cpp:
kwq/KWQComboBox.mm:
kwq/KWQKSSLKeyGen.mm:
kwq/KWQListBox.mm:
kwq/KWQListImpl.cpp:
kwq/KWQListImpl.h:
kwq/KWQScrollBar.mm:
kwq/KWQSlider.mm:
kwq/KWQTextField.mm:
kwq/KWQValueList.h:
loader/DocLoader.cpp:
page/Frame.cpp:
page/FrameView.cpp:
platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
rendering/render_applet.cpp:
rendering/render_form.cpp:
rendering/render_image.cpp:
rendering/render_list.cpp: Updated includes and protocol names.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::write): Remove QT_VERSION code.
platform/QString.h: Remove QT_VERSION.

kwq/KWQPtrList.h: Change to no longer use QPtrCollection.

kwq/KWQRenderTreeDebug.h:
kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove unused debuggingRenderTree boolean.

12:21 AM Changeset in webkit [13186] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

platform/mac/GraphicsContextMac.mm: Add Widget.h to fix no-svg build.

Mar 6, 2006:

11:35 PM Changeset in webkit [13185] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming tweaks.

10:54 PM Changeset in webkit [13184] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Add some more planned renaming.

6:05 PM Changeset in webkit [13183] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4457574> assertion failure watching trailers at netflix.com -[WebNetscapePluginRepresentation
receivedData:withDataSource:] + 684

Plugins/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): Moved the ASSERT(instance) to the block that actually requires an assertion -- the plugin view should never have a NULL instance by the time we start the NPStream (by calling -startStreamWithResponse:). Some stream teardown logic changed with my fix to 4153419: when a WebBaseNetscapePluginStream is destroyed, it now clears its NPP instance backpointer. The WebBaseNetscapePluginStream may be destroyed from within -startStreamWithResponse: if NPP_NewStream() returns an error. We can handle this gracefully by changing the assertion before -receivedData: to a simple NULL check. This is unrelated to the Radar, but prior to this fix, we would attempt an NPP_Write() with the initial stream data even if NPP_NewStream() returned an error. Seems like that alone could cause issues, though I'm guessing that plugins handle this in practice.

4:38 PM Changeset in webkit [13182] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Make spinneret run again, fix webview to support dynamic resize.

platform/win/TemporaryLinkStubs.cpp: (Widget::setDrawingAlpha):
platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setClient): (WebCore::Widget::client): (WebCore::Widget::frameGeometry):

3:41 PM Changeset in webkit [13181] by bdakin

1 edit
4 adds in trunk/LayoutTests

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566

3:36 PM Changeset in webkit [13180] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix win32 build.

platform/win/TemporaryLinkStubs.cpp: (QScrollBar::QScrollBar): (QTextEdit::setAlignment): (Widget::client): (Widget::setClient): (QLineEdit::setAlignment):

3:32 PM Changeset in webkit [13179] by bdakin

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566 (also
<rdar://problem/4467128> ). Must call update() on a Font before
attempting to use it because the FontRenderer is not created until
update() is called.

3:17 PM Changeset in webkit [13178] by eseidel

2 edits in trunk/WebKitTools

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint): force layout before painting

3:10 PM Changeset in webkit [13177] by darin

3 edits in trunk/WebKitSite

Reviewed by Darin.

Change "Mail.app" to "Mail".

index.html:
projects/editing/index.html:

3:09 PM Changeset in webkit [13176] by darin

58 edits
1 add
11 deletes in trunk/WebCore

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7564 remove QObject, QGuardedPtr, slots, and signals

I had written a detailed change log entry, but I lost it!
I'm too annoyed to write one all over again.

ForwardingHeaders/qguardedptr.h: Removed.
ForwardingHeaders/qobject.h: Removed.

kwq/KWQGuardedPtr.cpp: Removed.
kwq/KWQGuardedPtr.h: Removed.
kwq/KWQNamespace.h: Removed.
kwq/KWQObject.cpp: Removed.
kwq/KWQObject.h: Removed.
kwq/KWQSignal.cpp: Removed.
kwq/KWQSignal.h: Removed.
kwq/KWQSlot.cpp: Removed.
kwq/KWQSlot.h: Removed.

platform/WidgetClient.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

bindings/js/JSDOMCore.cpp: Touched.
bindings/js/JSDOMEvents.cpp: Ditto.

bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementForView:]):
dom/CDATASectionImpl.cpp: (WebCore::CDATASectionImpl::cloneNode):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl):
dom/DocumentImpl.h:
kcanvas/device/KRenderingDevice.h:
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
khtml/ecma/kjs_window.cpp: (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::createTokenizer):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::finished):
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::processToken): (WebCore::parseHTMLDocumentFragment):
khtml/html/htmltokenizer.h:
kwq/KWQComboBox.h:
kwq/KWQComboBox.mm: (-[KWQPopUpButton setPopulatingMenu:QComboBox:::]): (QComboBox::itemSelected): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
kwq/KWQFileButton.h: (KWQFileButton::filename):
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::filenameChanged): (-[KWQFileButtonAdapter filenameChanged:]): (-[KWQFileButtonAdapter focusChanged:]): (-[KWQFileButtonAdapter clicked]):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setAlignment): (KWQNSTextAlignment):
kwq/KWQListBox.h: (QListBox::changingSelection):
kwq/KWQListBox.mm: (QListBox::QListBox): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView tableViewSelectionDidChange:]):
kwq/KWQScrollBar.h: (WebCore::): (QScrollBar::orientation):
kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (QScrollBar::QScrollBar): (QScrollBar::valueChanged): (QScrollBar::scroll):
kwq/KWQSlider.h:
kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider slide:]): (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (QSlider::QSlider): (QSlider::sliderValueChanged): (QSlider::dimensions):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textViewDidChangeSelection:]): (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView mouseDown:]): (-[KWQTextAreaTextView dispatchHTMLEvent:]):
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setAlignment):
kwq/KWQTextField.mm: (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController textViewDidChangeSelection:]):
loader/CachedObject.h:
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setOpener): (WebCore::Frame::nodeForWidget): (WebCore::Frame::disconnectOwnerRenderer):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
page/FrameView.cpp: (WebCore::FrameView::~FrameView):
platform/Brush.h:
platform/Pen.h:
platform/Widget.cpp: (WebCore::Widget::isFrameView):
platform/Widget.h: (WebCore::):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawText):
platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::focusPolicy): (WebCore::Widget::sendConsumedMouseUp): (WebCore::Widget::setClient): (WebCore::Widget::client):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::operator delete):
rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/render_form.cpp: (WebCore::RenderFormElement::clicked): (WebCore::RenderFormElement::textAlignment): (WebCore::RenderLineEdit::RenderLineEdit): (WebCore::RenderLineEdit::selectionChanged): (WebCore::RenderLineEdit::returnPressed): (WebCore::RenderLineEdit::performSearch): (WebCore::RenderLineEdit::valueChanged): (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::returnPressed): (WebCore::RenderFileButton::valueChanged): (WebCore::RenderLegend::RenderLegend): (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::createListBox): (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::valueChanged): (WebCore::RenderTextArea::selectionChanged): (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::valueChanged):
rendering/render_form.h: (WebCore::RenderFormElement::element): (WebCore::RenderLineEdit::element): (WebCore::RenderFileButton::element): (WebCore::RenderFileButton::isEditable): (WebCore::RenderSelect::element): (WebCore::RenderTextArea::element): (WebCore::RenderSlider::element):
rendering/render_frames.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart): (WebCore::RenderPart::setFrame): (WebCore::RenderPart::setWidget): (WebCore::RenderPart::deleteWidget): (WebCore::RenderFrame::RenderFrame): (WebCore::RenderPartObject::RenderPartObject): (WebCore::RenderPartObject::layout):
rendering/render_frames.h:
rendering/render_layer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::hitTest):
rendering/render_layer.h: (WebCore::RenderLayer::parent): (WebCore::RenderLayer::previousSibling): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::firstChild): (WebCore::RenderLayer::lastChild):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::~RenderWidget): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::layout): (WebCore::RenderWidget::sendConsumedMouseUp): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut): (WebCore::RenderWidget::scrollToVisible): (WebCore::RenderWidget::isVisible): (WebCore::RenderWidget::element): (WebCore::RenderWidget::deleteWidget):
rendering/render_replaced.h:
xml/xmlhttprequest.cpp: (WebCore::requestsByDocument): (WebCore::addToRequestsByDocument): (WebCore::removeFromRequestsByDocument): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getSpecificHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
xml/xmlhttprequest.h:

3:05 PM Changeset in webkit [13175] by ggaren

2 edits in trunk/WebKitSite

Oops, accidentally deleted the archives links.

blog/wp-content/themes/webkit/sidebar.php: Bring them back.

3:04 PM Changeset in webkit [13174] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Reorganize link stubs (alphabetically).
Stub out Path methods to make cnn.com work.

platform/win/TemporaryLinkStubs.cpp: (FrameView::viewportToGlobal): (FrameView::updateBorder): (FrameView::isFrameView): (FrameView::topLevelWidget): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (ScrollView::scrollXOffset): (QComboBox::focusPolicy): (QTextEdit::QTextEdit): (QTextEdit::~QTextEdit): (QTextEdit::textWithHardLineBreaks): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setColors): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QTextEdit::checksDescendantsForFocus): (QTextEdit::selectionStart): (QTextEdit::hasSelectedText): (QTextEdit::setReadOnly): (QTextEdit::setDisabled): (QTextEdit::setLineHeight): (QTextEdit::setSelectionStart): (QTextEdit::text): (QTextEdit::setWordWrap): (QTextEdit::setAlignment): (QTextEdit::getCursorPosition): (QTextEdit::setSelectionRange): (Widget::enableFlushDrawing): (Widget::isEnabled): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::setIsSelected): (Widget::unlockDrawingFocus): (KJavaAppletWidget::KJavaAppletWidget): (ScrollView::scrollPointRecursively): (ScrollView::scrollBy): (QLineEdit::selectAll): (QLineEdit::addSearchResult): (QLineEdit::selectionStart): (QLineEdit::hasSelectedText): (QLineEdit::selectedText): (QLineEdit::setAutoSaveName): (QLineEdit::checksDescendantsForFocus): (QLineEdit::setMaxResults): (GraphicsContext::GraphicsContext): (GraphicsContext::addFocusRingRect): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::drawFocusRing): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::drawHighlightForText): (GraphicsContext::misspellingLineThickness): (GraphicsContext::addRoundedRectClip): (QSlider::QSlider): (QSlider::sizeHint): (QSlider::setValue): (QSlider::setMaxValue): (QSlider::~QSlider): (QSlider::setFont): (QListBox::setFont): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setEnabled): (QListBox::clear): (QListBox::checksDescendantsForFocus): (KWQFileButton::KWQFileButton): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFilename): (KWQFileButton::baselinePosition): (KWQFileButton::setFrameGeometry): (QSlider::focusPolicy): (QListBox::focusPolicy): (Cursor::Cursor): (MouseEvent::MouseEvent): (KWQKCookieJar::cookieEnabled): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::createPlugin): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::inWindow): (Path::~Path): (Path::Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=):

2:57 PM Changeset in webkit [13173] by ggaren

3 edits in trunk/WebKitSite

Reviewed by Beth.

Some site cleanup.

blog/wp-content/themes/webkit/sidebar.php: sync with the sidebar for the rest of the site.
quality/lifecycle.html: add Joost's homepage to his contact info.

2:39 PM Changeset in webkit [13172] by ggaren

2 edits in trunk/WebKitSite

Doing penance after being set straight by Joost.

projects/compat/hitlist.html: Remove slur against QA. My humblest apologies.

2:33 PM Changeset in webkit [13171] by ggaren

3 edits
1 add in trunk/WebKitSite

Reviewed by Maciej, Darin.

Added Safari Compatibility Hit List.

nav.inc: Link to the hit list.
projects/compat/hitlist.html: Added.
projects/compat/index.html: Link to the hit list.

11:59 AM Changeset in webkit [13170] by ap

2 edits
3 copies in trunk/JavaScriptCore

Patch by David Carson, reviewed by Darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7582 c_utility.cpp contains CFString OS X platform-dependent code; should use ICU

Tested with test case from:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

bindings/c_utility.cpp (convertUTF8ToUTF16): Changed to using Unicode converter from ICU, and manual Latin-1 conversion.
icu/unicode/ucnv.h: Copied from WebCore.
icu/unicode/ucnv_err.h: Ditto.
icu/unicode/uenum.h: Ditto.

11:43 AM Changeset in webkit [13169] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

fast/lists/drag-into-marker-expected.checksum: Added.
fast/lists/drag-into-marker-expected.png: Added.
fast/lists/drag-into-marker-expected.txt: Added.
fast/lists/drag-into-marker.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

Call RenderObject::setInnerNode(), which sets both the
innerNode and the innerNonSharedNode.

rendering/render_list.cpp: (WebCore::RenderListItem::nodeAtPoint):
rendering/render_list.h:

WebKitTools:

Reviewed by darin

Sent the windowNumber when sending events.
Added leapForward so that we don't have to spend time waiting
in layout tests that do mouse operations that require delays.

DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController currentEventTime]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):

9:11 AM Changeset in webkit [13168] by darin

2 edits in trunk/WebCore

WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted files from the kwq directory.

8:50 AM Changeset in webkit [13167] by darin

147 edits
2 adds
2 deletes in trunk/WebCore

Reviewed by Maciej.

moved all the remnants of the public C++ DOM API out of khtml/dom
changed from "int" to "ExceptionCode" for DOM exceptions
removed unused CSS_HTML_RELATIVE
changed offsetInCharacters to be a member function of NodeImpl
changed DOM functions that take a NodeType to use NodeType instead of unsigned short for clarity (will still be unsigned short in bindings)
changed exception constants so they can be used directly in the implementation code (added in the offsets for different types of exceptions)
replaced the eventListenerType function with an isHTMLEventListener function
got rid of EventListenerEvent, which is a synonym for EventImpl*
eliminated handleEventImpl, whish is now the same as handleEvent

did other preparation for the "remove Impl suffix" renaming (tested by using a script that does the renaming)

khtml/dom/css_rule.h: Removed.
khtml/dom/css_stylesheet.h: Removed.
khtml/dom/css_value.h: Removed.
khtml/dom/dom2_events.cpp: Removed.
khtml/dom/dom2_events.h: Removed.
khtml/dom/dom2_range.h: Removed.
khtml/dom/dom2_traversal.cpp: Removed.
khtml/dom/dom2_traversal.h: Removed.
khtml/dom/dom_exception.h: Removed.
khtml/dom/dom_node.h: Removed.

dom/EventListener.h: Added.
dom/ExceptionCode.h: Added.

WebCore+SVG/kdom.h: Removed NodeType and ExceptionCodes
WebCore+SVG/kdomevents.h: Removed.

WebCore.xcodeproj/project.pbxproj: Updated for file changes.
WebCore.xcodeproj/project.pbxproj: Updated for file changes.

bindings/scripts/CodeGeneratorJS.pm: Removed unneeded DOM:: prefix. Updated file names and exception prefix for changes in DOM exceptions.

bindings/js/JSDOMCore.cpp: Touched to cause auto-generated code to be recompiled. We need to get this fixed!
bindings/js/JSDOMEvents.cpp: Ditto.

dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
dom/WheelEvent.idl: Touched all IDL files so that changes in CodeGeneratorJS.pm would take effect. Added license headers.

bindings/objc/DOM.mm: Fixed garbled license agreement. Updated includes. Changed from a single "using namespace WebCore" to individual using statements because of the imminent conflict between DOMImplementation in Objective C and WebCore::DOMImplementation (currently has an Impl suffix). Added a typedef for WebCore::DOMImplementationImpl. Changed to use ExceptionCode instead of int.

bindings/objc/DOMCSS.h: Removed DOMCSSException and the special CSS exception codes. This is a feature of DOM Level 1 only. In DOM Level 2 these were eliminated and use basic DOM exception codes instead. We might have to do something for binary compatibility eventually, but perhaps not.

bindings/objc/DOMCSS.mm:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMEventsInternal.h:
bindings/objc/DOMHTML.mm:
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMViews.mm:
bindings/objc/DOMViewsInternal.h: Fixed garbled license agreements. Changed to use ExceptionCode instead of int and name the variable "ec".

bindings/objc/DOMInternal.h: Changed addDOMWrapperImpl to take NSObject* instead of id. This helps with overload resolution when addDOMWrapperImpl is renamed to be addDOMWrapper. Changed ALLOW_DOM_CAST to always use "class" in from of the type name of the WebCore class. This helps work around what seems like a bug in namespace support in Objective-C mode, although the bug only happens after the "remove Impl" renaming.
bindings/objc/DOMInternal.mm: (getDOMWrapperImpl): Changed to use HashMap. (addDOMWrapperImpl): Ditto. (removeDOMWrapper): Ditto. (raiseDOMException): Update to use new names for exception number ranges.

bridge/mac/WebCoreFrameBridge.mm:
khtml/ecma/xmlserializer.cpp:
kwq/KWQAccObject.mm: Removed unneeded includes.

css/css_ruleimpl.h: Moved "rule type" into this header.

dom/CommentImpl.h:
dom/CommentImpl.cpp: (WebCore::CommentImpl::offsetInCharacters): Added. Returns true.

khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): Changed this around so we don't have a local variable named docImpl.

khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Updated for new form of exception constants.

khtml/ecma/kjs_events.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Changed to no longer use EventListenerEvent. (KJS::JSAbstractEventListener::isHTMLEventListener): Added.

rendering/RenderTextField.h: Updated includes. Tweaked the code formatting of InputMutationListener. (Might be unnecessary since this class might be deleted soon.)

bridge/mac/MacFrame.mm:
css/css_computedstyle.cpp:
css/css_computedstyle.h:
css/css_ruleimpl.cpp:
css/css_stylesheetimpl.cpp:
css/css_stylesheetimpl.h:
css/css_valueimpl.cpp:
css/css_valueimpl.cpp:
css/css_valueimpl.h:
css/css_valueimpl.h:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/CDATASectionImpl.cpp:
dom/CDATASectionImpl.h:
dom/CharacterDataImpl.cpp:
dom/CharacterDataImpl.h:
dom/ContainerNodeImpl.cpp:
dom/DOMImplementationImpl.cpp:
dom/DocumentFragmentImpl.cpp:
dom/DocumentFragmentImpl.h:
dom/DocumentImpl.cpp:
dom/DocumentImpl.h:
dom/DocumentTypeImpl.cpp:
dom/DocumentTypeImpl.h:
dom/NamedNodeMapImpl.h:
dom/NodeImpl.cpp:
dom/NodeImpl.h:
dom/NodeListImpl.cpp:
dom/TextImpl.cpp:
dom/TextImpl.h:
dom/dom2_eventsimpl.cpp:
dom/dom2_eventsimpl.h:
dom/dom2_rangeimpl.cpp:
dom/dom2_rangeimpl.h:
dom/dom2_traversalimpl.cpp:
dom/dom2_traversalimpl.h:
dom/dom_elementimpl.cpp:
dom/dom_elementimpl.h:
dom/dom_position.cpp:
dom/dom_xmlimpl.cpp:
dom/dom_xmlimpl.h:
dom/xml_tokenizer.cpp:
editing/AppendNodeCommand.cpp:
editing/ApplyStyleCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/InsertIntoTextNodeCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertNodeBeforeCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/JoinTextNodesCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/RemoveNodeAttributeCommand.cpp:
editing/RemoveNodeCommand.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/Selection.cpp:
editing/SelectionController.cpp:
editing/SelectionController.h:
editing/SetNodeAttributeCommand.cpp:
editing/SplitElementCommand.cpp:
editing/SplitTextNodeCommand.cpp:
editing/VisiblePosition.cpp:
editing/WrapContentsInDummySpanCommand.cpp:
editing/htmlediting.cpp:
editing/markup.cpp:
editing/visible_text.cpp:
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_css.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_html.cpp:
khtml/ecma/kjs_range.cpp:
khtml/ecma/kjs_traversal.cpp:
khtml/ecma/kjs_traversal.h:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.h:
khtml/html/HTMLOptionsCollectionImpl.cpp:
khtml/html/HTMLSelectElementImpl.cpp:
khtml/html/HTMLTextAreaElementImpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_documentimpl.h:
khtml/html/html_headimpl.cpp:
khtml/html/html_tableimpl.cpp:
khtml/html/html_tableimpl.h:
khtml/html/htmlparser.cpp:
khtml/xbl/xbl_tokenizer.cpp:
khtml/xsl/xsl_stylesheetimpl.cpp:
ksvg2/misc/SVGDocumentExtensions.cpp:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.h:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGLengthImpl.cpp:
ksvg2/svg/SVGLocatableImpl.cpp:
ksvg2/svg/SVGPolyElementImpl.cpp:
ksvg2/svg/SVGSVGElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.h:
ksvg2/svg/SVGUseElementImpl.cpp:
page/Frame.cpp:
page/FrameView.cpp:
rendering/render_object.cpp:
xml/xmlhttprequest.cpp: Changed to use ExceptionCode instead of int and name the variable "ec". Also updated use of exception codes and other constants to get them from their new locations.

2:12 AM Changeset in webkit [13166] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix more pages (apple.com, yahoo.com) by returning empty error image.
Empty a couple more stubs and clean up stub style a little.

platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
platform/win/TemporaryLinkStubs.cpp: (QListBox::isSelected): (QSlider::sizeHint): (QScrollBar::~QScrollBar): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::recordFormValue): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::passWheelEventToChildWidget): (FrameWin::createPlugin): (BrowserExtensionWin::createNewWindow): (Path::Path): (QLineEdit::~QLineEdit): (QLineEdit::setLiveSearch): (QComboBox::~QComboBox):

1:15 AM Changeset in webkit [13165] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Empty enough stubs to make apple.com load.

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (GraphicsContext::misspellingLineThickness): (QTextEdit::selectAll): (QTextEdit::setSelectionStart): (Widget::unlockDrawingFocus): (QLineEdit::setAutoSaveName): (ScrollView::scrollYOffset): (KWQFileButton::setFilename): (QListBox::setFont): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (QComboBox::QComboBox): (QComboBox::setFont): (QComboBox::baselinePosition): (QComboBox::setWritingDirection): (QComboBox::clear): (QComboBox::appendItem): (QComboBox::setCurrentItem): (QComboBox::sizeHint): (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QLineEdit::setLiveSearch):

12:39 AM Changeset in webkit [13164] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix external resource loading.
Make a bunch of stubs not abort (to fix slashdot).

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (KWQFileButton::click): (QComboBox::setFrameGeometry): (QTextEdit::setText): (QListBox::appendItem): (GraphicsContext::endTransparencyLayer): (QLineEdit::selectionStart): (QTextEdit::QTextEdit): (QListBox::isSelected): (QComboBox::focusPolicy): (QTextEdit::setCursorPosition): (QTextEdit::setAlignment): (QLineEdit::selectedText): (ScrollView::scrollPointRecursively): (QScrollBar::setSteps): (QComboBox::appendItem): (GraphicsContext::drawLineForMisspelling): (KWQFileButton::setFilename): (QListBox::setWritingDirection): (QListBox::focusPolicy): (MouseEvent::MouseEvent): (QSlider::setFont): (Widget::setEnabled): (Widget::paint): (ScrollView::addChild): (ScrollView::inWindow): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField): (QLineEdit::QLineEdit): (QLineEdit::setFont): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (QLineEdit::maxLength): (QLineEdit::setMaxLength): (QLineEdit::text): (QLineEdit::setText): (QLineEdit::cursorPosition): (QLineEdit::setCursorPosition): (QLineEdit::setEdited): (QLineEdit::setReadOnly): (QLineEdit::setPlaceholderString): (QLineEdit::setColors): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):

Mar 5, 2006:

11:38 PM Changeset in webkit [13163] by ggaren

2 edits in trunk/LayoutTests

Checked in new results for the test I just landed. Looks like I landed an old copy.

fast/dom/prototype-chain-expected.txt:

11:23 PM Changeset in webkit [13162] by darin

1 edit in trunk/WebCore/ChangeLog

Fix typo.

11:22 PM Changeset in webkit [13161] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fix failure seen running editing layout tests

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use selectNodeContents instead of rolling our own. It handles the "nothing at all" edget case properly.

11:18 PM Changeset in webkit [13160] by eseidel

3 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make updateContents invalidate entire window for now.
Fix indentation in fileLoadTimer.

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

10:26 PM Changeset in webkit [13159] by eseidel

17 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Add missing files to vcproj (fix win32 build).
Also add svn:eol-style=native to new files.

WebCore.vcproj/WebCore/WebCore.vcproj:

10:06 PM Changeset in webkit [13158] by darin

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated.

9:55 PM Changeset in webkit [13157] by darin

2 edits in trunk/WebCore

fix build

rendering/render_style.h: (compareEqual): Made it inline, fixed variable name.

9:52 PM Changeset in webkit [13156] by adele

12 edits
6 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
Implement maxlength for new text fields

fast/forms/input-appearance-maxlength-expected.txt: Added.
fast/forms/input-appearance-maxlength.html: Added.

WebCore:

Reviewed by Darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6987 Implement maxlength for new text fields

Test added:

fast/forms/input-appearance-maxlength.html

WebCore.xcodeproj/project.pbxproj: Added BeforeTextInsertedEventImpl.h, BeforeTextInsertedEventImpl.cpp, HTMLTextFieldInnerElementImpl.h, and HTMLTextFieldInnerElementImpl.cpp

khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::init): initialize max length to 1024. (WebCore::HTMLInputElementImpl::defaultEventHandler): Added case to use the khtmlBeforeTextInsertedEvent to check for maxlength. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Makes sure that maxlength is between 0 and 1024.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): After doing a test insert of the fragment, Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text, and we can update the fragment.
editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text if necessary.
editing/EditCommand.cpp: (WebCore::EditCommand::apply): If we've just applied a command, send the khtmlTextInsertedEvent to the root editable element. (WebCore::EditCommand::unapply): ditto. (WebCore::EditCommand::reapply): ditto.

khtml/html/HTMLTextFieldInnerElementImpl.h: Added this class to store a pointer to the input element for the text field and to handle default events. (DOM::HTMLTextFieldInnerElementImpl::shadowParentNode): Added. (DOM::HTMLTextFieldInnerElementImpl::setShadowParentNode): Added.
khtml/html/HTMLTextFieldInnerElementImpl.cpp: Added. (WebCore::HTMLTextFieldInnerElementImpl::HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::~HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler): Sends khtmlBeforeTextInsertedEvents to the shadowParentNode, and handles khtmlTextInsertedEvents by telling the renderer that the subtree has changed.

rendering/RenderTextField.cpp: Removed InputMutationListener since subtreeHasChanged is now called from the editing code. (WebCore::RenderTextField::~RenderTextField): removed event listener code. (WebCore::RenderTextField::updateFromElement): ditto. And creates HTMLTextFieldInnerElementImpl. (WebCore::RenderTextField::subtreeHasChanged): calls new text() method. (WebCore::RenderTextField::text): created to get a String of all text in the RenderTextField.
rendering/RenderTextField.h: Removed InputMutationListener class.

dom/EventNames.h: Added khtmlTextInserted and khtmlBeforeTextInserted.
dom/BeforeTextInsertedEventImpl.cpp: Added. (WebCore::BeforeTextInsertedEventImpl::BeforeTextInsertedEventImpl):
dom/BeforeTextInsertedEventImpl.h: Added. (WebCore::BeforeTextInsertedEventImpl::isBeforeTextInsertedEvent): (WebCore::BeforeTextInsertedEventImpl::text):
dom/dom2_eventsimpl.cpp: (WebCore::EventImpl::isBeforeTextInsertedEvent): Added.
dom/dom2_eventsimpl.h: Added isBeforeTextInsertedEvent.

9:47 PM Changeset in webkit [13155] by mjs

2 edits in trunk/WebCore

fix build, give this a return type.

rendering/render_style.h: (compareEqual):

9:32 PM Changeset in webkit [13154] by ap

2 edits in trunk/JavaScriptCore

Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7601 REGRESSION (r13089): Reproducible crash dereferencing a deallocated element on google image search

kxmlcore/Platform.h: Corrected the define to enable USE(MULTIPLE_THREADS) on Mac OS X.

9:29 PM Changeset in webkit [13153] by darin

6 edits
2 copies in trunk/JavaScriptCore

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7616 get all references to KJS::Node out of internal.h

JavaScriptCore.xcodeproj/project.pbxproj: Updated for file changes.

kjs/Parser.cpp: Added.
kjs/Parser.h: Added.

kjs/internal.cpp: Removed the Parser class.
kjs/internal.h: Ditto. Also removed unnecessary declarations of classes not used in this header.

kjs/nodes.h: Added an include of "Parser.h".
kjs/function.h: Added a declaration of FunctionBodyNode.

8:56 PM Changeset in webkit [13152] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Add "Font.h" to (try to) fix the no-svg build.

platform/mac/GraphicsContextMac.mm:

8:55 PM Changeset in webkit [13151] by mjs

2 edits in trunk/WebCore

Rubber stamped by Darin.

fix win32 build by avoiding use of typeof

rendering/render_style.h: (compareEqual):

7:58 PM Changeset in webkit [13150] by ggaren

21 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

JSC support for the fix for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

kjs/lookup.h: (1) Added the KJS_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro. The class definiton macro needs to know about the prototype's prototype so that the class constructor properly sets it. (2) Removed the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro. The class implementation macro does not need to know about the prototype's prototype, since getOwnPropertySlot should only look in the current object's property map, and not its prototype's.

LayoutTests:

Reviewed by Maciej.

Layout test for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

fast/dom/prototype-chain-expected.txt: Added.
fast/dom/prototype-chain.html: Added.

WebCore:

Reviewed by Maciej.

Second cut at fixing <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

The approach here is for prototypes, in their constructor methods,
to set their own prototypes, preserving the prototype
chain in cases of multiple levels of inheritance. (Previously, our
code assumed that a prototype never had a prototype of its own,
and always used an empty object as a prototype's prototype).

bindings/scripts/CodeGeneratorJS.pm: Use the new DEFINE_PROTOTYPE_WITH_PROTOTYPE macro in place of the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro.
khtml/ecma/kjs_dom.cpp: Ditto.
khtml/ecma/kjs_dom.h: Ditto.
khtml/ecma/kjs_events.cpp: Ditto.

Touched these files to force a rebuild:

bindings/js/JSDOMCore.cpp:
bindings/js/JSDOMEvents.cpp:
dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
dom/WheelEvent.idl:

6:53 PM Changeset in webkit [13149] by mjs

40 edits in trunk/WebCore

Reviewed by Darin.

use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL) http://bugzilla.opendarwin.org/show_bug.cgi?id=7618

css/css_base.cpp: (WebCore::CSSSelector::operator == ): (WebCore::CSSSelector::selectorText):
css/css_base.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::relation):
css/css_grammar.y:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
kcanvas/KCanvasPath.h: (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::addPath):
kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
khtml/ecma/kjs_html.h:
khtml/html/HTMLButtonElementImpl.h:
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setInputType):
khtml/html/HTMLInputElementImpl.h: (DOM::HTMLInputElementImpl::inputType):
khtml/html/html_tableimpl.h:
khtml/xbl/xbl_protohandler.cpp: (XBL::m_button):
khtml/xbl/xbl_protohandler.h:
ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::): (WebCore::SVGRenderStyle::setBitDefaults):
ksvg2/svg/SVGAnimateTransformElementImpl.h:
ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
ksvg2/svg/SVGAnimationElementImpl.h:
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
ksvg2/svg/SVGLengthImpl.h:
kwq/KWQKHTMLSettings.h:
loader/CachedImage.h:
loader/DocLoader.cpp: (WebCore::DocLoader::setCachePolicy): (WebCore::DocLoader::setShowAnimations):
loader/DocLoader.h: (WebCore::DocLoader::showAnimations):
platform/FontDescription.h: (WebCore::FontDescription::genericFamily):
platform/QString.cpp: (HandleNode::):
platform/QString.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
rendering/RenderBlock.h: (WebCore::RenderBlock::selectionState): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::FloatingObject::type):
rendering/RenderTable.h: (WebCore::RenderTable::getRules):
rendering/bidi.cpp: (khtml::BidiContext::BidiContext): (khtml::operator==): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):
rendering/bidi.h: (khtml::BidiContext::dir): (khtml::BidiContext::basicDir): (khtml::BidiRun::BidiRun):
rendering/render_canvasimage.h:
rendering/render_layer.h: (WebCore::Marquee::whiteSpace):
rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
rendering/render_replaced.cpp: (WebCore::RenderWidget::setSelectionState):
rendering/render_replaced.h: (WebCore::RenderReplaced::selectionState):
rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle):
rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderValue::style): (khtml::BorderValue::nonZero): (khtml::BorderValue::operator==): (khtml::OutlineValue::operator==): (khtml::CollapsedBorderValue::style): (khtml::BorderImage::horizontalRule): (khtml::BorderImage::verticalRule): (khtml::BorderData::borderLeftWidth): (khtml::BorderData::borderRightWidth): (khtml::BorderData::borderTopWidth): (khtml::BorderData::borderBottomWidth): (khtml::BackgroundLayer::backgroundClip): (khtml::BackgroundLayer::backgroundOrigin): (khtml::BackgroundLayer::backgroundRepeat): (khtml::RenderStyle::styleType): (khtml::RenderStyle::display): (khtml::RenderStyle::originalDisplay): (khtml::RenderStyle::position): (khtml::RenderStyle::floating): (khtml::RenderStyle::borderLeftStyle): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightStyle): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopStyle): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomStyle): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::overflow): (khtml::RenderStyle::visibility): (khtml::RenderStyle::verticalAlign): (khtml::RenderStyle::unicodeBidi): (khtml::RenderStyle::clear): (khtml::RenderStyle::tableLayout): (khtml::RenderStyle::textAlign): (khtml::RenderStyle::textTransform): (khtml::RenderStyle::direction): (khtml::RenderStyle::whiteSpace): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundClip): (khtml::RenderStyle::backgroundOrigin): (khtml::RenderStyle::emptyCells): (khtml::RenderStyle::captionSide): (khtml::RenderStyle::listStyleType): (khtml::RenderStyle::listStylePosition): (khtml::RenderStyle::cursor): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::appearance): (khtml::RenderStyle::boxAlign): (khtml::RenderStyle::boxDirection): (khtml::RenderStyle::boxLines): (khtml::RenderStyle::boxOrient): (khtml::RenderStyle::boxPack): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::userModify): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::wordWrap): (khtml::RenderStyle::nbspMode): (khtml::RenderStyle::khtmlLineBreak): (khtml::RenderStyle::matchNearestMailBlockquoteColor): (khtml::RenderStyle::setBorderLeftWidth): (khtml::RenderStyle::setBorderLeftStyle): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightWidth): (khtml::RenderStyle::setBorderRightStyle): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopWidth): (khtml::RenderStyle::setBorderTopStyle): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomWidth): (khtml::RenderStyle::setBorderBottomStyle): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::pseudoState):

12:36 PM Changeset in webkit [13148] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Fix a couple of things found while testing. Script now works (after landing my two pending patches).

12:25 PM Changeset in webkit [13147] by ggaren

2 edits in trunk/WebCore

Rolled out the fix for <rdar://problem/4467143> because it's the wrong approach. Maciej and I discussed this on IRC.

khtml/ecma/kjs_dom.cpp: (KJS::): Don't use classInfo to express prototype inheritance. classInfo is only for representing a c++ superclass relationship.

11:59 AM Changeset in webkit [13146] by darin

1 edit
1 add in trunk/WebKitTools

check in a script to do a "big" rename in WebCore (can be run whenever we're ready to do it)

Scripts/do-webcore-rename: Added.

9:11 AM Changeset in webkit [13145] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Move improperly placed #endif causing no-svg build to fail.

kcanvas/device/quartz/KRenderingDeviceQuartz.h:

6:36 AM Changeset in webkit [13144] by lypanov

1 edit
6 adds in trunk/LayoutTests

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

missing results from previous commit

svg/custom/polyline-invalid-points-expected.checksum: Added.
svg/custom/polyline-invalid-points-expected.png: Added.
svg/custom/polyline-invalid-points-expected.txt: Added.
svg/custom/polyline-setattribute-points-null-expected.checksum: Added.
svg/custom/polyline-setattribute-points-null-expected.png: Added.
svg/custom/polyline-setattribute-points-null-expected.txt: Added.

6:33 AM Changeset in webkit [13143] by lypanov

3 edits
2 adds in trunk

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

new reduced testcases for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 http://bugzilla.opendarwin.org/show_bug.cgi?id=6890

svg/custom/polyline-invalid-points.svg: Added.
svg/custom/polyline-setattribute-points-null.svg: Added.

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6890 and http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 by being more tolerant towards invalid points data

new tests: svg/custom/polyline-setattribute-points-null.svg svg/custom/polyline-invalid-points.svg

ksvg2/svg/svgpathparser.cpp: (SVGPolyParser::parsePoints):

3:27 AM Changeset in webkit [13142] by mjs

3 edits
3 deletes in trunk/WebCore

Rubber stamped by Eric.

remove no longer used KDOMSettings and KSVGSettings

WebCore+SVG/KDOMSettings.cpp: Removed.
WebCore+SVG/KDOMSettings.h: Removed.
WebCore.xcodeproj/project.pbxproj:
ksvg2/KSVGSettings.h: Removed.
ksvg2/svg/SVGStyledElementImpl.cpp:

3:12 AM Changeset in webkit [13141] by mjs

2 edits in trunk/WebKitTools

Reviewed by Eric.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Close file when done.

2:30 AM Changeset in webkit [13140] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

platform/Font.cpp: (WebCore::Font::update): remove extra ref causing large leak.

2:10 AM Changeset in webkit [13139] by ap

5 edits
4 adds in trunk

Fix by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7589 Mouse moved events do not work in DumpRenderTree

WebKitTools:

DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseMoveToX:Y:]): Pass the correct windowNumber in the event.

LayoutTests:

fast/css/hover-subselector-expected.txt: Updated results.
fast/css/hover-subselector.html: Changed to work with the new mechanism.
fast/events/event-sender-mouse-moved-expected.checksum: Added.
fast/events/event-sender-mouse-moved-expected.png: Added.
fast/events/event-sender-mouse-moved-expected.txt: Added.
fast/events/event-sender-mouse-moved.html: Added.

1:43 AM Changeset in webkit [13138] by ap

3 edits in trunk/JavaScriptCore

Patch by Andrew Wellington, reviewed by Eric.

Remove unused breakpoint bool from StatementNodes. No test provided as there is no functionality change.

kjs/nodes.cpp: (StatementNode::StatementNode):
kjs/nodes.h:

1:42 AM Changeset in webkit [13137] by eseidel

5 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Take advantage of new GraphicsContext constructor to implement double buffering to avoid tearing.
Disable background erase to avoid tearing.
Fix potential memory smasher from extra long urls.

Spinneret/Spinneret/Spinneret.cpp: (MyRegisterClass):
Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::paint):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance):

1:41 AM Changeset in webkit [13136] by eseidel

9 edits in trunk/WebCore

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Re-work ImageViewer to use GraphicsContext.
Add GraphicsContext(cairo_t*) constructor to make double-buffering easier.
Add one more stub to prevent slashdot from crashing.
Also fixed win32 build after Font change.

Viewer.vcproj:
Viewer/ImageView.cpp:
platform/Color.h:
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

1:35 AM Changeset in webkit [13135] by ap

6 edits
1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4840 Frames only resize wider, can't make them narrower

khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): Removed unused m_resizing flag.
khtml/html/html_baseimpl.h:
manual-tests/bugzilla-4840.html: Added.
page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::setResizingFrameSet): New method. When a resizing frameset is set, mouse move and mouse release events target it instead of hit-testing.
page/FrameView.h:
rendering/render_frames.cpp: (WebCore::RenderFrameSet::setResizing): Inform the FrameView that we are resizing (or not).

Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt

23 edits
2 adds
2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

WebCore.xcodeproj/project.pbxproj:
css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
kwq/KWQFontMetrics.h: Removed.
kwq/KWQFontMetrics.mm: Removed.
platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
platform/GraphicsContext.h:
platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
platform/mac/GraphicsContextMac.mm:
rendering/InlineTextBox.h:
rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
rendering/RenderText.h:
rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
rendering/render_object.h:
rendering/render_style.h:

4:33 PM Changeset in webkit [13133] by eseidel

3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):

4:28 PM Changeset in webkit [13132] by eseidel

2 edits in trunk/WebCore

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):

3:07 PM Changeset in webkit [13131] by thatcher

2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap

2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

Scripts/run-webkit-tests:

3:05 PM Changeset in webkit [13129] by mjs

3 edits in trunk/WebCore

Reviewed by Eric.

stop background image loads from crashing

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):

fix termination condition on file load loop

platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

2:57 PM Changeset in webkit [13128] by thatcher

9 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

English.lproj/Localizable.strings: removed localized strings
WebInspector.subproj/WebInspector.m: (-init): (-dealloc): (-window): (-setSearchQuery:): (-resizeTopArea): (-searchPerformed:): called from JavaScript when a search happens (-_toggleIgnoreWhitespace:): (-_exitSearch:): exit search results on double click (-_focusRootNode:): (-_revealAndSelectNodeInTree:): (-_refreshSearch): (-_update): (-_updateTraversalButtons): (-_updateRoot): (-_updateTreeScrollbar): (-_updateSystemColors): update CSS with system colors (-webView:didFinishLoadForFrame:): (-webView:plugInViewWithArguments:): (-outlineViewSelectionDidChange:): test for webViewLoaded (-[WebInspectorPrivate init]): alloc rightArrowImage and downArrowImage (-[WebInspectorPrivate dealloc]): no more matchedRules (-[DOMNode _displayName]): removed localization UI_STRING calls.
WebInspector.subproj/WebInspectorInternal.h:
WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.html:
WebInspector.subproj/webInspector/inspector.js:

12:37 PM Changeset in webkit [13127] by ggaren

3 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.

3:02 AM Changeset in webkit [13126] by mjs

3 edits in trunk/WebKitTools

Reviewed by Eric.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.

2:58 AM Changeset in webkit [13125] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

2:26 AM Changeset in webkit [13124] by mjs

10 edits in trunk/WebCore

Reviewed by Eric.

make TransferJobWin handle file: URLs, and fix other bugs as needed to make local file image loads work http://bugzilla.opendarwin.org/show_bug.cgi?id=7587

WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
platform/TransferJob.h:
platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.

Mar 3, 2006:

11:42 PM Changeset in webkit [13123] by eseidel

5 edits
2 adds in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
rendering/RenderThemeWin.h: Added.

11:29 PM Changeset in webkit [13122] by eseidel

3 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
Scripts/run-webkit-tests:

5:35 PM Changeset in webkit [13121] by eseidel

5 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):

3:33 PM Changeset in webkit [13120] by ggaren

3 edits
1 add in trunk

JavaScriptCore:

Reviewed by Darin.

Fixed <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

manual-tests/property-map-save-crash.html: Added.

2:10 PM Changeset in webkit [13119] by lypanov

2 edits in trunk/LayoutTests

2006-03-03 Alexander Kellett <lypanov@kde.org>

local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.

svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:

11:43 AM Changeset in webkit [13118] by eseidel

3 edits in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):

7:59 AM Changeset in webkit [13117] by darin

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Eric.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7480 non-HTML elems w/o children in HTML docs get serialized self-closing
update tests for problem where the HTML tokenizer would discard the first newline after </pre>

fast/innerHTML/innerHTML-custom-tag.html: Added.
fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.

fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.

editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7480 non-HTML elems w/o children in HTML docs get serialized self-closing
fix problem where the HTML tokenizer would discard the first newline after </pre>

Test: fast/innerHTML/innerHTML-custom-tag.html

editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.

1:54 AM Changeset in webkit [13116] by eseidel

5 edits
2 adds in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
Spinneret/Spinneret/WebFrame.h: Added.
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

1:44 AM Changeset in webkit [13115] by mjs

3 edits
1 copy in trunk/WebCore

Rubber stamped by Eric.

add new files to build, fix link stubs.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
platform/win/TransferJobWin.cpp: Added.

1:31 AM Changeset in webkit [13114] by mjs

1 edit
1 add in trunk/WebCore

add file I forgot in my last commit.

platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):

1:30 AM Changeset in webkit [13113] by eseidel

10 edits
2 adds in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

Viewer/ImageDocument.h:
WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp:
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
platform/IntRect.h: (WebCore::IntRect::IntRect):
platform/Widget.h:
platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
platform/win/MouseEventWin.cpp:
platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):

1:19 AM Changeset in webkit [13112] by mjs

11 edits
1 copy
3 moves
2 deletes in trunk/WebCore

Reviewed by Eric.

move TransferJob from kwq to platform, separate platform from non-platform bits

ForwardingHeaders/kio/job.h: Removed.
ForwardingHeaders/kio/jobclasses.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm:
dom/xml_tokenizer.cpp:
khtml/xsl/xslt_processorimpl.cpp:
kwq/KWQKJobClasses.h: Removed.
kwq/KWQKJobClasses.mm: Removed.
kwq/KWQLoader.mm:
kwq/KWQResourceLoader.mm:
kwq/TransferJobClient.h: Removed.
loader/Cache.cpp:
loader/loader.cpp:
page/Frame.cpp:
platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
platform/TransferJob.h: Added.
platform/TransferJobClient.h: Added.
platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
xml/xmlhttprequest.cpp:

1:18 AM Changeset in webkit [13111] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint

platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):

Mar 2, 2006:

11:44 PM Changeset in webkit [13110] by mjs

2 edits in trunk/WebCore

Rubber stamped by Eric.

remove function that is now gone

platform/win/TemporaryLinkStubs.cpp:

11:41 PM Changeset in webkit [13109] by mjs

7 edits in trunk/WebCore

Reviewed by Eric.

move logic to kick off load from KWQLoader function to a TransferJob method

kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (WebCore::TransferJob::start):
kwq/KWQLoader.h:
kwq/KWQLoader.mm:
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

11:16 PM Changeset in webkit [13108] by mjs

5 edits in trunk/WebCore

Rubber stamped by Eric.

remove unused loader parameter to KWQServeRequest.

kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQServeRequest):
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

10:58 PM Changeset in webkit [13107] by mjs

5 edits in trunk/WebCore

Reviewed by Eric.

remove one of the versions of KWQServeRequest.

kwq/KWQLoader.h:
kwq/KWQLoader.mm:
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
platform/win/TemporaryLinkStubs.cpp: (Widget::isEnabled): (KWQServeRequest):

10:13 PM Changeset in webkit [13106] by mjs

2 edits in trunk/WebCore

Rubber stamped by Eric.

win32 build fix.

platform/win/MouseEventWin.cpp:

9:37 PM Changeset in webkit [13105] by eseidel

2 edits in trunk/WebKitSite

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

quality/reporting.html: display a nicer message to those using 10.2

6:53 PM Changeset in webkit [13104] by justing

5 edits in trunk/WebCore

Reviewed by eric

<http://bugzilla.opendarwin.org/show_bug.cgi?id=3894>
uses of <cmath> should change to <math>

ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGHelper.cpp:
ksvg2/svg/SVGLengthImpl.cpp:

5:52 PM Changeset in webkit [13103] by bdakin

8 edits
6 adds in trunk/LayoutTests

Reviewed by Darin, landed by Beth.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Update existing tests for new results and add new test

5:46 PM Changeset in webkit [13102] by bdakin

5 edits in trunk/WebCore

Reviewed by Darin, landed by Beth

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Does not use UBreakIterator (yet?) for this, but a relatively
simple change that fixes our failure in the CSS1 test suite
(5.4.5).

1:46 PM Changeset in webkit [13101] by eseidel

3 edits in trunk/WebKitTools

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

1:45 PM Changeset in webkit [13100] by justing

3 edits
4 adds in trunk

LayoutTests:

Patch reviewed by sullivan
Test written by mitz

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

fast/lists/scrolled-marker-paint-expected.checksum: Added.
fast/lists/scrolled-marker-paint-expected.png: Added.
fast/lists/scrolled-marker-paint-expected.txt: Added.
fast/lists/scrolled-marker-paint.html: Added.

WebCore:

Reviewed by sullivan

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

rendering/render_list.cpp: (WebCore::RenderListMarker::paint):

1:41 PM Changeset in webkit [13099] by eseidel

6 edits
2 adds in trunk/WebCore

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Add (partially stubbed out) mouse event handling for Win32.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/IntPoint.h:
platform/MouseEvent.h:
platform/win/IntPointWin.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINT):
platform/win/MouseEventWin.cpp: Added. (WebCore::MouseEvent::MouseEvent):
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setMaxLength): (ScrollView::scrollBy): (WebCore::Widget::setFocus): (FrameWin::respondToChangedSelection): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::registerCommandForUndo): (FrameWin::addMessageToConsole): (FrameWin::mimeTypeForFileName): (FrameWin::shouldChangeSelection): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::personalbarVisible): (FrameWin::objectContentType): (FrameWin::createFrame): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (FrameWin::passSubframeEventToSubframe): (FrameWin::lastEventIsMouseUp): (BrowserExtensionWin::BrowserExtensionWin): (Widget::setCursor): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents): (TransferJob::TransferJob): (TransferJob::addMetaData):

11:40 AM Changeset in webkit [13098] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by mjs

<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

editing/undo/undo-iframe-location-change-expected.txt: Added.
editing/undo/undo-iframe-location-change.html: Added.

WebCore:

Reviewed by mjs

<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

Can't clear undo/redo operations registered by subframes in didOpenURL,
because subframes have already been detached.

page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::closeURL):

11:37 AM Changeset in webkit [13097] by thatcher

1 copy in tags/WebCore-417.23/WebCore

New tag part two).

11:37 AM Changeset in webkit [13096] by thatcher

1 add in tags/WebCore-417.23

New tag.

11:35 AM Changeset in webkit [13095] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.23

11:32 AM Changeset in webkit [13094] by thatcher

7 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This also includes the http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 fix
<rdar://problem/4462712> REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

2006-02-17 Vicki Murley <vicki@apple.com>

Reviewed by Justin.

Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
rendering/render_replaced.h: Remove handleFocusOut().
rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.

2:35 AM Changeset in webkit [13093] by mjs

2 edits in trunk/JavaScriptCore

now fix mac build again

kjs/identifier.cpp:

2:20 AM Changeset in webkit [13092] by mjs

3 edits in trunk/JavaScriptCore

Rubber stamped by Anders and Eric.

add fpconst.cpp to win32 build, it is now needed

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/fpconst.cpp:

2:10 AM Changeset in webkit [13091] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by Eric.

fix windows build, broken by my last patch

kjs/JSImmediate.cpp:
kjs/identifier.cpp:
kxmlcore/FastMalloc.cpp:
kxmlcore/Platform.h:

1:21 AM Changeset in webkit [13090] by eseidel

52 edits in trunk

Add svn:eol-style=native, and fix line endings.

1:12 AM Changeset in webkit [13089] by mjs

62 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Set up new prototype macros and avoid using #if without defined() in JSC

Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
are defined, and to separate core OS-level dependencies from operating environment
dependencies so you can, e.g., build KDE on Mac or Windows.

kxmlcore/Platform.h: Added.

deploy them everywhere in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
bindings/objc/WebScriptObject.mm:
bindings/objc/objc_instance.mm: (ObjcInstance::end):
bindings/softlinking.h:
bindings/testbindings.mm: (main):
kjs/JSLock.cpp:
kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively):
kjs/config.h:
kjs/date_object.cpp: (gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::makeTime):
kjs/dtoa.cpp:
kjs/fpconst.cpp: (KJS::sizeof): (KJS::):
kjs/grammar.y:
kjs/identifier.cpp:
kjs/internal.cpp:
kjs/interpreter.cpp: (KJS::Interpreter::evaluate): (KJS::Interpreter::createLanguageInstanceForValue):
kjs/interpreter.h:
kjs/lookup.cpp:
kjs/lookup.h:
kjs/math_object.cpp:
kjs/object.cpp:
kjs/object.h:
kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf):
kjs/operations.h:
kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
kjs/regexp.h:
kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
kjs/ustring.cpp:
kjs/ustring.h:
kxmlcore/AlwaysInline.h:
kxmlcore/Assertions.cpp:
kxmlcore/Assertions.h:
kxmlcore/FastMalloc.cpp: (KXMLCore::):
kxmlcore/FastMalloc.h:
kxmlcore/FastMallocInternal.h:
kxmlcore/HashTable.h:
kxmlcore/TCPageMap.h:
kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
os-win32/stdint.h:

JavaScriptGlue:

Not reviewed, but I noticed these trivial extra changes were needed to avoid
breaking the build with my reviewed patch for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

Add config.h, includes of it, and Platform.h forwarding header.

JSBase.cpp:
JSObject.cpp:
JSRun.cpp:
JSUtils.cpp:
JSValueWrapper.cpp:
JavaScriptGlue.cpp:
UserObjectImp.cpp:
config.h: Added.
kxmlcore/Platform.h: Added.

WebCore:

Reviewed by Darin.

WebCore updates for "Set up new prototype macros and avoid using #if without defined() in JSC" http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

Add Platform.h

ForwardingHeaders/kxmlcore/Platform.h: Added.
bridge/mac/WebCoreFrameNamespaces.m:
bridge/mac/WebCoreViewFactory.m:
bridge/mac/WebDashboardRegion.m:
config.h:
platform/Logging.cpp:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
platform/mac/WebCoreCookieAdapter.m:
platform/mac/WebCoreGraphicsBridge.m:
platform/mac/WebCoreHistory.m:
platform/mac/WebCoreImageRendererFactory.m:
platform/mac/WebCoreKeyGenerator.m:
platform/mac/WebCoreView.m:

12:39 AM Changeset in webkit [13088] by eseidel

2 edits in trunk/WebCore

2006-03-02 Eric Seidel <eseidel@apple.com>

WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build

12:21 AM Changeset in webkit [13087] by eseidel

6 edits in trunk/WebKitTools

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

Make spinneret take advantage of the new GraphicsContextCairo.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): updated to match style guidelines.
Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WndProc):
Spinneret/Spinneret/WebView.h:

12:20 AM Changeset in webkit [13086] by eseidel

6 edits
1 move in trunk/WebCore

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Add first-stab GraphicsContextCairo.

Shuffle a few more link stubs around, remove uncessary WebCore

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/GraphicsContext.cpp: Added.
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::setColor): (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::adjustLineToPixelBounderies): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled):
platform/cairo/ImageCairo.cpp:
platform/cg/GraphicsContextCG.cpp: Removed.
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (Widget::mapFromGlobal): (QLineEdit::cursorPosition): (QTextEdit::setScrollBarModes): (QTextEdit::selectAll): (QComboBox::focusPolicy): (GraphicsContext::clearShadow): (QTextEdit::setCursorPosition): (GraphicsContext::drawText): (QLineEdit::setLiveSearch): (QComboBox::QComboBox): (Widget::lockDrawingFocus): (QTextEdit::setSelectionRange): (QSlider::QSlider): (ScrollView::scrollYOffset): (QComboBox::sizeHint): (QLineEdit::edited): (QTextEdit::text): (QSlider::value): (WebCore::Widget::setFocus): (WebCore::TransferJob::addMetaData): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::registerCommandForUndo): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::addMessageToConsole): (FrameWin::passWheelEventToChildWidget): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::shouldChangeSelection): (FrameWin::scheduleClose): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::lastEventIsMouseUp): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::userAgent): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::objectContentType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (FrameWin::generateFrameName): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (GraphicsContext::GraphicsContext): (QFontMetrics::isFixedPitch): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::setTitle): (FrameWin::handledOnloadEvents): (FrameWin::markedTextRange): (GraphicsContext::font): (GraphicsContext::setFont):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed