⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 2, 2006:

8:21 PM Changeset in webkit [14170] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Fix for <rdar://problem/4523671>
REGRESSION (NativeTextField): Auto-complete popup list doesn't appear at the correct location after scrolling page.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): Use the documentView to compute the correct rect for the element when the view is scrolled.
8:17 PM Changeset in webkit [14169] by justing
  • 12 edits
    28 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8704>
Fix a few end merge bugs
<rdar://problem/4424044>
REGRESSION: Extra line appears when typing

Added a function so that selection changes can participate in slow-motion-mode:

  • editing/editing.js: Extra newlines were added:
  • editing/inserting/paragraph-separator-01-expected.checksum: Added.
  • editing/inserting/paragraph-separator-01-expected.png: Added.
  • editing/inserting/paragraph-separator-01-expected.txt: Added.
  • editing/inserting/paragraph-separator-01.html: Added.
  • editing/inserting/paragraph-separator-02-expected.checksum: Added.
  • editing/inserting/paragraph-separator-02-expected.png: Added.
  • editing/inserting/paragraph-separator-02-expected.txt: Added.
  • editing/inserting/paragraph-separator-02.html: Added. A preserved newline was turned into a nbsp:
  • editing/inserting/paragraph-separator-03-expected.checksum: Added.
  • editing/inserting/paragraph-separator-03-expected.png: Added.
  • editing/inserting/paragraph-separator-03-expected.txt: Added.
  • editing/inserting/paragraph-separator-03.html: Added. End merge didn't happen:
  • editing/pasteboard/merge-end-4-expected.checksum: Added.
  • editing/pasteboard/merge-end-4-expected.png: Added.
  • editing/pasteboard/merge-end-4-expected.txt: Added.
  • editing/pasteboard/merge-end-4.html: Added. Content was pulled out of these special elements:
  • editing/pasteboard/merge-end-blockquote-expected.checksum: Added.
  • editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • editing/pasteboard/merge-end-blockquote-expected.txt: Added.
  • editing/pasteboard/merge-end-blockquote.html: Added.
  • editing/pasteboard/merge-end-list-expected.checksum: Added.
  • editing/pasteboard/merge-end-list-expected.png: Added.
  • editing/pasteboard/merge-end-list-expected.txt: Added.
  • editing/pasteboard/merge-end-list.html: Added.
  • editing/pasteboard/merge-end-table-expected.checksum: Added.
  • editing/pasteboard/merge-end-table-expected.png: Added.
  • editing/pasteboard/merge-end-table-expected.txt: Added.
  • editing/pasteboard/merge-end-table.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8704>
Fix a few end merge bugs
<rdar://problem/4424044>
REGRESSION: Extra line appears when typing

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]): Use renamed characterAfter.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Regenerate a VisiblePosition that became stale during a text node split. Don't rebalance whitespace after the operation, 1) it has a bug that turns preserved newlines into nbsps, 2) I think it should only be done during serialization, not after every command (since editable regions now always have -webkit-nbsp-mode:space on them). Use a regular br for the placeholder as I think we can move away from -webkit-block-placeholders.


  • editing/RebalanceWhitespaceCommand.cpp: Added FIXMEs.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Removed FIXME. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Can now use rendering information. (WebCore::ReplaceSelectionCommand::doApply): Call shouldMergeEnd after the insertion so that it can use rendering information. Don't use positionAfterNode of the last node inserted to mark the position at the end of inserted content because canonicalization can send it into content that was already in the document.


  • editing/ReplaceSelectionCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Renamed. When two candidates are visually equivalent, the rightmost candidate will be the one inside the text node where the character will be.


  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp: (WebCore::enclosingTableCell): Added. (WebCore::enclosingList):
  • editing/htmlediting.h:
5:21 PM Changeset in webkit [14168] by darin
  • 3 edits in trunk/WebKit

Reviewed by Eric.

I don't know how reproduce this without one of Rosyna's hacks installed, so I
did not include a test.

  • Misc/WebStringTruncator.m: (+[WebStringTruncator initialize]): Add call to InitWebCoreSystemInterface.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add a boolean so we will only do this one time.
5:02 PM Changeset in webkit [14167] by hyatt
  • 3 edits in trunk/WebCore

Partial fix for the crash in bugzilla bug 8088. There's a third crash
even after fixing this though.

Reviewed by darin

  • platform/mac/WebTextRenderer.mm: (WebCore::WidthMap::widths): (WebCore::extendWidthMap):
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory clearCaches]):
4:56 PM Changeset in webkit [14166] by adele
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Don't let the UI delegate have control over the context menu for text fields.
4:56 PM Changeset in webkit [14165] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-20 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/3997958>
REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode

  • dom/Position.cpp: (WebCore::Position::upstream): Avoid calling previous() when we know that it will 1) end the search and 2) be expensive to compute. (WebCore::Position::downstream): Removed some dead code. (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
  • dom/Position.h:
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose the one that occurs first in document order. Using upstream() to find the one that occurs first is much faster than the old code.
4:02 PM Changeset in webkit [14164] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-07 David Hyatt <​hyatt@apple.com>

A fix that makes coalesced updates work much better (and makes our
single animated GIF timer work better). The new rect painting algorithm
for WebHTMLView will use the single unioned rect if the # of rects exceeds
a threshold (10 is my initial cut), or if the union has enough "wasted"
additional pixels (conservatively set at 75%).

Reviewed by darin

  • WebView/WebHTMLView.m: (-[NSArray drawSingleRect:]): (-[NSArray drawRect:]):
3:54 PM Changeset in webkit [14163] by sfalken
  • 4 edits in trunk/WebCore

2006-05-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

WARNING: NO TEST CASES ADDED OR CHANGED

  • WebCore.vcproj/WebCore/WebCore.vcproj: defined NDEBUG in release build
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): turned on javascript.
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::KHTMLSettings): initialized settings to 0
3:48 PM Changeset in webkit [14162] by sfalken
  • 3 edits in trunk/JavaScriptCore

2006-05-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: set NDEBUG for release build
  • kxmlcore/FastMalloc.cpp: Prevent USE_SYSTEM_MALLOC from being defined twice
3:42 PM Changeset in webkit [14161] by thatcher
  • 50 edits
    1 add in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric, Geoff and Darin.

  • fixed <rdar://problem/4118258> XML DOM trees freed prematurely unless reference held to document node (causes crash)


I changed the design for how DOM nodes maintain their reference to
the document. Instead of using DocumentPtr, an indirect reference
which would go null in a clean way when the document is destroyed,
they now have a different strategy.


Nodes that belong to the document now hold a special kind of
reference on the document - a "self only reference". When a
document has no regular references but still has self-only
references, it won't be destroyed, but it will drop all its
children. This allows detached nodees to still have a valid
document reference, but they won't keep the rest of the DOM alive
or cause circular references.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::HTMLBodyElementImpl): (HTMLFrameElementImpl::HTMLFrameElementImpl): (HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): (HTMLHeadElementImpl::HTMLHeadElementImpl): (HTMLHtmlElementImpl::HTMLHtmlElementImpl): (HTMLIFrameElementImpl::HTMLIFrameElementImpl):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp: (HTMLBlockquoteElementImpl::HTMLBlockquoteElementImpl): (HTMLDivElementImpl::HTMLDivElementImpl): (HTMLHRElementImpl::HTMLHRElementImpl): (HTMLHeadingElementImpl::HTMLHeadingElementImpl): (HTMLParagraphElementImpl::HTMLParagraphElementImpl): (HTMLPreElementImpl::HTMLPreElementImpl): (HTMLMarqueeElementImpl::HTMLMarqueeElementImpl):
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_canvasimpl.cpp: (HTMLCanvasElementImpl::HTMLCanvasElementImpl):
  • khtml/html/html_canvasimpl.h:
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::createTokenizer): (DOM::HTMLDocumentImpl::determineParseMode):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::createContextualFragment): (HTMLElementImpl::setInnerText): (HTMLElementImpl::setOuterText):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLGenericFormElementImpl::HTMLGenericFormElementImpl): (DOM::HTMLButtonElementImpl::HTMLButtonElementImpl): (DOM::HTMLFieldSetElementImpl::HTMLFieldSetElementImpl): (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLLabelElementImpl::HTMLLabelElementImpl): (DOM::HTMLLegendElementImpl::HTMLLegendElementImpl): (DOM::HTMLSelectElementImpl::HTMLSelectElementImpl): (DOM::HTMLKeygenElementImpl::HTMLKeygenElementImpl): (DOM::HTMLOptGroupElementImpl::HTMLOptGroupElementImpl): (DOM::HTMLOptionElementImpl::HTMLOptionElementImpl): (DOM::HTMLOptionElementImpl::setText): (DOM::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::HTMLBaseElementImpl): (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLMetaElementImpl::HTMLMetaElementImpl): (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLStyleElementImpl::HTMLStyleElementImpl): (HTMLTitleElementImpl::HTMLTitleElementImpl):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLMapElementImpl::HTMLMapElementImpl): (HTMLAreaElementImpl::HTMLAreaElementImpl):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::HTMLAnchorElementImpl): (DOM::HTMLBRElementImpl::HTMLBRElementImpl): (DOM::HTMLFontElementImpl::HTMLFontElementImpl): (DOM::HTMLModElementImpl::HTMLModElementImpl): (DOM::HTMLQuoteElementImpl::HTMLQuoteElementImpl):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.h: (DOM::HTMLUListElementImpl::HTMLUListElementImpl): (DOM::HTMLDirectoryElementImpl::HTMLDirectoryElementImpl): (DOM::HTMLMenuElementImpl::HTMLMenuElementImpl): (DOM::HTMLOListElementImpl::HTMLOListElementImpl): (DOM::HTMLLIElementImpl::HTMLLIElementImpl): (DOM::HTMLDListElementImpl::HTMLDListElementImpl):
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLBaseFontElementImpl::HTMLBaseFontElementImpl):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::HTMLAppletElementImpl): (DOM::HTMLEmbedElementImpl::HTMLEmbedElementImpl): (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLParamElementImpl::HTMLParamElementImpl):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::HTMLTableElementImpl): (DOM::HTMLTableElementImpl::createTHead): (DOM::HTMLTableElementImpl::createTFoot): (DOM::HTMLTableElementImpl::createCaption): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::HTMLTableSectionElementImpl): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableCellElementImpl::HTMLTableCellElementImpl): (DOM::HTMLTableColElementImpl::HTMLTableColElementImpl):
  • khtml/html/html_tableimpl.h: (DOM::HTMLTablePartElementImpl::HTMLTablePartElementImpl): (DOM::HTMLTableRowElementImpl::HTMLTableRowElementImpl): (DOM::HTMLTableCaptionElementImpl::HTMLTableCaptionElementImpl):
  • khtml/html/htmlfactory.cpp: (DOM::htmlConstructor): (DOM::headConstructor): (DOM::bodyConstructor): (DOM::baseConstructor): (DOM::linkConstructor): (DOM::metaConstructor): (DOM::styleConstructor): (DOM::titleConstructor): (DOM::frameConstructor): (DOM::framesetConstructor): (DOM::iframeConstructor): (DOM::formConstructor): (DOM::buttonConstructor): (DOM::inputConstructor): (DOM::isindexConstructor): (DOM::fieldsetConstructor): (DOM::labelConstructor): (DOM::legendConstructor): (DOM::optgroupConstructor): (DOM::optionConstructor): (DOM::selectConstructor): (DOM::textareaConstructor): (DOM::dlConstructor): (DOM::ulConstructor): (DOM::olConstructor): (DOM::dirConstructor): (DOM::menuConstructor): (DOM::liConstructor): (DOM::blockquoteConstructor): (DOM::divConstructor): (DOM::headingConstructor): (DOM::hrConstructor): (DOM::paragraphConstructor): (DOM::preConstructor): (DOM::basefontConstructor): (DOM::fontConstructor): (DOM::modConstructor): (DOM::anchorConstructor): (DOM::imageConstructor): (DOM::mapConstructor): (DOM::areaConstructor): (DOM::canvasConstructor): (DOM::appletConstructor): (DOM::embedConstructor): (DOM::objectConstructor): (DOM::paramConstructor): (DOM::scriptConstructor): (DOM::tableConstructor): (DOM::tableCaptionConstructor): (DOM::tableColConstructor): (DOM::tableRowConstructor): (DOM::tableCellConstructor): (DOM::tableSectionConstructor): (DOM::brConstructor): (DOM::quoteConstructor): (DOM::marqueeConstructor): (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::HTMLParser): (HTMLParser::~HTMLParser):
  • khtml/html/htmlparser.h: (HTMLParser::doc):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::parseTag): (khtml::parseHTMLDocumentFragment):
  • khtml/html/htmltokenizer.h:
  • khtml/misc/loader.h:
  • khtml/misc/shared.h: (khtml::TreeShared::~TreeShared): (khtml::TreeShared::destroy): (khtml::TreeShared::deref):
  • khtml/xbl/xbl_tokenizer.cpp: (XBL::XBLTokenHandler::XBLTokenHandler):
  • khtml/xbl/xbl_tokenizer.h: (XBL::):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::RangeImpl): (DOM::RangeImpl::setStart): (DOM::RangeImpl::setEnd): (DOM::RangeImpl::processContents): (DOM::RangeImpl::cloneRange): (DOM::RangeImpl::setStartAfter): (DOM::RangeImpl::setEndBefore): (DOM::RangeImpl::setEndAfter): (DOM::RangeImpl::setStartBefore): (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocumentType): (DOMImplementationImpl::createDocument): (DocumentImpl::DocumentImpl): (DocumentImpl::destroy): (DocumentImpl::~DocumentImpl): (DocumentImpl::createDocumentFragment): (DocumentImpl::createTextNode): (DocumentImpl::createComment): (DocumentImpl::createCDATASection): (DocumentImpl::createProcessingInstruction): (DocumentImpl::createEntityReference): (DocumentImpl::createEditingTextNode): (DocumentImpl::createElementNS): (DocumentImpl::setTitle): (DocumentImpl::removeTitle): (DocumentImpl::createRange): (DocumentImpl::createTokenizer): (DocumentImpl::implicitClose): (DocumentImpl::setHoverNode): (DocumentImpl::setActiveNode): (DocumentImpl::setFocusNode): (DocumentImpl::createAttributeNS): (DocumentFragmentImpl::DocumentFragmentImpl): (DocumentFragmentImpl::cloneNode): (DocumentTypeImpl::DocumentTypeImpl):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::selfOnlyRef): (DOM::DocumentImpl::selfOnlyDeref): (DOM::DocumentImpl::focusNode): (DOM::DocumentImpl::hoverNode): (DOM::DocumentImpl::activeNode):
  • khtml/xml/dom_elementimpl.cpp: (AttributeImpl::allocateImpl): (AttrImpl::AttrImpl): (AttrImpl::cloneNode): (ElementImpl::ElementImpl): (StyledElementImpl::StyledElementImpl):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): (DOM::NodeImpl::setDocument): (DOM::NodeImpl::~NodeImpl): (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::checkAddChild): (DOM::ContainerNodeImpl::ContainerNodeImpl): (DOM::ContainerNodeImpl::removeAllChildren): (DOM::ContainerNodeImpl::~ContainerNodeImpl):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inDocument): (DOM::NodeImpl::getDocument):
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): (CommentImpl::CommentImpl): (TextImpl::TextImpl): (TextImpl::createNew): (CDATASectionImpl::CDATASectionImpl): (CDATASectionImpl::createNew): (EditingTextImpl::EditingTextImpl):
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::EntityReferenceImpl::EntityReferenceImpl): (DOM::EntityReferenceImpl::cloneNode): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl): (DOM::ProcessingInstructionImpl::cloneNode):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElementNs): (khtml::XMLTokenizer::enterText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::cdataBlock): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::internalSubset): (khtml::XMLTokenizer::finish): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::newXMLTokenizer):
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::createFragmentFromSource):
1:45 PM Changeset in webkit [14160] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add layout test for scrollLeft/Top setting bug.

1:44 PM Changeset in webkit [14159] by hyatt
  • 2 edits in trunk/WebCore

Make sure to updateLayout on all scrolling functions (in particular when
setting scrollLeft/Top).

Reviewed by eric

fast/overflow/008,html added as a test case.

  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
1:20 PM Changeset in webkit [14158] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore/kjs

Debug build fix.

9:23 AM Changeset in webkit [14157] by darin
  • 6 edits
    1 add in trunk/WebKitWin
  • ChangeLog: Added.
  • <most files: Cleared the stray "executable" bit that was on most files.
2:30 AM Changeset in webkit [14156] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-05-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kxmlcore/HashMap.h: (KXMLCore::::operator): Return *this
12:25 AM Changeset in webkit [14155] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-05-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8688
file URLs aren't being serialized correctly when using window.location


  • platform/KURL.cpp: (KURL::prettyURL): Append "" for file URLs.

LayoutTests:

2006-05-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Dave Hyatt.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8688
file URLs aren't being serialized correctly when using window.location


  • fast/js/window-location-href-file-urls-expected.txt: Added.
  • fast/js/window-location-href-file-urls.html: Added.

May 1, 2006:

5:49 PM Changeset in webkit [14154] by thatcher
  • 4 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2006-05-01 Tim Omernick <​timo@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4476875> Support printing for embedded Netscape plugins

  • bindings/npapi.h: Fixed struct alignment problem in our npapi.h. Structs must be 68k-aligned on both pre-Mac OS X and Mac OS X systems, as this is what plugins expect.

WebKit:

Merged fix from TOT to Safari-2-0-branch

2006-04-20 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4476875> Support printing for embedded Netscape plugins

NOTE: This only works with the Flash plugin right now. It appears that the other
major plugins either have awful printing support, or no printing support. If someone
can find an example of any other embedded Netscape plugin printing in any browser on
the Mac, I will be happy to eat my own words!

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView drawRect:]): When printing, get the printed bitmap via -_printedPluginBitmap, and draw it into the plugin view. (-[WebBaseNetscapePluginView _printedPluginBitmap]): Call NPP_Print on the plugin to render it into a GWorld. This GWorld has the same underlying buffer as an NSBitmapImageRep, which is returned to the caller.
5:48 PM Changeset in webkit [14153] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

<rdar://problem/4476875> Support printing for embedded Netscape plugins

  • bindings/npapi.h: Fixed struct alignment problem in our npapi.h. Structs must be 68k-aligned on both pre-Mac OS X and Mac OS X systems, as this is what plugins expect.
5:08 PM Changeset in webkit [14152] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-03-13 Tim Omernick <​timo@apple.com>

Reviewed by Maciej.

<rdar://problem/4476873> Support printing for plugin documents (not embedded plugins)

  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView documentViewShouldHandlePrint]): Called by the host application before it initializes and runs a print operation. If NO is returned, the host application will abort its print operation and call -printDocumentView on the WebFrameView. The document view is then expected to run its own print operation. If YES is returned, the host application's print operation will continue as normal. (-[WebFrameView printDocumentView]): Called by the host application when the WebFrameView returns YES from -documentViewShouldHandlePrint.
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView documentViewShouldHandlePrint]): Allow the plugin to take over printing if it defines an NPP_Print function (-[WebNetscapePluginDocumentView printDocumentView]): Print the plugin document.
4:48 PM Changeset in webkit [14151] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-01-02 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.


  • fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)


We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
we fail to fire onmouseout events. Since the call to passSubframeEventToSubframe was originally added
to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
on passSubframeEventToSubframe.

  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
4:07 PM Changeset in webkit [14150] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-04-18 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix "new Function()" to correctly use lexical scoping.
Add ScopeChain::print() function for debugging.
<rdar://problem/4067864> REGRESSION (125-407): JavaScript failure on PeopleSoft REN Server

  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
  • kjs/scope_chain.h:
4:02 PM Changeset in webkit [14149] by hyatt
  • 12 edits in trunk/WebCore

Convert WebTextRenderer to be a C++ class. Change the factory so
that it uses pointer-based hashmaps instead of NSMutableDictionaries.
Convert uses of malloc/free to new/delete so that they start using
the fastMalloc/fastFree code.

Reviewed by darin

  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (QListBox::clearCachedTextRenderers): (-[KWQTableView drawRow:clipRect:]):
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::invalidate): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth): (WebCoreSetAlwaysUseATSU):
  • platform/mac/WebTextRenderer.h: (WebCore::WebTextRenderer::ascent): (WebCore::WebTextRenderer::descent): (WebCore::WebTextRenderer::lineSpacing): (WebCore::WebTextRenderer::lineGap): (WebCore::WebTextRenderer::misspellingLineThickness): (WebCore::WebTextRenderer::misspellingLinePatternWidth): (WebCore::WebTextRenderer::misspellingLinePatternGapWidth):
  • platform/mac/WebTextRenderer.mm: (WebCore::WebCoreInitializeFont): (WebCore::WebCoreInitializeTextRun): (WebCore::WebCoreInitializeEmptyTextStyle): (WebCore::WebCoreInitializeEmptyTextGeometry): (WebCore::widthForGlyph): (WebCore::overrideLayoutOperation): (WebCore::m_ATSUMirrors): (WebCore::WebTextRenderer::~WebTextRenderer): (WebCore::WebTextRenderer::xHeight): (WebCore::WebTextRenderer::drawRun): (WebCore::WebTextRenderer::floatWidthForRun): (WebCore::WebTextRenderer::drawLineForCharacters): (WebCore::WebTextRenderer::selectionRectForRun): (WebCore::WebTextRenderer::drawHighlightForRun): (WebCore::WebTextRenderer::drawLineForMisspelling): (WebCore::WebTextRenderer::pointToOffset): (WebCore::WebTextRenderer::setAlwaysUseATSU): (WebCore::getSmallCapsRenderer): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::computeWidthForSpace): (WebCore::setUpFont): (WebCore::CG_selectionRect): (WebCore::CG_draw): (WebCore::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::initializeATSUStyle): (WebCore::createATSULayoutParameters): (WebCore::disposeATSULayoutParameters): (WebCore::addDirectionalOverride): (WebCore::ATSU_selectionRect): (WebCore::ATSU_draw): (WebCore::ATSU_pointToOffset): (WebCore::freeWidthMap): (WebCore::freeGlyphMap): (WebCore::glyphForCharacter): (WebCore::advanceWidthIterator):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory clearCaches]): (-[WebTextRendererFactory init]): (-[WebTextRendererFactory dealloc]): (-[WebTextRendererFactory rendererWithFont:]):
3:54 PM Changeset in webkit [14148] by thatcher
  • 19 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2006-03-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

  • JavaScriptCore side of fix for <rdar://problem/4308243> 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

The crash was a result of threaded deallocation of thread-unsafe
objects. Pure JS objects are thread-safe because all JS execution
is synchronized through JSLock. However, JS objects that wrap WebCore
objects are thread-unsafe because JS and WebCore execution are not
synchronized. That unsafety comes into play when the collector
deallocates a JS object that wraps a WebCore object, thus causing the
WebCore object to be deallocated.

The solution here is to have each JSCell know whether it is safe to
collect on a non-main thread, and to avoid collecting unsafe cells
when on a non-main thread.

We don't have a way to test PAC files yet, so there's no test
attached to this patch.

  • kjs/collector.cpp: (KJS::Collector::collect):
(1) Added the test "currentThreadIsMainThread

imp->m_destructorIsThreadSafe".

  • kjs/protect.h: (KJS::gcProtectNullTolerant): (KJS::gcUnprotectNullTolerant):
  • kjs/value.h: (KJS::JSCell::JSCell): The bools here must be bitfields, otherwise m_destructorIsThreadSafe becomes another whole word, ruining the collector optimizations we've made based on the size of a JSObject.
  • kxmlcore/FastMalloc.cpp: (KXMLCore::currentThreadIsMainThread): (KXMLCore::fastMallocRegisterThread):
  • kxmlcore/FastMalloc.h:

WebCore:

Merged fix from TOT to Safari-2-0-branch

2006-03-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

  • WebCore side of fix for <rdar://problem/4308243> 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

(1) To ensure thread-safe deallocation, set the "unsafe to destroy on
non-main threads" bit in the DOMObject constructor.

(2) Made all binding objects inherit from DOMObject, because the
WebCore data structures they wrap are not thread-safe. "DOMObject" is
a slightly awkward name for things like the Window object, but the
DOM spec is considering adding a Window object, and creating a whole
new base class for this purpose seemed like overkill.

  • khtml/ecma/JSDOMParser.h:
  • khtml/ecma/JSXMLHttpRequest.h:
  • khtml/ecma/JSXMLSerializer.cpp: (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
  • khtml/ecma/JSXMLSerializer.h:
  • khtml/ecma/JSXSLTProcessor.h:
  • khtml/ecma/kjs_binding.h: (KJS::DOMObject::DOMObject): Unset the "safe to collect on non-main threads bit" to ensure thread-safe deallocation.
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_proxy.cpp:
  • khtml/ecma/kjs_window.cpp: (KJS::History::History): (KJS::FrameArray::FrameArray): (KJS::Screen::Screen): (KJS::Window::Window): (KJS::BarInfo::BarInfo):
  • khtml/ecma/kjs_window.h:
3:46 PM Changeset in webkit [14147] by eseidel
  • 2 edits in branches/Safari-2-0-branch/WebCore

kwq/KWQKURL.mm

3:28 PM Changeset in webkit [14146] by sfalken
  • 1 edit in trunk/WebKitWin/WebFramePrivate.cpp

2006-05-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.


Fix missing line ending.

  • WebFramePrivate.cpp:
3:21 PM Changeset in webkit [14145] by sfalken
  • 5 edits
    4 deletes in trunk/WebKitTools

2006-05-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Spinneret now links against the new separate lib.
Removed WebFrame, WebView.


  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::updateLocationBar): (_tWinMain):
  • Spinneret/Spinneret/Spinneret.h:
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: Removed.
  • Spinneret/Spinneret/WebFrame.h: Removed.
  • Spinneret/Spinneret/WebView.cpp: Removed.
  • Spinneret/Spinneret/WebView.h: Removed.
3:10 PM Changeset in webkit [14144] by sfalken
  • 4 copies
    11 adds in trunk/WebKitWin

2006-05-01 Steve Falkenburg <​sfalken@microsoft.com>

Reviewed by eric.

Moved WebKit-like code from Spinnaret into WebKitWin.


  • .: Added.
  • WebFrame.cpp: Added. (WebKit::WebFrame::createWebFrame): Factory to create web frames.
  • WebFramePrivate.cpp: Added. (WebKit::WebFramePrivate::WebFrameData::WebFrameData): (WebKit::WebFramePrivate::WebFrameData::~WebFrameData): (WebKit::WebFramePrivate::WebFramePrivate): (WebKit::WebFramePrivate::~WebFramePrivate): (WebKit::WebFramePrivate::loadFilePath): (WebKit::WebFramePrivate::loadHTMLString): (WebKit::WebFramePrivate::openURL): (WebKit::WebFramePrivate::submitForm): (WebKit::WebFramePrivate::loadURL): (WebKit::WebFramePrivate::getURL): (WebKit::WebFramePrivate::reload): (WebKit::WebFramePrivate::receivedData): (WebKit::WebFramePrivate::receivedAllData): (WebKit::WebFramePrivate::paint): (WebKit::WebFramePrivate::impl): (WebKit::WebFramePrivate::toPrivate):
  • WebFramePrivate.h: Added.
  • WebKitWin.vcproj: Added.
  • WebKitWin.vcproj/WebKitWin: Added.
  • WebKitWin.vcproj/WebKitWin.sln: Added.
  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj: Added.
  • WebKitWin.vcproj/WebKitWin/stdafx.cpp: Added.
  • WebKitWin.vcproj/WebKitWin/stdafx.h: Added.
  • WebView.cpp: Added. (WebKit::WebView::createWebView): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):
  • public: Added.
  • public/WebFrame.h: Added.
  • public/WebHost.h: Added.
  • public/WebView.h: Added.
2:43 PM Changeset in webkit [14143] by justing
  • 4 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8653>
Remove a use of hasMoreThanOneBlock

Deleting didn't merge because of code that stopped the merge whenever
the end of the selection to delete was in a fully selected line.

  • editing/deleting/merge-endOfParagraph-expected.checksum: Added.
  • editing/deleting/merge-endOfParagraph-expected.png: Added.
  • editing/deleting/merge-endOfParagraph-expected.txt: Added.
  • editing/deleting/merge-endOfParagraph.html: Added.


Two testcases where paste did not request a merge from deletion, but should have.

  • editing/pasteboard/merge-after-delete-1-expected.checksum: Added.
  • editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • editing/pasteboard/merge-after-delete-1-expected.txt: Added.
  • editing/pasteboard/merge-after-delete-1.html: Added.
  • editing/pasteboard/merge-after-delete-2-expected.checksum: Added.
  • editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • editing/pasteboard/merge-after-delete-2-expected.txt: Added.
  • editing/pasteboard/merge-after-delete-2.html: Added.


Code that prevents nesting incoming blocks in the block being pasted into
could reverse the order of pasted paragraphs.

  • editing/pasteboard/prevent-block-nesting-01-expected.checksum: Added.
  • editing/pasteboard/prevent-block-nesting-01-expected.png: Added.
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
  • editing/pasteboard/prevent-block-nesting-01.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8653>
Remove a use of hasMoreThanOneBlock, which uses info from the test rendering.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Removed code that stopped the merge if the end of the selection to delete was in a fully selected line, which was nonsense.


(WebCore::DeleteSelectionCommand::mergeParagraphs):
Deletion does a bad job of updating the endpoints of the selection as it removes
content. If the endpoints have been flip flipped, bail.
If deletion has removed everything from the block that contained the
start of the selection to delete, we can't create a visible position inside
that block to serve as a destination for the merge. So, we insert a placeholder
at that position to prop the block open to let content in.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added an assert and two early returns for cases where we'll crash. Removed a use of !fragment.hasMoreThanOneBlock, which uses test rendering info and which was wrong. If we've already inserted content during the start merge, insertionPos will be the position just after that content, so inserting new content before insertionPos will reverse its order.
2:24 PM Changeset in webkit [14142] by tomernic
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/plugin-controller-datasource.html: Added.
  • manual-tests/resources/orange.mov: Added.

WebKit:

Reviewed by Darin.

  • WebView/WebHTMLView.m:

(-[WebHTMLView setDataSource:]): Set the pluginController's dataSource.

1:58 PM Changeset in webkit [14141] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.


<rdar://problem/4308243> 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

The original fix missed the oversized cell case. Added a test for "currentThreadIsMainThread

imp->m_destructorIsThreadSafe" where we collect oversized cells.

We don't have a way to test PAC files yet, so there's no test attached.

  • kjs/collector.cpp: (KJS::Collector::collect): test the thread when we collect oversized cells
1:49 PM Changeset in webkit [14140] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adele.

<rdar://problem/4526114> REGRESSION (two days ago): LOG() just prints @ for NSObject substitutions

  • kxmlcore/Assertions.cpp: Changed sense of strstr("%@") check. I already made the same fix to the WebBrowser assertions.
12:20 PM Changeset in webkit [14139] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Speculative fix for our 7th worst crasher.
Also added ASSERTs to help us better understand the issue.
<rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::setInPageCache):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
11:25 AM Changeset in webkit [14138] by thatcher
  • 1 copy in tags/JavaScriptGlue-418/JavaScriptGlue

Tag for JavaScriptGlue 418 (part 2 of 2.)

11:25 AM Changeset in webkit [14137] by thatcher
  • 1 add in tags/JavaScriptGlue-418

Tag for JavaScriptGlue 418 (part 1 of 2.)

11:25 AM Changeset in webkit [14136] by thatcher
  • 1 copy in tags/JavaScriptCore-418/JavaScriptCore

Tag for JavaScriptCore 418 (part 2 of 2.)

11:25 AM Changeset in webkit [14135] by thatcher
  • 1 add in tags/JavaScriptCore-418

Tag for JavaScriptCore 418 (part 1 of 2.)

11:24 AM Changeset in webkit [14134] by thatcher
  • 1 copy in tags/WebKit-418.1/WebKit

Tag for WebKit 418.1 (part 2 of 2.)

11:24 AM Changeset in webkit [14133] by thatcher
  • 1 add in tags/WebKit-418.1

Tag for WebKit 418.1 (part 1 of 2.)

11:23 AM Changeset in webkit [14132] by thatcher
  • 1 move in tags/WebCore-418

Wrong tag name.

11:21 AM Changeset in webkit [14131] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

11:21 AM Changeset in webkit [14130] by thatcher
  • 1 add in tags/WebCore-418.4

Tag for WebCore 418.4 (part 1 of 2.)

11:10 AM Changeset in webkit [14129] by mjs
  • 2 edits in trunk/WebKit
  • fix build
  • WebKit.exp: Add symbol that the new Safari will need.
10:59 AM Changeset in webkit [14128] by thatcher
  • 8 edits in branches/Safari-2-0-branch

Versioning.

8:17 AM Changeset in webkit [14127] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/3126419> history load enforces history limit, but deletes the newest instead of oldest items
  • added notification reporting items discarded during load because the age limit or item count limit is exceeded
  • a few other minor tweaks
  • History/WebHistory.h: fixed a typo and an incorrect method name


  • History/WebHistoryPrivate.h: Added declaration of WebHistoryItemsDiscardedWhileLoadingNotification. Also changed signature of WebHistoryPrivate method -loadFromURL:error: to have new collectDiscardedItemsInto: parameter. Also deleted declarations of two methods that didn't actually exist (loadHistory and initWithFile:), and added comments about which methods should become public API, WebKit-internal, or file-internal.
  • History/WebHistory.m: (-[WebHistoryPrivate arrayRepresentation]): This method, called only by _saveHistoryGuts:, used to deliberately leave out items that violated either the age limit or the item count limit. Now all the items are included (and thus saved), and all the pruning is done at load time, so clients can keep track of the pruned items by observing the new WebHistoryItemsDiscardedWhileLoadingNotification (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Now keeps track of all the items that violated the age limit or item count limit in the new collectedDiscardedItemsInto: parameter. Also, now processes items in forward order rather than reverse order to fix 3126419. Now uses compare: rather than _webkit_compareDay: to check against age limit; this is faster and also more correct (most noticeable with small age limits). (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): new collectDiscardedItemsInto: parameter, passed into _loadHistoryGuts:... (-[WebHistory loadFromURL:error:]): Now sends new WebHistoryItemsDiscardedWhileLoadingNotification if any items were discarded due to age limit or item count limit.


  • WebKit.exp: exported symbol for WebHistoryItemsDiscardedWhileLoadingNotification
1:34 AM Changeset in webkit [14126] by eseidel
  • 4 edits in trunk

2006-04-30 Rob Buis <​buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8651:
CGContextSetLineDash: invalid dash array: emmited during WebKit tests

Properly discard invalid stroke-dasharray properties like in
invalid-css.svg. (Tests updated.)

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGStrokeDasharray):

Apr 29, 2006:

1:19 PM Changeset in webkit [14125] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Bug 8577: [TabBarView _web_superviewOfClass:stoppingAtClass:]
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8577

Added back _web_superviewOfClass:stoppingAtClass:.
This method was removed in r14032 (bug 8562), but Safari 2.0 still uses it.
We should remove this method once Open Source users have a new version
to use with TOT WebKit.

  • Misc/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:stoppingAtClass:]):

Apr 28, 2006:

11:15 PM Changeset in webkit [14124] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-04-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by kdecker


Actually apply the change that was reviewed insted of checking it in with an #if 0 (oops).

  • kjs/testkjs.cpp: (main): Suppress C runtime alerts
10:45 PM Changeset in webkit [14123] by sfalken
  • 2 edits in trunk/WebKitTools

2006-04-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by kdecker

Modify error reporting registry keys to disable Dr. Watson.
This allows Javascript test cases to complete without blocking UI.


  • Scripts/install-win-extras:
    • Use Perl Win32 registry functions to disable blocking UI
10:28 PM Changeset in webkit [14122] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-04-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by kdecker

Suppress error reporting dialog that blocks Javascript tests from completing.


Real error is due to an overflow in the date/time handling functions that needs
to be addressed, but this will prevent the hang running the Javascript tests
on the build bot (along with the related changes).


  • kjs/testkjs.cpp: (main): Suppress C runtime alerts
6:03 PM Changeset in webkit [14121] by hyatt
  • 3 edits in trunk/WebCore

Make image buffer sizes in the loader more accurate, since we know we store
buffers with 4 bytes per pixel. Double sizes to account for this. Also
deal better with animated GIFs that may have thousands of frames by adding
in a heuristic that will use the data size instead of a single frame RGBA32
buffer size if it's larger.

Reviewed by darin

WARNING: NO TEST CASES ADDED OR CHANGED

  • loader/Cache.cpp:
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
5:59 PM Changeset in webkit [14120] by hyatt
  • 2 edits in trunk/WebKit

Double the cache size to account for our revised (more accurate)
measurement of the image buffers.

Reviewed by darin

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
5:50 PM Changeset in webkit [14119] by hyatt
  • 1 copy in trunk/WebCore/icu/unicode/unorm.h

Fix build bustage for public builds.

5:33 PM Changeset in webkit [14118] by hyatt
  • 1 add in trunk/WebCore/platform/mac/WebCoreTextRenderer.mm

fix build bustage.

5:17 PM Changeset in webkit [14117] by sfalken
  • 9 edits in trunk/WebKitTools

2006-04-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.


Turned off C++ exceptions, fixed memory leaks

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::~WebFrame): (WebKit::WebFrame::impl):
  • Spinneret/Spinneret/WebFrame.h:
  • Spinneret/Spinneret/WebView.cpp:
  • Spinneret/Spinneret/stdafx.h:
5:12 PM Changeset in webkit [14116] by sfalken
  • 6 edits in trunk/WebCore

2006-04-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

No test necessary - fixing Win32 build, turned off C++ exceptions, turned off RTTI

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/PageWin.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::saveDocumentState): (Path::contains): (Path::boundingRect):
5:06 PM Changeset in webkit [14115] by hyatt
  • 15 edits
    2 deletes in trunk/WebCore

Merge WebCoreTextRenderer into WebTextRenderer. Merge WebCoreTextRendererFactory
into WebTextRendererFactory. Change all callers to refer to the concrete classes
now. Change WebCoreTextRenderer.h to be the public API that WebKit uses when
it calls in to WebCore. Clean up the exports to remove things WebKit no longer
needs.

Reviewed by darin

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.h:
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch):
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory init]):
  • platform/mac/WebTextRenderer.h:
  • platform/mac/WebTextRenderer.mm:
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (WebCoreInitializeFont): (WebCoreInitializeTextRun): (WebCoreInitializeEmptyTextStyle): (WebCoreInitializeEmptyTextGeometry): (-[WebTextRendererFactory clearCaches]): (+[WebTextRendererFactory createSharedFactory]): (+[WebTextRendererFactory sharedFactory]): (-[WebTextRendererFactory init]):
4:06 PM Changeset in webkit [14114] by thatcher
  • 3 edits
    2 adds in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-02-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by John.

  • Fixed <rdar://problem/4330457> CrashTracer: [REGRESSION] 3763 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance:: getClass const + 56

This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.

The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): Added delete callbacks
  • bindings/runtime.cpp: Added definitions for delete callbacks (KJS::Bindings::deleteMethodList): (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField):
  • bindings/runtime.h: Added declarations for delete callbacks
3:25 PM Changeset in webkit [14113] by hyatt
  • 9 edits
    4 deletes in trunk/WebKit

Fix for 8586, move WebTextRenderer into WebCore.

Reviewed by darin

  • Misc/WebKitNSStringExtras.m: (-[NSString _web_drawAtPoint:font:textColor:]): (-[NSString _web_widthWithFont:]):
  • Misc/WebStringTruncator.m: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebCoreSupport/WebTextRenderer.h: Removed.
  • WebCoreSupport/WebTextRenderer.m: Removed.
  • WebCoreSupport/WebTextRendererFactory.h: Removed.
  • WebCoreSupport/WebTextRendererFactory.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
  • WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]):
  • WebView/WebTextView.m: (-[WebTextView setFixedWidthFont]):
  • WebView/WebView.m: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setShouldUseFontSmoothing:]): (+[WebView _shouldUseFontSmoothing]):
3:24 PM Changeset in webkit [14112] by hyatt
  • 8 edits
    4 copies in trunk/WebCore

Fix for 8586, move WebTextRenderer into WebCore.

Reviewed by darin

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRendererFactory.mm: (+[WebCoreTextRendererFactory sharedFactory]):
  • platform/mac/WebTextRenderer.h: Added.
  • platform/mac/WebTextRenderer.mm: Added. (widthForGlyph): (-[WebTextRenderer initWithFont:]): (destroy): (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): (-[WebTextRenderer drawLineForMisspelling:withWidth:]): (findSubstituteFont): (setUpFont): (pathFromFont): (drawGlyphs): (CG_draw): (extendGlyphMap): (extendWidthMap): (initializeATSUStyle): (createATSULayoutParameters): (getTextBounds): (addDirectionalOverride): (ATSU_draw): (normalizeVoicingMarks): (advanceWidthIterator): (fillStyleWithAttributes):
  • platform/mac/WebTextRendererFactory.h: Added.
  • platform/mac/WebTextRendererFactory.mm: Added. (getAppDefaultValue): (getUserDefaultValue): (getLCDScaleParameters): (fontsChanged): (+[WebTextRendererFactory createSharedFactory]): (-[WebTextRendererFactory isFontFixedPitch:]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (FontCacheKeyCopy): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):
3:15 PM Changeset in webkit [14111] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-28 Eric Seidel <​eseidel@apple.com>

Fix by beth. Reviewed by darin. Landed by eseidel.

Make hackish fix to avoid crash in Xcode and Filemaker.
<rdar://problem/4059059> Crash in RenderFlow::detach (XCode Documentation Window)

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:pageCache:]):
3:03 PM Changeset in webkit [14110] by eseidel
  • 2 edits in trunk/WebCore

2006-04-28 Eric Seidel <​eseidel@apple.com>

Fix by beth. Reviewed by darin. Landed by eseidel.

Make hackish fix to avoid crash in Xcode and Filemaker.
<rdar://problem/4059059> Crash in RenderFlow::detach (XCode Documentation Window)

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:pageCache:]):
2:09 PM Changeset in webkit [14109] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-23 Darin Adler <Darin Adler>

Reviewed by Beth.

  • fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.
1:57 PM Changeset in webkit [14108] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-26 Tim Omernick <​timo@apple.com>

Reviewed by Hyatt.

<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript

  • html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.
1:51 PM Changeset in webkit [14107] by thatcher
  • 7 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-22 Beth Dakin <Beth Dakin>

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6141
DOMCSSPrimitiveValue is always returning values in pixels when
using getComputedStyle:

getFloatValue() took a unit type as a parameter, ignored it, and
returned m_value.num. This patch writes a second version of the
function that actually converts m_value.num to the specified unites
before returning it. Where a conversion is not required, I removed
the unit type from the caller so that it would go directly to the
inline version of the function.

  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValue::computeLengthFloat): Remove type parameter since a conversion is not needed. (WebCore::scaleFactorForConversion): Helper function for conversion. (WebCore::CSSPrimitiveValue::getFloatValue): This version of getFloatValue() takes a unit type parameter and converts m_value.num.
  • css/css_valueimpl.h: (WebCore::CSSPrimitiveValue::getFloatValue): This version does not take a parameter and just returns m_value.num.
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage): Remove type parameter since a conversion is not needed.
  • css/cssstyleselector.cpp: (WebCore::convertToLength): Same. (WebCore::CSSStyleSelector::applyProperty): Same. (WebCore::CSSStyleSelector::mapBackgroundSize): Same. (WebCore::CSSStyleSelector::mapBackgroundXPosition): Same. (WebCore::CSSStyleSelector::mapBackgroundYPosition): Same.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Same.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Same.
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): Same.
1:05 PM Changeset in webkit [14106] by ap
  • 11 edits in trunk

Reviewed by hyatt.

WebCore:

LayoutTests:

  • fast/css/acid2.html: Updated to the current version of the test, which no longer includes SGML comment parsing.
  • fast/css/acid2-pixel.html: Ditto.
  • http/tests/misc/acid2-pixel.html: Ditto.
  • http/tests/misc/acid2.html: Ditto.
  • fast/parser/comments-expected.checksum: The results of this test now match WinIE.
  • fast/parser/comments-expected.png:
  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html:
12:51 PM Changeset in webkit [14105] by eseidel
  • 12 edits in trunk/WebKit

2006-04-28 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Misc. style cleanup.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8643

  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _iconsForIconURLString:]): (-[WebIconDatabase _forgetIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): (-[WebBasePluginPackage pListForPath:createFile:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): (-[WebBasePluginPackage isNativeLibraryData:]): (-[NSArray _web_lowercaseStrings]):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage executableType]): (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]):
  • Plugins/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation redeliverStream]):
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase pluginForExtension:]): (pluginLocations): (-[WebPluginDatabase init]): (-[WebPluginDatabase refresh]):
  • Plugins/npapi.m: (NPN_MemAlloc): (NPN_MemFree): (pluginViewForInstance):
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader willSendRequest:redirectResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSource isLoading]):
  • WebView/WebFrame.m: (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _subframeIsLoading]):
  • WebView/WebView.m: (-[WebView initWithFrame:]): (-[WebView initWithFrame:frameName:groupName:]):
11:56 AM Changeset in webkit [14104] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-01-24 Tim Omernick <​timo@apple.com>

Reviewed by Dave Harrison.

<rdar://problem/4339024>
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or embed
(and plugin view)"


  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl): Assert that appletInstance has been deleted by detach(). (WebCore::HTMLAppletElementImpl::detach): Delete appletInstance, because it references the widget owned by the renderer we're about to destroy. It is assumed elsewhere (getRuntimeObject(), kjs_dom.cpp) that the instance is owned by the applet element. Therefore, it is required that the element destroy the instance in its tear-down phase. (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl): Assert that embedInstance has been deleted by detach(). (WebCore::HTMLEmbedElementImpl::detach): Delete embedInstance, same reason. This is the one that fixes <rdar://problem/4339024>. (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl): Assert that objectInstance has been deleted by detach(). (WebCore::HTMLObjectElementImpl::detach): Delete embedInstance, same reason.
  • khtml/html/html_objectimpl.h: Declared HTMLAppletElementImpl::detach() and HTMLEmbedElementImpl::detach().
11:24 AM Changeset in webkit [14103] by thatcher
  • 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-27 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Make WebCore accept any */*+xml type as XML.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5998
<rdar://problem/4031511> XmlHttpRequest doesn't allow responses with Content-Type: application/soap+xml

Test: http/tests/xmlhttprequest/supported-xml-content-types.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType):
10:05 AM Changeset in webkit [14102] by darin
  • 34 edits
    2 moves in trunk/WebCore

Reviewed by Eric.

  • Changed GraphicsContext to use NSGraphicsContext as little as possible.
  • Removed the printing flag from GraphicsContext.
  • Changed GraphicsContext to assume the NSGraphicsContext is always flipped, and got rid of parameters to pass the flipped boolean around.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add GraphicsTypes.h/cpp and remove CompositeOperator.h/cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • html/CanvasPattern.cpp: (WebCore::patternCallback):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::createGraphicsContext):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::lockDrawingFocus): Update for changes to GraphicsContext constructor (no flipped or printing boolean).
  • html/CanvasRenderingContext2D.h: Added a Path to the context state. Changed the LineCap and LineJoin types to use the new ones in GraphicsTypes.h instead of defining types here in this class. Changed m_platformContextStrokeStyleIsPattern and m_platformContextFillStyleIsPattern to be named m_appliedStrokePattern and m_appliedFillPattern and moved them outside the APPLE ifdefs. Removed the platformContext() function. Moved applyStrokePattern and applyFillPattern out of the APPLE ifdef.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): Moved the stroke pattern booleans out of Mac-specific ifdef. (WebCore::CanvasRenderingContext2D::save): Changed to use GraphicsContext instead of using CGContext directly. (WebCore::CanvasRenderingContext2D::restore): Ditto. (WebCore::CanvasRenderingContext2D::setStrokeStyle): Ditto. (WebCore::CanvasRenderingContext2D::setFillStyle): Ditto. (WebCore::CanvasRenderingContext2D::setLineWidth): Ditto. (WebCore::CanvasRenderingContext2D::lineCap): Ditto. (WebCore::CanvasRenderingContext2D::setLineCap): Ditto. (WebCore::CanvasRenderingContext2D::lineJoin): Ditto. (WebCore::CanvasRenderingContext2D::setLineJoin): Ditto. (WebCore::CanvasRenderingContext2D::setMiterLimit): Ditto. (WebCore::CanvasRenderingContext2D::shadowColor): Ditto. (WebCore::CanvasRenderingContext2D::setGlobalAlpha): Ditto. (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): Ditto. (WebCore::CanvasRenderingContext2D::scale): Update since platformContext() function no longer exists. (WebCore::CanvasRenderingContext2D::rotate): Ditto. (WebCore::CanvasRenderingContext2D::translate): Ditto. (WebCore::CanvasRenderingContext2D::beginPath): Changed to use GraphicsContext instead of using CGContext directly. (WebCore::CanvasRenderingContext2D::closePath): Ditto. (WebCore::CanvasRenderingContext2D::moveTo): Ditto. (WebCore::CanvasRenderingContext2D::lineTo): Ditto. (WebCore::CanvasRenderingContext2D::quadraticCurveTo): Ditto. (WebCore::CanvasRenderingContext2D::bezierCurveTo): Ditto. (WebCore::CanvasRenderingContext2D::arcTo): Ditto. (WebCore::CanvasRenderingContext2D::arc): Ditto. (WebCore::CanvasRenderingContext2D::rect): Ditto. (WebCore::CanvasRenderingContext2D::fill): Changed to use the current path from this class instead of relying on the CGContext's current path. (WebCore::CanvasRenderingContext2D::stroke): Ditto. (WebCore::CanvasRenderingContext2D::clip): Changed to use the current path and use the GraphicsContext instead of using CGContext directly. (WebCore::CanvasRenderingContext2D::clearRect): Changed to use GraphicsContext instead of using CGContext directly. (WebCore::CanvasRenderingContext2D::fillRect): Update since platformContext() function no longer exists. (WebCore::CanvasRenderingContext2D::strokeRect): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto. (WebCore::CanvasRenderingContext2D::drawImage): Ditto. (WebCore::CanvasRenderingContext2D::drawImageFromRect): Ditto. (WebCore::CanvasRenderingContext2D::createPattern): Ditto. (WebCore::CanvasRenderingContext2D::applyStrokePattern): Made a tiny bit of this function cross-platform. The bulk is still Mac-specific. (WebCore::CanvasRenderingContext2D::applyFillPattern): Ditto.
  • html/CanvasStyle.h: Changed to use GraphicsContext instead of CGContext. Now the platform-specific stuff is in the implementation, not the header.
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): Moved the ifdefs inside the function, getting us one step closer to platform independence. (WebCore::CanvasStyle::applyFillColor): Ditto.
  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRect): Update for changes to the Path class. (WebCore::HTMLAreaElement::getRegion): Ditto.
  • page/Frame.cpp: (WebCore::Frame::paint): Change to check printing flag on the document, rather than on the GraphicsContext, since there is no printing flag for GraphicsContext any more. (WebCore::Frame::adjustPageHeight): Update for change to GraphicsContext constructor.
  • platform/GraphicsContext.h: Define a type called PlatformGraphicsContext so the platform-specific getter and constructor don't have to be ifdef'd. Added clearRect, strokeRect, setLineWidth, setLineCap, setLineJoin, setMiterLimit, setAlpha, setCompositeOperation, and clip functions. Removed the isForPrinting parameter from createGraphicsContextPrivate.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): Removed isForPrinting. (WebCore::GraphicsContext::createGraphicsContextPrivate): Ditto.
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Removed NSGraphicsContext. (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): Ditto. (WebCore::GraphicsContext::GraphicsContext): Removed constructor that takes an NSGraphicsContext. Removed the flipText and forPrinting parameters to the other constructor. (WebCore::GraphicsContext::savePlatformState): Removed NSGraphicsContext code. (WebCore::GraphicsContext::restorePlatformState): Ditto. (WebCore::GraphicsContext::drawRect): Updated assertion to more-precisely reflect the limitation of the current version of this function. (WebCore::GraphicsContext::setColorFromFillColor): Ditto. (WebCore::GraphicsContext::setColorFromPen): Ditto. (WebCore::GraphicsContext::drawLine): Updated assertion to more-precisely reflect the limitation of the current version of this function. (WebCore::setCompositeOperation): (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::setLineWidth): Added. (WebCore::GraphicsContext::setMiterLimit): Added. (WebCore::GraphicsContext::setAlpha): Added. (WebCore::GraphicsContext::setCompositeOperation): Added. (WebCore::GraphicsContext::clearRect): Added. (WebCore::GraphicsContext::strokeRect): Added. (WebCore::GraphicsContext::setLineCap): Added. (WebCore::GraphicsContext::setLineJoin): Added. (WebCore::GraphicsContext::clip): Added.
  • platform/CompositeOperator.cpp: Removed.
  • platform/CompositeOperator.h: Removed.
  • platform/GraphicsTypes.cpp: Added. Includes CompositeOperator, LineCap, and LineJoin.
  • platform/GraphicsTypes.h: Added.
  • platform/Image.h: Changed include to GraphicsTypes.h from CompositeOperator.h.
  • platform/Path.h: Removed constructors that take a Rect and an array of points. Made the Path mutable. Changed the types for contains and boundingRect to be float-based instead of int-based. Changed translate to take a FloatSize instead of two integers. Added clear, moveTo, addLineTo, addQuadCurveTo, addBezierCurveTo, addArcTo, closeSubpath, addArc, addRect, addEllipse, and platformPath functions. Defined a PlatformPath type so we don't have to ifdef the header so much.
  • platform/cg/PathCG.cpp: (WebCore::Path::Path): Changed class to always have a mutable path. (WebCore::Path::operator=): Changed to make a mutable copy. (WebCore::Path::contains): Changed to take a FloatPoint instead of IntPoint. (WebCore::Path::translate): Changed to use a FloatSize instead of two ints. (WebCore::Path::boundingRect): Changed to return a FloatRect. (WebCore::Path::moveTo): Added. (WebCore::Path::addLineTo): Added. (WebCore::Path::addQuadCurveTo): Added. (WebCore::Path::addBezierCurveTo): Added. (WebCore::Path::addArcTo): Added. (WebCore::Path::closeSubpath): Added. (WebCore::Path::addArc): Added. (WebCore::Path::addRect): Added. (WebCore::Path::addEllipse): Added. (WebCore::Path::clear): Added.
  • platform/mac/ImageMac.mm: (WebCore::fillSolidColorInRect): Changed to take a GraphicsContext instead of a CGContext. (WebCore::Image::checkForSolidColor): Changed to use the new setCompositeOperation in GraphicsContex. (WebCore::Image::draw): Changed to use the new PDF image and fillSolidColorInRect function that take GraphicsContext instead of CGContext. (WebCore::Image::drawTiled): Ditto.
  • platform/mac/PDFDocumentImage.h: Made most functions private. Changed to use GraphicsContext and FloatRect instead of CGContext and NSRect. Also removed the unused alpha and flipped booleans.
  • platform/mac/PDFDocumentImage.mm: (WebCore::PDFDocumentImage::bounds): Update for change in types. (WebCore::PDFDocumentImage::adjustCTM): Ditto. (WebCore::PDFDocumentImage::setCurrentPage): Ditto. (WebCore::PDFDocumentImage::draw): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Added lots of new stubs.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Changed to get printing boolean from document instead graphics context.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren): Ditto. (WebCore::RenderBlock::paintObject): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Ditto.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint): Ditto.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintButton): Ditto.
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): Ditto.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint): Ditto.
9:02 AM Changeset in webkit [14101] by ap
  • 9 edits
    4 adds in trunk

2006-04-28 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt, landed by ap.

WebCore:

Test: fast/repaint/table-extra-bottom-grow.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed to not add the top/left overflow twice and allow the normal overflow height to overlap with the bottom extra height.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout): Removed the code that resets the extra heights.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): If the top extra height changed or the bottom extra height increased, just repaint the entire cell.

LayoutTests:

  • fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
  • fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • fast/repaint/table-extra-bottom-grow-expected.txt: Added.
  • fast/repaint/table-extra-bottom-grow.html: Added.
  • fast/repaint/table-cell-moved-expected.checksum: Removed excessive painting.
  • fast/repaint/table-cell-moved-expected.png: Ditto.
  • fast/repaint/bugzilla-6278-expected.checksum: Ditto.
  • fast/repaint/bugzilla-6278-expected.png: Ditto.
8:37 AM Changeset in webkit [14100] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (main): Call [[NSURLCache sharedURLCache] removeAllCachedResponses].
5:49 AM Changeset in webkit [14099] by eseidel
  • 2 edits in trunk/WebKitSite

2006-04-28 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

  • projects/svg/status.xml: Update to reflect current status.
5:30 AM Changeset in webkit [14098] by eseidel
  • 3 edits in trunk/WebKitTools

2006-04-28 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

  • Scripts/do-webcore-rename: rename KCanvasContainer too
  • Scripts/run-webkit-tests: output total time
4:50 AM Changeset in webkit [14097] by eseidel
  • 16 edits in trunk/WebCore

2006-04-28 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Remove KCanvasContainerQuartz, pushing all logic into KCanvasContainer.

  • kcanvas/KCanvasContainer.cpp: (WebCore::KCanvasContainer::canHaveChildren): (WebCore::KCanvasContainer::requiresLayer): (WebCore::KCanvasContainer::lineHeight): (WebCore::KCanvasContainer::baselinePosition): (WebCore::KCanvasContainer::calcMinMaxWidth): (WebCore::KCanvasContainer::layout): (WebCore::KCanvasContainer::paint): (WebCore::KCanvasContainer::setViewport): (WebCore::KCanvasContainer::viewport): (WebCore::KCanvasContainer::setViewBox): (WebCore::KCanvasContainer::viewBox): (WebCore::KCanvasContainer::setAlign): (WebCore::KCanvasContainer::align): (WebCore::KCanvasContainer::viewportTransform): (WebCore::KCanvasContainer::getAbsoluteRepaintRect): (WebCore::KCanvasContainer::absoluteTransform): (WebCore::KCanvasContainer::getAspectRatio):
  • kcanvas/KCanvasContainer.h: (WebCore::KCanvasContainer::renderName):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createPaintServer):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::createRenderer):
  • ksvg2/svg/SVGGElement.cpp: (SVGGElement::createRenderer):
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::createRenderer):
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::createRenderer):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::createRenderer):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createRenderer):
  • ksvg2/svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::createRenderer):
  • ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::createRenderer):
3:57 AM Changeset in webkit [14096] by eseidel
  • 5 edits
    3 adds in trunk

2006-04-27 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Make WebCore accept any */*+xml type as XML.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5998
<rdar://problem/4031511> XmlHttpRequest doesn't allow responses with Content-Type: application/soap+xml

Test: http/tests/xmlhttprequest/supported-xml-content-types.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType):

Apr 27, 2006:

8:49 PM Changeset in webkit [14095] by eseidel
  • 2 edits in trunk/WebCore

2006-04-27 Eric Seidel <​eseidel@apple.com>

  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix break from last checkin.
6:00 PM Changeset in webkit [14094] by ggaren
  • 26 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej

  • Minor fixups I discovered while working on the autogenerator.


  • kjs/lookup.cpp: (findEntry): ASSERT that size is not 0, because otherwise we'll % by 0, compute a garbage address, and possibly crash.
  • kjs/lookup.h: (cacheGlobalObject): Don't enumerate cached objects -- ideally, they would be hidden entirely.

LayoutTests:

  • Updated to remove diff shmutz:
  • fast/dom/Window/window-special-properties-expected.txt:
  • fast/dom/Window/window-special-properties.html:
  • Test for global window properties like window.HTMLDocument:


  • fast/dom/global-constructors-expected.txt: Added.
  • fast/dom/global-constructors.html: Added.

WebCore:

Reviewed by Maciej.

  • Added global constructor autogeneration for the following, many of which are required by *.live.com: Node, Element, Range, CSSRule, CSSValue, CSSPrimitiveValue, CSSStyleDeclaration, Event, MutationEvent, NodeFilter

It works like so:


  • The autogenerator knows about the "Constructor" data type, which gets special treatment because it exists purely in the bindings. It also knows about the "GenerateConstructor" interface attribute, which does just that.
  • The window interface has many Constructor attributes
  • The hash table generator swizzles empty tables to tables with one empty bucket, to prevent crashes in Lookup::findEntry. (The old generator used to work this way, too.)
  • Window object property lookup gets special treatment to allow shadowing of its built-in global constructor properties. We'll need to expand this mechanism in the future and make it more flexible, but it works for now.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_window.cpp: Removed 'namedFrameGetter' and its use because they were bogus; added FIXME describing what they were attempting to do. (KJS::Window::getValueProperty): (KJS::Window::getOverridePropertySlot): (KJS::Window::getOwnPropertySlot):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl: Added.
  • css/CSSValue.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/MutationEvent.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/Range.idl:
  • page/DOMWindow.idl:
5:39 PM Changeset in webkit [14093] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

2006-04-27 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2006-02-27 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

  • fast/dom/css-selectorText-expected.checksum: Updated.
  • fast/dom/css-selectorText-expected.png: Updated.
  • fast/dom/css-selectorText-expected.txt: Updated.
  • fast/dom/css-selectorText.html: Added a case with multiple subselectors.

2006-04-27 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2005-12-12 Timothy Hatcher <​timothy@apple.com>

Reviewed by Dave Hyatt.

Test: fast/dom/css-selectorText.html

Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.

  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):
4:44 PM Changeset in webkit [14092] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan, Eric Seidel

<rdar://problem/4340787> Safari creates 2 instances of the some plug-ins


  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView of the appropriate class. Right now, this can only happen when the loading document is a standalone WebKit plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that kind of page load.


I have verified that this does not affect other kinds of page loads; in all other cases, the representation
class is distinct from the document view class.

I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
approach.

4:39 PM Changeset in webkit [14091] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4472035> SPI that checks for URL policy fails in plugin documents

  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController URLPolicyCheckReferrer]): New method. Get the referrer from the frame's data source's NSURLResponse. Note that for document types loaded by WebCore, this URL is the same as -[WebCorePageBridge referrer], since the response URL is what we pass to -[WebCorePageBridge openURL:].
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use the WebPluginController's -URLPolicyCheckReferrer instead of assuming that the bridge's -referrer is valid. -[WebCorePageBridge referrer] is only set during the normal WebCore page load process, which has nothing to do with loading standalone plugin documents.
4:24 PM Changeset in webkit [14090] by justing
  • 1 edit in trunk/LayoutTests/ChangeLog

Give credit where credit is due.

4:00 PM Changeset in webkit [14089] by justing
  • 2 edits
    51 adds
    12 deletes in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8607>
Automate repaint tests

  • fast/repaint/backgroundSizeRepaint-expected.checksum: Added.
  • fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • fast/repaint/backgroundSizeRepaint-expected.txt: Added.
  • fast/repaint/backgroundSizeRepaint.html: Added.
  • fast/repaint/border-repaint-glitch-expected.checksum: Added.
  • fast/repaint/border-repaint-glitch-expected.png: Added.
  • fast/repaint/border-repaint-glitch-expected.txt: Added.
  • fast/repaint/border-repaint-glitch.html: Added.
  • fast/repaint/bugzilla-3509-expected.checksum: Added.
  • fast/repaint/bugzilla-3509-expected.png: Added.
  • fast/repaint/bugzilla-3509-expected.txt: Added.
  • fast/repaint/bugzilla-3509.html: Added.
  • fast/repaint/bugzilla-5699-expected.checksum: Added.
  • fast/repaint/bugzilla-5699-expected.png: Added.
  • fast/repaint/bugzilla-5699-expected.txt: Added.
  • fast/repaint/bugzilla-5699.html: Added.
  • fast/repaint/bugzilla-6278-expected.checksum: Added.
  • fast/repaint/bugzilla-6278-expected.png: Added.
  • fast/repaint/bugzilla-6278-expected.txt: Added.
  • fast/repaint/bugzilla-6278.html: Added.
  • fast/repaint/bugzilla-6388-expected.checksum: Added.
  • fast/repaint/bugzilla-6388-expected.png: Added.
  • fast/repaint/bugzilla-6388-expected.txt: Added.
  • fast/repaint/bugzilla-6388.html: Added.
  • fast/repaint/bugzilla-6473-expected.checksum: Added.
  • fast/repaint/bugzilla-6473-expected.png: Added.
  • fast/repaint/bugzilla-6473-expected.txt: Added.
  • fast/repaint/bugzilla-6473.html: Added.
  • fast/repaint/bugzilla-7235-expected.checksum: Added.
  • fast/repaint/bugzilla-7235-expected.png: Added.
  • fast/repaint/bugzilla-7235-expected.txt: Added.
  • fast/repaint/bugzilla-7235.html: Added.
  • fast/repaint/inline-outline-repaint-expected.checksum: Added.
  • fast/repaint/inline-outline-repaint-expected.png: Added.
  • fast/repaint/inline-outline-repaint-expected.txt: Added.
  • fast/repaint/inline-outline-repaint.html: Added.
  • fast/repaint/outline-repaint-glitch-expected.checksum: Added.
  • fast/repaint/outline-repaint-glitch-expected.png: Added.
  • fast/repaint/outline-repaint-glitch-expected.txt: Added.
  • fast/repaint/outline-repaint-glitch.html: Added.
  • fast/repaint/repaint-resized-overflow-expected.checksum: Added.
  • fast/repaint/repaint-resized-overflow-expected.png: Added.
  • fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • fast/repaint/repaint-resized-overflow.html: Added.
  • fast/repaint/repaint.js: Added.
  • fast/repaint/resources: Added.
  • fast/repaint/resources/apple.jpg: Added.
  • fast/repaint/table-cell-move-expected.checksum: Added.
  • fast/repaint/table-cell-move-expected.png: Added.
  • fast/repaint/table-cell-move-expected.txt: Added.
  • fast/repaint/table-cell-move.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8607>
Automate repaint tests

  • manual-tests/backgroundSizeRepaint.html: Removed.
  • manual-tests/border-repaint-glitch.html: Removed.
  • manual-tests/bugzilla-3509.html: Removed.
  • manual-tests/bugzilla-5699.html: Removed.
  • manual-tests/bugzilla-6278.html: Removed.
  • manual-tests/bugzilla-6388.html: Removed.
  • manual-tests/bugzilla-6473.html: Removed.
  • manual-tests/bugzilla-7235.html: Removed.
  • manual-tests/inline-outline-repaint.html: Removed.
  • manual-tests/outline-repaint-glitch.html: Removed.
  • manual-tests/repaint-resized-overflow.html: Removed.
  • manual-tests/table-cell-move.html: Removed.
3:11 PM Changeset in webkit [14088] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej.

Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
for dimensions like 'margin-left'

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For margin and padding, to match Firefox we now go to the renderer to get the property value instead of calling valueForLength() on the style attribute. valueForLength() will return the string 'auto' if that was what was specified in the CSS, or a percentage if it was specified as a percent. But to match Firefox, we always want to return a pixel value for margin and padding.
3:04 PM Changeset in webkit [14087] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
  • dom/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h:
1:11 PM Changeset in webkit [14086] by justing
  • 13 edits
    24 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8624>
Placeholders aren't always removed during paste
<rdar://problem/4059807>
Seed: Mail: pasting quoted content sometimes adds a phantom newline


If a webkit-block-placeholder has been introduced by a bug in deletion,
we shouldn't remove it during paste if it is now acting as a linebreak.

  • editing/pasteboard/bad-placeholder-expected.checksum: Added.
  • editing/pasteboard/bad-placeholder-expected.png: Added.
  • editing/pasteboard/bad-placeholder-expected.txt: Added.
  • editing/pasteboard/bad-placeholder.html: Added. Generic placeholder brs should be removed if they are displaced by pasted content.
  • editing/pasteboard/displaced-generic-placeholder-expected.checksum: Added.
  • editing/pasteboard/displaced-generic-placeholder-expected.png: Added.
  • editing/pasteboard/displaced-generic-placeholder-expected.txt: Added.
  • editing/pasteboard/displaced-generic-placeholder.html: Added. So should placeholder brs with our special class on them.
  • editing/pasteboard/displaced-placeholder-expected.checksum: Added.
  • editing/pasteboard/displaced-placeholder-expected.png: Added.
  • editing/pasteboard/displaced-placeholder-expected.txt: Added.
  • editing/pasteboard/displaced-placeholder.html: Added. Removed an unnecessary collapsed br.
  • editing/pasteboard/paste-text-010-expected.txt: Two fixes, an extra line was present after pasting with an interchange newline.
  • editing/pasteboard/paste-text-016-expected.checksum: Added.
  • editing/pasteboard/paste-text-016-expected.png: Added.
  • editing/pasteboard/paste-text-016-expected.txt: Added.
  • editing/pasteboard/paste-text-017-expected.checksum: Added.
  • editing/pasteboard/paste-text-017-expected.png: Added.
  • editing/pasteboard/paste-text-017-expected.txt: Added. The code that interprets the incoming br as a br in strict mode had a bug.
  • editing/pasteboard/quirks-mode-br-1-expected.checksum: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.png: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.txt: Added.
  • editing/pasteboard/quirks-mode-br-1.html: Added. The linePlaceholder removal was negating the work to interpret the last incoming br as a br in strict mode.
  • editing/pasteboard/quirks-mode-br-2-expected.checksum: Added.
  • editing/pasteboard/quirks-mode-br-2-expected.png: Added.
  • editing/pasteboard/quirks-mode-br-2-expected.txt: Added.
  • editing/pasteboard/quirks-mode-br-2.html: Added. Don't let collapsed brs become rendered as a result of the paste operation.
  • editing/pasteboard/unrendered-br-expected.checksum: Added.
  • editing/pasteboard/unrendered-br-expected.png: Added.
  • editing/pasteboard/unrendered-br-expected.txt: Added.
  • editing/pasteboard/unrendered-br.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8624>
Placeholders aren't always removed during paste
<rdar://problem/4059807>
Seed: Mail: pasting quoted content sometimes adds a phantom newline

  • editing/CompositeEditCommand.cpp: Added a FIXME.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed two no-op setEndingSelection calls. Store away a br at the position where we'll start inserting content in case the br a) is made unnecessary by the insertion (it's collapsed away) b) was acting as a placeholder and should therefore be displaced by inserted content or c) was acting as a line break and, as a result of the insertion, is now acting as a placeholder. Don't only store away brs that have the webkit-block-placeholder class on them. Any br that does any of the three things just mentioned should be removed. The linePlaceholder removal was run after the code that makes sure to interpret incoming brs strictly, and was negating that work in certain cases.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded): Described above.

  • editing/ReplaceSelectionCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): Added a workaround for 8622. We want this function to return true even if one of the two visible positions has been incorrectly canonicalized.
11:39 AM Changeset in webkit [14085] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by darin.

<rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
Also cleaned up spacing a little.

No layout test possible (local loads are non incremental).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::slotData):
11:34 AM Changeset in webkit [14084] by adele
  • 13 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Beth.

Fix for <rdar://problem/4073701> click event not sent with dispatchEvent

Removed KHTML_CLICK_EVENT and KHTML_DBLCLICK_EVENT. Just use CLICK_EVENT and DBLCLICK_EVENT.

  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): (HTMLElementImpl::click):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.h:
  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked):
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::idToType):
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchMouseEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]):
9:57 AM Changeset in webkit [14083] by ggaren
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

speculative fix for windows build

Apr 26, 2006:

5:57 PM Changeset in webkit [14082] by tomernic
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test case for <rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when
CSS Display Style is Toggled via Javascript

  • plugins/inner-html-display-none.html: Added.
  • plugins/inner-html-display-none-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript

  • html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.
3:31 PM Changeset in webkit [14081] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Rolling out grandparent NULL check because it caused this regression and there's no test case justifying it.
2:35 PM Changeset in webkit [14080] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-02-23 Vicki Murley <​vicki@apple.com>

Reviewed by Tim Omernick.


  • fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

Check shouldClose() before actually scheduling a close.

shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
result based on whether the user clicks "OK" or "Cancel". In cases where the window is closed with cmd-w
or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method. Since
windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
closes a window even gets started.

  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
2:10 PM Changeset in webkit [14079] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

Updated to mention the bug that this testcase still demonstrates.
Leaving it disabled until the bug (8592) is fixed:

  • editing/deleting/merge-whitespace-pre.html-disabled:


Illustrates why prune should ascend using the render tree:

  • editing/deleting/pruning-after-merge-1-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-1-expected.png: Added.
  • editing/deleting/pruning-after-merge-1-expected.txt: Added.
  • editing/deleting/pruning-after-merge-1.html: Added.

WebCore:

Reviewed by hyatt


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::prune): The function would prune a rendered leaf because it assumed that the first node passed to it would be a container. The old code ascended using the DOM tree, and would remove the <b> when pruning the <div> in <b><div></div>foo</b>. Now ascends using the render tree.
1:57 PM Changeset in webkit [14078] by thatcher
  • 21 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2006-02-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use SharedPtrs, and sent them to bed without dessert.

  • bindings/jni/jni_instance.cpp: Made _instance a SharedPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref):
  • bindings/jni/jni_runtime.cpp: Made _array a SharedPtr (JavaArray::~JavaArray): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=):
  • bindings/objc/objc_runtime.h:
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject):
  • bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
  • bindings/runtime_object.h:
  • Removed ownsInstance data member because SharedPtr takes care of instance lifetime now.
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance):

WebCore:

Merged fix from TOT to Safari-2-0-branch

2006-02-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use SharedPtrs, and sent them to bed without dessert.

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a SharedPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a SharedPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made m_objectInstance a SharedPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach):
  • bindings/js/JSDOMCore.cpp:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/html/html_objectimpl.h:
1:42 PM Changeset in webkit [14077] by ggaren
  • 3 edits in trunk/WebCore

This time for sure. Fixed Windows build too.


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
1:29 PM Changeset in webkit [14076] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by TimO.

Build fix.

  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_domnode.h:
1:18 PM Changeset in webkit [14075] by tomernic
  • 6 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4525105> Repro TOT crash in [WebBaseNetscapePluginView dealloc] at coachella.com
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8564> crashed when closing a tab

  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Assert that plugInViews has been released. (-[WebFrame _addPlugInView:]): New method. Adds the plug-in view to the plugInViews set and calls -setWebFrame: on it. (-[WebFrame _removeAllPlugInViews]): New method. Calls -setWebFrame:nil on all plug-in views and releases the plugInViews set. (-[WebFrame _willCloseURL]): New method. Dispose of plug-in views when leaving a page (or closing the WebView).
  • WebView/WebFrameInternal.h: Declared -_addPlugInView:, -_removeAllPlugInViews, -_willCloseURL
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): Call -[WebFrame _addPlugInView:] instead of directly setting plug-in views' frames. This allows us to keep track of them so that we can explicitly dispose of them when leaving the page. (-[WebFrameBridge closeURL]): Override -[WebCoreFrameBridge closeURL] so that we can perform our own teardown when leaving a page or closing the WebView.
  • Plugins/WebBaseNetscapePluginView.h: Declared -stop so that subclass WebNetscapePluginEmbeddedView can call it.
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): Stop the plug-in when it is removed from its WebFrame.
1:02 PM Changeset in webkit [14074] by ggaren
  • 13 edits
    2 adds in trunk

LayoutTests:

Reviewed by OMG DETHBAKIN.

  • fast/dom/prototype-chain-expected.txt: Fix up prototype chain now that Node is autogenerated.

WebCore:

Reviewed by OMG DETHBAKIN.

  • Start autogenerating Node. This fixes many missing attributes in our DOM by making prototypes hold their relevant constants as properties.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::toJS):
  • bindings/js/kjs_dom.h: (KJS::DOMEventTargetNode::):
  • bindings/js/kjs_domnode.h: Had to break DOMNode into a separate header to avoid circular dependency in header includes. Gave it an old-school file name to keep distinguishing beteween old school and news school files easy. (KJS::DOMNode::impl): (KJS::DOMNode::classInfo): (KJS::DOMNode::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/DocumentType.idl:
  • dom/Entity.idl:
  • dom/Node.idl: Added.
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
12:52 PM Changeset in webkit [14073] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4472035> SPI that checks for URL policy fails in plugin documents

  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController URLPolicyCheckReferrer]): New method. Get the referrer from the frame's data source's NSURLResponse. Note that for document types loaded by WebCore, this URL is the same as -[WebCorePageBridge referrer], since the response URL is what we pass to -[WebCorePageBridge openURL:].
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use the WebPluginController's -URLPolicyCheckReferrer instead of assuming that the bridge's -referrer is valid. -[WebCorePageBridge referrer] is only set during the normal WebCore page load process, which has nothing to do with loading standalone plugin documents.
12:09 PM Changeset in webkit [14072] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Committing the project file change jhaygood suggesed in
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8044
WebKit Visual Studio 2005 project shouldn't use the SolutionDir


Instead of his patch, I used the following commands:

sed -e 's/$(SolutionDir)/$(ProjectDir)
../g' Image\ Viewer/Image\
Viewer.vcproj > Image\ Viewer/Image\ Viewer.vcproj_ && mv Image\
Viewer/Image\ Viewer.vcproj_ Image\ Viewer/Image\ Viewer.vcproj

sed -e 's/$(SolutionDir)/$(ProjectDir)
../g'
WebCore/WebCore.vcproj > WebCore/WebCore.vcproj_ && mv
WebCore/WebCore.vcproj_ WebCore/WebCore.vcproj

  • Viewer.vcproj:
  • WebCore.vcproj/WebCore/WebCore.vcproj:

Apr 25, 2006:

9:33 PM Changeset in webkit [14071] by justing
  • 15 edits
    13 adds
    1 delete in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes

Disabling until the bug it illustrates is fixed (8459):

  • editing/deleting/merge-whitespace-pre.html: Removed.
  • editing/deleting/merge-whitespace-pre.html-disabled: Added.


This illustrates the need to do mergeEnd in the opposite direction:

  • editing/pasteboard/merge-end-borders-expected.checksum: Added.
  • editing/pasteboard/merge-end-borders-expected.png: Added.
  • editing/pasteboard/merge-end-borders-expected.txt: Added.
  • editing/pasteboard/merge-end-borders.html: Added.


These illustrate the need to do the special case checks for list content and Mail
blockquote content at the top of shouldMergeStart:

  • editing/pasteboard/merge-start-blockquote-expected.checksum: Added.
  • editing/pasteboard/merge-start-blockquote-expected.png: Added.
  • editing/pasteboard/merge-start-blockquote-expected.txt: Added.
  • editing/pasteboard/merge-start-blockquote.html: Added.
  • editing/pasteboard/merge-start-list-expected.checksum: Added.
  • editing/pasteboard/merge-start-list-expected.png: Added.
  • editing/pasteboard/merge-start-list-expected.txt: Added.
  • editing/pasteboard/merge-start-list.html: Added.


In these tests, the caret was blown away because it was in content that
participated in the end merge. Now the end merge happens in the opposite
direction (incoming content is what is moved when merging paragraphs), so
the caret is no longer blown away:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:


Acceptable change to a complicated paste-a-selection-over-itself:

  • editing/pasteboard/paste-text-003-expected.checksum:
  • editing/pasteboard/paste-text-003-expected.png:
  • editing/pasteboard/paste-text-003-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes


Moved code to make it easier to do the start merge after the fact,
with moveParagraph, instead of in the middle of the paste operation.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::shouldMergeStart): Moved code to make this decision to its own function. Moved special case checks to the top. Added m_forceMergeStart to override the special cases because moveParagraph uses ReplaceSelectionCommand and expects a merge.


(WebCore::ReplaceSelectionCommand::shouldMergeEnd):
No functional changes, just moved code here.
(WebCore::ReplaceSelectionCommand::doApply):
Do the end merge in the opposite direction. Merging two paragraphs destroys
the moved one's block level styles, and we prefer to use the styles of the
one that was in the document, not the one that's being pasted.


  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.h: (WebCore::Selection::visibleStart): Added. (WebCore::Selection::visibleEnd): Added.
  • editing/htmlediting.cpp: (WebCore::enclosingList): Added. (WebCore::isMailBlockquote): Don't require a renderer so that this can be used on nodes in fragments.


  • editing/htmlediting.h:
4:12 PM Changeset in webkit [14070] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc]
running layout tests

  • Plugins/WebPluginPackage.m: (-[WebPluginPackage unload]): Clear isLoaded here. It turns out that only WebNetscapePluginPackage cleared its isLoaded flag in -unload. We need to also do it here, because the superclass (WebBasePluginPackage) asserts in -dealloc that -unload has been called.
3:58 PM Changeset in webkit [14069] by ggaren
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for the DOM properties supported by object, embed, attribute:

  • fast/dom/plugin-attributes-enumeration-expected.txt: Added.
  • fast/dom/plugin-attributes-enumeration.html: Added.


Test for setting attributes through DOM properties:

  • plugins/embed-attributes-setting-expected.txt: Added.
  • plugins/embed-attributes-setting.html: Added.


Test for the special attribute-to-style mappings on embed.

  • plugins/embed-attributes-style-expected.txt: Added.
  • plugins/embed-attributes-style.html: Added.

WebCore:

Reviewed by Maciej.

  • Removed special handling of attributes in the DOM. To match WinIE, we used to make all attributes available as properties of their elements in the DOM, but that has caused us more compatibility woes than it has solved, so, after talking with Darin and Maciej, I'm taking it out. (Firefox does not support it.)

A layout test regression caused by this change led me to do the
following as well:


  • Implemented DOM properties missing on EMBED elements: align, height, name, width, src, type. Since align, height, name, and width are common to all plugin elements, I factored them and some other common functionality out into a new abstract base class, HTMLPlugInElement.
  • Removed extraneous attribute-to-style mappings on EMBED elements: valign, border. Why they were there in the first place is a question for the ages. Neither FF nor IE supports them.
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::embedGetter): (KJS::JSHTMLElement::embedSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Element.idl:
  • html/html_objectimpl.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::align): (WebCore::HTMLPlugInElement::setAlign): (WebCore::HTMLPlugInElement::height): (WebCore::HTMLPlugInElement::setHeight): (WebCore::HTMLPlugInElement::name): (WebCore::HTMLPlugInElement::setName): (WebCore::HTMLPlugInElement::width): (WebCore::HTMLPlugInElement::setWidth): (WebCore::HTMLPlugInElement::mapToEntry): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::checkDTD): (WebCore::HTMLAppletElement::HTMLAppletElement): (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::insertedIntoDocument): (WebCore::HTMLAppletElement::removedFromDocument): (WebCore::HTMLAppletElement::getInstance): (WebCore::HTMLAppletElement::closeRenderer): (WebCore::HTMLAppletElement::detach): (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::mapToEntry): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::attach): (WebCore::HTMLEmbedElement::detach): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLEmbedElement::src): (WebCore::HTMLEmbedElement::setSrc): (WebCore::HTMLEmbedElement::type): (WebCore::HTMLEmbedElement::setType): (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::closeRenderer): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::recalcStyle):
  • html/html_objectimpl.h: (WebCore::HTMLPlugInElement::endTagRequirement): (WebCore::HTMLAppletElement::tagPriority): (WebCore::HTMLEmbedElement::tagPriority): (WebCore::HTMLObjectElement::tagPriority):
3:42 PM Changeset in webkit [14068] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526120> -[WebBasePluginPackage finalize] leaks the CFBundle (under GC only)

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage finalize]): Release the CFBundle here.
3:35 PM Changeset in webkit [14067] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
for dimensions like 'margin-left'

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For margin and padding, to match Firefox we now go to the renderer to get the property value instead of calling valueForLength() on the style attribute. valueForLength() will return the string 'auto' if that was what was specified in the CSS, or a percentage if it was specified as a percent. But to match Firefox, we always want to return a pixel value for margin and padding.
3:02 PM Changeset in webkit [14066] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-31 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Hatcher.


  • fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.
2:51 PM Changeset in webkit [14065] by thatcher
  • 8 edits
    1 add in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:47 PM Changeset in webkit [14064] by brmorris
  • 1 copy in S60/tags/s60-051212

S60: Tagging initial migration at S60/tags/s60-051212

2:44 PM Changeset in webkit [14063] by brmorris
  • 1 delete in S60/trunks

S60: Removed svn/webkit/s60/trunkS

2:34 PM Changeset in webkit [14062] by brmorris
  • 574 edits
    235 adds
    205 deletes in S60/trunk

S60: populated s60/trunk with s60-051212 release.

2:26 PM Changeset in webkit [14061] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController display]):
2:24 PM Changeset in webkit [14060] by tomernic
  • 8 edits
    1 add in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:23 PM Changeset in webkit [14059] by eseidel
  • 2 edits
    3 adds in trunk

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

Test: fast/frames/empty-cols-attribute.html

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): If the string is empty, return 0 but set len to 1. This gives the same behavior you get if you don't specify the attribute at all, matching WinIE and Firefox. Previously, the empty string resulted in len being set to 0 (and a memory smasher in RenderFrameSet::layout()).
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout): Added an assert.
2:22 PM Changeset in webkit [14058] by eseidel
  • 12 edits
    50 adds in trunk

2006-04-26 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasFilters.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasFilters.h: (WebCore::KCComponentTransferFunction::KCComponentTransferFunction):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::genImageFromTable): (WebCore::filterForComponentFunc): (WebCore::setParametersForComponentFunc): (WebCore::getFilterForFunc): (WebCore::KCanvasFEComponentTransferQuartz::getFunctionFilter): (WebCore::KCanvasFEComponentTransferQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.h: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.m: Added. (+[WKComponentMergeFilter initialize]): (+[WKComponentMergeFilter filterWithName:]): (-[WKComponentMergeFilter init]): (-[WKComponentMergeFilter outputImage]):
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: Added. (+[WKDiscreteTransferFilter initialize]): (+[WKDiscreteTransferFilter filterWithName:]): (-[WKDiscreteTransferFilter init]): (-[WKDiscreteTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.m: Added. (+[WKGammaTransferFilter initialize]): (+[WKGammaTransferFilter filterWithName:]): (-[WKGammaTransferFilter init]): (-[WKGammaTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.m: Added. (+[WKIdentityTransferFilter initialize]): (+[WKIdentityTransferFilter filterWithName:]): (-[WKIdentityTransferFilter init]): (-[WKIdentityTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.m: Added. (+[WKLinearTransferFilter initialize]): (+[WKLinearTransferFilter filterWithName:]): (-[WKLinearTransferFilter init]): (-[WKLinearTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKTableTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.m: Added. (+[WKTableTransferFilter initialize]): (+[WKTableTransferFilter filterWithName:]): (-[WKTableTransferFilter init]): (-[WKTableTransferFilter outputImage]):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute): (SVGComponentTransferFunctionElement::transferFunction):
2:21 PM Changeset in webkit [14057] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

New export symbols for a change in JavaScriptGlue.

2:20 PM Changeset in webkit [14056] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptGlue

Merged fix from TOT to Safari-2-0-branch

2006-03-31 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

  • Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.


  • JSUtils.cpp: (KJSValueToJSObject):
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:


  • JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.
12:33 PM Changeset in webkit [14055] by eseidel
  • 4 edits in branches/Safari-2-0-branch/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:32 PM Changeset in webkit [14054] by eseidel
  • 2 edits in trunk/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:16 PM Changeset in webkit [14053] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):
11:53 AM Changeset in webkit [14052] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

changelog fixup

11:38 AM Changeset in webkit [14051] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • don't have a fini method, since trying to call it will actually call the subclass method and mess up the bridge count.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]):
11:05 AM Changeset in webkit [14050] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-20 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.


<rdar://problem/4458568> WebCore should not disclose https referrers

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.
10:59 AM Changeset in webkit [14049] by sfalken
  • 3 edits in trunk/WebCore

2006-04-25 Steve Falkenburg <​sfalkenburg@apple.com>

Reviewed by eseidel.

No test case needed

  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::setFrameGeometry):
1:51 AM Changeset in webkit [14048] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix reproducible crash in html parser code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7137

Test: fast/parser/remove-current-node-parent.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
1:11 AM Changeset in webkit [14047] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Add a missing release
12:18 AM Changeset in webkit [14046] by hyatt
  • 2 edits in trunk/WebCore

Fix for 8336, focus ring redrawing on top of itself. Make sure
not to include empty rects when doing the focus ring drawing, since
that results in a draw with no clip set.

Reviewed by adele

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):

Apr 24, 2006:

10:24 PM Changeset in webkit [14045] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix for 5th worst unresolved crasher:
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test: fast/dom/remove-style-element.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
10:01 PM Changeset in webkit [14044] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.


<rdar://problem/4525364> REGRESSION (yesterday?): LOG() mechanism is broken


  • initialize WebKit's log channels
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel): (WebKitInitializeLoggingChannelsIfNecessary):
  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
  • WebView/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
10:00 PM Changeset in webkit [14043] by eseidel
  • 4 edits in trunk/WebCore

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Speculative fix for our 7th worst crasher.
Also added ASSERTs to help us better understand the issue.
<rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::setInPageCache):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
5:30 PM Changeset in webkit [14042] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4503438> REGRESSION (NativeTextField): Can't insert caret when
selection is active in field (Business/Unit)

  • css/html4.css: Added -webkit-user-select:text for input elements.
5:22 PM Changeset in webkit [14041] by mjs
  • 6 edits in trunk

WebCore:

Build fix:


  • move some prematurely code back
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fini]):

WebKit:

Build fix:


  • move some prematurely code back
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebFrameBridge keyboardUIMode]):
4:54 PM Changeset in webkit [14040] by brmorris
  • 1 copy in S60/trunk

Creating trunk in S60 branch from r9049

4:33 PM Changeset in webkit [14039] by brmorris
  • 1 delete in S60/tags/s60-051212

Reversed s60-051212 import ('svn copy' is better)

3:56 PM Changeset in webkit [14038] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge fini]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]): (_getPreSmartSet): (_getPostSmartSet): (-[WebCoreFrameBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): (-[WebCoreFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebCoreFrameBridge keyboardUIMode]):

WebKit:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge expiresTimeForResponse:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge _preferences]):
3:33 PM Changeset in webkit [14037] by brmorris
  • 1174 adds in S60/tags/s60-051212

Populated S60/tags/s60-051212

2:59 PM Changeset in webkit [14036] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Fix to send textFieldDidBeginEditing on the first editing change instead of on focus.
This matches our old behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::subtreeHasChanged):
2:10 PM Changeset in webkit [14035] by ggaren
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/prototype-chain-expected.txt: Updated now that 'JS' is no longer used as a prefix when serializing DOM elements to string.
  • fast/events/event-view-toString.html: ditto

WebCore:

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:05 PM Changeset in webkit [14034] by brmorris
  • 4 adds in S60

S60: Added toplevel repository layout

11:50 AM Changeset in webkit [14033] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:30 AM Changeset in webkit [14032] by mjs
  • 27 edits in trunk/WebKit

Reviewed by Anders.



I removed all use of these, now objects get at each other via
actual pointers, not using the view hierarchy. However, I left two
of the calls in because other clients rely on them as SPI (ugh).

  • History/WebHistoryItem.m:
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): (-[NSView _web_parentWebFrameView]):
  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins/WebNullPluginView.h:
  • Plugins/WebNullPluginView.m: (-[WebNullPluginView setWebFrame:]): (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController setDataSource:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController webFrame]):
  • Plugins/WebPluginDocumentView.h:
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): (-[WebPluginDocumentView layout]): (-[WebPluginDocumentView currentWindow]): (-[WebPluginDocumentView viewWillMoveToWindow:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): (-[WebFrameBridge formControlIsResigningFirstResponder:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebView/WebClipView.m: (-[NSView initWithFrame:]):
  • WebView/WebFrameView.m: (-[WebFrameView _shouldDrawBorder]): (-[WebFrameView webCoreBridge]):
  • WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _dataSource]): (-[WebHTMLView _bridge]): (-[WebHTMLView _webView]): (-[WebHTMLView _frameView]): (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): (-[NSArray becomeFirstResponder]): (-[NSArray setDataSource:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]): (-[WebHTMLView _frame]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebImageView.h:
  • WebView/WebImageView.m: (-[WebImageView drawRect:]): (-[WebImageView adjustFrameSize]): (-[WebImageView setDataSource:]): (-[WebImageView webView]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView/WebPDFView.h:
  • WebView/WebPDFView.m: (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebTextView.h:
  • WebView/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): (-[WebTextView _preferences]): (-[WebTextView setDataSource:]): (-[WebTextView _webFrame]): (-[WebTextView dragSelectionWithEvent:offset:slideBack:]): (-[WebTextView menuForEvent:]): (-[WebTextView resignFirstResponder]): (-[WebTextView drawPageBorderWithSize:]): (-[WebTextView knowsPageRange:]):
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): (containingFrameView): (-[WebView _focusedFrame]): (-[WebView _frameViewAtWindowPoint:]):

Apr 23, 2006:

9:58 PM Changeset in webkit [14031] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • Took the larger snippets of C++ in the code generator and broke them into HERE documents in the hopes of improving readability.


  • bindings/scripts/CodeGeneratorJS.pm: I indented variable names level with their corresponding HERE documents to clearly "sandwich" the HERE documents between opening and closing EOF statements.
8:47 PM Changeset in webkit [14030] by mjs
  • 13 edits
    2 copies
    2 deletes in trunk

WebCore:

Reviewed by Darin.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreStringTruncator.h: Added.
  • bridge/mac/WebCoreStringTruncator.mm: Added. (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • bridge/mac/WebCoreViewFactory.h:
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton positionButton]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton initWithFrame:]): (-[WebCoreFileButton dealloc]): (-[WebCoreFileButton isFlipped]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton filename]): (-[WebCoreFileButton setFrameSize:]): (-[WebCoreFileButton bestVisualFrameSizeForCharacterCount:]): (-[WebCoreFileButton visualFrame]): (-[WebCoreFileButton setVisualFrame:]): (-[WebCoreFileButton baseline]): (-[WebCoreFileButton beginSheet]): (-[WebCoreFileButton chooseFilename:]): (-[WebCoreFileButton cancel]): (-[WebCoreFileButton chooseButtonPressed:]): (-[WebCoreFileButton mouseDown:]): (-[WebCoreFileButton acceptsFirstResponder]): (-[WebCoreFileButton becomeFirstResponder]): (-[WebCoreFileButton nextKeyView]): (-[WebCoreFileButton previousKeyView]): (-[WebCoreFileButton nextValidKeyView]): (-[WebCoreFileButton previousValidKeyView]): (-[WebCoreFileButton performClick]): (-[WebFileChooserButton initWithWidget:]): (-[WebFileChooserButton nextValidKeyView]): (-[WebFileChooserButton previousValidKeyView]): (-[WebFileChooserButton resignFirstResponder]): (KWQFileButton::KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):

WebKit:

Reviewed by Darin.


  • Misc/WebStringTruncator.m: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebCoreSupport/WebFileButton.h: Removed.
  • WebCoreSupport/WebFileButton.m: Removed.
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory fileButtonChooseFileLabel]): (-[WebViewFactory fileButtonNoFileSelectedLabel]):
  • WebKit.xcodeproj/project.pbxproj:
4:11 PM Changeset in webkit [14029] by mjs
  • 7 edits
    4 deletes in trunk

WebCore:

Reviewed by Eric.

  • remove WebCoreCookieAdapter, instead make mac implementation of CookieJar use Foundation directly.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies): (WebCore::cookiesEnabled):
  • platform/mac/WebCoreCookieAdapter.h: Removed.
  • platform/mac/WebCoreCookieAdapter.m: Removed.

WebKit:

Reviewed by Eric.


  • remove WebCookieAdapter, WebCore can just use Foundation directly.
  • WebCoreSupport/WebCookieAdapter.h: Removed.
  • WebCoreSupport/WebCookieAdapter.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
4:09 PM Changeset in webkit [14028] by mjs
  • 21 edits in trunk/WebKit

Reviewed by Adele.


  • prune WebView SPI of unused calls


Specifically I moved methods that have no callers outside WebKit
to WebViewInternal.h or removed them entirely.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebNullPluginView.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebDataSource.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebScriptDebugDelegate.m:
  • WebView/WebView.m: (-[WebView _downloadURL:]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:57 PM Changeset in webkit [14027] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-21 Rob Buis <​buis@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8170:
SVG CSS property values with extra items do not get treated
as invalid (they should)

Fixes the handling of invalid svg css properties similar
to how invalid html css properties are handled, ie. discard
the property if there are more values in the value list than
expected.

Test: svg/custom/invalid-css.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
3:45 PM Changeset in webkit [14026] by eseidel
  • 2 edits in trunk/WebCore

2006-04-23 Michael Emmel <​mike.emmel@gmail.com>

Reviewed by mjs. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8517
No test necessary, no functional change.

  • DerivedSources.make: use VPATH more consistently.
3:39 PM Changeset in webkit [14025] by eseidel
  • 8 edits
    2 adds in trunk

2006-04-21 Jon Shier <​jshier@iastate.edu>

Reviewed by ggaren. Landed by eseidel.



  • ChangeLog:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): changed khtmlErrorEvent to errorEvent. (KJS::DOMEventTargetNode::putValueProperty): ditto.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): ditto. (KJS::Window::put):
  • dom/EventNames.h: Removed khtmlError macro.


12:16 PM Changeset in webkit [14024] by adele
  • 3 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (dump): If display() has been called during the test, grab the pixels from the view, after letting it repaint invalidated rects. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController display]): Added. Calls -display on the view and changes the subsequent behavior of dump(). (dumpRenderTree):
2:19 AM Changeset in webkit [14023] by eseidel
  • 3 edits
    8 adds in trunk

2006-04-23 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Reproducible crasher with <li value=1234567890 type=A>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8542

Fixed our alphabetical list generation to match WinIE (not FireFox)
Previously our alphabetical lists were completely wrong past 26 items.

Tests:

  • fast/lists/alpha-list-wrap.html
  • fast/lists/li-style-alpha-huge-value-crash.html
  • rendering/render_list.cpp: (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderListMarker::calcMinMaxWidth):

Apr 22, 2006:

9:23 PM Changeset in webkit [14022] by darin
  • 1 edit in trunk/LayoutTests/fast/dom/prototype-chain-expected.txt

Geoff seems to have checked in the change log, but not the updated result.

6:52 PM Changeset in webkit [14021] by mjs
  • 73 edits
    2 deletes in trunk/WebKit

Reviewed by Eric.

  • remove WebKit copy of assertions code, use the assertions stuff from JavaScriptCore instead.
  • Carbon/HIViewAdapter.m:
  • DOM/WebDOMOperations.m:
  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • DefaultDelegates/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
  • History/WebBackForwardList.m:
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
  • History/WebHistoryItem.m:
  • Misc/WebAssertions.h: Removed.
  • Misc/WebAssertions.m: Removed.
  • Misc/WebDatabase.m:
  • Misc/WebDownload.m:
  • Misc/WebFileDatabase.m: (SetThreadPriority):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary releaseIconForURL:]): (-[NSMutableDictionary delayDatabaseCleanup]): (-[NSMutableDictionary allowDatabaseCleanup]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
  • Misc/WebIconLoader.m:
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m:
  • Misc/WebKitSystemBits.m: (initCapabilities):
  • Misc/WebLRUFileList.m: (WebLRUFileListRemoveOldestFileFromList): (WebLRUFileListGetFileSize):
  • Misc/WebLocalizableStrings.m:
  • Misc/WebNSCalendarDateExtras.m:
  • Misc/WebNSDataExtras.m:
  • Misc/WebNSDictionaryExtras.m:
  • Misc/WebNSFileManagerExtras.m:
  • Misc/WebNSPasteboardExtras.m:
  • Misc/WebNSURLExtras.m: (hexDigit): (hexDigitValue): (allCharactersInIDNScriptWhiteList):
  • Misc/WebNSURLRequestExtras.m:
  • Misc/WebNSUserDefaultsExtras.m:
  • Misc/WebStringTruncator.m:
  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]):
  • Panels/WebPanelAuthenticationHandler.m:
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
  • Plugins/WebBaseNetscapePluginView.m: (TSMEventHandler): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
  • Plugins/WebBasePluginPackage.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
  • Plugins/WebNetscapePluginRepresentation.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m: (-[WebPluginController addPlugin:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]):
  • Plugins/WebPluginDatabase.m:
  • Plugins/WebPluginDocumentView.m:
  • WebCoreSupport/WebCookieAdapter.m:
  • WebCoreSupport/WebFileButton.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runModal]):
  • WebCoreSupport/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
  • WebCoreSupport/WebImageDecoder.m:
  • WebCoreSupport/WebImageRenderer.m: (-[WebImageRenderer TIFFRepresentation]):
  • WebCoreSupport/WebImageRendererFactory.m:
  • WebCoreSupport/WebJavaScriptTextInputPanel.m:
  • WebCoreSupport/WebKeyGenerator.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebCoreSupport/WebTextRenderer.m: (widthForGlyph): (-[WebTextRenderer initWithFont:]): (drawGlyphs): (initializeATSUStyle): (createATSULayoutParameters): (getTextBounds): (ATSU_draw):
  • WebCoreSupport/WebTextRendererFactory.m:
  • WebCoreSupport/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView/WebArchiver.m: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
  • WebView/WebClipView.m:
  • WebView/WebDataProtocol.m:
  • WebView/WebDataSource.m: (-[WebDataSource _startLoading]):
  • WebView/WebFormDataStream.m: (formEventCallback): (webSetHTTPBody):
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]):
  • WebView/WebFrameView.m:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray drawSingleRect:]): (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray deleteBackwardByDecomposingPreviousCharacter:]): (-[NSArray checkSpelling:]): (-[NSArray showGuessPanel:]): (-[NSArray _changeSpellingToWord:]): (-[NSArray ignoreSpelling:]): (-[NSArray performFindPanelAction:]): (-[WebTextCompleteController doCompletion]):
  • WebView/WebImageView.m:
  • WebView/WebLoader.m: (-[NSURLProtocol connection:willCacheResponse:]):
  • WebView/WebPDFRepresentation.m: (+[WebPDFRepresentation PDFDocumentClass]):
  • WebView/WebPDFView.m: (+[WebPDFView PDFKitBundle]): (+[WebPDFView PDFViewClass]): (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
  • WebView/WebTextRepresentation.m:
  • WebView/WebTextView.m:
  • WebView/WebUnarchivingState.m:
  • WebView/WebView.m:
4:48 PM Changeset in webkit [14020] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8514
Bug 8514: Web Inspector hides when the app is in the background

Makes the inspector not hide in the background. Since the inspector is a floating panel
we need to call setFloatingPanel:NO when the app is switching into the background. Then
call setFloatingPanel:YES when the app is activated again. Without this the inspector
would float above all applications.

  • WebInspector/WebInspector.m: (-[NSWindow window]): setHidesOnDeactivate:NO (-[NSWindow windowWillClose:]): de-regiser appliction active notifications (-[NSWindow showWindow:]): register for appliction active notifications (-_applicationWillResignActive): setFloatingPanel:NO (-_applicationDidBecomeActive): setFloatingPanel:YES
3:48 PM Changeset in webkit [14019] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/JavaScriptGlue

Copying the JavaScriptGlue tag to the release tag.

3:45 PM Changeset in webkit [14018] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/JavaScriptCore

Copying the JavaScriptCore tag to the release tag.

3:44 PM Changeset in webkit [14017] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/WebCore

Copying the WebCore tag to the release tag.

3:43 PM Changeset in webkit [14016] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/WebKit

Copying the WebKit tag to the release tag.

3:40 PM Changeset in webkit [14015] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.6

New release tag folder.

3:11 PM Changeset in webkit [14014] by ggaren
  • 6 edits in trunk

LayoutTests:

Reviewed by Darin.

  • Updated prototype chain expectation since DOMElement no longer exists


  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Darin.

  • Finished autogeneration of Element
  • bindings/js/kjs_dom.cpp: Removed DOMElement class
  • bindings/js/kjs_dom.h: ditto
  • bindings/scripts/CodeGeneratorJS.pm: added support for special attribute lookup that elements do
  • dom/Element.idl: added new attribute, "IncludeAttributesInPropertyLookup," which tells the code generator to include HTML element attributes in property lookup
3:01 PM Changeset in webkit [14013] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • rendering/RenderObject.h: Removed erroneous RenderObject:: prefix from a member function name.
  • rendering/RenderText.h: Removed erroneous RenderText:: prefix from a member function name.
  • platform/Arena.cpp: Added <assert.h> to list of includes.
  • platform/KURL.cpp: Ditto.
  • platform/StringImpl.cpp: Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Ditto.
2:57 PM Changeset in webkit [14012] by darin
  • 1 edit
    1 add in trunk/WebCore
  • doc: Added.
1:23 PM Changeset in webkit [14011] by ap
  • 11 edits
    5 adds in trunk/WebKitTools

Reviewed by Maciej.

Test case numbers are not compatible with iExploder 1.2.

  • Scripts/run-iexploder-tests: Print the numbers of the last five tests that were accessed.
  • iExploder/CHANGELOG.txt: Added.
  • iExploder/LICENSE.txt: Changed to a standard zlib/png license.
  • iExploder/README.txt: Added some performance hints.
  • iExploder/htdocs/config.rb: Added.
  • iExploder/htdocs/cssproperties.in:
  • iExploder/htdocs/cssvalues.in:
  • iExploder/htdocs/htmlattrs.in:
  • iExploder/htdocs/htmltags.in:
  • iExploder/htdocs/iexploder.cgi:
    • Updated to support the latest HTML & CSS tags, properties, and values from both the WebKit and Mozilla CVS tree
    • cssproperties.in cleanup
    • Modularized the code a little bit.
    • Fix subtest bug that was causing last 5 tags to be missed
    • new subtest algorithm to deal better with larger tag counts
    • default HTML_MAX_TAGS increased from 32 to 96
  • iExploder/htdocs/index.html: Updated version to 1.3.2.
  • iExploder/htdocs/webserver.rb: Added. New standalone webserver, can be used as an alternative to our run-iexploder-tests.
  • iExploder/tools/showtest.rb: Added. Similar to run-iexploder-tests --get.
  • iExploder/htdocs/iexploder.rb: Added. Used by webserver.rb.
  • iExploder/tools/osx_last_crash.rb: Find logs modified in the last two days.
1:07 PM Changeset in webkit [14010] by ap
  • 1 edit
    1 add in trunk/WebKitTools

Commit Scripts/run-mangleme-tests (missed it the previous time).

12:04 PM Changeset in webkit [14009] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Eric.

  • push down a bunch of WebCoreFrameBridge code to C++ (plus some reformatting)
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isDescendantOfFrame:]): (-[WebCoreFrameBridge traverseNextFrameStayWithin:]): (-[WebCoreFrameBridge nextFrameWithWrap:]): (-[WebCoreFrameBridge previousFrameWithWrap:]): (+[WebCoreFrameBridge bridgeForDOMDocument:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge _stringWithDocumentTypeStringAndMarkupString:]): (-[WebCoreFrameBridge nodesFromList:]): (-[WebCoreFrameBridge markupStringFromNode:nodes:]): (-[WebCoreFrameBridge markupStringFromRange:nodes:]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
  • page/Frame.cpp: (WebCore::Frame::nodeInfoAtPoint): (WebCore::Frame::hasSelection): (WebCore::Frame::documentTypeString):
  • page/Frame.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::traverseNextWithWrap): (WebCore::FrameTree::traversePreviousWithWrap): (WebCore::FrameTree::deepLastChild):
  • page/FrameTree.h:
1:01 AM Changeset in webkit [14008] by bdakin
  • 9 edits
    4 adds in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6141
DOMCSSPrimitiveValue is always returning values in pixels when
using getComputedStyle:

getFloatValue() took a unit type as a parameter, ignored it, and
returned m_value.num. This patch writes a second version of the
function that actually converts m_value.num to the specified unites
before returning it. Where a conversion is not required, I removed
the unit type from the caller so that it would go directly to the
inline version of the function.

  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValue::computeLengthFloat): Remove type parameter since a conversion is not needed. (WebCore::scaleFactorForConversion): Helper function for conversion. (WebCore::CSSPrimitiveValue::getFloatValue): This version of getFloatValue() takes a unit type parameter and converts m_value.num.
  • css/css_valueimpl.h: (WebCore::CSSPrimitiveValue::getFloatValue): This version does not take a parameter and just returns m_value.num.
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage): Remove type parameter since a conversion is not needed.
  • css/cssstyleselector.cpp: (WebCore::convertToLength): Same. (WebCore::CSSStyleSelector::applyProperty): Same. (WebCore::CSSStyleSelector::mapBackgroundSize): Same. (WebCore::CSSStyleSelector::mapBackgroundXPosition): Same. (WebCore::CSSStyleSelector::mapBackgroundYPosition): Same.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Same.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Same.
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): Same.
12:33 AM Changeset in webkit [14007] by ggaren
  • 8 edits
    6 adds in trunk

LayoutTests:

  • Layout test for whether the error event bubbles.
  • fast/events/onerror-bubbling-expected.txt: Added.
  • fast/events/onerror-bubbling.html: Added.

WebCore:

Reviewed by John.


  • dom/Document.cpp: (WebCore::Document::importNode): Throw an error if the node is null. This happens when the object provided in the JavaScript call is not a node. (WebCore::Document::adoptNode): Set the DOM exception code in all error cases instead of just a few, because that's what the spec requires.

Apr 21, 2006:

11:08 PM Changeset in webkit [14006] by adele
  • 1 edit in trunk/WebCore/ChangeLog

Fixing bug number & title in last commit.

11:06 PM Changeset in webkit [14005] by adele
  • 3 edits
    1 add in trunk

WebCore:

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
REGRESSION: Can't tab out of text field if iframe comes after it

  • manual-tests/tabbing-input-google.html: Added.

WebKit:

Reviewed by Darin.

Test: manual-tests/tabbing-input-google.html

  • WebView/WebHTMLView.m: (-[NSArray resignFirstResponder]): When resigning first responder, reset willBecomeFirstResponderForNodeFocus, so when the WebHTMLView gets focus again it knows it can start moving through the tab cycle.
10:31 PM Changeset in webkit [14004] by darin
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • kjs/operations.h:
  • kxmlcore/Assertions.cpp:
  • kxmlcore/FastMalloc.cpp: Added necessary headers to resolve compilation issues when not using precompiled headers.


  • kjs/value.h: Declare the JSCell class before friend declaration to resolve compilation issues with gcc 4.0.2.


  • kxmlcore/Platform.h: Set Unicode support to use ICU on platforms other than KDE (previously only defined for Win and Mac OS)

WebCore:

Reviewed by Darin.

  • platform/Cursor.h: Created a fallback case that typedefs PlatformCursor to void * if it isn't defined to anything else. (Useful to help get new ports initially compiling.)


  • bindings/js/kjs_window.cpp:
  • rendering/RenderTextField.cpp:
  • rendering/RenderBox.cpp: Add missing headers to resolve issues when compiling without precompiled headers.


  • rendering/RenderText.h: Declare the InlineTextBox class before friend declaration to resolve compilation issues with gcc 4.0.2.
6:29 PM Changeset in webkit [14003] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
REGRESSION: Can't tab out of text field if iframe comes after it

  • fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • fast/forms/tabbing-input-iframe-expected.png: Added.
  • fast/forms/tabbing-input-iframe-expected.txt: Added.
  • fast/forms/tabbing-input-iframe.html: Added.

WebCore:

Reviewed by Darin.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8213
REGRESSION: Can't tab out of text field if iframe comes after it

Test: fast/forms/tabbing-input-iframe.html

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): If the next focusable node is a RenderWidget without a view, then continue in the loop. We used to break out in this case. I also made some formatting changes and reorganized the function to make it easier to read.
4:59 PM Changeset in webkit [14002] by adele
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Beth.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8496
REGRESSION: Dragging to select text around a text field causes the text field to scroll.

Test: manual-tests/text-field-autoscroll.html

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): Start the frame's autoscroll timer even when we're calling over the bridge to handle the autoscroll.
  • page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Clear out pointer to layer.
1:32 PM Changeset in webkit [14001] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4476875> Support printing for embedded Netscape plugins

NOTE: This only works with the Flash plugin right now. It appears that the other
major plugins either have awful printing support, or no printing support. If someone
can find an example of any other embedded Netscape plugin printing in any browser on
the Mac, I will be happy to eat my own words!

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView drawRect:]): When printing, get the printed bitmap via -_printedPluginBitmap, and draw it into the plugin view. (-[WebBaseNetscapePluginView _printedPluginBitmap]): Call NPP_Print on the plugin to render it into a GWorld. This GWorld has the same underlying buffer as an NSBitmapImageRep, which is returned to the caller.
11:18 AM Changeset in webkit [14000] by bdakin
  • 1 edit
    13 adds in trunk/LayoutTests

Adding a few more background-size tests that include background-
origin.

10:24 AM Changeset in webkit [13999] by ggaren
  • 2 edits in trunk/WebCore
  • And again.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
10:09 AM Changeset in webkit [13998] by ggaren
  • 2 edits in trunk/WebCore
  • Futile attempt to fix Windows build.


  • WebCore.vcproj/WebCore/WebCore.vcproj:
9:29 AM Changeset in webkit [13997] by ggaren
  • 23 edits
    7 adds in trunk

LayoutTests:

Tests for global constants related to CSSRule, CSSValue, Event, and
NodeFilter objects.

  • fast/dom/constants-expected.txt: Added.
  • fast/dom/constants.html: Added.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/resources/stylesheet.css: Added.
  • fast/dom/xmlhttprequest-get-expected.txt:

WebCore:

Reviewed by Maciej.

  • Added autogeneration of JS bindings for CSSRule, CSSValue, Event, and NodeFilter.
  • Made related prototype objects hold the relevant constants, to match Mozilla and the DOM 2 spec. (Previously, only the related constructor objects held those constants, in accordance with the DOM 3 spec.)
  • Fixed up remaining Windows build issues.
  • DerivedSources.make: Added new autogenerated files
  • WebCore.xcodeproj/project.pbxproj: ditto
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::classInfo): (KJS::DOMCSSRule::getOwnPropertySlot): scope call to classInfo() because it's virtual and DOMCSSRule has a derrived class now. (KJS::DOMCSSRule::put): ditto (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_events.cpp: (KJS::toJS):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp: (KJS::OptionConstructorImp::OptionConstructorImp):
  • bindings/js/kjs_traversal.cpp: (KJS::toJS):
  • bindings/js/kjs_traversal.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): added CSSValue global object
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Changed generator to write constants to prototype objects (previously only wrote constants to constructor objects)
  • css/CSSPrimitiveValue.idl: Removed LegacyParent since CSSValue now exists in IDL
  • css/CSSRule.idl: Added.
  • css/CSSValue.idl: Added.
  • css/css_ruleimpl.h: (WebCore::CSSRule::):
  • css/css_valueimpl.h:
  • dom/Event.idl: Added.
  • dom/MutationEvent.idl: Removed LegacyParent since Event now exists in IDL
  • dom/NodeFilter.idl: Added.
  • dom/UIEvent.idl: Removed LegacyParent since event now exists in IDL
  • dom/dom2_eventsimpl.h: (WebCore::Event::):
12:57 AM Changeset in webkit [13996] by darin
  • 2 edits in trunk/WebCore
  • one more attempt to fix Windows build
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect): Update to use Color and match the similar function on GraphicsContextMac.
12:54 AM Changeset in webkit [13995] by bdakin
  • 4 edits
    74 adds
    65 deletes in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8495
REGRESSION: Sidebar on cnn.com is hosed

  • platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Use the size of the destination rect, not the oneTileRect in the no-pattern case.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): Initialize scaledWidth and scaledHeight to the appropriate value (was wrong in scroll case), adjust position at appropriate times, and take out no-repeat clause for now since we don't have enough test cases yet to be sure we won't cause massive regressions.
12:49 AM Changeset in webkit [13994] by darin
  • 7 edits in trunk/WebCore
  • attempt to fix Windows build after my last check-in
  • WebCore.vcproj/Image Viewer/ImageView.cpp: Changed calls to use the new IntRect-based API.
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): Put appropriate ifdefs around the m_platformImage initializer.
  • page/Frame.cpp: Make Frame::adjustPageHeight Mac-OS-X-only for now since it's used for printing and we don't have printing going on any other platforms yet.
  • platform/cairo/GraphicsContextCairo.cpp: Take out constructor that takes only the "for printing" boolean for now.
  • platform/cairo/ImageCairo.cpp: Include the GraphicsContext.h header.
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::setShadow): Fix up this stub and remove the GraphicsContext empty constructor stub.
12:27 AM Changeset in webkit [13993] by darin
  • 2 edits in trunk/WebCore
  • fix build
  • WebCore.xcodeproj/project.pbxproj: Replaced absolute path on my system with a build-result-relative path; also removed some source files from the list of resources to install!

Apr 20, 2006:

11:52 PM Changeset in webkit [13992] by darin
  • 63 edits
    5 adds
    1 delete in trunk/WebCore

Reviewed by Hyatt.

  • make <canvas> element and related API behave more like the draft of the WhatWG Web Application specification, checking parameter validity and raising exceptions
  • changed HTMLCanvasElement bindings to be auto-generated, fixing all issues so we can generate bindings for classes drived from HTMLElement
  • change GraphicsContext API to use IntRect/Point/Size in more cases
  • change GraphicsContext so it is closer to truly wrapping a graphics context rather than representing the current NSGraphicsContext; there are still some things like text and rectangle fills that are tied to NSGraphicsContext, but we're most of the way there
  • removed Brush class since it just amounted to a color, using an RGBA32 instead where we used to use a Brush
  • DerivedSources.make: Added JSHTMLCanvasElement.h.
  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSCanvasRenderingContext2DBase.h: Added toJS.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): Added exception code handling for strokeRect, drawImage, and createPattern. Added version of createPattern that takes a canvas. Use TYPE_MISMATCH_ERR instead of JavaScript TypeError when parameter is neither an image or canvas element. Adapt for new HTMLCanvasElement binding. (WebCore::toJS): Added. Converts context object to JS wrapper.
  • bindings/js/JSHTMLElementWrapperFactory.h: Added.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Added. Creates a JavaScript wrapper for an arbitrary HTML element. Better than putting this all in the DOM node class toJS function.
  • bindings/js/JSXMLSerializer.cpp: Tweaked to make it build.
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Changed to call the JSHTMLElementWrapperFactory function createJSWrapper, instead of always creating a JSHTMLElement.
  • bindings/js/kjs_html.h: Removed canvas-related stuff. Added HTMLElement prototype.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::classInfo): Removed canvas element. (KJS::JSHTMLElement::accessors): Ditto. (KJS::JSHTMLElementProtoFunc::callAsFunction): Added, to help the auto-binding machiner cope with HTMLElement. (KJS::HTMLElementFunction::callAsFunction): Removed canvas element.
  • bindings/scripts/CodeGeneratorJS.pm: Added types needed for HTMLCanvasElement.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setDisplaysWithFocusAttributes): Changed to create a GraphicsContext with the new constructor that takes a CGContextRef.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): Changed to create a GraphicsContext with the new constructor that takes a NSGraphicsContext.
  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight): Changed to create a GraphicsContext with the new constructor that takes a CGContextRef.
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret): Eliminated a use of obsolete class Brush.
  • html/CanvasPattern.h:
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::parseRepetitionType): Added. Parses a repetition type. Different from the old logic in that it is case-sensitive and rejects anything other than null, empty string, or the four repeat types. (WebCore::CanvasPattern::CanvasPattern): Added constructor that takes a CGImageRef. Changed constructor to take two booleans instead of the repetition type string. It's the caller's responsibility to parse the string. (WebCore::CanvasPattern::~CanvasPattern): Release the CGImage. (WebCore::patternCallback): Handle the CGImage case. Also changed the code to create a GraphicsContext as needed and call the image drawing code with that. (WebCore::CanvasPattern::createPattern): Handle both the image element case and the canvas element case.


  • html/CanvasRenderingContext2D.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): Change line cap, line join, and global composite to store enum values instead of strings. (WebCore::CanvasRenderingContext2D::setLineWidth): Do nothing if width is NaN or <= 0. (WebCore::CanvasRenderingContext2D::lineCap): Return a string based on a stored enum, rather than returning a stored string. (WebCore::CanvasRenderingContext2D::setLineCap): Do nothing if the string is not one of the standard line cap types. Also case sensitive and stores enum rather than the string. (WebCore::CanvasRenderingContext2D::lineJoin): Return a string based on a stored enum, rather than returning a stored string. (WebCore::CanvasRenderingContext2D::setLineJoin): Do nothing if the string is not one of the standard line join types. Also case sensitive and stores enum rather than the string. (WebCore::CanvasRenderingContext2D::setMiterLimit): Do nothing if limit is NaN or <= 0. (WebCore::CanvasRenderingContext2D::setGlobalAlpha): Do nothing if alpha is NaN or < 0 or > 1. (WebCore::CanvasRenderingContext2D::globalCompositeOperation): Return a string based on a stored enum, rather than returning a stored string. (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): Do nothing if the string is not one of the standard compositing modes. Also case sensitive and stores enum rather than the string. (WebCore::CanvasRenderingContext2D::arcTo): Generate INDEX_SIZE_ERR exception if radius is NaN or <= 0. (WebCore::CanvasRenderingContext2D::arc): Ditto. (WebCore::CanvasRenderingContext2D::rect): Generate INDEX_SIZE_ERR exception if width or height is NaN or <= 0. (WebCore::CanvasRenderingContext2D::clearRect): Ditto. (WebCore::CanvasRenderingContext2D::fillRect): Ditto. (WebCore::CanvasRenderingContext2D::strokeRect): Ditto, same for line width. Changed the case where the line width is not specified to share code with the case where it is. (WebCore::size): Renamed from imageSize, since C++ overloads based on parameter types anyway. (WebCore::CanvasRenderingContext2D::drawImage): Generate INDEX_SIZE_ERR exception if the source rect is not entirely inside the image rect, or if the width or height of either the source or destination rect is NaN or <= 0. Changed image drawing code to be platform-independent for the image element case, but not yet for the canvas case. (WebCore::CanvasRenderingContext2D::drawImageFromRect): Change code to parse the composite operation to use the new code shared with Image. (WebCore::CanvasRenderingContext2D::createPattern): Added code to parse the repetition type separately before creating the pattern. Added an overload for canvas elements. (WebCore::CanvasRenderingContext2D::drawingContext): Changed to return a GraphicsContext*. (WebCore::CanvasRenderingContext2D::platformContext): Added. Now does what drawingContext used to do.
  • html/CanvasRenderingContext2D.idl: Added exception declarations as needed for changes above.
  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Changed m_drawingContext to be a GraphicsContext instead of a CGContextRef. (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Ditto. (WebCore::HTMLCanvasElement::getContext): Removed special cases for null and empty string. Only give a 2D graphics context if the string is "2d". (WebCore::HTMLCanvasElement::reset): Updated for change to GraphicsContext from CGContextRef. (WebCore::HTMLCanvasElement::paint): Ditto. (WebCore::HTMLCanvasElement::createDrawingContext): Changed to create a GraphicsContext* instead of a CGContextRef. (WebCore::HTMLCanvasElement::drawingContext): Changed to return a GraphicsContext* instead of a CGContextRef. (WebCore::HTMLCanvasElement::createPlatformImage): Updated for changes above.
  • html/HTMLCanvasElement.idl: Added.
  • html/HTMLParser.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::canvasCreateErrorCheck): Added. An attempt to implement the fallback behavior for canvas elements when JavaScript is off. (WebCore::HTMLParser::getNode): Sorted list of functions. Added case for canvas.
  • html/html_imageimpl.h:
  • html/html_imageimpl.cpp: (WebCore::HTMLImageElement::HTMLImageElement): Changed m_compositeOperator to be an enum instead of a string. (WebCore::HTMLImageElement::parseMappedAttribute): Parse the enum here.
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): Changed to take a GraphicsContext parameter.
  • kcanvas/RenderPath.h: Added GraphicsContext parameter to drawMarkersIfNeeded.
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Changed to generate and use an appropriate GraphicsContext.
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Added GraphicsContext parameter to drawMarkersIfNeeded.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::DrawMarkersData::DrawMarkersData): Added GraphicsContext*. (WebCore::drawMarkerWithData): Pass along a GraphicsContext*. (WebCore::drawStartAndMidMarkers): Ditto. (WebCore::KCanvasItemQuartz::drawMarkersIfNeeded): Pass a long a GraphicsContext*.
  • kcanvas/device/KRenderingDevice.h: Added a pure virtual createGraphicsContext to bridge back to a GraphicsContext. Long term that class will replace this one.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::createGraphicsContext): Added.
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Create and pass a GraphicsContext -- old code used the default constructor for GraphicsContext which meant "current context", and that no longer exists.
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): Ditto.
  • platform/Brush.h: Removed.
  • platform/CompositeOperator.h: Added.
  • platform/CompositeOperator.cpp: Added.
  • platform/Font.h: Changed calls to use IntPoint instead of pairs of ints. Also removed the const from all the uses of GraphicsContext*.
  • platform/GraphicsContext.h: Eliminated default constructor and constructor that takes only a boolean. Replaced with constructors that take platform graphics contexts only. Replaced brush-related calls with fill color calls. Replaced use of Brush with use of Color. Changed Image::CompositeOperator to just plain CompositeOperator. Changed tuples of ints into IntRect and IntPoint. Moved setFocusRingClip and clearFocusRingClip out of ifdefs. Removed unused getCompositeOperation and string-based setCompositeOperation. Moved currentCGContext and the other setCompositeOperation out of the GraphicsContext class and made them global functions. Fixed platformContext so it won't always return the CGContextRef of the current NSGraphicsContext. Instead, it will return the appropriate CGContextRef for the GraphicsContext. This eliminates the need to use void* for the image-drawing functions.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): Replaced Brush with an RGBA fill color. (WebCore::GraphicsContext::setFillColor): Renamed from setBrush. (WebCore::GraphicsContext::fillColor): Renamed from brush. (WebCore::GraphicsContext::drawImage): Changed to use IntRect. (WebCore::GraphicsContext::drawTiledImage): Moved here from GraphicsContextMac.mm. (WebCore::GraphicsContext::drawText): Changed to use IntPoint. (WebCore::GraphicsContext::drawHighlightForText): Ditto. (WebCore::GraphicsContext::drawLineForText): Ditto. (WebCore::GraphicsContext::drawLineForMisspelling): Ditto.
  • platform/Image.h: Removed CompositeOperator and related functions. Removed void* context parameters from draw functions.
  • platform/Image.cpp: Removed compositeOperatorFromString.
  • platform/Widget.h: Added a GraphicsContext* return value from lockDrawingFocus that you pass back to unlockDrawingFocus (for deletion).
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText): Changed parameter to point and removed const on GraphicsContext* parameter. (WebCore::Font::drawText): Ditto. (WebCore::Font::drawHighlightForText): Ditto. (WebCore::Font::drawLineForText): Ditto. (WebCore::Font::drawLineForMisspelling): Ditto. (WebCore::Font::misspellingLineThickness): Removed const.
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Added fields to store a CGContextRef and an NSGraphicsContext. (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): Release both the CGContextRef and the NSGraphicsContext. (WebCore::GraphicsContext::GraphicsContext): Implement to set up both the CGContextRef and the NSGraphicsContext in one case, and only the CGContextRef in the other. (WebCore::GraphicsContext::savePlatformState): Implement for the CGContext-only case. (WebCore::GraphicsContext::restorePlatformState): Ditto. (WebCore::GraphicsContext::drawRect): Assert that the NS context is present and (WebCore::GraphicsContext::setColorFromFillColor): Renamed from setColorFromBrush. (WebCore::GraphicsContext::setColorFromPen): Added assertion. (WebCore::GraphicsContext::drawLine): Added assertion. (WebCore::GraphicsContext::drawEllipse): Get CGContext from the platformContext function instead of currentCGContext, and changed to use fillColor. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::setCompositeOperation): Changed to global function and also changed to do the work here -- no need to use WebCoreImageRendererFactory. (WebCore::GraphicsContext::drawImage): Move most of this into GraphicsContext.cpp. Remove the void* context parameter. Changed to take rects instead of separate coordinates. (WebCore::GraphicsContext::fillRect): Changed to take color instead of Brush. (WebCore::GraphicsContext::addClip): Added assertion. (WebCore::GraphicsContext::addRoundedRectClip): Get CGContextRef from the platformContext function instead of currentCGContext. (WebCore::GraphicsContext::createRenderingDeviceContext): Ditto. (WebCore::GraphicsContext::beginTransparencyLayer): Ditto. (WebCore::GraphicsContext::endTransparencyLayer): Ditto. (WebCore::GraphicsContext::setShadow): Change to take size instead of x,y. Also get CGCOntextRef from the platformContext function instead of currentCGContext. (WebCore::GraphicsContext::clearShadow): Get CGContextRef from the platformContext function instead of currentCGContext. (WebCore::GraphicsContext::platformContext): Added. Returns m_data->m_cgContext.
  • platform/mac/ImageMac.mm: (WebCore::fillSolidColorInRect): Updated for change in CompositeOperator type. (WebCore::Image::checkForSolidColor): Ditto. (WebCore::Image::draw): Removed void* context parameter and replaced it with a GraphicsContext* parameter. Renamed from drawInRect. (WebCore::Image::drawTiled): Ditto. Renamed from tileInRect and scaleAndTileInRect.
  • platform/mac/PDFDocumentImage.h: Updated for change in CompositeOperator type.
  • platform/mac/PDFDocumentImage.mm: (WebCore::PDFDocumentImage::draw): Ditto.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::lockDrawingFocus): Changed to return a GraphicsContext*. (WebCore::Widget::unlockDrawingFocus): Changed to take a GraphicsContext*.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Changed to pass IntPoint. (WebCore::InlineTextBox::paint): Changed to pass IntSize. (WebCore::InlineTextBox::paintSelection): More of the same. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintDecoration): Ditto. (WebCore::InlineTextBox::paintSpellingMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::paintMarkedTextUnderline): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): Ditto. (WebCore::RenderBlock::fillVerticalSelectionGap): Ditto. (WebCore::RenderBlock::fillLeftSelectionGap): Ditto. (WebCore::RenderBlock::fillRightSelectionGap): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): Ditto. (WebCore::RenderBox::outlineBox): Ditto.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::setClip): Take out ifdefs. We'll do that inside GraphicsContext instead. (WebCore::restoreClip): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder): More of the same. (WebCore::RenderObject::paintBorderImage): Ditto.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations): Ditto. (WebCore::EllipsisBox::paint): Ditto.
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): Ditto.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Set up a graphics context by calling lockDrawingFocus. Also changed a color here to be a constant.
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawImage): Update for parameter type changes. (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip):
  • platform/cairo/ImageCairo.cpp: (WebCore::setCompositingOperation): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
10:56 PM Changeset in webkit [13991] by adele
  • 5 edits in trunk/LayoutTests

Updated test results for:

a file: URL being pasted instead of just the file name

  • editing/pasteboard/drop-text-without-selection-expected.txt:
  • fast/forms/input-paste-undo-expected.txt:
  • fast/forms/input-truncate-newline-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
9:51 PM Changeset in webkit [13990] by adele
  • 5 edits
    7 adds in trunk

WebCore:

Reviewed by Darin.

WebCore part of:

a file: URL being pasted instead of just the file name

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isDragCaretRichlyEditable]): Added.
  • manual-tests/plain-text-paste.html: Added.
  • manual-tests/resources/plain-text-paste: Added.
  • manual-tests/resources/plain-text-paste/1.textClipping: Added.
  • manual-tests/resources/plain-text-paste/2.textClipping: Added.
  • manual-tests/resources/plain-text-paste/3.gif: Added.
  • manual-tests/resources/plain-text-paste/4.txt: Added.
  • manual-tests/resources/plain-text-paste/5.webloc: Added.

WebKit:

Reviewed by Darin.

WebKit part of:

a file: URL being pasted instead of just the file name

  • WebView/WebHTMLView.m: (-[WebHTMLView _plainTextFromPasteboard:]): Added method that tries to copy AppKit text fields' logic for extracting plain text from the pasteboard. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added helper method. (-[WebHTMLView _shouldInsertText:replacingDOMRange:givenAction:]): (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]): (-[WebHTMLView readSelectionFromPasteboard:]): Paste as plain text if rich text is not allowed. (-[WebHTMLView validateUserInterfaceItem:]): Changed to not allow pasteAsRichText: if the paste is not going to be handled by the DOM and the selection does not allow pasting rich text. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Paste as plain text if rich text is not allowed. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView pasteAsPlainText:]):
9:32 PM Changeset in webkit [13989] by darin
  • 13 edits
    4 adds
    4 deletes in trunk

WebCore:

Reviewed by Adele.

  • platform/mac/WebCoreGraphicsBridge.h: Removed.
  • platform/mac/WebCoreGraphicsBridge.m: Removed.
  • platform/mac/WebCoreSystemInterface.h: Added.
  • platform/mac/WebCoreSystemInterface.mm: Added.
  • WebCore.exp: Add new SystemInterface globals, remove WebCoreGraphicsBridge.
  • WebCore.xcodeproj/project.pbxproj: Updated for removed and added files. Sorted files.
  • bridge/mac/FrameMac.mm: Removed unneeded include of WebCoreGraphicsBridge.h.
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): Moved code from WebGraphicsBridge here, using WebCoreSystemInterface so we can call wkSetDragImage.
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing): Moved code from WebGraphicsBridge here, using WebCoreSystemInterface so we can call wkDrawFocusRing.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): Call wkDrawBezeledTextFieldCell from WebCoreSystemInterface instead of using WebGraphicsBridge to do the same thing.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebGraphicsBridge.h: Removed.
  • WebCoreSupport/WebGraphicsBridge.m: Removed.
  • WebCoreSupport/WebSystemInterface.h: Added.
  • WebCoreSupport/WebSystemInterface.m: Added.
  • WebKit.xcodeproj/project.pbxproj: Updated for removed and added files.
  • WebCoreSupport/WebImageData.m: Removed unneeded include of WebGraphicsBridge.h.
  • WebCoreSupport/WebImageRenderer.m: Ditto.
  • WebCoreSupport/WebTextRenderer.m: Ditto.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Guarded all the one-time initialization inside a boolean, just in case some things take a little time. Added a call to InitWebCoreSystemInterface to the one-time initialization here. Later, we will need to add it in some other places if we call code that requires the use of WebCoreSystemInterface functions from anywhere that can be invoked before creations of the first WebFrameView, but for now there is no need.
3:22 PM Changeset in webkit [13988] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

  • fast/forms/input-readonly-empty-expected.checksum: Added.
  • fast/forms/input-readonly-empty-expected.png: Added.
  • fast/forms/input-readonly-empty-expected.txt: Added.
  • fast/forms/input-readonly-empty.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

Test: fast/forms/input-readonly-empty.html

  • rendering/RenderBlock.h: Added hasLineIfEmpty.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Added. Checks for rootEditableElement as well as a shadowNode who has an input element as a parent. (WebCore::RenderBlock::getBaselineOfLastLineBox): Calls hasLineIfEmpty instead of just checking for the rootEditableElement.
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): ditto.
12:08 PM Changeset in webkit [13987] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Removed TO_NODE_OFFSET and TO_NODE_ADDRESS macros. These can just be done inline with pointer math.

  • platform/DeprecatedString.cpp: (allocateNode): (freeHandle):

Apr 19, 2006:

11:31 PM Changeset in webkit [13986] by adele
  • 2 edits in trunk/LayoutTests

Updated test to use webkit-block-placeholder instead of khtml-block-placeholder.

  • editing/inserting/insert-div-010.html:
11:05 PM Changeset in webkit [13985] by adele
  • 4 edits in trunk/LayoutTests

Updating test results that were incorrectly checked in
when many of the table test results changed recently due to Color
improvements.

  • tables/mozilla/bugs/bug625-expected.checksum:
  • tables/mozilla/bugs/bug625-expected.png:
  • tables/mozilla/bugs/bug625-expected.txt:
10:22 PM Changeset in webkit [13984] by adele
  • 4 edits in trunk/LayoutTests

Updated results after rolling out optimizations in setInnerText and setInnerHTML.

  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/text/attributed-substring-from-range-expected.txt:
8:01 PM Changeset in webkit [13983] by adele
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin.

Removed optimizations recently added in setInnerHTML and setInnerText. The setInnerHTML change broke a first-letter style test.
The setInnerText change caused an empty text node to get added when setting inner text to an empty string. The bug that this
change went in with remains fixed.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): (WebCore::HTMLElement::setInnerText):
7:51 PM Changeset in webkit [13982] by thatcher
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Haytt.

  • manual-tests/repaint-resized-overflow.html: Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::computeRepaintRects): Set the m_repaintOverflowOnResize flag to true if our object itself needs layout or if we're an overflow and have a normal child that needs layout, in which case if we end up resizing it will be because of the child, and that child might have not repainted itself correctly during its own layout. (WebCore::RenderLayer::updateLayerPositions): Do a full repaint if m_repaintOverflowOnResize is set and we resized but didn't move.
  • rendering/RenderLayer.h:
7:33 PM Changeset in webkit [13981] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/dynamic-shadow.html: Added.
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow changes.
7:18 PM Changeset in webkit [13980] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8442
Bug 8442: improvements to Cocoa bindings support in WebView - code simplification

Removes the WebController class added earlier; changes NSTreeController and
WebView to together without it. Now you can just bind the contentObject binding
of the tree controller directly to the mainFrameDocument key of the WebView.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebView/WebDataSource.m: (-[WebDataSource _setTitle:]):
  • WebView/WebFrame.m: (-[WebFrame _closeOldDataSources]):
  • WebView/WebView.m: (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setMainFrameDocumentReady:]): (-[WebView mainFrameDocument]):
  • WebView/WebViewPrivate.h:
7:07 PM Changeset in webkit [13979] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Fix the change log for my last commit, change was done by James G. Speth <​speth@end.com>.

7:06 PM Changeset in webkit [13978] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6635
Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost

Stop observing window will close notifications before we tell the highlight window to close,
this prevents the crash. Also prevent drawing highlights for hidden tabs.

  • WebInspector/WebInspector.m: (-_highlightNode:):
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight expire]):
7:04 PM Changeset in webkit [13977] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Added readOnly methods for HTMLInputElement and HTMLTextAreaElement so the DOM bindings can call
a method with the same name. This will make it easier to autogenerate the DOM bindings in the future.


  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::readOnly): Added. Calls isReadOnlyControl.
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::readOnly): ditto.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::inputGetter): Calls readOnly instead of isReadOnlyControl. (KJS::JSHTMLElement::textAreaGetter): ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement readOnly]): ditto. (-[DOMHTMLTextAreaElement readOnly]): Calls readOnly instead of getting the attribute directly. (-[DOMHTMLTextAreaElement setReadOnly:]): Calls setReadOnly instead of setting the attribute directly.
6:44 PM Changeset in webkit [13976] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6637
Bug 6637: selecting node in Inspector after closing window crashes Safari

When the window the Web Inspector was inspecting is closed, the inspector goes into its
no-selection state. Choosing to inspect another element activates it again. The inspector
will also follow the WebView if the URL changes and select the root element on the new page.

6:03 PM Changeset in webkit [13975] by adele
  • 43 edits in trunk

LayoutTests:

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
REGRESSION: Input element extends outside of DIV element at ​http://www.macdock.com/

  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/3690719-expected.png:
  • editing/selection/3690719-expected.txt:
  • fast/forms/input-appearance-minWidth-expected.checksum:
  • fast/forms/input-appearance-minWidth-expected.png:
  • fast/forms/input-appearance-minWidth-expected.txt:
  • fast/forms/input-appearance-width-expected.checksum:
  • fast/forms/input-appearance-width-expected.png:
  • fast/forms/input-appearance-width-expected.txt:
  • fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.checksum:
  • tables/mozilla/bugs/bug1188-expected.png:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug12384-expected.checksum:
  • tables/mozilla/bugs/bug12384-expected.png:
  • tables/mozilla/bugs/bug12384-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.checksum:
  • tables/mozilla/bugs/bug18359-expected.png:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug55545-expected.checksum:
  • tables/mozilla/bugs/bug55545-expected.png:
  • tables/mozilla/bugs/bug55545-expected.txt:
  • tables/mozilla/bugs/bug7342-expected.checksum:
  • tables/mozilla/bugs/bug7342-expected.png:
  • tables/mozilla/bugs/bug7342-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
REGRESSION: Input element extends outside of DIV element at ​http://www.macdock.com/

  • platform/Font.h: Added runRounding parameter to floatWidth.
  • platform/mac/FontMac.mm: (WebCore::Font::floatWidth): ditto.
  • platform/win/FontWin.cpp: (WebCore::Font::floatWidth): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth): Use new floatWidth parameter to turn off run rounding.
3:40 PM Changeset in webkit [13974] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Fix for Windows build.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): Use isReadOnlyControl instead of isReadOnly.
3:21 PM Changeset in webkit [13973] by adele
  • 27 edits
    4 adds in trunk

LayoutTests:

Tests for change to make readonly text fields have dimmed borders.

  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.png:
  • fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • fast/forms/input-readonly-dimmed-expected.png: Added.
  • fast/forms/input-readonly-dimmed-expected.txt: Added.
  • fast/forms/input-readonly-dimmed.html: Added.

WebCore:

2006-04-19 Adele Peterson <​adele@apple.com>


Reviewed by Beth.


Fix to make readonly text fields have dimmed borders to match AppKit behavior.


Test: fast/forms/input-readonly-dimmed.html


  • dom/Node.h: (WebCore::Node::isReadOnlyControl): Changed from const version of isReadOnly.
  • dom/Node.cpp: (WebCore::Node::isReadOnlyNode): Changed from isReadOnly. (WebCore::Node::setNodeValue): Uses isReadOnlyNode instead of isReadOnly. (WebCore::Node::checkSetPrefix): ditto. (WebCore::Node::checkAddChild): ditto.
  • dom/Attr.cpp: (WebCore::Attr::setValue): ditto.
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): ditto. (WebCore::CharacterData::appendData): ditto. (WebCore::CharacterData::checkCharDataOperation): ditto.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): ditto.
  • dom/Element.cpp: (WebCore::Element::setAttribute): ditto.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): ditto. (WebCore::NamedAttrMap::removeNamedItem): ditto.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::isReadOnlyNode): ditto.
  • dom/NamedNodeMap.h: (WebCore::NamedNodeMap::isReadOnlyNode): ditto.
  • dom/Range.cpp: (WebCore::Range::checkDeleteExtract): ditto. (WebCore::Range::containedByReadOnly): ditto.
  • dom/Text.cpp: (WebCore::Text::splitText): ditto.
  • dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstruction::setData): ditto.


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::inputGetter): Uses isReadOnlyControl instead of isReadOnly. (KJS::JSHTMLElement::textAreaGetter): ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement readOnly]): ditto.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::updateFromElement): ditto. (WebCore::RenderTextArea::updateFromElement): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): ditto. (WebCore::RenderTextField::updateFromElement): ditto.


  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::parseMappedAttribute): When readonly attribute changes, update the theme so the control will repaint.
  • html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::isReadOnlyControl): Renamed from readOnly.
  • html/HTMLInputElement.h: Removed isReadOnly, since isReadOnlyControl now exists on HTMLGenericFormElement.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isReadOnlyControl): Renamed from isReadOnly.
  • rendering/RenderTheme.h: (WebCore::): Added ReadOnlyState to ControlState enum.
  • rendering/RenderThemeMac.h: Removed NSTextFieldCell since it was only being used to store the enabled state. Removed setTextFieldState since it was updating the enabled state of the cell, which is only used in one place.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): No longer initialized the NSTextFieldCell. (WebCore::RenderThemeMac::adjustRepaintRect): No longer calls setTextFieldState. (WebCore::RenderThemeMac::paintTextField): Uses the enabled state and the readonly state to determine whether to draw a dimmed version of the aqua border.
12:35 PM Changeset in webkit [13972] by bdakin
  • 2 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8467 Block
with percentage background-size doesn't repaint properly when it
grows

  • manual-tests/backgroundSizeRepaint.html: Added.
  • manual-tests/resources/apple.jpg: Added.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): We must return true if we have a percentage background-size.
11:47 AM Changeset in webkit [13971] by hyatt
  • 2 edits in trunk/WebCore

Fix for a regression in the new text fields. Don't allow the repaint
rect created by dynamic line layout changes to spill out of an overflow
area's clip region.

(There is no test, since we have no way of testing cases where we repaint

too much rather than too little.)

Reviewed by darin

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
11:17 AM Changeset in webkit [13970] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Fix for bug 8449, incomplete repaint of table cell that moved. This
fix also solves some of the textfield repainting problems (e.g., on
google.com and lxr.mozilla.org).

Reviewed by hyatt

  • manual-tests/table-cell-move.html: Added.
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::repaintViewRectangle):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
9:45 AM Changeset in webkit [13969] by ap
  • 3 edits
    2 adds in trunk

Fix by Mitz Pettel, reviewed by Eric.

Test: fast/css/dashboard-regions-attr-crash.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseDashboardRegions): Added null check for args.
4:03 AM Changeset in webkit [13968] by eseidel
  • 7 edits in trunk/WebCore

2006-04-18 Rob Buis <​buis@kde.org>

Reviewed by eseidel & darin. Landed by eseidel.

No automated tests possible (from javascript).

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6664:
Inspector does not highlight SVG elements properly

Make sure RenderObject::absoluteBoundingBoxRect works for
svg specific render objects by overriding absoluteRects.
This fixes highlighting in the Inspector of svg shapes, paths,
images and text.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::absoluteRects):
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::absoluteRects):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects):
  • kcanvas/RenderSVGText.h:
3:57 AM Changeset in webkit [13967] by eseidel
  • 8 edits
    6 adds in trunk

2006-04-17 Rob Buis <​buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Test: svg/custom/tref-update.svg

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6427:
<tref> element not implemented

Implementation of <tref> element.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGTRefElement.cpp: Added. (SVGTRefElement::SVGTRefElement): (SVGTRefElement::~SVGTRefElement): (SVGTRefElement::parseMappedAttribute): (SVGTRefElement::closeRenderer): (SVGTRefElement::childShouldCreateRenderer): (SVGTRefElement::createRenderer):
  • ksvg2/svg/SVGTRefElement.h: Added. (WebCore::SVGTRefElement::rendererIsNeeded):
  • ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::childShouldCreateRenderer):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer):
  • ksvg2/svg/svgtags.in:

Apr 18, 2006:

7:03 PM Changeset in webkit [13966] by darin
  • 2 edits in trunk/WebKitTools
  • attempt to fix Windows buildbot
  • Scripts/install-win-extras: Temporarily changed URLs to fr.rpmfind.net. We need a better long-term solution for this.
5:56 PM Changeset in webkit [13965] by darin
  • 2 edits in trunk/WebKit

Reviewed by Beth.

  • WebInspector/webInspector/inspector.css: Add "-webkit-" prefixes to the border radius properties to make the corners rounded again.
5:51 PM Changeset in webkit [13964] by darin
  • 7 edits in trunk/LayoutTests

Reviewed by Beth.

  • updated some results that were affected by recent changes

There are some other failures that might be reflecting actual
bugs; these seem fine though.

  • fast/events/updateLayoutForHitTest-expected.checksum:
  • fast/events/updateLayoutForHitTest-expected.png:
  • fast/events/updateLayoutForHitTest-expected.txt: Updated because the 4 clicks done in this test now seem to be behaving as a triple-click and selecting some text.
  • fast/forms/input-appearance-maxlength-expected.txt:
  • fast/forms/input-paste-undo-expected.txt:
  • fast/text/attributed-substring-from-range-expected.txt: Unimportant changes to the editing delegate calls.
5:16 PM Changeset in webkit [13963] by darin
  • 2 edits in trunk/WebCore
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): Roll out accidentally-landed change for bug 8398.
4:47 PM Changeset in webkit [13962] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for a leak exposed by background-size and detected by the
layout tests.

  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValue::cleanup): We must deref pairs.
4:10 PM Changeset in webkit [13961] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Build fix for Windows. Just a few typos from background-size patch.

3:17 PM Changeset in webkit [13960] by eseidel
  • 5 edits
    3 adds in trunk

2006-04-18 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix "new Function()" to correctly use lexical scoping.
Add ScopeChain::print() function for debugging.
<rdar://problem/4067864> REGRESSION (125-407): JavaScript failure on PeopleSoft REN Server

  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
  • kjs/scope_chain.h:
3:06 PM Changeset in webkit [13959] by bdakin
  • 19 edits
    65 adds in trunk

Reviewed by Hyatt.

Implementation of CSS3 background-size property. See
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8353 for details.

2:56 PM Changeset in webkit [13958] by jdevalk
  • 2 edits
    6 adds in trunk/WebKitSite

Added webkit detection scripts and info on how to use them.

11:14 AM Changeset in webkit [13957] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/pasteboard/merge-end-3-expected.checksum: Added.
  • editing/pasteboard/merge-end-3-expected.png: Added.
  • editing/pasteboard/merge-end-3-expected.txt: Added.
  • editing/pasteboard/merge-end-3.html: Added.

WebCore:

Reviewed by harrison

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): The placeholder that's inserted to keep content from collapsing due to pruning was inserted at the position after the moved paragraph. That's only appropriate when moving the paragraph backward into the previous paragraph.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): The last paragraph of the incoming fragment should be merged with the paragraph after the end of the selection being pasted into even if the incoming fragment has only one block. This fixes a bug and gets rid of a use of the info gathered during the test insertion.
9:43 AM Changeset in webkit [13956] by adele
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Use white-space:pre for the inner div to avoid collapsing spaces in the text field.

LayoutTests:

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

  • fast/forms/input-spaces-expected.checksum: Added.
  • fast/forms/input-spaces-expected.png: Added.
  • fast/forms/input-spaces-expected.txt: Added.
  • fast/forms/input-spaces.html: Added.
9:37 AM Changeset in webkit [13955] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • manual-tests/applet-param-no-name.html: Added.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary): Skip param elements with empty name.
9:30 AM Changeset in webkit [13954] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix bug number in log message.

9:28 AM Changeset in webkit [13953] by darin
  • 2 edits
    2 adds in trunk/LayoutTests

Reviewed by Geoff.


  • fast/block/float/014.html: Use local image
  • fast/block/float/resources: Added.
  • fast/block/float/resources/training_thumb.jpg: Added.
9:07 AM Changeset in webkit [13952] by darin
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::setColor): Update for changes to getRGBA.

Apr 17, 2006:

10:12 PM Changeset in webkit [13951] by ap
  • 1 edit in trunk/WebKitTools/ChangeLog

Corrected run-iexploder-tests description in the ChangeLog.

10:01 PM Changeset in webkit [13950] by ap
  • 1 edit
    6 adds in trunk/WebKitTools

Reviewed by Darin.

Works in a similar way to run-iexploder-tests.

  • Scripts/run-mangleme-tests: Added.
  • mangleme: Added.
  • mangleme/Makefile: Added.
  • mangleme/README: Added.
  • mangleme/mangle.cgi.c: Added.
  • mangleme/remangle.cgi.c: Added.
  • mangleme/tags.h: Added.
9:54 PM Changeset in webkit [13949] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/parser/number-sign-in-map-name.html

  • html/html_imageimpl.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): Fixed handling of names starting with a '#'.
8:55 PM Changeset in webkit [13948] by adele
  • 12 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:54 PM Changeset in webkit [13947] by adele
  • 98 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:53 PM Changeset in webkit [13946] by adele
  • 44 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:53 PM Changeset in webkit [13945] by adele
  • 20 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:53 PM Changeset in webkit [13944] by adele
  • 46 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:52 PM Changeset in webkit [13943] by adele
  • 44 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:52 PM Changeset in webkit [13942] by adele
  • 90 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:51 PM Changeset in webkit [13941] by adele
  • 162 edits in trunk/LayoutTests/tables/mozilla/marvin

more updated layout tests

8:46 PM Changeset in webkit [13940] by adele
  • 48 edits in trunk/LayoutTests/tables/mozilla/marvin

More updated layout tests

8:37 PM Changeset in webkit [13939] by adele
  • 2 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:36 PM Changeset in webkit [13938] by adele
  • 22 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:36 PM Changeset in webkit [13937] by adele
  • 16 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:36 PM Changeset in webkit [13936] by adele
  • 18 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:36 PM Changeset in webkit [13935] by adele
  • 31 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:36 PM Changeset in webkit [13934] by adele
  • 42 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:35 PM Changeset in webkit [13933] by adele
  • 66 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:35 PM Changeset in webkit [13932] by adele
  • 46 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:34 PM Changeset in webkit [13931] by adele
  • 80 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:33 PM Changeset in webkit [13930] by adele
  • 138 edits in trunk/LayoutTests/tables/mozilla/bugs

More updated tests

8:22 PM Changeset in webkit [13929] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8269
REGRESSION: disabled text field does not display greyed-out text

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): For disabled text fields, lighten or darken text color based on background color. Tries to get as close as possible to logic in AppKit for old text fields.
  • platform/Color.h: Removed hsv and setHsv since they were just used within Color.cpp.
  • platform/Color.cpp: (WebCore::parseHexColor): Cleanup. (WebCore::differenceSquared): Added. Returns the difference squared of two colors. (WebCore::convertRGBToHSV): Added static function. Replaces hsv and setHSV, and fixes bug in old implementation of the algorithm. (WebCore::convertHSVToRGB): ditto. (WebCore::Color::light): No longer takes in a factor, since all callers use the same factor. Uses new conversion functions. (WebCore::Color::dark): ditto.
  • rendering/InlineTextBox.cpp: Removed simpleDifferenceBetweenColors. (WebCore::correctedTextColor): Uses differenceSquared instead of simpleDifferenceBetweenColors.
8:20 PM Changeset in webkit [13928] by adele
  • 102 edits in trunk/LayoutTests/tables/mozilla_expected_failures

More updated layout tests

8:19 PM Changeset in webkit [13927] by adele
  • 12 edits in trunk/LayoutTests/tables/mozilla_expected_failures/dom

More updated layout tests

8:19 PM Changeset in webkit [13926] by adele
  • 14 edits in trunk/LayoutTests/tables/mozilla_expected_failures

More updated layout tests

8:18 PM Changeset in webkit [13925] by adele
  • 114 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

More updated layout tests

8:17 PM Changeset in webkit [13924] by adele
  • 20 edits in trunk/LayoutTests/tables/mozilla/other

More updated layout tests

8:14 PM Changeset in webkit [13923] by adele
  • 112 edits in trunk/LayoutTests/tables/mozilla

More updated layout tests

8:07 PM Changeset in webkit [13922] by adele
  • 128 edits in trunk/LayoutTests/fast

More updated layout tests

8:06 PM Changeset in webkit [13921] by adele
  • 14 edits in trunk/LayoutTests/fast

More updated layout tests

8:05 PM Changeset in webkit [13920] by adele
  • 31 edits
    4 adds in trunk/LayoutTests/fast

More updated layout tests

8:04 PM Changeset in webkit [13919] by adele
  • 26 edits in trunk/LayoutTests/fast

More updated layout tests

8:04 PM Changeset in webkit [13918] by adele
  • 20 edits in trunk/LayoutTests/fast/block

More updated layout tests

8:03 PM Changeset in webkit [13917] by adele
  • 24 edits in trunk/LayoutTests/css1

More updated layout tests

8:02 PM Changeset in webkit [13916] by adele
  • 34 edits in trunk/LayoutTests/css1

More updated layout tests

8:02 PM Changeset in webkit [13915] by adele
  • 26 edits in trunk/LayoutTests/css1

More updated layout tests

8:01 PM Changeset in webkit [13914] by adele
  • 122 edits in trunk/LayoutTests/css1

More updated layout tests

7:57 PM Changeset in webkit [13913] by adele
  • 40 edits in trunk/LayoutTests/editing

More updated layout tests

7:56 PM Changeset in webkit [13912] by adele
  • 15 edits in trunk/LayoutTests

Test and updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8269
REGRESSION: disabled text field does not display greyed-out text

  • fast/forms/input-disabled-color-expected.checksum: Added.
  • fast/forms/input-disabled-color-expected.png: Added.
  • fast/forms/input-disabled-color-expected.txt: Added.
  • fast/forms/input-disabled-color.html: Added.

This code change affects the color of table borders and inset, outset, and groove borders which affects many tests.

  • css1/basic/class_as_selector-expected.checksum:
  • css1/basic/class_as_selector-expected.png:
  • css1/basic/comments-expected.checksum:
  • css1/basic/comments-expected.png:
  • css1/basic/containment-expected.checksum:
  • css1/basic/containment-expected.png:
  • css1/basic/contextual_selectors-expected.checksum:
  • css1/basic/contextual_selectors-expected.png:
  • css1/basic/grouping-expected.checksum:
  • css1/basic/grouping-expected.png:
  • css1/basic/id_as_selector-expected.checksum:
  • css1/basic/id_as_selector-expected.png:
  • css1/basic/inheritance-expected.checksum:
  • css1/basic/inheritance-expected.png:
  • css1/box_properties/border-expected.checksum:
  • css1/box_properties/border-expected.png:
  • css1/box_properties/border_bottom-expected.checksum:
  • css1/box_properties/border_bottom-expected.png:
  • css1/box_properties/border_bottom_inline-expected.checksum:
  • css1/box_properties/border_bottom_inline-expected.png:
  • css1/box_properties/border_bottom_width-expected.checksum:
  • css1/box_properties/border_bottom_width-expected.png:
  • css1/box_properties/border_bottom_width_inline-expected.checksum:
  • css1/box_properties/border_bottom_width_inline-expected.png:
  • css1/box_properties/border_color-expected.checksum:
  • css1/box_properties/border_color-expected.png:
  • css1/box_properties/border_color_inline-expected.checksum:
  • css1/box_properties/border_color_inline-expected.png:
  • css1/box_properties/border_inline-expected.checksum:
  • css1/box_properties/border_inline-expected.png:
  • css1/box_properties/border_left-expected.checksum:
  • css1/box_properties/border_left-expected.png:
  • css1/box_properties/border_left_inline-expected.checksum:
  • css1/box_properties/border_left_inline-expected.png:
  • css1/box_properties/border_left_width-expected.checksum:
  • css1/box_properties/border_left_width-expected.png:
  • css1/box_properties/border_left_width_inline-expected.checksum:
  • css1/box_properties/border_left_width_inline-expected.png:
  • css1/box_properties/border_right-expected.checksum:
  • css1/box_properties/border_right-expected.png:
  • css1/box_properties/border_right_inline-expected.checksum:
  • css1/box_properties/border_right_inline-expected.png:
  • css1/box_properties/border_right_width-expected.checksum:
  • css1/box_properties/border_right_width-expected.png:
  • css1/box_properties/border_right_width_inline-expected.checksum:
  • css1/box_properties/border_right_width_inline-expected.png:
  • css1/box_properties/border_style-expected.checksum:
  • css1/box_properties/border_style-expected.png:
  • css1/box_properties/border_style_inline-expected.checksum:
  • css1/box_properties/border_style_inline-expected.png:
  • css1/box_properties/border_top-expected.checksum:
  • css1/box_properties/border_top-expected.png:
  • css1/box_properties/border_top_inline-expected.checksum:
  • css1/box_properties/border_top_inline-expected.png:
  • css1/box_properties/border_top_width-expected.checksum:
  • css1/box_properties/border_top_width-expected.png:
  • css1/box_properties/border_top_width_inline-expected.checksum:
  • css1/box_properties/border_top_width_inline-expected.png:
  • css1/box_properties/border_width-expected.checksum:
  • css1/box_properties/border_width-expected.png:
  • css1/box_properties/border_width_inline-expected.checksum:
  • css1/box_properties/border_width_inline-expected.png:
  • css1/box_properties/clear-expected.checksum:
  • css1/box_properties/clear-expected.png:
  • css1/box_properties/clear_float-expected.checksum:
  • css1/box_properties/clear_float-expected.png:
  • css1/box_properties/float-expected.checksum:
  • css1/box_properties/float-expected.png:
  • css1/box_properties/float_elements_in_series-expected.checksum:
  • css1/box_properties/float_elements_in_series-expected.png:
  • css1/box_properties/float_margin-expected.checksum:
  • css1/box_properties/float_margin-expected.png:
  • css1/box_properties/float_on_text_elements-expected.checksum:
  • css1/box_properties/float_on_text_elements-expected.png:
  • css1/box_properties/height-expected.checksum:
  • css1/box_properties/height-expected.png:
  • css1/box_properties/margin-expected.checksum:
  • css1/box_properties/margin-expected.png:
  • css1/box_properties/margin_bottom-expected.checksum:
  • css1/box_properties/margin_bottom-expected.png:
  • css1/box_properties/margin_bottom_inline-expected.checksum:
  • css1/box_properties/margin_bottom_inline-expected.png:
  • css1/box_properties/margin_inline-expected.checksum:
  • css1/box_properties/margin_inline-expected.png:
  • css1/box_properties/margin_left-expected.checksum:
  • css1/box_properties/margin_left-expected.png:
  • css1/box_properties/margin_left_inline-expected.checksum:
  • css1/box_properties/margin_left_inline-expected.png:
  • css1/box_properties/margin_right-expected.checksum:
  • css1/box_properties/margin_right-expected.png:
  • css1/box_properties/margin_right_inline-expected.checksum:
  • css1/box_properties/margin_right_inline-expected.png:
  • css1/box_properties/margin_top-expected.checksum:
  • css1/box_properties/margin_top-expected.png:
  • css1/box_properties/margin_top_inline-expected.checksum:
  • css1/box_properties/margin_top_inline-expected.png:
  • css1/box_properties/padding-expected.checksum:
  • css1/box_properties/padding-expected.png:
  • css1/box_properties/padding_bottom-expected.checksum:
  • css1/box_properties/padding_bottom-expected.png:
  • css1/box_properties/padding_bottom_inline-expected.checksum:
  • css1/box_properties/padding_bottom_inline-expected.png:
  • css1/box_properties/padding_inline-expected.checksum:
  • css1/box_properties/padding_inline-expected.png:
  • css1/box_properties/padding_left-expected.checksum:
  • css1/box_properties/padding_left-expected.png:
  • css1/box_properties/padding_left_inline-expected.checksum:
  • css1/box_properties/padding_left_inline-expected.png:
  • css1/box_properties/padding_right-expected.checksum:
  • css1/box_properties/padding_right-expected.png:
  • css1/box_properties/padding_right_inline-expected.checksum:
  • css1/box_properties/padding_right_inline-expected.png:
  • css1/box_properties/padding_top-expected.checksum:
  • css1/box_properties/padding_top-expected.png:
  • css1/box_properties/padding_top_inline-expected.checksum:
  • css1/box_properties/padding_top_inline-expected.png:
  • css1/box_properties/width-expected.checksum:
  • css1/box_properties/width-expected.png:
  • css1/cascade/cascade_order-expected.checksum:
  • css1/cascade/cascade_order-expected.png:
  • css1/cascade/important-expected.checksum:
  • css1/cascade/important-expected.png:
  • css1/classification/display-expected.checksum:
  • css1/classification/display-expected.png:
  • css1/classification/list_style-expected.checksum:
  • css1/classification/list_style-expected.png:
  • css1/classification/list_style_image-expected.checksum:
  • css1/classification/list_style_image-expected.png:
  • css1/classification/list_style_position-expected.checksum:
  • css1/classification/list_style_position-expected.png:
  • css1/classification/list_style_type-expected.checksum:
  • css1/classification/list_style_type-expected.png:
  • css1/classification/white_space-expected.checksum:
  • css1/classification/white_space-expected.png:
  • css1/color_and_background/background-expected.checksum:
  • css1/color_and_background/background-expected.png:
  • css1/color_and_background/background_attachment-expected.checksum:
  • css1/color_and_background/background_attachment-expected.png:
  • css1/color_and_background/background_color-expected.checksum:
  • css1/color_and_background/background_color-expected.png:
  • css1/color_and_background/background_image-expected.checksum:
  • css1/color_and_background/background_image-expected.png:
  • css1/color_and_background/background_position-expected.checksum:
  • css1/color_and_background/background_position-expected.png:
  • css1/color_and_background/background_repeat-expected.checksum:
  • css1/color_and_background/background_repeat-expected.png:
  • css1/color_and_background/color-expected.checksum:
  • css1/color_and_background/color-expected.png:
  • css1/font_properties/font-expected.checksum:
  • css1/font_properties/font-expected.png:
  • css1/font_properties/font_family-expected.checksum:
  • css1/font_properties/font_family-expected.png:
  • css1/font_properties/font_size-expected.checksum:
  • css1/font_properties/font_size-expected.png:
  • css1/font_properties/font_style-expected.checksum:
  • css1/font_properties/font_style-expected.png:
  • css1/font_properties/font_variant-expected.checksum:
  • css1/font_properties/font_variant-expected.png:
  • css1/font_properties/font_weight-expected.checksum:
  • css1/font_properties/font_weight-expected.png:
  • css1/formatting_model/canvas-expected.checksum:
  • css1/formatting_model/canvas-expected.png:
  • css1/formatting_model/floating_elements-expected.checksum:
  • css1/formatting_model/floating_elements-expected.png:
  • css1/formatting_model/height_of_lines-expected.checksum:
  • css1/formatting_model/height_of_lines-expected.png:
  • css1/formatting_model/inline_elements-expected.checksum:
  • css1/formatting_model/inline_elements-expected.png:
  • css1/formatting_model/replaced_elements-expected.checksum:
  • css1/formatting_model/replaced_elements-expected.png:
  • css1/formatting_model/vertical_formatting-expected.checksum:
  • css1/formatting_model/vertical_formatting-expected.png:
  • css1/pseudo/anchor-expected.checksum:
  • css1/pseudo/anchor-expected.png:
  • css1/pseudo/firstletter-expected.checksum:
  • css1/pseudo/firstletter-expected.png:
  • css1/pseudo/firstline-expected.checksum:
  • css1/pseudo/firstline-expected.png:
  • css1/pseudo/multiple_pseudo_elements-expected.checksum:
  • css1/pseudo/multiple_pseudo_elements-expected.png:
  • css1/pseudo/pseudo_elements_in_selectors-expected.checksum:
  • css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • css1/text_properties/letter_spacing-expected.checksum:
  • css1/text_properties/letter_spacing-expected.png:
  • css1/text_properties/line_height-expected.checksum:
  • css1/text_properties/line_height-expected.png:
  • css1/text_properties/text_align-expected.checksum:
  • css1/text_properties/text_align-expected.png:
  • css1/text_properties/text_decoration-expected.checksum:
  • css1/text_properties/text_decoration-expected.png:
  • css1/text_properties/text_indent-expected.checksum:
  • css1/text_properties/text_indent-expected.png:
  • css1/text_properties/text_transform-expected.checksum:
  • css1/text_properties/text_transform-expected.png:
  • css1/text_properties/vertical_align-expected.checksum:
  • css1/text_properties/vertical_align-expected.png:
  • css1/text_properties/word_spacing-expected.checksum:
  • css1/text_properties/word_spacing-expected.png:
  • css1/units/color_units-expected.checksum:
  • css1/units/color_units-expected.png:
  • css1/units/length_units-expected.checksum:
  • css1/units/length_units-expected.png:
  • css1/units/percentage_units-expected.checksum:
  • css1/units/percentage_units-expected.png:
  • css1/units/urls-expected.checksum:
  • css1/units/urls-expected.png:
  • css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • css2.1/t0805-c5517-brdr-s-00-c-expected.checksum:
  • css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • css2.1/t0805-c5517-ibrdr-s-00-a-expected.checksum:
  • css2.1/t0805-c5517-ibrdr-s-00-a-expected.png:
  • css2.1/t0805-c5522-brdr-00-b-expected.checksum:
  • css2.1/t0805-c5522-brdr-00-b-expected.png:
  • css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/pasteboard/3976872-expected.checksum:
  • editing/pasteboard/3976872-expected.png:
  • editing/pasteboard/4076267-2-expected.checksum:
  • editing/pasteboard/4076267-2-expected.png:
  • editing/pasteboard/4076267-3-expected.checksum:
  • editing/pasteboard/4076267-3-expected.png:
  • editing/pasteboard/4076267-expected.checksum:
  • editing/pasteboard/4076267-expected.png:
  • editing/pasteboard/display-block-on-spans-expected.checksum:
  • editing/pasteboard/display-block-on-spans-expected.png:
  • editing/pasteboard/drop-text-without-selection-expected.checksum:
  • editing/pasteboard/drop-text-without-selection-expected.png:
  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • editing/pasteboard/undoable-fragment-removes-expected.png:
  • editing/selection/4402375-expected.checksum:
  • editing/selection/4402375-expected.png:
  • editing/selection/6476-expected.checksum:
  • editing/selection/6476-expected.png:
  • editing/selection/7152-1-expected.checksum:
  • editing/selection/7152-1-expected.png:
  • editing/selection/7152-2-expected.checksum:
  • editing/selection/7152-2-expected.png:
  • editing/selection/image-before-linebreak-expected.checksum:
  • editing/selection/image-before-linebreak-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • fast/block/basic/018-expected.checksum:
  • fast/block/basic/018-expected.png:
  • fast/block/basic/text-indent-rtl-expected.checksum:
  • fast/block/basic/text-indent-rtl-expected.png:
  • fast/block/float/015-expected.checksum:
  • fast/block/float/015-expected.png:
  • fast/block/float/025-expected.checksum:
  • fast/block/float/025-expected.png:
  • fast/block/float/026-expected.checksum:
  • fast/block/float/026-expected.png:
  • fast/block/float/027-expected.checksum:
  • fast/block/float/027-expected.png:
  • fast/block/float/028-expected.checksum:
  • fast/block/float/028-expected.png:
  • fast/block/positioning/height-change-expected.checksum:
  • fast/block/positioning/height-change-expected.png:
  • fast/block/positioning/relayout-on-position-change-expected.checksum:
  • fast/block/positioning/relayout-on-position-change-expected.png:
  • fast/block/positioning/window-height-change-expected.checksum:
  • fast/block/positioning/window-height-change-expected.png:
  • fast/css-generated-content/014-expected.checksum:
  • fast/css-generated-content/014-expected.png:
  • fast/css-generated-content/hover-style-change-expected.checksum:
  • fast/css-generated-content/hover-style-change-expected.png:
  • fast/css/MarqueeLayoutTest-expected.checksum:
  • fast/css/MarqueeLayoutTest-expected.png:
  • fast/css/apple-prefix-expected.checksum:
  • fast/css/apple-prefix-expected.png:
  • fast/css/hover-subselector-expected.checksum:
  • fast/css/hover-subselector-expected.png:
  • fast/css/rtl-ordering-expected.checksum:
  • fast/css/rtl-ordering-expected.png:
  • fast/css/universal-hover-quirk-expected.checksum:
  • fast/css/universal-hover-quirk-expected.png:
  • fast/dom/HTMLElement/bdo-expected.checksum:
  • fast/dom/HTMLElement/bdo-expected.png:
  • fast/dom/HTMLTableElement/colSpan-expected.checksum:
  • fast/dom/HTMLTableElement/colSpan-expected.png:
  • fast/dom/HTMLTableElement/createCaption-expected.checksum:
  • fast/dom/HTMLTableElement/createCaption-expected.png:
  • fast/dom/clone-node-dynamic-style-expected.checksum:
  • fast/dom/clone-node-dynamic-style-expected.png:
  • fast/dom/isindex-002-expected.checksum:
  • fast/dom/isindex-002-expected.png:
  • fast/dom/row-inner-text-expected.checksum:
  • fast/dom/row-inner-text-expected.png:
  • fast/dynamic/012-expected.checksum:
  • fast/dynamic/012-expected.png:
  • fast/dynamic/013-expected.checksum:
  • fast/dynamic/013-expected.png:
  • fast/dynamic/015-expected.checksum:
  • fast/dynamic/015-expected.png:
  • fast/encoding/invalid-UTF-8-expected.checksum:
  • fast/encoding/invalid-UTF-8-expected.png:
  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png:
  • fast/events/event-sender-mouse-moved-expected.checksum:
  • fast/events/event-sender-mouse-moved-expected.png:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/006-expected.checksum:
  • fast/forms/006-expected.png:
  • fast/forms/007-expected.checksum:
  • fast/forms/007-expected.png:
  • fast/forms/button-default-title-expected.checksum:
  • fast/forms/button-default-title-expected.png:
  • fast/forms/button-inner-block-reuse-expected.checksum:
  • fast/forms/button-inner-block-reuse-expected.png:
  • fast/forms/input-appearance-disabled-expected.checksum:
  • fast/forms/input-appearance-disabled-expected.png:
  • fast/forms/input-appearance-disabled-expected.txt:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/visual-hebrew-text-field-expected.checksum:
  • fast/forms/visual-hebrew-text-field-expected.png:
  • fast/lists/004-expected.checksum:
  • fast/lists/004-expected.png:
  • fast/lists/markers-in-selection-expected.checksum:
  • fast/lists/markers-in-selection-expected.png:
  • fast/lists/olstart-expected.checksum:
  • fast/lists/olstart-expected.png:
  • fast/overflow/002-expected.checksum:
  • fast/overflow/002-expected.png:
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum:
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.png:
  • fast/overflow/overflow-text-hit-testing-expected.checksum:
  • fast/overflow/overflow-text-hit-testing-expected.png:
  • fast/parser/entities-in-xhtml-expected.checksum:
  • fast/parser/entities-in-xhtml-expected.png:
  • fast/repaint/flexible-box-overflow-expected.checksum:
  • fast/repaint/flexible-box-overflow-expected.png:
  • fast/repaint/flexible-box-overflow-horizontal-expected.checksum:
  • fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • fast/repaint/inline-block-overflow-expected.checksum:
  • fast/repaint/inline-block-overflow-expected.png:
  • fast/repaint/layer-outline-expected.checksum:
  • fast/repaint/layer-outline-expected.png:
  • fast/repaint/layer-outline-horizontal-expected.checksum:
  • fast/repaint/layer-outline-horizontal-expected.png:
  • fast/repaint/text-shadow-expected.checksum:
  • fast/repaint/text-shadow-expected.png:
  • fast/repaint/text-shadow-horizontal-expected.checksum:
  • fast/repaint/text-shadow-horizontal-expected.png:
  • fast/replaced/005-expected.checksum:
  • fast/replaced/005-expected.png:
  • fast/replaced/inline-box-wrapper-handover-expected.checksum:
  • fast/replaced/inline-box-wrapper-handover-expected.png:
  • fast/selectors/032-expected.checksum:
  • fast/selectors/032-expected.png:
  • fast/selectors/077-expected.checksum:
  • fast/selectors/077-expected.png:
  • fast/selectors/077b-expected.checksum:
  • fast/selectors/077b-expected.png:
  • fast/selectors/078b-expected.checksum:
  • fast/selectors/078b-expected.png:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • fast/table/004-expected.checksum:
  • fast/table/004-expected.png:
  • fast/table/006-expected.checksum:
  • fast/table/006-expected.png:
  • fast/table/007-expected.checksum:
  • fast/table/007-expected.png:
  • fast/table/009-expected.checksum:
  • fast/table/009-expected.png:
  • fast/table/017-expected.checksum:
  • fast/table/017-expected.png:
  • fast/table/018-expected.checksum:
  • fast/table/018-expected.png:
  • fast/table/020-expected.checksum:
  • fast/table/020-expected.png:
  • fast/table/029-expected.checksum:
  • fast/table/029-expected.png:
  • fast/table/030-expected.checksum:
  • fast/table/030-expected.png:
  • fast/table/035-expected.checksum:
  • fast/table/035-expected.png:
  • fast/table/038-expected.checksum:
  • fast/table/038-expected.png:
  • fast/table/039-expected.checksum:
  • fast/table/039-expected.png:
  • fast/table/040-expected.checksum:
  • fast/table/040-expected.png:
  • fast/table/041-expected.checksum:
  • fast/table/041-expected.png:
  • fast/table/add-before-anonymous-child-expected.checksum:
  • fast/table/add-before-anonymous-child-expected.png:
  • fast/table/border-collapsing/rtl-border-collapsing-expected.checksum:
  • fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • fast/table/edge-offsets-expected.checksum:
  • fast/table/edge-offsets-expected.png:
  • fast/table/empty-table-percent-height-expected.checksum:
  • fast/table/empty-table-percent-height-expected.png:
  • fast/table/giantRowspan-expected.checksum:
  • fast/table/giantRowspan-expected.png:
  • fast/table/large-width-expected.checksum:
  • fast/table/large-width-expected.png:
  • fast/table/multiple-percent-height-rows-expected.checksum:
  • fast/table/multiple-percent-height-rows-expected.png:
  • fast/table/nobr-expected.checksum:
  • fast/table/nobr-expected.png:
  • fast/table/overflowHidden-expected.checksum:
  • fast/table/overflowHidden-expected.png:
  • fast/table/percent-heights-expected.checksum:
  • fast/table/percent-heights-expected.png:
  • fast/table/rowindex-expected.checksum:
  • fast/table/rowindex-expected.png:
  • fast/table/rowspan-paint-order-expected.checksum:
  • fast/table/rowspan-paint-order-expected.png:
  • fast/table/spanOverlapRepaint-expected.checksum:
  • fast/table/spanOverlapRepaint-expected.png:
  • fast/text/atsui-kerning-and-ligatures-expected.checksum:
  • fast/text/atsui-kerning-and-ligatures-expected.png:
  • fast/text/atsui-multiple-renderers-expected.checksum:
  • fast/text/atsui-multiple-renderers-expected.png:
  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum:
  • fast/text/atsui-pointtooffset-calls-cg-expected.png:
  • fast/text/atsui-rtl-override-selection-expected.checksum:
  • fast/text/atsui-rtl-override-selection-expected.png:
  • fast/text/atsui-small-caps-punctuation-size-expected.checksum:
  • fast/text/atsui-small-caps-punctuation-size-expected.png:
  • fast/text/atsui-spacing-features-expected.checksum:
  • fast/text/atsui-spacing-features-expected.png:
  • fast/text/basic/001-expected.checksum:
  • fast/text/basic/001-expected.png:
  • fast/text/basic/006-expected.checksum:
  • fast/text/basic/006-expected.png:
  • fast/text/basic/007-expected.checksum:
  • fast/text/basic/007-expected.png:
  • fast/text/basic/015-expected.checksum:
  • fast/text/basic/015-expected.png:
  • fast/text/cg-vs-atsui-expected.checksum:
  • fast/text/cg-vs-atsui-expected.png:
  • fast/text/in-rendered-text-rtl-expected.checksum:
  • fast/text/in-rendered-text-rtl-expected.png:
  • fast/text/international/003-expected.checksum:
  • fast/text/international/003-expected.png:
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • fast/text/international/bidi-LDB-2-CSS-expected.png:
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • fast/text/international/bidi-LDB-2-HTML-expected.png:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • fast/text/international/bidi-european-terminators-expected.checksum:
  • fast/text/international/bidi-european-terminators-expected.png:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • fast/text/international/bidi-innertext-expected.checksum:
  • fast/text/international/bidi-innertext-expected.png:
  • fast/text/should-use-atsui-expected.checksum:
  • fast/text/should-use-atsui-expected.png:
  • fast/text/whitespace/027-expected.checksum:
  • fast/text/whitespace/027-expected.png:
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum:
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • tables/mozilla/bugs/45621-expected.checksum:
  • tables/mozilla/bugs/45621-expected.png:
  • tables/mozilla/bugs/bug10009-expected.checksum:
  • tables/mozilla/bugs/bug10009-expected.png:
  • tables/mozilla/bugs/bug10036-expected.checksum:
  • tables/mozilla/bugs/bug10036-expected.png:
  • tables/mozilla/bugs/bug10039-expected.checksum:
  • tables/mozilla/bugs/bug10039-expected.png:
  • tables/mozilla/bugs/bug101201-expected.checksum:
  • tables/mozilla/bugs/bug101201-expected.png:
  • tables/mozilla/bugs/bug1055-1-expected.checksum:
  • tables/mozilla/bugs/bug1055-1-expected.png:
  • tables/mozilla/bugs/bug10565-expected.checksum:
  • tables/mozilla/bugs/bug10565-expected.png:
  • tables/mozilla/bugs/bug1067-2-expected.checksum:
  • tables/mozilla/bugs/bug1067-2-expected.png:
  • tables/mozilla/bugs/bug106795-expected.checksum:
  • tables/mozilla/bugs/bug106795-expected.png:
  • tables/mozilla/bugs/bug106816-expected.checksum:
  • tables/mozilla/bugs/bug106816-expected.png:
  • tables/mozilla/bugs/bug108340-expected.checksum:
  • tables/mozilla/bugs/bug108340-expected.png:
  • tables/mozilla/bugs/bug109043-expected.checksum:
  • tables/mozilla/bugs/bug109043-expected.png:
  • tables/mozilla/bugs/bug110566-expected.checksum:
  • tables/mozilla/bugs/bug110566-expected.png:
  • tables/mozilla/bugs/bug113235-1-expected.checksum:
  • tables/mozilla/bugs/bug113235-1-expected.png:
  • tables/mozilla/bugs/bug113235-3-expected.checksum:
  • tables/mozilla/bugs/bug113235-3-expected.png:
  • tables/mozilla/bugs/bug113424-expected.checksum:
  • tables/mozilla/bugs/bug113424-expected.png:
  • tables/mozilla/bugs/bug11384q-expected.checksum:
  • tables/mozilla/bugs/bug11384q-expected.png:
  • tables/mozilla/bugs/bug1188-expected.checksum:
  • tables/mozilla/bugs/bug1188-expected.png:
  • tables/mozilla/bugs/bug11944-expected.checksum:
  • tables/mozilla/bugs/bug11944-expected.png:
  • tables/mozilla/bugs/bug119786-expected.checksum:
  • tables/mozilla/bugs/bug119786-expected.png:
  • tables/mozilla/bugs/bug12008-expected.checksum:
  • tables/mozilla/bugs/bug12008-expected.png:
  • tables/mozilla/bugs/bug1220-expected.checksum:
  • tables/mozilla/bugs/bug1220-expected.png:
  • tables/mozilla/bugs/bug1224-expected.checksum:
  • tables/mozilla/bugs/bug1224-expected.png:
  • tables/mozilla/bugs/bug12268-expected.checksum:
  • tables/mozilla/bugs/bug12268-expected.png:
  • tables/mozilla/bugs/bug12384-expected.checksum:
  • tables/mozilla/bugs/bug12384-expected.png:
  • tables/mozilla/bugs/bug1261-expected.checksum:
  • tables/mozilla/bugs/bug1261-expected.png:
  • tables/mozilla/bugs/bug12709-expected.checksum:
  • tables/mozilla/bugs/bug12709-expected.png:
  • tables/mozilla/bugs/bug128229-expected.checksum:
  • tables/mozilla/bugs/bug128229-expected.png:
  • tables/mozilla/bugs/bug12908-1-expected.checksum:
  • tables/mozilla/bugs/bug12908-1-expected.png:
  • tables/mozilla/bugs/bug12910-expected.checksum:
  • tables/mozilla/bugs/bug12910-expected.png:
  • tables/mozilla/bugs/bug1302-expected.checksum:
  • tables/mozilla/bugs/bug1302-expected.png:
  • tables/mozilla/bugs/bug131020-2-expected.checksum:
  • tables/mozilla/bugs/bug131020-2-expected.png:
  • tables/mozilla/bugs/bug131020-expected.checksum:
  • tables/mozilla/bugs/bug131020-expected.png:
  • tables/mozilla/bugs/bug13118-expected.checksum:
  • tables/mozilla/bugs/bug13118-expected.png:
  • tables/mozilla/bugs/bug13169-expected.checksum:
  • tables/mozilla/bugs/bug13169-expected.png:
  • tables/mozilla/bugs/bug1318-expected.checksum:
  • tables/mozilla/bugs/bug1318-expected.png:
  • tables/mozilla/bugs/bug13196-expected.checksum:
  • tables/mozilla/bugs/bug13196-expected.png:
  • tables/mozilla/bugs/bug133756-2-expected.checksum:
  • tables/mozilla/bugs/bug133756-2-expected.png:
  • tables/mozilla/bugs/bug133948-expected.checksum:
  • tables/mozilla/bugs/bug133948-expected.png:
  • tables/mozilla/bugs/bug13484-expected.checksum:
  • tables/mozilla/bugs/bug13484-expected.png:
  • tables/mozilla/bugs/bug139524-4-expected.checksum:
  • tables/mozilla/bugs/bug139524-4-expected.png:
  • tables/mozilla/bugs/bug1474-expected.checksum:
  • tables/mozilla/bugs/bug1474-expected.png:
  • tables/mozilla/bugs/bug149275-1-expected.checksum:
  • tables/mozilla/bugs/bug149275-1-expected.png:
  • tables/mozilla/bugs/bug149275-2-expected.checksum:
  • tables/mozilla/bugs/bug149275-2-expected.png:
  • tables/mozilla/bugs/bug14929-expected.checksum:
  • tables/mozilla/bugs/bug14929-expected.png:
  • tables/mozilla/bugs/bug15247-expected.checksum:
  • tables/mozilla/bugs/bug15247-expected.png:
  • tables/mozilla/bugs/bug15933-expected.checksum:
  • tables/mozilla/bugs/bug15933-expected.png:
  • tables/mozilla/bugs/bug16012-expected.checksum:
  • tables/mozilla/bugs/bug16012-expected.png:
  • tables/mozilla/bugs/bug16252-expected.checksum:
  • tables/mozilla/bugs/bug16252-expected.png:
  • tables/mozilla/bugs/bug17168-expected.checksum:
  • tables/mozilla/bugs/bug17168-expected.png:
  • tables/mozilla/bugs/bug175455-4-expected.checksum:
  • tables/mozilla/bugs/bug175455-4-expected.png:
  • tables/mozilla/bugs/bug17548-expected.checksum:
  • tables/mozilla/bugs/bug17548-expected.png:
  • tables/mozilla/bugs/bug17587-expected.checksum:
  • tables/mozilla/bugs/bug17587-expected.png:
  • tables/mozilla/bugs/bug1800-expected.checksum:
  • tables/mozilla/bugs/bug1800-expected.png:
  • tables/mozilla/bugs/bug1802-expected.checksum:
  • tables/mozilla/bugs/bug1802-expected.png:
  • tables/mozilla/bugs/bug1802s-expected.checksum:
  • tables/mozilla/bugs/bug1802s-expected.png:
  • tables/mozilla/bugs/bug1809-expected.checksum:
  • tables/mozilla/bugs/bug1809-expected.png:
  • tables/mozilla/bugs/bug1818-1-expected.checksum:
  • tables/mozilla/bugs/bug1818-1-expected.png:
  • tables/mozilla/bugs/bug1818-2-expected.checksum:
  • tables/mozilla/bugs/bug1818-2-expected.png:
  • tables/mozilla/bugs/bug1818-3-expected.checksum:
  • tables/mozilla/bugs/bug1818-3-expected.png:
  • tables/mozilla/bugs/bug1818-4-expected.checksum:
  • tables/mozilla/bugs/bug1818-4-expected.png:
  • tables/mozilla/bugs/bug1828-expected.checksum:
  • tables/mozilla/bugs/bug1828-expected.png:
  • tables/mozilla/bugs/bug18359-expected.checksum:
  • tables/mozilla/bugs/bug18359-expected.png:
  • tables/mozilla/bugs/bug18558-expected.checksum:
  • tables/mozilla/bugs/bug18558-expected.png:
  • tables/mozilla/bugs/bug18955-expected.checksum:
  • tables/mozilla/bugs/bug18955-expected.png:
  • tables/mozilla/bugs/bug19061-1-expected.checksum:
  • tables/mozilla/bugs/bug19061-1-expected.png:
  • tables/mozilla/bugs/bug19061-2-expected.checksum:
  • tables/mozilla/bugs/bug19061-2-expected.png:
  • tables/mozilla/bugs/bug19356-expected.checksum:
  • tables/mozilla/bugs/bug19356-expected.png:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug19599-expected.checksum:
  • tables/mozilla/bugs/bug19599-expected.png:
  • tables/mozilla/bugs/bug2050-expected.checksum:
  • tables/mozilla/bugs/bug2050-expected.png:
  • tables/mozilla/bugs/bug2065-expected.checksum:
  • tables/mozilla/bugs/bug2065-expected.png:
  • tables/mozilla/bugs/bug20804-expected.checksum:
  • tables/mozilla/bugs/bug20804-expected.png:
  • tables/mozilla/bugs/bug21299-expected.checksum:
  • tables/mozilla/bugs/bug21299-expected.png:
  • tables/mozilla/bugs/bug21918-expected.checksum:
  • tables/mozilla/bugs/bug21918-expected.png:
  • tables/mozilla/bugs/bug219693-1-expected.checksum:
  • tables/mozilla/bugs/bug219693-1-expected.png:
  • tables/mozilla/bugs/bug219693-2-expected.checksum:
  • tables/mozilla/bugs/bug219693-2-expected.png:
  • tables/mozilla/bugs/bug220536-expected.checksum:
  • tables/mozilla/bugs/bug220536-expected.png:
  • tables/mozilla/bugs/bug221784-1-expected.checksum:
  • tables/mozilla/bugs/bug221784-1-expected.png:
  • tables/mozilla/bugs/bug221784-2-expected.checksum:
  • tables/mozilla/bugs/bug221784-2-expected.png:
  • tables/mozilla/bugs/bug2267-expected.checksum:
  • tables/mozilla/bugs/bug2267-expected.png:
  • tables/mozilla/bugs/bug2296-expected.checksum:
  • tables/mozilla/bugs/bug2296-expected.png:
  • tables/mozilla/bugs/bug23235-expected.checksum:
  • tables/mozilla/bugs/bug23235-expected.png:
  • tables/mozilla/bugs/bug24200-expected.checksum:
  • tables/mozilla/bugs/bug24200-expected.png:
  • tables/mozilla/bugs/bug24503-expected.checksum:
  • tables/mozilla/bugs/bug24503-expected.png:
  • tables/mozilla/bugs/bug24627-expected.checksum:
  • tables/mozilla/bugs/bug24627-expected.png:
  • tables/mozilla/bugs/bug24661-expected.checksum:
  • tables/mozilla/bugs/bug24661-expected.png:
  • tables/mozilla/bugs/bug2479-3-expected.checksum:
  • tables/mozilla/bugs/bug2479-3-expected.png:
  • tables/mozilla/bugs/bug24880-expected.checksum:
  • tables/mozilla/bugs/bug24880-expected.png:
  • tables/mozilla/bugs/bug25004-expected.checksum:
  • tables/mozilla/bugs/bug25004-expected.png:
  • tables/mozilla/bugs/bug25086-expected.checksum:
  • tables/mozilla/bugs/bug25086-expected.png:
  • tables/mozilla/bugs/bug2516-expected.checksum:
  • tables/mozilla/bugs/bug2516-expected.png:
  • tables/mozilla/bugs/bug25663-expected.checksum:
  • tables/mozilla/bugs/bug25663-expected.png:
  • tables/mozilla/bugs/bug2585-expected.checksum:
  • tables/mozilla/bugs/bug2585-expected.png:
  • tables/mozilla/bugs/bug26553-expected.checksum:
  • tables/mozilla/bugs/bug26553-expected.png:
  • tables/mozilla/bugs/bug2684-expected.checksum:
  • tables/mozilla/bugs/bug2684-expected.png:
  • tables/mozilla/bugs/bug27038-2-expected.checksum:
  • tables/mozilla/bugs/bug27038-2-expected.png:
  • tables/mozilla/bugs/bug2757-expected.checksum:
  • tables/mozilla/bugs/bug2757-expected.png:
  • tables/mozilla/bugs/bug2773-expected.checksum:
  • tables/mozilla/bugs/bug2773-expected.png:
  • tables/mozilla/bugs/bug278385-expected.checksum:
  • tables/mozilla/bugs/bug278385-expected.png:
  • tables/mozilla/bugs/bug27993-1-expected.checksum:
  • tables/mozilla/bugs/bug27993-1-expected.png:
  • tables/mozilla/bugs/bug2886-expected.checksum:
  • tables/mozilla/bugs/bug2886-expected.png:
  • tables/mozilla/bugs/bug28928-expected.checksum:
  • tables/mozilla/bugs/bug28928-expected.png:
  • tables/mozilla/bugs/bug29058-1-expected.checksum:
  • tables/mozilla/bugs/bug29058-1-expected.png:
  • tables/mozilla/bugs/bug29058-3-expected.checksum:
  • tables/mozilla/bugs/bug29058-3-expected.png:
  • tables/mozilla/bugs/bug29157-expected.checksum:
  • tables/mozilla/bugs/bug29157-expected.png:
  • tables/mozilla/bugs/bug29326-expected.checksum:
  • tables/mozilla/bugs/bug29326-expected.png:
  • tables/mozilla/bugs/bug29429-expected.checksum:
  • tables/mozilla/bugs/bug29429-expected.png:
  • tables/mozilla/bugs/bug2962-expected.checksum:
  • tables/mozilla/bugs/bug2962-expected.png:
  • tables/mozilla/bugs/bug2981-2-expected.checksum:
  • tables/mozilla/bugs/bug2981-2-expected.png:
  • tables/mozilla/bugs/bug30273-expected.checksum:
  • tables/mozilla/bugs/bug30273-expected.png:
  • tables/mozilla/bugs/bug30332-1-expected.checksum:
  • tables/mozilla/bugs/bug30332-1-expected.png:
  • tables/mozilla/bugs/bug30332-2-expected.checksum:
  • tables/mozilla/bugs/bug30332-2-expected.png:
  • tables/mozilla/bugs/bug30418-expected.checksum:
  • tables/mozilla/bugs/bug30418-expected.png:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug3103-expected.checksum:
  • tables/mozilla/bugs/bug3103-expected.png:
  • tables/mozilla/bugs/bug3191-expected.checksum:
  • tables/mozilla/bugs/bug3191-expected.png:
  • tables/mozilla/bugs/bug32205-2-expected.checksum:
  • tables/mozilla/bugs/bug32205-2-expected.png:
  • tables/mozilla/bugs/bug32205-3-expected.checksum:
  • tables/mozilla/bugs/bug32205-3-expected.png:
  • tables/mozilla/bugs/bug32205-5-expected.checksum:
  • tables/mozilla/bugs/bug32205-5-expected.png:
  • tables/mozilla/bugs/bug3260-expected.checksum:
  • tables/mozilla/bugs/bug3260-expected.png:
  • tables/mozilla/bugs/bug3263-expected.checksum:
  • tables/mozilla/bugs/bug3263-expected.png:
  • tables/mozilla/bugs/bug32841-expected.checksum:
  • tables/mozilla/bugs/bug32841-expected.png:
  • tables/mozilla/bugs/bug3309-2-expected.checksum:
  • tables/mozilla/bugs/bug3309-2-expected.png:
  • tables/mozilla/bugs/bug33137-expected.checksum:
  • tables/mozilla/bugs/bug33137-expected.png:
  • tables/mozilla/bugs/bug34176-expected.checksum:
  • tables/mozilla/bugs/bug34176-expected.png:
  • tables/mozilla/bugs/bug3454-expected.checksum:
  • tables/mozilla/bugs/bug3454-expected.png:
  • tables/mozilla/bugs/bug35662-expected.checksum:
  • tables/mozilla/bugs/bug35662-expected.png:
  • tables/mozilla/bugs/bug3718-expected.checksum:
  • tables/mozilla/bugs/bug3718-expected.png:
  • tables/mozilla/bugs/bug38916-expected.checksum:
  • tables/mozilla/bugs/bug38916-expected.png:
  • tables/mozilla/bugs/bug39209-expected.checksum:
  • tables/mozilla/bugs/bug39209-expected.png:
  • tables/mozilla/bugs/bug3977-expected.checksum:
  • tables/mozilla/bugs/bug3977-expected.png:
  • tables/mozilla/bugs/bug40828-expected.checksum:
  • tables/mozilla/bugs/bug40828-expected.png:
  • tables/mozilla/bugs/bug4093-expected.checksum:
  • tables/mozilla/bugs/bug4093-expected.png:
  • tables/mozilla/bugs/bug41890-expected.checksum:
  • tables/mozilla/bugs/bug41890-expected.png:
  • tables/mozilla/bugs/bug42187-expected.checksum:
  • tables/mozilla/bugs/bug42187-expected.png:
  • tables/mozilla/bugs/bug42443-expected.checksum:
  • tables/mozilla/bugs/bug42443-expected.png:
  • tables/mozilla/bugs/bug4284-expected.checksum:
  • tables/mozilla/bugs/bug4284-expected.png:
  • tables/mozilla/bugs/bug43204-expected.checksum:
  • tables/mozilla/bugs/bug43204-expected.png:
  • tables/mozilla/bugs/bug4385-expected.checksum:
  • tables/mozilla/bugs/bug4385-expected.png:
  • tables/mozilla/bugs/bug43854-1-expected.checksum:
  • tables/mozilla/bugs/bug43854-1-expected.png:
  • tables/mozilla/bugs/bug4427-expected.checksum:
  • tables/mozilla/bugs/bug4427-expected.png:
  • tables/mozilla/bugs/bug4429-expected.checksum:
  • tables/mozilla/bugs/bug4429-expected.png:
  • tables/mozilla/bugs/bug44505-expected.checksum:
  • tables/mozilla/bugs/bug44505-expected.png:
  • tables/mozilla/bugs/bug44523-expected.checksum:
  • tables/mozilla/bugs/bug44523-expected.png:
  • tables/mozilla/bugs/bug4501-expected.checksum:
  • tables/mozilla/bugs/bug4501-expected.png:
  • tables/mozilla/bugs/bug4520-expected.checksum:
  • tables/mozilla/bugs/bug4520-expected.png:
  • tables/mozilla/bugs/bug4523-expected.checksum:
  • tables/mozilla/bugs/bug4523-expected.png:
  • tables/mozilla/bugs/bug45486-expected.checksum:
  • tables/mozilla/bugs/bug45486-expected.png:
  • tables/mozilla/bugs/bug4576-expected.checksum:
  • tables/mozilla/bugs/bug4576-expected.png:
  • tables/mozilla/bugs/bug46268-1-expected.checksum:
  • tables/mozilla/bugs/bug46268-1-expected.png:
  • tables/mozilla/bugs/bug46268-2-expected.checksum:
  • tables/mozilla/bugs/bug46268-2-expected.png:
  • tables/mozilla/bugs/bug46268-3-expected.checksum:
  • tables/mozilla/bugs/bug46268-3-expected.png:
  • tables/mozilla/bugs/bug46268-5-expected.checksum:
  • tables/mozilla/bugs/bug46268-5-expected.png:
  • tables/mozilla/bugs/bug46268-expected.checksum:
  • tables/mozilla/bugs/bug46268-expected.png:
  • tables/mozilla/bugs/bug46368-1-expected.checksum:
  • tables/mozilla/bugs/bug46368-1-expected.png:
  • tables/mozilla/bugs/bug46368-2-expected.checksum:
  • tables/mozilla/bugs/bug46368-2-expected.png:
  • tables/mozilla/bugs/bug46623-1-expected.checksum:
  • tables/mozilla/bugs/bug46623-1-expected.png:
  • tables/mozilla/bugs/bug46623-2-expected.checksum:
  • tables/mozilla/bugs/bug46623-2-expected.png:
  • tables/mozilla/bugs/bug46924-expected.checksum:
  • tables/mozilla/bugs/bug46924-expected.png:
  • tables/mozilla/bugs/bug46944-expected.checksum:
  • tables/mozilla/bugs/bug46944-expected.png:
  • tables/mozilla/bugs/bug4739-expected.checksum:
  • tables/mozilla/bugs/bug4739-expected.png:
  • tables/mozilla/bugs/bug47432-expected.checksum:
  • tables/mozilla/bugs/bug47432-expected.png:
  • tables/mozilla/bugs/bug48028-1-expected.checksum:
  • tables/mozilla/bugs/bug48028-1-expected.png:
  • tables/mozilla/bugs/bug48028-2-expected.checksum:
  • tables/mozilla/bugs/bug48028-2-expected.png:
  • tables/mozilla/bugs/bug50695-1-expected.checksum:
  • tables/mozilla/bugs/bug50695-1-expected.png:
  • tables/mozilla/bugs/bug51037-expected.checksum:
  • tables/mozilla/bugs/bug51037-expected.png:
  • tables/mozilla/bugs/bug51140-expected.checksum:
  • tables/mozilla/bugs/bug51140-expected.png:
  • tables/mozilla/bugs/bug5188-expected.checksum:
  • tables/mozilla/bugs/bug5188-expected.png:
  • tables/mozilla/bugs/bug53690-1-expected.checksum:
  • tables/mozilla/bugs/bug53690-1-expected.png:
  • tables/mozilla/bugs/bug53690-2-expected.checksum:
  • tables/mozilla/bugs/bug53690-2-expected.png:
  • tables/mozilla/bugs/bug53891-expected.checksum:
  • tables/mozilla/bugs/bug53891-expected.png:
  • tables/mozilla/bugs/bug54450-expected.checksum:
  • tables/mozilla/bugs/bug54450-expected.png:
  • tables/mozilla/bugs/bug55694-expected.checksum:
  • tables/mozilla/bugs/bug55694-expected.png:
  • tables/mozilla/bugs/bug56201-expected.checksum:
  • tables/mozilla/bugs/bug56201-expected.png:
  • tables/mozilla/bugs/bug56563-expected.checksum:
  • tables/mozilla/bugs/bug56563-expected.png:
  • tables/mozilla/bugs/bug57300-expected.checksum:
  • tables/mozilla/bugs/bug57300-expected.png:
  • tables/mozilla/bugs/bug57378-expected.checksum:
  • tables/mozilla/bugs/bug57378-expected.png:
  • tables/mozilla/bugs/bug57828-expected.checksum:
  • tables/mozilla/bugs/bug57828-expected.png:
  • tables/mozilla/bugs/bug5797-expected.checksum:
  • tables/mozilla/bugs/bug5797-expected.png:
  • tables/mozilla/bugs/bug5798-expected.checksum:
  • tables/mozilla/bugs/bug5798-expected.png:
  • tables/mozilla/bugs/bug5799-expected.checksum:
  • tables/mozilla/bugs/bug5799-expected.png:
  • tables/mozilla/bugs/bug5835-expected.checksum:
  • tables/mozilla/bugs/bug5835-expected.png:
  • tables/mozilla/bugs/bug5838-expected.checksum:
  • tables/mozilla/bugs/bug5838-expected.png:
  • tables/mozilla/bugs/bug58402-1-expected.checksum:
  • tables/mozilla/bugs/bug58402-1-expected.png:
  • tables/mozilla/bugs/bug59354-expected.checksum:
  • tables/mozilla/bugs/bug59354-expected.png:
  • tables/mozilla/bugs/bug60013-expected.checksum:
  • tables/mozilla/bugs/bug60013-expected.png:
  • tables/mozilla/bugs/bug60749-expected.checksum:
  • tables/mozilla/bugs/bug60749-expected.png:
  • tables/mozilla/bugs/bug60804-expected.checksum:
  • tables/mozilla/bugs/bug60804-expected.png:
  • tables/mozilla/bugs/bug60807-expected.checksum:
  • tables/mozilla/bugs/bug60807-expected.png:
  • tables/mozilla/bugs/bug60992-expected.checksum:
  • tables/mozilla/bugs/bug60992-expected.png:
  • tables/mozilla/bugs/bug6184-expected.checksum:
  • tables/mozilla/bugs/bug6184-expected.png:
  • tables/mozilla/bugs/bug625-expected.checksum:
  • tables/mozilla/bugs/bug625-expected.png:
  • tables/mozilla/bugs/bug625-expected.txt:
  • tables/mozilla/bugs/bug6304-expected.checksum:
  • tables/mozilla/bugs/bug6304-expected.png:
  • tables/mozilla/bugs/bug647-expected.checksum:
  • tables/mozilla/bugs/bug647-expected.png:
  • tables/mozilla/bugs/bug6674-expected.checksum:
  • tables/mozilla/bugs/bug6674-expected.png:
  • tables/mozilla/bugs/bug67915-1-expected.checksum:
  • tables/mozilla/bugs/bug67915-1-expected.png:
  • tables/mozilla/bugs/bug68998-expected.checksum:
  • tables/mozilla/bugs/bug68998-expected.png:
  • tables/mozilla/bugs/bug69187-expected.checksum:
  • tables/mozilla/bugs/bug69187-expected.png:
  • tables/mozilla/bugs/bug69382-1-expected.checksum:
  • tables/mozilla/bugs/bug69382-1-expected.png:
  • tables/mozilla/bugs/bug69382-2-expected.checksum:
  • tables/mozilla/bugs/bug69382-2-expected.png:
  • tables/mozilla/bugs/bug7112-1-expected.checksum:
  • tables/mozilla/bugs/bug7112-1-expected.png:
  • tables/mozilla/bugs/bug7112-2-expected.checksum:
  • tables/mozilla/bugs/bug7112-2-expected.png:
  • tables/mozilla/bugs/bug7121-1-expected.checksum:
  • tables/mozilla/bugs/bug7121-1-expected.png:
  • tables/mozilla/bugs/bug727-expected.checksum:
  • tables/mozilla/bugs/bug727-expected.png:
  • tables/mozilla/bugs/bug73321-expected.checksum:
  • tables/mozilla/bugs/bug73321-expected.png:
  • tables/mozilla/bugs/bug7342-expected.checksum:
  • tables/mozilla/bugs/bug7342-expected.png:
  • tables/mozilla/bugs/bug7471-expected.checksum:
  • tables/mozilla/bugs/bug7471-expected.png:
  • tables/mozilla/bugs/bug7714-expected.checksum:
  • tables/mozilla/bugs/bug7714-expected.png:
  • tables/mozilla/bugs/bug78162-expected.checksum:
  • tables/mozilla/bugs/bug78162-expected.png:
  • tables/mozilla/bugs/bug81934-expected.checksum:
  • tables/mozilla/bugs/bug81934-expected.png:
  • tables/mozilla/bugs/bug82946-1-expected.checksum:
  • tables/mozilla/bugs/bug82946-1-expected.png:
  • tables/mozilla/bugs/bug8381-expected.checksum:
  • tables/mozilla/bugs/bug8381-expected.png:
  • tables/mozilla/bugs/bug86708-expected.checksum:
  • tables/mozilla/bugs/bug86708-expected.png:
  • tables/mozilla/bugs/bug88035-1-expected.checksum:
  • tables/mozilla/bugs/bug88035-1-expected.png:
  • tables/mozilla/bugs/bug88035-2-expected.checksum:
  • tables/mozilla/bugs/bug88035-2-expected.png:
  • tables/mozilla/bugs/bug8858-expected.checksum:
  • tables/mozilla/bugs/bug8858-expected.png:
  • tables/mozilla/bugs/bug8950-expected.checksum:
  • tables/mozilla/bugs/bug8950-expected.png:
  • tables/mozilla/bugs/bug9123-1-expected.checksum:
  • tables/mozilla/bugs/bug9123-1-expected.png:
  • tables/mozilla/bugs/bug9123-2-expected.checksum:
  • tables/mozilla/bugs/bug9123-2-expected.png:
  • tables/mozilla/bugs/bug92143-expected.checksum:
  • tables/mozilla/bugs/bug92143-expected.png:
  • tables/mozilla/bugs/bug92647-2-expected.checksum:
  • tables/mozilla/bugs/bug92647-2-expected.png:
  • tables/mozilla/bugs/bug9271-1-expected.checksum:
  • tables/mozilla/bugs/bug9271-1-expected.png:
  • tables/mozilla/bugs/bug9271-2-expected.checksum:
  • tables/mozilla/bugs/bug9271-2-expected.png:
  • tables/mozilla/bugs/bug965-expected.checksum:
  • tables/mozilla/bugs/bug965-expected.png:
  • tables/mozilla/bugs/bug97138-expected.checksum:
  • tables/mozilla/bugs/bug97138-expected.png:
  • tables/mozilla/bugs/bug98196-expected.checksum:
  • tables/mozilla/bugs/bug98196-expected.png:
  • tables/mozilla/bugs/bug9879-1-expected.checksum:
  • tables/mozilla/bugs/bug9879-1-expected.png:
  • tables/mozilla/bugs/bug99923-expected.checksum:
  • tables/mozilla/bugs/bug99923-expected.png:
  • tables/mozilla/collapsing_borders/bug41262-4-expected.checksum:
  • tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • tables/mozilla/core/bloomberg-expected.checksum:
  • tables/mozilla/core/bloomberg-expected.png:
  • tables/mozilla/core/borders-expected.checksum:
  • tables/mozilla/core/borders-expected.png:
  • tables/mozilla/core/captions-expected.checksum:
  • tables/mozilla/core/captions-expected.png:
  • tables/mozilla/core/cell_heights-expected.checksum:
  • tables/mozilla/core/cell_heights-expected.png:
  • tables/mozilla/core/col_span-expected.checksum:
  • tables/mozilla/core/col_span-expected.png:
  • tables/mozilla/core/col_widths_auto_auto-expected.checksum:
  • tables/mozilla/core/col_widths_auto_auto-expected.png:
  • tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • tables/mozilla/core/col_widths_auto_autoFixPer-expected.checksum:
  • tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
  • tables/mozilla/core/col_widths_auto_autoPer-expected.checksum:
  • tables/mozilla/core/col_widths_auto_autoPer-expected.png:
  • tables/mozilla/core/col_widths_auto_fix-expected.checksum:
  • tables/mozilla/core/col_widths_auto_fix-expected.png:
  • tables/mozilla/core/col_widths_auto_fixPer-expected.checksum:
  • tables/mozilla/core/col_widths_auto_fixPer-expected.png:
  • tables/mozilla/core/col_widths_auto_per-expected.checksum:
  • tables/mozilla/core/col_widths_auto_per-expected.png:
  • tables/mozilla/core/col_widths_fix_auto-expected.checksum:
  • tables/mozilla/core/col_widths_fix_auto-expected.png:
  • tables/mozilla/core/col_widths_fix_autoFix-expected.checksum:
  • tables/mozilla/core/col_widths_fix_autoFix-expected.png:
  • tables/mozilla/core/col_widths_fix_autoPer-expected.checksum:
  • tables/mozilla/core/col_widths_fix_autoPer-expected.png:
  • tables/mozilla/core/col_widths_fix_fix-expected.checksum:
  • tables/mozilla/core/col_widths_fix_fix-expected.png:
  • tables/mozilla/core/col_widths_fix_fixPer-expected.checksum:
  • tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • tables/mozilla/core/col_widths_fix_per-expected.checksum:
  • tables/mozilla/core/col_widths_fix_per-expected.png:
  • tables/mozilla/core/margins-expected.checksum:
  • tables/mozilla/core/margins-expected.png:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/nested1-expected.checksum:
  • tables/mozilla/core/nested1-expected.png:
  • tables/mozilla/core/one_row-expected.checksum:
  • tables/mozilla/core/one_row-expected.png:
  • tables/mozilla/core/row_span-expected.checksum:
  • tables/mozilla/core/row_span-expected.png:
  • tables/mozilla/core/table_frame-expected.checksum:
  • tables/mozilla/core/table_frame-expected.png:
  • tables/mozilla/core/table_heights-expected.checksum:
  • tables/mozilla/core/table_heights-expected.png:
  • tables/mozilla/core/table_widths-expected.checksum:
  • tables/mozilla/core/table_widths-expected.png:
  • tables/mozilla/dom/appendCol2-expected.checksum:
  • tables/mozilla/dom/appendCol2-expected.png:
  • tables/mozilla/dom/appendRowsExpand1-expected.checksum:
  • tables/mozilla/dom/appendRowsExpand1-expected.png:
  • tables/mozilla/dom/appendTbodyExpand1-expected.checksum:
  • tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • tables/mozilla/dom/deleteCellsRebuild1-expected.checksum:
  • tables/mozilla/dom/deleteCellsRebuild1-expected.png:
  • tables/mozilla/dom/deleteCellsShrink1-expected.checksum:
  • tables/mozilla/dom/deleteCellsShrink1-expected.png:
  • tables/mozilla/dom/deleteCellsShrink2-expected.checksum:
  • tables/mozilla/dom/deleteCellsShrink2-expected.png:
  • tables/mozilla/dom/deleteCol1-expected.checksum:
  • tables/mozilla/dom/deleteCol1-expected.png:
  • tables/mozilla/dom/deleteCol2-expected.checksum:
  • tables/mozilla/dom/deleteCol2-expected.png:
  • tables/mozilla/dom/deleteCol3-expected.checksum:
  • tables/mozilla/dom/deleteCol3-expected.png:
  • tables/mozilla/dom/deleteColGroup1-expected.checksum:
  • tables/mozilla/dom/deleteColGroup1-expected.png:
  • tables/mozilla/dom/deleteColGroup2-expected.checksum:
  • tables/mozilla/dom/deleteColGroup2-expected.png:
  • tables/mozilla/dom/deleteRowsRebuild1-expected.checksum:
  • tables/mozilla/dom/deleteRowsRebuild1-expected.png:
  • tables/mozilla/dom/deleteRowsShrink1-expected.checksum:
  • tables/mozilla/dom/deleteRowsShrink1-expected.png:
  • tables/mozilla/dom/deleteTbodyExpand1-expected.checksum:
  • tables/mozilla/dom/deleteTbodyExpand1-expected.png:
  • tables/mozilla/dom/deleteTbodyRebuild1-expected.checksum:
  • tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
  • tables/mozilla/dom/insertCellsExpand1-expected.checksum:
  • tables/mozilla/dom/insertCellsExpand1-expected.png:
  • tables/mozilla/dom/insertCellsExpand2-expected.checksum:
  • tables/mozilla/dom/insertCellsExpand2-expected.png:
  • tables/mozilla/dom/insertCellsRebuild1-expected.checksum:
  • tables/mozilla/dom/insertCellsRebuild1-expected.png:
  • tables/mozilla/dom/insertCellsRebuild2-expected.checksum:
  • tables/mozilla/dom/insertCellsRebuild2-expected.png:
  • tables/mozilla/dom/insertColGroups1-expected.checksum:
  • tables/mozilla/dom/insertColGroups1-expected.png:
  • tables/mozilla/dom/insertColGroups2-expected.checksum:
  • tables/mozilla/dom/insertColGroups2-expected.png:
  • tables/mozilla/dom/insertCols1-expected.checksum:
  • tables/mozilla/dom/insertCols1-expected.png:
  • tables/mozilla/dom/insertCols2-expected.checksum:
  • tables/mozilla/dom/insertCols2-expected.png:
  • tables/mozilla/dom/insertCols3-expected.checksum:
  • tables/mozilla/dom/insertCols3-expected.png:
  • tables/mozilla/dom/insertCols4-expected.checksum:
  • tables/mozilla/dom/insertCols4-expected.png:
  • tables/mozilla/dom/insertCols5-expected.checksum:
  • tables/mozilla/dom/insertCols5-expected.png:
  • tables/mozilla/dom/insertRowsExpand1-expected.checksum:
  • tables/mozilla/dom/insertRowsExpand1-expected.png:
  • tables/mozilla/dom/insertRowsRebuild1-expected.checksum:
  • tables/mozilla/dom/insertRowsRebuild1-expected.png:
  • tables/mozilla/dom/tableDom-expected.checksum:
  • tables/mozilla/dom/tableDom-expected.png:
  • tables/mozilla/marvin/body_col-expected.checksum:
  • tables/mozilla/marvin/body_col-expected.png:
  • tables/mozilla/marvin/col_span-expected.checksum:
  • tables/mozilla/marvin/col_span-expected.png:
  • tables/mozilla/marvin/colgroup_align_center-expected.checksum:
  • tables/mozilla/marvin/colgroup_align_center-expected.png:
  • tables/mozilla/marvin/colgroup_align_justify-expected.checksum:
  • tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • tables/mozilla/marvin/colgroup_align_left-expected.checksum:
  • tables/mozilla/marvin/colgroup_align_left-expected.png:
  • tables/mozilla/marvin/colgroup_align_right-expected.checksum:
  • tables/mozilla/marvin/colgroup_align_right-expected.png:
  • tables/mozilla/marvin/colgroup_span-expected.checksum:
  • tables/mozilla/marvin/colgroup_span-expected.png:
  • tables/mozilla/marvin/colgroup_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • tables/mozilla/marvin/colgroup_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • tables/mozilla/marvin/colgroup_valign_middle-expected.checksum:
  • tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • tables/mozilla/marvin/colgroup_valign_top-expected.checksum:
  • tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • tables/mozilla/marvin/table_frame_border-expected.checksum:
  • tables/mozilla/marvin/table_frame_border-expected.png:
  • tables/mozilla/marvin/table_frame_box-expected.checksum:
  • tables/mozilla/marvin/table_frame_box-expected.png:
  • tables/mozilla/marvin/table_overflow_hidden_td-expected.checksum:
  • tables/mozilla/marvin/table_overflow_hidden_td-expected.png:
  • tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.checksum:
  • tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • tables/mozilla/marvin/table_row_align_center-expected.checksum:
  • tables/mozilla/marvin/table_row_align_center-expected.png:
  • tables/mozilla/marvin/table_row_align_left-expected.checksum:
  • tables/mozilla/marvin/table_row_align_left-expected.png:
  • tables/mozilla/marvin/table_row_align_right-expected.checksum:
  • tables/mozilla/marvin/table_row_align_right-expected.png:
  • tables/mozilla/marvin/table_rules_all-expected.checksum:
  • tables/mozilla/marvin/table_rules_all-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_aqua-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_aqua-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_black-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_black-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_blue-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_blue-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_gray-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_gray-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_green-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_green-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_lime-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_lime-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_maroon-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_maroon-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_navy-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_navy-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_olive-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_olive-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_purple-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_purple-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_red-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_red-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_silver-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_silver-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_teal-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_teal-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_white-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_white-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_yellow-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_yellow-expected.png:
  • tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.checksum:
  • tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png:
  • tables/mozilla/marvin/tables_border_1-expected.checksum:
  • tables/mozilla/marvin/tables_border_1-expected.png:
  • tables/mozilla/marvin/tables_border_2-expected.checksum:
  • tables/mozilla/marvin/tables_border_2-expected.png:
  • tables/mozilla/marvin/tables_border_3-expected.checksum:
  • tables/mozilla/marvin/tables_border_3-expected.png:
  • tables/mozilla/marvin/tables_caption_align_bot-expected.checksum:
  • tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • tables/mozilla/marvin/tables_caption_align_top-expected.checksum:
  • tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • tables/mozilla/marvin/tables_cellpadding-expected.checksum:
  • tables/mozilla/marvin/tables_cellpadding-expected.png:
  • tables/mozilla/marvin/tables_cellpadding_pct-expected.checksum:
  • tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • tables/mozilla/marvin/tables_class-expected.checksum:
  • tables/mozilla/marvin/tables_class-expected.png:
  • tables/mozilla/marvin/tables_id-expected.checksum:
  • tables/mozilla/marvin/tables_id-expected.png:
  • tables/mozilla/marvin/tables_row_th_nowrap-expected.checksum:
  • tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • tables/mozilla/marvin/tables_style-expected.checksum:
  • tables/mozilla/marvin/tables_style-expected.png:
  • tables/mozilla/marvin/tables_td_align_center-expected.checksum:
  • tables/mozilla/marvin/tables_td_align_center-expected.png:
  • tables/mozilla/marvin/tables_td_align_left-expected.checksum:
  • tables/mozilla/marvin/tables_td_align_left-expected.png:
  • tables/mozilla/marvin/tables_td_align_right-expected.checksum:
  • tables/mozilla/marvin/tables_td_align_right-expected.png:
  • tables/mozilla/marvin/tables_td_colspan-expected.checksum:
  • tables/mozilla/marvin/tables_td_colspan-expected.png:
  • tables/mozilla/marvin/tables_td_height-expected.checksum:
  • tables/mozilla/marvin/tables_td_height-expected.png:
  • tables/mozilla/marvin/tables_td_nowrap-expected.checksum:
  • tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • tables/mozilla/marvin/tables_td_rowspan-expected.checksum:
  • tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • tables/mozilla/marvin/tables_td_width-expected.checksum:
  • tables/mozilla/marvin/tables_td_width-expected.png:
  • tables/mozilla/marvin/tables_th_align_center-expected.checksum:
  • tables/mozilla/marvin/tables_th_align_center-expected.png:
  • tables/mozilla/marvin/tables_th_align_left-expected.checksum:
  • tables/mozilla/marvin/tables_th_align_left-expected.png:
  • tables/mozilla/marvin/tables_th_align_right-expected.checksum:
  • tables/mozilla/marvin/tables_th_align_right-expected.png:
  • tables/mozilla/marvin/tables_th_colspan-expected.checksum:
  • tables/mozilla/marvin/tables_th_colspan-expected.png:
  • tables/mozilla/marvin/tables_th_height-expected.checksum:
  • tables/mozilla/marvin/tables_th_height-expected.png:
  • tables/mozilla/marvin/tables_th_rowspan-expected.checksum:
  • tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • tables/mozilla/marvin/tables_th_width-expected.checksum:
  • tables/mozilla/marvin/tables_th_width-expected.png:
  • tables/mozilla/marvin/tbody_align_center-expected.checksum:
  • tables/mozilla/marvin/tbody_align_center-expected.png:
  • tables/mozilla/marvin/tbody_align_char-expected.checksum:
  • tables/mozilla/marvin/tbody_align_char-expected.png:
  • tables/mozilla/marvin/tbody_align_justify-expected.checksum:
  • tables/mozilla/marvin/tbody_align_justify-expected.png:
  • tables/mozilla/marvin/tbody_align_left-expected.checksum:
  • tables/mozilla/marvin/tbody_align_left-expected.png:
  • tables/mozilla/marvin/tbody_align_right-expected.checksum:
  • tables/mozilla/marvin/tbody_align_right-expected.png:
  • tables/mozilla/marvin/tbody_char-expected.checksum:
  • tables/mozilla/marvin/tbody_char-expected.png:
  • tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • tables/mozilla/marvin/tbody_valign_top-expected.png:
  • tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/td_valign_baseline-expected.png:
  • tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/td_valign_bottom-expected.png:
  • tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • tables/mozilla/marvin/td_valign_middle-expected.png:
  • tables/mozilla/marvin/td_valign_top-expected.checksum:
  • tables/mozilla/marvin/td_valign_top-expected.png:
  • tables/mozilla/marvin/tfoot_align_center-expected.checksum:
  • tables/mozilla/marvin/tfoot_align_center-expected.png:
  • tables/mozilla/marvin/tfoot_align_char-expected.checksum:
  • tables/mozilla/marvin/tfoot_align_char-expected.png:
  • tables/mozilla/marvin/tfoot_align_justify-expected.checksum:
  • tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • tables/mozilla/marvin/tfoot_align_left-expected.checksum:
  • tables/mozilla/marvin/tfoot_align_left-expected.png:
  • tables/mozilla/marvin/tfoot_align_right-expected.checksum:
  • tables/mozilla/marvin/tfoot_align_right-expected.png:
  • tables/mozilla/marvin/tfoot_char-expected.checksum:
  • tables/mozilla/marvin/tfoot_char-expected.png:
  • tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/th_valign_baseline-expected.png:
  • tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/th_valign_bottom-expected.png:
  • tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • tables/mozilla/marvin/th_valign_middle-expected.png:
  • tables/mozilla/marvin/th_valign_top-expected.checksum:
  • tables/mozilla/marvin/th_valign_top-expected.png:
  • tables/mozilla/marvin/thead_align_center-expected.checksum:
  • tables/mozilla/marvin/thead_align_center-expected.png:
  • tables/mozilla/marvin/thead_align_char-expected.checksum:
  • tables/mozilla/marvin/thead_align_char-expected.png:
  • tables/mozilla/marvin/thead_align_justify-expected.checksum:
  • tables/mozilla/marvin/thead_align_justify-expected.png:
  • tables/mozilla/marvin/thead_align_left-expected.checksum:
  • tables/mozilla/marvin/thead_align_left-expected.png:
  • tables/mozilla/marvin/thead_align_right-expected.checksum:
  • tables/mozilla/marvin/thead_align_right-expected.png:
  • tables/mozilla/marvin/thead_char-expected.checksum:
  • tables/mozilla/marvin/thead_char-expected.png:
  • tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • tables/mozilla/marvin/thead_valign_middle-expected.png:
  • tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • tables/mozilla/marvin/thead_valign_top-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_black-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_black-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_blue-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_gray-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_green-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_green-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_lime-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_maroon-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_navy-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_olive-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_purple-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_red-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_red-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_silver-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_teal-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_white-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_white-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_yellow-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
  • tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.checksum:
  • tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
  • tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • tables/mozilla/marvin/tr_valign_middle-expected.png:
  • tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • tables/mozilla/marvin/tr_valign_top-expected.png:
  • tables/mozilla/marvin/x_caption_align_bottom-expected.checksum:
  • tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • tables/mozilla/marvin/x_caption_align_top-expected.checksum:
  • tables/mozilla/marvin/x_caption_align_top-expected.png:
  • tables/mozilla/marvin/x_caption_class-expected.checksum:
  • tables/mozilla/marvin/x_caption_class-expected.png:
  • tables/mozilla/marvin/x_caption_id-expected.checksum:
  • tables/mozilla/marvin/x_caption_id-expected.png:
  • tables/mozilla/marvin/x_caption_style-expected.checksum:
  • tables/mozilla/marvin/x_caption_style-expected.png:
  • tables/mozilla/marvin/x_col_align_center-expected.checksum:
  • tables/mozilla/marvin/x_col_align_center-expected.png:
  • tables/mozilla/marvin/x_col_align_char-expected.checksum:
  • tables/mozilla/marvin/x_col_align_char-expected.png:
  • tables/mozilla/marvin/x_col_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_col_align_justify-expected.png:
  • tables/mozilla/marvin/x_col_align_left-expected.checksum:
  • tables/mozilla/marvin/x_col_align_left-expected.png:
  • tables/mozilla/marvin/x_col_align_right-expected.checksum:
  • tables/mozilla/marvin/x_col_align_right-expected.png:
  • tables/mozilla/marvin/x_col_span-expected.checksum:
  • tables/mozilla/marvin/x_col_span-expected.png:
  • tables/mozilla/marvin/x_col_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_col_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_col_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • tables/mozilla/marvin/x_col_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_col_valign_top-expected.png:
  • tables/mozilla/marvin/x_col_width_pct-expected.checksum:
  • tables/mozilla/marvin/x_col_width_pct-expected.png:
  • tables/mozilla/marvin/x_col_width_px-expected.checksum:
  • tables/mozilla/marvin/x_col_width_px-expected.png:
  • tables/mozilla/marvin/x_col_width_rel-expected.checksum:
  • tables/mozilla/marvin/x_col_width_rel-expected.png:
  • tables/mozilla/marvin/x_colgroup_align_center-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • tables/mozilla/marvin/x_colgroup_align_char-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • tables/mozilla/marvin/x_colgroup_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • tables/mozilla/marvin/x_colgroup_align_left-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_align_left-expected.png:
  • tables/mozilla/marvin/x_colgroup_align_right-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_align_right-expected.png:
  • tables/mozilla/marvin/x_colgroup_span-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_span-expected.png:
  • tables/mozilla/marvin/x_colgroup_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_colgroup_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_colgroup_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • tables/mozilla/marvin/x_colgroup_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • tables/mozilla/marvin/x_colgroup_width_rel-expected.checksum:
  • tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • tables/mozilla/marvin/x_table_align_center-expected.checksum:
  • tables/mozilla/marvin/x_table_align_center-expected.png:
  • tables/mozilla/marvin/x_table_align_left-expected.checksum:
  • tables/mozilla/marvin/x_table_align_left-expected.png:
  • tables/mozilla/marvin/x_table_align_right-expected.checksum:
  • tables/mozilla/marvin/x_table_align_right-expected.png:
  • tables/mozilla/marvin/x_table_bgcolor_name-expected.checksum:
  • tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • tables/mozilla/marvin/x_table_border-expected.checksum:
  • tables/mozilla/marvin/x_table_border-expected.png:
  • tables/mozilla/marvin/x_table_border_px-expected.checksum:
  • tables/mozilla/marvin/x_table_border_px-expected.png:
  • tables/mozilla/marvin/x_table_cellpadding-expected.checksum:
  • tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • tables/mozilla/marvin/x_table_cellpadding_pct-expected.checksum:
  • tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • tables/mozilla/marvin/x_table_cellspacing-expected.checksum:
  • tables/mozilla/marvin/x_table_cellspacing-expected.png:
  • tables/mozilla/marvin/x_table_cellspacing_pct-expected.checksum:
  • tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • tables/mozilla/marvin/x_table_class-expected.checksum:
  • tables/mozilla/marvin/x_table_class-expected.png:
  • tables/mozilla/marvin/x_table_id-expected.checksum:
  • tables/mozilla/marvin/x_table_id-expected.png:
  • tables/mozilla/marvin/x_table_width_pct-expected.checksum:
  • tables/mozilla/marvin/x_table_width_pct-expected.png:
  • tables/mozilla/marvin/x_table_width_px-expected.checksum:
  • tables/mozilla/marvin/x_table_width_px-expected.png:
  • tables/mozilla/marvin/x_tbody_align_center-expected.checksum:
  • tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • tables/mozilla/marvin/x_tbody_align_char-expected.checksum:
  • tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • tables/mozilla/marvin/x_tbody_align_left-expected.checksum:
  • tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • tables/mozilla/marvin/x_tbody_align_right-expected.checksum:
  • tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • tables/mozilla/marvin/x_tbody_class-expected.checksum:
  • tables/mozilla/marvin/x_tbody_class-expected.png:
  • tables/mozilla/marvin/x_tbody_id-expected.checksum:
  • tables/mozilla/marvin/x_tbody_id-expected.png:
  • tables/mozilla/marvin/x_tbody_style-expected.checksum:
  • tables/mozilla/marvin/x_tbody_style-expected.png:
  • tables/mozilla/marvin/x_tbody_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_tbody_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_tbody_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • tables/mozilla/marvin/x_tbody_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • tables/mozilla/marvin/x_td_align_center-expected.checksum:
  • tables/mozilla/marvin/x_td_align_center-expected.png:
  • tables/mozilla/marvin/x_td_align_char-expected.checksum:
  • tables/mozilla/marvin/x_td_align_char-expected.png:
  • tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_td_align_justify-expected.png:
  • tables/mozilla/marvin/x_td_align_left-expected.checksum:
  • tables/mozilla/marvin/x_td_align_left-expected.png:
  • tables/mozilla/marvin/x_td_align_right-expected.checksum:
  • tables/mozilla/marvin/x_td_align_right-expected.png:
  • tables/mozilla/marvin/x_td_bgcolor_name-expected.checksum:
  • tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • tables/mozilla/marvin/x_td_bgcolor_rgb-expected.checksum:
  • tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • tables/mozilla/marvin/x_td_class-expected.checksum:
  • tables/mozilla/marvin/x_td_class-expected.png:
  • tables/mozilla/marvin/x_td_colspan-expected.checksum:
  • tables/mozilla/marvin/x_td_colspan-expected.png:
  • tables/mozilla/marvin/x_td_height-expected.checksum:
  • tables/mozilla/marvin/x_td_height-expected.png:
  • tables/mozilla/marvin/x_td_id-expected.checksum:
  • tables/mozilla/marvin/x_td_id-expected.png:
  • tables/mozilla/marvin/x_td_nowrap-expected.checksum:
  • tables/mozilla/marvin/x_td_nowrap-expected.png:
  • tables/mozilla/marvin/x_td_rowspan-expected.checksum:
  • tables/mozilla/marvin/x_td_rowspan-expected.png:
  • tables/mozilla/marvin/x_td_style-expected.checksum:
  • tables/mozilla/marvin/x_td_style-expected.png:
  • tables/mozilla/marvin/x_td_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_td_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_td_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • tables/mozilla/marvin/x_td_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_td_valign_top-expected.png:
  • tables/mozilla/marvin/x_td_width-expected.checksum:
  • tables/mozilla/marvin/x_td_width-expected.png:
  • tables/mozilla/marvin/x_tfoot_align_center-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • tables/mozilla/marvin/x_tfoot_align_char-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • tables/mozilla/marvin/x_tfoot_align_left-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • tables/mozilla/marvin/x_tfoot_align_right-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • tables/mozilla/marvin/x_tfoot_class-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_class-expected.png:
  • tables/mozilla/marvin/x_tfoot_id-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_id-expected.png:
  • tables/mozilla/marvin/x_tfoot_style-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_style-expected.png:
  • tables/mozilla/marvin/x_tfoot_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_tfoot_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_tfoot_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • tables/mozilla/marvin/x_tfoot_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • tables/mozilla/marvin/x_th_align_center-expected.checksum:
  • tables/mozilla/marvin/x_th_align_center-expected.png:
  • tables/mozilla/marvin/x_th_align_char-expected.checksum:
  • tables/mozilla/marvin/x_th_align_char-expected.png:
  • tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_th_align_justify-expected.png:
  • tables/mozilla/marvin/x_th_align_left-expected.checksum:
  • tables/mozilla/marvin/x_th_align_left-expected.png:
  • tables/mozilla/marvin/x_th_align_right-expected.checksum:
  • tables/mozilla/marvin/x_th_align_right-expected.png:
  • tables/mozilla/marvin/x_th_bgcolor_name-expected.checksum:
  • tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • tables/mozilla/marvin/x_th_bgcolor_rgb-expected.checksum:
  • tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • tables/mozilla/marvin/x_th_class-expected.checksum:
  • tables/mozilla/marvin/x_th_class-expected.png:
  • tables/mozilla/marvin/x_th_colspan-expected.checksum:
  • tables/mozilla/marvin/x_th_colspan-expected.png:
  • tables/mozilla/marvin/x_th_height-expected.checksum:
  • tables/mozilla/marvin/x_th_height-expected.png:
  • tables/mozilla/marvin/x_th_id-expected.checksum:
  • tables/mozilla/marvin/x_th_id-expected.png:
  • tables/mozilla/marvin/x_th_nowrap-expected.checksum:
  • tables/mozilla/marvin/x_th_nowrap-expected.png:
  • tables/mozilla/marvin/x_th_rowspan-expected.checksum:
  • tables/mozilla/marvin/x_th_rowspan-expected.png:
  • tables/mozilla/marvin/x_th_style-expected.checksum:
  • tables/mozilla/marvin/x_th_style-expected.png:
  • tables/mozilla/marvin/x_th_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_th_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_th_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_th_valign_middle-expected.png:
  • tables/mozilla/marvin/x_th_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_th_valign_top-expected.png:
  • tables/mozilla/marvin/x_th_width-expected.checksum:
  • tables/mozilla/marvin/x_th_width-expected.png:
  • tables/mozilla/marvin/x_thead_align_center-expected.checksum:
  • tables/mozilla/marvin/x_thead_align_center-expected.png:
  • tables/mozilla/marvin/x_thead_align_char-expected.checksum:
  • tables/mozilla/marvin/x_thead_align_char-expected.png:
  • tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • tables/mozilla/marvin/x_thead_align_left-expected.checksum:
  • tables/mozilla/marvin/x_thead_align_left-expected.png:
  • tables/mozilla/marvin/x_thead_align_right-expected.checksum:
  • tables/mozilla/marvin/x_thead_align_right-expected.png:
  • tables/mozilla/marvin/x_thead_class-expected.checksum:
  • tables/mozilla/marvin/x_thead_class-expected.png:
  • tables/mozilla/marvin/x_thead_id-expected.checksum:
  • tables/mozilla/marvin/x_thead_id-expected.png:
  • tables/mozilla/marvin/x_thead_style-expected.checksum:
  • tables/mozilla/marvin/x_thead_style-expected.png:
  • tables/mozilla/marvin/x_thead_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_thead_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_thead_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • tables/mozilla/marvin/x_thead_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • tables/mozilla/marvin/x_tr_align_center-expected.checksum:
  • tables/mozilla/marvin/x_tr_align_center-expected.png:
  • tables/mozilla/marvin/x_tr_align_char-expected.checksum:
  • tables/mozilla/marvin/x_tr_align_char-expected.png:
  • tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • tables/mozilla/marvin/x_tr_align_left-expected.checksum:
  • tables/mozilla/marvin/x_tr_align_left-expected.png:
  • tables/mozilla/marvin/x_tr_align_right-expected.checksum:
  • tables/mozilla/marvin/x_tr_align_right-expected.png:
  • tables/mozilla/marvin/x_tr_bgcolor_name-expected.checksum:
  • tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.checksum:
  • tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • tables/mozilla/marvin/x_tr_class-expected.checksum:
  • tables/mozilla/marvin/x_tr_class-expected.png:
  • tables/mozilla/marvin/x_tr_id-expected.checksum:
  • tables/mozilla/marvin/x_tr_id-expected.png:
  • tables/mozilla/marvin/x_tr_style-expected.checksum:
  • tables/mozilla/marvin/x_tr_style-expected.png:
  • tables/mozilla/marvin/x_tr_valign_baseline-expected.checksum:
  • tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • tables/mozilla/marvin/x_tr_valign_bottom-expected.checksum:
  • tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • tables/mozilla/marvin/x_tr_valign_middle-expected.checksum:
  • tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • tables/mozilla/marvin/x_tr_valign_top-expected.checksum:
  • tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • tables/mozilla/other/body_col-expected.checksum:
  • tables/mozilla/other/body_col-expected.png:
  • tables/mozilla/other/cell_widths-expected.checksum:
  • tables/mozilla/other/cell_widths-expected.png:
  • tables/mozilla/other/cellspacing-expected.checksum:
  • tables/mozilla/other/cellspacing-expected.png:
  • tables/mozilla/other/nested2-expected.checksum:
  • tables/mozilla/other/nested2-expected.png:
  • tables/mozilla/other/nestedTables-expected.checksum:
  • tables/mozilla/other/nestedTables-expected.png:
  • tables/mozilla/other/padding-expected.checksum:
  • tables/mozilla/other/padding-expected.png:
  • tables/mozilla/other/test3-expected.checksum:
  • tables/mozilla/other/test3-expected.png:
  • tables/mozilla/other/test6-expected.checksum:
  • tables/mozilla/other/test6-expected.png:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • tables/mozilla/other/wa_table_tr_align-expected.checksum:
  • tables/mozilla/other/wa_table_tr_align-expected.png:
  • tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • tables/mozilla_expected_failures/bugs/97619-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • tables/mozilla_expected_failures/bugs/bug101759-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • tables/mozilla_expected_failures/bugs/bug10216-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug106336-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug106336-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1128-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug11384s-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1164-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1164-expected.png:
  • tables/mozilla_expected_failures/bugs/bug11945-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1262-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1262-expected.png:
  • tables/mozilla_expected_failures/bugs/bug131020-3-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14007-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14323-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14323-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14489-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1647-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • tables/mozilla_expected_failures/bugs/bug18440-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug18440-expected.png:
  • tables/mozilla_expected_failures/bugs/bug18770-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • tables/mozilla_expected_failures/bugs/bug19526-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • tables/mozilla_expected_failures/bugs/bug21518-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • tables/mozilla_expected_failures/bugs/bug22246-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug22246-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug22246-2a-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug22246-2a-expected.png:
  • tables/mozilla_expected_failures/bugs/bug22246-3-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug22246-3-expected.png:
  • tables/mozilla_expected_failures/bugs/bug22246-3a-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug22246-3a-expected.png:
  • tables/mozilla_expected_failures/bugs/bug222846-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug222846-expected.png:
  • tables/mozilla_expected_failures/bugs/bug23847-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • tables/mozilla_expected_failures/bugs/bug24880-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug25707-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • tables/mozilla_expected_failures/bugs/bug27993-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug27993-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3105-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3105-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-8-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • tables/mozilla_expected_failures/bugs/bug32205-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug32205-4-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • tables/mozilla_expected_failures/bugs/bug42043-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • tables/mozilla_expected_failures/bugs/bug4294-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • tables/mozilla_expected_failures/bugs/bug46268-4-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • tables/mozilla_expected_failures/bugs/bug51000-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • tables/mozilla_expected_failures/bugs/bug56024-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug59252-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • tables/mozilla_expected_failures/bugs/bug61042-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug61042-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug65372-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • tables/mozilla_expected_failures/bugs/bug7113-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug7113-expected.png:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • tables/mozilla_expected_failures/bugs/bug73629-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug8499-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug9879-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum:
  • tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
  • tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • tables/mozilla_expected_failures/core/col_span2-expected.png:
  • tables/mozilla_expected_failures/core/cols1-expected.checksum:
  • tables/mozilla_expected_failures/core/cols1-expected.png:
  • tables/mozilla_expected_failures/core/columns-expected.checksum:
  • tables/mozilla_expected_failures/core/columns-expected.png:
  • tables/mozilla_expected_failures/core/conflicts-expected.checksum:
  • tables/mozilla_expected_failures/core/conflicts-expected.png:
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum:
  • tables/mozilla_expected_failures/core/table_rules-expected.png:
  • tables/mozilla_expected_failures/dom/appendCells1-expected.checksum:
  • tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.checksum:
  • tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • tables/mozilla_expected_failures/dom/appendCol1-expected.checksum:
  • tables/mozilla_expected_failures/dom/appendCol1-expected.png:
  • tables/mozilla_expected_failures/dom/appendColGroup1-expected.checksum:
  • tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.checksum:
  • tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.checksum:
  • tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum:
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png:
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum:
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_above-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_below-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_void-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • tables/mozilla_expected_failures/marvin/table_rules_cols-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.png:
  • tables/mozilla_expected_failures/marvin/table_rules_rows-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.checksum:
  • tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.checksum:
  • tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
  • tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png:
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png:
  • tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.checksum:
  • tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
  • tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
  • tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • tables/mozilla_expected_failures/other/test4-expected.checksum:
  • tables/mozilla_expected_failures/other/test4-expected.png:
5:39 PM Changeset in webkit [13911] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8270, text highlights outside of textfield when it shouldn't.

Reviewed by darin

Added fast/forms/input-double-click-selection-gap-bug.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):
5:37 PM Changeset in webkit [13910] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

new layout test for input selection bug.

5:12 PM Changeset in webkit [13909] by thatcher
  • 1 copy in tags/WebCore-315.14.2/WebCore

New tag (part 2).

5:11 PM Changeset in webkit [13908] by thatcher
  • 1 copy in tags/JavaScriptCore-312.3.2/JavaScriptCore

New tag (part 2).

5:10 PM Changeset in webkit [13907] by thatcher
  • 1 add in tags/JavaScriptCore-312.3.2

New tag (part 1).

5:09 PM Changeset in webkit [13906] by thatcher
  • 1 add in tags/WebCore-315.14.2

New tag (part 1).

5:08 PM Changeset in webkit [13905] by thatcher
  • 4 edits in branches/Safari-1-3-branch

Versioning

5:04 PM Changeset in webkit [13904] by thatcher
  • 5 edits in branches/Safari-1-3-branch

JavaScriptCore:

Merged fix from TOT to Safari-1-3-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

  • bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto
  • bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().

WebCore:

Merged fix from TOT to Safari-1-3-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)

Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.


  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::windowScriptNPObject): Removed the check Darin added to return 0 when JavaScript is disabled. This method cannot return 0, because plugins are not guaranteed to check for that. Removed my old fix for Radar 4428609 (7015) in favor of a better solution. Instead of creating a "dummy" JSObject to represent the window script object when JavaScript is disabled, we use the new JavaScriptCore bindings API to create a "no script" NPObject. This solution is better because it does not cause entry into any JavaScript interpreter code.
  • manual-tests/NPN_Invoke: Added.
  • manual-tests/NPN_Invoke/English.lproj: Added.
  • manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
  • manual-tests/NPN_Invoke/Info.plist: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
  • manual-tests/NPN_Invoke/main.c: Added.
  • manual-tests/NPN_Invoke/test.html: Added.
4:11 PM Changeset in webkit [13903] by justing
  • 2 edits in trunk/LayoutTests/editing/pasteboard

These pixel results were generated before Hyatt checked in his caret-off-by-one fix.

3:19 PM Changeset in webkit [13902] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 8848, caret off by 1 pixel on numerous pixel tests.

Reviewed by darin

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect):
3:04 PM Changeset in webkit [13901] by thatcher
  • 23 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4506601> TOT WebCore fails to build ppc64

Switch many CG calls to use CGFloat for colors and gradients

  • bindings/objc/DOMCSS.mm: (-[DOMRGBColor dealloc]): cast _internal to uintptr_t (-[DOMRGBColor finalize]): cast _internal to uintptr_t (-[DOMRGBColor red]): cast _internal to uintptr_t (-[DOMRGBColor green]): cast _internal to uintptr_t (-[DOMRGBColor blue]): cast _internal to uintptr_t (-[DOMRGBColor alpha]): cast _internal to uintptr_t (-[DOMRGBColor _color]): cast _internal to uintptr_t
  • bridge/mac/FrameMac.mm: (WebCore::regExpForLabels): use CFIndex as the type returned from indexOfObject:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): workaround for <rdar://problem/4509035>
  • config.h: define CGFloat if it isn't defined already
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop): (WebCore::gradientCallback): (WebCore::CanvasGradient::platformShading):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::alphaImageForImage): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask):
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: (WebCore::scratchContext):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::cgGradientCallback): (WebCore::CGShadingRefForLinearGradient): (WebCore::CGShadingRefForRadialGradient): (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientStopsCache):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (WebCore::):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
  • kwq/WebCoreAXObject.mm: (CreateCGColorIfDifferent):
  • platform/Color.cpp: (WebCore::Color::getRGBA): new name, was getRgbaF. getRGBA uses float and has a double overload
  • platform/Color.h:
  • platform/mac/ClipboardMac.h: no need to define NSDragOperation
  • platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):
  • platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode):
2:18 PM Changeset in webkit [13900] by mjs
  • 2 edits in branches/treecode/JavaScriptCore
  • fix a comment per Geoff's suggestion
  • kjs/TreeCode.cpp: (KJS::InterpreterImp::runInterpreterLoop):
2:15 PM Changeset in webkit [13899] by jdevalk
  • 2 edits in trunk/WebKitSite

Removed passwords and username for blog from SVN and included from elsewhere on server.

2:11 PM Changeset in webkit [13898] by mjs
  • 7 edits in branches/treecode/JavaScriptCore

Reviewed by Geoff.


  • make for..in work again
  • kjs/Opcode.h:
  • kjs/TreeCode.cpp: (KJS::isExecuteOpcode): (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (ForInNode::ForInNode):
  • kjs/nodes.h: (KJS::VarDeclNode::VarDeclNode::VarDeclNode): (KJS::ForInInitEndNode::ForInInitEndNode): (KJS::ForInUpdateEndNode::ForInUpdateEndNode): (KJS::ForInPropSourceEndNode::ForInPropSourceEndNode): (KJS::SwapNode::SwapNode): (KJS::Rotate3Node::Rotate3Node):
  • kjs/nodes2string.cpp: (ForInNode::streamTo):
1:38 PM Changeset in webkit [13897] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Scripts/run-iexploder-tests: Added a --get option to save a test into a file.
1:14 PM Changeset in webkit [13896] by justing
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8402>
Fix interchange newline handling and avoid use of test rendering info

  • editing/pasteboard/interchange-newline-1-expected.checksum: Added.
  • editing/pasteboard/interchange-newline-1-expected.png: Added.
  • editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • editing/pasteboard/interchange-newline-1.html: Added.
  • editing/pasteboard/interchange-newline-2-expected.checksum: Added.
  • editing/pasteboard/interchange-newline-2-expected.png: Added.
  • editing/pasteboard/interchange-newline-2-expected.txt: Added.
  • editing/pasteboard/interchange-newline-2.html: Added.
  • editing/pasteboard/interchange-newline-3-expected.checksum: Added.
  • editing/pasteboard/interchange-newline-3-expected.png: Added.
  • editing/pasteboard/interchange-newline-3-expected.txt: Added.
  • editing/pasteboard/interchange-newline-3.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8402>
Fix interchange newline handling and avoid use of test rendering info

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Fixed bugs in handling of interchange newlines at the end of incoming fragments. Removed the use of !fragment.isBlockFlow since it isn't correct and relies on information gathered during the test insertion, which we're trying to get rid of.
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::rootEditableElement): Added for convenience.
9:29 AM Changeset in webkit [13895] by ap
  • 1 edit in trunk/WebKitTools/ChangeLog

Corrected bug number in ChangeLog.

9:27 AM Changeset in webkit [13894] by ap
  • 1 edit
    15 adds in trunk/WebKitTools

Reviewed by Darin.

This script generates artificially mangled HTML documents, to test that the browser
doesn't crash when handling ill-formed code.


How to use:

run-iexploder-tests Open an interactive test page in Safari+ToT.
run-iexploder-tests nnnnn Open test #nnnnn.

Command line options:

-guard-malloc (-g) Use Guard Malloc.
-port=nnnn Run Apache on port nnnn (default is 8000).

To save a crashing test, you can use curl while the crash reporter dialog is on the screen
(thus, Apache is still running), e.g.:

curl -o iexploder293.html "​http://127.0.0.1:8000/iexploder.cgi?lookup=1&test=293"

Additionally, there are some useful scripts in WebKitTools/iExploder/tools directory.

  • Scripts/run-iexploder-tests: Added.
  • iExploder: Added.
  • iExploder/LICENSE.txt: Added.
  • iExploder/README.txt: Added.
  • iExploder/htdocs: Added.
  • iExploder/htdocs/cssproperties.in: Added.
  • iExploder/htdocs/cssvalues.in: Added.
  • iExploder/htdocs/htmlattrs.in: Added.
  • iExploder/htdocs/htmltags.in: Added.
  • iExploder/htdocs/htmlvalues.in: Added.
  • iExploder/htdocs/iexploder.cgi: Added.
  • iExploder/htdocs/index.html: Added.
  • iExploder/tools: Added.
  • iExploder/tools/lasthit.rb: Added.
  • iExploder/tools/osx_last_crash.rb: Added.

Apr 16, 2006:

11:50 PM Changeset in webkit [13893] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/selection/extend-by-word-002-expected.checksum: Updated.
  • editing/selection/extend-by-word-002-expected.png: Updated.
  • fast/lists/markers-in-selection-expected.checksum: Added.
  • fast/lists/markers-in-selection-expected.png: Added.
  • fast/lists/markers-in-selection-expected.txt: Added.
  • fast/lists/markers-in-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/lists/markers-in-selection.html

  • rendering/RenderObject.h: Added selectionColorImageOverlayAlpha constant - the maximum opacity of the selection color when painted over images.
  • rendering/render_list.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::paint): Paint the selection highlight if selected: over the marker for image markers, under the marker for all other markers. (WebCore::RenderListMarker::setSelectionState): Added. (WebCore::RenderListMarker::selectionRect): Added. (WebCore::RenderListMarker::selectionColor): Added. Ensures that the selection color is transparent for image markers.
  • rendering/render_list.h: (WebCore::RenderListMarker::selectionState): (WebCore::RenderListMarker::canBeSelectionLeaf):
  • rendering/render_replaced.cpp (WebCore::RenderReplaced::selectionColor): Changed to use the selectionColorImageOverlayAlpha constant.
11:15 PM Changeset in webkit [13892] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/button-inner-block-reuse-expected.checksum: Added.
  • fast/forms/button-inner-block-reuse-expected.png: Added.
  • fast/forms/button-inner-block-reuse-expected.txt: Added.
  • fast/forms/button-inner-block-reuse.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/button-inner-block-reuse.html

Buttons have a distinguished anonymous child that holds all their other
descendants. Descendants ended up in a sibling anonymous block as the
initial anonymous child was being reused to hold the initial part of an
inline that got split.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): Check if the anonymous block's parent allows us to reuse it.
  • rendering/RenderObject.h: (WebCore::RenderObject::allowsReusingAnonymousChild): Added. Returns true.
  • rendering/render_button.h: (WebCore::RenderButton::allowsReusingAnonymousChild): Added. Returns false.
11:01 PM Changeset in webkit [13891] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/drop-text-without-selection-expected.checksum: Added.
  • editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • editing/pasteboard/drop-text-without-selection.html: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/drop-text-without-selection.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithText:]): Changed to allow creating a fragment regardless of the selection.
10:46 PM Changeset in webkit [13890] by darin
  • 11 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • bridge/mac/WebCoreFrameBridge.h:
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[KWQPopUpButton resignFirstResponder]): Cleaned up.
  • kwq/KWQListBox.mm: Ditto. (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder: and cleaned up. (-[KWQSlider resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[WebCoreTextView resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added call to formControlIsBecomingFirstResponder:.
  • manual-tests/textarea-focus.html: Added.

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): Added. Calls the ancestor WebHTMLView's _formControlIsBecomingFirstResponder:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState:]): If a descendant is becoming first responder, enable focused appearance. (-[WebHTMLView _formControlIsBecomingFirstResponder:]): Added. Calls _updateFocusState, causing the frame to display with focus attributes.
  • WebView/WebHTMLViewInternal.h:
10:34 PM Changeset in webkit [13889] by darin
  • 7 edits
    1 add in trunk/WebCore

Reviewed by Adele and Justin.

Calling SelectionController::nodeWillBeRemoved from Document::notifyBeforeNodeRemoval
fixes the crash, which was happening because the call that was removing the text
node, removeChildren, does not send a "node removed" mutation event (it sends a
"subtree modified" mutation event instead). So this change alone fixes the crash.

But I also changed setInnerText to not blow away the text node each time the value
is changed, and that makes the test case behave even better -- you don't even lose
the selection; it works as it did with the NSTextField-based text field.

  • manual-tests/input-empty-on-focus.html: Added.
  • page/Frame.h: Tweaked a few comments and functions related to selection.
  • page/Frame.cpp: (WebCore::Frame::dragCaret): Made non-const.
  • dom/Document.cpp: (WebCore::Document::notifyBeforeNodeRemoval): Call nodeWillBeRemoved on the two selection controllers before removing a node from the document.
  • editing/SelectionController.h: Tweak formatting. Remove MutationListener class and m_mutationListener field.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Remove code to set up the mutation event listener. (WebCore::SelectionController::setSelection): Remove code to maintain the mutation event listener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): In cases where the container has only a single child use replaceChild, and in cases where the HTML being inserted also has only a single child and both are text nodes use setData. It's common to use setInnerHTML to set something that's just text. (WebCore::HTMLElement::setInnerText): Same as above, but simpler since the thing we're replacing with is always text.
8:10 PM Changeset in webkit [13888] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • css/make-css-file-arrays.pl: Remove the "-" parameter from the invocation of cpp, which means "send output to stdout". It's optional on Mac OS X, and is causing a hang on Linux.
  • rendering/RenderArena.cpp: Added a missing include of <assert.h>.
2:36 PM Changeset in webkit [13887] by jdevalk
  • 3 edits in trunk/WebKitSite
  • Small textual change to my contact info;
  • Added bugreporting URL for non ADC members.
2:22 PM Changeset in webkit [13886] by jdevalk
  • 2 edits in trunk/WebKitSite

Added info on CIA, trac, build bot and webkit-unassigned

2:29 AM Changeset in webkit [13885] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (crashHandler): Added a handler for signals that are raised on a crash. Keeping separate from the existing handler for manual interruption (SIGINT/SIGHUP/SIGTERM), because I'm trying to find a way to prevent the Crash Reporter dialog from appearing on crash, and this code may change significantly.

(main): Install crashHandler.

(setDefaultColorProfileToRGB): Properly convert CFStringRef to a char buffer
(CFStringGetCStringPtr should NEVER EVER be used!).

Apr 15, 2006:

8:05 PM Changeset in webkit [13884] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/install-win-extras: Try to fix the Windows build by fixing the URLs here. Seems xmlsoft.org's HTTP no longer has what we need.
7:28 PM Changeset in webkit [13883] by darin
  • 2 edits in trunk/WebCore
  • removed references to a couple files that are obsolete but were still in the Windows project file
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove kjs_views.h and .cpp.
7:20 PM Changeset in webkit [13882] by mjs
  • 8 edits
    1 move in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • rename InterpreterState to Opcode
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/InterpreterState.h: Removed.
  • kjs/Opcode.h: Added. (KJS::):
  • kjs/TreeCode.cpp: (KJS::): (KJS::isEvaluateOpcode): (KJS::isEvaluateListOpcode): (KJS::isExecuteState): (KJS::pushEvaluate): (KJS::pushEvaluateList): (KJS::pushExecute): (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp: (KJS::printUnwindBarrier): (KJS::InterpreterImp::printStateStack): (KJS::InterpreterImp::unwindToNextBarrier):
  • kjs/internal.h: (KJS::InterpreterImp::State::State):
  • kjs/nodes.cpp: (Node::Node):
  • kjs/nodes.h: (KJS::Node::opcode): (KJS::ExprNode::ExprNode): (KJS::StatementNode::StatementNode): (KJS::JumpNode::JumpNode): (KJS::ForExprEndNode::ForExprEndNode):
6:26 PM Changeset in webkit [13881] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • more results for tests landed without pixel-test results
  • fast/text/whitespace/pre-newline-box-test-expected.checksum: Added.
  • fast/text/whitespace/pre-newline-box-test-expected.png: Added.
12:27 PM Changeset in webkit [13880] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Use isEmpty() instead of isNull() for checking the domain to determine if the document in a local file.
11:13 AM Changeset in webkit [13879] by darin
  • 1 edit
    7 adds in trunk/LayoutTests
  • added some results for some tests people added without expected results
  • svg/custom/class-selector-expected.txt: Added.
  • svg/custom/class-selector-expected.checksum: Added.
  • svg/custom/class-selector-expected.png: Added.
  • editing/selection/extend-by-sentence-001-expected.checksum: Added.
  • editing/selection/extend-by-sentence-001-expected.png: Added.
  • fast/dom/Element/null-offset-parent-expected.checksum: Added.
  • fast/dom/Element/null-offset-parent-expected.png: Added.
11:10 AM Changeset in webkit [13878] by darin
  • 2 edits in trunk/LayoutTests
  • updated a layout test result for Hyatt's prefix change
  • fast/inspector/style-expected.txt: Some background properties now have the "-webkit" prefix.

Apr 14, 2006:

10:38 PM Changeset in webkit [13877] by thatcher
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Adds a category to WebScriptObject with array accessors for KVC/KVO.

If super valueForKey: fails it will call valueForUndefinedKey:, which is
important because it causes the right behavior to happen with bindings using
the "Raises for Not Applicable Keys" flag and the "Not Applicable Placeholder"

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject valueForKey:]): (-[WebScriptObject count]): (-[WebScriptObject objectAtIndex:]): (-[WebUndefined description]): return "undefined"

WebKit:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Added a controller class, WebController, that is a subclass of
NSTreeController that has a new outlet/binding for the WebView.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]): notify bindings about the document change
  • WebView/WebView.m: (-[WebView _progressStarted:]): notify bindings about the document change (-[WebView _finalProgressComplete]): notify bindings about the document change (-[WebView _declaredKeys]): added a key for the main frame document (-[WebController init]): (-[WebController exposedBindings]): (-[WebController valueClassForBinding:]): (-[WebController setContent:]): (-[WebController webView]): (-[WebController setWebView:]): (-[WebView mainFrameDocument]): get the main frame's DOMDocument
  • WebView/WebViewPrivate.h: Adds mainFrameDocument to pending public.
5:53 PM Changeset in webkit [13876] by mjs
  • 1 edit
    1 add in branches/treecode/JavaScriptCore
  • missing part of last commit
  • kjs/Expr.h: Added.
5:28 PM Changeset in webkit [13875] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore/kjs

Mark the list stack, fix assertion hit when collector runs out of memory. r=mjs

3:50 PM Changeset in webkit [13874] by hyatt
  • 31 edits in trunk/WebCore

CSS vendor-specific property/value cleanup. Properly qualify background-clip,
background-origin, border-image and the border-radius properties. Make sure
our overflow extensions of marquee and overlay are qualified as well. Rename
the -khtml- extension to -webkit.

Reviewed by beth

  • bindings/js/kjs_css.cpp: (KJS::cssPropertyName):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): (-[DOMCSSStyleDeclaration _setFontSizeDelta:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _setAutofilled:]):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForTextAlign): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSGrammar.y:
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/css_valueimpl.cpp: (WebCore::):
  • css/css_valueimpl.h:
  • css/cssparser.cpp: (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseBackgroundProperty): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseShadow):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/html4.css:
  • css/quirks.css:
  • css/tokenizer.flex:
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::removeInlineStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::blockPlaceholderClassString):
  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode):
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::addHTMLAlignment): (WebCore::HTMLElement::setContentEditable):
  • html/html_blockimpl.cpp: (WebCore::HTMLDivElement::parseMappedAttribute): (WebCore::HTMLParagraphElement::parseMappedAttribute): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/html_inlineimpl.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
  • html/html_tableimpl.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::canMouseDownStartSelect):
  • page/Frame.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
3:01 PM Changeset in webkit [13873] by eseidel
  • 3 edits in trunk/WebCore

2006-04-14 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Fix win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • page/FramePrivate.h:
2:37 PM Changeset in webkit [13872] by eseidel
  • 4 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix build-warnings in cairo code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8176

  • platform/cairo/cairo/src/cairo-win32-surface.c: (_cairo_win32_print_gdi_error): (_cairo_win32_surface_create_for_dc): (_composite_alpha_blend): (cairo_win32_surface_create):
  • platform/cairo/pixman/src/iccolor.c: (pixman_pixel_to_color):
2:25 PM Changeset in webkit [13871] by mjs
  • 1 edit in branches/treecode/JavaScriptCore/ChangeLog

Updated ChangeLog to note this:

Makes treecode branch 10% faster.

2:25 PM Changeset in webkit [13870] by mjs
  • 11 edits in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • changed expression grammar production rules to make flattened output


Expressions now form lists instead of trees, so that use of the
state stack can be avoided.

  • kjs/InterpreterState.h:
  • kjs/TreeCode.cpp: (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/internal.h: (KJS::Stack::fromLast): (KJS::Stack::swapLastTwo):
  • kjs/lexer.cpp:
  • kjs/nodes.cpp: (Node::throwError): (ForNode::processVarDecls): (ForInNode::ForInNode):
  • kjs/nodes.h: (KJS::ExprNode::ExprNode): (KJS::ExprNode::next): (KJS::ExprStatementEndNode::ExprStatementEndNode): (KJS::ExprStatementEndNode::streamTo): (KJS::ArgumentEndNode::ArgumentEndNode): (KJS::ArgumentEndNode::streamTo): (KJS::PropertyEndNode::PropertyEndNode): (KJS::PropertyEndNode::streamTo): (KJS::ElementEndNode::ElementEndNode): (KJS::ElementEndNode::streamTo): (KJS::NullNode::NullNode): (KJS::BooleanNode::BooleanNode): (KJS::NumberNode::NumberNode): (KJS::StringNode::StringNode): (KJS::RegExpNode::RegExpNode): (KJS::ThisNode::ThisNode): (KJS::ResolveNode::ResolveNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyNode::PropertyNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::BracketAccessorNode::BracketAccessorNode): (KJS::BracketAccessorNode::isBracketAccessorNode): (KJS::DotAccessorNode::DotAccessorNode): (KJS::DotAccessorNode::isDotAccessorNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentListNode::streamTo): (KJS::ArgumentsNode::streamTo): (KJS::NewExprNode::NewExprNode): (KJS::FunctionCallNode::FunctionCallNode): (KJS::PostfixNode::PostfixNode): (KJS::PostfixBracketNode::PostfixBracketNode): (KJS::DeleteNode::DeleteNode): (KJS::DeleteBracketNode::DeleteBracketNode): (KJS::DeleteValueNode::DeleteValueNode): (KJS::VoidNode::VoidNode): (KJS::TypeOfResolveNode::TypeOfResolveNode): (KJS::TypeOfValueNode::TypeOfValueNode): (KJS::PrefixNode::PrefixNode): (KJS::PrefixBracketNode::PrefixBracketNode): (KJS::UnaryPlusNode::UnaryPlusNode): (KJS::NegateNode::NegateNode): (KJS::BitwiseNotNode::BitwiseNotNode): (KJS::LogicalNotNode::LogicalNotNode): (KJS::MultNode::MultNode): (KJS::AddNode::AddNode): (KJS::ShiftNode::ShiftNode): (KJS::RelationalNode::RelationalNode): (KJS::EqualNode::EqualNode): (KJS::BitOperNode::BitOperNode): (KJS::JumpNode::JumpNode): (KJS::NoOpNode::NoOpNode): (KJS::ReadModifyAssignNode::ReadModifyAssignNode): (KJS::AssignNode::AssignNode): (KJS::ReadModifyAssignBracketNode::ReadModifyAssignBracketNode): (KJS::AssignBracketNode::AssignBracketNode): (KJS::CommaNode::CommaNode): (KJS::VarDeclNode::VarDeclNode::VarDeclNode): (KJS::VarDeclEndNode::VarDeclEndNode): (KJS::VarDeclEndNode::streamTo): (KJS::ExprStatementNode::ExprStatementNode): (KJS::IfConditionEndNode::IfConditionEndNode): (KJS::IfConditionEndNode::streamTo): (KJS::DoWhileTestExprEndNode::DoWhileTestExprEndNode): (KJS::DoWhileTestExprEndNode::streamTo): (KJS::WhileTestExprEndNode::WhileTestExprEndNode): (KJS::WhileTestExprEndNode::streamTo): (KJS::ForNode::ForNode): (KJS::ForExprEndNode::ForExprEndNode): (KJS::ForExprEndNode::streamTo): (KJS::ReturnNode::ReturnNode): (KJS::ValueReturnEndNode::ValueReturnEndNode): (KJS::WithExprEndNode::WithExprEndNode): (KJS::WithExprEndNode::streamTo): (KJS::ThrowEndNode::ThrowEndNode): (KJS::FuncExprNode::FuncExprNode):
  • kjs/nodes2string.cpp: (ExprNode::streamTo): (ReturnNode::streamTo):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): bug fix (doIt): fix to avoid false positive leak reports (kjsmain): ditto
1:22 AM Changeset in webkit [13869] by hyatt
  • 2696 edits
    2 adds in trunk/LayoutTests

Land updated layout tests.

1:15 AM Changeset in webkit [13868] by hyatt
  • 13 edits in trunk/WebCore

Fix for 8333, make sure newlines in whitespace:pre (and friends) get
line boxes created for them. This resolves all the weird selection/navigation
issues that arise by not creating lines (and thus not having navigable positions
on those lines).

This checkin is also removing all of the layout test hacks that have piled
up, so layout test results are being regenerated completely.

Reviewed by eric

  • dom/Position.cpp: (WebCore::Position::downstream):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • kwq/RenderTreeAsText.cpp: (getTagName): (operator<<):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): (WebCore::InlineTextBox::isLineBreak): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h:
  • rendering/RenderBR.cpp:
  • rendering/RenderBR.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::atLineWrap): (WebCore::RenderText::caretRect): (WebCore::RenderText::height): (WebCore::RenderText::inlineBox):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/render_line.h: (WebCore::InlineBox::isLineBreak):

Apr 13, 2006:

6:17 PM Changeset in webkit [13867] by darin
  • 5 edits
    2 copies
    8 moves in trunk/WebCore

Reviewed by Geoff.

  • moved a few things out of kwq and cleaned up the Java-applet-related renderers
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file location and name changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/JavaAppletWidget.h: Moved.
  • kwq/JavaAppletWidget.mm: Moved.
  • kwq/RegularExpression.cpp: Moved.
  • kwq/RegularExpression.h: Moved.
  • kwq/RenderTreeAsText.cpp: Moved.
  • kwq/RenderTreeAsText.h: Moved.
  • rendering/render_applet.cpp: Moved.
  • rendering/render_applet.h: Moved.
  • bridge/JavaAppletWidget.h: Moved here.
  • bridge/mac/JavaAppletWidget.mm: Moved here.
  • platform/RegularExpression.cpp: Moved here.
  • platform/RegularExpression.h: Moved here.
  • rendering/RenderTreeAsText.cpp: Moved here.
  • rendering/RenderTreeAsText.h: Moved here.
  • rendering/RenderApplet.h: Moved here and made changes. Removed unused element() function.
  • rendering/RenderApplet.cpp: Moved here and made changes. (WebCore::RenderApplet::RenderApplet): Changed parameter type to be more precise (HTMLAppletElement). (WebCore::RenderApplet::intrinsicWidth): Removed unnecessary type cast and simplified. (WebCore::RenderApplet::intrinsicHeight): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Straightened out the if statements and changed to use node() instead of element(). (WebCore::RenderApplet::layout): Removed unneeded check before calling createWidgetIfNecessary.
  • rendering/RenderEmptyApplet.h: Moved here and made changes. Removed unneeded overrides of intrinsicWidth and intrinsicHeight.
  • rendering/RenderEmptyApplet.cpp: Moved here and made changes. (WebCore::RenderEmptyApplet::RenderEmptyApplet): Added code to set the intrinsic width and height.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): Initialize m_widget with contructor syntax. (WebCore::RenderWidget::paint): Changed _tx and _ty to be just tx and ty. Rearranged the code so the transparent wash will draw even if m_widget is 0.
  • html/html_objectimpl.cpp: Update includes for new file names.
4:06 PM Changeset in webkit [13866] by eseidel
  • 10 edits in branches/treecode/JavaScriptCore

Removed (most) macros from TreeCode.cpp
Removed Imp from state names
Removed Interpreter ring (using interpreter map instead)
Removed push/pop/peek accessors for stacks.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8363
Reviewed by Darin.

2:24 PM Changeset in webkit [13865] by ggaren
  • 29 edits
    8 adds
    4 deletes in trunk

JavaScriptCore:

Reviewed by Darin.

  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject): Add the built-in object prototype to the end of the global object's prototype chain instead of just blowing away its existing prototype. We need to do this because the window object has a meaningful prototype now.

LayoutTests:

Layout test for document.defaultView

  • fast/dom/defaultView-expected.txt: Added.
  • fast/dom/defaultView.html: Added.
  • fast/events/event-view-toString-expected.txt: Updated to reflect new prototype chain for defaultView.

WebCore:

Reviewed by Darin.

  • Fixed <rdar://problem/4478467> document.defaultView should return the window object


Also made part of the window object autogenerated by IDL file.


  • DerivedSources.make: Added /page to IDL file search path, added JSDOMWindow.h, removed kjs_views.lut.h
  • WebCore.xcodeproj/project.pbxproj: Added missing files, removed obsolete files
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • bindings/js/kjs_views.cpp: Removed.
  • bindings/js/kjs_views.h: Removed.
  • bindings/js/kjs_window.cpp: Removed document property -- it now belongs to JSDOMWindow. Added toJS and toDOMWindow. (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::getValueProperty): (KJS::Window::clear): Added call to setPrototype to ensure that the prototype gets cleared during navigation. (Previously this wasn't an issue because the window object had no real prototype.) (WebCore::toJS): (WebCore::toDOMWindow):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/objc/DOMCSS.mm: Added NULL checks for the AbstractView (Presumably this is an issue after the window is closed.) Typedef-ed AbstractView as DOMWindow. I could have just replaced AbstractView with DOMWindow, but I think it's clearer to say, "There's this thing called the AbstractView, but really it's just the window." (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMViews.mm:
  • bindings/objc/DOMViewsInternal.h:
  • bindings/scripts/CodeGeneratorJS.pm: Removed unused GetLegacyImplementationIncludes. Added support for DOMWindow and new "DoNotCache" attribute. Replaced C macros with text because (1) it makes the generated source easier to read and debug and (2) it made it much easier to implement the DoNotCache attribute.
  • bindings/scripts/IDLParser.pm: Return a hash reference instead of a hash, because otherwise an interface with more than one attribute returns too many arguments to be processed.
  • bridge/mac/FrameMac.mm:
  • dom/AbstractView.cpp: Removed.
  • dom/AbstractView.h: Removed.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultView):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/Position.cpp:
  • dom/UIEvent.idl:
  • dom/dom2_eventsimpl.h:
  • page/DOMWindow.cpp: Added. (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::document): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules):
  • page/DOMWindow.h: Added.
  • page/DOMWindow.idl: Added.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Disconnect the new DOMWindow object in addition to the Window object. Maybe we can unify this in the future. (WebCore::Frame::tree): (WebCore::Frame::domWindow):
  • page/Frame.h:
  • page/FramePrivate.h:
1:52 PM Changeset in webkit [13864] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

  • projects/compat/hitlist.html: Added Google Calendar to the list in place of www.hangseng.com/ebanking
10:03 AM Changeset in webkit [13863] by ap
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

  • html/HTMLTokenizer.cpp: Only use fixUpChar() when handling entities. (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convert): Remove the special case for Latin-1, because it is already handled via effectiveEncoding().
  • platform/StreamingTextDecoder.h: Remove convertLatin1().

LayoutTests:

Tests that Latin-1 is handled as windows-1252
(see ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7602). Some existing tests
already did cover this, but only indirectly.

  • fast/encoding/latin1-winlatin-expected.txt: Added.
  • fast/encoding/latin1-winlatin.html: Added.
8:50 AM Changeset in webkit [13862] by darin
  • 2 edits in trunk/WebCore
  • platform/mac/GraphicsContextMac.mm: Fix one no-SVG compile problem by adding a "using namespace std".
3:33 AM Changeset in webkit [13861] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • fix testkjs to not show false-positive KJS::Node leaks in debug builds
  • kjs/testkjs.cpp: (doIt): (kjsmain):
12:48 AM Changeset in webkit [13860] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Refining the list of renames to be done soon.

12:07 AM Changeset in webkit [13859] by darin
  • 54 edits
    1 delete in trunk/WebCore

Rubber-stamped by Anders.

  • fix Windows build
  • WebCore.vcproj/Image\ Viewer/Image\ Viewer.vcproj: Add loader directory.
  • use std::min/max exclusively intead of kMin/Max
  • eliminate KWQDef.h since all it had left in it was kMin/Max
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove KWQDef.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/KWQDef.h: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • dom/Document.cpp: (WebCore::Document::minimumLayoutDelay): (WebCore::Document::addMarker):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::readOutBytes):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::CharacterIterator::string): (WebCore::findPlainText):
  • editing/htmlediting.cpp: (WebCore::rangeCompliantEquivalent):
  • editing/markup.cpp: (WebCore::renderedText):
  • editing/visible_units.cpp: (WebCore::startOfParagraph):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer):
  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion):
  • html/html_tableimpl.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQSlider.mm: (QSlider::setValue):
  • loader/Cache.cpp: (WebCore::Cache::setSize):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • platform/DeprecatedPtrListImpl.h:
  • platform/DeprecatedString.cpp: (ucstrcmp):
  • platform/DeprecatedString.h:
  • platform/DeprecatedValueListImpl.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::addRoundedRectClip):
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView _trackResizeFromMouseDown:]):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::isSelected): (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::selectionStartEnd): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::nearestFloatBottom): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlocminMaxWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcMinMaxWidth): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::absoluteBoundingBox): (WebCore::Marquee::marqueeSpeed): (WebCore::Marquee::computePosition): (WebCore::Marquee::timerFired):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::minXPos): (WebCore::RenderText::width): (WebCore::RenderText::caretMinOffset): (WebCore::RenderText::caretMaxOffset):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkLinesForOverflow):
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderSelect::layout): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_line.h: (WebCore::RootInlineBox::selectionHeight):
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::shouldPaint):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): Use min/max instead of kMin/kMax.

Apr 12, 2006:

11:32 PM Changeset in webkit [13858] by darin
  • 97 edits
    18 deletes in trunk/WebCore

Rubber-stamped by Anders.

  • get ready for some more de-KWQ-ing done by the renaming script in two ways

1) stop using forwarding headers for things within WebCore
2) remove a bit of unused stuff

  • loader/CachedImage.h:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • xml/XSLTProcessor.cpp: Removed unused showAnimations functions and data. We can add back later if we need it. And if we do, we won't use a typedef from KHTMLSettings.
  • ForwardingHeaders/java: Removed.
  • ForwardingHeaders/java/kjavaappletwidget.h: Removed.
  • ForwardingHeaders/khtml_settings.h: Removed.
  • ForwardingHeaders/kio: Removed.
  • ForwardingHeaders/kio/global.h: Removed.
  • ForwardingHeaders/ksslkeygen.h: Removed.
  • ForwardingHeaders/q3ptrlist.h: Removed.
  • ForwardingHeaders/q3valuelist.h: Removed.
  • ForwardingHeaders/qcombobox.h: Removed.
  • ForwardingHeaders/qfontmetrics.h: Removed.
  • ForwardingHeaders/qlineedit.h: Removed.
  • ForwardingHeaders/qmatrix.h: Removed.
  • ForwardingHeaders/qptrlist.h: Removed.
  • ForwardingHeaders/qptrqueue.h: Removed.
  • ForwardingHeaders/qregexp.h: Removed.
  • ForwardingHeaders/qscrollbar.h: Removed.
  • ForwardingHeaders/qtextedit.h: Removed.
  • ForwardingHeaders/qtextstream.h: Removed.
  • ForwardingHeaders/qvaluelist.h: Removed.
  • ForwardingHeaders/qwmatrix.h: Removed.
  • WebCore+SVG/DOMList.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/css_valueimpl.h:
  • css/cssstyleselector.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/EventTargetNode.cpp:
  • dom/Node.cpp:
  • editing/BreakBlockquoteCommand.h:
  • editing/htmlediting.cpp:
  • html/FormDataList.h:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLTokenizer.h:
  • html/html_objectimpl.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQKHTMLSettings.h:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/Decoder.cpp:
  • loader/FormData.h:
  • loader/loader.h:
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/Font.cpp:
  • platform/SegmentedString.h:
  • platform/mac/FontMac.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderBlock.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
  • rendering/render_applet.cpp:
  • rendering/render_form.cpp:
  • rendering/render_form.h:
  • rendering/render_frames.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.cpp: Updated includes.
  • WebCore.xcodeproj/project.pbxproj: Resorted a couple things.
10:43 PM Changeset in webkit [13857] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Plans for another round of renaming (eliminating KWQ).

8:19 PM Changeset in webkit [13856] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Fixes the build.

7:00 PM Changeset in webkit [13855] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Layout test for the changes made to VisiblePosition::init in r13825.


  • editing/selection/unrendered-space.html
  • editing/selection/unrendered-space-expected.png
  • editing/selection/unrendered-space-expected.checksum
  • editing/selection/unrendered-space-expected.txt
6:50 PM Changeset in webkit [13854] by adele
  • 24 edits
    2 adds in trunk

LayoutTests:

Test for setSelectionRange bug in text fields.

  • fast/forms/input-delete-expected.txt: Added.
  • fast/forms/input-delete.html: Added.

WebCore:

Reviewed by Darin and Tim O.

WebCore part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8061
REGRESSION: New text fields need to send callbacks used by autocomplete

Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8156
FrameMac::submitForm is busted after Vector changes

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): Use boundingBox method so this no longer relies on an NSTextField. The old code is no longer needed because this method was used by autocomplete, and that was not enabled for password or search fields. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): New implementation that uses setValue and setSelectionRange instead of NSTextField specific code. (-[DOMHTMLInputElement _selectedRange]): Creates range by calling selectionStart and selectionEnd on the input element. (-[DOMHTMLInputElement _setAutofilled:]): Provides a way for the autofill code to set a flag on the input element so it knows when its value is set by autofill. This is how we change the background color.
  • bindings/objc/DOMPrivate.h: Removed _displayedValue, _setDisplayedValue, _setBackgroundColor since these are no longer needed for the new text field implementation, and aren't used for remaining NSView-style password and search fields. Added _setAutofilled method.
  • bridge/mac/FrameMac.h: Added virtual clearRecordedFormValues and recordFormValue. These were moved into Frame.cpp recently, which broke how Safari asked to add form values to the keychain.
  • bridge/mac/FrameMac.mm: (WebCore::createNSDictionary): Added. Converts a hashmap to an NSDictionary for m_formValuesAboutToBeSubmitted. This is needed to fix the submit form bug. (WebCore::selectorForKeyEvent): Added. This helper function converts key events into selectors that the autocomplete code needs to know about. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): Convert saved form and formValues into DOMElement and NSMutableDictionary. (WebCore::FrameMac::textFieldDidBeginEditing): Added so the input element can send this notification over the bridge. (WebCore::FrameMac::textFieldDidEndEditing): ditto. (WebCore::FrameMac::textDidChangeInTextField): ditto. (WebCore::FrameMac::doTextFieldCommandFromEvent): ditto. Also calls selectorForKeyEvent. (WebCore::FrameMac::textWillBeDeletedInTextField): ditto.
  • page/Frame.cpp: (WebCore::Frame::textFieldDidBeginEditing): ditto. (WebCore::Frame::textFieldDidEndEditing): ditto. (WebCore::Frame::textDidChangeInTextField): ditto. (WebCore::Frame::doTextFieldCommandFromEvent): ditto. (WebCore::Frame::textWillBeDeletedInTextField): ditto.
  • page/Frame.h: ditto.
  • platform/PlatformString.h: (WebCore::String::replace): Added to use an existing version of StringImpl::replace.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Setting the selection here should close the typing command. (WebCore::RenderTextField::subtreeHasChanged): Calls textDidChangeInTextField.
  • dom/Document.cpp: (WebCore::Document::setFocusNode): Calls dispatchFocusEvent and dispatchBlurEvent instead of directly dispatching the events. This gives the node a chance to do other work before dispatching the event.
  • dom/EventTargetNode.cpp:
(WebCore
EventTargetNode::dispatchFocusEvent): Added.
(WebCore
EventTargetNode::dispatchBlurEvent): Added.
  • dom/EventTargetNode.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): initializes m_autofilled. (WebCore::HTMLInputElement::dispatchFocusEvent): Calls textFieldDidBeginEditing and then calls up to the base class (WebCore::HTMLInputElement::dispatchBlurEvent): Calls textFieldDidEndEditing and then calls up to the base class (WebCore::HTMLInputElement::defaultEventHandler): For keypress events, calls doTextFieldCommandFromEvent so the form delegate will have a chance to say whether or not it is going to handle the event.

(WebCore::HTMLInputElement::isKeyboardFocusable): Uses isNonWidgetTextField instead of checking the inputType.

(WebCore::HTMLInputElement::isMouseFocusable): ditto.
(WebCore::HTMLInputElement::focus): ditto.
(WebCore::HTMLInputElement::constrainValue): Uses isTextField instead of checking inputType.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): ditto.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField): Added. Checks for TEXT, PASSWORD, and SEARCH (WebCore::HTMLInputElement::isNonWidgetTextField): Added. Checks for all converted controls. (WebCore::HTMLInputElement::autofilled): Added. (WebCore::HTMLInputElement::setAutofilled): Added.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Uses isNonWidgetTextField instead of checking the inputType.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): If the deletion is occuring in a text field, call textWillBeDeletedInTextField so the frame can call across the bridge to notify the form delegate.
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType): Added autofill string for "-khtml-autofill".
  • css/css_base.h: (WebCore::CSSSelector::): Added PseudoAutofill to enum.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added case for PseudoAutofill that checks the input element's autofilled flag. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/html4.css: Added background-color and background-image for input:-khtml-autofill style. Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/CSSValueKeywords.in: ditto.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto. (WebCore::CSSParser::parseShadow): ditto.
6:31 PM Changeset in webkit [13853] by justing
  • 110 edits in trunk

LayoutTests:

Reviewed by hyatt



  • css1/basic/class_as_selector-expected.txt:
  • css1/basic/containment-expected.txt:
  • css1/basic/contextual_selectors-expected.txt:
  • css1/basic/id_as_selector-expected.txt:
  • css1/box_properties/border_bottom-expected.txt:
  • css1/box_properties/border_left-expected.txt:
  • css1/box_properties/border_right_inline-expected.txt:
  • css1/box_properties/border_top-expected.txt:
  • css1/box_properties/clear_float-expected.txt:
  • css1/box_properties/margin-expected.txt:
  • css1/box_properties/margin_bottom-expected.txt:
  • css1/box_properties/margin_left-expected.txt:
  • css1/box_properties/margin_right-expected.txt:
  • css1/box_properties/margin_top-expected.txt:
  • css1/box_properties/padding_left-expected.txt:
  • css1/box_properties/padding_right-expected.txt:
  • css1/cascade/cascade_order-expected.txt:
  • css1/classification/display-expected.txt:
  • css1/classification/list_style-expected.txt:
  • css1/classification/list_style_image-expected.txt:
  • css1/classification/list_style_position-expected.txt:
  • css1/classification/list_style_type-expected.txt:
  • css1/conformance/forward_compatible_parsing-expected.txt:
  • css1/pseudo/anchor-expected.txt:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • css2.1/t0505-c16-descendant-01-e-expected.txt:
  • css2.1/t050803-c14-classes-00-e-expected.txt:
  • css2.1/t0509-c15-ids-01-e-expected.txt:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-01-b-expected.txt:
  • css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/selectNode-expected.txt:
  • editing/selection/selectNodeContents-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • fast/block/float/014-expected.txt:
  • fast/css-generated-content/009-expected.txt:
  • fast/css/001-expected.txt:
  • fast/css/001-expected.png:
  • fast/css/001-expected.checksum:
  • fast/css/continuationCrash-expected.txt:
  • fast/css/list-outline-expected.txt:
  • fast/doctypes/001-expected.txt:
  • fast/doctypes/002-expected.txt:
  • fast/doctypes/003-expected.txt:
  • fast/doctypes/004-expected.txt:
  • fast/dom/window-onFocus-expected.txt:
  • fast/forms/form-hides-table-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/lists/001-expected.checksum:
  • fast/lists/001-expected.png:
  • fast/lists/001-expected.txt:
  • fast/lists/002-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/lists/004-expected.txt:
  • fast/lists/005-expected.txt:
  • fast/lists/006-expected.txt:
  • fast/lists/007-expected.txt:
  • fast/lists/008-expected.txt:
  • fast/lists/009-expected.txt:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/li-br-expected.txt:
  • fast/lists/ol-display-types-expected.txt:
  • fast/lists/olstart-expected.txt:
  • fast/lists/scrolled-marker-paint-expected.txt:
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/selectors/001-expected.txt:
  • fast/selectors/013-expected.txt:
  • fast/selectors/015-expected.txt:
  • fast/selectors/166-expected.txt:
  • fast/table/018-expected.txt:
  • fast/table/form-with-table-style-expected.txt:
  • fast/text/whitespace/tab-character-basics-expected.txt:
  • fast/tokenizer/004-expected.txt:
  • tables/mozilla/bugs/bug23235-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug3191-expected.txt:
  • tables/mozilla/bugs/bug32205-2-expected.txt:
  • tables/mozilla/marvin/backgr_index-expected.txt:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/x_table-expected.txt:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:

WebCore:

Reviewed by hyatt



  • manual-tests/list-marker-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Call positionListMarker() after laying out the children. (WebCore::RenderBlock::calcInlineMinMaxWidth): Call calcWidth() on the child if we are going to use its marginLeft() or marginRight(), which is if they are given as a percentage or if the child is a list marker.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionListMarker): Added this virtual function which RenderListItem implements and which is called from layoutBlock().
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Avoid adding focus rings around outside list markers. Previously it did not matter since the markers had zero width.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Outside list markers should not contribute to the line width, even now that they have width.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Skip outside list markers.
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker): Added. (WebCore::RenderListMarker::paint): Removed code that was used to right-align outside text markers, since that is achieved by margins now. (WebCore::RenderListMarker::calcMinMaxWidth): Changed the marker height to be the font height. Made the width of outside list markers non-zero and equal to the width of inside markers. Changed the width to include only the marker and not any padding. Increased the width of bullets by 2 to contain spillage due to antialiasing. (WebCore::RenderListMarker::calcWidth): Calculate horizontal margins. Padding that was previously included in the width is now part of the margins. (WebCore::RenderListMarker::getRelativeMarkerRect): Adjusted for the changes to width and margins.
  • rendering/render_list.h:
5:36 PM Changeset in webkit [13852] by darin
  • 3 edits
    14 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved some more files out of KWQ to more-permanent homes
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/BlockExceptions.h: Removed.
  • kwq/BlockExceptions.mm: Removed.
  • kwq/ClipboardMac.h: Removed.
  • kwq/ClipboardMac.mm: Removed.
  • kwq/DeprecatedPtrList.h: Removed.
  • kwq/DeprecatedPtrListImpl.cpp: Removed.
  • kwq/DeprecatedPtrListImpl.h: Removed.
  • kwq/DeprecatedValueList.h: Removed.
  • kwq/DeprecatedValueListImpl.cpp: Removed.
  • kwq/DeprecatedValueListImpl.h: Removed.
  • kwq/WebCoreTextArea.h: Removed.
  • kwq/WebCoreTextArea.mm: Removed.
  • kwq/WebCoreTextField.h: Removed.
  • kwq/WebCoreTextField.mm: Removed.
  • platform/DeprecatedPtrList.h: Added.
  • platform/DeprecatedPtrListImpl.cpp: Added.
  • platform/DeprecatedPtrListImpl.h: Added.
  • platform/DeprecatedValueList.h: Added.
  • platform/DeprecatedValueListImpl.cpp: Added.
  • platform/DeprecatedValueListImpl.h: Added.
  • platform/mac/BlockExceptions.h: Added.
  • platform/mac/BlockExceptions.mm: Added.
  • platform/mac/ClipboardMac.h: Added.
  • platform/mac/ClipboardMac.mm: Added.
  • platform/mac/WebCoreTextArea.h: Added.
  • platform/mac/WebCoreTextArea.mm: Added.
  • platform/mac/WebCoreTextField.h: Added.
  • platform/mac/WebCoreTextField.mm: Added.
5:21 PM Changeset in webkit [13851] by harrison
  • 10 edits
    4 adds in trunk/LayoutTests

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

  • editing/editing.js: Add sentence navigation/selection.


  • editing/selection/extend-by-sentence-001-expected.txt: Added.
  • editing/selection/extend-by-sentence-001.html: Added. Test for both <rdar://problem/4386640> and <rdar://problem/4414575>.


  • fast/dom/inner-text-001-expected.txt: Added.
  • fast/dom/inner-text-001.html: Added. Tests innerText on a variety of elements.


  • fast/dom/HTMLObjectElement/form/test1-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/button-in-forms-collection-expected.txt:
  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/focus-expected.txt:
  • fast/forms/textarea-hard-linewrap-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/loader/loadInProgress-expected.txt: Updated for innerText changes that emit newlines for more kinds of blocks.
5:18 PM Changeset in webkit [13850] by harrison
  • 4 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app


(see related changes in WebCore)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray selectSentence:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h: Add sentence navigation and selection.
5:14 PM Changeset in webkit [13849] by harrison
  • 10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

AXPreviousSentenceStartTextMarkerForTextMarker failed to stop at the beginning a block because
SimplifiedBackwardsTextIterator::handleNonTextNode() emitted a space when exiting the block.
Fixed by emitting a newline instead.


Word boundary failed to stop at the beginning of a block because no character at all was emitted
when leaving the block, because the exitNode was checking specific html tags to decide whether the
node is block, but the node was xml. Fixed by using the node's renderer, if present.


(see related changes in WebKit)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Add sentence navigation/selection.


  • editing/Selection.cpp: (WebCore::Selection::validate): Add sentence navigation/selection.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify): Add sentence navigation/selection.
  • editing/TextGranularity.h: (WebCore::): Add SentenceGranularity and SentenceBoundary.
  • editing/TextIterator.cpp: (WebCore::isTableCell): (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlineForNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode): (WebCore::shouldEmitExtraNewlineForNode): New utility functions that prefer renderers over html tag names.

(WebCore::TextIterator::handleNonTextNode):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::advance):
Use new utility functions.


(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
Use new utility functions. Also emit linefeed instead of space,
so sentence parsing works across block boundaries.


(WebCore::SimplifiedBackwardsTextIterator::exitNode):
Use new utility functions.

(WebCore::SimplifiedBackwardsTextIterator::emitNewline):
Renamed from emitNewlineForBROrText because it is not always for BR or text.


  • editing/TextIterator.h: Renamed emitNewlineForBROrText to emitNewline.


  • editing/visible_units.cpp:
  • editing/visible_units.h: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Add sentence navigation/selection.
4:54 PM Changeset in webkit [13848] by darin
  • 11 edits
    4 copies
    1 move
    1 delete in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved Decoder and FormData classes into loader directory (Decoder, because it's part of the loading process.

FormData, because it's used as a parameter when specifying
what to load. Arguably either could be in page instead.)

  • moved Length.h from css to renderer, cause that's where Hyatt says it belongs
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml: Removed.
  • loader/Decoder.cpp: Added.
  • loader/Decoder.h: Added.
  • loader/FormData.cpp: Added.
  • loader/FormData.h: Added.
  • css/Length.h: Removed.
  • rendering/Length.h: Added.
  • bridge/mac/WebCoreEncodings.mm:
  • dom/Document.h:
  • kwq/KWQFormData.mm:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXSLStyleSheet.cpp:
  • page/ResourceRequest.h:
  • platform/TransferJobInternal.h:
  • xml/xmlhttprequest.cpp: Updated includes.
4:49 PM Changeset in webkit [13847] by darin
  • 2 edits in trunk/WebKitTools

Rubber-stamped by Darin.

  • BuildSlaveSupport/build-launcher-dmg: Use the -srcfolder option to 'hdiutil create'. This creates the initial disk image based on the size of the source folder, and copies the contents to the new disk image. The file extension on the temporary uncompressed disk image has also been altered from ".uncompressed" to ".uncompressed.dmg" as hdiutil on 10.4.6 Intel fails when the extension is not ".dmg".
4:13 PM Changeset in webkit [13846] by justing
  • 2 edits
    1 add in trunk/WebCore

Reviewed by darin

  • manual-tests/inline-outline-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Add the maximal outline width to the inlines' repaint rect.
4:01 PM Changeset in webkit [13845] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/misc

Fix broken test results.

2:54 PM Changeset in webkit [13844] by justing
  • 1 edit in trunk/WebCore/editing/JSEditor.cpp

Removed unnecessary check for an empty string.

2:51 PM Changeset in webkit [13843] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/deleting/merge-unrendered-space.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum: Added.
  • editing/execCommand/insertHorizontalRule-expected.png: Added.
  • editing/execCommand/insertHorizontalRule-expected.txt: Added.
  • editing/execCommand/insertHorizontalRule.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/JSEditor.cpp:
2:50 PM Changeset in webkit [13842] by eseidel
  • 1 copy in branches/treecode-stable

Make a "stable" copy of treecode, which ggaren and I can drive towards TOT, independent of mjs' re-working.

2:43 PM Changeset in webkit [13841] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Part of <rdar://problem/4482530>

  • WebView/WebView.m: (-[WebView _focusedFrame]): Fixed up the logic here to take into account immediate subviews of WebView, which are not actually in a WebFrameView (they are peers to the main frame's WebFrameView).
1:21 PM Changeset in webkit [13840] by hyatt
  • 7 edits in trunk/LayoutTests/fast

Land updated results for overflow changes.

1:02 PM Changeset in webkit [13839] by darin
  • 3 edits
    4 copies
    2 deletes in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved xsl files into xml directory, removed xbl files (for now)
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/xbl: Removed.
  • khtml/xsl: Removed.
  • xml/XSLStyleSheet.cpp: Added.
  • xml/XSLStyleSheet.h: Added.
  • xml/XSLTProcessor.cpp: Added.
  • xml/XSLTProcessor.h: Added.
12:52 PM Changeset in webkit [13838] by hyatt
  • 4 edits in trunk/WebCore

Fix for 5283, make sure overflow doesn't paint on top of positioned elements.

Reviewed by beth

  • kwq/RenderTreeAsText.cpp: (writeLayers):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyOverflowList): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isOverflowOnly): (WebCore::RenderLayer::overflowList):
11:31 AM Changeset in webkit [13837] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-12 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim H.

  • Scripts/update-webkit: Make this return non-zero when svn fails.
9:32 AM Changeset in webkit [13836] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Turn SVG support back on. I accidentally checked in this file with SVG off last night.
9:22 AM Changeset in webkit [13835] by darin
  • 4 edits in trunk/WebCore
  • try to fix Windows build
  • platform/TransferJobInternal.h: Declare HANDLE.
  • platform/image-decoders/gif/GIFImageReader.h: Include GIFImageDecoder.h.
  • rendering/RenderThemeWin.h: Declare HANDLE and HMODULE.
9:08 AM Changeset in webkit [13834] by darin
  • 3 edits in trunk/WebCore
  • another attempt to get things building
  • bindings/js/kjs_proxy.cpp: Add "kjs_events.h" include, needed when not building SVG (so for Windows too).
  • editing/TextIterator.h: Add back include of Vector.h.

Apr 11, 2006:

10:31 PM Changeset in webkit [13833] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Minor code cleanup -- passes all the JS tests.

  • kjs/object_object.cpp: (ObjectObjectImp::construct): (ObjectObjectImp::callAsFunction):
9:46 PM Changeset in webkit [13832] by darin
  • 9 edits in trunk

JavaScriptCore:

  • another attempt to fix Windows build -- Vector in Forward.h was not working
  • kxmlcore/Forward.h: Remove Vector.
  • kxmlcore/Vector.h: Add back default arguments, remove include of Forward.h.

WebCore:

  • try to fix Windows build
  • html/HTMLCollection.h: Add back include of Vector.h.
  • page/Frame.h: Ditto.
  • platform/Timer.h: Ditto.
  • more changes for no-SVG (not working yet though)
  • editing/CompositeEditCommand.h: Added css_valueimpl.h include.
9:15 PM Changeset in webkit [13831] by darin
  • 3 edits in trunk/WebCore
  • try to fix no-SVG build
  • kwq/RenderTreeAsText.cpp: Added back an include only needed for non-SVG.
  • rendering/RenderObject.h: Ditto.
9:07 PM Changeset in webkit [13830] by darin
  • 12 edits
    3 deletes in trunk

JavaScriptCore:

  • try to fix Windows build -- HashForward.h was not working
  • kxmlcore/HashForward.h: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove HashForward.h.
  • kjs/collector.h: Remove use of HashForward.h.
  • kxmlcore/HashCountedSet.h: Remove include of HashForward.h, restore default arguments.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.

JavaScriptGlue:

  • try to fix Windows build
  • kxmlcore/HashForward.h: Removed.

WebCore:

  • try to fix Windows build
  • ForwardingHeaders/kxmlcore/HashForward.h: Removed.
  • dom/xml_tokenizer.h: Include another header instead of HashForward.h.
  • loader/Cache.h: Ditto.
  • page/Page.h: Ditto.
  • platform/TransferJob.h: Ditto.
8:14 PM Changeset in webkit [13829] by justing
  • 2 edits in trunk
7:07 PM Changeset in webkit [13828] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

Added to test changes:

  • editing/pasteboard/merge-end-1-expected.checksum: Added.
  • editing/pasteboard/merge-end-1-expected.png: Added.
  • editing/pasteboard/merge-end-1-expected.txt: Added.
  • editing/pasteboard/merge-end-1.html: Added.
  • editing/pasteboard/merge-end-2-expected.checksum: Added.
  • editing/pasteboard/merge-end-2-expected.png: Added.
  • editing/pasteboard/merge-end-2-expected.txt: Added.
  • editing/pasteboard/merge-end-2.html: Added.


Use the editing library so the test can be run in slow motion.

  • editing/deleting/merge-unrendered-space.html:


Merges after pasted content no longer happen unnecessary. These
tests used to do unnecessary merges that happened to move nodes
that served as selection endpoints, which cleared the selection.
So, you'll see changes to the selection change delegate calls.

  • editing/pasteboard/8145-2-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:

WebCore:

Reviewed by harrison


Fixes more instances of:
<rdar://problem/3950559>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Do paragraph merging using moveParagraphs.
6:18 PM Changeset in webkit [13827] by eseidel
  • 63 edits
    3 copies
    1 delete in branches/treecode/JavaScriptCore

Merged with HEAD (13826), rs=timo.

6:08 PM Changeset in webkit [13826] by eseidel
  • 1 edit in branches/treecode/JavaScriptCore/kjs/TreeCode.cpp

.5% speedup on ibench by using Completion&. r=darin

5:57 PM Changeset in webkit [13825] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/merge-unrendered-space-expected.checksum: Added.
  • editing/deleting/merge-unrendered-space-expected.png: Added.
  • editing/deleting/merge-unrendered-space-expected.txt: Added.
  • editing/deleting/merge-unrendered-space.html: Added.

WebCore:

Reviewed by harrison


Some setup for work on paste performance.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Moved code from mergeParagraphs so that it can be used in ReplaceSelectionCommand.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): Put the code that chooses m_deepPosition into initDeepPosition. (WebCore::VisiblePosition::initDeepPosition): Fixed a bug: don't fall through to the code that's only for positions inside unrendered space between blocks when there's a candidate downstream() is a candidate. Added a comment about why the fall through code is necessary.
  • editing/VisiblePosition.h:
1:02 PM Changeset in webkit [13824] by harrison
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed clean build, broken by Darin's check-in
  • kjs/date_object.cpp: Add needed include of lookup.h.
  • kjs/regexp_object.cpp: Move include of .lut.h file below other includes.
12:45 PM Changeset in webkit [13823] by eseidel
  • 2 edits in trunk/WebKitSite

2006-04-11 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

  • quality/testing.html: fix run-mozilla-tests to run-javascriptcore-tests
10:51 AM Changeset in webkit [13822] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.


  • fixed <rdar://problem/4509328> highlight all matches hangs when searching for tab character on www.google.com (and others)


For reasons not yet completely understood, searching for a tab character on some pages (Google, Amazon) finds a match
with a non-collapsed range but then claims that the end visible position of the match is the original start visible
position of the search range. This was causing the highlightAllMatches code to loop forever. Fixed the loop by
checking for the non-advancing search range explicitly. I'm going to track down a reduction of the bogus
search-for-tab issue, and write that up as a separate bug (that bug is not a regression; you can "find" a tab on
google in Tiger also).

  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): break the loop if the search range hasn't advanced
9:30 AM Changeset in webkit [13821] by darin
  • 352 edits
    7 adds
    1 delete in trunk

JavaScriptCore:

Rubber-stamped by John Sullivan.

  • switched from a shell script to a makefile for generated files
  • removed lots of unneeded includes
  • added new Forward.h and HashForward.h headers that allow compiling with fewer unneeded templates
  • DerivedSources.make: Added.
  • generate-derived-sources: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files, changed to use DerivedSources.make.
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.
  • kxmlcore/HashCountedSet.h: Include HashForward for default args.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.
  • kjs/object.h:
  • kjs/object.cpp: Moved KJS_MAX_STACK into the .cpp file.
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm:
  • bindings/objc/objc_runtime.mm:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp:
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp:
  • bindings/runtime_root.h:
  • kjs/JSImmediate.cpp:
  • kjs/Parser.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.h:
  • kjs/context.h:
  • kjs/debugger.cpp:
  • kjs/error_object.h:
  • kjs/function_object.h:
  • kjs/internal.h:
  • kjs/lexer.cpp:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object_object.cpp:
  • kjs/operations.cpp:
  • kjs/protected_reference.h:
  • kjs/reference.h:
  • kjs/reference_list.h:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/Vector.h: Removed unneeded header includes.

JavaScriptGlue:

Rubber-stamped by John Sullivan.

  • added forwarding headers for the new Forward.h and HashForward.h files
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.

WebCore:

Rubber-stamped by John Sullivan (except for pbxproj change).

  • updated to use the new Forward.h and HashForward.h headers
  • moved the showTree debugging functions out of the WebCore namespace so they are easier to call from gdb, and renamed the showTree member functions so they don't get in the way; now you can do "call showTree(x)" in gdb and it just works
  • removed a lot of unneeded includes
  • WebCore.xcodeproj/project.pbxproj: Fixed a lot of paths that were not relative to the enclosing group.
  • ForwardingHeaders/kxmlcore/Forward.h: Added.
  • ForwardingHeaders/kxmlcore/HashForward.h: Added.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_navigator.cpp:
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_traversal.h:
  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/DOMViews.mm:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreFrameNamespaces.mm:
  • bridge/mac/WebCoreJavaScript.mm:
  • bridge/win/PageWin.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/css_base.h:
  • css/css_ruleimpl.h:
  • css/css_valueimpl.cpp:
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • dom/AbstractView.h:
  • dom/AtomicStringList.h:
  • dom/Attribute.cpp:
  • dom/Attribute.h:
  • dom/Comment.cpp:
  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/DOMImplementation.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dump): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::postDispatchEventHandler):
  • dom/NamedAttrMap.h:
  • dom/Node.cpp: (WebCore::Node::showNode): (WebCore::Node::showTree): (WebCore::Node::showTreeAndMark): (showTree):
  • dom/Node.h:
  • dom/NodeList.cpp:
  • dom/NodeList.h:
  • dom/Position.cpp: (showTree):
  • dom/Position.h:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • dom/dom2_eventsimpl.cpp:
  • dom/dom2_eventsimpl.h:
  • dom/dom2_traversalimpl.h:
  • dom/dom_xmlimpl.cpp:
  • dom/xml_tokenizer.cpp:
  • dom/xml_tokenizer.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/CreateLinkCommand.cpp:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/DeleteSelectionCommand.cpp:
  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/HTMLInterchange.cpp:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/JoinTextNodesCommand.cpp:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/ModifySelectionListLevelCommand.cpp:
  • editing/MoveSelectionCommand.cpp:
  • editing/RebalanceWhitespaceCommand.h:
  • editing/RemoveCSSPropertyCommand.h:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.cpp: (WebCore::Selection::formatForDebugger): (WebCore::Selection::showTree): (showTree):
  • editing/Selection.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::formatForDebugger): (WebCore::SelectionController::showTree): (showTree):
  • editing/SelectionController.h:
  • editing/TextIterator.cpp:
  • editing/TextIterator.h:
  • editing/TypingCommand.cpp:
  • editing/TypingCommand.h:
  • editing/UnlinkCommand.cpp:
  • editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): (WebCore::VisiblePosition::formatForDebugger): (WebCore::VisiblePosition::showTree): (showTree):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition): (WebCore::operator==):
  • editing/WrapContentsInDummySpanCommand.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • editing/markup.h: (WebCore::):
  • editing/visible_units.cpp:
  • html/CanvasGradient.cpp:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp:
  • html/CanvasStyle.h:
  • html/FormDataList.cpp:
  • html/FormDataList.h:
  • html/HTMLCollection.cpp:
  • html/HTMLCollection.h:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:
  • html/HTMLElement.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLElementFactory.h:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • html/html_baseimpl.cpp:
  • html/html_headimpl.h:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/misc/decoder.cpp:
  • khtml/misc/decoder.h:
  • khtml/xsl/XSLStyleSheet.cpp:
  • khtml/xsl/XSLTProcessor.cpp:
  • khtml/xsl/XSLTProcessor.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGTransform.h:
  • kwq/AccessibilityObjectCache.mm:
  • kwq/ClipboardMac.mm:
  • kwq/JavaAppletWidget.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/RegularExpression.h:
  • kwq/RenderTreeAsText.cpp:
  • kwq/RenderTreeAsText.h:
  • kwq/WebCoreAXObject.mm:
  • loader/Cache.cpp:
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedObject.h:
  • loader/CachedScript.cpp:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp:
  • page/FrameTree.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
  • platform/Color.cpp:
  • platform/FloatRect.h:
  • platform/Font.cpp:
  • platform/Font.h:
  • platform/FontFamily.cpp:
  • platform/GraphicsContext.cpp:
  • platform/Image.cpp:
  • platform/Image.h:
  • platform/IntRect.h:
  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/SegmentedString.h:
  • platform/Shared.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/TextEncoding.h:
  • platform/Timer.cpp:
  • platform/Timer.h:
  • platform/TransferJob.cpp:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/cairo/ImageCairo.cpp:
  • platform/cairo/ImageSourceCairo.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/mac/FontFamilyMac.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/ImageMac.mm:
  • platform/mac/TextEncodingMac.cpp:
  • platform/mac/TransferJobMac.mm:
  • platform/win/FontPlatformDataWin.cpp:
  • platform/win/TransferJobWin.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderCanvas.cpp:
  • rendering/RenderCanvas.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (showTree):
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderThemeWin.cpp:
  • rendering/bidi.cpp:
  • rendering/render_form.h:
  • rendering/render_line.cpp: (showTree):
  • rendering/render_line.h:
  • rendering/render_list.cpp:
  • rendering/render_replaced.cpp:
  • rendering/render_replaced.h:
  • rendering/render_style.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.h:
4:17 AM Changeset in webkit [13820] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore

misc small speedups to bring 2% more on the js ibench. r=mjs

2:03 AM Changeset in webkit [13819] by eseidel
  • 9 edits in branches/treecode/JavaScriptCore/kjs

Roll DeclaredFunctionImp::call() down into the interpreter loop for a 5% speed gain on ibench. r=mjs

Apr 10, 2006:

9:40 PM Changeset in webkit [13818] by ap
  • 2 edits
    2 moves
    1 delete in trunk

Reviewed by Darin.

WebKitTools:

  • Scripts/run-webkit-tests: Added support for running .pl and .php tests, removed support for .text. Reduced the number of places that explicitly list supported extensions. Some of the changes come from bug 8121, the patch for which got landed only partially.

LayoutTests:

  • http/tests/incremental/slow-utf8-text.pl: Added (renamed from .text).
  • http/tests/incremental/slow-utf8-text.text: Removed.
  • http/tests/incremental/split-hex-entities.pl: Added (renamed from .html).
  • http/tests/incremental/split-hex-entities.html: Removed.
  • http/tests/incremental/.htaccess: Removed.
9:17 PM Changeset in webkit [13817] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4139799> Seed: Safari: Private Browsing leaves traces in Icon Cache


  • Misc/WebIconDatabasePrivate.h: new ivars: pageURLsBoundDuringPrivateBrowsing, iconURLsBoundDuringPrivateBrowsing, and privateBrowsingEnabled
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): initialize new ivars, and listen for notifications that WebPreferences changed so we can react to changes to private browsing. (-[NSMutableDictionary iconForURL:withSize:cache:]): Don't remove icon URL from extraRetain dictionary; that's now done in _forgetIconForIconURLString. (I left a comment here earlier about why I was worried about this change, but I convinced myself that it's fine.) (-[WebIconDatabase removeAllIcons]): Removed no-longer-true (and never very clear) comment, and braces. Also remove all objects from the two private-browsing-related dictionaries. (-[WebIconDatabase _setIcon:forIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setHaveNoIconForIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setIconURL:forURL:]): added an assert that helped me out at one point (-[WebIconDatabase _clearDictionaries]): clear the two new dictionaries too (-[WebIconDatabase _loadIconDictionaries]): made an existing ERROR not fire in the expected case where there are no icons at all on disk (-[WebIconDatabase _updateFileDatabase]): when saving the pageURLToIconURL dictionary to disk, first remove any values that were created during private browsing (-[WebIconDatabase _retainIconForIconURLString:]): skip the code that deals with saving changes to disk if private browsing is enabled (-[WebIconDatabase _forgetIconForIconURLString:]): Remove the icon URL from extraRetain dictionary here. We're forgetting everything about this icon URL so we should forget its former extraRetain count too. (-[WebIconDatabase _resetCachedWebPreferences:]): Cache the new value of private browsing. If it has now been turned off, forget everything we learned while it was on. This causes (e.g.) icons for bookmarks or pre-existing history items to be forgotten if the icon was only learned during private browsing.
  • History/WebHistoryItem.m: removed an unnecessary #import I happened to notice
4:36 PM Changeset in webkit [13816] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4-expected.txt: Add one blank line (test result was failing).
4:30 PM Changeset in webkit [13815] by darin
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix mistaken bad editing of AdditionalIncludeDirectories.
3:30 PM Changeset in webkit [13814] by hyatt
  • 6 edits in trunk/WebCore

Make focus ring painting respect clips set by WebCore (e.g., overflow).

Reviewed by darin

  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawFocusRing):
  • platform/mac/WebCoreGraphicsBridge.h:
  • platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
  • rendering/RenderLayer.cpp: (WebCore::setClip): (WebCore::restoreClip):
3:29 PM Changeset in webkit [13813] by hyatt
  • 2 edits in trunk/WebKit

Make the broken CG focus ring painting work when WebCore sets a clip
(in addition to respecting the dirty rect clip).

Reviewed by darin

  • WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
3:12 PM Changeset in webkit [13812] by darin
  • 4 edits
    28 copies
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • death to khtml/ecma, long live bindings/js
  • khtml/ecma: Removed. Moved all files to bindings/js.
  • bindings/js/JSDOMParser.cpp: Added.
  • bindings/js/JSDOMParser.h: Added.
  • bindings/js/JSXMLHttpRequest.cpp: Added.
  • bindings/js/JSXMLHttpRequest.h: Added.
  • bindings/js/JSXMLSerializer.cpp: Added.
  • bindings/js/JSXMLSerializer.h: Added.
  • bindings/js/JSXSLTProcessor.cpp: Added.
  • bindings/js/JSXSLTProcessor.h: Added.
  • bindings/js/kjs_binding.cpp: Added.
  • bindings/js/kjs_binding.h: Added.
  • bindings/js/kjs_css.cpp: Added.
  • bindings/js/kjs_css.h: Added.
  • bindings/js/kjs_dom.cpp: Added.
  • bindings/js/kjs_dom.h: Added.
  • bindings/js/kjs_events.cpp: Added.
  • bindings/js/kjs_events.h: Added.
  • bindings/js/kjs_html.cpp: Added.
  • bindings/js/kjs_html.h: Added.
  • bindings/js/kjs_navigator.cpp: Added.
  • bindings/js/kjs_navigator.h: Added.
  • bindings/js/kjs_proxy.cpp: Added.
  • bindings/js/kjs_proxy.h: Added.
  • bindings/js/kjs_traversal.cpp: Added.
  • bindings/js/kjs_traversal.h: Added.
  • bindings/js/kjs_views.cpp: Added.
  • bindings/js/kjs_views.h: Added.
  • bindings/js/kjs_window.cpp: Added.
  • bindings/js/kjs_window.h: Added.
  • DerivedSources.make: Removed khtml/ecma from directory list.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Moved files from khtml/ecma to bindings/js.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
3:09 PM Changeset in webkit [13811] by eseidel
  • 21 edits
    4 copies
    1 delete in branches/treecode/JavaScriptCore

Re-base the treecode branch to latest HEAD.

I used the following command:
svn merge -r 13663:13752 ​svn+ssh://eseidel@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore

The merge was rubber-stamped by Tim Hatcher.

2:40 PM Changeset in webkit [13810] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.
2:38 PM Changeset in webkit [13809] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • try to fix the Windows build
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Put code to release m_drawingContext into an APPLE ifdef.
  • platform/win/TemporaryLinkStubs.cpp:
2:10 PM Changeset in webkit [13808] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth.

  • projects/compat/hitlist.html: updated dates
2:04 PM Changeset in webkit [13807] by eseidel
  • 1 delete in branches/temp-tree-code

Remove the temporary import branch for treecode.

2:02 PM Changeset in webkit [13806] by eseidel
  • 1 move in branches/treecode

Move the treecode branch to its proper place.

1:34 PM Changeset in webkit [13755] by thatcher
  • 1 add in branches/temp-tree-code

New branch folder for an upcoming import.

10:02 AM Changeset in webkit [13754] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Eric.

  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Removed the addition of scroll offsets, which is redundant for scrolled views, then changed the first view to be the document's scrolled view instead of its scroll view (all subsequent views were already scrolled views).
  • manual-tests/dictionary-scrolled-iframe.html: Added.
9:49 AM Changeset in webkit [13753] by darin
  • 92 edits in trunk

LayoutTests:

  • regenerated pixel results because many may be affected by the fix for bug 8100

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebTextRenderer.m: (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left. (CG_floatWidthForRun): For RTL runs, apply the last character's rounding on the left by adjusting the start position. (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator. (advanceWidthIterator): For RTL runs, apply rounding on the left of the character, by increasing the width of the next character (which is the character to the left). For the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by CG_floatWidthForRun().

Apr 9, 2006:

10:40 PM Changeset in webkit [13805] by ggaren
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

5% speedup by pushing all sourceelements nodes on the stack in one go

10:06 PM Changeset in webkit [13752] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by eric.

This patch switches manual RefPtr exchange with use of
RefPtr::release to ensure that a node's ref count never tops 1
(in the normal case).

  • kjs/nodes.cpp: (BlockNode::BlockNode): (CaseBlockNode::CaseBlockNode):
  • kjs/nodes.h: (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
9:53 PM Changeset in webkit [13804] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

prevent unnecessary entries in the extra ref count on nodes table

9:40 PM Changeset in webkit [13751] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Test: http/tests/xmlhttprequest/basic-auth.html

  • platform/KURL.cpp: (KURL::setUser): Enable a code path that handles non-empty user name - it was already present, but commented out and protected with an assertion. (KURL::setPass): Ditto.
7:45 PM Changeset in webkit [13750] by darin
  • 1 edit in trunk/LayoutTests/fast/canvas/canvas-before-css-expected.checksum

Removed bogus suffix I checked in by accident.

5:55 PM Changeset in webkit [13803] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

Prevent int->double conversion in hot code path

5:31 PM Changeset in webkit [13802] by ggaren
  • 5 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fixed up unwinding some more -- all the mozilla js tests now pass

4:48 PM Changeset in webkit [13749] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

First early steps towards a next, much smaller, round of renames
in WebCore.

4:38 PM Changeset in webkit [13748] by darin
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/canvas/canvas-before-css-expected.checksum: Added.
  • fast/canvas/canvas-before-css-expected.png: Added.
  • fast/canvas/canvas-before-css-expected.txt: Added.
  • fast/canvas/canvas-before-css.html: Added.
  • fast/canvas/image-object-in-canvas.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.
  • fast/canvas/patternfill-repeat-expected.txt: Updated for name change from RenderCanvasImage to RenderHTMLCanvas.
  • fast/canvas/image-object-in-canvas-expected.txt: Ditto.
  • fast/canvas/fillrect_gradient-expected.txt: Ditto.
  • fast/canvas/quadraticCurveTo-expected.txt: Ditto.

WebCore:

Reviewed by Anders.

Test: fast/canvas/canvas-before-css.html

This patch makes us match the canvas documentation in Hixie's Web Applications
draft as far as when the canvas is created and recreated and how it's sized.
It also gets rid of the compositeOperation attribute of the canvas element.
We can add that back if we need it. Anders points out that this specifically
changes behavior for canvas elements where the size is set in CSS and not with
width and height attributes. The CSS size now determines how big a box the canvas
is rendered into, but has no effect on the size of the canvas's buffer.

  • html/CanvasRenderingContext2D.h: Added overloads of drawImage that take HTMLCanvasElement, which is no longer derived from HTMLImageElement.
  • html/CanvasRenderingContext2D.cpp: (WebCore::imageSize): Renamed from imageOrCanvasSize. Now used for images only, because canvas is no longer derived from image. (WebCore::CanvasRenderingContext2D::drawImage): Split the implementation of this for image sources from the implementation for canvas sources. (WebCore::CanvasRenderingContext2D::willDraw): Changed to call a new willDraw function on the canvas element. (WebCore::CanvasRenderingContext2D::drawingContext): Changed to call drawingContext on the canvas element rather than the renderer.
  • html/HTMLCanvasElement.h: Changed HTMLCanvasElement to derive from HTMLElement instead of HTMLImageElement. Added width, height, setWidth, setHeight, willDraw, paint, drawingContext, createDrawingContext, and reset functions. Added m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. Removed mapToEntry, attach, detach, and isURLAttribute functins.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Added initializers for new m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Free m_data and m_drawingContext. (WebCore::HTMLCanvasElement::parseMappedAttribute): Got rid of special case for srcAttr, which is no longer needed since we aren't deriving from HTMLImageElement. Added code that triggers a reset when either width or height is set. (WebCore::HTMLCanvasElement::createRenderer): Added code to set the intrinsic width and height of the renderer to the size of the element. (WebCore::HTMLCanvasElement::setHeight): Added. Sets the height attribute. (WebCore::HTMLCanvasElement::setWidth): Added. Sets the width attribute. (WebCore::HTMLCanvasElement::willDraw): Added. Tells the renderer to repaint. Also has FIXME mentioning we could dirty only the part that has changed in the future. (WebCore::HTMLCanvasElement::reset): Added. Sets the size of the canvas and discards the old buffer, which is an indirect way of resetting the buffer to transparent black. (WebCore::HTMLCanvasElement::paint): Added. Draws the canvas image into the graphics context that's passed in. (WebCore::HTMLCanvasElement::createDrawingContext): Added. Allocates a buffer for the bits, then creates a bitmap context for drawing into the buffer. (WebCore::HTMLCanvasElement::drawingContext): Added. Calls createDrawingContext if needed, then returns the current drawing context. (WebCore::HTMLCanvasElement::createPlatformImage): Changed to always call CGContextFlush and to create the image from the context in this class.
  • rendering/RenderHTMLCanvas.h: Remove almost all of the contents of this file. Removed ~RenderHTMLCanvas, setNeedsImageUpdate, element, updateDrawnImage, drawingContext, createDrawingContext, and drawnImage functions and _drawingContext, _drawingContextData, _drawnImage, and _needsImageUpdate booleans. Changed RenderHTMLCanvas to derive from RenderReplaced instead of RenderImage.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Changed to only initialize RenderReplaced. (WebCore::RenderHTMLCanvas::renderName): Moved this in here, since there's no good reason to have this virtual function inlined. (WebCore::RenderHTMLCanvas::paint): Changed implementation to use HTMLCanvasElement::paint instead ofcalling CGContextDrawImage directly. (WebCore::RenderHTMLCanvas::layout): Removed the code that detects changes in width and causes the drawing context to be recreated; instead, if the width and height changes we scale when we paint the canvas.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): Separated out handling for <canvas> vs. <img> elements in drawRect, since HTMLCanvasElement is no longer derived from HTMLImageElement.
3:00 PM Changeset in webkit [13747] by eseidel
  • 2 edits in trunk/WebCore

2006-04-09 Rob Buis <​buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6027:
Dirty rect invalidation issues in mozilla sample

Make sure the paths calculate the new bounding box and not
use the cached bbox.

No automated test case possible.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::setPath):
2:55 PM Changeset in webkit [13746] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-09 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6930:
% width/height on nested <svg> tags do not work

Set the context correctly for inner <svg>, so calculation of
width/height for inner <svg> elements is done against the
viewport element.

Test: svg/custom/inner-percent.svg

  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::width): (WebCore::SVGSVGElement::height):
1:12 PM Changeset in webkit [13745] by eseidel
  • 2 edits in trunk/WebCore

2006-04-08 Rob Buis <​buis@kde.org>

Reviewed by eseidel.

No automated test case possible.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7531:
hang in SVGPolygonElementImpl::toPathData in polygon test case

Make sure the points list is cleared, just like the path
list is cleared first before (re)parsing.

  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):
1:03 AM Changeset in webkit [13744] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Forgot to commit ChangeLog for JSC string capitalization fixes.

Apr 8, 2006:

10:08 PM Changeset in webkit [13743] by darin
  • 17 edits
    8 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/forms/input-text-maxlength-expected.checksum: Added.
  • fast/forms/input-text-maxlength-expected.png: Added.
  • fast/forms/input-text-maxlength-expected.txt: Added.
  • fast/forms/input-text-maxlength.html: Added.
  • fast/forms/input-text-paste-maxlength-expected.checksum: Added.
  • fast/forms/input-text-paste-maxlength-expected.png: Added.
  • fast/forms/input-text-paste-maxlength-expected.txt: Added.
  • fast/forms/input-text-paste-maxlength.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/forms/input-text-maxlength.html
Test: fast/forms/input-text-paste-maxlength.html

  • html/HTMLInputElement.h: Removed all friend classes (not needed any more). Renamed typeEnum to InputType. Made init() function private. Tweaked parameter names and formatting in many function declarations. Made canHaveSelection, selectionStart, and selectionEnd const. Made data members except for m_name private instead of protected. Added private functions constrainValue and recheckValue. Removed unused isEditable function.
  • html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): Added. (WebCore::numCharactersInGraphemeClusters): Added. (WebCore::HTMLInputElement::isKeyboardFocusable): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::isMouseFocusable): Ditto. (WebCore::HTMLInputElement::focus): Ditto. (WebCore::HTMLInputElement::setInputType): Added code to call constrainValue or recheckValue so we will enforce maxLen if changing from a type that doesn't have maxLen to one that does. (WebCore::HTMLInputElement::type): More-standard formatting for switch statement. Put cases into alphabetical order. (WebCore::HTMLInputElement::state): Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::restoreState): Ditto. (WebCore::HTMLInputElement::canHaveSelection): Ditto. (WebCore::HTMLInputElement::selectionStart): Ditto. (WebCore::HTMLInputElement::selectionEnd): Ditto. (WebCore::HTMLInputElement::setSelectionStart): Ditto. (WebCore::HTMLInputElement::setSelectionEnd): Ditto. (WebCore::HTMLInputElement::select): Ditto. (WebCore::HTMLInputElement::setSelectionRange): Ditto. (WebCore::HTMLInputElement::click): Ditto. (WebCore::HTMLInputElement::accessKeyAction): Ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Use inputType() instead of using m_type directly. Added call to recheckValue when parsing a new value for the maxlength attribute. (WebCore::HTMLInputElement::rendererIsNeeded): Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::createRenderer): Ditto. (WebCore::HTMLInputElement::attach): Remove code to condition the value attribute when done parsing. This is now all handled by constrainValue and recheckValue as needed. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::appendFormData): Ditto. Rearranged code a little. (WebCore::HTMLInputElement::setChecked): Ditto. (WebCore::HTMLInputElement::setIndeterminate): Ditto. (WebCore::HTMLInputElement::value): Ditto. Call constrainValue when reading the value out of the value attribute. (WebCore::HTMLInputElement::valueWithDefault): Use inputType() instead of using m_type directly. Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::setValue): Ditto. Call constrainValue when storing a value. (WebCore::HTMLInputElement::setValueFromRenderer): Added an assertion. (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto. Changed code to truncate inserted text in a BeforeTextInsertedEvent to use the new constrainValue function and also the numGraphemeClusters function, so it's based on grapheme clusters instead of characters and shares code. (WebCore::HTMLInputElement::constrainValue): Added. (WebCore::HTMLInputElement::recheckValue): Added.
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement): Removed unneeded code to set m_type to TEXT, which is already what it gets set to by the base class's constructor.
  • html/HTMLGenericFormElement.h: Removed unused isEditable function.
  • html/HTMLGenericFormElement.cpp: Ditto.
  • html/HTMLTextAreaElement.h: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • platform/StringImpl.cpp: (WebCore::StringImpl::truncate): Changed > to >= so that truncating to the size of the string does nothing, efficiently.
  • rendering/RenderText.h: Added declaration of characterBreakIterator.
  • rendering/RenderText.cpp: (WebCore::characterBreakIterator): Made this public so it can be used in other files. Maybe we should also move it to another source file later. Also renamed to remove the "get" from the title. (WebCore::RenderText::previousOffset): Updated for name change. (WebCore::RenderText::nextOffset): Updated for name change.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): Removed code to implement maxlength checking. That's handled entirely in the DOM now. Also moved down the code to get the value into a string so that it's done only in the case where the string is used.
  • rendering/render_form.cpp: (WebCore::RenderFileButton::valueChanged): Use setValueFromRenderer instead of setting the value directly in the input element. We changed this for all the other types a while ago, and it works just as well for the input element.
  • dom/BeforeTextInsertedEvent.h: Added setText function. Previously, clients changed the text by modifying the text object in place, but going forward we'd like to avoid that sort of thing.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Changed code to assume clients will change the text in the event rather than mutating the text object itself. This is compatible with possible future changes to String to be copy on write.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Ditto.
1:51 PM Changeset in webkit [13801] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

added missing fall through to case code

1:50 PM Changeset in webkit [13800] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

refined rules for what the current completion state is

1:40 PM Changeset in webkit [13799] by eseidel
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore

added shrinkTo and growTo to vector for speed gain

12:08 PM Changeset in webkit [13798] by eseidel
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fix try and switch

12:04 PM Changeset in webkit [13742] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

One more attempt - use reinterpret_cast, rather than static_cast.

11:54 AM Changeset in webkit [13741] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

An attempt to fix Win32 build - ICU uses wchar_t on Windows, so we need a type cast.

  • kxmlcore/unicode/icu/UnicodeIcu.h: (KXMLCore::Unicode::toLower): (KXMLCore::Unicode::toUpper):
10:21 AM Changeset in webkit [13740] by ap
  • 11 edits
    3 copies
    3 adds in trunk

Reviewed by Darin.

Test: fast/js/string-capitalization.html

  • JavaScriptCore.xcodeproj/project.pbxproj: Added KXMLCore::Unicode headers to the project.
  • icu/unicode/putil.h: Added (copied from WebCore).
  • icu/unicode/uiter.h: Ditto.
  • icu/unicode/ustring.h: Ditto.
  • kjs/string_object.cpp: (StringProtoFunc::callAsFunction): Use the new KXMLCore::Unicode::toUpper() and toLower().
  • kjs/ustring.cpp: Removed unused (and evil) UChar::toLower() and toUpper().
  • kjs/ustring.h: Ditto.
  • kxmlcore/unicode/Unicode.h: Corrected capitalization of the word Unicode.
  • kxmlcore/unicode/UnicodeCategory.h: Renamed include guard macro to match file name.
  • kxmlcore/unicode/icu/UnicodeIcu.h: (KXMLCore::Unicode::toLower): Work on strings, not individual characters. Use ICU root locale. (KXMLCore::Unicode::toUpper): Ditto. (KXMLCore::Unicode::isFormatChar): Use int32_t, which can hold a complete code point. (KXMLCore::Unicode::isSeparatorSpace): Ditto. (KXMLCore::Unicode::category): Ditto.
  • kxmlcore/unicode/qt4/UnicodeQt4.h: (KXMLCore::Unicode::toLower): Work on strings, not individual characters. (KXMLCore::Unicode::toUpper): Ditto. (KXMLCore::Unicode::isFormatChar): Use int32_t, which can hold a complete code point. (KXMLCore::Unicode::isSeparatorSpace): Ditto. (KXMLCore::Unicode::category): Ditto.
  • tests/mozilla/ecma/String/15.5.4.12-1.js: Corrected expected results.
  • tests/mozilla/ecma/String/15.5.4.12-5.js: Corrected expected results.
9:49 AM Changeset in webkit [13739] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _retainIconForIconURLString:]): This new assertion was one block too high; moved it in.

Apr 7, 2006:

6:40 PM Changeset in webkit [13797] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

fix assertion in ForInNodeExecutePopBreakUnwindBarrierState

6:31 PM Changeset in webkit [13796] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

Fix FALL_THROUGH in debug builds

6:26 PM Changeset in webkit [13795] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fixed labeled break and continue

6:16 PM Changeset in webkit [13794] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

add missing break in CommaNodeEvaluateState

6:02 PM Changeset in webkit [13793] by eseidel
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

Add FALL_THROUGH macro

5:47 PM Changeset in webkit [13792] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

fixed do-while by adding fake true value at the front

5:34 PM Changeset in webkit [13738] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/forms/input-text-drag-down-expected.checksum: Added.
  • fast/forms/input-text-drag-down-expected.png: Added.
  • fast/forms/input-text-drag-down-expected.txt: Added.
  • fast/forms/input-text-drag-down.html: Added.

WebCore:

Reviewed by Hyatt.

  • editing/Selection.cpp: (WebCore::comparePositions): Added. Takes shadow content into account. (WebCore::Selection::validate): Changed to call comparePositions instead of calling Range::compareBoundaryPoints directly. Also removed unneeded code to redundantly set m_start and m_end to null and did a bit of reformatting.
  • some tiny efficiency improvements to the tokenizer -- no measurable speedup, but removes a little bit of unneeded code
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Changed all the places that do "unsigned short x = *c" to "unsigned short x = c->unicode()" when c is a QChar, otherwise we do an unnecessary conversion to char (which requires a branch to see if the c fits in a char).
5:27 PM Changeset in webkit [13791] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fix exception handling and loop continue states

5:21 PM Changeset in webkit [13737] by justing
  • 6 edits in trunk

Reviewed by harrison


Rolled the fix for 8250 back in and fixed a bug:
The local variables for the first and last nodes in the fragment
need to be reset when the fragment is changed for plaintext-only mode
or a change from the beforetextinserted event handler.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
5:16 PM Changeset in webkit [13736] by hyatt
  • 2 edits in trunk/WebKit

A fix that makes coalesced updates work much better (and makes our
single animated GIF timer work better). The new rect painting algorithm
for WebHTMLView will use the single unioned rect if the # of rects exceeds
a threshold (10 is my initial cut), or if the union has enough "wasted"
additional pixels (conservatively set at 75%).

Reviewed by darin

  • WebView/WebHTMLView.m: (-[NSArray drawSingleRect:]): (-[NSArray drawRect:]):
5:11 PM Changeset in webkit [13790] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

fixed missing break in property list node

5:08 PM Changeset in webkit [13789] by ggaren
  • 1 edit in branches/temp-tree-code/trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

fixing missing break statement in property list node

4:55 PM Changeset in webkit [13735] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test case for this fix:


  • fixed REGRESSION: offsetParent on element with no offset parent crashes
  • fast/dom/Element/null-offset-parent.html: Added.

WebCore:

Reviewed by Darin.


  • fixed REGRESSION: offsetParent on element with no offset parent crashes
  • dom/Element.cpp: (WebCore::Element::offsetParent): Add missing null check.
4:50 PM Changeset in webkit [13734] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.


  • simplify archive loading
  • WebView/WebDataSource.m: (-[WebDataSource representation]): fix whitespace
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]): Use WebFrame's loadArchive: instead of trying to do a manual load here. (-[WebHTMLRepresentation documentSource]): No more special case for WebArchive.
4:42 PM Changeset in webkit [13788] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fixed up switch / case statements

4:35 PM Changeset in webkit [13787] by eseidel
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

much better unwind barrier printing

4:01 PM Changeset in webkit [13733] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4507054> If an icon file is removed from disk behind Safari's back, Safari will not try to refetch it


In addition to letting WebIconDatabase recover from disk/memory mismatches as per 4507054, I also found
a bug in the way icons are remembered that could account for some of the other cases where
site icons didn't appear (and you'd get an ERROR on debug builds about WebIconDatabase saying it
had some icon when it really doesn't).

  • Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): When the icon file for a previously-saved site icon isn't found, forget about the darn icon URL thoroughly so that this situation is self-correcting. Formerly, once you got into this state WebKit would never find the icon again (short of removing the entire icon database cleanly). Note that this does *not* change the behavior of sites that didn't have a site icon when WebKit checked -- these will continue to not return a site icon indefinitely (that's a separate, possibly performance-sensitive issue). (-[WebIconDatabase _retainIconForIconURLString:]): This code did the wrong thing in the case where an icon was in the process of being forgotten about. In that case, the icon would still be in _private->iconsOnDiskWithURLs, so we wouldn't try to save it here, so the new icon wouldn't stick.
3:25 PM Changeset in webkit [13732] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by adele

  • fast/forms/input-maxlength-2-expected.checksum: Added.
  • fast/forms/input-maxlength-2-expected.png: Added.
  • fast/forms/input-maxlength-2-expected.txt: Added.
  • fast/forms/input-maxlength-2.html: Added.

WebCore:

Reviewed by adele


maxlength truncation in text fields didn't work if the fragment was a
single text node.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
2:57 PM Changeset in webkit [13731] by justing
  • 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Rolling out the patch I just checked in.

1:46 PM Changeset in webkit [13730] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8250>
REGRESSION: Interchange newlines aren't passed with the khtmlBeforeTextInsertedEvent

  • fast/forms/8250-expected.checksum: Added.
  • fast/forms/8250-expected.png: Added.
  • fast/forms/8250-expected.txt: Added.
  • fast/forms/8250.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8250>
REGRESSION: Interchange newlines aren't passed with the khtmlBeforeTextInsertedEvent

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Interchange content removal happened before khtmlBeforeTextInsertedEvent was sent.
12:51 PM Changeset in webkit [13786] by eseidel
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

unify exception handling

12:36 PM Changeset in webkit [13729] by justing
  • 7 edits in trunk

LayoutTests:

Reviewed by adele
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8219>
REGRESSION: Two extra newlines added when pasting a single styled line into a plaintext-only region

Updated to relfect fix:

  • editing/pasteboard/8145-1-expected.checksum:
  • editing/pasteboard/8145-1-expected.png:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/8145-1.html:

WebCore:

Reviewed by adele


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8219>
REGRESSION: Two extra newlines added when pasting a single styled line into a plaintext-only region

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Converting the fragment to plaintext introduced an extraneous newline because the range passed to plainText ended after the paragraph containing the fragment built from the markup that TextEdit put on the paste board. TextIterator will emit a newline when it exits a paragraph. Two extra newlines were added because the '\n' in the plaintext string turns into an interchange newline, which isn't removed because of 8250, and the interchange newline looks like inline content that requires the insertion of a paragraph separator during paste. Fixed by creating a range using VisiblePositions at the start and the end of the node that holds the fragment during paste's test rendering.
11:41 AM Changeset in webkit [13728] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8145>
REGRESSION: Pasting text from TextEdit with a bold word into text field results in crash

  • editing/pasteboard/8145-1-expected.checksum: Added.
  • editing/pasteboard/8145-1-expected.png: Added.
  • editing/pasteboard/8145-1-expected.txt: Added.
  • editing/pasteboard/8145-1.html: Added.
  • editing/pasteboard/8145-2-expected.checksum: Added.
  • editing/pasteboard/8145-2-expected.png: Added.
  • editing/pasteboard/8145-2-expected.txt: Added.
  • editing/pasteboard/8145-2.html: Added.
  • editing/pasteboard/8145-3-expected.checksum: Added.
  • editing/pasteboard/8145-3-expected.png: Added.
  • editing/pasteboard/8145-3-expected.txt: Added.
  • editing/pasteboard/8145-3.html: Added.
  • fast/forms/plaintext-mode-1-expected.txt:
  • fast/forms/plaintext-mode-1.html:

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8145>
REGRESSION: Pasting text from TextEdit with a bold word into text field results in crash

  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Assert that the node will be placed somewhere that's contenteditable.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto
  • editing/JSEditor.cpp: Enabled insertHTML for plaintext-only regions since it's useful for debugging rich content pastes into the new text fields.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): 1) After the first paragraph of the fragment has been merged with the first part of the paragraph where the paste occured, if the next node to be inserted is inline, we put it in a new paragraph because it was at the start of a paragraph in the fragment. The change is to insert a paragraph separator if insertionPos.next() is null or outside of the current editable region. 2) Before the paste begins, a paragraph separator is inserted in order to avoid nesting blocks from the fragment to be pasted inside the block where the paste will occur. I made two fixes to the code that decides whether or not to insert the paragraph separator and added testcases for each. Added a fixme because it appears that this code is also used to ensure that the aforementioned insertionPos will be at the end of a paragraph. This code should only be about preventing nesting.
10:06 AM Changeset in webkit [13727] by thatcher
  • 1 add in branches/Safari-2-0-branch/JavaScriptGlue/Makefile

Missing a makefile.

1:31 AM Changeset in webkit [13726] by mjs
  • 13 edits
    3 adds in trunk

LayoutTests:

Reviewed by Anders.

Added test case for incidental fix from this change:


  • fast/dom/Element/dimension-properties-unrendered-expected.txt: Added.
  • fast/dom/Element/dimension-properties-unrendered.html: Added.
  • fast/dom/Element/resources/dimension-properties-unrendered.js: Added.

WebCore:

Reviewed by Anders.

  • dom/Element.idl: Declare full interface in IDL.
  • dom/Element.h: (WebCore::Element::tagQName): Renamed from tagName, so the real DOM method can be called tagName. (WebCore::Element::tagName): inline alias for nodeName.
  • dom/Element.cpp: (WebCore::Element::scrollByUnits): Moved logic from JS bindings to core DOM. (WebCore::Element::scrollByLines): ditto (WebCore::Element::scrollByPages): ditto (WebCore::Element::offsetLeft): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetTop): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetHeight): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetParent): ditto (WebCore::Element::clientWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::clientHeight): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::scrollLeft): ditto (WebCore::Element::scrollTop): ditto (WebCore::Element::setScrollLeft): ditto (WebCore::Element::setScrollTop): ditto (WebCore::Element::scrollWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::scrollHeight): ditto, plus make unrendered elements return 0 not undefined
  • bindings/scripts/CodeGeneratorJS.pm: Added support for ConvertUndefinedToTrue, for benefit of scroll methods where omitted arguments should be treated as true. However, maybe explicit overloading in the IDL would be a better long-term approach for optional arguments.
  • khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck): fixed formatting (KJS::valueToBooleanTreatUndefinedAsTrue): added for binding of scrollIntoView (isn't this lame?)
  • khtml/ecma/kjs_binding.h: (KJS::toJS): fixed formatting, added new stuff
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::getValueProperty): removed most of contents (KJS::DOMElement::putValueProperty): ditto (KJS::DOMElementProtoFunc::callAsFunction): ditto
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): updated for rename of tagName to tagQName (WebCore::CSSStyleSelector::checkOneSelector): ditto
  • dom/Document.cpp: (WebCore::Document::importNode): ditto
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): ditto (WebCore::areIdenticalElements): ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList): ditto (WebCore::HTMLElement::inInlineTagList): ditto (WebCore::HTMLElement::inBlockTagList): ditto
1:04 AM Changeset in webkit [13725] by hyatt
  • 2 edits in trunk/WebKit

Re-enable coalesced updates. Our move to a single timer has essentially
implemented coalescing of updates anyway, so the regression has already
come back. Since we have to deal with that now anyway, there's no reason
to visually tear also. :)

Reviewed by darin

  • ChangeLog:
  • WebView/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
12:26 AM Changeset in webkit [13785] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

further fixes to exception handling, as well as doWhile and new expressions

Apr 6, 2006:

11:51 PM Changeset in webkit [13784] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fix try/catch and forIn unwind handling as well as error throwing

10:34 PM Changeset in webkit [13783] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs
10:25 PM Changeset in webkit [13782] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

fix AssignDotNodeEvaluateState

10:13 PM Changeset in webkit [13781] by ggaren
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

loops work now -- mostly :)

9:52 PM Changeset in webkit [13724] by darin
  • 1 edit in trunk/WebKitTools/WebKitLauncher/WebKitLauncher.xcodeproj

Add the ignore property for inside this project.

9:06 PM Changeset in webkit [13780] by eseidel
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

make value returns use a single value instead of the stack

6:21 PM Changeset in webkit [13779] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

trying to find value leak

5:02 PM Changeset in webkit [13778] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

Fix returns and completions

2:10 PM Changeset in webkit [13777] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

add printStacks()

2:09 PM Changeset in webkit [13776] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/completion.h

prevent the All completion mask from matching Scope, since Scope isn't a real completion

1:53 PM Changeset in webkit [13775] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/internal.cpp

unwind barrier debug print function was using the wrong variable

1:46 PM Changeset in webkit [13774] by ggaren
  • 1 add in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.h

forgot to add this file

1:44 PM Changeset in webkit [13773] by ggaren
  • 7 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore

random bug fixes, value stack printouts are now more informative

12:36 PM Changeset in webkit [13772] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

integrated for-in loop. everything compiles, but we still die bbadbeef-style on all js runs.

11:45 AM Changeset in webkit [13723] by bdakin
  • 9 edits
    4 adds in trunk

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8203
REGRESSION: "Invite a friend" text field in GMail page spills out
of table

RenderReplaced::calcMinMaxWidth() sets m_minWidth to 0 when the
width is a percent, so this patch copies that behavior into
RenderTextField::calcMinMaxWidth().

4:06 AM Changeset in webkit [13771] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

the beast

3:29 AM Changeset in webkit [13770] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

make ReferenceList iterators hold on to their lists so that we can keep an iterator stack without having the underlying lists get destroyed

1:58 AM Changeset in webkit [13769] by eseidel
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

add node stack and forIn

12:37 AM Changeset in webkit [13768] by eseidel
  • 5 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

go ggaren go

12:26 AM Changeset in webkit [13722] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add JSDocument.cpp.
12:23 AM Changeset in webkit [13721] by darin
  • 5 edits in trunk/WebKitTools

Changes requested by Mark Rowe.

  • BuildSlaveSupport/build-launcher-app: Set executable bit, removed property change trash at the end of the file.
  • BuildSlaveSupport/build-launcher-dmg: Ditto.
  • WebKitLauncher/main.m: Removed trash at end of file.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Let Xcode update comments to make name match.
12:11 AM Changeset in webkit [13720] by darin
  • 4 edits in trunk/LayoutTests
  • regenerated test results
  • fast/forms/input-table-expected.txt: Regenerated. Seems right, matches Gecko.
  • fast/forms/form-element-geometry-expected.png: Regenerated.
  • fast/forms/form-element-geometry-expected.checksum: Regenerated.
12:02 AM Changeset in webkit [13719] by darin
  • 3 edits in trunk/JavaScriptCore
  • attempt to fix Windows build
  • kxmlcore/HashMap.h: (KXMLCore::HashMap::remove): Use (*it). instead of it->.
  • kxmlcore/HashSet.h: (KXMLCore::HashSet::remove): Ditto.

Apr 5, 2006:

11:41 PM Changeset in webkit [13718] by darin
  • 2 edits in trunk/LayoutTests
  • fast/forms/input-truncate-newline-expected.txt: Restored good expected results.
11:07 PM Changeset in webkit [13717] by darin
  • 2 edits in trunk/JavaScriptCore
  • attempt to fix Windows build
  • os-win32/stdint.h: Add int8_t, uint8_t, int64_t.
11:01 PM Changeset in webkit [13716] by darin
  • 2 edits in trunk/WebKit
  • fixed a storage leak from that last check-in
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState dealloc]): Release the two dictionaries.
10:57 PM Changeset in webkit [13715] by darin
  • 19 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adele.

  • updated results for improved dumping of selection location in DumpRenderTree
  • fast/forms/input-text-self-emptying-click-expected.checksum: Added.
  • fast/forms/input-text-self-emptying-click-expected.png: Added.
  • fast/forms/input-text-self-emptying-click-expected.txt: Added.
  • fast/forms/input-text-self-emptying-click.html: Added.
  • editing/selection/3690703-2-expected.txt: Updated.
  • fast/forms/input-appearance-focus-expected.txt: Updated.
  • fast/forms/input-appearance-readonly-expected.txt: Updated.
  • fast/forms/input-appearance-selection-expected.txt: Updated.
  • fast/forms/input-paste-undo-expected.txt: Updated.
  • fast/forms/input-text-double-click-expected.txt: Updated.
  • fast/forms/input-text-option-delete-expected.txt: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
  • fast/forms/plaintext-mode-2-expected.txt: Updated.

WebCore:

Reviewed by Adele.

Test: fast/forms/input-text-self-emptying-click.html

  • page/MouseEventWithHitTestResults.h: Removed url, target, m_url and m_target, replacing them with isOverLink and m_isOverLink. Replaced innerNode with targetNode, and added logic to handle the case where the target node is removed from the document but the element the target node was in is still inside the document.
  • page/MouseEventWithHitTestResults.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: Added MouseEventWithHitTestResults.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • kwq/RenderTreeAsText.cpp: (nodePosition): Added a call to shadowParentNode so we correctly dump positions within shadow trees. This was needed to give a good result from my new test for this bug.
  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent): Update to pass fewer parameters to the constructor for MouseEventWithHitTestResults. Now takes isOverLink boolean, and no longer takes href and target parameters.
  • page/Frame.cpp: (WebCore::Frame::handleMousePressEventDoubleClick): Use new name targetNode, instead of old name innerNode. (WebCore::Frame::handleMousePressEventTripleClick): Ditto. (WebCore::Frame::handleMousePressEventSingleClick): Ditto. Also change code to check if over a link to use !isOverLink instead of url.isNull. (WebCore::Frame::handleMousePressEvent): Ditto. Also remove unused "url" local variable. (WebCore::Frame::handleMouseMoveEvent): Ditto. (WebCore::Frame::handleMouseReleaseEvent): Ditto. (WebCore::Frame::passWidgetMouseDownEventToWidget): Ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMousePressEvent): Use new name targetNode, instead of old name innerNode. (WebCore::FrameMac::handleMouseMoveEvent): Ditto. (WebCore::FrameMac::passSubframeEventToSubframe): Ditto. (WebCore::FrameMac::sendContextMenuEvent): Ditto.
  • page/FrameView.cpp: (WebCore::subframeForEvent): Use new name targetNode, instead of old name innerNode. (WebCore::FrameView::handleMousePressEvent): Ditto. (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto. (WebCore::selectCursor): Ditto. Also change code to check if over a link to use isOverLink instead of !url.isNull. (WebCore::FrameView::handleMouseMoveEvent): Ditto. (WebCore::FrameView::handleMouseReleaseEvent): Ditto. (WebCore::FrameView::updateDragAndDrop): Ditto.
9:49 PM Changeset in webkit [13714] by mjs
  • 7 edits
    2 adds in trunk/WebKit

Reviewed by Eric.



  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addToUnarchiveState:]): (-[WebDataSource _popSubframeArchiveWithName:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource subresourceForURL:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]):
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]):
  • WebView/WebUnarchivingState.h: Added.
  • WebView/WebUnarchivingState.m: Added. (-[WebUnarchivingState init]): (-[WebUnarchivingState addArchive:]): (-[WebUnarchivingState archivedResourceForURL:]): (-[WebUnarchivingState popSubframeArchiveWithFrameName:]):
9:44 PM Changeset in webkit [13713] by mjs
  • 2 edits in trunk

Fixed date in ChangeLog entries for last checkin.

9:40 PM Changeset in webkit [13712] by mjs
  • 4 edits in trunk

LayoutTests:

Reviewed and landed by Maciej.

  • fast/clip/outline-overflowClip-expected.txt: Reverted to the correct expected result.

WebCore:

Reviewed and landed by Maciej.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Reverted this part of the fix for bug 7943. The outlineRect should not be inflated.
9:36 PM Changeset in webkit [13711] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Reviewed by Eric, landed by Maciej.

  • svg/custom/class-selector.svg: Added.

WebCore:

Reviewed by Eric, landed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7627:
SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black

Fix this svg stylesheet to use strict-mode, as this makes sure
class selecting is done correctly.

  • ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
9:14 PM Changeset in webkit [13710] by mjs
  • 3 edits
    10 adds in trunk/WebKitTools

Reviewed by Darin, landed by Maciej.

  • BuildSlaveSupport/build-launcher-app: Added. Builds WebKit.app from WebKitLauncher and bundles the WebKit frameworks inside it.
  • BuildSlaveSupport/build-launcher-dmg: Added. Builds, and optionally uploads, a disk image containing WebKit.app.
  • BuildSlaveSupport/run-performance-tests: Use currentSVNRevision.
  • Scripts/webkitdirs.pm: Add currentSVNRevision to retrieve the revision number of the SVN working copy.
  • WebKitLauncher: Added.
  • WebKitLauncher/Info.plist: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Added.
  • WebKitLauncher/WebKitNightlyEnabler.m: Added. This makes up the WebKitNightlyEnabler dylib which is loaded into Safari's address space to cause LaunchServices to treat Safari.app as WebKit.app when it is run from the nightly launcher.
  • WebKitLauncher/main.m: Added. The WebKit.app launcher. It sets up the environment to have Safari use the bundled frameworks and load the WebKitNightlyEnabler dylib before exec'ing Safari
  • WebKitLauncher/start.html: Added.
  • WebKitLauncher/webkit.icns: Added.
7:31 PM Changeset in webkit [13767] by eseidel
  • 8 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

merge

6:59 PM Changeset in webkit [13766] by eseidel
  • 8 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

commit attempt

6:52 PM Changeset in webkit [13765] by ggaren
  • 1 copy in branches/temp-tree-code/branches/evaluate-execute-merge

created branch for evaluate-execute merge

5:13 PM Changeset in webkit [13709] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix memory leak introduced by the previous change
  • kxmlcore/HashTable.h: Specialize NeedsRef so that it correctly returns true when the value in question is a pair where one of the pair needs a ref and the other of the pair does not.
5:00 PM Changeset in webkit [13708] by justing
  • 2 edits in trunk/WebCore

Reviewed by mjs

I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
implicit removes.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
3:43 PM Changeset in webkit [13707] by justing
  • 1 edit in trunk/WebCore/editing/InsertNodeBeforeCommand.cpp

Should fix the build

3:26 PM Changeset in webkit [13706] by mjs
  • 23 edits
    1 add in trunk

LayoutTests:

Reviewed by Anders.

Update prototype chain for the following fix:

  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Anders.

  • also removed document.actualEncoding since it is not in any spec or implemented by any other browser


  • DerivedSources.make: add JSDocument.h to results
  • WebCore.xcodeproj/project.pbxproj: Added new files to project
  • bindings/scripts/CodeGeneratorJS.pm: Support for new stuff needed by Document.
  • dom/Document.cpp: (WebCore::Document::readyState): moved impl here from JS bindings (WebCore::Document::inputEncoding): ditto (WebCore::Document::defaultCharset): ditto (WebCore::Document::setCharset): ditto
  • dom/Document.h: (WebCore::Document::charset): added, synonym for inputEncoding. (WebCore::Document::characterSet): ditto
  • dom/Document.idl: Added. Full interface for the Document object.
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): JSDocument, not DOMDocument
  • khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): ditto
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrFalse): Added this convenience for the method on Document that bizzarely returns false on failure and a string otherwise.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::toJS): renamed for consistency
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp:
  • removed all traces of DOMDocument (KJS::toJS): JSDocument, not DOMDocument
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::): (KJS::JSHTMLDocument::JSHTMLDocument): inherit from JSDocument (KJS::JSHTMLDocument::getOwnPropertySlot): ditto (KJS::JSHTMLDocument::put): ditto
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::toJS): added overloads (KJS::toNodeFilter): handle JS functions as well as impl NodeFilter objects
  • khtml/ecma/kjs_traversal.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): Allow implicit conversion from String.
2:53 PM Changeset in webkit [13705] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
Hitting an assert on undo paste

  • editing/pasteboard/undoable-fragment-removes-expected.checksum: Added.
  • editing/pasteboard/undoable-fragment-removes-expected.png: Added.
  • editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • editing/pasteboard/undoable-fragment-removes.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
Hitting an assert on undo paste


ReplaceSelectionCommand was doing a combination of undoable and non-undoable
removes from the ReplacementFragment. On Undo Paste, the undoable removes
couldn't be undone because the tree was in a different state than it was
at the time of the remove. This patch makes all the removes from the fragment
non-undoable. We could make them all undoable, but I can't think of any reason
why we'd want the fragment to be reconstructed on an Undo Paste.

  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Assert that the node to append isn't already in a tree, since if it is, it will be removed in a non-undoable way.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Nodes were being moved from the fragment to the document with undoable inserts. Undoable inserts implicitly remove the node (in a non-undoable way) from its old location if it is already in a tree. I now explicitly remove the nodes from the fragment before inserting them into the document to make it clear that they are being removed in a non-non-undoable way. I also changed the one undoable remove from the fragment to a non-undoable remove.
  • editing/ReplaceSelectionCommand.h: Made ReplacementFragment's non-undoable removeNode public.
2:51 PM Changeset in webkit [13704] by darin
  • 2 edits in trunk/WebCore
  • fixed the build
  • WebCore.xcodeproj/project.pbxproj: Oops! Resolved merge conflict.
2:19 PM Changeset in webkit [13703] by darin
  • 34 edits
    2 adds
    1 delete in trunk

JavaScriptCore:

Reviewed by Maciej.

Change HashMap and HashSet implementation so they fold various types together.
This allows us to implement maps and sets that use RefPtr<WebCore::StringImpl>
and WebCore::String in terms of the underlying raw pointer type, and hence use
-1 for the deleted value.

  • kxmlcore/HashTraits.h: Added a new type to HashTraits, StorageTraits, which is a type to be used when storing a value that has the same layout as the type itself. This is used only for non-key cases. In the case of keys, the hash function must also be considered. Moved emptyValue out of GenericHashTraitsBase into GenericHashTraits. Added a new bool to HashTraits, needsRef, which indicates whether the type needs explicit reference counting. If the type itself has needsRef true, but the storage type has needsRef false, then the HashSet or HashMap has to handle the reference counting explicitly. Added hash trait specializations for all signed integer values that give -1 as the deleted value. Gave all integers StorageTraits of the canonical integer type of the same size so int and long will share code. Gave all pointers and RefPtrs StorageTraits of the appropriately sized integer type. Removed redundant TraitType and emptyValue definitions in the pointer specialization for HashTraits. Added PairBaseHashTraits, which doesn't try to set up needsDestruction and deletedValue. Useful for types where we don't want to force the existence of deletedValue, such as the type of a pair in a HashMap which is not the actual storage type. Removed an unneeded parameter from the DeletedValueAssigner template. Added HashKeyStorageTraits template, which determines what type can be used to store a given hash key type with a given hash function, and specialized it for pointers and RefPtr so that pointer hash tables share an underlying HashTable that uses IntHash.
  • kxmlcore/HashTable.h: Added HashTableConstIteratorAdapter, HashTableIteratorAdapter, NeedsRef, RefCountManagerBase, RefCountManager, HashTableRefCountManagerBase, and HashTableRefCountManager. All are used by both HashSet and HashMap to handle hash tables where the type stored is not the same as the real value type.


  • kxmlcore/HashFunctions.h: Added a new struct named IntTypes that finds an integer type given a sizeof value. Renamed pointerHash to intHash and made it use overloading and take integer parameters. Added an IntHash struct which is a hash function that works for integers. Changed PtrHash to call IntHash with an appropriately sized integer. Made IntHash the default hash function for many integer types. Made PtrHash the default hash function for RefPtr as well as for raw pointers.
  • kxmlcore/HashSet.h: Changed implementation to use a separate "storage type" derived from the new traits. The HashTable will use the storage type and all necessary translation and ref/deref is done at the HashSet level. Also reorganized the file so that the HashSet is at the top and has no inline implementation inside it so it's easy to read the interface to HashSet.
  • kxmlcore/HashMap.h: Changed implementation to use a separate "storage type" derived from the new traits. The HashTable will use the storage type and all necessary translation and ref/deref is done at the HashMap level. Also reorganized the file so that the HashMap is at the top and has no inline implementation inside it so it's easy to read the interface to HashMap.
  • kxmlcore/HashMapPtrSpec.h: Removed. Superceded by optimizations in HashMap itself.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove HashMapPtrSpec.h, resort files, and also remove some unnecessary build settings from the aggregate target that generates derived sources.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.

WebCore:

Reviewed by Maciej.

  • platform/StringHash.h: Added. Moved hash functions and such for WebCore::String and friends into this file so we don't have to include the hash traits header everywhere. Changed hashing for WebCore::StringImpl and WebCore::String so that they use a raw pointer for the underlying storage type, taking advantage of the new feature added in JavaScriptCore.
  • platform/AtomicString.h: Moved StrHash specialization to StringHash.h.
  • platform/PlatformString.h: Moved StrHash specialization to StringHash.h.
  • platform/StringImpl.h: Moved StrHash, CaseInsensitiveHash, and HashTraits to StringHash.h. Left DefaultHash behind so that you can't get the wrong hash function by accident if you forget to include "StringHash.h".
  • platform/StringImpl.cpp: Added include of StringHash.h and removed RefPtr<StringImpl> HashTraits<RefPtr<StringImpl> >::_deleted, which is the object with a global initializer causing all the trouble!
  • kwq/AccessibilityObjectCache.h: Changed hash function to be IntHash instead of PtrHash.
  • dom/StyledElement.cpp: Changed MappedAttributeKeyTraits to inherit from the generic traits in KXMLCore so we get a StorageType. Also cleaned up a tiny bit by adding default values to the MappedAttributeKey constructor.
  • platform/CharsetNames.cpp: Changed hash traits here to be a new TextEncodingIDHashTraits struct rather than defining new default traits for the integer type since more integer types have default traits in HashTraits.h now. Also added a specialization so this class will share the underlying implementation (since InvalidEncoding happens to be -1).
  • bridge/mac/FrameMac.h:
  • dom/Document.h:
  • dom/xml_tokenizer.h:
  • khtml/xsl/XSLTProcessor.h:
  • kwq/JavaAppletWidget.h:
  • page/FramePrivate.h:
  • page/Page.cpp:
  • platform/AtomicString.cpp:
  • platform/TransferJob.h:
  • rendering/render_applet.h: Added include of StringHash.h.
  • WebCore.xcodeproj/project.pbxproj: Added StringHash.h. Remove unneeded CREATE_HASH_TABLE variable in build settings. Re-sorted some file lists. Added quotes to the CREATE_HASH_TABLE initialization in the rule that builds generated files. Removed various unneeded build settings for that target as well.
  • ForwardingHeaders/kxmlcore/HashTraits.h: Added.
  • other minor cleanup
  • bridge/mac/FrameMac.mm: Sorted includes.
  • dom/Node.cpp: Removed bogus symbol after #endif.
  • khtml/xsl/XSLTProcessor.cpp: Sorted includes. Removed redundant using namespace WebCore.
  • loader/Cache.cpp: Ditto.

WebKitTools:

Reviewed by Maciej.

  • Scripts/check-for-global-initializers: Remove StringImpl from the list of files that are allowed to have global initializers.
1:28 PM Changeset in webkit [13764] by ggaren
  • 4 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

Oops. Committed wrong patch. This is with-stack.patch

1:09 PM Changeset in webkit [13763] by ggaren
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

Committing Eric's patch to unify how nodes know their interpreter state -- with minor tweaks to the ASSERTs. The unified method is for nodes to use a data member rather than virtual method dispatch. This is about a 7% performance win.

11:05 AM Changeset in webkit [13702] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4502311> text-transform:capitalize needs to
treat nbsp as a regular space when ICU changes

There will be future changes in ICU to match the Unicode 4.1
standard which no longer recognizes &nbsp as a word separator. We
need to work around this with text-transform:capitalize because
words after non-breaking spaces still need to be capitalized.

No layout tests added because existing layout tests cover this.

11:02 AM Changeset in webkit [13701] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/dom/navigator-vendorSub.html

  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): Return an empty string for vendorSub property.
  • khtml/ecma/kjs_navigator.h:
11:02 AM Changeset in webkit [13700] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by OMG BETH

  • Scripts/run-testkjs:
  • pipe STDERR to /dev/null by default; new --verbose option overrides this behavior
  • set DYLD_FRAMEWORK_PATH to the webkit-configured path
  • output run command in a format that can be copied and pasted into the terminal to run manually
12:17 AM Changeset in webkit [13762] by ggaren
  • 6 edits
    1 delete in branches/temp-tree-code/trunk/JavaScriptCore

more steps toward integrating the evaluate and execute loops

Apr 4, 2006:

11:42 PM Changeset in webkit [13761] by eseidel
  • 1 edit in branches/temp-tree-code/trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Make svn ignore xcode internal files

11:41 PM Changeset in webkit [13760] by eseidel
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

roll evaluateList into the loop, fix exception handling

8:55 PM Changeset in webkit [13699] by darin
  • 10 edits
    1 delete in trunk

LayoutTests:

Reviewed by Justin and Adele.

  • fast/forms/plaintext-mode-2-expected.txt: Updated because there's no longer and extra <div> element added.

WebCore:

Reviewed by Justin (editing parts) and Adele (the rest).

The smart paste code was getting confused and adding extra spaces.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of isStartOfLine. (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem): Change to call isStart/EndOfParagraph instead of Line.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Add a comment about how isStartOfLine is almost certainly wrong here.
  • clean up some loose ends in the Frame class from the recent renaming
  • page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and handleMouseMoveEventPart2.
  • page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing handleMouseMoveEvent itself.
  • invoke the makefile directly, removing the generate-derived-sources script
  • WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • generate-derived-sources: Removed.
7:26 PM Changeset in webkit [13698] by hyatt
  • 2 edits in trunk/LayoutTests/tables

Update table results after my change to create fewer RenderTexts.

7:19 PM Changeset in webkit [13697] by hyatt
  • 14 edits in trunk/LayoutTests/fast

Update fast results after my change to create fewer RenderTexts.

7:06 PM Changeset in webkit [13696] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

  • editing/selection/caret-rtl-expected.checksum: Added.
  • editing/selection/caret-rtl-expected.png: Added.
  • editing/selection/caret-rtl-expected.txt: Added.
  • editing/selection/caret-rtl.html: Added.
  • editing/selection/caret-rtl-2-expected.checksum: Added.
  • editing/selection/caret-rtl-2-expected.png: Added.
  • editing/selection/caret-rtl-2-expected.txt: Added.
  • editing/selection/caret-rtl-2.html: Added.

WebCore:

Reviewed by Justin.

Tests:
editing/selection/caret-rtl.html
editing/selection/caret-rtl-2.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): When calculating the position for the beginning or end of an InlineTextBox, we now use offsetForPosition instead of just using m_start and m_len, because offsetForPosition will take rtl text into account. I also made some formatting changes.
6:49 PM Changeset in webkit [13695] by adele
  • 2 edits in trunk/LayoutTests

New results for

  • fast/forms/input-truncate-newline-expected.txt

Filed bug:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8187
input-truncate-newline layout test fails when run as part of larger set of tests

5:47 PM Changeset in webkit [13759] by ggaren
  • 1 add in branches/temp-tree-code/trunk/JavaScriptCore/kjs/NodeType.h

forgot this file

5:47 PM Changeset in webkit [13758] by ggaren
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore

converted all executes to giant switch statement -- nothing is integrated with the evaluate loop yet, but it builds and passes all the tests

4:47 PM Changeset in webkit [13694] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1/JavaScriptCore

Correct place.

4:47 PM Changeset in webkit [13693] by thatcher
  • 1 add in tags/JavaScriptCore-521.9.1

New tag.

4:46 PM Changeset in webkit [13692] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1-temp

Move. This was in the wrong place.

4:42 PM Changeset in webkit [13691] by thatcher
  • 5 edits in tags/JavaScriptCore-521.9.1

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
4:34 PM Changeset in webkit [13690] by thatcher
  • 1 copy in tags/JavaScriptCore-521.9.1

new tag.

4:34 PM Changeset in webkit [13689] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8065, inline blocks incorrectly loses spaces between them.

Reviewed by beth

  • dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
3:23 PM Changeset in webkit [13688] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
REGRESSION (NativeTextField): table contents misaligned in Netflix queue

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

  • fast/forms/input-table-expected.checksum: Added.
  • fast/forms/input-table-expected.png: Added.
  • fast/forms/input-table-expected.txt: Added.
  • fast/forms/input-table.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

Test: fast/forms/input-table.html

Rewrote calcMinMaxWidth for text fields so it considers width,
min-width, and max-width settings as well as the size attribute.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
3:11 PM Changeset in webkit [13687] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Darin.

This is a followup to my fix for <rdar://problem/4493218>


This patch re-names computeIntLength() and computerShortLength() to
be computeLengthInt() and computeLengthShort(), respectively, to
match the pre-existing computeLengthFloat(). This patch also adds
the slightly confusing-ly named computeLengthIntForLength() which
uses the max and min values of a 28-bit integer as bounds for
overflow. This function is necessary because Length objects expect
28-bit integers.

2:21 PM Changeset in webkit [13686] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

JavaScriptGlue:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebKit.xcodeproj/project.pbxproj:
1:52 PM Changeset in webkit [13685] by justing
  • 17 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting

Added:

  • editing/deleting/merge-different-styles-expected.checksum: Added.
  • editing/deleting/merge-different-styles-expected.png: Added.
  • editing/deleting/merge-different-styles-expected.txt: Added.
  • editing/deleting/merge-different-styles.html: Added.
  • editing/deleting/merge-no-br-expected.checksum: Added.
  • editing/deleting/merge-no-br-expected.png: Added.
  • editing/deleting/merge-no-br-expected.txt: Added.
  • editing/deleting/merge-no-br.html: Added.
  • editing/deleting/merge-whitespace-pre-expected.checksum: Added.
  • editing/deleting/merge-whitespace-pre-expected.png: Added.
  • editing/deleting/merge-whitespace-pre-expected.txt: Added.
  • editing/deleting/merge-whitespace-pre.html: Added.

Fixes (not enough style on nodes for the fixes to be reflected in pixel results):

  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:

Equivalent render trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:


Forgot to checkin these new expected results after fixing the DRT bug:

  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/lists/drag-into-marker-expected.txt:

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting


Rewrote moveNodesAfterNode to address these problems:
It moved nodes without preserving their style.
It traversed over siblings looking for a br to know when
to stop merging. If the br was burried inside a span, it
wouldn't find it. If the text is whitespace:pre, it wouldn't
stop.
In theory it would crash if the "enclosingInlineElements" of the start of the
selection to delete and the end of the selection to delete were the
same. We think that this will fix these:
<rdar://problems/3950559&4498113>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
But we haven't been able to construct a reproducible case.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand. (WebCore::CompositeEditCommand::prune): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/DeleteSelectionCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::):
  • editing/markup.cpp: (WebCore::createMarkup): Was crashing when passed a collapsed range. I early return an empty string instead.
11:10 AM Changeset in webkit [13684] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix win32 build.
Disable ASSERT redefinition warnings for now.

10:48 AM Changeset in webkit [13683] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • WebKit part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Pass private browsing setting down to WebCore.
10:47 AM Changeset in webkit [13682] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Adele Peterson.


  • WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setPrivateBrowsingEnabled:]): (-[WebCoreSettings privateBrowsingEnabled]): Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)


  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::privateBrowsingEnabled): (KHTMLSettings::setPrivateBrowsingEnabled): Teach KHTMLSettings about private browsing


  • kwq/KWQLineEdit.mm: Fix wrong class in a category method declaration; the compiler didn't seem to mind.


  • kwq/WebCoreTextField.mm: (-[KWQSearchFieldCell _addStringToRecentSearches:]): Override this method to bail out if private browsing is enabled.
9:15 AM Changeset in webkit [13681] by darin
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
REGRESSION: Safari crashes when printing a google map w/directions

Tests: none, because I believe it only happens when printing, due to the relayouts

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells ensure the sections' grid data is up to date.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth): Call above method.
5:11 AM Changeset in webkit [13680] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Bjrn Graf <​bjoern.graf@gmail.com>

Reviewed by ggaren & darin. Landed by eseidel.

Integrate CURL version of gettimeofday
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7399
Disable crash report dialogs for testkjs.exe in Release mode
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8113

  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS): (main): (kjsmain):
4:54 AM Changeset in webkit [13679] by eseidel
  • 2 edits in trunk/WebCore

2006-04-03 Justin Haygood <​jhaygood@spsu.edu>

Reviewed by eseidel. Landed by eseidel.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollBars):
4:48 AM Changeset in webkit [13678] by eseidel
  • 3 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Work-around spaces-in-pathnames issue in gnumake on win32.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8173

  • WebCore.vcproj/WebCore/build-generated-files.sh:
3:08 AM Changeset in webkit [13677] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): remove trunc() to fix win32.
2:03 AM Changeset in webkit [13676] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • kjs/number_object.cpp: (intPow10): Compute integer powers of 10 using exponentiation by squaring. (NumberProtoFunc::callAsFunction): Use intPow10(n) in place of all pow(10.0, n), plus a bit of refactoring.

Apr 3, 2006:

11:54 PM Changeset in webkit [13675] by darin
  • 3 edits in trunk/WebCore
  • tried to fix build again
  • WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
11:30 PM Changeset in webkit [13674] by darin
  • 56 edits in trunk/WebCore
  • fixed properties on a bunch of files (removed allow-tabs and svn:executable from many)
  • css/css_base.cpp:
  • html/html_headimpl.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • kwq/DeprecatedPtrListImpl.cpp:
  • kwq/DeprecatedValueListImpl.cpp:
  • loader/CachedScript.h:
  • platform/ArrayImpl.cpp:
  • platform/StringImpl.cpp:
  • rendering/DataRef.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/bidi.h:
  • rendering/render_list.cpp:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Converted tabs to spaces.
10:21 PM Changeset in webkit [13673] by ap
  • 8 edits
    12 adds in trunk

Reviewed by Darin.

Tests: fast/css/invalidation-errors.html

fast/css/invalidation-errors-2.html
fast/css/invalidation-errors-3.html

  • css/CSSGrammar.y: Rollback the properties added by parseValue() when it returns false.
  • css/cssparser.h: Moved shorthand counting to ShorthandScope, a new class in cssparser.cpp.
  • css/cssparser.cpp: (WebCore::CSSParser::rollbackLastProperties): Added. (WebCore::CSSParser::parseValue): Return false if there are too many properties in the list. (WebCore::CSSParser::parseBackgroundShorthand): Use ShorthandScope. (WebCore::CSSParser::parseShorthand): Ditto. (WebCore::CSSParser::parse4Values): Ditto.
9:47 PM Changeset in webkit [13672] by thatcher
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Bumping the PLT count back to 5.

9:07 PM Changeset in webkit [13671] by darin
  • 4 edits
    1 delete in trunk/WebCore
  • changed StyleSheet back to hand-generated since the generated toJS function was not making the right type of wrapper for CSS style sheets (fixes failing layout tests)
  • DerivedSources.make: Removed JSStyleSheet.h.
  • css/StyleSheet.idl: Removed.
  • khtml/ecma/kjs_css.cpp: Added DOMStyleSheet back in.
  • khtml/ecma/kjs_css.h: Ditto.
8:55 PM Changeset in webkit [13670] by darin
  • 3 edits in trunk/JavaScriptCore
  • tweak config.h and Platform.h to try to get buildbot working (making some small changes at the same time)
  • kjs/config.h: Removed now-unneeded HAVE_ICU.
  • kxmlcore/Platform.h: Tweak how platform gets set up. Move all the USE stuff to the end.
8:34 PM Changeset in webkit [13669] by darin
  • 2 edits in trunk/WebCore
  • fixed Macintosh build
  • WebCore.xcodeproj/project.pbxproj: Fixed paths of some files that were absolute paths from my machine.
8:14 PM Changeset in webkit [13668] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add three new generated files as source files.
7:45 PM Changeset in webkit [13667] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix Win32 build breakage and remove an unused forward.

6:54 PM Changeset in webkit [13666] by darin
  • 7 edits in trunk

LayoutTests:

  • add a test of RTL to the test for bug 8106
  • fast/forms/input-text-scroll-left-on-blur-expected.png: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum: Updated.
  • fast/forms/input-text-scroll-left-on-blur.html: Updated.

WebCore:

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll to the right if RTL.
6:50 PM Changeset in webkit [13665] by darin
  • 6 edits
    4 adds in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Added.
  • css/CSSPrimitiveValue.idl: Added.
  • css/Counter.idl: Added.
  • css/StyleSheet.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Added new generated files, IDLs, and the makefile.
  • bindings/scripts/CodeGeneratorJS.pm:
  • generate-derived-sources: Added license header. Removed most of the script, except for a single invocation of make.
  • khtml/ecma/kjs_css.h: Removed DOMStyleSheet, DOMCSSPrimitiveValue, CSSPrimitiveValueConstructor, and DOMCounter.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): Changed to use JSStyleSheet as the base class. (KJS::DOMCSSStyleSheet::getOwnPropertySlot): Ditto. (KJS::DOMCSSValueProtoFunc::callAsFunction): Added. (KJS::toJS): Changed to use JSCSSPrimitiveValue. (KJS::DOMRGBColor::getValueProperty): Changed to call toJS instead of making a DOMCSSPrimitiveValue directly.
5:30 PM Changeset in webkit [13757] by eseidel
  • 5 edits
    1 copy
    1 add in branches/temp-tree-code/trunk/JavaScriptCore

Initial commit

4:58 PM Changeset in webkit [13664] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.png: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
  • editing/pasteboard/drag-drop-modifies-page.html: Added.

Updated:

  • fast/lists/drag-onto-marker.html:
  • fast/lists/drag-onto-marker-expected.txt:
  • fast/lists/drag-onto-marker-expected.png:
  • fast/lists/drag-onto-marker-expected.checksum:

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page


The frame's selection is only set after all sub-commands have been
performed. When we send the khtmlBeforeTextInsertedEvent to the root
editable element we were using frame->selection(), which may no longer
be in the document.


Had to move the construction of the ReplacementFragment to when the
replace operation is applied, because endingSelection isn't the
endingSelection of the last operation when the replace operation
is constructed.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:

WebKitTools:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it


Tell the source that the drag is over after the drag is performed, not before.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]):
4:49 PM Changeset in webkit [13663] by staikos
  • 5 edits
    9 adds in trunk/JavaScriptCore

Reviewed by Maciej.

Implement a unicode abstraction layer to make JavaScriptCore much more
easily ported to other platforms without having to take in libicu. Also
makes the unicode related code easier to understand.

4:46 PM Changeset in webkit [13662] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4495644> crash when mousing over
links at nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

4:17 PM Changeset in webkit [13661] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.


  • re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view remains when search text is deleted
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): I fixed this recently, but then broke it again by adding an early bail-out to this method. So now I'm removing the early bail-out.
4:08 PM Changeset in webkit [13756] by eseidel
  • 1502 adds in branches/temp-tree-code

initial import

3:30 PM Changeset in webkit [13660] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4495644> crash when mousing over links at
nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

This is a fix for a repro crasher where a rootLineBox had a stale
pointer to a render object.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild): Only break from the function because of selfNeedsLayout() if we are not an inline flow, because if we are, we will not re-layout before bad things can happen.
3:26 PM Changeset in webkit [13659] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Removing idl files and some scripts from the WebCore target to prevent
them from being copied into the Resources.

  • WebCore.xcodeproj/project.pbxproj:
3:06 PM Changeset in webkit [13658] by thatcher
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
2:58 PM Changeset in webkit [13657] by hyatt
  • 10 edits in trunk/WebCore

Win32 theme work. Bug 8162. r=anders

2:55 PM Changeset in webkit [13656] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/dom/Element/offsetTop-table-cell-expected.txt: Added.
  • fast/dom/Element/offsetTop-table-cell.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/dom/Element/offsetTop-table-cell.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop): Skip table rows when adding up the offsets, since a table cell's yPos() is relative to the table section, not the row.
2:42 PM Changeset in webkit [13655] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/inline-block-overflow-expected.png: Added.
  • fast/repaint/layer-outline-expected.checksum: Added.
  • fast/repaint/layer-outline-expected.png: Added.
  • fast/repaint/layer-outline-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal-expected.checksum: Added.
  • fast/repaint/layer-outline-horizontal-expected.png: Added.
  • fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal.html: Added.
  • fast/repaint/layer-outline.html: Added.

WebCore:

Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Use the outlineRect for the outline phase and do it only if the outlineRect isn't empty. (WebCore::RenderLayer::calculateRects): Actually add the outline width to the outline rect.
2:14 PM Changeset in webkit [13654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/input-truncate-newline-expected.txt: Added.
  • fast/forms/input-truncate-newline.html: Added.

WebCore:

Reviewed by Justin.

Test: fast/forms/input-truncate-newline.html

  • html/HTMLInputElement.cpp: (WebCore::minPosition): Added helper function. (WebCore::HTMLInputElement::defaultEventHandler): Searches for /r or /n and truncates the text to be inserted to the earliest newline.
10:46 AM Changeset in webkit [13653] by ap
  • 2 edits in trunk/WebCore

Fixed a comment (forgot to save the file before the previous commit).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
9:36 AM Changeset in webkit [13652] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: http/tests/xmlhttprequest/methods-lower-case.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): Uppercase some HTTP method names, to match a Firefox quirk. (WebCore::XMLHttpRequest::send): Account for the above change.
9:28 AM Changeset in webkit [13651] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): When an element changes size, the delta rectangles that need to be invalidated must be inflated by the outline size to ensure that the previous outline is erased, and the space where the new outline is to be drawn is also invalidated. This behaviour is identical to the behaviour of borders that was fixed in bug 6301.
  • manual-tests/outline-repaint-glitch.html: Added. Manual testcase. This is just an outline version of border-repaint-glitch.html
9:25 AM Changeset in webkit [13650] by darin
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Adding tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed
and ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

In addition I tweaked the httpd conf file to allow us to exec perl CGI scripts.

  • http/conf/httpd.conf:
  • http/tests/misc/error404-expected.checksum: Added.
  • http/tests/misc/error404-expected.png: Added.
  • http/tests/misc/error404-expected.txt: Added.
  • http/tests/misc/error404.pl: Added.
  • http/tests/misc/iframe404-expected.checksum: Added.
  • http/tests/misc/iframe404-expected.png: Added.
  • http/tests/misc/iframe404-expected.txt: Added.
  • http/tests/misc/iframe404.html: Added.

WebCore:

Reviewed by Maciej.

Support for fixing ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check. (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which gives a correct result even at the start of our loading process.
  • bindings/objc/DOM.mm: (-[DOMDocument _ownerElement]): Nuke redundant nil check.

WebKit:

Reviewed by Maciej.

fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): Only cancel failed loads for object elements, not for frames or a whole page.
9:04 AM Changeset in webkit [13649] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back updateStyleSelector call that was removed as part of the patch for bug 7907.
12:06 AM Changeset in webkit [13648] by mjs
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Tests for:

  • fast/forms/focus-control-to-page-expected.txt: Added.
  • fast/forms/focus-control-to-page.html: Added.

WebCore:

Reviewed by Hyatt.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame):
  • bridge/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
  • let WebHTMLView know that the next time it becomes first responder, it's to change focus within the page and the right node has already been set, so it should not move focus forward or backward inside it.
  • WebView/WebHTMLView.m: (-[NSArray needsPanelToBecomeKey]): Override to return YES, oddly enough this is the right way to tell AppKit that you should be in the tab cycle loop. (-[NSArray becomeFirstResponder]): Don't move forward or back in tab cycle when this becomeFirstResponder is for tabbing from a control in the page. (-[WebHTMLView _willMakeFirstResponderForNodeFocus]): Note that the next time this view becomes first responder, it will be for in-page focus navigation.
  • WebView/WebHTMLViewInternal.h:

Apr 2, 2006:

12:55 AM Changeset in webkit [13635] by ggaren
  • 5 edits
    1 add in trunk/JavaScriptGlue

Reviewed by Darin.

  • Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.


  • JSUtils.cpp: (KJSValueToJSObject):
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:


  • JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.

Apr 1, 2006:

6:52 PM Changeset in webkit [13647] by darin
  • 3 edits in trunk/LayoutTests
  • updated one more result for change in focus ring appearance
  • fast/forms/plaintext-mode-2-expected.checksum: Updated.
  • fast/forms/plaintext-mode-2-expected.png: Ditto.
6:39 PM Changeset in webkit [13646] by darin
  • 2 edits in trunk/WebCore
  • add a few stubs to get Windows closer to building
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles):
6:26 PM Changeset in webkit [13645] by darin
  • 2 edits in trunk/WebCore
  • fix the build
  • WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been mentioned at all, and a bunch of others that should be in the project but not in the target.
6:17 PM Changeset in webkit [13644] by darin
  • 178 edits in trunk/LayoutTests
  • updated layout test results, mostly for the change in focus ring appearance
  • editing/input/range-for-empty-document-expected.txt:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
  • editing/deleting/collapse-whitespace-3587601-fix-expected.checksum:
  • editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • editing/deleting/delete-3608430-fix-expected.checksum:
  • editing/deleting/delete-3608430-fix-expected.png:
  • editing/deleting/delete-3608445-fix-expected.checksum:
  • editing/deleting/delete-3608445-fix-expected.png:
  • editing/deleting/delete-3608462-fix-expected.checksum:
  • editing/deleting/delete-3608462-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-4038408-fix-expected.checksum:
  • editing/deleting/delete-4038408-fix-expected.png:
  • editing/deleting/delete-4083333-fix-expected.checksum:
  • editing/deleting/delete-4083333-fix-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • editing/deleting/delete-block-contents-001-expected.checksum:
  • editing/deleting/delete-block-contents-001-expected.png:
  • editing/deleting/delete-block-contents-002-expected.checksum:
  • editing/deleting/delete-block-contents-002-expected.png:
  • editing/deleting/delete-block-contents-003-expected.checksum:
  • editing/deleting/delete-block-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-001-expected.checksum:
  • editing/deleting/delete-block-merge-contents-001-expected.png:
  • editing/deleting/delete-block-merge-contents-002-expected.checksum:
  • editing/deleting/delete-block-merge-contents-002-expected.png:
  • editing/deleting/delete-block-merge-contents-003-expected.checksum:
  • editing/deleting/delete-block-merge-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-004-expected.checksum:
  • editing/deleting/delete-block-merge-contents-004-expected.png:
  • editing/deleting/delete-block-merge-contents-005-expected.checksum:
  • editing/deleting/delete-block-merge-contents-005-expected.png:
  • editing/deleting/delete-block-merge-contents-006-expected.checksum:
  • editing/deleting/delete-block-merge-contents-006-expected.png:
  • editing/deleting/delete-block-merge-contents-007-expected.checksum:
  • editing/deleting/delete-block-merge-contents-007-expected.png:
  • editing/deleting/delete-block-merge-contents-008-expected.checksum:
  • editing/deleting/delete-block-merge-contents-008-expected.png:
  • editing/deleting/delete-block-merge-contents-009-expected.checksum:
  • editing/deleting/delete-block-merge-contents-009-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/delete-block-merge-contents-011-expected.checksum:
  • editing/deleting/delete-block-merge-contents-011-expected.png:
  • editing/deleting/delete-block-merge-contents-012-expected.checksum:
  • editing/deleting/delete-block-merge-contents-012-expected.png:
  • editing/deleting/delete-block-merge-contents-013-expected.checksum:
  • editing/deleting/delete-block-merge-contents-013-expected.png:
  • editing/deleting/delete-block-merge-contents-014-expected.checksum:
  • editing/deleting/delete-block-merge-contents-014-expected.png:
  • editing/deleting/delete-block-merge-contents-015-expected.checksum:
  • editing/deleting/delete-block-merge-contents-015-expected.png:
  • editing/deleting/delete-block-merge-contents-016-expected.checksum:
  • editing/deleting/delete-block-merge-contents-016-expected.png:
  • editing/deleting/delete-block-merge-contents-017-expected.checksum:
  • editing/deleting/delete-block-merge-contents-017-expected.png:
  • editing/deleting/delete-br-001-expected.checksum:
  • editing/deleting/delete-br-001-expected.png:
  • editing/deleting/delete-br-002-expected.checksum:
  • editing/deleting/delete-br-002-expected.png:
  • editing/deleting/delete-br-003-expected.checksum:
  • editing/deleting/delete-br-003-expected.png:
  • editing/deleting/delete-br-004-expected.checksum:
  • editing/deleting/delete-br-004-expected.png:
  • editing/deleting/delete-br-005-expected.checksum:
  • editing/deleting/delete-br-005-expected.png:
  • editing/deleting/delete-br-006-expected.checksum:
  • editing/deleting/delete-br-006-expected.png:
  • editing/deleting/delete-br-007-expected.checksum:
  • editing/deleting/delete-br-007-expected.png:
  • editing/deleting/delete-character-001-expected.checksum:
  • editing/deleting/delete-character-001-expected.png:
  • editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • editing/deleting/delete-contiguous-ws-001-expected.png:
  • editing/deleting/delete-image-001-expected.checksum:
  • editing/deleting/delete-image-001-expected.png:
  • editing/deleting/delete-image-002-expected.checksum:
  • editing/deleting/delete-image-002-expected.png:
  • editing/deleting/delete-image-003-expected.checksum:
  • editing/deleting/delete-image-003-expected.png:
  • editing/deleting/delete-image-004-expected.checksum:
  • editing/deleting/delete-image-004-expected.png:
  • editing/deleting/delete-leading-ws-001-expected.checksum:
  • editing/deleting/delete-leading-ws-001-expected.png:
  • editing/deleting/delete-line-015-expected.checksum:
  • editing/deleting/delete-line-015-expected.png:
  • editing/deleting/delete-line-016-expected.checksum:
  • editing/deleting/delete-line-016-expected.png:
  • editing/deleting/delete-line-017-expected.checksum:
  • editing/deleting/delete-line-017-expected.png:
  • editing/deleting/delete-line-end-ws-001-expected.checksum:
  • editing/deleting/delete-line-end-ws-001-expected.png:
  • editing/deleting/delete-line-end-ws-002-expected.checksum:
  • editing/deleting/delete-line-end-ws-002-expected.png:
  • editing/deleting/delete-listitem-001-expected.checksum:
  • editing/deleting/delete-listitem-001-expected.png:
  • editing/deleting/delete-listitem-002-expected.checksum:
  • editing/deleting/delete-listitem-002-expected.png:
  • editing/deleting/delete-select-all-001-expected.checksum:
  • editing/deleting/delete-select-all-001-expected.png:
  • editing/deleting/delete-select-all-002-expected.checksum:
  • editing/deleting/delete-select-all-002-expected.png:
  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-selection-001-expected.checksum:
  • editing/deleting/delete-selection-001-expected.png:
  • editing/deleting/delete-tab-001-expected.checksum:
  • editing/deleting/delete-tab-001-expected.png:
  • editing/deleting/delete-tab-002-expected.checksum:
  • editing/deleting/delete-tab-002-expected.png:
  • editing/deleting/delete-tab-003-expected.checksum:
  • editing/deleting/delete-tab-003-expected.png:
  • editing/deleting/delete-tab-004-expected.checksum:
  • editing/deleting/delete-tab-004-expected.png:
  • editing/deleting/delete-trailing-ws-001-expected.checksum:
  • editing/deleting/delete-trailing-ws-001-expected.png:
  • editing/deleting/delete-trailing-ws-002-expected.checksum:
  • editing/deleting/delete-trailing-ws-002-expected.png:
  • editing/deleting/delete-ws-fixup-001-expected.checksum:
  • editing/deleting/delete-ws-fixup-001-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-003-expected.checksum:
  • editing/deleting/delete-ws-fixup-003-expected.png:
  • editing/deleting/delete-ws-fixup-004-expected.checksum:
  • editing/deleting/delete-ws-fixup-004-expected.png:
  • editing/deleting/smart-delete-001-expected.checksum:
  • editing/deleting/smart-delete-001-expected.png:
  • editing/deleting/smart-delete-002-expected.checksum:
  • editing/deleting/smart-delete-002-expected.png:
  • editing/execCommand/boldSelection-expected.checksum:
  • editing/execCommand/boldSelection-expected.png:
  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertImage-expected.checksum:
  • editing/execCommand/insertImage-expected.png:
  • editing/execCommand/italicizeByCharacter-expected.checksum:
  • editing/execCommand/italicizeByCharacter-expected.png:
  • editing/execCommand/modifyForeColorByCharacter-expected.checksum:
  • editing/execCommand/modifyForeColorByCharacter-expected.png:
  • editing/execCommand/print-expected.checksum:
  • editing/execCommand/print-expected.png:
  • editing/execCommand/selectAll-expected.checksum:
  • editing/execCommand/selectAll-expected.png:
  • editing/execCommand/strikethroughSelection-expected.checksum:
  • editing/execCommand/strikethroughSelection-expected.png:
  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/insert-3659587-fix-expected.checksum:
  • editing/inserting/insert-3659587-fix-expected.png:
  • editing/inserting/insert-3775316-fix-expected.checksum:
  • editing/inserting/insert-3775316-fix-expected.png:
  • editing/inserting/insert-3778059-fix-expected.checksum:
  • editing/inserting/insert-3778059-fix-expected.png:
  • editing/inserting/insert-3800346-fix-expected.checksum:
  • editing/inserting/insert-3800346-fix-expected.png:
  • editing/inserting/insert-after-delete-001-expected.checksum:
  • editing/inserting/insert-after-delete-001-expected.png:
  • editing/inserting/insert-at-end-01-expected.checksum:
  • editing/inserting/insert-at-end-01-expected.png:
  • editing/inserting/insert-at-end-02-expected.checksum:
  • editing/inserting/insert-at-end-02-expected.png:
  • editing/inserting/insert-br-001-expected.checksum:
  • editing/inserting/insert-br-001-expected.png:
  • editing/inserting/insert-br-002-expected.checksum:
  • editing/inserting/insert-br-002-expected.png:
  • editing/inserting/insert-br-003-expected.checksum:
  • editing/inserting/insert-br-003-expected.png:
  • editing/inserting/insert-br-004-expected.checksum:
  • editing/inserting/insert-br-004-expected.png:
  • editing/inserting/insert-br-005-expected.checksum:
  • editing/inserting/insert-br-005-expected.png:
  • editing/inserting/insert-br-006-expected.checksum:
  • editing/inserting/insert-br-006-expected.png:
  • editing/inserting/insert-br-007-expected.checksum:
  • editing/inserting/insert-br-007-expected.png:
  • editing/inserting/insert-br-008-expected.checksum:
  • editing/inserting/insert-br-008-expected.png:
  • editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-001-expected.png:
  • editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-002-expected.png:
  • editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-003-expected.png:
  • editing/inserting/insert-br-quoted-001-expected.checksum:
  • editing/inserting/insert-br-quoted-001-expected.png:
  • editing/inserting/insert-br-quoted-002-expected.checksum:
  • editing/inserting/insert-br-quoted-002-expected.png:
  • editing/inserting/insert-br-quoted-003-expected.checksum:
  • editing/inserting/insert-br-quoted-003-expected.png:
  • editing/inserting/insert-br-quoted-004-expected.checksum:
  • editing/inserting/insert-br-quoted-004-expected.png:
  • editing/inserting/insert-br-quoted-005-expected.checksum:
  • editing/inserting/insert-br-quoted-005-expected.png:
  • editing/inserting/insert-br-quoted-006-expected.checksum:
  • editing/inserting/insert-br-quoted-006-expected.png:
  • editing/inserting/insert-div-025-expected.checksum:
  • editing/inserting/insert-div-025-expected.png:
  • editing/inserting/insert-div-026-expected.checksum:
  • editing/inserting/insert-div-026-expected.png:
  • editing/inserting/insert-space-in-empty-doc-expected.checksum:
  • editing/inserting/insert-space-in-empty-doc-expected.png:
  • editing/inserting/insert-tab-001-expected.checksum:
  • editing/inserting/insert-tab-001-expected.png:
  • editing/inserting/insert-tab-002-expected.checksum:
  • editing/inserting/insert-tab-002-expected.png:
  • editing/inserting/insert-tab-003-expected.checksum:
  • editing/inserting/insert-tab-003-expected.png:
  • editing/inserting/insert-tab-004-expected.checksum:
  • editing/inserting/insert-tab-004-expected.png:
  • editing/inserting/insert-text-at-tabspan-001-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-001-expected.png:
  • editing/inserting/insert-text-at-tabspan-002-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-002-expected.png:
  • editing/inserting/insert-text-at-tabspan-003-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-003-expected.png:
  • editing/inserting/insert-text-with-newlines-expected.checksum:
  • editing/inserting/insert-text-with-newlines-expected.png:
  • editing/inserting/return-key-with-selection-001-expected.checksum:
  • editing/inserting/return-key-with-selection-001-expected.png:
  • editing/inserting/return-key-with-selection-002-expected.checksum:
  • editing/inserting/return-key-with-selection-002-expected.png:
  • editing/inserting/return-key-with-selection-003-expected.checksum:
  • editing/inserting/return-key-with-selection-003-expected.png:
  • editing/inserting/typing-001-expected.checksum:
  • editing/inserting/typing-001-expected.png:
  • editing/inserting/typing-002-expected.checksum:
  • editing/inserting/typing-002-expected.png:
  • editing/inserting/typing-003-expected.checksum:
  • editing/inserting/typing-003-expected.png:
  • editing/inserting/typing-around-br-001-expected.checksum:
  • editing/inserting/typing-around-br-001-expected.png:
  • editing/inserting/typing-around-image-001-expected.checksum:
  • editing/inserting/typing-around-image-001-expected.png:
  • editing/pasteboard/3976872-expected.checksum:
  • editing/pasteboard/3976872-expected.png:
  • editing/pasteboard/4076267-2-expected.checksum:
  • editing/pasteboard/4076267-2-expected.png:
  • editing/pasteboard/4076267-3-expected.checksum:
  • editing/pasteboard/4076267-3-expected.png:
  • editing/pasteboard/4076267-expected.checksum:
  • editing/pasteboard/4076267-expected.png:
  • editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • editing/pasteboard/block-wrappers-necessary-expected.png:
  • editing/pasteboard/cut-text-001-expected.checksum:
  • editing/pasteboard/cut-text-001-expected.png:
  • editing/pasteboard/display-block-on-spans-expected.checksum:
  • editing/pasteboard/display-block-on-spans-expected.png:
  • editing/pasteboard/paste-4035648-fix-expected.checksum:
  • editing/pasteboard/paste-4035648-fix-expected.png:
  • editing/pasteboard/paste-4038267-fix-expected.checksum:
  • editing/pasteboard/paste-4038267-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-line-endings-001-expected.checksum:
  • editing/pasteboard/paste-line-endings-001-expected.png:
  • editing/pasteboard/paste-line-endings-002-expected.checksum:
  • editing/pasteboard/paste-line-endings-002-expected.png:
  • editing/pasteboard/paste-line-endings-003-expected.checksum:
  • editing/pasteboard/paste-line-endings-003-expected.png:
  • editing/pasteboard/paste-line-endings-004-expected.checksum:
  • editing/pasteboard/paste-line-endings-004-expected.png:
  • editing/pasteboard/paste-line-endings-005-expected.checksum:
  • editing/pasteboard/paste-line-endings-005-expected.png:
  • editing/pasteboard/paste-line-endings-006-expected.checksum:
  • editing/pasteboard/paste-line-endings-006-expected.png:
  • editing/pasteboard/paste-line-endings-007-expected.checksum:
  • editing/pasteboard/paste-line-endings-007-expected.png:
  • editing/pasteboard/paste-line-endings-008-expected.checksum:
  • editing/pasteboard/paste-line-endings-008-expected.png:
  • editing/pasteboard/paste-line-endings-009-expected.checksum:
  • editing/pasteboard/paste-line-endings-009-expected.png:
  • editing/pasteboard/paste-line-endings-010-expected.checksum:
  • editing/pasteboard/paste-line-endings-010-expected.png:
  • editing/pasteboard/paste-list-001-expected.checksum:
  • editing/pasteboard/paste-list-001-expected.png:
  • editing/pasteboard/paste-match-style-001-expected.checksum:
  • editing/pasteboard/paste-match-style-001-expected.png:
  • editing/pasteboard/paste-match-style-002-expected.checksum:
  • editing/pasteboard/paste-match-style-002-expected.png:
  • editing/pasteboard/paste-pre-001-expected.checksum:
  • editing/pasteboard/paste-pre-001-expected.png:
  • editing/pasteboard/paste-pre-002-expected.checksum:
  • editing/pasteboard/paste-pre-002-expected.png:
  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/paste-text-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.png:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-018-expected.checksum:
  • editing/pasteboard/paste-text-018-expected.png:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • editing/pasteboard/smart-paste-001-expected.checksum:
  • editing/pasteboard/smart-paste-001-expected.png:
  • editing/pasteboard/smart-paste-002-expected.checksum:
  • editing/pasteboard/smart-paste-002-expected.png:
  • editing/pasteboard/smart-paste-003-expected.checksum:
  • editing/pasteboard/smart-paste-003-expected.png:
  • editing/pasteboard/smart-paste-004-expected.checksum:
  • editing/pasteboard/smart-paste-004-expected.png:
  • editing/pasteboard/smart-paste-005-expected.checksum:
  • editing/pasteboard/smart-paste-005-expected.png:
  • editing/pasteboard/smart-paste-006-expected.checksum:
  • editing/pasteboard/smart-paste-006-expected.png:
  • editing/pasteboard/smart-paste-007-expected.checksum:
  • editing/pasteboard/smart-paste-007-expected.png:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/3690719-expected.png:
  • editing/selection/6476-expected.checksum:
  • editing/selection/6476-expected.png:
  • editing/selection/after-line-wrap-expected.checksum:
  • editing/selection/after-line-wrap-expected.png:
  • editing/selection/end-of-document-expected.checksum:
  • editing/selection/end-of-document-expected.png:
  • editing/selection/expanding-selections-expected.checksum:
  • editing/selection/expanding-selections-expected.png:
  • editing/selection/expanding-selections2-expected.checksum:
  • editing/selection/expanding-selections2-expected.png:
  • editing/selection/extend-by-character-001-expected.checksum:
  • editing/selection/extend-by-character-001-expected.png:
  • editing/selection/extend-by-character-002-expected.checksum:
  • editing/selection/extend-by-character-002-expected.png:
  • editing/selection/extend-by-character-003-expected.checksum:
  • editing/selection/extend-by-character-003-expected.png:
  • editing/selection/extend-by-character-004-expected.checksum:
  • editing/selection/extend-by-character-004-expected.png:
  • editing/selection/extend-by-character-005-expected.checksum:
  • editing/selection/extend-by-character-005-expected.png:
  • editing/selection/extend-by-character-006-expected.checksum:
  • editing/selection/extend-by-character-006-expected.png:
  • editing/selection/extend-by-word-001-expected.checksum:
  • editing/selection/extend-by-word-001-expected.png:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/fake-doubleclick-expected.checksum:
  • editing/selection/fake-doubleclick-expected.png:
  • editing/selection/fake-drag-expected.checksum:
  • editing/selection/fake-drag-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/image-before-linebreak-expected.checksum:
  • editing/selection/image-before-linebreak-expected.png:
  • editing/selection/inline-table-expected.checksum:
  • editing/selection/inline-table-expected.png:
  • editing/selection/leave-requested-block-expected.checksum:
  • editing/selection/leave-requested-block-expected.png:
  • editing/selection/move-backwords-by-word-001-expected.checksum:
  • editing/selection/move-backwords-by-word-001-expected.png:
  • editing/selection/move-between-blocks-no-001-expected.checksum:
  • editing/selection/move-between-blocks-no-001-expected.png:
  • editing/selection/move-by-character-001-expected.checksum:
  • editing/selection/move-by-character-001-expected.png:
  • editing/selection/move-by-character-002-expected.checksum:
  • editing/selection/move-by-character-002-expected.png:
  • editing/selection/move-by-character-003-expected.checksum:
  • editing/selection/move-by-character-003-expected.png:
  • editing/selection/move-by-character-004-expected.checksum:
  • editing/selection/move-by-character-004-expected.png:
  • editing/selection/move-by-character-005-expected.checksum:
  • editing/selection/move-by-character-005-expected.png:
  • editing/selection/move-by-character-6-expected.checksum:
  • editing/selection/move-by-character-6-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/selection/move-by-line-002-expected.checksum:
  • editing/selection/move-by-line-002-expected.png:
  • editing/selection/move-by-word-001-expected.checksum:
  • editing/selection/move-by-word-001-expected.png:
  • editing/selection/previous-line-position-expected.checksum:
  • editing/selection/previous-line-position-expected.png:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/replaced-boundaries-2-expected.checksum:
  • editing/selection/replaced-boundaries-2-expected.png:
  • editing/selection/replaced-boundaries-3-expected.checksum:
  • editing/selection/replaced-boundaries-3-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-box-expected.checksum:
  • editing/selection/select-box-expected.png:
  • editing/selection/selection-3748164-fix-expected.checksum:
  • editing/selection/selection-3748164-fix-expected.png:
  • editing/selection/triple-click-in-pre-expected.checksum:
  • editing/selection/triple-click-in-pre-expected.png:
  • editing/selection/unrendered-001-expected.checksum:
  • editing/selection/unrendered-001-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/selection/unrendered-003-expected.checksum:
  • editing/selection/unrendered-003-expected.png:
  • editing/selection/unrendered-004-expected.checksum:
  • editing/selection/unrendered-004-expected.png:
  • editing/selection/unrendered-005-expected.checksum:
  • editing/selection/unrendered-005-expected.png:
  • editing/style/block-style-004-expected.checksum:
  • editing/style/block-style-004-expected.png:
  • editing/style/block-style-005-expected.checksum:
  • editing/style/block-style-005-expected.png:
  • editing/style/block-style-006-expected.checksum:
  • editing/style/block-style-006-expected.png:
  • editing/style/block-styles-007-expected.checksum:
  • editing/style/block-styles-007-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.png:
  • editing/style/remove-underline-after-paragraph-expected.checksum:
  • editing/style/remove-underline-after-paragraph-expected.png:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.png:
  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-from-stylesheet-expected.checksum:
  • editing/style/remove-underline-from-stylesheet-expected.png:
  • editing/style/remove-underline-in-bold-expected.checksum:
  • editing/style/remove-underline-in-bold-expected.png:
  • editing/style/smoosh-styles-001-expected.checksum:
  • editing/style/smoosh-styles-001-expected.png:
  • editing/style/smoosh-styles-002-expected.checksum:
  • editing/style/smoosh-styles-002-expected.png:
  • editing/style/smoosh-styles-003-expected.checksum:
  • editing/style/smoosh-styles-003-expected.png:
  • editing/style/style-3681552-fix-001-expected.checksum:
  • editing/style/style-3681552-fix-001-expected.png:
  • editing/style/style-3681552-fix-002-expected.checksum:
  • editing/style/style-3681552-fix-002-expected.png:
  • editing/style/style-3690704-fix-expected.checksum:
  • editing/style/style-3690704-fix-expected.png:
  • editing/style/style-3998892-fix-expected.checksum:
  • editing/style/style-3998892-fix-expected.png:
  • editing/style/style-boundary-001-expected.checksum:
  • editing/style/style-boundary-001-expected.png:
  • editing/style/style-boundary-002-expected.checksum:
  • editing/style/style-boundary-002-expected.png:
  • editing/style/style-boundary-003-expected.checksum:
  • editing/style/style-boundary-003-expected.png:
  • editing/style/style-boundary-004-expected.checksum:
  • editing/style/style-boundary-004-expected.png:
  • editing/style/typing-style-001-expected.checksum:
  • editing/style/typing-style-001-expected.png:
  • editing/style/typing-style-002-expected.checksum:
  • editing/style/typing-style-002-expected.png:
  • editing/style/typing-style-003-expected.checksum:
  • editing/style/typing-style-003-expected.png:
  • editing/style/unbold-in-bold-expected.checksum:
  • editing/style/unbold-in-bold-expected.png:
  • editing/style/underline-expected.checksum:
  • editing/style/underline-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/undo/redo-typing-001-expected.checksum:
  • editing/undo/redo-typing-001-expected.png:
  • editing/undo/undo-typing-001-expected.checksum:
  • editing/undo/undo-typing-001-expected.png:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-delete-002-expected.checksum:
  • editing/unsupported-content/list-delete-002-expected.png:
  • editing/unsupported-content/list-delete-003-expected.checksum:
  • editing/unsupported-content/list-delete-003-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.png:
  • editing/unsupported-content/table-delete-001-expected.checksum:
  • editing/unsupported-content/table-delete-001-expected.png:
  • editing/unsupported-content/table-delete-002-expected.checksum:
  • editing/unsupported-content/table-delete-002-expected.png:
  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • fast/css/outline-auto-empty-rects-expected.checksum:
  • fast/css/outline-auto-empty-rects-expected.png:
  • fast/css/outline-auto-location-expected.checksum:
  • fast/css/outline-auto-location-expected.png:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png:
  • fast/events/focusingUnloadedFrame-expected.checksum:
  • fast/events/focusingUnloadedFrame-expected.png:
  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:
  • fast/forms/input-appearance-readonly-expected.checksum: Added.
  • fast/forms/input-appearance-readonly-expected.png: Added.
  • fast/forms/input-appearance-selection-expected.checksum:
  • fast/forms/input-appearance-selection-expected.png:
  • fast/forms/input-paste-undo-expected.checksum: Added.
  • fast/forms/input-paste-undo-expected.png: Added.
  • fast/forms/input-text-double-click-expected.checksum:
  • fast/forms/input-text-double-click-expected.png:
  • fast/forms/input-text-option-delete-expected.checksum:
  • fast/forms/input-text-option-delete-expected.png:
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • fast/forms/input-text-scroll-left-on-blur-expected.png:
  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/overflow/childFocusRingClip-expected.checksum:
  • fast/overflow/childFocusRingClip-expected.png:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
6:16 PM Changeset in webkit [13643] by darin
  • 95 edits in trunk/LayoutTests/editing/selection
  • updated layout test results, mostly for the change in focus ring appearance
6:15 PM Changeset in webkit [13642] by darin
  • 90 edits in trunk/LayoutTests/editing/inserting
  • updated layout test results, mostly for the change in focus ring appearance
6:14 PM Changeset in webkit [13641] by darin
  • 158 edits in trunk/LayoutTests/editing/deleting
  • updated layout test results, mostly for the change in focus ring appearance
6:12 PM Changeset in webkit [13640] by darin
  • 33 edits
    4 adds in trunk/LayoutTests/fast
  • updated layout test results, mostly for the change in focus ring appearance
6:11 PM Changeset in webkit [13639] by darin
  • 23 edits in trunk/WebCore

Reviewed by Adele.

  • some cleanup to how we parse user agent style sheets
  • css/CSSValueKeywords.in: Added -webkit-focus-ring-color.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Parse an array of chars instead of UTF-16. Cuts the size of the style sheet in half. (WebCore::CSSStyleSelector::applyProperty): Allow negative value for outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue instead of repeating the same logic. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case for the focus ring color.
  • rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset): Changed to allow negative values.
  • css/html4.css: Removed a lot of excess spaces. Changed color of focus to -webkit-focus-ring-color. Changed width of focus to 5px. Added an outline-offset for <input type=text> of -2px.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all the time, and as any other color when not in strict mode. I'm confused about what's best for this whole strict mode policy, and I may need advice on Hyatt to perfect this one later. (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because the functions in platform already take care of that. Kept the pinning of a, though because that's done in floating point before converting to an integer. (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.
  • bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list. (WebCore::FrameMac::~FrameMac): Ditto. (WebCore::Frame::setNeedsReapplyStyles): Added.
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
  • platform/mac/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the obsolete Frame::instances.
  • page/Frame.h: Removed instances, mutableInstances, and detachFromView.
  • page/Frame.cpp: Ditto.
  • page/FrameTree.cpp: (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView(). (WebCore::FrameTree::removeChild): Ditto.
  • page/Page.h:
  • page/Page.cpp: (WebCore::Page::init): Added a set of pages instead of a page count. Also register a function for when the focus ring color changes the first time this is called. (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update to manager the set of pages. (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames. (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles on all frames with the passed-in settings.
  • css/make-css-file-arrays.pl: Changed to run the C preprocessor on the input files and to generate an array of char instead of unsigned short.
  • platform/PlatformString.h: Added a constructor that takes a char* and a length.
  • platform/String.cpp: (WebCore::String::String): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like the user agent style sheets.
  • platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit. Added focusRingColor and setFocusRingColorChangeFunction.
  • platform/Color.cpp: (WebCore::makeRGB): Rewrote using max and min. (WebCore::makeRGBA): Ditto. (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of DeprecatedString. (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code. (WebCore::Color::setNamedColor): Changed to use String in the interface.
  • platform/mac/ColorMac.mm: (WebCore::observeTheme): Added. Function used to start up the observer. (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can update all the views when the color changes (including recomputing style to get the color change in). (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus ring colors. Both of these match what AppKit uses -- neither matches what we used to have in the html4.css file. (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when the appearance is changed from blue to graphite and back. We keep a global so we don't have to call over to AppKit every time; that's probably overkill but we need the obsever for the color change function anyway.
12:54 PM Changeset in webkit [13638] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/inline-block/overflow-clip-expected.checksum: Added.
  • fast/inline-block/overflow-clip-expected.png: Added.
  • fast/inline-block/overflow-clip-expected.txt: Added.
  • fast/inline-block/overflow-clip.html: Added.

WebCore:

Test: fast/inline-block/overflow-clip.html

Reviewed by Darin.

  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow when calculating the contribution to the inline's vertical overflows.
5:13 AM Changeset in webkit [13637] by eseidel
  • 11 edits in trunk/WebCore

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Make WebCore safe against KJS::Node in JavaScriptCore private headers.

  • editing/ReplaceSelectionCommand.h:
  • khtml/ecma/JSXMLSerializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toNode): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity): (KJS::toJS): (KJS::getRuntimeObject): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::JSHTMLSelectCollection::put):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::put):
  • kwq/KWQPageState.mm: (-[KWQPageState WebCore::]):
4:41 AM Changeset in webkit [13636] by eseidel
  • 1 edit
    1 add in trunk/JavaScriptGlue

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add missing forwarding header.

  • kxmlcore/Vector.h: Added.
Note: See TracTimeline for information about the timeline view.