⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 2, 2006:

9:56 PM Changeset in webkit [14705] by ddkilzer
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by ggaren.

Test: fast/js/string-replace-3.html

  • kjs/string_object.cpp: (substituteBackreferences): Added support for $& (matched substring), $` (everything preceding matched substring), $' (everything following matched substring) and 2-digit back references, and cleaned up a little.

LayoutTests:

Reviewed by ggaren.

  • fast/js/resources/string-replace-3.js: Added.
  • fast/js/string-replace-3-expected.txt: Added.
  • fast/js/string-replace-3.html: Added.
6:41 PM Changeset in webkit [14704] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Windows theme for textareas. Also made some formatting changes.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::paintTextArea):
  • rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::supportsHover):
6:28 PM Changeset in webkit [14703] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt, checked in by Tim H.

Explicitly run perl on *.pl files instead of relying
on Windows shell figuring out which program to run for
this extention.

  • DerivedSources.make:
6:16 PM Changeset in webkit [14702] by adele
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Set incremental linking to no. This seems to fix a build problem I was seeing
where dftables couldn't find a dll.

6:15 PM Changeset in webkit [14701] by thatcher
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

For: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Added test case to test opacity layers, in particular, opacities
with a value of zero.

  • fast/css/ZeroOpacityLayers.html: Added.
  • fast/css/ZeroOpacityLayers-expected.txt: Added.
  • fast/css/ZeroOpacityLayers-expected.png: Added.
  • fast/css/ZeroOpacityLayers-expected.checksum: Added.
  • fast/css/ZeroOpacityLayers2.html: Added.
  • fast/css/ZeroOpacityLayers2-expected.txt: Added.
  • fast/css/ZeroOpacityLayers2-expected.png: Added.
  • fast/css/ZeroOpacityLayers2-expected.checksum: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Changed RenderLayer to only render layers that are not
totally transparent.

  • rendering/RenderLayer.cpp (RenderLayer::paintLayer): Changed function to also check if the layer is totally transparent and if it is, don't bother painting it.
5:52 PM Changeset in webkit [14700] by thatcher
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

Adding testcase for bug 8223.

  • fast/dom/css-inline-style-important-expected.checksum: Added.
  • fast/dom/css-inline-style-important-expected.png: Added.
  • fast/dom/css-inline-style-important-expected.txt: Added.
  • fast/dom/css-inline-style-important.html: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
WebKit fails to update style on element via DOM

Handle !important by detecting it and using a different code
path from normal priority.

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty):
  • css/CSSStyleDeclaration.h:
5:19 PM Changeset in webkit [14699] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff, checked in by Maciej.



  • dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before calling isFocusable, since isFocusable looks at the size of the renderer.
3:35 PM Changeset in webkit [14698] by brmorris
  • 3 edits in S60/trunk

2006-06-02 Shyam <​Shyam.Sareen@nokia.com>

Reviewed by Zalan/Bradley


  • S60WebUi\HomePage\src\BookmarkPageGen.cpp
  • S60WebUi\HomePage\src\SettingsPageGen.cpp


  • Bookmarks & Setting Menu Options not working on hardware due to overzealous WINS flags.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9256

2:57 PM Changeset in webkit [14697] by brmorris
  • 13 edits
    9 deletes in S60/trunk

2006-06-02 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin


  • Webkit/BrowserControl
  • Webkit/BrowserView
  • S60Internals


  • This is a port of ccm task 11164 (WML interface changes)
2:49 PM Changeset in webkit [14696] by thatcher
  • 1 copy in tags/WebCore-418.12/WebCore

Tag for WebCore 418.12 (part 2 of 2.)

2:49 PM Changeset in webkit [14695] by thatcher
  • 1 add in tags/WebCore-418.12

Tag for WebCore 418.12 (part 1 of 2.)

2:49 PM Changeset in webkit [14694] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:47 PM Changeset in webkit [14693] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin and Eric.

<rdar://problem/4523402> SUTiLondon: XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file

The decoder was returning a null string for the EscapeString stylesheet because it didn't specify an encoding.
If we do not find an encoding we need to assume it is UTF-8.

We also need to load DTD files in xml documents for this test to fully work like Win IE.
Wrapping XMLTokenizer's xmlReadMemory with setLoaderForLibXMLCallbacks to load any files XML needs through the docLoader.

However, this further exposes <rdar://problem/4292995> (libxml2 looks for file in /etc/xml/catalog, but the file is not installed)
This causes Safari to show an error in the activity window about ​file:///etc/xml/catalog. To prevent this we can set
the XML_CATALOG_FILES environment variable to an empty string. We will only set this env var if it hasn't been set already.
This allows someone to launch Safari with a custom catalog if that was ever needed.

  • khtml/misc/decoder.cpp: (Decoder::decode):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::setTransformSource):
1:50 PM Changeset in webkit [14692] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.



For a synchronous XMLHttpRequest, the JavaScript interpreter initiating
the request would deadlock with the JavaScript interpreter spawned by
the request to execute the PAC file.


The solution here is to temporarily drop the initiating interpreter's locks
before making the request, and re-acquire the locks afterwards. Because
the initiating interpreter waits for the request to complete before
continuing execution, it is free to drop its locks while the request
is in progress.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send):
12:35 PM Changeset in webkit [14691] by sfalken
  • 2 edits in trunk/WebKitTools

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated build script

  • Scripts/build-webkit:
12:35 PM Changeset in webkit [14690] by sfalken
  • 3 edits in trunk/WebKitWin

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated to latest hosting interface

  • WebFramePrivate.cpp: (WebKit::WebFramePrivate::openURL): (WebKit::WebFramePrivate::setTitle): (WebKit::WebFramePrivate::setStatusText):
  • WebFramePrivate.h:
12:34 PM Changeset in webkit [14689] by sfalken
  • 5 edits in trunk/WebCore

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

Platform hookup fixes

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::setTitle): (WebCore::FrameWin::setStatusBarText):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::overrideMediaType):
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start): (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):
12:32 PM Changeset in webkit [14688] by sfalken
  • 1 edit
    61 adds in trunk/WebKit

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

New hosting for Spinneret to avoid static linking

  • COM: Added.
  • COM/Interfaces: Added.
  • COM/Interfaces/DOMCSS.idl: Added.
  • COM/Interfaces/DOMCore.idl: Added.
  • COM/Interfaces/DOMHTML.idl: Added.
  • COM/Interfaces/DOMRange.idl: Added.
  • COM/Interfaces/IWebArchive.idl: Added.
  • COM/Interfaces/IWebAttributedString.idl: Added.
  • COM/Interfaces/IWebBackForwardList.idl: Added.
  • COM/Interfaces/IWebDataSource.idl: Added.
  • COM/Interfaces/IWebDocument.idl: Added.
  • COM/Interfaces/IWebDownload.idl: Added.
  • COM/Interfaces/IWebEditingDelegate.idl: Added.
  • COM/Interfaces/IWebError.idl: Added.
  • COM/Interfaces/IWebFrame.idl: Added.
  • COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
  • COM/Interfaces/IWebFrameView.idl: Added.
  • COM/Interfaces/IWebHistoryItem.idl: Added.
  • COM/Interfaces/IWebIconDatabase.idl: Added.
  • COM/Interfaces/IWebImage.idl: Added.
  • COM/Interfaces/IWebMutableURLRequest.idl: Added.
  • COM/Interfaces/IWebNotification.idl: Added.
  • COM/Interfaces/IWebPolicyDelegate.idl: Added.
  • COM/Interfaces/IWebPreferences.idl: Added.
  • COM/Interfaces/IWebResource.idl: Added.
  • COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
  • COM/Interfaces/IWebScriptObject.idl: Added.
  • COM/Interfaces/IWebUIDelegate.idl: Added.
  • COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
  • COM/Interfaces/IWebURLRequest.idl: Added.
  • COM/Interfaces/IWebURLResponse.idl: Added.
  • COM/Interfaces/IWebUndoManager.idl: Added.
  • COM/Interfaces/IWebView.idl: Added.
  • COM/Interfaces/WebKit.idl: Added.
  • COM/WebBackForwardList.cpp: Added. (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::QueryInterface): (WebBackForwardList::AddRef): (WebBackForwardList::Release): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize):
  • COM/WebBackForwardList.h: Added.
  • COM/WebDataSource.cpp: Added. (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::QueryInterface): (WebDataSource::AddRef): (WebDataSource::Release): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::pageTitle): (WebDataSource::unreachableURL): (WebDataSource::webArchive): (WebDataSource::mainResource): (WebDataSource::subresources): (WebDataSource::subresourceForURL): (WebDataSource::addSubresource):
  • COM/WebDataSource.h: Added.
  • COM/WebFrame.cpp: Added. (WebFrame::WebFramePrivate::WebFramePrivate): (WebFrame::WebFramePrivate::~WebFramePrivate): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::createInstance): (WebFrame::QueryInterface): (WebFrame::AddRef): (WebFrame::Release): (WebFrame::initWithName): (WebFrame::name): (WebFrame::webView): (WebFrame::frameView): (WebFrame::DOMDocument): (WebFrame::frameElement): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::loadAlternateHTMLString): (WebFrame::loadArchive): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::findFrameNamed): (WebFrame::parentFrame): (WebFrame::childFrames): (WebFrame::paint): (WebFrame::impl): (WebFrame::loadDataSource): (WebFrame::loading): (WebFrame::goToItem): (WebFrame::loadItem): (WebSystemMainMemory): (WebFrame::getObjectCacheSize): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::openURL): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::setStatusText):
  • COM/WebFrame.h: Added.
  • COM/WebHistoryItem.cpp: Added. (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::QueryInterface): (WebHistoryItem::AddRef): (WebHistoryItem::Release): (WebHistoryItem::initWithURLString): (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval): (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle): (WebHistoryItem::icon):
  • COM/WebHistoryItem.h: Added.
  • COM/WebIconDatabase.cpp: Added. (WebIconDatabase::WebIconDatabase): (WebIconDatabase::~WebIconDatabase): (WebIconDatabase::createInstance): (WebIconDatabase::QueryInterface): (WebIconDatabase::AddRef): (WebIconDatabase::Release): (WebIconDatabase::sharedIconDatabase): (WebIconDatabase::iconForURL): (WebIconDatabase::defaultIconWithSize): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL): (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):
  • COM/WebIconDatabase.h: Added.
  • COM/WebKitClassFactory.cpp: Added. (WebKitClassFactory::WebKitClassFactory): (WebKitClassFactory::~WebKitClassFactory): (WebKitClassFactory::QueryInterface): (WebKitClassFactory::AddRef): (WebKitClassFactory::Release): (WebKitClassFactory::CreateInstance): (WebKitClassFactory::LockServer):
  • COM/WebKitClassFactory.h: Added.
  • COM/WebKitDLL.cpp: Added. (DllMain): (DllGetClassObject): (DllCanUnloadNow): (DllUnregisterServer): (DllRegisterServer):
  • COM/WebKitDLL.h: Added.
  • COM/WebMutableURLRequest.cpp: Added. (WebMutableURLRequest::WebMutableURLRequest): (WebMutableURLRequest::~WebMutableURLRequest): (WebMutableURLRequest::createInstance): (WebMutableURLRequest::QueryInterface): (WebMutableURLRequest::AddRef): (WebMutableURLRequest::Release): (WebMutableURLRequest::requestWithURL): (WebMutableURLRequest::allHTTPHeaderFields): (WebMutableURLRequest::cachePolicy): (WebMutableURLRequest::HTTPBody): (WebMutableURLRequest::HTTPBodyStream): (WebMutableURLRequest::HTTPMethod): (WebMutableURLRequest::HTTPShouldHandleCookies): (WebMutableURLRequest::initWithURL): (WebMutableURLRequest::mainDocumentURL): (WebMutableURLRequest::timeoutInterval): (WebMutableURLRequest::URL): (WebMutableURLRequest::valueForHTTPHeaderField): (WebMutableURLRequest::addValue): (WebMutableURLRequest::setAllHTTPHeaderFields): (WebMutableURLRequest::setCachePolicy): (WebMutableURLRequest::setHTTPBody): (WebMutableURLRequest::setHTTPBodyStream): (WebMutableURLRequest::setHTTPMethod): (WebMutableURLRequest::setHTTPShouldHandleCookies): (WebMutableURLRequest::setMainDocumentURL): (WebMutableURLRequest::setTimeoutInterval): (WebMutableURLRequest::setURL): (WebMutableURLRequest::setValue): (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • COM/WebMutableURLRequest.h: Added.
  • COM/WebView.cpp: Added. (WebView::WebView): (WebView::~WebView): (WebView::createInstance): (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): (WebView::keyPress): (registerWebView): (WebViewWndProc): (calculateScrollDelta): (scrollMessageForKey): (WebView::goToItem): (WebView::QueryInterface): (WebView::AddRef): (WebView::Release): (WebView::canShowMIMEType): (WebView::canShowMIMETypeAsHTML): (WebView::MIMETypesShownAsHTML): (WebView::setMIMETypesShownAsHTML): (WebView::URLFromPasteboard): (WebView::URLTitleFromPasteboard): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setResourceLoadDelegate): (WebView::resourceLoadDelegate): (WebView::setDownloadDelegate): (WebView::downloadDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::setPolicyDelegate): (WebView::policyDelegate): (WebView::mainFrame): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setTextSizeMultiplier): (WebView::textSizeMultiplier): (WebView::setApplicationNameForUserAgent): (WebView::applicationNameForUserAgent): (WebView::setCustomUserAgent): (WebView::customUserAgent): (WebView::userAgentForURL): (WebView::supportsTextEncoding): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::setMediaStyle): (WebView::mediaStyle): (WebView::stringByEvaluatingJavaScriptFromString): (WebView::windowScriptObject): (WebView::setPreferences): (WebView::preferences): (WebView::setPreferencesIdentifier): (WebView::preferencesIdentifier): (WebView::setHostWindow): (WebView::hostWindow): (WebView::searchFor): (WebView::registerViewClass): (WebView::takeStringURLFrom): (WebView::stopLoading): (WebView::reload): (WebView::canGoBack): (WebView::canGoForward): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::computedStyleForElement): (WebView::editableDOMRangeForPoint): (WebView::setSelectedDOMRange): (WebView::selectedDOMRange): (WebView::selectionAffinity): (WebView::setEditable): (WebView::isEditable): (WebView::setTypingStyle): (WebView::typingStyle): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled): (WebView::setContinuousSpellCheckingEnabled): (WebView::isContinuousSpellCheckingEnabled): (WebView::spellCheckerDocumentTag): (WebView::undoManager): (WebView::setEditingDelegate): (WebView::editingDelegate): (WebView::styleDeclarationWithText): (WebView::replaceSelectionWithNode): (WebView::replaceSelectionWithText): (WebView::replaceSelectionWithMarkupString): (WebView::replaceSelectionWithArchive): (WebView::deleteSelection): (WebView::applyStyle): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyFont): (WebView::pasteFont): (WebView::delete_): (WebView::pasteAsPlainText): (WebView::pasteAsRichText): (WebView::changeFont): (WebView::changeAttributes): (WebView::changeDocumentBackgroundColor): (WebView::changeColor): (WebView::alignCenter): (WebView::alignJustified): (WebView::alignLeft): (WebView::alignRight): (WebView::checkSpelling): (WebView::showGuessPanel): (WebView::performFindPanelAction): (WebView::startSpeaking): (WebView::stopSpeaking): (WebView::viewWindow):
  • COM/WebView.h: Added.
  • WebKit.vcproj: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added.
  • WebKit.vcproj/WebKit.def: Added.
  • WebKit.vcproj/WebKit.rc: Added.
  • WebKit.vcproj/WebKit.sln: Added.
  • WebKit.vcproj/WebKit.vcproj: Added.
  • WebKit.vcproj/WebKitGUID.vcproj: Added.
  • WebKit.vcproj/autoversion.h: Added.
  • WebKit.vcproj/resource.h: Added.
10:24 AM Changeset in webkit [14687] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css-generated-content/016-expected.checksum: Added.
  • fast/css-generated-content/016-expected.png: Added.
  • fast/css-generated-content/016-expected.txt: Added.
  • fast/css-generated-content/016.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css-generated-content/016.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style if the unique bit is set. (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property, set the unique bit and add to m_selectorAttrs.
  • rendering/render_style.cpp: Did a lot of reformatting, and this one real change. (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
  • rendering/render_style.h: (WebCore::RenderStyle::unique): Added. Returns value of m_unique. (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
10:04 AM Changeset in webkit [14686] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.


The fix is to mark all DOM Nodes when collecting on an alternate thread --
not just the nodes that are still in a document.


Previously, the DOMObjectsMarker didn't mark DOM nodes that were not in
a document, since we assumed such nodes would either be (a) unreachable
or (b) reachable, and therefore marked elsewhere. However, it seems that
heap/stack entropy allows for (c) non-deterministically reachable by the
conservative garbage collector. So, ironically, we need to mark
DOM nodes that are not in a document to avoid crashing when trying to
mark them later.

  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::DOMObjectsMarker::markOnMainThread): (KJS::DOMObjectsMarker::markOnAlternateThread):
9:39 AM Changeset in webkit [14685] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Anders.

Updated test so that is will once again exercise the fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9009

  • fast/table/empty-section-crash-expected.txt:
  • fast/table/empty-section-crash.html:
2:50 AM Changeset in webkit [14684] by ddkilzer
  • 3034 edits in trunk

LayoutTests:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-1-expected.png: Ditto.
  • editing/selection/7152-1-expected.txt: Ditto.
  • editing/selection/7152-1.html: Changed text in HTML content.
  • editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-2-expected.png: Ditto.
  • editing/selection/7152-2-expected.txt: Ditto.
  • editing/selection/7152-2.html: Changed text in HTML content.
  • *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
12:29 AM Changeset in webkit [14683] by darin
  • 2 edits in trunk/WebKit
  • WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup by include NSObject as a superclass (oops!).

Jun 1, 2006:

11:59 PM Changeset in webkit [14682] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • bridge/win/FrameWin.cpp: Added include of Decoder.h.
11:56 PM Changeset in webkit [14681] by darin
  • 9 edits
    4 deletes in trunk

WebCore:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • WebCore.exp: Removed WebCoreImageRendererFactory.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRendererFactory.h/mm.
  • bridge/mac/WebCoreFrameBridge.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/ImageMac.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/WebCoreImageRendererFactory.h: Removed.
  • platform/mac/WebCoreImageRendererFactory.m: Removed.

WebKit:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • Resources/missing_image.tiff: Removed.
  • WebCoreSupport/WebImageRendererFactory.h: Removed.
  • WebCoreSupport/WebImageRendererFactory.m: Moved @interface in here. Removed all but the "threaded decoding" calls that older Safari calls. This file can go altogether when compatibility with that older Safari is no longer needed.
  • WebKit.xcodeproj/project.pbxproj: Removed WebImageRendererFactory.h and missing_image.tiff.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Removed call to [WebImageRendererFactory createSharedFactory].
11:30 PM Changeset in webkit [14680] by darin
  • 20 edits
    8 copies
    2 moves in trunk/WebCore

Reviewed by Geoff, tweaked a bit by Darin.

  • WebCore.xcodeproj/project.pbxproj: Updated for new files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bindings/js/kjs_traversal.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/objc/DOM.mm:
  • dom/Document.cpp:
  • dom/Document.h: Updated includes.
  • dom/NodeFilter.cpp: Added.
  • dom/NodeFilter.h: Added.
  • dom/NodeFilterCondition.cpp: Added.
  • dom/NodeFilterCondition.h: Added.
  • dom/NodeIterator.cpp: Added.
  • dom/NodeIterator.h: Added.
  • dom/Traversal.cpp: Added.
  • dom/Traversal.h: Added.
  • dom/TreeWalker.cpp: Added.
  • dom/TreeWalker.h: Added.
  • dom/dom2_traversalimpl.cpp: Removed.
  • dom/dom2_traversalimpl.h: Removed.
10:55 PM Changeset in webkit [14679] by darin
  • 23 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej and Adele


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
Updated and extended select/option form tests


  • fast/forms/HTMLOptionElement_label01.html:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.png:
  • fast/forms/HTMLOptionElement_label02.html:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label03.html:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.png
  • fast/forms/HTMLOptionElement_label04.html:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.png
  • fast/forms/HTMLOptionElement_label05.html:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png: Updated to reflect success and added some description


  • fast/forms/HTMLOptionElement_label06.html:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label07.html:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.png: Added.

WebCore:

Reviewed by Maciej and Adele

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
REGRESSION: LABEL in OPTION element is clobbering display #TEXT
Patch provided by Darin.


  • rendering/RenderSelect.cpp (RenderSelect::updateFromElement): Changed to use the containing text by default, and not the label text
10:46 PM Changeset in webkit [14678] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Test the window.screen.pixelDepth and window.screen.colorDepth


  • fast/dom/window/window-screen-properties.html: Added
  • fast/dom/window/window-screen-properties-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Correcting the value returned for window.screen.pixelDepth and
window.screen.colorDepth


  • platform/mac/ScreenMac.mm (screenDepth): Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
8:15 PM Changeset in webkit [14677] by hyatt
  • 4 edits in trunk/WebCore

Fix win32 build bustage.

7:18 PM Changeset in webkit [14676] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Missed an initialization in my last checkin which caused too many
resizers to be drawn.

  • rendering/render_style.cpp: (WebCore::resize): Initialize resize to RESIZE_NONE.
6:13 PM Changeset in webkit [14675] by hyatt
  • 4 edits in trunk/WebCore

Implement form posting via WinINet. This code is crazy... CRAZY

5:05 PM Changeset in webkit [14674] by adele
  • 19 edits
    1 copy in trunk/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9216
Implement CSS3 resize property

  • css/html4.css: Sets resize:both for textareas. This won't affect old-style textareas.
  • css/CSSPropertyNames.in: Added resize property.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added case for CSS_PROP_RESIZE.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): ditto.
  • rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData): Initialize resize.
  • rendering/render_style.h: (WebCore::): Added EResize enum. (WebCore::RenderStyle::resize): (WebCore::RenderStyle::setResize): (WebCore::RenderStyle::initialResize):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_resizeLayer to keep track of a layer that has begun resizing. (WebCore::FrameViewPrivate::reset): Reset m_resizeLayer. (WebCore::FrameView::handleMousePressEvent): If the mouse was pressed in a layer's resize control, then put the layer into resize mode. (WebCore::selectCursor): Updated so we get a pointer cursor for the resize control. (WebCore::FrameView::handleMouseMoveEvent): If there's a layer currently resizing, then tell the layer to continue resizing. (WebCore::FrameView::handleMouseReleaseEvent): If there's a layer currently resizing, then pull it out of resize mode.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Updated so the resize control isn't considered part of the scrollbar.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initialize m_inResizeMode (WebCore::RenderLayer::updateLayerPositions): Calls positionResizeControl. (WebCore::RenderLayer::resize): Added. Sets a new width and height based on the current mouse point. (WebCore::RenderLayer::isPointInResizeControl): Added. (WebCore::RenderLayer::positionResizeControl): Added. (WebCore::RenderLayer::positionScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintResizeControl): Added. (WebCore::RenderLayer::paintLayer): Calls paintResizeControl.
  • rendering/RenderLayer.h: Added m_inResizeMode. (WebCore::RenderLayer::resizeControlRect): (WebCore::RenderLayer::setResizeControlRect): (WebCore::RenderLayer::inResizeMode): Added. (WebCore::RenderLayer::setInResizeMode): Added.
  • platform/mac/ImageMac.mm: (WebCore::Image::loadResource): Moved code from WebImageRendererFactory. Now loads images from WebCore's resources. WebImageRendererFactory is no longer used and should be removed.
  • Resources/missingImage.tiff: Added. Copied from WebKit.
  • WebCore.xcodeproj/project.pbxproj: Added missingImage.tiff
  • loader/Cache.cpp: (WebCore::Cache::init): Updated name from missing_image to missingImage.
  • rendering/RenderTheme.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintResizeControl): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize resizeCornerImage. (WebCore::RenderThemeMac::paintResizeControl): Paints resizeCornerImage.
4:02 PM Changeset in webkit [14673] by beidson
  • 13 edits
    5 adds in trunk

WebKit:
Simple changes to hook up the new WebCore based Icon Database
for testing.
WebCore:
Added the beginnings of sqlite-based code in a WebCore
based version of the Icon Database. Right now the code
is very loosely hooked up through a Bridge and only
creates an sqlite3 database.
There are also changes to our String classes to allow appending
a single character to a String without creating a temporary object.

3:23 PM Changeset in webkit [14672] by andersca
  • 4 edits in trunk/WebCore

2006-06-01 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

  • fixed all places in the Canvas to RenderView rename patch where view() should have been changed to frameView().
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
2:52 PM Changeset in webkit [14671] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

  • http/tests/xmlhttprequest/event-listener-gc.html: Added.
  • http/tests/xmlhttprequest/event-listener-gc-expected.txt: Added.

WebCore:

Fix by Mitz. Reviewed, tweaked, tested, landed by me.


An XMLHttpRequest must be added to the DOMObject cache so that its
DOM implementation object can protect it, and by extension, its event
listeners.


This design seems slightly backwards to me -- the bindings should know
about the DOM, not the other way around -- but I'm restoring it for
now to fix the regression.


  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2:41 PM Changeset in webkit [14670] by andersca
  • 2 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

  • platform/KURL.cpp: (equalIgnoringRef): Whoops. Fix build.


2:29 PM Changeset in webkit [14669] by andersca
  • 19 edits
    2 adds in trunk

WebCore:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • bindings/js/kjs_window.cpp: (KJS::Location::put): Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes are equal.


  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::historyURL):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: New function historyURL which returns the complete URL for a given item in the history.


  • page/Frame.cpp: (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it directly.


  • platform/KURL.cpp:
  • platform/KURL.h: Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working

  • Misc/WebNSURLExtras.m: (-[NSString _webkit_URLFragment]): Don't include the "#" character in the fragment.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge historyURL:]): New function, returns the history URL for a given position in the back/forward list


  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's URL up-to-date.

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): Add clearBackForwardList function to layoutTestController


LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • fast/dom/location-hash-expected.txt: Added.
  • fast/dom/location-hash.html: Added. Added tests.


12:06 PM Changeset in webkit [14668] by andersca
  • 5 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9212
dispatchEvent13.html crashes under GuardMalloc

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::addEventListener): (WebCore::EventTargetNode::removeEventListener): (WebCore::EventTargetNode::handleLocalEvents):


(WebCore::EventTargetNode::removeHTMLEventListener):
(WebCore::EventTargetNode::getHTMLEventListener):

  • dom/EventTargetNode.h: Make the list of registered event listeners refcount the listeners by using a value list of RefPtr objects.


Set removed flag to true in removeEventListener
Only invoke event listeners if they don't have the removed flag.


  • dom/dom2_eventsimpl.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/dom2_eventsimpl.h: Make RegisteredEventListener refcounted.


(WebCore::RegisteredEventListener::removed):
(WebCore::RegisteredEventListener::setRemoved):
Add removed flag and getter and setter

12:01 PM Changeset in webkit [14667] by mjs
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Anders.


  • http/tests/misc/redirect-expected.txt: Added.
  • http/tests/misc/redirect.php: Added.
  • http/tests/misc/resources/redirect-result.php: Added.

WebKit:

Reviewed by Anders.


  • WebView/WebDataSource.m: (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the User-Agent header.
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.m: (-[NSURLProtocol willSendRequest:redirectResponse:]): Pass a mutable URL request so the above can work.
11:33 AM Changeset in webkit [14666] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/focus-body-expected.checksum: Added.
  • editing/selection/focus-body-expected.png: Added.
  • editing/selection/focus-body-expected.txt: Added.
  • editing/selection/focus-body.html: Added.
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4567752> When forwarding a message, pressing TAB key to place caret in body actually selects the entire message instead

  • dom/Element.cpp: (WebCore::Element::focus):
10:35 AM Changeset in webkit [14665] by andersca
  • 6 edits in trunk

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • WebView/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): Use _webkit_objectForMIMEType here so we'll get an object back for "text/".

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)


  • DumpRenderTree/DumpRenderTree.m: (dump): Dump as text when the response MIME type is text/plain

LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)

  • http/tests/incremental/slow-utf8-text-expected.txt: Updated
4:00 AM Changeset in webkit [14664] by ddkilzer
  • 1 edit
    2 adds in trunk/WebCore

2006-06-01 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9144
Test for Bug 8079 (REGRESSION: Redraw from page cache does not show visited links)

  • manual-tests/redraw-page-cache-visited-links.html: Added.
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added.

May 31, 2006:

11:34 PM Changeset in webkit [14663] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/find-next-layer-expected.checksum: Added.
  • fast/css/find-next-layer-expected.png: Added.
  • fast/css/find-next-layer-expected.txt: Added.
  • fast/css/find-next-layer.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css/find-next-layer.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach two levels down in the layer tree and return 0.
11:30 PM Changeset in webkit [14662] by adele
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Changed the uninitialized value of m_tabWidth to -1 and removed the
assertion that it cannot be 0.

  • rendering/RenderBlock.cpp: (WebCore:::RenderBlock::RenderBlock): (WebCore::RenderBlock::setStyle):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth):
11:24 PM Changeset in webkit [14661] by adele
  • 47 edits in trunk/LayoutTests

Updated test results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
11:16 PM Changeset in webkit [14660] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.

WebCore:

Reviewed by Hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
11:07 PM Changeset in webkit [14659] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/table/row-height-recalc-expected.checksum: Added.
  • fast/table/row-height-recalc-expected.png: Added.
  • fast/table/row-height-recalc-expected.txt: Added.
  • fast/table/row-height-recalc.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/table/row-height-recalc.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation if the height property changed.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::recalcCells): Initialize the grid row height to the height of the row element (like addChild() does).
10:56 PM Changeset in webkit [14658] by adele
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::updateLayout): Changed to ensure that pending subtree layouts are performed too.
  • page/Frame.cpp: (WebCore::Frame::forceLayout): Force a full layout.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): Changed to relayout only the subtree rooted at d->layoutRoot if it's non-zero and allowSubtree is true. (WebCore::FrameView::scheduleRelayout): Change pending subtree relayout into normal relayout by clearing d->layoutRoot and propagating needsLayout to the root. (WebCore::FrameView::scheduleRelayoutOfSubtree): Added.
  • page/FrameView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Added scheduleRelayout parameter. FrameView passes false to force marking all the way to the root when turning a pending subtree relayout into a full relayout. Otherwise, marking stops at the first textField (or at the root) and relayout of the last object reached is scheduled. (WebCore::RenderObject::scheduleRelayout):
  • rendering/RenderObject.h:
10:35 PM Changeset in webkit [14657] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8910>
Bug 8910: Various code cleanups in RenderBox


Clean up with some slight optimizations.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing):
  • rendering/RenderBox.h:
10:28 PM Changeset in webkit [14656] by adele
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8899>
Bug 8899: Removes some unneeded code from RenderBox


Removes the use of WidthType where not needed to simplify
the code a little.


  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
  • rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
10:09 PM Changeset in webkit [14655] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Testcase for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455

  • fast/forms/select-reset.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
selectedIndex for a select after a Form reset() has wrong value

Make sure the list items are reset properly by selecting
the first option in case no options have the selected attribute
set.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
10:02 PM Changeset in webkit [14654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Add a test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024

  • fast/dom/document-all-input.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
"Go" button (search) doesn't work at fifa.com (document.all.FormName)

Allow input elements with name attributes as possible named
items for document.all.

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
6:06 PM Changeset in webkit [14653] by hyatt
  • 2 edits in trunk/WebCore/platform/win

Tweaks to remove fragments when loading urls via wininet or cookies.

3:19 PM Changeset in webkit [14652] by hyatt
  • 3 edits
    9 adds in trunk/WebCore

Add stubs for bmp/ico/xbm decoders on win32.

2:36 PM Changeset in webkit [14651] by hyatt
  • 14 edits in trunk

WebCore:

Fix for the gmail tab-focus-stealing bug.

Reviewed by darin

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::focusWindow):
  • platform/win/WidgetWin.cpp:

WebKit:

Make programmatic focus/blur actually work on sub-frames. Make the
top-level UI delegate get called for deactivation of windows.

Reviewed by darin

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge activateWindow]): (-[WebFrameBridge deactivateWindow]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebKit.xcodeproj/project.pbxproj:
2:30 PM Changeset in webkit [14650] by bdakin
  • 7 edits
    73 adds in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3:
Borders rounded with border-radius don't draw the roundings

This patch does not draw all of the different border styles
perfectly, so I have filed a few followup bugs that I will
reference from this Bugzilla.

  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawArc): drawArc() has different parameters now, but mostly this needs to be implemented to match the Mac side later. (WebCore::GraphicsContext::addRoundedRectClip): Just a stub. Implement this later. (WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub. Implement this later.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawArc): drawArc() now handles drawing elliptical arcs as well as circular arcs, it also takes a thickness parameter to draw an arc of a given thickness and draws with the appropriate pen style. (WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to the inside of an arc instead of to the outside which is already done by addRoundedClipRect()
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): Draws the border arcs in the appropriate styles. (WebCore::RenderObject::paintBorder): Calls drawBorderArc() when border arcs are needed.
  • rendering/RenderObject.h:
1:05 PM Changeset in webkit [14649] by hyatt
  • 2 edits in trunk/WebCore

Fix Win32 build bustage from Screen/Page FloatRect conversion

11:11 AM Changeset in webkit [14648] by brmorris
  • 8 edits in S60/trunk

S60WebKit:

2006-05-30 Pat <​vincent.bradley@nokia.com>

Reviewed by Bradley/Zalan


  • S60WebUi/WebUi/data/WebUi.rss
  • S60WebUi/WebUi/inc/WebUi.hrh
  • S60WebUi/WebUi/inc/WebUiAutomatedTests.h
  • S60WebUi/WebUi/src/WebUiAutomatedTests.cpp
  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp


11:04 AM Changeset in webkit [14647] by darin
  • 1 delete in trunk/WebCore/RenderView.cpp

Remove accidentally-checked-in file.

10:25 AM Changeset in webkit [14646] by eseidel
  • 121 edits
    1 copy
    12 moves
    10 adds
    6 deletes in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add first-cut SVG JS bindings autogeneration.
SVGSVGElement and various other support classes are generated.
Various small style fixes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4249

  • DerivedSources.make:
  • WebCore+SVG/RGBColor.cpp: Removed.
  • WebCore+SVG/RGBColor.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): renamed from createJSWrapper
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::toBoolean): (KJS::DOMNode::getOwnPropertySlot): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::put): (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNodeListFunc::callAsFunction): (KJS::toElement): (KJS::toDocumentType): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMap::~DOMNamedNodeMap): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::toJS): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (KJS::DOMExceptionConstructor::getOwnPropertySlot): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::getDOMExceptionConstructor): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/Element.h:
  • dom/StyledElement.h:
  • ksvg2/bindings/idl/svg/SVGAngle.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGColor.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGDocument.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGMatrix.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPoint.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGRect.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGSVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGTransform.idl: Removed.
  • ksvg2/bindings/idl/svg/kdomdefs.idl: Removed.
  • ksvg2/bindings/js: Added.
  • ksvg2/bindings/js/JSSVGNumber.cpp: Added. (WebCore::): (WebCore::JSSVGNumber::~JSSVGNumber): (WebCore::JSSVGNumber::getOwnPropertySlot): (WebCore::JSSVGNumber::getValue): (WebCore::getJSSVGNumber):
  • ksvg2/bindings/js/JSSVGNumber.h: Added. (WebCore::JSSVGNumber::JSSVGNumber): (WebCore::JSSVGNumber::classInfo):
  • ksvg2/bindings/js/JSSVGPoint.cpp: Added. (WebCore::): (WebCore::JSSVGPoint::~JSSVGPoint): (WebCore::JSSVGPoint::getOwnPropertySlot): (WebCore::JSSVGPoint::getValueProperty): (WebCore::getJSSVGPoint): (WebCore::toFloatPoint):
  • ksvg2/bindings/js/JSSVGPoint.h: Added. (WebCore::JSSVGPoint::JSSVGPoint): (WebCore::JSSVGPoint::classInfo): (WebCore::JSSVGPoint::): (WebCore::JSSVGPoint::impl):
  • ksvg2/bindings/js/JSSVGRect.cpp: Added. (WebCore::): (WebCore::JSSVGRect::~JSSVGRect): (WebCore::JSSVGRect::getOwnPropertySlot): (WebCore::JSSVGRect::getValueProperty): (WebCore::getJSSVGRect): (WebCore::toFloatRect):
  • ksvg2/bindings/js/JSSVGRect.h: Added. (WebCore::JSSVGRect::JSSVGRect): (WebCore::JSSVGRect::classInfo): (WebCore::JSSVGRect::): (WebCore::JSSVGRect::impl):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/events/SVGZoomEvent.cpp: (SVGZoomEvent::SVGZoomEvent): (SVGZoomEvent::zoomRectScreen): (SVGZoomEvent::previousTranslate): (SVGZoomEvent::newTranslate):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h: (WebCore::):
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addTimeContainer): (WebCore::SVGDocumentExtensions::removeTimeContainer): (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h: (WebCore::SVGAngle::):
  • ksvg2/svg/SVGAngle.idl: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement): (WebCore::SVGAnimateColorElement::handleTimerEvent): (WebCore::SVGAnimateColorElement::clampColor):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp: (SVGAnimateElement::SVGAnimateElement): (SVGAnimateElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::parseMappedAttribute): (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix): (WebCore::SVGAnimateTransformElement::initialMatrix):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedLength.idl: Added.
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::rgbColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::color):
  • ksvg2/svg/SVGColor.h: (WebCore::SVGColor::): (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGColor.idl: Added.
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.idl: Added.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::isSupported): (WebCore::SVGElement::id): (WebCore::SVGElement::setId): (WebCore::SVGElement::xmlbase): (WebCore::SVGElement::setXmlbase): (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement): (WebCore::SVGElement::tryGetAttribute): (WebCore::SVGElement::tryGetAttributeNS): (WebCore::SVGElement::childShouldCreateRenderer):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGEvent.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport): (WebCore::SVGHelper::ParseSeperatedList):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.h: (WebCore::SVGLength::):
  • ksvg2/svg/SVGLength.idl: Added.
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGLocatable.cpp: (SVGLocatable::getBBox):
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::inverse): (SVGMatrix::rotateFromVector):
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGMatrix.idl: Added.
  • ksvg2/svg/SVGNumber.idl: Added.
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::x): (WebCore::SVGPatternElement::y): (WebCore::SVGPatternElement::width): (WebCore::SVGPatternElement::height): (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyClientsToRepaint): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::canvasResource): (WebCore::SVGPatternElement::getCTM):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.idl: Added.
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.idl: Added.
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::unsuspendRedraw): (WebCore::SVGSVGElement::getIntersectionList): (WebCore::SVGSVGElement::getEnclosureList): (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure): (WebCore::SVGSVGElement::createSVGNumber): (WebCore::SVGSVGElement::createSVGPoint): (WebCore::SVGSVGElement::createSVGRect): (WebCore::SVGSVGElement::pauseAnimations): (WebCore::SVGSVGElement::unpauseAnimations): (WebCore::SVGSVGElement::animationsPaused): (WebCore::SVGSVGElement::getCurrentTime): (WebCore::SVGSVGElement::setCurrentTime):
  • ksvg2/svg/SVGSVGElement.h: (WebCore::SVGSVGElement::timeScheduler):
  • ksvg2/svg/SVGSVGElement.idl: Added.
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::SVGSetElement): (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp: (SVGStyledLocatableElement::getBBox):
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::getBBox):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::getStartPositionOfChar): (SVGTextContentElement::getEndPositionOfChar): (SVGTextContentElement::getExtentOfChar): (SVGTextContentElement::getCharNumAtPosition): (SVGTextContentElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getBBox):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h: (WebCore::SVGTransform::):
  • ksvg2/svg/SVGTransform.idl: Added.
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::pauseTimeouts): (WebCore::Frame::resumeTimeouts):
  • platform/Color.h:
  • rendering/RenderBR.h:
  • rendering/RenderBox.h: (WebCore::RenderBox::renderName):
  • rendering/RenderCanvas.h: (WebCore::RenderCanvas::view):
  • rendering/RenderContainer.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderInline.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderTextFragment.h: (WebCore::RenderTextFragment::contentString):
  • xml/xmlattrs.in: Added.
9:51 AM Changeset in webkit [14645] by brmorris
  • 2 edits in S60/trunk/S60WebUi/WebUi/src

2006-05-30 Zalan <​zbujtas@gmail.com>

Second commit, Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


9:50 AM Changeset in webkit [14644] by brmorris
  • 1 edit
    2 adds in S60/trunk

2006-05-30 Zalan <​zbujtas@gmail.com>

Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


12:48 AM Changeset in webkit [14643] by ggaren
  • 15 edits
    1 move in trunk/WebCore

Reviewed by Maciej.

  • Fixed <rdar://problem/4559720> window sizing: make javascript window and screen sizing methods and properties work @ HIDPI


The general approach here is to change some ints to floats, make
a few key functions that scale between WebView and window/screen
coordinates, and change other functions that work with screen
coordinates to use the scaling functions for their underlying
implementations.

  • manual-tests/window-open-features.html: Removed.
  • manual-tests/window-sizing.html: Added. More test coverage.
  • bindings/js/kjs_window.cpp: Changed ints to floats and IntRects to FloatRects, because window coordinates can be fractional when scaled to WebView/DOM coordinates. (KJS::floatFeature): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Removed custom scaling code and replaced with calls to Page::windowRect and Page::setWindowRect. Renamed 'page' and 'bridge' to 'pageBridge' and 'frameBridge,' respectively.
  • bridge/mac/PageMac.mm: (WebCore::Page::windowRect): Changed to use scaling (WebCore::Page::setWindowRect): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (globalPoint):
  • page/Page.h:
  • platform/IntRect.h:
  • platform/Screen.h:
  • platform/mac/MouseEventMac.mm: (WebCore::globalPositionForEvent): Changed to use flipScreenPoint
  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): New key function (WebCore::flipScreenPoint): New key function (WebCore::scaleScreenRectToView): New key function (WebCore::scaleViewRectToScreen): New key function (WebCore::screenRect): Changed to use scaling (WebCore::usableScreenRect): ditto

Feeble attempt to preserve Windows build:


  • platform/win/ScreenWin.cpp: (WebCore::scaleScreenRectToWidget): stub -- doesn't actually scale (WebCore::scaleWidgetRectToScreen): ditto
  • bridge/win/PageWin.cpp: (WebCore::Page::Page): (WebCore::Page::widget):
12:12 AM Changeset in webkit [14642] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderView.h

Fix layout tests.

May 30, 2006:

9:12 PM Changeset in webkit [14641] by thatcher
  • 1 copy in tags/WebCore-418.11/WebCore

Tag for WebCore 418.11 (part 2 of 2.)

9:12 PM Changeset in webkit [14640] by thatcher
  • 1 add in tags/WebCore-418.11

Tag for WebCore 418.11 (part 1 of 2.)

9:11 PM Changeset in webkit [14639] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

6:48 PM Changeset in webkit [14638] by hyatt
  • 41 edits
    1 copy
    2 moves in trunk/WebCore

Rename RenderCanvas to RenderView. Rename canvas(), isCanvas()
to view(), isView(). Rename the frame view accessor on the old canvas
from view() to frameView() (to avoid view()->view(), since that just looks
stupid). :)

Reviewed by andersca

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]):
  • dom/Document.cpp: (WebCore::Document::attach): (WebCore::Document::updateSelection): (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentTranslate):
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::view): (WebCore::SVGStyledElement::pushAttributeContext):
  • ksvg2/svg/SVGStyledElement.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityShouldUseUniqueId]): (-[WebCoreAXObject role]): (-[WebCoreAXObject value]): (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityIsIgnored]): (-[WebCoreAXObject accessibilityAttributeNames]): (-[WebCoreAXObject topView]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • page/Frame.cpp: (WebCore::Frame::selectionRect): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • rendering/AutoTableLayout.cpp: (WebCore::shouldScaleColumns):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::calcBlocminMaxWidth): (WebCore::RenderBlock::inRootBlockContext):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::availableHeightUsing):
  • rendering/RenderCanvas.cpp: Removed.
  • rendering/RenderCanvas.h: Removed.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
  • rendering/RenderFileButton.cpp: (WebCore::RenderFileButton::RenderFileButton):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::paintLines):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::setResizing):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollToOffset): (WebCore::isSubframeCanvas): (WebCore::RenderLayer::intersectsDamageRect):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isStackingContext):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::selectionStartEnd): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::viewRect): (WebCore::RenderObject::view): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::maximalOutlineSize):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderView):
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::RenderTextArea):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
  • rendering/RenderView.cpp: Added. (WebCore::RenderView::RenderView): (WebCore::RenderView::~RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::calcMinMaxWidth): (WebCore::RenderView::layout): (WebCore::RenderView::absolutePosition): (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations): (WebCore::RenderView::repaintViewRectangle): (WebCore::RenderView::getAbsoluteRepaintRect): (WebCore::RenderView::computeAbsoluteRepaintRect): (WebCore::RenderView::absoluteRects): (WebCore::RenderView::selectionRect): (WebCore::RenderView::setSelection): (WebCore::RenderView::clearSelection): (WebCore::RenderView::selectionStartEnd): (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h: Added. (WebCore::RenderView::renderName): (WebCore::RenderView::isRenderView): (WebCore::RenderView::frameView):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::updateWidgetPosition):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::widget):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
6:31 PM Changeset in webkit [14637] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4567776> REGRESSION: window.open() links do not work at www.newarchery.com

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Set the URL in the ResourceRequest; otherwise, it'll be uninitialized and createNewWindow() will not be able to load the URL into a pre-existing frame.
2:56 PM Changeset in webkit [14636] by lweintraub
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by justin.

<rdar://problem/4039661> crash in ApplyStyleCommand::applyBlockStyle(DOM::CSSMutableStyleDeclarationImpl*, DOM::Position const&, DOM::Position const&) pasting contents of webpage into Mail or Blot
<rdar://problem/4029632> Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Swap reversed start and end selection points to avoid null dereference. (khtml::ApplyStyleCommand::removeInlineStyle): Modified assert to not complain about caret selections.
2:53 PM Changeset in webkit [14635] by brmorris
  • 1 edit
    1 add in S60/trunk

S60WebKit:

2006-05-30 Bradley Morrison <​bradley.morrison@nokia.com>

Reviewed by Antti K/Zalan


2:10 PM Changeset in webkit [14634] by bdakin
  • 3 edits
    8 adds in trunk

Reviewed by Maciej, landed by Beth.

Adds special case.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
1:47 PM Changeset in webkit [14633] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Hyatt, landed by Beth.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
11:57 AM Changeset in webkit [14632] by thatcher
  • 1 copy in tags/JavaScriptCore-418.3/JavaScriptCore

Tag for JavaScriptCore 418.3 (part 2 of 2.)

11:57 AM Changeset in webkit [14631] by thatcher
  • 1 add in tags/JavaScriptCore-418.3

Tag for JavaScriptCore 418.3 (part 1 of 2.)

11:56 AM Changeset in webkit [14630] by thatcher
  • 1 copy in tags/WebCore-418.10/WebCore

Tag for WebCore 418.10 (part 2 of 2.)

11:56 AM Changeset in webkit [14629] by thatcher
  • 1 add in tags/WebCore-418.10

Tag for WebCore 418.10 (part 1 of 2.)

11:55 AM Changeset in webkit [14628] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

11:32 AM Changeset in webkit [14627] by thatcher
  • 3 copies in tags/WebKit-521.12/WebKit

New tag (part 2)

11:31 AM Changeset in webkit [14626] by thatcher
  • 1 add in tags/WebKit-521.12

New tag

11:30 AM Changeset in webkit [14625] by thatcher
  • 2 copies in tags/WebCore-521.12/WebCore

New tag (part 2)

11:28 AM Changeset in webkit [14624] by thatcher
  • 1 add in tags/WebCore-521.12

New tag

11:20 AM Changeset in webkit [14623] by thatcher
  • 4 edits in /

Versioning

9:22 AM Changeset in webkit [14622] by thatcher
  • 8 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Maciej.


  • Rolling out the 'currentThreadIsMainThread' argument passed to Interpreter::mark because the fix for <rdar://problem/4562599> makes it superfluous.


  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.h: (KJS::Interpreter::mark):

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562599> 10.4.7 regression: After closing a window that contains macworld.com, creating a new window results in crash (KJS::PropertyMap::mark() )

ScriptInterpreter used to be responsible for marking cached DOM objects.
That was insufficient because once all the windows are closed, there's
no ScriptInterpreter left to do the marking.


The solution here is to allocate a static, protected 'DOMObjectsMarker'
object that takes care of marking the DOM object caches.


  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument):
  • khtml/ecma/kjs_binding.h:
1:34 AM Changeset in webkit [14621] by eseidel
  • 6 edits in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Small amount of svg-related code cleanup.
No test case possible.

  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGLength.cpp: (SVGLength::SVGLength): (SVGLength::value):
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::SVGMatrix): (SVGMatrix::copy): (SVGMatrix::postMultiply): (SVGMatrix::inverse): (SVGMatrix::postTranslate): (SVGMatrix::postScale): (SVGMatrix::postScaleNonUniform): (SVGMatrix::postRotate): (SVGMatrix::postRotateFromVector): (SVGMatrix::postFlipX): (SVGMatrix::postFlipY): (SVGMatrix::postSkewX): (SVGMatrix::postSkewY): (SVGMatrix::multiply): (SVGMatrix::translate): (SVGMatrix::scale): (SVGMatrix::scaleNonUniform): (SVGMatrix::rotate): (SVGMatrix::rotateFromVector): (SVGMatrix::flipX): (SVGMatrix::flipY): (SVGMatrix::skewX): (SVGMatrix::skewY): (SVGMatrix::setMatrix): (SVGMatrix::qmatrix): (SVGMatrix::removeScale):
  • ksvg2/svg/SVGMatrix.h:
1:30 AM Changeset in webkit [14620] by eseidel
  • 5 edits in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Small ammount of bindings-related code cleanup.
No test case possible.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSXMLSerializer.cpp: (WebCore::JSXMLSerializerConstructorImp::JSXMLSerializerConstructorImp): (WebCore::JSXMLSerializerConstructorImp::implementsConstruct): (WebCore::JSXMLSerializerConstructorImp::construct): (WebCore::): (WebCore::JSXMLSerializer::JSXMLSerializer): (WebCore::JSXMLSerializerProtoFunc::callAsFunction):
  • bindings/js/JSXMLSerializer.h: (WebCore::JSXMLSerializer::toBoolean): (WebCore::JSXMLSerializer::classInfo): (WebCore::JSXMLSerializer::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

May 27, 2006:

11:33 AM Changeset in webkit [14619] by andersca
  • 2 edits in trunk/WebCore

2006-05-27 Anders Carlsson <​acarlsson@apple.com>

  • bindings/js/JSHTMLElementWrapperFactory.cpp: Correct include file names.

May 26, 2006:

7:23 PM Changeset in webkit [14618] by justing
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

Added, test for the crash by focusing an editable html element and then
inserting a tab

  • editing/selection/editable-html-element-expected.checksum: Added.
  • editing/selection/editable-html-element-expected.png: Added.
  • editing/selection/editable-html-element-expected.txt: Added.
  • editing/selection/editable-html-element.html: Added. Fixed:
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message

  • dom/Position.cpp: (WebCore::Position::inRenderedContent): Removed a candidate at [html, 0].
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/Selection.cpp: (WebCore::Selection::validate): If visible positions can't be created from the endpoints, then create a null selection. Not doing this was making editing code think there was a valid, editable selection even though there wasn't.
  • editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Early return.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary. It looks like a non-editable/editable boundary since rootEditableElement stops at the body even if the html element is editable.
3:17 PM Changeset in webkit [14617] by adele
  • 2 edits in trunk/WebCore

Reviewed by Justin.

Fixes a mistake in my last checkin. Uses maxDeepOffset to get the end position for
the textarea's inner div.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks):
2:13 PM Changeset in webkit [14616] by adele
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Added test for new textarea implementation. Tests
wrap attributes and form submission.

  • fast/forms/textarea-appearance-wrap-expected.txt: Added.
  • fast/forms/textarea-appearance-wrap.html: Added.

WebCore:

Reviewed by Hyatt.

Added support for wrap=hard for new textarea implementation.

Tests: fast/forms/textarea-appearance-wrap.html

  • dom/Range.h: Added version of toString that will convert BRs to newlines.
  • dom/Range.cpp: (WebCore::Range::toString):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): When in plain-text mode, and a white-space mode that doesn't collapse whitespace, create a fragment with one text node.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Subtract scroll offset so the absolute position for the containing block is correct. (WebCore::nextLinePosition): ditto.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): If the position is equal to the left edge of the box, make the affinity downstream so the position doesn't jump back to the previous line. (WebCore::RenderText::atLineWrap): The logic was reversed here in a recent change. If the box is not at a line break, then its at a line wrap. (WebCore::RenderText::caretRect): Only go to the next text box if its at a line wrap and the affinity is also downstream. If its upstream, then the correct box is on the current line. (WebCore::RenderText::inlineBox): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): multi line controls don't need to check valueMatchesRenderer before updating the renderer. For textareas, the renderer should always try to update. This matches our old textarea behavior. (WebCore::RenderTextField::text): Pass true to textContent so it converts BRs to newlines. (WebCore::RenderTextField::textWithHardLineBreaks): Iterate through the RootLineBoxes to find the soft wraps and replace them with newlines.
1:30 PM Changeset in webkit [14615] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::handleLocalEvents): Invoke capturing event listeners for the AT_TARGET phase. This violates the DOM spec but it's what Mozilla does.

LayoutTests:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET

  • dom/html/level2/events/dispatchEvent09-expected.txt:
  • dom/xhtml/level2/events/dispatchEvent09-expected.txt: These fail now.


  • fast/dom/capturing-event-listeners-expected.txt: Added.
  • fast/dom/capturing-event-listeners.html: Added.


12:34 PM Changeset in webkit [14614] by harrison
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel

  • WebView/WebHTMLView.m: (-[WebHTMLView _increaseSelectionListLevel]):
  • Now returns DOMNode*

(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):

  • Added. These also return DOMNode*
  • WebView/WebHTMLViewPrivate.h:
  • Updated as above
12:31 PM Changeset in webkit [14613] by harrison
  • 7 edits
    2 moves in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • Renamed ModifySelectionListLevelCommand .cpp and .h to ModifySelectionListLevel .cpp and .h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
  • Call functions in IncreaseSelectionListLevelCommand or DecreaseSelectionListLevelCommand instead of ModifySelectionListLevelCommand.


(-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
(-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):

  • Added.


  • editing/ModifySelectionListLevel.cpp: Added.
  • Renamed from ModifySelectionListLevelCommand.cpp
  • Made ModifySelectionListLevelCommand class into a useful base class for new classes IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand.


(WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
(WebCore::getStartEndListChildren):
(WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore):
(WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange):

  • ModifySelectionListLevelCommand is base class for IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand


(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
(WebCore::IncreaseSelectionListLevelCommand::listElement):
(WebCore::canIncreaseListLevel):
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
(WebCore::increaseSelectionListLevelWithType):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

  • Now a subclass of ModifySelectionListLevelCommand
  • Added Ordered and Unordered increaser functions
  • Increaser functions return the list element that the items were moved into


(WebCore::DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand):
(WebCore::canDecreaseListLevel):
(WebCore::DecreaseSelectionListLevelCommand::doApply):
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
(WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel):

  • No functional changes other than to become a subclass of ModifySelectionListLevelCommand
  • editing/ModifySelectionListLevel.h: Added. (WebCore::):
    • Renamed from ModifySelectionListLevelCommand.cpp


  • editing/ModifySelectionListLevelCommand.cpp: Removed.
  • Renamed to ModifySelectionListLevel.cpp


  • editing/ModifySelectionListLevelCommand.h: Removed.
  • Renamed to ModifySelectionListLevel.h
  • editing/htmlediting.cpp: (WebCore::createOrderedListElement): (WebCore::createUnorderedListElement):
  • editing/htmlediting.h:
12:26 PM Changeset in webkit [14612] by brmorris
  • 1 edit in S60/trunk/build.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by dacarson.

build.bat now deletes outdated headers.
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9126)

11:58 AM Changeset in webkit [14611] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8347>
REGRESSION: Flash movie audible but not visible until window is resized

  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView dataSourceUpdated:]): Layout if needed here. Maciej recently removed the "LayoutAcceptable" frame state, which used to cause plugin document views to lay out immediately upon receiving data. This call to -layout has the same effect.
11:11 AM Changeset in webkit [14610] by sfalken
  • 4 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Build fixes/tweaks

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • ksvg2/scripts/make_names.pl:
1:12 AM Changeset in webkit [14609] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

1:10 AM Changeset in webkit [14608] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj:
1:07 AM Changeset in webkit [14607] by sfalken
  • 3 edits in trunk/WebKitTools

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.vcproj:

May 25, 2006:

5:36 PM Changeset in webkit [14606] by sfalken
  • 3 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Fix build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
5:28 PM Changeset in webkit [14605] by hyatt
  • 2 edits in trunk/WebCore

Set the fixed pitch hardcoded default to 13 on windows.

5:24 PM Changeset in webkit [14604] by hyatt
  • 1 edit in trunk/WebKitTools/Spinneret/Spinneret/Spinneret.cpp

Make sure Spinneret inits and shuts down COM like a good boy.

5:19 PM Changeset in webkit [14603] by aliceli1
  • 2 adds in trunk/LayoutTests/fast/forms
5:15 PM Changeset in webkit [14602] by aliceli1
  • 5 edits in trunk/WebCore

Reviewed by Adele.

  • bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
  • bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
  • html/HTMLSelectElement.h: added prototype for namedItem method
4:45 PM Changeset in webkit [14601] by hyatt
  • 2 edits in trunk/WebCore

Add soft hyphen support for Win32.

4:18 PM Changeset in webkit [14600] by hyatt
  • 2 edits in trunk/WebCore

Implement containsCharacters method on Win32 for determining if a fallback font has the necessary glyphs to be used.

3:42 PM Changeset in webkit [14599] by hyatt
  • 7 edits
    1 add
    1 delete in trunk/WebCore

Remove the logical scale factor from Cairo Win32 fonts.

3:17 PM Changeset in webkit [14598] by eseidel
  • 5 edits
    3 adds in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

Test: fast/table/border-collapsing/border-collapsing-head-foot.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::sectionAbove): Added. (WebCore::RenderTable::sectionBelow): Added. (WebCore::RenderTable::cellAbove): Changed to call sectionAbove. (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove. (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.
3:11 PM Changeset in webkit [14597] by eseidel
  • 39 edits in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Assign the row renderer to the grid row. (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug and add vertical spacing only for grid rows that have a renderer. (WebCore::RenderTableSection::recalcCells): Assign row renderers to grid rows.
3:05 PM Changeset in webkit [14596] by eseidel
  • 1 delete in trunk/WebCore/WebCore

Remove bogus directory

3:00 PM Changeset in webkit [14595] by eseidel
  • 9 edits in trunk/WebCore

2006-05-19 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

Make sure SVGDocument is created for standalone svg
documents.

  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::instance): (SVGDOMImplementation::createDocument):
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::~SVGDocument):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • page/Frame.cpp: (WebCore::Frame::begin):
2:55 PM Changeset in webkit [14594] by eseidel
  • 5 edits
    6 adds
    2 deletes in trunk/WebCore

2006-05-17 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5889
HTMLNames.* should be generated using make_names.pl

Use a patched make_names.pl to autogenerate HTMLNames.*

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLNames.cpp: Removed.
  • html/HTMLNames.h: Removed.
  • html/HTMLTagNames.in: Added.
  • html/HTMLAttributeNames.in: Added.
  • ksvg2/scripts/make_names.pl:
2:41 PM Changeset in webkit [14593] by eseidel
  • 24 edits
    5 adds in trunk

2006-05-23 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add "HasIndexGetter" support to bindings autogen system.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9057

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLInputElementBase.cpp:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValueList.idl: Added.
1:15 PM Changeset in webkit [14592] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix

12:10 PM Changeset in webkit [14591] by thatcher
  • 3 copies in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:09 PM Changeset in webkit [14590] by thatcher
  • 1 delete in tags/WebKit-521.11.1/WebKit

Bad tag.

12:09 PM Changeset in webkit [14589] by thatcher
  • 1 copy in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:07 PM Changeset in webkit [14588] by thatcher
  • 1 add in tags/WebKit-521.11.1

Tag for WebKit 521.11.1 (part 1 of 2.)

12:06 PM Changeset in webkit [14587] by thatcher
  • 2 edits in /

Versioning

12:00 PM Changeset in webkit [14586] by thatcher
  • 27 edits
    1 add in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4559808> WebKit fails to compile for ppc64
<rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
<rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

  • Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
  • Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
  • Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772> (HIWebViewEventHandler):
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
  • History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]):
  • Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]):
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
  • Misc/WebSearchableTextView.m: (-[NSString selectionRect]):
  • Misc/WebTypesInternal.h: Added.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath):
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]):
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector):
  • WebInspector/WebInspector.m: (-_updateSystemColors):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]):
  • WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
  • WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]):
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
10:57 AM Changeset in webkit [14585] by brmorris
  • 1 edit in S60/trunk/runATF.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by Franklin.

runATF.bat sets compile environment
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9106)

1:08 AM Changeset in webkit [14584] by hyatt
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

12:35 AM Changeset in webkit [14583] by hyatt
  • 2 edits in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree

Fix DumpRenderTree so that it works again.

May 24, 2006:

10:52 PM Changeset in webkit [14582] by hyatt
  • 4 edits in trunk/WebCore

Implement font aliasing of family names for Courier/Courier New,
Arial/Helvetica, and Times/Times New Roman. This behavior matches
WinIE and Firefox.

Reviewed by maciej

Test cases not really possible, since they would have to rely on people
not having the fonts installed (so not having installed Office).

  • platform/FontCache.cpp: (WebCore::alternateFamilyName): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontCache.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeLeftoverAnonymousBoxes):
5:43 PM Changeset in webkit [14581] by bdakin
  • 1 edit
    1 move
    3 adds
    3 deletes in trunk/LayoutTests

Reviewed by Geoff.

This layout test is now correct, so I moved it into the expected
successes directory and generated new results.

  • tables/mozilla/bugs/bug222846-expected.checksum: Added.
  • tables/mozilla/bugs/bug222846-expected.png: Added.
  • tables/mozilla/bugs/bug222846-expected.txt: Added.
  • tables/mozilla/bugs/bug222846.html: Added.
  • tables/mozilla_expected_failures/bugs/bug222846- expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846.html: Removed.
5:40 PM Changeset in webkit [14580] by thatcher
  • 8 copies in tags/Safari-521.11

Tag

5:34 PM Changeset in webkit [14579] by thatcher
  • 6 edits in /

Versioning

4:49 PM Changeset in webkit [14578] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/selection/designmode-no-caret-expected.checksum: Added.
  • editing/selection/designmode-no-caret-expected.png: Added.
  • editing/selection/designmode-no-caret-expected.txt: Added.
  • editing/selection/designmode-no-caret.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4549610> REGRESSION: No initial cursor in Mail reply or Blot document
<rdar://problem/4560698> Mail is very crashy in Leopard9A182, WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)

  • page/Frame.cpp: (WebCore::Frame::setSelectionFromNone): Find the body and stick a caret in it.
4:41 PM Changeset in webkit [14577] by sullivan
  • 2 edits in trunk/WebKitSite

Reviewed by John Sullivan.

  • quality/lifecycle.html: mentions case of PlatformOnly bugs

and 'other' bug databases.

4:33 PM Changeset in webkit [14576] by hyatt
  • 4 edits in trunk/WebCore/platform

Add support for IMLangFontLink2 to map to a similar font that has missing characters on Win32.

4:18 PM Changeset in webkit [14575] by ggaren
  • 4 edits in trunk/WebCore

Rubber stamped by Anders.


Removed meaningless 'dom::' prefix in IDL files.

  • dom/Range.idl:
  • html/CanvasRenderingContext2D.idl:
  • html/HTMLOptionElement.idl:
4:13 PM Changeset in webkit [14574] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/dom/option-properties-expected.txt: Added.
  • fast/dom/option-properties.html: Added.

WebCore:

Reviewed by andersca.



'text' and 'selected' were erroneously marked read-only for option elements.


  • html/HTMLOptionElement.idl:
4:02 PM Changeset in webkit [14573] by brmorris
  • 7 edits in S60/trunk

S60Webkit:

2006-05-25 Mario Borges

Reviewed by bradleym.

  • better support for SISX using ARMV5
  • updated def files
3:57 PM Changeset in webkit [14572] by thatcher
  • 1 copy in tags/WebCore-418.9/WebCore

Tag for WebCore 418.9 (part 2 of 2.)

3:56 PM Changeset in webkit [14571] by thatcher
  • 1 add in tags/WebCore-418.9

Tag for WebCore 418.9 (part 1 of 2.)

3:56 PM Changeset in webkit [14570] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:42 PM Changeset in webkit [14569] by ggaren
  • 19 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by mjs.


  • JSC half of fix for <rdar://problem/4557926> TOT REGRESSSION: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving on
with my life.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::mark):
  • kjs/interpreter.h:

LayoutTests:

Layout tests for DOM object cache and garbage collection,
<rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting
to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716
( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file

  • fast/dom/gc-8-expected.txt: Added.
  • fast/dom/gc-8.html: Added.
  • fast/dom/gc-9-expected.txt: Added.
  • fast/dom/gc-9.html: Added.

WebCore:

Reviewed by mjs.

  • WebCore half of fix for <rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving
on with my life.

Also added functionality for testing garbage collection from inside
DumpRenderTree.


Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
objects aren't accessed through the DOM.


Also added JS locking around access to some shared data structures in
WebCoreJavaScript, even though it probably doesn't matter in practice.

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCoreJavaScript.mm: (collect): (+[WebCoreJavaScript objectCount]): (+[WebCoreJavaScript interpreterCount]): (+[WebCoreJavaScript protectedObjectCount]): (+[WebCoreJavaScript garbageCollect]): (+[WebCoreJavaScript garbageCollectOnAlternateThread:]): (+[WebCoreJavaScript shouldPrintExceptions]): (+[WebCoreJavaScript setShouldPrintExceptions:]):

WebKitTools:

Reviewed by mjs.


Added 'GCController' to DRT to support garbage collection layout tests.


GCController.collect() and GCController.collectOnAlternateThread() do
what you would expect. The latter takes a boolean argument sepcifying
whether to wait for garbage collection to finish before continuing to
execute script.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/GCController.mm: Added. (+[GCController isSelectorExcludedFromWebScript:]): (+[GCController webScriptNameForSelector:]): (-[GCController collect]): (-[GCController collectOnAlternateThread:]):
3:39 PM Changeset in webkit [14568] by kdecker
  • 2 edits in branches/Safari-2-0-branch/WebCore
3:32 PM Changeset in webkit [14567] by jdevalk
  • 3 edits in trunk/WebKitSite

Adding Google Analytics code, to create visitor stats of our site.

2:54 PM Changeset in webkit [14566] by hyatt
  • 3 edits in trunk/WebCore

Move font destruction for HFONTs and cairo objects into FontData.

1:48 PM Changeset in webkit [14565] by brmorris
  • 1 edit in S60/trunk/WebKit/Plugin/inc/jri.h

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • Removing JRE dependency in Plugin/inc/jri.h
12:26 PM Changeset in webkit [14564] by andersca
  • 7 edits
    2 adds in trunk

WebCore:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return document.scripts() instead of a placeholder object.


  • dom/Document.cpp: (WebCore::Document::scripts):
  • dom/Document.h: Add Document::scripts.


  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::): Add scripts collection type which traverses all script elements.


LayoutTests:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Add tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • fast/dom/document-scripts-expected.txt: Added.
  • fast/dom/document-scripts.html: Added.
12:02 PM Changeset in webkit [14563] by brmorris
  • 1 edit
    8 deletes in S60/trunk

S60WebKit:

Reviewed by mario

2006-05-24 brmorris <​bradley.morrison@nokia.com>

  • Purged unneeded source
  • Updated README.txt
11:57 AM Changeset in webkit [14562] by brmorris
  • 5 edits
    1 delete in S60/trunk/WebKit/Plugin/inc

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • More lawyer-speak:

MPL 1.1 license on the Netscape Plugins.

11:51 AM Changeset in webkit [14561] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers

  • dom/Node.cpp: (WebCore::Node::textContent):
  • dom/Node.h: Add optional convertBRsToNewlines argument for textContent.


  • html/HTMLElement.cpp: (WebCore::HTMLElement::innerText): If the element doesn't have a renderer, return textContent.

LayoutTests:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

Add test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers.


  • fast/dom/inner-text-with-no-renderer-expected.txt: Added.
  • fast/dom/inner-text-with-no-renderer.html: Added.
2:25 AM Changeset in webkit [14560] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderThemeWin.cpp

Fix the Win32 themed controls so that they honor Cairo transforms.

1:33 AM Changeset in webkit [14559] by hyatt
  • 3 edits in trunk/WebCore

Fix a minor bug with the computation of glyph offsets in Cairo/Win32.

1:28 AM Changeset in webkit [14558] by hyatt
  • 2 edits in trunk/WebKitWin

Switch the cairo win32 create similar call over to createdib instead. Avoids wasted fills.

1:23 AM Changeset in webkit [14557] by hyatt
  • 1 edit
    1 add in trunk/WebCore/platform/cairo

Check in some temporary hacks to Cairo for speed.

12:15 AM Changeset in webkit [14556] by hyatt
  • 1 edit in trunk/WebKitWin/WebFramePrivate.cpp

Make sure the font options set on the context match what we draw.

May 23, 2006:

6:21 PM Changeset in webkit [14555] by brmorris
  • 1 edit
    2 deletes in S60/trunk

S60WebKit:

  • Corrected build.bat usage statement
  • Removed some irrelevant config files
6:08 PM Changeset in webkit [14554] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Correct reviewer from me to Tim.

5:59 PM Changeset in webkit [14553] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Maciej.


  • more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _startLoading]):
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithDataSource:]): (-[WebMainResourceLoader didReceiveResponse:]):
5:24 PM Changeset in webkit [14552] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Timothy.

  • index.html: Link to Nokia's S60 WebKit.
4:32 PM Changeset in webkit [14551] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove the recent idl files from the WebCore target to prevent them
from being copied into the framework resources.

  • WebCore.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [14550] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Justin Garcia and Levi Weintraub.


  • fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html
  • dom/Document.cpp: (WebCore::Document::removeMarkers): One more time to get this right, ugh. There is still one case where we don't want to advance the iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now the layout tests pass even with the pixel tests enabled.
3:48 PM Changeset in webkit [14549] by brmorris
  • 372 edits
    2668 adds in S60/trunk

S60WebKit ... migrated!

3:11 PM Changeset in webkit [14548] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Implement CookieJar on Win32.

2:37 PM Changeset in webkit [14547] by thatcher
  • 1 copy in tags/WebKit-418.8/WebKit

Tag for WebKit 418.8 (part 2 of 2.)

2:37 PM Changeset in webkit [14546] by thatcher
  • 1 add in tags/WebKit-418.8

Tag for WebKit 418.8 (part 1 of 2.)

2:36 PM Changeset in webkit [14545] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:36 PM Changeset in webkit [14544] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-23 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
2:21 PM Changeset in webkit [14543] by hyatt
  • 1 edit in trunk/WebCore/bridge/win/FrameWin.cpp

Fix post form submission on Win32.

1:45 PM Changeset in webkit [14542] by sullivan
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Newer Xcode removed some obsolete cruft


  • DumpRenderTree/TextInputController.m: (-[TextInputController textInput]): added (id) cast to make newer compiler happy
1:31 PM Changeset in webkit [14541] by hyatt
  • 7 edits in trunk/WebCore

Fix glyph width access on win32 to not depend on the UChar.

12:27 PM Changeset in webkit [14540] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
12:18 PM Changeset in webkit [14539] by brmorris
  • 1 add in S60/trunk/patentlicense.txt

S60WebKit: adding patentlicense.txt

12:15 PM Changeset in webkit [14538] by thatcher
  • 4 edits in tags/Safari-521.10.1

Versioning

10:51 AM Changeset in webkit [14537] by lweintraub
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Cleaned up changes to markup by adding the non-virtual
nodeNamePreservingCase accessor function.

  • dom/Element.cpp: (WebCore::Element::nodeNamePreservingCase):
  • dom/Element.h:
  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
10:47 AM Changeset in webkit [14536] by thatcher
  • 1 copy in tags/Safari-521.10.1

New tag.

10:35 AM Changeset in webkit [14535] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • dom/Document.cpp: (WebCore::Document::removeMarkers): Fix to my previous checkin (which broke a layout test). Advance the iterator position every time through the loop; formerly it was not advanced in the case where a marker was actually removed, causing an infinite loop in certain cases. Also modified a comment that was confusing the situation by falsely claiming that iterating over a just-inserted node would always be OK.
9:27 AM Changeset in webkit [14534] by andersca
  • 12 edits
    2 adds in trunk

WebCore:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/Element.cpp: (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute): Use new getAttributeItem method.


  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem): Use new getAttributeItem method.


(WebCore::NamedAttrMap::getAttributeItem):

  • dom/NamedAttrMap.h: New method which returns the attribute based on the nodeName.

LayoutTests:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Update tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: This fails in a different way now.


  • dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
  • dom/xhtml/level3/core/noderemovechild28-expected.txt:
  • dom/xhtml/level3/core/noderemovechild29-expected.txt: These now pass.


  • fast/dom/attribute-namespaces-get-set-expected.txt: Added.
  • fast/dom/attribute-namespaces-get-set.html: Added. Add new tests.
8:40 AM Changeset in webkit [14533] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.


  • remove knowledge of WebView from WebLoader in preparation for moving the code down
  • WebView/WebDataSource.m: (-[WebDataSource _defersCallbacks]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _privateBrowsingEnabled]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[WebLoader releaseResources]): (-[WebLoader setDataSource:]): (-[WebLoader willSendRequest:redirectResponse:]): (-[WebLoader didReceiveAuthenticationChallenge:]): (-[WebLoader didCancelAuthenticationChallenge:]): (-[WebLoader didReceiveResponse:]): (-[WebLoader didReceiveData:lengthReceived:]): (-[WebLoader signalFinish]): (-[WebLoader didFinishLoading]): (-[WebLoader didFailWithError:]): (-[WebLoader willCacheResponse:]): (-[WebLoader cancelWithError:]):
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
  • WebView/WebView.m: (-[WebView _incrementProgressForIdentifier:response:]): (-[WebView _incrementProgressForIdentifier:data:]): (-[WebView _completeProgressForIdentifier:]):
  • WebView/WebViewInternal.h:

May 22, 2006:

6:36 PM Changeset in webkit [14532] by eseidel
  • 2 edits in trunk/WebCore

2006-05-22 Eric Seidel <​eric@eseidel.com>

Rubber-stamped by adele.

  • bindings/js/kjs_html.h: simple style cleanup.
4:55 PM Changeset in webkit [14531] by thatcher
  • 1 copy in tags/Safari-521.10

Tag for 521.10

4:46 PM Changeset in webkit [14530] by thatcher
  • 8 edits in /

Versioning.

4:30 PM Changeset in webkit [14529] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix when doing 'xcodebuild install'.

3:18 PM Changeset in webkit [14528] by thatcher
  • 1 edit in trunk/WebCore/platform/mac/WebCoreSystemInterface.h

Build fix.

3:10 PM Changeset in webkit [14527] by justing
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by levi


Fixed and reenabled this test.

  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe.html: Added.
  • editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.
2:51 PM Changeset in webkit [14526] by thatcher
  • 1 copy in tags/WebKit-418.7/WebKit

Tag for WebKit 418.7 (part 2 of 2.)

2:51 PM Changeset in webkit [14525] by thatcher
  • 1 add in tags/WebKit-418.7

Tag for WebKit 418.7 (part 1 of 2.)

2:51 PM Changeset in webkit [14524] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:41 PM Changeset in webkit [14523] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-22 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
2:39 PM Changeset in webkit [14522] by thatcher
  • 1 edit in trunk/JavaScriptCore/wtf/MathExtras.h

Removes svn:executable from MathExtras.h. Caused a build verification failure.

2:20 PM Changeset in webkit [14521] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.


  • fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
DeprecatedValueList and DeprecatedValueListIterator.


  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::markersForNode): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintAllMarkersOfType):
2:00 PM Changeset in webkit [14520] by thatcher
  • 5 edits in trunk/WebCore/platform

64-bit build fix, and removes the workaround for <rdar://problem/4294625>.

1:55 PM Changeset in webkit [14519] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
1:21 PM Changeset in webkit [14518] by sfalken
  • 2 edits in trunk/WebKitTools

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.


Fix build.

  • Spinneret/Spinneret.sln:
1:16 PM Changeset in webkit [14517] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.


Fix build.

  • WebKitWin.vcproj/WebKitWin.sln:
11:34 AM Changeset in webkit [14516] by lweintraub
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by eric.


  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • fast/dom/Range/range-exceptions-expected.txt:
  • fast/dom/Range/resources/range-exceptions.js:
  • fast/innerHTML/005-expected.txt:
  • fast/innerHTML/innerHTML-custom-tag-expected.txt:
  • fast/innerHTML/innerHTML-cast.html: Added.
  • fast/innerHTML/innerHTML-cast-expected.txt: Added.
  • fast/xsl/xslt-processer-expected.txt:

WebCore:

Reviewed by Eric.


  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
11:20 AM Changeset in webkit [14515] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Eric, Kevin and Geoff.

Merge open source build fixes. <rdar://problem/4555500>

  • kjs/collector.cpp: look at the rsp register in x86_64 (KJS::Collector::markOtherThreadConservatively):
  • wtf/Platform.h: add x86_64 to the platform list
1:04 AM Changeset in webkit [14514] by hyatt
  • 1 edit in trunk/WebCore/platform/mac/FontCacheMac.mm

Fix Mac bustage.

May 21, 2006:

11:19 PM Changeset in webkit [14513] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontDataWin.cpp

Fix win32 bustage.

11:18 PM Changeset in webkit [14512] by hyatt
  • 5 edits
    3 adds in trunk/WebCore

Fix win32 bustage.

4:42 PM Changeset in webkit [14511] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::text): Reverting recent change to user innerText instead of textContent. For textareas, we need a better solution than textContent that also takes newlines into account, but this should fix this crasher.
12:51 AM Changeset in webkit [14510] by andersca
  • 1 edit
    1 add in trunk/WebCore

2006-05-21 Anders Carlsson <​acarlsson@apple.com>

Fix build.


  • ForwardingHeaders/wtf/MathExtras.h: Added.
12:18 AM Changeset in webkit [14509] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Add mathextras to javascrtipcore project.

12:05 AM Changeset in webkit [14508] by hyatt
  • 1 edit in trunk/WebCore/platform/mac/FontPlatformData.h

Fix mac bustage. Minor snafu in constructor.

May 20, 2006:

11:58 PM Changeset in webkit [14507] by hyatt
  • 14 edits
    1 move
    2 adds in trunk/WebCore

Switch on Cairo-based text rendering on win32.

11:55 PM Changeset in webkit [14506] by hyatt
  • 1 add in trunk/JavaScriptCore/wtf/MathExtras.h

Add mathextras.h to wtf to give win32 roundf/lroundf support.

7:09 PM Changeset in webkit [14505] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Beth.


  • fix assertion failure on layout tests
  • WebView/WebDataSource.m: (-[WebDataSource _mainReceivedError:complete:]): Don't do anything if this data source is no longer connected to a frame. Used to be this couldn't happen because the WebView would have been nil, but we no longer go through the WebView.
3:42 PM Changeset in webkit [14504] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9018


Use clientHeight now that offsetHeight includes the border and padding.
clientHeight should have been used initially.

2:22 PM Changeset in webkit [14503] by hyatt
  • 2 edits in trunk/WebKitWin

Fix Cairo double buffering.

1:19 PM Changeset in webkit [14502] by andersca
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8993
Support function declaration in case statements


  • kjs/grammar.y: Get rid of StatementList and use SourceElements instead.


  • kjs/nodes.cpp: (CaseClauseNode::evalStatements): (CaseClauseNode::processVarDecls): (CaseClauseNode::processFuncDecl): (ClauseListNode::processFuncDecl): (CaseBlockNode::processFuncDecl): (SwitchNode::processFuncDecl):
  • kjs/nodes.h: (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ClauseListNode::getClause): (KJS::ClauseListNode::getNext): (KJS::ClauseListNode::releaseNext): (KJS::SwitchNode::SwitchNode): Add processFuncDecl for the relevant nodes.
  • kjs/nodes2string.cpp: (CaseClauseNode::streamTo): next got renamed to source.

LayoutTests:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • fast/js/function-declarations-in-switch-statement-expected.txt: Added.
  • fast/js/function-declarations-in-switch-statement.html: Added.
  • fast/js/resources/function-declarations-in-switch-statement.js: Added.
1:57 AM Changeset in webkit [14501] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
  • manual-tests/custom-cursors.html: Added.
1:47 AM Changeset in webkit [14500] by ap
  • 3 edits
    4 adds in trunk

2006-05-20 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

Test: fast/table/empty-section-crash.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): Return immediately if the section has 0 rows or 0 columns.

May 19, 2006:

10:52 PM Changeset in webkit [14499] by hyatt
  • 1 edit in trunk/WebCore/platform/cairo/ImageCairo.cpp

Fix Win32 bustage caused by image document. supportsType is not implemented yet for ImageCairo, so we'll return false rather than true to keep every document from being an image document.

5:21 PM Changeset in webkit [14498] by lweintraub
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by justin.


Tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
Drag caret not painted for editable sub-frames

  • editing/resources/select-and-drag-iframe.html: Added.
  • editing/selection/drag-in-iframe-expected.checksum: Added.
  • editing/selection/drag-in-iframe-expected.png: Added.
  • editing/selection/drag-in-iframe-expected.txt: Added.
  • editing/selection/drag-in-iframe.html: Added.

WebCore:

Reviewed by justin.


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
Drag caret not painted for editable sub-frames


Moved the drag caret out of Frame and into Page.
Only the Frame that contains the drag caret will paint it.

  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::dragCaret): (WebCore::Frame::setDragCaret): (WebCore::Frame::paintDragCaret):
  • page/FramePrivate.h:
  • page/Page.cpp: (WebCore::Page::dragCaret): (WebCore::Page::setDragCaret):
  • page/Page.h:
4:16 PM Changeset in webkit [14497] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • html/HTMLButtonElement.idl: added support for HTMLButtonElement.click()
2:18 PM Changeset in webkit [14496] by aliceli1
  • 2 adds in trunk/LayoutTests/fast/forms
12:35 PM Changeset in webkit [14495] by ggaren
  • 9 edits
    2 adds in trunk

LayoutTests:

  • Test for overriding non-autogenerated global constructors.
  • fast/dom/constructors-overriding-expected.txt: Added.
  • fast/dom/constructors-overriding.html: Added.

WebCore:

Reviewed by Eric.

  • Fixed non-autogenerated global constructors to match autogenerated ones and FF. (Found this bug while @ the GOOG.)

(1) They're no longer read-only, so they can be overridden.
(2) They now have the default object prototype, so they can do things
like 'toString' and 'valueOf', necessary for general functionality,
including my layout test.
(3) Their prototype properties are now enumerable and not read-only.


  • bindings/js/JSDOMParser.cpp: (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXMLSerializer.cpp: (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • bindings/js/kjs_html.cpp: (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::ImageConstructorImp::ImageConstructorImp):
  • bindings/js/kjs_window.cpp:
12:07 PM Changeset in webkit [14494] by thatcher
  • 1 copy in tags/JavaScriptCore-418.2/JavaScriptCore

Tag for JavaScriptCore 418.2 (part 2 of 2.)

12:07 PM Changeset in webkit [14493] by thatcher
  • 1 add in tags/JavaScriptCore-418.2

Tag for JavaScriptCore 418.2 (part 1 of 2.)

12:06 PM Changeset in webkit [14492] by thatcher
  • 1 copy in tags/WebCore-418.8/WebCore

Tag for WebCore 418.8 (part 2 of 2.)

12:06 PM Changeset in webkit [14491] by thatcher
  • 1 add in tags/WebCore-418.8

Tag for WebCore 418.8 (part 1 of 2.)

12:05 PM Changeset in webkit [14490] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

12:01 PM Changeset in webkit [14489] by thatcher
  • 9 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4543569> 10.4.7 regression: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)
  • Major fix: On alternate threads, DOMObjects remain in the ScriptInterpreter's cache because they're not collected. So, they need an opportunity to mark their children.
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.h: (KJS::Interpreter::mark):

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4543569> 10.4.7 regression: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)
  • Minor fix: DOMParserConstructor needed to inherit from DOMObject to prevent collection on alternate threads.
  • Major fix: On alternate threads, DOMObjects remain in the ScriptInterpreter's cache because they're not collected. So, they need an opportunity to mark their children.
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
  • khtml/ecma/kjs_binding.h:
11:42 AM Changeset in webkit [14488] by lweintraub
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by justin.

When the paste performance fix was merged over, uses of isCandidate
were changed to isRenderedContent. isRenderedContent on the branch
is incorrect in a few ways.

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init):
11:17 AM Changeset in webkit [14487] by thatcher
  • 1 copy in tags/WebKit-418.6/WebKit

Tag for WebKit 418.6 (part 2 of 2.)

11:17 AM Changeset in webkit [14486] by thatcher
  • 1 add in tags/WebKit-418.6

Tag for WebKit 418.6 (part 1 of 2.)

11:16 AM Changeset in webkit [14485] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

10:55 AM Changeset in webkit [14484] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-18 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4551938> More options needed for window display throttle

We decided to play it safe and leave our window flushing behavior unchanged from the previous
public release. By default, CoreGraphics deferred updates are once again OFF, and the window
display throttle is OFF.

Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and
WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs.

Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey (or unset).

Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey=1. While this configuration fixes the tearing issues
caused by over-flushing, some applications will experience performance problems as over-flushing
with CG deferred updates enabled will cause the app to block.

Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1,
WebKitEnableDeferredUpdatesPreferenceKey=1. This is the riskiest configuration in that it
enables the window display throttle "feature", potentially breaking applications' assumptions
about when displays occur. However, it provides the "best of both worlds", in that updates
are tear-free, and performance impact should me minimal.

  • WebView/WebPreferenceKeysPrivate.h: Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value. Added some comments.
3:53 AM Changeset in webkit [14483] by andersca
  • 11 edits
    22 adds in trunk/WebCore

2006-05-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8983
Autogenerate another 22 HTML classes


Already covered by existing DOM tests.

  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add new IDL files and generated sources.


  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::createPattern): Use JSHTMLImageElement::info in inherits.


  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Add macros for the functions and the code to populate the hash set.


  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Delete old cruft.


  • bindings/scripts/CodeGeneratorJS.pm: Add support for creating a JS object from a HTMLCollection.


  • html/HTMLAreaElement.idl: Added.
  • html/HTMLBRElement.idl: Added.
  • html/HTMLBaseFontElement.idl: Added.
  • html/HTMLBlockquoteElement.idl: Added.


  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
  • html/HTMLBodyElement.h: Add new functions that used to be implemented in kjs_html.cpp


  • html/HTMLBodyElement.idl: Added.
  • html/HTMLFieldSetElement.idl: Added.
  • html/HTMLFontElement.idl: Added.
  • html/HTMLHRElement.idl: Added.
  • html/HTMLHeadingElement.idl: Added.
  • html/HTMLImageElement.idl: Added.
  • html/HTMLIsIndexElement.idl: Added.
  • html/HTMLLIElement.idl: Added.
  • html/HTMLLabelElement.idl: Added.
  • html/HTMLLegendElement.idl: Added.
  • html/HTMLMapElement.idl: Added.
  • html/HTMLMenuElement.idl: Added.
  • html/HTMLModElement.idl: Added.
  • html/HTMLParagraphElement.idl: Added.
  • html/HTMLParamElement.idl: Added.
  • html/HTMLPreElement.idl: Added.
  • html/HTMLQuoteElement.idl: Added.
  • html/HTMLScriptElement.idl: Added.

May 18, 2006:

6:25 PM Changeset in webkit [14482] by hyatt
  • 54 edits in trunk/WebCore/platform/cairo

Update to the latest and greatest Cairo.

3:00 PM Changeset in webkit [14481] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Eric.


  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]):
  • WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader receivedError:]): (-[WebSubresourceLoader signalFinish]):
  • WebView/WebDataSource.m: (-[WebDataSource _stopLoading]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _finishedLoadingResource]): (-[WebDataSource _mainReceivedBytesSoFar:complete:]): (-[WebDataSource _receivedError:]): (-[WebDataSource _mainReceivedError:complete:]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveData:lengthReceived:]): (-[WebMainResourceLoader didFinishLoading]):
  • WebView/WebView.m:
  • WebView/WebViewInternal.h:
2:28 PM Changeset in webkit [14480] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4551938> More options needed for window display throttle

We decided to play it safe and leave our window flushing behavior unchanged from the previous
public release. By default, CoreGraphics deferred updates are once again OFF, and the window
display throttle is OFF.

Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and
WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs.

Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey (or unset).

Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
WebKitEnableDeferredUpdatesPreferenceKey=1. While this configuration fixes the tearing issues
caused by over-flushing, some applications will experience performance problems as over-flushing
with CG deferred updates enabled will cause the app to block.

Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1,
WebKitEnableDeferredUpdatesPreferenceKey=1. This is the riskiest configuration in that it
enables the window display throttle "feature", potentially breaking applications' assumptions
about when displays occur. However, it provides the "best of both worlds", in that updates
are tear-free, and performance impact should me minimal.

  • WebView/WebPreferenceKeysPrivate.h: Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value. Added some comments.
1:56 PM Changeset in webkit [14479] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-18 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4553450> Make disabling window throttle safer

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't assume that +_webkit_disableWindowDisplayThrottle restored the NSWindow method implementations; now we'll only swizzle them once, and our replacement IMPs will call the old IMPs when the window throttle is disabled. This is a safer approach when other components/"haxies" override the same methods that we are overriding, as it allows the overrides to "chain" properly. Moved the dictionary initialization code down a bit. The order doesn't matter here. (disableWindowDisplayThrottleApplierFunction): Noticed that this could have been written safer with respect to the timer having the last reference to the window. I never experienced a crash here, but this code is definitely safer. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Don't restore NSWindow method implementations; just clear the flag, flush pending displays, and destroy the dictionary. (replacementPostWindowNeedsDisplay): If throttling is disabled, just call the original IMP. (clearWindowDisplayInfo): Added an assert. (replacementDealloc): Don't call clearWindowDisplayInfo() when throttling is disabled. (replacementFinalize): ditto (cancelPendingWindowDisplay): Removed an unnecessary assertion.
1:49 PM Changeset in webkit [14478] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Make Win32 compile (finally). Add missing files to bindings/js directory in the vcproj.

1:40 PM Changeset in webkit [14477] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Reduce link errors from 21 to 7 by adding more auto-generated JS bindings files to the vcproj. (Win32 bustage still.)

1:36 PM Changeset in webkit [14476] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Keep working on win32 bustage. Add KWQFileButton::setDisabled to TemporaryLinkStubs.

1:31 PM Changeset in webkit [14475] by hyatt
  • 1 edit in trunk/WebCore/loader/ImageDocument.cpp

Keep going trying to fix win32 bustage. Make ImageDocument compile.

1:31 PM Changeset in webkit [14474] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.


  • fixed <rdar://problem/4552713> REGRESSION: WebFrameView no longer responds to responder methods sent by Safari code
  • WebView/WebView.m: (-[WebView _responderForResponderOperations]): Treat sibling views of the main frameView the same as views outside of the webview for the purposes of this mechanism.
1:29 PM Changeset in webkit [14473] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4553450> Make disabling window throttle safer

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't assume that +_webkit_disableWindowDisplayThrottle restored the NSWindow method implementations; now we'll only swizzle them once, and our replacement IMPs will call the old IMPs when the window throttle is disabled. This is a safer approach when other components/"haxies" override the same methods that we are overriding, as it allows the overrides to "chain" properly. Moved the dictionary initialization code down a bit. The order doesn't matter here. (disableWindowDisplayThrottleApplierFunction): Noticed that this could have been written safer with respect to the timer having the last reference to the window. I never experienced a crash here, but this code is definitely safer. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Don't restore NSWindow method implementations; just clear the flag, flush pending displays, and destroy the dictionary. (replacementPostWindowNeedsDisplay): If throttling is disabled, just call the original IMP. (clearWindowDisplayInfo): Added an assert. (replacementDealloc): Don't call clearWindowDisplayInfo() when throttling is disabled. (replacementFinalize): ditto (cancelPendingWindowDisplay): Removed an unnecessary assertion.
1:18 PM Changeset in webkit [14472] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Fix build bustage caused by broken XPath feature support checking on win32.

10:57 AM Changeset in webkit [14471] by darin
  • 2 edits in trunk/WebKitTools
  • try to fix no-SVG, no-XPATH build, again
  • Scripts/build-webkit: Use FEATURE_DEFINES= instead of FEATURE_DEFINES=.
10:52 AM Changeset in webkit [14470] by hyatt
  • 6 edits in trunk/WebCore

Turn off responding to font changes while running. It doesn't work
right anyway.

Reviewed by darin

  • platform/FontCache.cpp: (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontCache.h:
  • platform/GlyphMap.h: (WebCore::GlyphMap::~GlyphMap):
  • platform/GlyphWidthMap.h: (WebCore::GlyphWidthMap::~GlyphWidthMap):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::platformInit):
10:28 AM Changeset in webkit [14469] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-17 Tim Omernick <​timo@apple.com>

Reviewed by Kevin Decker and John Sullivan.

<rdar://problem/4550801> REGRESSION: Window throttle code can sometimes leak NSWindows

The window display throttle depended on windows being closed before they were deallocated; this is
not guaranteed by AppKit. Windows that were being released without being closed were getting stuck
in our NSWindow -> WindowDisplayInfo dictionary.


  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't retain the NSWindow keys in the window display info dictionary. Instead of overriding -close, override -dealloc and -finalize so that we can remove the NSWindow -> WindowDisplayInfo mapping when a window deallocates. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -dealloc and -finalize. (clearWindowDisplayInfo): Factored the WindowDisplayInfo cleanup code out of the now-defunct replacementClose(). (replacementClose): Removed; no longer needed. (replacementDealloc): Clear the WindowDisplayInfo for the window after deallocation. (replacementFinalize): ditto (-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]): Rewrote this method to be safe in the case where the firing display timer has the last reference to the window. Added comments.
10:04 AM Changeset in webkit [14468] by darin
  • 2 edits in trunk/WebKitTools
  • try to fix no-SVG, no-XPATH build
  • Scripts/build-webkit: Pass FEATURE_DEFINES rather than GCC_PREPROCESSOR_DEFINITIONS, since the former is what's used in the WebCore project now.
9:56 AM Changeset in webkit [14467] by darin
  • 3 edits in trunk/WebCore
  • try to fix the Windows build
  • platform/TextEncoding.h: Changed a ";" to a ",".
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed JSCanvasRenderingContext2DBase.cpp and JSCanvasRenderingContext2DBase.h. Added JSCanvasRenderingContext2DCustom.cpp.
9:53 AM Changeset in webkit [14466] by darin
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
Bug 8896: Absolutely positioned elements should use their parent's
direction when left, right and width are auto in quirks mode.

  • fast/block/positioning/absolute-position-direction-quirk.html: Added.
  • fast/block/positioning/absolute-position-direction-quirk-expected.txt: Added.
  • fast/block/positioning/absolute-position-direction-quirk-expected.png: Added.
  • fast/block/positioning/absolute-position-direction-quirk-expected.checksum: Added.
  • fast/block/positioning/absolute-position-direction-strict.html: Added.
  • fast/block/positioning/absolute-position-direction-strict-expected.txt: Added.
  • fast/block/positioning/absolute-position-direction-strict-expected.png: Added.
  • fast/block/positioning/absolute-position-direction-strict-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
Bug 8896: Absolutely positioned elements should use their parent's
direction when left, right and width are auto in quirks mode.

Use the parent's direction instead of the containing
block's in quirks mode for absolute positioning to match
WinIE.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  • rendering/RenderBox.h:
9:13 AM Changeset in webkit [14465] by darin
  • 3 edits in trunk/WebCore

Reviewed and tweaked (way too much) by Darin.

  • platform/CharsetNames.cpp: (WebCore::TextEncodingIDHashTraits::emptyValue): Added a non-zero empty value, InvalidEncoding, and used InvalidEncoding2 for the deleted value. (WebCore::buildCharsetMaps): Added an assertion that the deleted and empty values are not valid encodings.
  • platform/TextEncoding.h: Defined InvalidEncoding2.
2:13 AM Changeset in webkit [14464] by hyatt
  • 3 edits in trunk/WebCore

Horrible glyph map regression fix. The initial page of the map was
being rebuilt over and over again.

Reviewed by andersca

  • platform/GlyphMap.cpp: (WebCore::GlyphMap::locatePage):
  • platform/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePage):
1:20 AM Changeset in webkit [14463] by andersca
  • 10 edits
    8 adds in trunk

WebCore:

2006-05-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8964
Autogenerate more HTML classes


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new files.


  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createAnchorWrapper): (WebCore::createAppletWrapper): (WebCore::createDivWrapper): (WebCore::createDirectoryWrapper): (WebCore::createDListWrapper): (WebCore::createHtmlWrapper): (WebCore::createOListWrapper): (WebCore::createUListWrapper): (WebCore::createJSWrapper): Add wrappers.


  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Delete the old implementations.


  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::host): (WebCore::HTMLAnchorElement::hostname): (WebCore::HTMLAnchorElement::pathname): (WebCore::HTMLAnchorElement::port): (WebCore::HTMLAnchorElement::protocol): (WebCore::HTMLAnchorElement::search): (WebCore::HTMLAnchorElement::text):
  • html/HTMLAnchorElement.h: Add some new accessor methods which used to be in kjs_html.cpp.


  • html/HTMLAnchorElement.idl: Added.
  • html/HTMLAppletElement.idl: Added.
  • html/HTMLDListElement.idl: Added.
  • html/HTMLDirectoryElement.idl: Added.
  • html/HTMLDivElement.idl: Added.
  • html/HTMLHtmlElement.idl: Added.
  • html/HTMLOListElement.idl: Added.
  • html/HTMLUListElement.idl: Added.

LayoutTests:

2006-05-18 Anders Carlsson <​acarlsson@apple.com>

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8964
Autogenerate more HTML classes

  • fast/dom/prototype-chain-expected.txt: Update test result.
12:36 AM Changeset in webkit [14462] by hyatt
  • 4 edits
    2 adds in trunk/WebCore

Convert the width map for glyphs into the same new HashMap-style as the
glyph map for characters.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontData.cpp: (WebCore::FontData::~FontData): (WebCore::FontData::widthForGlyph):
  • platform/FontData.h:
  • platform/GlyphWidthMap.cpp: Added. (WebCore::GlyphWidthMap::widthForGlyph): (WebCore::GlyphWidthMap::setWidthForGlyph): (WebCore::GlyphWidthMap::locatePage):
  • platform/GlyphWidthMap.h: Added. (WebCore::GlyphWidthMap::GlyphWidthMap): (WebCore::GlyphWidthMap::~GlyphWidthMap): (WebCore::GlyphWidthMap::GlyphWidthPage::widthForGlyph): (WebCore::GlyphWidthMap::GlyphWidthPage::setWidthForGlyph): (WebCore::GlyphWidthMap::GlyphWidthPage::setWidthForIndex):

May 17, 2006:

11:21 PM Changeset in webkit [14461] by hyatt
  • 2 edits
    1 move in trunk/WebCore

Rename FontData.mm to FontData.cpp, since it has no obj-c in it.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontData.cpp: Added.
11:09 PM Changeset in webkit [14460] by hyatt
  • 4 edits
    1 add in trunk/WebCore

Split FontData.mm into platform-specific and cross-platform pieces.

Reviewed by andersca

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontData.h: (WebCore::FontData::xHeight):
  • platform/mac/FontData.mm: (WebCore::FontData::widthForGlyph): (WebCore::m_smallCapsFontData): (WebCore::FontData::~FontData): (WebCore::extendWidthMap):
10:02 PM Changeset in webkit [14459] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Some more future renames.
9:35 PM Changeset in webkit [14458] by ap
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/js/date-constructor-expected.txt:
  • fast/js/resources/date-constructor.js: Disable the offending tests.
9:15 PM Changeset in webkit [14457] by staikos
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej, Alexey, and Eric.

  • Use // in .c files to compile with non-C99 and non-GCC compilers.
  • Change include to <wtf/HashTraits.h> from "HashTraits.h" to avoid -I
  • Use correct parentheses and correct mask for utf-32 support.
8:36 PM Changeset in webkit [14456] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker and John Sullivan.

<rdar://problem/4550801> REGRESSION: Window throttle code can sometimes leak NSWindows

The window display throttle depended on windows being closed before they were deallocated; this is
not guaranteed by AppKit. Windows that were being released without being closed were getting stuck
in our NSWindow -> WindowDisplayInfo dictionary.


  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Don't retain the NSWindow keys in the window display info dictionary. Instead of overriding -close, override -dealloc and -finalize so that we can remove the NSWindow -> WindowDisplayInfo mapping when a window deallocates. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -dealloc and -finalize. (clearWindowDisplayInfo): Factored the WindowDisplayInfo cleanup code out of the now-defunct replacementClose(). (replacementClose): Removed; no longer needed. (replacementDealloc): Clear the WindowDisplayInfo for the window after deallocation. (replacementFinalize): ditto (-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]): Rewrote this method to be safe in the case where the firing display timer has the last reference to the window. Added comments.
6:02 PM Changeset in webkit [14455] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler


Improvement to my previous patch, suggested by Darin

  • dom/Document.cpp: (WebCore::Document::repaintMarkers): new method, similar in structure to removeMarkers but just repaints each node that has a marker of the specified type
  • dom/Document.h: declare new method, and tweak style in related method declarations


  • page/Frame.cpp: (WebCore::Frame::setMarkedTextMatchesAreHighlighted): if the value changes, call repaintMarkers
5:44 PM Changeset in webkit [14454] by eseidel
  • 6 adds in trunk/LayoutTests/fast/dom

2006-05-17 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Autogenerate button, optgroup, option, input and textarea js bindings
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8953

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createButtonWrapper): (WebCore::createInputWrapper): (WebCore::createOptGroupWrapper): (WebCore::createOptionWrapper): (WebCore::createTextAreaWrapper): (WebCore::createJSWrapper):
  • bindings/js/JSHTMLInputElementBase.cpp: Added. (WebCore::JSHTMLInputElementBaseProtoFunc::callAsFunction): (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  • bindings/js/JSHTMLInputElementBase.h: Added. (WebCore::JSHTMLInputElementBase::classInfo): (WebCore::JSHTMLInputElementBase::): (WebCore::JSHTMLInputElementBase::impl):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: Added. (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::implementsConstruct): (WebCore::JSHTMLOptionElementConstructor::construct):
  • bindings/js/JSHTMLOptionElementConstructor.h: Added.
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::htmlSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLButtonElement.idl: Added.
  • html/HTMLInputElement.idl: Added.
  • html/HTMLOptGroupElement.idl: Added.
  • html/HTMLOptionElement.idl: Added.
  • html/HTMLTextAreaElement.idl: Added.
5:44 PM Changeset in webkit [14453] by eseidel
  • 10 edits
    9 adds in trunk

2006-05-17 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Autogenerate button, optgroup, option, input and textarea js bindings
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8953

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createButtonWrapper): (WebCore::createInputWrapper): (WebCore::createOptGroupWrapper): (WebCore::createOptionWrapper): (WebCore::createTextAreaWrapper): (WebCore::createJSWrapper):
  • bindings/js/JSHTMLInputElementBase.cpp: Added. (WebCore::JSHTMLInputElementBaseProtoFunc::callAsFunction): (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  • bindings/js/JSHTMLInputElementBase.h: Added. (WebCore::JSHTMLInputElementBase::classInfo): (WebCore::JSHTMLInputElementBase::): (WebCore::JSHTMLInputElementBase::impl):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: Added. (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::implementsConstruct): (WebCore::JSHTMLOptionElementConstructor::construct):
  • bindings/js/JSHTMLOptionElementConstructor.h: Added.
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::htmlSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLButtonElement.idl: Added.
  • html/HTMLInputElement.idl: Added.
  • html/HTMLOptGroupElement.idl: Added.
  • html/HTMLOptionElement.idl: Added.
  • html/HTMLTextAreaElement.idl: Added.
4:45 PM Changeset in webkit [14452] by beidson
  • 4 edits
    2 deletes in trunk/WebKit

2006-05-17 bradeeoh <​beidson@apple.com>

Reviewed by Tim Hatcher

Consolidated WebDatabase base class into WebFileDatabase as the inheritance relationship became
obsolete. This improves readability and sets the stage for a further in-depth rewrite of the
WebIcon* code.

  • Misc/WebDatabase.h: Removed.
  • Misc/WebDatabase.m: Removed.
  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (-[WebFileDatabaseOp dealloc]): (-[WebFileDatabase dealloc]): (-[WebFileDatabase path]): (-[WebFileDatabase isOpen]): (-[WebFileDatabase sizeLimit]):
  • WebKit.xcodeproj/project.pbxproj:
4:32 PM Changeset in webkit [14451] by adele
  • 30 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated test results for changes to prepare for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

  • fast/block/float/032-expected.txt:

WebCore:

Reviewed by Hyatt.

First step for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

New textareas can be turned on by setting -webkit-appearance:textarea.

Tests:

  • LayoutTests/fast/block/float/032.html - Updated results.
  • bridge/mac/FrameMac.h: Added textDidChangeinTextArea to send notification over the bridge to form delegate.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::textDidChangeInTextArea): ditto.
  • page/Frame.cpp: (WebCore::Frame::textDidChangeInTextArea): ditto.
  • page/Frame.h: ditto.
  • css/CSSValueKeywords.in: Added textarea.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Updates to check for textarea.
  • css/html4.css: Added style for textarea. Leaved background-color and appearance values commented out.
  • rendering/render_style.h: (WebCore::): Added TextAreaAppearance.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Updated for textarea. (WebCore::RenderTheme::paint): ditto. (WebCore::RenderTheme::paintBorderOnly): ditto. (WebCore::RenderTheme::isControlStyled): ditto. (WebCore::RenderTheme::supportsFocusRing): ditto. (WebCore::RenderTheme::adjustTextFieldStyle): ditto. (WebCore::RenderTheme::adjustTextAreaStyle): ditto.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintTextArea): Added.
  • rendering/RenderThemeMac.h: Added adjustTextAreaStyle. Note- I didn't add a paintTextArea function for RenderThemeMac, since we can just paint the border specified in html4.css to match the NSTextView border. Added a paintTextArea function to the Windows theme can override that border.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Updated for textarea. (WebCore::RenderThemeMac::adjustTextAreaStyle): ditto.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::HTMLGenericFormElement): Moved m_valueMatchesRenderer and its setters and getters into this class so HTMLInputElement and HTMLTextArea can share.
  • html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::valueMatchesRenderer): Added. (WebCore::HTMLGenericFormElement::setValueMatchesRenderer): Added.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Remove m_valueMatchesRenderer intialization. (WebCore::HTMLInputElement::isKeyboardFocusable): Updated spelling. (WebCore::HTMLInputElement::createRenderer): Pass multiLine bool to RenderTextField constructor. (WebCore::HTMLInputElement::parseMappedAttribute): Use setValueMatchesRenderer instead of m_valueMatchesRenderer. (WebCore::HTMLInputElement::detach): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
  • html/HTMLInputElement.h: Remove setValueMatchesRenderer and valueMatchesRenderer and m_valueMatchesRenderer.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Calls setValueMatchesRenderer to intialize m_valueMatchesRenderer. (WebCore::HTMLTextAreaElement::selectionStart): Uses appearance to determine which renderer to use. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::setSelectionStart): ditto. (WebCore::HTMLTextAreaElement::setSelectionEnd): ditto. (WebCore::HTMLTextAreaElement::select): ditto. (WebCore::HTMLTextAreaElement::setSelectionRange): ditto. (WebCore::HTMLTextAreaElement::createRenderer): ditto. (WebCore::HTMLTextAreaElement::appendFormData): ditto. (WebCore::HTMLTextAreaElement::updateValue): ditto. (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Added. (WebCore::HTMLTextAreaElement::isMouseFocusable): Added. (WebCore::HTMLTextAreaElement::focus): Added. (WebCore::HTMLTextAreaElement::defaultEventHandler): Added to forward events to the inner div. (WebCore::HTMLTextAreaElement::setValue): Calls setValueMatchesRenderer.
  • html/HTMLTextAreaElement.h: Added defaultEventHandler, isMouseFocusable, isKeyboardFocusable, and focus methods. Removed invalidateValue and m_valueMatchesRenderer since those are now handled in the base class.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Updated to handle textareas.
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::valueChanged): Calls setValueMatchesRenderer(false) instead of invalidateValue.
  • rendering/RenderTextField.h: Changed to be a RenderFlexibleBox instead of a RenderBlock. This was necessary to get the inner div's height to grow and shrink with the size of the textarea. Added m_multiLine bool, and calcHeight, canHaveChildren, baselinePosition, isTextArea, textWithHardLineBreaks, selectionChanged. (WebCore::RenderTextField::canHaveChildren): Returns false now so that no renderer gets created for the textarea's child text node for its initial contents. (WebCore::RenderTextField::isTextField): Returns true if m_multiLine is false. (WebCore::RenderTextField::isTextArea): Returns true if m_multiLine is true.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::RenderTextField): Initializes m_multiLine. (WebCore::RenderTextField::~RenderTextField): Notifies HTMLTextAreaElement that the renderer is being destroyed so the value gets updated. (WebCore::RenderTextField::setStyle): Makes sure there's no overflow clip on the RenderTextField, since we're handling overflow on the inner div. (WebCore::RenderTextField::createDivStyle): Sets white-space, box-flex, overflow, word-wrap styles needed for text area. (WebCore::RenderTextField::updateFromElement): Updated for textarea elements. (WebCore::RenderTextField::setSelectionRange): Optimized caret case by checking to see if start is equal to end before calculating the same VisiblePosition twice. (WebCore::RenderTextField::subtreeHasChanged): Updated for textarea elements. (WebCore::RenderTextField::text): Use innerText so newlines are considered. (WebCore::RenderTextField::textWithHardLineBreaks): Added. Not implemented yet. Just calls text method. (WebCore::RenderTextField::calcHeight): Added. Sets initial height based on specified number of rows, and then calls the base class. (WebCore::RenderTextField::baselinePosition): Added. Unlike text fields, textareas align to the bottom. (WebCore::RenderTextField::calcMinMaxWidth): Updated for textareas. (WebCore::RenderTextField::selectionChanged): Added. Not implemented yet.

WebKit:

Reviewed by Hyatt.

WebKit part of initial checkin to prepare for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

  • WebView/WebHTMLView.m: (-[NSArray insertNewline:]): If we're in plain text mode, insert a line break instead of a paragraph separator. (-[NSArray insertParagraphSeparator:]): ditto.
  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Checks for textareas as well as textfields before allowing the delegate to control the context menu. This won't affect the old textareas because AppKit handles those context menus.

WebKitTools:

Reviewed by Hyatt.

  • Scripts/do-webcore-rename: Added RenderTextField => RenderTextControl and HTMLTextFieldInnerElement => HTMLTextControlInnerElement to list for future renames.
2:29 PM Changeset in webkit [14450] by hyatt
  • 6 edits
    3 adds in trunk/WebCore

Fix for 8954, separate the glyph map out into its own files and make it
cross-platform.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::WidthIterator::advance):
  • platform/FontData.h: (WebCore::FontData::glyphDataForCharacter): (WebCore::FontData::setGlyphDataForCharacter):
  • platform/GlyphMap.cpp: Added. (WebCore::GlyphMap::glyphDataForCharacter): (WebCore::GlyphMap::setGlyphDataForCharacter): (WebCore::GlyphMap::locatePage):
  • platform/GlyphMap.h: Added. (WebCore::GlyphMap::GlyphMap): (WebCore::GlyphMap::~GlyphMap): (WebCore::GlyphMap::GlyphPage::glyphDataForCharacter): (WebCore::GlyphMap::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphMap::GlyphPage::setGlyphDataForIndex):
  • platform/mac/FontData.mm: (-[NSFont WebCore]): (WidthMap::m_ATSUMirrors): (WidthMap::FontData::~FontData): (WidthMap::FontData::xHeight): (WidthMap::FontData::platformInit): (WidthMap::extendWidthMap):
  • platform/mac/GlyphMapMac.cpp: Added. (WebCore::GlyphMap::fillPage):
  • platform/mac/WebCoreSystemInterface.h:
2:10 PM Changeset in webkit [14449] by andersca
  • 5 edits
    1 add
    2 deletes in trunk/WebCore

2006-05-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8958
Should be able to have custom implementations for JS methods


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DBase.cpp: Removed.
  • bindings/js/JSCanvasRenderingContext2DBase.h: Removed.
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Added. Remove JSCanvasRenderingContext2DBase and add JSCanvasRenderingContext2DCustom with custom implementations.


(WebCore::toJS):
(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::strokeStyle):
(WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
(WebCore::JSCanvasRenderingContext2D::fillStyle):
(WebCore::JSCanvasRenderingContext2D::setFillStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::strokeRect):
(WebCore::JSCanvasRenderingContext2D::drawImage):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::createPattern):
Move implementations from JSCanvasRenderingContext2DBase.


  • bindings/scripts/CodeGeneratorJS.pm: Add new "Custom" extended attribute for functions and attributes. When a function or attribute has this attribute, a custom implementation is called instead of calling down to the DOM object.


  • html/CanvasRenderingContext2D.idl: Add bunch of custom attributes and functions.
2:05 PM Changeset in webkit [14448] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

First step towards making text-matching mechanism more flexible; updated for changes
to WebCoreFrameBridge calls.

  • WebView/WebHTMLView.m: (-[WebHTMLView highlightAllMatchesForString:caseSensitive:]): updated for name change in WebCoreFrameBridge, also now calls setMarkedTextMatchesAreHighlighted: (-[WebHTMLView clearHighlightedMatches]): updated for name change in WebCoreFrameBridge
2:04 PM Changeset in webkit [14447] by sullivan
  • 8 edits in trunk/WebCore

Reviewed by Maciej.


First step towards making text-matching mechanism more flexible; now caller can
control whether or not the matches are highlighted.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:]): renamed from highlightAllMatchesForString: (-[WebCoreFrameBridge markedTextMatchesAreHighlighted]): new getter method (-[WebCoreFrameBridge setMarkedTextMatchesAreHighlighted:]): new setter method (-[WebCoreFrameBridge unmarkAllTextMatches]): renamed from clearHighlightedMatches


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): renamed from highlightAllMatchesForString (WebCore::Frame::markedTextMatchesAreHighlighted): new getter method, uses boolean ivar in FramePrivate (WebCore::Frame::setMarkedTextMatchesAreHighlighted): new setter method, uses boolean ivar in FramePrivate


  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): added boolean ivar m_highlightTextMatches, initialized to 0


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): respect markedTextMatchesAreHighlighted
  • WebCore.xcodeproj/project.pbxproj: newer Xcode removed some obsolete settings
2:01 PM Changeset in webkit [14446] by thatcher
  • 1 copy in tags/WebCore-418.7/WebCore

Tag for WebCore 418.7 (part 2 of 2.)

2:01 PM Changeset in webkit [14445] by thatcher
  • 1 add in tags/WebCore-418.7

Tag for WebCore 418.7 (part 1 of 2.)

2:01 PM Changeset in webkit [14444] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:00 PM Changeset in webkit [14443] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.


<rdar://problem/4542925> 10.4.7 regression: Mail: Using the delete key may cause application crash in DOM::NodeImpl::isBlockFlow() const from khtml::DeleteSelectionCommand::mergeParagraphs()


  • khtml/editing/htmlediting.cpp: (positionBeforeContainingSpecialElement): (positionAfterContainingSpecialElement): (positionOutsideContainingSpecialElement): (positionBeforePossibleContainingSpecialElement): (positionAfterPossibleContainingSpecialElement): (DeleteSelectionCommand::initializePositionData): Fix special element handling to not create selection that does not completely surround the element.


(DeleteSelectionCommand::mergeParagraphs):
Incorporate the remainder of the improved merge code.


  • xml/dom_position.cpp: (inRenderedContent): Allow br 0 unconditionally.
1:47 PM Changeset in webkit [14442] by thatcher
  • 1 copy in tags/WebKit-418.5/WebKit

Tag for WebKit 418.5 (part 2 of 2.)

1:47 PM Changeset in webkit [14441] by thatcher
  • 1 add in tags/WebKit-418.5

Tag for WebKit 418.5 (part 1 of 2.)

1:47 PM Changeset in webkit [14440] by thatcher
  • 1 copy in tags/WebCore-418.6/WebCore

Tag for WebCore 418.6 (part 2 of 2.)

1:47 PM Changeset in webkit [14439] by thatcher
  • 1 add in tags/WebCore-418.6

Tag for WebCore 418.6 (part 1 of 2.)

1:44 PM Changeset in webkit [14438] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

1:43 PM Changeset in webkit [14437] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:19 AM Changeset in webkit [14436] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Reverting change that Darin made a few weeks ago. He was trying to make editingIgnoresContent return true for the new text fields, but the code actually didn't change that result. When the new text fields actually do return true for editingIgnoresContent, other editing problems are exposed. For example, moving the cursor around an editable area that contains a text field will cross the text field boundary and descend into the shadow tree. So for now, we'll revert this change.
10:19 AM Changeset in webkit [14435] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Test: fast/js/regexp-stack-overflow.html

  • pcre/pcre-config.h: Define NO_RECURSE.

May 16, 2006:

11:51 PM Changeset in webkit [14434] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/encoding/high-bit-latin1-expected.txt: Added.
  • fast/encoding/high-bit-latin1.html: Added.

WebCore:

Reviewed by Maciej, tweaked by Darin.

Test: fast/encoding/high-bit-latin1.html

  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): Use an unsigned char local.
  • platform/StringImpl.cpp: (WebCore::StringImpl::init): Ditto.
11:46 PM Changeset in webkit [14433] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7492
CSS attribute selectors fail when the setAttribute() method is used
to create an attribute and the attribute name is not Class or ID.

  • fast/css/selector-set-attribute.html: Added.
  • fast/css/selector-set-attribute-expected.txt: Added.
  • fast/css/selector-set-attribute-expected.checksum: Added.
  • fast/css/selector-set-attribute-expected.png: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7492
CSS attribute selectors fail when the setAttribute() method is used
to create an attribute and the attribute name is not Class or ID.

Keep track of attributes used in attribute selectors to
check after setAttribute whether a style recalc is needed.

Test: fast/css/selector-set-attribute.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
  • css/cssstyleselector.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
11:36 PM Changeset in webkit [14432] by darin
  • 6 edits in trunk/WebKit

Reviewed by Geoff.


Ensured all the public headers have a newline at their end.

Client code can now have 'Missing Newline at end of File' warnings enabled without emitting
such warnings against any WebKit includes.

  • Misc/WebDownload.h:
  • Plugins/npfunctions.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
11:34 PM Changeset in webkit [14431] by darin
  • 2 edits in trunk

Correct bug number.

11:33 PM Changeset in webkit [14430] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5624
document.createElementNS() should not allow to insert a second <html> element

  • dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Updated to show a different failure.
  • dom/xhtml/level3/core/nodeappendchild02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore06-expected.txt:
  • dom/xhtml/level3/core/nodereplacechild39-expected.txt: Updated to reflect success.
  • fast/dom/createDocumentType2.html: Added.
  • fast/dom/createDocumentType2-expected.txt: Added.
  • fast/dom/createElementNS.html: Added.
  • fast/dom/createElementNS-expected.txt: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5624
document.createElementNS() should not allow to insert a second <html> element

Do extra checks for document nodes to detect multiple document elements
and document types.

  • dom/Document.cpp: (WebCore::Document::childTypeAllowed):
  • dom/Document.h:
10:29 PM Changeset in webkit [14429] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix some warnings and strict compilation errors.

7:11 PM Changeset in webkit [14428] by aliceli1
  • 1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added yahoo.com preview to the hit list, moved capitalone to alumni list

5:58 PM Changeset in webkit [14427] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8945 (REGRESSION: Scrolling is very slow when dragging
the thumb)

Rolled out one of my tweaks to the window display throttle hack (remember the last flush time instead
of the last display time). While that was technically a better approach, we discovered a problem
with how it interacts with NSView scroll tracking. Rather than further complicate this already
crazy hack, I'm reverting back to the simple version. This should yield similar numbers on iBench,
but not exhibit the nasty scrolling problem.


  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): (+[NSWindow _webkit_disableWindowDisplayThrottle]): (getWindowDisplayInfo): (requestWindowDisplay):
5:07 PM Changeset in webkit [14426] by justing
  • 5 edits in branches/Safari-2-0-branch/WebCore

Reviewed by levi


<rdar://problem/4547278> 10.4.7 regression: Mail: Triple click, then drag, fails to select an empty line following a non-empty line


Merged in the fix for:
<rdar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  • khtml/editing/selection.cpp: (khtml::Selection::validate):
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::isEndOfLine): (khtml::endOfParagraph): (khtml::isEndOfParagraph): (khtml::endOfBlock): (khtml::isEndOfBlock):
  • khtml/editing/visible_units.h: (khtml::):
5:01 PM Changeset in webkit [14425] by thatcher
  • 1 edit in trunk/WebCore/platform/FontPlatformData.h

64-bit build fix, use uintptr_t to cast from a pointer.

4:29 PM Changeset in webkit [14424] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

4:27 PM Changeset in webkit [14423] by andersca
  • 16 edits in trunk/WebCore

2006-05-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • DerivedSources.make: Conditionally generate the SVG and XPath related files based on the value of FEATURE_DEFINES. Also, pass FEATURE_DEFINES TO THE BINDINGS GENERATOR.


  • WebCore.xcodeproj/project.pbxproj: Add FEATURE_DEFINES as a toplevel build setting and set it to "SVG_SUPPORT XPATH_SUPPORT" to keep SVG and XPath support turned on. Add FEATURE_DEFINES to the CPP defines.


  • bindings/js/kjs_binding.cpp: (KJS::setDOMException): Add #ifdefs around the XPath code.


  • bindings/scripts/CodeGeneratorJS.pm: Add "Conditional" extended attribute for interfaces. If this is set, the generated code will be surrounded by an #if.


  • bindings/scripts/IDLParser.pm: Pass the define flags on to the preprocessor.


  • bindings/scripts/generate-bindings.pl: Add a --defines property and pass it on to the parser.


  • css/cssstyleselector.h: Add DeprecatedString.h include.


  • dom/Document.idl: Put back #if around the XPath functions


  • page/DOMWindow.idl: Put #if around the XPath constructors


  • xpath/XPathEvaluator.idl:
  • xpath/XPathExpression.idl:
  • xpath/XPathNSResolver.cpp:
  • xpath/XPathNSResolver.idl:
  • xpath/XPathNamespace.cpp:
  • xpath/XPathResult.idl: Add "Conditional=XPATH" to all interfaces.
4:13 PM Changeset in webkit [14422] by beidson
  • 2 edits in trunk/WebKit

2006-05-16 bradeeoh <​beidson@apple.com>

Reviewed by Maciej Stachowiak

  • Fixed an old deprecated method in Misc/WebFileDatabase.m
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey): changed lossyCString to UTF8String
3:28 PM Changeset in webkit [14421] by darin
  • 9 edits in trunk/WebKit

Reviewed by Anders.

  • did the name change from "ImageElement" to "ImageForElement" that I said I would (oops!)
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]):
  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
  • WebView/WebView.m: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]): (-[WebView writeElement:withPasteboardTypes:toPasteboard:]):
  • WebView/WebViewInternal.h:
3:25 PM Changeset in webkit [14420] by darin
  • 29 edits
    9 deletes in trunk

WebCore:

Reviewed by Anders.

  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRenderer.h.
  • platform/mac/WebCoreImageRenderer.h: Removed.
  • bridge/mac/WebCoreFrameBridge.h: Added supportedImageResourceMIMETypes. Like supportedImageMIMETypes, but includes PDF and PostScript.
  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): Added. Has code that came from -[WebImageRendererFactory supportedMIMETypes]. (+[WebCoreFrameBridge supportedImageMIMETypes]):
  • platform/mac/ImageMac.mm: (WebCore::Image::supportsType): Instead of calling the old -[WebCoreImageRendererFactory supportedMIMETypes], call the new +[WebCoreFrameBridge supportedImageResourceMIMETypes]. (WebCore::Image::drawTiled): Use wkSetPatternPhaseInUserSpace instead of the WebCoreImageRendererFactory.
  • platform/mac/ClipboardMac.mm: Removed an unneeded include of WebCoreImageRenderer.h.
  • platform/mac/WebCoreImageRendererFactory.h: Removed everything except for the one remaining method, imageDataForName:, which gets resources from the WebKit localized resources. We should figure out how to remove that one too later.
  • platform/mac/WebCoreImageRendererFactory.m: Ditto.
  • platform/mac/WebCoreSystemInterface.h: Added some new calls.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • WebCore.exp: Ditto.
  • platform/cairo/ImageCairo.cpp: Moved a stub to the stubs file. If it's here it has to have a FIXME comment and also it contains a big commented-out pile of code. Better to have it in the stubs file with all the other stubs.
  • platform/win/TemporaryLinkStubs.cpp: (Image::drawTiled): Put stub here instead of having it in ImageCairo.cpp.

WebKit:

Reviewed by Anders.

  • English.lproj/StringsNotToBeLocalized.txt: Updated for many recent changes.
  • WebKit.xcodeproj/project.pbxproj: Removed files.
  • WebCoreSupport/WebImageData.h: Removed.
  • WebCoreSupport/WebImageData.m: Removed.
  • WebCoreSupport/WebImageDecodeItem.h: Removed.
  • WebCoreSupport/WebImageDecodeItem.m: Removed.
  • WebCoreSupport/WebImageDecoder.h: Removed.
  • WebCoreSupport/WebImageDecoder.m: Removed.
  • WebCoreSupport/WebImageRenderer.h: Removed.
  • WebCoreSupport/WebImageRenderer.m: Removed.
  • WebCoreSupport/WebImageRendererFactory.h:
  • WebCoreSupport/WebImageRendererFactory.m: Removed everything except for shouldUseThreadedDecoding, setShouldUseThreadedDecoding, and imageDataForName:.
  • Misc/WebNSPasteboardExtras.h: Removed WebImageRenderer parameter from _web_declareAndWriteDragImage and renamed _web_declareAndWriteDragImageElement.
  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Changed to call +[WebFrameBridge supportedImageResourceMIMETypes] instead of -[WebImageRendererFactory supportedMIMETypes]. (-[NSPasteboard _web_declareAndWriteDragImageElement:URL:title:archive:source:]): Removed WebImageRenderer parameter, and updated code since it was always nil.
  • Misc/WebNSViewExtras.h: Removed WebImageRenderer parameter from _web_dragImage and renamed _web_dragImageElement.
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragImageElement:rect:event:pasteboard:source:offset:]): Removed WebImageRenderer parameter, and updated code since it was always nil.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added some new functions now used by WebCore.
  • WebView/WebDataSource.m: (-[WebDataSource _documentFragmentWithArchive:]): Call +[WebFrameBridge supportedImageResourceMIMETypes] instead of -[WebImageRendererFactory supportedMIMETypes].
  • WebView/WebFrameView.m: Removed include of WebImageRenderer.h.
  • WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedImageMIMETypes]): Removed call to +[WebImageRendererFactory createSharedFactory].
  • WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): Call +[WebFrameBridge supportedImageResourceMIMETypes] instead of -[WebImageRendererFactory supportedMIMETypes]. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Update to no longer pass nil for an image to _web_declareAndWriteDragImageElement and to _web_dragImageElement. (-[WebHTMLView dealloc]): Remove call to now-unneeded _reset. (-[WebHTMLView finalize]): Ditto. (-[WebHTMLView viewDidMoveToWindow]): Remove logic for calling _reset, including the inWindow boolean field.
  • WebView/WebHTMLViewInternal.h: Removed inWindow boolean.
  • WebView/WebHTMLViewPrivate.h: Removed _reset method.
2:38 PM Changeset in webkit [14419] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Rolled out this earlier change. This change caused:
REGRESSION: Scrolling is very slow when dragging the thumb
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8945

2006-05-12 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
1:26 PM Changeset in webkit [14418] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Hyatt.

REGRESSION: revert SGML comment parsing fix (comment parsing causes most of usbank.com page to be missing)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5855

This also fixes:
<rdar://problem/4543829> -[DOMComment nodeValue] and -[DOMComment data] returning too much

12:26 PM Changeset in webkit [14417] by andersca
  • 3 edits in trunk/WebCore

2006-05-16 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8941
document.cookie undefined for documents of type text/javascript


  • loader/TextDocument.cpp: (WebCore::TextDocument::TextDocument):
  • loader/TextDocument.h: Inherit from HTMLDocument.
8:13 AM Changeset in webkit [14416] by darin
  • 6 edits in trunk

WebCore:

Reviewed by Hyatt.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge domain]): Removed unneeded check of isHTMLDocument. (-[WebCoreFrameBridge getData:andResponse:forURL:]): Handle document() of 0. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto.

WebKit:

Reviewed by Hyatt.

These fixes may become obsolete when Anders lands his standalone image viewer
patch, but in my tree they are needed to make Copy Image work after the fix
over on the WebCore side to avoid the crashes.

  • Misc/WebNSPasteboardExtras.h: Change _web_writeImage parameter to an NSImage.
  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Change parameter to an NSImage instead of a WebImageRenderer. (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]): Call -[WebImageRenderer image] to get an NSImage to pass to _web_writeImage.
  • WebView/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): Get the image using WebElementImageKey if WebElementDOMNodeKey is nil.
3:02 AM Changeset in webkit [14415] by eseidel
  • 6 edits
    5 adds in trunk/WebCore

2006-05-16 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Autogenerate BASE, HEAD, LINK, STYLE and TITLE JS bindings.

Already covered by existing dom tests.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createBaseWrapper): (WebCore::createHeadWrapper): (WebCore::createLinkWrapper): (WebCore::createStyleWrapper): (WebCore::createTitleWrapper): (WebCore::createJSWrapper):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors):
  • bindings/js/kjs_html.h:
  • html/HTMLBaseElement.idl: Added.
  • html/HTMLHeadElement.idl: Added.
  • html/HTMLLinkElement.idl: Added.
  • html/HTMLStyleElement.idl: Added.
  • html/HTMLTitleElement.idl: Added.
2:30 AM Changeset in webkit [14414] by andersca
  • 31 edits
    2 adds
    4 deletes in trunk

WebCore:

2006-05-16 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8921
Use WebCore to render full-frame images.

  • WebCore.xcodeproj/project.pbxproj: Add ImageDocument.


  • bridge/mac/WebCoreFrameBridge.h: Add mainResourceURLResponse and imageTitleForFilename.


  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedNonImageMIMETypes]): This used to be supportedMIMETypes but WebKit requires that we handle the image MIME types separately.


(+[WebCoreFrameBridge supportedImageMIMETypes]):
Add image types from WebCoreImageRendererFactory.


(-[WebCoreFrameBridge canProvideDocumentSource]):
Return no for image types.


  • dom/xml_tokenizer.h: (WebCore::Tokenizer::wantsRawData): (WebCore::Tokenizer::writeRawData): New virtual functions which tokenizers can override if they want to get raw data (which isn't fed through the decoder)


  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::setLoadManually): New function which calls HTMLImageLoader::setLoadManually


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): Don't request the image from the loader if the load is set to be manual.


  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::setLoadManually): New function which decides if the image data should be fed manually or loaded by the loader.


  • loader/DocLoader.h: Add HTMLImageLoader as a friend.


  • loader/ImageDocument.cpp: Added. (WebCore::ImageTokenizer::ImageTokenizer): (WebCore::ImageTokenizer::wantsRawData): (WebCore::ImageTokenizer::write): (WebCore::ImageTokenizer::writeRawData): (WebCore::ImageTokenizer::stopParsing): (WebCore::ImageTokenizer::finish): (WebCore::ImageTokenizer::isWaitingForScripts): (WebCore::ImageDocument::ImageDocument): (WebCore::ImageDocument::createTokenizer):
  • loader/ImageDocument.h: Added. Add new ImageDocument class which will feed its data to a created image element.
  • loader/TextDocument.h: Inherit from HTMLDocument here too, in case any broken web pages want to manipulate the DOM of any plain text documents.


  • page/Frame.cpp: (WebCore::Frame::begin): (WebCore::Frame::write): Don't create or use the decoder if the tokenizer is in "raw mode".


WebKit:

2006-05-16 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8921
Use WebCore to render full-frame images


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge determineObjectFromMIMEType:URL:]): Remove WebImageView handling.


(-[WebFrameBridge mainResourceURLResponse]):
New function which returns the URL response for the main resource. This is used by the
manual loading of images.


(-[WebFrameBridge imageTitleForFilename:size:]):
New function which returns a correctly translated image title given a filename and a size.


  • WebCoreSupport/WebImageRenderer.m: (-[WebImageRenderer _startOrContinueAnimationIfNecessary]): Remove WebImageView handling.


  • WebKit.xcodeproj/project.pbxproj: Remove WebImageRepresentation and WebImageView.


  • WebView/WebArchiver.h:
  • WebView/WebArchiver.m: (+[WebArchiver archiveMainResourceForFrame:]): New functions which returns a WebArchive with just the main resource, ignoring any subresources.


  • WebView/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): Use MIME types from WebHTMLRepresentation instead of WebImageRepresentation.


  • WebView/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Use MIME types from WebHTMLRepresentation instead of WebImageRepresentation.


(+[WebHTMLRepresentation supportedMIMETypes]):
Create an array of image and non-image MIME Types.


(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
New functions, separating the list of MIME types into image and non-image ones.


  • WebView/WebHTMLView.m: (+[WebHTMLView supportedImageMIMETypes]): (+[WebHTMLView supportedNonImageMIMETypes]): New functions which call down to WebHTMLRepresentation.


(-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
If the image element comes from an ImageDocument, just use an archive of the main resource
instead of the generated HTML document.


  • WebView/WebHTMLViewPrivate.h: Declare new functions.


  • WebView/WebImageRepresentation.h: Removed.
  • WebView/WebImageRepresentation.m: Removed.
  • WebView/WebImageView.h: Removed.
  • WebView/WebImageView.m: Removed.


LayoutTests:

2006-05-16 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8921
Use WebCore to render full-frame images.

  • css2.1/t0801-c412-hz-box-00-b-a-expected.txt:
  • dom/xhtml/level2/html/frame-expected.checksum:
  • dom/xhtml/level2/html/frame-expected.png:
  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.checksum:
  • dom/xhtml/level2/html/iframe-expected.png:
  • dom/xhtml/level2/html/iframe-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.txt: Update tests.
2:26 AM Changeset in webkit [14413] by eseidel
  • 8 edits
    4 adds in trunk

2006-05-16 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Autogenerate JSHTMLMetaElement.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8938

Test: fast/dom/HTMLMetaElement/meta-attributes.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createMetaWrapper): (WebCore::createJSWrapper):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors):
  • bindings/js/kjs_html.h:
  • html/HTMLMetaElement.h:
2:06 AM Changeset in webkit [14412] by hyatt
  • 17 edits
    3 adds
    3 deletes in trunk/WebCore

Bug 8936, eliminate WebTextRendererFactory and convert it over to the
new FontCache.

Reviewed by andersca

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm:
  • platform/Font.h: (WebCore::Font::bold):
  • platform/FontCache.cpp: Added. (WebCore::FontPlatformDataCacheKey::m_italic): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontCache::getCachedFontPlatformData): (WebCore::FontDataCacheKeyHash::hash): (WebCore::FontDataCacheKeyHash::equal): (WebCore::FontDataCacheKeyTraits::deletedValue): (WebCore::FontCache::getCachedFontData): (WebCore::FontCache::getFontData): (WebCore::FontCache::clearCommonCaches):
  • platform/FontCache.h:
  • platform/FontData.h:
  • platform/FontFamily.cpp: (WebCore::FontFamily::FontFamily): (WebCore::FontFamily::operator=): (WebCore::FontFamily::setFamily):
  • platform/FontFamily.h: (WebCore::FontFamily::familyIsEmpty):
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/mac/FontCacheMac.mm: (WebCore::getAppDefaultValue): (WebCore::getUserDefaultValue): (WebCore::getLCDScaleParameters): (WebCore::fontsChanged): (WebCore::FontCache::registerForFontChanges): (WebCore::FontCache::clearCaches): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::createFontPlatformData):
  • platform/mac/FontData.mm: (-[NSFont WebCore]): (WidthMap::FontData::xHeight): (WidthMap::FontData::smallCapsFontData): (WidthMap::computeWidthForSpace): (WidthMap::setUpFont): (WidthMap::fillStyleWithAttributes): (WidthMap::FontData::determinePitch):
  • platform/mac/FontFallbackListMac.mm: (WebCore::FontFallbackList::setPlatformFont):
  • platform/mac/FontFamilyMac.mm: Removed.
  • platform/mac/FontMac.mm:
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreFindFont):
  • platform/mac/WebFontCache.h: Added.
  • platform/mac/WebFontCache.mm: Added. (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):
  • platform/mac/WebTextRendererFactory.h: Removed.
  • platform/mac/WebTextRendererFactory.mm: Removed.
1:31 AM Changeset in webkit [14411] by hyatt
  • 8 edits in trunk/LayoutTests/fast/text

Update fast/text results.

1:20 AM Changeset in webkit [14410] by eseidel
  • 2 edits
    1 add in trunk/WebCore

2006-05-16 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add Rect.idl, even though it can't be used quite yet due to generator limitations.

  • WebCore.xcodeproj/project.pbxproj:
  • css/Rect.idl: Added.
12:54 AM Changeset in webkit [14409] by eseidel
  • 2 edits in trunk/WebCore

2006-05-16 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by darin. Landed by eseidel.

Patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8924>
Bug 8924: re-apply the 'disabled type=file' change
from bug 5882 to RenderFileButton


  • rendering/RenderFileButton.cpp: (WebCore::RenderFileButton::updateFromElement):
12:52 AM Changeset in webkit [14408] by eseidel
  • 42 edits
    5 copies
    2 moves in trunk/WebCore

2006-05-16 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Split css_base.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8935

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • css/CSSBorderImageValue.cpp:
  • css/CSSBorderImageValue.h:
  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.h:
  • css/CSSGrammar.y:
  • css/CSSImportRule.h:
  • css/CSSInheritedValue.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSMediaRule.h:
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSNamespace.h: Added. (WebCore::CSSNamespace::CSSNamespace): (WebCore::CSSNamespace::namespaceForPrefix):
  • css/CSSPageRule.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.cpp:
  • css/CSSProperty.h:
  • css/CSSRule.h:
  • css/CSSRuleList.cpp:
  • css/CSSSelector.cpp: Added.
  • css/CSSSelector.h: Added. (WebCore::CSSSelector::CSSSelector):
  • css/CSSStyleDeclaration.h:
  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::~CSSStyleSheet):
  • css/CSSStyleSheet.h:
  • css/CSSValue.h:
  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:
  • css/FontValue.cpp:
  • css/FontValue.h:
  • css/MediaList.h:
  • css/ShadowValue.cpp:
  • css/ShadowValue.h:
  • css/StyleBase.cpp: Added. (WebCore::StyleBase::stylesheet):
  • css/StyleBase.h: Added. (WebCore::StyleBase::StyleBase):
  • css/StyleList.cpp: Added.
  • css/StyleList.h: Added.
  • css/StyleSheet.h:
  • css/css_base.cpp: Removed.
  • css/css_base.h: Removed.
  • css/cssparser.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
  • css/cssstyleselector.h:
  • dom/CSSMappedAttributeDeclaration.h:
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::cssText): (WebCore::SVGColor::color):
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::className): (WebCore::SVGStyledElement::createRenderer): (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::notifyAttributeChange): (WebCore::SVGStyledElement::attributeChanged): (WebCore::SVGStyledElement::canvas): (WebCore::SVGStyledElement::updateCanvasItem): (WebCore::SVGStyledElement::pushAttributeContext):

May 15, 2006:

10:33 PM Changeset in webkit [14407] by eseidel
  • 54 edits
    42 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Split css_valueimpl.* and css_ruleimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8934

  • WebCore+SVG/RGBColor.cpp: (WebCore::RGBColor::RGBColor):
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::classInfo):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOMCSS.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSBorderImageValue.cpp: Added. (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h: Added.
  • css/CSSCharsetRule.h: Added. (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceRule.cpp: Added. (WebCore::CSSFontFaceRule::CSSFontFaceRule):
  • css/CSSFontFaceRule.h: Added. (WebCore::CSSFontFaceRule::isFontFaceRule):
  • css/CSSGrammar.y:
  • css/CSSImageValue.cpp: Added. (WebCore::CSSImageValue::CSSImageValue):
  • css/CSSImageValue.h: Added.
  • css/CSSImportRule.cpp: Added.
  • css/CSSImportRule.h: Added.
  • css/CSSInheritedValue.cpp: Added.
  • css/CSSInheritedValue.h: Added.
  • css/CSSInitialValue.cpp: Added.
  • css/CSSInitialValue.h: Added.
  • css/CSSMediaRule.cpp: Added. (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::~CSSMediaRule): (WebCore::CSSMediaRule::append): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
  • css/CSSMediaRule.h: Added. (WebCore::CSSMediaRule::media): (WebCore::CSSMediaRule::cssRules):
  • css/CSSMutableStyleDeclaration.cpp: Added. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::setChanged):
  • css/CSSMutableStyleDeclaration.h: Added.
  • css/CSSPageRule.cpp: Added. (WebCore::CSSPageRule::CSSPageRule):
  • css/CSSPageRule.h: Added. (WebCore::CSSPageRule::isPageRule):
  • css/CSSPrimitiveValue.cpp: Added.
  • css/CSSPrimitiveValue.h: Added.
  • css/CSSProperty.cpp: Added. (WebCore::CSSProperty::cssText):
  • css/CSSProperty.h: Added. (WebCore::CSSProperty::CSSProperty):
  • css/CSSQuirkPrimitiveValue.h: Added.
  • css/CSSRule.cpp: Added.
  • css/CSSRule.h: Added. (WebCore::CSSRule::CSSRule):
  • css/CSSRuleList.cpp: Added. (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::~CSSRuleList): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::append): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h: Added. (WebCore::CSSRuleList::item):
  • css/CSSStyleDeclaration.cpp: Added. (WebCore::CSSStyleDeclaration::CSSStyleDeclaration): (WebCore::CSSStyleDeclaration::diff):
  • css/CSSStyleDeclaration.h: Added.
  • css/CSSStyleRule.cpp: Added. (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::selectorText):
  • css/CSSStyleRule.h: Added.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::ownerRule):
  • css/CSSUnknownRule.h: Added. (WebCore::CSSUnknownRule::CSSUnknownRule):
  • css/CSSValue.h: Added.
  • css/CSSValueList.cpp: Added.
  • css/CSSValueList.h: Added.
  • css/Counter.h: Added.
  • css/DashboardRegion.h: Added.
  • css/FontFamilyValue.cpp: Added.
  • css/FontFamilyValue.h: Added. (WebCore::FontFamilyValue::genericFamilyType):
  • css/FontValue.cpp: Added. (WebCore::FontValue::cssText):
  • css/FontValue.h: Added.
  • css/MediaList.cpp:
  • css/Pair.h: Added. (WebCore::Pair::~Pair):
  • css/RectImpl.h: Added. (WebCore::RectImpl::~RectImpl):
  • css/ShadowValue.cpp: Added. (WebCore::ShadowValue::ShadowValue):
  • css/ShadowValue.h: Added.
  • css/css_base.cpp:
  • css/css_ruleimpl.cpp: Removed.
  • css/css_ruleimpl.h: Removed.
  • css/css_valueimpl.cpp: Removed.
  • css/css_valueimpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseFontFamily):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage):
  • css/cssstyleselector.h:
  • dom/CSSMappedAttributeDeclaration.h: (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
  • dom/Document.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditCommand.cpp:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertLineBreakCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): (WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::styleDeclaration):
  • html/HTMLBodyElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.h:
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderPath.h:
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • platform/DeprecatedValueList.h:
  • rendering/RenderTextField.cpp:
9:38 PM Changeset in webkit [14406] by ap
  • 5 edits in trunk

JavaScriptCore:

  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".

WebKitTools:

  • Scripts/install-unix-extras: Changed to be executable and removed text in the file generated by "svn diff".
  • Scripts/regenerate-makefiles: Ditto.
9:30 PM Changeset in webkit [14405] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Removed duplicate files that were screwing up Xcode.
8:11 PM Changeset in webkit [14404] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

Fix typo causing build failure.

7:54 PM Changeset in webkit [14403] by ggaren
  • 4 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4534904> please do not treat "debugger" as a reserved word while parsing JavaScript (and other ECMA reserved words)

AKA

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6179
We treat "char" as a reserved word in JavaScript and firefox/IE do
not

(1) I unreserved most of the spec's "future reserved words" because
they're not reserved in IE or FF. (Most, but not all, because IE
somewhat randomly *does* reserve a few of them.)
(2) I made 'debugger' a legitimate statement that acts like an empty
statement because FF and IE support it.


  • kjs/grammar.y:
  • kjs/keywords.table:

LayoutTests:

  • fast/js/debugger-expected.txt: Added.
  • fast/js/debugger.html: Added.
  • fast/js/reserved-words-expected.txt: Added.
  • fast/js/reserved-words.html: Added.
  • fast/js/resources/debugger.js: Added.
  • fast/js/resources/reserved-words.js: Added.
7:21 PM Changeset in webkit [14402] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

A few more style cleanup changes I missed in my last commit.

7:08 PM Changeset in webkit [14401] by eseidel
  • 33 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Split css_stylesheetimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8933

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: Added. (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::deleteRule): (WebCore::CSSStyleSheet::parseString): (WebCore::CSSStyleSheet::docLoader):
  • css/CSSStyleSheet.h: Added.
  • css/MediaList.cpp: Added. (WebCore::MediaList::MediaList): (WebCore::MediaList::contains): (WebCore::MediaList::parentStyleSheet): (WebCore::MediaList::parentRule): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText):
  • css/MediaList.h: Added.
  • css/StyleSheet.cpp: Added. (WebCore::StyleSheet::StyleSheet): (WebCore::StyleSheet::parentStyleSheet): (WebCore::StyleSheet::setMedia):
  • css/StyleSheet.h: Added. (WebCore::StyleSheet::ownerNode):
  • css/StyleSheetList.cpp: Added. (WebCore::StyleSheetList::~StyleSheetList): (WebCore::StyleSheetList::add): (WebCore::StyleSheetList::remove): (WebCore::StyleSheetList::item):
  • css/StyleSheetList.h: Added.
  • css/css_stylesheetimpl.cpp: Removed.
  • css/css_stylesheetimpl.h: Removed.
7:00 PM Changeset in webkit [14400] by darin
  • 3 edits in trunk/WebCore
  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".
  • move-js-headers.sh: Ditto.
6:04 PM Changeset in webkit [14399] by bdakin
  • 121 edits in trunk/LayoutTests

Reviewed by Darin.

These tests have new expected results after the fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6838 Incomplete
repaint of collapsed table borders

5:43 PM Changeset in webkit [14398] by thatcher
  • 3 edits in trunk/WebCore/platform/mac

64-bit build fixes.

5:04 PM Changeset in webkit [14397] by tomernic
  • 5 edits in trunk

JavaScriptCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • bindings/npapi.h: Define NP_NO_QUICKDRAW when compiling 64-bit; there is no 64-bit QuickDraw. Added NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool variables. Added NPDrawingModel enumeration. Currently the only drawing models are QuickDraw and CoreGraphics. NPRegion's type now depends on the drawing model specified by the plugin. NP_Port is now only defined when QuickDraw is available. Added NP_CGContext, which is the type of the NPWindow's "window" member in CoreGraphics mode.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • Plugins/WebBaseNetscapePluginView.h: Added PluginPort union, which wraps a NP_Port and a NP_CGContext. This is to make access to the nPort and lastSetPort ivars more convenient now that the port type differs based on the drawing model. Changed types of nPort and lastSetPort to PluginPort so they can be used with any drawing model. Added drawingModel ivar.
  • Plugins/WebBaseNetscapePluginView.m: Renamed PortState to PortState_QD. PortState is now an opaque pointer. PortState_QD cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView fixWindowPort]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Only fix window port if drawing model is QuickDraw. Re-ordered some code so I could group QuickDraw-specific stuff into switch and if blocks (that's why the diff here is so terrible). Now returns a malloc()'ed PortState that the caller is responsible for freeing. Renamed to better reflect this behavior. Support for the CoreGraphics drawing model -- fill PortState_CG struct, save CGContext state. (-[WebBaseNetscapePluginView restorePortState:]): Switch based on drawing model. Support for the CoreGraphics drawing model -- restore CGContext state saved earlier. (-[WebBaseNetscapePluginView sendEvent:]): Formatting. Don't set save/set port state or set the window in CoreGraphics mode unless the event being sent is an updateEvt. We can't provide the plugin with a CGContext outside of our view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Formatting. Switch how we compare ports based on the drawing model. (-[WebBaseNetscapePluginView updateAndSetWindow]): Fixed for CoreGraphics by triggering a redisplay instead of sending an update event to the plugin outside of the view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Assert that the window is only set when updating in CoreGraphics mode. Log differently depending on the drawing model. (-[WebBaseNetscapePluginView start]): Fall back on QuickDraw if the plugin does not specify a drawing model. (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Only call -tellQuickTimeToChill in QuickDraw mode. (-[WebBaseNetscapePluginView viewHasMoved:]): ditto (-[WebBaseNetscapePluginView invalidateRegion:]): NPRegion is a CGPathRef in CoreGraphics mode. (-[WebBaseNetscapePluginView getVariable:value:]): Added support for retriveing the NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool browser variables. (-[WebBaseNetscapePluginView setVariable:value:]): Added support for setting the NPNVpluginDrawingModel variable.
5:04 PM Changeset in webkit [14396] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: build fix.
4:53 PM Changeset in webkit [14395] by eseidel
  • 11 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Split dom_xmlimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Entity.cpp: Added. (WebCore::Entity::Entity):
  • dom/Entity.h: Added.
  • dom/EntityReference.cpp: Added. (WebCore::EntityReference::EntityReference):
  • dom/EntityReference.h: Added.
  • dom/Notation.cpp: Added. (WebCore::Notation::Notation):
  • dom/Notation.h: Added.
  • dom/ProcessingInstruction.cpp: Added. (WebCore::ProcessingInstruction::ProcessingInstruction):
  • dom/ProcessingInstruction.h: Added.
  • dom/dom_xmlimpl.cpp: Removed.
  • dom/dom_xmlimpl.h: Removed.
4:30 PM Changeset in webkit [14394] by thatcher
  • 1 edit in trunk/WebCore/kwq/KWQListBox.mm

build fix

4:23 PM Changeset in webkit [14393] by eseidel
  • 24 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim Hatcher.

Split html_imageimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8929

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp:
  • editing/JSEditor.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp: Added. (WebCore::HTMLAreaElement::HTMLAreaElement): (WebCore::HTMLAreaElement::mapMouseEvent): (WebCore::HTMLAreaElement::getRect): (WebCore::HTMLAreaElement::getRegion):
  • html/HTMLAreaElement.h: Added.
  • html/HTMLCanvasElement.h:
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLImageElement.cpp: Added. (WebCore::HTMLImageElement::HTMLImageElement):
  • html/HTMLImageElement.h: Added.
  • html/HTMLImageLoader.cpp: Added. (WebCore::HTMLImageLoader::HTMLImageLoader):
  • html/HTMLImageLoader.h: Added.
  • html/HTMLInputElement.cpp:
  • html/HTMLMapElement.cpp: Added. (WebCore::HTMLMapElement::mapMouseEvent): (WebCore::HTMLMapElement::parseMappedAttribute):
  • html/HTMLMapElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_imageimpl.cpp: Removed.
  • html/html_imageimpl.h: Removed.
  • ksvg2/misc/SVGImageLoader.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject addChildrenToArray:]):
  • page/Frame.cpp:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::nodeAtPoint):
3:22 PM Changeset in webkit [14392] by tomernic
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix and follow-up fix from TOT to Safari-2-0-branch

2006-05-15 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.

2006-05-15 Tim Omernick <​timo@apple.com>

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
3:18 PM Changeset in webkit [14391] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
2:57 PM Changeset in webkit [14390] by eseidel
  • 9 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split html_blockimpl.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8927

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • html/HTMLBlockquoteElement.cpp: Added. (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h: Added.
  • html/HTMLDivElement.cpp: Added.
  • html/HTMLDivElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLHRElement.cpp: Added.
  • html/HTMLHRElement.h: Added.
  • html/HTMLHeadingElement.cpp: Added.
  • html/HTMLHeadingElement.h: Added.
  • html/HTMLMarqueeElement.cpp: Added. (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/HTMLMarqueeElement.h: Added.
  • html/HTMLParagraphElement.cpp: Added.
  • html/HTMLParagraphElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPreElement.cpp: Added. (WebCore::HTMLPreElement::HTMLPreElement): (WebCore::HTMLPreElement::setWrap):
  • html/HTMLPreElement.h: Added.
  • html/HTMLTextFieldInnerElement.h:
  • html/html_blockimpl.cpp: Removed.
  • html/html_blockimpl.h: Removed.
  • rendering/RenderLayer.cpp:
2:16 PM Changeset in webkit [14389] by eseidel
  • 16 edits
    14 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Split render_list.* and html_listimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • html/HTMLDListElement.cpp: Added. (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDListElement.h: Added.
  • html/HTMLDirectoryElement.cpp: Added. (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDirectoryElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLLIElement.cpp: Added. (WebCore::HTMLLIElement::HTMLLIElement): (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach): (WebCore::HTMLLIElement::setType):
  • html/HTMLLIElement.h: Added.
  • html/HTMLMenuElement.cpp: Added. (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMenuElement.h: Added.
  • html/HTMLOListElement.cpp: Added. (WebCore::HTMLOListElement::HTMLOListElement): (WebCore::HTMLOListElement::parseMappedAttribute): (WebCore::HTMLOListElement::setType):
  • html/HTMLOListElement.h: Added. (WebCore::HTMLOListElement::start):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::checkDTD): (WebCore::HTMLOptionElement::text): (WebCore::HTMLOptionElement::setText): (WebCore::HTMLOptionElement::getSelect): (WebCore::HTMLOptionElement::setLabel):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement):
  • html/HTMLUListElement.cpp: Added. (WebCore::HTMLUListElement::HTMLUListElement):
  • html/HTMLUListElement.h: Added.
  • html/html_listimpl.cpp: Removed.
  • html/html_listimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • rendering/InlineFlowBox.cpp:
  • rendering/ListMarkerBox.cpp: Added. (WebCore::ListMarkerBox::ListMarkerBox): (WebCore::ListMarkerBox::isText):
  • rendering/ListMarkerBox.h: Added.
  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild): (WebCore::RenderContainer::layout): (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
  • rendering/RenderListItem.cpp: Added. (WebCore::RenderListItem::RenderListItem): (WebCore::RenderListItem::setStyle): (WebCore::RenderListItem::calcValue): (WebCore::RenderListItem::markerStringValue):
  • rendering/RenderListItem.h: Added. (WebCore::RenderListItem::renderName): (WebCore::RenderListItem::setValue): (WebCore::RenderListItem::setNotInList): (WebCore::RenderListItem::notInList):
  • rendering/RenderListMarker.cpp: Added. (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcMinMaxWidth):
  • rendering/RenderListMarker.h: Added. (WebCore::RenderListMarker::renderName):
  • rendering/RenderObject.cpp:
  • rendering/render_list.cpp: Removed.
  • rendering/render_list.h: Removed.
2:12 PM Changeset in webkit [14388] by hyatt
  • 1 edit in trunk/LayoutTests/editing/input/attributed-substring-from-range-lines-expected.txt

Land updated results.

1:49 PM Changeset in webkit [14387] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • followup to previous fix; I hadn't tested quitting adequately
  • WebView/WebHTMLView.m: (-[WebHTMLView dealloc]): call removeAllToolTips before clearing _private so that removeTrackingRect: override can work properly. Normally removeAllToolTips would be called by super, but that's too late. (-[WebHTMLView finalize]): ditto
1:25 PM Changeset in webkit [14386] by thatcher
  • 1 copy in tags/WebKit-418.4/WebKit

Tag for WebKit 418.4 (part 2 of 2.)

1:25 PM Changeset in webkit [14385] by thatcher
  • 1 add in tags/WebKit-418.4

Tag for WebKit 418.4 (part 1 of 2.)

1:25 PM Changeset in webkit [14384] by thatcher
  • 1 delete in tags/WebCore-418.4/WebCore/WebCore

Removing a bad tag.

1:23 PM Changeset in webkit [14383] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • fixed <rdar://problem/4503016> TOT assertion failure in -[WebHTMLView(WebPrivate) removeTrackingRect:]


We have some tricky code to deal with tracking rects, which succumbed to a fix in AppKit. Updated our
tricky code to work with the AppKit fix.

  • WebView/WebHTMLViewInternal.h: new instance variable lastToolTipTag


  • WebView/WebHTMLView.m: (-[WebHTMLView removeTrackingRect:]): handle removing lastToolTipTag by calling super (-[WebHTMLView _setToolTip:]): save tool tip tag in lastToolTipTag; this apparently used to always return 0, so we formerly had no way to distinguish it from the no-tool-tips-yet case.
  • WebKit.xcodeproj/project.pbxproj: Xcode removed some old cruft
12:15 PM Changeset in webkit [14382] by eseidel
  • 17 edits
    18 copies
    2 moves in trunk/WebCore

2006-05-15 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by eseidel.

Split render_form.* into separate files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8889

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
  • html/HTMLOptionElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::setAccessKey):
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQSlider.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderFieldset.cpp: Added. (WebCore::RenderFieldset::RenderFieldset): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFieldset.h: Added. (WebCore::RenderFieldset::renderName):
  • rendering/RenderFileButton.cpp: Added. (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::calcMinMaxWidth): (WebCore::RenderFileButton::updateFromElement): (WebCore::RenderFileButton::click):
  • rendering/RenderFileButton.h: Added. (WebCore::RenderFileButton::renderName): (WebCore::RenderFileButton::calcReplacedHeight): (WebCore::RenderFileButton::isEditable):
  • rendering/RenderFormElement.cpp: Added. (WebCore::RenderFormElement::RenderFormElement): (WebCore::RenderFormElement::baselinePosition): (WebCore::RenderFormElement::layout):
  • rendering/RenderFormElement.h: Added. (WebCore::RenderFormElement::renderName): (WebCore::RenderFormElement::isFormElement): (WebCore::RenderFormElement::borderTop): (WebCore::RenderFormElement::borderBottom): (WebCore::RenderFormElement::borderLeft): (WebCore::RenderFormElement::borderRight): (WebCore::RenderFormElement::paddingTop): (WebCore::RenderFormElement::paddingBottom): (WebCore::RenderFormElement::paddingLeft): (WebCore::RenderFormElement::paddingRight): (WebCore::RenderFormElement::canHaveIntrinsicMargins): (WebCore::RenderFormElement::intrinsicMargin): (WebCore::RenderFormElement::isEditable):
  • rendering/RenderImageButton.cpp: Added. (WebCore::RenderImageButton::RenderImageButton):
  • rendering/RenderImageButton.h: Added. (WebCore::RenderImageButton::renderName): (WebCore::RenderImageButton::isImageButton):
  • rendering/RenderLabel.cpp: Added. (WebCore::RenderLabel::RenderLabel):
  • rendering/RenderLabel.h: Added. (WebCore::RenderLabel::renderName):
  • rendering/RenderLegend.cpp: Added. (WebCore::RenderLegend::RenderLegend):
  • rendering/RenderLegend.h: Added. (WebCore::RenderLegend::renderName):
  • rendering/RenderLineEdit.cpp: Added. (WebCore::RenderLineEdit::RenderLineEdit):
  • rendering/RenderLineEdit.h: Added. (WebCore::RenderLineEdit::renderName): (WebCore::RenderLineEdit::calcReplacedHeight): (WebCore::RenderLineEdit::canHaveIntrinsicMargins): (WebCore::RenderLineEdit::isTextField): (WebCore::RenderLineEdit::isEditable):
  • rendering/RenderSelect.cpp: Added. (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderSelect::setStyle): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::baselinePosition): (WebCore::RenderSelect::calcMinMaxWidth): (WebCore::RenderSelect::layout): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::updateSelection):
  • rendering/RenderSelect.h: Added. (WebCore::RenderSelect::renderName): (WebCore::RenderSelect::calcReplacedHeight): (WebCore::RenderSelect::canHaveIntrinsicMargins): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::setSelectionChanged):
  • rendering/RenderSlider.cpp: Added. (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName): (WebCore::RenderSlider::canHaveIntrinsicMargins):
  • rendering/RenderTextArea.cpp: Added. (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderTextArea::setStyle): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::selectionStart): (WebCore::RenderTextArea::selectionEnd): (WebCore::RenderTextArea::setSelectionStart): (WebCore::RenderTextArea::setSelectionEnd): (WebCore::RenderTextArea::select): (WebCore::RenderTextArea::setSelectionRange):
  • rendering/RenderTextArea.h: Added. (WebCore::RenderTextArea::renderName): (WebCore::RenderTextArea::isTextArea): (WebCore::RenderTextArea::isEdited): (WebCore::RenderTextArea::canHaveIntrinsicMargins): (WebCore::RenderTextArea::isEditable):
  • rendering/render_form.cpp: Removed.
  • rendering/render_form.h: Removed.
12:10 PM Changeset in webkit [14381] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

12:08 PM Changeset in webkit [14380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

12:05 PM Changeset in webkit [14379] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.
11:17 AM Changeset in webkit [14378] by andersca
  • 10 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Eric.

Remove the XPath log calls. They were causing leaks and were never
really useful.


  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary):
  • platform/Logging.cpp:
  • platform/Logging.h:
  • xpath/XPathResult.cpp: (WebCore::XPathResult::convertTo):
  • xpath/impl/XPathFunctions.cpp: (round): (WebCore::XPath::FunCount::doEvaluate): (WebCore::XPath::FunSum::doEvaluate): (WebCore::XPath::FunctionLibrary::createFunction):
  • xpath/impl/XPathPath.cpp: (WebCore::XPath::Filter::doEvaluate): (WebCore::XPath::LocationPath::doEvaluate):
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::Negative::doEvaluate): (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::Union::doEvaluate):
  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeTestMatches):
  • xpath/impl/XPathValue.cpp: (WebCore::XPath::Value::toNodeVector):
10:14 AM Changeset in webkit [14377] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <​eseidel@apple.com>

Fix linux build.

  • html/HTMLBodyElement.cpp: Fix case of #include "cssstyleselector.h"
1:47 AM Changeset in webkit [14376] by andersca
  • 6 edits in trunk

WebCore:

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge canSaveAsWebArchive]):

WebKit:

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files

  • WebView/WebDocumentPrivate.h: Add canSaveAsWebArchive.


  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation canProvideDocumentSource]): Call the bridge.


(-[WebHTMLRepresentation canSaveAsWebArchive]):
New function. This will be used in Safari ToT to determine if a page can be saved as an archive.

1:03 AM Changeset in webkit [14375] by hyatt
  • 10 edits in trunk/WebCore

Remove the .forPrinter boolean from FontPlatformData. After the initial
acquisition of an NSFont, the font is then adjusted to printer or screen
when put into a FontPlatformData. Then it can simply be used in the hash
lookup to get a FontData.

Reviewed by mjs

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
  • platform/FontData.h:
  • platform/FontDescription.h: (WebCore::FontDescription::bold):
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::getSmallCapsFontData): (WebCore::setUpFont):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):

May 14, 2006:

11:59 PM Changeset in webkit [14374] by andersca
  • 2 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

9:57 PM Changeset in webkit [14373] by hyatt
  • 246 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update svg layout tests.

9:42 PM Changeset in webkit [14372] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/repaint/table-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-collapsed-border-expected.png: Added.
  • fast/repaint/table-collapsed-border-expected.txt: Added.
  • fast/repaint/table-collapsed-border.html: Added.

WebCore:

Reviewed by Hyatt.


This patch updates the implementation of collapsing borders to match
the current spec.

Test: fast/repaint/table-collapsed-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::layout): Calculate horizontal overflows. (WebCore::RenderTable::calcMinMaxWidth): Added call to recalcHorizontalBorders. (WebCore::RenderTable::colElement): Made const. (WebCore::RenderTable::calcBorderLeft): Calculates the left border. In the collapsing borders model, this is the left border of the leftmost cell of the first row. (WebCore::RenderTable::calcBorderRight): Ditto for the right border. (WebCore::RenderTable::recalcHorizontalBorders): Added. (WebCore::RenderTable::borderTop): Changed to return outerBorderTop in the collapsing case. (WebCore::RenderTable::borderBottom): Changed to return outerBorderBottom in the collapsing case. (WebCore::RenderTable::outerBorderTop): Added. Returns the table half of the top border, which is half the widest top border on the first row. (WebCore::RenderTable::outerBorderBottom): Added. Returns the table half of the bottom border, which is half the widest bottom border on the last row. (WebCore::RenderTable::outerBorderLeft): Added. Returns the table half of the left border, which is half the widest left border on the leftmost column. (WebCore::RenderTable::outerBorderRight): Added. Returns the table half of the right border, which is half the widest right border on the rightmost column. (WebCore::RenderTable::cellAbove): Return 0 if the cell is in the first row of the header. (WebCore::RenderTable::cellBelow): Return 0 if the cell is in the last row of the footer.
  • rendering/RenderTable.h: (WebCore::RenderTable::borderLeft): (WebCore::RenderTable::borderRight): (WebCore::RenderTable::overflowHeight):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::borderLeft): Removed unnecessary use of floats. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::paint): Account for the table half of the vertical borders. (WebCore::RenderTableCell::paintCollapsedBorder): Removed unnecessary use of floats.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added call to recalcOuterBorder. (WebCore::RenderTableSection::calcOuterBorderTop): Added. Calculates the outer half of the section's top border, which is half the widest top border on the first row. (WebCore::RenderTableSection::calcOuterBorderBottom): Ditto for the bottom border. (WebCore::RenderTableSection::calcOuterBorderLeft): Ditto for the left border. (WebCore::RenderTableSection::calcOuterBorderRight): Ditto for the right border. (WebCore::RenderTableSection::recalcOuterBorder): Added. (WebCore::RenderTableSection::paint): Account for the table half of the borders.
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::outerBorderTop): (WebCore::RenderTableSection::outerBorderBottom): (WebCore::RenderTableSection::outerBorderLeft): (WebCore::RenderTableSection::outerBorderRight):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout if a border style changed from 'hidden' to 'none' or vice versa in the collapsing borders model, since 'hidden' suppresses other borders.
9:37 PM Changeset in webkit [14371] by darin
  • 5 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/dom-manipulation-on-resize.html: Added.

WebKit:

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
9:33 PM Changeset in webkit [14370] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

  • fast/forms/file-input-disabled.html: Added.
  • fast/forms/file-input-disabled-expected.txt: Added.
  • fast/forms/file-input-disabled-expected.png: Added.
  • fast/forms/file-input-disabled-expected.checksum: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

Be sure to call setDisabled on the file button when in
RenderFileButton::updateFromElement.

  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton setEnabled:]): (KWQFileButton::setDisabled):
  • rendering/render_form.cpp: (WebCore::RenderFileButton::updateFromElement):
3:12 PM Changeset in webkit [14369] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.

  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::fontDataAt): (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
2:26 PM Changeset in webkit [14368] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

2:25 PM Changeset in webkit [14367] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

1:38 PM Changeset in webkit [14366] by hyatt
  • 100 edits
    8 adds in trunk

Bug 8895. Rework font substitution and fallback. Lift the concept of
substitution and fallback out of FontData and up into the FontFallbackList.
See the bug for details of issues fixed in the fallback code.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::primaryFont): (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontCache.h: Added.
  • platform/FontData.h: (WebCore::FontData::pitch): (WebCore::FontData::getNSFont): (WebCore::):
  • platform/FontFallbackList.cpp: Added. (WebCore::m_pitch): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::isFixedPitch): (WebCore::FontFallbackList::primaryFont):
  • platform/FontFamily.h:
  • platform/mac/FontCacheMac.mm: Added. (WebCore::FontCache::getFontData): (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::containsCharacters):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
9:39 AM Changeset in webkit [14365] by ap
  • 3 edits
    4 adds in trunk

2006-05-14 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8387>
"border-left/padding-Left do not show up on multiline rtl inline boxes"

Test: fast/inline/inline-borders-with-bidi-override.html: added

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
12:12 AM Changeset in webkit [14364] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix the Windows build the rest of the way

  • WebCore.vcproj/WebCore/WebCore.vcproj:

May 13, 2006:

9:52 PM Changeset in webkit [14363] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Update to new file paths

  • WebFramePrivate.cpp:
9:42 PM Changeset in webkit [14362] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Get FontWin.cpp compiling.
WebCore and JSCore now build, but Spinneret still gets link errors.

  • platform/win/FontWin.cpp: (WebCore::Font::offsetForPosition):
8:58 PM Changeset in webkit [14361] by sfalken
  • 4 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by maciej.

Fix Windows build except for fontwin.cpp.

  • WebCore/platform/win/FontWin.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
9:58 AM Changeset in webkit [14360] by ap
  • 3 edits in trunk/LayoutTests/fast/block/positioning/auto

Commit the remaining updated results for bug 7604.

9:47 AM Changeset in webkit [14359] by ap
  • 3 edits
    22 adds in trunk

2006-05-13 Kevin M. Ollivier <​kevino@theolliviers.com>

Reviewed by Darin, landed by ap.

JavaScriptCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • JavaScriptCoreSources.bkl: Added JavaScriptCore sources list for Bakefile.


  • jscore.bkl: Bakefile used to generate JavaScriptCore project files (currently only used by wx and gdk ports)

WebCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • move-js-headers.sh: Added script to copy JavaScriptCore includes into one dir so that Framework-style includes will work on all OSes. (written by Mike Emmel)


  • platform/wx: New dir, home for the wxWidgets port
  • platform/wx/wx-encodings.txt: Added temp. stub for wx encodings file.


  • Projects: New dir, for various project files for ports.


  • Projects/gdk: New dir, GDK port files.
  • Projects/webcore-gdk.bkl: Bakefile to generate GDK port project files


  • Projects/wx: New dir, wxWidgets port files.
  • Projects/webcore-wx.bkl: Bakefile to generate wxWidgets port project files

WebKitTools:

  • Scripts/install-unix-extras: Added.
  • Scripts/regenerate-makefiles: Added.
9:28 AM Changeset in webkit [14358] by ap
  • 3 edits
    4 adds in trunk

2006-05-13 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/text/midword-break-hang.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): If this is a mid-word break, ignore breakOnlyAfterWhiteSpace.
9:19 AM Changeset in webkit [14357] by ap
  • 2 edits in trunk/WebCore

Ok, now RenderBox.cpp actually compiles for me.

8:57 AM Changeset in webkit [14356] by ap
  • 2 edits in trunk/WebCore

Same fix for calcAbsoluteVerticalValues().

8:50 AM Changeset in webkit [14355] by ap
  • 2 edits in trunk/WebCore

Try to fix release build.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): Initialize leftValue. This value will never be used, because 'left' and 'right' cannot both be 'auto'.
8:28 AM Changeset in webkit [14354] by ap
  • 1 edit
    1 delete in trunk/WebCore/rendering

Re-applied the fix for bug 8835 (REGRESSION: Line moves but selection
highlight stays behind) to a correct file; removed the stale one.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
  • rendering/render_line.cpp: Removed.
8:12 AM Changeset in webkit [14353] by ap
  • 1 edit in trunk/WebCore/ChangeLog

Corrected a path in ChangeLog.

8:11 AM Changeset in webkit [14352] by ap
  • 6 edits
    4 adds in trunk

2006-05-13 Rob Buis <​buis@kde.org>

Reviewed by Darin, landed by ap.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8132
CSS parser sometimes accepts real number as integer

Add a boolean variable per css value to catch whether values
are specified as floats or integers.

Test: fast/css/rgb-float.html

  • css/CSSGrammar.y:
  • css/cssparser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::lex):
  • css/cssparser.h:
  • css/tokenizer.flex:
7:58 AM Changeset in webkit [14351] by ap
  • 7 edits
    8 adds in trunk

2006-05-13 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

WebCore:

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7604
calcAbsoluteHorizontalValues() is being getting passed arguments
in the wrong order in calcAbsoluteHorizontal()

Cleans up the RenderBox code for absolutely positioned elements
and adds new functions for replaced absolutely positioned
elements. Now uses Length so that magic number -666666 for
auto lengths is no longer used.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Handle replaced case separately. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto.
  • rendering/RenderBox.h:

LayoutTests:

  • fast/block/positioning/absolute-length-of-neg-666666.html: Added.
  • fast/block/positioning/absolute-positioned-overconstrained.html: Added.
  • fast/block/positioning/auto/006.html: Updated to reflect that the containing block's direction, not the parent's is used.
  • fast/css/absolute-poition-in-rtl-parent.html: Updated and cleaned up.

May 12, 2006:

11:41 PM Changeset in webkit [14350] by hyatt
  • 7 edits in trunk/WebCore

Bug 8880, remove the remaining drawing/hit testing code from
FontData.

Reviewed by tim h

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advanceOneCharacter): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::makeComplete):
  • platform/FontData.h:
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
8:26 PM Changeset in webkit [14349] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Maciej.

8:26 PM Changeset in webkit [14348] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Add missing include.


  • dom/Node.h: Add missing include for DeprecatedString.
8:24 PM Changeset in webkit [14347] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/selection-highlight-adjust-expected.checksum: Added.
  • fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • fast/dynamic/selection-highlight-adjust-expected.txt: Added.
  • fast/dynamic/selection-highlight-adjust.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/selection-highlight-adjust.html

  • rendering/render_line.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
7:44 PM Changeset in webkit [14346] by thatcher
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7156
Bug 7156: TinyMCE: Links are actually activated in editable area, not editable.


Links in editable areas will not activate or perform a navigation
change (on par with WinIE and Firefox.) To visit the link
you can shift-click. Manual test added.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLAnchorElement.h:
  • manual-tests/contenteditable-link.html: Added.
  • page/FrameView.cpp: (WebCore::selectCursor):
6:36 PM Changeset in webkit [14345] by eseidel
  • 10 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Split out html_inlineimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • editing/CreateLinkCommand.cpp:
  • editing/UnlinkCommand.cpp:
  • html/HTMLAnchorElement.cpp: Added. (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLAnchorElement.h: Added.
  • html/HTMLBRElement.cpp: Added.
  • html/HTMLBRElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLFontElement.cpp: Added. (WebCore::HTMLFontElement::HTMLFontElement): (WebCore::HTMLFontElement::setColor): (WebCore::HTMLFontElement::setFace): (WebCore::HTMLFontElement::setSize):
  • html/HTMLFontElement.h: Added.
  • html/HTMLModElement.cpp: Added. (WebCore::HTMLModElement::setCite): (WebCore::HTMLModElement::setDateTime):
  • html/HTMLModElement.h: Added.
  • html/HTMLQuoteElement.cpp: Added.
  • html/HTMLQuoteElement.h: Added.
  • html/html_imageimpl.h:
  • html/html_inlineimpl.cpp: Removed.
  • html/html_inlineimpl.h: Removed.
  • page/FrameView.cpp:
5:57 PM Changeset in webkit [14344] by eseidel
  • 3 edits in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Fix build error.

  • rendering/InlineFlowBox.cpp:
  • rendering/RootInlineBox.cpp:
5:54 PM Changeset in webkit [14343] by eseidel
  • 7 edits
    8 copies
    1 move in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split out render_line.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:
  • rendering/EllipsisBox.cpp: Added.
  • rendering/EllipsisBox.h: Added. (WebCore::EllipsisBox::EllipsisBox):
  • rendering/InlineBox.cpp: Added.
  • rendering/InlineBox.h: Added. (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::~InlineBox): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::rightOverflow):
  • rendering/InlineFlowBox.cpp: Added. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/InlineFlowBox.h: Added.
  • rendering/InlineRunBox.h: Added. (WebCore::InlineRunBox::InlineRunBox): (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RootInlineBox.cpp: Added.
  • rendering/RootInlineBox.h: Added. (WebCore::RootInlineBox::RootInlineBox):
  • rendering/render_line.h: Removed.
4:50 PM Changeset in webkit [14342] by eseidel
  • 1 edit
    1 delete in trunk/WebCore

spelling fix

4:44 PM Changeset in webkit [14341] by eseidel
  • 3 edits
    4 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Split out table_layout.* into separate files (one per class).
Search replace instnace variables "foo" with "m_foo" to comply with modern style.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/AutoTableLayout.cpp: Added. (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
  • rendering/AutoTableLayout.h: Added. (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/FixedTableLayout.cpp: Added. (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
  • rendering/FixedTableLayout.h: Added.
  • rendering/RenderTable.cpp:
  • rendering/TableLayout.h: Added. (WebCore::TableLayout::TableLayout):
  • rendering/table_layout.cpp: Removed.
  • rendering/table_layout.h: Removed.
4:39 PM Changeset in webkit [14340] by thatcher
  • 1 copy in tags/WebCore-418.5/WebCore

Tag for WebCore 418.5 (part 2 of 2.)

4:39 PM Changeset in webkit [14339] by thatcher
  • 1 add in tags/WebCore-418.5

Tag for WebCore 418.5 (part 1 of 2.)

4:39 PM Changeset in webkit [14338] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:28 PM Changeset in webkit [14337] by hyatt
  • 15 edits in trunk/WebCore

Bug 8877. Change form controls and the bridge entry points from the
Safari UI to use Font instead of FontData.

Reviewed by mjs

  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]): (+[WebCoreStringTruncator clear]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (QListBox::clearCachedTextRenderers): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h: (WebCore::TextStyle::disableRoundingHacks): (WebCore::TextStyle::setRTL):
  • platform/FontData.h:
  • platform/FontFallbackList.h:
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/Pen.h:
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteRenderer):
  • platform/mac/FontMac.mm: (WebCore::FontFallbackList::setPlatformFont): (WebCore::m_wordSpacing): (WebCore::Font::drawComplexText):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • platform/win/FontWin.cpp: (WebCore::Font::drawText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset):
4:14 PM Changeset in webkit [14336] by eseidel
  • 14 edits
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by kevin.

Move render_button to RenderButton.
Various small style cleanup.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • platform/mac/WebCoreTextArea.mm:
  • rendering/RenderApplet.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderButton.cpp: Added. (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::addChild): (WebCore::RenderButton::removeChild):
  • rendering/RenderButton.h: Added.
  • rendering/RenderEmptyApplet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/render_button.cpp: Removed.
  • rendering/render_button.h: Removed.
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout):
  • rendering/table_layout.h: (WebCore::TableLayout::TableLayout): (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
4:08 PM Changeset in webkit [14335] by bdakin
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0 branch. Fixes <rdar://problem/
4536941> Branch regression: : Random crash occurs when navigating
site at ​http://abcnews.go.com/ (KHTMLParser::popOneBlock(bool) +
56)

2006-01-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
3:56 PM Changeset in webkit [14334] by eseidel
  • 17 edits
    18 copies
    6 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Split render_frames.* render_replaced.* and html_baseimpl.* into separate files (one class per file).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8878

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getValueProperty): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::formIndexGetter): (KJS::JSHTMLElement::formNameGetter): (KJS::JSHTMLElement::selectIndexGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::runtimeObjectGetter): (KJS::JSHTMLElement::runtimeObjectPropertyGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::implementsCall): (KJS::JSHTMLElement::callAsFunction): (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::toString): (KJS::getForm): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLElement::putValueProperty): (KJS::toHTMLElement): (KJS::toHTMLTableCaptionElement): (KJS::toHTMLTableSectionElement): (KJS::JSHTMLCollection::lengthGetter): (KJS::JSHTMLCollection::indexGetter): (KJS::JSHTMLCollection::nameGetter): (KJS::JSHTMLCollection::getOwnPropertySlot): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::JSHTMLSelectCollection::selectedIndexGetter): (KJS::JSHTMLSelectCollection::put): (KJS::OptionConstructorImp::construct): (KJS::getSelectHTMLCollection):
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
  • dom/Document.cpp: (WebCore::widgetForNode):
  • html/HTMLBodyElement.cpp: Added. (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLBodyElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElement.cpp: Added. (WebCore::HTMLFrameElement::isURLAllowed): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::setLocation):
  • html/HTMLFrameElement.h: Added.
  • html/HTMLFrameSetElement.cpp: Added. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): (WebCore::HTMLFrameSetElement::defaultEventHandler): (WebCore::HTMLFrameSetElement::recalcStyle):
  • html/HTMLFrameSetElement.h: Added.
  • html/HTMLHeadElement.cpp: Added. (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHeadElement.h: Added.
  • html/HTMLHtmlElement.cpp: Added. (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLHtmlElement.h: Added.
  • html/HTMLIFrameElement.cpp: Added. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_baseimpl.cpp: Removed.
  • html/html_baseimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement): (WebCore::Frame::selectionRect): (WebCore::Frame::isFrameSet): (WebCore::scanForForm): (WebCore::Frame::currentForm): (WebCore::Frame::nodeInfoAtPoint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::frameForWidget): (WebCore::Frame::forceLayoutWithPageWidthRange): (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/FrameView.cpp:
  • rendering/RenderFrame.cpp: Added. (WebCore::RenderFrame::viewCleared):
  • rendering/RenderFrame.h: Added.
  • rendering/RenderFrameSet.cpp: Added. (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::~RenderFrameSet): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::canResize): (WebCore::RenderFrameSet::dump):
  • rendering/RenderFrameSet.h: Added.
  • rendering/RenderImage.h:
  • rendering/RenderPart.cpp: Added. (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h: Added.
  • rendering/RenderPartObject.cpp: Added. (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderPartObject.h: Added.
  • rendering/RenderReplaced.cpp: Added. (WebCore::RenderReplaced::selectionColor):
  • rendering/RenderReplaced.h: Added.
  • rendering/RenderWidget.cpp: Added. (WebCore::RenderWidget::deleteWidget):
  • rendering/RenderWidget.h: Added.
  • rendering/render_form.h:
  • rendering/render_frames.cpp: Removed.
  • rendering/render_frames.h: Removed.
  • rendering/render_replaced.cpp: Removed.
  • rendering/render_replaced.h: Removed.
3:21 PM Changeset in webkit [14333] by mjs
  • 19 edits
    1 add in trunk/WebKit

Reviewed by Brady.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=8876

  • move most private WebDataSource methods to uninstalled header


I put the declarations for the ones only used in WebKit in WebDataSourceInternal.h
and removed two entirey unused ones.

  • Plugins/WebNetscapePluginRepresentation.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebPluginController.m:
  • Plugins/WebPluginDocumentView.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge dataSource]):
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _clearErrors]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]):
  • WebView/WebDataSourceInternal.h: Added.
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebRenderNode.m:
  • WebView/WebView.m:
1:44 PM Changeset in webkit [14332] by eseidel
  • 15 edits
    10 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split html_headimpl.* into separate files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8875

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::headGetter): (KJS::JSHTMLElement::linkGetter):
  • bindings/objc/DOMCSS.mm: (+[DOMCounter _counterWith:]): (-[DOMCounter finalize]): (-[DOMCounter _DOMStyleSheet]): (-[DOMStyleSheet _initWithStyleSheet:]): (-[DOMStyleSheetList dealloc]): (-[DOMStyleSheetList finalize]): (-[DOMStyleSheetList _styleSheetList]): (-[DOMStyleSheetList _initWithStyleSheetList:]): (-[DOMCSSStyleSheet _CSSStyleSheet]): (-[DOMMediaList dealloc]): (-[DOMMediaList finalize]): (-[DOMMediaList _mediaList]): (-[DOMMediaList _initWithMediaList:]): (-[DOMCSSRuleList dealloc]): (-[DOMCSSRuleList finalize]): (-[DOMCSSRuleList _ruleList]): (-[DOMCSSRuleList _initWithRuleList:]): (-[DOMCSSRule dealloc]): (-[DOMCSSRule finalize]): (-[DOMCSSRule _rule]): (-[DOMCSSRule _initWithRule:]): (-[DOMCSSStyleRule _styleRule]): (-[DOMCSSMediaRule _mediaRule]): (-[DOMCSSFontFaceRule _fontFaceRule]): (-[DOMCSSPageRule _pageRule]): (-[DOMCSSImportRule _importRule]): (-[DOMCSSCharsetRule _importRule]): (-[DOMCSSStyleDeclaration dealloc]): (-[DOMCSSStyleDeclaration finalize]): (-[DOMCSSStyleDeclaration _initWithStyleDeclaration:]): (-[DOMCSSStyleDeclaration _styleDeclaration]): (-[DOMCSSValue dealloc]): (-[DOMCSSValue finalize]): (-[DOMCSSValue _value]): (-[DOMCSSValue _initWithValue:]): (-[DOMCSSPrimitiveValue _primitiveValue]): (-[DOMCSSValueList _valueList]): (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor _initWithRGB:]): (-[DOMRect dealloc]): (-[DOMRect finalize]): (-[DOMRect _rect]): (-[DOMRect _initWithRect:]): (-[DOMCounter dealloc]): (-[DOMCounter _counter]): (-[DOMCounter _initWithCounter:]): (-[DOMObject sheet]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLCollection dealloc]): (-[DOMHTMLCollection finalize]): (-[DOMHTMLCollection _collection]): (-[DOMHTMLCollection _initWithCollection:]): (-[DOMHTMLOptionsCollection dealloc]): (-[DOMHTMLOptionsCollection finalize]): (-[DOMHTMLOptionsCollection _initWithOptionsCollection:]): (-[DOMHTMLOptionsCollection _optionsCollection]): (+[DOMHTMLElement _elementWith:]): (-[DOMHTMLElement _HTMLElement]): (-[DOMHTMLDocument _HTMLDocument]): (-[DOMHTMLHtmlElement _HTMLHtmlElement]): (-[DOMHTMLHeadElement _headElement]): (-[DOMHTMLLinkElement _linkElement]): (-[DOMHTMLTitleElement _titleElement]): (-[DOMHTMLMetaElement _metaElement]): (-[DOMHTMLBaseElement _baseElement]): (-[DOMHTMLStyleElement _styleElement]): (-[DOMHTMLBodyElement _bodyElement]): (-[DOMHTMLFormElement _formElement]): (+[DOMHTMLFormElement _formElementWith:]): (-[DOMHTMLIsIndexElement _isIndexElement]): (-[DOMHTMLSelectElement _selectElement]): (-[DOMHTMLOptGroupElement _optGroupElement]): (-[DOMHTMLOptionElement _optionElement]): (-[DOMHTMLInputElement _inputElement]): (-[DOMHTMLTextAreaElement _textAreaElement]): (-[DOMHTMLButtonElement _buttonElement]): (-[DOMHTMLLabelElement _labelElement]): (-[DOMHTMLLabelElement form]): (-[DOMHTMLFieldSetElement _fieldSetElement]): (-[DOMHTMLLegendElement _legendElement]): (-[DOMHTMLUListElement _uListElement]): (-[DOMHTMLOListElement _oListElement]): (-[DOMHTMLDListElement _dListElement]): (-[DOMHTMLDirectoryElement _directoryListElement]): (-[DOMHTMLMenuElement _menuListElement]): (-[DOMHTMLLIElement _liElement]): (-[DOMHTMLQuoteElement _quoteElement]): (-[DOMHTMLDivElement _divElement]): (-[DOMHTMLParagraphElement _paragraphElement]): (-[DOMHTMLHeadingElement _headingElement]): (-[DOMHTMLPreElement _preElement]): (-[DOMHTMLBRElement _BRElement]): (-[DOMHTMLBaseFontElement _baseFontElement]): (-[DOMHTMLFontElement _fontElement]): (-[DOMHTMLHRElement _HRElement]): (-[DOMHTMLModElement _modElement]): (-[DOMHTMLAnchorElement _anchorElement]): (-[DOMHTMLImageElement _imageElement]): (-[DOMHTMLObjectElement _objectElement]): (-[DOMHTMLParamElement _paramElement]): (-[DOMHTMLMapElement _mapElement]): (-[DOMHTMLAreaElement _areaElement]): (-[DOMHTMLScriptElement _scriptElement]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (-[DOMHTMLTableElement createTHead]): (-[DOMHTMLTableElement createTFoot]): (-[DOMHTMLTableElement createCaption]): (-[DOMHTMLTableElement insertRow:]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (-[DOMHTMLTableColElement _tableColElement]): (-[DOMHTMLTableRowElement _tableRowElement]): (-[DOMHTMLTableRowElement insertCell:]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]): (-[DOMHTMLFrameSetElement _frameSetElement]): (-[DOMHTMLFrameElement _frameElement]): (-[DOMHTMLIFrameElement _IFrameElement]): (-[DOMHTMLEmbedElement _embedElement]): (viewForElement):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::passWheelEventToChildWidget): (WebCore::FrameMac::fileWrapperForElement): (WebCore::listParent): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::shouldBeginEditing): (WebCore::FrameMac::shouldEndEditing): (WebCore::FrameMac::setMarkedTextRange):
  • dom/Document.cpp:
  • dom/xml_tokenizer.cpp:
  • html/HTMLBaseElement.cpp: Added. (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • html/HTMLBaseElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLLinkElement.cpp: Added. (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: Added.
  • html/HTMLMetaElement.cpp: Added. (WebCore::HTMLMetaElement::HTMLMetaElement): (WebCore::HTMLMetaElement::parseMappedAttribute): (WebCore::HTMLMetaElement::process): (WebCore::HTMLMetaElement::setContent): (WebCore::HTMLMetaElement::setHttpEquiv): (WebCore::HTMLMetaElement::setName):
  • html/HTMLMetaElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLScriptElement.cpp: Added. (WebCore::HTMLScriptElement::HTMLScriptElement): (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLScriptElement.h: Added.
  • html/HTMLStyleElement.cpp: Added. (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h: Added.
  • html/HTMLTitleElement.cpp: Added. (WebCore::HTMLTitleElement::HTMLTitleElement): (WebCore::HTMLTitleElement::text): (WebCore::HTMLTitleElement::setText):
  • html/HTMLTitleElement.h: Added.
  • html/html_headimpl.cpp: Removed.
  • html/html_headimpl.h: Removed.
  • loader/CachedCSSStyleSheet.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
12:44 PM Changeset in webkit [14331] by eseidel
  • 2 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split out html_tableimpl.* into multiple files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8873

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTableCaptionElement.cpp: Added. (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
  • html/HTMLTableCaptionElement.h: Added.
  • html/HTMLTableCellElement.cpp: Added. (WebCore::HTMLTableCellElement::HTMLTableCellElement):
  • html/HTMLTableCellElement.h: Added.
  • html/HTMLTableColElement.cpp: Added. (WebCore::HTMLTableColElement::HTMLTableColElement): (WebCore::HTMLTableColElement::endTagRequirement): (WebCore::HTMLTableColElement::tagPriority): (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableColElement.h: Added.
  • html/HTMLTableElement.cpp: Added. (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: Added.
  • html/HTMLTablePartElement.cpp: Added. (WebCore::HTMLTablePartElement::parseMappedAttribute):
  • html/HTMLTablePartElement.h: Added.
  • html/HTMLTableRowElement.cpp: Added. (WebCore::HTMLTableRowElement::HTMLTableRowElement): (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableRowElement.h: Added.
  • html/HTMLTableSectionElement.cpp: Added. (WebCore::HTMLTableSectionElement::insertRow):
  • html/HTMLTableSectionElement.h: Added.
  • html/html_tableimpl.cpp: Removed.
  • html/html_tableimpl.h: Removed.
11:51 AM Changeset in webkit [14330] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

11:51 AM Changeset in webkit [14329] by thatcher
  • 1 add in tags/WebCore-418.4

Tag for WebCore 418.4 (part 1 of 2.)

11:51 AM Changeset in webkit [14328] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:14 AM Changeset in webkit [14327] by eseidel
  • 11 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-10 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs & adele.

Split html_objectimpl.* into multiple files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8836

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp:
  • html/HTMLAppletElement.cpp: Added.
  • html/HTMLAppletElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp: Added. (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLEmbedElement.h: Added.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem):
  • html/HTMLObjectElement.cpp: Added. (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::updateDocNamedItem):
  • html/HTMLObjectElement.h: Added.
  • html/HTMLParamElement.cpp: Added.
  • html/HTMLParamElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPlugInElement.cpp: Added.
  • html/HTMLPlugInElement.h: Added.
  • html/html_objectimpl.cpp: Removed.
  • html/html_objectimpl.h: Removed.
  • page/Frame.cpp: (WebCore::Frame::handleFallbackContent):
  • rendering/RenderApplet.cpp:
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
10:53 AM Changeset in webkit [14326] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-12 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
10:40 AM Changeset in webkit [14325] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
9:49 AM Changeset in webkit [14324] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Added a null check.
  • manual-tests/context-click-generated-content.html: Added.
9:45 AM Changeset in webkit [14323] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Move caret to the right side of the rect when the offset is non-zero, rather than expanding it.
  • manual-tests/caret-image.html: Added.
5:35 AM Changeset in webkit [14322] by andersca
  • 3 edits
    4 adds in trunk

WebCore:

2006-05-12 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Test: fast/text/international/rtl-caret.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset): Added missing m_toAdd argument.

LayoutTests:

2006-05-12 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


  • fast/text/international/rtl-caret-expected.checksum: Added.
  • fast/text/international/rtl-caret-expected.png: Added.
  • fast/text/international/rtl-caret-expected.txt: Added.
  • fast/text/international/rtl-caret.html: Added.
2:22 AM Changeset in webkit [14321] by hyatt
  • 10 edits in trunk/WebCore

Bug 8864. Lift WebCoreTextStyle up into the API (as TextStyle).

Reviewed by mjs

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextStyle::m_attemptFontSubstitution): (WebCore::TextStyle::tabWidth): (WebCore::TextStyle::xPos): (WebCore::TextStyle::padding): (WebCore::TextStyle::rtl): (WebCore::TextStyle::ltr): (WebCore::TextStyle::directionalOverride): (WebCore::TextStyle::applyRunRounding): (WebCore::TextStyle::applyWordRounding): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::Font::operator==):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPosition):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):

May 11, 2006:

9:51 PM Changeset in webkit [14320] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/loader/url-strip-cr-lf-tab.html

  • platform/KURL.cpp: (appendEscapingBadChars): Strip CR, LF and TAB, as Firefox and IE do.
9:43 PM Changeset in webkit [14319] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 8856: Web Inspector should show the Xpath for the selected node
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8856


Adds an Xpath area to the Node panel.

5:23 PM Changeset in webkit [14318] by hyatt
  • 10 edits in trunk/WebCore

Remove the misspelling drawing code from Font and FontData. Implement it
natively in GraphicContext instead.

Reviewed by maciej

  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/win/FontWin.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingMarker):
5:04 PM Changeset in webkit [14317] by hyatt
  • 12 edits in trunk/WebCore

Remove drawLineForText from the Font API. Implement it natively in
the two GraphicsContexts (CG and Cairo) instead.

Reviewed by maciej

  • platform/Font.h:
  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations):
4:57 PM Changeset in webkit [14316] by bdakin
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4539954> 10.4.7 regression:DHTML menu
closes prematurely when hovering over it at ​http://
www.shopping.hp.com/

This fix already exists on TOT, though I am not sure when it was
checked in, nor am I aure what in particular caused this regression
on the branch. Whatever the cause of the badness, though, we need
to take borderTopExtra() and borderBottomExtra() into consideration
when hitTesting the background of a RenderBlock.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):
4:55 PM Changeset in webkit [14315] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix last fix.

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName):
4:31 PM Changeset in webkit [14314] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix crash on static constructors builds at exit due to qualified name default constructor not
initializing m_impl.

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref):
4:24 PM Changeset in webkit [14313] by hyatt
  • 4 edits in trunk/WebCore

Reviewed by hyatt

Already covered by several tests in fast/text

  • platform/Font.h: (WebCore::TextRun::TextRun): Added length parameter.
  • rendering/InlineTextBox.cpp: Pass the length to the TextRun constructor. (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Pass length and from instead of from and to to the TextRun constructor. (WebCore::RenderText::width): Ditto.
3:45 PM Changeset in webkit [14312] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.


<rdar://problem/4543847> 10.4.7 regression: Mail: selecting the bottom of a message and deleting it leaves a stray newline


Merged most of the DeleteSelectionCommand parts of r14143.

  • khtml/editing/htmlediting.cpp: (DeleteSelectionCommand::initializePositionData): Removed erroneous check that disabled merging based on paragraph boundaries.


(DeleteSelectionCommand::mergeParagraphs):
Return early if upstreamStart and downstreamEnd are flipped, or startblock == endblock.

3:31 PM Changeset in webkit [14311] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression from the TextRun landing. Delete the characters in
the adjustedRun, not the ones in the original run!

Reviewed by beth

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText):
3:21 PM Changeset in webkit [14310] by justing
  • 18 edits in trunk

LayoutTests:

Reviewed by thatcher, levi


Inserting an <hr> into <div>foobar</div> now produces
<div>foo</div><hr><div>bar</div>, instead of <div>foo<hr>bar</div>,
which means that removing an inserted <hr> programmatically from
javascript produces a different visual result than before (the
new result is arguably more correct):

  • editing/execCommand/insertHorizontalRule.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:


Equivalent render trees or changes in the editing delegate
notifications that reflect the fact that we are doing an end
merge more often:

  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher, levi

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed a use fragment.hasMoreThanOneBlock to decide if the paragraph containing the position pasted into must be split to avoid block nesting. We now split unnecessarily some times, but the end merge cleans up for us.
3:20 PM Changeset in webkit [14309] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

More 8060 layout test fun.

3:18 PM Changeset in webkit [14308] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla/bugs

More 8060 layout test fun.

3:03 PM Changeset in webkit [14307] by hyatt
  • 3 edits in trunk/LayoutTests/fast/text/international

Fix bidi line break layout test to account for bug 8060.

3:02 PM Changeset in webkit [14306] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/margin-collapse

Fix margin-collapsing layout test to account for bug 8060.

3:01 PM Changeset in webkit [14305] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/float

Fix float layout test to account for bug 8060.

2:56 PM Changeset in webkit [14304] by hyatt
  • 11 edits in trunk/WebCore

This patch makes drawHighlightForText a completely cross-platform method
implemented by the GraphicsContext. The platform-specific implementations
of the method in the Font class have been eliminated.

Reviewed by andersca

  • platform/Font.h:
  • platform/FontData.h: Remove the drawHighlight methods. Change the selectionRect method in Font to return a FloatRect so that the GraphicsContext can do an accurate fill.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawHighlightForText): Implement the drawHighlightFunction in terms of the cross-platform Font selectionRect functions and a new float-based fillRect graphics context function.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): Add the new float-based fillRect function for Cairo and CG.
  • platform/mac/FontData.mm: (WebCore::CG_draw): (WebCore::ATSU_draw): Removed the CG and ATSU drawHighlight methods. Remove the drawing of the background from the deprecated draw methods (they'll be removed soon).
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText):
  • platform/win/FontWin.cpp: (WebCore::Font::selectionRectForText): Change selectionRectForText to return a FloatRect instead of an IntRect, so that the GraphicsContext can do a precise fill.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::positionForOffset): Modify the callers who expect an int-based selection rect so that they call enclosingIntRect.
12:05 PM Changeset in webkit [14303] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Anders.

Fixes <rdar://problem/4411845> lots of SPOD trying to scroll through
Markup & Content inspecting body at apple.com (6614)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6614

Removed the Markup & Content pane when viewing a element.
This pane was not that useful and made the inspector really slow
when the markup was large. Only show this pane for text nodes.

11:34 AM Changeset in webkit [14302] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

Patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8810>
Bug 8810: Scrollbars in WebInspector rendered incorrectly

  • WebInspector/webInspector/inspector.css: Make scroll bars absolutely positioned.
10:47 AM Changeset in webkit [14301] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/double-focus-expected.txt: Added.
  • fast/forms/double-focus.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/double-focus.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Changed to only call setFocusNode, select, and revealSelection if the element is not already focused. Also changed to use return a bit more rather than else.
10:44 AM Changeset in webkit [14300] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/Misc.subproj/WebNSWindowExtras.m

Build fix.

10:23 AM Changeset in webkit [14299] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher (earlier version).

  • bindings/scripts/IDLParser.pm: Invoke the preprocessor via the "gcc" driver script, passing "-E" so we only preprocess, "-P" so we don't get "#line" directives, and "-x c++" so we handle both C and C++ comments. Removed the code to eliminate comments since the preprocessor handles that.
  • css/make-css-file-arrays.pl: This already invoked the preprocessor, but updated it to do the same way as above.
4:38 AM Changeset in webkit [14298] by andersca
  • 14 edits
    3 adds in trunk

WebCore:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new generated files.


  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Specify the KJS namespace for JSHTMLElmement.


  • bindings/js/kjs_dom.cpp: (KJS::toJS): Create a WebCore::JSHTMLDocument for document nodes. Also, create JSDocumentFragments for document fragments (instead of plain node objects).


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLDocument::getOwnPropertySlot): Add a prototype for JSHTMLDocument and move all functions there.


(KJS::JSHTMLElement::JSHTMLElement):
(KJS::JSHTMLElement::getOwnPropertySlot):
Update since JSHTMLElement now inherits from WebCore::JSHTMLElement.


(KJS::JSHTMLElement::getValueProperty):
(KJS::JSHTMLElement::putValueProperty):
Remove title setter and getter. Those are autogenerated now.


  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Inherit from WebCore::JSHTMLElement. Clarify the inheritance chain.


  • bindings/scripts/CodeGeneratorJS.pm: Always generate a prototype object, regardless of whether the object has any functions or constants.


Use the type of generator attributes to determine what constructor to use. This is useful for
the XMLDocument property in DOMWindow.idl, since that's just an alias for the Document constructor.


  • dom/DocumentFragment.idl: Added.
  • html/HTMLDocument.idl: Added.
  • html/HTMLElement.idl: Added.


  • page/DOMWindow.idl: Add constructors for DocumentFragment, HTMLElement, HTMLDocument and XMLDocument. XMLDocument is just an alias for the Document constructor.


LayoutTests:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object

  • fast/dom/prototype-chain-expected.txt: Update prototype chains.
  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html: Test new constructor objects.
3:19 AM Changeset in webkit [14297] by hyatt
  • 16 edits in trunk/WebCore

Bug 8845. Define a TextRun (similar to the old WebCoreTextRun) and
make it the new API for Font and GraphicsContext when drawing/measuring
text.

Reviewed by andersca

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::width): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_to): (WebCore::TextRun::operator[]): (WebCore::TextRun::data): (WebCore::TextRun::adjustFrom): (WebCore::TextRun::adjustTo): (WebCore::TextRun::characters): (WebCore::TextRun::length): (WebCore::TextRun::from): (WebCore::TextRun::to):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):

May 10, 2006:

10:32 PM Changeset in webkit [14296] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-10 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc.subproj/WebNSWindowExtras.h:
  • Misc.subproj/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
7:52 PM Changeset in webkit [14295] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Fixed my incorrect wording.

6:26 PM Changeset in webkit [14294] by justing
  • 16 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

Fixed a select-after-replacement problem:

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • editing/pasteboard/drag-drop-modifies-page-expected.png:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:


The trailing interchange newline used to be lost:

  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-016-expected.checksum:
  • editing/pasteboard/paste-text-016-expected.png:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-017-expected.txt:


Illustrates the bug fixed in smart replace whitespace handling:

  • editing/pasteboard/smart-paste-008.html
  • editing/pasteboard/smart-paste-008-expected.txt
  • editing/pasteboard/smart-paste-008-expected.png
  • editing/pasteboard/smart-paste-008-expected.checksum

WebCore:

Reviewed by darin

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed the code to find out if we must later add smart replace whitespace. We can wait until we've done the insertion to figure it out, and the position sampled (startPos) to make the decision about trailing whitespace was wrong. Changed the order that work is done during a paste: 1) Insert everything 2) Do one of the following: a) handle a trailing interchange newline, b) uncollapse the last incoming br if it has been collapsed because of quirks mode, c) do an end merge 3) Add smart replace whitespace (2 and 3 were reversed because the end merge must happen before we can know whether or not we need to add a trailing space). Don't do an end merge if the last node inserted was a br because the end merge will clobber it.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded):
brs that are at the end of a block and not at the start of a block are not the one brs
that are collapsed because of quirks mode.

6:04 PM Changeset in webkit [14293] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
2:08 PM Changeset in webkit [14292] by hyatt
  • 5 edits in trunk/WebCore

Rename isSpace to treatAsSpace. Move it and the rounding hack function into
Font and make them static methods (inlined in the header). Make the rounding
hack character table a static member as well. Remove the redundant space/rounding
functions from FontData.mm.

Reviewed by darin

  • platform/Font.cpp: (WebCore::): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance):
  • platform/Font.h: (WebCore::Font::treatAsSpace): (WebCore::Font::isRoundingHackCharacter):
  • platform/mac/FontData.mm: (WebCore::overrideLayoutOperation): (WebCore::createATSULayoutParameters): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
1:49 PM Changeset in webkit [14291] by darin
  • 1 edit
    1 delete in trunk/WebCore
  • WebCore: Removed an extra WebCore subtree that somehow got checked in.
1:27 PM Changeset in webkit [14290] by hyatt
  • 1 edit in trunk/WebCore/platform/Font.cpp

Fix typo from the removal of the inline keyword from some functions.

11:59 AM Changeset in webkit [14289] by thatcher
  • 1 copy in tags/WebCore-418.3/WebCore

Tag for WebCore 418.3 (part 2 of 2.)

11:59 AM Changeset in webkit [14288] by thatcher
  • 1 add in tags/WebCore-418.3

Tag for WebCore 418.3 (part 1 of 2.)

11:55 AM Changeset in webkit [14287] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

11:09 AM Changeset in webkit [14286] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Darin, landed by Timothy.

  • platform/Font.cpp: (WebCore::isSpace):
  • platform/mac/FontData.mm: (WebCore::widthForGlyph): (WebCore::isRoundingHackCharacter): (WebCore::glyphForCharacter):
10:28 AM Changeset in webkit [14285] by ap
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Anders.

The problem itself was fixed by Anders in bug 8808 (WebCore should handle text files).

  • http/tests/misc/resources: Added.
  • http/tests/misc/resources/200.html: Added.
  • http/tests/misc/resources/text-refresh.pl: Added.
  • http/tests/misc/text-refresh-expected.txt: Added.
  • http/tests/misc/text-refresh.html: Added.
8:11 AM Changeset in webkit [14284] by andersca
  • 2 edits in trunk/WebCore

2006-05-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

Already covered by several pixel tests in fast/text

  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
1:49 AM Changeset in webkit [14283] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Fix for bug 8809, lift the Mac-specific WebTextRenderer code for
drawing and measuring of runs up into the Font class. The fast code
path is in Font.cpp and is designed to be mostly cross-platform. The
slow code path is in FontMac.cpp and is Mac-specific.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::isSpace): (WebCore::): (WebCore::isRoundingHackCharacter): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::primaryFont): (WebCore::Font::setAlwaysUseComplexPath): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h:
  • platform/FontData.h: (WebCore::FontData::platformData):
  • platform/GlyphBuffer.h: Added. (WebCore::GlyphBuffer::GlyphBuffer): (WebCore::GlyphBuffer::isEmpty): (WebCore::GlyphBuffer::size): (WebCore::GlyphBuffer::glyphs): (WebCore::GlyphBuffer::advances): (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/mac/FontData.mm: (WebCore::isSpace): (WebCore::isRoundingHackCharacter): (WebCore::FontData::widthForGlyph): (WebCore::m_ATSUMirrors): (WebCore::FontData::xHeight): (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::FontData::findSubstituteFontData): (WebCore::computeWidthForSpace): (WebCore::FontData::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::createATSULayoutParameters): (WebCore::FontData::glyphForCharacter): (WebCore::advanceWidthIterator): (WebCore::shouldUseATSU):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::m_padPerSpace): (WebCore::addDirectionalOverride): (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::disposeATSULayoutParameters): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU):
1:18 AM Changeset in webkit [14282] by andersca
  • 2 edits in trunk/WebKit

2006-05-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • WebView/WebHTMLView.m: (+[WebHTMLView unsupportedTextMIMETypes]): Add text/rtf
12:20 AM Changeset in webkit [14281] by darin
  • 1 edit
    1 add in trunk/WebCore
  • another try at fixing the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData): Use characters() instead of unicode().
12:19 AM Changeset in webkit [14280] by darin
  • 2 edits
    1 move in trunk/WebCore

Cut change log.

12:12 AM Changeset in webkit [14279] by darin
  • 2 edits in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

Optimization of [DOMNode _nodeWith:] to look up the obj-c wrapperClass
for each HTMLElement using a HashMap instead of by repeated calls to
htmlElt->hasLocalName(someTag).

  • bindings/objc/DOM.mm: (addElementClass): Added. (createHTMLElementClassMap): (elementClass): (+[DOMNode _nodeWith:]): Added code to call elementClass.

May 9, 2006:

11:56 PM Changeset in webkit [14278] by darin
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/first-line-style-crash.html: Added.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): Changed to not return the shared styleNotYetAvailable if allowSharing is off.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): In the FIRST_LINE_INHERITED case, set the styleType on the style returned from createStyleForElement().
  • rendering/render_style.h: (WebCore::RenderStyle::setStyleType): Added. Called from RenderObject::getPseudoStyle().
11:42 PM Changeset in webkit [14277] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

No test possible (no functionality change).

  • dom/Node.cpp: (WebCore::Node::diff): When checking if :before or :after has changed, return NoInherit unless both pseudoStyles are known and equal.
  • rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle): Fixed to match the requested type against the pseudoStyle's styleType instead of our own.
11:04 PM Changeset in webkit [14276] by darin
  • 4 edits in trunk/WebCore
  • another attempt to fix the Windows build
  • bindings/js/kjs_window.cpp: (KJS::isSeparator): Take a UChar, not a KJS::UChar.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): Use UChar instead of QChar. (WebCore::FrameWin::runJavaScriptConfirm): Ditto.
  • editing/TextIterator.h: Include DeprecatedString.h.
10:43 PM Changeset in webkit [14275] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/replaced/image-map.html: Added.
  • fast/replaced/image-map-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion): Remove extra Path definition that was shadowing the real one.
10:26 PM Changeset in webkit [14274] by darin
  • 12 edits in trunk

WebCore:

  • fix build
  • rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle): Fix a typo.
  • attempt to fix Windows build
  • css/maketokenizer: Use UChar instead of unsigned short.
  • platform/win/FontWin.cpp: (WebCore::getFontData): Removed cast to QChar. (WebCore::hackishExtentForString): Use UChar. (WebCore::Font::floatWidth): Use UChar. (WebCore::Font::drawText): Use UChar. (WebCore::Font::drawHighlightForText): Use UChar. (WebCore::Font::selectionRectForText): Use UChar. (WebCore::Font::checkSelectionPoint): Use UChar.
  • platform/win/KeyEventWin.cpp: (WebCore::singleCharacterString): Added. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use above function.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findNextSentenceFromIndex): Use UChar. (WebCore::findSentenceBoundary): Use UChar. (WebCore::findNextWordFromIndex): Use UChar. (WebCore::findWordBoundary): Use UChar.
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start): Use a different String constructor.
  • rendering/RenderTable.h: Added an include of DeprecatedArray.h.
  • rendering/RenderText.cpp: Added an include of DeprecatedString.h.
  • rendering/render_list.h: Ditto.

WebKitWin:

  • attempt to fix the Windows build
  • WebView.cpp: (WebKit::WebViewWndProc): Convert to String explicitly via UChar instead of implicitly via QChar.
9:59 PM Changeset in webkit [14273] by darin
  • 104 edits
    2 adds in trunk

LayoutTests:

  • fast/css/case-transform.html: Added.
  • fast/css/case-transform-expected.txt: Added.

WebCore:

Rubber stamped by Hyatt.

Test: fast/css/case-transform.html

By using ICU more, this fixes some bugs in a few places.

  • bindings/js/JSXMLSerializer.cpp:
  • css/css_valueimpl.h:
  • kwq/KWQTextStream.cpp:
  • loader/CachedObject.h:
  • platform/Color.cpp: Add includes of DeprecatedString.h as needed, now that StringImpl.h no longer includes it.
  • bindings/js/kjs_css.cpp: (KJS::cssPropertyName): Eliminate use of QChar::latin1() in a case where it's not helpful.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Use characters() function instead of the old unicode() function.
  • bindings/js/kjs_window.cpp: (KJS::isSeparator): Use UChar instead of QChar.
  • bindings/objc/DOMInternal.mm: (StringImpl::operator NSString*): Remove typecast that's no longer needed. (String::String): Ditto. Also use Vector for local buffer to make code read simpler.
  • bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Remove call to unicode() function, no longer needed. (WebCore::FrameMac::setTitle): Remove QChar cast, no longer needed. (WebCore::FrameMac::setStatusBarText): Ditto. (WebCore::FrameMac::advanceToNextMisspelling): Use UChar instead of QChar. (WebCore::FrameMac::runJavaScriptAlert): Remove QChar cast, no longer needed. (WebCore::FrameMac::runJavaScriptConfirm): Ditto. (WebCore::FrameMac::runJavaScriptPrompt): Ditto. (WebCore::FrameMac::attributedString): Replaces calls of QChar::direction() with calls to u_charDirection and use ICU constants instead of QChar ones. (WebCore::FrameMac::markMisspellings): Remove QChar cast, no longer needed. Added a QChar cast so we can call isSpace -- slated to be removed later. (WebCore::FrameMac::shouldClose): Remove QChar cast, no longer needed.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectedString]): Remove QChar cast, no longer needed. (-[WebCoreFrameBridge stringForRange:]): Ditto.
  • css/CSSGrammar.y: Update for field name change from string to characters. Use UChar instead of unsigned short.
  • css/css_valueimpl.cpp: (WebCore::propertyID): Use UChar instead of unsigned short and get rid of call to unicode() function, no longer needed. (WebCore::quoteStringIfNeeded): Use strings when building up a resulting string, instead of depending on the feature where you can append characters to a string.
  • css/csshelper.cpp: (WebCore::parseURL): Remove calls to unicode() function and rewrite to obviate the need to call lower() just to check for a few constant character values. Also remove a now-unneeded type cast.
  • css/cssparser.h: Changed ParseString field to use UChar and to be named characters instead of string. Changed many other fields to be UChar instead of unsigned short. (WebCore::domString): Update for that. (WebCore::atomicString): Ditto.
  • css/cssparser.cpp: (WebCore::ParseString::lower): Use u_tolower instead of QChar::lower(). Also change name to characters from string. (WebCore::CSSParser::setupParser): Use UChar instead of unsigned short. (WebCore::CSSParser::lex): Ditto. Also update for characters name change. (WebCore::CSSParser::text): Use UChar instead of unsigned short. Also tweak some of the code a little bit to handle a couple of overflow cases better and reduce type casting. (WebCore::deprecatedString): Moved here so we don't have to include DeprecatedString.h in the header file.
  • css/cssstyleselector.cpp: (WebCore::checkPseudoState): Added a type cast since this code now bridges the world between modern code and QChar/DeprecatedString.
  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): Changed QChar to UChar.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::isValidName): Updated for name change from unicode to characters. (WebCore::Document::parseQualifiedName): Ditto. (WebCore::Document::backslashAsCurrencySymbol): Changed return type to UChar.
  • dom/NamedMappedAttrMap.cpp: (WebCore::isClassWhitespace): Changed parameter to UChar from QChar. (WebCore::NamedMappedAttrMap::parseClassAttribute): Changed from UChar to QChar and from unicode to characters.
  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): Changed from QChar to UChar. (WebCore::Position::trailingWhitespacePosition): Ditto.
  • dom/StyledElement.cpp: (WebCore::isClassWhitespace): Changed from QChar to UChar. (WebCore::StyledElement::addCSSLength): Changed from QChar to UChar, and remove one case where latin1() was used and was not helpful. (WebCore::StyledElement::addCSSColor): Removed unicode() function call, no longer needed.
  • dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEvent::charCode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue): Removed unicode() function call, no longer needed.
  • dom/xml_tokenizer.h: Removed default parameter for xmlDocPtrForString so we don't have to include the DeprecatedString.h header in this file (and since no one uses it).
  • editing/HTMLInterchange.cpp: (convertHTMLTextToInterchangeFormat): Added a couple calls to the unicode() function to bridge the gap from QChar/DeprecatedString back to modern code.
  • editing/InsertTextCommand.cpp: Removed unused function.
  • editing/TextIterator.h: Changed from QChar to UChar.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Initialize m_lastCharacter since it's now a UChar (which is just a typedef) rather than a QChar (which was a class with a default value of 0). (WebCore::TextIterator::handleTextNode): Updated to use characters() instead of unicode(). (WebCore::TextIterator::handleTextBox): Removed unicode() call since it's now a UChar instead of a QChar. (WebCore::TextIterator::emitCharacter): More of the same. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::CharacterIterator::string): Ditto. (WebCore::WordAwareIterator::advance): Ditto. (WebCore::WordAwareIterator::length): Ditto. (WebCore::WordAwareIterator::characters): Ditto. (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed to use UChar instead of QChar, but also to use foldCase() instead of lower(), because we want case folding here, not lowercasing. (WebCore::CircularSearchBuffer::append): Ditto, with u_foldCase. (WebCore::CircularSearchBuffer::isMatch): Ditto. (WebCore::plainText): Added type cast since this bridges the gap from the modern stuff to QChar/DeprecatedString.
  • editing/VisiblePosition.h: Changed from QChar to UChar.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Ditto.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed code that used latin1() for no good reason to use unicode() instead.


  • html/HTMLTokenizer.h: Changed from QChar to UChar.
  • html/HTMLTokenizer.cpp: Changed from QChar to UChar, including removing the KHTML_ALLOC_QCHAR_VEC and KHTML_DELETE_QCHAR_VEC macros, which weren't being used consistently anyway. (WebCore::fixUpChar): More of the same. (WebCore::tagMatch): Ditto. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::begin): Ditto. Also corrected anomaly where buffer size was not the same as the size value -- this was only true in the initial allocation, so I believe there was no value in it. (WebCore::HTMLTokenizer::parseSpecial): Ditto. Also removed a use of latin1() that was unnnecessary extra work. (WebCore::HTMLTokenizer::scriptHandler): More of the same. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. Another unnecessary use of latin1() removed. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. Changed hex-parsing code to handle uppercase hex a more-efficient way than calling QChar::lower() on each character. Also changed surrogate code logic to fix a couple things -- reject character codes

    0x10FFFF as it should and use U16_LEAD and U16_TRAIL instead of writing our

    own versions of these. (WebCore::HTMLTokenizer::parseTag): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto. (WebCore::HTMLTokenizer::enlargeBuffer): Ditto. (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto. (WebCore::HTMLTokenizer::notifyFinished): (WebCore::decodeNamedEntity): Ditto.
  • html/html_inlineimpl.cpp: (WebCore::parseFontSizeNumber): Changed from QChar to UChar, including using u_isdigit and u_charDigitValue instead of QChar::isNumber and QChar::digitValue. Also removed unneeded range checking that's already done by WebCore::String.
  • kwq/KWQLoader.mm: (KWQIsResponseURLEqualToURL): Rewrote to use Vector and UChar, removing all the type casts and making the whole function much shorter.
  • kwq/WebCoreAXObject.mm: (AXAttributedStringAppendText): Use UChar instead of QChar. (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]): More of the same.
  • loader/Cache.h: Remove unnecessary default parameters, preventing the need to include the DeprecatedString.h header in this header. Cleaned up the header structure a bit, removing some obsolete and redundant comments and fixing typos.
  • loader/Cache.cpp: Removed unused preload functions.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Added explicit arguments. This was the only caller anywhere that took advantage of the default parameter values in one of the Cache class request functions. (WebCore::Frame::backslashAsCurrencySymbol): Changed QChar to UChar.
  • platform/AtomicString.h: Changed QChar to UChar. Removed constructor that makes an AtomicString from a single character. Renamed unicode() function to characters(). Renamed KHTML_ATOMICSTRING_HIDE_GLOBALS to ATOMICSTRING_HIDE_GLOBALS.
  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): Changed QChar to UChar. (WebCore::operator==): Changed unicode() to characters(). (WebCore::UCharBufferTranslator::hash): More of the same. (WebCore::UCharBufferTranslator::equal): Ditto. (WebCore::UCharBufferTranslator::translate): Ditto. (WebCore::AtomicString::add): Ditto. (WebCore::AtomicString::operator Identifier): Ditto. (WebCore::AtomicString::operator UString): Ditto. (WebCore::AtomicString::AtomicString): Moved here so we don't need DeprecatedString.h in the header. (WebCore::AtomicString::deprecatedString): Ditto.
  • platform/DeprecatedString.h: Removed QChar::Direction enum and all the DirXXX values, isDigit, isLetter, isNumber, isLetterOrNumber, isPunct, digitValue, and direction functions. (QChar::isSpace): Changed to use u_charDirection instead of QChar::direction.
  • platform/Font.h: (WebCore::Font::width): Changed QChar to UChar.
  • platform/Font.cpp: (WebCore::Font::width): Ditto.
  • platform/GraphicsContext.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Changed QChar to UChar. Removed horizontalAlignment parameter from simplified string drawing entry point, since it's not used. (WebCore::GraphicsContext::drawHighlightForText): Changed QChar to UChar.
  • platform/PlatformString.h: Changed QChar to UChar. Removed constructor that makes a String from a single character. Renamed unicode() function to characters(). Added an append function and changed += operator to just call that. Added a foldCase() function. Removed the concatenation operators that add individual strings before or after.
  • platform/String.cpp: (WebCore::String::String): Changed QChar to UChar. (WebCore::String::append): Renamed from operator+= and removed the return value. (WebCore::String::operator[]): Changed QChar to UChar. (WebCore::String::foldCase): Added. (WebCore::String::percentage): More of the same. (WebCore::String::characters): Renamed from unicode(). (WebCore::String::deprecatedString): More of the same. (WebCore::String::sprintf): Fixed mistakes in the comments. (WebCore::String::isEmpty): Tweaked a bit. (WebCore::operator==): More of the same. (WebCore::String::operator Identifier): Ditto. (WebCore::String::operator UString): Ditto.
  • platform/SegmentedString.h: Changed from QChar to UChar. Had to initialize data members that are now UChar.
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::length): Updated for change from QChar to UChar. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::toString): Ditto.
  • platform/StringHash.h: Updated to use UChar instead of QChar and for name changes. Also changed to use case folding intead of lowercasing for case insensitive hashing.
  • platform/StringImpl.h:
  • platform/StringImpl.cpp: (WebCore::newUCharVector): Changed to UChar from QChar. (WebCore::deleteUCharVector): Ditto. (WebCore::StringImpl::StringImpl): Ditto. (WebCore::StringImpl::init): Ditto. Also renamed from initWithChar and initWithQChar. (WebCore::StringImpl::~StringImpl): Ditto. (WebCore::StringImpl::append): Ditto. (WebCore::StringImpl::insert): Ditto. (WebCore::StringImpl::truncate): Ditto. (WebCore::StringImpl::remove): Ditto. (WebCore::StringImpl::split): Ditto. (WebCore::StringImpl::containsOnlyWhitespace): Ditto. Also added comment because this function seems a little broken. (WebCore::parseLength): More of the same. (WebCore::StringImpl::toCoordsArray): Ditto. (WebCore::StringImpl::toLengthArray): Ditto. (WebCore::StringImpl::isLower): Ditto. (WebCore::StringImpl::lower): Rewrote to use u_strToLower. (WebCore::StringImpl::upper): Rewrote to use u_strToUpper. (WebCore::StringImpl::foldCase): Added. Uses u_strFoldCase. (WebCore::getWordBreakIterator): Changed to use U_FAILURE instead of accepting only U_ZERO_ERROR as a success code. (WebCore::StringImpl::capitalize): More QChar to UChar changes. (WebCore::StringImpl::toInt): Ditto. (WebCore::equal): Changed from QChar to UChar and was careful to preserve the old semantics where "high ASCII" is treated as U+0080-U+00FF even though I don't know if this feature is important. (WebCore::equalIgnoringCase): Ditto, but used case folding instead of lowercasing by using the u_foldCase and u_memcasecmp functions. Also renamed from equalCaseInsensitive for more-consistent naming. (WebCore::StringImpl::find): Ditto. Use case folding for the case insensitive branch. (WebCore::StringImpl::replace): More of the same. (WebCore::StringImpl::computeHash): Ditto. (WebCore::StringImpl::ascii): Ditto.
  • platform/TextBoundaries.h: Changed from QChar to UChar.
  • platform/mac/TextBoundaries.mm: (WebCore::findWordBoundary): Made the change to UChar and removed some type casts. (WebCore::findNextWordFromIndex): Ditto. (WebCore::findSentenceBoundary): Ditto. (WebCore::findNextSentenceFromIndex): Ditto.
  • platform/TextEncoding.h:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::backslashAsCurrencySymbol): Changed from QChar to UChar. (WebCore::TextEncoding::fromUnicode): More of the same.
  • platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode): More of the same.
  • platform/mac/FontFamilyMac.mm: (WebCore::FontFamily::getNSFamily): Removed a now-unneeded type cast.
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): Changed QChar to UChar and removed some now-unneeded type casts.
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::isWhitespace):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startWordBoundary): (WebCore::endWordBoundary): (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::startSentenceBoundary): (WebCore::endSentenceBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
  • rendering/RenderTreeAsText.cpp: (quoteAndEscapeNonPrintables):
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
  • rendering/break_lines.h: (WebCore::isBreakable):
  • rendering/render_style.h: (WebCore::RenderStyle::isCollapsibleWhiteSpace):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/xmlhttprequest.cpp: (WebCore::getMIMEType): (WebCore::getCharset): Changed QChar to UChar.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Changed QChar to UChar. (WebCore::RenderImage::paint): Changed callers of drawText to no-longer pass 0 for the horizontal alignment, since I removed that parameters.
  • rendering/RenderText.h: Changed QChar to UChar.
  • rendering/RenderText.cpp: (WebCore::characterBreakIterator): Update for name change. (WebCore::RenderText::RenderText): Ditto. (WebCore::RenderText::allAscii): Remove uneeded unicode() and allow the value U+007F to count as ASCII. (WebCore::RenderText::cacheWidths): Changed QChar to UChar. (WebCore::RenderText::widthFromCache): Changed code that deals with direction to use the ICU direction calls. (WebCore::RenderText::trimmedMinMaxWidth): Changed QChar to UChar. (WebCore::RenderText::calcMinMaxWidth): Ditto. (WebCore::RenderText::containsOnlyWhitespace): Ditto. (WebCore::RenderText::setText): Ditto. (WebCore::RenderText::width): Ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): Removed unneeded QChar cast. (WebCore::RenderTextField::calcMinMaxWidth): Changed from QChar to UChar.
  • rendering/bidi.h:
  • rendering/bidi.cpp: (WebCore::BidiIterator::BidiIterator): (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::current): (WebCore::BidiIterator::direction): (WebCore::addRun): (WebCore::checkMidpoints): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow): Changed from QChar to UChar and all direction from QChar constants to the ones from ICU.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks): Got rid of now-unneeded QChar type casts.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Updated for change from QChar to UChar. (WebCore::EllipsisBox::paint): Updated for unicode() -> characters() name change.
  • rendering/render_list.cpp: (WebCore::toRoman): Updated from QChar to UChar. (WebCore::toLetterString): Ditto. (WebCore::toHebrew): More of the same, also cleaned up the logic a bit. (WebCore::RenderListMarker::paint): Removed the alignment parameters from the various functions. Also removed all reliance on the width-measuring functions that take a string. (WebCore::RenderListMarker::calcMinMaxWidth): More of the same. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
9:08 PM Changeset in webkit [14272] by sfalken
  • 2 edits in trunk/WebKitTools

2006-05-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.

Fix registry usage from perl script. Turns out libwin32's
SetRegValueEx, even for REG_DWORD, always takes its value as a string!


  • Scripts/install-win-extras:
8:00 PM Changeset in webkit [14271] by tomernic
  • 3 edits in trunk/WebCore

Reviewed by/co-written by Darin.

Performance improvement when drawing large numbers of animated images.

Instead of removing the "first" object from a set on each next(),
copy the clients into a vector once and keep track of the current index.

  • loader/CachedObjectClientWalker.h:
  • loader/CachedObjectClientWalker.cpp: (WebCore::CachedObjectClientWalker::CachedObjectClientWalker): (WebCore::CachedObjectClientWalker::next):
6:10 PM Changeset in webkit [14270] by lweintraub
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin.

<rdar:/problem/4442395>
Tiny MCE: Link isn't inserted after dragging into textarea field
Created tests to test drag-and-dropped links.


  • editing/pasteboard/drop-link-expected.checksum: Added.
  • editing/pasteboard/drop-link-expected.png: Added.
  • editing/pasteboard/drop-link-expected.txt: Added.
  • editing/pasteboard/drop-link.html: Added.

WebKit:

Reviewed by justin.

<rdar://problem/4442395>
Tiny MCE: Link isn't inserted after dragging into textarea field


  • WebView/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]): Modified to create an anchor object with a title as opposed to just the URL as text.
4:29 PM Changeset in webkit [14269] by sfalken
  • 2 edits in trunk/WebCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build. Added TextDocument.cpp to vcproj.


Reviewed by adele.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
3:54 PM Changeset in webkit [14268] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.

<rdar://problem/4540011> Random crash occurs at when loading espn.go.com (khtml::RenderObject::PaintInfo&, int, int)


The crash occured because the document element was cached but later replaced by a script.
So the render object was accessing the old document element that no longer had a renderer.
When the document's children change we now invalidate the document element in case it is replaced.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::childrenChanged):
  • khtml/xml/dom_docimpl.h:
3:53 PM Changeset in webkit [14267] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderObject.cpp

Missed a dir.

2:57 PM Changeset in webkit [14266] by sfalken
  • 5 edits in trunk/WebKitTools

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Add load ended callback.


Reviewed by kevin.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Fix include paths
  • Scripts/build-webkit: Build WebKitWin instead of WebCore/JavaScriptCore (WebKitWin builds those indirectly).
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::loadEnd): Add callback for loadEnd() to determine success/failure of page load. (_tWinMain): Load built-in test content here instead of in lower-level code.
  • Spinneret/Spinneret/Spinneret.h: Add loadEnd() callback.
2:56 PM Changeset in webkit [14265] by sfalken
  • 5 edits in trunk/WebKitWin

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Add host calback so caller can determine success/failure of a page load.


Reviewed by kevin.

  • WebFramePrivate.cpp: (WebKit::WebFramePrivate::loadFilePath): Style fix. (WebKit::WebFramePrivate::loadHTMLString): Style fix. (WebKit::WebFramePrivate::receivedAllData): Call host->loadEnd() with data indicating success/failure of load.
  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj: Fix include paths.
  • WebView.cpp: (WebKit::WebView::WebView): Don't load boilerplate test HTML from core code.
  • public/WebHost.h: Add host callback for loadEnd().
2:54 PM Changeset in webkit [14264] by sfalken
  • 12 edits
    1 add in trunk/WebCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Add host calback so caller can determine success/failure of a page load.


Reviewed by kevin.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix paths, add missing files
  • loader/CachedResource.h: Fix include path.
  • loader/CachedResourceClientWalker.h: Fix include path.
  • platform/FontPlatformData.h: Fix include path.
  • platform/TransferJobClient.h: Make PlatformData, PlatformResponse an opaque struct.
  • platform/image-decoders/ImageDecoder.h: Fix include path.
  • platform/win/SharedTimerWin.cpp: Fix include path.
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): Add host callback for success/failure of load.
  • platform/win/TransferJobWin.h: Added. Windows version of PlatformData/PlatformResponse.
  • xpath/impl/XPathFunctions.cpp: Work around missing math functions in MSVC. (round): Work around missing math functions in MSVC.
  • xpath/impl/XPathPredicate.cpp: Work around missing math functions in MSVC.
  • xpath/impl/XPathValue.cpp: Work around missing math functions in MSVC.
2:50 PM Changeset in webkit [14263] by sfalken
  • 5 edits in trunk/JavaScriptCore

2006-05-09 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.
Minor fixes to WTF headers.


Reviewed by kevin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Fix include dirs, paths to files.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Fix include dirs.
  • wtf/Assertions.h: include Platform.h to get definition for COMPILER()
  • wtf/Vector.h: include FastMalloc.h for definition of fastMalloc, fastFree
2:49 PM Changeset in webkit [14262] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or
other WebPreferences changes)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): When the plugin view is removed from both its window and its hostWindow, stop observing WebPreferences.
2:44 PM Changeset in webkit [14261] by hyatt
  • 10 edits in trunk/WebCore

Revert styleForElement, pseudoStyleForElement, styleForRenderer back to
their old names, since the term "create" is not accurate.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement):
  • css/cssstyleselector.h:
  • dom/Element.cpp: (WebCore::Element::styleForRenderer): (WebCore::Element::recalcStyle):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::styleForRenderer):
  • dom/Node.h:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
2:15 PM Changeset in webkit [14260] by andersca
  • 4 edits in trunk/LayoutTests

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Hyatt.


  • http/tests/incremental/slow-utf8-text-expected.checksum:
  • http/tests/incremental/slow-utf8-text-expected.png:
  • http/tests/incremental/slow-utf8-text-expected.txt: Update tests now that we wrap plain text differently.
2:09 PM Changeset in webkit [14259] by andersca
  • 2 edits in trunk/WebCore

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Use the correct variable to prevent crashes.
12:03 PM Changeset in webkit [14258] by andersca
  • 14 edits
    2 adds
    4 deletes in trunk

WebCore:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8808
WebCore should handle text files


  • WebCore.xcodeproj/project.pbxproj: Add TextDocument.cpp and TextDocument.h


  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedMIMETypes]): Add text types here.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createTextDocument): (WebCore::DOMImplementation::isTextMIMEType):
  • dom/DOMImplementation.h: New functions for creating a TextDocument and determining if a mime type is a text MIME type.


  • loader/TextDocument.cpp: Added. (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): (WebCore::TextTokenizer::isWaitingForScripts): Special tokenizer which will put text inside a <pre> tag in a document.


(WebCore::TextDocument::TextDocument):
(WebCore::TextDocument::createTokenizer):
Create a TextTokenizer.


  • loader/TextDocument.h: Added.


  • page/Frame.cpp: (WebCore::Frame::begin): Create a TextDocument if the MIME type is of type text.

WebKit:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8808
WebCore should handle text files

  • WebKit.exp: Remove WebTextView.


  • WebKit.xcodeproj/project.pbxproj: Get rid of WebTextView and WebTextRepresentation.


  • WebView/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
  • WebView/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
  • WebView/WebHTMLView.m: The text MIME types are now handled by WebHTMLView.


(+[WebHTMLView unsupportedTextMIMETypes]):
New function, moved here from WebTextView.


  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebTextRepresentation.h: Removed.
  • WebView/WebTextRepresentation.m: Removed.
  • WebView/WebTextView.h: Removed.
  • WebView/WebTextView.m: Removed.


  • WebView/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): Now special-case WebHTMLView instead of WebTextView for MIME types that shouldn't be shown.
2:32 AM Changeset in webkit [14257] by mjs
  • 4 edits in trunk

Fixed ChangeLog comments.

2:27 AM Changeset in webkit [14256] by mjs
  • 193 edits
    3 moves in trunk

JavaScriptCore:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_instance.cpp:
  • bindings/objc/WebScriptObject.mm:
  • kjs/JSImmediate.h:
  • kjs/Parser.cpp:
  • kjs/Parser.h:
  • kjs/array_object.cpp:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • kjs/collector.h:
  • kjs/config.h:
  • kjs/function.cpp: (KJS::isStrWhiteSpace):
  • kjs/function.h:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/lexer.cpp: (Lexer::shift): (Lexer::isWhiteSpace): (Lexer::isIdentStart): (Lexer::isIdentPart):
  • kjs/lookup.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/number_object.cpp:
  • kjs/object.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/string_object.cpp: (StringProtoFunc::callAsFunction):
  • kjs/testkjs.cpp: (testIsInteger):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kxmlcore: Removed.
  • kxmlcore/AlwaysInline.h: Removed.
  • kxmlcore/Assertions.cpp: Removed.
  • kxmlcore/Assertions.h: Removed.
  • kxmlcore/FastMalloc.cpp: Removed.
  • kxmlcore/FastMalloc.h: Removed.
  • kxmlcore/FastMallocInternal.h: Removed.
  • kxmlcore/Forward.h: Removed.
  • kxmlcore/HashCountedSet.h: Removed.
  • kxmlcore/HashFunctions.h: Removed.
  • kxmlcore/HashMap.h: Removed.
  • kxmlcore/HashSet.h: Removed.
  • kxmlcore/HashTable.cpp: Removed.
  • kxmlcore/HashTable.h: Removed.
  • kxmlcore/HashTraits.h: Removed.
  • kxmlcore/ListRefPtr.h: Removed.
  • kxmlcore/Noncopyable.h: Removed.
  • kxmlcore/OwnArrayPtr.h: Removed.
  • kxmlcore/OwnPtr.h: Removed.
  • kxmlcore/PassRefPtr.h: Removed.
  • kxmlcore/Platform.h: Removed.
  • kxmlcore/RefPtr.h: Removed.
  • kxmlcore/TCPageMap.h: Removed.
  • kxmlcore/TCSpinLock.h: Removed.
  • kxmlcore/TCSystemAlloc.cpp: Removed.
  • kxmlcore/TCSystemAlloc.h: Removed.
  • kxmlcore/UnusedParam.h: Removed.
  • kxmlcore/Vector.h: Removed.
  • kxmlcore/VectorTraits.h: Removed.
  • kxmlcore/unicode: Removed.
  • kxmlcore/unicode/Unicode.h: Removed.
  • kxmlcore/unicode/UnicodeCategory.h: Removed.
  • kxmlcore/unicode/icu: Removed.
  • kxmlcore/unicode/icu/UnicodeIcu.h: Removed.
  • kxmlcore/unicode/posix: Removed.
  • kxmlcore/unicode/qt3: Removed.
  • kxmlcore/unicode/qt4: Removed.
  • kxmlcore/unicode/qt4/UnicodeQt4.h: Removed.
  • pcre/pcre_get.c:
  • wtf: Added.
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::Scavenge): (WTF::do_malloc): (WTF::do_free): (WTF::TCMallocGuard::TCMallocGuard): (WTF::malloc): (WTF::free): (WTF::calloc): (WTF::cfree): (WTF::realloc):
  • wtf/FastMalloc.h:
  • wtf/FastMallocInternal.h:
  • wtf/Forward.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.cpp:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/ListRefPtr.h:
  • wtf/Noncopyable.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
  • wtf/Vector.h:
  • wtf/VectorTraits.h:
  • wtf/unicode/UnicodeCategory.h:
  • wtf/unicode/icu/UnicodeIcu.h:

JavaScriptGlue:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • config.h:
  • kxmlcore: Removed.
  • kxmlcore/AlwaysInline.h: Removed.
  • kxmlcore/Assertions.h: Removed.
  • kxmlcore/FastMalloc.h: Removed.
  • kxmlcore/Forward.h: Removed.
  • kxmlcore/HashCountedSet.h: Removed.
  • kxmlcore/HashSet.h: Removed.
  • kxmlcore/Noncopyable.h: Removed.
  • kxmlcore/OwnArrayPtr.h: Removed.
  • kxmlcore/OwnPtr.h: Removed.
  • kxmlcore/PassRefPtr.h: Removed.
  • kxmlcore/Platform.h: Removed.
  • kxmlcore/RefPtr.h: Removed.
  • kxmlcore/Vector.h: Removed.
  • wtf: Added.

WebCore:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • ForwardingHeaders/kxmlcore: Removed.
  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Removed.
  • ForwardingHeaders/kxmlcore/Assertions.h: Removed.
  • ForwardingHeaders/kxmlcore/FastMalloc.h: Removed.
  • ForwardingHeaders/kxmlcore/Forward.h: Removed.
  • ForwardingHeaders/kxmlcore/HashCountedSet.h: Removed.
  • ForwardingHeaders/kxmlcore/HashMap.h: Removed.
  • ForwardingHeaders/kxmlcore/HashSet.h: Removed.
  • ForwardingHeaders/kxmlcore/HashTraits.h: Removed.
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Removed.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/PassRefPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/Platform.h: Removed.
  • ForwardingHeaders/kxmlcore/RefPtr.h: Removed.
  • ForwardingHeaders/kxmlcore/Vector.h: Removed.
  • ForwardingHeaders/wtf: Added.
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOMImplementationFront.h:
  • bridge/JavaAppletWidget.h:
  • bridge/mac/WebCoreFrameNamespaces.mm:
  • bridge/mac/WebCorePageBridge.mm: (initializeLogChannel):
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreViewFactory.m:
  • config.h:
  • css/css_base.h:
  • css/css_valueimpl.h:
  • css/csshelper.cpp:
  • css/cssparser.h:
  • dom/DOMImplementation.h:
  • dom/Document.h:
  • dom/NamedNodeMap.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/QualifiedName.cpp:
  • dom/Range.h:
  • dom/StyledElement.cpp:
  • dom/dom2_traversalimpl.h:
  • dom/xml_tokenizer.h:
  • editing/RebalanceWhitespaceCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/RemoveNodeAttributeCommand.cpp:
  • editing/RemoveNodeCommand.cpp:
  • editing/RemoveNodePreservingChildrenCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.cpp:
  • editing/SetNodeAttributeCommand.cpp:
  • editing/SplitElementCommand.cpp:
  • editing/SplitTextNodeCommand.cpp:
  • editing/SplitTextNodeContainingElementCommand.cpp:
  • editing/TextIterator.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp:
  • html/HTMLCollection.h:
  • html/HTMLElementFactory.h:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGDOMImplementation.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformable.cpp:
  • kwq/AccessibilityObjectCache.h:
  • kwq/KWQCString.cpp:
  • kwq/KWQFormData.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/KWQTextEdit.mm:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/Decoder.h:
  • loader/DocLoader.h:
  • loader/loader.cpp:
  • loader/loader.h:
  • page/DOMWindow.h:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp:
  • page/Page.cpp:
  • page/Page.h:
  • page/Plugin.h:
  • platform/Arena.cpp:
  • platform/ArrayImpl.h:
  • platform/AtomicString.cpp:
  • platform/CharsetNames.cpp:
  • platform/Color.cpp:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedValueListImpl.h:
  • platform/FontFallbackList.h:
  • platform/GraphicsContext.h:
  • platform/GraphicsTypes.cpp:
  • platform/Image.h:
  • platform/KURL.cpp:
  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/PlatformString.h:
  • platform/PlugInInfoStore.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/StreamingTextDecoder.h:
  • platform/String.cpp:
  • platform/StringHash.h:
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/TextEncoding.cpp:
  • platform/Timer.cpp:
  • platform/Timer.h:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/mac/BlockExceptions.mm:
  • platform/mac/ColorMac.mm:
  • platform/mac/FontData.mm:
  • platform/mac/KURLMac.mm:
  • platform/mac/QStringMac.mm:
  • platform/mac/SharedTimerMac.cpp:
  • platform/mac/TextEncodingMac.cpp:
  • platform/mac/WebCoreImageRendererFactory.m:
  • platform/mac/WebCoreKeyGenerator.m:
  • platform/mac/WebCoreTextArea.mm:
  • platform/mac/WebCoreTextField.mm:
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm:
  • platform/win/TemporaryLinkStubs.cpp: (JavaAppletWidget::JavaAppletWidget):
  • rendering/InlineTextBox.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/bidi.cpp:
  • xml/XSLTProcessor.h:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathParser.h:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathUtil.h:

WebKit:

Rubber stamped by Anders.


  • renamed kxmlcore to wtf


kxmlcore --> wtf
KXMLCore --> WTF
WKC --> WTF

  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel):
1:35 AM Changeset in webkit [14255] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/extract-localizable-strings: Update for correct names of log macros.
1:19 AM Changeset in webkit [14254] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8803
XPath query for empty attributes crashes in XPath::StringExpression::StringExpression


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::lexString): Make sure an empty string is returned instead of a null string.


(WebCore::XPath::Parser::lex):
Only assign the string if it isn't null.

LayoutTests:

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8803
XPath query for empty attributes crashes in XPath::StringExpression::StringExpression


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::lexString): Make sure an empty string is returned instead of a null string.


(WebCore::XPath::Parser::lex):
Only assign the string if it isn't null.

1:03 AM Changeset in webkit [14253] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix the ICU code path, too (currently unused on the Mac).

  • platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): Normalize the string.
12:47 AM Changeset in webkit [14252] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Anders.

Bug 8804: Inspector should support searching by Xpath query
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8804

12:23 AM Changeset in webkit [14251] by mjs
  • 19 edits
    5 copies in trunk

WebCore:

Reviewed by Tim Hatcher.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/Cache.cpp: (WebCore::Cache::updateCacheStatus): (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument):
  • loader/Cache.h:
  • loader/CachedResource.cpp: Added.
  • loader/CachedResource.h: Added.
  • loader/CachedResourceClient.h: Added.
  • loader/CachedResourceClientWalker.cpp: Added.
  • loader/CachedResourceClientWalker.h: Added.
  • loader/DocLoader.cpp: (WebCore::DocLoader::setAutoloadImages): (WebCore::DocLoader::removeCachedObject):
  • loader/DocLoader.h: (WebCore::DocLoader::cachedObject): (WebCore::DocLoader::allCachedObjects):

WebKit:

Reviewed by Tim Hatcher.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _archivedSubresourceForURL:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]): (-[WebDataSource addSubresource:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol didFinishLoading]):
  • WebView/WebUnarchivingState.h:
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState addResource:]):

May 8, 2006:

11:52 PM Changeset in webkit [14250] by andersca
  • 2 edits in trunk/WebKitTools

2006-05-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.


  • Scripts/check-dom-results: Add XPath to the list of results.
6:27 PM Changeset in webkit [14249] by lweintraub
  • 2 edits in trunk/LayoutTests

Reviewed by justin.


REGRESSION: two editing layout tests show incorrect spell checking in pixel test mode
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8350
Forgot to update expected results.

  • fast/dom/inner-text-001-expected.txt
5:53 PM Changeset in webkit [14248] by lweintraub
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin.


REGRESSION: two editing layout tests show incorrect spell checking in pixel test mode
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8350

  • editing/pasteboard/innerText-inline-table-expected.checksum: Added.
  • editing/pasteboard/innerText-inline-table-expected.png: Added.
  • editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • editing/pasteboard/innerText-inline-table.html: Added.

WebCore:

Reviewed by justin.

  • editing/TextIterator.cpp: (WebCore::shouldEmitSpaceBeforeAndAfterNode): Returns true when the node should have a leading and trailing space. Currently only used for inline tables. The function shouldEmitNewlinesBeforeAndAfterNode has a fallback for nodes with no RenderObject, but the inline property doesn't really have a meaning without one. (WebCore::TextIterator::handleNonTextNode): Checks shouldEmitSpaceBeforeAndAfterNode and inserts a space if necessary. (WebCore::TextIterator::exitNode): Checks shouldEmitSpaceBeforeAndAfterNode and inserts a space if necessary.
5:49 PM Changeset in webkit [14247] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Add another rename.
5:36 PM Changeset in webkit [14246] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Tim O.

  • bindings/npapi.h: do not define #pragma options align=mac68k if we are 64-bit
5:13 PM Changeset in webkit [14245] by thatcher
  • 1 edit in trunk/Makefile.shared

Adding a ARGS variable that can be used to pass arguments to xcodebuild. This is handy when you want to temporary overide a build setting, like ARCHS. Use: make r ARGS='ARCHS=ppc64'

3:20 PM Changeset in webkit [14244] by andersca
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Remove \impl from files who aren't actually in the \impl directory...let's hope this does it

3:11 PM Changeset in webkit [14243] by andersca
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add xpath\impl to include path as well.

3:06 PM Changeset in webkit [14242] by andersca
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add XPATH_SUPPORT define. This is getting old...

3:01 PM Changeset in webkit [14241] by andersca
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add xpath in _both_ places

2:56 PM Changeset in webkit [14240] by andersca
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Another try, now add xpath to the include path

2:50 PM Changeset in webkit [14239] by andersca
  • 2 edits in trunk/WebCore

2006-05-08 Anders Carlsson <​acarlsson@apple.com>

Try fixing the Win32 build


  • WebCore.vcproj/WebCore/WebCore.vcproj: Add XPath files to project.
2:34 PM Changeset in webkit [14238] by thatcher
  • 1 copy in tags/WebCore-418.2/WebCore

Tag for WebCore 418.2 (part 2 of 2.)

2:34 PM Changeset in webkit [14237] by thatcher
  • 1 add in tags/WebCore-418.2

Tag for WebCore 418.2 (part 1 of 2.)

2:31 PM Changeset in webkit [14236] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:30 PM Changeset in webkit [14235] by andersca
  • 1 edit
    197 adds in trunk/LayoutTests

2006-05-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Add DOM3 xpath tests as self-contained SVG files.


  • dom/svg: Added.
  • dom/svg/level3: Added.
  • dom/svg/level3/xpath: Added.
  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Attribute_Nodes.js: Added.
  • dom/svg/level3/xpath/Attribute_Nodes.svg: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns-expected.txt: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.js: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.svg: Added.
  • dom/svg/level3/xpath/Comment_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Comment_Nodes.js: Added.
  • dom/svg/level3/xpath/Comment_Nodes.svg: Added.
  • dom/svg/level3/xpath/Conformance_Expressions-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_Expressions.js: Added.
  • dom/svg/level3/xpath/Conformance_Expressions.svg: Added.
  • dom/svg/level3/xpath/Conformance_ID-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_ID.js: Added.
  • dom/svg/level3/xpath/Conformance_ID.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null.svg: Added.
  • dom/svg/level3/xpath/Element_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Element_Nodes.js: Added.
  • dom/svg/level3/xpath/Element_Nodes.svg: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.js: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.svg: Added.
  • dom/svg/level3/xpath/Text_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Text_Nodes.js: Added.
  • dom/svg/level3/xpath/Text_Nodes.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01.js: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.svg: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.js: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.svg: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.js: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_UNORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue.js: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue.svg: Added.
  • dom/svg/level3/xpath/XPathResult_resultType-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_resultType.js: Added.
  • dom/svg/level3/xpath/XPathResult_resultType.svg: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue.js: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue.svg: Added.
  • dom/svg/level3/xpath/svgunit.js: Added.
2:27 PM Changeset in webkit [14234] by andersca
  • 16 edits
    35 adds in trunk/WebCore

2006-05-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin, Eric and Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6638
Support Mozilla's XPathEvaluator object.


  • DerivedSources.make: Generate XPath grammar, and JavaScript wrappers.


  • WebCore.xcodeproj/project.pbxproj: Add new files to project


  • bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException): Handle setting XPath exceptions.


  • bindings/objc/DOM.mm: Just return nil for now when trying to create a wrapper for XPath namespace nodes.
  • bindings/scripts/CodeGeneratorJS.pm: Add XPath types. Also add a "CanBeConstructed" extended attribute for interfaces that can be constructed directly.


  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize LogXPath channel.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Support "xpath" version "3.0".


  • dom/Document.cpp: (WebCore::Document::Document):


(WebCore::Document::importNode):
Ignore XPath namespace nodes.


(WebCore::Document::createExpression):
(WebCore::Document::createNSResolver):
(WebCore::Document::evaluate):
New functions which call down to a lazily created XPathEvaluator.

  • dom/Document.h: Add function declarations.


  • dom/Document.idl: Add XPath methods.


  • dom/Node.h: (WebCore::Node::): Add XPATH_NAMESPACE_NODE type.


  • editing/markup.cpp: (WebCore::startMarkup): Ignore XPath namespace nodes.


  • page/DOMWindow.idl: Add constructors for XPathEvaluator and XPathResult.


  • platform/Logging.cpp:
  • platform/Logging.h: Add XPath log channel
  • xpath: Added.
  • xpath/XPathEvaluator.cpp: Added. (WebCore::XPathEvaluator::createExpression): (WebCore::XPathEvaluator::createNSResolver): (WebCore::XPathEvaluator::evaluate):
  • xpath/XPathEvaluator.h: Added. (WebCore::):
  • xpath/XPathEvaluator.idl: Added.
  • xpath/XPathExpression.cpp: Added. (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::~XPathExpression): (WebCore::XPathExpression::evaluate):
  • xpath/XPathExpression.h: Added.
  • xpath/XPathExpression.idl: Added.
  • xpath/XPathNSResolver.cpp: Added. (WebCore::XPathNSResolver::XPathNSResolver): (WebCore::XPathNSResolver::lookupNamespaceURI):
  • xpath/XPathNSResolver.h: Added.
  • xpath/XPathNSResolver.idl: Added.
  • xpath/XPathNamespace.cpp: Added. (WebCore::XPathNamespace::XPathNamespace): (WebCore::XPathNamespace::~XPathNamespace): (WebCore::XPathNamespace::ownerDocument): (WebCore::XPathNamespace::ownerElement): (WebCore::XPathNamespace::prefix): (WebCore::XPathNamespace::nodeName): (WebCore::XPathNamespace::nodeValue): (WebCore::XPathNamespace::namespaceURI): (WebCore::XPathNamespace::nodeType):
  • xpath/XPathNamespace.h: Added.
  • xpath/XPathResult.cpp: Added. (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::InvalidatingEventListener::handleEvent): (WebCore::XPathResult::XPathResult): (WebCore::XPathResult::~XPathResult): (WebCore::XPathResult::convertTo): (WebCore::XPathResult::resultType): (WebCore::XPathResult::numberValue): (WebCore::XPathResult::stringValue): (WebCore::XPathResult::booleanValue): (WebCore::XPathResult::singleNodeValue): (WebCore::XPathResult::invalidateIteratorState): (WebCore::XPathResult::invalidIteratorState): (WebCore::XPathResult::snapshotLength): (WebCore::XPathResult::iterateNext): (WebCore::XPathResult::snapshotItem):
  • xpath/XPathResult.h: Added. (WebCore::XPathResult::):
  • xpath/XPathResult.idl: Added.
  • xpath/impl: Added.
  • xpath/impl/XPathExpressionNode.cpp: Added. (WebCore::XPath::Expression::evaluationContext): (WebCore::XPath::Expression::Expression): (WebCore::XPath::Expression::~Expression): (WebCore::XPath::Expression::evaluate): (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::optimize): (WebCore::XPath::Expression::subExprCount): (WebCore::XPath::Expression::subExpr): (WebCore::XPath::Expression::isConstant):
  • xpath/impl/XPathExpressionNode.h: Added. (WebCore::XPath::EvaluationContext::EvaluationContext):
  • xpath/impl/XPathFunctions.cpp: Added. (WebCore::XPath::Interval::Interval): (WebCore::XPath::Interval::contains): (WebCore::XPath::Interval::asString): (WebCore::XPath::Function::setArguments): (WebCore::XPath::Function::setName): (WebCore::XPath::Function::arg): (WebCore::XPath::Function::argCount): (WebCore::XPath::Function::name): (WebCore::XPath::FunLast::doEvaluate): (WebCore::XPath::FunLast::isConstant): (WebCore::XPath::FunPosition::doEvaluate): (WebCore::XPath::FunPosition::isConstant): (WebCore::XPath::FunLocalName::isConstant): (WebCore::XPath::FunLocalName::doEvaluate): (WebCore::XPath::FunNamespaceURI::isConstant): (WebCore::XPath::FunNamespaceURI::doEvaluate): (WebCore::XPath::FunName::isConstant): (WebCore::XPath::FunName::doEvaluate): (WebCore::XPath::FunCount::doEvaluate): (WebCore::XPath::FunCount::isConstant): (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunConcat::doEvaluate): (WebCore::XPath::FunStartsWith::doEvaluate): (WebCore::XPath::FunContains::doEvaluate): (WebCore::XPath::FunSubstringBefore::doEvaluate): (WebCore::XPath::FunSubstringAfter::doEvaluate): (WebCore::XPath::FunSubstring::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): (WebCore::XPath::FunTranslate::doEvaluate): (WebCore::XPath::FunBoolean::doEvaluate): (WebCore::XPath::FunNot::doEvaluate): (WebCore::XPath::FunTrue::doEvaluate): (WebCore::XPath::FunTrue::isConstant): (WebCore::XPath::FunLang::doEvaluate): (WebCore::XPath::FunLang::isConstant): (WebCore::XPath::FunFalse::doEvaluate): (WebCore::XPath::FunFalse::isConstant): (WebCore::XPath::FunNumber::doEvaluate): (WebCore::XPath::FunSum::doEvaluate): (WebCore::XPath::FunFloor::doEvaluate): (WebCore::XPath::FunCeiling::doEvaluate): (WebCore::XPath::FunRound::doEvaluate): (WebCore::XPath::FunctionLibrary::self): (WebCore::XPath::FunctionLibrary::FunctionLibrary): (WebCore::XPath::FunctionLibrary::createFunction):
  • xpath/impl/XPathFunctions.h: Added.
  • xpath/impl/XPathGrammar.y: Added.
  • xpath/impl/XPathParser.cpp: Added. (WebCore::XPath::): (WebCore::XPath::Parser::charCat): (WebCore::XPath::Parser::isAxisName): (WebCore::XPath::Parser::isNodeTypeName): (WebCore::XPath::Parser::isOperatorContext): (WebCore::XPath::Parser::skipWS): (WebCore::XPath::Parser::makeTokenAndAdvance): (WebCore::XPath::Parser::makeIntTokenAndAdvance): (WebCore::XPath::Parser::peekAheadHelper): (WebCore::XPath::Parser::peekCurHelper): (WebCore::XPath::Parser::lexString): (WebCore::XPath::Parser::lexNumber): (WebCore::XPath::Parser::lexNCName): (WebCore::XPath::Parser::lexQName): (WebCore::XPath::Parser::nextTokenInternal): (WebCore::XPath::Parser::nextToken): (WebCore::XPath::Parser::Parser): (WebCore::XPath::Parser::reset): (WebCore::XPath::Parser::lex): (WebCore::XPath::Parser::parseStatement): (WebCore::XPath::Parser::registerParseNode): (WebCore::XPath::Parser::unregisterParseNode): (WebCore::XPath::Parser::registerPredicateVector): (WebCore::XPath::Parser::unregisterPredicateVector): (WebCore::XPath::Parser::registerExpressionVector): (WebCore::XPath::Parser::unregisterExpressionVector): (WebCore::XPath::Parser::registerString): (WebCore::XPath::Parser::unregisterString):
  • xpath/impl/XPathParser.h: Added. (WebCore::XPath::Token::Token): (WebCore::XPath::Parser::): (WebCore::XPath::Parser::current):
  • xpath/impl/XPathPath.cpp: Added. (WebCore::XPath::Filter::Filter): (WebCore::XPath::Filter::~Filter): (WebCore::XPath::Filter::doEvaluate): (WebCore::XPath::LocationPath::LocationPath): (WebCore::XPath::LocationPath::~LocationPath): (WebCore::XPath::LocationPath::optimize): (WebCore::XPath::LocationPath::doEvaluate): (WebCore::XPath::Path::Path): (WebCore::XPath::Path::~Path): (WebCore::XPath::Path::doEvaluate):
  • xpath/impl/XPathPath.h: Added.
  • xpath/impl/XPathPredicate.cpp: Added. (WebCore::XPath::Number::Number): (WebCore::XPath::Number::isConstant): (WebCore::XPath::Number::doEvaluate): (WebCore::XPath::StringExpression::StringExpression): (WebCore::XPath::StringExpression::isConstant): (WebCore::XPath::StringExpression::doEvaluate): (WebCore::XPath::Negative::doEvaluate): (WebCore::XPath::NumericOp::NumericOp): (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::EqTestOp::EqTestOp): (WebCore::XPath::EqTestOp::doEvaluate): (WebCore::XPath::LogicalOp::LogicalOp): (WebCore::XPath::LogicalOp::shortCircuitOn): (WebCore::XPath::LogicalOp::isConstant): (WebCore::XPath::LogicalOp::doEvaluate): (WebCore::XPath::Union::doEvaluate): (WebCore::XPath::Predicate::Predicate): (WebCore::XPath::Predicate::~Predicate): (WebCore::XPath::Predicate::evaluate): (WebCore::XPath::Predicate::optimize):
  • xpath/impl/XPathPredicate.h: Added. (WebCore::XPath::NumericOp::): (WebCore::XPath::EqTestOp::): (WebCore::XPath::LogicalOp::):
  • xpath/impl/XPathStep.cpp: Added. (WebCore::XPath::Step::axisAsString): (WebCore::XPath::Step::Step): (WebCore::XPath::Step::~Step): (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeTestMatches): (WebCore::XPath::Step::optimize): (WebCore::XPath::Step::namespaceFromNodetest): (WebCore::XPath::Step::primaryNodeType):
  • xpath/impl/XPathStep.h: Added. (WebCore::XPath::Step::):
  • xpath/impl/XPathUtil.cpp: Added. (WebCore::XPath::isRootDomNode): (WebCore::XPath::stringValue): (WebCore::XPath::isValidContextNode):
  • xpath/impl/XPathUtil.h: Added.
  • xpath/impl/XPathValue.cpp: Added. (WebCore::XPath::Value::Value): (WebCore::XPath::Value::type): (WebCore::XPath::Value::isNodeVector): (WebCore::XPath::Value::isBoolean): (WebCore::XPath::Value::isNumber): (WebCore::XPath::Value::isString): (WebCore::XPath::Value::toNodeVector): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xpath/impl/XPathValue.h: Added. (WebCore::XPath::Value::):
  • xpath/impl/XPathVariableReference.cpp: Added. (WebCore::XPath::VariableReference::VariableReference): (WebCore::XPath::VariableReference::isConstant): (WebCore::XPath::VariableReference::doEvaluate):
  • xpath/impl/XPathVariableReference.h: Added.
11:46 AM Changeset in webkit [14233] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Timothy.

<rdar://problem/4538833> 10.4.7 regression: Mail crashing frequently since updating to SUTiLondon 8J110

  • khtml/editing/markup.cpp: (khtml::createMarkup): add an early return if the range is collapsed
11:01 AM Changeset in webkit [14232] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderBox.h

Remove an outdated comment from RenderBox.

10:49 AM Changeset in webkit [14231] by hyatt
  • 276 edits in trunk/LayoutTests/css2.1

Update layout test results.

10:31 AM Changeset in webkit [14230] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderBox.cpp

Fix typo in variable name.

5:55 AM Changeset in webkit [14229] by jdevalk
  • 2 edits in trunk/WebKitSite

changed checkout guide to point to universal binary.

1:19 AM Changeset in webkit [14228] by hyatt
  • 1 edit in trunk/WebCore/css/html4.css

Backing out caption box-sizing change. I want to do table stuff separately.

1:17 AM Changeset in webkit [14227] by hyatt
  • 3 edits in trunk/WebCore

Comprehensive box-sizing fix. This patch changes all form controls to
have the right box-sizing values (text fields and text areas actually only
use border-box in quirks mode now, and image buttons never use border-box).

Tables are supposed to use border-box box-sizing as well, but that's a scary
enough change that I'm saving it for a separate patch.

Reviewed by mjs

  • css/html4.css:
  • css/quirks.css:
12:11 AM Changeset in webkit [14226] by ap
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

Updated a test case affected by the previous checkin. &rang; and &lang; are
replaced with their canonical equivalents during normalization.

  • fast/parser/entities-in-xhtml-expected.checksum:
  • fast/parser/entities-in-xhtml-expected.txt:

May 7, 2006:

11:00 PM Changeset in webkit [14225] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Tweak change log.

10:31 PM Changeset in webkit [14224] by hyatt
  • 599 edits in trunk/LayoutTests/tables

Land changes to mozilla table tests for bug 8060.

10:24 PM Changeset in webkit [14223] by hyatt
  • 113 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

Land changes to mozilla table tests for bug 8060.

10:21 PM Changeset in webkit [14222] by hyatt
  • 456 edits in trunk/LayoutTests/tables/mozilla/bugs

Land changes to mozilla table tests for bug 8060.

9:59 PM Changeset in webkit [14221] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed and landed by Maciej.


I haven't figured out how to construct a test for this, but this does seem to fix the
problem; Mitz mentioned that a double-destroy was occurring in these functions.


  • kxmlcore/HashMap.h: (KXMLCore::HashMap::remove): Use RefCounter::deref instead of calling ~ValueType, because ~ValueType often results in a double-destroy, since the HashTable also destroys the element based on the storage type. The RefCounter template correctly does work only in cases where ValueType and ValueStorageType differe and this class is what's used elsewhere for the same purpose; I somehow missed this case when optimizing HashMap.
  • kxmlcore/HashSet.h: (KXMLCore::HashSet::remove): Ditto.

WebCore:

Suggested by Mitz. Reviewed and landed by Maciej.


  • dom/Document.cpp: (WebCore::Document::formElementsState): Fixed mistake where the vector has an initial size and instead should have an initial capacity. Harmless in a way, but hurts performance.
9:18 PM Changeset in webkit [14220] by hyatt
  • 82 edits in trunk/LayoutTests/fast/table

Land new results for fast/table to account for bug 8060.

9:14 PM Changeset in webkit [14219] by hyatt
  • 2 edits in trunk/WebCore

Fix for bugzilla bug 8060.

Fixed width table cells weren't having their border widths
included in the effective width of the column (and thus could end up being
too small).

Reviewed by darin

Added fast/tables/fixed-cell-growth.html

  • rendering/table_layout.cpp: (WebCore::AutoTableLayout::recalcColumn):
11:07 AM Changeset in webkit [14218] by ap
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo in te ChangeLog.

11:01 AM Changeset in webkit [14217] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

Tests:

  • fast/forms/form-data-encoding.html
  • fast/forms/form-data-encoding-2.html
  • platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode): Normalize the string; handle surrogate pairs.

May 6, 2006:

1:40 AM Changeset in webkit [14216] by hyatt
  • 16 edits
    2 moves
    1 delete in trunk/WebCore

Rename WebCoreFont to FontPlatformData and WebTextRenderer to FontData. Merge them into the
headers (uncleanly with ifdefs at the moment, so I can see what I'm working towards).

Reviewed by mjs

  • ChangeLog:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontData.h: (WebCore::FontData::ascent): (WebCore::FontData::descent): (WebCore::FontData::lineSpacing): (WebCore::FontData::lineGap): (WebCore::FontData::misspellingLineThickness): (WebCore::FontData::misspellingLinePatternWidth): (WebCore::FontData::misspellingLinePatternGapWidth):
  • platform/FontDataSet.h: Removed.
  • platform/FontFallbackList.h: Added.
  • platform/FontPlatformData.h:
  • platform/mac/FontData.mm: Added. (WebCore::WebCoreInitializeFont): (WebCore::WebCoreInitializeEmptyTextGeometry): (WebCore::widthForGlyph): (WebCore::overrideLayoutOperation): (WebCore::FontData::~FontData): (WebCore::FontData::xHeight): (WebCore::FontData::drawRun): (WebCore::FontData::floatWidthForRun): (WebCore::FontData::drawLineForCharacters): (WebCore::FontData::selectionRectForRun): (WebCore::FontData::drawHighlightForRun): (WebCore::FontData::drawLineForMisspelling): (WebCore::FontData::pointToOffset): (WebCore::FontData::setAlwaysUseATSU): (WebCore::getSmallCapsRenderer): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::computeWidthForSpace): (WebCore::setUpFont): (WebCore::CG_drawHighlight): (WebCore::CG_selectionRect): (WebCore::CG_draw): (WebCore::CG_floatWidthForRun): (WebCore::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::initializeATSUStyle): (WebCore::createATSULayoutParameters): (WebCore::getTextBounds): (WebCore::ATSU_floatWidthForRun): (WebCore::ATSU_drawHighlight): (WebCore::ATSU_selectionRect): (WebCore::ATSU_draw): (WebCore::ATSU_pointToOffset): (WebCore::advanceWidthIteratorOneCharacter): (WebCore::CG_pointToOffset): (WebCore::glyphForCharacter): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::m_font): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::platformFont): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::Font::platformFont): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth): (WebCoreSetAlwaysUseATSU):
  • platform/mac/WebTextRenderer.h: Removed.
  • platform/mac/WebTextRenderer.mm: Removed.
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory isFontFixedPitch:]): (-[WebTextRendererFactory init]): (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):

May 5, 2006:

4:48 PM Changeset in webkit [14215] by darin
  • 2 edits in trunk/WebCore
  • fix the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData):
4:17 PM Changeset in webkit [14214] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by

Merged this fix for:
<rdar://problem/4537287> REGRESSION: All text links are broken at yahoo.com

A recent change to dispatching click events exposed this bug in a new way.

2005-10-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

  • khtml/ecma/kjs_events.cpp: (KJS::DOMEventProtoFunc::callAsFunction): Don't let stopPropagation fall through to preventDefault.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): Don't let stopPropagation prevent calling default event handlers; only preventDefault does that.
3:56 PM Changeset in webkit [14213] by darin
  • 2 edits in trunk/WebCore
  • platform/SegmentedString.h: (WebCore::SegmentedString::advance): Oops! Removed an extra ! that was causing everything to fail.
3:50 PM Changeset in webkit [14212] by darin
  • 19 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • remove a few of the stranger features of QChar on the road to eventually replacing it with an integer type (probably ICU's UChar)
  • platform/DeprecatedString.h: Remove SpecialCharacter, byteOrderMark, null, cell, row, isNull, mirrored, mirroredChar, operator char, >, >=, <, and <= from QChar. Also removed the many unneeded friend declarations. Remove findArg and arg from DeprecatedString.
  • dom/Document.cpp: (WebCore::Document::parseQualifiedName): Cast the type of the buffer before invoking the U16_NEXT function. Turns out this was converting each QChar to a char and back to a UChar, which means it caused a bug with characters that are U+0100 or greater.
  • css/csshelper.cpp: (WebCore::parseURL):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toCoordsArray):
  • xml/xmlhttprequest.cpp: (WebCore::getCharset): Add some calls to unicode() since we don't have comparison operators any more.
  • dom/StyledElement.cpp: (WebCore::toHex): Rewrote to just take a UChar parameter. (WebCore::StyledElement::addCSSColor): Call toHex on the character code.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextBox):
  • platform/SegmentedString.h: (WebCore::SegmentedString::push): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::length): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::toString): Changed calls to isNull() to instead just use unicode() and check for 0.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity): Change callers that used cell and row to just use unicode() instead. (WebCore::HTMLTokenizer::parseTag): Ditto.
  • loader/Decoder.cpp: (Decoder::decode): Changed code that did a type cast to unsigned char to instead call unicode().
  • platform/DeprecatedString.cpp: (KWQStringData::makeAscii): Call latin1() instead of relying on the conversion operator. (DeprecatedString::DeprecatedString): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::at): Use 0 instead of QChar::null. (DeprecatedString::compare): Use unicode() so we can do comparison since we don't have comparison operators any more. (DeprecatedString::find): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::findRev): Ditto. (DeprecatedString::copyLatin1): Call latin1() instead of relying on the conversion operator. (DeprecatedString::lower): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::insert): Ditto. (DeprecatedString::replace): Ditto. (DeprecatedString::fill): Ditto. (DeprecatedString::append): Ditto.
  • html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Eliminate the one use of DeprecatedString::arg.
  • other cleanup
  • kwq/KWQCString.cpp: Remove unneeded "using" directive.
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor): (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor): (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::preConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::modConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableColConstructor): (WebCore::tableRowConstructor): (WebCore::tableCellConstructor): (WebCore::tableSectionConstructor): (WebCore::brConstructor): (WebCore::quoteConstructor): (WebCore::marqueeConstructor): Mark functions static, remove unused parameters, change from docPtr to doc.
1:35 PM Changeset in webkit [14211] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

Test: fast/parser/broken-comments-vs-parsing-mode.html

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Call determineParseMode() if needed.
1:30 PM Changeset in webkit [14210] by darin
  • 2 edits in trunk/WebCore
  • fix the Windows build (this time for sure)
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::translate): Added. (GraphicsContext::rotate): Ditto. (GraphicsContext::scale): Ditto.
9:53 AM Changeset in webkit [14209] by darin
  • 3 edits in trunk/WebCore
  • fix the Windows build
  • bridge/win/FrameWin.h: Add Element* parameter to createPlugin.
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): Ditto.
9:37 AM Changeset in webkit [14208] by darin
  • 3 edits in trunk/WebCore
  • get the Window build a little closer to building again
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Call alpha to check if the color is transparent. Call setColor directly instead of setColorFromPen. (WebCore::GraphicsContext::drawLine): Ditto. (WebCore::GraphicsContext::drawEllipse): Ditto. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: (JavaAppletWidget::JavaAppletWidget): Updated parameter types.
8:22 AM Changeset in webkit [14207] by darin
  • 33 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • manual-tests/form-value-restore.html: Added.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Rewrote to call the new formElementsState function on the document and also to convert null strings to NSNull instead of empty NSString objects. (-[WebCoreFrameBridge restoreDocumentState]): Ditto, with the setStateForNewFormElements function.
  • dom/Document.h: Added FormElementKey, FormElementKeyHash, and FormElementKeyHashTraits for use in the hash map. Made readyState, inputEncoding, defaultCharset, charset, characterSet, getElementByAccessKey, haveStylesheetsLoaded, usesDescendantRules, usesSiblingRules, inCompatMode, inAlmostStrictMode, inStrictMode, preferredStylesheetSet, selectedStylesheetSet, and getCSSTarget all const member functions. Removed the unused nextState function. Renamed registerMaintainsState and deregisterMaintainsState to registerFormElementWithState and HTMLGenericFormElement and changed them to use form elements rather than arbitrary DOM nodes. Replaced docState with formElementsState and setRestoreState and restoreState with setStateForNewFormElements, hasStateForNewFormElements, and takeStateForFormElement. Replaced m_maintainsState with m_formElementsWithState, m_state with m_stateForNewFormElements. Made m_elementsByAccessKey and m_accessKeyMapValid mutable. Removed unused m_elementNames, m_elementNameAlloc, m_elementNameCount, m_attrNames, m_attrNameAlloc, m_attrNameCount, m_namespaceURIs, m_namespaceURIAlloc, m_namespaceURICount.
  • dom/Document.cpp: (WebCore::Document::Document): Remove initialization of long-obsolete m_elementNames and m_attrNames. (WebCore::Document::~Document): Remove destruction of same. (WebCore::Document::readyState): Made const. (WebCore::Document::inputEncoding): Ditto. (WebCore::Document::defaultCharset): Ditto. (WebCore::Document::getElementByAccessKey): Ditto. (WebCore::Document::preferredStylesheetSet): Ditto. (WebCore::Document::selectedStylesheetSet): Ditto. (WebCore::Document::getCSSTarget): Ditto. (WebCore::Document::formElementsState): Added. Replaces the old docState function. Builds a vector of strings, with 3 strings for each form element containing the name, type, and state value. (WebCore::Document::setStateForNewFormElements): Added. Converts the state vector into a hash map, considering the scheme with 3 strings for form element used above. (WebCore::Document::hasStateForNewFormElements): Added. (WebCore::Document::takeStateForFormElement): Added. Given a name and type, looks up the values in the hash map and "peels off" the last one. (WebCore::FormElementKey::FormElementKey): Added. (WebCore::FormElementKey::~FormElementKey): Added. (WebCore::FormElementKey::operator=): Added. (WebCore::FormElementKey::ref): Added. (WebCore::FormElementKey::deref): Added. (WebCore::FormElementKeyHash::hash): Added. (WebCore::FormElementKeyHashTraits::deletedValue): Added.
  • dom/Element.h: Removed state function.
  • dom/Node.h: Removed maintainsState, state, and restoreState functions.
  • dom/Node.cpp: Ditto.
  • dom/QualifiedName.cpp: Reformatted. (WebCore::hashComponents): Removed code to handle buffers that are not multiples of 4 bytes, since a QualifiedName is guaranteed to be; also asserted that fact.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Remove code to restore state; that's now handled by closeRenderer. (WebCore::HTMLParser::popOneBlock): Ditto.
  • html/HTMLFormElement.cpp: Added include of HTMLInputElement.h.
  • html/HTMLGenericFormElement.h: Changed form to be a const member function. Changed type function to return a const AtomicString& instead of a String. Added an override of closeRenderer. Removed state and findMatchingState functions. Added stateValue and restoreState functions. Made m_form, m_disabled, and m_readOnly be private instead of protected. Removed m_inited. Changed booleans to not use bit fields since there are only two of them.
  • html/HTMLGenericFormElement.cpp: Removed encodedElementName, state, and findMatchingState functions. (WebCore::HTMLGenericFormElement::stateValue): Added. No implementation. This will only be called for subclasses that call registerFormElementWithState, and those will override and implement it. (WebCore::HTMLGenericFormElement::restoreState): Ditto. (WebCore::HTMLGenericFormElement::closeRenderer): Added. Replaces code that was in the HTML parser. Calls takeStateForFormElement, passing in the name and type, and if a state is found, calls restoreState.
  • html/HTMLButtonElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Return a const AtomicString& instead of a String. (WebCore::HTMLButtonElement::defaultEventHandler): Use form() instead of m_form. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Use disabled() instead of m_disabled.
  • html/HTMLInputElement.h: Changed type to return a const AtomicString& instead of a String. Removed maintainsState, state, and restoreState functions, and added new stateValue and restoreState functions. Added m_inited (moved here from the generic form element base class).
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Call registerFormElementWithState. This was formerly done by the HTML parser. (WebCore::HTMLInputElement::~HTMLInputElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLInputElement::isKeyboardFocusable): Use form() instead of m_form. (WebCore::HTMLInputElement::setType): Ditto. (WebCore::HTMLInputElement::setInputType): Ditto. Also call inputType() != PASSWORD instead of maintainsState(), since this is the only function that needs to know the rule and it's no longer a function in the base class. Also call register and deregister functions by their new names. (WebCore::HTMLInputElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLInputElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to no longer modify the value() string by adding a ".", which gets in the way of distinguishing null and empty values and is slower and unnecessary. (WebCore::HTMLInputElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState, and also to no longer remove the last character from the value when restoring state. (WebCore::HTMLInputElement::parseMappedAttribute): Use form() instead of m_form. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Use disabled() instead of m_disabled. (WebCore::HTMLInputElement::setChecked): Use form() instead of m_form. (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
  • html/HTMLSelectElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Call registerFormElementWithState. This was formerly done by the HTML parser. (WebCore::HTMLSelectElement::~HTMLSelectElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLSelectElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLSelectElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to build the string in a Vector<char> instead of appending characters one at a time to a string. (WebCore::HTMLSelectElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState. (WebCore::HTMLSelectElement::defaultEventHandler): Use form() instead of m_form.
  • html/HTMLTextAreaElement.h: Changed type to return a const AtomicString& instead of a String. Removed maintainsState, state, and restoreState functions, and added new stateValue and restoreState functions.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Call registerFormElementWithState. This was formerly done by the HTML parser. Also use member initialization instead of assignment. (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLTextAreaElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLTextAreaElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to no longer modify the value() string by adding a ".", which is unnecessary. (WebCore::HTMLTextAreaElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState, and also to no longer remove the last character from the value when restoring state. (WebCore::HTMLTextAreaElement::updateValue): Changed to const. (WebCore::HTMLTextAreaElement::value): Ditto. (WebCore::HTMLTextAreaElement::defaultValue): Ditto.
  • html/HTMLFieldSetElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto.
  • html/HTMLKeygenElement.h: Ditto.
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto.
  • html/HTMLLegendElement.h: Ditto.
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type):
  • html/HTMLOptGroupElement.h: Ditto.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto.
  • html/HTMLOptionElement.h: Ditto.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto.
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer): Added missing call to base class.
  • rendering/render_form.h: Removed element() functions that cast to the appropriate derived element class. They do make some bits of code slightly more readable, but they also require including too many headers. Removed the includes of HTMLInputElement.h, HTMLSelectElement.h, HTMLTextAreaElement.h, and KWQLineEdit.h, and added an include of GraphicsTypes.h.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::updateFromElement): Changed use of element() to instead use node() and cast. (WebCore::RenderFormElement::clicked): Ditto. (WebCore::RenderLineEdit::selectionChanged): Ditto. (WebCore::RenderLineEdit::returnPressed): Ditto. (WebCore::RenderLineEdit::performSearch): Ditto. (WebCore::RenderLineEdit::addSearchResult): Ditto. (WebCore::RenderLineEdit::calcMinMaxWidth): Ditto. (WebCore::RenderLineEdit::setStyle): Ditto. (WebCore::RenderLineEdit::updateFromElement): Ditto. (WebCore::RenderLineEdit::valueChanged): Ditto. (WebCore::RenderFileButton::calcMinMaxWidth): Ditto. (WebCore::RenderFileButton::updateFromElement): Ditto. (WebCore::RenderFileButton::returnPressed): Ditto. (WebCore::RenderFileButton::valueChanged): Ditto. (WebCore::RenderSelect::updateFromElement): Ditto. (WebCore::RenderSelect::layout): Ditto. (WebCore::RenderSelect::valueChanged): Ditto. (WebCore::RenderSelect::selectionChanged): Ditto. (WebCore::RenderSelect::updateSelection): Ditto. (WebCore::RenderTextArea::destroy): Ditto. (WebCore::RenderTextArea::calcMinMaxWidth): Ditto. (WebCore::RenderTextArea::setStyle): Ditto. (WebCore::RenderTextArea::updateFromElement): Ditto. (WebCore::RenderTextArea::valueChanged): Ditto. (WebCore::RenderTextArea::selectionChanged): Ditto. (WebCore::RenderSlider::updateFromElement): Ditto. (WebCore::RenderSlider::valueChanged): Ditto.
8:09 AM Changeset in webkit [14206] by darin
  • 4 edits in trunk

JavaScriptCore:

  • kjs/date_object.cpp: (KJS::parseDate): Merged change that George Staikos provided from KDE 3.4.3 branch that allows day values of 0 and values that are > 1000.

LayoutTests:

  • fast/js/kde/resources/Date.js: Added test cases that George Staikos provided that test dates with day values of 0, 55, and 452.
8:08 AM Changeset in webkit [14205] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added name of test.

7:59 AM Changeset in webkit [14204] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8563>

Tests that the name, publicID and systemID are all read correctly
and that the doctype object preserves the case of the
components from the source html:

  • fast/doctypes/005-case-preserving.html: Added.
  • fast/doctypes/005-case-preserving-expected.txt: Added.

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8563

The doctype object in the DOM is now usable by client code
as opposed to always being exposed as nil. Now also ensures that
the 'name' of the component preserves the case of the original html source.
(i.e HtMl -> HtMl not HTML)

  • dom/Document.h: Changes comment by docType() to say it may return 0 for html
  • html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration): (WebCore::HTMLDocument::determineParseMode): Preserves the case of the name component (WebCore::HTMLDocument::doctype):removed
  • html/HTMLDocument.h: (WebCore::HTMLDocument::doctype):removed
7:49 AM Changeset in webkit [14203] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8651:
[DOMHTMLSelectElement multiple] returns no when the select element is multiple

Correct the logic errors, which are clearly indicated by the changeset given
in the bug report.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLLinkElement disabled]): (-[DOMHTMLSelectElement disabled]): (-[DOMHTMLSelectElement multiple]): (-[DOMHTMLOptGroupElement disabled]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement disabled]):

May 4, 2006:

9:30 PM Changeset in webkit [14202] by darin
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick.

  • fix storage leak I introduced yesterday
  • platform/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): Added. (WebCore::setCGStrokeColor): Added. (WebCore::GraphicsContext::drawRect): Use setCGFillColor to avoid allocating a CGColorRef object. (WebCore::GraphicsContext::drawLine): Use setCGStrokeColor and setCGFillColor to avoid allocating a CGColorRef object. (WebCore::GraphicsContext::drawEllipse): Ditto. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillRect): Ditto.
9:29 PM Changeset in webkit [14201] by darin
  • 3 edits
    1 copy
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

  • plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Added.
  • plugins/pluginDocumentView-deallocated-dataSource.html: Added.
  • plugins/resources: Added.
  • plugins/resources/orange.mov: Added.

WebKit:

Reviewed by Darin.

Test: plugins/pluginDocumentView-deallocated-dataSource.html

  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release the dataSource. (-[WebPluginDocumentView setDataSource:]): Retain the dataSource.
9:25 PM Changeset in webkit [14200] by thatcher
  • 1 copy in tags/WebKit-418.3/WebKit

Tag for WebKit 418.3 (part 2 of 2.)

9:25 PM Changeset in webkit [14199] by thatcher
  • 1 add in tags/WebKit-418.3

Tag for WebKit 418.3 (part 1 of 2.)

9:22 PM Changeset in webkit [14198] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

9:20 PM Changeset in webkit [14197] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/WebView.subproj/WebFrameView.m

GCC 3 Build fix for warning: 'return' with a value, in function returning void.

9:19 PM Changeset in webkit [14196] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebFrameView.m

Build fix, warning: 'return' with a value, in function returning void.

6:43 PM Changeset in webkit [14195] by justing
  • 12 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

Pasted content would end up inside the block that contained the end of
the selection that was pasted into and not the block that contained
the start of the selection that was pasted into:

  • editing/pasteboard/merge-end-5-expected.checksum: Added.
  • editing/pasteboard/merge-end-5-expected.png: Added.
  • editing/pasteboard/merge-end-5-expected.txt: Added.
  • editing/pasteboard/merge-end-5.html: Added.


Inserting a paragraph separator was splitting and cloning the body element
if the html element was editable:

  • editing/inserting/editable-html-element-expected.checksum: Added.
  • editing/inserting/editable-html-element-expected.png: Added.
  • editing/inserting/editable-html-element-expected.txt: Added.
  • editing/inserting/editable-html-element.html: Added.


Since we now sometimes merge backward (from content already in the
document to just inserted content) during the end merge, the node that
contains the old caret is removed more often during paste. The editing
delegate notifications in these tests reflect this:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:


Now demonstrates a bug where the html element is focused, but its contents
aren't selected:

  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:
  • editing/selection/focus_editable_html.html:

WebCore:

Reviewed by harrison

  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Restored code to stop at the body tag. Editing shouldn't be allowed to happen outside the body, so it needs to be the editable root even if the html element is contentEditable.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Now takes in more information so it can be "the decider". (WebCore::ReplaceSelectionCommand::doApply): Merging two paragraphs will destroy the moved one's block styles. Perform the end merge backward (from content already in the document to just inserted content) if moving forward would move the paragraph that contained the start of the selection being pasted into, since we always want to preserve that paragraph's block style. Moving backward in this case is also helpful because otherwise it would be difficult to remember the position where inserted content began (since merging would remove m_firstNodeInserted). That position is needed in order to select the replacement and to add smart replace whitespace. (WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded): If [br, 0] is at the end of a block, the br is not necessarily collapsed in quirks mode. [br, 0] needs to also not be at the start of a block.


  • editing/ReplaceSelectionCommand.h:
5:58 PM Changeset in webkit [14194] by tomernic
  • 7 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4537606> Give Java WebKit plugin access to its own DOM element

  • bridge/mac/WebCoreFrameBridge.h: Added DOMElement parameter to -viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:.
  • bridge/JavaAppletWidget.h: Constructor now takes the applet's element instead of its containing frame.
  • bridge/mac/JavaAppletWidget.mm: (JavaAppletWidget::JavaAppletWidget): Pass the applet's element to viewForJavaAppletWithFrame:.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary): Pass the element along to JavaAppletWidget.

WebKit:

Reviewed by Darin.

<rdar://problem/4537606> Give Java WebKit plugin access to its own DOM element

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): Pass the DOMElement to the plugin if it's a WebKit plugin (we need to handle Netscape plugins differently).
5:35 PM Changeset in webkit [14193] by thatcher
  • 1 copy in tags/WebKit-418.2/WebKit

Tag for WebKit 418.2 (part 2 of 2.)

5:33 PM Changeset in webkit [14192] by thatcher
  • 1 add in tags/WebKit-418.2

Tag for WebKit 418.2 (part 1 of 2.)

5:33 PM Changeset in webkit [14191] by thatcher
  • 1 copy in tags/WebCore-418.1/WebCore

Tag for WebCore 418.1 (part 2 of 2.)

5:33 PM Changeset in webkit [14190] by thatcher
  • 1 add in tags/WebCore-418.1

Tag for WebCore 418.1 (part 1 of 2.)

5:32 PM Changeset in webkit [14189] by thatcher
  • 1 copy in tags/JavaScriptCore-418.1/JavaScriptCore

Tag for JavaScriptCore 418.1 (part 2 of 2.)

5:32 PM Changeset in webkit [14188] by thatcher
  • 1 add in tags/JavaScriptCore-418.1

Tag for JavaScriptCore 418.1 (part 1 of 2.)

5:02 PM Changeset in webkit [14187] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning

4:54 PM Changeset in webkit [14186] by thatcher
  • 14 edits in branches/Safari-2-0-branch

WebCore:

Reviewed by Harrison.

<rdar://problem/4523536> SUTiLondon: Dashcode removes commented code from HTML files

  • khtml/editing/markup.cpp: (khtml::endMarkup):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createTokenizer):
  • khtml/html/html_documentimpl.h: (DOM::HTMLDocumentImpl::isHTMLDocument):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::setIncludesComments): (khtml::HTMLTokenizer::includesComments):
  • khtml/html/htmltokenizer.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removedLastRef): (DocumentImpl::documentElement):
  • khtml/xml/dom_docimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (+[WebCoreBridge includesCommentsInDOM]): (+[WebCoreBridge setIncludesCommentsInDOM:]):

WebKit:

Reviewed by Harrison.

<rdar://problem/4523536> SUTiLondon: Dashcode removes commented code from HTML files

  • WebView.subproj/WebView.m: (+[WebView _includesCommentsInDOM]): (+[WebView _setIncludesCommentsInDOM:]):
  • WebView.subproj/WebViewPrivate.h:
4:03 PM Changeset in webkit [14185] by tomernic
  • 10 edits in trunk

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4480186> Give WebKit plugins access to their own DOM element

  • bridge/mac/WebCoreFrameBridge.h: Added DOMElement: parameter to -viewForPluginWithURL:attributeNames:attributueValues:MIMEType:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createPlugin): Added "element" parameter; wrap element in DOMElement and pass up to the bridge.
  • page/Frame.h: Added "element" parameter to createPlugin().
  • page/Frame.cpp: (WebCore::Frame::loadPlugin): Get the plugin's DOM element and pass to createPlugin().

WebKit:

Reviewed by John Sullivan.

<rdar://problem/4480186> Give WebKit plugins access to their own DOM element

This does not fix <rdar://problem/4480187> Give Netscape plugins access to their own DOM element --
we're not going to use the ObjC DOM API for that, but rather the NP bindings API.

  • Plugins/WebPluginPackage.m: Declared WebPlugInContainingElementKey. This is not a new plugin argument -- it's been in our public headers since all along, but has never been concretely declared -- plugins that referenced it would not link.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:]): Added DOMElement parameter, which is now included in the plugin arguments dictionary. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:]): ditto
  • WebKit.exp: Export WebPlugInContainingElementKey.
1:37 PM Changeset in webkit [14184] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-05-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8734
Would like a Vector::append that takes another Vector


  • kxmlcore/Vector.h: (KXMLCore::::append): New function that takes another array.
1:08 PM Changeset in webkit [14183] by justing
  • 5 edits in branches/Safari-2-0-branch/WebCore

Reviewed by thatcher


Used the StayInBlock variant of upstream/downstream since they behave that way in
tip of tree (where there is no StayInBlock parameter).

11:26 AM Changeset in webkit [14182] by eseidel
  • 2 edits
    1 add in trunk/WebCore

2006-05-04 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Add drag & drop support to <input type="file">
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8733

Test: manual/input-type-file-drag-drop.html

  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton changeFilename:]): (-[WebCoreFileButton chooseFilename:]): (validFilenameFromPasteboard): (-[WebCoreFileButton draggingEntered:]): (-[WebCoreFileButton draggingExited:]): (-[WebCoreFileButton performDragOperation:]):
11:20 AM Changeset in webkit [14181] by bdakin
  • 13 edits in trunk

--This

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8732
Backgrounds with background-size and background-origin do not
always lay out correctly

  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawTiled): We no longer need to scale the source point since it will now come in with the scale already taken into account.
  • platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Same as above.
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Now calculate the background size in a helper method. (WebCore::RenderBox::paintBackgroundExtended): Calculate the background size before calculating cx, cy, cw, ch, sx, and sy so that they can all be calculated with the scaled image size taken into account.

M LayoutTests/ChangeLog
M LayoutTests/fast/backgrounds/size/backgroundSize18-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize12-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize19-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize10-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize18-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize19-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize10-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize12-expected.checksum
M WebCore/platform/mac/ImageMac.mm
M WebCore/platform/cairo/ImageCairo.cpp
M WebCore/rendering/RenderBox.cpp
M WebCore/ChangeLog

11:10 AM Changeset in webkit [14180] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/Plugins.subproj/WebPluginController.m

Speculative build fix for B&I.

11:04 AM Changeset in webkit [14179] by hyatt
  • 4 edits in trunk/WebCore

Fix for 8693, crash when reloading PDF. Make sure to clear the truncator's
cached renderer.

Reviewed by beth

  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm: (+[WebCoreStringTruncator clear]):
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory clearCaches]):
10:42 AM Changeset in webkit [14178] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch


This fixes: <rdar://problem/4211296> right side of page is clipped when printing to PDF

2005-12-08 John Sullivan <​sullivan@apple.com>

Reviewed by Tim O.


  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.

May 3, 2006:

5:48 PM Changeset in webkit [14177] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Build fix for WebCore.

5:02 PM Changeset in webkit [14176] by thatcher
  • 8 edits
    22 adds
    5 deletes in branches/Safari-2-0-branch/JavaScriptCore

2006-05-03 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2005-11-06 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

Our UTF16-modified PCRE didn't work with extended character classes
(classes involving characters > 255) because it used the GETCHARINC
macro to read through them. In UTF16 mode, GETCHARINC expects UTF16
input, but PCRE encodes character classes in UTF8 regardless of the
input mode of the subject string.

The fix is to explicitly define GETUTF8CHARINC, and to use it,
rather than GETCHARINC, when reading extended character classes.


In UTF8 mode, we simply define GETCHARINC to be GETUTF8CHARINC.

  • pcre/pcre_internal.h:
  • pcre/pcre_xclass.c: (_pcre_xclass):

2006-05-03 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2005-09-29 Eric Seidel <​eseidel@apple.com>

Fix from Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin.

Fix JSC memory smasher in TOT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5176

  • pcre/pcre_exec.c: (match):

2006-05-03 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2005-09-08 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • updated to PCRE 6.1

The original PCRE 6.1 sources are checked into the tree with the tag
"pcre-6-1" for reference. What we're checking in right now is the original
plus our changes to make it support UTF-16 and at least one other tweak
(vertical tab considered whitespace). Our work to get our changes was
done on "pcre-6-1-branch", with an anchor at "pcre-6-1-anchor" so you can
see the evolution of the UTF-16 changes.


Note also that there was one small change made here that's not on the branch
in pcre_compile.c.

  • Info.plist: Updated the part of the copyright message that's about PCRE.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new PCRE source files, removed obsolete ones.
  • pcre/AUTHORS: Updated to PCRE 6.1. Includes credits for Apple's UTF-16 changes, but not the credits for Google's C++ wrapper, since we don't include that.
  • pcre/COPYING: Updated to PCRE 6.1.
  • pcre/LICENCE: Ditto.
  • pcre/dftables.c: Ditto.
  • pcre/pcre-config.h: Ditto.
  • pcre/pcre.h: Ditto.
  • pcre/pcre_compile.c: Added for PCRE 6.1.
  • pcre/pcre_config.c: Ditto.
  • pcre/pcre_exec.c: Ditto.
  • pcre/pcre_fullinfo.c: Ditto.
  • pcre/pcre_get.c: Ditto.
  • pcre/pcre_globals.c: Ditto.
  • pcre/pcre_info.c: Ditto.
  • pcre/pcre_internal.h: Ditto.
  • pcre/pcre_maketables.c: Ditto.
  • pcre/pcre_ord2utf8.c: Ditto.
  • pcre/pcre_printint.c: Ditto.
  • pcre/pcre_refcount.c: Ditto.
  • pcre/pcre_study.c: Ditto.
  • pcre/pcre_tables.c: Ditto.
  • pcre/pcre_try_flipped.c: Ditto.
  • pcre/pcre_ucp_findchar.c: Ditto.
  • pcre/pcre_version.c: Ditto.
  • pcre/pcre_xclass.c: Ditto.
  • pcre/ucp.h: Ditto.
  • pcre/ucp_findchar.c: Ditto.
  • pcre/ucpinternal.h: Ditto.
  • pcre/ucptable.c: Ditto.
  • pcre/get.c: Removed.
  • pcre/internal.h: Removed.
  • pcre/maketables.c: Removed.
  • pcre/pcre.c: Removed.
  • pcre/study.c: Removed.
2:35 PM Changeset in webkit [14175] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Tim H.

<rdar://problem/4536009> REGRESSION: Printing embedded plugins crashes on Safari-2-0-branch, but not in TOT


Merge over npapi.h from the r14154 JavaScriptCore change.

  • Plugins.subproj/npapi.h:
2:15 PM Changeset in webkit [14174] by darin
  • 12 edits
    1 copy in trunk/WebCore

Reviewed by Eric.

  • WebCore.xcodeproj/project.pbxproj: Added GraphicsContextCG.cpp.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): Use new GraphicsContext function. (WebCore::CanvasRenderingContext2D::rotate): Ditto. (WebCore::CanvasRenderingContext2D::translate): Ditto.
  • kwq/KWQComboBox.mm: Added include (not sure if this is needed for this patch, but it's needed for one of my upcoming ones).
  • platform/GraphicsContext.h: Changed fillColor and setFillColor to use Color instead of RGBA32. Removed setColorFromFillColor and setColorFromPen. Added scale, rotate, and translate functions.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::setFillColor): Changed to use Color instead of RGBA32. (WebCore::GraphicsContext::fillColor): Ditto.
  • platform/GraphicsTypes.h: Moved HorizontalAlignment here.
  • platform/Widget.h: Removed HorizontalAlignment from here.
  • platform/cg/GraphicsContextCG.cpp: Added. Started as a copy of GraphicsContextMac.mm. (WebCore::GraphicsContext::drawRect): Rewrote to not rely on [NSGraphicsContext currentContext]. (WebCore::GraphicsContext::drawLine): Ditto. (WebCore::GraphicsContext::drawEllipse): Ditto. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::setLineWidth): Added check of paintingDisabled(). (WebCore::GraphicsContext::setMiterLimit): Ditto. (WebCore::GraphicsContext::setAlpha): Ditto. (WebCore::GraphicsContext::clearRect): Ditto. (WebCore::GraphicsContext::strokeRect): Ditto. (WebCore::GraphicsContext::setLineCap): Ditto. (WebCore::GraphicsContext::setLineJoin): Ditto. (WebCore::GraphicsContext::clip): Ditto. (WebCore::GraphicsContext::scale): Added. (WebCore::GraphicsContext::rotate): Added. (WebCore::GraphicsContext::translate): Added.
  • platform/mac/GraphicsContextMac.mm: Moved most of this file into GraphicsContextCG.cpp. (WebCore::GraphicsContext::setCompositeOperation): Added check of paintingDisabled().
  • platform/mac/WebCoreSystemInterface.h: Added declarations so this header stands alone.
1:28 PM Changeset in webkit [14173] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-04 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting


Rewrote moveNodesAfterNode to address these problems:
It moved nodes without preserving their style.
It traversed over siblings looking for a br to know when
to stop merging. If the br was burried inside a span, it
wouldn't find it. If the text is whitespace:pre, it wouldn't
stop.
In theory it would crash if the "enclosingInlineElements" of the start of the
selection to delete and the end of the selection to delete were the
same. We think that this will fix these:
<rdar://problems/3950559&4498113>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
But we haven't been able to construct a reproducible case.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand. (WebCore::CompositeEditCommand::prune): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/DeleteSelectionCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::):
  • editing/markup.cpp: (WebCore::createMarkup): Was crashing when passed a collapsed range. I early return an empty string instead.
12:32 PM Changeset in webkit [14172] by darin
  • 58 edits
    19 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/input-text-click-inside-expected.png: Added.
  • fast/forms/input-text-click-inside-expected.txt: Added.
  • fast/forms/input-text-click-inside-expected.checksum: Added.
  • fast/forms/input-text-click-inside.html: Added.
  • fast/forms/input-text-click-outside-expected.png: Added.
  • fast/forms/input-text-click-outside-expected.txt: Added.
  • fast/forms/input-text-click-outside-expected.checksum: Added.
  • fast/forms/input-text-click-outside.html: Added. Test clicks both inside and outside an input element.
  • editing/selection/contenteditable-click-inside-expected.png: Added.
  • editing/selection/contenteditable-click-inside-expected.txt: Added.
  • editing/selection/contenteditable-click-inside-expected.checksum: Added.
  • editing/selection/contenteditable-click-inside.html: Added.
  • editing/selection/contenteditable-click-outside-expected.png: Added.
  • editing/selection/contenteditable-click-outside-expected.txt: Added.
  • editing/selection/contenteditable-click-outside-expected.checksum: Added.
  • editing/selection/contenteditable-click-outside.html: Added. Added a test for the same situation, but with a div element set to have editable content.
  • editing/inserting/insert-3851164-fix-expected.txt:
  • editing/inserting/insert-3851164-fix.html:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-3907422-fix.html:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-011.html: Update some tests that were relying on a bug that would cause a Select All in a document that contained a single content-editable element select the contents of that element.
  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/drag-into-marker.html: Changed test so that it no longer tests what happens when you drag to a marker that is outside the content-editable element. We may still want to make that case behave as before, but that's a separate issue.
  • editing/pasteboard/drop-text-without-selection-expected.txt:
  • editing/pasteboard/merge-start-blockquote-expected.txt:
  • editing/pasteboard/merge-start-list-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • fast/events/div-focus-expected.txt:
  • fast/events/drag-outside-window-expected.txt:
  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/input-changing-value-expected.txt:
  • fast/forms/input-maxlength-2-expected.txt:
  • fast/forms/input-paste-undo-expected.txt:
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/forms/input-truncate-newline-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/text/textIteratorNilRenderer-expected.txt: Update tests where the DOM range endpoints passed to the delegate are slightly different, but equivalent and still OK.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Updated tests where the resulting tree is slightly different, but still OK.
  • editing/unsupported-content/list-delete-002-expected.checksum:
  • editing/unsupported-content/list-delete-002-expected.png:
  • editing/unsupported-content/list-delete-002-expected.txt: Update test where the new code eliminates an unwanted extra space that we got with the old code.
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-4038408-fix.html:
  • editing/input/text-input-controller-expected.txt:
  • editing/input/text-input-controller.html:
  • fast/forms/attributed-strings-expected.txt:
  • fast/forms/attributed-strings.html: Update tests that were relying on the behavior of Select All putting the selection inside a content-editable element if that element was the first in the body; the patch breaks that behavior.
  • fast/events/updateLayoutForHitTest-expected.checksum:
  • fast/events/updateLayoutForHitTest-expected.png: Update a test that no longer shows a visible selection.
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690703-expected.txt: Updated results for these tests, which have examples of form elements inside a content-editable area. The old results were wrong; the new results are not much better, but are OK.
  • update some other misc. pixel-test results
  • fast/inspector/style-expected.checksum:
  • fast/inspector/style-expected.png: Updated since the name changed to include "-webkit-".
  • fast/overflow/childFocusRingClip-expected.checksum:
  • fast/overflow/childFocusRingClip-expected.png: Updated results that now seem to show correct clipping of the focus ring.
  • fast/frames/empty-cols-attribute-expected.checksum:
  • fast/frames/empty-cols-attribute-expected.png: Added. Checksum was wrong, png was missing.
  • fast/parser/001-expected.checksum:
  • fast/parser/001-expected.png: Checksum and png were incorrect -- changed a while back.
  • plugins/embed-attributes-style-expected.checksum: Added.
  • plugins/embed-attributes-style-expected.png: Added. Added pixel-test results for tests that don't have them.

WebCore:

Reviewed by Justin.

This bug has always been present for "content editable" HTML, but
now affects <input type=text> as well. The problem is with the editing
concept of a "deep equivalent". When computing the deep equivalent,
the code can move from outside an editable area to inside. To fix this,
I removed all use of the "deep equivalent" concept.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Changed argument names from _x and _y to just x and y. When the element is the editable root, changed things so that clicks that are not within the element at all return positions before or after the element, rather than always choosing the closest point within the element. This gets us off on the right foot, by not choosing a position inside an editable root when you click outside that editable root. This code handles shadowParentNode as well, and also calls positionForCoordinates on children rather than calling positionForRenderer (which I believe is now a function that can be removed).
  • editing/VisiblePosition.h: Removed the deepEquivalent function.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::previousVisiblePosition): Removed use of the deepEquivalent function. Also, to make this function easier to understand I separated out the case where the start point is "in rendered content" and the case where it's not into two separate loops. (WebCore::VisiblePosition::nextVisiblePosition): Ditto. (WebCore::VisiblePosition::initDeepPosition): Removed use of the deepEquivalent function. Also added code to make sure that this work never turns a position outside an editable element into a position inside that editable element, or vice versa. Reorganized the code a bit.
  • dom/Position.cpp: (WebCore::Position::upstream): Removed use of the deepEquivalent function. (WebCore::Position::downstream): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Changed to use isReplaced instead of isWidget and isImage to determine if editing should ignore content. (WebCore::firstInSpecialElement): Rewrote isFirstVisiblePositionInSpecialElement to have code to share with positionBeforeContainingSpecialElement. And changed to allow both the position just before a table and the position just inside a table to qualify. While this is slightly sloppy, the old code worked because of the "deep equivalent" technique. This change is needed to get the desired results even without that technique. (WebCore::lastInSpecialElement): Ditto. (WebCore::isFirstVisiblePositionInSpecialElement): Changed to use the new function. (WebCore::positionBeforeContainingSpecialElement): Ditto. (WebCore::isLastVisiblePositionInSpecialElement): Ditto. (WebCore::positionAfterContainingSpecialElement): Ditto.
  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Rewrote to remove special case for body tag.
  • other changes
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterHTML): Added a FIXME about the fact that this won't merge neighboring text nodes the way setOuterText does. (WebCore::HTMLElement::setInnerText): Added a FIXME about the fact that this creates a text node even when setting to empty text. (WebCore::HTMLElement::setOuterText): Ditto.
  • editing/DeleteSelectionCommand.cpp: Removed some #if 1 and #if 0.
  • editing/ReplaceSelectionCommand.cpp: A little reformatting.
  • rendering/render_button.h: Tiny formatting tweak.
12:32 PM Changeset in webkit [14171] by tomernic
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-04 Tim Omernick <​timo@apple.com>

Reviewed by Dave Harrison, John Sullivan.

<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)

I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
initialized. Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
has been "committed" (inserted into the view hierarchy).

My fix is to ensure that the plugin is initialized where we previously would have created that second
WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.


  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy. We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView has been committed.
Note: See TracTimeline for information about the timeline view.