⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 3, 2006:

7:35 PM Changeset in webkit [15149] by ggaren
  • 13 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • Refined value conversions in the API:
    • failed toNumber returns NaN
    • failed toObject returns NULL
    • failed toString returns empty string


  • Refined excpetion handling in the API:
    • failed value conversions do not throw exceptions
    • uncaught exceptions in JSEvaluate, JSObjectCallAsFunction, and JSObjectCallAsConstructor are returned through a JSValueRef* exception argument
    • removed JSContextHasException, because JSContextGetException does the same job


  • API/JSBase.h:
  • API/JSCharBufferRef.cpp: (JSValueCopyStringValue):
  • API/JSContextRef.cpp: (JSEvaluate):
  • API/JSContextRef.h:
  • API/JSNodeList.c: Added test code demonstrating how you would use toNumber, and why you probably don't need toUInt32, etc. (JSNodeListPrototype_item): (JSNodeList_getProperty):
  • API/JSObjectRef.cpp: (JSValueToObject): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • API/JSObjectRef.h:
  • API/JSValueRef.cpp: (JSValueToNumber):
  • API/JSValueRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main): Added tests for new rules, and call to JSGCProtect to fix Intel crash
  • JavaScriptCore.exp:
6:42 PM Changeset in webkit [15148] by darin
  • 2 edits in trunk/JavaScriptCore
  • Rolled out HashMap implementation of NPRuntime, at least temporarily.

Fixes hang in the bindings section of layout tests seen on the
buildbot.

This code was using HashMap<const char*, PrivateIdentifier*>.
But that hashes based on pointer identity, not string value.
The default hash for any pointer type is to hash based on the pointer.
And WTF doesn't currently have a string hash for char*.
We'll need to fix that before re-landing this patch.

(Formatting was also incorrect -- extra spaces in parentheses.)

  • bindings/npruntime.cpp: Rolled out last change.
11:46 AM Changeset in webkit [15147] by thatcher
  • 1 edit in trunk/WebKit/Misc/WebNSDataExtras.m

Build fix.

10:36 AM Changeset in webkit [15146] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed, tweaked, landed by ggaren.

  • Port NPRuntime from CFDictionary to HashMap.
  • bindings/npruntime.cpp: (getStringIdentifierDictionary): (getIntIdentifierDictionary): (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier):
  • bindings/npruntime.h:
1:27 AM Changeset in webkit [15145] by thatcher
  • 3 edits in trunk/WebKitTools/Drosera/English.lproj/MainMenu.nib

Forgot the NIB file change for step over and step out.

1:20 AM Changeset in webkit [15144] by thatcher
  • 7 edits
    1 add in trunk/WebKitTools

Reviewed by Eric.

Bug 9631: [Drosera] Add "Step Over" and "Step Out"
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9631


Adds step over and step out. Along with a little code cleanup
that was minor enough to piggyback on this fix.

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument stepOver:]): (-[DebuggerDocument stepOut:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
  • Drosera/viewer.css:
1:03 AM Changeset in webkit [15143] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Bug 9628: [Drosera] Split Views acting oddly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9628


Only update the last X or Y coordinate if the new
size was not constrained. Also adds the resize cursor to
the body during the drag incase there is a constrained
over drag off of the resizer element.

  • Drosera/debugger.js:
12:42 AM Changeset in webkit [15142] by thatcher
  • 2 edits in tags/WebKit-521.14.2/WebKit

Build fix and versioning.

12:37 AM Changeset in webkit [15141] by thatcher
  • 1 copy in tags/WebKit-521.14.2

New tag.

Jul 2, 2006:

4:36 PM Changeset in webkit [15140] by ggaren
  • 5 edits in trunk/WebCore

Reviewed and landed by ggaren.

  • platform/gdk/TransferJobManager.cpp Fixed broken dowload logic
  • platform/gdk/ScrollViewGdk.cpp Add comment that scrollbarSize is a temporary variable
  • Projects/gdk/webcore-gdk.bkl Defined NDEBUG build executable is miscompiled otherwise
  • WebCoreSources.bkl added icon/SiteIcon.cpp editing/IndentOutdentCommand.cpp html/HTMLViewSourceDocument.cpp
11:17 AM Changeset in webkit [15139] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adele.


6:05 AM Changeset in webkit [15138] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Alexy Proskuryakov. Patch by Mark Rowe.

Bug 9692: Warning about Safari extensions on every launch is obnoxious
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9692

  • WebKitLauncher/WebKitNightlyEnabler.m: (myApplicationWillTerminate): Note that we are exiting cleanly. (cleanUpAfterOurselves): Install bundle load tracking only if we failed to exit cleanly on our last invocation. This doesn't play nicely with multiple concurrent instances of WebKit.app so it can be disabled via defaults write com.apple.Safari WKNEShouldMonitorShutdowns -bool NO.
5:23 AM Changeset in webkit [15137] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Alexy Proskuryakov. Patch by Mark Rowe.

Bug 9654: Refresh Loop when accessing feed URLs
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9654

  • WebKitLauncher/Info.plist: Don't claim to handle feed:// URLs.
5:02 AM Changeset in webkit [15136] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy Hatcher. Patch by Mark Rowe.

Bug 9689: Nightly builds should warn a user about potential problems when using
"Safari extensions"
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9689

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitNightlyEnabler.m: (myBundleDidLoad): Keep track of if any bundles that are loaded. (myApplicationWillFinishLaunching): Notify user if any bundles are loaded. (cleanUpAfterOurselves): Register for NSBundleDidLoadNotification and NSApplicationWillFinishLaunchingNotification notifications so that we can track bundle loads and notify the user at launch completion.
4:59 AM Changeset in webkit [15135] by ddkilzer
  • 4 edits in trunk/WebCore

WebCore:

Reviewed by Timothy Hatcher. Build fix for Linux. Patch by Shawn Stricker.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::setDrawable): Changed SCROLLBAR_SIZE to scrollbarSize.
  • platform/gdk/TemporaryLinkStubs.cpp: (Image::drawTiled): Added missing parameter to argument list.
  • platform/gdk/TransferJobManager.cpp: (WebCore::writeCallback): Added missing parenthesis to static_cast.
4:39 AM Changeset in webkit [15134] by ddkilzer
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Darin. Patch by Mitz.

Replaced the requestingScript state bit added in the fix for bug 9317
with a m_requestingScript bool that is set before and restored
after calling ref() on a CachedScript.


Test: fast/tokenizer/nested-cached-scripts.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::):

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/tokenizer/nested-cached-scripts-expected.txt: Added.
  • fast/tokenizer/nested-cached-scripts.html: Added.
  • fast/tokenizer/resources/nested-1.js: Added.
  • fast/tokenizer/resources/nested-2.js: Added.

Jul 1, 2006:

9:06 PM Changeset in webkit [15133] by ggaren
  • 17 edits
    14 adds in trunk/JavaScriptCore

Reviewed by Maciej.


  • Phase 2 in the JS API.


  • Added support for specifying static tables of values -- this should obviate the need for using complicated callbacks for most lookups.


  • API objects are now created with classes (JSClassRef) -- in order to support static values, and in order to prevent API objects from storing their data inline, and thus falling into the oversized (read: slow and prone to giving Maciej the frowny face) heap.


  • Added two specialized JSObject subclasses -- JSCallbackFunction and JSCallbackConstructor -- to allow JSFunctionMake and JSConstructorMake to continue to work with the new class model. Another solution to this problem would be to create a custom class object for each function and constructor you make. This solution is more code but also more efficient.


  • Substantially beefed up the minidom example to demonstrate and test a lot of these techniques. Its output is still pretty haphazard, though.


  • Gave the <kjs/ preface to some includes -- I'm told this matters to building on some versions of Linux.


  • Implemented JSValueIsInstanceOf and JSValueIsObjectOfClass


  • Removed GetDescription callback. Something in the class datastructure should take care of this.
  • API/JSBase.h:
  • API/JSCallbackConstructor.cpp: Added. (KJS::): (KJS::JSCallbackConstructor::JSCallbackConstructor): (KJS::JSCallbackConstructor::implementsConstruct): (KJS::JSCallbackConstructor::construct): (KJS::JSCallbackConstructor::setPrivate): (KJS::JSCallbackConstructor::getPrivate):
  • API/JSCallbackConstructor.h: Added. (KJS::JSCallbackConstructor::classInfo):
  • API/JSCallbackFunction.cpp: Added. (KJS::): (KJS::JSCallbackFunction::JSCallbackFunction): (KJS::JSCallbackFunction::implementsCall): (KJS::JSCallbackFunction::callAsFunction): (KJS::JSCallbackFunction::setPrivate): (KJS::JSCallbackFunction::getPrivate):
  • API/JSCallbackFunction.h: Added. (KJS::JSCallbackFunction::classInfo):
  • API/JSCallbackObject.cpp: (KJS::): (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::className): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::implementsConstruct): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::implementsCall): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::inherits): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSCallbackObject.h:
  • API/JSCharBufferRef.cpp:
  • API/JSClassRef.cpp: Added. (JSClassCreate): (JSClassRetain): (JSClassRelease):
  • API/JSClassRef.h: Added. (StaticValueEntry::StaticValueEntry): (StaticFunctionEntry::StaticFunctionEntry): (JSClass::JSClass):
  • API/JSContextRef.cpp: (JSContextCreate): (JSEvaluate):
  • API/JSContextRef.h:
  • API/JSNode.c: Added. (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNodePrototype_class): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild): (JSNode_finalize): (JSNode_class): (JSNode_prototype): (JSNode_new): (JSNode_construct):
  • API/JSNode.h: Added.
  • API/JSNodeList.c: Added. (JSNodeListPrototype_item): (JSNodeListPrototype_class): (JSNodeList_length): (JSNodeList_getProperty): (JSNodeList_finalize): (JSNodeList_class): (JSNodeList_prototype): (JSNodeList_new):
  • API/JSNodeList.h: Added.
  • API/JSObjectRef.cpp: (JSObjectMake): (JSFunctionMake): (JSConstructorMake): (JSPropertyEnumerator::JSPropertyEnumerator): (JSObjectCreatePropertyEnumerator): (JSPropertyEnumeratorGetNext): (JSPropertyEnumeratorRetain): (JSPropertyEnumeratorRelease):
  • API/JSObjectRef.h: (JSObjectCallbacks::):
  • API/JSValueRef.cpp: (JSValueIsObjectOfClass): (JSValueIsInstanceOf):
  • API/JSValueRef.h:
  • API/Node.c: Added. (Node_new): (Node_appendChild): (Node_removeChild): (Node_replaceChild): (Node_ref): (Node_deref):
  • API/Node.h: Added.
  • API/NodeList.c: Added. (NodeList_new): (NodeList_length): (NodeList_item): (NodeList_ref): (NodeList_deref):
  • API/NodeList.h: Added.
  • API/minidom.c: (main): (print): (createStringWithContentsOfFile):
  • API/minidom.js:
  • API/testapi.c: (assertEqualsAsCharacters): (MyObject_getProperty): (MyObject_class): (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • JavaScriptCore.xcodeproj/project.pbxproj:
8:20 PM Changeset in webkit [15132] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

  • platform/gdk/TransferJobManager.cpp: (WebCore::writeCallback): Changed 'static_cat' to 'static_cast'.
7:50 PM Changeset in webkit [15131] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by NOBODY (fixed Tim's build fix).

  • WebView/WebView.m: Added back missing '/' at the beginning of the file.
6:31 PM Changeset in webkit [15130] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebView.m: (-[WebView _isMIMETypeRegisteredAsPlugin:]): Changed nil to NO (typo).
12:13 PM Changeset in webkit [15129] by thatcher
  • 2 edits in tags/WebKit-521.14.1/WebKit

Build fix for case-sensitive filesystems and versioning.

12:11 PM Changeset in webkit [15128] by thatcher
  • 1 copy in tags/WebKit-521.14.1/WebKit

New tag part 2.

12:10 PM Changeset in webkit [15127] by thatcher
  • 1 add in tags/WebKit-521.14.1

New tag.

12:08 PM Changeset in webkit [15126] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Build fix for case-sensitive filesystems.

Jun 30, 2006:

10:02 PM Changeset in webkit [15125] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed and tweaked by Darin.

  • Compile fixes for wx port / gcc 4.0.2
  • kjs/array_object.cpp: Added missing headers.
  • kjs/ExecState.h: gcc needs class prototypes before defining those classes as friend classes
9:39 PM Changeset in webkit [15124] by darin
  • 1 edit
    29 adds in trunk/WebCore

Reviewed and worked over a lot by Darin.

  • check in first set of GDK-specific sources
  • platform/gdk/BrowserExtensionGdk.h: Added.
  • platform/gdk/CookieJarGdk.cpp: Added.
  • platform/gdk/CursorGdk.cpp: Added.
  • platform/gdk/FontCacheGdk.cpp: Added.
  • platform/gdk/FontDataGdk.cpp: Added.
  • platform/gdk/FontGdk.cpp: Added.
  • platform/gdk/FontPlatformData.h: Added.
  • platform/gdk/FontPlatformDataGdk.cpp: Added.
  • platform/gdk/FrameGdk.cpp: Added.
  • platform/gdk/FrameGdk.h: Added.
  • platform/gdk/GlyphMapGdk.cpp: Added.
  • platform/gdk/KeyEventGdk.cpp: Added.
  • platform/gdk/KeyboardCodes.h: Added.
  • platform/gdk/MouseEventGdk.cpp: Added.
  • platform/gdk/PageGdk.cpp: Added.
  • platform/gdk/RenderThemeGdk.cpp: Added.
  • platform/gdk/RenderThemeGdk.h: Added.
  • platform/gdk/ScreenGdk.cpp: Added.
  • platform/gdk/ScrollViewGdk.cpp: Added.
  • platform/gdk/SharedTimerLinux.cpp: Added.
  • platform/gdk/SystemTimeLinux.cpp: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: Added.
  • platform/gdk/TransferJobCurl.cpp: Added.
  • platform/gdk/TransferJobManager.cpp: Added.
  • platform/gdk/TransferJobManager.h: Added.
  • platform/gdk/WheelEventGdk.cpp: Added.
  • platform/gdk/WidgetGdk.cpp: Added.
  • platform/gdk/gdk-encodings.txt: Added.
9:24 PM Changeset in webkit [15123] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • WebCoreSources.bkl: Updated for recent file changes.
9:23 PM Changeset in webkit [15122] by darin
  • 5 edits in trunk/WebCore

Reviewed and enhanced by Darin.

Compilation fixes for Linux/Gdk.

  • WebCore/platform/FontData.h: Added forward declaration of a class.
  • WebCore/platform/cairo/GraphicsContextCairo.cpp: Fixed case on include.
  • WebCore/bindings/js/kjs_html.cpp: Added <math.h> include.
  • WebCore/css/maketokenizer: Fixed incorrect check for Linux that was already true even on Mac OS X. Added some additional includes and defines to the Linux extra generated code.
7:51 PM Changeset in webkit [15121] by ddkilzer
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/float-move-during-layout.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::repaintOverhangingFloats): Renamed repaintFloatingDescendants() to this and limited it to repainting overhanging floats. Added a boolean parameter that forces all descendant overhanging floats (that don't have their own layer) to paint.
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved): Changed to paint all descendant floats.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintOverhangingFloats):
  • rendering/RenderObject.h:

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/float-move-during-layout-expected.checksum: Added.
  • fast/repaint/float-move-during-layout-expected.png: Added.
  • fast/repaint/float-move-during-layout-expected.txt: Added.
  • fast/repaint/float-move-during-layout.html: Added.
6:33 PM Changeset in webkit [15120] by darin
  • 1 edit in trunk/Bakefiles/presets.bkl

Changes by Mike Emmel.

6:32 PM Changeset in webkit [15119] by darin
  • 1 edit
    8 adds in trunk/WebKitTools

Reviewed by Darin.

  • first check-in of a Gdk shell for testing WebKit
  • GdkLauncher: Added.
6:31 PM Changeset in webkit [15118] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Compilation fixes for Linux/Gdk.

  • JavaScriptCore/kjs/interpreter.cpp: added include of signal.h
  • JavaScriptCore/kjs/ExecState.h: added missing class declaration
  • JavaScriptCore/kjs/ExecState.cpp: case wrong on include of context.h
  • JavaScriptCore/JavaScriptCoreSources.bkl: added Context.cpp and ExecState.cpp
4:47 PM Changeset in webkit [15117] by lweintraub
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin

  • editing/execCommand/format-block-with-trailing-br-expected.checksum: Added.
  • editing/execCommand/format-block-with-trailing-br-expected.png: Added.
  • editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
  • editing/execCommand/format-block-with-trailing-br.html: Added.

WebCore:

Reviewed by justin

  • editing/VisiblePosition.cpp: Removed is[Not]EqualIgnoringAffinity and made operator== use the logic that ignores affinity.
  • editing/VisiblePosition.h: Ditto. (WebCore::operator==):
  • editing/visible_units.cpp: (WebCore::isStartOfParagraph): Changed to compare VisiblePositions using ==. (WebCore::isEndOfParagraph): Ditto. (WebCore::isStartOfBlock): Ditto. (WebCore::isEndOfBlock): Ditto.
4:41 PM Changeset in webkit [15116] by thatcher
  • 9 copies in tags/Safari-521.14

New tag.

4:35 PM Changeset in webkit [15115] by thatcher
  • 8 edits in /

Versioning

3:32 PM Changeset in webkit [15114] by justing
  • 1 edit in trunk/LayoutTests/editing/pasteboard/pasting-object.html

Fixed the test case that I just checked in.

3:17 PM Changeset in webkit [15113] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/pasteboard/pasting-object-expected.checksum: Added.
  • editing/pasteboard/pasting-object-expected.png: Added.
  • editing/pasteboard/pasting-object-expected.txt: Added.
  • editing/pasteboard/pasting-object.html: Added.

WebCore:

Reviewed by levi

  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Don't insert children into object tags while editing.
12:43 PM Changeset in webkit [15112] by justing
  • 22 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


Added:

  • editing/selection/skip-non-editable-1-expected.txt: Added.
  • editing/selection/skip-non-editable-1.html: Added.
  • editing/selection/skip-non-editable-2-expected.txt: Added.
  • editing/selection/skip-non-editable-2.html: Added.

Equivalent render tree:

  • editing/execCommand/format-block-with-braces-expected.txt:


Fixes:

  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/iframe-expected.txt:
  • editing/selection/inline-table-expected.checksum:
  • editing/selection/inline-table-expected.png:
  • editing/selection/inline-table-expected.txt:
  • editing/selection/move-between-blocks-no-001-expected.checksum:
  • editing/selection/move-between-blocks-no-001-expected.png:
  • editing/selection/move-between-blocks-no-001-expected.txt:
  • editing/selection/select-box-expected.checksum:
  • editing/selection/select-box-expected.png:
  • editing/selection/select-box-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4598309
Caret gets stuck when it hits non editable content within an editable body
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9510>
Caret will jump out of an editable region


  • dom/Position.cpp: (WebCore::Position::upstream): Don't move into a new editable region so that candidates that that straddle an editable/non-editable boundary will correspond to different VisiblePositions. (WebCore::Position::downstream): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingRightForward): Use VisiblePosition::next(true) (WebCore::SelectionController::modifyMovingLeftBackward): Use VisiblePosition::previous(true)
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Added code to jump to the next editable region as long as it has the same highest editable root. (WebCore::VisiblePosition::previous): Ditto.
  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp: (WebCore::highestEditableRoot): Added, returns the highest editable root of a node if that node is in editable content, otherwise 0.
  • editing/htmlediting.h:
12:09 PM Changeset in webkit [15111] by ddkilzer
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: editing/deleting/delete-all-text-in-text-field-assertion.html

Bug 9661 filed to fix the follow-up issue:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9661
textContent returns "\n" for a <br> even if it is collapsed

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer): Work around "\n" value when all characters are deleted from a text field.

LayoutTests:

Reviewed by Darin.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
  • editing/deleting/delete-all-text-in-text-field-assertion.html: Added.
11:56 AM Changeset in webkit [15110] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Only enable shouldCloseWithWindow when ObjC GC is enabled.
This maintains backwards compatibility with applications
that expect a WebView to be usable after the window closes.

  • WebView/WebView.m: (-[WebViewPrivate init]):
10:53 AM Changeset in webkit [15109] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick

<rdar://problem/4609481> Crash calling -[WebScriptObject valueForKey:] when JS disabled


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::executionContextForDOM): Early return if JS is not enabled.
10:35 AM Changeset in webkit [15108] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Call _close in dealloc to ensure we cleanup for backwards
compatibility. This will safeguard and cleanup even if the
application doesn't use the new close API yet, like Mail.

  • WebView/WebView.m: (-[WebView dealloc]):
7:05 AM Changeset in webkit [15107] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

  • page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): Added a check that oldSubframe is still a subframe of the view's frame before passing the event to it.
12:29 AM Changeset in webkit [15106] by thatcher
  • 23 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3694163> -[KWQPageState finalize] is incorrect; design change needed
<rdar://problem/3694165> -[WebCoreFrameBridge finalize] is incorrect; design change needed

Added close methods that need to be called before these
objects can be released. This ensures proper tear-down under GC.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]): (-[WebCoreFrameBridge close]):
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setMainFrame:]): (-[WebCorePageBridge dealloc]): (-[WebCorePageBridge finalize]): (-[WebCorePageBridge close]): (-[WebCorePageBridge mainFrame]): (-[WebCorePageBridge setGroupName:]): (-[WebCorePageBridge groupName]):
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState dealloc]): (-[KWQPageState finalize]): (-[KWQPageState close]):

WebKit:

Reviewed by Darin.

<rdar://problem/4484405> WebKit leaks, improper tear-down
<rdar://problem/3694059> -[WebBackForwardList finalize] is incorrect; design change needed
<rdar://problem/3694103> -[WebFrame finalize] is incorrect; design change needed
<rdar://problem/3694104> -[WebHTMLView finalize] is incorrect; design change needed

Adds a close method to WebView, this needs to be called when the
WebView is no longer needed. To make this easier for the common cases
there is now an "auto close" on WebView that listens to the view's
parent window. If the parent window closes and the WebView has no
hostWindow then the WebView is automatically closed if autoClose is YES.
To manage WebView closing yourself call setAutoClose: and pass NO.

When a WebView closes it will tear-down and not be usable anymore.
Close will will called on various other internal objects as a part
of this, to ensure proper tear-down in GC without relying on finalize.

  • History/WebBackForwardList.m: (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList _close]):
  • History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]): (+[WebHistoryItem _releaseAllPendingPageCaches]):
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge close]): (-[WebFrameBridge saveDocumentToPageCache:]): (-[WebFrameBridge canGoBackOrForward:]):
  • WebView/WebFrame.m: (-[WebFrame _detachFromParent]): (-[WebFrame dealloc]): (-[WebFrame finalize]):
  • WebView/WebFrameView.m: (-[WebFrameView _setWebFrame:]): (-[WebFrameView finalize]):
  • WebView/WebHTMLView.m: (-[WebHTMLView close]): (-[NSArray dealloc]): (-[NSArray finalize]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebScriptDebugDelegatePrivate.h:
  • WebView/WebView.m: (-[WebViewPrivate init]): (-[WebView _close]): (-[WebView dealloc]): (-[WebView finalize]): (-[WebView viewWillMoveToWindow:]): (-[WebView _windowWillClose:]): (-[WebView setPreferencesIdentifier:]): (-[WebView mainFrame]): (-[WebView setHostWindow:]): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView close]): (-[WebView setAutoClose:]): (-[WebView autoClose]): (-[WebView _frameViewAtWindowPoint:]):
  • WebView/WebViewPrivate.h:

WebKitTools:

Reviewed by Darin.

Need to call window close so WebView tears-down completly.

  • DumpRenderTree/DumpRenderTree.m: (main): call [window close]

Jun 29, 2006:

11:36 PM Changeset in webkit [15105] by ddkilzer
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Note: patch originally from Mitz, spruced up by Weinig.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):

LayoutTests:

Reviewed by Hyatt.

Note: test case originally from Mitz.

  • fast/table/absolute-table-at-bottom-expected.checksum: Added.
  • fast/table/absolute-table-at-bottom-expected.png: Added.
  • fast/table/absolute-table-at-bottom-expected.txt: Added.
  • fast/table/absolute-table-at-bottom.html: Added.
10:56 PM Changeset in webkit [15104] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by mjs and timo.


Fixed: <rdar://problem/4609119> handleAuthenticationFromResource was removed; needed by the Dashboard

  • WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the Dashboard, but was removed in r.14028 on 2006-04-23.
10:35 PM Changeset in webkit [15103] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Justin.

  • editing/CompositeEditCommand.cpp: Added sanity checking to prevent modifying nodes outside of where we should be (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-table-002.html: Added.
  • editing/pasteboard/paste-table-002-expected.checksum: Added.
  • editing/pasteboard/paste-table-002-expected.png: Added.
  • editing/pasteboard/paste-table-002-expected.txt: Added.
9:45 PM Changeset in webkit [15102] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Levi.

In addition to a few small details, logging changes, and style cleanups, this is a stop-gap hack
for a problem in SQLite's blob handling. Querying for a blob in a void* form is reproducibly
returning a corrupt buffer. The temporary solution is to query for the blob as "quoted text" and
manually convert the return string into a character buffer.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables):

(WebCore::hexToUnsignedChar): These two functions are the text-to-character-data converters for the time being
(WebCore::hexStringToVector):

(WebCore::IconDatabase::imageDataForIconID):
(WebCore::IconDatabase::imageDataForIconURL):
(WebCore::IconDatabase::imageDataForPageURL):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::hasIconForIconURL):

  • icon/IconDatabase.h: changes the icon data accessors to return a Vector<unsigned char> instead of void*
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnBlob):
  • icon/SiteIcon.cpp: (SiteIcon::getImage):
9:39 PM Changeset in webkit [15101] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/rtl-cell-display-none-assert.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Corrected the index used as the last index in the columnPos vector.

LayoutTests:

Reviewed by Darin.

  • fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
  • fast/table/rtl-cell-display-none-assert-expected.png: Added.
  • fast/table/rtl-cell-display-none-assert-expected.txt: Added.
  • fast/table/rtl-cell-display-none-assert.html: Added.
9:31 PM Changeset in webkit [15100] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]

  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here. For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI, we need to save a copy of the additional paths and not cause a refresh of the plugin DB at this time. (-[WebPluginDatabase _plugInPaths]): Include additionalWebPlugInPaths if this is the global DB. (-[WebPluginDatabase refresh]): Call -_plugInPaths to get the modified array of paths. This is similar to what the old code (before we had per-WebView plugin search paths).
9:24 PM Changeset in webkit [15099] by ddkilzer
  • 1 edit
    14 adds in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9615: Buildbot configuration should be in SVN repository
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9615

Import BuildBot configuration files as used by build.webkit.org.
auth.py has been stubbed out so that slave passwords are not disclosed.

  • BuildSlaveSupport/build.webkit.org-config/Makefile: Added.
  • BuildSlaveSupport/build.webkit.org-config/buildbot.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Added.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/init.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Added.
9:20 PM Changeset in webkit [15098] by ddkilzer
  • 6 edits
    1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9614: Nightly builds should notify user if a newer build is available
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9614

  • BuildSlaveSupport/build-launcher-app: Write revision number to WebKit.app's VERSION file.
  • BuildSlaveSupport/build-launcher-dmg: Pass revision number to server-side nightly maintenance script so it can keep track of the latest revision.
  • Scripts/run-webkit-tests: Pass build-dumprendertree's exit status through correctly.
  • WebKitLauncher/VERSION: Added. Placeholder for SVN revision number
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/start.html: Retrieve revision number from VERSION file, and pass it through to the nightly start page.
7:56 PM Changeset in webkit [15097] by darin
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Anders.

  • manual-tests/modal-dialog.html: Added.
  • manual-tests/show-modal-dialog-test.html: Added.
  • page/Frame.cpp: (WebCore::Frame::clear): Call KJSProxy::clear with the clearWindowProperties parameter instead of not calling it at all when clearWindowProperties is false.
  • bindings/js/kjs_proxy.h: Add boolean clearWindowProperties parameter.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): Pass clearWindowProperties variable through to Window::clear instead of not calling it at all.
  • bindings/js/kjs_window.h: Add boolean clearWindowProperties parameter.
  • bindings/js/kjs_window.cpp: (KJS::Window::clear): If clearWindowProperties is false, do only the returnValue work, not the rest of the work.
  • manual-tests/modal-dialog.html: Added.
  • manual-tests/show-modal-dialog-test.html: Added.
4:32 PM Changeset in webkit [15096] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • add headerdoc comments to some of the new JS API headers
  • API/JSBase.h:
  • API/JSValueRef.h:
4:18 PM Changeset in webkit [15095] by bdakin
  • 17 edits
    5 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4450615> Add composite mode to background
styles

-webkit-background-composite will set a composite mode on a
background image.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in: Add -webkit-background-composite
  • css/CSSValueKeywords.in: Add all possible values (clear, copy, source-over, source-in, source-out, source-atop, destination-over, destination-in, destination-out, destination-atop, xor, plus- darker, highlight, and plus-lighter)
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundProperty):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundComposite):
  • css/cssstyleselector.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/GraphicsContext.h: drawTiledImage() now takes a composite operator.
  • platform/Image.h: drawTiled() now takes a composite operator.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawTiled): Set the composite operator.
  • platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Set the composite operator.
  • platform/win/TemporaryLinkStubs.cpp: (Image::drawTiled):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): Send the composite operator in the render style over to the graphics context.
  • rendering/render_style.cpp: (WebCore::BackgroundLayer::BackgroundLayer): (WebCore::BackgroundLayer::operator=): (WebCore::BackgroundLayer::operator==): (WebCore::BackgroundLayer::fillUnsetProperties): (WebCore::BackgroundLayer::cullEmptyLayers):
  • rendering/render_style.h: (WebCore::BackgroundLayer::backgroundComposite): (WebCore::BackgroundLayer::isBackgroundCompositeSet): (WebCore::BackgroundLayer::setBackgroundComposite): (WebCore::BackgroundLayer::clearBackgroundComposite): (WebCore::RenderStyle::backgroundComposite): (WebCore::RenderStyle::initialBackgroundComposite):
12:28 PM Changeset in webkit [15094] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
-_setTransientProperty:forKey:.
For now, these properties do not persist with the rest of the history data. They are intended to hold transient
per-history-item state, which is something that was until now difficult for a WebKit client app to do.


  • History/WebHistoryItemPrivate.h:
  • History/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):
11:18 AM Changeset in webkit [15093] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Harrison.

Smart insert and delete, continuous spell checking and autoscroll
can now be used for any WebView, not just editable ones. All of
these make sense for documents that might contain content editable
areas or our new text fields. Autoscroll is usefull for dragging
for file input controls also.

Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
WebHTMLView's _interceptEditingKeyEvent now uses WebView's
tabKeyCyclesThroughElements state to determine whether or not
to process tab key events. The idea here is that tabKeyCyclesThroughElements
will be YES when this WebView is being used in a browser, and we
desire the behavior where tab moves to the next element in tab order.
If tabKeyCyclesThroughElements is NO, it is likely that the WebView
is being embedded as the whole view, as in Mail, and tabs should input
tabs as expected in a text editor. Using Option-Tab always cycles
through elements.

  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
  • WebView/WebHTMLView.m: (-[NSArray _interceptEditingKeyEvent:]):
  • WebView/WebView.m: (-[WebViewPrivate init]): (-[WebView _autoscrollForDraggingInfo:timeDelta:]): (-[WebView _shouldAutoscrollForDraggingInfo:]): (-[WebView validateUserInterfaceItem:]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]):
  • WebView/WebViewPrivate.h:
8:28 AM Changeset in webkit [15092] by ddkilzer
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9649
The no-svg build broke after r15091

  • bindings/objc/DOMInternal.h: Added #if XPATH_SUPPORT/#endif.
  • bindings/objc/DOMInternal.mm: Ditto. (raiseDOMException):
  • bindings/objc/DOMXPath.h: Ditto.
  • bindings/objc/DOMXPath.mm: Ditto.
  • bindings/objc/DOMXPathInternal.h: Ditto.
12:54 AM Changeset in webkit [15091] by andersca
  • 6 edits
    3 adds in trunk

WebCore:

2006-06-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

<rdar://problem/4599760> Objective-C XPath support


  • WebCore.xcodeproj/project.pbxproj: Add files.


  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm: (raiseDOMException): Handle XPath exceptions


  • bindings/objc/DOMXPath.h: Added. (-[DOMXPathNSResolver lookupNamespaceURI:]):
  • bindings/objc/DOMXPath.mm: Added. (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver _xpathNSResolver]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]): (-[DOMXPathResult dealloc]): (-[DOMXPathResult finalize]): (-[DOMXPathResult resultType]): (-[DOMXPathResult numberValue]): (-[DOMXPathResult stringValue]): (-[DOMXPathResult booleanValue]): (-[DOMXPathResult singleNodeValue]): (-[DOMXPathResult invalidIteratorState]): (-[DOMXPathResult snapshotLength]): (-[DOMXPathResult iterateNext]): (-[DOMXPathResult snapshotItem:]): (-[DOMXPathResult _xpathResult]): (-[DOMXPathResult _initWithXPathResult:]): (+[DOMXPathResult _xpathResultWith:]): (-[DOMXPathExpression evaluate:::]): (-[DOMXPathExpression _xpathExpression]): (-[DOMXPathExpression _initWithXPathExpression:]): (+[DOMXPathExpression _xpathExpressionWith:]): (-[DOMDocument createExpression::]): (-[DOMDocument createNSResolver:]): (-[DOMDocument evaluate:::::]):
  • bindings/objc/DOMXPathInternal.h: Added. Add Objective-C XPath API.

WebKit:

2006-06-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

  • WebKit.xcodeproj/project.pbxproj: Add DOMXPath.h header.

Jun 28, 2006:

5:32 PM Changeset in webkit [15090] by hyatt
  • 11 edits in trunk

WebCore:

Add support for custom highlighting to paint at the root line box level
(and to inflate the box it uses so that it can go outside the bounds of
the line if necessary).

Reviewed by harrison

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight):
  • bridge/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:

WebKit:

Fix custom highlighting so that you can paint the entire line (and go
outside the bounds of the line).

Reviewed by harrison

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge customHighlightRect:forLine:]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
5:20 PM Changeset in webkit [15089] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • fix Frame leak on layout tests
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Return WebFrameView for main frame instead of WebView to avoid reference cycle between WebView and Page.
4:44 PM Changeset in webkit [15088] by lweintraub
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • editing/execCommand/format-block-with-braces-expected.checksum: Added.
  • editing/execCommand/format-block-with-braces-expected.png: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Added.
  • editing/execCommand/format-block-with-braces.html: Added.
  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection-expected.checksum: Added.
  • editing/execCommand/outdent-selection-expected.png: Added.
  • editing/execCommand/outdent-selection-expected.txt: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Return inline nodes
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
  • editing/JSEditor.cpp: Support html braces (<>) around tag names
4:18 PM Changeset in webkit [15087] by justing
  • 3 edits in trunk/WebCore

Reviewed by levi


svg/custom/text-hit-test.svg was failing

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't skip child renderers that have a height of 0 when looking for the closest child renderer, they may contain content that overflows.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Fixed typos.
1:43 PM Changeset in webkit [15086] by hyatt
  • 3 edits in trunk/WebCore

Make the view source document properly handle <script>. We don't syntax
highlight the JS yet, but it shows up properly now.

Reviewed by john

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
1:32 PM Changeset in webkit [15085] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

JavaScriptGlue:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

  • WebKit.xcodeproj/project.pbxproj:
1:18 PM Changeset in webkit [15084] by justing
  • 4 edits in trunk/WebCore

Reviewed by levi


Fixed EditActions for InsertHorizontalRule and RemoveFormat.


  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::editingAction):
  • editing/ReplaceSelectionCommand.h:
1:09 PM Changeset in webkit [15083] by aliceli1
  • 1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.

11:58 AM Changeset in webkit [15082] by lweintraub
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Build Fix

11:36 AM Changeset in webkit [15081] by lweintraub
  • 2 edits in trunk/WebCore

Build Fix. Reviewed by NOBODY

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion):
11:17 AM Changeset in webkit [15080] by lweintraub
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • editing/execCommand/indent-list-item-expected.checksum: Added.
  • editing/execCommand/indent-list-item-expected.png: Added.
  • editing/execCommand/indent-list-item-expected.txt: Added.
  • editing/execCommand/indent-list-item.html: Added.
  • editing/execCommand/indent-selection-expected.checksum: Added.
  • editing/execCommand/indent-selection-expected.png: Added.
  • editing/execCommand/indent-selection-expected.txt: Added.
  • editing/execCommand/indent-selection.html: Added.
  • editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/IndentOutdentCommand.cpp: Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::enclosingListOrBlockquote): (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a descendent node to an ending ancestor, duplicating nodes when necessary. Returns the last node split. Used to insert blockquotes at the topmost level. (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph): (WebCore::IndentOutdentCommand::outdentRegion): (WebCore::IndentOutdentCommand::doApply):
  • editing/IndentOutdentCommand.h: Added. (WebCore::IndentOutdentCommand::):
  • editing/JSEditor.cpp: Added the execCommands Indent and Outdent
  • editing/htmlediting.cpp: (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag. (WebCore::enclosingListChild): Added checks for nill and editable boundaries. (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child. (WebCore::highestAncestor): Added. (WebCore::createElement): Changed the passed in string to a const reference.
  • editing/htmlediting.h:

WebKit:

Reviewed by justin

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent
Added undo action strings and enum values

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
8:42 AM Changeset in webkit [15079] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

  • fast/forms/button-generated-content-expected.checksum: Added.
  • fast/forms/button-generated-content-expected.png: Added.
  • fast/forms/button-generated-content-expected.txt: Added.
  • fast/forms/button-generated-content.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Test: fast/forms/button-generated-content.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject() on the button itself or on its inner div, if it has one.
  • rendering/RenderButton.h: (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing generated content of the requested type if there is one, or otherwise the child before/after which such generated content should come. (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts of this method into updatePseudoChildForObject, which this method calls unless the object is an anonymous wrapper. (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what updatePseudoChildForObject did previously, but fetches the pseudo style from the styledObject parameter.
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow):
  • rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces allowsReusingAnonymousChild and returns the opposite of what that method used to return. Returns true if the object creates an anonymous child to contain all its other children.
7:39 AM Changeset in webkit [15078] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

Improved test to check offsetX/Y after dispatching instead of before.

  • fast/dom/window-xy-properties.html:
  • fast/dom/window-xy-properties-expected.txt:
12:18 AM Changeset in webkit [15077] by beidson
  • 10 edits
    1 add in trunk

WebCore:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.

  • WebCore.xcodeproj/project.pbxproj: Added file SiteIcon.cpp
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
  • icon/IconDatabase.cpp: (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
  • icon/IconDatabase.h: (WebCore::SiteIcon::getIconURL): (WebCore::IconDatabase::getPrivateBrowsingEnabled):


  • icon/SiteIcon.cpp: Added. (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): (SiteIcon::getImage): (SiteIcon::resetExpiration): (SiteIcon::getExpiration):

WebKit:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.
Note: To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)

  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:

Jun 27, 2006:

8:52 PM Changeset in webkit [15076] by darin
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

Updated test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9605

  • fast/dom/window-xy-properties.html:
  • fast/dom/window-xy-properties-expected.txt:

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
REGRESSION: pageX and pageY are both 0 for events created with initMouseEvent

Calculate pageX/pageY and clientX/clientY values when using initMouseEvent.

  • dom/MouseEvent.cpp: (WebCore::MouseEvent::initMouseEvent):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
8:32 PM Changeset in webkit [15075] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/tokenizer/write-unclosed-script-expected.txt: Added.
  • fast/tokenizer/write-unclosed-script.html: Added.

WebCore:

Reviewed by Maciej and Darin.

Test: fast/tokenizer/write-unclosed-script.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Changed to reset the inScript flag and scriptCodeSize before possible script execution, but not afterwards. This way, if script execution write()s a <script> tag without closing it, the tokenizer is left in inScript state. Added code to set the requestingScript flag around the request for the cached script, to let notifiyFinished() know that it's being called under scriptHandler(). (WebCore::HTMLTokenizer::scriptExecution): Removed code that saved and restored the inScript flag. This function is always entered now with inScript being false. (WebCore::HTMLTokenizer::notifyFinished): Changed to use the new requestingScript state flag instead of the inScript flag, which is always false now when entering this function.
  • html/HTMLTokenizer.h: Added the requestingScript state bit, used to tell notifyFinished() that it is being called under scriptHandler() (which happens when the script is already in cache).
7:26 PM Changeset in webkit [15074] by justing
  • 1 edit in trunk/LayoutTests/editing/execCommand/remove-formatting.html

Fixed some typos.

7:23 PM Changeset in webkit [15073] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/execCommand/remove-formatting-expected.checksum: Added.
  • editing/execCommand/remove-formatting-expected.png: Added.
  • editing/execCommand/remove-formatting-expected.txt: Added.
  • editing/execCommand/remove-formatting.html: Added.

WebCore:

Reviewed by levi

  • editing/JSEditor.cpp: Added RemoveFormat.
7:17 PM Changeset in webkit [15072] by kdecker
  • 2 edits in trunk/WebCore
5:18 PM Changeset in webkit [15071] by thatcher
  • 9 edits in trunk/JavaScriptCore

Reviewed by Tim O.

<rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore, WebKit and WebBrowser

Switch to the new ObjC 2 API, ifdefed the old code around OBJC_API_VERSION so it still works on Tiger.
Removed the use of the old stringWithCString, switched to the new Tiger version that accepts an encoding.
Lots of code style cleanup.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::_createClassesByIsAIfNecessary): (KJS::Bindings::ObjcClass::classForIsA): (KJS::Bindings::ObjcClass::name): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed): (KJS::Bindings::ObjcClass::fallbackObject):
  • bindings/objc/objc_header.h:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::operator=): (ObjcInstance::begin): (ObjcInstance::end): (ObjcInstance::getClass): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfField): (ObjcInstance::supportsSetValueOfUndefinedField): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcMethod::ObjcMethod): (ObjcMethod::name): (ObjcMethod::getMethodSignature): (ObjcMethod::setJavaScriptName): (ObjcField::name): (ObjcField::type): (ObjcField::valueFromInstance): (convertValueToObjcObject): (ObjcField::setValueToInstance): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::callAsFunction): (ObjcFallbackObjectImp::defaultValue):
4:59 PM Changeset in webkit [15070] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-06-28 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8636
REGRESSION: JavaScript access to Java applet causes hang (_webViewURL not implemented)


  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall): Just pass nil as the calling URL. This will cause the Java plugin to use the URL of the page containing the applet (which is what we used to do).
4:58 PM Changeset in webkit [15069] by andersca
  • 3 edits in trunk/WebCore

2006-06-28 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Move FIXME comment here.


  • page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Don't do a null check on the renderer here. Everything's handled by CSSComputedStyleDeclaration anyway.
3:56 PM Changeset in webkit [15068] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin

  • rendering/RenderContainer.cpp: Fixed #include formatting.
3:26 PM Changeset in webkit [15067] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work


Added:

  • editing/selection/click-before-and-after-table-expected.txt: Added.
  • editing/selection/click-before-and-after-table.html: Added. Updated to reflect fix:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:

WebCore:

Reviewed by levi


<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): In the fall through case, where we can't find a child block that contains (x, y), pass to RenderFlow instead of the last visible child block.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't pass to the closest child renderer if this is a table and (x, y) is outside the table. Return a VisiblePosition before or after the table. Fixed the code that finds the closest child renderer.
3:04 PM Changeset in webkit [15066] by hyatt
  • 3 edits in trunk/WebCore

Preserve entity text in view source mode. This patch doesn't highlight the
the entities yet, but it at least prevents their resolution and removal.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity):
2:30 PM Changeset in webkit [15065] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout


  • page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Do a relayout.

LayoutTests:

2006-06-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout

  • fast/css/getComputedStyle-relayout-expected.txt: Added.
  • fast/css/getComputedStyle-relayout.html: Added.
2:13 PM Changeset in webkit [15064] by thatcher
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Adding symbols for debug builds.

2:03 PM Changeset in webkit [15063] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptCore

JavaScriptCore 10.4.7 release.

2:02 PM Changeset in webkit [15062] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebCore

WebCore 10.4.7 release.

2:02 PM Changeset in webkit [15061] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebKit

WebKit 10.4.7 release.

2:00 PM Changeset in webkit [15060] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptGlue

JavaScriptGlue 10.4.7 release.

1:59 PM Changeset in webkit [15059] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.7

10.4.7 release tag.

1:53 PM Changeset in webkit [15058] by thatcher
  • 2 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch

1:36 PM Changeset in webkit [15057] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Adele

  • fixed <rdar://problem/4550473> Reproducible hang on www.digg.com


  • dom/NodeList.cpp: (WebCore::NodeList::recursiveItem): Make NodeList caching also work for backwards iteration - if the requested index is before the last cached, but closer to it than to the start of the list, then search backwards from there. (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a helper method. (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar to the above.
  • dom/NodeList.h:
12:07 PM Changeset in webkit [15056] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Levi

Some SQLDatabase cleanup (style stuff) and enhancements

  • icon/SQLDatabase.cpp: (SQLDatabase::open): (SQLDatabase::executeCommand): (SQLDatabase::returnsAtLeastOneResult): Accessor to see if this query returns results (SQLDatabase::lastInsertRowID): Accessor for the rowid of the last insert
  • icon/SQLDatabase.h: (WebCore::SQLStatement::prepareAndStep):
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::bindInt64): -All of the following used to require the user to manually prepare and step a statement before asking for the result. Now it will prepare and step itself so you can use a temporary object to get a quick result (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlobAsVector): (WebCore::SQLStatement::getColumnBlob):
11:15 AM Changeset in webkit [15055] by adachan
  • 2 edits in trunk/WebCore

2006-06-27 Ada Chan <​adachan@apple.com>

Reviewed by sfalken.

Fixed build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
10:56 AM Changeset in webkit [15054] by bdakin
  • 4 edits
    15 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4602635> Media queries must be extended to
address CSS pixel scaling factor

  • css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit- min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the list of feature names.
  • css/MediaQueryEvaluator.cpp: (WebCore::cmpvalue): Added a version of cmpvalue that compares floats. (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval):
10:44 AM Changeset in webkit [15053] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Change to use pageX/Y, but this really doesn't matter since framesets can't be scrolled -- it's the frames that are scrolled. So this change has no user-visible effect, but it's still better this way.
10:22 AM Changeset in webkit [15052] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Tests for fix for 2/3 of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
REGRESSION: some callers are still using clientX/Y to get pageX/Y

  • fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
  • fast/events/anchor-image-scrolled-x-y.html: Added.
  • fast/events/input-image-scrolled-x-y-expected.txt: Added.
  • fast/events/input-image-scrolled-x-y.html: Added.

WebCore:

Reviewed by Geoff.

Test: fast/events/anchor-image-scrolled-x-y.html
Test: fast/events/input-image-scrolled-x-y.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
12:35 AM Changeset in webkit [15051] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data

  • platform/mac/ImageMac.mm: (WebCore::Image::getTIFFRepresentation):

Jun 26, 2006:

4:53 PM Changeset in webkit [15050] by hyatt
  • 18 edits
    3 adds in trunk/WebCore

Fix for 9538, support syntax highlighted HTML source. Lots of loose
ends still (script/style/comments/doctype/entities/accurate whitespace).

Reviewed by darin

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setInViewSourceMode:]): (-[WebCoreFrameBridge inViewSourceMode]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules):
  • css/cssstyleselector.h:
  • css/view-source.css: Added.
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/xml_tokenizer.h: (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode):
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::attach):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::viewSourceMode):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: Added. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceAttribute): (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
  • html/HTMLViewSourceDocument.h: Added.
  • page/Frame.cpp: (WebCore::Frame::begin): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
4:48 PM Changeset in webkit [15049] by hyatt
  • 4 edits in trunk/WebKit

Fix for 9538, support syntax highlighting for HTML source.

Reviewed by darin

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]):
  • WebView/WebViewPrivate.h:
2:26 PM Changeset in webkit [15048] by andersca
  • 4 edits in trunk/WebCore

2006-06-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
REGRESSION: Crash when closing tabs on newegg.com


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
  • page/Frame.h: Add new method which is invoked when the frame's page has been destroyed. Currently this function disassociates the JS Window object with the frame, stopping any running JS timers.


  • page/Page.cpp: (WebCore::Page::~Page): Call pageDestroyed on all frames.
9:38 AM Changeset in webkit [15047] by darin
  • 10 edits in trunk/WebCore

Reviewed and reworked by Darin.

Code cleanup, calculate clientX/clientY in one central place.

  • dom/EventTargetNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): Renamed parameters to pageX/Y since they aren't clientX/Y values. Removed code to compute clientX/Y (was a bit confused in naming before), because that's now done inside MouseEvent.
  • dom/MouseEvent.h:
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters. (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed. (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML, when it was talking about the DOM standard.
  • dom/MouseRelatedEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): Added helper function. (WebCore::contentsY): Ditto. (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter, and added code to compute clientX/Y based on pageX/Y. (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.
  • dom/WheelEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y parameter.
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code to compute coordinates, and renamed the confusingly named clientPos (which was a page-relative position) to contentsPos.
8:26 AM Changeset in webkit [15046] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Darin.

  • LayoutTests/fast/events/objc-event-api-expected.txt: Updated to reflect flipped coordinates dumped by the layout tests.

WebKitTools:

Reviewed by Darin.

Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9579

Report screenY values as (height of zero screen - screenY)

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):

Jun 25, 2006:

10:09 PM Changeset in webkit [15045] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9591


Makes breakpoints dragable. If dragged off the gutter they are deleted.

  • Drosera/debugger.js:
  • Drosera/viewer.css:
9:51 PM Changeset in webkit [15044] by darin
  • 5 edits
    11 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

  • fast/forms/input-appearance-height-expected.png: Added.
  • fast/forms/input-appearance-height-expected.txt: Added.
  • fast/forms/input-appearance-height.html: Added. Tests the height attribute on all input types
  • fast/forms/input-type-change-expected.checksum: Added.
  • fast/forms/input-type-change-expected.png: Added.
  • fast/forms/input-type-change-expected.txt: Added.
  • fast/forms/input-type-change.html: Added. Tests changing an input type=TEXT to type=IMAGE with a height and width specified on the element.
  • fast/forms/input-type-change2-expected.checksum: Added.
  • fast/forms/input-type-change2-expected.png: Added.
  • fast/forms/input-type-change2-expected.txt: Added.
  • fast/forms/input-type-change2.html: Added. Tests changing an input type=IMAGE to type=TEXT with a height and width specified on the element.

WebCore:

Reviewed and tweaked by Darin.

  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getAttributeItem): Added to static_cast method.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the style decl if input type has changed. (WebCore::HTMLInputElement::mapToEntry): Only Cache height and width if it is an IMAGE or HIDDEN (WebCore::HTMLInputElement::parseMappedAttribute): Check type before adding height and width style. (WebCore::HTMLInputElement::attach): Remove code for discarding width.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::respectHeightAndWidthAttrs): New method added to report if this input type uses height & width.
8:12 PM Changeset in webkit [15043] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Adele.


  • Added JSConstructorMake to match JSFunctionMake, along with test code.


[ I checked in the ChangeLog before without the actual files. ]

  • API/JSObjectRef.cpp: (JSConstructorMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.
7:17 PM Changeset in webkit [15042] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


Bug 9568: assertion failure in Safari after quitting Drosera
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9568

Call switchToServerNamed:nil and not removeLister to make sure
the server object is set to nil to prevent further removeListener calls.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument applicationTerminating:]):
5:28 PM Changeset in webkit [15041] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
  • fast/forms/textarea-hard-linewrap.html: Ditto.
4:55 PM Changeset in webkit [15040] by ddkilzer
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/forms/textarea-hard-linewrap-empty.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for m_div->firstChild()->renderer().

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap-empty.html: Added.
  • fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and renamed function from foo() to submitForm().
4:28 PM Changeset in webkit [15039] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find that the directory is not empty instead of reading in every single file and directory first, then checking the count. Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not defined.
4:17 PM Changeset in webkit [15038] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/repaint/outline-shrinking.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is becoming narrower, even if we are going to relayout.

LayoutTests:

Reviewed by Darin.

  • fast/repaint/outline-shrinking-expected.checksum: Added.
  • fast/repaint/outline-shrinking-expected.png: Added.
  • fast/repaint/outline-shrinking-expected.txt: Added.
  • fast/repaint/outline-shrinking.html: Added.
2:45 PM Changeset in webkit [15037] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebKit

Adds an SPI Mail needs, and versioning.

2:42 PM Changeset in webkit [15036] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebCore

Build fix, and versioning.

2:38 PM Changeset in webkit [15035] by thatcher
  • 1 copy in tags/Safari-521.13.1

New tag.

1:56 PM Changeset in webkit [15034] by thatcher
  • 3 edits in trunk/WebCore

Build fix for for GCC 5406

1:37 PM Changeset in webkit [15033] by thatcher
  • 1 edit in trunk/WebCore/dom/Document.cpp

Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.

1:37 PM Changeset in webkit [15032] by ddkilzer
  • 9 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent):

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

  • fast/dom/window-xy-properties-expected.txt: Added.
  • fast/dom/window-xy-properties.html: Added.
1:32 PM Changeset in webkit [15031] by thatcher
  • 1 edit in trunk/WebKit/DefaultDelegates/WebScriptDebugServer.m

Leak fix

1:01 PM Changeset in webkit [15030] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Tweak comments.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
12:42 PM Changeset in webkit [15029] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Formatting fix per Bug 9571 Comment #2. Reviewed by NOBODY.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571#c2

  • Scripts/svn-apply: Formatting fix.
12:39 PM Changeset in webkit [15028] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
Teach svn-apply and svn-unapply to handle directory adds and removes better

  • Scripts/svn-apply: Handle directory adds more intelligently. Handle directory removes.
  • Scripts/svn-unapply: Handle undoing both directory adds and removes.
11:59 AM Changeset in webkit [15027] by thatcher
  • 20 edits in trunk/LayoutTests

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9560


This fix converted the resize corner image to a B/W tiff.
The pixel tests showed 0.0% changes but still said it had differences.
Updating the tests that use CSS3 resize or textarea.

  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/negativeLineHeight-expected.checksum:
  • fast/forms/negativeLineHeight-expected.png:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/forms/textarea-setinnerhtml-expected.checksum:
  • fast/forms/textarea-setinnerhtml-expected.png:
  • fast/overflow/overflow-x-y-expected.checksum:
  • fast/overflow/overflow-x-y-expected.png:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
10:53 AM Changeset in webkit [15026] by thatcher
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Pass the starting line number and error message to the debugger.

  • kjs/debugger.cpp: (Debugger::sourceParsed):
  • kjs/debugger.h:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):

WebCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Pass the starting line number and error message to the debugger.
  • Call parsedSource even if there was a script parse error so the debugger can show the parse error.
  • Pass NSURL objects to the ObjC delegate for the script URLs.
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreScriptDebugger.mm: (toNSURL): (WebCoreScriptDebuggerImp::sourceParsed):

WebKit:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Adds a new version of the didParseSource delegate callback with base line number.
  • Adds a new delegate callback for when a script fails to parse.
  • These new callbacks use NSURLs for the url parameter.
  • Adds a new script listener callback to notify when the main resource loads.
  • Adds a WebScriptErrorDomian and other keys for use with NSError.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebKit.exp:
  • WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):

WebKitTools:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Refactor the JavaScript code to have a distinction between files
and scripts. Show the script in the context of the HTML file if
it's URL is the same as the frame's main resource. At the time of
the disParseScript callback the main resource might not be completely
loaded, but Drosera needs to show whatever we have at the time. Once
the main resource is finished, update the file source and reload the file.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument pause]): (-[DebuggerDocument webView:didLoadMainResourceForDataSource:]): (-[DebuggerDocument webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • Drosera/debugger.css:
  • Drosera/debugger.js:

Jun 24, 2006:

11:01 PM Changeset in webkit [15025] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9570
Teach prepare-ChangeLog to operate on a list of files or directories

  • Scripts/prepare-ChangeLog: Accept a list of files and/or directories when running.
  • Scripts/svn-create-patch: Code refactoring.
8:02 PM Changeset in webkit [15024] by ddkilzer
  • 8 edits
    2 deletes in trunk

WebCore:

Build fix. Reviewed by NOBODY.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Build fix. Reviewed by NOBODY.

  • fast/dom/window-xy-properties-expected.txt: Removed.
  • fast/dom/window-xy-properties.html: Removed.
7:09 PM Changeset in webkit [15023] by ddkilzer
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Darin. Patch by Rob Buis.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

Test: fast/dom/window-xy-properties.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

  • fast/dom/window-xy-properties-expected.txt: Added.
  • fast/dom/window-xy-properties.html: Added.
6:53 PM Changeset in webkit [15022] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin. Patch by James G. Speth.

  • plugins/jsobjc-dom-wrappers-expected.txt: Added.
  • plugins/jsobjc-dom-wrappers.html: Added.
  • plugins/jsobjc-simple-expected.txt: Added.
  • plugins/jsobjc-simple.html: Added.
2:55 PM Changeset in webkit [15021] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9352>
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

  • svg/custom/gradient-stroke-width-expected.checksum: Added.
  • svg/custom/gradient-stroke-width-expected.png: Added.
  • svg/custom/gradient-stroke-width-expected.txt: Added.
  • svg/custom/gradient-stroke-width.svg: Added.

WebCore:

Reviewed by Darin. Patch by Rob Buis.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9352
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

Make sure the stroke path is set before applying gradient transforms.

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
2:08 PM Changeset in webkit [15020] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin. Patch by James G. Speth.

Tests running in DumpRenderTree can choose to relax some restrictions of the JavaScript/Objective-C bridge
allowing more extensive testing of the Obj-C API. (and by more extensive, I mean this lets scripts do
pretty much whatever they want, including acting as delegates, generating events, instantiating obj-c
objects, etc... )

  • DumpRenderTree/ObjCPlugin.h:
  • DumpRenderTree/ObjCPlugin.m: this ability is only exposed to scripts running in DumpRenderTree (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin removeBridgeRestrictions:]): scripts call this to open up obj-c for extensive testing (+[NSObject setAllowsScriptsFullAccess:]): makes NSObject allow all selectors to be invoked from script (+[NSObject allowsScriptsFullAccess]): (+[NSObject isSelectorExcludedFromWebScript:]): when full access is enabled, no selector is excluded (+[NSObject webScriptNameForSelector:]): always return nil for the default selector mutation (-[JSObjC classNameOfObject:isSelectorExcludedFromWebScript:]): (+[JSObjC webScriptNameForSelector:]): (-[JSObjC invokeDefaultMethodWithArguments:]): shortcut for accessing classes (-[JSObjC lookUpClass:]): allow scripts to retrieve obj-c classes by name (-[JSObjC log:]): access to NSLog function (-[JSObjC retainObject:]): useful obj-c functions that are otherwise hard to reach from javascript (-[JSObjC classOfObject:]): (-[JSObjC classNameOfObject:]):
2:07 PM Changeset in webkit [15019] by ap
  • 4 edits in trunk

Rubber-stamped by Eric.

Add a -h (do not follow symlinks) option to ln in derived sources build script (without it,
a symlink was created inside the source directory on second build).

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
1:51 PM Changeset in webkit [15018] by ddkilzer
  • 7 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by James G. Speth. Copyrights tweaked by ddkilzer.


Bug 8331: DOMNodeLists returned to Objective-C are not properly wrapped
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8331


DOMNodes were the only objects handled by createObjcInstanceForValue.
now it handles all of these: DOMNode, DOMNodeList, DOMNamedNodeMap, DOMStyleSheetList,
DOMStyleSheet, DOMMediaList, DOMCSSRuleList, DOMCSSRule, DOMCSSStyleDeclaration, and DOMCSSValue


  • WebCore.xcodeproj/project.pbxproj: added file DOMCSSInternal.h to project
  • bindings/js/kjs_css.cpp: (KJS::): changed ClassInfo for DOMCSSStyleSheet to have DOMStyleSheet as its parent class
  • bindings/objc/DOM.mm: (-[DOMDocumentType :]): moved DOMNamedNodeMap (WebCoreInternal) interface to DOMInternal.h
  • bindings/objc/DOMCSS.mm: moved WebCoreInternal interfaces to DOMCSSInternal.h
  • bindings/objc/DOMCSSInternal.h: Added file, contains WebCoreInternal interface for CSS classes
  • bindings/objc/DOMInternal.h: added DOMNamedNodeMap (WebCoreInternal) interface
  • bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue): support for more classes
1:01 PM Changeset in webkit [15017] by ddkilzer
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

JavaScriptGlue:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

WebCore:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.
  • manual-tests/NPN_Invoke/Info.plist: Added copyright statement.

WebKit:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

WebKitTools:

Reviewed by Timothy.

  • DrawTest/Info.plist: Added copyright statement.
  • Drosera/Info.plist: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Ditto.
  • WebKitLauncher/Info.plist: Ditto.
12:00 PM Changeset in webkit [15016] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Build fix. Reviewed by NOBODY.

  • Scripts/webkitdirs.pm: Backed out previous change.
11:45 AM Changeset in webkit [15015] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej. Patch by Bjoern Graf.

  • Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
9:02 AM Changeset in webkit [15014] by ap
  • 5 edits
    4 adds in trunk

2006-06-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/css/resize-corner-tracking.html

  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Store the offset from the layer's resizing corner where dragging has started. (WebCore::FrameView::handleMouseMoveEvent): Pass the stored offset to the layer's resize method.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Added an offset parameter, which is added to the mouse location. For objects that may have intrinsic margins applied to them, added code to lift the margins into the object's style in order to keep them constant. Changed to take the content size as the base size if the box-sizing property is content-box. (WebCore::RenderLayer::offsetFromResizeCorner): Added. Returns the offset of the given point from the corner that tracks the mouse when resizing.
  • rendering/RenderLayer.h:
8:52 AM Changeset in webkit [15013] by ap
  • 5 edits
    4 adds in trunk

Reviewed by Darin, landed by ap.

Test: fast/forms/floating-textfield-relayout.html

  • page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added. During subtree relayout, returns the subtree root. Otherwise returns 0. (WebCore::FrameView::layoutPending): Made const.
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Added early return if this is the root of a subtree being laid out.
8:37 AM Changeset in webkit [15012] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Add an -all-interfaces (-a) flag to bind to all interfaces, not just 127.0.0.1. Useful for testing with WinIE running on another machine;
  • don't call checkFrameworks() - we do not need a built WebKit here;
  • changed tabs to spaces;
  • disable HTTP keepalive (since Apache doesn't spawn sub-processes in interactive mode, they were a hassle when testing with several browsers, as one had to wait for connection to expire);
  • remove httpd.pid when done, so that Apache doesn't complain next time.
  • Scripts/run-webkit-httpd:
8:09 AM Changeset in webkit [15011] by ddkilzer
  • 116 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • css1/classification/white_space-expected.checksum:
  • css1/classification/white_space-expected.png:
  • css1/classification/white_space-expected.txt:
  • editing/selection/select-all-004-expected.checksum:
  • editing/selection/select-all-004-expected.png:
  • editing/selection/select-all-004-expected.txt:
  • editing/selection/unrendered-001-expected.checksum:
  • editing/selection/unrendered-001-expected.png:
  • editing/selection/unrendered-001-expected.txt:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/selection/unrendered-002-expected.txt:
  • editing/selection/unrendered-003-expected.checksum:
  • editing/selection/unrendered-003-expected.png:
  • editing/selection/unrendered-003-expected.txt:
  • editing/selection/unrendered-004-expected.checksum:
  • editing/selection/unrendered-004-expected.png:
  • editing/selection/unrendered-004-expected.txt:
  • editing/selection/unrendered-005-expected.checksum:
  • editing/selection/unrendered-005-expected.png:
  • editing/selection/unrendered-005-expected.txt:
  • fast/block/float/019-expected.checksum:
  • fast/block/float/019-expected.png:
  • fast/block/float/019-expected.txt:
  • fast/block/margin-collapse/104-expected.checksum:
  • fast/block/margin-collapse/104-expected.png:
  • fast/block/margin-collapse/104-expected.txt:
  • fast/block/positioning/relative-overflow-block-expected.checksum:
  • fast/block/positioning/relative-overflow-block-expected.txt:
  • fast/block/positioning/relative-overflow-replaced-expected.checksum:
  • fast/block/positioning/relative-overflow-replaced-expected.txt:
  • fast/block/positioning/relative-overflow-replaced-float-expected.checksum:
  • fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • fast/lists/li-br-expected.checksum:
  • fast/lists/li-br-expected.png:
  • fast/lists/li-br-expected.txt:
  • fast/media/mq-relative-constraints-02-expected.checksum:
  • fast/media/mq-relative-constraints-02-expected.png:
  • fast/media/mq-relative-constraints-02-expected.txt:
  • fast/media/mq-relative-constraints-03-expected.checksum:
  • fast/media/mq-relative-constraints-03-expected.png:
  • fast/media/mq-relative-constraints-03-expected.txt:
  • fast/media/mq-relative-constraints-04-expected.checksum:
  • fast/media/mq-relative-constraints-04-expected.png:
  • fast/media/mq-relative-constraints-04-expected.txt:
  • fast/media/mq-relative-constraints-05-expected.checksum:
  • fast/media/mq-relative-constraints-05-expected.png:
  • fast/media/mq-relative-constraints-05-expected.txt:
  • fast/media/mq-relative-constraints-06-expected.checksum:
  • fast/media/mq-relative-constraints-06-expected.png:
  • fast/media/mq-relative-constraints-06-expected.txt:
  • fast/media/mq-relative-constraints-07-expected.checksum:
  • fast/media/mq-relative-constraints-07-expected.png:
  • fast/media/mq-relative-constraints-07-expected.txt:
  • fast/media/mq-relative-constraints-09-expected.checksum:
  • fast/media/mq-relative-constraints-09-expected.png:
  • fast/media/mq-relative-constraints-09-expected.txt:
  • fast/media/mq-width-absolute-01-expected.checksum:
  • fast/media/mq-width-absolute-01-expected.png:
  • fast/media/mq-width-absolute-01-expected.txt:
  • fast/media/mq-width-absolute-02-expected.checksum:
  • fast/media/mq-width-absolute-02-expected.png:
  • fast/media/mq-width-absolute-02-expected.txt:
  • fast/media/mq-width-absolute-03-expected.checksum:
  • fast/media/mq-width-absolute-03-expected.png:
  • fast/media/mq-width-absolute-03-expected.txt:
  • fast/media/mq-width-absolute-04-expected.checksum:
  • fast/media/mq-width-absolute-04-expected.png:
  • fast/media/mq-width-absolute-04-expected.txt:
  • fast/table/wide-colspan-expected.checksum:
  • fast/table/wide-colspan-expected.png:
  • fast/table/wide-colspan-expected.txt:
  • fast/table/wide-column-expected.checksum:
  • fast/table/wide-column-expected.png:
  • fast/table/wide-column-expected.txt:
  • tables/mozilla/bugs/bug131020-expected.checksum:
  • tables/mozilla/bugs/bug131020-expected.png:
  • tables/mozilla/bugs/bug131020-expected.txt:
  • tables/mozilla/bugs/bug23151-expected.checksum:
  • tables/mozilla/bugs/bug23151-expected.png:
  • tables/mozilla/bugs/bug23151-expected.txt:
  • tables/mozilla/bugs/bug29314-expected.checksum:
  • tables/mozilla/bugs/bug29314-expected.png:
  • tables/mozilla/bugs/bug29314-expected.txt:
  • tables/mozilla/bugs/bug43039-expected.checksum:
  • tables/mozilla/bugs/bug43039-expected.png:
  • tables/mozilla/bugs/bug43039-expected.txt:
  • tables/mozilla/bugs/bug43854-1-expected.checksum:
  • tables/mozilla/bugs/bug43854-1-expected.png:
  • tables/mozilla/bugs/bug43854-1-expected.txt:
  • tables/mozilla/bugs/bug625-expected.checksum:
  • tables/mozilla/bugs/bug625-expected.png:
  • tables/mozilla/bugs/bug625-expected.txt:
  • tables/mozilla/bugs/bug92143-expected.checksum:
  • tables/mozilla/bugs/bug92143-expected.png:
  • tables/mozilla/bugs/bug92143-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.checksum:
  • tables/mozilla/bugs/bug96334-expected.png:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla/core/nested1-expected.checksum:
  • tables/mozilla/core/nested1-expected.png:
  • tables/mozilla/core/nested1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

The change affects many existing tests.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Mark the body renderer as needing layout if the view's height has changed and the body stretches to the view's height.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
  • rendering/RenderBox.h: (WebCore::RenderBox::stretchesToViewHeight): Added. Moved the logic for when the HTML block needs to stretch to the view's height from calcHeight() here.
8:00 AM Changeset in webkit [15010] by ap
  • 3 edits
    7 adds in trunk

Reviewed by Darin.

Test: http/tests/uri/utf8-path.html

  • platform/KURL.cpp: (encodeRelativeString): Always set pathEncoding to UTF-8.
7:43 AM Changeset in webkit [15009] by ap
  • 18 edits
    4 adds in trunk

2006-06-24 Graham Dennis <​Graham.Dennis@gmail.com>

Reviewed by Darin, landed by ap.



Test: traversal/stay-within-root.html

  • dom/Node.cpp: (WebCore::Node::traversePreviousNode):
  • dom/Node.h: Add a stayWithin argument to traversePreviousNode just like the other traversal functions
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::findNextNode): (WebCore::NodeIterator::findPreviousNode): Ensure that when moving forward or backward that the root node is not exited
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Ditto (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
6:50 AM Changeset in webkit [15008] by ap
  • 10 edits
    3 adds in trunk

svn-commit.tmp

6:01 AM Changeset in webkit [15007] by ap
  • 4 edits in trunk/WebCore

2006-06-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

No test added because there is no change in functionality.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::layout):
5:53 AM Changeset in webkit [15006] by ap
  • 19 edits in trunk/WebCore

Reviewed by Darin.

No change in functionality, thus no test.

Use info sharing for named collections, too. Moved shared HTMLCollection infos from HTMLDocument
to Document. Renamed collection types to use the preferred WebKit style. Replaced direct
HTMLCollection creation with using accessors from Document in a few places.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement children]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLMapElement areas]): (-[DOMHTMLTableSectionElement rows]): (-[DOMHTMLTableElement rows]): (-[DOMHTMLTableElement tBodies]): (-[DOMHTMLTableRowElement cells]):
  • dom/Document.cpp: (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems): (WebCore::Document::nameCollectionInfo):
  • dom/Document.h: (WebCore::Document::collectionInfo):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::traverseNextItem): (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::):
  • html/HTMLDocument.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::children):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
  • html/HTMLNameCollection.h:
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): (WebCore::HTMLNameCollection::traverseNextItem):
  • html/HTMLFormCollection.cpp:
  • html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]):
  • page/Frame.cpp: (WebCore::Frame::gotoAnchor):
4:50 AM Changeset in webkit [15005] by ap
  • 6 edits in trunk

Reviewed by Darin.

Enclose search paths in quotes; create symlinks to avoid passing paths with spaces to make.

  • JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
  • WebCore/WebCore.xcodeproj/project.pbxproj:
  • WebKit/WebKit.xcodeproj/project.pbxproj:

Jun 23, 2006:

10:19 PM Changeset in webkit [15004] by tomernic
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken


  • fast/events/ondragenter-expected.checksum: Added.
  • fast/events/ondragenter-expected.png: Added.
  • fast/events/ondragenter-expected.txt: Added.
  • fast/events/ondragenter.html: Added.

WebCore:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken

  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Use the passed mouse event, instead of the "current" event. There is no such thing as a "drag event". Asking for the current event during a drag returns a weird system- internal event with an invalid mouse location.
10:07 PM Changeset in webkit [15003] by thatcher
  • 22 edits
    5 adds in trunk/WebCore

Reviewed by Eric.

Manual test added: cursor.html

Bug 9560: should support new CSS3 cursor types to get more resizing directions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9560

Adds support for ew-resize, ns-resize, nesw-resize, nwse-resize,
col-resize and row-resize CSS3 cursor values.

Also converted some of the cursor images to grayscale tiffs,
some were RGB but had no color data.

  • Resources/eastResizeCursor.tiff:
  • Resources/eastWestResizeCursor.tiff: Added.
  • Resources/helpCursor.tiff:
  • Resources/moveCursor.tiff:
  • Resources/northEastResizeCursor.tiff:
  • Resources/northEastSouthWestResizeCursor.tiff: Added.
  • Resources/northResizeCursor.tiff:
  • Resources/northSouthResizeCursor.tiff: Added.
  • Resources/northWestResizeCursor.tiff:
  • Resources/northWestSouthEastResizeCursor.tiff: Added.
  • Resources/southEastResizeCursor.tiff:
  • Resources/southResizeCursor.tiff:
  • Resources/southWestResizeCursor.tiff:
  • Resources/textAreaResizeCorner.tiff:
  • Resources/waitCursor.tiff:
  • Resources/westResizeCursor.tiff:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • manual-tests/cursor.html: Added.
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • platform/win/CursorWin.cpp: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • rendering/render_style.h: cursor needs 5 bits now
6:09 PM Changeset in webkit [15002] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Adding more operator[] overloads for long and short types.

  • wtf/Vector.h: (WTF::Vector::operator[]):
5:58 PM Changeset in webkit [15001] by kdecker
  • 4 edits in trunk/WebKitTools
4:56 PM Changeset in webkit [15000] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Fixed a bug I found in the CoreGraphics drawing model that was preventing certain types of events from being dispatched to the plugin, unless the plugin was being updated. The check for portState was only required to call -setWindowIfNecessary, not required for the entire event dispatch. Also, don't paint the green debug rect unless this is a QuickDraw plugin. Otherwise the current QD port is not set, and the green rect fills the entire screen. Pretty awesome looking, but not intended behavior. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Improved the logging here to include the NPWindow's width and height.
4:34 PM Changeset in webkit [14999] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Tim O.

Adds back SPI that Mail is still depending on.

  • WebView/WebDataSource.m: (-[WebDataSource _addSubframeArchives:]):
  • WebView/WebDataSourcePrivate.h:
4:12 PM Changeset in webkit [14998] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Tim Omernick


  • fixed <rdar://problem/4597685> stale rects for document markers can be left behind in certain cases
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker): changed parameter from IntRect to const IntRect& at Darin's request (WebCore::Document::invalidateRenderedRectsForMarkersInRect): new method, tests whether the rendered rect for each marker intersects the passed rect. If so, sets the rendered rect back to the placeholder rect that means that the rect for this marker isn't known.


  • page/Frame.cpp: (WebCore::Frame::paint): call invalidateRenderedRectsForMarkersInRect on the rect we're about to paint. This ensures that old stale rects won't be preserved if the associated marker has moved such that it is out of the painted area.
3:38 PM Changeset in webkit [14997] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Added bug number.

3:36 PM Changeset in webkit [14996] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
  • editing/deleting/merge-into-empty-block-1-expected.png: Added.
  • editing/deleting/merge-into-empty-block-1-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-1.html: Added.
  • editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
  • editing/deleting/merge-into-empty-block-2-expected.png: Added.
  • editing/deleting/merge-into-empty-block-2-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-2.html: Added.

WebCore:

Reviewed by levi

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Add a rule for when to merge into empty blocks.
3:08 PM Changeset in webkit [14995] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Adele.


  • Added JSConstructorMake to match JSFunctionMake, along with test code.
  • API/JSObjectRef.cpp: (JSConstructorMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.
2:43 PM Changeset in webkit [14994] by thatcher
  • 8 copies in tags/Safari-521.13

New tag for 521.13.

2:36 PM Changeset in webkit [14993] by thatcher
  • 3 edits in trunk

Versoning

2:27 PM Changeset in webkit [14992] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4223619> Safari crashed in -[NSFont isSystemFont]
CFRetain and CFRelease NSFont's when FontPlatformData has a reference.
We only do this when GC is enabled for performance reasons.
No tests possible.

  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
2:19 PM Changeset in webkit [14991] by justing
  • 5 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

Demonstrates 9557:

  • editing/input/range-for-empty-document-expected.txt: Added:
  • editing/selection/table-caret-1-expected.checksum: Added.
  • editing/selection/table-caret-1-expected.png: Added.
  • editing/selection/table-caret-1-expected.txt: Added.
  • editing/selection/table-caret-1.html: Added.
  • editing/selection/table-caret-2-expected.checksum: Added.
  • editing/selection/table-caret-2-expected.png: Added.
  • editing/selection/table-caret-2-expected.txt: Added.
  • editing/selection/table-caret-2.html: Added.
  • editing/selection/table-caret-3-expected.checksum: Added.
  • editing/selection/table-caret-3-expected.png: Added.
  • editing/selection/table-caret-3-expected.txt: Added.
  • editing/selection/table-caret-3.html: Added.

WebCore:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Don't propagate to children, VisiblePositions inside containers don't refer to children. Don't use the font height for tables.
1:04 PM Changeset in webkit [14990] by thatcher
  • 9 edits in trunk/WebKit

Reviewed by Geoff.

script debugger should only attach to JavaScriptCore when there are listeners
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9552

Attaches the debugger to all WebFrames when the first listener
is added. Detaches when the last listener is removed.
Also detach when the script debug delegate is set to nil.

  • DefaultDelegates/WebScriptDebugServer.m: (+[WebScriptDebugServer listenerCount]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer attachScriptDebuggerToAllWebViews]): (-[WebScriptDebugServer detachScriptDebuggerFromAllWebViews]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebView/WebFrame.m: (-[WebFrame _attachScriptDebugger]): (-[WebFrame _detachScriptDebugger]):
  • WebView/WebFramePrivate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView setScriptDebugDelegate:]):
  • WebView/WebViewPrivate.h:
10:51 AM Changeset in webkit [14989] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Added 64-bit String::number() functions

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::number):
10:37 AM Changeset in webkit [14988] by thatcher
  • 1 edit in trunk/WebCore/dom/Document.cpp

Build fix.

9:16 AM Changeset in webkit [14987] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick


  • added support for UIDelegate to be notified of scrolling in any WebHTMLView
  • cleaned up recently-added UIDelegate code
  • WebView/WebUIDelegatePrivate.h: declared webView:didScrollDocumentInFrameView: method
  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:didDrawRect:]): provide default (empty) implementation of this recently-added method, so the DelegateForwarder mechanism will work for it (-[NSApplication webView:didScrollDocumentInFrameView:]): same thing for the new method


  • WebView/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): use _UIDelegateForwarder mechanism to notify delegate that scrolling occurred (-[NSArray drawSingleRect:]): use _UIDelegateForwarder mechanism instead of checking respondsToSelector stuff here (that's packaged up nicely by the forwarder mechanism)

Jun 22, 2006:

9:43 PM Changeset in webkit [14986] by ap
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • API/JSObjectRef.cpp: Changed "identifier.h" to "Identifier.h"
9:37 PM Changeset in webkit [14985] by ap
  • 4 edits in trunk

Reviewed by darin and ggaren.

WebKitTools:

  • Scripts/webkitdirs.pm: Building WebKit now requires Xcode 2.3.

WebKitSite:

  • building/build.html: Ditto.
9:18 PM Changeset in webkit [14984] by thatcher
  • 10 edits in trunk/WebKitTools

Reviewed by Eric.

Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument stepInto]): (-[DebuggerDocument pause:]): (-[DebuggerDocument resume:]): (-[DebuggerDocument stepInto:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
  • Drosera/viewer.html:
9:07 PM Changeset in webkit [14983] by ddkilzer
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • fast/repaint/clipped-relative-expected.checksum: Added.
  • fast/repaint/clipped-relative-expected.png: Added.
  • fast/repaint/clipped-relative-expected.txt: Added.
  • fast/repaint/clipped-relative.html: Added.
  • fast/repaint/containing-block-position-change-expected.checksum: Updated.
  • fast/repaint/containing-block-position-change-expected.png: Updated.

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/repaint/clipped-relative.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects(). Previously, it was needed to update the cached rects before RenderBox::setStyle() called updateLayerPositions().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly- created layer only if it does not need layout. Otherwise, updateLayerPositions() will be called after layout. This saves a repaint in some cases.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to this and deleted the code that cached the absolute position and repaint rects. (WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute position and repaint rects right after updating the layer's position.
  • rendering/RenderLayer.h:
7:25 PM Changeset in webkit [14982] by thatcher
  • 2 edits in trunk/WebKitTools/Drosera

Adding an image that wasn't added to the project earlier.

7:00 PM Changeset in webkit [14981] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4599015> REGRESSION: Hand on clock widget
don't appear at all

This regression was caused by <rdar://problem/4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Do the contains check before rounding to integral device pixels.
4:12 PM Changeset in webkit [14980] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.
2:31 PM Changeset in webkit [14979] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader methods.
2:10 PM Changeset in webkit [14978] by thatcher
  • 8 edits in /

Versioning

12:01 PM Changeset in webkit [14977] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)
11:48 AM Changeset in webkit [14976] by mjs
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Adele.


  • start moving loading logic to new WebFrameLoader class; move management of WebLoaders there
  • Misc/WebIconLoader.h:
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource finalize]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView/WebFrameLoader.h: Added.
  • WebView/WebFrameLoader.m: Added. (-[WebFrameLoader initWithDataSource:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader hasIconLoader]): (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader stopLoadingIcon]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoading]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]):
11:34 AM Changeset in webkit [14975] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

  • html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0


  • fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
  • fast/dom/noscript-canvas-in-created-html-document.html: Added.
10:48 AM Changeset in webkit [14974] by kdecker
  • 3 edits
    1 add in trunk/WebKitTools
10:46 AM Changeset in webkit [14973] by andersca
  • 6 edits
    4 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown


  • dom/xml_tokenizer.cpp: (WebCore::shouldAllowExternalLoad): Use correct path for the catalog.


(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.


(WebCore::XMLTokenizer::write):
Remove if (0 &&)


(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.


(WebCore::xmlDocPtrForString):

  • dom/xml_tokenizer.h: Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.


  • xml/XSLTProcessor.cpp: (WebCore::xmlDocPtrFromNode): Pass DocLoader to xmlDocPtrForString


LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

  • fast/xsl/dtd-in-source-document-expected.txt: Added.
  • fast/xsl/dtd-in-source-document.xml: Added.
  • fast/xsl/resources/dtd-in-source-document.dtd: Added.
  • fast/xsl/resources/dtd-in-source-document.xsl: Added.
10:34 AM Changeset in webkit [14972] by thatcher
  • 8 edits in trunk/WebKitTools

Reviewed by Kevin Decker.

Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument dealloc]): (-[DebuggerDocument currentFrame]): (-[DebuggerDocument currentFrameFunctionName]): (-[DebuggerDocument currentFunctionStack]): (-[DebuggerDocument log:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
10:18 AM Changeset in webkit [14971] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

Teach run-webkit-httpd to properly look for webkitdirs.pm.

  • Scripts/run-webkit-httpd:
8:01 AM Changeset in webkit [14970] by kdecker
  • 5 edits
    5 adds in trunk/WebKitTools
3:38 AM Changeset in webkit [14969] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Build fix.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build

  • API/APICast.h: Changed "UString.h" to "ustring.h".

Jun 21, 2006:

5:58 PM Changeset in webkit [14968] by hyatt
  • 5 edits in trunk/WebCore

Back out -webkit-overlay and just rename it back to overlay.

Reviewed by darin

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
5:26 PM Changeset in webkit [14967] by thatcher
  • 1 copy in tags/WebCore-315.14.3/WebCore

Tag for WebCore 315.14.3 (part 2 of 2.)

5:26 PM Changeset in webkit [14966] by thatcher
  • 1 add in tags/WebCore-315.14.3

Tag for WebCore 315.14.3 (part 1 of 2.)

5:26 PM Changeset in webkit [14965] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

5:22 PM Changeset in webkit [14964] by thatcher
  • 1 copy in tags/WebCore-418.19.1/WebCore

Tag for WebCore 418.19.1 (part 2 of 2.)

5:22 PM Changeset in webkit [14963] by thatcher
  • 1 add in tags/WebCore-418.19.1

Tag for WebCore 418.19.1 (part 1 of 2.)

5:20 PM Changeset in webkit [14962] by justing
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/deleting/table-cells-expected.checksum: Added.
  • editing/deleting/table-cells-expected.png: Added.
  • editing/deleting/table-cells-expected.txt: Added.
  • editing/deleting/table-cells.html: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.checksum: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
  • editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
  • editing/inserting/paragraph-separator-in-table-1.html: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.checksum: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
  • editing/inserting/paragraph-separator-in-table-2.html: Added.

WebCore:

Reviewed by levi

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Fix a bug in the code to stop merges across table cells. (WebCore::DeleteSelectionCommand::mergeParagraphs): Move the code to stop merges across table cells to initializePositionData so that its changes to m_mergeBlocksAfterDelete can take effect on the endingPosition.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreak instead of splitting/cloning a table cell.
5:13 PM Changeset in webkit [14961] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:00 PM Changeset in webkit [14960] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.
4:50 PM Changeset in webkit [14959] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add overflow-x and overflow-y tests.

4:40 PM Changeset in webkit [14958] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.
4:38 PM Changeset in webkit [14957] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by John.

Fix for <rdar://problem/3914965> Misspelled text underline doesn't
look right at non-standard scale factors

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): We need to call into our previously-created SPI for pattern-drawing so that the phase is right at all scale factors.
4:15 PM Changeset in webkit [14956] by thatcher
  • 4 edits in trunk

Switching to Stabs debugging format for Production builds.

4:13 PM Changeset in webkit [14955] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Maciej

The WebCoreIconDatabaseBridge was getting messages sent to it after it had been closed, resulting in a crash
on an ASSERT(). After closing the databaseBridge, we simply set it to nil so this can't happen.
anymore.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):
4:10 PM Changeset in webkit [14954] by ggaren
  • 4 edits in trunk/JavaScriptCore

Fixed release build, fixed accidental infinite recursion due to
last minute global replace gone awry.


  • API/APICast.h: (toRef):
  • API/testapi.c: (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr):
  • JavaScriptCore.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [14953] by hyatt
  • 18 edits in trunk/WebCore

Fix for 7362, implement the CSS3 overflow-x and overflow-y properties.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::calcMinMaxWidth):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::shouldAutoscroll): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasAutoVerticalScrollbar): (WebCore::RenderObject::hasAutoHorizontalScrollbar): (WebCore::RenderObject::scrollsOverflow): (WebCore::RenderObject::scrollsOverflowX): (WebCore::RenderObject::scrollsOverflowY): (WebCore::RenderObject::includeVerticalScrollbarSize): (WebCore::RenderObject::includeHorizontalScrollbarSize):
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::setStyle):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight): (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff):
  • rendering/render_style.h: (WebCore::): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::overflowX): (WebCore::RenderStyle::overflowY): (WebCore::RenderStyle::setOverflowX): (WebCore::RenderStyle::setOverflowY): (WebCore::RenderStyle::initialOverflowX): (WebCore::RenderStyle::initialOverflowY):
2:22 PM Changeset in webkit [14952] by justing
  • 37 edits
    9 adds
    1 delete in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT


Added:

  • editing/selection/line-wrap-1-expected.checksum: Added.
  • editing/selection/line-wrap-1-expected.png: Added.
  • editing/selection/line-wrap-1-expected.txt: Added.
  • editing/selection/line-wrap-1.html: Added.
  • editing/selection/line-wrap-2-expected.checksum: Added.
  • editing/selection/line-wrap-2-expected.png: Added.
  • editing/selection/line-wrap-2-expected.txt: Added.
  • editing/selection/line-wrap-2.html: Added. Fixes:
  • editing/execCommand/findString-expected.checksum:
  • editing/execCommand/findString-expected.png:
  • editing/execCommand/findString-expected.txt:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-tab-002-expected.txt:
  • editing/inserting/insert-text-with-newlines-expected.txt:
  • editing/inserting/typing-001-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/inserting/typing-around-br-001-expected.txt:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-after-paragraph-expected.txt:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/remove-underline-in-bold-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/style/unbold-in-bold-expected.txt:
  • editing/style/underline-expected.txt: Disabled (9337):
  • editing/input/attributed-substring-from-range-lines.html

WebCore:

Reviewed by levi


<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

  • dom/Document.cpp: (WebCore::Document::updateSelection): Use the leftmost candidate for the end of the selection and the rightmost candidate for the start of the selection.
  • dom/Position.cpp: (WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream to get to candidates before/after linewraps. (WebCore::Position::downstream): (WebCore::Position::inRenderedContent):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ensure that the leftmost candidate is used. We should sample the style from that one. When the block to insert is after a br, a br should be inserted even in strict mode.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition. Don't apply a style if its unnecessary.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
  • editing/VisiblePosition.cpp: Renamed initDeepPosition and made it return the canonical position. (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::characterBefore): Added.
  • editing/visible_units.cpp: (WebCore::startOfParagraph):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend onto the next line.
2:09 PM Changeset in webkit [14951] by ggaren
  • 20 edits
    19 adds in trunk

JavaScriptCore:

Reviewed by Anders.


  • First cut at C API to JavaScript. Includes a unit test, 'testapi.c', and the outline of a test app, 'minidom.c'.


Includes one change to JSC internals: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.


Also, I just ran prepare-ChangeLog in about 10 seconds, and I would like
to give a shout-out to that.


  • API/APICast.h: Added. (toJS): (toRef):
  • API/JSBase.h: Added.
  • API/JSCallbackObject.cpp: Added. (KJS::): (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::className): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::implementsConstruct): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::implementsCall): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::setPrivate): (KJS::JSCallbackObject::getPrivate): (KJS::JSCallbackObject::cachedValueGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSCallbackObject.h: Added. (KJS::JSCallbackObject::classInfo):
  • API/JSCharBufferRef.cpp: Added. (JSStringMake): (JSCharBufferCreate): (JSCharBufferCreateUTF8): (JSCharBufferRetain): (JSCharBufferRelease): (JSValueCopyStringValue): (JSCharBufferGetLength): (JSCharBufferGetCharactersPtr): (JSCharBufferGetCharacters): (JSCharBufferGetMaxLengthUTF8): (JSCharBufferGetCharactersUTF8): (JSCharBufferIsEqual): (JSCharBufferIsEqualUTF8): (JSCharBufferCreateWithCFString): (CFStringCreateWithJSCharBuffer):
  • API/JSCharBufferRef.h: Added.
  • API/JSContextRef.cpp: Added. (JSContextCreate): (JSContextDestroy): (JSContextGetGlobalObject): (JSEvaluate): (JSCheckSyntax): (JSContextHasException): (JSContextGetException): (JSContextClearException): (JSContextSetException):
  • API/JSContextRef.h: Added.
  • API/JSObjectRef.cpp: Added. (JSValueToObject): (JSObjectMake): (JSFunctionMake): (JSObjectGetDescription): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSPropertyListEnumerator::JSPropertyListEnumerator): (JSObjectCreatePropertyEnumerator): (JSPropertyEnumeratorGetNext): (JSPropertyEnumeratorRetain): (JSPropertyEnumeratorRelease): (JSPropertyListAdd):
  • API/JSObjectRef.h: Added.
  • API/JSValueRef.cpp: Added. (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsEqual): (JSValueIsStrictEqual): (JSUndefinedMake): (JSNullMake): (JSBooleanMake): (JSNumberMake): (JSValueToBoolean): (JSValueToNumber): (JSGCProtect): (JSGCUnprotect): (JSGCCollect):
  • API/JSValueRef.h: Added.
  • API/JavaScriptCore.h: Added.
  • API/minidom.c: Added. (main):
  • API/minidom.html: Added.
  • API/minidom.js: Added.
  • API/testapi.c: Added. (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_initialize): (MyObject_copyDescription): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (MyObject_finalize): (print_callAsFunction): (main): (createStringWithContentsOfFile):
  • API/testapi.js: Added.
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/npruntime_impl.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getPropertyList):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/nodes.cpp: (ForInNode::execute):
  • kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::canPut): (KJS::JSObject::deleteProperty): (KJS::JSObject::propertyIsEnumerable): (KJS::JSObject::getPropertyAttributes): (KJS::JSObject::getPropertyList):
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::get):
  • kjs/property_map.h:
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
  • kjs/string_object.cpp: (StringInstance::getPropertyList):
  • kjs/string_object.h:
  • kjs/ustring.h: (KJS::UString::Rep::ref):

JavaScriptGlue:

Reviewed by Anders.


  • Required for JS API: Rename propList to getPropertyList and have it take its target property list by reference so that subclasses can add properties to the list before calling through to their superclasses.
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
  • UserObjectImp.cpp: (UserObjectImp::getPropertyList):
  • UserObjectImp.h:
1:46 PM Changeset in webkit [14950] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Fixing ChangeLog.

1:44 PM Changeset in webkit [14949] by bdakin
  • 2 edits in trunk/WebCore

Reviewed and committed by Beth.

Fix for <rdar://problem/4595337> Resizing a containing block
strictly vertically does not cause contained height:100% element to
also be resized.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Also layout if the child's min or max height is a percent.
1:35 PM Changeset in webkit [14948] by andersca
  • 9 edits
    3 adds in trunk

WebCore:

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered


  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Initialize new members.


(WebCore::XMLTokenizer::endElementNs):
If we've encountered a script tag, execute the script here. If the script
tag refers to an external resource, pause the parser while loading it.


(WebCore::XMLTokenizer::end):
Move code from finish() to here


(WebCore::XMLTokenizer::finish):
Only call end() if the parser isn't paused.


(WebCore::XMLTokenizer::notifyFinished):
Evaluate the script here and resume the parser.


(WebCore::XMLTokenizer::resumeParsing):
If finish() was called, call end() after writing all data.

LayoutTests:

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

  • dom/svg/level3/xpath/svgunit.js: The XPath tests depend on the document being loaded before running the tests. Add a "load" event listener and run the test in the handler.


  • fast/canvas/quadraticCurveTo.xml: Add onload handler and run tests there.


  • fast/innerHTML/004-expected.txt:
  • fast/innerHTML/004.xhtml: Add load event listener and run test there.


  • fast/parser/external-entities-expected.txt: This now dumps as text because the script is ran before the parse error is encountered.


  • fast/parser/resources/xhtml-scripts.js: Added.
  • fast/parser/xhtml-scripts-expected.txt: Added.
  • fast/parser/xhtml-scripts.xhtml: Added. Add new tests.


  • svg/custom/text-hit-test.svg: Run test in onload handler.
12:29 PM Changeset in webkit [14947] by tomernic
  • 9 edits in trunk/WebKit

Reviewed by Geoff Garen.

<rdar://problem/4564131> WebPluginDatabase setAdditionalWebPlugInPaths needs to be per WebView

Added some WebView SPI so that individual WebViews may have different plugin search paths. There are some
limitations with the approach taken here:

  • JavaScript may only access the global plugin DB.
  • When this SPI is in use, certain WebView methods may not give accurate results, such as +canShowMIMEType:.
  • This only works for plugins referenced using the <object> or <embed> tags; plugins that reside in non-standard file system locations may not be loaded directly into frames.


None of these issues are important to the client that needs this SPI. Rather than re-architect our entire
plugin database, I think it is better to simply accept these limitations for now.

  • Plugins/WebPluginDatabase.h: Added "plugInPaths" ivar, so different plugin databases can have different search paths.
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Give the global plugin database the default plugin search paths. (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): Removed static global; this method now sets the plugin paths on the global plugin database. (-[WebPluginDatabase setPlugInPaths:]): Setter method for plugin paths. (-[WebPluginDatabase close]): New method; called when the plugin database is no longer needed (when its WebView is being destroyed). (-[WebPluginDatabase init]): Don't refresh in -init, so that callers can set the DB's plugin path array before it refreshes. (-[WebPluginDatabase dealloc]): Moved here from near the bottom of the file. Release new ivar. (-[WebPluginDatabase refresh]): Use the plugInPaths ivar instead of calling pluginLocations(). Notify plugin packages when they are added to and removed from a plugin database. A plugin package will unload itself when it is removed from all of its plugin databases. The only really tricky thing here is that the global MIME <-> view class registrations are only modified by the shared plugin DB. (+[WebPluginDatabase _defaultPlugInPaths]): Refactored from the old pluginLocations() function; returns the default set of plugin search paths.
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that this package has been removed from all of its containing plugin databases. (-[WebBasePluginPackage finalize]): ditto (-[WebBasePluginPackage wasAddedToPluginDatabase:]): Add plugin database to set. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Remove plugin database from set. If it was the last DB, then unload the plugin package.
  • WebView/WebViewInternal.h: Added instance methods to find the view class or plugin package, given a MIME type or file extension.
  • WebView/WebViewPrivate.h: Added SPI to set plugin search paths per WebView.
  • WebView/WebView.m: (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): New method; tries the global MIME <-> view map first; failing that, it checks the WebView's plugin DB. (-[WebView _close]): Close the plugin DB. (-[WebView _setAdditionalWebPlugInPaths:]): Create the plugin DB if necessary, and set its plugin paths. (-[WebView _pluginForMIMEType:]): Checks global plugin DB, falls back on WebView DB. (-[WebView _pluginForExtension:]): ditto (-[WebView _isMIMETypeRegisteredAsPlugin:]): ditto
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Use new WebView instance methods to look for plugins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto (-[WebFrameBridge determineObjectFromMIMEType:URL:]): ditto
10:47 AM Changeset in webkit [14946] by sfalken
  • 2 edits in trunk/WebCore

2006-06-21 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):
9:21 AM Changeset in webkit [14945] by ap
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/run-webkit-httpd: Added.
8:27 AM Changeset in webkit [14944] by andersca
  • 2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

  • blog/wp-content/themes/webkit/sidebar.php: Add link to Wiki in the navigation menu here too.
6:50 AM Changeset in webkit [14943] by andersca
  • 2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

  • nav.inc: Add link to Wiki in the navigation menu.
6:24 AM Changeset in webkit [14942] by andersca
  • 3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp


  • bridge/win/FrameWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):
1:40 AM Changeset in webkit [14941] by adele
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
More Win32 build bustage.


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::shouldInterruptJavaScript):
  • bridge/win/FrameWin.h:
12:45 AM Changeset in webkit [14940] by thatcher
  • 7 edits
    3 adds in trunk/WebKitTools

Reviewed by Eric.

Builds Drosera and a launcher to include with the nightly.

  • BuildSlaveSupport/build-launcher-app:
  • BuildSlaveSupport/build-launcher-dmg:
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Info.plist:
  • Drosera/LauncherInfo.plist: Added.
  • Drosera/launcher.m: Added. (displayErrorAndQuit): (checkMacOSXVersion): (myExecve): (main):
  • Scripts/build-drosera
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/main.m: (main):
12:27 AM Changeset in webkit [14939] by mjs
  • 16 edits in trunk/LayoutTests

No review - updated results for earlier patch.


  • updated SVG test results where my recent fix affected bounding boxes


I think the new results are more accurate bounding boxes and in
any case there is no actual difference in rendered output.

  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/custom/foreign-object-skew-expected.txt:
  • svg/custom/image-with-transform-clip-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
12:27 AM Changeset in webkit [14938] by adele
  • 4 edits in trunk/LayoutTests/dom

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:26 AM Changeset in webkit [14937] by adele
  • 9 edits in trunk/LayoutTests/tables/mozilla/bugs

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:23 AM Changeset in webkit [14936] by adele
  • 94 edits in trunk/LayoutTests

Reviewed by Anders.

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
and the renderer name for textareas has changed from RenderTextArea to RenderTextField.

  • dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
  • dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
  • dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
  • dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
  • fast/block/margin-collapse/103-expected.checksum:
  • fast/block/margin-collapse/103-expected.png:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/dynamic/008-expected.checksum:
  • fast/dynamic/008-expected.png:
  • fast/dynamic/008-expected.txt:
  • fast/forms/001-expected.checksum:
  • fast/forms/002-expected.checksum:
  • fast/forms/003-expected.checksum:
  • fast/forms/004-expected.checksum:
  • fast/forms/005-expected.checksum:
  • fast/forms/006-expected.checksum:
  • fast/forms/007-expected.checksum:
  • fast/forms/8250-expected.checksum:
  • fast/forms/blankbuttons-expected.checksum:
  • fast/forms/button-cannot-be-nested-expected.checksum:
  • fast/forms/button-default-title-expected.checksum:
  • fast/forms/button-inner-block-reuse-expected.checksum:
  • fast/forms/button-positioned-expected.checksum:
  • fast/forms/button-sizes-expected.checksum:
  • fast/forms/button-table-styles-expected.checksum:
  • fast/forms/button-white-space-expected.checksum:
  • fast/forms/checkbox-radio-onchange-expected.checksum:
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/double-focus-expected.txt:
  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/form-hides-table-expected.checksum:
  • fast/forms/formmove-expected.checksum:
  • fast/forms/formmove2-expected.checksum:
  • fast/forms/formmove3-expected.checksum:
  • fast/forms/indeterminate-expected.checksum:
  • fast/forms/input-appearance-bkcolor-expected.checksum:
  • fast/forms/input-appearance-default-bkcolor-expected.checksum:
  • fast/forms/input-appearance-disabled-expected.checksum:
  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-minWidth-expected.checksum:
  • fast/forms/input-appearance-preventDefault-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-selection-expected.checksum:
  • fast/forms/input-appearance-visibility-expected.checksum:
  • fast/forms/input-appearance-width-expected.checksum:
  • fast/forms/input-baseline-expected.checksum:
  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • fast/forms/input-maxlength-2-expected.checksum:
  • fast/forms/input-no-renderer-expected.checksum:
  • fast/forms/input-paste-undo-expected.checksum:
  • fast/forms/input-readonly-dimmed-expected.checksum:
  • fast/forms/input-readonly-empty-expected.checksum:
  • fast/forms/input-spaces-expected.checksum:
  • fast/forms/input-table-expected.checksum:
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-outside-expected.checksum:
  • fast/forms/input-text-double-click-expected.checksum:
  • fast/forms/input-text-drag-down-expected.checksum:
  • fast/forms/input-text-maxlength-expected.checksum:
  • fast/forms/input-text-option-delete-expected.checksum:
  • fast/forms/input-text-paste-maxlength-expected.checksum:
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • fast/forms/input-text-self-emptying-click-expected.checksum:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-width-expected.checksum:
  • fast/forms/minWidthPercent-expected.checksum:
  • fast/forms/negativeLineHeight-expected.checksum:
  • fast/forms/negativeLineHeight-expected.png:
  • fast/forms/negativeLineHeight-expected.txt:
  • fast/forms/option-index-expected.checksum:
  • fast/forms/option-script-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/plaintext-mode-2-expected.checksum:
  • fast/forms/radio-attr-order-expected.checksum:
  • fast/forms/radio_checked-expected.checksum:
  • fast/forms/radio_checked_dynamic-expected.checksum:
  • fast/forms/selection-functions-expected.txt:
  • fast/forms/tabbing-input-iframe-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/forms/textAreaLineHeight-expected.txt:
  • fast/forms/textarea-crlf-expected.txt:
  • fast/forms/textarea-setinnerhtml-expected.checksum:
  • fast/forms/textarea-setinnerhtml-expected.png:
  • fast/forms/textarea-setinnerhtml-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/forms/visual-hebrew-text-field-expected.checksum:
  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • fast/table/003-expected.txt:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug194024-expected.txt:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30559-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug30692-expected.txt:
12:23 AM Changeset in webkit [14935] by adele
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

  • css/html4.css:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::isKeyboardFocusable): (WebCore::HTMLTextAreaElement::isMouseFocusable): (WebCore::HTMLTextAreaElement::focus): (WebCore::HTMLTextAreaElement::defaultEventHandler): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setValue):

Jun 20, 2006:

6:42 PM Changeset in webkit [14934] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way

  • icon/SQLStatement.cpp:
6:29 PM Changeset in webkit [14933] by beidson
  • 16 edits
    1 add in trunk

WebCore:

Reviewed by Maciej.

More changes/additions setting the stage for the major IconDatabase hookup.

  • WebCore.xcodeproj/project.pbxproj: Added SQLTransaction.cpp
  • bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedBridgeInstance]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge iconForURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
  • bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check (initializeLoggingChannelsIfNecessary):
  • icon/IconDatabase.cpp: Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): (WebCore::IconDatabase::setIconForIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
  • icon/IconDatabase.h: WebIcon will be an internal class used in IconDatabase but is not complete yet (WebCore::WebIcon::getExpiration): (WebCore::WebIcon::getTouch):
  • icon/SQLDatabase.cpp: Added more SQLite convenience methods (SQLDatabase::setFullsync): (SQLDatabase::setBusyTimeout): (SQLDatabase::setBusyHandler):
  • icon/SQLDatabase.h:
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::returnsAtLeastOneResult):
  • icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class (SQLTransaction::SQLTransaction): (SQLTransaction::~SQLTransaction): (SQLTransaction::begin): (SQLTransaction::commit): (SQLTransaction::rollback):

WebKit:

Reviewed by Maciej

Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API. For now these calls
are wrapped with #ifdef's and are for debugging only.

  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary _scaleIcon:toSize:]): (-[NSMutableDictionary init]): (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]):
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • Misc/WebKitLogging.h: Added a logging channel for WebIconDatabase debugging
  • Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):
5:20 PM Changeset in webkit [14932] by thatcher
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make sure we clear the exception before returning so
that future calls will not fail because of an earlier
exception state. Assert on entry that the WebScriptObject
is working with an ExecState that dose not have an exception.
Document that evaluateWebScript and callWebScriptMethod return
WebUndefined when an exception is thrown.

  • bindings/objc/WebScriptObject.h:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):
5:10 PM Changeset in webkit [14931] by adele
  • 14 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Tests for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

  • fast/forms/double-focus-expected.txt:
  • fast/forms/input-selection-hidden-expected.txt: Added.
  • fast/forms/input-selection-hidden.html: Added.
  • fast/forms/input-selection-restore-expected.txt: Added.
  • fast/forms/input-selection-restore.html: Added.
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/forms/onselect-textarea-expected.txt: Added.
  • fast/forms/onselect-textarea.html: Added.
  • fast/forms/onselect-textfield-expected.txt: Added.
  • fast/forms/onselect-textfield.html: Added.
  • fast/forms/selection-functions-expected.txt:

WebCore:

Reviewed by Maciej.

Fixes for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

Implemented onSelect for new text fields and textareas. Also fixed selection restore
behavior to better match other browsers and Safari 2.0 behavior.

Tests:

  • fast/forms/input-selection-restore.html
  • fast/forms/input-selection-hidden.html
  • fast/forms/onselect-textarea.html
  • fast/forms/onselect-textfield.html
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initializes cached selection. (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection. (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text. Otherwise, restore the cached selection. This matches other browsers' behavior. (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
  • page/Frame.h: Added notifyRendererOfSelectionChange method.
  • page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange): Added. Calls selectionChanged for text fields and textareas. Forwards a userTriggered argument so selectionChanged knows whether or not to fire onSelect. (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false). This gets called for all selection changes, so the renderer can always update its cached selection values. (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done making a selection with the mouse.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets fired when the user makes a selection with the keyboard. (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.
  • rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and return early since we won't be able to actually set the selection. (WebCore::RenderTextField::selectionChanged): Caches the selection. If the selection is a range, and its triggered by user action, then fire the onSelect event.
3:11 PM Changeset in webkit [14930] by andersca
  • 3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

  • bridge/win/FrameWin.cpp: (WebCore::shouldInterruptJavaScript):
  • bridge/win/FrameWin.h: Try fixing the Windows build.
3:07 PM Changeset in webkit [14929] by adele
  • 36 edits
    2 moves in trunk

RS by Tim Hatcher.

Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.


  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
  • html/HTMLSelectElement.h:
  • rendering/DeprecatedRenderSelect.cpp: Added. (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::setStyle): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::calcMinMaxWidth): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::valueChanged): (WebCore::DeprecatedRenderSelect::selectionChanged): (WebCore::DeprecatedRenderSelect::setOptionsChanged): (WebCore::DeprecatedRenderSelect::createListBox): (WebCore::DeprecatedRenderSelect::updateSelection):
  • rendering/DeprecatedRenderSelect.h: Added. (WebCore::DeprecatedRenderSelect::renderName):
  • rendering/RenderSelect.cpp: Removed.
  • rendering/RenderSelect.h: Removed.
3:01 PM Changeset in webkit [14928] by andersca
  • 1 edit in trunk/WebCore/dom/xml_tokenizer.cpp

Commit for real this time - Not just the ChangeLog and some white-space

2:34 PM Changeset in webkit [14927] by andersca
  • 2 edits in trunk/WebCore

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
Would like a way to pause/resume XML parsing

  • dom/xml_tokenizer.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): New classes which manage a list of pending SAX callbacks that have not yet been sent to the tokenizer.


(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new member variables.


(WebCore::XMLTokenizer::~XMLTokenizer):
Delete PendingCallbacks object.


(WebCore::XMLTokenizer::write):
If the parser is paused, queue the data to be written.


(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::characters):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::processingInstruction):
(WebCore::XMLTokenizer::cdataBlock):
(WebCore::XMLTokenizer::comment):
(WebCore::XMLTokenizer::internalSubset):
If the parser has been paused, queue the callbacks instead.

(WebCore::XMLTokenizer::handleError):
New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback


(WebCore::XMLTokenizer::finish):
(WebCore::XMLTokenizer::pauseParsing):

Set m_parserPaused to true.


(WebCore::XMLTokenizer::resumeParsing):
Call the pending callbacks and then parse the pending source.

2:24 PM Changeset in webkit [14926] by hyatt
  • 3 edits in trunk/WebCore

Don't send the custom highlighter callback when painting is disabled.

Reviewed by harrison

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
2:04 PM Changeset in webkit [14925] by adele
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.
12:44 PM Changeset in webkit [14924] by andersca
  • 3 edits
    8 adds in trunk

WebCore:

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::checkBuffer): (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): Add a text buffer which is used for translation of CR and CRLF to plain LF, like the HTML tokenizer does.

LayoutTests:

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

  • fast/text/plain-text-line-breaks-expected.checksum: Added.
  • fast/text/plain-text-line-breaks-expected.png: Added.
  • fast/text/plain-text-line-breaks-expected.txt: Added.
  • fast/text/plain-text-line-breaks.html: Added.
  • fast/text/resources/line-breaks-cr.txt: Added.
  • fast/text/resources/line-breaks-crlf.txt: Added.
  • fast/text/resources/line-breaks-lf.txt: Added.
12:12 PM Changeset in webkit [14923] by thatcher
  • 1 edit
    51 adds in trunk/WebKitTools

Reviewed by Darin.


Adds a JavaScript debugger, called Drosera. Named after
a genus of bug eating plants.

  • Drosera/DebuggerApplication.h: Added.
  • Drosera/DebuggerApplication.m: Added. (-[DebuggerApplication applicationDidFinishLaunching:]): (-[DebuggerApplication serverLoaded:]): (-[DebuggerApplication serverUnloaded:]): (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication showAttachPanel:]): (-[DebuggerApplication attach:]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): (-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]): (-[DebuggerApplication tableViewSelectionDidChange:]):
  • Drosera/DebuggerDocument.h: Added.
  • Drosera/DebuggerDocument.m: Added. (+[WebScriptCallFrame isSelectorExcludedFromWebScript:]): (+[WebScriptCallFrame isKeyExcludedFromWebScript:]): (+[DebuggerDocument isSelectorExcludedFromWebScript:]): (+[DebuggerDocument isKeyExcludedFromWebScript:]): (-[DebuggerDocument initWithServerName:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument dealloc]): (-[DebuggerDocument isPaused]): (-[DebuggerDocument pause]): (-[DebuggerDocument resume]): (-[DebuggerDocument step]): (-[DebuggerDocument windowNibName]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument switchToServerNamed:]): (-[DebuggerDocument applicationTerminating:]): (-[DebuggerDocument serverConnectionDidDie:]): (-[DebuggerDocument webView:windowScriptObjectAvailable:]): (-[DebuggerDocument webView:didFinishLoadForFrame:]): (-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/Drosera.pch: Added.
  • Drosera/Drosera.xcodeproj/project.pbxproj: Added.
  • Drosera/English.lproj/Debugger.nib/classes.nib: Added.
  • Drosera/English.lproj/Debugger.nib/info.nib: Added.
  • Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/info.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
  • Drosera/Images/breakPoint.tif: Added.
  • Drosera/Images/breakPointDisabled.tif: Added.
  • Drosera/Images/continue.tif: Added.
  • Drosera/Images/finishFunction.tif: Added.
  • Drosera/Images/glossyFooterFill.tif: Added.
  • Drosera/Images/glossyHeader.png: Added.
  • Drosera/Images/gradientBackground.png: Added.
  • Drosera/Images/gutter.png: Added.
  • Drosera/Images/navLeftDisabled.png: Added.
  • Drosera/Images/navLeftNormal.png: Added.
  • Drosera/Images/navLeftPressed.png: Added.
  • Drosera/Images/navRightDisabled.png: Added.
  • Drosera/Images/navRightNormal.png: Added.
  • Drosera/Images/navRightPressed.png: Added.
  • Drosera/Images/pause.tif: Added.
  • Drosera/Images/popUpArrows.png: Added.
  • Drosera/Images/programCounter.tif: Added.
  • Drosera/Images/programCounterBreakPoint.tif: Added.
  • Drosera/Images/programCounterBreakPointDisabled.tif: Added.
  • Drosera/Images/run.tif: Added.
  • Drosera/Images/splitterBar.tif: Added.
  • Drosera/Images/splitterDimple.tif: Added.
  • Drosera/Images/step.tif: Added.
  • Drosera/Images/stepOver.tif: Added.
  • Drosera/Images/stop.tif: Added.
  • Drosera/Images/toolbarBackground.png: Added.
  • Drosera/Info.plist: Added.
  • Drosera/debugger.css: Added.
  • Drosera/debugger.html: Added.
  • Drosera/debugger.js: Added.
  • Drosera/main.m: Added. (main):
  • Drosera/viewer.css: Added.
  • Drosera/viewer.html: Added.
12:08 PM Changeset in webkit [14922] by thatcher
  • 5 edits in trunk/WebKit

Reviewed by Darin.

Removes the @try/@catch from the callbacks to improve performance,
simply check if the proxy object's connection is still valid first.
Listener objects are now required to be NSDistantObjects.

Adds pause, resume and step support. The debugger process use to handle this,
but it caused problems when there were multiple listeners.

Sends the bundle identifier in the notification userInfo dictionary along with
process name and process ID.

  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer step]): (-[WebScriptDebugServer pause]): (-[WebScriptDebugServer resume]): (-[WebScriptDebugServer isPaused]): (-[WebScriptDebugServer suspendProcessIfPaused]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebKit.exp:
1:14 AM Changeset in webkit [14921] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix crasher on one of the layout tests caused by my recent checkin
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

Jun 19, 2006:

10:17 PM Changeset in webkit [14920] by ap
  • 8 edits
    2 adds in trunk

Reviewed by Darin.

WebCore:

  • bindings/js/kjs_window.cpp: (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.
  • page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was used only for storing response HTTP headers, which was an overkill.
  • page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob. (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob. (WebCore::Frame::receivedFirstData): Ditto. (WebCore::Frame::addMetaData): Ditto. (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what scheduleRedirection() does. (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.

WebKit:

  • WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for reload requests. (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).

LayoutTests:

  • http/tests/misc/refresh-headers-expected.txt: Added.
  • http/tests/misc/refresh-headers.php: Added.
8:20 PM Changeset in webkit [14919] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Ben Goodger.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9501
Windows build fails with link error CharsetTable not defined

  • platform/make-charset-table.pl: (process_iana_charsets): Move test for equality to alias "None" until after normalization steps to ensure escape characters in the input data don't interfere with processing. Convert nearby tabs to 4 spaces in this function.
7:43 PM Changeset in webkit [14918] by mjs
  • 12 edits
    6 adds in trunk/WebCore

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6946
"SVG shows invalidation issues in WebKit"


​http://www.treebuilder.de/default.asp?file=441875.xml
"Invalidation issues with "SVG 3d" demo"


​http://code.google.com/webstats/2005-12/pages.html
"SVG text doesn't repaint correctly"

  • kcanvas/KCanvasContainer.cpp: (WebCore::KCanvasContainer::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in transformed SVG content get propagated up properly. (WebCore::KCanvasContainer::getAbsoluteRepaintRect): note a FIXME; this method seems wrong.
  • kcanvas/KCanvasContainer.h: Prototype new method.
  • css/svg.css: Don't apply overflow:hidden to foreignObject, since that makes it a RenderLayer so it paints twice.
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): Transform the damage rect before passing it down to HTML content, so everything paints that is supposed to. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in HTML embedded in SVG get propagated up properly. (WebCore::RenderForeignObject::requiresLayer): Never use a RenderLayer. (WebCore::RenderForeignObject::layout): Make sure to dirty our previous bounds when layout changes, as by transform.
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): Transform the damage rect when painting. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in SVG images get propagated up properly. (WebCore::RenderSVGImage::translationForAttributes): New helper method, factored out of below. (WebCore::RenderSVGImage::translateForAttributes): Use above. (WebCore::RenderSVGImage::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGImage::layout): Make sure to properly dirty the old bounds, accounting for transforms. (WebCore::RenderSVGImage::relativeBBox): Correct bbox computation.
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Transform incoming damage rect. Handle opacity here since we won't get a layer. (WebCore::RenderSVGText::computeAbsoluteRepaintRect): Apply transforms. (WebCore::RenderSVGText::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGText::layout): Make sure to dirty the old bounds.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Instead of transforming rect to device space and back to user space, do this for the origin and lower right corner of the rect. Otherwise the rect will get inflated if user space is rotated or skewed.
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::layout): Make sure to dirty the old bounds. (WebCore::RenderPath::paint): Hhandle opacity here.


Bonus fix:


  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Fix hit testing. Wasn't applying the x/y attribute transform.
4:31 PM Changeset in webkit [14917] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebView.h

Build fix.

3:58 PM Changeset in webkit [14916] by weinig
  • 40 edits
    20 copies
    2 moves in trunk/WebCore
2:58 PM Changeset in webkit [14915] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin.


  • added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only works for HTML views.
  • WebView/WebUIDelegatePrivate.h: Define a new UIDelegate method -webView:didDrawRect:
  • WebView/WebHTMLView.m: (-[WebView drawSingleRect:]): Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers in the case where the delegate implements the method but does nothing in it.
2:39 PM Changeset in webkit [14914] by darin
  • 4 edits
    3 deletes in trunk/WebCore

Reviewed by Brady.

  • removed a few empty/unused files Brady found by tracking down the nm error message
  • editing/VisibleRange.cpp: Removed.
  • editing/VisibleRange.h: Removed.
  • kcanvas/KCanvasImage.cpp: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
  • WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
  • WebCoreSources.bkl: Removed VisibleRange.cpp.
12:23 PM Changeset in webkit [14913] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-06-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Fix argument order in setitimer calls.
9:42 AM Changeset in webkit [14912] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

It was only available in newly created windows, and became undefined after changing the URL
or reloading. Let's try removing it; hopefully, no-one will notice.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.
9:15 AM Changeset in webkit [14911] by ap
  • 9 edits in trunk

Reviewed by Darin.

Test: LayoutTests/fast/encoding/invalid-UTF-8.html

  • dom/xml_tokenizer.cpp: (WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter before, because the garbage at the end was guaranteed to be invalid UTF-8, and was omitted in appendOmittingUnwanted();
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters. Renamed back from appendOmittingUnwanted();

(WebCore::StreamingTextDecoder::convertUsingICU):

  • platform/StreamingTextDecoder.h: Update for the above function renaming.
3:51 AM Changeset in webkit [14910] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's -[webView:didFailProvisionalLoadWithError:forFrame].

Jun 18, 2006:

5:00 PM Changeset in webkit [14909] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
Teach svn-apply and svn-unapply to use full path names

  • Scripts/svn-apply: Changed to use full path names. Cleaned up code.
  • Scripts/svn-unapply: Ditto.
4:54 PM Changeset in webkit [14908] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.
3:20 PM Changeset in webkit [14907] by ddkilzer
  • 4 edits in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.
10:58 AM Changeset in webkit [14906] by ddkilzer
  • 5 edits in trunk/WebKit

WebKit:

Reviewed by xenon.

  • WebInspector/WebInspector.m: (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame the inspector is (no longer) targeting. (-_webFrameDetached:): Added. Moved the code that was previously in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it is detached from its parent.
  • WebInspector/WebInspectorInternal.h:
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors that the WebFrame is detaching. (-[WebFrame _addInspector:]): Added. (-[WebFrame _removeInspector:]): Added.
  • WebView/WebFrameInternal.h:
10:54 AM Changeset in webkit [14905] by ddkilzer
  • 7 edits
    7 adds in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited-expected.checksum: Added.
  • fast/history/clicked-link-is-visited-expected.png: Added.
  • fast/history/clicked-link-is-visited-expected.txt: Added.
  • fast/history/clicked-link-is-visited.html: Added.
  • fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack. Fixed coordinates for mouse events. Added call to keepWebHistory().
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about window.history hack.

WebKitTools:

Reviewed by ggaren.

Test: LayoutTests/fast/history/clicked-link-is-visited.html

  • DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory. (-[LayoutTestController keepWebHistory]): Added. We only set optional shared history if it is currently nil since keepWebHistory() might be called more than once incidentally for the same test. (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.
10:11 AM Changeset in webkit [14904] by andersca
  • 16 edits in trunk

JavaScriptCore:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): Do nothing if the timeout check hasn't been started.


(KJS::TimeoutChecker::resumeTimeoutCheck):
Do nothing if the timeout check hasn't been started.
Use the right signal handler when unblocking.


(KJS::Interpreter::handleTimeout):
pause/resume the timeout check around the call to
shouldInterruptScript().


WebCore:

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Set the default script timeout.


(KJS::ScriptInterpreter::shouldInterruptScript):
New function which asks the frame if the script should be interrupted.


  • bindings/js/kjs_binding.h:


  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add calls to startTimeoutCheck/stopTimeoutCheck


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add calls to pauseTimeoutCheck/unpauseTimeoutCheck


(KJS::ScheduledAction::execute):
Add calls to startTimeoutCheck/stopTimeoutCheck


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldInterruptJavaScript): New function which asks the bridge if the script should be interrupted.


  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h: Add function declarations.


WebKit:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge shouldInterruptJavaScript]): Ask the UI delegate if the script should be interrupted.


  • WebView/WebUIDelegatePrivate.h: Declare webViewShouldInterruptJavaScript: delegate method
12:00 AM Changeset in webkit [14903] by ap
  • 3 edits
    2 adds in trunk

Reviewed by ggaren.

Most of the properties were already fixed, this just adds adds a prototype to window.debug.

Test: fast/dom/everything-to-string.html

  • bindings/js/kjs_proxy.cpp: (WebCore::TestFunctionImp::TestFunctionImp): (WebCore::KJSProxy::initScriptIfNeeded):

Jun 17, 2006:

11:25 PM Changeset in webkit [14902] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9491
Windows build breaks in interpreter.cpp

  • kjs/interpreter.cpp (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Make sure to only assert equality with s_executingInterpreter when it is being used (i.e. when HAVE(SYS_TIME_H) == true)
9:22 PM Changeset in webkit [14901] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • Fix capitalization issue for case-sensitive filesystems.
  • icon/SQLStatement.cpp: Change assertions.h to Assertions.h.
5:30 PM Changeset in webkit [14900] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9477
REGRESSION: fast/dom/replaceChild.html crashes on WebKit ToT in debug build

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Refetch the debugger after executing the function in case the WebFrame it was running in has since been destroyed.
8:54 AM Changeset in webkit [14899] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Updated.
  • fast/block/float/table-relayout-expected.checksum: Added.
  • fast/block/float/table-relayout-expected.png: Added.
  • fast/block/float/table-relayout-expected.txt: Added.
  • fast/block/float/table-relayout.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/block/float/table-relayout.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): Added marking of children that use lineWidth.
  • rendering/RenderBlock.h: Added a FIXME.
8:37 AM Changeset in webkit [14898] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282>

  • fast/dom/select-selectedIndex-multiple.html: Added.
  • fast/dom/select-selectedIndex.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282:
Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

Update selectedIndex when a new option is added using javascript.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLSelectCollection::put):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
  • html/HTMLSelectElement.h:
8:29 AM Changeset in webkit [14897] by adele
  • 4 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/reset-initiatedDrag.html: Added.

WebKit:

Reviewed by Darin.

  • WebView/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Reset the WebView's initiatedDrag flag when the document view is changed.
  • WebView/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): Changed the ASSERT to allow for drags that end after the view has been removed from the WebView.
3:48 AM Changeset in webkit [14896] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9476
REGRESSION: Reproducible crash after closing window after viewing
css2.1/t0803-c5501-imrgn-t-00-b-ag.html

  • kjs/debugger.cpp: (Debugger::detach): Call setDebugger(0) for all interpreters removed from the 'attached to a debugger' list.

Jun 16, 2006:

6:15 PM Changeset in webkit [14895] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
(m_floatingSelectors.contains(selector)) in some CSS tests

  • css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector() instead of the bare constructor.
6:08 PM Changeset in webkit [14894] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

Problem was that revision lost a check to not draw the markers
when paintingDisabled(). This led the markers to be drawn when
the window deactivated, at which time the view happens to be flipped.

It is similar but not the same as the Mail ToDo highlighting
issue, which is due to the custom highlight method
drawing when the focusView is nil. Mail team knows this
and has tested the fix.

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): Early return if paintingDisabled().
4:47 PM Changeset in webkit [14893] by andersca
  • 6 edits in trunk/JavaScriptCore

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej and Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
Provide some way to stop a JavaScript infinite loop


  • kjs/completion.h: (KJS::): Add Interrupted completion type.


  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction): Only set the exception on the new ExecState if the current one has had one.


  • kjs/interpreter.cpp: (KJS::TimeoutChecker::startTimeoutCheck): (KJS::TimeoutChecker::stopTimeoutCheck): (KJS::TimeoutChecker::alarmHandler): (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given period of time. This currently only works on Unix platforms where setitimer and signals are used.


(KJS::Interpreter::Interpreter):
Initialize new member variables.


(KJS::Interpreter::~Interpreter):
Destroy the timeout checker.


(KJS::Interpreter::startTimeoutCheck):
(KJS::Interpreter::stopTimeoutCheck):
(KJS::Interpreter::pauseTimeoutCheck):
(KJS::Interpreter::resumeTimeoutCheck):
Call the timeout checker.


(KJS::Interpreter::handleTimeout):
Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.


  • kjs/interpreter.h: (KJS::Interpreter::setTimeoutTime): New function for setting the timeout time.


(KJS::Interpreter::shouldInterruptScript):
New function. The idea is that this should be overridden by subclasses in order to for example
pop up a dialog asking the user if the script should be interrupted.


(KJS::Interpreter::checkTimeout):
New function which checks the m_timedOut flag and calls handleTimeout if it's set.


  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): Call Interpreter::checkTimeout after each iteration of the loop.
4:45 PM Changeset in webkit [14892] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Adjust padding of inner div so text lines up with text fields.
Adjust height of textarea so it only leaves room for the horizontal
scrollbar if overflow is set to scroll, or if overflow is set to
auto and there's no word wrap.

These changes will be tested by current layout tests when the
new textarea implementation takes effect.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight):
2:49 PM Changeset in webkit [14891] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net
  • dom/Document.cpp: (WebCore::Document::addMarker): Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can change value of [it - markers.begin()].
2:10 PM Changeset in webkit [14890] by thatcher
  • 7 edits
    3 adds in trunk/WebKit

Reviewed by Tim O.

Exposes a distributed objects server for clients to register for script debugger calls.
For preformance concerns this is disabled by default, you will need to enable this per application.
To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

Clients will need to listen to the following distributed notification to discover servers:
WebScriptDebugServerDidLoadNotification

To discover servers that previously loaded before the client, the client needs to send the following notification:
WebScriptDebugServerQueryNotification

All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
registered server connection name to use with distributed objects.

  • DefaultDelegates/WebScriptDebugServer.h: Added.
  • DefaultDelegates/WebScriptDebugServer.m: Added. (+[WebScriptDebugServer sharedScriptDebugServer]): (-[WebScriptDebugServer init]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (+[WebView _developerExtrasEnabled]): (+[WebView _scriptDebuggerEnabled]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
  • WebView/WebViewPrivate.h:
11:27 AM Changeset in webkit [14889] by adele
  • 12 edits in trunk

WebCore:

Reviewed by Alice.

Added code to draw Cocoa-like border for textareas instead of just using CSS.

  • WebCore.exp:
  • css/html4.css: Sets a 1px solid border.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderThemeMac.h: Formatting changes.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea): Uses new wkDrawBezeledTextArea to draw border.

WebKit:

Reviewed by Alice.

Added initialization for WKDrawBezeledTextArea.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Alice.

  • WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
  • libWebKitSystemInterface.a: ditto.
10:02 AM Changeset in webkit [14888] by adele
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Maciej.

Adding missing expected result for test from yesterday.

  • fast/events/window-load-capture-expected.txt: Added.
6:13 AM Changeset in webkit [14887] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/text/capitalize-empty-generated-string-expected.checksum: Added.
  • fast/text/capitalize-empty-generated-string-expected.png: Added.
  • fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

Reviewed by hyatt.

Test: fast/text/capitalize-empty-generated-string.html

  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Skip empty-string text renderers when looking for the previous character.

Jun 15, 2006:

5:45 PM Changeset in webkit [14886] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • fast/repaint/selection-after-delete-expected.checksum: Added.
  • fast/repaint/selection-after-delete-expected.png: Added.
  • fast/repaint/selection-after-delete-expected.txt: Added.
  • fast/repaint/selection-after-delete.html: Added.
  • fast/repaint/selection-after-remove-expected.checksum: Added.
  • fast/repaint/selection-after-remove-expected.png: Added.
  • fast/repaint/selection-after-remove-expected.txt: Added.
  • fast/repaint/selection-after-remove.html: Added.

WebCore:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that selection gaps are invalidated.
3:44 PM Changeset in webkit [14885] by thatcher
  • 1 copy in tags/WebCore-418.19/WebCore

Tag for WebCore 418.19 (part 2 of 2.)

3:44 PM Changeset in webkit [14884] by thatcher
  • 1 add in tags/WebCore-418.19

Tag for WebCore 418.19 (part 1 of 2.)

3:33 PM Changeset in webkit [14883] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

JavaScriptGlue:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebKit.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [14882] by jdevalk
  • 4 edits in trunk/LayoutTests/fast/css

And now with the ugly line gone, and the proper expected test results

3:28 PM Changeset in webkit [14881] by jdevalk
  • 1 edit
    2 adds in trunk/LayoutTests/fast/css

update testresults

3:26 PM Changeset in webkit [14880] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-2-expected.png: Added.
  • editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

Reviewed by harrison


  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): Ascend using the DOM (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion during deletion is fixed, removing the fall back.
2:37 PM Changeset in webkit [14879] by jdevalk
  • 8 edits
    2 adds in trunk

Adding :lang support, patch by Nicholas Shanks, review by Hyatt

2:09 PM Changeset in webkit [14878] by jdevalk
  • 2 edits in trunk/WebKitSite

Improve wording of first paragraph of index.html

1:05 PM Changeset in webkit [14877] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

  • editing/execCommand/findString-2-expected.checksum: Added.
  • editing/execCommand/findString-2-expected.png: Added.
  • editing/execCommand/findString-2-expected.txt: Added.
  • editing/execCommand/findString-2.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E


  • page/Frame.cpp: (WebCore::Frame::findString): When comparing the found range with what's currently selected a) build a selection with the found range to remove collapsed whitespace and b) compare ranges instead of selection objects to ignore the way that the current selection was made (to ignore the base and extent).
11:56 AM Changeset in webkit [14876] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:51 AM Changeset in webkit [14875] by justing
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by thatcher, harrison


<rdar://problem/4585175> 10.4.7 regression: Text from end of signature unexpectedly removed


Merged fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • khtml/editing/htmlediting.cpp: (khtml::hasARenderedDescendant): Added. (khtml::CompositeEditCommand::prune): Don't prune a leaf, the root editable element, or a container with one or more rendered descendants.
10:37 AM Changeset in webkit [14874] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


Fixed bug in WebKit support for computing but not highlighting rects for text matches.

  • WebView/WebView.m: (-[WebView rectsForTextMatches]): leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch of autoreleased NSValue objects, use a local autorelease pool
6:37 AM Changeset in webkit [14873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebPluginController.m: (-[WebPluginController _cancelOutstandingChecks]): add nil check before calling CFSetApplyFunction
4:12 AM Changeset in webkit [14872] by ddkilzer
  • 108 edits in trunk/WebCore

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
IDL files missing copyright/license headers

Add Apple BSD license and copyright to IDL files.

  • ksvg2/bindings/idl/svg/GetSVGDocument.idl:
  • ksvg2/bindings/idl/svg/SVGAElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl:
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl:
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl:
  • ksvg2/bindings/idl/svg/SVGDescElement.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
  • ksvg2/bindings/idl/svg/SVGEvent.idl:
  • ksvg2/bindings/idl/svg/SVGException.idl:
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
  • ksvg2/bindings/idl/svg/SVGGElement.idl:
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGICCColor.idl:
  • ksvg2/bindings/idl/svg/SVGImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl:
  • ksvg2/bindings/idl/svg/SVGLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGLineElement.idl:
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGLocatable.idl:
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
  • ksvg2/bindings/idl/svg/SVGNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGPaint.idl:
  • ksvg2/bindings/idl/svg/SVGPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl:
  • ksvg2/bindings/idl/svg/SVGPointList.idl:
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGRectElement.idl:
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl:
  • ksvg2/bindings/idl/svg/SVGSetElement.idl:
  • ksvg2/bindings/idl/svg/SVGStopElement.idl:
  • ksvg2/bindings/idl/svg/SVGStringList.idl:
  • ksvg2/bindings/idl/svg/SVGStylable.idl:
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl:
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
  • ksvg2/bindings/idl/svg/SVGTests.idl:
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl:
  • ksvg2/bindings/idl/svg/SVGTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGTransformable.idl:
  • ksvg2/bindings/idl/svg/SVGURIReference.idl:
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
  • ksvg2/bindings/idl/svg/SVGUseElement.idl:
  • ksvg2/bindings/idl/svg/SVGViewElement.idl:
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
  • ksvg2/svg/SVGAnimatedLength.idl:

Jun 14, 2006:

5:14 PM Changeset in webkit [14871] by thatcher
  • 1 copy in tags/WebCore-418.18/WebCore

New tag part 2.

5:12 PM Changeset in webkit [14870] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
  • editing/pasteboard/copy-paste-bidi-expected.png: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt: Added.
  • editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/markup.cpp: (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.
5:12 PM Changeset in webkit [14869] by thatcher
  • 1 add in tags/WebCore-418.18

Tag for WebCore 418.18 (part 1 of 2.)

4:23 PM Changeset in webkit [14868] by justing
  • 22 edits
    10 adds in trunk

LayoutTests:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-002.html:
  • editing/execCommand/format-block-expected.checksum: Added.
  • editing/execCommand/format-block-expected.png: Added.
  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
  • editing/execCommand/format-block-from-range-selection-expected.png: Added.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Added.
  • editing/execCommand/format-block.html: Added.

WebCore:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. downstream() the start or else we'll move collapsed whitespace and uncollapse it.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition because that's removeNode's responsibility. (WebCore::updatePositionForNodeRemoval): Added. (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual overload of removeNode so that we can update positions as we remove nodes. (WebCore::updatePositionForTextRemoval): Added. (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid since m_trailingWhitespace is always valid (we update it as we remove nodes). (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should be fixed if they have collapsed before merging paragraphs.
  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h: (WebCore::):
  • editing/FormatBlockCommand.cpp: Added. (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange(). (WebCore::FormatBlockCommand::doApply):
  • editing/FormatBlockCommand.h: Added. (WebCore::FormatBlockCommand::editingAction):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::editingAction):
  • editing/JSEditor.cpp:
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::validBlockTag): (WebCore::createElement):
  • editing/htmlediting.h:

WebKit:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)


  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
3:59 PM Changeset in webkit [14867] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

  • Plugins/WebPluginController.m: (cancelOutstandingCheck): (-[WebPluginController _cancelOutstandingChecks]): Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.
3:50 PM Changeset in webkit [14866] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:21 PM Changeset in webkit [14865] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Test case by Anders, reviewed and tweaked by Maciej.


  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work


  • fast/events/window-load-capture.html: Added.

WebCore:

Reviewed by Anders.

  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
2:51 PM Changeset in webkit [14864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Written by mjs, reviewed by Tim H.

<rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Call window capturing event handlers, not just bubbling event handlers.
2:45 PM Changeset in webkit [14863] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Beth.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"
2:17 PM Changeset in webkit [14862] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Rename RenderSlider to DeprecatedSlider, so that I can start work on
the new NSView-less slider.

Reviewed by john

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/DeprecatedSlider.cpp: Added. (WebCore::DeprecatedSlider::DeprecatedSlider): (WebCore::DeprecatedSlider::calcMinMaxWidth): (WebCore::DeprecatedSlider::updateFromElement): (WebCore::DeprecatedSlider::valueChanged):
  • rendering/DeprecatedSlider.h: Added. (WebCore::DeprecatedSlider::renderName):
  • rendering/RenderSlider.cpp: Removed.
  • rendering/RenderSlider.h: Removed.
10:04 AM Changeset in webkit [14861] by antti
  • 4 edits
    1 delete in S60/trunk

Reviewed by dacarson.

  • S60Internals/S60Headers.zip:
  • S60Internals/S60Libs.zip:
  • S60Internals/S60LibsGcce.zip:
  • S60Internals/SDK_GCCE_Patch.zip: Removed.

Jun 13, 2006:

10:54 PM Changeset in webkit [14860] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Test for createHTMLDocument.

  • fast/dom/implementation-createHTMLDocument-expected.txt: Added.
  • fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument appears challenging.


  • Added createHTMLDocument to Objc bindings, fixed up implementation to comply with the DOM 2 Candidate Recommendation in which is was defined. (It never made the final spec.) Also removed use of deprecatedString, to avoid unnecessary killing of puppies.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMImplementation createHTMLDocument:]):
  • bindings/objc/DOMPrivate.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
10:03 PM Changeset in webkit [14859] by mjs
  • 2 edits
    1 add in trunk/LayoutTests
  • fixed up results of the layout test I committed for 4583892, they were guaranteed to fail
  • fast/events/no-window-load-expected.txt:
  • fast/events/resources/greenbox.png: Added.
10:01 PM Changeset in webkit [14858] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

RS by MacDome. Added missing results for this test.

  • fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
6:35 PM Changeset in webkit [14857] by aliceli1
  • 2 edits
    2 adds in trunk

Reviewed by Adele.

fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on ​http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction): support this by converting the argument to an options object before passing to remove()
6:33 PM Changeset in webkit [14856] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page
  • fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
  • fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

This patch fixes a bug where the event listener cache does not distinguish
HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
prevented default masked a case of this bug on the yahoo.com home page until
we fixed bug 5180 on 2005-10-03.

Test: fast/events/event-listener-html-non-html-confusion.html

  • bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.
  • bindings/js/kjs_window.cpp: (KJS::Window::~Window): Go through the additional maps when clearing the window object pointer in event listeners. (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the argument passed. (KJS::Window::getJSUnprotectedEventListener): Ditto.
  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML or non-HTML map depending on the argument passed. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the HTML or non-HTML map depending on whether the HTML flag is set. (KJS::JSEventListener::JSEventListener): More of the same. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there is not a listener at construction time, thus the code here to put the listener into a map needs the HTML vs. non-HTML logic.
6:25 PM Changeset in webkit [14855] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.


  • test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com
  • fast/events/no-window-load-expected.txt: Added.
  • fast/events/no-window-load.html: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow "load" events to propagate up to the window. We need this quirk to avoid site hangs, because they depend on an old Mozilla bug.
6:11 PM Changeset in webkit [14854] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:56 PM Changeset in webkit [14853] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

New tag.

5:56 PM Changeset in webkit [14852] by thatcher
  • 1 delete in tags/WebCore-418.17/WebCore

Bad tag.

5:53 PM Changeset in webkit [14851] by thatcher
  • 1 copy in tags/WebCore-418.7/WebCore

New tag.

5:53 PM Changeset in webkit [14850] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:52 PM Changeset in webkit [14849] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog

Versioning

5:46 PM Changeset in webkit [14848] by ggaren
  • 4 edits in branches/Safari-2-0-branch/WebCore

Patch by Darin, tweaked by me, reviewed by Harrison.

  • Fixed <rdar://problem/4584598> 10.4.7 regression: Changing location for weather on yahoo.com home page redirects to another page


We need to keep separate caches for HTML and non-HTML event listeners
so that, if you add one of each to the same node, the two don't clobber
each other.

  • khtml/ecma/kjs_events.cpp: (JSUnprotectedEventListener::JSUnprotectedEventListener): (JSUnprotectedEventListener::~JSUnprotectedEventListener): (JSEventListener::JSEventListener): (JSEventListener::~JSEventListener): (JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_window.cpp: (Window::~Window): (Window::getJSEventListener): (Window::getJSUnprotectedEventListener):
  • khtml/ecma/kjs_window.h:
4:19 PM Changeset in webkit [14847] by antti
  • 7 edits
    12 adds in trunk

LayoutTests:

Reviewed by Hyatt

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

  • fast/block/positioning/relative-overflow-block-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-block-expected.png: Added.
  • fast/block/positioning/relative-overflow-block-expected.txt: Added.
  • fast/block/positioning/relative-overflow-block.html: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float.html: Added.
  • fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
Relative positioned block size doesnt update root layer size

  • take relative positioning into account in leftmost/rightmost/lowestPosition()
  • ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
  • split relativePositionOffset() to x and y functions


  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop):
3:20 PM Changeset in webkit [14846] by andersca
  • 4 edits
    2 adds in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
xml-stylesheet processing instructions outside of the prolog should have no effect.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Remove todo comment.


  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427


  • fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
  • fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.
3:19 PM Changeset in webkit [14845] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


  • fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context menu in Mail message body
  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Add special-case hackery to recover from this SPI -> API mismatch.
2:58 PM Changeset in webkit [14844] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Clarified my previous ChangeLog entry.

2:56 PM Changeset in webkit [14843] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Fixed a recently-introduced assertion failure when handling 404 errors.

  • WebView/WebDataSource.m: (-[WebDataSource _handleFallbackContent]): Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge]. The former is not valid until the data source has been committed, as is the case when the resource fails to load. The latter is safe to call at any time. This broke last night with Maciej's change to WebFrameResourceLoader. The old code used to call -[WebFrame _bridge].
1:17 PM Changeset in webkit [14842] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

Tag for WebCore 418.17 (part 2 of 2.)

1:17 PM Changeset in webkit [14841] by thatcher
  • 1 add in tags/WebCore-418.17

Tag for WebCore 418.17 (part 1 of 2.)

1:15 PM Changeset in webkit [14840] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

12:56 PM Changeset in webkit [14839] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Harrison, landed by Tim H.

Handle window events for capture phase, except load events, this quirk is needed because
Mozilla used to not do the bubble or capture phase for image load events and sites mistakenly
put capturing load event listeners on the window

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
6:37 AM Changeset in webkit [14838] by andersca
  • 6 edits in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests

  • Plugins/WebPluginDatabase.h: (-[WebPluginDatabase isMIMETypeRegistered:]): Add new function isMIMETypeRegistered which returns whether a given MIME type has a plugin registered.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase init]): Init set of registered MIME types.


(-[WebPluginDatabase refresh]):
Add and remove MIME types from the set of registered MIME types when registering and unregistering
plugin MIME types.


(-[WebPluginDatabase dealloc]):
Release set of registered MIME types.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge determineObjectFromMIMEType:URL:]): Use isMIMETypeRegistered here.

Jun 12, 2006:

11:37 PM Changeset in webkit [14837] by ggaren
  • 1 edit
    1 add in trunk/WebCore

build fix -- forgot to svn add this file


  • ForwardingHeaders/kjs/SavedBuiltins.h: Added.
11:27 PM Changeset in webkit [14836] by ggaren
  • 2 edits in trunk/JavaScriptCore

build fix


  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): Restore assignment I accidentally deleted in previous commit
11:10 PM Changeset in webkit [14835] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fixed a bug in append(char) and append(UChar) where our intended copy-on-write semantics was ignored!

  • platform/String.cpp: (WebCore::String::append):
11:08 PM Changeset in webkit [14834] by ggaren
  • 29 edits
    2 copies
    1 move
    4 adds in trunk

JavaScriptCore:

Reviewed by TimO, Maciej.


  • Merged InterpreterImp code into Interpreter, which implements all interpreter functionality now. This is part of my continuing quest to create an external notion of JS "execution context" that is unified and simple -- something to replace the mix of Context, ContextImp, ExecState, Interpreter, InterpreterImp, and JSRun.


All tests pass. Leaks test has not regressed from its baseline ~207 leaks
with ~3460 leaked nodes.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.cpp:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]):
  • bindings/runtime_root.cpp:
  • bindings/runtime_root.h:
  • kjs/Context.cpp: (KJS::Context::Context):
  • kjs/ExecState.cpp: Added. (KJS::ExecState::lexicalInterpreter):
  • kjs/ExecState.h: Added. (KJS::ExecState::dynamicInterpreter):
  • kjs/SavedBuiltins.h: Added.
  • kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype):
  • kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::numInterpreters):
  • kjs/context.h:
  • kjs/debugger.cpp: (Debugger::attach): (Debugger::detach):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp: (KJS::interpreterMap): (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::globalExec): (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate): (KJS::Interpreter::builtinObject): (KJS::Interpreter::builtinFunction): (KJS::Interpreter::builtinArray): (KJS::Interpreter::builtinBoolean): (KJS::Interpreter::builtinString): (KJS::Interpreter::builtinNumber): (KJS::Interpreter::builtinDate): (KJS::Interpreter::builtinRegExp): (KJS::Interpreter::builtinError): (KJS::Interpreter::builtinObjectPrototype): (KJS::Interpreter::builtinFunctionPrototype): (KJS::Interpreter::builtinArrayPrototype): (KJS::Interpreter::builtinBooleanPrototype): (KJS::Interpreter::builtinStringPrototype): (KJS::Interpreter::builtinNumberPrototype): (KJS::Interpreter::builtinDatePrototype): (KJS::Interpreter::builtinRegExpPrototype): (KJS::Interpreter::builtinErrorPrototype): (KJS::Interpreter::builtinEvalError): (KJS::Interpreter::builtinRangeError): (KJS::Interpreter::builtinReferenceError): (KJS::Interpreter::builtinSyntaxError): (KJS::Interpreter::builtinTypeError): (KJS::Interpreter::builtinURIError): (KJS::Interpreter::builtinEvalErrorPrototype): (KJS::Interpreter::builtinRangeErrorPrototype): (KJS::Interpreter::builtinReferenceErrorPrototype): (KJS::Interpreter::builtinSyntaxErrorPrototype): (KJS::Interpreter::builtinTypeErrorPrototype): (KJS::Interpreter::builtinURIErrorPrototype): (KJS::Interpreter::mark): (KJS::Interpreter::interpreterWithGlobalObject): (KJS::Interpreter::saveBuiltins): (KJS::Interpreter::restoreBuiltins):
  • kjs/interpreter.h: (KJS::Interpreter::setCompatMode): (KJS::Interpreter::compatMode): (KJS::Interpreter::firstInterpreter): (KJS::Interpreter::nextInterpreter): (KJS::Interpreter::prevInterpreter): (KJS::Interpreter::debugger): (KJS::Interpreter::setDebugger): (KJS::Interpreter::setContext): (KJS::Interpreter::context):
  • kjs/nodes.cpp: (StatementNode::hitStatement): (RegExpNode::evaluate):
  • kjs/protect.h:

JavaScriptGlue:

Reviewed by TimO, Maciej.


  • JSGlue part of merging InterpreterImp into Interpreter.


Since there's now a kjs forwarding header, I moved all forwarding
headers into a "ForwardingHeaders" directory, like in WebCore.

  • ForwardingHeaders: Added.
  • ForwardingHeaders/kjs: Added.
  • ForwardingHeaders/kjs/ExecState.h: Added.
  • ForwardingHeaders/wtf: Added.
  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • config.h:
  • wtf: Removed.
  • wtf/AlwaysInline.h: Removed.
  • wtf/Assertions.h: Removed.
  • wtf/FastMalloc.h: Removed.
  • wtf/Forward.h: Removed.
  • wtf/HashCountedSet.h: Removed.
  • wtf/HashSet.h: Removed.
  • wtf/Noncopyable.h: Removed.
  • wtf/OwnArrayPtr.h: Removed.
  • wtf/OwnPtr.h: Removed.
  • wtf/PassRefPtr.h: Removed.
  • wtf/Platform.h: Removed.
  • wtf/RefPtr.h: Removed.
  • wtf/Vector.h: Removed.

WebCore:

Reviewed by TimO, Maciej.

  • WebCore part of merging InterpreterImp into Interpreter. No test because there's no behavior change.


A substantive change here is that ScriptInterpreter::mark must now chain to
Interpreter::mark, since Interpreter needs to mark the things that
InterpreterImp used to mark.


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
  • kwq/KWQPageState.mm:
10:09 PM Changeset in webkit [14833] by mjs
  • 3 edits in trunk/WebKit
  • fix for cocoa exception (whoops)
  • WebView/WebView.m: (+[WebView _generatedMIMETypeForURLScheme:]): put this back
  • WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView
8:36 PM Changeset in webkit [14832] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.


  • remove use of WebView and related from WebMainResourceLoader
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): (+[WebDataSource _representationExistsForURLScheme:]): (+[WebDataSource _canShowMIMEType:]): (-[WebDataSource _handleFallbackContent]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _isMainFrame]):
  • WebView/WebFrameInternal.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader loadWithRequestNow:]):
  • WebView/WebView.m:
6:04 PM Changeset in webkit [14831] by beidson
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

Changed String::ascii() to return a Vector<char> instead of const char*
This allows us to use it "regularly" as the returned vector will destruct
and not leak memory like the previous approach.
We can now do a String.ascii().data() to get a char* buffer instead of
String.deprecatedString().ascii(). It doesn't improve the style much but
dumping the memory-leak issue is a plus.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::clearDatabase):
  • icon/SQLDatabase.cpp: (SQLDatabase::open):
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults): In addition to the changes to the string classes, changed my database code over to the new preferred method.
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::ascii):
  • platform/StringImpl.cpp: (WebCore::StringImpl::ascii):
  • platform/StringImpl.h:
5:27 PM Changeset in webkit [14830] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]): Renamed from -initWithPath:. Instead of releasing/deallocating self on error, return NO. (-[WebNetscapePluginPackage initWithPath:]): Call the new -_initWithPath:. If it returns NO, unload the plugin package before deallocating it.
4:16 PM Changeset in webkit [14829] by thatcher
  • 1 copy in tags/WebCore-418.16/WebCore

Tag for WebCore 418.16 (part 2 of 2.)

4:16 PM Changeset in webkit [14828] by thatcher
  • 1 add in tags/WebCore-418.16

Tag for WebCore 418.16 (part 1 of 2.)

4:03 PM Changeset in webkit [14827] by hyatt
  • 17 edits in trunk/WebCore

Add selection foreground color on Win32.

4:02 PM Changeset in webkit [14826] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.


  • page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Do a "fake" paint here so that the rectangles for the text matches will have been computed by the time this method returns.
3:43 PM Changeset in webkit [14825] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Levi and Tim Omernick.

-Added a skeleton sqlite3 icon database file to IconDatabase
-Added functionality to validate and recreate this icon.db file
-Fixed some buggys in SQLDatabase.cpp

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::recreateDatabase):
  • icon/IconDatabase.h:
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_* function calls weren't as error-tolerant as documentation advertised (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)
1:54 PM Changeset in webkit [14824] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:53 PM Changeset in webkit [14823] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej, Harrison.

Fixes <rdar://problem/4582172> frameset load events don't fire (can't login into Gmail account or see map at 511.org)

Framesets need to register their load, beforeunload and unload events with the window.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::parseHTMLAttribute):
12:53 PM Changeset in webkit [14822] by hyatt
  • 3 edits in trunk/WebCore/platform

Fix Win32 build bustage.

12:02 PM Changeset in webkit [14821] by ggaren
  • 10 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Have *.lut.h files #include lookup.h to eliminate surprising header include order dependency.
  • DerivedSources.make:
  • kjs/array_object.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h: (KJS::DateProtoFunc::):
  • kjs/lexer.cpp:
  • kjs/math_object.cpp:
  • kjs/number_object.cpp:
  • kjs/regexp_object.cpp:
  • kjs/string_object.cpp:
11:07 AM Changeset in webkit [14820] by beidson
  • 7 edits
    3 adds in trunk/WebCore

Reviewed by Levi.

-Added SQLite helper wrappers to ease use of SQLite in the IconDatabase.
-Changed the base IconDatabase over to this new framework.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]):

-By popular request, removed an annoying log message I'd accidentally left in

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::~IconDatabase):
  • icon/IconDatabase.h: (WebCore::IconDatabase::isOpen):

-Changed over IconDatabase from direct sqlite3_* calls to the new SQLDatabase calls

  • icon/SQLDatabase.cpp: Added. (SQLDatabase::SQLDatabase): (SQLDatabase::open): (SQLDatabase::close): (SQLDatabase::executeCommand): (SQLDatabase::tableExists):
  • icon/SQLDatabase.h: Added. (WebCore::SQLDatabase::isOpen): (WebCore::SQLDatabase::getPath): (WebCore::SQLDatabase::lastError): (WebCore::SQLDatabase::lastErrorMsg): (WebCore::SQLStatement::isPrepared): (WebCore::SQLStatement::lastError): (WebCore::SQLStatement::lastErrorMsg):
  • icon/SQLStatement.cpp: Added. (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::~SQLStatement): (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::finalize): (WebCore::SQLStatement::reset): (WebCore::SQLStatement::executeCommand): (WebCore::SQLStatement::bindBlob): (WebCore::SQLStatement::bindText): (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults):

-Initial checking of SQLDatabase framework

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::String):

-Added an explicit UChar* constructor to our string class as much of sqlite3's UTF16 handling is based on
null-terminated UTF16 which we didn't yet support.

Jun 11, 2006:

9:10 PM Changeset in webkit [14819] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9408
Clean build fails with "make: * No rule to make target SVGElementFactory.cpp', needed by all'. Stop"

  • DerivedSources.make: Fix clean builds.
7:03 PM Changeset in webkit [14818] by darin
  • 10 edits in trunk/WebCore
  • another try at fixing Windows
  • loader/CachedResource.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setData):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoderPrivate::decode): (WebCore::GIFImageDecoder::setData):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::setData):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::setData):
  • platform/image-decoders/png/PNGImageDecoder.h: s/DeprecatedByteArray/Vector<char>/
6:37 PM Changeset in webkit [14817] by darin
  • 5 edits in trunk

WebCore:

  • try to fix Windows build
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Use Vector<char> instead of DeprecatedByteArray.
  • platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): Don't try to return 0 from a function that returns a Vector<char>.

WebKit:

  • try to fix Windows build
  • COM/WebKitDLL.cpp: (loadResourceIntoArray): Use Vector<char> instead of DeprecatedByteArray.
6:10 PM Changeset in webkit [14816] by darin
  • 59 edits
    2 deletes in trunk/WebCore

Reviewed by Hyatt, tweaked quite a bit and landed by Darin.

This removes most of the uses of DeprecatedArray and
DeprecatedByteArray, with the exception of DeprecatedCString.

No test cases added because there is no change in
functionality.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::bufferData): (WebCore::CachedImage::data): (WebCore::CachedImage::checkNotify): (WebCore::CachedImage::shouldStopAnimation):
  • loader/CachedImage.h:
  • loader/CachedObject.cpp: (WebCore::CachedObject::bufferData): (WebCore::CachedObject::setExpireDate):
  • loader/CachedObject.h: (WebCore::CachedObject::setCharset):
  • loader/CachedScript.cpp: (WebCore::CachedScript::data):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): (WebCore::CachedXBLDocument::checkNotify):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
  • loader/CachedXSLStyleSheet.h:
  • loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
  • loader/Request.h: (WebCore::Request::buffer): (WebCore::Request::cachedObject): (WebCore::Request::docLoader): (WebCore::Request::isIncremental): (WebCore::Request::setIsIncremental): (WebCore::Request::isMultipart): (WebCore::Request::setIsMultipart):
  • loader/loader.cpp: (WebCore::crossDomain): (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::numRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::removeBackgroundDecodingRequest): (WebCore::Loader::jobForRequest):
  • platform/Image.cpp: (WebCore::Image::setData):
  • platform/Image.h: (WebCore::Image::dataBuffer):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
  • css/cssstyleselector.h: (WebCore::CSSStyleSelector::addMatchedRule): (WebCore::CSSStyleSelector::addMatchedDeclaration):
  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::openFunc):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::length): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::value): (WebCore::HTMLSelectElement::setValue): (WebCore::HTMLSelectElement::state): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::appendFormData): (WebCore::HTMLSelectElement::optionToListIndex): (WebCore::HTMLSelectElement::listToOptionIndex): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::listItems):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
  • kwq/KWQTextStream.cpp: (QTextStream::operator<<):
  • kwq/KWQTextStream.h:
  • loader/FormData.cpp: (WebCore::FormData::flatten): (WebCore::FormData::flattenToString):
  • loader/FormData.h: (WebCore::FormDataElement::FormDataElement):
  • platform/DeprecatedString.cpp:
  • platform/DeprecatedString.h:
  • platform/IntPointArray.cpp: Removed.
  • platform/IntPointArray.h: Removed.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::toUnicode):
  • platform/TextEncoding.h:
  • platform/cairo/pixman/src/pixregion.c:
  • platform/cg/PathCG.cpp: (WebCore::Path::Path):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
  • rendering/RenderTable.h: (WebCore::RenderTable::colToEffCol): (WebCore::RenderTable::effColToCol):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths):
  • rendering/RenderTableSection.h:
  • rendering/bidi.cpp: (WebCore::addMidpoint): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::layout): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::updateSelection):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::layout):
  • rendering/table_layout.h:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::processSyncLoadResults):
  • xml/xmlhttprequest.h:
4:58 PM Changeset in webkit [14815] by ddkilzer
  • 122 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9394
Fix no-SVG build

  • DerivedSources.make: Removed tabs. Create empty SVGElementFactory.cpp on no-svg build.
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Added #if SVG_SUPPORT/#endif.
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Ditto.
  • ksvg2/bindings/idl/svg/SVGAElement.idl: Add "Conditional=SVG" to all interfaces.
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGDescElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGEvent.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGException.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGGElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGICCColor.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGImageElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGLengthList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGLineElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGLocatable.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGNumberList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPaint.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPointList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGRectElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGSetElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGStopElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGStringList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGStylable.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTests.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTextElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTransformList.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGTransformable.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGURIReference.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGUseElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGViewElement.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Ditto.
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Ditto.
  • ksvg2/svg/SVGAngle.idl: Ditto.
  • ksvg2/svg/SVGAnimatedLength.idl: Ditto.
  • ksvg2/svg/SVGColor.idl: Ditto.
  • ksvg2/svg/SVGDocument.idl: Ditto.
  • ksvg2/svg/SVGElement.idl: Ditto.
  • ksvg2/svg/SVGEvent.idl: Ditto.
  • ksvg2/svg/SVGLength.idl: Ditto.
  • ksvg2/svg/SVGMatrix.idl: Ditto.
  • ksvg2/svg/SVGNumber.idl: Ditto.
  • ksvg2/svg/SVGPoint.idl: Ditto.
  • ksvg2/svg/SVGRect.idl: Ditto.
  • ksvg2/svg/SVGSVGElement.idl: Ditto.
  • ksvg2/svg/SVGTransform.idl: Ditto.
4:49 PM Changeset in webkit [14814] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9395
Make prepare-ChangeLog faster

  • Scripts/prepare-ChangeLog: Use "svn diff" instead of "svn stat" to find changed files, then save the diff output for reuse. Keep a status variable if changes are made to LayoutTests so "svn diff LayoutTests" doesn't have to be run to check for changes when
WebCore is updated. Added -hhelp command-line switch and help message. Move test

for no changed files closer to the beginning of the program.

1:18 PM Changeset in webkit [14813] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Removes a hardcoded path I had added for testing.

1:10 PM Changeset in webkit [14812] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim H.

  • WebInspector/WebInspector.m: (-[NSWindow windowWillClose:]): Added a call to setWebFrame to avoid further load progress notifications. (-[NSWindow setWebFrame:]): Changed to resign the WebView's hostWindow rather than its window for close notifications, to avoid resigning from all windows' close notifications (including the inspector window's) when the WebView is in a hidden tab. Also changed to prevent highlighting the initial focused node.
12:49 PM Changeset in webkit [14811] by andersca
  • 30 edits
    2 adds
    6 deletes in trunk

WebCore:

2006-06-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
Move full-frame plugins to WebCore


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add PluginDocument


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::redirectDataToPlugin): Call the bridge.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: Add redirectDataToPlugin which is used to redirect incoming data to a plugin.


  • bridge/mac/WebCoreViewFactory.h: Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.


  • dom/DOMImplementation.cpp:
  • dom/DOMImplementation.h: Get rid of createTextDocument and just create a text document explicitly when needed.


  • dom/Document.h: (WebCore::Document::isPluginDocument):
  • loader/PluginDocument.cpp: Added. (WebCore::PluginTokenizer::PluginTokenizer): (WebCore::PluginTokenizer::wantsRawData): (WebCore::PluginTokenizer::write): (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData): (WebCore::PluginTokenizer::stopParsing): (WebCore::PluginTokenizer::finish): (WebCore::PluginTokenizer::isWaitingForScripts): (WebCore::PluginDocument::PluginDocument): (WebCore::PluginDocument::createTokenizer):
  • loader/PluginDocument.h: Added. (WebCore::PluginDocument::isPluginDocument): Add PluginDocument.


  • page/Frame.cpp: (WebCore::Frame::begin): Possibly create a plugin document.


  • page/Frame.h: (WebCore::Frame::redirectDataToPlugin): Add declaration.


  • platform/PlugInInfoStore.h:
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::supportsMIMEType): Ask WebCoreViewFactory if the MIME type is supported.

WebKit:

2006-06-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
Move full-frame plugins to WebCore

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream instance]): Add instance method which returns the plugin instance.


  • Plugins/WebBasePluginPackage.h: Add WebPluginManualLoader protocol


  • Plugins/WebNetscapePluginDocumentView.h: Removed.
  • Plugins/WebNetscapePluginDocumentView.m: Removed.
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView didStart]): (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]): (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]): (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]): (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]): (-[WebNetscapePluginEmbeddedView redeliverStream]): Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the data manually. Much of this code has been copied from WebNetscapePluginRepresentation.
  • Plugins/WebNetscapePluginRepresentation.h: Removed.
  • Plugins/WebNetscapePluginRepresentation.m: Removed.
  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]): (-[WebPluginController pluginView:receivedData:]): (-[WebPluginController pluginView:receivedError:]): (-[WebPluginController pluginViewFinishedLoading:]): Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.


  • Plugins/WebPluginDocumentView.h: Removed.
  • Plugins/WebPluginDocumentView.m: Removed.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Add loadManually argument.


(-[WebFrameBridge redirectDataToPlugin:]):
Call down to the HTML representation.


(-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
Pass NO to loadManually.


(-[WebFrameBridge determineObjectFromMIMEType:URL:]):
Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.


  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory pluginSupportsMIMEType:]): New function which returns whether any plugins support a given MIME type.


  • WebKit.xcodeproj/project.pbxproj: Update for removed files.


  • WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Remove view type checks.


(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
Remove FIXME comments.


  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]): New function which redirects incoming data to a manual loader.


(-[WebHTMLRepresentation receivedData:withDataSource:]):
(-[WebHTMLRepresentation receivedError:withDataSource:]):
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
Optionally redirect incoming data.


  • WebView/WebHTMLRepresentationPrivate.h:

Jun 10, 2006:

9:07 PM Changeset in webkit [14810] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Patch by mitzpettel. Reviewed by hyatt.

  • fast/repaint/static-to-positioned-expected.checksum: Added.
  • fast/repaint/static-to-positioned-expected.png: Added.
  • fast/repaint/static-to-positioned-expected.txt: Added.
  • fast/repaint/static-to-positioned.html: Added.

WebCore:

Patch by mitzpettel. Reviewed by hyatt.

Test: fast/repaint/static-to-positioned.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint as static.
8:46 PM Changeset in webkit [14809] by ddkilzer
  • 4 edits
    9 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • test repainting of layer children's outlines that extend beyond the layer
  • fast/layers: Added.
  • fast/layers/opacity-outline-expected.checksum: Added.
  • fast/layers/opacity-outline-expected.png: Added.
  • fast/layers/opacity-outline-expected.txt: Added.
  • fast/layers/opacity-outline.html: Added.
  • fast/repaint/layer-child-outline-expected.checksum: Added.
  • fast/repaint/layer-child-outline-expected.png: Added.
  • fast/repaint/layer-child-outline-expected.txt: Added.
  • fast/repaint/layer-child-outline.html: Added.

WebCore:

Reviewed by hyatt.

Test: fast/layers/opacity-outline.html

  • fix repainting of layer children's outlines that extend beyond the layer

Test: fast/repaint/layer-child-outline.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::intersectsDamageRect): Account for outlines. (WebCore::RenderLayer::absoluteBoundingBox): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::maximalOutlineSize): Changed to return the view's maximal outline size rather than 0 for PaintPhaseChildOutlines.
7:34 PM Changeset in webkit [14808] by sfalken
  • 3 edits in trunk/WebCore

2006-06-10 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::scale):
9:09 AM Changeset in webkit [14807] by ggaren
  • 28 edits in trunk

JavaScriptCore:


Fix by Mike Emmel, Reviewed by Darin.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:
  • wtf/Platform.h:

WebCore:


Fix by Mike Emmel, Reviewed by Darin.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • css/maketokenizer:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLImageElement.h:
  • icon/IconDatabase.cpp:
  • make-generated-sources.sh:
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/Cursor.h:
  • platform/FontData.h: (WebCore::FontData::getGlyphIndex):
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/GraphicsContext.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/ScrollView.h:
  • platform/TransferJob.h: (WebCore::TransferJob::getInternal):
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
  • platform/Widget.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::roundToDevicePixels):
  • webcore-base.bkl:
  • xpath/impl/XPathValue.cpp:
6:42 AM Changeset in webkit [14806] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

WebKit support for computing but not highlighting rects for text matches.

  • WebView/WebHTMLViewPrivate.h: added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and rectsForTextMatches, and renamed related methods for clarity/consistency
  • WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:]): renamed, calls similarly-renamed method (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): new method, calls through to bridge (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): renamed (-[WebHTMLView rectsForTextMatches]): new method, calls through to bridge
  • WebView/WebViewPrivate.h: added rectsForTextMatches, renamed other methods (and added highlight: parameter)
  • WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:]): renamed for clarity/consistency, and now has highlight: parameter, which is passed down (-[WebView unmarkAllTextMatches]): renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got confused with the end of this and the end of the next method. (-[WebView rectsForTextMatches]): new method, calls through to WebHTMLView as related methods currently do
6:42 AM Changeset in webkit [14805] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Tim Omernick and Dave Hyatt.

WebCore support for computing but not highlighting rects for text matches.

  • dom/Document.h: added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers and one vector of rects


  • dom/Document.cpp: (placeholderRectForMarker()): new function, returns a recognizable degenerate rect used until a real rect has been set (WebCore::Document::addMarker): Reworked for new MarkerMap data structure; now adds parallel placeholder rect along with marker (WebCore::Document::copyMarkers): Reworked for new MarkerMap data structure (WebCore::Document::removeMarkers): Reworked for new MarkerMap data structure; now removed corresponding rect along with marker (WebCore::Document::markersForNode): Reworked for new MarkerMap data structure (WebCore::Document::renderedRectsForMarkers): New method, returns an array of all non-placeholder rects for the given marker type (WebCore::Document::repaintMarkers): Reworked for new MarkerMap data structure (WebCore::Document::setRenderedRectForMarker): New method, sets the rendered rect for a given marker (WebCore::Document::shiftMarkers): Reworked for new MarkerMap data structure; resets rendered rects to placeholders.


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker now, but sometimes we will end up only computing the rect, not actually highlighting it. (Maybe some names should be improved here?) (WebCore::InlineTextBox::paintTextMatchMarker): Reorganized to move all the code that actually draws into a block that's guarded by markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will go, and now we always use that computation in order to call setRenderedRectForMarker.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rectsForTextMatches]): New method, returns an array of NSValues representing NSRects. Gets them from Document::renderedRectsForMarkers
6:38 AM Changeset in webkit [14804] by sullivan
  • 2 edits in trunk/WebKit

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
WebView's initWithCoder: method does not set useBackForwardList
correctly


Reviewed by John Sullivan.

  • WebView/WebView.m: (-[WebView initWithCoder:]): Make sure that the function variable useBackForwardList is correctly set, so that the copy in the _private ivar is set.
3:24 AM Changeset in webkit [14803] by ap
  • 2 edits in trunk/WebKitTools

2006-06-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

  • make DumpRenderTree build
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState (-[WaitUntilDoneDelegate webViewFocus:]): Ditto. (-[LayoutTestController setWindowIsKey:]): Ditto. (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto.
2:59 AM Changeset in webkit [14802] by andersca
  • 2 edits in trunk/WebCore

2006-06-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Eric.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::put): Call WebCore::JSHTMLElement::put so that autogenerated setters will work for HTMLElement.

Jun 9, 2006:

9:52 PM Changeset in webkit [14801] by ggaren
  • 3 edits in trunk/JavaScriptCore

Build fix -- I think :).

9:34 PM Changeset in webkit [14800] by ggaren
  • 2 edits in trunk/WebCore
  • Build fix after last JSC check-in (oops!)


  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
8:57 PM Changeset in webkit [14799] by ggaren
  • 10 edits
    1 copy in trunk/JavaScriptCore

Reviewed by Eric (yay!).


  • Removed Context wrapper for ContextImp, renamed ContextImp to Context, split Context into its own file -- Context.cpp -- renamed _var to m_var, change ' *' to '* '.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Context.cpp: Added. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
  • kjs/context.h: (KJS::Context::scopeChain): (KJS::Context::variableObject): (KJS::Context::setVariableObject): (KJS::Context::thisValue): (KJS::Context::callingContext): (KJS::Context::activationObject): (KJS::Context::currentBody): (KJS::Context::function): (KJS::Context::arguments): (KJS::Context::pushScope): (KJS::Context::seenLabels):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/internal.cpp: (KJS::InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::setContext): (KJS::InterpreterImp::context):
  • kjs/interpreter.cpp:
  • kjs/interpreter.h: (KJS::ExecState::context): (KJS::ExecState::ExecState):
  • kjs/nodes.cpp: (currentSourceId): (currentSourceURL): (ThisNode::evaluate): (ResolveNode::evaluate): (FunctionCallResolveNode::evaluate): (PostfixResolveNode::evaluate): (DeleteResolveNode::evaluate): (TypeOfResolveNode::evaluate): (PrefixResolveNode::evaluate): (AssignResolveNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (ContinueNode::execute): (BreakNode::execute): (ReturnNode::execute): (WithNode::execute): (SwitchNode::execute): (LabelNode::execute): (TryNode::execute): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
8:09 PM Changeset in webkit [14798] by justing
  • 1 edit in trunk/WebCore/ChangeLog
5:16 PM Changeset in webkit [14797] by thatcher
  • 1 copy in tags/WebCore-418.15/WebCore

Tag for WebCore 418.15 (part 2 of 2.)

5:16 PM Changeset in webkit [14796] by thatcher
  • 1 add in tags/WebCore-418.15

Tag for WebCore 418.15 (part 1 of 2.)

5:01 PM Changeset in webkit [14795] by hyatt
  • 1 edit in trunk/WebCore/page/Frame.cpp

Fix win32 build bustage.

4:37 PM Changeset in webkit [14794] by hyatt
  • 3 edits in trunk/WebKit

Rename updateFocusState to updateActiveState.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateActiveState]): (-[NSArray viewDidMoveToWindow]): (-[NSArray windowDidBecomeKey:]): (-[NSArray windowDidResignKey:]): (-[NSArray becomeFirstResponder]): (-[NSArray resignFirstResponder]): (-[WebHTMLView _formControlIsBecomingFirstResponder:]): (-[WebHTMLView _formControlIsResigningFirstResponder:]):
  • WebView/WebHTMLViewPrivate.h:
4:33 PM Changeset in webkit [14793] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/xml/dom_nodeimpl.cpp

Correcting a merge problem.

4:30 PM Changeset in webkit [14792] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes the regression from <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-23 Vicki Murley <​vicki@apple.com>

Reviewed by Hyatt.

  • fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
  • dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter
4:26 PM Changeset in webkit [14791] by hyatt
  • 5 edits in trunk/WebCore

Rename m_isFocused on the frame to m_isActive, since it isn't really
about focus but is instead about whether or not the top-level window is
active.

Pull code that was incorrectly factored into Mac-only code out of FrameMac
and back up into Frame.

Reviewed by andersca

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • page/Frame.cpp: (WebCore::Frame::setFocusNodeIfNeeded): (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
4:07 PM Changeset in webkit [14790] by hyatt
  • 1 edit in trunk/WebKit/COM/WebView.cpp

Fix Win32 build bustage.

3:04 PM Changeset in webkit [14789] by thatcher
  • 1 copy in tags/WebCore-418.14/WebCore

Tag for WebCore 418.14 (part 2 of 2.)

3:04 PM Changeset in webkit [14788] by thatcher
  • 1 add in tags/WebCore-418.14

Tag for WebCore 418.14 (part 1 of 2.)

3:03 PM Changeset in webkit [14787] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:01 PM Changeset in webkit [14786] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Rolling out this fix, this caused a Mail regression.
<rdar://problem/4578653> Forwarding loses the attached images

2006-04-26 Tim Omernick <​timo@apple.com>


Reviewed by Hyatt.


<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript


  • html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.
2:25 PM Changeset in webkit [14785] by thatcher
  • 1 edit in trunk/WebKitSite/coding/bsd-license.html

Removes some control characters that snuck in.

1:20 PM Changeset in webkit [14784] by hyatt
  • 34 edits in trunk

WebCore:

Rework selection coloring. Rename displaysWithFocusAttributes
to isActive. Move the white-blending code onto the Color API to make
it more convenient to mutate colors for selection blending. Eliminate all
the selection state from the GraphicsContext and move it to the RenderTheme.
Implement both Win32 and Mac theme selection colors.

Reviewed by sfalken

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setIsActive):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): (-[WebCoreFrameBridge setIsActive:]): (-[WebCoreFrameBridge selectionColor]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • page/Frame.cpp: (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
  • page/Frame.h:
  • platform/Color.cpp: (WebCore::blend): (WebCore::Color::blendWithWhite):
  • platform/Color.h: (WebCore::Color::hasAlpha):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::endTransparencyLayer):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionColor):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderReplaced.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionColor): (WebCore::RenderTheme::inactiveSelectionColor): (WebCore::RenderTheme::platformActiveSelectionColor): (WebCore::RenderTheme::platformInactiveSelectionColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionColor): (WebCore::RenderThemeMac::platformInactiveSelectionColor):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::platformActiveSelectionColor): (WebCore::RenderThemeWin::platformInactiveSelectionColor):
  • rendering/RenderThemeWin.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):

WebKit:

Rename displaysWithFocusAttributes to isActive.

Reviewed by sfalken

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]):
1:14 PM Changeset in webkit [14783] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-08 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

  • Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

  • fast/events/window-events-bubble.html
  • fast/events/window-events-bubble2.html
  • fast/events/window-events-capture.html
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
  • khtml/xml/DocumentImpl.h: Added handleWindowEvent.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
12:14 PM Changeset in webkit [14782] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

  • editing/execCommand/findString-expected.checksum: Added.
  • editing/execCommand/findString-expected.png: Added.
  • editing/execCommand/findString-expected.txt: Added.
  • editing/execCommand/findString.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

  • bridge/mac/FrameMac.h: Moved findString to Frame.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): Convert the NSString to a String.
  • editing/JSEditor.cpp: Added execCommand(FindString, ...)
  • editing/Selection.cpp: Added a constructor for Ranges (WebCore::Selection::Selection):
  • editing/Selection.h:
  • page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges.
  • page/Frame.h:
12:06 PM Changeset in webkit [14781] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin, landed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9350
Use pathcmp() when sorting paths in svn-create-patch

  • Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex.
  • Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests. Changed sort() functions to use pathcmp(). Added subroutine prototypes. Added -h command-line switch and printUsage() subroutine.
11:40 AM Changeset in webkit [14780] by sfalken
  • 4 edits in trunk/WebCore

2006-06-09 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • css/MediaQueryEvaluator.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
10:09 AM Changeset in webkit [14779] by bdakin
  • 23 edits
    234 adds in trunk

Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
Landed by Beth.

CSS3 Media Queries implementation.
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127>

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
  • bindings/objc/DOMCSS.mm: (-[DOMMediaList setMediaText:]): (-[DOMMediaList deleteMedium:]): (-[DOMMediaList appendMedium:]):
  • css/CSSGrammar.y:
  • css/MediaFeatureNames.cpp: Added. (WebCore::MediaFeatureNames::init):
  • css/MediaFeatureNames.h: Added.
  • css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::~MediaList): (WebCore::parseMediaDescriptor): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::mediaText): (WebCore::MediaList::setMediaText): (WebCore::MediaList::item): (WebCore::MediaList::appendMedium): (WebCore::MediaList::appendMediaQuery):
  • css/MediaList.h: (WebCore::MediaList::MediaList): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries):
  • css/MediaQuery.cpp: Added. (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText):
  • css/MediaQuery.h: Added. (WebCore::MediaQuery::): (WebCore::MediaQuery::restrictor): (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (WebCore::MediaQuery::append):
  • css/MediaQueryEvaluator.cpp: Added. (WebCore::): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::mediaTypeMatch): (WebCore::applyRestrictor): (WebCore::MediaQueryEvaluator::eval): (WebCore::parseAspectRatio): (WebCore::cmpvalue): (WebCore::numberValue): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::createFunctionMap):
  • css/MediaQueryEvaluator.h: Added.
  • css/MediaQueryExp.cpp: Added. (WebCore::MediaQueryExp::MediaQueryExp): (WebCore::MediaQueryExp::~MediaQueryExp):
  • css/MediaQueryExp.h: Added. (WebCore::MediaQueryExp::mediaFeature): (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::operator==):
  • css/StyleSheet.cpp: (WebCore::StyleSheet::setMedia):
  • css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::sinkFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery): (WebCore::CSSParser::sinkFloatingMediaQuery):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/cssstyleselector.h:
  • css/maketokenizer:
  • css/tokenizer.flex:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::createCSSStyleSheet):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • platform/Screen.h:
  • platform/mac/ScreenMac.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):

Jun 8, 2006:

11:14 PM Changeset in webkit [14778] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Tweaked ChangeLog

9:57 PM Changeset in webkit [14777] by justing
  • 39 edits
    26 adds in trunk

LayoutTests:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

Added:

  • editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
  • editing/execCommand/create-list-from-range-selection-expected.png: Added.
  • editing/execCommand/create-list-from-range-selection-expected.txt: Added.
  • editing/execCommand/create-list-from-range-selection.html: Added.
  • editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
  • editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • editing/execCommand/insert-list-and-stitch-expected.txt: Added.
  • editing/execCommand/insert-list-and-stitch.html: Added.
  • editing/execCommand/insert-list-with-id-expected.checksum: Added.
  • editing/execCommand/insert-list-with-id-expected.png: Added.
  • editing/execCommand/insert-list-with-id-expected.txt: Added.
  • editing/execCommand/insert-list-with-id.html: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.png: Added.
  • editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
  • editing/execCommand/remove-list-from-range-selection.html: Added.
  • editing/execCommand/remove-list-items-expected.checksum: Added.
  • editing/execCommand/remove-list-items-expected.png: Added.
  • editing/execCommand/remove-list-items-expected.txt: Added.
  • editing/execCommand/remove-list-items.html: Added.
  • editing/execCommand/switch-list-type-expected.checksum: Added.
  • editing/execCommand/switch-list-type-expected.png: Added.
  • editing/execCommand/switch-list-type-expected.txt: Added.
  • editing/execCommand/switch-list-type.html: Added.


Fixes:

  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • fast/text/textIteratorNilRenderer-expected.checksum:
  • fast/text/textIteratorNilRenderer-expected.png:
  • fast/text/textIteratorNilRenderer-expected.txt:
  • editing/deleting/delete-line-016-expected.checksum:
  • editing/deleting/delete-line-016-expected.png:
  • editing/deleting/delete-line-016-expected.txt:

WebCore:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

  • WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
  • dom/Position.cpp: (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): Added. A block with height is only a candidate if this is false. This should fix the problems getting carets into empty blocks. (WebCore::Position::inRenderedContent):
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet have no rendered descendants. Fixed the pruning rule to avoid removing a node like this. (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to each other if they aren't already, as a convenience. (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should continue to happen until it is no longer possible. (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node wouldn't always avoid removing the start block.
  • editing/InsertListCommand.cpp: Added. (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list into a list. (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: Added. (WebCore::InsertListCommand::):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the iterator ends at the start of that node. used to create the iterator.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous):
  • editing/VisiblePosition.h: Added a parameter to next/previous to prevent them from going outside the current editable region.
  • editing/htmlediting.cpp: (WebCore::highestAncestor): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::outermostEnclosingList): (WebCore::createListItemElement):
  • editing/htmlediting.h:
  • page/Frame.cpp: (WebCore::Frame::selectionListState): Added.
  • page/Frame.h:

WebKit:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

  • WebView/WebFrame.m: (-[WebFrame _findFrameWithSelection]): Removed an assertion that we only have one frame with a selection.
  • WebView/WebView.m: (-[WebView selectedFrame]): Ditto.
6:06 PM Changeset in webkit [14776] by thatcher
  • 2 edits
    2 adds in trunk/WebKitSite

Reviewed by Darin.

Include our own copies of the BSD and LGPL licenses.

  • coding/bsd-license.html: Added.
  • coding/lgpl-license.html: Added.
  • nav.inc: link to our copies of the licenses
3:10 PM Changeset in webkit [14775] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

  • fast/dom/setPrimitiveValue-expected.checksum: Added.
  • fast/dom/setPrimitiveValue-expected.png: Added.
  • fast/dom/setPrimitiveValue-expected.txt: Added.
  • fast/dom/setPrimitiveValue.html: Added.

WebCore:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)


Problem was the primitive value was getting reset to a generic state before the parameter
check that relies on that state.

Test: fast/dom/setPrimitiveValue.html

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): Move parameter checks ahead of call to cleanup().
2:38 PM Changeset in webkit [14774] by aliceli1
  • 4 adds in trunk/LayoutTests/fast/dom/Range

added tests for Range.isPointInRange and Range.comparePoint

2:35 PM Changeset in webkit [14773] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Justin.

  • fixed <rdar://problem/4578115> support Range.isPointInRange
  • fixed <rdar://problem/4578123> support Range.comparePoint
  • dom/Range.cpp: (WebCore::Range::isPointInRange): added implementation (WebCore::Range::comparePoint): added implementation
  • dom/Range.h: added prototypes
  • dom/Range.idl: added bindings
2:20 PM Changeset in webkit [14772] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebView.m

Build fix.

2:05 PM Changeset in webkit [14771] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Darin and John.

<rdar://problem/3600734> API: please add a way to turn vertical scrollbar
always on (for Mail, to avoid reflow when typing)

Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView.
Locking the scroll mode prevents WebCore from changing it as needed.
Also adds an SPI on WebView that will lock the "always on" mode
for each scroller.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setScrollingModesLocked:]): (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
  • WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
  • WebView/WebViewPrivate.h:
9:43 AM Changeset in webkit [14770] by darin
  • 6 edits in trunk

WebCore:

Reviewed by Justin.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Changed to call nodeInfoAtPoint directly. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly. Also added code to convert coordinates so it works for points that are in nodes in subframes.
  • page/Frame.cpp: (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection endpoints in another document. (WebCore::Frame::setSelection): Ditto.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Added. (-[WebHTMLView _isTopHTMLView]): Added. (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Forward to the top HTML view, so that only the top view ever starts a dragging operation. Change dragging code to not assume that the dragged node is in the current view's document. Added checks that the node is an element in a couple places and coordinate conversions. (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view. (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0, since we now use the dataSource field to get to the WebView. (-[NSArray removeMouseMovedObserver]): Added a comment. (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Forward to the top HTML view. (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view. (-[NSArray draggedImage:movedTo:]): Ditto. (-[NSArray draggedImage:endedAt:operation:]): Ditto. (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto. (-[NSArray _isMoveDrag]): Ditto. (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto. (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work with the appropriate bridge when receiving a drag. This fixes the problem where the top level frame got a selection intended for the inner frame; the source of the bug. (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates so this works properly when returning an element from an inner frame. (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that addMouseMovedObserver won't do anything if called when dataSource is nil. (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view.
  • WebView/WebView.m: (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field is now gone. (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the drag caret is now a page-level item. Later we'll move it to the page bridge. (-[WebView removeDragCaret]): Ditto.
9:36 AM Changeset in webkit [14769] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Added change log entry that I apparently forgot.

Jun 7, 2006:

9:04 PM Changeset in webkit [14768] by justing
  • 17 edits in trunk

LayoutTests:

Reviewed by levi

  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:

WebCore:

Reviewed by levi


Fixed some comments and removed an unused variable.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): Don't remove a br if it isn't at the start of a block, since it isn't really a "block placeholder".
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
  • editing/htmlediting.cpp:
6:43 PM Changeset in webkit [14767] by hyatt
  • 5 edits in trunk/WebKit

Add support for custom highlighting to WebKit.

Reviewed by justin

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _highlighterForType:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
6:41 PM Changeset in webkit [14766] by hyatt
  • 8 edits in trunk/WebCore

Add support for custom highlighting. This is all ifdefed to be Mac-only.

Reviewed by justin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::paintCustomHighlight):
  • bridge/mac/WebCoreFrameBridge.h:
  • platform/mac/ClipboardMac.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
6:25 PM Changeset in webkit [14765] by adele
  • 17 edits
    2 adds in trunk

WebCore:

Reviewed by Hyatt

Added support for cross-platform resize property.

  • platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we already cache this info when we handle mouse down and mouse up.
  • platform/mac/MouseEventMac.mm: ditto.
  • platform/win/TemporaryLinkStubs.cpp: ditto.
  • page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown.
  • page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method. (WebCore::FrameView::mousePressed): Added.
  • page/FrameView.h: Added mousePressed.
  • rendering/RenderTheme.h: Removed paintResizeControl. Since its not dependent on the theme, the layer can just paint this.
  • rendering/RenderTheme.cpp: ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage. (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage. (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one. (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image.
  • rendering/RenderLayer.h: Added m_resizeCornerImage. Important to have one per-layer for when we allow more customization.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Loads image resources.

WebKit:

Reviewed by Hyatt.

Added resources for missingImage and textAreaResizeCorner.

  • COM/WebKitDLL.cpp: (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data.
  • WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources.
  • WebKit.vcproj/WebKit.vcproj: Added pngs.
  • WebKit.vcproj/missingImage.png: Added.
  • WebKit.vcproj/resource.h: Added entries for pngs.
  • WebKit.vcproj/textAreaResizeCorner.png: Added.
5:18 PM Changeset in webkit [14764] by hyatt
  • 4 edits in trunk/WebKit

Add SPI for setting and removing custom highlighters.

Reviewed by Tim H

  • WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _setHighlighter:ofType:]): (-[WebHTMLView _removeHighlighterOfType:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
4:08 PM Changeset in webkit [14763] by hyatt
  • 7 edits in trunk/WebCore

Add support for a new property for custom highlighting. This patch just
adds support for the parsing of the property. It doesn't do anything yet.

Reviewed by beth

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/render_style.h: (WebCore::RenderStyle::highlight): (WebCore::RenderStyle::setHighlight): (WebCore::RenderStyle::initialHighlight):
3:59 PM Changeset in webkit [14762] by ggaren
  • 1 edit
    1 delete in trunk/JavaScriptCore

Removed API directory I prematurely/accidentally added.

  • API: Removed.
9:33 AM Changeset in webkit [14761] by darin
  • 2 edits
    4 adds in trunk

Fix suggested by Rob Buis. Reviewed by Darin.

Test: fast/css/font-shorthand-weight-only.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change made to fix bug 5564.
9:29 AM Changeset in webkit [14760] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, tweaked by Mitz.

  • fast/table/text-field-baseline-expected.checksum: Added.
  • fast/table/text-field-baseline-expected.png: Added.
  • fast/table/text-field-baseline-expected.txt: Added.
  • fast/table/text-field-baseline.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/table/text-field-baseline.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just use their baseline.
9:26 AM Changeset in webkit [14759] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added.
  • fast/block/float/nopaint-after-layer-destruction-expected.png: Added.
  • fast/block/float/nopaint-after-layer-destruction-expected.txt: Added.
  • fast/block/float/nopaint-after-layer-destruction.html: Added.

WebCore:

Reviewed by Hyatt (concept) and Darin (some coding details).

Pixel test: fast/block/float/nopaint-after-layer-destruction.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag in the block's FloatingObject for the given float and calls setChildNeedsLayout.
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::blockThatPaintsFloat): Added this helper function. (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float gains or loses its layer.

Jun 6, 2006:

8:14 PM Changeset in webkit [14758] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
Teach svn-create-patch to sort its output

  • Scripts/svn-create-patch: Clean up perl code. Sort patch output alphabetically by text files first, then by binary files.
8:13 PM Changeset in webkit [14757] by darin
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/containing-block-position-change-expected.checksum: Added.
  • fast/repaint/containing-block-position-change-expected.png: Added.
  • fast/repaint/containing-block-position-change-expected.txt: Added.
  • fast/repaint/containing-block-position-change.html: Added.

WebCore:

Reviewed by Hyatt.

Test (repaint): fast/repaint/containing-block-position-change.html

  • manual-tests/containing-block-position-chage.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from the RenderCanvas to RenderView rename. (WebCore::RenderBlock::removePositionedObject): Added a return immediately after removing the object. (WebCore::RenderBlock::removePositionedObjects): Added.
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned descendants from the positioned objects list of their current containing block when they are going to have a new one as a result of this block's position property changing.
  • rendering/RenderObject.h: (WebCore::RenderObject::removePositionedObjects):
8:12 PM Changeset in webkit [14756] by darin
  • 4 edits in trunk/LayoutTests
  • fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
  • fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
  • fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.
5:25 PM Changeset in webkit [14755] by thatcher
  • 1 copy in tags/WebCore-418.13/WebCore

Tag for WebCore 418.13 (part 2 of 2.)

5:25 PM Changeset in webkit [14754] by thatcher
  • 1 add in tags/WebCore-418.13

Tag for WebCore 418.13 (part 1 of 2.)

5:19 PM Changeset in webkit [14753] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:13 PM Changeset in webkit [14752] by ggaren
  • 5 edits in branches/Safari-2-0-branch/WebCore

Fix by Maciej, reviewed by Darin. I provided desk space.


Because the garbage collector suspends a thread while marking its stack,
mark methods must not call malloc, because they may end up stuck,
trying to acquire the malloc lock from a suspended thread.

The fix here is:
(1) Use a data member rather than a dictionary to track nodes that are
in the process of marking their subtrees.
(2) Avoid the case wheter calling getDOMNodeForDocument might allocate
the staticDOMNodesPerDocument dictionary.


  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument): (KJS::ScriptInterpreter::getDOMNodeForDocument):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
  • khtml/xml/dom_nodeimpl.h:
5:09 PM Changeset in webkit [14751] by justing
  • 86 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi

Added to demonstrate fixes:

  • editing/pasteboard/merge-after-delete-expected.checksum: Added.
  • editing/pasteboard/merge-after-delete-expected.png: Added.
  • editing/pasteboard/merge-after-delete-expected.txt: Added.
  • editing/pasteboard/merge-after-delete.html: Added.
  • editing/inserting/line-break-expected.checksum: Added.
  • editing/inserting/line-break-expected.png: Added.
  • editing/inserting/line-break-expected.txt: Added.
  • editing/inserting/line-break.html: Added.
  • editing/inserting/multiple-lines-selected-expected.checksum: Added.
  • editing/inserting/multiple-lines-selected-expected.png: Added.
  • editing/inserting/multiple-lines-selected-expected.txt: Added.
  • editing/inserting/multiple-lines-selected.html: Added.


Fixed:

  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.checksum:
  • editing/deleting/delete-4038408-fix-expected.png:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-4038408-fix.html:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-br-011-expected.checksum:
  • editing/deleting/delete-br-011-expected.png:
  • editing/deleting/delete-br-011-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-select-all-001-expected.checksum:
  • editing/deleting/delete-select-all-001-expected.png:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/execCommand/insertImage-expected.checksum:
  • editing/execCommand/insertImage-expected.png:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • editing/input/text-input-controller-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.checksum:
  • editing/unsupported-content/list-delete-002-expected.png:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.checksum:
  • editing/unsupported-content/table-delete-001-expected.png:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • fast/text/attributed-substring-from-range.html:

WebCore:

Reviewed by levi

  • dom/Node.cpp: (WebCore::Node::firstDescendant): Added.
  • dom/Node.h:
  • dom/Range.cpp: Added a constructor that takes in Positions. (WebCore::Range::Range):
  • dom/Range.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): Let this function insert children into empty containers. Calls canHaveChildrenForEditing. (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing. (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the replacement so that moveParagraph's callers have a valid destination after the move.
  • editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand, made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Removed m_startNode, used a local variable. (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion. (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up front and keep track of it as nodes and text are removed. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode. (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand. Update m_endingPosition as we remove nodes. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Update m_endingPosition as we delete text. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block. Cleaned up. (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph clobbers the old one. (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after deletion. Make the placeholder decision before we do special element expansion.
  • editing/DeleteSelectionCommand.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned up the code.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do a merge (added a testcase).
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto. Merge even when the incoming fragment has interchange newlines (added a testcase). Merge when the selection being pasted into starts at the start of a block because not doing so would leave one or more hanging empty blocks. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires a selection, and a selection can't be created until whitespace has been rebalanced.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added.
  • editing/htmlediting.h:
5:03 PM Changeset in webkit [14750] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4570475> Dashboard regions do not scale for
non-1.0 scale factors.

No test cases added since this only affects non-1.0 resolution
scale factors.

  • platform/FloatRect.cpp: (WebCore::FloatRect::scale): Added new function that scales a rect's origin and size by a given factor.
  • platform/FloatRect.h:
  • platform/IntRect.cpp: (WebCore::IntRect::scale): Same as above.
  • platform/IntRect.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addDashboardRegions): After the bounds and clip rects on the Dashboard region have been calculated, get the user space scale factor, and if it is not 1.0, scale the rects.
4:12 PM Changeset in webkit [14749] by brmorris
  • 4 edits in S60/trunk

2006-06-06 Bradley <​bradley.morrison@nokia.com>

Reviewed by dacarson


  • WebKit\group\icons.mk


Added tabs back to icons.mk


  • JavaScriptCore\group\Bwinscw\JAVASCRIPTCOREU.DEF
  • WebCore\BWINS\WEBCOREU.DEF


Regenerated def files

3:58 PM Changeset in webkit [14748] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.


  • fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at ​http://www.apple.com/ (RenderObject::repaint(bool))


This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
it to the surface.

  • dom/Document.h: Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained
  • dom/Document.cpp: (WebCore::Document::removeMarkers): Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker removed. (WebCore::Document::repaintMarkers): Add a .get() to compensate for using RefPtr.
3:28 PM Changeset in webkit [14747] by adele
  • 2 edits in trunk/WebKit

Reviewed by Justin.

  • COM/WebView.cpp: (WebView::keyPress): Added case for VK_RETURN.
1:28 PM Changeset in webkit [14746] by brmorris
  • 2 edits in S60/trunk

2006-06-06 Sachin <​sachin.padma@nokia.com>

Reviewed by Zalan/Bradley


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9332


  • WebKit\group\icons.mk


Search for GCCE in $(PLATFORM), not ARMV5.

12:10 PM Changeset in webkit [14745] by brmorris
  • 5 edits in S60/trunk

2006-06-06 Sachin <​sachin.padma@nokia.com>

Reviewed by Zalan/Bradley


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9332


  • WebKit\group\icons.mk
  • WebKit\group\webkit.mmp
  • S60WebUi\WebUi\group\WebUi.mmp


Remove relative include paths for data_caging_paths.hrh,
rely on include path instead.


  • S60Internals\S60Headers.zip


Moved data_caging_paths.hrh out of oem to \epoc32\include.

11:26 AM Changeset in webkit [14744] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size


  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): If we're the document element, and in strict mode, return the visible size of the frame.


LayoutTests:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size

  • fast/dom/client-width-height-expected.txt: Added.
  • fast/dom/client-width-height.html: Added.
10:55 AM Changeset in webkit [14743] by andersca
  • 7 edits in trunk

WebCore:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge containsPlugins]):
  • page/Frame.cpp: (WebCore::Frame::containsPlugins):
  • page/Frame.h: Add containsPlugins function which returns whether a frame contains plugins or not.

WebKit:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Don't traverse the view hierarchy looking for plugin views. Instead, just ask the frame whether it contains any plugins.

Jun 5, 2006:

10:59 PM Changeset in webkit [14742] by ggaren
  • 2 edits
    1 add in trunk/JavaScriptCore

Reviewed and landed by Geoff.

  • fix a regression in ecma_3/String/regress-104375.js
  • kjs/string_object.cpp: (substituteBackreferences): If a 2-digit back reference is out of range, parse it as a 1-digit reference (followed by the other digit). This matches Firefox's behavior.
8:52 PM Changeset in webkit [14741] by sfalken
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

2006-06-06 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::roundToDevicePixels):
8:13 PM Changeset in webkit [14740] by ddkilzer
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by mjs.

testcases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode

  • fast/css/font_property_compatibility-expected.checksum: Added.
  • fast/css/font_property_compatibility-expected.png: Added.
  • fast/css/font_property_compatibility-expected.txt: Added.
  • fast/css/font_property_compatibility.html: Added.
  • fast/css/font_property_normal-expected.checksum: Added.
  • fast/css/font_property_normal-expected.png: Added.
  • fast/css/font_property_normal-expected.txt: Added.
  • fast/css/font_property_normal.html: Added.

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode

When not in strict mode accept font property specifications
lacking a font family part, like WinIE does.

  • css/cssparser.cpp: (WebCore::CSSParser::parseFont):
7:27 PM Changeset in webkit [14739] by bdakin
  • 10 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4567520> Pixel cracks in weather widget at
1.83 scaling

To prevent pixel cracks at non-integral scaling factors, before we
call into CG to draw an image, we have to convert the rect to
device space, round the origin and size to integers in device
space, and convert back to user space.


No test cases added since this only affects non-1.0 resolution
scale factors.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects.
  • html/CanvasPattern.cpp: (WebCore::patternCallback): Call roundToDevicePixels()
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects and call roundToDevicePixels()
  • html/CanvasRenderingContext2D.h: drawImage() now takes FloatRects.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Call roundToDevicePixels()
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::debugDumpCGImageToFile): Same as above.
  • platform/GraphicsContext.h:
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Takes care of converting between coordinate spaces and rounding. (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/ImageMac.mm: Call roundToDevicePixels() (WebCore::Image::draw): Same as above. (WebCore::drawPattern): Same as above.
6:51 PM Changeset in webkit [14738] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by ggaren.

  • fast/dom/global-constructors-expected.txt: Fixed test results.
5:23 PM Changeset in webkit [14737] by hyatt
  • 1 edit in trunk/WebKit/COM/WebView.cpp

Fix for perf regression with single-processor windows machines on ibench.

3:12 PM Changeset in webkit [14736] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed By Maciej.
Darin already reviewed this change on the branch. See <rdar://problem/4317701>.


  • Fixed <rdar://problem/4291345> PCRE overflow in Safari JavaScriptCore

No test case because there's no behavior change.


  • pcre/pcre_compile.c: (read_repeat_counts): Check for integer overflow / out of bounds
10:15 AM Changeset in webkit [14735] by ggaren
  • 12 edits
    2 adds
    2 deletes in trunk

LayoutTests:

  • Merged test-prototypes.html into global-constructors.html
  • Added prototypes.html, which tests for some missing prototypes in DOM objects


  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html:
  • fast/dom/prototypes-expected.txt: Added.
  • fast/dom/prototypes.html: Added.
  • fast/dom/test-prototypes-expected.txt: Removed.
  • fast/dom/test-prototypes.html: Removed.
  • fast/dom/undetectable-document-all-expected.txt: Updated to reflect change from "HTMLCollection" to "Collection"

WebCore:

Reviewed by Darin.

  • Added the built-in object prototype to DOM objects that were missing it so that primitive operations like == work on them.


  • Removed dead EventConstructor class (it's autogenerated now)


  • Changed HTML collections to describe themselves as "[object Collection]", to match IE.


  • Made DOMCSSRule constructor private because JSCSSRule is the class to use.


  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRule::DOMCSSRule): (KJS::DOMCSSValue::DOMCSSValue): (KJS::toJS): (KJS::DOMRGBColor::DOMRGBColor): (KJS::getDOMRGBColor): (KJS::DOMRect::DOMRect):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNodeList::DOMNodeList): (KJS::DOMExceptionConstructor::DOMExceptionConstructor): (KJS::DOMExceptionConstructor::getOwnPropertySlot): (KJS::): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
  • bindings/js/kjs_dom.h: (KJS::DOMNamedNodesCollection::classInfo):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp: (KJS::):
9:37 AM Changeset in webkit [14734] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by aliu.

  • Changed CString length from int to size_t. We sould probably do this for UString, too. (Darin, if you're reading this: Maciej said so.)


  • kjs/function.cpp: (KJS::encode):
  • kjs/ustring.cpp: (KJS::CString::CString): (KJS::operator==):
  • kjs/ustring.h: (KJS::CString::size):

Jun 4, 2006:

10:20 PM Changeset in webkit [14733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: Added include of <wtf/MathExtras.h>. (WebCore::floatFeature): Remove WIN32 ifdef around isnan. (WebCore::toJS): Add null checks.
9:15 PM Changeset in webkit [14732] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/loader/link-no-URL.html: Added.
  • fast/loader/link-no-URL-expected.txt: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/link-no-URL.html

  • loader/Cache.h:
  • loader/Cache.cpp: (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL from the cached object itself. Callers were passing in the wrong URL. When it was a null string, it caused the crash mentioned above. But in other cases it may have caused some other minor problems as well. Added an assert to catch cases where the URL is null (should never happen). (WebCore::Cache::requestImage): Changed call site to not pass URL. (WebCore::Cache::requestStyleSheet): Ditto. (WebCore::Cache::requestScript): Ditto. (WebCore::Cache::requestXSLStyleSheet): Ditto. (WebCore::Cache::requestXBLDocument): Ditto.
8:09 PM Changeset in webkit [14731] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • kjs/value.h: Removed redundant declarations
4:05 PM Changeset in webkit [14730] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • platform/mac/WebCoreTextField.mm: (inputElement): Added. Helper function to get the Objective-C wrapper for an input element associated with a QTextEdit. Returns nil if the element is not an input element. The bug was caused by passing a non-input element to the delegate methods. (-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement and don't make the delegate call at all if there is none. This happens only with isindex elements; it's not important to have auto-fill work with those. (-[KWQTextFieldController controlTextDidEndEditing:]): Ditto. (-[KWQTextFieldController controlTextDidChange:]): Ditto. (-[KWQTextFieldController control:textShouldEndEditing:]): Ditto. (-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto. (-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.
4:03 PM Changeset in webkit [14729] by darin
  • 36 edits in trunk/WebCore

Reviewed by Anders.

  • fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8995 memory leak in XPath code -- seen in layout tests
  • fixed malloc error on exit due to SVGDOMImplementation destructor
  • attempted to fix the no-XPATH_SUPPORT build by adding an #if
  • changed around includes and header-file formatting in XPath code
  • bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when generating the bindings for XPathNSResolver.
  • dom/DOMImplementation.h: Added a virtual destructor for the benefit of SVGDOMImplementation.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.
  • ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code. (SVGDOMImplementation::createDocument): Remove a reference to KDOMView.
  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of reference count churn. (WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code relies on it being 0 when the function succeeds.
  • xpath/XPathResult.cpp: (WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed unneeded target node data member. (WebCore::XPathResult::XPathResult): Updated for enum name changes and InvalidatingEventListener name change. Added an assertion.
  • xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter for createFunction to be a String instead of char*.
  • xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all the Interval functions inline. (WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round(). (WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables. Use equalIgnoringCase() instead of calling lower() on two strings. (WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to this function. Also removed a duplicate entry for the "last" function. (WebCore::XPath::createFunction): Changed from a member function to a separate function. Also changed so that if the args are not used in the function they are deleted. This was one of the sources of the storage leaks.
  • xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed tokens that were declared as <str> but weren't actually using the string to be declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of unregisterString, unregisterPredicateVector, and unregisterExpressionVector to call delete functions instead that both unregister and delete. Change call sites for createFunction to just use the String, removing the deprecatedString().latin1() call that is no longer needed. Added a call to unregisterParseNode that was missing in the "FilterExpr DescendantOrSelf RelativeLocationPath" production.
  • xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode, and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private part of the Parser class last. Moved a number of private things inside the cpp file.
  • xpath/impl/XPathParser.cpp: (WebCore::XPath::charCat): Made this a separate function, instead of a static member. (WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function, allowing use of a map instead of a map pointer. (WebCore::XPath::isNodeTypeName): Ditto. (WebCore::XPath::Parser::isOperatorContext): Made this const. (WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this. By using the actual types, we can safely use overload instead. (WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid(). (WebCore::XPath::Parser::lexNumber): Ditto. (WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite confusing and is also a bit more explicit. (WebCore::XPath::Parser::lexQName): Ditto. (WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and to remove some unneeded else statements. (WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID to decide what the type is. This matches what the grammar expects, and removes the need for the token object to track which part of the value is good and the need to reserve 0 to have a special meaning. (WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the expressions in the predicate and expression vectors. Before, we were only deleting the vectors. This was one of the sources of the storage leaks. (WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete the vector. However this does not delete the predicates in the vector. (WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete the vector. However this does not delete the expressions in the vector. (WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.
  • xpath/impl/XPathPredicate.h:
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and renamed to "opcode" instead of "opCode". (WebCore::XPath::NumericOp::doEvaluate): More of the same. (WebCore::XPath::EqTestOp::EqTestOp): Ditto. (WebCore::XPath::EqTestOp::doEvaluate): Ditto. (WebCore::XPath::LogicalOp::LogicalOp): Ditto. (WebCore::XPath::LogicalOp::shortCircuitOn): Ditto. (WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".
  • xpath/impl/XPathStep.h:
  • xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString function and default constructor.
  • xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix, instead of the underscore suffix used before on NodeVector and String.
  • xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.
  • xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate): Use a reference instead of a pointer.
  • xpath/XPathEvaluator.cpp:
  • xpath/XPathEvaluator.h:
  • xpath/XPathExpression.h:
  • xpath/XPathNSResolver.cpp:
  • xpath/XPathNSResolver.h:
  • xpath/XPathNamespace.cpp:
  • xpath/XPathNamespace.h:
  • xpath/XPathResult.h:
  • xpath/impl/XPathExpressionNode.cpp:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathPath.cpp:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathUtil.cpp:
  • xpath/impl/XPathUtil.h:
  • xpath/impl/XPathVariableReference.h: Reformatted and changed includes around; no substantive changes.
3:51 PM Changeset in webkit [14728] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • changed deleteAllValues so it can work on "const" collections Deleting the values affects the values, not the pointers in the collection, so it's legitimate to do it to a const collection, and a case of that actually came up in the XPath code.
  • wtf/HashMap.h: (WTF::deleteAllPairSeconds): Use const iterators. (WTF::deleteAllValues): Take const HashMap reference as a parameter.
  • wtf/HashSet.h: (WTF::deleteAllValues): Take const HashSet reference as a parameter, and use const iterators.
  • wtf/Vector.h: (WTF::deleteAllValues): Take const Vector reference as a parameter.
  • added more functions that are present in <math.h> on some platforms, but not on others; moved here from various files in WebCore
  • wtf/MathExtras.h: (isinf): Added. (isnan): Added. (lround): Added. (lroundf): Tweaked. (round): Added. (roundf): Tweaked. (signbit): Added.
3:41 PM Changeset in webkit [14727] by ddkilzer
  • 4 edits
    32 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl.html: Added.
  • fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-short-rtl.html: Added.

WebCore:

Reviewed by hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
2:41 PM Changeset in webkit [14726] by brmorris
  • 3 edits in S60/trunk

2006-06-04 Bradley <​bradley.morrison@nokia.com>

Reviewed by nobody (oops!)


Webkit.rsg gets processed before webkit.mmp. Fix for nonfatal:


No rule to make target `\EPOC32\INCLUDE\Webkit.rsg'

2:07 PM Changeset in webkit [14725] by brmorris
  • 22 edits
    17 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserCore (part 3 of 3).

2:04 PM Changeset in webkit [14724] by brmorris
  • 19 edits
    15 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / Plugin and BrowserView (part 2.8 of 3).

1:58 PM Changeset in webkit [14723] by brmorris
  • 46 edits
    11 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.6 of 3).

1:54 PM Changeset in webkit [14722] by brmorris
  • 11 edits
    1 add in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.2 of 3).

1:37 PM Changeset in webkit [14721] by ddkilzer
  • 3 edits in trunk/WebKitSite

WebKitSite:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
JavaScript error when loading WebKit blog page

  • blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript. Synced with nav.inc.
  • nav.inc: Removed evil tabs--whitespace change only.
1:12 PM Changeset in webkit [14720] by brmorris
  • 77 edits in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
Reindeer UI and WebCore (part 2 of 3).

1:05 PM Changeset in webkit [14719] by brmorris
  • 19 edits
    2 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
JavaScriptCore, MemoryManager and S60Internals (part 1 of 3).

11:52 AM Changeset in webkit [14718] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
Teach svn-create-patch and friends to work with binary files

  • Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
  • Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
  • Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.
1:08 AM Changeset in webkit [14717] by andersca
  • 11 edits
    3 adds in trunk

WebCore:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements


  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Pass the resolver to the parser.


  • xpath/XPathResult.cpp: (WebCore::XPathResult::iterateNext): Fix off-by-one error.


  • xpath/impl/XPathExpressionNode.h: (WebCore::XPath::EvaluationContext::EvaluationContext): Get rid of the resolver in the evaluation context.


  • xpath/impl/XPathGrammar.y: Fetch the resolver from the parser. Only return the local name.


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
  • xpath/impl/XPathParser.h: (WebCore::XPath::Parser::resolver): Update to hold the resolver.


  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::Step): If the parser has stored a namespace URI, set it.


(WebCore::XPath::Step::nodeTestMatches):
Check namespace URIs.


  • xpath/impl/XPathStep.h: Add m_namespaceURI.

LayoutTests:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements

  • fast/xpath: Added.
  • fast/xpath/xpath-namespaces-expected.txt: Added.
  • fast/xpath/xpath-namespaces.html: Added.

Jun 3, 2006:

9:33 PM Changeset in webkit [14716] by ddkilzer
  • 1 edit
    1 add in trunk/LayoutTests

LayoutTests:

Reviewed by Eric.

Added missing pixel test output:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
3:23 PM Changeset in webkit [14715] by ddkilzer
  • 9 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

  • fast/replaced/applet-rendering-java-disabled.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.png: Added.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.

WebCore:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

Test: fast/replaced/applet-rendering-java-disabled.html

Match WinIE, render applet content inline when java is
disabled.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • rendering/RenderEmptyApplet.cpp: Removed.
  • rendering/RenderEmptyApplet.h: Removed.
1:40 PM Changeset in webkit [14714] by thatcher
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet count correct.
1:38 PM Changeset in webkit [14713] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
Performance improvement for svn-create-patch

  • Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.
1:03 PM Changeset in webkit [14712] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • platform/Widget.h: Moved scaleFactor function out of Apple-specific section of the header into the common part.
11:37 AM Changeset in webkit [14711] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4537274> HiDPI: <canvas> needs to apply a
scale. <canvas> needs to scale itself along with whatever scale
factor is set on the window.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext): Get the scale factor and use it to create a larger buffer and to scale the CGContext.
  • platform/Widget.h: Provide a new function that returns the user space scale factor.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::scaleFactor): Get the scale factor from the window and return it.
  • platform/win/WidgetWin.cpp: (WebCore::Widget::scaleFactor): Just return 1.0f for now.
10:59 AM Changeset in webkit [14710] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKit:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
Teach svn-apply and svn-unapply to patch ChangeLogs cleanly

  • Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
  • Scripts/svn-unapply: Ditto. Also simplified reversing a deletion.
12:16 AM Changeset in webkit [14709] by sfalken
  • 1 delete in trunk/WebKitWin

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Removed unused code.

12:15 AM Changeset in webkit [14708] by sfalken
  • 5 edits in trunk/WebKitTools

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Switch Spinneret to new hosting mechanism

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::updateAddressBar): (SpinneretWebHost::QueryInterface): (SpinneretWebHost::AddRef): (SpinneretWebHost::Release): (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc): (About): (loadURL):
  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): (SpinneretWebHost::didFailProvisionalLoadWithError): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didReceiveTitle): (SpinneretWebHost::didReceiveIcon): (SpinneretWebHost::didFinishLoadForFrame): (SpinneretWebHost::didFailLoadWithError): (SpinneretWebHost::didChangeLocationWithinPageForFrame): (SpinneretWebHost::willPerformClientRedirectToURL): (SpinneretWebHost::didCancelClientRedirectForFrame): (SpinneretWebHost::willCloseFrame): (SpinneretWebHost::windowScriptObjectAvailable):
  • Spinneret/Spinneret/Spinneret.vcproj:
12:13 AM Changeset in webkit [14707] by sfalken
  • 2 edits in trunk/WebKit

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Add implementation of loadHTMLString for Spinneret

  • COM/WebFrame.cpp: (WebFrame::loadHTMLString):
12:10 AM Changeset in webkit [14706] by sfalken
  • 2 edits in trunk/WebCore

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.

Don't send empty referrers. Fixes image load fail on Spinneret default content.

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):
Note: See TracTimeline for information about the timeline view.