Timeline
Aug 3, 2006:
- 10:41 PM Changeset in webkit [15795] by
-
- 2 edits in trunk/WebCore
Minor tweak to earlier patch. Use containsFloats instad.
- 10:35 PM Changeset in webkit [15794] by
-
- 3 edits2 moves3 adds6 deletes in trunk/WebKit
Reviewed by Darin.
- moved all loader code that is slated to be moved down to WebCore to a new Loader directory
(next step is to remove dependencies on the rest of WebKit from this directory)
- Loader/WebNetscapePlugInStreamLoader.h: Added.
- Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m (-[WebNetscapePlugInStreamLoader initWithStream:view:]): (-[WebNetscapePlugInStreamLoader isDone]): (-[WebNetscapePlugInStreamLoader releaseResources]): (-[WebNetscapePlugInStreamLoader didReceiveResponse:]): (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
- Plugins/WebNetscapePluginStream.m:
- WebKit.xcodeproj/project.pbxproj:
- WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
- WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
- WebView/WebFrameLoader.h: Moved to Loader/
- WebView/WebFrameLoader.m: Moved to Loader/
- WebView/WebLoader.h: Moved to Loader/
- WebView/WebLoader.m: Moved to Loader/
- WebView/WebMainResourceLoader.h: Moved to Loader/
- WebView/WebMainResourceLoader.m: Moved to Loader/
- 7:08 PM Changeset in webkit [15793] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin Decker.
<rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]): Fixed color component swapping so that it works on both x86 and PPC. See comments.
- 6:38 PM Changeset in webkit [15792] by
-
- 4 adds in trunk/LayoutTests/fast/block/float
- 6:35 PM Changeset in webkit [15791] by
-
- 2 edits in trunk/WebCore
Fix for bug 10229, don't bother trying to clear when no floats are
present. I suspect there's still a bug in the math that follows, but
this fix is safer in that it just does the obvious thing (and doesn't
compute any clearance if no floats are even around).
Reviewed by maciej
- ChangeLog:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta):
- 5:42 PM Changeset in webkit [15790] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
- editing/style/non-inheritable-styles-expected.checksum: Added.
- editing/style/non-inheritable-styles-expected.png: Added.
- editing/style/non-inheritable-styles-expected.txt: Added.
- editing/style/non-inheritable-styles.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
Copy/Paste fidelity was bad.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
- editing/markup.cpp: (WebCore::startMarkup): We were not adding non-inheritable styles to the markup for an element unless they were in the elements inline style declaration.
- 5:37 PM Changeset in webkit [15789] by
-
- 1 edit in trunk/WebKit/ChangeLog
Cleaned up the ChangeLog from last checkin
- 5:00 PM Changeset in webkit [15788] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher's rubber stamp
Fixed Intel build break caused by weinig's -W change in r15781
- WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
- 3:58 PM Changeset in webkit [15787] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed problem that could cause assertion failures in Safari
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't allow a plugin to start new loads once its document is no longer the one actively loading.
- 3:48 PM Changeset in webkit [15786] by
-
- 3 edits in S60/trunk/WebKit
Rolling out r15783 which introduced a new, unwanted dependency. This patch needs to be re-thought.
- 3:35 PM Changeset in webkit [15785] by
-
- 2 edits in S60/trunk/JavaScriptCore
2006-08-03 bujtas <zbujtas@gmail.com>
Reviewed by Yongjun.
fix hashtable crash in case of oom
- kjs/identifier.cpp: (KJS::Identifier::rehash):
- 3:33 PM Changeset in webkit [15784] by
-
- 14 edits in trunk/WebKit
Reviewed by John.
- remove use of WebDataSource from WebLoader and subclasses, just have them talk to the WebFrameLoader instead.
For now this is done by forarding all the calls.
- Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
- Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
- WebCoreSupport/WebSubresourceLoader.h:
- WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader initWithLoader:frameLoader:]): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]): (-[WebSubresourceLoader receivedError:]): (-[WebSubresourceLoader signalFinish]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: (-[WebDataSource _updateLoading]): (-[WebDataSource textEncodingName]): (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
- WebView/WebFrameLoader.h:
- WebView/WebFrameLoader.m: (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader clearIconLoader]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _archivedSubresourceForURL:]): (-[WebFrameLoader _defersCallbacks]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader _addPlugInStreamLoader:]): (-[WebFrameLoader _removePlugInStreamLoader:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader _addSubresourceLoader:]): (-[WebFrameLoader _removeSubresourceLoader:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]): (-[WebFrameLoader _iconLoaderReceivedPageIcon:]): (-[WebFrameLoader _URL]):
- WebView/WebLoader.h:
- WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setFrameLoader:]): (-[NSURLProtocol frameLoader]): (-[NSURLProtocol willSendRequest:redirectResponse:]): (-[NSURLProtocol didReceiveAuthenticationChallenge:]): (-[NSURLProtocol didCancelAuthenticationChallenge:]): (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:]): (-[NSURLProtocol signalFinish]): (-[NSURLProtocol didFailWithError:]): (-[NSURLProtocol willCacheResponse:]): (-[NSURLProtocol cancelWithError:]):
- WebView/WebMainResourceLoader.h:
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithFrameLoader:]): (-[WebMainResourceLoader receivedError:]): (-[WebMainResourceLoader cancelWithError:]): (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]): (-[WebMainResourceLoader addData:]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader continueAfterContentPolicy:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader didReceiveResponse:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:]): (-[WebMainResourceLoader didFinishLoading]): (-[WebMainResourceLoader didFailWithError:]): (-[WebMainResourceLoader loadWithRequestNow:]):
- 3:12 PM Changeset in webkit [15783] by
-
- 3 edits in S60/trunk/WebKit
2006-08-03 spaltis
Reviewed Yongjun.
Unfinished download should be visible in the download list,
before connection is established.
- ResourceLoader/inc/HttpDownloadObserver.h:
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::~CHttpDownloadObserver): (CHttpDownloadObserver::ConstructL): (CHttpDownloadObserver::DlMgrInitCB): (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrEventL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
- 3:03 PM Changeset in webkit [15782] by
-
- 3 edits in S60/trunk/WebKit
2006-08-03 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
The browser engine opens same database 9 times in CFaviconHandler during startup
CFaviconHandler has only one instance. Open the database in ConstructL
and close it when the object is deleted.
- BrowserCore/Misc/inc/Favicon.h:
- BrowserCore/Misc/src/Favicon.cpp: (CFaviconHandler::NewL): (CFaviconHandler::CFaviconHandler): (CFaviconHandler::ConstructL): (CFaviconHandler::~CFaviconHandler): (CFaviconHandler::SetFaviconL): (CFaviconHandler::InsertFaviconL): (CFaviconHandler::GetFaviconL): (CFaviconHandler::OpenDatabaseL): (CFaviconHandler::DeleteFaviconL): (CFaviconHandler::UpdateTimeL): (CFaviconHandler::CreateDatabaseL): (CFaviconHandler::ExtractDomainL):
- 2:55 PM Changeset in webkit [15781] by
-
- 94 edits in trunk
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Added #define YYMAXDEPTH 10000 in kjs/grammar.y to fix a warning from within Bison.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::getSlot): (JavaJSObject::setSlot):
- bindings/npapi.h:
- bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
- bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
- bindings/objc/objc_runtime.mm: (ObjcMethod::getMethodSignature): (ObjcField::name): (ObjcField::type):
- kjs/grammar.y:
- kjs/identifier.h:
JavaScriptGlue:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN) (and in one instance in config.h with #if !COMPILER(MSVC))
- Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y to fix a warning from within Bison.
- Cleaned up style a little in surrounding code.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
- config.h:
- css/CSSGrammar.y:
- css/MediaFeatureNames.cpp:
- css/MediaFeatureNames.h:
- css/cssparser.cpp:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
- dom/Element.cpp: (WebCore::Element::attach):
- dom/Element.h:
- dom/EventNames.cpp:
- dom/EventNames.h:
- dom/NamedAttrMap.h:
- dom/Position.cpp:
- dom/QualifiedName.cpp:
- dom/QualifiedName.h:
- dom/Range.h:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::error):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::notifyFinished):
- kcanvas/device/quartz/KCanvasFilterQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/css/SVGRenderStyleDefs.h:
- ksvg2/scripts/make_names.pl:
- loader/CachedResource.h:
- loader/LoaderFunctions.h:
- loader/loader.h:
- page/Frame.cpp:
- page/FrameTree.cpp:
- page/FrameView.cpp: (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::layoutTimerFired): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::unscheduleRelayout):
- platform/AtomicString.cpp:
- platform/AtomicString.h:
- platform/Cursor.h:
- platform/DeprecatedArray.h:
- platform/DeprecatedString.cpp: (WebCore::allocateHandle): (WebCore::initializeHandleNodeBlock): (WebCore::freeHandle):
- platform/FloatPoint.h:
- platform/FloatRect.h:
- platform/FloatSize.h:
- platform/GraphicsContext.h:
- platform/Image.h:
- platform/IntPoint.h:
- platform/IntRect.h: (WebCore::IntRect::inflateX): (WebCore::IntRect::inflateY):
- platform/IntSize.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformString.h:
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/ScrollView.h:
- platform/StaticConstructors.h:
- platform/StreamingTextDecoderICU.cpp: (WebCore::StreamingTextDecoderICU::convert):
- platform/StringImpl.h:
- platform/Widget.h:
- platform/mac/BlockExceptions.mm:
- platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]):
- platform/mac/FloatPointMac.mm:
- platform/mac/FloatRectMac.mm:
- platform/mac/FloatSizeMac.mm:
- platform/mac/FontMac.mm:
- platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
- platform/mac/IntPointMac.mm:
- platform/mac/IntRectMac.mm:
- platform/mac/IntSizeMac.mm:
- platform/mac/WebCoreSystemInterface.h:
- rendering/RenderBlock.h:
- rendering/RenderTableCell.h:
- rendering/bidi.cpp: (WebCore::appendRun): (WebCore::RenderBlock::layoutInlineChildren):
- xml/XSLTProcessor.cpp: (WebCore::parseErrorFunc):
- xpath/impl/XPathGrammar.y:
WebKit:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Carbon/CarbonUtils.m:
- Carbon/CarbonWindowAdapter.m:
- Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]):
- Carbon/HIWebView.m: (HIWebViewEventHandler):
- Misc/WebFileDatabase.m: (UniqueFilePathForKey):
- Misc/WebNSWindowExtras.m: (swizzleInstanceMethod):
- Misc/WebTypesInternal.h:
- Plugins/WebNetscapeDeprecatedFunctions.c:
- Plugins/WebNetscapeDeprecatedFunctions.h:
- Plugins/WebNetscapePluginPackage.h:
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
- WebKit.xcodeproj/project.pbxproj:
- 1:25 PM Changeset in webkit [15780] by
-
- 3 edits in trunk/LayoutTests
Reviewed by darin
- fast/forms/plaintext-mode-1-expected.txt:
- fast/forms/plaintext-mode-1.html:
- 1:13 PM Changeset in webkit [15779] by
-
- 4 edits in S60/trunk/WebKit
2006-08-03 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan.
Fix pending resource loading.
- BrowserView/inc/WebKitLoader.h:
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CreateAsyncCancelHandleL):
- BrowserView/src/webkitbridge.cpp: (CWebKitBridge::StartLoadingResource):
- 12:51 PM Changeset in webkit [15778] by
-
- 4 edits in S60/trunk/WebKit
2006-08-02 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
The SetClientResolvesUrl setting was not set when pages were loaded.
If the ResolveLinkL callback failed to handle the link the transaction was canceled
before it was added to the queue and a crash would occur. I delay the cancel by
putting it into a callback.
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
- ResourceLoader/inc/BufferTransaction.h:
- ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
- 12:33 PM Changeset in webkit [15777] by
-
- 2 edits in trunk/JavaScriptCore
2006-08-03 Anders Carlsson <acarlsson@apple.com>
Reviewed by John Sullivan.
- wtf/HashSet.h: (WTF::::operator): Return *this in operator=
- 12:29 PM Changeset in webkit [15776] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej and Beth.
Fix use-after-dispose heap corruption bug.
- rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not destroying the document
- 12:19 PM Changeset in webkit [15775] by
-
- 2 edits in S60/trunk/WebKit
2006-08-03 vbradley <vincent.bradley@nokia.com>
Reviewed by Yongjun & Sriram
Changes the cursor to correct image when loading a new page and was
was displaying the waiting cursor.
- BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate): (CWebKitCursor::SetWaitCursor):
- 12:18 PM Changeset in webkit [15774] by
-
- 6 edits in trunk
Reviewed by Anders.
- Fixed Windows build
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- wtf/MathExtras.h: Implement inline versions of these functions (nextafter): (nextafterf):
WebCore:
Reviewed by Anders.
- Fixed Windows build.
- platform/Color.cpp: (WebCore::makeRGBAFromHSLA): Whitespace change
- platform/win/TemporaryLinkStubs.cpp: Add new method stubs (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (ScrollBar::scroll): (ScrollBar::setValue):
- 11:48 AM Changeset in webkit [15773] by
-
- 2 edits in S60/trunk/WebKit
2006-08-03 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
FocusElementType is incosistent in tabbed view.
Resolved by setting the current focus element type prior to
calling TabbedNavigation in CKeyEventHandler::NavigateWithCursor which
will reset the focus element type.
- BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor):
- 11:04 AM Changeset in webkit [15772] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
- editing/execCommand/hilitecolor-expected.checksum: Added.
- editing/execCommand/hilitecolor-expected.png: Added.
- editing/execCommand/hilitecolor-expected.txt: Added.
- editing/execCommand/hilitecolor.html: Added.
WebCore:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
- editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...). It's what GMail uses to implement text hiliting. It's just a synonym for BackColor.
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment a more appropriate place.
- 9:21 AM Changeset in webkit [15771] by
-
- 1 edit50 adds in S60/trunk/LayoutTests
2006-07-31 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
Adding new LayoutTest baselines.
- 9:18 AM Changeset in webkit [15770] by
-
- 2 edits in S60/trunk
2006-07-31 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
- runATF.bat: Generate and copy 'expected' if missing.
- 8:36 AM Changeset in webkit [15769] by
-
- 4 edits in trunk/WebKitTools
2006-08-03 Mark Rowe <opendarwin.org@bdash.net.nz>
Reviewed by Darin.
Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
http://bugzilla.opendarwin.org/show_bug.cgi?id=10224
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/LauncherInfo.plist:
2006-08-03 Mitz Pettel <opendarwin.org@mitzpettel.com>
- fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc] when a test performs an unsuccessful drag and drop operation.
- DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]): Added a call to -draggingExited: if the drag operation for the mouse release is NSDragOperationNone.
- 8:34 AM Changeset in webkit [15768] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Adele and Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10177 REGRESSION: Successfully dragging text into a disabled field
- fast/forms/textfield-drag-into-disabled-expected.checksum: Added.
- fast/forms/textfield-drag-into-disabled-expected.png: Added.
- fast/forms/textfield-drag-into-disabled-expected.txt: Added.
- fast/forms/textfield-drag-into-disabled.html: Added.
- fast/forms/input-disabled-color-expected.txt: Updated.
WebCore:
Reviewed by Adele and Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177 REGRESSION: Successfully dragging text into a disabled field
Test: fast/forms/textfield-drag-into-disabled.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify to read-only on the inner div if the control is disabled. (WebCore::RenderTextControl::updateFromElement): Ditto.
- 8:24 AM Changeset in webkit [15767] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10198 REGRESSION: WebKit r15750 crashes while loading anthem.com
- fast/overflow/generated-content-crash-expected.txt: Added.
- fast/overflow/generated-content-crash.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198 REGRESSION: WebKit r15750 crashes while loading anthem.com
Test: fast/overflow/generated-content-crash.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for the renderer's element. Generated content does not have an element and therefore does not need to maintain overflow status.
- 8:22 AM Changeset in webkit [15766] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Anders.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10202 REGRESSION: Repro crash when loading an empty image document
- fast/tokenizer/image-empty-crash-expected.txt: Added.
- fast/tokenizer/image-empty-crash.html: Added.
WebCore:
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202 REGRESSION: Repro crash when loading an empty image document
Test: fast/tokenizer/image-empty-crash.html
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement. (WebCore::ImageTokenizer::finish): Ditto.
- 8:21 AM Changeset in webkit [15765] by
-
- 6 edits in trunk/WebCore
Reviewed by Anders.
- clean up "flip"-related code a tiny bit
- platform/Screen.h: Removed redundant parameter names.
- platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one copy of the flipping code. (WebCore::flipScreenPoint): Fixed indentation.
- bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and simplified a bit.
- platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
- platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent): Removed unneeded local variable.
- 8:17 AM Changeset in webkit [15764] by
-
- 2 edits in trunk/WebKit
Reviewed by Eric Seidel.
- fix storage leak
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.
Aug 2, 2006:
- 11:08 PM Changeset in webkit [15763] by
-
- 2 edits in trunk/WebKit
Rubber stamped by Maciej.
Adding back resultsWithXpathQuery, removed by Darin's earlier change.
This function is called from ObjC, but not used from JavaScript.
- WebInspector/webInspector/inspector.js:
- 4:18 PM Changeset in webkit [15762] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9632
Do not change the file source when normalizing the line endings.
We use this file source to compare against new versions of the source
as it comes in, so we can skip re-syntax highlighting if they are the same.
The problem is apparent on yahoo.com since they have mixed line endings and
once we normalize them the source will always be different. This was
compounded by the fact that yahoo has around 40 inline scripts. Each
inline script causes us to check if the main document has more loaded,
that is when we compare the source strings. Since they are always different
we would syntax highlight yahoo.com 40 times! We do check source length before
doing a more expensive string comparison, but the lengths were the same.
- Drosera/debugger.js:
- 4:15 PM Changeset in webkit [15761] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
http://bugzilla.opendarwin.org/show_bug.cgi?id=10200
Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.
Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
where you call a function from the console and expect it to break on a breakpoint in them, but
this appears to never have worked even without this change. When that is figured out we can
reconsider a better solution to reentrancy. I have filed that as bug 10214.
I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
we don't use "onway void" as the return type for the callbacks. Note: using onway void for
the listener callbacks causes bad synchronization issues and obscure crashes.
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
- DefaultDelegates/WebScriptDebugServerPrivate.h:
- 3:59 PM Changeset in webkit [15760] by
-
- 4 edits in trunk/WebCore
Abstract RenderLayer scrollbar creation and destruction so that there
is a clean spot in which to drop in engine scrollbar stuff.
Reviewed by timo
- platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
- rendering/RenderLayer.h:
- 3:58 PM Changeset in webkit [15759] by
-
- 2 edits1 add in trunk/WebKitSite
Reviewed by TimO.
Tweaked the build instructions a bit.
- building/build.html:
- building/debug.png: Added.
- 3:47 PM RecentChanges created by
- 3:47 PM SandBox created by
- 3:47 PM TitleIndex created by
- 3:47 PM CamelCase created by
- 3:47 PM TracAccessibility created by
- 3:47 PM TracAdmin created by
- 3:47 PM TracBackup created by
- 3:47 PM TracBrowser created by
- 3:47 PM TracCgi created by
- 3:47 PM TracInstall created by
- 3:47 PM TracInterfaceCustomization created by
- 3:47 PM TracLinks created by
- 3:47 PM TracChangeset created by
- 3:47 PM TracEnvironment created by
- 3:47 PM TracFastCgi created by
- 3:47 PM TracGuide created by
- 3:47 PM TracRss created by
- 3:47 PM TracImport created by
- 3:47 PM TracIni created by
- 3:47 PM TracLogging created by
- 3:47 PM TracModPython created by
- 3:47 PM TracNotification created by
- 3:47 PM TracPermissions created by
- 3:47 PM TracPlugins created by
- 3:47 PM TracQuery created by
- 3:47 PM TracReports created by
- 3:47 PM TracRoadmap created by
- 3:47 PM TracSearch created by
- 3:47 PM TracStandalone created by
- 3:47 PM TracSupport created by
- 3:47 PM TracSyntaxColoring created by
- 3:47 PM TracTickets created by
- 3:47 PM WikiHtml created by
- 3:47 PM TracTicketsCustomFields created by
- 3:47 PM TracTimeline created by
- 3:47 PM TracUnicode created by
- 3:47 PM TracUpgrade created by
- 3:47 PM TracWiki created by
- 3:47 PM WikiDeletePage created by
- 3:47 PM WikiFormatting created by
- 3:47 PM WikiMacros created by
- 3:47 PM WikiPageNames created by
- 3:47 PM WikiProcessors created by
- 3:47 PM WikiRestructuredText created by
- 3:47 PM WikiRestructuredTextLinks created by
- 3:47 PM WikiStart created by
- 3:47 PM InterWiki edited by
- (diff)
- 3:47 PM TracFineGrainedPermissions created by
- 3:47 PM TracFastCgi edited by
- (diff)
- 3:47 PM TracEnvironment edited by
- (diff)
- 3:47 PM TracChangeset edited by
- (diff)
- 3:47 PM TracCgi edited by
- (diff)
- 3:47 PM InterTrac edited by
- (diff)
- 3:47 PM TracRevisionLog edited by
- (diff)
- 3:47 PM TracUpgrade edited by
- (diff)
- 3:47 PM TracUnicode edited by
- (diff)
- 3:47 PM TracTimeline edited by
- (diff)
- 3:47 PM TracTicketsCustomFields edited by
- (diff)
- 3:47 PM TracTickets edited by
- (diff)
- 3:47 PM WikiProcessors edited by
- (diff)
- 3:47 PM WikiMacros edited by
- (diff)
- 3:47 PM WikiFormatting edited by
- (diff)
- 3:47 PM WikiRestructuredTextLinks edited by
- (diff)
- 3:47 PM WikiRestructuredText edited by
- (diff)
- 3:47 PM WikiPageNames edited by
- (diff)
- 3:47 PM WikiHtml edited by
- (diff)
- 3:47 PM WikiDeletePage edited by
- (diff)
- 3:47 PM TracWorkflow created by
- 3:47 PM TracWiki edited by
- (diff)
- 3:47 PM TracSyntaxColoring edited by
- (diff)
- 3:47 PM TracSupport edited by
- (diff)
- 3:47 PM TracStandalone edited by
- (diff)
- 3:47 PM TracSearch edited by
- (diff)
- 3:47 PM TracRss edited by
- (diff)
- 3:47 PM TracRoadmap edited by
- (diff)
- 3:47 PM TracReports edited by
- (diff)
- 3:47 PM TracQuery edited by
- (diff)
- 3:47 PM TracPlugins edited by
- (diff)
- 3:47 PM TracPermissions edited by
- (diff)
- 3:47 PM TracNotification edited by
- (diff)
- 3:47 PM TracNavigation created by
- 3:47 PM TracModPython edited by
- (diff)
- 3:47 PM TracLogging edited by
- (diff)
- 3:47 PM TracLinks edited by
- (diff)
- 3:47 PM TracInterfaceCustomization edited by
- (diff)
- 3:47 PM TracInstall edited by
- (diff)
- 3:47 PM TracIni edited by
- (diff)
- 3:47 PM TracImport edited by
- (diff)
- 3:47 PM TracGuide edited by
- (diff)
- 3:47 PM TracBrowser edited by
- (diff)
- 3:47 PM TracBackup edited by
- (diff)
- 3:47 PM TracAdmin edited by
- (diff)
- 3:47 PM TracAccessibility edited by
- (diff)
- 3:47 PM TitleIndex edited by
- (diff)
- 3:47 PM RecentChanges edited by
- (diff)
- 3:47 PM PageTemplates created by
- 3:47 PM CamelCase edited by
- (diff)
- 1:32 PM Changeset in webkit [15758] by
-
- 3 edits4 adds4 deletes in trunk
Fix by Mitz Pettel, reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438 incorrect display of transparent 1x1 PNGs
Test: fast/replaced/image-solid-color-with-alpha.html
- platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): Changed to divide each color component by the alpha component. You need to do that since the bitmap context has premultiplied alpha but m_solidColor should be non-premultiplied.
- 1:26 PM Changeset in webkit [15757] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
- Fixed build
- kjs/date_object.cpp: (KJS::formatTime):
- 12:06 PM Changeset in webkit [15756] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
- add more assertions for safety
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Removed obsolete comment. (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called at a time when this data source is the one that might be loading for a frame. (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
- WebView/WebFrameLoader.m: (-[WebFrameLoader isLoadingPlugIns]): New helper method. (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them at stopLoading time.
- 11:35 AM Changeset in webkit [15755] by
-
- 2 edits in trunk/WebKitSite
- building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".
- 11:14 AM Changeset in webkit [15754] by
-
- 4 edits in trunk
WebCore:
Reviewed by Brady.
- Remove redundant #include
- loader/loader.cpp:
WebKit:
Reviewed by Brady.
- Rename TransferJob to ResourceLoader (this file was forgotten in an earlier change by Maciej)
- COM/WebView.cpp:
- 11:13 AM Changeset in webkit [15753] by
-
- 3 edits1 add in trunk/WebKitTools
Reviewed by Timothy.
Bug 9931: [Drosera] Needs a cool icon
http://bugzilla.opendarwin.org/show_bug.cgi?id=9931
- Drosera/Drosera.icns: Added.
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/Info.plist:
- 11:07 AM Changeset in webkit [15752] by
-
- 2 edits in S60/trunk/WebKit
2006-08-02 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun, landed by Bradley.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10194
Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
- 1:11 AM Changeset in webkit [15751] by
-
- 8 edits in trunk/WebKit
Reviewed by Adele.
- Change things around so WebFrameLoader tracks the main and provisional data source, as well as the frame load state, pulling much code out of WebFrame along the way.
The most significant aspects of this change are:
- management of WebDataSources and WebFrameState was moved into WebFrameLoader
- there is now just one WebFrameLoader shared between the primary and provisional data source
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
- WebView/WebFrame.m: (-[WebFramePrivate init]): (-[WebFramePrivate dealloc]): (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueAfterWillSubmitForm:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame stopLoading]):
- WebView/WebFrameInternal.h:
- WebView/WebFrameLoader.h:
- WebView/WebFrameLoader.m: (-[WebFrameLoader initWithWebFrame:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDataSource:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDataSource:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader state]): (+[WebFrameLoader timeOfLastCompletedLoad]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]):
- WebView/WebFramePrivate.h:
Aug 1, 2006:
- 4:06 PM Changeset in webkit [15750] by
-
- 4 edits in trunk/WebKit
Reviewed by John Sullivan.
<rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()
I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView setWindowIfNecessary]): ditto (-[WebBaseNetscapePluginView start]): It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg problems). Added a sanity-checking assertion. (-[WebBaseNetscapePluginView stop]): If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said plugin-function returns. (-[WebBaseNetscapePluginView pluginScriptableObject]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView willCallPlugInFunction]): Increment plug-in function call depth. (-[WebBaseNetscapePluginView didCallPlugInFunction]): Decrement plug-in function call depth. Stop if we're supposed to stop. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): ditto (-[WebBaseNetscapePluginView _printedPluginBitmap]): ditto
- Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
- 4:04 PM Changeset in webkit [15749] by
-
- 1 copy in S60/tags/s60-RnD-06wk31_rc1
Tagging S60 RnD w31 '06 release candidate 1
- 3:58 PM Changeset in webkit [15748] by
-
- 3 edits in S60/trunk/WebKit
2006-08-01 hongzhao <hong.a.zhao@nokia.com>
Reviewed by Yongjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10184
Sound continues after page closes in Bookmark view.
- Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::): Added EPluginInvisible
- Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): Sends message to Plugin notifier
- 3:53 PM Changeset in webkit [15747] by
-
- 2 edits in trunk/WebKit
- fix build after last change
- WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]):
- 3:43 PM Changeset in webkit [15746] by
-
- 6 edits in S60/trunk/WebKit
2006-07-31 vbradley <vincent.bradley@nokia.com>
Reviewed by Yongun & Sachin
Add changes to allow the user to send plugin content to viewer.
- BrowserControl/src/BrCtl.cpp:
- BrowserView/inc/PluginControl.h:
- BrowserView/src/PluginControl.cpp:
- Plugin/inc/PluginWin.h:
- Plugin/src/PluginWin.cpp:
- 3:08 PM Changeset in webkit [15745] by
-
- 5 edits in S60/trunk
2006-08-01 raalexan <rasvan.alexandrescu@nokia.com>
Reviewed by Sachin/Youngjun.
Horizontal scroll not working with WML pages.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10092
- BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::ResizeBrCtlView): Set the view rectangle in WML view.
- 3:05 PM Changeset in webkit [15744] by
-
- 2 edits in trunk/WebKit
Reviewed by Beth.
- revert part of my last fix that broke the Safari bookmarks view
- WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
- 1:20 PM Changeset in webkit [15743] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.
- Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView redeliverStream]): Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation, which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when the plug-in is destroyed.
- 1:17 PM Changeset in webkit [15742] by
-
- 2 edits in S60/trunk/WebKit
2006-07-28 zhalu <zhaosong.lu@nokia.com>
Reviewed by Youngjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10149
- BrowserView/src/WebKitView.cpp: (CWebKitView::ProgressAndImageDecodeComplete): Now calls ScheduleRepaint()
- 1:06 PM Changeset in webkit [15741] by
-
- 2 edits in S60/trunk/WebKit
2006-08-01 naguo <George.Guo@nokia.com>
Reviewed by Yongjun.
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::FindDownloadL): Make sure the download is not completed before start it
- 12:09 PM Changeset in webkit [15740] by
-
- 2 edits in S60/trunk/WebCore
2006-08-01 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10185
www.euromaster.fi crash due to memory corruption.
- kwq/KWQKURL.cpp: (KURL::KURL): free buffer (KURL::parse): free path_buffer not buffer
- 11:41 AM Changeset in webkit [15739] by
-
- 2 edits3 adds in trunk/WebKitSite
Reviewed by Beth.
- Added instructions for debugging in Xcode
- building/build-window.png: Added.
- building/build.html:
- building/custom-executable.png: Added.
- building/info-tab.png: Added.
- 11:38 AM Changeset in webkit [15738] by
-
- 2 edits in trunk/WebKit
Reviewed by Geoff.
- some refactoring in preparation for moving more stuff to WebFrameLoader.
- WebView/WebFrame.m: (-[WebFrame _clearDataSource]): (-[WebFrame _detachFromParent]): (-[WebFrame _commitProvisionalLoad]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _clearProvisionalLoad]): (-[WebFrame _markLoadComplete]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _startProvisionalLoad:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame stopLoading]):
- 11:03 AM Changeset in webkit [15737] by
-
- 5 edits in S60/trunk/WebKit
2006-08-01 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
Implemented MCoeForegroundObserver at CPluginWin to process
background/foreground events independently of changes in focus.
- Plugin/inc/PluginLoader.h:
- Plugin/inc/PluginSkin.h:
- Plugin/inc/PluginWin.h:
- Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::SetPluginFocusL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
- 10:57 AM Changeset in webkit [15736] by
-
- 4 edits in S60/trunk
2006-08-01 zhalu <zhaosong.lu@nokia.com>
Reviewed by Yongjun.
- BrowserCore/Formcontrols/src/FControlButtonSkin.cpp: (CFormButtonSkin::Draw): Now sets alpha
- 9:40 AM Changeset in webkit [15735] by
-
- 4 edits in trunk
LayoutTests:
- updated a test affected by changes to the DumpRenderTree tool to return a current mouse position
- fast/inline/dirtyLinesForInline-expected.txt: Updated.
WebKitTools:
- fix a bug in my recent change where the mouse position at the end of the last test would affect the results of the next test
- DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.
Jul 31, 2006:
- 11:15 PM Changeset in webkit [15734] by
-
- 12 edits in trunk
LayoutTests:
Reviewed by Darin.
- tests changed by http://bugzilla.opendarwin.org/show_bug.cgi?id=9955 Colors scaled from [0, 1] range to [0, 255] incorrectly
- fast/css/hsl-color-expected.checksum:
- fast/css/hsl-color-expected.png:
- fast/css/hsl-color-expected.txt:
- fast/forms/input-disabled-color-expected.checksum:
- fast/forms/input-disabled-color-expected.png:
- fast/forms/input-disabled-color-expected.txt:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=9955 Colors scaled from [0, 1] range to [0, 255] incorrectly
Fixes scaling issue and fixes Color to follow style guidelines.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- platform/Color.cpp: (WebCore::calcHue): (WebCore::makeRGBAFromHSLA): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::blend):
- platform/Color.h: (WebCore::Color::Color): (WebCore::Color::isValid): (WebCore::Color::red): (WebCore::Color::green): (WebCore::Color::blue): (WebCore::Color::alpha): (WebCore::Color::rgb): (WebCore::Color::setRGB): (WebCore::operator==): (WebCore::operator!=):
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
- 11:13 PM Changeset in webkit [15733] by
-
- 3 edits4 adds in trunk
LayoutTests:
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10158 REGRESSION: Selection highlight is dark and opaque when solid-color images are used
Reviewed by Darin.
- fast/backgrounds/solid-color-context-restore-expected.checksum: Added.
- fast/backgrounds/solid-color-context-restore-expected.png: Added.
- fast/backgrounds/solid-color-context-restore-expected.txt: Added.
- fast/backgrounds/solid-color-context-restore.html: Added.
WebCore:
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10158 REGRESSION: Selection highlight is dark and opaque when solid-color images are used
Reviewed by Darin.
Pixel test: fast/backgrounds/solid-color-context-restore.html
- platform/mac/ImageMac.mm: (WebCore::Image::draw): Added calls to preserve the graphics context around the painting of a solid color image. (WebCore::Image::drawTiled): Ditto.
- 11:10 PM Changeset in webkit [15732] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10182
Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables
- Drosera/console.js: String.indexOf returns -1 when the string is not found. Correct the logic to not reload local variable list unless an '=' character is in the expression.
- 11:00 PM Changeset in webkit [15731] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171 REGRESSION: failing layout test: fast/events/objc-event-api.html
- fast/events/objc-event-api-expected.txt: Updated test results for changes in the DumpRenderTree tool.
WebKitTools:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171 REGRESSION: failing layout test: fast/events/objc-event-api.html
- DumpRenderTree/DumpRenderTree.m: (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable location in flipped coordinates, since those are the coordinates that we use. (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling inside WebHTMLView.
- DumpRenderTree/EventSendingController.m: (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array. (-[EventSendingController init]): Removed, since the whole thing was a no-op. (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code probably worked OK, but this is needed to be correct. (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping code from screenY. We didn't really need to flip screenY -- what was actually happening was that the position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just dump the screenY as-is.
- 10:15 PM Changeset in webkit [15730] by
-
- 25 edits10 moves in trunk
WebCore:
Rubber-stamped by Tim Hatcher.
- renamed TransferJob to ResourceLoader
- Projects/gdk/webcore-gdk.bkl:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreResourceLoaderImp.h:
- bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp redirectedToURL:]): (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
- bridge/win/FrameWin.cpp:
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- loader/Cache.cpp:
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
- loader/loader.h:
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- platform/ResourceLoader.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::isErrorPage): (WebCore::ResourceLoader::error): (WebCore::ResourceLoader::setError): (WebCore::ResourceLoader::queryMetaData): (WebCore::ResourceLoader::addMetaData): (WebCore::ResourceLoader::kill): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
- platform/ResourceLoader.h: Added. (WebCore::ResourceLoader::getInternal):
- platform/ResourceLoaderClient.h: Added. (WebCore::ResourceLoaderClient::~ResourceLoaderClient): (WebCore::ResourceLoaderClient::receivedRedirect): (WebCore::ResourceLoaderClient::receivedResponse): (WebCore::ResourceLoaderClient::receivedData): (WebCore::ResourceLoaderClient::receivedAllData):
- platform/ResourceLoaderInternal.h: Added. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/TransferJob.cpp: Removed.
- platform/TransferJob.h: Removed.
- platform/TransferJobClient.h: Removed.
- platform/TransferJobInternal.h: Removed.
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::receivedData): (WebCore::FrameGdk::receivedAllData):
- platform/gdk/FrameGdk.h:
- platform/gdk/ResourceLoaderCurl.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
- platform/gdk/ResourceLoaderManager.cpp: Added. (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::get): (WebCore::ResourceLoaderManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add): (WebCore::ResourceLoaderManager::cancel):
- platform/gdk/ResourceLoaderManager.h: Added.
- platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
- platform/gdk/TransferJobCurl.cpp: Removed.
- platform/gdk/TransferJobManager.cpp: Removed.
- platform/gdk/TransferJobManager.h: Removed.
- platform/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::setLoader): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel):
- platform/mac/TransferJobMac.mm: Removed.
- platform/win/ResourceLoaderWin.cpp: Added. (WebCore::addToOutstandingJobs): (WebCore::lookupResourceLoader): (WebCore::ResourceLoaderWndProc): (WebCore::initializeOffScreenResourceLoaderWindow): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
- platform/win/ResourceLoaderWin.h: Added.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
- platform/win/TransferJobWin.cpp: Removed.
- platform/win/TransferJobWin.h: Removed.
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData):
- xml/xmlhttprequest.h:
WebKit:
Reviewed by Tim Hatcher.
- renamed TransferJob to ResourceLoader in WebCore
- COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::setStatusText):
- COM/WebFrame.h:
- 9:54 PM Changeset in webkit [15729] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
- omit the margin and padding boxes for display types where they are ignored
- use CSS instead of properties for table spacing and padding as suggested by Tim H.
- WebInspector/webInspector/inspector.css: Added rules for spacing and padding. Added rules that hide the margin and padding boxes (borders and all but the center cell) when the hide attribute is present.
- WebInspector/webInspector/inspector.html: Added classes for the rules above. Removed cellpadding and cellspacing attributes.
- WebInspector/webInspector/inspector.js: Added code to hide/show the margin and padding boxes based on the display type.
- 9:14 PM Changeset in webkit [15728] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt.
- removed obsolete cell margin hack
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins): Set top and bottom margins to 0 for table cells instead of -16384. No effect on layout (including layout tests).
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a few comments about differences between this class and the what the CSS specification says about computed style.
- 9:00 PM Changeset in webkit [15727] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode
- fast/selectors/unqualified-hover-quirks-expected.checksum: Added.
- fast/selectors/unqualified-hover-quirks-expected.png: Added.
- fast/selectors/unqualified-hover-quirks-expected.txt: Added.
- fast/selectors/unqualified-hover-quirks.html: Added.
- fast/selectors/unqualified-hover-strict-expected.checksum: Added.
- fast/selectors/unqualified-hover-strict-expected.png: Added.
- fast/selectors/unqualified-hover-strict-expected.txt: Added.
- fast/selectors/unqualified-hover-strict.html: Added.
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active exclusion based on onlyHoverActive to quirks mode.
- 8:54 PM Changeset in webkit [15726] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
"REGRESSION: delegate returning no menu elements crashes webkit"
No automated test, because there's no way to programmatically open a context menu,
no manual test because there's no way to customize the context menu delegate.
- WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned some menu items before accessing the first one.
- 8:51 PM Changeset in webkit [15725] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10178
Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source
- Drosera/debugger.js: Keep a stack that contains the source file and line number references for outer frames. Use this stack to determine which file and line to highlight when a stack frame is selected.
- 8:48 PM Changeset in webkit [15724] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10175
Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list
- Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.
- 7:27 PM Changeset in webkit [15723] by
-
- 1 add in trunk/WebCore/platform/ScrollBar.cpp
Add ScrollBar.cpp to fix the build.
- 7:25 PM Changeset in webkit [15722] by
-
- 7 edits in trunk/WebCore
Fix for bug 10179, digg.com scrolls slowly. Improve fixed positioning
and fixed backgrounds so that a count of them is kept on the FrameView.
This allows us to switch slow scrolling on and off as these objects come
and go.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
- page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
- page/FrameView.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 6:50 PM Changeset in webkit [15721] by
-
- 11 edits2 adds1 delete in trunk/WebCore
Begin disentangling of scrollbar logic in preparation for engine-implemented
scrollbars. Split ScrollBar into two classes, an abstract base (still named
ScrollBar) and a new PlatformScrollBar subclass. This subclass is used only
by platforms that want to continue to use a platform scrollbar (rather than
the engine one).
Reviewed by darin
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLCanvasElement.h:
- page/Frame.cpp:
- platform/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
- platform/ScrollBar.h: (WebCore::ScrollBarClient::~ScrollBarClient): (WebCore::ScrollBar::~ScrollBar): (WebCore::ScrollBar::orientation): (WebCore::ScrollBar::value): (WebCore::ScrollBar::client):
- platform/mac/PlatformScrollBarMac.mm: Added. (-[WebCoreScrollBar initWithPlatformScrollBar:]): (-[WebCoreScrollBar detachPlatformScrollBar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (-[WebCoreScrollBar mouseDown:]): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::scrollbarHit): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint):
- platform/mac/ScrollBarMac.mm: Removed.
- platform/mac/WebCoreTextArea.mm:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
- rendering/RenderFormElement.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionScrollbars):
- rendering/RenderLayer.h:
- rendering/RenderWidget.h:
- 5:05 PM Changeset in webkit [15720] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by John and Anders.
- Test for <rdar://problem/4380576> onChange does not get called when field changed by return key
- fast/forms/onchange-enter-submit-expected.txt: Added.
- fast/forms/onchange-enter-submit.html: Added.
WebCore:
Reviewed by John and Anders.
- Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key
Test: fast/forms/onchange-enter-submit.html
Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
This matches the sequence of events fired in WinIE.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
- 4:55 PM Changeset in webkit [15719] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/4658194> REGRESSION: "Search in Google"
and "Search in Spotlight" fail to work on text selected in a frame
Use selectedFrame to get the frame with the text selection.
- WebView/WebView.m: (-[WebView _searchWithGoogleFromMenu:]): (-[WebView _searchWithSpotlightFromMenu:]):
- 3:27 PM Changeset in webkit [15718] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin.
Moved string debug function outside of the WebCore namespace so that it's
easier to call in the debugger. I will never doubt Darin again (x100).
- platform/String.cpp: (string):
- 2:06 PM Changeset in webkit [15717] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Get rid of the -50000 nonsense on scrollbars when they're first added to overflow blocks.
- 1:59 PM Changeset in webkit [15716] by
-
- 2 edits in trunk/WebCore
Partial fix for 5453. Improve overflow so that when it changes
dynamically from scroll/auto to hidden that we properly hide the
scrollbars. Also refine the dirty dashboard region updating so that
it only happens if the scrollbars genuinely come and go.
Also eliminate the extra repaint of the entire block. This should not be
necessary, since the scrollbars repaint themselves already and children
will repaint already if they move.
Reviewed by darin
Adding test case from bug into fast/overflow/dynamic-hidden.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 1:58 PM Changeset in webkit [15715] by
-
- 4 adds in trunk/LayoutTests/fast/overflow
Add layout test for bug 5453.
- 12:49 PM Changeset in webkit [15714] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by justin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
- editing/pasteboard/paste-4039777-fix-expected.txt:
- editing/pasteboard/testcase-9507-expected.checksum: Added.
- editing/pasteboard/testcase-9507-expected.png: Added.
- editing/pasteboard/testcase-9507-expected.txt: Added.
- editing/pasteboard/testcase-9507.html: Added.
- editing/unsupported-content/table-delete-001-expected.txt:
- editing/selection/selectNode-expected.png:
- editing/selection/selectNode-expected.checksum:
- editing/selection/selectNode-expected.txt:
WebCore:
Reviewed by justin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
Improves paste fidelity because some of these empty font/style spans had a non-zero
size and were messing up the layout of pasted content:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead of start.node(). Don't do any application if the endpoints are swapped. Adjust endNode if the start node is a descendant of it, so that the pre-order traversal will terminate properly.
- 12:14 PM Changeset in webkit [15713] by
-
- 4 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10168 add a first cut at a Metrics pane to the inspector
- WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
- WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with the table to show the box model.
- WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some "title" attributes so we have more tooltips. Removed the optional parameter to getComputedStyle.
- 11:44 AM Changeset in webkit [15712] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- platform/String.cpp: (WebCore::string): Added a debugging function to create a String from a const char*.
- 11:21 AM Changeset in webkit [15711] by
-
- 1 edit in trunk/WebKit/ChangeLog
Update ChangeLog with bug link.
- 9:13 AM Changeset in webkit [15710] by
-
- 2 edits in trunk/WebKit
2006-07-31 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
- Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Create a mutable set instead of a mutable array.
- 8:43 AM Changeset in webkit [15709] by
-
- 2 edits in trunk/WebCore
2006-07-31 Anders Carlsson <acarlsson@apple.com>
- css/CSSPrimitiveValue.cpp: Fix windows build.
- 1:44 AM Changeset in webkit [15708] by
-
- 2 edits1 copy1 move1 delete in trunk/WebCore
Reinstating my last change. Everything builds now.
- 1:41 AM Changeset in webkit [15707] by
-
- 4 edits in trunk
LayoutTests:
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests
- fast/events/objc-event-api-expected.txt: Update test results.
WebKitTools:
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests
- DumpRenderTree/EventSendingController.m: Don't set the mouse down flag in keyDown handler.
- 1:31 AM Changeset in webkit [15706] by
-
- 2 edits2 copies2 deletes in trunk/WebCore
Backing out my last change because it causes a build failure in some
configurations. This seems to be the cleanest way to get svn to cooperate.
- 12:26 AM Changeset in webkit [15705] by
-
- 3 edits2 deletes in trunk/LayoutTests
- editing/pasteboard/paste-table-002-expected.txt: Corrected one result affected by my recent change to getComputedStyle.
- editing/pasteboard/paste-table-002.html: Converted to a text test, since it dumps the serialized form of hte result.
- editing/pasteboard/paste-table-002-expected.checksum: Removed.
- editing/pasteboard/paste-table-002-expected.png: Removed.
- 12:17 AM Changeset in webkit [15704] by
-
- 2 edits1 copy1 move1 delete in trunk/WebCore
Reviewed by Maciej.
Moved files around to make WebCore's structure clearer
and easier to explain.
DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
show up when you search inside bindings/js/, but are marked, at
the same time, as files that you should not edit manually)
WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
use DOMList.h)
icon -> loader/icon
I tested that everything still builds.
- 12:07 AM Changeset in webkit [15703] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- WebInspector/webInspector/inspector.js: Fix bug where a null property value leads to an empty style pane.
Jul 30, 2006:
- 11:52 PM Changeset in webkit [15702] by
-
- 10 edits2 adds in trunk
LayoutTests:
- test that displays all computed style -- demonstrates bug fixes I just made to the computed style class and also acts as a regression test for the existence of all of them and the basic format for a default object
- fast/css/computed-style-expected.txt: Added.
- fast/css/computed-style.html: Added.
WebCore:
Reviewed by Tim Hatcher.
- some improvements for the benefit of the style pane of the inspector
- css/CSSComputedStyleDeclaration.cpp: Removed background-position and border-spacing from the list of properties that show up in computed style, because of background-position-x, background-position-y, -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing. (WebCore::valueForLength): Added handling for undefinedLength, intrinsic, and min-intrinsic. (WebCore::primitiveValueFromLength): Removed code that would add a space to the string for no good reason. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a special case for a line clamp of -1, which should come back as "none" rather than an actual "-1". (WebCore::CSSComputedStyleDeclaration::length): Return 0 if the declaration has no corresponding node or no renderer. (WebCore::CSSComputedStyleDeclaration::item): Check against length() so that the two stay consistent rather than using a constant.
- css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Added. (WebCore::isCSSTokenizerURL): Added. (WebCore::quoteString): Added. (WebCore::quoteStringIfNeeded): Changed to quote strings in many more cases -- any cases where they would not parse in the CSS parser otherwise. The main case this affects is font names with spaces in them. (WebCore::quoteURLIfNeeded): Added. (WebCore::CSSPrimitiveValue::cssText): Use quoteURLIfNeeded in the case where we're making the text form of a URI.
- css/tokenizer.flex: Whitespace tweaks to line things up better.
WebKit:
Reviewed by Tim Hatcher.
- some improvements for the inspector
- WebInspector/WebInspector.m: (+sharedWebInspector:): Fixed bug that could cause the inspector to be garbage collected if used in an application with GC enabled. (-dealloc): Removed a call to a non-existent close method. (-window): Added a custom WebPreferences object and called setPrivateBrowsingEnabled:YES so the inspector won't appear in the history menu. Also call setProhibitsMainFrameScrolling:YES to try to get rid of trouble where the inspector scrolls when dragging.
- WebInspector/webInspector/inspector.css: Added style for the new color swatch, and JavaScript properties. More of the style should be shared between the panes, but this should be OK for now.
- WebInspector/webInspector/inspector.html: Added a first cut at a JavaScript properties pane. Needs work, but better than nothing.
- WebInspector/webInspector/inspector.js: Lots of improvements:
- Omit "typical" property values from computed style display, making it much shorter.
- Use the words "black", "white", and "transparent" when appropriate for color values.
- Refactored the loaded() function to get rid of repetitive scrollbar setup.
- Added a new scrollarea for the JavaScript properties pane.
- Simplified refreshScrollbars() -- we now refresh all scrollbars every time, which does no harm.
- Removed unused resultsWithXpathQuery().
- Use [] instead of "new Array()" and {} instead of "new Object()".
- Removed unused xpathForNode().
- Changed style pane to display the style for a text node's parent instead of saying it can't display the style for text.
- Fixed regression I caused a while back by checking the length of a computed style and not trying to display anything if its length is 0. Before this change and the corresponding change in WebCore, we'd see a complete list of all styles with the empty string as the value for each one.
- Changed the name of the computedStyle flag on the style rules array to isComputedStyle to make it easier to understand it's a boolean.
- Fixed an error in the code that does !important scanning where it was trying to do a special case for computed style, but was checking the computed style flag on the wrong object.
- Added populateStyleListItem() function to factor out things in common between the items in the top level list and the expanded tree for shorthand properties.
- Added code to make a color swatch next to the textual representation for any property that contains a color.
- Implemented a first cut at a simple JavaScript properties pane.
- 11:15 PM Changeset in webkit [15701] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
- Drosera/DebuggerDocument.m: (-[WebScriptObject switchToServerNamed:]): Remove as listener before resuming to ensure that the server does not try and notify us of events related to the resumption. (-[WebScriptObject webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Delegate call through to JavaScript.
- Drosera/debugger.js: Pause debugger when exception is raised.
- 4:02 PM Changeset in webkit [15700] by
-
- 3 edits in trunk/WebKitSite
Reviewed by Beth.
- Tweaked the checkout and build instructions to make them simpler and clearer.
- building/build.html:
- building/checkout.html:
Jul 29, 2006:
- 9:31 PM Changeset in webkit [15699] by
-
- 3 edits3 deletes in trunk/WebCore
2006-07-30 Eric Seidel <eric@eseidel.com>
Reviewed by gramps!
Remove some unused SVG code.
- ksvg2/ecma/Ecma.cpp: Removed.
- ksvg2/ecma/Ecma.h: Removed.
- ksvg2/ecma/GlobalObject.cpp: remove a couple dead functions.
- ksvg2/ecma/GlobalObject.h: add a comment about this dead code.
- ksvg2/ecma/SVGLookup.h: Removed.
- 5:04 PM Changeset in webkit [15698] by
-
- 38 edits in trunk
- Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
- Removed allow-tabs Subversion property from the files too.
- bindings/NP_jsobject.cpp:
- bindings/c/c_utility.cpp:
- bindings/jni/jni_runtime.cpp:
- bindings/jni/jni_utility.cpp:
- bindings/objc/objc_utility.mm:
- bindings/runtime.cpp:
- bindings/runtime_method.cpp:
- bindings/testbindings.cpp:
- bindings/testbindings.mm:
- kjs/date_object.cpp:
- kjs/function.cpp:
- kjs/list.cpp:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/string_object.cpp:
- kjs/ustring.cpp:
WebCore:
- Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
- Removed allow-tabs Subversion property from the files too.
- bindings/objc/WebScriptObject.h:
- bindings/objc/WebScriptObject.mm:
- platform/FontData.cpp:
WebKit:
- Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
- Removed allow-tabs Subversion property from the files too.
- DefaultDelegates/WebDefaultPolicyDelegate.m:
- History/WebHistory.m:
- Misc/WebDownload.m:
- Misc/WebIconDatabase.m:
- Misc/WebKitErrors.m:
- Misc/WebKitLogging.m:
- Misc/WebNSDataExtras.m:
- Misc/WebNSFileManagerExtras.m:
- Panels/WebPanelAuthenticationHandler.m:
- Plugins/WebBaseNetscapePluginView.m:
- Plugins/npfunctions.h:
- WebCoreSupport/WebSubresourceLoader.m:
- WebView/WebMainResourceLoader.m:
- WebView/WebView.h:
- WebView/WebView.m:
- 4:41 PM Changeset in webkit [15697] by
-
- 2 edits in trunk/JavaScriptCore
- tests/mozilla/expected.html: Update test results now that regress-185165.js is succeeding. I suspect Anders fix for bug 4620655 is the reason.
- 4:15 PM Changeset in webkit [15696] by
-
- 225 edits in trunk
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080 Adopt pedantic changes from the Unity project to improve cross-compiler compatibility
Changes include:
- Removing trailing semicolon from namespace braces.
- Removing trailing comma from last enum declaration.
- Updating to match style guidelines.
- Adding missing newline to the end of the file.
- Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
- Alphabetical sorting of Xcode source list files.
- Replace use of non-portable variable-size array with Vector.
- Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
- API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCorePrefix.h:
- bindings/jni/jni_class.cpp: (JavaClass::fieldNamed):
- bindings/jni/jni_class.h:
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
- bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
- bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaArray::JavaArray):
- bindings/jni/jni_runtime.h:
- bindings/jni/jni_utility.h:
- bindings/objc/objc_instance.h:
- bindings/runtime_array.h:
- kjs/collector.h:
- kjs/config.h:
- kjs/ustring.cpp:
- wtf/Platform.h:
JavaScriptGlue:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080 Adopt pedantic changes from the Unity project to improve cross-compiler compatibility
Changes include:
- Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080 Adopt pedantic changes from the Unity project to improve cross-compiler compatibility
Changes include:
- Removing trailing semicolon from namespace braces.
- Removing trailing comma from last enum declaration.
- Updating to match style guidelines.
- Adding missing newline to the end of the file.
- Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
- Alphabetical sorting of Xcode source list files.
- Use abs() function from <math.h> instead of ABS() macro.
- Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
- Use -numeric_limits<double>::infinity() instead of -HUGE_VAL.
- WebCore+SVG/DOMList.h:
- WebCore.xcodeproj/project.pbxproj:
- WebCorePrefix.h:
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- bindings/js/JSXSLTProcessor.h:
- bindings/js/kjs_domnode.h: (KJS::DOMNode::):
- bindings/objc/DOMCSS.h: (-[DOMCSSValue enum]):
- bindings/objc/DOMCore.h: (-[DOMImplementation createDocument:::]):
- bindings/objc/DOMEvents.h: (-[DOMOverflowEvent enum]):
- bindings/objc/DOMRange.h:
- bindings/objc/DOMTraversal.h:
- bindings/objc/DOMXPath.h: (-[DOMXPathNSResolver lookupNamespaceURI:]):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreKeyboardAccess.h:
- css/makeprop:
- css/makevalues:
- dom/ChildNodeList.h:
- dom/DocPtr.h:
- dom/Document.h: (WebCore::Document::):
- dom/DocumentMarker.h: (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
- dom/EventTargetNode.h:
- dom/KeyboardEvent.h: (WebCore::KeyboardEvent::):
- dom/NameNodeList.h: (WebCore::NameNodeList::rootNodeChildrenChanged):
- dom/QualifiedName.cpp:
- editing/TypingCommand.h: (WebCore::TypingCommand::):
- editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):
- html/FormDataList.h: (WebCore::FormDataListItem::FormDataListItem): (WebCore::FormDataList::appendData):
- html/HTMLBlockquoteElement.h:
- html/HTMLDivElement.h:
- html/HTMLFormElement.h:
- html/HTMLHRElement.h:
- html/HTMLHeadingElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.h:
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::):
- icon/IconDatabase.cpp:
- icon/SQLStatement.cpp:
- kcanvas/KCanvasFilters.h: (WebCore::): (WebCore::KCanvasPoint3F::KCanvasPoint3F): (WebCore::KCanvasFilter::KCanvasFilter): (WebCore::KCanvasFilter::~KCanvasFilter): (WebCore::KCanvasFilterEffect::~KCanvasFilterEffect): (WebCore::KCComponentTransferFunction::KCComponentTransferFunction): (WebCore::KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): (WebCore::KCLightSource::KCLightSource): (WebCore::KCDistantLightSource::KCDistantLightSource): (WebCore::KCPointLightSource::KCPointLightSource): (WebCore::KCSpotLightSource::KCSpotLightSource): (WebCore::KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEImage::KCanvasFEImage): (WebCore::KCanvasFESpecularLighting::KCanvasFESpecularLighting):
- kcanvas/RenderSVGImage.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::):
- ksvg2/css/SVGRenderStyleDefs.h: (WebCore::):
- ksvg2/events/SVGZoomEvent.h:
- ksvg2/ksvg.h: (WebCore::):
- ksvg2/misc/KCanvasRenderingStyle.h:
- ksvg2/misc/SVGImageLoader.h:
- ksvg2/scripts/make_names.pl:
- ksvg2/svg/SVGAElement.h:
- ksvg2/svg/SVGAngle.h:
- ksvg2/svg/SVGAnimateColorElement.h:
- ksvg2/svg/SVGAnimateElement.h:
- ksvg2/svg/SVGAnimateTransformElement.h:
- ksvg2/svg/SVGAnimatedAngle.h:
- ksvg2/svg/SVGAnimatedBoolean.h:
- ksvg2/svg/SVGAnimatedColor.h:
- ksvg2/svg/SVGAnimatedEnumeration.h:
- ksvg2/svg/SVGAnimatedInteger.h:
- ksvg2/svg/SVGAnimatedLength.h:
- ksvg2/svg/SVGAnimatedLengthList.h:
- ksvg2/svg/SVGAnimatedNumber.h:
- ksvg2/svg/SVGAnimatedNumberList.h:
- ksvg2/svg/SVGAnimatedPathData.h:
- ksvg2/svg/SVGAnimatedPoints.h:
- ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
- ksvg2/svg/SVGAnimatedRect.h:
- ksvg2/svg/SVGAnimatedString.h:
- ksvg2/svg/SVGAnimatedTemplate.h:
- ksvg2/svg/SVGAnimatedTransformList.h:
- ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
- ksvg2/svg/SVGAnimationElement.h: (WebCore::):
- ksvg2/svg/SVGCircleElement.h:
- ksvg2/svg/SVGClipPathElement.h:
- ksvg2/svg/SVGColor.h:
- ksvg2/svg/SVGComponentTransferFunctionElement.h:
- ksvg2/svg/SVGCursorElement.h:
- ksvg2/svg/SVGDOMImplementation.h:
- ksvg2/svg/SVGDefsElement.h:
- ksvg2/svg/SVGDescElement.h:
- ksvg2/svg/SVGDocument.h:
- ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
- ksvg2/svg/SVGElementInstance.h:
- ksvg2/svg/SVGElementInstanceList.h:
- ksvg2/svg/SVGEllipseElement.h:
- ksvg2/svg/SVGExternalResourcesRequired.h:
- ksvg2/svg/SVGFEBlendElement.h:
- ksvg2/svg/SVGFEColorMatrixElement.h:
- ksvg2/svg/SVGFEComponentTransferElement.h:
- ksvg2/svg/SVGFECompositeElement.h:
- ksvg2/svg/SVGFEDiffuseLightingElement.h:
- ksvg2/svg/SVGFEDisplacementMapElement.h:
- ksvg2/svg/SVGFEDistantLightElement.h:
- ksvg2/svg/SVGFEFloodElement.h:
- ksvg2/svg/SVGFEFuncAElement.h:
- ksvg2/svg/SVGFEFuncBElement.h:
- ksvg2/svg/SVGFEFuncGElement.h:
- ksvg2/svg/SVGFEFuncRElement.h:
- ksvg2/svg/SVGFEGaussianBlurElement.h:
- ksvg2/svg/SVGFEImageElement.h:
- ksvg2/svg/SVGFELightElement.h:
- ksvg2/svg/SVGFEMergeElement.h:
- ksvg2/svg/SVGFEMergeNodeElement.h:
- ksvg2/svg/SVGFEOffsetElement.h:
- ksvg2/svg/SVGFEPointLightElement.h:
- ksvg2/svg/SVGFESpecularLightingElement.h:
- ksvg2/svg/SVGFESpotLightElement.h:
- ksvg2/svg/SVGFETileElement.h:
- ksvg2/svg/SVGFETurbulenceElement.h:
- ksvg2/svg/SVGFilterElement.h:
- ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
- ksvg2/svg/SVGFitToViewBox.h:
- ksvg2/svg/SVGForeignObjectElement.cpp:
- ksvg2/svg/SVGForeignObjectElement.h:
- ksvg2/svg/SVGGElement.h:
- ksvg2/svg/SVGGradientElement.h:
- ksvg2/svg/SVGHelper.h: (WebCore::):
- ksvg2/svg/SVGImageElement.h:
- ksvg2/svg/SVGLangSpace.h:
- ksvg2/svg/SVGLength.h:
- ksvg2/svg/SVGLengthList.h:
- ksvg2/svg/SVGLineElement.h:
- ksvg2/svg/SVGLinearGradientElement.h:
- ksvg2/svg/SVGList.h:
- ksvg2/svg/SVGLocatable.h:
- ksvg2/svg/SVGMarkerElement.h:
- ksvg2/svg/SVGMaskElement.h:
- ksvg2/svg/SVGMatrix.h:
- ksvg2/svg/SVGNumber.h:
- ksvg2/svg/SVGNumberList.h:
- ksvg2/svg/SVGPaint.h:
- ksvg2/svg/SVGPathElement.h:
- ksvg2/svg/SVGPathSeg.h:
- ksvg2/svg/SVGPathSegArc.h:
- ksvg2/svg/SVGPathSegClosePath.h:
- ksvg2/svg/SVGPathSegCurvetoCubic.h:
- ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
- ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
- ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
- ksvg2/svg/SVGPathSegLineto.h:
- ksvg2/svg/SVGPathSegLinetoHorizontal.h:
- ksvg2/svg/SVGPathSegLinetoVertical.h:
- ksvg2/svg/SVGPathSegList.h:
- ksvg2/svg/SVGPathSegMoveto.h:
- ksvg2/svg/SVGPatternElement.h:
- ksvg2/svg/SVGPoint.h:
- ksvg2/svg/SVGPointList.h:
- ksvg2/svg/SVGPolyElement.h:
- ksvg2/svg/SVGPolygonElement.h:
- ksvg2/svg/SVGPolylineElement.h:
- ksvg2/svg/SVGPreserveAspectRatio.h:
- ksvg2/svg/SVGRadialGradientElement.h:
- ksvg2/svg/SVGRect.h:
- ksvg2/svg/SVGRectElement.h:
- ksvg2/svg/SVGSVGElement.h:
- ksvg2/svg/SVGScriptElement.h:
- ksvg2/svg/SVGSetElement.h:
- ksvg2/svg/SVGStopElement.h:
- ksvg2/svg/SVGStringList.h:
- ksvg2/svg/SVGStylable.h:
- ksvg2/svg/SVGStyleElement.h:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::canvasResource):
- ksvg2/svg/SVGStyledLocatableElement.h:
- ksvg2/svg/SVGStyledTransformableElement.h:
- ksvg2/svg/SVGSwitchElement.h:
- ksvg2/svg/SVGSymbolElement.h:
- ksvg2/svg/SVGTRefElement.h:
- ksvg2/svg/SVGTSpanElement.h:
- ksvg2/svg/SVGTests.h:
- ksvg2/svg/SVGTextContentElement.h:
- ksvg2/svg/SVGTextElement.h:
- ksvg2/svg/SVGTextPositioningElement.h:
- ksvg2/svg/SVGTitleElement.h:
- ksvg2/svg/SVGTransform.h:
- ksvg2/svg/SVGTransformList.h:
- ksvg2/svg/SVGTransformable.h:
- ksvg2/svg/SVGURIReference.h:
- ksvg2/svg/SVGUseElement.h:
- ksvg2/svg/SVGViewElement.h:
- ksvg2/svg/SVGZoomAndPan.h:
- ksvg2/svg/svgpathparser.h:
- page/Frame.h: (WebCore::):
- platform/AffineTransform.h:
- platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
- platform/FontData.cpp: (WebCore::FontData::FontData):
- platform/FontData.h:
- platform/TextBox.h: (WebCore::TextBox::):
- platform/Timer.cpp: (WebCore::TimerBase::heapPop):
- platform/mac/FontCacheMac.mm:
- platform/mac/GlyphMapMac.cpp:
- platform/mac/WebFontCache.mm: (betterChoice):
- rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
- rendering/EllipsisBox.h:
- rendering/RenderBR.h: (WebCore::RenderBR::renderName): (WebCore::RenderBR::width):
- rendering/RenderBlock.h: (WebCore::):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
- rendering/RenderFrame.cpp:
- rendering/bidi.h:
- rendering/break_lines.cpp:
WebKit:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080 Adopt pedantic changes from the Unity project to improve cross-compiler compatibility
Changes include:
- Adding missing newline to the end of the file.
- Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebResourcePrivate.h:
- 4:09 PM Changeset in webkit [15695] by
-
- 32 edits in trunk
Clear stray executable bits.
- 3:50 PM Changeset in webkit [15694] by
-
- 2 edits in trunk/WebCore/editing
Clear some stray executable bits.
- 2:05 PM Changeset in webkit [15693] by
-
- 1 edit in trunk/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt
Remove the output produced by an alert, so
hopefully buildbot will not complain anymore :)
- 1:25 PM Changeset in webkit [15692] by
-
- 6 edits in trunk
Reviewed by Geoff.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
ghostmap XHTML + SVG fails due to javascript undefined exception
Make sure document.URL works when called from a non-HTML document.
- 8:44 AM Changeset in webkit [15691] by
-
- 14 edits2 adds in trunk
Reviewed by Darin.
- fixes for Linux build
- JavaScriptCoreSources.bkl: Added new files to build, kjs/PropertyNameArray.cpp and kjs/testkjs.cpp, and removed old files.
WebCore:
Reviewed and tweaked by Darin.
- fixes for Linux build (still might not compile, since Darin tweaked but was unable to test).
- WebCoreSources.bkl: Added some new sources, removed some obsolete ones.
- Projects/gdk/webcore-gdk.bkl: Added RenderPopupMenuGdk.cpp
- html/HTMLPlugInElement.h: Removed incorrect syntax with class name before ::.
- platform/gdk/FrameGdk.h:
- platform/gdk/FrameGdk.cpp: Updated parameters of constructor. Moved a couple stubs out of this file.
- platform/gdk/RenderPopupMenuGdk.h: Added.
- platform/gdk/RenderPopupMenuGdk.cpp: Added. Just a file full of empty stubs.
- platform/gdk/RenderThemeGdk.h:
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): Added.
- platform/gdk/TemporaryLinkStubs.cpp: Add some new stubs.
WebKitTools:
Reviewed by Darin.
- fixes for Linux build
- GdkLauncher/mk: Added call to bakefile_gen before calling make.
- GdkLauncher/gdklauncher.bkl: Tweak comment.
- 8:43 AM Changeset in webkit [15690] by
-
- 3 edits in trunk/LayoutTests
- changed this test to a plain-text one and added text explaining what it tests
- fast/forms/input-named-action-overrides-action-attribute.html: Added explanation text, got rid of some incorrect HTML syntax, added a call to dumpAsText(), and used a paragraph element instead of a span element for the result.
- fast/forms/input-named-action-overrides-action-attribute-expected.txt: Updated.
- 8:21 AM Changeset in webkit [15689] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10022
Bug 10022: REGRESSION: Crash in WebCore::XMLTokenizer::characters
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::resumeParsing): If the write() call resulted in new callbacks being added, don't call through to end() just yet.
- 8:19 AM Changeset in webkit [15688] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by John Sullivan.
- manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9984 ASSERTION FAILURE: _private->mouseDownEvent != nil (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
- manual-tests/subview-click-assertion.html: Added.
WebKit:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9984 ASSERTION FAILURE: _private->mouseDownEvent != nil (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
- WebView/WebHTMLView.m: (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed to accept nil. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Copy the hit HTMLView's mouse down event to the top HTMLView. (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in mouseDown: (and used during dragging). (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to the top HTMLView.
- 8:06 AM Changeset in webkit [15687] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly
- fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
- fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
- fast/lists/ordered-list-with-no-ol-tag-expected.txt: Added.
- fast/lists/ordered-list-with-no-ol-tag.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly
- rendering/RenderListItem.cpp: (WebCore::enclosingList): If no real list element is found, use parent instead. (WebCore::previousListItem): Check list elements to see if they are list items -- the old code assumed that a list would never be a list item but this is entirely possible with CSS and especially with the new rule that means any DOM element could act as a list.
- 7:56 AM Changeset in webkit [15686] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10147
REGRESSION: custom attribute values set via javascript are not persistent
Test: fast/dom/Element/setAttribute-case-insensitivity.html
- dom/Element.cpp: (WebCore::Element::setAttribute): Use the lowercased localName for retrieving the old value, too.
- 7:53 AM Changeset in webkit [15685] by
-
- 1 edit4 deletes in trunk/LayoutTests
- rolled out the test for bug 9753, since we rolled out the fix we'll bring back the test when we bring back the fix
- svg/custom/width-full-percentage-expected.checksum: Removed.
- svg/custom/width-full-percentage-expected.png: Removed.
- svg/custom/width-full-percentage-expected.txt: Removed.
- svg/custom/width-full-percentage.svg: Removed.
Jul 28, 2006:
- 5:25 PM Changeset in webkit [15684] by
-
- 2 edits in trunk/WebCore
Suggested by Darin.
Moving the implementation of isContentEditable to the
the WebPrivate category.
- bindings/objc/DOM.mm: (-[DOMNode isContentEditable]):
- 5:24 PM Changeset in webkit [15683] by
-
- 8 edits in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
Removed incorrect nesting:
- editing/pasteboard/paste-table-001-expected.checksum:
- editing/pasteboard/paste-table-001-expected.png:
- editing/pasteboard/paste-table-001-expected.txt:
- editing/pasteboard/paste-table-003-expected.txt:
WebCore:
Reviewed by levi
First part of:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
Migrate to isBlock and enclosingBlock.
Changed RendereringInfo::isBlock and ReplacementFragment::isBlock
to wasBlock so that they don't conflict with isBlock and because
it's more descriptive.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::wasBlock): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::shouldMergeStart): (WebCore::ReplaceSelectionCommand::doApply):
- editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::wasBlock):
- 5:05 PM Changeset in webkit [15682] by
-
- 1 copy in tags/Safari-521.25
New tag.
- 5:02 PM Changeset in webkit [15681] by
-
- 4 edits in branches/Safari-521
Versioning
- 4:58 PM Changeset in webkit [15680] by
-
- 1 delete in test
revert 15679
- 4:58 PM Changeset in webkit [15679] by
-
- 1 add in test
test
- 4:51 PM Changeset in webkit [15678] by
-
- 2 edits in branches/Safari-521/WebKit
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-28 Timothy Hatcher <timothy@apple.com>
Reviewed by John.
The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- 4:50 PM Changeset in webkit [15677] by
-
- 2 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-28 Timothy Hatcher <timothy@apple.com>
Reviewed by John.
Adding isContentEditable to DOMNode's private category.
- bindings/objc/DOMPrivate.h:
- 4:29 PM Changeset in webkit [15676] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Rubber stamped by Maciej.
Fix for <rdar://problem/4541255> Safari hangs at http://
www.kutilek.de/safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)
This is the same fix that Maciej and I did a week ago for 4529398.
Rolling it onto the branch because it fixes this crash too!
- WebCore.xcodeproj/project.pbxproj: Project file wars.
- khtml/rendering/render_list.cpp: (ListMarkerBox::detach): Remove from parent when detaching. (ListMarkerBox::operator delete):
- khtml/rendering/render_list.h:
- 3:33 PM Changeset in webkit [15675] by
-
- 3 edits in S60/trunk/WebKit
2006-07-28 ligman <joseph.ligman@nokia.com>
Reviewed by Sachin.
- BrowserView/inc/SmartLinkMap.h:
- BrowserView/src/SmartLinkMap.cpp:
- 3:10 PM Changeset in webkit [15674] by
-
- 4 edits in S60/trunk/WebKit
2006-07-28 ligman <joseph.ligman@nokia.com>
Reviewed by Sachin.
- BrowserView/inc/SmartLinkMap.h:
- BrowserView/src/SmartLinkMap.cpp: (CSmartLinkMap::InsertLink): (CSmartLinkMap::IndexingCallbackL): (CSmartLinkMap::~CSmartLinkMap): (CSmartLinkMap::StartIndexingSmartLinks): (CSmartLinkMap::StopIndexingSmartLinks): (CSmartLinkMap::ReIndexSmartLinks):
- BrowserView/src/WebKitView.cpp: (CWebKitView::FindNextSmartLink):
Fix scrolling of smart links in manual find. Remove the duplicate smart links from the map
- 3:01 PM Changeset in webkit [15673] by
-
- 10 edits8 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/
Removed one of the two extraneous newlines that are introduced on paste:
- editing/pasteboard/paste-table-003-expected.checksum:
- editing/pasteboard/paste-table-003-expected.png:
- editing/pasteboard/paste-table-003-expected.txt:
Fewer pastes remove nodes containing the selection b/c of
the changes to interchange newlines:
- editing/pasteboard/paste-line-endings-007-expected.txt:
- editing/pasteboard/paste-line-endings-008-expected.txt:
- editing/pasteboard/paste-line-endings-009-expected.txt:
Added:
- editing/pasteboard/4242293-1-expected.checksum: Added.
- editing/pasteboard/4242293-1-expected.png: Added.
- editing/pasteboard/4242293-1-expected.txt: Added.
- editing/pasteboard/4242293-1.html: Added.
- editing/pasteboard/4242293-expected.checksum: Added.
- editing/pasteboard/4242293-expected.png: Added.
- editing/pasteboard/4242293-expected.txt: Added.
- editing/pasteboard/4242293.html: Added.
WebCore:
Reviewed by levi
More changes for:
<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/
- editing/markup.cpp: (WebCore::needInterchangeNewlineAfter): Added. (WebCore::createMarkup): Only add an interchangeNewline if we're annotating for interchange. Can't test this until we expose createMarkup in non-annotate mode (I'd expose Range::toHTML). Remove the FIXME about prepending the interchangeNewline before creating the rest of the markup. Its correct to surround the interchangeNewline in ancestors of the adjusted startNode. Fixed the check to see if an interchangeNewline is needed (!inSameBlock). This would add an interchangeNewline for a selection that started before a table. Removed the workaround for the bug where markup for a table was not included when selecting the contents of a table, since this change fixes the general problem of markup for ancestors of the startNode being left out. Don't leave out ancestors of the startNode as we leave their subtrees. Execute the code to include them even if we closed ancestors in the ancestorsToClose list.
- 1:06 PM Changeset in webkit [15672] by
-
- 2 edits in S60/trunk/WebKit
2006-07-28 sareen <shyam.sareen@nokia.com>
Reviewed by Sachin
- group/EABI/browserengineU.def: Bugzilla ID 10109: BC break in Browser Control API due to the def file
incompatibility with the old version.
- 12:59 PM Changeset in webkit [15671] by
-
- 1 edit in trunk/WebKit/ChangeLog
Reviewed by John.
<rdar://problem/4657473> REGRESSION: Spell check not available from contextual menu in Mail
The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- 12:58 PM Changeset in webkit [15670] by
-
- 5 edits in trunk
WebCore:
Reviewed by John.
Adding isContentEditable to DOMNode's private category.
- bindings/objc/DOMPrivate.h:
WebKit:
Reviewed by John.
The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- 12:19 PM Changeset in webkit [15669] by
-
- 40 edits in trunk
Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=6010 because of failing layout tests.
- 12:01 PM Changeset in webkit [15668] by
-
- 13 edits in trunk/WebCore
Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 because of failing layout tests.
SVG with width and height 100% leaves room for scrollbar on the right.
- kcanvas/RenderPath.cpp:
- kcanvas/RenderPath.h:
- kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- ksvg2/svg/SVGCircleElement.cpp:
- ksvg2/svg/SVGCircleElement.h:
- ksvg2/svg/SVGEllipseElement.cpp:
- ksvg2/svg/SVGEllipseElement.h:
- ksvg2/svg/SVGLineElement.cpp:
- ksvg2/svg/SVGLineElement.h:
- ksvg2/svg/SVGRectElement.cpp:
- ksvg2/svg/SVGRectElement.h:
- ksvg2/svg/SVGStyledElement.h:
- 11:07 AM Changeset in webkit [15667] by
-
- 40 edits in trunk
2006-07-27 Eric Seidel <eric@eseidel.com>
Reviewed by darin.
Add better SVGLoad event support.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
There will still need to be additional support added for <link> and <script> elements.
Not all of the error -> loaded -> error transition cases work yet.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
- html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
- ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::SVGImageLoader): (WebCore::SVGImageLoader::dispatchLoadEvent):
- ksvg2/misc/SVGImageLoader.h:
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::parseMappedAttribute):
- ksvg2/svg/SVGAnimatedBoolean.h:
- ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::parseMappedAttribute): (WebCore::SVGElement::haveLoadedRequiredResources): (WebCore::SVGElement::sendSVGLoadEventIfPossible): (WebCore::SVGElement::closeRenderer):
- ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
- ksvg2/svg/SVGExternalResourcesRequired.h:
- ksvg2/svg/SVGImageElement.cpp: (SVGImageElement::SVGImageElement): (SVGImageElement::haveLoadedRequiredResources):
- ksvg2/svg/SVGImageElement.h:
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::executeScript):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
Jul 27, 2006:
- 10:13 PM Changeset in webkit [15666] by
-
- 9 edits in trunk/WebCore
Reviewed by Anders.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10135 Cleanup: remove useless parameters from RenderObject::position()
No test possible (no functionality change)
- rendering/RenderBox.cpp: (WebCore::RenderBox::position):
- rendering/RenderBox.h:
- rendering/RenderObject.h: (WebCore::RenderObject::position):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::position):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::position):
- rendering/RenderText.cpp: (WebCore::RenderText::position):
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeVerticalPositionsForLine):
- 9:53 PM Changeset in webkit [15665] by
-
- 14 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
Test case for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.
- svg/custom/width-full-percentage-expected.txt: Added.
- svg/custom/width-full-percentage-expected.checksum: Added.
- svg/custom/width-full-percentage-expected.png: Added.
- svg/custom/width-full-percentage.svg: Added.
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.
Relayout children of svg containers, except svg shapes that do not depend on percentages.
- kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
- kcanvas/RenderPath.h:
- kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
- ksvg2/svg/SVGCircleElement.h:
- ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
- ksvg2/svg/SVGEllipseElement.h:
- ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
- ksvg2/svg/SVGLineElement.h:
- ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
- ksvg2/svg/SVGRectElement.h:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
- 6:07 PM Changeset in webkit [15664] by
-
- 1 edit in tags/Safari-521.24/WebCore/Info.plist
Versioning
- 6:03 PM Changeset in webkit [15663] by
-
- 4 edits in tags/Safari-521.24/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-26 Justin Garcia <justin.garcia@apple.com>
Reviewed by darin
<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body
- dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
- html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
- html/HTMLElement.h:
- 6:02 PM Changeset in webkit [15662] by
-
- 4 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-26 Justin Garcia <justin.garcia@apple.com>
Reviewed by darin
<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body
- dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
- html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
- html/HTMLElement.h:
- 5:47 PM Changeset in webkit [15661] by
-
- 1 copy in tags/Safari-521.24
New tag.
- 5:45 PM Changeset in webkit [15660] by
-
- 4 edits in branches/Safari-521
Versioning
- 5:40 PM Changeset in webkit [15659] by
-
- 2 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-26 Alice Liu <alice.liu@apple.com>
Reviewed by John Sullivan (and Kevin and Timo).
landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard
- page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
- 5:38 PM Changeset in webkit [15658] by
-
- 2 edits in branches/Safari-521/WebKit
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej, inspired by John.
- Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon
An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.
- Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
- 5:36 PM Changeset in webkit [15657] by
-
- 3 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-25 Justin Garcia <justin.garcia@apple.com>
Reviewed by darin
<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">
- dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
- page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
- 4:50 PM Changeset in webkit [15656] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/
- editing/pasteboard/styled-element-markup-expected.checksum: Added.
- editing/pasteboard/styled-element-markup-expected.png: Added.
- editing/pasteboard/styled-element-markup-expected.txt: Added.
- editing/pasteboard/styled-element-markup.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Fixed crasher with nil-check.
- editing/markup.cpp: (WebCore::startMarkup): Style information wasn't added to an element if it had attributes but no style attribute.
- 2:56 PM Changeset in webkit [15655] by
-
- 2 edits in S60/trunk/WebKit
2006-07-27 zhalu <Zhaosong.lu@nokia.com>
Reviewed by Sachin
- BrowserCore/Formcontrols/src/FControlSelectSkin.cpp: (CFormSelectSkin::CalculateVisualClipTextL): Work around if Font returns zero for MaxNormalCharWidth
- 2:06 PM Changeset in webkit [15654] by
-
- 4 edits2 adds in trunk
2006-07-27 Alexander Kellett <lypanov@kde.org>
Reviewed by Darin.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9867 REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit
- bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
- html/HTMLFormElement.idl:
2006-07-27 Alexander Kellett <lypanov@kde.org>
Reviewed by Darin.
Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit
- fast/forms/input-named-action-overrides-action-attribute-expected.txt: Added.
- fast/forms/input-named-action-overrides-action-attribute.html: Added.
- 1:18 PM Changeset in webkit [15653] by
-
- 8 edits2 adds in trunk
Reviewed by Anders.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
Some HTML DOM attributes have incorrect types
Adjust idl and dom source code for HTMLImageElement and
HTMLBaseFontElement to choose correct type for
HTMLImageElement::border and HTMLBaseFontElement::size
attributes.
- 1:01 PM Changeset in webkit [15652] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form
- fast/forms/4628409-expected.txt: Added.
- fast/forms/4628409.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): A script on the page shrinks the textarea down to zero rows just before insertion. That gives the shadow div a zero height, removing [div, 0] as a candidate for a VisiblePosition. Then InsertTextCommand::input() tries to create a VisiblePosition from [div, 0] and fails. A nil check is a quick fix. Another might be to make positions where there is a caret selection candidates. Another might be to make any [div, 0] where div is a shadow div inside a form element a candidate.
- 11:58 AM Changeset in webkit [15651] by
-
- 3 edits4 adds in trunk
Fix by Graham Dennis, reviewed by Darin.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10094 Japanese characters improperly rendering in TOT
Test: fast/encoding/denormalised-voiced-japanese-chars.html
- platform/Font.cpp: (WebCore::WidthIterator::advance): pass currentCharacter to normalizeVoicingMarks (WebCore::WidthIterator::normalizeVoicingMarks): turn the currentCharacter variable into an argument as WidthIterator::advance doesn't update m_currentCharacter while looping
- 11:11 AM Changeset in webkit [15650] by
-
- 2 edits in tags/Safari-521.23/WebKit
Versioning
- 11:09 AM Changeset in webkit [15649] by
-
- 2 edits in branches/Safari-521/WebKit
Versioning
- 2:22 AM Changeset in webkit [15648] by
-
- 13 edits in trunk
2006-07-27 Eric Seidel <eric@eseidel.com>
Reviewed by ap.
Complex entities seem to fail on TOT
http://bugzilla.opendarwin.org/show_bug.cgi?id=6390
Use an alternative work-around to an XML Entity parsing bug.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write): (WebCore::hackAroundLibXMLEntityBug): added. (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::getEntityHandler):
- 12:46 AM Changeset in webkit [15647] by
-
- 3 edits8 adds in trunk
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9938
Fix viewBox issues in Hixie's test
Do a more accurate and quicker job of parsing the viewBox
attribute. Handle properly on negative width/height and
invalid syntax in general.
- ksvg2/svg/SVGFitToViewBox.cpp: (SVGFitToViewBox::parseViewBox):
Jul 26, 2006:
- 10:26 PM Changeset in webkit [15646] by
-
- 11 edits12 adds in trunk
2006-07-27 Eric Seidel <eric@eseidel.com>
Reviewed by ap.
Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
This patch does not try to autogenerate anything, but enables the SVG functionality.
Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.
- bindings/js/kjs_dom.cpp: (KJS::toJS):
- bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::objectGetter): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::objectSetter):
- bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
- dom/Document.h: (WebCore::Document::isSVGDocument):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::contentDocument): (WebCore::HTMLEmbedElement::getSVGDocument):
- html/HTMLEmbedElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::contentDocument): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::setCode): (WebCore::HTMLObjectElement::setArchive): (WebCore::HTMLObjectElement::setBorder): (WebCore::HTMLObjectElement::setCodeBase): (WebCore::HTMLObjectElement::setCodeType): (WebCore::HTMLObjectElement::setData): (WebCore::HTMLObjectElement::hspace): (WebCore::HTMLObjectElement::setHspace): (WebCore::HTMLObjectElement::setStandby): (WebCore::HTMLObjectElement::setType): (WebCore::HTMLObjectElement::setUseMap): (WebCore::HTMLObjectElement::vspace): (WebCore::HTMLObjectElement::setVspace): (WebCore::HTMLObjectElement::getSVGDocument):
- html/HTMLObjectElement.h:
- ksvg2/svg/SVGDocument.h: (WebCore::SVGDocument::isSVGDocument):
- rendering/RenderWidget.h: (WebCore::RenderWidget::frameView):
- 9:31 PM Changeset in webkit [15645] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet
Test: fast/js/xhtml-serialize.html
- editing/markup.cpp: (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it is not permitted in HTML, to make it valid XML.
- 6:43 PM Changeset in webkit [15644] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan (and Kevin and Timo).
landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard
- page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
- 5:42 PM Changeset in webkit [15643] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by darin
<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body
- editing/style/designmode-expected.checksum: Added.
- editing/style/designmode-expected.png: Added.
- editing/style/designmode-expected.txt: Added.
- editing/style/designmode.html: Added.
WebCore:
Reviewed by darin
<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body
- dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
- html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
- html/HTMLElement.h:
- 5:26 PM Changeset in webkit [15642] by
-
- 1 copy in tags/Safari-521.23
New tag.
- 5:07 PM Changeset in webkit [15641] by
-
- 2 edits in branches/Safari-521/WebCore
Versioning
- 4:22 PM Changeset in webkit [15640] by
-
- 6 edits in branches/Safari-521
WebCore:
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-25 David Harrison <harrison@apple.com>
Reviewed by timo and Darin.
<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.
WebKit:
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-25 David Harrison <harrison@apple.com>
Reviewed by timo and Darin.
<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
- WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
- 12:33 PM Changeset in webkit [15639] by
-
- 2 edits in trunk/WebCore
Fix by Mitz Pettel, reviewed by ap.
- fix debug-only information() string for table cells
- rendering/RenderObject.cpp: (WebCore::RenderObject::information):
- 11:31 AM Changeset in webkit [15638] by
-
- 5 edits1 add in S60/trunk
2006-06-26 David Carson <david.carson@nokia.com>
Reviewed by Sachin & Zalan.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9073
Soft hyphens not breaking words
- WebCore/WebCore/khtml/rendering/break_lines.cpp (isBreakable): Added check for soft hyphen character when determining where to break a word. Based on similar change made by Hyatt in Windows port of WebKit. Added copyright notice to the file, copied from same file in current Mac WebKit tree.
Testcases
- LayoutTests/fast/js/global/encode-URI-test-mobile-expected.txt:
- LayoutTests/fast/text/basic/014-mobile-expected.txt: Updated these results as the test now passes, and the results are different.
- LayoutTests/fas/text/basic/013-mobile-expected.txt Added missing results file.
- 9:31 AM Changeset in webkit [15637] by
-
- 5 edits2 adds in S60/trunk
2006-07-26 David Carson <david.carson@nokia.com>
- Patch taken from <http://bugzilla.opendarwin.org/show_bug.cgi?id=3808> For: http://bugzilla.opendarwin.org/show_bug.cgi?id=8959
Implement location.assign.
Reviewed by Zalan.
Test cases added:
- layout-tests/fast/js/location-assign.html: Added.
- layout-tests/fast/js/location-assign-expected.txt: Added.
- layout-tests/fast/js/resources/new-location.html: Added.
- khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (WindowFunc::tryCall): (ScheduledAction::execute): (Location::get): (LocationFunc::tryCall):
- khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Location::):
- khtml/ecma/kjs_window.lut.h: (KJS::): Implement location.assign.
Jul 25, 2006:
- 8:04 PM Changeset in webkit [15636] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej, inspired by John.
- Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon
An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.
- Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
- 7:23 PM Changeset in webkit [15635] by
-
- 1 copy in tags/Safari-521.22
New tag.
- 7:18 PM Changeset in webkit [15634] by
-
- 6 edits in branches/Safari-521
Versioning
- 5:30 PM Changeset in webkit [15633] by
-
- 6 edits in trunk
WebCore:
Reviewed by timo and Darin.
<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.
WebKit:
Reviewed by timo and Darin.
<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
- WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
- 5:27 PM Changeset in webkit [15632] by
-
- 3 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-24 Adele Peterson <adele@apple.com>
Reviewed by Justin.
- Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails
Test: * editing/style/apple-style-editable-mix.html
- dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
- 5:23 PM Changeset in webkit [15631] by
-
- 3 edits in branches/Safari-521/WebKit
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback) (without re-introducing http://bugzilla.opendarwin.org/show_bug.cgi?id=10062 )
- WebView/WebLoader.h:
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
- 5:17 PM Changeset in webkit [15630] by
-
- 3 edits in branches/Safari-521/WebKit
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-24 Timothy Hatcher <timothy@apple.com>
Reviewed by John and Darin.
<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.
Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.
- WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
- WebView/WebFrameViewPrivate.h:
- 5:09 PM Changeset in webkit [15629] by
-
- 5 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-24 David Hyatt <hyatt@apple.com>
Two bug fixes.
(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.
- rendering/RenderBox.cpp: (WebCore::RenderBox::position):
(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
- rendering/RootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 5:06 PM Changeset in webkit [15628] by
-
- 2 edits in branches/Safari-521/WebCore
Merging CCC approved change from TOT to Safari-521 branch.
2006-07-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.
- manual-tests/onsearch-enter.html: Added.
- 4:13 PM Changeset in webkit [15627] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by adele
<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"
- editing/selection/select-all-005-expected.checksum: Added.
- editing/selection/select-all-005-expected.png: Added.
- editing/selection/select-all-005-expected.txt: Added.
- editing/selection/select-all-005.html: Added.
- editing/selection/select-all-006-expected.checksum: Added.
- editing/selection/select-all-006-expected.png: Added.
- editing/selection/select-all-006-expected.txt: Added.
- editing/selection/select-all-006.html: Added.
WebCore:
Reviewed by adele
<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from a non-editable html element into an editable body as a convenience.
- 3:06 PM Changeset in webkit [15626] by
-
- 2 edits in S60/trunk/WebKit
2006-07-25 brmorris <bradley.morrison@nokia.com>
Quickfix for RD_32_BROWSER build
Reviewed by Sachin.
- BrowserView/inc/WebKitToolBarInterface.h: Removed errant "\no newline at end of file" :-)
- 2:24 PM Changeset in webkit [15625] by
-
- 3 edits1 add in S60/trunk
2006-07-25 brmorris <bradley.morrison@nokia.com>
Reviewed by Sachin.
- build.bat: restores variant.cfg to default at END
- variant_default.cfg: Added.
- 2:06 PM Changeset in webkit [15624] by
-
- 3 edits in trunk/WebCore
Reviewed by darin
<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">
- dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
- page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
- 1:56 PM Changeset in webkit [15623] by
-
- 19 edits2 adds in S60/trunk
2006-07-25 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Sachin
WARNING: NO TEST CASES ADDED OR CHANGED
Implement webkit changes for toolbar.
- BrowserControl/inc/BrCtl.h:
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserControl/inc/BrCtlInterface.h:
- BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddCommandObserverL): (CBrCtl::RemoveCommandObserver): (CBrCtl::SendCommandsToClient):
- BrowserView/inc/WebKitToolBarInterface.h: Added.
- BrowserView/inc/WebKitView.h:
- BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
- BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
- BrowserView/src/WebKitToolBarInterface.cpp: Added. (CWebKitToolBarInterface::NewL): (CWebKitToolBarInterface::CWebKitToolBarInterface): (CWebKitToolBarInterface::ConstructL): (CWebKitToolBarInterface::~CWebKitToolBarInterface): (CWebKitToolBarInterface::CursorPosition): (CWebKitToolBarInterface::SetAndUpdateCursorPosition): (CWebKitToolBarInterface::SendCommandsToClient): (CWebKitToolBarInterface::ResolveUrlL): (CWebKitToolBarInterface::OpenPageViewL): (CWebKitToolBarInterface::HandleHistoryCommandL):
- BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw): (CWebKitView::DrawToolTip): (CWebKitView::LaunchToolBarL): (CWebKitView::CloseToolBarL):
- group/BWINSCW/WebKit_30U.def:
- group/BrowserView.mmp:
- group/EABI/browserengineU.def:
- group/webkit.mmp:
- rom/webkit.iby:
- rom/webkitResources.iby:
- 1:32 PM Changeset in webkit [15622] by
-
- 2 edits in S60/trunk
2006-07-25 brmorris <bradley.morrison@nokia.com>
Reviewed by zbujtas@gmail.com.
- build.bat: Correct build drive print statement.
Allow BUILD_DRIVE env var support.
- 10:26 AM Changeset in webkit [15621] by
-
- 2 edits in S60/trunk
2006-07-25 brmorris <bradley.morrison@nokia.com>
Reviewed by Zalan.
- runATF.bat: Restore emulator startup on SIGINT
- 10:23 AM Changeset in webkit [15620] by
-
- 2 edits in S60/trunk/WebKit
2006-07-25 vbradley <vincent.bradley@nokia.com>
Reviewed by Sachin & Sriram.
Changes to CreateStream to allow Plugins to make additional content requests.
- Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::DestroyStream): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamL): (CPluginWin::WriteStreamToPluginL): (CPluginWin::DestroyStreamL): (CPluginWin::LoadRequestL): (CPluginWin::SetPluginFocusL): (CPluginWin::PluginConstructedL): (CPluginData::CPluginData): (CPluginData::NewL): (CPluginData::SetUrlL):
- 8:35 AM Changeset in webkit [15619] by
-
- 7 edits in trunk/WebCore
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute
No test added because there is no change in functionality.
- bindings/js/kjs_binding.cpp: Removed valueToBooleanTreatUndefinedAsTrue() method.
- bindings/js/kjs_binding.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Removed support for ConvertUndefinedToTrue parameter attribute.
- dom/Element.h: Set default value to true for scrollIntoView() and scrollIntoViewIfNeeded() arguments.
- dom/Element.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute. Fixed name of scrollIntoViewIfNeeded() argument to match implementation.
- page/DOMWindow.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.
Jul 24, 2006:
- 10:05 PM Changeset in webkit [15618] by
-
- 9 edits in trunk
Reviewed and tweaked a bit by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9902 jsNull and NSNull not properly converted between JS and ObjC
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): Added case for converting NSNull to jsNull.
LayoutTests:
Reviewed and tweaked a bit by Darin.
- added some new tests that use "echo" including one for JavaScript null
- plugins/bindings-test-expected.txt: Added results.
- plugins/bindings-test.html: Added tests.
WebCore:
Reviewed and tweaked a bunch by Darin.
Test: plugins/bindings-test.html
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9902 jsNull and NSNull not properly converted between JS and ObjC
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Added case that converts jsNull to NSNull.
WebKitTools:
Reviewed and tweaked a bit by Darin.
- DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin isSelectorExcludedFromWebScript:]): Added "echo:". (+[ObjCPlugin webScriptNameForSelector:]): Use the name "echo" for "echo:" so it's nice to call from JavaScript. (-[ObjCPlugin echo:]): Just returns the same object -- can be used to test a round trip through Objective-C types.
- 9:39 PM Changeset in webkit [15617] by
-
- 50 edits8 adds2 deletes in trunk
LayoutTests:
Reviewed by Adele and Justin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9630 REGRESSION: some spaces typed in <textarea> are posted as non-breaking spaces
- fast/forms/textarea-type-spaces-expected.txt: Added.
- fast/forms/textarea-type-spaces.html: Added.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9939 REGRESSION: Pasting text into native text area with newline at end does not preserve newline
- fast/forms/textarea-paste-newline-expected.txt: Added.
- fast/forms/textarea-paste-newline.html: Added.
- updated tests affected by above changes, results are equivalent or better
- editing/pasteboard/4641033-expected.checksum:
- editing/pasteboard/4641033-expected.png:
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/paste-table-003-expected.checksum:
- editing/pasteboard/paste-table-003-expected.png:
- editing/pasteboard/paste-table-003-expected.txt:
- editing/pasteboard/paste-text-016-expected.txt:
- editing/pasteboard/quirks-mode-br-1-expected.txt:
- editing/pasteboard/quirks-mode-br-2-expected.txt:
- fast/forms/textarea-scrolled-type-expected.checksum:
- fast/forms/textarea-scrolled-type-expected.png:
- fast/forms/textarea-scrolled-type-expected.txt:
- changed a test to be a "dump as text" test
- fast/forms/paste-into-textarea-expected.txt:
- fast/forms/paste-into-textarea.html:
- fast/forms/paste-into-textarea-expected.checksum: Removed.
- fast/forms/paste-into-textarea-expected.png: Removed.
- changed a test to be a "dump as text" test, improved test a bit and also checked in new results
- fast/forms/textarea-scrolled-endline-caret-expected.txt:
- fast/forms/textarea-scrolled-endline-caret.html:
- fixed a test that was raising an exception every time it ran
- fast/forms/attributed-strings-expected.txt:
- fast/forms/attributed-strings.html:
- corrected checksums on a bunch of tests (pngs were right, but checksums wrong, apparently)
- editing/deleting/delete-to-select-table-expected.checksum:
- editing/selection/3690719-expected.checksum:
- editing/selection/clear-selection-expected.checksum:
- editing/undo/undo-misspellings-expected.checksum:
- added some missing pixel test results
- editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
- editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
- editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
- editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
WebCore:
Reviewed by Adele and Justin.
- fix <rdar://problem/4613616> REGRESSION: some spaces typed in <textarea> are posted as non-breaking spaces (9630) http://bugzilla.opendarwin.org/show_bug.cgi?id=9630
- also fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9939 REGRESSION: Pasting text into native text area with newline at end does not preserve newline
- removed some uses of DeprecatedPtrList in the markup code
Test: fast/forms/textarea-type-spaces.html
Test: fast/forms/textarea-paste-newline.html
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]): Updated call to pass a range -- in this case it is the range of the entire document, so this will not handle the whitespace properly.
- bridge/mac/WebCoreFrameBridge.h: Added range context parameter to the documentFragmentWithText: method, so we can handle whitespace properly.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nodesFromList:]): Changed from DeprecatedPtrList to Vector. (-[WebCoreFrameBridge markupStringFromNode:nodes:]): Ditto. (-[WebCoreFrameBridge markupStringFromRange:nodes:]): Ditto. (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): Added range context parameter -- pass it on to createFragmentFromText. (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): Changed from DeprecatedPtrList to Vector. (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]): Pass the range of the current selection as context when creating the fragment.
- dom/Position.cpp: (WebCore::Position::inRenderedText): Replace range check with a call to the new containsCaretOffset function -- helps make the caret work right when it is past the end of the last line in a textarea.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Don't do anything if the style does not call for collapsing whitespace. (WebCore::CompositeEditCommand::rebalanceWhitespace): Call replaceWhitespaceAt to share code, including the new logic mentioned above.
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use a text node instead of a break element when inserting and the style is preserveNewline.
- editing/JSEditor.cpp: (WebCore::execRemoveFormat): Pass the selection range to createFragmentFromText.
- editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doApply): Assert that we're in a style that collapses whitespace. It's the caller's responsibility not to call otherwise.
- editing/ReplaceSelectionCommand.h: Removed unused destructor, type, isSingleTextNode, isTreeFragment, m_type, and added a context parameter to inertFragmentForTestRendering. Also changed the constructor to take a selection rather than a pointer to the root editable element, replaced removeEndBRIfNeeded with shouldRemoveEndBR and removed an unused parameter from shouldMergeEnd.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Removed code to set up m_type. Compute root editable element from passed-in selection. Used the start of the selection as a base node for style purposes for the test rendering. Removed the special case "single text node" alternative to createFragmentFromText in the plain text case, since createFragmentFromText now handles that correctly. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the whitespace property from the source location when creating a temporary element for test rendering. (WebCore::ReplacementFragment::shouldMergeEnd): Removed unneeded boolean parameter fragmentHadInterchangeNewlineAtEnd, which is always false. (WebCore::ReplaceSelectionCommand::doApply): Update for ReplacementFragment changes, change code to not remove end BR when it can be re-used instead, don't call the paragraph separator insertion when the position is at the start of a paragraph already, removed redundant computation of identical "next" value, removed unneeded boolean parameter to shouldMergeEnd, add case for merging when all we need to do is to delete a newline character, removed unneeded code to set insertionPos after all code that uses it, and use spaces instead of non-breaking spaces when doing smart paste if the context is one where we do not collapse white space. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renamed and changed to return a boolean instead of doing the removal.
- editing/markup.h: Use Vector instead of DeprecatedPtrList. Change the createFragmentFromText function to take a range for context instead of a document.
- editing/markup.cpp: (WebCore::markup): Use Vector instead of DeprecatedPtrList. (WebCore::createMarkup): Ditto. (WebCore::createParagraphContentsFromString): Remove unneeded document parameter and changed a couple places to use isEmpty instead of comparing with "". (WebCore::createFragmentFromText): Given the new context parameter, if the context is one that preserves newlines, then use "\n" instead of <br> elements. (WebCore::createFragmentFromNodes): Use Vector instead of DeprecatedPtrList.
- html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Do not use <br> elements if the context of this node is one where we preserve newlines.
- rendering/InlineTextBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::containsCaretOffset): Added. Implements the appropriate rule for determining if a caret position is in this line or not. Returns true for both one line and the next in cases where affinity must be considered to determine which line the caret is on.
- rendering/RenderText.h: Make atLineWrap no longer be a member function.
- rendering/RenderText.cpp: (WebCore::atLineWrap): Remove special rule about preserveNewline and isLineBreak, which will no longer apply due to the new containsCaretOffset function logic. (WebCore::RenderText::caretRect): Use containsCaretOffset. (WebCore::RenderText::inlineBox): Ditto.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): Make a placeholder <br> element after calling setInnerText so that the last newline in the string has the effect we expect outside the HTML world (an additional line). (WebCore::RenderTextControl::setSelectionRange): Set granularity of the selection too. The layout tests caught this problem, which needs a better solution long term. (WebCore::RenderTextControl::text): Call textContent with the parameter false so it will not include newlines for <br> elements. Now the only <br> element that will ever be in the shadow DOM tree is the one to prevent collapsing, and that one should not show up in the text value.
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Took a rule that specifically called out the pre whitespace mode and made it work for all the modes that preserve newlines. This makes sure we get a last line box for text after the last "\n" even in cases where there is no <br> afterward.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Added assertions to make sure we don't do anything when we're not collapsing whitespace.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setDefaultValue): Changed to use Vector instead of DeprecatedPtrList.
- editing/HTMLInterchange.cpp: Removed obsolete comment.
- loader/Cache.h: Removed a stray include.
WebKit:
Reviewed by Adele and Justin.
- update for change to require context when creating fragments from text (needed to handle whitespace properly)
- WebView/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Added context parameter, pass through to bridge. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Pass selection range as context when calling above method. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Pass drag caret as context when calling above method.
- 8:40 PM Changeset in webkit [15616] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Justin.
- Test for <rdar://problem/4632132> Changing style of content with mixed editability fails
- editing/style/apple-style-editable-mix-expected.checksum: Added.
- editing/style/apple-style-editable-mix-expected.png: Added.
- editing/style/apple-style-editable-mix-expected.txt: Added.
- editing/style/apple-style-editable-mix.html: Added.
WebCore:
Reviewed by Justin.
- Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails
Test: * editing/style/apple-style-editable-mix.html
- dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
- 8:37 PM Changeset in webkit [15615] by
-
- 3 edits in trunk/WebKit
Reviewed by Geoff.
- fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback) (without re-introducing http://bugzilla.opendarwin.org/show_bug.cgi?id=10062 )
- WebView/WebLoader.h:
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
- 6:11 PM Changeset in webkit [15614] by
-
- 3 edits2 adds in trunk/WebCore
Reviewed by Hyatt.
- implement String::createCFString
- WebCore.xcodeproj/project.pbxproj: Added StringImplMac.mm and StringMac.mm.
- bindings/objc/DOMInternal.mm: Moved NSString conversion functions out of here.
- platform/mac/StringImplMac.mm: Added. Moved NSString conversion members here and added the CFStringRef ones.
- platform/mac/StringMac.mm: Added. Ditto.
- 5:22 PM Changeset in webkit [15613] by
-
- 1 copy in tags/Safari-521.21
New tag.
- 4:16 PM Changeset in webkit [15612] by
-
- 6 edits in trunk/WebCore
Two bug fixes.
(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.
- rendering/RenderBox.cpp: (WebCore::RenderBox::position):
(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
- rendering/RootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 3:50 PM Changeset in webkit [15611] by
-
- 2 edits in branches/Safari-521/WebKit
Correcting WebKit versioning.
- 3:50 PM Changeset in webkit [15610] by
-
- 2 edits in trunk/WebKit
2006-07-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Tim O.
- Misc/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): Make an array of the keys and iterate through it to avoid modifying the dictionary while enumerating it.
- 3:47 PM Changeset in webkit [15609] by
-
- 4 edits in branches/Safari-521
Versioning
- 1:55 PM Changeset in webkit [15608] by
-
- 1 edit in trunk/WebCore/manual-tests/onsearch-enter.html
Add a newline
- 1:48 PM Changeset in webkit [15607] by
-
- 2 edits1 add in trunk/WebCore
2006-07-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.
- manual-tests/onsearch-enter.html: Added.
- 1:25 PM Changeset in webkit [15606] by
-
- 2 edits in S60/trunk/WebCore
- bridge/WebCoreBridge.cpp:
(CWebCoreBridge::GetNextRenderTextForSmartLinksL): Fix ref counting of iSmartLinkNode
- 12:12 PM Changeset in webkit [15605] by
-
- 3 edits in trunk/WebKit
Reviewed by John and Darin.
<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.
Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.
- WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
- WebView/WebFrameViewPrivate.h:
- 11:13 AM Changeset in webkit [15604] by
-
- 30 edits4 adds in S60/trunk
2006-07-24 brmorris <bradley.morrison@nokia.com>
Reviewed by Sachin.
Implement Smart Text recognition / context options.
- 10:26 AM Changeset in webkit [15603] by
-
- 3 edits4 adds in trunk
Fix by Dave MacLachlan, reviewed by Darin and Alexey.
Fix for: <http://bugzilla.opendarwin.org/show_bug.cgi?id=8425>
and <http://bugzilla.opendarwin.org/show_bug.cgi?id=6947>
Test: svg/custom/non-opaque-filters.svg
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): We create an autorelease pool so we can control the deallocation of the CIContext that we're creating. The CIContext retains the CGContext that you pass it internally so when the CIContext is released, the CGContext is released as well. This is all fine and dandy unless you wrap the creation of the CIFilter with a pair of CGBegin/EndTransparencyLayer calls which swap the context out from underneath you. So if you start with context A, CGBeginTransparencyLayer swaps it out and gives you B. You create a CIFilter with it and add a reference to B. CGEndTransparencyLayer swaps out B and gives you back A. Autorelease pool comes and cleans up the Filter, and calls release on A, but A never got the refcount in the first place. B did. BOOM! So we create a pool, then do a retain, then release the pool so that we don't have to worry about the pool releasing it at a later time. See <rdar://problem/4647735> for reduction of CGEndTransparencyLayer case
- 9:55 AM Changeset in webkit [15602] by
-
- 4 edits4 adds in trunk
Fix by Mitz Pettel, reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Incomplete repaint when changing an inline's border
Test: fast/repaint/line-overflow.html
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added repaintTop and repaintBottom variables to track the vertical edges of the area that changed, accounting for lines that were deleted, inserted or moved. Removed unnecessary updating of m_overflowHeight. (WebCore::RenderBlock::determineStartPosition): Removed unnecessary updating of m_overflowHeight. (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): Added repaintTop and repaintBottom arguments, which this method updates to account for deleted lines. (WebCore::RenderBlock::checkLinesForOverflow): Removed outdated FIXME.
- 9:36 AM Changeset in webkit [15601] by
-
- 2 edits in trunk
Land the ChangeLogs, too.
- 9:21 AM Changeset in webkit [15600] by
-
- 1 edit4 adds in trunk
Fix by Mitz Pettel, reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10075 REGRESSION: Reversed pop-up text in visually-ordered Hebrew pages
Test: fast/forms/select-visual-hebrew.html
- css/html4.css: Set "-webkit-rtl-ordering: logical" on select elements.
- 9:03 AM Changeset in webkit [15599] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10060
Improve iExploder results parsing
- Scripts/run-iexploder-tests: Fix Apach logs parsing to produce a correct results in random mode, too.
- 8:58 AM Changeset in webkit [15598] by
-
- 4 edits in trunk
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
No test case possible.
WebCore:
- page/Frame.cpp: (WebCore::Frame::begin): Give PDF plugins a chance to handle frame content, before ImageDocument claims it.
WebKit:
- WebView/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView, make sure to initialize the plugin database, in case a plugin wants to handle it.
- 8:44 AM Changeset in webkit [15597] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10083 REGRESSION (r15584): editing/selection/select-from-textfield-outwards failing
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Added back change from the fix for bug 9312: For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
- 8:41 AM Changeset in webkit [15596] by
-
- 2 edits in branches/Safari-521/WebCore
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10083 REGRESSION (r15584): editing/selection/select-from-textfield-outwards failing
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Added back change from the fix for bug 9312: For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
- 6:13 AM Changeset in webkit [15595] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4258
Date().toString() only includes GMT offset, not timezone string
Use the info in tm_zone to append timezone abbreviation
to Date().toString().
- kjs/date_object.cpp: (KJS::formatTime):
- 4:45 AM Changeset in webkit [15594] by
-
- 2 edits3 adds in trunk
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5257
setYear() does not match FireFox/IE behavior
Make sure the right values end up in tm_year.
- kjs/date_object.cpp: (KJS::formatTime):
Jul 23, 2006:
- 11:06 PM Changeset in webkit [15593] by
-
- 16 edits in trunk
Reviewed by Maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
JavaScriptCore portion of the fix.
- JavaScriptCore.exp: Update symbol for change in argument type.
- kjs/debugger.cpp: (Debugger::detach): Clear map of recent exceptions. (Debugger::hasHandledException): Track the most recent exception thrown by an interpreter. (Debugger::exception): Change exception argument to a JSValue.
- kjs/debugger.h:
- kjs/nodes.cpp: (Node::debugExceptionIfNeeded): Notify the debugger of an exception if it hasn't seen it before. (ThrowNode::execute): Notify the debugger that an exception is being thrown.
- kjs/nodes.h:
2006-07-23 Geoffrey Garen <ggaren@apple.com>
Patch by Eric Albert, reviewed by Darin and me.
- Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)
- bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
- kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
- JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!
WebCore:
Reviewed by maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
WebCore portion of the fix.
- bridge/mac/WebCoreScriptDebugger.h: (-[WebScriptDebugger exceptionRaised:sourceId:line::]): Add delegate method.
- bridge/mac/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::exception): Call delegate method when an exception is raised.
WebKit:
Reviewed by Maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
WebKit portion of the fix.
- DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
- DefaultDelegates/WebScriptDebugServer.h:
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Notify listeners that an exception has been raised.
- WebView/WebScriptDebugDelegate.h:
- WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame exceptionRaised:sourceId:line:]): Dispatch through to delegate and WebScriptDebugServer.
- 8:21 PM Changeset in webkit [15592] by
-
- 2 edits in branches/Safari-521/WebCore
Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).
- editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
- 7:53 PM Changeset in webkit [15591] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).
- editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
- 7:51 PM Changeset in webkit [15590] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her.
- editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
- 7:43 PM Changeset in webkit [15589] by
-
- 13 edits4 deletes in branches/Safari-521
Rolling out CCC denied changes. r15553, r15536, r15529, r15455 and r15435.
- 6:41 PM Changeset in webkit [15588] by
-
- 5 copies in branches/Safari-521
New branch
- 5:16 PM Changeset in webkit [15587] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by timo.
<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion
- editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
- editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
- editing/deleting/delete-mixed-editable-content-001-expected.txt: Added.
- editing/deleting/delete-mixed-editable-content-001.html: Added.
WebCore:
Reviewed by timo.
<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion
- Test: editing/deleting/delete-mixed-editable-content-001.html
- editing/visible_units.cpp: (WebCore::startOfParagraph): Respect editable boundary the same way endOfParagraph does.
- 4:40 PM Changeset in webkit [15586] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- Fix for <rdar://problem/4646276> CrashTracer: 7 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 155
- WebView/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): needsDisplay was returning NO even though the view has a dirty rect (see <rdar://problem/4647062>). Since we know about the dirty rect, we don't actually need to check needsDisplay.
- 4:36 PM Changeset in webkit [15585] by
-
- 7 edits in trunk/WebCore
Reviewed by Maciej. (Patch by me, Maciej, and Harrison.)
Fix for <rdar://problem/4529398> WebCore crashes when pasting rich
text - WebCore::InlineBox::root()
The initial rendering crash was due to a render object having a
stale reference to an inline box that had already been deleted and
then recreated in the exact same location in memory. (Crazy, I
know.) The situation seemed pretty specific to list markers
according to Hyatt according to Maciej, so that is what I patched
specifically. Fixing this crash unearthed a separate editing crash
where we were trying to insert a block into itself. I worked on
that with Maciej and Harrison, and Harrison came up with a fix.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): This is the fix for the editing crash. If paragraphStart is an atomic node, insert the new block into the parent instead.
- rendering/InlineBox.cpp: (WebCore::InlineBox::isChildOfParent): This function is for posterity. It will help keep the linebox tree in check.
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine): Added assert. (WebCore::InlineFlowBox::deleteLine): Added assert.
- rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): If this has a parent, call removeChild on this. (WebCore::ListMarkerBox::operator delete):
- rendering/ListMarkerBox.h:
- 4:17 PM Changeset in webkit [15584] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
fixed <rdar://problem/4617841> REGRESSION (NativeTextField): You can move keyboard focus to a field without getting insertion point
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): removed some unnecessary vertical position checks and added a fudge factor to be more forgiving for clicks near lines.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): added implementation
- rendering/RenderTextControl.h: added function protocol
- 2:59 PM Changeset in webkit [15583] by
-
- 4 edits in trunk/JavaScriptCore
2006-07-23 Geoffrey Garen <ggaren@apple.com>
Patch by Eric Albert, reviewed by Darin and me.
- Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)
- bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
- kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
- JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!
- 10:28 AM Changeset in webkit [15582] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Updating fix from last checkin.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Only tell the view about this flexbox if there isn't another flexbox already cached.
- 1:52 AM Changeset in webkit [15581] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
Test for: <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling
- fast/forms/textarea-scrolled-type-expected.checksum: Added.
- fast/forms/textarea-scrolled-type-expected.png: Added.
- fast/forms/textarea-scrolled-type-expected.txt: Added.
- fast/forms/textarea-scrolled-type.html: Added.
WebCore:
Reviewed by Maciej.
- Fix for <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Don't updateScrollInfoAfterLayout if an ancestor flexible box is just on its first layout.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): ditto. (WebCore::RenderFlexibleBox::layoutVerticalBox): Let the view know if this flex box is doing its first pass at layout.
- rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Caches a flexible box that's doing its first layout.
- rendering/RenderView.h: (WebCore::RenderView::setFlexBoxInFirstLayout): (WebCore::RenderView::flexBoxInFirstLayout):
Jul 22, 2006:
- 6:37 PM Changeset in webkit [15580] by
-
- 2 edits in trunk/WebKit
Rolling out r15572.
Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10062
2006-07-21 Timothy Hatcher <timothy@apple.com>
Reviewed by Maciej.
<rdar://problem/4609195> Help Viewer loads empty window
(not getting didFailLoadingWithError: callback)
Call super's didFailWithError before _receivedMainResourceError
because _receivedMainResourceError will cause the datasource's
frame to be set to nil before the didFailLoadingWithError delegate
callback is sent. (This order is needed now that WebDataSource does
not hold on to the WebView; it uses the WebFrame to get to the WebView.
If the WebFrame is nil we can't get to the WebView's resource load delegate.)
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]):
- 4:06 PM Changeset in webkit [15579] by
-
- 2 edits in tags/Safari-521.20/WebKit
Merging in '<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu' and build fixes.
- 3:56 PM Changeset in webkit [15578] by
-
- 2 edits in trunk/WebKit
Reviewed by Adele.
<rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu
Show the editing context menu if the WebView is editible.
The original change only checked if the DOM element was editable,
and isContentEditable returns NO if entire WebView is editable.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- 3:45 PM Changeset in webkit [15577] by
-
- 4 edits in tags/Safari-521.20/WebCore/platform
Rolling out r15529 because of <rdar://problem/4646196> REGRESSION: Artifacts are painted around Business, Calendar, Address Book, Translation, and Stocks
- 3:24 PM Changeset in webkit [15576] by
-
- 1 edit in tags/Safari-521.20/WebCore/platform/cg/GraphicsContextCG.cpp
Rolling back in <rdar://problem/4616595> REGRESSION: Problems with world clock widget clock hand motion on 9A211 + 4604574 now that is was CCC approved.
- 10:45 AM Changeset in webkit [15575] by
-
- 9 edits in tags/Safari-521.20
Rolling out changes that are not CCC approved. r15435, r15455, r15470 and r15553
- 10:41 AM Changeset in webkit [15574] by
-
- 1 edit in trunk/WebKit/WebInspector/WebInspector.m
Build fix.
- 12:39 AM Changeset in webkit [15573] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10038
REGRESSION: Length of navigator.mimeTypes collection returns number of installed plugins, not number
of registered mime types
Test: fast/js/navigator-mimeTypes-length.html
- bindings/js/kjs_navigator.cpp: (KJS::MimeTypes::getValueProperty): Return the length of the mime types vector, not the plugins one. (KJS::MimeTypes::getOwnPropertySlot): Fixed another typo, which prevented MimeTypes::getValueProperty() from even being called.
Jul 21, 2006:
- 11:34 PM Changeset in webkit [15572] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
<rdar://problem/4609195> Help Viewer loads empty window
(not getting didFailLoadingWithError: callback)
Call super's didFailWithError before _receivedMainResourceError
because _receivedMainResourceError will cause the datasource's
frame to be set to nil before the didFailLoadingWithError delegate
callback is sent. (This order is needed now that WebDataSource does
not hold on to the WebView; it uses the WebFrame to get to the WebView.
If the WebFrame is nil we can't get to the WebView's resource load delegate.)
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]):
- 10:31 PM Changeset in webkit [15571] by
-
- 12 edits1 add in trunk/WebCore
Reviewed by Adele and Tim Omernick.
<rdar://problem/4641004> 9A224: Safari crashes in WebCore::RenderMenuList::showPopup when changing a input select field to input text field
Couldn't figure out how to make layout test, here's a manual test:
- manual-tests/remove-select-onchange.html: Added.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup): Don't add the RenderPopupMenu to the render tree so it doesn't get destroyed if we do.
The remaining changes are to let the RenderPopupMenu know its menu list w/o having
to be in the render tree:
- rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::RenderPopupMenu):
- rendering/RenderPopupMenu.h: (WebCore::RenderPopupMenu::menuList):
- rendering/RenderPopupMenuMac.h:
- rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::RenderPopupMenuMac):
- rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::createPopupMenu):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
- rendering/RenderThemeWin.h:
- 8:05 PM Changeset in webkit [15570] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removed a stray conflict marker.
- 7:24 PM Changeset in webkit [15569] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
Test for: <rdar://problem/4643238> REGRESSION: Can't set insertion point at the end of a line of text
- fast/forms/textarea-scrolled-endline-caret-expected.txt: Added.
- fast/forms/textarea-scrolled-endline-caret.html: Added.
WebCore:
Reviewed by Darin.
Fix for: <rdar://problem/4643238> REGRESSION: Can't set insertion point at the end of a line of text
Test: fast/forms/textarea-scrolled-endline-caret.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): When looking for the closest line box, take the scroll offset into account.
- 7:17 PM Changeset in webkit [15568] by
-
- 1 edit2 adds in trunk/LayoutTests
RS by Adele.
Test for whether focusing and/or blurring a frame before its content has loaded causes
a crash. <rdar://problem/4632505> REGRESSION: Crash at
WebCore::Widget::getView() const + 6
- http/tests/incremental/frame-focus-before-load-expected.txt: Added.
- http/tests/incremental/frame-focus-before-load.html: Added.
- 7:14 PM Changeset in webkit [15567] by
-
- 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm
minor comment fixup
- 6:48 PM Changeset in webkit [15566] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff & Maciej.
<rdar://problem/4632505> REGRESSION: Crash at WebCore::Widget::getView() const + 6
Geoff is working on a layout test for this.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow): Check for a NULL view. The view can be NULL if the frame has not yet loaded any data. This fixes the crash, but the behavior is still wrong -- we should focus the frame once it gets a view. I've filed <rdar://problem/4645685> to track that. It's not as urgent as this crasher.
- 5:45 PM Changeset in webkit [15565] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/4523976> REGRESSION (NativeTextField): Crash occurs when choosing "Undo Typing" after typing and setting the value
- fast/forms/text-field-setvalue-crash-expected.txt: Added.
- fast/forms/text-field-setvalue-crash.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/4523976> REGRESSION (NativeTextField): Crash occurs when choosing "Undo Typing" after typing and setting the value
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): Clear the undo chain when the text control contents have been set programmatically.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::clearUndoRedoOperations): Before clearing undo stack, close all open undo groups and then open an equal number, since otherwise NSUndoManager ends up in an inconsistent state leading to uncaught ObjC exceptions.
- 4:47 PM Changeset in webkit [15564] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Just moving this assertion down a couple of lines. It was hitting
every time you try to print a page because we put it too early in
the function.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
- 4:38 PM Changeset in webkit [15563] by
-
- 10 edits4 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4548238>
REGRESSION: Can't remove the first OL/UL list item in a Mail's compose window
- editing/deleting/delete-first-list-item-expected.checksum: Added.
- editing/deleting/delete-first-list-item-expected.png: Added.
- editing/deleting/delete-first-list-item-expected.txt: Added.
- editing/deleting/delete-first-list-item.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4548238>
REGRESSION: Can't remove the first OL/UL list item in a Mail's compose window
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Moved from InsertParagraphSeparator. Does its own typing style restoration.
- editing/CompositeEditCommand.h:
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Call breakOutOfEmptyListItem.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Call breakOutOfEmptyListItem if the endingSelection is at the start of an editable region.
- editing/htmlediting.cpp: (WebCore::embeddedSublist): Moved from InsertParagraphSeparator. (WebCore::appendedSublist): Ditto. (WebCore::enclosingEmptyListItem): Ditto.
- editing/htmlediting.h:
- 4:10 PM Changeset in webkit [15562] by
-
- 10 copies in tags/Safari-521.20
New tag.
- 3:55 PM Changeset in webkit [15561] by
-
- 9 edits in /
Versioning
- 2:36 PM Changeset in webkit [15560] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/4607572> REGRESSION (521.10.1 - 521.13): most context menu items missing when a form field is focused (common on google.com) (9680)
Do not use _isEditable call since that only checks if the current
selection or frame is editible. We now check if the currently clicked element
is a content editible area, a textarea, an isindex or an input element that
return YES to _isTextField.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- 1:16 PM Changeset in webkit [15559] by
-
- 2 edits in trunk/WebCore
Reviewed by Beth Dakin & John Sullivan.
<rdar://problem/4633717> 9A218: Reproducible crash in -[NSScroller mouseDown:]
Beth is in the middle of making a layout test for this; she will land it soon.
- platform/mac/ScrollBarMac.mm: (ScrollBar::~ScrollBar): Call Widget::removeFromSuperview() rather than -removeFromSuperview directly on the scroll bar view. Widget::removeFromSuperview() obeys the "mustStayInWindow" flag, which is set while tracking the mouse in view-based widgets to prevent their destruction while the tracking is in progress. I searched around WebCore and this is the only Widget subclass that directly removes its view rather than using removeFromSuperview().
- 1:01 PM Changeset in webkit [15558] by
-
- 9 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- editing/selection/select-all-iframe-expected.txt:
- editing/selection/select-from-textfield-outwards-expected.checksum: Added.
- editing/selection/select-from-textfield-outwards-expected.png: Added.
- editing/selection/select-from-textfield-outwards-expected.txt: Added.
- editing/selection/select-from-textfield-outwards.html: Added.
- fast/events/drag-outside-window-expected.txt:
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9312 REGRESSION: Selection bug in new text fields when selecting past the first letter
Test: editing/selection/select-from-textfield-outwards.html
- editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added code to handle the case where the selection starts (resp. ends) in the last (resp. first) visual position inside an editable root.
- editing/htmlediting.cpp: (WebCore::comparePositions): Fixed the case of comparing a position inside a shadow tree with a position in the shadow ancestor.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
- rendering/RenderObject.cpp: (WebCore::RenderObject::caretMaxOffset): Changed to return 1 for replaced objects.
- rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed to return the last position in the lowest text box if the y coordinate is below all text boxes.
- 11:50 AM Changeset in webkit [15557] by
-
- 7 edits3 adds in trunk
Reviewed by Darin.
- Added support for strings that masquerade as undefined. Currently used by WebCore to implement undetectable style.filter.
The name is a little long, but it's only used in one line of code, so I
thought clarity should win over brevity.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/object.h:
- kjs/string_object.h: (KJS::StringInstanceThatMasqueradesAsUndefined::StringInstanceThatMasqueradesAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::masqueradeAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::toBoolean):
LayoutTests:
Test for undetectable style.filter property.
- fast/dom/undetectable-style-filter-expected.txt: Added.
- fast/dom/undetectable-style-filter.html: Added.
WebCore:
Reviewed by Darin.
- Fixed <rdar://problem/4507265> REGRESSION: overlays don't work on HousingMaps.com (Google Maps-based site)
- Made style.filter undetectable, like document.all.
Unfortunately, the SVG spec-makers invented a CSS attribute named 'filter',
which conflicts with IE's custom CSS attribute by the same name. Web programs
like the Google maps API test for style.filter, and assume it's the IE
style.filter if they find it, so we need to make style.filter undetectable
to avoid breaking them.
An alternative solution would be to hotwire a delorean, go back in time,
and beg the web standards makers to make standards that work on the web.
- bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
- 11:39 AM Changeset in webkit [15556] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by john
<rdar://problem/4641033>
REGRESSION: Pasting from web pages into Mail (or Blot) often loses most of the content
- editing/pasteboard/4641033-expected.checksum: Added.
- editing/pasteboard/4641033-expected.png: Added.
- editing/pasteboard/4641033-expected.txt: Added.
- editing/pasteboard/4641033.html: Added.
WebCore:
Reviewed by john
<rdar://problem/4641033>
REGRESSION: Pasting from web pages into Mail (or Blot) often loses most of the content
- editing/markup.cpp: (WebCore::createMarkup): We surround the currently accumulated markup with markup for ancestors of the startNode when the pre-order traversal leaves the trees rooted at those ancestors. We assumed that any ancestors of the current node not in the ancestorsToClose list were those kind of ancestors. But we don't add renderer-less containers to the ancestorsToClose list. So, we were incorrectly surrounding the currently accumulated markup with markup for render-less containers. Most of the content at apple.com was being put inside an <optgroup> inside a <select> element. Then on Paste createContextualFragment would drop it.
- 11:06 AM Changeset in webkit [15555] by
-
- 1 edit1 delete in S60/trunk/JavaScriptCore
2006-07-21 brmorris <bradley.morrison@nokia.com>
Reviewed by Zalan.
- JavaScriptCore/.cvsignore: Removed.
- 8:28 AM Changeset in webkit [15554] by
-
- 15 edits25 adds3 deletes in S60/trunk
2006-07-20 brmorris <bradley.morrison@nokia.com>
Reviewed by Sachin/Zalan.
- Distribution.Policy.S60 files: Added.
- Cleaned JavaScriptCore
- Minor fixes (see ChangeLogs)
- 12:56 AM Changeset in webkit [15553] by
-
- 5 edits in trunk/WebCore
2006-07-21 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
- dom/Document.h: (WebCore::Document::):
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::addEventListener):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Only dispatch overflowchanged events if overflowchanged event listeners have been registered on the document.
- 12:52 AM Changeset in webkit [15552] by
-
- 4 edits2 adds in trunk
WebCore:
2006-07-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
<rdar://problem/4637807> REGRESSION: "Features & Options" page at volvocars.us fails
- xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): Turns out parameters never worked. String parameters need to be escaped so we create a transform context, add the parameters to it quoted and then use xsltApplyStylesheetUser which lets us pass the transform context to it. This also works around a bug in libxslt where a hash table isn't allocated.
LayoutTests:
2006-07-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
<rdar://problem/4637807> REGRESSION: "Features & Options" page at volvocars.us fails
- fast/xsl/xslt-processer-expected.txt: This passes now.
- fast/xsl/xslt-string-parameters-expected.txt: Added.
- fast/xsl/xslt-string-parameters.html: Added.
Jul 20, 2006:
- 10:30 PM Changeset in webkit [15551] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Tim Omernick.
Fixed <rdar://problem/4621649> repro crash: Upload link causes crash on pages.google.com in Frame::nodeForWidget
added manual test because there is no way to change the value of an <input type=file> via the DOM. It's not supported because it's a security risk.
- manual-tests/remove-input-file-onchange.html: Added.
- platform/mac/FileButtonMac.mm: (-[WebFileChooserButton chooseFilename:]): swapped the calls to changeFilename and bridgeForWidget because changeFilename will destroy the widget that is accessed in bridgeForWidget
- 10:18 PM Changeset in webkit [15550] by
-
- 5 edits3 adds in trunk/WebCore
Reviewed by Adele.
Fixed <rdar://problem/4532113> REGRESSION (NativeTextField): Crash occurs after modifying field then reloading page -[FormDelegate frameLayoutHasChanged:]
added a manual test because of the need to use AutoFill.
- dom/Node.h: (WebCore::Node::aboutToUnload): added virtual function prototype
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::aboutToUnload): added implementation that sends textFieldDidEndEditing notification
- html/HTMLInputElement.h: added virtual function prototype
- manual-tests/input-type-file-autocomplete-frame-1.html: Added.
- manual-tests/input-type-file-autocomplete-frame-2.html: Added.
- manual-tests/input-type-file-autocomplete-refresh.html: Added.
- page/Frame.cpp: (WebCore::Frame::stopLoading): before unloading, call aboutToUnload on the current focused node
- 8:11 PM Changeset in webkit [15549] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Beth and John.
- fix recently broken layout tests that need updated results or test changes:
For these three, the selection ranges changed (for the better) due to my input
editing fix.
- editing/selection/3690703-2-expected.txt:
- editing/selection/3690703-expected.txt:
- fast/text/textIteratorNilRenderer-expected.txt:
For this one, DumpRenderTree no longer shows resize corners by default, so turned
it on via style.
- fast/css/resize-corner-tracking.html:
- 6:16 PM Changeset in webkit [15548] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej
fixed <rdar://problem/4611303> REGRESSION: repro crash in WebCore::EventTargetNode::dispatchWindowEvent at aeropostale.com
There was an attempt to deref an EventListener that got cleaned up in GC. Changing Document's EventListener list from
vanilla ptrs to refptrs to prevent GC, following EventTargetNode's proven example.
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::clear): (WebCore::Document::handleWindowEvent): (WebCore::Document::getHTMLWindowEventListener): (WebCore::Document::removeHTMLWindowEventListener): (WebCore::Document::removeWindowEventListener): (WebCore::Document::hasWindowEventListener): Changed all of the list iterators to work with RefPtrs instead of vanilla ptrs
- dom/Document.h: Changed the EventListener list to be a vanilla pointer list to a refptr list
- 6:07 PM Changeset in webkit [15547] by
-
- 7 edits in trunk
WebCore:
Reviewed by Maciej
- WebCore part of fix for: <rdar://problem/4557386> REGRESSION (419.3-521.19): repro Safari world leak involving closing tabs after clicking in a web page
- bridge/mac/WebCoreFrameBridge.h: (-[WebCoreFrameBridge textViewWasFirstResponderAtMouseDownTime:]) renamed to be more specific (formerly wasFirstResponderAtMouseDownTime:)
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget): updated for name change
WebKit:
Reviewed by Maciej
- WebKit part of fix for: <rdar://problem/4557386> REGRESSION (419.3-521.19): repro Safari world leak involving closing tabs after clicking in a web page
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]): renamed to be more specific (formerly wasFirstResponderAtMouseDownTime:)
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): updated for name change (-[NSArray _setMouseDownEvent:]): Now only retains the first responder if it's a textView, since that's the only case that the only client actually cares about. This avoids a reference cycle caused by retaining self. This is the only substantive part of the patch; all the rest is just renaming for clarity, and comments. (-[NSArray mouseDown:]): updated for name change (-[WebHTMLView _textViewWasFirstResponderAtMouseDownTime:]): renamed to be more specific (formerly _wasFirstResponderAtMouseDownTime:)
- 2:52 PM Changeset in webkit [15546] by
-
- 2 edits in trunk/JavaScriptCore
2006-07-20 Steve Falkenburg <sfalken@apple.com>
Fix the build
- kjs/function.cpp: (KJS::escapeStringForPrettyPrinting):
- 2:23 PM Changeset in webkit [15545] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix an old typo
- 12:20 PM Changeset in webkit [15544] by
-
- 9 edits1 add in trunk/WebCore
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8272
Use of window.open & window.close can cause crash
- platform/PlatformMouseEvent.h: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/mac/PlatformMouseEventMac.mm: (WebCore::PlatformMouseEvent::PlatformMouseEvent): The default constructor now creates a "zero" event, and a new one was added to create the "current" one.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent):
- rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::clicked): Updated for the above changes.
- platform/gdk/MouseEventGdk.cpp:
- platform/gdk/TemporaryLinkStubs.cpp: (PlatformMouseEvent::PlatformMouseEvent):
- platform/win/MouseEventWin.cpp:
- platform/win/TemporaryLinkStubs.cpp: (PlatformMouseEvent::PlatformMouseEvent): Trying not to break other platforms.
- manual-tests/invalid-mouse-event.html: Added.
- 2:03 AM Changeset in webkit [15543] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- delete line that I only commented in the last patch - meant to do this before landing
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::close):
- 1:47 AM Changeset in webkit [15542] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
- fixed <rdar://problem/4634484> REGRESSION: Project Change Request form should have vertical scroll bar, but doesn't
I couldn't figure out how to make an automated test case for this,
or even a manual one. It seems to be timing-related in some way.
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::close): detach the child frame from its element, not the frame containing this element.
- 12:49 AM Changeset in webkit [15541] by
-
- 2 edits in trunk/WebCore
2006-07-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): Hold a ref to the node in case it gets destroyed by an event handler.
Jul 19, 2006:
- 10:11 PM Changeset in webkit [15540] by
-
- 1 edit in tags/Safari-521.19/JavaScriptCore/Info.plist
Versioning
- 10:02 PM Changeset in webkit [15539] by
-
- 3 edits in tags/Safari-521.19
Versioning
- 9:58 PM Changeset in webkit [15538] by
-
- 16 edits3 copies17 deletes in tags/Safari-521.19
Rolled out changes that CCC denied.
<rdar://problem/4404312> REGRESSION: KOI8-U encoding no longer supported (4195)
<rdar://problem/4613467> REGRESSION: RegEx seems broken for hex escaped non breaking space (8395)
<rdar://problem/4613948> REGRESSION: Check Spelling does not work in textarea elements (9658)
<rdar://problem/4616595> REGRESSION: Problems with world clock widget clock hand motion on 9A211 + 4604574
<rdar://problem/4638376> lots of transparent 1x1 drawing in page load test (Image::checkSolidColor failing?)
- 9:15 PM Changeset in webkit [15537] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Adele.
- fixed layout test results that were affected by editing input paste patch -- new results are actually more correct, handling text fields properly as a replaced element.
- editing/selection/3690703-2-expected.txt:
- editing/selection/3690703-expected.txt:
- fast/events/div-focus-expected.txt:
- fast/text/textIteratorNilRenderer-expected.txt:
- 7:01 PM Changeset in webkit [15536] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10021
Bug 10021: REGRESSION: Stack overflow due to infinite recursion in
Image::checkForSolidColor
- platform/Image.cpp: (WebCore::Image::cacheFrame): Don't call checkForSolidColor unless the frame was decoded successfully.
- 5:59 PM Changeset in webkit [15535] by
-
- 1 copy in tags/Safari-521.19
new tag
- 5:47 PM Changeset in webkit [15534] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or other WebPreferences changes)
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): Stop the plug-in when it is removed from its superview. It is not sufficient to do this in -viewWillMoveToWindow:nil, because the WebView might still has a hostWindow at that point, which prevents the plug-in from being destroyed. There is no need to start the plug-in when moving into a superview. -viewDidMoveToWindow takes care of that.
- 4:56 PM Changeset in webkit [15533] by
-
- 2 edits in trunk/JavaScriptGlue
Fixed by Darin & Maciej, reviewed by me.
- Fixed <rdar://problem/4638934> Leopard 9A227: Installer crashes right after LCA and while preparing Installation
Compile release/production with NDEBUG set, to ensure binary compatibility
between JavaScriptGlue and JavaScriptCore. In debug builds, JavaScriptCore
includes an extra debug data member in HashSet.
- JavaScriptGlue.xcodeproj/project.pbxproj:
- 4:54 PM Changeset in webkit [15532] by
-
- 14 edits in trunk/WebCore
Reviewed by Maciej.
- Fix for: <rdar://problem/4422657> REGRESSION: member name field or password field should have focus after loading webmail.mac.com (7405) http://bugzilla.opendarwin.org/show_bug.cgi?id=7405
<rdar://problem/4614181> REGRESSION: Crash in WebCore::RenderTextField::text() when quoting post at the Ars Technica forum (9707)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9707
Needs an http test. (http://bugzilla.opendarwin.org/show_bug.cgi?id=10020)
These bugs were both cases where focus() was called on an element which didn't have a renderer yet because stylesheets hadn't finished loading yet.
Now, we detect this case and let setFocusNode be called. And when the stylesheet finishes loading, and the element attaches, a timer will fire,
which will cause the correct selection & scrolling behavior to occur.
This fix removes selection and scrolling behavior from the focus method. This code is now in a new method, updateFocusAppearance.
updateFocusAppearance can now be called directly from focus(), but it can also be called when a timer fires. This timer gets set
up when an element attaches, and its already been focused by the focus method. We have to use a timer, because updateFocusAppearance can cause
a layout to happen, and we don't want that to happen in the middle of attach().
- bindings/objc/DOM.mm: (-[DOMElement isFocused]): Added SPI for autofill.
- bindings/objc/DOMPrivate.h:
- dom/Element.cpp: (WebCore::Element::Element): Initializes timer and needFocusAppearanceUpdate bool. (WebCore::Element::attach): Checks needsFocusAppearanceUpdate, and if the node is focused, then starts the timer. (WebCore::Element::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::Element::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node. (WebCore::Element::updateFocusAppearanceTimerFired): Stops the timer, and if the element is focusable, calls updateFocusAppearance. (WebCore::Element::stopUpdateFocusAppearanceTimer): Cancels timer, and setsNeedsFocusAppearanceUpdate(false). (WebCore::Element::detach): Calls stopUpdateFocusAppearanceTimer. (WebCore::Element::blur): ditto.
- dom/Element.h: (WebCore::Element::needsFocusAppearanceUpdate): Added so the timer only fires when focus() methods have caused an element to be focused. (WebCore::Element::setNeedsFocusAppearanceUpdate): Added so focus methods can set this flag.
- dom/Node.h: (WebCore::Node::supportsFocus): Added. Base class just calls isFocusable.
- html/HTMLAnchorElement.h: Added supportsFocus.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): Added. Checks for the case where stylesheets haven't loaded yet, so we can still focus the node without a renderer, and when it gets a renderer, we'll update the focus appearance.
- html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::supportsFocus): ditto.
- html/HTMLGenericFormElement.cpp: Removed include of Document.h since this is now in the header.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::HTMLInputElement::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node.
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Updated to check supportsFocus before calling setFocusNode, and only requiring the element to be focusable now before updating focus appearance. (WebCore::HTMLTextAreaElement::updateFocusAppearance): Added. Separates the selection, and the scrolling from focusing the node.
- html/HTMLTextAreaElement.h:
- 3:55 PM Changeset in webkit [15531] by
-
- 10 edits4 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4631972>
REGRESSION: Mail crashes when pasting entire contents of http://www.apple.com/support/ into a new mail message
- editing/pasteboard/4631972-expected.checksum: Added.
- editing/pasteboard/4631972-expected.png: Added.
- editing/pasteboard/4631972-expected.txt: Added.
- editing/pasteboard/4631972.html: Added.
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/selection/replaced-boundaries-3-expected.checksum:
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
WebCore:
Reviewed by levi
<rdar://problem/4631972>
REGRESSION: Mail crashes when pasting entire contents of http://www.apple.com/support/ into a new mail message
- dom/Position.cpp: (WebCore::Position::upstream): Deployed isBlock and enclosingBlock. (WebCore::Position::downstream): Ditto.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Ditto.
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added !iframe. (WebCore::isBlock): Added, returns !node->renderer()->isInline() (WebCore::enclosingBlock): Added.
- editing/htmlediting.h:
- 3:32 PM Changeset in webkit [15530] by
-
- 3 edits2 adds in trunk
WebCore:
2006-07-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
<rdar://problem/4631272> REGRESSION: Crash tabbing out of hostname field at autorestore.apple.com
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): Take into account that focus handlers can cause a node to be destroyed.
LayoutTests:
2006-07-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
<rdar://problem/4631272> REGRESSION: Crash tabbing out of hostname field at autorestore.apple.com
- fast/forms/display-none-in-onchange-keyboard-expected.txt: Added.
- fast/forms/display-none-in-onchange-keyboard.html: Added.
- 2:49 PM Changeset in webkit [15529] by
-
- 5 edits in trunk/WebCore
Fix for 4638376. The 1x1 solid color image optimization was broken when
I re-architected image. This patch restores the optimization for CG. Cairo
will still need the optimization.
Reviewed by darin
WARNING: NO TEST CASES ADDED OR CHANGED (need test cases still)
- platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::invalidateData): (WebCore::Image::cacheFrame):
- platform/Image.h: (WebCore::Image::setIsPDF):
- platform/cairo/ImageCairo.cpp: (WebCore::Image::checkForSolidColor):
- platform/mac/ImageMac.mm: (WebCore::Image::initNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::checkForSolidColor): (WebCore::Image::draw): (WebCore::Image::drawTiled):
- 12:01 PM Changeset in webkit [15528] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4613519>
REGRESSION: Pasting text in native text area inserts text one character before it should (9527)
- fast/forms/paste-into-textarea-expected.checksum: Added.
- fast/forms/paste-into-textarea-expected.png: Added.
- fast/forms/paste-into-textarea-expected.txt: Added.
- fast/forms/paste-into-textarea.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4613519>
REGRESSION: Pasting text in native text area inserts text one character before it should (9527)
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreakCommand instead of bailing if the enclosingBlockFlowElement doesn't have a parent.
- 11:30 AM Changeset in webkit [15527] by
-
- 3 edits in trunk/LayoutTests
2006-07-19 Anders Carlsson <acarlsson@apple.com>
- fast/js/pretty-print-expected.txt: Update result.
- fast/js/resources/pretty-print.js: Fix description string.
- 10:32 AM Changeset in webkit [15526] by
-
- 6 edits3 adds in trunk
2006-07-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
<rdar://problem/4620655> REGRESSION(10.4.7-10.5): preview button for a blogger.com post doesn't work
- kjs/nodes2string.cpp: (StringNode::streamTo): Return the escaped string.
(RegExpNode::streamTo):
Use the correct syntax.
- kjs/function.cpp: (KJS::escapeStringForPrettyPrinting):
- kjs/function.h: Add escape function which escapes a string for pretty-printing so it can be parsed again.
- wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar): New function.
LayoutTests:
2006-07-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
<rdar://problem/4620655> REGRESSION(10.4.7-10.5): preview button for a blogger.com post doesn't work
- fast/js/pretty-print-expected.txt: Added.
- fast/js/pretty-print.html: Added.
- fast/js/resources/pretty-print.js: Added.
- 10:24 AM Changeset in webkit [15525] by
-
- 3 edits4 adds in trunk
LayoutTests:
<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range
<rdar://problem/4062218> pasting in contents of web.apple.com strips off the <table> element from the first table
(this really only tests the symptoms of <rdar://problem/4062218>, because -[DOMRange markupString] is not testable)
- editing/pasteboard/paste-table-003-expected.checksum: Added.
- editing/pasteboard/paste-table-003-expected.png: Added.
- editing/pasteboard/paste-table-003-expected.txt: Added.
- editing/pasteboard/paste-table-003.html: Added.
WebCore:
Reviewed by Tim Hatcher.
<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range
<rdar://problem/4062218> pasting in contents of web.apple.com strips off the <table> element from the first table
Better patch than previous checkin.
- test: editing/pasteboard/paste-table-003.html
- editing/markup.cpp: (WebCore::createMarkup): Make sure to include the table when including a tbody.
- 8:26 AM Changeset in webkit [15524] by
-
- 6 edits in /
Versioning
- 7:50 AM Changeset in webkit [15523] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
<rdar://problem/4629307> -[DOMRange markupString] does not include the initial table element if it is at the beginning of the range
No test case as this can only be reproduced through ObjC APIs.
- editing/markup.cpp: (WebCore::createMarkup): Adjust the range for ancestor markup handling when main loop skips first node.
- 12:06 AM Changeset in webkit [15522] by
-
- 4 edits3 adds in trunk
Reviewed by Adele Peterson.
<rdar://problem/4589530> REGRESSION: null character in JS string causes parse error (works in Tiger and in other browsers)
- kjs/lexer.cpp: (Lexer::shift): (Lexer::lex): (Lexer::record16): (Lexer::scanRegExp):
- kjs/lexer.h:
LayoutTests:
Reviewed by Adele Peterson.
Test case for:
<rdar://problem/4620646> REGRESSION(10.4.7-10.5): can't type into editing region when creating or editing a blogger.com post
- fast/js/null-char-in-string-expected.txt: Added.
- fast/js/null-char-in-string.html: Added.
- fast/js/resources/null-char-in-string.js: Added.
Jul 18, 2006:
- 10:38 PM Changeset in webkit [15521] by
-
- 4 edits in /
Adding versioning and markers from earlier.
- 9:39 PM Changeset in webkit [15520] by
-
- 2 edits in tags/JavaScriptCore-521.18.1/JavaScriptCore
Fix hard wrap issue that I forogt to check in before submitting.
- 9:37 PM Changeset in webkit [15519] by
-
- 1 copy in tags/JavaScriptCore-521.18.1/JavaScriptCore
New tag (part 2)
- 9:36 PM Changeset in webkit [15518] by
-
- 1 add in tags/JavaScriptCore-521.18.1
new tag.
- 9:05 PM Changeset in webkit [15517] by
-
- 4 deletes in trunk/LayoutTests/fast/css
Remove the font property compatibility test, since we no longer want to be compatible.
- 7:44 PM Changeset in webkit [15516] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Timothy.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9964 Add switch to prepare-ChangeLog to skip svn update of ChangeLog files
- Scripts/prepare-ChangeLog: Added --[no-]update switch.
- 5:32 PM Changeset in webkit [15515] by
-
- 1 edit in trunk/WebCore/css/cssparser.cpp
Tweak a comment in cssparser.
- 5:16 PM Changeset in webkit [15514] by
-
- 6 edits in trunk/WebCore
Fix for radar 4611287, make resizable text fields opt-in rather than
opt-out. Open source users will need to write the pref into their defaults
to see the resizers on textareas now.
Reviewed by mjs and adele
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setTextAreasAreResizable:]):
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/html4.css:
- 4:03 PM Changeset in webkit [15513] by
-
- 12 edits in tags/Safari-521.18
Merging important fixes.
- 3:56 PM Changeset in webkit [15512] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Tim Hatcher.
Removed a misleading comment; we recently added support for the NPNVPluginElementNPObject
variable.
- bindings/npapi.h:
- 3:09 PM Changeset in webkit [15511] by
-
- 77 edits6 copies7 deletes in tags/Safari-521.18
Merged urgent fixes to a new tag.
- 1:43 PM Changeset in webkit [15510] by
-
- 33 edits in S60/trunk/WebKit
2006-07-18 Bradley <bradley.morrison@nokia.com>
Reviewed by Sachin/Zalan.
Various fixes - see ChangeLogs for details.
Part 4 of 4.
- 1:38 PM Changeset in webkit [15509] by
-
- 34 edits in S60/trunk/WebKit
2006-07-17 Bradley <bradley.morrison@nokia.com>
Reviewed by Sachin/Zalan.
Various fixes - see ChangeLogs for details.
Part 3 of 4.
- 1:31 PM Changeset in webkit [15508] by
-
- 26 edits in S60/trunk/WebCore
2006-07-17 Bradley <bradley.morrison@nokia.com>
Reviewed by Sachin/Zalan.
Various fixes - see ChangeLogs for details.
Part 2 of 4.
- 1:22 PM Changeset in webkit [15507] by
-
- 21 edits5 adds1 delete in S60/trunk
2006-07-17 Bradley <bradley.morrison@nokia.com>
Reviewed by Sachin/Zalan.
Various fixes - see ChangeLogs for details.
Part 1 of 4.
- 1:22 PM Changeset in webkit [15506] by
-
- 5 edits2 adds in trunk
WebCore:
2006-07-18 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::close):
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::willRemove): Remove calls to incrementFrameCount and decrementFrameCount.
- page/Frame.cpp: (WebCore::Frame::Frame): Call incrementFrameCount here.
(WebCore::Frame::~Frame):
Call disconnectOwnerElement.
(WebCore::Frame::disconnectOwnerElement):
Call decrementFrameCount here.
LayoutTests:
2006-07-18 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads
- fast/frames/frame-limit-expected.txt: Added.
- fast/frames/frame-limit.html: Added.
- 12:56 PM Changeset in webkit [15505] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9013
Let correct CSS custom cursor declarations parse
- css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ignore any values following a custom CSS cursor URI, instead of requiring that it is the only one in the list (which is actually illegal, according to the spec). This is only a temporary hack, with a real implementation to follow in bug 6001/6002.
- manual-tests/custom-cursors.html: Added a test for this issue.
- manual-tests/resources/helpCursor.tiff: A cursor image used in the test.
- 12:28 PM Changeset in webkit [15504] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
<rdar://problem/4636216> NetNewsWire fails to launch on 9A224 - missing symbols
WebCore needs to add -sub_library libobjc to maintain
backwards compatibility with binaries linked with WebKit
before JavaScriptCore moved out of WebKit.
- WebCore.xcodeproj/project.pbxproj:
- 10:56 AM Changeset in webkit [15503] by
-
- 1 copy in tags/Safari-521.18
New tag.
- 10:03 AM Changeset in webkit [15502] by
-
- 5 edits4 deletes in trunk/LayoutTests
Reviewed by Alice.
- convert a couple of tests to "dump as text" tests
- fast/dom/css-selectorText-expected.checksum: Removed.
- fast/dom/css-selectorText-expected.png: Removed.
- fast/dom/css-selectorText-expected.txt: Replaced render tree results with text results.
- fast/dom/css-selectorText.html: Added a call to layoutTestController.dumpAsText.
- fast/dom/css-shortHands-expected.checksum: Removed.
- fast/dom/css-shortHands-expected.png: Removed.
- fast/dom/css-shortHands-expected.txt: Replaced render tree results with text results.
- fast/dom/css-shortHands.html: Added a call to layoutTestController.dumpAsText.
- 9:01 AM Changeset in webkit [15501] by
-
- 2 edits in trunk/JavaScriptCore
Made the following headers public:
- JavaScriptCore.h
- JSBase.h
- JSContextRef.h
- JSObjectRef.h
- JSStringRef.h
- JSValueRef.h
- JavaScriptCore.xcodeproj/project.pbxproj:
- 3:55 AM Changeset in webkit [15500] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Justin. Patch by Mitz.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9978 REGRESSION (r12949-r12988): Clicking the first letter on a line places the caret at the end of the previous line
- editing/selection/click-start-of-line-expected.checksum: Added.
- editing/selection/click-start-of-line-expected.png: Added.
- editing/selection/click-start-of-line-expected.txt: Added.
- editing/selection/click-start-of-line.html: Added.
WebCore:
Reviewed by Justin. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9978 REGRESSION (r12949-r12988): Clicking the first letter on a line places the caret at the end of the previous line
Test: editing/selection/click-start-of-line.html
- rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed to return downstream affinity if the x coordinate is to the left of the middle of the first character in the text box.
- 2:24 AM Changeset in webkit [15499] by
-
- 3 edits2 adds in trunk
WebCore:
2006-07-18 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): If the caret is inside an editable region, the beginning/end of the document should actually be the beginning/end of the editable region.
LayoutTests:
2006-07-18 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)
- editing/selection/move-begin-end-expected.txt: Added.
- editing/selection/move-begin-end.html: Added.
Jul 17, 2006:
- 9:55 PM Changeset in webkit [15498] by
-
- 12 edits in trunk
WebCore:
Reviewed by Maciej.
<rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
by script
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setProhibitsScrolling:]):
- page/Frame.cpp: (WebCore::Frame::prohibitsScrolling): (WebCore::Frame::setProhibitsScrolling):
- page/Frame.h:
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
- page/FrameView.cpp: (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos):
- page/FrameView.h:
- platform/ScrollView.h:
WebKit:
Reviewed by Maciej.
<rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
by script
- WebView/WebViewPrivate.h:
- WebView/WebView.m: (-[WebView setProhibitsMainFrameScrolling:]): New method. Prohibits scrolling in the WebView's main frame. Used to "lock" a WebView to a specific scroll position.
- 9:33 PM Changeset in webkit [15497] by
-
- 19 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Added automatic prototype creation for classes.
A class stores a weak reference to a prototype, which is cleared when
the prototype is garbage collected, to avoid a reference cycle.
We now have an attributes field in JSClassDefinition, that currently is
used only to override automatic prototype creation when you want to manage your
own prototypes, but can be extended in the future for other nefarious purposes.
Similarly, we have JSObjectMake and JSObjectMakeWithPrototype, the latter
allowing you to manage your own prototypes.
JSObjectMakeConstructor is more interesting now, able to make a constructor
on your behalf if you just give it a class.
- Removed bogus old code from minidom.js.
- Tweaked the headerdocs.
- Added more GC testing, which caught some leaks, and tested more funny edge cases in lookup, which caught a lookup bug. Removed some testing we used to do with MyObject because it was redundant with the new, cool stuff.
While fixing the lookup bug I retracted this change:
"If a static setProperty callback returns 'false', to indicate that the
property was not set, we no longer forward the set request up the class
chain, because that's almost certainly not what the programmer expected."
Returning false when setting a static property is a little silly, but you can see
it being useful when shadowing a base class's static properties, and, regardless
of usefullness, this is the defined behavior of the setProperty callback.
- Plus a little ASCII art, for the kids.
- 9:32 PM Changeset in webkit [15496] by
-
- 3 edits4 adds in trunk
LayoutTests:
Test cases not reviewed but the corresponding fix was.
- test cases for <rdar://problem/4618089> Blot crashes when I paste in all the contents of http://www.apple.com/startpage/
- editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
- editing/pasteboard/nested-blocks-with-text-area.html: Added.
- editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
- editing/pasteboard/nested-blocks-with-text-field.html: Added.
WebCore:
Reviewed by Dave Harrison.
- fixed <rdar://problem/4618089> Blot crashes when I paste in all the contents of http://www.apple.com/startpage/
- editing/htmlediting.cpp: (WebCore::editingIgnoresContent):
- 6:18 PM Changeset in webkit [15495] by
-
- 2 edits in trunk/WebCore
Reviewed by levi
<rdar://problem/4621728>
REGRESSION: Selecting by dragging down creates selection in wrong direction, with certain steps
<rdar://problem/4604932>
REGRESSION: Dragging too far left on a line will select all lines above it.
No layout test because of 9980.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Don't return positions inside editable roots for coordinates outside those roots, except for coordinates outside a document that is entirely editable.
- 5:55 PM Changeset in webkit [15494] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/4635311> REGRESSION: WebKit should call windowScriptObjectAvailable before attaching the script debugger
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
- 5:48 PM Changeset in webkit [15493] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4635281> JSCanvasRenderingContext2D::drawImage needs to initialize the exception code to zero
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): initialize ec to zero
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): initialize ec before earlier return
- 5:27 PM Changeset in webkit [15492] by
-
- 20 edits1 copy2 moves1 add in trunk
Reviewed by Maciej.
<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit
Moves WebScriptObject and WebUndefined up to WebCore.
This change does create an upwards-dependancy on WebScriptObject existing
in the loaded process, but this code path in JavaScriptCore does not get used
unless it is through WebKit/WebCore. Moving all of the binding code out of
JavaScriptCore might make sense in the future.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/objc/WebScriptObject.h: Replaced.
- bindings/objc/WebScriptObject.mm: Removed.
- bindings/objc/WebScriptObjectPrivate.h: Removed.
- bindings/objc/objc_class.h:
- bindings/objc/objc_instance.h:
- bindings/objc/objc_instance.mm: (ObjcInstance::~ObjcInstance):
- bindings/objc/objc_runtime.h:
- bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::createObjcInstanceForValue):
WebCore:
Reviewed by Maciej.
<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit
Moves WebScriptObject and WebUndefined to WebCore.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
- bindings/objc/DOMCore.h:
- bindings/objc/DOMInternal.mm:
- bindings/objc/DOMUtility.mm:
- bindings/objc/WebScriptObject.mm: Added. (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
- bindings/objc/WebScriptObjectPrivate.h: Added.
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreScriptDebugger.mm:
WebKit:
Reviewed by Maciej.
<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit
Copy WebScriptObject.h from WebCore's private headers, not JavaScriptCore.
- WebKit.xcodeproj/project.pbxproj:
- 3:29 PM Changeset in webkit [15491] by
-
- 1 edit1 add in trunk/LayoutTests
2006-07-17 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Add Apache 2 config file.
- http/conf/apache2-httpd.conf: Added.
- 3:18 PM Changeset in webkit [15490] by
-
- 2 edits in trunk/WebCore
Back out the fix for 5564, since it turns out font:x-small; is a pretty
prominent IE-specific CSS hack. Because Web sites rely on IE's incorrect
font parsing as a means of also correcting IE's incorrect font size rules.
This fixes Yahoo.com.
Reviewed by darin
- css/cssparser.cpp: (WebCore::CSSParser::parseFont):
- 3:05 PM Changeset in webkit [15489] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Omernick.
- fixed <rdar://problem/4604366> Orange Find highlight displays text in wrong size on PDF pages if they're not at "actual size"
To match WebHTMLView, I made the methods that return attributed strings take the view's scale
factor into account.
- WebView/WebPDFView.m: (-[WebPDFView _scaledAttributedString:]): new helper method, takes an attributed string and returns one that's scaled by the view's current scale factor (-[WebPDFView attributedString]): pass result through _scaledAttributedString: (-[WebPDFView selectedAttributedString]): ditto
- 2:54 PM Changeset in webkit [15488] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4618389> REGRESSION: After applying a link to the last word of a sentence, a new selection is created at the start of the sentence
- editing/selection/replace-selection-1-expected.checksum: Added.
- editing/selection/replace-selection-1-expected.png: Added.
- editing/selection/replace-selection-1-expected.txt: Added.
- editing/selection/replace-selection-1.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4618389> REGRESSION: After applying a link to the last word of a sentence, a new selection is created at the start of the sentence
- dom/Document.cpp: (WebCore::Document::updateSelection):
- 12:38 PM Changeset in webkit [15487] by
-
- 4 edits in trunk
LayoutTests:
Reviewed by levi
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/selection/subframe-with-selection-expected.txt:
WebKit:
Reviewed by levi
Rolled the first fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
back in and removed the call to _clearSelectionInOtherFrames from
-[WebHTMLView becomeFirstResponder] to fix the bug.
- WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): (-[NSArray becomeFirstResponder]):
- WebView/WebView.m: (-[WebView maintainsInactiveSelection]):
- 8:19 AM Changeset in webkit [15486] by
-
- 3 edits in trunk/JavaScriptCore
- API/JSBase.h: Fix comment formatting where things used to be lined up but are now ragged. Got rid of spaces that attempted to line things up.
- API/JSObjectRef.h: Ditto. Also add missing periods for a couple of comments.
- 4:50 AM Changeset in webkit [15485] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by Beth.
<rdar://problem/4604946> REGRESSION: 'checkboxRef.checked = true' fires onchange event in Leopard
- fast/events/programmatic-check-no-change-event-expected.txt: Added.
- fast/events/programmatic-check-no-change-event.html: Added.
WebCore:
Reviewed by Beth.
<rdar://problem/4604946> REGRESSION: 'checkboxRef.checked = true' fires onchange event in Leopard
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler):
- html/HTMLInputElement.h:
- 3:49 AM Changeset in webkit [15484] by
-
- 12 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Removed the exception parameter from the initialize callback and, by extension, JSObjectMake. We have never had a need for exceptions when iniitializing, so the parameter seemed likely to "get in the way."
Also, an exception in JavaScript is thrown in response to input --
"invalid URL", "index not a number", etc., so it's the job of the
constructor function, not the initialize method, to throw.
If initialize *really* wants to throw, it can communicate the throw to
the constructor through the constructed object's private data (e.g., set
it to NULL, signaling to the consntructor that initialization failed.)
- Added JSObjectMakeWithData, which enables a constructor to set private data on an object *before* it has been initialized. That way, the initialize methods can properly operate on the data.
- API/JSNode.c: Moved ref into the initialize method, for better encapsulation, now that it's possible.
- API/JSNodeList.c: ditto
- API/minidom.c: (main): Do more aggressive garbage collection to test ref/deref and initialize/finalize.
- API/minidom.js: store childNodes in a temporary so it doesn't get re-created like a thousand times. This makes debugging ref/deref easier
- 2:06 AM Changeset in webkit [15483] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Changed the initialize callback to run from least derived class (parent class) to most derived class. This enables C++ style initialization, and derived class overriding of member data.
- Added excpetion propopgation to JSObjectMake, to support initialize exceptions, and generally round out our policy of making function signatures as long as possible.
- API/JSCallbackObject.h: Use ExecState instead of ContextRef, cuz we're in C++ land now.
- 1:20 AM Changeset in webkit [15482] by
-
- 16 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Changed JSObjectMakeConstructor to JSObjectMakeConstructorWithCallback, to match JSObjectMakeFunctionWithCallback.
- Added prototype parameter, so the generated constructor automatically works with hasInstance / instanceof
- Moved hasInstance implementation from InternalFunctionImp to JSObject so that subclasses can inherit it without inheriting function-related baggage. More refactoring here would be good, but this seems like a good short-term solution.
(KJS::JSCallbackFunction::implementsHasInstance): override and return false,
because callback functions aren't constructors.
- 1:14 AM Changeset in webkit [15481] by
-
- 15 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- add a JSContextRef parameter to all JSValueRef, JSObjectRef, and JSContextRef operations; except JSObject{Get,Set}PrivateData which can be assumed to be simple pure accessors.
Also renamed the parameter "context" to "ctx" because it makes the code read better with this pervasive
but usually uninteresting parameter.
- API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax): (JSGarbageCollect):
- API/JSBase.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString):
- API/JSContextRef.cpp: (JSGlobalContextCreate): (JSGlobalContextRetain): (JSGlobalContextRelease): (JSContextGetGlobalObject):
- API/JSContextRef.h:
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNode_getNodeType): (JSNode_getFirstChild): (JSNode_prototype):
- API/JSNodeList.c: (JSNodeListPrototype_item): (JSNodeList_length): (JSNodeList_getProperty): (JSNodeList_prototype):
- API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor): (JSObjectMakeFunction): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSObjectCopyPropertyNames):
- API/JSObjectRef.h:
- API/JSStringRef.cpp:
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
- API/JSValueRef.h:
- API/minidom.c: (print):
- API/testapi.c: (MyObject_getProperty): (MyObject_deleteProperty): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (print_callAsFunction): (main):
Jul 16, 2006:
- 9:41 PM Changeset in webkit [15480] by
-
- 11 edits in trunk/JavaScriptCore
Approved by Maciej, RS by Beth.
JSObjectMakeFunction -> JSObjectMakeFunctionWithCallback
JSObjectMakeFunctionWithBody -> JSObjectMakeFunction
because the latter is more common, and more fundamental, than the former.
- API/APICast.h: (toJS):
- API/JSBase.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyNames): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter):
- API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::~OpaqueJSClass):
- API/JSClassRef.h:
- API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray): (JSObjectCopyPropertyNames):
- API/JSObjectRef.h:
- API/minidom.c: (main):
- API/testapi.c: (main):
- ChangeLog:
- JavaScriptCore.exp:
- 9:21 PM Changeset in webkit [15479] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9954 REGRESSION: document.dir should return empty string in <head>
- fast/dom/document-dir-property-expected.txt: Added.
- fast/dom/document-dir-property.html: Added.
WebCore:
Reviewed by Darin.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9954 REGRESSION: document.dir should return empty string in <head>
Test: fast/dom/document-dir-property.html
- bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return an empty string instead of an undefined value for an unset document.dir property.
- 9:15 PM Changeset in webkit [15478] by
-
- 8 edits in trunk
LayoutTests:
Reviewed by Darin.
- fast/dynamic/move-node-with-selection-expected.checksum: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
WebCore:
Reviewed by Darin.
- dom/NodeFilter.idl: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
- manual-tests/input-empty-on-focus.html: Removed "Property changes" that snuck in as part of the "apply patch" process.
WebKitTools:
Reviewed by Darin.
- BuildSlaveSupport/build.webkit.org-config/buildbot.css: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
- GdkLauncher/mk: Removed "Property changes" that snuck in as part of the "apply patch" process.
- 8:59 PM Changeset in webkit [15477] by
-
- 3 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9875 Teach svn-apply and svn-unapply to use patch(1) for additions and deletions
- Scripts/svn-apply: (addDirectoriesIfNeeded): Don't try to add a directory that's already in svn. (checksum): Added. (patch): Use patch(1) for non-binary additions and deletions.
- Scripts/svn-unapply: (checksum): Added. (patch): Use patch(1) for reverting non-binary additions and deletions. (revertDirectories): Don't try to revert a directory that hasn't changed in svn.
- 8:59 PM Changeset in webkit [15476] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix Windows build
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some recently added files, removed some recently removed.
- 7:51 PM Changeset in webkit [15475] by
-
- 3 edits in trunk/LayoutTests
- fixed a couple of files I checked in wrong
- fast/html/body-offset-properties-expected.txt: Removed property cruft.
- fast/html/body-offset-properties.html: Ditto.
- 7:00 PM Changeset in webkit [15474] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Change getProperty* to return undefined, rather than NULL, for missing properties, since that's what the spec says. Also added exception out parameters to the *Index functions, because they can call through to the regular functions, which can throw for custom objects.
- API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
- API/JSObjectRef.h:
- API/testapi.c: (main):
- 6:48 PM Changeset in webkit [15473] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Properly document and handle NULL callbacks for static properties. We throw an exception in any case other than a ReadOnly property with a NULL setProperty callback, because a NULL callback almost certainly indicates a programming error. Also throw an exception if hasProperty returns true for a property that getProperty can't get.
- If a static setProperty callback returns 'false', to indicate that the property was not set, we no longer forward the set request up the class chain, because that's almost certainly not what the programmer expected.
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
- API/JSObjectRef.h:
- API/minidom.js:
- API/testapi.c: (MyObject_hasProperty):
- API/testapi.js:
- 6:47 PM Changeset in webkit [15472] by
-
- 2 edits in trunk/LayoutTests
- fixed typo in expected results
- fast/js/for-in-avoid-duplicates-expected.txt:
- 5:37 PM Changeset in webkit [15471] by
-
- 9 edits2 adds in trunk
LayoutTests:
Reviewed by John Sullivan (new test, not the changes to existing ones).
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9943 <rdar://problem/4590613> REGRESSION (Tiger-TOT): menus are offset to the right at http://movies.aol.com/movie-photo-bts/superman-returns
- fast/html/body-offset-properties-expected.txt: Added.
- fast/html/body-offset-properties.html: Added.
- editing/execCommand/findString-2.html: Update to not depend on the buggy body.offseLeft/Top. Instead hardcode the default body margin of 8.
- editing/pasteboard/drop-text-without-selection.html: Ditto.
- editing/selection/click-before-and-after-table.html: Ditto.
- editing/selection/mixed-editability-1.html: Ditto.
- fast/table/click-near-anonymous-table.html: Ditto.
- editing/selection/drag-to-contenteditable-iframe.html: Remove unnecessary use of body.offsetLeft/Top that are always 0.
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9943 <rdar://problem/4590613> REGRESSION (Tiger-TOT): menus are offset to the right at http://movies.aol.com/movie-photo-bts/superman-returns
The problem turns out to be the fact that body.offsetLeft is returning a non-zero value.
I have no idea why the menus worked in Tiger Safari, because body.offsetLeft behavior has not changed.
Presumably some other bug that we fixed had been compensating.
Test: fast/html/body-offset-properties.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): Always return 0 for any object without an offsetParent. (WebCore::RenderObject::offsetTop): Ditto. (WebCore::RenderObject::offsetParent): Return 0 for the body (treat as a special case).
- 5:25 PM Changeset in webkit [15470] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Fix for <rdar://problem/4616595> REGRESSION: Problems with world
clock widget clock hand motion on 9A211 + 4604574
The second hand on the widget was jiggling because the rotation was
messing up the use of the affine transformation matrix while
rounding to pixel boundaries in device space. We are mainly
concerned with rounding to pixel boundaries with the scale in mind,
so this patch extracts the scale to device space from the matrix,
and rounds to pixel boundaries using only the scale. This doesn't
seem like it is a perfect solution, but it definitely solves the
immediate problem. We will probably need to re-address what should
happen to avoid pixel cracks with rotations at non-integral scale
factors.
- platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
- 3:17 PM Changeset in webkit [15469] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Added names to functions.
- Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. The private data idiom is that a JS object stores its native implementation as private data. For functions and constructors, the native implementation is nothing more than the callback they already store, so supporting private data, too, confuses the idiom. If you *really* want, you can still create a custom function with private data.
- API/JSCallbackConstructor.cpp:
- API/JSCallbackConstructor.h:
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
- API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeFunctionWithBody): (JSObjectGetPrivate): (JSObjectSetPrivate):
- API/JSObjectRef.h:
- API/minidom.c: (main):
- API/testapi.c: (main):
- 2:06 PM Changeset in webkit [15468] by
-
- 31 edits5 adds5 deletes in trunk
Reviewed by Darin.
- switch property lists to be vector+set of Identifiers instead of list of References
This has the following benefits:
- no duplicates in property lists
- simplifies API calls
- probably more efficient, since linked list is gone
- entirely removed Reference, ReferenceList and ProtectedReference types from the API
- kjs/PropertyNameArray.cpp: Added. (KJS::PropertyNameArray::add): Check set, if not already there, add to vector.
- kjs/PropertyNameArray.h: Added. (KJS::PropertyNameArray::PropertyNameArray): Newly added type, combines a set and a vector to make a unique but ordered list of identifiers. (KJS::PropertyNameArray::begin): ditto (KJS::PropertyNameArray::end): ditto (KJS::PropertyNameArray::size): ditto (KJS::PropertyNameArray::operator[]): ditto
- kjs/array_instance.h:
- kjs/array_object.cpp: (ArrayInstance::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray (ArrayInstance::setLength): updated for PropertyNameArray (ArrayInstance::pushUndefinedObjectsToEnd): ditto
- kjs/nodes.cpp: (ForInNode::execute): updated for PropertyNameArray
- kjs/nodes.h:
- kjs/object.cpp: (KJS::JSObject::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray
- kjs/object.h:
- kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): updated for PropertyNameArray (KJS::PropertyMap::getSparseArrayPropertyNames): ditto
- kjs/property_map.h:
- kjs/protected_reference.h: Removed.
- kjs/reference.cpp: Removed.
- kjs/reference.h: Removed.
- kjs/reference_list.cpp: Removed.
- kjs/reference_list.h: Removed.
- kjs/scope_chain.cpp: (KJS::ScopeChain::print): Use PropertyNamesArray instead of ReferenceList.
- kjs/string_object.cpp: (StringInstance::getPropertyNames): Updated for new approach.
- kjs/string_object.h:
- kjs/ustring.h:
- API/APICast.h: (toJS): Added overload for PropertyNameAccumulatorRef / PropertyNameArray* (toRef): ditto
- API/JSBase.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getPropertyNames): Fixed for new API.
- API/JSCallbackObject.h:
- API/JSObjectRef.cpp: (JSPropertyNameArray::JSPropertyNameArray): Type used for a publicly vended JSPropertyNameArrayRef. (JSObjectCopyPropertyNames): New API call - renamed / refactored from JSObjectCreatePropertyList (JSPropertyNameArrayRetain): new retain call for JSPropertyNameArray. (JSPropertyNameArrayRelease): new release call for - " -. (JSPropertyNameArrayGetCount): Instead of having to use a stateful enumerator you can now get the count and items in any order. (JSPropertyNameArrayGetNameAtIndex): See above. (JSPropertyNameAccumulatorAddName): What you add properties to is now an opaque accumulator object.
- API/JSObjectRef.h: Prototyped new functions, removed old ones
- JavaScriptCore.exp: Updated exported symbols.
- JavaScriptCore.xcodeproj/project.pbxproj: Added new files, removed old.
- API/testapi.c: (MyObject_getPropertyNames): Renamed / fixed callback to fit new paradigm. (main): Updated for new API.
JavaScriptGlue:
Reviewed by Darin.
- switch property lists to be vector+set of Identifiers instead of list of References
- JSUtils.cpp: (KJSValueToCFTypeInternal): updated for JSC SPI changes
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): ditto
- UserObjectImp.cpp: (UserObjectImp::getPropertyNames): ditto
- UserObjectImp.h:
LayoutTests:
Reviewed by Darin.
- new test case and updated results for property list changes
- fast/js/for-in-avoid-duplicates-expected.txt: Added.
- fast/js/for-in-avoid-duplicates.html: Added.
- fast/js/kde/Array-expected.txt:
- fast/js/resources/for-in-avoid-duplicates.js: Added.
Jul 15, 2006:
- 10:45 PM Changeset in webkit [15467] by
-
- 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj
JavaScriptGlue has no need to look for frameworks in WebKit's umbrella framework path anymore.
- 10:22 PM Changeset in webkit [15466] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
WebCore has no need to look for frameworks in WebKit's umbrella framework path anymore.
- 7:26 PM Changeset in webkit [15465] by
-
- 6 edits in trunk/JavaScriptCore
- oops, missed a few more arrays that had to be const
- API/JSNode.c: (JSNodePrototype_appendChild): Added const. (JSNodePrototype_removeChild): Ditto. (JSNodePrototype_replaceChild): Ditto. (JSNode_construct): Ditto.
- API/JSNodeList.c: (JSNodeListPrototype_item): Ditto.
- API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto.
- API/minidom.c: (print): Ditto.
- API/testapi.c: (MyObject_callAsFunction): Ditto. (MyObject_callAsConstructor): Ditto. (print_callAsFunction): Ditto. (myConstructor_callAsConstructor): Ditto.
- 7:18 PM Changeset in webkit [15464] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- API/JSNode.h: Made an array parameter const.
- API/JSObjectRef.h: Made array parameters const. Fixed a comment.
- 6:40 PM Changeset in webkit [15463] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- JSObjectMakeFunctionWithBody includes a function name and named parameters now.
- API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody):
- API/JSObjectRef.h:
- API/testapi.c: (assertEqualsAsUTF8String): More informative failure reporting. (main): Test more function cases.
- 6:28 PM Changeset in webkit [15462] by
-
- 11 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.
- Added support for class names.
- kJSClassDefinitionNull replaces kJSObjectCallbacksNone.
- JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.
- Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h
- Also added some more informative explanation to the class structure doc.
- 2:03 PM Changeset in webkit [15461] by
-
- 2 edits in trunk/WebCore
- fix mistake from fix for 8952 that was breaking layout tests
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Justin was right! I changed the behavior of the function by accident. Changed it back so that it doesn't blow away the selection on the DOM side in the case where it didn't before.
I will write 100 times on the blackboard: "When Justin says something about editing,
assume he is right."
- 1:00 PM Changeset in webkit [15460] by
-
- 2 edits in trunk/WebCore
- try to fix Windows build
- WebCore.vcproj/WebCore/WebCore.vcproj: Added StreamingTextDecoderICU.cpp/h.
- 12:41 PM Changeset in webkit [15459] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by John Sullivan.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8952 <rdar://problem/4575185> REGRESSION: crash on drag of highlighted Google custom home page modules
- fast/dynamic/move-node-with-selection-expected.checksum: Added.
- fast/dynamic/move-node-with-selection-expected.png: Added.
- fast/dynamic/move-node-with-selection-expected.txt: Added.
- fast/dynamic/move-node-with-selection.html: Added.
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8952 <rdar://problem/4575185> REGRESSION: crash on drag of highlighted Google custom home page modules
Test: fast/dynamic/move-node-with-selection.html
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Call updateRendering before calling clearSelection(), since it's important to do any work beforehand, and there are calls inside clearSelection that will indirectly do an updateRendering. Also change code to make fewer assumptions about object lifetime.
- 12:27 PM Changeset in webkit [15458] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by John Sullivan.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 <rdar://problem/4631844> REGRESSION: {display:list-item} on items outside an ol or ul element no longer causes incremental numbering
- fast/lists/numeric-markers-outside-list-expected.checksum: Added.
- fast/lists/numeric-markers-outside-list-expected.png: Added.
- fast/lists/numeric-markers-outside-list-expected.txt: Added.
- fast/lists/numeric-markers-outside-list.html: Added.
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 <rdar://problem/4631844> REGRESSION: {display:list-item} on items outside an ol or ul element no longer causes incremental numbering
Test: fast/lists/numeric-markers-outside-list.html
- rendering/RenderListItem.cpp: (WebCore::previousListItem): Look for list items, even when we're outside any list.
- 10:22 AM Changeset in webkit [15457] by
-
- 7 edits in trunk/WebCore
Reviewed by John.
- Fix for <rdar://problem/4593970> REGRESSION (NativeTextField): autofill menu disappears after typing a 2nd character
This was caused by composite editing commands, (like typing or pasting) that include a DeleteCommand, being
interpreted by the form delegate as an actual delete. This fix doesn't notify the form delegate if the deletion is
part of an editing command to replace the selected text.
- editing/DeleteSelectionCommand.h: Added m_replace to keep track of whether this deletion is part of a composite command to replace the text being deleted.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_replace. (WebCore::DeleteSelectionCommand::doApply): Only notify the form delegate of the deletion if the text is not being replaced.
- editing/CompositeEditCommand.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Added replace argument to construct DeleteSelectionCommand.
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call deleteSelection with replace argument.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): ditto.
- 9:31 AM Changeset in webkit [15456] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Maciej.
Layout test for crash when setting the dir property on a document with no body.
- fast/dom/dir-no-body-expected.txt: Added.
- fast/dom/dir-no-body.html: Added.
WebCore:
Reviewed by Maciej, tweaked to match Darin's patch.
- Fixed <rdar://problem/4631837> REGRESSION: Reproducible crash on FCKeditor demo (9911)
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Check for a null body element before forwarding the put request to it. I confirmed that no other parts of the file use 'body' or 'bodyElement' without checking for null.
Also, use 'body' rather than 'bodyElement' because dir can bet set on
any element, not just HTMLBodyElement.
- 8:30 AM Changeset in webkit [15455] by
-
- 4 edits3 adds in trunk
Reviewed by Geoff.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8395 <rdar://problem/4613467> REGRESSION: RegEx seems broken for hex escaped non breaking space
Test: fast/js/regexp-extended-characters-more.html
- pcre/pcre_exec.c: (match): Got rid of utf16Length local variable to guarantee there's no extra stack usage in recursive calls. Fixed two places in the PCRE_UTF16 code that were using the length variable, which is the UTF-8 length of a character in the pattern, to move in the UTF-16 subject string. Instead they hardcode lengths of 1 and 2 since the code already handles BMP characters and surrogate pairs separately. Also fixed some DPRINTF so I could compile with DEBUG on. (pcre_exec): Changed a place that was checking for multibyte characters in the subject string to use ISMIDCHAR. Instead it was using hardcoded logic that was right for UTF-8 but wrong for UTF-16.
- pcre/pcre_compile.c: (pcre_compile2): Fixed a DPRINTF so I could compile with DEBUG on.
LayoutTests:
Reviewed by Geoff.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8395 <rdar://problem/4613467> REGRESSION: RegEx seems broken for hex escaped non breaking space
- fast/js/regexp-extended-characters-more-expected.txt: Added.
- fast/js/regexp-extended-characters-more.html: Added.
- fast/js/resources/regexp-extended-characters-more.js: Added.
- 8:21 AM Changeset in webkit [15454] by
-
- 5 edits2 adds in trunk
LayoutTests:
Reviewed by Adele.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8871 <rdar://problem/4575417> REGRESSION: Pressing Enter/Return in a text input removes the selected text and http://bugzilla.opendarwin.org/show_bug.cgi?id=9743 <rdar://problem/4614228> REGRESSION: crash dispatching JavaScript-created keyboard event to input element
- fast/forms/input-text-enter-expected.txt: Added.
- fast/forms/input-text-enter.html: Added.
WebCore:
Reviewed by Adele.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8871 <rdar://problem/4575417> REGRESSION: Pressing Enter/Return in a text input removes the selected text
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9743 <rdar://problem/4614228> REGRESSION: crash dispatching JavaScript-created keyboard event to input element
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Add a null check to fix the crash, and a FIXME explaining why this is not necessarily enough for the future.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Consume Enter key keypress events even if the element is not in a form.
- platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): Added \n to the characters that turn into "Enter". Actual keyboard events always are \r or \003 on the Macintosh, but in layout tests we can use \n, and everything other than the code path here works, so worth fixing.
- 8:14 AM Changeset in webkit [15453] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by John Sullivan.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9883 <rdar://problem/4631821> REGRESSION: NativePopups don't work correctly in some forum software
- fast/forms/select-selected-expected.checksum: Added.
- fast/forms/select-selected-expected.png: Added.
- fast/forms/select-selected-expected.txt: Added.
- fast/forms/select-selected.html: Added.
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9883 <rdar://problem/4631821> REGRESSION: NativePopups don't work correctly in some forum software
Test: fast/forms/select-selected.html
- rendering/RenderMenuList.h:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Added code to map the selected option index to a list index before using it to index into the list. (WebCore::RenderMenuList::showPopup): Added code to map the selection option index to a list index before passing it to the menu renderer. (WebCore::RenderMenuList::valueChanged): Added code to map the list index back to a option index before calling setSelectedIndex (that function takes an option index).
- 8:09 AM Changeset in webkit [15452] by
-
- 6 edits in trunk
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9928 REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)
- bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): Moved into DOMEventTarget category. (-[DOMNode removeEventListener:::]): Ditto. (-[DOMNode dispatchEvent:]): Ditto.
- WebCore.xcodeproj/project.pbxproj: Allow Xcode to do its thing.
WebKit:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9928 REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)
- WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category. (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category. (-[WebHTMLView selectionView]): Ditto. (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto. (-[WebHTMLView selectionImageRect]): Ditto. (-[WebHTMLView pasteboardTypesForSelection]): Ditto. (-[WebHTMLView selectAll]): Ditto. (-[WebHTMLView deselectAll]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto. (-[WebHTMLView attributedString]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView selectedAttributedString]): Ditto. (-[WebHTMLView supportsTextEncoding]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols. (-[WebHTMLView _isMoveDrag]): Ditto. (-[WebHTMLView _isNSColorDrag:]): Ditto. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView elementAtPoint:]): Ditto. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
- WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
- 2:36 AM Changeset in webkit [15451] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
<rdar://problem/4632144> REGRESSION: table column tests failing as a result of very recent fix
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): columns and colgroups are valid children of a table too, not just table sections!
- 2:04 AM Changeset in webkit [15450] by
-
- 3 edits2 adds in trunk
WebCore:
2006-07-15 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Add null check for contentFrame() since content frames won't be created for invalid URLs.
LayoutTests:
2006-07-15 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.
- http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
- http/tests/misc/iframe-invalid-source-crash.html: Added.
Jul 14, 2006:
- 11:53 PM Changeset in webkit [15449] by
-
- 9 edits2 copies12 adds3 deletes in trunk
Reviewed by Darin.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4195
REGRESSION: KOI8-U encoding no longer supported.
Tests:
- http/tests/misc/BOM-override.pl
- http/tests/misc/BOM-override-script.html
- fast/encoding/charset-koi8-u.html
- fast/encoding/charset-x-nextstep.html
Restored a TEC code path for encodings that are not supported by ICU (but which currently
passes all layout tests even by itself with ICU disabled). A lot of refactoring is
still needed - most importantly, round-tripping encoding names via CFStringEncoding
makes little sense now.
- WebCore.exp:
- bridge/mac/WebCoreTextDecoder.h: Removed.
- bridge/mac/WebCoreTextDecoder.mm: Removed. WebCoreTextDecoder was not used anywhere since WebTextView was moved into WebCore.
- loader/Decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::decode): Use StreamingTextDecoder::create().
- platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::create): (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
- platform/StreamingTextDecoder.h: StreamingTextDecoder is just an abstract interface to implementations now.
- platform/StreamingTextDecoderICU.cpp: Added. (WebCore::StreamingTextDecoderICU::StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::~StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::releaseICUConverter): (WebCore::StreamingTextDecoderICU::textEncodingSupported): (WebCore::StreamingTextDecoderICU::convertUTF16): (WebCore::StreamingTextDecoderICU::convertIfASCII): (WebCore::StreamingTextDecoderICU::createICUConverter): (WebCore::StreamingTextDecoderICU::appendOmittingBOM): (WebCore::StreamingTextDecoderICU::convertUsingICU): (WebCore::StreamingTextDecoderICU::convert): (WebCore::StreamingTextDecoderICU::toUnicode): (WebCore::StreamingTextDecoderICU::fromUnicode):
- platform/StreamingTextDecoderICU.h: Added. Renamed from StreamingTextDecoder; added a way to tell whether the encoding is actually supported by the decoder; minor cleanup.
- platform/TextEncoding.cpp: (WebCore::TextEncoding::effectiveEncoding): Moved from StreamingTextDecoder. (WebCore::TextEncoding::toUnicode): Use StreamingTextDecoder::create(). (WebCore::TextEncoding::fromUnicode): Moved to StreamingTextDecoderICU.
- platform/TextEncoding.h: Changed APPLE to PLATFORM(MAC); added effectiveEncoding().
- platform/mac/StreamingTextDecoderMac.cpp: Added. (WebCore::StreamingTextDecoderMac::StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::~StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::releaseTECConverter): (WebCore::StreamingTextDecoderMac::textEncodingSupported): (WebCore::StreamingTextDecoderMac::convertUTF16): (WebCore::StreamingTextDecoderMac::convertIfASCII): (WebCore::StreamingTextDecoderMac::createTECConverter): (WebCore::StreamingTextDecoderMac::appendOmittingBOM): (WebCore::StreamingTextDecoderMac::convertOneChunkUsingTEC): (WebCore::StreamingTextDecoderMac::convertUsingTEC): (WebCore::StreamingTextDecoderMac::convert): (WebCore::StreamingTextDecoderMac::toUnicode): (WebCore::StreamingTextDecoderMac::fromUnicode):
- platform/mac/StreamingTextDecoderMac.h: Added. (WebCore::StreamingTextDecoderMac::convert): This is a TEC+CFString code path for decoding, basically restored from a year-old revision.
- platform/mac/TextEncodingMac.cpp: Removed. Code moved to StreamingTextDecoderMac.
- WebCore.xcodeproj/project.pbxproj:
- 11:37 PM Changeset in webkit [15448] by
-
- 2 edits in tags/JavaScriptCore-521.17.1/JavaScriptCore
Build fix and versioning.
- 11:36 PM Changeset in webkit [15447] by
-
- 1 copy in tags/JavaScriptCore-521.17.1/JavaScriptCore
New tag (part 2)
- 11:35 PM Changeset in webkit [15446] by
-
- 1 add in tags/JavaScriptCore-521.17.1
new tag.
- 11:32 PM Changeset in webkit [15445] by
-
- 1 edit in trunk/JavaScriptCore/API/JSBase.cpp
Build fix for case-sensitive file systems.
- 9:16 PM Changeset in webkit [15444] by
-
- 11 edits in trunk/JavaScriptCore
RS by Maciej.
Global replace in the API of argc/argv with argumentCount/arguments.
- 9:10 PM Changeset in webkit [15443] by
-
- 11 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Finalized exception handling in the API.
setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.
toBoolean can't throw because it's defined that way in the spec.
- Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.
- 7:32 PM Changeset in webkit [15442] by
-
- 5 copies in tags/Safari-521.17
New tag.
- 7:25 PM Changeset in webkit [15441] by
-
- 5 edits4 deletes in trunk
LayoutTests:
Rolling out this fix from r15358 since it isn't resolved.
2006-07-11 Justin Garcia <justin.garcia@apple.com>
Reviewed by levi & thatcher
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/selection/subframe-with-selection-expected.checksum: Added.
- editing/selection/subframe-with-selection-expected.png: Added.
- editing/selection/subframe-with-selection-expected.txt: Added.
- editing/selection/subframe-with-selection.html: Added.
WebKit:
Rolling out this fix from r15358 since it isn't resolved.
2006-07-11 Justin Garcia <justin.garcia@apple.com>
Reviewed by levi & thatcher
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
- WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
- WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
- 7:14 PM Changeset in webkit [15440] by
-
- 8 edits in /
Versioning
- 5:53 PM Changeset in webkit [15439] by
-
- 9 edits in trunk/WebKit
<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure
Build fix with the new GCC. Removes forward declarations of protocols.
- Misc/WebSearchableTextView.h:
- WebCoreSupport/WebSubresourceLoader.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDocumentInternal.h:
- WebView/WebDocumentPrivate.h:
- WebView/WebHTMLView.h:
- WebView/WebPDFView.h:
- WebView/WebScriptDebugDelegatePrivate.h:
- 5:24 PM Changeset in webkit [15438] by
-
- 34 edits in trunk/WebCore
<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure
Made a DOMNode category in DOMEvents.h that lets DOMNode conform to the
DOMEventTarget protocol that works with GCC 5412.
Removed forward declarations of WebCoreWidgetHolder and imported WebCoreWidgetHolder.h.
Removed all <Cocoa/Cocoa.h> and <Foundation/Foundation.h> imports in other headers,
we import <Cocoa/Cocoa.h> in the prefix header for ObjC.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCore.h:
- bindings/objc/DOMEvents.h:
- bridge/mac/FormDataMac.h:
- bridge/mac/WebCoreAXObject.h:
- bridge/mac/WebCoreCache.h:
- bridge/mac/WebCoreEncodings.h:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameNamespaces.h:
- bridge/mac/WebCoreJavaScript.h:
- bridge/mac/WebCorePageBridge.h:
- bridge/mac/WebCorePageState.h:
- bridge/mac/WebCoreResourceLoader.h:
- bridge/mac/WebCoreScriptDebugger.h:
- bridge/mac/WebCoreSettings.h:
- bridge/mac/WebCoreStringTruncator.h:
- bridge/mac/WebCoreStringTruncator.mm:
- bridge/mac/WebCoreTextDecoder.h:
- bridge/mac/WebDashboardRegion.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
- platform/mac/CookieJar.mm:
- platform/mac/DeprecatedStringMac.mm:
- platform/mac/FontDataMac.mm:
- platform/mac/FoundationExtras.h:
- platform/mac/TextBoundaries.mm:
- platform/mac/WebCoreHistory.h:
- platform/mac/WebCoreHistory.m:
- platform/mac/WebCoreKeyGenerator.h:
- platform/mac/WebCoreTextArea.h:
- platform/mac/WebCoreTextField.h:
- platform/mac/WebCoreTextRenderer.h:
- platform/mac/WebCoreView.h:
- platform/mac/WebCoreWidgetHolder.h:
- 3:39 PM Changeset in webkit [15437] by
-
- 22 edits in trunk
Reviewed by Maciej.
- Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.
Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.
- Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)
- API/APICast.h: (toJS): Added cast for new JSGlobalContext
- API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
- kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
- kjs/testkjs.cpp: (doIt): Ref-count the interpreter.
JavaScriptGlue:
Reviewed by Maciej.
- Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.
(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.
WebCore:
Reviewed by Maciej.
- Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.
(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.
- 2:21 PM Changeset in webkit [15436] by
-
- 2 edits1 add in S60/trunk/S60Tools
2006-07-14 brmorris <bradley.morrison@nokia.com>
Reviewed by zbujtas@gmail.com. Fix for:
- prepare-ChangeLog.bat: Match Changelog subdir location on '/'
- refresh_zips.bat: Added.
- 1:54 PM Changeset in webkit [15435] by
-
- 3 edits1 add in trunk/WebCore
2006-07-14 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele and Justin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
<rdar://problem/4613948>
REGRESSION: Check Spelling does not work in textarea elements
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end indices respectively.
- dom/Range.cpp: (WebCore::Range::checkNodeBA): Allow range operations on shadow trees.
- manual-tests/form-element-spelling.html: Added.
- 1:53 PM Changeset in webkit [15434] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- removed bool return value from JSObjectSetProperty, since it is inefficient and also doesn't work quite right
- added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex
- API/JSObjectRef.cpp: (JSObjectSetProperty): Removed return value and canPut stuff. (JSObjectGetPropertyAtIndex): Added. (JSObjectSetPropertyAtIndex): Added.
- API/JSObjectRef.h: Prototyped and documented new functions.
- 1:35 PM Changeset in webkit [15433] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
WebCore::FrameView::updateOverflowStatus
m_viewportRenderer is never initialized for framesets, and it
shouldn't be. So we just need to nil-check for it in
updateOverflowStatus() and return early.
- page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus): Nil check.
- 1:29 PM Changeset in webkit [15432] by
-
- 3 edits7 adds in S60/trunk
2006-07-11 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
Fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=9755
- ChangeLog: Re-arranged all ChangeLog entry locations.
- JavaScriptCore/ChangeLog: Stripped to S60WebKit only.
- MemoryManager/ChangeLog: Added.
- S60Internals/ChangeLog: Added.
- S60Tools/ChangeLog: Added.
- S60WebUi/ChangeLog: Added.
- WebCore/ChangeLog: Added.
- WebKit/ChangeLog: Re-arranged.
- 1:07 PM Changeset in webkit [15431] by
-
- 3 edits in S60/trunk
2006-07-11 brmorris <bradley.morrison@nokia.com>
Reviewed by zbujtas@gmail.com.
Fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=9852
- runATF.bat: Now supports SDK 3rd ed maintenance release.
Calls Epoc.exe directly
- emu.bat: Calls Epoc.exe directly
- 12:09 PM Changeset in webkit [15430] by
-
- 4 edits in trunk
WebCore:
RS by Darin.
Backing out fix for <rdar://problem/4604703>
REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field
Darin had a better fix in WebKit for this.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
WebKit:
Reviewed by Adele.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9625 <rdar://problem/4604703> REGRESSION: Focus not removed from password field after ctrl-click in text field
- WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to YES while calling sendContextMenuEvent: on the bridge.
- 11:53 AM Changeset in webkit [15429] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
- Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
- page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
- bridge/mac/FrameMac.h: ditto.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter if the input manager says there's marked text. I added this code for all text field paths. For widgets, WebCoreTextField.mm has code to deal with this case. But as we convert search, password, and isindex, they will need to do this check too.
- 10:41 AM Changeset in webkit [15428] by
-
- 7 edits1 add in trunk/JavaScriptCore
Reviewed by Beth.
Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
JSBase.h/.cpp. They don't belong in the value-specific or context-specific
files because they're not part of the value or context implementations.
- API/JSBase.h:
- API/JSContextRef.cpp: (JSContextGetGlobalObject):
- API/JSContextRef.h:
- API/JSValueRef.cpp: (JSValueUnprotect):
- API/JSValueRef.h:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 6:18 AM Changeset in webkit [15427] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Darin. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9907 REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode
- rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret position.
- 6:14 AM Changeset in webkit [15426] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div
- editing/deleting/delete-at-start-or-end-expected.checksum: Added.
- editing/deleting/delete-at-start-or-end-expected.png: Added.
- editing/deleting/delete-at-start-or-end-expected.txt: Added.
- editing/deleting/delete-at-start-or-end.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div
Test: editing/deleting/delete-at-start-or-end.html
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Added null check. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- 5:33 AM Changeset in webkit [15425] by
-
- 1 edit4 adds in trunk/LayoutTests
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9879 REGRESSION: Repro crash when clicking to the side of an anonymous table
- see also <rdar://problem/4628129> REGRESSION: Repro crash when clicking to the side of an anonymous table
NOTE: Only the layout test part of this patch was landed since an alternate
fix was committed in r15401: <rdar://problem/4509393> selected DOM range
starts with <object>, 0 offset but selection should include the <object>
- fast/table/click-near-anonymous-table-expected.checksum: Added.
- fast/table/click-near-anonymous-table-expected.png: Added.
- fast/table/click-near-anonymous-table-expected.txt: Added.
- fast/table/click-near-anonymous-table.html: Added.
- 5:05 AM Changeset in webkit [15424] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Geoffrey.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber()
No test cases since there is no change in functionality.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Simplified logic by using the no-argument getNumber() method.
- 1:07 AM Changeset in webkit [15423] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have one surrounding this function, and the nested one makes the compiler think our local variable is volatile (seems like a compiler bug to me).
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
- 12:46 AM Changeset in webkit [15422] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Make JavaScriptCore a public framework. Adjusted the paths.
- WebCore.xcodeproj/project.pbxproj:
- 12:45 AM Changeset in webkit [15421] by
-
- 5 edits24 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)
I included the test case from the bug plus variants for other broken cases that
were similar but needed separate fixes.
- fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
- fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
- fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
- fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
- fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
- fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
- fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
- fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
- fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
- fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
- fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
- fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.
WebCore:
Reviewed by Hyatt.
- fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)
I also fixed all the similar crash / assertion failure cases I could think of.
- dom/Node.cpp: (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
- dom/Node.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Don't allow inserting forms when not in an HTML document, since we don't need that quirk and because parsing won't do certain render tree fixups. Also watch out for case when inserting before the renderer of a misnested child.
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): ditto
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): ditto
- 12:15 AM Changeset in webkit [15420] by
-
- 4 edits in trunk
Reviewed by Maciej.
Moved JavaScriptCore to be a public framework.
- JavaScriptCore.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Maciej.
Moved JavaScriptCore to be a public framework.
- WebKit.xcodeproj/project.pbxproj:
Jul 13, 2006:
- 11:48 PM Changeset in webkit [15419] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Maciej.
- Fix for <rdar://problem/4604703> REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field
Test:
- manual-tests/password-ctrl-click-lose-focus.html: Added.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): If we're about to set a selection in the current view, make sure its the first responder. In this case, this will cause the password field to resign first responder at the right time.
- 9:42 PM Changeset in webkit [15418] by
-
- 20 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt. Patch by Mitz.
- test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 REGRESSION: RTL white-space:pre-wrap text is offset to the right
- editing/deleting/delete-to-select-table-expected.txt:
- editing/execCommand/boldSelection-expected.txt:
- editing/execCommand/italicizeByCharacter-expected.txt:
- editing/execCommand/modifyForeColorByCharacter-expected.txt:
- editing/execCommand/print-expected.txt:
- editing/execCommand/selectAll-expected.txt:
- editing/execCommand/strikethroughSelection-expected.txt:
- editing/inserting/insert-div-027-expected.txt:
- editing/selection/after-line-wrap-expected.txt:
- editing/selection/mixed-editability-1-expected.txt:
- editing/selection/select-all-001-expected.txt:
- editing/selection/select-all-002-expected.txt:
- editing/selection/select-all-003-expected.txt:
- fast/clip/outline-overflowClip-expected.txt:
- fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
- fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
- fast/text/international/rtl-white-space-pre-wrap-expected.txt: Added.
- fast/text/international/rtl-white-space-pre-wrap.html: Added.
- fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
- fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
WebCore:
Reviewed by Hyatt. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 REGRESSION: RTL white-space:pre-wrap text is offset to the right
Test: fast/text/international/rtl-white-space-pre-wrap.html
- rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed LTR case and added the RTL case of clipping the caret position to the text box when the caret is after the trailing space of an autowrapped line.
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to truncate- to-fit the logically last text box if it contains the trailing spaces of an autowrapped line. (WebCore::RenderBlock::bidiReorderLine): Remember the logically last text run. In the case of autowrapped text with white space that overflows beyond the line, the last text run is the one containing the overflowing white space. (WebCore::RenderBlock::findNextLineBreak): Split overflowing white space on a line that autowraps only after white space into a separate text run.
- 8:29 PM Changeset in webkit [15417] by
-
- 7 edits3 adds in trunk
Reviewed by Geoffrey. Patch by Mark Rowe.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <http://www.vtbook.com>
- kjs/value.h: (KJS::JSValue::getUInt32): Only types tagged as numeric can be converted to UInt32.
LayoutTests:
Reviewed by Geoffrey. Patch by Mark Rowe.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <http://www.vtbook.com>
This includes tests for indexing an array with immediate types, and for
setting selectField.options.length to immediate types.
- fast/dom/select-selectedIndex-expected.txt:
- fast/dom/select-selectedIndex-multiple-expected.txt:
- fast/dom/select-selectedIndex-multiple.html: Update to test setting length to true and false.
- fast/dom/select-selectedIndex.html: Ditto.
- fast/js/array-index-immediate-types-expected.txt: Added.
- fast/js/array-index-immediate-types.html: Added.
- fast/js/resources/array-index-immediate-types.js: Added.
- 7:37 PM Changeset in webkit [15416] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9795 REGRESSION: Crash in [WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] and http://bugzilla.opendarwin.org/show_bug.cgi?id=9850 REGRESSION: Assertion failure (SHOULD NEVER BE REACHED) in - [WebHTMLView(WebPrivate) removeTrackingRect:]
- WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if the view has already been closed.
- 4:17 PM Changeset in webkit [15415] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave Hyatt.
<rdar://problem/4624203> -webkit-highlight should be behind images
- rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Call custom highlighter before painting the image, marker, or widget.
- 2:08 PM Changeset in webkit [15414] by
-
- 8 edits8 adds in trunk
LayoutTests:
Reviewed by Justin and Levi.
<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
- editing/deleting/delete-by-word-001-expected.checksum: Added.
- editing/deleting/delete-by-word-001-expected.png: Added.
- editing/deleting/delete-by-word-001-expected.txt: Added.
- editing/deleting/delete-by-word-001.html: Added.
- editing/deleting/delete-by-word-002-expected.checksum: Added.
- editing/deleting/delete-by-word-002-expected.png: Added.
- editing/deleting/delete-by-word-002-expected.txt: Added.
- editing/deleting/delete-by-word-002.html: Added.
WebCore:
Reviewed by Justin and Levi.
<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
- Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::doApply):
- editing/TypingCommand.h: Delete and forward delete to use specified granularity. Undo of delete and forward delete to select what had been deleted (non-char granularity only).
- page/Frame.cpp: (WebCore::Frame::setSelection): Close typing and end style even if selection is not changing.
- page/Frame.h: Remove unused setSelection parameter keepTypingStyle.
WebKit:
Reviewed by Justin and Levi.
<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
- Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
- WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
- 11:45 AM Changeset in webkit [15413] by
-
- 3 edits in tags/WebKit-521.16.4/WebKit
Reviewed by Darin.
<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.
Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.
- WebView/WebView.m: (-[WebView setEditable:]):
- 11:44 AM Changeset in webkit [15412] by
-
- 3 edits in tags/WebCore-521.16.1/WebCore
Reviewed by Brady Eidson
- fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
- dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
- 11:34 AM Changeset in webkit [15411] by
-
- 1 copy in tags/WebKit-521.16.4
New tag.
- 11:33 AM Changeset in webkit [15410] by
-
- 1 copy in tags/WebCore-521.16.1/WebCore
New tag (part 2)
- 11:32 AM Changeset in webkit [15409] by
-
- 1 add in tags/WebCore-521.16.1
New tag.
- 11:28 AM Changeset in webkit [15408] by
-
- 11 edits8 adds in trunk
LayoutTests:
Reviewed by justin
<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table
- editing/deleting/delete-block-table-expected.checksum: Added.
- editing/deleting/delete-block-table-expected.png: Added.
- editing/deleting/delete-block-table-expected.txt: Added.
- editing/deleting/delete-block-table.html: Added.
- editing/deleting/delete-hr-expected.checksum: Added.
- editing/deleting/delete-hr-expected.png: Added.
- editing/deleting/delete-hr-expected.txt: Added.
- editing/deleting/delete-hr.html: Added.
- editing/deleting/delete-to-select-table-expected.png:
- editing/execCommand/insertHorizontalRule-expected.txt:
- fast/lists/markers-in-selection-expected.txt:
WebCore:
Reviewed by justin
<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Added selection expansion for HRs. (WebCore::DeleteSelectionCommand::initializePositionData): Now uses enclosingBlockFlowOrTableElement instead of enclosingBlockFlowElement. (WebCore::DeleteSelectionCommand::removeNode): Use to identify that we need a placeholder when the start or end block is removed. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Added check for canHaveChildrenForEditing to keep things like HRs from being given children. (WebCore::DeleteSelectionCommand::doApply): Switched to use member variable for needPlaceholder.
- editing/DeleteSelectionCommand.h: Made needPlaceholder a member variable.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Fixed selection bug for tables and open typing commands. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added check for HRs, since it's not considered a widget.
- editing/visible_units.cpp: (WebCore::startOfParagraph): Fix for HRs and tables. (WebCore::endOfParagraph): Ditto.
- 11:27 AM Changeset in webkit [15407] by
-
- 3 edits in trunk/WebKit
Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit
<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.m:
- 11:06 AM Changeset in webkit [15406] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.
Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.
- WebView/WebView.m: (-[WebView setEditable:]):
- 8:54 AM Changeset in webkit [15405] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9880 Memory leaks running DOM-Hanoi
No change in behavior, thus no test included.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries - the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.
- 1:56 AM Changeset in webkit [15404] by
-
- 14 edits in trunk/JavaScriptCore
Pleasing to Maciej.
- Renamed JSEvaluate -> JSEvaluateScript, JSCheckSyntax -> JSCheckScriptSyntax
- Added exception out parameters to JSValueTo* and JSValueIsEqual because they can throw
- Removed JSObjectGetDescription because it's useless and vague, and JSValueToString/JSValueIsObjectOfClass do a better job, anyway
- Clarified comments about "IsFunction/Constructor" to indicate that they are true of all functions/constructors, not just those created by JSObjectMake*
- 12:11 AM Changeset in webkit [15403] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Timothy.
Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame
http://bugzilla.opendarwin.org/show_bug.cgi?id=9889
- Drosera/debugger.js: Track whether we paused during the execution of willLeaveFrame. If so, have stepOut pause on the next call to willExecuteStatement rather than second.
Jul 12, 2006:
- 9:52 PM Changeset in webkit [15402] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Adele. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9862 REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF
- see also <rdar://problem/4622407>
Test: fast/frames/repaint-display-none-crash.html
- rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Added null checking of the owner element's renderer, which can be null if the iframe is set to display:none.
LayoutTests:
Reviewed by Adele. Patch by Mitz.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9862 REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF
- see also <rdar://problem/4622407>
- fast/frames/repaint-display-none-crash-expected.txt: Added.
- fast/frames/repaint-display-none-crash.html: Added.
- 7:31 PM Changeset in webkit [15401] by
-
- 14 edits2 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>
- editing/selection/legal-positions-expected.txt: Added.
- editing/selection/legal-positions.html: Added.
- editing/deleting/delete-3608430-fix-expected.txt:
- editing/deleting/delete-image-001-expected.txt:
- editing/deleting/delete-image-002-expected.txt:
- editing/deleting/delete-image-003-expected.txt:
- editing/deleting/delete-image-004-expected.txt:
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
WebCore:
Reviewed by levi
<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Don't pull content out of a table cell.
- editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added <select> nodes. (WebCore::rangeCompliantEquivalent): Convert [node, 0] positions to positionBeforeNode(node) for more types of nodes.
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Fix a crasher when right clicking on an anonymous table.
- 7:15 PM Changeset in webkit [15400] by
-
- 4 edits2 moves in trunk/JavaScriptCore
RS by Beth.
Finished previously approved JSInternalString -> JSString conversion
by renaming the files.
- API/JSCallbackObject.cpp:
- API/JSInternalStringRef.cpp: Removed.
- API/JSInternalStringRef.h: Removed.
- API/JSStringRef.cpp: Added.
- API/JSStringRef.h: Added.
- API/JavaScriptCore.h:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 5:36 PM Changeset in webkit [15399] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Brady Eidson (and written by Justin Garcia)
- layout test corresponding to <rdar://problem/4611164>
- editing/undo/undo-misspellings-expected.checksum: Added.
- editing/undo/undo-misspellings-expected.png: Added.
- editing/undo/undo-misspellings-expected.txt: Added.
- editing/undo/undo-misspellings.html: Added.
- 5:29 PM Changeset in webkit [15398] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson
- fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
- dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
- 5:20 PM Changeset in webkit [15397] by
-
- 3 edits4 adds in trunk
WebCore:
2006-07-13 Anders Carlsson <acarlsson@apple.com>
Reviewed by Justin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus
- dom/Document.cpp: (WebCore::Document::updateSelection): Don't return early if the selection is empty.
LayoutTests:
2006-07-13 Anders Carlsson <acarlsson@apple.com>
Reviewed by Justin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus
- editing/selection/clear-selection-expected.checksum: Added.
- editing/selection/clear-selection-expected.png: Added.
- editing/selection/clear-selection-expected.txt: Added.
- editing/selection/clear-selection.html: Added.
- 2:47 PM Changeset in webkit [15396] by
-
- 2 edits in trunk/WebKit
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Don't create Dictionary, Spotlight or Google lookup items if there's no selection.
- 10:31 AM Changeset in webkit [15395] by
-
- 2 edits1 add in trunk/WebCore
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
<rdar://problem/4614656> REGRESSION: onpaste() handlers don't run for textarea elements
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::dispatchCPPEvent): If the element is a shadow node, dispatch the event to its real parent.
- manual-tests/textarea-onpaste.html: Added.
- 10:00 AM Changeset in webkit [15394] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders.
Fix for layout test regressions after my check-in last night. Just
a silly mistake where I should have asked if we were NOT printing
instead of if we were in the listbox code.
- WebCore.xcodeproj/project.pbxproj: Project file wars. Back to XCode 2.3
- platform/mac/ListBoxMac.mm: (itemTextRenderer): Inverted check. (groupLabelTextRenderer): Inverted check.
- 9:15 AM Changeset in webkit [15393] by
-
- 4 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Teach svn-create-patch and friends to fix ChangeLog patches
- Scripts/svn-apply: Added fixChangeLogPatch() and invoked it in the proper place.
- Scripts/svn-create-patch: Ditto.
- Scripts/svn-unapply: Ditto.
- 9:09 AM Changeset in webkit [15392] by
-
- 3 edits in trunk/LayoutTests
LayoutTests:
Reviewed by NOBODY (layout test fix).
Remove property information left in files from svn-apply.
- fast/table/large-rowspan-crash-expected.txt:
- fast/table/large-rowspan-crash.html:
- 8:52 AM Changeset in webkit [15391] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix date.
- 8:30 AM Changeset in webkit [15390] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Maciej.
- another large rowspan test case
- fast/table/large-rowspan-crash-expected.txt: Added.
- fast/table/large-rowspan-crash.html: Added.
WebCore:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9806 <rdar://problem/4622622> REGRESSION: Large rowspan causes WebKit to call abort()
Test: fast/table/large-rowspan-crash.html
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use sizeof(RowStruct) instead of sizeof(int). Clearly we'll need something better to solve this completely. I expect another smaller, but still huge, value will still cause a problem.
- 6:32 AM Changeset in webkit [15389] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by ggaren.
Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope
http://bugzilla.opendarwin.org/show_bug.cgi?id=9869
- Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): Include the global frame in the stack.
- 4:28 AM Changeset in webkit [15388] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by ggaren.
Bug 9863: Drosera needs to show something at launch
http://bugzilla.opendarwin.org/show_bug.cgi?id=9863
- Drosera/DebuggerApplication.m: (-[DebuggerApplication applicationDidFinishLaunching:]): Show the attach window on launch.
- 3:33 AM Changeset in webkit [15387] by
-
- 5 edits4 adds in trunk
WebCore:
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const
- bridge/mac/FrameMac.h: Add focusCallResultedInViewBeingCreated argument.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): If the call to focus() caused the node to get a native widget, set focusCallResultedInViewBeingCreated to true.
(WebCore::FrameMac::nextKeyViewInFrameHierarchy):
Don't reset the focus node if focusCallResultedInViewBeingCreated is true. Also, add magic to prevent setting
a text field as the first responder if its field editor already is the current first responder.
- page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): In some cases, get the event target node again after dispatching the mouse event.
LayoutTests:
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const
- fast/forms/input-type-change-in-onfocus-keyboard-expected.txt: Added.
- fast/forms/input-type-change-in-onfocus-keyboard.html: Added.
- fast/forms/input-type-change-in-onfocus-mouse-expected.txt: Added.
- fast/forms/input-type-change-in-onfocus-mouse.html: Added.
- 3:18 AM Changeset in webkit [15386] by
-
- 4 edits in trunk/JavaScriptGlue
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Build fix
- JSUtils.cpp: (KJSValueToCFTypeInternal):
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
- UserObjectImp.cpp: (UserObjectImp::getPropertyList):
- 3:01 AM Changeset in webkit [15385] by
-
- 16 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Removed context and exception parameters from JSObjectGetPropertyEnumerator, removing the spurious use of ExecState inside JavaScriptCore that made us think this was necessary in the first place.
(StringInstance::getPropertyList): Use getString instead of toString because
we know we're dealing with a string -- we put it there in the first place.
While we're at it, store the string's size instead of retrieving it each time
through the loop, to avoid the unnecessary killing of puppies.
- kjs/string_object.h:
- 2:55 AM Changeset in webkit [15384] by
-
- 7 edits in trunk/JavaScriptCore
4eviewed by Geoff.
- add handling of hasInstance callback for API objects
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::implementsHasInstance): Check if callback is present. (KJS::JSCallbackObject::hasInstance): Invoke appropriate callback.
- API/JSCallbackObject.h:
- API/JSClassRef.cpp:
- API/JSObjectRef.h:
- API/testapi.c: (MyObject_hasInstance): Test case; should match what construct would do.
- API/testapi.js:
- 2:52 AM Changeset in webkit [15383] by
-
- 6 edits in trunk/WebCore
--This Reviewed by Adele.
Fix for <rdar://problem/4615765> Input[type='search' fields
initially render too large in Widgets
Fundamentally, the problem here is that we were miscalculating
things because [NSGraphicsContext currentContextDrawingToScreen]
was evaluating to false when widgets first load. We only ever used
this check, however, to determine if we were printing or not, so it
should not have evaluated to false for loading in Dashbaord.
Instead, if we query the RenderView about whether or not we are
printing, we will get the right answer.
No test case added since this appears only to affect Dashboard.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): Ask the RenderView if we are printing instead. This is not part of the actual bug fix, but it seems wise to get rid of all calls to [NSGraphicsContext currentContextDrawingToScreen] when we are just trying to determine if we are printing or not.
- platform/mac/ListBoxMac.mm: (itemTextRenderer):This function now takes a boolean, isPrinting. (groupLabelTextRenderer): Same as above. (ListBox::sizeForNumberOfLines): Ask the RenderView if we are printing. (-[WebCoreTableView drawRow:clipRect:]): Same as above.
- platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint): Same as above.
- platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
- rendering/RenderLineEdit.cpp: Same as above.
M WebCore/platform/mac/TextFieldMac.mm
M WebCore/platform/mac/PopUpButtonMac.mm
M WebCore/platform/mac/ListBoxMac.mm
M WebCore/rendering/RenderLineEdit.cpp
M WebCore/ChangeLog
M WebCore/bridge/mac/WebCoreFrameBridge.mm
- 2:32 AM Changeset in webkit [15382] by
-
- 2 edits in trunk/WebKit
Reviewed by Timothy.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
Applications shown in Drosera's "Attach" window remain after exit
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will know when the application is being exited. (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated. (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.
- 1:55 AM Changeset in webkit [15381] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Timothy.
Lets Drosera build universal for the nightlies. Right now it is not
possible to build a universal binary on a PPC machine because of a
conflict with the universal SDK.
- BuildSlaveSupport/build-launcher-app:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 1:31 AM Changeset in webkit [15380] by
-
- 3 edits in tags/WebKit-521.16.3/WebKit
Build fix for AGL. Versioning.
- 1:26 AM Changeset in webkit [15379] by
-
- 1 copy in tags/WebKit-521.16.3
new tag.
- 1:25 AM Changeset in webkit [15378] by
-
- 3 edits in trunk/WebKit
Reviewed by Tim Hatcher.
<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
from earlier.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.m:
- 1:17 AM Changeset in webkit [15377] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar
- fast/forms/option-text-clip-expected.checksum: Added.
- fast/forms/option-text-clip-expected.png: Added.
- fast/forms/option-text-clip-expected.txt: Added.
- fast/forms/option-text-clip.html: Added.
WebCore:
Reviewed by Maciej.
Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar
Test: fast/forms/option-text-clip.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject): When calculating the clip to apply to the button text, also consider padding. In the future, we may have separate renderers for the text part, and the arrow part of the control, and then the separation should be natural. For now, we use padding.
- 1:12 AM Changeset in webkit [15376] by
-
- 23 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Implemented a vast number of renames and comment clarifications suggested during API review.
JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->
JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.
- Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.
- Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.
- Moved standard library includes into the headers that actually require them.
- Standardized use of the phrase "Create Rule."
- Removed JSLock from make functions that don't allocate.
- Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.
- Renamed JSGCCollect to JSGarbageCollect.
Jul 11, 2006:
- 11:04 PM Changeset in webkit [15375] by
-
- 2 edits in tags/WebKit-521.16.2/WebKit
Build fix and versioning.
- 11:02 PM Changeset in webkit [15374] by
-
- 1 copy in tags/WebKit-521.16.2
New good tag.
- 11:02 PM Changeset in webkit [15373] by
-
- 1 delete in tags/WebKit-521.16.2
Bad tag.
- 11:01 PM Changeset in webkit [15372] by
-
- 1 copy in tags/WebKit-521.16.2/WebKit-521.16.1
new tag (part 2)
- 11:01 PM Changeset in webkit [15371] by
-
- 1 add in tags/WebKit-521.16.2
New tag.
- 11:00 PM Changeset in webkit [15370] by
-
- 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.m
More build fixes for the deprecated AGL functions.
- 9:26 PM Changeset in webkit [15369] by
-
- 1 edit in trunk/WebKitTools/Drosera/debugger.js
Forgot to commit a file this morning that actually makes the Drosera console open. Thanks bdash!
- 8:31 PM Changeset in webkit [15368] by
-
- 2 edits in trunk/WebCore
WebCore:
Windows build fix. Reviewed by NOBODY.
- WebCore.vcproj/WebCore/WebCore.vcproj: Added JSHTMLOptionsCollection.cpp/h and JSHTMLOptionsCollectionCuston.cpp. VC++ Express realphabetized the file list.
- 7:55 PM Changeset in webkit [15367] by
-
- 10 edits in trunk/WebCore
Reviewed by Adele.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9809 <rdar://problem/4619515> focus ring fails to appear on select element after choosing item from popup
- includes http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 improvements to select element, including some storage leak fixes
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const reference for the list items, so we don't have to copy a vector.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): Ditto. (WebCore::HTMLSelectElement::setSelectedIndex): Ditto. (WebCore::HTMLSelectElement::length): Ditto. (WebCore::HTMLSelectElement::remove): Ditto. (WebCore::HTMLSelectElement::value): Ditto. (WebCore::HTMLSelectElement::setValue): Ditto. (WebCore::HTMLSelectElement::stateValue): Ditto. (WebCore::HTMLSelectElement::restoreState): Ditto. (WebCore::HTMLSelectElement::appendFormData): Ditto. (WebCore::HTMLSelectElement::optionToListIndex): Ditto. (WebCore::HTMLSelectElement::listToOptionIndex): Ditto. (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate fields mutable. (WebCore::HTMLSelectElement::reset): Use a const reference for the list items, so we don't have to copy the vector. Remove the call to setSelectionChanged for the RenderMenuList case. (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts. (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing the pop-up.
- html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend. Changed the listItems function to return a const reference to the vector so it no longer copies the vector. Removed the const_cast to the call to recalcListItems and changed it to a const member function. Made m_recalcListItems mutable.
- rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call to recalcListItems, which is called automatically. Use a const reference for the list items so we don't have to copy a vector. (WebCore::DeprecatedRenderSelect::layout): Ditto. (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto. (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members. (WebCore::RenderMenuList::createInnerBlock): Ditto. (WebCore::RenderMenuList::addChild): Ditto. (WebCore::RenderMenuList::removeChild): Ditto. (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style on the pop-up menu, because it's created with the correct style and destroyed before it a style change could occur. (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the maximum width in a simpler fashion, and to not bother trying to maintain the "selected" flags on the elements, since the HTMLSelectElement class takes care of that. Store the width as an int. Call setText to set the text based on the selected element's option text. (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting up the clip -- always set up the clip. (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly instead of calling ceilf on m_longestWidth. (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the menu -- instead keep the pointer in a local variable. Get the selected index from the HTMLSelectElement. (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex to do most of the work.
- rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed m_longestWidth to m_optionsWidth and changed it to be an int. Removed unneeded override of removeLeftoverAnonymousBoxes function. Removed unneeded selectionChanged, setSelectionChanged, updateSelection, and hasPopupMenu functions. Removed extra includes.
- rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Change to iterate the list items instead of iterating all children of the select node.
- rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
- rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create the pop-up here from the caller. Removed an extra retain that would cause the NSPopUpButtonCell to leak. (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to create the pop-up, which is now in populate, and also the call to the clear function, for the same reason. Reorganized code to make it a bit more readable. Removed an unnecessary if to check if frame is nil. Used a RefPtr to make sure we don't make a call on a frame after it's deleted. As part of the reorganization fixed a problem where we'd retain the event and then return early without releasing it in one case. (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little. (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to manage the NSMenu at the bottom of the function. (WebCore::RenderPopupMenuMac::addOption): Ditto.
- 7:21 PM Changeset in webkit [15366] by
-
- 14 edits in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
- editing/deleting/delete-after-span-ws-001-expected.checksum:
- editing/deleting/delete-after-span-ws-001-expected.png:
- editing/deleting/delete-after-span-ws-002-expected.checksum:
- editing/deleting/delete-after-span-ws-002-expected.png:
- editing/deleting/delete-after-span-ws-003-expected.checksum:
- editing/deleting/delete-after-span-ws-003-expected.png:
- editing/deleting/delete-block-merge-contents-010-expected.checksum:
- editing/deleting/delete-block-merge-contents-010-expected.png:
- editing/deleting/merge-unrendered-space-expected.checksum:
- editing/deleting/merge-unrendered-space-expected.png:
WebCore:
Reviewed by levi
<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.
- 5:45 PM Changeset in webkit [15365] by
-
- 2 edits in trunk/WebCore/bindings/objc
better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.
- 5:40 PM Changeset in webkit [15364] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (build fix)
- bindings/objc/DOMPrivate.h: Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject there is of a different type. Also clarified a highly misleading comment from my last commit. I meant to clarify the comment before landing.
- 5:27 PM Changeset in webkit [15363] by
-
- 2 edits3 adds in trunk/WebCore
2006-07-12 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9635
REGRESSION: Crash when adding to cart at <http://www.yemeksepeti.com/>
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Don't load external scripts if the parser is stopped.
- manual-tests/open-close-tokenizer-crash.html: Added.
- manual-tests/resources/empty-file.js: Added.
- manual-tests/resources/open-close-tokenizer-crash.html: Added. Add manual test.
- 5:00 PM Changeset in webkit [15362] by
-
- 5 edits in trunk/WebKit
Reviewed by Kevin and Tim O
- added support for creating a selection image with white text
- WebView/WebDocumentPrivate.h: added -selectionImageForcingWhiteText: and -selectionImageRect to the private <WebDocumentSelection> protocol
- Misc/WebSearchableTextView.m: (-[NSString selectionImageForcingWhiteText:]): added stub for this new method to this obsolete class to satisfy the compiler (-[NSString selectionImageRect]): ditto
- WebView/WebHTMLView.m: (-[WebHTMLView _selectionDraggingImage]): now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage (-[WebHTMLView _selectionDraggingRect]): now calls selectionImageRect, to which the implementation moved (-[WebHTMLView selectionImageForcingWhiteText:]): implemented this new method by calling through to new bridge method selectionImageForcingWhiteText: (-[WebHTMLView selectionImageRect]): implemented this new method by using existing _selectionDraggingRect implementation
- WebView/WebPDFView.m: (-[WebPDFView selectionImageForcingWhiteText:]): implemented by using code that was formerly in Safari (-[WebPDFView selectionImageRect]): implemented by returning selectionRect
- 4:59 PM Changeset in webkit [15361] by
-
- 15 edits in trunk/WebCore
Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)
- added support for creating a selection image with white text
- rendering/RenderObject.h: (WebCore::): add PaintRestriction enum (WebCore::RenderObject::PaintInfo::PaintInfo): add forceWhiteText boolean to PaintInfo struct
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the text to white
- page/Frame.cpp: (WebCore::Frame::paint): updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::selectionImage): now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionImageForcingWhiteText:]): renamed from selectionImage, now takes forceWhiteText parameter, which is passed down into Frame
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): use a PaintRestriction value where we used to use a selectionOnly bool (WebCore::RenderLayer::paintLayer): ditto; also stores forceWhiteText in PaintInfo struct
- kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): updated for changed signature of PaintInfo constructor
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): ditto
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): ditto
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): paint with white text color if forceWhiteText is set in PaintInfo struct
- 4:58 PM Changeset in webkit [15360] by
-
- 18 edits4 adds in trunk
LayoutTests:
Reviewed by Geoff.
Test case for <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element
- plugins/netscape-dom-access-expected.checksum: Added.
- plugins/netscape-dom-access-expected.png: Added.
- plugins/netscape-dom-access-expected.txt: Added.
- plugins/netscape-dom-access.html: Added.
WebCore:
Reviewed by Anders.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element
- html/HTMLPlugInElement.h: Just import JSC headers on Mac. The NPObject and Bindings::Instance stuff is only used on Mac anyway. Changed APPLE to PLATFORM(MAC). Added m_NPObject ivar.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize the NPObject. (WebCore::HTMLPlugInElement::~HTMLPlugInElement): Release the NPObject when the element is destroyed. (WebCore::HTMLPlugInElement::createNPObject): Creates an NPObject for the element. (WebCore::HTMLPlugInElement::getNPObject): Returns the NPObject for the element, creating and caching it if necessary.
- html/HTMLAppletElement.h: Changed APPLE to PLATFORM(MAC).
- html/HTMLAppletElement.cpp: ditto
- html/HTMLEmbedElement.h: ditto
- html/HTMLEmbedElement.cpp: ditto
- html/HTMLObjectElement.h: ditto
- html/HTMLObjectElement.cpp: ditto
- bindings/objc/DOMPrivate.h: Added -[DOMElement _NPObject].
- bindings/objc/DOM.mm: (-[DOMElement _NPObject]): Returns the NPObject for the element. Since this is only needed by the Netscape plug-in API, you can only get the NPObject for applet, embed, and object elements.
WebKit:
Reviewed by Geoff.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Release DOM element. (-[WebBaseNetscapePluginView getVariable:value:]): Return NPObject for plugin DOM element.
- Plugins/WebNetscapePluginEmbeddedView.h:
- Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Pass DOMElement to Netscape plug-ins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto
- 4:32 PM Changeset in webkit [15359] by
-
- 8 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
REGRESSION: Can't dynamically change list box to popup
- fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
- fast/forms/select-change-listbox-to-popup-expected.png: Added.
- fast/forms/select-change-listbox-to-popup-expected.txt: Added.
- fast/forms/select-change-listbox-to-popup.html: Added.
- fast/forms/select-change-popup-to-listbox.html:
WebCore:
Reviewed by Hyatt.
- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861 REGRESSION: Can't dynamically change list box to popup
and updated fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box
The original fix for 9859 was in the renderer, and I think we can catch the change
earlier in the element to detach and reattach.
I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect
Test: fast/forms/select-change-listbox-to-popup.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa, and we're already attached, then detach and reattach to create the correct renderer. If we're not attached, then we'll create the correct renderer when we attach. (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle. (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto. (WebCore::HTMLSelectElement::isMouseFocusable): ditto. (WebCore::HTMLSelectElement::createRenderer): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::notifyOptionSelected): ditto. (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): This method no longer takes a RenderStyle. That was leftover from when we used to use the appearance to determine whether or not to use the new menu list implementation.
- rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
- rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::updateSelection):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Backed out previous fix since this is now done in HTMLSelectElement.
- 3:35 PM Changeset in webkit [15358] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by levi & thatcher
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- editing/selection/subframe-with-selection-expected.checksum: Added.
- editing/selection/subframe-with-selection-expected.png: Added.
- editing/selection/subframe-with-selection-expected.txt: Added.
- editing/selection/subframe-with-selection.html: Added.
WebKit:
Reviewed by levi & thatcher
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
- WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
- WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
- 3:13 PM Changeset in webkit [15357] by
-
- 1 copy in tags/WebCore-315.14.5/WebCore
Tag for WebCore 315.14.5 (part 2 of 2.)
- 3:13 PM Changeset in webkit [15356] by
-
- 1 add in tags/WebCore-315.14.5
Tag for WebCore 315.14.5 (part 1 of 2.)
- 3:13 PM Changeset in webkit [15355] by
-
- 1 delete in tags/WebCore-===
bad tag.
- 3:13 PM Changeset in webkit [15354] by
-
- 1 delete in tags/WebCore-315.14.4/WebCore/WebCore
bad tag.
- 3:12 PM Changeset in webkit [15353] by
-
- 1 copy in tags/WebCore-315.14.4/WebCore/WebCore
Tag for WebCore 315.14.4 (part 2 of 2.)
- 3:11 PM Changeset in webkit [15352] by
-
- 1 add in tags/WebCore-===
Tag for WebCore === (part 1 of 2.)
- 3:10 PM Changeset in webkit [15351] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning
- 3:08 PM Changeset in webkit [15350] by
-
- 3 edits in branches/Safari-1-3-branch/WebCore
Merged fix from Safari-2-0-branch to Safari-1-3-branch
2006-07-06 Adele Peterson <adele@apple.com>
Reviewed by Tim Hatcher.
- Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with $
- khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to $ If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exi$
- khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.
- 2:42 PM Changeset in webkit [15349] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box
- fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
- fast/forms/select-change-popup-to-listbox-expected.png: Added.
- fast/forms/select-change-popup-to-listbox-expected.txt: Added.
- fast/forms/select-change-popup-to-listbox.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box
Test: fast/forms/select-change-popup-to-listbox.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): If the select element has the multiple property set, or has a size > 1, then it really should be a list box, so we detach and attach the element so it creates the correct type of renderer.
- 2:31 PM Changeset in webkit [15348] by
-
- 2 edits in trunk/WebCore
Reviewed by Beth Dakin and Tim Omernick
- fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks at non-integral scale factors
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::imageFromRect): round image rect in window coordinate space
- 2:30 PM Changeset in webkit [15347] by
-
- 1 copy in tags/WebCore-418.20.1/WebCore
New tag (part 2).
- 2:28 PM Changeset in webkit [15346] by
-
- 1 add in tags/WebCore-418.20.1
Tag for WebCore 418.20.1 (part 1 of 2.)
- 2:23 PM Changeset in webkit [15345] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning
- 2:08 PM Changeset in webkit [15344] by
-
- 2 edits in tags/WebKit-521.16.1/WebKit
Build fix.
- 2:06 PM Changeset in webkit [15343] by
-
- 1 copy in tags/WebKit-521.16.1/WebKit
New tag (part 2)
- 2:05 PM Changeset in webkit [15342] by
-
- 1 add in tags/WebKit-521.16.1
New tag.
- 1:58 PM Changeset in webkit [15341] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
<rdar://problem/4622748> WebKit now uses deprecated AGL functions
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _createWindowedAGLContext]): aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.
- 12:07 PM Changeset in webkit [15340] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Add application/xhtml+xml to the Accept header
The fix itself was landed on 2006-07-09, but I forgot about the test.
- http/tests/misc/xhtml-expected.txt: Added.
- http/tests/misc/xhtml.php: Added.
- 11:54 AM Changeset in webkit [15339] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adele.
Adele checked in new results for this test when you could style
selects, but the styling of selects is turned off for now, so back
to the original results.
- fast/forms/001-expected.checksum:
- fast/forms/001-expected.png:
- fast/forms/001-expected.txt:
- 11:40 AM Changeset in webkit [15338] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding the radar to a change.
- 11:21 AM Changeset in webkit [15337] by
-
- 5 edits2 adds in trunk
Reviewed by Tim O.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7808 Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL
WebKit:
- Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Remove the early return when requesting an invalid (unsupported) URL.
WebKitTools:
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL - should open a new stream and deliver the data to the current instance.
LayoutTests:
- plugins/get-empty-url-expected.txt: Added.
- plugins/get-empty-url.html: Added.
- 11:13 AM Changeset in webkit [15336] by
-
- 6 edits4 adds in trunk/WebKitTools
Reviewed by Darin.
Bug 9598: [Drosera] add a JavaScript evaluator console
http://bugzilla.opendarwin.org/show_bug.cgi?id=9598
- Drosera/DebuggerApplication.h:
- Drosera/DebuggerApplication.m: (-[DebuggerApplication knownServers]):
- Drosera/DebuggerDocument.h:
- Drosera/DebuggerDocument.m: (-[WebScriptObject evaluateScript:inCallFrame:]): (-[WebScriptObject showConsole:]): (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[WebScriptObject toolbarDefaultItemIdentifiers:]): (-[WebScriptObject toolbarAllowedItemIdentifiers:]): (-[WebScriptObject webView:createWebViewWithRequest:]): (-[WebScriptObject webViewShow:]): (-[WebScriptObject webViewAreToolbarsVisible:]): (-[WebScriptObject webView:setToolbarsVisible:]): (-[WebScriptObject webView:setResizable:]): (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]): (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject webView:windowScriptObjectAvailable:]): (-[WebScriptObject webView:didFinishLoadForFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/Images/console.png: Added.
- Drosera/console.css: Added.
- Drosera/console.html: Added.
- Drosera/console.js: Added.
- 11:02 AM Changeset in webkit [15335] by
-
- 2 edits1 add in S60/trunk/WebKit
2006-07-11 zalan <zbujtas@gmail.com>
Reviewed by Sachin/David. Fix for:
Fix resource file directories. Missing #include <data_caging_paths.hrh>
- 8:00 AM Changeset in webkit [15334] by
-
- 2 edits in S60/trunk
2006-07-07 brmorris <bradley.morrison@nokia.com>
Reviewed by zbujtas@gmail.com.
- S60Internals/S60Headers.zip: data_caging_paths to \epoc32\include
Fix for:
- 7:21 AM Changeset in webkit [15333] by
-
- 2 edits in S60/trunk
2006-07-07 brmorris <bradley.morrison@nokia.com>
Reviewed by zbujtas@gmail.com
- build.bat: Now supports SDK 3rd ed maintenance release. Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9512
- 12:51 AM Changeset in webkit [15332] by
-
- 5 edits in trunk/WebKitTools
Reviewed by a tired Geoff.
Bug 9597: [Drosera] hook up the variables table to show stack variables
http://bugzilla.opendarwin.org/show_bug.cgi?id=9597
- Drosera/DebuggerDocument.m: (-[WebScriptObject isSelectorExcludedFromWebScript:]): (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): (-[WebScriptObject localScopeVariableNamesForCallFrame:]): (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]): (-[WebScriptObject webView:didLoadMainResourceForDataSource:]): (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
- Drosera/debugger.css:
- Drosera/debugger.html:
- Drosera/debugger.js:
- 12:30 AM Changeset in webkit [15331] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Beth Dakin.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9844>:
Add DOM access test to DumpRenderTree's Netscape plug-in
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (testDOMAccess): (pluginInvoke):
Jul 10, 2006:
- 11:04 PM Changeset in webkit [15330] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9811 rdar://problem/4619572 OPTION text contained in OPTGROUP appears at the wrong size
- dom/Node.h:
- dom/Node.cpp: (WebCore::Node::renderStyle): Made a const member function. The derived classes were overriding with const member functions, and I could change either this or the derived -- decided to do this.
- 10:48 PM Changeset in webkit [15329] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9810 OPTGROUP label text is using the default font instead of Lucida Grande
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Code wants the family name, but was calling fontName, which is not the same thing. Also removed the unneeded conversion to DeprecatedString.
- 10:37 PM Changeset in webkit [15328] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Darin.
- Changed public header includes to the <JavaScriptCore/ style.
- Changed instances of 'buffer' to 'string' since we decided on JSInternalString instead of JSStringBuffer.
- API/JSContextRef.h:
- API/JSInternalStringRef.cpp: (JSStringMake): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (CFStringCreateWithJSInternalString):
- API/JSInternalStringRef.h:
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType):
- API/JSObjectRef.cpp: (JSObjectCallAsConstructor):
- API/JSValueRef.h:
- API/JavaScriptCore.h:
- API/minidom.c: (main): (print):
- API/testapi.c: (MyObject_getPropertyList): (myConstructor_callAsConstructor): (main): I noticed that we were prematurely releasing some string buffers, so I moved their release calls to the end of main(). I got rid of 'Buf' in *Buf (sometimes changing to 'IString', when necessary to differentiate a variable) to match the buffer->string change.
- 9:36 PM Changeset in webkit [15327] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9839 Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load
Now track three states: initializing, running, and closed. If we are launched and the previous
state was initializing then we likely just experienced a crash on launch.
- WebKitLauncher/WebKitNightlyEnabler.m: (myApplicationWillFinishLaunching): Improve wording of dialog. Update to set new running state. (myApplicationWillTerminate): Update to use new states. (cleanUpAfterOurselves): Display alert if previous state was initializing. Set state as initializing as early as practical. (symbol_lookup): Bring code up to speed with formatting guidelines. (GDSymbolLookup): Ditto.
- 8:40 PM Changeset in webkit [15326] by
-
- 5 copies in tags/Safari-521.16
New tag.
- 8:37 PM Changeset in webkit [15325] by
-
- 2 edits in trunk/JavaScriptCore
- kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one more place. Just in case.
- 8:36 PM Changeset in webkit [15324] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Move the release tag.
- 8:34 PM Changeset in webkit [15323] by
-
- 3 edits in trunk/JavaScriptCore
- fix the release build
- kjs/value.h:
- kjs/value.cpp: (KJS::JSValue::toInt32Inline): Move the code here to an inline. (KJS::JSValue::toInt32): Call the inline from both overloaded toInt32 functions.
- 8:33 PM Changeset in webkit [15322] by
-
- 6 edits in /
Versioning
- 8:16 PM Changeset in webkit [15321] by
-
- 20 edits6 adds in trunk
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method
- JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
- JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for kjs/value.h to make it available as a forwarded header.
- kjs/lookup.h: (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method. The new method returns a boolean value if no entry is found in the lookup table.
- kjs/value.cpp: (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
- kjs/value.h: Ditto.
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method
- fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
- fast/dom/select-selectedIndex-multiple.html: Updated to print comments between tests to make failures easier to track down.
- fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
- fast/dom/select-selectedIndex.html: Ditto.
- fast/js/resources/select-options-add.js: Added.
- fast/js/select-options-add-expected.txt: Added.
- fast/js/select-options-add.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method
Tests:
- fast/dom/select-selectedIndex-multiple.html
- fast/dom/select-selectedIndex.html
- fast/js/select-options-add.html
- DerivedSources.make: Added JSHTMLOptionsCollection.h.
- ForwardingHeaders/kjs/operations.h: Added.
- WebCore.xcodeproj/project.pbxproj: Added new source files.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added. (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter):
- bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation. Renamed classes and methods for consistency. (KJS::JSHTMLElement::selectGetter): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionProtoFunc::callAsFunction): (KJS::getHTMLOptionsCollection):
- bindings/js/kjs_html.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute. Added support for Optional parameter attribute, which makes generated code assume overloaded implementation methods are available for a JavaScript function with optional arguments. Changed local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
- html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
- html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class. (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): (WebCore::HTMLOptionsCollection::add): (WebCore::HTMLOptionsCollection::selectedIndex): (WebCore::HTMLOptionsCollection::setSelectedIndex): (WebCore::HTMLOptionsCollection::setLength):
- html/HTMLOptionsCollection.h: Ditto.
- html/HTMLOptionsCollection.idl: Added.
- 7:02 PM Changeset in webkit [15320] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave Hyatt.
<rdar://problem/4602408> -webkit-highlight needs to support images and elements other than text
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
- rendering/RenderBox.h: Utility for subclasses.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Custom highlight in front of images.
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Custom highlight in front of list markers.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Custom highlight in front of objects.
- 6:22 PM Changeset in webkit [15319] by
-
- 6 edits in trunk/WebCore
Better fix for repainting issue with positioned objects when height
changes. Optimize when only a positioned child changes so that we don't
incorrectly do normal flow layout.
Reviewed by darin
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- rendering/RenderView.cpp: (WebCore::RenderView::layout):
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 5:27 PM Changeset in webkit [15318] by
-
- 1 edit1 delete in trunk/JavaScriptCore
No review necessary. Removed bogus file I accidentally checked in before.
- API/JSInternalSringRef.h: Removed.
- 5:26 PM Changeset in webkit [15317] by
-
- 15 edits in trunk/JavaScriptCore
Reviewed by Darin.
Added exception out parameter to API object callbacks, removed semi-bogus
JSContext(.*)Exception functions.
To make these calls syntactically simple, I added an exceptionSlot()
method to the ExecState class, which provides a JSValue slot in which to
store a JSValue* exception.
- API/APICast.h: (toRef):
- API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
- API/JSContextRef.cpp: (JSCheckSyntax):
- API/JSContextRef.h:
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild): (JSNode_construct):
- API/JSNode.h:
- API/JSNodeList.c: (JSNodeListPrototype_item): (JSNodeList_length): (JSNodeList_getProperty):
- API/JSObjectRef.h:
- API/minidom.c: (print):
- API/testapi.c: (MyObject_initialize): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
- JavaScriptCore.exp:
- kjs/ExecState.h: (KJS::ExecState::exceptionHandle):
- 4:52 PM Changeset in webkit [15316] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Beth.
Test for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com
- fast/forms/select-style-expected.checksum: Added.
- fast/forms/select-style-expected.png: Added.
- fast/forms/select-style-expected.txt: Added.
- fast/forms/select-style.html: Added.
WebCore:
Reviewed by Beth.
- Fix for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com
Test: fast/forms/select-style.html
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Don't let popups be style-able for now. We'll allow it later, when we have a good way to handle border & backgrounds and still having it look like a control.
- 4:50 PM Changeset in webkit [15315] by
-
- 2 edits in trunk/WebKit
Reviewed by John Sullivan.
- fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838> REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache
- WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is has just loaded it (when coming from the back/forward cache, it hasn't).
- 3:29 PM Changeset in webkit [15314] by
-
- 3 edits in trunk/WebCore
Reviewed by harrison
<rdar://problem/4619260>
9A213 + Safari 521.15.1 Crash with To Do's alarm icon (WebCore::maxDeepOffset(WebCore::Node const*) )
<rdar://problem/4619841>
REGRESSION: Dragging selection over input field results in a crash (WebCore::maxDeepOffset(WebCore::Node const*)
- WebCore.xcodeproj/project.pbxproj:
- editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Iterate using next/previousVisuallyDistinctCandidate instead of traverseNext/Previous node because we were skipping positions. Jump out of shadow trees. Migrate to isEditablePosition instead of isContentEditable.
- 3:25 PM Changeset in webkit [15313] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
Shuffling comments around from my last check-in to make things read
more clearly.
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 3:05 PM Changeset in webkit [15312] by
-
- 5 edits4 adds in trunk
Reviewed by Darin.
Fix for <rdar://problem/4621095> The should be a way to
access the user interface scale factor through the DOM
window.devicePixelRatio returns the user interface scale factor.
- page/DOMWindow.cpp: (WebCore::DOMWindow::devicePixelRatio):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 2:39 PM Changeset in webkit [15311] by
-
- 8 edits in S60/trunk
2006-07-10 David Carson <david.carson@nokia.com>
Reviewed by Sachin/Zalan.
Fix for network connection, remove use of InternetConnectionManager
http://bugzilla.opendarwin.org/show_bug.cgi?id=9451
- WebKit\BrowserView\src\HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequest) Added check fo NULL pointer as aConnectionPtr could be null after the cb
- S60WebUi\WebUi\src\WebUiSessionAndSecurity.cpp
- S60WebUi\WebUi\inc\WebUiSessionAndSecurity.h Removed dependancy on InternetConnectionManager, and removed ShowSessionInfo as the information is available from the Connection Manager application. Constructor no longer takes a InternetConnectionManager reference.
- S60WebUi\WebUi\data\WebUi.rss
- S60WebUi\WebUi\inc\WebUi.hrh Removed ShowSessionInfo menu option
- S60WebUi\WebUi\src\WebUiWindowContainer.cpp
- S60WebUi\WebUi\inc\WebUiWindowContainer.h (CWebUiWindowContainer::HandleCommandL): Removed ShowSessionInfo option (CWebUiWindowContainer::NetworkConnectionNeededL): Made function empty as Symbian default handler does the work.
- 2:17 PM Changeset in webkit [15310] by
-
- 13 edits in trunk/JavaScriptCore
Reviewed by Darin.
Improved type safety by implementing opaque JSValue/JSObject typing through
abuse of 'const', not void*. Also fixed an alarming number of bugs
exposed by this new type safety.
I made one design change in JavaScriptCore, which is that the JSObject
constructor should take a JSValue* as its prototype argument, not a JSObject*,
since we allow the prototype to be any JSValue*, including jsNull(), for
example.
- API/APICast.h: (toJS):
- API/JSBase.h:
- API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::staticFunctionGetter):
- API/JSCallbackObject.h:
- API/JSContextRef.cpp: (JSEvaluate):
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild):
- API/JSObjectRef.cpp: (JSObjectMake): (JSFunctionMakeWithBody): (JSObjectGetProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
- API/JSObjectRef.h:
- API/testapi.c: (main):
- ChangeLog:
- kjs/object.h: (KJS::JSObject::JSObject):
- 1:53 PM Changeset in webkit [15309] by
-
- 37 edits in trunk/LayoutTests
http://bugzilla.opendarwin.org/show_bug.cgi?id=9830
More pixel test results need updating since switching to native popup
- editing/selection/replaced-boundaries-3-expected.checksum:
- editing/selection/replaced-boundaries-3-expected.png:
- fast/block/margin-collapse/103-expected.checksum:
- fast/block/margin-collapse/103-expected.png:
- fast/forms/001-expected.checksum:
- fast/forms/001-expected.png:
- fast/forms/HTMLOptionElement_label01-expected.checksum:
- fast/forms/HTMLOptionElement_label01-expected.png:
- fast/forms/HTMLOptionElement_label02-expected.checksum:
- fast/forms/HTMLOptionElement_label02-expected.png:
- fast/forms/HTMLOptionElement_label03-expected.checksum:
- fast/forms/HTMLOptionElement_label03-expected.png:
- fast/forms/HTMLOptionElement_label04-expected.checksum:
- fast/forms/HTMLOptionElement_label04-expected.png:
- fast/forms/form-element-geometry-expected.checksum:
- fast/forms/form-element-geometry-expected.png:
- fast/forms/option-script-expected.checksum:
- fast/forms/option-script-expected.png:
- fast/forms/option-strip-whitespace-expected.checksum:
- fast/forms/option-strip-whitespace-expected.png:
- fast/invalid/014-expected.checksum:
- fast/invalid/014-expected.png:
- fast/parser/document-write-option-expected.checksum:
- fast/parser/document-write-option-expected.png:
- tables/mozilla/bugs/bug2479-3-expected.checksum:
- tables/mozilla/bugs/bug2479-3-expected.png:
- tables/mozilla/bugs/bug29326-expected.checksum:
- tables/mozilla/bugs/bug29326-expected.png:
- tables/mozilla/bugs/bug33855-expected.checksum:
- tables/mozilla/bugs/bug33855-expected.png:
- tables/mozilla/bugs/bug96334-expected.checksum:
- tables/mozilla/bugs/bug96334-expected.png:
- tables/mozilla/core/margins-expected.checksum:
- tables/mozilla/core/margins-expected.png:
- tables/mozilla/dom/tableDom-expected.checksum:
- tables/mozilla/dom/tableDom-expected.png:
- 10:47 AM Changeset in webkit [15308] by
-
- 4 edits in trunk
WebCore:
Reviewed by Alexey
Resolved the console error messages people got from the new DB even if they didn't have it enabled
- icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnreferencedIcons): (WebCore::IconDatabase::pruneUnretainedIcons): Added quick check to bail if the DB isn't open
WebKit:
Reviewed by Alexey
Resolved the console error messages people got from the new DB even if they didn't have it enabled
- Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Disabled initializing the IconDatabaseBridge if user is living on the old DB
- 10:41 AM Changeset in webkit [15307] by
-
- 16 edits1 copy2 moves in trunk/JavaScriptCore
Approved by Maciej, Darin.
Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
JavaScript engine's internal string representation, which is the most
low-level and efficient representation to use when interfacing with JavaScript.
- API/APICast.h: (toJS): (toRef):
- API/JSBase.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
- API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
- API/JSContextRef.h:
- API/JSInternalStringRef.cpp: Added. (JSStringMake): (JSInternalStringCreate): (JSInternalStringCreateUTF8): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (JSInternalStringIsEqual): (JSInternalStringIsEqualUTF8): (JSInternalStringCreateCF): (CFStringCreateWithJSInternalString):
- API/JSInternalStringRef.h: Added.
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
- API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
- API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
- API/JSObjectRef.h:
- API/JSStringBufferRef.cpp: Removed.
- API/JSStringBufferRef.h: Removed.
- API/JSValueRef.h:
- API/JavaScriptCore.h:
- API/minidom.c: (main): (print):
- API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 9:48 AM Changeset in webkit [15306] by
-
- 2 edits in trunk/WebCore
- 9:18 AM Changeset in webkit [15305] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text
- manual-tests/ATSU-bad-layout.html: Added.
- platform/mac/FontMac.mm: (WebCore::Font::floatWidthForComplexText): Return 0 immediately for empty runs.
- 8:54 AM Changeset in webkit [15304] by
-
- 2 edits in trunk/WebCore
- try to fix the no-SVG build
- ksvg2/misc/SVGImageLoader.cpp: Move namespace brace inside the #if.
- 8:53 AM Changeset in webkit [15303] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9833 REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first'
- manual-tests/empty-title-popup.html: Added.
- rendering/RenderMenuList.h: Add createInnerBlock.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createInnerBlock): Factored out of addChild. (WebCore::RenderMenuList::addChild): Call createInnerBlock. (WebCore::RenderMenuList::setText): Changed parameter type. (WebCore::RenderMenuList::showPopup): Call createInnerBlock before calling the parent class's addChild.
- 8:34 AM Changeset in webkit [15302] by
-
- 2 edits in trunk/WebKitTools
- try to fix Windows build
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove include paths with "khtml" in them. Add one for "html" subdir or WebCore.
- 8:00 AM Changeset in webkit [15301] by
-
- 2 edits in trunk/LayoutTests
- tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Updated one more result for Adele's 4463835 change last night.
- 5:57 AM Changeset in webkit [15300] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by Maciej via IRC. Patch by Rob Buis.
Make sure the attributes are calculated against viewport width value,
as defined in the spec. http://paste.lisp.org/display/22342
- ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::rx): Changed LM_HEIGHT to LM_WIDTH.
- ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::x2): Ditto.
- 4:39 AM Changeset in webkit [15299] by
-
- 10 edits13 adds in trunk
Reviewed by Maciej.
Fix for <rdar://problem/4610314> Support the CSS3 content property
for images
This patch provides initial support for the CSS3 content property.
It lacks support for any content other than images, and only allows
content for elements that seemed safe for now.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove restrictions for just :before and :after
- html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::createRenderer):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::createRenderer):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer):
- html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
- rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setCachedImage): Don't allow the image to be set this way if it was already set with the content property.
- rendering/RenderImage.h: (WebCore::RenderImage::setIsAnonymousImage): Anonymous images are those set through the content property. (WebCore::RenderImage::isAnonymousImage):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): If there is content specified, create a RenderImage with the content and initialize the cached image to whatever was specified in the CSS.
- 3:31 AM Changeset in webkit [15298] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (Build Fix!)
- icon/SiteIcon.cpp: (SiteIcon::getImage): Release build made an "unused variable" warning, which is, of course, an error. fixed that.
- 2:57 AM Changeset in webkit [15297] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej
SQLite Icon DB now fully replicates functionality of the old DB, including pruning to keep unused
information out to keep down disk usage. For now, it is still off by default, as the critical
feature of importing old icons into the new DB is still unrealized.
If you'd like to test, add #define ICONDEBUG to your WebKitPrefix.h
- icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): -Sets up a timer for initial pruning (WebCore::IconDatabase::iconForPageURL): -Switched away from "dirty blob hack" as the problem is provisionally solved (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): -Same as found in WebKit (WebCore::IconDatabase::totalRetainCountForIconURL): -Adds up all retainers of icon (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): -Wipes an Icon table entry out (WebCore::IconDatabase::establishTemporaryIconIDForIconURL): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): -Added ability to get an iconID without creating a new one if a lookup is all
that is genuinely wanted
(WebCore::IconDatabase::pruneUnreferencedIcons):
(WebCore::IconDatabase::pruneUnretainedIcons):
-Called on a timer on DB startup to clean it out
- icon/IconDatabase.h:
- icon/SiteIcon.cpp: (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): -Deletes the image on deletion (SiteIcon::getImage): -Cut down on no-longer-necessary debug info
- 2:02 AM Changeset in webkit [15296] by
-
- 4 edits2 adds in trunk
WebCore:
2006-07-10 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.
LayoutTest:
2006-07-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements
- fast/forms/activate-and-disabled-elements-expected.txt: Added.
- fast/forms/activate-and-disabled-elements.html: Added.
- 1:01 AM Changeset in webkit [15295] by
-
- 3 edits in trunk/WebCore
- try to fix Windows build
- platform/win/TemporaryLinkStubs.cpp: Put a few functions in the WebCore namespace.
- platform/gdk/TemporaryLinkStubs.cpp: Ditto.
- 12:59 AM Changeset in webkit [15294] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
- fix failures seen in layout tests
- bindings/js/kjs_dom.cpp: (KJS::toJS): Restore one of the few WebCore:: prefixes that really needed to be there -- because we have two classes named JSHTMLDocument at the moment! (One in KJS and one in WebCore namespace.)
- 12:40 AM Changeset in webkit [15293] by
-
- 2 edits in trunk/WebCore
- try to fix Windows build
- rendering/RenderLayer.h: Correct a forward declaration of ScrollBar.
- 12:33 AM Changeset in webkit [15292] by
-
- 2 edits in trunk/WebKit
- try to fix Windows build
- COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.
- 12:19 AM Changeset in webkit [15291] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Reviewed by Maciej.
Updated results for:
<rdar://problem/4463835> Switch to use new popup menu implementation for <select>
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
- fast/block/margin-collapse/103-expected.txt:
- fast/dom/option-properties-expected.txt:
- fast/forms/003-expected.txt:
- fast/forms/004-expected.txt:
- fast/forms/HTMLOptionElement_label01-expected.txt:
- fast/forms/HTMLOptionElement_label02-expected.txt:
- fast/forms/HTMLOptionElement_label03-expected.txt:
- fast/forms/HTMLOptionElement_label04-expected.txt:
- fast/forms/HTMLOptionElement_label06-expected.txt:
- fast/forms/HTMLOptionElement_label07-expected.txt:
- fast/forms/form-element-geometry-expected.txt:
- fast/forms/option-script-expected.txt:
- fast/forms/option-strip-whitespace-expected.txt:
- fast/forms/select-remove-option-expected.txt:
- fast/forms/select-replace-option-expected.txt:
- fast/forms/select-reset-expected.txt:
- fast/invalid/014-expected.txt:
- fast/parser/document-write-option-expected.txt:
- fast/replaced/width100percent-expected.txt:
- tables/mozilla/bugs/bug1188-expected.txt:
- tables/mozilla/bugs/bug18359-expected.txt:
- tables/mozilla/bugs/bug2479-3-expected.txt:
- tables/mozilla/bugs/bug2479-4-expected.txt:
- tables/mozilla/bugs/bug29326-expected.txt:
- tables/mozilla/bugs/bug33855-expected.txt:
- tables/mozilla/bugs/bug4382-expected.txt:
- tables/mozilla/bugs/bug96334-expected.txt:
- tables/mozilla/core/margins-expected.txt:
- tables/mozilla/dom/tableDom-expected.txt:
- 12:19 AM Changeset in webkit [15290] by
-
- 41 edits in trunk
Reviewed by Maciej.
Fix for <rdar://problem/4463835> Switch to use new popup menu implementation for <select>
- css/html4.css: Added style for new selects, and for list boxes.
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Removed check for appearance so new popups can be styled.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Removed padding. This is now set by the theme. (WebCore::RenderMenuList::calcMinMaxWidth): Now takes minimum text size into account.
- rendering/RenderMenuList.h: Removed baselinePosition since we're letting the theme calculate that.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlContainer): Added menuList as a ControlContainer, so RenderThemeMac will compute its baseline.
- rendering/RenderTheme.h: (WebCore::RenderTheme::minimumTextSize): Added.
- rendering/RenderThemeMac.h: Added minimumTextSize, setPopupPaddingFromControlSize, popupButtonSizes, popupButtonMargins, popupButtonPadding. Removed sizeOfArrowControl.
- rendering/RenderThemeMac.mm: (WebCore::): Added enum for padding. (WebCore::RenderThemeMac::adjustRepaintRect): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::baselinePosition): Now calculates baseline for menulist. (WebCore::RenderThemeMac::popupButtonMargins): Tweaked values. (WebCore::RenderThemeMac::popupButtonSizes): Added. (WebCore::RenderThemeMac::popupButtonPadding): Added, so different padding can be set for different control sizes. (WebCore::RenderThemeMac::setPopupPaddingFromControlSize): Added. (WebCore::RenderThemeMac::paintMenuList): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::adjustMenuListStyle): Resets border, sets padding, sets control size. (WebCore::RenderThemeMac::setPopupButtonCellState): Removed unnecessary class name. (WebCore::RenderThemeMac::minimumTextSize): Added.
Jul 9, 2006:
- 11:16 PM Changeset in webkit [15289] by
-
- 6 edits in trunk/WebCore
- add back "unused code" for plain text fields, still used by <isindex>!
- platform/TextField.h:
- platform/mac/TextFieldMac.mm:
- platform/mac/WebCoreTextField.h:
- platform/mac/WebCoreTextField.mm:
- rendering/RenderLineEdit.cpp:
- 11:15 PM Changeset in webkit [15288] by
-
- 2 edits in trunk/WebKit
- try to fix Windows build
- COM/WebFrame.cpp: Rename QChar to DeprecatedChar.
- 11:05 PM Changeset in webkit [15287] by
-
- 51 edits in trunk/WebKit
- fix newlines to be consistent for all files in the COM directory (many had mixed style) and set the EOL style to "native" on them.
- COM/*: Set properties and changed files.
- 10:20 PM Changeset in webkit [15286] by
-
- 219 edits in trunk/WebCore
Reviewed by Tim Hatcher.
- put more into the WebCore namespace
- removed unused code for plain text fields
Put more classes, class templates, enums, functions, and constants into
the WebCore namespace, including all the headers in the platform directory.
Removed lots of unneeded "WebCore::" qualifiers and "using" directives.
Added some "WebCore::" qualifiers in a few places.
Removed "uses WebCore::" in headers that we said we'd remove "when
everything is in the WebCore namespace".
- bindings/js/JSDOMParser.cpp:
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- bindings/js/JSXSLTProcessor.cpp:
- bindings/js/kjs_binding.cpp:
- bindings/js/kjs_css.cpp:
- bindings/js/kjs_dom.cpp:
- bindings/js/kjs_dom.h:
- bindings/js/kjs_events.cpp:
- bindings/js/kjs_proxy.h:
- bindings/js/kjs_window.h:
- bindings/objc/DOM.mm:
- bridge/History.h:
- bridge/JavaAppletWidget.h:
- bridge/mac/FormDataMac.h:
- bridge/mac/FormDataMac.mm:
- bridge/mac/WebCoreAXObject.mm:
- bridge/mac/WebCoreEncodings.mm:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreIconDatabaseBridge.mm:
- bridge/mac/WebCorePageState.h:
- bridge/mac/WebCoreScriptDebugger.mm:
- bridge/mac/WebCoreSettings.h:
- css/CSSGrammar.y:
- css/CSSPageRule.cpp:
- css/CSSPageRule.h:
- css/MediaList.cpp:
- css/cssstyleselector.h:
- dom/Clipboard.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/EventTargetNode.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/Position.h:
- dom/Range.cpp:
- dom/XMLTokenizer.cpp:
- editing/AppendNodeCommand.h:
- editing/ApplyStyleCommand.cpp:
- editing/BreakBlockquoteCommand.cpp:
- editing/BreakBlockquoteCommand.h:
- editing/CompositeEditCommand.cpp:
- editing/CompositeEditCommand.h:
- editing/CreateLinkCommand.h:
- editing/DeleteFromTextNodeCommand.h:
- editing/DeleteSelectionCommand.h:
- editing/FormatBlockCommand.h:
- editing/HTMLInterchange.cpp:
- editing/HTMLInterchange.h:
- editing/IndentOutdentCommand.h:
- editing/InsertIntoTextNodeCommand.h:
- editing/InsertLineBreakCommand.h:
- editing/InsertListCommand.h:
- editing/InsertNodeBeforeCommand.h:
- editing/InsertTextCommand.cpp:
- editing/InsertTextCommand.h:
- editing/JSEditor.cpp:
- editing/JSEditor.h:
- editing/JoinTextNodesCommand.h:
- editing/MergeIdenticalElementsCommand.cpp:
- editing/MergeIdenticalElementsCommand.h:
- editing/ModifySelectionListLevel.h:
- editing/MoveSelectionCommand.h:
- editing/RebalanceWhitespaceCommand.h:
- editing/RemoveNodeAttributeCommand.h:
- editing/RemoveNodeCommand.h:
- editing/RemoveNodePreservingChildrenCommand.h:
- editing/ReplaceSelectionCommand.h:
- editing/SetNodeAttributeCommand.h:
- editing/SplitElementCommand.cpp:
- editing/SplitElementCommand.h:
- editing/SplitTextNodeCommand.cpp:
- editing/SplitTextNodeCommand.h:
- editing/SplitTextNodeContainingElementCommand.h:
- editing/TypingCommand.cpp:
- editing/TypingCommand.h:
- editing/UnlinkCommand.h:
- editing/VisiblePosition.cpp:
- editing/WrapContentsInDummySpanCommand.cpp:
- editing/WrapContentsInDummySpanCommand.h:
- editing/markup.cpp:
- editing/markup.h:
- html/HTMLAnchorElement.cpp:
- html/HTMLBodyElement.cpp:
- html/HTMLButtonElement.h:
- html/HTMLCollection.h:
- html/HTMLDocument.h:
- html/HTMLEmbedElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLKeygenElement.cpp:
- html/HTMLLabelElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLObjectElement.h:
- html/HTMLTableElement.cpp:
- html/HTMLTablePartElement.cpp:
- icon/IconDatabase.h:
- kcanvas/KCanvasPath.h:
- kcanvas/KCanvasResources.cpp:
- kcanvas/KCanvasResources.h:
- kcanvas/KCanvasTreeDebug.cpp:
- kcanvas/KCanvasTreeDebug.h:
- kcanvas/RenderSVGContainer.cpp:
- kcanvas/RenderSVGText.h:
- kcanvas/device/KRenderingPaintServer.h:
- kcanvas/device/KRenderingPaintServerGradient.h:
- kcanvas/device/KRenderingPaintServerSolid.cpp:
- ksvg2/misc/SVGImageLoader.cpp:
- ksvg2/svg/SVGElement.cpp:
- ksvg2/svg/SVGElement.h:
- ksvg2/svg/SVGForeignObjectElement.cpp:
- ksvg2/svg/SVGForeignObjectElement.h:
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGPoint.h:
- ksvg2/svg/SVGStylable.h:
- ksvg2/svg/SVGTRefElement.cpp:
- ksvg2/svg/SVGTRefElement.h:
- ksvg2/svg/SVGTSpanElement.cpp:
- ksvg2/svg/SVGTSpanElement.h:
- ksvg2/svg/SVGTextElement.h:
- ksvg2/svg/svgpathparser.cpp:
- ksvg2/svg/svgpathparser.h:
- loader/Cache.h:
- loader/DocLoader.h:
- loader/LoaderFunctions.h:
- loader/mac/LoaderFunctionsMac.mm:
- page/Frame.h:
- page/FrameView.h:
- page/Page.h:
- page/Settings.h:
- platform/AffineTransform.cpp:
- platform/AffineTransform.h:
- platform/Arena.cpp:
- platform/Arena.h:
- platform/CookieJar.h:
- platform/DeprecatedCString.cpp:
- platform/DeprecatedCString.h:
- platform/DeprecatedPtrList.h:
- platform/DeprecatedPtrListImpl.cpp:
- platform/DeprecatedPtrListImpl.h:
- platform/DeprecatedPtrQueue.h:
- platform/DeprecatedString.cpp:
- platform/DeprecatedString.h:
- platform/DeprecatedStringList.cpp:
- platform/DeprecatedStringList.h:
- platform/DeprecatedValueList.h:
- platform/DeprecatedValueListImpl.cpp:
- platform/DeprecatedValueListImpl.h:
- platform/FileButton.h:
- platform/FloatPoint.h:
- platform/FloatRect.h:
- platform/FloatSize.h:
- platform/FontData.h:
- platform/FontFallbackList.h:
- platform/GraphicsContext.h:
- platform/IntPoint.h:
- platform/IntRect.h:
- platform/IntSize.h:
- platform/KURL.cpp:
- platform/KURL.h:
- platform/ListBox.h:
- platform/Logging.cpp:
- platform/Logging.h:
- platform/Pen.h:
- platform/PopUpButton.h:
- platform/RegularExpression.cpp:
- platform/RegularExpression.h:
- platform/SSLKeyGenerator.h:
- platform/ScrollBar.h:
- platform/SegmentedString.h:
- platform/Shared.h:
- platform/Slider.h:
- platform/StringImpl.h:
- platform/TextBox.h:
- platform/TextField.h:
- platform/TextStream.cpp:
- platform/TextStream.h:
- platform/TransferJob.h:
- platform/TransferJobClient.h:
- platform/Widget.h:
- platform/cg/AffineTransformCG.cpp:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/DeprecatedStringListMac.mm:
- platform/mac/FontCacheMac.mm:
- platform/mac/KURLMac.mm:
- platform/mac/ListBoxMac.mm:
- platform/mac/PopUpButtonMac.mm:
- platform/mac/SSLKeyGeneratorMac.mm:
- platform/mac/TextBoxMac.mm:
- platform/mac/TextFieldMac.mm:
- platform/mac/WebCoreTextArea.h:
- platform/mac/WebCoreTextArea.mm:
- platform/mac/WebCoreTextField.h:
- platform/mac/WebCoreTextField.mm:
- rendering/DeprecatedRenderSelect.h:
- rendering/RenderArena.cpp:
- rendering/RenderArena.h:
- rendering/RenderBlock.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderContainer.cpp:
- rendering/RenderFlexibleBox.cpp:
- rendering/RenderFlow.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLineEdit.cpp:
- rendering/RenderObject.h:
- rendering/RenderStyle.cpp:
- rendering/RenderStyle.h:
- rendering/RenderText.cpp:
- rendering/RenderTextFragment.cpp:
- rendering/RenderTheme.h:
- rendering/RenderTreeAsText.cpp:
- rendering/RenderTreeAsText.h:
- rendering/RenderView.h:
- rendering/bidi.h:
- xml/XSLStyleSheet.cpp:
- xml/XSLTProcessor.cpp:
- 10:18 PM Changeset in webkit [15285] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Beth.
Now that we garbage collect after reinitalizing the global object, not
before, we have more free memory, so a custom property that used to
get collected during the initialization phase of this test now avoids
getting collected until the collection phase.
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
WebCore:
Reviewed by Beth.
- bindings/js/kjs_window.cpp: (KJS::Window::clear): Garbage collect after reinitalizing the global object, not before, since the reinitialization tends to create garbage.
- 9:45 PM Changeset in webkit [15284] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Build fix. Reviewed by NOBODY.
- Backed out http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations
- Scripts/webkitdirs.pm: Backed out previous change.
- 9:25 PM Changeset in webkit [15283] by
-
- 3 edits in trunk/WebKit/WebView
Adding 2006 to the copyright years for headers I changed earlier.
- 9:18 PM Changeset in webkit [15282] by
-
- 3 edits in trunk/WebCore/bindings/objc
FIx the copyright dates to include all years published.
- 9:05 PM Changeset in webkit [15281] by
-
- 3 edits in trunk/WebCore/bindings/objc
Build fix for DumpRenderTree and other clients that don't use AppKit. Update the copyright date on headers I changed earlier.
- 9:00 PM Changeset in webkit [15280] by
-
- 3 edits in trunk/LayoutTests
LayoutTests:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9812 LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed
- svg/custom/foreign-object-skew-expected.checksum: Updated.
- svg/custom/foreign-object-skew-expected.png: Updated.
- 8:46 PM Changeset in webkit [15279] by
-
- 3 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9693 svn-apply should set ChangeLog date correctly when applying patches
- Scripts/svn-apply: Set the ChangeLog entry date using a configurable timezone before applying the patch.
- Scripts/svn-unapply: Reset the ChangeLog entry date before unapplying the patch.
- 8:26 PM Changeset in webkit [15278] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
<rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI
Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
This fixes many bugs involving plug-in mouse event handling in HiDPI. Most notably, the Flash player will now
correctly respond to clicks.
- Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
- 8:13 PM Changeset in webkit [15277] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- fix assertion firing in plug-in layout tests
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Don't start null events if the plug-in is not in the started state. This happens when the plug-in moves within its view hierarchy after it has been stopped.
- 8:02 PM Changeset in webkit [15276] by
-
- 14 edits in trunk
WebCore:
Reviewed by Darin.
Bug 9820: Move new DOM API that has been through API review to public headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=9820
- bindings/objc/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]): (-[DOMRange text]): (-[DOMRange _text]):
- bindings/objc/DOMCSS.mm: (-[DOMRGBColor color]): (-[DOMRGBColor _color]):
- bindings/objc/DOMCore.h:
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]): (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMXPath.h:
- bindings/objc/DOMXPath.mm:
WebKit:
Reviewed by Darin.
Bug 9820: Move new DOM API that has been through API review to public headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=9820
- Misc/WebElementDictionary.m: include DOMExtensions.h
- Misc/WebNSViewExtras.m: include DOMExtensions.h
- WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public
- 7:49 PM Changeset in webkit [15275] by
-
- 8 edits in trunk/WebKit
Reviewed by Kevin.
Bug 9818: move new UIDelegate API that has been through API review to public headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=9818
<rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.
Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.
- DefaultDelegates/WebDefaultUIDelegate.m:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge print]):
- WebView/WebFrameView.h:
- WebView/WebFrameView.m:
- WebView/WebFrameViewPrivate.h:
- WebView/WebUIDelegate.h:
- WebView/WebUIDelegatePrivate.h:
- 7:43 PM Changeset in webkit [15274] by
-
- 2 edits in trunk/LayoutTests
- fast/dom/delete-contents-expected.txt: Updated results that changed because we now keep comment nodes in the DOM.
- 7:31 PM Changeset in webkit [15273] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 A
nested content editable div causes unnecessary screen redraws.
We were repainting too much because we were deciding that we needed
a full layout because we didn't have a first line box. Our code
used to hold a lot of assumptions that positioned elements would
always have line boxes, but I fixed a few bugs a while back that
appeared because this assumption isn't true. This assumption was
also causing the extra redraws because the check meant that we
would decide to do a full layout for any positioned element that
did not have any line boxes in the first place. Maciej and I talked
about this, and we couldn't figure out why the check for line boxes
was part of determining if we need a full layout in the first
place. After hunting around the code, we decided to assume that
this check is antiquated. Removing it fixes the bug and doesn't
seem to break any layout tests. So, fingers crossed!
Will add layout test so soon.
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Remove firstLineBox check.
- 5:57 PM Changeset in webkit [15272] by
-
- 4 edits in trunk/WebKit
Reviewed by Darin.
Bug 9814: Move new WebView API that has been through API review to public headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=9814
- WebView/WebView.h:
- WebView/WebView.m: (-[WebView close]): (-[WebView setShouldCloseWithWindow:]): (-[WebView shouldCloseWithWindow]): (-[WebView selectedFrame]): (-[WebView setMainFrameURL:]): (-[WebView mainFrameURL]): (-[WebView isLoading]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView mainFrameDocument]): (-[WebView setDrawsBackground:]): (-[WebView drawsBackground]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView maintainsInactiveSelection]):
- WebView/WebViewPrivate.h:
- 5:11 PM Changeset in webkit [15271] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
Bug 9487: The XPath section should be removed and/or moved.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9487
- WebInspector/webInspector/inspector.css:
- WebInspector/webInspector/inspector.html:
- WebInspector/webInspector/inspector.js:
- 4:18 PM Changeset in webkit [15270] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by John Sullivan.
<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache
- fast/dom/delete-contents-expected.checksum: Added.
- fast/dom/delete-contents-expected.png: Added.
- fast/dom/delete-contents-expected.txt: Added.
- fast/dom/delete-contents.html: Added.
WebCore:
Reviewed by John Sullivan.
<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache
Test: fast/dom/delete-contents.html
- dom/Range.cpp: (WebCore::Range::processContents):
- 3:48 PM Changeset in webkit [15269] by
-
- 64 edits12 copies5 moves2 deletes in trunk/WebCore
- another round of renaming; and KWQ is dead
- WebCore.vcproj/WebCore/WebCore.vcproj: Remove paths for kwq and khtml directories. Move files to their new locations. Did rename.
- WebCore.xcodeproj/project.pbxproj: Move files to their new locations. Did rename.
- WebCoreSources.bkl: Did rename.
- webcore-base.bkl: Removed kwq.
- kwq/AccessibilityObjectCache.h: Removed.
- kwq/AccessibilityObjectCache.mm: Removed.
- kwq/FormDataMac.h: Removed.
- kwq/FormDataMac.mm: Removed.
- kwq/WebCoreAXObject.h: Removed.
- kwq/WebCoreAXObject.mm: Removed.
- kwq/WebCoreEditCommand.h: Removed.
- kwq/WebCoreEditCommand.mm: Removed.
- kwq/WebCorePageState.h: Removed.
- kwq/WebCorePageState.mm: Removed.
- kwq/WebCoreResourceLoaderImp.h: Removed.
- kwq/WebCoreResourceLoaderImp.mm: Removed.
- bridge/AXObjectCache.h: Added.
- bridge/mac/AXObjectCacheMac.mm: Added.
- bridge/mac/WebCoreAXObject.h: Added.
- bridge/mac/WebCoreAXObject.mm: Added.
- loader/CachedObject.cpp: Removed.
- loader/CachedObject.h: Removed.
- loader/CachedObjectClient.h: Removed.
- loader/CachedObjectClientWalker.cpp: Removed.
- loader/CachedObjectClientWalker.h: Removed.
- loader/CachedResource.cpp: Added.
- loader/CachedResource.h: Added.
- loader/CachedResourceClient.h: Added.
- loader/CachedResourceClientWalker.cpp: Added.
- loader/CachedResourceClientWalker.h: Added.
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreFrameBridge.mm:
- css/CSSImageValue.h:
- css/CSSImportRule.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/Notation.h:
- dom/ProcessingInstruction.h:
- dom/XMLTokenizer.cpp:
- html/CanvasPattern.h:
- html/HTMLDocument.h:
- html/HTMLImageLoader.cpp:
- html/HTMLImageLoader.h:
- html/HTMLLinkElement.h:
- html/HTMLScriptElement.cpp:
- html/HTMLScriptElement.h:
- html/HTMLTokenizer.cpp:
- html/HTMLTokenizer.h:
- kcanvas/KCanvasFilters.h:
- ksvg2/svg/SVGCursorElement.cpp:
- ksvg2/svg/SVGCursorElement.h:
- ksvg2/svg/SVGFEImageElement.cpp:
- ksvg2/svg/SVGFEImageElement.h:
- loader/Cache.cpp:
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp:
- loader/CachedImage.h:
- loader/CachedScript.cpp:
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp:
- loader/CachedXSLStyleSheet.h:
- loader/DocLoader.cpp:
- loader/DocLoader.h:
- loader/LoaderFunctions.h:
- loader/Request.cpp:
- loader/Request.h:
- loader/loader.cpp:
- loader/loader.h:
- loader/mac/LoaderFunctionsMac.mm:
- page/Frame.cpp:
- page/FrameView.cpp:
- platform/gdk/TemporaryLinkStubs.cpp:
- platform/mac/ClipboardMac.h:
- platform/win/TemporaryLinkStubs.cpp:
- rendering/RenderBox.h:
- rendering/RenderContainer.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImage.h:
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderStyle.cpp:
- rendering/RenderStyle.h:
- xml/XSLImportRule.h: Did renaming.
- platform/mac/can-convert.mm: Removed.
- 3:39 PM Changeset in webkit [15268] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Final version of this round of renaming for posterity.
- 3:35 PM Changeset in webkit [15267] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove conflict marker.
- 2:42 PM Changeset in webkit [15266] by
-
- 1 edit in trunk/WebKit/ChangeLog
Remove conflict marker. Thanks Mitz!
- 2:39 PM Changeset in webkit [15265] by
-
- 7 edits in trunk
WebCore:
2006-07-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Tim O.
- WebCore.exp: Add wkPathFromFont.
- platform/mac/FontDataMac.mm: (-[NSFont WebCore]): Use wkPathFromFont.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: Declare wkPathFromFont.
WebKit:
2006-07-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Tim O.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkPathFromFont.
- 2:31 PM Changeset in webkit [15264] by
-
- 3 edits in trunk/WebKitLibraries
2006-07-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a: Add WKPathFromFont.
- 2:11 PM Changeset in webkit [15263] by
-
- 2 edits in trunk/WebKit
- fix release build
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so that we don't have an unused variable in versions with assertions disabled. The alternative would be to wrap the whole thing in an #if statement.
- 1:37 PM Changeset in webkit [15262] by
-
- 6 edits in trunk
Reviewed by Maciej.
Added an OpenGL drawing model to the Netscape Plug-in API.
- bindings/npapi.h:
WebKit:
Reviewed by John Sullivan.
- Plugins/WebBaseNetscapePluginView.h:
- Added ivars for OpenGL support. Someday it would be nice to refactor this class so that each drawing model is encapsulated in a class; this would allow WebBaseNetscapePluginView to make more efficient use of space, for example by not keeping OpenGL-related ivars for Quickdraw plug-ins.
- Plugins/WebBaseNetscapePluginView.m:
- Declared a bunch of internal methods for OpenGL support (see below).
- Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES", so I just cleaned up the silly code that used it.
- Declared OpenGL port state struct. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- Moved a CoreGraphics-related assertion down to the big "switch" statement.
- Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to request that the browser use a "windowless" (offscreen) context instead.
- Moved the assertion from the top of this method here; removed a less restrictive assertion that is now obsolete.
- Removed "forUpdate" flag from CoreGraphics port state struct.
- Fill in OpenGL port state struct. Set up the viewport appropriately for both windowed and windowless OpenGL plug-ins. Windowed plug-ins need to have their GL viewport transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen into a surface whose geometry is never changed or clipped, so they may always draw with a viewport origin of (0, 0). (-[WebBaseNetscapePluginView restorePortState:]):
- Removed "forUpdate" flag from CoreGraphics port state struct.
- Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:. (-[WebBaseNetscapePluginView sendEvent:]):
- Updated an assertion to also include OpenGL. To ensure that attached plug-in window movements happen atomically with web page redisplays, we assert that the plug-in's window is set only while the plug-in view is redrawing.
- Same deal as with the assertion; only save/set port state when redrawing the plug-in view. Plug-ins that use the new drawing models are only allowed to draw when the web page draws. I might consider changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
- Compare new NP_GLContext structs. (-[WebBaseNetscapePluginView updateAndSetWindow]):
- In OpenGL mode, can only set window when updating plug-in view. (-[WebBaseNetscapePluginView setWindowIfNecessary]):
- ditto
- Updated logging for OpenGL drawing mode. (-[WebBaseNetscapePluginView addWindowObservers]):
- No need to observe frame/bounds change notifications for this and all parent views. See -renewGState comments below. (-[WebBaseNetscapePluginView removeWindowObservers]):
- Don't need to remove frame/bounds observers anymore. (-[WebBaseNetscapePluginView start]):
- Plug-ins are "windowed" by default. This is not a change from our previous behavior, but this is a better place to set the default value as it allows the plug-in to override it later. (-[WebBaseNetscapePluginView stop]):
- Destroy AGL context when the plug-in stops. (-[WebBaseNetscapePluginView dealloc]):
- Assert that the AGL stuff has been cleaned up. (-[WebBaseNetscapePluginView drawRect:]):
- If this is a windowless OpenGL plugin, blit its contents back into this view. (-[WebBaseNetscapePluginView renewGState]):
- This method is called when the view or one of its parents is moved or resized (see comments). (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
- Hide the AGL window if the plug-in view is about to be removed from its window. (-[WebBaseNetscapePluginView viewHasMoved:]):
- Renamed and moved to the "Internal" category. (-[WebBaseNetscapePluginView invalidateRegion:]):
- Style changes.
- Add support for OpenGL (uses the same region type as CoreGraphics). (-[WebBaseNetscapePluginView getVariable:value:]):
- Style changes.
- Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model. (-[WebBaseNetscapePluginView setVariable:value:]):
- Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in "windowed" or "windowless" mode. This is an older part of the Netscape Plug-in API that was never implemented in WebKit. "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on other platforms. However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so that they have some way of specifying whether they should be rendered on an accelerated overlay surface, composited into the browser window.
- Support for setting the drawing model to OpenGL. (-[WebBaseNetscapePluginView _viewHasMoved]):
- Renamed from -viewHasMoved:, and moved down in the file.
- None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly restored when it is moved back into a window.
- Reshape OpenGL surface window here. (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
- Creates the AGL context of the appropriate type (windowed/windowless). (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
- Creates a windowed AGL context, which is an AGL context attached to a child window. This is the only way to get true hardware acceleration. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
- Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer. This buffer can then be blitted back into the browser window with a different alpha, or scaled, or whatever. (-[WebBaseNetscapePluginView _cglContext]):
- Returns the underlying CGL context from the AGL context. We give the plug-in access to the CGL context because CGL is the more primitive of the GL drawable APIs and allows for finer control over the context. (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
- Returns the buffer allocated for the offscreen AGL context, if there is one. (-[WebBaseNetscapePluginView _destroyAGLContext]):
- Destroys the AGL context, as well as the associated offscreen buffer or child window. (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
- Positions the AGL window over the browser window. (-[WebBaseNetscapePluginView _hideAGLWindow]):
- Hides the AGL window. (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
- Returns an NSImage representation of the offscreen AGL context's framebuffer. This is used to draw the offscreen bits back into the plug-in view. This is kind of tricky because it has to convert the offscreen buffer in-place from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep. See comments.
- WebKit.xcodeproj/project.pbxproj: Link OpenGL and AGL.
- 11:10 AM Changeset in webkit [15261] by
-
- 1 edit in trunk/WebKit/ChangeLog
Fixed a nearly unparsable ChangeLog entry
- 10:52 AM Changeset in webkit [15260] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej
Set the stage to remove the workaround for the SQLite BLOB corruption. A few other small cleanups, and
preparation for pruning unreferenced and unretained icons.
- icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): Added another trigger to assist in icon removal (WebCore::IconDatabase::deletePrivateTables): Cleaned up logging messages (WebCore::IconDatabase::imageDataForIconID): #ifdefed the blobbing hack for impending removal, use the real blob by default (WebCore::IconDatabase::imageDataForIconURL): same (WebCore::IconDatabase::imageDataForPageURL): same (WebCore::IconDatabase::pruneUnreferencedIcons): Will delete any icons and their data that are not referenced by any PageURL
- icon/IconDatabase.h:
- icon/SQLDatabase.h: Changed BlobAsVector to be unsigned char as thats the most reasonable type for a byte-buffer, and is what CFData expects
- icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector):
- 10:38 AM Changeset in webkit [15259] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej
The ICONDEBUG flag no choose either/or the new icon database and the old one
No longer any need to live side by side to compare results
- Misc/WebIconDatabase.m: (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
- 10:03 AM Changeset in webkit [15258] by
-
- 29 edits1 copy23 moves5 deletes in trunk/WebCore
- move all but the last 12 files out of kwq directory
- removed a few unused source files I discovered
- WebCore.vcproj/WebCore/WebCore.vcproj: Update for new file locations.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bridge/mac/FrameMac.mm:
- dom/Element.h:
- html/HTMLImageLoader.cpp:
- loader/Cache.cpp:
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp:
- loader/CachedImage.h:
- loader/CachedObject.h:
- loader/CachedScript.cpp:
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp:
- loader/CachedXSLStyleSheet.h:
- loader/DocLoader.cpp:
- loader/DocLoader.h:
- page/Frame.cpp:
- page/Frame.h:
- page/FramePrivate.h:
- platform/gdk/TemporaryLinkStubs.cpp:
- platform/win/TemporaryLinkStubs.cpp:
- rendering/DeprecatedSlider.cpp:
- rendering/RenderObject.h:
- xml/xmlhttprequest.cpp: Updated includes as needed for file location changes. Changed CachePolicy uses to match new filename and enum names.
- loader/CachedResource.cpp: Removed.
- loader/CachedResource.h: Removed.
- loader/CachedResourceClient.h: Removed.
- loader/CachedResourceClientWalker.cpp: Removed.
- loader/CachedResourceClientWalker.h: Removed. The above files were checked in by accident a while back. The rename of CachedObject to CachedResource is now reflected in do-webcore-rename, and will be done soon.
- kwq/AffineTransform.cpp: Removed.
- kwq/AffineTransform.h: Removed.
- kwq/CacheControl.h: Removed.
- kwq/DeprecatedPtrQueue.h: Removed.
- kwq/FileButton.h: Removed.
- kwq/FileButton.mm: Removed.
- kwq/ListBox.h: Removed.
- kwq/ListBox.mm: Removed.
- kwq/LoaderFunctions.h: Removed.
- kwq/LoaderFunctions.mm: Removed.
- kwq/PopUpButton.h: Removed.
- kwq/PopUpButton.mm: Removed.
- kwq/SSLKeyGenerator.h: Removed.
- kwq/SSLKeyGenerator.mm: Removed.
- kwq/Settings.h: Removed.
- kwq/TextBox.h: Removed.
- kwq/TextBox.mm: Removed.
- kwq/TextField.h: Removed.
- kwq/TextField.mm: Removed.
- kwq/WebCoreScrollBar.h: Removed.
- kwq/WebCoreScrollBar.mm: Removed.
- kwq/WebCoreSlider.h: Removed.
- kwq/WebCoreSlider.mm: Removed.
- loader/CachePolicy.h: Added.
- loader/LoaderFunctions.h: Added.
- loader/mac/LoaderFunctionsMac.mm: Added.
- page/Settings.h: Added.
- platform/AffineTransform.cpp: Added.
- platform/AffineTransform.h: Added.
- platform/DeprecatedPtrQueue.h: Added.
- platform/FileButton.h: Added.
- platform/ListBox.h: Added.
- platform/PopUpButton.h: Added.
- platform/SSLKeyGenerator.h: Added.
- platform/ScrollBar.h: Added.
- platform/Slider.h: Added.
- platform/TextBox.h: Added.
- platform/TextField.h: Added.
- platform/cg/AffineTransformCG.cpp: Added.
- platform/mac/FileButtonMac.mm: Added.
- platform/mac/ListBoxMac.mm: Added.
- platform/mac/PopUpButtonMac.mm: Added.
- platform/mac/SSLKeyGeneratorMac.mm: Added.
- platform/mac/ScrollBarMac.mm: Added.
- platform/mac/ScrollBarMac.mm: Added.
- platform/mac/SliderMac.mm: Added.
- platform/mac/SliderMac.mm: Added.
- platform/mac/TextBoxMac.mm: Added.
- platform/mac/TextFieldMac.mm: Added.
- 9:36 AM Changeset in webkit [15257] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Next round of renaming. (Last round was done.)
- 8:53 AM Changeset in webkit [15256] by
-
- 2 edits in trunk/LayoutTests
LayoutTests:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9797 Make description() in fast/js/resources/js-test-pre.js work with MSIE 6
- fast/js/resources/js-test-pre.js: Change description() to work with MSIE 6.
- 8:42 AM Changeset in webkit [15255] by
-
- 4 edits4 moves in trunk/WebCore
- move 4 files out of kwq directory
- make some minor project adjustments for the WebCore project
- WebCore.xcodeproj/project.pbxproj: Link libsqlite3 the same way we do other libraries, rather than using a custom linker option. Moved the files from their old locations to the new ones. Removed "khtml" from the list of header search paths since that directory doesn't exist any more. Eliminated STYLE_LDFLAGS and just put -umbrella WebKit in OTHER_LDFLAGS in the Production configuration (was a leftover from "build styles" in Xcode 1). Changed to use EXPORTED_SYMBOLS_FILE instead of using -exported_symbols_list directly again now that Xcode has fixed the "strip twice" bug. Removed unneeded explicit SECTORDER_FLAGS = "" settings. Removed the explicit -Y,3 option now that Xcode does that by default.
- WebCore.vcproj/WebCore/WebCore.vcproj: Removed some obsolete uneeded files, many of which didn't exist any more. Moved the files from their old locations to the new ones.
- WebCoreSources.bkl: Moved the files from their old locations to the new ones.
- kwq/DeprecatedCString.cpp: Removed.
- kwq/DeprecatedCString.h: Removed.
- kwq/TextStream.cpp: Removed.
- kwq/TextStream.h: Removed.
- platform/DeprecatedCString.cpp: Added.
- platform/DeprecatedCString.h: Added.
- platform/TextStream.cpp: Added.
- platform/TextStream.h: Added.
- 8:23 AM Changeset in webkit [15254] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by NOBODY (build fix).
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations
- Scripts/webkitdirs.pm: Restore Hyatt's original logic to make buildbot work again. Add VC++ Express check as the fallback.
- 8:10 AM Changeset in webkit [15253] by
-
- 226 edits46 moves in trunk/WebCore
Rubber stamped by Maciej (kinda).
- did the next pass of renaming (used do-webcore-rename script) this takes care of most of the remaining KWQ names (almost all)
- WebCore+SVG/DOMList.h:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/kjs_dom.cpp:
- bindings/js/kjs_window.cpp:
- bindings/objc/DOMHTML.mm:
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreFrameBridge.mm:
- bridge/mac/WebCoreSettings.h:
- bridge/mac/WebCoreSettings.mm:
- bridge/win/FrameWin.cpp:
- css/CSSPrimitiveValue.cpp:
- css/CSSValueKeywords.in:
- css/MediaQueryEvaluator.cpp:
- css/cssparser.cpp:
- css/cssstyleselector.cpp:
- css/cssstyleselector.h:
- dom/CharacterData.cpp:
- dom/CharacterData.h:
- dom/Document.cpp:
- dom/Element.cpp:
- dom/Element.h:
- dom/EventTargetNode.cpp:
- dom/EventTargetNode.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/Position.cpp:
- dom/ProcessingInstruction.cpp:
- dom/QualifiedName.cpp:
- dom/QualifiedName.h:
- dom/XMLTokenizer.cpp: Added.
- dom/xml_tokenizer.cpp: Removed.
- dom/xml_tokenizer.h: Removed.
- editing/EditAction.h:
- editing/HTMLInterchange.cpp:
- editing/HTMLInterchange.h:
- editing/Selection.h:
- editing/SelectionController.h:
- editing/TextAffinity.h:
- editing/TextIterator.cpp:
- editing/TextIterator.h:
- editing/VisiblePosition.h:
- editing/htmlediting.cpp:
- editing/markup.cpp:
- editing/markup.h:
- editing/visible_units.cpp:
- editing/visible_units.h:
- html/HTMLDocument.cpp:
- html/HTMLFontElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLKeygenElement.cpp:
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.cpp:
- html/HTMLTextFieldInnerElement.cpp:
- html/HTMLTokenizer.cpp:
- html/HTMLTokenizer.h:
- kcanvas/KCanvasContainer.cpp: Removed.
- kcanvas/KCanvasContainer.h: Removed.
- kcanvas/KCanvasCreator.cpp:
- kcanvas/KCanvasFilters.cpp:
- kcanvas/KCanvasFilters.h:
- kcanvas/KCanvasMatrix.cpp:
- kcanvas/KCanvasMatrix.h:
- kcanvas/KCanvasPath.cpp:
- kcanvas/KCanvasPath.h:
- kcanvas/KCanvasResources.cpp:
- kcanvas/KCanvasResources.h:
- kcanvas/KCanvasTreeDebug.cpp:
- kcanvas/KCanvasTreeDebug.h:
- kcanvas/RenderForeignObject.cpp:
- kcanvas/RenderForeignObject.h:
- kcanvas/RenderPath.cpp:
- kcanvas/RenderPath.h:
- kcanvas/RenderSVGContainer.cpp: Added.
- kcanvas/RenderSVGContainer.h: Added.
- kcanvas/RenderSVGImage.cpp:
- kcanvas/RenderSVGImage.h:
- kcanvas/RenderSVGText.cpp:
- kcanvas/RenderSVGText.h:
- kcanvas/device/KRenderingPaintServer.h:
- kcanvas/device/KRenderingPaintServerGradient.cpp:
- kcanvas/device/KRenderingPaintServerGradient.h:
- kcanvas/device/KRenderingPaintServerPattern.cpp:
- kcanvas/device/KRenderingPaintServerPattern.h:
- kcanvas/device/KRenderingPaintServerSolid.cpp:
- kcanvas/device/KRenderingPaintServerSolid.h:
- kcanvas/device/quartz/KCanvasFilterQuartz.mm:
- kcanvas/device/quartz/KCanvasItemQuartz.h:
- kcanvas/device/quartz/KCanvasResourcesQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
- ksvg2/css/CSSValueKeywords.in:
- ksvg2/css/SVGRenderStyleDefs.cpp:
- ksvg2/misc/KCanvasRenderingStyle.cpp:
- ksvg2/misc/KSVGTimeScheduler.cpp:
- ksvg2/svg/SVGAElement.cpp:
- ksvg2/svg/SVGAnimateTransformElement.cpp:
- ksvg2/svg/SVGAnimateTransformElement.h:
- ksvg2/svg/SVGGElement.cpp:
- ksvg2/svg/SVGHelper.cpp:
- ksvg2/svg/SVGHelper.h:
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGLinearGradientElement.cpp:
- ksvg2/svg/SVGMarkerElement.cpp:
- ksvg2/svg/SVGMaskElement.cpp:
- ksvg2/svg/SVGMatrix.cpp:
- ksvg2/svg/SVGMatrix.h:
- ksvg2/svg/SVGPatternElement.cpp:
- ksvg2/svg/SVGRadialGradientElement.cpp:
- ksvg2/svg/SVGSVGElement.cpp:
- ksvg2/svg/SVGStyledElement.h:
- ksvg2/svg/SVGStyledTransformableElement.cpp:
- ksvg2/svg/SVGStyledTransformableElement.h:
- ksvg2/svg/SVGSwitchElement.cpp:
- ksvg2/svg/SVGTextElement.cpp:
- ksvg2/svg/SVGTransformable.h:
- ksvg2/svg/SVGUseElement.cpp:
- kwq/AffineTransform.cpp: Added.
- kwq/AffineTransform.h: Added.
- kwq/DeprecatedCString.cpp: Added.
- kwq/DeprecatedCString.h: Added.
- kwq/DeprecatedPtrQueue.h: Added.
- kwq/FileButton.h: Added.
- kwq/FileButton.mm: Added.
- kwq/FormDataMac.mm: Added.
- kwq/KWQCString.cpp: Removed.
- kwq/KWQCString.h: Removed.
- kwq/KWQComboBox.h: Removed.
- kwq/KWQComboBox.mm: Removed.
- kwq/KWQEditCommand.h: Removed.
- kwq/KWQEditCommand.mm: Removed.
- kwq/KWQFileButton.h: Removed.
- kwq/KWQFileButton.mm: Removed.
- kwq/KWQFormData.h: Removed.
- kwq/KWQFormData.mm: Removed.
- kwq/KWQKHTMLSettings.h: Removed.
- kwq/KWQKIOGlobal.h: Removed.
- kwq/KWQKSSLKeyGen.h: Removed.
- kwq/KWQKSSLKeyGen.mm: Removed.
- kwq/KWQLineEdit.h: Removed.
- kwq/KWQLineEdit.mm: Removed.
- kwq/KWQListBox.h: Removed.
- kwq/KWQListBox.mm: Removed.
- kwq/KWQLoader.h: Removed.
- kwq/KWQLoader.mm: Removed.
- kwq/KWQPageState.h: Removed.
- kwq/KWQPageState.mm: Removed.
- kwq/KWQPtrQueue.h: Removed.
- kwq/KWQResourceLoader.h: Removed.
- kwq/KWQResourceLoader.mm: Removed.
- kwq/KWQScrollBar.h: Removed.
- kwq/KWQScrollBar.mm: Removed.
- kwq/KWQSlider.h: Removed.
- kwq/KWQSlider.mm: Removed.
- kwq/KWQTextEdit.h: Removed.
- kwq/KWQTextEdit.mm: Removed.
- kwq/KWQTextStream.cpp: Removed.
- kwq/KWQTextStream.h: Removed.
- kwq/KWQWMatrix.cpp: Removed.
- kwq/KWQWMatrix.h: Removed.
- kwq/ListBox.h: Added.
- kwq/ListBox.mm: Added.
- kwq/LoaderFunctions.h: Added.
- kwq/LoaderFunctions.mm: Added.
- kwq/PopUpButton.h: Added.
- kwq/PopUpButton.mm: Added.
- kwq/SSLKeyGenerator.h: Added.
- kwq/SSLKeyGenerator.mm: Added.
- kwq/Settings.h: Added.
- kwq/TextBox.h: Added.
- kwq/TextBox.mm: Added.
- kwq/TextField.h: Added.
- kwq/TextField.mm: Added.
- kwq/TextStream.cpp: Added.
- kwq/TextStream.h: Added.
- kwq/WebCoreEditCommand.h: Added.
- kwq/WebCoreEditCommand.mm: Added.
- kwq/WebCorePageState.h: Added.
- kwq/WebCorePageState.mm: Added.
- kwq/WebCoreResourceLoaderImp.h: Added.
- kwq/WebCoreResourceLoaderImp.mm: Added.
- kwq/WebCoreScrollBar.h: Added.
- kwq/WebCoreScrollBar.mm: Added.
- kwq/WebCoreSlider.h: Added.
- kwq/WebCoreSlider.mm: Added.
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedImage.cpp:
- loader/CachedObject.h:
- loader/CachedObjectClientWalker.h:
- loader/CachedResource.h:
- loader/CachedResourceClientWalker.h:
- loader/CachedScript.h:
- loader/CachedXBLDocument.h:
- loader/Decoder.h:
- loader/DocLoader.cpp:
- loader/DocLoader.h:
- loader/FormData.h:
- loader/ImageDocument.cpp:
- loader/PluginDocument.cpp:
- loader/TextDocument.cpp:
- loader/loader.cpp:
- loader/loader.h:
- page/Frame.cpp:
- page/Frame.h:
- page/FramePrivate.h:
- page/Page.cpp:
- page/Page.h:
- platform/DeprecatedPtrList.h:
- platform/DeprecatedPtrListImpl.cpp:
- platform/DeprecatedPtrListImpl.h:
- platform/DeprecatedString.cpp:
- platform/DeprecatedString.h:
- platform/DeprecatedStringList.cpp:
- platform/DeprecatedStringList.h:
- platform/DeprecatedValueList.h:
- platform/DeprecatedValueListImpl.cpp:
- platform/DeprecatedValueListImpl.h:
- platform/FloatSize.h:
- platform/Font.cpp:
- platform/KURL.cpp:
- platform/RegularExpression.cpp:
- platform/RegularExpression.h:
- platform/SegmentedString.h:
- platform/StreamingTextDecoder.cpp:
- platform/String.cpp:
- platform/StringImpl.cpp:
- platform/TextEncoding.cpp:
- platform/TransferJob.cpp:
- platform/TransferJob.h:
- platform/TransferJobInternal.h:
- platform/gdk/FrameGdk.cpp:
- platform/gdk/TemporaryLinkStubs.cpp:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/CursorMac.mm:
- platform/mac/DeprecatedStringMac.mm: Added.
- platform/mac/FontCacheMac.mm:
- platform/mac/FontMac.mm:
- platform/mac/FoundationExtras.h:
- platform/mac/ImageMac.mm:
- platform/mac/KURLMac.mm:
- platform/mac/MouseEventMac.mm: Removed.
- platform/mac/QStringListMac.mm: Removed.
- platform/mac/QStringMac.mm: Removed.
- platform/mac/TransferJobMac.mm:
- platform/mac/WebCoreTextArea.h:
- platform/mac/WebCoreTextArea.mm:
- platform/mac/WebCoreTextField.h:
- platform/mac/WebCoreTextField.mm:
- platform/mac/WidgetMac.mm:
- platform/win/TemporaryLinkStubs.cpp:
- rendering/DataRef.h:
- rendering/DeprecatedRenderSelect.cpp:
- rendering/DeprecatedRenderSelect.h:
- rendering/DeprecatedSlider.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderApplet.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderContainer.cpp:
- rendering/RenderFileButton.cpp:
- rendering/RenderFlexibleBox.cpp:
- rendering/RenderFlow.cpp:
- rendering/RenderFormElement.cpp:
- rendering/RenderFrameSet.cpp:
- rendering/RenderFrameSet.h:
- rendering/RenderImage.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderLineEdit.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderPartObject.cpp:
- rendering/RenderReplaced.cpp:
- rendering/RenderStyle.cpp: Added.
- rendering/RenderStyle.h: Added.
- rendering/RenderTable.cpp:
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTextArea.cpp:
- rendering/RenderTextControl.cpp: Added.
- rendering/RenderTextControl.h: Added.
- rendering/RenderTextField.cpp: Removed.
- rendering/RenderTextField.h: Removed.
- rendering/RenderTheme.cpp:
- rendering/RenderThemeMac.mm:
- rendering/RenderTreeAsText.cpp:
- rendering/RenderTreeAsText.h:
- rendering/RenderView.cpp:
- rendering/RenderWidget.cpp:
- rendering/bidi.cpp:
- rendering/render_style.cpp: Removed.
- rendering/render_style.h: Removed.
- xml/XSLStyleSheet.cpp:
- xml/XSLTProcessor.cpp:
- xml/xmlhttprequest.cpp:
- xpath/impl/XPathParser.cpp:
- 7:53 AM Changeset in webkit [15252] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Timothy Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations
- Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
- 5:05 AM Changeset in webkit [15251] by
-
- 2 edits in trunk/WebKitTools
Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9804
In the congratulations message, "capatibilies" should be "capabilities".
- 4:29 AM Changeset in webkit [15250] by
-
- 1 edit in trunk/WebCore/ChangeLog
Tweaked bug title in last comment to be correct.
- 4:09 AM Changeset in webkit [15249] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8251
navigator.product incorrect in WebKit.app on Intel Macs
For navigator.platform return "MacIntel" for Intel processors, "MacPPC"
otherwise.
- bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
- 3:46 AM Changeset in webkit [15248] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Timothy Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9794 Teach run-webkit-tests how to ignore tests with performance improvements
- Scripts/run-webkit-tests: Speed up test list generation, implement --ignore-tests feature, and minor clean up.
- 12:56 AM Changeset in webkit [15247] by
-
- 23 edits8 adds in trunk
LayoutTests:
Reviewed by Maciej.
Bug 5312: comments aren't available via DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
New tests for DOM comment nodes. Updated results to account for new
nodes in the DOM (editing offsets changed.)
- editing/deleting/delete-line-013-expected.txt:
- editing/deleting/delete-line-014-expected.txt:
- editing/inserting/insert-3907422-fix-expected.txt:
- editing/inserting/insert-div-009-expected.txt:
- editing/inserting/insert-div-010-expected.txt:
- editing/selection/extend-by-character-006-expected.txt:
- editing/selection/move-between-blocks-no-001-expected.txt:
- editing/selection/move-between-blocks-yes-001-expected.txt:
- fast/dom/HTMLDocument/object-by-name-or-id-expected.txt:
- fast/dom/HTMLDocument/object-by-name-or-id.html:
- fast/dom/comment-document-fragment-expected.txt: Added.
- fast/dom/comment-document-fragment.html: Added.
- fast/dom/comment-dom-node-expected.txt: Added.
- fast/dom/comment-dom-node.html: Added.
- fast/dom/comment-not-documentElement-expected.checksum: Added.
- fast/dom/comment-not-documentElement-expected.png: Added.
- fast/dom/comment-not-documentElement-expected.txt: Added.
- fast/dom/comment-not-documentElement.html: Added.
- fast/text/atsui-pointtooffset-calls-cg-expected.txt:
- fast/text/atsui-rtl-override-selection-expected.txt:
WebCore:
Reviewed by Maciej.
Bug 5312: comments aren't available via DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
<rdar://problem/4564414> getting comments via DOM isn't working (5312)
<rdar://problem/4545691> DOM_COMMENT node masking out real DOM elements
- dom/Document.cpp: (WebCore::Document::removedLastRef): set m_documentElement to 0 (WebCore::Document::childrenChanged): invalidate the document element we have cached in case it was replaced (WebCore::Document::documentElement): cache the first element as the document node if m_documentElement is 0
- dom/Document.h: added m_documentElement
- html/HTMLDocument.cpp: removed documentElement(), HTML documents just use Document's documentElement()
- html/HTMLDocument.h: ditto
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): make a new HTML node is the document's firstChild is NULL or the firstChild is not a HTML element (like a comment)
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): removed the #ifdef to include comment nodes
WebKit:
Reviewed by Maciej.
Bug 5312: comments aren't available via DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
Makes the Web Inspector show comment node contents.
- WebInspector/WebInspector.m: (-[DOMNode _displayName]): return the contents of the comment
- WebInspector/webInspector/inspector.js: check for comment nodes
- 12:04 AM Changeset in webkit [15246] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Add application/xhtml+xml to the Accept header
- WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header to main resource requests.
- English.lproj/StringsNotToBeLocalized.txt: Added new strings.
Jul 8, 2006:
- 10:44 PM Changeset in webkit [15245] by
-
- 2 edits in trunk/LayoutTests/editing/selection
Update the pixel result to match.
- 10:13 PM Changeset in webkit [15244] by
-
- 5 edits in tags/JavaScriptCore-521.15.1/JavaScriptCore
Build fix.
- 10:03 PM Changeset in webkit [15243] by
-
- 1 copy in tags/JavaScriptCore-521.15.1/JavaScriptCore
New tag (part 2.)
- 10:02 PM Changeset in webkit [15242] by
-
- 1 add in tags/JavaScriptCore-521.15.1
New tag.
- 9:58 PM Changeset in webkit [15241] by
-
- 4 edits2 deletes in trunk/JavaScriptCore
Reviewed by Maciej.
Moved KJS_GetCreatedJavaVMs to jni_utility.cpp.
Switched KJS_GetCreatedJavaVMs over to use dlopen and dlsym
now that NSAddImage, NSLookupSymbolInImage and NSAddressOfSymbol
are deprecated in Leopard.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/jni/jni_utility.cpp: (KJS::Bindings::KJS_GetCreatedJavaVMs):
- bindings/softlinking.c: Removed.
- bindings/softlinking.h: Removed.
- 9:28 PM Changeset in webkit [15240] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin, tweaked slightly and landed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9787
fast/frames tests failing (bad pointer to owner element) under MallocScribble
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::close): Disconnect the owner element of our frame.
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Don't call setFrame here.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::detach): Disconnect the owner element of our frame.
- html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::setFrameName): New function.
- page/Frame.cpp: (WebCore::Frame::Frame): Don't call setFrame.
(WebCore::Frame::~Frame):
Null out the owner element.
(WebCore::Frame::requestObject):
When an object creates a child frame, assign it a name so it can be
accessed from HTMLPlugInElement.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart):
- rendering/RenderPart.h: Get rid of setFrame.
- 1:04 PM Changeset in webkit [15239] by
-
- 7 edits in trunk/WebCore
Reviewed by Geoff.
- better fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 REGRESSION: showModalDialog returnValue ignored, function result is always "undefined"
- bindings/js/kjs_window.cpp: (KJS::showModalDialog): Set the return value after returning from the function if the window is not cleared; this is a better way to handle the case where the window does not get cleared before returning, and handles some new cases created by slight changes in the latest Safari properly too. (KJS::Window::clear): Changed logic slightly so we always store the result of getDirect into the return value slot -- the old code left the storage untouched if it was 0. Also made it only overwrite the return value slot if it's 0.
- bindings/js/kjs_proxy.h:
- bindings/js/kjs_proxy.cpp:
- bindings/js/kjs_window.h:
- bindings/js/kjs_window.cpp:
- page/Frame.cpp: Roll the previous fix out.
- 12:45 PM Changeset in webkit [15238] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Geoff (well, half of it at least).
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 storage leaks in Objective-C tests
- plugins/jsobjc-simple.html: Add an autorelease to fix a storage leak.
WebKitTools:
Reviewed by Geoff (well, half of it at least).
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 storage leaks in Objective-C tests
- DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController keepWebHistory]):
- DumpRenderTree/ObjCPlugin.m: (-[ObjCPlugin removeBridgeRestrictions:]): Add a release to fix a storage leak.
- 12:38 PM Changeset in webkit [15237] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: A few more.
- 12:11 PM Changeset in webkit [15236] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Another cut at renames. About ready to go (later today).
- 11:08 AM Changeset in webkit [15235] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Anders.
- Make JSObjectGetProperty return a JSValue or NULL, like JSEvaluate does.
- API/JSObjectRef.cpp: (JSObjectGetProperty):
- API/JSObjectRef.h:
- API/testapi.c: (main):
- 10:53 AM Changeset in webkit [15234] by
-
- 4 edits in trunk/JavaScriptCore
Style change -- no review necessary.
Use 0 instead of NULL in API .cpp files, to match our style guidelines.
- API/JSContextRef.cpp: (JSEvaluate):
- API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
- API/JSValueRef.cpp: (JSValueToObject):
- 10:42 AM Changeset in webkit [15233] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by TimO.
- Added ability to pass NULL for thisObject when calling JSObjectCallAsFunction, to match JSEvaluate.
- API/JSObjectRef.cpp: (JSObjectCallAsFunction):
- API/JSObjectRef.h:
- API/testapi.c: (main):
- 10:14 AM Changeset in webkit [15232] by
-
- 42 edits3 adds in trunk/LayoutTests
- clear up a few minor housekeeping problems
- fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Added.
- fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Added.
- fast/forms/input-appearance-height-expected.checksum: Added. Added missing test results.
- fast/block/float/nopaint-after-layer-destruction-expected.checksum:
- fast/block/positioning/absolute-positioned-overconstrained.html:
- fast/css/ZeroOpacityLayers.html:
- fast/css/ZeroOpacityLayers2.html:
- fast/css/font-shorthand-weight-only-expected.checksum:
- fast/css/hsl-color-expected.checksum:
- fast/css/hsla-color-expected.checksum:
- fast/css/resize-corner-tracking-expected.checksum:
- fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum:
- fast/dynamic/selection-highlight-adjust-expected.checksum:
- fast/forms/button-generated-content-expected.checksum:
- fast/frames/calculate-fixed.html:
- fast/frames/calculate-order.html:
- fast/frames/calculate-percentage.html:
- fast/frames/calculate-relative.html:
- fast/frames/calculate-round.html:
- fast/history/clicked-link-is-visited-expected.checksum:
- fast/layers/opacity-outline-expected.checksum:
- fast/media/import-p-red.css:
- fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
- fast/repaint/clipped-relative-expected.checksum:
- fast/repaint/float-move-during-layout-expected.checksum:
- fast/repaint/layer-child-outline-expected.checksum:
- fast/repaint/outline-shrinking-expected.checksum:
- fast/repaint/static-to-positioned-expected.checksum:
- fast/repaint/table-collapsed-border-expected.checksum:
- fast/table/absolute-table-at-bottom-expected.checksum:
- fast/table/border-collapsing/border-collapsing-head-foot-expected.checksum:
- fast/table/empty-section-crash-expected.checksum:
- fast/table/rtl-cell-display-none-assert-expected.checksum:
- fast/table/text-field-baseline-expected.checksum:
- fast/text/capitalize-empty-generated-string-expected.checksum:
- svg/custom/gradient-stroke-width-expected.checksum:
- traversal/stay-within-root-expected.checksum: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
- fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
- fast/css/ZeroOpacityLayers-expected.checksum:
- fast/css/ZeroOpacityLayers-expected.png:
- fast/css/ZeroOpacityLayers-expected.txt:
- fast/css/ZeroOpacityLayers2-expected.checksum:
- fast/css/ZeroOpacityLayers2-expected.png:
- fast/css/ZeroOpacityLayers2-expected.txt: Updated tests results that changed due to the above.
- 9:54 AM Changeset in webkit [15231] by
-
- 2 edits in trunk/WebKit
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): Removed misleading old comment.
- 7:30 AM Changeset in webkit [15230] by
-
- 2 edits in trunk/WebCore
- try to fix Windows build
- WebCore.vcproj/WebCore/WebCore.vcproj: Add missing source files.
- 2:34 AM Changeset in webkit [15229] by
-
- 9 copies in tags/Safari-521.15
New tag.
- 2:30 AM Changeset in webkit [15228] by
-
- 8 edits in /
Versioning
Jul 7, 2006:
- 8:36 PM Changeset in webkit [15227] by
-
- 3 edits in trunk/JavaScriptGlue
- build fix
- JSUtils.cpp: (KJSValueToCFTypeInternal):
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
- 7:32 PM Changeset in webkit [15226] by
-
- 12 edits4 adds in trunk
LayoutTests:
Reviewed by levi
- editing/selection/editable-non-editable-crash-expected.checksum: Added.
- editing/selection/editable-non-editable-crash-expected.png: Added.
- editing/selection/editable-non-editable-crash-expected.txt: Added.
- editing/selection/editable-non-editable-crash.html: Added.
- editing/selection/skip-non-editable-1-expected.txt:
- editing/selection/skip-non-editable-1.html:
WebCore:
Reviewed by levi
Fix Mail ToDo crashers.
- dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both containers are non-null and an early return.
- editing/Selection.cpp: (WebCore::Selection::validate): Fix a dangling start/end. (WebCore::Selection::adjustForEditableContent): Added an early return if m_start or m_end are null. (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition. (WebCore::Selection::isContentRichlyEditable): Ditto.
- editing/Selection.h:
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Use the new highestEditableRoot. (WebCore::VisiblePosition::previous): Ditto.
- editing/htmlediting.cpp: (WebCore::highestEditableRoot): Takes in a position. (WebCore::isEditablePosition): Added. (WebCore::isRichlyEditablePosition): Added. (WebCore::rootEditableElement): Added. (WebCore::nextCandidate): Moved and split out from nextVisiblePosition. (WebCore::nextVisuallyDistinctCandidate): Ditto. (WebCore::previousCandidate): Moved and split out from previousVisiblePosition. (WebCore::previousVisuallyDistinctCandidate): Ditto. (WebCore::firstEditablePositionAfterPositionInRoot): Iterate over positions, using nextVisuallyDistinctCandidate, skipping atomic nodes that are non-editable. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
- editing/htmlediting.h:
- editing/visible_units.cpp: (WebCore::startOfWord): Added a FIXME.
- 7:25 PM Changeset in webkit [15225] by
-
- 14 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Standardized which functions take a JSContext as an argument. The rule is: if you might execute JavaScript, you take a JSContext, otherwise you don't.
The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
but not API changes, so I'm putting it off until later.
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init):
- API/JSCallbackObject.h:
- API/JSContextRef.cpp: (JSContextCreate):
- API/JSContextRef.h:
- API/JSObjectRef.cpp: (JSObjectMake): (JSPropertyEnumeratorGetNext):
- API/JSObjectRef.h:
- API/testapi.c: (MyObject_initialize): (main):
- JavaScriptCore.exp:
- kjs/array_object.cpp: (ArrayInstance::setLength): (ArrayInstance::pushUndefinedObjectsToEnd):
- kjs/nodes.cpp: (ForInNode::execute):
- kjs/reference.cpp: (KJS::Reference::getPropertyName): (KJS::Reference::getValue):
- kjs/reference.h:
- kjs/scope_chain.cpp: (KJS::ScopeChain::print):
- 7:02 PM Changeset in webkit [15224] by
-
- 21 edits in trunk/JavaScriptCore
Reviewed by Maciej.
More API action.
- Headerdoc finished
Semantic Changes:
- Added a JSContextRef argument to many functions, because you need a JSContextRef for doing virtually anything. I expect to add this argument to even more functions in a future patch.
- Removed the globalObjectPrototype argument to JSContextCreate because you can't create an object until you have a context, so it's impossible to pass a prototype object to JSContextCreate. That's OK because (1) there's no reason to give the global object a prototype and (2) if you really want to, you can just use a separate call to JSObjectSetPrototype.
- Removed the JSClassRef argument to JSClassCreate because it was unnecessary, and you need to be able to make the global object's class before you've created a JSContext.
- Added an optional exception parameter to JSFunctionMakeWithBody because anything less would be uncivilized.
- Made the return value parameter to JSObjectGetProperty optional to match all other return value parameters in the API.
- Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions and JSCallbackConstructors. You could use an abstract base class or strategic placement of m_privateData in the class structure to implement this, but the former seemed like overkill, and the latter seemed too dangerous.
- Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.
Cosmetic Changes:
- Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc
- Removed function names from @function declarations because headeroc can parse them automatically, and I wanted to rule out manual mismatch.
- Changed Error::create to take a const UString& instead of a UString* because it was looking at me funny.
- Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF because the latter is more concise and it matches JSStringBufferCreateUTF8.
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString):
- API/JSClassRef.cpp: (JSClassCreate):
- API/JSContextRef.cpp: (JSContextCreate): (JSContextSetException):
- API/JSContextRef.h:
- API/JSNode.c: (JSNodePrototype_class): (JSNode_class):
- API/JSNodeList.c: (JSNodeListPrototype_class): (JSNodeList_class):
- API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectCallAsFunction): (JSObjectCallAsConstructor): (JSPropertyEnumeratorGetNext):
- API/JSObjectRef.h:
- API/JSStringBufferRef.cpp: (JSStringBufferCreateCF):
- API/JSStringBufferRef.h:
- API/JSValueRef.cpp: (JSValueIsInstanceOf):
- API/JSValueRef.h:
- API/minidom.c: (main):
- API/minidom.js:
- API/testapi.c: (MyObject_hasProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_convertToType): (MyObject_class): (main):
- JavaScriptCore.exp:
- 6:45 PM Changeset in webkit [15223] by
-
- 4 edits in trunk/LayoutTests
Reviewed by NOBODY
Missed a few in the last update...
- fast/forms/input-delete-expected.txt:
- fast/repaint/inline-outline-repaint-expected.txt:
- fast/repaint/selection-after-delete-expected.txt:
- 5:46 PM Changeset in webkit [15222] by
-
- 156 edits in trunk
LayoutTests:
Reviewed by justin
Deletion editing deligates now show up!
- editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- editing/deleting/delete-3608430-fix-expected.txt:
- editing/deleting/delete-3608445-fix-expected.txt:
- editing/deleting/delete-3608462-fix-expected.txt:
- editing/deleting/delete-3775172-fix-expected.txt:
- editing/deleting/delete-3800834-fix-expected.txt:
- editing/deleting/delete-3857753-fix-expected.txt:
- editing/deleting/delete-3865854-fix-expected.txt:
- editing/deleting/delete-3928305-fix-expected.txt:
- editing/deleting/delete-3959464-fix-expected.txt:
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/deleting/delete-4083333-fix-expected.txt:
- editing/deleting/delete-after-span-ws-001-expected.txt:
- editing/deleting/delete-after-span-ws-002-expected.txt:
- editing/deleting/delete-after-span-ws-003-expected.txt:
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-and-undo-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- editing/deleting/delete-block-contents-001-expected.txt:
- editing/deleting/delete-block-contents-002-expected.txt:
- editing/deleting/delete-block-contents-003-expected.txt:
- editing/deleting/delete-block-merge-contents-001-expected.txt:
- editing/deleting/delete-block-merge-contents-002-expected.txt:
- editing/deleting/delete-block-merge-contents-003-expected.txt:
- editing/deleting/delete-block-merge-contents-004-expected.txt:
- editing/deleting/delete-block-merge-contents-005-expected.txt:
- editing/deleting/delete-block-merge-contents-006-expected.txt:
- editing/deleting/delete-block-merge-contents-007-expected.txt:
- editing/deleting/delete-block-merge-contents-008-expected.txt:
- editing/deleting/delete-block-merge-contents-009-expected.txt:
- editing/deleting/delete-block-merge-contents-010-expected.txt:
- editing/deleting/delete-block-merge-contents-012-expected.txt:
- editing/deleting/delete-block-merge-contents-013-expected.txt:
- editing/deleting/delete-block-merge-contents-014-expected.txt:
- editing/deleting/delete-block-merge-contents-015-expected.txt:
- editing/deleting/delete-block-merge-contents-016-expected.txt:
- editing/deleting/delete-block-merge-contents-017-expected.txt:
- editing/deleting/delete-block-merge-contents-018-expected.txt:
- editing/deleting/delete-block-merge-contents-019-expected.txt:
- editing/deleting/delete-block-merge-contents-020-expected.txt:
- editing/deleting/delete-block-merge-contents-021-expected.txt:
- editing/deleting/delete-block-merge-contents-022-expected.txt:
- editing/deleting/delete-block-merge-contents-023-expected.txt:
- editing/deleting/delete-block-merge-contents-024-expected.txt:
- editing/deleting/delete-br-001-expected.txt:
- editing/deleting/delete-br-002-expected.txt:
- editing/deleting/delete-br-003-expected.txt:
- editing/deleting/delete-br-004-expected.txt:
- editing/deleting/delete-br-005-expected.txt:
- editing/deleting/delete-br-006-expected.txt:
- editing/deleting/delete-br-007-expected.txt:
- editing/deleting/delete-br-008-expected.txt:
- editing/deleting/delete-br-009-expected.txt:
- editing/deleting/delete-br-010-expected.txt:
- editing/deleting/delete-br-011-expected.txt:
- editing/deleting/delete-character-001-expected.txt:
- editing/deleting/delete-contiguous-ws-001-expected.txt:
- editing/deleting/delete-image-001-expected.txt:
- editing/deleting/delete-image-002-expected.txt:
- editing/deleting/delete-image-003-expected.txt:
- editing/deleting/delete-image-004-expected.txt:
- editing/deleting/delete-leading-ws-001-expected.txt:
- editing/deleting/delete-line-001-expected.txt:
- editing/deleting/delete-line-002-expected.txt:
- editing/deleting/delete-line-003-expected.txt:
- editing/deleting/delete-line-004-expected.txt:
- editing/deleting/delete-line-005-expected.txt:
- editing/deleting/delete-line-006-expected.txt:
- editing/deleting/delete-line-007-expected.txt:
- editing/deleting/delete-line-008-expected.txt:
- editing/deleting/delete-line-009-expected.txt:
- editing/deleting/delete-line-010-expected.txt:
- editing/deleting/delete-line-011-expected.txt:
- editing/deleting/delete-line-012-expected.txt:
- editing/deleting/delete-line-013-expected.txt:
- editing/deleting/delete-line-014-expected.txt:
- editing/deleting/delete-line-015-expected.txt:
- editing/deleting/delete-line-016-expected.txt:
- editing/deleting/delete-line-017-expected.txt:
- editing/deleting/delete-line-end-ws-001-expected.txt:
- editing/deleting/delete-line-end-ws-002-expected.txt:
- editing/deleting/delete-listitem-001-expected.txt:
- editing/deleting/delete-listitem-002-expected.txt:
- editing/deleting/delete-select-all-001-expected.txt:
- editing/deleting/delete-select-all-002-expected.txt:
- editing/deleting/delete-select-all-003-expected.txt:
- editing/deleting/delete-selection-001-expected.txt:
- editing/deleting/delete-tab-001-expected.txt:
- editing/deleting/delete-tab-002-expected.txt:
- editing/deleting/delete-tab-003-expected.txt:
- editing/deleting/delete-tab-004-expected.txt:
- editing/deleting/delete-trailing-ws-001-expected.txt:
- editing/deleting/delete-trailing-ws-002-expected.txt:
- editing/deleting/delete-ws-fixup-001-expected.txt:
- editing/deleting/delete-ws-fixup-002-expected.txt:
- editing/deleting/delete-ws-fixup-003-expected.txt:
- editing/deleting/delete-ws-fixup-004-expected.txt:
- editing/deleting/forward-delete-expected.txt:
- editing/deleting/merge-different-styles-expected.txt:
- editing/deleting/merge-endOfParagraph-expected.txt:
- editing/deleting/merge-into-empty-block-1-expected.txt:
- editing/deleting/merge-into-empty-block-2-expected.txt:
- editing/deleting/merge-no-br-expected.txt:
- editing/deleting/merge-unrendered-space-expected.txt:
- editing/deleting/pruning-after-merge-1-expected.txt:
- editing/deleting/pruning-after-merge-2-expected.txt:
- editing/deleting/smart-delete-001-expected.txt:
- editing/deleting/smart-delete-002-expected.txt:
- editing/deleting/table-cells-expected.txt:
- editing/execCommand/insertHTML-expected.txt:
- editing/input/text-input-controller-expected.txt:
- editing/inserting/insert-3775316-fix-expected.txt:
- editing/inserting/insert-3851164-fix-expected.txt:
- editing/inserting/insert-after-delete-001-expected.txt:
- editing/inserting/insert-div-021-expected.txt:
- editing/inserting/insert-div-026-expected.txt:
- editing/pasteboard/4076267-2-expected.txt:
- editing/pasteboard/4076267-3-expected.txt:
- editing/pasteboard/4076267-expected.txt:
- editing/pasteboard/paste-table-002-expected.txt:
- editing/pasteboard/paste-text-015-expected.txt:
- editing/selection/move-between-blocks-no-001-expected.txt:
- editing/selection/select-all-iframe-expected.txt:
- editing/style/block-style-005-expected.txt:
- editing/style/smoosh-styles-001-expected.txt:
- editing/style/smoosh-styles-002-expected.txt:
- editing/style/style-3681552-fix-002-expected.txt:
- editing/style/typing-style-001-expected.txt:
- editing/style/typing-style-002-expected.txt:
- editing/unsupported-content/list-delete-001-expected.txt:
- editing/unsupported-content/list-delete-002-expected.txt:
- editing/unsupported-content/list-delete-003-expected.txt:
- editing/unsupported-content/table-delete-001-expected.txt:
- editing/unsupported-content/table-delete-002-expected.txt:
- editing/unsupported-content/table-delete-003-expected.txt:
- fast/forms/input-text-option-delete-expected.checksum:
- fast/forms/input-text-option-delete-expected.txt:
WebCore:
Reviewed by justin
Allowed deletion typing commands to take in a granularity
- bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
- bridge/mac/WebCoreFrameBridge.mm: Ditto (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
- editing/TypingCommand.cpp: Constructors take in a granularity (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
- editing/TypingCommand.h: ditto
- page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual
WebKit:
Reviewed by justin
Finished moving deletion selection expansion across the bridge... say that 3 times fast.
- WebView/WebHTMLView.m: Pass granularity to WebCore to handle expansion (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]): (-[NSArray deleteToMark:]):
- 5:27 PM Changeset in webkit [15221] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders and Tim Hatcher
Added an accessor to a SQLite config option to change its disk-syncing behavior.
Used this accessor to significantly speed up writes to the Icon DB.
- icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Disable full syncing to the SQLite db to speed up writes to the icondb
- icon/SQLDatabase.cpp: (SQLDatabase::setFullsync): (SQLDatabase::setSynchronous):
- icon/SQLDatabase.h: (WebCore::SQLDatabase::): Added accessor to the SQLite config pragma "synchronous"
- 5:21 PM Changeset in webkit [15220] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed a storage leak noticed by the buildbot
- dom/Document.cpp: (WebCore::Document::removedLastRef): Call delete on the markers before clearing the map containing them.
- 4:46 PM Changeset in webkit [15219] by
-
- 5 edits in trunk/WebCore
2006-07-08 Anders Carlsson <acarlsson@apple.com>
Reviewed by Brady.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9777
Reproducible crash in Loading/Frames in ToT.
The problem was that the renderpart destructor resets the frame's
owner element. For iframes, this should only be done when the element is
going to be removed from the document.
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::~HTMLIFrameElement): (WebCore::HTMLIFrameElement::willRemove): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::detach):
- html/HTMLIFrameElement.h: Remove the frame in willRemove instead.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart):
- rendering/RenderPart.h: Don't call setFrame(0) in the destructor when the element is an iframe element.
- 4:01 PM Changeset in webkit [15218] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- fixed a storage leak noticed by the buildbot
- page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate): Delete m_scheduledEvents.
- 3:39 PM Changeset in webkit [15217] by
-
- 1 edit in trunk/WebKit/ChangeLog
Added a bug number to an existing entry.
- 3:33 PM Changeset in webkit [15216] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
- fixed a couple of storage leaks noticed by the buildbot
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Call deref on the style after calling setRenderStyle, since styleForRenderer returns us a "ref'd" RenderStyle object.
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
- 3:18 PM Changeset in webkit [15215] by
-
- 6 edits in trunk/WebCore
Reviewed by Adele.
- fix some license mistakes
- LICENSE-APPLE: Added more years of publication to the copyright here.
- html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
- html/CanvasPattern.idl: Ditto.
- html/CanvasRenderingContext2D.idl: Ditto.
- html/HTMLCanvasElement.idl: Ditto.
- 2:13 PM Changeset in webkit [15214] by
-
- 2 edits in trunk/WebKit
Reviewed by John
Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
whose assertion was reproducibly causing a build bot failure
- Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):
- 1:41 PM Changeset in webkit [15213] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- Fixed a few crashes resulting from NULL parameters to JSClassCreate.
- API/JSClassRef.cpp: (JSClassCreate): (JSClassRelease):
- API/testapi.c: Added test for NULL parameters. (main):
- 1:39 PM Changeset in webkit [15212] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John, mocked by Darin.
- Changed JSEvaluate to take a JSObjectRef instead of a JSValueRef as "this," since "this" must be an object.
- API/JSContextRef.cpp: (JSEvaluate):
- API/JSContextRef.h:
- 1:38 PM Changeset in webkit [15211] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- More headerdoc
- API/JSBase.h:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:57 PM Changeset in webkit [15210] by
-
- 1 copy in tags/WebCore-315.14.4/WebCore
New tag (part 2).
- 12:56 PM Changeset in webkit [15209] by
-
- 1 add in tags/WebCore-315.14.4
New tag.
- 12:55 PM Changeset in webkit [15208] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning
- 12:54 PM Changeset in webkit [15207] by
-
- 4 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( http://www.yahoo.com/ )
2005-10-16 David Hyatt <hyatt@apple.com>
Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.
Reviewed by bdakin
- khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
- khtml/rendering/render_container.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy
- 12:33 PM Changeset in webkit [15206] by
-
- 12 edits4 adds in trunk
LayoutTests:
Reviewed by justin
Improved table editing
- editing/deleting/delete-to-select-table-expected.checksum: Added.
- editing/deleting/delete-to-select-table-expected.png: Added.
- editing/deleting/delete-to-select-table-expected.txt: Added.
- editing/deleting/delete-to-select-table.html: Added.
- editing/input/text-input-controller-expected.txt:
WebCore:
Reviewed by justin
Improved table editing: pressing delete directly before or after a table will now select
the table first, then delete it, instead of just deleting it. Useful for when the table's
existence is non-obvious.
- bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger deletion editing deligates
- bridge/mac/FrameMac.mm: ditto (WebCore::FrameMac::shouldDeleteSelection):
- bridge/mac/WebCoreFrameBridge.h: ditto
- editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and subsequent selection (as opposed to removal) (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
- page/Frame.cpp: shouldDeleteSelection added (WebCore::Frame::shouldDeleteSelection):
- page/Frame.h: ditto
WebKit:
Reviewed by justin
Improved table editing
- WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger deletion editing delegate (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
- WebView/WebHTMLView.m: Moved code that expanded a selection when the delete key is pressed over to WebCore so we can be more intelligent about how to handle it (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
- 12:29 PM Changeset in webkit [15205] by
-
- 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog
Versioning
- 12:21 PM Changeset in webkit [15204] by
-
- 2 copies in tags/WebCore-418.20/WebCore
New tag (part 2).
- 12:20 PM Changeset in webkit [15203] by
-
- 1 add in tags/WebCore-418.20
New tag.
- 12:19 PM Changeset in webkit [15202] by
-
- 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist
Versioning
- 11:24 AM Changeset in webkit [15201] by
-
- 4 edits2 copies in trunk/WebCore
Reviewed by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9768 Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file).
- WebCore.xcodeproj/project.pbxproj:
- xml/XSLImportRule.cpp: Added. (WebCore::XSLImportRule::XSLImportRule): (WebCore::XSLImportRule::parentStyleSheet): (WebCore::XSLImportRule::loadSheet):
- xml/XSLImportRule.h: Added.
- xml/XSLStyleSheet.cpp:
- xml/XSLStyleSheet.h:
- 10:22 AM Changeset in webkit [15200] by
-
- 3 edits2 adds in trunk
WebCore:
2006-07-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
- css/html4.css: Set "-webkit-user-select: ignore" on radio buttons and check boxes .
LayoutTests:
2006-07-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
- fast/forms/radio-check-click-and-drag-expected.txt: Added.
- fast/forms/radio-check-click-and-drag.html: Added.
- 10:09 AM Changeset in webkit [15199] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher
- WebKit.exp: added surprisingly missing _WebPreferencesChangedNotification, defined in WebPreferences.h
- 1:36 AM Changeset in webkit [15198] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
- fix 20 Node leaks on fast/events tests - these should be the last ones
- bindings/objc/DOMEvents.mm: (-[DOMEvent dealloc]): implement - deref the event! (-[DOMEvent finalize]): ditto
Jul 6, 2006:
- 9:48 PM Changeset in webkit [15197] by
-
- 3 edits in trunk/WebCore
Reviewed by Tim Hatcher.
- fix 26 Node leaks on fast/dom tests
- dom/Document.cpp: (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't want nodes held by the parser to keep the document alive.
- html/HTMLParser.cpp: (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node, but avoids refing document nodes to avoid cycles. (WebCore::RefNonDocNodePtr::~RefNonDocNodePtr): (WebCore::RefNonDocNodePtr::get): (WebCore::RefNonDocNodePtr::operator*): (WebCore::RefNonDocNodePtr::operator->): (WebCore::RefNonDocNodePtr::operator!): (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType): (WebCore::RefNonDocNodePtr::operator=): (WebCore::operator==): (WebCore::operator!=): (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node> (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing
- 7:29 PM Changeset in webkit [15196] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej.
Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9762 [Native pop up] Highlighted item text is black instead of white
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Added. (WebCore::HTMLSelectElement::isMouseFocusable): Added. (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
- rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
- rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send fake mouseUp and keyUp events when the NSMenu returns. (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black. Follow-up bug about other colors: http://bugzilla.opendarwin.org/show_bug.cgi?id=9769 (WebCore::RenderPopupMenuMac::addOption): ditto.
- bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.
- 7:13 PM Changeset in webkit [15195] by
-
- 7 edits8 adds in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints
- editing/selection/mixed-editability-1-expected.checksum: Added.
- editing/selection/mixed-editability-1-expected.png: Added.
- editing/selection/mixed-editability-1-expected.txt: Added.
- editing/selection/mixed-editability-1.html: Added.
- editing/selection/mixed-editability-2-expected.checksum: Added.
- editing/selection/mixed-editability-2-expected.png: Added.
- editing/selection/mixed-editability-2-expected.txt: Added.
- editing/selection/mixed-editability-2.html: Added.
WebCore:
Reviewed by levi
<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints
- editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Moved code into a helper function. (WebCore::VisiblePosition::previous): Ditto.
- editing/htmlediting.cpp: (WebCore::comparePositions): Moved from Selection.cpp. (WebCore::lowestEditableAncestor): Added. Returns rootEditableElement for a node in editable content and the rootEditableElement for the first ancestor that's editable for a node in non-editable content. (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot):
- editing/htmlediting.h:
- 6:00 PM Changeset in webkit [15194] by
-
- 6 edits2 adds in trunk
WebCore:
2006-07-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes
Patch by Darin, tweaked by Anders.
- html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Convert newline characters to <br> elements. I've verified that what's done here is what WinIE does when setting innerText.
(WebCore::HTMLElement::setOuterText):
Fix comment.
- rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Remove assert. m_div->firstChild() can be null now because setInnerText doesn't create text nodes for empty strings anymore.
LayoutTests:
2006-07-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adele.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes
- fast/dom/css-selectorText-expected.txt:
- fast/dom/css-shortHands-expected.txt: Update tests.
- fast/dom/set-inner-text-newlines-expected.txt: Added.
- fast/dom/set-inner-text-newlines.html: Added.
- 5:22 PM Changeset in webkit [15193] by
-
- 3 edits in trunk/WebCore
Reviewed by Tim Hatcher.
- Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)
- page/FrameView.cpp: (WebCore::FrameView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
- page/FrameView.h: (WebCore::FrameView::hasOneRef): Added.
- 5:12 PM Changeset in webkit [15192] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Reviewed by Tim Hatcher.
- Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)
- khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
- khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.
- 4:11 PM Changeset in webkit [15191] by
-
- 14 edits5 adds in trunk
WebCore:
2006-07-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/4610891> Support overflow events
- DerivedSources.make: Add generated sources.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/js/kjs_events.cpp: (KJS::toJS): Support creating wrappers for overflow events..
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): (-[DOMOverflowEvent _overflowEvent]): (-[DOMOverflowEvent orient]): (-[DOMOverflowEvent horizontalOverflow]): (-[DOMOverflowEvent verticalOverflow]): Add Objective-C wrapper for overflow events.
- dom/Event.cpp: (WebCore::Event::isOverflowEvent):
- dom/Event.h:
- dom/EventNames.h:
- dom/OverflowEvent.cpp: Added. (WebCore::OverflowEvent::OverflowEvent): (WebCore::OverflowEvent::isOverflowEvent):
- dom/OverflowEvent.h: Added. (WebCore::OverflowEvent::): (WebCore::OverflowEvent::orient): (WebCore::OverflowEvent::horizontalOverflow): (WebCore::OverflowEvent::verticalOverflow):
- dom/OverflowEvent.idl: Added. Add overflow events.
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): Dispatch any scheduled events when layout is done.
(WebCore::FrameView::scheduleEvent):
New function which schedules an event.
(WebCore::FrameView::updateOverflowStatus):
Update overflow status for the viewport.
(WebCore::FrameView::dispatchScheduledEvents):
New function which dispatches all scheduled events.
- page/FrameView.h: Add declarations.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h: Schedule overflow events when overflow status changes.
LayoutTests:
2006-07-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/4610891> Support overflow events
- fast/events/overflow-events-expected.txt: Added.
- fast/events/overflow-events.html: Added.
- 3:47 PM Changeset in webkit [15190] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff.
<rdar://problem/4610881> Expose scroll-related JS properties to ObjC DOM interface
<rdar://problem/4519675> offsetLeft, offsetTop, offsetHeight, and offsetWidth
properties are not exposed to ObjC
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMHTML.mm: (-[DOMHTMLElement offsetLeft]): (-[DOMHTMLElement offsetTop]): (-[DOMHTMLElement offsetWidth]): (-[DOMHTMLElement offsetHeight]): (-[DOMHTMLElement offsetParent]): (-[DOMHTMLElement clientWidth]): (-[DOMHTMLElement clientHeight]): (-[DOMHTMLElement scrollLeft]): (-[DOMHTMLElement setScrollLeft:]): (-[DOMHTMLElement scrollTop]): (-[DOMHTMLElement setScrollTop:]): (-[DOMHTMLElement scrollWidth]): (-[DOMHTMLElement scrollHeight]):
- 3:45 PM Changeset in webkit [15189] by
-
- 3 edits in S60/trunk
S60WebKit:
2006-07-06 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson. Fix for:
- S60Tools/patch.exe: Updated to version 2.5.
- S60Tools/prepare-ChangeLog.bat: Force forwardslashes.
- 3:30 PM Changeset in webkit [15188] by
-
- 1 edit5 adds in S60/trunk
S60WebKit:
2006-07-06 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
- S60Tools\patch.exe: Added.
- S60Tools\prepare-ChangeLog.bat: Added.
- S60Tools\svn-apply.bat: Added.
- S60Tools\svn-create-patch.bat: Added.
- S60Tools\svn-unapply.bat: Added.
- 2:41 PM Changeset in webkit [15187] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- fix 435 more layout tests Node leaks
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): fix more instances of leaked DOM ranges
- 11:39 AM Changeset in webkit [15186] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
is closing
- Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):
- 9:45 AM Changeset in webkit [15185] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Geoff.
<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '>' instead of '>'
- fast/innerHTML/006-expected.checksum: Added.
- fast/innerHTML/006-expected.png: Added.
- fast/innerHTML/006-expected.txt: Added.
- fast/innerHTML/006.html: Added.
WebCore:
Reviewed by Geoff
<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '>' instead of '>'
Test: fast/innerHTML/006.html
- editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup): Do not special quote content of XMP nodes.
- 4:37 AM Changeset in webkit [15184] by
-
- 3 edits in trunk/WebCore
Not reviewed - build fix.
- back out earlier leak fix, as it caused a crash on one of the fast/invalid layout tests
- dom/Document.cpp: (WebCore::Document::removedLastRef):
- html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlock):
- 2:50 AM Changeset in webkit [15183] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- fix ~3000 Node leaks on the editing tests
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): put a newly created Range in a RefPtr to avoid leaking it, as this leaks the whole document.
- 2:39 AM Changeset in webkit [15182] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders.
- fix 26 Node leaks on various fast/dom tests
- dom/Document.cpp: (WebCore::Document::removedLastRef): Delete the tokenizer here, since if we are in mid-parse, the parser might hold refs on some of our children that have self-only refs.
- html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): don't ref the node if it is a document to avoid ref cycles (WebCore::HTMLStackElem::~HTMLStackElem): ditto (WebCore::HTMLStackElem::node): changed interface a bit to support the above (WebCore::HTMLStackElem::setNode): ditto (WebCore::HTMLParser::popNestedHeaderTag): use new interface to HTMLStackElem (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): ditto (WebCore::HTMLParser::reopenResidualStyleTags): ditto (WebCore::HTMLParser::popBlock): ditto (WebCore::HTMLParser::popOneBlock): ditto
Jul 5, 2006:
- 11:39 PM Changeset in webkit [15181] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- rendering/RenderMenuList.h: (WebCore::RenderMenuList::createsAnonymousWrapper): This method replaces allowsReusingAnonymousChild() and has the opposite meaning.
- 11:35 PM Changeset in webkit [15180] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej
Small fix that prevents an assertion from triggering if the DB is being cleaned up
(ie, the app being shut down)
- Misc/WebIconDatabase.h:
- Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
- 11:19 PM Changeset in webkit [15179] by
-
- 6 edits in trunk/WebCore
Build fixes.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- platform/win/TemporaryLinkStubs.cpp:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcMinMaxWidth):
- rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
- rendering/RenderThemeWin.cpp:
- 10:55 PM Changeset in webkit [15178] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- fix 308 Node leaks on the editing layout tests
- dom/Document.cpp: (WebCore::Document::removedLastRef): Clear the markers once there are no real refs on the document, otherwise a self-only reference cycle w/ the document can occur.
- 10:47 PM Changeset in webkit [15177] by
-
- 28 edits7 adds in trunk
WebCore:
Reviewed by Maciej and Hyatt.
Initial implementation of popup menu control. This can be turned on by setting -webkit-appearance: menulist on a select element.
- WebCore.xcodeproj/project.pbxproj: Added RenderMenuList.h, RenderMenuList.cpp, RenderPopupMenu.h, RenderPopupMenu.cpp, RenderPopupMenuWin.h, RenderPopupMenuMac.h, RenderPopupMenuMac.mm,
- dom/Node.cpp: (WebCore::Node::renderStyle): Added. Returns the renderer's style. If there's no renderer, returns's a RenderStyle that's kept by the node. This is important for HTMLOptGroupElement and HTMLOptionElement, which don't have renderers. (WebCore::Node::setRenderStyle): Added.
- dom/Node.h:
- dom/Element.cpp: (WebCore::Element::recalcStyle): Updated to use renderStyle so recalcStyle will work for HTMLOptionElements and HTMLOptGroupElements.
- css/cssstyleselector.cpp: Updated to call renderStyle method on the node, so resolving style works on elements w/o renderers that cache style. (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::checkOneSelector):
- css/html4.css: Removed display:none from options and optgroups, since we're now caching style for these elements. Added font-weight styles for option and optgroup.
- html/HTMLOptGroupElement.h: Added m_style to keep track of a RenderStyle for the element, even though we aren't creating a renderer. This will allow us to honor style for optgroups and options for popup menus (and eventually list boxes too). (WebCore::HTMLOptGroupElement::rendererIsNeeded): Added. (WebCore::HTMLOptGroupElement::renderStyle): Added.
- html/HTMLOptionElement.h: ditto. (WebCore::HTMLOptionElement::rendererIsNeeded): Added. (WebCore::HTMLOptionElement::renderStyle): Added.
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Initialize m_style. (WebCore::HTMLOptGroupElement::attach): Set the renderStyle. (WebCore::HTMLOptGroupElement::detach): Clear m_style. (WebCore::HTMLOptGroupElement::setRenderStyle): Added. (WebCore::HTMLOptGroupElement::groupLabelText): Added.
- html/HTMLOptionElement.cpp: ditto. (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::setRenderStyle): (WebCore::HTMLOptionElement::optionText):
- html/HTMLSelectElement.cpp: Added code to use the new RenderMenuList if the appearance is set to MenuListAppearance, and if we're not creating a list box renderer. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
- html/HTMLSelectElement.h:
- WebCore.exp: Added _wkPopupMenu.
- platform/mac/WebCoreSystemInterface.h: Added wkPopupMenu to get the NSMenu to pop up.
- platform/mac/WebCoreSystemInterface.mm:
- platform/win/TemporaryLinkStubs.cpp: Added stubs for RenderPopupMenuWin. (RenderPopupMenuWin::RenderPopupMenuWin): (RenderPopupMenuWin::~RenderPopupMenuWin): (RenderPopupMenuWin::clear): (RenderPopupMenuWin::populate): (RenderPopupMenuWin::showPopup): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (RenderPopupMenuWin::addOption):
- rendering/RenderPopupMenuWin.h: Added.
- rendering/RenderPopupMenu.cpp: Added. (WebCore::RenderPopupMenu::RenderPopupMenu): (WebCore::RenderPopupMenu::~RenderPopupMenu): (WebCore::RenderPopupMenu::clear): (WebCore::RenderPopupMenu::populate): Walks the DOM tree, and adds separators, options, and group labels to the RenderPopupMenu. (WebCore::RenderPopupMenu::showPopup): (WebCore::RenderPopupMenu::addSeparator): (WebCore::RenderPopupMenu::addGroupLabel): (WebCore::RenderPopupMenu::addOption):
- rendering/RenderPopupMenu.h: Added. (WebCore::RenderPopupMenu::renderName): (WebCore::RenderPopupMenu::getRenderMenuList):
- rendering/RenderPopupMenuMac.h: Added.
- rendering/RenderPopupMenuMac.mm: Added. (WebCore::RenderPopupMenuMac::RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::~RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::clear): Removes all items from the menu. (WebCore::RenderPopupMenuMac::populate): Disables menuChangedMessages before populating the menu. (WebCore::RenderPopupMenuMac::showPopup): Calculates the right position, and calls wkPopupMenu. (WebCore::RenderPopupMenuMac::addSeparator): (WebCore::RenderPopupMenuMac::addGroupLabel): (WebCore::RenderPopupMenuMac::addOption):
- rendering/RenderMenuList.cpp: Added. (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::addChild): (WebCore::RenderMenuList::removeChild): (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::updateFromElement): If the options have changed, iterate through the children to find the menu item with the widest text. Set the button text to the selected item's text. (WebCore::RenderMenuList::setText): (WebCore::RenderMenuList::paintObject): (WebCore::RenderMenuList::baselinePosition): (WebCore::RenderMenuList::calcMinMaxWidth): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::layout): (WebCore::RenderMenuList::updateSelection): (WebCore::RenderMenuList::valueChanged):
- rendering/RenderMenuList.h: Added. (WebCore::RenderMenuList::removeLeftoverAnonymousBoxes): (WebCore::RenderMenuList::allowsReusingAnonymousChild): (WebCore::RenderMenuList::canHaveChildren): (WebCore::RenderMenuList::renderName): (WebCore::RenderMenuList::setOptionsChanged): (WebCore::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::setSelectionChanged): (WebCore::RenderMenuList::hasPopupMenu):
- rendering/RenderTheme.cpp: Added cases for MenuListAppearance. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::adjustMenuListStyle): (WebCore::RenderTheme::createPopupMenu): creates platform-specific RenderPopupMenu.
- rendering/RenderTheme.h: (WebCore::RenderTheme::sizeOfArrowControl): Added. (WebCore::RenderTheme::paintMenuList): Added.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::createPopupMenu): (WebCore::RenderThemeMac::sizeOfArrowControl):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
- rendering/RenderThemeWin.h:
WebKit:
Reviewed by Maciej and Hyatt.
WebKit part of initial popup menu implementation.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKPopupMenu.
WebKitLibraries:
Reviewed by Maciej and Hyatt.
- WebKitSystemInterface.h: Updated.
- libWebKitSystemInterface.a: Updated.
- 7:57 PM Changeset in webkit [15176] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( http://www.yahoo.com/ )
2005-10-16 David Hyatt <hyatt@apple.com>
Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.
Reviewed by bdakin
- khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
- khtml/rendering/render_container.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy
- 4:45 PM Changeset in webkit [15175] by
-
- 5 edits in trunk/WebCore
Reviewed by Tim Omernick.
IconDatabase now respects private browsing via the use of in memory, temporary tables
- bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): Renamed WebCore::IconDatabase methods, changes reflected here
- icon/IconDatabase.cpp: (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::performSetIconDataForIconID): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::performSetIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL): -Some style/comment cleanups, but mainly putting private browsing handling in place
- icon/IconDatabase.h: Some methods added, others renamed, some comments added
- icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): -The above 4 had changes to return String() for empty results instead of "" as it's less expensive;
- 4:30 PM Changeset in webkit [15174] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Adele.
- layout test for <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view
The test verifies that focusing a link will scroll the link into view.
- fast/events/reveal-link-when-focused-expected.checksum: Added.
- fast/events/reveal-link-when-focused-expected.png: Added.
- fast/events/reveal-link-when-focused-expected.txt: Added.
- fast/events/reveal-link-when-focused.html: Added.
- 4:27 PM Changeset in webkit [15173] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin and Adele.
- fixed <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view
- html/HTMLAnchorElement.cpp:
- html/HTMLAnchorElement.h: removed HTMLAnchorElement::focus and HTMLAnchorElement::blur.
HTMLAnchorElement::focus just called document()->setFocusNode(). The scroll-to-reveal
code used to be inside document()->setFocusNode(), but now it's in Element::focus, and this override
was preventing that code from running.
HTMLAnchorElement::blur was exactly the same implementation as Element::blur (and there aren't any
other implementations of ::blur in the class hierarchy in between). This change has no practical
effect, other than removing duplicate code.
Adele and I think that it was an oversight not to remove these two methods on 12/20/05
these methods were removed from HTMLButtonElementImpl and HTMLInputElementImpl.
- 3:24 PM Changeset in webkit [15172] by
-
- 4 edits in trunk/WebCore
2006-07-05 Anders Carlsson <acarlsson@apple.com>
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::createFrame): Fix Win32 build.
- 2:37 PM Changeset in webkit [15171] by
-
- 2 edits in trunk/WebCore
2006-07-05 Anders Carlsson <acarlsson@apple.com>
- WebCore.xcodeproj/project.pbxproj: Revert accidental change of debug format to DWARF.
- 2:29 PM Changeset in webkit [15170] by
-
- 24 edits5 adds in trunk
WebCore:
2006-07-05 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::createFrame):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge installInFrame:]): Modify to pass the owner element instead of the owner renderer.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): Dispatch the node inserted events before attaching the nodes. This is what the tokenizer does.
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): Pass the element to requestFrame.
(WebCore::HTMLFrameElement::setLocation):
Don't call attach/detach on an iframe.
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): Load the frame here (using openURL).
(WebCore::HTMLIFrameElement::removedFromDocument):
Call frameDetached.
(WebCore::HTMLIFrameElement::attach):
If there's a renderer, attach the content frame to it.
(WebCore::HTMLIFrameElement::detach):
Reset the renderer's frame.
(WebCore::HTMLIFrameElement::openURL):
Modify to request the frame.
- html/HTMLIFrameElement.h: Add detach.
- page/Frame.cpp: (WebCore::parentFromOwnerElement): (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::disconnectOwnerElement):
- page/Frame.h:
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
- rendering/RenderPart.cpp: (WebCore::RenderPart::setFrame): Modify to keep an owner element around instead of the renderer.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Don't do anything for iframes.
WebKit:
2006-07-05 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Modify to pass the owner element instead of the owner renderer.
- WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Remove assertion, it's not valid anymore.
LayoutTests:
2006-07-05 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array
- fast/events/mouseover-mouseout2-expected.txt:
- fast/events/mouseover-mouseout2.html: Update expected result. Since we now keep the frame around, the mouseout event is now dispatched to the element in the frame.
- fast/events/onloadFrameCrash-expected.checksum:
- fast/events/onloadFrameCrash-expected.png:
- fast/events/onloadFrameCrash-expected.txt: This does hide the frame now.
- fast/frames/iframe-display-none-expected.txt: Added.
- fast/frames/iframe-display-none.html: Added.
- fast/frames/resources/iframe-display-none-child.html: Added. New test that tests JS interaction with frames.
- fast/frames/iframe-double-attach-expected.txt: Added.
- fast/frames/iframe-double-attach.html: Added.
- 1:05 PM Changeset in webkit [15169] by
-
- 2 edits1 add in trunk/WebKit
Reviewed by Harrison.
<rdar://problem/4608423> HIViewAdapter used but not defined
Adds a new export file to fix the build.
- WebKit.LP64.exp: Added.
- WebKit.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [15168] by
-
- 16 edits2 moves in trunk/JavaScriptCore
RS by Beth.
Renamed JSCharBufferRef, which was universally unpopular, to JSStringBufferRef,
which, hopefully, will be less unpopular.
- API/APICast.h: (toJS): (toRef):
- API/JSBase.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
- API/JSCharBufferRef.cpp: Removed.
- API/JSCharBufferRef.h: Removed.
- API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
- API/JSContextRef.h:
- API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
- API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
- API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
- API/JSObjectRef.h:
- API/JSStringBufferRef.cpp: Added. (JSStringMake): (JSStringBufferCreate): (JSStringBufferCreateUTF8): (JSStringBufferRetain): (JSStringBufferRelease): (JSValueCopyStringValue): (JSStringBufferGetLength): (JSStringBufferGetCharactersPtr): (JSStringBufferGetCharacters): (JSStringBufferGetMaxLengthUTF8): (JSStringBufferGetCharactersUTF8): (JSStringBufferIsEqual): (JSStringBufferIsEqualUTF8): (JSStringBufferCreateWithCFString): (CFStringCreateWithJSStringBuffer):
- API/JSStringBufferRef.h: Added.
- API/JSValueRef.h:
- API/JavaScriptCore.h:
- API/minidom.c: (main): (print):
- API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [15167] by
-
- 3 edits in tags/WebKit-521.14.3/WebKit
Build fixes and versioning.
- 11:35 AM Changeset in webkit [15166] by
-
- 1 copy in tags/WebKit-521.14.3
New tag.
- 11:07 AM Changeset in webkit [15165] by
-
- 6 edits in trunk/JavaScriptCore
RS by Beth.
Moved some code around for more logical file separation.
- API/JSBase.h:
- API/JSContextRef.h:
- API/JSObjectRef.cpp:
- API/JSValueRef.cpp: (JSValueToObject):
- API/JSValueRef.h:
- 10:46 AM Changeset in webkit [15164] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Implemented JSFunctionMakeWithBody, which parses a script as a function body
in the global scope, and returns the resulting anonymous function.
I also removed private data from JSCallbackFunction. It never worked,
since JSCallbackFunction doesn't inherit from JSCallbackObject.
- API/JSCallbackConstructor.cpp: Removed.
- API/JSCallbackConstructor.h: Removed.
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction): (KJS::JSCallbackFunction::implementsConstruct): (KJS::JSCallbackFunction::construct): (KJS::JSCallbackFunction::implementsCall): (KJS::JSCallbackFunction::callAsFunction):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
- API/JSObjectRef.cpp: (JSFunctionMake): (JSFunctionMakeWithCallbacks):
- API/JSObjectRef.h:
- API/JSValueRef.h:
- API/minidom.c: (main):
- API/testapi.c: (main):
- JavaScriptCore.exp: Programmatically added all symbols exported by API object files, and sorted results
- JavaScriptCore.xcodeproj/project.pbxproj:
- 9:52 AM Changeset in webkit [15163] by
-
- 10 edits in trunk
Reviewed by Maciej.
- Return syntax error in JSCheckSyntax through a JSValueRef* exception argument
- API/JSBase.h:
- API/JSContextRef.cpp: (JSCheckSyntax):
- API/testapi.c: (main):
- JavaScriptCore.exp:
- kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax):
- kjs/interpreter.h:
JavaScriptGlue:
Reviewed by Maciej.
- JSRun.cpp: (JSRun::CheckSyntax): Updated to use new checkSyntax syntax in JSC.
- JavaScriptGlue.xcodeproj/project.pbxproj:
- 9:35 AM Changeset in webkit [15162] by
-
- 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m
Build fix.
- 9:35 AM Changeset in webkit [15161] by
-
- 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m
Build fix to work with the new linker.
- 9:27 AM Changeset in webkit [15160] by
-
- 1 edit in trunk/WebKit/Misc/WebNSDataExtras.m
Fixes backwards if statement logic.
Jul 4, 2006:
- 11:17 PM Changeset in webkit [15159] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
Bug 9731: [Drosera] crash when trying to access the scope chain
http://bugzilla.opendarwin.org/show_bug.cgi?id=9731
Because of <rdar://problem/4608404> the WebScriptObject, _globalObj, that
WebCoreScriptDebugger holds is unprotected each time the page changes.
This causes Drosera to crash Safari when trying to access the scope chain.
We simply need to detach and re-attach the debugger when the window script
object is cleared until 4608404 is fixed. This change also attaches the
debugger before we call the windowScriptObjectAvailable: delegate method,
so the debugger is ready before anyone might use the window object.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
- 9:52 PM Changeset in webkit [15158] by
-
- 67 edits in trunk
LayoutTests:
Reviewed by Darin.
- change SVG XPath DOM tests to dump as text, and update expected results
This should stop the random failures in Attribute_Nodes.svg
- dom/svg/level3/xpath/Attribute_Nodes-expected.txt:
- dom/svg/level3/xpath/Attribute_Nodes_xmlns-expected.txt:
- dom/svg/level3/xpath/Comment_Nodes-expected.txt:
- dom/svg/level3/xpath/Conformance_Expressions-expected.txt:
- dom/svg/level3/xpath/Conformance_hasFeature_3-expected.txt:
- dom/svg/level3/xpath/Conformance_hasFeature_empty-expected.txt:
- dom/svg/level3/xpath/Conformance_hasFeature_null-expected.txt:
- dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt:
- dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt:
- dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt:
- dom/svg/level3/xpath/Element_Nodes-expected.txt:
- dom/svg/level3/xpath/Processing_Instruction_Nodes-expected.txt:
- dom/svg/level3/xpath/Text_Nodes-expected.txt:
- dom/svg/level3/xpath/XPathEvaluatorCast01-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NS-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_document-expected.txt:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement-expected.txt:
- dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt:
- dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
- dom/svg/level3/xpath/XPathExpression_evaluate_document-expected.txt:
- dom/svg/level3/xpath/XPathExpression_evaluate_documentElement-expected.txt:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix-expected.txt:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml-expected.txt:
- dom/svg/level3/xpath/XPathResult_TYPE_ERR-expected.txt:
- dom/svg/level3/xpath/XPathResult_booleanValue_false-expected.txt:
- dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt:
- dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_numberValue-expected.txt:
- dom/svg/level3/xpath/XPathResult_resultType-expected.txt:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_stringValue-expected.txt:
- dom/svg/level3/xpath/svgunit.js:
WebKitTools:
Reviewed by Darin.
- add support for dumping non-HTML as text - in this case use textContent instead of innerText
- DumpRenderTree/DumpRenderTree.m: (dump):
- 9:34 PM Changeset in webkit [15157] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
Bug 9732: [Drosera] calling removeListener to many times will cause
WebKit's listener count to underflow/wraparound
Adds a check to make sure the listener was in our listeners set before
decrementing the global listener count. Also checks for nil in addListner
to prevent a possible exception when adding the object to the set.
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
- 9:25 PM Changeset in webkit [15156] by
-
- 2 edits in trunk/JavaScriptCore
- fixed build
- wtf/MathExtras.h: Oops. Added missing #endif.
- 9:13 PM Changeset in webkit [15155] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Tweaked a bit by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 work around MSVCRT's fmod function returning NaN for fmod(x, infinity) instead of x
- wtf/MathExtras.h: Added include of <float.h>. (isinf): Fix to return false for NAN. (wtf_fmod): Added. An inline that works around the bug.
- kjs/nodes.cpp:
- kjs/number_object.cpp:
- kjs/operations.cpp:
- kjs/value.cpp: Added includes of MathExtras.h to all files using fmod.
- JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode 2.3 have its way with the project.
- 9:04 PM Changeset in webkit [15154] by
-
- 10 edits3 adds in trunk/WebCore
Reviewed by Maciej, reworked a bit by Darin.
Compile fixes for wx port / gcc 4.0.2
- platform/PlatformString.h:
- platform/StringImpl.h: Include CoreFoundation for CF-specific code.
- dom/DocPtr.h:
- doc/EventTargetNode.h: Silence warnings about 'extra tokens' after #endif on gcc 4.0.2. (Not an error but warnings appear frequently.)
- WebCoreSources.bkl:
- webcore-base.bkl: Synching ports sources file with TOT. Also, making sure SRCDIR variable overrides any previous values.
- loader/ImageDocument.cpp: Use PLATFORM(MAC) for the parts that are specific to the Macintosh version, and move the Objective-C parts to another file.
- loader/mac/ImageDocumentMac.h: Added.
- loader/mac/ImageDocumentMac.mm: Added.
- 6:05 PM Changeset in webkit [15153] by
-
- 2 edits in trunk/LayoutTests
- updated test result to reflect window without scroll bars
1) this test should not have scroll bars
2) on the buildbot the result is the non-scroll-bar one
- dom/svg/level3/xpath/Attribute_Nodes-expected.txt: Changed text node width to 800.
- 4:40 PM Changeset in webkit [15152] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/Color.cpp: (WebCore::makeRGBAFromHSLA):
- 3:14 PM Changeset in webkit [15151] by
-
- 6 edits8 adds in trunk
LayoutTests:
Reviewed by Darin.
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Tests using HSL rather than RGB for color values.
- fast/css/hsl-color-expected.checksum: Added.
- fast/css/hsl-color-expected.png: Added.
- fast/css/hsl-color-expected.txt: Added.
- fast/css/hsl-color.html: Added.
- fast/css/hsla-color-expected.checksum: Added.
- fast/css/hsla-color-expected.png: Added.
- fast/css/hsla-color-expected.txt: Added.
- fast/css/hsla-color.html: Added.
WebCore:
Reviewed by Darin.
- Added HSL color support as specified in CSS3 spec. http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Added parsing support of hsl(h,s,l) and hsla(h,s,l,a) Added converting code to convert HSL to RGB
- css/cssparser.cpp: (WebCore::CSSParser::parseColorParameters): Moved common code to parse RGB/RGBA values into it's own function. This code was duplicated in the parseColorFromValue() method. (WebCore::CSSParser::parseHSLParameters): Common code to parse HSL/HSLA values. (WebCore::CSSParser::parseColorFromValue): Moved RGB/RGBA parsing out to seperate function as the code was duplicated. Added parsing support for hsl( and hsla(
- css/cssparser.h: Added two new functions parseColorParameters() and parseHSLParameters().
- platform/Color.cpp: (WebCore::calcHue): Added Hue parameter to RGB color. (WebCore::makeRGBAFromHSLA): New function to convert HSLA to RGBA.
- platform/Color.h: Added new functions makeRGBAFromHSLA() and calcHue().
- 9:45 AM Changeset in webkit [15150] by
-
- 6 edits3 adds in trunk
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Conditional XMLHttpRequest gets should pass 304 responses unchanged
Test: http/tests/xmlhttprequest/cache-override.html
- Misc/WebNSURLRequestExtras.h: Added _web_isConditionalRequest
- Misc/WebNSURLRequestExtras.m: (-[NSURLRequest _web_isConditionalRequest]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Bypass the cache for conditional requests.
- WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Ditto.
