⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 3, 2006:

7:11 PM Changeset in webkit [16210] by weinig
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin and Tim H.

Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _styleSheetWith:]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMStylesheets.h:
  • bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/StyleSheet.idl: Added.
  • css/StyleSheetList.idl: Added.

WebKit:

Reviewed by Darin and Tim H.

  • MigrateHeaders.make:
6:00 PM Changeset in webkit [16209] by weinig
  • 1 add in trunk/WebCore/platform/Path.cpp

Build fix.

3:19 PM Changeset in webkit [16208] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
2:46 PM Changeset in webkit [16207] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid warning about property name conflict.

2:31 PM Changeset in webkit [16206] by rwlbuis
  • 38 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed

Cleanup of code related to RenderPath.

2:20 PM Changeset in webkit [16205] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo Darin called out, but I forgot to change.

2:11 PM Changeset in webkit [16204] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Build fix.

1:48 PM Changeset in webkit [16203] by thatcher
  • 5 edits in trunk

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:42 PM Changeset in webkit [16202] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:38 PM Changeset in webkit [16201] by thatcher
  • 30 edits in trunk/WebCore

Reviewed by Darin.

Bug 10685: ObjC DOM should have no unnamed parameters
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10685

  • The ObjC code generation script now outputs parameter prefixes for methods that have more than 1 parameter. This prefix is simply the parameter name. Some parameter names have been changed in the IDL files to produce better prefixes. If an extended attribute of "ObjCPrefix" exists on a parameter we will use that for the prefix.
  • A backwards compatible version of the method is placed in a category with a deprecation marco for 10.5 and later. This step only happens if the IDL extended attribute "OldStyleObjC" is defined. All new functions in IDL should not get this attribute.
  • Made the $interfaceMethodSelector regex in IDLStructure.pm allow "=" so parameter extended attributes can have values.
  • Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm so it can be shared between the two generators.


  • Removed the die when we encounter a getter that uses exceptions. Sam Weinig added support for this in an earlier change.
  • Check if $ENV{"MACOSX_DEPLOYMENT_TARGET"} is defined before we compare. This caused a perl warning when generating on other platforms.
  • The ObjC generation will not happen on platforms other than Mac OS. This is determined by the "OS" env variable Xcode sets. This check is in the DerivedSources.make.
  • Added a way to skip generation if the constructor of the specific generator returns undef. Not used yet.
  • Many cleanup tweaks in CodeGeneratorObjC.pm.
  • Removed IDL and CSS files from the project's resource copy phase, these do no need to be in WebCore's resources.
  • DerivedSources.make
  • WebCore.xcodeproj/project.pbxproj
  • bindings/scripts/CodeGenerator.pm
  • bindings/scripts/CodeGeneratorJS.pm
  • bindings/scripts/CodeGeneratorObjC.pm
  • bindings/scripts/IDLStructure.pm
  • css/CSSMediaRule.idl
  • css/CSSPrimitiveValue.idl
  • css/CSSStyleDeclaration.idl
  • css/CSSStyleSheet.idl
  • dom/CharacterData.idl
  • dom/DOMImplementation.idl
  • dom/Document.idl
  • dom/Element.idl
  • dom/KeyboardEvent.idl
  • dom/MouseEvent.idl
  • dom/MutationEvent.idl
  • dom/NamedNodeMap.idl
  • dom/UIEvent.idl
  • html/HTMLCanvasElement.idl
  • html/HTMLSelectElement.idl
  • ksvg2/bindings/idl/svg/SVGLengthList.idl
  • ksvg2/bindings/idl/svg/SVGNumberList.idl
  • ksvg2/bindings/idl/svg/SVGPointList.idl
  • ksvg2/bindings/idl/svg/SVGStringList.idl
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl
  • ksvg2/bindings/idl/svg/SVGTransformList.idl
  • ksvg2/svg/SVGSVGElement.idl
  • page/DOMWindow.idl
12:08 PM Changeset in webkit [16200] by ap
  • 11 edits in trunk

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10693
Convert JavaScript arrays to AppleScript lists

JavaScriptCore:

  • JavaScriptCore.exp: Export ArrayInstance::info and ArrayInstance::getItem().
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getItem): Added a method to access array items from C++.

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added a case for ArrayInstance.

LayoutTests:

  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/array.html: Updated results, added a test for circular dependencies.

WebKitTools:

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject): (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.
10:28 AM Changeset in webkit [16199] by ap
  • 1 edit in trunk/LayoutTests/http/tests/incremental/slow-utf8-html.pl

http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

9:59 AM Changeset in webkit [16198] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
REGRESSION (r16175): Errors in incremental decoding of UTF-8

Tests:

  • http/tests/incremental/slow-utf8-html.pl
  • fast/encoding/charset-invalid.html
  • loader/Decoder.cpp: (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match the logic in setEncodingName(). (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding constructor to lowercase it if necessary. (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the validity of encoding - it is enforced by class constructor and setEncodingName().
6:45 AM Changeset in webkit [16197] by weinig
  • 1 edit in trunk/WebCore/bindings/objc/DOMRGBColor.h

Fixes build for regression tests.

2:25 AM Changeset in webkit [16196] by ap
  • 4 edits
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
Layout tests access an external server

  • fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present, but the test still pointed to a remote one).
  • fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
  • fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of a non-existent http one.
  • fast/loader/docLoaderFrame-expected.checksum: Removed.
  • fast/loader/docLoaderFrame-expected.png: Removed.
  • fast/loader/docLoaderFrame-expected.txt: Removed.
  • fast/loader/docLoaderFrame.html: Removed.
  • http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
  • http/tests/xmlhttprequest/docLoaderFrame.html: Added.
  • http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added. Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it actually work.

Sep 2, 2006:

7:10 PM Changeset in webkit [16195] by weinig
  • 17 edits
    11 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm: (+[DOMCSSStyleSheet _CSSStyleSheetWith:]): (+[DOMCSSPrimitiveValue _valueWith:]):
  • bindings/objc/DOMCSSInternal.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMRGBColor.h: Added.
  • bindings/objc/DOMRGBColor.mm: Added. (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSCharsetRule.idl: Added.
  • css/CSSFontFaceRule.idl: Added.
  • css/CSSImportRule.idl: Added.
  • css/CSSMediaRule.idl: Added.
  • css/CSSPageRule.idl: Added.
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl: Added.
  • css/CSSStyleSheet.idl: Added.
  • css/CSSUnknownRule.idl: Added.
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl: Added.
  • css/Rect.idl:
  • css/RectImpl.h:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
12:19 PM Changeset in webkit [16194] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

Testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/style/table-selection-expected.checksum: Added.
  • editing/style/table-selection-expected.png: Added.
  • editing/style/table-selection-expected.txt: Added.
  • editing/style/table-selection.html: Added.

WebCore:

Reviewed by Justin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by making sure that the 'beyondEnd' node is after the start node.
12:15 PM Changeset in webkit [16193] by thatcher
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • JavaScriptCoreSources.bkl:

WebCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

  • WebCoreSources.bkl:
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • webcore-base.bkl:
10:25 AM Changeset in webkit [16192] by adele
  • 6 edits in trunk/WebCore

Reviewed by Anders.

Test: fast/forms/password-doubleclick-selection.html

  • editing/visible_units.cpp: (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character isn't treated as a punctuation boundary. (WebCore::nextBoundary): ditto.
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's string instead of the node value. This matches the base class implementation of handleTextNode.

Code cleanup.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Avoid unnecessary check for password field case if the smart replace condition is false.
  • page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code. Calls isSelectionInPasswordField now.
  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.

Sep 1, 2006:

6:43 PM Changeset in webkit [16191] by hyatt
  • 6 edits in trunk/WebCore

Fix for 10682, refine the FOUC paint suppression logic so that it
is only triggered when FOUC would really have occurred.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): (WebCore::Document::): (WebCore::Document::didLayoutWithPendingStylesheets):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
6:10 PM Changeset in webkit [16190] by aroben
  • 11 edits in trunk

2006-09-01 MorganL <​morlmor@yahoo.com>

Reviewed by Darin. Updated/landed by Adam.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
Windows build fixes

5:57 PM Changeset in webkit [16189] by beidson
  • 6 edits in trunk/WebCore

Reviewed by Tim Omernick

Added an SQLDatabase logging channel. Changed all SQLDatabase and SQLStatement errors to use this new channel.
Also, as a popular request from other contributers, added a log for all prepare(), step(), finalize(), and reset()s
Also, fixed a grammar error in my previous ChangeLog entry.

  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize the new channel
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setBusyTimeout): Use SQLDatabase logging channel (WebCore::SQLDatabase::setBusyHandler): ditto (WebCore::SQLDatabase::clearAllTables): ditto (WebCore::SQLDatabase::runVacuumCommand): ditto
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Added a log (WebCore::SQLStatement::step): ditto (WebCore::SQLStatement::finalize): ditto (WebCore::SQLStatement::reset): ditto (WebCore::SQLStatement::getColumnBlob): Use SQLDatabase logging channel (WebCore::SQLStatement::returnTextResults): ditto (WebCore::SQLStatement::returnTextResults16): ditto (WebCore::SQLStatement::returnIntResults): ditto (WebCore::SQLStatement::returnInt64Results): ditto (WebCore::SQLStatement::returnDoubleResults): ditto
  • platform/Logging.cpp: (WebCore::): Added new logging channel
  • platform/Logging.h: ditto
5:55 PM Changeset in webkit [16188] by adele
  • 20 edits in trunk

LayoutTests:

Reviewed by Tim Omernick.

Updated results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
Switch to use new text field implementation for <input type="password">

  • dom/html/level2/html/HTMLInputElement22-expected.txt:
  • dom/xhtml/level2/html/HTMLInputElement22-expected.txt:
  • fast/events/event-sender-mouse-click.html:
  • fast/forms/input-appearance-height-expected.checksum:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-type-change-in-onfocus-mouse-expected.txt:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/input-value-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

Updated from switch to style-able selects

  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:

WebCore:

Reviewed by Tim Omernick.

  • css/html4.css: Give input[password] the same style properties as normal text fields.
  • html/HTMLInputElement.cpp: Removed checks for TextFieldAppearance. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField):
5:03 PM Changeset in webkit [16187] by beidson
  • 8 edits in trunk/WebCore

Reviewed by John (though Sarge review a previous patch of mine in an attempt to review this one)

Added some constants for SQL Result Codes to SQLDatabase.h
This way, users of SQLDatabase can access all necessary SQLite functionality
without having access to sqlite3.h.
Also reordered some files in the xcodeproj and some #includes

  • WebCore.xcodeproj/project.pbxproj: Reordered some files
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Use our new result codes
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): Use our new result codes (WebCore::IconDatabase::retainIconForPageURL): Use our new result codes (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Use our new result codes (WebCore::IconDatabase::addIconForIconURLQuery): Use our new result codes (WebCore::IconDatabase::hasIconForIconURLQuery): Use our new result codes
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastError): Moved from header to eliminate dependency on sqlite3.h in header (WebCore::SQLDatabase::lastErrorMsg): Ditto
  • loader/icon/SQLDatabase.h: Removed #include <sqlite3.h>
  • loader/icon/SQLStatement.cpp: Added #include <sqlite3.h>
  • loader/icon/SQLStatement.h: Removed #include <sqlite3.h>
4:53 PM Changeset in webkit [16186] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

My ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)

4:20 PM Changeset in webkit [16185] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Darin

A "never should be reach" method was reached - lets not release the shared database bridge, esp
since we never retain it!

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge
3:57 PM Changeset in webkit [16184] by hyatt
  • 4 adds in trunk/LayoutTests/fast/flexbox

Add flexbox test.

3:56 PM Changeset in webkit [16183] by hyatt
  • 2 edits in trunk/WebCore

Fix for 10680, contrained flexbox is not shrinking flexible children
properly. (Fixing in case it's hit by the file upload control.)

Reviewed by aroben

Adding 026.html to fast/flexbox.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
2:52 PM Changeset in webkit [16182] by eseidel
  • 4 edits in trunk/WebCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Implement support for multiple parents in the SVG idls.

For class "FooBar" go through all parents recursively,
collect their attributes & functions & constants and
add them directly into the class "FooBar".

(Note: It is NOT enabled by default for now - still some things related to SVGAnimated* need to be solved first)

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/generate-bindings.pl:
2:50 PM Changeset in webkit [16181] by eseidel
  • 6 edits in trunk

2006-09-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix build on Linux.

  • CMakeLists.txt: Add platform/CString.cpp.
  • platform/qt/FrameQt.cpp: Correct repsondToChangedContents() signature
  • platform/qt/FrameQt.h:: Correct respondToChangedContents() signature
2:41 PM Changeset in webkit [16180] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed unnecessary declarations. Renamed sharedBridgeInstance to sharedInstance.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Put functions inside WebCore namespace. (WebCore::IconDatabase::loadIconFromURL): Updated for sharedInstance namespace.

WebKit:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed to allocate one of these. (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the shared instance. Added the "self = [super init]" idiom even though it's not important in this case just to be consistent. (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file so it can be called without declaring it in the header. (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use CFRetain for compatibility. (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false). (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.
2:21 PM Changeset in webkit [16179] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Adele.

Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10677

2:00 PM Changeset in webkit [22139] by sfalken
  • 5 edits in branches/WindowsMerge
1:09 PM Changeset in webkit [16178] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

  • updated results, null is not round-tripped through the bindings because of regressions the original change caused in other applications.
  • added an echo for "undefined".
  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:

WebCore:

Reviewed by Darin.

<rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
<rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields

jsNull should not be returned as NSNull because existing applications do not
expect that return value. Return as nil for backwards compatibility.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
1:05 PM Changeset in webkit [16177] by ap
  • 4 edits in trunk/JavaScriptCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fix build on Linux (C89 without gcc extensions enabled).

  • pcre/pcre_internal.h: Use C style comments.
  • wtf/Assertions.h: Use C style comments.
  • wtf/Platform.h: Use C style comments.
12:48 PM Changeset in webkit [16176] by ap
  • 2 edits in trunk/WebCore

Build fix.

  • loader/Decoder.cpp: (Decoder::Decoder): Use String::latin1().
12:36 PM Changeset in webkit [16175] by ap
  • 12 edits
    18 adds in trunk

Reviewed by Eric.

WebCore:

  • loader/Decoder.cpp: (Decoder::Decoder): Decoder now knows what kind of content it is decoding. Also, the browser default encoding can now be passed directly to the constructor, to streamline the logic. (Decoder::decode): Add support for @charset, differentiate between HTML and XML. (Decoder::setEncodingName): Style cleanup. (Decoder::encodingName): Ditto. (Decoder::flush): Ditto.
  • loader/Decoder.h: (WebCore::Decoder::):
  • bridge/mac/WebCoreEncodings.mm: Pass a content type of text/html to Decoder.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h: Use Decoder instead of TextEncoding::toUnicode() to enable @charset support.
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): Pass a content type.
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Ditto. (WebCore::CachedXSLStyleSheet::data): Flush the decoder to be safe.
  • page/Frame.cpp: (WebCore::Frame::write): Pass a content type and a default encoding to the Decoder.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Pass the output document MIME type.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData): Ditto.

LayoutTests:

  • fast/encoding/css-charset-expected.txt: Added.
  • fast/encoding/css-charset.css: Added.
  • fast/encoding/css-charset.html: Added.
  • fast/encoding/css-charset-evil-expected.txt: Added.
  • fast/encoding/css-charset-evil.css: Added.
  • fast/encoding/css-charset-evil.html: Added.
  • fast/encoding/default-xhtml-encoding-expected.txt: Added.
  • fast/encoding/default-xhtml-encoding.xhtml: Added.
  • fast/encoding/meta-in-xhtml-expected.txt: Added.
  • fast/encoding/meta-in-xhtml.xhtml: Added.
  • fast/encoding/pseudo-xml-2-expected.txt: Added.
  • fast/encoding/pseudo-xml-2.html: Added.
  • fast/encoding/pseudo-xml-3-expected.txt: Added.
  • fast/encoding/pseudo-xml-3.html: Added.
  • fast/encoding/pseudo-xml-4-expected.txt: Added.
  • fast/encoding/pseudo-xml-4.html: Added.
  • fast/encoding/pseudo-xml-expected.txt: Added.
  • fast/encoding/pseudo-xml.html: Added.
12:01 PM Changeset in webkit [16174] by adele
  • 5 edits in trunk/WebCore

Reviewed by John.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode. (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
  • bridge/mac/FrameMac.h: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
  • page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
11:07 AM Changeset in webkit [22138] by adachan
  • 3 edits in branches/WindowsMerge/WebCore

2006-09-01 Ada Chan <​adachan@apple.com>

Reviewed by lamadio.

Fixed build break.

10:21 AM Changeset in webkit [16173] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't smart replace when the selection being replaces is in a password field.

Aug 31, 2006:

9:08 PM Changeset in webkit [16172] by thatcher
  • 12 edits
    4 adds in trunk

WebCore:

Reviewed by Tim H.


Auto-generates DOMHTMLAnchorElement, DOMHTMLAreaElement,
DOMHTMLBaseFontElement, DOMHTMLFontElement, DOMHTMLFrameElement,
DOMHTMLFrameSetElement, DOMHTMLHRElement, DOMHTMLIFrameElement,
DOMHTMLImageElement, DOMHTMLMapElement, DOMHTMLModElement,
DOMHTMLObjectElement, DOMHTMLParamElement, DOMHTMLScriptElement,
DOMHTMLTableCaptionElement, DOMHTMLTableCellElement,
DOMHTMLTableColElement, DOMHTMLTableElement, DOMHTMLTableRowElement,
and DOMHTMLTableSectionElement.

Splits DOMHTMLAppletElement and DOMHTMLOptionElement into their own
files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLAnchorElement absoluteLinkURL]): (-[DOMHTMLImageElement altDisplayString]): (-[DOMHTMLImageElement absoluteImageURL]): (-[DOMHTMLImageElement WebCore::]): (-[DOMHTMLObjectElement absoluteImageURL]): (-[DOMHTMLObjectElement WebCore::]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]):
  • bindings/objc/DOMHTMLAppletElement.h: Added.
  • bindings/objc/DOMHTMLAppletElement.mm: Added. (-[DOMHTMLAppletElement WebCore::]): (-[DOMHTMLAppletElement align]): (-[DOMHTMLAppletElement setAlign:]): (-[DOMHTMLAppletElement alt]): (-[DOMHTMLAppletElement setAlt:]): (-[DOMHTMLAppletElement archive]): (-[DOMHTMLAppletElement setArchive:]): (-[DOMHTMLAppletElement code]): (-[DOMHTMLAppletElement setCode:]): (-[DOMHTMLAppletElement codeBase]): (-[DOMHTMLAppletElement setCodeBase:]): (-[DOMHTMLAppletElement height]): (-[DOMHTMLAppletElement setHeight:]): (-[DOMHTMLAppletElement hspace]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement name]): (-[DOMHTMLAppletElement setName:]): (-[DOMHTMLAppletElement object]): (-[DOMHTMLAppletElement setObject:]): (-[DOMHTMLAppletElement vspace]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAppletElement width]): (-[DOMHTMLAppletElement setWidth:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMHTMLOptionElement.h: Added.
  • bindings/objc/DOMHTMLOptionElement.mm: Added. (-[DOMHTMLOptionElement WebCore::]): (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]):
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
8:58 PM Changeset in webkit [22137] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by kevin.


Fix back/forward regression.


Combining the two receivedAllData methods into one broke back/forward navigation,
since we put the resetting of m_quickRedirectComing and m_loadType at the start
of the combined method, but have code in the rest of receivedAllData that
relies on these having their old values.

  • WebFrame.cpp: (WebFrame::receivedAllData):


7:28 PM Changeset in webkit [16171] by aliceli1
  • 11 edits in trunk

LayoutTests:

Reviewed by Darin.

Revised expected results for an isindex element because of
<rdar://problem/4463870> Switch to use new text field implementation for <isindex>
Now the field is rendered as a textfield

  • fast/dom/isindex-002-expected.checksum:
  • fast/dom/isindex-002-expected.png:
  • fast/dom/isindex-002-expected.txt:

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/4463870> Switch to use new text field implementation for <isindex>

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): moved isindex from the list of nonTextInputTypes to the list of textInputTypes
  • css/html4.css: added isindex to certain rules that applied to input fields
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer): for the 8 methods above, moved the case for isindex to the same case as text
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): added isindex to this test
  • html/HTMLIsIndexElement.idl: HTMLIsIndexElement inherits from HTMLInputElement
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): removed the case for isindex since we changed the renderer type from a RenderLineEdit to a RenderTextControl in WebCore::HTMLInputElement::createRenderer()
6:57 PM Changeset in webkit [16170] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Prepare for another round of renaming.
6:13 PM Changeset in webkit [16169] by harrison
  • 11 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4708119> REGRESSION: Cannot observe an AXTextField element directly

... and most of
<rdar://problem/4708022> REGRESSION: TextRange-based attributes are missing from text fields
<rdar://problem/4709515> REGRESSION: Expose text areas

Remaining work for those two bugs in new bugs:

<rdar://problem/4712101> Support NSAccessibilityVisibleCharacterRangeAttribute for AXTextField and AXTextArea elements
<rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
<rdar://problem/4712125> Support setting NSAccessibilitySelectedTextAttribute for AXTextField and AXTextArea elements

  • bridge/AXObjectCache.h: (WebCore::AXObjectCache::postNotificationToElement):
  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): Removed postNotificationToTopWebArea. postNotification now posts to input element or top web area, as appropriate. postNotificationToElement posts to the specified element itself.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedContents): Take a selection. Pass the starting position's renderer to postNotification so that postNotification can post to the appropriate input element, if any.


  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isWebArea]): (-[WebCoreAXObject isAnchor]): (-[WebCoreAXObject isTextRange]): New convenience methods.


(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription])
(-[WebCoreAXObject value]):
(-[WebCoreAXObject accessibilityDescription]):
Support AXTextField and AXTextArea.

(-[WebCoreAXObject accessibilityShouldUseUniqueId]):
Register AXTextField and AXTextArea elements so notifications to them can be observed.


(-[WebCoreAXObject accessibilityIsIgnored]):
Use new convenience method isWebArea.

(-[WebCoreAXObject accessibilityAttributeNames]):
Simplify the array creation.
Add text range support.


(-[WebCoreAXObject accessibilityAttributeValue:]):
Add text range support.


(-[WebCoreAXObject canSetFocusAttribute]):
(-[WebCoreAXObject canSetValueAttribute]):
(-[WebCoreAXObject canSetTextRangeAttributes]):
New convenience methods.


(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Add text range support.

(-[WebCoreAXObject observableObject]):
New to locate text field or text area to notify.


  • dom/Document.cpp: (WebCore::Document::updateSelection): Post AXSelectedTextChanged notification with new selection's start node. postNotification will send it to the input element, if there is one, or the top WebArea.


(WebCore::Document::implicitClose):
Use postNotificationToElement now that it acts like the old postNotification.


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): Pass the selection of interest to respondToChangedContents.


  • page/FrameView.cpp: (WebCore::FrameView::layout): Use postNotificationToElement now that it acts like the old postNotification.
6:12 PM Changeset in webkit [16168] by sfalken
  • 3 edits in trunk/JavaScriptCore

2006-09-01 Steve Falkenburg <​sfalken@apple.com>

Fix build.

6:11 PM Changeset in webkit [22136] by andersca
  • 3 edits
    1 add in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

Add our own internal config.h so we can make changes to it.


  • WebCore.vcproj/WebCore.vcproj: Add config.h to the file list, move the KXMLCORE_PLATFORM_CF to the new config.h file


  • config.h: Added.


  • platform/win/ResourceLoaderWin.cpp: Include config.h
5:17 PM Changeset in webkit [16167] by adele
  • 9 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionInPasswordField]): Added.
  • page/Frame.cpp: (WebCore::Frame::isSelectionInPasswordField): Added.
  • page/Frame.h:

WebKit:

Reviewed by Darin.

WebKit part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Check that the selection isn't in a password field before adding these items to the default editing context menu.

Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction

  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
  • WebView/WebHTMLViewPrivate.h:
4:48 PM Changeset in webkit [22135] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage.

4:43 PM Changeset in webkit [16166] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Forgot the ChangeLog

4:15 PM Changeset in webkit [22134] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Add a platform scrollbar class for Windows. Doesn't really work yet.

4:11 PM Changeset in webkit [16165] by antti
  • 2 edits in S60/trunk/WebCore

2006-08-31 bujtas <​zbujtas@gmail.com>

Reviewed by Antti Koivisto.
DESC: do not call updateStyleAttributeIfNeeded when the
element is removed from doc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10662

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::scrollIntoView): (ElementImpl::blur): (ElementImpl::getAttributeNS): (ElementImpl::setAttribute): (ElementImpl::setAttributeMap): (ElementImpl::isURLAttribute): (ElementImpl::removedFromDocument): (ElementImpl::recalcStyle): (ElementImpl::dispatchAttrRemovalEvent): (ElementImpl::dispatchAttrAdditionEvent): (ElementImpl::openTagStartToString): (ElementImpl::toString): (ElementImpl::updateId): (ElementImpl::formatForDebugger): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
3:59 PM Changeset in webkit [16164] by andersca
  • 4 edits
    1 add in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.


Add new portability functions to MathExtras.h and add StringExtras.h which is for
string portability functions.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_instance.cpp:
  • kjs/date_object.cpp:
  • wtf/MathExtras.h: (copysign): (isfinite):
  • wtf/StringExtras.h: Added. (snprintf): (strncasecmp):
3:55 PM Changeset in webkit [16163] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H.


Fix Windows build.


  • JavaScriptCore.vcproj/dftables/dftables.vcproj:
  • pcre/pcre_internal.h:
3:44 PM Changeset in webkit [16162] by thatcher
  • 1 edit in trunk/WebKit/DOM/WebDOMOperations.m

Build fix to avoid a property name conflict warning.

3:31 PM Changeset in webkit [16161] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

3:26 PM Changeset in webkit [16160] by andersca
  • 10 edits in trunk/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H, Hyatt.

  • WebCore.xcodeproj/project.pbxproj: Add KURLCFNet.cpp


  • platform/KURL.h: Get rid of include, add KURL constructor that takes a CFURLRef.


  • platform/PlatformString.h:
  • platform/StringImpl.h: Get rid of include.


  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Add constructor.


  • platform/cf/ResourceLoaderCFNet.cpp: Fix includes.


  • platform/cf/StringCF.cpp: (WebCore::String::createCFString): Move this here from PlatformString.h


  • platform/cf/StringImplCF.cpp: (WebCore::StringImpl::createCFString): Fix cast.


  • platform/mac/KURLMac.mm: Move createCFURL() to KURLCFNet.cpp
2:59 PM Changeset in webkit [16159] by hyatt
  • 2 edits in trunk/WebCore

Make ScrollBar.cpp able to be compiled on Win32.

2:54 PM Changeset in webkit [16158] by thatcher
  • 3 edits in trunk/WebCore

Build fixes for ppc64 and x86_64, and fixes needed now that we use -Wshorten-64-to-32.

2:52 PM Changeset in webkit [16157] by beidson
  • 1 edit in trunk/WebCore/loader/icon/IconDatabase.h

Renamed an argument in a header for clarity (meant to go with last checkin)

2:44 PM Changeset in webkit [16156] by thatcher
  • 2 edits in trunk/JavaScriptCore/API

Build fixes for ppc64 and x86_64 now that we use -Wshorten-64-to-32.

2:28 PM Changeset in webkit [16155] by thatcher
  • 7 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Band-aid fix for PCRE to compile for ppc64 and x86_64 now that
we use -Wshorten-64-to-32. Adds an INT_CAST macro that ASSERTs
the value <= INT_MAX.

I filed <rdar://problem/4712064> to track the need to verify
PCRE's 64-bit compliance.

  • pcre/pcre_compile.c: (complete_callout): (compile_branch): (compile_regex): (pcre_compile2):
  • pcre/pcre_exec.c: (match): (pcre_exec):
  • pcre/pcre_get.c: (pcre_get_substring_list):
  • pcre/pcre_internal.h:
  • pcre/pcre_tables.c:
  • pcre/pcre_try_flipped.c: (_pcre_try_flipped):
2:26 PM Changeset in webkit [16154] by beidson
  • 3 edits in trunk/WebCore

Reviewed by John

Cleaned up my last patch after further considerations

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Uses the new checkForDanglingPageURLs to check for and fix danglers. Does so in all builds (changed from debug only in my last patch) (WebCore::IconDatabase::syncDatabase): Uses the new checkForDanglingPageURLs to check for danglers (WebCore::IconDatabase::checkForDanglingPageURLs): This checks and, if asked via an arg, prunes the dangling pageURLs
  • loader/icon/IconDatabase.h:
2:05 PM Changeset in webkit [16153] by andersca
  • 4 edits
    2 adds in trunk/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Add CString. CString is a simple, null-terminated byte buffer that supports data
sharing. Its main use is to be a better const char*.


Also add latin1 and utf8 methods to String which returns CStrings.


  • platform/CString.cpp: Added. (WebCore::CString::CString): (WebCore::CString::init): (WebCore::CString::data): (WebCore::CString::length): (WebCore::CString::deprecatedCString):
  • platform/CString.h: Added. (WebCore::CStringBuffer::CStringBuffer): (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CString::CString): (WebCore::CString::operator const char*): (WebCore::CString::isNull):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::latin1): (WebCore::String::utf8):
2:01 PM Changeset in webkit [22133] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Fix the build.

  • WebCore.vcproj/WebCore.vcproj:
1:26 PM Changeset in webkit [16152] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Previously mentioned ASSERT was hit right away by folks, as we first need to bring their old icon.db into consistency
Changed the ASSERT to a LOG_ERROR and added a method for debug builds to bring a DB back together.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Check for the danglers and prune them out (WebCore::IconDatabase::syncDatabase): Check for the danglers and log the error (WebCore::IconDatabase::pruneDanglingPageURLs): Prune the danglers
  • loader/icon/IconDatabase.h:
1:25 PM Changeset in webkit [16151] by antti
  • 2 edits in S60/trunk/WebCore
12:40 PM Changeset in webkit [16150] by spadma
  • 2 edits in S60/trunk/WebCore

2006-08-31 spadma <​sachin.padma@nokia.com>

Reviewed by Sriram.
DESC: Set the focused element type to none when no anchor is focused
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10659

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::tabbedNavigation):
11:57 AM Changeset in webkit [16149] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-31 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin/Yongjun.
DESC: Set the current page Url.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadResourceL):
11:22 AM Changeset in webkit [16148] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid name conflicts with generated properties.

10:38 AM Changeset in webkit [16147] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Hyatt

Fixed an error where an Icon's IconID could change without the change being reflected in the PageURL table,
causing icons to be pruned before their time and pages to lose their icons. This is because I misunderstood
how SQLite handles the "ON CONFLICT REPLACE" condition, which is to delete the row and re-insert instead of
perform an update. Also added an assertion to make sure this doesn't happen again.

  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Instead of one INSERT relying on SQLites conflict handling, broke this into an UPDATE attempt followed by the initial INSERT
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::createDatabaseTables): Slight tweak to the database schema to prevent this from happening in the future. Note this change will not cause incompatibility with the current schema, therefore I didn't update the official database version number (WebCore::IconDatabase::syncDatabase): Added an ASSERT to look for this condition in the future
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastChanges): Added this SQLite accessor to see if an UPDATE command actually changed a row
  • loader/icon/SQLDatabase.h: Ditto
10:37 AM Changeset in webkit [22132] by sfalken
  • 20 edits
    4 adds in branches/WindowsMerge
10:20 AM Changeset in webkit [16146] by weinig
  • 13 edits in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLBRElement, DOMHTMLButtonElement, DOMHTMLDListElement,
DOMHTMLDirectoryElement, DOMHTMLDivElement, DOMHTMLFieldSetElement,
DOMHTMLHeadingElement, DOMHTMLInputElement, DOMHTMLLIElement, DOMHTMLLabelElement,
DOMHTMLLegendElement, DOMHTMLMenuElement, DOMHTMLOListElement, DOMHTMLOptGroupElement,
DOMHTMLParagraphElement, DOMHTMLPreElement, DOMHTMLQuoteElement, DOMHTMLSelectElement,
DOMHTMLTextAreaElement, and DOMHTMLUListElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement altDisplayString]): (-[DOMHTMLInputElement absoluteImageURL]): (-[DOMHTMLInputElement WebCore::]): (-[DOMHTMLInputElement _rectOnScreen]): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
9:31 AM Changeset in webkit [16145] by adele
  • 10 edits in trunk

WebCore:

Reviewed by John Sullivan.

Removing use of SPI in favor of Carbon API to enable and disable secure event input.

  • WebCore.exp: Removed wkSecureEventInput and wkSetSecureEventInput.
  • platform/mac/WebCoreSystemInterface.h: ditto.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Uses EnableSecureEventInput and DisableSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Uses IsSecureEventInputEnabled.

WebKit:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
9:25 AM Changeset in webkit [16144] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick


  • fixed <rdar://problem/4711200> Loading history would be faster if it bypassed NSURL API for local files
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor style issues in this method, and I removed the support for old NSArray-style history files (which we stopped using before Safari 1.0).
9:06 AM Changeset in webkit [16143] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-30 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10646

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
9:02 AM Changeset in webkit [16142] by zbujtas
  • 8 edits in S60/trunk/WebCore

2006-08-29 yadavall <​koivisto@iki.fi>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9077

  • khtml/editing/markup.cpp: (khtml::endMarkup):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createTokenizer):
  • khtml/html/html_documentimpl.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): (DocumentImpl::documentElement):
  • khtml/xml/dom_docimpl.h:
8:38 AM Changeset in webkit [16141] by zbujtas
  • 2 edits in S60/trunk/MemoryManager

2006-08-31 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan
DESC: debug
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10212

  • Src/Allocator.cpp: (CPlainAllocator::ReAllocate):
8:10 AM Changeset in webkit [16140] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-28 bujtas <​zbujtas@gmail.com>

Reviewed by Antti Koivisto.
DESC: backgroung image is not ref-ed properly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10619

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
8:00 AM Changeset in webkit [16139] by brmorris
  • 2 edits in S60/trunk

2006-08-29 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: runATF sometimes does not detect test suite finished.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10625

  • runATF.bat: fork emulator launch, add END block to restore start.rsc

Aug 30, 2006:

11:22 PM Changeset in webkit [16138] by beidson
  • 2 edits in trunk/WebCore

Reviewed by "common sense" (and Maciej)

Fixed two logging typos

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
7:09 PM Changeset in webkit [16137] by adele
  • 2 edits in trunk/WebCore

Adding missing nil check for focus node.

  • page/Frame.cpp: (WebCore::Frame::setIsActive):
6:50 PM Changeset in webkit [16136] by adele
  • 14 edits in trunk

WebCore:

Reviewed by Hyatt.

WebCore part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
  • platform/mac/WebCoreSystemInterface.h: ditto.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry. (WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
  • page/Frame.h: (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::secureKeyboardEntry):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Hyatt.

Updated for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebKitSystemInterface.h: Added WKSetSecureEventInput and WKSecureEventInput;
  • libWebKitSystemInterface.a:
6:15 PM Changeset in webkit [16135] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebIconDatabaseBridge.m

Build fix.

5:20 PM Changeset in webkit [16134] by darin
  • 15 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

  • eliminated the need for UsesPassRefPtr in IDL files
  • got rid of the category mechanism for ObjC generated DOM headers (after discussions with Tim H where we decided it's not needed)
  • simplified use of macro inside ObjC generated code
  • ForwardingHeaders/wtf/GetPtr.h: Added.
  • bindings/scripts/CodeGeneratorObjC.pm: Removed code to handle categories. Eliminated use of DOM_cast since that's for the protection of human programmers -- the script won't make mistakes that it needs to catch. Changed macro to always be named IMPL instead of incorporating the class name. Use WTF::getPtr to extract the pointer, and removed the code that uses .get() to extract the pointer in the PassRefPtr case.
  • dom/Attr.idl: Removed all uses of UsesPassRefPtr and ObjCCatagory.
  • dom/DOMImplementation.idl: Ditto.
  • dom/Document.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NamedNodeMap.idl: Ditto.
  • html/HTMLDocument.idl: Ditto.
  • html/HTMLElement.idl: Ditto.
  • html/HTMLFormElement.idl: Ditto.
  • html/HTMLMapElement.idl: Ditto.
  • html/HTMLSelectElement.idl: Ditto.
  • html/HTMLTableElement.idl: Ditto.
  • html/HTMLTableRowElement.idl: Ditto.
  • html/HTMLTableSectionElement.idl: Ditto.
5:12 PM Changeset in webkit [16133] by darin
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

  • add WTF::getPtr, a function template that makes it possible to write generic code that gets a raw pointer out of any of our pointer types
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/GetPtr.h: Added.
  • wtf/ListRefPtr.h: (WTF::getPtr): Added.
  • wtf/OwnArrayPtr.h: (WTF::getPtr): Added.
  • wtf/OwnPtr.h: (WTF::getPtr): Added.
  • wtf/PassRefPtr.h: (WTF::getPtr): Added.
  • wtf/RefPtr.h: (WTF::getPtr): Added.
4:32 PM Changeset in webkit [16132] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by John

<rdar://problem/4707718> - Instead of faking the user out with an in-memory icon database if their
~/Library/Safari/Icons is unwritable, we'll actually fail to open the icon database and the app will
run as if it was disabled via a preference.
Also took the opportunity to change some ASSERTS() to reasonable behavior

  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): NSLog on failure so the user has a chance to figure out there's a problem. (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): From here on, just replaced ASSERTS() with reasonable behavior (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If we fail to open, return false (WebCore::IconDatabase::~IconDatabase): cleanup better
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John

<rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
continues on as if the IconDatabase is disabled.


  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Release the bridge on failure to open
  • WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
4:27 PM Changeset in webkit [16131] by thatcher
  • 2 edits
    1 add in trunk/WebKit

Reviewed by Darin.

Simplify the header copies from WebCore and JavaScriptCore.
Headers that need to be migrated from the other projects need
to be added to MigrateHeaders.make.

  • MigrateHeaders.make: Added.
  • WebKit.xcodeproj/project.pbxproj:
3:09 PM Changeset in webkit [16130] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4708007> REGRESSION: text field inside a webpage no longer has settable AXValueAttribute
<rdar://problem/4707479> REGRESSION: controls inside a webpage no longer have settable AXFocusedAttribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject canSetFocusAttribute]): (-[WebCoreAXObject canSetValueAttribute]): New utility methods. Text fields and buttons are focusable. Text fields can have their value set. We need not make popupbutton value settable because AppKit does not.


(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
Call new utility methods.


(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Set focus for text field or button.
Set value for text field.

2:46 PM Changeset in webkit [16129] by hyatt
  • 6 edits in trunk/WebCore

Fix for bugs 9000 and 10606. Add code to suppress painting when
a FOUC situation would otherwise occur. There will still typically be
a flash to white, but at least the wrong content won't show.

Reviewed by darin

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::preferredStylesheetSet): (WebCore::Document::selectedStylesheetSet): (WebCore::Document::setSelectedStylesheetSet): (WebCore::Document::stylesheetLoaded): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::isSubframe): (WebCore::RenderLayer::hitTest):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
2:19 PM Changeset in webkit [16128] by weinig
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Fix build for Drosera.

2:12 PM Changeset in webkit [16127] by spadma
  • 17 edits in S60/trunk/WebKit

2006-08-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Requests that are not handled by ResolveLinkL or ResolveEmbeddedLinkL need a status
returned from BufferLoader's RequestL method. The following methods are modified to return
a status code: QueueTransaction, SubmitTransaction, DoSubmitTransaction, SubmitTransaction, DoSubmit.
If the return type is not KErrNone (which can only happen in the case of a BufferTransaction) try
to request the transaction from another transaction type.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10605

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/AboutTransaction.h:
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/inc/DataTransaction.h:
  • ResourceLoader/inc/FileTransaction.h:
  • ResourceLoader/inc/HttpTransaction.h: (CHttpTransaction::SetIsRedirected): (CHttpTransaction::IsRedirected):
  • ResourceLoader/inc/UrlLoader.h:
  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
  • ResourceLoader/src/BaseTransaction.cpp: (CBaseTransaction::BaseConstructL): (CBaseTransaction::SubmitTransaction):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::SubmitTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
  • ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::DoSubmitL): (CDataTransaction::CreateHeaderResponseLC):
  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::DoSubmitL): (CFileTransaction::CreateHeaderResponseLC): (CFileTransaction::MHFRunL): (CFileTransaction::ParseFileNameLC): (CFileTransaction::ContentEncoding):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::DoSubmitL):
  • ResourceLoader/src/RequestDispatcher.cpp: (CRequestDispatcher::DispatchL):
  • ResourceLoader/src/UrlLoader.cpp: (CUrlLoader::RequestL): (CUrlLoader::QueueTransaction): (CUrlLoader::SubmitNextTransaction): (CUrlLoader::DoSubmitTransaction):
1:47 PM Changeset in webkit [16126] by rwlbuis
  • 4 edits in trunk/WebCore

2006-08-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric. Landed by rwlbuis.

Apply Rob's fixes in RenderPathQt too -> unbreak build.

1:36 PM Changeset in webkit [16125] by weinig
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement,
DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement,
DOMHTMLMetaElement, DOMHTMLStyleElement and DOMHTMLTitleElement.

Splits DOMHTMLDocument into it's own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLDocument.h: Added.
  • bindings/objc/DOMHTMLDocument.mm: Added. (-[DOMHTMLDocument WebCore::]): (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Tim H.

  • WebKit.xcodeproj/project.pbxproj:
1:24 PM Changeset in webkit [16124] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Use QColor <-> Color conversion operator, instead of faking it.

  • platform/qt/FontQt.cpp: (WebCore::Font::drawGlyphs):
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
1:20 PM Changeset in webkit [16123] by rwlbuis
  • 9 edits in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10586
pointer-events has issues when things are not stroked/filled

Add a param to fillContains/strokeContains to indicate
whether we still want hit testing when there is no fill/stroke.

1:00 PM Changeset in webkit [16122] by justing
  • 15 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line


Fixed:

  • editing/pasteboard/smart-paste-002-expected.checksum:
  • editing/pasteboard/smart-paste-002-expected.png:
  • editing/pasteboard/smart-paste-002-expected.txt: Added to demonstrate fix:
  • editing/pasteboard/4700297-expected.checksum: Added.
  • editing/pasteboard/4700297-expected.png: Added.
  • editing/pasteboard/4700297-expected.txt: Added.
  • editing/pasteboard/4700297.html: Added. Removed a superfluous style span:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt: Accidently checked in bad results yesterday:
  • editing/pasteboard/copy-paste-bidi-expected.txt: Equivalent render tree:
  • editing/pasteboard/smart-paste-001-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Rebalance whitespace around insertionPos before insertion because the content might cause a collapse, e.g. inserting <div>foo</div> at hello world.
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): Rebalance with all nbsps for simplicity, we can produce sequences of regular spaces and nbsps on serialization (10636).
12:37 PM Changeset in webkit [16121] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

The old solution was slow & does not work correctly.
Move the QString -> DeprecatedString conversion into
DeprectedString.cpp, to be able to access allocateHandle().

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::DeprecatedString):
  • platform/qt/StringQt.cpp:
12:16 PM Changeset in webkit [16120] by aroben
  • 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Implement containsCharacters() / determinePitch() functions.

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch):
11:58 AM Changeset in webkit [16119] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin's rubberstamp

We apparently have a fancy delateAllValues() helper for HashMap/Sets - I'll use that instead

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeAllIcons):
11:48 AM Changeset in webkit [16118] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by ggaren.

  • Verification of exceptions thrown in a plugin. Test for bug 10114.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin throwIfArgumentIsNotHello:]):
11:45 AM Changeset in webkit [16117] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed, tweaked by ggaren.


  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/ExecState.h:
  • kjs/context.h: (KJS::Context::setExecState): (KJS::Context::execState):

LayoutTests:

Reviewed by ggaren.

WebCore:

Reviewed, tweaked by ggaren.


11:32 AM Changeset in webkit [16116] by adele
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

  • page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
  • page/Frame.h: Added mayCopy.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag. (WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method. This also checks mayCopy now. (WebCore::FrameMac::mayDHTMLCopy): ditto. (WebCore::FrameMac::tryDHTMLCut): ditto. (WebCore::FrameMac::tryDHTMLCopy): ditto. (WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function. (WebCore::FrameMac::tryDHTMLPaste): ditto.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge mayCopy]): Calls the renamed method on frame. (-[WebCoreFrameBridge mayDHTMLCut]): ditto. (-[WebCoreFrameBridge mayDHTMLCopy]): ditto. (-[WebCoreFrameBridge mayDHTMLPaste]): ditto. (-[WebCoreFrameBridge tryDHTMLCut]): ditto. (-[WebCoreFrameBridge tryDHTMLCopy]): ditto. (-[WebCoreFrameBridge tryDHTMLPaste]): ditto.
  • css/html4.css: Added !important to the -webkit-text-security property for password fields.

WebKit:

Reviewed by Darin.

WebKit part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
Disallow copy from new password fields

  • WebView/WebHTMLView.m: (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy. (-[WebHTMLView _canCut]): Calls _canCopy now. (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item. This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
11:29 AM Changeset in webkit [16115] by thatcher
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Install wtf-unity library.
  • wtf/Platform.h: Add define for the KDE platform.

WebCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Move global variables up to trunk/CMakeLists.txt.

Also rename USE_WEBKIT_SVG_SUPPORT to WEBKIT_USE_SVG_SUPPORT.

WebKitTools:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
  • QtLauncher/CMakeLists.txt: Add ksvg2/ includes.
11:24 AM Changeset in webkit [16114] by thatcher
  • 3 edits in trunk/WebCore

Rubber-stamped by Brady.

Fix for the generated headers to make the build work
during "installhdrs" builds. Also export DOM headers
using the #import <WebCore/DOM*.h> syntax.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
11:15 AM Changeset in webkit [16113] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk35

Branching for release S60 RnD release 2006w35

9:50 AM Changeset in webkit [16112] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric and Tim H.

Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10634


Remove the check for canShowFile: from _web_bestURL: since
it shouldn't be concerned with whether or not the view
can show the URL, merely return the most appropriate URL.

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]):
1:11 AM Changeset in webkit [16111] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked
<rdar://problem/4707718> - If user's Icon directory is unwritable, Safari will crash at startup

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge removeAllIcons]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If DB file is not writeable, create an in-memory DB for this session (WebCore::IconDatabase::close): Use new deleteAllPreparedStatements() (WebCore::IconDatabase::removeAllIcons): Actually implemented (WebCore::IconDatabase::deleteAllPreparedStatements): Added for convinience/consistency (WebCore::IconDatabase::setPrivateBrowsingEnabled): Use new SQLDatabase::clearAllTables()
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::clearAllTables): Moved this from IconDatabase as it actually belongs here (WebCore::SQLDatabase::vacuum): Added
  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::path): changed name from getPath()

WebKit:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked

  • Misc/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification

Aug 29, 2006:

10:07 PM Changeset in webkit [16110] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Alice

Added a truth value to setIconURLForPageURL so WebKit can avoid sending a notification
This is a win on the iBench

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Alice

Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
This is a win on the iBench

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
9:59 PM Changeset in webkit [16109] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fixed <rdar://problem/4702021> REGRESSION: WebClip and Weather widgets shift downward vertically on screen after I drag them out from dashboard configure bar

  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): reverted the one line in this method back to what it was before r15765. This changed caused window.screenY to be incorrect.
5:48 PM Changeset in webkit [16108] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)
  • fast/css/computed-style-negative-top-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Added.

WebCore:

Reviewed by Hyatt.

  • fix <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)

The bug was that we would return "none" for computed style properties when they were
exactly "-1px".

Test: fast/css/computed-style-negative-top.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): Moved special case for "undefined length" out of here. (WebCore::valueForMaxLength): Moved it into here. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use valueForMaxLength only for max-height and max-width.
4:35 PM Changeset in webkit [16107] by eseidel
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Add path-related SVG JavaScript bindings to generation.

  • CMakeLists.txt:
4:19 PM Changeset in webkit [16106] by eseidel
  • 8 edits
    9 copies
    14 moves in trunk/WebCore

2006-08-29 Eric Seidel <​eric@eseidel.com>

Reviewed by kevin.

Re-enable path-related SVG JavaScript bindings.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10623
Split all SVGPathSeg*.idl files into Abs and Rel pieces.
Move all SVGPath*.idl files into ksvg2/svg

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: Special case Abs and Rel header includes
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Removed.
  • ksvg2/ksvg.h: move SVGPathSegment enum
  • ksvg2/svg/SVGPathElement.cpp: move SVGPathSegment enum (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSeg.cpp: (WebCore::SVGPathSeg::SVGPathSeg):
  • ksvg2/svg/SVGPathSeg.h: (WebCore::SVGPathSeg::):
  • ksvg2/svg/SVGPathSegArcAbs.idl: Added.
  • ksvg2/svg/SVGPathSegArcRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoRel.idl: Added.
4:13 PM Changeset in webkit [16105] by andersca
  • 1 edit in trunk/CMakeLists.txt

Forgot this

3:52 PM Changeset in webkit [16104] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment to work around what seems to be a bug in some versions of gdb.
3:49 PM Changeset in webkit [16103] by andersca
  • 7 edits
    1 add
    1 delete in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

Finish Unity merging. Remove libcurl usage, in favour of KIO.
This makes the regression testing fly! IO processing is way faster now.

  • CMakeLists.txt:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::createEmptyDocument): (WebCore::FrameQt::receivedData): (WebCore::FrameQt::receivedAllData):
  • platform/qt/FrameQt.h:
  • platform/qt/ResourceLoaderCurl.cpp: Removed.
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::~ResourceLoaderManager): (WebCore::ResourceLoaderManager::self): (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ResourceLoaderManager.h:
  • platform/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::receivedResponse):
3:37 PM Changeset in webkit [16102] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatchers rubber stamp

Removed some accidentally left-in console spew during the conversion to the new DB


  • Misc/WebIconDatabase.m: (objectFromPathForKey): Nuked some NSLogs
3:24 PM Changeset in webkit [22131] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build

3:14 PM Changeset in webkit [16101] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox

No layout test for now because Java doesn't work in DumpRenderTree.

  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets (we were always rendering fallback content, if any, for Java applets).
2:58 PM Changeset in webkit [16100] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Bug 10632: Objective-C DOM should use the @property syntax for DOM attributes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10632

Generate @property when MACOSX_DEPLOYMENT_TARGET is >= 10.5.
This is backwards compatible with the getter/setter methods.
Generate setter arguments with a "new" prefix to avoid the property
name conflict warning. Also removes some whitespace and the comments
that we added to the headers. This makes the headers look like what we ship now.

  • bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle::]): renamed a local variable to avoid the property name conflict. (-[DOMDocument getMatchedCSSRules::]): ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: generate @property in the headers.
2:57 PM Changeset in webkit [22130] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Land remaining CG integration patch.

2:40 PM Changeset in webkit [16099] by andersca
  • 2 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix time calculation, by using a correct calculation. Calling time()
returns a number of seconds, aka. an integer. Fix it by using gettimeofday().
Patch originally proposed by Ronan Meneu <​rmeneu@origyn.fr>

  • platform/qt/SystemTimeQt.cpp: (WebCore::currentTime):
1:43 PM Changeset in webkit [22129] by hyatt
  • 5 edits
    11 adds in branches/WindowsMerge/WebCore

This patch lands all the font changes. It does not patch the project file
yet, since this was done on Mac. Will switch to Win32 after landing this
and then fix any glitches.

  • platform/cairo/cairo-all.c: Added.
  • platform/cairo/pixman-all.c: Added.
  • platform/image-decoders/jpeg/jpeg-part1.c: Added.
  • platform/image-decoders/jpeg/jpeg-part2.c: Added.
  • platform/image-decoders/jpeg/jpeg-part3.c: Added.
  • platform/image-decoders/png/png-part1.c: Added.
  • platform/image-decoders/png/png-part2.c: Added.
  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: (WebCore::m_size):
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
1:33 PM Changeset in webkit [16098] by weinig
  • 29 edits
    12 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection, and lays groundwork for the rest of the
HTML DOM bindings by adding/fixing the appropriate IDL's and updating
the CodeGeneratorObjC.pm build script.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCollection.idl: Added.
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl: Added.
  • html/HTMLFrameSetElement.idl: Added.
  • html/HTMLIFrameElement.idl: Added.
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLObjectElement.idl: Added.
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLSelectElement.idl: Added.
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl: Added.
  • html/HTMLTableCellElement.idl: Added.
  • html/HTMLTableColElement.idl: Added.
  • html/HTMLTableElement.idl: Added.
  • html/HTMLTableRowElement.idl: Added.
  • html/HTMLTableSectionElement.idl: Added.
  • html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection.

  • WebKit.xcodeproj/project.pbxproj:
1:05 PM Changeset in webkit [16097] by ap
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10629.
Drawing convex polygons is broken in the Qt platform.

  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
12:16 PM Changeset in webkit [16096] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Implementing font hashing properly, fixes weird crashes in HashMap.

  • platform/qt/FontPlatformData.h:
  • platform/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
12:11 PM Changeset in webkit [16095] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by ggaren.

Fix scrollbars to reappear after the first layouting.

  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::suppressScrollBars):
11:58 AM Changeset in webkit [16094] by andersca
  • 6 edits
    2 copies
    3 adds
    1 delete in trunk/WebCore

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin and Geoff.

Move the CF String functions to separate files in platform/cf.
Also, move the files in platform/cfnet to platform/cf.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformString.h:
  • platform/StringImpl.h:
  • platform/cf/StringCF.cpp: Added. (WebCore::String::String):
  • platform/cf/StringImplCF.cpp: Added. (WebCore::StringImpl::createCFString):
  • platform/cfnet/KURLCFNet.cpp: Removed.
  • platform/cfnet/ResourceLoaderCFNet.cpp: Removed.
  • platform/mac/StringImplMac.mm:
  • platform/mac/StringMac.mm:
11:57 AM Changeset in webkit [22128] by hyatt
  • 2 edits
    4 adds in branches/WindowsMerge/WebCore

Forking the font files in preparation for dropping in CG code.

Reviewed by adam

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FontDataWin.cpp: Added. (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: Added. (WebCore::m_size): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/win/FontWin.cpp: Added. (WebCore::notImplemented): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
11:56 AM Changeset in webkit [16093] by ggaren
  • 3 edits in trunk/WebCore

Rolling out a change I included by accident in my last commit.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget):
  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
10:30 AM Changeset in webkit [16092] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-29 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
Fix build warnings and export cache header file

  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
  • group/bld.inf:
10:25 AM Changeset in webkit [16091] by beidson
  • 6 edits
    4 deletes in trunk/WebKit

Reviewed by Darin

Short of a few small snippets that still need to be pushed to WebCore, this
is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
and the small remaining snippets of WebFileDatabase code that were still important
are now in static functions in WebIconDatabase.m

  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Removed the flag
  • Misc/WebFileDatabase.h: Removed.
  • Misc/WebFileDatabase.m: Removed.
  • Misc/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (uniqueFilePathForKey): Added from WebFileDatabase (objectFromPathForKey): Added from WebFileDatabase (iconDataFromPathForIconURL): (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
  • Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Deleted 4 files
  • WebKitPrefix.h: Removed ICONDEBUG
10:07 AM Changeset in webkit [22127] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Ada.

  • WebKitDLL.cpp: (DllMain): Set the global instance handle.
8:33 AM Changeset in webkit [16090] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-28 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Update the minimap setting from pagescaler
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10504

  • BrowserView/src/WebKitView.cpp: (CWebKitView::InitializePageScalerL):

Aug 28, 2006:

6:13 PM Changeset in webkit [16089] by ggaren
  • 14 edits
    3 adds in trunk

Reviewed by Maciej.


Added support for experimental CFNetwork-based loader (not turned on yet).


While I was there, I did the following platform cleanup:

  • Windows now uses USE(WININET) instead of PLATFORM(WIN_OS), to match the USE(CFNETWORK) idiom.
  • Removed some #includes of windows.h in platform-independent headers.
  • Changed #ifdef APPLE to PLATFORM(MAC)
  • Fixed some build bustage, including case-sensitive filesystem bustage.
  • loader/loader.cpp: (WebCore::Loader::receivedAllData):
  • platform/Cursor.h:
  • platform/KURL.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderClient.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/cfnet/KURLCFNet.cpp: Added. (WebCore::KURL::createCFURL):
  • platform/cfnet/ResourceLoaderCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveChallenge): (WebCore::didCancelChallenge): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::addHeadersFromString): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
  • platform/win/CursorWin.cpp:
6:05 PM Changeset in webkit [22126] by ggaren
  • 14 edits in branches/WindowsMerge

Reviewed by Maciej.

Landed CFNetwork loader, off by default. To enable, define:

KXMLCORE_PLATFORM_CF
KXMLCORE_USE_CFNETWORK

CFNetwork uses winsock2. If you do this, you need to make sure that winsock2.h
is included before windows.h in any translation unit in which it's used.
A lot of the jiggering in this patch is devoted to that.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ResourceLoaderWin.cpp: Removed reliance on PlatformData since it wasn't being used, and removing it made easy work of integrating CFNetwork in a Windows-independent way. (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (Path::contains):
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp:
  • rendering/RenderPopupMenuWin.cpp:
  • rendering/RenderPopupMenuWin.h:
  • rendering/RenderThemeWin.cpp:
5:59 PM Changeset in webkit [22125] by adachan
  • 4 edits in branches/WindowsMerge
5:35 PM Changeset in webkit [16088] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/inserting/redo-expected.checksum: Added.
  • editing/inserting/redo-expected.png: Added.
  • editing/inserting/redo-expected.txt: Added.
  • editing/inserting/redo.html: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700341>
REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
  • page/Frame.cpp: (WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().
5:30 PM Changeset in webkit [16087] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Removed a bogus typecast.
4:18 PM Changeset in webkit [16086] by tomernic
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

No test cases added, since this is essentially a leak fix.

A brief history of NPP_GetValue(), NPObjects, and reference counting.

Earlier versions of WebKit incorrectly interpreted the NPRuntime reference counting rules. We failed to take
into account the fact that plug-ins are required to retain NPObjects before returning them. This creates several
classes of interesting plug-ins:

1) Plug-ins tested in WebKit and other browsers. These plug-ins may have WebKit-specific workarounds to not retain

the returned NPObject, thus avoiding the memory leak in WebKit.

2) Plug-ins tested only in other browsers. These plug-ins must already retain their NPObjects, since other browsers

implemented the NPRuntime retain/release rules correctly. These plug-ins likely work in WebKit, but probably leak
NPObjects since WebKit adds its own retain in addition to the plug-in's retain.

3) Plug-ins tested only in WebKit, that fail to retain their NPObjects before returning them.

Such plug-ins are guaranteed to crash in other browsers due to the missing expected retain. These plug-ins
work in older WebKits because WebKit did not expect the plug-in to retain the NPObject. Now that our retain
rules match other browsers, these plug-ins may crash due to the difference in retain/release behavior. We could
potentially detect that situation and correct it here, but I consider it a bug that the plug-in did not follow the
documented NPRuntime reference counting rules. Furthermore, it is extremely unlikely that someone would develop
a Netscape plug-in and test it *only* in WebKit. The entire purpose of creating a Netscape plugin is so that it
works in all browsers!

4) Plug-ins tested only in WebKit, that properly retain their NPObjects before returning them.

These plug-ins probably work in other browsers, and leak their NPObjects in older WebKits because of WebKit's
extra retain. A developer of this type of plug-in is probably unaware of the NPObject leak. A more savvy developer
would create a plug-in that fits into category #1.


I am changing our NPP_GetValue() behavior to match Firefox and other browsers -- the plug-in is now expected to retain the
returned NPObject, and the browser is expected to release it when done. This means that plug-ins in category #3 need to be
changed so that they don't crash in Safari. However, such plug-ins already crash in every other browser, so I do not feel that
this needs to be handled specifically by WebKit.

  • bridge/mac/FrameMac.mm: Changed -pluginScriptableObject to -createPluginScriptableObject to make clearer the contract that the method must return a retained NPObject. Also changed it to return an actual NPObject* instead of a void*. There is only one caller of this method, and only one implementor. Using void* here is a needless abstraction. It's an NPObject*! Admit it! (WebCore::getInstanceForView): Release the NPObject after creating the bindings instance. This is the actual bug fix.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Renamed this method (see corresponding WebCore ChangeLog entry for an explanation). Style changes.

WebKitTools:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_GetValue): WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox. NPObject return values are expected to be retained by the plug-in, and released by the caller.
3:56 PM Changeset in webkit [16085] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-28 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Some foreign site encoding errors -- due to encoding alias "X-MS950-HKSCS".
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10607

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQCharsetData.c:
3:48 PM Changeset in webkit [16084] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan.

WARNING: NO TEST CASES ADDED OR CHANGED

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10573


  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
2:19 PM Changeset in webkit [16083] by brmorris
  • 18 edits in S60/branches/printing_sabina

2006-08-28 sabina <​sabina.siddiqi@nokia.com>

Reviewed by Bradley.


First cut at print implementation.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9739

  • S60.hrh: Print flags
  • S60StaticLibs.zip: Printing libs
  • WebUi/data/WebUi.rss:
    • WebUi/inc/WebUi.hrh:
    • WebUi/inc/WebUiAppUi.h:
    • WebUi/inc/WebUiLoadObserver.h: (CWebUiLoadObserver::OffScreenBitmapH):
    • WebUi/inc/WebUiWindow.h: (CWebUiWindow::DialogsProvider): (CWebUiWindow::LoadObserver):
    • WebUi/src/WebUiAppUi.cpp: (CWebUiAppUi::ConstructL): (CWebUiAppUi::HandleCommandL): (CWebUiAppUi::ActiveView):
    • WebUi/src/WebUiLoadObserver.cpp: (CWebUiLoadObserver::NewL): (CWebUiLoadObserver::HandleBrowserLoadEventL): (CWebUiLoadObserver::GetProgressInfo):
    • khtml/khtml_part.cpp: (KHTMLPart::print):
    • BrowserView/inc/webkitbridge.h:
    • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
    • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::Print): (CWebKitBridge::PrintBandL): (CWebKitBridge::NotifyBandPrinted): (CWebKitBridge::NotifyPrintStarted): (CWebKitBridge::NotifyPrintEnded):
    • group/webkit.mmp:
2:08 PM Changeset in webkit [16082] by brmorris
  • 1 copy in S60/branches/printing_sabina

New feature branch

1:43 PM Changeset in webkit [16081] by aliceli1
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added tests for <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • http/tests/misc/iframe-domain-test-expected.txt: Added.
  • http/tests/misc/iframe-domain-test.html: Added.

WebCore:

Reviewed by Geoff.

Fixed <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • dom/Document.cpp: (WebCore::Document::open): set the document's url to the parent's url and re-located the code that does this to occur before calling the frame's didExplicitOpen()
  • page/Frame.cpp: (WebCore::Frame::didExplicitOpen): set the frame's url to the document's url
12:00 PM Changeset in webkit [16080] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and Adam

Added an optimization to return early if there's no replacements to be made

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
11:49 AM Changeset in webkit [16079] by ap
  • 3 edits
    2 adds in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Provide stub implementation of RenderPopupMenuQt.

  • CMakeLists.txt:
  • platform/qt/RenderPopupMenuQt.cpp: Added. (WebCore::RenderPopupMenuQt::RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::~RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::clear): (WebCore::RenderPopupMenuQt::populate): (WebCore::RenderPopupMenuQt::showPopup): (WebCore::RenderPopupMenuQt::hidePopup): (WebCore::RenderPopupMenuQt::addSeparator): (WebCore::RenderPopupMenuQt::addGroupLabel): (WebCore::RenderPopupMenuQt::addOption):
  • platform/qt/RenderPopupMenuQt.h: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): (WebCore::RenderThemeQt::createPopupMenu):
11:40 AM Changeset in webkit [16078] by ap
  • 3 edits in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Offer QString -> DeprecatedString conversion.

  • platform/DeprecatedString.h:
  • platform/qt/StringQt.cpp: (WebCore::DeprecatedString::DeprecatedString):
11:37 AM Changeset in webkit [16077] by ap
  • 5 edits in trunk

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Tim Hatcher.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

WebCore:

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): Remove annoying notImplemented() usage in systemFont()

WebKitTools:

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in Qt's DumpRenderTree.
  • Scripts/run-webkit-tests: Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
11:25 AM Changeset in webkit [16076] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • kjs/list.h: Use explicit in constructor (as appropriate).
11:22 AM Changeset in webkit [16075] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/build-drosera: Fix behavior when there are multiple options.
11:22 AM Changeset in webkit [16074] by beidson
  • 5 edits
    2 copies in trunk/WebKit

Reviewed by Tim Hatcher's rubberstamp

Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
failure in layout tests on a release build.

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (+[WebFileDatabaseOp opWithCode:key:object:]): (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp opcode]): (-[WebFileDatabaseOp key]): (-[WebFileDatabaseOp object]): (-[WebFileDatabaseOp perform:]): (-[WebFileDatabaseOp dealloc]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (databaseInit): (-[WebFileDatabase setTimer]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase sizeLimit]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]): (-[WebFileDatabase setSizeLimit:]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • WebKit.xcodeproj/project.pbxproj:
11:18 AM Changeset in webkit [16073] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.js: Add "resize: none" to the list of default values for CSS properties so it will be omitted from most displays of computed style.
8:54 AM Changeset in webkit [16072] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942647> Support AXStyleTextMarkerRangeForTextMarker parameterized attribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Add AXStyleTextMarkerRangeForTextMarker.


(startOfStyleRange):
(endOfStyleRange):
Return first/last VisiblePosition in range having the same style has the specified VisiblePosition.

(-[WebCoreAXObject doAXStyleTextMarkerRangeForTextMarker:]):
Return AXTextMarkerRange for startOfStyleRange/endOfStyleRange of the specified AXTextMarker.


(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Call doAXStyleTextMarkerRangeForTextMarker for AXStyleTextMarkerRangeForTextMarker.

8:46 AM Changeset in webkit [16071] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4517383> Hide all images used for spacing purpose in AX

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Check for one-dimensional image Check whether rendered image was stretched from one-dimensional file image
2:18 AM Changeset in webkit [16070] by beidson
  • 5 edits
    2 deletes in trunk/WebKit

Reviewed by Maciej

Major prune of unnecessary WebFileDatabase code. In the end, what
useful code that remains in WebFileDatabase will likely be moved directly
into WebIconDatabase

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (-[WebFileDatabase initWithPath:]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Aug 27, 2006:

10:59 PM Changeset in webkit [16069] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Rewrote StringImpl::replace(UChar, StringImpl*)

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
8:33 PM Changeset in webkit [16068] by weinig
  • 31 edits
    10 adds in trunk

WebCore:

Reviewed by Tim H.

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMNode description]): (-[DOMNode KJS::Bindings::]): (-[DOMNode dispatchEvent:]): (-[DOMNamedNodeMap _initWithNamedNodeMap:]): (+[DOMNamedNodeMap _namedNodeMapWith:]): (-[DOMNodeList _initWithNodeList:]): (+[DOMNodeList _nodeListWith:]): (-[DOMImplementation _initWithDOMImplementation:]): (+[DOMImplementation _DOMImplementationWith:]): (-[DOMImplementation _DOMImplementation]): (+[DOMDocumentFragment _documentFragmentWith:]): (-[DOMDocumentFragment _fragment]): (-[DOMDocument createCSSStyleDeclaration]): (+[DOMDocument _documentWith:]): (-[DOMDocument _document]): (-[DOMDocument _ownerElement]): (+[DOMAttr _attrWith:]): (-[DOMAttr _attr]): (+[DOMDocumentType _documentTypeWith:WebCore::]): (-[DOMDocumentType WebCore::]): (+[DOMText _textWith:WebCore::]): (+[DOMComment _commentWith:WebCore::]): (+[DOMCDATASection _CDATASectionWith:WebCore::]): (+[DOMProcessingInstruction _processingInstructionWith:WebCore::]): (+[DOMEntityReference _entityReferenceWith:WebCore::]):
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMNode.h: Added.
  • bindings/objc/DOMNode.mm: Added. (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMObject.h: Added.
  • bindings/objc/DOMObject.mm: Added. (-[DOMObject init]): (-[DOMObject dealloc]): (-[DOMObject finalize]): (-[DOMObject copyWithZone:]): (-[DOMObject sheet]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMStylesheets.h:
  • bindings/objc/DOMTraversal.h:
  • bindings/objc/DOMViews.h:
  • bindings/objc/DOMViews.mm:
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPath.mm:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Added.
  • dom/Attr.idl:
  • dom/CDATASection.idl: Added.
  • dom/Comment.idl: Added.
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/EntityReference.idl: Added.
  • dom/NamedNodeMap.idl: Added.
  • dom/NodeList.idl: Added.
  • dom/ProcessingInstruction.idl:

WebKit:

Reviewed by Tim H.

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

  • WebKit.xcodeproj/project.pbxproj:
5:26 PM Changeset in webkit [16067] by thatcher
  • 2 edits
    3 adds in trunk

Reviewed by Anders.

Drosera will be built when you type make.

  • Drosera/Makefile: Added.
  • Makefile: Added.
  • Makefile.shared: Added.
4:12 PM Changeset in webkit [16066] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Fix crash in LayoutTests/css1/font_properties/font.html,
by implementing FontData::smallCapsFontData.

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData):
3:57 PM Changeset in webkit [16065] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Plugged a leak in StringImpl::replace()

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
3:29 PM Changeset in webkit [16064] by andersca
  • 5 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Remove most annoying notImplemented() usages and
implement some missing ScrollViewQt functions.
Much nicer output when invoking run-webkit-tests.

  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::saveDocumentState): (WebCore::FrameQt::restoreDocumentState): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::partClearedInBegin):
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::headerCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::historyContains): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (loadResourceIntoArray): (WebCore::PlugInInfoStore::supportsMIMEType):
3:18 PM Changeset in webkit [16063] by andersca
  • 1 edit in trunk/CMakeLists.txt

Forgot this too (doh!)

3:07 PM Changeset in webkit [16062] by andersca
  • 1 edit in trunk/WebKitTools/Scripts/install-win-extras

Didn't mean to commit this!

3:03 PM Changeset in webkit [16061] by andersca
  • 1 edit
    5 adds in trunk/WebKitTools

2006-08-27 Anders Carlsson <​acarlsson@apple.com>

Forgot to add these.


  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):
2:53 PM Changeset in webkit [16060] by andersca
  • 5 edits in trunk/WebKitTools

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Add DumpRenderTree support for Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):
  • Scripts/build-dumprendertree:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:47 PM Changeset in webkit [16059] by andersca
  • 2 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix Qt build (add SVGMetaDataElement.cpp to build system)

  • CMakeLists.txt:
2:40 PM Changeset in webkit [16058] by eseidel
  • 5 edits
    2 deletes in trunk/WebCore

2006-08-27 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

No logic changes. Just cleanup.

  • ksvg2/svg/SVGAngle.cpp: (SVGAngle::SVGAngle): (SVGAngle::unitType): (SVGAngle::valueAsString): (SVGAngle::newValueSpecifiedUnits): (SVGAngle::convertToSpecifiedUnits):
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::unitType): (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits): (WebCore::SVGLength::updateValue): (WebCore::SVGLength::updateValueInSpecifiedUnits):
  • ksvg2/svg/SVGLength.h:
  • platform/BitmapImage.cpp: Removed.
  • platform/BitmapImage.h: Removed.
2:30 PM Changeset in webkit [16057] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

God, that ChangeLog entry was bad...

2:28 PM Changeset in webkit [16056] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Anders

-Changed all of the commonly used queries to keep around pre-prepared statements and bind
their arguments instead of constructing a messy.
-Changed some code in pruneUnretainedIconsOnStartup regarding transactions

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Initializers (WebCore::IconDatabase::close): Wipe all the preprepared statements (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions (WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery() (WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment (WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding (WebCore::IconDatabase::timeStampForIconURLQuery): ditto (WebCore::IconDatabase::iconURLForPageURLQuery): ditto (WebCore::IconDatabase::forgetPageURLQuery): ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): ditto (WebCore::IconDatabase::addIconForIconURLQuery): ditto (WebCore::IconDatabase::hasIconForIconURLQuery): ditto
  • loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
  • loader/icon/SQLStatement.h: (WebCore::SQLStatement::database): Added
12:27 PM Changeset in webkit [16055] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fix switch logic.

3:47 AM Changeset in webkit [16054] by rwlbuis
  • 58 edits
    6 deletes in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
KCanvasPath should be replace by platform/Path

Refactoring out the KCanvasPath class.

12:09 AM Changeset in webkit [16053] by eseidel
  • 7 edits
    4 adds in trunk

2006-08-26 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

pointer-events attribute does not work.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10415

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic (WebCore::RenderPath::nodeAtPoint): respect pointer-events property
  • kcanvas/RenderPath.h: (WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
  • ksvg2/svg/SVGPaint.h:

Aug 26, 2006:

3:45 PM Changeset in webkit [16052] by rwlbuis
  • 6 edits
    7 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
SVG should have support for <metadata> element

Add support for metadata tag.

2:51 AM Changeset in webkit [16051] by ap
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Daily Qt build fixes :-)

  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
  • platform/qt/ImageQt.cpp: (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource):
1:11 AM Changeset in webkit [16050] by hyatt
  • 2 edits in trunk/WebCore

Fix the ifdef in Path.h to be CG.

  • platform/Path.h:
12:48 AM Changeset in webkit [16049] by hyatt
  • 2 edits in trunk/WebCore

Fix Mac build bustage (lots of float/int confusion). I am not sure
whether rounding was desired or not... this is just a band-aid to get
the build working again.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

Aug 25, 2006:

11:49 PM Changeset in webkit [16048] by hyatt
  • 13 edits
    1 add in trunk/WebCore

More refactoring of image to disentangle graphics (e.g., Cairo) from
platform (e.g., Windows).

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add ImageWin to project.
  • loader/Cache.cpp: (WebCore::Cache::init):
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::loadImageFromResource): Renamed loadResource to loadPlatformResource to try to make it more clear that this call is implemented on each OS (and not by graphics libraries).
  • platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::invalidateData): (WebCore::Image::size): (WebCore::Image::setData): (WebCore::Image::setNativeData): Fix up the PDF code to not be considered platform data any more, since PDF rendering is not for a specific OS.

Renamed the methods that set OS-specific data (like NSImage) to PlatformData
instead of NativeData.

  • platform/Image.h: Shifted the PDF members into CG defines. Made CGImageRef a CG define. Renamed methods to reflect that they are OS-specific and not graphics-library-specific.


  • platform/cairo/ImageCairo.cpp: Removed the platform data methods. Other platforms besides Windows that use Cairo will need to account for this change by adding these methods to their OS Image*.cpp file.
  • platform/cg/ImageCG.cpp: (WebCore::Image::drawTiled): Add FIXMEs to the wkpattern stuff.
  • platform/cg/PDFDocumentImage.cpp: Shouldn't have #imports in .cpp.
  • platform/mac/ImageMac.mm: (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::getTIFFRepresentation): Add the platform data initializers to the Mac Image file. Move the TIFF representation there as well, since this is only used by Mac code.
  • platform/win/ImageWin.cpp: Added. (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::supportsType): Similar work for Windows. Add stubs for possible future HBITMAP returns in the platform data methods.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizeControl):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintResizeControl): loadResource -> loadPlatformResource
11:45 PM Changeset in webkit [22124] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Add ImageWin to project.

10:31 PM Changeset in webkit [22123] by hyatt
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Land CG/Cairo refactoring (and add some winsock2.h). (I do not really
understand why the winsock2.h stuff would suddenly be needed.)

  • platform/win/ResourceLoaderWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::setAlpha): (GraphicsContext::drawFocusRing): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::setCompositeOperation):
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp:
  • rendering/RenderThemeWin.cpp: (WebCore::prepareForDrawing): (WebCore::doneDrawing):

WebKitWin:

Add code path for doing painting of a WebFrame using CG.

  • WebFrame.cpp: (WebFrame::paint):
6:59 PM Changeset in webkit [16047] by aroben
  • 2 edits in trunk/WebCore

Rubber-stamped by Adele.

Fixed build.

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
5:37 PM Changeset in webkit [16046] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

Fixed up some leaks on [WebIconDatabase init]

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
5:33 PM Changeset in webkit [16045] by adele
  • 15 edits in trunk

LayoutTests:

Updated results for addition of -webkit-text-security.

  • fast/css/computed-style-expected.txt:

WebCore:

Patch by Francisco, Reviewed by me.

Preparation for switch to new text field implementation of password field.

Added -webkit-text-security property.

Tests: updated fast/css/computed-style-expected.txt

  • css/CSSPropertyNames.in: Added -webkit-text-security.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cases for textSecurity.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • css/html4.css: Added style for password field to use -webkit-text-security.
  • html/HTMLInputElement.cpp: Check appearance property to decide which renderer to use. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added check for password.
  • platform/StringImpl.cpp: (WebCore::StringImpl::secure): Added. Converts a string to replace characters with one character, like a bullet.
  • platform/StringImpl.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): Initialize textSecurity. (WebCore::RenderStyle::diff): Added case for textSecurity.
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::textSecurity): Added. (WebCore::RenderStyle::setTextSecurity): Added. (WebCore::RenderStyle::initialTextSecurity): Added.
  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Added case for textSecurity. (WebCore::RenderText::setText): ditto.
4:44 PM Changeset in webkit [16044] by adele
  • 94 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

New tests and updated tests for styled selects.

  • fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
  • fast/borders/borderRadiusInvalidColor-expected.png: Added.
  • fast/borders/borderRadiusInvalidColor-expected.txt: Added.
  • fast/borders/borderRadiusInvalidColor.html: Added.
  • fast/forms/select-baseline-expected.checksum: Added.
  • fast/forms/select-baseline-expected.png: Added.
  • fast/forms/select-baseline-expected.txt: Added.
  • fast/forms/select-baseline.html: Added.
  • editing/pasteboard/4641033-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/001-expected.txt:
  • fast/forms/003-expected.txt:
  • fast/forms/004-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/option-script-expected.txt:
  • fast/forms/option-text-clip-expected.txt:
  • fast/forms/select-change-listbox-to-popup-expected.txt:
  • fast/forms/select-selected-expected.txt:
  • fast/forms/select-style-expected.txt:
  • fast/forms/select-visual-hebrew-expected.txt:
  • fast/invalid/014-expected.txt:
  • fast/parser/document-write-option-expected.txt:
  • fast/replaced/width100percent-expected.txt:
  • http/tests/navigation/anchor-basic-expected.txt:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-goback-expected.txt:
  • http/tests/navigation/anchor-subframeload-expected.txt:
  • http/tests/navigation/javascriptlink-basic-expected.txt:
  • http/tests/navigation/javascriptlink-frames-expected.txt:
  • http/tests/navigation/javascriptlink-goback-expected.txt:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt:
  • http/tests/navigation/metaredirect-basic-expected.txt:
  • http/tests/navigation/metaredirect-frames-expected.txt:
  • http/tests/navigation/metaredirect-goback-expected.txt:
  • http/tests/navigation/metaredirect-subframeload-expected.txt:
  • http/tests/navigation/post-goback2-expected.txt:
  • http/tests/navigation/postredirect-goback2-expected.txt:
  • http/tests/navigation/redirect302-basic-expected.txt:
  • http/tests/navigation/redirect302-frames-expected.txt:
  • http/tests/navigation/redirect302-goback-expected.txt:
  • http/tests/navigation/redirect302-subframeload-expected.txt:
  • http/tests/navigation/relativeanchor-basic-expected.txt:
  • http/tests/navigation/relativeanchor-frames-expected.txt:
  • http/tests/navigation/relativeanchor-goback-expected.txt:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt:
  • http/tests/navigation/success200-basic-expected.txt:
  • http/tests/navigation/success200-frames-expected.txt:
  • http/tests/navigation/success200-frames-loadsame-expected.txt:
  • http/tests/navigation/success200-goback-expected.txt:
  • http/tests/navigation/success200-loadsame-expected.txt:
  • http/tests/navigation/success200-reload-expected.txt:
  • http/tests/navigation/success200-subframeload-expected.txt:
  • http/tests/navigation/timerredirect-basic-expected.txt:
  • http/tests/navigation/timerredirect-frames-expected.txt:
  • http/tests/navigation/timerredirect-goback-expected.txt:
  • http/tests/navigation/timerredirect-subframeload-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug2479-3-expected.txt:
  • tables/mozilla/bugs/bug2479-4-expected.txt:
  • tables/mozilla/bugs/bug29326-expected.txt:
  • tables/mozilla/bugs/bug33855-expected.txt:
  • tables/mozilla/bugs/bug4382-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/margins-expected.txt:
  • tables/mozilla/dom/tableDom-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

Reviewed by Hyatt.

Enable styling for popup menus. Also fixed baseline calculation for buttons and selects.

Tests: fast/forms/select-baseline.html

fast/borders/borderRadiusInvalidColor.html

updated: fast/forms/select-style-expected.txt and more...

  • css/html4.css: Added style rules for styled select elements.
  • platform/GraphicsContext.h: Added argument for antialiasing.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): Added textColor argument so this can be used when the border color is invalid. (WebCore::RenderObject::drawBorder): Removed invalidisInvert since its dead code (any callers that set this to true were already ensuring that their color was valid). Updated drawConvexPolygon call to use FloatPoints instead of IntPoints. (WebCore::RenderObject::paintBorder): Updated to remove invalidisInvert argument from drawBorder call. (WebCore::RenderObject::paintOutline): ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutlineForLine): ditto.
  • rendering/RenderObject.h: Updated arguments for drawBorder and drawBorderArc.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): Changed isRootLineBox argument to true when setting line height. Added case for when there's no children to check for hasLineIfEmpty.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Changed isRootLineBox argument to true when setting line height.
  • rendering/RenderButton.h: (WebCore::RenderButton::hasLineIfEmpty): Added so buttons always get a line height.
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasLineIfEmpty): ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): Added code to check hasLineIfEmpty to give flex boxes line height. (WebCore::RenderFlexibleBox::layoutVerticalBox): ditto.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Moved the appearance adjustment code into adjust style.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Lets the theme paint "decorations", like the arrow control and gradients immediately after painting the background.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): This now checks whether the control is styled, and adjusts the appearance property appropriately. For styled selects, instead of setting the appearance to none, which is what we do for other styled controls, we set the appearance to MenulistButtonAppearance, which indicates that we will draw the arrow controls and button appearance in the engine. (WebCore::RenderTheme::paintDecorations): Added. Paints MenulistButtonAppearance in a different function, so the arrow control will draw at the right time (after the background). (WebCore::RenderTheme::paint): Added case for MenulistButtonAppearance. (WebCore::RenderTheme::paintBorderOnly): ditto. (WebCore::RenderTheme::isControlContainer): Removed cases for MenuListAppearance and MenulistButtonAppearance since the baseline is no longer provided by the theme. (WebCore::RenderTheme::adjustMenuListButtonStyle): Added.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Removed code that made selects unstyle-able. (WebCore::RenderThemeMac::baselinePosition): Removed cases for MenuListAppearance and MenulistButtonAppearance. (WebCore::RenderThemeMac::popupButtonPadding): Added top and bottom padding so empty popups have the right baseline. (WebCore::TopGradientInterpolate): Added. (WebCore::BottomGradientInterpolate): Added. (WebCore::MainGradientInterpolate): Added. (WebCore::RenderThemeMac::paintMenuListButtonGradients): Added. Draws gradients for styled popup menu button appearance. (WebCore::RenderThemeMac::paintMenuListButton): Calls paintMenuListButtonGradients, and draws arrow control. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): Added to set padding and border radius to account for the arrow control size and font size.
3:57 PM Changeset in webkit [16043] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam

Changed some time()-related code to be more platform independent

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::getOrCreateIconDataCache): (WebCore::IconDatabase::setIconDataForIconURL):
3:25 PM Changeset in webkit [16042] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4416432> Radio buttons and Checkboxes in AXWebAreas don't fill in their AXTitle attribute

  • bridge/mac/WebCoreAXObject.mm: (labelForElement): New. Returns the HTMLLabelElement, if any, for the specified Element.


(-[WebCoreAXObject title]):
For input elements, return the innerHTML() of the labelForElement().

2:42 PM Changeset in webkit [16041] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-25 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10570
fix null pointer crash. check if tokenizer is null.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl):
2:28 PM Changeset in webkit [16040] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

Changed some debugging-only code to be more platform independent

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): (WebCore::IconDatabase::syncDatabase):
1:46 PM Changeset in webkit [16039] by brmorris
  • 1 edit
    1 add in S60/trunk/S60Internals

2006-08-25 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin, landed by Brad.
DESC: Added central repository files
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10567

  • S60CenResp.zip: Added.
12:23 PM Changeset in webkit [16038] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-25 naguo <​George.Guo@nokia.com>

Reviewed by Sachin.
DESC: The BrCtl should sent a keydown and keyup too for ECommandMakeCall
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10548

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
12:06 PM Changeset in webkit [16037] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-25 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Set value as per cache configurable parameter
as per center repository.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10567

  • ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::CreateCacheHandlersL):
11:54 AM Changeset in webkit [16036] by zbujtas
  • 6 edits
    1 delete in S60/trunk/S60WebUi

2006-08-25 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10564
ifdefs of obslete flags should be removed for Reindeer UI.

  • ChangeLog:
  • HomePage/group/HomePage.mmp:
  • HomePage/src/DllEntryPoint.cpp: Removed
  • WebUi/group/WebUi.mmp:
  • WebUi/src/WebUiApp.cpp:
  • WebUi/src/WebUiObserver.cpp:
  • WebUi/src/WebUiSettings.cpp: (CWebUiSettings::NewL): (CWebUiSettings::ResetSettingsDbL): (CWebUiSettings::DoSettingsActionL): (CWebUiSettings::UpdateSettingDb): (CWebUiSettings::SetEngineSettingL): (CWebUiSettings::GetSettingByCRIdL): (CWebUiSettings::GetSettingByNameL): (CWebUiSettings::SetSettingByNameL):
11:23 AM Changeset in webkit [16035] by aroben
  • 5 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10561
Qt platform build fixes.

  • platform/qt/FrameQt.h:
  • platform/qt/ScreenQt.cpp: (WebCore::qwidgetForPage): (WebCore::screenRect): (WebCore::screenDepth): (WebCore::usableScreenRect):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
  • platform/qt/WidgetQt.cpp:
9:51 AM Changeset in webkit [16034] by aroben
  • 4 edits in trunk/WebCore

Reviewed/landed by Adam.

Finally fix font caching. WebKit+Qt now works
out of the box without any further patches :-)

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::platformDestroy):
  • platform/qt/FontPlatformData.h:
  • platform/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::fontPtr): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
9:46 AM Changeset in webkit [16033] by aroben
  • 20 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
Confirm to WebKit style guide - last fixes :-)

  • platform/ResourceLoaderClient.h:
  • platform/qt/ComboBoxQt.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::doScroll): (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::setTitle): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::keyEvent): (WebCore::FrameQt::setFrameGeometry):
  • platform/qt/GlyphMapQt.cpp: (WebCore::GlyphMap::fillPage):
  • platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::TextShadow::TextShadow): (WebCore::GraphicsContextPlatformPrivate::p):
  • platform/qt/ImageQt.cpp: (WebCore::FrameData::clear): (WebCore::Image::supportsType):
  • platform/qt/IntSizeQt.cpp:
  • platform/qt/LineEditQt.cpp:
  • platform/qt/ListBoxQt.cpp:
  • platform/qt/PageQt.cpp: (WebCore::Page::windowRect):
  • platform/qt/PathQt.cpp: (WebCore::Path::~Path):
  • platform/qt/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::headerCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::setParentWidget): (WebCore::ScrollView::addChild):
  • platform/qt/SharedTimerQt.cpp: (WebCore::setSharedTimerFiredFunction):
  • platform/qt/SharedTimerQt.h: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::fire):
  • platform/qt/SystemTimeQt.cpp: (WebCore::currentTime):
  • platform/qt/TextEditQt.cpp: (WebCore::PlatformTextEdit::setParentWidget): (WebCore::PlatformTextEdit::text): (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):

Aug 24, 2006:

9:04 PM Changeset in webkit [16032] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

  • blog/wp-content/themes/webkit/style.css: Hide the footer altogether.
6:27 PM Changeset in webkit [22122] by sfalken
  • 17 edits
    3 adds in branches/WindowsMerge/WebKitWin
5:41 PM Changeset in webkit [16031] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebFrame.m: (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
  • WebView/WebView.m: (-[WebViewPrivate dealloc]): release the background color
5:32 PM Changeset in webkit [16030] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Justin.

Follow up for...
<rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

Fix bug I introduced in r15959.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Use topDocument in case we are in a subframe (we want the start/end of the overall page).
4:50 PM Changeset in webkit [16029] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Alice

Fixed my previous checkin, which was pruning the users entire icon db on startup everytime

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings are indexed to 1, not 0
4:32 PM Changeset in webkit [16028] by ggaren
  • 17 edits in trunk/WebCore
4:22 PM Changeset in webkit [22121] by ggaren
  • 8 edits in branches/WindowsMerge
4:09 PM Changeset in webkit [16027] by thatcher
  • 13 edits in trunk

WebCore:

Reviewed by Hyatt.

Allow changing the background color WebCore draws under transparent page backgrounds.
No automated way to test. All tests pass, no performance regression.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor):
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):

WebKit:

Reviewed by Hyatt.

WebView API to allow changing the background color that draws under transparent page backgrounds.

  • WebView/WebFrame.m: (-[WebFrame _makeDocumentView]): (-[WebFrame _updateBackground]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.m: (-[WebFrameView drawRect:]):
  • WebView/WebView.m: (-[WebView setBackgroundColor:]): (-[WebView backgroundColor]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setDrawsBackground:]):
  • WebView/WebViewPrivate.h:
3:07 PM Changeset in webkit [16026] by darin
  • 81 edits
    2 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/drag-into-textarea-expected.txt: Added.
  • fast/forms/drag-into-textarea.html: Added.

WebCore:

Reviewed by Justin.

Test: fast/forms/drag-into-textarea.html

  • bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
  • bridge/win/FrameWin.h: Ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto. (WebCore::FrameMac::registerCommandForUndo): Ditto. (WebCore::FrameMac::registerCommandForRedo): Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter. (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto. (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.
  • editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child parameter to be a PassRefPtr. Reversed order of child and parent parameters.
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto. (WebCore::AppendNodeCommand::doApply): Ditto. (WebCore::AppendNodeCommand::doUnapply): Ditto.
  • editing/ApplyStyleCommand.h: Removed document parameter from constructor.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.
  • editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
  • editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here. (WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly since setEndingSelection is no longer overloaded for Position.
  • editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it m_commands and made both doUnapply and doReapply private.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands. (WebCore::CompositeEditCommand::doReapply): Ditto. (WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up starting and ending selection -- now done inside setParent. Rewrote to use m_commands. (WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::applyStyledElement): Ditto. (WebCore::CompositeEditCommand::removeStyledElement): Ditto. (WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto. (WebCore::CompositeEditCommand::insertNodeBefore): Ditto. (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::removeNode): Ditto. (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto. (WebCore::CompositeEditCommand::splitTextNode): Ditto. (WebCore::CompositeEditCommand::splitElement): Ditto. (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto. (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto. (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto. (WebCore::CompositeEditCommand::joinTextNodes): Ditto. (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto. (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto. (WebCore::CompositeEditCommand::replaceTextInNode): Ditto. (WebCore::CompositeEditCommand::deleteSelection): Ditto. (WebCore::CompositeEditCommand::removeCSSProperty): Ditto. (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code would not remove an empty attribute -- will not come up in practice, but wrong in theory. (WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto. (WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop. (WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a Selection explicitly since setEndingSelection is no longer overloaded for Position. (WebCore::createBlockPlaceholderElement): Collapsed this code so that the block placeholder class string is no longer spread across multiple functions. Perhaps we can get rid of this altogether at some point.
  • editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor. Also removed unneeded destructor.
  • editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.
  • editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.
  • editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(), and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected. Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(), endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which are needed so we can determine which editable elements an editing operation affects. Changed setParent() and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added applyCommand() function that's convenient to use on a newly-created command.
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting and ending root editable elements. (WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed code to assert and set m_start. Eliminated use of EditCommandPtr. (WebCore::EditCommand::unapply): Ditto. (WebCore::EditCommand::reapply): Ditto. (WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this not change the starting selection of the parent unless this is the first command in the parent -- didn't make sense the way it was. (WebCore::EditCommand::setEndingSelection): Changed to set root editable element too. (WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child based on the ending selection of the parent, formerly done by callers. (WebCore::applyCommand): Added.
  • editing/FormatBlockCommand.h: Tweaked formatting.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
  • editing/InsertLineBreakCommand.h: Ditto.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr. (WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum. (WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.
  • editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.
  • editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off the constants.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::InsertListCommand): Ditto. (WebCore::InsertListCommand::doApply): Ditto.
  • editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor and changed the parameter of the node to insert to a PassRefPtr.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.
  • editing/InsertTextCommand.h: Changed insertTab to take const Position&.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto. (WebCore::InsertTextCommand::insertTab): Ditto.
  • editing/JSEditor.h: Tweaked formatting and names.
  • editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.
  • editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
  • editing/MergeIdenticalElementsCommand.h: Ditto.
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.
  • editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
  • editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers. (WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand): Changed to use Type instead of EListType. (WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers. (WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel. (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto. (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): Changed to not use EditCommandPtr. (WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers. (WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel. (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto. (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use EditCommandPtr.
  • editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment parameter to be a PassRefPtr.
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto. (WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.
  • editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto. (WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.
  • editing/RemoveCSSPropertyCommand.h: Tweaked formatting.
  • editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
  • editing/RemoveNodeAttributeCommand.cpp: (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.
  • editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.
  • editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
  • editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
  • editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto. (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto. (WebCore::ReplaceSelectionCommand::doApply): Ditto. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than a macro. Added constructors that take visible positions. Changed setBase and setExtent to take const Position& for better efficiency.
  • editing/Selection.cpp: (WebCore::Selection::Selection): Removed unnecessary double initialization of m_state and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.
  • editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
  • editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.
  • editing/SplitElementCommand.h: Removed unnneeded document parameter.
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand): Ditto.
  • editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.
  • editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
  • editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.
  • editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*. Renamed openForMoveTyping() with isOpenForMoreTyping().
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::insertText): Ditto. (WebCore::TypingCommand::insertLineBreak): Ditto. (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto. (WebCore::TypingCommand::insertParagraphSeparator): Ditto. (WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto. (WebCore::TypingCommand::closeTyping): Ditto. (WebCore::TypingCommand::typingAddedToOpenCommand): Ditto. (WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.
  • editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
  • editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.
  • editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of unsigned short.
  • page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(), and registerCommandForRedo() to take PassRefPtr<EditCommand>.
  • page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand. (WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function from Selection to simplify the code. (WebCore::Frame::selectAll): Ditto. (WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand. (WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to both of the root editable elements involved in a change -- the start selection might be in a different element than the end selection. (WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents, and to do it before setting the ending selection. Also update to use PassRefPtr instead of EditCommandPtr and change the order of setting m_lastEditCommand since passing it to registerCommandForUndo will take ownership and set it to 0. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto. (WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr. (WebCore::Frame::applyStyle): Ditto. (WebCore::Frame::applyParagraphStyle): Ditto.
  • platform/gdk/FrameGdk.h: Updated for above changes.
  • platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
  • platform/win/TemporaryLinkStubs.cpp: Updated for above changes.
2:41 PM Changeset in webkit [22120] by ggaren
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Branching PageWin.cpp from r15969.

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp: Added. (WebCore::Page::Page): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
2:39 PM Changeset in webkit [16025] by spadma
  • 5 edits in S60/trunk

2006-08-24 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin.
Change the name of the data member iVodaphoneCache.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10430

  • ResourceLoader/CacheInc/HttpCacheManager.h:
  • ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::~CHttpCacheManager): (CHttpCacheManager::RequestL): (CHttpCacheManager::ReceivedResponseHeadersL): (CHttpCacheManager::Find): (CHttpCacheManager::CreateCacheHandlersL): (CHttpCacheManager::CacheHandler):
2:04 PM Changeset in webkit [16024] by zbujtas
  • 5 edits in S60/trunk

2006-08-24 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.

check for null when the ustring is expanded


  • kjs/ustring.cpp: (KJS::UChar::toLower): (KJS::UChar::toUpper): (KJS::UString::Rep::computeHash): (KJS::UString::expandCapacity): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::toDouble): (KJS::UString::toStrictUInt32): (KJS::operator==):
  • kjs/ustring.h:
2:01 PM Changeset in webkit [16023] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-24 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10545
Application crashing with unhandled exception when exiting/destructing. This is caused when
LoadFaviconL leaves but is not handled in CWebKitBridge::DocumentComplete. Introduce
a TRAP_IGNORE to catch the leave. The leave is caused by lack of memory when trying to create
a CUrlRequestInfo.

  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::DocumentComplete):
1:18 PM Changeset in webkit [16022] by rwlbuis
  • 2 edits
    3 adds in trunk

Reviewed by Eric. Landed by rwlbuis.

Add QtLauncher (was testunity before), which provides a
standalone "browser" to test the Qt platform stuff.

1:10 PM Changeset in webkit [16021] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-22 ligman <​joseph.ligman@nokia.com>

Reviewed by Zalan Bujtas.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10461
Each character is saved as two bytes, but the charset was not being set to ucs-2. This
caused some saved pages with single byte encoding to load improperly. To fix set
the character set to ucs-2 before saving the page.


WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::GetPageDataL):
1:10 PM Changeset in webkit [16020] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Alice

<rdar://problem/4697973> - Unacceptable delay on startup
<rdar://problem/4690949> - Need to correctly prune unretained pageurls and icons on startup

This patch was started by me and finished by Mark Rowe - we now special case all retains during
startup into one huge sql transaction. Also we track PageURL retains instead of IconURLs so pruning works right.
Testing with reasonable sets of bookmarks/history (3000), startup time is neglibile. Testing with a huge set of
bookmarks (40,000), startup has a noticable delay, but reasonable, and is inline with shipping safari which also
has a noticeable delay.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): adding an initialStartupTransaction and pageRetainStatement (WebCore::IconDatabase::close): do cleanup on the initialStartupSQL stuff (WebCore::IconDatabase::retainIconForPageURL): Track initial PageURL retains in the temporary table (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::retainIconURL): We no longer special case this on startup (WebCore::IconDatabase::releaseIconURL): We no longer special case this on startup (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Handle the big transaction correctly and quickly (WebCore::IconDatabase::syncDatabase): Change the timing log message
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::bindText16): Added this - for reusing commonly used statements by just rebinding parameters.
  • loader/icon/SQLStatement.h:
12:56 PM Changeset in webkit [16019] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fix for Mail stationary. Selecting a stationary item would cause this exception.
* -[WebSubresourceLoader copyWithZone:]: selector not recognized
Uncaught exception - * -[WebSubresourceLoader copyWithZone:]: selector not recognized

  • Loader/WebFrameLoader.m: (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.
12:54 PM Changeset in webkit [16018] by rwlbuis
  • 1 add in trunk/WebCore/platform/qt/qt-encodings.txt

This file was listed in a previous ChangeLog, but not actually committed, fixing.

12:15 PM Changeset in webkit [16017] by brmorris
  • 2 edits in S60/trunk/S60Tools

2006-08-24 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.
Update ChangeLog entry template
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10544

  • prepare-ChangeLog.bat: Template contains DESC and Bugzilla Url
11:50 AM Changeset in webkit [16016] by aroben
  • 10 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • CMakeLists.txt:

Remove KCanvasMatrix.cpp because it no longer exists
Remove platform/qt/test

  • platform/FloatSize.h:
  • platform/image-decoders/bmp/BMPImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp:

Added PLATFORM(QT) hooks in the image-decoders/, as they also need
to work for Qt, not only for Cairo.

  • platform/qt/qt-encodings.txt: Added (required for build).
11:35 AM Changeset in webkit [16015] by aroben
  • 2 edits in trunk/WebCore

Fixing a typo from last patch.

11:32 AM Changeset in webkit [16014] by aroben
  • 32 edits in trunk/WebCore

Reviewed/landed by Adam.

Final cleanup to conform to WebKit coding style!

10:02 AM Changeset in webkit [16013] by andersca
  • 3 edits
    4 adds in trunk/WebCore

2006-08-24 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: Added. (WebCore::doScroll): (WebCore::FrameView::isFrameView): (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::init): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::userAgent): (WebCore::FrameQt::runJavaScriptAlert): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::setTitle): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passWheelEventToChildWidget): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::objectContentType): (WebCore::FrameQt::createPlugin): (WebCore::FrameQt::passMouseDownEventToWidget): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::createEmptyDocument): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::incomingReferrer): (WebCore::FrameQt::mimeTypeForFileName): (WebCore::FrameQt::markMisspellingsInAdjacentWords): (WebCore::FrameQt::markMisspellings): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::saveDocumentState): (WebCore::FrameQt::restoreDocumentState): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::addMessageToConsole): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::getEmbedInstanceForWidget): (WebCore::FrameQt::getObjectInstanceForWidget): (WebCore::FrameQt::getAppletInstanceForWidget): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::issueUndoCommand): (WebCore::FrameQt::issueRedoCommand): (WebCore::FrameQt::issueCutCommand): (WebCore::FrameQt::issueCopyCommand): (WebCore::FrameQt::issuePasteCommand): (WebCore::FrameQt::issuePasteAndMatchStyleCommand): (WebCore::FrameQt::issueTransposeCommand): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::partClearedInBegin): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::handledOnloadEvents): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo): (WebCore::FrameQt::print): (WebCore::FrameQt::shouldInterruptJavaScript): (WebCore::FrameQt::keyEvent): (WebCore::FrameQt::receivedResponse): (WebCore::FrameQt::receivedData): (WebCore::FrameQt::receivedAllData): (WebCore::FrameQt::setFrameGeometry):
  • platform/qt/FrameQt.h: Added.
  • platform/qt/ScrollViewCanvasQt.cpp: Added. (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::sizeHint): (WebCore::ScrollViewCanvasQt::mouseMoveEvent): (WebCore::ScrollViewCanvasQt::mousePressEvent): (WebCore::ScrollViewCanvasQt::mouseReleaseEvent): (WebCore::ScrollViewCanvasQt::keyPressEvent): (WebCore::ScrollViewCanvasQt::keyReleaseEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
  • platform/qt/ScrollViewCanvasQt.h: Added.
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setParentWidget):
9:49 AM Changeset in webkit [16012] by ap
  • 1 edit
    6 adds in trunk/WebCore

Reviewed by ap.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • platform/qt/FontCacheQt.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::createFontPlatformData):
  • platform/qt/FontDataQt.cpp: Added. (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph):
  • platform/qt/FontPlatformData.h: Added.
  • platform/qt/FontPlatformDataQt.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/qt/FontQt.cpp: Added. (WebCore::Font::operator QFont): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
  • platform/qt/GlyphMapQt.cpp: Added. (WebCore::GlyphMap::fillPage):
9:40 AM Changeset in webkit [16011] by harrison
  • 51 edits in trunk

LayoutTests:

Updated expected results for this change:


<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

  • editing/selection/anchor-focus1-expected.txt:
  • editing/selection/anchor-focus2-expected.txt:
  • editing/selection/anchor-focus3-expected.txt:
  • editing/selection/move-begin-end-expected.txt:
  • fast/dom/Element/onclick-case-expected.txt:
  • fast/dom/HTMLInputElement/size-as-number-expected.txt:
  • fast/dom/document-all-input-expected.txt:
  • fast/dom/option-properties-expected.txt:
  • fast/events/objc-keyboard-event-creation-expected.txt:
  • fast/events/onsubmit-bubbling-expected.txt:
  • fast/forms/access-key-expected.txt:
  • fast/forms/activate-and-disabled-elements-expected.txt:
  • fast/forms/button-in-forms-collection-expected.txt:
  • fast/forms/check-box-enter-key-expected.txt:
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/domstring-replace-crash-expected.txt:
  • fast/forms/double-focus-expected.txt:
  • fast/forms/element-by-name-expected.txt:
  • fast/forms/empty-get-expected.txt:
  • fast/forms/focus-expected.txt:
  • fast/forms/form-get-multipart-expected.txt:
  • fast/forms/form-get-multipart2-expected.txt:
  • fast/forms/form-get-multipart3-expected.txt:
  • fast/forms/form-post-urlencoded-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/input-appearance-maxlength-expected.txt:
  • fast/forms/input-changing-value-expected.txt:
  • fast/forms/input-delete-expected.txt:
  • fast/forms/input-selection-hidden-expected.txt:
  • fast/forms/input-selection-restore-expected.txt:
  • fast/forms/input-text-enter-expected.txt:
  • fast/forms/input-truncate-newline-expected.txt:
  • fast/forms/legend-access-key-expected.txt:
  • fast/forms/onchange-enter-submit-expected.txt:
  • fast/forms/onselect-textarea-expected.txt:
  • fast/forms/onselect-textfield-expected.txt:
  • fast/forms/paste-into-textarea-expected.txt:
  • fast/forms/plaintext-mode-1-expected.txt:
  • fast/forms/select-remove-option-expected.txt:
  • fast/forms/select-replace-option-expected.txt:
  • fast/forms/select-reset-expected.txt:
  • fast/forms/selection-functions-expected.txt:
  • fast/forms/text-field-setvalue-crash-expected.txt:
  • fast/forms/textarea-crlf-expected.txt:
  • fast/forms/textarea-scrolled-endline-caret-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/forms/textfield-focus-out-expected.txt:

WebCore:

Reinstate r15966 because layout test changes are correct.

<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

  • editing/TextIterator.cpp: (WebCore::TextIterator::advance):
9:25 AM Changeset in webkit [16010] by ap
  • 4 edits in trunk/WebCore

Reviewed by ap.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

Adapt the KCanvas Qt device to Rob's KCanvasMatrix removal.
Use AffineTransform everywhere instead.

  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt): (WebCore::KRenderingDeviceContextQt::concatCTM): (WebCore::KRenderingDeviceContextQt::ctm):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):
9:19 AM Changeset in webkit [16009] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed, tweaked and landed by ap

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

  • CMakeLists.txt: Adjust to Anders' build fixes.
  • wtf/Platform.h: Fix define for the Qt platform (we don't use/need Cairo.)
3:04 AM Changeset in webkit [16008] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
svg transform: comma delimiting breaks display

Properly parse transforms which use ',' as seperators.

12:12 AM Changeset in webkit [16007] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Adele.



  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource dealloc]):

Aug 23, 2006:

11:22 PM Changeset in webkit [16006] by mjs
  • 7 edits in trunk/WebKit

Reviewed by Brady.


  • move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation for WebFrameLoader just holding on to WebDocumentLoadState
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]):
  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame reload]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebView.m: (-[WebView setCustomTextEncodingName:]):
10:59 PM Changeset in webkit [16005] by beidson
  • 5 edits in trunk/WebKit

Reviewed by Maciej

First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
functionality changes.

  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
  • Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:
9:15 PM Changeset in webkit [16004] by mjs
  • 4 edits
    2 adds in trunk/WebKit

Reviewed by Adele.


  • started factoring most of the guts of WebDataSource into a new class


WebDocumentLoadState is decoupled from the rest of WebKit and will
be moved down to WebCore. I only moved one of the data fields of
WebDataSource for now.

  • Loader/WebDocumentLoadState.h: Added.
  • Loader/WebDocumentLoadState.m: Added. (-[WebDocumentLoadState initWithRequest:]): New class. (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState setFrameLoader:]): (-[WebDocumentLoadState setMainResourceData:]): (-[WebDocumentLoadState mainResourceData]):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call, it would have been called already by this point. (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]):
6:28 PM Changeset in webkit [16003] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Adele.


  • refactoring of WebDataSource in preparation for moving a bunch of it to a new class


  • minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
  • reduce Private category implementation to be only the SPI methods
  • make new Internal and FileInternal categories which contain the remainder (depending on whether they are called from outside of WebDataSource)
  • WebView/WebDataSource.m: (-[WebDataSource _setMainDocumentError:]): (addTypesFromClass): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _fileWrapperForURL:]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]): (-[WebDataSource _finishedLoading]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _mainReceivedError:complete:]): (-[WebDataSource _defersCallbacks]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _archivedSubresourceForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopRecordingResponses]): (-[WebDataSource _loadingStartedTime]): (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]): (-[WebDataSource _title]): (-[WebDataSource _isStopping]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _popSubframeArchiveWithName:]): (-[WebDataSource _setIsClientRedirect:]): (-[WebDataSource _setURL:]): (-[WebDataSource _setLastCheckedRequest:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _stopLoading]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _triggeringAction]): (-[WebDataSource _setTriggeringAction:]): (-[WebDataSource __adoptRequest:]): (-[WebDataSource _isDocumentHTML]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _responses]): (-[WebDataSource _makeRepresentation]): (-[WebDataSource _isClientRedirect]): (-[WebDataSource _originalRequest]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _addToUnarchiveState:]): (-[WebDataSource _setOverrideEncoding:]): (-[WebDataSource _setIconURL:]): (-[WebDataSource _setIconURL:withType:]): (-[WebDataSource _overrideEncoding]): (-[WebDataSource _setTitle:]):
  • WebView/WebDataSourceInternal.h:
6:01 PM Changeset in webkit [16002] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

5:38 PM Changeset in webkit [16001] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • added an assert to make it slightly easier to debug the common case of calling document() on a node of 0
  • dom/Node.h: (WebCore::Node::document): ASSERT(this).
5:04 PM Changeset in webkit [16000] by hyatt
  • 3 edits in trunk/JavaScriptCore

Fix Platform.h to include #defines for graphics features.

Reviewed by darin

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • wtf/Platform.h:
5:02 PM Changeset in webkit [15999] by hyatt
  • 41 edits
    7 copies
    3 moves
    1 add in trunk/WebCore

Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
separates the graphics engines from their respective platforms and replaces
#ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.h:
  • platform/Color.h:
  • platform/Cursor.h:
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/FloatSize.h:
  • platform/Font.h:
  • platform/FontData.h:
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/GraphicsContext.h:
  • platform/Image.h:
  • platform/ImageSource.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderClient.h:
  • platform/Widget.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/cairo/ImageCairo.cpp:
  • platform/cairo/ImageSourceCairo.cpp:
  • platform/cg/AffineTransformCG.cpp:
  • platform/cg/FloatPointCG.cpp: Added.
  • platform/cg/FloatRectCG.cpp: Added.
  • platform/cg/FloatSizeCG.cpp: Added.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine):
  • platform/cg/GraphicsContextPlatformPrivate.h: Added. (WebCore::GraphicsContextPlatformPrivate:::m_cgContext): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
  • platform/cg/ImageCG.cpp: Added. (WebCore::Image::drawTiled):
  • platform/cg/ImageSourceCG.cpp: Added.
  • platform/cg/IntPointCG.cpp: Added.
  • platform/cg/IntRectCG.cpp: Added.
  • platform/cg/IntSizeCG.cpp: Added.
  • platform/cg/PDFDocumentImage.cpp: Added. (WebCore::PDFDocumentImage::adjustCTM):
  • platform/cg/PDFDocumentImage.h: Added.
  • platform/cg/PathCG.cpp:
  • platform/image-decoders/bmp/BMPImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp:
  • platform/mac/FloatPointMac.mm:
  • platform/mac/FloatRectMac.mm:
  • platform/mac/FloatSizeMac.mm:
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/ImageMac.mm:
  • platform/mac/ImageSourceMac.cpp: Removed.
  • platform/mac/IntPointMac.mm:
  • platform/mac/IntRectMac.mm:
  • platform/mac/IntSizeMac.mm:
  • platform/mac/PDFDocumentImage.h: Removed.
  • platform/mac/PDFDocumentImage.mm: Removed.
4:54 PM Changeset in webkit [22119] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin
4:46 PM Changeset in webkit [15998] by justing
  • 2 edits in trunk/LayoutTests

I forgot to check in these expected results yesterday.

2:42 PM Changeset in webkit [22118] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Fixed placement of popups when document is scrolled.

2:36 PM Changeset in webkit [15997] by hyatt
  • 2 edits in trunk/WebCore

Remove the ifdef for platform scrollbars vs. engine scrollbars until
engine scrollbars actually exist.

  • platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
2:33 PM Changeset in webkit [15996] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison


Removed the poorly named next/previousVisiblePosition
and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
Removed the unused VisiblePosition::maxOffset()

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::canonicalPosition):
  • editing/VisiblePosition.h:
2:06 PM Changeset in webkit [15995] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan

/me crosses fingers
Flip the switch to the new Icon Database
Massive code pruning is coming up

  • WebKitPrefix.h: Flipped the switch
2:04 PM Changeset in webkit [15994] by rwlbuis
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Alexey. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

1:48 PM Changeset in webkit [15993] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Beth
Since I just pushed the default URL icon from WebKit to WebCore, but
WebKit was still using its version of the default icon, this patch makes it
use the WebCore version

  • Misc/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]):
12:31 PM Changeset in webkit [15992] by beidson
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Adele

Moved default URL icon from WebKit to WebCore

  • Resources/urlIcon.tiff: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::loadImageFromResource):
  • loader/icon/IconDataCache.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::defaultIcon):
  • loader/icon/IconDatabase.h:
11:24 AM Changeset in webkit [22117] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-23 Steve Falkenburg <​sfalken@apple.com>

Build fix (many of our include paths were wrong!)

  • WebCore.vcproj/WebCore.vcproj:
11:08 AM Changeset in webkit [15991] by aroben
  • 6 edits in trunk/WebCore

Reviewed by Darin, Adele.

Some popup refactoring/cleanup.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::hidePopup):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::popup): (WebCore::RenderMenuList::popupIsVisible):
  • rendering/RenderPopupMenu.h:
  • rendering/RenderPopupMenuMac.h: (WebCore::RenderPopupMenuMac::hidePopup):
11:03 AM Changeset in webkit [22116] by aroben
  • 4 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by Darin, Lou, Adele.

Initial implementation of <select> elements on Windows.

  • WebCore.vcproj/WebCore.vcproj:

Added RenderPopupMenuWin.cpp

  • platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addGroupLabel):
  • rendering/RenderPopupMenuWin.cpp: Added. (WebCore::RenderPopupMenuWin::RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::~RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::clear): (WebCore::RenderPopupMenuWin::populate): (WebCore::RenderPopupMenuWin::showPopup): (WebCore::RenderPopupMenuWin::hidePopup): (WebCore::RenderPopupMenuWin::setPositionAndSize): (WebCore::RenderPopupMenuWin::addOption): (WebCore::RenderPopupMenuWin::down): (WebCore::RenderPopupMenuWin::up): (WebCore::registerPopup): (WebCore::PopupWndProc):
  • rendering/RenderPopupMenuWin.h:

Added useful properties.

(WebCore::RenderPopupMenuWin::popupHandle):
(WebCore::RenderPopupMenuWin::containerHandle):
(WebCore::RenderPopupMenuWin::wasClicked):
(WebCore::RenderPopupMenuWin::setWasClicked):

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): (WebCore::RenderThemeWin::openButtonTheme): (WebCore::RenderThemeWin::openTextFieldTheme): (WebCore::RenderThemeWin::openMenuListTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

Refactored the above methods and added cases for
MenulistAppearance where appropriate.

(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):

Implemented the above methods.

  • rendering/RenderThemeWin.h:
10:44 AM Changeset in webkit [15990] by andersca
  • 10 edits in trunk/JavaScriptCore

2006-08-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Make the bindings compile without CoreFoundation.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_instance.cpp:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
  • bindings/npapi.h:
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createLanguageInstanceForValue):
  • bindings/runtime_root.cpp:
  • bindings/runtime_root.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::createLanguageInstanceForValue):
  • kjs/interpreter.h:
9:18 AM Changeset in webkit [15989] by rwlbuis
  • 1 edit
    4 adds in trunk/WebCore

Reviewed by Anders. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

Note: StringQt.cpp is not part of the original patch, but was
mistakenly omitted from earlier 10467 patch.


7:58 AM Changeset in webkit [15988] by zbujtas
  • 5 edits in S60/trunk/WebKit

2006-08-22 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10515
limit the textarea height so that it can not go beyond
the screen height (it is already done for the width)

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SetHeight): (CFormInputSkin::SizeForCharacterWidth):
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame): (CWebKitFrame::CalcBidiWidth): (CWebKitFrame::FocusedPlugin):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::FocusChanged): (CWebKitView::MaxBidiSize):
12:29 AM Changeset in webkit [15987] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Maciej

Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries

  • WebCore.xcodeproj/project.pbxproj: Reordered some files
  • loader/icon/IconDataCache.cpp: Use the new escapeSQLString() (WebCore::IconDataCache::writeToDatabase):
  • loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout (WebCore::IconDatabase::retainIconURL): (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::imageDataForIconURLQuery): (WebCore::timeStampForIconURLQuery): (WebCore::iconURLForPageURLQuery): (WebCore::forgetPageURLQuery): (WebCore::setIconIDForPageURLQuery): (WebCore::getIconIDForIconURLQuery): (WebCore::addIconForIconURLQuery): (WebCore::hasIconForIconURLQuery):
  • loader/icon/SQLDatabase.h: (WebCore::escapeSQLString): Added

Aug 22, 2006:

11:59 PM Changeset in webkit [15986] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • remove "loading" flag from WebDataSource and code that manages it; it is redundat.
  • Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _startLoading]): (-[WebDataSource isLoading]):
  • WebView/WebDataSourceInternal.h:
11:50 PM Changeset in webkit [15985] by mjs
  • 9 edits
    3 adds in trunk/WebCore

Reviewed by Brady.

  • assorted style cleanup of icon loader code:


  • wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
  • split headers to be one per class, to match impl files
  • made files that are purely local in IconDatabase.cpp static
  • make each impl file include config.h as first header (and no config.h includes in other headers)
  • avoid multiple copies of Vector<unsigned char> for image data
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDataCache.cpp:
  • loader/icon/IconDataCache.h: Added. (WebCore::): (WebCore::IconDataCache::getTimestamp): (WebCore::IconDataCache::setTimestamp): (WebCore::IconDataCache::getIconURL):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::iconForPageURL): (WebCore::pageURLTableIsEmptyQuery): (WebCore::imageDataForIconURLQuery): (WebCore::timeStampForIconURLQuery): (WebCore::iconURLForPageURLQuery): (WebCore::forgetPageURLQuery): (WebCore::setIconIDForPageURLQuery): (WebCore::getIconIDForIconURLQuery): (WebCore::addIconForIconURLQuery): (WebCore::hasIconForIconURLQuery):
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLDatabase.cpp:
  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector):
  • loader/icon/SQLStatement.h: Added. (WebCore::SQLStatement::isPrepared): (WebCore::SQLStatement::prepareAndStep): (WebCore::SQLStatement::lastError): (WebCore::SQLStatement::lastErrorMsg):
  • loader/icon/SQLTransaction.cpp:
  • loader/icon/SQLTransaction.h: Added.
11:05 PM Changeset in webkit [15984] by trey
  • 2 edits in trunk/LayoutTests

Reviewed by NOBODY


This test update was missing from the patch I posted, and ggarren just checked in.

  • fast/overflow/scrollRevealButton-expected.txt:
11:01 PM Changeset in webkit [15983] by beidson
  • 4 edits
    1 move in trunk/WebCore

Reviewed by Maciej

The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
As such, I'm renaming it to IconDataCache.
Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the
TimeStamp when an icon is created or the data is changed.
IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.

  • WebCore.xcodeproj/project.pbxproj: Renamed a file
  • loader/icon/IconDataCache.cpp: Added. (IconDataCache::IconDataCache): (IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data (IconDataCache::manuallySetImageData): Delete the old image and create the new one (IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB (IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version) (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying (WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate (WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write (WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
  • loader/icon/IconDatabase.h: (WebCore::IconDataCache::getTimestamp): (WebCore::IconDataCache::setTimestamp):
  • loader/icon/SiteIcon.cpp: Removed.
10:49 PM Changeset in webkit [15982] by mjs
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • test for <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)


(I both added a WebKit assertion that would fail under this test, and then did a fix to make it not fire)


  • fast/loader/start-load-in-unload-expected.txt: Added.
  • fast/loader/start-load-in-unload.html: Added.

WebKit:

Reviewed by Eric.

<rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)


  • Loader/WebFrameLoader.m: (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad situation occurs.
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent the situation from occuring.
10:37 PM Changeset in webkit [15981] by mjs
  • 5 edits in trunk/LayoutTests

Fix for broken tests.

  • made newly added CGI scripts executable
  • http/tests/navigation/resources/error404.pl:
  • http/tests/navigation/resources/frameset.pl:
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/redirect302.pl:
7:32 PM Changeset in webkit [15980] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/lists

Forgot to check this in in the previous commit.

5:47 PM Changeset in webkit [15979] by justing
  • 4 edits in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing

  • editing/pasteboard/paste-list-001-expected.txt:
  • fast/lists/drag-into-marker.html: Added.
  • fast/lists/drag-into-marker.html-disabled: Removed.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting in a list item.
5:42 PM Changeset in webkit [15978] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Kevin

Added a check in getTIFFRepresentation to not proceed if the frame count is zero
This is an error condition that was handled gracefully before - in certain circumstances
the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
or invalid data. This small change bails out before that call if that call will definitely fail

  • platform/mac/ImageMac.mm: (WebCore::Image::getTIFFRepresentation):
5:23 PM Changeset in webkit [15977] by harrison
  • 2 edits in trunk/WebCore

Backed out my last change (r15966) because it broke lots of layout tests.

  • editing/TextIterator.cpp: (WebCore::TextIterator::advance):
5:09 PM Changeset in webkit [15976] by mjs
  • 19 edits in trunk

WebCore:

Reviewed by Anders.

  • added some SPI indirections to support the following in WebKit/Loader:
    • pull more WebDataSource code into WebFrameLoader
    • make WebMainResourceLoader not depend on WebKit or on SPI
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Anders.


  • pull more WebDataSource code into WebFrameLoader
  • make WebMainResourceLoader not depend on WebKit or on SPI
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _updateIconDatabaseWithURL:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _iconLoaderReceivedPageIcon:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]):
  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • Loader/WebLoader.m: (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setDefersCallbacks:]):
  • Loader/WebMainResourceLoader.h:
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithFrameLoader:]): (-[WebMainResourceLoader dealloc]): (-[WebMainResourceLoader cancelWithError:]): (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:]): (-[WebMainResourceLoader checkContentPolicy]): (-[WebMainResourceLoader didReceiveResponse:]):
  • Plugins/WebPluginContainerCheck.m:
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _cancelledError]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _isDocumentHTML]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebPolicyDelegate.m:
  • WebView/WebPolicyDelegatePrivate.h:
3:59 PM Changeset in webkit [15975] by justing
  • 50 edits in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4052343&4052343&4426622> Mail hung on paste text


Bugs exposed:

  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.checksum:
  • editing/pasteboard/styled-element-markup-expected.png:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/execCommand/insertHTML.html:


Removed some empty style spans, font tags are replaced by style spans
in a couple of cases:

  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/styled-element-markup.html:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4052343&4052343&4426622> Mail hung on paste text


  • editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): (WebCore::isInterchangeConvertedSpaceSpan): (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and remove them and remove style nodes and style spans which were only contributing redundant styles. (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:
3:25 PM Changeset in webkit [15974] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-22 w3liu ​wei.liu@nokia.com

Reviewed by Zalan Bujtas.

WARNING: NO TEST CASES ADDED OR CHANGED

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10514
Thai website www.thairath.com text rendering incorrectly

  • kwq/KWQCharsetData.c:
2:55 PM Changeset in webkit [15973] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-22 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10496
Fix BC break in PluginAdapterInterface.
Remobe obsolete flags.

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::~CControlInputWidget):
  • Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::):
2:05 PM Changeset in webkit [15972] by andersca
  • 8 edits in trunk/JavaScriptCore

2006-08-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Move the npruntime code over to using HashMap and the runtime_root code over to using
HashMap and HashCountedSet.


  • bindings/NP_jsobject.cpp:
  • bindings/c/c_utility.cpp: (KJS::Bindings::identifierFromNPIdentifier):
  • bindings/c/c_utility.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::invoke):
  • bindings/npruntime.cpp: (getStringIdentifierMap): (getIntIdentifierMap): (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier):
  • bindings/runtime_root.cpp: (getReferencesByRootMap): (getReferencesSet): (KJS::Bindings::findReferenceSet): (KJS::Bindings::rootForImp): (KJS::Bindings::rootForInterpreter): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h:
1:59 PM Changeset in webkit [15971] by harrison
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4077676> Inline hole line adheres to the Japanese characters in inline hole

This happens because the underline is always 2 pixels thick, and placed 3 pixels above the bottom of the text box.

Test case added:

  • manual-tests/inline-input-marking.html: Added. Check that underlining of the inline input hole does not obscure the glyphs.


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline): Position underline at bottom of text box. Height of underline is reduced to 1 px when font's descent is less than or equal to 2 px.
1:41 PM Changeset in webkit [22115] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore
1:23 PM Changeset in webkit [15970] by ggaren
  • 3 edits
    107 adds in trunk

LayoutTests:

Reviewed by ggaren.

Introducing a small test suite for bugs related to various navigation techniques,
e.g., back/forward, reload, various redirect flavors, POST, POST-then-redirect,
within-page anchors. Most of the tests are done with and without an enclosing frameset.
The tests verify the content of the final page (which may include restored form
state), scroll location (also sometimes restored), and the full content of the
back-forward list.

  • fast/overflow/scrollRevealButton-expected.txt:

Updated to include scroll location that is now emitted.

  • http/tests/navigation/anchor-basic-expected.txt: Added.
  • http/tests/navigation/anchor-basic.html: Added.
  • http/tests/navigation/anchor-frames-expected.txt: Added.
  • http/tests/navigation/anchor-frames.html: Added.
  • http/tests/navigation/anchor-goback-expected.txt: Added.
  • http/tests/navigation/anchor-goback.html: Added.
  • http/tests/navigation/anchor-subframeload-expected.txt: Added.
  • http/tests/navigation/anchor-subframeload.html: Added.
  • http/tests/navigation/error404-basic-expected.txt: Added.
  • http/tests/navigation/error404-basic.html: Added.
  • http/tests/navigation/error404-frames-expected.txt: Added.
  • http/tests/navigation/error404-frames.html: Added.
  • http/tests/navigation/error404-goback-expected.txt: Added.
  • http/tests/navigation/error404-goback.html: Added.
  • http/tests/navigation/error404-subframeload-expected.txt: Added.
  • http/tests/navigation/error404-subframeload.html: Added.
  • http/tests/navigation/javascriptlink-basic-expected.txt: Added.
  • http/tests/navigation/javascriptlink-basic.html: Added.
  • http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • http/tests/navigation/javascriptlink-frames.html: Added.
  • http/tests/navigation/javascriptlink-goback-expected.txt: Added.
  • http/tests/navigation/javascriptlink-goback.html: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
  • http/tests/navigation/javascriptlink-subframeload.html: Added.
  • http/tests/navigation/metaredirect-basic-expected.txt: Added.
  • http/tests/navigation/metaredirect-basic.html: Added.
  • http/tests/navigation/metaredirect-frames-expected.txt: Added.
  • http/tests/navigation/metaredirect-frames.html: Added.
  • http/tests/navigation/metaredirect-goback-expected.txt: Added.
  • http/tests/navigation/metaredirect-goback.html: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/metaredirect-subframeload.html: Added.
  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html: Added.
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames-goback1.html-disabled: Added.
  • http/tests/navigation/post-frames.html: Added.
  • http/tests/navigation/post-goback1-expected.txt: Added.
  • http/tests/navigation/post-goback1.html: Added.
  • http/tests/navigation/post-goback2-expected.txt: Added.
  • http/tests/navigation/post-goback2.html: Added.
  • http/tests/navigation/postredirect-basic-expected.txt: Added.
  • http/tests/navigation/postredirect-basic.html: Added.
  • http/tests/navigation/postredirect-frames-expected.txt: Added.
  • http/tests/navigation/postredirect-frames-goback1.html-disabled: Added.
  • http/tests/navigation/postredirect-frames.html: Added.
  • http/tests/navigation/postredirect-goback1-expected.txt: Added.
  • http/tests/navigation/postredirect-goback1.html: Added.
  • http/tests/navigation/postredirect-goback2-expected.txt: Added.
  • http/tests/navigation/postredirect-goback2.html: Added.
  • http/tests/navigation/redirect302-basic-expected.txt: Added.
  • http/tests/navigation/redirect302-basic.html: Added.
  • http/tests/navigation/redirect302-frames-expected.txt: Added.
  • http/tests/navigation/redirect302-frames.html: Added.
  • http/tests/navigation/redirect302-goback-expected.txt: Added.
  • http/tests/navigation/redirect302-goback.html: Added.
  • http/tests/navigation/redirect302-subframeload-expected.txt: Added.
  • http/tests/navigation/redirect302-subframeload.html: Added.
  • http/tests/navigation/relativeanchor-basic-expected.txt: Added.
  • http/tests/navigation/relativeanchor-basic.html: Added.
  • http/tests/navigation/relativeanchor-frames-expected.txt: Added.
  • http/tests/navigation/relativeanchor-frames.html: Added.
  • http/tests/navigation/relativeanchor-goback-expected.txt: Added.
  • http/tests/navigation/relativeanchor-goback.html: Added.
  • http/tests/navigation/resources/error404.pl: Added.
  • http/tests/navigation/resources/frameset.pl: Added.
  • http/tests/navigation/resources/javascriptlink.html: Added.
  • http/tests/navigation/resources/metaredirect.html: Added.
  • http/tests/navigation/resources/otherpage.html: Added.
  • http/tests/navigation/resources/postresult.pl: Added.
  • http/tests/navigation/resources/redirect302.pl: Added.
  • http/tests/navigation/resources/slowmetaredirect.html: Added.
  • http/tests/navigation/resources/slowtimerredirect.html: Added.
  • http/tests/navigation/resources/success200.html: Added.
  • http/tests/navigation/resources/testcode.js: Added.
  • http/tests/navigation/resources/timerredirect.html: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowmetaredirect-basic.html: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowtimerredirect-basic.html: Added.
  • http/tests/navigation/success200-basic-expected.txt: Added.
  • http/tests/navigation/success200-basic.html: Added.
  • http/tests/navigation/success200-frames-expected.txt: Added.
  • http/tests/navigation/success200-frames-goback.html-disabled: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame.html: Added.
  • http/tests/navigation/success200-frames-reload.html-disabled: Added.
  • http/tests/navigation/success200-frames.html: Added.
  • http/tests/navigation/success200-goback-expected.txt: Added.
  • http/tests/navigation/success200-goback.html: Added.
  • http/tests/navigation/success200-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-loadsame.html: Added.
  • http/tests/navigation/success200-reload-expected.txt: Added.
  • http/tests/navigation/success200-reload.html: Added.
  • http/tests/navigation/success200-subframeload-expected.txt: Added.
  • http/tests/navigation/success200-subframeload-goback.html-disabled: Added.
  • http/tests/navigation/success200-subframeload.html: Added.
  • http/tests/navigation/timerredirect-basic-expected.txt: Added.
  • http/tests/navigation/timerredirect-basic.html: Added.
  • http/tests/navigation/timerredirect-frames-expected.txt: Added.
  • http/tests/navigation/timerredirect-frames.html: Added.
  • http/tests/navigation/timerredirect-goback-expected.txt: Added.
  • http/tests/navigation/timerredirect-goback.html: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/timerredirect-subframeload.html: Added.

WebKitTools:

Reviewed by ggaren.

Added support for a new set of browser navigation tests. The main feature
is the ability for a test to queue up a set of future actions that will
happen after that first page is loaded. This is used to simulate a sequence
of user actions such as filling out forms, loading additional pages or
going back. In addition we can now dump out the state of the back/forward
list, and the scroll position is dumped if not at 0,0.

  • DumpRenderTree/DumpRenderTree.m: (main): Init new state (compareHistoryItems): New utility to support sorting. (dumpHistoryItem): Write out a WebHistoryItem and kids. (dumpFrameScrollPosition): Write out the scroll position. (dump): Optionally write b/f list or scroll position. (-[WaitUntilDoneDelegate processWork:]): Perform queued work. (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): Kick off any queued actions. Fixed for the case of loads started in a subframe instead of the root frame. (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]): Grab the topmost frame that is being loaded. Do this as early as possible, instead of in didCommitLoadForFrame. (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Noting a load has started now happens in previous method. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Boilerplate (+[LayoutTestController webScriptNameForSelector:]): Boilerplate (-[LayoutTestController notifyDone]): readyToDump var is subsumed by topFrameLoading (-[LayoutTestController dumpBackForwardList]): New impl, just set a bit. (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]): Add new work to the queue. (-[LayoutTestController _doLoad:target:]): Do a queued load. (-[LayoutTestController _doBackOrForwardNav:]): Do a queued back/forward. (-[LayoutTestController scheduleBackNav:]): Ways for scripts to queue actions (-[LayoutTestController scheduleForwardNav:]): (-[LayoutTestController scheduleReload]): (-[LayoutTestController scheduleScript:]): (-[LayoutTestController scheduleLoad:target:]): (runTest): Clear new state for each test. Renamed from "dumpRenderTree" since it's not one of the functions that does any dumping.
12:45 PM Changeset in webkit [15969] by andersca
  • 11 edits in trunk/JavaScriptCore

2006-08-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.


Switch over the NPAPI and Java bindings to using HashMaps instead of dictionaries.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::CClass): (KJS::Bindings::CClass::~CClass): (KJS::Bindings::CClass::classForIsA): (KJS::Bindings::CClass::methodsNamed): (KJS::Bindings::CClass::fieldNamed):
  • bindings/c/c_class.h:
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass): (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField): (KJS::Bindings::): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
11:56 AM Changeset in webkit [15968] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
REPRO: SVG crashes inside gradient code

Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.

11:39 AM Changeset in webkit [22114] by sfalken
  • 14 edits
    6 adds in branches/WindowsMerge

Interface changes/additions in preparation for forms autofill.
Reviewed by Lou Amadio.

10:28 AM Changeset in webkit [15967] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4523606> Represent heading elements in AXAttributedStringForTextMarkerRange

  • bridge/mac/WebCoreAXObject.mm: (headingLevel): (-[WebCoreAXObject headingLevel]): (-[WebCoreAXObject isHeading]): New. Heading level is per the tag (h1 == 1, h2 == 2, etc.)


(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription]):
Add role and roleDescription for headings.


(-[WebCoreAXObject value]):
Value is the headingLevel.


(AXAttributeStringSetHeadingLevel):
(AXAttributedStringAppendText):
Put text's heading level (if applicable) in the attributes.

10:24 AM Changeset in webkit [15966] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

Treat controls as replaced elements, so that AXAttributedStringForTextMarkerRange will, too.


  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Include controls.
5:47 AM Changeset in webkit [15965] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4407336> Some non-text elements return AXTextMarkerRangeForUIElement with equal start and end marker

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRange]): Use 0 and maxDeepOffset(), instead of caretMinOffset() and caretMaxRenderedOffset(). Check for VisiblePositions being equal. If so, adjust end one to its next(). That happens with, e.g., buttons.
4:13 AM Changeset in webkit [15964] by rwlbuis
  • 28 edits
    2 deletes in trunk/WebCore

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10491
KCanvasMatrix removal

Remove KCanvasMatrix from project, using AffineTransform instead.

1:20 AM Changeset in webkit [15963] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
REPRO: SVG Maze crashes in RenderPath code

Do not render a path when it is empty so maze15.svg does not crash anymore.
Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.

12:22 AM Changeset in webkit [15962] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Brady.


  • move more code from WebDataSource to WebFrameLoader


Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
use any of WebDataSource's private data.

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader _finishedLoading]):
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]): (-[WebMainResourceLoader didFinishLoading]):
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): (-[WebSubresourceLoader signalFinish]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]):
  • WebView/WebDataSource.m: (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _cancelledError]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _isDocumentHTML]):
  • WebView/WebDataSourceInternal.h:
12:08 AM Changeset in webkit [15961] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Maciej

<rdar://4690949> - New IconDB: Need to prune unretained icons on startup

Added a flag to track whether or not the initial pruning has taken place on startup
If that flag is not set, IconURL retain counts will be tracked in a temporary db table
in addition to the in-memory hash. Then when the timer fires after initial retains
are complete, we prune those icons not in the retain table, prune dangling PageURL
references, delete the temporary table, and set the flag - and carry on as normal

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): initialize the flag (WebCore::IconDatabase::open): changed the schema of the temporary table (WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up (WebCore::IconDatabase::releaseIconURL): ditto (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then wipe all the PageURLs who no longer point to a valid IconURL
  • loader/icon/IconDatabase.h:

Aug 21, 2006:

9:32 PM Changeset in webkit [15960] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
XSLTProcessor transformToFragment fails because of an XML declaration

Test: fast/xsl/transformToFragment-XML-declaration.html

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.
5:51 PM Changeset in webkit [15959] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

Added support for the NSAccessibilityMisspelledTextAttribute.


Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: Lots of trivial formatting in many methods.


(-[WebCoreAXObject accessibilityAttributeValue:]):
Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
attribute.

(WebCore::AXAttributeStringSetSpelling):
New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.

(-[WebCoreAXObject AXAttributedStringAppendText:]):
Added call to AXAttributeStringSetSpelling.


  • editing/visible_units.cpp: (WebCore::startOfDocument): (WebCore::endOfDocument): Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*, so a previously existing VisiblePosition is not required.


  • editing/visible_units.h: Declare new forms of startOfDocument and endOfDocument.
5:16 PM Changeset in webkit [15958] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

Bug 9302: WebKit nightly download image says ~2.5 MB when
universal binaries make it ~5.0 MB
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9302


  • images/download.png:
4:35 PM Changeset in webkit [15957] by thatcher
  • 22 edits in trunk/WebKitSite

Stamped by Maciej.


Changes many opendarwin.org links to the proper webkit.org version.

  • blog/wp-content/themes/webkit/sidebar.php:
  • blog/wp-content/themes/webkit/style.css:
  • building/build.html:
  • coding/contributing.html:
  • contact.html:
  • index.html:
  • nav.inc:
  • projects/compat/hitlist.html:
  • projects/css/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/javascript/index.html:
  • projects/svg/index.html:
  • projects/svg/svg-status.xsl:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugzilla.html:
  • quality/leakhunting.html:
  • quality/lifecycle.html:
  • quality/reporting.html:
4:26 PM Changeset in webkit [15956] by weinig
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Eric.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • platform/qt/TemporaryLinkStubs.cpp: Added. (JavaAppletWidget::JavaAppletWidget): (Font::selectionRectForComplexText): (Font::offsetForPositionForComplexText): (WebCore::refreshPlugins): (WebCore::focusRingColor): (Image::drawTiled): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Slider::Slider): (WebCore::Slider::sizeHint): (WebCore::Slider::~Slider): (WebCore::Slider::setValue): (WebCore::Slider::setMaxValue): (WebCore::Slider::setMinValue): (WebCore::Slider::setFont): (WebCore::Slider::value): (WebCore::Slider::focusPolicy): (WebCore::ScrollBar::ScrollBar): (WebCore::ScrollBar::setSteps): (WebCore::ScrollBar::scroll): (WebCore::ScrollBar::setValue): (WebCore::ScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::ServeSynchronousRequest): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (Frame::setNeedsReapplyStyles): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::setFocusRingColorChangeFunction): (FrameView::updateBorder): (loadResourceIntoArray): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (FileButton::FileButton): (FileButton::click): (FileButton::sizeForCharacterWidth): (FileButton::focusPolicy): (FileButton::frameGeometry): (FileButton::setFilename): (FileButton::baselinePosition): (FileButton::setFrameGeometry): (FileButton::setDisabled): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
4:15 PM Changeset in webkit [15955] by weinig
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Maciej.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • platform/qt/CursorQt.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::Cursors::Cursors::self): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • platform/qt/RenderThemeQt.cpp: Added. (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::supportsHover): (WebCore::RenderThemeQt::paintCheckbox): (WebCore::RenderThemeQt::paintRadio): (WebCore::theme): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::controlSupportsTints): (WebCore::RenderThemeQt::systemFont): (WebCore::RenderThemeQt::createPopupMenu): (WebCore::RenderThemeQt::addIntrinsicMargins): (WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo): (WebCore::RenderThemeQt::setCheckboxSize): (WebCore::RenderThemeQt::setRadioSize): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::applyTheme): (WebCore::RenderThemeQt::adjustButtonStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::paintTextField):
4:04 PM Changeset in webkit [15954] by weinig
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Maciej.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

  • platform/qt/SharedTimerQt.cpp: Added. (WebCore:setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/qt/SharedTimerQt.h: Added. (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::~SharedTimerQt): (WebCore::SharedTimerQt::inst): (WebCore::SharedTimerQt::fire):
  • platform/qt/SystemTimeQt.cpp: Added. (WebCore::currentTime):
2:05 PM Changeset in webkit [15953] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by John

-Defers writing to the database via a timer and handles starting the timer

intelligently

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Don't start the update timer by default (WebCore::IconDatabase::close): Call syncDatabase() (WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase() (WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call (WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): (WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase() (WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John

Quick ICONDEBUG flag fix

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):
10:43 AM Changeset in webkit [15952] by ap
  • 5 edits
    3 adds in trunk

2006-08-21 Vladimir Olexa <​vladimir.olexa@gmail.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6252
JavaScript 1.6 Array.lastIndexOf

Test: fast/js/array-lastIndexOf.html

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added a LastIndexOf case.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Added LastIndexOf to enum.
  • tests/mozilla/expected.html: Two more tests now pass.
9:55 AM Changeset in webkit [15951] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Eric.

Test: fast/js/xslt-fragment-in-empty-doc.html

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.
1:55 AM Changeset in webkit [15950] by beidson
  • 4 edits in trunk/WebKit

Reviewed by Anders

-Renamed an internal only method for clarity
-Tweaked WebDataSource for notification purposes with the new expiring icons
-Fixed a bug with the ICONDEBUG flag

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed (-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
  • Misc/WebIconDatabasePrivate.h:
  • WebView/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _notifyIconChanged:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _iconLoaderReceivedPageIcon:]):
1:55 AM Changeset in webkit [15949] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Anders

-Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately

In the near future, we'll also have timer-based deferred *addition* of database records

-Keep retain/release counts in a hash instead of a DB table
-Keep only one hash record for the SiteIcons
-Renamed some methods for clarity

  • bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Added new timer setup (WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons (WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash (WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion (WebCore::IconDatabase::retainIconURL): Added (WebCore::IconDatabase::releaseIconURL): Added (WebCore::IconDatabase::forgetPageURL): Added (WebCore::IconDatabase::isIconURLRetained): New and improved simplicity (WebCore::IconDatabase::setIconDataForIconURL): Cleanup (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed (WebCore::IconDatabase::pruneIconsPendingDeletion): Added (WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
  • loader/icon/IconDatabase.h: Added multiple stuffs
12:51 AM Changeset in webkit [15948] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej's rubberstamp

Removed stale file references from the Xcode.proj

  • WebCore.xcodeproj/project.pbxproj:

Aug 20, 2006:

5:01 PM Changeset in webkit [15947] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • pull a bit of WebDataSource code into WebFrameLoader
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _handleFallbackContent]): (+[WebFrameLoader _canShowMIMEType:]): (+[WebFrameLoader _representationExistsForURLScheme:]): (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
  • WebView/WebDataSource.m:
  • WebView/WebDataSourceInternal.h:
3:27 PM Changeset in webkit [15946] by rwlbuis
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing obsolete QConstString/QString constructors in kjs code.

WebCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing HelperQt.h usage by creating appropriate operators
constructor in some of the platform classes, as suggested by Darin.

Aug 18, 2006:

10:35 PM Changeset in webkit [15945] by sfalken
  • 2 edits in trunk/WebCore

2006-08-18 Steve Falkenburg <​sfalken@apple.com>

Rubber stamped by adele.


Fix call to WebFormDelegate's textFieldDidBeginEditing.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged):


4:26 PM Changeset in webkit [15944] by rwlbuis
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

WebKit should have Qt platform support

4:20 PM Changeset in webkit [15943] by rwlbuis
  • 1 edit
    7 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:47 PM Changeset in webkit [15942] by rwlbuis
  • 1 edit
    6 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:34 PM Changeset in webkit [22113] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): Another attempt at fixing the build. Make these two functions into instance methods of PluginViewWin.
3:27 PM Changeset in webkit [22112] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::write): (WebCore::destroyStream):
  • plugins/win/PluginViewWin.h: Fix build by removing unneeded parameters.
3:16 PM Changeset in webkit [15941] by rwlbuis
  • 7 adds in trunk/WebCore/platform/qt

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:08 PM Changeset in webkit [22111] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

Have the NPN functions call into the plugin view. Implement some of the plugin view methods.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::setCurrentPluginView): (WebCore::PluginViewWin::currentPluginView): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL): (WebCore::PluginViewWin::newStream): (WebCore::write): (WebCore::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::status): (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::setValue): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp: (pluginViewForInstance): (NPN_ReloadPlugins): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_GetValue): (NPN_SetValue):
12:33 PM Changeset in webkit [15940] by rwlbuis
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/UnicodeDirection.h

I hope I got this finally right, learning all the time :|

12:26 PM Changeset in webkit [15939] by rwlbuis
  • 3 edits in trunk/JavaScriptCore/wtf/unicode

Accidently doubly applied patch for:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
Sorry for any inconvenience!

12:11 PM Changeset in webkit [15938] by rwlbuis
  • 1 edit
    17 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
The Qt platform needs a KCanvas device.

11:53 AM Changeset in webkit [15937] by rwlbuis
  • 3 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WTF Changes needed for Qt platform code.

11:27 AM Changeset in webkit [22110] by andersca
  • 7 edits
    4 adds in branches/WindowsMerge/WebCore

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Steve and Maciej.

Add initial implementation of plugin view.

  • WebCore.vcproj/WebCore.vcproj: Add files.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::objectContentType): (WebCore::FrameWin::createPlugin): Implement these functions.


  • platform/win/TemporaryLinkStubs.cpp: Remove implemented functions.


  • platform/win/WidgetWin.cpp: Add this file from the open source repo (WebCore::Widget::~Widget): Call DestroyWindow on the hWnd.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): New function which creates a plugin view.


  • plugins/win/PluginDatabaseWin.h:


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Assign the browser functions. They are just stubs for now.


  • plugins/win/PluginViewWin.cpp: Added. (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::invokeSetWindow): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::createUTF8StringArray): (WebCore::freeStringArray): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: Added. (WebCore::PluginViewWin::plugin): (WebCore::PluginViewWin::instance):
  • plugins/win/npapi.cpp: Added. (NPN_MemAlloc): (NPN_MemFree): (NPN_MemFlush): (NPN_ReloadPlugins): (NPN_RequestRead): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): (NPN_GetValue): (NPN_SetValue): (NPN_GetJavaEnv): (NPN_GetJavaPeer):
9:23 AM Changeset in webkit [15936] by brmorris
  • 2 edits in S60/trunk/group

2006-08-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by me.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10484

  • Distribution.Policy.S60: Set to 0
6:03 AM Changeset in webkit [15935] by rwlbuis
  • 3 edits
    1 add in trunk

Fixing my mistakes with landing of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466

4:58 AM Changeset in webkit [15934] by rwlbuis
  • 1 add in trunk/CMakeLists.txt

I forgot to commit this as part of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464

4:45 AM Changeset in webkit [15933] by rwlbuis
  • 20 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
WebKit should have Qt platform support.

4:21 AM Changeset in webkit [15932] by rwlbuis
  • 10 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
General WebKit Linux build fixes.

4:04 AM Changeset in webkit [15931] by rwlbuis
  • 2 edits
    2 adds in trunk

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
Offer a cmake build system for Qt platform.

Aug 17, 2006:

4:05 PM Changeset in webkit [15930] by harrison
  • 6 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons

Accessorized RenderMenuList objects.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject mouseButtonListener]): Trivial formatting.


(-[WebCoreAXObject actionElement]):
Return the HTMLSelectElement.


(-[WebCoreAXObject firstChild]):
(-[WebCoreAXObject lastChild]):
(-[WebCoreAXObject previousSibling]):
(-[WebCoreAXObject nextSibling]):
(-[WebCoreAXObject parentObject]):
(-[WebCoreAXObject parentObjectUnignored]):
(-[WebCoreAXObject isAttachment]):
(-[WebCoreAXObject attachmentView]):
Trivial formatting.

(-[WebCoreAXObject role]):
Return NSAccessibilityPopUpButtonRole.

(-[WebCoreAXObject subrole]):
Trivial formatting.


(-[WebCoreAXObject roleDescription]):
Return NSAccessibilityPopUpButtonRole.


(-[WebCoreAXObject textUnderElement]):
Trivial formatting.

(-[WebCoreAXObject value]):
Return the RenderMenuList::text().


(-[WebCoreAXObject position]):

Trivial formatting.

(-[WebCoreAXObject accessibilityIsIgnored]):

  • Ignore popup menu items because AppKit does.
  • Remove redundant check for buttonTag (earlier isControl() check suffices).


(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityActionNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Trivial formatting.


(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
Removed old debugging code that is no longer needed.
Trivial formatting.


(-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject removeAXObjectID]):
Trivial formatting.


  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Call click() instead of focus().


  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text): Added for easy access to popup's current text.


  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::isMenuList):
  • rendering/RenderObject.h: (WebCore::RenderObject::isMenuList): Added so popups can be identified.
3:23 PM Changeset in webkit [15929] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit

  • WebKit.LP64.exp:
2:13 PM Changeset in webkit [22109] by andersca
  • 5 edits
    8 adds in branches/WindowsMerge

WebCoreWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

Add initial implementation of plugin database.


  • WebCore.vcproj/WebCore.vcproj: Add new files.


  • platform/win/TemporaryLinkStubs.cpp: Get rid of the PlugInInfoStore stubs.
  • plugins/win/PlugInInfoStoreWin.cpp: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins):
  • plugins/win/PluginDatabaseWin.cpp: Added. (WebCore::PluginDatabaseWin::installedPlugins): (WebCore::PluginDatabaseWin::refresh): (WebCore::PluginDatabaseWin::plugins): (WebCore::PluginDatabaseWin::getPluginsInPaths): (WebCore::PluginDatabaseWin::defaultPluginPaths): (WebCore::PluginDatabaseWin::isMIMETypeRegistered): (WebCore::PluginDatabaseWin::pluginForMIMEType): (WebCore::PluginDatabaseWin::pluginForExtension):
  • plugins/win/PluginDatabaseWin.h: Added. (WebCore::PluginDatabaseWin::setPluginPaths):
  • plugins/win/PluginPackageWin.cpp: Added. (WebCore::PluginPackageWin::~PluginPackageWin): (WebCore::getVersionInfo): (WebCore::splitString): (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::fetchInfo): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown): (WebCore::PluginPackageWin::createPackage): (WebCore::PluginPackageWin::hash): (WebCore::PluginPackageWin::equal):
  • plugins/win/PluginPackageWin.h: Added. (WebCore::PluginPackageWin::name): (WebCore::PluginPackageWin::description): (WebCore::PluginPackageWin::fileName): (WebCore::PluginPackageWin::mimeToDescriptions): (WebCore::PluginPackageWin::mimeToExtensions): (WebCore::PluginPackageWin::pluginFuncs): (WebCore::PluginPackageWinHash::hash): (WebCore::PluginPackageWinHash::equal): (WTF::):
  • plugins/win/npfunctions.h: Added.

WebKitWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

  • WebKit.vcproj/WebKit.vcproj: Add version.lib
1:37 PM Changeset in webkit [15928] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-08-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • bindings/npapi.h: Fix ifdef.
1:06 PM Changeset in webkit [15927] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::visiblePositionForTextMarker): Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
12:58 PM Changeset in webkit [15926] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
<rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])

Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
Set the _private->closed flag at the beginning of _close to prevent reentry.
Set the host window and all the delegates to nil in _close.

  • WebView/WebView.m: (-[WebView _close]):
7:55 AM Changeset in webkit [15925] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-16 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10325
There is no data supplier provided for external links in LoadPage, so the data is not
loaded. Also, client "leaves" are not handled from ResolveLinkL in the BufferTransaction's
DoSubmit.function. Cleaned up the indentation

  • BrowserView/src/WebKitLoader.cpp: (CWebKitOOMStopper::Priority): (CWebKitLoader::ConstructL): (CWebKitLoader::NewL): (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleResolveComplete): (CBufferTransaction::HandleNextDataChunk): (CBufferTransaction::HandleNextDataChunkL): (CBufferTransaction::HandleClientDataChunkL):

Aug 16, 2006:

11:37 PM Changeset in webkit [22108] by aroben
  • 1 edit
    1 delete in branches/WindowsMerge/WebCore

Removing this unintentionally added file.

11:33 PM Changeset in webkit [22107] by aroben
  • 2 edits
    3 adds in branches/WindowsMerge/WebCore

Reviewed by Steve.

Branching files from OpenSource tree r15924 to prepare for <select>
element implementation.

  • WebCore.vcproj/WebCore.vcproj:
  • rendering/RenderPopupMenuWin.h: Added. (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme): (WebCore::m_textFieldTheme): (WebCore::RenderThemeWin::~RenderThemeWin): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeWin::addIntrinsicMargins): (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::prepareForDrawing): (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::setCheckboxSize): (WebCore::RenderThemeWin::setRadioSize): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::paintTextArea): (WebCore::RenderThemeWin::createPopupMenu):
  • rendering/RenderThemeWin.h: Added. (WebCore::ThemeData::m_state): (WebCore::RenderThemeWin::supportsHover): (WebCore::RenderThemeWin::paintCheckbox): (WebCore::RenderThemeWin::paintRadio):
3:59 PM Changeset in webkit [15924] by justing
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by thatcher

Equivalent render tree:

  • fast/events/ondragenter-expected.checksum:
  • fast/events/ondragenter-expected.txt:


Patch exposed a bug (10449):

  • fast/lists/drag-into-marker.html: Removed.
  • fast/lists/drag-into-marker.html-disabled: Added.
3:34 PM Changeset in webkit [15923] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Anders. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10447
AffineTransform should be multi-platform compatible

3:07 PM Changeset in webkit [15922] by hyatt
  • 2 edits in trunk/WebCore

Fix an issue with CSS2 system fonts where they did not respect text
zoom. This was most visible with the new control fonts used for form
controls (they stopped swapping between small/mini/regular as you zoomed).

Reviewed by beth

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
2:58 PM Changeset in webkit [15921] by thatcher
  • 1 copy in tags/WebKit-418.9/WebKit

Tag for WebKit 418.9 (part 2 of 2.)

2:58 PM Changeset in webkit [15920] by thatcher
  • 1 add in tags/WebKit-418.9

Tag for WebKit 418.9 (part 1 of 2.)

2:57 PM Changeset in webkit [15919] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:17 PM Changeset in webkit [15918] by justing
  • 114 edits
    8 adds in trunk

LayoutTests:

Reviewed by thatcher


Added:

  • editing/pasteboard/interchange-newline-4-expected.checksum: Added.
  • editing/pasteboard/interchange-newline-4-expected.png: Added.
  • editing/pasteboard/interchange-newline-4-expected.txt: Added.
  • editing/pasteboard/interchange-newline-4.html: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.txt: Added.
  • editing/deleting/paragraph-in-preserveNewline.html: Added.


Equivalent render trees, fixes, or bugs exposed (10427, 10428):

  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.checksum:
  • editing/inserting/insert-3786362-fix-expected.png:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3786362-fix.html:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/3976872-expected.checksum:
  • editing/pasteboard/3976872-expected.png:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-3-expected.checksum:
  • editing/pasteboard/4076267-3-expected.png:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-3.html:
  • editing/pasteboard/4076267-expected.checksum:
  • editing/pasteboard/4076267-expected.png:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/4076267.html:
  • editing/pasteboard/4242293-1-expected.txt:
  • editing/pasteboard/4242293-expected.checksum:
  • editing/pasteboard/4242293-expected.png:
  • editing/pasteboard/4242293-expected.txt:
  • editing/pasteboard/4631972-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/copy-paste-bidi-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.checksum:
  • editing/pasteboard/display-block-on-spans-expected.png:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/merge-end-1-expected.checksum:
  • editing/pasteboard/merge-end-1-expected.png:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.checksum:
  • editing/pasteboard/merge-end-2-expected.png:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-2.html:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.checksum:
  • editing/pasteboard/merge-end-table-expected.png:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-002-expected.txt:
  • editing/pasteboard/paste-line-endings-004-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-007-expected.checksum:
  • editing/pasteboard/paste-text-007-expected.png:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-013-expected.checksum:
  • editing/pasteboard/paste-text-013-expected.png:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/paste-text-019.html:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/pasting-object-expected.txt:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • editing/pasteboard/undoable-fragment-removes-expected.png:
  • editing/pasteboard/undoable-fragment-removes-expected.txt:
  • editing/pasteboard/undoable-fragment-removes.html:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher


First part of fix for:
<rdar://problem/4384589>
Mail hung on paste text


Fixes:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
Extra line left after deleting whitespace:pre text
<rdar://problem/4128080> Paste as HTML does not yield equivalent style
<rdar://problem/4046469> Box styles on first element aren't copied/pasted
Copy/paste of arstechnica.com


Here's how we avoid adding redundant style information on paste: insert
the fragment and do a test rendering, save away style information for
every node in the fragment, remove all style information from the fragment,
remove the fragment, insert it into the appropriate place in the document,
then restore only those styles gathered during the test insertion that aren't
redundant. Restoring the styles in this way results in an ApplyStyleCommand
and a layout for nearly every inserted node.
Instead we want to insert the fragment into the document without removing the
style information, then mark style nodes and inline style declarations for
removal if they are redundant, and sweep to remove them. This means that we
can't rely on ReplacementFragment::wasBlock anymore, because blocks will now
have style spans around them. This patch removes the use of wasBlock in
ReplaceSelectionCommand.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Added code to remove the line placeholder left after a move from preserveNewline text.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if we're deleting a paragraph in preserveNewline text.
  • editing/JSEditor.cpp: Pass true to prevent nesting.
  • editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends. (WebCore::ReplacementFragment::ReplacementFragment): Ditto. (WebCore::ReplacementFragment::saveRenderingInfo): Ditto. (WebCore::RenderingInfo::RenderingInfo): Ditto. (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from merging rules into one method. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): (WebCore::ReplaceSelectionCommand::shouldMerge): (WebCore::ReplaceSelectionCommand::doApply): Don't do nesting prevention when pasting into an empty paragraph, this fixes 4046469, the common cause of paste fidelity bugs, but needs to be tweaked a little because this can lead to margin/border build-up on repeated copy/pastes. Don't track startPos in addition to insertionPos. It was never used. Fixed a bug where a fragment starting with an interchange newline would cause content to be put outside of an editable region when pasting at the very end of it. Adjust insertionPos before insertion (not during) and do not consult wasBlock to decide whether or not to do so. Changed the way we do the start merge: insert the fragment, then stich paragraphs together, in the same way that we do the end merge. This doesn't require wasBlock and fixes bugs. Replaced some uses of insertionPos with endOfInsertedContent. Fixed a bug in the expansion of the last incoming br (a "collapsed" br is one where !isStartOfParagraph([br,0])). Removed the special case code that did the end merge for the preserveNewline case, since this patch fixes the moveParagraph bug in the preserveNewline case. Removed some unused variables. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was holding a line open should always be displaced by inserted content, unless the inserted content ends with a br. (WebCore::ReplaceSelectionCommand::updateNodesInserted):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::style):
  • editing/markup.cpp: (WebCore::createMarkup): Only add mail blockquotes and list/table/pre when annotate is true (when we're creating markup for the pasteboard).
12:31 PM Changeset in webkit [15917] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk31

Branching for release S60 RnD release 2006 w33

12:08 PM Changeset in webkit [15916] by brmorris
  • 2 edits in S60/trunk

2006-08-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10330


  • build.bat: Remove support for SDK MR until binary

compatability in S60Internals reached.

12:06 PM Changeset in webkit [15915] by brmorris
  • 2 edits in S60/trunk

2006-08-15 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10421

  • runATF.bat: prettify layout test results.
11:56 AM Changeset in webkit [15914] by hyatt
  • 2 edits in trunk/WebCore

Fix Win32 build bustage.

11:31 AM Changeset in webkit [15913] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-16 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10433

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructSecretEditorL):
11:31 AM Changeset in webkit [15912] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4637156> underlines appearing in white selection text
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations): bail out if phase is PaintPhaseSelection and forceWhiteText is true
11:08 AM Changeset in webkit [15911] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-16 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10434
Req. Dedicated folder for downloaded content

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
11:03 AM Changeset in webkit [15910] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John

Updated the DB version number and added a helpful comment explaining its meaning

  • loader/icon/IconDatabase.cpp:
10:43 AM Changeset in webkit [15909] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-16 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10432
Rearrange the initialization list, and remove unnecessary #includes
so PC-Lint will compile without errors.

  • BrowserView/inc/SmartLinkMap.h:
  • BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::CSmartLinkHandler):
1:16 AM Changeset in webkit [15908] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Maciej

  • Misc/WebIconDatabase.m: Pruned unused method
  • Misc/WebIconDatabasePrivate.h: Ditto
1:16 AM Changeset in webkit [15907] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Maciej

Major refactoring of new iconDB:
-Instead of private browsing being handled by in-memory tables, it's now handled

by a separate in-memory database with the same table names. This allows us to
re-use the same SQL on either the main or private-browsing database

-So it follows, I broke out much of the SQL queries into seperate methods suffixed with

"Query" that take a database as the method's argument so the same language can run on
both private and main tables

-Now that we have two DBs, moved the retain/release count to the m_mainDB
-While I was at it, updated the schema to combine the Icon and IconResource table - cuts

down on some high-usage, low value queries which were too expensive

-Ditched the _url -> url convention for escaping urls for SQL. Now its url and escapedURL
-Pruned tons of unused methods from previous revisions

  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used
    • bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
    • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Updated initializer list (WebCore::IconDatabase::open): Sets up both databases (WebCore::IconDatabase::close): Closes both databases (WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record (WebCore::IconDatabase::isValidDatabase): Reflect the updated schema (WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter (WebCore::IconDatabase::createDatabaseTables): Ditto (WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function (WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables (WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB (WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB (WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler (WebCore::IconDatabase::setIconDataForIconURL): Style cleanup (WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto (WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function (WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup (WebCore::IconDatabase::pruneUnreferencedIcons): DB name change (WebCore::IconDatabase::pruneUnretainedIcons): Ditto (WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function (WebCore::IconDatabase::~IconDatabase): (WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query (WebCore::imageDataForIconURLQuery): Self-explanatory SQL query (WebCore::timeStampForIconURLQuery): Self-explanatory SQL query (WebCore::iconURLForPageURLQuery): Self-explanatory SQL query (WebCore::forgetPageURLQuery): Self-explanatory SQL query (WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query (WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query (WebCore::addIconForIconURLQuery): Self-explanatory SQL query (WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
  • loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments

(WebCore::IconDatabase::isOpen): Changed our meaning of "isOpen" to reflect the 2 databases

Aug 15, 2006:

10:19 PM Changeset in webkit [15906] by sfalken
  • 3 edits in trunk/JavaScriptCore

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by mjs.


Build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • wtf/Assertions.h:
9:22 PM Changeset in webkit [15905] by darin
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/objc-keyboard-event-creation-expected.txt: Added.
  • fast/events/objc-keyboard-event-creation.html: Added.

WebCore:

Reviewed by Darin.

  • bindings/objc/DOMEvents.mm: (-[DOMKeyboardEvent initKeyboardEvent::::::::::]):
  • bindings/objc/DOMEventsNonstandard.mm: (-[DOMWheelEvent initWheelEvent:::::::::::]):
  • bindings/objc/DOMPrivate.h:
  • added an initializer for the WheelEvent
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h:

WebKitTools:

Reviewed by Darin.

  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController fireKeyboardEventsToElement:]):
9:18 PM Changeset in webkit [22106] by sfalken
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Pull TemporaryLinkStubs.cpp into internal tree to fix the build.

9:11 PM Changeset in webkit [22105] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Fix the build with TOT.

  • WebCore.vcproj/WebCore.vcproj:
8:53 PM Changeset in webkit [15904] by darin
  • 4 edits in trunk/WebKitTools

Reviewed and tweaked by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add setAcceptsEditing: to the list of methods. (+[LayoutTestController webScriptNameForSelector:]): Use the name setAcceptsEditing, without the colon, for the JavaScript name. (-[LayoutTestController setAcceptsEditing:]): Added. Calls through to the editing delegate. (dumpRenderTree): Set the acceptsEditing flag to YES before each test.
  • DumpRenderTree/EditingDelegate.h: Added an "acceptsEditing" flag and getter and setter methods to the class.
  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate init]): Initialize acceptsEditing to YES. (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): Instead of always returning YES, return the value of acceptsEditing. (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): Ditto. (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): Ditto. (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): Ditto. (-[EditingDelegate webView:shouldDeleteDOMRange:]): Ditto. (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): Ditto. (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): Ditto. (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Ditto. (-[EditingDelegate setAcceptsEditing:]): Added.
8:53 PM Changeset in webkit [15903] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Adele (preliminary version) and later by Kevin.


  • remove most WebKit dependencies from WebMainResourceLoader.
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader cannotShowMIMETypeForURL:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (+[WebFrameLoader _canShowMIMEType:]): (+[WebFrameLoader _representationExistsForURLScheme:]): (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
  • Loader/WebMainResourceLoader.h:
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader interruptForPolicyChangeError]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (isCaseInsensitiveEqual): (shouldLoadAsEmptyDocument): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader didReceiveResponse:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]): (-[WebMainResourceLoader didFinishLoading]): (-[WebMainResourceLoader loadWithRequestNow:]): (-[WebMainResourceLoader loadWithRequest:]):
6:25 PM Changeset in webkit [22104] by sfalken
  • 4 edits in branches/WindowsMerge/WebCore

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Get this building.

  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
6:24 PM Changeset in webkit [15902] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Kevin Decker.

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Fixed a subtle problem with the 64-bit debug build -- as written, this would LOG() on 64-bit and do nothing on 32-bit!
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase _scanForNewPlugins]): Use +[NSMutableSet set] here.
6:23 PM Changeset in webkit [22103] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Fix this to build in my tree.

  • WebFrame.cpp: (WebFrame::textFieldDidBeginEditing): (WebFrame::doTextFieldCommandFromEvent): (WebFrame::textWillBeDeletedInTextField):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:
5:37 PM Changeset in webkit [15901] by thatcher
  • 1 copy in tags/WebCore-315.14.6/WebCore

Tag for WebCore 315.14.6 (part 2 of 2.)

5:37 PM Changeset in webkit [15900] by thatcher
  • 1 add in tags/WebCore-315.14.6

Tag for WebCore 315.14.6 (part 1 of 2.)

5:37 PM Changeset in webkit [15899] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

5:24 PM Changeset in webkit [15898] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-08-15 Geoffrey Garen <​ggaren@apple.com>

Merged fix from TOT to Safari-2-0-branch


This fixes <rdar://problem/4661982> (crash in KHTMLParser::popBlock).


  • This patch reworks a previous fix for <rdar://problem/3524912> repro crash in KHTMLParser::parseToken, due to parser's current element being destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix leaks.


The previous solutions caused a ~2% performance regression on iBench HTML,
due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
for a total win of ~3% vs current TOT.


The solution here is:
(1) Don't let the parser ref document nodes -- that causes leaks.
(2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when
moving a node between stacks or to/from 'current', rather than deref'ing
and then ref'ing again, simply move the node, along with its refcount, to
its new location, and overwrite its old location.


  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::setCurrent): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::popOneBlock): (WebCore::HTMLParser::moveOneBlockToStack):
  • html/HTMLParser.h:
4:51 PM Changeset in webkit [15897] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Build fix: DWARF and -gfull are incompatible with symbol separation.

JavaScriptGlue:

Reviewed by Tim H.

Build fix: DWARF and -gfull are incompatible with symbol separation.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Tim H.

Build fix: DWARF and -gfull are incompatible with symbol separation.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin Adler.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)


  • Plugins/WebPluginDatabase.h:
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit. (-[WebPluginDatabase plugins]): 'plugins' is now a dictionary. (-[WebPluginDatabase close]): Call new -_removePlugin: method. (-[WebPluginDatabase refresh]): Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins. (-[WebPluginDatabase _plugInPaths]): No changes; just moved in file. (-[WebPluginDatabase _addPlugin:]): New method. Refactored from -refresh. Adds a plug-in to the database. (-[WebPluginDatabase _removePlugin:]): New method. Refactored from -refresh. Remove a plug-in from the database. (-[WebPluginDatabase _scanForNewPlugins]): New method. Refactored from -refresh. Returns the list of plug-in packages on disk. (-[WebPluginDatabase _applicationWillTerminate]): New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are removed from the DB (and unloaded if necessary).
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This avoids some stat()s and allocations during the plug-in refresh process. (-[WebBasePluginPackage isLoaded]): Removed. (-[WebBasePluginPackage load]): Base class for plug-in packages now always loads "successfully". (-[WebBasePluginPackage dealloc]): Removed this assertion. The base plug-in package class has no concept of "unloading". (-[WebBasePluginPackage finalize]): ditto. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in packages can be "unloaded".
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Combined old -unload and -unloadWithoutShutdown methods into this new one. (-[WebNetscapePluginPackage initWithPath:]): Call new unload method. (-[WebNetscapePluginPackage load]): ditto (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]): ditto (-[WebNetscapePluginPackage open]): New method. Called when a plug-in instance starts running. (-[WebNetscapePluginPackage close]): New method. Called when a plug-in instance stops running. When all plug-in instances close the plug-in package, and the plug-in package is removed from the database, the plug-in is unloaded.
  • Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]): Made this a bit more efficient by checking if the bundle is already loaded. (-[WebBasePluginPackage unload]): Removed. (-[WebBasePluginPackage isLoaded]): Removed.
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Open the plug-in package so it remains loaded while this instance uses it. (-[WebBaseNetscapePluginView stop]): Close the plug-in package when the plug-in instance is stopped.


  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have been stopped, and a Netscape plug-in instance will stop its streams when it is stopped. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
4:38 PM Changeset in webkit [15896] by tomernic
  • 10 edits in trunk/WebKit

Reviewed by Darin Adler.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)


  • Plugins/WebPluginDatabase.h:
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit. (-[WebPluginDatabase plugins]): 'plugins' is now a dictionary. (-[WebPluginDatabase close]): Call new -_removePlugin: method. (-[WebPluginDatabase refresh]): Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins. (-[WebPluginDatabase _plugInPaths]): No changes; just moved in file. (-[WebPluginDatabase _addPlugin:]): New method. Refactored from -refresh. Adds a plug-in to the database. (-[WebPluginDatabase _removePlugin:]): New method. Refactored from -refresh. Remove a plug-in from the database. (-[WebPluginDatabase _scanForNewPlugins]): New method. Refactored from -refresh. Returns the list of plug-in packages on disk. (-[WebPluginDatabase _applicationWillTerminate]): New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are removed from the DB (and unloaded if necessary).
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This avoids some stat()s and allocations during the plug-in refresh process. (-[WebBasePluginPackage isLoaded]): Removed. (-[WebBasePluginPackage load]): Base class for plug-in packages now always loads "successfully". (-[WebBasePluginPackage dealloc]): Removed this assertion. The base plug-in package class has no concept of "unloading". (-[WebBasePluginPackage finalize]): ditto. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in packages can be "unloaded".
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Combined old -unload and -unloadWithoutShutdown methods into this new one. (-[WebNetscapePluginPackage initWithPath:]): Call new unload method. (-[WebNetscapePluginPackage load]): ditto (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]): ditto (-[WebNetscapePluginPackage open]): New method. Called when a plug-in instance starts running. (-[WebNetscapePluginPackage close]): New method. Called when a plug-in instance stops running. When all plug-in instances close the plug-in package, and the plug-in package is removed from the database, the plug-in is unloaded.
  • Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]): Made this a bit more efficient by checking if the bundle is already loaded. (-[WebBasePluginPackage unload]): Removed. (-[WebBasePluginPackage isLoaded]): Removed.
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Open the plug-in package so it remains loaded while this instance uses it. (-[WebBaseNetscapePluginView stop]): Close the plug-in package when the plug-in instance is stopped.


  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have been stopped, and a Netscape plug-in instance will stop its streams when it is stopped. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
4:34 PM Changeset in webkit [15895] by thatcher
  • 1 copy in tags/WebCore-418.21/WebCore

Tag for WebCore 418.21 (part 2 of 2.)

4:34 PM Changeset in webkit [15894] by thatcher
  • 1 add in tags/WebCore-418.21

Tag for WebCore 418.21 (part 1 of 2.)

4:31 PM Changeset in webkit [15893] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping

JavaScriptGlue:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping

  • WebKit.xcodeproj/project.pbxproj:
4:24 PM Changeset in webkit [15892] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:51 PM Changeset in webkit [15891] by ggaren
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch


This fixes <rdar://problem/4661982> (crash in KHTMLParser::popBlock).


  • This patch reworks a previous fix for <rdar://problem/3524912> repro crash in KHTMLParser::parseToken, due to parser's current element being destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix leaks.


The previous solutions caused a ~2% performance regression on iBench HTML,
due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
for a total win of ~3% vs current TOT.


The solution here is:
(1) Don't let the parser ref document nodes -- that causes leaks.
(2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when
moving a node between stacks or to/from 'current', rather than deref'ing
and then ref'ing again, simply move the node, along with its refcount, to
its new location, and overwrite its old location.


  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::setCurrent): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::popOneBlock): (WebCore::HTMLParser::moveOneBlockToStack):
  • html/HTMLParser.h:
3:51 PM Changeset in webkit [15890] by ggaren
  • 4 edits
    2 adds in trunk

LayoutTests:

Layout test for <rdar://problem/4661982> (crash in KHTMLParser::popBlock)

  • fast/parser/remove-node-stack-expected.txt: Added.
  • fast/parser/remove-node-stack.html: Added.

WebCore:

Reviewed by Darin.


  • This patch reworks a previous fix for <rdar://problem/3524912> repro crash in KHTMLParser::parseToken, due to parser's current element being destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix leaks.


The previous solutions caused a ~2% performance regression on iBench HTML,
due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
for a total win of ~3% vs current TOT.


We can merge this fix to the branch to fix <rdar://problem/4661982>
(crash in KHTMLParser::popBlock).


The solution here is:
(1) Don't let the parser ref document nodes -- that causes leaks.
(2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when
moving a node between stacks or to/from 'current', rather than deref'ing
and then ref'ing again, simply move the node, along with its refcount, to
its new location, and overwrite its old location.


  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::setCurrent): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::popOneBlock): (WebCore::HTMLParser::moveOneBlockToStack):
  • html/HTMLParser.h:
3:38 PM Changeset in webkit [15889] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css

Add system fonts layout test.

3:37 PM Changeset in webkit [15888] by hyatt
  • 12 edits in trunk/WebCore

Fix for bug 3303, support CSS2 system fonts. This patch adds a new API
to RenderTheme for obtaining a system font. In addition to supporting
the CSS2 values, extensions have been added for the 3 control sizes on
Mac. The UA stylesheet now uses -webkit-small-control and no longer hardcodes
Lucida Grande 11px. This means that controls in Safari should now respect
haxies that modify the default fonts on controls.

Reviewed by beth

Added fast/css/css2-system-fonts.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/html4.css:
  • platform/FontDescription.h: (WebCore::FontDescription::setBold):
  • platform/win/TemporaryLinkStubs.cpp: (RenderThemeWin::systemFont):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcMinMaxWidth):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::minimumMenuListSize):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemFont): (WebCore::RenderThemeMac::minimumMenuListSize):
  • rendering/RenderThemeWin.h:
3:12 PM Changeset in webkit [15887] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-15 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/attachment.cgi?bugid=10417
Search rectangle size increased.

  • BrowserView/inc/WebKitCursor.h:
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CalcSearchRect): (CWebKitCursor::IncreaseSearchRect):
2:40 PM Changeset in webkit [15886] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for: <rdar://problem/4680207> REGRESSION: select-all should fire onSelect event for text fields and textareas (9518)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9518

  • fast/forms/onselect-selectall-expected.txt: Added.
  • fast/forms/onselect-selectall.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/onselect-selectall.html

  • page/Frame.cpp: (WebCore::Frame::selectAll): Call notifyRendererOfSelectionChange with userTriggered = true so that onSelect will fire.
2:31 PM Changeset in webkit [22102] by sfalken
  • 86 adds in branches/WindowsMerge/WebKitWin

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Initial check-in.

2:29 PM Changeset in webkit [22101] by sfalken
  • 14 adds in branches/WindowsMerge/WebCore

2006-08-15 Steve Falkenburg <​sfalken@apple.com>

Initial check-in.

2:28 PM Changeset in webkit [22100] by sfalken
  • 1 add in branches/WindowsMerge/LayoutTests

Initial check-in.

2:28 PM Changeset in webkit [22099] by sfalken
  • 1 add in branches/WindowsMerge

Initial check-in.

2:24 PM Changeset in webkit [15885] by yongjzha
  • 23 edits
    2 adds in S60/trunk

2006-08-15 yongjzha ​yongjun.zhang@nokia.com

Reviewed by Brad, Zalan and Sachin


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10418
Create a dedicated view to play plugin content only, this is
only enabled in US build.
Improve the communication between plugins and browser, providing
a interface for the plugins to tell browser that there are
interactable.


  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::CountComponentControls): (CBrCtl::ComponentControl):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/inc/WebKitFrame.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::OpenPluginPlayer): (CWebKitControl::ClosePluginPlayer): (CWebKitControl::IsPluginPlayer): (CWebKitControl::PluginPlayer):
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::FocusedPlugin):
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • Plugin/inc/PluginAdapterInterface.h:
  • Plugin/inc/PluginSkin.h: (CPluginSkin::Url): (CPluginSkin::CanInteract):
  • Plugin/inc/PluginWin.h: (CPluginWin::IsContentInteractive): (CPluginWin::SetContentInteractive):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::Draw): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::IsFocusable):
  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::PluginDataUrl):
  • group/BrowserView.mmp:
2:00 PM Changeset in webkit [15884] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-15 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin.
Change the UID3 of browserengine.dll in release 3.1 to
match with the 3.0.


  • group/webkit.mmp:
1:49 PM Changeset in webkit [15883] by andersca
  • 5 edits in trunk/WebCore

2006-08-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::charactersWithNullTermination): Add new function which calls StringImpl::charactersWithNullTermination.


  • platform/StringImpl.cpp: (WebCore::StringImpl::init): (WebCore::StringImpl::append): (WebCore::StringImpl::insert): (WebCore::StringImpl::truncate): (WebCore::StringImpl::remove): Set m_hasTerminatingNullCharacter to false;


(WebCore::StringImpl::charactersWithNullTermination):
If the string already has a terminating null character, simply return it. Otherwise,
realloc to make room for one and set m_hasTerminatingNullCharacter to true;

  • platform/StringImpl.h: (WebCore::StringImpl::StringImpl): Add m_hasTerminatingNullCharacter.
1:16 PM Changeset in webkit [15882] by adele
  • 3 edits in trunk/WebCore

Reviewed by Adam.

  • rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::addGroupLabel): Removed code to set foreground color in NSMenu. Added a FIXME that we need to handle both foreground and background color. (9846) (WebCore::RenderPopupMenuMac::addOption): ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle): For the aqua look, set the foreground color to black.
12:20 PM Changeset in webkit [15881] by mjs
  • 6 edits
    1 add in trunk/WebKit

Reviewed by Anders.


  • remove WebKit dependencies from WebPlugInStreamLoader via a protocol veil of ignorance
  • Loader/WebNetscapePlugInStreamLoader.h:
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader initWithDelegate:frameLoader:]):
  • Loader/WebPlugInStreamLoaderDelegate.h: Added.
  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
  • WebKit.xcodeproj/project.pbxproj:
9:08 AM Changeset in webkit [15880] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration

JavaScriptGlue:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration

  • WebKit.xcodeproj/project.pbxproj:
8:26 AM Changeset in webkit [15879] by darin
  • 9 edits
    6 deletes in trunk/WebCore

Reviewed by Hyatt.
Tweaked and landed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10399
Bug 10399: RenderTextArea is unused

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Removed RenderTextArea source files.
  • html/HTMLTextAreaElement.cpp: Removed include of RenderTextArea.h.
  • html/HTMLTextAreaElement.h: Removed forward declaration of RenderTextArea.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Updated a comment.
  • platform/TextBox.h: Removed.
  • platform/mac/TextBoxMac.mm: Removed.
  • platform/mac/WebCoreTextArea.h: Removed.
  • platform/mac/WebCoreTextArea.mm: Removed.
  • rendering/RenderTextArea.cpp: Removed.
  • rendering/RenderTextArea.h: Removed.
8:14 AM Changeset in webkit [15878] by darin
  • 2 edits in trunk/WebKit

Reviewed by Darin.


  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): Fixed to get objects from the archived resources dictionary using the URL as a string instead of as the URL itself (as this is how the data is put into the dictionary).
7:00 AM Changeset in webkit [15877] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-08-15 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10352
Browser crashes when exit during loading of www.yahoo.com
Call cancel in active object CStaticImageDecoder's destructor.


  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::~CStaticImageDecoder):
6:56 AM Changeset in webkit [15876] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-08-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10351

  • Plugin/src/PluginLoader.cpp: (CPluginLoader::Complete):
6:54 AM Changeset in webkit [15875] by brmorris
  • 2 edits in S60/trunk/S60Tools

2006-08-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10390


  • svn-create-patch.bat: exits if tabs
6:44 AM Changeset in webkit [15874] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-08-15 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10345
Correct the event we send to plugins when the focus changes
from/to plugin and browser. Fix that a non-leaving method
has a leaving method in it, by wrapping with TRAP_IGNORE.

  • BrowserView/src/WebKitView.cpp: (CWebKitView::FocusChanged):
  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::MakeVisible): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::Status): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
1:04 AM Changeset in webkit [15873] by beidson
  • 4 edits in trunk/WebCore

Reviewed by THE OTHER Maciej...

Two small fixes -
1) Renamed retain/release methods to add PageUrl in - we're being consistent and clear in the WebCore API
2) Fixed a bug where a null SiteIcon reference would be added into the pageURLToSiteIcon map causing a
null dereference later

  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge retainIconForURL:]): Changed IconDatabase method name (-[WebCoreIconDatabaseBridge releaseIconForURL:]): ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): Name change (WebCore::IconDatabase::releaseIconForPageURL): ditto (WebCore::IconDatabase::setIconURLForPageURL): Added the null site-icon check when changing a PageURL's iconURL
  • loader/icon/IconDatabase.h: Some renames

Aug 14, 2006:

11:40 PM Changeset in webkit [15872] by eseidel
  • 69 edits
    7 adds in trunk

2006-08-14 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.

<mask>, <marker>, <pattern> inside <defs> do not work
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

  • ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): moved to .cpp file (WebCore::SVGDefsElement::isValid): moved to .cpp file (WebCore::SVGDefsElement::rendererIsNeeded): Added. (WebCore::SVGDefsElement::createRenderer): Added.
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): adjusted spacing (WebCore::SVGGElement::parseMappedAttribute): adjusted spacing (WebCore::SVGDummyElement::SVGDummyElement): adjusted spacing
11:37 PM Changeset in webkit [15871] by eseidel
  • 2 edits in trunk/WebKitSite

2006-08-15 Eric Seidel <​eric@eseidel.com>

Reviewed by TimH.

  • projects/svg/status.xml: updated to reflect current SVG status
11:12 PM Changeset in webkit [15870] by eseidel
  • 39 edits
    3 copies in trunk

2006-08-14 Eric Seidel <​eric@eseidel.com>

Reviewed by darin and mjs.


Add better SVGLoad event support.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
There will still need to be additional support added for <link> and <script> elements.
Not all of the error -> loaded -> error transition cases work yet.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::SVGImageLoader): (WebCore::SVGImageLoader::dispatchLoadEvent):
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::parseMappedAttribute): (WebCore::SVGElement::haveLoadedRequiredResources): (WebCore::SVGElement::sendSVGLoadEventIfPossible): (WebCore::SVGElement::closeRenderer):
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGImageElement.cpp: (SVGImageElement::SVGImageElement): (SVGImageElement::haveLoadedRequiredResources):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
  • ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::executeScript):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
10:38 PM Changeset in webkit [15869] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Beth.


  • remove many (but not all) WebKit dependencies from WebNetscapePlugInStreamLoader (it still depends on WebNetscapePluginStream).
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
  • Loader/WebNetscapePlugInStreamLoader.h:
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader initWithStream:frameLoader:]): (-[WebNetscapePlugInStreamLoader releaseResources]): (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
10:18 PM Changeset in webkit [15868] by mjs
  • 1 edit
    1 add in trunk/LayoutTests

Missing expected results for last test.

  • http/tests/plugins/interrupted-get-url-expected.txt: Added.
8:52 PM Changeset in webkit [15867] by mjs
  • 3 edits
    5 adds in trunk

LayoutTests:

Test case not reviewed but the patch was reviewed by Tim Omernick.


  • http/tests/plugins/interrupted-get-url.html: Added.
  • http/tests/plugins/resources/interrupted-get-url-success.html: Added.
  • http/tests/plugins/resources/slow-resource.pl: Added.

WebKit:

Reviewed by Tim Omernick.


  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream. (-[WebNetscapePlugInStreamLoader cancelWithError:]): Make sure to destroy the stream as well; otherwise, when we try to clean up later, we won't have the right context.
5:59 PM Changeset in webkit [15866] by andersca
  • 9 edits
    4 adds in trunk/WebCore

2006-08-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10393
Autogenerate NodeIterator and TreeWalker.


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new files.


  • bindings/js/JSNodeIteratorCustom.cpp: Added. (WebCore::JSNodeIterator::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: Added. (WebCore::JSTreeWalker::mark):


  • bindings/js/kjs_traversal.cpp:
  • bindings/js/kjs_traversal.h: Remove implementations of DOMNodeIterator and DOMTreeWalker.
  • bindings/scripts/CodeGeneratorJS.pm: Add "CustomMarkFunction" attribute for classes where mark() needs to be overridden.


  • bindings/objc/DOM.mm: (-[DOMNodeIterator detach]):
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::detach):
  • dom/NodeIterator.h: Get rid of exception in detach, it isn't used at all and this function can't throw an exception according to the spec.
  • dom/NodeIterator.idl: Added.
  • dom/TreeWalker.idl: Added.
5:03 PM Changeset in webkit [15865] by beidson
  • 4 edits in trunk/WebCore

Reviewed by John

The changes are plentiful, but small, mostly to improve performance
1) Add a bool flag to SiteIcon to stop it from querying the database over and over
2) Added a pageURL->iconURL hashmap to cache database results, as an optimization
3) Fix a bug in setIconURLForPageURL code where the pageURL would still point to an old icon
4) Added isIconURLRetained() to optimize the retain count check
5) Prune old, unused code

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconID): Removed unused code (WebCore::IconDatabase::imageDataForIconURL): Removed unused code (WebCore::IconDatabase::imageDataForPageURL): Removed unused code (WebCore::IconDatabase::isIconExpiredForIconURL): Removed LOG msg (WebCore::IconDatabase::isIconExpiredForPageURL): Removed LOG msg (WebCore::IconDatabase::iconURLForPageURL): Added a hashmap cache to avoid common queries (WebCore::IconDatabase::releaseIconForURL): Changed to is isRetained() instead of retainCount() (WebCore::IconDatabase::isIconURLRetained): Added - we don't care about the actual retain count for an icon so much as whether or not it is retained (WebCore::IconDatabase::setIconURLForPageURL): If the new and old iconURLs are the same, skip the SQLite code
  • loader/icon/IconDatabase.h: Added new methods/variables
  • loader/icon/SiteIcon.cpp: (SiteIcon::SiteIcon): Added a flag so it only queries the database for icon data once (SiteIcon::getImage): Ditto
4:22 PM Changeset in webkit [15864] by hyatt
  • 1 edit in trunk/WebCore/html/HTMLTokenizer.cpp

Land a wording tweak to a comment I made.

3:05 PM Changeset in webkit [15863] by yongjzha
  • 2 edits in S60/trunk/WebKit

006-08-14 ligman <​joseph.ligman@nokia.com>

Reviewed by yongjzha
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10335
Browser crashes on exit because ~CPluginSkin trys to make use of the
iBrCtlSoftkeysObserver in it's destructor. The iBrCtlSoftkeysObserver is not
always owned by CBrCtl and therefore could be deleted prematurely. When the CPluginSkin
tried to make use of it, it was no longer valid and it was not set to NULL. To resolve this
the object destruction was rearranged in CBrCtl to delete the CWebKitControl after deleting
all of the observers and setting them to NULL.


Change the order of how ojects are destructed in ~CBrCtl
set observer pointers to NULL

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::UpdateDefaultSoftkeysL):
2:43 PM Changeset in webkit [15862] by hyatt
  • 2 edits
    4 adds in trunk

Fix for bug 10385, add more support for crappy pseudo-XML-in-HTML.

Reviewed by ggaren

Added fast/parser/bad-xml-slash.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
1:48 PM Changeset in webkit [15861] by hyatt
  • 2 edits in trunk/WebKit

Fix for Radar bug 4478840, Safari should not reduce null events sent to
plug-ins in windows that are inactive but visible.

With this fix you can view videos in visible background windows on YouTube
(for example) and not see any drop in frame rate.

Reviewed by timo

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]):
1:17 PM Changeset in webkit [15860] by thatcher
  • 7 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-08-04 Beth Dakin <Beth Dakin>

Reviewed by me/Hyatt.

Mostly this is merging over Hyatt's fix with r15801. Some other
things needed to be tweaked though. This is a better fix for
<rdar://problem/4541255> Safari hangs at ​http://www.kutilek.de/
safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

  • khtml/rendering/render_box.cpp: (RenderBox::deleteLineBoxWrapper): Call remove.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): Call remove.
  • khtml/rendering/render_list.h: (khtml::ListMarkerBox:::InlineBox):
  • khtml/rendering/render_object.cpp: Back out old fix. (RenderObject::remove):
  • khtml/rendering/render_object.h: Back out old fix.
12:23 PM Changeset in webkit [15859] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/parser/title-error-test-expected.checksum: Added.
  • fast/parser/title-error-test-expected.png: Added.
  • fast/parser/title-error-test-expected.txt: Added.
  • fast/parser/title-error-test.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/parser/title-error-test.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Fixed an error handling case that was skipping until a </style> tag in code that was shared between both <title> and <style>. Also rearranged the code a tiny bit.
12:16 PM Changeset in webkit [15858] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-07-28 Beth Dakin <Beth Dakin>

Rubber stamped by Maciej.

Fix for <rdar://problem/4541255> Safari hangs at ​http://
www.kutilek.de/safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

This is the same fix that Maciej and I did a week ago for 4529398.
Rolling it onto the branch because it fixes this crash too!

  • WebCore.xcodeproj/project.pbxproj: Project file wars.
  • khtml/rendering/render_list.cpp: (ListMarkerBox::detach): Remove from parent when detaching. (ListMarkerBox::operator delete):
  • khtml/rendering/render_list.h:
12:14 PM Changeset in webkit [15857] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Rearrange code so that "delete this" is called any time the function returns false -- ownership was inconsistent before.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Call deleteLineBoxWrapper even when documentBeingDestroyed() is true, because some of what it does has to be done during destruction. A little awkward since I preserved the order of operations. Perhaps we could structure this better later.
10:13 AM Changeset in webkit [15856] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan and Geoff Garen.

<rdar://problem/3854950> AX Seed: Blackboard Learning Systems - frame names need to be put in AXDescription AXAttribute

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): For a web area, return the name of the owning frame or iframe.


(-[WebCoreAXObject accessibilityAttributeNames]):
Advertize NSAccessibilityDescriptionAttribute.


(-[WebCoreAXObject rendererForView:]):
Clean up some old naming.

9:32 AM Changeset in webkit [15855] by andersca
  • 6 edits
    6 adds
    4 deletes in trunk/WebCore

2006-08-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10353
XMLSerializer and DOMParser should have real implementations


Make real implementation files for DOMParser and XMLSerializer and wrap them
using our bindings generation.


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMParser.cpp: Removed.
  • bindings/js/JSDOMParser.h: Removed.
  • bindings/js/JSXMLSerializer.cpp: Removed.
  • bindings/js/JSXMLSerializer.h: Removed.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.idl:
  • xml/DOMParser.cpp: Added. (WebCore::DOMParser::parseFromString):
  • xml/DOMParser.h: Added.
  • xml/DOMParser.idl: Added.
  • xml/XMLSerializer.cpp: Added. (WebCore::XMLSerializer::serializeToString):
  • xml/XMLSerializer.h: Added.
  • xml/XMLSerializer.idl: Added.
2:01 AM Changeset in webkit [15854] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Brady.

  • removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
  • WebCore.exp: export new functions
  • platform/mac/WebCoreSystemInterface.h: Added CFReadStream related functions
  • platform/mac/WebCoreSystemInterface.mm: ditto

WebKit:

Reviewed by Brady.


  • removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
  • Loader/WebFormDataStream.m: (formCanRead): (formEventCallback): (webSetHTTPBody):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
12:20 AM Changeset in webkit [15853] by mjs
  • 2 edits
    2 moves in trunk/WebKit

Rubber stamped by Brady.


  • move WebFormDataStream from WebView to Loader
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFormDataStream.h: Removed.
  • WebView/WebFormDataStream.m: Removed.
12:09 AM Changeset in webkit [15852] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream


(WebFormDataStream will be moved into the Loader directory soon)

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • Loader/WebSubresourceLoader.m: (isConditionalRequest): (hasCaseInsensitivePrefix): (isFileURLString): (setHTTPReferrer): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):

Aug 13, 2006:

11:50 PM Changeset in webkit [15851] by beidson
  • 2 edits
    2 moves in trunk/WebKit

Reviewed by Maciej

Relocated the WebIconLoaders

  • Misc/WebIconLoader.h: Moved to Loader/
  • Misc/WebIconLoader.m: Moved to Loader/
  • WebKit.xcodeproj/project.pbxproj:
11:46 PM Changeset in webkit [15850] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

Fixed my inaccurately stated Changelog

11:45 PM Changeset in webkit [15849] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Beth.


  • removed non-Loader WebKit dependencies from WebDataProtocol for real (whoops) and fix some typos.
  • Loader/WebDataProtocol.m: (isCaseInsensitiveEqual): Added. (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls. (-[WebDataProtocol startLoading]): ditto
  • Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual. (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.
11:44 PM Changeset in webkit [15848] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Maciej

The way of detecting a failed icon load before was to try and construct
an image from the icon and if that image construction failed, mark the icon
as missing.
A much more efficient way is to check for a 404 response. We'll still
check for invalid image data, but most servers will correctly return 404
on a missing icon.


  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Added check for 404 response
8:22 PM Changeset in webkit [15847] by mjs
  • 9 edits
    2 moves in trunk/WebKit

Reviewed by Darin.


  • remove all non-Loader dependencies from WebLoader


As part of this I moved WebDataProtocol to the loader directory
and removed dependencies on the rest of WebKit from that too.

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader clearArchivedResources]): (-[WebFrameLoader deliverArchivedResources]): (-[WebFrameLoader deliverArchivedResourcesAfterDelay]): (isCaseSensitiveEqual): (-[WebFrameLoader _canUseResourceForRequest:]): (-[WebFrameLoader _canUseResourceWithResponse:]): (-[WebFrameLoader pendingArchivedResources]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • Loader/WebLoader.h:
  • Loader/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setDefersCallbacks:]): (-[NSURLProtocol addData:allAtOnce:]): (-[NSURLProtocol resourceData]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]): (-[NSURLProtocol connection:didReceiveData:lengthReceived:]): (-[NSURLProtocol cancelWithError:]): (-[NSURLProtocol cancelledError]):
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader addData:allAtOnce:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
  • Loader/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataProtocol.h: Removed.
  • WebView/WebDataProtocol.m: Removed.
8:06 PM Changeset in webkit [15846] by mjs
  • 22 edits
    1 copy
    2 adds in trunk

JavaScriptCore:

Reviewed (and tweaked a little) by Maciej.


  • shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

This was done by removing _scope and _internalValue data members
from JSObject and moving them only to the subclasses that actually
make use of them.


  • kjs/object.cpp: (KJS::JSObject::mark): No need to mark scope or internal value here.
  • kjs/object.h: (KJS::JSObject::JSObject): Don't initialize them.
  • kjs/JSWrapperObject.cpp: Added. New base class for object types that wrap primitive values (Number, String, Boolean, Date). (KJS::JSWrapperObject::mark):
  • kjs/JSWrapperObject.h: Added. (KJS::JSWrapperObject::JSWrapperObject): (KJS::JSWrapperObject::internalValue): (KJS::JSWrapperObject::setInternalValue):
  • kjs/array_object.cpp: (ArrayPrototype::ArrayPrototype): Don't set useless internal value.
  • kjs/bool_object.cpp: (BooleanInstance::BooleanInstance): Inherit from JSWrapperObject. (BooleanProtoFunc::callAsFunction): Fixed to account for fact that not all JSObjects have an internal value. (BooleanObjectImp::construct): ditto.
  • kjs/bool_object.h:
  • kjs/collector.cpp: Lowered cell size to 48. (KJS::Collector::allocate): meaningless whitespace change
  • kjs/date_object.cpp: (KJS::DateInstance::DateInstance): Inherit from JSWrapperObject. (KJS::DateProtoFunc::callAsFunction): adjusted for move of internalValue (KJS::DateObjectImp::construct): ditto
  • kjs/date_object.h:
  • kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): don't set internal value
  • kjs/function.cpp: move _scope and related handling here (KJS::FunctionImp::mark): mark scope
  • kjs/function.h: (KJS::FunctionImp::scope): moved here from JSObject (KJS::FunctionImp::setScope): ditto
  • kjs/number_object.cpp: (NumberInstance::NumberInstance): inherit from JSWrapperObject (NumberProtoFunc::callAsFunction): adjusted (NumberObjectImp::construct): adjusted
  • kjs/number_object.h: shring RegExp-related objects a little
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): Adjust for size tweaks (RegExpObjectImp::RegExpObjectImp): ditto
  • kjs/regexp_object.h:
  • kjs/string_object.cpp: (StringInstance::StringInstance): inherit from JSWrapperObject (StringProtoFunc::callAsFunction): adjusted
  • kjs/string_object.h:
  • JavaScriptCore.exp: Exported new methods as needed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files to build.

WebCore:

Reviewed (and tweaked a little) by Maciej.


  • shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.


  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):

Aug 12, 2006:

6:38 PM Changeset in webkit [15845] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

Aug 11, 2006:

10:59 PM Changeset in webkit [15844] by eseidel
  • 3 edits in trunk/WebCore

2006-08-12 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt and mjs.

Fix two missing null checks causing layout test crashes.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
10:46 PM Changeset in webkit [15843] by ddkilzer
  • 4 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (layout test fix).

Additional layout test fixes from hyatt's "Eliminate RenderImageButton" change
in r15839. See also r15840 for more layout test fixes.

  • tables/mozilla/bugs/bug19599-expected.txt: Changed RenderImageButton to RenderImage.
  • tables/mozilla/bugs/bug24200-expected.txt: Ditto.
  • tables/mozilla/bugs/bug4527-expected.txt: Ditto.
9:07 PM Changeset in webkit [15842] by eseidel
  • 15 edits
    4 adds in trunk

2006-08-11 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

The outermost <svg> element needs to clip itself
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5358

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG (WebCore::RenderSVGContainer::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
  • ksvg2/svg/SVGPaint.cpp: spacing changes (WebCore::SVGPaint::SVGPaint): spacing cleanup
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
  • platform/GraphicsContext.h: Added concatCTM
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): Added.
8:22 PM Changeset in webkit [15841] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Maciej

Renamed a method/parameter for clarity and consistency, as well as some style
cleanups and removing some ridiculously verbose log messages.
Also added an _isEmpty method to the database and bridge for WebKit's use.
Finally, added a central way for both WebKit and WebCore to get the icon database filename

  • bridge/mac/WebCoreIconDatabaseBridge.h: Added _isEmpty and defaultDatabaseFilename
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed an unnecessary semicolon off most of these methods (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge _isEmpty]): Added (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]): (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Added (WebCore::IconDatabase::open): (WebCore::IconDatabase::isEmpty): Added (WebCore::IconDatabase::retainIconForURL): Removed log message (WebCore::IconDatabase::releaseIconForURL): Removed log message
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John, Timo, Adele, and Darin

In addition to a few style/good-practice cleanups, this patch will convert the old icon database
format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
place). After the conversion, it will delete all traces of the old format to free the unneeded space

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function (-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
4:53 PM Changeset in webkit [15840] by hyatt
  • 5 edits in trunk/LayoutTests/fast/forms

Update layout tests for removal of RenderImageButton

4:52 PM Changeset in webkit [15839] by hyatt
  • 5 edits in trunk/WebCore

Eliminate RenderImageButton.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isImageButton]):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/RenderImage.h: (WebCore::RenderImage::isImage):
4:49 PM Changeset in webkit [15838] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test case for <rdar://problem/4656274>
REGRESSION: option elements are selected when added regardless of "selected" property

  • fast/forms/option-constructor-selected-expected.txt: Added.
  • fast/forms/option-constructor-selected.html: Added.

WebCore:

Reviewed by Brady.

  • Fix for <rdar://problem/4656274> REGRESSION: option elements are selected when added regardless of "selected" property

Test: fast/forms/option-constructor-selected.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): When adding an option element, check that the option element is selected before calling setSelectedIndex.
4:06 PM Changeset in webkit [15837] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.


Needed for <rdar://problem/4678070>.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/4318269>.
3:35 PM Changeset in webkit [15836] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary to avoid printing an almost-empty page
  • WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]): If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled out of ... the air), then we adjust the scale factor slightly and check whether this reduces the page count and thus eliminates the orphan.
2:26 PM Changeset in webkit [15835] by hyatt
  • 4 adds in trunk/LayoutTests/fast/dynamic

Add layout test for link bug.

2:18 PM Changeset in webkit [15834] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 10349, make sure to call setChanged when an anchor changes
from not being a link to being a link (and vice versa).

Test is in fast/dynamic/link-href-change.html

Reviewed by darin

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
1:58 PM Changeset in webkit [15833] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Revert an over-optimization step that messed up the HashSet lookup.

10:46 AM Changeset in webkit [15832] by oliver
  • 2 edits in trunk/WebCore

Removing unnecessary comment from patch for bug 10346

10:15 AM Changeset in webkit [15831] by oliver
  • 2 edits in trunk/WebCore

Fix for bug #10346, fixes regression in svg image layout

Aug 10, 2006:

5:28 PM Changeset in webkit [15830] by andersca
  • 4 edits
    33 copies
    1 delete in trunk/WebCore

2006-08-10 Anders Carlsson <​acarlsson@apple.com>

Rubber-stamped by Maciej.

Move xpath to xml.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xpath/XPathEvaluator.cpp: Removed.
  • xpath/XPathEvaluator.h: Removed.
  • xpath/XPathEvaluator.idl: Removed.
  • xpath/XPathExpression.cpp: Removed.
  • xpath/XPathExpression.h: Removed.
  • xpath/XPathExpression.idl: Removed.
  • xpath/XPathNSResolver.cpp: Removed.
  • xpath/XPathNSResolver.h: Removed.
  • xpath/XPathNSResolver.idl: Removed.
  • xpath/XPathNamespace.cpp: Removed.
  • xpath/XPathNamespace.h: Removed.
  • xpath/XPathResult.cpp: Removed.
  • xpath/XPathResult.h: Removed.
  • xpath/XPathResult.idl: Removed.
  • xpath/impl/XPathExpressionNode.cpp: Removed.
  • xpath/impl/XPathExpressionNode.h: Removed.
  • xpath/impl/XPathFunctions.cpp: Removed.
  • xpath/impl/XPathFunctions.h: Removed.
  • xpath/impl/XPathGrammar.y: Removed.
  • xpath/impl/XPathParser.cpp: Removed.
  • xpath/impl/XPathParser.h: Removed.
  • xpath/impl/XPathPath.cpp: Removed.
  • xpath/impl/XPathPath.h: Removed.
  • xpath/impl/XPathPredicate.cpp: Removed.
  • xpath/impl/XPathPredicate.h: Removed.
  • xpath/impl/XPathStep.cpp: Removed.
  • xpath/impl/XPathStep.h: Removed.
  • xpath/impl/XPathUtil.cpp: Removed.
  • xpath/impl/XPathUtil.h: Removed.
  • xpath/impl/XPathValue.cpp: Removed.
  • xpath/impl/XPathValue.h: Removed.
  • xpath/impl/XPathVariableReference.cpp: Removed.
  • xpath/impl/XPathVariableReference.h: Removed.
1:37 PM Changeset in webkit [15829] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4600112> REGRESSION: VO no longer able to review text within an edit field on web pages

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Add handling for text input fields.

Aug 9, 2006:

10:11 PM Changeset in webkit [15828] by ddkilzer
  • 397 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_proxy.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm: (raiseDOMException):
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/DOMXPathInternal.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedNonImageMIMETypes]):
  • css/CSSGrammar.y:
  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::applyProperty):
  • css/cssstyleselector.h:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createElementNS): (WebCore::Document::implicitClose): (WebCore::Document::recalcStyleSelector): (WebCore::Document::createEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResourceListener.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/RenderForeignObject.cpp:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp:
  • kcanvas/RenderSVGContainer.h:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.cpp:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/KRenderingStrokePainter.cpp:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
  • kcanvas/device/quartz/KCanvasPathQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.h:
  • ksvg2/css/SVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/ecma/GlobalObject.h:
  • ksvg2/events/JSSVGLazyEventListener.cpp:
  • ksvg2/events/JSSVGLazyEventListener.h:
  • ksvg2/events/SVGZoomEvent.cpp:
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/svg/DOMList.h:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedAngle.cpp:
  • ksvg2/svg/SVGAnimatedAngle.h:
  • ksvg2/svg/SVGAnimatedBoolean.cpp:
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGAnimatedColor.cpp:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedEnumeration.cpp:
  • ksvg2/svg/SVGAnimatedEnumeration.h:
  • ksvg2/svg/SVGAnimatedInteger.cpp:
  • ksvg2/svg/SVGAnimatedInteger.h:
  • ksvg2/svg/SVGAnimatedLength.cpp:
  • ksvg2/svg/SVGAnimatedLength.h:
  • ksvg2/svg/SVGAnimatedLengthList.cpp:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumber.cpp:
  • ksvg2/svg/SVGAnimatedNumber.h:
  • ksvg2/svg/SVGAnimatedNumberList.cpp:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedPathData.cpp:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.cpp:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
  • ksvg2/svg/SVGAnimatedRect.cpp:
  • ksvg2/svg/SVGAnimatedRect.h:
  • ksvg2/svg/SVGAnimatedString.cpp:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimatedTransformList.cpp:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDOMImplementation.cpp:
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDefsElement.cpp:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.cpp:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.cpp:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstance.cpp:
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstanceList.cpp:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.cpp:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.cpp:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.cpp:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.cpp:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.cpp:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.cpp:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.cpp:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.cpp:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.cpp:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGLocatable.cpp:
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.cpp:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumber.cpp:
  • ksvg2/svg/SVGNumber.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.cpp:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.cpp:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.cpp:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.cpp:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.cpp:
  • ksvg2/svg/SVGPoint.h:
  • ksvg2/svg/SVGPointList.cpp:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.cpp:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.cpp:
  • ksvg2/svg/SVGRect.h:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.cpp:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.cpp:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.cpp:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.cpp:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.cpp:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.cpp:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.cpp:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.cpp:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformList.cpp:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.cpp:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.cpp:
  • ksvg2/svg/SVGZoomAndPan.h:
  • ksvg2/svg/svgpathparser.cpp:
  • ksvg2/svg/svgpathparser.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::begin): (WebCore::Frame::pauseTimeouts): (WebCore::Frame::resumeTimeouts):
  • platform/GraphicsContext.h:
  • platform/cg/GraphicsContextCG.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::inheritFrom): (WebCore::RenderStyle::operator==): (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
  • xpath/XPathEvaluator.cpp:
  • xpath/XPathEvaluator.h:
  • xpath/XPathExpression.cpp:
  • xpath/XPathExpression.h:
  • xpath/XPathNSResolver.cpp:
  • xpath/XPathNSResolver.h:
  • xpath/XPathNamespace.cpp:
  • xpath/XPathNamespace.h:
  • xpath/XPathResult.cpp:
  • xpath/XPathResult.h:
  • xpath/impl/XPathExpressionNode.cpp:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathFunctions.cpp:
  • xpath/impl/XPathFunctions.h:
  • xpath/impl/XPathGrammar.y:
  • xpath/impl/XPathParser.cpp:
  • xpath/impl/XPathParser.h:
  • xpath/impl/XPathPath.cpp:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathPredicate.cpp:
  • xpath/impl/XPathPredicate.h:
  • xpath/impl/XPathStep.cpp:
  • xpath/impl/XPathStep.h:
  • xpath/impl/XPathUtil.cpp:
  • xpath/impl/XPathUtil.h:
  • xpath/impl/XPathValue.cpp:
  • xpath/impl/XPathValue.h:
  • xpath/impl/XPathVariableReference.cpp:
  • xpath/impl/XPathVariableReference.h:

Change all #if SVG_SUPPORT to #ifdef SVG_SUPPORT and
#if XPATH_SUPPORT to #ifdef XPATH_SUPPORT
(except for one #if !SVG_SUPPORT to a #ifndef SVG_SUPPORT
in RenderTreeAsText.cpp)

8:09 PM Changeset in webkit [15827] by zbujtas
  • 2 edits in S60/trunk/S60Internals

2006-08-09 bujtas <​zbujtas@gmail.com>

Reviewed by NOBODY.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10318
generate historyprovider.dll using sdk env.

  • S60DynamicLibs.zip:
3:37 PM Changeset in webkit [15826] by zbujtas
  • 4 edits in S60/trunk/WebKit

2006-08-09 sareen <​shyam.sareen@nokia.com>

Reviewed by Yongjun & Zalan.

  • ResourceLoader/CacheInc/HttpCacheHandler.h:
  • ResourceLoader/CacheSrc/HttpCacheHandler.cpp: (CHttpCacheHandler::AdjustResponseTime): (CHttpCacheHandler::ReceivedResponseHeadersL): (CHttpCacheHandler::CacheNeedsValidationL):
  • ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::Age):
  • ResourceLoader/inc/PostDataPart.h:
3:23 PM Changeset in webkit [15825] by zbujtas
  • 4 edits in S60/trunk/WebKit

2006-08-09 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10327
clear webcore side static data when deleting global objects

  • BrowserCore/Formcontrols/src/FFormControlFactory.cpp: (CFormControlFactory::~CFormControlFactory):
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (CImageRendererFactory::~CImageRendererFactory):
  • BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::~CTextRendererFactory):
2:57 PM Changeset in webkit [15824] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-09 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10321
Unable to click "Sign In" button with tool bar feature enabled
Input types of "image" were not handled in CWebCoreBridge::NodeTypeB,
added HTMLInputElementImpl::IMAGE to be recognized as a button.


WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
2:47 PM Changeset in webkit [15823] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-08-08 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10308
Hovering over buttons changes cursor to smartlink telephone icon when it should
change to the selection cursor.

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):

Aug 8, 2006:

2:11 PM Changeset in webkit [15822] by zbujtas
  • 2 edits in S60/trunk/MemoryManager

2006-08-08 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10311


  • Src/fast_malloc.cpp: (close_mem_pool): (ChunkClosingUtil::~ChunkClosingUtil):
1:53 PM Changeset in webkit [15821] by zbujtas
  • 7 edits in S60/trunk

2006-08-08 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10294
text decoding problem for www.yaplog.cn and www.sogou.com

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • ChangeLog:
12:57 PM Changeset in webkit [15820] by zbujtas
  • 4 edits in S60/trunk/WebKit

2006-08-08 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10305
Turn off tabbed navigation when the pageoverview is on

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::SetCurrentZoomLevelIndex): (CWebKitView::ZoomLevelChanged): (CWebKitView::TouchScrolling): (CWebKitView::Draw): (CWebKitView::ScrollAndMoveCursor): (CWebKitView::FindNextSmartLink):
12:28 PM Changeset in webkit [15819] by rwlbuis
  • 33 edits
    2 adds
    1 delete in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
SVGDOMImplementation should die (and be rolled into DOMImplementation)

Delete SVGDOMImplementation and references to it. The
svg specific functionality is now in DOMImplementation.

11:56 AM Changeset in webkit [15818] by zbujtas
  • 2 edits in S60/trunk/S60Internals

2006-08-08 zbujtas <​zbujtas@gmail.com>

add one more Download Manager include file:
\epoc32\include\DownloadMgrCRKeys.h


  • S60Headers.zip:
8:12 AM Changeset in webkit [15817] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-08-07 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10296
Horizontal wrapping from TFastWrapUtil starts from wrong offset.

  • BrowserCore/Renderers/inc/BitmapTiler.h: (TFastWrapUtil::operator++):
7:54 AM Changeset in webkit [15816] by zbujtas
  • 2 edits in S60/trunk/S60Internals
12:28 AM Changeset in webkit [15815] by beidson
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Anders and John

Icons can now refresh when new data is sent from WebKit, both on disk and in memory

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (WebCore::IconDatabase::loadIconFromURL): Allows WebCore/Kit to kick off a load outside of any greater context (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]): (-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit to get whether or not an icon has expired
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): Changed database schema slightly (WebCore::IconDatabase::createPrivateTables): Changed database schema slightly (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired (WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired (WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory image when new icon data is loaded (WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID
  • loader/icon/IconDatabase.h: added/changed some methods
  • loader/icon/SiteIcon.cpp: (SiteIcon::getImage): simplified/removed debugging code (SiteIcon::manuallySetImageData): allow the image data to be changed when new icon data is loaded

WebKit:

Reviewed by Anders and John

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired (-[WebIconDatabase isIconExpiredForPageURL:]): Ditto (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase (-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
  • Misc/WebIconDatabasePrivate.h:
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit (-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load outside of the context of a page load
  • WebCoreSupport/WebIconDatabaseBridge.h: Added.
  • WebCoreSupport/WebIconDatabaseBridge.m: Added. (-[WebIconDatabaseBridge init]): (-[WebIconDatabaseBridge dealloc]): (-[WebIconDatabaseBridge loadIconFromURL:]): Kick off a load on an icon outside of the context of any page load (-[WebIconDatabaseBridge _setIconData:forIconURL:]): WebKit side of bridge method (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]): WebKit side of bridge method (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit so both sides of the bridge get the WebKit version
  • WebKit.xcodeproj/project.pbxproj: Added some files
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): Added check for reload/expired icon to force a load even if we already have it

Aug 7, 2006:

3:56 PM Changeset in webkit [15814] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-08-07 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10260
Browser crashes when trying to cancel a saved page refresh from options menu
Added a flag as to indicate the user has canceled the refresh of a saved page and
therefore the page should not be regenerated


  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL): (CWebKitControl::IncrementProgressForLoadStart): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete):
3:50 PM Changeset in webkit [15813] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-07 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas

WARNING: NO TEST CASES ADDED OR CHANGED


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10240

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
3:47 PM Changeset in webkit [15812] by zbujtas
  • 3 edits in S60/trunk/WebCore

2006-08-07 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas

WARNING: NO TEST CASES ADDED OR CHANGED


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10195

  • kwq/KWQPainter.cpp: (QPainter::xForm): (QPainter::drawFocusRing):
  • kwq/KWQPainter.h:
3:31 PM Changeset in webkit [15811] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-08-05 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10237

Unfinished download should be visible in the download list,
before connection is established.

  • ResourceLoader/inc/HttpDownloadObserver.h:
  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::~CHttpDownloadObserver): (CHttpDownloadObserver::ConstructL): (CHttpDownloadObserver::DlMgrInitCB): (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrEventL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):

Aug 6, 2006:

11:10 PM Changeset in webkit [15810] by thatcher
  • 5 edits in trunk

Fixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef for WebKit because <CoreGraphics/CGBase.h> causes a warning we can't fix. We can turn it back on once this radar is fixed: <rdar://problem/4669823> CGBase.h fails to build with -Wundef enabled.

Aug 5, 2006:

4:53 PM Changeset in webkit [15809] by darin
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • fix a storage leak
  • rendering/RenderView.cpp: (WebCore::RenderView::setSelection): Delete the values if we are going to exit without using the maps. Otherwise all the values leak.
1:14 PM Changeset in webkit [15808] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/frames/iframe-option-crash-expected.checksum: Added.
  • fast/frames/iframe-option-crash-expected.png: Added.
  • fast/frames/iframe-option-crash-expected.txt: Added.
  • fast/frames/iframe-option-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/frames/iframe-option-crash.xhtml

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): Check for a nil renderer.

Aug 4, 2006:

4:27 PM Changeset in webkit [15807] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4644045, regression where dragging selection no longer
works for floats contained inside layers. I added an optimization to
refine dirty rect checking for layers, and it incorrectly excluded floats
from the paint bounds since PaintPhaseSelection was not considered when
analyzing the floatRect().

Reviewed by beth

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
4:19 PM Changeset in webkit [15806] by hyatt
  • 5 edits in trunk/WebCore

Fix remove() so that it is equivalent to calling removeChild on the
parent. This involved moving three operations that remove did.

(1) Move the accessibility object cache removal into the destroy methods,
since this really should just happen when a render object is going away.

(2) removeFromObjectLists shifted into removeChild, which means it will
now be called more often (this is a correct change). Note that there is
also now a new guard on removeFromObjectLists so that it won't do any
work unless the document is not being destroyed.

(3) The big one. deleteLineBoxWrapper was not getting called to clean up
the line box tree. This moved right into RenderContainer's removeChildNode so
that it is now done even in the lowest level RenderContainer removal primitive.

Reviewed by beth

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::removeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h: (WebCore::RenderObject::remove):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
4:03 PM Changeset in webkit [15805] by bdakin
  • 7 edits in branches/Safari-2-0-branch/WebCore

Reviewed by me/Hyatt.

Mostly this is merging over Hyatt's fix with r15801. Some other
things needed to be tweaked though. This is a better fix for
<rdar://problem/4541255> Safari hangs at ​http://www.kutilek.de/
safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

  • khtml/rendering/render_box.cpp: (RenderBox::deleteLineBoxWrapper): Call remove.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): Call remove.
  • khtml/rendering/render_list.h: (khtml::ListMarkerBox:::InlineBox):
  • khtml/rendering/render_object.cpp: Back out old fix. (RenderObject::remove):
  • khtml/rendering/render_object.h: Back out old fix.
2:13 PM Changeset in webkit [15804] by brmorris
  • 13 edits
    2 adds in S60/trunk

2006-08-04 yaharon <​yael.aharon@nokia.com>

Reviewed by Zalan, Yongjun and Steve.

Handle pointer events in WebKit

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10250

  • ChangeLog:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::MouseDown):
  • kwq/KWQWidget.cpp: (QWidget::focusPolicy):
2:12 PM Changeset in webkit [15803] by beidson
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff's rubber stamp

Fix a build break on Intel hardware causes by adapting stricter
compiler warnings (-Wshorten-64-to-32)

  • API/testapi.c: (assertEqualsAsNumber): manually cast some doubles to floats (main): ditto
2:04 PM Changeset in webkit [15802] by hyatt
  • 4 adds in trunk/LayoutTests/fast/lists

Add layout test for list marker crash

2:04 PM Changeset in webkit [15801] by hyatt
  • 4 edits in trunk/WebCore

Back out the fix for list marker crashes. The actual bug here is that
there is a confusing mismatch between remove() and removeChild() in the
render tree. remove() does a little bit of extra work that removeChild
should be doing instead (so that remove() can just be a shorthand for
removeChild).

This conservative fix does not solve the remove/removeChild mismatch
but instead just changes the list marker updating code to use remove
instead.

Reviewed by beth

Test Case: fast/lists/dynamic-marker-crash.html

  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation):
1:52 PM Changeset in webkit [15800] by brmorris
  • 1 copy in S60/tags/s60-RnD-06wk31

Tagging S60 RnD release 2006w31

11:57 AM Changeset in webkit [15799] by weinig
  • 30 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • Adds explicit casts where OK.
  • API/JSNodeList.c: (JSNodeList_item): (JSNodeList_getProperty):
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • Adds 'f' to float literals where expecting a float.
  • Use cosf() instead of cos() when assigning to a float.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: (+[WKDiffuseLightingFilter initialize]):
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: (+[WKDisplacementMapFilter initialize]):
  • kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: (+[WKSpecularLightingFilter initialize]):
  • kcanvas/device/quartz/filters/WKSpotLightFilter.m: (-[WKSpotLightFilter outputImage]):
  • kcanvas/device/quartz/filters/WKTableTransferFilter.m: (-[WKTableTransferFilter outputImage]):

WebKit:

Reviewed by Darin.

  • Adds 'f' to float literals where expecting a float.
  • Use ceilf() instead of ceil() when assigning to a float.
  • Adds explicit casts where OK.


NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
because there are still a few places where no error handling
is in place. The flag can be added as soon as those are worked
out.

  • Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]):
  • Misc/WebNSImageExtras.m: (-[NSImage _web_scaleToMaxSize:]):
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView drawRect:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge expiresTimeForResponse:]):
  • WebInspector/WebInspector.m: (-[NSWindow window]): (-treeViewScrollTo:): (-_updateSystemColors): (-webView:plugInViewWithArguments:): (-outlineView:objectValueForTableColumn:byItem:):
  • WebInspector/WebInspectorOutlineView.m: (-[WebInspectorOutlineView _highlightRow:clipRect:]):
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithBounds:andRects:forView:]):
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView roundedRect:withRadius:]): (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): (-[WebNodeHighlightView drawRect:]):
  • WebView/WebFrame.m: (-[WebFrame _opened]):
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[NSArray layout]): (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): (-[NSArray adjustPageHeightNew:top:bottom:limit:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray setPageWidthForPrinting:]): (-[NSArray _endPrintMode]): (-[NSArray knowsPageRange:]): (-[NSArray _originalFontA]): (-[NSArray _originalFontB]): (-[WebTextCompleteController _buildUI]): (-[WebTextCompleteController _placePopupWindow:]):
  • WebView/WebPDFView.m: (-[WebPDFView _makeTextStandardSize:]): (-[WebPDFView selectionImageForcingWhiteText:]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebPreferences.m: (-[WebPreferences _floatValueForKey:]):
  • WebView/WebView.m: (-[WebView makeTextSmaller:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]):
9:55 AM Changeset in webkit [15798] by aroben
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Convert spaces to tabs
7:09 AM Changeset in webkit [15797] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-08-03 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10244

Fix null pointer crash.


  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrCompletedEventL): (CHttpDownloadObserver::FindDownloadL):
4:23 AM Changeset in webkit [15796] by ddkilzer
  • 1 edit
    6 copies in trunk/WebKit

WebKit:

Reviewed by NOBODY (build fix).

  • WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
  • WebView/WebFrameLoader.h: REALLY moved to Loader/
  • WebView/WebFrameLoader.m: REALLY moved to Loader/
  • WebView/WebLoader.h: REALLY moved to Loader/
  • WebView/WebLoader.m: REALLY moved to Loader/
  • WebView/WebMainResourceLoader.m: REALLY moved to Loader/
Note: See TracTimeline for information about the timeline view.