Context Navigation

← Previous Period
Next Period →

Timeline

Oct 4, 2006:

9:58 PM Changeset in webkit [16800] by andersca

2 edits in trunk/LayoutTests

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

fast/frames/frame-src-attribute-expected.txt: Update test result.

8:08 PM Changeset in webkit [16799] by aroben

4 edits in trunk/WebCore

Reviewed by Maciej and Tim H.

Copy some WebKit frame lifetime logic into WebCore -- just a step
along the path to frame lifetime being handled completely in WebCore.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): Move platform-independent parts of this method into Frame.
page/Frame.cpp: (WebCore::Frame::setView): Adding platform-independent parts of FrameMac::setView (WebCore::Frame::detachChildren): New method to accomplish what -[WebFrameBridge _detachChildren] currently does. (WebCore::Frame::clear): Call detachChildren
page/Frame.h: Add declaration for detachChildren

8:06 PM Changeset in webkit [22300] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej and Tim H.

Fixes <rdar://problem/4760991>
Flash content doesn't go away when navigating to a new page

Actually destroy subframes when detaching.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::frameDetached):
bridge/win/FrameWin.h:

7:02 PM Changeset in webkit [22299] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4762998>
REGRESSION: dragging to select text does not work

platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Set the correct button for WM_MOUSEMOVE events.

6:42 PM Changeset in webkit [16798] by kmccullo

3 edits in trunk/JavaScriptCore

Reviewed by Adam.

Removed an unnecessary assert that was stopping many pages. tm_gmtoff was not set for UTC time in mozilla but is always set for us.

kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::msToTM):
kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime):

6:07 PM Changeset in webkit [16797] by ggaren

2 edits in trunk/JavaScriptCore

Patch by Darin and me, reviewed by Maciej.

Fixed <rdar://problem/4518397> REGRESSION(?): Oft-seen but unrepro crash

in JavaScript garbage collection (KJS::Collector::collect())

<rdar://problem/4752492> Crash in KJS::collect

The issue here was allocating one garbage-collected object in the midst
of allocating a second garbage-collected object. In such a case, the
zeroIfFree word lies.

kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):

5:21 PM Changeset in webkit [16796] by bdash

4 edits in trunk/WebKitTools

2006-10-04 Mark Rowe <bdash@webkit.org>

Reviewed by Stephanie.

Switch the Qt buildbot to the standard set of build steps.
Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
see if any regressions were spotted, and fail the test if so.

BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:

5:19 PM Changeset in webkit [16795] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Adam.

Layout test fix

kjs/DateMath.cpp: (KJS::dateToDayInYear): accept and correctly handle negative months

4:30 PM Changeset in webkit [22298] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

rdar://problem/4757081
Crashes/hangs when using Flash 8 plugin (Flash 9 works MUCH better)

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Encode javascript URLs before passing them to the plugin.

4:16 PM Changeset in webkit [16794] by aliceli1

2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::setRequestHeader): removed exception set when the request is not open yet

3:57 PM Changeset in webkit [16793] by kmccullo

2 edits in trunk/JavaScriptCore

build fix

kjs/DateMath.cpp: (KJS::dateToDayInYear):

3:27 PM Changeset in webkit [16792] by brmorris

24 edits
10 adds in S60/branches/scriptable_plugins/JavaScriptCore

Landing initial version of scriptable plugins support (part 2 of 2).

3:26 PM Changeset in webkit [16791] by brmorris

24 edits
5 adds in S60/branches/scriptable_plugins

Landing scriptable plugins support (part 1 of 2).

3:25 PM Changeset in webkit [16790] by bdash

2 edits in trunk/JavaScriptCore

2006-10-05 Mark Rowe <bdash@webkit.org>

Reviewed by maculloch.

Gdk build fix.

JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.

3:17 PM Changeset in webkit [16789] by brmorris

1 copy in S60/branches/scriptable_plugins

New feature branch created from r16325.

3:14 PM Changeset in webkit [22297] by adele

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Fix for <rdar://problem/4762933> When typing past the end of a text field, the field doesn't auto-scroll to display the active caret

Reveal the selection after inserting text.

WebView.cpp: (WebViewWndProc):

3:13 PM WikiRestructuredText edited by trac

(diff)

3:13 PM TracTicketsCustomFields edited by trac

(diff)

3:13 PM TracNotification edited by trac

(diff)

3:13 PM TracRepositoryAdmin created by trac

3:13 PM TracFastCgi edited by trac

(diff)

3:13 PM TracIni edited by trac

(diff)

3:13 PM TracPermissions edited by trac

(diff)

3:13 PM TracTickets edited by trac

(diff)

3:13 PM TracUpgrade edited by trac

(diff)

3:13 PM TracWiki edited by trac

(diff)

3:13 PM TracImport edited by trac

(diff)

3:13 PM TracRoadmap edited by trac

(diff)

3:13 PM SandBox edited by trac

(diff)

3:13 PM TracReports edited by trac

(diff)

3:13 PM WikiMacros edited by trac

(diff)

3:13 PM TracInterfaceCustomization edited by trac

(diff)

3:13 PM TracModPython edited by trac

(diff)

3:13 PM TracFineGrainedPermissions edited by trac

(diff)

3:13 PM TracSyntaxColoring edited by trac

(diff)

3:13 PM TracSupport edited by trac

(diff)

3:13 PM TracUnicode edited by trac

(diff)

3:13 PM TracSearch edited by trac

(diff)

3:13 PM TracTimeline edited by trac

(diff)

3:13 PM InterTrac edited by trac

(diff)

3:13 PM TracQuery edited by trac

(diff)

3:13 PM TracLogging edited by trac

(diff)

3:13 PM TracBrowser edited by trac

(diff)

3:13 PM PageTemplates edited by trac

(diff)

3:13 PM WikiProcessors edited by trac

(diff)

3:13 PM TracLinks edited by trac

(diff)

3:13 PM TracEnvironment edited by trac

(diff)

3:13 PM TracStandalone edited by trac

(diff)

3:13 PM TracModWSGI created by trac

3:13 PM WikiDeletePage edited by trac

(diff)

3:13 PM WikiHtml edited by trac

(diff)

3:13 PM TracInstall edited by trac

(diff)

3:13 PM TracCgi edited by trac

(diff)

3:13 PM TracPlugins edited by trac

(diff)

3:13 PM TracRevisionLog edited by trac

(diff)

3:13 PM TracChangeset edited by trac

(diff)

3:13 PM WikiFormatting edited by trac

(diff)

3:13 PM TracWorkflow edited by trac

(diff)

3:13 PM TracAdmin edited by trac

(diff)

3:13 PM TracNavigation edited by trac

(diff)

3:13 PM TracGuide edited by trac

(diff)

3:13 PM InterWiki edited by trac

(diff)

3:13 PM TracBackup edited by trac

(diff)

3:13 PM CamelCase edited by trac

(diff)

3:13 PM WikiPageNames edited by trac

(diff)

3:13 PM TracRss edited by trac

(diff)

3:13 PM WikiRestructuredTextLinks edited by trac

(diff)

3:13 PM TracAccessibility edited by trac

(diff)

2:27 PM Changeset in webkit [16788] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by aroben

build fix

JavaScriptCore.xcodeproj/project.pbxproj:

2:11 PM Changeset in webkit [16787] by bdash

2 edits in trunk/JavaScriptCore

2006-10-04 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Mitz.

Fix Qt/Linux build by adding DateMath.cpp to compilation.

CMakeLists.txt: Also replace tabs with spaces.

2:08 PM Changeset in webkit [16786] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by DethBakin.

Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not. I hope this fixes the build but I cann't be sure on my system.

kjs/DateMath.cpp: (KJS::msToYear): (KJS::dayInYear): (KJS::dateToDayInYear):

1:44 PM Changeset in webkit [16785] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Mitz Pettel!

Bug 10708: [Drosera] Make the console input plaintext-only
http://bugs.webkit.org/show_bug.cgi?id=10708

Change the console input -webkit-user-modify property to
read-write-plaintext-only.

Drosera/console.css:

1:40 PM Changeset in webkit [22296] by darin

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

platform/win/NotImplemented.h: Changed implementation to use Assertions.h. Also fixed both macros to be single-statement macros.

1:37 PM Changeset in webkit [16784] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 10473: [Drosera] Overlapping text in JavaScript Console
http://bugs.webkit.org/show_bug.cgi?id=10473

Using min-height instead of height to avoid overlapping text.

ChangeLog:
Drosera/console.css:

1:35 PM Changeset in webkit [16783] by kmccullo

3 edits in trunk/JavaScriptCore

Reviewed by Adam.

wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.

1:34 PM Changeset in webkit [16782] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Adam.

wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.

11:37 AM Changeset in webkit [16781] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Tim H.

Added a bash-style command history.

Drosera/console.js:

11:36 AM Changeset in webkit [16780] by kmccullo

6 edits
2 adds in trunk/JavaScriptCore

Reviewed by GGaren

This is a big makeover for our Date implemenetation. This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code. The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/DateMath.cpp: Added. (KJS::): (KJS::daysInYear): (KJS::daysFrom1970ToYear): (KJS::msFrom1970ToYear): (KJS::msToDays): (KJS::msToYear): (KJS::isLeapYear): (KJS::isInLeapYear): (KJS::dayInYear): (KJS::msToMilliseconds): (KJS::msToWeekDay): (KJS::msToSeconds): (KJS::msToMinutes): (KJS::msToHours): (KJS::msToMonth): (KJS::msToDayInMonth): (KJS::monthToDayInYear): (KJS::timeToMseconds): (KJS::dateToDayInYear): (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::localTimeToUTC): (KJS::UTCToLocalTime): (KJS::dateToMseconds): (KJS::msToTM): (KJS::isDST):
kjs/DateMath.h: Added. (KJS::):
kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
kjs/testkjs.cpp:
os-win32/stdint.h:

11:34 AM Changeset in webkit [22295] by darin

7 edits
2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

fix <rdar://problem/4764253> frame targeting not implemented.

bridge/win/FrameWin.h: Added new window boolean to openURL. Also changed type from DeprecatedString to String.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Added logic to do frame targeting.

platform/win/BString.h: Added. Convenience for working with BSTR and handling allocation/free.
platform/win/BString.cpp: Added.
WebCore.vcproj/WebCore.vcproj: Added new files.

WebKitWin:

Reviewed by Adam.

fix <rdar://problem/4764253> frame targeting not implemented.

WebFrame.h: Added newWindow parameter to openURL and changed the URL parameter to a String.
WebFrame.cpp: (WebFrame::openURL): Changed code to use BString to convert the String to a BSTR. Also respect the newWindow parameter and changed the new window code slightly, adding a FIXME.

11:04 AM Changeset in webkit [16779] by andersca

2 edits in trunk/WebCore

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4654328>
Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off

loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.

1:43 AM Changeset in webkit [16778] by hyatt

1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:39 AM Changeset in webkit [16777] by hyatt

1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:26 AM Changeset in webkit [16776] by hyatt

2 edits in trunk/WebCore/platform

Fix more win32 and qt bustage.

1:21 AM Changeset in webkit [16775] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:19 AM Changeset in webkit [16774] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:11 AM Changeset in webkit [16773] by hyatt

1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:10 AM Changeset in webkit [16772] by hyatt

1 edit in trunk/WebCore/platform/qt/TemporaryLinkStubs.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [16771] by hyatt

1 edit in trunk/WebCore/platform/gdk/WidgetGdk.cpp

Fix Gdk bustage.

1:06 AM Changeset in webkit [16770] by hyatt

2 edits in trunk/WebCore/platform/qt

Fix Qt bustage.

1:05 AM Changeset in webkit [16769] by hyatt

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:53 AM Changeset in webkit [16768] by hyatt

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:52 AM Changeset in webkit [16767] by hyatt

2 edits in trunk/WebCore/platform/win

Fix Win32 bustage.

12:22 AM Changeset in webkit [22294] by hyatt

4 edits in branches/WindowsMerge/WebKitWin

Fix the textfield caret by not doing layouts every time we paint.

Oct 3, 2006:

9:50 PM Changeset in webkit [22293] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/WidgetWin.cpp

Move function into WidgetWin.cpp, since I made it windows only but had left it in Widget.cpp (breaking mac)

9:45 PM Changeset in webkit [16766] by hyatt

1 edit in trunk/WebCore/platform/Widget.cpp

Fix mac build bustage.

9:34 PM Changeset in webkit [16765] by ap

5 edits in trunk

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=11130
Convert "undefined" to AE missing value

WebCore:

bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:

fast/AppleScript/001-expected.txt:
fast/AppleScript/array-expected.txt: Updated the results.

9:26 PM Changeset in webkit [22292] by hyatt

7 edits in branches/WindowsMerge/WebCore

Land the new scrollview.

9:26 PM Changeset in webkit [22291] by hyatt

4 edits in branches/WindowsMerge/WebKitWin

Improve painting to not always use the unioned invalidation rect.

9:22 PM Changeset in webkit [16764] by hyatt

18 edits in trunk/WebCore

Scrolling work.

8:36 PM Changeset in webkit [16763] by bdash

2 edits in trunk/WebKit

2006-10-04 Mark Rowe <bdash@webkit.org>

Reviewed by NOBODY (build fix).

WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.

7:51 PM Changeset in webkit [16762] by bdash

2 edits in trunk

Update bug URLs in the two patches that I just landed.

7:46 PM Changeset in webkit [16761] by bdash

6 edits in trunk

2006-09-26 David Smith <catfish.man@gmail.com>

Reviewed by Timothy.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

No automated tests are possible as this code path isn't reachable from JavaScript.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):

2006-09-26 David Smith <catfish.man@gmail.com>

Reviewed by Timothy.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]):
WebView/WebViewPrivate.h:

7:31 PM Changeset in webkit [16760] by bdash

13 edits in trunk

2006-10-03 Graham Dennis <graham.dennis@gmail.com>

Reviewed by Timothy.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand

Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

AlwaysLive: Safari 2.0 behaviour
OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

bridge/mac/WebCoreSettings.h:
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]): (-[WebCoreSettings editableLinkBehavior]):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
html/HTMLAnchorElement.h:
manual-tests/contenteditable-link.html:
page/FrameView.cpp: (WebCore::nodeIsNotBeingEdited): (WebCore::selectCursor):
page/Settings.h: (WebCore::Settings::): (WebCore::Settings::Settings): (WebCore::Settings::editableLinkBehavior): (WebCore::Settings::setEditableLinkBehavior):

2006-10-03 Graham Dennis <graham.dennis@gmail.com>

Reviewed by Timothy.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand

Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

AlwaysLive: Safari 2.0 behaviour
OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setEditableLinkBehavior:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

6:28 PM Changeset in webkit [22290] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Improvements to error handling in PluginStreamWin.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::deliverData): Fail quietly if called after termination (due to bad error handling in ResourceLoaderWin), ASSERT if called before stream has been started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.

6:12 PM Changeset in webkit [16759] by bdakin

3 edits in trunk/WebCore

Reviewed Darin.

No test cases needed.

Implemented a version of StringImpl::append that takes a UChar* and
a length.

platform/StringImpl.cpp: (WebCore::StringImpl::append): (WebCore::StringImpl::insert): Call new append instead of making a new StringImpl.
platform/StringImpl.h:

6:10 PM Changeset in webkit [16758] by andersca

2 edits in trunk/WebKitTools

2006-10-03 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam and Brady.

DumpRenderTree/DumpRenderTree.m: (main): Update URL to Ahem.ttf

6:09 PM Changeset in webkit [16757] by bdash

2 edits in trunk/WebCore

2006-10-03 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onHandleCreated):

5:42 PM Changeset in webkit [22289] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4760963>
Failed ASSERT in PluginStreamWin::~PluginStreamWin at espn.com

We now store the state of a stream as a tri-state enum in
m_streamState. This allows us to differentiate between before and after the
stream has been started.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): Initialize members of m_stream struct individually. (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): Return early if the stream isn't started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
plugins/win/PluginStreamWin.h: (WebCore::): Add PluginStreamState enum.

4:50 PM Changeset in webkit [16756] by thatcher

5 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for bug 4671286 (r16737).

4:48 PM Changeset in webkit [16755] by thatcher

2 edits in tags/WebCore-521.28.1/WebCore

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

4:46 PM Changeset in webkit [16754] by thatcher

3 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for 4717965 and 4712111 (r16567).

4:28 PM Changeset in webkit [16753] by thatcher

1 edit in tags/WebCore-521.28.1/WebCore/Info.plist

Versioning

4:28 PM Changeset in webkit [16752] by justing

7 edits
8 adds in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/paste-1-expected.checksum: Added.
editing/execCommand/paste-1-expected.png: Added.
editing/execCommand/paste-1-expected.txt: Added.
editing/execCommand/paste-1.html: Added.
editing/execCommand/paste-2-expected.checksum: Added.
editing/execCommand/paste-2-expected.png: Added.
editing/execCommand/paste-2-expected.txt: Added.
editing/execCommand/paste-2.html: Added.

WebKit:

Reviewed by harrison

execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView. (-[WebFrameBridge issueCopyCommand]): Ditto. (-[WebFrameBridge issuePasteCommand]): Ditto. (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto. (-[WebFrameBridge issueTransposeCommand]): Fixed formatting. (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
WebView/WebHTMLView.m: (-[WebHTMLView copy:]): Moved to WebInternal (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView pasteAsPlainText:]): Ditto.
WebView/WebHTMLViewInternal.h:
WebView/WebView.m: Removed the now unused _canPaste.
WebView/WebViewInternal.h: Ditto.

4:25 PM Changeset in webkit [16751] by thatcher

1 copy in tags/WebCore-521.28.1/WebCore

New tag part 2.

4:24 PM Changeset in webkit [16750] by thatcher

1 add in tags/WebCore-521.28.1

New tag.

4:24 PM Changeset in webkit [16749] by thatcher

1 delete in WebCore-521.28.1

Bad tag.

4:23 PM Changeset in webkit [16748] by thatcher

1 add in WebCore-521.28.1

New tag.

4:19 PM Changeset in webkit [16747] by bdakin

9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these two counters tests so they pass on the BuildBot.

fast/css/counters/counter04-expected.checksum:
fast/css/counters/counter04-expected.png:
fast/css/counters/counter04-expected.txt:
fast/css/counters/counter04.html:
fast/css/counters/counters04-expected.checksum:
fast/css/counters/counters04-expected.png:
fast/css/counters/counters04-expected.txt:
fast/css/counters/counters04.html:

4:00 PM Changeset in webkit [16746] by justing

4 edits in trunk/LayoutTests

Reviewed by geoff

Fixed a typo, updating expected results.

editing/execCommand/create-list-with-hr-expected.checksum:
editing/execCommand/create-list-with-hr-expected.png:
editing/execCommand/create-list-with-hr-expected.txt:

4:00 PM Changeset in webkit [16745] by ggaren

6 edits in trunk/WebCore

Feared, loathed, reviewed by Darin.

More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
into FRAME, plus other cleanup.

No new behavior, so no new test. Layout tests pass. Basic browsing and
Mail editing seem to work.

dom/Node.cpp: (WebCore::Node::detach): Removed random commented-out code.
html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): (1) Removed reference to FrameView, to dissociate frame loading from rendering. (2) Renamed newURL to completeURL because the difference between newURL and URLString is that newURL is a KURL that is the complete version of URLString, not that it is new. (WebCore::HTMLFrameElement::willRemove): (1) Removed close() call and moved close() code into willRemove(), also removing close() call from detach(), since willRemove is the well-defined place from DOM tear-down, not detach(). (2) Removed manual renderer detach code because the DOM is not responsible for managing the render tree. I confirmed that this change not regress <rdar://problem/4132581>. (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements lost their content frames after being removed from the DOM. That's our current behavior, but it's going to change in future rounds of refactoring. This also fixes <rdar://problem/4750835>. (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to attach/detach, because the render tree should not be in charge of deciding when to load.
html/HTMLFrameElement.h:
html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject, because the renderer is a renderPartObject, not a renderPart.
html/HTMLIFrameElement.h:

3:46 PM Changeset in webkit [16744] by darin

2 edits in trunk/WebKitTools

Scripts/commit-log-editor: Added missing "close" call. Oops!

3:14 PM Changeset in webkit [16743] by bdash

2 edits in trunk/WebCore

2006-10-03 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11137
Bug 11137: GdkLauncher dies with "pure virtual method called" if
window is closed while page still loading

platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual methods to be called before the FrameGdk portion of "this" is torn down.

2:53 PM Changeset in webkit [16742] by justing

2 edits in trunk/WebKit

Reviewed by geoff

<rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load

Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Enable multipart/x-mixed-replace support on the request. This line was accidently removed during some loader refactoring.

2:10 PM Changeset in webkit [22288] by aroben

8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Fixes <rdar://problem/4603342>
Keyboard navigability

Implement tabbing between form elements (in the single-frame case).

bridge/win/FrameWin.cpp: Add methods to determine tabbing preferences. (WebCore::FrameWin::tabsToLinks): (WebCore::FrameWin::tabsToAllControls):
bridge/win/FrameWin.h: Add tabsToLinks() to FrameWinClient
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollPointRecursively): Implemented for single-frame case.
platform/win/TemporaryLinkStubs.cpp: Remove stub for now-implemented ScrollView::scrollPointsRecursively

WebKitWin:

Reviewed by Darin.

Part of fix for <rdar://problem/4603342>
Keyboard navigability

Implement methods to determine tabbing preferences.

WebFrame.cpp: (WebFrame::tabsToLinks):
WebFrame.h:

2:09 PM Changeset in webkit [16741] by aroben

4 edits in trunk/WebCore

Reviewed by Darin.

Handle tab key presses in the DOM.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Rename and reimplement focusNextPrevNode. Now we just call Element::focus().
page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make it public.

12:01 PM Changeset in webkit [16740] by justing

2 edits in trunk/WebCore

Reviewed by mjs

<rdar://problem/4760612>
TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints

No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.

dom/Range.cpp: (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming positions are non-null since most of it's callers would be in a bad state if the positions were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception. Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it from entering compareBoundaryPoints and hitting the assert.

11:55 AM Changeset in webkit [16739] by adele

2 edits in trunk/WebCore

Reviewed by Geoff.

Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):

11:18 AM Changeset in webkit [16738] by darin

2 edits in trunk/WebCore

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=11132 Caret disappears when you're typing

editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Remove unnecessary call to clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this. (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout to false so we can get the old caret repaint rect. Later we need to change the design so getting the rect doesn't have a side effect of causing a layout without invalidation.

11:16 AM Changeset in webkit [22287] by darin

2 edits in branches/WindowsMerge/WebKitWin

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Adam.

WebView.cpp: (WebView::handleMouseEvent): Pass message when creating a PlatformMouseEvent.

7:44 AM Changeset in webkit [16737] by harrison

10 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test so that it actually shows the caret rect for the caret position.
Before, it was showing the caret rect for the 9th character of the test description.

fast/text/justified-text-rect-expected.checksum:
fast/text/justified-text-rect-expected.png:
fast/text/justified-text-rect-expected.txt:
fast/text/justified-text-rect.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test:

fast/text/justified-text-rect.html

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): Make the selection's root editable element (or the document itself) be the basis for NSRange conversions. This supports "shadow DOM" like that for text fields and text areas.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass the document element as the scope.

editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Make the first parameter the scope.

editing/TextIterator.h: Make the first parameter of rangeFromLocationAndLength() the scope.

5:14 AM Changeset in webkit [16736] by eseidel

4 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Offer a way for BuildBot to not colorize the cmake output, when building
with the 'build-webkit' script. Add "--color" / "--no-color" option pair.

Default is colorize output, though only Qt platform handles this for now.

Scripts/build-dumprendertree:
Scripts/build-webkit:
Scripts/webkitdirs.pm:

3:49 AM Changeset in webkit [16735] by eseidel

5 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Make all important scripts work with Qt/Linux.

You can safely use this now:
set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests

Scripts/build-dumprendertree:
Scripts/run-javascriptcore-tests:
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

2:46 AM Changeset in webkit [16734] by bdash

4 edits in trunk

2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric.

build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).

Scripts/webkitdirs.pm:

2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric.

Fix Qt/Linux build.

CMakeLists.txt: Add counter related files.

2:42 AM Changeset in webkit [16733] by bdash

9 edits
1 add in trunk

2006-10-03 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

Stop Bakefile-generated Makefile from running `pkg-config' multiple times per file.

presets.bkl: Make use of "options" and Python commands to run pkg-config etc up front.

2006-10-03 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=10981
Linux/GDK build fixes

Based on a patch by Krzysztof Kowalczyk.

WebCoreSources.bkl:
platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::handleGdkEvent):
platform/gdk/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
platform/gdk/ScrollViewGdk.cpp:
platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passWheelEventToSubframe): (Cursor::Cursor): (Widget::invalidate): (Widget::invalidateRect): (ScrollView::wheelEvent): (ScrollView::convertToContainingWindow): (ScrollView::convertFromContainingWindow): (GraphicsContext::clip): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::updateThumbPosition): (PlatformScrollBar::updateThumbProportion): (ScrollBar::ScrollBar): (ScrollBar::setProportion): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/gdk/WidgetGdk.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):

Oct 2, 2006:

9:38 PM Changeset in webkit [16732] by aroben

3 edits in trunk/WebKit

Reviewed by Maciej.

(Forgot this in previous checkin)

Add message paramter to WebView::mouse* methods to pass down to
PlatformMouseEvent.

COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): (WebViewWndProc):
COM/WebView.h:

9:35 PM Changeset in webkit [22286] by aroben

2 edits in branches/WindowsMerge/WebKitWin

WebKit.vcproj/WebKit.vcproj:

9:29 PM Changeset in webkit [22285] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fixes <rdar://problem/4743497>
Can't check checkboxes

Let Windows determine which mouse button is pressed.

platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message parameter to determine which mouse button is pressed.

9:26 PM Changeset in webkit [16731] by aroben

3 edits in trunk/WebCore

Reviewed by Maciej.

Let Windows determine which mouse button is pressed.

platform/PlatformMouseEvent.h: Add message parameter to constructor.
platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message parameter to determine which mouse button is pressed.

7:00 PM Changeset in webkit [16730] by mjs

8 edits in trunk/WebKit

Reviewed by Alice.

take away direct knowledge of WebFrame from WebDataSource

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setFrameLoader:]): (-[WebDocumentLoadState detachFromFrameLoader]):
Loader/WebFrameLoader.m: (-[WebFrameLoader _setDocumentLoadState:]): (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
WebView/WebDataSource.m:
WebView/WebDataSourceInternal.h:
WebView/WebDocumentLoadStateMac.m: (-[WebDocumentLoadStateMac detachFromFrameLoader]):
WebView/WebFrame.m: (-[WebFrame _loadDataSource:withLoadType:formState:]):

6:38 PM Changeset in webkit [16729] by justing

3 edits in trunk/WebCore

Reviewed by anders

Build fix

editing/SelectionController.cpp: (WebCore::SelectionController::empty):
editing/SelectionController.h:

6:08 PM Changeset in webkit [16728] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by john

editing/execCommand/create-list-with-hr-expected.checksum: Added.
editing/execCommand/create-list-with-hr-expected.png: Added.
editing/execCommand/create-list-with-hr-expected.txt: Added.
editing/execCommand/create-list-with-hr.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4755287>
Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element

editing/markup.cpp: (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced elements). Don't skip blocks that aren't containers (like horizontal rules).

6:06 PM Changeset in webkit [16727] by darin

5 edits in trunk/WebCore

2006-10-03 Darin Adler <Darin Adler>

Reviewed by Justin Garcia.

correct mistaken code that would restart blinking every time "invalidateSelection" is called even if the caret has not moved

editing/SelectionController.h:
editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Update for name change. (WebCore::SelectionController::recomputeCaretRect): New function. Computes caret rect and does any necessary invalidation if the rect changes. (WebCore::SelectionController::invalidateCaretRect): Renamed from needsCaretRepaint. Invalidates the caret rect unconditionally. Also calls recomputeCaretRect as a side effect.

page/Frame.cpp: (WebCore::Frame::invalidateSelection): Remove unneeded call to clearCaretRectIfNeeded. (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change. (WebCore::Frame::selectionLayoutChanged): Restructured to use the new recomputeCaretRect function and not restart blinking if caret has not changed position. (WebCore::Frame::caretBlinkTimerFired): Removed some checks that are not needed since selectionLayoutChanged already checks these.

page/FramePrivate.h: Removed unused m_blinkCaret.

6:05 PM Changeset in webkit [16726] by bdakin

2 edits in trunk/WebCore

Reviewed by Adam.

Build fix. Add counters to vcproj.

WebCore.vcproj/WebCore/WebCore.vcproj:

5:51 PM Changeset in webkit [22284] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage on win32 caused by counters checkin.

5:38 PM Changeset in webkit [22283] by sfalken

5 edits in branches/WindowsMerge

2006-10-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff, Hyatt.

<rdar://4757389> Browser locks up while navigating to a new page
<rdar://4757407> Images fail to load at https://webmail.apple.com

WebFrame.cpp: Preserve old document until new doc has started loading. (WebFrame::loadDataSource): Don't destroy old document when a new load kicks off. (WebFrame::receivedResponse): Destroy old document when first data is received for new doc.
WebView.cpp: Fix painting suppression code. (WebViewWndProc): Suppress painting, mouse events until first layout instead of while loading.

2006-10-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Hyatt.

<rdar://4757387> (partial fix) Unable to sign on to my.yahoo.com
<rdar://4757405> (partial fix) Unable to log onto secure site (www.schwab.com)
<rdar://4757411> (partial fix) Unable to log onto any AppleConnect site (but using back and resubmiting works)

WinInet fixes.
Don't post data using HTTP when HTTPS should be used.
Fix redirect from POST to GET case.

There is a remaining bug with the way that we queue WinInet callbacks
still to be addressed.

platform/win/ResourceLoaderWin.cpp: (WebCore::addToOutstandingJobs): Skip dwContext of 0 (rollover case). (WebCore::ResourceLoaderWndProc): Call default wndproc properly.

Pass INTERNET_FLAG_SECURE when necessary for HTTPS.
Fix redirect code.
Initialize buffers struct.
Pass proper context in InternetReadFileExA

(WebCore::initializeOffScreenResourceLoaderWindow): Init a struct to {0} instead of using memset.
(WebCore::transferJobStatusCallback): Prevent future bugs by making an else a bit more explicit.
(WebCore::ResourceLoader::start): Pass proper port for HTTP vs. HTTPS.
(WebCore::ResourceLoader::cancel): Zero out handle when closing.

4:54 PM Changeset in webkit [16725] by mjs

12 edits in trunk/WebKit

Reviewed by Darin.

move a big slice of data and logic from WebDataSource to WebDocumentLoadState

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState initWithRequest:]): (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState originalRequestCopy]): (-[WebDocumentLoadState request]): (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]): (-[WebDocumentLoadState setRequest:]): (-[WebDocumentLoadState setResponse:]): (-[WebDocumentLoadState isStopping]): (-[WebDocumentLoadState bridge]): (-[WebDocumentLoadState setMainDocumentError:]): (-[WebDocumentLoadState mainDocumentError]): (-[WebDocumentLoadState clearErrors]): (-[WebDocumentLoadState mainReceivedError:complete:]): (-[WebDocumentLoadState stopLoading]): (-[WebDocumentLoadState setupForReplace]): (-[WebDocumentLoadState commitIfReady]): (-[WebDocumentLoadState finishedLoading]): (-[WebDocumentLoadState setCommitted:]): (-[WebDocumentLoadState isCommitted]): (-[WebDocumentLoadState setLoading:]): (-[WebDocumentLoadState isLoading]): (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoadState receivedData:]): (-[WebDocumentLoadState setupForReplaceByMIMEType:]): (-[WebDocumentLoadState updateLoading]): (-[WebDocumentLoadState response]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader activeDocumentLoadState]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _archivedSubresourceForURL:]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader documentLoadState]): (-[WebFrameLoader provisionalDocumentLoadState]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrameLoader finishedLoadingDocumentLoadState:]): (-[WebFrameLoader commitProvisitionalLoad]): (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]): (-[WebFrameLoader documentLoadState:setMainDocumentError:]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _finishedLoading]): (-[WebDataSource _receivedData:]): (-[WebDataSource _setMainDocumentError:]): (-[WebDataSource _clearUnarchivingState]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _setTitle:]): (-[WebDataSource _initWithDocumentLoadState:]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource isLoading]): (-[WebDataSource webArchive]):
WebView/WebDataSourceInternal.h:
WebView/WebDocumentLoadStateMac.m: (-[WebDocumentLoadStateMac initWithRequest:]):
WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _provisionalLoadStarted]):
WebView/WebFrameInternal.h:

4:51 PM Changeset in webkit [16724] by beidson

2 edits in trunk/WebCore

Reviewed by Adele

If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
icon data out because we don't correctly check SQL error conditions.

loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase):

4:36 PM Changeset in webkit [16723] by sfalken

3 edits in trunk/WebCore

2006-10-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Hyatt.

Added method to find out whether a layout has occurred.

page/FrameView.cpp: (WebCore::FrameView::didFirstLayout):
page/FrameView.h:

4:25 PM Changeset in webkit [16722] by bdakin

1 edit
153 adds in trunk/LayoutTests

Minor harassment followed by abject surrender provided by ggggaren.

Tests for counters.

fast/css/counters/contentNone-expected.checksum: Added.
fast/css/counters/contentNone-expected.png: Added.
fast/css/counters/contentNone-expected.txt: Added.
fast/css/counters/contentNone.html: Added.
fast/css/counters/counter00-expected.checksum: Added.
fast/css/counters/counter00-expected.png: Added.
fast/css/counters/counter00-expected.txt: Added.
fast/css/counters/counter00.html: Added.
fast/css/counters/counter01-expected.checksum: Added.
fast/css/counters/counter01-expected.png: Added.
fast/css/counters/counter01-expected.txt: Added.
fast/css/counters/counter01.html: Added.
fast/css/counters/counter02-expected.checksum: Added.
fast/css/counters/counter02-expected.png: Added.
fast/css/counters/counter02-expected.txt: Added.
fast/css/counters/counter02.html: Added.
fast/css/counters/counter03-expected.checksum: Added.
fast/css/counters/counter03-expected.png: Added.
fast/css/counters/counter03-expected.txt: Added.
fast/css/counters/counter03.html: Added.
fast/css/counters/counter04-expected.checksum: Added.
fast/css/counters/counter04-expected.png: Added.
fast/css/counters/counter04-expected.txt: Added.
fast/css/counters/counter04.html: Added.
fast/css/counters/counter05-expected.checksum: Added.
fast/css/counters/counter05-expected.png: Added.
fast/css/counters/counter05-expected.txt: Added.
fast/css/counters/counter05.html: Added.
fast/css/counters/counter06-expected.checksum: Added.
fast/css/counters/counter06-expected.png: Added.
fast/css/counters/counter06-expected.txt: Added.
fast/css/counters/counter06.html: Added.
fast/css/counters/counter07-expected.checksum: Added.
fast/css/counters/counter07-expected.png: Added.
fast/css/counters/counter07-expected.txt: Added.
fast/css/counters/counter07.html: Added.
fast/css/counters/counter08-expected.checksum: Added.
fast/css/counters/counter08-expected.png: Added.
fast/css/counters/counter08-expected.txt: Added.
fast/css/counters/counter08.html: Added.
fast/css/counters/counter09-expected.checksum: Added.
fast/css/counters/counter09-expected.png: Added.
fast/css/counters/counter09-expected.txt: Added.
fast/css/counters/counter09.html: Added.
fast/css/counters/counter10-expected.checksum: Added.
fast/css/counters/counter10-expected.png: Added.
fast/css/counters/counter10-expected.txt: Added.
fast/css/counters/counter10.html: Added.
fast/css/counters/counter11-expected.checksum: Added.
fast/css/counters/counter11-expected.png: Added.
fast/css/counters/counter11-expected.txt: Added.
fast/css/counters/counter11.html: Added.
fast/css/counters/counter12-expected.checksum: Added.
fast/css/counters/counter12-expected.png: Added.
fast/css/counters/counter12-expected.txt: Added.
fast/css/counters/counter12.html: Added.
fast/css/counters/counter13-expected.checksum: Added.
fast/css/counters/counter13-expected.png: Added.
fast/css/counters/counter13-expected.txt: Added.
fast/css/counters/counter13.html: Added.
fast/css/counters/counter14-expected.checksum: Added.
fast/css/counters/counter14-expected.png: Added.
fast/css/counters/counter14-expected.txt: Added.
fast/css/counters/counter14.html: Added.
fast/css/counters/counter15-expected.checksum: Added.
fast/css/counters/counter15-expected.png: Added.
fast/css/counters/counter15-expected.txt: Added.
fast/css/counters/counter15.html: Added.
fast/css/counters/counter16-expected.checksum: Added.
fast/css/counters/counter16-expected.png: Added.
fast/css/counters/counter16-expected.txt: Added.
fast/css/counters/counter16.html: Added.
fast/css/counters/counters00-expected.checksum: Added.
fast/css/counters/counters00-expected.png: Added.
fast/css/counters/counters00-expected.txt: Added.
fast/css/counters/counters00.html: Added.
fast/css/counters/counters01-expected.checksum: Added.
fast/css/counters/counters01-expected.png: Added.
fast/css/counters/counters01-expected.txt: Added.
fast/css/counters/counters01.html: Added.
fast/css/counters/counters02-expected.checksum: Added.
fast/css/counters/counters02-expected.png: Added.
fast/css/counters/counters02-expected.txt: Added.
fast/css/counters/counters02.html: Added.
fast/css/counters/counters03-expected.checksum: Added.
fast/css/counters/counters03-expected.png: Added.
fast/css/counters/counters03-expected.txt: Added.
fast/css/counters/counters03.html: Added.
fast/css/counters/counters04-expected.checksum: Added.
fast/css/counters/counters04-expected.png: Added.
fast/css/counters/counters04-expected.txt: Added.
fast/css/counters/counters04.html: Added.
fast/css/counters/counters05-expected.checksum: Added.
fast/css/counters/counters05-expected.png: Added.
fast/css/counters/counters05-expected.txt: Added.
fast/css/counters/counters05.html: Added.
fast/css/counters/counters06-expected.checksum: Added.
fast/css/counters/counters06-expected.png: Added.
fast/css/counters/counters06-expected.txt: Added.
fast/css/counters/counters06.html: Added.
fast/css/counters/counters07-expected.checksum: Added.
fast/css/counters/counters07-expected.png: Added.
fast/css/counters/counters07-expected.txt: Added.
fast/css/counters/counters07.html: Added.
fast/css/counters/counters08-expected.checksum: Added.
fast/css/counters/counters08-expected.png: Added.
fast/css/counters/counters08-expected.txt: Added.
fast/css/counters/counters08.html: Added.
fast/css/counters/counters09-expected.checksum: Added.
fast/css/counters/counters09-expected.png: Added.
fast/css/counters/counters09-expected.txt: Added.
fast/css/counters/counters09.html: Added.
fast/css/counters/counters10-expected.checksum: Added.
fast/css/counters/counters10-expected.png: Added.
fast/css/counters/counters10-expected.txt: Added.
fast/css/counters/counters10.html: Added.
fast/css/counters/counters11-expected.checksum: Added.
fast/css/counters/counters11-expected.png: Added.
fast/css/counters/counters11-expected.txt: Added.
fast/css/counters/counters11.html: Added.
fast/css/counters/counters12-expected.checksum: Added.
fast/css/counters/counters12-expected.png: Added.
fast/css/counters/counters12-expected.txt: Added.
fast/css/counters/counters12.html: Added.
fast/css/counters/counters13-expected.checksum: Added.
fast/css/counters/counters13-expected.png: Added.
fast/css/counters/counters13-expected.txt: Added.
fast/css/counters/counters13.html: Added.
fast/css/counters/counters14-expected.checksum: Added.
fast/css/counters/counters14-expected.png: Added.
fast/css/counters/counters14-expected.txt: Added.
fast/css/counters/counters14.html: Added.
fast/css/counters/counters15-expected.checksum: Added.
fast/css/counters/counters15-expected.png: Added.
fast/css/counters/counters15-expected.txt: Added.
fast/css/counters/counters15.html: Added.
fast/css/counters/counters18-expected.checksum: Added.
fast/css/counters/counters18-expected.png: Added.
fast/css/counters/counters18-expected.txt: Added.
fast/css/counters/counters18.html: Added.
fast/css/counters/implied00-expected.checksum: Added.
fast/css/counters/implied00-expected.png: Added.
fast/css/counters/implied00-expected.txt: Added.
fast/css/counters/implied00.html: Added.
fast/css/counters/root-expected.checksum: Added.
fast/css/counters/root-expected.png: Added.
fast/css/counters/root-expected.txt: Added.
fast/css/counters/root.html: Added.
fast/css/counters/visibilityNone-expected.checksum: Added.
fast/css/counters/visibilityNone-expected.png: Added.
fast/css/counters/visibilityNone-expected.txt: Added.
fast/css/counters/visibilityNone.html: Added.

4:15 PM Changeset in webkit [16721] by bdakin

17 edits
7 adds in trunk/WebCore

Reviewed by Darin.

Initial implementation of CSS2 counters. See http://
bugs.webkit.org/show_bug.cgi?id=4980 for more details.

WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the increment/reset list now that this is implemented.
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
css/Counter.h: (WebCore::Counter::Counter): (WebCore::Counter::~Counter): (WebCore::Counter::identifier): (WebCore::Counter::listStyle): (WebCore::Counter::separator): (WebCore::Counter::listStyleNumber): (WebCore::Counter::setIdentifier): (WebCore::Counter::setListStyle): (WebCore::Counter::setSeparator):
css/cssparser.cpp: (WebCore::CSSParser::addProperty): Take care of reset/increment (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): content can now take counters (WebCore::CSSParser::parseCounterContent): Parse counter() and counters() (WebCore::CSSParser::parseCounter): Parse counter-reset and counter-increment
css/cssparser.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::applyProperty):
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::insert): Implemented a version of insert that accepts a UChar* and a length.
platform/StringImpl.cpp: (WebCore::StringImpl::insert): Same as above.
platform/StringImpl.h:
rendering/CounterListItem.h: Added.
rendering/CounterNode.cpp: Added. (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::CounterNode::remove): (WebCore::CounterNode::setUsesSeparator): (WebCore::CounterNode::recountAndGetNext): (WebCore::CounterNode::recountTree): (WebCore::CounterNode::setSelfDirty): (WebCore::CounterNode::setParentDirty):
rendering/CounterNode.h: Added. (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::parent): (WebCore::CounterNode::previousSibling): (WebCore::CounterNode::nextSibling): (WebCore::CounterNode::firstChild): (WebCore::CounterNode::lastChild): (WebCore::CounterNode::value): (WebCore::CounterNode::setValue): (WebCore::CounterNode::count): (WebCore::CounterNode::setCount): (WebCore::CounterNode::setHasSeparator): (WebCore::CounterNode::isReset): (WebCore::CounterNode::hasSeparator): (WebCore::CounterNode::willNeedLayout): (WebCore::CounterNode::setWillNeedLayout): (WebCore::CounterNode::isRoot): (WebCore::CounterNode::setRenderer): (WebCore::CounterNode::renderer):
rendering/CounterResetNode.cpp: Added. (WebCore::CounterResetNode::CounterResetNode): (WebCore::CounterResetNode::insertAfter): (WebCore::CounterResetNode::removeChild): (WebCore::CounterResetNode::recountAndGetNext): (WebCore::CounterResetNode::setParentDirty): (WebCore::CounterResetNode::updateTotal):
rendering/CounterResetNode.h: Added. (WebCore::CounterResetNode::firstChild): (WebCore::CounterResetNode::lastChild): (WebCore::CounterResetNode::isReset): (WebCore::CounterResetNode::total):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject): Account for counter content.
rendering/RenderCounter.cpp: Added. (WebCore::RenderCounter::RenderCounter): (WebCore::RenderCounter::layout): (WebCore::toRoman): (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderCounter::convertValueToType): (WebCore::RenderCounter::calcMinMaxWidth):
rendering/RenderCounter.h: Added. (WebCore::RenderCounter::renderName): (WebCore::RenderCounter::isCounter):
rendering/RenderObject.cpp: (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to maps of CounterNodes (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::destroy): Destroy the maps. (WebCore::RenderObject::findCounter): Finds/creates counters.
rendering/RenderObject.h: (WebCore::RenderObject::isCounter):
rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::RenderStyle::arenaDelete): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setContent): (WebCore::ContentData::clearContent): (WebCore::RenderStyle::counterDataEquivalent): (WebCore::hasCounter): (WebCore::RenderStyle::hasCounterReset): (WebCore::RenderStyle::hasCounterIncrement): (WebCore::readCounter): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::counterIncrement):
rendering/RenderStyle.h: (WebCore::StyleVisualData::operator==): (WebCore::CounterData::CounterData): (WebCore::CounterData::identifier): (WebCore::CounterData::listStyle): (WebCore::CounterData::separator): (WebCore::ContentData::contentCounter): (WebCore::ContentData::): (WebCore::RenderStyle::counterIncrement): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::setCounterIncrement): (WebCore::RenderStyle::setCounterReset): (WebCore::RenderStyle::setCounterResetList): (WebCore::RenderStyle::setCounterIncrementList): (WebCore::RenderStyle::counterResetValueList): (WebCore::RenderStyle::counterIncrementValueList):

2:03 PM Changeset in webkit [16720] by aroben

3 edits in trunk/LayoutTests

Reviewed by Tim H.

This change fixes a couple of problems with the window-properties
test. window-properties' output changes depending on the presence or
non-presence of session history (see
http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
reason, the test must always be run as part of a run of ALL layout
tests. The test results checked in were generated from an individual
run of this test, so the buildbots were always failing since they run
all the tests at once.

This change regenerates the results for the test using a full run of
layout tests. The test now also prints out object class names, and
will print an error message when the test is run by itself.

fast/js/window-properties-expected.txt:
fast/js/window-properties.html:

1:44 PM Changeset in webkit [16719] by justing

2 edits in trunk/WebKit

Reviewed by john

<rdar://problem/4757583>
REGRESSION: tabbing into page focuses wrong control on 2nd pass
<rdar://problem/4757594>
REGRESSION: Form field is left with secondary selection after tabbing out of WebView

WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch for 9642. Only leave inactive editable selections in the WebHTMLView if the nextResponder is in the same WebView.

1:30 PM Changeset in webkit [16718] by adele

18 edits
2 adds in trunk

LayoutTests:

Reviewed by Adam.

Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

fast/forms/HTMLOptionElement_label05-expected.checksum:
fast/forms/HTMLOptionElement_label05-expected.png:
fast/forms/HTMLOptionElement_label05-expected.txt:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/form-element-geometry-expected.txt:
fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/option-strip-whitespace-expected.png:
fast/forms/option-strip-whitespace-expected.txt:
fast/forms/password-doubleclick-selection-expected.txt: Added.
fast/forms/password-doubleclick-selection.html: Added.
fast/forms/select-change-popup-to-listbox-expected.checksum:
fast/forms/select-change-popup-to-listbox-expected.png:
fast/forms/select-change-popup-to-listbox-expected.txt:
fast/text/updateNewFont-expected.checksum:
fast/text/updateNewFont-expected.png:
fast/text/updateNewFont-expected.txt:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

There are a few outstanding issues, so I've left the old code in for now. So you can use the old-style listboxes
by using "-webkit-appearance:none".

css/html4.css:

11:48 AM Changeset in webkit [22282] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix: Don't copy WebKit(_debug).dll into $WebKitSDKDir

WebKit.vcproj/WebKit.vcproj: Remove xcopy call

9:46 AM Changeset in webkit [16717] by aroben

2 edits in trunk/WebKitTools/DumpRenderTree

Backing out these accidental commits.

9:33 AM Changeset in webkit [16716] by aroben

7 edits in trunk

2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>

JavaScriptCore:

Reviewed/landed by Adam.

Build testkjs on Qt/Linux.

CMakeLists.txt:

WebKitTools:

Reviewed/landed by Adam.

Proper build-webkit support for Qt/Linux.

Compilation process is similar to OSX now, aka.
the build directory is RootCheckoutDir/WebKitBuild now.

Scripts/build-webkit: Recognize Qt.
Scripts/webkitdirs.pm: Add buildCMakeProject() logic.

8:32 AM Changeset in webkit [16715] by harrison

2 edits in trunk/WebCore

Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
Left the layout test.

rendering/bidi.cpp: (WebCore::checkMidpoints):

8:24 AM Changeset in webkit [16714] by zbujtas

3 edits in S60/trunk/WebKit

2006-10-02 sareen <shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas.
DESC: Include correct path for inc directory for S60 only.
http://bugs.webkit.org/show_bug.cgi?id=11122

group/BrowserView.mmp:
group/webkit.mmp:

3:57 AM Changeset in webkit [16713] by eseidel

2 edits in trunk/JavaScriptCore

2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix win32 build, which has no inttypes.h

wtf/Assertions.h:

3:30 AM Changeset in webkit [16712] by eseidel

4 edits in trunk

2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix Qt/Linux build.

platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/ (WebCore::supportedKeySizes):

3:26 AM Changeset in webkit [16711] by eseidel

7 edits in trunk

2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel & mjs. Landed by eseidel.

Fix Qt/Linux build with older gcc 3.3.4.
http://bugs.webkit.org/show_bug.cgi?id=11116

As discussed with Maciej, the GCC_ROOT_NS_HACK
can be completely removed, as well as the friendship
between cacheGlobalObject & the JS* objects.

bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3. (png_read_filter_row_mmx_avg):
platform/image-decoders/png/pngvcrd.c: Ditto. (png_mmx_support): (png_read_filter_row_mmx_avg):

12:46 AM Changeset in webkit [16710] by mjs

4 edits in trunk/WebKit

Reviewed by Anders.

remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState frameLoader]):
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoading]): (-[WebDataSource _webView]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource dealloc]): (-[WebDataSource webFrame]): (-[WebDataSource isLoading]):

12:39 AM Changeset in webkit [16709] by mjs

3 edits in trunk/WebKit

Reviewed by Anders.

fix crash on back/forward - reattach WebDocumentLoadState to data source when needed

WebView/WebDataSource.m: (-[WebDataSource _setWebFrame:]): (-[WebDataSource _initWithDocumentLoadState:]):
WebView/WebDataSourceInternal.h:

12:16 AM Changeset in webkit [16708] by mjs

1 edit
2 adds in trunk/WebKit

Build fix, not reviewed.

Added missing files to fix build.

WebView/WebDocumentLoadStateMac.h: Added.
WebView/WebDocumentLoadStateMac.m: Added. (-[WebDocumentLoadStateMac initWithRequest:]): (-[WebDocumentLoadStateMac dealloc]): (-[WebDocumentLoadStateMac setDataSource:]): (-[WebDocumentLoadStateMac dataSource]): (-[WebDocumentLoadStateMac setFrameLoader:]):

12:00 AM Changeset in webkit [16707] by mjs

10 edits in trunk/WebKit

Reviewed by Brady and Oliver.

move things around so that WebDataSource and WebDocumentLoadState know about each other in the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState initWithRequest:]): (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState originalRequest]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDocumentLoadState:]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader _setPolicyDocumentLoadState:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDocumentLoadState:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader activeDocumentLoadState]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _documentLoadState]): (-[WebDataSource _initWithDocumentLoadState:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
WebView/WebDataSourceInternal.h:
WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _policyDataSource]): (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrame _dataSourceForDocumentLoadState:]): (-[WebFrame _createDocumentLoadStateWithRequest:]):
WebView/WebFrameInternal.h:

Oct 1, 2006:

10:16 PM Changeset in webkit [16706] by mjs

3 edits
2 deletes in trunk

LayoutTests:

Rubber stamped by Alexey.

reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

fast/dom/css-insert-import-rule-expected.txt: Removed.
fast/dom/css-insert-import-rule.html: Removed.

WebCore:

Rubber stamped by Alexey.

reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

css/CSSGrammar.y:

9:36 PM Changeset in webkit [16705] by eseidel

3 edits in trunk/WebCore

2006-10-01 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

Eliminate a few more hotspots in SVG drawing code.

No test cases were harmed in the making of this patch. (And SVG has no perf tests.)

kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance

6:20 PM Changeset in webkit [16704] by bdash

5 edits in trunk/WebKitTools

2006-10-01 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Maciej.

Add QT build slave to Buildbot.

BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Add QT build slave, fix existing errors.
BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Add QT build factory.
BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Disable forcing of builds via web interface to prevent spamming. Use the IRC bot in #webkit-build instead.
BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Add CMake build step.

6:02 PM Changeset in webkit [16703] by ggaren

7 edits
2 adds in trunk

LayoutTests:

Added test for the viewource attribute, which applies to <frame> and
<iframe> elements.

fast/frames/viewsource-attribute-expected.txt: Added.
fast/frames/viewsource-attribute.html: Added.

fast/frames/frameElement-widthheight.html: Removed stray character.

WebCore:

Reviewed by Maciej.

More frame/iframe merging.

Removed needWidgetUpdate and related code. needWidgetUpdate is always false, so this was dead code.
Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather than attach(), is the correct place for setInViewSourceMode, because openURL() is the function that creates our frame.
Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME code that did the same thing in other places.
Made FRAME's attach() method suffuciently generic so that IFRAME could call up to it, rather than skipping its superclass and calling up directly to ELEMENT.
Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
Replaced ad hoc frame loading code in FRAME::attach() with call to openURL(), the designated frame loading function.

Layout tests pass. I added a layout test for viewsource mode, since I
broke it in the course of writing this patch.

5:04 PM Changeset in webkit [16702] by eseidel

1 edit
1 add in trunk

2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel.

CMakeLists.txt: add option to disable colored output when building on the buildbot

1:45 PM Changeset in webkit [16701] by andersca

11 edits in trunk/WebCore

2006-10-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
dom/Document.h: Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.

dom/Node.h: Remove DeprecatedStringList class forward declaration.

editing/markup.cpp: Include DeprecatedStringList.h here since it's not included by Document.h anymore.

kcanvas/KCanvasTreeDebug.cpp:
kcanvas/KCanvasTreeDebug.h: Remove unused functions.

loader/loader.cpp:
page/Frame.cpp:
page/Frame.h:
page/FrameView.h: Fixup DeprecatedStringList.h includes.

9:06 AM Changeset in webkit [16700] by harrison

3 edits
4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

fast/text/international/wrap-CJK-001-expected.checksum: Added.
fast/text/international/wrap-CJK-001-expected.png: Added.
fast/text/international/wrap-CJK-001-expected.txt: Added.
fast/text/international/wrap-CJK-001.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

Problem was that the decision to trim was based only on whether the character
is a soft hyphen, which caused pretty much any Japanese character to go.
Changed to decide based on whether the character is ignorable whitespace.

Test:

fast/text/international/wrap-CJK-001.html

rendering/bidi.cpp: (WebCore::isTrimmableChar): New. Checks whether character is whitespace that can be ignored according to the text node's style. trimmed from the end of wrapped line. (WebCore::checkMidpoints): Call isTrimmable() rather than checking for char != SOFT_HYPHEN.

8:40 AM Changeset in webkit [16699] by andersca

14 edits in trunk/WebCore

2006-10-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Mitz Pettel.

Convert the SVG code to use Vector<String> instead of DeprecatedStringList.

ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
ksvg2/svg/SVGLengthList.cpp:
ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::parse):
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::reset):
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGTransformable.cpp: (SVGTransformable::parseTransformAttribute):

3:51 AM Changeset in webkit [22281] by hyatt

2 edits in branches/WindowsMerge/WebCore

Finish the win32 scrollbar.

3:05 AM Changeset in webkit [16698] by ap

5 edits in trunk/WebCore

2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric, tweaked and landed by ap.

Fix Qt/Linux build.

CMakeLists.txt:
platform/qt/PlatformScrollBar.h:
platform/qt/TemporaryLinkStubs.cpp: (WebCore::ScrollBar::ScrollBar): (WebCore::PlatformScrollBar::PlatformScrollBar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passWheelEventToSubframe): (FrameView::passMousePressEventToScrollbar):
ksvg2/svg/SVGDocument.h:

2:11 AM Changeset in webkit [16697] by ap

3 edits in trunk

2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

No test case added (probably requires new DumpRenderTree functionality)

rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Added early return if the document is being destroyed.

2:06 AM Changeset in webkit [16696] by ap

3 edits
4 adds in trunk

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

Test: fast/text/line-breaks-after-white-space.html

rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

1:42 AM Changeset in webkit [22280] by hyatt

4 edits in branches/WindowsMerge/WebCore

Make scrollbar thumb dragging work.

1:37 AM Changeset in webkit [16695] by ap

2 edits in trunk

Fixed Bugzilla references in ChangeLogs for my previous commit.

1:35 AM Changeset in webkit [16694] by ap

3 edits
2 adds in trunk

Reviewed by Maciej and Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
JavaScript document.write page form does not submit in Safari

Test: fast/forms/document-write.html

page/Frame.cpp: (WebCore::Frame::submitForm): Don't check for parsing().

1:13 AM Changeset in webkit [16693] by ap

2 edits in trunk/WebCore

Build fix.

bridge/mac/FrameViewMac.mm: Add missing #imports.

12:32 AM Changeset in webkit [22279] by hyatt

4 edits in branches/WindowsMerge/WebCore

Hook up the pressed state of scrollbars.

12:26 AM Changeset in webkit [16692] by hyatt

6 edits in trunk/WebCore

Refactor the code that sends the mouse down to scrollbars.

Sep 30, 2006:

5:41 PM Changeset in webkit [22278] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Use BitBlt instead of SetDIBBitsToDevice

4:33 PM Changeset in webkit [16691] by weinig

26 edits in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
Add more SVG Objective-C DOM bindings

Auto-generate Objective-C DOM bindings for DOMSVGAElement, DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement, DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio, DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor, DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVG.h:
bindings/scripts/CodeGeneratorObjC.pm:
ksvg2/svg/SVGAElement.idl:
ksvg2/svg/SVGAnimateColorElement.idl:
ksvg2/svg/SVGAnimateElement.idl:
ksvg2/svg/SVGAnimateTransformElement.idl:
ksvg2/svg/SVGAnimatedPathData.idl:
ksvg2/svg/SVGAnimatedPoints.idl:
ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
ksvg2/svg/SVGAnimationElement.idl:
ksvg2/svg/SVGCircleElement.idl:
ksvg2/svg/SVGClipPathElement.idl:
ksvg2/svg/SVGColor.idl:
ksvg2/svg/SVGCursorElement.idl:
ksvg2/svg/SVGDefsElement.idl:
ksvg2/svg/SVGDescElement.idl:
ksvg2/svg/SVGDocument.idl:
ksvg2/svg/SVGEllipseElement.idl:
ksvg2/svg/SVGPointList.idl:
ksvg2/svg/SVGPreserveAspectRatio.idl:
ksvg2/svg/SVGRect.idl:
ksvg2/svg/SVGSVGElement.idl:

4:18 PM Changeset in webkit [16690] by mjs

3 edits in trunk/WebCore

Reviewed by Adele.

fix build

platform/FloatRect.h: (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment but more appropriate for path-type stuff.
platform/cg/PathCG.cpp: (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.

2:14 PM Changeset in webkit [16689] by ap

29 edits
5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11011
External CSS is parsed as iso-8859-1 even though the main document is utf-8

Test: fast/encoding/css-charset-default.xhtml

loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet): (WebCore::CachedResourceClient::setXSLStyleSheet): Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
css/CSSImportRule.h:

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
css/CSSStyleSheet.h: Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit member. Changed some String parameters to const String&.

css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
css/StyleSheet.h: Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

css/StyleSheetList.cpp: (WebCore::StyleSheetList::length): (WebCore::StyleSheetList::item):
css/StyleSheetList.h: Special-casing implicit stylesheets seemed to be dead code, removed.

dom/Document.cpp: (WebCore::Document::setCSSStyleSheet): (WebCore::Document::recalcStyleSelector):
dom/Document.h: Renamed setStyleSheet() to setCSSStyleSheet().

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet(). (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet): (WebCore::ProcessingInstruction::parseStyleSheet):
dom/ProcessingInstruction.h:

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute is not specified. (WebCore::HTMLLinkElement::setCSSStyleSheet):
html/HTMLLinkElement.h:

html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): Inherit URL and charset from the document.

loader/Cache.cpp: (WebCore::Cache::requestCSSStyleSheet):
loader/Cache.h: Adjust for setStyleSheet() renaming.

loader/CachedCSSStyleSheet.h: Removed an unused constructor.
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::deref): (WebCore::CachedCSSStyleSheet::checkNotify): Pass the encoding to setCSSStyleSheet().

loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::ref): (WebCore::CachedXSLStyleSheet::checkNotify):
loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
loader/DocLoader.h:
page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): (WebCore::XSLImportRule::loadSheet):
xml/XSLImportRule.h: Adjust for setStyleSheet() renaming.

10:08 AM Changeset in webkit [16688] by rwlbuis

3 edits
4 adds in trunk

Reviewed by eseidel.

http://bugs.webkit.org/show_bug.cgi?id=11096
Hit testing for polylines fails

Fix Path::contains so it handles filled, non-closed paths too.

3:11 AM Changeset in webkit [16687] by hyatt

1 edit in trunk/WebCore/platform/win/PlatformScrollBar.h

Fix win32.

2:49 AM Changeset in webkit [16686] by hyatt

1 edit in trunk/WebKit/WebView/WebPreferences.m

Revert minimum font size pref back to 1.

2:48 AM Changeset in webkit [16685] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage caused by a typo.

2:46 AM Changeset in webkit [16684] by hyatt

3 edits in trunk/WebCore

Fix mac bustage in FrameMac.mm and FrameViewMac.mm

2:37 AM Changeset in webkit [22277] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Revert minimum font size pref back to 1.

2:34 AM Changeset in webkit [22276] by hyatt

8 edits
1 add in branches/WindowsMerge/WebCore

Make mouse events work in iframes.

2:30 AM Changeset in webkit [16683] by hyatt

12 edits in trunk/WebCore

Event refactoring.

Sep 29, 2006:

10:42 PM Changeset in webkit [16682] by adele

3 edits in trunk/WebCore

Reviewed by Adele.

Fixes windows bustage:
http://bugs.webkit.org/show_bug.cgi?id=11093

platform/win/PlatformScrollBar.h:
platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar): (ScrollBar::ScrollBar):

9:41 PM Changeset in webkit [22275] by hyatt

1 edit in branches/WindowsMerge/WebKitWin/WebPreferences.cpp

Change minimum font size value to 0 on win32 as well.

8:25 PM Changeset in webkit [16681] by thatcher

2 edits in trunk/LayoutTests

Bug 11041: fast/dom/isindex-001 needs new results
http://bugs.webkit.org/show_bug.cgi?id=11041

fast/dom/isindex-001-expected.txt:

8:15 PM Changeset in webkit [22274] by sfalken

1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Fix the build.

platform/win/PlatformScrollBarWin.cpp:

7:08 PM Changeset in webkit [16680] by thatcher

2 edits in tags/Safari-521.28

Versioning

6:57 PM Changeset in webkit [16679] by hyatt

2 edits in trunk/WebKit

Change the default minimum font size pref to 0 in order to allow
font-size:0 to work.

WebView/WebPreferences.m: (+[WebPreferences initialize]):

6:55 PM Changeset in webkit [16678] by hyatt

15 edits in trunk/WebCore

Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
in RenderObject::NodeInfo (and then propagating that Widget to
MouseEventWithHitTestResults).

This allows RenderListBox and RenderBlock to do the same thing when the
mouse is over the scrollbar.

Also land fix to support font-size: 0.

Reviewed by mjs (scrollbar), eric (font-size)

dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
page/Frame.cpp: (WebCore::Frame::passWidgetMouseDownEventToWidget):
page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::dispatchMouseEvent):
page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderBlock.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest):
rendering/RenderLayer.h: (WebCore::RenderLayer::getHiddenBehavior):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::isPointInScrollbar):
rendering/RenderListBox.h:
rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::NodeInfo): (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):

6:50 PM Changeset in webkit [16677] by adele

3 edits in trunk/WebCore

Reviewed by Adele.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::convertToContainingWindow): (WebCore::ScrollView::convertFromContainingWindow):
platform/win/WidgetWin.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):

6:44 PM Changeset in webkit [16676] by adele

2 edits in trunk/WebCore

Updated with new argument for PlatformScrollBar.

platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar):

6:03 PM Changeset in webkit [16675] by thatcher

3 edits
2 copies in tags/Safari-521.28

Merging a fix to the tag.

6:00 PM Changeset in webkit [16674] by thatcher

16 edits in tags/Safari-521.28

Merging a fix to the tag.

5:44 PM Changeset in webkit [16673] by thatcher

13 edits in tags

Merging fix to tag.

5:42 PM Changeset in webkit [16672] by thatcher

3 edits
2 copies in tags

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

fast/text/attributed-substring-from-range-001-expected.txt: Added.
fast/text/attributed-substring-from-range-001.html: Added.

Check attributed string results when starting or ending at a br element.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

Test added

fast/text/attributed-substring-from-range-001.html

bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case. Also, add validation of the range.

5:39 PM Changeset in webkit [16671] by thatcher

2 copies in tags/Safari-521.28

New tag.

5:34 PM Changeset in webkit [16670] by thatcher

1 delete in tags/Safari-521.28

Bad tag.

5:29 PM Changeset in webkit [16669] by thatcher

3 copies in tags/Safari-521.28

New tag.

5:11 PM Changeset in webkit [22273] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff.

Allow WebKit to query for the rect
of the resizer rather than just its size.

Fix <rdar://4753220>
Correct more/fewer button toggling in bug report sheet.

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff.

Allow WebKit to query for the rect
of the resizer rather than just its size.

Interfaces/IWebUIDelegatePrivate.idl:

5:06 PM Changeset in webkit [16668] by thatcher

1 edit in trunk/WebCore/html/HTMLSelectElement.cpp

Build fix.

4:59 PM Changeset in webkit [16667] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixing build bustage with cast to int.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):

4:45 PM Changeset in webkit [16666] by adele

2 edits in trunk/WebCore

Fixing accidental include.

rendering/RenderListBox.cpp:

4:41 PM Changeset in webkit [16665] by adele

2 edits in trunk/WebCore

Adding RenderListBox files.

4:40 PM Changeset in webkit [22272] by adele

2 edits in branches/WindowsMerge/WebCore

Adding RenderListBox files

4:15 PM Changeset in webkit [16664] by bdakin

1 edit in trunk/WebCore/ChangeLog

Fixing typo. No problem in the ned. Just the end.

4:15 PM Changeset in webkit [22271] by adele

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Adding reviewer to ChangeLog

4:15 PM Changeset in webkit [22270] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

Updated constructor for PlatformScrollBar to include controlSize argument.

platform/win/PlatformScrollBar.h:
platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollBar::PlatformScrollBar):

4:14 PM Changeset in webkit [22269] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam, Geoff.

Fix <rdar://4757392>
Plug-ins flash to white while scrolling.

Set WS_CLIPCHILDREN on browser windows to clip out plug-in HWNDs
when drawing.

WebView.cpp: (WebView::initWithFrame):

4:13 PM Changeset in webkit [16663] by adele

26 edits
2 adds in trunk/WebCore

Reviewed by Adam.

Initial implementation of engine-based list box control.

WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp

bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):

page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select. (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto. (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.

page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::currentMousePosition): (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
page/FrameView.h:

platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument. The list box will use a smaller scroll bar size.
platform/ScrollBar.h: (WebCore::): (WebCore::ScrollBar::controlSize):
platform/mac/PlatformScrollBar.h:
platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollBar:]): (WebCore::PlatformScrollBar::PlatformScrollBar):

rendering/RenderBlock.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): (WebCore::RenderObject::autoscroll):
rendering/RenderObject.h: (WebCore::RenderObject::isListBox):

css/html4.css: Added properties for new list boxes.

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled. (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
html/HTMLOptionElement.h: Added disabled method.

html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::lastSelectedListIndex): (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys. (WebCore::HTMLSelectElement::nextSelectableListIndex): (WebCore::HTMLSelectElement::previousSelectableListIndex):
html/HTMLSelectElement.h:

rendering/RenderTheme.cpp: Added support for ListBoxAppearance (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::supportsFocusRing):
rendering/RenderTheme.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

rendering/RenderListBox.cpp: Added. (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::setStyle): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::size): (WebCore::RenderListBox::numItems): (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::baselinePosition): (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::scrollBarTarget): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scroll): (WebCore::RenderListBox::valueChanged):
rendering/RenderListBox.h: Added. (WebCore::RenderListBox::isListBox): (WebCore::RenderListBox::selectionChanged): (WebCore::RenderListBox::setSelectionChanged): (WebCore::RenderListBox::canHaveChildren): (WebCore::RenderListBox::renderName): (WebCore::RenderListBox::setOptionsChanged): (WebCore::RenderListBox::shouldAutoscroll): (WebCore::RenderListBox::listIndexIsVisible):

4:10 PM Changeset in webkit [16662] by bdakin

3 edits in trunk/WebCore

Reviewed by Darin.

We had a bug where html4.css was ignoring Media Queries. In the ned
the problem was that we were trying to send a char* to the
MediaQueryEvaluator constructor that expects a String, but the
char* got interpreted as a bool, the wrong constructor was called,
and the media type was never set.

No test case possible since this only affects html4.css

css/MediaQueryEvaluator.cpp: New constructor that expects takes a char* (WebCore::MediaQueryEvaluator):
css/MediaQueryEvaluator.h: Same.

3:57 PM Changeset in webkit [16661] by ggaren

5 edits
3 adds in trunk

LayoutTests:

Reviewed by John, Maciej.

Added test for whether a frame element reports its src attribute as a
complete, rather than relative, URL.

fast/frames/frame-src-attribute-expected.txt: Added.
fast/frames/frame-src-attribute.html: Added.
fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

Reviewed by John, Maciej.

Integrated some frame and iframe code. I'm trying to fix up frame ownership
and loading. Reducing the number of different code paths involved
seemed like a good first step.

As a side effect, I fixed a bug where FRAME elements would report their
src attributes as relative, rather than compelete, URLs. (IFRAME elements
had the correct complete URL behavior.)

html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo (WebCore::HTMLFrameElement::openURL):

(1) Removed checks that requestFrame does for us
(2) Added isURLAllowed check, to have one clear bottleneck for it
(3) Added viewsource check, to have one clear bottleneck for it

(WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
method, instead of finding our content frame in our own unique way.
(WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
since openURL does this for us now.
(WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
This is what FF does, and it made no sense to have different behaviors
for FRAME and IFRAME elements.

html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init code.
html/HTMLIFrameElement.h: Removed src() and openURL() methods, since HTMLFrameElement now does everything we need.

3:33 PM Changeset in webkit [16660] by rwlbuis

5 edits in trunk/WebCore

Reviewed by Hyatt.

Fix Qt/Linux build.

3:28 PM Changeset in webkit [16659] by brmorris

2 edits in S60/trunk/S60Tools

Reviewed by Brad.
DESC: Update bugzilla url

prepare-ChangeLog.bat:

3:24 PM Changeset in webkit [16658] by thatcher

1 edit in trunk/LayoutTests/ChangeLog