Timeline
Nov 4, 2006:
- 10:16 PM Changeset in webkit [17602] by
-
- 2 edits in trunk/WebKitTools
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521
Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open
- Drosera/debugger.js: Use . instead of so that it doesn't root the search at the document.
- 10:14 PM Changeset in webkit [17601] by
-
- 2 edits in trunk/WebKitTools
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513
Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.
- Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
- 10:12 PM Changeset in webkit [17600] by
-
- 2 edits in trunk/WebKitTools
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512
Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.
- Drosera/debugger.js: blur() the function popup when we're done with it.
- 5:24 PM Changeset in webkit [22469] by
-
- 5 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Maciej.
- bridge/win/FrameWin.h:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Updated for change of const Event* to Event*. (WebCore::FrameWin::submitForm): Added Event* parameter.
WebKitWin:
- WebView.cpp: (WebView::initWithFrame): Removed setMainFrame call and deref of Frame, now handled by Frame's constructor.
- 5:16 PM Changeset in webkit [17599] by
-
- 1 edit in trunk/WebCore/ChangeLog
s
- 5:16 PM Changeset in webkit [17598] by
-
- 2 edits in trunk/WebCore
Reviewed by Ander.
- fix http://bugs.webkit.org/show_bug.cgi?id=11453 REGRESSION: Status bar always shows cancelled opening the page
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel. Since the subresource owns the resource handle, there's no need to cancel. This arrangement is only temporary, anyway, since Maciej will soon change things so that the subresource loader uses the resource handle and the resource handle doesn't know anything about the subresource loader.
- 5:06 PM Changeset in webkit [17597] by
-
- 84 edits1 delete in trunk
WebCore:
Reviewed by Maciej.
- converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones
converted most uses of NSURL to KURL and NSEvent to DOM Event in
loader classes
moved download function out of FrameLoader.h to avoid reference to
NSURLConnection
added DOM Event parameters to various functions so that the handlers
can use the DOM Event instead of the global "current NSEvent";
includes Frame::submitForm, HTMLFormElement::prepareSubmit,
HTMLFormElement::submit, FrameLoader::load
moved the setMainFrame call that hands ownership to the Page
into one of the Frame constructors, and removed it from all
the clients
removed const from Event parameter to the urlSelected function
(we rarely use const with DOM elements)
removed some redundant includes and declarations from various
header files
removed NSURL parameter from userAgent function -- if we need it we
can add it back, but converting from NSURL to KURL and back is
inefficient enough that it's best to have it out for now (since it's
been unused for years) -- if we add it back, we can choose an
appropriate parameter type that's always inexpensive to pass
did some basic cleanup in the IconLoader class, including removing
an unnecessary loop that added icon data a byte at a time
renamed safeLoad to load, since it's no different from the other
FrameLoader load functions, safety-wise
fixed some code that was trying to distinguish null frame name from
empty string frame name -- both should be handled the same, but callers
were doing it by checking for empty and turning it into null (in a way
that was causing extra round trips between NSString and WebCore::String)
corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
and got rid of case-insensitive compares of methods
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent):
- bridge/mac/FrameViewMac.mm:
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
- bridge/mac/WebCorePageBridge.h:
- bridge/mac/WebCorePageBridge.mm:
- bridge/mac/WebCoreSettings.mm:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
- bridge/win/FrameWin.h:
- dom/MouseRelatedEvent.cpp:
- dom/MouseRelatedEvent.h:
- dom/UIEvent.cpp: (WebCore::UIEvent::~UIEvent):
- dom/UIEvent.h:
- dom/UIEventWithKeyState.h:
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
- loader/DocumentLoader.h:
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/NavigationAction.h: (WebCore::NavigationAction::event):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::create): (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFinishLoading):
- loader/icon/IconLoader.h:
- loader/loader.cpp:
- loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::URLForHistory):
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/mac/IconLoaderMac.mm: (WebCore::IconLoader::notifyIconChanged):
- loader/mac/LoaderFunctionsMac.mm:
- loader/mac/MainResourceLoaderMac.mm: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/mac/NavigationActionMac.mm: (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
- loader/mac/ResourceLoaderMac.mm:
- loader/mac/SubresourceLoaderMac.mm:
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::urlSelected): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::endIfNotLoading): (WebCore::Frame::hitTestResultAtPoint):
- page/Frame.h:
- page/FramePrivate.h:
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
- platform/gdk/FrameGdk.h:
- platform/mac/TextFieldMac.mm:
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/mac/ResourceResponseMac.h:
- platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
- platform/network/win/ResourceHandleWin.cpp:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
- platform/qt/FrameQt.h:
- rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::returnPressed):
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp:
WebKit:
Reviewed by Maciej.
- converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones
store the computed user agent string as a WebCore::String instead
of an NSString to avoid overhead converting it every time we get it
- COM/WebFrame.cpp: (WebFrame::initWithName):
- ChangeLog:
- Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): (-[WebElementDictionary _targetWebFrame]):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent): (WebFrameLoaderClient::actionDictionary):
- WebCoreSupport/WebPageBridge.mm: (WebCore::if):
- WebView/WebDataSource.mm: (-[WebDataSource _URL]): (-[WebDataSource _URLForHistory]): (-[WebDataSource unreachableURL]):
- WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]):
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (-[WebPDFView _path]):
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView _cachedResponseForURL:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView userAgentForURL:]): (-[WebView _computeUserAgent]): (-[WebView WebCore::]):
- WebView/WebViewInternal.h:
- 5:02 PM Changeset in webkit [17596] by
-
- 2 edits in trunk/WebKitTools
2006-11-04 Mark Rowe <bdash@webkit.org>
Reviewed by Darin.
Fix use of uninitialized value in pattern match.
- Scripts/webkitdirs.pm:
- 4:23 PM Changeset in webkit [22468] by
-
- 6 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Adele.
- replaced receivedRedirect with new willSendRequest delegate
- removed most mac-specific loader functions
- use ResourceResponse more in loader code
- WebCore.vcproj/WebCore.vcproj: Added new files
- platform/win/TemporaryLinkStubs.cpp: Removed unneeded link stubs
WebKitWin:
Reviewed by Adele.
- replaced receivedRedirect with new willSendRequest delegate
- removed most mac-specific loader functions
- use ResourceResponse more in loader code
- WebFrame.cpp: (WebFrame::willSendRequest): Rearranged from former receivedRedirect.
- WebFrame.h:
- 4:15 PM Changeset in webkit [17595] by
-
- 24 edits2 copies4 adds in trunk/WebCore
Reviewed by Adele.
- replaced receivedRedirect with new willSendRequest delegate
- removed most mac-specific loader functions
- use ResourceResponse more in loader code
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted for CachedResource method renames. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): simplified based on ResourceResponse
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage): adapt for ResourceResponse
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): store a ResourceResponse; platform response is now called platformResponse and expiration date is removed. (WebCore::CachedResource::~CachedResource): ditto (WebCore::CachedResource::isExpired): ditto
- loader/CachedResource.h: (WebCore::CachedResource::platformResponse): ditto (WebCore::CachedResource::setResponse): ditto (WebCore::CachedResource::canDelete): ditto
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse): Adjusted for renames. (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse in the CachedResource.
- loader/loader.h:
- loader/mac/FormDataStream.h:
- loader/mac/FormDataStream.m: (WebCore::getStreamFormDatas): Rearranged things so it's possible to get a FormData back out of a form data stream. (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::httpBodyFromStream): ditto
- loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): s/response/platformResponse/
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): ditto (WebCore::CachedResource::setPlatformResponse): ditto
- loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): send redirect to client appropriately
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): new entry point for SubresourceLoader, dispatch to client.
- platform/network/ResourceRequest.h: (WebCore::ResourceRequest::allowHTTPCookies): implemented (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
- platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): initialize expiration date(!)
- platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): Added this, ported from NSURL version. (WebCore::openNextStream): ditto (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::formCanRead): ditto (WebCore::formEventCallback): ditto (WebCore::setHTTPBody): ditto (WebCore::httpBodyFromStream): ditto
- platform/network/cf/FormDataStreamCFNet.h: Added.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): implemented (WebCore::ResourceHandle::start): use new ResourceRequest stuff
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): do nothing for a null response
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
- platform/network/mac/ResourceRequestMac.h: Added.
- platform/network/mac/ResourceRequestMac.mm: Added. (WebCore::getResourceRequest): Added way to convert an NSURLRequest to a ResourceRequest. (WebCore::nsURLRequest): Opposite of the above.
- platform/network/cf/ResourceRequestCFNet.h: Added.
- platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): Added way to convert an CFURLRequest to a ResourceRequest. (WebCore::cfURLRequest): Opposite of the above.
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect, adjusted.
- xml/xmlhttprequest.h:
- 9:54 AM Changeset in webkit [17594] by
-
- 2 edits in trunk/WebCore
Change suggested by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=11514 REGRESSION (r17438): Repro crash when opening a web archive
- bridge/mac/WebCorePageState.mm: (-[WebCorePageState dealloc]): Add null check. (-[WebCorePageState finalize]): Ditto.
- 9:53 AM Changeset in webkit [17593] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Tim Hatcher.
- Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
- 7:51 AM Changeset in webkit [17592] by
-
- 16 edits3 adds in trunk
2006-11-04 Bertrand Guiheneuf <guiheneuf@gmail.com>
Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
http://bugs.webkit.org/show_bug.cgi?id=11433
Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths Created platform/graphics and platform/network filters in hierarchy Moved GraphicsContext and GraphicsTypes to their respective filters Added EditorClient.h Added FrameLoader* files in loader/ Added HitTest* files in rendering/ Added Editor.* files in editing/ Added DeleteButton.* and DeleteButtonController.* in editing/
- bridge/win/ChromeClientWin.h: Added. (WebCore::ChromeClientWin::~ChromeClientWin):
- bridge/win/EditorClientWin.h: Added. (WebCore::EditorClientWin::~EditorClientWin):
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
- bridge/win/FrameWin.h: Added EditorClient parameter to constructor Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest() Removed openURL() and openURLRequest from class definition
- bridge/win/PageWin.cpp:
- platform/AffineTransform.h:
- platform/cairo/AffineTransformCairo.cpp: Added. (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::m11): (WebCore::AffineTransform::m12): (WebCore::AffineTransform::m21): (WebCore::AffineTransform::m22): (WebCore::AffineTransform::dx): (WebCore::AffineTransform::dy): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::det): (WebCore::AffineTransform::invert): (WebCore::AffineTransform::operator cairo_matrix_t): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator*= ): (WebCore::AffineTransform::operator* ):
- platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::goBackOrForward): (WebCore::FrameWin::getHistoryLength): (WebCore::FrameWin::historyURL): (WebCore::ServeSynchronousRequest): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::Path::transform): (WebCore::PopupMenu::updateFromElement): (WebCore::ResourceLoader::loadsBlocked): (WebCore::systemBeep):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):
WebKit:
- COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::receivedAllData): Use resource handles now. Do not start doc loader by hand anymore. Handle didReceiveData() callback instead of receivedData() which is deprecated in implementation of ResourceHandleClient
- COM/WebFrame.h:
- COM/WebView.cpp: Applied ResourceLoader --> ResourceHandle renaming
- WebKit.vcproj/WebKit.rc: Got rid of MFC dependencies (build fix for VCExpress).
- WebKit.vcproj/WebKit.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths
Nov 3, 2006:
- 11:53 PM Changeset in webkit [17591] by
-
- 5 edits2 adds2 deletes in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11448
⟨ and ⟩ entities are mapped to the incorrect Unicode codepoint
WebCore:
- html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
LayoutTests:
- fast/parser/entities-in-xhtml-expected.checksum: Removed.
- fast/parser/entities-in-xhtml-expected.png: Removed. Converted to plain text, the large table in the test didn't nearly fit anyway.
- fast/parser/entities-in-xhtml-expected.txt:
- fast/parser/entities-in-xhtml.xhtml: Made the test self-consistent again by using actual numeric values for ⟨ and ⟩.
- fast/parser/entities-in-html-expected.txt: Added.
- fast/parser/entities-in-html.html: Added. An HTML copy of the same test.
- 10:14 PM Changeset in webkit [17590] by
-
- 2 edits in trunk/WebKitTools
2006-11-03 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.
- Drosera/DebuggerApplication.m: (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
- 10:03 PM Changeset in webkit [22467] by
-
- 3 edits in branches/WindowsMerge/WebCore
2006-11-03 Steve Falkenburg <sfalken@apple.com>
Fix build
- config.h: Touched to cause re-build w/ SVG_SUPPORT enabled
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): Added
- 9:33 PM Changeset in webkit [17589] by
-
- 3 edits in trunk/WebCore
2006-11-03 Mark Rowe <bdash@webkit.org>
Reviewed by Oliver.
Update Windows and Qt project files for file removals in r17585.
- CMakeLists.txt:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- 9:10 PM Changeset in webkit [17588] by
-
- 2 edits in trunk/WebCore
2006-11-03 Zack Rusin <zack@kde.org>
Reviewed by Maciej.
The patch fixes text field drawing on the Qt platform.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField): Use the style to correctly render the text field
- 8:56 PM Applications using WebKit edited by
- Cleanup of formatting (diff)
- 8:39 PM WikiStart edited by
- A more useful start page, copied from the wiki:WebKit page (diff)
- 8:38 PM WebKit plus SVG edited by
- Remove the majority of the page content as it is out of date (diff)
- 8:20 PM Changeset in webkit [17587] by
-
- 2 edits in trunk/JavaScriptCore
2006-11-03 Steve Falkenburg <sfalken@apple.com>
Fix build
- kjs/JSImmediate.h:
- 4:41 PM Changeset in webkit [17586] by
-
- 2 edits in trunk/WebCore
2006-11-03 Oliver Hunt <oliver@apple.com>
Reviewed by Tim.
Correct incorrect call to SetCursor
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
- 4:37 PM Changeset in webkit [22466] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Oliver.
Removed DeprecatedRenderSelect and ListBox classes.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/TemporaryLinkStubs.cpp:
- 4:35 PM Changeset in webkit [17585] by
-
- 8 edits4 deletes in trunk/WebCore
Reviewed by Oliver.
Removed DeprecatedRenderSelect and ListBox classes.
- WebCore.xcodeproj/project.pbxproj:
- css/html4.css:
- html/HTMLOptionElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::updateListBoxSelection):
- html/HTMLSelectElement.h:
- platform/ListBox.h: Removed.
- platform/mac/FontCacheMac.mm:
- platform/mac/ListBoxMac.mm: Removed.
- platform/win/TemporaryLinkStubs.cpp:
- rendering/DeprecatedRenderSelect.cpp: Removed.
- rendering/DeprecatedRenderSelect.h: Removed.
- 4:20 PM Changeset in webkit [17584] by
-
- 1 edit2 deletes in trunk/WebCore
Not reviewed, fix for accidental commit.
- rolled back more of the accidentall commit that I forgot.
- platform/network/mac/ResourceRequestMac.h: Removed.
- platform/network/mac/ResourceRequestMac.mm: Removed.
- 4:09 PM Changeset in webkit [17583] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
Bug 9596: [Drosera] add a function popup to the source pane
- Drosera/debugger.css: Added styles for function popup
- Drosera/debugger.html: Added function popup button and select
- Drosera/debugger.js: Added function popup functionality
- 2:28 PM Changeset in webkit [17582] by
-
- 22 edits in trunk/WebCore
Not reviewed, fix for accidental commit.
- roll back some network changes accidentally committed with a previous patch.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired):
- loader/CachedResource.h: (WebCore::CachedResource::response):
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceivedResponse):
- loader/loader.h:
- loader/mac/FormDataStream.h:
- loader/mac/FormDataStream.m: (WebCore::formCreate): (WebCore::formFinalize):
- loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setResponse):
- loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedRedirect):
- platform/network/ResourceRequest.h:
- platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::redirectedToURL):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedRedirect):
- xml/xmlhttprequest.h:
- 2:20 PM Changeset in webkit [22465] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Remove SVGRenderAsText files from the project.
- WebCore.vcproj/WebCore.vcproj:
- 2:15 PM Changeset in webkit [17581] by
-
- 1 edit2 deletes in trunk/WebCore
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Rubber-stamped by Oliver.
Remove these, they have been merged with SVGRenderTreeAsText.
- rendering/SVGRenderAsText.cpp: Removed.
- rendering/SVGRenderAsText.h: Removed.
- 2:12 PM Changeset in webkit [17580] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11504
Fix warnings on non 32 bit platforms
- kjs/JSImmediate.h: (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits): Rewrite in a way that moves runtime checks to compile-time.
(KJS::):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):
- 1:55 PM Changeset in webkit [22464] by
-
- 4 edits in branches/WindowsMerge
WebCoreWin:
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Build fix.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setPlatformResponse):
WebKitWin:
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Build fix.
- WebChromeClient.cpp:
- 1:53 PM Changeset in webkit [17579] by
-
- 2 edits in trunk/WebCore
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
- 1:05 PM Changeset in webkit [17578] by
-
- 1 edit2 adds in trunk/WebKit
Forgot to add these two files. Oops.
- WebCoreSupport/WebChromeClient.h: Added.
- WebCoreSupport/WebChromeClient.mm: Added.
- 12:59 PM Changeset in webkit [22463] by
-
- 7 edits5 adds in branches/WindowsMerge
WebCoreWin:
Reviewed by Darin, Beth.
Updated to use ChromeClient.
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/PageWin.cpp:
- loader/win/ResourceLoaderWin.cpp: Added. (WebCore::ResourceLoader::loadsBlocked):
- platform/win/TemporaryLinkStubs.cpp:
WebKitWin:
Reviewed by Darin, Beth.
Updated to use ChromeClient.
- WebChromeClient.cpp: Added. (WebChromeClient::create): (WebChromeClient::WebChromeClient): (WebChromeClient::canRunModal): (WebChromeClient::runModal):
- WebChromeClient.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- WebView.cpp: (WebView::initWithFrame):
- 12:56 PM Changeset in webkit [17577] by
-
- 15 edits3 adds in trunk
WebCore:
Reviewed by Darin, Beth.
First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.
Layout tests pass.
- bridge/mac/PageMac.mm: Removed platform-specific constructor, added setBridge method to replace it. (WebCore::Page::setBridge):
- bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact that WebCorePageBridge.h doesn't need to be included by ObjC-only files, and, now that it uses PassRefPtr, can't be.
- page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
- page/Page.h: (WebCore::Page::dragCaretController): Made this function non-const so that m_dragCaretController doesn't have to be mutable.
WebKit:
Reviewed by Darin, Beth.
First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.
Layout tests pass.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebPageBridge.mm:
- WebKit.xcodeproj/project.pbxproj:
- 11:02 AM Changeset in webkit [17576] by
-
- 2 edits in S60/trunk/WebKit
2006-11-01 ligman <joseph.ligman@nokia.com>
Reviewed by Sachin.
DESC: Use the EscapeUtils::EscapeDecodeL to remove escaped characters in the path.
http://bugs.webkit.org/show_bug.cgi?id=11348
- ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):
- 10:58 AM Changeset in webkit [17575] by
-
- 1 edit1 add in trunk/WebKitTools
2006-11-03 Michael Emmel <mike.emmel@gmail.com>
Reviewed by Maciej.
- Scripts/wkstyle: Adds astyle sed script formats according to most of the style guidelines.
- 10:36 AM Changeset in webkit [17574] by
-
- 19 edits5 adds in trunk
Reviewed by Adele.
http://bugs.webkit.org/show_bug.cgi?id=7323
REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
WebCore:
- bridge/mac/FrameMac.h: Moved drag source information to a static variable in FrameMac.mm. There can be only one drag active at any moment, and having this information here was making sharing this information between subframes hard.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo. (WebCore::FrameMac::freeClipboard): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::dragSourceMovedTo): (WebCore::FrameMac::dragSourceEndedAt): (WebCore::FrameMac::dispatchDragSrcEvent): Access drag source info via sharedDragInfo - this fixes drag source even dispatching. Also removed some old code that was forwarding mouse events to subviews to make HTML editing work in subframes.
- page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): Forward events to subframes for dispatching - this fixes drag target events.
WebKitTools:
When dragging, do not send EventSendingController's events immediately. Dragging
is supposed to be modal, so we need to perform it from within the delegate, without
returning to JS to make the next mouse movement.
When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.
- DumpRenderTree/EventSendingController.h:
- DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (+[EventSendingController saveEvent:]): (+[EventSendingController replaySavedEvents]):
- DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
LayoutTests:
- fast/events/drag-in-frames-expected.txt: Added.
- fast/events/drag-in-frames.html: Added.
- fast/events/resources/drag-in-frames-console.html: Added.
- fast/events/resources/drag-in-frames-left.html: Added.
- fast/events/resources/drag-in-frames-right.html: Added.
- editing/selection/expanding-selections.html:
- editing/selection/expanding-selections2.html:
- fast/dynamic/layer-hit-test-crash.html:
- fast/events/event-view-toString.html:
- fast/events/resources/drag-outside-window-frame.html:
- svg/custom/hover-default-fill.svg: Added missing calls to mouseUp().
- svg/custom/stroke-width-click-expected.txt:
- svg/custom/stroke-width-click.svg: Don't attempt to click outside the page, this was confusing DRT.
- editing/selection/select-from-textfield-outwards-expected.txt:
- editing/selection/select-from-textfield-outwards.html: Removed alerts between dragging steps - they are now useless, as the dragging events are stored and executed at once.
- 8:52 AM Changeset in webkit [17573] by
-
- 2 edits in trunk/WebCore
2006-11-03 Zack Rusin <zack@kde.org>
Reviewed by Tim, landed by George.
Fixing compile.
- platform/qt/LoaderFunctionsQt.cpp: (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
- 8:51 AM Changeset in webkit [17572] by
-
- 12 edits in trunk/LayoutTests
Missed a few tests in my last check-in, and checked in old results for
others. Oops.
- editing/inserting/before-after-input-element-expected.txt:
- editing/inserting/before-after-input-element.html:
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/input-field-1-expected.txt:
- editing/pasteboard/input-field-1.html:
- editing/pasteboard/select-element-1-expected.txt:
- editing/pasteboard/select-element-1.html:
- editing/selection/select-element-paragraph-boundary-expected.txt:
- editing/selection/select-element-paragraph-boundary.html:
- fast/forms/textarea-no-scroll-on-blur-expected.txt:
- fast/forms/textarea-scrollbar-expected.txt:
- 8:20 AM Changeset in webkit [17571] by
-
- 3 edits1 add in trunk/WebCore
2006-11-01 Zack Rusin <zack@kde.org>
Reviewed by Maciej, landed by George.
Moving the word/sentence seperators into a file of their own
and implementing findWordBoundary.
- CMakeLists.txt:
- platform/qt/TemporaryLinkStubs.cpp:
- platform/qt/TextBoundaries.cpp: Added. (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
- 7:34 AM Changeset in webkit [17570] by
-
- 2 edits in S60/branches/3.1m/WebKit
2006-11-02 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496
- BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):
Merge from ccb r17569
- 7:29 AM Changeset in webkit [17569] by
-
- 2 edits in S60/trunk/WebKit
2006-11-02 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496
- BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):
- 7:24 AM Changeset in webkit [17568] by
-
- 2 edits in S60/trunk/WebKit
2006-11-02 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: TSW bug# VKRR-6PH9VQ : ResolveLink function is called with wrong parameters.
Set the current url on UrlRequest when user clicks on a link.
http://bugs.webkit.org/show_bug.cgi?id=11499
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
- 2:48 AM Changeset in webkit [17567] by
-
- 7 edits in trunk
2006-11-03 Zack Rusin <zack@kde.org>
Reviewed by Maciej, landed by George.
Compile on both KDE and Qt platforms
- CMakeLists.txt: add zlib explicitly
- platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::self): (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): Integrate both implementations
so that moc can parse it
(WebCore::ResourceHandleManager::deliverJobData):
(WebCore::ResourceHandleManager::remove):
- platform/network/qt/ResourceHandleManager.h:
- 2:01 AM Changeset in webkit [17566] by
-
- 2 edits in trunk/JavaScriptCore
2006-11-02 George Staikos <staikos@kde.org>
Reviewed by Maciej.
- collector.cpp: Remove a deprecated pthreads call.
- 1:40 AM Changeset in webkit [17565] by
-
- 2 edits in trunk/WebCore
No review, suggested by Mitz.
- fix a #if to be #ifdef
- platform/graphics/svg/cg/SVGResourceImageCg.cpp:
- 1:33 AM Changeset in webkit [17564] by
-
- 3 edits in trunk/WebCore
Reviewed and landed by Maciej.
Compile on the Qt platform.
- ksvg2/misc/KCanvasRenderingStyle.h:
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
- 1:28 AM Changeset in webkit [17563] by
-
- 27 edits2 adds in trunk/WebCore
Reviewed by Hyatt. Landed by Maciej.
Adding setPlatformPen/setPlatformFont/setPlatformFillColor
to graphics context to be able to set consistant state
on the platform specific painter without having to change
fill/stroke/font on every operation. This fixes color/stroke/fill
and font handling in the Qt port.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformFont):
- platform/graphics/GraphicsContext.h:
- platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::penToQPen): (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor):
- platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
- platform/qt/ScrollViewCanvasQt.h:
Nov 2, 2006:
- 10:41 PM Changeset in webkit [17562] by
-
- 418 edits in trunk
LayoutTests:
Reviewed by Justin Garcia.
Used a PERL script to add calls to opt into dumping of editing callbacks
in all editing tests that didn't do so already. This is required now that
dumping of editing callbacks is opt-in.
Updated editing.js so that any test that calls runEditingTest() opt into
dumping of editing callbacks.
Updated results in all non-editing tests to remove dumping of editing callbacks.
Updated results in all editing tests to reflect minor DOM changes due to new
<script> elements.
[ many tests and results modified ]
WebKitTools:
Reviewed by Justin Garcia.
Made dumping of editing callbacks opt-in, so that editing spew doesn't
cloud non-editing tests.
- DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController shouldDumpEditingCallbacks]): (runTest):
- DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
- 10:02 PM Changeset in webkit [17561] by
-
- 2 edits in trunk/LayoutTests
Updated results because they were incorrect when checked in. (We never
passed this test.)
- fast/js/regexp-unicode-handling-expected.txt:
- 9:07 PM Nice Bugzilla queries edited by
- (diff)
- 9:05 PM WebKit plus SVG edited by
- (diff)
- 9:03 PM WebKit plus SVG edited by
- (diff)
- 9:02 PM WebKit plus SVG edited by
- (diff)
- 8:54 PM WebKit Team edited by
- (diff)
- 8:54 PM WebKit plus SVG edited by
- (diff)
- 8:48 PM Nice Bugzilla queries edited by
- (diff)
- 8:42 PM WebKit plus SVG edited by
- (diff)
- 8:39 PM WebKit plus SVG edited by
- (diff)
- 8:39 PM WebKit Team edited by
- (diff)
- 8:39 PM Applications using WebKit edited by
- (diff)
- 8:39 PM Known incompatibilities between open-source WebKit and Safari edited by
- (diff)
- 8:35 PM WebKit plus SVG created by
- 8:35 PM WebKit Team created by
- 8:34 PM Known incompatibilities between open-source WebKit and Safari created by
- 8:34 PM Nice Bugzilla queries created by
- 8:34 PM Nightly Builds created by
- 8:34 PM Applications using WebKit created by
- 8:29 PM Changeset in webkit [17560] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Anders.
Test for http://bugs.webkit.org/show_bug.cgi?id=9581
REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
- fast/forms/textarea-no-scroll-on-blur-expected.txt: Added.
- fast/forms/textarea-no-scroll-on-blur.html: Added.
WebCore:
Reviewed by Anders.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=9581 REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
Test: fast/forms/textarea-no-scroll-on-blur.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent): On blur, only scroll back to the start for text fields.
- 7:37 PM Changeset in webkit [17559] by
-
- 2 edits in trunk/WebCore
Another build fix.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- 7:33 PM Changeset in webkit [17558] by
-
- 2 edits in trunk/WebCore
Build fix.
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
- 7:27 PM Changeset in webkit [17557] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff, landed by Anders.
Fix dependency problems caused when running move-js-headers.sh
- move-js-headers.sh: Use cp -p instead of just cp so that the modification time of the original files are used.
- 7:23 PM Changeset in webkit [17556] by
-
- 1 edit6 adds in trunk/LayoutTests
2006-11-02 W. Andy Carrel <wac@google.com>
Reviewed by Maciej, landed by Anders.
Adding tests for Unicode RegExp behavior to match IE and Firefox.
- fast/js/regexp-unicode-handling-expected.txt: Added.
- fast/js/regexp-unicode-handling.html: Added.
- fast/js/resources/regexp-unicode-handling.js: Added.
2006-11-02 Alexey Proskuryakov <ap@nypop.com>
Reviewed by Maciej, landed by Anders.
Test for bugs 7253 and 7445, based on reductions made by Parag Shah and W. Andy Carrel.
- fast/js/gmail-re-re-expected.txt: Added.
- fast/js/gmail-re-re.html: Added.
- fast/js/resources/gmail-re-re.js: Added.
- 7:17 PM Changeset in webkit [17555] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim H, landed by Anders.
Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
REGRESSION: Shadow of file upload button is clipped
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip height to keep from clipping in the shadow
- 7:16 PM Changeset in webkit [17554] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej, landed by Anders.
- platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between content and window. ScrollViewQt already receives correct content coordinates from QScrollArea. (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
- 7:14 PM Changeset in webkit [17553] by
-
- 7 edits in trunk
Reviewed by Maciej, landed by Anders.
- CMakeLists.txt: Make KDE support optional.
WebKitQt:
Reviewed by Maciej, landed by Anders.
- QtLauncher/CMakeLists.txt: Make linkage against kde libraries optional
- QtLauncher/main.cpp: Make it compile without KDE. (main):
- 7:11 PM Changeset in webkit [17552] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej, landed by Anders
- CMakeLists.txt: Make linkage against KDE libraries conditional
- platform/network/qt/ResourceHandleManager.cpp: Added a simple Qt base resource handler that supports only requests to the local filesystem. Used when compiling without KDE support. ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h. (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::deliverJobData):
- platform/network/qt/ResourceHandleManager.h:
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
- platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and input dialog functions when compiling without KDE support (WebCore::ServeSynchronousRequest):
- 7:09 PM Changeset in webkit [17551] by
-
- 3 edits in trunk/WebKitTools
2006-11-02 Alexey Proskuryakov <ap@nypop.com>
Reviewed by Maciej, landed by Anders.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations
- Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
- Scripts/install-win-extras: Make setx.exe actually run.
- 7:06 PM Changeset in webkit [17550] by
-
- 2 edits in trunk/WebCore
2006-11-02 David Carson <dacarson@gmail.com>
Reviewed by Geoff, landed by Anders.
Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
Initializing variable in constructor.
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
- 5:30 PM Changeset in webkit [17549] by
-
- 2 edits in trunk/WebCore
2006-11-02 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::addHeadersFromHashMap): Don't set all headers at once since that clears any previous headers set.
(WebCore::ResourceHandle::start):
- 4:27 PM Changeset in webkit [17548] by
-
- 1 edit in trunk/WebKit/WebView/WebViewPrivate.h
Build fix.
- 4:12 PM Changeset in webkit [17547] by
-
- 4 edits in trunk/WebKit
Reviewed by Brady.
Adding outdent to the WebView responder forwarding list.
Also add outdent to WebHTMLView.h and WebViewPrivate.h.
- WebView/WebHTMLView.h:
- WebView/WebViewPrivate.h:
- WebView/WebView.mm:
- 3:00 PM Changeset in webkit [22462] by
-
- 4 edits in branches/WindowsMerge/WebCore
2006-11-02 Anders Carlsson <acarlsson@apple.com>
Reviewed by Oliver.
- WebCore.vcproj/WebCore.vcproj: Use the forked CursorWin.cpp
- platform/win/CursorWin.cpp: (WebCore::moveCursor): Implement this.
- platform/win/TemporaryLinkStubs.cpp: Get rid of it here.
- 2:24 PM Changeset in webkit [22461] by
-
- 1 add in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp
mirroring CookieJar - porting to CF in next change.
- 2:12 PM Changeset in webkit [17546] by
-
- 3 edits in S60/branches/3.1m/WebKit
2006-11-02 sareen <shyam.sareen@nokia.com>
Reviewed by Sachin Padma.
DESC:
http://bugzilla.opendarwin.org/show_bug.cgi?id=11473
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
- ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
- 2:08 PM Changeset in webkit [17545] by
-
- 2 edits in trunk/LayoutTests
Updated results to fix failure seen when running layout tests. Justin
Garcia says the new results look more correct.
- editing/selection/drag-to-contenteditable-iframe-expected.txt:
- 1:47 PM Changeset in webkit [17544] by
-
- 2 edits in S60/branches/3.1m/WebKit
2006-10-31 zhalu <zhaosong.lu@nokia.com>
Reviewed by Yongjun.
DESC: Browser defaults font family to "Nokia Sans S60" which is not supported under variant 7 build. The system has to default to another font family. If the phone language is English, the system defaults the font family to "Series 60 Hindi" which contains fonts for Greek. If the phone language is set to Greek, the system default the font to "Series 60 ZDigi" which does not contains fonts for Greek. That is why the same variant 7 build supports Greek under English and Automatic Language settings while it does not under Greek language setting. My fix is setting the font family to "Series 60 Hindi" if the phone language is set to Geek language.
- BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):
Merge from ccb revision 17537
- 1:37 PM Changeset in webkit [17543] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by Mitz and Geoff.
Test for <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
- fast/forms/textarea-scrollbar-expected.checksum: Added.
- fast/forms/textarea-scrollbar-expected.png: Added.
- fast/forms/textarea-scrollbar-expected.txt: Added.
- fast/forms/textarea-scrollbar.html: Added.
WebCore:
Reviewed by Mitz and Geoff.
- Fix for: <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105) <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing) <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
Test: fast/forms/textarea-scrollbar.html
To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock. This should make them
a lot more stable. In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
- rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setStyle): (WebCore::RenderTextControl::createDivStyle): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::baselinePosition): (WebCore::RenderTextControl::nodeAtPoint): (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout. (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop):
- rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
- 1:36 PM Changeset in webkit [22460] by
-
- 1 edit1 add in branches/WindowsMerge/WebCore
2006-11-02 Anders Carlsson <acarlsson@apple.com>
Reviewed by Oliver.
Add forked copy of CursorWin.cpp
- platform/win/CursorWin.cpp: Added.
- 10:50 AM Changeset in webkit [17542] by
-
- 2 edits in tags/WebKit-521.29.2/WebKit
Versioning
- 10:48 AM Changeset in webkit [17541] by
-
- 2 edits in tags/WebKit-521.29.2/WebKit
merging fix for <rdar://problem/4801351>
- 10:43 AM Changeset in webkit [17540] by
-
- 1 copy in tags/WebKit-521.29.2
New tag.
- 10:12 AM Changeset in webkit [17539] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff Garen
- editing/Selection.cpp: (WebCore::Selection::showTreeForThis): this debugging method now displays start offset and end offset, at Darin's suggestion
- 9:44 AM Changeset in webkit [17538] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Maciej.
- Changed the test to take into account the JavaScript standard's interesting take on DST. According to the standard DST should not reflect historically accurate information but should rather interpolate from a comparable year. This test used to show historically accurate information but now reflects the results of interpolating.
- fast/js/date-big-setdate-expected.txt:
- fast/js/resources/date-big-setdate.js:
- 8:38 AM Changeset in webkit [17537] by
-
- 2 edits in S60/trunk/WebKit
2006-10-31 zhalu <zhaosong.lu@nokia.com>
Reviewed by <yongjun.zhang@nokia.com>
DESC: Browser defaults font family changes for Greek build
- BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):
- 8:13 AM Changeset in webkit [17536] by
-
- 3 edits in S60/branches/3.1m/WebCore
2006-11-01 w3liu <wei.liu@nokia.com>
Reviewed by <yongjun.zhang@nokia.com>
DESC: Thai text rendering fails when using HTTPS.
http://bugs.webkit.org/show_bug.cgi?id=11486
WARNING: NO TEST CASES ADDED OR CHANGED
- ChangeLog:
- kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (KWQTextDecoder::~KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode): (QTextCodec::PrepareForExit):
- kwq/KWQTextCodec.h:
Merge from r17535 from main branch
- 8:04 AM Changeset in webkit [17535] by
-
- 3 edits in S60/trunk/WebCore
2006-11-01 w3liu <wei.liu@nokia.com>
Reviewed by <yongjun.zhang@nokia.com>
DESC: handle truncated text fragments as input string
http://bugs.webkit.org/show_bug.cgi?id=11486
Thai text rendering fails when using HTTPS
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode):
- kwq/KWQTextCodec.h:
Nov 1, 2006:
- 7:59 PM Changeset in webkit [17534] by
-
- 3 edits in trunk/WebKitTools
2006-11-01 Stephanie Lewis <Stephanie Lewis>
Reviewed by Kevin.
Fixed bug where additional arguments got fed to xcode and jsdriver.pl
Since testkjs is being built before the tests are run, we don't need
to build it with webkit.
Fixes bugs
http://bugs.webkit.org/show_bug.cgi?id=11462
http://bugs.webkit.org/show_bug.cgi?id=6168
- Scripts/build-webkit:
- Scripts/run-javascriptcore-tests:
- 7:56 PM Changeset in webkit [17533] by
-
- 2 edits in tags/WebCore-521.29.4/WebCore
Versioning
- 7:52 PM Changeset in webkit [17532] by
-
- 10 edits16 adds in trunk
LayoutTests:
Reviewed by darin
<rdar://problem/4062865>
Copy/paste of a select element fails to include the options
Updated to reflect fix:
- editing/pasteboard/4641033-expected.checksum:
- editing/pasteboard/4641033-expected.png:
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/4641033.html:
Added:
- editing/inserting/before-after-input-element-expected.checksum: Added.
- editing/inserting/before-after-input-element-expected.png: Added.
- editing/inserting/before-after-input-element-expected.txt: Added.
- editing/inserting/before-after-input-element.html: Added.
- editing/pasteboard/input-field-1-expected.checksum: Added.
- editing/pasteboard/input-field-1-expected.png: Added.
- editing/pasteboard/input-field-1-expected.txt: Added.
- editing/pasteboard/input-field-1.html: Added.
- editing/pasteboard/select-element-1-expected.checksum: Added.
- editing/pasteboard/select-element-1-expected.png: Added.
- editing/pasteboard/select-element-1-expected.txt: Added.
- editing/pasteboard/select-element-1.html: Added.
- editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
- editing/selection/select-element-paragraph-boundary-expected.png: Added.
- editing/selection/select-element-paragraph-boundary-expected.txt: Added.
- editing/selection/select-element-paragraph-boundary.html: Added.
WebCore:
Reviewed by darin
<rdar://problem/4062865>
Copy/paste of a select element fails to include the options
- editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added paragraphBoundary.
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added checks for input elements and textareas. Insertion operations would fail when performed just before/after one of these elements b/c the content would be put inside the element. (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non editable content, and made the code to stop at an root faster (don't check isDescendantOf on every iteration). (WebCore::enclosingNodeOfType): Ditto. (WebCore::enclosingList): Ditto. (WebCore::enclosingListChild): Ditto. Added a FIXME, this function seems inappropriately named.
- editing/markup.cpp: (WebCore::startMarkup): Use the text node's value instead of its rendered content for text nodes inside select elements. One might also turn off annotation when createMarkup enters a select element, but createMarkup is iterative, not recursive, so doing so would be complicated. (WebCore::createMarkup): Add markup for unrendered nodes if they are descendants of a select element.
- editing/visible_units.cpp: (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock. Fixes bug where various replaced elements can't be copied when they are the only thing selected. (WebCore::endOfParagraph): Ditto.
- 7:36 PM Changeset in webkit [17531] by
-
- 3 edits in tags/WebCore-521.29.4/WebCore
Merging change.
- 7:26 PM Changeset in webkit [17530] by
-
- 1 copy in tags/WebCore-521.29.4
new tag.
- 6:07 PM Changeset in webkit [22459] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
- 5:46 PM Changeset in webkit [22458] by
-
- 3 edits8 adds in branches/WindowsMerge/WebCore
2006-11-01 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
Adding SVG_SUPPORT to Boomer.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/build-generated-files.sh:
- kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Added. (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter): (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFilterQuartz::setOutputImage): (WebCore::KCanvasFilterQuartz::inputImage):
- platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
- 5:41 PM Changeset in webkit [17529] by
-
- 19 edits2 moves in trunk/WebCore
2006-11-01 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
Converting more or kcanvas/quartz from Obj-C to C++
Minor SVG updates
compatibility fixes
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/device/KRenderingPaintServer.h:
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added. (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
- kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
- kcanvas/device/quartz/QuartzSupport.h:
- ksvg2/css/SVGCSSStyleSelector.cpp:
- ksvg2/misc/KCanvasRenderingStyle.h:
- ksvg2/scripts/cssmakeprops:
- ksvg2/scripts/cssmakevalues:
- ksvg2/scripts/make_names.pl:
- ksvg2/svg/SVGAnimateColorElement.cpp:
- ksvg2/svg/SVGAnimateTransformElement.cpp:
- ksvg2/svg/SVGAnimationElement.cpp:
- ksvg2/svg/SVGMaskElement.cpp:
- ksvg2/svg/SVGPatternElement.cpp:
- ksvg2/svg/svgpathparser.cpp:
- platform/Path.cpp:
- platform/graphics/svg/SVGResourceImage.h:
- rendering/RenderPath.cpp:
- rendering/SVGRenderAsText.cpp:
- 5:02 PM Changeset in webkit [17528] by
-
- 2 edits in trunk/LayoutTests
- temporarily passing a test so that it does not interfere with others testing.
- fast/js/date-big-setdate-expected.txt:
- 4:56 PM Changeset in webkit [17527] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Tim Hatcher
Added accessor to get the source directory for use in client scripts
- Scripts/webkitdirs.pm:
- 4:43 PM Changeset in webkit [17526] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- Fix a regression from r17521: painting of and crash caused by tables with collapsed borders
- rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to r17521, 'paintInfo' was the local variable. Now 'info' is the local variable and 'paintInfo' is the parameter, which we were accidently modifying.
- 3:34 PM Changeset in webkit [17525] by
-
- 4 edits in trunk/LayoutTests
Fixing typo. Changed repaintTest to runRepaintTest.
- fast/repaint/overflow-outline-repaint-expected.checksum:
- fast/repaint/overflow-outline-repaint-expected.png:
- fast/repaint/overflow-outline-repaint.html:
- 3:28 PM Changeset in webkit [17524] by
-
- 4 edits12 adds in trunk
LayoutTests:
Reviewed by Mitz.
Tests for http://bugs.webkit.org/show_bug.cgi?id=11277
REGRESSION: Incomplete repaint of overflow areas when deleting
- fast/repaint/overflow-delete-line-expected.checksum: Added.
- fast/repaint/overflow-delete-line-expected.png: Added.
- fast/repaint/overflow-delete-line-expected.txt: Added.
- fast/repaint/overflow-delete-line.html: Added.
- fast/repaint/overflow-scroll-delete-expected.checksum: Added.
- fast/repaint/overflow-scroll-delete-expected.png: Added.
- fast/repaint/overflow-scroll-delete-expected.txt: Added.
- fast/repaint/overflow-scroll-delete.html: Added.
- fast/repaint/overflow-outline-repaint-expected.checksum: Added.
- fast/repaint/overflow-outline-repaint-expected.png: Added.
- fast/repaint/overflow-outline-repaint-expected.txt: Added.
- fast/repaint/overflow-outline-repaint.html: Added.
WebCore:
Reviewed by Mitz.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=11277 REGRESSION: Incomplete repaint of overflow areas when deleting
Restrict the repaint rect for overflow blocks after the height has been fully computed.
Also, adjust the repaint rect coordinates for the scroll offset.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 3:26 PM Changeset in webkit [22457] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Reviewed by Adam.
Build fix from Sam Weinig's check-in. i.p in the PaintInfo is now
i.context
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):
- 3:22 PM Changeset in webkit [17523] by
-
- 2 edits in trunk/WebKit
Reviewed by Adam Roben
- fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
- WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
- 2:42 PM Changeset in webkit [17522] by
-
- 2 edits in S60/trunk/WebKit
2006-11-01 sareen <shyam.sareen@nokia.com>
Reviewed by Sachin.
DESC: Cenrep UID define change in HttpDownloadObserver.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11488
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
- 1:49 PM Changeset in webkit [17521] by
-
- 51 edits in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
Rename the "p" member variable of the PaintInfo struct to "context"
- Renames the 'p' and 'r' member variables of the PaintInfo struct to 'context' and 'rect' respectively.
- Assorted surrounding cleanups.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
- rendering/EllipsisBox.h:
- rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations):
- rendering/InlineFlowBox.h:
- rendering/InlineRunBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
- rendering/InlineTextBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::RenderBlock::paintSelection): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations):
- rendering/RenderBox.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::attachLineBox): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLinesFromChangedChild): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox): (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::getAbsoluteRepaintRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::caretRect): (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintOutline): (WebCore::RenderFlow::paintOutlineForLine):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
- rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
- rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintingRootForChildren): (WebCore::RenderObject::shouldPaintWithinRoot): (WebCore::RenderObject::printBoxDecorations):
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
- rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline): (WebCore::RenderTableSection::setNeedCellRecalc):
- rendering/RenderText.h: (WebCore::RenderText::renderName): (WebCore::RenderText::paint): (WebCore::RenderText::element):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
- rendering/RenderTheme.h: (WebCore::RenderTheme::RenderTheme): (WebCore::RenderTheme::~RenderTheme): (WebCore::RenderTheme::controlSupportsTints): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::themeChanged): (WebCore::RenderTheme::supportsHover): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::setCheckboxSize): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::setRadioSize): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::setButtonSize): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton):
- rendering/RenderView.cpp: (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- rendering/RenderWidget.h: (WebCore::RenderWidget::isWidget):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
- rendering/RootInlineBox.h:
- rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
- 1:31 PM Changeset in webkit [22456] by
-
- 4 edits in branches/WindowsMerge/WebCore
2006-11-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::createJavaAppletWidget): Ask the plugin database to create a java applet plugin.
- platform/win/TemporaryLinkStubs.cpp: Remove FrameWin::createJavaAppletWidget.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Don't look for the Sun Java plugin anymore.
- 12:34 PM Changeset in webkit [17520] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Brady.
- Fixes many JavaScriptCore tests in other timezones. The root problem is that on mac localtime() returns historically accurate information for DST, but the JavaScript spec explicitly states to not take into account historical information but rather to interpolate from valid years.
- kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset):
- 12:07 PM Changeset in webkit [22455] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-11-01 Anders Carlsson <acarlsson@apple.com>
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Build fix.
- 12:03 PM Changeset in webkit [22454] by
-
- 4 edits in branches/WindowsMerge/WebCore
2006-11-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Convert plugin code over to using ResourceResponse.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didFinishLoading):
- plugins/win/PluginStreamWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 11:43 AM Changeset in webkit [17519] by
-
- 3 edits in trunk/WebCore
2006-11-01 Anders Carlsson <acarlsson@apple.com>
Reviewed by Oliver, Brady.
- platform/network/ResourceResponse.h: (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): Add getters and setters for last modified dadte.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Fetch the last modified date. Add correct offset to expired date.
- 11:25 AM Changeset in webkit [17518] by
-
- 2 edits in trunk/WebCore
Build fix for 64-bit.
- 8:35 AM Changeset in webkit [17517] by
-
- 5 edits in S60/trunk/WebKit
2006-11-01 sareen <shyam.sareen@nokia.com>
Reviewed by yongjun.zhang@nokia.com.
DESC: add an UI option to disable flash content
http://bugs.webkit.org/show_bug.cgi?id=11473
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserView/inc/WebKitControl.h: (CWebKitControl::DisableFlashSetting):
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::HandleDisableFlashSetting): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
- Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL):
- 3:47 AM Changeset in webkit [17516] by
-
- 2 edits in trunk/WebCore
2006-11-01 David Kilzer <ddkilzer@kilzer.net>
Reviewed by Mitz.
Added missing "break;" statement in switch statement from r17493.
Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Oct 31, 2006:
- 11:53 PM Changeset in webkit [17515] by
-
- 2 edits in trunk/WebCore
2006-10-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- fix image dragging
This is covered by editing/selection/drag-to-contenteditable-iframe.html
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for HTML IMG elements. (WebCore::HitTestResult::absoluteImageURL): Ditto.
- 11:15 PM Changeset in webkit [17514] by
-
- 2 edits in trunk/WebKit
2006-10-31 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html
- Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): Add null check.
- 10:13 PM Changeset in webkit [17513] by
-
- 2 edits in trunk/WebKitSite
2006-10-31 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Update WebKit blog link to prevent pointless redirects.
- nav.inc:
- 9:45 PM Changeset in webkit [17512] by
-
- 3 edits in trunk/WebKitTools
2006-11-01 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Update references to webkit.opendarwin.org to webkit.org in Spinneret and WebKit.app.
- Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
- WebKitLauncher/WebKitNightlyEnabler.m: (cleanUpAfterOurselves):
- 7:22 PM Changeset in webkit [17511] by
-
- 6 edits in trunk
WebCore:
Reviewed by Maciej.
This adds the back-end of the remaining WebElementDictionary
functions into HitTestResult.
- WebCore.exp:
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::displayString): This is nearly identical to the displayString() defined in DOMInternal.mm except that it returns a String instead of an NSString. The old code path used the DOMInternal method, so I made a new one here for the new code path. (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::image): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::titleDisplayString): (WebCore::HitTestResult::textContent):
- rendering/HitTestResult.h:
WebKit:
Reviewed by Maciej.
This creates local functions for the remaining WebElementDictionary
members that calls into HitTestResult instead of doing magical
things with the Objective-C DOM classes.
- ChangeLog:
- Misc/WebElementDictionary.m: (addLookupKey): The values of the dictionary are now just selectors. They used to be WebElementMethods which were WebElementTargetObjects associated with selectors, but none of that is needed any more. (+[WebElementDictionary initializeLookupTable]): All selectors are now local functions, no more WebElementTargetObjects. (-[WebElementDictionary objectForKey:]): No more target objects! (-[WebElementDictionary _domNode]): Call into HitTestResult member variable. (-[WebElementDictionary _altDisplayString]): Same. (-[WebElementDictionary _image]): Same. (-[WebElementDictionary _absoluteImageURL]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _absoluteLinkURL]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _titleDisplayString]): Same. (-[WebElementDictionary _textContent]): Same.
- 7:11 PM Changeset in webkit [17510] by
-
- 3 edits in trunk/WebKitTools
2006-10-31 Mark Rowe <bdash@webkit.org>
Reviewed by Stephanie.
Limit build slaves to a single build to prevent concurrent builds on a single slave from significantly increasing build time.
- BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Adjust slave distribution, and make use of a SlaveLock.
- BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Remove unused Qt build factory.
- 6:59 PM Changeset in webkit [17509] by
-
- 2 edits in trunk/WebCore
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::markMisspellings): Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
- 6:49 PM Changeset in webkit [17508] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej
- fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
The foundation of this was in my last checkin. This checkin is all about displaying
the correct string in the toolTip.
- dom/DocumentMarker.h: New description field in this struct.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): When adding a grammar marker, supply the appropriate description. Also, added a comment about the remaining work to make grammar checking return sensible answers. (WebCore::FrameMac::markMisspellings): ditto (yes, still needs some refactoring to minimize duplicated code)
- dom/Document.h:
- dom/Document.cpp: (WebCore::Document::addMarker): Now takes an optional description string (WebCore::Document::markerContainingPoint): New function, returns a pointer to the (first) marker of the specified type whose rect contains the specified point, or 0 if none.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Replaced hardwired string placeholder implementation with code that uses markerContainingPoint and gets the description from the marker.
- 6:33 PM Changeset in webkit [22453] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Maciej.
- merged changes for:
- fixed "Stop and reload don't work on the WebView" http://bugs.webkit.org/show_bug.cgi?id=11285
Most of htis was already in this tree.
- WebFrame.cpp: (WebFrame::stopLoading): Implement. Added FIXME.
- 6:14 PM Changeset in webkit [17507] by
-
- 3 edits2 adds in trunk
Reviewed by Beth.
Fixed http://bugs.webkit.org/show_bug.cgi?id=11477
REGRESSION: GMail crashes in KJS::FunctionImp::callerGetter
- kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): Removed unnecessary braces. (KJS::FunctionImp::callerGetter): More logical NULL checking.
LayoutTests:
Added test for accessing the 'caller' property from inside an event
listener.
- fast/events/caller-access-from-event-listener-expected.txt: Added.
- fast/events/caller-access-from-event-listener.html: Added.
- 5:35 PM Changeset in webkit [17506] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
Fixed crash resulting from Darin's last patch to remove BrowserExtension.
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createWindow):
- manual-tests/window-open-features-parsing.html: Updated for clarity.
- 4:56 PM Changeset in webkit [17505] by
-
- 1 edit in trunk/WebKit/WebView/WebView.mm
Build fix for Leopard.
- 4:33 PM Changeset in webkit [22452] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-31 Steve Falkenburg <sfalken@apple.com>
Yet more B&I build fixes
Another missing .h file from the vcproj
- WebCore.vcproj/WebCore.vcproj:
- 3:56 PM Changeset in webkit [17504] by
-
- 20 edits2 adds in trunk
LayoutTests:
Added layout test for copying password field.
- editing/pasteboard/copy-in-password-field-expected.txt: Added.
- editing/pasteboard/copy-in-password-field.html: Added.
WebCore:
Reviewed by Alice.
Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.
Layout tests pass.
Renamed "may*" to "can*" because "can" is more accurate (these functions
aren't just about permission) and it matches WebKit.
(WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
password field. Now that WebCore fully implements canCopy(), it doesn't just
mean "the selection is not in a password field" anymore.
(-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
The fact that it's not called anymore may represent a security issue, but I
don't see how commented-out code will help reveal the issue, and the
bridge is going away, anyway.
- editing/SelectionController.h: Changed selection() calls to references to m_sel, to match the rest of the file.
WebKit:
Reviewed by Alice.
Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.
- WebCoreSupport/WebFrameBridge.mm:
- WebView/WebHTMLView.m: (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canCopy]): (-[WebHTMLView _canCut]): (-[WebHTMLView _canDelete]): (-[WebHTMLView _canPaste]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray _expandSelectionToGranularity:]):
- 3:37 PM Changeset in webkit [17503] by
-
- 13 edits in trunk
LayoutTests:
Reviewed by harrison
Updated these tests to mention the bug that they demonstrate:
- editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
- editing/pasteboard/nested-blocks-with-text-area-expected.png:
- editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- editing/pasteboard/nested-blocks-with-text-area.html:
- editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
- editing/pasteboard/nested-blocks-with-text-field-expected.png:
- editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- editing/pasteboard/nested-blocks-with-text-field.html:
WebCore:
Reviewed by harrison
<rdar://problem/4711063>
Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test insertion and plain text string creation unless we need the string for a BeforeTextInserted event handler or for a plain text only region. (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved code here from ReplacementFragment's constructor. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a FIXME.
- editing/ReplaceSelectionCommand.h:
- 3:10 PM Changeset in webkit [17502] by
-
- 6 edits in trunk/WebCore
2006-10-31 Ada Chan <adachan@apple.com>
Reviewed by Adam
Correct forward declarations of the HitTestRequest struct.
- 3:03 PM Changeset in webkit [17501] by
-
- 11 edits in trunk
WebCore:
Reviewed by Beth and Adam
Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
next I'll make it use a string that's relevant for a specific grammar error.
- WebCore.exp: export symbol for spellingToolTip function
- rendering/HitTestResult.h:
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): new function, returns the string to be used in a tool tip that describes the questionable grammar
- rendering/InlineTextBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): now takes a style and font, needed to compute the rect representing the range containing questionable grammar. Computes the rect and associates it with the marker. (WebCore::InlineTextBox::paintDocumentMarkers): Pass in the style and font now needed by paintSpellingOrGrammarMarker
WebKit:
Reviewed by Beth and Adam
Display a tooltip when hovering over marked bad grammar.
- Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): support spelling tool tip (-[WebElementDictionary _spellingToolTip]): new method, calls through to HitTestResult
- WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Check for a spelling tool tip; if found, prefer it over the other possible tool tips. Check for empty strings instead of just nil strings being, since values from WebElementDictionary are empty strings.
- WebView/WebViewPrivate.h: declare new string constant WebElementSpellingToolTipKey
- WebView/WebView.mm: define new string constant WebElementSpellingToolTipKey
- 3:01 PM Changeset in webkit [17500] by
-
- 2 edits in trunk/WebCore
Removed commented out variable from last checkin.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- 2:51 PM Changeset in webkit [17499] by
-
- 2 edits in trunk/WebCore
Build fix
- 2:15 PM Changeset in webkit [22451] by
-
- 2 edits in branches/WindowsMerge/WebCore
- 2:10 PM Changeset in webkit [17498] by
-
- 10 edits4 adds in trunk
LayoutTests:
Reviewed by Adam.
Tests for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
- fast/forms/listbox-onchange-expected.txt: Added.
- fast/forms/listbox-onchange.html: Added.
- fast/forms/listbox-selection-expected.txt: Added.
- fast/forms/listbox-selection.html: Added.
WebCore:
Reviewed by Adam.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
Tests:
- LayoutTests/fast/forms/listbox-selection.html
- LayoutTests/fast/forms/listbox-onchange.html
- html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress. Added 2 vectors to cache selection state. One is kept so that the previous selection state can be restored as the active selection grows and shrinks. And one for onChange, that is updated after onChange is fired. Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables. (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent. (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events. (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state. (WebCore::HTMLSelectElement::setExtent): Added. (WebCore::HTMLSelectElement::updateListBoxSelection): Added. (WebCore::HTMLSelectElement::listBoxOnChange): Added.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible. (WebCore::RenderListBox::listIndexAtOffset): Added. Replaces optionAtPoint, which is no longer used. (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent. (WebCore::RenderListBox::stopAutoscroll): Added. Tells the select element to fire onChange. This is needed because the autoscroll can end from a mouseUp outside of the list box, and the select element won't get a mouseUp event directly. But the frame will stop the autoscroll at that point, and now we can notify the select element from here. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method. (WebCore::RenderListBox::listIndexIsVisible): Added. (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
- page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, we don't try to use the pointer to that renderer to call stopAutoscroll. This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
- rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
- rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
- 2:04 PM Changeset in webkit [17497] by
-
- 2 edits in S60/trunk/WebCore
2006-10-31 sareen <shyam.sareen@nokia.com>
Reviewed by <zbujtas@gmail.com>.
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11473
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQObjectWidget.cpp: (QObjectWidget::hasResized): (QObjectWidget::focusable):
- 1:55 PM Changeset in webkit [17496] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing typo in ChangeLog. This is the last one, I swear.
- 1:53 PM Changeset in webkit [17495] by
-
- 1 edit1 add in trunk/WebCore
Forgot to check this in a minute ago. Oops!! Thanks Mitz!
- rendering/HitTestRequest.h: Added. (WebCore::HitTestRequest::HitTestRequest):
- 1:48 PM Changeset in webkit [17494] by
-
- 55 edits in trunk
WebCore:
Reviewed by Maciej.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
should be split into HitTestRequest and HitTestResult
This patch creates a new struct called HitTestRequest that holds
the three boolean values (readonly, active, and mouseMove) that
were formerly a part of HitTestRequest. all hitTest() and
nodeAtPoint() functions now take a HitTestRequest in addition to
the HitTestResult.
WebKit:
Reviewed by Maciej.
Small tweaks to WebKit because of http://bugs.webkit.org/
show_bug.cgi?id=11461 HitTestResult should be split into
HitTestRequest and HitTestResult
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): The HitTestResult initializer now just takes a point.
- 1:32 PM Changeset in webkit [22450] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-31 Steve Falkenburg <sfalken@apple.com>
Remove extra files I accidently added
- WebCore.vcproj/WebCore.vcproj:
- 1:03 PM Changeset in webkit [17493] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej.
Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSValueKeywords.in:
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- page/FrameView.cpp: (WebCore::selectCursor):
- rendering/RenderStyle.h:
- 12:56 PM Changeset in webkit [17492] by
-
- 8 edits5 moves in trunk/WebCore
2006-10-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff.
Converting Obj-C++ to C++ in kcanvas
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/device/quartz/KCanvasFilterQuartz.h:
- kcanvas/device/quartz/KCanvasFilterQuartz.mm:
- kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
- kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
- kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
- kcanvas/device/quartz/QuartzSupport.cpp: Added.
- kcanvas/device/quartz/QuartzSupport.h:
- kcanvas/device/quartz/QuartzSupport.mm: Removed.
- platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
- platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
- platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
- platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
- 12:52 PM Changeset in webkit [17491] by
-
- 2 edits in trunk/JavaScriptCore
2006-10-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff.
Adding definition for PLATFORM(CI)
- wtf/Platform.h:
- 12:34 PM Changeset in webkit [17490] by
-
- 11 edits1 add1 delete in trunk
LayoutTests:
Reviewed by harrison
- editing/execCommand/create-list-1.html: Removed.
- editing/execCommand/create-list-with-hr-expected.checksum:
- editing/execCommand/create-list-with-hr-expected.png:
- editing/execCommand/create-list-with-hr-expected.txt:
- editing/execCommand/remove-list-1-expected.checksum:
- editing/execCommand/remove-list-1-expected.png:
- editing/execCommand/remove-list-1-expected.txt:
- fast/text/attributed-substring-from-range-001-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
Completely back out r17276 because of performance issues.
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleReplacedElement): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::TextIterator::emitCharacter): (WebCore::TextIterator::range): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): (WebCore::SimplifiedBackwardsTextIterator::emitNewline): (WebCore::SimplifiedBackwardsTextIterator::range): (WebCore::CharacterIterator::range): (WebCore::TextIterator::rangeFromLocationAndLength):
- editing/TextIterator.h: (WebCore::TextIterator::atEnd): (WebCore::SimplifiedBackwardsTextIterator::atEnd):
- 12:01 PM Changeset in webkit [17489] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Build fix. Generated headers need to be added to 'Copy Generated Headers' and not 'Copy Headers'.
- 11:34 AM Changeset in webkit [22449] by
-
- 4 edits in branches/WindowsMerge
Fixes for Boomer submission, bumped version number.
- 11:31 AM Changeset in webkit [17488] by
-
- 14 edits3 adds in trunk
WebCore:
Reviewed by Brady.
- got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction
- loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
- loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::triggeringAction): Ditto. (WebCore::DocumentLoader::setTriggeringAction): Ditto.
- loader/FrameLoader.h: Changed action parameters to NavigationAction.
- loader/FrameLoaderClient.h: Changed action parameters to NavigationAction. Removed elementForEvent.
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::reload): Ditto. (WebCore::FrameLoader::checkNewWindowPolicy): Ditto. (WebCore::FrameLoader::checkNavigationPolicy): Ditto. (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto. (WebCore::FrameLoader::post): Ditto.
- loader/NavigationAction.h: Added.
- loader/NavigationAction.cpp: Added.
- loader/mac/NavigationActionMac.mm: Added.
- loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
- WebCore.xcodeproj/project.pbxproj: Updated for new files.
- WebCore.exp: Updated.
WebKit:
Reviewed by Brady.
- got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction
- WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction. Made elementForEvent non-virtual. Added actionDictionary function.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type, and used actionDictionary to make the action dictionary. (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto. (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore that creates the action dictionary (from a NavigationAction).
- WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction instead of a dictionary for the action parameters.
- 11:19 AM Changeset in webkit [17487] by
-
- 2 edits in trunk/WebCore
2006-10-31 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Build fix
- platform/win/CookieJarWin.cpp: (WebCore::cookies):
- 11:03 AM Changeset in webkit [17486] by
-
- 9 edits2 moves2 adds1 delete in trunk/WebCore
Reviewed by Maciej. Landed by Adam.
Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
as dicussed with Dave. Also kill the outdated DESIGN document.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/DESIGN: Removed.
- kcanvas/KCanvasFilters.cpp:
- kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
- kcanvas/KCanvasTreeDebug.h: Ditto.
- kcanvas/device/KRenderingPaintServerGradient.cpp:
- kcanvas/device/KRenderingPaintServerPattern.cpp:
- kcanvas/device/KRenderingPaintServerSolid.cpp:
- platform/graphics/svg/SVGResourceClipper.cpp:
- rendering/RenderTreeAsText.cpp:
- rendering/SVGRenderTreeAsText.cpp: Added.
- rendering/SVGRenderTreeAsText.h: Added. (WebCore::operator<<):
- 10:43 AM Changeset in webkit [17485] by
-
- 2 edits in trunk/WebCore
2006-10-31 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
Includes some CRLF -> LF fixups.
- platform/win/CookieJarWin.cpp: (WebCore::cookies):
- 10:39 AM Changeset in webkit [22448] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Steve.
- Added basic functionality for running javascript from the address bar. Currently no return results are evaluated so use alert messages to see the results.
- WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
- 10:23 AM Changeset in webkit [22447] by
-
- 11 edits in branches/WindowsMerge
WebCoreWin:
Build fixes.
- WebCore.vcproj/WebCore.vcproj: Add new platform/graphics directory to our include path, and copy headers from there for WebKit's benefit.
- bridge/win/FrameWin.cpp: Update accessors of FrameLoadRequest. (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
- plugins/win/PluginViewWin.cpp: Ditto. (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
- plugins/win/PluginViewWin.h: Correct forward declaration of FrameLoadRequest.
WebKitWin:
Build fixes.
- WebEditorClient.cpp: Add stubs for new methods. (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag):
- WebEditorClient.h: Add declarations for new methods.
- WebFrame.cpp: Fix #includes to use new platform/graphics directory.
- WebView.cpp: Ditto.
- WebKit.vcproj/WebKit.vcproj: Add platform/graphics to include path.
- 10:19 AM Changeset in webkit [17484] by
-
- 3 edits in trunk/WebCore
Reviewed by Steve.
Fix some incorrect forward declarations.
- loader/FrameLoader.h:
- page/Frame.h:
- 10:16 AM Changeset in webkit [17483] by
-
- 6 edits3 adds in trunk
2006-10-31 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=4166
Function object does not support caller property
Test: fast/js/caller-property.html
- kjs/function.cpp: (KJS::FunctionImp::callerGetter): added (KJS::FunctionImp::getOwnPropertySlot): added if statement to handle callerGetter()
- kjs/function.h: added callerGetter() declaration
- kjs/identifier.h: added caller property macro
- tests/mozilla/expected.html:
- 9:45 AM Changeset in webkit [17482] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
- fixed "Stop and reload don't work on the WebView" http://bugs.webkit.org/show_bug.cgi?id=11285
- COM/WebFrame.cpp: (WebFrame::stopLoading): Implement.
- COM/WebView.cpp: (WebView::stopLoading): ditto (WebView::reload): ditto
- 9:20 AM Changeset in webkit [17481] by
-
- 2 edits in trunk/WebKitQt
2006-10-31 Simon Hausmann <hausmann@kde.org>
Reviewed by Maciej.
- QtLauncher/main.cpp: (main): Declare our frame as main frame to the Page object. Fixes crashes on various web sites
- 8:49 AM Changeset in webkit [17480] by
-
- 2 edits in trunk/WebKitTools
- DumpRenderTree/DumpRenderTree.m: Instead of allocating a single local pasteboard, allocate any number of local pasteboards. (main): Allocate the dictionary of pasteboards. (+[DumpRenderTreePasteboard _pasteboardWithName:]): Allocate a pasteboard, given a name. (+[LocalPasteboard alloc]): Added, so we don't have to call NSAllocateObject explicitly elsewhere. (-[LocalPasteboard addTypes:owner:]): Added a check that the owner responds to the selector rather than calling unconditionally.
- 8:40 AM Changeset in webkit [17479] by
-
- 2 edits in trunk/WebCore
- WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to try to fix the build on the buildbot.
- 8:16 AM Changeset in webkit [17478] by
-
- 2 edits in trunk/WebCore
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds. (WebCore::FrameMac::markMisspellings): Ditto.
- 6:26 AM Changeset in webkit [17477] by
-
- 2 edits in trunk/WebCore
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): build fix: needed #ifndef BUILDING_ON_TIGER in one more place
- 6:18 AM Changeset in webkit [17476] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam Roben
- fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
This patch introduces much of the guts of grammar checking, though still not enough to actually
check grammar sensibly, due to:
<rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
context passed to grammar checker
- platform/Logging.h:
- platform/Logging.cpp: new log channel SpellingAndGrammar
- bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): initialize new log channel
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest in the event of a tie), and do further processing with that one (select range; create marker that causes range to be visibly marked with a funky underline; update spelling panel appropriately). (WebCore::FrameMac::markMisspellings): More or less the same types of changes as in advanceToNextMisspelling The loops are structured just differently enough to make sharing code between these two functions a little tricky, so I decided to save that for a later patch.
(WebCore::FrameMac::respondToChangedSelection):
remove grammar markers when we remove spelling markers
- 4:36 AM Changeset in webkit [17475] by
-
- 2 edits in trunk/WebCore
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Mitz.
Fix Qt/Linux build with older gcc3.3.4.
- bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
- 4:24 AM Changeset in webkit [17474] by
-
- 1 delete in trunk/WebCore/kcanvas/device/qt/KCanvasClipperQt.h
Remove obsolete KCanvasClipperQt.h which should have been removed in r17467.
- 3:47 AM Changeset in webkit [17473] by
-
- 11 edits in trunk
2006-10-31 Zack Rusin <zack@kde.org>
Reviewed by Mitz.
Fix the Qt build after last nights changes.
- platform/qt/FrameQt.cpp:
- platform/qt/EditorClientQt.h:
- platform/qt/EditorClientQt.cpp:
- platform/graphics/svg/qt/SVGResourceImageQt.cpp:
- platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
- CMakeLists.txt:
- kcanvas/device/qt/KRenderingDeviceQt.cpp:
2006-10-31 Zack Rusin <zack@kde.org>
Reviewed by Mitz.
Fix the Qt build after last nights changes.
- QtLauncher/CMakeLists.txt:
- WebKitPart/CMakeLists.txt:
Oct 30, 2006:
- 9:50 PM Changeset in webkit [17472] by
-
- 2 edits in trunk/WebKitTools
- fixed build
- DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]): Don't use CFPasteboard.
- 9:49 PM Changeset in webkit [22446] by
-
- 5 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
- remove BrowserExtension
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
- platform/win/TemporaryLinkStubs.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 9:46 PM Changeset in webkit [17471] by
-
- 17 edits6 deletes in trunk/WebCore
Reviewed by Anders.
- remove BrowserExtension
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
- bridge/BrowserExtension.h: Removed.
- bridge/mac/BrowserExtensionMac.h: Removed.
- bridge/mac/BrowserExtensionMac.mm: Removed.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected):
- bridge/win/BrowserExtensionWin.cpp: Removed.
- bridge/win/BrowserExtensionWin.h: Removed.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
- loader/FrameLoader.h:
- loader/icon/IconLoader.cpp:
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createWindow):
- page/Frame.cpp: (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
- page/Frame.h:
- page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isEmpty): (WebCore::FrameLoadRequest::resourceRequest): (WebCore::FrameLoadRequest::frameName): (WebCore::FrameLoadRequest::setFrameName):
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
- platform/gdk/BrowserExtensionGdk.h: Removed.
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk):
- platform/gdk/TemporaryLinkStubs.cpp:
- platform/network/ResourceRequest.h: (WebCore::ResourceRequest::isEmpty):
- 9:45 PM Changeset in webkit [17470] by
-
- 2 edits in trunk/WebKit
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Fix comment.
- 9:29 PM Changeset in webkit [17469] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Tim H.
- Drosera/debugger.js: ParsedURL() object now recognizes local files
- 8:48 PM Changeset in webkit [17468] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Tim Hatcher.
- DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard. This should make our buildbot tests no longer need a pasteboard server.
- 8:17 PM Changeset in webkit [17467] by
-
- 57 edits13 moves7 adds10 deletes in trunk/WebCore
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Modified from original due to earlier reversion
Better SVG integration in WebKit, Part I.
The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- graphics/svg/SVGResource.cpp: Removed.
- graphics/svg/SVGResourceClipper.cpp: Removed.
- graphics/svg/SVGResourceClipper.h: Removed.
- graphics/svg/SVGResourceImage.h: Removed.
- graphics/svg/SVGResourceListener.h: Removed.
- graphics/svg/SVGResourceMarker.cpp: Removed.
- graphics/svg/SVGResourceMarker.h: Removed.
- graphics/svg/SVGResourceMasker.cpp: Removed.
- graphics/svg/SVGResourceMasker.h: Removed.
- kcanvas/KCanvasClipper.cpp: Removed.
- kcanvas/KCanvasClipper.h: Removed.
- kcanvas/KCanvasCreator.cpp: Removed.
- kcanvas/KCanvasCreator.h: Removed.
- kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
- kcanvas/KCanvasFilters.h:
- kcanvas/KCanvasImage.h: Removed.
- kcanvas/KCanvasMarker.cpp: Removed.
- kcanvas/KCanvasMarker.h: Removed.
- kcanvas/KCanvasMasker.cpp: Removed.
- kcanvas/KCanvasMasker.h: Removed.
- kcanvas/KCanvasResource.cpp: Removed.
- kcanvas/KCanvasResource.h: Removed.
- kcanvas/KCanvasResourceListener.h: Removed.
- kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
- kcanvas/device/KRenderingDevice.h:
- kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
- kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
- kcanvas/device/KRenderingPaintServerGradient.h:
- kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
- kcanvas/device/KRenderingPaintServerPattern.h:
- kcanvas/device/KRenderingPaintServerSolid.h:
- kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
- kcanvas/device/qt/KCanvasClipperQt.h:
- kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
- kcanvas/device/qt/KRenderingDeviceQt.h:
- kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
- kcanvas/device/qt/RenderPathQt.h: Removed.
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
- kcanvas/device/quartz/KCanvasItemQuartz.mm:
- kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
- kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
- kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
- kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
- kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
- kcanvas/device/quartz/QuartzSupport.mm:
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
- ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
- ksvg2/svg/SVGClipPathElement.h:
- ksvg2/svg/SVGFEImageElement.cpp:
- ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
- ksvg2/svg/SVGFilterElement.h:
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
- ksvg2/svg/SVGGradientElement.h:
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGLinearGradientElement.h:
- ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
- ksvg2/svg/SVGMarkerElement.h:
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
- ksvg2/svg/SVGMaskElement.h:
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
- ksvg2/svg/SVGPatternElement.h:
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGRadialGradientElement.h:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
- platform/GraphicsContext.cpp: Removed.
- platform/GraphicsContext.h: Removed.
- platform/GraphicsTypes.cpp: Removed.
- platform/GraphicsTypes.h: Removed.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsTypes.cpp: (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
- platform/graphics/GraphicsTypes.h: (WebCore::):
- platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
- platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
- platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
- platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
- platform/graphics/svg/SVGResourceImage.h: Added.
- platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
- platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
- platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
- platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
- platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
- platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
- platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
- platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
- platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
- platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
- platform/qt/GraphicsContextQt.cpp:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
- 7:53 PM Changeset in webkit [17466] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady
- minor cleanup to make future patches clearer
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test with "continue" to better match structure of similar code in markMisspellings; a few other style tweaks.
(WebCore::FrameMac::markMisspellings):
renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
a block just after a break and outdented accordingly.
- 7:23 PM Changeset in webkit [17465] by
-
- 3 edits2 adds in trunk/WebKitTools
Reviewed by Beth.
Reorganized project file into Delegates and Controllers groups, and split
UIDelegate stuff into a UIDelegate class.
A little birdy told me that I might end up adding some UIDelegate methods
to DRT soon.
- DumpRenderTree/DumpRenderTree.m: (main): (runTest):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 6:54 PM Changeset in webkit [17464] by
-
- 5 edits in trunk
WebCore:
Reviewed by Geoff Garen
WebCore part of change to push the code that updates the spelling panel
into WebCore, in preparation for some grammar-checking stuff.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): no more return value for this method, and update the spelling panel with the misspelled word here rather than in the WebKit callers.
WebKit:
Reviewed by Geoff Garen
- WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): removed code to update spelling panel; WebCore handles that now (-[NSArray showGuessPanel:]): ditto
- 6:36 PM Changeset in webkit [17463] by
-
- 3 edits in trunk/WebKit
- English.lproj/WebViewEditingContextMenu.nib/info.nib:
- English.lproj/WebViewEditingContextMenu.nib/objects.nib: Another wording change to match framework, post-Tiger: "Check Spelling" -> "Check Document Now"
- 6:33 PM Changeset in webkit [17462] by
-
- 72 edits2 copies13 adds in trunk/WebCore
liver Hunt <oliver@apple.com>
Reviewed by Anders.
Roll out last patch
- CMakeLists.txt:
- ChangeLog:
- WebCore.xcodeproj/project.pbxproj:
- graphics/svg/SVGResource.cpp:
- graphics/svg/SVGResourceClipper.cpp:
- graphics/svg/SVGResourceClipper.h:
- graphics/svg/SVGResourceImage.h:
- graphics/svg/SVGResourceListener.h:
- graphics/svg/SVGResourceMarker.cpp:
- graphics/svg/SVGResourceMarker.h:
- graphics/svg/SVGResourceMasker.cpp:
- graphics/svg/SVGResourceMasker.h:
- kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasClipper::KCanvasClipper): (WebCore::KCanvasClipper::~KCanvasClipper): (WebCore::KCanvasClipper::resetClipData): (WebCore::KCanvasClipper::addClipData): (WebCore::KCanvasClipper::clipData): (WebCore::KCanvasClipper::externalRepresentation): (WebCore::getClipperById):
- kcanvas/KCanvasClipper.h: Added. (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::KCClipDataList): (WebCore::KCClipDataList::addPath): (WebCore::KCanvasClipper::isClipper):
- kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
- kcanvas/KCanvasFilters.h:
- kcanvas/KCanvasImage.h: Added. (WebCore::KCanvasImage::KCanvasImage): (WebCore::KCanvasImage::~KCanvasImage):
- kcanvas/KCanvasMarker.cpp: Added. (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::~KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::setRef): (WebCore::KCanvasMarker::refX): (WebCore::KCanvasMarker::refY): (WebCore::KCanvasMarker::setAngle): (WebCore::KCanvasMarker::angle): (WebCore::KCanvasMarker::setAutoAngle): (WebCore::KCanvasMarker::setUseStrokeWidth): (WebCore::KCanvasMarker::useStrokeWidth): (WebCore::KCanvasMarker::draw): (WebCore::KCanvasMarker::externalRepresentation): (WebCore::getMarkerById):
- kcanvas/KCanvasMarker.h: Added. (WebCore::KCanvasMarker::isMarker):
- kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::~KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
- kcanvas/KCanvasMasker.h: Added. (WebCore::KCanvasMasker::isMasker): (WebCore::KCanvasMasker::mask):
- kcanvas/KCanvasResource.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasResource::KCanvasResource): (WebCore::KCanvasResource::~KCanvasResource): (WebCore::KCanvasResource::addClient): (WebCore::KCanvasResource::clients): (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
- kcanvas/KCanvasResource.h: (WebCore::): (WebCore::KCanvasResource::isPaintServer): (WebCore::KCanvasResource::isFilter): (WebCore::KCanvasResource::isClipper): (WebCore::KCanvasResource::isMarker): (WebCore::KCanvasResource::isMasker):
- kcanvas/KCanvasResourceListener.h: Added. (KCanvasResourceListener::KCanvasResourceListener): (KCanvasResourceListener::~KCanvasResourceListener):
- kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
- kcanvas/device/KRenderingDevice.h:
- kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
- kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
- kcanvas/device/KRenderingPaintServerGradient.h:
- kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
- kcanvas/device/KRenderingPaintServerPattern.h:
- kcanvas/device/KRenderingPaintServerSolid.h:
- kcanvas/device/qt/KCanvasClipperQt.cpp: (WebCore::KCanvasClipperQt::applyClip):
- kcanvas/device/qt/KCanvasClipperQt.h: (WebCore::KCanvasClipperQt::KCanvasClipperQt):
- kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
- kcanvas/device/qt/KRenderingDeviceQt.h:
- kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
- kcanvas/device/quartz/KCanvasItemQuartz.mm:
- kcanvas/device/quartz/KCanvasMaskerQuartz.h: (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
- kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::KCanvasMaskerQuartz::applyMask):
- kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz): (WebCore::KCanvasImageQuartz::KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::init): (WebCore::KCanvasImageQuartz::size):
- kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip): (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::cgLayer): (WebCore::KCanvasImageQuartz::setCGLayer):
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
- kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
- kcanvas/device/quartz/QuartzSupport.mm:
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
- ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
- ksvg2/svg/SVGClipPathElement.h:
- ksvg2/svg/SVGFEImageElement.cpp:
- ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
- ksvg2/svg/SVGFilterElement.h:
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
- ksvg2/svg/SVGGradientElement.h:
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGLinearGradientElement.h:
- ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
- ksvg2/svg/SVGMarkerElement.h:
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
- ksvg2/svg/SVGMaskElement.h:
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
- ksvg2/svg/SVGPatternElement.h:
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGRadialGradientElement.h:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
- platform/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
- platform/GraphicsContext.h: Added.
- platform/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
- platform/GraphicsTypes.h: Added. (WebCore::):
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsTypes.cpp:
- platform/graphics/GraphicsTypes.h:
- platform/qt/GraphicsContextQt.cpp:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
- 5:46 PM Changeset in webkit [17461] by
-
- 59 edits13 moves3 adds2 deletes in trunk/WebCore
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Better SVG integration in WebKit, Part I.
The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/KCanvasClipper.cpp: Removed.
- kcanvas/KCanvasClipper.h: Removed.
- kcanvas/KCanvasCreator.cpp: Removed.
- kcanvas/KCanvasCreator.h: Removed.
- kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
- kcanvas/KCanvasFilters.h:
- kcanvas/KCanvasImage.h: Removed.
- kcanvas/KCanvasMarker.cpp: Removed.
- kcanvas/KCanvasMarker.h: Removed.
- kcanvas/KCanvasMasker.cpp: Removed.
- kcanvas/KCanvasMasker.h: Removed.
- kcanvas/KCanvasResource.cpp: Removed.
- kcanvas/KCanvasResource.h: Removed.
- kcanvas/KCanvasResourceListener.h: Removed.
- kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
- kcanvas/device/KRenderingDevice.h:
- kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
- kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
- kcanvas/device/KRenderingPaintServerGradient.h:
- kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
- kcanvas/device/KRenderingPaintServerPattern.h:
- kcanvas/device/KRenderingPaintServerSolid.h:
- kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
- kcanvas/device/qt/KCanvasClipperQt.h: Removed.
- kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
- kcanvas/device/qt/KRenderingDeviceQt.h:
- kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
- kcanvas/device/qt/RenderPathQt.h: Removed.
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
- kcanvas/device/quartz/KCanvasItemQuartz.mm:
- kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
- kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
- kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
- kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
- kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
- kcanvas/device/quartz/QuartzSupport.mm:
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
- ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
- ksvg2/svg/SVGClipPathElement.h:
- ksvg2/svg/SVGFEImageElement.cpp:
- ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
- ksvg2/svg/SVGFilterElement.h:
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
- ksvg2/svg/SVGGradientElement.h:
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGLinearGradientElement.h:
- ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
- ksvg2/svg/SVGMarkerElement.h:
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
- ksvg2/svg/SVGMaskElement.h:
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
- ksvg2/svg/SVGPatternElement.h:
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGRadialGradientElement.h:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
- platform/GraphicsContext.cpp: Removed.
- platform/GraphicsContext.h: Removed.
- platform/GraphicsTypes.cpp: Removed.
- platform/GraphicsTypes.h: Removed.
- platform/graphics/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h: Added.
- platform/graphics/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
- platform/graphics/GraphicsTypes.h: Added. (WebCore::):
- platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
- platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
- platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
- platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
- platform/graphics/svg/SVGResourceImage.h: Added.
- platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
- platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
- platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
- platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
- platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
- platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
- platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
- platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
- platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
- platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
- platform/qt/GraphicsContextQt.cpp:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
- 5:44 PM Changeset in webkit [17460] by
-
- 2 edits in trunk/WebKitTools
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new platform/graphics include directory.
- DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
- 5:35 PM Changeset in webkit [17459] by
-
- 2 edits in trunk
Reviewed by Brady.
Make the universal build return non-zero when module make fails.
- Makefile:
- 5:33 PM Changeset in webkit [17458] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Stephanie.
Add a special case for the Internal makefiles, so it can find the OepnSource.
- Scripts/webkitdirs.pm:
- 5:25 PM Changeset in webkit [17457] by
-
- 10 edits in trunk
WebCore:
Reviewed by Geoff Garen.
Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.
- bridge/EditorClient.h: declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()
- bridge/mac/WebCoreFrameBridge.h: removed bridge equivalents
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): convert bridge-using code to editor()->client()-using code (WebCore::FrameMac::markMisspellingsInAdjacentWords): ditto (WebCore::FrameMac::markMisspellings): ditto (WebCore::FrameMac::respondToChangedSelection): ditto
- editing/Editor.h:
- editing/Editor.cpp: (WebCore::Editor::client): new method, returns EditorClient pointer. In an ideal world all the code that needed to access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor. But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
WebKit:
Reviewed by Geoff Garen.
Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.
- WebCoreSupport/WebEditorClient.h: declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::isContinuousSpellCheckingEnabled): implement by calling through to WebView (WebEditorClient::isGrammarCheckingEnabled): ditto (WebEditorClient::spellCheckerDocumentTag): ditto
- WebCoreSupport/WebFrameBridge.mm: removed bridge equivalents of these methods
- 5:21 PM Changeset in webkit [17456] by
-
- 2 edits in trunk/WebKit
Reviewed by Beth.
Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
but the debugger confirmed the cause).
- WebView/WebFrame.mm: (core): Added check for NULL bridge.
- 5:01 PM Changeset in webkit [17455] by
-
- 32 edits2 adds in trunk
WebCore:
Reviewed by Darin.
Removed a number of editing and selection methods from the bridge.
I moved cross-platform editing and selection code into Editor and
SelectionController, respecitvely.
I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
everything + the kitchen sink.
Specific comments below for interesting things.
- bindings/objc/DOMInternal.h: Moved exception handling helper methods into a new file so that WebKit can use them, too. Added a helper method for handling exceptions when selecting a Range.
- bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into WebKit, since they have to do with creating an NSAttributedString for API consumption, and not much to do with general Frame functionality.
- editing/Editor.h: Moved lastEditCommand tracking (at least the data, for now) into the Editor. Eventually, the Frame will not have to notify the Editor of what the lastEditCommand was, since the Editor will perform all EditCommands.
- editing/SelectionController.h: The code here is just stuff moved from the bridge.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions and return them. The bridge method to select a DOM range did this implicitly, since all ObjC DOM operations handle DOM exceptions by throwing them as ObjC exceptions.
- editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity. The two enumerations are numerically identical, but that's an implementation detail of TextAffinity that clients shouldn't be required to know about.
WebKit:
Reviewed by Darin.
Removed a number of editing and selection methods from the bridge.
I moved cross-platform editing and selection code into WebCore::Editor and
WebCore::SelectionController, respecitvely.
All of the seemingly new code here is just code grabbed from WebCore or
merged from WebCoreFrameBridge.
I changed one piece of internal API: we now pass around Ranges in places
where we used to pass around broken out components of Ranges.
I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
Since we now include WebCore headers that depend on these #defines, we need
to keep in sync with them, to avoid binary incompatibility.
- 4:56 PM Changeset in webkit [17454] by
-
- 2 edits in tags/WebCore-521.29.3/WebCore
Versioning
- 4:55 PM Changeset in webkit [17453] by
-
- 2 edits in tags/WebCore-521.29.3/WebCore
Merging fix.
- 4:55 PM Changeset in webkit [17452] by
-
- 2 edits in tags/WebCore-521.29.3/WebCore
Merging fix.
- 4:52 PM Changeset in webkit [17451] by
-
- 1 copy in tags/WebCore-521.29.3
new tag.
- 4:49 PM Changeset in webkit [17450] by
-
- 2 edits in trunk/WebCore
Rolling out the following change because this crash:
<rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
And this regression:
<rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
2006-09-06 David Harrison <harrison@apple.com>
Reviewed and tweaked by Tim H.
<rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.
- platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
- 4:48 PM Changeset in webkit [22445] by
-
- 5 edits in branches/WindowsMerge/WebKitWin
2006-10-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam, Ada.
Expose printing methods in IWebViewPrivate and removed LPARAM-based dispatching.
Call StretchDIBits instead of BitBlt.
Add a maximum DPI (currently set at 300) to speed up printing.
Add support needed for print preview.
- Interfaces/IWebViewPrivate.idl: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
- WebView.cpp: Added MAXIMUM_DPI setting to limit the size of print jobs for performance reasons (getPrintRects): Added. Factored out of print, added maximum DPI handling. (WebView::startPrintJob): Factored out of print (WebView::endPrintJob): Factored out of print (WebView::getPrintedPageCount): Factored out of print (WebView::printPage): Factored out of print. Replaced call to BitBlt with StretchDIBits (WebViewWndProc): Re-add support for printing a window (used by bug reporter code)
- WebView.h: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
- 3:25 PM Changeset in webkit [17449] by
-
- 2 edits in trunk/WebCore
Reviewed by harrison
<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
- editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Only create VisiblePositions when we're going to use them to create a range for an emitted character. We should further speed TextIterators up by avoiding creating VisiblePositions for TIs that are only used for the characters they emit (like the one that plainText uses).
- 2:41 PM Changeset in webkit [17448] by
-
- 46 edits in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
More rendering code cleaning
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::RenderApplet): (WebCore::RenderApplet::createWidgetIfNecessary):
- rendering/RenderApplet.h:
- rendering/RenderArena.cpp: (WebCore::): (WebCore::RenderArena::RenderArena): (WebCore::RenderArena::allocate): (WebCore::RenderArena::free):
- rendering/RenderArena.h:
- rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): (WebCore::RenderBR::baselinePosition): (WebCore::RenderBR::lineHeight): (WebCore::RenderBR::setStyle): (WebCore::RenderBR::caretMinOffset): (WebCore::RenderBR::positionForCoordinates): (WebCore::RenderBR::inlineBox):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::setHasMarkupTruncation): (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo): (WebCore::RenderBlock::BlockSelectionInfo::block): (WebCore::RenderBlock::BlockSelectionInfo::state): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::CompactInfo::clear):
- rendering/RenderButton.cpp: (WebCore::RenderButton::removeChild): (WebCore::RenderButton::paintObject):
- rendering/RenderButton.h: (WebCore::RenderButton::renderName): (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer):
- rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::calcMinMaxWidth):
- rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): (WebCore::toRoman): (WebCore::toHebrew): (WebCore::RenderCounter::calcMinMaxWidth):
- rendering/RenderCounter.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcMinMaxWidth):
- rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::renderName):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtPoint):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::renderName):
- rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::layout): (WebCore::RenderFormElement::textAlignment):
- rendering/RenderFormElement.h:
- rendering/RenderFrame.cpp:
- rendering/RenderFrame.h: (WebCore::RenderFrame::element):
- rendering/RenderFrameSet.cpp:
- rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::element):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): (WebCore::RenderHTMLCanvas::paint):
- rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::renderName):
- rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setStyle): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText):
- rendering/RenderImage.h: (WebCore::RenderImage::element):
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::~RenderInline): (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::paint): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::calcMinMaxWidth): (WebCore::RenderInline::requiresLayer): (WebCore::RenderInline::width): (WebCore::RenderInline::height): (WebCore::RenderInline::renderName): (WebCore::RenderInline::nodeAtPoint): (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderInline.h: (WebCore::RenderInline::layout):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::root): (WebCore::RenderLayer::setPos): (WebCore::RenderLayer::height): (WebCore::RenderLayer::relativePositionOffset):
- rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderLineEdit::selectionStart): (WebCore::RenderLineEdit::selectionEnd): (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange):
- rendering/RenderLineEdit.h:
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h: (WebCore::RenderListBox::renderName):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle): (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
- rendering/RenderListItem.h:
- rendering/RenderListMarker.cpp:
- rendering/RenderListMarker.h: (WebCore::RenderListMarker::renderName): (WebCore::RenderListMarker::isListMarker):
- 2:35 PM Changeset in webkit [17447] by
-
- 5 edits in trunk
Reviewed by Darin.
Change Makefiles to return non-zero when module make fails.
- Makefile:
WebKitTools:
Change Makefiles to return non-zero when module make fails.
Fix bug where if xcode options are not set, modules can build in the
wrong directory.
- Makefile:
- Scripts/webkitdirs.pm:
- 2:29 PM Changeset in webkit [22444] by
-
- 9 edits1 add in branches/WindowsMerge
WebCoreWin:
2006-10-30 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
If there's no plug-in for a given mime type, or if the plug-in fails
to initialize, draw the "missing plug-in" icon.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): If no plug-in can be found, create a null plugin view.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): If the plugin hasn't been started, paint the missing plugin image.
(WebCore::PluginViewWin::setNPWindowSize):
Return early if the plugin hasn't been started.
(WebCore::PluginViewWin::start):
Return if the plugin couldn't be created.
(WebCore::PluginViewWin::createNullPluginView):
New function which just creates a plugin view and doesn't try to start its plugin
(because there is none).
(WebCore::PluginViewWin::PluginViewWin):
New constructor for the null plugin view.
WebKitWin:
2006-10-30 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Add "null plugin" image resource.
- 2:25 PM Changeset in webkit [17446] by
-
- 1 edit in trunk/WebCore/editing/DeleteButtonController.cpp
Build fix.
- 2:19 PM Changeset in webkit [17445] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
<rdar://problem/4478625> Basic table editing and culling
Refined the criteria for deletable elements, rely on the renderer more.
Corrected the interface positioning for elements that have borders.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::DeleteButtonController::show):
- 1:34 PM Changeset in webkit [17444] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Adam.
- Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
- kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
- kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
- 12:48 PM Changeset in webkit [17443] by
-
- 2 edits in trunk/WebCore
- fix build
- loader/ResourceLoader.h: Added header guard.
- 12:08 PM Changeset in webkit [22443] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
- WebCore.vcproj/WebCore.vcproj: Added new source files from the loader directory.
- 12:05 PM Changeset in webkit [17442] by
-
- 15 edits in trunk/WebCore
Reviewed by Adam.
- fix FrameLoader files so they can be built on non-Mac platforms
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader. (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
- page/Page.h:
- page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong the other day.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Removed code to create the frame loader. (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
- loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC) around the PolicyCheck definition.
- loader/FormState.cpp: Changed import to include.
- loader/FrameLoader.cpp: Ditto.
- loader/MainResourceLoader.h: Ditto.
- loader/FrameLoaderTypes.h: Added a header guard.
- loader/NetscapePlugInStreamLoader.h: Changed import to include. Added #if PLATFORM(MAC) around Mac-specific details.
- loader/SubresourceLoader.h: Ditto.
- page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to m_loader from m_frameLoader.
- CMakeLists.txt: Updated.
- WebCoreSources.bkl: Updated.
- 11:53 AM Changeset in webkit [17441] by
-
- 2 edits in trunk/WebCore
2006-10-30 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Patch by Zack rusin to fix:
http://bugs.webkit.org/show_bug.cgi?id=11429
Fix startup crash.
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
- 11:38 AM Changeset in webkit [17440] by
-
- 4 edits in trunk/WebCore
2006-10-30 Zach Rusin <zack@kde.org>
Reviewed and landed by Anders.
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::receivedResponse):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault):
- platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): More build fixes.
2006-10-30 Simon Hausmann <hausmann@kde.org>
Reviewed and landed by Anders.
- fix Qt build
- platform/qt/FrameQtClient.cpp: ResourceLoaderClient -> ResourceHandleClient
- 11:32 AM Changeset in webkit [17439] by
-
- 2 edits in trunk/LayoutTests
Requested by Maciej.
- fast/dom/xmlhttprequest-get-expected.txt: Generated a new result. Maciej says that the new behavior of returning empty string instead of undefined is correct and matches Firefox, so the new result is better than the old.
- 9:20 AM Changeset in webkit [17438] by
-
- 25 edits3 adds in trunk
WebCore:
Reviewed by John Sullivan.
- work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
- moved bodyBackgroundColor function from Frame to WebFrame in WebKit
- page/PageState.h:
- page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
- bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a double for the date instead of an NSDate.
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and saveDocumentToPageCache methods.
- bridge/mac/WebCorePageState.h:
- bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into an Objective-C wrapper for PageState.
- loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of NSDate and WebCorePageState.
- loader/FrameLoaderClient.h: Changed NSDate to double.
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache here that used to be in invalidateCurrentItemPageCache on the WebKit side. (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date. (WebCore::FrameLoader::open): Moved one of the open functions that was part of commitProvisionalLoad inside the commitProvisionalLoad function, so that it can extract the parameters from the response. Changed the open function that takes a PageState to use the new C++ PageState. (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open function; tightened up logic, removing a few cases that could never happen, as well as the unused reload boolean.
- ForwardingHeaders/kjs/property_map.h: Added.
- WebCore.exp: Updated.
- WebCore.xcodeproj/project.pbxproj: Updated.
WebKit:
Reviewed by John Sullivan.
- work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
- moved bodyBackgroundColor function here from Frame
- History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]): Updated for change in WebCorePageState.
- WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
- WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was formerly in invalidatePageCache: on the bridge here. (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the NSDate here. (WebFrameLoaderClient::createPageCache): Restructured code to create the WebCorePageState object directly instead of calling saveDocumentToPageCache on the bridge.
- WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work directly with the DOM and renderers rather than using a function on Frame.
- 9:18 AM Changeset in webkit [17437] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John Sullivan.
- kjs/SavedBuiltins.h: Added needed include.
- wtf/OwnPtr.h: (WTF::OwnPtr::set): Fixed mistake in assertion.
- 8:27 AM Changeset in webkit [17436] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Tim H.
Fix for http://bugs.webkit.org/show_bug.cgi?id=10468
[Drosera] The Console toolbar button should bring the console window to the front.
The console now gets focus when its activated but already open. Command + L also
now activates/focuses the console.
- Drosera/English.lproj/MainMenu.nib/classes.nib:
- Drosera/English.lproj/MainMenu.nib/info.nib:
- Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
- Drosera/debugger.js:
- 3:12 AM Changeset in webkit [22442] by
-
- 8 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
- WebCore.vcproj/WebCore.vcproj: Added new files.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): Changed prototype to match new version.
WebKitWin:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
- WebFrame.cpp: (WebFrame::didReceiveResponse): Updated from receivedResponse.
- WebFrame.h:
- WebURLResponse.cpp: (WebURLResponse::WebURLResponse): Reimplemented to work in terms of WebCore::ResourceResponse (ditto for below). Uses BString to convert strings as needed. (WebURLResponse::~WebURLResponse): (WebURLResponse::createInstance): (WebURLResponse::expectedContentLength): (WebURLResponse::initWithURL): (WebURLResponse::MIMEType): (WebURLResponse::suggestedFilename): (WebURLResponse::textEncodingName): (WebURLResponse::URL): (WebURLResponse::suggestedFileExtension):
- WebURLResponse.h:
- 3:08 AM Changeset in webkit [17435] by
-
- 25 edits5 adds in trunk
WebCore:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bridge/mac/WebCoreFrameBridge.h: Removed no longer needed expiresTimeForResponse: method.
- dom/XMLTokenizer.cpp: (WebCore::openFunc): Updated to use ResourceResponse.
- loader/FrameLoader.h: Update loadResourceSynchronously to use ResourceResponse.
- loader/LoaderFunctions.h:
- loader/icon/IconLoader.cpp: (IconLoader::didReceiveResponse): Updated from receivedResponse and made cross-platform.
- loader/icon/IconLoader.h: updated for above change
- loader/loader.cpp: (WebCore::Loader::receivedResponse): reduced to just saving the PlatformResponse (ideally we'd phase out use of this). (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse logic.
- loader/loader.h:
- loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously): Return results as ResourceResponse.
- loader/mac/IconLoaderMac.mm: remove receivedResponse.
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): take ResourceResponse as argument.
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h: Remove calls for broken out response pieces.
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveResponse): New delegate method.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove storage of response bits, we're not gonna return them seprately any more.
- platform/network/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): Freshly implemented. Same for below. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::isMultipart): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Send didReceiveResponse client method.
- platform/network/cf/ResourceResponseCFNet.h: Added.
- platform/network/cf/ResourceResponseCFNet.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from CFURLResponseRef.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Don't bother cleaning up fields we no longer have. (WebCore::ResourceHandle::receivedResponse): Send didReceiveResponse client method.
- platform/network/mac/ResourceResponseMac.h: Added.
- platform/network/mac/ResourceResponseMac.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from an NSURLResponse*.
- rendering/HitTestResult.cpp:
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseText): Store http response info in the form of a ResourceResponse, change all methods to account for this. (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
- xml/xmlhttprequest.h:
WebKit:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
- WebCoreSupport/WebFrameBridge.mm: Removed no longer needed expiresTimeForResponse: method.
Oct 29, 2006:
- 5:31 PM Changeset in webkit [17434] by
-
- 4 edits in trunk/WebCore
- fix build
- loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
- loader/NetscapePlugInStreamLoader.h: Ditto.
- loader/ResourceLoader.h: Ditto.
- 5:16 PM Changeset in webkit [17433] by
-
- 8 edits1 move5 adds in trunk
WebCore:
- one last name change -- WebFormState.h to FormState.h
- added more empty placeholder platform-independent files for currently-Mac-specific loader classes
- loader/FormState.cpp: Updated include.
- loader/FrameLoader.cpp: Updated include.
- loader/mac/FrameLoaderMac.mm: Updated include.
- loader/WebFormState.h: Removed.
- loader/FormState.h: Added.
- loader/DocumentLoader.cpp: Added.
- loader/MainResourceLoader.cpp: Added.
- loader/NetscapePlugInStreamLoader.cpp: Added.
- loader/ResourceLoader.cpp: Added.
- loader/SubresourceLoader.cpp: Added.
- WebCore.xcodeproj/project.pbxproj: Updated for changes above.
WebKit:
- update for the WebCore rename
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
- 5:01 PM Changeset in webkit [17432] by
-
- 3 edits in trunk/WebKitTools
- Scripts/do-file-rename: Renames done, ready for the next round.
- Scripts/do-webcore-rename: Ditto.
- 5:00 PM Changeset in webkit [22441] by
-
- 4 edits in branches/WindowsMerge/WebCore
- update for the WebCore renames
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::bindingInstance):
- 4:57 PM Changeset in webkit [17431] by
-
- 71 edits15 moves in trunk
WebCore:
- did the do-webcore-rename renames, including a number of changes to the names of loader files (and WebResourceLoader -> ResourceLoader), jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(), and improvements to the names of decoder classes and their source files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
WebKit:
- update for the WebCore renames
- 4:43 PM Changeset in webkit [17430] by
-
- 2 edits6 moves in trunk/WebCore
Rubber stamped by Adam (kinda).
- add Mac suffixes and correct filenames inside loader/mac
- WebCore.xcodeproj/project.pbxproj: Updated for changes below.
- loader/mac/FrameLoader.mm: Removed.
- loader/mac/WebDocumentLoader.mm: Removed.
- loader/mac/WebLoader.mm: Removed.
- loader/mac/WebMainResourceLoader.mm: Removed.
- loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
- loader/mac/WebSubresourceLoader.mm: Removed.
- loader/mac/FrameLoaderMac.mm: Added.
- loader/mac/DocumentLoaderMac.mm: Added.
- loader/mac/ResourceLoaderMac.mm: Added.
- loader/mac/MainResourceLoaderMac.mm: Added.
- loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
- loader/mac/SubresourceLoaderMac.mm: Removed.
- 4:37 PM Changeset in webkit [17429] by
-
- 12 edits1 move1 add in trunk/WebCore
Reviewed by Adam.
- moving towards use of FrameLoader cross-platform; get FrameLoader.h and FrameLoader.cpp mostly ready
- WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and FormState.cpp. Removed WebFormState.mm.
- loader/FrameLoader.h: Put in lots of #if statements to see if we can get this header compiling on non-Mac.
- loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
- loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
- loader/FrameLoaderClient.h: Added some ifdefs.
- loader/WebDocumentLoader.h: Ditto.
- loader/WebLoader.h: Ditto.
- loader/WebMainResourceLoader.h: Ditto.
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense): Rewrote to work without bridge, partly to remove the need for ObjC bridge type in the header, and also because we're tearing down the bridge.
- loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): Removed unused m_contentLength and m_bytesReceived. (WebCore::MainResourceLoader::didReceiveResponse): Ditto. (WebCore::MainResourceLoader::didReceiveData): Ditto.
- bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
- bridge/mac/WebCoreFrameBridge.mm: Ditto.
- loader/mac/FormState.mm: Removed.
- loader/FormState.cpp: Added.
- 3:38 PM Changeset in webkit [17428] by
-
- 2 edits7 moves in trunk/WebCore
Rubber stamped by Adam.
- moving towards use of FrameLoader cross-platform; move the headers for the Mac loader from loader/mac into loader, in preparation for making them useful on non-Mac
- WebCore.xcodeproj/project.pbxproj:
- loader/mac/FrameLoader.h: Removed.
- loader/mac/WebDocumentLoader.h: Removed.
- loader/mac/WebFormState.h: Removed.
- loader/mac/WebLoader.h: Removed.
- loader/mac/WebMainResourceLoader.h: Removed.
- loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
- loader/mac/WebSubresourceLoader.h: Removed.
- loader/FrameLoader.h: Added.
- loader/WebDocumentLoader.h: Added.
- loader/WebFormState.h: Added.
- loader/WebLoader.h: Added.
- loader/WebMainResourceLoader.h: Added.
- loader/WebNetscapePlugInStreamLoader.h: Added.
- loader/WebSubresourceLoader.h: Added.
- 3:01 PM Changeset in webkit [17427] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Finish Darin's clean up of the use of APPLE in WebCore, begun in
r17405.
- platform/DeprecatedString.h:
- 2:07 PM Changeset in webkit [17426] by
-
- 35 edits in trunk/WebCore
Rubber stamped by Geoff.
This is a followup to my HitTestResult checkin. Most of the
HitTestResult local variables in the code were named i or info for
when the class was named NodeInfo. This patch renames all of these
local variables to result.
- 12:48 PM Changeset in webkit [17425] by
-
- 3 edits in trunk/WebCore
More semi-fixes.
- page/Page.cpp: Forgot to wrap the actual definition of setDefersLoading() in PLATFORM(MAC).
- platform/PlatformWheelEvent.h: Fix up preprocessor directives.
- 12:32 PM Changeset in webkit [17424] by
-
- 3 edits in trunk/WebCore
Build semi-fix.
Move all FrameLoader-related code in Page.{cpp,h} within #if
PLATFORM(MAC), since this class currently only exists on Mac.
- page/Page.cpp:
- page/Page.h:
- 11:15 AM Changeset in webkit [17423] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-file-rename: And again.
- 11:06 AM Changeset in webkit [17422] by
-
- 3 edits in trunk/WebCore
build fix.
- platform/PlatformString.h: (WebCore::String::operator NSString*):
- 11:03 AM Changeset in webkit [17421] by
-
- 2 edits in trunk/WebCore
Rolled out accidental commit.
- platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator NSString*):
- 10:58 AM Changeset in webkit [17420] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Geoff.
Test for http://bugs.webkit.org/show_bug.cgi?id=11444
REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]: attempt to insert nil value)
when submitting a form with an empty uninitialized field
- fast/forms/submit-nil-value-field-assert-expected.txt: Added.
- fast/forms/submit-nil-value-field-assert.html: Added.
- 10:54 AM Changeset in webkit [17419] by
-
- 4 edits in trunk/WebCore
RS by Darin.
Rolled out change to map NULL Strings to nil NSStrings because it caused
even more AppKit crashes. Maybe we should remove the NSString * operator
entirely, since its use is not straight-forward, and require callers to
specify explicitly whether they tolerate NULL.
- platform/AtomicString.h:
- platform/PlatformString.h: (WebCore::String::operator NSString*):
- platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
- 10:28 AM Changeset in webkit [17418] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Tweaked plans for renaming again.
- 10:03 AM Changeset in webkit [17417] by
-
- 1 edit in trunk/WebKit/ChangeLog
Added a bug number to change log.
- 9:44 AM Changeset in webkit [17416] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
- fixed storage leak showing up on the buildbot
- loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): Release the NSURLRequest after passing it to load. Also clean up logic a bit.
- 9:12 AM Changeset in webkit [17415] by
-
- 9 edits1 move in trunk
WebCore:
Rubber stamped by Adam Roben.
- renamed WebFrameLoaderClient to match the class name inside it
- loader/mac/WebFrameLoaderClient.h: Removed.
- loader/FrameLoaderClient.h: Moved it here.
- WebCore.xcodeproj/project.pbxproj: Updated project.
- bridge/mac/FrameMac.mm: Updated includes.
- bridge/mac/WebCoreFrameBridge.mm: Ditto.
- loader/mac/FrameLoader.mm: Ditto.
- loader/mac/WebLoader.h: Ditto.
WebKit:
Rubber stamped by Adam Roben.
- renamed WebCore's WebFrameLoaderClient to match the class name inside it
- WebCoreSupport/WebFrameBridge.mm: Update include.
- WebCoreSupport/WebFrameLoaderClient.h: Ditto.
- 8:50 AM Changeset in webkit [17414] by
-
- 3 edits in trunk/WebCore
Reviewed by Mitz.
- fix crash visible on buildbot and also when running the test anchor-image-scrolled-x-y.html under libgmalloc
- loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle now that the class is named ResourceHandle.
- loader/mac/WebSubresourceLoader.mm: Renaming, plus: (WebCore::SubresourceLoader::didFinishLoading): Get the handle into a local RefPtr before calling finishJobAndHandle, since we might get cancelled inside that function, so we should not rely on m_handle to keep the ResourceHandle alive. (WebCore::SubresourceLoader::didFail): Ditto. (WebCore::SubresourceLoader::didCancel): Ditto.
- 4:21 AM Changeset in webkit [17413] by
-
- 5 edits in trunk/LayoutTests
2006-10-30 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
Fix fast/block/basic/014.html to pass when Microsoft Office fonts are present.
- fast/block/basic/014-expected.checksum:
- fast/block/basic/014-expected.png:
- fast/block/basic/014-expected.txt:
- fast/block/basic/014.html: Always use default sans-serif font rather than preferring Microsoft Office fonts.
- 3:15 AM Changeset in webkit [17412] by
-
- 2 edits in trunk/LayoutTests
2006-10-29 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix failure in editing/inserting/insert-3851164-fix if Gill Sans font is present.
- editing/inserting/insert-3851164-fix.html: Specify sans-serif to match expected results generated without Gill Sans present.
- 2:00 AM Changeset in webkit [17411] by
-
- 2 edits in trunk/WebCore
Not reviewed.
- build fix
- platform/network/mac/ResourceHandleMac.mm:
- 1:50 AM Changeset in webkit [22440] by
-
- 12 edits2 deletes in branches/WindowsMerge
WebCoreWin:
Rubber stamped by Darin.
- renamed ResourceLoader to ResourceHandle (and same for related classes)
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/FrameWin.cpp:
- platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::startHTTPRequest): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
- platform/network/win/ResourceHandleWin.h: Added.
- platform/network/win/ResourceLoaderWin.cpp: Removed.
- platform/network/win/ResourceLoaderWin.h: Removed.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (IconLoader::receivedResponse):
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData):
- plugins/win/PluginStreamWin.h:
WebKitWin:
Rubber stamped by Darin.
- renamed ResourceLoader to ResourceHandle (and same for related classes)
- WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
- WebFrame.h:
- WebURLResponse.cpp: (WebURLResponse::createInstance):
- WebURLResponse.h:
- WebView.cpp:
- 1:44 AM Changeset in webkit [17410] by
-
- 31 edits14 moves in trunk/WebCore
Rubber stamped by Darin.
- renamed ResourceLoader to ResourceHandle (and same for related classes)
- CMakeLists.txt:
- Projects/gdk/webcore-gdk.bkl:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bridge/mac/FrameMac.mm:
- bridge/win/FrameWin.cpp:
- dom/XMLTokenizer.cpp:
- loader/Cache.cpp:
- loader/CachedResource.h:
- loader/LoaderFunctions.h:
- loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
- loader/icon/IconLoader.h:
- loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
- loader/loader.h:
- loader/mac/IconLoaderMac.mm: (IconLoader::receivedResponse):
- loader/mac/LoaderFunctionsMac.mm:
- loader/mac/WebLoader.h:
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData):
- platform/gdk/FrameGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveCharset):
- platform/network/ResourceHandle.cpp: Added. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::isErrorPage): (WebCore::ResourceHandle::error): (WebCore::ResourceHandle::setError): (WebCore::ResourceHandle::responseEncoding): (WebCore::ResourceHandle::responseHTTPHeadersAsString): (WebCore::ResourceHandle::kill): (WebCore::ResourceHandle::requestHeaders): (WebCore::ResourceHandle::url): (WebCore::ResourceHandle::postData): (WebCore::ResourceHandle::method): (WebCore::ResourceHandle::client):
- platform/network/ResourceHandle.h: Added. (WebCore::ResourceHandle::getInternal):
- platform/network/ResourceHandleClient.h: Added. (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFinishLoading): (WebCore::ResourceHandleClient::receivedRedirect): (WebCore::ResourceHandleClient::receivedResponse): (WebCore::ResourceHandleClient::receivedAllData):
- platform/network/ResourceHandleInternal.h: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/ResourceLoader.cpp: Removed.
- platform/network/ResourceLoader.h: Removed.
- platform/network/ResourceLoaderClient.h: Removed.
- platform/network/ResourceLoaderInternal.h: Removed.
- platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
- platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
- platform/network/gdk/ResourceHandleCurl.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
- platform/network/gdk/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::get): (WebCore::ResourceHandleManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
- platform/network/gdk/ResourceHandleManager.h: Added.
- platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
- platform/network/gdk/ResourceLoaderManager.cpp: Removed.
- platform/network/gdk/ResourceLoaderManager.h: Removed.
- platform/network/mac/ResourceHandleMac.mm: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::redirectedToURL): (WebCore::ResourceHandle::addData): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
- platform/network/mac/ResourceLoaderMac.mm: Removed.
- platform/network/qt/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
- platform/network/qt/ResourceHandleManager.h: Added.
- platform/network/qt/ResourceHandleQt.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::extractCharsetFromHeaders):
- platform/network/qt/ResourceLoaderManager.cpp: Removed.
- platform/network/qt/ResourceLoaderManager.h: Removed.
- platform/network/qt/ResourceLoaderQt.cpp: Removed.
- platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setHasReceivedResponse): (WebCore::ResourceHandle::hasReceivedResponse):
- platform/network/win/ResourceHandleWin.h: Added.
- platform/network/win/ResourceLoaderWin.cpp: Removed.
- platform/network/win/ResourceLoaderWin.h: Removed.
- platform/qt/FrameQt.cpp:
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
- platform/qt/FrameQtClient.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ServeSynchronousRequest):
- xml/XSLTProcessor.cpp:
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::didReceiveData):
- xml/xmlhttprequest.h:
- 1:36 AM Changeset in webkit [17409] by
-
- 5 edits in trunk
LayoutTests:
- fast/events/js-keyboard-event-creation-expected.txt: Update test that is affected in a minor way by the change to DumpRenderTree.
WebKitTools:
Reviewed by Mitz.
- DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreeWindow keyDown:]): Added. Does nothing, which prevents a beep.
- Scripts/do-webcore-rename: Tweaked plans for renaming a bit.
Oct 29, 2006:
- 1:47 AM Changeset in webkit [17408] by
-
- 21 edits2 deletes in trunk
WebCore:
Reviewed by Maciej.
- eliminate use of NSArray to carry form data around
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/FormDataMac.h: Removed.
- bridge/mac/FormDataMac.mm: Removed.
- bridge/mac/FrameMac.h:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm:
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- loader/FormData.h: (WebCore::FormData::isEmpty):
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- loader/mac/WebFormDataStream.h:
- loader/mac/WebFormDataStream.m: (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody):
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
- platform/network/mac/ResourceLoaderMac.mm:
WebKit:
Reviewed by Maciej.
- eliminate use of NSArray to carry form data around (the code in this framework was actually using the NSArray to hold a single
NSData anyway, so I just went back to an NSData for now)
- History/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): (-[WebHistoryItem formData]):
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm):
- WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]):
- 1:36 AM Changeset in webkit [17407] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
- create SubresourceLoader with a ResourceRequest, not broken out request bits
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
- platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
- 12:30 AM Changeset in webkit [17406] by
-
- 12 edits3 deletes in trunk/WebCore
Reviewed by Darin.
- removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreFrameBridge.h:
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm:
- loader/mac/LoaderFunctionsMac.mm:
- loader/mac/WebLoader.h:
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
- platform/network/ResourceLoader.h:
- platform/network/ResourceLoaderInternal.h:
- platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::redirectedToURL): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::finishJobAndHandle): (WebCore::ResourceLoader::reportError):
- platform/network/mac/WebCoreResourceLoader.h: Removed.
- platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
- platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
Oct 28, 2006:
- 11:48 PM Changeset in webkit [17405] by
-
- 75 edits4 deletes in trunk
Reviewed by Maciej.
- renamed PassRefPtr::release to releaseRef to make it clearer that it's the counterpart of adoptRef, and to make it harder to confuse it with the safer-to-use RefPtr::release
- kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::translate):
- kjs/ustring.cpp: (KJS::UString::Rep::create):
- wtf/PassRefPtr.h: (WTF::PassRefPtr::PassRefPtr): (WTF::PassRefPtr::~PassRefPtr): (WTF::PassRefPtr::get): (WTF::PassRefPtr::releaseRef): (WTF::PassRefPtr::operator->): (WTF::PassRefPtr::operator=): (WTF::adoptRef): (WTF::static_pointer_cast): (WTF::const_pointer_cast):
- wtf/RefPtr.h: (WTF::RefPtr::RefPtr): (WTF::RefPtr::operator=):
WebCore:
Reviewed by Maciej.
- eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDecider, WebCoreFrameLoaderAsDelegate, and WebCoreMainResourceLoaderAsPolicyDelegate
- grouped the state related to policy decisions into a PolicyCheck class to simplify the FrameLoader logic
- removed six methods from the bridge, reducing FrameLoader's use of the bridge to a single method
- changed form state to always use HashMap instead of NSDictionary
- moved the defersLoading flag from WebView to WebCore::Page and changed code to consistently call it defersLoading rather than defersCallbacks
- updated for rename of PassRefPtr::release to releaseRef
- replaced all uses of APPLE with appropriate PLATFORM defines
- cleaned up kjs_binding.h a bit
- cleaned up FrameMac.h a bit
- loader/mac/WebPolicyDecider.h: Removed.
- loader/mac/WebPolicyDecider.mm: Removed.
- WebCore.xcodeproj/project.pbxproj: Updated for removal.
- WebCore.exp:
- bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::wasRunByUserGesture):
- bindings/js/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::setInlineCode): (KJS::ScriptInterpreter::setProcessingTimerCallback): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
- bridge/AXObjectCache.h:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::handleMouseMoveEvent):
- bridge/mac/PageMac.mm: (WebCore::Page::Page):
- bridge/mac/WebCoreEditCommand.mm:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
- css/CSSValueList.cpp: (WebCore::CSSValueList::append):
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- css/cssparser.h:
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateSelection): (WebCore::Document::implicitClose): (WebCore::Document::setFocusNode):
- dom/Document.h:
- editing/ReplaceSelectionCommand.h:
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
- loader/mac/FrameLoader.h: (WebCore::PolicyCheck::request):
- loader/mac/FrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): (WebCore::FrameLoader::stopLoading): (WebCore::setAllDefersLoading): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::dropRequest): (WebCore::FrameLoaderClient::~FrameLoaderClient):
- loader/mac/WebFormState.h:
- loader/mac/WebFormState.mm:
- loader/mac/WebFrameLoaderClient.h:
- loader/mac/WebLoader.h: (WebCore::WebResourceLoader::defersLoading):
- loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::setDefersLoading):
- loader/mac/WebMainResourceLoader.h:
- loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
- page/Frame.cpp: (WebCore::Frame::paint):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- page/FrameView.h:
- page/Page.cpp: (WebCore::Page::setDefersLoading):
- page/Page.h: (WebCore::Page::defersLoading):
- platform/DeprecatedString.h:
- platform/DeprecatedStringList.h:
- platform/FontFallbackList.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::dragNSImage): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
- rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
WebKit:
Reviewed by Maciej.
- eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDeciderMac
- moved the defersLoading flag from WebView to WebCore::Page
- removed unused copies of four methods that in the frame bridge; the actually-used copies are in the page bridge
- updated for rename of PassRefPtr::release to releaseRef
- WebView/WebPolicyDeciderMac.h: Removed.
- WebView/WebPolicyDeciderMac.m: Removed.
- WebKit.xcodeproj/project.pbxproj: Updated for removal.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]):
- Plugins/WebNetscapePluginStream.mm:
- WebCoreSupport/WebFrameBridge.mm:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::setUpPolicyListener): (WebFrameLoaderClient::receivedPolicyDecison): (WebFrameLoaderClient::userAgent): (-[WebFramePolicyListener initWithWebCoreFrame:]): (-[WebFramePolicyListener invalidate]): (-[WebFramePolicyListener dealloc]): (-[WebFramePolicyListener finalize]): (-[WebFramePolicyListener receivedPolicyDecision:]): (-[WebFramePolicyListener ignore]): (-[WebFramePolicyListener download]): (-[WebFramePolicyListener use]): (-[WebFramePolicyListener continue]):
- WebCoreSupport/WebPageBridge.mm: (-[WebPageBridge runModal]):
- WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
- WebView/WebFormDelegate.h:
- WebView/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]): (-[WebFormDelegate textFieldDidEndEditing:inFrame:]): (-[WebFormDelegate textDidChangeInTextField:inFrame:]): (-[WebFormDelegate textDidChangeInTextArea:inFrame:]): (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
- WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _isFrameSet]):
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm: (-[WebFrameView _shouldDrawBorder]):
- WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]):
- WebView/WebView.mm: (-[WebView _formDelegate]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 4:44 PM Changeset in webkit [17404] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding forgotten Bugzilla reference.
- 4:41 PM Changeset in webkit [17403] by
-
- 2 edits in trunk
- 4:39 PM Changeset in webkit [17402] by
-
- 13 edits in trunk
WebCore:
Reviewed by Maciej.
Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
point instead of being passed one explicitly.
- WebCore.exp: Change constructor symbol.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and hitTest(). (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
- dom/Document.cpp: (WebCore::Document::elementFromPoint): Ditto. (WebCore::Document::prepareMouseEvent): Ditto.
- page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Ditto. (WebCore::Frame::hitTestResultAtPoint): Ditto.
- page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Initalize m_point with the passed point.
- rendering/HitTestResult.h: Update constructor declaration.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Update to new constructor and hitTest(). (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the HitTestResult instead of being passed one. (WebCore::RenderLayer::hitTestLayer): Ditto.
- rendering/RenderLayer.h: Update declarations.
WebKit:
Reviewed by Maciej.
Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point.
- WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to HitTestResult constructor.
- 2:43 PM Changeset in webkit [22439] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj: Adding new HitTestResult.{cpp,h} files.
- 2:33 PM Changeset in webkit [17401] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders.
Fix Qt/Linux build.
- CMakeLists.txt:
- platform/qt/FrameQtClient.cpp: (WebCore::numRequests): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::updateFromElement):
- 11:56 AM Changeset in webkit [17400] by
-
- 2 edits in trunk/WebCore
Tweaked by Sam. Reviewed by Brady.
Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
Initialize m_modifyBiasSet to false, as it sometimes gets
used before it has been initalized.
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
- 11:28 AM Changeset in webkit [17399] by
-
- 75 edits3 adds in trunk
WebCore:
Reviewed by Darin.
This is the WebCore half of pushing elementAtPoint and the backend
of WebElementDictionary into WebCore. Most of the changes below are
to accommodate one of the following:
-NodeInfo is now a stand-alone class called HitTestResult.
Previously it was defined in RenderObject.h, but not for
any particular reason. The WebElementDictionary
functionality that was pushed into WebCore has been pushed
specifically into the this class. In fact,
WebElementDictionary now keeps a HitTestResult as a member
varibale.
-The enumeration AccessPolicy is now called
ClipboardAccessPolicy and is defined in its own header. It
was previously defined in ClipboardMac.h, but is now
defined independently to avoid including ClipboardMac.h
from within FrameMac.h since FrameMac.h is now included in
WebElementDictionary.m in WebKit.
-Element now has a virtual target() for the sake of
NodeInfo::targetFrame()
- WebCore.exp: Several WebCore functions are newly called from WebKit, so they have been added here.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: Must include Image.h because of adjustments to ClipboardMac.
- bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy and HitTestResult changes. (WebCore::FrameMac::eventMayStartDrag): Same. (WebCore::FrameMac::handleMouseMoveEvent): Same. (WebCore::FrameMac::dispatchCPPEvent): Same. (WebCore::FrameMac::mayDHTMLCut): Same. (WebCore::FrameMac::mayDHTMLCopy): Same. (WebCore::FrameMac::mayDHTMLPaste): Same. (WebCore::FrameMac::tryDHTMLCut): Same (WebCore::FrameMac::tryDHTMLCopy): Same. (WebCore::FrameMac::tryDHTMLPaste): Same.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to HitTestResult changes. (-[WebCoreAXObject accessibilityHitTest:]): Same.
- bridge/mac/WebCoreFrameBridge.h: Same.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for ClipboardAccessPolicy changes. (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same. (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
- dom/Document.cpp: (WebCore::Document::elementFromPoint): Adjust for HitTestResult changes. (WebCore::Document::prepareMouseEvent): Same.
- dom/Element.h: (WebCore::Element::target): Now has a virtual target()
- html/HTMLAnchorElement.h: Same.
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult changes.
- html/HTMLAreaElement.h: Virtual target()
- html/HTMLBaseElement.h: (WebCore::HTMLBaseElement::target): Same.
- html/HTMLFormElement.h: Same.
- html/HTMLLinkElement.h: Same.
- html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult changes.
- html/HTMLMapElement.h: Same.
- page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Same. (WebCore::Frame::hitTestResultAtPoint): Same.
- page/Frame.h: Same.
- page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Same.
- platform/mac/ClipboardAccessPolicy.h: Added. (WebCore::):
- platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, include ClipboardAccessPolicy.h, and rename AccessPolicy to ClipboardAccessPolicy.
- platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy. (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::setAccessPolicy): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::setDropEffect): (WebCore::ClipboardMac::setEffectAllowed):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult changes.
- rendering/EllipsisBox.h:
- rendering/HitTestResult.cpp: Added. (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::~HitTestResult): (WebCore::HitTestResult::operator=): (WebCore::HitTestResult::setInnerNode): (WebCore::HitTestResult::setInnerNonSharedNode): (WebCore::HitTestResult::setURLElement): (WebCore::HitTestResult::setScrollbar): (WebCore::HitTestResult::targetFrame): (WebCore::HitTestResult::boundingBox): (WebCore::HitTestResult::isSelected): (WebCore::HitTestResult::title):
- rendering/HitTestResult.h: Added. (WebCore::HitTestResult::readonly): (WebCore::HitTestResult::active): (WebCore::HitTestResult::mouseMove): (WebCore::HitTestResult::innerNode): (WebCore::HitTestResult::innerNonSharedNode): (WebCore::HitTestResult::point): (WebCore::HitTestResult::URLElement): (WebCore::HitTestResult::scrollbar): (WebCore::HitTestResult::setPoint): (WebCore::HitTestResult::setReadonly): (WebCore::HitTestResult::setActive): (WebCore::HitTestResult::setMouseMove):
- rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
- rendering/InlineBox.h: Same.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): Same.
- rendering/InlineFlowBox.h: Same.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): Same.
- rendering/InlineTextBox.h: Same.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Same. (WebCore::RenderBlock::nodeAtPoint): Same.
- rendering/RenderBlock.h: Same.
- rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Same.
- rendering/RenderBox.h: Same.
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): Same.
- rendering/RenderFlow.h: Same.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): Same.
- rendering/RenderForeignObject.h: Same.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): Same.
- rendering/RenderFrameSet.h: Same.
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Same.
- rendering/RenderImage.h: Same.
- rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): Same.
- rendering/RenderInline.h: Same.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Same. (WebCore::RenderLayer::hitTest): Same. (WebCore::RenderLayer::hitTestLayer): Same. (WebCore::RenderLayer::updateHoverActiveState): Same.
- rendering/RenderLayer.h: Same.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): Same.
- rendering/RenderListBox.h: Same.
- rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): Same. (WebCore::RenderObject::setInnerNode): Same. (WebCore::RenderObject::nodeAtPoint): Same.
- rendering/RenderObject.h: Remove NodeInfo class and forward declare HitTestResult.
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult changes.
- rendering/RenderPath.h: Same.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Same.
- rendering/RenderSVGImage.h: Same
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): Same.
- rendering/RenderSVGText.h: Same.
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): Same.
- rendering/RenderTableRow.h: Same.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): Same.
- rendering/RenderTableSection.h: Same.
- rendering/RenderText.h: Same. (WebCore::RenderText::nodeAtPoint): Same.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): Same.
- rendering/RenderTextControl.h: Same.
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): Same.
- rendering/RootInlineBox.h: Same.
WebKit:
Reviewed by Darin.
This is the WebKit half of pushing the guts of elementAtPoint and
WebElementDictionary into WebCore. Among other things, this patch
makes WebElementDictionary.m and WebHTMLView.m Objective-C++
- MigrateHeaders.make: Add DOMElementInternal.h to the list of headers to migrate.
- Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and NSPoint member variables with a HitTestResult member variable.
- Misc/WebElementDictionary.m: (addLookupKey): Formatting. (-[WebElementDictionary initWithHitTestResult:]): Constructor just takes a HitTestResult now and sets the member variable. (-[WebElementDictionary dealloc]): delete HitTestResult. (-[WebElementDictionary finalize]): Address HitTestResult. (-[WebElementDictionary _domNode]): Use HitTestResult and call into WebCore. (-[WebElementDictionary objectForKey:]): Same. (-[WebElementDictionary _webFrame]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _imageRect]): Same. (-[WebElementDictionary _isSelected]): Same.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.mm: (core): Convert from DOMNode* to Node* (kit): Convert from Node* to DOMNode*
- WebView/WebFrameInternal.h: Support for the above.
- WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly into Frame.cpp to get HitTestResult.
- 1:19 AM Changeset in webkit [17398] by
-
- 2 edits in trunk
WebCore:
Removed accidentally committed duplicate ChangeLog entries.
WebKit:
Removed accidentally committed duplicate ChangeLog entries.
Oct 27, 2006:
- 11:18 PM Changeset in webkit [17397] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance impact of fixing it again.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear):
- 10:08 PM Changeset in webkit [17396] by
-
- 21 edits2 adds in trunk
WebCore:
Reviewed by John & Adam.
- assorted speedups to fix perf regression from fixing correctness regression
- WebCore.exp: exported new methods.
- WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm:
- loader/CachedResource.cpp: Removed now obsolete getCFURL.
- loader/CachedResource.h:
- loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject.
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate.
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache.
- loader/mac/WebFrameLoaderClient.h:
WebKit:
Reviewed by John & Adam.
- various performance improvements for resource delegate dispatch.
- avoid any ObjC messaging when fetching the WebView
- avoid ObjC calls to WebView to get resource load delegate and impl cache
- cache actual method pointers, not just the fact that the method is present
- added a new SPI resource load delegate method which allows clients to get just one message in case of synchronously loading from memory cache; if this is implemented you don't get the normal delegate calls in that case.
- various other minor tweaks
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::frameLoadCompleted):
- WebCoreSupport/WebPageBridge.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.mm: (frame): (core): (kit): (getWebView): (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _updateBackground]): (-[WebFrame _clearSelectionInOtherFrames]): (-[WebFrame _isMainFrame]): (-[WebFrame webView]):
- WebView/WebResourceLoadDelegatePrivate.h: Added.
- WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): (WebViewGetResourceLoadDelegate): (WebViewGetResourceLoadDelegateImplementations):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 9:14 PM Changeset in webkit [17395] by
-
- 2 edits in trunk/WebCore
2006-10-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
build fix
- dom/Document.cpp: (WebCore::Document::referrer):
- 7:08 PM Changeset in webkit [17394] by
-
- 6 edits in trunk
top level:
Rubber stamped by Tim Hatcher
Added "make universal" to build universal binaries
- Makefile:
- Makefile.shared:
WebKitTools:
Rubber stamped by Tim Hatcher
Added "make universal" to build universal binaries
- Makefile:
- Makefile.shared:
- 6:22 PM Changeset in webkit [17393] by
-
- 17 edits in trunk
WebCore:
Reviewed by Maciej.
Moved some WebCoreFrameBridge functions into FrameLoader.
I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and OBJC #ifdefs.
- WebCore.exp:
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm:
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer):
- loader/LoaderFunctions.h:
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading):
- page/Frame.h:
- page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext):
- page/FrameTree.h:
- platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
WebKit:
Reviewed by Maciej.
Moved some WebCoreFrameBridge functions into FrameLoader.
- WebView/WebFrame.mm: (-[WebFrame _numPendingOrLoadingRequests:]):
- 5:41 PM Changeset in webkit [17392] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4478625> HTML Editing: Basic table editing and culling
Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection):
- 4:43 PM Changeset in webkit [17391] by
-
- 3 edits in trunk/WebCore
Reviewed by Kevin Decker
Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.
- rendering/InlineTextBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers.
- 4:37 PM Changeset in webkit [22438] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
2006-10-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
Tighten up warning levels by removing #pragma warning(push, 0), pop
- WebBackForwardList.h:
- WebFrame.h:
- WebIconDatabase.h:
- 3:31 PM Changeset in webkit [17390] by
-
- 7 edits in trunk
WebCore:
Reviewed by Beth.
Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorObjC.pm:
WebKit:
Reviewed by Beth.
Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.
- MigrateHeaders.make:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
- 3:07 PM Changeset in webkit [17389] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed the revision number in my ChangeLog entry.
- 2:28 PM Changeset in webkit [17388] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders
- fixed http://bugs.webkit.org/show_bug.cgi?id=11439 REGRESSION: Another page loading crash
- WebView/WebFrame.mm: (-[WebFrame _createItem:]): Handle nil documentLoader the way we did before ObjC->C++ changes
- 2:22 PM Changeset in webkit [22437] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-27 Anders Carlsson <acarlsson@apple.com>
Reviewed by Oliver.
<rdar://problem/4730678> Plug-ins should be able to open URLs
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 1:50 PM Changeset in webkit [17387] by
-
- 6 edits in trunk
WebCore:
Reviewed by Anders
- WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling()
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
WebKit:
Reviewed by Anders
- WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): call advanceToNextMisspelling directly on FrameMac, bypassing bridge (-[NSArray showGuessPanel:]): ditto
- 1:42 PM Changeset in webkit [17386] by
-
- 14 edits2 adds in trunk
LayoutTests:
Reviewed by harrison
<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value
Changes reflect the removal of more brs that were about
to collapse:
- editing/deleting/delete-4038408-fix-expected.txt:
- editing/inserting/insert-3654864-fix-expected.txt:
- editing/inserting/insert-3659587-fix-expected.txt:
- editing/inserting/insert-3775316-fix-expected.txt:
- editing/inserting/insert-at-end-01-expected.txt:
- editing/inserting/insert-at-end-02-expected.txt:
- editing/inserting/insert-br-001-expected.txt:
- editing/inserting/insert-br-005-expected.txt:
Added to demonstrate fix:
- fast/forms/11423-expected.txt: Added.
- fast/forms/11423.html: Added.
WebCore:
Reviewed by harrison
<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value
The regression is that foo, return, bar in a textarea serializes as 'foobar'.
Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.
We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse.
- editing/CompositeEditCommand.h:
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments.
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function.
- 12:50 PM Changeset in webkit [17385] by
-
- 2 edits in S60/trunk/WebKit
2006-10-27 sareen <shyam.sareen@nokia.com>
Reviewed by sachin.padma@nokia.com.
DESC: Change the cenrep value in the HTTPLoaderAcceptHeader.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11434
- ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
- 11:54 AM Changeset in webkit [17384] by
-
- 1 edit in tags/WebKit-521.29.1/WebKit/Info.plist
Versioning
- 11:54 AM Changeset in webkit [17383] by
-
- 1 edit in tags/WebKit-521.29.1/WebKit/WebView/WebDynamicScrollBarsView.h
Build fix.
- 11:53 AM Changeset in webkit [17382] by
-
- 1 copy in tags/WebKit-521.29.1/WebKit
New tag (part 2).
- 11:52 AM Changeset in webkit [17381] by
-
- 1 add in tags/WebKit-521.29.1
New tag.
- 11:51 AM Changeset in webkit [17380] by
-
- 2 edits2 deletes in S60/trunk/WebKit
2006-10-16 brmorris <thisisbradley@gmail.com>
Reviewed by Sachin.
DESC: Update svg icons in CannedImages.cpp
http://bugs.webkit.org/show_bug.cgi?id=9435
- BrowserCore/Misc/src/CannedImages.cpp: Update mbg includes (CCannedImages::GetImage): Update BROWSERSDK bitmap IDs (CCannedImages::LoadSvg): Update BROWSERSDK bitmap IDs
- data/Webkit_gcce.loc: Removed.
- data/Webkit_gcce.rss: Removed.
- 11:47 AM Changeset in webkit [17379] by
-
- 1 edit in trunk/WebKit/WebView/WebDynamicScrollBarsView.h
Build fix.
- 11:29 AM Changeset in webkit [17378] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady.
Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.
Added work-around for AppKit crash that semantic accuracy revealed.
No testcase because I don't think there's a way to reflect this change
in a webpage yet.
- platform/PlatformString.h: (WebCore::String::operator NSString*):
- platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
- 10:50 AM Changeset in webkit [17377] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Steve.
- kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix a warning some people see (not sure why others don't see it).
- JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch this file to force it to re-build grammar.cpp.
- 10:19 AM Changeset in webkit [17376] by
-
- 4 edits in tags/WebCore-521.29.2/WebCore
Reviewed by Brady
- fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
- 10:15 AM Changeset in webkit [17375] by
-
- 1 copy in tags/WebCore-521.29.2
New tag.
- 9:49 AM Changeset in webkit [17374] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/testkjs/testkjs.vcproj
Oops, forgot to save one file.
- 9:49 AM Changeset in webkit [17373] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej,
<rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
- bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element.
(AXAttributeStringSetBlockquoteLevel):
Add, if non-zero, or clear the block quote level attribute.
(AXAttributedStringAppendText):
Send AXAttributeStringSetBlockquoteLevel.
- 9:48 AM Changeset in webkit [17372] by
-
- 49 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)
- API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
- API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
- API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
- API/JSStringRef.cpp: (JSStringCreateWithCharacters):
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
- kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
- kjs/ExecState.h: (KJS::ExecState::hadException):
- kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
- kjs/Parser.h:
- kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
- kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
- kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
- kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
- kjs/completion.h: (KJS::Completion::isValueCompletion):
- kjs/date_object.cpp: (KJS::findMonth):
- kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
- kjs/dtoa.cpp:
- kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
- kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
- kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
- kjs/grammar.y:
- kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
- kjs/internal.h:
- kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
- kjs/lexer.h:
- kjs/math_object.cpp: (MathFuncImp::callAsFunction):
- kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
- kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
- kjs/object.h: (KJS::JSObject::getPropertySlot):
- kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
- kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
- kjs/property_slot.h:
- kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
- kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
- kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
- kjs/value.cpp: (KJS::JSValue::toUInt16):
- kjs/value.h:
- pcre/pcre_compile.c: (get_othercase_range):
- pcre/pcre_exec.c: (match):
- pcre/pcre_internal.h:
- wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
- wtf/MathExtras.h: (isnan): (lround): (lroundf):
- wtf/StringExtras.h: (strncasecmp):
- wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):
- 7:41 AM Changeset in webkit [17371] by
-
- 2 edits in trunk/WebCore
- fix one error in the Qt build
- platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated.
- 7:39 AM Changeset in webkit [17370] by
-
- 4 edits in S60/branches/3.1m/WebKit
2006-10-27 yongjzha yongjun.zhang@nokia.com
Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.
- BrowserCore/Renderers/inc/StaticImageDecoder.h:
- BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
- BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):
Merge from r17367 from main branch
- 7:33 AM Changeset in webkit [17369] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Moved the layout test part of the change log to the layout tests directory.
- 7:31 AM Changeset in webkit [17368] by
-
- 3 edits in trunk/LayoutTests
- new test results for a couple of tests
- fast/js/kde/RegExp-expected.txt: Affected by the change to decode \u sequences in JavaScript regular expression at the lexer level.
- http/tests/navigation/success200-reload-expected.txt: For some reason, this is consistently not dumping the "scrolled" line any more -- since the purpose of the test has nothing to do with that, landing new results.
- 7:28 AM Changeset in webkit [17367] by
-
- 4 edits in S60/trunk/WebKit
2006-10-27 yongjzha yongjun.zhang@nokia.com
Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.
- BrowserCore/Renderers/inc/StaticImageDecoder.h:
- BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
- BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):
- 1:08 AM Changeset in webkit [17366] by
-
- 2 edits in trunk/WebKit
- build fix
- WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
- 12:09 AM Changeset in webkit [17365] by
-
- 8 edits in trunk/WebKit
Reviewed by Maciej.
- moved methods that are there just to be called by the frame loader client into the client in an attempt to get back some of the speed we lost yesterday
- DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (dataSource): (decisionListener): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::canUseArchivedResource): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::createPageCache):
- WebView/WebFrame.mm: (-[NSView setWebFrame:]): (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _saveScrollPositionAndViewStateToItem:]): (-[WebFrame _hasSelection]): (-[WebFrame _clearSelection]): (-[WebFrame _setProvisionalItem:]): (-[WebFrame _setPreviousItem:]): (-[WebFrame _setCurrentItem:]): (-[WebFrame loadArchive:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]):
- WebView/WebHTMLViewPrivate.h:
- 12:08 AM Changeset in webkit [17364] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- WebCore.exp: Export more symbols needed by WebKit.
Oct 26, 2006:
- 11:29 PM Changeset in webkit [17363] by
-
- 2 edits in trunk/WebCore
Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
Fixed layout test crash. Oops.
- loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle):
- 11:08 PM Changeset in webkit [17362] by
-
- 1 edit in tags/WebCore-521.29.1/WebCore/Info.plist
Versioning
- 11:06 PM Changeset in webkit [17361] by
-
- 1 edit in tags/WebCore-521.29.1/WebCore/WebCore.exp
Build fix for 64-bit.
- 11:04 PM Changeset in webkit [17360] by
-
- 1 copy in tags/WebCore-521.29.1/WebCore
new tag (part 2).
- 11:01 PM Changeset in webkit [17359] by
-
- 1 add in tags/WebCore-521.29.1
new tag.
- 11:01 PM Changeset in webkit [17358] by
-
- 1 delete in tags/WebKit-521.29.1
Bad tag.
- 10:59 PM Changeset in webkit [17357] by
-
- 1 copy in tags/WebKit-521.29.1/WebKit
new tag (part 2).
- 10:58 PM Changeset in webkit [17356] by
-
- 1 add in tags/WebKit-521.29.1
new tag.
- 10:54 PM Changeset in webkit [17355] by
-
- 1 edit in trunk/WebCore/WebCore.exp
Build fix for 64-bit.
- 10:30 PM Changeset in webkit [17354] by
-
- 4 edits in trunk/JavaScriptCore
2006-10-26 W. Andy Carrel <wac@google.com>
Reviewed by Maciej.
- Fix http://bugs.webkit.org/show_bug.cgi?id=7445 / <rdar://problem/4614195> (and 7253 / <rdar://4694011>) by changing inline regexps so that they can have \u escaped Unicode sequences and still work properly.
- kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): Looking ahead one additional character for the benefit of scanRegExp (Lexer::scanRegExp): Change code to support unicode escapes in inline regexps.
- kjs/lexer.h: Extra lookahead added.
- tests/mozilla/ecma_2/RegExp/properties-001.js: Changed test to look for Unicode character rather than the '\u' escaped equivalent for .source and .toString().
- 8:46 PM Changeset in webkit [17353] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady
- fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
- 7:55 PM Changeset in webkit [17352] by
-
- 26 edits in trunk
WebCore:
Reviewed by Darin, Maciej.
Removed many uses of NSString *.
Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
stringByCollapsingNonPrintingCharacters with a c++ equivalent.
PLT says no performance regression.
- WebCore.exp:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]):
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post):
- loader/mac/WebDocumentLoader.h:
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle):
- loader/mac/WebFrameLoaderClient.h:
- loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy):
WebKit:
Reviewed by Darin, Maciej.
Removed many uses of NSString * from WebCore.
Changed a few files to ObjC++ for compatiblity with new WebCore methods
taking WebCore::Strings as arguments.
Added a static_cast to make the c++ compiler happy.
- 7:55 PM Changeset in webkit [22436] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/4764502> PluginStreams should cancel their loader jobs on error
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData): Modify assertions. None of the above functions should be run after aborting the load.
- 6:00 PM Changeset in webkit [22435] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths): Look for plugins in a plugins directory which is relative to the executable directory.
(WebCore::PluginDatabaseWin::createPluginView):
Use reverseFind instead of findRev here.
- 5:25 PM Changeset in webkit [17351] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
<rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
The main table at nytimes.com has a fixed width of 874px, but the table ends
up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
this. The other bug was a missing top and left of 0px on the container element,
causing the deletion UI to sometimes be offset below the table.
Now check for the element's renderer at the beginning of show() and
return early if it is null.
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show):
- 5:20 PM Changeset in webkit [22434] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Beth.
Fix: <rdar://problem/4799084> Text and dropdown button too close
together in <select>s
Fix: <rdar://problem/4800493> Popup menus should be positioned so that
their text is horizontally aligned with the <select> control's text
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR vs. RTL popups, and add padding to align the text. (WebCore::PopupMenu::paint): Add padding from the <select> control to align the text with the <select> control's text.
- rendering/RenderThemeWin.cpp: Set svn:eol-style native. (WebCore::RenderThemeWin::systemFont): Clean up line endings. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra padding between the dropdown button and text. (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
- 4:34 PM Changeset in webkit [22433] by
-
- 2 edits in branches/WindowsMerge/WebCore
Forgot to make the change to Release as well in my last checkin.
- WebCore.vcproj/WebCore.vcproj:
- 4:25 PM Changeset in webkit [22432] by
-
- 2 edits in branches/WindowsMerge/WebCore
Rubberstamped by Steve.
Add some missing '/d' flags to xcopy calls to only copy headers if
they've been modified.
- WebCore.vcproj/WebCore.vcproj:
- 4:12 PM Changeset in webkit [17350] by
-
- 2 edits in trunk/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
Build fix.
- html/CanvasRenderingContext2D.cpp: Include MathExtras.h
- 4:02 PM Changeset in webkit [22431] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
- platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspellingOrBadGrammar): Build fix from Oliver.
- 3:57 PM Changeset in webkit [17349] by
-
- 7 edits in trunk
WebCore:
Reviewed by Anders.
Some changes to support new grammar checking code in WebKit.
- WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit
- WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it.
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
WebKit:
Reviewed by Anders
- WebView/WebFrame.mm: now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h> (-[WebFrame _unmarkAllBadGrammar]): filled in guts (-[WebFrame _unmarkAllMisspellings]): rewrote to call Document directly, bypassing bridge
- 3:30 PM Changeset in webkit [17348] by
-
- 3 edits in trunk/WebKit
- English.lproj/WebViewEditingContextMenu.nib/info.nib:
- English.lproj/WebViewEditingContextMenu.nib/objects.nib:
Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
- 3:27 PM Changeset in webkit [17347] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Geoff.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11419
REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
([view isKindOfClass:[WebHTMLView class]]) when running the layout tests
- DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseMoveToX:Y:]):
- 3:22 PM Changeset in webkit [17346] by
-
- 7 edits in trunk/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
Reviewed by Brady.
Add reverseFind to String and use it instead of findRev.
Use CString instead of DeprecatedCString in one place.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
- ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
- loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset):
- platform/PlatformString.h: (WebCore::String::reverseFind):
- platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind):
- platform/StringImpl.h:
- 2:27 PM Changeset in webkit [17345] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin
More plumbing for grammar checking. Still no grammars is checked.
- dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
- platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling
- platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT".
- rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar
- 2:19 PM Changeset in webkit [17344] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added bug number to change log entry.
- 2:17 PM Changeset in webkit [17343] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam.
- editing/execCommand/remove-formatting-expected.txt: Roll back results. The ones just checked in showed the same kind of intermittent failure that copy-paste-bidi.html used to show -- now we consistently get these results.
- 1:52 PM Changeset in webkit [17342] by
-
- 1 edit8 copies in tags/Safari-521.29
New tag.
- 1:42 PM Changeset in webkit [17341] by
-
- 6 edits in /
Re-versioning
- 1:32 PM Changeset in webkit [17340] by
-
- 6 edits in /
Versioning
- 1:29 PM Changeset in webkit [17339] by
-
- 3 edits in S60/branches/3.1m/WebKit
2006-10-25 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly. Merge from CCB
http://bugs.webkit.org/show_bug.cgi?id=
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
- ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
- 1:23 PM Changeset in webkit [17338] by
-
- 37 edits in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
Cleanup rendering code
- Assorted code cleanup.
- rendering/AutoTableLayout.cpp:
- rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent):
- rendering/CounterListItem.h:
- rendering/CounterNode.cpp:
- rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset):
- rendering/CounterResetNode.cpp:
- rendering/CounterResetNode.h:
- rendering/DataRef.h: (WebCore::DataRef::DataRef):
- rendering/DeprecatedRenderSelect.h:
- rendering/DeprecatedSlider.cpp:
- rendering/DeprecatedSlider.h:
- rendering/EllipsisBox.cpp:
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
- rendering/FixedTableLayout.cpp:
- rendering/FixedTableLayout.h:
- rendering/GapRects.h:
- rendering/InlineBox.cpp:
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty):
- rendering/InlineFlowBox.cpp:
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions):
- rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject):
- rendering/Length.h: (WebCore::Length::Length):
- rendering/ListMarkerBox.cpp:
- rendering/ListMarkerBox.h:
- rendering/RenderPartObject.h:
- rendering/RootInlineBox.cpp:
- rendering/RootInlineBox.h:
- rendering/SVGInlineFlowBox.cpp:
- rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
- rendering/SVGRootInlineBox.cpp:
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox):
- rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout):
- rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun):
- rendering/break_lines.h:
- 12:44 PM Changeset in webkit [17337] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by john
<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
- editing/execCommand/remove-formatting-2-expected.checksum: Added.
- editing/execCommand/remove-formatting-2-expected.png: Added.
- editing/execCommand/remove-formatting-2-expected.txt: Added.
- editing/execCommand/remove-formatting-2.html: Added.
- editing/execCommand/remove-formatting-expected.txt:
WebCore:
Reviewed by john
<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
- editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner.
- editing/Editor.h:
- editing/JSEditor.cpp:
- 12:24 PM Changeset in webkit [17336] by
-
- 2 edits in S60/trunk/WebCore
2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>
Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414
merged from 3.1m r17335
- kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
- 12:06 PM Changeset in webkit [17335] by
-
- 2 edits in S60/branches/3.1m/WebCore
2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>
Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414
- kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
- 11:54 AM Changeset in webkit [17334] by
-
- 3 edits4 adds in trunk
2006-10-26 Oliver Hunt <oliver@apple.com>
Reviewed by Anders.
Fixes <rdar://problem/4800518> -- needed to update existing
canvas path elements when transforms are performed on the
context.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate):
- 11:51 AM Changeset in webkit [22430] by
-
- 5 edits in branches/WindowsMerge/WebCore
2006-10-26 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Use FrameLoadRequest and ResourceRequest instead of passing around
the individual components.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::destroyStream):
- plugins/win/PluginStreamWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::frameLoadRequest): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
- plugins/win/PluginViewWin.h:
- 11:27 AM Changeset in webkit [17333] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
Fix build with older gcc 3.3.4.
- kjs/DateMath.cpp: Remove inline prefix. (KJS::equivalentYearForDST):
- 11:25 AM Changeset in webkit [17332] by
-
- 10 edits in trunk
WebCore:
Reviewed by Darin.
Fix Qt/Linux build.
- platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
- platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
- platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest):
WebKitQt:
Reviewed by Darin.
Fix Qt/Linux build.
- QtLauncher/main.cpp: (main):
- WebKitPart/WebKitPart.cpp: (WebKitPart::openUrl):
WebKitTools:
Reviewed by Darin.
Fix Qt/Linux build.
- DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- 11:23 AM Changeset in webkit [22429] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
should close the popup and move selection in the page
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Don't cache the focused index. (WebCore::PopupMenu::focusedIndex): Always get the focused index from the HTMLSelectElement. (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling valueChanged(), as this will change the result of focusedIndex(). (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll the popup. (WebCore::PopupWndProc): Send TAB keypresses and printable characters back to the WebView for handling. Also omove handling of Return/Escape into the WM_CHAR event, as this is recommended by MSDN.
- 11:19 AM Changeset in webkit [17331] by
-
- 8 edits in trunk/WebCore
Reviewed by Adele.
Fix: <rdar://problem/3951815> add "type-to-select" feature for list
boxes (<select> elements)
This also adds type-ahead find for closed menulists (popups).
- WebCore.xcodeproj/project.pbxproj: Version wars.
- html/HTMLSelectElement.h: Add new instance variables for type-ahead find.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new instance variables. (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead find on printable character presses. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove redundant check that the listIndex has changed (setSelectedIndex does this for us), and fix indentation. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if to an else-if. (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind() to strip leading whitespace (including non-breaking spaces) from a string. (WebCore::HTMLSelectElement::typeAheadFind): New method to perform type-ahead find.
- platform/PopupMenu.h: Added new updateFromElement() method to be called from RenderMenuList::updateFromElement().
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::updateFromElement): While we are using NSPopUpButtonCell for our popups, this method can stay empty.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first selected element.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Tell the popup to update if it's visible.
- 11:05 AM Changeset in webkit [17330] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebKit
Tag for WebKit for 10.4.1 (unchanged from 10.4).
- 11:04 AM Changeset in webkit [17329] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/JavaScriptCore
Tag for JavaScriptCore for 10.4.1 (unchanged from 10.4).
- 11:02 AM Changeset in webkit [17328] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/JavaScriptCore
Tag for JavaScriptCore for 10.4 (JavaScriptCore 412).
- 11:01 AM Changeset in webkit [17327] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebKit
Tag for WebKit for 10.4 (WebKit 412).
- 11:00 AM Changeset in webkit [17326] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebCore
Tag for WebCore for 10.4 (WebCore 413).
- 10:59 AM Changeset in webkit [17325] by
-
- 1 add in releases/Apple/Tiger/Mac OS X Update 10.4
New release tag for 10.4.
- 10:57 AM Changeset in webkit [17324] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/JavaScriptCore
Tag for JavaScriptCore for 10.4.2 (JavaScriptCore 412.3).
- 10:56 AM Changeset in webkit [17323] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebKit
Tag for WebKit for 10.4.2 (WebKit 412.6).
- 10:55 AM Changeset in webkit [17322] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebCore
Tag for WebCore for 10.4.2 (WebCore 415.11).
- 10:54 AM Changeset in webkit [17321] by
-
- 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.2
New release tag for 10.4.2.
- 10:53 AM Changeset in webkit [17320] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebCore
Tag for WebCore for 10.4.1 (WebCore 415.5).
- 10:48 AM Changeset in webkit [17319] by
-
- 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.1
New release tag for 10.4.1.
- 10:44 AM Changeset in webkit [17318] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit
Tag for WebKit for 10.4.8 (WebKit 418.9).
- 10:44 AM Changeset in webkit [17317] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebCore
Tag for WebCore for 10.4.8 (WebCore 418.21).
- 10:44 AM Changeset in webkit [17316] by
-
- 1 delete in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit
bad tag.
- 10:43 AM Changeset in webkit [17315] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit/WebCore
Tag for WebCore for 10.4.8 (WebCore 418.21).
- 10:42 AM Changeset in webkit [17314] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit
Tag for WebKit for 10.4.8 (WebKit 418.9).
- 10:40 AM Changeset in webkit [17313] by
-
- 1 edit in trunk/WebCore/ChangeLog
"causing give inconsistent results" -> "causing inconsistent results"
- 10:40 AM Changeset in webkit [17312] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptGlue
Tag for JavaScriptGlue for 10.4.8 (unchanged from 10.4.7).
- 10:39 AM Changeset in webkit [17311] by
-
- 4 edits in trunk
LayoutTests:
Reviewed by Anders.
- removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
- editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the anonymous block that sometimes appeared and sometimes did not.
WebCore:
Reviewed by Anders.
- removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Use two vectors instead of a map: more efficient, deterministic. There was no reason to use a hash table.
- 10:39 AM Changeset in webkit [17310] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptCore
Tag for JavaScriptCore for 10.4.8 (unchanged from 10.4.7).
- 10:38 AM Changeset in webkit [17309] by
-
- 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.8
New release tag.
- 9:59 AM Changeset in webkit [17308] by
-
- 2 edits in trunk/LayoutTests
- oops, checked in failure results, not success
- fast/js/string-property-iteration-expected.txt: Successful results.
- 9:46 AM Changeset in webkit [17307] by
-
- 1 edit3 adds in trunk/LayoutTests
- checked in some missing results (if these are wrong we could remove or disable the test)
- svg/hixie/cascade/002-expected.checksum: Added.
- svg/hixie/cascade/002-expected.png: Added.
- svg/hixie/cascade/002-expected.txt: Added.
- 9:39 AM Changeset in webkit [17306] by
-
- 8 edits3 adds in trunk
Reviewed by John.
- fix iteration of properties of string objects (found because of a warning emitted by the MSVC compiler)
- kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that wants to format a number as a string to use UString::from. Before it was using the UString constructor that makes a string from a character!
- kjs/ustring.h:
- kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char) constructor.
- kjs/grammar.y: Change code to not depend on the UString(char) constructor. This is potentially more efficient anyway because we could overload the + operator some day to handle char* directly instead of creating a UString.
- kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on the UString(char) constructor.
LayoutTests:
Reviewed by John.
- add a test for iteration of properties of string objects
- fast/js/resources/string-property-iteration.js: Added.
- fast/js/string-property-iteration-expected.txt: Added.
- fast/js/string-property-iteration.html: Added.
- 9:06 AM Changeset in webkit [17305] by
-
- 1 edit in trunk/WebKit/English.lproj/Localizable.strings
- 9:05 AM Changeset in webkit [17304] by
-
- 67 edits17 copies in S60/branches/s60-RnD-06wk43
2006-10-25 yadavall <sriram.yadavalli@nokia.com>
Merge of r17301 to s60-RnD-06wk43 release branch.
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407
- 9:05 AM Changeset in webkit [17303] by
-
- 2 edits in trunk/WebKit
No review, just two localized string changes.
- WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
- English.lproj/Localizable.strings: updated for these changes
- 8:23 AM Changeset in webkit [17302] by
-
- 3 edits in S60/trunk/WebKit
2006-10-25 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly
http://bugs.webkit.org/show_bug.cgi?id=
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
- ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
- 6:26 AM Changeset in webkit [17301] by
-
- 67 edits17 adds in S60/trunk
2006-10-25 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407
- BrowserControl/inc/BrCtl.h:
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserControl/inc/BrCtlInterface.h:
- BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::UpdateDefaultSoftkeysL): (CBrCtl::CreateWidgetExtensionL):
- BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
- BrowserView/inc/webkitbridge.h:
- BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::CreateWidgetExtensionL):
- BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
- BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged): (CWebKitBridge::createWidgetObject):
- Plugin/inc/PluginHandler.h:
- Plugin/inc/PluginSkin.h: (CPluginSkin::WebKitControl): (CPluginSkin::Frame):
- Plugin/inc/PluginWin.h:
- Plugin/inc/npapi.h:
- Plugin/src/NpnImplementation.cpp: (NpnGetValue):
- Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginHandler::LoadPluginsSyncL): (CPluginHandler::LoadPluginsL): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::ReloadPluginsL):
- Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::CreatePluginWinL): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::PluginScriptableObject):
- Plugin/src/PluginWin.cpp: (CPluginWin::WindowScriptNPObject): (CPluginWin::PluginScriptableObject):
- group/BrowserView.mmp:
- group/Plugin.mmp:
- group/webkit.mmp:
- rom/webkit.iby:
- 3:34 AM Changeset in webkit [17300] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders.
- .5% speed improvement by avoiding excess CFURLRef allocation
- loader/CachedResource.cpp: (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL here for later reuse.
- loader/CachedResource.h:
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
Oct 25, 2006:
- 10:04 PM Changeset in webkit [17299] by
-
- 40 edits in trunk
WebCore:
Reviewed by Anders.
- removed 55 methods from WebCoreFrameBridge
- changed callers to use Frame directly instead
- put FrameLoaderTypes.h types into the WebCore namespace
- first steps to get FrameLoader.h ready for cross-platform duty
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::startRedirectionTimer): (WebCore::FrameMac::stopRedirectionTimer): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::handledOnloadEvents): (WebCore::FrameMac::isLoadTypeReload):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge executionContextForView:]): (updateRenderingForBindings): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreFrameBridge installInFrame:]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
- loader/FrameLoaderTypes.h:
- loader/mac/FrameLoader.h:
- loader/mac/FrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
- loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense):
- loader/mac/WebMainResourceLoader.h:
- loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
- platform/mac/ListBoxMac.mm: (-[WebCoreTableView keyDown:]): (-[WebCoreTableView keyUp:]):
- platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
WebKit:
Reviewed by Anders.
- removed 55 methods from WebCoreFrameBridge
- changed callers to use Frame directly instead
- put FrameLoaderTypes.h types into the WebCore namespace
- first steps to get FrameLoader.h ready for cross-platform duty
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView getVariable:value:]):
- Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
- Plugins/WebNetscapePluginStream.mm:
- Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _continueWithPolicy:]): (-[WebPluginContainerCheck _isForbiddenFileLoad]):
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): (-[WebFrameBridge finishInitializingWithFrameName:view:]): (-[WebFrameBridge createWindowWithURL:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge createModalDialogWithURL:]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchWillSubmitForm):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
- WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]):
- WebView/WebEditingDelegatePrivate.h:
- WebView/WebFrame.mm: (core): (kit): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _childFramesMatchItem:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _addChild:]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _numPendingOrLoadingRequests:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _initWithWebFrameView:webView:coreFrame:]): (-[WebFrame _documentViews]): (-[WebFrame _updateBackground]): (-[WebFrame _unmarkAllMisspellings]): (-[WebFrame _hasSelection]): (-[WebFrame _atMostOneFrameHasSelection]): (-[WebFrame _findFrameWithSelection]): (-[WebFrame _frameLoader]): (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame name]): (-[WebFrame webView]): (-[WebFrame DOMDocument]): (-[WebFrame frameElement]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation attributedText]):
- WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): (-[WebHTMLView _selectedRange]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _updateActiveState]): (-[NSArray readSelectionFromPasteboard:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray maintainsInactiveSelection]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray centerSelectionInVisibleArea:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray _emptyStyle]): (-[NSArray performKeyEquivalent:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionImageForcingWhiteText:]): (-[WebHTMLView selectionImageRect]): (-[WebHTMLView attributedString]): (-[WebHTMLView _isMoveDrag]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
- WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]): (-[WebPolicyDecisionListener continue]):
- WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame globalObject]):
- WebView/WebView.mm: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView windowScriptObject]): (incrementFrame): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView removeDragCaret]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]): (-[WebView shouldClose]): (-[WebView selectedDOMRange]): (-[WebView styleDeclarationWithText:]):
- 7:43 PM Changeset in webkit [17298] by
-
- 2 edits in trunk/WebKitSite
2006-10-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Adele.
- http://bugs.webkit.org/show_bug.cgi?id=11412 Stray list item in coding/coding-style.html
- coding/coding-style.html:
- 5:48 PM Changeset in webkit [22428] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2006-10-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin.
Checked in Luke's CG printing code
- WebView.cpp: (WebView::print): added (WebViewWndProc): call print from WM_PRINTCLIENT
- WebView.h: added print, m_pages, rearranged includes
- 5:48 PM Changeset in webkit [22427] by
-
- 3 edits in branches/WindowsMerge/WebCore
2006-10-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin.
Checked in Luke's CG printing code
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::setupRootForPrinting): Added (WebCore::FrameWin::computePageRects): Added
- bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects
- 5:43 PM Changeset in webkit [17297] by
-
- 3 edits in trunk/WebCore
2006-10-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin.
Printing fixes
- page/Frame.cpp: (WebCore::Frame::adjustPageHeight):
- page/Frame.h: (WebCore::Frame::setupRootForPrinting): (WebCore::Frame::computePageRects):
- 5:29 PM Changeset in webkit [17296] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Steve (rubber stamp).
- Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
- 5:27 PM Changeset in webkit [17295] by
-
- 2 edits in trunk/WebKitLibraries
Reverting my change, broke the Tiger build.
- 5:12 PM Changeset in webkit [17294] by
-
- 3 edits in trunk/WebCore
2006-10-25 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
<rdar://problem/4799088>
REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]): Set the HTTP method before the HTTP body.
- 4:42 PM Changeset in webkit [17293] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by Kevin Decker.
- libWebKitSystemInterface.a: updated to be 64-bit universal
- 2:15 PM Changeset in webkit [17292] by
-
- 1 copy in S60/branches/s60-RnD-06wk43
New release branch.
- 1:51 PM Changeset in webkit [17291] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Lou.
Removed duplicate symbol declaration.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/grammar.y:
- 1:49 PM Changeset in webkit [17290] by
-
- 20 edits2 moves in trunk
WebCore:
Reviewed by Adam.
Renamed WebFrameLoader to FrameLoader, to match class name.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreFrameBridge.mm:
- loader/mac/FrameLoader.mm: Added.
- loader/mac/IconLoaderMac.mm:
- loader/mac/WebDocumentLoader.mm:
- loader/mac/WebFrameLoader.h: Removed.
- loader/mac/WebFrameLoader.mm: Removed.
- loader/mac/WebLoader.mm:
- loader/mac/WebMainResourceLoader.mm:
- loader/mac/WebNetscapePlugInStreamLoader.mm:
- loader/mac/WebSubresourceLoader.mm:
WebKit:
Reviewed by Adam.
Renamed WebFrameLoader to FrameLoader, to match class name.
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebNetscapePluginStream.mm:
- Plugins/WebPluginController.mm:
- WebCoreSupport/WebFrameBridge.mm:
- WebView/WebDataSource.mm:
- WebView/WebFrame.mm:
- WebView/WebPDFView.mm:
- WebView/WebPolicyDelegate.mm:
- WebView/WebView.mm:
- 12:29 PM Changeset in webkit [17289] by
-
- 2 edits in trunk/WebCore
- fix full builds
- WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
- 5:12 AM Changeset in webkit [17288] by
-
- 2 edits in trunk/WebCore
2006-10-25 David Smith <catfish.man@gmail.com>
Reviewed by Mitz.
Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
http://bugs.webkit.org/show_bug.cgi?id=11411
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
- 2:57 AM Changeset in webkit [17287] by
-
- 2 edits3 moves in trunk/WebCore
Rubber stamped by Mitz.
- moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
- bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
- bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
- 2:55 AM Changeset in webkit [17286] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Mark.
- remove no longer existing symbol that was breaking linking
- WebCore.exp:
- 1:52 AM Changeset in webkit [17285] by
-
- 4 edits in trunk/WebCore
Reviewed by Mitz.
- fixed "REGRESSION: Activity window doesn't always list all files until refresh" http://bugs.webkit.org/show_bug.cgi?id=11212
I couldn't figure out how to write a test case.
- bindings/js/kjs_window.cpp: (KJS::Window::clear): Avoid crashing if already detached.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): Change prototype to make this a proper overload for Frame::clear once again(!).
- 1:22 AM Changeset in webkit [17284] by
-
- 2 edits in trunk/WebKitSite
2006-10-25 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
Fix some HTML bugs in the coding style guidelines.
- coding/coding-style.html:
- 12:52 AM Changeset in webkit [17283] by
-
- 2 edits in trunk/WebKit
2006-10-25 Mark Rowe <bdash@webkit.org>
Reviewed by Anders.
Build fix for the Buildbot.
- WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
- 12:30 AM Changeset in webkit [17282] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
<rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
<rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
- WebView/WebPolicyDeciderMac.m: (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
Oct 24, 2006:
- 10:38 PM Changeset in webkit [17281] by
-
- 2 edits in trunk/WebKit
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- WebKitPrefix.h: Include FastMalloc.h from C++ code.
- 10:35 PM Changeset in webkit [17280] by
-
- 30 edits2 adds in trunk
WebCore:
Reviewed by Anders.
- converted WebFrameLoaderClient to C++
- renamed frame->frameLoader() function to frame->loader()
- renamed [bridge impl] to [bridge _frame]
- removed some bridge methods
- WebCore.exp: Added more exports.
- WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal so it can be used in WebKit.
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame): (WebCore::FrameMac::didFirstLayout):
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge setOpener:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]): (-[WebCoreFrameBridge _frame]): (-[WebCoreFrameBridge executionContextForView:]):
- bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setMainFrame:]):
- dom/Position.cpp: (WebCore::Position::upstream):
- loader/mac/IconLoaderMac.mm: (IconLoader::notifyIconChanged):
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/mac/WebFormState.mm: (WebCore::FormState::FormState):
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::download): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoaderClient::~FrameLoaderClient):
- loader/mac/WebFrameLoaderClient.h:
- loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
- page/Frame.cpp: (WebCore::Frame::loader):
- page/Frame.h:
- platform/mac/SliderMac.mm: (Slider::focusPolicy):
WebKit:
Reviewed by Anders.
- converted WebFrameLoaderClient to C++
- renamed frame->frameLoader() function to frame->loader()
- renamed [bridge impl] to [bridge _frame]
- removed some bridge methods
- Plugins/WebNetscapePluginStream.mm:
- WebCoreSupport/WebEditorClient.mm:
- WebCoreSupport/WebFrameLoaderClient.h: Added. (WebFrameLoaderClient::webFrame):
- WebCoreSupport/WebFrameLoaderClient.mm: Added. (WebFrameLoaderClient::detachFrameLoader): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.mm: (-[WebDataSource webFrame]):
- WebView/WebFrame.mm: (frame): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame parentFrame]): (-[WebFrame _provisionalLoadStarted]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
- WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray changeBaseWritingDirection:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
- WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView setEditable:]):
- 10:30 PM Changeset in webkit [17279] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Anders.
- get rid of the assertion firing while running the layout tests
This does not fix the real problem, which is that we need to map offsets within
possibly-text-transformed text in the render tree to DOM tree offsets and vice
versa -- but it gets the tests running again.
- dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
- 9:25 PM Changeset in webkit [17278] by
-
- 15 edits1 add in trunk
LayoutTests:
Reviewed by Oliver.
- re-enable testing of HEAD methods, now that bugs relating to these are fixed
- http/tests/xmlhttprequest/methods-async-expected.txt:
- http/tests/xmlhttprequest/methods-async.html:
- http/tests/xmlhttprequest/methods-expected.txt:
- http/tests/xmlhttprequest/methods.html:
WebCore:
Reviewed by Oliver.
- more ResourceLoader cleanup
- moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
- took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
- loader/LoaderFunctions.h:
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
- platform/network/HTTPHeaderMap.h: Added.
- platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::requestHeaders):
- platform/network/ResourceLoader.h:
- platform/network/ResourceRequest.h:
- platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
- xml/xmlhttprequest.h:
- 9:23 PM Changeset in webkit [17277] by
-
- 2 edits in trunk/WebKitTools
2006-10-24 Stephanie Lewis <Stephanie Lewis>
Reviewed by Maciej.
- Changed run-javascriptcore tests to build testkjs before running.
- Scripts/run-javascriptcore-tests:
- 9:22 PM Changeset in webkit [22426] by
-
- 5 edits in branches/WindowsMerge/WebCore
Reviewed by Oliver.
- updated for ResourceRequest changes.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders):
- plugins/win/PluginStreamWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
- plugins/win/PluginViewWin.h:
- 6:37 PM Changeset in webkit [17276] by
-
- 13 edits4 adds in trunk
LayoutTests:
Reviewed by darin
<http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker
- editing/execCommand/create-list-1-expected.checksum: Added.
- editing/execCommand/create-list-1-expected.png: Added.
- editing/execCommand/create-list-1-expected.txt: Added.
- editing/execCommand/create-list-1.html: Added.
Fixed:
- editing/execCommand/create-list-with-hr-expected.checksum:
- editing/execCommand/create-list-with-hr-expected.png:
- editing/execCommand/create-list-with-hr-expected.txt:
- editing/execCommand/create-list-with-hr.html:
- editing/execCommand/remove-list-1-expected.checksum:
- editing/execCommand/remove-list-1-expected.png:
- editing/execCommand/remove-list-1-expected.txt:
- fast/text/attributed-substring-from-range-001-expected.txt:
WebCore:
Reviewed by darin
<http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker
List creation uses moveParagraphs to push content into list items.
moveParagraphs uses a TextIterator to restore selections after moves.
Some characters emitted by the TextIterator had bad ranges associated
with them. rangeFromLocationAndLength would skip past the range it
should have used when asked for ranges of length 0.
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): No longer need to initialize a removed member variable. (WebCore::TextIterator::advance): An extra newline is emitted when leaving some blocks. Use the same range for this newline as for the first newline. We should remove this code and just emit two '\n's. (WebCore::TextIterator::handleTextNode): Setup m_range. (WebCore::TextIterator::handleTextBox): Ditto. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::handleNonTextNode): Ditto. (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition in the block we're leaving to that VP after that one. (WebCore::TextIterator::emitCharacter): This function now takes in the start and the end of the range associated with the emited character, and sets up m_range. (WebCore::TextIterator::range): Return m_range. If it is null (we are atEnd), return the end of the range used to create the iterator, as a convenience to callers that use call range() on an iterator that is atEnd. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Same as the changes made to TextIterator's constructor. (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of a null m_positionNode to signal that we're finished. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes made to TextIterator. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified. (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to TextIterator::range. (WebCore::CharacterIterator::range): This function assumed that an iterator's range() was safe to modify. (WebCore::TextIterator::rangeFromLocationAndLength): If the range we're looking for starts in the current chunk, this function assumed that if the chunk started in a text node, it would end in the same text node. This is no longer the case. If the range we're looking for starts in the middle of the current chunk, I assume that the chunk is inside a text node, because those are the only chunks with length greater than one at the moment. If the range we're looking for is a zero length range that starts/ends at the end of the current chunk, we used to return the start of the next chunk, but that's wrong and is what caused this bug.
- editing/TextIterator.h: (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null. (WebCore::SimplifiedBackwardsTextIterator::atEnd):
- editing/visible_units.cpp: (WebCore::previousBoundary): Cleaned up by using a convenience function. (WebCore::nextBoundary): Ditto.
- 6:05 PM Changeset in webkit [22425] by
-
- 4 edits in branches/WindowsMerge
2006-10-24 Steve Falkenburg <sfalken@apple.com>
Build fix for official builds
- 5:31 PM Changeset in webkit [17275] by
-
- 2 edits in trunk/JavaScriptCore
2006-10-24 Steve Falkenburg <sfalken@apple.com>
Build config change
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
- 5:11 PM Changeset in webkit [17274] by
-
- 4 edits in trunk/WebKit
Reviewed by Kevin Decker
- fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
- WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether the spelling panel is already showing. Also, removed else's after returns, and removed braces around one-line if clauses. (-[NSArray showGuessPanel:]): post-Tiger, make this item hide the spelling panel if it's already showing
- English.lproj/Localizable.strings: updated for this change
- 4:49 PM Changeset in webkit [17273] by
-
- 2 edits in trunk/WebCore
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
- platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't retain the header dictionary.
- 4:11 PM Changeset in webkit [17272] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders.
Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
running svg/custom/svg/custom/gradient-attr-update.svg
SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/css/SVGRenderStyleDefs.h:
- 3:59 PM Changeset in webkit [22424] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-24 Steve Falkenburg <sfalken@apple.com>
Bump version to 521.28.6
- WebKit.vcproj/VERSION:
- 3:57 PM Changeset in webkit [22423] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-24 Steve Falkenburg <sfalken@apple.com>
Fix build so it can be submitted.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/merge-opensource.sh:
- rendering/RenderThemeWin.cpp:
- 3:56 PM Changeset in webkit [17271] by
-
- 2 edits in trunk/WebCore
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Mitz.
- platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Set the http method to "GET" in the constructor that takes a String.
- 3:48 PM Changeset in webkit [17270] by
-
- 3 edits20 moves in trunk/WebCore
Reviewed by Tim H.
Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
and rendering/SVG* respectively. Fix Xcode project and
CMakeLists.txt to account for the moves.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/RenderForeignObject.cpp: Removed.
- kcanvas/RenderForeignObject.h: Removed.
- kcanvas/RenderPath.cpp: Removed.
- kcanvas/RenderPath.h: Removed.
- kcanvas/RenderSVGContainer.cpp: Removed.
- kcanvas/RenderSVGContainer.h: Removed.
- kcanvas/RenderSVGImage.cpp: Removed.
- kcanvas/RenderSVGImage.h: Removed.
- kcanvas/RenderSVGInline.cpp: Removed.
- kcanvas/RenderSVGInline.h: Removed.
- kcanvas/RenderSVGInlineText.cpp: Removed.
- kcanvas/RenderSVGInlineText.h: Removed.
- kcanvas/RenderSVGTSpan.cpp: Removed.
- kcanvas/RenderSVGTSpan.h: Removed.
- kcanvas/RenderSVGText.cpp: Removed.
- kcanvas/RenderSVGText.h: Removed.
- kcanvas/SVGInlineFlowBox.cpp: Removed.
- kcanvas/SVGInlineFlowBox.h: Removed.
- kcanvas/SVGRootInlineBox.cpp: Removed.
- kcanvas/SVGRootInlineBox.h: Removed.
- 3:37 PM Changeset in webkit [17269] by
-
- 2 edits in trunk/WebKit/Misc
Build fix.
- 3:34 PM Changeset in webkit [17268] by
-
- 3 edits in trunk/WebKit
Reviewed by Anders.
<rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
- Misc/WebNSViewExtras.h:
- Misc/WebNSViewExtras.m: (-[NSView _webView]):
- 3:28 PM Changeset in webkit [22422] by
-
- 3 edits in branches/WindowsMerge/WebCore
Rolling back in, now fixed:
Nixed a few more redundant loading functions in Frame.
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
- 3:24 PM Changeset in webkit [17267] by
-
- 11 edits in trunk/WebCore
Rolling back in, now fixed:
Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture always 'true', because changing it broke the world, and testing seems to indicate that the one caller that might have passed 'false' didn't need to.
- page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
- page/Frame.h:
- platform/gdk/FrameGdk.cpp:
- platform/gdk/FrameGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
- platform/qt/FrameQt.cpp:
- platform/qt/FrameQt.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
- 3:21 PM Changeset in webkit [22421] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-24 Anders Carlsson <acarlsson@apple.com>
- WebFrame.cpp: (WebFrame::loadDataSource): Forgot to save before committing. Call begin before trying to access the document.
- 3:15 PM Changeset in webkit [22420] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Fix build. (Update for changes to ResourceLoader)
- WebFrame.cpp: (WebFrame::loadDataSource):
- WebURLResponse.cpp: (WebURLResponse::createInstance):
- 3:06 PM Changeset in webkit [17266] by
-
- 2 edits in trunk/WebCore
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Fix the build (Update for changes to ResourceLoader)
- platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
- 2:58 PM Changeset in webkit [22419] by
-
- 5 edits in branches/WindowsMerge/WebCore
Reviewed by Geoff.
- update for ResourceLoader API changes
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest):
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::receivedAllData):
- plugins/win/PluginStreamWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 2:57 PM Changeset in webkit [17265] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz.
Change #includes using <kcanvas/*.h> to use "*.h" instead
to prepare for moving the kcanvas files.
- kcanvas/RenderSVGContainer.h:
- ksvg2/svg/SVGAElement.cpp:
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
- ksvg2/svg/SVGFETileElement.cpp:
- ksvg2/svg/SVGStyledLocatableElement.cpp:
- ksvg2/svg/SVGStyledTransformableElement.cpp:
- 2:53 PM Changeset in webkit [17264] by
-
- 18 edits in trunk/WebCore
Reviewed by Darin.
- More movement towards the final network API.
Changed ResourceLoader::create to take a ResurceRequest and start
the load. Removed methods relating to setting request
headers. Removed methods relating to metaData. Added some more
convenience methods to ResourceRequest.
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- loader/LoaderFunctions.h:
- loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didFinishLoading):
- loader/icon/IconLoader.h:
- loader/loader.cpp: (WebCore::Loader::servePendingRequests):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm):
- platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::responseHTTPHeadersAsString): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
- platform/network/ResourceLoader.h:
- platform/network/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::httpAccept): (WebCore::ResourceRequest::setHTTPAccept): (WebCore::ResourceRequest::addHTTPHeaderFields):
- platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
- xml/xmlhttprequest.h:
- 2:26 PM Changeset in webkit [17263] by
-
- 3 edits in trunk/WebCore
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
- loader/FormData.cpp: (WebCore::FormData::FormData):
- loader/FormData.h: (WebCore::FormData::FormData): Add new constructor that takes a void* and a size.
- 2:25 PM Changeset in webkit [17262] by
-
- 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm
Build fix for un-initialized var.
- 2:24 PM Changeset in webkit [17261] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders
http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
to prevent null dereferencing.
- WebView/WebFrame.mm: (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]):
- 2:17 PM Changeset in webkit [22418] by
-
- 3 edits in branches/WindowsMerge/WebCore
Rolling out my last change because it broke the world.
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURL):
- 2:14 PM Changeset in webkit [17260] by
-
- 11 edits in trunk/WebCore
Rolling out my last change because it broke the world.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
- page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::frameLoader): (WebCore::Frame::requestFrame): (WebCore::Frame::redirectionTimerFired):
- page/Frame.h:
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL):
- platform/gdk/FrameGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::openURLRequest):
- platform/qt/FrameQt.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::openURL): (WebCore::FrameWin::openURLRequest):
- 1:50 PM Changeset in webkit [17259] by
-
- 2 edits in trunk/WebCore/loader/mac
Build fixes for 64-bit.
- 1:46 PM Changeset in webkit [17258] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Brady.
- Fixes a date formatting issue on win. Specifically strftime cannot handle some ranges of time so we shift time call strftime and then manipulate the returned string, if needed.
- kjs/date_object.cpp: (KJS::): (KJS::formatLocaleDate): (KJS::DateProtoFunc::callAsFunction):
- 1:03 PM Changeset in webkit [17257] by
-
- 23 edits4 deletes in trunk/WebCore
2006-10-24 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Adam.
Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
or broken.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeStyle):
- kcanvas/RenderPath.cpp: (WebCore::RenderPath::fillContains):
- kcanvas/device/KRenderingFillPainter.cpp:
- kcanvas/device/KRenderingFillPainter.h:
- kcanvas/device/KRenderingStrokePainter.cpp:
- kcanvas/device/KRenderingStrokePainter.h:
- kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):
- kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
- kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
- kcanvas/device/qt/KRenderingPaintServerQt.h:
- kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup):
- kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke): (WebCore::RenderPath::strokeBBox):
- kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
- kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
- kcanvas/device/quartz/QuartzSupport.h: (WebCore::CGLineCapFromKC): (WebCore::CGLineJoinFromKC):
- kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
- ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::):
- ksvg2/css/SVGRenderStyleDefs.h:
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
- ksvg2/misc/KCanvasRenderingStyle.h:
- ksvg2/svg/SVGFEImageElement.cpp:
- 12:54 PM Changeset in webkit [22417] by
-
- 6 edits in branches/WindowsMerge/WebCore
2006-10-24 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
<rdar://problem/4760429> Crash in PluginStreamWin::~PluginStreamWin when
navigating away from mcdonalds.com
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Use fastFree instead of free when memory is allocated by fastMalloc. If the plugin name or description is null, don't try to fetch info about the plugin.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
- plugins/win/PluginStreamWin.h: Change type of header map to ResourceRequest::HTTPHeaderMap. When a plugin is stopped, set its state to StreamStopped.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
- plugins/win/PluginViewWin.h: Update for type changes to the header map.
- 12:20 PM Changeset in webkit [22416] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
Nixed a few more redundant loading functions in Frame.
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
- 12:17 PM Changeset in webkit [17256] by
-
- 11 edits in trunk/WebCore
Reviewed by Anders.
Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture to actually check for a user gesture. New callers rely on this behavior, and it seems like the previous behavior must have been a bug.
- page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
- page/Frame.h:
- platform/gdk/FrameGdk.cpp:
- platform/gdk/FrameGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
- platform/qt/FrameQt.cpp:
- platform/qt/FrameQt.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
- 12:14 PM Changeset in webkit [17255] by
-
- 14 edits4 adds in trunk/WebKit
Reviewed by Darin
Initial plumbing for grammar checking. No actual grammar are checked at this time.
- English.lproj/WebViewEditingContextMenu.nib/classes.nib:
- English.lproj/WebViewEditingContextMenu.nib/info.nib:
- English.lproj/WebViewEditingContextMenu.nib/objects.nib: Added grammar-checking item, reworded to match changes in framework. This will be used post-Tiger.
- English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
- English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
- English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added. Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Choose the right context menu based on BUILDING_ON_TIGER.
- WebView/WebPreferenceKeysPrivate.h: declare grammar-related NSUserDefault value
- WebView/WebViewPrivate.h: declare grammar-related methods
- WebView/WebView.mm: declare static BOOL grammarCheckingEnabled (-[WebViewPrivate init]): initialize grammarCheckingEnabled to NSUserDefaults value (-[WebView validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebView isGrammarCheckingEnabled]): return value of grammarCheckingEnabled (-[WebView setGrammarCheckingEnabled:]): set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers (-[WebView toggleGrammarChecking:]): flip the value
- WebView/WebFrameInternal.h:
- WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): new placeholder method, does nothing yet
- WebView/WebHTMLViewInternal.h: declare grammar-related methods
- WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebHTMLView isGrammarCheckingEnabled]): new method, calls through to WebView (-[WebHTMLView setGrammarCheckingEnabled:]): ditto (-[WebHTMLView toggleGrammarChecking:]): ditto
- English.lproj/StringsNotToBeLocalized.txt: Updated for these changes
- WebKit.xcodeproj/project.pbxproj: updated for new files
- 8:14 AM Changeset in webkit [17254] by
-
- 12 edits in S60/trunk
Reviewed by Sachin.
DESC: Automatically open download file progressively settings. If yes,
then download file will be open progressively. If no, then the user
need to open the file manually.
- 6:10 AM Changeset in webkit [17253] by
-
- 10 edits2 deletes in trunk
WebCore:
Reviewed by Maciej.
Fix Qt/Linux build.
- Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
- Fix CMakeLists.txt to include platform/network.
- CMakeLists.txt:
- platform/qt/BrowserExtensionQt.cpp: Removed.
- platform/qt/BrowserExtensionQt.h: Removed.
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::createNewWindow): (WebCore::FrameQt::goBackOrForward): (WebCore::FrameQt::historyURL): (WebCore::FrameQt::getHistoryLength):
- platform/qt/FrameQt.h:
- platform/qt/PageQt.cpp: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):
WebKitQt:
Reviewed by Maciej.
Fix Qt/Linux build.
- Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
- Fix CMakeLists.txt to include platform/network.
- QtLauncher/CMakeLists.txt:
- WebKitPart/CMakeLists.txt:
WebKitTools:
Reviewed by Maciej.
Fix Qt/Linux build.
- Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
- Fix CMakeLists.txt to include platform/network.
- DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
- 6:06 AM Changeset in webkit [17252] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim H.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
Fix build when XSLT_SUPPORT is not defined
Fix unconditional use of XSLT support.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end):
- 4:26 AM Changeset in webkit [17251] by
-
- 5 edits in trunk
2006-10-24 Simon Hausmann <hausmann@kde.org>
Reviewed by Darin.
- CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.
2006-10-24 Simon Hausmann <hausmann@kde.org>
Reviewed by Darin.
- QtLauncher/CMakeLists.txt, WebKitPart/CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.
- 4:19 AM Changeset in webkit [17250] by
-
- 2 edits in trunk/WebKitTools
2006-10-24 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
http://bugs.webkit.org/show_bug.cgi?id=11382
- Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.
- 4:15 AM Changeset in webkit [17249] by
-
- 2 edits in trunk/WebCore
2006-10-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Tim H.
- fix http://bugs.webkit.org/show_bug.cgi?id=11394 HTMLViewSourceDocuments are leaking
- html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid ref cycle.
- 1:49 AM Changeset in webkit [17248] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin.
Removed one of Frame's redundant urlSelected methods.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): since it's unused.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString to String because the former is deprecated and its performance is irrelevant here. Added call to completeURL because Frame no longer does it for us. Having the call here also improves clarity about the element's behavior.
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre irrelevent NULL checks on ownerDocument() because I couldn't help myself.
- page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected):
- page/Frame.h:
- platform/network/ResourceRequest.h: Removed explicit keyword on constructor because we want to be able to use these constructors instead of helper functions mimicking their behavior sprinkled across different classes. (WebCore::ResourceRequest::ResourceRequest):
- 12:59 AM Changeset in webkit [17247] by
-
- 11 edits in trunk/WebCore
Reviewed by Maciej
Moved FrameLoader from WebCoreFrameBridge to Frame. Frame.h/cpp have generic accessors to the FrameLoader itself
and creation/deletion is currently managed in FrameMac.mm
Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
frame instead of the bridge.
The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
use of it as its days are numbered!
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Create the FrameLoader (WebCore::FrameMac::~FrameMac): Nuke it (WebCore::FrameMac::loadRequest):
- bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader):
- loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete):
- loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
- page/Frame.cpp: (WebCore::Frame::frameLoader):
- page/Frame.h:
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
- 12:33 AM Changeset in webkit [17246] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed two crashes in layout tests I just introduced
- loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): Add null check. (WebCore::FrameLoader::setState): Ditto.
Oct 23, 2006:
- 11:19 PM Changeset in webkit [17245] by
-
- 19 edits in trunk
WebCore:
Reviewed by Geoff.
- converted WebDocumentLoader to C++
- WebCore.exp:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge mainResourceURLResponse]):
- loader/mac/WebDocumentLoader.h:
- loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::bridge): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::detachFromParent):
- loader/mac/WebFrameLoaderClient.h:
WebKit:
Reviewed by Geoff.
- converted WebDocumentLoader to C++
- Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
- WebView/WebDataSourceInternal.h:
- WebView/WebDocumentLoaderMac.h:
- WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::dataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame):
- WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addChild:]): (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame loadArchive:]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]): (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _makeRepresentationForDocumentLoader:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _provisionalLoadStarted]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
- WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]):
- 11:18 PM Changeset in webkit [22415] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-23 Ada Chan <adachan@apple.com>
Reviewed by sfalken.
We forgot to add a reference in WebNotificationCenter::addObserver.
- 10:13 PM Changeset in webkit [17244] by
-
- 2 edits2 moves in trunk/WebKit
RS by Maciej.
Gave ObjC++ files .mm extension instead of .m.
- WebCoreSupport/WebPageBridge.m: Removed.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDocumentLoaderMac.m: Removed.
- 9:59 PM Changeset in webkit [17243] by
-
- 6 edits in trunk/WebCore
Lovingly reviewed by Maciej
Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
- bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
- bridge/mac/WebCoreFrameBridge.mm: Ditto
- loader/mac/WebFrameLoader.mm: (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
- 9:45 PM Changeset in webkit [17242] by
-
- 5 edits in trunk/WebCore
RS by Maciej.
Inside Frame, moved the plethora of load() and stopLoading() functions next
to each other to facilitate merging and crying.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::createFrame):
- page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::stop): (WebCore::Frame::closeURL): (WebCore::Frame::cancelRedirection): (WebCore::Frame::iconURL): (WebCore::Frame::didOpenURL): (WebCore::Frame::didExplicitOpen):
- page/Frame.h:
- 9:12 PM Changeset in webkit [17241] by
-
- 3 edits in trunk/WebCore
RS by Maciej.
Moved our plethora of load() and stopLoading() functions next to each other
to facilitate merging and laughter.
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (WebCore::cancelAll): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader):
- 8:55 PM Changeset in webkit [17240] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by
- Build fix
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/grammar.y:
- 8:44 PM Changeset in webkit [17239] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Makes the toTM function an operator. Was going to piggy back on a patch but the patch needs more work.
- kjs/DateMath.cpp: (KJS::equivalentYearForDST):
- kjs/DateMath.h: (KJS::GregorianDateTime::operator tm):
- kjs/date_object.cpp: (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction):
- 8:28 PM Changeset in webkit [17238] by
-
- 32 edits in trunk
WebCore:
Reviewed by Maciej.
- converted WebFrameLoader to C++
- WebCore.exp: Added many new entry points for WebKit.
- WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge clearFrame]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
- loader/mac/WebDocumentLoader.h:
- loader/mac/WebDocumentLoader.mm: (-[WebDocumentLoader frameLoader]): (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader mainResourceData]): (-[WebDocumentLoader setRequest:]): (-[WebDocumentLoader bridge]): (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader stopLoading]): (-[WebDocumentLoader setupForReplace]): (-[WebDocumentLoader commitIfReady]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setFrame:]): (-[WebDocumentLoader attachToFrame]): (-[WebDocumentLoader detachFromFrame]): (-[WebDocumentLoader prepareForLoadStart]): (-[WebDocumentLoader setPrimaryLoadComplete:]): (-[WebDocumentLoader isLoadingInAPISense]): (-[WebDocumentLoader setTitle:]):
- loader/mac/WebFrameLoader.h: (WebCore::FrameLoader::frame):
- loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::defersCallbacks): (WebCore::setAllDefersCallbacks): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::cancelAll): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::load): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::download): (WebCore::FrameLoader::bridge): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setFrameLoaderClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::asDelegate): (-[WebCoreFrameLoaderAsDelegate initWithLoader:]): (-[WebCoreFrameLoaderAsDelegate detachFromLoader]): (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
- loader/mac/WebLoader.h: (WebCore::WebResourceLoader::identifier): (WebCore::WebResourceLoader::reachedTerminalState): (WebCore::WebResourceLoader::cancelled):
- loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::releaseResources): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::frameLoader): (WebCore::WebResourceLoader::willSendRequest): (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge): (WebCore::WebResourceLoader::didCancelAuthenticationChallenge): (WebCore::WebResourceLoader::didReceiveResponse): (WebCore::WebResourceLoader::didReceiveData): (WebCore::WebResourceLoader::didFinishLoading): (WebCore::WebResourceLoader::didFinishLoadingOnePart): (WebCore::WebResourceLoader::didFail): (WebCore::WebResourceLoader::willCacheResponse): (WebCore::WebResourceLoader::didCancel): (WebCore::WebResourceLoader::cancel): (WebCore::WebResourceLoader::cancelledError): (WebCore::WebResourceLoader::delegate):
- loader/mac/WebMainResourceLoader.h:
- loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::policyDelegate):
- loader/mac/WebNetscapePlugInStreamLoader.h:
- loader/mac/WebNetscapePlugInStreamLoader.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
WebKit:
Reviewed by Maciej.
- converted WebFrameLoader to C++
- History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]):
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController pluginView:receivedResponse:]):
- WebCoreSupport/WebFrameBridge.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.mm: (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
- WebView/WebDocumentLoaderMac.h:
- WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac dealloc]): (-[WebDocumentLoaderMac attachToFrame]): (-[WebDocumentLoaderMac detachFromFrame]):
- WebView/WebFrame.mm: (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _frameLoader]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.m: (-[WebHTMLView _clearLastHitViewIfSelf]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray removeMouseMovedObserverUnconditionally]): (-[NSArray removeMouseMovedObserver]): (-[NSArray viewWillMoveToWindow:]): (-[NSArray viewDidMoveToWindow]): (-[WebHTMLView _canMakeTextSmaller]): (-[WebHTMLView _canMakeTextLarger]): (-[WebHTMLView _canMakeTextStandardSize]):
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
- WebView/WebView.mm: (-[WebView _close]): (-[WebView setDefersCallbacks:]): (-[WebView setCustomTextEncodingName:]):
- 8:23 PM Changeset in webkit [22414] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Bradee.
Removed methods from BrowserExtension.
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::goBackOrForward): (FrameWin::getHistoryLength): (FrameWin::historyURL): (Page::canRunModal): (Page::canRunModalNow): (Page::runModal): (BrowserExtensionWin::BrowserExtensionWin):
- 8:18 PM Changeset in webkit [17237] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- Fixes two regressions on win. Both are stack overflows. For one the number of regressions is capped at 100, and for the other, nested parenthesis pairs are not evaluated (since they would evaluate to whatever is in them anyway).
- kjs/grammar.y:
- kjs/object.cpp:
- 8:18 PM Changeset in webkit [17236] by
-
- 17 edits in trunk
WebCore:
Reviewed by Bradee.
Shrunk BrowserExtension in preparation for its imminent death, moving page-
level operations to Page and frame-level operations to Frame.
Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
because 'this' is guaranteed by the compiler to be a FrameMac*.
- bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places where it can be NULL.
- bindings/js/kjs_window.cpp: (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
- bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
- bridge/mac/BrowserExtensionMac.h:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::unfocusWindow): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::documentViewForNode): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight): (WebCore::FrameMac::getHistoryLength): (WebCore::FrameMac::goBackOrForward): (WebCore::FrameMac::historyURL):
- bridge/mac/PageMac.mm: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCorePageBridge.h:
- bridge/win/BrowserExtensionWin.h:
- page/Frame.cpp: (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
- page/Frame.h:
- page/Page.h:
WebKit:
Reviewed by Bradee.
Moved some page-level operations from WebFrameBridge to WebPageBridge.
- WebCoreSupport/WebFrameBridge.m:
- WebCoreSupport/WebPageBridge.m: (-[WebPageBridge createModalDialogWithURL:referrer:]): (-[WebPageBridge canRunModal]): (-[WebPageBridge canRunModalNow]): (-[WebPageBridge runModal]):
- WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support WebCore #includes.
- 7:36 PM Changeset in webkit [17235] by
-
- 2 adds in trunk/LayoutTests/editing/execCommand
- 7:35 PM Changeset in webkit [17234] by
-
- 7 edits in trunk
LayoutTests:
Reviewed by mjs
<http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
- editing/execCommand/queryCommandState-01-expected.txt: Added.
- editing/execCommand/queryCommandState-01.html: Added.
WebCore:
Reviewed by mjs
<http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): Added. (WebCore::Editor::selectionOrderedListState): Added.
- editing/Editor.h:
- editing/JSEditor.cpp:
- page/Frame.cpp:
- page/Frame.h:
- 4:57 PM Changeset in webkit [17233] by
-
- 2 edits in trunk/WebKit
- WebKitPrefix.h: Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had already been added between the last time I updated in this tree and when I needed it locally.
- 4:10 PM Changeset in webkit [17232] by
-
- 1 edit in trunk/WebKit/WebKitPrefix.h
Checked in this file that I mentioned in the previous ChangeLog entry but forgot to check in.
- 4:03 PM Changeset in webkit [17231] by
-
- 2 edits in trunk/WebKit
Reviewed by Ander
- WebKit.xcodeproj/project.pbxproj: Move WebKitPrefix.h from Misc group to top level, to match WebCore
- WebKitPrefix.h: defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
- 3:56 PM Changeset in webkit [17230] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim H
- WebCore.xcodeproj/project.pbxproj: Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
- 3:40 PM Changeset in webkit [17229] by
-
- 4 edits10 moves in trunk/WebKit
Reviewed by Darin.
Rename the now ObjC++ files to be .mm and remove the explicit file types.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
- English.lproj/StringsNotToBeLocalized.txt:
- Plugins/WebBaseNetscapePluginView.m: Removed.
- Plugins/WebNetscapePluginStream.m: Removed.
- Plugins/WebPluginController.m: Removed.
- WebCoreSupport/WebFrameBridge.m: Removed.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: Removed.
- WebView/WebFrame.m: Removed.
- WebView/WebFrameView.m: Removed.
- WebView/WebPDFView.m: Removed.
- WebView/WebPolicyDelegate.m: Removed.
- WebView/WebView.m: Removed.
- 3:27 PM Changeset in webkit [17228] by
-
- 5 edits2 adds in trunk/WebKit
Reviewed by Darin.
Move the undef try/catch to WebKitPrfix.h and include algorithm so we get
exception_defines.h and so the undef of try/catch works.
Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
framework to complain about C++ exceptions being disabled.
- Misc/WebGraphicsExtras.c: Added. (WebConvertBGRAToARGB):
- Misc/WebGraphicsExtras.h: Added.
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
- WebKit.xcodeproj/project.pbxproj:
- WebKitPrefix.h:
- WebView/WebView.m:
- 3:22 PM Changeset in webkit [17227] by
-
- 3 edits16 adds16 deletes in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
PNG as cursor image format instead of TIFF
Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)
- Convert cursor images from TIFF to PNG.
- Resources/eastResizeCursor.png: Added.
- Resources/eastResizeCursor.tiff: Removed.
- Resources/eastWestResizeCursor.png: Added.
- Resources/eastWestResizeCursor.tiff: Removed.
- Resources/helpCursor.png: Added.
- Resources/helpCursor.tiff: Removed.
- Resources/linkCursor.png: Added.
- Resources/linkCursor.tiff: Removed.
- Resources/moveCursor.png: Added.
- Resources/moveCursor.tiff: Removed.
- Resources/northEastResizeCursor.png: Added.
- Resources/northEastResizeCursor.tiff: Removed.
- Resources/northEastSouthWestResizeCursor.png: Added.
- Resources/northEastSouthWestResizeCursor.tiff: Removed.
- Resources/northResizeCursor.png: Added.
- Resources/northResizeCursor.tiff: Removed.
- Resources/northSouthResizeCursor.png: Added.
- Resources/northSouthResizeCursor.tiff: Removed.
- Resources/northWestResizeCursor.png: Added.
- Resources/northWestResizeCursor.tiff: Removed.
- Resources/northWestSouthEastResizeCursor.png: Added.
- Resources/northWestSouthEastResizeCursor.tiff: Removed.
- Resources/southEastResizeCursor.png: Added.
- Resources/southEastResizeCursor.tiff: Removed.
- Resources/southResizeCursor.png: Added.
- Resources/southResizeCursor.tiff: Removed.
- Resources/southWestResizeCursor.png: Added.
- Resources/southWestResizeCursor.tiff: Removed.
- Resources/waitCursor.png: Added.
- Resources/waitCursor.tiff: Removed.
- Resources/westResizeCursor.png: Added.
- Resources/westResizeCursor.tiff: Removed.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):
- 3:15 PM Changeset in webkit [17226] by
-
- 3 edits in trunk/WebCore
Not reviewed.
- fixed build from last change.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::openURL):
- 3:03 PM Changeset in webkit [22413] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Reviewed by Adele.
Fix: <rdar://problem/4796994> Styled <select>s should still use Windows
theme
The fix is to do most of our drawing for menulists in
RenderThemeWin::paintMenuListButton (which is called for styled
<select>s), and then do any extra drawing for unstyled <select>s in
RenderThemeWin::paintMenuList.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Case for MenulistButtonAppearance should be the same as MenulistAppearance. (WebCore::RenderThemeWin::paintMenuList): Draw the border, then defer to paintMenuListButton to handle the rest of painting. (WebCore::RenderThemeWin::adjustMenuListStyle): Reset the border so we can draw our own, then defer to adjustMenuListStyle. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Code moved from adjustMenuListStyle, less the call to resetBorder(). (WebCore::RenderThemeWin::paintMenuListButton): Code moved from paintMenuList, less the border-drawing code.
- rendering/RenderThemeWin.h:
- 3:00 PM Changeset in webkit [17225] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
Move border-radius rule for <select>s into RenderThemeMac, as this is
really a platform-specific look.
- css/html4.css:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
- 2:53 PM Changeset in webkit [22412] by
-
- 8 edits in branches/WindowsMerge/WebKitWin
2006-10-23 Steve Falkenburg <sfalken@apple.com>
Reviewed by Lou.
- MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToCFStringRef): Fix leak in BSTRToCFStringRef
- WebEditorClient.cpp: (WebEditorClient::WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView (WebEditorClient::~WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView
- WebFrame.cpp: (WebFrame::initWithWebFrameView): (WebFrame::windowResizerRect): Fix reference leaks
- WebHistory.cpp: (createUserInfoFromArray): Fixed leak of key CFStringRef. (WebHistory::setOptionalSharedHistory): Made this callable with a 0 to release shared history (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::containsItemForURLLatin1): Don't hold a ref to the WebHistoryPrivate
- WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): Don't hold a reference to the WebIconDatabase
- WebIconDatabase.cpp: (WebIconDatabase::~WebIconDatabase): Delete core icon db on delete
- WebNotificationCenter.cpp: (ObserverKey::ObserverKey): Init data to 0 before calling assignment op (ObserverKey::operator=): Free old string, release old ref if needed before copy
- 2:44 PM Changeset in webkit [17224] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady.
- moved things around so loadURL:... is only called from one place
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
- 2:29 PM Changeset in webkit [17223] by
-
- 7 edits20 adds in trunk
LayoutTests:
Reviewed by john
<http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
- editing/inserting/insert-br-009-expected.checksum: Added.
- editing/inserting/insert-br-009-expected.png: Added.
- editing/inserting/insert-br-009-expected.txt: Added.
- editing/inserting/insert-br-009.html: Added.
- editing/inserting/insert-paragraph-01-expected.checksum: Added.
- editing/inserting/insert-paragraph-01-expected.png: Added.
- editing/inserting/insert-paragraph-01-expected.txt: Added.
- editing/inserting/insert-paragraph-01.html: Added.
- editing/inserting/insert-paragraph-02-expected.checksum: Added.
- editing/inserting/insert-paragraph-02-expected.png: Added.
- editing/inserting/insert-paragraph-02-expected.txt: Added.
- editing/inserting/insert-paragraph-02.html: Added.
- editing/inserting/insert-paragraph-03-expected.checksum: Added.
- editing/inserting/insert-paragraph-03-expected.png: Added.
- editing/inserting/insert-paragraph-03-expected.txt: Added.
- editing/inserting/insert-paragraph-03.html: Added.
- editing/inserting/insert-paragraph-04-expected.checksum: Added.
- editing/inserting/insert-paragraph-04-expected.png: Added.
- editing/inserting/insert-paragraph-04-expected.txt: Added.
- editing/inserting/insert-paragraph-04.html: Added.
WebCore:
Reviewed by john
<http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
Added special cases in InsertLineBreakCommand for inserting before
and after tables and horizontal rules. Also, perform InsertLineBreak
instead of InsertParagraphSeparator at these positions.
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use the canonical form of the caret position when we check for the new special cases because we know that we canonicalize VisiblePositions to those positions. Added code to handle inserting before/after tables and horizontal rules. Fixed a bug when inserting at the end of a block (it checked for a collapse of the inserted br by looking for the absence of a br, but the line break might have been a '\n' in white-space:pre text). Removed unused LOGs.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an InsertLineBreakCommand when before/after a table or a horizontal rule so that we don't have to maintain two pieces of special case code. Migrated to enclosingBlock.
- editing/htmlediting.cpp: Added a FIXME.
- editing/visible_units.cpp: (WebCore::startOfParagraph): Added a workaround for 8622.
- 1:59 PM Changeset in webkit [17222] by
-
- 2 edits in trunk/JavaScriptCore
2006-10-21 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Add minimal compatibility with MSVCRT leak checker
- wtf/FastMalloc.h:
- 1:37 PM Changeset in webkit [22411] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Fix: <rdar://problem/4786759> PageUp/PageDown/Home/End don't work in
<select> menus
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): Only call ::UpdateWindow if we didn't scroll, because scrolling will do the update for us. (WebCore::PopupMenu::focusFirst): New method. (WebCore::PopupMenu::focusLast): New method. (WebCore::PopupMenu::down): Add a parameter to specify how far we should try to move the selection. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): Cleanup code by using IntRect instead of RECT. (WebCore::PopupMenu::scrollTo): Return a boolean to say whether scrolling actually happened. (WebCore::PopupMenu::scrollToRevealSelection): Ditto. (WebCore::PopupWndProc): Handle PageUp/PageDown/Home/End.
- 1:34 PM Changeset in webkit [17221] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
Make popups a little more flexible.
- platform/PopupMenu.h:
- 12:45 PM Changeset in webkit [17220] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim H.
Cleanup CodeGeneratorJS.pm
- bindings/scripts/CodeGeneratorJS.pm:
- 12:21 PM Changeset in webkit [17219] by
-
- 2 edits in trunk/WebCore/Resources
Reverting two images that got commited as empty files after being compressed.
- 12:03 PM Changeset in webkit [17218] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geof.
- Sets the lowercase range correctly in the test and consolidates a variable to make the test more readable.
- tests/mozilla/ecma/String/15.5.4.11-2.js:
- 11:58 AM Changeset in webkit [17217] by
-
- 2 edits in trunk/WebKit
Build fix.
- 11:35 AM Changeset in webkit [17216] by
-
- 2 edits in trunk
Build fix. We can't make the internal DOM headers private since they are not generated at the time installhdrs is called, this break B&I builds.
- 11:24 AM Changeset in webkit [22410] by
-
- 9 edits in branches/WindowsMerge
WebCoreWin:
Build fix.
- WebCore.vcproj/WebCore.vcproj: Copy headers from new platform/network directory and subdirectories.
WebKitWin:
Build fix.
- WebFrame.cpp: Change header paths to point to new platform/network directory and subdirectories.
- WebFrame.h: Ditto.
- WebURLResponse.cpp: Ditto.
- WebURLResponse.h: Ditto.
- WebView.cpp: Ditto.
- WebKit.vcproj/WebKit.vcproj: Add platform/network and subdirectories to AdditionalIncludeDirectories.
- 11:23 AM Changeset in webkit [17215] by
-
- 4 edits in trunk/WebCore/Resources
Compressing TIFFs to fix verification error.
- 10:02 AM Changeset in webkit [22409] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- plugins/win/PluginStreamWin.h: Rename methods to match Maciej's changes.
- 9:50 AM Changeset in webkit [17214] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Brady.
- loader/icon/IconLoader.h: Changed angle-brackets to quotes for #include of ResourceLoader.h, since it's a WebCore header.
- 9:50 AM Changeset in webkit [22408] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj: Copied AdditionalIncludeDirectories from Release to All Configurations.
- 8:47 AM Changeset in webkit [17213] by
-
- 2 edits in trunk/WebCore
- fixed mistake that was preventing any loading from happening
- platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): Changed parameter back to int. Perhaps we want to move to "long long" consistently, but I'll leave that up to Maciej.
- 3:01 AM Changeset in webkit [22407] by
-
- 7 edits in branches/WindowsMerge
WebCoreWin:
Rubber-stamped by Anders.
- fixed for ResourceLoader refactoring.
- platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
WebKitWin:
Rubber-stamped by Anders.
- fixed for ResourceLoader refactoring.
- WebFrame.cpp: (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
- WebFrame.h:
- 2:07 AM Changeset in webkit [17212] by
-
- 17 edits in trunk/WebCore
Reviewed by Anders.
- start converting ResourceLoaderClient to new API
Did the bits I could do without introducing new types:
- renamed receivedData to didReceiveData
- renamed version of receivedAllData that doesn't pass any data to didFinishLoading
- bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
- loader/icon/IconLoader.cpp: (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
- loader/icon/IconLoader.h:
- loader/loader.cpp: (WebCore::Loader::didReceiveData):
- loader/loader.h:
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::didReceiveData):
- platform/gdk/FrameGdk.h:
- platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): (WebCore::ResourceLoaderClient::didFinishLoading): (WebCore::ResourceLoaderClient::receivedResponse):
- platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceLoader::cancel):
- platform/network/gdk/ResourceLoaderManager.cpp: (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove):
- platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::remove):
- platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::didReceiveData):
- platform/qt/FrameQtClient.h:
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
- xml/xmlhttprequest.h:
- 1:00 AM Changeset in webkit [17211] by
-
- 1 edit in trunk/WebCore/ChangeLog
Rubber stamped by Anders.
- marked files executable
- ksvg2/scripts/csscssmakeprops:
- ksvg2/scripts/csscssmakevalues:
Oct 22, 2006:
- 5:44 PM Changeset in webkit [22406] by
-
- 2 edits2 moves2 adds in branches/WindowsMerge/WebCore
Reviewed by Anders.
- updated for new ResourceLoader file locations.
- WebCore.vcproj/WebCore.vcproj: Updated file paths.
- platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win
- platform/win/ResourceLoaderWin.h: ditto
- 5:20 PM Changeset in webkit [17210] by
-
- 6 edits15 moves6 adds in trunk/WebCore
Reviewed by Anders.
- moved ResourceLoader and related files to platform/network in preparation for building out this API.
I tried to update all the build systems but I'm not sure they are
all fixed properly
- page/ResourceRequest.h: Moved to platform/network.
- platform/ResourceLoader.cpp: Moved to platform/network.
- platform/ResourceLoader.h: Moved to platform/network.
- platform/ResourceLoaderClient.h: Moved to platform/network.
- platform/ResourceLoaderInternal.h: Moved to platform/network.
- platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
- platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
- platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
- platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
- platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
- platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
- platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
- platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
- platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
- platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
- webcore-base.bkl: Updated for new paths.
- CMakeLists.txt: ditto
- Projects/gdk/webcore-gdk.bkl: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- WebCoreSources.bkl: ditto
- 12:59 PM Changeset in webkit [22405] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Steve.
Fix some crashes caused by the <select> element being detached while
the popup is open.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
- 11:01 AM Changeset in webkit [17209] by
-
- 5 edits in trunk
WebCore:
Reviewed by Tim H.
- Add DOMHTMLFormElementPrivate.h to the project.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMPrivate.h:
WebKit:
Reviewed by Tim H.
- Add DOMHTMLFormElementPrivate.h to the project.
- MigrateHeaders.make:
- 12:31 AM Changeset in webkit [17208] by
-
- 4 edits in trunk/WebCore
- another try at fixing Qt
- CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
- and fix a couple warnings while I'm at it
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA): Don't do unsigned *= float.
- rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable inside #if so it's consistent.
Oct 21, 2006:
- 11:51 PM Changeset in webkit [17207] by
-
- 4 edits in trunk/WebCore
- fix the Qt build
- platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface):
- platform/qt/EditorClientQt.h:
- platform/qt/FrameQt.cpp:
- 11:39 PM Changeset in webkit [17206] by
-
- 21 edits in trunk
WebCore:
Reviewed by Adele.
- convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.
Did not yet rename the source files.
- WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
- WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
- platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
- loader/mac/WebLoader.h:
- loader/mac/WebLoader.mm:
- loader/mac/WebMainResourceLoader.h:
- loader/mac/WebMainResourceLoader.mm:
- loader/mac/WebNetscapePlugInStreamLoader.h:
- loader/mac/WebNetscapePlugInStreamLoader.mm:
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: Translate to C++.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
- loader/mac/WebFrameLoaderClient.h: Call the new C++ API.
WebKit:
Reviewed by Adele.
- convert WebLoader and its 3 subclasses to C++
- Plugins/WebNetscapePluginStream.h:
- Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
- 8:22 PM Changeset in webkit [22404] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
item, not just one line at a time
Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
in <select> control
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by translating into screen coordinates right away. (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify whether the text in the <select> control should be updated. (WebCore::PopupMenu::scrollTo): Extracted scrolling code from PopupWndProc to here. (WebCore::PopupMenu::scrollToRevealSelection): New method. (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of manually scrolling one line at a time. Fixed a bug in detecting a mouse drag. Pass in HDC from ::BeginPaint to PopupMenu::paint.
- 8:19 PM Changeset in webkit [17205] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
Popup tweaks.
- platform/PopupMenu.h:
- 8:10 PM Changeset in webkit [17204] by
-
- 2 edits in trunk/WebCore
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it.
- 7:59 PM Changeset in webkit [17203] by
-
- 2 edits in trunk/WebKitTools
- Scripts/commit-log-editor: Use baseProductDir() to find the base product directory. This was still using "symroots" so it almost never worked!
- 7:58 PM Changeset in webkit [17202] by
-
- 12 edits in trunk/WebCore
Reviewed by Anders.
- fix http://bugs.webkit.org/show_bug.cgi?id=11379 assertion failure seen in editing tests (in new DeleteButtonController)
I cleaned up the relationship between the Frame, Editor, EditorClient, and
DeleteButtonController a bit while also making the simple change to fix the
assertion failure.
- bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
- page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
- page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto.
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
- editing/DeleteButtonController.h:
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
- editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
- editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change.
- 7:38 PM Changeset in webkit [17201] by
-
- 3 edits in trunk/WebCore
2006-10-21 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary.
- 7:09 PM Changeset in webkit [22403] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to project.
- 6:55 PM Changeset in webkit [17200] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=11377 swap(Vector, Vector) should be O(1) instead of O(n)
- wtf/Vector.h: (WTF::VectorBuffer::swap): Added. (WTF::Vector::swap): Added. (WTF::swap): Added overload that takes two Vector objects.
- 6:52 PM Changeset in webkit [17199] by
-
- 3 edits in trunk/WebKit
Reviewed by Anders.
- fix http://bugs.webkit.org/show_bug.cgi?id=10328 REGRESSION: frame leak reported by buildbot
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Don't retain the web view. (WebEditorClient::~WebEditorClient): Don't release the web view. (WebEditorClient::setWebView): Ditto.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both init methods below. (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method. Also added comment pointing out design flaw -- we attach the client to the web view here, but we need to be sure to detach in case the web view is deallocated first. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
- 6:24 PM Changeset in webkit [17198] by
-
- 6 edits in trunk
Reviewed by Adam.
- http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors
- JavaScriptCore.xcodeproj/project.pbxproj: Pass -j
sysctl -n hw.ncputo make.
WebCore:
Reviewed by Adam.
- http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors
- WebCore.xcodeproj/project.pbxproj: Pass -j
sysctl -n hw.ncputo make.
WebKit:
Reviewed by Adam.
- http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors
- WebKit.xcodeproj/project.pbxproj: Pass -j
sysctl -n hw.ncputo make.
- 6:15 PM Changeset in webkit [17197] by
-
- 3 edits1 copy in trunk/WebKitTools
- Makefile: Build DumpRenderTree too.
- Scripts/do-webcore-rename: Removed bogus comment.
- 11:46 AM Changeset in webkit [22402] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Geoff.
Stub out the new shouldShowDeleteInterface method.
- WebEditorClient.cpp: (WebEditorClient::shouldShowDeleteInterface):
- WebEditorClient.h:
- 11:40 AM Changeset in webkit [17196] by
-
- 18 edits7 adds in trunk
WebCore:
Reviewed by Geoff.
<rdar://problem/4478625> HTML Editing: Basic table editing and culling
Initial implementaltion of table deletion user interface:
- Interface shows up on the nearest table containing the entire selection.
- Shows a Dashboard style close button in the top left corner.
- Shows a 60% opaque black outline around the table.
- Adds a new EditorClient function shouldShowDeleteInterface.
Also adds a new constructor CachedImage and setter functions on
HTMLImageElement and HTMLImageLoader allowing an Image object to be set
and image element in the page. This change also paves the way to allow an
NSImage setter on DOMHTMLImageElement.
- Resources/deleteButton.tiff: Added.
- Resources/deleteButtonPressed.tiff: Added.
- WebCore.xcodeproj/project.pbxproj:
- bridge/EditorClient.h:
- editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
- editing/DeleteButton.h: Added.
- editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
- editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target
- editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
- editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
- html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto
- html/HTMLImageLoader.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image
- loader/CachedImage.h: ditto
- page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
WebKit:
Reviewed by Geoff.
<rdar://problem/4478625> HTML Editing: Basic table editing and culling
Initial implementaltion of table deletion user interface:
- Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
- The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
- DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebEditingDelegatePrivate.h: Added.
- 11:37 AM Changeset in webkit [17195] by
-
- 4 edits in trunk/WebCore
Reviewed by Tim H.
Cleanup bindings generation a little through re-factoring
and general style cleanup.
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- 8:41 AM Changeset in webkit [17194] by
-
- 4 edits2 adds in trunk/WebCore
Reviewed by Mitz.
Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.
- CMakeLists.txt:
- platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange):
- platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt):
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
- platform/qt/FrameQt.h:
- 6:34 AM Changeset in webkit [17193] by
-
- 8 edits in trunk/WebCore
Reviewed by Tim H.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
Auto-generate a few more Objective-C DOM methods.
- Auto-generate getMatchedCSSRules and getComputedStyle methods.
- bindings/objc/DOMCSS.h:
- bindings/objc/DOMCSS.mm:
- bindings/objc/DOMExtensions.h:
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/Document.idl:
- page/DOMWindow.idl:
- 3:15 AM Changeset in webkit [17192] by
-
- 3 edits1 add in trunk/WebCore
2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by aliu, landed by aliu.
Fix Qt/Linux build.
- CMakeLists.txt:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
- platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep):
- 3:01 AM Changeset in webkit [17191] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
fix leaks.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView): only change webview if its different
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): actually use the client allocated in the line above instead of allocation again, duh.
- 2:12 AM Changeset in webkit [17190] by
-
- 2 edits in trunk/WebCore
2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Mitz, landed by ap.
Fix obscure crashes in RenderTableSection on Rob's musicdb file.
The problem was a missing layout() call on the frame view.
Thanks go to Mitz Pettel for the initial hint!
- platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent):
- 1:45 AM Changeset in webkit [17189] by
-
- 3 edits in trunk/WebKit
Build fix.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView):
Oct 20, 2006:
- 11:43 PM Changeset in webkit [17188] by
-
- 4 edits in trunk/WebKit
Reviewed by Tim Hatcher.
Fixed a problem where the webview passed to the EditorClient wasn't valid yet.
- WebCoreSupport/WebEditorClient.h: (WebEditorClient::setWebView): added webview setter
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): add default constructor
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): use [page webView] since _webview isn't valid yet (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): use webview setter on editorclient
- 11:37 PM Changeset in webkit [22401] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Fix build bustage and horrible memory leak.
- 11:20 PM Changeset in webkit [17187] by
-
- 2 edits in trunk/WebCore
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Anders.
Send User-Agent on requests.
Send custom request headers properly.
- platform/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
- 11:05 PM Changeset in webkit [22400] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Hyatt.
Make the auto-version script work with paths that contain spaces
- 9:57 PM Changeset in webkit [17186] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Fix some bad formatting.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
- 9:48 PM Changeset in webkit [22399] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp
Match the change I made on Mac in the public tree.
- 9:45 PM Changeset in webkit [22398] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Build fix.
- WebView.cpp: (webKitVersion):
- 9:45 PM Changeset in webkit [17185] by
-
- 2 edits in trunk/WebKit
Tweak cache sizes so that they are back to the way they were,
except for < 512, which will stay doubled.
Reviewed by Tim H.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
- 9:42 PM Changeset in webkit [17184] by
-
- 7 edits4 adds in trunk/WebKitTools
Reviewed by Tim H.
Bug 11367: Inline Breakpoint Editor Improvements: Act III
http://bugs.webkit.org/show_bug.cgi?id=11367
Major breakpoint editor changes:
- Breakpoints can now either pause or log to console
- Code cleanup through use of XPath and converting breakpoints to objects
- Breakpoints now track how many times they've been reached
- UI tweaks
- The breakpoint editor now saves changes as they're entered
- Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
- If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.
- Drosera/DebuggerDocument.m: (-[WebScriptObject breakpointEditorHTML]): A way of loading this from an external file, as it was getting too complex to include inline.
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/Images/close.tif: Added.
- Drosera/Images/close_active.tif: Added.
- Drosera/Images/close_hover.tif: Added.
- Drosera/breakpointEditor.html: Added.
- Drosera/console.js: Added a way to append messages from outside the console window.
- Drosera/debugger.js:
- Drosera/viewer.css:
- Drosera/viewer.html:
- 8:57 PM Changeset in webkit [22397] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Anders.
Turn on CFNetwork
- config.h:
- 8:55 PM Changeset in webkit [22396] by
-
- 12 edits3 adds1 delete in branches/WindowsMerge
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Ada.
<rdar://4778502> Boomer userAgent string needs to support pulling in proper build #, plus customization
Useragent/versioning changes
Stamp auto-generated version number into DLL and into user agent.
Generate a real user agent string instead of hardcoding one.
Support client supplying an application name for the user agent.
Support client overriding the useragent (for debug menu).
Support per-URL user agents (not used at least for now).
Also fixed a bug I recently introduced that broke form submit.
- 7:02 PM Changeset in webkit [17183] by
-
- 1 edit13 adds15 deletes in trunk/LayoutTests
RS by Beth "pants on fire" Dakin.
Put some layout tests in their place.
- fast/dom/Window/window-object-cross-frame-calls-expected.txt: Added.
- fast/dom/Window/window-object-cross-frame-calls.html: Added.
- fast/dom/Window/window-onFocus-expected.checksum: Added.
- fast/dom/Window/window-onFocus-expected.png: Added.
- fast/dom/Window/window-onFocus-expected.txt: Added.
- fast/dom/Window/window-onFocus.html: Added.
- fast/dom/Window/window-xy-properties-expected.txt: Added.
- fast/dom/Window/window-xy-properties.html: Added.
- fast/dom/window-object-cross-frame-calls-expected.txt: Removed.
- fast/dom/window-object-cross-frame-calls.html: Removed.
- fast/dom/window-onFocus-expected.checksum: Removed.
- fast/dom/window-onFocus-expected.png: Removed.
- fast/dom/window-onFocus-expected.txt: Removed.
- fast/dom/window-onFocus.html: Removed.
- fast/dom/window-xy-properties-expected.txt: Removed.
- fast/dom/window-xy-properties.html: Removed.
- fast/html/xhtml-serialize-expected.txt: Added.
- fast/html/xhtml-serialize.html: Added.
- fast/js/resources/xhtml-serialize.js: Removed.
- fast/js/resources/xslt-fragment-in-empty-doc.js: Removed.
- fast/js/xhtml-serialize-expected.txt: Removed.
- fast/js/xhtml-serialize.html: Removed.
- fast/js/xslt-fragment-in-empty-doc-expected.txt: Removed.
- fast/js/xslt-fragment-in-empty-doc.html: Removed.
- fast/xsl/xslt-fragment-in-empty-doc-expected.txt: Added.
- fast/xsl/xslt-fragment-in-empty-doc.html: Added.
- fast/dom/resources/child.html: Removed.
- fast/dom/Window/resources/child.html: Added.
- 6:34 PM Changeset in webkit [17182] by
-
- 9 edits in trunk/LayoutTests
Reviewed by Geoff.
Changing these counters tests because they fail on some people's
machines. They fail for people who have the Armenian glyphs the
tests were looking for in the "expected" line. There is no point in
testing that anyway, since we do not currently support Armenian in
counters or in list markers.
- fast/css/counters/counter10-expected.checksum:
- fast/css/counters/counter10-expected.png:
- fast/css/counters/counter10-expected.txt:
- fast/css/counters/counter10.html:
- fast/css/counters/counters10-expected.checksum:
- fast/css/counters/counters10-expected.png:
- fast/css/counters/counters10-expected.txt:
- fast/css/counters/counters10.html:
- 6:07 PM Changeset in webkit [17181] by
-
- 1 edit2 adds4 deletes in trunk/LayoutTests
Reviewed by Anders.
Removed old window property tests because they didn't quite work and they
were looking at me funny. Replaced with new, comprehensive test.
- fast/dom/Window/window-properties-expected.txt: Added.
- fast/dom/Window/window-properties.html: Added.
- fast/js/window-properties-expected.txt: Removed.
- fast/js/window-properties.html: Removed.
- fast/js/window-properties2-expected.txt: Removed.
- fast/js/window-properties2.html: Removed.
- 5:43 PM Changeset in webkit [17180] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
- loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key" as the key, not the dictionary itself.
- 4:57 PM Changeset in webkit [17179] by
-
- 13 edits7 adds in trunk
WebCore:
Reviewed by Maciej.
This is the initial foundation for the EditingController class and
everything else it needs to work. The idea is that the Frame has an
EditingController object that it calls to handle editing commands, the
most simple examples being copy/paste. This controller will handle
these editing commands in WebCore, and only hand off to WebKit to call
editing delegates (to the let the app intercept editing actions if it
wants to). Thus we need a platform-specific client to which the
EditingController hands off the delegate calls,
WebCoreEditingControllerClient. On the WebCore side this is an
abstract base class, and on the WebKit(Mac) side this is an ObjC++
subclass, WebEditingControllerClient. How does the EditingController
get a handle to its platform-specific client? In WebKit, the creator
of a platform-specific Frame creates the client (which is ref-counted)
and passes it down the chain of constructors until it gets back to the
EditingController, which then refs it in its constructor and derefs in
its destructor.
No Layout tests needed.
- WebCore.xcodeproj/project.pbxproj: Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
- bridge/EditorClient.h: Added. (WebCore::EditorClient::~EditorClient):
- bridge/mac/FrameMac.h: Added an EditingClient to the constructor, to pass down to Frame constructor
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Passed client down to Frame constructor
- bridge/mac/WebCoreFrameBridge.h: Added an EditingClient to the constructor, to pass down to FrameMac constructor
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Passed client down to FrameMac constructor
- editing/Editor.cpp: Added. Mostly stuf implementations of the following functions, except for a couple. These are all needed by cut, copy, paste, delete. (WebCore::generalPasteboard): (WebCore::Editor::canCopy): (WebCore::Editor::canCut): (WebCore::Editor::canDelete): (WebCore::Editor::canDeleteRange): (WebCore::Editor::canPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::isSelectionRichlyEditable): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste): (WebCore::Editor::performDelete):
- editing/Editor.h: Added.
- page/Frame.h: Added an EditingClient to the constructor, to pass down to Editor constructor
- page/Frame.cpp: (WebCore::Frame::Frame): Passed down to Editor constructor (WebCore::Frame::editor): Accessfor for Editor stored in FramePrivate
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added an Editor object to the FramePrivate data
- platform/Sound.h: Added. Made a platform-independent accessor to a beep function
- platform/mac/SoundMac.mm: Added. (WebCore::systemBeep): calls mac system beep
WebKit:
Reviewed by Maciej.
Adding knowledge of EditorClient to WebKit
- WebCoreSupport/WebEditorClient.h: Added.
- WebCoreSupport/WebEditorClient.mm: Added. (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): Implementation of mac EditorClient
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): create an editor client to pass down the chain of constructors
- WebKit.xcodeproj/project.pbxproj: Added related EditorClient files
- WebKitPrefix.h: Added tiger build flag in order to make certain private headers from webcore compile successfully
- 4:56 PM Changeset in webkit [22395] by
-
- 8 edits3 adds in branches/WindowsMerge
WebCoreWin:
Reviewed by Steve.
Adding knowledge of the Editor and EditorClient to Windows WebCore
No layout tests needed
- WebCore.vcproj/WebCore.vcproj: added Sound.h, SoundWin.cpp, EditorClient.h, Editor.h&.cpp
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): added client to constructor params
- bridge/win/FrameWin.h: added client to constructor params
- platform/win/SoundWin.cpp: Added. (WebCore::systemBeep): Calls windows system beep
WebKitWin:
Reviewed by Steve and Maciej.
Adding knowledge of the Editor and EditorClient to Windows WebKit
- Interfaces/IWebEditingDelegate.idl: needs IWebView.idl
- WebEditorClient.cpp: Added (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldBeginEditingInRange): (WebEditorClient::shouldEndEditingInRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidBeginEditing): (WebEditorClient::webViewDidChange): (WebEditorClient::webViewDidEndEditing): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection):
- WebEditorClient.h: Added.
- WebFrame.cpp: (WebFrame::initWithWebFrameView): created an editor client
- WebKit.vcproj/WebKit.vcproj: added WebEditorClient files
- 4:32 PM Changeset in webkit [17178] by
-
- 2 adds in trunk/LayoutTests/fast/forms
Add encoding layout test for forms.
- 4:13 PM Changeset in webkit [17177] by
-
- 3 edits in trunk/WebCore
Make sure to support the "encoding" property on form elements for
legacy compatibility.
Reviewed by darin/john
No test cases added. Not sure how to do a form submission of
various encodings as a layout test.
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::encoding): (WebCore::HTMLFormElement::setEncoding):
- html/HTMLFormElement.idl:
- 3:55 PM Changeset in webkit [17176] by
-
- 3 edits in trunk/WebCore
2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and by Anders.
Fix warnings in JS generation by killing the whole isRefPtr logic,
and just using WTF::getPtr as Sam Weinig suggested. Also kill some
places using get() where getPtr() is cleaner - not for m_impl.get().
- CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
- bindings/scripts/CodeGeneratorJS.pm:
- 3:21 PM Changeset in webkit [17175] by
-
- 21 edits in trunk
WebCore:
- rolled out my loader change; caused world leak and possibly a plug-in crash
WebKit:
- rolled out my loader change; caused world leak and possibly a plug-in crash
- 3:21 PM Changeset in webkit [17174] by
-
- 2 edits in trunk/WebCore
2006-10-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Tim H
- loader/mac/LoaderFunctionsMac.mm: Autorelease the header NSDictionary.
- 2:53 PM Changeset in webkit [17173] by
-
- 3 edits2 adds in trunk
WebCore:
2006-10-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
- bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Check if the timeout id is still in the table before trying to access it. If it isn't in the table it has been deleted inside of the execute method.
LayoutTests:
2006-10-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Goeff.
Add test case for timer crash.
- fast/dom/timer-clear-interval-in-handler-expected.txt: Added.
- fast/dom/timer-clear-interval-in-handler.html: Added.
- 2:05 PM Changeset in webkit [17172] by
-
- 2 edits in trunk/WebCore
2006-10-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin and Geoff.
Remove debugging output.
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
- 1:55 PM Changeset in webkit [17171] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/4792755> REGRESSON: Drag selecting is erratic
No test because it would require autoscrolling, which is not available to layout tests.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use hitTest() to find the correct node.
(WebCore::RenderLayer::hitTest):
Trivial source formatting.
- 1:07 PM Changeset in webkit [17170] by
-
- 2 edits in trunk/WebCore
2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).
- platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::add):
- 1:05 PM Changeset in webkit [17169] by
-
- 21 edits in trunk
WebCore:
Reviewed by Adele.
- convert WebLoader and its 3 subclasses to C++
Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.
Did not yet rename the source files.
- WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
- WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
- platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
- loader/mac/WebLoader.h:
- loader/mac/WebLoader.mm:
- loader/mac/WebMainResourceLoader.h:
- loader/mac/WebMainResourceLoader.mm:
- loader/mac/WebNetscapePlugInStreamLoader.h:
- loader/mac/WebNetscapePlugInStreamLoader.mm:
- loader/mac/WebSubresourceLoader.h:
- loader/mac/WebSubresourceLoader.mm: Translate to C++.
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
- loader/mac/WebFrameLoaderClient.h: Call the new C++ API.
WebKit:
Reviewed by Adele.
- convert WebLoader and its 3 subclasses to C++
- Plugins/WebNetscapePluginStream.h:
- Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
- 1:03 PM Changeset in webkit [17168] by
-
- 2 adds in trunk/WebKitQt/WebKitPart
Forgot to add these.
- 12:14 PM Changeset in webkit [17167] by
-
- 7 edits in trunk/WebKitQt
2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Adapt to FrameQtClient changes, and provide some kind of status
information to the KPart wheter we're loading or not (started/completed signaling).
- WebKitPart/CMakeLists.txt:
- WebKitPart/WebKitPart.cpp: (WebKitPart::WebKitPart): (WebKitPart::~WebKitPart): (WebKitPart::openUrl): (WebKitPart::initView):
- WebKitPart/WebKitPart.h:
- WebKitPart/WebKitPartBrowserExtension.cpp: Added. (WebKitPartBrowserExtension::WebKitPartBrowserExtension): (WebKitPartBrowserExtension::~WebKitPartBrowserExtension):
- WebKitPart/WebKitPartBrowserExtension.h: Added.
- WebKitPart/WebKitPartClient.cpp: (WebKitPartClient::WebKitPartClient): (WebKitPartClient::loadFinished):
- WebKitPart/WebKitPartClient.h:
- WebKitPart/WebKitPartInterface.h:
- 12:14 PM Changeset in webkit [17166] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Beth, approved in principle by Adele, who couldn't be troubled
for an actual review.
Fixed http://bugs.webkit.org/show_bug.cgi?id=11345
1 fewer shouldChangeSelection delegate call for fast/forms/focus-control-to-page
I updated this test to use <input type="search"> because that's the only
remaining AppKit control, and the test's intention is verify tabbing
between AppKit and non-AppKit controls.
I updated the results because the behavior change is good.
Here's why the test regressed:
Our editing code is cra-zay. When AppKit calls nextKeyView, we not only
calculate the next key element in the page, we also focus it as a side-effect.
As a result, we used to fire a focus delegate twice, because AppKit happened
to call nextKeyView twice.
This test first regressed when Adele changed listboxes to be non-AppKit
controls (r16718). That change took AppKit out of test.
The regression redoubled itself when Adam moved TAB handling into the DOM
(r16741), taking AppKit out of TABing completely.
- fast/forms/focus-control-to-page-expected.txt:
- fast/forms/focus-control-to-page.html:
- 12:14 PM Changeset in webkit [17165] by
-
- 11 edits in trunk/WebCore
2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Offer a way for WebKitPart to be able to detect when
the webpage has been completly loaded (including subresources).
Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.
- CMakeLists.txt:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::client):
- platform/qt/FrameQt.h:
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::checkLoaded): (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests): (WebCore::FrameQtClientDefault::receivedAllData):
- platform/qt/FrameQtClient.h:
- platform/qt/LoaderFunctionsQt.cpp: (WebCore::CheckCacheObjectStatus):
- platform/qt/PopupMenuQt.cpp:
- platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::add):
- platform/qt/ResourceLoaderManager.h:
- platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::start):
- 12:04 PM Changeset in webkit [17164] by
-
- 2 edits in trunk/WebCore
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Geoff.
Fix compiler warnings
- platform/ResourceLoaderClient.h:
- 11:27 AM Changeset in webkit [17163] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geof.
Changed test to make us pass Georgian case changing for Unicode 4.0 and 5.0. This incorporates changes from the 1.4 revision of the same mozilla test.
On Tiger we are still using Unicode 4.0 but on win and Leopard we are using Unicode 5.0, so this test currently allows for either answer.
- tests/mozilla/ecma/String/15.5.4.11-2.js:
- 10:58 AM Changeset in webkit [17162] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin
- fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, taking ~1% on the PLT test
- WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here because this is called too often.
- WebView/WebView.m: (-[WebView viewWillMoveToWindow:]): Do call them here, because this is guaranteed to be called at least once for each window containing a webview, but isn't called too often. Also restructured this method a little.
- 10:44 AM Changeset in webkit [17161] by
-
- 2 edits in S60/trunk/MemoryManager
2006-10-20 yongjzha <yongjun.zhang@nokia.com>
Reviewed by Sachin
DESC: WebKit Lite edition memory saving adjustment
http://bugs.webkit.org/show_bug.cgi?id=11369
- Src/fast_malloc.cpp:
- 9:51 AM Changeset in webkit [22394] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Implement (barely) more of DOMWindow.idl.
- Interfaces/DOMWindow.idl:
- 9:42 AM Changeset in webkit [22393] by
-
- 1 edit1 add in branches/WindowsMerge/WebKitWin
Reviewed by Darin.
Build fix.
Stubbing out DOMWindow.idl, which was forgotten in the last checkin.
- Interfaces/DOMWindow.idl: Added.
- 8:48 AM Changeset in webkit [17160] by
-
- 5 edits in trunk/WebCore
Reviewed by Mitz.
Win32 build fix and cleanup.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::submitForm):
- page/ResourceRequest.h: (WebCore::ResourceRequest::addHTTPHeaderField):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::Slider::~Slider): (WebCore::Slider::setMinValue): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): (WebCore::FrameWin::runJavaScriptPrompt): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::createFrame): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::createPlugin): (WebCore::FrameWin::objectContentType): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultLanguage): (WebCore::findWordBoundary): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::startHTTPRequest): (WebCore::TextField::TextField): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::hide):
- 8:44 AM Changeset in webkit [17159] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11303
Path::transform() should be implemented on Qt build
Use QPainterPath API to implement Path::transform.
This fixes svg/custom/clip-path-with-transform.svg on
the qt build.
- 3:29 AM Changeset in webkit [17158] by
-
- 9 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg clipping and painting classes.
- 2:48 AM Changeset in webkit [17157] by
-
- 3 edits in trunk/WebCore
Make sure to do the code that checks the repeatInterval before the timer has been
deleted. (Duh.)
Reviewed by andersca
- bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::setNestingLevel): (KJS::Window::timerFired): (KJS::DOMWindowTimer::fired):
- platform/Timer.h:
- 12:32 AM Changeset in webkit [22392] by
-
- 11 edits3 adds in branches/WindowsMerge
2006-10-19 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
<rdar://4771958> Holding down Ctrl when a redirect happens opens the redirected page in a new tab
Send triggering event to url selection.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
- bridge/win/FrameWin.h: Add triggeringEvent parameter
- platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Call GetKeyState instead of GetAsyncKeyState
- platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Call GetKeyState instead of GetAsyncKeyState
2006-10-19 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
<rdar://4771958>
Holding down Ctrl when a redirect happens opens the redirected page in a new tab
Also added a bunch of DOM bindings for events.
- DOMEventsClasses.cpp: Added.
- DOMEventsClasses.h: Added.
- Interfaces/DOMEvents.idl: Added.
- WebFrame.cpp: (WebFrame::loadData): Implemented (WebFrame::openURL): Added triggeringEvent parameter
- WebFrame.h: Added triggeringEvent parameter
- WebKit.vcproj/Interfaces.vcproj: Added DOMEvents.idl, DOMWindow.idl
- WebKit.vcproj/WebKit.vcproj: Added DOMEventsClasses.cpp, DOMEventsClasses.h
- WebKit.vcproj/WebKitGUID.vcproj: Added DOMEvents_i.c
- 12:25 AM Changeset in webkit [17156] by
-
- 3 edits in trunk/WebCore
Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
At that point clamp to 10ms to prevent excessive CPU usage.
Reviewed by anders
- bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::nestingLevel): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::DOMWindowTimer::fired):
- platform/Timer.h: (WebCore::TimerBase::startRepeating): (WebCore::TimerBase::startOneShot): (WebCore::TimerBase::repeatInterval): (WebCore::TimerBase::augmentRepeatInterval): (WebCore::TimerBase::inHeap): (WebCore::Timer::Timer): (WebCore::Timer::fired):
- 12:10 AM Changeset in webkit [17155] by
-
- 2 edits in trunk/WebCore
2006-10-20 Steve Falkenburg <sfalken@apple.com>
Build fix
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
- 12:01 AM Changeset in webkit [17154] by
-
- 10 edits in trunk/WebCore
2006-10-19 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Use GetKeyState rather than GetAsyncKeyState since we're
calling in these cases in direct response to an event, and want the
key state associated with that event.
Pass triggering event to url selection method.
- bridge/mac/FrameMac.h: Add triggeringEvent parameter
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
- bridge/win/FrameWin.h: Add triggeringEvent parameter
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
- page/Frame.cpp: (WebCore::Frame::changeLocation): Add 0 as triggeringEvent (WebCore::Frame::urlSelected): Pass through triggeringEvent
- page/Frame.h: Add triggeringEvent parameter to urlSelected methods
- platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
- platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState (WebCore::PlatformMouseEvent::PlatformMouseEvent):
Oct 19, 2006:
- 10:21 PM Changeset in webkit [22391] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp
Put in a missing else.
- 10:14 PM Changeset in webkit [17153] by
-
- 3 edits in trunk/WebCore
Correct typos from changing "flush" to "prune" using automated search/replace.
Change the cache heuristic for flushing to allow a higher watermark before initiating an
aggressive prune. This ensures that small cache sizes are no worse in terms of performance
than the old buggy cache.
Make sizes unsigned instead of ints in the cache's APIs and member variables.
- loader/Cache.cpp: (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize):
- loader/Cache.h: (WebCore::Cache::maximumSize):
- 9:24 PM Changeset in webkit [17152] by
-
- 9 edits in trunk/WebCore
2006-10-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Daddy Hyatt.
Use a real hash map for the headers.
- loader/LoaderFunctions.h:
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- platform/ResourceLoader.cpp: (WebCore::ResourceLoader::setRequestHeaders): (WebCore::ResourceLoader::requestHeaders):
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h:
- platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader):
- xml/xmlhttprequest.h:
- 8:23 PM Changeset in webkit [22390] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Add a forgotten Radar reference <rdar://problem/4786763>
- 8:05 PM Changeset in webkit [22389] by
-
- 4 edits in branches/WindowsMerge/WebCore
Reviewed by Ada.
This is a partial reimplementation of PopupMenu for Windows. The old
implementation used the Win32 ListBox control, but as we needed to
customize the behavior more and more it began to make sense to roll our
own popup from scratch. That is what this patch accomplishes. And...
Fix: <rdar://problem/4709416>
Implement mouse hot-tracking for <select> menus
(It was easier to implement this than to leave it broken.)
- WebCore.vcproj/WebCore.vcproj: Removed PopupMenu.cpp from project.
- platform/win/PopupMenuWin.cpp: Carnage. PopupMenu has gained a slew of new private instance variables to maintain the window state. m_container has been removed as it is no longer needed. (WebCore::PopupMenu::PopupMenu): Initialize new variables. (WebCore::PopupMenu::~PopupMenu): Clean up new variables. (WebCore::PopupMenu::show): Now that we don't have m_container, m_popup gets the WS_BORDER and WS_POPUP styles. Also moved code to animate the window out of the old PopupMenu::setPositionAndSize() into this method since it fits the purpose of this method better. (WebCore::PopupMenu::hide): (WebCore::PopupMenu::calculatePositionAndSize): Renamed from setPositionAndSize(), as this method no longer actually sets the window position and size, just calculates it. It also now makes sure the window is sized to never show partial items, and takes into account the window's border when calculating the size. (WebCore::PopupMenu::setFocusedIndex): New method to handle setting the selected index of the <select> and highlighting the item in the popup menu. (WebCore::PopupMenu::down): Use setSelectedIndex() to do the dirty work. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): New method to invalidate the rectangle in the popup menu for this item. (WebCore::PopupMenu::clientRect): New method to calculate an IntRect for the client area of the window. (WebCore::PopupMenu::incrementWheelDelta): New method to add the wheel delta obtained from a WM_MOUSEWHEEL message to any pre-existing delta. (WebCore::PopupMenu::reduceWheelDelta): New method to reduce the pre-existing wheel delta by a given amount towards 0. (WebCore::PopupMenu::paint): Does the work that PopupMenu::drawItem did, but for every item contained within the damageRect. Can also paint into a passed-in HDC (needed for window animations and smooth-scrolling). (WebCore::registerPopup): Changed a void* to a PopupMenu*, since that's what it really is. (WebCore::PopupWndProc): Added code to handle all the messages any self-respecting window would handle, and removed messages only relevant to the ListBox control.
- platform/win/TemporaryLinkStubs.cpp: Removed unneeded #include.
- 8:02 PM Changeset in webkit [17151] by
-
- 7 edits1 delete in trunk/WebCore
Reviewed by Ada.
Pippity-poppity popup tweaks.
- WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if requested and the new index is actually different than the old one.
- platform/IntPoint.h: Added another casting operator.
- platform/PopupMenu.cpp: Removed. The code in here, while platform-independent, was only useful for the NSPopUpButtonCell implementation of popup menus, so I've moved it to PopupMenuMac.mm.
- platform/PopupMenu.h: Moved the definition of PopupMenu::create into the header since it's fairly simple. Made some more methods private now that we don't have subclasses and virtual methods anymore. (WebCore::PopupMenu::create): (WebCore::PopupMenu::menuList): (WebCore::PopupMenu::itemHeight): (WebCore::PopupMenu::windowRect): (WebCore::PopupMenu::listIndexAtPoint): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setScrollOffset): (WebCore::PopupMenu::scrollOffset): (WebCore::PopupMenu::wheelDelta):
- platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp. (WebCore::PopupMenu::populate): Call our own clear() method to clear the menu.
- platform/win/IntPointWin.cpp: New casting operator. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINTS):
- 8:01 PM Changeset in webkit [22388] by
-
- 2 edits in branches/WindowsMerge/WebCore
WebCoreWin:
Rubberstamped by Maciej.
Build fix.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
- 8:00 PM Changeset in webkit [17150] by
-
- 4 edits in trunk/WebKit
Reviewed by Anders.
Bug 11366: Web Inspector should show user agent style rules
http://bugs.webkit.org/show_bug.cgi?id=11366
- WebInspector/WebInspector.m: (-init): (-showOptionsMenu): (-_toggleShowUserAgentStyles:):
- WebInspector/WebInspectorInternal.h:
- WebInspector/webInspector/inspector.js:
- 6:57 PM Changeset in webkit [17149] by
-
- 2 edits in trunk/WebKit
Build fix - 2gig is on that pesky signed/unsigned limit...
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
- 5:48 PM Changeset in webkit [22387] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Steve.
- speculative build fix for Windows for my recent changes.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
- 5:26 PM Changeset in webkit [17148] by
-
- 2 edits in trunk/WebKit
Reviewed by Hyatt.
Death to 16777216. Long live 33554432.
(Cache size changed needs to be reflected in localization file)
- English.lproj/StringsNotToBeLocalized.txt:
- 5:16 PM Changeset in webkit [17147] by
-
- 2 edits in trunk/WebKit
Reviewed by Hyatt
Added an larger in-memory level of cache for machines with 2+gb ram
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
- 5:16 PM Changeset in webkit [22386] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp
Add a new 8x multiplier on the memory cache for >2gb machines
- 5:08 PM Changeset in webkit [17146] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Cleaning up Document::nextFocusNode and Document::previousFocusNode.
- dom/Document.cpp: (WebCore::Document::nextFocusNode): (WebCore::Document::previousFocusNode):
- 5:07 PM Changeset in webkit [22385] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebPreferences.cpp
Double the WebCore cache size.
- 5:06 PM Changeset in webkit [17145] by
-
- 2 edits in trunk/WebKit
Reviewed by Hyatt
Double the default memory cache size
- WebView/WebPreferences.m: (+[WebPreferences initialize]):
- 5:00 PM Changeset in webkit [17144] by
-
- 17 edits in trunk/WebCore
Reviewed by Geoff.
- implement new ResourceRequest API and fix up code as appropriate
- bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
- dom/DOMImplementation.cpp: (WebCore::addString): (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
- dom/Document.h:
- editing/CommandByName.cpp:
- editing/JSEditor.cpp:
- page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
- page/Frame.h:
- page/FramePrivate.h:
- page/ResourceRequest.h: (WebCore::): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpContentType): (WebCore::ResourceRequest::setHTTPContentType): (WebCore::ResourceRequest::httpReferrer): (WebCore::ResourceRequest::setHTTPReferrer): (WebCore::ResourceRequest::httpUserAgent): (WebCore::ResourceRequest::setHTTPUserAgent): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::addHTTPHeaderField):
- platform/FontCache.cpp: (WebCore::computeHash):
- platform/StringHash.h: (WTF::):
- platform/StringImpl.cpp: (WebCore::equalIgnoringCase):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
- 4:21 PM Changeset in webkit [17143] by
-
- 17 edits in trunk
LayoutTests:
Reviewed by levi
<rdar://problem/4447885>
API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
Changed blockquotes in these tests to blockquote class="webkit-indent-blockquote".
- editing/execCommand/indent-empty-root-expected.txt:
- editing/execCommand/indent-selection-expected.checksum:
- editing/execCommand/indent-selection-expected.png:
- editing/execCommand/indent-selection-expected.txt:
- editing/execCommand/indent-selection.html:
- editing/execCommand/nsresponder-indent-expected.txt:
- editing/execCommand/nsresponder-outdent.html:
- editing/execCommand/outdent-selection-expected.checksum:
- editing/execCommand/outdent-selection-expected.png:
- editing/execCommand/outdent-selection-expected.txt:
Ditto. Added a FIXME:
- editing/execCommand/outdent-selection.html:
WebCore:
Reviewed by levi
<rdar://problem/4447885>
API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
Fixed indent/outdent to only increment the left margin, to match other browsers.
Used blockquote class="webkit-indent-blockquote" to do this. Mail can now
implement indent/outdent by customizing the appearance of these blockquotes,
instead of using a new API.
- css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
- editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Added. (WebCore::createIndentBlockquoteElement): Added. (WebCore::isIndentBlockquote): Added. (WebCore::isListOrBlockquote): Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed a bug in the code that added an extra br if the placeholder collapsed upon insertion. Used the new indentBlockquote checks and enclosing element getters. (WebCore::IndentOutdentCommand::indentRegion): Ditto. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto. Cleaned up the logic to pull the selection out of a list a bit.
- editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
- editing/htmlediting.h:
- 2:57 PM Changeset in webkit [17142] by
-
- 3 edits in trunk/WebKit
Reviewed by Kevin D and Geoff
- WebKit.xcodeproj/project.pbxproj: version wars
Cleaned up this file, as follows:
- renamed all file-internal methods to start with underscores
- moved all file-internal methods into a FileInternal category block, and alphabetized them
- grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
- removed unstylish braces around one-line clauses
- WebView/WebPDFView.m: (_applicationInfoForMIMEType): (_PDFSelectionsAreEqual): (+[WebPDFView supportedMIMETypes]): (-[WebPDFView setPDFDocument:]): (-[WebPDFView dealloc]): (-[WebPDFView centerSelectionInVisibleArea:]): (-[WebPDFView scrollPageDown:]): (-[WebPDFView scrollPageUp:]): (-[WebPDFView scrollLineDown:]): (-[WebPDFView scrollLineUp:]): (-[WebPDFView scrollToBeginningOfDocument:]): (-[WebPDFView scrollToEndOfDocument:]): (-[WebPDFView jumpToSelection:]): (-[WebPDFView acceptsFirstResponder]): (-[WebPDFView becomeFirstResponder]): (-[WebPDFView hitTest:]): (-[WebPDFView initWithFrame:]): (-[WebPDFView menuForEvent:]): (-[WebPDFView setNextKeyView:]): (-[WebPDFView viewDidMoveToWindow]): (-[WebPDFView viewWillMoveToWindow:]): (-[WebPDFView validateUserInterfaceItem:]): (-[WebPDFView copy:]): (-[WebPDFView takeFindStringFromSelection:]): (-[WebPDFView canPrintHeadersAndFooters]): (-[WebPDFView printOperationWithPrintInfo:]): (-[WebPDFView viewWillMoveToHostWindow:]): (-[WebPDFView viewDidMoveToHostWindow]): (-[WebPDFView elementAtPoint:]): (-[WebPDFView elementAtPoint:allowShadowContent:]): (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): (-[WebPDFView viewState]): (-[WebPDFView setViewState:]): (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (+[WebPDFView _PDFPreviewViewClass]): (+[WebPDFView _PDFViewClass]): (-[WebPDFView _anyPDFTagsFoundInMenu:]): (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _fakeKeyEventWithFunctionKey:]): (-[WebPDFView _menuItemsFromPDFKitForEvent:]): (-[WebPDFView _openWithFinder:]): (-[WebPDFView _path]): (-[WebPDFView _PDFSubview]): (-[WebPDFView _pointIsInSelection:]): (-[WebPDFView _receivedPDFKitLaunchNotification:]): (-[WebPDFView _scaledAttributedString:]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]): (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
- 1:42 PM Changeset in webkit [17141] by
-
- 3 edits in trunk/LayoutTests
Reviewed by ap.
Added a delay before printing the last line of text to ensure that the two
lines consistently decode as separate chunks.
- http/tests/incremental/slow-utf8-css.pl:
- http/tests/incremental/slow-utf8-css-expected.txt:
- 1:13 PM Changeset in webkit [17140] by
-
- 2 edits in trunk/WebCore
Rolling out the this change since it caused a bad regression:
<rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
2006-10-12 Adele Peterson <adele@apple.com>
Reviewed by Dave Harrison.
- Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
- rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.
- 11:44 AM Changeset in webkit [22384] by
-
- 4 edits in branches/WindowsMerge
WebCoreWin:
2006-10-19 Anders Carlsson <acarlsson@apple.com>
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): Build fix.
WebKitWin:
2006-10-19 Anders Carlsson <acarlsson@apple.com>
- WebFrame.cpp: (WebFrame::initWithWebFrameView): Build fix.
- 11:43 AM Changeset in webkit [17139] by
-
- 9 edits in trunk/WebKit
Reviewed by Kevin Decker
- fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
- WebKit.xcodeproj/project.pbxproj: version wars
- WebView/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): initialize document view with frame view's rect instead of empty rect. This avoids some problems when constructing view hierarchies from nibs
- WebView/WebPreferencesPrivate.h: declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
- WebView/WebPreferenceKeysPrivate.h: declare new preference key string
- WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize new preference to true (we will by default use the new view if it's available) (-[WebPreferences _usePDFPreviewView]): new accessor for new pref (-[WebPreferences _setUsePDFPreviewView:]): ditto
- WebView/WebPDFView.h: new previewView ivar
- WebView/WebPDFView.m: (+[WebPDFView PDFPreviewViewClass]): new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available (-[WebPDFView initWithFrame:]): now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back to old behavior otherwise (-[WebPDFView dealloc]): release new previewView ivar (retained in initWithFrame:) (-[WebPDFView viewWillMoveToWindow:]): stop observing PDFKit notification when we're removed from window (-[WebPDFView viewDidMoveToWindow]): start observing PDFKit notification when we're added to window (-[WebPDFView _receivedPDFKitLaunchNotification:]): respond to this new PDFKit notification by opening the document via NSWorkspace
- English.lproj/StringsNotToBeLocalized.txt: updated for lots of recent changes
- 11:07 AM Changeset in webkit [17138] by
-
- 8 edits in trunk/WebCore
2006-10-19 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Fix Qt/Linux build.
- CMakeLists.txt:
- loader/Cache.h:
- platform/qt/BrowserExtensionQt.cpp:
- platform/qt/BrowserExtensionQt.h:
- platform/qt/CursorQt.cpp: (WebCore::pointerCursor):
- platform/qt/LoaderFunctionsQt.cpp: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus):
- platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse):
- 10:09 AM Changeset in webkit [17137] by
-
- 6 edits in trunk
WebCore:
Reviewed by ap.
Win32 build fix.
- bridge/win/FrameWin.cpp:
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):
WebKit:
Reviewed by ap.
Win32 build fix.
- COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::createNewWindow):
- 9:41 AM Changeset in webkit [17136] by
-
- 4 edits9 adds in trunk
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11141
REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
to document URL. This matches WinIE and partially matches Firefox - although the latter
reports the href as if it were inherited, it still doesn't use it when resolving URIs in
@import rules.
Test: http/tests/uri/css-href.php
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
- ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
- 9:37 AM Changeset in webkit [17135] by
-
- 2 edits in trunk/WebKit
2006-10-19 Mitz Pettel <mitz@webkit.org>
Reviewed and landed by ap.
- fixed the inspector's tree popup
- WebInspector/webInspector/inspector.html:
- 9:15 AM Changeset in webkit [17134] by
-
- 2 edits in trunk/WebCore
2006-10-19 Anders Carlsson <acarlsson@apple.com>
- loader/Cache.cpp: Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems with case-sensitive file systems.
- 9:09 AM Changeset in webkit [17133] by
-
- 16 edits in trunk/WebCore
2006-10-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej, Brady.
Remove "charset" from the ResourceLoader metadata map and use
a getter function instead. Also, rename charset to encoding in a couple of places.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::setEncoding):
- loader/CachedCSSStyleSheet.h:
- loader/CachedResource.h: (WebCore::CachedResource::setEncoding):
- loader/CachedScript.cpp: (WebCore::CachedScript::setEncoding):
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::setEncoding):
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setEncoding):
- loader/CachedXSLStyleSheet.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- platform/ResourceLoader.cpp: (WebCore::ResourceLoader::responseEncoding): (WebCore::ResourceLoader::queryMetaData):
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData):
- 7:58 AM Changeset in webkit [17132] by
-
- 3 edits in trunk/LayoutTests
Updated this test to avoid machine-specific results.
- fast/js/window-properties2-expected.txt:
- fast/js/window-properties2.html:
- 2:21 AM Changeset in webkit [17131] by
-
- 29 edits in trunk/WebCore
Rewrite of the WebCore memory cache. The following changes have been made (along with many more):
(1) Referenced objects are now also cached.
(2) Pruning of the cache will occur once the cache is both full and in addition
more than half full with unreferenced objects.
(3) The prune is much more aggressive now, since referenced objects are counted when
pruning. The cache will therefore often prune out every unreferenced object if lots of
windows/tabs are open.
(4) Consolidated the request methods for various types of resources to go through a single
requestResource bottleneck function.
(5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
identical.
(6) Changed "object" to "resource" everywhere.
(7) The Cache is now an actual object, obtained via cache().
(8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
and enabled.
(9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
(10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
in the LRU lists). Also fixed a bug with the "-SP" part of the algorithm where the access count was
being incorrectly weighted too much due to a math error.
(11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
the size of referenced resources.
Reviewed by Maciej, bradee-oh
- bridge/mac/WebCoreCache.mm: (+[WebCoreCache statistics]): (+[WebCoreCache empty]): (+[WebCoreCache setDisabled:]):
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::image):
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
- loader/Cache.cpp: (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::resourceForURL): (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::addDocLoader): (WebCore::Cache::removeDocLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled):
- loader/Cache.h: (WebCore::LRUList::LRUList): (WebCore::Cache::loader): (WebCore::Cache::maximumSize): (WebCore::Cache::disabled): (WebCore::Cache::addToLiveObjectSize): (WebCore::Cache::removeFromLiveObjectSize): (WebCore::Cache::TypeStatistic::TypeStatistic):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::~CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::data):
- loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad):
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::finish): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired): (WebCore::CachedResource::setRequest): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setSize):
- loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::setCharset): (WebCore::CachedResource::url): (WebCore::CachedResource::type): (WebCore::CachedResource::referenced): (WebCore::CachedResource::count): (WebCore::CachedResource::status): (WebCore::CachedResource::size): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::setLoading): (WebCore::CachedResource::isImage): (WebCore::CachedResource::accessCount): (WebCore::CachedResource::increaseAccessCount): (WebCore::CachedResource::setInCache): (WebCore::CachedResource::inCache): (WebCore::CachedResource::cachePolicy): (WebCore::CachedResource::response): (WebCore::CachedResource::allData): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::schedule): (WebCore::CachedResource::accept): (WebCore::CachedResource::setAccept):
- loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
- loader/CachedXSLStyleSheet.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setAutoLoadImages): (WebCore::DocLoader::removeCachedResource):
- loader/DocLoader.h: (WebCore::DocLoader::cachedResource): (WebCore::DocLoader::allCachedResources): (WebCore::DocLoader::autoLoadImages): (WebCore::DocLoader::cachePolicy): (WebCore::DocLoader::expireDate): (WebCore::DocLoader::frame): (WebCore::DocLoader::doc): (WebCore::DocLoader::loadInProgress):
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
- loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::cancelRequests):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus):
- page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::setAutoLoadImages): (WebCore::Frame::autoLoadImages): (WebCore::Frame::begin): (WebCore::Frame::checkCompleted): (WebCore::Frame::reparseConfiguration):
- page/Frame.h:
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
Oct 18, 2006:
- 11:17 PM Changeset in webkit [17130] by
-
- 3 edits2 adds in trunk/LayoutTests
Test for some window properties that WebCore previously didn't enumerate.
- fast/js/window-properties2-expected.txt: Added.
- fast/js/window-properties2.html: Added.
- 10:09 PM Changeset in webkit [17129] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Tim H.
Improve the doubleclick behavior of breakpoints, and make breakpoints with no custom condition set appear blank instead of return [-1, 1] depending on enabled state.
- Drosera/DebuggerDocument.m: (-[WebScriptObject getDoubleClickMillis]): Add an ObjC wrapper for GetDblTime() so that JS can call it
- Drosera/Drosera.xcodeproj/project.pbxproj: link Carbon for GetDblTime()
- Drosera/debugger.js:
- 10:02 PM Changeset in webkit [17128] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Anders.
Bug 10851: Crash with Drosera
http://bugs.webkit.org/show_bug.cgi?id=10851
This crash results in an assert in debug builds.
assert(implementsCall());
The drosera_introspection propery was not callable. Now we just assign
this.drosera_introspection in the evaluateWebScript call.
This change also removes one DO message.
- Drosera/DebuggerDocument.m: (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):
- 7:42 PM Changeset in webkit [17127] by
-
- 26 edits in trunk
Reviewed by Geoff.
- remove vestiges of KXMLCore name (former name of WTF).
- wtf/Assertions.h:
- wtf/FastMalloc.h: (operator new): (operator delete): (operator new[]): (operator delete[]):
- wtf/FastMallocInternal.h:
- wtf/Forward.h:
- wtf/GetPtr.h:
- wtf/HashCountedSet.h:
- wtf/HashFunctions.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
- wtf/HashTable.h:
- wtf/HashTraits.h:
- wtf/ListRefPtr.h:
- wtf/MathExtras.h:
- wtf/Noncopyable.h:
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/Platform.h:
- wtf/RefPtr.h:
- wtf/StringExtras.h: (snprintf):
- wtf/UnusedParam.h:
- wtf/Vector.h:
- wtf/VectorTraits.h:
WebCore:
Reviewed by Geoff.
- remove vestiges of KXMLCore name (former name of WTF).
- config.h:
- 6:45 PM Changeset in webkit [22383] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Geoff.
- remove remnants of KXMLCore name.
- WebCore.vcproj/WebCore.vcproj:
- config.h:
- 6:43 PM Changeset in webkit [17126] by
-
- 6 edits in trunk
LayoutTests:
Reviewed by Beth.
Updated some results now that some global JS objects repeatably report their
statically declared properties.
- fast/js/window-properties-expected.txt:
- fast/js/window-properties.html:
WebCore:
Reviewed by Beth.
Some global JS objects lacked references to their property hashtables,
so for-in enumeration didn't work. I added the references, and then removed
a few bogus properties from the tables. The bogus ones got in there through
bit rot.
We should come up with some solution to these hand-written bindings bugs.
Maybe we could use a script to autogenerate them or something.
- bindings/js/kjs_window.cpp: (KJS::): (KJS::History::getValueProperty):
- 6:05 PM Changeset in webkit [17125] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Maciej.
Fix: http://bugs.webkit.org/show_bug.cgi?id=11342
fast/repaint/4774354 is failing
It seems that this test got checked in with incorrect results, as it
has been failing since its introduction in r17093.
- fast/repaint/4774354-expected.txt:
- 5:11 PM Changeset in webkit [17124] by
-
- 3 edits1 copy1 add in trunk
LayoutTests:
Reviewed by Brady.
New test to make sure we're generating the correct keycodes for Tab
and Shift-Tab keypresses.
- fast/events/js-keyboard-event-creation-expected.txt: Added.
- fast/events/js-keyboard-event-creation.html: Added.
WebCore:
Reviewed by Brady.
Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
U+000019 (Backtab). This matches our windowsKeyCode for this key
combination.
- platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
- 4:28 PM Changeset in webkit [17123] by
-
- 2 edits in trunk/WebCore
2006-10-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam, Brady.
Loader tweaks.
- platform/cf/ResourceLoaderCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::runLoaderThread): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
- 4:15 PM Changeset in webkit [17122] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Brady.
Fix: http://bugs.webkit.org/show_bug.cgi?id=11344
REGRESSION (r16741): webViewDidChangeSelection delegate not firing in
2 layout tests
The behavior for display-none-in-onchange-keyboard is still correct
(we don't crash when the element about to receive focus gets
display:none set), so I've just generated new results for it.
The behavior of tabbing-input-iframe has changed a little. iframe
elements are now in the tab order, so I've changed the test to take
that into account and generated new results.
- fast/forms/display-none-in-onchange-keyboard-expected.txt:
- fast/forms/tabbing-input-iframe-expected.txt:
- fast/forms/tabbing-input-iframe.html:
- 3:56 PM Changeset in webkit [17121] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
- Store the Mac popup button cell as a RetainPtr to prevent GC collection.
- Convert more ObjC local statics and member variables to use RetainPtr.
- Convert more CFRetain/CFRelease to HardRetain/HardRelease.
- bindings/objc/DOM.mm: (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
- bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease (WebCore::AXObjectCache::get): use HardRetain and not CFRetain (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
- bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
- bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
- platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
- platform/cf/RetainPtr.h: (WTF::::operator): implement a missing operator= template function
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): remove nil initialization (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup (WebCore::PopupMenu::populate): ditto (WebCore::PopupMenu::show): ditto (WebCore::PopupMenu::hide): ditto (WebCore::PopupMenu::addSeparator): ditto (WebCore::PopupMenu::addGroupLabel): ditto (WebCore::PopupMenu::addOption): ditto
- 3:52 PM Changeset in webkit [22382] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-18 Steve Falkenburg <sfalken@apple.com>
Fix build
- platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::historyURL): (BrowserExtensionWin::BrowserExtensionWin):
- 3:45 PM Changeset in webkit [17120] by
-
- 4 edits in trunk/WebCore
Reviewed by Adele.
Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
are tracking or menus are down (run loop modes)
I spent a few hours trying to write an automated test, but DRT doesn't
seem to support it. Manual tests attached to related bugs.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget):
- platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
- 2:58 PM Changeset in webkit [22381] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
Reviewed by Steve.
Any file that #includes WebView.h also needed to include
IWebURLResponse.h since IWebView.h needed it. Adding this
to the IDL file.
- Interfaces/IWebDataSource.idl: re-arranged imports because not all were being generated due to weird IDL file compiler bug
- Interfaces/IWebView.idl: added reference to IWebURLResponse.h
- WebFrame.cpp:
- WebKitClassFactory.cpp:
- WebView.cpp: removed reference to IWebURLResponse.h
- 2:30 PM Changeset in webkit [17119] by
-
- 2 edits in trunk/WebKitTools
2006-10-18 Mark Rowe <bdash@webkit.org>
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=11304
Bug 11304: Drosera fails to link as universal binary on PowerPC machine
- Drosera/Drosera.xcodeproj/project.pbxproj: Use -weak_framework to link against JavaScriptCore and WebCore directly when they are not part of the WebKit umbrella framework.
- 2:12 PM Changeset in webkit [17118] by
-
- 5 edits in trunk
WebCore:
Reviewed by Maciej.
More Win32 buildfix.
- bridge/win/FrameWin.h:
WebKit:
Reviewed by Maciej.
Win32 build fix.
- COM/WebFrame.cpp: (WebFrame::createNewWindow):
- COM/WebFrame.h:
- 1:51 PM Changeset in webkit [17117] by
-
- 2 edits in trunk/WebKit
2006-10-18 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11000
REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge determineObjectFromMIMEType:URL:]): Return ObjectElementFrame if the MIME type is one of the image ones we support.
- 1:17 PM Changeset in webkit [17116] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz
Win32 build fix.
- bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::BrowserExtensionWin): (WebCore::BrowserExtensionWin::createNewWindow):
- bridge/win/BrowserExtensionWin.h:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
- bridge/win/FrameWin.h:
- platform/win/CursorWin.cpp:
- platform/win/TemporaryLinkStubs.cpp: (Image::getHBITMAP):
- 12:35 PM Changeset in webkit [17115] by
-
- 2 edits in trunk/WebKitTools
fixo el buildo II: Release's Pride.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 12:27 PM Changeset in webkit [17114] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4784823>
GMail Editor: Hang occurs when removing list styling on text in a rich text message
- editing/execCommand/remove-list-1-expected.checksum: Added.
- editing/execCommand/remove-list-1-expected.png: Added.
- editing/execCommand/remove-list-1-expected.txt: Added.
- editing/execCommand/remove-list-1.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4784823>
GMail Editor: Hang occurs when removing list styling on text in a rich text message
List removal moves the contents of every list item out of the list it's
in. When the code tried to move the contents of an empty list item (an li
with no child nodes, not even a placeholder br), moveParagraph didn't prune
the li, like it would if the li had a placeholder inside it. So the list
removal code went into an infinite loop, continually attempting to de-list
an empty list item.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If the selection to move was empty and in an empty block that doesn't require a placeholder to prop itself open (like a bordered div or an li), remove it during the move.
- 12:22 PM Changeset in webkit [17113] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4765600>
REGRESSION: Mail.app: smart deletion of words does not work
- editing/deleting/smart-delete-003-expected.checksum: Added.
- editing/deleting/smart-delete-003-expected.png: Added.
- editing/deleting/smart-delete-003-expected.txt: Added.
- editing/deleting/smart-delete-003.html: Added.
- editing/deleting/smart-delete-004-expected.checksum: Added.
- editing/deleting/smart-delete-004-expected.png: Added.
- editing/deleting/smart-delete-004-expected.txt: Added.
- editing/deleting/smart-delete-004.html: Added.
WebKit:
Reviewed by harrison
<rdar://problem/4765600>
REGRESSION: Mail.app: smart deletion of words does not work
Regressed when we pushed selecion expansion down into WebCore. It's OK
to try a smart delete from _deleteWithDirection:, which is called by
deleteFoward: and deleteBackward: if the current selection is a
range.
- WebView/WebHTMLView.m: (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
- 11:59 AM Changeset in webkit [17112] by
-
- 2 edits in trunk/WebKitTools
fixo el buildo.
Work around #import of <PDFKit/PDFView.h>.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 11:47 AM Changeset in webkit [17111] by
-
- 2 edits in trunk/WebCore
Reviewed by Beth.
- Fixed http://bugs.webkit.org/show_bug.cgi?id=11343 REGRESSION (r16975): fast/events/objc-event-api is failing
When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
a call to invalidateClick. This change moves it back to the sequence that existed before. This allows
the click count to get properly reset during a selection.
- page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
- 11:16 AM Changeset in webkit [22380] by
-
- 29 edits1 delete in branches/WindowsMerge/WebKitWin
2006-10-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Lou.
<rdar://4781998> Need API for setting the rendering modes
Added font smoothing preference
Fixed some COM interface typos
Removed use of IWebImage (we use HBITMAP instead)
- 10:54 AM Changeset in webkit [17110] by
-
- 2 edits in S60/branches/3.1m/WebKit
2006-10-18 zhalu <zhaosong.lu@nokia.com>
Reviewed by Sachin Padma.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is
enabled, the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed. The function
calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in CAknFepManager.
If users press the key in a normal speed, there is no problem because there is nothing for committing.
But if users press two keys(not two letters on the same key) very quickly, the second key will be commited
by the SetFocus() of the first key and the cursor in the editbox will move to the third key position.
The result is that it seems not letting you insert some key in the second position.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11192
- BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):
- 10:42 AM Changeset in webkit [17109] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Removing SVGZoomEvent.idl from Copy Resources.
- 10:37 AM Changeset in webkit [17108] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Adjust include paths
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 9:29 AM Changeset in webkit [17107] by
-
- 4 edits1 add3 deletes in trunk/WebKitTools
Reviewed by Tim H.
Add Xcode 3 style inline breakpoint editor. Credit to xenon for the CSS wizardry to get the appearance working properly.
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/Images/breakpointeditor.png: Added.
- Drosera/breakpointEditor.css: Removed.
- Drosera/breakpointEditor.html: Removed.
- Drosera/breakpointEditor.js: Removed.
- Drosera/debugger.js:
- Drosera/viewer.css:
- 8:25 AM Changeset in webkit [17106] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Tim H.
Bug 11341: REGRESSION (r16760): editing/selection/editable-links is failing
http://bugs.webkit.org/show_bug.cgi?id=11341
Link editing behavior became a preference. DumpRenderTree needs to specify the
non-default behavior it wants (WebKitEditableLinkOnlyLiveWithShiftKey).
- DumpRenderTree/DumpRenderTree.m: (main):
- 12:45 AM Changeset in webkit [17105] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Maciej.
Fix: http://bugs.webkit.org/show_bug.cgi?id=11340
editing/pasteboard/4641033 needs new results
Update results after r17071.
- editing/pasteboard/4641033-expected.txt:
Oct 17, 2006:
- 11:04 PM Changeset in webkit [17104] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
Factored common scaling code into a helper function.
- platform/mac/ScreenMac.mm: (WebCore::scale): (WebCore::scaleScreenRectToPageCoordinates): (WebCore::scalePageRectToScreenCoordinates):
- 10:52 PM Changeset in webkit [22379] by
-
- 11 edits in branches/WindowsMerge
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by ggaren.
<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by ggaren.
<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title
- Interfaces/IWebHistoryItemPrivate.idl: added setTitle to set title for a page after we receive it
- WebFrame.cpp: Removed unnecessary WebFramePrivate::title (WebFrame::goToItem): Get back/forward list via frame-aware getter (WebFrame::receivedRedirect): Use BString (WebFrame::receivedResponse): Use BString. Get back/forward list, history via frame-aware getters. (WebFrame::createFrame): Use BString (WebFrame::submitForm): Clean up up BSTR usage (WebFrame::setTitle): Set title in back/forward, history when received (WebFrame::backForwardList): Frame-aware getter for back/forward (WebFrame::webHistory): Frame-aware getter for history
- WebFrame.h: Added frame-aware getters for history, back/forward
- WebHistory.cpp: Reorder includes. (WebHistory::QueryInterface): Support QI to WebHistory via CLSID (avoids yucky static cast in other places)
- WebHistoryItem.cpp: (WebHistoryItem::setTitle): Added
- WebHistoryItem.h: Added setTitle
- WebView.cpp: (WebView::QueryInterface): Support QI to WebView via CLSID
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Build fix
- platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow):
- 10:46 PM Changeset in webkit [17103] by
-
- 9 edits in trunk/WebCore
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Build fixes
- bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
- bridge/win/BrowserExtensionWin.h:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
- bridge/win/FrameWin.h:
- platform/gdk/BrowserExtensionGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow):
- platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
- platform/qt/BrowserExtensionQt.h:
- 10:16 PM Changeset in webkit [22378] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
Added WindowFeatures.h to the project.
- WebCore.vcproj/WebCore.vcproj:
- 10:13 PM Changeset in webkit [17102] by
-
- 7 edits1 copy in trunk/WebCore
Reviewed by Anders.
Renamed WindowArgs to WindowFeatures, and moved it into its own header.
("Features" is the term of art in IE documentation. "Args" is pirate
talk.)
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
- bridge/BrowserExtension.h:
- bridge/WindowFeatures.h: Added.
- bridge/mac/BrowserExtensionMac.h:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- 9:16 PM Changeset in webkit [22377] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj
- 9:15 PM Changeset in webkit [22376] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
Turn off a very noisy warning (unknown pragma) caused by an Interfacer include
- WebCore.vcproj/WebCore.vcproj:
- 9:09 PM Changeset in webkit [17101] by
-
- 2 edits in trunk/JavaScriptCore
2006-10-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
Adjust include paths
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 8:04 PM Changeset in webkit [17100] by
-
- 18 edits8 copies1 move1 delete in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
- Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
- Moves the contents of ksvg/bindings/js/ to bindings/js/.
- Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
- Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching the other CSSValue classing, and allowing the bindings to allocate appropriately.
- Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing generation for Objective-C.
- Assorted style cleanups.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
- bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
- bindings/objc/DOMSVG.h:
- bindings/objc/DOMSVGNumber.mm: (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
- bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
- bindings/objc/DOMSVGRect.mm: (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
- bindings/scripts/CodeGeneratorObjC.pm:
- css/StyleBase.h: (WebCore::StyleBase::isSVGColor): (WebCore::StyleBase::isSVGPaint):
- ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
- ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
- ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
- ksvg2/bindings/js/JSSVGNumber.h: Removed.
- ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
- ksvg2/bindings/js/JSSVGPoint.h: Removed.
- ksvg2/bindings/js/JSSVGRect.cpp: Removed.
- ksvg2/bindings/js/JSSVGRect.h: Removed.
- ksvg2/svg/SVGColor.h: (WebCore::SVGColor::isSVGColor):
- ksvg2/svg/SVGFECompositeElement.idl:
- ksvg2/svg/SVGFEFloodElement.idl:
- ksvg2/svg/SVGLocatable.idl:
- ksvg2/svg/SVGMarkerElement.idl:
- ksvg2/svg/SVGPaint.h: (WebCore::SVGPaint::isSVGPaint):
- ksvg2/svg/SVGRectElement.idl:
- ksvg2/svg/SVGZoomEvent.idl: Removed.
- 7:12 PM Changeset in webkit [17099] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix changelog file list. It wasn't right.
- 7:10 PM Changeset in webkit [17098] by
-
- 5 edits in trunk/WebCore
Prepare for the elimination of the RenderLayer for <html> elements. The layer is still present,
but this patch makes everything work without a root layer being around.
Reviewed by beth
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp: Removed.
- platform/KURL.h: Removed.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderLayer.cpp: (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::intersectsDamageRect):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setInnerNode):
- rendering/RenderView.cpp: (WebCore::RenderView::paint):
- 6:56 PM Changeset in webkit [17097] by
-
- 15 edits in trunk/WebCore
Back out my previous patch to the WebCore memory cache.
- loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::deref):
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::deref):
- loader/CachedImage.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
- loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
- loader/CachedScript.cpp: (WebCore::CachedScript::deref):
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::deref):
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::deref):
- loader/CachedXSLStyleSheet.h:
- 6:31 PM Changeset in webkit [17096] by
-
- 2 edits in trunk/WebCore
2006-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Anders.
Make north and east resize cursors use correct image
- platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor):
- 5:39 PM Changeset in webkit [22375] by
-
- 6 edits in branches/WindowsMerge
2006-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Brady.
Fixed alpha in favicons, added composite operation conversion
for cg
rdar://problem/4758934
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::setCompositeOperation):
- platform/win/ImageWin.cpp: (WebCore::Image::getHBITMAP):
- platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspelling):
Fix flickering cursor
- WebView.cpp: (registerWebViewWindowClass):
- 5:30 PM Changeset in webkit [17095] by
-
- 5 edits in trunk/WebCore
2006-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Brady
Various cursor fixes
- page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent):
- platform/Cursor.h:
- platform/mac/CursorMac.mm: (WebCore::pointerCursor):
- platform/win/CursorWin.cpp: (WebCore::supportsAlphaCursors): (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::pointerCursor):
- 5:28 PM Changeset in webkit [17094] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused
- editing/selection/4776665-expected.checksum: Added.
- editing/selection/4776665-expected.png: Added.
- editing/selection/4776665-expected.txt: Added.
- editing/selection/4776665.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused
- page/Frame.cpp: (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error (like when the frame that contains the caret isn't focused) then we don't want to paint the caret. We should eventually move to using a single bool for caret painting.
- 4:52 PM Changeset in webkit [17093] by
-
- 3 edits5 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
- fast/repaint/4774354-expected.checksum: Added.
- fast/repaint/4774354-expected.png: Added.
- fast/repaint/4774354-expected.txt: Added.
- fast/repaint/4774354.html: Added.
- fast/repaint/resources/contenteditable-iframe-src.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
Functions call recomputCaretRect to see if the caret rect has changed,
and, if it has, they invalidate (repaint) it. recomputeCaretRect was
returning false if the caret turned into a range selection or was blown
away.
- editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Don't early return if !isCaret(). Obtain the FrameView* using the m_frame pointer, because m_sel may now be null.
- 4:37 PM Changeset in webkit [17092] by
-
- 10 edits in trunk/WebCore
Reviewed by Brady.
BrowserExtension cleanup.
- Removed unnecessary #include of BrowserExtension in Frame.h, added #includes to compensate in other files.
- Removed unused versions of createNewWindow.
- bindings/js/kjs_window.cpp:
- bridge/BrowserExtension.h:
- bridge/mac/BrowserExtensionMac.h:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/WebCoreFrameBridge.mm:
- html/HTMLFormElement.cpp:
- loader/mac/LoaderFunctionsMac.mm:
- page/Frame.h:
- page/FramePrivate.h:
- 2:46 PM Changeset in webkit [17091] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Brady.
Fixes a JavaScriptCore math issue on win.
- kjs/math_object.cpp: (MathFuncImp::callAsFunction):
- wtf/MathExtras.h: (wtf_atan2):
- 2:20 PM Changeset in webkit [22374] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
Added HTMLFrameElementBase to the project.
- WebCore.vcproj/WebCore.vcproj:
- 2:17 PM Changeset in webkit [17090] by
-
- 9 edits2 copies in trunk/WebCore
Reviewed by Adam.
- Fixed "FIXME: Violates Liskov Substitution principle."
IFRAME was never a true subclass of FRAME, since they disagreed on a
number of behaviors, which, confusingly, IFRAME just overrode and contradicted.
The fix here is to factor out things common to IFRAME and FRAME into a
common base class, HTMLFrameElementBase.
I also changed some " *" to "* " and added #includes in files that implicitly
assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
- 12:47 PM Changeset in webkit [17089] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by sullivan
<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
- fast/repaint/4776765-expected.checksum: Added.
- fast/repaint/4776765-expected.png: Added.
- fast/repaint/4776765-expected.txt: Added.
- fast/repaint/4776765.html: Added.
WebCore:
Reviewed by sullivan
<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
We set m_needsLayout to false and call caretRect() in the hopes that it will give us
the old caret rect. It in fact corrects the caret rect for an offset that it
believes is due to scrolling but which is actually due to a change in selection
without an accompanying layout. So it returns the new caret rect regardless of
what m_needsLayout is set to.
- editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that adds a one pixel slop to this new function. (WebCore::SelectionController::caretRepaintRect): Moved this code to repaintRectForCaret. (WebCore::SelectionController::recomputeCaretRect): Compare the old caret rect to the new one that's computed with a fresh layout. If they are different, invalidate both repaint rects.
- 12:11 PM Changeset in webkit [17088] by
-
- 1 copy in tags/WebKit-312.8.1/WebKit
Tag for WebKit 312.8.1 (part 2 of 2.)
- 12:11 PM Changeset in webkit [17087] by
-
- 1 add in tags/WebKit-312.8.1
Tag for WebKit 312.8.1 (part 1 of 2.)
- 12:11 PM Changeset in webkit [17086] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
Versioning to 312.8.1
- 12:08 PM Changeset in webkit [17085] by
-
- 3 edits in branches/Safari-1-3-branch/WebKit
Merged fix from Safari-2-0-branch to Safari-1-3-branch
2006-09-07 Beth Dakin <Beth Dakin>
Reviewed by Darin sort of and Maciej definitely.
Fix for <rdar://problem/4719149> Crash caused by malformed frame
setup. This is the same bug as 3853672, which has been fixed on TOT
for a while. We feel like this fix is much safer for the branch
though.
- WebKit.xcodeproj/project.pbxproj: Version wars.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[NSURLProtocol releaseResources]): Added comment for assertion that will be hit. (-[NSURLProtocol didFailWithError:]): Added comment for assertion that will be hit.
- WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Retain and release all of the pieces involved with sending the error.
- 12:06 PM Changeset in webkit [17084] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Tim Hatcher.
When nodes are removed, selections are cleared, and when http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications. Updating the test results fixes some of the tests mentioned in http://bugs.webkit.org/show_bug.cgi?id=10924
- fast/dynamic/move-node-with-selection-expected.txt:
- fast/events/dblclick-addEventListener-expected.txt:
- fast/events/updateLayoutForHitTest-expected.txt:
- 11:58 AM Changeset in webkit [22373] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Geoff.
A couple of cleanups that Geoff suggested after my last checkin.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):
- 11:47 AM Changeset in webkit [22372] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Fix: <rdar://problem/4772506> <select> popup menu should not clip items
when width: is set.
Popups are now sized and positioned as follows:
- Popups are at least as wide as the <select> control on the page.
- Popups for LTR <select>s are right-aligned with the <select>, popups for RTL <select>s are left-aligned. This means the scrollbar in the popup will always line up with the dropdown button in the <select>.
- Popups try to be wide enough to fit their widest item, but will shrink to ensure they don't extend off the screen.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):
- 11:07 AM Changeset in webkit [17083] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
<rdar://problem/4770453> VO not honoring secure edit fields in web pages
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isPasswordField]): New. Checks for input with inputType() of PASSWORD.
(-[WebCoreAXObject subrole]):
Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
(-[WebCoreAXObject roleDescription]):
Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
(-[WebCoreAXObject value]):
Return nil if [self isPasswordField].
(-[WebCoreAXObject accessibilityAttributeNames]):
Return generic attributes if [self isPasswordField].
(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Return empty array if [self isPasswordField].
- 9:51 AM Changeset in webkit [17082] by
-
- 1 copy in tags/WebKit-418.9.1/WebKit
Tag for WebKit 418.9.1 (part 2 of 2.)
- 9:50 AM Changeset in webkit [17081] by
-
- 1 add in tags/WebKit-418.9.1
Tag for WebKit 418.9.1 (part 1 of 2.)
- 9:49 AM Changeset in webkit [17080] by
-
- 3 edits in trunk/LayoutTests
Reviewed by aroben.
updating test results after r17068 - http://bugs.webkit.org/show_bug.cgi?id=11320
- fast/block/float/013-expected.checksum:
- fast/block/float/013-expected.txt:
- 9:42 AM Changeset in webkit [17079] by
-
- 2 edits in branches/Safari-2-0-branch/WebKit
Versioning to 418.9.1
- 9:36 AM Changeset in webkit [17078] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adele.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11214
http/tests/xmlhttprequest/exceptions.html needs new results
Updating results after r16794.
- http/tests/xmlhttprequest/exceptions-expected.txt:
- http/tests/xmlhttprequest/exceptions.html: Add comments about why we don't follow the XHR spec.
- 7:59 AM Changeset in webkit [17077] by
-
- 2 edits in S60/trunk/S60Internals
2006-10-13 brmorris <thisisbradley@gmail.com>
Reviewed by me.
DESC: Updated RVCT supporting libs.
http://bugs.webkit.org/show_bug.cgi?id=9435
- target/RVCT/S60LibsRVCT.zip: Toolbar.dll & recentstore.dll
- 1:52 AM Changeset in webkit [17076] by
-
- 2 edits in trunk/WebCore
Fix "flash to white' problem on yahoo.com as it finishes loading. Refine the FOUC suppression
code so that it will only run if the body still has no renderer.
- dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets):
- 12:32 AM Changeset in webkit [17075] by
-
- 15 edits in trunk/WebCore
Fix a bug where the WebCore memory cache could grow without bound during extended browsing
sessions.
Reviewed by mjs
- loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp:
- loader/CachedImage.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
- loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
- loader/CachedScript.cpp:
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp:
- loader/CachedXSLStyleSheet.h:
Oct 16, 2006:
- 5:51 PM Changeset in webkit [22371] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Kevin.
Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
aligned on right-to-left sites
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx so that we get a left-aligned scrollbar in RTL popups. (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw RTL when direction:rtl is set. (WebCore::PopupWndProc): Add 1px of vertical height to each menu item to match RenderListBox.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on the left when in RTL. (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow for the dropdown button being on the left in RTL.
- 5:48 PM Changeset in webkit [17074] by
-
- 8 edits8 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/3655385>
Editing: -indent: method unimplemented
- editing/execCommand/nsresponder-indent-expected.checksum: Added.
- editing/execCommand/nsresponder-indent-expected.png: Added.
- editing/execCommand/nsresponder-indent-expected.txt: Added.
- editing/execCommand/nsresponder-indent.html: Added.
- editing/execCommand/nsresponder-outdent-expected.checksum: Added.
- editing/execCommand/nsresponder-outdent-expected.png: Added.
- editing/execCommand/nsresponder-outdent-expected.txt: Added.
- editing/execCommand/nsresponder-outdent.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/3655385>
Editing: -indent: method unimplemented
Added Frame and bridge methods.
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]):
- page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent):
- page/Frame.h:
WebKit:
Reviewed by harrison
<rdar://problem/3655385>
Editing: -indent: method unimplemented
- WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in richly editable areas. (-[NSArray indent:]): (-[NSArray outdent:]):
- 5:35 PM Changeset in webkit [17073] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geof.
Removed unecessary global specifiers.
- kjs/math_object.cpp: (MathFuncImp::callAsFunction):
- 5:10 PM Changeset in webkit [22370] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
- 4:12 PM Changeset in webkit [17072] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by John.
Fixes a compile order issue for testkjs on win.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
- 2:57 PM Changeset in webkit [22369] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Added forgotten <rdar://problem/4710456> reference to old entry.
- 2:54 PM Changeset in webkit [22368] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by John.
Forgot to save these changes John suggested before checking in.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::drawItem):
- 2:52 PM Changeset in webkit [22367] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by John.
Fix: <rdar://problem/4709480> Implement option groups
Fix: <rdar://problem/4785693> Use CG to draw popup menu items
Fix: <rdar://problem/4709487> Implement separators in <select> popups
Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor
- platform/win/PopupMenuWin.cpp: Added some now-required #includes, moved some constants into the WebCore namespace. (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show(). (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx to assume responsibility for drawing menu itesm. Removed call to set the font on the popup menu, as CG will take care of this. (WebCore::addString): Added to help with the PopupMenu::add* methods. (WebCore::PopupMenu::addOption): Use addString. (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp. (WebCore::PopupMenu::addSeparator): Ditto. (WebCore::PopupMenu::down): Skip items that are not enabled <option> elements, and tell the popup menu to set the selection to the element we end up on. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::drawItem): Added. This is the method that is called to draw each item in the menu. (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM messages (required now that we're drawing the menu items ourselves). In the cases for arrow key presses, return -2 to signify that we're handling all aspects of changing the selection.
- platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator and PopupMenu::addGroupLabel.
- 2:44 PM Changeset in webkit [17071] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
More menulist cleanup/tweaking.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled <option> elements when using arrow keys, and make sure we pass an option index to setSelectedIndex.
- platform/PopupMenu.h: (WebCore::PopupMenu::setWasClicked): Specify default argument.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from option text before setting the control text so that options within <optgroup>s don't appear indented in the actual control.
- 1:52 PM Changeset in webkit [17070] by
-
- 9 edits in trunk/WebCore
Reviewed by Adam.
Win32 build fix.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
- bridge/win/FrameWin.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData):
- rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):
- 11:17 AM Changeset in webkit [17069] by
-
- 2 edits in S60/trunk/WebCore
2006-10-16 brmorris <thisisbradley@gmail.com>
Reviewed by Zalan.
DESC: Fix build break in render_frames.cpp caused by r17066
- kwq/KWQWidget.h: (QWidget::focusable): Is available when not RD_32_BROWSER
- 1:29 AM Changeset in webkit [17068] by
-
- 4 edits in trunk/WebCore
Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
element is the initial containing block (our RenderView).
Reviewed by mjs
Test cases added to fast/block/positioning for quirks and strict modes.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical):
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
- 1:27 AM Changeset in webkit [17067] by
-
- 8 adds in trunk/LayoutTests/fast/block/positioning
Add test cases for bug 9347.
Oct 15, 2006:
- 7:00 PM Changeset in webkit [17066] by
-
- 7 edits in S60/trunk/WebCore
2006-10-13 sareen <shyam.sareen@nokia.com>
Reviewed by bujtas <zbujtas@gmail.com>
DESC: New Enum need to add for finding the whether the plugin
is interactive or not.
WARNING: NO TEST CASES ADDED OR CHANGED
- bridge/WebCoreWidget.h:
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::isFocusable):
- khtml/rendering/render_frames.cpp:
- khtml/rendering/render_frames.h:
- kwq/KWQObjectWidget.cpp:
- kwq/KWQObjectWidget.h:
- 6:33 PM Changeset in webkit [17065] by
-
- 16 edits in trunk
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Remove junk (as gcc calls it) after #else clause.
- wtf/FastMalloc.cpp: (WTF::do_free):
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Misc Gdk/Linux build fixes.
- platform/gdk/BrowserExtensionGdk.h:
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
- platform/gdk/FrameGdk.h:
- platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
- platform/gdk/RenderPopupMenuGdk.h:
- platform/gdk/RenderThemeGdk.cpp:
- platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk):
- platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Make compiler not complain about unused gk. SpinneretWebHost was not setting
initial refcount upon creation, so it is completely bogus.
- GdkLauncher/main.cpp: (main):
- Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::SpinneretWebHost):
- 3:22 PM Changeset in webkit [17064] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
Add getModifierState method to KeyboardEvent
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMEvents.mm:
- bindings/objc/PublicDOMInterfaces.h:
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState):
- dom/KeyboardEvent.h:
- dom/KeyboardEvent.idl:
- 2:44 PM Changeset in webkit [22366] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Geoff, Anders.
Fix crash on startup.
We were crashing somewhere inside Frame::setResourceRequest. I'm not
sure what change made this start crashing.
- WebFrame.cpp: (WebFrame::receivedResponse): Remove useless calls to Frame::resourceRequest and Frame::setResourceRequest.
- 1:52 PM Changeset in webkit [22365] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
Merge OpenSource r17056 to TemporaryLinkStubs.cpp.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 12:20 PM Changeset in webkit [17063] by
-
- 14 edits1 add in trunk/WebCore
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Changed PlatformResponse handling for Qt. Don't just store
a QString object containing the data but a new PlatformResponseQt struct
containing data and url, and store it as pointer. This is compatible
to the OS X handling and removes the Qt plaform specific hacks from
CachedCSSStyleSheet, CachedResource & loader.
Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
all methods from TemporaryLinkStubs related to loading in there, and implement
some like ServeSynchronousRequest (yay for xslt handling!).
- CMakeLists.txt:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- platform/ResourceLoaderClient.h:
- platform/ResourceLoaderInternal.h:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument):
- platform/qt/FrameQt.h: (WebCore::QtFrame):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData):
- platform/qt/FrameQtClient.h:
- platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove):
- platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse):
- platform/qt/TemporaryLinkStubs.cpp:
- 3:00 AM Changeset in webkit [17062] by
-
- 31 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg basic datastructure classes.
Oct 14, 2006:
- 5:31 PM Changeset in webkit [17061] by
-
- 10 edits in trunk/WebCore
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Implement some functions in FrameQt / ScrollViewQt.
Added comments what needs to be done in quite some places,
marked some functions as no-ops.
- CMakeLists.txt:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo):
- platform/qt/FrameQt.h:
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible):
- platform/qt/FrameQtClient.h:
- platform/qt/ImageSourceQt.cpp:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 5:04 PM Changeset in webkit [17060] by
-
- 2 edits in trunk/WebKitTools
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add another hanging test, to the "to be skipped" list.
- DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
- 10:38 AM Changeset in webkit [17059] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
<rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
<rdar://problem/4783926> REGRESSION: Typing tab key enters no text
The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
of whether frame->view()->advanceFocus() actually changed the focus.
Trivial fix is to preventDefault() only if advanceFocus() returns true.
- No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
- 10:21 AM Changeset in webkit [17058] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Anders.
Some fixes to get the Qt BuildSlave to run the LayoutTests.
- Scripts/build-dumprendertree: No need to call cmake again.
- Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.
- 5:53 AM Changeset in webkit [17057] by
-
- 10 edits in trunk/WebCore
Reviewed by Mitz.
Fix Qt/Linux build & some little fixes:
- Adapt to Maciej's FrameLoadRequest changes.
- Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
- Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
- Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
- loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
- platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
- platform/qt/BrowserExtensionQt.h:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest):
- platform/qt/FrameQt.h:
- platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 2:42 AM Changeset in webkit [17056] by
-
- 10 edits in trunk/WebCore
2006-10-14 David Carson <dacarson@gmail.com>
Reviewed by Maciej.
Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
Removed Mac platform dependance, changed WebCore functions to
use PlatformResponse/PlatformData rather than NSURLResponse/
NSData.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
- loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData):
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 2:39 AM Changeset in webkit [17055] by
-
- 7 edits in trunk
2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
networking, and set it for GDK build
- wtf/Platform.h:
2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
Pure virtual classes require non-pure destructor, who knew.
Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
so that other platforms can also use CURL, if they wish.
Silence compiler warning about unused variable in SharedTimerLinux.cpp
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient):
- platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback):
- platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer):
Oct 13, 2006:
- 7:44 PM Changeset in webkit [17054] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff.
Build fix from my last check-in. Make hasOutlineAnnotation() non-
inline so that we don't have to include Document.h in
RenderObject.h
Doing so causes a build failure in WebKit, and it probably isn't a
good idea anyway.
- rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation):
- rendering/RenderObject.h: (WebCore::RenderObject::hasOutline):
- 6:37 PM Changeset in webkit [17053] by
-
- 3 edits2 adds in trunk/WebKitSite
Reviewed by Beth.
Split build, run, and debug steps into separate pages. Darin recommended
this a while back.
- building/build.html:
- building/checkout.html:
- building/debug.html: Added.
- building/run.html: Added.
- nav.inc:
- 6:12 PM Changeset in webkit [17052] by
-
- 12 edits in trunk/WebCore
Patch written mostly by Ken Kraisler, but also by me.
Reviewed by Hyatt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
problem/3391162> PDF created by printing should have live
hyperlinks
- platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect):
- platform/GraphicsContext.h:
- platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect):
- platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above.
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting.
- rendering/RenderFlow.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting.
- rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true.
- rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN.
- 4:58 PM Changeset in webkit [17051] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by ggaren and harrison
<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari
- editing/pasteboard/4744008-expected.txt: Added.
- editing/pasteboard/4744008.html: Added.
WebCore:
Reviewed by ggaren and harrison
<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix.
- 4:56 PM Changeset in webkit [22364] by
-
- 5 edits in branches/WindowsMerge/WebCore
Reviewed by Darin.
- split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): (IconLoader::notifyIconChanged):
- 4:54 PM Changeset in webkit [17050] by
-
- 12 edits1 add in trunk/WebCore
Reviewed by Darin.
- split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
- bridge/BrowserExtension.h:
- bridge/mac/BrowserExtensionMac.h:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
- bridge/win/BrowserExtensionWin.h:
- page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
- page/Frame.h:
- page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory):
- page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
- 4:50 PM Changeset in webkit [17049] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej
- loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback.
- 4:45 PM Changeset in webkit [17048] by
-
- 1 edit1 copy in trunk/WebKit
Not reviewed, build fix.
- icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
- 4:16 PM Changeset in webkit [17047] by
-
- 1 edit1 copy in trunk/WebKit
Not reviewed, build fix.
- icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
- 3:14 PM Changeset in webkit [22363] by
-
- 5 edits in branches/WindowsMerge/WebCore
Make form controls work in transparency layers.
- 3:12 PM Changeset in webkit [22362] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Make sure the backing store flushes properly when the theme changes.
- 3:09 PM Changeset in webkit [17046] by
-
- 4 edits in trunk/WebCore
Transparency layer work.
- 2:45 PM Changeset in webkit [17045] by
-
- 2 edits in S60/trunk/WebKit
2006-10-13 zhalu <zhaosong.lu@nokia.com>
Reviewed by Sachin.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is enabled,
the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed.
The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in
CAknFepManager. If users press the key in a normal speed, there is no problem because there is nothing
for committing. But if users press two keys(not two letters on the same key) very quickly, the second key
will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third
key position. The result is that it seems not letting you insert some key in the second position.
- BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):
- 2:42 PM Changeset in webkit [17044] by
-
- 3 edits in trunk/WebKit
Reviewed by Anders.
- add a bunch of casts to get this compiling with older Xcode versions
(I used static_cast so it will be easier to find and remove these once we have completely moved
on to a new enough compiler version.)
- Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): (-[WebBaseNetscapePluginView _reshapeAGLWindow]): (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
- WebKit.xcodeproj/project.pbxproj:
- 2:35 PM Changeset in webkit [17043] by
-
- 2 edits1 move in S60/trunk/S60WebUi
2006-10-13 brmorris <thisisbradley@gmail.com>
Reviewed by Zalan.
DESC: Updates to reindeer sisx installation.
http://bugs.webkit.org/show_bug.cgi?id=9435
- WebUi/install/Reindeer.pkg: Added.
- WebUi/install/WebUi.pkg: Removed.
- WebUi/install/buildsis.bat:
- 2:18 PM Changeset in webkit [17042] by
-
- 7 edits in S60/trunk/WebKit
2006-10-13 sareen <shyam.sareen@nokia.com>
Reviewed by (Sachin.padma@nokia.com).
DESC: New Enum need to add for finding the whether the plugin
is interactive or not.
- Plugin/inc/PluginAdapterInterface.h: (MPluginAdapter::SetOptionMenuHandler):
- Plugin/inc/PluginSkin.h:
- Plugin/inc/PluginWin.h:
- Plugin/inc/npapi.h:
- Plugin/src/PluginSkin.cpp:
- Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::IsContentInteractive):
- 2:04 PM Changeset in webkit [17041] by
-
- 11 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg paint server classes.
- 1:22 PM Changeset in webkit [17040] by
-
- 10 edits4 adds in trunk
LayoutTests:
Tests for accessing renderer-dependent properties from a javascript: URL.
- fast/frames/frame-js-url-clientWidth-expected.txt: Added.
- fast/frames/frame-js-url-clientWidth.html: Added.
- fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
- fast/frames/iframe-js-url-clientWidth.html: Added.
WebCore:
Reviewed by Darin, John.
- Merged more frame and iframe code
- Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time
PLT insists this is a small performance win. Don't believe its lies.
- bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach):
- dom/ContainerNode.h:
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height):
- html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies.
- html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach):
- page/FrameView.h: Removed unused method.
- 12:21 PM Changeset in webkit [17039] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Eric.
Force --no-http on Qt/Linux.
- 12:10 PM Changeset in webkit [17038] by
-
- 1 add2 deletes in trunk/WebCore/platform/qt
Add PopupMenuQt.cpp, remove RenderPopupMenuQt.*, as per WildFox' request.
- 11:56 AM Changeset in webkit [17037] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Kevin McCullough.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11283
Fixes Qt/Linux and Windows build
- kjs/DateMath.cpp:
- kjs/DateMath.h:
- kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):
- 11:17 AM Changeset in webkit [17036] by
-
- 12 edits4 adds in trunk
LayoutTests:
Reviewed by Justin.
<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
- editing/style/style-boundary-005.html: Added. Matches steps from bug.
- editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
- editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
- editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
- editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
WebCore:
Reviewed by Justin.
<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
Tests added or changed:
- editing/style/style-boundary-005.html: Added. Matches steps from bug.
- editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
- editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
- editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
- editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
- dom/Text.cpp: (WebCore::Text::splitText): Comment changes.
- editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
Rename emptySpans local to unstyledSpans.
(WebCore::dummySpanAncestorForNode):
New. To locate Apple style span created when splitting a text node.
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
of dummy span's parents, rather than traversing up from start and
end locations. Old algorithm would miss empty spans in the bug case.
(WebCore::ApplyStyleCommand::applyInlineStyle):
Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
(WebCore::ApplyStyleCommand::removeCSSStyle):
Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Comment changes.
- editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild().
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes.
- rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
- 11:14 AM Changeset in webkit [17035] by
-
- 1 add in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt
Adding a file that should have gone in in r17021, as requested by WildFox.
- 11:08 AM Changeset in webkit [17034] by
-
- 6 edits in trunk/WebCore
Reviewed by Eric.
Fix Qt/Linux build after Adele's popup menu changes.
- CMakeLists.txt:
- platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl):
- platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
- platform/qt/RenderPopupMenuQt.cpp: Removed.
- platform/qt/RenderPopupMenuQt.h: Removed.
- platform/qt/RenderThemeQt.cpp:
- 10:57 AM Changeset in webkit [17033] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam.
Gets JavaScripCore tests running on windows.
- Scripts/run-javascriptcore-tests:
- Scripts/webkitdirs.pm:
- 10:48 AM Changeset in webkit [17032] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
fixed build failure
- WebCore.xcodeproj/project.pbxproj:
- loader/mac/WebFrameLoader.mm:
- 10:31 AM Changeset in webkit [17031] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Adam, Geoff, Darin.
Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up.
- ChangeLog:
- kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
- kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): (KJS::GregorianDateTime::~GregorianDateTime): (KJS::GregorianDateTime::toTM):
- kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
- kjs/date_object.h:
- 10:22 AM Changeset in webkit [17030] by
-
- 2 edits in trunk/WebKit
Changed by Darin, reviewed by me.
- Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on case-sensitive file system.
- 10:07 AM Changeset in webkit [17029] by
-
- 14 edits1 copy1 add in trunk
WebCore:
Reviewed by Adele.
- converted WebFormState from Objective-C to C++
- WebCore.exp: Added a new symbol, changed one symbol from C to C++.
- WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h.
- loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
- loader/mac/WebFormState.h: Converted class to C++.
- loader/mac/WebFormState.mm: Ditto.
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState.
WebKit:
Reviewed by Adele.
- converted WebFormState from Objective-C to C++
- ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here. We should eventually come up with a more-elegant solution.
- WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths. Converted many files from Objective-C to Objective-C++. In a later check-in, I'll rename them to .mm instead of .m. Removed C-only warning options for now. In a later check-in I will add these back in a way that omits them for C++.
- Plugins/WebPluginContainerCheck.m: Updated for header changes.
- WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category so this file can still be used by Objective-C code (not just Objective-C++).
- WebView/WebFrame.m: Put WebFrameLoaderClient category in here. (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed enum code for C++ compatibility. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here. (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility. (-[WebFrame _updateHistoryForReload]): Ditto.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto. (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility. (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
- WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
- 7:36 AM Changeset in webkit [17028] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
- Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
- 5:56 AM Changeset in webkit [17027] by
-
- 23 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg structure classes.
Oct 12, 2006:
- 11:33 PM Changeset in webkit [17026] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Anders.
- Test for http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
- fast/forms/listbox-width-change-expected.txt: Added.
- fast/forms/listbox-width-change-expected.png: Added.
- fast/forms/listbox-width-change-expected.checksum: Added.
- fast/forms/listbox-width-change.html: Added.
WebCore:
Reviewed by Anders.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
Test: fast/forms/listbox-width-change.html
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.
- 10:52 PM Changeset in webkit [22361] by
-
- 10 edits2 deletes in branches/WindowsMerge/WebCore
Vote Cairo off the island.
- 10:49 PM Changeset in webkit [22360] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp
Remove Cairo files from WebFrame.cpp now that the Cairo paint method is gone.
- 10:22 PM Changeset in webkit [17025] by
-
- 10 edits2 adds in trunk
WebCore:
Reviewed by Oliver.
- moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
- loader/mac/LoaderNSURLExtras.h:
- loader/mac/LoaderNSURLRequestExtras.h: Added.
- loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer):
- loader/mac/WebFrameLoader.mm:
- loader/mac/WebSubresourceLoader.mm:
WebKit:
Reviewed by Oliver.
- liberate more WebKit code down to WebCore
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameBridge.m:
- 8:53 PM Changeset in webkit [22359] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Add code that will delete the backing store if our window gets hidden. (We are dependent on the app to make sure we get the message.)
- 7:29 PM Changeset in webkit [22358] by
-
- 2 edits in branches/WindowsMerge/WebCore
RS by Geoff.
Renamed uploadControlDetaching to disconnectUploadControl.
- platform/win/FileChooserWin.cpp: (WebCore::FileChooser::disconnectUploadControl):
- 7:28 PM Changeset in webkit [17024] by
-
- 7 edits in trunk/WebCore
RS by Geoff.
Renamed menuListIsDetaching to disconnectMenuList,
uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
These names match similar methods in WebCore a little better.
- platform/FileChooser.h:
- platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
- platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl):
- platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
- 7:13 PM Changeset in webkit [17023] by
-
- 9 edits in trunk
WebCore:
Reviewed by Maciej.
WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
Added private delegate method for clients that want access to a PopupMenu's NSMenu.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
- bridge/mac/WebCoreFrameBridge.h:
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
WebKit:
Reviewed by Maciej.
WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
Added private delegate method for clients that want access to a PopupMenu's NSMenu.
- DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
- WebView/WebUIDelegatePrivate.h:
- 6:39 PM Changeset in webkit [17022] by
-
- 4 edits in trunk/WebCore
Reviewed by Alice.
- Fix for <rdar://problem/4707372> After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
- platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards.
- 6:33 PM Changeset in webkit [17021] by
-
- 3 edits in trunk/WebKitTools
2006-10-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Maciej.
Exclude some tests which crash or hang from Qt/Linux DRT.
These are known to fail, and will be fixed at some point :-)
- DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::readSkipFile): (WebCore::DumpRenderTree::checkLoaded):
- DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
- DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.
- 6:31 PM Changeset in webkit [17020] by
-
- 3 edits in trunk/WebCore
2006-10-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Maciej.
Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
document.open(); document.write(..); and NO document.close(). On the Qt platform this
leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
Hmpf, this took me nine hours to debug today.
Result: Couldn't find the real fix, going for a workaround for now.
540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
- 6:27 PM Changeset in webkit [22357] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Alice.
Fixed a small oversight from the last checkin. The populate method was calling itself,
instead of the newly renamed addItems method.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::populate):
- 4:04 PM Changeset in webkit [22356] by
-
- 3 edits1 move1 delete in branches/WindowsMerge/WebCore
Reviewed by Adele.
Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.
- WebCore.vcproj/WebCore.vcproj: Move files within project.
- platform/win/PopupMenuWin.cpp: Moved from rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to PopupMenu. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::setPositionAndSize): (WebCore::PopupMenu::addOption): (WebCore::PopupMenu::focusedIndex): New method to get the index of the element that is currently highlighted. This won't always be the same as the selectedIndex because of mouse hot-tracking. (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::registerPopup): (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages to the popup window.
- platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu. (PopupMenu::addSeparator): (PopupMenu::addGroupLabel):
- rendering/RenderPopupMenuWin.cpp: Removed.
- rendering/RenderPopupMenuWin.h: Removed.
- rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
- rendering/RenderThemeWin.h: Ditto.
- 4:02 PM Changeset in webkit [17019] by
-
- 13 edits3 moves2 deletes in trunk/WebCore
Reviewed by Adele.
Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.
- WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/HTMLSelectElement.cpp: Remove unnecessary #include.
- platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr<PopupMenu>. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it.
- platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle):
- platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto.
- platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup):
- rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup):
- rendering/RenderPopupMenu.cpp: Removed.
- rendering/RenderPopupMenu.h: Removed.
- rendering/RenderPopupMenuMac.h: Removed.
- rendering/RenderPopupMenuMac.mm: Removed.
- rendering/RenderPopupMenuWin.h: Removed.
- rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
- rendering/RenderTheme.h: Ditto.
- rendering/RenderThemeMac.h: Ditto.
- rendering/RenderThemeMac.mm: Ditto.
- rendering/RenderThemeWin.cpp: Ditto.
- rendering/RenderThemeWin.h: Ditto.
- 2:44 PM Changeset in webkit [17018] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Harrison.
- Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
- rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.
- 1:42 PM Changeset in webkit [17017] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Removed JSObjectMakeWithPrototype, clarified some comments. We really
don't want people to manage their own prototypes, so we don't want an
extra function in the API devoted to just that. People can still manage
their own prototypes if they really want by using JSObjectSetPrototype.
- API/JSClassRef.cpp: (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
- API/JSClassRef.h:
- API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMake):
- API/JSObjectRef.h:
- API/testapi.c: (main):
- JavaScriptCore.exp:
- 1:29 PM Changeset in webkit [17016] by
-
- 9 edits in trunk/WebCore
Reviewed by MacDome.
Finally found a way to remove our begin() trickery in FrameQt.
The (probably misnamed) Frame::setEncoding() function automatically
calls Frame::receivedFirstData() which calls being on the working
url, which has been passed to didOpenUrl(). Took me some hours
to figure out that the missing charset logic, forced us to do hacks.
- 1:19 PM Changeset in webkit [17015] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Adam.
Build breakage fix
- kjs/DateMath.cpp: (KJS::msToTM):
- kjs/date_object.cpp: (KJS::gmtoffset):
- 12:49 PM Changeset in webkit [17014] by
-
- 2 edits in S60/trunk
2006-10-12 brmorris <thisisbradley@gmail.com>
Reviewed by Bradley.
DESC: Replace winscw MemMan.dll with MemMan_sdk.dll if ! -e MemMan.dll
- 12:22 PM Changeset in webkit [17013] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Bandaid-ing a null-dereference crash until a real fix is made.
- page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
- 11:46 AM Changeset in webkit [17012] by
-
- 4 edits in S60/trunk
2006-10-12 brmorris <thisisbradley@gmail.com>
Reviewed by Zalan.
DESC: Generate/check only the correct WebKit icons depending on build flavour
http://bugs.webkit.org/show_bug.cgi?id=11266
- group/icons.mk: Work off BROWSER_SDK evar to check/create correct icons.
- 11:34 AM Changeset in webkit [17011] by
-
- 2 edits in trunk/WebKit
2006-10-12 MorganL <morganl.webkit@yahoo.com>
Reviewed/landed by Adam.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
Windows build busted
- COM/WebFrame.cpp: (WebFrame::receivedResponse):
- 10:58 AM Changeset in webkit [17010] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly. Also there is some code cleanup.
- kjs/DateMath.cpp: (KJS::timeToMS): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::dateToMS): (KJS::msToTM): (KJS::tmToKJStm): (KJS::KJStmToTm):
- kjs/DateMath.h:
- kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
- kjs/date_object.h:
- 10:10 AM Changeset in webkit [22355] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Build fix (broken by OpenSource r17006)
- WebFrame.cpp: (WebFrame::receivedResponse):
- 10:04 AM Changeset in webkit [17009] by
-
- 9 edits3 adds in S60/trunk
2006-10-12 brmorris <thisisbradley@gmail.com>
Reviewed by Zalan.
DESC: Fixes for GCCE compilation.
http://bugs.webkit.org/show_bug.cgi?id=9435
- 8:07 AM Changeset in webkit [17008] by
-
- 11 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg text classes.
- 5:44 AM Changeset in webkit [17007] by
-
- 7 edits in trunk
WebCore:
Reviewed by Maciej.
Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
WebKitTools:
Reviewed by Maciej.
Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
- 4:50 AM Changeset in webkit [17006] by
-
- 9 edits in trunk/WebCore
Reviewed by Eric.
- move m_responseMIMEType out of ResourceRequest, where it doesn't belong
- page/FramePrivate.h: Add m_responseMIMEType
- page/ResourceRequest.h: Remove m_responseMIMEType
- page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto
- page/Frame.h:
- bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto
- 3:36 AM Changeset in webkit [17005] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric.
<rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
We really need some way to test loadHTMLString since it keeps breaking!
- loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
- 3:22 AM Changeset in webkit [17004] by
-
- 3 edits in trunk/WebCore
Reviewed by Eric.
Fix Qt/Linux build.
- 2:36 AM Changeset in webkit [17003] by
-
- 6 edits in trunk
2006-10-12 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Update Gdk\Linux build for recent changes, based on Qt code
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
- platform/gdk/FrameGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create):
2006-10-12 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Also regenerate GdkLauncher makefiles, since not doing that might
lead to mismatch between WebCore and GdkLauncher compiler settings.
- Scripts/regenerate-makefiles:
- 2:03 AM Changeset in webkit [22354] by
-
- 12 edits in branches/WindowsMerge
Implement full-blown double buffering.
- 2:01 AM Changeset in webkit [17002] by
-
- 13 edits in trunk/WebCore
Add more clipping retrieval functionality for widgets.
Oct 11, 2006:
- 6:44 PM Changeset in webkit [17001] by
-
- 3 edits in S60/trunk/WebKit
2006-10-11 brmorris <thisisbradley@gmail.com>
Reviewed by zalan
DESC: send reindeer UA String
http://bugs.webkit.org/show_bug.cgi?id=9189
- BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
- ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK
- 5:54 PM Changeset in webkit [17000] by
-
- 11 edits in trunk/WebKit
Reviewed by Adele.
- preparations for making more code C++
- WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.
- Misc/WebKitLogging.h:
- Misc/WebKitSystemBits.h:
- Misc/WebLocalizableStrings.h:
- WebCoreSupport/WebSystemInterface.h: Added extern "C".
- Misc/WebNSViewExtras.h:
- WebView/WebDataSource.m: (addTypesFromClass):
- WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".
- WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
- Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
- 5:40 PM Changeset in webkit [16999] by
-
- 14 edits in trunk/WebCore
Reviewed by John.
- some changes to prepare for converting more code to C++
- bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.
- bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).
- loader/mac/LoaderNSURLExtras.h:
- loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.
- loader/mac/LoaderNSURLExtras.m:
- loader/mac/WebDataProtocol.mm:
- loader/mac/WebDocumentLoader.mm:
- loader/mac/WebFormDataStream.m:
- loader/mac/WebLoader.mm:
- loader/mac/WebMainResourceLoader.mm:
- loader/mac/WebNetscapePlugInStreamLoader.mm:
- loader/mac/WebPolicyDecider.mm:
- loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.
- 4:18 PM Changeset in webkit [16998] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by John Sullivan.
- WebKitSystemInterface.h: Updated to a C++-compatible version.
- 4:15 PM Changeset in webkit [16997] by
-
- 4 edits in trunk/WebCore
Darin wrote this code; we tested it; I give it the thumbs up.
- fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
The hash table to look up an element class given a QualifiedName was
not working at all.
- dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.
- bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto
- 2:09 PM Changeset in webkit [16996] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Anders.
Clean up FileChooser::create and Icon::newIconForFile.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
- platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):
- 1:39 PM Changeset in webkit [16995] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Darin.
These test DST behavior on the cusp of a change (i.e. spring forward, fall back)
- fast/js/date-DST-time-cusps-expected.txt: Added.
- fast/js/date-DST-time-cusps.html: Added.
- fast/js/resources/date-DST-time-cusps.js: Added.
- 11:45 AM Changeset in webkit [16994] by
-
- 3 edits in trunk/LayoutTests
2006-10-11 Oliver Hunt <oliver@apple.com>
Reviewed by Brady.
Fix svg text related layout tests
- svg/custom/getsvgdocument-expected.txt:
- svg/hixie/viewbox/003-expected.txt:
- 11:27 AM Changeset in webkit [16993] by
-
- 3 edits4 adds in trunk
2006-10-11 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
Reviewed by Geoff.
Test case for http://bugs.webkit.org/show_bug.cgi?id=11251
- fast/canvas/zero-size-fill-rect-expected.checksum: Added.
- fast/canvas/zero-size-fill-rect-expected.png: Added.
- fast/canvas/zero-size-fill-rect-expected.txt: Added.
- fast/canvas/zero-size-fill-rect.html: Added.
- 11:26 AM Changeset in webkit [16992] by
-
- 1 edit7 adds in S60/trunk/S60Internals
Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
http://bugs.webkit.org/show_bug.cgi?id=9435
- target/GCCE/SDKGCCEPatch.zip: Added.
- target/RVCT/S60LibsRVCT.zip: Added.
- target/RVCT/S60RVCTPatch.zip: Added.
- target/RVCT/rvct2_2.h: Added. (std::):
- 11:19 AM Changeset in webkit [16991] by
-
- 3 edits2 adds in trunk
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"
Take better care of empty cursor lists.
Test: fast/css/invalid-cursor-property-crash.html
- 10:56 AM Changeset in webkit [16990] by
-
- 2 edits in trunk/WebCore
Fixing Windows for real this time.
- platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
- 10:30 AM Changeset in webkit [16989] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
- 10:14 AM Changeset in webkit [22353] by
-
- 2 edits in branches/WindowsMerge/WebCore
Rubberstamped by Brady.
Clean up logic in Icon::newIconForFile.
- platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.
- 10:08 AM Changeset in webkit [22352] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Steve.
Fixes <rdar://problem/4777719>
Icons don't paint with CG
- platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.
- 9:54 AM Changeset in webkit [22351] by
-
- 3 edits in branches/WindowsMerge/WebCore
Rubberstamped by Anders.
Clean up FileChooser::create, Icon::create.
- platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
- platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.
- 8:04 AM Changeset in webkit [16988] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
- fast/layers/layer-visibility-expected.checksum: Added.
- fast/layers/layer-visibility-expected.png: Added.
- fast/layers/layer-visibility-expected.txt: Added.
- fast/layers/layer-visibility.html: Added.
WebCore:
Reviewed by Hyatt.
Respect css visibility semantics for layers too
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
- 12:15 AM Changeset in webkit [16987] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Oliver.
- added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
- WebCore.xcodeproj/project.pbxproj:
- platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):
- use it in WidgetMac so it gets tested in at least one place
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):
Oct 10, 2006:
- 11:35 PM Changeset in webkit [16986] by
-
- 8 edits in trunk
WebCore:
Reviewed by Maciej.
Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]):
- loader/mac/WebFrameLoader.h:
- loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]):
WebKit:
Reviewed by Maciej.
Moved WebFrameLoader into WebCoreFrameBridge
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge close]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
- 9:39 PM Changeset in webkit [16985] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Tim H.
Bug 11246: Minor Drosera code cleanup
http://bugs.webkit.org/show_bug.cgi?id=11246
- Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.
- 9:35 PM Changeset in webkit [16984] by
-
- 7 edits5 adds in trunk/WebKitTools
Reviewed by Tim H.
- ChangeLog:
- Drosera/Drosera.xcodeproj/project.pbxproj: Added files
- Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
- Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
- Drosera/Images/SourceArrowOpen.png: Added.
- Drosera/Images/fileIcon.jpg: Added.
- Drosera/Images/siteCollapsed.tif: Added.
- Drosera/Images/siteExpanded.tif: Added.
- Drosera/Images/siteIcon.tif: Added.
- Drosera/debugger.css: Added File Browser styles
- Drosera/debugger.html: Added File Browser UI
- Drosera/debugger.js: Added File Browser functionality
- 9:35 PM Changeset in webkit [22350] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Oliver.
Fixes <rdar://problem/4731316>
Crash when <input type="file"> element removed while file chooser is open
- platform/win/FileChooserWin.cpp: Make FileChooser ref-counted. (WebCore::FileChooser::create): (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around the call to GetOpenFileName so we don't get deleted while the file chooser window is open.
- 9:33 PM Changeset in webkit [16983] by
-
- 5 edits in trunk/WebCore
Reviewed by Oliver.
Make FileChooser ref-counted.
- platform/FileChooser.h:
- platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
- rendering/RenderFileUploadControl.h:
- 8:46 PM Changeset in webkit [16982] by
-
- 22 edits1 delete in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
Even More auto-generated Objective-C DOM bindings changes
- Auto-generate DOMSVGPathElement.
- Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.
- Add SVG classes to DOMNode and DOMEvent internal interfaces.
- Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.
- Assorted cleanups.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent):
- bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]):
- bindings/objc/DOMSVGPathSegInternal.h: Removed.
- bindings/scripts/CodeGeneratorObjC.pm:
- css/CSSRule.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- dom/Event.cpp: (WebCore::Event::isSVGZoomEvent):
- dom/Event.h:
- dom/Event.idl:
- dom/Node.idl:
- ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent):
- ksvg2/events/SVGZoomEvent.h:
- ksvg2/svg/SVGAnimatedAngle.idl:
- ksvg2/svg/SVGCircleElement.idl:
- ksvg2/svg/SVGClipPathElement.idl:
- ksvg2/svg/SVGPathElement.idl:
- ksvg2/svg/SVGPathSeg.idl:
- 8:41 PM Changeset in webkit [22349] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
Fixes <rdar://problem/4772428>
<select> popup menus positioned incorrectly within frames
- rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::setPositionAndSize): Use contentsToWindow() instead of scrollOffset() to correct menu location.
- 7:29 PM Changeset in webkit [22348] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-10 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
<rdar://4775676>
Crash in CoreFoundation parsing a "corrupt" plist
Prevent crash when we encounter a corrupt history plist by using
structured exception handling to catch the crash and return
an empty history list.
- WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL):
- 7:22 PM Changeset in webkit [16981] by
-
- 2 edits in trunk/WebCore
2006-10-10 Oliver Hunt <oliver@apple.com>
rubber stamped by Anders.
More buildbot bustage
- kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline):
- 7:12 PM Changeset in webkit [16980] by
-
- 4 edits in trunk/WebCore
2006-10-10 Oliver Hunt <oliver@apple.com>
Reviewed by Anders
Unbreak build bots
- dom/Text.cpp:
- kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
- kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline):
- 6:28 PM Changeset in webkit [16979] by
-
- 9 edits10 adds in trunk/WebCore
2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>
Reviewed by hyatt.
Fixes bugs #6423, #6559, #10380 and #10839
- WebCore.xcodeproj/project.pbxproj:
- css/svg.css:
- dom/Text.cpp: (WebCore::Text::createRenderer):
- kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox):
- kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer):
- kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect):
- kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer):
- kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects):
- kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName):
- kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox):
- kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
- kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
- kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
- kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
- kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
- ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer):
- ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer):
- rendering/InlineFlowBox.h:
- 6:26 PM Changeset in webkit [16978] by
-
- 271 edits in trunk/LayoutTests
2006-10-10 Oliver Hunt <ohunt@apple.com>
Rubber stamped by Anders.
Updated to deal with new svg text renderers, and
updated result.
custom/text-clip testcase was incorrect, and has been fixed
- svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
- svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
- svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
- svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
- svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
- svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
- svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
- svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
- svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
- svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
- svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
- svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
- svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
- svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
- svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
- svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
- svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
- svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
- svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
- svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
- svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
- svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
- svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
- svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
- svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
- svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
- svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
- svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
- svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
- svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
- svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
- svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
- svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
- svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
- svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
- svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
- svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
- svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
- svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
- svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
- svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
- svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
- svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
- svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
- svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
- svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
- svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
- svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
- svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
- svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
- svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
- svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
- svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
- svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
- svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
- svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
- svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
- svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
- svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
- svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
- svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
- svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
- svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
- svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
- svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
- svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
- svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
- svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
- svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
- svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
- svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
- svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
- svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
- svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
- svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
- svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
- svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-01-b-expected.png:
- svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-02-b-expected.png:
- svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
- svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-03-b-expected.png:
- svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
- svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-04-b-expected.png:
- svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
- svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-05-b-expected.png:
- svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
- svg/W3C-SVG-1.1/text-align-06-b-expected.png:
- svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
- svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
- svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
- svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
- svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
- svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
- svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
- svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
- svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
- svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
- svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
- svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
- svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
- svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
- svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
- svg/custom/baseval-animval-equality-expected.checksum:
- svg/custom/baseval-animval-equality-expected.png:
- svg/custom/coords-relative-units-transforms-expected.checksum:
- svg/custom/coords-relative-units-transforms-expected.png:
- svg/custom/coords-relative-units-transforms-expected.txt:
- svg/custom/createelement-expected.txt:
- svg/custom/feComponentTransfer-Discrete-expected.txt:
- svg/custom/feComponentTransfer-Gamma-expected.txt:
- svg/custom/feComponentTransfer-Linear-expected.txt:
- svg/custom/feComponentTransfer-Table-expected.txt:
- svg/custom/foreign-object-skew-expected.txt:
- svg/custom/gradient-stroke-width-expected.txt:
- svg/custom/image-with-transform-clip-filter-expected.txt:
- svg/custom/invalid-css-expected.txt:
- svg/custom/invalid-fill-expected.txt:
- svg/custom/invalid-viewbox1-expected.txt:
- svg/custom/invalid-viewbox2-expected.txt:
- svg/custom/junk-data-expected.txt:
- svg/custom/marker-overflow-clip-expected.txt:
- svg/custom/missing-xlink-expected.txt:
- svg/custom/non-opaque-filters-expected.txt:
- svg/custom/pointer-events-path-expected.txt:
- svg/custom/svg-overflow-types-expected.txt:
text-clip was an incorrect test, rather than an incorrect result
- svg/custom/text-clip-expected.txt:
- svg/custom/text-clip.svg:
- svg/custom/text-filter-expected.txt:
- svg/custom/text-gradient-no-content-expected.txt:
- svg/custom/text-hit-test-expected.txt:
- svg/custom/text-image-opacity-expected.txt:
- svg/custom/tref-update-expected.txt:
- 3:04 PM Changeset in webkit [22347] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Fixes <rdar://problem/4763246>
Using arrow keys in <select> popup fires onChange event
Also updates text shown in <select> element on page when using arrow
keys to change selection within the popup menu, and makes onChange fire
in the same cases as Firefox/IE.
- rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::down): Update text of the <select> control. Change call to valueChanged() so that onChange doesn't fire. (WebCore::RenderPopupMenuWin::up): Ditto. (WebCore::PopupWndProc): Don't fire onChange anytime selection changes. Fire onChange when pressing Enter
- 2:57 PM Changeset in webkit [16977] by
-
- 5 edits in trunk/WebCore
Reviewed by Adele.
Improve popup menu behavior.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection.
- html/HTMLSelectElement.h:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here.
- rendering/RenderMenuList.h:
- 2:28 PM Changeset in webkit [16976] by
-
- 2 edits in S60/trunk/WebCore
2006-10-10 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas
DESC: On ActivateEvent, clear the "don't submit form twice" data member.
http://bugs.webkit.org/show_bug.cgi?id=11242
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
- 2:18 PM Changeset in webkit [16975] by
-
- 15 edits in trunk
WebCore:
Reviewed by Beth.
- Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
Moved autoscroll code to the Frame class
- bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
- bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):
- bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore.
- page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto.
- page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
- page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac.
- page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
- rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
WebKit:
Reviewed by Beth.
Removed handleAutoscrollForMouseDragged. Except for autoscroll caused by drag and drop, all other
autoscrolling should be done in WebCore instead of in AppKit.
- WebCoreSupport/WebFrameBridge.m:
- WebView/WebHTMLView.m:
- WebView/WebHTMLViewPrivate.h:
- 2:02 PM Changeset in webkit [16974] by
-
- 2 edits in S60/trunk/WebCore
2006-10-10 bujtas <zbujtas@gmail.com>
Reviewed by NOBODY.
DESC: changing capital includes to non-capital
http://bugs.webkit.org/show_bug.cgi?id=11247
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/xml/xml_tokenizer.cpp: (khtml::XMLNamespace::m_ref): (khtml::): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElement): (khtml::XMLTokenizer::endElement): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::exitText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::setTransformSource): (khtml::attributesStartElementHandler): (khtml::XMLAttributes::operator=): (khtml::XMLAttributes::split):
- 2:00 PM Changeset in webkit [16973] by
-
- 2 edits9 moves in trunk/WebCore
Rubber stamped by Maciej.
- convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++
- WebCore.xcodeproj/project.pbxproj:
- loader/mac/WebDataProtocol.m: Removed.
- loader/mac/WebDocumentLoader.m: Removed.
- loader/mac/WebFormState.m: Removed.
- loader/mac/WebFrameLoader.m: Removed.
- loader/mac/WebLoader.m: Removed.
- loader/mac/WebMainResourceLoader.m: Removed.
- loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
- loader/mac/WebPolicyDecider.m: Removed.
- loader/mac/WebSubresourceLoader.m: Removed.
- loader/mac/WebDataProtocol.mm: Added.
- loader/mac/WebDocumentLoader.mm: Added.
- loader/mac/WebFormState.mm: Added.
- loader/mac/WebFrameLoader.mm: Added.
- loader/mac/WebLoader.mm: Added.
- loader/mac/WebMainResourceLoader.mm: Added.
- loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
- loader/mac/WebPolicyDecider.mm: Added.
- loader/mac/WebSubresourceLoader.mm: Added.
- 2:00 PM Changeset in webkit [16972] by
-
- 1 edit1 add in trunk/WebKitTools
- Scripts/do-file-rename: Added.
- 1:10 PM Changeset in webkit [16971] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
- fixed REGRESSION (r16960): crash on navigating to site http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
- loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain.
- 12:17 PM Changeset in webkit [22346] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Beth.
- fix problem where you can't type in subframes
- WebView.cpp: (WebViewWndProc): Use WebView's focusedTargetFrame() function instead of sending everything to the main frame.
- 10:01 AM Changeset in webkit [16970] by
-
- 2 edits in trunk/WebKit
- corrected an archive regression caused by loader refactoring (pointed out by Graham Dennis)
- WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]): Fix selector name.
- 9:19 AM Changeset in webkit [16969] by
-
- 33 edits18 adds in S60/trunk
2006-10-04 sareen <shyam.sareen@nokia.com>
Reviewed by Zalan, yongjun.
DESC: Change the dll names BROWSER_SDK and add stub for HistoryProvider
http://bugzilla.opendarwin.org/show_bug.cgi?id=11148
http://bugzilla.opendarwin.org/show_bug.cgi?id=11149
http://bugzilla.opendarwin.org/show_bug.cgi?id=11150
- 4:03 AM Changeset in webkit [16968] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
- fixed release build
- WebCore.xcodeproj/project.pbxproj:
- 3:48 AM Changeset in webkit [16967] by
-
- 20 edits24 moves in trunk
WebCore:
Rubber stamped by Eric.
- moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- loader/mac/LoaderNSURLExtras.m: Added.
- loader/mac/WebDataProtocol.m: Added.
- loader/mac/WebDocumentLoader.m: Added.
- loader/mac/WebFormDataStream.m: Added.
- loader/mac/WebFrameLoader.m: Added.
- loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
- loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]):
- loader/mac/WebPolicyDecider.m: Added.
- loader/mac/WebSubresourceLoader.h: Added.
- loader/mac/WebSubresourceLoader.m: Added.
WebKit:
Rubber stamped by Eric.
- moved a whole bunch of stuff over to WebCore - updated includes appropriately
- Loader/LoaderNSURLExtras.h: Removed.
- Loader/LoaderNSURLExtras.m: Removed.
- Loader/WebDataProtocol.h: Removed.
- Loader/WebDataProtocol.m: Removed.
- Loader/WebDocumentLoader.h: Removed.
- Loader/WebDocumentLoader.m: Removed.
- Loader/WebFormDataStream.h: Removed.
- Loader/WebFormDataStream.m: Removed.
- Loader/WebFormState.h: Removed.
- Loader/WebFormState.m: Removed.
- Loader/WebFrameLoader.h: Removed.
- Loader/WebFrameLoader.m: Removed.
- Loader/WebFrameLoaderClient.h: Removed.
- Loader/WebLoader.h: Removed.
- Loader/WebLoader.m: Removed.
- Loader/WebMainResourceLoader.h: Removed.
- Loader/WebMainResourceLoader.m: Removed.
- Loader/WebNetscapePlugInStreamLoader.h: Removed.
- Loader/WebNetscapePlugInStreamLoader.m: Removed.
- Loader/WebPlugInStreamLoaderDelegate.h: Removed.
- Loader/WebPolicyDecider.h: Removed.
- Loader/WebPolicyDecider.m: Removed.
- Loader/WebSubresourceLoader.h: Removed.
- Loader/WebSubresourceLoader.m: Removed.
- Misc/WebNSURLExtras.m:
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginView.m:
- Plugins/WebNetscapePluginStream.m:
- Plugins/WebPluginContainerCheck.m:
- Plugins/WebPluginController.m:
- WebCoreSupport/WebFrameBridge.m:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m:
- WebView/WebDocumentLoaderMac.h:
- WebView/WebFrame.m:
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.m:
- WebView/WebPolicyDeciderMac.h:
- WebView/WebPolicyDelegate.m:
- WebView/WebView.m:
- 3:38 AM Changeset in webkit [16966] by
-
- 2 edits in trunk/WebKit
2006-10-10 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
Fix crash on launch in nightly builds after r16965.
Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView. If this happens,
InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
pointer.
- Misc/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
- 2:49 AM Changeset in webkit [16965] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver (sort of?)
- WebCore part of moving down NSURL extras
- WebCore.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 2:44 AM Changeset in webkit [16964] by
-
- 5 edits2 adds in trunk/WebKit
Reviewed by Oliver.
- split out some NSURL extras to be moved to WebCore
- Loader/LoaderNSURLExtras.h: Added.
- Loader/LoaderNSURLExtras.m: Added. (urlByRemovingComponent): (urlByRemovingFragment): (urlOriginalDataAsString): (urlOriginalData): (urlWithData): (WebCFAutorelease): (urlWithDataRelativeToURL): (urlByRemovingResourceSpecifier): (urlIsFileURL): (stringIsFileURL): (urlIsEmpty): (canonicalURL):
- Loader/WebFrameLoader.m: (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (setHTTPReferrer): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader safeLoadURL:]):
- Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- WebKit.xcodeproj/project.pbxproj:
- 1:42 AM Changeset in webkit [16963] by
-
- 12 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg animation classes.
- 1:06 AM Changeset in webkit [16962] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
- added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]):
Oct 9, 2006:
- 11:51 PM Changeset in webkit [16961] by
-
- 4 edits in trunk/WebKit
Reviewed by Anders.
- sever final WebFrame dependencies
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader checkLoadComplete]):
- 11:12 PM Changeset in webkit [16960] by
-
- 6 edits in trunk/WebKit
Reviewed by Brady.
- convert more WebFrameLoader stuff to be independent of WebFrame
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader client]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebDataSource.m: (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
- WebView/WebFrame.m: (-[WebFrame _dispatchCreateWebViewWithRequest:]):
- 10:14 PM Changeset in webkit [16959] by
-
- 6 edits in trunk/WebKit
Reviewed by Anders and Oliver.
- move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadRequest:]): (-[WebFrameLoader loadRequest:inFrameNamed:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _hasFrameView]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _didFinishLoad]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _provisionalLoadStarted]):
- WebView/WebFrameInternal.h:
- 9:04 PM Changeset in webkit [22345] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
Reviewed by Steve
<rdar://4721579> - WebPreferences for IconDatabase hooked up
This completes the above task by implementing the icon database location preference
- WebIconDatabase.cpp: (WebIconDatabase::init): Get the location from the prefs, fallback to the default via shell call
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::iconDatabaseLocation): (WebPreferences::setIconDatabaseLocation):
- 8:16 PM Changeset in webkit [16958] by
-
- 1 edit2 adds in trunk/WebKit
Not reviewed, build fix.
- added forgotten files
- Loader/WebPolicyDecider.h: Added.
- Loader/WebPolicyDecider.m: Added. (-[WebPolicyDecider invalidate]):
- 7:41 PM Changeset in webkit [16957] by
-
- 6 edits2 adds in trunk/WebKit
Reviewed by Brady.
- add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
- Loader/WebFrameLoaderClient.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.m: (-[WebFrame _createPolicyDeciderWithTarget:action:]): (decisionListener): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
- WebView/WebPolicyDeciderMac.h: Added.
- WebView/WebPolicyDeciderMac.m: Added. (-[WebPolicyDeciderMac initWithTarget:action:]): (-[WebPolicyDeciderMac dealloc]): (-[WebPolicyDeciderMac decisionListener]): (-[WebPolicyDeciderMac invalidate]):
- 7:10 PM Changeset in webkit [16956] by
-
- 5 edits1 add in trunk/WebKit
Reviewed by John
http://bugs.webkit.org/show_bug.cgi?id=11195
Added the WebIconDatabaseDelegate. This allows the ability to allow customization of
IconDatabase behavior in the future, starting now with the ability to override the
default icon fairly flexibly
- Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
- Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase delegate]):
- Misc/WebIconDatabaseDelegate.h: Added.
- Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
- WebKit.xcodeproj/project.pbxproj:
- 6:52 PM Changeset in webkit [16955] by
-
- 2 edits in trunk/WebCore
Backing out accidental commit.
- page/Frame.cpp: (WebCore::Frame::finishedParsing):
- 6:49 PM Changeset in webkit [16954] by
-
- 11 edits in trunk/WebCore
Reviewed by Darin.
Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
this could cause recursive calls to the destructor. RefPtr now also
inherits from Noncopyable.
- dom/NodeFilter.h:
- dom/Traversal.h:
- page/DOMWindow.h:
- page/Frame.cpp: (WebCore::Frame::finishedParsing):
- page/Frame.h:
- page/Plugin.h:
- platform/FontFallbackList.h:
- platform/Icon.h:
- platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount):
- platform/StringImpl.h:
- 6:30 PM Changeset in webkit [16953] by
-
- 7 edits in trunk/WebKit
Reviewed by Maciej.
- eliminated uses of WebResource and WebView from WebFrameLoader
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): (-[WebFrameLoader _canShowMIMEType:]): (-[WebFrameLoader _representationExistsForURLScheme:]): (-[WebFrameLoader _generatedMIMETypeForURLScheme:]): (-[WebFrameLoader loadDocumentLoader:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
- Loader/WebFrameLoaderClient.h:
- Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader loadWithRequestNow:]):
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame _canUseResourceForRequest:]): (-[WebFrame _canUseResourceWithResponse:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _setDefersCallbacks:]): (-[WebFrame _canHandleRequest:]): (-[WebFrame _canShowMIMEType:]): (-[WebFrame _representationExistsForURLScheme:]): (-[WebFrame _generatedMIMETypeForURLScheme:]): (-[WebFrame _elementForEvent:]):
- 6:09 PM Changeset in webkit [16952] by
-
- 10 edits in trunk/WebCore
2006-10-09 Oliver Hunt <ohunt@apple.com>
Reviewed by Anders.
Correcting ifdef's
- html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop):
- html/CanvasGradient.h:
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern):
- html/CanvasPattern.h:
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
- html/CanvasRenderingContext2D.h:
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext):
- html/HTMLCanvasElement.h:
- 6:04 PM Changeset in webkit [16951] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
- do all the stuff that setting the referrer should
- Loader/WebFrameLoader.m: (setHTTPReferrer): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- WebKit.xcodeproj/project.pbxproj:
- 5:53 PM Changeset in webkit [16950] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Darin.
- test case that ensures Referer[sic] header is sent
- http/tests/misc/referrer-expected.txt: Added.
- http/tests/misc/referrer.html: Added.
- http/tests/misc/resources/referrer-result.php: Added.
- 5:38 PM Changeset in webkit [22344] by
-
- 8 edits in branches/WindowsMerge/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
Fix <rdar://problem/4756255>
PDF/Acrobat Reader plugin don't work
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): Implement these, getting the instance from the plugin view.
- platform/win/TemporaryLinkStubs.cpp: Remove functions that are now implemented.
- plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): Implement this, returning whether we a plugin exists for a given mime type.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::parseVersionString): (WebCore::compareVersions): New functions for handling versions.
(WebCore::addMozillaPluginPaths):
(WebCore::addWindowsMediaPlayerPluginPath):
(WebCore::addQuickTimePluginPath):
(WebCore::addJavaPluginPath):
(WebCore::addAdobeAcrobatPluginPath):
(WebCore::PluginDatabaseWin::defaultPluginPaths):
Factor out checks into separate functions, add checks for Java and Adobe Acrobat.
(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
Handle null MIME types.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Add some missing functions. Unload the library if the load failed.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): Uncomment code for getting the element object.
(WebCore::PluginViewWin::bindingInstance):
- plugins/win/PluginViewWin.h: New function which fetches the plugin NPObject and wraps it in an instance.
- 5:05 PM Changeset in webkit [16949] by
-
- 2 edits in tags/Safari-521.28b/WebCore
Reviewed by Steve.
Merge r16948 to tag.
- 4:57 PM Changeset in webkit [16948] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Fix a possible recursive destructor call.
- page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed.
- 4:49 PM Changeset in webkit [16947] by
-
- 42 edits2 adds in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
Assorted Objective-C bindings changes
- Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
- Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement.
- Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker)
- Put more methods in the WebCore namespace and factor out the displayString method into DOMInternal.h as done by Darin in his patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
- bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
- bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
- bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]):
- bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString):
- bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]):
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
- bindings/objc/DOMSVG.h:
- bindings/objc/DOMSVGPathSegInternal.h: Added.
- bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
- bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/NodeIterator.idl:
- dom/TreeWalker.idl:
- html/HTMLInputElement.idl:
- html/HTMLObjectElement.idl:
- ksvg2/svg/SVGDocument.idl:
- ksvg2/svg/SVGElement.idl:
- ksvg2/svg/SVGPathSeg.idl:
- ksvg2/svg/SVGPathSegArcAbs.idl:
- ksvg2/svg/SVGPathSegArcRel.idl:
- ksvg2/svg/SVGPathSegClosePath.idl:
- ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
- ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
- ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
- ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
- ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
- ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
- ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
- ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
- ksvg2/svg/SVGPathSegLinetoAbs.idl:
- ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
- ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
- ksvg2/svg/SVGPathSegLinetoRel.idl:
- ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
- ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
- ksvg2/svg/SVGPathSegMovetoAbs.idl:
- ksvg2/svg/SVGPathSegMovetoRel.idl:
- 4:28 PM Changeset in webkit [16946] by
-
- 2 edits in trunk/WebCore
2006-10-09 Don Gibson <dgibson77@gmail.com>
Unreviewed build fix.
Fix windows build bustage.
- platform/win/TemporaryLinkStubs.cpp:
- 4:08 PM Changeset in webkit [16945] by
-
- 15 edits in trunk
2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Geoff.
Improve gdk build compiler flags (show warning, no rtti and exceptions).
- jscore.bkl:
2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Geoff.
Improve gdk build compiler options.
- Bakefiles.bkgen:
- presets.bkl:
2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Geoff.
Fix memory leaks discovered via valgrind. Gdk build fixes.
- Projects/gdk/webcore-gdk.bkl:
- make-generated-sources.sh:
- platform/cairo/ImageCairo.cpp: (WebCore::Image::draw):
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
- platform/gdk/FrameGdk.h:
- platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Geoff.
Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
a page. This allows automatic testing via e.g. valgrind.
- GdkLauncher/gdklauncher.bkl:
- GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (LauncherFrameGdk::setExitAfterLoading): (LauncherFrameGdk::handledOnloadEvents): (handle_event): (main):
- 3:36 PM Changeset in webkit [16944] by
-
- 2 edits in trunk/WebCore
2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Beth.
Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
- platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage):
- 3:34 PM Changeset in webkit [16943] by
-
- 2 edits in trunk/LayoutTests
2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Use log() instead of alert() just like in all other tests.
- editing/selection/move-begin-end.html:
- 3:30 PM Changeset in webkit [16942] by
-
- 4 edits in trunk/WebCore
2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
Unreviewed build fix.
Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget):
- platform/qt/FrameQt.h:
- platform/qt/TemporaryLinkStubs.cpp:
- 3:24 PM Changeset in webkit [16941] by
-
- 6 edits in trunk
WebCore:
Reviewed by Maciej
Tiny changes to help reorganize WebFrameLoader code in WebKit
- bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
- bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
WebKit:
Reviewed by Maciej
Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader
- Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
- WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge createInstance]):
- 2:44 PM Changeset in webkit [16940] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
(Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)
- avoid a needless use of WebFrame
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
- 2:36 PM Changeset in webkit [16939] by
-
- 3 edits in S60/trunk/WebKit
2006-10-09 yaharon <yael.aharon@nokia.com>
Reviewed by Yongjun Zhang
DESC: Fix issues with touch support
- Activate an element only if it received both down and up pointer events
- Fix coordinates calculation in frames while zooming
- Update cursor in each touch event, to give user the correct feedback
- BrowserView/inc/PointerEventHandler.h:
- BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL):
- 1:27 PM Changeset in webkit [16938] by
-
- 2 edits in trunk/WebKit
A *real* fake fix for the layouttest problem until the real fix
- Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
- 1:15 PM Changeset in webkit [16937] by
-
- 2 edits in trunk/WebKit
Quick layouttest fix until I make the real fix
- Loader/WebFrameLoader.m:
- 1:06 PM Changeset in webkit [16936] by
-
- 7 edits in trunk/WebKit
Reviewed by Darin.
- wean WebFrameLoader from WebDataSource private stuff
(actually just tweaks tot he above to make merging my future
patches easier since Darin did a lot of the same stuff)
- Loader/WebDocumentLoader.h:
- Loader/WebDocumentLoader.m: (-[WebDocumentLoader URLForHistory]):
- Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebDataSource.m: (-[WebDataSource _URLForHistory]):
- WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]):
- 12:31 PM Changeset in webkit [16935] by
-
- 7 edits in trunk/WebKit
Reviewed by Brady.
- eliminated WebFrameLoader dependency on WebDataSourceInternal.h, WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with most but not all references to WebView
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader handleUnimplementablePolicyWithError:]): (-[WebFrameLoader cannotShowMIMETypeWithResponse:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader checkLoadComplete]):
- Loader/WebFrameLoaderClient.h:
- Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
- WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _formDelegate]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _revertToProvisionalWithDocumentLoader:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _URLForHistoryForDocumentLoader:]): (-[WebFrame _cancelledErrorWithRequest:]): (-[WebFrame _cannotShowURLErrorWithRequest:]): (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]): (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]): (-[WebFrame _fileDoesNotExistErrorWithResponse:]): (-[WebFrame _shouldFallBackForError:]): (-[WebFrame _hasWebView]): (-[WebFrame _mainFrameURL]):
- WebView/WebFrameInternal.h:
- 11:50 AM Changeset in webkit [22343] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Steve.
Fix <rdar://problem/4773320>
Safari didn't pick up quicktime that was already installed
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths):
- 11:43 AM Changeset in webkit [16934] by
-
- 2 edits in tags/Safari-521.28b/WebCore
Reviewed by Steve.
Merging r16932 to tag.
- 11:41 AM Changeset in webkit [16933] by
-
- 1 edit in trunk/WebKit/WebInspector/WebInspector.m
Build fix.
- 11:30 AM Changeset in webkit [22342] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Fixes <rdar://problem/4773142>
Crash in Settings::mediumFontSize() on ebay.com
Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
end up calling the Frame::saveDocumentState, which is pure virtual.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
- 11:29 AM Changeset in webkit [16932] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
already called frome ~FrameMac.
- page/Frame.cpp: (WebCore::Frame::~Frame):
- 11:29 AM Changeset in webkit [16931] by
-
- 7 edits in trunk/WebKit
Reviewed, landed, tweaked a bit by Darin.
- removed most uses of WebFrameBridge from WebFrameLoader (WebCoreFrameBridge use is OK)
- Loader/WebDocumentLoader.m: (-[WebDocumentLoader bridge]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
- WebView/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]):
- WebView/WebFrameInternal.h:
- 11:28 AM Changeset in webkit [22341] by
-
- 3 edits in branches/WindowsMerge/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
- WebCore.vcproj/WebCore.vcproj:
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Fix build.
- 11:04 AM Changeset in webkit [16930] by
-
- 6 edits in trunk/WebKit
Reviewed by Brady.
- removed almost all direct use of WebView from WebFrameLoader
- Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
- Loader/WebFrameLoaderClient.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.m: (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _hasBackForwardList]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]): (-[WebFrame _progressStarted]): (-[WebFrame _progressCompleted]): (-[WebFrame _incrementProgressForIdentifier:response:]): (-[WebFrame _incrementProgressForIdentifier:data:]): (-[WebFrame _completeProgressForIdentifier:]): (-[WebFrame _setMainFrameDocumentReady:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _startDownloadWithRequest:]):
- 10:47 AM Changeset in webkit [16929] by
-
- 2 edits in trunk/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
- bridge/win/FrameWin.h: Add function declaration.
- 10:35 AM Changeset in webkit [16928] by
-
- 2 edits in trunk/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build.
- 10:21 AM Changeset in webkit [16927] by
-
- 6 edits2 deletes in trunk/WebCore
2006-10-09 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Move applet widget creation to Frame and get rid of JavaAppletWidget.
- WebCore.xcodeproj/project.pbxproj:
- bridge/JavaAppletWidget.h: Removed.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget):
- bridge/mac/JavaAppletWidget.mm: Removed.
- page/Frame.h:
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
- 2:53 AM Changeset in webkit [16926] by
-
- 7 edits2 adds in trunk/WebKit
Reviewed by Alice.
- moved WebFormState into Loader directory and tweaked to void WebKit dependencies
- Loader/WebDocumentLoader.h:
- Loader/WebFormState.h: Added.
- Loader/WebFormState.m: Added. (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState dealloc]): (-[WebFormState form]): (-[WebFormState values]): (-[WebFormState sourceFrame]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.m:
- WebView/WebFrameInternal.h:
- 2:29 AM Changeset in webkit [16925] by
-
- 2 edits1 add1 delete in trunk/WebCore
2006-10-09 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=11220 Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
Subversion does not support resource forks and HFS metadata, so
the resources for this test need to be on a disk image.
- manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
- manual-tests/resources/plain-text-paste.dmg: Added.
- manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
- manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
- manual-tests/resources/plain-text-paste/._4.txt: Removed.
- manual-tests/resources/plain-text-paste/._5.webloc: Removed.
- manual-tests/resources/plain-text-paste/1.textClipping: Removed.
- manual-tests/resources/plain-text-paste/2.textClipping: Removed.
- manual-tests/resources/plain-text-paste/3.gif: Removed.
- manual-tests/resources/plain-text-paste/4.txt: Removed.
- manual-tests/resources/plain-text-paste/5.webloc: Removed.
- 2:09 AM Changeset in webkit [16924] by
-
- 3 edits in trunk/WebKit
Reviewed by Oliver.
- remove dependency on WebNSURLRequestExtras.h
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
- 1:59 AM Changeset in webkit [16923] by
-
- 2 edits in trunk/WebKit
Reviewed by Oliver.
- removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
- Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
- 1:44 AM Changeset in webkit [16922] by
-
- 10 edits in trunk/WebKit
Reviewed by Oliver.
- remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
- Loader/WebDocumentLoader.h:
- Loader/WebDocumentLoader.m: (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader initialRequest]): (-[WebDocumentLoader URL]): (-[WebDocumentLoader unreachableURL]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _URL]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader safeLoadURL:]):
- Loader/WebFrameLoaderClient.h:
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge originalRequestURL]):
- WebView/WebDataSource.m: (-[WebDataSource _URL]): (-[WebDataSource dealloc]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
- WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _forceLayoutForNonHTML]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]): (-[WebFrame _makeRepresentationForDocumentLoader:]):
- 12:40 AM Changeset in webkit [16921] by
-
- 31 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in filter classes.
- 12:36 AM Changeset in webkit [16920] by
-
- 24 edits in trunk/WebCore
Reviewed by olliej.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in SVGPath* classes.
- 12:32 AM Changeset in webkit [16919] by
-
- 4 edits in trunk/WebKit
Reviewed by Darin.
- removed need for WebFrameLoader to now about WebDocumentLoaderMac
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
- WebView/WebDocumentLoaderMac.h:
- WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac setFrameLoader:]): (-[WebDocumentLoaderMac detachFromFrameLoader]):
- 12:27 AM Changeset in webkit [16918] by
-
- 15 edits in trunk/WebCore
Reviewed by aroben.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg shape classes.
- 12:23 AM Changeset in webkit [16917] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
- passed calls that require WebScriptDebugServer across the client interface
- Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
- 12:03 AM Changeset in webkit [16916] by
-
- 5 edits in trunk/WebKit
Reviewed by Maciej.
- passed calls that require WebHTMLView or WebFrameView calls across the client interface
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader opened]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader reload]): (-[WebFrameLoader transitionToCommitted:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _forceLayout]): (-[WebFrame _setDocumentViewFromPageCache:]): (-[WebFrame _setCopiesOnScroll]):
Oct 8, 2006:
- 11:46 PM Changeset in webkit [16915] by
-
- 4 edits in trunk/WebKit
Reviewed by Darin.
- pass remaining delegate methods across client interface
- Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _dispatchDidFirstLayoutInFrame]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchShow]): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]): (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
- 11:30 PM Changeset in webkit [16914] by
-
- 16 edits in trunk
WebCore:
Reviewed by Maciej.
- added a bit more WebCoreSystemInterface
wkGetNSURLResponseCalculatedExpiration
wkGetNSURLResponseLastModifiedDate
wkGetNSURLResponseMustRevalidate
- WebCore.exp: Added the new symbols.
- platform/mac/WebCoreSystemInterface.h: Ditto.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- quiet down the code generation script
- bindings/scripts/CodeGenerator.pm:
WebKit:
Reviewed by Maciej.
- use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
- Loader/WebFrameLoader.m: Update includes. (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK. (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added the three new symbols, and resorted the list.
- Loader/WebDataProtocol.m:
- Loader/WebLoader.m:
- Loader/WebMainResourceLoader.h:
- Loader/WebMainResourceLoader.m:
- Loader/WebNetscapePlugInStreamLoader.h:
- Loader/WebNetscapePlugInStreamLoader.m:
- Loader/WebSubresourceLoader.h:
- Loader/WebSubresourceLoader.m: Changed import statements to consistently use the "" format.
- 11:19 PM Changeset in webkit [16913] by
-
- 2 edits in trunk/WebKit
Not reviewed.
- fix accidental build break due to editing while committing
- Loader/WebFrameLoader.m:
- 11:17 PM Changeset in webkit [16912] by
-
- 4 edits in trunk/WebKit
Reviewed by Darin.
- move all WebFrameLoadDelegate methods across client interface
- Loader/WebFrameLoader.m: (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _dispatchDidCancelClientRedirectForFrame]): (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]): (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]): (-[WebFrame _dispatchWillCloseFrame]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidReceiveTitle:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]):
- 10:44 PM Changeset in webkit [16911] by
-
- 6 edits in trunk/WebKit
Reviewed by Maciej.
- removed some of the WebKit dependencies in WebFrameLoader
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader reload]): (-[WebFrameLoader didChangeTitleForDocument:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
- WebView/WebFrameInternal.h:
- some other tweaks
- Misc/WebNSURLRequestExtras.m: (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
- 10:42 PM Changeset in webkit [16910] by
-
- 4 edits in trunk/WebKit
Reviewed by Darin.
- pass all WebResourceLoadDelegate methods across client, removing need to include related headers
- Loader/WebFrameLoader.m: (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
- 10:23 PM Changeset in webkit [16909] by
-
- 6 edits in trunk/WebKit
Reviewed by Darin.
- started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
- Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
- Loader/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge handledOnloadEvents]):
- WebView/WebFrame.m: (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
- WebView/WebFrameInternal.h:
- 9:30 PM Changeset in webkit [16908] by
-
- 11 edits in trunk/WebKit
Reviewed by Maciej.
- moved more methods to WebFrameLoader from WebFrame
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader reload]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader checkLoadComplete]):
- Loader/WebFrameLoaderClient.h:
- Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge close]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]):
- WebView/WebDataSourceInternal.h:
- WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _detachedFromParent1]): (-[WebFrame _detachedFromParent2]): (-[WebFrame _detachedFromParent3]): (-[WebFrame _detachedFromParent4]): (-[WebFrame _updateHistoryAfterClientRedirect]): (-[WebFrame _loadedFromPageCache]):
- WebView/WebFrameInternal.h:
- WebView/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
- WebView/WebView.m: (-[WebView _close]): (-[WebView setDefersCallbacks:]):
- 8:56 PM Changeset in webkit [16907] by
-
- 10 edits in trunk
WebCore:
Reviewed by Darin.
- more code laundering - add wkSupportsMultipartXMixedReplace
- WebCore.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Darin.
- avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
- Loader/WebDocumentLoader.m: (-[WebDocumentLoader initWithRequest:]):
- Loader/WebMainResourceLoader.m:
- Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- WebView/WebDataSource.m: (-[WebDataSource _initWithDocumentLoader:]):
- 8:23 PM Changeset in webkit [16906] by
-
- 1 edit in trunk/WebKit/WebView/WebFrame.m
Release build fix: silence warning about unused variable.
- 7:43 PM Changeset in webkit [16905] by
-
- 2 edits in trunk/WebKit
- build fix (also a fix for a crasher I forgot to commit before)
- Loader/WebFrameLoader.m: Added some missing includes. (-[WebFrameLoader checkLoadCompleteForThisFrame]): Added a needed retain/release.
- 7:35 PM Changeset in webkit [16904] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
- quick fix to loader problem causing layout test failures
- Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge that we retain/release. (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Same here.
- 7:17 PM Changeset in webkit [22340] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Maciej.
Break up ResourceLoaderWndProc into callback functions.
- platform/win/ResourceLoaderWin.cpp: Fix up #includes (WebCore::): Remove loadStatusMessage, struct JobLoadStatus, add messageHandlers array. (WebCore::ResourceLoaderWndProc): Split handling of different messages into callbacks. (WebCore::ResourceLoader::onHandleCreated): New callback. (WebCore::ResourceLoader::onRequestRedirected): New callback. (WebCore::ResourceLoader::onRequestComplete): New callback. (WebCore::initializeOffScreenResourceLoaderWindow): No need to register loadStatusMessage anymore. (WebCore::transferJobStatusCallback): Change how information is passed into ResourceLoaderWndProc.
- 7:09 PM Changeset in webkit [16903] by
-
- 4 edits in trunk/WebKit
Reviewed by Adam.
- removed a few includes from WebFrameLoader, fixed up as appropriate
- segregated header includes into ones that need to go away to move the code and ones that don't
- Loader/WebFrameLoader.m: (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[WebFrame _privateBrowsingEnabled]):
- 6:48 PM Changeset in webkit [16902] by
-
- 9 edits in trunk/WebKit
Reviewed by Maciej.
- moved a few methods from WebFrame to WebFrameLoader
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (isBackForwardLoadType): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- Loader/WebFrameLoaderClient.h:
- Plugins/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
- WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _updateBackground]): (-[WebFrame _frameLoader]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForBackForwardNavigation]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _tokenForLoadErrorReset]): (-[WebFrame _resetAfterLoadError:]): (-[WebFrame _doNotResetAfterLoadError:]):
- WebView/WebFrameInternal.h:
- 5:44 PM Changeset in webkit [16901] by
-
- 2 edits in trunk/WebKit
2006-10-09 Mark Rowe <bdash@webkit.org>
Rubber-stamped by Darin.
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that is triggering an assertion failure.
- 5:33 PM Changeset in webkit [16900] by
-
- 2 edits in trunk/WebCore
2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Darin and Oliver.
Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
- platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage. (WebCore::GraphicsContext::drawConvexPolygon):
- 4:52 PM Changeset in webkit [16899] by
-
- 8 edits in trunk/WebKit
Reviewed by Darin.
- remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into two coincidentally matching enums)
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader commitProvisionalLoad:]): (isBackForwardLoadType): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader didFirstLayout]):
- WebCoreSupport/WebFrameBridge.m:
- WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _loadType]): (-[WebFrame loadRequest:]):
- WebView/WebFrameInternal.h:
- WebView/WebView.m:
- 4:33 PM Changeset in webkit [16898] by
-
- 2 edits in trunk/WebCore
2006-10-08 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- page/Frame.cpp: (WebCore::Frame::submitForm): No need to use latin1() here.
- 3:47 PM Changeset in webkit [16897] by
-
- 6 edits in trunk/WebKit
Reviewed by Maciej.
- move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge
- Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader closeOldDataSources]):
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge loader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge imageTitleForFilename:size:]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
- WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFramePrivate setWebFrameView:]): (-[WebFramePrivate setProvisionalItem:]): (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _setTitle:]): (-[WebFrame _defersCallbacksChanged]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForSavingDocState]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _frameLoader]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame frameView]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
- WebView/WebFrameInternal.h:
- 3:45 PM Changeset in webkit [16896] by
-
- 2 edits in trunk/WebCore
2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Darin.
Kill warnings when generating IDL files on Qt/Linux, as the
SOURCE_ROOT environment variable is not defined (and not needed) for us.
- bindings/scripts/CodeGenerator.pm:
- 3:24 PM Changeset in webkit [16895] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
- split didNotOpenURL: into general and page-cache-specific parts
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:]): (-[WebCoreFrameBridge invalidatePageCache:]):
- 3:10 PM Changeset in webkit [16894] by
-
- 10 edits in trunk/WebKit
Reviewed by Darin.
- move remaining movable data fields from WebFrameLoader to WebFrame
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitIfReady]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader isQuickRedirectComing]):
- Loader/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameBridge.h:
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
- WebView/WebDataSource.m: (-[WebDataSource _loadFromPageCache:]):
- WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _didFinishLoad]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame stopLoading]): (-[WebFrame _invalidateCurrentItemPageCache]):
- WebView/WebFrameInternal.h:
- 2:40 PM Changeset in webkit [16893] by
-
- 3 edits in trunk/WebCore
2006-10-08 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- loader/loader.cpp: Remove DeprecatedStringList.h include.
- page/Frame.cpp: (WebCore::Frame::submitForm): Don't remove "attach" from mailto URLs, we don't do it anywhere else.
- 2:28 PM Changeset in webkit [16892] by
-
- 12 edits4 moves in trunk/WebKit
Rubber stamped by Maciej.
- changed "document load state" to "document loader"
- Loader/WebDocumentLoadState.h: Removed.
- Loader/WebDocumentLoadState.m: Removed.
- Loader/WebDocumentLoader.h: Added.
- Loader/WebDocumentLoader.m: Added. (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setTitle:]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader activeDocumentLoader]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader setDocumentLoader:]): (-[WebFrameLoader documentLoader]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader setPolicyDocumentLoader:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader provisionalDocumentLoader]): (-[WebFrameLoader setProvisionalDocumentLoader:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
- Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
- WebView/WebDataSourceInternal.h:
- WebView/WebDocumentLoadStateMac.h: Removed.
- WebView/WebDocumentLoadStateMac.m: Removed.
- WebView/WebDocumentLoaderMac.h: Added.
- WebView/WebDocumentLoaderMac.m: Added.
- WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
- WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):
- 1:44 PM Changeset in webkit [16891] by
-
- 1 edit in trunk/WebKit/ChangeLog
More change log tweaking -- it's well worth it!
- 1:42 PM Changeset in webkit [16890] by
-
- 1 edit in trunk/WebKit/ChangeLog
Fixed grammar mistake in change log entry.
- 1:42 PM Changeset in webkit [16889] by
-
- 2 edits in trunk/WebKit
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=11218 REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL
Also added a helper function in WebFrameLoader so code that checks for back/forward load types
is easier to read.
- Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load state to nil instead of the passed-in object. (isBackForwardLoadType): Added. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType. (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): Ditto. (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.
- 12:19 PM Changeset in webkit [16888] by
-
- 27 edits2 deletes in trunk/WebCore
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
Yet another round of Objective-C SVG DOM bindings auto-generation
- Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent, DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, DOMSVGZoomAndPan and DOMSVGZoomEvent.
- Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement using the new [ConvertFromString] property.
- Add forward declarations for NS* types to auto-generated classes.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMHTMLAppletElement.mm: Removed.
- bindings/objc/DOMHTMLEmbedElement.mm: Removed.
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMSVG.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- ksvg2/svg/SVGPatternElement.idl:
- ksvg2/svg/SVGPolygonElement.idl:
- ksvg2/svg/SVGPolylineElement.idl:
- ksvg2/svg/SVGRadialGradientElement.idl:
- ksvg2/svg/SVGRenderingIntent.idl:
- ksvg2/svg/SVGScriptElement.idl:
- ksvg2/svg/SVGSetElement.idl:
- ksvg2/svg/SVGStopElement.idl:
- ksvg2/svg/SVGSwitchElement.idl:
- ksvg2/svg/SVGSymbolElement.idl:
- ksvg2/svg/SVGTRefElement.idl:
- ksvg2/svg/SVGTSpanElement.idl:
- ksvg2/svg/SVGTextContentElement.idl:
- ksvg2/svg/SVGTextElement.idl:
- ksvg2/svg/SVGTextPositioningElement.idl:
- ksvg2/svg/SVGTitleElement.idl:
- ksvg2/svg/SVGUseElement.idl:
- ksvg2/svg/SVGViewElement.idl:
- ksvg2/svg/SVGZoomEvent.idl:
- 6:53 AM Changeset in webkit [16887] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
- fix two recently introduced leaks: one of an NSString, the other of a WebDataSource
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Rearranged code to avoid storage leak in case of identical title.
- Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method from the header.
- Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader as needed if this load state is going away rather than moving on to become the provisional load state. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting. (-[WebFrameLoader _loadRequest:archive:]): Added an assertion. (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion. (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion. (-[WebFrameLoader reload]): Added an assertion. (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid calling _documentLoadState over and over again.
- 1:02 AM Changeset in webkit [22339] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Add win2k/classic support for all controls.
- 12:47 AM Changeset in webkit [22338] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-07 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Fix <rdar://4772205> Regression (r10623): WinInet loader doesn't ever write to the cache.
- platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): Apply POST related flags only for posts. (WebCore::ResourceLoader::startHTTPRequest): Don't add no-cache-write flag to non-post transactions.
Oct 7, 2006:
- 11:15 PM Changeset in webkit [22337] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Add code to paint the Windows Classic/2000 look for scrollbars.
- 6:08 PM Changeset in webkit [16886] by
-
- 2 edits in trunk/WebCore
2006-10-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.
- loader/loader.cpp: (WebCore::Loader::servePendingRequests):
- 5:44 PM Changeset in webkit [16885] by
-
- 18 edits in trunk/WebCore
2006-10-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Convert a bunch of RefPtr<StringImpl> to String.
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::didTellBridgeAboutLoad): (WebCore::FrameMac::haveToldBridgeAboutLoad):
- dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::storeResult):
- dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::result):
- dom/Document.cpp: (WebCore::Document::createEntityReference):
- dom/Entity.cpp: (WebCore::Entity::Entity): (WebCore::Entity::nodeName): (WebCore::Entity::toString):
- dom/Entity.h: (WebCore::Entity::publicId): (WebCore::Entity::systemId): (WebCore::Entity::notationName):
- dom/EntityReference.cpp: (WebCore::EntityReference::EntityReference): (WebCore::EntityReference::nodeName): (WebCore::EntityReference::cloneNode): (WebCore::EntityReference::toString):
- dom/EntityReference.h:
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent): (WebCore::KeyboardEvent::initKeyboardEvent):
- dom/KeyboardEvent.h: (WebCore::KeyboardEvent::keyIdentifier):
- dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
- dom/MutationEvent.h: (WebCore::MutationEvent::prevValue): (WebCore::MutationEvent::newValue): (WebCore::MutationEvent::attrName):
- dom/Notation.cpp: (WebCore::Notation::Notation): (WebCore::Notation::nodeName):
- dom/Notation.h: (WebCore::Notation::publicId): (WebCore::Notation::systemId):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::setData): (WebCore::ProcessingInstruction::nodeName): (WebCore::ProcessingInstruction::nodeValue): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::toString):
- dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::target): (WebCore::ProcessingInstruction::data): (WebCore::ProcessingInstruction::localHref):
- 3:49 PM Changeset in webkit [22336] by
-
- 2 edits in branches/WindowsMerge/WebCore
Make sure frames honor scrolling modes and margins.
- 12:22 PM Changeset in webkit [22335] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Anders.
Merge of OpenSource r16884
http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.
- WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):
- 11:53 AM Changeset in webkit [16884] by
-
- 2 edits in trunk/WebKit
Reviewed/landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.
- COM/WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):
- 11:42 AM Changeset in webkit [22334] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Steve.
Fix for failed ASSERT on iBench.
- WebFrame.cpp: (WebFrame::receivedAllData): Be a bit more lenient about what ResourceLoader has called WebFrame::receivedAllData
- 10:24 AM Changeset in webkit [16883] by
-
- 24 edits in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
10 more SVG Objective-C auto-generated bindings
- Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement, DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
- Auto-generate the text method for DOMRange.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMRGBColor.mm:
- bindings/objc/DOMSVG.h:
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/Range.idl:
- ksvg2/svg/SVGFilterElement.cpp:
- ksvg2/svg/SVGFilterElement.h:
- ksvg2/svg/SVGFilterElement.idl:
- ksvg2/svg/SVGForeignObjectElement.idl:
- ksvg2/svg/SVGGElement.idl:
- ksvg2/svg/SVGGradientElement.idl:
- ksvg2/svg/SVGImageElement.idl:
- ksvg2/svg/SVGLineElement.idl:
- ksvg2/svg/SVGLinearGradientElement.idl:
- ksvg2/svg/SVGMarkerElement.idl:
- ksvg2/svg/SVGMaskElement.idl:
- ksvg2/svg/SVGPaint.idl:
- 5:58 AM Changeset in webkit [16882] by
-
- 14 edits1 move1 add3 deletes in trunk
WebCore:
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces
- Fully auto-generate DOMAbstractView and DOMRange.
- Auto-generate just the interface for DOMRGBColor.
- Add DOMRanges.h as the new top level file for Ranges module.
- Add DOMRanges.h and DOMXPath.h to DOM.mm
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.h:
- bindings/objc/DOM.mm:
- bindings/objc/DOMAbstractView.h: Removed.
- bindings/objc/DOMAbstractView.mm: Removed.
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMRGBColor.h: Removed.
- bindings/objc/DOMRGBColor.mm:
- bindings/objc/DOMRange.h: Removed.
- bindings/objc/DOMRanges.h: Added.
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- css/RGBColor.idl:
- dom/Range.idl:
- page/AbstractView.idl: Added.
WebKit:
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces
- MigrateHeaders.make:
- 5:39 AM Changeset in webkit [16881] by
-
- 3 edits4 adds in trunk
2006-10-07 Andrew Wellington <proton@wiretapped.net>
Reviewed by Eric.
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Return null when there is no frame. This matches Firefox.
- bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty):
2006-10-07 Andrew Wellington <proton@wiretapped.net>
Reviewed by Eric.
Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
- fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.
- 5:04 AM Changeset in webkit [16880] by
-
- 2 edits in trunk/WebCore/platform
Fix win32 and qt bustage.
- 4:41 AM Changeset in webkit [16879] by
-
- 5 edits in trunk/WebCore
Implement scroll corner painting (a white rect fill) for overflow areas to cover up
scrollbar joins properly.
Refactor painting of scrollbars and resizers into common functions. Eliminate the
extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
Reviewed by mitz
- page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
- platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h:
- 3:42 AM Changeset in webkit [16878] by
-
- 2 edits in trunk/WebKit
2006-10-07 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix memory leak from -[WebDocumentLoadState setTitle:].
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is zero, and untangle the confusing logic around this case.
- 2:32 AM Changeset in webkit [16877] by
-
- 6 edits in trunk/WebCore
2006-10-07 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
matching recent ResourceLoader changes.
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected):
- platform/gdk/PlatformScrollBar.h:
- platform/gdk/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::start):
- platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode):
- platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::addChild): (ScrollView::updateScrollbars): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
- 1:20 AM Changeset in webkit [22333] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp
Fix build bustage from earlier checkin.
- 1:18 AM Changeset in webkit [22332] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix resizer coordinate space error.
Oct 6, 2006:
- 11:57 PM Changeset in webkit [22331] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp
Better fix for scrollbars coming and going affecting plugin clip.
- 11:32 PM Changeset in webkit [22330] by
-
- 2 edits in branches/WindowsMerge/WebCore
Update plugin clipping when scrollbars come/go.
- 11:06 PM Changeset in webkit [16876] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp
Fix Qt bustage.
- 11:04 PM Changeset in webkit [16875] by
-
- 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp
Fix win32 bustage.
- 11:03 PM Changeset in webkit [16874] by
-
- 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm
Remove x/y from the log message on debug Mac builds.
- 10:56 PM Changeset in webkit [22329] by
-
- 2 edits in branches/WindowsMerge/WebCore
Improve performance of plugin clipping when scrolling.
- 10:55 PM Changeset in webkit [16873] by
-
- 16 edits in trunk/WebKit
Reviewed by Darin
Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal
- DefaultDelegates/WebDefaultContextMenuDelegate.m:
- History/WebHistoryItem.m:
- Loader/WebFrameLoader.h:
- Misc/WebCoreStatistics.m:
- Misc/WebElementDictionary.m:
- Plugins/WebNetscapePluginEmbeddedView.m:
- Plugins/WebPluginController.m:
- WebCoreSupport/WebViewFactory.m:
- WebView/WebArchiver.m:
- WebView/WebDataSource.m:
- WebView/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame _isFrameSet]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- WebView/WebHTMLRepresentation.m:
- WebView/WebScriptDebugDelegate.m:
- 10:43 PM Changeset in webkit [22328] by
-
- 4 edits in branches/WindowsMerge/WebCore
Implement clipping of plugins on Win32.
- 10:32 PM Changeset in webkit [16872] by
-
- 10 edits in trunk/WebCore
Add a new method for obtaining accurate window-level clip rectangles. Can be used even by windowed plugins to clip properly.
- 8:31 PM Changeset in webkit [16871] by
-
- 3 edits3 adds in trunk/WebKitTools
2006-10-06 David Smith <catfish.man@gmail.com>
Reviewed by Timothy.
Bug 9665: [Drosera] Conditional breakpoints. http://bugs.webkit.org/show_bug.cgi?id=9665
- Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
- Drosera/breakpointEditor.css: Added.
- Drosera/breakpointEditor.html: Added.
- Drosera/breakpointEditor.js: Added.
- Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.
- 6:57 PM Changeset in webkit [22327] by
-
- 6 edits in branches/WindowsMerge
WebCoreWin:
Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL
The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.
The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.
- ChangeLog:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
- bridge/win/FrameWin.h:
WebKitWin:
Reviewed by Adam Roben, esq.
Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL
The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.
The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.
- WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::stopMainResourceLoad): (WebFrame::receivedAllData):
- WebFrame.h:
- 5:42 PM Changeset in webkit [16870] by
-
- 6 edits in trunk/WebKit
Reviewed by Darin.
- Move all delegate dispatching code out of WebDataSource.
- Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
- WebView/WebDataSource.m: (-[WebDataSource _setLoadingFromPageCache:]): (-[WebDataSource _stopLoadingWithError:]):
- WebView/WebDataSourceInternal.h:
- 5:36 PM Changeset in webkit [16869] by
-
- 6 edits in trunk/WebKit
Reviewed by Maciej.
- moved firstLayoutDone BOOL from WebFrame to WebFrameLoader
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader firstLayoutDone]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
- WebView/WebFrame.m: (-[WebFrame _firstLayoutDone]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]):
- WebView/WebFrameInternal.h:
- 5:19 PM Changeset in webkit [16868] by
-
- 8 edits in trunk/WebKit
Reviewed by Maciej.
- moved more data and the corresponding code from WebFrame to WebFrameLoader
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader cannotShowMIMETypeForURL:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader _continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]): (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
- Loader/WebFrameLoaderClient.h:
- WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame stopLoading]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _quickRedirectComing]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- WebKit.xcodeproj/project.pbxproj:
- 4:00 PM Changeset in webkit [22326] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Use a better versioning scheme.
Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".
This first versioned submission is 521.28b
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Use a better versioning scheme.
Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".
This first versioned submission is 521.28b
- WebKit.vcproj/WebKit.rc:
- 3:49 PM Changeset in webkit [16867] by
-
- 2 edits in trunk/WebKit
Rubber stamped by Darin.
- removed includes of unused headers.
- WebView/WebDataSource.m:
- 3:42 PM Changeset in webkit [16866] by
-
- 3 edits in trunk/WebKit
Not reviewed.
- fix build breakage
- Loader/WebFrameLoader.m: (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
- 3:38 PM Changeset in webkit [16865] by
-
- 11 edits in trunk/WebKit
Reviewed by Darin.
- move remaining movable WebDataSource fields to WebDocumentLoadState
- Loader/WebDocumentLoadState.h:
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState isLoadingInAPISense]): (-[WebDocumentLoadState addResponse:]): (-[WebDocumentLoadState stopRecordingResponses]): (-[WebDocumentLoadState title]): (-[WebDocumentLoadState setLastCheckedRequest:]): (-[WebDocumentLoadState lastCheckedRequest]): (-[WebDocumentLoadState triggeringAction]): (-[WebDocumentLoadState setTriggeringAction:]): (-[WebDocumentLoadState responses]): (-[WebDocumentLoadState setOverrideEncoding:]): (-[WebDocumentLoadState overrideEncoding]): (-[WebDocumentLoadState setTitle:]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource textEncodingName]):
- WebView/WebDataSourceInternal.h:
- WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
- WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
- WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):
- 3:32 PM Changeset in webkit [16864] by
-
- 1 copy in tags/Safari-521.28b
New tag.
- 3:20 PM Changeset in webkit [22325] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Bump version number.
- WebKit.vcproj/WebKit.rc:
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Bump version number.
- 2:52 PM Changeset in webkit [16863] by
-
- 6 edits in trunk/WebKit
Reviewed by Maciej.
- moved loadType into WebFrameLoader
- WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's currently used by Safari.
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
- WebView/WebFrame.m: (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _didFirstLayout]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame loadRequest:]):
- 2:34 PM Changeset in webkit [22324] by
-
- 7 edits in branches/WindowsMerge
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam, Lou.
<rdar://4754295> Corrupt history.plist = crash on startup
Fix improper CF usage that likely led to retain/release imbalances.
Resizer fixes.
We now properly invalidate and draw overlapping contents or opaque.
Fix capture state after resize by posting a mouse up to balance the one that gets eaten (Thanks, Lou!)
- 2:25 PM Changeset in webkit [16862] by
-
- 3 edits in trunk/WebCore
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Add another method we'll need for scrollbar dodging
- platform/ScrollView.h:
- platform/win/TemporaryLinkStubs.cpp: (ScrollView::resizerOverlapsContent):
- 2:25 PM Changeset in webkit [16861] by
-
- 6 edits1 add in trunk/WebKit
Reviewed by Maciej.
- added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame
- Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol. Eventually we'll be removing the dependency on WebFrame entirely.
- WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method by its new name.
- Loader/WebFrameLoaderClient.h: Added.
- WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.
- 2:13 PM Changeset in webkit [16860] by
-
- 14 edits9 deletes in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
Auto-generate the interfaces even for Objective-C DOM
bindings that need custom implementations
- Fully auto-generate DOMEventTarget, DOMNodeFilter and DOMHTMLOptionElement.
- Auto-generate just the interface for DOMHTMLAppletElement, DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect using the new IDL property ObjCCustomImplementation.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMEventTarget.h: Removed.
- bindings/objc/DOMHTMLAppletElement.h: Removed.
- bindings/objc/DOMHTMLEmbedElement.h: Removed.
- bindings/objc/DOMHTMLOptionElement.h: Removed.
- bindings/objc/DOMHTMLOptionElement.mm: Removed.
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMNodeFilter.h: Removed.
- bindings/objc/DOMSVGNumber.h: Removed.
- bindings/objc/DOMSVGPoint.h: Removed.
- bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint matrixTransform:]):
- bindings/objc/DOMSVGRect.h: Removed.
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/EventTarget.idl:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLOptionElement.idl:
- ksvg2/svg/SVGNumber.idl:
- ksvg2/svg/SVGPoint.idl:
- ksvg2/svg/SVGRect.idl:
- 2:11 PM Changeset in webkit [16859] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to
Also removed useless WebFrameLoader part
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]):
- 2:04 PM Changeset in webkit [22323] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add (commented out) WMP plugin check.
- 1:53 PM Changeset in webkit [22322] by
-
- 2 edits5 adds in branches/WindowsMerge/WebKitTools
2006-10-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
Land new version of DumpRenderTree that uses the WebKit APIs.
- 1:48 PM Changeset in webkit [16858] by
-
- 4 edits in trunk
WebCore:
Reviewed by Tim H.
Make Qt/Linux compile again completly.
- platform/qt/WidgetQt.cpp: (WebCore::Widget::removeFromParent):
WebKitTools:
Reviewed by Tim H.
Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.
- DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- 1:42 PM Changeset in webkit [16857] by
-
- 8 edits in trunk/WebKit
Reviewed by Anders.
- moved more data from WebDataSource to WebDocumentLoadState
- Loader/WebDocumentLoadState.h:
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState prepareForLoadStart]): (-[WebDocumentLoadState loadingStartedTime]): (-[WebDocumentLoadState setIsClientRedirect:]): (-[WebDocumentLoadState isClientRedirect]): (-[WebDocumentLoadState setPrimaryLoadComplete:]): (-[WebDocumentLoadState isLoadingInAPISense]):
- Loader/WebFrameLoader.h:
- Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader subframeIsLoading]):
- WebView/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource isLoading]):
- WebView/WebDataSourceInternal.h:
- WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
- 1:36 PM Changeset in webkit [16856] by
-
- 4 edits in trunk/WebCore
Reviewed by Tim H.
Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
- platform/qt/PlatformScrollBar.h:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::scrollbarUnderMouse):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (FrameView::passMousePressEventToScrollbar):
- 11:26 AM Changeset in webkit [22321] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-10-06 Anders Carlsson <acarlsson@apple.com>
Reviewed by Brady and Geoff.
<rdar://problems/4769023>
Crash on cnettv.com - PluginStreamWin::receivedResponse
- platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): If the Content-Type header is missing, try to figure o ut the content type from the file extension. Failing that, just use "application/octet-stream".
- 11:16 AM Changeset in webkit [16855] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Brady.
DST and TimeZones were wrong in some cases, specifically on some of the dates where DST changes.
- kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::dateToMseconds): (KJS::msToTM):
- kjs/DateMath.h:
- kjs/date_object.cpp: (KJS::gmtoffset):
- 11:03 AM Changeset in webkit [16854] by
-
- 4 deletes in S60/branches/scriptable_plugins/WebCore
Remove some tmp files from revision control.
- 10:55 AM Changeset in webkit [16853] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled
- WebView/WebFrame.m: (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Use utf-8 encoding instead of the string's "fastest" encoding.
- 7:52 AM Changeset in webkit [16852] by
-
- 3 edits in S60/trunk/WebKit
2006-10-06 yaharon <yael.aharon@nokia.com>
Reviewed by Yongjun Zhang
DESC: Match page overview touch behavior to UI spec
http://bugs.webkit.org/show_bug.cgi?id=11179
- BrowserView/inc/PointerEventHandler.h:
- BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL): (CPointerEventHandler::AutoScroll):
- 5:28 AM Changeset in webkit [16851] by
-
- 3 edits in S60/branches/3.1m/WebCore
2006-10-05 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
http://bugs.webkit.org/show_bug.cgi?id=11170
merged from trunk r16849
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
- kwq/KWQKHTMLPart.h:
- 5:25 AM Changeset in webkit [16850] by
-
- 36 edits6 adds in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation
- Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement, DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, DOMSVGFETileElement, DOMSVGFETurbulenceElement, DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
- Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint and DOMSVGRect.
- IDL clean up.
- Make numOctaves in SVGFETurbulenceElement use a long instead of an int in it's macro declaration and definition.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMSVG.h:
- bindings/objc/DOMSVGNumber.h: Added.
- bindings/objc/DOMSVGNumber.mm: Added. (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
- bindings/objc/DOMSVGPoint.h: Added.
- bindings/objc/DOMSVGPoint.mm: Added. (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
- bindings/objc/DOMSVGRect.h: Added.
- bindings/objc/DOMSVGRect.mm: Added. (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
- bindings/scripts/CodeGeneratorObjC.pm:
- ksvg2/svg/SVGAnimatedNumberList.idl:
- ksvg2/svg/SVGAnimatedRect.idl:
- ksvg2/svg/SVGComponentTransferFunctionElement.idl:
- ksvg2/svg/SVGCursorElement.idl:
- ksvg2/svg/SVGFEBlendElement.idl:
- ksvg2/svg/SVGFEColorMatrixElement.idl:
- ksvg2/svg/SVGFEComponentTransferElement.idl:
- ksvg2/svg/SVGFECompositeElement.idl:
- ksvg2/svg/SVGFEDiffuseLightingElement.idl:
- ksvg2/svg/SVGFEDisplacementMapElement.idl:
- ksvg2/svg/SVGFEDistantLightElement.idl:
- ksvg2/svg/SVGFEFloodElement.idl:
- ksvg2/svg/SVGFEFuncAElement.idl:
- ksvg2/svg/SVGFEFuncBElement.idl:
- ksvg2/svg/SVGFEFuncGElement.idl:
- ksvg2/svg/SVGFEFuncRElement.idl:
- ksvg2/svg/SVGFEGaussianBlurElement.idl:
- ksvg2/svg/SVGFEImageElement.idl:
- ksvg2/svg/SVGFEMergeElement.idl:
- ksvg2/svg/SVGFEMergeNodeElement.idl:
- ksvg2/svg/SVGFEOffsetElement.idl:
- ksvg2/svg/SVGFEPointLightElement.idl:
- ksvg2/svg/SVGFESpecularLightingElement.idl:
- ksvg2/svg/SVGFESpotLightElement.idl:
- ksvg2/svg/SVGFETileElement.idl:
- ksvg2/svg/SVGFETurbulenceElement.cpp:
- ksvg2/svg/SVGFETurbulenceElement.h:
- ksvg2/svg/SVGFETurbulenceElement.idl:
- ksvg2/svg/SVGNumberList.idl:
- 5:21 AM Changeset in webkit [16849] by
-
- 3 edits in S60/trunk/WebCore
2006-10-05 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
http://bugs.webkit.org/show_bug.cgi?id=11170
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
- kwq/KWQKHTMLPart.h:
- 4:18 AM Changeset in webkit [16848] by
-
- 4 edits in trunk/WebKit
Reviewed by Adam.
- fixed the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"
Possibly more.
- Loader/WebDocumentLoadState.h:
- Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState actualRequest]): New method.
- WebView/WebDataSource.m: (-[WebDataSource _startLoading]): We need to make sure not to start loading the main resource with the fake external request for an applewebdata: request.
- 3:30 AM Changeset in webkit [16847] by
-
- 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp
Fix win32 bustage.
- 3:28 AM Changeset in webkit [16846] by
-
- 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp
Fix win32 bustage.
- 3:22 AM Changeset in webkit [16845] by
-
- 5 edits in trunk/WebCore
Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.
- 3:18 AM Changeset in webkit [16844] by
-
- 3 edits in trunk/WebCore
Backing out my previous change.
- WebCore.xcodeproj/project.pbxproj:
- page/FrameView.cpp: (WebCore::FrameView::adjustViewSize):
- 3:18 AM Changeset in webkit [22320] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix open source build bustage by moving windowResizerRect into ScrollViewWin.
- 3:17 AM Changeset in webkit [16843] by
-
- 3 edits in trunk/WebCore
Fix build bustage like... everywhere.
- 3:06 AM Changeset in webkit [16842] by
-
- 3 edits in trunk/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj:
- page/FrameView.cpp: (WebCore::FrameView::windowResizerRect):
- 3:01 AM Changeset in webkit [16841] by
-
- 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp
Fix win32 bustage.
- 2:48 AM Changeset in webkit [22319] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Maciej.
Some loader improvements, courtesy of Steve.
Functionally, the improvements are these:
- Support HTTP Authentication
- Respect WinInet errors better
There are also some general code cleanups, like extracting the creation
of an HTTP request into its own method.
- platform/win/ResourceLoaderWin.cpp: Add dwError field to JobLoadStatus to store WinInet error codes. Also removed the globalInternetHandle() function as the global HINTERNET is now only needed within startHTTPRequest. (WebCore::ResourceLoaderWndProc): Respect error codes and add HTTP Authentication support. Also, process HTTP status codes as ints instead of strings. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): Cleanup m_formData (WebCore::transferJobStatusCallback): Cleanup the code, and set dwError. (WebCore::ResourceLoader::startHTTPRequest): New method to start a new HTTP request. (WebCore::ResourceLoader::start): Restructure code.
- 2:43 AM Changeset in webkit [16840] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
More loader tweaks.
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::newHTTPRequest):
- 2:16 AM Changeset in webkit [22318] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix cnn.com plugins. Fix a crash from not unparenting scrollbars of a scrollview in its destructor.
- 1:23 AM Changeset in webkit [22317] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix plugins being mispositioned on osnews.com
- 12:50 AM Changeset in webkit [22316] by
-
- 12 edits in branches/WindowsMerge
2006-10-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Allow window to be resized via the gripper (bottom right rect adjacent to scrollbars).
Add a method to reset the candidate URLs when a page load completes.
Add implementations for resizer related UI delegate callbacks.
Move gripper drawing into DrawingUtilities.
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Scrollbars now dodge resizing gripper.
Resizing gripper now paints via web ui delegate.
Debug vcproj fixes.
Fix redirects to search.com.
Add support for painting and cursor tracking of resizer.
- Interfaces/IWebUIDelegatePrivate.idl: added webViewDrawResizer.
- WebFrame.cpp: (WebFrame::paint): added gripper drawing code. (WebFrame::receivedResponse): tell the app when we commit a page load. (WebFrame::windowResizerRect): added. (WebFrame::paintGripper): added.
- WebFrame.h: added windowResizerRect, paintGripper.
- WebKit.vcproj/WebKit.vcproj: Link against debug libs, debug MSVC library in debug build.
- WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::inResizer): (WebViewWndProc): (WebView::setUIDelegate):
- WebView.h:
2006-10-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Scrollbars now dodge resizing gripper.
- bridge/win/FrameViewWin.cpp: (WebCore::FrameView::windowResizerRect): added.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::windowResizerRect): added.
- bridge/win/FrameWin.h:
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Scrollbars now dodge resizing gripper.
- 12:44 AM Changeset in webkit [16839] by
-
- 7 edits in trunk/WebCore
2006-10-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Stub out some methods that we'll be able to use to dodge a window resizer.
- bridge/win/FrameWin.h:
- page/Frame.h: (WebCore::Frame::windowResizerRect):
- page/FrameView.h:
- platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect):
- platform/Widget.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameView::windowResizerRect): (Widget::setParent): (Widget::parent): (FrameWin::windowResizerRect):
Oct 5, 2006:
- 11:19 PM Changeset in webkit [22315] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix scrollview resizing to do updatescrollbars even for iframes. Matches Mac better and makes iframes stop showing scrollbars when they shouldn't.
- 11:14 PM Changeset in webkit [16838] by
-
- 2 edits in trunk/WebCore
Stub out setFrameGeometry.
- 10:53 PM Changeset in webkit [22314] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/win/GraphicsContextWin.cpp
Implement proper clipping and transforms for themed form controls.
- 10:45 PM Changeset in webkit [22313] by
-
- 6 edits in branches/WindowsMerge
Implement proper clipping and transforms for themed form controls.
- 10:30 PM Changeset in webkit [16837] by
-
- 1 edit in trunk/WebCore/platform/cg/GraphicsContextCG.cpp
Temporary hack.
- 10:18 PM Changeset in webkit [16836] by
-
- 5 edits in trunk/WebCore
Reverting autoscroll fix. I need to rework this a little.
- page/Frame.cpp: (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::stopAutoscrollTimer):
- page/Frame.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox):
- 9:48 PM Changeset in webkit [16835] by
-
- 2 edits in trunk/WebKitTools
2006-10-05 Oliver Hunt <ohunt@apple.com>
Reviewed by Anders.
- Scripts/run-webkit-tests: Fix pixel tests.
- 8:57 PM Changeset in webkit [16834] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Fixed <rdar://problem/4731778>
- editing/CommandByName.cpp: (WebCore::Frame::Command::): was calling the wrong enabledFn for arrow selection and navigation
- 8:34 PM Changeset in webkit [16833] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
- Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text"> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
- page/Frame.cpp: Added getter and setter for the renderer being autoscrolled. (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::autoscrollRenderer): (WebCore::Frame::setAutoscrollRenderer): (WebCore::Frame::stopAutoscrollTimer):
- page/Frame.h:
- 7:48 PM Changeset in webkit [16832] by
-
- 7 edits in trunk/WebCore
2006-10-05 Don Gibson <dgibson77@gmail.com>
Reviewed by Eric.
Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- platform/Widget.h:
- platform/win/PlatformScrollBar.h:
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
- platform/win/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
- platform/win/WidgetWin.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setContainingWindow): (WebCore::Widget::containingWindow):
- 6:23 PM Changeset in webkit [16831] by
-
- 5 edits in trunk/WebKit
Reviewed by the letter 'B'.
More build fixes.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):
- WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
- 6:03 PM Changeset in webkit [22312] by
-
- 2 edits in branches/WindowsMerge/WebCore
build fix.
- platform/win/WidgetWin.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::removeFromParent):
- 6:01 PM Changeset in webkit [16830] by
-
- 14 edits in trunk/WebCore
build fix.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
- bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar):
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge installInFrame:]):
- bridge/mac/WebCoreFrameView.h:
- platform/ScrollBar.cpp:
- platform/Widget.h:
- platform/mac/PlatformScrollBar.h:
- platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollbar:]): (-[WebCoreScrollBar detachPlatformScrollbar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::scrollbarHit): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::scrollbarUnderMouse):
- platform/mac/WidgetMac.mm: (WebCore::Widget::removeFromParent):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar):
- 5:02 PM Changeset in webkit [16829] by
-
- 2 edits in trunk/WebKitSite
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by Tim H.
- coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors
- 4:16 PM Changeset in webkit [22311] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKitGUID.vcproj
Correct a build break when the build directory is outside the source tree.
- 3:58 PM Changeset in webkit [16828] by
-
- 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip
Fix runtime break introduced in r16809: added RecentUrlStore.dll
- 3:38 PM Changeset in webkit [22310] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp
Fix addClip->clip renaming bustage.
- 3:26 PM Changeset in webkit [16827] by
-
- 1 edit4 adds in trunk/WebCore
2006-10-06 Mitz Pettel <mitz@webkit.org>
http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.
Add resource forks for test resources.
- manual-tests/resources/plain-text-paste/._1.textClipping: Added.
- manual-tests/resources/plain-text-paste/._2.textClipping: Added.
- manual-tests/resources/plain-text-paste/._4.txt: Added.
- manual-tests/resources/plain-text-paste/._5.webloc: Added.
- 3:21 PM Changeset in webkit [22309] by
-
- 2 edits in branches/WindowsMerge/WebCore
Stub out GraphicsContextPlatformPrivate methods so that the HDC can
be updated when clips/transforms are applied.
Reviewed by darin
- platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- 3:19 PM Changeset in webkit [22308] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog
Build fix.
- WebKit.vcproj/WebKitGUID.vcproj: Fix patch to IWebFramePrivate_i.c
- 3:16 PM Changeset in webkit [22307] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::BrowserExtensionWin): Change Frame* to FrameWin*
- 3:14 PM Changeset in webkit [16826] by
-
- 18 edits in trunk/WebCore
Rename addClip to clip.
Reviewed by darin
- kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
- kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- platform/GraphicsContext.h:
- platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
- platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM):
- platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addRoundedRectClip):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
- rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::setClip):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- 3:11 PM Changeset in webkit [22306] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix. Remove RenderImageButton.{h,cpp}.
- WebCore.vcproj/WebCore.vcproj:
- 3:03 PM Changeset in webkit [16825] by
-
- 4 edits2 deletes in trunk/WebCore
2006-10-05 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=10386 Delete RenderImageButton.* and remove references from .vcproj and .bkl files
- CMakeLists.txt:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCoreSources.bkl:
- rendering/RenderImageButton.cpp: Removed.
- rendering/RenderImageButton.h: Removed.
- 2:56 PM Changeset in webkit [16824] by
-
- 2 edits in trunk/WebCore
2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=11067 manual-tests/scrollbar-hittest2.html is invalid
- manual-tests/scrollbar-hittest2.html:
- 2:53 PM Changeset in webkit [16823] by
-
- 3 edits in trunk/WebKit
2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Timothy.
Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.
- WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
- WebView/WebView.m: (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults (-[WebView setContinuousSpellCheckingEnabled:]): (-[WebView isContinuousSpellCheckingEnabled]):
- 2:43 PM Changeset in webkit [16822] by
-
- 2 edits in trunk/WebKit
2006-10-05 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
- COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedResponse):
- 2:40 PM Changeset in webkit [16821] by
-
- 3 edits in trunk/WebCore
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.
- html/HTMLTokenizer.cpp:
- config.h:
- 2:38 PM Changeset in webkit [16820] by
-
- 2 edits in trunk/WebCore
Removing accidentally-checked-in do-nothing code.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- 2:35 PM Changeset in webkit [16819] by
-
- 2 edits in trunk/WebCore
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
- 2:33 PM Changeset in webkit [22305] by
-
- 9 edits1 add in branches/WindowsMerge/WebKitWin
2006-10-05 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
A couple of changes needed for the new DumpRenderTree.
- DOMCoreClasses.cpp: (DOMDocument::documentElement): Implement.
- DOMHTMLClasses.cpp: (DOMHTMLElement::innerHTML): (DOMHTMLElement::setInnerHTML): (DOMHTMLElement::innerText): (DOMHTMLElement::setInnerText):
- DOMHTMLClasses.h: (DOMHTMLFormElement::innerHTML): (DOMHTMLFormElement::setInnerHTML): (DOMHTMLFormElement::innerText): (DOMHTMLFormElement::setInnerText): (DOMHTMLSelectElement::innerHTML): (DOMHTMLSelectElement::setInnerHTML): (DOMHTMLSelectElement::innerText): (DOMHTMLSelectElement::setInnerText): (DOMHTMLOptionElement::innerHTML): (DOMHTMLOptionElement::setInnerHTML): (DOMHTMLOptionElement::innerText): (DOMHTMLOptionElement::setInnerText): (DOMHTMLInputElement::innerHTML): (DOMHTMLInputElement::setInnerHTML): (DOMHTMLInputElement::innerText): (DOMHTMLInputElement::setInnerText): (DOMHTMLTextAreaElement::innerHTML): (DOMHTMLTextAreaElement::setInnerHTML): (DOMHTMLTextAreaElement::innerText): (DOMHTMLTextAreaElement::setInnerText):
- Interfaces/DOMHTML.idl: Implement innerText and add stubs for innerHTML, setInnerHTML and setInnerText.
- Interfaces/IWebFramePrivate.idl: Added.
- WebFrame.cpp: (WebFrame::QueryInterface): (WebFrame::renderTreeAsExternalRepresentation): (WebFrame::receivedAllData): Call Frame::end() before calling the frame load delegate methods. This matches the mac behavior.
(WebFrame::didFirstLayout):
(WebFrame::handledOnloadEvents):
Add null checks for frameLoadDelegatePriv, all clients might not use it.
- WebFrame.h:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj: Add new interface, IWebFramePrivate, which supports getting the render tree as text.
- 1:27 PM Changeset in webkit [16818] by
-
- 7 edits in trunk
2006-10-05 Don Gibson <dgibson77@gmail.com>
WebCore:
Reviewed by Darin, landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.
- platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::start):
WebKit:
Reviewed by Darin, landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.
- COM/WebFrame.cpp: (WebFrame::loadDataSource):
- 1:22 PM Changeset in webkit [16817] by
-
- 10 edits1 add in trunk
2006-10-05 Marvin Decker <marv.decker@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10989
Provide a way for embedders to implement BrowserExtensionWin
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/BrowserExtensionWin.cpp: Added. (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL):
- bridge/win/BrowserExtensionWin.h:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp:
WebKit:
- COM/Interfaces/IWebUIDelegate.idl:
- COM/WebFrame.cpp: (WebFrame::createNewWindow):
- COM/WebFrame.h:
- 1:17 PM Changeset in webkit [16816] by
-
- 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip
More break fixes: updating Toolbar.* in S60/S60Internals/S60DynamicLibs.zip
- 1:01 PM Changeset in webkit [22304] by
-
- 4 edits in branches/WindowsMerge/WebCore
Reviewed by Darin.
Fixed <rdar://problem/4766987>
- renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.
- fixed RenderLayer to properly tear down scrollbars, removing them from their parents.
- bridge/win/FrameViewWin.cpp: (WebCore::FrameView::passMousePressEventToScrollbar):
- platform/win/PlatformScrollBar.h: (WebCore::):
- platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::invalidateTrack): (WebCore::PlatformScrollbar::invalidatePart): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::backButtonRect): (WebCore::PlatformScrollbar::forwardButtonRect): (WebCore::PlatformScrollbar::trackRect): (WebCore::PlatformScrollbar::thumbRect): (WebCore::PlatformScrollbar::gripperRect): (WebCore::PlatformScrollbar::splitTrack): (WebCore::PlatformScrollbar::thumbPosition): (WebCore::PlatformScrollbar::thumbLength): (WebCore::PlatformScrollbar::trackLength): (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb): (WebCore::PlatformScrollbar::paintGripper): (WebCore::PlatformScrollbar::hitTest): (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent): (WebCore::PlatformScrollbar::startTimerIfNeeded): (WebCore::PlatformScrollbar::stopTimerIfNeeded): (WebCore::PlatformScrollbar::autoscrollPressedPart): (WebCore::PlatformScrollbar::autoscrollTimerFired): (WebCore::PlatformScrollbar::pressedPartScrollDirection): (WebCore::PlatformScrollbar::pressedPartScrollGranularity): (WebCore::PlatformScrollbar::thumbUnderMouse): (WebCore::PlatformScrollbar::themeChanged): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::themeChanged):
- 12:59 PM Changeset in webkit [16815] by
-
- 21 edits in trunk/WebCore
Reviewed by Darin.
Fixed <rdar://problem/4766987>
- renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.
- fixed RenderLayer to properly tear down scrollbars, removing them from their parents.
- bindings/js/kjs_window.cpp: (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures):
- bridge/BrowserExtension.h:
- dom/Document.cpp: (WebCore::Document::setInPageCache):
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute):
- html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::scrollingMode):
- page/Frame.cpp: (WebCore::Frame::finishedParsing): (WebCore::Frame::scrollbarsVisible):
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): (WebCore::FrameView::handleMousePressEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::scrollbarMoved):
- page/FrameView.h:
- page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
- page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
- platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
- platform/ScrollBar.h: (WebCore::): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::Scrollbar::~Scrollbar): (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::controlSize): (WebCore::Scrollbar::hasPlatformScrollbars): (WebCore::Scrollbar::client):
- platform/ScrollBarMode.h: (WebCore::):
- platform/ScrollView.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::horizontaScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::verticalScrollbarWidth): (WebCore::RenderLayer::horizontalScrollbarHeight): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::valueChanged):
- rendering/RenderListBox.h:
- rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):
- 12:58 PM Changeset in webkit [16814] by
-
- 2 edits in trunk/WebKitTools
2006-10-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
- Scripts/run-webkit-tests: Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test results should be.
- 12:38 PM Changeset in webkit [16813] by
-
- 2 edits in trunk/WebKitTools
2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Cmake: make it possible to install the libraries after having built using 'build-webkit'.
Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.
- Scripts/webkitdirs.pm:
- 11:27 AM Changeset in webkit [16812] by
-
- 2 edits in S60/trunk/S60Internals
Fix build break introduced in r16809 by updating toolbar.h in S60Headers.zip
- 10:57 AM Changeset in webkit [16811] by
-
- 2 edits in trunk/WebCore
2006-10-05 Don Gibson <dgibson77@gmail.com>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11138
Incorrect mouse event generation on Windows
- platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): (1) Set mouse button even for non-click-related messages. (2) Track clicks correctly for all buttons, not just the left button.
- 10:48 AM Changeset in webkit [16810] by
-
- 8 edits in trunk/WebCore
2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fix Qt/Linux build, adapt to Eric's Quartz changes and to Maciej's ResourceLoader changes.
- kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::renderPath): (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
- kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: (WebCore::KRenderingPaintServerPatternQt::renderPath):
- kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
- kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup): (WebCore::KRenderingPaintServerSolidQt::renderPath):
- kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke):
- 10:37 AM Changeset in webkit [16809] by
-
- 5 edits in S60/trunk/WebKit
2006-10-05 raalexan <rasvan.alexandrescu@nokia.com>
Reviewed by Zhang Yongjun.
DESC: Enable touch ui on browser toolbar
http://bugs.webkit.org/show_bug.cgi?id=11156
- BrowserView/inc/PointerEventHandler.h:
- BrowserView/inc/WebKitView.h:
- BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL):
- BrowserView/src/WebKitView.cpp: (CWebKitView::LaunchToolBarL): (CWebKitView::NodeUnderPointer):
- 10:20 AM Changeset in webkit [16808] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Kevin McCullough.
- wtf/Assertions.cpp: Fix build when _DEBUG is not defined.
- 9:44 AM Changeset in webkit [16807] by
-
- 3 edits23 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11054
REGRESSION: Traditional Chinese encoding in login authentication
- Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
- On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
WebCore:
- platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
LayoutTests:
Each of these tests is passed by Firefox 1.5 and/or WinIE 6.
- fast/encoding/GBK/EUC-CN-expected.txt: Added.
- fast/encoding/GBK/EUC-CN.html: Added.
- fast/encoding/GBK/chinese-expected.txt: Added.
- fast/encoding/GBK/chinese.html: Added.
- fast/encoding/GBK/cn-gb-expected.txt: Added.
- fast/encoding/GBK/cn-gb.html: Added.
- fast/encoding/GBK/csgb2312-expected.txt: Added.
- fast/encoding/GBK/csgb2312.html: Added.
- fast/encoding/GBK/csgb231280-expected.txt: Added.
- fast/encoding/GBK/csgb231280.html: Added.
- fast/encoding/GBK/gb2312-expected.txt: Added.
- fast/encoding/GBK/gb2312.html: Added.
- fast/encoding/GBK/gb_2312-80-expected.txt: Added.
- fast/encoding/GBK/gb_2312-80.html: Added.
- fast/encoding/GBK/gbk-expected.txt: Added.
- fast/encoding/GBK/gbk.html: Added.
- fast/encoding/GBK/iso-ir-58-expected.txt: Added.
- fast/encoding/GBK/iso-ir-58.html: Added.
- fast/encoding/GBK/x-euc-cn-expected.txt: Added.
- fast/encoding/GBK/x-euc-cn.html: Added.
- fast/encoding/GBK/x-gbk-expected.txt: Added.
- fast/encoding/GBK/x-gbk.html: Added.
- 6:59 AM Changeset in webkit [16806] by
-
- 2 edits1 delete in trunk/WebCore
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
Removed dead code.
Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
- WebCore.xcodeproj/project.pbxproj:
- ksvg2/ecma/GlobalObject.cpp: Removed.
- ksvg2/ecma/GlobalObject.h: Removed.
- 6:56 AM Changeset in webkit [22303] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Maciej.
Fixes <rdar://problem/4757387>
Unable to sign on to my.yahoo.com
This patch fixes a number of bugs that all resulted in not being able
to log on to many websites. The problems were that we weren't allowing
redirects between HTTP and HTTPS sites and weren't correctly handling
redirects from POST requests to GET requests.
- platform/win/ResourceLoaderWin.cpp: (WebCore::globalInternetHandle): Move internetHandle and callbackHandle into file scope, and add this function to initialize them. (WebCore::logLastError): Add this debug logging function to give more readable WinInet error messages. (WebCore::ResourceLoaderWndProc): The most substantial change here is to allow redirects from POST to GET to function correctly. To do this we have to create a new HINTERNET for the GET. We also have to be sure not to try to read from our now-invalid handles after the redirect. (WebCore::transferJobStatusCallback): Rename timerId to jobId, since that's what it is. (WebCore::ResourceLoader::start): Call new static initializer, and pass flags to allow HTTP<->HTTPS redirects. Also change a few delete calls to kill().
- 6:54 AM Changeset in webkit [16805] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Small ResourceLoaderInternal tweak.
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- 6:52 AM Changeset in webkit [16804] by
-
- 26 edits in trunk/WebCore
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
More incremental KCanvas cleanup and optimization.
Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
Optimized dash array usage to not malloc.
Also removed un-needed KSVGRenderingStyle includes.
- kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
- kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
- kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
- kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
- kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
- kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
- ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
- ksvg2/misc/KCanvasRenderingStyle.h:
- 6:15 AM Changeset in webkit [16803] by
-
- 13 edits in trunk/WebCore
Reviewed by Adam.
- changed ResourceLoader to be refcounted
It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.
- bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- loader/icon/IconLoader.cpp: (IconLoader::IconLoader): (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
- loader/icon/IconLoader.h:
- loader/loader.cpp: (WebCore::Loader::servePendingRequests):
- platform/ResourceLoader.cpp: (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::kill):
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
- xml/xmlhttprequest.h:
- 5:59 AM Changeset in webkit [16802] by
-
- 5 edits in trunk/WebCore
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
http://bugs.webkit.org/show_bug.cgi?id=11163
No SVG performance tests yet.
- kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
- kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
- 5:51 AM Changeset in webkit [22302] by
-
- 6 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Adam.
- changed ResourceLoader to be refcounted
It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.
In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.
This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com
- platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
- plugins/win/PluginStreamWin.h:
WebKitWin:
Reviewed by Adam.
- changed ResourceLoader to be refcounted
It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.
In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.
This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com
- WebFrame.cpp: (WebFrame::loadDataSource):
- 2:03 AM Changeset in webkit [22301] by
-
- 7 edits in branches/WindowsMerge
Make key events get delivered properly to iframes and frames.
- 1:58 AM Changeset in webkit [16801] by
-
- 4 edits in trunk/WebCore
Widget focusability work.
Note:
See TracTimeline
for information about the timeline view.
