Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Dec 5, 2006:

7:49 PM Changeset in webkit [22623] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:42 PM Changeset in webkit [18040] by sfalken

• 1 copy in tags/Safari-521.31.5b

New tag.

6:16 PM Changeset in webkit [22622] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Don't delete the internal pointer anymore since it's an OwnPtr now.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::~ResourceHandle):

6:09 PM Changeset in webkit [18039] by andersca

• 7 edits in trunk/WebCore

Reviewed by Maciej.

General cleanup, get rid of PlatformResponse (we have ResourceResponse now)
and remove a couple of functions that were unused.

• loader/CachedResource.h:
• loader/LoaderFunctions.h:
• loader/mac/LoaderFunctionsMac.mm:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle):

6:01 PM Changeset in webkit [18038] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by John.

• keydown is now a keydown event instead of a keypress event. Fixes some form submission odditties.

• platform/win/KeyEventWin.cpp:

5:20 PM Changeset in webkit [18037] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-12-05 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix for tabbed navigation
​http://bugs.webkit.org/show_bug.cgi?id=11757

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):

5:11 PM Changeset in webkit [22621] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

Fix the build

• platform/win/TemporaryLinkStubs.cpp:

4:18 PM Changeset in webkit [18036] by sullivan

• 2 edits in trunk/WebCore

Tiger build fix

• editing/mac/EditorMac.mm: declare -[NSSpellChecker learnWord:], on Tiger only (it's API on Leopard)

4:08 PM Changeset in webkit [22620] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
...and add ImageAnimationObserver.h into its new location.

• WebCore.vcproj/WebCore.vcproj:

4:03 PM Changeset in webkit [22619] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
Remove ImageAnimationObserver.h from vcproj.

• WebCore.vcproj/WebCore.vcproj:

3:56 PM Changeset in webkit [22618] by sullivan

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff Garen

Changes to keep up with Frame -> Editor changes in WebCore

• bridge/win/FrameWin.h: remove ignoreSpelling() and learnSpelling()

• platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::ignoreSpelling): moved from FrameWin to Editor (WebCore::Editor::learnSpelling): ditto

3:48 PM Changeset in webkit [18035] by sullivan

• 7 edits in trunk/WebCore

Reviewed by Geoff Garen

• page/Frame.h: remove declarations of ignoreSpelling() and learnSpelling()

• bridge/mac/FrameMac.h: remove declarations of ignoreSpelling() and learnSpelling()
• bridge/mac/FrameMac.mm: moved implementations of ignoreSpelling() and learnSpelling() from here

• editing/Editor.h: added declarations of ignoreSpelling() and learnSpelling()

• editing/mac/EditorMac.mm: (WebCore::Editor::ignoreSpelling): moved here from FrameMac.mm (WebCore::Editor::learnSpelling): ditto

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): updated callers to use frame()->editor() rather than frame()

3:18 PM Changeset in webkit [22617] by sfalken

• 4 edits
  5 adds in branches/WindowsMerge/WebKitWin

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

3:15 PM Changeset in webkit [18034] by sfalken

• 2 edits in trunk/WebKitTools

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Make extract-localizable-strings compatible with cpp file extensions.

• Scripts/extract-localizable-strings:

2:34 PM Changeset in webkit [18033] by sullivan

• 5 edits in trunk

WebCore:

Reviewed by Adam

New context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Leave out "No Guesses Found" and separator for grammar-checking case.

WebKit:

Reviewed by Adam

Old context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Leave out "No Guesses Found" and separator for grammar-checking case.

1:50 PM Changeset in webkit [22616] by aliceli1

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• platform/win/CursorWin.cpp: (WebCore::copyCursor):

1:47 PM Changeset in webkit [18032] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11686
WebKit draws Carto.net tabgroup example completely incorrectly (ff does fine)

Make sure the SVG render objects are laid out before measuring their
dimensions using relativeBBox.

1:24 PM Changeset in webkit [18031] by sullivan

• 5 edits in trunk/WebCore

Reviewed by Darin

Grammar/Spelling code re-homing, baby step one: put isGrammarCheckingEnabled in Editor
since that's where isContinousSpellCheckingEnabled lives.

• editing/Editor.h:
• editing/Editor.cpp: (WebCore::Editor::isGrammarCheckingEnabled): new method, calls through to client a la isContinuousSpellCheckingEnabled

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): call editor() rather than editor()->client() (WebCore::FrameMac::markMisspellings): ditto

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): ditto

1:22 PM Changeset in webkit [22615] by aliceli1

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• bridge/win/FrameWin.h: added missing declarations for the functions in John's checkin, below.

1:08 PM Changeset in webkit [18030] by darin

• 6 edits
  1 delete in trunk/WebCore

Reviewed by Geoff.

• a little cleanup

• html/HTMLInputElement.h: Removed unneeded includes of RenderObject.h and RenderStyle.h.
• html/HTMLSelectElement.h: Removed unneeded include of RenderStyle.h.
• ksvg2/svg/SVGStyledElement.h: Removed unneeded include of RenderStyle.h.

• ksvg2/svg/SVGSVGElement.h: Remove unneeded parameter to createSVGPoint.
• ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGPoint): Ditto.

• ksvg2/scripts/generateJSBindings.pl: Removed unused script.

11:58 AM Changeset in webkit [18029] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Layout messed up when changing zoomlevel while typing text in input box
​http://bugs.webkit.org/show_bug.cgi?id=11708

• BrowserView/src/WebKitView.cpp: (CWebKitView::ZoomL): (CWebKitView::SetCurrentZoomLevelIndex): (CWebKitView::ZoomLevelChanged):

11:50 AM Changeset in webkit [18028] by spadma

• 2 edits in S60/trunk/WebKit

2006-12-05 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Not able to select placeholder for audio download
​http://bugs.webkit.org/show_bug.cgi?id=11755

• Plugin/src/PluginSkin.cpp: (CPluginSkin::IsFocusable):

11:49 AM Changeset in webkit [18027] by darin

• 1 edit
  1 delete in trunk/WebCore

• doc: Removed empty directory. It's not clear this is a good place for documentation, so lets add it back later if we actually start using it.

11:17 AM Changeset in webkit [18026] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Browser scrollbar is blinking, then disappears in RTL pages for 3.1 version.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11733

• BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):

11:08 AM Changeset in webkit [18025] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: Don't move to the scroll bar rect to right if the page is RTL
​http://bugs.webkit.org/show_bug.cgi?id=11733

• WebKit/BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):

11:03 AM Changeset in webkit [18024] by andersca

• 3 edits in trunk/WebCore

Reviewed by Brady, Darin.

• loader/loader.cpp: (WebCore::Loader::receivedAllData): Remove ref() call that was left around by mistake.

11:01 AM Changeset in webkit [18023] by sullivan

• 3 edits in trunk/WebKit

build fix

• WebView/WebViewPrivate.h:
• WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)

10:43 AM Changeset in webkit [22614] by sullivan

• 2 edits in branches/WindowsMerge/WebCore

• platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::isSelectionUngrammatical): (WebCore::FrameWin::guessesForUngrammaticalSelection): added stubs to correspond to new Frame functions

10:40 AM Changeset in webkit [18022] by weinig

• 9 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11758
Don't compile custom SVG and XSLT bindings in non-svg build

• bindings/js/JSSVGNumber.cpp:
• bindings/js/JSSVGNumber.h:
• bindings/js/JSSVGPoint.cpp:
• bindings/js/JSSVGPoint.h:
• bindings/js/JSSVGRect.cpp:
• bindings/js/JSSVGRect.h:
• bindings/js/JSXSLTProcessor.cpp:
• bindings/js/JSXSLTProcessor.h:

10:36 AM Changeset in webkit [18021] by sullivan

• 14 edits in trunk

WebCore:

Reviewed by Darin

WebCore part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Also, some of this code
should move from Frame to Editor, but that will wait for another checkin.

• page/Frame.h: added pure virtual function declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()

• bridge/mac/FrameMac.h: added virtual functions declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::isSelectionMisspelled): now updates spelling panel (whether or not it's showing), since this is now needed to make -[NSSSpellChecker ignoreWord:inSpellDocumentWithTag:] work correctly (WebCore::isRangeUngrammatical): new function, helper used by both isSelectionUngrammatical() and guessesForUngrammaticalSelection() (WebCore::FrameMac::isSelectionUngrammatical): new function, calls isRangeUngrammatical (WebCore::FrameMac::guessesForUngrammaticalSelection): ditto

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): now considers bad grammar as well as misspellings

• platform/ContextMenuItem.h: added ContextMenuItemTagIgnoreGrammar

WebKit:

Reviewed by Darin

WebKit part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
can be deleted when the new mechanism is in place.

• WebView/WebUIDelegatePrivate.h: added WebMenuItemTagIgnoreGrammar

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): added case for WebMenuItemTagIgnoreGrammar (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): now considers adding grammar-related items as well as spelling-related items

• WebView/WebHTMLViewPrivate.h: declared _isSelectionUngrammatical

• WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): new method, calls through to WebCore (-[WebHTMLView _ignoreGrammarFromMenu:]): new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both

• English.lproj/Localizable.strings: updated for "Ignore Grammar" menu item title

4:31 AM Changeset in webkit [18020] by ap

• 3 edits in trunk/WebCore

2006-12-05 Kirby White <​KWhiteRight@gmail.com>

Reviewed, tweaked and landed by Alexey.

<​http://bugs.webkit.org/show_bug.cgi?id=11639> Form buttons don't look different when clicked

• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): Moved test for active state before test for hover state, since active should override hover when both are true.

• platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): Same fix.

2:23 AM Changeset in webkit [18019] by ap

• 3 edits
  3 adds in trunk

2006-12-05 Kirby White <​KWhiteRight@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11681
Don't select the first option when resetting a listbox-style form
control (i.e., a multi-select control or one with size > 1) that
has no default selection.

Test: fast/dom/HTMLSelectElement/listbox-select-reset.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):

12:51 AM Changeset in webkit [18018] by ap

• 2 edits in trunk/LayoutTests

Reviewed by Rob.

Make this test pass on PowerPC, too (the calculation was giving 4.7e-16 instead of zero,
now rounding it to 15 digits).

• svg/custom/getTransformToElement.svg:

12:26 AM Changeset in webkit [18017] by ap

• 9 edits
  1 add in trunk/WebCore

2006-12-05 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11752
[CSS 3] missing support for cursor selector 'copy'

• Resources/copyCursor.png: Added.
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSValueKeywords.in:
• manual-tests/cursor.html:
• page/EventHandler.cpp: (WebCore::selectCursor):
• platform/Cursor.h:
• platform/mac/CursorMac.mm: (WebCore::copyCursor):
• rendering/RenderStyle.h: (WebCore::):

Dec 4, 2006:

10:50 PM Changeset in webkit [18016] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix from last check-in. This line was badbad.

• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::~ContextMenu):

10:33 PM Changeset in webkit [18015] by bdakin

• 3 edits in trunk/WebCore

Reviewed by Geoff.

With the new changes to ContextMenuItems, WebCore context menus
stopped appearing at all. And then when I got them to appear, they
crashed. This fixes both of these problems.

• platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot be nil. This was causing Obj-C to throw an exception preventing the menus from popping up at all.
• platform/mac/ContextMenuMac.mm: (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static MenuTarget so that it is more clear that it is a static and shared WebCoreMenuTarget. (WebCore::ContextMenu::ContextMenu): Initialize the WebCoreMenuTarget's controller in the ContextMenu constructor instead of in getNSMenuItem since the controller will only possibly change when a new ContextMenu has been created. (WebCore::ContextMenu::~ContextMenu): Set the target's controller to 0. (WebCore::getNSMenuItem): A lot of this work is being done other places now. Call new class method on WebCoreMenuTarget to get the shared target. (WebCore::ContextMenu::appendItem): We should not be releasing the menuItem here! This caused the crashes I saw. (WebCore::ContextMenu::insertItem): Same.

7:37 PM Changeset in webkit [18014] by andersca

• 2 edits in trunk/WebCore

Fix the build.

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::~SubresourceLoader): Add back the destructor.

7:17 PM Changeset in webkit [22613] by andersca

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

• WebCore.vcproj/WebCore.vcproj: Add SubresourceClient.h

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Get rid of the receivedResponse call.

(WebCore::didFinishLoading):
Get rid of the receivedAllData call, that's handled by the subresource loader now.

7:07 PM Changeset in webkit [18013] by andersca

• 17 edits
  1 add in trunk/WebCore

Reviewed by Darin.

Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a
standalone class which doesn't need to know about SubresourceLoader.

• WebCore.xcodeproj/project.pbxproj:
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::setDefersLoading):
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFailWithError): (WebCore::SubresourceLoader::receivedAllData):
• loader/SubresourceLoader.h: (WebCore::SubresourceLoader::loaderAsResourceHandleClient): (WebCore::SubresourceLoader::handle):
• loader/SubresourceLoaderClient.h: Added. (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient): (WebCore::SubresourceLoaderClient::willSendRequest): (WebCore::SubresourceLoaderClient::didReceiveResponse): (WebCore::SubresourceLoaderClient::didReceiveData): (WebCore::SubresourceLoaderClient::didFinishLoading): (WebCore::SubresourceLoaderClient::didFailWithError): (WebCore::SubresourceLoaderClient::receivedAllData):
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading): (WebCore::IconLoader::clearLoadingState):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests):
• loader/loader.h:
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::loader):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::willSendRequest): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
• xml/xmlhttprequest.h:

5:36 PM Changeset in webkit [22612] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

• WebCore.vcproj/WebCore.vcproj: Update for new UIEventWithKeyState.cpp file.

5:29 PM Changeset in webkit [18012] by darin

• 12 edits
  3 adds in trunk

LayoutTests:

Reviewed by Adele.

• test the part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window that can easily be tested from the DOM -- this only checks that simulated mouse events from clicking on a link have the key state from the Enter key keyboard event, which is one part of the fix for the bug above

• fast/events/simulated-key-state-expected.txt: Added.
• fast/events/simulated-key-state.html: Added.

WebCore:

Reviewed by Adele.

• fix another part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window

This fixes command-return when the focus is on a link.
Despite the title of the bug, Mitz wanted me to fix both, and I will not
say no to him!

Test: fast/events/simulated-key-state.html

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing false for all the key state in simulated mouse events, pass the state from the first underlying event in the chain that has key state; in the case in the bug, the keyboard event will be the underlying event itself and we'll propagate the alt key modifier to the mouse event, resulting in the effect we want. It's nice that JavaScript also gets to see the proper modifiers in the mouse event.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Added code to pass in an underlying event to dispatchSimulatedClick. After looking at all the other callers, this seems to be the only one that needs to pass an event that is currently passing 0. Also removed the code that only simulated a click when the event has a PlatformKeyboardEvent -- no reason for that and it prevented me from writing a layout test for the fix.

• dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the underlyingEvent chain to find the first event that has key state. This already existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
• dom/UIEventWithKeyState.cpp: Added.

• CMakeLists.txt: Added UIEventWithKeyState.cpp.
• WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
• WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
• WebCoreSources.bkl: Added UIEventWithKeyState.cpp.

• WebCore.exp: Added findEventWithKeyState, used by WebKit.

WebKit:

Reviewed by Adele.

• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Changed to use the new findEventWithKeyState function in WebCore instead of a local function in this file.

4:49 PM Changeset in webkit [18011] by kmccullo

• 11 edits in trunk/WebCore

Reviewed by Darin.

• removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView):
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
• config.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError):
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
• page/Frame.cpp: (WebCore::Frame::setView):
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::mouseDown):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

4:38 PM Changeset in webkit [22611] by kmccullo

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

• removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
• config.h:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):

4:37 PM Changeset in webkit [18010] by ggaren

• 2 edits in trunk/WebKit

Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
part of my last checkin.

We have to turn on support for backward compatibility mode to avoid Dashboard
regressions in the short term.

• WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]):

3:54 PM Changeset in webkit [18009] by ggaren

• 15 edits in trunk

LayoutTests:

Reviewed by Darin Adler.

Removed Dashboard quirk from expected results. Now that we have a Dashboard
quirks mode, there's no reason to keep the old, bad behavior in the browser.

• http/tests/xmlhttprequest/exceptions-expected.txt:
• http/tests/xmlhttprequest/exceptions.html:

WebCore:

Reviewed by Darin Adler.

Added support for Dashboard backward compatibility mode.

• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior of automatically clearing the stroke path buffer after a call to stroke().
• html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas tag being self-closing. (WebCore::HTMLCanvasElement::endTagRequirement): (WebCore::HTMLCanvasElement::tagPriority):
• html/HTMLCanvasElement.h:
• html/HTMLParser.cpp: Ditto. (WebCore::HTMLParser::canvasCreateErrorCheck):
• xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring a call to setRequestHeader() if it preceded a call to open() or followed a call to send(). (WebCore::XMLHttpRequest::setRequestHeader):

WebKit:

Reviewed by Darin Adler.

Added SPI for enabling Dashboard backward compatibility mode. For now,
we enable it unconditionally for Dashboard and Dashcode. Once they
implement specific support for the backward compatibility mode behavior,
we can change that.

Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
to YES in order to turn this code on.

• WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]):
• WebView/WebViewPrivate.h:

3:52 PM Changeset in webkit [22610] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::generalPasteboard): Got rid of s_generalPasteboard. Also removed definition of destructor.

3:43 PM Changeset in webkit [18008] by darin

• 11 edits in trunk

WebCore:

Reviewed by Alice.

• bridge/EditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function. Alice will probably change this so it's not on the editor client any more later.

• editing/Editor.h: Removed "_web_" prefix from C++ userVisibleString member function.
• editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific code from this file.

• editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable. (WebCore::Editor::userVisibleString): Moved this function here.

• platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes. Made Pasteboard noncopyable. Removed use of "protected" where we should be using "private". Removed s_generalPasteboard.
• platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the s_generalPasteboard global. Removed the unused destructor. Updated call to userVisibleString for name change. Tweaked formatting.

WebKit:

Reviewed by Alice.

• WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function.
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString): Ditto.

• WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.

3:34 PM Changeset in webkit [22609] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Geoff.

Get rid of ref() in ResourceHandle::start() and remove all uses of kill().

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceHandle::start):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop):

WebKitWin:

Reviewed by Darin, Geoff.

Don't use ResourceHandle::kill().

• WebFrame.cpp: (WebFrame::stopMainResourceLoad):

3:31 PM Changeset in webkit [22608] by aliceli1

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag. The part of that
function after the drag hysteresis is exceeded remains unimplemented until
drag&drop is implemented.

• page/win/EventHandlerWin.cpp: (WebCore::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
• platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):

WebKitWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag.

• WebView.cpp: (WebView::WebView): Added a data member (WebView::handleMouseEvent): Create the mouse event telling it it activated the webview (WebViewWndProc): Call setMouseActivated upon receiving the relevent message
• WebView.h: (WebView::setMouseActivated): Added this function so that the webview knows if it was brought to the foreground by a mouse event

3:30 PM Changeset in webkit [18007] by aliceli1

• 5 edits in trunk/WebCore

Reviewed by Oliver.

Moved some constants from EventHandlerMac.mm to EventHandler.cpp
Added some platform-specific data members and functions.

• page/EventHandler.cpp:
• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:
• platform/PlatformMouseEvent.h: (WebCore::): (WebCore::PlatformMouseEvent::timestamp): (WebCore::PlatformMouseEvent::activatedWebView): (WebCore::PlatformMouseEvent::type):

3:26 PM Changeset in webkit [18006] by andersca

• 8 edits in trunk/WebCore

Reviewed by Darin, Geoff.

Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
We use RefPtrs to ResourceHandle instead.

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::~IconLoader): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse):
• loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
• loader/loader.h:
• platform/network/ResourceHandle.cpp:
• platform/network/ResourceHandle.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::didFinishLoading):

3:14 PM Changeset in webkit [18005] by bdash

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix: set private attribute on ImageAnimationObserver.h so it is copied into the framework.

2:32 PM Changeset in webkit [18004] by oliver

• 2 edits in trunk/WebCore

2006-12-04 Oliver Hunt <​oliver@apple.com>

Build fix for non-SVG builds

• bindings/js/JSSVGPoint.cpp: (WebCore::JSSVGPointProtoFunc::callAsFunction):

2:31 PM Changeset in webkit [18003] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):

2:00 PM Changeset in webkit [18002] by yongjzha

• 7 edits in S60/trunk/WebKit

2006-12-04 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>.
DESC: [S60] PNIO-6TCGX3: document.referrer doesn't seem to have any value
​http://bugs.webkit.org/show_bug.cgi?id=11735

• BrowserView/inc/WebKitLoader.h: (CWebKitLoader::ReferrerUrl):
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::SetPageUrlL): (CWebKitLoader::SetReferrerUrlL):
• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::IncomingReferrer):
• ChangeLog:
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::RefererUrl):
• ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::ConstructL): (CUrlRequestInfo::SetRefererUrlL):

1:29 PM Changeset in webkit [18001] by darin

• 2 edits in trunk/WebCore

Reviewed by Beth.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11632 AKA <rdar://problem/4858866> REGRESSION (r17770): Overflow areas' scrollbars don't work

No test case added at the moment, but Beth said she'd investigate
adding one after the fact.

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar): Fix obvious-in-retrospect copy and paste error -- call passMouseDownEventToWidget instead of passWheelEventToWidget.

11:37 AM Changeset in webkit [18000] by ap

• 12 edits
  5 adds in trunk

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11738:
Make link clicking work again on Windows.

WebCore:

This re-implements a few functions that used to be part of FrameWin in
their new loader-based locations, and copies a few things from the Mac
and Qt event handling code that aren't strictly necessary but are
pretty simple.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ChromeClientWin.h:
• bridge/win/ContextMenuClientWin.h:
• bridge/win/EditorClientWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::client):
• bridge/win/FrameWin.h:
• loader/win/DocumentLoaderWin.cpp: Added. (WebCore::DocumentLoader::setTitle):
• loader/win/FrameLoaderClientWin.cpp: Added. (WebCore::FrameLoaderClientWin::userAgent):
• loader/win/FrameLoaderClientWin.h:
• loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::setTitle):
• page/win/EventHandlerWin.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoaderClientWin::setTitle):

WebKit:

The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
hasn't actually moved, which were preventing clicks from actually
getting dispatched in many cases. It's a peculiarity of Windows mouse
handling that we receive these at all.

• COM/WebView.cpp: (WebView::WebView): (WebView::mouseMoved):
• COM/WebView.h:

10:49 AM Changeset in webkit [17999] by ap

• 4 edits in trunk/WebCore

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11748:
Windows build bustage.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/ContextMenuItem.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):

10:24 AM Changeset in webkit [17998] by sullivan

• 2 edits
  1 move
  1 add in trunk/WebCore

Reviewed by Anders

Moved EditorMac.mm to its appropriate location

• platform/mac/EditorMac.mm: Removed.
• editing/mac/EditorMac.mm: Added

• WebCore.xcodeproj/project.pbxproj: updated for this change

9:07 AM Changeset in webkit [17997] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Anders

• fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" menu items not displayed in the contextual menu

• WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always returning NO. D'oh!

7:14 AM Changeset in webkit [17996] by yongjzha

• 6 edits in S60/trunk/WebKit

2006-12-01 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Add platform scrollbars support, behind feature flag
​http://bugs.webkit.org/show_bug.cgi?id=11736

• BrowserControl/inc/BrCtl.h: (MBrHistoryInterface::~MBrHistoryInterface): (NONSHARABLE_CLASS): (CBrCtl::WmlEngineInterface):
• BrowserControl/inc/BrCtlScrollingProvider.h: (NONSHARABLE_CLASS):
• BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::DrawScrollbarBackground): (CBrCtl::MopSupplyObject): (CBrCtl::Draw): (CBrCtl::HandleResourceChange):
• BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::NewL): (CBrCtlScrollingProvider::ConstructL): (CBrCtlScrollingProvider::~CBrCtlScrollingProvider): (CBrCtlScrollingProvider::UpdateVScrollBarL): (CBrCtlScrollingProvider::UpdateHScrollBarL): (CBrCtlScrollingProvider::NotifyLayoutChange): (CBrCtlScrollingProvider::VScrollBarWidth): (CBrCtlScrollingProvider::HScrollBarHeight): (CBrCtlScrollingProvider::VScrollBar): (CBrCtlScrollingProvider::HScrollBar): (CBrCtlScrollingProvider::ScrollBarCornerWindow): (CBrCtlScrollingProvider::SetScrollDisplayRect): (CBrCtlScrollingProvider::ResizeBrCtlView): (CBrCtlScrollingProvider::ShiftBrCtlView): (CBrCtlScrollingProvider::HandleScrollEventL): (CBrCtlScrollingProvider::SkinChangedL): (CBrCtlScrollingProvider::DrawBackground):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
• ChangeLog:

1:21 AM Changeset in webkit [17995] by rwlbuis

• 3 edits
  4 adds in trunk

Reviewed by dhyatt.

Patch by pmax.

​http://bugs.webkit.org/show_bug.cgi?id=3280
With LEGEND element, align=right value is not supported
​http://bugs.webkit.org/show_bug.cgi?id=11544
<legend> rendering doesn't take align into account

Allow aligning for legends in both RTL and LTR mode.

Dec 3, 2006:

4:16 PM Changeset in webkit [17994] by bdash

• 2 edits in trunk/WebCore

2006-12-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11730
Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.

• dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.

8:29 AM Changeset in webkit [22607] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

<rdar://4853816> CFNetwork crash on Vista loading any SSL page

Change link order so secur32.dll is initialized prior to its
indirect use in code called by CoreGraphics DllMain.

To help avoid similar problems in the future, I reordered the
imported DLLs by level/dependency so things like CoreFoundation
is listed prior to CFNetwork and CoreGraphics.

• WebKit.vcproj/WebKit.vcproj:

5:36 AM Changeset in webkit [17993] by zimmermann

• 13 edits
  16 adds in trunk

Reviewed by Oliver.

Fix following bugs:
​http://bugs.webkit.org/show_bug.cgi?id=11734
​http://bugs.webkit.org/show_bug.cgi?id=11685

SVGPoint/SVGRect/SVGNumber were missing put() support.
SVGPoint.matrixTransform() was missing.

4:19 AM Changeset in webkit [17992] by zimmermann

• 2 edits
  1 move in trunk/WebCore

Reviewed by Dave.
Another missing piece in the platform/graphics move.

4:02 AM Changeset in webkit [17991] by rwlbuis

• 10 edits
  4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11667
SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

Implement getTransformToElement functionality. Introduce virtual
baseclass SVGLocatable to allow one implementation of the functionality.
Finally cleanup some code.

3:55 AM Changeset in webkit [17990] by zimmermann

• 3 edits
  2 moves in trunk/WebCore

Reviewed by Rob.
Move some files around, which have been forgotton in the platform/graphics move.

3:39 AM Changeset in webkit [17989] by zimmermann

• 3 edits in trunk/WebCore

Reviewed by Mitz.
Fix non-svg build. (At least hope BuildBot doesn't moan anymore :-)

1:07 AM Changeset in webkit [17988] by ap

• 4 edits in trunk/LayoutTests

Reviewed by Mitz.

This test used to be a pixel one, but without pixel results provided - converted to text.

• http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
• http/tests/xmlhttprequest/frame-load-cancelled-abort.html:

• http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added a parameter to send() to make the test work in Firefox.

Dec 2, 2006:

6:48 AM Changeset in webkit [17987] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

• bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code

6:02 AM Changeset in webkit [17986] by ap

• 3 edits
  4 adds in trunk

2006-12-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11672 REGRESSION (r17068): Repro crash due to painting without layout

Test: fast/dynamic/containing-block-change.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.

5:41 AM Changeset in webkit [17985] by ap

• 3 edits in trunk/WebCore

2006-12-02 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

• platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
• platform/String.cpp: (WebCore::String::format):

Dec 1, 2006:

6:52 PM Changeset in webkit [22606] by bdakin

• 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. Also some
adjustments to make ContextMenuItem class a wrapper for the
platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)

• WebCore.vcproj/WebCore.vcproj:
• platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::insertItem):

WebKitWin:

Reviewed by Adam.

Changes to support sub-menus for WebCore ContextMenus.

• Interfaces/IWebUIDelegate.idl: New tags.
• WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): ContextMenu::menu () is now called parentMenu()

6:35 PM Changeset in webkit [17984] by bdakin

• 12 edits
  1 add in trunk

WebCore:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. This also re-
architects the ContextMenuItem class so that it is more like
ContextMenu in that the class is now really just a wrapper for the
platformDescription

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Add place-holders for new tags for the sub-menu items. I will flesh these out in a separate check-in.
• platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate): Call the above functions to add the appropriate sub-menus to editing context menus.
• platform/ContextMenu.h:
• platform/ContextMenuItem.h: (WebCore::): New tags in the ContextMenuAction enumeration. (WebCore::ContextMenuItem::parentMenu): (WebCore::ContextMenuItem::setType):
• platform/PlatformMenuDescription.h: Added. This defines PlatformMenuDesciption. It needs to be its own header because we

have to include it from ContextMenu.h and ContextMenuItem.h

• platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to make this class basically just be a wrapper for NSMenuItem. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::getNSMenuItem): Now we only have to get the platformDescription of the ContextMenuItem and then set its target and action. (WebCore::ContextMenu::itemCount):

WebKit:

Reviewed by Adam.

Changes to support sub-menus in WebCore ContextMenus.

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): ContextMenuItem::menu() is now called parentMenu()
• WebView/WebUIDelegatePrivate.h: New not-yet-API tags.

4:36 PM Changeset in webkit [17983] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by .

• accidentally checked in with previous checkin

• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

4:23 PM Changeset in webkit [17982] by kmccullo

• 5 edits in trunk/WebCore

Reviewed by Adam.

• better solution to the ambiguous reference

• platform/Widget.h: (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
• platform/win/PlatformScrollBar.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

3:40 PM Changeset in webkit [17981] by justing

• 58 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

Removed unnecessary shouldChangeSelection calls;

• editing/deleting/delete-at-start-or-end-expected.txt:
• editing/deleting/delete-br-002-expected.txt:
• editing/deleting/delete-br-004-expected.txt:
• editing/deleting/delete-br-005-expected.txt:
• editing/deleting/delete-br-006-expected.txt:
• editing/deleting/delete-br-009-expected.txt:
• editing/deleting/delete-br-010-expected.txt:
• editing/deleting/delete-br-012-expected.txt:
• editing/deleting/delete-hr-expected.txt:
• editing/deleting/delete-tab-004-expected.txt:
• editing/deleting/forward-delete-expected.txt:
• editing/deleting/merge-into-empty-block-1-expected.txt:
• editing/deleting/merge-into-empty-block-2-expected.txt:
• editing/execCommand/format-block-expected.txt:
• editing/execCommand/outdent-selection-expected.txt:
• editing/inserting/editing-empty-divs-expected.txt:
• editing/inserting/insert-3800346-fix-expected.txt:
• editing/inserting/insert-br-004-expected.txt:
• editing/inserting/insert-br-005-expected.txt:
• editing/inserting/insert-br-006-expected.txt:
• editing/inserting/insert-br-008-expected.txt:
• editing/inserting/insert-div-006-expected.txt:
• editing/inserting/insert-div-008-expected.txt:
• editing/inserting/insert-div-010-expected.txt:
• editing/inserting/insert-div-011-expected.txt:
• editing/inserting/insert-div-013-expected.txt:
• editing/inserting/insert-div-015-expected.txt:
• editing/inserting/insert-div-019-expected.txt:
• editing/inserting/insert-div-021-expected.txt:
• editing/inserting/insert-paragraph-01-expected.txt:
• editing/inserting/insert-paragraph-03-expected.txt:
• editing/inserting/insert-tab-004-expected.txt:
• editing/inserting/insert-text-with-newlines-expected.txt:
• editing/inserting/line-break-expected.txt:
• editing/pasteboard/3976872-expected.txt:
• editing/pasteboard/paste-text-005-expected.txt:
• editing/pasteboard/paste-text-006-expected.txt:
• editing/pasteboard/paste-text-007-expected.txt:
• editing/pasteboard/paste-text-010-expected.txt:
• editing/pasteboard/paste-text-014-expected.txt:
• editing/pasteboard/paste-text-016-expected.txt:
• editing/pasteboard/quirks-mode-br-2-expected.txt:
• editing/style/apple-style-editable-mix-expected.txt:
• editing/style/block-style-001-expected.txt:
• editing/style/block-style-002-expected.txt:
• editing/style/block-style-003-expected.txt:
• editing/style/block-style-006-expected.txt:
• editing/style/create-block-for-style-005-expected.txt:
• editing/style/create-block-for-style-006-expected.txt:
• editing/style/create-block-for-style-008-expected.txt:
• editing/style/relative-font-size-change-002-expected.txt:
• editing/style/relative-font-size-change-003-expected.txt:
• editing/style/relative-font-size-change-004-expected.txt:
• editing/style/table-selection-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

No layout test for the bug fix, because there's no way to register a custom
editing delegate from a layout test. Layout tests are effected by the change
to avoid sending unnecessary shouldChangeSelections, however.

• editing/Editor.cpp: (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection if the editing operation didn't change the selection. Still call setSelection though, because it does work in this case that's necessary, like clearing the typing style. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting selection if the editing delegate returns NO from shouldDeleteRange. Notice we now call setStartingSelection in the case where the current selection was a range selection. This is fine because it's a no-op (the starting selection is already the current selection). (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

3:32 PM Changeset in webkit [17980] by sullivan

• 4 edits in trunk/WebCore

Reviewed by Darin

Move subrange helper function from spellchecking code to TextIterator

• editing/TextIterator.h: added TextIterator::subrange
• editing/TextIterator.cpp: (WebCore::CharacterIterator::advance): early return if count is <= 0; assert that it's not < 0 (WebCore::TextIterator::subrange): new function, moved from FrameMac.mmm

• bridge/mac/FrameMac.mm: moved subrange() function to TextIterator (WebCore::FrameMac::advanceToNextMisspelling): use TextIterator::subrange (WebCore::markAllMisspellingsInRange): ditto (WebCore::markAllBadGrammarInRange): ditto

2:53 PM Changeset in webkit [17979] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-004 (unchanged from 10.4.7).

2:52 PM Changeset in webkit [17978] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-004 (unchanged from 10.4.7).

2:51 PM Changeset in webkit [17977] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebKit

Tag for WebKit for Security Update 2006-004 (unchanged from 10.4.7).

2:46 PM Changeset in webkit [17976] by darin

• 31 edits
  1 delete in trunk

WebCore:

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

I couldn't think of an easy way to make a regression test for this, but maybe
I'll get an idea later about how to do it.

The main thing I did was add a concept of a DOM event having an "underlying event".
That allows the DOM activate event to contain inside it the original keyboard event
that triggered the form submission, and thus allows WebKit to see the modifier keys
from that original event. The code that uses the underlying event is in WebKit, but
the code to set it up is here in WebCore.

• also do some clean-up to related event handling code

• bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the name change of cancelBubble.

• dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting. Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old name predated the use of the m_ prefix on data members. Added the underlying event, and a getter and setter.
• dom/Event.cpp: (WebCore::Event::setTarget): Updated to take a PassRefPtr. (WebCore::Event::setUnderlyingEvent): Added.

• dom/EventTargetNode.h: Added an optional underlyingEvent parameter to dispatchUIEvent, one of the overloads of dispatchMouseEvent, and dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that mostly replaces the click function in HTMLElement.
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change of cancelBubble. (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter, which gets attached to the UIEvent object after it's created. (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter name for the version that creates a mouse event for a real platform mouse event. Added an underlying event parameter to the main version, and attached it to all three of the events that can be dispatched. (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying event parameter, passed it along to dispatchMouseEvent. (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement and renamed it from click. Added an underlyingEvent parameter, and passed that along in all three of the calls to dispatchSimulatedMouseEvent.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to setTarget that no longer needs a get().
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
• html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
• html/HTMLElement.h: Removed the parameters to click and made it non-virtual. We could move it down to the input and button elements, now that it's just a single function call, but it's also OK to just leave it here.
• html/HTMLElement.cpp: (WebCore::HTMLElement::click): Removed the parameters and changed this to just call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick. (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers, pass the event along as the underlying event.
• html/HTMLInputElement.h:
• html/HTMLInputElement.cpp: Removed override of virtual click function. The special cases for the file control and hidden input elements aren't needed. (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to dispatchSimulatedClick, passing along the event as the underlying event.
• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick, passing the event along as the underlying event. Also changed the local variable for the element to a RefPtr since the code assumes it's still around after calling arbitrary JavaScript code.
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.

• rendering/RenderFileUploadControl.h:
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): Removed unneeded ignored parameter to the click function, and also made it non-virtual.

• loader/NavigationAction.h: Removed unneeded includes.
• loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm, since none of it is Mac-specific any more.
• loader/mac/NavigationActionMac.mm: Removed.
• WebCore.xcodeproj/project.pbxproj: Updated for removed file.

• ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.

• loader/FrameLoader.cpp: Added a newly-needed incluude.
• loader/mac/DocumentLoaderMac.mm: Ditto.
• loader/mac/FrameLoaderMac.mm: Ditto.
• rendering/RenderWidget.cpp: Ditto.

WebKit:

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

• WebCoreSupport/WebFrameLoaderClient.mm: (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain of events and their underlying events. (findMouseEvent): Added. Same, but specifically for mouse events. (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we use the modifiers from the underlying events rather than just the one from the event itself. So if the event is a DOM activate event, we can still see the modifiers from the original keyboard event that triggered it. Has no effect if the event is already the right type or if there is no underlying event.

• WebView/WebFrame.mm: Added a newly-needed include.

• WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.

2:44 PM Changeset in webkit [17975] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebCore

Tag for WebCore for Security Update 2006-004.

2:43 PM Changeset in webkit [17974] by thatcher

• 1 add in releases/Apple/Tiger/Security Update 2006-004

New tag for Security Update 2006-004

2:33 PM Changeset in webkit [17973] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebKit

Tag for WebKit for Security Update 2006-007.

2:31 PM Changeset in webkit [17972] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebCore

Tag for WebCore for Security Update 2006-007 (unchanged from 10.4.8).

2:30 PM Changeset in webkit [17971] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-007 (unchanged from 10.4.8).

2:29 PM Changeset in webkit [17970] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-007 (unchanged from 10.4.8).

2:28 PM Changeset in webkit [17969] by thatcher

• 1 add in releases/Apple/Tiger/Security Update 2006-007

New tag for Security Update 2006-007

2:12 PM Changeset in webkit [17968] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Darin

• fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker

• bridge/mac/FrameMac.mm: (WebCore::markAllMisspellingsInRange): new function, extracted from markMisspellings -- ignores grammar (WebCore::markAllBadGrammarInRange): new function, extracted from markMisspellings -- ignores spelling, and operates on appropriately-sized chunks of text (WebCore::FrameMac::markMisspellings): now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather than trying to interweave the spelling and grammar logic

1:31 PM Changeset in webkit [17967] by sullivan

• 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

1:25 PM Changeset in webkit [17966] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Darin

With these changes, grammar checking works correctly for the one-by-one case.
It still doesn't work correctly for the check-as-you-type case; I need to make these
same kinds of changes in markMisspellings, and refactor to share more code between
the two cases, but I wanted to get this working code in before modifying it further.

The major change here is that advanceToNextMisspelling used to look at small chunks of
text at a time, checking each one for both misspellings and questionable grammar. But
grammar checking needs at least paragraph-sized chunks of text to have enough context
to work correctly, so the old mechanism was causing many spurious complaints of bad
grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
would complain about missing capitalization). So now the spell checker runs in the
specified range first. Then the grammar checker runs on the same range (stopping at the
next misspelling, if any), but expanded to paragraph-aligned boundaries.

• bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): new function, extracted from advanceToNextMisspelling, and ignores grammar (WebCore::paragraphAlignedRangeForRange): new function, used by findNextBadGrammarInRange (WebCore::findFirstBadGrammarInRange): new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned chunks, and ignores spelling (WebCore::subrange): new helper function, used by advanceToNextMisspelling (WebCore::FrameMac::advanceToNextMisspelling): now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately instead of trying to interweave the spelling and grammar logic

1:21 PM Changeset in webkit [17965] by rwlbuis

• 14 edits in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11732:
Windows build bustage.

1:11 PM Changeset in webkit [17964] by yongjzha

• 4 edits in S60/branches/3.1m/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11727

• BrowserControl/inc/BrCtl.h:
• BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
• BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

1:06 PM Changeset in webkit [17963] by yongjzha

• 4 edits in S60/trunk/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongju.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugs.webkit.org/show_bug.cgi?id=11727

• BrowserControl/inc/BrCtl.h: (CBrCtl::HttpLoaderEventToUi):
• BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
• BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

11:08 AM Changeset in webkit [22605] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-12-01 Steve Falkenburg <​sfalken@apple.com>

Fix post-build step.
Need to copy CoreFoundation resources.
Bundles aren't config specific - removed ConfigSuffix from copy commands for resources.

• WebKit.vcproj\WebKit.vcproj:

10:44 AM Changeset in webkit [17962] by thatcher

• 4 edits
  1 add in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit

Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.

• Misc/OldWebAssertions.c: Added. (WebReportAssertionFailure): (WebReportError):
• WebKit.LP64.exp: added the new symbols, and sorted the file
• WebKit.exp: added the new symbols, and sorted the file
• WebKit.xcodeproj/project.pbxproj:

10:34 AM Changeset in webkit [17961] by thatcher

• 2 edits in trunk/WebKit/Misc

Correcting the copyright date since these are new files.

Nov 30, 2006:

11:28 PM Changeset in webkit [22604] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:22 PM Changeset in webkit [17960] by sfalken

• 1 copy in tags/Safari-521.31.4

New tag.

10:35 PM Changeset in webkit [22603] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Fix build.
Link against new WTF.lib

• WebKit.vcproj/WebKit.vcproj:

9:42 PM Changeset in webkit [17959] by sfalken

• 4 edits
  2 adds in trunk/JavaScriptCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Move WTF from JavaScriptCore project into a new WTF project.

• JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTF.vcproj to sln
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove WTF source files
• JavaScriptCore.vcproj/WTF/WTF.vcproj: Added.
• JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add dependency on WTF.lib

8:23 PM Changeset in webkit [22602] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):

8:15 PM Changeset in webkit [17958] by ggaren

• 24 edits in trunk

WebCore:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

WebKit:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

• WebView/WebHTMLView.m: (-[NSArray clearFocus]):

6:16 PM Changeset in webkit [17957] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-30 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Tabbed navigation fixes
​http://bugs.webkit.org/show_bug.cgi?id=11725

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):

5:53 PM Changeset in webkit [22601] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:47 PM Changeset in webkit [17956] by sfalken

• 1 copy in tags/Safari-521.31.3

New tag.

4:57 PM Changeset in webkit [22600] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Lather, rinse, repeat.

• platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):

4:55 PM Changeset in webkit [17955] by sullivan

• 15 edits in trunk

LayoutTests:

Reviewed by Justin

• editing/execCommand/create-list-from-range-selection-expected.checksum:
• editing/execCommand/create-list-from-range-selection-expected.png:
• editing/execCommand/create-list-from-range-selection-expected.txt:
• editing/execCommand/create-list-from-range-selection.html: This test's results were broken by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably by revealing a different bug. Justin is going to look into this; for now I've updated the result so that it won't appear to fail for others.

• editing/execCommand/create-list-with-hr-expected.checksum:
• editing/execCommand/create-list-with-hr-expected.png:
• editing/execCommand/create-list-with-hr-expected.txt:
• editing/execCommand/create-list-with-hr.html: This test's results were improved by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used to create an extra <div>, and now it does not.

WebCore:

Reviewed by Justin

With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.

With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.

• dom/Position.h: removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.

• dom/Range.cpp: (WebCore::Range::Range): Call setStart and setEnd in the two Range constructors that take parameters, rather than just directly setting the instance variables. This makes Range perform the boundary checks and compensations that the DOM spec requires.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.

• editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Assert that the boundary points of the range are valid.

4:18 PM Changeset in webkit [22599] by aroben

• 3 edits
  1 delete in branches/WindowsMerge/WebCore

Build fix.

• platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was un-forked a while ago.
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::platformDescription):
• platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):

4:14 PM Changeset in webkit [17954] by thatcher

• 3 edits in trunk/WebKit

Reviewed by Mitz.

Bug 10698: Scroll wheel causes inspector to shift up
​http://bugs.webkit.org/show_bug.cgi?id=10698

Remove size attribute from the tree popup as a workaround for
​http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options

• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.html:

4:11 PM Changeset in webkit [17953] by thatcher

• 3 edits in trunk/WebKit

Reviewed by Tim H.

Move web inspector style markup to javascript to fix ​http://bugs.webkit.org/show_bug.cgi?id=6724
Bug 6724: Text copied from Web Inspector is different from actual text

• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.js:

4:03 PM Changeset in webkit [17952] by thatcher

• 1 edit in trunk/WebCore/ChangeLog

Removing the conflict marker.

3:50 PM Changeset in webkit [17951] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

• ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):

3:45 PM Changeset in webkit [17950] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

• ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):

2:48 PM Changeset in webkit [22598] by aroben

• 4 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:
• platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::createFilterEffect):
• platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):

2:29 PM Changeset in webkit [17949] by lamadio

• 3 edits in trunk/WebCore

2006-11-30 Lou Amadio <​lamadio@apple.com>

Reviewed by Dave Hyatt
Cleaned up generated files.

2:07 PM Changeset in webkit [17948] by aroben

• 7 edits in trunk

WebCore:

Reviewed by Beth.

Store ContextMenu's NSMutableArray inside a RetainPtr so that we
will retain/release it correctly.

• WebCore.exp:
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Added a FIXME.
• platform/ContextMenu.h:
• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription):

WebKit:

Reviewed by Beth.

Put code in place to use WebCore context menus when they are turned
on.

• WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):

1:47 PM Changeset in webkit [17947] by zimmermann

• 81 edits
  4 copies
  1 delete in trunk/WebCore

Reviewed by Eric. Rubber stamped by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10383

This is the final patch after the long "die kcanvas" journey.

All old kcanvas code is gone now, and properly integrated within
WebCore (stuff like GraphicsContext changes etc.). It shares
the platform/ design concept: no subclassing, but instead
implementing parts of the classes/methods per-platform.

This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
This layer was just obsolete, given the powerful GraphicsContext API we have
since quite a while now. All the ugly pushContext/popContext stuff is gone now.

The naming issues Cg vs. CG will be fixed in one shot, when moving the whole
platform/graphics/svg directory down into ksvg2/graphics - as discussed with Darin.

1:13 PM Changeset in webkit [22597] by ggaren

• 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

• loader/win/FrameLoaderWin.cpp: Removed custom implementation for detachFromParent, since FrameLoader has a cross-platform version now.

WebKitWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

Copied *very nice* (NOT!) WebKit Mac idiom of calling
FrameLoader::detachFromParent when closing the WebView.
We need to do this so event listeners that retain the document
get destroyed, and so the unload event gets dispatched.

This is pretty silly. Instead, the document/frame/interpreter should
be responsible for cleaning up after itself.

• WebView.cpp: (WebView::close):

1:10 PM Changeset in webkit [17946] by yongjzha

• 2 edits in S60/trunk/WebKit

1:06 PM Changeset in webkit [17945] by ggaren

• 9 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.

Fixed up garbage collection at window close time.

• kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter): Garbage collect here, since destroying the interpreter frees the global object and therefore creates a lot of garbage.

WebCore:

Reviewed by Beth Dakin.

Fixed up garbage collection at window close time.

• bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy destructor, since the global object hasn't been freed yet.
• bindings/js/kjs_proxy.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Made this function cross- platform.
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac, since it's Mac-only. (WebCore::FrameLoader::closeBridge):
• page/Page.cpp: (WebCore::Page::~Page): Don't garbage collect in the Page destructor, since the Interpreter destructor will do it for us.

12:26 PM Changeset in webkit [17944] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: If values are null in setPreferenceForKey remove them from the map.
​http://bugs.webkit.org/show_bug.cgi?id=11438

• BrowserView/src/WidgetPreferences.cpp: (CWidgetPreferences::SetPreferenceL):

12:23 PM Changeset in webkit [17943] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll
​http://bugs.webkit.org/show_bug.cgi?id=11724

• ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Internalize):

12:16 PM Changeset in webkit [17942] by spadma

• 8 edits in S60/trunk

2006-11-30 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma.
DESC: Refresh timer in the browser is not cancelled
​http://bugs.webkit.org/show_bug.cgi?id=11722

• BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::Complete):

12:06 PM Changeset in webkit [22596] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

build WebKit.lib to proper directory

• WebKit.vcproj/WebKit.vcproj:

11:24 AM Changeset in webkit [17941] by spadma

• 5 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: [s60] Saved Pages: Some Images not saved with the page.
​http://bugs.webkit.org/show_bug.cgi?id=11721

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
• ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):

11:23 AM Changeset in webkit [17940] by beidson

• 2 edits in trunk/WebCore

Reviewed by Tim's rubberstamp

Amazingly, DocumentLoader.h survived all this time without a header guard...

• loader/DocumentLoader.h: Added header guard

10:48 AM Changeset in webkit [22595] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Add missing header files to vcproj.

• WebCore.vcproj/WebCore.vcproj:

9:37 AM Changeset in webkit [17939] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Brady and Eric.

XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
​http://bugs.webkit.org/show_bug.cgi?id=11723

Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
tested in Safari's debug Snippet Editor.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):

7:05 AM Changeset in webkit [17938] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-29 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11716
[S60] some Chinese characters displays as mess code on www.163.com

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotData):

Nov 29, 2006:

7:44 PM Changeset in webkit [22594] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• platform/win/TemporaryLinkStubs.cpp: Remove unused function.

7:26 PM Changeset in webkit [17937] by andersca

• 12 edits in trunk/WebCore

Reviewed by Brady.

Get rid of PlatformResponse, the platform specific response object is stored inside of
the ResourceResponse object now. This also gets rid of receivedResponse in ResourceHandleClient.

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
• loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
• loader/CachedResource.h: (WebCore::CachedResource::response):
• loader/loader.cpp:
• loader/loader.h:
• loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse):
• platform/network/ResourceHandle.h:
• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::cfURLResponse):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveResponse):

6:54 PM Changeset in webkit [17936] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by sullivan

<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message

• editing/deleting/4845371-expected.checksum: Added.
• editing/deleting/4845371-expected.png: Added.
• editing/deleting/4845371-expected.txt: Added.
• editing/deleting/4845371.html: Added.

WebCore:

Reviewed by sullivan

<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The start/end were being inflated even when they were the start/end of a partially selected special element.

6:01 PM Changeset in webkit [17935] by bdash

• 1 edit in trunk/WebKit/WebCoreSupport/WebChromeClient.mm

Build fix: ResourceRequestMac.h was removed in r17911.

5:55 PM Changeset in webkit [17934] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-29 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: QPen emulation in KWQ did not handle special
case for pen width zero.
​http://bugs.webkit.org/show_bug.cgi?id=11714

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQPainter.cpp:

4:59 PM Changeset in webkit [17933] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Oliver.

Keep preferences separate from the rest of the client, making sure we are using expected preference values.
This lets the inspector work when plugins are disabled for the WebView.

• WebInspector/WebInspector.m: (-[NSWindow window]):

4:10 PM Changeset in webkit [22593] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.

• platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Initialize the status code to 0 for non-http responses.

3:01 PM Changeset in webkit [22592] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.

Minor fix to my recent COM registration/Vista fix.
Ignore errors during registration. Vista locks off more of
HKCU\Software\Classes than I thought.

• WebKitDLL.cpp:

2:42 PM Changeset in webkit [17932] by andersca

• 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.

• platform/network/mac/ResourceResponseMac.mm: Initialize the status code to 0 for non-http responses.

2:14 PM Changeset in webkit [17931] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11712
REGRESSION: Crash when clicking JS link on crateandbarrel.com (window.open("http[...]"))

This was an accidental commit by Anders.

Chrome can't use the FrameView at window.open time, because it doesn't
exist yet.

• page/Chrome.cpp: (WebCore::Chrome::pageRect):

1:58 PM Changeset in webkit [17930] by ggaren

• 10 edits in trunk/WebCore

Reviewed by Mitz Pettel.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11710
REGRESSION (r17906): Crash in WebCore::FrameMac

Added null checks for EditorClient, since it can be NULL when the page
has been destroyed. Removed external access to EditorClient, since it's
an implementation detail of the Editor.

No test case because this crash depends on window tear-down. Layout tests
pass.

11:31 AM Changeset in webkit [17929] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
​http://bugs.webkit.org/show_bug.cgi?id=11702

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):

11:30 AM Changeset in webkit [17928] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
​http://bugs.webkit.org/show_bug.cgi?id=11702

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):

11:26 AM Changeset in webkit [17927] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
​http://bugs.webkit.org/show_bug.cgi?id=11715

• BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):

11:24 AM Changeset in webkit [17926] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
​http://bugs.webkit.org/show_bug.cgi?id=11715

• BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):

10:47 AM Changeset in webkit [17925] by andersca

• 4 edits in trunk/WebKit

Reviewed by Tim.

Add back methods in WebCoreStatistics that are still used by Tiger Safari.

• Misc/WebCoreStatistics.h:
• Misc/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]):

10:38 AM Changeset in webkit [17924] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=11711

• ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):

10:38 AM Changeset in webkit [17923] by andersca

• 2 edits in trunk/WebCore

Fix build.

• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): Fix tyop.

10:37 AM Changeset in webkit [17922] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=11711

• ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):

10:35 AM Changeset in webkit [22591] by andersca

• 5 edits
  2 deletes in branches/WindowsMerge/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.

• WebCore.vcproj/WebCore.vcproj:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse):
• platform/network/cf/ResourceRequestCFNet.h: Removed.
• platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
• platform/network/cf/ResourceResponseCFNet.h: Removed.
• platform/win/MimeTypeRegistryWin.cpp:

10:29 AM Changeset in webkit [17921] by andersca

• 8 edits
  1 add
  1 delete in trunk/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.

• WebCore.xcodeproj/project.pbxproj:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously):
• platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest):
• platform/network/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpStatusText): (WebCore::ResourceResponse::setHTTPStatusText): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate): (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): (WebCore::ResourceResponse::updateResourceResponse):
• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipart):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::willSendRequest):
• platform/network/mac/ResourceResponseMac.h: Removed.
• platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):

9:57 AM Changeset in webkit [22590] by aroben

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

Give archive builds a separate set of CLSIDs so that they may be
installed/run alongside B&I builds and development builds.

• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKit.vcproj: Don't register WebKit.dll if ARCHIVE_BUILD or BuildBot is defined.

Nov 28, 2006:

11:43 PM Changeset in webkit [22589] by adachan

• 14 edits
  3 adds in branches/WindowsMerge/WebKitWin

2006-11-28 Ada Chan <​adachan@apple.com>

Reviewed by Adam.

WebKitWin:

<rdar://4850020> Clear cache in WebKit

• Added the IWebCache interface, which contains API to clear and disable the cache
• Added implementation of WebCache which implements IWebCache.
• the page cache related calls added in WebHistoryItem are just stubs right now because we haven't implemented page cache yet.

11:25 PM Changeset in webkit [17920] by aliceli1

• 6 edits in trunk

WebCore:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

• bridge/EditorClient.h: Add frame parameter to dataForArchivedSelectionInFrame instead of just getting the webview's selectedFrame.

• platform/mac/PasteboardMac.mm: (Pasteboard::writeSelection): Pass in the frame

WebKit:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection): Use the frame parameter instead of using the webview's selectedFrame.

10:42 PM Changeset in webkit [17919] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Geoffff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION
(r17399, r17511): WebElementDictionary no longer returns nil
NSStrings

String's NSString* operator converts null Strings to empty
NSStrings for compatibility with AppKit. We need to work around
that here.

• Misc/WebElementDictionary.m: (NSStringOrNil): (-[WebElementDictionary _altDisplayString]): (-[WebElementDictionary _spellingToolTip]): (-[WebElementDictionary _title]): (-[WebElementDictionary _titleDisplayString]): (-[WebElementDictionary _textContent]):

10:18 PM Changeset in webkit [22588] by ggaren

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API

All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API

All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.

• WebFrame.cpp: (WebFrame::initWithWebFrameView):

10:11 PM Changeset in webkit [17918] by ggaren

• 17 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API

All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.

• bridge/mac/WebCoreFrameBridge.mm: I had to move some initialization up into WebKit to resolve circular dependencies at init time.

WebKit:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API

All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.

• WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed some arguments to resolve ciruclar dependencies at init time. (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient here, because the client is set up at construction time.

8:25 PM Changeset in webkit [22587] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly dispose of the HMENU.

• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::at): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::show):

8:19 PM Changeset in webkit [17917] by aroben

• 3 edits in trunk/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly retain/release the platform menu description.

• platform/ContextMenu.h: (WebCore::ContextMenu::platformDescription):
• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription):

7:27 PM Changeset in webkit [22586] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.

Make COM registration fall back to per-user for Vista LUA compatibility.

• WebKitDLL.cpp:

7:24 PM Changeset in webkit [22585] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:15 PM Changeset in webkit [17916] by brmorris

• 2 edits in S60/trunk/S60Tools

2006-11-28 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sasha.

• S60WebKitPlatformBuild.pl: Utility fixes.

6:30 PM Changeset in webkit [17915] by zbujtas

• 3 edits in S60/branches/3.1m/WebCore

2006-11-27 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678
Merged from 3.2 17914
WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
• kwq/KWQKHTMLPart.h:

6:15 PM Changeset in webkit [22584] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

• WebCore.vcproj/WebCore.vcproj:

6:09 PM Changeset in webkit [17914] by zbujtas

• 3 edits in S60/trunk/WebCore

2006-11-22 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
• kwq/KWQKHTMLPart.h:

5:51 PM Changeset in webkit [17913] by aroben

• 2 edits in trunk/WebCore

Build fix.

• platform/network/mac/ResourceRequestMac.mm:

5:24 PM Changeset in webkit [17912] by harrison

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

• editing/selection/select-missing-image-expected.checksum: Added.
• editing/selection/select-missing-image-expected.png: Added.
• editing/selection/select-missing-image-expected.txt: Added.
• editing/selection/select-missing-image.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

Test:

• editing/selection/select-missing-image.html: Added.

• rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Draw the selection tint even if the image itself is not available.

5:23 PM Changeset in webkit [22583] by andersca

• 5 edits in branches/WindowsMerge/WebCore

Fix the build by doing the same changes that were done in the open source WebCore repo.

• WebCore.vcproj/WebCore.vcproj:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::ResourceHandle::start):
• platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::cfURLRequest): (WebCore::addHeadersFromHashMap): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
• platform/network/cf/ResourceRequestCFNet.h:

5:15 PM Changeset in webkit [17911] by andersca

• 11 edits
  1 add
  1 delete in trunk

WebCore:

Reviewed by Maciej.

Have ResourceRequest hold on to the platform object so we don't
have to convert back and forth when nothing in the object changes.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::continueAfterNavigationPolicy):
• page/Chrome.cpp: (WebCore::Chrome::pageRect):
• platform/network/ResourceRequest.cpp: Added. (WebCore::ResourceRequest::isEmpty): (WebCore::ResourceRequest::url): (WebCore::ResourceRequest::setURL): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderFields): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::allowHTTPCookies): (WebCore::ResourceRequest::setAllowHTTPCookies): (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest): (WebCore::ResourceRequest::addHTTPHeaderField): (WebCore::ResourceRequest::addHTTPHeaderFields):
• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest):
• platform/network/mac/ResourceRequestMac.h: Removed.
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::nsURLRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Maciej.

Update for changes to ResourceRequest.

• WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest):

4:49 PM Changeset in webkit [22582] by aroben

• 15 edits
  1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

• WebCore.vcproj/WebCore.vcproj: Defined WEBCORE_CONTEXT_MENUS to turn on the context menus. Added new ContextMenuItem files.
• platform/win/ContextMenuItemWin.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem):
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemCount): Updated to match ContextMenu.h and ContextMenuItem changes. (WebCore::ContextMenu::insertItem): Ditto. (WebCore::ContextMenu::appendItem): Ditto. (WebCore::ContextMenu::at): New method, similar to Vector<T>::at. (WebCore::ContextMenu::setPlatformDescription): Use MIM_APPLYTOSUBMENUS to make sure all submenus get the MNS_NOTIFYBYPOS style. (WebCore::ContextMenu::show): Implemented.

Updates to match OpenSource changes.

• loader/win/FrameLoaderWin.cpp: Added missing #include.
• page/win/EventHandlerWin.cpp: Return bools to signify whether the event was handled. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar):
• platform/win/PlatformScrollBar.h: Ditto.
• platform/win/PlatformScrollBarWin.cpp: Ditto. (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

Small fix inspired by WebView.cpp changes.

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Use ::ClientToScreen to do coordinate conversion instead of doing it ourselves.

WebKitWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

• Interfaces/IWebUIDelegate.idl: Added a new delegate method to be called when the user clicks on one of the application's context menu items.

Client updates from WebCore.

• WebContextMenuClient.cpp: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): New client method that calls the UI delegate.
• WebContextMenuClient.h: Updated to match ContextMenuClient.h

Windows context menu event handling.

• WebView.cpp: (WebView::handleContextMenuEvent): New method to send a context menu event down into WebCore. (WebView::performContextMenuAction): New method to tell the ContextMenuController that the user clicked on a context menu item. (WebView::handleMouseEvent): Return a bool to signify whether the event was handled. (WebView::mouseWheel): Ditto. (WebViewWndProc): Handle WM_CONTEXTMENU and WM_MENUCOMMAND messages, and pass unhandled events to DefWindowProc.
• WebView.h: New declarations.

Small (but necessary) fixes.

• WebElementPropertyBag.cpp: (isEqual): Fixed to deal with LPCWSTRs, which is what was being passed in anyway. (WebElementPropertyBag::Read): Use FAILED() to check the return value of QueryInterface.
• WebElementPropertyBag.h: Added missing #include.

4:42 PM Changeset in webkit [17910] by aroben

• 23 edits
  1 copy
  1 add in trunk

WebCore:

Reviewed by Beth.

More WebCore context menu work (still not turned on, however).

Split ContextMenuItem into its own files and make it a class.

• WebCore.exp: Updated symbols.
• WebCore.xcodeproj/project.pbxproj: Added new ContextMenuItem files.
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Code cleanup.
• platform/ContextMenu.h: Split ContextMenuItem into a separate file, removed redundant "Menu" part of platformMenuDescription(), setPlatformMenuDescription(). (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformDescription):
• platform/ContextMenuItem.h: Added. Made ContextMenuItem a full-fledged class. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::menu): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
• platform/mac/ContextMenuItemMac.mm: Added. (WebCore::ContextMenuItem::ContextMenuItem):
• platform/mac/ContextMenuMac.mm: Updated for ContextMenuItem changes. (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): Handle separator items. (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformDescription):
• page/ContextMenuController.h: Updated declaration, added getter. (WebCore::ContextMenuController::contextMenu):

Added some more context menu plumbing.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Added code to call the ContextMenuController when a context menu event is received.
• page/ContextMenuClient.h: New client method declaration.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Set the event defaultHandled after handling it. (WebCore::ContextMenuController::contextMenuItemSelected): Take a ContextMenuItem instead of a separate action and title.

Changed event-handling methods to return bools to signify whether the
event was handled or not. This is needed so we can know whether to hand
the event off to the OS. Also restructured some code to use early
returns instead of nesting ifs.

• page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::canMouseDownStartSelect):
• page/EventHandler.h:
• page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
• page/FrameView.h:
• platform/ScrollBar.h: More bool return values. (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent):
• platform/Widget.h: Ditto. (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):

Reverted the changes made in r17805 so that we can have fewer header
#includes.

• page/Page.cpp: (WebCore::Page::Page):
• page/Page.h: Ditto. (WebCore::Page::dragCaretController): (WebCore::Page::chrome): (WebCore::Page::contextMenuController):

WebKit:

Reviewed by Beth.

More WebCore context menu work.

• DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation. (-[NSApplication webView:contextMenuItemSelected:forElement:]):
• WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): Added new client method.
• WebView/WebUIDelegatePrivate.h: New private delegate method declaration.

4:12 PM Changeset in webkit [22581] by andersca

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4850883>
Crash loading pdf page (W4 form)

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::redirectDataToPlugin):
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::redirectDataToPlugin): Move the function to FrameLoaderWin.cpp and get rid of STOP_NOIMPL() for now, we do things differently on Windows so this function doesn't need do do anything. I've filed 4852889 about redoing this once the loader has been ported.

2:14 PM Changeset in webkit [22580] by aliceli1

• 6 edits
  4 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada, Adam, and Lou.

• WebCore.vcproj/WebCore.vcproj: Added the files listed below

• platform/win/ClipboardWin.h: Added.
• platform/win/ClipboardWin.cpp: Added. Added the minimum stubs for the ClipboardWin class (WebCore::ClipboardWin::isForDragging): (WebCore::ClipboardWin::dropEffect): (WebCore::ClipboardWin::setDropEffect): (WebCore::ClipboardWin::effectAllowed): (WebCore::ClipboardWin::setEffectAllowed): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::dragLocation): (WebCore::ClipboardWin::dragImage): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::dragImageElement): (WebCore::ClipboardWin::setDragImageElement): (WebCore::ClipboardWin::setAccessPolicy): (WebCore::ClipboardWin::~ClipboardWin):

• platform/win/EditorWin.cpp: Added. Added this to make dispatchCPPEvent happy. (WebCore::Editor::newGeneralClipboard):

• platform/win/PasteboardWin.cpp: Added. The pasteboard class follows a singleton pattern Implemented the following to support CF_HTML, CF_UNICODE, and CF_TEXT (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::registerSelectionPasteboardTypes): (WebCore::Pasteboard::clearTypes): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::createHandleFromString): (WebCore::Pasteboard::createHandleFromCString): (WebCore::Pasteboard::createCF_HTMLFromRange): (WebCore::Pasteboard::replaceNBSP): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::PasteboardOwnerWndProc):

WebKitWin:

Reviewed by Ada, Adam, and Lou.

• WebEditorClient.h:
• WebEditorClient.cpp: These 3 functions are, for now, hard-coded to return true, letting paste work. Commented out previous unused code because the app would crash if the editingDelegate was called (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): stub impl for: (WebEditorClient::smartInsertDeleteEnabled):

• WebView.cpp: moved where cut/copy/paste was handled from (WebView::execCommand): (WebViewWndProc):

call the editor's version of these 4:
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::delete_):

2:06 PM Changeset in webkit [22579] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/4844863> REGRESSION: screen flashes when scrolling/
resizing page with plug-in (@ cnn.com, for example).

LockWindowUpdate was to blame. It turns out that using LockWindowUpdate
was wrong to begin with. It's really only intended for use in drag-n-drop
operations, which explains why only one window can be locked at a time.
(See ​http://blogs.msdn.com/oldnewthing/archive/2004/06/10/152612.aspx.)

The new solution I've implemented for avoiding plug-in fragments while scrolling
is simply to clip the plug-in to the zero rect before moving it, and
then to un-clip it when done.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd):

2:05 PM Changeset in webkit [17909] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):

2:02 PM Changeset in webkit [17908] by aliceli1

• 17 edits
  1 move
  5 adds in trunk

WebCore:

Reviewed by Justin and Adam.

All layout tests pass as they do without this patch

• WebCore.exp: Exposed functions in Editor and removed functions in FrameMac due to changes in WebHTMLView.m

• WebCore.xcodeproj/project.pbxproj: Added Pasteboard.h, PasteboardMac.mm, WebNSAttributedStringExtras.h&mm, EditorMac.mm

• bridge/EditorClient.h: Added smartInsertDeleteEnabled and shouldInsertNode and some mac-specific functions

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: Removed dispatchCPPEvent and [can|try]DHTML[cut|copy|paste] since the Editor's are called now

• dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode):
• dom/Node.h: (WebCore::Node::isCharacterDataNode): Added a type-identifying function to Node and the proper subclass

• dom/Clipboard.h: Exposed setAccessPolicy as public

• editing/Editor.h:
• editing/Editor.cpp: Implemented the following (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::canDHTMLPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::canSmartReplaceWithPasteboard): (WebCore::Editor::shouldInsertFragment): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::replaceSelectionWithText): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste):

• platform/mac/ClipboardAccessPolicy.h: Removed. Not removed, but moved to dom/ClipboardAccessPolicy.h

• platform/mac/EditorMac.mm: Added. (WebCore::Editor::newGeneralClipboard):

• platform/Pasteboard.h: Added.
• platform/mac/PasteboardMac.mm: Added. The pasteboard class follows a singleton pattern (Pasteboard::generalPasteboard): (Pasteboard::~Pasteboard): (Pasteboard::Pasteboard): (Pasteboard::clearTypes): (Pasteboard::writeSelection): (Pasteboard::selectionPasteboardTypes): (Pasteboard::canSmartReplace): (Pasteboard::plainText): (Pasteboard::documentFragment):

• platform/mac/WebNSAttributedStringExtras.h: Added.
• platform/mac/WebNSAttributedStringExtras.mm: Added. Added select portions of this file from WebKit because the pasteboard needed the following function: (-[NSAttributedString _web_attributedStringByStrippingAttachmentCharacters]):

WebKit:

Reviewed by Justin and Adam.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: added the following (WebEditorClient::smartInsertDeleteEnabled): (WebEditorClient::dataForArchivedSelectionInFrame): (WebEditorClient::_web_userVisibleString): (WebEditorClient::shouldInsertNode):

• WebKitPrefix.h: Added flags to control whether WebCore cut/copy/paste is enabled. Turned on Cut and Copy, left Paste and Delete off

• WebView/WebHTMLViewPrivate.h:
• WebView/WebHTMLView.m: removed _can[Cut|Copy|Paste|Delete] (-[NSArray validateUserInterfaceItem:]): call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead (-[NSArray delete:]): added code to call the editor's delete instead (not turned on) (-[WebHTMLView copy:]): added code to call the editor's copy (turned on) (-[WebHTMLView cut:]): added code to call the editor's cut (turned on) (-[WebHTMLView paste:]): added code to call the editor's paste (not turned on)

1:25 PM Changeset in webkit [17907] by justing

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste

• editing/selection/4397952-expected.checksum: Added.
• editing/selection/4397952-expected.png: Added.
• editing/selection/4397952-expected.txt: Added.
• editing/selection/4397952.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste

There were no VisiblePositions before/after buttons because editingIgnoresContent
returned false for buttons.

• dom/Position.cpp: (WebCore::Position::upstream): Fixed a comment. (WebCore::Position::downstream): Ditto.
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
• editing/htmlediting.cpp: (WebCore::editingIgnoresContent): It's unnecessary to prefer renderer checks over tag name checks because it seems that a node of a tag name that we do not ignore content for can't have a renderer of a type that we do. (WebCore::canHaveChildrenForEditing): Added selects, buttons, applets, and embeds.
• editing/visible_units.cpp: (WebCore::previousLinePosition): Migrate to enclosingBlock. Fixes a bug where the caret would get stuck moving up/down a line from a caret just before an input element. (WebCore::nextLinePosition): Ditto.

11:00 AM Changeset in webkit [22578] by ggaren

• 14 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.

Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.

I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.

Layout tests pass.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.

Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.

I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.

Layout tests pass.

10:54 AM Changeset in webkit [17906] by ggaren

• 36 edits
  1 delete in trunk

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.

Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.

I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.

Layout tests pass.

WebKit:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.

Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.

I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.

Layout tests pass.

9:21 AM Changeset in webkit [17905] by spadma

• 33 edits in S60/trunk

2006-11-17 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: Removed the obsolete flags RD_32_BROWSER and RD_BROWSER_VIDEO_PLUGIN
​http://bugs.webkit.org/show_bug.cgi?id=11604

• BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
• BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::CountComponentControls): (CBrCtl::ComponentControl):
• BrowserCore/Formcontrols/inc/FControlInputWidget.h:
• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL):
• BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetWebKitCursorPosition):
• BrowserCore/Misc/src/CannedImages.cpp: (CCannedImages::GetImage):
• BrowserView/inc/BrowserSettingsContainer.h:
• BrowserView/inc/SmartLinkHandler.h:
• BrowserView/inc/WebKitControl.h:
• BrowserView/inc/WebKitCursor.h:
• BrowserView/inc/WebKitFrame.h:
• BrowserView/inc/WebKitView.h:
• BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleArrowKeysL): (CKeyEventHandler::HandleActivateKeysL):
• BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::~CSmartLinkHandler): (CSmartLinkHandler::PrepareAiwHandlerL): (CSmartLinkHandler::HandleMakeCall):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::ProgressCompleted):
• BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::ConstructL): (CWebKitCursor::CursorUpdate): (CWebKitCursor::MoveCursorAdjusted): (CWebKitCursor::GetSmartLinkEntry): (CWebKitCursor::CalcSearchRect):
• BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame):
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ZoomLevelChanged): (CWebKitView::FindNextSmartLink):
• Plugin/inc/PluginSkin.h: (CPluginSkin::CanInteract):
• Plugin/inc/PluginWin.h:
• Plugin/src/PluginWin.cpp:
• ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
• data/Webkit.loc:
• data/Webkit.rss:
• data/Webkit_sdk.loc:
• data/Webkit_sdk.rss:
• group/BrowserView.mmp:
• group/webkit.mmp:

Nov 27, 2006:

11:06 PM Changeset in webkit [17904] by andersca

• 2 edits in trunk/WebCore

2006-11-27 Anders Carlsson <​acarlsson@apple.com>

Try fixing the build.

• platform/graphics/IntRect.cpp: (WebCore::IntRect::IntRect):

10:34 PM Changeset in webkit [22577] by bdakin

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Stub out functions in order to remove FIXMEs from ContextMenu.cpp

• bridge/win/FrameWin.h: Spell checker functions pushed down from WebKit.
• platform/win/TemporaryLinkStubs.cpp: Stubs for spelling functions. (WebCore::FrameWin::isSelectionMisspelled): (WebCore::FrameWin::guessesForMisspelledSelection):

WebKitWin:

Reviewed by Adam.

Stub for canHandleRequest() to remove FIXME from ContextMenu.cpp

• WebFrame.cpp: (WebFrame::canHandleRequest):
• WebFrame.h:

10:26 PM Changeset in webkit [17903] by bdakin

• 13 edits in trunk

WebCore:

Reviewed by Adam.

Getting rid of some of the critical FIXMEs in ContextMenu.cpp.

• bridge/mac/FrameMac.h: Two new spell checker functions from WebKit. (We will be able to delete the WebKit versions once we switch over to WebCore context menus.)
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::isSelectionMisspelled): (WebCore::core): Convert from NSArray of Strings to a Vector of Strings. (WebCore::FrameMac::guessesForMisspelledSelection):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::canHandleRequest):
• loader/FrameLoader.h: Make canHandleRequest available through the FrameLoader.
• loader/FrameLoaderClient.h: canHandleRequest takes a ResourceRequest instead of an NSURLRequest.
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::continueAfterNavigationPolicy): Same
• page/Frame.h: New spell checker functions moved to Frame. These should be moved some place better some day, but FrameMac currently seems to be the place to be for spell checker stuff.
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Use new FrameLoader and spell checking functionality to get rid of two if (true) statements. Also add spelling guesses to the editing context menus.

WebKit:

Reviewed by Adam.

WebKit half of getting rid of the FixMes in ContextMenu.cpp

• WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a ResourceRequest now.
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest): Same.
• WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.

9:33 PM Changeset in webkit [17902] by ap

• 3 edits
  2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=11694
XSLT output method does not default to HTML when the target document is HTML

Test: fast/xsl/default-html.html

• xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Make mimeType an input/output parameter, serving as a hint when the stylesheet doesn't specify the output method. (WebCore::XSLTProcessor::transformToFragment): Set mimeType to text/html if the target document is HTML.

8:36 PM Changeset in webkit [22576] by oliver

• 2 edits in branches/WindowsMerge/WebCore

2006-11-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes a crash in SVG caused by an attempt to
perform css overflow clipping by preventing
the css overflow clip from being set in SVG.

<rdar:/problems/4839568>

8:33 PM Changeset in webkit [17901] by oliver

• 6 edits
  2 adds in trunk/WebCore

2006-11-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes a crash in SVG caused by an attempt to
perform css overflow clipping by preventing
the css overflow clip from being set in SVG.

<rdar:/problems/4839568>

7:08 PM Changeset in webkit [22575] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/4814582>
JavaScript window.resizeTo doesn't work

• Interfaces/IWebUIDelegate.idl: Fix declarations.

• WebChromeClient.cpp: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): Call the COM methods.

7:01 PM Changeset in webkit [17900] by andersca

• 3 edits in trunk/WebCore

Reviewed by Adam.

Add an explicit IntRect constructor that takes a FloatRect.

• platform/graphics/IntRect.cpp: (WebCore::IntRect::IntRect):
• platform/graphics/IntRect.h:

6:18 PM Changeset in webkit [17899] by adachan

• 8 edits
  2 moves in trunk

WebCore:

Reviewed by Adam.

Moved WebCoreCache up to WebKit.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreCache.h: Removed.
• bridge/mac/WebCoreCache.mm: Removed.

WebKit:

Reviewed by Adam.

Part of the change to move WebCoreCache into WebKit:
Added WebCache which handles emptying and enable/disabling the cache.
emptyCache and setCacheDisabled have been removed from WebCoreStatistics.

• Misc/WebCache.h: Added.
• Misc/WebCache.mm: Added.
• Misc/WebCoreStatistics.h:
• Misc/WebCoreStatistics.m: (+[WebCoreStatistics statistics]):
• WebKit.exp:
• WebKit.xcodeproj/project.pbxproj:

5:13 PM Changeset in webkit [17898] by thatcher

• 1 edit in tags/WebCore-521.31.1/WebCore/Info.plist

Versioning.

5:12 PM Changeset in webkit [17897] by thatcher

• 1 edit in tags/WebCore-521.31.1/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Merging the build fix from r17888.

5:10 PM Changeset in webkit [17896] by thatcher

• 1 copy in tags/WebCore-521.31.1/WebCore

New tag (part 2.)

5:09 PM Changeset in webkit [17895] by thatcher

• 1 add in tags/WebCore-521.31.1

New tag.

5:06 PM Changeset in webkit [17894] by kmccullo

• 5 edits
  1 move in trunk/LayoutTests

Reviewed by Adam.

• fast/forms/resources/success.html: Removed.
• fast/forms/targeted-frame-submission-expected.checksum:
• fast/forms/targeted-frame-submission-expected.png:
• fast/forms/targeted-frame-submission-expected.txt:
• fast/forms/targeted-frame-submission.html:

4:50 PM Changeset in webkit [17893] by thatcher

• 1 edit in tags/Safari-421.31/JavaScriptGlue/Info.plist

Versioning.

4:49 PM Changeset in webkit [17892] by thatcher

• 1 edit in tags/Safari-421.31/JavaScriptCore/Info.plist

Versioning.

4:49 PM Changeset in webkit [17891] by thatcher

• 1 edit in tags/Safari-421.31/WebKit/Info.plist

Versioning.

4:49 PM Changeset in webkit [17890] by thatcher

• 1 edit in tags/Safari-421.31/WebCore/Info.plist

Versioning.

4:38 PM Changeset in webkit [17889] by thatcher

• 1 copy in tags/Safari-421.31

New tag.

4:29 PM Changeset in webkit [17888] by thatcher

• 1 edit in trunk/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Build fix. Use the CGPDFPage APIs to get the media rect, crop rect and rotation.

3:10 PM Changeset in webkit [22574] by andersca

• 9 edits in branches/WindowsMerge

WebCoreWin:

Remove addMessageToConsole from FrameWin.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Adam.

Add "addMessageToConsole" method to the private ui delegate, and have the client call it.

• Interfaces/IWebUIDelegatePrivate.idl:
• WebFrame.cpp: (WebFrame::addMessageToConsole):
• WebFrame.h:

3:01 PM Changeset in webkit [17887] by kmccullo

• 1 edit
  5 adds in trunk/LayoutTests

Reviewed by Adam and Anders.

Testcase for:
Targeted frame submission.

• fast/forms/resources/success.html: Added.
• fast/forms/targeted-frame-submission-expected.checksum: Added.
• fast/forms/targeted-frame-submission-expected.png: Added.
• fast/forms/targeted-frame-submission-expected.txt: Added.
• fast/forms/targeted-frame-submission.html: Added.

2:59 PM Changeset in webkit [17886] by andersca

• 15 edits in trunk

WebCore:

Reviewed by Adam.

Move addMessageToConsole to Chrome.

• bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
• bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::ScheduledAction::execute):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.h:
• page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole):
• page/Chrome.h:
• page/ChromeClient.h:
• page/Frame.h:

WebKit:

Reviewed by Adam.

Move addMessageToConsole to Chrome.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
• WebCoreSupport/WebFrameBridge.mm:

1:55 PM Changeset in webkit [22573] by beidson

• 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

Added removeAllIcons() for cache clearing

• Interfaces/IWebIconDatabase.idl:
• WebIconDatabase.cpp: (WebIconDatabase::removeAllIcons): Added
• WebIconDatabase.h:

1:30 PM Changeset in webkit [17885] by adele

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

• Fix for ​http://bugs.webkit.org/show_bug.cgi?id=8062 Caret color in new text field should take background color and foreground color into consideration

• editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret): Use the foreground color of the rootEditableElement to determine the caret color. This will work well for text controls in web pages (since the root is always the actual form control) as well as in editable WebViews, like in Mail, which will just pick up the color from the body element.

12:53 PM Changeset in webkit [17884] by beidson

• 3 edits in trunk/WebKit

Reviewed by Anders

Moved unused Private SPI to Internal and pruned other unused code

• Misc/WebIconDatabase.m:
• Misc/WebIconDatabasePrivate.h:

8:04 AM Changeset in webkit [17883] by brmorris

• 3 edits in S60/trunk/S60Tools

2006-11-27 brmorris <​thisisbradley@gmail.com>

Reviewed by me.
DESC: Minor updates to svn2ccm utils

• S60WebKitPlatformBuild.pl: Detailed notification
• svn2ccm.pl: Whitespace only desc to 'undefined synopsis'

Nov 26, 2006:

12:57 PM Changeset in webkit [17882] by zbujtas

• 3 edits in S60/branches/3.1m/WebCore

2006-11-22 w3liu <​wei.liu@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11665
Text decoder regression in S60 browser.

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::fromUnicode): (QTextCodec::toUnicode): (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
• kwq/KWQTextCodec.h:

12:53 PM Changeset in webkit [17881] by zbujtas

• 3 edits in S60/trunk/WebCore

2006-11-22 w3liu <​wei.liu@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11665
Text decoder regression in S60 browser

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::fromUnicode): (QTextCodec::toUnicode): (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
• kwq/KWQTextCodec.h:

5:09 AM Changeset in webkit [17880] by rwlbuis

• 7 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11693
Fix the Qt build, adapt to various enum/class renamings.

Nov 24, 2006:

2:39 PM Changeset in webkit [17879] by rwlbuis

• 6 edits
  4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11666
.getScreenCTM() returns wrong values

Take into account the local transform matrix too and
so fix getScreenCTM/getCTM for <text>.

Nov 22, 2006:

11:16 PM WikiStart edited by mitz@webkit.org

+Writing Layout Tests for DumpRenderTree (diff)

2:02 PM Changeset in webkit [17878] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-21 sareen <​shyam.sareen@nokia.com>

Reviewed by ​sachin.padma@nokia.com
Desc: [S60]Cache not cleared when it gets filled. Cache Handler is not assigned in case of
expired entries.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11663

• ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::RequestL):

1:59 PM Changeset in webkit [17877] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-21 sareen <​shyam.sareen@nokia.com>

Reviewed by ​sachin.padma@nokia.com
Desc: [S60]Cache not cleared when it gets filled. Cache Handler is not assigned in case of
expired entries.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11663

• ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::RequestL):

1:24 PM Changeset in webkit [17876] by rwlbuis

• 3 edits
  4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=11661
SVG: stroke not sensitive to mouse events (hit testing fails)

Use mapAbsolutePointToLocal when hit-testing strokes.

7:49 AM Changeset in webkit [17875] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2006-11-21 w3liu <​wei.liu@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11665
Text decoder regression in 3.1 and 3.0 browser

WARNING: NO TEST CASES ADDED OR CHANGED

• ChangeLog:
• kwq/KWQTextCodec.h:

Nov 21, 2006:

9:14 PM Changeset in webkit [22572] by andersca

• 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Various fixes that make file upload possible.

• bridge/win/FrameWin.h:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm): Change submitForm to take a FrameLoadRequest.

• platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Pass kCFURLWindowsPathStyle to CFURLCreateWithFileSystemPath.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Call the client method.

WebKitWin:

Reviewed by Adam.

Various fixes for getting file upload working.

• WebFrame.cpp: (WebFrame::loadDataSource): Set the header fields on the new request.

(WebFrame::submitForm):

• WebFrame.h: Update submitForm, it now takes a FrameLoadRequest.

• WebMutableURLRequest.cpp: (WebMutableURLRequest::addHTTPHeaderFields): (WebMutableURLRequest::httpHeaderFields):
• WebMutableURLRequest.h: New functions for getting and setting HTTP headers.

8:43 PM Changeset in webkit [22571] by andersca

• 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Forgot to add this file.

8:25 PM Changeset in webkit [22570] by andersca

• 1 edit
  8 adds in branches/WindowsMerge/WebCore

Rubber-stamped by Maciej.

Fork the CF loader.

• WebCore.vcproj/WebCore.vcproj:
• platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
• platform/network/cf/FormDataStreamCFNet.h: Added.
• platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::addHeadersFromHashMap): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
• platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): (WebCore::addHeadersFromHashMap): (WebCore::cfURLRequest):
• platform/network/cf/ResourceRequestCFNet.h: Added.
• platform/network/cf/ResourceResponseCFNet.cpp: Added. (WebCore::getResourceResponse):
• platform/network/cf/ResourceResponseCFNet.h: Added.

4:58 PM Changeset in webkit [22569] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou, Dave Hyatt.

<rdar://problem/4761639>
Group label in list box doesn't appear as bold

<rdar://problem/4805795>
<optgroup> labels should be bold in popup menus

• platform/win/FontPlatformDataWin.cpp: (WebCore::enumStylesCallback): (WebCore::FontPlatformData::FontPlatformData): Enumerate the existing font styles and decide what to synthesize depending on what styles are available.

4:09 PM Changeset in webkit [22568] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Fix build.

• WebCore.vcproj/WebCore.vcproj:

4:03 PM Changeset in webkit [17874] by andersca

• 24 edits in trunk/WebCore

Reviewed by Mitz.

General SVG cleanup. Change some enums to match the style guidelines, use PLATFORM(CG) instead of PLATFORM(MAC).
Remove config.h inluce from AffineTransform.h

• kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
• ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
• ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
• ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
• ksvg2/svg/SVGLinearGradientElement.h: (WebCore::SVGLinearGradientElement::gradientType):
• ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::canvasResource):
• ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
• ksvg2/svg/SVGRadialGradientElement.h: (WebCore::SVGRadialGradientElement::gradientType):
• platform/graphics/AffineTransform.h:
• platform/graphics/svg/SVGPaintServer.h: (WebCore::):
• platform/graphics/svg/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
• platform/graphics/svg/SVGPaintServerGradient.h:
• platform/graphics/svg/SVGPaintServerLinearGradient.h: (WebCore::SVGPaintServerLinearGradient::type):
• platform/graphics/svg/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::type):
• platform/graphics/svg/SVGPaintServerRadialGradient.h: (WebCore::SVGPaintServerRadialGradient::type):
• platform/graphics/svg/SVGPaintServerSolid.h: (WebCore::SVGPaintServerSolid::type):
• platform/graphics/svg/SVGResource.h: (WebCore::):
• platform/graphics/svg/cg/SVGPaintServerCg.cpp: (WebCore::SVGPaintServer::renderPath):
• platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientCache): (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath): (WebCore::SVGPaintServerGradient::setup):
• platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup):
• platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
• rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
• rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):

3:15 PM Changeset in webkit [17873] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-21 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
​http://bugs.webkit.org/show_bug.cgi?id=11670

• ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):

3:11 PM Changeset in webkit [17872] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-21 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
​http://bugs.webkit.org/show_bug.cgi?id=11670

• ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):

10:14 AM Changeset in webkit [17871] by darin

• 7 edits in trunk

WebKit:

Reviewed by Maciej.

• make the close method do a more-complete job to prevent world leaks seen when running some of the layout tests

• WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
• WebView/WebHTMLView.m: (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects. We want to do this at "close" time, rather than waiting for deallocation time. This is especially important for the data source, which indirectly keeps a number of objects alive. (-[WebHTMLView close]): Added an explicit call to clear out the data source on the plug-in controller. Without this, we'd see the plug-in controller making calls to a deallocated data source during the layout tests. Added a call to the new clear method on the private object so that we release the objects at close time instead of waiting for deallocation time.

• WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file, because I can't fight the power.

WebKitTools:

Reviewed by Maciej.

• a couple changes to reduce the chance of false positives on the leakbot

• DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Move the main function into a separate function so we can run a final garbage collect afterward without any stray values on the stack. Replaced the old way of closing down a WebView (setting the delegates to nil) with the new way (calling the close method), which does a more complete job of shutting everything down without waiting for the WebView object to be deallocated. (main): Put auto-release pool here and added an explicit call to garbage collect. With a separate function, we greatly reduce the chance that a stray address on the stack will keep an object alive.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode do its thing, because I don't have what it takes to fight the power.

4:22 AM Changeset in webkit [17870] by zimmermann

• 26 edits
  22 adds
  19 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11658

Move KRenderingPaintServer* classes to the location
of all other resources (platform/graphics/svg).

4:08 AM Changeset in webkit [17869] by bdash

• 3 edits
  4 adds in trunk

2006-11-21 Alex Taylor <​darwin@techvisual.co.nz>

Reviewed by Mitz.

Pixel tests for border radius rendering bug

• ​http://bugs.webkit.org/show_bug.cgi?id=11587

• fast/borders/borderRadiusArcs01-expected.checksum: Added.
• fast/borders/borderRadiusArcs01-expected.png: Added.
• fast/borders/borderRadiusArcs01-expected.txt: Added.
• fast/borders/borderRadiusArcs01.html: Added.

2006-11-21 Alex Taylor <​darwin@techvisual.co.nz>

Reviewed by Mitz.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11587

Adds calculations for bottom right radius's position
which was being drawn incorrectly.

• rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder):

3:58 AM Changeset in webkit [17868] by bdash

• 11 edits in trunk/WebKitSite

2006-11-21 Matt Lilek <​pewtermoose@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11652
Bug 11652: Mailing list address and URL are incorrect

This also removes a lot of bit rot from the KWQ-era.

• coding/contributing.html:
• contact.html:
• projects/css/index.html:
• projects/editing/index.html:
• projects/forms/index.html:
• projects/html/index.html:
• projects/portability/index.html:
• projects/xslt/index.html:
• quality/lifecycle.html:
• quality/testwriting.html:

1:28 AM Changeset in webkit [17867] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11519
REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html

Transport disabled state from DOM element to the shadow
DOM/render object.

Nov 20, 2006:

11:23 PM Changeset in webkit [17866] by bdash

• 1 edit in trunk/WebCore/loader/TextResourceDecoder.cpp

Build fix: silence warning about use before initialization.

3:27 PM Changeset in webkit [17865] by andersca

• 6 edits in trunk/WebCore

Reviewed by Maciej.

• loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding): Use CString instead of DeprecatedCString.

• platform/CString.cpp: (WebCore::CString::find):
• platform/CString.h: (WebCore::CString::data): Add find method, make data method inline.

• platform/TextStream.cpp:
• platform/TextStream.h: Remove DeprecatedCString functions.

2:35 PM Changeset in webkit [17864] by andersca

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Use CString instead of DeprecatedCString.

• html/FormDataList.cpp: (WebCore::FormDataList::appendString): (WebCore::fixLineBreaks): (WebCore::FormDataList::appendFile):

2:35 PM Changeset in webkit [17863] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-20 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Dependencies to SystemSW Internal headers; Browser HttpCacheStreamHandler.cpp
​http://bugs.webkit.org/show_bug.cgi?id=11657

• ResourceLoader/CacheSrc/HttpCacheStreamHandler.cpp:

12:24 PM Changeset in webkit [17862] by ap

• 10 edits in trunk

2006-11-20 W. Andy Carrel <​wac@google.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11501
REGRESSION: \u no longer escapes metacharacters in RegExps
​http://bugs.webkit.org/show_bug.cgi?id=11502
Serializing RegExps doesn't preserve Unicode escapes

JavaScriptCore:

• kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): (Lexer::scanRegExp): Push \u parsing back down into the RegExp object rather than in the parser. This backs out r17354 in favor of a new fix that better matches the behavior of other browsers.

• kjs/lexer.h:
• kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::sanitizePattern): (KJS::isHexDigit): (KJS::convertHex): (KJS::convertUnicode):
• kjs/regexp.h: Translate \u escaped unicode characters for the benefit of pcre.

• kjs/ustring.cpp: (KJS::UString::append): Fix failure to increment length on the first UChar appended to a UString that was copy-on-write.

• tests/mozilla/ecma_2/RegExp/properties-001.js: Adjust tests back to the uniform standards.

LayoutTests:

• fast/js/kde/RegExp-expected.txt:
• fast/js/regexp-unicode-handling-expected.txt: Adjust these test results to passing as a result of other included changes in this revision.

11:58 AM Changeset in webkit [17861] by bdash

• 8 edits in trunk

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Alexey.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ContextMenuClientWin.h:
• bridge/win/EditorClientWin.h:
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::ContextMenuClientWin::lookUpInDictionary): (WebCore::EditorClientWin::shouldInsertText): (WebCore::FrameLoader::reload): (WebCore::FrameWin::ignoreSpelling): (WebCore::FrameWin::learnSpelling):

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Alexey.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

• WebKit.vcproj/WebKit.vcproj: don't include directories that no longer exist.

11:56 AM Changeset in webkit [17860] by ap

• 9 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10736
XMLHttpRequest.responseXML should be null on error

WebCore:

• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::wellFormed):
• dom/XMLTokenizer.h: (WebCore::Tokenizer::wellFormed):
• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implicitClose):
• dom/Document.h: (WebCore::Document::wellFormed): Tell whether XMLTokenizer saw an error. Always true (success) for HTML.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.

LayoutTests:

• http/tests/xmlhttprequest/zero-length-response-expected.txt:
• http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated the results for the new behavior.

10:59 AM Changeset in webkit [17859] by ap

• 16 edits
  5 adds in trunk

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=11633
Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone

WebCore:

• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setXMLVersion): (WebCore::Document::setXMLStandalone):
• dom/Document.h: (WebCore::Document::xmlEncoding): (WebCore::Document::xmlVersion): (WebCore::Document::xmlStandalone): (WebCore::Document::setXMLEncoding):
• dom/Document.idl:
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startDocument): (WebCore::startDocumentHandler): (WebCore::XMLTokenizer::initializeParserContext): Added support for these properties, getting them from an libxml2 context.

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".

• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorObjC.pm: Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.

LayoutTests:

• dom/xhtml/level3/core/documentgetxmlencoding01-expected.txt:
• dom/xhtml/level3/core/documentgetxmlencoding03-expected.txt
• dom/xhtml/level3/core/documentgetxmlstandalone04-expected.txt:
• dom/xhtml/level3/core/documentgetxmlversion01-expected.txt:
• dom/xhtml/level3/core/documentgetxmlversion02-expected.txt:
• dom/xhtml/level3/core/documentgetxmlversion03-expected.txt: These now pass.

• dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Re-added a correct test.

• fast/dom/Window/window-properties-expected.txt: Added these new properties.

• http/tests/xmlhttprequest/xml-encoding-expected.txt: Added.
• http/tests/xmlhttprequest/xml-encoding.html: Added.
• http/tests/xmlhttprequest/resources/xml-encoding.xml: Added.
• http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi: Added. Test how xmlEncoding interacts with XMLHttpRequest.

8:12 AM Changeset in webkit [17858] by zimmermann

• 9 edits in trunk/WebCore

Reviewed by Rob.
Fix Qt/Linux build.

7:42 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

(diff)

5:14 AM Changeset in webkit [17857] by bdash

• 1 add in trunk/WebCore/platform/graphics/svg/qt/SVGResourceFilterQt.cpp

Qt build fix after r17853: add missing SVGResourceFilterQt.cpp.

4:59 AM Changeset in webkit [17856] by bdash

• 7 edits in trunk

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

• kjs/config.h: define NOMINMAX instead of min/max as themselves.
• wtf/Vector.h: put back hack to ensure that min/max are not defined as macros.

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

• config.h: add #define NOMINMAX for windows build
• platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
• platform/win/TemporaryLinkStubs.cpp: add definitions for new cursors. (WebCore::aliasCursor): (WebCore::noDropCursor): (WebCore::progressCursor):

2:13 AM Changeset in webkit [22567] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Add the same include paths to the debug build.

• WebCore.vcproj/WebCore.vcproj:

1:42 AM Changeset in webkit [22566] by andersca

• 2 edits
  1 move in branches/WindowsMerge/WebCore

Fix build.

• WebCore.vcproj/WebCore.vcproj:
• kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
• platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):

1:39 AM Changeset in webkit [22565] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

Fix build.

• WebEditorClient.cpp: (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText):
• WebEditorClient.h:

Nov 19, 2006:

10:51 PM TitleIndex edited by pewtermoose@gmail.com

removing spam (diff)

10:51 PM Writing Layout Tests for DumpRenderTree edited by pewtermoose@gmail.com

removing spam (diff)

10:48 PM TracInstall edited by pewtermoose@gmail.com

removing spam (diff)

10:48 PM TracGuide edited by pewtermoose@gmail.com

removing spam (diff)

5:27 PM Changeset in webkit [22564] by bdakin

• 9 edits in branches/WindowsMerge

WebCore:

Reviewed by Adam.

Boomer part of context menu actions.

• bridge/win/FrameWin.h: New spelling functions on Frame.
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenu::hide):
• platform/win/TemporaryLinkStubs.cpp: New stubs. (FrameWin::ignoreSpelling): (FrameWin::learnSpelling): (FrameLoader::reload):

WebKit:

Reviewed by Adam.

• WebContextMenuClient.cpp: Stubs for the currently client- dependent menu actions. (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::lookUpInDictionary):
• WebContextMenuClient.h:
• WebEditorClient.cpp: (WebEditorClient::shouldInsertText): Remove comment markers since this is implemented now on the Mac.
• WebEditorClient.h:

5:21 PM Changeset in webkit [17855] by bdakin

• 24 edits
  1 add in trunk

WebCore:

Reviewed by Adam.

Implementation of actions for the new context menus.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h: Declaration of shouldInsertText.
• bridge/mac/FrameMac.h: Two new spelling functions.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::ignoreSpelling): (WebCore::FrameMac::learnSpelling):
• editing/Editor.cpp: (WebCore::Editor::shouldInsertText): Call into the client.
• editing/Editor.h:
• editing/EditorInsertAction.h: Added. (WebCore::): The WebCore equivalent of WebViewInsertAction. This is defined in its own header so that we can use it from Editor.h and EditorClient.h without having one of the above include the other.
• page/ContextMenuClient.h: A few currently WebKit-implemented function needed for menu actions.
• page/ContextMenuController.cpp: (WebCore::makeGoogleSearchURL): (WebCore::ContextMenuController::contextMenuActionSelected): The actions!
• page/ContextMenuController.h:
• page/Frame.h: New pure-virtual spelling functions.
• platform/ContextMenu.cpp: (WebCore::ContextMenu::controller): Get the controller from the menu.
• platform/ContextMenu.h:
• platform/mac/ContextMenuMac.mm: (-[MenuTarget forwardContextMenuAction:initWithContextMenuController:WebCore::]): Use the controller instead of the menu (-[MenuTarget WebCore::]): (-[MenuTarget setMenuController:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::show): (ContextMenu::hide):

WebKit:

Reviewed by Adam.

WebKit side of new context menu actions.

• WebCoreSupport/WebContextMenuClient.h: These are for the currently-WebKit-dependent menu actions.
• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::searchWithSpotlight): (WebContextMenuClient::lookUpInDictionary):
• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (core): These are to convert between WebViewInsertAction and EditorInsertAction. (kit): (WebEditorClient::shouldInsertText): Added implementation for shouldInsertText.
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved _lookUpInDictionary to be within the implementation of WebHTMLView internal.
• WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
• WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu

2:22 PM Changeset in webkit [17854] by ap

• 1 edit
  3 deletes in trunk/LayoutTests

Removed parts of an incorrectly committed test, to be re-added later.

• dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Removed.
• dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Removed.
• dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Removed.

1:25 PM TracGuide edited by asas@asas.com

(diff)

1:25 PM TracInstall edited by asas@asas.com

(diff)

1:24 PM Writing Layout Tests for DumpRenderTree edited by asas@asas.com

(diff)

1:23 PM TitleIndex edited by asas@asas.com

(diff)

12:13 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

Added GCController (diff)

10:39 AM Changeset in webkit [17853] by staikos

• 13 edits in trunk

top level:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649

• CMakeLists.txt: Fix Qt-only build without KDE cmake files

JavaScriptCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake Qt-only build without KDE CMake files

• CMakeLists.txt:
• pcre/CMakeLists.txt:

WebCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake files for Qt-only build without KDE cmake files.
Fix Qt/KDE build for the SVG support.
Fix Qt-only build in the resource handler.

• CMakeLists.txt:
• platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
• platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::deliverJobData):
• platform/network/qt/ResourceHandleManager.h:
• platform/network/qt/ResourceHandleQt.cpp:
• platform/qt/CursorQt.cpp: (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::aliasCursor):

WebKitQt:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix Qt-only build

• QtLauncher/CMakeLists.txt:

1:12 AM Changeset in webkit [17852] by ap

• 2 edits
  4 adds
  1 delete in trunk

2006-11-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=11626 Automate test for rdar://problem/4056100

WebCore:

• manual-tests/delete-into-nested-block.html: Removed.

LayoutTests:

• fast/repaint/delete-into-nested-block-expected.checksum: Added.
• fast/repaint/delete-into-nested-block-expected.png: Added.
• fast/repaint/delete-into-nested-block-expected.txt: Added.
• fast/repaint/delete-into-nested-block.html: Added.

Nov 18, 2006:

11:20 PM Changeset in webkit [22563] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:18 PM Changeset in webkit [17851] by sfalken

• 1 copy in tags/Safari-521.31b

New tag.

6:44 PM Changeset in webkit [17850] by zimmermann

• 59 edits
  41 copies
  61 adds
  6 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11596

Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.

This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.

4:47 PM Changeset in webkit [17849] by andersca

• 1 edit
  2 adds in trunk/LayoutTests

Reviewed by Darin.

Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.

• fast/dom/node-filter-gc-expected.txt: Added.
• fast/dom/node-filter-gc.html: Added.

3:45 PM Changeset in webkit [22562] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix from OpenSource r17841.

• platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):

2:59 PM Changeset in webkit [17848] by rwlbuis

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

• fast/css/target-fragment-match-expected.checksum: Added.
• fast/css/target-fragment-match-expected.png: Added.
• fast/css/target-fragment-match-expected.txt: Added.
• fast/css/target-fragment-match.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):

12:58 PM Changeset in webkit [17847] by ap

• 10 edits
  2 adds in trunk

2006-11-18 Don Gibson <​dgibson77@gmail.com>

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
• bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
• bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• bridge/win/FrameWin.h: (WebCore::Win):
• loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):

WebKit:

• COM/WebFrame.cpp: (WebFrame::initWithName):

12:19 PM Changeset in webkit [17846] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2006-11-16 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
​http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):

12:17 PM Changeset in webkit [17845] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-16 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
​http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):

11:29 AM Changeset in webkit [17844] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-16 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix for tabbed navigation
​http://bugs.webkit.org/show_bug.cgi?id=11619

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):

11:25 AM Changeset in webkit [17843] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-16 shkeller <​shaun.keller@nokia.com>

Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
​http://bugs.webkit.org/show_bug.cgi?id=11608

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):

5:52 AM Changeset in webkit [17842] by ap

• 5 edits in trunk

Reviewed by Rob (yay!).

​http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication

WebCore:

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.

LayoutTests:

• http/tests/xmlhttprequest/basic-auth-expected.txt:
• http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.

3:24 AM Nightly Builds edited by mitz@webkit.org

Changed to talk about Safari extensions in general rather than about a … (diff)

3:01 AM Known incompatibilities between open-source WebKit and Safari edited by mitz@webkit.org

Deleted obsolete information. The context menu items are present and … (diff)

2:00 AM Changeset in webkit [17841] by ap

• 9 edits
  3 adds in trunk/WebCore

2006-11-17 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles

• Resources/aliasCursor.png: Added.
• Resources/noDropCursor.png: Added.
• Resources/progressCursor.png: Added.
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSValueKeywords.in:
• manual-tests/cursor.html:
• page/EventHandler.cpp: (WebCore::selectCursor):
• platform/Cursor.h:
• platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
• rendering/RenderStyle.h: (WebCore::):

1:30 AM Changeset in webkit [17840] by ap

• 2 edits in trunk/WebKitSite

2006-11-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Gender-neutrality fix.

• coding/contributing.html:

1:29 AM Changeset in webkit [17839] by sfalken

• 2 edits in trunk/WebCore

2006-11-18 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Properly adjust CFAbsoluteTime to time_t to fix date calculations.

Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.

• platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment

Nov 17, 2006:

9:57 PM Changeset in webkit [17838] by andersca

• 10 edits in trunk/WebCore

Reviewed by Geoff.

More conversions from DeprecatedValueList to Vector and HashSet.

• css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
• css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
• dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
• dom/Document.h:
• ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
• ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
• platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
• platform/graphics/svg/SVGResource.h:
• rendering/RenderBlock.h:

7:29 PM Changeset in webkit [22561] by andersca

• 19 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Add #defines in config.h to prevent the min and max macros from being used.

• bridge/win/FrameWin.cpp:
• config.h:
• platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
• platform/win/PopupMenuWin.cpp:
• plugins/win/PluginStreamWin.cpp:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Reviewed by Adam.

Make sure that all .cpp files and none of the headers include config.h.

• MemoryStream.cpp:
• WebBackForwardList.cpp:
• WebBackForwardList.h:
• WebElementPropertyBag.cpp:
• WebHTMLRepresentation.cpp:
• WebKitClassFactory.cpp:
• WebKitDLL.cpp:
• WebMutableURLRequest.cpp:
• WebMutableURLRequest.h:
• WebURLResponse.cpp:
• WebURLResponse.h:

7:15 PM Changeset in webkit [17837] by andersca

• 4 edits in trunk/JavaScriptCore

2006-11-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Make sure that we always use std::min and std::max instead of macros.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• kjs/config.h:
• wtf/Vector.h:

7:09 PM Changeset in webkit [22560] by kmccullo

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

• Fixes Targetted Form Submission to now work. Radar: 4762693

• ChangeLog:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):

6:24 PM Changeset in webkit [17836] by thatcher

• 1 edit in trunk/WebCore/editing/EditCommand.cpp

Fixing the assertion failure, forgot to remove an enable() call.

5:24 PM Changeset in webkit [17835] by thatcher

• 1 edit
  8 copies in tags/Safari-521.31

New tag.

5:21 PM Changeset in webkit [17834] by thatcher

• 6 edits in /

Versioning

5:06 PM Changeset in webkit [17833] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

Disable the delete button controller when cloning nodes, Mail does this before saving a draft.

• dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
• editing/markup.cpp: (WebCore::createFragmentFromNodes):

5:04 PM Changeset in webkit [17832] by justing

• 9 edits
  12 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

Fixed:

• editing/pasteboard/merge-end-blockquote-expected.checksum:
• editing/pasteboard/merge-end-blockquote-expected.png:
• editing/pasteboard/merge-end-blockquote-expected.txt:
• editing/pasteboard/merge-end-blockquote.html:

Added:

• editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
• editing/pasteboard/paste-blockquote-1-expected.png: Added.
• editing/pasteboard/paste-blockquote-1-expected.txt: Added.
• editing/pasteboard/paste-blockquote-1.html: Added.
• editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
• editing/pasteboard/paste-blockquote-2-expected.png: Added.
• editing/pasteboard/paste-blockquote-2-expected.txt: Added.
• editing/pasteboard/paste-blockquote-2.html: Added.
• editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
• editing/pasteboard/paste-blockquote-3-expected.png: Added.
• editing/pasteboard/paste-blockquote-3-expected.txt: Added.
• editing/pasteboard/paste-blockquote-3.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

• editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
• editing/ReplaceSelectionCommand.h:
• editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.

4:22 PM Changeset in webkit [17831] by thatcher

• 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Forgoet the project change.

4:21 PM Changeset in webkit [17830] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves

• WebKit.xcodeproj/project.pbxproj:
• WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):

4:04 PM Changeset in webkit [22559] by darin

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

• fix leak of Document ref count seen in updateCounterpartURLForRSS

• WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.

12:14 PM Changeset in webkit [17829] by rwlbuis

• 2 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build

Fix the issue and do style guideline corrections.

11:47 AM Changeset in webkit [17828] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it

Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

• editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
• editing/EditCommand.h:

11:42 AM Changeset in webkit [22558] by darin

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

• fix leak of WebView when you close a tab or window

• Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.

• WebView.h: Added close function.
• WebView.cpp: (WebView::close): First cut at implementation of close.

11:23 AM Changeset in webkit [17827] by zimmermann

• 13 edits
  5 adds in trunk

Reviewed by Mitz. Landed by Niko.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.

11:21 AM Changeset in webkit [17826] by harrison

• 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer

Replace an assert with a fixme that refers to this bug.

• page/Frame.cpp: (WebCore::Frame::revealSelection):

Nov 16, 2006:

7:04 PM Changeset in webkit [22557] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Ada.

Added new WebMenuItemBaseApplicationTag to the WebMenuItemTag enum to
keep WebKit apps from conflicting with WebKit context menu identifiers.

• Interfaces/IWebUIDelegate.idl:

6:11 PM Changeset in webkit [17825] by beidson

• 10 edits
  4 adds in trunk

LayoutTests:

Reviewed and landed by Brady

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render

• fast/css/import-rule-regression-11590-expected.txt: Added.
• fast/css/import-rule-regression-11590.html: Added.
• fast/css/resources/imports.css: Added.
• fast/css/resources/style.css: Added.

WebCore:

Reviewed and landed by Brady

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.

• css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
• dom/Node.h: (WebCore::Node::sheetLoaded):
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
• dom/ProcessingInstruction.h:
• html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded):
• html/HTMLLinkElement.h:
• html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded):
• html/HTMLStyleElement.h:

5:06 PM Changeset in webkit [17824] by harrison

• 8 edits
  1 add in trunk/WebCore

Reviewed by Beth.

<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message

The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.

Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.

Test added:

• manual-tests/delete-into-nested-block.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats):
• rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
• rendering/RenderBox.h:
• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
• rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved):
• rendering/RenderObject.h:
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):

4:07 PM Changeset in webkit [22556] by adele

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Added theme for sider.

• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::sliderTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineSliderThumbState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::adjustSliderThumbSize):
• rendering/RenderThemeWin.h:

4:03 PM Changeset in webkit [17823] by adele

• 7 edits in trunk/WebCore

Reviewed by Adam.

Slider cleanup. Let the theme set the size of the slider thumb.

• rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
• rendering/RenderTheme.h: ditto.
• rendering/RenderThemeMac.h: ditto.
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.

3:34 PM Changeset in webkit [17822] by spadma

• 3 edits in S60/branches/3.1m/WebKit

2006-11-15 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
​http://bugs.webkit.org/show_bug.cgi?id=110606

• BrowserView/inc/WebKitControl.h:
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):

3:27 PM Changeset in webkit [17821] by spadma

• 3 edits in S60/trunk/WebKit

2006-11-15 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
​http://bugs.webkit.org/show_bug.cgi?id=110606

• BrowserView/inc/WebKitControl.h:
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):

3:24 PM Changeset in webkit [17820] by spadma

• 7 edits in S60/trunk/WebKit

2006-11-16 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Fix copyright issues
​http://bugs.webkit.org/show_bug.cgi?id=11620

• BrowserView/inc/WidgetExtension.h:
• BrowserView/inc/WidgetPreferences.h:
• BrowserView/inc/WidgetRenderer.h:
• BrowserView/src/WidgetExtension.cpp:
• BrowserView/src/WidgetPreferences.cpp:
• BrowserView/src/WidgetRenderer.cpp: (TWidgetRenderer::TWidgetRenderer): (TWidgetRenderer::PrepareForTransitionL): (TWidgetRenderer::PerformTransitionL): (TWidgetRenderer::TransitionCb): (TWidgetRenderer::DrawFadeMaskL): (TWidgetRenderer::DrawTransition):

2:54 PM Changeset in webkit [17819] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Feeds Engine / Form element in feed article: If input box is selected the browser crashes.
​http://bugs.webkit.org/show_bug.cgi?id=11603

• BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):

1:22 PM Changeset in webkit [17818] by andersca

• 19 edits in trunk/WebCore

Reviewed by Darin.

Use Vector instead of DeprecatedValueList in a few places.

• bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
• bindings/js/kjs_dom.h:
• bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems):
• bindings/objc/DOM.mm:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary):
• css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff):
• html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems):
• html/HTMLCollection.h:
• kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
• kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
• ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
• platform/graphics/svg/SVGResourceClipper.h:
• platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
• platform/network/FormData.h:
• rendering/RenderPath.h:
• rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):

1:03 PM Changeset in webkit [17817] by andersca

• 2 edits in trunk/WebCore

Reviewed by Tim.

• editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents.

12:32 PM Changeset in webkit [17816] by ap

• 23 edits
  2 adds
  1 delete in trunk

2006-11-16 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by ap.

​http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.

Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
• bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
• bridge/win/EditorClientWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress):
• bridge/win/FrameWin.h:
• bridge/win/PageWin.cpp: Removed.
• editing/EditCommand.h:
• loader/FormState.h:
• loader/FrameLoader.h:
• page/EventHandler.cpp:
• platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
• platform/graphics/win/ImageWin.cpp:
• platform/network/ResourceError.cpp:
• platform/network/ResourceHandleInternal.h:
• platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
• platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth):
• platform/win/SoundWin.cpp: Added. (WebCore::systemBeep):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
• platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus):

WebKit:

• COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData):
• COM/WebFrame.h:
• COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
• WebKit.vcproj/WebKit.vcproj:

11:58 AM Changeset in webkit [17815] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

• editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup

11:52 AM Changeset in webkit [17814] by staikos

• 3 edits in trunk/WebCore

Rubberstamped by Maciej.

Making the code valgrind clean.

11:49 AM Changeset in webkit [17813] by andersca

• 2 edits in trunk/WebKit

Reviewed by Tim.

<rdar://problem/4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message

• Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points.

10:35 AM Changeset in webkit [17812] by thatcher

• 1 edit in trunk/WebCore/editing/DeleteButtonController.h

Adding back a correct version of this assert.

9:59 AM Changeset in webkit [17811] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin and Tim.

<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode().

9:52 AM Changeset in webkit [17810] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected

Consider the container of the selection range for deletion before asking enclosingNodeOfType().

• editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):

9:09 AM Changeset in webkit [17809] by spadma

• 6 edits in S60/branches/3.1m/WebKit

2006-11-16 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
​http://bugs.webkit.org/show_bug.cgi?id=11605

• BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
• BrowserView/inc/BrowserSettingsContainer.h:
• BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
• Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):

12:43 AM Changeset in webkit [17808] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by hyatt.

Removal of unused m_styleElement.

Nov 15, 2006:

11:14 PM Changeset in webkit [17807] by aroben

• 4 edits in trunk/WebCore

Build fix.

Rename the items in the ContextMenuAction enum so that they don't
conflict with WebKit names.

• WebCore.xcodeproj/project.pbxproj:
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
• platform/ContextMenu.h: (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem):

10:56 PM Changeset in webkit [17806] by aroben

• 4 edits in trunk/WebCore

Reviewed by Anders.

Change m_contextMenu to an OwnPtr.

• WebCore.xcodeproj/project.pbxproj:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
• page/ContextMenuController.h:

10:50 PM Changeset in webkit [22555] by aroben

• 8 edits
  2 copies in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Added new ContextMenuClient and ContextMenuController classes.

• WebCore.vcproj/WebCore.vcproj: Added new files.
• platform/win/ContextMenuWin.cpp: Added method implementations Beth forgot to check in in r11129. (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::appendItem):

WebKitWin:

Reviewed by Anders.

Added new WebContextMenuClient class, and moved context menu-related
code there from WebChromeClient.

• WebChromeClient.cpp: (WebChromeClient::setResizable):
• WebChromeClient.h:
• WebContextMenuClient.cpp: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
• WebContextMenuClient.h: Added.
• WebKit.vcproj/WebKit.vcproj: Added new files.
• WebView.cpp: (WebView::initWithFrame):

10:43 PM Changeset in webkit [17805] by aroben

• 15 edits
  5 copies in trunk

WebCore:

Reviewed by Anders.

Add new ContextMenuController and ContextMenuClient classes, and move
context menu responsibilities from Chrome and ChromeClient to them.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj: Add new files to project, and alphabetize some others.
• page/Chrome.cpp: Remove context menu-related code.
• page/Chrome.h: Ditto.
• page/ChromeClient.h:
• page/ContextMenuClient.h: Added.
• page/ContextMenuController.cpp: Added. (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::~ContextMenuController): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::contextMenuActionSelected):
• page/ContextMenuController.h: Added. (WebCore::ContextMenuController::client):
• page/Page.cpp: Every Page now has a ContextMenuController. (WebCore::Page::Page):
• page/Page.h: Made m_dragCaretController and m_chrome objects instead of pointers to objects. (WebCore::Page::contextMenuController):
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the delegate to add its menu items, and moved the code from the static addDefaultItems function into this method.
• platform/ContextMenu.h: (WebCore::ContextMenu::show): Added an empty method body since this method is now called from ContextMenuController (although no one calls into ContextMenuController yet, so it's OK for this to be empty). (WebCore::ContextMenu::hide): Ditto.

WebKit:

Reviewed by Anders.

Added new WebContextMenuClient class to act as WebCore's ChromeClient,
and moved context menu-related code there from WebChromeClient.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:
• WebCoreSupport/WebContextMenuClient.h: Added. (WebContextMenuClient::webView):
• WebCoreSupport/WebContextMenuClient.mm: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
• WebKit.xcodeproj/project.pbxproj: Added new files.
• WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

9:53 PM Changeset in webkit [17804] by thatcher

• 1 edit in trunk/WebCore/editing/DeleteButtonController.h

Removing this assert until I can look into the problem further.

8:23 PM Changeset in webkit [17803] by andersca

• 3 edits in trunk/WebCore

Reviewed by Darin.

Add null checks on the node filter, they can be null if no filter was passed to the respective
create functions.

• bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
• bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):

7:13 PM Changeset in webkit [22554] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed flash of plug-in content outside its containing iframe while
scrolling the iframe.

The problem was that the plug-in would draw between our call to MoveWindow
and our call to SetWindowRgn. The solution here is to lock all updates in
the plug-in's HWND until we've called both MoveWindow and SetWindowRgn.

Tested with Quicktime and Flash.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::geometryChanged):
• plugins/win/PluginViewWin.h: Removed bogus invalidate parameter to updateHwnd.

7:07 PM Changeset in webkit [17802] by oliver

• 4 edits in trunk/WebCore

2006-11-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Allow <embed> and <object> tags to include non-plugin
content when plugins are disabled

Fixes <rdar://problems/4839488>

• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):

6:34 PM Changeset in webkit [17801] by adele

• 2 edits in trunk/WebCore

Build fix. Another type problem that I don't see locally.

• rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):

6:24 PM Changeset in webkit [17800] by adele

• 2 edits in trunk/WebCore

Reviewed by Adam.

Adding MathExtras header.

• rendering/RenderSlider.cpp:

6:00 PM Changeset in webkit [17799] by thatcher

• 5 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)

• Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.

• Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.

• Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().

• editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::isDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed (WebCore::DeleteButtonController::deleteTarget): check the enabled state
• editing/DeleteButtonController.h: (WebCore::DeleteButtonController::disable): (WebCore::DeleteButtonController::enable): (WebCore::DeleteButtonController::enabled):
• editing/EditCommand.cpp: (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end (WebCore::EditCommand::unapply): ditto (WebCore::EditCommand::reapply): ditto

5:46 PM Changeset in webkit [22553] by adele

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Adding RenderSlider class, and removing DeprecatedSlider and Slider classes.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp:

5:42 PM Changeset in webkit [17798] by adele

• 20 edits
  2 adds
  4 deletes in trunk

LayoutTests:

Reviewed by Adam.

Updating results for new slider implementation.

• fast/forms/input-appearance-height-expected.checksum:
• fast/forms/input-appearance-height-expected.png:
• fast/forms/input-appearance-height-expected.txt:

WebCore:

Reviewed by Adam.

New implementation of slider control.

• WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
• rendering/DeprecatedSlider.cpp: Removed.
• rendering/DeprecatedSlider.h: Removed.
• platform/Slider.h: Removed.
• platform/mac/SliderMac.mm: Removed.
• platform/win/TemporaryLinkStubs.cpp:

• css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
• css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
• rendering/RenderStyle.cpp: (WebCore::): (WebCore::pseudoBit):
• rendering/RenderStyle.h: (WebCore::RenderStyle::):

• css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements. (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.

• page/EventHandler.cpp: Added concept of a node that will capture all mouse events. This will be used by the slider thumb, so it can continue to capture mouse move events during the drag, even though those events aren't directly over the slider. (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::setCapturingMouseEventsNode): (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
• page/EventHandler.h:

• rendering/RenderSlider.cpp: Added. (WebCore::HTMLSliderThumbElement::isShadowNode): (WebCore::HTMLSliderThumbElement::shadowParentNode): (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode. (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement): (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag. (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::~RenderSlider): (WebCore::RenderSlider::baselinePosition): (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track. (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::valueChanged): (WebCore::RenderSlider::currentPosition): (WebCore::RenderSlider::setCurrentPosition): (WebCore::RenderSlider::trackSize): (WebCore::RenderSlider::forwardEvent): (WebCore::RenderSlider::inDragMode):
• rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName):

• rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):

• rendering/RenderTheme.h: (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb):
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle):

5:36 PM Changeset in webkit [17797] by bdakin

• 1 edit
  1 add in trunk/WebCore

Reviewed by Adam.

Oops! Forgot to add this!

• platform/mac/ContextMenuMac.mm: Added. (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]): (-[MenuTarget WebCore::]): (-[MenuTarget setMenu:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformMenuDescription):

5:33 PM Changeset in webkit [22552] by bdakin

• 5 edits
  1 add in branches/WindowsMerge

WebCore:

Reviewed by Adam and Beth.

Internal side of r17796.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/ContextMenuWin.cpp: Added. (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformMenuDescription):

WebKit:

Reviewed by Adam and Beth.

Internal side of r17796.

• WebChromeClient.cpp: (WebChromeClient::addCustomContextMenuItems):
• WebChromeClient.h:

5:27 PM Changeset in webkit [17796] by bdakin

• 10 edits
  2 adds in trunk

WebCore:

Reviewed by Adam and Beth.

Initial cut at pushing Context Menus into WebCore. Nobody actually
calls this code just yet.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• page/Chrome.cpp: (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to call into addContextMenuItems on the UIDelegate.
• page/Chrome.h:
• page/ChromeClient.h:
• platform/ContextMenu.cpp: Added. (WebCore::addDefaultItems): (WebCore::ContextMenu::populate):
• platform/ContextMenu.h: Added. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformMenuDescription):

WebKit:

Reviewed by Adam & Beth.

WebKit side of first cut at engine context menus. Use the client to
call into the UIDelegate.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addCustomContextMenuItems):
• WebKit.xcodeproj/project.pbxproj:

4:56 PM Changeset in webkit [17795] by beidson

• 2 edits
  2 moves in trunk/WebKit

Reviewed by Maciej

Quick change of files to ObjC++ for BF cache re-write

• History/WebBackForwardList.m: Removed.
• History/WebBackForwardList.mm: Added.
• History/WebHistoryItem.m: Removed.
• History/WebHistoryItem.mm: Added.
• WebKit.xcodeproj/project.pbxproj:

3:49 PM Changeset in webkit [17794] by adele

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

• Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org

• css/html4.css: Removed "-webkit-user-select: ignore" for labels.

2:34 PM Changeset in webkit [17793] by spadma

• 7 edits in S60/trunk/WebKit

2006-11-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
​http://bugs.webkit.org/show_bug.cgi?id=11605

• BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
• BrowserView/inc/BrowserSettingsContainer.h:
• BrowserView/inc/WebKitControl.h: (CWebKitControl::PluginHandler): (CWebKitControl::AccessPointId): (CWebKitControl::SetAccessPointId):
• BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
• Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL): (CPluginSkin::ConstructL):

2:08 PM Changeset in webkit [22551] by adachan

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-15 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

Fixed a bad free in DllRegisterServer.

1:44 PM Changeset in webkit [17792] by beidson

• 4 edits in trunk/WebKit

Reviewed by Sarge

SPI addition

• WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
• WebView/WebFrameInternal.h:
• WebView/WebFramePrivate.h:

12:09 PM Changeset in webkit [17791] by spadma

• 5 edits in S60/branches/3.1m/WebKit

2006-11-15 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
​http://bugs.webkit.org/show_bug.cgi?id=11602

• BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
• BrowserView/inc/WebKitLoader.h:
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):

12:06 PM Changeset in webkit [17790] by spadma

• 5 edits in S60/trunk/WebKit

2006-11-15 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
​http://bugs.webkit.org/show_bug.cgi?id=11602

• BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
• BrowserView/inc/WebKitLoader.h:
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):

12:04 PM Changeset in webkit [17789] by spadma

• 3 edits in S60/trunk/WebCore

2006-11-13 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Valid email address cannot be identified on a page when smart text is on. Remove garbage characters from being appended to descriptor prior to calling the FindItemEngine.
​http://bugs.webkit.org/show_bug.cgi?id=11589

WARNING: NO TEST CASES ADDED OR CHANGED

• bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL):
• bridge/WebCoreBridge.h:

11:46 AM Changeset in webkit [17788] by beidson

• 3 edits in trunk/WebKit

Reviewed by Adele

<rdar://problem/4838729> - Replace mistakenly removed SPI

• WebView/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
• WebView/WebHTMLViewPrivate.h:

11:41 AM Changeset in webkit [17787] by thatcher

• 4 edits in trunk

Explicitly set GCC 4 for all of our projects, since the system default can be GCC 3.3.

11:35 AM Changeset in webkit [17786] by harrison

• 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)

Test:

• manual-tests/keep_spelling_markers.html: Updated to include checking for this bug.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): it.advance() even when current string is a single space.

11:25 AM Changeset in webkit [22550] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Take another pass at fixing COM registration

• WebKitDLL.cpp: (substituteGUID):

11:24 AM Changeset in webkit [17785] by beidson

• 4 edits in trunk/WebCore

Reviewed by lamadio

Backing out macro expansion

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
• ksvg2/scripts/make_names.pl:

10:41 AM Changeset in webkit [17784] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4770453> VO not honoring secure edit fields in web pages

The remaining problem was the password fields would return their contents
even though they did not advertise that they could. Apparently, VoiceOver
does not read the ads.

• bridge/mac/WebCoreAXObject.mm: (isPasswordFieldElement): (-[WebCoreAXObject isPasswordField]): (-[WebCoreAXObject textMarkerForVisiblePosition:]): (-[WebCoreAXObject accessibilityAttributeValue:]): (-[WebCoreAXObject doAXStringForRange:]):

10:21 AM Changeset in webkit [22549] by andersca

• 8 edits in branches/WindowsMerge

WebCoreWin:

2006-11-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Remove some (now) obsolete methods.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::getAppletInstanceForWidget): (FrameWin::issuePasteCommand): (FrameWin::respondToChangedSelection):

WebKitWin:

2006-11-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Add an undo manager to the editor client. Make it possible for applications to invoke undo/redo.

• Interfaces/IWebView.idl:
• WebEditorClient.cpp: (WebUndoManager::WebUndoManager): (WebUndoManager::~WebUndoManager): (WebUndoManager::clearCommands): (WebUndoManager::registerCommand): (WebUndoManager::undo): (WebUndoManager::redo): (WebUndoManager::canUndo): (WebUndoManager::canRedo): (WebUndoManager::undoOrRedo): (WebEditorClient::WebEditorClient): (WebEditorUndoCommand::WebEditorUndoCommand): (WebEditorUndoCommand::execute): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
• WebEditorClient.h:
• WebView.cpp: (WebView::execCommand):

10:19 AM Changeset in webkit [17783] by lamadio

• 3 edits in trunk/WebCore

2006-11-13 Lou Amadio <​lamadio@apple.com>

Reviewed by Darin Adler, Maciej Stachowiak

Cleanup: Expanded macros in generated files

• html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
• ksvg2/scripts/make_names.pl:

10:01 AM Changeset in webkit [22548] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Fix bug in my last check-in preventing proper COM registration

• WebKitDLL.cpp: (DllRegisterServer):

9:34 AM Changeset in webkit [17782] by andersca

• 4 edits in trunk/WebCore

Reviewed by Geoff.

Use Vector instead of DeprecatedPtrList.

• editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
• editing/BreakBlockquoteCommand.cpp:
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline):

9:24 AM Changeset in webkit [17781] by andersca

• 5 edits in trunk/WebKit

Reviewed by Adele.

isTargetItem is used by DRT, so make it private instead of internal.

• History/WebHistoryItem.m: (-[WebHistoryItem isTargetItem]):
• History/WebHistoryItemInternal.h:
• History/WebHistoryItemPrivate.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

8:51 AM Changeset in webkit [22547] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Remove header from vcproj that no longer exists

• WebCore.vcproj/WebCore.vcproj:

8:40 AM Changeset in webkit [22546] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Fix the B&I build

• WebCore.vcproj/WebCore.vcproj:

7:52 AM Changeset in webkit [22545] by sfalken

• 4 edits in branches/WindowsMerge/WebKitWin

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Use separate CLSIDs for buildbot builds.

This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).

• Interfaces/WebKit.idl: Add a second set of CLSIDs for builbot-based builds.
• WebKit.vcproj/Interfaces.vcproj: Add a preprocessor define BUILDBOT set to 1 for official builds, 0 otherwise (use #if to check).
• WebKitDLL.cpp: Convert CLSIDs to strings via code instead of copying string literals from elsewhere. (substituteGUID): Added. (DllUnregisterServer): Substitute CLSIDs into reg keys. (DllRegisterServer): Substitute CLSIDs into reg keys.

2006-11-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Use separate CLSIDs for buildbot builds.

This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).

4:21 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

(diff)

4:15 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

Added some don'ts (diff)

2:12 AM Changeset in webkit [22544] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

It's too early in the morning to be fixing the build.

• WebEditorClient.cpp: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):

2:05 AM Changeset in webkit [22543] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

Build fix.

• WebEditorClient.cpp: (selectWordBeforeMenuEvent): (isEditable):
• WebEditorClient.h:

1:45 AM Changeset in webkit [17780] by aroben

• 2 edits in trunk/WebCore

Build fix.

• page/EventHandler.h:

1:29 AM Changeset in webkit [17779] by beidson

• 10 edits
  1 add in trunk/WebKit

Reviewed by Maciej

Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h

• History/WebBackForwardList.m:
• History/WebHistory.m:
• History/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
• History/WebHistoryItemInternal.h: Added.
• History/WebHistoryItemPrivate.h:
• WebCoreSupport/WebFrameBridge.mm:
• WebCoreSupport/WebFrameLoaderClient.mm:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.mm:
• WebView/WebView.mm:

Nov 14, 2006:

10:57 PM Changeset in webkit [17778] by bdash

• 4 edits
  1 delete in trunk/WebKitSite

2006-11-14 Matt Lilek <​pewtermoose@gmail.com>

Reviewed by Tim Hatcher.

Moved the web developer page to the wiki, adding link to the Drosera page.

• .htaccess: Add permanent redirect to the new page on the wiki.
• contact.html: Trac numbers are no longer one off.
• nav.inc:
• webdevelopers/index.html: Removed.
• webdevelopers/webkit_version.html: Removed.
• webdevelopers/webkit_version.js: Removed.
• webdevelopers/webkit_version_xl.html: Removed.
• webdevelopers/webkit_version_xl.js: Removed.

10:09 PM Changeset in webkit [17777] by bdakin

• 15 edits in trunk

WebCore:

Reviewed by Geoff.

Moving things off the bridge and onto clients.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
• WebCoreSupport/WebFrameBridge.mm:
• WebKit.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff.

Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h:
• bridge/mac/WebCoreFrameBridge.h:
• editing/Editor.cpp: (WebCore::Editor::selectWordBeforeMenuEvent): (WebCore::Editor::clientIsEditable):
• editing/Editor.h:
• page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:

9:42 PM Changeset in webkit [17776] by thatcher

• 13 edits in trunk

WebCore:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.

• bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]):
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
• page/FrameView.cpp: (WebCore::selectCursor):
• page/Settings.h: (WebCore::Settings::):

WebKit:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]): (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): (-[WebDefaultUIDelegate openLink:]):
• English.lproj/Localizable.strings:
• WebKit.exp:
• WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]):
• WebView/WebPreferencesPrivate.h:
• WebView/WebUIDelegatePrivate.h:

9:28 PM WebKit Team edited by timothy@apple.com

(diff)

9:17 PM Changeset in webkit [17775] by oliver

• 2 edits in trunk/WebCore

2006-11-14 Mark Rowe <​bdash@webkit.org>

Reviewed by Oliver.

Build fix

• bindings/scripts/CodeGenerator.pm:

9:06 PM Changeset in webkit [17774] by andersca

• 4 edits in trunk

WebCore:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

• WebCore.xcodeproj/project.pbxproj:

WebKit:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

• WebKit.xcodeproj/project.pbxproj:

9:01 PM Changeset in webkit [17773] by andersca

• 4 edits in trunk

WebCore:

I must stop trying to force DWARF on the world.

• WebCore.xcodeproj/project.pbxproj:

WebKit:

I must stop trying to force DWARF on the world.

• WebKit.xcodeproj/project.pbxproj:

7:52 PM Changeset in webkit [17772] by justing

• 14 edits
  4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4806874>
Missing background image after paste

Checking in new expected results for fixes:

• editing/inserting/insert-3851164-fix-expected.checksum:
• editing/inserting/insert-3851164-fix-expected.png:
• editing/selection/drag-in-iframe-expected.checksum:
• editing/selection/drag-in-iframe-expected.png:

Same, but also removing an outdated comment about a bug:

• editing/pasteboard/paste-text-019-expected.checksum:
• editing/pasteboard/paste-text-019-expected.png:
• editing/pasteboard/paste-text-019-expected.txt:
• editing/pasteboard/paste-text-019.html:

Added:

• editing/pasteboard/4806874-expected.checksum: Added.
• editing/pasteboard/4806874-expected.png: Added.
• editing/pasteboard/4806874-expected.txt: Added.
• editing/pasteboard/4806874.html: Added.

Equivalent render trees:

• editing/inserting/insert-3907422-fix-expected.txt:
• editing/pasteboard/paste-text-011-expected.txt:
• editing/pasteboard/paste-text-015-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4806874>
Missing background image after paste

• editing/markup.cpp: (WebCore::createMarkup): If the body is fully selected, add a div with its CSS properties to the markup. Migrated a use of enclosingBlockFlowElement to enclosingBlock to fix an infinite loop when pasting <div><input></div>.

7:20 PM Changeset in webkit [17771] by andersca

• 2 edits in trunk/WebCore

2006-11-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Add Undo/Redo to execCommand.

• editing/Editor.cpp: (WebCore::execRedo): (WebCore::execUndo): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::):

7:16 PM WikiStart edited by pewtermoose@gmail.com

forgot a page (diff)

7:15 PM WikiStart edited by pewtermoose@gmail.com

linking to the pages I added (diff)

7:12 PM WebDevelopers created by pewtermoose@gmail.com

Web developer oriented resources

7:12 PM DetectingWebKit created by pewtermoose@gmail.com

Moved this from the website

7:12 PM Drosera created by pewtermoose@gmail.com

Some rough Drosera documentation

7:00 PM WebKit Team edited by bdash@webkit.org

(diff)

6:59 PM WebKit Team edited by bdash@webkit.org

(diff)

6:52 PM WebKit Team edited by pewtermoose@gmail.com

(diff)

6:45 PM WebKit Team edited by pewtermoose@gmail.com

Clean up a few cobwebs (diff)

5:40 PM Changeset in webkit [22542] by darin

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Fixed reviewer name (Anders).

5:34 PM Changeset in webkit [22541] by darin

• 8 edits
  3 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by NOBODY (OOPS!).

• update for creation of EventHandler

• WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.

• bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp, tabsToLinks, and tabsToAllControls to EventHandler.
• bridge/win/FrameWin.cpp: Ditto.

• bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar functions to EventHandler.

• page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.

• platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed function in its new home in EventHandler.

• platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.

WebKitWin:

Reviewed by Anders.

• update for creation of EventHandler

• WebView.cpp: (WebView::handleMouseEvent): Call methods now moved to EventHandler. (WebView::mouseWheel): Ditto. (WebView::elementAtPoint): Ditto.

5:29 PM Changeset in webkit [17770] by darin

• 43 edits
  5 adds
  1 delete in trunk

WebCore:

Reviewed by Anders.

• created EventHandler class, moved event handling code from both Frame and FrameView in there

• added ScrollTypes.h header so you can include the scroller-related enums without all of Scrollbar.h

• page/EventHandler.cpp: Added.
• page/EventHandler.h: Added.
• page/mac/EventHandlerMac.mm: Added.

• platform/ScrollBarMode.h: Removed.
• platform/ScrollTypes.h: Added.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::imageFromRect):
• bridge/mac/FrameViewMac.mm:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge _visiblePositionForPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
• dom/Document.cpp: (WebCore::Document::hoveredNodeDetached):
• dom/Element.h:
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
• editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
• editing/SelectionController.h: (WebCore::SelectionController::setCaretBlinkingSuspended): (WebCore::SelectionController::isCaretBlinkingSuspended):
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
• html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus):
• html/HTMLFrameElementBase.h:
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::open):

• page/Frame.cpp: (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::frameForWidget): (WebCore::Frame::eventHandler): (WebCore::Frame::setProhibitsScrolling): (WebCore::FramePrivate::FramePrivate):
• page/Frame.h:
• page/FramePrivate.h:
• page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::addRepaintInfo): (WebCore::FrameView::layout): (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::windowClipRectForLayer): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
• page/FrameView.h:
• page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
• page/PageState.h:
• platform/ScrollBar.h:
• platform/ScrollView.h:
• platform/mac/ClipboardMac.mm:
• platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
• platform/mac/SliderMac.mm: (-[WebCoreSlider becomeFirstResponder]): (-[WebCoreSlider nextKeyView]): (-[WebCoreSlider previousKeyView]): (-[WebCoreSlider canBecomeKeyView]): (Slider::focusPolicy):
• platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]): (-[WebCoreTextFieldController setHasFocus:]): (-[WebCoreSearchField nextKeyView]): (-[WebCoreSearchField previousKeyView]): (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
• platform/mac/WidgetMac.mm: (WebCore::Widget::hasFocus): (WebCore::Widget::clearFocus):
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::setResizing):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::updateOverflowStatus):
• rendering/RenderLayer.h:
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll):
• rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::destroy):
• rendering/RenderObject.h: (WebCore::RenderObject::RepaintInfo::RepaintInfo):
• rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):

WebKit:

Reviewed by Anders.

• update for creation of EventHandler

• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
• WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]): (-[WebHTMLView elementAtPoint:allowShadowContent:]):

5:21 PM Changeset in webkit [17769] by andersca

• 2 edits in trunk/WebKit

Fix build for real this time.

• WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]):

5:07 PM Changeset in webkit [17768] by andersca

• 2 edits in trunk/WebKit

2006-11-14 Anders Carlsson <​acarlsson@apple.com>

Try fixing the build.

• WebCoreSupport/WebEditorClient.mm: (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]):

5:07 PM Changeset in webkit [22540] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

2006-11-14 Anders Carlsson <​acarlsson@apple.com>

Build fix.

• WebEditorClient.cpp: (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
• WebEditorClient.h:

4:36 PM Changeset in webkit [17767] by andersca

• 19 edits
  2 deletes in trunk

WebCore:

Reviewed by Darin.

Let the editor client handle undo/redo.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::canUndo): (WebCore::FrameMac::canRedo):
• bridge/mac/WebCoreEditCommand.h: Removed.
• bridge/mac/WebCoreEditCommand.mm: Removed.
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
• editing/JSEditor.cpp:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::closeURL):
• page/Frame.cpp:
• page/Frame.h:
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement):

WebKit:

Reviewed by Darin.

Move undo/redo handling into WebEditorClient.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (undoNameForEditAction): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
• WebCoreSupport/WebFrameBridge.mm:
• WebKit.xcodeproj/project.pbxproj:

3:02 PM Web Inspector edited by pewtermoose@gmail.com

Add how to use with OmniWeb (diff)

2:33 PM Changeset in webkit [17766] by beidson

• 5 edits in trunk/WebCore

Reviewed and landed by Brady

Fix Qt/Linux build.

• ChangeLog:
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
• platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::add):
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::submitForm):
• platform/qt/FrameQtClient.h:

1:51 PM Changeset in webkit [17765] by thatcher

• 1 edit in trunk/WebKitSite/nav.inc

Fixing the site.

1:45 PM Changeset in webkit [17764] by sfalken

• 1 copy in tags/Safari-521.30.1b

New tag.

1:44 PM Changeset in webkit [17763] by bdash

• 3 edits in trunk/WebKitSite

2006-11-14 Mark Rowe <​bdash@webkit.org>

Reviewed by Tim Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site

• blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
• nav.inc: Generate WordPress archive list if included from within WordPress.

11:56 AM Changeset in webkit [22539] by beidson

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

Additional tweek to the FormData change

• WebFrame.cpp: (WebFrame::loadDataSource):

11:52 AM Changeset in webkit [17762] by beidson

• 9 edits in trunk/WebCore

Reviewed by Anders

Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
• platform/network/ResourceHandle.h:
• platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
• platform/network/mac/FormDataStreamMac.h:
• platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
• platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest):

11:44 AM Changeset in webkit [22538] by aroben

• 15 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Replace all instances of DebugBreak() with ASSERT_NOT_REACHED() so that
it will be compiled out for Release builds.

• DOMCSSClasses.cpp:
• DOMCoreClasses.cpp:
• DOMHTMLClasses.cpp:
• WebBackForwardList.cpp:
• WebDataSource.cpp:
• WebFrame.cpp:
• WebHTMLRepresentation.cpp:
• WebHistoryItem.cpp:
• WebIconDatabase.cpp:
• WebMutableURLRequest.cpp:
• WebNotification.cpp:
• WebPreferences.cpp:
• WebScriptObject.cpp:
• WebView.cpp:

10:57 AM Changeset in webkit [17761] by ap

• 3 edits
  6 adds in trunk

2006-11-14 Rob Buis <​buis@kde.org>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer

Test: fast/css/css-imports.html

• css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Fix the crash by testing for null pointer.

10:11 AM Changeset in webkit [17760] by ap

• 4 edits
  1 add in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.

2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

• WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
• WebView/WebHTMLViewInternal.h:

10:06 AM Changeset in webkit [17759] by aroben

• 5 edits in trunk/WebCore

2006-11-14 Darin Adler <Darin Adler>

Reviewed by Adam.

Fix up usages of FormData within CFNet loader code.

• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody):
• platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the streamFormDatas HashMap. (WebCore::formCreate): (WebCore::formFinalize): Removed delete because the remove() will deref and delete if necessary. (WebCore::setHTTPBody): Changed parameter to PassRefPtr. (WebCore::httpBodyFromStream):
• platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
• platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::getResourceRequest):

7:39 AM Changeset in webkit [17758] by spadma

• 4 edits in S60/trunk/WebKit

2006-11-10 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

• BrowserCore/Renderers/src/TextRendererFactory.cpp:

7:25 AM Changeset in webkit [17757] by spadma

• 4 edits in S60/branches/3.1m/WebKit

2006-11-10 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

• BrowserCore/Renderers/src/TextRendererFactory.cpp:

3:55 AM Changeset in webkit [17756] by bdash

• 2 edits in trunk/WebCore

2006-11-14 Greg Jackson <​gjspanner@gmail.com>

Reviewed by Darin.

Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.

• bindings/js/kjs_navigator.cpp:

2:13 AM BuildingGdk edited by alp@atoker.com

(diff)

2:11 AM BuildingGdk created by alp@atoker.com

Nov 13, 2006:

11:59 PM Changeset in webkit [22537] by beidson

• 9 edits in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

• bridge/win/FrameWin.h:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

• WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::submitForm):
• WebFrame.h:
• WebMutableURLRequest.cpp: (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
• WebMutableURLRequest.h:

7:54 PM Changeset in webkit [17755] by beidson

• 16 edits in trunk/WebCore

Reviewed by Maciej

Made FormData Shared, and pass it around as such.

• WebCore.xcodeproj/project.pbxproj: Reordered some items
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
• html/HTMLFormElement.h:
• loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::FrameLoader::submitForm):
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
• platform/network/FormData.h: Made FormData shared
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody):
• platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest): (WebCore::nsURLRequest):

• platform/network/mac/FormDataStreamMac.h:
• platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

7:01 PM Changeset in webkit [22536] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

• platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Make sure to call valueChanged after hiding the popup so that change events will be delivered correctly.

6:45 PM Changeset in webkit [17754] by justing

• 3 edits in trunk/LayoutTests/editing/selection

I accidently checked in old expected results in my previous checkin.

6:37 PM Changeset in webkit [17753] by justing

• 4 edits
  4 adds in trunk

LayoutTests:

Reviewed by harrison

• editing/selection/drag-select-1-expected.checksum: Added.
• editing/selection/drag-select-1-expected.png: Added.
• editing/selection/drag-select-1-expected.txt: Added.
• editing/selection/drag-select-1.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (​http://www.cnet.com/)

The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.

• editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup to prevent crashes like this in future Release builds.
• editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Let this function escape shadow nodes. We might eventually push this code down into next/previous{VisuallyDistinct}Canditate. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.

6:09 PM Changeset in webkit [22535] by andersca

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Various editing fixes.

• WebView.cpp: (WebView::execCommand): Use the focused frame, not the main frame.

(WebView::focusedTarget):
Add FIXME comment.

(WebView::keyDown):
Return false for unknown keydown messages when not in editing mode.

5:27 PM Changeset in webkit [22534] by aroben

• 1 edit in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp

Fix line endings.

5:21 PM Changeset in webkit [22533] by sfalken

• 4 edits in branches/WindowsMerge

2006-11-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders, Lou.

Fix merge script

• WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman

2006-11-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders, Lou.

Bump version for submit
Copy CharacterSets directory for CF

• WebKit.vcproj/VERSION: Bump version
• WebKit.vcproj/WebKit.vcproj: Copy CharacterSets

3:56 PM Changeset in webkit [17752] by justing

• 4 edits in trunk/WebCore

Reviewed by darin

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
• editing/Editor.cpp: (WebCore::Editor::appliedEditing):
• editing/Editor.h: (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.

3:37 PM Changeset in webkit [17751] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Oliver

• editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
• editing/pasteboard/paste-unrendered-select-expected.png: Added.
• editing/pasteboard/paste-unrendered-select-expected.txt: Added.
• editing/pasteboard/paste-unrendered-select.html: Added.

WebCore:

Reviewed by Oliver

<rdar://problem/4820026>
copy/paste of news.google.com yields text from hidden select element options

We were adding descendants of unrendered select elements.

• editing/markup.cpp: (WebCore::createMarkup): Don't traverse into nodes without renderers, unless they are grandfathered in by a rendered select element.

3:27 PM Changeset in webkit [22532] by ggaren

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin Adler, Anders Carlsson.

More window.open work.

• Hooked up all of WebChromeClient that the App currently supports.

• WebChromeClient.cpp: (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):

2:59 PM Changeset in webkit [17750] by thatcher

• 4 edits in tags/Safari-421.30

Versioning

2:40 PM Changeset in webkit [17749] by thatcher

• 1 copy in tags/Safari-421.30

New tag.

1:46 PM Changeset in webkit [17748] by thatcher

• 4 edits in trunk/WebKitTools

Explicitly set Dwarf for projects that didn't specify the debugging format.

1:38 PM Changeset in webkit [17747] by thatcher

• 4 edits in trunk

Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.

9:42 AM Changeset in webkit [22531] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

Fix line-endings and svn properties.

• WebChromeClient.cpp:
• WebChromeClient.h:

9:35 AM Changeset in webkit [22530] by aroben

• 6 edits in branches/WindowsMerge/WebKitWin

Build fix.

• MarshallingHelpers.cpp:
• WebChromeClient.cpp:
• WebChromeClient.h:
• WebEditorClient.h:
• WebMutableURLRequest.h:

Nov 12, 2006:

11:13 PM Changeset in webkit [17746] by beidson

• 3 edits in trunk/WebKit

Rubberstamped by Anders

Changed some #includes from <WebKit/foo.h> to "foo.h"

• History/WebBackForwardList.m:
• History/WebHistory.m:

6:57 PM Changeset in webkit [22529] by ggaren

• 2 edits in branches/WindowsMerge/WebKitWin

• WebChromeClient.cpp: Fixed up #include.

6:54 PM Changeset in webkit [22528] by ggaren

• 12 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve Falkenberg.

Implemented window.open. Rough around the edges right now.

• Converted WebMutableURLRequest to use a ResourceRequest as its backing store, to avoid yet another way of representing this data.
• Changed WebMutableURLRequests's timeoutInterval to double, to match ResourceRequest and NSURLRequest.
• Added BSTRToKURL and KURLToBSTR helper functions.
• Added page accessor on WebView, and core(), for converting from WebView to page.

• MarshallingHelpers.h: Removed unnecessary variable names from declarations.

3:49 PM Changeset in webkit [22527] by ggaren

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std

functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)

• WebCore.vcproj/WebCore.vcproj:

WebKitWin:

Reviewed by Steven Falkenberg.

Fixed up work-arounds to MSVC warning silliness.

Replaced in-place disabling of "conditional expression is constant" warning
with project-wide setting. (We use do { } while(0); for macro scoping.)

Replaced in-place and project-wide disabling of "xxx was declared deprecated"
warning with project-wide setting only to disable Microsoft's made-up deprecation

warnings related to std

functions.

• WebChromeClient.cpp: (WebChromeClient::setResizable):
• WebKit.vcproj/WebKit.vcproj:
• WebKitDLL.h:

3:44 PM Changeset in webkit [17745] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.

Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std

functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

8:47 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

Added bug number for navigationController issue (diff)

8:45 AM Writing Layout Tests for DumpRenderTree created by mitz@webkit.org

Copied from Google cache of wiki.opendarwin.org with minimal …

7:18 AM Changeset in webkit [17744] by bdash

• 7 edits in trunk/WebCore

2006-11-12 Simon Hausmann <​hausmann@kde.org>

Reviewed by Sam Weinig.

Fix Qt build. Missing AbstractShared implementation.
​http://bugs.webkit.org/show_bug.cgi?id=11581

• loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::ref): (WebCore::FrameLoaderClientQt::deref):
• loader/qt/FrameLoaderClientQt.h:
• platform/qt/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ref): (WebCore::ChromeClientQt::deref):
• platform/qt/ChromeClientQt.h:
• platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::ref): (WebCore::EditorClientQt::deref):
• platform/qt/EditorClientQt.h:

4:39 AM BuildingOnWindows edited by ap@webkit.org

added a few more needed cygwin packages (diff)

4:29 AM Changeset in webkit [17743] by bdash

• 4 edits in trunk/WebCore

2006-11-13 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Fix some Linux/Gdk build issues noted by Alp Toker.

• Projects/gdk/webcore-gdk.bkl:
• WebCoreSources.bkl:
• platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):

4:19 AM BuildingOnWindows created by bdash@webkit.org

Rescue Building on Windows page from the old wiki

1:31 AM Changeset in webkit [17742] by beidson

• 4 edits in trunk/WebCore

Reviewed by Anders

Logging channel plumbing for future work

• platform/Logging.cpp: (WebCore::):
• platform/Logging.h:
• platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

12:47 AM Changeset in webkit [17741] by bdash

• 16 edits
  1 delete in trunk

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.

• Projects/gdk/webcore-gdk.bkl:
• WebCoreSources.bkl:
• page/PageState.cpp:
• platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::ref): (WebCore::ChromeClientGdk::deref):
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::~FrameGdk):
• platform/gdk/FrameGdk.h:
• platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
• platform/gdk/ScreenClientGdk.h: Removed.
• platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::canPaste): (FrameGdk::originalRequestURL): (TextField::TextField):
• platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
• webcore-base.bkl:

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Clean up of JavaScriptCore bakefiles.

• JavaScriptCoreSources.bkl:
• jscore.bkl:

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Clean up of GdkLauncher bakefile.

• GdkLauncher/gdklauncher.bkl:

Nov 11, 2006:

8:59 PM Changeset in webkit [22526] by ggaren

• 29 edits in branches/WindowsMerge

Reviewed by Maciej Stachowiak.

• Fixed <rdar://problem/4831461> Crash in FrameLoader::~FrameLoader when navigating away from ebay.com

• Changed WebKit clients to match new virtual ref/deref scheme in WebCore.

• Removed WebEditorClient from the WebCore namespace because it's a WebKit class, not a WebCore class.

• Standardized some header #includes to match Mac:
  • alphabetical
  • config.h, WebKitDLL.h, and class headers go together at the top
  • everything else comes after a line break

8:53 PM Changeset in webkit [17740] by ggaren

• 17 edits
  1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.

• Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h: Fixed up function prototypes for style.
• loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose was to implement an alternative ownership model. (WebCore::FrameLoader::~FrameLoader): Removed empty destructor. (WebCore::FrameLoader::setClient): This function now takes ownership (WebCore::FrameLoader::client):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• page/ChromeClient.h:
• platform/AbstractShared.h: Added. This is the virtual function-based refcounting complement to Shared. (WebCore::AbstractShared::~AbstractShared):

WebKit:

Reviewed by Maciej Stachowiak.

• Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.

WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.

• WebCoreSupport/WebChromeClient.h: (WebChromeClient::ref): (WebChromeClient::deref): (WebChromeClient::refCount):
• WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes. The ones in WebCore make clear what remains to be implemented. Replaced constructor with factory function to avoid leaks.
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::create): (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
• WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory function to avoid leaks. (WebFrameLoaderClient::ref): (WebFrameLoaderClient::deref): (WebFrameLoaderClient::refCount):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::create):
• WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):

4:13 PM Changeset in webkit [17739] by staikos

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix uninitialized variable.

• rendering/RenderStyle.h:

2:54 PM Changeset in webkit [22525] by andersca

• 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Remove conflict markers

2:50 PM Changeset in webkit [22524] by andersca

• 7 edits in branches/WindowsMerge

WebCoreWin:

2006-11-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Rename keyPress to keyEvent, it's used for both key presses
and releases.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
• bridge/win/FrameWin.h:

WebKitWin:

2006-11-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Clean up the event handling code.

• WebEditorClient.cpp: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::shouldApplyStyle): Change these to return true. Eventually they will call the editing delegate.

• WebView.cpp: (WebView::execCommand): Update to call the editor's execCommand.

(WebView::keyUp):
New function that forwards the event to FrameWin.

(editCommandForKey):
New function that given a key returns an edit command from a table. Eventually this table
should be moved into WebCore.

(WebView::handleEditingKeyboardEvent):
New function that handles editing events.

(WebView::keyDown):
If the frame is editable, call handleEditingKeyboardEvent.

(WebViewWndProc):

• WebView.h:

1:34 PM Changeset in webkit [17738] by aroben

• 1 edit in trunk/WebCore/ChangeLog

Grammar fix.

1:32 PM Changeset in webkit [17737] by aroben

• 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.

General style cleanup, remove all tabs etc.

• CMakeLists.txt:

1:32 PM Changeset in webkit [17736] by ddkilzer

• 1 edit in trunk/JavaScriptCore/ChangeLog

Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.

1:28 PM Changeset in webkit [17735] by ddkilzer

• 4 edits in trunk

Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.

1:17 PM Changeset in webkit [22523] by aroben

• 30 edits
  3 moves
  1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

Move graphics-related files to platform/graphics to stay in sync with
changes from OpenSource r17727.

Also, as discussed with Darin and Steve, we now copy all our headers to
a flat include/WebCore directory instead of copying the directory
structure of WebCore. This mirrors how Mac builds.

• WebCore.vcproj/WebCore.vcproj:
• platform/cg/ColorCG.cpp: Removed.
• platform/cg/GraphicsContextCG.cpp: Removed.
• platform/cg/GraphicsContextPlatformPrivate.h: Removed.
• platform/win/IconWin.cpp: Removed.
• platform/win/ImageWin.cpp: Removed.

WebKitWin:

Reviewed by Geoff.

Update WebCore #includes to use a flat directory structure.

• DOMCSSClasses.cpp:
• DOMCSSClasses.h:
• DOMCoreClasses.cpp:
• DOMEventsClasses.cpp:
• DOMHTMLClasses.cpp:
• MarshallingHelpers.cpp:
• WebChromeClient.cpp:
• WebChromeClient.h:
• WebDataSource.cpp:
• WebEditorClient.cpp:
• WebEditorClient.h:
• WebElementPropertyBag.cpp:
• WebFrame.cpp:
• WebFrame.h:
• WebHTMLRepresentation.cpp:
• WebHistory.cpp:
• WebIconDatabase.cpp:
• WebIconDatabase.h:
• WebKit.vcproj/WebKit.vcproj:
• WebKitDLL.cpp:
• WebMutableURLRequest.cpp:
• WebNotificationCenter.cpp:
• WebPreferences.cpp:
• WebURLResponse.cpp:
• WebURLResponse.h:
• WebView.cpp:
• WebView.h:

11:10 AM Changeset in webkit [17734] by andersca

• 2 edits in trunk/WebKitTools

Reviewed and landed by Anders.

Make DRT work again on Qt/Linux.

• DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

10:36 AM Changeset in webkit [17733] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.

• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):

10:08 AM Changeset in webkit [17732] by beidson

• 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed header guard

• loader/FrameLoaderClient.h:

8:52 AM Changeset in webkit [22522] by darin

• 2 edits in branches/WindowsMerge/WebCore

• blind attempt to fix the build

• platform/win/CursorWin.cpp: (WebCore::verticalTextCursor): Added. Just returns the pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.

8:48 AM Changeset in webkit [17731] by darin

• 2 edits in trunk/WebCore

• attempt to fix Qt build

• platform/qt/CursorQt.cpp: (WebCore::verticalTextCursor): Added. Just returns pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.

7:49 AM Changeset in webkit [17730] by rwlbuis

• 6 edits
  3 adds in trunk

Reviewed by hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

7:31 AM Changeset in webkit [17729] by ap

• 2 edits in trunk/WebCore

Attempt to fix Qt build.

• CMakeLists.txt: PathQt.cpp is in graphics/qt now.

7:15 AM Changeset in webkit [17728] by ap

• 9 edits
  3 adds in trunk/WebCore

2006-11-11 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)

[CSS 3] support for vertical-text, cell and context-menu cursors
​http://bugs.webkit.org/show_bug.cgi?id=11494

• Resources/cellCursor.png: Added.
• Resources/contextMenuCursor.png: Added.
• Resources/verticalTextCursor.png: Added.
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSValueKeywords.in:
• manual-tests/cursor.html:
• page/FrameView.cpp: (WebCore::selectCursor):
• platform/Cursor.h:
• platform/mac/CursorMac.mm: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor):
• rendering/RenderStyle.h: (WebCore::):

6:31 AM Changeset in webkit [17727] by ap

• 4 edits
  50 moves
  4 adds in trunk/WebCore

2006-11-11 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aroben and ap, landed by ap.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11468

Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/AffineTransform.cpp: Removed.
• platform/AffineTransform.h: Removed.
• platform/Color.cpp: Removed.
• platform/Color.h: Removed.
• platform/FloatPoint.cpp: Removed.
• platform/FloatPoint.h: Removed.
• platform/FloatRect.cpp: Removed.
• platform/FloatRect.h: Removed.
• platform/FloatSize.cpp: Removed.
• platform/FloatSize.h: Removed.
• platform/Icon.h: Removed.
• platform/Image.cpp: Removed.
• platform/Image.h: Removed.
• platform/ImageSource.h: Removed.
• platform/IntPoint.h: Removed.
• platform/IntRect.cpp: Removed.
• platform/IntRect.h: Removed.
• platform/IntSize.h: Removed.
• platform/IntSizeHash.h: Removed.
• platform/Path.cpp: Removed.
• platform/Path.h: Removed.
• platform/Pen.cpp: Removed.
• platform/Pen.h: Removed.
• platform/cairo/AffineTransformCairo.cpp: Removed.
• platform/cairo/GraphicsContextCairo.cpp: Removed.
• platform/cairo/ImageCairo.cpp: Removed.
• platform/cairo/ImageSourceCairo.cpp: Removed.
• platform/cairo/cairo/AUTHORS: Removed.
• platform/cairo/cairo/COPYING: Removed.
• platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
• platform/cairo/cairo/COPYING-MPL-1.1: Removed.
• platform/cairo/cairo/INSTALL: Removed.
• platform/cairo/cairo/NEWS: Removed.
• platform/cairo/cairo/README: Removed.
• platform/cairo/cairo/TODO: Removed.
• platform/cairo/cairo/src/Makefile.in: Removed.
• platform/cairo/cairo/src/cairo-arc-private.h: Removed.
• platform/cairo/cairo/src/cairo-arc.c: Removed.
• platform/cairo/cairo/src/cairo-array.c: Removed.
• platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
• platform/cairo/cairo/src/cairo-atsui.h: Removed.
• platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
• platform/cairo/cairo/src/cairo-beos.h: Removed.
• platform/cairo/cairo/src/cairo-cache-private.h: Removed.
• platform/cairo/cairo/src/cairo-cache.c: Removed.
• platform/cairo/cairo/src/cairo-clip-private.h: Removed.
• platform/cairo/cairo/src/cairo-clip.c: Removed.
• platform/cairo/cairo/src/cairo-color.c: Removed.
• platform/cairo/cairo/src/cairo-debug.c: Removed.
• platform/cairo/cairo/src/cairo-debug.h: Removed.
• platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
• platform/cairo/cairo/src/cairo-directfb.h: Removed.
• platform/cairo/cairo/src/cairo-features.h: Removed.
• platform/cairo/cairo/src/cairo-features.h.in: Removed.
• platform/cairo/cairo/src/cairo-fixed.c: Removed.
• platform/cairo/cairo/src/cairo-font-options.c: Removed.
• platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
• platform/cairo/cairo/src/cairo-font-subset.c: Removed.
• platform/cairo/cairo/src/cairo-font.c: Removed.
• platform/cairo/cairo/src/cairo-ft-font.c: Removed.
• platform/cairo/cairo/src/cairo-ft-private.h: Removed.
• platform/cairo/cairo/src/cairo-ft.h: Removed.
• platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
• platform/cairo/cairo/src/cairo-glitz.h: Removed.
• platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
• platform/cairo/cairo/src/cairo-gstate.c: Removed.
• platform/cairo/cairo/src/cairo-hash-private.h: Removed.
• platform/cairo/cairo/src/cairo-hash.c: Removed.
• platform/cairo/cairo/src/cairo-hull.c: Removed.
• platform/cairo/cairo/src/cairo-image-surface.c: Removed.
• platform/cairo/cairo/src/cairo-matrix.c: Removed.
• platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
• platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
• platform/cairo/cairo/src/cairo-output-stream.c: Removed.
• platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
• platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
• platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
• platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
• platform/cairo/cairo/src/cairo-path-data.c: Removed.
• platform/cairo/cairo/src/cairo-path-fill.c: Removed.
• platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
• platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
• platform/cairo/cairo/src/cairo-path.c: Removed.
• platform/cairo/cairo/src/cairo-pattern.c: Removed.
• platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
• platform/cairo/cairo/src/cairo-pdf.h: Removed.
• platform/cairo/cairo/src/cairo-pen.c: Removed.
• platform/cairo/cairo/src/cairo-platform.h: Removed.
• platform/cairo/cairo/src/cairo-png.c: Removed.
• platform/cairo/cairo/src/cairo-polygon.c: Removed.
• platform/cairo/cairo/src/cairo-private.h: Removed.
• platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
• platform/cairo/cairo/src/cairo-ps.h: Removed.
• platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
• platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
• platform/cairo/cairo/src/cairo-quartz.h: Removed.
• platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
• platform/cairo/cairo/src/cairo-quartz2.h: Removed.
• platform/cairo/cairo/src/cairo-region.c: Removed.
• platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
• platform/cairo/cairo/src/cairo-slope.c: Removed.
• platform/cairo/cairo/src/cairo-spline.c: Removed.
• platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
• platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
• platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
• platform/cairo/cairo/src/cairo-surface.c: Removed.
• platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
• platform/cairo/cairo/src/cairo-svg.h: Removed.
• platform/cairo/cairo/src/cairo-traps.c: Removed.
• platform/cairo/cairo/src/cairo-unicode.c: Removed.
• platform/cairo/cairo/src/cairo-wideint.c: Removed.
• platform/cairo/cairo/src/cairo-wideint.h: Removed.
• platform/cairo/cairo/src/cairo-win32-font.c: Removed.
• platform/cairo/cairo/src/cairo-win32-private.h: Removed.
• platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
• platform/cairo/cairo/src/cairo-win32.h: Removed.
• platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
• platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
• platform/cairo/cairo/src/cairo-xcb.h: Removed.
• platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
• platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
• platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
• platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
• platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
• platform/cairo/cairo/src/cairo-xlib.h: Removed.
• platform/cairo/cairo/src/cairo.c: Removed.
• platform/cairo/cairo/src/cairo.h: Removed.
• platform/cairo/cairo/src/cairoint.h: Removed.
• platform/cairo/cairo/src/test-fallback-surface.c: Removed.
• platform/cairo/cairo/src/test-fallback-surface.h: Removed.
• platform/cairo/cairo/src/test-meta-surface.c: Removed.
• platform/cairo/cairo/src/test-meta-surface.h: Removed.
• platform/cairo/cairo/src/test-paginated-surface.c: Removed.
• platform/cairo/cairo/src/test-paginated-surface.h: Removed.
• platform/cairo/pixman/AUTHORS: Removed.
• platform/cairo/pixman/COPYING: Removed.
• platform/cairo/pixman/README: Removed.
• platform/cairo/pixman/src/Makefile.in: Removed.
• platform/cairo/pixman/src/fbcompose.c: Removed.
• platform/cairo/pixman/src/fbedge.c: Removed.
• platform/cairo/pixman/src/fbedgeimp.h: Removed.
• platform/cairo/pixman/src/fbmmx.c: Removed.
• platform/cairo/pixman/src/fbmmx.h: Removed.
• platform/cairo/pixman/src/fbpict.c: Removed.
• platform/cairo/pixman/src/fbpict.h: Removed.
• platform/cairo/pixman/src/fbtrap.c: Removed.
• platform/cairo/pixman/src/icblt.c: Removed.
• platform/cairo/pixman/src/icbltone.c: Removed.
• platform/cairo/pixman/src/iccolor.c: Removed.
• platform/cairo/pixman/src/icformat.c: Removed.
• platform/cairo/pixman/src/icimage.c: Removed.
• platform/cairo/pixman/src/icimage.h: Removed.
• platform/cairo/pixman/src/icint.h: Removed.
• platform/cairo/pixman/src/icpixels.c: Removed.
• platform/cairo/pixman/src/icrect.c: Removed.
• platform/cairo/pixman/src/icrop.h: Removed.
• platform/cairo/pixman/src/icstipple.c: Removed.
• platform/cairo/pixman/src/ictransform.c: Removed.
• platform/cairo/pixman/src/ictrap.c: Removed.
• platform/cairo/pixman/src/ictri.c: Removed.
• platform/cairo/pixman/src/icutil.c: Removed.
• platform/cairo/pixman/src/pixman-remap.h: Removed.
• platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
• platform/cairo/pixman/src/pixman.h: Removed.
• platform/cairo/pixman/src/pixregion.c: Removed.
• platform/cairo/pixman/src/pixregionint.h: Removed.
• platform/cairo/pixman/src/renderedge.c: Removed.
• platform/cairo/pixman/src/renderedge.h: Removed.
• platform/cairo/pixman/src/slim_internal.h: Removed.
• platform/cairo/rgb24-hacks.txt: Removed.
• platform/cairo/scale-removal.txt: Removed.
• platform/cg/AffineTransformCG.cpp: Removed.
• platform/cg/FloatPointCG.cpp: Removed.
• platform/cg/FloatRectCG.cpp: Removed.
• platform/cg/FloatSizeCG.cpp: Removed.
• platform/cg/GraphicsContextCG.cpp: Removed.
• platform/cg/GraphicsContextPlatformPrivate.h: Removed.
• platform/cg/ImageCG.cpp: Removed.
• platform/cg/ImageSourceCG.cpp: Removed.
• platform/cg/IntPointCG.cpp: Removed.
• platform/cg/IntRectCG.cpp: Removed.
• platform/cg/IntSizeCG.cpp: Removed.
• platform/cg/PDFDocumentImage.cpp: Removed.
• platform/cg/PDFDocumentImage.h: Removed.
• platform/cg/PathCG.cpp: Removed.
• platform/gdk/ImageGdk.cpp: Removed.
• platform/mac/ColorMac.mm: Removed.
• platform/mac/FloatPointMac.mm: Removed.
• platform/mac/FloatRectMac.mm: Removed.
• platform/mac/FloatSizeMac.mm: Removed.
• platform/mac/GraphicsContextMac.mm:
• platform/mac/IconMac.mm: Removed.
• platform/mac/ImageMac.mm: Removed.
• platform/mac/IntPointMac.mm: Removed.
• platform/mac/IntRectMac.mm: Removed.
• platform/mac/IntSizeMac.mm: Removed.
• platform/qt/AffineTransformQt.cpp: Removed.
• platform/qt/ColorQt.cpp: Removed.
• platform/qt/FloatPointQt.cpp: Removed.
• platform/qt/FloatRectQt.cpp: Removed.
• platform/qt/IconQt.cpp: Removed.
• platform/qt/ImageQt.cpp: Removed.
• platform/qt/ImageSourceQt.cpp: Removed.
• platform/qt/IntPointQt.cpp: Removed.
• platform/qt/IntRectQt.cpp: Removed.
• platform/qt/IntSizeQt.cpp: Removed.
• platform/qt/PathQt.cpp: Removed.
• platform/win/ImageWin.cpp: Removed.
• platform/win/IntPointWin.cpp: Removed.
• platform/win/IntRectWin.cpp: Removed.
• platform/win/IntSizeWin.cpp: Removed.

5:10 AM Changeset in webkit [17726] by gdennis

• 1 edit in trunk/WebCore/rendering/RenderText.cpp

Build fix.

4:34 AM Changeset in webkit [17725] by gdennis

• 3 edits in trunk/WebCore

WebCore:

Reviewed by hyatt.

A layout test was added when this bug was fixed, so none needed now.

Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570

• rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Removed.
• rendering/RenderText.cpp: (WebCore::isSpace): Added. (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.

4:04 AM Changeset in webkit [17724] by gdennis

• 4 edits
  4 adds in trunk

WebCore:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570

• rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Added.
• rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'

LayoutTests:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570

• fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
• fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
• fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
• fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.

12:50 AM Changeset in webkit [17723] by ap

• 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h

Fix suggested by Don Gibson.

• kjs/JSImmediate.h: Re-enable all MSVC warnings, move the remaining runtime checks to compile-time.

Nov 10, 2006:

7:11 PM Changeset in webkit [22521] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

6:55 PM Changeset in webkit [17722] by bdash

• 14 edits
  9 adds in trunk

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
​http://bugs.webkit.org/show_bug.cgi?id=11540

• wtf/Platform.h:

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
​http://bugs.webkit.org/show_bug.cgi?id=11540

• config.h:
• platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
• platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
• platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
• platform/FloatPoint.h:
• platform/FloatRect.h:
• platform/IntPoint.h:
• platform/IntRect.h:
• platform/IntSize.h:
• platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
• platform/StringImpl.h:
• platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
• platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
• platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
• platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
• platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
• platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
• platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
• platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):

6:33 PM Changeset in webkit [17721] by bdash

• 6 edits in trunk

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

• loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
• loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

• DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
• DumpRenderTree/DumpRenderTree.qtproj/main.cpp:

5:56 PM Changeset in webkit [17720] by justing

• 11 edits
  8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

• editing/deleting/delete-link-1-expected.checksum: Added.
• editing/deleting/delete-link-1-expected.png: Added.
• editing/deleting/delete-link-1-expected.txt: Added.
• editing/deleting/delete-link-1.html: Added.
• editing/inserting/insert-before-link-1-expected.checksum: Added.
• editing/inserting/insert-before-link-1-expected.png: Added.
• editing/inserting/insert-before-link-1-expected.txt: Added.
• editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
• editing/DeleteSelectionCommand.h:
• editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
• editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
• editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
• editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
• editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.

5:33 PM Changeset in webkit [22520] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

5:19 PM Changeset in webkit [17719] by thatcher

• 1 edit
  9 copies in tags/Safari-521.30

New tag.

5:18 PM Changeset in webkit [17718] by thatcher

• 6 edits in /

Versioning.

5:15 PM Changeset in webkit [17717] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

• rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):

4:51 PM Changeset in webkit [17716] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

• editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
• rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):

4:20 PM Changeset in webkit [17715] by thatcher

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

4:11 PM Changeset in webkit [22519] by beidson

• 3 edits in branches/WindowsMerge/WebKitWin

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase

• WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
• WebIconDatabase.h:

4:10 PM Changeset in webkit [17714] by thatcher

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

64-bit build fix. Generates a derived export file for 64-bit architectures.

4:01 PM Changeset in webkit [22518] by andersca

• 3 edits in branches/WindowsMerge/WebCore

2006-11-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

• platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
• platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):

3:45 PM Changeset in webkit [17713] by aroben

• 4 edits in trunk/WebCore

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

• page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
• page/Frame.h:
• page/FramePrivate.h:

3:36 PM Changeset in webkit [17712] by mjs

• 3 edits in trunk/WebKit

Reviewed by Anders.

• remove some unnecessary uses of WebDataProtocol

• WebView/WebDataSource.mm: Remove the unneeded include.
• WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.

3:20 PM Changeset in webkit [17711] by andersca

• 11 edits in trunk

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

• WebCore.exp:
• editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
• editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

• WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):

2:29 PM Changeset in webkit [17710] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-10 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
​http://bugs.webkit.org/show_bug.cgi?id=11568

• ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):

1:53 PM Changeset in webkit [17709] by sfalken

• 1 copy in tags/Safari-521.30b

New tag.

1:51 PM Changeset in webkit [22517] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Steve Falkenburg <​sfalken@apple.com>

Bump version number for submission

• VERSION:
• WebKit.vcproj/VERSION:

1:35 PM Changeset in webkit [22516] by ggaren

• 14 edits in branches/WindowsMerge/WebKitWin

Oops. Checked in too much. Rolling out the extra.

1:33 PM Changeset in webkit [22515] by ggaren

• 15 edits in branches/WindowsMerge/WebKitWin

Fixed build -- you can't delete the shared icon database -- it's a singleton

1:12 PM Changeset in webkit [17708] by ggaren

• 1 edit in trunk/WebCore/platform/MimeTypeRegistry.cpp

Fixed platform #ifs

1:07 PM Changeset in webkit [17707] by spadma

• 4 edits in S60/branches/3.1m/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

• BrowserView/inc/BrowserSettingsContainer.h:
• BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):

1:00 PM Changeset in webkit [17706] by spadma

• 4 edits in S60/trunk/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

• BrowserView/inc/BrowserSettingsContainer.h:
• BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):

11:45 AM Changeset in webkit [17705] by andersca

• 11 edits in trunk

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

• WebCore.exp:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
• editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.

• WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):

11:31 AM Changeset in webkit [22514] by beidson

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin

Keep windows build from breaking

• WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
• WebFrame.h:

11:24 AM Changeset in webkit [17704] by beidson

• 14 edits
  1 add
  4 deletes in trunk

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
• bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
• loader/FrameLoaderClient.h:
• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
• loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
• loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

• Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
• Misc/WebIconDatabaseInternal.h: Added.
• Misc/WebIconDatabasePrivate.h:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
• WebCoreSupport/WebIconDatabaseBridge.h: Removed.
• WebCoreSupport/WebIconDatabaseBridge.m: Removed.
• WebKit.xcodeproj/project.pbxproj:

11:16 AM Changeset in webkit [17703] by andersca

• 22 edits
  8 adds in trunk

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

• CMakeLists.txt:
• loader/DocumentLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
• loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
• loader/qt/FrameLoaderClientQt.h: Added.
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
• loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
• loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
• platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
• platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
• platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
• platform/qt/ChromeClientQt.h: Added.
• platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
• platform/qt/EditorClientQt.h:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
• platform/qt/FrameQt.h:
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
• platform/qt/ImageQt.cpp:
• platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
• platform/qt/PageQt.cpp:
• platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
• platform/qt/ScreenQt.cpp:
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

• QtLauncher/main.cpp: (main):
• WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):

12:42 AM Changeset in webkit [17702] by beidson

• 2 edits in trunk/WebCore

Reviewed by Mitz

​http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.

12:22 AM Changeset in webkit [22513] by oliver

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Oliver Hunt <​oliver@apple.com>

Build fix

sprintf -> format (from Maciej's earlier change to WebCore)

• WebView.cpp: (osVersion): (WebView::userAgentForKURL):

Nov 9, 2006:

11:33 PM Changeset in webkit [22512] by oliver

• 4 edits
  1 add in branches/WindowsMerge/WebCore

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Added Windows side of MIME Type registry, and updated
objectContentType and ImageWin to make use of it

This fixes <rdar://problem/4791483>

• WebCore.vcproj/WebCore.vcproj:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::objectContentType):
• platform/win/ImageWin.cpp:
• platform/win/MimeTypeRegistryWin.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::mimeTypeForExtension): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

11:31 PM Changeset in webkit [17701] by oliver

• 14 edits
  5 adds in trunk

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• bridge/mac/WebMimeTypeRegistryBridge.h: Added.
• bridge/mac/WebMimeTypeRegistryBridge.mm: Added. (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
• platform/Image.cpp: (WebCore::Image::supportsType):
• platform/Image.h:
• platform/MimeTypeRegistry.cpp: Added. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes): (WebCore::initialiseMimeTypeRegistry): (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes): (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
• platform/MimeTypeRegistry.h: Added.
• platform/mac/ImageMac.mm:
• platform/mac/MimeTypeRegistryMac.mm: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

Updated to make use of MimeTypeRegistry/bridge

• Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
• WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
• WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
• WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]):

9:17 PM Changeset in webkit [17700] by mjs

• 28 edits in trunk/WebCore

Reviewed by Oliver.

• rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size for you and use vsnprintf.

• bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
• css/cssparser.cpp: (WebCore::CSSParser::parseColorFromValue):
• dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::handleError):
• ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
• ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::toString):
• ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::toString):
• ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
• ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
• ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::toString):
• ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
• ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::toString):
• ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::toString):
• ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
• ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
• loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setSynchronous):
• platform/Color.cpp: (WebCore::Color::name):
• platform/DeprecatedString.cpp: (WebCore::DeprecatedString::setNum): (WebCore::DeprecatedString::format):
• platform/DeprecatedString.h:
• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::format): (WebCore::String::number):
• platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
• platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::calcMinMaxWidth):

8:14 PM Changeset in webkit [22511] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

6:27 PM Changeset in webkit [22510] by oliver

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fix crash on unknown protocol

• WebFrame.cpp: (WebFrame::didFailWithError):

6:03 PM Changeset in webkit [22509] by lamadio

• 4 edits in branches/WindowsMerge

2006-11-09 Lou Amadio <​lamadio@apple.com>

Reviewed by mjs
Correct the broken search implementations based on original webkit
<rdar://4827714>

4:30 PM Changeset in webkit [17699] by mjs

• 2 edits in trunk/WebCore

Reviewed by Anders.

• fixed "Regression: Can't log into gmail.com"
• fixed "iBench doesn't report results - tests run but no number is recorded"

• platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): Removed extra ! character.

3:21 PM Changeset in webkit [17698] by beidson

• 3 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released

• WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto (WebFrameLoaderClient::setUpPolicyListener): Ditto (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto

2:58 PM Changeset in webkit [17697] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace

Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See ​http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.

• rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): It is possible for a prevRootBox and its prevRootBox to share a lineBreakObj. So instead of just clearing the lineBreakObj of the prevRootBox, cycle through all prevRootBoxs with the same lineBreakObj.

2:30 PM Changeset in webkit [22508] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Put the OpenSource revision in the WebKit.dll version info.

2:06 PM Changeset in webkit [17696] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
​http://bugs.webkit.org/show_bug.cgi?id=11556

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):

2:05 PM Changeset in webkit [17695] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
​http://bugs.webkit.org/show_bug.cgi?id=11556

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):

1:48 PM Changeset in webkit [17694] by thatcher

• 1 edit in trunk/WebKit/WebCoreSupport/WebEditorClient.mm

Build fix.

1:40 PM Changeset in webkit [17693] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-09 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414

• kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):

1:37 PM Changeset in webkit [17692] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2006-11-09 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414

• kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):

1:11 PM Changeset in webkit [22507] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Fix line-endings.

• WebEditorClient.cpp:

12:54 PM Changeset in webkit [22506] by oliver

• 3 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Build fixes

• WebEditorClient.cpp: (WebEditorClient::respondToChangedContents):
• WebEditorClient.h:

12:51 PM Changeset in webkit [17691] by aroben

• 3 edits
  1 copy
  3 adds in trunk

LayoutTests:

Reviewed by Geoff.

New test to keep the mistake I made in r17680 from happening again.

• fast/block/margin-collapse/negative-margins-expected.checksum: Added.
• fast/block/margin-collapse/negative-margins-expected.png: Added.
• fast/block/margin-collapse/negative-margins-expected.txt: Added.
• fast/block/margin-collapse/negative-margins.html: Added.

WebCore:

Reviewed by Geoff.

Fix the change in behavior I caused in r17680 with my build fix.

• rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

11:48 AM Changeset in webkit [17690] by andersca

• 15 edits in trunk

WebCore:

Reviewed by Adam, Oliver.

Move more functions to Editor.

• bridge/EditorClient.h:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.h:
• editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
• editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::dispatchEditableContentChangedEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
• editing/Editor.h:
• editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
• page/Frame.cpp:
• page/Frame.h:

WebKit:

Reviewed by Adam, Oliver.

Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame): (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::didEndEditing):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):

11:00 AM Changeset in webkit [22505] by lamadio

• 3 edits in branches/WindowsMerge/WebCore

2006-11-08 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren

Moved CookieJar to OpenSourceWin
Ported CookieJar to CFNetwork
Corrected an uninitialized variable which crashed on Vista in the Wininet code

• WebCore.vcproj/WebCore.vcproj:
• platform/network/win/CookieJarWin.cpp:

8:31 AM Changeset in webkit [17689] by darin

• 2 edits in trunk/WebCore

• rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.

8:17 AM Changeset in webkit [17688] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass

• html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): check lastSection before deleting row

7:41 AM Changeset in webkit [17687] by darin

• 3 edits in trunk/WebCore

• improved version of last night's build fix (should not do using namespace in a header)

• rendering/RenderObject.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

7:38 AM Changeset in webkit [17686] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=11552

• ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

7:34 AM Changeset in webkit [17685] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=11552

• ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

7:27 AM Changeset in webkit [17684] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11539

• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

7:24 AM Changeset in webkit [17683] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
​http://bugs.webkit.org/show_bug.cgi?id=11539

• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

Nov 8, 2006:

11:31 PM Changeset in webkit [22504] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Make the same change here as made in r11013.

11:13 PM Changeset in webkit [22503] by mjs

• 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

• added ResourceError class and didFailWithError client method

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFailLoadingWithError): (WebCore::PluginStreamWin::didFinishLoading):
• plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Geoff.

• added ResourceError class and didFailWithError client method

• WebFrame.cpp: (WebFrame::didFinishLoading): (WebFrame::didFailWithError):
• WebFrame.h:

10:49 PM Changeset in webkit [17682] by mjs

• 16 edits
  3 adds in trunk

Reviewed by Geoff.

• added ResourceError class and didFailWithError client method

• WebCore.xcodeproj/project.pbxproj:
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError):
• loader/loader.h:
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
• platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptCFReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adopt):
• platform/network/ResourceError.cpp: Added.
• platform/network/ResourceError.h: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
• platform/network/ResourceHandle.cpp:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFailWithError):
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::cancel):
• platform/network/mac/ResourceErrorMac.mm: Added. (-[NSError WebCore]):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::reportError):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading):
• xml/xmlhttprequest.h:

10:39 PM Changeset in webkit [17681] by bdash

• 9 edits
  1 add in trunk/WebCore

2006-11-08 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk fixes.

• platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::~ChromeClientGdk):
• platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor): (WebCore::moveCursor):
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
• platform/gdk/PageGdk.cpp:
• platform/gdk/ScreenClientGdk.h: Added. (WebCore::ScreenClientGdk::~ScreenClientGdk):
• platform/gdk/ScreenGdk.cpp: (WebCore::ScreenClientGdk::depth): (WebCore::ScreenClientGdk::depthPerComponent): (WebCore::ScreenClientGdk::isMonochrome): (WebCore::ScreenClientGdk::rect): (WebCore::ScreenClientGdk::usableRect):
• platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::historyURL): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable):
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::client):
• platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):

9:58 PM Changeset in webkit [17680] by aroben

• 2 edits in trunk/WebCore

Build fix.

• rendering/RenderObject.h: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

9:22 PM Changeset in webkit [22502] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Updated Windows to use the new platform abstraction for Screen.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
• platform/win/ScreenWin.cpp: (WebCore::monitorInfoForWidget): (WebCore::deviceInfoForWidget): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

9:18 PM Changeset in webkit [17679] by brmorris

• 1 edit in S60/trunk/README.txt

Updating README.txt to point to new wiki location.

9:18 PM Changeset in webkit [17678] by ggaren

• 7 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.

• bindings/js/kjs_window.cpp: Removed unnecessary subtractions when computing the screen's available dimensions.

7:55 PM Changeset in webkit [17677] by weinig

• 3 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject

• rendering/RenderObject.cpp: (WebCore::RenderObject::operator delete): (WebCore::RenderObject::createObject): (WebCore::RenderObjectCounter::~RenderObjectCounter): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isDescendantOf): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::removeChild): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): (WebCore::RenderObject::previousInPreOrder): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::nextEditable): (WebCore::RenderObject::previousEditable): (WebCore::RenderObject::firstLeafChild): (WebCore::RenderObject::lastLeafChild): (WebCore::RenderObject::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::updateFirstLetter): (WebCore::RenderObject::offsetParent): (WebCore::RenderObject::scroll): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::containingBlockHeight): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintObjectsBeforeLayout): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::information): (WebCore::RenderObject::dump): (WebCore::selectStartNode): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::createAnonymousBlock): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::setStyleInternal): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::absolutePosition): (WebCore::RenderObject::caretRect): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::tabWidth): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::arenaDelete): (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::invalidateVerticalPositions): (WebCore::RenderObject::recalcMinMaxWidths): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::setInlineBoxWrapper): (WebCore::RenderObject::firstLineStyle): (WebCore::RenderObject::getPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::collectDashboardRegions): (WebCore::RenderObject::avoidsFloats): (WebCore::RenderObject::findCounter): (WebCore::RenderObject::backslashAsCurrencySymbol): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::previousOffset): (WebCore::RenderObject::nextOffset): (WebCore::RenderObject::inlineBox):
• rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::renderName): (WebCore::RenderObject::parent): (WebCore::RenderObject::previousSibling): (WebCore::RenderObject::nextSibling): (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::getOverflowClipRect): (WebCore::RenderObject::getClipRect): (WebCore::RenderObject::getBaselineOfFirstLineBox): (WebCore::RenderObject::setEdited): (WebCore::RenderObject::setStaticX): (WebCore::RenderObject::setStaticY): (WebCore::RenderObject::setPreviousSibling): (WebCore::RenderObject::setNextSibling): (WebCore::RenderObject::setParent): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymousBlock): (WebCore::RenderObject::isDragging): (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::setMinMaxKnown): (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc): (WebCore::RenderObject::setPositioned): (WebCore::RenderObject::setRelPositioned): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setShouldPaintBackgroundOrBorder): (WebCore::RenderObject::setReplaced): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::calcWidth): (WebCore::RenderObject::updateFromElement): (WebCore::RenderObject::RepaintInfo::RepaintInfo): (WebCore::RenderObject::setOverrideSize): (WebCore::RenderObject::setPos): (WebCore::RenderObject::setWidth): (WebCore::RenderObject::setHeight): (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::overflowHeight): (WebCore::RenderObject::overflowWidth): (WebCore::RenderObject::setOverflowHeight): (WebCore::RenderObject::setOverflowWidth): (WebCore::RenderObject::overflowLeft): (WebCore::RenderObject::overflowTop): (WebCore::RenderObject::overflowRect): (WebCore::RenderObject::stopAutoscroll): (WebCore::RenderObject::collapsedMarginTop): (WebCore::RenderObject::collapsedMarginBottom): (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin): (WebCore::RenderObject::): (WebCore::RenderObject::setTable): (WebCore::RenderObject::isFloatingOrPositioned): (WebCore::RenderObject::containsFloat): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::SelectionInfo::SelectionInfo): (WebCore::RenderObject::lowestPosition): (WebCore::RenderObject::rightmostPosition): (WebCore::RenderObject::leftmostPosition): (WebCore::RenderObject::calcVerticalMargins): (WebCore::RenderObject::font):

6:21 PM Changeset in webkit [22501] by darin

• 4 edits in branches/WindowsMerge/WebCore

• fix the build

• bridge/win/FrameWin.h: Add a forward declaration of FormData.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.

• platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the TextField constructor.

6:18 PM Changeset in webkit [17676] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by zalan.
merged from 3.1m 17675
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
​http://bugs.webkit.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:07 PM Changeset in webkit [17675] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by zalan.
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:00 PM Changeset in webkit [22500] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

Build fix.

• WebEditorClient.cpp: Added stubs for new methods from EditorClient.h. (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
• WebEditorClient.h: Added new methods from EditorClient.h and cleaned up placement of *s.

6:00 PM Changeset in webkit [17674] by darin

• 30 edits
  2 adds in trunk

LayoutTests:

Reviewed by Anders.

• added test for option-tab

• fast/events/option-tab.html: Added.
• fast/events/option-tab-expected.txt: Added.

WebCore:

Reviewed by Anders.

• added event parameters to focus-related functions so we can implement the "option-tab to all links" behavior without relying on a global "current event" -- also makes it work with DOM events

• page/Frame.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
• page/Frame.cpp: (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from PlatformKeyboardEvent to the DOM keyboard event class. (WebCore::Frame::tabsToLinks): Added event parameter. (WebCore::Frame::tabsToAllControls): Ditto. (WebCore::scanForForm): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (WebCore::Frame::hitTestResultAtPoint): Ditto.

• bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
• bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of a PlatformKeyboardEvent. (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent() and pass event into next/previousFocusNode. (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from the AppKit current event, if it's a keyboard event. Really just a hack that's needed to preserve some code we can remove once we deal with the last NSView- based form control. (WebCore::isKeyboardOptionTab): Added. (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the option (alt) key is down. (WebCore::FrameMac::tabsToAllControls): Ditto. (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just call resetMultipleFormSubmissionProtection() explicitly instead. (WebCore::FrameMac::mouseDown): Ditto.

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to prepareForUserAction() to call resetMultipleFormSubmissionProtection() explicitly instead.

• page/FrameView.h:
• page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Changed function to take an event parameter, and decide the direction based on the shift key modifier instead of a passed-in boolean.

• dom/Document.h:
• dom/Document.cpp: (WebCore::Document::nextFocusNode): Added event parameter. (WebCore::Document::previousFocusNode): Ditto.
• dom/Node.h:
• dom/Node.cpp: (WebCore::Node::isKeyboardFocusable): Ditto.
• html/HTMLAnchorElement.h:
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
• html/HTMLGenericFormElement.h:
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
• html/HTMLInputElement.h:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
• html/HTMLSelectElement.h:
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
• html/HTMLTextAreaElement.h:
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Pass event to the advanceFocus function.

• platform/TextField.h:
• platform/mac/TextFieldMac.mm: Removed the non-search field code.

• platform/mac/WebCoreTextField.h:
• platform/mac/WebCoreTextField.mm: Removed the non-search field code. (-[WebCoreTextFieldController controlTextDidChange:]): Removed the call to FrameMac::handleKeyboardOptionTabInView, which is no longer needed since the default handler in HTMLInputElement takes care of option-tab.

• platform/mac/SliderMac.mm: (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent() and pass event into tabsToAllControls. (Slider::focusPolicy): Ditto.

• rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code. (WebCore::RenderLineEdit::updateFromElement): Ditto.

5:41 PM Changeset in webkit [22499] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

5:33 PM Changeset in webkit [17673] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Anders.

• same change as below, only tested this time

• DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links" mode off. I think we need to do this because WebPreferences saves things for us automatically. It would be good to turn that off for DumpRenderTree, but for now lets handle this like the other preferences (set it explicitly each time).

5:21 PM Changeset in webkit [17672] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Anders.

• DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on "tab to links" mode. No current tests depend on this, and there's a new test I want to land that depends on the default setting.

5:16 PM Changeset in webkit [17671] by beidson

• 2 edits in trunk/WebCore

Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)

<rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)

More "free nil checking" we lost in the transition from ObjC to C++

• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto

4:51 PM Changeset in webkit [17670] by andersca

• 19 edits in trunk

WebCore:

Reviewed by Adam.

Move more code into editor.

• WebCore.exp:
• bridge/EditorClient.h:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.h:
• dom/Document.cpp: (WebCore::Document::relinquishesEditingFocus): (WebCore::Document::acceptsEditingFocus): (WebCore::Document::didBeginEditing): (WebCore::Document::didEndEditing):
• editing/Editor.cpp: (WebCore::Editor::indent): (WebCore::Editor::outdent):
• editing/Editor.h:
• page/Frame.cpp:
• page/Frame.h:

WebKit:

Reviewed by Adam.

Move more code into editor.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
• WebCoreSupport/WebFrameBridge.mm:
• WebView/WebHTMLView.m: (-[NSArray indent:]): (-[NSArray outdent:]):
• WebView/WebView.mm:
• WebView/WebViewInternal.h:

4:41 PM Changeset in webkit [22498] by bdakin

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Add clause for new WebElementIsContentEditableKey to the Read
fucntion.

• Interfaces/IWebView.idl:
• WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):

2:58 PM Changeset in webkit [17669] by bdakin

• 9 edits in trunk

WebCore:

Reviewed by Adam.

Add ability to HitTestResult to ask if the inner non-shared node is
content editable.

• WebCore.exp: Export HitTestResult::isContentEditable()
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
• rendering/HitTestResult.h:

WebKit:

Reviewed by Adam.

Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Use new WebElementIsContentEditableKey.
• Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isContentEditable]): Call into HitTestResult::isContentEditable()
• WebView/WebView.mm: Add new key.
• WebView/WebViewPrivate.h: Add new key.

2:50 PM Changeset in webkit [17668] by andersca

• 2 edits in trunk/WebCore

Build fix.

• WebCore.xcodeproj/project.pbxproj: Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.

2:32 PM Coding Style Guidelines edited by sam@webkit.org

(diff)

2:24 PM Changeset in webkit [17667] by thatcher

• 12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection

Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.

• bindings/objc/DOM.mm: (WebCore::kit): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
• bindings/objc/DOMPrivate.h:
• dom/Range.cpp: (WebCore::Range::boundingBox): (WebCore::Range::addLineBoxRects):
• dom/Range.h:
• rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
• rendering/RenderContainer.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects):
• rendering/RenderObject.h:
• rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
• rendering/RenderText.h:

1:57 PM Changeset in webkit [22497] by adachan

• 6 edits in branches/WindowsMerge

1:57 PM Changeset in webkit [17666] by andersca

• 18 edits in trunk

WebCore:

Reviewed by Oliver.

Move methods from the bridge and frame into editor.

• WebCore.exp:
• bridge/EditorClient.h:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::toggleBold): (WebCore::Editor::toggleItalic): (WebCore::Editor::selectionStartHasStyle):
• editing/Editor.h:
• editing/JSEditor.cpp:
• page/Frame.cpp:
• page/Frame.h:

WebKit:

Reviewed by Oliver.

Call into the WebCore editor object directly.

• MigrateHeaders.make:
• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle):
• WebView/WebFrame.mm: (core): (kit):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]): (-[NSArray _changeCSSColorUsingSelector:inRange:]): (-[NSArray underline:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
• WebView/WebView.mm: (-[WebView applyStyle:]):

1:30 PM Changeset in webkit [17665] by andersca

• 2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app

• WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Initialize the framework pointer to 0.

1:26 PM Changeset in webkit [22496] by lamadio

• 10 edits in branches/WindowsMerge

1:20 PM Changeset in webkit [17664] by adachan

• 2 edits in trunk/JavaScriptCore

2006-11-08 Ada Chan <​adachan@apple.com>

Reviewed by darin.

Added a method to delete all the keys in a HashMap.

12:14 PM Changeset in webkit [17663] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Beth.

Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.

• platform/Screen.h:
• platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint): Grab the best screen instead of the screen you're on, since you might be off-screen.
• platform/mac/ScreenMac.mm: (WebCore::screenForWindow):

11:47 AM Changeset in webkit [22495] by andersca

• 5 edits
  3 adds in branches/WindowsMerge/WebKitTools

2006-11-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

Fix the build. Hook up a layoutTestController and implement dumpAsText, waitUntilDone and notifyDone.

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): (main):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added.
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Added. (dumpAsTextCallback): (waitUntilDoneCallback): (notifyDoneCallback): (getClass): (createLayoutTestController):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Added.
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didFinishLoadForFrame): (WaitUntilDoneDelegate::windowScriptObjectAvailable):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction):

11:13 AM Changeset in webkit [22494] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

Build fixes.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

More fiddling with midl to get our JSC API types recognized.

• Interfaces/IWebFrameLoadDelegate.idl:

9:32 AM Changeset in webkit [17662] by darin

• 3 edits in trunk/WebCore

• fix bug caused by last-minute change to my check-in last night that is causing layout tests to hang

• dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn a null string into an empty string before calling completeURL.

2:02 AM Changeset in webkit [17661] by beidson

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Maciej

Added test to cover bug ​http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched

• http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
• http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
• http/tests/xmlhttprequest/resources/endlessxml.php: Added.
• http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.

WebCore:

Reviewed by Maciej

If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

1:55 AM Changeset in webkit [22493] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Use m_frame instead of this, include the correct files.

1:51 AM Changeset in webkit [17660] by darin

• 2 edits in trunk/WebCore

• another attempt to fix Qt build

• loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.

1:48 AM Changeset in webkit [17659] by darin

• 3 edits in trunk/WebCore

Reviewed by Geoff.

• stray bits of my FrameLoader patch that I left out by accident

• loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class. (WebCore::FrameLoader::requestFrame): Use less DeprecatedString. (WebCore::FrameLoader::clear): Stop the redirection timer. (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the entire function in an if statement. Use less DeprecatedString. (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator. (WebCore::FrameLoader::scheduleRefresh): Ditto. (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class.
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto.

1:47 AM Changeset in webkit [22492] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

(I'm not doing this to get commit 11000)

• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): It's m_frame, not frame.

1:45 AM Changeset in webkit [17658] by darin

• 2 edits in trunk/LayoutTests

Reviewed by Geoff.

• fast/forms/submit-nil-value-field-assert.html: Update test so it no longer relies on incorrect "submit form right away during JavaScript execution" behavior.

1:43 AM Changeset in webkit [22491] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

It's FrameLoader, not FrameWin.

• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin):

1:40 AM Changeset in webkit [22490] by andersca

• 4 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <​acarlsson@apple.com>

A blind attempt at fixing the build.

• bridge/win/FrameWin.cpp:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameWin::partClearedInBegin):
• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::restoreDocumentState):

12:19 AM Changeset in webkit [17657] by bdakin

• 2 edits in trunk/LayoutTests

Reviewed by Geoff.

This test needs new results from my last check-in. I thought this
change was already in my tree, but I guess not. Whoops!

• fast/dom/delete-contents-expected.txt:

Nov 7, 2006:

11:48 PM Changeset in webkit [17656] by bdakin

• 10 edits
  25 adds in trunk

WebCore:

Reviewed by Hyatt.

Another go at fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The fix from yesterday caused a layout test regression which
exposed an existing bug. The existing bug was that we allowed text
nodes to stay in the head tag, but other browsers move them to the
body. The previous fix also caused a performance regression, which
was seemingly easy to fix by moving the new clause in
HTMLParser::handleError() to be below the HTMLElement case.

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to be the child of the document.
• html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::childAllowed): Do not allow non- whitespace text nodes to be children of the head.
• html/HTMLHeadElement.h:
• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Error case for comment nodes.
• page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safety-net null check for the original crash.

Layout Tests:

Reviewed by Hyatt.

Test cases for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

And for the found-bug of moving text nodes within the head to the
body.

11:24 PM Changeset in webkit [17655] by darin

• 2 edits in trunk/WebCore

• another attempt to fix Qt build

• loader/icon/IconLoader.h: Added missing include.

11:09 PM Changeset in webkit [22489] by ggaren

• 5 edits
  1 add
  2 deletes in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Fixed bug where Screen would query the default screen instead of the screen
on which the active window was located. (The code is written in Klingon,
but that's cool.)

Implemented some missing screen functionality on Win.

I can't fully verify this code because I can't load files without crashing
in CFNetwork, but I exercised most of it with javascript: URLs and the
debugger reported reasonable values.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/ScreenWin.cpp: Added. Merged over from opensource tree. (WebCore::getWindow): (WebCore::getMonitorInfo): (WebCore::getDeviceInfo): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect):

WebKitWin:

Reviewed by Anders.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

11:04 PM Changeset in webkit [17654] by ggaren

• 11 edits
  1 add
  5 deletes in trunk

WebCore:

Reviewed by Tim Hatcher.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
since the two were always used together.

Changed pixel depth queries to query the deepest screen. Darin mentioned
that it might have been a feature, not a bug, to use the main/menubar screen
regardless of the screen you were on. For scaling and flipping that's not
the case, but for querying pixel depth I think it is. You want to know
about the highest pixel depth your content may display on.

Tests still pass.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• page/Page.cpp: (WebCore::Page::Page):
• page/Page.h:
• page/Screen.cpp: Removed.
• page/Screen.h: Removed.
• page/ScreenClient.h: Removed.
• platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint):
• platform/mac/ScreenMac.mm: (WebCore::window): (WebCore::bestScreen): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect): (WebCore::toUserSpace): (WebCore::toDeviceSpace):

WebKit:

Reviewed by Geoff.

• udpated for changes to move from Frame/FrameMac to FrameLoader

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
• Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
• Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
• WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):

9:58 PM Changeset in webkit [17653] by darin

• 3 edits in trunk/WebCore

• try to fix Qt build

• CMakeLists.txt: Updated for some file changes.
• WebCoreSources.bkl: Ditto.

9:57 PM Changeset in webkit [22488] by darin

• 10 edits
  1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

• moved loader code from Frame/FrameMac to FrameLoader

• WebCore.vcproj/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
• bridge/win/FrameWin.h:
• loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::setTitle):
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::markMisspellings): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (IconLoader::notifyIconChanged): (PolicyCheck::PolicyCheck): (PolicyCheck::clear): (PolicyCheck::call): (PolicyCheck::clearRequest): (FrameLoader::saveDocumentState): (FrameLoader::restoreDocumentState): (FrameLoader::partClearedInBegin): (FrameLoader::goBackOrForward): (FrameLoader::historyURL): (FrameLoader::canGoBackOrForward): (FrameLoader::getHistoryLength): (DocumentLoader::setupForReplaceByMIMEType): (ResourceLoader::cancel): (DocumentLoader::stopLoading): (DocumentLoader::setLoading): (DocumentLoader::updateLoading): (DocumentLoader::setFrame): (DocumentLoader::stopRecordingResponses): (DocumentLoader::isStopping): (DocumentLoader::setPrimaryLoadComplete): (DocumentLoader::finishedLoading): (DocumentLoader::URL): (DocumentLoader::isLoadingInAPISense): (DocumentLoader::frameLoader): (FrameLoader::overrideMediaType): (FrameLoader::redirectDataToPlugin): (FrameLoader::checkLoadCompleteForThisFrame): (FrameLoader::loadEmptyDocumentSynchronously): (FrameLoader::startLoading): (FrameLoader::referrer):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::userAgent):

WebKitWin:

Reviewed by Geoff.

• moved loader code from Frame/FrameMac to FrameLoader

• WebFrame.cpp: (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::initWithWebFrameView): (WebFrame::loadDataSource): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading): (WebFrame::setTitle): (WebFrame::dispatchDidHandleOnloadEvents): (WebFrame::detachFrameLoader): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::hasBackForwardList): (WebFrame::resetBackForwardList): (WebFrame::provisionalItemIsTarget): (WebFrame::loadProvisionalItemFromPageCache): (WebFrame::invalidateCurrentItemPageCache): (WebFrame::privateBrowsingEnabled): (WebFrame::makeDocumentView): (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::updateHistoryForCommit): (WebFrame::updateHistoryForBackForwardNavigation): (WebFrame::updateHistoryForReload): (WebFrame::updateHistoryForStandardLoad): (WebFrame::updateHistoryForInternalLoad): (WebFrame::updateHistoryAfterClientRedirect): (WebFrame::setCopiesOnScroll): (WebFrame::tokenForLoadErrorReset): (WebFrame::resetAfterLoadError): (WebFrame::doNotResetAfterLoadError): (WebFrame::willCloseDocument): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromPageCache): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::dispatchDidLoadMainResource): (WebFrame::clearLoadingFromPageCache): (WebFrame::isLoadingFromPageCache): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::progressStarted): (WebFrame::progressCompleted): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finishedLoading): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::frameLoadCompleted): (WebFrame::restoreScrollPositionAndViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::userAgent):
• WebFrame.h:
• WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

9:52 PM Changeset in webkit [17652] by darin

• 79 edits
  1 copy
  1 add in trunk

WebCore:

Reviewed by Geoff.

• moved loader code from Frame/FrameMac to FrameLoader

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSXSLTProcessor.h:
• bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
• bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty):
• bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
• bindings/js/kjs_window.cpp: (KJS::Screen::Screen): (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Location::getValueProperty): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
• bindings/objc/DOM.mm: (+[DOMNode _nodeWith:WebCore::]):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::setView): (WebCore::FrameMac::setStatusBarText):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge receivedData:textEncodingName:]):
• css/cssparser.cpp: (WebCore::CSSParser::parseContent):
• dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
• dom/DOMImplementation.h:
• dom/Document.cpp: (WebCore::Document::readyState): (WebCore::Document::updateTitle): (WebCore::Document::open): (WebCore::Document::close): (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer): (WebCore::Document::finishedParsing):
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::notifyFinished):
• editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
• html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
• html/HTMLDocument.cpp: (WebCore::HTMLDocument::lastModified):
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
• html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::willRemove):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
• html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
• html/HTMLPreElement.idl:
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired):
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
• loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress):
• loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::cancelAll): (WebCore::getString): (WebCore::isBackForwardLoadType): (WebCore::numRequests): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::cancelRedirection): (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::gotoAnchor): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadDone): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::checkEmitLoadEvent): (WebCore::FrameLoader::baseURL): (WebCore::FrameLoader::baseTarget): (WebCore::FrameLoader::completeURL): (WebCore::FrameLoader::scheduleRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldUsePlugin): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::clearRecordedFormValues): (WebCore::FrameLoader::recordFormValue): (WebCore::FrameLoader::parentCompleted): (WebCore::FrameLoader::outgoingReferrer): (WebCore::FrameLoader::lastModified): (WebCore::FrameLoader::opener): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::openedByJavaScript): (WebCore::FrameLoader::setOpenedByJavaScript): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::setPolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::isComplete): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::url): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::stopRedirectionTimer): (WebCore::FrameLoader::updateBaseURLForEmptyDocument): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::started): (WebCore::FrameLoader::containsPlugins): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canTarget): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::hasMainResourceLoader): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::open): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::handledOnloadEvents): (WebCore::FrameLoader::frameDetached): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoaderClient::~FrameLoaderClient):
• loader/FrameLoader.h: (WebCore::):
• loader/FrameLoaderClient.h:
• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData):
• loader/ResourceLoader.h:
• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
• loader/loader.cpp: (WebCore::Loader::didReceiveResponse):
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setPrimaryLoadComplete):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::nsArray): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFinishLoad):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): (WebCore::CheckCacheObjectStatus):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::cancel):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
• loader/qt/FrameLoaderQt.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::originalRequestURL):
• page/DOMWindow.cpp: (WebCore::DOMWindow::document):
• page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::prepareForUserAction): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
• page/Frame.h:
• page/FramePrivate.h:
• page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::mediaType):
• page/FrameView.h:
• page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restoreJavaScriptState):
• platform/mac/CookieJar.mm: (WebCore::setCookies):
• platform/mac/TextCodecMac.cpp:
• platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
• platform/qt/FrameQt.cpp:
• platform/qt/FrameQt.h:
• rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
• rendering/RenderBlock.h:
• rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget):
• xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
• xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):

WebKit:

Reviewed by Geoff.

• udpated for changes to move from Frame/FrameMac to FrameLoader

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
• Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
• Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
• WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):

7:36 PM Coding Style Guidelines edited by Adam Roben

(diff)

7:05 PM Changeset in webkit [17651] by andersca

• 11 edits in trunk

WebCore:

Reviewed by Geoff.

Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]): (-[WebCoreFrameBridge selectionGranularity]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]): (-[WebCoreFrameBridge applyStyle:withUndoAction:]): (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
• editing/SelectionController.cpp: (WebCore::SelectionController::setModifyBias): (WebCore::SelectionController::modify):
• editing/SelectionController.h: (WebCore::SelectionController::):
• editing/TextGranularity.h:

WebKit:

Reviewed by Geoff.

Use the WebCore editing enums.

• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge undoNameForEditAction:]):
• WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[WebHTMLView moveBackward:]): (-[WebHTMLView moveBackwardAndModifySelection:]): (-[WebHTMLView moveDown:]): (-[WebHTMLView moveDownAndModifySelection:]): (-[WebHTMLView moveForward:]): (-[WebHTMLView moveForwardAndModifySelection:]): (-[WebHTMLView moveLeft:]): (-[WebHTMLView moveLeftAndModifySelection:]): (-[WebHTMLView moveRight:]): (-[WebHTMLView moveRightAndModifySelection:]): (-[WebHTMLView moveToBeginningOfDocument:]): (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): (-[WebHTMLView moveToBeginningOfSentence:]): (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]): (-[WebHTMLView moveToBeginningOfLine:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToBeginningOfParagraph:]): (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): (-[WebHTMLView moveToEndOfDocument:]): (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): (-[WebHTMLView moveToEndOfSentence:]): (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]): (-[WebHTMLView moveToEndOfLine:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfParagraph:]): (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): (-[WebHTMLView moveParagraphForwardAndModifySelection:]): (-[WebHTMLView moveUp:]): (-[WebHTMLView moveUpAndModifySelection:]): (-[WebHTMLView moveWordBackward:]): (-[WebHTMLView moveWordBackwardAndModifySelection:]): (-[WebHTMLView moveWordForward:]): (-[WebHTMLView moveWordForwardAndModifySelection:]): (-[WebHTMLView moveWordLeft:]): (-[WebHTMLView moveWordLeftAndModifySelection:]): (-[WebHTMLView moveWordRight:]): (-[WebHTMLView moveWordRightAndModifySelection:]): (-[WebHTMLView pageUp:]): (-[WebHTMLView pageDown:]): (-[WebHTMLView pageUpAndModifySelection:]): (-[WebHTMLView pageDownAndModifySelection:]): (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectParagraph:]): (-[WebHTMLView selectLine:]): (-[WebHTMLView selectSentence:]): (-[WebHTMLView selectWord:]): (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): (-[WebHTMLView _toggleBold]): (-[WebHTMLView _toggleItalic]): (-[WebHTMLView pasteFont:]): (-[WebHTMLView changeFont:]): (-[WebHTMLView changeAttributes:]): (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): (-[WebHTMLView changeColor:]): (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): (-[WebHTMLView alignCenter:]): (-[WebHTMLView alignJustified:]): (-[WebHTMLView alignLeft:]): (-[WebHTMLView alignRight:]): (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]): (-[WebHTMLView deleteForward:]): (-[WebHTMLView deleteBackward:]): (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]): (-[WebHTMLView deleteToBeginningOfLine:]): (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToBeginningOfParagraph:]): (-[WebHTMLView deleteToEndOfParagraph:]): (-[WebHTMLView subscript:]): (-[WebHTMLView superscript:]): (-[WebHTMLView unscript:]): (-[WebHTMLView underline:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
• WebView/WebView.mm: (-[WebView setTypingStyle:]): (-[WebView applyStyle:]):

5:34 PM WikiStart edited by pewtermoose@gmail.com

Add link to Web Inspector (diff)

5:33 PM Web Inspector created by pewtermoose@gmail.com

5:18 PM Coding Style Guidelines edited by bdash@webkit.org

(diff)

5:13 PM Coding Style Guidelines edited by sam@webkit.org

Add ToC (diff)

5:12 PM Coding Style Guidelines edited by sam@webkit.org

(diff)

5:02 PM Nightly Builds edited by bdash@webkit.org

(diff)

5:01 PM WikiStart edited by bdash@webkit.org

Remove outdated link (diff)

4:52 PM Coding Style Guidelines edited by sam@webkit.org

Finish port of Coding Style Guidelines (diff)

4:52 PM Changeset in webkit [17650] by beidson

• 2 edits in trunk/WebCore

Reviewed by Maciej

Changed the check for "top level frame" to something much more valid

• page/Frame.cpp: (WebCore::Frame::endIfNotLoading):

4:25 PM Coding Style Guidelines edited by sam@webkit.org

More Code Style Guidlines porting (diff)

4:21 PM Changeset in webkit [22487] by andersca

• 8 edits in branches/WindowsMerge

WebCoreWin:

2006-11-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Let the Frame client know when the window object is available.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::partClearedInBegin):
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::markMisspellings): (FrameWin::restoreDocumentState):

WebKitWin:

2006-11-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Call IWebFrameLoadDelegate::windowScriptObject available when the
window script object is available.

• Interfaces/IWebFrameLoadDelegate.idl: Get MIDL to understand the JSC API types.

• WebFrame.cpp: (WebFrame::windowScriptObjectAvailable): Call into the delegate.

• WebFrame.h:

4:06 PM Coding Style Guidelines created by sam@webkit.org

First wack at transfering Style Guildlines to the Wiki

3:52 PM Changeset in webkit [17649] by andersca

• 2 edits in trunk/JavaScriptCore

2006-11-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

• API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Initialize cachedPrototype to 0.

3:42 PM Changeset in webkit [22486] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• platform/win/TemporaryLinkStubs.cpp: Remove no-longer-needed stub.

3:39 PM WikiStart edited by sam@webkit.org

(diff)

3:05 PM Applications using WebKit edited by bradley.morrison@nokia.com

added web browser for s60 (diff)

2:44 PM Changeset in webkit [17648] by harrison

• 4 edits in trunk/LayoutTests

Updated.

• editing/pasteboard/4076267-2-expected.checksum:
• editing/pasteboard/4076267-2-expected.png:
• editing/pasteboard/4076267-2-expected.txt:

2:24 PM Changeset in webkit [17647] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Hyatt (yesterday).

Here is part of my patch from yesterday that is safe to roll back
in. It will make the BuildBot happy.

• rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.

1:07 PM Changeset in webkit [17646] by darin

• 2 edits in trunk/WebCore

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Comment grammar fix.

1:05 PM Changeset in webkit [17645] by darin

• 6 edits
  6 deletes in trunk

LayoutTests:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

WebCore:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

12:41 PM Changeset in webkit [17644] by darin

• 6 edits
  1 delete in trunk/WebCore

Reviewed by Brady.

• fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher crashes on launch in WebCore::ResourceLoader::start

No layout test, because this depends on cached icons, although there's
perhaps a way to write a test for it with some further ingenuity.

• loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable to make explicit the fact that it can't be successfully copied. Remove notifyIconChanged function and put the contents in the caller. This eliminates the need for IconLoaderMac.mm. Added finishedLoading and clearLoadingState functions to share code. Removed m_url, since the resource handle already stores the URL. Renamed m_resourceLoader to m_handle to reflect the class's name change. Removed the 4096-byte inline buffer from m_data, since the malloc savings is not sufficient to offset the additional memory use. Removed m_httpStatusCode because we can instead cancel the load when we get a status code that reflects failure. Added m_loadIsInProgress boolean because we need to detect loads that complete during the ResourceHandle::create function call.

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress. Don't initialize m_httpStatusCode. (WebCore::IconLoader::~IconLoader): Updated for name change. (WebCore::IconLoader::startLoading): Added code to use the m_loadIsInProgress flag to detect if the load completed while inside the ResourceHandle::create function. Removed code to set m_url. (WebCore::IconLoader::stopLoading): Call clearLoadingState to share more code. (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle and finish loading if the HTTP status code indicates failure. (WebCore::IconLoader::didReceiveData): Removed assertion that checks the ResourceHandle, since we can't do that any more. (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading so we can share code with the new didReceiveResponse code path. (WebCore::IconLoader::finishLoading): Moved code here from the didFinishLoading callback. Pass a URL when calling commitIconURLToIconDatabase. Call notifyIconChanged directly here instead of using a separate function. Call clearLoadingState to share more code with stopLoading. (WebCore::IconLoader::clearLoadingState): Added.

• loader/mac/IconLoaderMac.mm: Removed.
• WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.

11:32 AM Changeset in webkit [17643] by harrison

• 12 edits
  1 delete in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

• editing/pasteboard/3976872-expected.txt:
• editing/pasteboard/4076267-2-expected.txt:
• editing/pasteboard/4076267-3-expected.txt:
• editing/pasteboard/4076267-expected.txt:
• editing/pasteboard/8145-1-expected.txt:
• editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
• editing/pasteboard/paste-match-style-001-expected.txt:
• editing/pasteboard/paste-match-style-002-expected.txt:
• editing/pasteboard/paste-text-019-expected.txt:
• editing/pasteboard/pasting-tabs-expected.txt:

WebCore:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

• editing/pasteboard/3976872-expected.txt:
• editing/pasteboard/4076267-2-expected.txt:
• editing/pasteboard/4076267-3-expected.txt:
• editing/pasteboard/4076267-expected.txt:
• editing/pasteboard/8145-1-expected.txt:
• editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
• editing/pasteboard/paste-match-style-001-expected.txt:
• editing/pasteboard/paste-match-style-002-expected.txt:
• editing/pasteboard/paste-text-019-expected.txt:
• editing/pasteboard/pasting-tabs-expected.txt: Updated because pasting text with no newlines does not use intermediate div.

• editing/markup.cpp: (WebCore::fillContainerFromString): First parameter is now a Container so a fragment can be passed.

(WebCore::createFragmentFromText):
A string with no newlines gets added inline, rather than being put into a paragraph.

10:39 AM Changeset in webkit [17642] by ap

• 1 edit
  4 adds in trunk/LayoutTests

2006-11-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11505
REGRESSION: Null pointer deref in HitTestResult::spellingToolTip() (assertion failure in Node::document)

The null check was added as part for the fix for <rdar://problem/4820814>,
however the test that was committed with the fix avoids the case of a null
m_innerNonSharedNode, which this test covers.

• fast/css-generated-content/spellingToolTip-assert-expected.checksum: Added.
• fast/css-generated-content/spellingToolTip-assert-expected.png: Added.
• fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
• fast/css-generated-content/spellingToolTip-assert.html: Added.

2:47 AM Changeset in webkit [17641] by bdash

• 2 edits in trunk/WebKitSite

2006-11-07 Mark Rowe <​bdash@webkit.org>

Reviewed by Dave Hyatt.

• projects/javascript/index.html: Update link to non-existent JavaScript Bugzilla component to the correct JavaScriptCore.

12:36 AM Changeset in webkit [22485] by sfalken

• 4 edits in branches/WindowsMerge

Nov 6, 2006:

11:40 PM Changeset in webkit [22484] by sfalken

• 3 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.

Export JavaScriptCore C API via WebKit.

• WebKit.vcproj/WebKit.def:
• WebKit.vcproj/WebKit_debug.def:

11:15 PM Changeset in webkit [17640] by bdakin

• 6 edits
  6 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The bug here is that the source of the iframe is only a comment,
and we were not properly constructing the frame because it was
sort-of empty but not.

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if it is a comment node.
• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): if n is a comment node and there is no head, we create a head, insert in the document, and add the comment node as a child. This is what Firefox does too.
• page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safe-guard for the fix. It is possible to get a mouse event without a target node, so we null check it. (Of course, in the case of this bug, it should not have been null, but it is a good thing to check for anyway.
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.

Layout Tests:

Reviewed by Hyatt.

Test for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

• fast/frames/onlyCommentInIFrame-expected.checksum: Added.
• fast/frames/onlyCommentInIFrame-expected.png: Added.
• fast/frames/onlyCommentInIFrame-expected.txt: Added.
• fast/frames/onlyCommentInIFrame.html: Added.
• fast/frames/resources/comment.html: Added.
• fast/frames/resources/commentX.xhtml: Added.

9:42 PM Changeset in webkit [17639] by ggaren

• 13 edits in trunk/LayoutTests

New results. The originals were incorrect.

• svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:

9:27 PM Changeset in webkit [22483] by kmccullo

• 4 edits in branches/WindowsMerge

WebCoreWin:

-Fix test fields accepting text.

• WebCore.vcproj/WebCore.vcproj:

WebKitWin:

-Fix test fields accepting text.

• WebKit.vcproj/WebKit.vcproj:

7:32 PM Changeset in webkit [17638] by justing

• 5 edits
  8 adds in trunk

LayoutTests:

Reviewed by harrison

• editing/execCommand/4641880-1-expected.checksum: Added.
• editing/execCommand/4641880-1-expected.png: Added.
• editing/execCommand/4641880-1-expected.txt: Added.
• editing/execCommand/4641880-1.html: Added.
• editing/execCommand/4641880-2-expected.checksum: Added.
• editing/execCommand/4641880-2-expected.png: Added.
• editing/execCommand/4641880-2-expected.txt: Added.
• editing/execCommand/4641880-2.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4641880>
Setting bullets to existing text grabs subsequent paragraph

When a selection ends at the start of a paragraph, we rarely paint
the selection gap before that paragraph, because there often is no gap.
In a case like this, it's not obvious to the user that the selection
ends "inside" that paragraph, so it would be confusing if
InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.

• editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Moved the check for editability of the selection to a more appropriate place. Change the endingSelection if it ends at the start of a paragraph.
• editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::doApply): Ditto.
• editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Ditto.

7:25 PM Changeset in webkit [17637] by beidson

• 2 edits in trunk/WebCore

Reviewed by Sarge

<rdar://problem/4822911> - ASSERTION was a little overzealous.
Toned it down a bit.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading): Toned down assertion

6:34 PM Changeset in webkit [22482] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/4778180>
wikipedia.org crashes when loading

• platform/win/GlyphMapWin.cpp: (WebCore::GlyphMap::fillPage): Don't call GetGlyphIndices on buffers larger than the page size. GetGlyphIndicies doesn't know anything about Unicode supplementary characters and will overwrite the local buffer if the passed-in buffer is bigger than the page size.

6:33 PM Changeset in webkit [22481] by andersca

• 1 edit
  1 add in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Fork GlyphMapWin.cpp

• platform/win/GlyphMapWin.cpp: Added. (WebCore::GlyphMap::fillPage):

5:48 PM Changeset in webkit [22480] by ggaren

• 2 edits
  2 adds in branches/WindowsMerge/WebKitWin

Oops. Forgot to add these files.

Changed comment that Darin mentioned, too.

• WebChromeClient.cpp:
• WebScreenClient.cpp: Added. (WebScreenClient::create): (WebScreenClient::WebScreenClient): (WebScreenClient::depth): (WebScreenClient::depthPerComponent): (WebScreenClient::isMonochrome): (WebScreenClient::rect): (WebScreenClient::usableRect):
• WebScreenClient.h: Added.

5:09 PM Changeset in webkit [17636] by bdash

• 14 edits
  1 add in trunk

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Remove warning about garbage after #else. #else clause applies for all
non-mac platforms, not only win.

• kjs/date_object.cpp:

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk build fixes.

• loader/icon/IconDatabase.cpp:
• loader/icon/SQLStatement.h:
• platform/gdk/ChromeClientGdk.h: Added. (WebCore::ChromeClientGdk::~ChromeClientGdk):
• platform/gdk/CursorGdk.cpp: (WebCore::pointerCursor):
• platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::handleGdkEvent):
• platform/gdk/FrameGdk.h: (WebCore::FrameGdk::client):
• platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::updateFromElement):
• platform/gdk/ScreenGdk.cpp:
• platform/gdk/TemporaryLinkStubs.cpp: (Slider::focusPolicy): (WebCore::ServeSynchronousRequest): (FrameGdk::goBackOrForward): (FrameGdk::getHistoryLength): (FrameGdk::historyURL): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (WebCore::systemBeep): (WebCore::CachedResource::setPlatformResponse): (Path::transform): (ResourceLoader::loadsBlocked): (IconLoader::notifyIconChanged):
• platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add):

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\gdk build fixes.

• GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (main):

5:08 PM Changeset in webkit [17635] by thatcher

• 1 edit in trunk/WebCore/WebCore.exp

64-bit build fix, take two.

5:04 PM Changeset in webkit [17634] by thatcher

• 1 edit in trunk/WebCore/WebCore.exp

Build fix for 64-bit.

4:56 PM Changeset in webkit [17633] by ggaren

• 2 edits in trunk/WebKit

Reviewed by Darin.

Accidentally rolled out this change when removing the WebPageBridge. Now
putting it back.

• WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

4:47 PM S60Buzilla created by bradley.morrison@nokia.com

initial revision

4:30 PM Changeset in webkit [17632] by ggaren

• 2 edits in trunk/WebCore

build fix.

• WebCore.xcodeproj/project.pbxproj:

4:29 PM S60Webkit edited by bradley.morrison@nokia.com

minor type fixed (diff)

4:26 PM S60Reindeer created by bradley.morrison@nokia.com

4:01 PM Changeset in webkit [22479] by ggaren

• 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Hooked up the Chrome and Screen clients on Windows.

• WebCore.vcproj/WebCore.vcproj:
• bridge/win/PageWin.cpp:
• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
• platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin.

Stubbed out the Chrome and Screen clients.

• WebChromeClient.cpp: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): (WebChromeClient::pageRect): (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createWindow): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
• WebChromeClient.h:
• WebKit.vcproj/WebKit.vcproj:
• WebView.cpp: (WebView::initWithFrame):

3:56 PM Changeset in webkit [17631] by ggaren

• 38 edits
  6 adds
  8 deletes in trunk

WebCore:

Reviewed by Maciej, Anders, Darin.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
Fixed a minor where WebCore would always assume it was displayed on the
monitor containing the menubar. window.open and window.showModalDialog
are now cross-platform.

Layout tests, manual-tests/show-modal-dialog, and manual-tests/
window-open-features-parsing all pass. I verified the new screen functionality
by running in DRT, and checking whether WebCore knew it was off-screen.

Some refactoring remains, as all were not pleased by this design. I see
in my future another patch.

• bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a client, to encapsulate asking the platform questions about the screen occupied by the page. (Previously, we always assumed we were on screen 0, which was a bug.)
• bridge/mac/WebCoreFrameBridge.mm: (createMouseEventFromDraggingInfo): Reversed argument order, to match other functions. (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
• bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
• bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
• bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
• bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
• manual-tests/window-open-features-parsing.html: Updated for accuracy. (In this case, neither size nor position is specified, so you should get the default window size and position.)
• page/Screen.cpp: Added. Includes screen-related helper functions used in WebCore and WebKit.
• platform/PlatformMouseEvent.h: Exported common code so it doesn't have to be duplicated. Renamed "position" to "point" since both were used, and "point" seemed clearer.
• platform/Screen.h: Removed. Dead Code.
• platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge initialization.

WebKit:

Reviewed by Maciej, Darin, Anders.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.

(WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
about its own dimensions. The idea here is that we're asking the Chrome how
much space it has devoted to the page. We have API for this (-webViewContentRect), but
it was documented incorrectly (even Safari used it wrong), so we don't use
it anymore. Once we fix our API/documentation, we can return to making a
delegate callback to ask for the page's size.
(WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of making up its own.
(WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of broken out parcels.

• WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
• WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
• WebCoreSupport/WebScreenClient.h: Added.
• WebCoreSupport/WebScreenClient.mm: Added.
• WebView/WebView.mm: Added NULL checks for new _private->page, since it's not NULL-safe like the bridge was, and it gets cleared before dealloc.

3:36 PM S60CheckoutAndBuild created by bradley.morrison@nokia.com

3:09 PM S60ConfigureComputer created by bradley.morrison@nokia.com

2:44 PM Changeset in webkit [17630] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-06 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Enable toolbar capability support
​http://bugs.webkit.org/show_bug.cgi?id=11528

• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

2:44 PM Changeset in webkit [17629] by gdennis

• 13 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Part of patch for ​http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

No layout tests added as this must be tested manually by the test
WebCore/manual-tests/contenteditable-link.html

• WebCore.exp: Exported HitTestResult::isLiveLink().
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::isLiveLink):
• html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable to track shift key status.
• manual-tests/contenteditable-link.html: Added description about link dragging behaviour.
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::isLiveLink): Added.
• rendering/HitTestResult.h:

WebKit:

Reviewed by Tim Hatcher.

Part of patch for ​http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

• DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to WebHTMLView's _mayStartDragAtEventLocation
• Misc/WebElementDictionary.m: added isLiveLink (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isLiveLink]):
• WebView/WebHTMLView.m: (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should only be followed if isLiveLink is true (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not a move (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
• WebView/WebView.mm: added WebElementLinkIsLiveKey
• WebView/WebViewPrivate.h: ditto

2:43 PM BuildBot edited by bdash@webkit.org

Update some links and stuff (diff)

2:43 PM Changeset in webkit [17628] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-06 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​Sachin.Padma@nokia.com).
DESC: Enable toolbar capability
​http://bugs.webkit.org/show_bug.cgi?id=11528

• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

2:42 PM BuildBot edited by bdash@webkit.org

Update Twisted download instructions (diff)

2:39 PM BuildBot edited by bdash@webkit.org

Import of BuildBot instrutions (diff)

2:37 PM BuildBot created by bdash@webkit.org

Import of BuildBot instrutions

2:36 PM S60Webkit edited by bradley.morrison@nokia.com

(diff)

2:30 PM S60Webkit edited by bradley.morrison@nokia.com

(diff)

2:30 PM S60Webkit edited by bradley.morrison@nokia.com

(diff)

2:05 PM S60Webkit created by bradley.morrison@nokia.com

1:23 PM Changeset in webkit [17627] by thatcher

• 6 edits in trunk/WebKitSite

Reviewed by Anders.

Update the site with new wiki and Trac links.

• blog/wp-content/themes/webkit/sidebar.php:
• building/build.html:
• index.html:
• nav.inc:
• projects/svg/index.html:

1:03 PM Changeset in webkit [17626] by beidson

• 2 edits in trunk/WebCore

Reviewed by Oliver

Fixes <rdar://problem/4812674> and ​http://bugs.webkit.org/show_bug.cgi?id=11530
For now, we have to not load favicons when we have no Document - linking directly
to PDFs being the common case

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): Check for the document and return if none

1:00 PM Changeset in webkit [22478] by bdakin

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Oops! Silly mistake!

• WebElementPropertyBag.cpp: (convertStringToVariant):

12:56 PM Changeset in webkit [22477] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Fix build

• WebMutableURLRequest.cpp:

12:20 PM Changeset in webkit [17625] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: Place curet under the cursor position when activating an input box
​http://bugs.webkit.org/show_bug.cgi?id=11533

• BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):

12:14 PM Changeset in webkit [17624] by spadma

• 4 edits in S60/trunk/WebKit

2006-11-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] Remove toolbar in touch environment
​http://bugs.webkit.org/show_bug.cgi?id=11527

• BrowserView/inc/PointerEventHandler.h:
• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
• BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):

11:27 AM Changeset in webkit [17623] by oliver

• 1 edit
  4 moves
  12 adds in trunk/LayoutTests

2006-11-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Mitz.

• svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
• svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
• svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
• svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
• svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
• svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
• svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
• svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.

11:05 AM Changeset in webkit [17622] by beidson

• 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/4801066>
Added a critical null frameLoader() check

• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow):

10:26 AM Changeset in webkit [22476] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Copy npfunctions.h to WebKitOutputDir.

• WebCore.vcproj/WebCore.vcproj:

10:08 AM Changeset in webkit [17621] by harrison

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

• editing/deleting/delete-br-012-expected.checksum: Added.
• editing/deleting/delete-br-012-expected.png: Added.
• editing/deleting/delete-br-012-expected.txt: Added.
• editing/deleting/delete-br-012.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

Test:

• editing/deleting/delete-br-012.html

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Update m_endingPosition when preventing merge. Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.

9:47 AM Changeset in webkit [17620] by ap

• 2 edits in trunk/WebKitTools

Build fix, approved in principle by Tim H.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Disable deprecated warnings for main.c (TestNetscapePlugin), as it now uses QuickDraw to convert mouse event coordinates.

9:08 AM Changeset in webkit [17619] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
​http://bugs.webkit.org/show_bug.cgi?id=11525

• Drosera/debugger.js: imporved the function name code

7:55 AM Changeset in webkit [22475] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Fix double-include of FormData.cpp/.h.

• WebCore.vcproj/WebCore.vcproj:

6:19 AM Changeset in webkit [17618] by ap

• 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.

• css2.1/t0905-c414-flt-00-d-expected.checksum:
• css2.1/t0905-c414-flt-00-d-expected.png:
• css2.1/t0905-c414-flt-00-d-expected.txt:
• css2.1/t0905-c414-flt-00-d.html:

5:08 AM Changeset in webkit [17617] by ap

• 5 edits in trunk

Reviewed by Maciej.

Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
being attributed to the next test.

WebKitTools:

• DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
• DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):

LayoutTests:

Removed leftover results from the previous test.

• editing/selection/drag-to-contenteditable-iframe-expected.txt:

5:03 AM Changeset in webkit [17616] by bdash

• 3 edits in trunk/LayoutTests

2006-11-07 Mark Rowe <​bdash@webkit.org>

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Correctly updated tests results.

• fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
• fast/dom/HTMLMetaElement/meta-attributes.html:

4:54 AM Changeset in webkit [17615] by bdash

• 17 edits in trunk

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Update DOMNode::toString to always use className rather than preferring nodeName.

• bindings/js/kjs_dom.cpp: (KJS::DOMNode::toString): Match the format returned by valueOf.

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Updated test results for change from nodeName to className in DOMNode::toString.

• fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
• fast/dom/prototype-chain-expected.txt:
• fast/dom/replace-first-child-expected.txt:
• fast/events/mouseclick-target-and-positioning-expected.txt:
• fast/forms/input-appearance-preventDefault-expected.checksum:
• fast/forms/input-appearance-preventDefault-expected.png:
• fast/forms/input-appearance-preventDefault-expected.txt:
• fast/loader/loadInProgress-expected.txt:
• fast/tokenizer/external-script-document-write-expected.checksum:
• fast/tokenizer/external-script-document-write-expected.png:
• fast/tokenizer/external-script-document-write-expected.txt:
• traversal/stay-within-root-expected.checksum:
• traversal/stay-within-root-expected.png:
• traversal/stay-within-root-expected.txt:

4:36 AM Changeset in webkit [22474] by mjs

• 2 edits in branches/WindowsMerge/WebCore

• build fixes, adjusted for file move

• WebCore.vcproj/WebCore.vcproj:

3:08 AM Changeset in webkit [17614] by bdash

• 2 edits in trunk/WebKitTools

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.

• Scripts/run-webkit-tests: import the POSIX module.

2:57 AM Changeset in webkit [17613] by bdash

• 1 edit in trunk/WebKit/WebCoreSupport/WebFrameBridge.mm

Clean build fix after r17607: removed obselete header include.

1:16 AM Changeset in webkit [17612] by oliver

• 2 edits in trunk/WebCore

2006-11-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fix RTL text in SVG to have correct positioning

• rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::placeBoxesHorizontally):

12:43 AM Changeset in webkit [17611] by ap

• 7 edits
  2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11517
REGRESSION: Flash clicks/interactivity not working properly

WebCore:

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): Restore parts of event dispatching that were removed when fixing bug 7323 - just bypass those for subframes.

WebKitTools:

Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:

<embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
<script>

plg.eventLoggingEnabled = true;
use eventSender to simulate events...

</script>

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginSetProperty): (pluginAllocate):
• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
• DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_HandleEvent):

LayoutTests:

• plugins/mouse-events-expected.txt: Added.
• plugins/mouse-events.html: Added.

12:30 AM Changeset in webkit [17610] by bdash

• 3 edits
  3 adds in trunk

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

​http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

• kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Use ToString operator on each element rather than calling their toString method.

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

• fast/js/array-join-bug-11524-expected.txt: Added.
• fast/js/array-join-bug-11524.html: Added.
• fast/js/resources/array-join-bug-11524.js: Added.

Nov 5, 2006:

11:03 PM Changeset in webkit [22473] by bdakin

• 8 edits
  2 adds in branches/WindowsMerge

WebKit:

Reviewed by Steve and Anders. And sort of Maciej.

Here is a basic implementation of elementAtPoint for Boomer.

• Interfaces/IWebView.idl: The definitions of the WebElementPropertyBag keys.
• MarshallingHelpers.cpp: (MarshallingHelpers::intRectToSafeArray): New safe array creation function that creates a safe array out of an IntRect.
• MarshallingHelpers.h:
• WebElementPropertyBag.cpp: Added. This is the equivalent of WebElementDictionary on the Mac. (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::QueryInterface): (WebElementPropertyBag::AddRef): (WebElementPropertyBag::Release): (isEqual): (convertStringToVariant): (WebElementPropertyBag::Read): This is the bulk of the class. It compares the input key to all of the possible keys and calls the appropriate function for each. (WebElementPropertyBag::Write): Writing is not actually allowed.
• WebElementPropertyBag.h: Added.
• WebKit.vcproj/WebKit.vcproj:
• WebView.cpp: (WebView::elementAtPoint): Call into frame to get the HitTestResult for the point and set elementDictionary to the WebElementPropertyBag for the result.

WebCore:

Reviewed by Steve and Anders.

Add client() fucntion to FrameWin to return the FrameClient.

• bridge/win/FrameWin.h: (WebCore::FrameWin::client):

10:05 PM Changeset in webkit [17609] by darin

• 14 edits in trunk/WebCore

• quick attempt to fix the no-SVG build

• platform/graphics/svg/SVGResource.cpp:
• platform/graphics/svg/SVGResource.h:
• platform/graphics/svg/SVGResourceClipper.cpp:
• platform/graphics/svg/SVGResourceClipper.h:
• platform/graphics/svg/SVGResourceImage.h:
• platform/graphics/svg/SVGResourceMarker.cpp:
• platform/graphics/svg/SVGResourceMarker.h:
• platform/graphics/svg/SVGResourceMasker.cpp:
• platform/graphics/svg/SVGResourceMasker.h:
• platform/graphics/svg/cg/SVGResourceMaskerCg.h:
• platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
• platform/graphics/svg/qt/SVGResourceImageQt.cpp:
• platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added #ifdef SVG_SUPPORT to these files.

7:38 PM Changeset in webkit [22472] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build

• WebCore.vcproj/WebCore.vcproj:

7:15 PM Changeset in webkit [17608] by mjs

• 2 edits in trunk/WebCore

Reviewed & landed by Maciej.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11265

• platform/win/ResourceLoaderWin.cpp: (WebCore::transferJobStatusCallback): (WebCore::ResourceLoader::start):

6:55 PM Changeset in webkit [17607] by mjs

• 8 edits
  4 moves in trunk

WebCore:

Reviewed by Oliver.

• moved FormData and FormDataStream to platform/network directory

• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreFrameBridge.mm:
• loader/FormData.cpp: Removed.
• loader/FormData.h: Removed.
• loader/mac/FormDataStream.h: Removed.
• loader/mac/FormDataStream.m: Removed.
• loader/mac/FrameLoaderMac.mm:
• loader/mac/SubresourceLoaderMac.mm:
• platform/network/mac/FormDataStreamMac.h: Added.
• platform/network/mac/FormDataStreamMac.mm: Added.
• platform/network/mac/ResourceRequestMac.mm:

WebKit:

Reviewed by Oliver.

• removed unneeded (and obsolete) header includes

• WebCoreSupport/WebFrameBridge.mm:
• WebView/WebFrame.mm:

4:04 PM Changeset in webkit [22471] by sfalken

• 3 edits in branches/WindowsMerge/WebKitWin

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

• WebFrame.cpp:
• WebFrame.h:

3:54 PM Changeset in webkit [22470] by sfalken

• 3 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

• bridge/win/FrameWin.cpp:
• bridge/win/PageWin.cpp:

3:52 PM Changeset in webkit [17606] by sfalken

• 3 edits in trunk/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

• loader/DocumentLoader.h:
• platform/win/ScreenWin.cpp:

3:14 PM Changeset in webkit [17605] by darin

• 3 edits in trunk/WebKit

• WebKit part of Frame.h check-in (forgot to land it)

• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]): (-[WebFrameBridge shouldInterruptJavaScript]): (-[WebFrameBridge saveDocumentState:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge getObjectCacheSize]): (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebFrameBridge mayStartDragAtEventLocation:]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge getAppletInView:]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge setIsSelected:forView:]):

2:02 PM Changeset in webkit [17604] by darin

• 37 edits in trunk/WebCore

Reviewed by Geoff.

• more preparation for splitting up Frame into sub-pieces
• removed unnecessary includes from Frame.h

• page/Frame.h: Removed unneeded includes and forward declarations. Added additional forward declarations. Removed the constant NoXPosForVerticalArrowNavigation, now moved inside SelectionController. Created sections of functions to be moved into Chrome, Editor, EventHandler, FrameLoader, SelectionController, and the Platform directory, as well as marking one function for deletion.

• page/FramePrivate.h: Removed the definition of the constructor and destructor and removed unnecessary includes.

• page/FrameView.h: Removed unneeded forward declarations and friend declarations. Created a section of functions and data to be moved into EventHandler.

• bridge/mac/FrameMac.h: Removed unneeded forward declarations. Created sections of functions and data to be moved into Chrome, Editor, EventHandler, FrameLoader, and the Platform directory.

• bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment. Removed unused methods areScrollbarsVisible, nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.

• page/Frame.cpp: (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have to include KURL.h just for the KURL default constructor. (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h. (WebCore::FramePrivate::~FramePrivate): Ditto.

• page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf booleans, scrollbarMoved and cleared funcitons. (WebCore::FrameView::clear): Moved the code from the cleared function in here. (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated for changes to header.

• editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): Moved NoXPosForVerticalArrowNavigation into this file.

• bindings/js/kjs_events.cpp:
• bindings/js/kjs_html.cpp:
• bindings/js/kjs_window.cpp:
• bridge/mac/WebCoreAXObject.mm:
• bridge/mac/WebCoreFrameBridge.mm:
• css/cssstyleselector.cpp:
• dom/Document.cpp:
• dom/Element.cpp:
• dom/EventTargetNode.cpp:
• dom/MouseRelatedEvent.cpp:
• dom/XMLTokenizer.cpp:
• html/HTMLBaseElement.cpp:
• html/HTMLDocument.cpp:
• html/HTMLEmbedElement.cpp:
• html/HTMLFrameElementBase.cpp:
• html/HTMLGenericFormElement.cpp:
• html/HTMLObjectElement.cpp:
• html/HTMLTokenizer.cpp:
• loader/mac/FrameLoaderMac.mm:
• page/PageState.cpp:
• rendering/RenderApplet.cpp:
• rendering/RenderBlock.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderObject.cpp:
• rendering/RenderPartObject.cpp:
• rendering/RenderTreeAsText.cpp:
• xml/XSLTProcessor.cpp: Added includes as needed to keep compiling, since there are fewer includes in Frame.h.

12:36 AM Changeset in webkit [17603] by ap

• 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

​http://bugs.webkit.org/show_bug.cgi?id=11402
REGRESSION: onChange does not work anymore for 1st item in popup

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::reset): Set m_lastOnChangeIndex to -1.