Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 5, 2007:

10:24 PM Changeset in webkit [18638] by adele

• 2 edits in trunk/WebCore

Release build fix.

• rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.

5:36 PM Changeset in webkit [18637] by darin

• 391 edits
  935 adds
  152 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

• added a new version of the CSS 2.1 test from the W3C site
• added counters, list, and other CSS tests for my counter-related check-in

• css2.1: Updated to the 2006-10-11 version of the test suite. I downloaded it from ​http://www.w3.org/Style/CSS/Test/CSS2.1/20061011/ added UTF-8 BOMs to the beginning of all the files, and generated expected results.

• fast/css-generated-content/reset-content-to-initial-expected.txt: Updated to reflect a bug fix in CSS content property support.

• fast/css/counters/*: Removed all the existing tests since they are now part of the CSS 2.1 test suite.

• fast/css/counters/counter-text-security-expected.checksum: Added. New test.
• fast/css/counters/counter-text-security-expected.png: Ditto.
• fast/css/counters/counter-text-security-expected.txt: Ditto.
• fast/css/counters/counter-text-security.html: Ditto.

• fast/css/counters/counter-text-transform-expected.checksum: Added. New test.
• fast/css/counters/counter-text-transform-expected.png: Ditto.
• fast/css/counters/counter-text-transform-expected.txt: Ditto.
• fast/css/counters/counter-text-transform.html: Ditto.

• fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
• fast/lists/decimal-leading-zero-expected.png: Ditto.
• fast/lists/decimal-leading-zero-expected.txt: Ditto.
• fast/lists/decimal-leading-zero.html: Ditto.

• fast/css/text-security-expected.checksum: Added. New test.
• fast/css/text-security-expected.png: Ditto.
• fast/css/text-security-expected.txt: Ditto.
• fast/css/text-security.html: Ditto.

• fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
• fast/lists/decimal-leading-zero-expected.png: Ditto.
• fast/lists/decimal-leading-zero-expected.txt: Ditto.
• fast/lists/decimal-leading-zero.html: Ditto.

• fast/lists/li-values-expected.checksum: Added. New test.
• fast/lists/li-values-expected.png: Ditto.
• fast/lists/li-values-expected.txt: Ditto.
• fast/lists/li-values.html: Ditto.

• fast/css/import-rule-regression-11590-expected.checksum: Added. Missing pixel-test results.
• fast/css/import-rule-regression-11590-expected.png: Ditto.
• fast/dom/css-insert-import-rule-expected.checksum: Ditto.
• fast/dom/css-insert-import-rule-expected.png: Ditto.
• fast/forms/encoding-test-expected.checksum: Ditto.
• fast/forms/encoding-test-expected.png: Ditto.
• fast/frames/frame-src-attribute-expected.checksum: Ditto.
• fast/frames/frame-src-attribute-expected.png: Ditto.
• fast/frames/onlyCommentInIFrame-expected.png: Ditto.
• fast/frames/viewsource-attribute-expected.checksum: Ditto.
• fast/frames/viewsource-attribute-expected.png: Ditto.
• fast/loader/start-load-in-unload-expected.checksum: Ditto.
• fast/loader/start-load-in-unload-expected.png: Ditto.

WebCore:

Reviewed by Hyatt.

• eliminated use of DeprecatedString for list item markers
• eliminated use of DeprecatedValueList for border style collapsing
• made many members private instead of protected or public

• reworked counter implementation to fix most of the CSS 2.1 counter tests;

made CounterNode be a simple non-polymorphic class, moved most counter-
specific code out of RenderObject into RenderCounter, changed the data
structure in RenderStyle to be more speed-efficient but less space-
efficient for nodes with counter styles

• fixed ​http://bugs.webkit.org/show_bug.cgi?id=11557

Tests: css2.1

• fixed a bug where counter text did not have text transform or text security applied to it

Test: fast/css/counters/counter-text-security.html
Test: fast/css/counters/counter-text-transform.html

• improved handling of CSS content property values with data of the wrong type; this probably needs a bit more refinement

Test: fast/css-generated-content/reset-content-to-initial-expected.txt

• fixed a bug where removing the value attribute from an HTMLLIElement would set the list item's value to 0 instead of restoring it to normal

Test: fast/lists/li-values.html

• fixed a bug where changing the text security style from one style to another would not change the displayed text

Test: fast/css/text-security.html

• fixed some problems handling long sequences of counter-related styles; still needs more work and some super-large test cases to check if recursive algorithms for these that will overflow stack remain

• added support for list styles decimal-leading-zero, hiragana, hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian

Test: fast/lists/decimal-leading-zero.html

• minor tweaks and bug fixes for other list styles, including range checking

• WebCore.exp: Updated for RenderListItem change.

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Updated to use String instead of DeprecatedString.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed implementation for counter styles for now. We should probably restore it later, but we need to make sure the returned list is separate from the original list in the DOM -- modifying the list should not change the element it was computed from.

• css/Counter.h: Removed unneeded empty constructor and destructor.

• css/cssstyleselector.cpp: (WebCore::applyCounterList): Added. Stores counter directives in hash tables that should allow us to efficiently implement dynamic counter changes. Full support will have to wait for a future check-in. (WebCore::CSSStyleSelector::applyProperty): Changed counter properties to call applyCounterList. Reformatted the code to parse the content property for changes to RenderStyle and to handle the case where some the items in the content list don't generate any content.

• editing/visible_units.cpp:
• rendering/RenderBox.cpp:
• rendering/RenderFlexibleBox.cpp:
• rendering/RenderFlow.cpp:
• rendering/RenderSlider.cpp: Added includes needed because of header changes.

• html/HTMLLIElement.H: Removed unneeded m_isValued.
• html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): To match test results seen in WinIE, ignore values that are 0 or negative, and use new functions in RenderListItem to communicate the lack of a valid value. (WebCore::HTMLLIElement::attach): More of the same.

• rendering/CounterNode.h: Made CounterNode be a non-polymorphic class, removing all the subclasses. Merged in CounterResetNode. Removed m_total from CounterResetNode, because it isn't needed for any of the styles (decimal-leading-zero always uses two digits). Removed m_hasSeparator and m_willNeedLayout since they aren't needed any more. Renamed m_count to m_countInParent for clarify, and named the list links the same as their associated functions. Removed many functions as well.
• rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): Added new fields. (WebCore::CounterNode::computeCountInParent): Added. Used by recount. (WebCore::CounterNode::recount): Simplified by removing unused parameter and the "get next" idiom. Changed to be iterative instead of recursive so we can handle arbitrarily long lists. (WebCore::CounterNode::insertAfter): Moved here from CounterResetNode. Updated for field name changes. Corrected rule for when to recount. (WebCore::CounterNode::removeChild): Moved here from CounterResetNode. Changed to only work on nodes without children. Corrected rule for when to recount. (WebCore::nextInPreOrderAfterChildren): Added. For debugging only. (WebCore::nextInPreOrder): Ditto. (WebCore::showTreeAndMark): Ditto. (showTree): Ditto.

• rendering/CounterListItem.h:
• rendering/CounterResetNode.h:
• rendering/CounterResetNode.cpp: Marked ready to remove. I'll do the remove in a separate patch, since I have to update a lot of different make files when I do.

• rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText): Changed for the change to RenderListMarker.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): Changed to use functions instead of direct field access so the fields can be private and we don't need to be friends. (WebCore::RenderBlock::getBaselineOfFirstLineBox): Ditto. (WebCore::RenderBlock::getBaselineOfLastLineBox): Ditto.
• rendering/RenderBlock.h: (WebCore::RenderBlock::initMaxMarginValues): Ditto. (WebCore::RenderBlock::firstRootBox): Ditto. (WebCore::RenderBlock::lastRootBox): Ditto.
• rendering/RenderBox.h: (WebCore::RenderBox::setWidth): Ditto. (WebCore::RenderBox::setHeight): Ditto.
• rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): Ditto.
• rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Ditto.

• rendering/RenderContainer.h: Renamed m_first and m_last to m_firstChild and m_lastChild. Made them private instead of proected. Removed the setFirstChild and setLastChild functions.
• rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer): Updated for field name change. Changed all calls to get at fields directly instead of using functions. (WebCore::RenderContainer::destroyLeftoverChildren): Ditto. (WebCore::updateListMarkerNumbers): Updated for RenderListItem change. (WebCore::RenderContainer::addChild): Changed to get at fields directly instead of using functions. Also used release() since RenderText::setText now takes PassRefPtr. (WebCore::RenderContainer::removeChildNode): Changed to get at fields directly instead of using functions. (WebCore::RenderContainer::updatePseudoChildForObject): Create the anonymous box only if at least one of of the items in the content list actually generates content. Since a RenderCounter is a RenderText, don't bother making a new style for it -- it just shares the style with its parent. Changed code to use RenderImage::setCachedImage() instead of of setContentObject(). Added a call to setIsAnonymousImage() here, which was the only special thing that setContentObject() used to do. Pass a reference to the counter to the RenderCounter rather than a pointer. Pass document() as the node instead of passing the element to RenderCounter, which makes it anonymous automatically, and removed the setIsAnonymous call. (WebCore::RenderContainer::appendChildNode): Chagned to get at fields directly instead of using functions. (WebCore::RenderContainer::insertChildNode): Ditto. (WebCore::RenderContainer::layout): Ditto. (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): Ditto. (WebCore::RenderContainer::positionForCoordinates): Ditto. (WebCore::RenderContainer::addLineBoxRects): Ditto.

• rendering/RenderCounter.h: Removed unneeded layout override, never called on a text node. Added override of originalString. Replaced CounterData* with a copy of the CounterContent -- it's two atomic strings and an integer so it's efficient enough to store all three in the render object, and this eliminates the lifetime problems we could have if we used a pointer.
• rendering/RenderCounter.cpp: Removed duplicate copy of list marker code. (WebCore::counterMaps): Moved these maps here from RenderObject. (WebCore::previousSiblingOrParent): Added. (WebCore::lastDescendant): Added. (WebCore::previousInPreOrder): Added. (WebCore::planCounter): Added. (WebCore::findPlaceForCounter): Added. (WebCore::counter): New name of function that was named RenderObject::findCounter. Also uses a new algorithm that passes all the CSS 2.1 tests. (WebCore::RenderCounter::RenderCounter): Changed to take a Document* instead of a Node*, since at the moment counters are always anonymous. (WebCore::RenderCounter::originalString): Added. This overrides the originalString in the RenderText base class so that any text transforms will use the counter's value. This code was previously in calcMinMaxWidth. (WebCore::RenderCounter::calcMinMaxWidth): Changed to call setInternalString and pass originalString -- this uses the counter's value from the counter tree. (WebCore::destroyCounterNodeChildren): Added. (WebCore::RenderCounter::destroyCounterNodes): Added. Called as needed from RenderObject::destroy for objects that have counter nodes.

• rendering/RenderFlow.h: Made m_continuation private instead of protected.

• rendering/RenderImage.h: Removed unneeded includes, and unnecessary element() function that casts to HTMLElement*. Made image() protected, and made the two calcAspectRatio functions private. Removed setContentObject(). Renamed the errorOccured() function to isErrorImage() and made it private.
• rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Removed initialization of removed m_selectionState field. (WebCore::RenderImage::setCachedImage): Rearrange code so it won't try to call isErrorImage() on a null image. (WebCore::RenderImage::paint): Updated for name change.

• rendering/RenderListBox.h: Removed unneeded forward declarations.

• rendering/RenderListItem.h: Renamed markerStringValue() to markerText() and made it return a String instead of a DeprecatedString. Renamed m_prededfVal to m_explicitValue. Added booleans named m_hasExplicitValue and m_isValueUpToDate and marked m_value mutable so it can be computed in const member functions. (WebCore::RenderListItem::value): Changed to update value on demand at the time you ask for it. (WebCore::RenderListItem::hasExplicitValue): Added. Use instead of magic -1 value to indicate that the item does or does not have an explicit value. (WebCore::RenderListItem::explicitValue): Added. (WebCore::RenderListItem::setExplicitValue): Added. (WebCore::RenderListItem::clearExplicitValue): Added.
• rendering/RenderListItem.cpp: (WebCore::RenderListItem::RenderListItem): Updated to not use magic -1 values. (WebCore::RenderListItem::setStyle): Removed call to RenderListMarker::setListItem since it's not needed any more, and instead pass the list item to the constructor. (WebCore::previousListItem): Made parameter const. (WebCore::RenderListItem::calcValue): Restructed the function a bit. (WebCore::RenderListItem::updateValueNow): Added. Calls calcValue. (WebCore::RenderListItem::updateValue): Added. New name for resetValue(). Unlike the old version, this no longer calculates the value until it's asked-for later. (WebCore::RenderListItem::markerText): Changed to return String rather than a DeprecatedString and to return a null string rather than empty string when there is no marker.

• rendering/RenderListMarker.h: Added listMarkerText function -- common code shared with anyone who needs to convert a value into text given a list style. Changed constructor to take a RenderListItem and figure out the document from that. Added isImage() and isText() functions and removed listImage() function. Changed the type of the text() function from DeprecatedString to String. Removed the listItem() and seListeItem() functions. Made the getRelativeMarkerRect() function private. Renamed m_item to m_text and chagned it from DeprecatedString to String. Renamed m_listImage to m_image.
• rendering/RenderListMarker.cpp: (WebCore::toRoman): Added range checking to fix buffer overrun for large or negative numbers. Rewrote to use a local UChar array and String rather than prepending to a DeprecatedString. (WebCore::toAlphabetic): Replaces toLetterString, and is more flexible since it takes an alphabet array. Changed to match CSS 3 specification by using decimal numbering for 0 and negative numbers. Rewrote to use a local UChar array and String rather than prepending to a DeprecatedString. (WebCore::toHebrewUnder1000): Added. Helper function for Hebrew numbers so we can handle numbers up to a million. (WebCore::toHebrew): Changed to use toHebrewUnder1000, added a special case for zero, negative, and too-large numbers. (WebCore::toArmenianUnder10000): Added. Used by toArmenian. (WebCore::toArmenian): Added. (WebCore::toGeorgian): Added. (WebCore::toCJKIdeographic): Added. (WebCore::listMarkerText): Added. Moved the code here from calcMinMaxWidth, but added support for text for the styles disc, circle, square, decimal-leading-zero, hiragana, hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian. Also changed some of the styles to share the new toAlphabetic function. (WebCore::RenderListMarker::RenderListMarker): Updated for name changes and list item parameter. (WebCore::RenderListMarker::~RenderListMarker): Updated for name changes. (WebCore::RenderListMarker::setStyle): Updated for name changes. (WebCore::RenderListMarker::isImage): Added. Useful helper that unifies the check for no image and the error image. (WebCore::RenderListMarker::paint): Updated for name changes to to use isImage() and rearranged the code a bit. (WebCore::RenderListMarker::imageChanged): Updated for name change (WebCore::RenderListMarker::calcMinMaxWidth): Updated for name change, fixed a bug where we'd leave the old text around if we were using an image-based marker. Also changed the code to use isImage() instead of checking m_listImage. (WebCore::RenderListMarker::calcWidth): Changed to use isImage(). (WebCore::RenderListMarker::lineHeight): Changed to use isImage(). (WebCore::RenderListMarker::baselinePosition): Changed to use isImage(). (WebCore::RenderListMarker::getRelativeMarkerRect): Changed to use isImage(), restructured the code a little.

• rendering/RenderObject.h: Removed now-uneeded includes. Removed collectBorders() and isFormElement(). Made remove() function and m_hasCounterNodeMap public so we could remove friend declarations for RenderListItem and RenderView. Moved findCounter() to become a private function inside RenderCounter.cpp.
• rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Fix bug where a contentData() with CONTENT_NONE is treated as image content -- only look at the content property if it has exactly one entry which is a CONTENT_OBJECT. (WebCore::RenderObject::selectionStartEnd): Add const. (WebCore::RenderObject::destroy): Moved counter-specific code to RenderCounter::destroyCounterNodes. (WebCore::RenderObject::recalcMinMaxWidths): Changed code to set m_recalcMinMax near the top of the function -- the old code would potentially reset it after it was set by the calcMinMaxWidths functions, and possibly skip a future needed recalc. That came up in counter test cases. Removed unneeded boolean check right after an assertion.

• rendering/RenderPart.h: Marked two virtual functions virtual for clarity.

• rendering/RenderReplaced.h: Made shouldPaint be protected, and made m_intrinsicWidth, m_intrinsicHeight, and m_selectionState be private. Also marked isSelected() const.
• rendering/RenderReplaced.cpp: Added newly-needed include. (WebCore::RenderReplaced::RenderReplaced): Use constructor syntax. (WebCore::RenderReplaced::isSelected): Made const and changed to call the selectionStartEnd function in the straightforward way.

• rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): Use functions instead of direct field access so the fields can be private. (WebCore::RenderSVGText::relativeBBox): Ditto.

• rendering/RenderStyle.h: Tweaked formatting. Changed names of CSS3 holders to say "rare" instead, since it's not all CSS 3. Renamed CounterData to CounterContent, since it's used inside ContentData. Changed names of fields in ContentData to have m prefix. Moved content and counter fields into the rare non-inherited data object. Removed unneeded assignment operator from a class that already inherits from Shared which makes it start out noncopyable.
• rendering/RenderStyle.cpp: Name changes, plus: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Updated for added fields (content, counter-reset, counter-increment). (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Ditto. (WebCore::StyleRareNonInheritedData::operator==): Reformatted and sorted so it's easy to see if any fields are missing. (WebCore::operator!=): Added. Compares two CounterContent objects. (WebCore::RenderStyle::arenaDelete): Removed code to handle content, which is now in the rareNonInheritedData structure. (WebCore::RenderStyle::RenderStyle): Ditto. (WebCore::RenderStyle::inheritFrom): Ditto. (WebCore::RenderStyle::operator==): Ditto. (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): Added case for counter, which previously would be ignored when determining if content is equivalent. (WebCore::RenderStyle::clearContent): Added. (WebCore::RenderStyle::setContent): Updated for change in content location. (WebCore::ContentData::clear): Changed algorithm so that it's not recursive and thus can handle a very long list of ContentData. (WebCore::operator==): Added. Compares two CounterDirective objects. (WebCore::RenderStyle::counterDirectives): Added. (WebCore::RenderStyle::accessCounterDirectives): Added.

• rendering/RenderTable.h: Made m_currentBorder const to better reflect the paint algorithm.
• rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed to use Vector instead of DeprecatedValueList for the border styles, and to sort rather than inserting in sorted order as we go. Put the code to loop through the nodes and collect border styles here instead of in a RenderObject virtual function. Also set m_currentBorder to 0 after the loop for greater clarity.

• rendering/RenderTableCell.h: Added a typedef for a vector of border values. Removed the virtual collectBorders and replaced with the non-virtual named collectBorderStyles. Also added a static member function named sortBorderStyles.
• rendering/RenderTableCell.cpp: (WebCore::CollapsedBorders::CollapsedBorders): Removed unneeded constructor parameter. (WebCore::addBorderStyle): Changed to use a vector instead of a DeprecatedValueList. Wrote out a loop since Vector doesn't have a contains member function. Removed the code to insert the border at a sorted location; instead we have a separate call to sort the border styles (WebCore::RenderTableCell::collectBorderStyles): Renamed, and changed the parameter type. (WebCore::compareBorderStylesForQSort): Added. (WebCore::RenderTableCell::sortBorderStyles): Added.

• rendering/RenderText.h: Changed StringImpl parameters in setText functions to be PassRefPtr; added a new setInternalString function. Made a bunch of the member functions private and made all the data members private instead of protected.
• rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Restructure a bit for clarity. Fix case where the old style has a different security than the new style. Use release() since RenderText::setText now takes PassRefPtr. Always call cacheWidths here. (WebCore::RenderText::setTextWithOffset): Changed to take the string as a PassRefPtr instead of a raw pointer. (WebCore::isInlineFlowOrEmptyText): Added. (WebCore::RenderText::setInternalString): Refactored core of setText into a separate protected member function that can be used RenderCounter. Changed the text security square character to match what's used in list markers. Changed the text transform switch statement so that gcc will warn us if we add a new value and don't add a case for it. (WebCore::RenderText::setText): Refactored most of the function into setInternalString. Removed the call to cacheWidths -- that's now done in the setStyle function only.

• rendering/RenderView.h:
• rendering/RenderView.cpp: (WebCore::RenderView::selectionStartEnd): Now const.

• rendering/RenderWidget.cpp: Added newly-needed include. (WebCore::RenderWidget::setSelectionState): Don't bother setting m_selectionState here since RenderReplaced::setSelectionState already does that.

WebKit:

Reviewed by Hyatt.

• Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): Updated to use new list marker text API that is String rather than DeprecatedString. Also removed code to do text form of non-text list markers since the list marker class now deals with that.

5:13 PM Changeset in webkit [18636] by andersca

• 3 edits in trunk/WebKit

Reviewed by Darin.

Fix build.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):

5:09 PM Changeset in webkit [22734] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Update temporary link stubs.

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::referrer): (FrameLoader::overrideMediaType): (FrameLoader::checkLoadCompleteForThisFrame): (DocumentLoader::getResponseRefreshAndModifiedHeaders): (MainResourceLoader::create): (ResourceLoader::cancel): (ResourceLoader::load): (ResourceLoader::releaseResources): (ResourceLoader::addData):

WebKitWin:

Reviewed by Adam.

Add stubs for FrameLoaderClient methods.

• WebFrame.cpp: (WebFrame::setMainDocumentError): (WebFrame::cancelledError): (WebFrame::cannotShowURLError): (WebFrame::interruptForPolicyChangeError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchUnableToImplementPolicy): (WebFrame::download): (WebFrame::willUseArchive): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::dispatchDidLoadResourceFromMemoryCache): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad): (WebFrame::dispatchCreatePage): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::startDownload):

4:55 PM Changeset in webkit [18635] by andersca

• 9 edits in trunk/WebCore

Rubber stamped by Adam.

Move even more code to .cpp files.

• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::post): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::applyUserAgent): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didChangeTitle):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):

4:21 PM Changeset in webkit [22733] by aliceli1

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.

Fixed <rdar://problem/4853400> disable commands in the Edit menu when they're not applicable
and <rdar://problem/4769487> Some editing operations should be disabled in View Source window

• Interfaces/IWebView.idl:
• WebView.cpp: (WebView::hasSelectedRange): (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled):
• WebView.h:

3:03 PM Changeset in webkit [18634] by adele

• 7 edits
  8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• repaint tests and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=12079 Nested tables don't repaint properly when a certain row is added

• fast/repaint/table-section-overflow-expected.checksum: Added.
• fast/repaint/table-section-overflow-expected.png: Added.
• fast/repaint/table-section-overflow-expected.txt: Added.
• fast/repaint/table-section-overflow.html: Added.
• fast/repaint/table-section-repaint-expected.checksum: Added.
• fast/repaint/table-section-repaint-expected.png: Added.
• fast/repaint/table-section-repaint-expected.txt: Added.
• fast/repaint/table-section-repaint.html: Added.
• tables/mozilla/core/misc-expected.txt:
• tables/mozilla/core/misc-expected.png:
• tables/mozilla/core/misc-expected.checksum:

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12079 Nested tables don't repaint properly when a certain row is added

Tests: fast/repaint/table-section-repaint.html

fast/repaint/table-section-overflow.html

Fixed repainting when table sections move during layout.

Made table cells' overflows propagate to table sections and gave tables
overflows.

• rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Added computation of horizontal and vertical overflows based on the caption's and the table sections' overflows. Added checks for table sections that change position during layout. When that happens, we assume all sections below the first section that moved also moved, and repaint everything downwards from there. Added calls to repaintDuringLayoutIfMoved() for the caption. Changed the way table sections are iterated over and added a FIXME to change it again once bug 12124 is fixed. (WebCore::RenderTable::paint): Changed to paint overflow. (WebCore::RenderTable::outerBorderBottom):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added code to compute the section's overflow and a flag saying whether any cells in this section overflow. (WebCore::RenderTableSection::paint): Changed to paint overflow. If any cell in the section has overflow, then all cells are given a chance to paint. This is needed because there can be internal overflow, and external overflow can be coming from any cell inside.
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowLeft):

2:48 PM Changeset in webkit [18633] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/4863434> Wrong contextual menu appears for
textarea and input elements at ​http://www.apple.com/feedback/
ical.html

No test cases added since context menus are not in DRT.

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Call EventHandler's hitTestResultAtPoint() instead of just hit testing the layer.

2:37 PM Changeset in webkit [22732] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Fix build.

• platform/win/TemporaryLinkStubs.cpp: (ResourceLoader::cancel): (FrameLoader::didChangeTitle): (DocumentLoader::unreachableURL):

WebKitWin:

Reviewed by Adam.

Add stubs for new FrameLoaderClient methods.

• WebFrame.cpp: (WebFrame::createDocumentLoader): (WebFrame::setMainDocumentError): (WebFrame::cancelledError): (WebFrame::cannotShowURLError): (WebFrame::interruptForPolicyChangeError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::shouldFallBack): (WebFrame::committedLoad):
• WebFrame.h:

2:27 PM Changeset in webkit [18632] by andersca

• 1 edit in trunk/WebCore/ChangeLog

independEnt

2:26 PM Changeset in webkit [18631] by andersca

• 9 edits in trunk/WebCore

Rubber-stamped by Adam.

Move a bunch of platform independant code over to DocumentLoader.cpp

• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::urlForHistory):
• loader/DocumentLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::mainResourceData):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::unreachableURL):
• loader/mac/FrameLoaderMac.mm:

2:18 PM Changeset in webkit [18630] by spadma

• 2 edits in S60/trunk/WebKit

2006-12-20 sareen <​shyam.sareen@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Change SDK exported files path MACRO for S60 builds.
​http://bugs.webkit.org/show_bug.cgi?id=11895

• group/bld.inf:

2:16 PM Changeset in webkit [18629] by spadma

• 2 edits in S60/trunk/WebKit

2007-01-05 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: xhtml link not opened 2nd time (TSW error id : MSZR-6TGH7D)
​http://bugs.webkit.org/show_bug.cgi?id=12130

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::MergeHeadersLC):

2:13 PM Changeset in webkit [18628] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2007-01-05 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: xhtml link not opened 2nd time (TSW error id : MSZR-6TGH7D)
​http://bugs.webkit.org/show_bug.cgi?id=12130

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::MergeHeadersLC):

1:18 PM Changeset in webkit [18627] by beidson

• 1 edit in trunk/WebCore/ChangeLog

Fixed Eric's name

1:14 PM Changeset in webkit [18626] by beidson

• 2 edits in trunk/WebCore

Reviewed by Eric Siedel

​http://bugs.webkit.org/show_bug.cgi?id=12117
Fixes null deref when opening links from a gmail account

• loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): Null check m_currentHistoryItem (WebCore::FrameLoader::updateHistoryForClientRedirect): Ditto

1:08 PM Changeset in webkit [22731] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Fix the build.

• WebCore.vcproj/WebCore.vcproj:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::CheckCacheObjectStatus):

1:00 PM Changeset in webkit [18625] by andersca

• 9 edits in trunk/WebCore

Move some now cross platform functions over to ResourceLoader.cpp in an attempt to fix the non Mac builds.

• loader/CachedResource.h: (WebCore::CachedResource::setAllData):
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData):
• loader/ResourceLoader.h:
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
• loader/mac/LoaderFunctionsMac.mm:
• loader/mac/ResourceLoaderMac.mm:
• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::platformDataSize):
• platform/network/ResourceHandle.h:

12:57 PM Changeset in webkit [18624] by hyatt

• 3 edits in trunk/LayoutTests/fast/block/float

Land updated results for float tests.

12:56 PM Changeset in webkit [18623] by hyatt

• 2 edits in trunk/WebCore

Back out fix for 12114. I missed rule #5 in the float positioning part of the CSS2.1 spec. Keep all
the code cleanup though.

Reviewed by mitz

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):

12:54 PM Changeset in webkit [18622] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2007-01-05 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: BrowserNG does not open hyperlinks with a space in the anchor.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12127

• ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):

11:33 AM Changeset in webkit [18621] by andersca

• 24 edits
  3 adds in trunk

WebCore:

Reviewed by Maciej.

Add a shared buffer class which is backed by either a vector or an NSData object. This object can also
be held in a custom NSData subclass. Use this in the loader wherever NSData was used.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• loader/CachedResource.h: (WebCore::CachedResource::allData):
• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
• loader/loader.cpp: (WebCore::Loader::didFinishLoading):
• loader/loader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::mainResourceData):
• loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setAllData):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
• platform/KURL.h:
• platform/SharedBuffer.cpp: Added. (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::clearPlatformData): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData):
• platform/SharedBuffer.h: Added.
• platform/mac/SharedBufferMac.mm: Added. (-[SharedBufferData dealloc]): (-[SharedBufferData finalize]): (-[SharedBufferData initWithSharedBuffer:WebCore::]): (-[SharedBufferData length]): (-[SharedBufferData bytes]): (WebCore::SharedBuffer::wrapNSData): (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData): (WebCore::SharedBuffer::platformDataSize): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::clearPlatformData):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):

WebKit:

Reviewed by Maciej.

The data returned is now a SharedBuffer so wrap it in an NSData object.

• WebView/WebDataSource.mm: (-[WebDataSource data]):

11:26 AM Changeset in webkit [18620] by ap

• 2 edits in trunk/LayoutTests

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

• http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Set the cookies unconditionally (previously, the test failed if there were other cookies for 127.0.0.1:8000.

11:02 AM Changeset in webkit [18619] by andersca

• 3 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12120
REGRESSION(r18605): Safari snippet editor no longer works

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Put back the code change in r18607.

• platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Convert nil NSURLs to null KURLs.

8:15 AM Changeset in webkit [18618] by ap

• 6 edits in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=7296
Disable JavaScript exceptions when dynamically changing CSS properties.

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): Removed the Dashboard quirk logic.

• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Don't raise an exception if parsing fails.

5:24 AM Changeset in webkit [18617] by zack

• 2 edits in trunk/WebKitTools

be smarter when detecting the display (hopefully fixes
running the layout tests with the buildbot)

1:00 AM Changeset in webkit [18616] by antti

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by hyatt.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12109
layer visibility incorrect in some cases

• fast/layers/layer-visibility-sublayer-expected.checksum: Added.
• fast/layers/layer-visibility-sublayer-expected.png: Added.
• fast/layers/layer-visibility-sublayer-expected.txt: Added.
• fast/layers/layer-visibility-sublayer.html: Added.

WebCore:

Reviewed by hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12109

Fix layer visibility in some cases with nested layers.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus):

12:43 AM Changeset in webkit [18615] by lars

• 7 edits in trunk

the daily checkin to get the Qt build compiling again :)

Jan 4, 2007:

11:44 PM Changeset in webkit [18614] by aroben

• 7 edits in trunk

WebCore:

Reviewed by Geoff, cheered by others.

Dead code elimination.

All layout tests pass.

• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:
• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Geoff, cheered by others.

Dead code elimination.

• WebView/WebHTMLView.m:

11:26 PM Changeset in webkit [18613] by aroben

• 2 edits in trunk/WebKit

Boo on me for undoing Beth's hard work.

• WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Undo a mistaken roll out of r18597.

11:21 PM Changeset in webkit [18612] by ddkilzer

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Brady.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12111 Uninitialized variable in -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]

• DefaultDelegates/WebDefaultPolicyDelegate.m: Initialize isDirectory.

10:36 PM Changeset in webkit [18611] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Speed up svn-create-patch for copied and moved files.

• Scripts/svn-create-patch: (manufacturePatchForAdditionWithHistory($$)): Use 'svn cat' instead of 'svn cat -rNNNNN' so svn pulls original from local disk.

10:28 PM Changeset in webkit [22730] by aroben

• 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fix: <rdar://4763580> Support tabbing between subframes
Fix: <rdar://4763595> Support tabbing out of the document back into the
Safari UI

• Interfaces/IWebUIDelegate.idl: Added declarations of new methods.
• WebBackForwardList.cpp: (WebBackForwardList::backItem): Changed to return E_FAIL if returning a null pointer. (WebBackForwardList::currentItem): Ditto. (WebBackForwardList::forwardItem): Ditto.
• WebChromeClient.cpp: (WebChromeClient::canTakeFocus): Added new click method. (WebChromeClient::takeFocus): Ditto. (WebChromeClient::focus): Removed unnecessary null check. (WebChromeClient::unfocus): Ditto. (WebChromeClient::createWindow): Ditto. (WebChromeClient::createModalDialog): Ditto. (WebChromeClient::show): Ditto. (WebChromeClient::canRunModal): Ditto. (WebChromeClient::runModal): Ditto. (WebChromeClient::setToolbarsVisible): Ditto. (WebChromeClient::toolbarsVisible): Ditto. (WebChromeClient::setStatusbarVisible): Ditto. (WebChromeClient::statusbarVisible): Ditto. (WebChromeClient::setMenubarVisible): Ditto. (WebChromeClient::menubarVisible): Ditto. (WebChromeClient::setResizable): Ditto. (WebChromeClient::addMessageToConsole): Ditto.
• WebChromeClient.h: Added declarations.

10:18 PM Changeset in webkit [18610] by aroben

• 36 edits
  14 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added new tests for tabindex and tabbing into/out of subframes.

• fast/dom/tabindex-clamp-expected.txt: Added.
• fast/dom/tabindex-clamp.html: Added.
• fast/events/frame-click-focus-expected.txt: Added.
• fast/events/frame-click-focus.html: Added.
• fast/events/frame-tab-focus-expected.txt: Added.
• fast/events/frame-tab-focus.html: Added.
• fast/events/resources/frame-tab-focus-child.html: Added.
• fast/events/resources/frame-tab-focus-empty-child.html: Added.
• fast/events/resources/frame-tab-focus-empty-middle.html: Added.
• fast/events/resources/frame-tab-focus-middle.html: Added.
• fast/events/resources/frame-tab-focus-upper.html: Added.
• fast/html/tab-order-expected.txt: Added.
• fast/html/tab-order.html: Added.

Updated test to match new behavior.

• fast/forms/focus2-expected.txt: Updated results.
• fast/forms/focus2.html: Fixed typo, and reduced the number of tab events dispatched now that frames containing focusable elements aren't themselves in the tab order.

WebCore:

Reviewed by Geoff.

Fix: <rdar://4800335> REGRESSION: shift-tabbing from location field
goes to first field rather than last (businessweek.com)

Fix: <rdar://4800373> REGRESSION: tabbing from last control focuses
nothing visible (busniessweek.com)

Handle tabbing into/out of subframes in WebCore instead of letting
AppKit do the dirty work. This change also fixes a number of bugs and
changes some behavior to match other browsers:

• No frames receive a focus event when the page is first loaded.
• When a frame is clicked or focused with the keyboard, it receives a focus event and all other frames receive a blur event.
• tabindex values are clamped to the range of a signed short, rather than overflowing within an unsigned short.
• tabindex is respected on frame owner elements, even though HTML4 says it shouldn't be.
• Subframes will be focused when tabbing if they don't contain any focusable elements within them (it would be nice to only focus the frame if it has scrollbars).

Renamed SelectionDirection to FocusDirection and put it in its own file.

• page/FocusDirection.h: Added. (WebCore::):
• page/mac/WebCoreFrameBridge.mm: Updated for renames. (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):

Moved advanceFocus from EventHandler to FocusController and added
support for moving into/out of subframes..

• page/EventHandler.cpp: Moved advanceFocus to FocusController.
• page/EventHandler.h: Ditto.
• page/FocusController.cpp: (WebCore::deepFocusableNode): Static helper function to find focusable nodes nested within frames. (WebCore::FocusController::advanceFocus): Moved from EventHandler and rewritten to handle subframes.
• page/FocusController.h: Added advanceFocus declaration.
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Updated for the move of advanceFocus to FocusController.
• html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::isFrameOwnerElement): New method. (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable): New virtual implementation used to trick Document::nextFocusableNode so that we can focus frames.

Rewrote/renamed
Document::nextFocusableNode/Document::previousFocusableNode.

• dom/Document.cpp: (WebCore::nextNodeWithExactTabIndex): New static helper function. (WebCore::previousNodeWithExactTabIndex): Ditto. (WebCore::nextNodeWithGreaterTabIndex): Ditto. (WebCore::previousNodeWithLowerTabIndex): Ditto. (WebCore::Document::nextFocusableNode): Renamed from nextFocusedNode, and rewritten with much simpler logic. (WebCore::Document::previousFocusableNode): Ditto.
• dom/Document.h: Updated declarations for renames.
• page/mac/EventHandlerMac.mm: Updated for rename of SelectionDirection to FocusDirection. (WebCore::EventHandler::nextKeyViewInFrame): Updated for renames. (WebCore::EventHandler::nextKeyViewInFrameHierarchy): Ditto. (WebCore::EventHandler::nextKeyView): Ditto. (WebCore::EventHandler::focusDocumentView): Added call to setFocusedFrame when focusing the document view. (WebCore::EventHandler::passMouseDownEventToWidget): Removed LOG_ERROR when a nil NSView is returned from AppKit, as this is a fairly common occurrence when a RenderWidget has a border. (WebCore::EventHandler::passWheelEventToWidget): Added a nil-check of the hit-tested NSView.

Changed storage of tabIndex to a signed short, and added clamping of
tabindex attribute values to match Firefox's behavior.

• dom/Node.h: Use a signed short to store m_tabIndex. (WebCore::Node::isFrameOwnerElement): New method. (WebCore::Node::tabIndex): Updated for signedness. (WebCore::Node::setTabIndex): Ditto.
• html/HTMLAnchorElement.cpp: Remove implementation of tabIndex() so that Node::tabIndex() will be called instead and return the clamped value (which matches Firefox's behavior).
• html/HTMLAnchorElement.h: Ditto.
• html/HTMLAreaElement.cpp: Ditto.
• html/HTMLAreaElement.h: Ditto.
• html/HTMLGenericFormElement.cpp: Ditto.
• html/HTMLGenericFormElement.h: Ditto.
• html/HTMLObjectElement.cpp: Ditto.
• html/HTMLObjectElement.h: Ditto.
• html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Clamp tabIndex to the range of a signed short to match Firefox.

Added two new Chrome methods for transferring focus out of the
WebView.

• page/Chrome.cpp: (WebCore::Chrome::canTakeFocus): (WebCore::Chrome::takeFocus):
• page/Chrome.h:
• page/ChromeClient.h:
• platform/graphics/svg/SVGImageEmptyClients.h: Fixed typo "CromeClient" -> "ChromeClient". (WebCore::SVGEmptyChromeClient::~SVGEmptyChromeClient): (WebCore::SVGEmptyChromeClient::canTakeFocus): (WebCore::SVGEmptyChromeClient::takeFocus):
• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Fixed typo.

Miscellaneous:

• WebCore.exp: Updated/sorted symbols.
• WebCore.xcodeproj/project.pbxproj: Made FocusController.h Private so WebKit can access it.

WebKit:

Reviewed by Geoff.

Remove WebKit/AppKit from handling tabbing between subframes.

• WebCoreSupport/WebChromeClient.h: Added new ChromeClient methods for moving focus out of the WebView.
• WebCoreSupport/WebChromeClient.mm: Ditto. (WebChromeClient::canTakeFocus): (WebChromeClient::takeFocus):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): Added null-check of m_frame.
• WebView/WebHTMLView.m: Removed -[WebHTMLView nextValidKeyView]. (-[WebHTMLView _updateActiveState]): Changed to focus the frame if WebCore believes it to be the focused frame. (-[WebHTMLView becomeFirstResponder]): Rewrote to call into FocusController to place focus correctly within the WebView.

9:58 PM Changeset in webkit [18609] by beidson

• 2 edits in trunk/WebCore

Reverted Anders' change to fix the world

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):

9:56 PM Changeset in webkit [18608] by ddkilzer

• 14 edits in trunk/WebCore

WebCore:

Reviewed by Sam Weinig.

• ​http://bugs.webkit.org/show_bug.cgi?id=12078 Clean up RenderTable*

• Coding style cleanup.
• Canceled AutoTableLayout and FixedTableLayout being friend classes of RenderTable. Instead, added public accessors to RenderTable for what the table layout classes need and changed TableLayout::calcMinMaxWidth() to take references to the caller's min and max widths.
• Made RenderTableSection's grid protected and moved code that accessed it from RenderTable into RenderTableSection.

No test possible (no change to functionality).

• rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::layout):
• rendering/AutoTableLayout.h:
• rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
• rendering/FixedTableLayout.h:
• rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::~RenderTable): (WebCore::RenderTable::setStyle): (WebCore::RenderTable::addChild): (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::setCellWidths): (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::calcMinMaxWidth): (WebCore::RenderTable::splitColumn): Factored out the section work to RenderTableSection::splitColumn(). (WebCore::RenderTable::appendColumn): Factored out the section work to RenderTableSection::appendColumn(). (WebCore::RenderTable::colElement): (WebCore::RenderTable::recalcSections): (WebCore::RenderTable::removeChildNode): (WebCore::RenderTable::calcBorderLeft): (WebCore::RenderTable::calcBorderRight): (WebCore::RenderTable::outerBorderTop): (WebCore::RenderTable::outerBorderBottom): (WebCore::RenderTable::outerBorderLeft): (WebCore::RenderTable::outerBorderRight): (WebCore::RenderTable::sectionAbove): (WebCore::RenderTable::sectionBelow): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::getOverflowClipRect): (WebCore::RenderTable::dump):
• rendering/RenderTable.h: (WebCore::RenderTable::getColumnPos): (WebCore::RenderTable::hBorderSpacing): (WebCore::RenderTable::vBorderSpacing): (WebCore::RenderTable::getRules): (WebCore::RenderTable::cellPadding): (WebCore::RenderTable::setCellPadding): (WebCore::RenderTable::ColumnStruct::ColumnStruct): (WebCore::RenderTable::columns): Added this accessor. (WebCore::RenderTable::columnPositions): Added this accessor. (WebCore::RenderTable::header): (WebCore::RenderTable::footer): (WebCore::RenderTable::firstBody): (WebCore::RenderTable::numEffCols): (WebCore::RenderTable::spanOfEffCol): (WebCore::RenderTable::colToEffCol): (WebCore::RenderTable::effColToCol): (WebCore::RenderTable::bordersPaddingAndSpacing): (WebCore::RenderTable::needsSectionRecalc): (WebCore::RenderTable::setNeedsSectionRecalc): Renamed setNeedSectionRecalc() to this. (WebCore::RenderTable::hasSections): (WebCore::RenderTable::recalcSectionsIfNeeded):
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::destroy): (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition): (WebCore::RenderTableCell::baselinePosition): (WebCore::RenderTableCell::setStyle): (WebCore::compareBorders): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::paint): (WebCore::collapsedBorderStyle): (WebCore::CollapsedBorder::CollapsedBorder): (WebCore::CollapsedBorders::CollapsedBorders): (WebCore::CollapsedBorders::addBorder): (WebCore::CollapsedBorders::nextBorder): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations): (WebCore::RenderTableCell::dump):
• rendering/RenderTableCell.h: (WebCore::RenderTableCell::colSpan): (WebCore::RenderTableCell::setColSpan): (WebCore::RenderTableCell::rowSpan): (WebCore::RenderTableCell::setRowSpan): (WebCore::RenderTableCell::col): (WebCore::RenderTableCell::setCol): (WebCore::RenderTableCell::row): (WebCore::RenderTableCell::setRow): (WebCore::RenderTableCell::section): (WebCore::RenderTableCell::table): (WebCore::RenderTableCell::yPos): (WebCore::RenderTableCell::setCellTopExtra): (WebCore::RenderTableCell::setCellBottomExtra): (WebCore::RenderTableCell::borderTopExtra): (WebCore::RenderTableCell::borderBottomExtra):
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::setStyle): (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::paint):
• rendering/RenderTableRow.h: (WebCore::RenderTableRow::section): (WebCore::RenderTableRow::table): (WebCore::RenderTableRow::lineHeight):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::setStyle): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::calcOuterBorderTop): (WebCore::RenderTableSection::calcOuterBorderBottom): (WebCore::RenderTableSection::calcOuterBorderLeft): (WebCore::RenderTableSection::calcOuterBorderRight): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::clearGrid): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): Added. Moved code from RenderTable::appendColumn() into here. (WebCore::RenderTableSection::splitColumn): Added. Moved code from RenderTable::splitColumn() into here. (WebCore::RenderTableSection::removeChildNode): (WebCore::RenderTableSection::dump):
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName): (WebCore::RenderTableSection::isTableSection): (WebCore::RenderTableSection::lineHeight): (WebCore::RenderTableSection::table): (WebCore::RenderTableSection::cellAt): (WebCore::RenderTableSection::numRows): (WebCore::RenderTableSection::recalcCellsIfNeeded): (WebCore::RenderTableSection::needsCellRecalc): (WebCore::RenderTableSection::setNeedsCellRecalc): (WebCore::RenderTableSection::getBaseline):
• rendering/TableLayout.h:

9:14 PM Changeset in webkit [18607] by andersca

• 2 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12120
REGRESSION(r18605): Safari snippet editor no longer works

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Fix logic so applewebdata: URLs no longer cause the underlying URL to be fetched .

7:34 PM Changeset in webkit [18606] by andersca

• 10 edits in trunk/WebCore

Reviewed by Adam.

Move all remaining instances of NSURLRequest over to ResourceRequest (well, pretty much all).

• loader/MainResourceLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoadingMainResource):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

6:46 PM Changeset in webkit [22729] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

6:40 PM Changeset in webkit [18605] by andersca

• 17 edits in trunk

WebCore:

Reviewed by Brady.

Move more NSURLRequests over to ResourceRequests.

• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/ResourceLoader.h: (WebCore::ResourceLoader::request):
• loader/SubresourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::cancelledError):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
• platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isNull):
• platform/network/ResourceRequest.h:

WebKit:

Reviewed by Brady.

FrameLoaderClient changed yet again.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest):

6:38 PM Changeset in webkit [18604] by sfalken

• 1 copy in tags/Safari-521.32.9b

New tag.

6:20 PM Changeset in webkit [18603] by beidson

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe

​http://bugs.webkit.org/show_bug.cgi?id=12119
Changing the behavior of HistoryItem::pageCache() this morning also necessitated
changing the behavior of HistoryItem::hasPageCache()

• history/HistoryItem.cpp: (WebCore::HistoryItem::hasPageCache): Add the same pendingRelease check pageCache() has

4:36 PM Changeset in webkit [18602] by bdash

• 4 edits
  4 adds in trunk

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12043 Another assertion failure in WebCore::RenderObject::drawBorder

Test: fast/borders/border-radius-huge-assert.html

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Fixed the check for border radii that do not fit in the given width or height to work with radii that sum up to more than MAX_INT.
• rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder): Ditto.

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=12043 Another assertion failure in WebCore::RenderObject::drawBorder

• fast/borders/border-radius-huge-assert-expected.checksum: Added.
• fast/borders/border-radius-huge-assert-expected.png: Added.
• fast/borders/border-radius-huge-assert-expected.txt: Added.
• fast/borders/border-radius-huge-assert.html: Added.

4:35 PM Changeset in webkit [18601] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items

• editing/pasteboard/4861080-expected.checksum: Added.
• editing/pasteboard/4861080-expected.png: Added.
• editing/pasteboard/4861080-expected.txt: Added.
• editing/pasteboard/4861080.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items

A rendering bug (4907469) creates unwanted space at the top of a
list item when its contents are wrapped in span. Dropping content
inside that space causes a crash because positionForCoordinates
fails there and the code that creates drag carets can't handle it.

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]): Added the that's inside click handling for the case where positionForCoordinates returns null. We should also fix positionForCoordinates but that's less important: now its only side effect is that a no-op drop is performed instead of a snap back when you drop the contents of one of these list items its own unwanted space.

4:14 PM Changeset in webkit [18600] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12118 REGRESSION
(Context menus): No context menu displayed when clicking outside a
short document

No test case added since we do not currently have a way to automate
context menus.

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): If the hit test does not find a node, use the document node.

4:04 PM Changeset in webkit [18599] by hyatt

• 1 edit in trunk/LayoutTests/fast/table/absolute-table-at-bottom-expected.txt

Fix table test for bold change. No idea why this changed by a pixel though.

3:59 PM Changeset in webkit [18598] by andersca

• 10 edits in trunk

WebCore:

Reviewed by Adam.

Convert NSURLRequest to ResourceRequest in a few places

• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willUseArchive):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):

WebKit:

Reviewed by Adam.

FrameLoaderClient changed again.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::willUseArchive):

3:22 PM Changeset in webkit [18597] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Adam.

No need to hit test twice.

• WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

3:13 PM Changeset in webkit [18596] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2007-01-04 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Submit button can not be pressed after unsuccessful login to gmail.com
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12113

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

2:58 PM Changeset in webkit [18595] by hyatt

• 4 adds in trunk/LayoutTests/fast/block/float

New layout test for bug 12114.

2:58 PM Changeset in webkit [18594] by hyatt

• 2 edits in trunk/WebCore

Bug 12114 fix, make sure left/right floats are allowed to go above
other floats of opposite alignment.

Reviewed by aroben

fast/block/float/independent-align-positioning.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):

2:56 PM Changeset in webkit [18593] by andersca

• 2 edits in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=12116
REGRESSION: ASSERTION FAILED: URL in +[WebDataProtocol _webIsDataProtocolURL:]

<rdar://problem/4908910>
REGRESSION: After switching to Bookmarks view, the browser window is completely empty (no bookmarks are displayed)

• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): Initialize m_isNull

1:57 PM Changeset in webkit [22728] by bdakin

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

A few changes needed to turn on WebCore context menus on the Mac.

• WebContextMenuClient.cpp: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same.
• WebContextMenuClient.h: Same.

1:47 PM Changeset in webkit [18592] by bdakin

• 13 edits in trunk

WebCore:

Reviewed by Adam.

Turn on WebCore context menus.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Turn on WebCore menus.
• page/ContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Above name change. (WebCore::ContextMenuController::contextMenuItemSelected): Use local variable.
• platform/ContextMenu.cpp: (WebCore::createAndAppendSpeechSubMenu): Fix silly mistake -- make "Stop speaking" actually stop speaking.
• platform/graphics/svg/SVGImageEmptyClients.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.

(WebCore::SVGEmptyContextMenuClient::getCustomMenuFromDefaultItems):

WebKit:

Reviewed by Adam.

Turn on WebCore context menus. Delete a bunch of WebKit context
menu code that is no longer needed.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed a lot of code from this class. This class only still needs to exist for PDF context menus, so we only need to deal with the menu items that might possibly be added to a PDF context menu. (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Same. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Same.
• WebCoreSupport/WebContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
• WebCoreSupport/WebContextMenuClient.mm: Same. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same. Also move in some code that used to be in _menuForElement.
• WebView/WebHTMLView.m: Deleted a bunch of un-used functions (-[WebHTMLView menuForEvent:]): Turn on menus, and append the Inspect Element item.
• WebView/WebHTMLViewPrivate.h: Deleted a bunch of un-used functions.
• WebView/WebView.mm: (-[WebView _menuForElement:defaultItems:]): Removed a lot of code from _menuForElement that now makes more sense elsewhere. Only PDF context menus use this function now. Hopefully we can just get rid of it soon, too.

1:27 PM Changeset in webkit [18591] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-02 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):

1:03 PM Changeset in webkit [18590] by hyatt

• 3 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update for synthetic bold change.

1:02 PM Changeset in webkit [18589] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2007-01-04 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):

12:59 PM Changeset in webkit [22727] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Always use 1.0 as the synthetic bold offset for now. Fixes bug 9534.

Reviewed by olliej

• platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit):

12:52 PM Changeset in webkit [18588] by beidson

• 5 edits in trunk/WebCore

Reviewed and landed by Brady

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12087 REGRESSION: Reproducible crash going back in Back/Forward history

Allow a PageCache that is pending release to be resurrected by its
HistoryItem instead of creating a new PageCache. This avoids the
the condition of having two PageCaches for the same HistoryItem, one
current and one pending release but not yet released, which was causing
this and other bugs before.

Replaced the vector of PageCaches pending release with a set of
HistoryItems that are pending release of their PageCache.

• history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setHasPageCache): Check for an existing PageCache pending release, and if found, resurrect it by canceling the release. (WebCore::HistoryItem::pageCache): Return 0 if the PageCache is pending release. (WebCore::itemsWithPendingPageCacheToRelease): Renamed pendingPageCacheToRelease to this. This method now returns a HashSet of HistoryItems that have scheduled their PageCaches for release. (WebCore::HistoryItem::releasePageCachesOrReschedule): Renamed releasePageCache to this. (WebCore::HistoryItem::releasePageCache): Added. Actually closes and releases the PageCache. (WebCore::HistoryItem::releaseAllPendingPageCaches): Rolled closeObjectsInPendingPageCaches into this method. (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::cancelRelease): Added.
• history/HistoryItem.h: Removed unused declaration of scheduleReleaseTimer()
• history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleasePageCachesOrReschedule):
• history/HistoryItemTimer.h:

12:50 PM Changeset in webkit [18587] by hyatt

• 2 edits in trunk/WebCore

Just make the synthetic bold offset always be 1.0. This fixes bug
9534, synthetic bold looks doubled.

Reviewed by olliej

• platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):

11:25 AM Changeset in webkit [18586] by andersca

• 26 edits in trunk

WebCore:

Reviewed by Brady.

Convert almost all occurrences of NSURLResponse to ResourceResponse.

• WebCore.exp:
• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/loader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::loadNow):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::response):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isHTTP):
• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isNull):
• platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):

WebKit:

Reviewed by Brady.

Update for WebCore changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::incrementProgress):

11:21 AM Changeset in webkit [18585] by adele

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4887422>
​http://bugs.webkit.org/show_bug.cgi?id=11848
REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

• fast/forms/searchfield-heights-expected.checksum: Added.
• fast/forms/searchfield-heights-expected.png: Added.
• fast/forms/searchfield-heights-expected.txt: Added.
• fast/forms/searchfield-heights.html: Added.

WebCore:

Reviewed by Darin.

• Fix for <rdar://problem/4887422> ​http://bugs.webkit.org/show_bug.cgi?id=11848 REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

Test: fast/forms/searchfield-heights.html

Override the border and the height for search fields that use -webkit-appearance: searchfield.

• css/html4.css: Use box-sizing: border-box for search fields. We don't need to have the border-box quirk that we use for the other text fields for this control.
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::searchFieldSizes): Added. (WebCore::RenderThemeMac::setSearchFieldSize): Added. (WebCore::RenderThemeMac::adjustSearchFieldStyle): Override the border and the height of the search field.

10:58 AM Changeset in webkit [18584] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12070 REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes

• kjs/DateMath.cpp: (KJS::getUTCOffset): Don't cache UTC offset.

10:42 AM Changeset in webkit [18583] by yongjzha

• 4 edits in S60/branches/3.1m/WebKit

2007-01-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
​http://bugs.webkit.org/show_bug.cgi?id=11787

• BrowserView/inc/HttpLoaderEventToUiListener.h:
• BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):

10:31 AM Changeset in webkit [18582] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-03 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjun Zhang.
DESC: fix for aol.co.uk crash (3.2)
​http://bugs.webkit.org/show_bug.cgi?id=12102

• BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):

6:09 AM Changeset in webkit [18581] by lars

• 2 edits in trunk/WebKitTools

compile DumpRenderTree with RPATH. Hopefully this will
fix the automatic regression tests.

6:08 AM Changeset in webkit [18580] by lars

• 2 edits in trunk/WebCore

Add some missing stubs

4:49 AM Changeset in webkit [18579] by ap

• 19 edits in trunk

2007-01-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11900:
Windows build bustage

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• platform/graphics/BitmapImage.h:
• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
• platform/graphics/Image.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon):
• platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawTiled):
• platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource):
• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::userIdleTime): (WebCore::BitmapImage::drawTiled): (WebCore::BitmapImage::getHBITMAP): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::urlForHistory): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::FrameLoader::load): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::applyUserAgent): (WebCore::GraphicsContext::strokeRect): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): (WebCore::PageCache::close): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu):

WebKit:

• COM/ChromeClientWin.cpp: (ChromeClientWin::addMessageToConsole): (ChromeClientWin::runBeforeUnloadConfirmPanel):
• COM/ChromeClientWin.h:
• COM/ContextMenuClientWin.cpp: (ContextMenuClientWin::contextMenuItemSelected):
• COM/ContextMenuClientWin.h:
• COM/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):
• COM/WebFrameLoaderClient.h:
• WebKit.vcproj/WebKit.vcproj:

3:38 AM Changeset in webkit [18578] by ap

• 2 edits in trunk/WebKitSite

2007-01-04 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11295
Nightly download size is misleading

• images/download.png: Changed the size to 6 MB.

3:23 AM Changeset in webkit [18577] by ap

• 7 edits
  3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11611
REGRESSION: No http referer header sent on XMLHttpRequest

Test: http/tests/xmlhttprequest/referer.html

• loader/FrameLoader.h: Removed FrameLoader::addExtraFieldsToRequest(NSMutableURLRequest*, bool, bool), which is no longer used.
• loader/mac/FrameLoaderMac.mm: Ditto.
• WebCore.exp: Do not export this method (WebKit doesn't use it).

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create): Rewrote to create the request with ResourceRequest::nsURLRequest.

• platform/PlatformString.h: (WebCore::operator!): Added. Previously, attempts to use operator! on a String would result with an NSString* conversion, which never returns nil. This was causing a problem in SubresourceLoader::create().

Jan 3, 2007:

11:48 PM Changeset in webkit [18576] by lars

• 2 edits in trunk/WebCore

fix the Qt build

10:36 PM Changeset in webkit [18575] by bdash

• 4 edits in trunk/LayoutTests

2007-01-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

• more updated results for ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

• css1/box_properties/acid_test-expected.checksum:
• css1/box_properties/acid_test-expected.png:
• css1/box_properties/acid_test-expected.txt:

9:28 PM Changeset in webkit [18574] by ddkilzer

• 37 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

• css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
• css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
• css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
• css2.1/t09-c5526c-display-00-e-expected.checksum:
• css2.1/t09-c5526c-display-00-e-expected.png:
• css2.1/t09-c5526c-display-00-e-expected.txt:
• fast/block/basic/011-expected.checksum:
• fast/block/basic/011-expected.png:
• fast/block/basic/011-expected.txt:
• fast/css/percentage-non-integer-expected.checksum: Added.
• fast/css/percentage-non-integer-expected.png: Added.
• fast/css/percentage-non-integer-expected.txt: Added.
• fast/css/percentage-non-integer.html: Added.
• tables/mozilla/bugs/bug4385-expected.checksum:
• tables/mozilla/bugs/bug4385-expected.png:
• tables/mozilla/bugs/bug4385-expected.txt:
• tables/mozilla_expected_failures/core/col_span2-expected.checksum:
• tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

Test: fast/css/percentage-non-integer.html

Added floating point constructor and accessors to Length for use with
Percent lengths only. The raw value of a percent length is the integer
part of a constant multiple of the original double value. The constant
is percentScaleFactor, which is currently 128.

Added assertions that the correct constructors and accessors are used
depending on the type: the double-based percent(), setValue() and Length()
for the Percent type, and the integer-based value(), setValue() and Length()
for all other types.

calcValue() and calcMinValue() work the same as before, regardless of the
type.

Added helpers for testing if the value is 0, positive, negative or undefined
without having to check the type first.

Added raw value accessors. These are useful for doing integer math and
comparisons with scaled percent values or doing Length type-agnostic math.

Changed the rest of the code to use the appropriate accessors and helpers.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
• platform/StringImpl.cpp: (WebCore::parseLength):
• rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
• rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
• rendering/Length.h: (WebCore::Length::Length): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
• rendering/RenderBR.cpp: (WebCore::RenderBR::lineHeight):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock):
• rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical):
• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
• rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
• rendering/RenderLayer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start):
• rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::lineHeight):
• rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Added FIXMEs.
• rendering/RenderStyle.h: (WebCore::LengthBox::nonZero): (WebCore::RenderStyle::initialLineHeight):
• rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):

9:25 PM Changeset in webkit [18573] by bdash

• 2 edits in tags/WebKit-521.32.1/WebKit

Versioning.

9:23 PM Changeset in webkit [18572] by ddkilzer

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11744 Setting the 'content' property dynamically has no effect

• fast/css/content-dynamic-expected.checksum: Added.
• fast/css/content-dynamic-expected.png: Added.
• fast/css/content-dynamic-expected.txt: Added.
• fast/css/content-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11744 Setting the 'content' property dynamically has no effect

Test: fast/css/content-dynamic.html

• dom/Node.cpp: (WebCore::Node::diff): Changed to return 'Detach' if the styles' content data are not equivalent.

9:19 PM Changeset in webkit [18571] by ddkilzer

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12082 REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

• fast/frames/negative-remaining-length-crash-expected.txt: Added.
• fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12082 REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

Test: fast/frames/negative-remaining-length-crash.html

• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength as zero.

6:17 PM Changeset in webkit [18570] by bdash

• 2 edits in trunk/WebKitTools

2007-01-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

• Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.

6:01 PM Changeset in webkit [18569] by sullivan

• 2 edits in trunk/WebCore

Written by Darin over my shoulder; reviewed by me

• fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused

• page/Frame.cpp: (WebCore::isInShadowTree): new helper function used by findString (WebCore::Frame::findString): when deciding whether to start from the selection, ignore selections that are in a shadow tree (i.e. in a form control)

5:21 PM Changeset in webkit [18568] by beidson

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12089

• loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader

5:20 PM Changeset in webkit [18567] by sullivan

• 2 edits in trunk/WebKit

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]

5:07 PM Changeset in webkit [18566] by hyatt

• 4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for inline generated content.

5:07 PM Changeset in webkit [18565] by hyatt

• 2 edits in trunk/WebCore

Relax the display type restriction a little bit for generated content inside
inlines. We still don't allow block display types like we should (since this
will cause a crash), but we at least handle inline-table and inline-block now.

Reviewed by beth

fast/css-generated-content/inline-display-types.html

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject):

5:05 PM Changeset in webkit [18564] by justing

• 4 edits in trunk

LayoutTests:

Reviewed by john

• editing/pasteboard/merge-end-blockquote-expected.txt: A recent change caused an acceptable change in these expected results.

WebCore:

Reviewed by john

<rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item

No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

• editing/mac/EditorMac.mm: (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to the highest editable root, instead of the lowest. Use firstEditablePosition... to look for an editable position.

4:57 PM Changeset in webkit [18563] by bdakin

• 2 edits in trunk/WebCore

Fixing silly mistake.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string function.

4:55 PM Changeset in webkit [18562] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the PDF in /tmp, both group and world-readable

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Make the file only readable by the current user

4:53 PM Changeset in webkit [18561] by beidson

• 2 edits in trunk/WebCore

Reviewed by Anders

​http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
I can't really think of a cleaner way to fix this then to help these SVG cases avoid
the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
and we find better ways to handle it...

• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the ASSERTing method

4:49 PM Changeset in webkit [22726] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

• removed some obsolete source files

• WebCore.vcproj/WebCore.vcproj: Removed obsolete files.

4:40 PM Changeset in webkit [18560] by darin

• 7 edits
  8 deletes in trunk/WebCore

Reviewed by Adele.

• removed some obsolete source files

• CMakeLists.txt: Removed obsolete files.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• WebCoreSources.bkl: Ditto.

• html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.

• platform/qt/ComboBoxQt.cpp: Removed.
• platform/qt/LineEditQt.cpp: Removed.
• platform/qt/ListBoxQt.cpp: Removed.
• platform/qt/TextEditQt.cpp: Removed.
• rendering/RenderFormElement.cpp: Removed.
• rendering/RenderFormElement.h: Removed.
• rendering/RenderLabel.cpp: Removed.
• rendering/RenderLabel.h: Removed.

4:27 PM Changeset in webkit [18559] by darin

• 4 edits
  5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for bug where :after content appeared in the wrong order

• fast/css-generated-content/after-order-expected.checksum: Added.
• fast/css-generated-content/after-order-expected.png: Added.
• fast/css-generated-content/after-order-expected.txt: Added.
• fast/css-generated-content/after-order.html: Added.
• fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

Reviewed by Hyatt.

• fix bug where :after content appears backwards

Test: fast/css-generated-content/after-order.html

• rendering/RenderBlock.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
• rendering/RenderInline.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderInline::addChildToFlow): Use isAfterContent.

4:15 PM Changeset in webkit [18558] by thatcher

• 5 edits in tags/WebKit-521.32.1/WebKit

Merging r18381 and r18388.

4:04 PM Changeset in webkit [18557] by hyatt

• 7 edits in trunk/WebCore

Implement box-shadow parsing... getting it all into the RenderStyle.

Reviewed by beth

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSPropertyNames.in:
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==): (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setBoxShadow):
• rendering/RenderStyle.h: (WebCore::RenderStyle::boxShadow):

3:48 PM Changeset in webkit [22725] by bdakin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Add stubs for all of the localized context menu item titles. The
stubs just return English Strings until we have a localization
solution in WebKit.

3:47 PM Changeset in webkit [18556] by thatcher

• 1 copy in tags/WebKit-521.32.1/WebKit

New tag (part 2).

3:46 PM Changeset in webkit [18555] by thatcher

• 1 add in tags/WebKit-521.32.1

New tag (part 1).

3:38 PM Changeset in webkit [18554] by bdakin

• 8 edits in trunk

WebCore:

Reviewed by John.

Call into WebKit to get localized strings for all of the context
menu item titles.

WebKit:

Reviewed by John.

Make localized strings for all of the context menu item titles that
are accessible to WebCore.

2:24 PM Changeset in webkit [22724] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4857027>
ragnarok online misrenders (due to lack of support for windowless plugins)

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Rename from updateHwnd since this now handles updating the clip rect for windowless plugins.

(WebCore::PluginViewWin::paintMissingPluginIcon):
New function which paints the missing plugin icon.

(WebCore::PluginViewWin::paint):
Do windowless painting here.

(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
(WebCore::PluginViewWin::handleEvent):
New functions for handling mouse and keyboard events, translating them and handing them to the plugin.

(WebCore::PluginViewWin::setNPWindowRect):
Set correct window rect for windowless plugins.

(WebCore::PluginViewWin::getValue):
Add variable for containing HWND.

(WebCore::PluginViewWin::setValue):
Add windowless and transparent variables.

(WebCore::PluginViewWin::invalidateRect):
(WebCore::PluginViewWin::invalidateRegion):
(WebCore::PluginViewWin::forceRedraw):
Implement these.

(WebCore::PluginViewWin::determineQuirks):
Set quirks now that we support windowless flash.

(WebCore::PluginViewWin::PluginViewWin):
Only create the window if the plugin isn't windowless.

• plugins/win/PluginViewWin.h: New declarations.

• plugins/win/npapi.cpp: (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): Implement these and forward them to the plugin view.

2:19 PM Changeset in webkit [18553] by beidson

• 3 edits in trunk/WebCore

Reviewed by Darin and Geoff

​http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
-Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
-Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree

• loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createHistoryItemTree): (WebCore::FrameLoader::updateHistoryForInternalLoad):
• loader/FrameLoader.h:

1:48 PM Changeset in webkit [18552] by andersca

• 4 edits in trunk/WebCore

Reviewed by Geoff.

Allow plugin elements to handle off events to their widgets.

• html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
• html/HTMLPlugInElement.h:
• platform/Widget.h: (WebCore::Widget::handleEvent):

12:56 PM Changeset in webkit [18551] by beidson

• 2 edits in trunk/WebKit

Reviewed by John Sullivan

In the Bookmarks View/History View, favicon may be the incorrect size

• History/WebHistoryItem.mm: (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved

11:35 AM Changeset in webkit [18550] by adele

• 2 edits in trunk/WebKit

Reviewed by Darin.

• Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)

• Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.

11:16 AM Changeset in webkit [18549] by ap

• 1 edit
  3 adds in trunk/LayoutTests

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

• http/tests/xmlhttprequest/cookies-expected.txt: Added.
• http/tests/xmlhttprequest/cookies.html: Added.
• http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Added.

10:38 AM Changeset in webkit [18548] by yongjzha

• 3 edits in S60/branches/3.1m/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Fix the issue with the SQL query associated with the checkin made for the following bug:
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::ReadLongTextL):

10:25 AM Changeset in webkit [18547] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-03 sareen <​shyam.sareen@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Vodafone Specific Storage test failing.
​http://bugs.webkit.org/show_bug.cgi?id=12101

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::VSSCacheContent):

10:17 AM Changeset in webkit [18546] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Put back the patches r18389, r18183 as well as fix the issue with the SQL query.
Patches r18389, r18183 fix the following two bugs:
TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::CFormDataAutoFillStore): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::~CFormDataAutoFillStore): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::ClearData): (CFormDataAutoFillStore::OpenDatabase): (CFormDataAutoFillStore::CloseDatabase): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):

4:04 AM Changeset in webkit [18545] by lars

• 10 edits
  2 adds in trunk

Fix the Qt build

12:31 AM Changeset in webkit [18544] by beidson

• 2 edits in trunk/WebKit

Controversially reviewed by Tim H. and Maciej

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12086, ​http://bugs.webkit.org/show_bug.cgi?id=12088,
possibly ​http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others

WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
by the Safari app. This bug never surfaced before because the WebBackForwardList had a retain on the
item, preventing deallocation. Since the items are now just temporary wrappers, the list
is no longer actually retaining them.

This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the
only solution for now... =/

We can possibly consider reverting this fix at a later date - that task is marked by
<rdar://problem/4905705>

• History/WebBackForwardList.mm: (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList itemAtIndex:]):

Jan 2, 2007:

10:59 PM Changeset in webkit [18543] by bdash

• 4 edits in tags/Safari-421.32

Versioning.

8:16 PM Changeset in webkit [18542] by bdakin

• 3 edits in trunk/WebKit

Reviewed by Geoff.

Remove un-used function.

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm:

7:28 PM Changeset in webkit [22723] by beidson

• 6 edits in branches/WindowsMerge

Temporary Link Stub fix after landing Back/Forward cache in OpenSource

7:11 PM Changeset in webkit [18541] by beidson

• 54 edits
  1 move
  13 adds
  2 deletes in trunk

WebCore:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:

• bridge/mac/WebCorePageState.h: Removed.
• bridge/mac/WebCorePageState.mm: Removed.

• history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::~BackForwardList): (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::goBack): (WebCore::BackForwardList::goForward): (WebCore::BackForwardList::goToItem): (WebCore::BackForwardList::backItem): (WebCore::BackForwardList::currentItem): (WebCore::BackForwardList::forwardItem): (WebCore::BackForwardList::backListWithLimit): (WebCore::BackForwardList::forwardListWithLimit): (WebCore::BackForwardList::capacity): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::pageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::usesPageCache): (WebCore::BackForwardList::backListCount): (WebCore::BackForwardList::forwardListCount): (WebCore::BackForwardList::itemAtIndex): (WebCore::BackForwardList::entries): (WebCore::BackForwardList::close): (WebCore::BackForwardList::closed): (WebCore::BackForwardList::removeItem): (WebCore::BackForwardList::containsItem): (WebCore::BackForwardList::setDefaultPageCacheSize): (WebCore::BackForwardList::defaultPageCacheSize):
• history/BackForwardList.h: Added.

• history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::copy): (WebCore::HistoryItem::setHasPageCache): (WebCore::HistoryItem::retainIconInDatabase): (WebCore::HistoryItem::urlString): (WebCore::HistoryItem::originalURLString): (WebCore::HistoryItem::title): (WebCore::HistoryItem::alternateTitle): (WebCore::HistoryItem::icon): (WebCore::HistoryItem::lastVisitedTime): (WebCore::HistoryItem::url): (WebCore::HistoryItem::originalURL): (WebCore::HistoryItem::target): (WebCore::HistoryItem::parent): (WebCore::HistoryItem::setAlternateTitle): (WebCore::HistoryItem::setURLString): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::setOriginalURLString): (WebCore::HistoryItem::setTitle): (WebCore::HistoryItem::setTarget): (WebCore::HistoryItem::setParent): (WebCore::HistoryItem::setLastVisitedTime): (WebCore::HistoryItem::visitCount): (WebCore::HistoryItem::setVisitCount): (WebCore::HistoryItem::scrollPoint): (WebCore::HistoryItem::setScrollPoint): (WebCore::HistoryItem::clearScrollPoint): (WebCore::HistoryItem::setDocumentState): (WebCore::HistoryItem::documentState): (WebCore::HistoryItem::clearDocumentState): (WebCore::HistoryItem::isTargetItem): (WebCore::HistoryItem::setIsTargetItem): (WebCore::HistoryItem::alwaysAttemptToUsePageCache): (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache): (WebCore::HistoryItem::addChildItem): (WebCore::HistoryItem::childItemWithName): (WebCore::HistoryItem::recurseToFindTargetItem): (WebCore::HistoryItem::targetItem): (WebCore::HistoryItem::pageCache): (WebCore::HistoryItem::children): (WebCore::HistoryItem::hasChildren): (WebCore::HistoryItem::formContentType): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest): (WebCore::HistoryItem::formData): (WebCore::HistoryItem::mergeAutoCompleteHints): (WebCore::HistoryItem::hasPageCache): (WebCore::timer): Function to manage the global release timer (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released (WebCore::HistoryItem::releasePageCache): (WebCore::closeObjectsInPendingPageCaches): (WebCore::HistoryItem::releaseAllPendingPageCaches): (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::print):
• history/HistoryItem.h: Added.
• history/mac/HistoryItemMac.mm: Added. (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state (WebCore::HistoryItem::setViewState): (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept (WebCore::HistoryItem::setTransientProperty):

• history/HistoryItemTimer.cpp: Added (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept (WebCore::HistoryItemTimer::isActive): (WebCore::HistoryItemTimer::schedule): (WebCore::HistoryItemTimer::invalidate): (WebCore::HistoryItemTimer::callReleasePageCache):
• history/HistoryItemTimer.h: Added.

• history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit (WebCore::PageCache::PageCache): (WebCore::PageCache::setPageState): (WebCore::PageCache::~PageCache): (WebCore::PageCache::pageState): (WebCore::PageCache::setDocumentLoader): (WebCore::PageCache::documentLoader): (WebCore::PageCache::setTimeStamp): (WebCore::PageCache::setTimeStampToNow): (WebCore::PageCache::timeStamp):
• history/PageCache.h: Added.
• history/mac/PageCacheMac.mm: Added. (WebCore::PageCache::close): (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView (WebCore::PageCache::documentView):

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::loadFromPageCache): (WebCore::DocumentLoader::setLoadingFromPageCache): (WebCore::DocumentLoader::isLoadingFromPageCache): (WebCore::DocumentLoader::originalURL): (WebCore::DocumentLoader::requestURL): (WebCore::DocumentLoader::responseURL): (WebCore::DocumentLoader::responseMIMEType):
• loader/DocumentLoader.h:

• loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame are now here, where they should be. (WebCore::FrameLoader::clear): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoader::dispatchDidFinishLoadToClient): (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now) (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto (WebCore::FrameLoader::shouldGoToHistoryItem): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromPageCache): (WebCore::FrameLoader::createPageCache): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createItemTree): (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoader::restoreScrollPositionAndViewState): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemPageCache): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::goToItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::childFramesMatchItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit): (WebCore::FrameLoader::saveDocumentAndScrollState): (WebCore::FrameLoader::currentHistoryItem): (WebCore::FrameLoader::previousHistoryItem): (WebCore::FrameLoader::provisionalHistoryItem): (WebCore::FrameLoader::setCurrentHistoryItem): (WebCore::FrameLoader::setPreviousHistoryItem): (WebCore::FrameLoader::setProvisionalHistoryItem):
• loader/FrameLoader.h:

• loader/FrameLoaderClient.h:

• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::urlForHistory):

• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

• page/FrameTree.cpp: (WebCore::FrameTree::removeChild):

• page/Page.cpp: Transfered a handful of concepts from WebView (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::backForwardList): (WebCore::Page::goBack): (WebCore::Page::goForward): (WebCore::Page::goToItem):
• page/Page.h:

• page/PageState.h:
• page/mac/FrameMac.h:
• page/mac/FrameMac.mm:
• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm:

• platform/KURL.cpp: (WebCore::KURL::print): Added debug only method for debugging convenience
• platform/KURL.h:

• platform/Logging.cpp: (WebCore::): Added some logging channels
• platform/Logging.h:

• platform/PlatformString.h: (WebCore::nsStringNilIfEmpty): Added for WebKit use

• platform/SystemTime.h: Added userIdleTime()

• platform/graphics/svg/SVGImage.cpp:
• platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem): (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache): (WebCore::SVGEmptyFrameLoaderClient::canCachePage): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):

• platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

• platform/mac/SystemTimeMac.cpp: (WebCore::userIdleTime):

• platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
• platform/mac/WebCoreSystemInterface.mm:

• platform/network/FormData.cpp: (WebCore::FormData::FormData): (WebCore::FormData::copy):
• platform/network/FormData.h:

• platform/network/ResourceHandle.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag

• platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime):
• rendering/RenderPart.h:

WebKit:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache
Most things not specifically commented on in the ChangeLog can be summed up as
"Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"

• History/WebBackForwardList.mm: (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList (core): (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart (kit): (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]): (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList _close]): (-[WebBackForwardList addItem:]): (-[WebBackForwardList removeItem:]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (vectorToNSArray): (-[WebBackForwardList backListWithLimit:]): (-[WebBackForwardList forwardListWithLimit:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList description]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList _usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
• History/WebBackForwardListInternal.h: Added.

• History/WebHistory.m: Removed.
• History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):

• History/WebHistoryItem.mm: (kitPrivate): Same pattern as WebBackForwardList (core): (historyItemWrappers): (WKNotifyHistoryItemChanged): (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem alternateTitle]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem hash]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (kit): (+[WebHistoryItem entryWithURL:]): (+[WebHistoryItem initWindowWatcherIfNecessary]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setVisitCount:]): (-[WebHistoryItem setViewState:]): (-[WebHistoryItem _mergeAutoCompleteHints:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem URL]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
• History/WebHistoryItemInternal.h:
• History/WebHistoryItemPrivate.h:

• WebCoreSupport/WebFrameBridge.mm:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

• WebKit.xcodeproj/project.pbxproj:

• WebView/WebDataSource.mm:
• WebView/WebDataSourceInternal.h:

• WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): (-[WebFrame _canCachePage]): (-[WebFrame _loadURL:referrer:intoChild:]):
• WebView/WebFrameInternal.h:

• WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): (-[WebFrameView keyDown:]):

• WebView/WebHTMLView.m: (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
• WebView/WebHTMLViewInternal.h:

• WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _close]): (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView backForwardList]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]):

5:05 PM Changeset in webkit [18540] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to open it in Preview while PDF was loading

• WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): added comment (-[WebPDFView validateUserInterfaceItem:]): disable this menu item when there's no document yet (-[WebPDFView _openWithFinder:]): If this is invoked when there is no document yet (e.g. via the PDFKit delegate method), just beep and return. I should make a nice error message here, but I'll do that separately.

4:48 PM Changeset in webkit [18539] by bdash

• 2 edits in tags/Safari-421.32/WebCore

Merge fix r18352.

4:45 PM Changeset in webkit [18538] by bdash

• 2 edits in tags/Safari-421.32/JavaScriptCore

Merge fix r18349.

4:41 PM Changeset in webkit [18537] by bdash

• 5 edits in tags/Safari-421.32/WebCore

Merge fix r18328 and r18386.

4:32 PM Changeset in webkit [18536] by zimmermann

• 2 edits in trunk/WebKit

Reviewed by Timothy.
Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).

4:23 PM Changeset in webkit [18535] by bdash

• 1 copy in tags/Safari-421.32

New tag.

3:40 PM Changeset in webkit [22722] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:34 PM Changeset in webkit [18534] by darin

• 7 edits in trunk/WebCore

Rubber stamped by Mitz.

Rename isRenderSVGContainer to isSVGContainer.

• platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
• rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
• rendering/RenderObject.h: (WebCore::RenderObject::isSVGContainer):
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::viewportTransform):
• rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::isSVGContainer):
• rendering/RenderTreeAsText.cpp: (WebCore::write):

3:31 PM Changeset in webkit [18533] by sfalken

• 1 copy in tags/Safari-521.32.8b

New tag.

3:22 PM Changeset in webkit [18532] by zimmermann

• 1 edit in trunk/WebCore/ChangeLog

Forgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer to isRenderSVGContainer)

3:20 PM Changeset in webkit [18531] by zimmermann

• 6 edits in trunk/WebCore

Reviewed by Mitz.
Rename isKCanvasContainer to isRenderSVGContainer.

3:18 PM Changeset in webkit [18530] by bdakin

• 4 edits in trunk

WebCore:

Reviewed by Darin.

Fix assertion failure with WebCore context menus by getting "Copy
Image" item added in.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Check if the image url is a local file or if we have an image in the cache.

WebKit:

Reviewed by Darin.

Fix bug with WebCore context menu item "Copy Image."

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyImageToClipboard): We must call declareTypes on the pasteboard.

11:31 AM Changeset in webkit [22721] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

10:58 AM Changeset in webkit [18529] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Anders.

Testcase for ​http://bugs.webkit.org/show_bug.cgi?id=12072

• fast/forms/select-align-expected.checksum: Added.
• fast/forms/select-align-expected.png: Added.
• fast/forms/select-align-expected.txt: Added.
• fast/forms/select-align.html: Added.

WebCore:

Reviewed by Anders.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12072
select with align attribute should not affect contained text

Don't map align for select elements.

Test: fast/forms/select-align.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):

10:04 AM Changeset in webkit [18528] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Testcase for ​http://bugs.webkit.org/show_bug.cgi?id=12071

• fast/forms/button-align-expected.checksum: Added.
• fast/forms/button-align-expected.png: Added.
• fast/forms/button-align-expected.txt: Added.
• fast/forms/button-align.html: Added.

WebCore:

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12071
button with align attribute should not affect contained text

Don't map align for button elements.

Test: fast/forms/button-align.html

• html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):

9:41 AM Changeset in webkit [18527] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=7075

• fast/forms/textarea-align-expected.checksum: Added.
• fast/forms/textarea-align-expected.png: Added.
• fast/forms/textarea-align-expected.txt: Added.
• fast/forms/textarea-align.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=7075
textarea with align=right should not cause contained text to
be right-justified

Don't map align for textarea elements.

Test: fast/forms/textarea-align.html

• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):

9:39 AM Changeset in webkit [18526] by darin

• 3 edits in trunk/JavaScriptCore

• minor tweak (hope this doesn't re-break Windows)

• pcre/pcre_compile.c: Removed use of const pcre_uchar const * -- Mitz probably meant const pcre_uchar *const, but I think we can do without the explicit const here.

• pcre/pcre_internal.h: Re-enabled warning C4114.

9:22 AM Changeset in webkit [18525] by ddkilzer

• 3 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by NOBODY (Windows build fix).

The MSVC compiler requires variables to be declared at the top of the enclosing block in C source.

Disable this warning to prevent MSVC from complaining about the 'const pcre_uchar const *' type:
warning C4114: same type qualifier used more than once

• pcre/pcre_compile.c: (pcre_compile2): Moved variable declarations to top of their respective enclosing blocks.
• pcre/pcre_internal.h: Added pragma to disable compiler warning.

9:08 AM Changeset in webkit [18524] by eseidel

• 4 edits in trunk/WebCore

2007-01-02 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Implement SVGSVGElement::deselectAll()

• ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
• ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll): implement (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
• ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment

6:12 AM Changeset in webkit [18523] by weinig

• 4 edits
  8 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=3360

• fast/forms/input-align-expected.checksum: Added.
• fast/forms/input-align-expected.png: Added.
• fast/forms/input-align-expected.txt: Added.
• fast/forms/input-align-image-expected.checksum: Added.
• fast/forms/input-align-image-expected.png: Added.
• fast/forms/input-align-image-expected.txt: Added.
• fast/forms/input-align-image.html: Added.
• fast/forms/input-align.html: Added.

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=3360
align="right" on a text input aligns the input field to the right

Don't map align if input type is not 'image'.

Test: fast/forms/input-align-image.html
Test: fast/forms/input-align.html

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::parseMappedAttribute):

5:46 AM Changeset in webkit [18522] by zimmermann

• 1 edit
  66 adds in trunk/LayoutTests

Rubber stamped by Rob.
Adding all carto.net SVG/JS examples. Highlights some nifty bugs.

4:09 AM Changeset in webkit [18521] by zimmermann

• 79 edits
  32 adds in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12013
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11980
Partly fixes: ​http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)

Rewrite gradient & pattern code, fixing all known bugs & regressions.

2:13 AM Changeset in webkit [18520] by zack

• 2 edits in trunk/WebCore

fix compile for svg as well (filenames are case-sensitive)

2:05 AM Changeset in webkit [18519] by zack

• 7 edits in trunk

compilation fixes for the Qt port

1:03 AM Changeset in webkit [18518] by eseidel

• 18 edits
  2 adds in trunk/WebCore

2007-01-02 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Refactor more animation code for better sharing between SVGAnimate*Element classes.

• replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
• move initialTransform() function down into SVGTimer (eventually to AnimationCompositor) Add non-functional (only parses) SVGAnimateMotionElement Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion) Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well. Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking change transformMatrix() to currentTransform() to match AffineTransform class name

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::baseValueTransformList): (WebCore::SVGTimer::applyAnimations):
• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateMotionElement.cpp: Added. (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): added. (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute (WebCore::SVGAnimateMotionElement::updateCurrentValue): (WebCore::SVGAnimateMotionElement::handleStartCondition): (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
• ksvg2/svg/SVGAnimateMotionElement.h: Added. (WebCore::SVGAnimateMotionElement::contextElement): (WebCore::SVGAnimateMotionElement::):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidTarget): added. (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::currentTransform):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::hasValidTarget): added. (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::isAdditive): (WebCore::SVGAnimationElement::isAccumulated): (WebCore::SVGAnimationElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): (WebCore::SVGAnimationElement::resetValues):
• ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::toPathData):
• ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): added. (WebCore::SVGPathSegList::toPathData): added.
• ksvg2/svg/SVGPathSegList.h:
• ksvg2/svg/svgtags.in: add animateMotion
• platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
• platform/graphics/PathTraversalState.cpp: (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
• platform/graphics/PathTraversalState.h: (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode

Jan 1, 2007:

9:13 PM Changeset in webkit [18517] by ddkilzer

• 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

Modified pcre_compile() (and the functions that it calls) to work with patterns
containing null characters.

Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

• kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
• pcre/pcre.h:
• pcre/pcre_compile.c: (check_escape): (get_ucp): (is_counted_repeat): (check_posix_syntax): (compile_branch): (compile_regex): (pcre_compile): Added a parameter specifying the length of the pattern, which is no longer required to be null-terminated and may contain null characters. (pcre_compile2):
• pcre/pcre_internal.h:
• tests/mozilla/expected.html: Updated for the two tests that this patch fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js which were not updated after bug 6257 was fixed.

WebCore:

Reviewed by Darin.

• WebCore changes for ​http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

• platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.

8:37 PM Changeset in webkit [18516] by ddkilzer

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

• fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
• fast/repaint/table-cell-collapsed-border-expected.png: Added.
• fast/repaint/table-cell-collapsed-border-expected.txt: Added.
• fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

Test: fast/repaint/table-cell-collapsed-border.html

• rendering/RenderTable.h: Added needsSectionRecalc() accessor.
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
• rendering/RenderTableCell.h:

8:27 PM Changeset in webkit [18515] by ddkilzer

• 4 edits in trunk/WebCore

WebCore:

WebCore.vcproj change reviewed by Darin. Additional build files updated by ddkilzer.

• CMakeLists.txt: Removed RenderLineEdit.cpp.
• WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
• WebCoreSources.bkl: Removed RenderLineEdit.cpp.

8:19 PM Changeset in webkit [18514] by ddkilzer

• 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12057 REGRESSION: JavaScript Date Is One Day In The Future in GMT time zone

Because Mac OS X returns geographically and historically accurate time zone information,
converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
in GMT (London - England) since it was in BST (+0100) all year in 1970[1]. Instead, the
UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
subtracting that from the same date in UTC.

[1] ​http://en.wikipedia.org/wiki/British_Summer_Time

• kjs/DateMath.cpp: (KJS::getUTCOffset): Updated UTC offset calculation. (KJS::getDSTOffset): Improved comment.

8:13 PM Changeset in webkit [18513] by ddkilzer

• 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12023
svn-create-patch and friends should handle moved/copied files

• Scripts/svn-apply: Identify copied files and handle those before all other patches.
• Scripts/svn-create-patch: Generate patches with subtle changes for copied files. (findMimeType($)): Added. (findModificationTime($)): Added. (findSourceFileAndRevision($)): Added. (generateDiff($$$)): Changed to use svn stat instead of svn diff. (isBinaryMimeType($)): Added. (manufacturePatchForAdditionWithHistory($$)): Added.
• Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.

6:27 PM Changeset in webkit [18512] by darin

• 2 edits in trunk/WebKitSite

• quality/bugzilla.html: Fix a lingering reference to opendarwin.org.

6:03 PM Changeset in webkit [18511] by ddkilzer

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

• fast/borders/outline-offset-min-assert-expected.checksum: Added.
• fast/borders/outline-offset-min-assert-expected.png: Added.
• fast/borders/outline-offset-min-assert-expected.txt: Added.
• fast/borders/outline-offset-min-assert.html: Added.

WebCore:

Reviewed by Mark Rowe.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

Test: fast/borders/outline-offset-min-assert.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): Bail out if the width or height is smaller than twice the outline inset.

5:42 PM Changeset in webkit [18510] by bdash

• 3 edits
  2 adds in trunk

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

• rendering/RenderStyle.cpp: (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent do not result in derefing deallocated members.

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

• fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
• fast/css-generated-content/reset-content-to-initial.html: Added.

12:48 PM Changeset in webkit [18509] by eseidel

• 10 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Begin pushing code down into SVGAnimateElement

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleStartCondition):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateCurrentValue): (WebCore::SVGAnimateElement::handleStartCondition): (WebCore::SVGAnimateElement::handleEndCondition):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleStartCondition):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateCurrentValue): (WebCore::SVGSetElement::handleStartCondition): (WebCore::SVGSetElement::handleEndCondition):
• ksvg2/svg/SVGSetElement.h:

11:40 AM Changeset in webkit [18508] by eseidel

• 4 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
• ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString (WebCore::parseNumberOrPercent): new color parsing helper (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
• ksvg2/svg/SVGColor.h:

10:58 AM Changeset in webkit [18507] by eseidel

• 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): (WebCore::SVGAnimateColorElement::resetValues): (WebCore::SVGAnimateColorElement::updateCurrentValue): (WebCore::SVGAnimateColorElement::startIfNecessary): (WebCore::SVGAnimateColorElement::handleEndCondition): (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::startIfNecessary): (WebCore::SVGAnimateTransformElement::handleEndCondition): (WebCore::SVGAnimateTransformElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.h:

10:56 AM Changeset in webkit [18506] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by Eric.

Simple cleanups, removing unused color table, copyright and include guard fixes.

10:20 AM Changeset in webkit [18505] by eseidel

• 1 edit in trunk/WebCore/ChangeLog

correct reviewer, was andersca not mitz

10:19 AM Changeset in webkit [18504] by eseidel

• 7 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More animation code cleanup.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::connectedToTimer): (WebCore::SVGAnimationElement::connectTimer): (WebCore::SVGAnimationElement::disconnectTimer): (WebCore::SVGAnimationElement::updateForElapsedSeconds):
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
• ksvg2/svg/SVGSetElement.h:

9:53 AM Changeset in webkit [18503] by eseidel

• 3 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More clean-up to animation code.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):

12:12 AM Changeset in webkit [18502] by eseidel

• 12 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.

• ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): add comment (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateElement.cpp:
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::calculateTimePercentage): logic moved from SVGTimer (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenate): fixed spacing

Dec 31, 2006:

10:47 PM Changeset in webkit [18501] by eseidel

• 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Split out animationsByElement() logic in preparation for adding AnimationCompositor class
Add addColorsAndClamp helper (since adding and clamping is the common case)

• ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): split out from notifyAll (WebCore::SVGTimer::notifyAll):
• ksvg2/misc/SVGTimer.h:
• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
• ksvg2/svg/SVGAnimateColorElement.h:

10:03 PM Changeset in webkit [18500] by eseidel

• 10 edits
  2 copies
  2 moves in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
(Basic clean-up before re-working animation system)

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
• ksvg2/misc/KSVGTimeScheduler.h: Removed.
• ksvg2/misc/SVGTimer.cpp: Added. (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll):
• ksvg2/misc/SVGTimer.h: Added.
• ksvg2/misc/TimeScheduler.cpp: Added. (WebCore::TimeScheduler::TimeScheduler):

9:15 PM Changeset in webkit [18499] by eseidel

• 2 edits in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Re-enable animateTransform (now that SVGList is fixed)
(Things are only "less broken" not totally fixed yet.)

• ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):

9:07 PM Changeset in webkit [18498] by ddkilzer

• 23 edits
  1 move
  1 delete in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Geoff.

Update embedded pcre library from version 6.2 to 6.4. Changes from pcre 6.2 to 6.3
did not include any files in JavaScriptCore/pcre.

All changes include renaming EXPORT to PCRE_EXPORT, renaming of ucp_findchar() to
_pcre_ucp_findchar(), or comment changes. Additional changes noted below.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated source file list.
• JavaScriptCore.xcodeproj/project.pbxproj: Renamed pcre_printint.c to pcre_printint.src and changed it from a source file to a header file.
• JavaScriptCoreSources.bkl: Updated source file list.
• pcre/CMakeLists.txt: Updated source file list.
• pcre/pcre-config.h:
• pcre/pcre.h: Updated version.
• pcre/pcre.pri: Updated source file list.
• pcre/pcre_compile.c: Include pcre_printint.src #if DEBUG. (pcre_compile2):
• pcre/pcre_config.c:
• pcre/pcre_exec.c: (match):
• pcre/pcre_fullinfo.c:
• pcre/pcre_info.c:
• pcre/pcre_internal.h: Added header guard. Removed export of _pcre_printint().
• pcre/pcre_ord2utf8.c:
• pcre/pcre_printint.c: Renamed to pcre_printint.src.
• pcre/pcre_printint.src: Added. Renamed _pcre_printint() to pcre_printint().
• pcre/pcre_refcount.c:
• pcre/pcre_study.c:
• pcre/pcre_tables.c:
• pcre/pcre_try_flipped.c:
• pcre/pcre_ucp_findchar.c: Added contents of ucp_findchar.c.
• pcre/pcre_version.c:
• pcre/pcre_xclass.c: (_pcre_xclass):
• pcre/ucp.h: Removed export of ucp_findchar().
• pcre/ucp_findchar.c: Removed. Contents moved to pcre_ucp_findchar.c.

4:49 PM Changeset in webkit [18497] by ddkilzer

• 2 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt.

• ​http://bugs.webkit.org/show_bug.cgi?id=12049 RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks

No test possible (no change to functionality).

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth() only if their result is needed.

4:37 PM Changeset in webkit [18496] by bdash

• 1 copy
  1 add in trunk/WebCore

Roll over WebCore ChangeLog

1:45 PM Changeset in webkit [18495] by eseidel

• 21 edits in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by weinig.

Make SVGPathSeg construction take fewer lines of code.

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
• ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
• ksvg2/svg/SVGPathSegArc.h:
• ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
• ksvg2/svg/SVGPathSegCurvetoCubic.h:
• ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
• ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
• ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
• ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
• ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
• ksvg2/svg/SVGPathSegLineto.h:
• ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
• ksvg2/svg/SVGPathSegLinetoHorizontal.h:
• ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
• ksvg2/svg/SVGPathSegLinetoVertical.h:
• ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
• ksvg2/svg/SVGPathSegMoveto.h:

12:38 PM Changeset in webkit [18494] by eseidel

• 3 edits
  2 deletes in trunk/LayoutTests

2006-12-31 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

Make getTotalLength test case work in Opera and FireFox.

• svg/custom/path-getTotalLength-expected.checksum: Removed.
• svg/custom/path-getTotalLength-expected.png: Removed.
• svg/custom/path-getTotalLength-expected.txt:
• svg/custom/path-getTotalLength.svg:

11:37 AM Changeset in webkit [18493] by eseidel

• 6 edits
  6 adds in trunk

2006-12-31 Eric Seidel <​eric@eseidel.com>

Reviewed by weinig.

Implement path length measuring for SVGPathElement::getTotalLength and friends.
​http://bugs.webkit.org/show_bug.cgi?id=12033

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
• platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::length): (WebCore::Path::pointAtLength):
• platform/graphics/Path.h:
• platform/graphics/PathTraversalState.cpp: Added. (WebCore::midPoint): (WebCore::distanceLine): (WebCore::QuadraticBezier::QuadraticBezier): (WebCore::QuadraticBezier::approximateDistance): (WebCore::QuadraticBezier::split): (WebCore::CubicBezier::CubicBezier): (WebCore::CubicBezier::approximateDistance): (WebCore::CubicBezier::split): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::closeSubpath): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::lineTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
• platform/graphics/PathTraversalState.h: Added. (WebCore::PathTraversalState::):

8:08 AM Changeset in webkit [18492] by weinig

• 5 edits in trunk/WebCore

Reviewed by Mitz.

Move the SVGZoomAndPanType enum out of SVGSVGElement and
SVGViewElement and into SVGZoomAndPan where it belongs.

• ksvg2/svg/SVGSVGElement.h:
• ksvg2/svg/SVGViewElement.h:
• ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::parseMappedAttribute):
• ksvg2/svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::):

6:25 AM Changeset in webkit [18491] by ddkilzer

• 4 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Tweaked by Mitz.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=9659 Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

• fast/overflow/clip-rects-fixed-ancestor-expected.checksum: Added.
• fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
• fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
• fast/overflow/clip-rects-fixed-ancestor.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=9659 Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

Added a 'fixed' flag to ClipRects, indicating that the cached rects are in
viewport coordinates. The flag is set (and scrolling is compensated for) for
fixed objects and their descendants.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
• rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::ClipRects::fixed):

6:00 AM Changeset in webkit [18490] by ddkilzer

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Sam.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12037 For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

• fast/block/positioning/relative-overconstrained-expected.checksum: Added.
• fast/block/positioning/relative-overconstrained-expected.png: Added.
• fast/block/positioning/relative-overconstrained-expected.txt: Added.
• fast/block/positioning/relative-overconstrained.html: Added.

WebCore:

Reviewed by Sam.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12037 For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

Test: fast/block/positioning/relative-overconstrained.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::relativePositionOffsetX):

Dec 30, 2006:

3:02 PM Changeset in webkit [18489] by rwlbuis

• 15 edits
  2 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12004
Webkit doesnt handle omitting M at the start of path syntax well

Improve path parsing error handling.

1:54 PM Changeset in webkit [18488] by rwlbuis

• 6 edits in trunk

Reviewed by Darin.

The marker is used for start, mid and end.

12:53 PM Changeset in webkit [18487] by rwlbuis

• 15 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12035
Use SVGParserUtilities in lists of values

Use SVGParserUtilities in some more places.

8:09 AM Changeset in webkit [18486] by rwlbuis

• 5 edits
  4 adds in trunk

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12034
Adapt preserveAspectRatio parsing to SVGParserUtilities

Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

2:12 AM Changeset in webkit [18485] by ap

• 3 edits in trunk/WebCore

2006-12-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

• remove unused member variables m_loadingSheet and m_bAllDataReceived

No test possible (no change to functionality).

• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setCSSStyleSheet):
• dom/Document.h:

12:34 AM Changeset in webkit [18484] by ap

• 3 edits
  2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11998
Incorrect serialization of quotation marks in XML attributes.

Test: fast/dom/serialize-attribute.xhtml

• editing/markup.cpp: (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark only needs to be encoded in attribute values. (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().

Dec 29, 2006:

7:03 PM Changeset in webkit [18483] by ddkilzer

• 4 edits in trunk/JavaScriptCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Geoff.

Update embedded pcre library from version 6.1 to 6.2. From the pcre ChangeLog:

3. Added "b" to the 2nd argument of fopen() in dftables.c, for non-Unix-like operating environments where this matters.

5. Named capturing subpatterns were not being correctly counted when a pattern was compiled. This caused two problems: (a) If there were more than 100 such subpatterns, the calculation of the memory needed for the whole compiled pattern went wrong, leading to an overflow error. (b) Numerical back references of the form \12, where the number was greater than 9, were not recognized as back references, even though there were sufficient previous subpatterns.

• pcre/dftables.c: Item 3. (main):
• pcre/pcre.h: Updated version.
• pcre/pcre_compile.c: Item 5. (read_repeat_counts): (pcre_compile2):

5:30 PM Changeset in webkit [18482] by ddkilzer

• 3 edits in trunk/WebCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Build fix for no-svg build.

Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

• bindings/js/kjs_css.cpp: (KJS::toJS):
• loader/CachedImage.cpp: (WebCore::CachedImage::createImage):

5:27 PM Changeset in webkit [22720] by ggaren

• 1 edit in branches/WindowsMerge/WebCore/bridge/win/FrameWin.cpp

build fix

5:24 PM Changeset in webkit [22719] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Build fix.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):

4:48 PM Changeset in webkit [18481] by ggaren

• 13 edits in trunk

JavaScriptCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

The key change here is to RootObject::RootObject().

• JavaScriptCore.exp:

• bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Changed to use new constructor.

• bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): Changed to use new constructor. Replaced large 'if' followed by default condition with "if !" and explicit default condition.

• bindings/objc/objc_runtime.mm: (convertValueToObjcObject): Changed to use new constructor.

• bindings/runtime_root.cpp: (KJS::Bindings::RootObject::destroy): "removeAllNativeReferences" => "destroy" because this function actually destroys the RootObject.

• bindings/runtime_root.h: Changed Interpreter* to RefPtr<Interpreter> to prevent a RootObject from holding a stale Interperter*.

(KJS::Bindings::RootObject::RootObject): Changed constructor to take an
Interpreter*, since it's pointless to create a RootObject without one.
Removed setRootObjectImp() and rootObjectImp() because they were just
a confusing way of setting and getting the Interpreter's global object.

(KJS::Bindings::RootObject::nativeHandle): "_nativeHandle" => "m_nativeHandle"
(KJS::Bindings::RootObject::interpreter): "_interpreter" => "m_interpreter"

WebCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

The key change here is to RootObject::RootObject().

Layout tests pass.

Renamed "_bindingRoot" => "_bindingRootObject" because "RootObject" is the
type name.

• bindings/objc/WebScriptObject.mm: (_didExecute): Use Interpreter::globalObject(), since RootObject::rootObjectImp() no longer exists.

• page/mac/FrameMac.mm: (WebCore::FrameMac::bindingRootObject): Use the new RootObject constructor. Stop lying about who deletes _bindingRoot.

(WebCore::FrameMac::cleanupPluginObjects): => "destroy". Fixed a bug where
the RootObject would only free its own memory if there were a ReferencesSet*
associated with it.

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rootObjectForView:]): Use new constructor. Changed misleading comment.

2:14 PM Changeset in webkit [18480] by rwlbuis

• 12 edits
  4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12007
SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

Refactor code so svg reuses cssparser methods. Also make
SVGColor and SVGPaint more efficient by avoiding using
setRGBColor internally.

12:59 PM Changeset in webkit [18479] by rwlbuis

• 2 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12022
typo in SVGTransformable.cpp introduce in r18440

Use the helper method proposed by Eric.

12:47 PM Changeset in webkit [18478] by rwlbuis

• 3 edits
  4 adds
  8 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12028
Adapt viewBox parsing to SVGParserUtilities

Use the new parseNumber and add tests for viewBox parsing.

12:00 PM Changeset in webkit [18477] by ggaren

• 2 edits in trunk/WebCore

Build fix: SVGImage only works on Mac.

• loader/CachedImage.cpp: (WebCore::CachedImage::createImage):

11:28 AM Changeset in webkit [18476] by weinig

• 17 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12018
Cleanup of CSSRule and its subclasses

• Make CSSRule::type() virtual instead of using a member variable.
• General style cleanup.

• WebCore.xcodeproj/project.pbxproj:
• css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
• css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
• css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule): (WebCore::CSSFontFaceRule::cssText):
• css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
• css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent):
• css/CSSImportRule.h: (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
• css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
• css/CSSMediaRule.h: (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
• css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText): (WebCore::CSSPageRule::setSelectorText): (WebCore::CSSPageRule::cssText):
• css/CSSPageRule.h: (WebCore::CSSPageRule::style): (WebCore::CSSPageRule::type):
• css/CSSRule.cpp: (WebCore::CSSRule::cssText): (WebCore::CSSRule::setCssText):
• css/CSSRule.h: (WebCore::CSSRule::): (WebCore::CSSRule::CSSRule):
• css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::setSelectorText): (WebCore::CSSStyleRule::cssText): (WebCore::CSSStyleRule::parseString):
• css/CSSStyleRule.h: (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::style): (WebCore::CSSStyleRule::type):
• css/CSSUnknownRule.h: (WebCore::CSSUnknownRule::CSSUnknownRule): (WebCore::CSSUnknownRule::type):

9:45 AM Changeset in webkit [18475] by eseidel

• 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): explicitly cast to integers to prevent compile error

6:47 AM Changeset in webkit [18474] by staikos

• 5 edits in trunk

Make the Qt port not crash on many sites such as www.apple.com: painter was closed too
early, and I think also there is a Qt bug that it complains about a painter being
around on a destroyed object that's really just a QShared reference going away. Worked
around.

3:17 AM Changeset in webkit [18473] by zimmermann

• 2 edits in trunk/WebCore

Build fixed, not reviewed. Noticed by Daniel Molkentin.

• platform/graphics/svg/SVGImage.h: s/WTF/wtf/ in include.

1:17 AM Changeset in webkit [18472] by eseidel

• 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyCromeClient::scaleFactor): build fix, use 1.f instead of 1f

12:36 AM Changeset in webkit [18471] by eseidel

• 3 edits
  9 adds in trunk/LayoutTests

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.

Add updated SVGImage results, forgotten in last commit.

• fast/images/svg-as-background-expected.checksum: Added.
• fast/images/svg-as-background-expected.png: Added.
• fast/images/svg-as-background-expected.txt: Added.
• fast/images/svg-as-image-expected.checksum: Added.
• fast/images/svg-as-image-expected.png: Added.
• fast/images/svg-as-image-expected.txt: Added.
• fast/images/svg-as-tiled-background-expected.checksum: Added.
• fast/images/svg-as-tiled-background-expected.png: Added.
• fast/images/svg-as-tiled-background-expected.txt: Added.
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:

12:27 AM Changeset in webkit [18470] by eseidel

• 10 edits
  9 adds in trunk

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

New tests:

• fast/images/svg-as-image.html
• fast/images/svg-as-background.html
• fast/images/svg-as-tiled-background.html

Implement basic SVGImage support.
​http://bugs.webkit.org/show_bug.cgi?id=5971

This implementation depends on (rather ugly) stub Page and Frame clients in SVGImageEmptyClients.h

• WebCore.xcodeproj/project.pbxproj: add SVGImage.*
• ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute): ignore fragment urls
• loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
• platform/graphics/Image.h: made setData virtual
• platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::drawTiled): stub method
• platform/graphics/cg/PDFDocumentImage.h:
• platform/graphics/svg/SVGImage.cpp: Added. (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::size): (WebCore::SVGImage::draw): (WebCore::SVGImage::drawTiled): stub method (WebCore::SVGImage::setData):
• platform/graphics/svg/SVGImage.h: Added. (WebCore::SVGImage::frameAtIndex):
• platform/graphics/svg/SVGImageEmptyClients.h: Added. (WebCore::SVGEmptyCromeClient::~SVGEmptyCromeClient): (WebCore::SVGEmptyCromeClient::chromeDestroyed): (WebCore::SVGEmptyCromeClient::setWindowRect): (WebCore::SVGEmptyCromeClient::windowRect): (WebCore::SVGEmptyCromeClient::pageRect): (WebCore::SVGEmptyCromeClient::scaleFactor): (WebCore::SVGEmptyCromeClient::focus): (WebCore::SVGEmptyCromeClient::unfocus): (WebCore::SVGEmptyCromeClient::createWindow): (WebCore::SVGEmptyCromeClient::createModalDialog): (WebCore::SVGEmptyCromeClient::show): (WebCore::SVGEmptyCromeClient::canRunModal): (WebCore::SVGEmptyCromeClient::runModal): (WebCore::SVGEmptyCromeClient::setToolbarsVisible): (WebCore::SVGEmptyCromeClient::toolbarsVisible): (WebCore::SVGEmptyCromeClient::setStatusbarVisible): (WebCore::SVGEmptyCromeClient::statusbarVisible): (WebCore::SVGEmptyCromeClient::setScrollbarsVisible): (WebCore::SVGEmptyCromeClient::scrollbarsVisible): (WebCore::SVGEmptyCromeClient::setMenubarVisible): (WebCore::SVGEmptyCromeClient::menubarVisible): (WebCore::SVGEmptyCromeClient::setResizable): (WebCore::SVGEmptyCromeClient::addMessageToConsole): (WebCore::SVGEmptyCromeClient::canRunBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::runBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::closeWindowSoon): (WebCore::SVGEmptyFrameLoaderClient::~SVGEmptyFrameLoaderClient): (WebCore::SVGEmptyFrameLoaderClient::frameLoaderDestroyed): (WebCore::SVGEmptyFrameLoaderClient::hasWebView): (WebCore::SVGEmptyFrameLoaderClient::hasFrameView): (WebCore::SVGEmptyFrameLoaderClient::hasBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::resetBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::provisionalItemIsTarget): (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemPageCache): (WebCore::SVGEmptyFrameLoaderClient::privateBrowsingEnabled): (WebCore::SVGEmptyFrameLoaderClient::makeDocumentView): (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::forceLayout): (WebCore::SVGEmptyFrameLoaderClient::forceLayoutForNonHTML): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForCommit): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForInternalLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryAfterClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::setCopiesOnScroll): (WebCore::SVGEmptyFrameLoaderClient::tokenForLoadErrorReset): (WebCore::SVGEmptyFrameLoaderClient::resetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::doNotResetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent1): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent2): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent3): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent4): (WebCore::SVGEmptyFrameLoaderClient::loadedFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillPerformClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillClose): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveIcon): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveTitle): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFirstLayout): (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage): (WebCore::SVGEmptyFrameLoaderClient::dispatchShow): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebCore::SVGEmptyFrameLoaderClient::cancelPolicyCheck): (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSubmitForm): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadMainResource): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState): (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::clearUnarchivingState): (WebCore::SVGEmptyFrameLoaderClient::progressStarted): (WebCore::SVGEmptyFrameLoaderClient::progressCompleted): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress): (WebCore::SVGEmptyFrameLoaderClient::setMainFrameDocumentReady): (WebCore::SVGEmptyFrameLoaderClient::startDownload): (WebCore::SVGEmptyFrameLoaderClient::willChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::didChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::committedLoad): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading): (WebCore::SVGEmptyFrameLoaderClient::finalSetupForReplace): (WebCore::SVGEmptyFrameLoaderClient::cancelledError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowURLError): (WebCore::SVGEmptyFrameLoaderClient::interruptForPolicyChangeError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowMIMETypeError): (WebCore::SVGEmptyFrameLoaderClient::fileDoesNotExistError): (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack): (WebCore::SVGEmptyFrameLoaderClient::setDefersLoading): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive): (WebCore::SVGEmptyFrameLoaderClient::isArchiveLoadPending): (WebCore::SVGEmptyFrameLoaderClient::cancelPendingArchiveLoad): (WebCore::SVGEmptyFrameLoaderClient::clearArchivedResources): (WebCore::SVGEmptyFrameLoaderClient::canHandleRequest): (WebCore::SVGEmptyFrameLoaderClient::canShowMIMEType): (WebCore::SVGEmptyFrameLoaderClient::representationExistsForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::generatedMIMETypeForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::frameLoadCompleted): (WebCore::SVGEmptyFrameLoaderClient::restoreScrollPositionAndViewState): (WebCore::SVGEmptyFrameLoaderClient::provisionalLoadStarted): (WebCore::SVGEmptyFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebCore::SVGEmptyFrameLoaderClient::addHistoryItemForFragmentScroll): (WebCore::SVGEmptyFrameLoaderClient::didFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::prepareForDataSourceReplacement): (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader): (WebCore::SVGEmptyFrameLoaderClient::setTitle): (WebCore::SVGEmptyFrameLoaderClient::userAgent): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient): (WebCore::SVGEmptyEditorClient::pageDestroyed): (WebCore::SVGEmptyEditorClient::shouldDeleteRange): (WebCore::SVGEmptyEditorClient::shouldShowDeleteInterface): (WebCore::SVGEmptyEditorClient::smartInsertDeleteEnabled): (WebCore::SVGEmptyEditorClient::isContinuousSpellCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleContinuousSpellChecking): (WebCore::SVGEmptyEditorClient::isGrammarCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleGrammarChecking): (WebCore::SVGEmptyEditorClient::spellCheckerDocumentTag): (WebCore::SVGEmptyEditorClient::selectWordBeforeMenuEvent): (WebCore::SVGEmptyEditorClient::isEditable): (WebCore::SVGEmptyEditorClient::shouldBeginEditing): (WebCore::SVGEmptyEditorClient::shouldEndEditing): (WebCore::SVGEmptyEditorClient::shouldInsertNode): (WebCore::SVGEmptyEditorClient::shouldInsertText): (WebCore::SVGEmptyEditorClient::shouldApplyStyle): (WebCore::SVGEmptyEditorClient::didBeginEditing): (WebCore::SVGEmptyEditorClient::respondToChangedContents): (WebCore::SVGEmptyEditorClient::didEndEditing): (WebCore::SVGEmptyEditorClient::registerCommandForUndo): (WebCore::SVGEmptyEditorClient::registerCommandForRedo): (WebCore::SVGEmptyEditorClient::clearUndoRedoOperations): (WebCore::SVGEmptyEditorClient::canUndo): (WebCore::SVGEmptyEditorClient::canRedo): (WebCore::SVGEmptyEditorClient::undo): (WebCore::SVGEmptyEditorClient::redo): (WebCore::SVGEmptyEditorClient::dataForArchivedSelection): (WebCore::SVGEmptyEditorClient::userVisibleString): (WebCore::SVGEmptyContextMenuClient::~SVGEmptyContextMenuClient): (WebCore::SVGEmptyContextMenuClient::contextMenuDestroyed): (WebCore::SVGEmptyContextMenuClient::addCustomContextMenuItems): (WebCore::SVGEmptyContextMenuClient::contextMenuItemSelected): (WebCore::SVGEmptyContextMenuClient::downloadURL): (WebCore::SVGEmptyContextMenuClient::copyImageToClipboard): (WebCore::SVGEmptyContextMenuClient::lookUpInDictionary): (WebCore::SVGEmptyContextMenuClient::speak): (WebCore::SVGEmptyContextMenuClient::stopSpeaking): (WebCore::SVGEmptyContextMenuClient::searchWithSpotlight):

12:27 AM Changeset in webkit [18469] by eseidel

• 2 edits in trunk/WebKitTools

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.

Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage

• DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): clear WebCore cache before exiting

12:15 AM Changeset in webkit [18468] by ddkilzer

• 3 edits
  1 delete in trunk

LayoutTests:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

• webarchive/resources/apple.gif: Removed.
• webarchive/resources/dump-webarchive.js: Removed.
• webarchive/resources/test-frame.html: Removed.
• webarchive/resources/test-style.css: Removed.
• webarchive/test-body-background-expected.txt: Removed.
• webarchive/test-body-background.html: Removed.
• webarchive/test-duplicate-resources-expected.txt: Removed.
• webarchive/test-duplicate-resources.html: Removed.
• webarchive/test-frameset-expected.txt: Removed.
• webarchive/test-frameset.html: Removed.
• webarchive/test-img-src-expected.txt: Removed.
• webarchive/test-img-src.html: Removed.
• webarchive/test-input-src-expected.txt: Removed.
• webarchive/test-input-src.html: Removed.
• webarchive/test-link-href-expected.txt: Removed.
• webarchive/test-link-href.html: Removed.
• webarchive/test-object-data-expected.txt: Removed.
• webarchive/test-object-data.html: Removed.
• webarchive/test-script-src-expected.txt: Removed.
• webarchive/test-script-src.html: Removed.
• webarchive/test-table-background-expected.txt: Removed.
• webarchive/test-table-background.html: Removed.
• webarchive/test-td-background-expected.txt: Removed.
• webarchive/test-td-background.html: Removed.

WebKitTools:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

• DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Removed. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Removed. (runTest):

Dec 28, 2006:

9:50 PM Changeset in webkit [18467] by staikos

• 2 edits in trunk/WebCore

Make redirects work.

8:38 PM Changeset in webkit [18466] by ddkilzer

• 3 edits
  1 copy
  25 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Created webarchive tests that exercise various features of the WebArchive format.

• webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
• webarchive/resources/dump-webarchive.js: Added.
• webarchive/resources/test-frame.html: Added.
• webarchive/resources/test-style.css: Added.
• webarchive/test-body-background-expected.txt: Added.
• webarchive/test-body-background.html: Added.
• webarchive/test-duplicate-resources-expected.txt: Added.
• webarchive/test-duplicate-resources.html: Added.
• webarchive/test-frameset-expected.txt: Added.
• webarchive/test-frameset.html: Added.
• webarchive/test-img-src-expected.txt: Added.
• webarchive/test-img-src.html: Added.
• webarchive/test-input-src-expected.txt: Added.
• webarchive/test-input-src.html: Added.
• webarchive/test-link-href-expected.txt: Added.
• webarchive/test-link-href.html: Added.
• webarchive/test-object-data-expected.txt: Added.
• webarchive/test-object-data.html: Added.
• webarchive/test-script-src-expected.txt: Added.
• webarchive/test-script-src.html: Added.
• webarchive/test-table-background-expected.txt: Added.
• webarchive/test-table-background.html: Added.
• webarchive/test-td-background-expected.txt: Added.
• webarchive/test-td-background.html: Added.

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Saves WebArchive plist in xml format, then alters ​file:// URLs to remove path
where WebKit was checked out.

• DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Added. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Added. (runTest):

7:36 PM Changeset in webkit [18465] by staikos

• 6 edits in trunk

Fix the Qt build. Reviewed by Olliej.

7:09 PM Changeset in webkit [18464] by ggaren

• 4 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

More cleanup. Layout tests pass.

Use a helper function to initialize and access WebUndefined and WebScriptObject.

• bindings/objc/objc_runtime.h:
• bindings/objc/objc_runtime.mm: (KJS::Bindings::webScriptObjectClass): (KJS::Bindings::webUndefinedClass): (convertValueToObjcObject):
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):

5:57 PM Changeset in webkit [18463] by eseidel

• 13 edits in trunk/WebCore

2006-12-28 Daniel Molkentin <​molkentin@kde.org>

Reviewed by Eric Seidel <​eric@webkit.org>

• Fix font sizes
• Make Qt plattform build again:
  • Adjust Qt platform to the Image class split.
  • Introduce BitmapImage class
  • add stub PDFDocumentImage class

• WebCore.pro:
• editing/qt/EditorQt.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::partClearedInBegin):
• platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawTiled): (WebCore::BitmapImage::checkForSolidColor):
• platform/graphics/svg/SVGPaintServerLinearGradient.h:
• platform/graphics/svg/SVGPaintServerRadialGradient.h:
• platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp: (WebCore::SVGPaintServerLinearGradient::setup):
• platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp: (WebCore::SVGPaintServerPattern::setup):
• platform/graphics/svg/qt/SVGPaintServerQt.cpp: (WebCore::SVGPaintServer::teardown):
• platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp: (WebCore::SVGPaintServerRadialGradient::setup):
• platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp: (WebCore::SVGPaintServerSolid::setup):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::bindingRootObject):

5:48 PM Changeset in webkit [18462] by ggaren

• 1 edit
  2 moves in trunk/LayoutTests

Reviewed by Eric Seidel.

Disable MS-font dependent tests until ​http://bugs.webkit.org/show_bug.cgi?id=11662 is fixed.

• svg/W3C-SVG-1.1/text-align-08-b.svg: Removed.
• svg/custom/js-font-test.svg: Removed.

5:44 PM Changeset in webkit [18461] by ggaren

• 35 edits in trunk

JavaScriptCore:

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

I'm just trying to make heads or tails of this baffling code.

Renamed "root" | "execContext" | "executionContext" => "rootObject", because
that's the object's (admittedly vague) type name.

• bindings/runtime.cpp: Removed createLanguageInstanceForValue because I'll give you a dollar if you can explain to me what it actually did.

• bindings/runtime_root.cpp: Put everything in the KJS::Bindings namespace, removing the KJS::Bindings prefix from individual functions and datatypes. This matches the header and eliminates a lot of syntax cruft.

• bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Replaced use of createLanguageInstanceForValue with call to _NPN_CreateScriptObject because that's what createLanguageInstanceForValue actually did (but don't ask me for that dollar now; that's cheating.)

• bindings/objc/objc_utility.h:
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): Removed. Its only purpose was to call a single function for WebKit, which WebKit can do on its own.

• kjs/interpreter.h: Removed rtti() because it was unused, and this class is scheduled for demolition anyway.

• kjs/interpreter.cpp: Removed createLanguageInstanceForValue because it had nothing to do with the Interpreter, and nothing makes Chuck Norris more mad than a function whose sole purpose is to call another function of the same name. (Really, I asked him.)

WebCore:

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

Layout tests pass.

Renamed "root" | "execContext" | "executionContext" => rootObject, because
that's the object's (admittedly vague) type name.

• bindings/js/kjs_binding.cpp:
• bindings/js/kjs_binding.h: Removed createLanguageInstanceForValue and createObjcInstanceForValue because their only purpose was to confuse you.

• bindings/objc/DOMInternal.h: Moved declaration of createDOMWrapper here. createDOMWrapper is the new name for createObjcInstanceForValue.

• bindings/objc/DOMInternal.mm: Renamed Interpreter::createObjcInstanceForValue to createDOMWrapper because creating DOM wrappers has nothing to do with the interpreter, and everything to do with the DOM. Renamed value to object because it is one. Removed newObj nil check that is unnecessary in ObjC.

• bindings/objc/WebScriptObject.mm: Replaced call to createLanguageInstanceForValue with explicit code to do the same thing it would have done: (1) try to create a DOM wrapper; (2) if the object is not a wrappable DOM object, create a vanilla WebScriptObject for it instead.

3:33 PM Changeset in webkit [18460] by ddkilzer

• 3 edits in trunk/WebCore

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11729 REGRESSION: Crash closing page with frames after selection

• loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Added call to pageDestroyed().
• page/FrameTree.cpp: (WebCore::FrameTree::appendChild): Added an assertion that the parent and the child are in the same page. (WebCore::FrameTree::removeChild): Added calls to decrementFrameCount() and pageDestroyed().

2:53 PM Changeset in webkit [18459] by ddkilzer

• 3 edits in trunk/WebCore

2006-12-28 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12016 REGRESSION: fast/text/stroking-decorations.html test fails with bus error in no-svg build

No test cases (no change in functionality).

• platform/TextStream.cpp: Properly initialize presicionFormats.
• rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): HTML tests now print out the stroke width, which is a float, so the precision needs to be set.

1:39 PM Changeset in webkit [18458] by eseidel

• 2 edits in trunk/WebCore

2006-12-28 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Fix for memory smasher when drawing markers.
​http://bugs.webkit.org/show_bug.cgi?id=12015

No test case possible (crashes for some folks but not others, not even under --guard)

• platform/graphics/cg/PathCG.cpp: (WebCore::CGPathApplierToPathApplier): array was too small

11:53 AM Changeset in webkit [18457] by weinig

• 4 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=11124 REGRESSION (r14297): No drag image for partially-selected complex text

• fast/text/atsui-partial-selection-expected.checksum: Added.
• fast/text/atsui-partial-selection-expected.png: Added.
• fast/text/atsui-partial-selection-expected.txt: Added.
• fast/text/atsui-partial-selection.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11124 REGRESSION (r14297): No drag image for partially-selected complex text

Test: fast/text/atsui-partial-selection.html

• platform/Font.h: Changed comment.
• platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected the run length calculation. Changed the ATSUI layout parameters to know about the entire text run, rather than just the range we are drawing. ATSUI measures the characters before the range and positions the range accordingly.

11:28 AM Changeset in webkit [18456] by weinig

• 16 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

Based on a test by Joost de Valk.

• test and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=9202 CSS3: border-radius not completely implemented, testcase hangs webkit

• fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
• fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
• fast/borders/borderRadiusAllStylesAllCorners-expected.txt: Added.
• fast/borders/borderRadiusAllStylesAllCorners.html: Added.
• fast/borders/borderRadiusArcs01-expected.checksum:
• fast/borders/borderRadiusArcs01-expected.png:
• fast/borders/borderRadiusGroove01-expected.checksum:
• fast/borders/borderRadiusGroove01-expected.png:
• fast/borders/borderRadiusGroove02-expected.checksum:
• fast/borders/borderRadiusGroove02-expected.png:
• fast/borders/borderRadiusInset01-expected.checksum:
• fast/borders/borderRadiusInset01-expected.png:
• fast/borders/borderRadiusInvalidColor-expected.checksum:
• fast/borders/borderRadiusOutset01-expected.checksum:
• fast/borders/borderRadiusOutset01-expected.png:
• fast/borders/borderRadiusRidge01-expected.checksum:
• fast/borders/borderRadiusRidge01-expected.png:

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=9202 CSS3: border-radius not completely implemented, testcase hangs webkit

Test: fast/borders/borderRadiusAllStylesAllCorners.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder): Changed to not draw "arcs" at straight corners and to paint half-corners only where the styles mismatch. Corrected the condition for matching styles: ridge, groove, inset and outset all mismatch in the upper right and lower left corners and match in the other two. The incorrect condition for a match was (almost) unnoticeable because of the painting of both half-corners on each side that had at least one mismatch.

11:15 AM Changeset in webkit [18455] by ap

• 4 edits
  4 deletes in trunk

Reverting the previous checkin, as it caused an assertion in layout tests.

10:29 AM Changeset in webkit [18454] by ap

• 4 edits
  4 adds in trunk

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

Test: fast/repaint/table-cell-collapsed-border.html

• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
• rendering/RenderTableCell.h:

10:17 AM Changeset in webkit [18453] by ap

• 3 edits
  4 adds in trunk

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11671 REGRESSION (r13702): text-transform: capitalize changes non-breaking spaces to spaces

Test: fast/text/capitalize-preserve-nbsp.html

• platform/StringImpl.cpp: (WebCore::StringImpl::capitalize): Copy back non-breaking spaces from the original string to the capitalized string. Change a 'previous' non-breaking space into a space (this improves the fix for <rdar://problem/4502311> from r13702).

8:09 AM Changeset in webkit [18452] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=10699 div with border-radius does not redraw properly if element inside div is resized

• fast/repaint/border-radius-repaint-expected.checksum: Added.
• fast/repaint/border-radius-repaint-expected.png: Added.
• fast/repaint/border-radius-repaint-expected.txt: Added.
• fast/repaint/border-radius-repaint.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=10699 div with border-radius does not redraw properly if element inside div is resized

Test: fast/repaint/border-radius-repaint.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

1:13 AM Changeset in webkit [18451] by darin

• 2 edits in trunk/WebCore

• loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Fixed an #ifdef PLATFORM(CG) that should be #if PLATFORM(CG). Might have broken the build on some platforms.

12:51 AM Changeset in webkit [18450] by rwlbuis

• 2 edits in trunk/LayoutTests

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12011
svg/custom/dynamic-svg-document-creation.svg is failing

Correct the transform syntax errors (since the new transform
parser is more strict).

Dec 27, 2006:

7:54 PM Changeset in webkit [18449] by ggaren

• 2 edits in trunk/WebCore

Build fix, plus a few "double &" => "double&" changes.

• ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber): (WebCore::SVGPathParser::calculateArc):

7:22 PM Changeset in webkit [18448] by eseidel

• 1 edit
  4 moves in trunk/LayoutTests

2006-12-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ggaren.

Disable MS-font dependent tests until ​http://bugs.webkit.org/show_bug.cgi?id=11662 is fixed.

• svg/W3C-SVG-1.1/text-intro-01-t.svg: Removed.
• svg/W3C-SVG-1.1/text-intro-02-b.svg: Removed.
• svg/W3C-SVG-1.1/text-intro-03-b.svg: Removed.
• svg/W3C-SVG-1.1/text-intro-04-t.svg: Removed.

6:47 PM Changeset in webkit [22718] by oliver

• 3 edits in branches/WindowsMerge/WebCore

2006-12-27 Oliver Hunt <​oliver@apple.com>

Build fix

• WebCore.vcproj/WebCore.vcproj:
• platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::getHBITMAP):

6:24 PM Changeset in webkit [18447] by oliver

• 5 edits in trunk/WebCore

2006-12-27 Oliver Hunt <​oliver@apple.com>

Build fix

• platform/graphics/BitmapImage.h:
• platform/graphics/Image.cpp:
• platform/graphics/Image.h: (WebCore::Image::getHBITMAP):
• platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::PDFDocumentImage):

4:48 PM Changeset in webkit [18446] by eseidel

• 13 edits
  2 copies in trunk/WebCore

2006-12-27 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add new PDFDocumentImage and BitmapImage classes (subclasses of Image)
(In preparation for adding SVGImage as part of bug 5971)
​http://bugs.webkit.org/show_bug.cgi?id=11990

Test cases landed separately as part of filing bug 11992.

• WebCore.xcodeproj/project.pbxproj: add BitmapImage.*
• loader/CachedImage.cpp: (WebCore::nullImage): use BitmapImage directly (WebCore::CachedImage::createImage): now create either BitmapImage or PDFDocumentImage directly
• loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::setImageData): use BitmapImage directly
• platform/graphics/BitmapImage.cpp: Added. (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::~BitmapImage): (WebCore::BitmapImage::invalidateData): (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::size): (WebCore::BitmapImage::setNativeData): (WebCore::BitmapImage::frameCount): (WebCore::BitmapImage::isSizeAvailable): (WebCore::BitmapImage::frameAtIndex): (WebCore::BitmapImage::frameDurationAtIndex): (WebCore::BitmapImage::frameHasAlphaAtIndex): (WebCore::BitmapImage::shouldAnimate): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::stopAnimation): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation):
• platform/graphics/BitmapImage.h: Added. (WebCore::FrameData::FrameData): (WebCore::BitmapImage::nativeImageForCurrentFrame): added. (WebCore::BitmapImage::currentFrame): (WebCore::BitmapImage::mayFillWithSolidColor): added. (WebCore::BitmapImage::solidColor): added.
• platform/graphics/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image):
• platform/graphics/Image.h: (WebCore::Image::setNativeData): now virtual (WebCore::Image::stopAnimation): now virtual (WebCore::Image::resetAnimation): now virtual (WebCore::Image::getNSImage): now virtual (WebCore::Image::getTIFFRepresentation): now virtual (WebCore::Image::getCGImageRef): now virtual
• platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::getCGImageRef): use nativeImageForCurrentFrame (WebCore::fillWithSolidColor): added (WebCore::BitmapImage::draw): (WebCore::drawPattern): use fillWithSolidColor, mayFillWithSolidColor() and solidcolor() (WebCore::BitmapImage::drawTiled): use fillWithSolidColor, mayFillWithSolidColor() and solidcolor()
• platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::size): change to subclass from Image (WebCore::PDFDocumentImage::setNativeData): (WebCore::PDFDocumentImage::draw):
• platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::drawTiled):
• platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::getTIFFRepresentation): (WebCore::BitmapImage::getNSImage):
• platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter): remove soon-to-be unnecessary comment
• rendering/RenderImage.cpp: (WebCore::RenderImage::nullImage): use BitmapImage

4:02 PM Changeset in webkit [18445] by weinig

• 2 edits in trunk/WebKit

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=9403 Red outline from Web Inspector appears above all other OS X windows

Made the window containing the highlight a child window of the window
containing the view.

• WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithBounds:andRects:forView:]): (-[WebNodeHighlight dealloc]): (-[WebNodeHighlight expire]):

3:47 PM Changeset in webkit [18444] by weinig

• 3 edits in trunk/WebKit

Reviewed by Tim H.

Bug 11993: REGRESSION(r18320): Web Inspector scroll bars not drawn
​http://bugs.webkit.org/show_bug.cgi?id=11993

AppleVerticalScrollbar tries to set a NaN value as the scroll height which
causes DOM Exceptions after r18320. This overrides the _setObjectLength
method and checks for NaN until a system update can fix this. See rdar://4901491

• WebInspector/webInspector/inspector.html:
• WebInspector/webInspector/inspector.js:

3:43 PM Changeset in webkit [18443] by weinig

• 4 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=11452 REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes

• fast/repaint/fixed-expected.checksum: Added.
• fast/repaint/fixed-expected.png: Added.
• fast/repaint/fixed-expected.txt: Added.
• fast/repaint/fixed.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11452 REGRESSION (r16736-r16801): Incorrect repaint of fixed boxes

Test: fast/repaint/fixed.html

• rendering/RenderView.cpp: (WebCore::RenderView::computeAbsoluteRepaintRect): Re-added.
• rendering/RenderView.h:

3:25 PM Changeset in webkit [18442] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Geoff.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=11930 Specifying border-radius makes the outline shrink

• fast/css/border-radius-outline-offset-expected.checksum: Added.
• fast/css/border-radius-outline-offset-expected.png: Added.
• fast/css/border-radius-outline-offset-expected.txt: Added.
• fast/css/border-radius-outline-offset.html: Added.

WebCore:

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11930 Specifying border-radius makes the outline shrink

Test: fast/css/border-radius-outline-offset.html

• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Added missing return statement.

2:40 PM Changeset in webkit [18441] by ggaren

• 2 edits in trunk/WebKit

Reviewed by Oliver Hunt.

Fixed <rdar://problem/4901629> Crash occurs at WebCore::Frame::page()
after closing window containing flash content

No testcase because we can't open and close windows in DRT.

I can't reproduce this crash, but from the backtrace it's clear that it
occured because of a NULL frame object. Since it's valid for a frame to
be NULL, I've added NULL checks.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView getVariable:value:]):

2:27 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org

(diff)

2:04 PM Changeset in webkit [18440] by rwlbuis

• 11 edits
  2 copies in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=11108
Replace usage of split by proper parsers
​http://bugs.webkit.org/show_bug.cgi?id=11908
WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes
Get rid of split() when parsing transform attribute.

1:19 PM Changeset in webkit [18439] by weinig

• 3 edits in trunk/WebCore

Reviewed by Geoff.

• ​http://bugs.webkit.org/show_bug.cgi?id=11968 BidiContext's m_basicDir is redundant

No test possible (no functionality change)

• rendering/bidi.cpp: (WebCore::BidiContext::BidiContext): (WebCore::operator==): (WebCore::RenderBlock::computeHorizontalPositionsForLine): Use the block's direction to resolve 'automatic' text-align.
• rendering/bidi.h: (WebCore::BidiContext::dir):

1:09 PM Changeset in webkit [18438] by brmorris

• 3 edits in S60/trunk/WebKit

2006-12-27 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Reverted 2 patches to CFormDataAutoFillStore: r18389, r18183
​http://bugs.webkit.org/show_bug.cgi?id=11927
​http://bugs.webkit.org/show_bug.cgi?id=11781

11:56 AM Changeset in webkit [18437] by ggaren

• 7 edits in trunk

LayoutTests:

Reviewed by Eric Seidel.

Fixed regression in plugins/netscape-dom-access.html.

When I stopped WebKit from meddling in plug-in lifetime, plug-ins started
to live a little longer. In this case, the plug-in from mouse-events.html
started to live long enough to get a blur event when DumpRenderTree navigated
to the next page.

• plugins/mouse-events.html: Stop logging events when the test is over, so our results don't bleed into the next test. A better solution might be for the event logger inside DRT to check for whether you're still in the document, but that doesn't seem worth the effort right now.

WebKitTools:

Reviewed by Eric Seidel. Prose edited by Mitz Pettel.

Some cleanup I did while debugging the regression in plugins/netscape-dom-access.html.

No behavior change. Layout tests pass.

• DumpRenderTree/DumpRenderTree.h: Exported the done BOOL in place of the doneLoading() accessor function. This matches the rest of DRT's exports and makes it easier to search for clients who check (!done).

• DumpRenderTree/DumpRenderTree.m: Moved fflush() call to runTest() so it would cover both code paths for calling runTest().

(dumpRenderTree): "doneLoading()" => "done"
(dump): ditto

• DumpRenderTree/EditingDelegate.m: ditto (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): ditto (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): ditto (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): ditto (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): ditto (-[EditingDelegate webView:shouldDeleteDOMRange:]): ditto (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): ditto (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): ditto (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): ditto (-[EditingDelegate webViewDidBeginEditing:]): ditto (-[EditingDelegate webViewDidChange:]): ditto (-[EditingDelegate webViewDidEndEditing:]): ditto (-[EditingDelegate webViewDidChangeTypingStyle:]): ditto (-[EditingDelegate webViewDidChangeSelection:]): ditto
• DumpRenderTree/UIDelegate.m: ditto (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]): ditto

11:52 AM Changeset in webkit [18436] by eseidel

• 879 edits
  529 adds in trunk/LayoutTests

2006-12-27 Eric Seidel <​eric@webkit.org>

Rubber-stamped by ggaren.

Update SVG tests with the latest tests released by the W3C:
​http://www.w3.org/Graphics/SVG/Test/20061213

A few tests are likely to fail on the buildbot due to Asian fonts, filter color spaces, and '(' and ')' spacing differences between machines

• svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-02-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-02-t.svg:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-03-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-03-t.svg:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-04-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-04-t.svg:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-05-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-05-t.svg:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-06-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-07-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-07-t.svg:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-08-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-08-t.svg:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-09-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-09-t.svg:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-10-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-11-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-11-t.svg:
• svg/W3C-SVG-1.1/animate-elem-12-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-12-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-12-t.svg:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-13-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-13-t.svg:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-14-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-14-t.svg:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-15-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-17-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-17-t.svg:
• svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-19-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-19-t.svg:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-20-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-20-t.svg:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-21-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-21-t.svg:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-22-b-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-22-b.svg:
• svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-23-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-23-t.svg:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-24-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-25-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-25-t.svg:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-26-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-26-t.svg:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-27-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-27-t.svg:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-28-t-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-28-t.svg:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-29-b-w3c.png:
• svg/W3C-SVG-1.1/animate-elem-29-b.svg:
• svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-30-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-30-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-31-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-31-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-32-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-32-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-33-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-33-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-34-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-34-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-34-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-35-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-36-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-36-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-37-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-37-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-38-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-39-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-39-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-40-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-40-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-41-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-41-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-42-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-43-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-44-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-44-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-44-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-45-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-46-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-46-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-46-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-47-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-48-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-49-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-50-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-51-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-52-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-52-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-52-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-53-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-60-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-60-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-61-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-61-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-62-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-62-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-63-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-63-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-64-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-64-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-64-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-65-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-65-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-66-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-66-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-67-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-67-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-68-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-68-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-69-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-69-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-70-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-70-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-77-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-77-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-77-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-78-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-78-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-78-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-80-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-80-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-81-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-81-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-82-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-82-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-83-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-83-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-84-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-84-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-84-t.svg: Added.
• svg/W3C-SVG-1.1/animate-elem-85-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
• svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
• svg/W3C-SVG-1.1/animate-elem-85-t-w3c.png: Added.
• svg/W3C-SVG-1.1/animate-elem-85-t.svg: Added.
• svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
• svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
• svg/W3C-SVG-1.1/color-prof-01-f-w3c.png:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
• svg/W3C-SVG-1.1/color-prop-01-b-w3c.png:
• svg/W3C-SVG-1.1/color-prop-01-b.svg:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.checksum:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-02-f-w3c.png:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.checksum:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
• svg/W3C-SVG-1.1/color-prop-03-t-w3c.png:
• svg/W3C-SVG-1.1/color-prop-03-t.svg:
• svg/W3C-SVG-1.1/color-prop-04-t-w3c.png: Added.
• svg/W3C-SVG-1.1/color-prop-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-coord-01-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
• svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
• svg/W3C-SVG-1.1/coords-coord-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-coord-01-t.svg: Added.
• svg/W3C-SVG-1.1/coords-coord-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/coords-coord-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-coord-02-t.svg: Added.
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-01-b-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-01-b.svg:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-02-t-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-02-t.svg:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-03-t-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-03-t.svg:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-04-t-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-04-t.svg:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-05-t-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-05-t.svg:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.checksum:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-06-t-w3c.png:
• svg/W3C-SVG-1.1/coords-trans-06-t.svg:
• svg/W3C-SVG-1.1/coords-trans-07-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-trans-08-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-trans-09-t-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
• svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-01-b-w3c.png:
• svg/W3C-SVG-1.1/coords-units-01-b.svg:
• svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
• svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-02-b-w3c.png:
• svg/W3C-SVG-1.1/coords-units-02-b.svg:
• svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-03-b-w3c.png:
• svg/W3C-SVG-1.1/coords-units-03-b.svg:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-w3c.png:
• svg/W3C-SVG-1.1/coords-viewattr-01-b.svg:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-w3c.png:
• svg/W3C-SVG-1.1/coords-viewattr-02-b.svg:
• svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
• svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
• svg/W3C-SVG-1.1/coords-viewattr-03-b-w3c.png: Added.
• svg/W3C-SVG-1.1/coords-viewattr-03-b.svg: Added.
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
• svg/W3C-SVG-1.1/extend-namespace-01-f.svg:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-blend-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-blend-01-b.svg:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-color-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-color-01-b.svg:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
• svg/W3C-SVG-1.1/filters-composite-02-b-w3c.png:
• svg/W3C-SVG-1.1/filters-composite-02-b.svg:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-comptran-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-comptran-01-b.svg:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-conv-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-conv-01-f.svg:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-displace-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-displace-01-f.svg:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-example-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-felem-01-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
• svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
• svg/W3C-SVG-1.1/filters-felem-01-b-w3c.png: Added.
• svg/W3C-SVG-1.1/filters-felem-01-b.svg: Added.
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-gauss-01-b.svg:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-image-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-image-01-b.svg:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-light-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-light-01-f.svg:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-morph-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-morph-01-f.svg:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-offset-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-offset-01-b.svg:
• svg/W3C-SVG-1.1/filters-overview-01-b-w3c.png: Added.
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-specular-01-f-w3c.png:
• svg/W3C-SVG-1.1/filters-specular-01-f.svg:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-tile-01-b-w3c.png:
• svg/W3C-SVG-1.1/filters-tile-01-b.svg:
• svg/W3C-SVG-1.1/filters-turb-01-f-w3c.png:
• svg/W3C-SVG-1.1/fonts-desc-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-desc-02-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-desc-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-desc-04-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-desc-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
• svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
• svg/W3C-SVG-1.1/fonts-elem-01-t-w3c.png:
• svg/W3C-SVG-1.1/fonts-elem-01-t.svg:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-02-t-w3c.png:
• svg/W3C-SVG-1.1/fonts-elem-02-t.svg:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-03-b-w3c.png:
• svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
• svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-elem-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-05-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-elem-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-06-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-elem-07-b-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-elem-07-b.svg: Added.
• svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-glyph-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-glyph-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-03-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-glyph-04-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-glyph-04-t.svg: Added.
• svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
• svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
• svg/W3C-SVG-1.1/fonts-kern-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/fonts-kern-01-t.svg: Added.
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
• svg/W3C-SVG-1.1/interact-cursor-01-f-w3c.png:
• svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.checksum:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-dom-01-b-w3c.png:
• svg/W3C-SVG-1.1/interact-dom-01-b.svg:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.checksum:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-events-01-b-w3c.png:
• svg/W3C-SVG-1.1/interact-events-01-b.svg:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-01-b-w3c.png:
• svg/W3C-SVG-1.1/interact-order-01-b.svg:
• svg/W3C-SVG-1.1/interact-order-02-b-w3c.png:
• svg/W3C-SVG-1.1/interact-order-02-b.svg:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.checksum:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-03-b-w3c.png:
• svg/W3C-SVG-1.1/interact-order-03-b.svg:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
• svg/W3C-SVG-1.1/interact-zoom-01-t-w3c.png:
• svg/W3C-SVG-1.1/interact-zoom-01-t.svg:
• svg/W3C-SVG-1.1/interact-zoom-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/interact-zoom-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum:
• svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
• svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-01-b-w3c.png:
• svg/W3C-SVG-1.1/linking-a-01-b.svg:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-02-b-w3c.png:
• svg/W3C-SVG-1.1/linking-a-02-b.svg:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-03-b-w3c.png:
• svg/W3C-SVG-1.1/linking-a-03-b.svg:
• svg/W3C-SVG-1.1/linking-a-04-t-expected.checksum:
• svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
• svg/W3C-SVG-1.1/linking-a-04-t-w3c.png:
• svg/W3C-SVG-1.1/linking-a-04-t.svg:
• svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
• svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
• svg/W3C-SVG-1.1/linking-a-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-a-05-t.svg: Added.
• svg/W3C-SVG-1.1/linking-a-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-a-07-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
• svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
• svg/W3C-SVG-1.1/linking-a-07-t-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-a-07-t.svg: Added.
• svg/W3C-SVG-1.1/linking-a-08-t-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-a-09-b-w3c.png: Added.
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-01-b-w3c.png:
• svg/W3C-SVG-1.1/linking-uri-01-b.svg:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-02-b-w3c.png:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-03-t.svg:
• svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Added.
• svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
• svg/W3C-SVG-1.1/masking-intro-01-f-w3c.png: Added.
• svg/W3C-SVG-1.1/masking-intro-01-f.svg: Added.
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-mask-01-b-w3c.png:
• svg/W3C-SVG-1.1/masking-mask-01-b.svg:
• svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-opacity-01-b-w3c.png:
• svg/W3C-SVG-1.1/masking-opacity-01-b.svg:
• svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-01-b-w3c.png:
• svg/W3C-SVG-1.1/masking-path-01-b.svg:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-02-b-w3c.png:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-03-b-w3c.png:
• svg/W3C-SVG-1.1/masking-path-03-b.svg:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-04-b-w3c.png:
• svg/W3C-SVG-1.1/masking-path-04-b.svg:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
• svg/W3C-SVG-1.1/masking-path-05-f-w3c.png:
• svg/W3C-SVG-1.1/masking-path-05-f.svg:
• svg/W3C-SVG-1.1/masking-path-06-b-w3c.png: Added.
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/metadata-example-01-b-w3c.png:
• svg/W3C-SVG-1.1/metadata-example-01-b.svg:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-01-t-w3c.png:
• svg/W3C-SVG-1.1/painting-fill-01-t.svg:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-02-t-w3c.png:
• svg/W3C-SVG-1.1/painting-fill-02-t.svg:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-03-t-w3c.png:
• svg/W3C-SVG-1.1/painting-fill-03-t.svg:
• svg/W3C-SVG-1.1/painting-fill-04-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-04-t-w3c.png:
• svg/W3C-SVG-1.1/painting-fill-04-t.svg:
• svg/W3C-SVG-1.1/painting-fill-05-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
• svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
• svg/W3C-SVG-1.1/painting-fill-05-b-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-fill-05-b.svg: Added.
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-01-f-w3c.png:
• svg/W3C-SVG-1.1/painting-marker-01-f.svg:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
• svg/W3C-SVG-1.1/painting-marker-02-f-w3c.png:
• svg/W3C-SVG-1.1/painting-marker-02-f.svg:
• svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum: Added.
• svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
• svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
• svg/W3C-SVG-1.1/painting-marker-03-f-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-marker-03-f.svg: Added.
• svg/W3C-SVG-1.1/painting-marker-04-f-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-render-01-b-w3c.png:
• svg/W3C-SVG-1.1/painting-render-01-b.svg:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-01-t-w3c.png:
• svg/W3C-SVG-1.1/painting-stroke-01-t.svg:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-02-t-w3c.png:
• svg/W3C-SVG-1.1/painting-stroke-02-t.svg:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-03-t-w3c.png:
• svg/W3C-SVG-1.1/painting-stroke-03-t.svg:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.checksum:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-04-t-w3c.png:
• svg/W3C-SVG-1.1/painting-stroke-04-t.svg:
• svg/W3C-SVG-1.1/painting-stroke-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-stroke-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
• svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
• svg/W3C-SVG-1.1/painting-stroke-07-t-w3c.png: Added.
• svg/W3C-SVG-1.1/painting-stroke-07-t.svg: Added.
• svg/W3C-SVG-1.1/painting-stroke-08-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-01-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-01-t.svg:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-02-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-02-t.svg:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
• svg/W3C-SVG-1.1/paths-data-03-f-w3c.png:
• svg/W3C-SVG-1.1/paths-data-03-f.svg:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-04-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-04-t.svg:
• svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-05-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-05-t.svg:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-06-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-06-t.svg:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-07-t-w3c.png:
• svg/W3C-SVG-1.1/paths-data-07-t.svg:
• svg/W3C-SVG-1.1/paths-data-08-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-08-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-08-t.svg: Added.
• svg/W3C-SVG-1.1/paths-data-09-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-09-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-09-t.svg: Added.
• svg/W3C-SVG-1.1/paths-data-10-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-10-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-10-t.svg: Added.
• svg/W3C-SVG-1.1/paths-data-11-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-12-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-13-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-13-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-13-t.svg: Added.
• svg/W3C-SVG-1.1/paths-data-14-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-14-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-14-t.svg: Added.
• svg/W3C-SVG-1.1/paths-data-15-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
• svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
• svg/W3C-SVG-1.1/paths-data-15-t-w3c.png: Added.
• svg/W3C-SVG-1.1/paths-data-15-t.svg: Added.
• svg/W3C-SVG-1.1/paths-dist-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-01-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-01-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-02-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-02-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-03-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-03-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-04-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-04-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-05-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-05-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-06-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-06-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-07-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-07-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-08-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-08-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-09-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-09-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-10-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-10-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-11-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-11-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-12-b-w3c.png:
• svg/W3C-SVG-1.1/pservers-grad-12-b.svg:
• svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-13-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-13-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-14-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-14-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-15-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-15-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-15-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-16-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-16-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-17-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-17-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-18-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-18-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-18-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
• svg/W3C-SVG-1.1/pservers-grad-19-b-w3c.png: Added.
• svg/W3C-SVG-1.1/pservers-grad-19-b.svg: Added.
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-w3c.png:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-01-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-01-t.svg:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-02-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-02-t.svg:
• svg/W3C-SVG-1.1/render-elems-03-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-03-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-03-t.svg:
• svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-06-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-07-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-07-t.svg:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-08-t-w3c.png:
• svg/W3C-SVG-1.1/render-elems-08-t.svg:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-groups-01-b-w3c.png:
• svg/W3C-SVG-1.1/render-groups-01-b.svg:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
• svg/W3C-SVG-1.1/render-groups-03-t.svg:
• svg/W3C-SVG-1.1/resources/20x20.png: Added.
• svg/W3C-SVG-1.1/resources/SVGImageTest.svg: Added.
• svg/W3C-SVG-1.1/resources/animation-add-BE-09.svg:
• svg/W3C-SVG-1.1/resources/coords-units-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-blend-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-color-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-composite-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-comptran-01-f.svg: Added.
• svg/W3C-SVG-1.1/resources/filters-conv-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-diffuse-01-f.svg:
• svg/W3C-SVG-1.1/resources/filters-example-01-f.svg:
• svg/W3C-SVG-1.1/resources/galpha.png: Added.
• svg/W3C-SVG-1.1/resources/interact-dom-01-f.svg:
• svg/W3C-SVG-1.1/resources/linking-uri-01-b.svg:
• svg/W3C-SVG-1.1/resources/makealpha.svg: Added.
• svg/W3C-SVG-1.1/resources/paths-data-01-f.svg:
• svg/W3C-SVG-1.1/resources/paths-data-02-f.svg:
• svg/W3C-SVG-1.1/resources/paths-data-03-f.svg:
• svg/W3C-SVG-1.1/resources/paths-data-04-f.svg:
• svg/W3C-SVG-1.1/resources/plant.jpg: Added.
• svg/W3C-SVG-1.1/resources/rgbalpha.png: Added.
• svg/W3C-SVG-1.1/resources/shapes-ellipse-01-b.svg:
• svg/W3C-SVG-1.1/resources/shapes-ellipse-01-f.svg:
• svg/W3C-SVG-1.1/resources/shapes-rect-01-b.svg:
• svg/W3C-SVG-1.1/resources/shapes-rect-01-f.svg:
• svg/W3C-SVG-1.1/resources/smiley.png: Added.
• svg/W3C-SVG-1.1/resources/stefan_252_tRNS_opti.png: Added.
• svg/W3C-SVG-1.1/resources/svgRef1.svg: Added.
• svg/W3C-SVG-1.1/resources/svgRef4.css: Added.
• svg/W3C-SVG-1.1/resources/svgRef4.svg: Added.
• svg/W3C-SVG-1.1/resources/text-align-01-f.svg:
• svg/W3C-SVG-1.1/resources/text-align-02-f.svg:
• svg/W3C-SVG-1.1/resources/text-align-03-f.svg:
• svg/W3C-SVG-1.1/resources/text-altglyph-01-f.svg:
• svg/W3C-SVG-1.1/resources/text-extTref-BE-18-targ.svg:
• svg/W3C-SVG-1.1/resources/text-intro-01-f.svg:
• svg/W3C-SVG-1.1/resources/text-tref-01-f.svg:
• svg/W3C-SVG-1.1/resources/text-ws-01-f.svg:
• svg/W3C-SVG-1.1/script-handle-02-b-w3c.png:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.checksum:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-03-b-w3c.png:
• svg/W3C-SVG-1.1/script-handle-03-b.svg:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.checksum:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-04-b-w3c.png:
• svg/W3C-SVG-1.1/script-handle-04-b.svg:
• svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-circle-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-circle-01-t.svg:
• svg/W3C-SVG-1.1/shapes-circle-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/shapes-circle-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/shapes-circle-02-t.svg: Added.
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t.svg:
• svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/shapes-ellipse-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/shapes-ellipse-02-t.svg: Added.
• svg/W3C-SVG-1.1/shapes-intro-01-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
• svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
• svg/W3C-SVG-1.1/shapes-intro-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/shapes-intro-01-t.svg: Added.
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.checksum:
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-line-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-line-01-t.svg:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.checksum:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-polygon-01-t.svg:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.checksum:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-polyline-01-t.svg:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-rect-01-t-w3c.png:
• svg/W3C-SVG-1.1/shapes-rect-01-t.svg:
• svg/W3C-SVG-1.1/shapes-rect-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/shapes-rect-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/shapes-rect-02-t.svg: Added.
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-01-t-w3c.png:
• svg/W3C-SVG-1.1/struct-cond-01-t.svg:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.png:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-02-t-w3c.png:
• svg/W3C-SVG-1.1/struct-cond-02-t.svg:
• svg/W3C-SVG-1.1/struct-cond-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-cond-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-cond-03-t.svg: Added.
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-defs-01-t-w3c.png:
• svg/W3C-SVG-1.1/struct-defs-01-t.svg:
• svg/W3C-SVG-1.1/struct-dom-01-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-02-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-03-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-04-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.checksum:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-05-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-05-b.svg:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.checksum:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-06-b-w3c.png:
• svg/W3C-SVG-1.1/struct-dom-06-b.svg:
• svg/W3C-SVG-1.1/struct-frag-01-t.svg:
• svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-frag-02-t.svg: Added.
• svg/W3C-SVG-1.1/struct-frag-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-frag-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-frag-03-t.svg: Added.
• svg/W3C-SVG-1.1/struct-frag-04-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-frag-04-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-frag-04-t.svg: Added.
• svg/W3C-SVG-1.1/struct-frag-05-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-frag-06-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-frag-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-frag-06-t.svg: Added.
• svg/W3C-SVG-1.1/struct-group-01-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-01-t-w3c.png:
• svg/W3C-SVG-1.1/struct-group-02-b-w3c.png:
• svg/W3C-SVG-1.1/struct-group-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-group-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-group-03-t.svg: Added.
• svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-01-t-w3c.png:
• svg/W3C-SVG-1.1/struct-image-01-t.svg:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-02-b-w3c.png:
• svg/W3C-SVG-1.1/struct-image-02-b.svg:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-03-t-w3c.png:
• svg/W3C-SVG-1.1/struct-image-03-t.svg:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-04-t-w3c.png:
• svg/W3C-SVG-1.1/struct-image-04-t.svg:
• svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
• svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
• svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-05-b-w3c.png:
• svg/W3C-SVG-1.1/struct-image-05-b.svg:
• svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-image-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-image-06-t.svg: Added.
• svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-image-07-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-image-07-t.svg: Added.
• svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-image-08-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-image-08-t.svg: Added.
• svg/W3C-SVG-1.1/struct-image-09-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-image-09-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-image-09-t.svg: Added.
• svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-image-10-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-image-10-t.svg: Added.
• svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
• svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
• svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
• svg/W3C-SVG-1.1/struct-symbol-01-b-w3c.png:
• svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
• svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-use-01-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-use-01-t.svg: Added.
• svg/W3C-SVG-1.1/struct-use-02-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-use-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-use-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-use-03-t.svg: Added.
• svg/W3C-SVG-1.1/struct-use-04-b-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-use-05-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/struct-use-05-b-expected.png: Added.
• svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
• svg/W3C-SVG-1.1/struct-use-05-b-w3c.png: Added.
• svg/W3C-SVG-1.1/struct-use-05-b.svg: Added.
• svg/W3C-SVG-1.1/styling-css-01-b-expected.checksum:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-01-b-w3c.png:
• svg/W3C-SVG-1.1/styling-css-01-b.svg:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-02-b-w3c.png:
• svg/W3C-SVG-1.1/styling-css-02-b.svg:
• svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
• svg/W3C-SVG-1.1/styling-css-03-b-w3c.png:
• svg/W3C-SVG-1.1/styling-css-04-f-expected.checksum: Added.
• svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
• svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
• svg/W3C-SVG-1.1/styling-css-04-f-w3c.png: Added.
• svg/W3C-SVG-1.1/styling-css-04-f.svg: Added.
• svg/W3C-SVG-1.1/styling-css-05-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/styling-css-05-b-expected.png: Added.
• svg/W3C-SVG-1.1/styling-css-05-b-w3c.png: Added.
• svg/W3C-SVG-1.1/styling-css-05-b.svg: Added.
• svg/W3C-SVG-1.1/styling-css-06-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/styling-css-06-b-expected.png: Added.
• svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
• svg/W3C-SVG-1.1/styling-css-06-b-w3c.png: Added.
• svg/W3C-SVG-1.1/styling-css-06-b.svg: Added.
• svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
• svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
• svg/W3C-SVG-1.1/styling-inherit-01-b-w3c.png:
• svg/W3C-SVG-1.1/styling-inherit-01-b.svg:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.checksum:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
• svg/W3C-SVG-1.1/styling-pres-01-t-w3c.png:
• svg/W3C-SVG-1.1/styling-pres-01-t.svg:
• svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-01-b-expected.png:
• svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-01-b.svg:
• svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-02-b-expected.png:
• svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-02-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-02-b.svg:
• svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-03-b-expected.png:
• svg/W3C-SVG-1.1/text-align-03-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-03-b.svg:
• svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-04-b-expected.png:
• svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-04-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-04-b.svg:
• svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-05-b-expected.png:
• svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-05-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-05-b.svg:
• svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-06-b-expected.png:
• svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-06-b-w3c.png:
• svg/W3C-SVG-1.1/text-align-06-b.svg:
• svg/W3C-SVG-1.1/text-align-07-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
• svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
• svg/W3C-SVG-1.1/text-align-08-b.svg: Added.
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-altglyph-01-b.svg:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-deco-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-deco-01-b.svg:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-01-t-w3c.png:
• svg/W3C-SVG-1.1/text-fonts-01-t.svg:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-02-t-w3c.png:
• svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-fonts-03-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-fonts-03-t.svg: Added.
• svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-01-t-w3c.png:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-02-b-w3c.png:
• svg/W3C-SVG-1.1/text-intro-02-b.svg:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-03-b.svg:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-04-t-w3c.png:
• svg/W3C-SVG-1.1/text-intro-04-t.svg:
• svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-intro-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-intro-05-t.svg: Added.
• svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-path-01-b-expected.png:
• svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-path-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-path-01-b.svg:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-spacing-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-spacing-01-b.svg:
• svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-text-01-b-expected.png:
• svg/W3C-SVG-1.1/text-text-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-text-01-b.svg:
• svg/W3C-SVG-1.1/text-text-03-b-expected.png:
• svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-03-b-w3c.png:
• svg/W3C-SVG-1.1/text-text-03-b.svg:
• svg/W3C-SVG-1.1/text-text-04-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-text-04-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-text-04-t.svg: Added.
• svg/W3C-SVG-1.1/text-text-05-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-text-05-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-text-05-t.svg: Added.
• svg/W3C-SVG-1.1/text-text-06-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-text-06-t-w3c.png: Added.
• svg/W3C-SVG-1.1/text-text-07-t-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-text-07-t-expected.png: Added.
• svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
• svg/W3C-SVG-1.1/text-text-07-t.svg: Added.
• svg/W3C-SVG-1.1/text-text-08-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
• svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
• svg/W3C-SVG-1.1/text-text-08-b-w3c.png: Added.
• svg/W3C-SVG-1.1/text-text-08-b.svg: Added.
• svg/W3C-SVG-1.1/text-tref-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
• svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tref-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-tref-01-b.svg:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tselect-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-tselect-01-b.svg:
• svg/W3C-SVG-1.1/text-tselect-01-f-w3c.png: Added.
• svg/W3C-SVG-1.1/text-tselect-02-f-expected.checksum: Added.
• svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
• svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
• svg/W3C-SVG-1.1/text-tselect-02-f.svg: Added.
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tspan-01-b-w3c.png:
• svg/W3C-SVG-1.1/text-tspan-01-b.svg:
• svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
• svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-ws-01-t-w3c.png:
• svg/W3C-SVG-1.1/text-ws-01-t.svg:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.checksum:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
• svg/W3C-SVG-1.1/text-ws-02-t-w3c.png:
• svg/W3C-SVG-1.1/text-ws-02-t.svg:
• svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum: Added.
• svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
• svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
• svg/W3C-SVG-1.1/types-basicDOM-01-b-w3c.png: Added.
• svg/W3C-SVG-1.1/types-basicDOM-01-b.svg: Added.

10:55 AM Changeset in webkit [18435] by ggaren

• 2 edits in trunk/WebKit

Reviewed by Darin Adler.

Updated <rdar://problem/4871518> fix based on Darin's comments.

Instead of searching the frame tree to retrieve the new frame, put it in
a RefPtr, and then explicitly check for its removal. This option is slightly
more efficient, and it avoids problems that can occur due to frame name collision.

• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):

9:49 AM Changeset in webkit [18434] by zimmermann

• 2 edits in trunk/WebCore

Build fix, not reviewed.
Accidently commited an older revision of this file.

9:45 AM Changeset in webkit [18433] by zimmermann

• 4 edits in trunk/WebCore

Reviewed by Mitz & Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11904

We need to cache the CGPatternRef (m_pattern) for efficiency
in SVGPaintServerPatternCg, and keep track wheter the underlying
ImageBuffer has changed, and only update the pattern in that case.

9:06 AM S60ConfigureComputer edited by bradley.morrison@nokia.com

(diff)

1:03 AM Changeset in webkit [18432] by eseidel

• 4 edits in trunk/LayoutTests

2006-12-27 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Corrected test results. (Last minute change before earlier checkin.)

• svg/custom/invalid-fill-hex-expected.checksum:
• svg/custom/invalid-fill-hex-expected.png:
• svg/custom/invalid-fill-hex-expected.txt:

12:15 AM Changeset in webkit [18431] by eseidel

• 1 edit
  13 adds in trunk/LayoutTests

2006-12-27 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add tests to document our current PDF-as-image behavior.
(Note: we fail pdf-as-background tests, filed as bug 11992)

• fast/images/pdf-as-background-expected.checksum: Added.
• fast/images/pdf-as-background-expected.png: Added.
• fast/images/pdf-as-background-expected.txt: Added.
• fast/images/pdf-as-background.html: Added.
• fast/images/pdf-as-image-expected.checksum: Added.
• fast/images/pdf-as-image-expected.png: Added.
• fast/images/pdf-as-image-expected.txt: Added.
• fast/images/pdf-as-image.html: Added.
• fast/images/pdf-as-tiled-background-expected.checksum: Added.
• fast/images/pdf-as-tiled-background-expected.png: Added.
• fast/images/pdf-as-tiled-background-expected.txt: Added.
• fast/images/pdf-as-tiled-background.html: Added.
• fast/images/resources/green_rectangle.pdf: Added.

Dec 26, 2006:

11:46 PM Changeset in webkit [22717] by ggaren

• 3 edits in branches/WindowsMerge/WebKitWin

Build fix.

• WebFrame.cpp: Removed willCloseDocument, which is now gone from WebCore::FrameLoaderClient.
• WebFrame.h: ditto

11:38 PM Changeset in webkit [18430] by ggaren

• 16 edits in trunk

WebCore:

Reviewed by Eric Seidel.

Fixed <rdar://problem/4740328> Safari crash on quit in _NPN_ReleaseObject
from KJS::Bindings::CInstance::~CInstance

No testcase because we can't open and close windows in DumpRenderTree.

• loader/FrameLoader.cpp: Removed closeDocument helper function because its only purpose was to call didCloseDocument, which is gone now. (WebCore::FrameLoader::detachFromParent): closeDocument => closeURL, since didCloseDocument is gone now.

• loader/FrameLoaderClient.h: Removed didCloseDocument because it proved unnecessary and harmful.

• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::transitionToCommitted): closeDocument => closeURL, since didCloseDocument is gone now.

WebKit:

Reviewed by Eric Seidel.

Fixed <rdar://problem/4740328> Safari crash on quit in _NPN_ReleaseObject
from KJS::Bindings::CInstance::~CInstance

The essence of this change is that WebKit shouldn't meddle in plug-in
lifetime, since WebCore already manages it. The rest is details.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView removeTrackingRect]): Autorelease our window instead of releasing it, since we might hold the last reference to our window, and releasing it immediately would crash AppKit. (-[WebBaseNetscapePluginView resetTrackingRect]):

• Plugins/WebNetscapePluginEmbeddedView.h:
• Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]): Use our DOMElement to access our WebFrame, since we don't keep around a direct pointer to our WebFrame anymore.

• Plugins/WebNullPluginView.h:
• Plugins/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:error:DOMElement:]): (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]): Use our DOMElement to access our WebFrame, as above.

• WebCoreSupport/WebFrameBridge.mm: Don't call _addPlugInView because it doesn't exist anymore. Do pass a DOMElement to WebNullPluginView's initializer, so it can access its frame like WebNetscapePluginEmbeddedView does. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: Removed didCloseDocument. It had two purposes -- one unnecessary, one harmful: (1) NULL out plug-ins' weak references to their frames. Unnecessary. Having plug-ins access their frames through their DOM elements solves this problem. (2) Unload plug-ins. Harmful. If a plug-in unloads before WebCore is done with it, WebCore will access unmapped memory. Also unnecessary. WebCore Widgets take care of calling -removeFromSuperview on their NSViews, which is sufficient for stopping plug-ins.

• WebKit.xcodeproj/project.pbxproj: Made WebNullPluginView.m ObjC++.

• WebView/WebFrame.mm: Removed _addPlugInView, since it was only used to call -setWebFrame, which is gone. (-[WebFramePrivate dealloc]):
• WebView/WebFrameInternal.h: Removed plugInViews, since it was only used by _addPlugInView, which is gone.

8:13 PM Changeset in webkit [18429] by eseidel

• 6 edits
  4 adds in trunk

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

ASSERT while loading SVG map
​http://bugs.webkit.org/show_bug.cgi?id=11987

• ksvg2/css/SVGCSSParser.cpp: remove a few .impl() calls previously missed. (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
• ksvg2/misc/KCanvasRenderingStyle.cpp: handle invalid colors (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):

7:13 PM Changeset in webkit [18428] by eseidel

• 29 edits in trunk/WebCore

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by ggaren.

No test cases changed.

Remove unnecessary (and inefficient) .impl() and .deprecatedString() calls.
​http://bugs.webkit.org/show_bug.cgi?id=11989

• bindings/js/kjs_dom.cpp: (KJS::DOMNodeList::getOwnPropertySlot):
• dom/Document.cpp: (WebCore::Document::createAttributeNS):
• dom/Element.cpp: (WebCore::Element::getAttributeNS): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeNS): (WebCore::Element::removeAttributeNS): (WebCore::Element::getAttributeNode): (WebCore::Element::getAttributeNodeNS): (WebCore::Element::hasAttribute): (WebCore::Element::hasAttributeNS):
• dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItemNS): (WebCore::NamedAttrMap::removeNamedItemNS):
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
• html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
• html/HTMLEmbedElement.h:
• html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument):
• html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::parseMappedAttribute):
• ksvg2/svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::handleTimerEvent):
• ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
• ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
• ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute):
• ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute):
• ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::parseMappedAttribute):
• ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
• ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
• ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute):
• ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
• ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
• ksvg2/svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::parseMappedAttribute):
• ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
• ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute):
• page/Frame.cpp: (WebCore::Frame::selectionComputedStyle):
• rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
• rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderResources):

4:14 PM Changeset in webkit [18427] by eseidel

• 26 adds in trunk/PageLoadTests

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by bradee-oh.

Add new PageLoadTests directory (this one)
Add LICENSES file to explain where each SVG came from.

• ChangeLog: Added.
• svg/LICENSES: Added.
• svg/files/33041-Samurai.svg: Added.
• svg/files/42470-flower_from_my_garden_v2.svg: Added.
• svg/files/Harvey_Rayner.svg: Added.
• svg/files/az-lizard_benji_park_01.svg: Added.
• svg/files/bamboo_01.svg: Added.
• svg/files/cacuts_01.svg: Added.
• svg/files/cowboy.svg: Added.
• svg/files/crawfish2_ganson.svg: Added.
• svg/files/deb9frac1.svg: Added.
• svg/files/food_leif_lodahl_01.svg: Added.
• svg/files/france.svg: Added.
• svg/files/francobollo_gnome_ezechi_02.svg: Added.
• svg/files/gearflowers.svg: Added.
• svg/files/hereGear4.svg: Added.
• svg/files/mtsthelens.svg: Added.
• svg/files/mtsthelens0.jpg: Added.
• svg/files/world-iso.svg: Added.
• svg/files/worldcup.svg: Added.
• svg/svg.pltsuite: Added.

4:12 PM Changeset in webkit [18426] by eseidel

• 1 edit
  1 add in trunk/WebKitTools

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by bradee-oh.

Add very simple run-pageloadtest script for running SVG page load test.

• Scripts/run-pageloadtest: Added.

4:03 PM Changeset in webkit [18425] by zimmermann

• 7 edits in trunk

Reviewed by Oliver.

Add patternContentUnits support, and cleanup SVGPaintServerGradientCg.cpp
Fixes coords-units-01-b.svg

2:10 PM Changeset in webkit [18424] by ggaren

• 11 edits in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance

• bindings/c/c_instance.cpp:
• bindings/c/c_instance.h: Removed unused copy constructor and assignment operator. They made tracking data flow more difficult. Unused code is also dangerous because it can succumb to bit rot with the stealth of a Ninja.

Replaced #include with forward declaration to reduce header dependency.

• bindings/npruntime.cpp: Sorted #includes. (_NPN_GetStringIdentifier): Replaced assert with ASSERT. (_NPN_GetStringIdentifiers): ditto (_NPN_ReleaseVariantValue): ditto (_NPN_CreateObject): ditto (_NPN_RetainObject): ditto (_NPN_ReleaseObject): ditto (_NPN_DeallocateObject): ditto

WebKit:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance

Renamed "installedPlugins" to "sharedDatabase." This better follows
the Cocoa naming scheme, and calls out the key attribute that produced this
crash -- namely, that the database is shared throughout the process.

-installedPlugins is actually a part of SPI, but a global search showed
that it had no users.

• Plugins/WebPluginDatabase.h:
• Plugins/WebPluginDatabase.m: (+[WebPluginDatabase sharedDatabase]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _plugInPaths]): (-[WebPluginDatabase _removePlugin:]):
• WebCoreSupport/WebViewFactory.m: (-[WebViewFactory pluginsInfo]): (-[WebViewFactory refreshPlugins:]): (-[WebViewFactory pluginSupportsMIMEType:]):
• WebView/WebView.mm: (+[WebView _supportedMIMETypes]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): (-[WebView _close]): (-[WebView _pluginForMIMEType:]): (-[WebView _pluginForExtension:]): (-[WebView _isMIMETypeRegisteredAsPlugin:]):

WebKitTools:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance

(dumpRenderTree): Renamed "installedPlugins" to "sharedDatabase."

12:03 PM Changeset in webkit [18423] by eseidel

• 12 edits in trunk/WebCore

2006-12-26 Eric Seidel <​eric@eseidel.com>

Reviewed by ggaren

No test cases changed.

Remove unneeded isPaintingText() and activeClient() from SVGPaintServer system

• platform/graphics/svg/SVGPaintServer.cpp: (WebCore::SVGPaintServer::SVGPaintServer):
• platform/graphics/svg/SVGPaintServer.h:
• platform/graphics/svg/SVGPaintServerGradient.h:
• platform/graphics/svg/SVGPaintServerPattern.h:
• platform/graphics/svg/SVGPaintServerSolid.h:
• platform/graphics/svg/cg/SVGPaintServerCg.cpp: (WebCore::SVGPaintServer::teardown):
• platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
• platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
• platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
• rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
• rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):

10:12 AM Changeset in webkit [18422] by ggaren

• 7 edits in trunk

WebCore:

Reviewed by Adam Roben.

Fixed <rdar://problem/4778898> REGRESSION: crash in getInstanceForView()
when quitting from kcbs.com

No testcase because we can't open and close windows in DRT.

The crash was caused by deallocating plug-ins that were later referenced
in the unload event handler.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::closeDocument): Call didCloseDocument after closing instead of before, so plugins don't get deallocated until the document has been destroyed and all event handlers have fired.

• loader/FrameLoaderClient.h: Renamed "willCloseDocument" to "didCloseDocument", since we call it after closing now.

WebKit:

Reviewed by Adam Roben.

Fixed <rdar://problem/4778898> REGRESSION: crash in getInstanceForView()
when quitting from kcbs.com

No testcase because we can't open and close windows in DRT.

The crash was caused by deallocating plug-ins that were later referenced
in the unload event handler.

• Plugins/WebBaseNetscapePluginView.mm: Don't call stop on ourselves because we may destroy our plugin before the unload handler fires. Also, we don't need to, since didCloseDocument will do it for us.

(-[WebBaseNetscapePluginView addWindowObservers]): We don't need to listen
for windowWillClose anymore, since we don't want to call -stop on ourselves.
(-[WebBaseNetscapePluginView removeWindowObservers]): ditto.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didCloseDocument): Renamed from "willCloseDocument."

8:26 AM Changeset in webkit [18421] by eseidel

• 18 edits
  4 adds in trunk

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Replace bogus SVGLength::isFraction() method with valueAsPercentage() to fix:
​http://bugs.webkit.org/show_bug.cgi?id=11973

• ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::valueInSpecifiedUnits): remove extra spaces (WebCore::SVGLength::valueAsPercentage): new method
• ksvg2/svg/SVGLength.h:
• ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): use valueAsPercentage()
• ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): return if malloc fails
• ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): use valueAsPercentage()
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::createImageBuffer): return 0 if malloc fails
• platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::setup): return if malloc fails
• platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask): add comment about possible crash

Dec 25, 2006:

9:36 PM Changeset in webkit [18420] by ggaren

• 6 edits in trunk/WebKit

More "plugin" => "pluginPackage" renaming that I forgot to check in.

• Plugins/WebBaseNetscapePluginView.h:
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setPluginPackage:]):
• Plugins/WebNetscapePluginEmbeddedView.h:
• Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):

9:24 PM Changeset in webkit [18419] by ggaren

• 2 edits in trunk/WebKit

Reviewed by Eric Seidel.

Fixed crash when opening view source window.

• WebView/WebView.mm: (-[WebView initWithCoder:]): Don't use the WebView until calling _commonInitialization...

7:43 PM Changeset in webkit [22716] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Fixed build. Tsk, tsk, Oliver.

• WebCore.vcproj/WebCore.vcproj:

5:44 PM Changeset in webkit [18418] by zimmermann

• 3 edits
  4 adds in trunk

Reviewed by Oliver.

In the DOMParser class, we have to create content-type specific
documents, instead of a pure "Document" object. Real-life SVG
files us this way to convert strings "<svg><rect x=...></svg>
to a new Document structure.

Add new testcase dynamic-svg-document-creation.svg.

5:30 PM Changeset in webkit [22715] by ggaren

• 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

• WebCore.vcproj/WebCore.vcproj: Added Settings.cpp to the project.

• bridge/win/FrameWin.cpp: Updated to use new preferences names. (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):

• loader/win/FrameLoaderWin.cpp: ditto. (WebCore::FrameLoader::partClearedInBegin):

• plugins/win/PluginViewWin.cpp: ditto. (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

• WebFrame.cpp: (WebFrame::initWithWebFrameView): Used core() here, now that WebView::settings() is gone.

• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Simplified this code, now that WebCore handles most of it.

• WebView.h: Removed settings() accessor. Settings belong to the WebCore page, not the WebView.

5:22 PM Changeset in webkit [18417] by ggaren

• 37 edits
  1 add
  2 deletes in trunk

WebCore:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

• WebCore.exp: Exported Settings for use by WebKit, removed WebCoreSettings class.

• WebCore.xcodeproj/project.pbxproj: Removed WebCoreSetttings.h/.mm. Added Settings.cpp.

• page/Frame.cpp: Removed cruft that duplicated Settings data. Callers now call through to Settings to get Settings data.

• page/Page.cpp: Added Settings data member, to replace the one that WebView used to hold.

• page/Settings.cpp: Added.
• page/Settings.h:
  • Renamed all functions to match WebKit API. Renamed all variables to match functions. Favorite old name: "isPluginsEnabled."
  • Moved EditableLinkBehavior outside of the class. Having it inside just made it harder to type.
  • Merged in old WebCoreSettings functionality, like guarding against re-setting to the same value, and making sure to update page layout.
  • Paired setters and getters, putting setters first.

WebKit:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

• WebView/WebFrame.mm: Added helper functions for converting between WebKitEditableLinkBehavior and WebCore::EditableLinkBehavior. I'm not sure that this is the best place for these functions, but it's where all the other functions like them reside. (core): (kit):
• WebView/WebFrameInternal.h:

• WebView/WebView.mm: Removed uses of WebCoreSettings. Replaced with direct use of underlying page's settings.

4:45 PM Changeset in webkit [18416] by zimmermann

• 5 edits in trunk/WebCore

Reviewed by Oliver.
Fix some minor style issues.

4:37 PM Changeset in webkit [18415] by zimmermann

• 22 edits
  9 adds in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11963
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11123

Fix SVGList JS wrappers, which operate on POD types (ie. Point).
There exists a special JSSVGPODTypeWrapperCreatorForList class now,
which operators on specialized SVGPODList's. It makes it possible
to support stuff like "myList.getItem(0).value = 200", for POD lists.

Adding two new testcases demonstrating the usage of SVG DOM & SVGAnimatedPoints.

2:32 PM Changeset in webkit [18414] by ggaren

• 8 edits in trunk/WebKit

Reviewed by Oliver Hunt.

Some refactoring in preparation for fixing <rdar://problem/4778898>
REGRESSION: crash in getInstanceForView() when quitting from kcbs.com

Two renames:

• "plugin" => "pluginPackage" (since the type is WebNetscapePluginPackage *)
• "instance" and/or "pluginPointer" => plugin (since NPP is an opaque handle to a plug-in)

Removed braces around single-line 'if' statements.

Made plugin a pointer instead of an inline ivar. This allows us to NULL
it out once we call NPP_Destroy on it.

Added helper functions for creating and destroying plugin. The destroy function
NULLs out plugin, which helps with debugging.

(-[WebBaseNetscapePluginView willCallPlugInFunction]): Added an ASSERT
to catch attempts to call functions on destroyed plug-ins.

(-[WebBaseNetscapePluginView _createPlugin]): New helper function.
(-[WebBaseNetscapePluginView _destroyPlugin]): New helper function.

10:37 AM Changeset in webkit [18413] by ap

• 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10313
Reproducible crash when doing importStylesheet in javascript with
xsl files that use xsl:import

This doesn't fully address the bug, but makes a couple of steps
in that direction.

• xml/XSLTProcessor.cpp: (WebCore::transformToString): Set m_stylesheet even if it's created implicitly, rather than passed from outside. Always reset it in the end (this doesn't affect Document::applyXSLTransform(), which was the only user of setXSLStylesheet()).

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the loaded document's URL.

Dec 24, 2006:

10:02 AM Changeset in webkit [18412] by ddkilzer

• 1 edit
  1 delete in trunk/WebKit

2006-12-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

• WebKit/Loader: Removed.

8:46 AM Changeset in webkit [18411] by weinig

• 3 edits in trunk/WebCore

Reviewed by Maciej and Geoff.

• remove unused member variable m_styleSelectorDirty

No test possible (no functionality change)

• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::recalcStyleSelector):
• dom/Document.h:

7:48 AM Changeset in webkit [18410] by weinig

• 3 edits
  8 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

• fast/dom/css-mediarule-deleteRule-update-expected.checksum: Added.
• fast/dom/css-mediarule-deleteRule-update-expected.png: Added.
• fast/dom/css-mediarule-deleteRule-update-expected.txt: Added.
• fast/dom/css-mediarule-deleteRule-update.html: Added.
• fast/dom/css-mediarule-insertRule-update-expected.checksum: Added.
• fast/dom/css-mediarule-insertRule-update-expected.png: Added.
• fast/dom/css-mediarule-insertRule-update-expected.txt: Added.
• fast/dom/css-mediarule-insertRule-update.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

Tests added:

• fast/dom/css-mediarule-deleteRule-update.html
• fast/dom/css-mediarule-insertRule-update.html

• css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):

7:45 AM Changeset in webkit [18409] by rwlbuis

• 2 edits in trunk/WebCore

Reviewed by Alexey.

Get rid of unused variable.

Dec 23, 2006:

11:39 PM Changeset in webkit [18408] by ap

• 5 edits in trunk/LayoutTests

​http://bugs.webkit.org/show_bug.cgi?id=9801
fast/encoding/utf-16-big-endian-diffs.html pixel test fails

• fast/encoding/utf-16-big-endian-expected.checksum:
• fast/encoding/utf-16-big-endian-expected.png:
• fast/encoding/utf-16-little-endian-expected.checksum:
• fast/encoding/utf-16-little-endian-expected.png: Updated the pixel results, which weren't landed with the fix for bug 3297.

11:19 PM Changeset in webkit [18407] by ggaren

• 3 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak.

Added --threaded support to run-webkit-tests and DumpRenderTree.

In "threaded" mode, DRT runs a concurrent JavaScript thread with each test,
stressing the thread safety of JavaScriptCore and the JavaScriptCore/WebCore
interface. This is useful for tracking down bugs you might see on a system
configured to use a PAC file.

Ironically, I can proudly state that very few layout tests pass.

• DumpRenderTree/DumpRenderTree.m: Added javaScriptThread and helper functions for starting and stopping it. (runJavaScriptThread): helper function (startJavaScriptThread): helper function (stopJavaScriptThread): helper function

(dumpRenderTree): Added --threaded command line argument.

• Scripts/run-webkit-tests: ditto

11:09 PM Changeset in webkit [18406] by ap

• 3 edits
  2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11933
REGRESSION: trying to change a property in a computed style declaration results in a crash

Test: fast/dom/computed-style-set-property.html

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): Added a check for null m_impl->stylesheet(). Also, fixed incorrect logic in Dashboard branch - it didn't return in time if removeProperty() raised an exception (credit for noticing this bug goes to Geoff).

7:19 PM Changeset in webkit [18405] by weinig

• 7 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11940
Bad transparency in some cursor pointer images

• Resources/northEastResizeCursor.png:
• Resources/northEastSouthWestResizeCursor.png:
• Resources/northWestResizeCursor.png:
• Resources/northWestSouthEastResizeCursor.png:
• Resources/southEastResizeCursor.png:
• Resources/southWestResizeCursor.png:

4:48 PM Changeset in webkit [18404] by weinig

• 6 edits
  2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

• fast/dom/css-mediarule-functions-expected.txt: Added.
• fast/dom/css-mediarule-functions.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

Test added:

• fast/dom/css-mediarule-functions.html

• bindings/js/kjs_css.cpp: (KJS::DOMCSSRuleFunc::callAsFunction):
• css/CSSMediaRule.cpp: add exception handling (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
• css/CSSMediaRule.h: add ExceptionCode arguments
• css/CSSMediaRule.idl: un-comment exceptions

10:18 AM Changeset in webkit [18403] by hyatt

• 1 edit in trunk/LayoutTests/editing/pasteboard/paste-table-002-expected.txt

Update editing/pasteboard/paste-table-002 results now that the two style decl arrays are in sync.

8:19 AM Changeset in webkit [18402] by ddkilzer

• 3 edits in trunk/LayoutTests

2006-12-23 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Mitz.

Regenerate test results with default fonts installed.

• svg/custom/js-font-test-expected.png: Regenerated.
• svg/custom/js-font-test-expected.txt: Regenerated.

4:39 AM Changeset in webkit [18401] by hyatt

• 3 edits in trunk/WebCore

Fix 11942. The inheritable properties array is duplicated (lame). Make
sure to keep both in sync.

Reviewed by mitz

• css/CSSComputedStyleDeclaration.cpp:
• css/CSSMutableStyleDeclaration.cpp: (WebCore::):

Dec 22, 2006:

10:01 PM Changeset in webkit [18400] by bdash

• 2 edits in trunk/WebKitTools

2006-12-22 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Fix for <rdar://problem/4265976>
prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method

• Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.

6:29 PM Changeset in webkit [22714] by aliceli1

• 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fixed <rdar://4766681> and <rdar://4766685> concerning editable link behavior

• Interfaces/IWebPreferences.idl:
• WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation):
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::editableLinkBehavior): (WebPreferences::setEditableLinkBehavior):
• WebPreferences.h:
• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

4:19 PM Changeset in webkit [18399] by ggaren

• 6 edits
  2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.

Test for <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

Tests an onload handler for a synchronously loaded iframe removing the iframe
from the document.

• fast/frames/onload-remove-iframe-crash-expected.txt: Added.
• fast/frames/onload-remove-iframe-crash.html: Added.

WebCore:

Reviewed by Brady Eidson.

Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createFrame): Updated to reflect the fact that createChildFrameNamed: now returns a WebCore::Frame* instead of a WebCoreFrameBridge *.
• page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady Eidson.

Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
• The fix:

Changed to re-fetch the child frame we're trying to load before returning it,
since its onload handler may have removed it from the document. This
allows us to treat a removed frame like a frame that never loaded.

• Plus some cleanup:
  • Changed to return a WebCore::Frame* instead of a WebFrameBridge *, to simplify some code.
  • Grouped ObjC objects by usage, and moved calls to -release so that they immediately follow the calls that retain.

4:03 PM Changeset in webkit [22713] by adachan

• 2 edits in branches/WindowsMerge/WebCore

2006-12-22 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

Build fix.

3:28 PM Changeset in webkit [18398] by hyatt

• 3 edits in trunk/WebCore

Make sure to actually set the stroke thickness for text decorations.
Covered by bugzilla bug 11921.

Reviewed by mitz

• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):

2:06 PM Changeset in webkit [18397] by thatcher

• 2 edits in tags/WebCore-521.32.1/WebCore

Versioning

2:04 PM Changeset in webkit [18396] by thatcher

• 5 edits in tags/WebCore-521.32.1/WebCore

Merging fix r18328 and r18386.

1:52 PM Changeset in webkit [18395] by thatcher

• 1 copy in tags/WebCore-521.32.1/WebCore

New tag (part 2.)

1:52 PM Changeset in webkit [18394] by thatcher

• 1 add in tags/WebCore-521.32.1

New tag. (part 1).

12:49 PM Changeset in webkit [22712] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

11:35 AM Changeset in webkit [18393] by zimmermann

• 33 edits
  5 adds
  1 delete in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11934

Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList
interface) has live update problems, as the notifyAttributeChange() function
isn't called anywhere. The context param is currently stored per SVGPathSeg,
which is not needed - as it can be done using SVGPathSegList completely. It
wastes memory, that is fixed. In order to get rid of the context param in
SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement*
objects ("context element"). That is done using a new HashMap in the
SVGDocumentExtensions class.

11:26 AM Changeset in webkit [18392] by ap

• 2 edits in trunk/WebCore

2006-12-22 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11903 REGRESSION: outline not drawn if line style is dashed.

This fixes a bunch of existing pixel tests.

• rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):

10:57 AM Changeset in webkit [22711] by sullivan

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker

Renamed stub method name to match change in WebCore

• platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords

10:49 AM Changeset in webkit [18391] by sullivan

• 4 edits in trunk/WebCore

Reviewed by Kevin Decker

• renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition in anticipation of fixing it to work more correctly with grammar checking, where only checking adjacent words isn't good enough.

• editing/Editor.h: renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition

• editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for name change

• editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords and added FIXME comment

9:43 AM Changeset in webkit [18390] by eseidel

• 3 edits
  16 adds in trunk

2006-12-22 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

​http://bugs.webkit.org/show_bug.cgi?id=11912
Overriding visibility does not behave as expected.

• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): allow children to draw when container is visibility='hidden'

8:51 AM Changeset in webkit [18389] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-22 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Steve Winship and Yongjun Zhang.
DESC: TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):

6:11 AM Changeset in webkit [18388] by sullivan

• 5 edits in trunk/WebKit

Reviewed by Geoff Garen

• improved concept and implementation of my previous checkin after discussing with Darin

• WebView/WebViewPrivate.h:
• WebView/WebView.mm: (-[WebView setHoverFeedbackSuspended:]): renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can rework the document architecture and make this kind of thing less hacky (but this is following existing customs, so I don't feel too bad) (-[WebView isHoverFeedbackSuspended]): renamed from ignoresMouseMovedEvents

• WebView/WebHTMLViewInternal.h: declare _hoverFeedbackSuspendedChanged

• WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): test the webView's state of the hit-tested WebHTMLView rather than self (-[WebHTMLView _hoverFeedbackSuspendedChanged]): generate a fake mouse-moved event, which simulates the mouse moving away from the current element or back over it

1:30 AM Changeset in webkit [18387] by zimmermann

• 4 edits
  5 adds in trunk

Reviewed by Rob.

Fix SVGPathSeg JS object creation. SVGPathSegList has to return
the actual SVGPathSegLineToAbs/MoveToRel... object instead of a pure
SVGPathSeg JS object.

Dec 21, 2006:

10:06 PM Changeset in webkit [22710] by wallis

• 1 edit in branches/WindowsMerge/WebKitWin/WebView.cpp

Print by spooling PDF

9:53 PM Changeset in webkit [18386] by bdakin

• 10 edits
  2 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4897162> REGRESSION: Attempting to create a
new message in .Mac web mail causes Safari to crash
( KJS::DOMCSSStyleDeclaration::put() + 368 )

This was a regression from my clone-node change. This fix is very
simple.

• dom/StyledElement.cpp: (WebCore::StyledElement::copyNonAttributeProperties): Must set the data that getInlineStyleDecl() points to instead of setting m_inlineStyleDecl directly. I also changed some variable names.
• dom/StyledElement.h: Don't need parameter name here.

Layout Tests:

Reviewed by Beth. (Geoff wrote the new test.)

New test for <rdar://problem/4897162>. This also reverts the layout
test changes that were caused by the first rev of the clone-node
style change.

• editing/style/remove-underline-across-paragraph-expected.checksum:
• editing/style/remove-underline-across-paragraph-expected.png:
• editing/style/remove-underline-across-paragraph-expected.txt:
• editing/style/remove-underline-expected.checksum:
• editing/style/remove-underline-expected.png:
• editing/style/remove-underline-expected.txt:
• fast/dom/clone-node-style-expected.txt: Added.
• fast/dom/clone-node-style.html: Added.

9:46 PM Changeset in webkit [22709] by wallis

• 1 edit in branches/WindowsMerge/WebKitWin/WebView.h

Print by spooling PDF

9:46 PM Changeset in webkit [22708] by wallis

• 1 edit in branches/WindowsMerge/WebKitWin/Interfaces/IWebViewPrivate.idl

Print by spooling PDF

6:20 PM Changeset in webkit [18385] by bdash

• 2 edits in trunk/WebKitTools

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Tim Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=11922
Bug 11922: REGRESSION(r17128): Drosera no longer shows local variables in stack frame

• Drosera/DebuggerDocument.m: (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): Use an anonymous function with function.call to ensure that the properties are being retrieved from the correct scope object.

5:53 PM Changeset in webkit [18384] by adele

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

• fast/events/onsearch-enter-expected.txt: Added.
• fast/events/onsearch-enter.html: Added.

WebCore:

Reviewed by Geoff.

• Fix for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

Test: fast/events/onsearch-enter.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls onSearch when handling "Enter". Also removed special case for AppKit search fields, so now the enter event is considered handled here. (WebCore::HTMLInputElement::onSearch): Added. Dispatches search event.
• html/HTMLInputElement.h: Added onSearch.
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::onSearch): Calls onSearch on the node.

5:26 PM Changeset in webkit [18383] by darin

• 2 edits in trunk/WebKit

Reviewed by Oliver.

• WebInspector/webInspector/inspector.js: Added default values for the new CSS properties so they don't appear in the inspector when their values are uninteresting.

4:03 PM Changeset in webkit [22707] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:56 PM Changeset in webkit [18382] by sfalken

• 1 copy in tags/Safari-521.32.7b

New tag.

3:02 PM Changeset in webkit [18381] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Geoff Garen

• added WebKit support for making a web page temporarily ignore mouse movements

• WebView/WebViewPrivate.h: declare ignoresMouseMovedEvents and setIgnoresMouseMovedEvents:

• WebView/WebView.mm: added ignoresMouseMovedEvents boolean field to _private data structure (-[WebView setIgnoresMouseMovedEvents:]): set new boolean field (-[WebView ignoresMouseMovedEvents]): return new boolean field

• WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): bail out right away if [[self _webView] ignoresMouseMovedEvents]

2:39 PM Changeset in webkit [18380] by ggaren

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.

<rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

Test for adding an iframe to the document from another iframe's onload handler.

• fast/loader/iframe-recursive-synchronous-load-expected.txt: Added.
• fast/loader/iframe-recursive-synchronous-load.html: Added.

WebCore:

Reviewed by Brady Eidson.

Fixed <rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

I added that assertion to try to "keep things simple," but I've found a
testcase that demonstrates why things need to be complicated.

• dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback):

2:37 PM Changeset in webkit [18379] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-21 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
​http://bugs.webkit.org/show_bug.cgi?id=11881

• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

2:25 PM Changeset in webkit [18378] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-21 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
​http://bugs.webkit.org/show_bug.cgi?id=11881

• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

12:16 PM Changeset in webkit [18377] by ap

• 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11919
Allow setting CSS values to null.

WebCore:

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): Convert null values to null strings.

LayoutTests:

• fast/dom/css-set-property-exception-expected.txt:
• fast/dom/css-set-property-exception.html:

11:45 AM Changeset in webkit [18376] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=11898
CSSMediaRule functions insertRule and deleteRule assert when called from js in debug builds

Test explicitly for the two media rule functions so it ends up calling callAsFunction.

5:46 AM Changeset in webkit [18375] by lars

• 15 edits
  19 adds in trunk

Add support for the layoutTestController JavaScript object
to be able to get textOnly dumps.
Added a Qt specific hack to always get the same fonts (the ones
added in this submit) and the same dpi when running the layout tests.
Modified the run-webkit-tests script to also do a comparison to the
Mac generated outputs (by stripping out positioning information).

12:08 AM Changeset in webkit [18374] by bdash

• 4 edits in trunk

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

• WebInspector/webInspector/inspector.js: Use removeProperty to reset a style property to its initial value. Bail out early from updateNodePane if Inspector has not yet been set.

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

• Drosera/debugger.js: Use removeProperty to reset a style property to its initial value.

Dec 20, 2006:

11:53 PM Changeset in webkit [18373] by hyatt

• 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Land updated results for computed style test.

11:41 PM Changeset in webkit [18372] by hyatt

• 3 edits in trunk/WebCore

Make sure the execrable match-nearest-mail-blockquote-color CSS property is actually initialized (amazingly
it started off with the value "match", since it wasn't even initialized). Now that it is actually being
initialized and properly copied and assigned to, tests have failed. It seems that we were getting the
behavior of "match" by default, when the initial value was supposed to be "normal."

Because this property really should not exist at all, it's unclear to me what the right solution is here.

• rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
• rendering/RenderStyle.h:

9:43 PM Changeset in webkit [18371] by beidson

• 2 edits in trunk/WebCore

Reviewed by Adam's rubberstamp

Accidentally left a logging channel on in my checkin

• platform/Logging.cpp: (WebCore::):

8:13 PM Changeset in webkit [22706] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Mark Rowe.

Fix: <rdar://4895655> Status bar doesn't display correct text when
WebView is scrolled.

• WebView.cpp: (WebView::handleMouseEvent): Convert the event coordinates to document coordinates before calling elementAtPoint.

5:42 PM Changeset in webkit [18370] by zimmermann

• 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix removeItem recursively calling itself (!). It was meant to call m_vector.remove(index)
not removeItem(index, ec). This bug is in SVN for quite some time now :-)

5:29 PM Changeset in webkit [18369] by harrison

• 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4893376> REGRESSION: Crash occurs at WebCoreFrameBridge fontForSelection: when drag selecting from a line break

No layout test added because crash only happens in path where editing window is key,
which is never the case for the automated tests.

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]): Add nil check of fontForSelection() result.

4:53 PM Changeset in webkit [18368] by zimmermann

• 6 edits
  4 adds in trunk/LayoutTests

Reviewed by Adam.

Adding new test js-update-style.svg, testing
dynamic style updates via JS (here: stroke-width change)

Setting eol-style native property for all the js-update*.svg
files, as requested by Adam.

4:50 PM Changeset in webkit [22705] by aroben

• 3 edits in branches/WindowsMerge/WebCore

4:26 PM Changeset in webkit [18367] by zimmermann

• 1 edit
  4 adds in trunk/LayoutTests

Reviewed by Beth.

Adding new test js-update-pattern.svg, testing
dynamic pattern updates via JS.

4:13 PM Changeset in webkit [18366] by zimmermann

• 6 edits in trunk

Reviewed by Maciej.

Fix dynamic gradient changes, via JS. It actually worked before, but it
wasn't repainted. Behave just like the pattern notifyAttributeChange() code now.

3:57 PM Changeset in webkit [18365] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

3:09 PM Changeset in webkit [18364] by zimmermann

• 1 edit
  24 adds in trunk/LayoutTests

Reviewed by Sam.
Add a new set of SVG JavaScript testcases, mostly using SVG DOM.

2:54 PM Changeset in webkit [18363] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-20 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin and Yongjun.
DESC: Links on sonera.fi when loaded opens toolbar.
​http://bugs.webkit.org/show_bug.cgi?id=11843

• BrowserView/inc/KeyEventHandler.h:
• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):

2:43 PM Changeset in webkit [18362] by yongjzha

• 3 edits in S60/branches/3.1m/WebKit

2006-12-20 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun & Sachin.
DESC: Links on www.sonera.fi don't work and open floating Toolbar
​http://bugs.webkit.org/show_bug.cgi?id=11843

• BrowserView/inc/KeyEventHandler.h:
• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):

2:34 PM Changeset in webkit [22704] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Remove line width setting in font rendering now that GraphicsContext sets
it for us.

• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

2:30 PM Changeset in webkit [18361] by hyatt

• 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Update computed style layout test results.

2:25 PM Changeset in webkit [18360] by hyatt

• 7 edits in trunk/WebCore

Fix SVG stroking. Make strokeThickness() get pushed into CG immediately
when set in the GraphicsContext. Remove setLineWidth since it is
redundant with setStrokeThickness now.

Reviewed by mitz

• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth):
• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle):
• platform/graphics/GraphicsContext.h:
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::setPlatformStrokeThickness):
• platform/graphics/qt/GraphicsContextQt.cpp:
• platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):

1:55 PM Changeset in webkit [18359] by hyatt

• 4 edits in trunk/WebCore

Fix for bug 11893, white text on form controls. Just make sure that
all form control drawing in RenderTheme is bracketed by save/restore
calls.

Reviewed by adele

• platform/mac/LocalCurrentGraphicsContext.h:
• platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):

1:54 PM Changeset in webkit [18358] by bdash

• 2 edits in trunk/WebCore

2006-12-20 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

Fix leak of CGContextRef from GraphicsContext::createImageBuffer.

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::createImageBuffer): Release newly-created CGContextRef after passing it to GraphicsContext.

1:28 PM Changeset in webkit [18357] by bdakin

• 4 edits in trunk/LayoutTests

Rubber-stamped by Darin.

This test also needs updated results after my clone node check-in.
Somehow, the fix to clone node eliminated the dummy spans in both
of these tests. This is an improvement.

• editing/style/remove-underline-expected.checksum:
• editing/style/remove-underline-expected.png:
• editing/style/remove-underline-expected.txt:

12:25 PM Changeset in webkit [18356] by andersca

• 2 edits in trunk/JavaScriptCore

• kjs/string_object.cpp: (localeCompare): Another speculative Win32 fix.

12:20 PM Changeset in webkit [18355] by andersca

• 2 edits in trunk/JavaScriptCore

• kjs/string_object.cpp: (localeCompare): Speculative Win32 fix.

12:11 PM Changeset in webkit [18354] by andersca

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4235733>
<​http://bugs.webkit.org/?show_bug.cgi?id=10193>
support String.localeCompare.

Implement localeCompare.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/string_object.cpp: (localeCompare): (StringProtoFunc::callAsFunction):
• kjs/string_object.h: (KJS::StringProtoFunc::):

11:20 AM Changeset in webkit [18353] by thatcher

• 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

• JavaScriptCore.xcodeproj/project.pbxproj: use GCC 4.0 for all the other test targets

10:54 AM Changeset in webkit [18352] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4871993> WebCore-421.31 build fails with "Public API change" error when gcc 3.3 is the default compiler

• bindings/scripts/CodeGeneratorObjC.pm: ignore blank lines in the public API check

10:50 AM Changeset in webkit [18351] by bdakin

• 4 edits in trunk/LayoutTests

Rubber stamped by Darin.

Updated results for this test after my clone node check-in
yesterday.

• editing/style/remove-underline-across-paragraph-expected.checksum:
• editing/style/remove-underline-across-paragraph-expected.png:
• editing/style/remove-underline-across-paragraph-expected.txt:

10:41 AM Changeset in webkit [18350] by harrison

• 2 edits in trunk/LayoutTests

Updated for Justin's checkin that added properties.

• fast/dom/Window/window-properties-expected.txt:

10:36 AM Changeset in webkit [18349] by thatcher

• 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/4871613> JavaScriptCore-421.31's dftables target needs to override default compiler and use gcc-4.0

• JavaScriptCore.xcodeproj/project.pbxproj:

10:31 AM Changeset in webkit [18348] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

​http://bugs.webkit.org/show_bug.cgi?id=11886

• BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):

10:25 AM Changeset in webkit [18347] by spadma

• 2 edits in S60/trunk/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

​http://bugs.webkit.org/show_bug.cgi?id=11886

• BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):

8:14 AM Changeset in webkit [18346] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-19 vbradley <​vincent.bradley@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com
DESC: TSW ID: IRON-6WAAWZ. crash on aol.co.uk
​http://bugs.webkit.org/show_bug.cgi?id=11875

• BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):

7:40 AM Changeset in webkit [18345] by harrison

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

Test for <rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

• editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
• editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
• editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
• editing/deleting/delete-to-end-of-paragraph.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

Test:

• editing/deleting/delete-to-end-of-paragraph.html

• editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed): If the selection was a caret at the end of the paragraph, extend selection so it wraps to the start of next paragraph (if any),

6:16 AM Changeset in webkit [18344] by zimmermann

• 2 edits in trunk/WebCore

Build fix, reviewed by Mitz.
Fix mac build, by using proper float -> int conversion.

3:32 AM Changeset in webkit [18343] by hyatt

• 1 edit in trunk/WebCore/rendering/InlineTextBox.cpp

Fix warning on buildbot on mac.

3:16 AM Changeset in webkit [18342] by hyatt

• 3 edits
  4 adds in trunk

Make sure text decoration colors prefer stroke over fill (and honor both of the new CSS properties added
for these values over color).

Reviewed by mitz

Added fast/text/stroking-decorations.html

• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
• rendering/RenderObject.cpp: (WebCore::decorationColor): (WebCore::RenderObject::getTextDecorationColors):

3:05 AM Changeset in webkit [18341] by ddkilzer

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

• editing/selection/move-begin-end-expected.txt: Updated editing delegate results.
• fast/forms/onselect-textarea-expected.txt: Updated selection start/end positions.
• fast/forms/textarea-initial-caret-position-expected.txt: Added.
• fast/forms/textarea-initial-caret-position.html: Added.
• fast/forms/textarea-no-scroll-on-blur.html: Updated to position caret at end of text to match previous initial focus behavior for this test.
• fast/forms/textarea-scrollbar.html: Ditto.
• fast/forms/textarea-scrolled-endline-caret.html: Ditto.
• fast/forms/textarea-scrolled-type.html: Ditto.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

Set caret at beginning of text on initial focus.

Test: fast/forms/textarea-initial-caret-position.html

• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):

2:40 AM Changeset in webkit [22703] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Add support for stroking and filling of text to CSS. Boomer side. Same code as in FontMac.

• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

2:31 AM Changeset in webkit [18340] by hyatt

• 13 edits
  4 adds in trunk

Fix for bug 11889, support stroking and filling of HTML text from CSS. This patch adds four new CSS properties:
text-fill-color, text-stroke-color, text-stroke-width and text-stroke (a shorthand for the other two). Text
is filled and not stroked by default and does so using the text-fill-color. If this property is not set, then
color is used.

Stroking is accomplished by setting a stroke width. Stroke color, if omitted, will be picked up from the color
property. You can set either color to be transparent or partially transparent. A fully transparent fill color is
the way to achieve an "outline" effect where only stroking happens.

Stroking and filling are both customizable inside the ::selection pseudo-element, and so when selecting you can
vary colors and widths.

text-shadow applies to both the stroke and the fill.

text-decorations do not yet respect the stroke/fill colors. This will follow in a later patch.

Reviewed by mitz

Added fast/text/stroking.html as a layout test. Enhanced RenderTreeAsText.cpp to dump fill and stroke information.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSPropertyNames.in:
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
• rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
• rendering/InlineTextBox.cpp: (WebCore::updateGraphicsContext): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
• rendering/RenderObject.cpp: (WebCore::RenderObject::selectionForegroundColor):
• rendering/RenderStyle.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff):
• rendering/RenderStyle.h: (WebCore::RenderStyle::textStrokeColor): (WebCore::RenderStyle::textStrokeWidth): (WebCore::RenderStyle::textFillColor): (WebCore::RenderStyle::setTextStrokeColor): (WebCore::RenderStyle::setTextStrokeWidth): (WebCore::RenderStyle::setTextFillColor): (WebCore::RenderStyle::initialTextStrokeWidth):
• rendering/RenderTreeAsText.cpp: (WebCore::operator<<):

2:05 AM Changeset in webkit [18339] by lars

• 4 edits
  9 adds in trunk/JavaScriptCore

Added support to bind QObject's to JavaScript.

Dec 19, 2006:

11:18 PM Changeset in webkit [18338] by adele

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Anders.

Test for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

• editing/selection/select-all-user-select-none-expected.txt: Added.
• editing/selection/select-all-user-select-none.html: Added.

WebCore:

Reviewed by Anders.

• Fix for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

Also made user-select:none work on new list boxes, and cleaned up the list box defaultEventHandler.

Test: editing/selection/select-all-user-select-none.html

• editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Make sure canSelect is true on the root renderer.
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): Check canSelect here. (WebCore::HTMLSelectElement::selectAll): Added nil check for renderer. (WebCore::HTMLSelectElement::defaultEventHandler): Return early if the event has been handled. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Check canSelect here.
• html/HTMLSelectElement.h:

10:52 PM Changeset in webkit [18337] by andersca

• 6 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Add -p option to testkjs which pretty prints the files instead of executing them.

• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/Parser.cpp: (KJS::Parser::prettyPrint):
• kjs/Parser.h:
• kjs/testkjs.cpp: (doIt):

10:22 PM Changeset in webkit [18336] by andersca

• 2 edits in trunk

Fix bug numbers (Thanks Mitz!)

10:00 PM Changeset in webkit [18335] by andersca

• 3 edits
  3 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4726407>
[9A255] Crash in WebCore::EventTargetNode::dispatchEvent

• fast/dom/resources/script-element-gc.js: Added.
• fast/dom/script-element-gc-expected.txt: Added.
• fast/dom/script-element-gc.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4726407>
[9A255] Crash in WebCore::EventTargetNode::dispatchEvent

• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::notifyFinished): Ref the script element while running the script since it can be freed when executing the script.

6:53 PM Changeset in webkit [22702] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

6:46 PM Changeset in webkit [18334] by sfalken

• 1 copy in tags/Safari-521.32.5b

New tag.

5:49 PM Changeset in webkit [18333] by darin

• 5 edits in trunk/WebCore

Reviewed by Geoff.

• <rdar://problem/4885227> frame resizing is now live and no longer does direct drawing

• html/HTMLFrameSetElement.h: Made frameBorder() and noResize() const. Added rowLengths() and colLengths() getters so that we don't have to have RenderFrameSet as a friend. Stopped using bit fields.

• html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Removed now-uneeded check for contextmenu events. Look at return value from userResize to decide whether to mark the event as "default handled". In the case where the event is handled, don't call through to the base class.

• rendering/RenderFrameSet.h: No longer mark HTMLFrameSetElement as a friend. Made positionFrames and canResize private, and changed canResize to take an IntPoint. Added isResizingRow, isResizingColumn, canResizeRow, and canResizeColumn functions to be used soon for cursor feedback. Removed override of non-virtual element() function and replaced it with a private frameSet() inline function. Grouped all the data members for each axis into a GridAxis class, and made one called m_cols and one called m_rows. Used vectors for the resizable bits of this instead of new/delete arrays. Added a constant named "noSplit" so we don't have to use -1 everywhere explicitly for this purpose. Renamed setResizing to setIsResizing and made it private. Eliminated resizing() function. Added new private helper functions, layOutAxis, findNonResizableSplits, splitPosition, hitTestSplit, startResizing, and continueResizing. Renamed m_resizing to m_isResizing, and m_clientResizing to m_isChildResizing.

• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): Removed now-unneeded initialization that is handled by the GridAxis and Vector constructors. (WebCore::RenderFrameSet::~RenderFrameSet): Ditto (for destructors). (WebCore::RenderFrameSet::GridAxis::GridAxis): Added. (WebCore::RenderFrameSet::frameSet): Added. Inline function so we don't have to cast the result of node() or element() everywhere. (WebCore::RenderFrameSet::nodeAtPoint): Updated for name changes. (WebCore::RenderFrameSet::GridAxis::resize): Added. Helper function to be used in the layout function. (WebCore::RenderFrameSet::layOutAxis): Added. Factored out the part of the layout function that used to be inside a for loop for the two axes. The algorithm is otherwise unchanged. (WebCore::RenderFrameSet::findNonResizableSplits): Added. Factored out the code that set up the "split variable" arrays from the layout function. (WebCore::RenderFrameSet::layout): Moved the bulk of this function into the new helpers. This allowed me to remove the use of goto. (WebCore::RenderFrameSet::positionFrames): Updated for change to data structures. Also added some more local variables for clarity. (WebCore::RenderFrameSet::startResizing): Added. Code factored out of the userResize function that handles mousedown events that might begin a resize. (WebCore::RenderFrameSet::continueResizing): Added. Code factored out of the userResize function that handles mouse events that continue a resize already in progress, including mouseup events that end the resizing. Uses the new splitPosition function so it can be used over and over again while resizing. (WebCore::RenderFrameSet::userResize): Restructured to use the new helper functions. Removed the direct drawing of a gray bar during mouse movement; instead we do the resizing live. (WebCore::RenderFrameSet::setIsResizing): Updated for name changes. (WebCore::RenderFrameSet::isResizingRow): Added. (WebCore::RenderFrameSet::isResizingColumn): Added. (WebCore::RenderFrameSet::canResize): Changed to use hitTestSplit for clarity. (WebCore::RenderFrameSet::canResizeRow): Added. (WebCore::RenderFrameSet::canResizeColumn): Added. (WebCore::RenderFrameSet::splitPosition): Added. (WebCore::RenderFrameSet::hitTestSplit): Added. Contains the guts of the code that was used both in canResize and userResize before -- now it's shared. (WebCore::RenderFrameSet::dump): Updated for name changes.

5:37 PM Changeset in webkit [22701] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

In r11349 I accidentally checked in my local change to the user agent.
Here I am changing it back to what it used to be.

• WebView.cpp: (WebView::userAgentForKURL):

5:16 PM Changeset in webkit [18332] by justing

• 6 edits
  6 adds in trunk

LayoutTests:

Reviewed by harrison

Added Selection::removeAllRanges() and ::addRange()

• editing/selection/addRange-expected.checksum: Added.
• editing/selection/addRange-expected.png: Added.
• editing/selection/addRange-expected.txt: Added.
• editing/selection/addRange.html: Added.
• editing/selection/removeAllRanges-expected.txt: Added.
• editing/selection/removeAllRanges.html: Added.

WebCore:

Reviewed by harrison

Added Selection::removeAllRanges() and ::addRange()

• bindings/js/kjs_window.cpp: (KJS::SelectionFunc::callAsFunction): Added the bindings for the two new functions.
• bindings/js/kjs_window.h: (KJS::Selection::):
• editing/SelectionController.cpp: (WebCore::SelectionController::removeAllRanges): Equivalent to clear(). (WebCore::SelectionController::addRange): Until we support discontiguous selections, the new selected range is the union of the old selected range and the passed range if the two intersect, and the old range if they don't.
• editing/SelectionController.h:

5:07 PM Changeset in webkit [18331] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• fix for unrepro infinite recursion bug: <rdar://problem/4448181> CrashTracer: 154 crashes in Safari at com.apple.AppKit: -[NSView isDescendantOf:] + 24; infinite recursion in makeFirstResponder logic

• WebView/WebView.mm: added becomingFirstResponder BOOL to private struct (-[WebView becomeFirstResponder]): use _private->becomingFirstResponder to guard against infinite recursion; complain on debug builds if we run into this problem

5:06 PM Changeset in webkit [22700] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:59 PM Changeset in webkit [18330] by sfalken

• 1 copy in tags/Safari-521.32.4b

New tag.

4:46 PM Changeset in webkit [22699] by aliceli1

• 2 edits
  2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

<rdar://problem/4796729> add "deleteButton" image resource

• WebKit.vcproj/WebKit.rc:
• WebKit.vcproj/deleteButton.png: Added.
• WebKit.vcproj/deleteButtonPressed.png: Added.

4:41 PM Changeset in webkit [18329] by oliver

• 4 edits in trunk/LayoutTests

m2006-12-19 Oliver Hunt <​oliver@apple.com>

rs=ggaren.
Fix expected output of layout test to not rely on ms fonts

• svg/custom/js-font-test-expected.checksum:
• svg/custom/js-font-test-expected.png:
• svg/custom/js-font-test-expected.txt:

4:32 PM Changeset in webkit [18328] by bdakin

• 6 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4860924> outerHTML gives an out-of-date
result when applied to a clone

We were only copying the m_inlineStyleDecl over to clones, but we
need to copy m_isStyleAttributeValid and
m_synchronizingStyleAttribute as well to know when we have to
update style, etc.

• dom/StyledElement.cpp: (WebCore::StyledElement::copyNonAttributeProperties): Copy over all three member variables.
• dom/StyledElement.h:
• html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode): No longer need to copy the inline style decl explicitly because copyNonAttributeProperties() will take care of it.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Call into parent class implementation. This is important now that there is more than one implementation of this function.

4:20 PM Changeset in webkit [22698] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-19 Steve Falkenburg <​sfalken@apple.com>

Remove non-existent header from vcproj

• WebCore.vcproj/WebCore.vcproj:

3:44 PM Changeset in webkit [22697] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam, Darin.

<rdar://problem/4769830>
logging to JS console.

Add isError argument to addMessageToConsole.

• Interfaces/IWebUIDelegatePrivate.idl:
• WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):

3:39 PM Changeset in webkit [18327] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11880
REGRESSION (r18304): Assertion failure in -[WebHTMLView _canProcessDragWithDraggingInfo:]
when dragging over the window's a scroll bar (innerFrame)

RenderLayer needs to check 'active,' when deciding what to do if hit testing
hasn't hit anything, because we want the default hit testing mechanism to return the
document when we hit a scrollbar.

This problem shows that the idea of 'capturing' was a little too ambitious
in hit testing, at least given the current state of things. So, I've replaced
'capturing' with 'mouseUp,' the condition that provided the immediate need
for the capturing flag in the first place.

• page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
• rendering/HitTestRequest.h: Removed 'capturing' (WebCore::HitTestRequest::HitTestRequest):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

3:23 PM Changeset in webkit [22696] by beidson

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada

-Changed CFNetwork debugging output to use a logging channel
-Added the url to each logging message - the debugging output was quite crippled without this

3:08 PM Changeset in webkit [18326] by beidson

• 6 edits in trunk

JavaScriptCore:

Rubberstamped by Lou

Removed unneccessary "else"

• wtf/Assertions.cpp:

WebCore:

Reviewed by Ada

Added a logging channel for network activity for loader work

• platform/Logging.cpp: (WebCore::):
• platform/Logging.h:
• platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

2:06 PM Changeset in webkit [18325] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by hyatt

<rdar://problem/4888891>
Docs & Spreadsheets: Comment fails to insert if text is selected in the document

• fast/dom/Range/surroundContents-1-expected.checksum: Added.
• fast/dom/Range/surroundContents-1-expected.png: Added.
• fast/dom/Range/surroundContents-1-expected.txt: Added.
• fast/dom/Range/surroundContents-1.html: Added.

WebCore:

Reviewed by hyatt

<rdar://problem/4888891>
Docs & Spreadsheets: Comment fails to insert if text is selected in the document

• dom/Range.cpp: (WebCore::Range::surroundContents): If startContainer is a text node, it will be split when the range is extracted, and it will be its parent that will have to accept newParent. Also cleaned up some code with isDescendantOf.

2:00 PM Changeset in webkit [22695] by sfalken

• 4 edits in branches/WindowsMerge/WebKitWin

2006-12-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou, Adele.

Added CLSID for WebPreferences

• Interfaces/WebKit.idl:
• WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
• WebKitDLL.cpp: (DllGetClassObject):

1:43 PM Changeset in webkit [18324] by thatcher

• 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

• JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

• JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

• WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

• WebKit.xcodeproj/project.pbxproj:

1:38 PM Changeset in webkit [18323] by zimmermann

• 3 edits
  4 adds in trunk

Reviewed by Oliver.
Fix SVGList index validation (off-by-one error).

Adding new testcase js-font-test.svg, which uses SVGLengthList interface.
(This is a very old ksvg1 testcase, adopted for SVG1.1)

12:40 PM Changeset in webkit [22694] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4876963>
Crash launching Boomer after all options deselected in pref->security

• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Add check for JavaScript.

12:17 PM Changeset in webkit [18322] by zimmermann

• 7 edits in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11879
Fix pattern on stroke/fill of text.

11:59 AM Changeset in webkit [22693] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker.

Add (currently disabled) plugin quirks. This is necessary in order to get the Flash plugin
to request windowless plugins (which it only will do if it think it's running on a Mozilla browser).

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin):
• plugins/win/PluginViewWin.h: (WebCore::):
• plugins/win/npapi.cpp: (NPN_UserAgent):

11:58 AM Changeset in webkit [18321] by aliceli1

• 2 edits in trunk/WebCore

Build fix

• platform/graphics/ImageBuffer.cpp:

11:46 AM Changeset in webkit [22692] by beidson

• 2 edits in branches/WindowsMerge/WebCore

Change by Lou, reviewed by Brady

Scrolling caused Desktop flickering as well as other strange
flickering in the case of a missing plug-in

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd):

10:56 AM Changeset in webkit [18320] by ap

• 7 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7296
JavaScript error not thrown when trying to set a CSS property to an invalid value

WebCore:

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): When not in Dashboard compatibility mode, raise exception for invalid values. Also removed an unnecessary call to removeProperty(), which prevented the property value from being preserved in error case.

• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Moved the handling of empty property values here. Also removed an unnecessary call to removeProperty().

LayoutTests:

• fast/block/positioning/relayout-on-position-change.html: This test was setting position property to an invalid value, expecting that it will be removed. Changed it to set the property to an empty value (now the test passes in Firefox, too).

• fast/dom/css-set-property-exception-expected.txt:
• fast/dom/css-set-property-exception.html: Updated the results, added a new case and made the output more verbose.

10:49 AM Changeset in webkit [22691] by andersca

• 2 edits in branches/WindowsMerge/WebCore

• WebCore.vcproj/WebCore.vcproj: Update for SVG changes.

10:45 AM Changeset in webkit [18319] by andersca

• 3 edits in trunk/WebCore

Reviewed by Adam.

• dom/Document.h:
• page/EventHandler.h: Use correct forward declarations for HitTestRequest.

10:41 AM Changeset in webkit [18318] by spadma

• 8 edits
  2 adds in S60/trunk/WebKit

2006-12-14 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin and Zalan.
DESC: Bug 11834: TLUU-6VJQX3 : Cache cannot support more than one application simultaneously
​http://bugs.webkit.org/show_bug.cgi?id=11834

• ChangeLog:
• ResourceLoader/CacheInc/HttpCacheEntry.h:
• ResourceLoader/CacheInc/HttpCacheHandler.h:
• ResourceLoader/CacheInc/HttpCacheLookupTable.h:
• ResourceLoader/CacheInc/HttpCacheObserver.h: Added. (NONSHARABLE_CLASS):
• ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Accessed):
• ResourceLoader/CacheSrc/HttpCacheHandler.cpp: (CHttpCacheHandler::ConstructL): (CHttpCacheHandler::~CHttpCacheHandler): (CHttpCacheHandler::OpenLookupTableL): (CHttpCacheHandler::SaveLookupTableL): (CHttpCacheHandler::UpdateLookupTable): (CHttpCacheHandler::UpdateLookupTableL):
• ResourceLoader/CacheSrc/HttpCacheLookupTable.cpp:
• ResourceLoader/CacheSrc/HttpCacheObserver.cpp: Added. (CHttpCacheObserver::CHttpCacheObserver): (CHttpCacheObserver::ConstructL): (CHttpCacheObserver::NewL): (CHttpCacheObserver::~CHttpCacheObserver): (CHttpCacheObserver::RunL): (CHttpCacheObserver::RunError): (CHttpCacheObserver::DoCancel): (CHttpCacheObserver::StartObserver):
• group/BrowserCache.mmp:

10:36 AM Changeset in webkit [18317] by spadma

• 8 edits
  2 adds in S60/branches/3.1m/WebKit

2006-12-14 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin and Zalan.
DESC: Bug 11834: TLUU-6VJQX3 : Cache cannot support more than one application simultaneously
​http://bugs.webkit.org/show_bug.cgi?id=11834

• ChangeLog:
• ResourceLoader/CacheInc/HttpCacheEntry.h:
• ResourceLoader/CacheInc/HttpCacheHandler.h:
• ResourceLoader/CacheInc/HttpCacheLookupTable.h:
• ResourceLoader/CacheInc/HttpCacheObserver.h: Added. (NONSHARABLE_CLASS):
• ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::~CHttpCacheEntry): (CHttpCacheEntry::SetSize): (CHttpCacheEntry::Internalize): (CHttpCacheEntry::Externalize): (CHttpCacheEntry::Accessed):
• ResourceLoader/CacheSrc/HttpCacheHandler.cpp: (CHttpCacheHandler::ConstructL): (CHttpCacheHandler::~CHttpCacheHandler): (CHttpCacheHandler::OpenLookupTableL): (CHttpCacheHandler::SaveLookupTableL): (CHttpCacheHandler::DoBackgroundSave): (CHttpCacheHandler::UpdateLookupTable): (CHttpCacheHandler::UpdateLookupTableL):
• ResourceLoader/CacheSrc/HttpCacheLookupTable.cpp:
• ResourceLoader/CacheSrc/HttpCacheObserver.cpp: Added. (CHttpCacheObserver::CHttpCacheObserver): (CHttpCacheObserver::ConstructL): (CHttpCacheObserver::NewL): (CHttpCacheObserver::~CHttpCacheObserver): (CHttpCacheObserver::RunL): (CHttpCacheObserver::RunError): (CHttpCacheObserver::DoCancel): (CHttpCacheObserver::StartObserver):
• group/BrowserCache.mmp:

7:09 AM Changeset in webkit [18316] by zimmermann

• 3 edits in trunk/WebCore

Build fix, not reviewed.

Fix Qt/Linux build. Missing GraphicsContext.h include.
Fix Mac build, by adding lroundf() (I swear this compiled w/o that, locally :-)

6:51 AM Changeset in webkit [18315] by zimmermann

• 27 edits
  4 adds
  3 deletes in trunk

Reviewed by Sam. Previous attempts reviewed by Oliver & Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11867

Bring back masking, by adding off-screen rendering functionality in GraphicsContext.
Add new "static GraphicsContext* createImageContext(const IntSize& size, bool grayScale)"
function, and implement it with CGBitmapContext in the GraphicsContextCG (stubs for Qt.)

Mask image sizes are dynamically calculated using the passed bounding box in applyMask,
as it was orignally planned. Gradient stroke mask image sizes aren't hardcoded to 2048x2048
anymore, but are as well dynamically calculated using getAbsoluteRepaintRect().

Add new ImageBuffer class encapsulating the size of the image, a platform-specific
handle (ie. CGImageRef for CG platform) plus the GraphicsContext pointer, obtained
via GraphicsContext::createImageBuffer. Offer a generic logic for rendering subtrees
of the rendering tree into a ImageBuffer (see renderSubtreeToImage function)
ImageBufferCG is completly implemented, ImageBufferQt is stubbed.

Also add correct default values for x/y/width/height of <mask>.
Fixes masking related LayoutTests, and speeds up gradient-on-stroke a lot.

3:22 AM Changeset in webkit [18314] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp

Fix spelling error in Cairo graphics context.

3:07 AM Changeset in webkit [18313] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Remove save()/restore()... forgot they are more expensive.

3:04 AM Changeset in webkit [18312] by hyatt

• 3 edits in trunk/WebCore

Make sure to initialize the CG fill and stroke colors to our initial fill/stroke colors when first
constructing a GraphicsContextCG. Because Safari actually draws text in the bookmarks bar using GraphicsContext
and sets a fill color, this could only really be seen in another WebKit app.

Patched GraphicsContextQt as well, since it has the same pattern.

Reviewed by bdash

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): (WebCore::setCGStrokeColor): (WebCore::GraphicsContext::GraphicsContext):

2:47 AM Changeset in webkit [18311] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Remove an unnecessary cgsetfill in drawEllipse.

2:26 AM Changeset in webkit [18310] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Fix buildbot bustage with conversion of stroke thickness.

2:20 AM Changeset in webkit [18309] by hyatt

• 1 edit in trunk/WebCore/rendering/RenderImage.cpp

Fix drawing of image alt text..

2:08 AM Changeset in webkit [18308] by hyatt

• 1 edit in trunk/WebCore/rendering/RenderImage.cpp

Fix stroking of error image borders.

1:53 AM Changeset in webkit [18307] by lars

• 6 edits in trunk

Fix the Qt build and make sure it doesn't crash.

12:54 AM Changeset in webkit [18306] by hyatt

• 6 edits in trunk/WebCore

Convert stroke thickness to a float. This allows the thickness argument to strokeArc to be eliminated.

Reviewed by olliej

• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::setPlatformStrokeThickness):
• platform/graphics/GraphicsContext.h:
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::setPlatformStrokeThickness):
• rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc):

12:39 AM Changeset in webkit [18305] by hyatt

• 6 edits in trunk/WebCore

Rename drawArc to strokeArc and remove its strange behavior of trying to "fill" by stroking using the passed in
thickness. Now the method is purely about stroking an arc and always uses the passed in thickness. Fix the
border-radius code that calls the method so that it makes more sense now. If stroke thickness is converted
to a float, then even the extra argument can go away, and this method can be a clean stroke of an arc.

Make sure to get square list markers right by setting both stroke and fill color properly.

Reviewed by mitz, olliej

• platform/graphics/GraphicsContext.h:
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeArc):
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokeArc):
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
• rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc):

12:04 AM Changeset in webkit [18304] by ggaren

• 10 edits
  4 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Test cases for capturing of mouse up events.

• fast/events/mouseup-outside-button-expected.txt: Added.
• fast/events/mouseup-outside-button.html: Added.
• fast/events/mouseup-outside-document-expected.txt: Added.
• fast/events/mouseup-outside-document.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4549745> REGRESSION: scrolling on Google maps
continues after the mouse is released outside the window (8137)

The RenderLayer hit testing code assumed that, when the mouse was outside
the WebView, we only needed to capture mouse events while the mouse was
down (in other words, mouse move events). We actually need to capture mouse
up events, as well.

• dom/Document.cpp: (WebCore::Document::prepareMouseEvent): To match EventHandler::prepareMouseEvent, I changed this function to take a HitTestRequest instead of the broken-out values of one. For clarity, I moved an assert to top of function. (WebCore::Document::addMarker): Removed stray character.
• dom/Document.h:

• page/EventHandler.cpp: Changed prepareMouseEvent to take a HitTestRequest, instead of the broken-out values of one. This simplified the code, and made the task of adding an extra, optional parameter to hit testing much easier. (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): Set the 'capturing' flag if the move occurs while the mouse is down. This replaces RenderLayer's heavy-handed assumption that we should always capture if the mouse is down. (WebCore::EventHandler::handleMouseReleaseEvent): Set the 'capturing' flag, since we assume every mouse up follows a mouse down inside the WebView. (We'd like to ASSERT as much, but DRT's event sending mechanism is crazy, and violates this axiom.) (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::prepareMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired):
• page/EventHandler.h:

• rendering/HitTestRequest.h: (WebCore::HitTestRequest::HitTestRequest): Added 'capturing' data member, which specifies whether the hit test should capture mouse events that occur outside the WebView.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer): Moved misleading comment to where it actually applies. Changed 'active' test to new 'capturing' test, so the hit test requester can decide whether we need to capture mouse events that don't intersect any layer.

WebKitTools:

Reviewed by Beth Dakin.

Updated EventSender to be able to send mouse up events outside the WebView.
This is a minor tweak to a hackish implementation. The real solution
should be to use NSApplication's event sending model instead of rolling
our own, but I don't have time for that right now.

• DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]):

Dec 18, 2006:

11:45 PM Changeset in webkit [18303] by hyatt

• 2 edits in trunk/WebCore

Make sure a stroke style is set for list bullets.

Reviewed by mitz

• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):

10:28 PM Changeset in webkit [22690] by adachan

• 10 edits in branches/WindowsMerge

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.

Fixed <rdar://4850800> Pop-up window opens with same size as parent window, and app crashes when closing pop-up

• Corrected the height set on the max/min/restore/close buttons on the top-right of the safari win to take into account its top margin.
• Implemented the calls we need to close window via script.

• Added runBeforeUnloadConfirmPanelWithMessage to IWebUIDelegate.
• implemented canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon in WebChromeClient
• implemented WebView::closeWindow().

Removed scheduleClose() from FrameWin. The implementation has
been moved to Frame.cpp.

10:15 PM Changeset in webkit [18302] by adachan

• 22 edits in trunk

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.

Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
from WebCoreFrameBridge to Chrome.
Moved implementation of Frame::scheduleClose to Frame.cpp.

9:53 PM Changeset in webkit [22689] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/PopupMenuWin.cpp

Fix Boomer build bustage from Pen conversion.

9:48 PM Changeset in webkit [22688] by beidson

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice

Fixes <rdar://4821724> - Wrong site icon displays for sites who don't actually have an icon

We judged whether or not a site has an icon based on whether or not the IconDatabase returned
a valid Image.
In the case of sites without an icon, we actually get returned a valid Image with dimensions 0x0.
WebKit on OS X correctly handles this case via NSImage goodness - now we manually handle it on Windows

• WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Check the width() as an additional case to fallback to the default icon

9:30 PM Changeset in webkit [18301] by aliceli1

• 3 edits
  3 adds in trunk

LayoutTests:

Reviewed by Adam.

Test case for <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

• http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
• http/tests/misc/location-test-xsl-style-sheet.xml: Added.
• http/tests/misc/resources/location-test-xsl-style-sheet.xsl: Added.

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

• loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):

9:23 PM Changeset in webkit [18300] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:22 PM Changeset in webkit [22687] by sfalken

• 5 edits in branches/WindowsMerge/WebKitWin

2006-12-18 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Added loadType to IWebFramePrivate.

• Interfaces/IWebFramePrivate.idl: Added loadType
• WebFrame.cpp: Fixed line endings (WebFrame::loadType): Added
• WebFrame.h: Fixed line endings
• WebKit.vcproj/WebKit.vcproj: Moved WebLocalizableStrings.h to proper folder

9:18 PM Changeset in webkit [18299] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix spelling error in Qt code..

9:17 PM Changeset in webkit [18298] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:02 PM Changeset in webkit [18297] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing setPlatformPen.

8:58 PM Changeset in webkit [18296] by hyatt

• 2 edits in trunk/WebCore

Add save/restore calls around the painting of text areas on Mac, since the methods in question
alter the current fill color in CG destructively.

Reviewed by olliej

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb):

8:31 PM Changeset in webkit [18295] by hyatt

• 2 edits in trunk/WebCore

Fix list markers to properly stroke and fill. I screwed this up when changing how text draws.

Reviewed by olliej

• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):

8:21 PM Changeset in webkit [22686] by andersca

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam and Oliver.

<rdar://problem/4856014> Target weekly ad doesn't work.

Store the real base URL and use it for requests.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::PluginViewWin):
• plugins/win/PluginViewWin.h:

8:16 PM Changeset in webkit [22685] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Boomer side of pen removal changes.

8:00 PM Changeset in webkit [18294] by hyatt

• 18 edits in trunk/WebCore

Eliminate the Pen object in favor of separate stroke variables, since most code just wants to set the
stroke color. This also makes it easier for us to push only stroke color through into CG synchronously
while leaving the others alone.

Reviewed by olliej

• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
• platform/graphics/GraphicsContext.h: (WebCore::):
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformStrokeColor):
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQPenStyle): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
• platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
• rendering/InlineTextBox.cpp: (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
• rendering/RenderBox.cpp:
• rendering/RenderBox.h:
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
• rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
• rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder):
• rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
• rendering/RenderText.cpp:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton):

6:44 PM Changeset in webkit [22684] by darin

• 2 edits in branches/WindowsMerge/WebCore

• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Fix build, wrong variable name.

6:30 PM Changeset in webkit [18293] by darin

• 7 edits in trunk/WebCore

Reviewed by Adele.

• fix <rdar://problem/4889565> REGRESSION (r17597): Command-clicking a submit button does not submit in a new tab/window ​http://bugs.webkit.org/show_bug.cgi?id=11858

• change DOMActivate events to be created as a part of default handling of click events instead of having the sender of the click event also send a DOMActivate event

• fixed some edge cases in the slider thumb element handler; since this is inside a shadow DOM, it's likely none of these can arise in practice

No easy way to test the command-click part since the behavior is in Safari.
To make a test we'd have to provide JavaScript access to the modifiers passed
to the policy delegate or have some way to query the underlying event from
JavaScript.

• dom/EventTargetNode.cpp: Change all assert to ASSERT. (WebCore::EventTargetNode::dispatchMouseEvent): Renamed some local variables for clarity. Added a RefPtr for relatedTarget since it might be deallocated by the handlers for the click event and is used in the code that creates the dblclick event. Removed the code to create a DOMActivate event, since that's now done in the default event handler for the click event. (WebCore::EventTargetNode::defaultEventHandler): Added code to check for a click event and dispatch a DOMActivate event using the click event as the underlying event. The part of this that fixes the bug is that we use the click event as the underlying event; the old code used the same underlying event as for the click event, not the click event itself. The underlying event for the click event is usually 0, since we propagate the key state to the click event instead of using an underlying event in the common case.

• dom/Document.cpp: (WebCore::Document::defaultEventHandler): Added call to the base class's defaultEventHandler function, except in the case where the event is already handled.

• html/HTMLInputElement.h: Removed clickX() and clickY().
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Use xPos and yPos directly, so we can remove clickX() and clickY(). (WebCore::HTMLInputElement::defaultEventHandler): Removed code that calls setDefaultHandled for click events since we are just recording the x and y coordinates of the events; that's not "handling" an event, and setting the flag prevents us from calling the base class's default event handler, which is now needed to submmit the form.

• rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Added some missing isMouseEvent checks in code that casts to a MouseEvent. Added check document()->frame() in code that manipulates the frame so that fake events, which might happen when there's no frame, can't cause a crash. Added an m_inDragMode check so we don't try to handle mouseup events when we are not handling a drag. Remove the setDefaultHandled call from the mousemove case, because mousemove events are observed, and not "handled" in the "nobody else should look at this event" sense. Added a call to the base class's default event handler, and some return statements so that we won't call it when the event has been handled.

• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Removed an unneeded "return" for a function that has no return value.

6:04 PM Changeset in webkit [18292] by bdash

• 2 edits in trunk/LayoutTests

2006-12-18 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Bug 11870: Bug 11866 caused layout test regression in fast/forms/input-value.html
​http://bugs.webkit.org/show_bug.cgi?id=11870

• fast/forms/input-value-expected.txt: Updated results.

5:38 PM Changeset in webkit [18291] by bdakin

• 4 edits
  4 adds in trunk

WebCore:

Fix for <rdar://problem/4749770> WebCore crashes on a blog website
in WebCore::InlineBox::root() + 6

We null-check inlineBoxWrapper everywhere else in the code except
for these 3 spots. This patch adds them in. Only one of the checks
is required to fix the crash. What we render for the test case now
matches shipping Safari, but still seems wrong because we do not
match Firefox. I will file a follow-up about the rendering problem.

• rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): This is the required null-check.
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setSelectionState): Null-check for safety. (WebCore::RenderListMarker::selectionRect): Same.

LayoutTests:

Reviewed by Adele.

Test case for <rdar://problem/4749770> WebCore crashes on a blog
website in WebCore::InlineBox::root() + 6

• fast/lists/inlineBoxWrapperNullCheck-expected.checksum: Added.
• fast/lists/inlineBoxWrapperNullCheck-expected.png: Added.
• fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
• fast/lists/inlineBoxWrapperNullCheck.html: Added.

5:26 PM Changeset in webkit [22683] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Boomer side of my changes for filling/stroking of text.

Reviewed by olliej

• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

5:18 PM Changeset in webkit [18290] by hyatt

• 14 edits in trunk/WebCore

Fix performance regression caused by adding setting of stroke colors as well as fill colors to every font drawing
call on Mac. Fix is rather involved:

(1) Fill color is now updated in CG synchronously. There is no more delay in the push. I used the model that
Qt added for this, setPlatformFillColor, so we're the same now.

(2) Text was being drawn using the pen color, which is tantamount to using the stroke color. Since text in HTML
is really a fill and not a stroke, all cross-platform code that draws text has been patched to use fill instead
of the pen.

(3) Added a new API to GraphicsContext to set the text drawing mode to any combination of fill/stroke/clip.
Ports should implement setPlatformTextDrawingMode or just query the mode in their drawGlyphs/drawComplexText
method on their Font class to get the new functionality.

(4) InlineTextBox will set the fill and stroke colors appropriately now rather than always assuming fill.

(5) Fixed a bug in GraphicsContextCG where fillRectWithColor was updating the CG fill color in the state object
as a side effect, creating a mismatch between CG's fill color and the stored cross-platform fill color.

Reviewed by olliej

• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformPen):
• platform/graphics/GraphicsContext.h:
• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformFillColor):
• platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
• platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
• platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
• platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
• platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
• rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
• rendering/InlineTextBox.cpp: (WebCore::correctedTextColor): (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):

3:28 PM Changeset in webkit [18289] by bdash

• 3 edits
  5 adds in trunk

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Bug 11760: Animated GIFs with offsets crash WebKit
​http://bugs.webkit.org/show_bug.cgi?id=11760

• platform/image-decoders/gif/GIFImageDecoder.cpp: ensure we don't write past the end of the image buffer when the offset is nonzero. also fix the way we composite frames when animating. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11760

• ChangeLog:
• fast/images/animated-gif-with-offsets-expected.txt: Added.
• fast/images/animated-gif-with-offsets.html: Added.
• fast/images/resources/animated-gif-with-offsets.gif: Added.

3:22 PM Changeset in webkit [18288] by bdash

• 3 edits
  4 adds in trunk

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Changed hidden input controls to reset to their initial values
when the form is reset. Also added layout tests for resetting
other input controls.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11866

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11866

• fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
• fast/dom/HTMLInputElement/input-checked-reset.html: Added.
• fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
• fast/dom/HTMLInputElement/input-text-reset.html: Added.

2:57 PM Changeset in webkit [22682] by aliceli1

• 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

• WebCore.vcproj/WebCore.vcproj: Added file EditorDeleteAction.h

WebKitWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

• WebView.cpp: (WebView::execCommand): Removed the case for ForwardDelete, since it shouldn't be handled there (WebView::deleteSelection): Implemented (WebView::copy): (WebView::cut): (WebView::paste): (WebView::delete_): Use the Editor's execCommand for these editor-responsible functions

2:49 PM Changeset in webkit [18287] by aliceli1

• 1 edit
  1 add in trunk/WebCore

Oops forgot a file.

• editing/EditorDeleteAction.h: Added. (WebCore::):

2:47 PM Changeset in webkit [18286] by aliceli1

• 11 edits in trunk

WebCore:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

• WebCore.exp: Exposed Editor::deleteWithDirection and ::deleteRange()

• WebCore.xcodeproj/project.pbxproj: Added EditorDeleteAction.h

• editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::deleteWithDirection): Implemented

(WebCore::Editor::deleteSelectionWithSmartDelete):
Overloaded to take no params, in which case canSmartCopyOrDelete is called

(WebCore::execCopy):
(WebCore::execCut):
(WebCore::execDelete):
(WebCore::execPaste):
Call the editor instead of asking frame to cut/copy/paste/delete

(WebCore::execBackwardDelete):
(WebCore::execForwardDelete):
Call deleteWithDirection instead of just executing a TypingCommand

(WebCore::CommandEntry::):
distinguished delete (which deletes selection) from backwards delete (single character, no selection)

(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
Trivial changes

• editing/Editor.h: Added some functons. (WebCore::Editor::setStartNewKillRingSequence): (WebCore::Editor::propogateDOMException): (WebCore::Editor::addToKillRing):
• editing/mac/EditorMac.mm: Factored out support for Kill Rings to this file

• platform/mac/PasteboardMac.mm: Trivial change

WebKit:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

• WebKitPrefix.h: Turned on WebCore deletion

• WebView/WebHTMLViewInternal.h: Moved ownership of startNewKillRingSequence to the WebCore::Editor

• WebView/WebHTMLView.m: (-[NSArray becomeFirstResponder]): Use the Editor's startNewKillRingSequence flag

(-[NSArray deleteForward:]):
(-[NSArray deleteBackward:]):
(-[NSArray deleteWordForward:]):
(-[NSArray deleteWordBackward:]):
(-[NSArray deleteToBeginningOfLine:]):
(-[NSArray deleteToEndOfLine:]):
(-[NSArray deleteToBeginningOfParagraph:]):
(-[NSArray deleteToEndOfParagraph:]):
(-[NSArray deleteToMark:]):
use Editor::deleteWithDirection instead of WebHTMLView's

2:39 PM Changeset in webkit [22681] by kmccullo

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

• Remove CG header includes in OpenSource files

• config.h:
• platform/graphics/cg/GraphicsContextPlatformPrivate.h:

WebKitWin:

Reviewed by Oliver.

• Remove CG header includes in open source files

• WebView.cpp:

2:32 PM Changeset in webkit [18285] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by Oliver.

• Removed CG header include

• platform/graphics/ImageSource.h:

2:18 PM Changeset in webkit [18284] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

• fixed <rdar://problem/4887764> GMAIL: Crash occurs at WebCore::Range::cloneRange() when I ctrl-click in a empty list item

• editing/mac/EditorMac.mm: (WebCore::isRangeUngrammatical): bail out immediately for nil range (which selectionController()->toRange().get() can return). Also save some work by bailing out immediately for collapsed ranges.

1:36 PM Changeset in webkit [18283] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

• ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):

1:31 PM Changeset in webkit [18282] by yongjzha

• 3 edits in S60/branches/3.1m/WebKit

2006-12-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):

1:28 PM Changeset in webkit [18281] by spadma

• 6 edits in S60/branches/3.1m

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

• BrowserView/inc/WebKitToolBarInterface.h:
• BrowserView/inc/WebKitView.h:
• BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):

1:21 PM Changeset in webkit [18280] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

• ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):

1:00 PM Changeset in webkit [18279] by spadma

• 6 edits in S60/trunk

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

• BrowserView/inc/WebKitToolBarInterface.h:
• BrowserView/inc/WebKitView.h:
• BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):

12:27 PM Changeset in webkit [18278] by ap

• 1 edit
  4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=7170
`window.parent.[frameName].location=' fails if the target frame has not yet loaded a document

• fast/frames/resources/set-unloaded-frame-location-1.html: Added.
• fast/frames/resources/set-unloaded-frame-location-2.html: Added.
• fast/frames/set-unloaded-frame-location-expected.txt: Added.
• fast/frames/set-unloaded-frame-location.html: Added.

11:41 AM Changeset in webkit [18277] by thatcher

• 1 copy in tags/WebKit-419/WebKit

New tag (part 2.)

11:41 AM Changeset in webkit [18276] by thatcher

• 1 add in tags/WebKit-419

new tag (part 1.)

11:27 AM Changeset in webkit [18275] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

Versioning.

10:44 AM Changeset in webkit [18274] by aliceli1

• 2 edits in trunk/WebCore

Leopard build fix.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):

9:58 AM Changeset in webkit [22680] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Build fixes.

• WebCore.vcproj/WebCore.vcproj: Removed deleted files.
• platform/win/CursorWin.cpp: Added missing method. (WebCore::noneCursor):

Dec 17, 2006:

2:23 PM Changeset in webkit [18273] by zack

• 2 edits in trunk/WebCore

fix compiltion, after the const changes

1:48 PM Changeset in webkit [18272] by rwlbuis

• 1 edit
  1 add in trunk/LayoutTests

Reviewed by Eric.

Add missing checksum file, thnx to Wildfox for noticing.

1:29 PM Changeset in webkit [18271] by zimmermann

• 6 edits in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10956

Long standing regression. The old code in FontMac.mm, used set the fill/stroke
color "[nsColor(graphicsContext->pen().color()) set];", and current code only
sets the fill color. Reverting to old behaviour fixes gradient-on-stroke-of-text.

11:25 AM Changeset in webkit [18270] by ap

• 14 edits
  1 add in trunk/WebCore

2006-12-17 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed, tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11798
[CSS 3] missing cursor support for 'none'

• Resources/noneCursor.png: Added.
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSValueKeywords.in:
• css/cssparser.cpp: Also fixed previously broken -webkit-background-composite: copy.
• manual-tests/cursor.html:
• page/EventHandler.cpp: (WebCore::selectCursor):
• platform/Cursor.h:
• platform/gdk/CursorGdk.cpp: (WebCore::noneCursor):
• platform/mac/CursorMac.mm: (WebCore::noneCursor):
• platform/qt/CursorQt.cpp: (WebCore::noneCursor):
• platform/win/CursorWin.cpp: (WebCore::noneCursor):
• rendering/RenderStyle.h: (WebCore::):

5:24 AM SVG TODO List - Short notes edited by zimmermann@kde.org

(diff)

4:52 AM Changeset in webkit [18269] by zimmermann

• 2 edits in trunk/WebCore

Build fix, not reviewed.

This should hopefully fix Qt build.

• ksvg2/svg/SVGLength.cpp: Include math.h for Qt/Linux build.

4:47 AM Changeset in webkit [18268] by zimmermann

• 55 edits
  2 deletes in trunk/WebCore

Reviewed by Rob.

Remove SVGHelper class. Move the last static function "parseSeparatedList"
to the only place using it: SVGAnimationElement. Update all build files.

Remove any lazy_create macro usage, by what it does - cleaner.

4:16 AM Changeset in webkit [18267] by zimmermann

• 60 edits in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11813

Pass SVGLength around by value, remove any SVGLength* usage.
Bindings work fine, as the SVG POD JS Wrapper stuff is already in svn.

No new regressions, none fixed. But the code itself is much cleaner.
And some problems with width-full-percentage.svg have been fixed, viewport
clipping works in any case now, also for percentual width/height values set on <svg>.

Still unsure if we can simulate window resizes in a layout test,
not through "width/height" property changes, but directly in any way.
If anyone knows if we can do that, please drop me a line.

3:58 AM Changeset in webkit [18266] by hausmann

• 2 edits in trunk/JavaScriptCore

make testkjs.pro work on machines other than mine :)

2:50 AM Changeset in webkit [18265] by hausmann

• 3 edits
  1 add in trunk

for the Qt build also build testkjs now

Dec 16, 2006:

8:11 PM Changeset in webkit [18264] by weinig

• 406 edits in trunk

LayoutTests:

Reviewed by Maciej.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=11856
Update renderName() methods to return current class names.

• dom/svg/level3/xpath/Conformance_ID-expected.txt:
• editing/inserting/before-after-input-element-expected.txt:
• editing/pasteboard/4806874-expected.txt:
• editing/pasteboard/drop-text-without-selection-expected.txt:
• editing/pasteboard/input-field-1-expected.txt:
• editing/pasteboard/nested-blocks-with-text-area-expected.txt:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt:
• editing/pasteboard/pasting-tabs-expected.txt:
• editing/selection/3690703-2-expected.txt:
• editing/selection/3690703-expected.txt:
• editing/selection/3690719-expected.txt:
• editing/selection/drag-select-1-expected.txt:
• editing/selection/select-from-textfield-outwards-expected.txt:
• fast/block/float/032-expected.txt:
• fast/block/margin-collapse/103-expected.txt:
• fast/css/resize-corner-tracking-expected.txt:
• fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• fast/dom/isindex-002-expected.txt:
• fast/dynamic/008-expected.txt:
• fast/events/label-focus-expected.txt:
• fast/forms/8250-expected.txt:
• fast/forms/encoding-test-expected.txt:
• fast/forms/fieldset-align-expected.txt:
• fast/forms/floating-textfield-relayout-expected.txt:
• fast/forms/form-element-geometry-expected.txt:
• fast/forms/input-appearance-bkcolor-expected.txt:
• fast/forms/input-appearance-default-bkcolor-expected.txt:
• fast/forms/input-appearance-disabled-expected.txt:
• fast/forms/input-appearance-focus-expected.txt:
• fast/forms/input-appearance-height-expected.txt:
• fast/forms/input-appearance-minWidth-expected.txt:
• fast/forms/input-appearance-preventDefault-expected.txt:
• fast/forms/input-appearance-readonly-expected.txt:
• fast/forms/input-appearance-selection-expected.txt:
• fast/forms/input-appearance-visibility-expected.txt:
• fast/forms/input-appearance-width-expected.txt:
• fast/forms/input-baseline-expected.txt:
• fast/forms/input-disabled-color-expected.txt:
• fast/forms/input-double-click-selection-gap-bug-expected.txt:
• fast/forms/input-maxlength-2-expected.txt:
• fast/forms/input-paste-undo-expected.txt:
• fast/forms/input-readonly-dimmed-expected.txt:
• fast/forms/input-readonly-empty-expected.txt:
• fast/forms/input-spaces-expected.txt:
• fast/forms/input-table-expected.txt:
• fast/forms/input-text-click-inside-expected.txt:
• fast/forms/input-text-click-outside-expected.txt:
• fast/forms/input-text-double-click-expected.txt:
• fast/forms/input-text-drag-down-expected.txt:
• fast/forms/input-text-maxlength-expected.txt:
• fast/forms/input-text-option-delete-expected.txt:
• fast/forms/input-text-paste-maxlength-expected.txt:
• fast/forms/input-text-scroll-left-on-blur-expected.txt:
• fast/forms/input-text-self-emptying-click-expected.txt:
• fast/forms/input-type-change2-expected.txt:
• fast/forms/input-value-expected.txt:
• fast/forms/input-width-expected.txt:
• fast/forms/minWidthPercent-expected.txt:
• fast/forms/negativeLineHeight-expected.txt:
• fast/forms/plaintext-mode-2-expected.txt:
• fast/forms/tabbing-input-iframe-expected.txt:
• fast/forms/textAreaLineHeight-expected.txt:
• fast/forms/textarea-scroll-height-expected.txt:
• fast/forms/textarea-scrollbar-expected.txt:
• fast/forms/textarea-scrolled-type-expected.txt:
• fast/forms/textarea-setinnerhtml-expected.txt:
• fast/forms/textfield-drag-into-disabled-expected.txt:
• fast/forms/visual-hebrew-text-field-expected.txt:
• fast/lists/dynamic-marker-crash-expected.txt:
• fast/overflow/overflow-x-y-expected.txt:
• fast/replaced/width100percent-expected.txt:
• fast/table/003-expected.txt:
• fast/table/colspanMinWidth-expected.txt:
• fast/table/spanOverlapRepaint-expected.txt:
• fast/table/text-field-baseline-expected.txt:
• fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• fast/text/textIteratorNilRenderer-expected.txt:
• http/tests/navigation/anchor-basic-expected.txt:
• http/tests/navigation/anchor-frames-expected.txt:
• http/tests/navigation/anchor-goback-expected.txt:
• http/tests/navigation/anchor-subframeload-expected.txt:
• http/tests/navigation/javascriptlink-basic-expected.txt:
• http/tests/navigation/javascriptlink-frames-expected.txt:
• http/tests/navigation/javascriptlink-goback-expected.txt:
• http/tests/navigation/javascriptlink-subframeload-expected.txt:
• http/tests/navigation/metaredirect-basic-expected.txt:
• http/tests/navigation/metaredirect-frames-expected.txt:
• http/tests/navigation/metaredirect-goback-expected.txt:
• http/tests/navigation/metaredirect-subframeload-expected.txt:
• http/tests/navigation/post-goback2-expected.txt:
• http/tests/navigation/postredirect-goback2-expected.txt:
• http/tests/navigation/redirect302-basic-expected.txt:
• http/tests/navigation/redirect302-frames-expected.txt:
• http/tests/navigation/redirect302-goback-expected.txt:
• http/tests/navigation/redirect302-subframeload-expected.txt:
• http/tests/navigation/relativeanchor-basic-expected.txt:
• http/tests/navigation/relativeanchor-frames-expected.txt:
• http/tests/navigation/relativeanchor-goback-expected.txt:
• http/tests/navigation/slowmetaredirect-basic-expected.txt:
• http/tests/navigation/slowtimerredirect-basic-expected.txt:
• http/tests/navigation/success200-basic-expected.txt:
• http/tests/navigation/success200-frames-expected.txt:
• http/tests/navigation/success200-frames-loadsame-expected.txt:
• http/tests/navigation/success200-goback-expected.txt:
• http/tests/navigation/success200-loadsame-expected.txt:
• http/tests/navigation/success200-reload-expected.txt:
• http/tests/navigation/success200-subframeload-expected.txt:
• http/tests/navigation/timerredirect-basic-expected.txt:
• http/tests/navigation/timerredirect-frames-expected.txt:
• http/tests/navigation/timerredirect-goback-expected.txt:
• http/tests/navigation/timerredirect-subframeload-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
• svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
• svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
• svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
• svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
• svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
• svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
• svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
• svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
• svg/custom/SVGNumber-interface-expected.txt:
• svg/custom/SVGPoint-interface-expected.txt:
• svg/custom/SVGPoint-matrixTransform-expected.txt:
• svg/custom/SVGRect-interface-expected.txt:
• svg/custom/baseval-animval-equality-expected.txt:
• svg/custom/class-selector-expected.txt:
• svg/custom/clip-path-with-transform-expected.txt:
• svg/custom/conditional-processing-outside-switch-expected.txt:
• svg/custom/control-points-for-S-and-T-expected.txt:
• svg/custom/coords-relative-units-transforms-expected.txt:
• svg/custom/create-metadata-element-expected.txt:
• svg/custom/createelement-expected.txt:
• svg/custom/dasharrayOrigin-expected.txt:
• svg/custom/display-none-expected.txt:
• svg/custom/dynamic-empty-path-expected.txt:
• svg/custom/empty-merge-expected.txt:
• svg/custom/evt-onload-expected.txt:
• svg/custom/feComponentTransfer-Discrete-expected.txt:
• svg/custom/feComponentTransfer-Gamma-expected.txt:
• svg/custom/feComponentTransfer-Linear-expected.txt:
• svg/custom/feComponentTransfer-Table-expected.txt:
• svg/custom/feDisplacementMap-01-expected.txt:
• svg/custom/fill-update-expected.txt:
• svg/custom/filter-source-alpha-expected.txt:
• svg/custom/foreign-object-skew-expected.txt:
• svg/custom/fractional-rects-expected.txt:
• svg/custom/getTransformToElement-expected.txt:
• svg/custom/getsvgdocument-expected.txt:
• svg/custom/gradient-attr-update-expected.txt:
• svg/custom/gradient-stroke-width-expected.txt:
• svg/custom/grayscale-gradient-mask-expected.txt:
• svg/custom/hover-default-fill-expected.txt:
• svg/custom/image-clipped-hit-expected.txt:
• svg/custom/image-with-transform-clip-filter-expected.txt:
• svg/custom/inner-percent-expected.txt:
• svg/custom/invalid-css-expected.txt:
• svg/custom/invalid-fill-expected.txt:
• svg/custom/invalid-transforms-expected.txt:
• svg/custom/invalid-viewbox1-expected.txt:
• svg/custom/invalid-viewbox2-expected.txt:
• svg/custom/junk-data-expected.txt:
• svg/custom/marker-overflow-clip-expected.txt:
• svg/custom/mask-inside-defs-expected.txt:
• svg/custom/missing-xlink-expected.txt:
• svg/custom/non-opaque-filters-expected.txt:
• svg/custom/path-bad-data-expected.txt:
• svg/custom/path-update-expected.txt:
• svg/custom/pattern-in-defs-expected.txt:
• svg/custom/pattern-y-offset-expected.txt:
• svg/custom/percentage-rect-expected.txt:
• svg/custom/percentage-rect2-expected.txt:
• svg/custom/pointer-events-path-expected.txt:
• svg/custom/polyline-hittest-expected.txt:
• svg/custom/polyline-invalid-points-expected.txt:
• svg/custom/polyline-setattribute-points-null-expected.txt:
• svg/custom/recursive-clippath-expected.txt:
• svg/custom/rootelement-expected.txt:
• svg/custom/rounded-rects-expected.txt:
• svg/custom/sheet-title-expected.txt:
• svg/custom/simpleCDF-expected.txt:
• svg/custom/svg-overflow-types-expected.txt:
• svg/custom/svgpolyparser-extra-space-expected.txt:
• svg/custom/text-clip-expected.txt:
• svg/custom/text-ctm-expected.txt:
• svg/custom/text-filter-expected.txt:
• svg/custom/text-gradient-no-content-expected.txt:
• svg/custom/text-hit-test-expected.txt:
• svg/custom/text-image-opacity-expected.txt:
• svg/custom/transform-ignore-after-invalid-expected.txt:
• svg/custom/transform-invalid-expected.txt:
• svg/custom/transform-scale-parse-expected.txt:
• svg/custom/transform-with-ending-space-expected.txt:
• svg/custom/tref-update-expected.txt:
• svg/custom/use-forward-refs-expected.txt:
• svg/custom/viewport-clip-expected.txt:
• svg/custom/viewport-em-expected.txt:
• svg/custom/viewport-no-width-height-expected.txt:
• svg/custom/viewport-update-expected.txt:
• svg/custom/viewport-update2-expected.txt:
• svg/custom/width-full-percentage-expected.txt:
• svg/hixie/cascade/002-expected.txt:
• svg/hixie/viewbox/003-expected.txt:
• tables/mozilla/bugs/45621-expected.txt:
• tables/mozilla/bugs/bug1188-expected.txt:
• tables/mozilla/bugs/bug12384-expected.txt:
• tables/mozilla/bugs/bug18359-expected.txt:
• tables/mozilla/bugs/bug194024-expected.txt:
• tables/mozilla/bugs/bug24200-expected.txt:
• tables/mozilla/bugs/bug2479-3-expected.txt:
• tables/mozilla/bugs/bug2479-4-expected.txt:
• tables/mozilla/bugs/bug28928-expected.txt:
• tables/mozilla/bugs/bug30559-expected.txt:
• tables/mozilla/bugs/bug30692-expected.txt:
• tables/mozilla/bugs/bug4382-expected.txt:
• tables/mozilla/bugs/bug4527-expected.txt:
• tables/mozilla/bugs/bug46368-1-expected.txt:
• tables/mozilla/bugs/bug46368-2-expected.txt:
• tables/mozilla/bugs/bug51037-expected.txt:
• tables/mozilla/bugs/bug55545-expected.txt:
• tables/mozilla/bugs/bug59354-expected.txt:
• tables/mozilla/bugs/bug7342-expected.txt:
• tables/mozilla/bugs/bug96334-expected.txt:
• tables/mozilla/bugs/bug99948-expected.txt:
• tables/mozilla/dom/tableDom-expected.txt:
• tables/mozilla/other/move_row-expected.txt:
• tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
• tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
• tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
• tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11856
Update renderName() methods to return current class names.

• rendering/RenderPath.h: (WebCore::RenderPath::renderName): Returns "RenderPath" instead of "KCanvasItem".
• rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::renderName): Returns "RenderSVGContainer" instead of "KCanvasContainer".
• rendering/RenderTextControl.h: (WebCore::RenderTextControl::renderName): Returns "RenderTextControl" instead of "RenderTextField".

3:43 PM Changeset in webkit [22679] by aroben

• 3 edits in branches/WindowsMerge/WebCore

2006-12-16 Beth Dakin <Beth Dakin>

Reviewed by Adam (and partially Geoff).

Boomer side of making WebCore Context Menus support state and
enabled/disabled, and re-architecture of ContextMenuItem.

• platform/win/ContextMenuItemWin.cpp: ContextMenuItem class holds the platformDescription as the sole member variable. Changes to account for this. (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::releasePlatformDescription): Same. (WebCore::ContextMenuItem::type): Same (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setType): Same. (WebCore::ContextMenuItem::setTitle): Same. (WebCore::ContextMenuItem::setSubMenu): Same. (WebCore::ContextMenuItem::setChecked): Same. (WebCore::ContextMenuItem::setEnabled): Same.
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::insertItem): Takes ownership of the item by calling releasePlatformDescription() (WebCore::ContextMenu::appendItem): Same. (WebCore::ContextMenu::itemWithAction): This is the new at(). Since we are no longer using notifybypos, we instead need a way to find a menu item by its action. (Its ID.) (WebCore::ContextMenu::setPlatformDescription): No longer use notifybypos.

3:36 PM Changeset in webkit [18263] by weinig

• 27 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11844
Code Cleanup for more of the rendering code

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcMinMaxWidth):
• rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setStyle): (WebCore::RenderText::destroy): (WebCore::RenderText::attachTextBox): (WebCore::RenderText::findNextInlineTextBox): (WebCore::RenderText::positionForCoordinates): (WebCore::firstRendererOnNextLine): (WebCore::lastRendererOnPrevLine): (WebCore::RenderText::caretRect): (WebCore::RenderText::posOfChar): (WebCore::RenderText::allAscii): (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::minXPos): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::position): (WebCore::RenderText::width): (WebCore::RenderText::getAbsoluteRepaintRect): (WebCore::RenderText::selectionRect): (WebCore::RenderText::verticalPositionHint): (WebCore::RenderText::font): (WebCore::RenderText::caretMinOffset): (WebCore::RenderText::caretMaxOffset): (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::inlineBox):
• rendering/RenderText.h: (WebCore::RenderText::isTextFragment): (WebCore::RenderText::data): (WebCore::RenderText::string): (WebCore::RenderText::paint): (WebCore::RenderText::layout): (WebCore::RenderText::nodeAtPoint): (WebCore::RenderText::length): (WebCore::RenderText::text): (WebCore::RenderText::stringLength):
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): (WebCore::disabledTextColor): (WebCore::RenderTextControl::createInnerBlockStyle): (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::createResultsButtonStyle): (WebCore::RenderTextControl::createCancelButtonStyle): (WebCore::RenderTextControl::showPlaceholderIfNeeded): (WebCore::RenderTextControl::hidePlaceholderIfNeeded): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::subtreeHasChanged): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::nodeAtPoint): (WebCore::RenderTextControl::layout): (WebCore::RenderTextControl::calcMinMaxWidth): (WebCore::RenderTextControl::addSearchResult): (WebCore::RenderTextControl::showPopup): (WebCore::RenderTextControl::itemText): (WebCore::RenderTextControl::itemIsEnabled): (WebCore::RenderTextControl::listSize): (WebCore::RenderTextControl::scroll):
• rendering/RenderTextControl.h: (WebCore::RenderTextControl::renderName): (WebCore::RenderTextControl::removeLeftoverAnonymousBoxes):
• rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment): (WebCore::RenderTextFragment::originalString):
• rendering/RenderTextFragment.h: (WebCore::RenderTextFragment::isTextFragment):
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::stateChanged): (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
• rendering/RenderTheme.h: (WebCore::):
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeMac::systemFont): (WebCore::RenderThemeMac::isControlStyled): (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::updateCheckedState): (WebCore::RenderThemeMac::controlSupportsTints): (WebCore::RenderThemeMac::setFontFromControlSize): (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::checkboxMargins): (WebCore::RenderThemeMac::setCheckboxCellState): (WebCore::RenderThemeMac::setCheckboxSize): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::radioMargins): (WebCore::RenderThemeMac::setRadioCellState): (WebCore::RenderThemeMac::setRadioSize): (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::buttonMargins): (WebCore::RenderThemeMac::setButtonSize): (WebCore::RenderThemeMac::setButtonCellState): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::popupButtonMargins): (WebCore::RenderThemeMac::popupButtonPadding): (WebCore::TopGradientInterpolate): (WebCore::BottomGradientInterpolate): (WebCore::MainGradientInterpolate): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
• rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeIndent): (WebCore::printBorderStyle): (WebCore::getTagName): (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::writeTextRun): (WebCore::write): (WebCore::writeLayers): (WebCore::nodePosition): (WebCore::writeSelection):
• rendering/RenderTreeAsText.h:
• rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcMinMaxWidth): (WebCore::RenderView::layout): (WebCore::RenderView::absolutePosition): (WebCore::RenderView::paint): (WebCore::RenderView::repaintViewRectangle): (WebCore::rendererAfterPosition): (WebCore::RenderView::selectionRect): (WebCore::RenderView::setSelection): (WebCore::RenderView::selectionStartEnd): (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
• rendering/RenderView.h: (WebCore::RenderView::renderName): (WebCore::RenderView::selectionStart): (WebCore::RenderView::selectionEnd):
• rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::resizeWidget): (WebCore::RenderWidget::setStyle): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::setSelectionState):
• rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::fillLineSelectionGap): (WebCore::RootInlineBox::selectionState): (WebCore::RootInlineBox::firstSelectedBox): (WebCore::RootInlineBox::lastSelectedBox): (WebCore::RootInlineBox::selectionTop): (WebCore::RootInlineBox::closestLeafChildForXPos):
• rendering/RootInlineBox.h: (WebCore::RootInlineBox::isRootInlineBox): (WebCore::RootInlineBox::setVerticalOverflowPositions): (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions): (WebCore::RootInlineBox::lineBreakObj): (WebCore::RootInlineBox::lineBreakPos): (WebCore::RootInlineBox::setLineBreakPos): (WebCore::RootInlineBox::blockHeight): (WebCore::RootInlineBox::setBlockHeight): (WebCore::RootInlineBox::endsWithBreak): (WebCore::RootInlineBox::setEndsWithBreak):
• rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
• rendering/SVGInlineFlowBox.h:
• rendering/SVGRenderTreeAsText.cpp: (WebCore::TextStreamSeparator::TextStreamSeparator): (WebCore::operator<<): (WebCore::hasFractions): (WebCore::writeIndent): (WebCore::writeStyle): (WebCore::getTagName): (WebCore::write): (WebCore::writeRenderResources):
• rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):
• rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
• rendering/SVGRootInlineBox.h:
• rendering/TableLayout.h:

3:34 PM Changeset in webkit [18262] by aroben

• 3 edits in trunk/WebCore

Build fixes.

• platform/ContextMenuItem.h: Fixed const declarations.
• platform/mac/ContextMenuItemMac.mm: Dito. (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

1:30 PM Changeset in webkit [18261] by adele

• 6 edits
  2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11189
<rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

• fast/forms/listbox-select-all-expected.txt: Added.
• fast/forms/listbox-select-all.html: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11189
<rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

Test: fast/forms/listbox-select-all.html

• dom/Node.h: We should try to find a more appropriate place to put these methods. (WebCore::Node::canSelectAll): Added. (WebCore::Node::selectAll): Added.
• editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Before selecting editable content, give the focused node a chance to select its content.
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Selects all items in a multi-select list box. Single-select list boxes will just do nothing, but we still want the select to handle this case when it has focus, rather than selecting other content.
• html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canSelectAll): Returns true for list boxes.

10:44 AM Changeset in webkit [18260] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-14 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11810

• Plugin/src/PluginWin.cpp: (CPluginWin::ViewFocusChanged): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):

9:37 AM Changeset in webkit [18259] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-14 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11810

• Plugin/src/PluginWin.cpp: (CPluginWin::ViewFocusChanged): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):

8:54 AM Changeset in webkit [18258] by zack

• 1 edit
  1 add in trunk/WebCore

Add a stub for SearchPopupMenu for Qt.

8:45 AM Changeset in webkit [18257] by zack

• 9 edits in trunk

Adjust Qt code to the last nights changes (make it compile)

4:31 AM Changeset in webkit [18256] by ap

• 2 edits in trunk/JavaScriptCore

Reviewed by Rob.

A deleted object was accessed to prepare RegExp construction error messages.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Wrap the RegExp into an OwnPtr.

2:56 AM Changeset in webkit [18255] by adele

• 2 edits in trunk/WebCore

One more...

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):

2:51 AM Changeset in webkit [18254] by adele

• 2 edits in trunk/WebCore

Missed one instance of isNonWidgetTextField.

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):

2:47 AM Changeset in webkit [18253] by ap

• 3 edits in trunk/WebCore

2006-12-16 Hunter L. Williams <​hlwebkit@gmail.com>

Reviewed by Adele.

Fix mouse wheel scrolling in <textarea> controls.

• rendering/RenderTextControl.cpp:
• rendering/RenderTextControl.h: Override |scroll| on RenderTextControl to forward the call to the RenderObject of the inner m_innerText, which has a layer that can be scrolled.

2:44 AM Changeset in webkit [22678] by adele

• 3 edits in branches/WindowsMerge/WebCore

RS by Adam.

Removed TextField, RenderLineEdit classes.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp:

2:38 AM Changeset in webkit [18252] by adele

• 5 edits
  6 deletes in trunk/WebCore

RS by Adam.

Removed RenderLineEdit, TextField, WebCoreTextField classes, and use of isNonWidgetTextField,

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::isMouseFocusable): (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::dispatchFocusEvent): (WebCore::HTMLInputElement::dispatchBlurEvent): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::defaultEventHandler):
• html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField):
• html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler):
• platform/TextField.h: Removed.
• platform/mac/TextFieldMac.mm: Removed.
• platform/mac/WebCoreTextField.h: Removed.
• platform/mac/WebCoreTextField.mm: Removed.
• rendering/RenderLineEdit.cpp: Removed.
• rendering/RenderLineEdit.h: Removed.

2:35 AM WebKit Team edited by Adam Roben

(diff)

2:35 AM WebKit Team edited by Adam Roben

(diff)

2:18 AM Changeset in webkit [18251] by adele

• 1 edit
  2 adds in trunk/WebCore

Two more files I forgot to svn add for search fields.

• platform/SearchPopupMenu.h: Added. (WebCore::SearchPopupMenu::create):
• platform/mac/SearchPopupMenuMac.mm: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):

2:12 AM Changeset in webkit [18250] by adele

• 1 edit
  1 add in trunk/WebCore

Reviewed by Adam.

• platform/PopupMenuClient.h: Added. Broken out of PopupMenu class. (WebCore::PopupMenuClient::~PopupMenuClient):

2:00 AM Changeset in webkit [18249] by ap

• 3 edits in trunk/LayoutTests

2006-12-16 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

• ​http://bugs.webkit.org/show_bug.cgi?id=11831 REGRESSION: pixel test failing for editing/selection/select-all-005.html

• editing/selection/select-all-005-expected.txt: Reverted to the original expected result for this test.
• editing/selection/select-all-005.html: Eliminated a script element that was added outside the body, so that the selection will encompass the entire html element as originally intended.

1:57 AM Changeset in webkit [22677] by adele

• 4 edits
  1 add in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added PopupMenu and theme code for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

• WebCore.vcproj/WebCore.vcproj:
• platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon):
• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupWndProc):
• platform/win/SearchPopupMenuWin.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchField): (WebCore::RenderThemeWin::adjustSearchFieldStyle): (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeWin::paintSearchFieldDecoration): (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
• rendering/RenderThemeWin.h:

1:56 AM Changeset in webkit [18248] by adele

• 38 edits in trunk

LayoutTests:

Reviewed by Adam.

Updated test results for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

• fast/events/onchange-searchfield-expected.txt:
• fast/forms/input-appearance-height-expected.checksum:
• fast/forms/input-appearance-height-expected.png:
• fast/forms/input-appearance-height-expected.txt:

WebCore:

Reviewed by Adam.

WebCore part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

• WebCore.xcodeproj/project.pbxproj: Added SearchPopupMenu.h, SearchPopupMenuMac.mm, and PopupMenuClient.h.

Added pseudo classes and corresponding values for -webkit appearance for the cancel button and for the three types of "decoration" that
correspond to the different functions of the magnifier glass in the search field. One for the button that will show and hide the
recent searches menu. One for decoration when the results attribute is set, but no results are saved. And one for decoration
when no results attribute is set. We added these different pseudo elements so that RenderTextControl can decide which pseudo class
is appropriate, and each theme can decide for itself which kind of image is appropriate for each function.

• css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
• css/CSSSelector.h: (WebCore::CSSSelector::): Added to PseudoType enum.
• css/CSSValueKeywords.in: Added searchfield-decoration, searchfield-results-decoration, searchfield-results-button, searchfield-cancel-button values.
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added cases for -webkit-search-cancel-button, -webkit-search-decoration, -webkit-search-results-decoration, -webkit-search-results-button
• rendering/RenderStyle.cpp: Addes new pseudoBits for matching pseudoIds. (WebCore::): (WebCore::pseudoBit):
• rendering/RenderStyle.h: Added new appearance values and pseudoIds. (WebCore::): (WebCore::RenderStyle::):
• css/html4.css: Added style for input[type=search], and the new pseudo elements.

The structure of the shadow DOM for new search field adds an intermediate block that contains 3 inline-blocks for the magnifier, text element, and cancel button.
Since the tree has become deeper, some editing and event code that used to check for a shadowParent, really needs to check the shadowAncestorNode.

• editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent): Check shadowAncestorNode instead of shadowParentNode.
• editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): ditto.
• editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): ditto. (WebCore::lastEditablePositionBeforePositionInRoot): ditto.
• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): ditto. (WebCore::ReplaceSelectionCommand::shouldMerge): Nil check enclosingBlock call. I ran into this while testing search fields in mixed editability. (WebCore::ReplaceSelectionCommand::doApply): ditto.

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Remove use of RenderLineEdit.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::addSearchResult): Added. Calls addSearchResult on the renderer.
• html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added case for search field. (WebCore::HTMLInputElement::isSearchField): Added.

• platform/PopupMenu.h: Broke PopupMenuClient out into a separate file.
• platform/PopupMenuClient.h: Added. (WebCore::PopupMenuClient::~PopupMenuClient):
• platform/graphics/Icon.h:

• platform/SearchPopupMenu.h: Added. Saves and loads recent search vector. (WebCore::SearchPopupMenu::create):
• platform/mac/SearchPopupMenuMac.mm: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):

• html/HTMLTextFieldInnerElement.h: Reorganized this class. Added subclasses HTMLTextFieldInnerTextElement, HTMLSearchFieldResultsButtonElement, HTMLSearchFieldCancelButtonElement (WebCore::HTMLTextFieldInnerElement::isMouseFocusable): Added. Returns false so setFocusNodeIfNeeded will try to focus the input element instead of nodes in the shadow tree. (WebCore::HTMLTextFieldInnerElement::isShadowNode): Now returns whether or not a shadowParent has been specified.
  • html/HTMLTextFieldInnerElement.cpp:

(WebCore::HTMLTextFieldInnerTextElement::HTMLTextFieldInnerTextElement):
(WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Moved this from the old HTMLTextFieldInnerElement class.
(WebCore::HTMLSearchFieldResultsButtonElement::HTMLSearchFieldResultsButtonElement):
(WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): Shows and hides recent searches menu.
(WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement):
(WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): On mouse up, clears the value from the text field.

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listSize): Changed return type to unsigned.
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::valueShouldChangeOnHotTrack): Added.

• WebCore.exp: Export _wkDrawTextFieldCellFocusRing.
• platform/mac/WebCoreSystemInterface.h: Added wkDrawTextFieldCellFocusRing
• platform/mac/WebCoreSystemInterface.mm: ditto.

• rendering/RenderTextControl.h: (WebCore::RenderTextControl::popupIsVisible): Added so HTMLSearchFieldResultsButtonElement knows whether or not the menu is already up. (WebCore::RenderTextControl::shouldPopOver): Added as a PopupClient method so the results menu shows up under the control instead of over. (WebCore::RenderTextControl::valueShouldChangeOnHotTrack):
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Initialize m_placeholderIsVisible, m_searchPopup, and m_searchPopupIsVisible. (WebCore::RenderTextControl::~RenderTextControl): Detach the node at the top of the shadow tree (m_innerBlock for search fields, and m_innerText for other text controls). (WebCore::RenderTextControl::setStyle): Sets style on new elements. (WebCore::disabledTextColor): Added so this can be used in setPlaceholder. (WebCore::RenderTextControl::createInnerBlockStyle): Added. (WebCore::RenderTextControl::createInnerTextStyle): Added. (WebCore::RenderTextControl::createResultsButtonStyle): Added. (WebCore::RenderTextControl::createCancelButtonStyle): Added. (WebCore::RenderTextControl::showPlaceholderIfNeeded): Added. Shows the placeholder if there's no value and the field doesn't have focus. (WebCore::RenderTextControl::hidePlaceholderIfNeeded): Added. Clears the placeholder if there's a value or the field has focus. (WebCore::RenderTextControl::createSubtreeIfNeeded): Added. Creates all of the shadow tree elements. (WebCore::RenderTextControl::updateFromElement): Calls showPlaceholderIfNeeded. (WebCore::RenderTextControl::visiblePositionForIndex): Renaming (m_div to m_innerText). (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::updateCancelButtonVisibility): Shows and hides cancel button based on the value of the control. (WebCore::RenderTextControl::subtreeHasChanged): Fires onSearch if the incremental attribute is set. (WebCore::RenderTextControl::text): Renaming. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::calcHeight): Take the size of the results button and cancel button into account when calculating height. (WebCore::RenderTextControl::nodeAtPoint): Act as if we've hit the shadow tree elements based on the x coordinate of the mouse event. (WebCore::RenderTextControl::layout): Set the height and width of the text block taking the other shadow tree elements into account. (WebCore::RenderTextControl::calcMinMaxWidth): Take new shadow tree elements into account when calculating width. (WebCore::RenderTextControl::forwardEvent): Forward events to appropriate shadow nodes. (WebCore::RenderTextControl::scrollWidth): Renaming. (WebCore::RenderTextControl::scrollHeight): ditto. (WebCore::RenderTextControl::scrollLeft): ditto. (WebCore::RenderTextControl::scrollTop): ditto. (WebCore::RenderTextControl::setScrollLeft): ditto. (WebCore::RenderTextControl::setScrollTop): ditto. (WebCore::RenderTextControl::autosaveName): ditto. (WebCore::RenderTextControl::addSearchResult): Added. Saves value to search result list. (WebCore::RenderTextControl::onSearch): Added. Dispatches search event. (WebCore::RenderTextControl::showPopup): Added. Loads searches, and displays menu. (WebCore::RenderTextControl::hidePopup): Added PopupClient method. (WebCore::RenderTextControl::valueChanged): Added PopupClient method. Interprets the selected menu item index, and either sets the value and fires onSearch, or clears all recent searches for this autosave name. (WebCore::RenderTextControl::itemText): Added PopupClient method. (WebCore::RenderTextControl::itemIsEnabled): Added PopupClient method. (WebCore::RenderTextControl::itemStyle): ditto. (WebCore::RenderTextControl::clientStyle): ditto. (WebCore::RenderTextControl::clientDocument): ditto. (WebCore::RenderTextControl::clientPaddingLeft): ditto. (WebCore::RenderTextControl::clientPaddingRight): ditto. (WebCore::RenderTextControl::listSize): ditto. (WebCore::RenderTextControl::selectedIndex): ditto. (WebCore::RenderTextControl::itemIsSeparator): ditto. (WebCore::RenderTextControl::itemIsLabel): ditto. (WebCore::RenderTextControl::itemIsSelected): ditto. (WebCore::RenderTextControl::setTextFromItem): ditto.

• rendering/RenderTheme.cpp: Added search field theme. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled): Returns false for search fields, until we've worked out the kinks. (WebCore::RenderTheme::adjustSearchFieldStyle): (WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle): (WebCore::RenderTheme::adjustSearchFieldDecorationStyle): (WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
• rendering/RenderTheme.h: (WebCore::RenderTheme::paintSearchField): (WebCore::RenderTheme::paintSearchFieldCancelButton): (WebCore::RenderTheme::paintSearchFieldDecoration): (WebCore::RenderTheme::paintSearchFieldResultsDecoration): (WebCore::RenderTheme::paintSearchFieldResultsButton):
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::sizeForSystemFont): Added. Compares style's font to systemFontSizeForControlSize to determine what controlSize to use after a style's font has already been initially adjusted. (WebCore::RenderThemeMac::controlSizeForSystemFont): Added. ditto. (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::menuListSizes): (WebCore::RenderThemeMac::minimumMenuListSize): Uses sizeForSystemFont instead of hardcoded adjusted font sizes. (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::cancelButtonSizes): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::resultsButtonSizes): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::paintSearchFieldDecoration): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

WebKit:

Reviewed by Adam.

WebKit part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKDrawTextFieldCellFocusRing.
• WebInspector/webInspector/inspector.css: Set -webkit-user-select:text and text-shadow:none on the search field. These are both properties that we didn't honor in the old control, and the inherited values didn't work or look right.

1:51 AM Changeset in webkit [18247] by ap

• 3 edits
  2 adds in trunk

2006-12-16 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11814 REGRESSION(r18098): Find does not work with capital letters

Test: editing/execCommand/findString-3.html

• wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::foldCase): Changed to not return an error if the result fits in the buffer without a null terminator.

1:50 AM Changeset in webkit [18246] by adele

• 3 edits in trunk/WebKitLibraries

Reviewed by Adam.

WebKitLibraries part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

Added wkDrawTextFieldCellFocusRing.

• WebKitSystemInterface.h:
• libWebKitSystemInterface.a:

1:45 AM Changeset in webkit [22676] by bdakin

• 5 edits in branches/WindowsMerge/WebKitWin

WebCoreWin:

Reviewed by Adam.

Boomer side of making WebCore Context Menus support state and
enabled/disabled, and re-architecture of ContextMenuItem.

• platform/win/ContextMenuItemWin.cpp: ContextMenuItem class holds the platformDescription as the sole member variable. Changes to account for this. (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::releasePlatformDescription): Same. (WebCore::ContextMenuItem::type): Same (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setType): Same. (WebCore::ContextMenuItem::setTitle): Same. (WebCore::ContextMenuItem::setSubMenu): Same. (WebCore::ContextMenuItem::setChecked): Same. (WebCore::ContextMenuItem::setEnabled): Same.
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::insertItem): Takes ownership of the item by calling releasePlatformDescription() (WebCore::ContextMenu::appendItem): Same. (WebCore::ContextMenu::itemWithAction): This is the new at(). Since we are no longer using notifybypos, we instead need a way to find a menu item by its action. (Its ID.) (WebCore::ContextMenu::setPlatformDescription): No longer use notifybypos

1:33 AM Changeset in webkit [18245] by bdakin

• 21 edits in trunk

WebCore:

Reviewed by Adam (and partially Geoff).

Primarily, this patch gives WebCore context menus the ability to
enable/disable and set state. It does a few other things along the
way, though. Some of the more noticeable things:

-Re-architects the ContextMenuItem class a bit so that the

ownership model is a bit less confusing. ContextMenuItem is
now *purely* a wrapper for the platformDescription. There
are no other member variables. If you ever need the
platformDescription outside of the MenuItem class, you have
to call releasePlatformDescription(), which transfers
ownership of the platformDescription to the caller.

-Moves fontForSelection() from FrameMac into Editor.cpp.

Turns out I don't need to use this function for my patch
after all, but it doesn't seem like a terrible idea to move
it anyway since we seem to be moving things from FrameMac
into Editor these days anyway.

WebKit:

Reviewed by Adam.

WebKit side of making WebCore context menus support state and
enabled/disabled.

• WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected takes a pointer to the parentMenu now since menu items no longer hold onto it.
• WebCoreSupport/WebContextMenuClient.mm: Same. (WebContextMenuClient::contextMenuItemSelected): Same.
• WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our menu. (-[NSArray menuForEvent:]):
• WebView/WebUIDelegatePrivate.h: No need for if-def.

Dec 15, 2006:

6:50 PM Changeset in webkit [18244] by bdash

• 3 edits in trunk/WebCore

2006-12-15 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Oliver.

Allow images to load into frames again. Tidy up code a bit and
add some much needed documentation.

• platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes):
• platform/MimeTypeRegistry.h:

5:50 PM Changeset in webkit [22675] by andersca

• 2 edits in branches/WindowsMerge/WebCore

• platform/win/TemporaryLinkStubs.cpp: Remove DocumentLoader::isStopped because it's now in DocumentLoader.cpp.

4:41 PM Changeset in webkit [18243] by andersca

• 3 edits in trunk/WebCore

Fix build.

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::mainDocumentError):
• loader/DocumentLoader.h:

4:05 PM Changeset in webkit [18242] by andersca

• 11 edits in trunk

WebCore:

Reviewed by Geoff.

More loader cleanup.

• loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::prepareForLoadStart):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::setResponse):
• loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):

WebKit:

Reviewed by Geoff.

Update for WebCore changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
• WebView/WebDataSource.mm: (-[WebDataSource response]):

2:58 PM Changeset in webkit [18241] by andersca

• 2 edits in trunk/WebCore

• loader/DocumentLoader.h: Whoops, didn't mean to commit this.

2:57 PM Changeset in webkit [18240] by andersca

• 6 edits in trunk/WebCore

Reviewed by Darin and Brady (in no particular order).

More loader cleanup.

• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError):
• loader/mac/MainResourceLoaderMac.mm:
• loader/mac/NetscapePlugInStreamLoaderMac.mm:

2:24 PM Changeset in webkit [22674] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

I'm in ur prjct, fxng ur build.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadResourceSynchronously):

2:02 PM Changeset in webkit [18239] by ap

• 2 edits in trunk/WebCore

Try to fix Windows build: add EventTarget.{h,cpp}.

1:49 PM Changeset in webkit [18238] by ap

• 22 edits
  2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11610
XMLHttpRequest.onreadystatechange doesn't provide access to the request object

Created a separate EventTarget class, now that EventTargetNode isn't the only kind.

WebCore:

• WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}

• bindings/js/kjs_dom.cpp: (KJS::toJS): Added an EventTarget variant.
• bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.

• bindings/objc/DOM.mm: (+[DOMNode _eventTargetWith:WebCore::]):
• bindings/scripts/CodeGeneratorObjC.pm: Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal). It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest. Corrected spelling of internalHeaderContent.

• dom/Event.cpp: (WebCore::Event::setTarget):
• dom/Event.h: (WebCore::Event::target): (WebCore::Event::currentTarget): (WebCore::Event::setCurrentTarget): These methods now work with EventTargets instead of Nodes.

• dom/EventTarget.cpp: Added. (WebCore::EventTarget::~EventTarget): (WebCore::EventTarget::toNode): (WebCore::EventTarget::toXMLHttpRequest):
• dom/EventTarget.h: Added. (WebCore::EventTarget::ref): (WebCore::EventTarget::deref): Originally, my intention was to share much of the implementation between EventTargetNode and XHR, but now I don't see anything substantial worth sharing.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.

• dom/EventTargetNode.h: Made EventTarget methods virtual. (WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget. (WebCore::EventTargetNode::refEventTarget): (WebCore::EventTargetNode::derefEventTarget):

• dom/MouseEvent.cpp: (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
• dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
• rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): Cast from EventTarget to Node as appropriate.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener): Set target and currentTarget before dispatching.

• xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter to match EventTargetNode. (WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget. (WebCore::XMLHttpRequest::refEventTarget): (WebCore::XMLHttpRequest::derefEventTarget):

LayoutTests:

• fast/dom/xmlhttprequest-get-expected.txt:
• http/tests/xmlhttprequest/event-target-expected.txt:
• http/tests/xmlhttprequest/event-target.html:

1:08 PM Changeset in webkit [18237] by andersca

• 12 edits in trunk

WebCore:

Reviewed by Darin.

More loader cleanup, use KURL instead of NSURL in a couple of places.

• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/ResourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::prepareForLoadStart):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willUseArchive):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):

WebKit:

Reviewed by Darin.

Update for WebCore changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive):
• WebView/WebDataSource.mm: (-[WebDataSource _URLForHistory]):

12:40 PM Changeset in webkit [18236] by ap

• 13 edits
  3 moves
  5 adds
  2 deletes in trunk

2006-12-15 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Darin and Alexey.

Fix the Windows build, move various Client implementations out of
WebCore and into WebKit.

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ChromeClientWin.h: Removed.
• bridge/win/ContextMenuClientWin.h: Removed.
• bridge/win/EditorClientWin.h: Removed.
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• bridge/win/FrameWin.h:
• loader/win/FrameLoaderClientWin.cpp: Removed.
• loader/win/FrameLoaderClientWin.h: Removed.
• platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::DocumentLoader::URL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::~Pasteboard): (WebCore::PolicyCheck::call): (WebCore::PopupMenu::PopupMenu): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceLoader::cancel):

WebKit:

• COM/ChromeClientWin.cpp: Added. (ChromeClientWin::~ChromeClientWin): (ChromeClientWin::chromeDestroyed): (ChromeClientWin::setWindowRect): (ChromeClientWin::windowRect): (ChromeClientWin::pageRect): (ChromeClientWin::scaleFactor): (ChromeClientWin::focus): (ChromeClientWin::unfocus): (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog): (ChromeClientWin::show): (ChromeClientWin::canRunModal): (ChromeClientWin::runModal): (ChromeClientWin::setToolbarsVisible): (ChromeClientWin::toolbarsVisible): (ChromeClientWin::setStatusbarVisible): (ChromeClientWin::statusbarVisible): (ChromeClientWin::setScrollbarsVisible): (ChromeClientWin::scrollbarsVisible): (ChromeClientWin::setMenubarVisible): (ChromeClientWin::menubarVisible): (ChromeClientWin::setResizable): (ChromeClientWin::addMessageToConsole):
• COM/ChromeClientWin.h: Added.
• COM/ContextMenuClientWin.cpp: Added. (ContextMenuClientWin::~ContextMenuClientWin): (ContextMenuClientWin::contextMenuDestroyed): (ContextMenuClientWin::addCustomContextMenuItems): (ContextMenuClientWin::contextMenuItemSelected): (ContextMenuClientWin::copyLinkToClipboard): (ContextMenuClientWin::downloadURL): (ContextMenuClientWin::copyImageToClipboard): (ContextMenuClientWin::lookUpInDictionary): (ContextMenuClientWin::speak): (ContextMenuClientWin::stopSpeaking):
• COM/ContextMenuClientWin.h: Added.
• COM/EditorClientWin.cpp: Added. (EditorClientWin::~EditorClientWin): (EditorClientWin::pageDestroyed): (EditorClientWin::shouldDeleteRange): (EditorClientWin::shouldShowDeleteInterface): (EditorClientWin::smartInsertDeleteEnabled): (EditorClientWin::isContinuousSpellCheckingEnabled): (EditorClientWin::toggleContinuousSpellChecking): (EditorClientWin::isGrammarCheckingEnabled): (EditorClientWin::toggleGrammarChecking): (EditorClientWin::spellCheckerDocumentTag): (EditorClientWin::selectWordBeforeMenuEvent): (EditorClientWin::isEditable): (EditorClientWin::shouldBeginEditing): (EditorClientWin::shouldEndEditing): (EditorClientWin::shouldInsertNode): (EditorClientWin::shouldInsertText): (EditorClientWin::shouldApplyStyle): (EditorClientWin::didBeginEditing): (EditorClientWin::respondToChangedContents): (EditorClientWin::didEndEditing): (EditorClientWin::registerCommandForUndo): (EditorClientWin::registerCommandForRedo): (EditorClientWin::clearUndoRedoOperations): (EditorClientWin::canUndo): (EditorClientWin::canRedo): (EditorClientWin::undo): (EditorClientWin::redo):
• COM/EditorClientWin.h: Added.
• COM/WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::initWithName):
• COM/WebFrame.h:
• COM/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::frameLoaderDestroyed): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent):
• COM/WebFrameLoaderClient.h: Added.
• COM/WebKitDLL.h:
• WebKit.vcproj/WebKit.vcproj:

WebKitTools:

• Spinneret/Spinneret.sln:

12:11 PM Changeset in webkit [18235] by andersca

• 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11842
REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history

• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URLForHistory): Don't return appleweburls without an unreachable url.

11:48 AM Changeset in webkit [18234] by andersca

• 12 edits in trunk

WebCore:

Reviewed by Darin.

Replace more instances of NSError with ResourceError.

Also remove a check for a selector that was added pre-Tiger.

• WebCore.exp:
• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/ResourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::cancelledError):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didCancel):

WebKit:

Reviewed by Darin.

Include ResourceError.h.

• Plugins/WebNetscapePluginStream.mm:
• WebKit.xcodeproj/project.pbxproj:

11:31 AM Changeset in webkit [18233] by rwlbuis

• 13 edits
  5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11824
CSSStyleSheet.title property is always null

Set title on the stylesheet just after creating it, for the HTML
elements <link> and <style>.

4:26 AM Changeset in webkit [18232] by zack

• 3 edits in trunk/WebCore

Fix compilation (from lars)

Dec 14, 2006:

11:50 PM Changeset in webkit [22673] by ggaren

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

ChangeLog fixup

11:46 PM Changeset in webkit [22672] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

WARNING: NO TEST CASES ADDED OR CHANGED

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe):

8:10 PM Changeset in webkit [22671] by adele

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):

8:04 PM Changeset in webkit [18231] by andersca

• 21 edits in trunk

WebCore:

Reviewed by Maciej.

Use char* pointer + length instead of NSData in a bunch of places.

• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData):
• loader/SubresourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::committedLoad):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::didReceiveData):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveData):
• platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
• platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

Reviewed by Maciej.

Update for WebCore changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::deliverArchivedResources):
• WebView/WebView.mm: (-[WebView _incrementProgressForIdentifier:length:]):
• WebView/WebViewInternal.h:

8:02 PM Changeset in webkit [18230] by adele

• 5 edits in trunk/WebCore

Reviewed by Adam.

Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.

• platform/PopupMenu.h: (WebCore::PopupMenuClient::~PopupMenuClient): (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed. (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList. (WebCore::PopupMenu::client): Added.
• platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList. (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer. (WebCore::PopupMenu::show): ditto. (WebCore::PopupMenu::hide): ditto.
• rendering/RenderMenuList.h: Now also inherits from PopupMenuClient. (WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient(). (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent can add children, and you don't want to do that in the middle of calculating width. (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list. (WebCore::RenderMenuList::itemIsEnabled): ditto. (WebCore::RenderMenuList::itemStyle): ditto. (WebCore::RenderMenuList::clientStyle): ditto. (WebCore::RenderMenuList::clientDocument): ditto. (WebCore::RenderMenuList::clientPaddingLeft): ditto. (WebCore::RenderMenuList::clientPaddingRight): ditto. (WebCore::RenderMenuList::listSize): ditto. (WebCore::RenderMenuList::selectedIndex): ditto. (WebCore::RenderMenuList::itemIsSeparator): ditto. (WebCore::RenderMenuList::itemIsLabel): ditto. (WebCore::RenderMenuList::itemIsSelected): ditto. (WebCore::RenderMenuList::setTextFromItem): ditto.

7:43 PM Changeset in webkit [18229] by ggaren

• 8 edits
  2 adds in trunk

LayoutTests:

Updated these results now that I've rolled out my change to move focus
to the page level:

• editing/undo/undo-iframe-location-change-expected.txt:
• fast/forms/focus2-expected.txt:

Added this test for one of the regressions that moving focus to the page
level caused:

• editing/selection/inactive-selection-expected.txt: Added.
• editing/selection/inactive-selection.html: Added.

WebCore:

Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text

Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window

I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).

Hopefully we can revisit this, along with hover and active, in the future.

• dom/Document.cpp: (WebCore::widgetForNode): (WebCore::relinquishesEditingFocus): (WebCore::acceptsEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::focusedNodeDetached): (WebCore::Document::setFocusedNode):
• dom/Document.h: (WebCore::Document::focusedNode):
• page/FocusController.cpp:
• page/FocusController.h:

7:34 PM Changeset in webkit [22670] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:27 PM Changeset in webkit [18228] by sfalken

• 1 copy in tags/Safari-521.32.3b

New tag.

7:14 PM Changeset in webkit [18227] by mjs

• 2 edits in trunk/WebCore

Reviewed by Geoff.

• fix failing drag & drop layout tests

• platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into nil.

6:25 PM Changeset in webkit [18226] by thatcher

• 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4827549> need NSRange-based selection support exposed.

• WebView/WebFrame.mm: (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]):
• WebView/WebFramePrivate.h:

6:18 PM Changeset in webkit [22669] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

• platform/win/TemporaryLinkStubs.cpp: (SubresourceLoader::didCancel):

5:30 PM Changeset in webkit [18225] by sfalken

• 2 edits in trunk/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

• loader/MainResourceLoader.h:

5:24 PM Changeset in webkit [18224] by bdash

• 3 edits in branches/Safari-2-0-branch/WebKit

2006-12-14 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-11-14 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.

2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

• WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
• WebView/WebHTMLViewInternal.h:

4:58 PM Changeset in webkit [22668] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Added JSSVGPODTypeWrapper.h to the vcproj.

• WebCore.vcproj/WebCore.vcproj:

4:41 PM Changeset in webkit [18223] by andersca

• 18 edits in trunk

WebCore:

Reviewed by John.

Convert a bunch of NSErrors to ResourceError.

Make the ResourceError accessor functions const.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::interruptionForPolicyChangeError):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::didFail):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
• platform/network/ResourceError.h: (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

Reviewed by John.

Update for WebKit changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack):

4:10 PM Changeset in webkit [18222] by staikos

• 3 edits in trunk

Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

3:48 PM Changeset in webkit [22667] by adele

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Build Fix.

• WebContextMenuClient.h:

3:40 PM Changeset in webkit [22666] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Build fix.

• platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::URL): (ResourceHandle::loadResourceSynchronously):

3:30 PM Changeset in webkit [18221] by justing

• 11 edits
  8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

• editing/deleting/4866671-expected.checksum: Added.
• editing/deleting/4866671-expected.png: Added.
• editing/deleting/4866671-expected.txt: Added.
• editing/deleting/4866671.html: Added.
• editing/pasteboard/4866671-expected.checksum: Added.
• editing/pasteboard/4866671-expected.png: Added.
• editing/pasteboard/4866671-expected.txt: Added.
• editing/pasteboard/4866671.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.

• dom/Document.cpp: (WebCore::Document::updateSelection):
• dom/Position.cpp: (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::nodeIsUserSelectNone): (WebCore::Position::isCandidate): (WebCore::Position::rendersInDifferentPosition):
• dom/Position.h:
• editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
• editing/htmlediting.cpp: (WebCore::nextCandidate): (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousCandidate): (WebCore::previousVisuallyDistinctCandidate):
• editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph):
• page/Frame.cpp: (WebCore::Frame::styleForSelectionStart):

3:16 PM Changeset in webkit [18220] by hyatt

• 2 edits in trunk/WebCore

Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.

Reviewed by ggaren

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):

2:13 PM Changeset in webkit [18219] by andersca

• 6 edits in trunk/WebCore

Reviewed by John.

General loader cleanup, convert NSURLResponse to ResourceResponse in some places.

• loader/DocumentLoader.h:
• loader/SubresourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::addResponse):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::opened):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):

1:04 PM Changeset in webkit [22665] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Fix the build.

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::loadResourceSynchronously): (ResourceHandle::loadResourceSynchronously):

12:56 PM Changeset in webkit [22664] by adachan

• 6 edits in branches/WindowsMerge/WebKitWin

2006-12-14 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

Implemented WebChromeClient::pageRect() to return the bounds of the WebView.
Implemented WebFrame::parentFrame().
Added a temporary implementation of WebDataSource::isLoading().

12:50 PM Changeset in webkit [18218] by andersca

• 15 edits in trunk/WebCore

Reviewed by Darin.

Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.

Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

Get rid of ServeSynchronousRequest and use the loader instead.

• WebCore.exp:
• dom/XMLTokenizer.cpp: (WebCore::openFunc):
• loader/FrameLoader.h:
• loader/LoaderFunctions.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/LoaderFunctionsMac.mm:
• platform/network/ResourceError.h: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::isNull):
• platform/network/ResourceHandle.h:
• platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isConditional):
• platform/network/ResourceRequest.h:
• platform/network/mac/ResourceErrorMac.mm: (-[NSError WebCore]):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously):
• xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

12:42 PM Changeset in webkit [18217] by zimmermann

• 6 edits
  1 add in trunk/WebCore

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11830

Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

11:30 AM Changeset in webkit [18216] by thatcher

• 4 edits in trunk

top level:

Reviewed by Brady.

• Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

Reviewed by Brady.

• Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

10:05 AM Changeset in webkit [18215] by ap

• 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

9:32 AM Changeset in webkit [18214] by hausmann

• 2 edits in trunk/WebKitQt

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack.

• QtLauncher/QtLauncher.pro: Link this little test program with rpath, for convenience. (This is never going to get installed anyway)

8:47 AM Changeset in webkit [18213] by hausmann

• 2 edits in trunk/WebCore

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack Rusin.

• WebCore.pro: Clean up the xpath grammar generation rule.

6:22 AM Changeset in webkit [18212] by zack

• 2 edits in trunk/WebCore

Make it link with temporary stubs (from lars, icefox)

3:40 AM Changeset in webkit [18211] by zack

• 4 edits in trunk/WebCore

Compilation fixes for the Qt port after last nights changes

2:36 AM Changeset in webkit [18210] by rwlbuis

• 10 edits
  4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing

Take into account the overflowRect when hit-testing <svg> container.

12:50 AM Changeset in webkit [18209] by bdash

• 2 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-05-14 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8739 Crash in RenderTableSection::paint due to manipulating DOM on resize

Manual test: manual-tests/dom-manipulation-on-resize.html

• WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.

Dec 13, 2006:

11:52 PM Changeset in webkit [18208] by hyatt

• 5 edits in trunk/WebCore

Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.

Reviewed by olliej

• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
• rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
• rendering/RenderTable.cpp: (WebCore::RenderTable::paint):

11:33 PM Changeset in webkit [18207] by bdash

• 3 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2005-09-06 David Hyatt <​hyatt@apple.com>

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

5:30 PM Changeset in webkit [18206] by andersca

• 2 edits in trunk/WebCore

• loader/FrameLoader.h: id is mac-only.

5:04 PM Changeset in webkit [22663] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Fix the build.

• platform/win/TemporaryLinkStubs.cpp: (PolicyCheck::call): (DocumentLoader::URL):

3:34 PM Changeset in webkit [18205] by beidson

• 2 edits in trunk/WebCore

Implicitly reviewed by Darin, Hyatt, Maciej, and others!

Fixes a document tear down crash.
Changes a few long standing assertions to our new style

• dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::topDocument):

3:22 PM Changeset in webkit [18204] by mjs

• 2 edits in trunk

Reviewed by Brady and Anders.

• Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.

3:20 PM Changeset in webkit [18203] by mjs

• 30 edits in trunk

JavaScriptCore:

Reviewed by Anders.

• added equality and inequality operations for HashMap and Vector, useful for comparing more complex types

• wtf/HashMap.h: (WTF::operator==): (WTF::operator!=):
• wtf/Vector.h: (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Anders.

• converted many places to use ResourceRequest instead of NSURLRequest

• WebCore.exp:
• loader/DocumentLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck):
• loader/FrameLoader.h: (WebCore::PolicyCheck::request):
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::URLForHistory):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::applyUserAgent): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::originalRequestURL): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
• loader/mac/WebDataProtocol.h:
• loader/mac/WebDataProtocol.mm:
• platform/KURL.cpp: (WebCore::operator!=):
• platform/KURL.h:
• platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL):
• platform/network/FormData.h: (WebCore::operator==): (WebCore::operator!=):
• platform/network/ResourceRequest.cpp: (WebCore::operator==):
• platform/network/ResourceRequest.h:
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Anders.

• adjusted for changes from NSURLRequest to ResourceRequest

• Plugins/WebPluginController.mm:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::createDocumentLoader):
• WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
• WebView/WebDocumentLoaderMac.h:
• WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
• WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame loadArchive:]):

3:19 PM Changeset in webkit [22662] by ggaren

• 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Minor problems remain with focus in frames, but basic editing / cursor
focus works.

I moved tracking of the focused frame from the Widget hiearchy to Page's
FocusController. Not all widgets are frames, so this change cleaned up a
dubious static cast. Also, the DOM needs to track frame focus because (1)
it needs to respond to focus changes and (2) you can focus an element /
frame even before it has a renderer / widget.

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::focusDocumentView): Implemented. This function is poorly named, based on the Mac design. (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really used on Windows, though.

WebKitWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Updated WebKit to use new FocusController tracking of the focused frame.

• WebView.cpp: (WebViewWndProc): Fixed a minor bug where we wouldn't fire the blur event when changing focus to the location bar.

3:10 PM Changeset in webkit [18202] by ggaren

• 8 edits in trunk/WebCore

Reviewed by Darin Adler, Dave Hyatt.

Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.

(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.
(WebCore::FocusController::focusedFrame):

• platform/Widget.h:

1:33 PM Changeset in webkit [18201] by justing

• 2 edits
  4 adds in trunk

Reviewed by adele

<rdar://problem/4818145>
Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides

There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.

• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition to fix the table case.

1:08 PM Changeset in webkit [22661] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:01 PM Changeset in webkit [18200] by sfalken

• 1 copy in tags/Safari-521.32.2b

New tag.

12:12 PM Changeset in webkit [22660] by sfalken

• 3 edits in branches/WindowsMerge/WebCore

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add WebCore forwarding headers to include paths

2006-11-14 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add missing ForwardingHeaders to project

• WebCore.vcproj/WebCore.make: Fixed line endings
• WebCore.vcproj/WebCore.vcproj: Added missing headers

12:02 PM Changeset in webkit [18199] by sfalken

• 1 edit
  2 adds in trunk/WebCore

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Added missing forwarding headers.

• ForwardingHeaders/kjs/value.h: Added.
• ForwardingHeaders/wtf/HashTable.h: Added.

9:05 AM Changeset in webkit [18198] by ggaren

• 2 edits in trunk/LayoutTests

Updated results to match Justin Garcia's addition of rangeCount to
the selection object.

• fast/dom/Window/window-properties-expected.txt:

6:45 AM Changeset in webkit [18197] by zack

• 3 edits in trunk/WebKitTools

Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob

5:16 AM Changeset in webkit [18196] by zack

• 6 edits in trunk

make it compile after last nights changes from lars (r=maciej,me)

Dec 12, 2006:

11:02 PM Changeset in webkit [22659] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

B&I build fix

• WebCore.vcproj/build-generated-files.sh:

6:48 PM Changeset in webkit [22658] by aliceli1

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region

• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):

6:41 PM Changeset in webkit [22657] by aroben

• 5 edits in branches/WindowsMerge/WebCore

6:34 PM Changeset in webkit [18195] by aroben

• 2 edits in trunk/WebCore

Reviewed by Anders.

Changed #import to #include to match the rest of our ForwardingHeaders.

• ForwardingHeaders/wtf/StringExtras.h:

5:46 PM Changeset in webkit [18194] by zbujtas

• 4 edits in S60/trunk/WebCore

2006-12-11 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/css/html4.css:
• khtml/css/html4_gcce.css:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):

5:41 PM Changeset in webkit [18193] by zbujtas

• 4 edits in S60/branches/3.1m/WebCore

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/css/html4.css:
• khtml/css/html4_gcce.css:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):

5:23 PM Changeset in webkit [22656] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [18192] by sfalken

• 1 copy in tags/Safari-521.32.0b

New tag.

4:48 PM Changeset in webkit [18191] by justing

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4757667>
GoogleDocs: Style menu does not open

• editing/selection/rangeCount-expected.txt: Added.
• editing/selection/rangeCount.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4757667>
GoogleDocs: Style menu does not open

• bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): Added rangeCount.
• bindings/js/kjs_window.h: (KJS::Selection::):
• editing/SelectionController.h: (WebCore::SelectionController::rangeCount): Added.

3:58 PM Changeset in webkit [18190] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Oliver.

• bindings/js/JSSVGMatrixCustom.cpp: added #ifdef SVG_SUPPORT

3:45 PM Changeset in webkit [18189] by andersca

• 2 edits in trunk/WebCore

Suggested by Darin.

• loader/ResourceLoader.cpp: Move down include of ResourceHandle.h.

3:30 PM Changeset in webkit [18188] by ggaren

• 2 edits in trunk/WebCore/page

Fixing up svn properties on FocusController.*

2:19 PM Changeset in webkit [22655] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Added FocusController to project.

• WebCore.vcproj/WebCore.vcproj:

2:11 PM Changeset in webkit [18187] by ggaren

• 7 edits
  2 adds in trunk/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.

Layout tests pass.

• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp: (WebCore::Document::view): (WebCore::Document::page): New helper function.
• dom/Document.h: Moved setters before getters. (WebCore::Document::hoverNode): (WebCore::Document::activeNode):
• dom/Node.cpp: (WebCore::Node::detach): Use the FocusController.
• page/FocusController.cpp: Added. (WebCore::shouldFocus): renamed and refactored this helper function. (WebCore::shouldUnfocus): ditto.
• page/FocusController.h: Added.

2:03 PM Changeset in webkit [18186] by andersca

• 3 edits in trunk/WebCore

Rubber Stamped by Geoff.

• platform/Base64.cpp:
• platform/Base64.h: Put functions inside of the WebCore namespace.

1:50 PM Changeset in webkit [22654] by andersca

• 6 edits in branches/WindowsMerge

WebCoreWin:

• loader/win/ResourceLoaderWin.cpp:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
• platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadsBlocked): Update for changes to ResourceHandle.

WebKitWin:

• WebFrame.cpp: (WebFrame::loadDataSource): Update for changes to ResourceHandle.

1:42 PM Changeset in webkit [18185] by andersca

• 4 edits in trunk/WebCore

Try fixing the non-Mac builds.

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail):
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
• loader/SubresourceLoader.h:

1:14 PM Changeset in webkit [18184] by andersca

• 18 edits in trunk

WebCore:

Reviewed by Darin.

Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

• WebCore.exp: Add new methods needed by WebKit.

• WebCore.xcodeproj/project.pbxproj: Make ResourceHandle.h a private header.

• loader/FrameLoaderClient.h: Change the download method to take a ResourceHandle instead of an NSURLConnection.

• loader/MainResourceLoader.h: Get rid of the proxy instance variable, that's handled by ResourceHandlw now.

• loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::handle):
• loader/SubresourceLoader.h: Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.

• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): Use a ResourceHandle instead of an NSURLConnection.

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail): Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.

• loader/mac/SubresourceLoaderMac.mm: Remove ResourceHandleClient methods.

• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.

• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseProxy): (WebCore::ResourceHandle::connection): New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing connection.

WebKit:

Reviewed by Darin.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Get the handle and proxy from the ResourceHandle now that they aren't passed to us.

12:13 PM Changeset in webkit [18183] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):

12:09 PM Changeset in webkit [18182] by ap

• 7 edits in trunk

Reviewed by Geoff. Based on a patch by Maks Orlovich.

​http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)

JavaScriptCore:

• kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
• kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.

• tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.

LayoutTests:

• fast/js/kde/RegExp-expected.txt: One more test passes.

11:50 AM SVG TODO List - Short notes edited by ojh16@student.canterbury.ac.nz

text+filter stuff (diff)

11:42 AM Changeset in webkit [18181] by andersca

• 3 edits in trunk/WebCore

Reviewed by Geoff.

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of the DocLoader parameter to ResourceHandle::create.

11:41 AM Changeset in webkit [22653] by darin

• 2 edits in branches/WindowsMerge/WebCore

• fix build

• WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.

11:32 AM Changeset in webkit [18180] by ggaren

• 1 edit in trunk/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt

Oops. Forgot to check in this file.

9:52 AM SVG TODO List - Short notes edited by zimmermann@kde.org

(diff)

9:01 AM Changeset in webkit [18179] by spadma

• 5 edits in S60/branches/3.1m/WebKit

2006-12-11 sareen <​shyam.sareen@nokia.com>

Reviewed Sachin Padma.
DESC: Saved Pages: Some Images not saved with the page.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11721

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
• ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):

4:09 AM Changeset in webkit [18178] by staikos

• 3 edits in trunk/WebCore

Make the last checkin compile

3:19 AM Changeset in webkit [18177] by zimmermann

• 55 edits
  1 add
  2 deletes in trunk

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11797

Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

1:55 AM Changeset in webkit [18176] by staikos

• 9 edits in trunk

Fix the Qt build

1:02 AM Changeset in webkit [18175] by ggaren

• 8 edits
  4 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Added some focus-related tests.

• editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect the fact that we now unfocus nodes when they're removed from the document.

• fast/events/keypress-removed-node-expected.txt: Added.
• fast/events/keypress-removed-node.html: Added.
• fast/forms/focus2-expected.txt: Added.
• fast/forms/focus2.html: Added.

WebCore:

Reviewed by Beth Dakin.

Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.

We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.

• dom/Document.cpp: Migrated code to Page (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::setFocusedNode): (WebCore::Document::focusedNode):
• dom/Document.h:
• dom/Node.cpp: (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes the minor bug and was also necessary to prevent regressions caused by hanging on to a focused node after the document was replaced.
• dom/Node.h: (WebCore::Node::inDetach):
• page/Page.cpp: Migrated code from Document (WebCore::shouldAcquireEditingFocus): (WebCore::shouldRelinquishEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::widgetForNode): (WebCore::Page::setFocusedNode):
• page/Page.h: (WebCore::Page::focusedNode):

12:45 AM Changeset in webkit [18174] by ggaren

• 1 edit in trunk/WebCore/platform/Base64.cpp

build fix

12:28 AM Changeset in webkit [18173] by ap

• 2 edits in trunk/LayoutTests

Added the new XHR EventTarget methods to test results.

• fast/dom/Window/window-properties-expected.txt:

Dec 11, 2006:

11:59 PM Changeset in webkit [18172] by ap

• 6 edits
  2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11053
XMLHttpRequest should be an EventTarget

Test: http/tests/xmlhttprequest/event-target.html

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
• bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener):
• xml/xmlhttprequest.h: (WebCore::XMLHttpRequest::eventListeners): Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).

11:28 PM Changeset in webkit [22652] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj: Added missing files to project.

11:13 PM Changeset in webkit [22651] by sfalken

• 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

B&I build fix

11:13 PM Changeset in webkit [18171] by darin

• 5 edits in trunk/WebCore

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11809 fast/dom/gc-8.html crash in alternate-thread marking code in ScriptInterpreter

DocumentType objects were getting filed under the wrong document in the
DOM objects structure.

• bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
• bindings/js/kjs_binding.cpp: (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging. (KJS::addWrapper): Added. (KJS::removeWrapper): Added. (KJS::removeWrappers): Added. (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference to this wrapper since it's being destroyed. (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS. (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions we're calling. Another solution would be to reorder the two, but I think that would create a race where another thread could garbage collect after the forget but before the put. (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.

• dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
• dom/Node.cpp: (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here. (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument now takes care of that.

10:47 PM Changeset in webkit [18170] by ap

• 10 edits
  9 adds in trunk

​http://bugs.webkit.org/show_bug.cgi?id=9673
Add support for window.atob() and window.btoa()

Reviewed by Darin.

JavaScriptCore:

• JavaScriptCore.exp: Export UString::is8Bit().
• JavaScriptCore.xcodeproj/project.pbxproj: Added StringExtras.h as a private header.

WebCore:

• WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
• bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
• bindings/js/kjs_window.h: (KJS::Window::):
• platform/Base64.cpp: Added. (base64Encode): (base64Decode):
• platform/Base64.h: Added.
• ForwardingHeaders/wtf/StringExtras.h: Added.
• platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.

LayoutTests:

• fast/dom/Window/atob-btoa-expected.txt: Added.
• fast/dom/Window/atob-btoa.html: Added.
• fast/dom/Window/btoa-pnglet-expected.checksum: Added.
• fast/dom/Window/btoa-pnglet-expected.png: Added.
• fast/dom/Window/btoa-pnglet-expected.txt: Added.
• fast/dom/Window/btoa-pnglet.html: Added.
• fast/dom/Window/window-properties-expected.txt:

10:34 PM Changeset in webkit [22650] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-11 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.

• WebCore.vcproj/WebCore.vcproj:

9:56 PM Changeset in webkit [18169] by darin

• 8 edits
  10 moves in trunk

WebCore:

Reviewed by Brady.

• did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list

• WebCore.xcodeproj/project.pbxproj: Updated project for file moves.

• bridge/mac/FrameMac.h: Moved to page/mac.
• bridge/mac/FrameMac.mm: Ditto.
• bridge/mac/WebCoreFrameBridge.h: Ditto.
• bridge/mac/WebCoreFrameBridge.mm: Ditto.
• bridge/mac/WebCoreFrameView.h: Ditto.
• bridge/mac/WebCoreViewFactory.h: Ditto.
• bridge/mac/WebCoreViewFactory.m: Ditto.
• bridge/mac/WebDashboardRegion.h: Ditto.
• bridge/mac/WebDashboardRegion.m: Ditto.

• bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac, renamed WebCoreKeyboardUIMode.h, and made a C++ header.

• page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): Ditto. (WebCore::EventHandler::tabsToAllControls): Ditto. (WebCore::EventHandler::keyboardUIMode): Ditto.

WebKit:

Reviewed by Brady.

• did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list

• WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto. (-[WebFrameBridge keyboardUIMode]): Ditto.

9:47 PM Changeset in webkit [18168] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

• JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this (I think Hyatt is using an old Xcode).

9:03 PM Changeset in webkit [18167] by darin

• 2 edits in trunk/LayoutTests

• fast/frames/iframe-option-crash-expected.txt: Updated results for this test. My recent change to owner element lifetime management changed these results, but since the point of the test is simply to check if the page crashes, the new result is probably OK. Or there could be some problem, but if so we need some other investigation -- I couldn't see anything.

8:44 PM Changeset in webkit [22649] by bdakin

• 6 edits in branches/WindowsMerge/WebKitWin

Boomer WebKit support for editing sub-menu actions for WebCore
context menus.

• Interfaces/IWebUIDelegate.idl: Re-named some of the spelling sub-menu tags.
• WebContextMenuClient.cpp: New functions for the speech sub-menu. (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
• WebContextMenuClient.h:
• WebEditorClient.cpp: New functions to toggle spelling/grammar checking. (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
• WebEditorClient.h

8:27 PM Changeset in webkit [18166] by bdakin

• 16 edits in trunk

WebCore:

Reviewed by Adam.

Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:

-Made BUILDING_ON_TIGER ifdef work within C++ as well as

Obj-C

-Fixed bug where we would throw and Obj-C exception and

fail to pop up menus with more than one separator item.

-Re-named some of the spelling/grammar tags since Tiger and

Leopard share more of the actions than initially
anticipated.

• WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
• bridge/EditorClient.h: New functions to toggle spelling/grammar checking.
• editing/Editor.cpp: (WebCore::Editor::toggleContinuousSpellChecking): Call into client. (WebCore::Editor::toggleGrammarChecking): Same. (WebCore::Editor::toggleBold): call execToggleBold() (WebCore::Editor::toggleUnderline): Create appropriate underline style and apply to selection. (WebCore::Editor::setBaseWritingDirection): Create appropriate writing direction and apply to selection.
• editing/Editor.h:
• editing/mac/EditorMac.mm: New functions to show spelling guesses, fonts, styles, and color panels.
• page/ContextMenuClient.h: New functions for the speech sub-menu.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Fill in editing sub-menu actions.
• platform/ContextMenu.cpp: (WebCore::separatorItem): Helper function to create a separator item. (WebCore::createFontSubMenu): Put very mac-specific things within a platform ifdef. (WebCore::createSpellingAndGrammarSubMenu): Re-named some of the spelling sub-menu tags. (WebCore::createSpellingSubMenu): Same. (WebCore::ContextMenu::populate): We can't share the separator item. When we do, menus with more than one separator throw and obj- c exception and fail to pop-up.
• platform/ContextMenuItem.h: (WebCore::): Re-named some of the spelling sub-menu tags.

WebKit:

Reviewed by Adam.

WebKit support for editing sub-menu actions.

• WebCoreSupport/WebContextMenuClient.h: New functions for the speech sub-menu.
• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
• WebCoreSupport/WebEditorClient.h: New functions to toggle spelling/grammar checking.
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
• WebView/WebUIDelegatePrivate.h: Re-named some of the spelling sub-menu tags.

8:20 PM S60CheckoutAndBuild edited by thisisbradley@gmail.com

s60webkit path changes (diff)

7:26 PM Changeset in webkit [22648] by aliceli1

• 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
And some cleanup of PlatformMouseEvent(Win)

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Removed unnecessary check for mouse event type

• platform/win/PasteboardWin.cpp:

(WebCore::PasteboardOwnerWndProc):
(WebCore::createGlobalData):
Added more overloaded implemtations and renamed from createHandle

(WebCore::markupToCF_HTML):
Changed to handle less-specific input and renamed from createCF_HTML

(WebCore::urlToMarkup):
(WebCore::Pasteboard::writeURL):
Added these.

(WebCore::replaceNBSP):
Moved out of Pasteboard class

(WebCore::Pasteboard::clear):
Renamed from clearTypes.

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
Trivial cleanup of these.

• platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Removed anything having to do with unnecessary m_type

WebKitWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work

• Interfaces/IWebView.idl: Added copyURL.

• WebContextMenuClient.cpp:
• WebContextMenuClient.h: Removed copyLinkToClipboard

• WebView.cpp: (WebView::copy): (WebView::cut): (WebView::paste): Trivial cleanup of these

(WebView::copyURL):
Added this.

• WebView.h: Added copyURL.

7:17 PM Changeset in webkit [18165] by aliceli1

• 16 edits in trunk

WebCore:

Reviewed by Geoff, Adam.

Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.

All layout tests pass as they would without this patch.

• WebCore.exp: added Editor::copyURL to be called from WebKit

• editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Pasteboard::clearTypes() changed to clear()

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
Changed signature of writeSelection to take raw pointer instead of PassRefPtr

(WebCore::Editor::copyURL):

• editing/Editor.h: Added copyURL.

• page/ContextMenuClient.h:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Removed copyLinkToClipboard

• platform/KURL.cpp: (WebCore::KURL::lastPathComponent):
• platform/KURL.h: Added lastPathComponent.

• platform/Pasteboard.h: Changed some function names. Moved some functions out of class to static.

• platform/PlatformMouseEvent.h: (WebCore::): Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.

• platform/mac/PasteboardMac.mm: Added writeURL, and moved some things around

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm: Add some calls necessary for Pasteboard::writeURL to work

WebKit:

Reviewed by Geoff, Adam.

switch to use the Editor for copying URLs

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): Call down to the editor for this.
• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add some calls necessary for Pasteboard::writeURL to work

5:26 PM Changeset in webkit [18164] by zimmermann

• 50 edits in trunk/LayoutTests

Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.

3:50 PM SVG TODO List - Short notes edited by zimmermann@kde.org

(diff)

3:47 PM Changeset in webkit [22647] by darin

• 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady.

• ​http://bugs.webkit.org/show_bug.cgi?id=11794 fix lifetime problems affecting Frame's ownerElement pointer

• WebCore.vcproj/WebCore.vcproj: Update for added files.

• bridge/win/FrameWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame): Changed to use HTMLFrameOwnerElement.

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load): Changed to use HTMLFormElement.

WebKitWin:

Reviewed by Brady.

• ​http://bugs.webkit.org/show_bug.cgi?id=11794 fix lifetime problems affecting Frame's ownerElement pointer

• WebFrame.h:
• WebFrame.cpp: (WebFrame::initWithWebFrameView): Changed to use HTMLFrameOwnerElement. (WebFrame::createFrame): Ditto.

3:40 PM Changeset in webkit [18163] by darin

• 43 edits
  2 adds in trunk

WebCore:

Reviewed by Brady.

• ​http://bugs.webkit.org/show_bug.cgi?id=11794 fix lifetime problems affecting Frame's ownerElement pointer

• CMakeLists.txt:
• WebCore.vcproj/WebCore/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• WebCoreSources.bkl: Updated for new source files.

• WebCore.exp: Updated for changes to entry point names.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
• bridge/win/FrameWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• platform/qt/FrameQt.h:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): Updated owner element type to HTMLFrameOwnerElement.

• bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't use that any more. Updated owner element type to HTMLFrameOwnerElement.

• dom/Document.cpp: Added include so that the ownerElement function can compile (since it downcasts an HTMLFrameOwnerElement to an Element).

• html/HTMLFrameElement.cpp: (WebCore::containingFrameSetElement): Moved this function in here; it doesn't need to be a member function. (WebCore::HTMLFrameElement::attach): Updated to call this.

• html/HTMLFrameElementBase.h:
• html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and containingFrameSetElement. Removed friend classes.

• html/HTMLFrameOwnerElement.h: Added.
• html/HTMLFrameOwnerElement.cpp: Added.

• html/HTMLEmbedElement.h:
• html/HTMLEmbedElement.cpp:
• html/HTMLObjectElement.h:
• html/HTMLObjectElement.cpp: Remove now-unneeded contentDocument functions.

• html/HTMLPlugInElement.h:
• html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from HTMLFrameOwnerElement.

• loader/FormState.h:
• loader/FormState.cpp: Use HTMLFormElement instead of just Element.

• loader/FrameLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use HTMLFormElement. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::requestObject): Don't pass an element parameter to shouldUsePlugin, and remove now-unneeded type casts. (WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter. (WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement. (WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto. (WebCore::FrameLoader::isHostedByObjectElement): Ditto.
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Use HTMLFormElement. (WebCore::FrameLoader::post): Ditto. (WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.

• page/Frame.h:
• page/FramePrivate.h:
• page/Frame.cpp: (WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement. (WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::ownerRenderer): Ditto. (WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner element before disconnecting it. (WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.

• page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that the code here will compile (no code changes needed).

• rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.

• rendering/RenderPart.h:
• rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Use HTMLFrameOwnerElement.

• rendering/RenderPartObject.h:
• rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement. (WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.

• other changes

• platform/network/ResourceHandleInternal.h: Added Noncopyable and fixed indentation.

WebKit:

Reviewed by Brady.

• ​http://bugs.webkit.org/show_bug.cgi?id=11794 fix lifetime problems affecting Frame's ownerElement pointer

• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Use HTMLFrameOwnerElement.

• WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the HTMLFormElement class.

• WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.

• WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the change in return type of ownerElement.

3:11 PM Changeset in webkit [18162] by hyatt

• 2 edits in trunk/WebCore

Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.

Reviewed by darin

• platform/StringImpl.cpp: (WebCore::isSpace):

3:10 PM Changeset in webkit [18161] by hyatt

• 3 edits in trunk/JavaScriptCore

Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.

Reviewed by darin

• wtf/unicode/icu/UnicodeIcu.h:
• wtf/unicode/qt4/UnicodeQt4.h:

3:00 PM Changeset in webkit [22646] by lamadio

• 2 edits in branches/WindowsMerge/WebKitWin

2006-12-08 Lou Amadio <​lamadio@apple.com>

Reviewed by aroben,adachan
Implement Status Bar
<rdar://4601297> Status Bar feature
<rdar://4854036> subsequent windows have glass borders on vista
<rdar://4861165> Window cascade is off
<rdar://4804690> Window widgets clip highligh

2:51 PM Changeset in webkit [22645] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/page/win/EventHandlerWin.cpp

Fix build bustage.

2:06 PM Changeset in webkit [18160] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: remove the dependency on CAknSettingsCache
​http://bugs.webkit.org/show_bug.cgi?id=11806

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):

1:54 PM Changeset in webkit [18159] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: add flag to remove the SDK dependency on AknSettingsCache
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):

12:49 PM Changeset in webkit [22644] by bdakin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build fix from Nick Zimmerman's last check-in.

• WebCore.vcproj/WebCore.vcproj:

12:13 PM Changeset in webkit [18158] by ap

• 4 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11807
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

• page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::autoscrollTimerFired):
• page/EventHandler.h:
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::mouseMoved): Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

(WebCore::EventHandler::lastEventIsMouseUp):
Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.

12:13 PM Changeset in webkit [18157] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):

11:47 AM Changeset in webkit [18156] by yongjzha

• 2 edits in S60/trunk/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
​http://bugs.webkit.org/show_bug.cgi?id=11806

• BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):

10:52 AM Changeset in webkit [18155] by zimmermann

• 9 deletes in trunk/WebCore/bindings

I forgot to remove these in the previous commit, they were only emptied out.

10:03 AM Changeset in webkit [18154] by harrison

• 3 edits in trunk/WebKit

Fix previous checkin where I committed the wrong file.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

• WebView/WebFrame.mm: (-[WebFrame frameElement]): Add nil check.

• WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Reverted to previous.

9:55 AM Changeset in webkit [18153] by zimmermann

• 19 edits in trunk

Reviewed by Sam Weinig.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11801

Autogenerate POD types for ObjC/JS.

This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)

8:48 AM Changeset in webkit [18152] by yongjzha

• 2 edits in S60/branches/3.1m/WebCore

2006-12-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
​http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):

8:42 AM Changeset in webkit [18151] by yongjzha

• 4 edits in S60/trunk/WebKit

2006-12-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
​http://bugs.webkit.org/show_bug.cgi?id=11787

• BrowserView/inc/HttpLoaderEventToUiListener.h:
• BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
• ChangeLog:

8:24 AM Changeset in webkit [18150] by ap

• 2 edits in trunk/LayoutTests

Reviewed by Mitz.

Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).

• fast/text/atsui-rtl-override-selection.html:

Dec 10, 2006:

5:23 PM Changeset in webkit [18149] by zack

• 3 edits in trunk/WebCore

add missing receive call for resources

5:23 PM Changeset in webkit [18148] by staikos

• 2 edits in trunk/WebKitQt

Add a default useragent for now.

5:21 PM Changeset in webkit [18147] by zack

• 1 edit in trunk/WebKitQt/WebCoreSupport/ChromeClientQt.h

Fix a small issue (crash) with resource loading (from lars, r=me)

5:17 PM Changeset in webkit [18146] by staikos

• 2 edits in trunk/WebCore

Make the xpath grammar hack more specific (and work on OS X) until
it's cleaned up.

5:12 PM Changeset in webkit [18145] by zack

• 2 edits in trunk/WebCore

Set the WidgetClient in WidgetQt correctly. We need to make
this platform independent

4:13 PM Changeset in webkit [18144] by zack

• 2 edits in trunk/WebCore

Fixes loading of local files (from Lars)

2:49 PM Changeset in webkit [18143] by zack

• 3 edits in trunk/WebCore

Don't use QTransform yet, affine QMatrix is enough for SVG,
plus it makes it work with 4.2.

1:43 PM Changeset in webkit [18142] by zack

• 7 edits in trunk

Fixes for the layout tests regression testing and removal
of few unimplemented warnings (from lars)

1:37 PM Changeset in webkit [18141] by zack

• 5 edits in trunk

Enable the SVG build by default and make it build.

12:29 PM Changeset in webkit [18140] by zack

• 1 edit in trunk/WebCore/WebCore.pro

This should go in in 18139, it's WebKitQt not WebKit

12:05 PM Changeset in webkit [18139] by zack

• 5 edits
  8 moves
  1 add in trunk

Move the "*Client classes to WebKitQt/WebCoreSupport. Uptil
now they were all scattered around the Qt platform build dirs,
this cleans it up.

11:14 AM Changeset in webkit [18138] by staikos

• 2 edits in trunk

Add WebKitBuild/Release back to the output dir for external build cases.

11:02 AM Changeset in webkit [18137] by zack

• 5 edits in trunk/WebKitTools

Some more fixes to the dumprendertree application (from lars)

10:57 AM Changeset in webkit [18136] by zack

• 1 add in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro

Add the project file.

10:46 AM Changeset in webkit [18135] by zack

• 3 edits in trunk/WebCore

Add back some stubs needed to compile (from lars, r=me)

10:16 AM Changeset in webkit [18134] by rwlbuis

• 74 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10996
WebKit needs (possibly private) XML/SVG innerText support (for DumpRenderTree)

Create an internal method to create innerText functionality for non-HTML
nodes. When called from DRT this omits CDATA nodes.

2:17 AM Changeset in webkit [18133] by ap

• 3 edits in trunk/WebCore

2006-12-10 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11790
No way to initialize ResourceResponse::m_httpHeaderFields

• platform/network/ResourceResponse.cpp: impl setHTTPHeaderField (WebCore::ResourceResponse::setHTTPHeaderField):
• platform/network/ResourceResponse.h: decl setHTTPHeaderField

1:21 AM Changeset in webkit [18132] by zack

• 5 edits in trunk

Cleanup more of the FrameQt crack - mainly finally remove
the methods that have been moved to their proper locations.

Dec 9, 2006:

11:13 PM Changeset in webkit [18131] by zack

• 3 edits in trunk/WebCore

Remove unused/pointless code from FrameQtClient.

11:11 PM Changeset in webkit [18130] by aroben

• 2 edits in trunk/WebCore

Build fix.

• xml/XPathParser.cpp: (WebCore::XPath::charCat): Use C++ unsigned instead of uint.

10:54 PM Changeset in webkit [18129] by staikos

• 3 edits in trunk/WebCore

Reviewed by Zack.

Make it not crash, and make it set the title on Qt platform.

10:36 PM Changeset in webkit [18128] by zack

• 7 edits in trunk

Include DumpRenderTree in the Qt build and adjust it to the
recet platform/qt changes (by lars)

10:32 PM Changeset in webkit [22643] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Hyatt.

Use num-cpus to determine the number of jobs make should run
concurrently.

• WebCore.vcproj/build-generated-files.sh:

9:54 PM Changeset in webkit [18127] by staikos

• 2 edits in trunk

Correct the path to the libraries for QMake.

9:44 PM Changeset in webkit [18126] by zack

• 7 edits in trunk

Cleanup the FrameQtClient mess a little bit.

9:33 PM Changeset in webkit [18125] by zack

• 2 edits in trunk/WebCore

Accomodate the file changes in the project files (aka build)

9:12 PM Changeset in webkit [18124] by zack

• 10 edits
  4 adds
  2 deletes in trunk/WebCore

Implement a decent network loader using QHttp (from Lars)

8:58 PM Changeset in webkit [18123] by staikos

• 4 edits in trunk

Fix qmake build re: bison issues - unify with Linux build

8:36 PM Changeset in webkit [18122] by staikos

• 2 edits in trunk/WebKitTools

Repair QMake build on OS X.

8:25 PM Changeset in webkit [18121] by zack

• 5 edits in trunk

Small fixes for qmake shadow builds

7:57 PM Changeset in webkit [18120] by staikos

• 2 edits in trunk/WebKitTools

Remove reference to Unity. Reviewed by Zack.

7:27 PM Changeset in webkit [18119] by zack

• 3 edits in trunk

Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.

7:07 PM Changeset in webkit [22642] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix: <rdar://problem/4860184> Can't select context menu items with the
right mouse button

• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show):

6:52 PM Changeset in webkit [18118] by zack

• 2 edits in trunk/WebCore

Crazy notion: make the font setting on widgets work.

6:36 PM Changeset in webkit [18117] by zack

• 2 edits in trunk/WebCore

Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)

6:32 PM Changeset in webkit [18116] by zack

• 3 edits in trunk/WebCore

Fix some rounding issues

6:01 PM Changeset in webkit [18115] by zack

• 8 edits in trunk/WebCore

Fix build for Qt 4.1 and less (for Qtopia mainly). By George.

4:58 PM Changeset in webkit [18114] by zack

• 6 edits
  6 adds
  1 delete in trunk

CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.

4:44 PM Changeset in webkit [18113] by zack

• 2 adds in trunk/WebCore/platform/graphics/qt

This is part of r 18111 commit - Use the Qt image
loading framework.

4:41 PM Changeset in webkit [18112] by zack

• 4 edits in trunk/WebCore

Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.

4:37 PM Changeset in webkit [18111] by zack

• 4 edits in trunk/WebCore

Use the Qt image loading framework instead of the Mozilla
loaders

4:21 PM Changeset in webkit [18110] by zack

• 2 edits in trunk/WebCore

Remove an explicit ICU dependency (by lars)

4:19 PM Changeset in webkit [18109] by zack

• 4 edits in trunk

Fixing the kde build after the icu Qt changes.

4:01 PM Changeset in webkit [22641] by aroben

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Build fixes after OpenSource r18098 and r18106.

• WebCore.vcproj/WebCore.vcproj:
  • Changed include paths to reflect the now-flattened JSCore headers.
  • Added missing files to project.
  • Changed post-build step to also copy ForwardingHeaders.
  • Removed unnecessary definition of WTF_PLATFORM_CF from project file (it's already defined in config.h).
• platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed function calls. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):

WebKitWin:

Reviewed by Darin.

Build fix.

• WebKit.vcproj/WebKit.vcproj: Added WebCore/ForwardingHeaders to the include path.
• WebView.cpp: Updated to reflect the newly-flattend JSCore headers.

3:53 PM Changeset in webkit [18108] by aroben

• 31 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Some updates in reaction to r18098.

• wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all cases. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::isUpper):
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/WTF/WTF.vcproj:

WebCore:

Reviewed by Darin.

Changed all ForwardingHeaders to use #include instead of #import.

• ForwardingHeaders/kjs/JSLock.h:
• ForwardingHeaders/kjs/SavedBuiltins.h:
• ForwardingHeaders/kjs/collector.h:
• ForwardingHeaders/kjs/dtoa.h:
• ForwardingHeaders/kjs/internal.h:
• ForwardingHeaders/kjs/interpreter.h:
• ForwardingHeaders/kjs/lookup.h:
• ForwardingHeaders/kjs/object.h:
• ForwardingHeaders/kjs/property_map.h:
• ForwardingHeaders/kjs/protect.h:
• ForwardingHeaders/wtf/AlwaysInline.h:
• ForwardingHeaders/wtf/Assertions.h:
• ForwardingHeaders/wtf/FastMalloc.h:
• ForwardingHeaders/wtf/GetPtr.h:
• ForwardingHeaders/wtf/HashCountedSet.h:
• ForwardingHeaders/wtf/HashMap.h:
• ForwardingHeaders/wtf/HashSet.h:
• ForwardingHeaders/wtf/HashTraits.h:
• ForwardingHeaders/wtf/MathExtras.h:
• ForwardingHeaders/wtf/Noncopyable.h:
• ForwardingHeaders/wtf/OwnArrayPtr.h:
• ForwardingHeaders/wtf/OwnPtr.h:
• ForwardingHeaders/wtf/PassRefPtr.h:
• ForwardingHeaders/wtf/Platform.h:
• ForwardingHeaders/wtf/RefPtr.h:
• ForwardingHeaders/wtf/Vector.h:

2:40 PM Changeset in webkit [18107] by staikos

• 2 edits in trunk/JavaScriptCore

Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).

Reviewed by Darin.

9:22 AM Changeset in webkit [18106] by rwlbuis

• 12 edits
  2 adds in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11625
Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

Add a class shared by both HTMLStyleElement and SVGStyleElement that
encapsulates the common logic.

9:09 AM SVG TODO List - Short notes edited by zimmermann@kde.org

(diff)

9:07 AM SVG TODO List - Short notes created by zimmermann@kde.org

8:15 AM WikiStart edited by pewtermoose@gmail.com

(diff)

8:09 AM WikiStart edited by pewtermoose@gmail.com

(diff)

5:30 AM WikiStart edited by zimmermann@kde.org

(diff)

12:52 AM Changeset in webkit [18105] by hyatt

• 2 adds
  1 delete in trunk/WebKit/ForwardingHeaders/wtf

Fix WebKit forwarding headers for mac.

12:35 AM Changeset in webkit [18104] by hyatt

• 2 adds
  1 delete in trunk/WebCore/ForwardingHeaders/wtf

Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.

12:34 AM Changeset in webkit [18103] by hyatt

• 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage (more still).

12:33 AM Changeset in webkit [18102] by hyatt

• 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage (maybe).

12:32 AM Changeset in webkit [18101] by hyatt

• 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage (maybe).

12:29 AM Changeset in webkit [18100] by hyatt

• 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage (maybe).

Dec 8, 2006:

11:54 PM Changeset in webkit [18099] by hyatt

• 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage.

9:54 PM Changeset in webkit [18098] by hyatt

• 42 edits
  13 adds
  5 deletes in trunk

JavaScriptCore:

Land the new ICU abstraction layer. Patch by Lars.

Reviewed by me

• JavaScriptCore.xcodeproj/project.pbxproj:
• wtf/Platform.h:
• wtf/unicode/UnicodeCategory.h: Removed.
• wtf/unicode/UnicodeDecomposition.h: Removed.
• wtf/unicode/UnicodeDirection.h: Removed.
• wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::direction): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset):
• wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
• wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset): (WTF::Unicode::direction): (WTF::Unicode::category):

WebCore:

Land the new ICU abstraction layer (WTF::Unicode). Patch
by Lars with a couple of fixes thrown in by me.

Reviewed by hyatt

• ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
• ForwardingHeaders/wtf/unicode/Unicode.h: Added.
• WebCore.xcodeproj/project.pbxproj:
• css/cssparser.cpp: (WebCore::ParseString::lower):
• dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
• editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::append):
• html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
• html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters):
• html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
• page/Frame.h:
• platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
• platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
• platform/FontCache.h:
• platform/FontData.h:
• platform/GlyphMap.cpp:
• platform/GlyphMap.h:
• platform/GlyphWidthMap.h:
• platform/KURL.cpp: (WebCore::encodeHostname):
• platform/StringHash.h: (WTF::):
• platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize): (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
• platform/StringImpl.h:
• platform/TextBoundaries.h:
• platform/TextBreakIterator.h: Added. (WebCore::):
• platform/TextBreakIteratorICU.cpp: Added. (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
• platform/TextCodec.h:
• platform/TextCodecLatin1.cpp:
• platform/TextEncoding.cpp: (WebCore::TextEncoding::encode):
• platform/TextEncoding.h:
• platform/TextEncodingRegistry.cpp: (WebCore::buildTextEncodingNameMap): (WebCore::buildTextCodecMap):
• platform/TextEncodingRegistry.h:
• platform/UChar.h: Removed.
• platform/graphics/GraphicsContext.h:
• platform/qt/GlyphMapQt.cpp:
• platform/qt/TextBreakIteratorQt.cpp: Added. (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
• platform/qt/TextCodecQt.cpp: Added. (WebCore::getAtomicName): (WebCore::TextCodecQt::registerEncodingNames): (WebCore::newTextCodecQt): (WebCore::TextCodecQt::registerCodecs): (WebCore::TextCodecQt::TextCodecQt): (WebCore::TextCodecQt::~TextCodecQt): (WebCore::TextCodecQt::decode): (WebCore::TextCodecQt::encode):
• platform/qt/TextCodecQt.h: Added.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
• rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::widthFromCache):
• rendering/RenderText.h:
• rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
• rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiContext::dir): (WebCore::BidiContext::basicDir): (WebCore::BidiRun::BidiRun):
• rendering/break_lines.h:

WebKit:

Land new ICU abstraction layer. Patch by Lars.

Reviewed by me

• ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
• ForwardingHeaders/wtf/unicode/Unicode.h: Added.
• WebKit.xcodeproj/project.pbxproj:

8:10 PM Changeset in webkit [18097] by aroben

• 6 edits in trunk/WebCore

Rolling out r17865 because it caused a performance regression.

• loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding):
• platform/CString.cpp: (WebCore::CString::data):
• platform/CString.h:
• platform/TextStream.cpp: (WebCore::TextStream::operator<<):
• platform/TextStream.h:

6:44 PM Changeset in webkit [22640] by kmccullo

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

• createWebViewWithRequest now increases the ref count for the new window it returns. This is standard practice for COM, and fixes a crash.

• WebFrame.cpp: (WebFrame::openURL):

5:27 PM Changeset in webkit [18096] by zack

• 34 edits
  4 adds in trunk

Reviewed by Maciej.

Patch fixes compile of all Qt/KDE code after
the recent API changes.

5:25 PM Changeset in webkit [18095] by bdash

• 1 edit in trunk/WebCore/ChangeLog

Remove stray conflict marker

5:13 PM Changeset in webkit [18094] by thatcher

• 9 copies in tags/Safari-521.32

New tag.

5:07 PM Changeset in webkit [18093] by thatcher

• 7 edits in /

Versioning

4:38 PM Changeset in webkit [18092] by thatcher

• 2 edits in trunk/WebKit

Rolling out a change that broke Mail stationary.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

• WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]):

4:31 PM Changeset in webkit [18091] by staikos

• 3 edits in trunk/WebKitTools

Reviewed by Maciej.

Build Qt webkit on non-linux, and prefer it if $QTDIR is set

• Scripts/build-webkit:
• Scripts/webkitdirs.pm:

4:11 PM Changeset in webkit [22639] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

• platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix use of min().

3:40 PM Changeset in webkit [18090] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10188
Form elements added via appendChild() are not accessible via form.element

Make sure looking up form elements works when the form is not appended
to the document.

2:44 PM Changeset in webkit [18089] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=11765
REGRESSION: Clicking on a select with size other than 1 and no children results in a crash

Make sure returned value is -1 for selects without children.

2:37 PM Changeset in webkit [22638] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

2:34 PM Changeset in webkit [18088] by aroben

• 2 edits in trunk

Fixed typo.

2:34 PM Changeset in webkit [18087] by aroben

• 5 edits in trunk

JavaScriptCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

• kjs/config.h:
• wtf/Vector.h:

WebCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

• config.h:

1:21 PM Changeset in webkit [18086] by ap

• 11 edits in trunk

2006-12-08 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11759:
Windows build bustage

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ContextMenuClientWin.h:
• bridge/win/FrameWin.h:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
• platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
• platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel): (WebCore::inputElementAltText): (WebCore::copyCursor): (WebCore::resetButtonDefaultLabel): (WebCore::ContextMenuClientWin::contextMenuItemSelected): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::FrameLoader::load): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::respondToChangedSelection):

WebKit:

• COM/WebFrame.cpp: (WebFrame::loadDataSource):
• COM/WebFrame.h:

1:12 PM Changeset in webkit [18085] by weinig

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

• fast/dom/XMLSerializer-doctype-expected.txt: Added.
• fast/dom/XMLSerializer-doctype.html: Added.
• fast/dom/XMLSerializer-doctype2-expected.txt: Added.
• fast/dom/XMLSerializer-doctype2.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

Test: fast/dom/XMLSerializer-doctype.html
Test: fast/dom/XMLSerializer-doctype2.html

• dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): set the document of the DocumentType node to the new document.
• xml/XMLSerializer.cpp: Cleanup. (WebCore::XMLSerializer::serializeToString): now throws an exception for documentless nodes.
• xml/XMLSerializer.h: cleanup
• xml/XMLSerializer.idl: add exception

11:29 AM Changeset in webkit [18084] by justing

• 4 edits
  8 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

• editing/selection/mixed-editability-6-expected.checksum: Added.
• editing/selection/mixed-editability-6-expected.png: Added.
• editing/selection/mixed-editability-6-expected.txt: Added.
• editing/selection/mixed-editability-6.html: Added.
• editing/selection/mixed-editability-7-expected.checksum: Added.
• editing/selection/mixed-editability-7-expected.png: Added.
• editing/selection/mixed-editability-7-expected.txt: Added.
• editing/selection/mixed-editability-7.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

• editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints to the same *highest* editable root. This bug only happened when creating selections based in an editable region and extending into a higher editable root, so this change doesn't expose any new kinds of deletions, but we should start thinking about how those deletions should behave.
• editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Ditto.

10:53 AM Changeset in webkit [18083] by harrison

• 2 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

• WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Add nil check.

10:46 AM Changeset in webkit [22637] by bdakin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>. Not doing
this breaks sub-menus on Boomer since the menu items are no longer
static.

• platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):

10:42 AM Changeset in webkit [18082] by bdakin

• 1 edit in trunk/WebCore/ChangeLog

Typo! Thanks Mitz!

10:37 AM Changeset in webkit [18081] by bdakin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>

• platform/ContextMenu.cpp: Because of the OwnPtr in ContextMenuItem, we have to separate the declaration of ContextMenuItems away from the calls to appendItem(). Not doing so causes a build failure because OwnPtr inherits from Noncopyable. (WebCore::createFontSubMenu): Same. (WebCore::createSpellingAndGrammarSubMenu): Same. (WebCore::createSpellingSubMenu): Same. (WebCore::createSpeechSubMenu): Same. (WebCore::createWritingDirectionSubMenu): Same. (WebCore::ContextMenu::populate): Same.
• platform/ContextMenuItem.h: New member variable m_subMenu.
• platform/mac/ContextMenuItemMac.mm: Take care of setting m_subMenu in addition to setting the submenu of the NSMenuItem when we have a sub-menu. (WebCore::menuToArray): (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setSubMenu): Same.

10:35 AM Changeset in webkit [18080] by ap

• 2 edits in trunk/WebCore

2006-12-08 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11778
CString::data() should be documented as returning a null terminated char array

• platform/CString.h: Add some basic documentation to CString.h

10:31 AM Changeset in webkit [18079] by ap

• 2 edits
  1 add in trunk/WebCore

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11718
REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
continues to scroll automatically.

Test: manual-tests/autoscroll.html

• manual-tests/autoscroll.html: Added.

• page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Assign to m_mousePressNode earlier, so that it is available in the superframe as well. Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value was only defined if the event was passed down to a widget or a subframe.

(WebCore::EventHandler::stopAutoscrollTimer):
If the mouse down event was in a subframe, stop the subframe's timer.

10:25 AM Changeset in webkit [18078] by ap

• 9 edits in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=6275
XMLHttpRequest.getResponseHeader should return a null string for non-existent headers

WebCore:

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Convert null getResponseHeader strings to JS null, rather than undefined.

LayoutTests:

• http/tests/xmlhttprequest/methods-async-expected.txt:
• http/tests/xmlhttprequest/methods-expected.txt:
• http/tests/xmlhttprequest/methods-lower-case-expected.txt: Updated the results.

• http/tests/xmlhttprequest/web-apps/008-expected.txt:
• http/tests/xmlhttprequest/web-apps/008-test.asis:
• http/tests/xmlhttprequest/web-apps/008.html: Changed to test both missing and empty headers, also test case insensitivity of header names. Please note that neither Firefox nor IE passes this test now - the former returns null in both cases, and the latter returns empty strings.

10:19 AM Changeset in webkit [18077] by ap

• 5 edits
  7 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=9854
HTTP Refresh header with quotes is parsed incorrectly

Test: http/tests/misc/redirect-with-quotes.php

• WebCore.xcodeproj/project.pbxproj: Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.

• dom/Document.cpp: (WebCore::Document::processHttpEquiv):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Use the new implementation in HTTPHeaders.

• platform/network/HTTPParsers.cpp: Added. (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
• platform/network/HTTPParsers.h: Added. Merged and rewrote existing implementations for better Firefox compatibility.

10:03 AM Changeset in webkit [18076] by ap

• 3 edits
  2 adds in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11772
REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes

Test: fast/dom/serialize-cdata.html

• editing/markup.cpp: (WebCore::startMarkup): Dump CDATA sections, too.

3:02 AM Changeset in webkit [18075] by rwlbuis

• 2 edits in trunk/WebCore

Reviewed by hyatt.

Deleted misplaced comment.

12:02 AM Changeset in webkit [18074] by rwlbuis

• 11 edits
  4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=6074
WebKit+SVG and FireFox disagree on invalid "transform" handling

Test for parsing failure on transform attribute and clear the transform
list upon failure to match FF behaviour.

Dec 7, 2006:

11:05 PM Changeset in webkit [18073] by ggaren

• 3 edits
  6 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Tests for the change and blur events in input elements.

• fast/events/onchange-passwordfield-expected.txt: Added.
• fast/events/onchange-passwordfield.html: Added.
• fast/events/onchange-searchfield-expected.txt: Added.
• fast/events/onchange-searchfield.html: Added.
• fast/events/onchange-textfield-expected.txt: Added.
• fast/events/onchange-textfield.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
dispatches onchange event in response to enter key

To match our old behavior and FF, we need to dispatch onchange in response to the
ENTER key. The strategy here is just to dispatch a blur event, since that's how
the search field always worked, and the DOM spec says onchange only fires
as a precursor to blur.

• ChangeLog:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

7:53 PM Changeset in webkit [18072] by aroben

• 3 edits in trunk/WebCore

Reviewed by Oliver.

Some small context menu-related fixes.

• html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to resize on a contextmenuEvent.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event off to HTMLGenericFormElement if we haven't handled it.

7:22 PM Changeset in webkit [18071] by bdash

• 5 edits in trunk/JavaScriptCore

2006-12-07 Kevin Fyure <​digdog@macports.org>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11545
Disable the testcases do not follow the ECMA-262v3 specification.

• tests/mozilla/expected.html: Update Results.
• tests/mozilla/js1_2/String/concat.js: 4 tests disabled. The result of concat Array object is not followinig ECMA 15.5.4.6
• tests/mozilla/js1_2/function/Number.js: 1 test disabled. The result of Array object to Number object conversion is not following ECMA 9.3. And the test was duplicated in ecma/TypeConversion/9.3-1.js
• tests/mozilla/js1_2/function/String.js: 2 tests disabled. The result of Object/Array object to String object conversion is not following ECMA 15.5.1.1 and ECMA 9.8

5:51 PM Changeset in webkit [18070] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-12-03 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: synthesize missing html node when comments start doc
​http://bugs.webkit.org/show_bug.cgi?id=11747

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

4:54 PM Changeset in webkit [18069] by andersca

• 7 edits
  3 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4838778>
DashboardClient crashing in WebCore::SubresourceLoader::didFail.

• http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
• http/tests/xmlhttprequest/abort-crash.html: Added.
• http/tests/xmlhttprequest/hello-world.cgi: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4838778>
Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::stopLoading):
• loader/SubresourceLoader.h: Add stopLoading method which currently just clears the client. This isn't the ideal fix, since it doesn't actually stop the load.

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): Add null-checks.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call stopLoading.

4:28 PM Changeset in webkit [22636] by kmccullo

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by.

Fixed previous comment

• ChangeLog:

4:26 PM Changeset in webkit [22635] by kmccullo

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

• keyDown events must be followed by keyPressed events and before keyUp events.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):

4:23 PM Changeset in webkit [18068] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by Geof.

• added the ability to set the auto repeating variable to force a keyPressed event from a keyDown event.

• platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):

4:14 PM Changeset in webkit [18067] by bdash

• 1 edit
  5 adds in trunk/LayoutTests

2006-12-07 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=11771
Bug 11771: Add a test for resetting a textarea form control

• fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
• fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
• fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
• fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.

4:10 PM Changeset in webkit [18066] by bdash

• 2 edits in trunk/WebCore

2006-12-07 Don Gibson <​dgibson77@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11749
Don't call updateThumbProportion() unnecessarily.

• platform/ScrollBar.cpp: (WebCore::Scrollbar::setProportion):

3:50 PM Changeset in webkit [22634] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:44 PM Changeset in webkit [18065] by sfalken

• 1 copy in tags/Safari-521.31.7b

New tag.

3:37 PM Changeset in webkit [18064] by bdash

• 1 edit in tags/WebCore-521.31.2/WebCore/Info.plist

Versioning.

3:35 PM Changeset in webkit [18063] by bdash

• 2 edits
  1 copy in tags/WebCore-521.31.2/WebCore

Merge fix from r18048

3:22 PM Changeset in webkit [18062] by bdash

• 1 copy in tags/WebCore-521.31.2

New tag

3:21 PM Changeset in webkit [18061] by brmorris

• 981 edits in S60/trunk/LayoutTests

2006-12-07 Bradley Morrison <​bradley.morrison@nokia.com>

Reviewed by Babu.

Updated expected layout test results to include color attribute.

2:10 PM Changeset in webkit [22633] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Two small fixes for bugs discovered while implementing the Snippet
Editor.

• WebView.cpp: (registerWebViewWindowClass): Set the WebView's default cursor to be IDC_ARROW. (WebView::uiDelegate): Return E_FAIL if there's no UI delegate.

1:57 PM Changeset in webkit [22632] by sfalken

• 5 edits in branches/WindowsMerge/WebKitWin

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

Add LPCTSTR_UI_STRING and LPCTSTR_UI_STRING_KEY.
Added caching to prevent re-converting strings unnecessarily.

• WebKit.vcproj/WebKit.def: Export LPCTSTR localization function
• WebKit.vcproj/WebKit_debug.def: Export LPCTSTR localization function
• WebLocalizableStrings.cpp: (createWebKitBundle): Added using namespace so we don't need to qualify String (WebLocalizedLPCTSTR): Added
• WebLocalizableStrings.h: Added LPCTSTR localization support

1:49 PM Changeset in webkit [18060] by sfalken

• 2 edits in trunk/WebKitTools

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Support C strings for localization

• Scripts/extract-localizable-strings:

12:47 PM Changeset in webkit [18059] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Brady.

Build fix for WebCore ContextMenus. It got broken by r18046.

• WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):

11:57 AM Changeset in webkit [22631] by bdakin

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady.

New link stub for load() function used by
ContextMenuItemTagOpenLink action.

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):

WebKitWin:

Reviewed by Brady.

Make some parameters const and const references.

• WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
• WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/TemporaryLinkStubs.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

11:49 AM Changeset in webkit [18058] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2006-12-05 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Toolbar tooltip not OK for RTL tooltip like Hebrew
​http://bugs.webkit.org/show_bug.cgi?id=11761

• BrowserView/src/WebKitView.cpp: (CWebKitView::DrawToolTip):

11:49 AM Changeset in webkit [18057] by bdakin

• 7 edits in trunk

WebCore:

Reviewed by Brady.

Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
doing anything before, and now it works! Also some formatting
changes, etc.

• page/ContextMenuClient.h: Several of the parameters to several of the functions here should be const or const references. And now they are!
• page/ContextMenuController.cpp: (WebCore::openNewWindow): Moved the open new window functionality into a helper function since it is used by several menu item tags. Now after calling chrome()->createWindow() we call chrome()->show() on the new window, and so it appears! (WebCore::ContextMenuController::contextMenuItemSelected): Call new openNewWindow function to do the right thing. Shift some formatting, use local variable for HitTestResult. Implement action for ContextMenuItemTagOpenLink.

WebKit:

Reviewed by Brady.

Make some parameters const and const references.

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):

11:41 AM Changeset in webkit [18056] by yongjzha

• 2 edits in S60/trunk/WebCore

2006-12-07 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
​http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):

11:39 AM Changeset in webkit [22630] by adachan

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-07 Ada Chan <​adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4866288> Crash on boomer quit

• don't close the themes on termination, since uxtheme should do that anyway.

1:49 AM Changeset in webkit [18055] by ddkilzer

• 1 edit in trunk/WebCore/ChangeLog

Fixed typos/misspellings.

Dec 6, 2006:

6:47 PM Changeset in webkit [18054] by kmccullo

• 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

• Removed a confilct marker

• ChangeLog:

6:47 PM Changeset in webkit [22629] by adachan

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-06 Ada Chan <​adachan@apple.com>

Reviewed by Maciej.

Fixed a couple of things while investigating <rdar://4866288> (note this doesn't fix the crash yet):

• we forgot to initialize m_sliderTheme
• we did the wrong null check when getting the slider theme.

6:46 PM Changeset in webkit [18053] by justing

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

• editing/selection/select-line-expected.txt: Added.
• editing/selection/select-line.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

• WebCore.vcproj/WebCore/WebCore.vcproj: Removed RebalanceWhitespaceCommand.*.
• editing/visible_units.cpp: (WebCore::startOfLine): There are VisiblePositions at offset 0 in blocks without RootInlineBoxes, like empty editable blocks and bordered blocks. (WebCore::endOfLine): Ditto.

6:40 PM Changeset in webkit [18052] by kmccullo

• 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

• Removed a confilct marker

• ChangeLog:

6:24 PM Changeset in webkit [18051] by kmccullo

• 1 edit in trunk/WebCore/ChangeLog

Reviewed by john

<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

• editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
• editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.

5:01 PM Changeset in webkit [18050] by justing

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

• editing/deleting/delete-mixed-editable-content-001-expected.txt:
• editing/inserting/editable-inline-element-expected.checksum: Added.
• editing/inserting/editable-inline-element-expected.txt: Added.
• editing/inserting/editable-inline-element-expected.png: Added.
• editing/inserting/editable-inline-element.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

• editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
• editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.

4:41 PM Changeset in webkit [18049] by beidson

• 4 edits in trunk/WebKit

Reviewed by John Sullivan

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
Now we need to explicitly set the data source when loading from a page cache

• History/WebHistoryItem.mm: (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message (+[WebHistoryItem _releasePageCache:]): Ditto (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
• WebView/WebHTMLView.m: (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view

4:22 PM Changeset in webkit [18048] by thatcher

• 2 edits
  1 add in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4843505> Fix cross-library ivar use for 64-bit Objective-C

Adds a new WebCore.LP64.exp file that gets appended to the normal export file.
This new file will have 64-bit only symbols we need to export.

• WebCore.LP64.exp: Added.
• WebCore.xcodeproj/project.pbxproj:

4:15 PM Changeset in webkit [22628] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Fix the build.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFail): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):

WebKitWin:

Fix the build.

• WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::didFail):
• WebFrame.h:

4:08 PM Changeset in webkit [18047] by andersca

• 18 edits in trunk/WebCore

Reviewed by Maciej.

Change SubresourceLoader to use a ResourceHandle, and change ResourceHandle to use a NSURLConnection.

• loader/ResourceLoader.h:
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail):
• loader/SubresourceLoader.h: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): (WebCore::SubresourceLoader::didCancelAuthenticationChallenge): (WebCore::SubresourceLoader::willStopBufferingData): (WebCore::SubresourceLoader::willCacheResponse): (WebCore::SubresourceLoader::receivedCredential): (WebCore::SubresourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::SubresourceLoader::receivedCancellation):
• loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::didFail):
• loader/loader.h:
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::setDefersLoading): (WebCore::SubresourceLoader::resourceData): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFail): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::willStopBufferingData): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation):
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::delegate): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData): (-[WebCoreResourceHandleAsDelegate initWithHandle:]): (-[WebCoreResourceHandleAsDelegate detachHandle]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFail):
• xml/xmlhttprequest.h:

2:41 PM Changeset in webkit [22627] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Modify PluginStreamWin to use a SubresourceLoader instead of a ResourceHandle.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
• plugins/win/PluginStreamWin.h:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):

2:33 PM Changeset in webkit [22626] by andersca

• 3 edits in branches/WindowsMerge/WebCore

Build fixes.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::scheduleClose):

1:55 PM Changeset in webkit [18046] by beidson

• 2 edits in trunk/WebKit

Reviewed by Adam and Oliver

While working on ​http://bugs.webkit.org/show_bug.cgi?id=11675 I
decided to fix much of the null-deref problems that creeped in via
the loader refactoring. This isn't changing behavior, just reintroducing
the free nil checking we used to have with pure ObjC

• WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Explicitly check for null frames (-[NSArray mouseDown:]): Ditto (-[NSArray mouseDragged:]): Ditto (-[NSArray mouseUp:]): Ditto (-[NSArray performKeyEquivalent:]): Ditto (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto

1:54 PM Changeset in webkit [18045] by bdakin

• 5 edits in trunk/WebCore

Reviewed by Adam.

There are two bugs with WebCore ContextMenus due to the static
ContextMenuItems. One bug is that we often crashed in
NSAutoreleasePool upon quitting the browser. The other bug is that
we were adding static NSMenuItems to multiple NSMenus, which is
disallowed. To fix these bugs, the MenuItems are no longer static.
This is in line with the current design in WebKit anyway. I made
some re-arrangements in the code because I also removed the macro
that was used to create the menu items since it was a bit
confusing.

• platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate):
• platform/ContextMenuItem.h:
• platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): Use the NSMenuItem global separator item if we have SeparatorType.
• platform/mac/ContextMenuMac.mm: (WebCore::setMenuItemTarget): Change name of getNSMenuItem since that is no longer accurate. (WebCore::ContextMenu::appendItem): Above name change. (WebCore::ContextMenu::insertItem): Same.

1:46 PM Changeset in webkit [18044] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by Geof.

• Returned the semantic meaning of the mask to be the actual repeat count, and changed auto_repeat to correctly differnetiate between keypressed and keydown.

• platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

1:01 PM Changeset in webkit [18043] by justing

• 10 edits
  4 adds
  2 deletes in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

• editing/inserting/edited-whitespace-1-expected.checksum: Added.
• editing/inserting/edited-whitespace-1-expected.png: Added.
• editing/inserting/edited-whitespace-1-expected.txt: Added.
• editing/inserting/edited-whitespace-1.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

• WebCore.xcodeproj/project.pbxproj: Removed RebalanceWhitespaceCommand.* from the project.
• editing/CompositeEditCommand.cpp: (WebCore::isWhitespace): Moved from htmlediting. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Moved the work that was once done in its own command here. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Prevents whitespace around a position from collapsing when it's pushed apart during Paste. This function can eventually be deployed to eliminate the need for leading/trailing whitespace handling in InsertParagraphSeparator, InsertLineBreak, Delete, and BreakBlockquote. (WebCore::CompositeEditCommand::rebalanceWhitespace): Cleaned up.
• editing/CompositeEditCommand.h:
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Do rebalanceWhitespaceAt *before* saving the typing style, because whitespace rebalancing is no longer it's own command that claims to preserve the typing style.
• editing/RebalanceWhitespaceCommand.cpp: Removed.
• editing/RebalanceWhitespaceCommand.h: Removed.
• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moved the code to prepare whitespace arond a position for being pushed aparat to its own method.
• editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Added. Returns a rebalanced string. Takes in whether or not the beginning of that string will be at the start of a paragraph, because a space at such a position must have be nbsp, even if that doesn't follow the nbsp/space pattern used. Similar stuff for the end of a paragraph.
• editing/htmlediting.h:
• editing/markup.cpp: (WebCore::fillContainerFromString): Call stringWithRelabacedWhitespace. Pass it the startOfParagraph/endOfParagraph bools.

12:39 PM Changeset in webkit [18042] by rwlbuis

• 6 edits in trunk/WebKitSite

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=10254
A few grammar and spelling corrections on the WebKit website

Grammar and spelling corrections by Jonathan Johnsson.

12:01 PM Changeset in webkit [22625] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

10:57 AM Changeset in webkit [22624] by sullivan

• 3 edits in branches/WindowsMerge/WebCore

Try to keep the windows build happy with Frame -> Editor changes...

• bridge/win/FrameWin.h: removed declarations of spelling and grammar functions

• platform/win/TemporaryLinkStubs.cpp:

changed spelling and grammar functions from FrameWin

to Editor:: (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::Editor::advanceToNextMisspelling):

10:50 AM Changeset in webkit [18041] by sullivan

• 14 edits in trunk

WebCore:

Reviewed by Beth

Moved spelling and grammar code from Frame to Editor

• WebCore.exp: updated for these changes

• page/Frame.h: removed declarations of spelling and grammar functions

• bridge/mac/FrameMac.h: removed declarations of spelling and grammar functions

• bridge/mac/FrameMac.mm: moved implementation of spelling and grammar functions from here (WebCore::FrameMac::respondToChangedSelection): updated for moved functions

• editing/Editor.h: moved declarations of spelling and grammar functions to here

• editing/mac/EditorMac.mm: moved implementation of spelling and grammar functions to here; changed only to make it compile (e.g. removing "editor()->" and adding "frame()->" where appropraite. (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::core): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::Editor::markMisspellings):

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): updated for moved functions

• editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for moved functions

WebKit:

Reviewed by Beth

Updated to match Frame -> Editor changes in WebCore

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): guessesForUngrammaticalSelection() is now in Editor

• WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): isSelectionUngrammatical() is now in Editor (-[WebHTMLView _isSelectionMisspelled]): isSelectionMisspelled() is now in Editor

(-[WebHTMLView checkSpelling:]):
advanceToNextMisspelling() is now in Editor
(-[WebHTMLView showGuessPanel:]):
ditto