⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 8, 2007:

11:59 PM Changeset in webkit [23047] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Oliver Hunt <​oliver@apple.com>

WebCoreWin:

Allow webloc files to be dropped onto the webview


<rdar://problem/4883564> Regression: cannot open webloc file by dnd to Boomer's window

  • platform/win/DragDataWin.cpp: (WebCore::cfHDropFormat):

Clipboard format for HDROP, non-static as i will need it elsewhere in the future

(WebCore::getWebLocData):

Extract a url from a webloc file

(WebCore::getURL):

Call getWebLocData


11:20 PM Changeset in webkit [23046] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

Fix B&I build more

  • WebCore.vcproj/WebCore.vcproj:
10:23 PM Changeset in webkit [20086] by bdash
  • 4 edits in tags/Safari-4522.4

Versioning.

10:18 PM Changeset in webkit [20085] by bdash
  • 1 copy in tags/Safari-4522.4

New tag.

10:05 PM Changeset in webkit [20084] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Beth.

No tests added since LayoutTests/fast/forms/document-write.html was timing out
and causing a layout test failure.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Removed stray code.
9:52 PM Changeset in webkit [23045] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
8:55 PM Changeset in webkit [20083] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex): add empty stub
8:23 PM Changeset in webkit [20082] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5051616> Mouse clicks and movement are ignored in HIWebView on 64-bit

Mouse events are not being handled correctly as GetControlKind is returning an error
on 64-bit. The more modern HIObjectIsOfClass behaves correctly for this use.

  • Carbon/HIWebView.m: (HIWebViewDestructor): (WindowHandler): Use HIObjectIsOfClass in place of GetControlKind. (HIWebViewEventHandler): Don't leak the NSEvent.
8:06 PM Changeset in webkit [20081] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-09 Mark Rowe <​mrowe@apple.com>

Unreviewed. Use the new SVN URL on the buildbot.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
7:57 PM Changeset in webkit [20080] by bdash
  • 1 edit
    1 add in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Tim Hatcher.

Sexy blog permalinks!

  • blog/.htaccess: Added.
7:11 PM Changeset in webkit [20079] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-08 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13018
Bug 13018: allow embedders to override the definition of CRASH.

  • wtf/Assertions.h: make it possible to override CRASH.
7:08 PM Changeset in webkit [20078] by bdash
  • 3 edits
    2 adds in trunk

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

Test: fast/loader/onunload-form-submit-crash-2.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): Added null check.

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash-2.html: Added.
7:02 PM Changeset in webkit [20077] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Bruce Q Hammond <​bruceq@apple.om>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13009
Console spews "CGContextGetType: invalid context" non-stop on web site

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
6:37 PM Changeset in webkit [20076] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

  • building/checkout.html: Update repository URL.
6:37 PM Changeset in webkit [20075] by justing
  • 31 edits in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang

Less messy DOM trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • fast/lists/drag-into-marker-expected.txt: Styles from style sheets are now inlined:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:\ Two levels of nesting are removed, but text nodes are no longer coalesced when they should be, investigating:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang


~2x speedup copying:
​http://shakespeare.mit.edu/henryviii/full.html
Also produces less bloated markup.

  • editing/markup.cpp: (WebCore::startMarkup): Don't wrap text nodes in style spans. For Elements, don't inline styles inherited from ancestors. (WebCore::createMarkup): No longer necessary to find the root's default style and pass it to startMarkup. Add a wrapper span around the markup with the styles that all nodes in the markup inherit (the inheritable styles from the common ancestor container's computed style). Added a FIXME about unecessary markup for inline ancestors up to the commonAncestorBlock.
6:25 PM Changeset in webkit [20074] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • <rdar://problem/4470381> multipart/form-data boundary security vulnerability

By making the form data boundary a string with some random data in it, we reduce
the possibility that anyone could take advantage of it by creating a file that
intentionally has the boundary string in it.

  • html/HTMLFormElement.h: Removed boundary(), setBoundary(), and m_boundary. Marked a lot more stuff private.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Removed code to initialize m_boundary. (WebCore::randomNumber): Added. Function that returns a random number, including seeding the random number generator the first time it's called. For now, usees the more random function random() on Mac OS X and the more-standard rand() on other platforms. (WebCore::HTMLFormElement::formData): Take a parameter with the form boundary string, and use that instead of m_boundary. (WebCore::getUniqueBoundaryString): Added. Makes a boundary string using random numbers and base 64 encoding. (WebCore::HTMLFormElement::submit): Call getUniqueBoundaryString and pass the boundary string into formData for multipart form posts.
6:15 PM Changeset in webkit [20073] by bdash
  • 7 edits
    1 delete in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4561772> HIWebView does not exist for 64-bit

Update HIWebView and friends to work without QuickDraw.

Changes are gleaned from the 64-bit support inside HICocoaView. The main
fact of interest are that all Carbon windows must have compositing enabled
so the code paths that aren't accessible are #ifdef'd out. Conveniently
these are the exact code paths that make use of QuickDraw.

There are currently minor event-handling and invalidation issues running as
64-bit that are not present in 32-bit.

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (Click): (SyncFrame): (StartUpdateObserver): (StopUpdateObserver): (UpdateObserver):
  • WebKit.LP64.exp: Removed.
  • WebKit.xcodeproj/project.pbxproj: Always use WebKit.exp.
6:12 PM Changeset in webkit [20072] by mjs
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents, these test cases cover every focus call I could find.


  • fast/forms/focus-selection-input-expected.txt: Added.
  • fast/forms/focus-selection-input.html: Added.
  • fast/forms/focus-selection-textarea-expected.txt: Added.
  • fast/forms/focus-selection-textarea.html: Added.
  • fast/forms/onselect-textfield-expected.txt:

WebCore:

Reviewed by Adele.


<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents.


Tests:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html


  • dom/Element.cpp: (WebCore::Element::focus):
  • dom/Element.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::accessKeyAction):
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::focus): (WebCore::HTMLLabelElement::accessKeyAction):
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::focus):
  • html/HTMLLegendElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus):
  • html/HTMLTextAreaElement.h:
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
4:33 PM Changeset in webkit [20071] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • editing/execCommand/12244-expected.txt: Added.
  • editing/execCommand/12244.html: Added.
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • bindings/js/kjs_window.cpp: (KJS::Window::find): Added. This function doesn't yet support whole word searches, searching in subframes, or opening the find dialog. (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
3:58 PM Changeset in webkit [20070] by hyatt
  • 4 edits in trunk/WebCore

Fix regression from throwing away frames of large animated images. Alter
animated images so that they refuse to advance the animation until the
current displayed frame has been fully decoded.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
3:45 PM Changeset in webkit [23044] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Steve.


Fix <rdar://problem/4969070> Failed error pages show "unknown error"
rather than specific error

Make ResourceError aware of kCFErrorDomainCFNetwork.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Added case for kCFErrorDomainCFNetwork.
3:33 PM Changeset in webkit [20069] by hyatt
  • 2 edits in trunk/WebCore

Fix 2% performance regression on the PLT. Increase the large animated
image cutoff from 1MB to 5MB.

In addition when pruning we will aggressively discard image sources.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
2:42 PM Changeset in webkit [20068] by justing
  • 1 edit in trunk/LayoutTests/fast/dom/Range/13000-expected.txt
2:16 PM Changeset in webkit [20067] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Pass the RenderObject's node to customHighlightLineRect and paintCustomHighlight.

  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight):
  • page/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Added new methods to the WebHTMLHighlighter protocol that include the DOMNode being painted.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge customHighlightRect:forLine:representedNode:WebCore::]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:representedNode:WebCore::]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
2:00 PM Changeset in webkit [20066] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • fast/dom/Range/13000-expected.txt: Added.
  • fast/dom/Range/13000.html: Added.

WebCore:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • dom/Range.cpp: (WebCore::Range::createContextualFragment): The "startContainer" may not be a container, if the range starts inside text. In that case, look to the parent of the start node for an HTMLElement.
12:49 PM Changeset in webkit [20065] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar::/problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/execCommand/5049671-expected.checksum: Added.
  • editing/execCommand/5049671-expected.png: Added.
  • editing/execCommand/5049671-expected.txt: Added.
  • editing/execCommand/5049671.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Clear removed anchors after the deletion.
10:33 AM Changeset in webkit [20064] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Attempt to fix the build.

9:47 AM Changeset in webkit [20063] by brmorris
  • 3 edits in S60/trunk/S60Internals

brmorris, reviewed by nobody (bustage fix)

DESC: add some icons to fix build bustage caused by r20034

7:03 AM Changeset in webkit [20062] by ddkilzer
  • 1 edit
    1 add in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

Added missing file for r20059:
<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

File was taken from this svn repository which contained versions of ucnv.h and ucnv_err.h
that were identical to ours:
​http://source.icu-project.org/repos/icu/icu/tags/release-3-2/source/common/unicode/ucnv_cb.h

  • icu/unicode/ucnv_cb.h: Added.
5:57 AM Changeset in webkit [20061] by bdash
  • 2 edits in trunk/WebCore

2007-03-09 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
4:09 AM Changeset in webkit [20060] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

Fix compiler warnings when building Drosera as 64-bit.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument breakpointEditorHTML]): Move away from deprecated NSString method. (-[DebuggerDocument scriptConfirmSheetDidEnd:returnCode:contextInfo:]): Update type. (-[DebuggerDocument webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Update type to accommodate constant.
3:08 AM Changeset in webkit [20059] by oliver
  • 6 edits in trunk

2007-03-08 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

To match old TEC behaviour when using ICU we need to use
a few manual fallback encodings for the GBK/EUC-CN charsets

<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::gbkEscapes): (WebCore::gbkCallbackEscape): (WebCore::gbkCallbackSubstitute): (WebCore::TextCodecICU::encode):
  • platform/TextCodecICU.h: (WebCore::TextCodecICU::needsGBKFallbacks): (WebCore::TextCodecICU::setNeedsGBKFallbacks):


LayoutTests:

Adding GBK character encoding tests

  • fast/encoding/char-encoding-expected.txt:
  • fast/encoding/char-encoding.html:


2:00 AM Changeset in webkit [23043] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.


  • WebView.cpp: (WebView::isLoading):
1:21 AM Changeset in webkit [23042] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Implement WebView::isLoading.


  • WebView.cpp: (WebView::isLoading):
1:12 AM Changeset in webkit [20058] by andersca
  • 2 edits in trunk/WebKit

Try fixing the buildbot build.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
12:48 AM Changeset in webkit [20057] by ap
  • 5 edits in trunk

WebCore:

Build fix.

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue):

LayoutTests:

Added a test for attribute node string-value.

  • fast/xpath/string-value-expected.txt:
  • fast/xpath/string-value.html:
12:43 AM Changeset in webkit [20056] by hyatt
  • 4 edits in trunk/WebCore

This patch dramatically reduces the memory consumed by animated images. For large animated GIFs (defined for
now as >1mb in terms of decoded frame buffer size), we will now aggressively flush previous frames of the
animated GIF and just re-decode them on the fly if the animation loops.

Whenever a large animated GIF has its animation reset, we will also just throw out everything and start
the animation over (in order to get rid of any cached detritus held in the ImageSource).

With this patch and the sample GIF used to test, WebKit's memory consumption went from 160MB down to 16MB.

Reviewed by mjs

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
12:16 AM Changeset in webkit [20055] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13006
XPath string-value is broken for some node types

Test: fast/xpath/string-value.html

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Fix it :-)
12:02 AM Changeset in webkit [20054] by ddkilzer
  • 1 edit in trunk/WebKit/ChangeLog

Added bug number and fixed email address.

Mar 7, 2007:

11:15 PM Changeset in webkit [20053] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4981000>
​http://bugs.webkit.org/show_bug.cgi?id=12634
REGRESSION: crash loading web archive (12634)


The reason this bug wasn't always reproducible is that it involved sending an event to a plugin while
the page was loading. Before we send the event to the plugin we defer loads. The problem was that
MainResourceLoader::setDefersLoad would not work with data loads.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): Only set m_committed to false if we also have a valid unreachable URL.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::setDefersLoading): Make sure to stop and start data loads.
11:01 PM Changeset in webkit [20052] by kjk
  • 4 edits in trunk/WebCore

Not reviewed.

Gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::handleKeypress): renamed (WebCore::EditorClientGdk::handleInputMethodKeypress): add a stub
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::destroyFrameAtIndex): add a stub
10:52 PM Changeset in webkit [23041] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Return E_POINTER for null parameters.

  • WebScrollBar.cpp: (WebScrollBar::value): (WebScrollBar::capturingMouse): (WebScrollBar::frameGeometry): (WebScrollBar::width): (WebScrollBar::height): (WebScrollBar::requestedWidth): (WebScrollBar::requestedHeight): (WebScrollBar::windowClipRect):
10:47 PM Changeset in webkit [23040] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

Added requestedWidth and requestedHeight methods to WebScrollBar.

  • Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
  • WebScrollBar.cpp: (WebScrollBar::requestedWidth): Implemented. (WebScrollBar::requestedHeight): Implemented.
  • WebScrollBar.h: Added method declarations.
9:36 PM Changeset in webkit [23039] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

  • WebFrame.cpp: (WebFrame::cancelledError): Use the WebURLErrorDomain constant. (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
7:47 PM Changeset in webkit [20051] by weinig
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13004
Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks

  • fast/xpath/evaluate-twice-expected.txt: Added.
  • fast/xpath/evaluate-twice.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13004
Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks

Removed XPath::Expression::optimize() and related methods, since they were buggy and almost useless.
Merged doEvaluate() into evaluate(), since this was all evaluate() was doing after the above changes.

Test: fast/xpath/evaluate-twice.html

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::Expression): (WebCore::XPath::Expression::~Expression):
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLast::evaluate): (WebCore::XPath::FunPosition::evaluate): (WebCore::XPath::FunId::evaluate): (WebCore::XPath::FunLocalName::evaluate): (WebCore::XPath::FunNamespaceURI::evaluate): (WebCore::XPath::FunName::evaluate): (WebCore::XPath::FunCount::evaluate): (WebCore::XPath::FunString::evaluate): (WebCore::XPath::FunConcat::evaluate): (WebCore::XPath::FunStartsWith::evaluate): (WebCore::XPath::FunContains::evaluate): (WebCore::XPath::FunSubstringBefore::evaluate): (WebCore::XPath::FunSubstringAfter::evaluate): (WebCore::XPath::FunSubstring::evaluate): (WebCore::XPath::FunStringLength::evaluate): (WebCore::XPath::FunNormalizeSpace::evaluate): (WebCore::XPath::FunTranslate::evaluate): (WebCore::XPath::FunBoolean::evaluate): (WebCore::XPath::FunNot::evaluate): (WebCore::XPath::FunTrue::evaluate): (WebCore::XPath::FunLang::evaluate): (WebCore::XPath::FunFalse::evaluate): (WebCore::XPath::FunNumber::evaluate): (WebCore::XPath::FunSum::evaluate): (WebCore::XPath::FunFloor::evaluate): (WebCore::XPath::FunCeiling::evaluate): (WebCore::XPath::FunRound::evaluate):
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): (WebCore::XPath::LocationPath::evaluate): (WebCore::XPath::Path::evaluate):
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp: (WebCore::XPath::Number::evaluate): (WebCore::XPath::StringExpression::evaluate): (WebCore::XPath::Negative::evaluate): (WebCore::XPath::NumericOp::evaluate): (WebCore::XPath::EqTestOp::evaluate): (WebCore::XPath::LogicalOp::evaluate): (WebCore::XPath::Union::evaluate):
  • xml/XPathPredicate.h:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::evaluate):
  • xml/XPathVariableReference.h:
7:31 PM Changeset in webkit [20050] by bdash
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

The change to go along with Anders' ChangeLog entry.

7:18 PM Changeset in webkit [20049] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Leopard build fix.


  • Plugins/WebBaseNetscapePluginView.mm:
7:15 PM Changeset in webkit [20048] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Remove unused #import from Objective-C bindings and cleanup the order of #imports.

  • bindings/scripts/CodeGeneratorObjC.pm:
6:43 PM Changeset in webkit [20047] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Make sure the baseURI attribute generates for private Objective-C bindings.

  • dom/Node.idl:
6:35 PM Changeset in webkit [23038] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
that we will send the right errors once <rdar://problem/5034136> is
fixed.

  • Interfaces/IWebError.idl: Changed definition.
6:18 PM Changeset in webkit [20046] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4874059>

REGRESSION: Painter IX:register - Crash in WebCore
ResourceLoader::willSendRequest()

If a load is done from inside of an error delegate method that is called because we cancel another load,
the first load should be ignored since this is what shipping WebKit does.


(Actually, it does load the page in the data source but doesn't do anything with it since the data source
won't have a web frame).


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Just bail out if m_isStoppingLoad is true.
6:09 PM Changeset in webkit [20045] by hyatt
  • 3 edits in trunk/WebCore

Use CGImageRelease instead of CFRelease.

Reviewed by aroben

  • platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::destroyFrameAtIndex):
6:00 PM Changeset in webkit [20044] by hyatt
  • 6 edits in trunk/WebCore

Fix a regression where the cache size overflows because of a double
subtraction per resource when they got removed from the cache. Add an
assert to adjustSize to detect this case in the future.

Fix ImageSourceCG so that when we flush decoded data from our cache that
we also flush it from the ImageSource.

Reviewed by mjs

  • loader/Cache.cpp: (WebCore::Cache::adjustSize):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::~BitmapImage): (WebCore::BitmapImage::destroyDecodedData):
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): (WebCore::ImageSource::destroyFrameAtIndex):
5:42 PM Changeset in webkit [20043] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-07 Anrong Hu <​huanr@yahoo.com>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12535
Bug 12535: Stack-optimizing compilers can trick GC into freeing in-use objects

  • kjs/internal.cpp: (KJS::StringImp::toObject): Copy val onto the stack so it is not subject to garbage collection.
5:34 PM Changeset in webkit [20042] by bdash
  • 2 edits in trunk/WebKit

2007-03-07 Bruce Q Hammond <​bruceq@apple.om>

Reviewed by Darin.

This fixes a problem with Netscape-style Plug-ins which draw through the Quickdraw APIs
being unable to render into offscreen bitmap contexts.

This patches both saveAndSetNewPortStateForUpdate: and restorePortState:
These methods now check the current context and see if appropriate setup/cleanup needs to be done
for offscreen rendering.

  • Plugins/WebBaseNetscapePluginView.mm: (QDPixelFormatFromCGBitmapInfo): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
5:29 PM Changeset in webkit [20041] by bdash
  • 3 edits
    4 adds in trunk

2007-03-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/repaint/outline-inset.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

2007-03-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/repaint/outline-inset-expected.checksum: Added.
  • fast/repaint/outline-inset-expected.png: Added.
  • fast/repaint/outline-inset-expected.txt: Added.
  • fast/repaint/outline-inset.html: Added.
5:16 PM Changeset in webkit [20040] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Use HardRetain/HardRelease.


  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame): (WebDocumentLoaderMac::increaseLoadCount): (WebDocumentLoaderMac::decreaseLoadCount):
5:16 PM Changeset in webkit [23037] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
5:09 PM Changeset in webkit [20039] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4961259>
REGRESSION: Bumper Car 2.1.1 - Crash at WebCore::FrameLoader::receivedMainResourceError when encountering a invalid URL address


(The crash was already fixed, this actually makes Bumper Car load the error page correctly.)


This adds a "load counter" to the document loader and keeps the data source retained for as long as something is loading.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSendRequest): Increase the load counter.


(WebFrameLoaderClient::dispatchDidFinishLoading):
(WebFrameLoaderClient::dispatchDidFailLoading):
Decrease the load counter,


  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):


(WebDocumentLoaderMac::attachToFrame):
If the document loader has been detached, make sure to retain its data source here.


(WebDocumentLoaderMac::detachFromFrame):
Release the data source.


(WebDocumentLoaderMac::increaseLoadCount):
Retain the data source if load count was 0.


(WebDocumentLoaderMac::decreaseLoadCount):
Release the data source if load count becomes 0

5:07 PM Changeset in webkit [20038] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Update check-for-global-initializers to ignore new debug initializers in bidi.o and kjs_events.o.

  • Scripts/check-for-global-initializers:
3:33 PM Changeset in webkit [20037] by thatcher
  • 1 edit in trunk/WebKit/English.lproj/Localizable.strings

Updating the localized strings.

3:32 PM Changeset in webkit [20036] by thatcher
  • 1 edit in trunk/WebCore/html/HTMLAnchorElement.cpp

Fixing a comment.

3:11 PM Changeset in webkit [20035] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by Yongjun

DESC: Browser: page info not shown correctly after going back to secure page HMNN-6YNH7J
​http://bugs.webkit.org/show_bug.cgi?id=12989

3:08 PM Changeset in webkit [20034] by brmorris
  • 5 edits in S60/trunk/WebKit

yaharon, reviewed by sachin, brad (for sdk build)

DESC: Take new graphics into use when displaying the url
​http://bugs.webkit.org/show_bug.cgi?id=12977

3:05 PM Changeset in webkit [20033] by brmorris
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by Sachin

DESC: merge r20032 to s60/trunk. SLON-6VZ8Vu - Web Browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=12927

3:04 PM Changeset in webkit [20032] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

vbradley, reviewed by Sachin

DESC: SLON-6VZ8Vu - Web Browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=12927

3:03 PM Changeset in webkit [20031] by oliver
  • 2 edits in trunk/WebCore

2007-03-07 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti.

Reset mouse down/drag state variables on mouse button release


Fixes <rdar://problem/5044654>: Drag out of some QuickTime plug-ins converting into image drag

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
2:53 PM Changeset in webkit [23036] by adele
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKitWin part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebEditorClient.cpp: (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. (WebEditorClient::handleInputMethodKeypress): Added.
  • WebEditorClient.h:
2:49 PM Changeset in webkit [20030] by adele
  • 16 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Call handleInputMethodKeypress before actually dispatching the keypress event so that input methods have a chance to handle the event. If the input method handles the event (by marking or unmarking text), then we don't need to send the keypress event. If an input method doesn't handle the event, then we'll save the data we need to perform the correct action (like what text to insert or what selector to use) when we dispatch the keypress event.
  • dom/KeyboardEvent.h: Added Mac-specific KeypressCommand struct, so we can store command info during handleInputMethodKeypress, and use it during handleKeypress. (WebCore::KeyboardEvent::keypressCommand): (WebCore::KeyboardEvent::setKeypressCommand):
  • bridge/EditorClient.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::Editor::handleInputMethodKeypress): Added.
  • editing/Editor.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::SVGEmptyEditorClient::handleInputMethodKeypress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent: shouldSaveCommand:]): Added shouldSaveCommand field to WebHTMLViewInterpretKeyEventsParameters. When shouldSaveCommand is true, we call interpretKeyEvents and in doCommandBySelector and insertText, we just save the information without performing any action. When shouldSaveCommand is false, we used the saved information and call doCommandBySelector and insertText directly. If there's no saved command data in the KeyboardEvent, call interpretKeyEvents, and honor the shouldSaveCommand argument. This allows repeating keypress events to function normally. (-[WebHTMLView doCommandBySelector:]): If the WebHTMLViewInterpretKeyEventsParameters shouldSaveCommand field is set, then just save the selector information in the KeyboardEvent, and don't perform the action. (-[WebHTMLView insertText:]): ditto. insertText can be called from an input method or from normal key event processing If its from an input method, then we should go ahead and insert the text now. The only way we know if its from an input method is to check hasMarkedText. There might be a better way to do this.
  • WebView/WebHTMLViewInternal.h: Added shouldSaveCommand argument.
  • WebView/WebViewInternal.h: ditto.
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. Call _interceptEditingKeyEvent with shouldSaveCommand:NO. (WebEditorClient::handleInputMethodKeypress): Call _interceptEditingKeyEvent with shouldSaveCommand:YES.

WebKitQt:

Reviewed by Darin.

WebKitQT part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::EditorClientQt::handleInputMethodKeypress): Added.
  • WebCoreSupport/EditorClientQt.h:
2:30 PM Changeset in webkit [20029] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

Add some assertions.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
2:26 PM Changeset in webkit [23035] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebFrame.cpp: (WebFrame::makeDocumentView): Assert that frame is not null.
1:25 PM Changeset in webkit [20028] by rwlbuis
  • 21 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12579
WebKit fails SVG xml:base test

Implement DOM3 properties baseURI and documentURI to fix
the testcase in bug 12579.

11:31 AM Changeset in webkit [20027] by andersca
  • 9 edits in trunk

WebCore:

Reviewed by Brady.

Remove some methods in FrameLoader that just calls down to the active document loader. Since each
resource loader now has a pointer to its document loader, we can just call directly to the
document loader.

  • WebCore.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::didReceiveResponse):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit:

Reviewed by Brady.

Update to match WebCore.


  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]):
11:25 AM Changeset in webkit [20026] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix for non-multiple-thread folks.


Use a shared global in the non-multiple-thread case.

  • wtf/FastMalloc.cpp: (WTF::isForbidden): (WTF::fastMallocForbid): (WTF::fastMallocAllow):
11:10 AM Changeset in webkit [20025] by beidson
  • 2 edits in trunk/WebKitSite

Whoops, its actually prepare-ChangeLog

  • coding/contributing.html:
11:09 AM Changeset in webkit [20024] by beidson
  • 2 edits in trunk/WebKitSite

Reviewed by Anders

Explicitly mention the prepare-Changelog step for contributing patches

  • coding/contributing.html:
11:07 AM Changeset in webkit [20023] by darin
  • 7 edits in trunk/LayoutTests

Reviewed by Geoff.

  • change tests that depend on the order of iteration of built-in properties to sort explicitly so they don't depend on the order any more
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/js/regexp-caching-expected.txt:
  • fast/js/regexp-caching.html:
10:32 AM Changeset in webkit [20022] by ap
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12953
Import/convert 4XPath test suite

Import the rest of the converted suite. The only remaining failures are due to
incorrect node order, bug 12497.

  • fast/xpath/4XPath/Core/test_literal_expr.html: Added.
  • fast/xpath/4XPath/Core/test_location_path.html: Added.
  • fast/xpath/4XPath/Core/test_node_test.html: Added.
  • fast/xpath/4XPath/Core/test_nodeset_expr.html: Added.
  • fast/xpath/4XPath/Core/test_parser-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_parser.html: Added.
  • fast/xpath/4XPath/Core/test_predicate_list.html: Added.
  • fast/xpath/4XPath/Core/test_step-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_step.html: Added.
8:40 AM Changeset in webkit [20021] by darin
  • 2 edits in trunk/WebKitQt
  • WebCoreSupport/FrameLoaderClientQt.h: Oops, forgot the header.
8:34 AM Changeset in webkit [20020] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed ASSERT failure I just introduced.


Made the fastMalloc isForbidden flag per thread. (Oops!) We expect that
other threads will malloc while we're marking -- we just want to prevent
our own marking from malloc'ing.

  • wtf/FastMalloc.cpp: (WTF::initializeIsForbiddenKey): (WTF::isForbidden): (WTF::fastMallocForbid): (WTF::fastMallocAllow): (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::fastRealloc): (WTF::do_malloc):
7:37 AM Changeset in webkit [20019] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12997

Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

  • kjs/collector.cpp: (KJS::Collector::markMainThreadOnlyObjects):

WebCore:

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4576242> | ​http://bugs.webkit.org/show_bug.cgi?id=12586
PAC file: malloc deadlock sometimes causes a hang @ www.apple.com/pro/profiles/ (12586)


No test because this is very difficult to repro, and the new ASSERTs in
JavaScriptCore catch the underlying cause while running normal layout tests.


This is a modified version of r14752 on the branch.


The fix is to use a bit inside each node, instead of a hash table, to track
which node subtrees are in the process of being marked. This avoids a call
to malloc inside mark().


  • bindings/js/kjs_binding.cpp: (KJS::domObjects): (KJS::domNodesPerDocument):
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::mark):
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h:
7:01 AM Changeset in webkit [20018] by ddkilzer
  • 24 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests using both dumpDOMAsWebArchive() and dumpSourceAsWebArchive() were added
for this bug since a similar fix was suggested for the DOM case which was not
needed. The remaining changes are related to renaming dumpAsWebArchive() to
dumpDOMAsWebArchive().

  • webarchive/archive-empty-frame-dom-expected.txt: Added.
  • webarchive/archive-empty-frame-dom.html: Added.
  • webarchive/archive-empty-frame-source-expected.txt: Added.
  • webarchive/archive-empty-frame-source.html: Added.
  • webarchive/resources/dump-webarchive.js: Renamed dumpAsWebArchive() to dumpDOMAsWebArchive().
  • webarchive/test-body-background-expected.txt: Ditto.
  • webarchive/test-body-background.html: Ditto.
  • webarchive/test-duplicate-resources-expected.txt: Ditto.
  • webarchive/test-frameset-expected.txt: Ditto.
  • webarchive/test-frameset.html: Ditto.
  • webarchive/test-img-src-expected.txt: Ditto.
  • webarchive/test-img-src.html: Ditto.
  • webarchive/test-input-src-expected.txt: Ditto.
  • webarchive/test-input-src.html: Ditto.
  • webarchive/test-link-href-expected.txt: Ditto.
  • webarchive/test-link-href.html: Ditto.
  • webarchive/test-object-data-expected.txt: Ditto.
  • webarchive/test-object-data.html: Ditto.
  • webarchive/test-script-src-expected.txt: Ditto.
  • webarchive/test-table-background-expected.txt: Ditto.
  • webarchive/test-table-background.html: Ditto.
  • webarchive/test-td-background-expected.txt: Ditto.
  • webarchive/test-td-background.html: Ditto.

WebKit:

Reviewed by Darin.

When dealing with an iframe element with no src attribute, the element contains
a src attribute in the DOM with a URL of "about:blank" and some HTML to implement
the blank page. In the original page source, however, the iframe element does
not include a src attribute, which caused a nil archive to be returned for the
childFrameArchive and thus caused the bug. The fix is a simple nil check.

Test: webarchive/archive-empty-frame-source.html

  • WebView/WebArchiver.mm: (+ (NSArray *)_subframeArchivesForFrame:(WebFrame *)frame): Don't add childFrameArchive to the subframeArchives array if it is nil.

WebKitTools:

Reviewed by Darin.

The dumpDOMAsWebArchive() test method uses the DOMDocument as a basis for creating
a webarchive while the dumpSourceAsWebArchive() test method uses the original
dataSource (page source) to create a webarchive. Most tests currently use
dumpDOMAsWebArchive() since this is what Safari does when saving a web page as a
webarchive.

  • DumpRenderTree/DumpRenderTree.m: Renamed dumpAsWebArchive to dumpDOMAsWebArchive. Added dumpSourceAsWebArchive. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpDOMAsWebArchive]): (-[LayoutTestController dumpSourceAsWebArchive]): (runTest):
6:25 AM Changeset in webkit [20017] by ddkilzer
  • 5 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Mitz.

  • svg/custom/struct-use-09-b.svg: Changed to use Helvetica instead of 'Arial Black', Arial.
  • svg/custom/struct-use-09-b-expected.checksum: Update results.
  • svg/custom/struct-use-09-b-expected.png: Ditto.
  • svg/custom/struct-use-09-b-expected.txt: Ditto.
6:18 AM Changeset in webkit [20016] by darin
  • 2 edits in trunk/WebKitQt
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent): Try to fix the build by correcting the parameter here.
1:46 AM Changeset in webkit [20015] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-07 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12997

Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

  • kjs/collector.cpp: (KJS::Collector::markMainThreadOnlyObjects):
1:05 AM Changeset in webkit [20014] by justing
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by mjs

<​http://bugs.webkit.org/show_bug.cgi?id=8592>
Extra line left after deleting whitespace:pre text

Re-enabled the test and removed a FIXME:

  • editing/deleting/merge-whitespace-pre-expected.checksum:
  • editing/deleting/merge-whitespace-pre-expected.png:
  • editing/deleting/merge-whitespace-pre-expected.txt:
  • editing/deleting/merge-whitespace-pre.html: Added.
  • editing/deleting/merge-whitespace-pre.html-disabled: Removed.
12:49 AM Changeset in webkit [20013] by bdash
  • 3 edits in tags/Safari-5522.3

Versioning.

12:43 AM Changeset in webkit [20012] by bdash
  • 2 edits in trunk

Fix an oversight in the spelling over oversight.

12:40 AM Changeset in webkit [20011] by bdash
  • 10 edits in tags/Safari-5522.3/WebCore

Merge in r19977.

2007-03-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • loader/Cache.cpp: Propogate and check user style sheet flag. (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h: Propogate user style sheet flag.
  • loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag. (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
  • loader/DocLoader.cpp: Propogate user style sheet flag. (WebCore::DocLoader::requestResource):
  • loader/SubresourceLoader.cpp: Propogate and check user style sheet flag. (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h: Add check for user style sheet flag.
  • loader/loader.cpp: Propogate user style sheet flag. (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h: Propogate user style sheet flag.
12:34 AM Changeset in webkit [20010] by bdash
  • 1 copy in tags/Safari-5522.3

New tag.

Mar 6, 2007:

11:42 PM Changeset in webkit [20009] by hyatt
  • 17 edits
    1 add
    1 delete in trunk/WebCore

This patch reworks the WebCore memory cache to significantly reduce the amount of memory consumed by
images in the cache and to enhance the accuracy of the cache size as an absolute bound for the objects
contained within it. WebCore's memory use over time should significantly improve as a result of these
changes.

Cached resources now have both an encoded size (the original data stream) and a decoded size (an estimate of
the amount of memory consumed by an expanded version of that resource, e.g., the decoded frames of an image).
Both sizes now count towards the total size of the object and towards the allowed memory cache total.

By including both totals the reported size of resources will now be larger, and the cache will therefore become
much more aggressive about flushing.

Objects are stored in size-adjusted and popularity-aware LRU lists as before, but encoded size is now always
used when determining the correct LRU list.

The flush algorithm for the memory cache has been rewritten to first destroy decoded data before evicting
resources. By being able to compact its resources without evicting them, the memory cache can now hold many more
unique resources (encoded) in the same amount of space. Depending on how much of a hit we want to take from
re-decoding images, the memory cache could in theory have its size significantly reduced now while still holding
more resources than it did at the larger size!

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::prune): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::adjustSize):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::allReferencesRemoved): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::destroyDecodedData): (WebCore::CachedImage::decodedSize): (WebCore::CachedImage::decodedSizeChanged): (WebCore::CachedImage::shouldPauseAnimation):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize):
  • loader/CachedResource.h: (WebCore::CachedResource::allReferencesRemoved): (WebCore::CachedResource::size): (WebCore::CachedResource::encodedSize): (WebCore::CachedResource::decodedSize): (WebCore::CachedResource::destroyDecodedData):
  • loader/CachedScript.cpp: (WebCore::CachedScript::data):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::~BitmapImage): (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::pruneDecodedDataIfNeeded): (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::setNativeData): (WebCore::BitmapImage::shouldAnimate): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::decodedSize):
  • platform/graphics/Image.cpp: (WebCore::Image::Image):
  • platform/graphics/Image.h: (WebCore::Image::destroyDecodedData): (WebCore::Image::decodedSize): (WebCore::Image::imageObserver):
  • platform/graphics/ImageAnimationObserver.h: Removed.
  • platform/graphics/ImageObserver.h: Added. (WebCore::ImageObserver::~ImageObserver):
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::SVGImage):
  • platform/graphics/svg/SVGImage.h:
10:03 PM Changeset in webkit [20008] by ap
  • 7 edits
    1 add in trunk

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12987
Fix and import 4XPath test_numeric_expr.html

  • xml/XPathPredicate.cpp: (WebCore::XPath::Negative::doEvaluate): Convert the argument to number. (WebCore::XPath::NumericOp::doEvaluate): Convert the arguments to numbers. Use a correct operation for mod.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Do not append parent node if there is none.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNumber): Do not convert to DeprecatedString just to trim whitespace and to convert to double.
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedStringData::makeAscii): Added a FIXME about unreliable makeAscii() behavior.
9:55 PM Changeset in webkit [20007] by bdash
  • 1 edit in trunk/LayoutTests/fast/dom/select-selectedIndex-bug-12942-expected.txt

Fix broken layout test results.

9:36 PM Changeset in webkit [20006] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4619663> REGRESSION (NativePopup): Popup menu doesn't draw at the correct vertical position (9816)


  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Make a temporary dummy view with the passed in rect, since AppKit will use the view bounds to determine what area to exclude when popping up a menu moved to the top of the screen.
9:25 PM Changeset in webkit [20005] by bdash
  • 2 edits in trunk/WebKitLibraries

2007-03-07 Mark Rowe <​mrowe@apple.com>

Build fix. Rebuild against 10.4 SDK.

  • libWebKitSystemInterface.a:
8:25 PM Changeset in webkit [20004] by ggaren
  • 33 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed all known crashers exposed by run-webkit-tests --threaded. This covers:

<rdar://problem/4565394> | ​http://bugs.webkit.org/show_bug.cgi?id=12585

PAC file: after closing a window that contains macworld.com, new window
crashes (KJS::PropertyMap::mark()) (12585)

<rdar://problem/4571215> | ​http://bugs.webkit.org/show_bug.cgi?id=9211

PAC file: Crash occurs when clicking on the navigation tabs at ​http://www.businessweek.com/ (9211)

<rdar://problem/4557926>

PAC file: Crash occurs when attempting to view image in slideshow mode
at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::
ExecState*) + 312) if you use a PAC file

(1) Added some missing JSLocks, along with related ASSERTs.


(2) Fully implemented support for objects that can only be garbage collected
on the main thread. So far, only WebCore uses this. We can add it to API
later if we learn that it's needed.


The implementation uses a "main thread only" flag inside each object. When
collecting on a secondary thread, the Collector does an extra pass through
the heap to mark all flagged objects before sweeping. This solution makes
the common case -- flag lots of objects, but never collect on a secondary
thread -- very fast, even though the uncommon case of garbage collecting
on a secondary thread isn't as fast as it could be. I left some notes
about how to speed it up, if we ever care.


For posterity, here are some things I learned about GC while investigating:


  • Each collect must either mark or delete every heap object. "Zombie" objects, which are neither marked nor deleted, raise these issues:
  • On the next pass, the conservative marking algorithm might mark a zombie, causing it to mark freed objects.
  • The client might try to use a zombie, which would seem live because its finalizer had not yet run.
  • A collect on the main thread is free to delete any object. Presumably, objects allocated on secondary threads have thread-safe finalizers.
  • A collect on a secondary thread must not delete thread-unsafe objects.
  • The mark function must be thread-safe.


Line by line comments:

  • API/JSObjectRef.h: Added comment specifying that the finalize callback may run on any thread.
  • bindings/npruntime.cpp: (_NPN_GetStringIdentifier): Added JSLock.
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::~ObjcInstance): Use an autorelease pool. The other callers to CFRelease needed one, too, but they were dead code, so I removed them instead. (This fixes a leak seen while running run-webkit-tests --threaded, although I don't think it's specifically a threading issue.)


  • kjs/collector.cpp: (KJS::Collector::collectOnMainThreadOnly): New function. Tells the collector to collect a value only if it's collecting on the main thread. (KJS::Collector::markMainThreadOnlyObjects): New function. Scans the heap for "main thread only" objects and marks them.
  • kjs/date_object.cpp: (KJS::DateObjectImp::DateObjectImp): To make the new ASSERTs happy, allocate our globals on the heap, avoiding a seemingly unsafe destructor call at program exit time.
  • kjs/function_object.cpp: (FunctionPrototype::FunctionPrototype): ditto
  • kjs/interpreter.cpp: (KJS::Interpreter::mark): Removed boolean parameter, which was an incomplete and arguably hackish way to implement markMainThreadOnlyObjects() inside WebCore.
  • kjs/interpreter.h:
  • kjs/identifier.cpp: (KJS::identifierTable): Added some ASSERTs to check for thread safety problems.
  • kjs/list.cpp: Added some ASSERTs to check for thread safety problems. (KJS::allocateListImp): (KJS::List::release): (KJS::List::append): (KJS::List::empty): Make the new ASSERTs happy.
  • kjs/object.h: (KJS::JSObject::JSObject): "m_destructorIsThreadSafe" => "m_collectOnMainThreadOnly". I removed the constructor parameter because m_collectOnMainThreadOnly, like m_marked, is a Collector bit, so only the Collector should set or get it.
  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Make the ASSERTs happy.
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): ditto
  • kjs/ustring.cpp: Added some ASSERTs to check for thread safety problems. (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::null): Make the new ASSERTs happy.
  • kjs/ustring.h: (KJS::UString::Rep::ref): Added some ASSERTs to check for thread safety problems. (KJS::UString::Rep::deref):
  • kjs/value.h: (KJS::JSCell::JSCell):

JavaScriptGlue:

Reviewed by Maciej Stachowiak.

Fixed all known crashers exposed by run-webkit-tests --threaded while using
a PAC file (for maximum carnage). See JavaScriptCore ChangeLog for
more details.

  • JSBase.cpp: (JSBase::Release): Lock when deleting, because we may be deleting an object (like a JSRun) that holds thread-unsafe data.
  • JSUtils.cpp: (CFStringToUString): Don't lock, because our caller locks. Also, locking inside a function that returns thread-unsafe data by copy will only mask threading problems.
  • JavaScriptGlue.cpp: (JSRunEvaluate): Added missing JSLock. (JSRunCheckSyntax): Converted to JSLock.
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej Stachowiak.

Fixed all known crashers exposed by run-webkit-tests --threaded [*]. See
JavaScriptCore ChangeLog for more details.

  • bindings/js/kjs_binding.cpp: (KJS::domNodesPerDocument): Added thread safety ASSERT. (KJS::ScriptInterpreter::mark): Removed obsolete logic for marking unsafe objects when collecting on a secondary thread. The Collector takes care of this now.
  • bindings/js/kjs_binding.h: (KJS::DOMObject::DOMObject): Used new API for specifying that WebCore objects should be garbage collected on the main thread only.
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute): Moved JSLock to cover implementedsCall() call, which, for some subclasses, ends up allocating garbage collected objects. (This fix was speculative. I didn't actually see a crash from this.) (KJS::Window::timerFired): Added JSLock around ScheduleAction destruction, since it destroys a KJS::List.
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject setException:]): Added JSLock. (This fix was speculative. I didn't actually see a crash from this.)
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Added JSLock. (This fix was speculative. I didn't actually see a crash from this.)
  • dom/Document.cpp: (WebCore::Document::~Document): Added JSLock around modification to domNodesPerDocument(), which can be accessed concurrently during garbage collection.
  • dom/Node.cpp: (WebCore::Node::setDocument): ditto.


[*] fast/js/toString-stack-overflow.html is an exception. --threaded mode
crashes this test because it causes the garbage collector to run frequently,
and this test crashes if you happen to garbage collect while it's running.
This is a known issue with stack overflow during the mark phase. It's
not related to threading.

8:18 PM Changeset in webkit [20003] by kdecker
  • 2 edits in trunk/WebKitLibraries

Reviewed by Brady

Fixed: <rdar://problem/4126976> private keys imported by WebKit should not be accessible by all applications

  • libWebKitSystemInterface.a:
8:16 PM Changeset in webkit [20002] by bdash
  • 2 edits in trunk/LayoutTests

2007-03-07 Mark Rowe <​mrowe@apple.com>

Add dumpAsText to test to match expected results.

  • fast/dom/Window/window-location-replace-functions.html:
8:07 PM Changeset in webkit [20001] by bdash
  • 4 edits
    2 adds in trunk

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

Test: fast/dom/select-selectedIndex-bug-12942.html.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
  • html/HTMLSelectElement.h:

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/select-selectedIndex-bug-12942.html: Added.
8:05 PM Changeset in webkit [20000] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Rubberstamped by Kevin Decker

20,000!

  • ChangeLog: Point out revision 20,000
8:04 PM Changeset in webkit [19999] by kjk
  • 3 edits in trunk/WebCore

Not reviewed.

Gdk build fix.

  • loader/gdk/FrameLoaderClientGdk.cpp: update userAgent() signature. (WebCore::FrameLoaderClientGdk::userAgent):
  • loader/gdk/FrameLoaderClientGdk.h: ditto.
7:40 PM Changeset in webkit [19998] by bdash
  • 3 edits
    4 adds in trunk

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/select-change-listbox-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Reattach on list box size change.

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/select-change-listbox-size-expected.checksum: Added.
  • fast/forms/select-change-listbox-size-expected.png: Added.
  • fast/forms/select-change-listbox-size-expected.txt: Added.
  • fast/forms/select-change-listbox-size.html: Added.
7:35 PM Changeset in webkit [19997] by bdash
  • 37 edits
    8 adds in trunk

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/content-into-overflow.html

fast/repaint/overflow-into-content.html

Changed repaintAfterLayoutIfNeeded() to take, in addition to the clipped overflow
rect, the unclipped border box plus outline, and to repaint any areas that
were added or removed from that box, in addition to any areas added or removed
from the clipped overflow rect.

  • platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect): Renamed getAbsoluteRepaintRect() to this.
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
  • rendering/RenderFlow.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::checkForRepaintOnResize): (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::absoluteClippedOverflowRect): (WebCore::RenderObject::absoluteOutlineBox):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::absoluteClippedOverflowRect): (WebCore::RenderPath::absoluteRects): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::absoluteClippedOverflowRect): (WebCore::RenderSVGContainer::absoluteRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteClippedOverflowRect):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged): (WebCore::RenderSVGImage::absoluteClippedOverflowRect): (WebCore::RenderSVGImage::absoluteRects):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteClippedOverflowRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::absoluteRects):
  • rendering/RenderSVGText.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absoluteClippedOverflowRect):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::absoluteClippedOverflowRect):
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::absoluteClippedOverflowRect):
  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteClippedOverflowRect):
  • rendering/RenderText.h:

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/bugzilla-6278-expected.checksum:
  • fast/repaint/bugzilla-6278-expected.png:
  • fast/repaint/content-into-overflow-expected.checksum: Added.
  • fast/repaint/content-into-overflow-expected.png: Added.
  • fast/repaint/content-into-overflow-expected.txt: Added.
  • fast/repaint/content-into-overflow.html: Added.
  • fast/repaint/overflow-into-content-expected.checksum: Added.
  • fast/repaint/overflow-into-content-expected.png: Added.
  • fast/repaint/overflow-into-content-expected.txt: Added.
  • fast/repaint/overflow-into-content.html: Added.
7:30 PM Changeset in webkit [19996] by bdash
  • 1 edit
    2 adds in trunk/LayoutTests

2007-03-06 Ian Eng <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

  • fast/dom/Window/window-location-replace-functions-expected.txt: Added.
  • fast/dom/Window/window-location-replace-functions.html: Added.
7:15 PM Changeset in webkit [19995] by bdash
  • 2 edits in trunk/WebCore

2007-03-06 Ian Eng <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: Disallow replacing functions in LocationTable, and return early without updating URL.
6:27 PM Changeset in webkit [19994] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


2% speedup on super accurate JS iBench.

(KJS::Collector::collect): Removed anti-optimization to call
pthread_is_threaded_np() before calling pthread_main_np(). Almost all
apps have more than one thread, so the extra call is actually worse.
Interestingly, even the single-threaded testkjs shows a speed gain
from removing the pthread_is_threaded_np() short-circuit. Not sure why.

6:22 PM Changeset in webkit [19993] by kmccullo
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<​http://bugs.webkit.org/show_bug.cgi?id=12686>
REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT

  • Now all class constructors implement implementsHasInstance.
  • fast/dom/dom-instanceof-expected.txt: Added.
  • fast/dom/dom-instanceof.html: Added.

WebCore:

Reviewed by Darin.

<​http://bugs.webkit.org/show_bug.cgi?id=12686>
REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT

  • Now all class constructors implement implementsHasInstance.
  • bindings/scripts/CodeGeneratorJS.pm:
4:51 PM Changeset in webkit [23034] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • WebFrame.cpp: (WebFrame::makeDocumentView): Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
4:36 PM Changeset in webkit [23033] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

Adapt to an API change in CFURLDownload


  • WebDownload.cpp: (WebDownload::init):
4:35 PM Changeset in webkit [23032] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Fixing the build while semi-blind is fun.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::supportedKeySizes): Need a namespace. (WebCore::signedPublicKeyAndChallengeString): Ditto.
4:27 PM Changeset in webkit [19992] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Rob & Oliver.

Preparations for the new SVG text engine.

Handle baseline-shift / kerning css values correctly.
Recognize missing svg presentation attribute "font-size-adjust".
Add all missing svg<->css property mappings in mapToEntry().

Doesn't affect any layout test (as these properties are not used w/o my text patch).
While I'm at it, unify the macro names (RS_ -> SVG_RS_) & cleanup style a bit.

4:19 PM Changeset in webkit [23031] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

It works better if you use valid C++ syntax.

  • platform/win/TemporaryLinkStubs.cpp:
4:19 PM Changeset in webkit [23030] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Added missing stubs.
4:11 PM Changeset in webkit [19991] by justing
  • 17 edits
    8 adds in trunk

LayoutTests:

Reviewed by kevin


<​http://bugs.webkit.org/show_bug.cgi?id=12245>
FCKeditor: Remove Format sometimes doesn't work
<rdar://problem/4786404>
Underline style is not removed from selection after performing Remove Format

Added:

  • editing/execCommand/4786404-1-expected.checksum: Added.
  • editing/execCommand/4786404-1-expected.png: Added.
  • editing/execCommand/4786404-1-expected.txt: Added.
  • editing/execCommand/4786404-1.html: Added.
  • editing/execCommand/4786404-2-expected.checksum: Added.
  • editing/execCommand/4786404-2-expected.png: Added.
  • editing/execCommand/4786404-2-expected.txt: Added.
  • editing/execCommand/4786404-2.html: Added. Demonstrate fixes:
  • editing/execCommand/4920488-expected.checksum:
  • editing/execCommand/4920488-expected.png:
  • editing/execCommand/4920488-expected.txt:
  • editing/execCommand/4920742-1-expected.checksum:
  • editing/execCommand/4920742-1-expected.png:
  • editing/execCommand/4920742-1-expected.txt:
  • editing/execCommand/remove-formatting-2-expected.checksum:
  • editing/execCommand/remove-formatting-2-expected.png:
  • editing/execCommand/remove-formatting-2-expected.txt: Ditto, also added a FIXME:
  • editing/execCommand/remove-formatting-expected.checksum:
  • editing/execCommand/remove-formatting-expected.png:
  • editing/execCommand/remove-formatting-expected.txt:
  • editing/execCommand/remove-formatting.html:

WebCore:

Reviewed by kevin


<​http://bugs.webkit.org/show_bug.cgi?id=12245>
FCKeditor: Remove Format sometimes doesn't work
<rdar://problem/4786404>
Underline style is not removed from selection after performing Remove Format

  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Re-wrote this.
3:45 PM Changeset in webkit [19990] by zimmermann
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by Oliver.

Add new <use> layout tests. (forgot in last commit)

3:40 PM Changeset in webkit [19989] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12979
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12981

Guard against registering pending resources with empty id.
Be careful with calling recalcStyle() in SVGUseElement, when change is "Detach" we
have to use special code, as calling attach() on the shadow tree root element will crash,
because it has no (direct) parent node, only a shadow parent node element.

2:38 PM Changeset in webkit [19988] by kdecker
  • 6 edits
    2 adds in trunk

Reviewed by Adele.

Fixed: <rdar://problem/5041660> REGRESSION: <keygen> element broken, prevents users from signing up for Thawte email certs


  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Added <keygen> to the DOM bindings so it can be accessed from Objective-C.
  • css/html4.css: Apply the look of the <select> element to <keygen>.
  • html/HTMLElementFactory.cpp: (WebCore::keygenConstructor): Added. (WebCore::createFunctionMap): Added keygen.
  • html/HTMLSelectElement.cpp: Made const typeAheadTimeout variable static const. (WebCore::HTMLSelectElement::HTMLSelectElement): Fix both HTMLSelectElement constructors to initialize the same number of member variables. The fact that some fields were not initialized could (and would) crash the keygen element when selecting different items. Also removed m_typedString(String()) from the constructor initialization because this is not needed.
1:48 PM Changeset in webkit [19987] by zimmermann
  • 3 edits in trunk/LayoutTests

Reviewed by Mitz.
Remove an alert() which got accidently added in my last commit.

11:35 AM Changeset in webkit [19986] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


Made WebAuthenticationHandler.h SPI so Safari can call it directly.

  • WebKit.exp: added .objc_class_name_WebPanelAuthenticationHandler
  • WebKit.xcodeproj/project.pbxproj: changed status of WebAuthenticationHandler.h from "project" to "private"
11:29 AM Changeset in webkit [19985] by kmccullo
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • Rename a function to clarify its purpose.
  • WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
  • WebView/WebViewPrivate.h:
11:28 AM Changeset in webkit [19984] by kmccullo
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • Rename a function to clarify its purpose.
  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::registerURLSchemeAsLocal):
  • loader/FrameLoader.h:
9:05 AM Changeset in webkit [23029] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

9:02 AM Changeset in webkit [19983] by sfalken
  • 1 copy in tags/Safari-521.35.6b

New tag.

8:17 AM Changeset in webkit [19982] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by <Sachin>

DESC: ASOG-6YTLNA -- Remove BROWSER_OSS_ENGINE flag from webkit.iby and webkitresources.iby
​http://bugs.webkit.org/show_bug.cgi?id=12935

3:08 AM Changeset in webkit [23028] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-06 Steve Falkenburg <​sfalken@apple.com>

Rubber-stamped by Adam.


Fix disney.com more. Disney redirects to disney.go.com.

  • WebView.cpp: (WebView::userAgentForKURL): Added disney.go.com
2:27 AM Changeset in webkit [19981] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.exp: Updated symbols.
2:02 AM Changeset in webkit [23027] by aroben
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Always keep rounding hacks on.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth): Tell StringTruncator to keep rounding hacks on.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreTextFloatWidth): Ditto.

WebKitWin:

Reviewed by Anders.

Always keep rounding hacks on to be consistent.

  • WebDragClient.cpp: (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
  • WebKitGraphics.cpp: (CenterTruncateStringToWidth): Ditto. (RightTruncateStringToWidth): Ditto.
1:57 AM Changeset in webkit [19980] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Anders.

Added a parameter to all StringTruncator methods to specify whether
rounding hacks should be on or off.

No layout test possible.

  • platform/StringTruncator.cpp: (WebCore::stringWidth): Added disableRoundingHacks parameter. (WebCore::truncateString): Ditto. (WebCore::StringTruncator::centerTruncate): Ditto. (WebCore::StringTruncator::rightTruncate): Ditto. (WebCore::StringTruncator::width): Ditto.
  • platform/StringTruncator.h: Ditto.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Pass in false to centerTruncate so that the truncation matches the way the text will be rendered.
1:32 AM Changeset in webkit [23026] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Allow custom user agents per site.


This fixes:


​http://www.disney.com
​http://www.yahoo.com
​http://mail.google.com
iTunes store links (w/ latest unsubmitted CFNetwork from our root share)

  • WebView.cpp: (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
1:05 AM Changeset in webkit [19979] by andersca
  • 8 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at ​http://www.metoffice.gov.uk/weather/satellite/index.html


Add some tests where image elements have id _and_ name elements.


  • fast/dom/HTMLDocument/document-special-properties-expected.txt:
  • fast/dom/HTMLDocument/document-special-properties.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at ​http://www.metoffice.gov.uk/weather/satellite/index.html


It turns out WinIE does allow you to access images by their id as special document properties. However, this is only
allowed when the element also has a name attribute. The value of the name attribute is ignored and can even be empty!


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): Return jsUndefined() if the collection is empty.


  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::insertedIntoDocument): (WebCore::HTMLImageElement::removedFromDocument):
  • html/HTMLImageElement.h: Add the id attribute value to the extra named item map.


  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem): Check for images with name attributes that match, as well as elements with id attributes that match where the element also has a name attribute.
12:50 AM Changeset in webkit [23025] by andersca
  • 5 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Adam.


Pass the user agent on.


  • WebFrame.cpp: (WebFrame::userAgent):
  • WebFrame.h:
12:37 AM Changeset in webkit [19978] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Adam.

WebCore part of patch to make it possible to have different user agents for different URLs.

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setLoading):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::applyUserAgent):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::userAgent):

WebKit:

Reviewed by Adam.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent):

Mar 5, 2007:

11:04 PM Changeset in webkit [19977] by kmccullo
  • 13 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • http/tests/security/local-user-CSS-from-remote-expected.txt: Added.
  • http/tests/security/local-user-CSS-from-remote.html: Added.

WebCore:

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • loader/Cache.cpp: Propogate and check user style sheet flag. (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h: Propogate user style sheet flag.
  • loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag. (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
  • loader/DocLoader.cpp: Propogate user style sheet flag. (WebCore::DocLoader::requestResource):
  • loader/SubresourceLoader.cpp: Propogate and check user style sheet flag. (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h: Add check for user style sheet flag.
  • loader/loader.cpp: Propogate user style sheet flag. (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h: Propogate user style sheet flag.

WebKitTools:

Reviewed by Mark and Dave H.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • DumpRenderTree/DumpRenderTree.m: Add ability to set user style sheet to DRT. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUserStyleSheetLocation:]): (-[LayoutTestController setUserStyleSheetEnabled:]):
10:33 PM Changeset in webkit [23024] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5041348>
Can't watch videos at cnn.com


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::cancelAndDestroyStream): Change this function back to call call stop() after destroyStream(). Also, make sure to protect the stream since destroyStream can eventually, well, destroy it.
9:41 PM Changeset in webkit [19976] by bdash
  • 1 edit in tags/Safari-5522.2/WebKit/Info.plist

Versioning.

9:40 PM Changeset in webkit [19975] by bdash
  • 3 edits in tags/Safari-5522.2/WebKit

Merge in r19929.

2007-03-01 Justin Garcia <​justin.garcia@apple.com>

Reviewed by harrison


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Provide subresources used to create the fragment as a
convenience.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Update the calls to the changed method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Give the caller the subresources in the WebArchive and RTF cases.
  • WebView/WebHTMLViewPrivate.h:
9:36 PM Changeset in webkit [19974] by bdash
  • 1 copy in tags/Safari-5522.2/WebKit

New tag (part 2).

9:35 PM Changeset in webkit [19973] by bdash
  • 1 add in tags/Safari-5522.2

New tag (part 1).

5:35 PM Changeset in webkit [19972] by zimmermann
  • 142 edits
    10 adds in trunk

Reviewed by Darin.

Fix all (except one) known <use> bug. The remaining bug (12630) is not crucical at all.
Enable <use> again as default SVG feature, as discussed on webkit-dev.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12936 (Master bug used to track all current use problems.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12926 (transform attribute not respected in nested <use> elements)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12267 (getElementById broken for <use>)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12916 (use instance in symbol definition does not work)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12917 (mouseout event does not occur after scaling use instance)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> DOM broken for script)

Added test: svg/custom/use-nested-transform.svg
Added test: svg/custom/struct-use-09-b.svg (not yet official W3C-SVG-1.1 testcase)
Fixes test: svg/custom/use-elementInstance-event-target.svg (rectangle now turns green on first click)

5:11 PM Changeset in webkit [19971] by beidson
  • 3 edits in trunk/WebCore

Reviewed by John

Fixes <rdar://problem/4974258>
Adds some key null checking

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::implementsCall): Null check doc/frame
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): Null check doc/frame
4:05 PM Changeset in webkit [19970] by zimmermann
  • 5 edits
    4 adds in trunk

Reviewed by Darin.

Path::normalAngleAtLength() / Path::pointAtLength() don't work correctly.
pointAtLength() was not implemented, basically and normalAngleAtLength()
had a bug in the tangent slope calculation.

The normalAngleAtLength() stuff can only be tested with my local textPath support.
New LayoutTest: svg/custom/path-textPath-simulation.svg

3:02 PM Changeset in webkit [19969] by oliver
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

2007-03-05 Darin Adler <Darin Adler>

Reviewed by Oliver.

Text encoding test case

  • fast/encoding/char-encoding-expected.txt: Added.
  • fast/encoding/char-encoding.html: Added.
  • fast/encoding/charset-names-expected.txt: Moved.
  • fast/encoding/charset-names.html: Moved.
1:09 PM Changeset in webkit [23023] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4987743>
Regression: java content is represented as broken images on pages


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Make sure to set the size of the NPPluginFuncs struct correctly.
12:39 PM Changeset in webkit [19968] by ap
  • 5 edits
    1 copy
    1 add in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12970
Fix and import 4XPath test_core_functions.html test

WebCore:

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Fully initialize the evaluation context.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstring::doEvaluate): Fixed handling of edge cases. (WebCore::XPath::FunRound::round): Reimplemented to match the spec; exposed FunRound::round() to be used in other functions.

LayoutTests:

  • fast/xpath/4XPath/Core/test_core_functions-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_core_functions.html: Added. The remaining failures with id() are caused by an XML DOM problem - ID attributes declared in an internal subset are not treated as such.
  • fast/xpath/4XPath/Core/test.js: Common data for XPath tests.
12:29 PM Changeset in webkit [19967] by andersca
  • 2 edits in trunk/LayoutTests
  • plugins/get-url-with-blank-target-expected.txt: Update test result.
11:38 AM Changeset in webkit [23022] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Added line spacing querying to FontMetrics to support line wrapping.

11:31 AM Changeset in webkit [19966] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam, Darin.

<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

  • plugins/get-url-with-blank-target-expected.txt: Added.
  • plugins/get-url-with-blank-target.html: Added.

WebKit:

Reviewed by Adam, Darin.


<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Handle the case where the web view returned from the delegate method is null. Also, send out an error notification in that case so we can catch it.

WebKitTools:

Reviewed by Adam, Darin.

<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object


Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
to be run when the URL has finished (or failed) loading.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): (handleCallback):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_URLNotify):
10:37 AM Changeset in webkit [19965] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin and Kevin D

  • fixed <rdar://problem/5038087> Header and footer on printed page are too large after certain steps
  • WebView/WebView.mm: (-[WebView _adjustPrintingMarginsForHeaderAndFooter]): This method was modifying the margins in the NSPrintInfo object without any sort of check whether this had already been done. In some cases this can be called multiple times with the same NSPrintInfo, so now we stash information in the NSPrintInfo's dictionary such that we always start with a fresh copy of the original margins.
10:25 AM Changeset in webkit [19964] by ap
  • 12 deletes in trunk/LayoutTests/fast/xpath/4XPath/Core

Remove accidentally committed tests.

9:36 AM Changeset in webkit [19963] by ap
  • 6 edits
    2 moves
    36 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12954
XPath relative operations are implemented incorrectly

WebCore:

  • xml/XPathPredicate.cpp: (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::EqTestOp::compare): (WebCore::XPath::EqTestOp::doEvaluate): Reimplemented relative equality operations to match the spec.
  • xml/XPathPredicate.h: (WebCore::XPath::NumericOp::): (WebCore::XPath::EqTestOp::): Moved relative operations to EqTestOp.
  • xml/XPathGrammar.y:
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::nextTokenInternal): (WebCore::XPath::Parser::lex): Adapted for the above changes.

LayoutTests:

  • fast/xpath/4XPath/Core/test_boolean_expr-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_boolean_expr.html: Added.
  • fast/xpath/4XPath/Borrowed/cz_20030217-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/cz_20030217.html: Added.
  • fast/xpath/4XPath/Borrowed/kd_20010423-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/kd_20010423.html: Added.
  • fast/xpath/4XPath/Borrowed/od_20000608-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/od_20000608.html: Added.
  • fast/xpath/4XPath/Borrowed/resources/od_20000608.xml: Added.
  • fast/xpath/4XPath/Borrowed/rs_20010831-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/rs_20010831.html: Added.
  • fast/xpath/4XPath/Borrowed/sr_20021217-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/sr_20021217.html: Added. Added a bunch of XPath tests that already passed.
  • fast/xpath/4XPath/Borrowed/namespace-nodes-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/namespace-nodes.html: Added.
  • fast/xpath/namespace-nodes-expected.txt: Removed.
  • fast/xpath/namespace-nodes.html: Removed. Moved a previously imported 4XPath test.
1:41 AM Changeset in webkit [19962] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Pesky apostrophe.

1:39 AM Changeset in webkit [19961] by bdash
  • 2 edits in trunk/WebCore

2007-03-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Lars.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12947
Bug 12947: REGRESSION: ASSERTION FAILED: maxWidth >= 0 in StringTruncator.cpp:109 in WebCore::truncateString()

Handle nil window correctly in toUserSpace and toDeviceSpace. On Intel Mac's a message to nil that returns a
float will return 0.0. We use this as the divisor in calculating a scale factor, which results in NaN being
introduced into our rect.

  • platform/mac/ScreenMac.mm: (WebCore::toUserSpace): (WebCore::toDeviceSpace):
1:07 AM Changeset in webkit [19960] by rwlbuis
  • 3 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12868
parts of the CSS classes in this simple SVG example are not applied

Make sure the xml stylesheets are parsed in strict mode.

1:00 AM Changeset in webkit [23021] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-05 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop): Call cancel() instead of stopLoading(), since the latter was removed.

Mar 4, 2007:

10:18 PM Changeset in webkit [19959] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12961
shouldBe() should support NaN

  • fast/js/resources/js-test-pre.js: Make shouldBe() succeed if both sides are NaN numbers.
9:40 PM Changeset in webkit [19958] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/keydown-keypress-preventDefault-expected.txt: Added.
  • fast/events/keydown-keypress-preventDefault.html: Added.

WebCore:

Reviewed by Darin.

Change to dispatch the keypress event during the defaultEventHandler for keydown events. This matches IE behavior.
This is preparation for fixing event dispatch with input methods (​http://bugs.webkit.org/show_bug.cgi?id=10871)

Test: fast/events/keydown-keypress-preventDefault.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Call the defaultKeyboardEventHandler for keydown events.
  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): Return 0 instead of false since the return type in EventTargetNode. (WebCore::EventHandler::keyEvent): Removed dispatch of keypress event, since this is now done in the default event handler. (WebCore::EventHandler::defaultKeyboardEventHandler): For keydown events, create and dispatch a keypress event.
9:34 PM Changeset in webkit [19957] by ap
  • 3 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann (yay!).

​http://bugs.webkit.org/show_bug.cgi?id=12962
4XPath tests crash on lang() function

Covered by 4XPath tests, to be landed later.

  • platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind): Do not crash with empty strings.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::doEvaluate): Do not crash when an element has no attributes. Use a proper namespace for xml:lang (not sure where "xms" came from). Rewrote the algorithm for suffix removing to match the spec.
5:33 PM Changeset in webkit [19956] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Nikolas Zimmermann.

  • wtf/Assertions.cpp: Don't #define WINVER and _WIN32_WINNT if they are already defined.
3:30 PM Changeset in webkit [19955] by andersca
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5028165>
​http://bugs.webkit.org/show_bug.cgi?id=12915
REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)

  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
  • http/tests/xmlhttprequest/abort-should-cancel-load.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5028165>
​http://bugs.webkit.org/show_bug.cgi?id=12915
REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Save the value of m_loading since calling FrameLoader::stopLoading could set it to false.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didCancel):
  • loader/SubresourceLoader.h: Get rid of didCancel now, it's not needed anymore.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call cancel() instead of stopLoading(). Also, set m_aborted to true so the XMLHttpRequest object won't be dereferenced in didFail when aborting.
1:24 PM Changeset in webkit [19954] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Nikolas Zimmermann.

Move ScrollView stubs to ScrollViewGdk.cpp

  • platform/gdk/FrameGdk.h: remove comment that no longer makes sense
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gdk/TemporaryLinkStubs.cpp:

WebKitTools:

Reviewed by Nikolas Zimmermann.

Load a url given on a command line in a way that also
works for local (​file://) urls.

  • GdkLauncher/main.cpp: (main):
7:47 AM Changeset in webkit [19953] by ddkilzer
  • 1 edit
    2 moves in trunk/LayoutTests

LayoutTests:

Reviewed by Nikolas Zimmermann.

Fixed spelling of "processer" to "processor" in file names.

  • fast/xsl/xslt-processer-expected.txt: Removed.
  • fast/xsl/xslt-processer.html: Removed.
  • fast/xsl/xslt-processor-expected.txt: Added. Results progressed after fixing Bugzilla Bug 12735 (<rdar://problem/4545040>).
  • fast/xsl/xslt-processor.html: Added.

Mar 2, 2007:

6:18 PM Changeset in webkit [19952] by kmccullo
  • 39 edits
    20 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • fast/loader/local-CSS-from-local-expected.txt: Added.
  • fast/loader/local-CSS-from-local.html: Added.
  • fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • fast/loader/local-JavaScript-from-local.html: Added.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Added.
  • fast/loader/local-iFrame-source-from-local.html: Added.
  • fast/loader/local-image-from-local-expected.txt: Added.
  • fast/loader/local-image-from-local.html: Added.
  • http/tests/security/local-CSS-from-remote-expected.txt: Added.
  • http/tests/security/local-CSS-from-remote.html: Added.
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
  • http/tests/security/local-JavaScript-from-remote.html: Added.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Added.
  • http/tests/security/local-iFrame-from-remote.html: Added.
  • http/tests/security/local-image-from-remote-expected.txt: Added.
  • http/tests/security/local-image-from-remote.html: Added.
  • http/tests/security/resources/compass.jpg: Added.
  • http/tests/security/resources/cssStyle.css: Added.
  • http/tests/security/resources/localPage.html: Added.
  • http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • WebCore.exp: added exported functions
  • bindings/objc/DOM.mm: consolodated function to base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/Document.cpp: Cache the document's ability to load local resources. (WebCore::Document::Document): (WebCore::Document::setURL): (WebCore::Document::shouldBeAllowedToLoadLocalResources): (WebCore::Document::stylesheetLoaded):
  • dom/Document.h: Cache the docuent's ability to load local resources. (WebCore::Document::getPendingSheet): (WebCore::Document::isAllowedToLoadLocalResources):
  • html/HTMLImageLoader.cpp: Moved functionality into base class. (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLLinkElement.cpp: Handles null returns correctly now.
  • html/HTMLTokenizer.cpp: Moved functionality into base class. (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class. (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: Checks if the cached resource can be loaded. (WebCore::Cache::requestResource):
  • loader/CachedCSSStyleSheet.cpp: Moved functionality into base class. (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedImage.cpp: Moved functionality into base class. (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h: Moved functionality into base class. (WebCore::CachedImage::canRender):
  • loader/CachedResource.cpp: Cache if the CachedResource should be treated as local (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: Moved functionality into base class. (WebCore::CachedResource::errorOccurred): (WebCore::CachedResource::shouldTreatAsLocal):
  • loader/CachedScript.cpp: Moved functionality into base class. (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h: Moved functionality into base class. (WebCore::CachedScript::schedule):
  • loader/CachedXBLDocument.cpp: Moved functionality into base class. (WebCore::CachedXBLDocument::error):
  • loader/CachedXSLStyleSheet.cpp: Moved functionality into base class. (WebCore::CachedXSLStyleSheet::error):
  • loader/FrameLoader.cpp: See comments for each function below. (WebCore::FrameLoader::loadSubframe): Use new canLoad. (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check. (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check. (WebCore::localSchemes): Return set of schemes that are to be treated as local. (WebCore::FrameLoader::loadPlugin): Use new canLoad. (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously. (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed. (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info. (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local. (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
  • loader/FrameLoader.h: Declared functions for this security fix. See above.
  • loader/MainResourceLoader.cpp: Optized order of bools to regain performance. (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/SubresourceLoader.cpp: Now restricts remote from loading local resources. (WebCore::SubresourceLoader::create):
  • page/EventHandler.cpp: Moved functionality into base class. (WebCore::selectCursor):
  • platform/KURL.cpp: KURLs need to check all the registered schemes now. (WebCore::KURL::isLocalFile):
  • rendering/HitTestResult.cpp: Moved functionality into base class. (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: Moved functionality into base class. (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: Moved functionality into base class. (WebCore::RenderImage::errorOccurred):
  • rendering/RenderListItem.cpp: Moved functionality into base class. (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: Moved functionality into base class. (WebCore::RenderListMarker::isImage):
  • xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):

WebKit:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • Misc/WebKitVersionChecks.h: added linked-on-or-after check
  • Misc/WebNSAttributedStringExtras.mm: Moved functionalit into the base class. (fileWrapperForElement):
  • Plugins/WebNetscapePluginStream.mm: uses new canLoad functions
  • Plugins/WebPluginContainerCheck.mm: uses new canLoad functions (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebView.mm: make linked-on-or-after check and cache value, exposes SPI for registering a scheme as local. (-[WebView _commonInitializationWithFrameName:groupName:]): (+[WebView registerSchemeAsLocal:]):
  • WebView/WebViewPrivate.h: exposes SPI for registering a scheme as local.
5:46 PM Changeset in webkit [19951] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by kevin


<rdar://problem/5028447>
REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

  • editing/pasteboard/5028447-expected.checksum: Added.
  • editing/pasteboard/5028447-expected.png: Added.
  • editing/pasteboard/5028447-expected.txt: Added.
  • editing/pasteboard/5028447.html: Added.

WebCore:

Reviewed by kevin


<rdar://problem/5028447>
REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

  • editing/markup.cpp: (WebCore::createMarkup): The style of the div that holds a fully selected body's styles didn't include styles inherited from the body's ancestors.
4:48 PM Changeset in webkit [19950] by ggaren
  • 2 edits in trunk/WebKitTools

Tweaked parse-malloc-history to work with new malloc_history output format.

  • Scripts/parse-malloc-history:
4:09 PM Changeset in webkit [23020] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Beth.

Make submenus draw using the UIDelegate.

  • Interfaces/IWebUIDelegate.idl: Added new delegate method to add custom drawing data for menus.
  • WebView.cpp: (WebView::onInitMenuPopup): Added. Calls new delegate method. (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called for all submenus.
  • WebView.h: Added declaration.
3:02 PM Changeset in webkit [19949] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4545040>
innerHTML does not HTML-escape text nodes inside PRE elements
<rdar://problem/5027857>
Pasting into Mail from Safari's view-source window renders the HTML

  • editing/pasteboard/5027857-expected.checksum: Added.
  • editing/pasteboard/5027857-expected.png: Added.
  • editing/pasteboard/5027857-expected.txt: Added.
  • editing/pasteboard/5027857.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4545040>
innerHTML does not HTML-escape text nodes inside PRE elements
<rdar://problem/5027857>
Pasting into Mail from Safari's view-source window renders the HTML

  • editing/HTMLInterchange.cpp: (WebCore::convertHTMLTextToInterchangeFormat): Send this function the node that the text comes from as a parameter. It shouldn't convert '\n's to spaces/nbsps if the text is coming from text where newlines are preserved.
  • editing/HTMLInterchange.h:
  • editing/markup.cpp: (WebCore::startMarkup): Escape text inside the children of PREs.
2:35 PM Changeset in webkit [23019] by aroben
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Added optional underlining of a single character to
WebCoreTextRenderer.

No layout tests possible.

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint): Added. This is an extraction of the code from DrawTextAtPoint that now also contains the underlining code. (WebCore::WebCoreDrawTextAtPoint): Call the helper function. (WebCore::WebCoreDrawDoubledTextAtPoint): Ditto.
  • platform/win/WebCoreTextRenderer.h: Added optional underlinedIndex parameters.

WebKitWin:

Reviewed by Anders.

Added optional underlining of a single character to WebKitGraphics.

1:10 PM Changeset in webkit [19948] by weinig
  • 4 edits in trunk

WebCore:

Reviewed by Anders.

Try to fix the Qt build.

  • platform/qt/TemporaryLinkStubs.cpp: Add stubs. (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):

WebKitQt:

Reviewed by Anders.

Try to fix the Qt build

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragDestinationAction): (WebCore::DragClientQt::dragControllerDestroyed): (WebCore::DragClientQt::createDragImageForLink):
1:06 PM Changeset in webkit [19947] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-03-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.


Add unsigned int hash traits (matches existing unsigned long version)

  • wtf/HashTraits.h: (WTF::):
1:06 PM Changeset in webkit [19946] by harrison
  • 2 edits in trunk/WebCore

Suggested by Darin.

A more efficient solution to rdar://4961431.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]):
11:55 AM Changeset in webkit [19945] by aroben
  • 4 edits in trunk/JavaScriptCore

Reviewed by Kevin M.

Try to fix the Qt build.

  • kjs/DateMath.cpp: (KJS::msToGregorianDateTime): Removed unnecessary "struct" keyword.
  • kjs/DateMath.h: Moved forward declarations to the top of the file before they are used.
  • kjs/date_object.cpp: (KJS::formatLocaleDate): Changed to take a const GregorianDateTime& since GregorianDateTime is Noncopyable.
11:53 AM Changeset in webkit [19944] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5032095>
Gmail Editor: Copied text pastes on a new line instead of current line

  • editing/pasteboard/5032095-expected.checksum: Added.
  • editing/pasteboard/5032095-expected.png: Added.
  • editing/pasteboard/5032095-expected.txt: Added.
  • editing/pasteboard/5032095.html: Added.

WebCore:

Reviewed by john


<rdar://problem/5032095>
Gmail Editor: Copied text pastes on a new line instead of current line


Start merge failed to occur because positionAtStartOfInsertedContent
had a bug.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Was failing when inserting <span><div>foo/div></span>. Return the inserted content's first VisiblePosition.
9:42 AM Changeset in webkit [19943] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

  • kjs/DateMath.h: Marked GregorianDateTime as noncopyable, since it has a non-trivial destructor and not the correspoding copy constructor or assignment operator. Changed the GregorianDateTime constructor to use member initialization syntax. Fixed the destructor to use the array delete operator, since timeZone is an array.
  • kjs/DateMath.cpp: (KJS::daysInYear): Changed to call isLeapYear so the rule is not repeated twice. (KJS::getUTCOffset): Added caching on PLATFORM(DARWIN), since we can rely on the notify_check function and "com.apple.system.timezone" to let us know when the offset has changed.
1:39 AM Changeset in webkit [19942] by hyatt
  • 2 edits in trunk/WebCore

Fix glyph map crasher.

12:22 AM Changeset in webkit [19941] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12895
REGRESSION: imagemap: pointer cursor is shown everywhere
<rdar://problem/5028163>


Image with imagemap should never itself be URLElement in hit test results.


No layout test, cursor state can't be captured.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest):

Mar 1, 2007:

11:59 PM Changeset in webkit [19940] by antti
  • 8 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.


HTTP layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>

also for
​http://bugs.webkit.org/show_bug.cgi?id=12604
​http://bugs.webkit.org/show_bug.cgi?id=12020


  • http/tests/misc/multiple-submit-expected.txt: Added.
  • http/tests/misc/multiple-submit.html: Added.
  • http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.

WebCore:

Reviewed by Maciej.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>


and ​http://bugs.webkit.org/show_bug.cgi?id=12604
REGRESSION: After closing the "Would you like to save password" sheet, the form fails
to submit automatically at ​http://www.mac.com/WebObjects/HomePage.woa
<rdar://problem/4871752>


and ​http://bugs.webkit.org/show_bug.cgi?id=12020
REGRESSION: Flickr uploading broken
<rdar://problem/4928662>


Turn protection against multiple forms submission back on. This approach is buggy
but it is way better than not having it at all. Not protecting against this
breaks number of major sites.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedMainResourceError):
  • loader/FrameLoader.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
  • page/Frame.cpp: (WebCore::Frame::setView):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown):
10:35 PM Changeset in webkit [19939] by bdash
  • 4 edits in tags/Safari-5522.1

Versioning.

9:26 PM Changeset in webkit [19938] by bdash
  • 2 edits in tags/Safari-5522.1/WebCore

Merge in r19928.

2007-03-01 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Initialize threadViolationIsException to true.
9:18 PM Changeset in webkit [19937] by bdash
  • 10 edits
    2 copies in tags/Safari-5522.1

Merge in r19921.

2007-02-28 Brady Eidson <​beidson@apple.com>

Reviewed by Beth

Move the Thread Safety Check functions into their own header for export to WebKit

  • WebCore.exp: Export the function
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm: Include the new header
  • platform/Logging.h: Move stuff to ThreadCheck.h
  • platform/ThreadCheck.h: Added.
  • platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
  • platform/mac/ThreadCheck.mm: Added. (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation):

2007-02-28 Brady Eidson <​beidson@apple.com>

Reviewed by Beth

Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
the WebKit API instead of the ASSERT_MAIN_THREAD() hack

  • History/WebBackForwardList.mm: (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]):
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]):
8:47 PM Changeset in webkit [19936] by bdash
  • 1 copy in tags/Safari-5522.1

New tag.

7:16 PM Changeset in webkit [23018] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:13 PM Changeset in webkit [19935] by sfalken
  • 1 copy in tags/Safari-521.35.5b

New tag.

6:42 PM Changeset in webkit [19934] by kmccullo
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

  • Tests that the url of a document after an open is what it was before the open.
  • fast/loader/external-script-URL-location-expected.txt: Added.
  • fast/loader/external-script-URL-location.html: Added.
  • fast/loader/resources/external-script-URL-location.js: Added.

WebCore:

Reviewed by Adam.

  • Added the test case: external-script-URL-location.html
  • Fix an issue where the url of a document is null after an open if the document has no parent.
  • dom/Document.cpp: (WebCore::Document::open):
6:29 PM Changeset in webkit [19933] by bdash
  • 3 edits in tags/Safari-4522.1

Versioning.

6:23 PM Changeset in webkit [19932] by bdash
  • 1 copy in tags/Safari-4522.1

New tag.

6:17 PM Changeset in webkit [19931] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4960250>
​http://bugs.webkit.org/show_bug.cgi?id=11627
REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes


In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the
didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
to be reset to null when other code wasn't expecting it.


This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
that no leaks occur.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
5:58 PM Changeset in webkit [19930] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix ARM crash due to accessing non-4-byte-aligned memory
as 32-bit values.

  • platform/AtomicString.cpp: (WebCore::UCharBufferTranslator::equal):
5:57 PM Changeset in webkit [19929] by justing
  • 3 edits in trunk/WebKit

Reviewed by harrison


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Provide subresources used to create the fragment as a
convenience.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Update the calls to the changed method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Give the caller the subresources in the WebArchive and RTF cases.
  • WebView/WebHTMLViewPrivate.h:
5:53 PM Changeset in webkit [19928] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Initialize threadViolationIsException to true.
4:46 PM Changeset in webkit [23017] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin M.

Add support for right-truncation to WebKitGraphics.

2:04 PM Changeset in webkit [23016] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

  • plugins/win/npfunctions.h: Fix tyop.
2:00 PM Changeset in webkit [19927] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5030628> - Crash opening a new window with the
"New windows open to the same page" pref set

  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly
9:08 AM Changeset in webkit [19926] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12801
Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

Test: editing/pasteboard/createMarkup-assert.xml

  • editing/markup.cpp: (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.

Feb 28, 2007:

11:43 PM Changeset in webkit [19925] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Oliver and Hyatt.

Fix <rdar://problem/5024233> Crash while using Find on empty document

No layout test possible, as this involves a null document.

  • dom/Range.cpp: (WebCore::rangeOfContents): Added an ASSERT.
  • page/Frame.cpp: (WebCore::Frame::findString): Added a null-check for document(). (WebCore::Frame::markAllMatchesForText): Ditto.
8:42 PM Changeset in webkit [23015] by aroben
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Clean up WebCoreTextRenderer. WebCoreDrawTextAtPoint now just draws
text at a point. It doesn't center truncate, clip, or modify alignment.

No layout test possible.

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Use only WebCore types, and don't center truncate or modify alignment. (WebCore::WebCoreDrawDoubledTextAtPoint): Moved from WebKitGraphics.cpp. (WebCore::WebCoreTextFloatWidth): Added.
  • platform/win/WebCoreTextRenderer.h: Updated/added declarations.

WebKitWin:

Reviewed by Anders.

Made WebKitGraphics more flexible.

7:25 PM Changeset in webkit [19924] by oliver
  • 2 edits in trunk/WebKit

2007-02-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fixes <rdar://problem/5012009>


When looking for a requested resource we should also check
the set of manually added subresources if WebCore can't find it.

  • WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]):
5:30 PM Changeset in webkit [19923] by thatcher
  • 8 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12887
Bug#12887: [Drosera] Add ability to close loaded files

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
  • Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
  • Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file
4:47 PM Changeset in webkit [19922] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - simple gdk build fix.

Add stubs for newly introduced localized strings.

  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText):
4:01 PM Changeset in webkit [19921] by beidson
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Beth

Move the Thread Safety Check functions into their own header for export to WebKit

  • WebCore.exp: Export the function
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm: Include the new header
  • platform/Logging.h: Move stuff to ThreadCheck.h
  • platform/ThreadCheck.h: Added.
  • platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
  • platform/mac/ThreadCheck.mm: Added. (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation):

WebKit:

Reviewed by Beth

Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
the WebKit API instead of the ASSERT_MAIN_THREAD() hack

  • History/WebBackForwardList.mm: (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]):
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]):
3:59 PM Changeset in webkit [23014] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):
3:46 PM Changeset in webkit [19920] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION:
Assertion failure copying standalone image

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Use the CachedImage as the resource. This makes more sense anyway. There is no need to null- check the renderer or the CachedImage since we return early if there is no Image* and the HitTestResult::image() function checks for these things.
3:08 PM Changeset in webkit [19919] by adele
  • 8 edits in trunk

WebCore:

Reviewed by Beth.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

Use localized strings from WebKit instead of hard coded strings.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject roleDescription]):
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemText):

WebKit:

Reviewed by Beth.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory searchMenuNoRecentSearchesText]): (-[WebViewFactory searchMenuRecentSearchesText]): (-[WebViewFactory searchMenuClearRecentSearchesText]): (-[WebViewFactory AXWebAreaText]): (-[WebViewFactory AXLinkText]): (-[WebViewFactory AXListMarkerText]): (-[WebViewFactory AXImageMapText]): (-[WebViewFactory AXHeadingText]):
2:31 PM Changeset in webkit [19918] by brmorris
  • 2 edits in S60/trunk/JavaScriptCore

vbradley, reviewed by Yongjun

DESC: merge r19917 to s60/trunk. ALAA-6XSF7U : Reduce stack overflow counter
​http://bugs.webkit.org/show_bug.cgi?id=12928

2:26 PM Changeset in webkit [19917] by brmorris
  • 2 edits in S60/branches/3.1m/JavaScriptCore

vbradley, reviewed by Yongjun.

DESC: ALAA-6XSF7U : Reduce stack overflow counter
​http://bugs.webkit.org/show_bug.cgi?id=12928

2:23 PM Changeset in webkit [19916] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by <Yongjun>

DESC: TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
​http://bugs.webkit.org/show_bug.cgi?id=12901

2:17 PM Changeset in webkit [19915] by brmorris
  • 13 edits in S60/trunk/WebKit

yinxcai, reviewed by <Sachin>

DESC: merge of r19914 to s60/turnk: Browser may crash when selecting No for secure connections HMNN-6YLEHJ
​http://bugs.webkit.org/show_bug.cgi?id=12858

2:15 PM Changeset in webkit [19914] by brmorris
  • 13 edits in S60/branches/3.1m/WebKit

yinxcai, reviewed by <Sachin>

DESC Browser may crash when selecting No for secure connections HMNN-6YLEHJ
​http://bugs.webkit.org/show_bug.cgi?id=12858

2:11 PM Changeset in webkit [19913] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Sachin

DESC: Toolbar should be activated only on long keypress CR: 102-5945
​http://bugs.webkit.org/show_bug.cgi?id=12816

11:56 AM Changeset in webkit [19912] by ggaren
  • 1 edit
    1 move in trunk/LayoutTests

Reviewed by Bradeee Eidson.

Disabling this test for now because it fails on the buildbot but not on
my Intel or PPC machines. I've filed ​http://bugs.webkit.org/show_bug.cgi?id=12930
to track this issue.

  • fast/leaks/003.html: Removed.
7:46 AM Changeset in webkit [19911] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/lists/ol-start-dynamic-expected.checksum: Added.
  • fast/lists/ol-start-dynamic-expected.png: Added.
  • fast/lists/ol-start-dynamic-expected.txt: Added.
  • fast/lists/ol-start-dynamic.html: Added.

WebCore:

Reviewed by Maciej.


Update list marker value when start attribute changes.

  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
4:29 AM Changeset in webkit [19910] by zimmermann
  • 8 edits in trunk

Reviewed by Maciej.

Corrected the use of the new ENABLE() macros in some ksvg2/svg files.
Add new build-webkit flags "--(no-)xpath" / "--(no-)xslt", to be able
to switch off build features easily. Also add "--(no-)svg-experimental-features"
flag, to be able to test filters/animations/use/foreignObject easily.

1:00 AM Changeset in webkit [19909] by bdash
  • 2 edits in trunk/WebKit

2007-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5028473> WebKit allocates a huge number of NSCalendarDates while loading history file

  • History/WebHistory.mm: (-[WebHistoryPrivate insertItem:atDateIndex:]): Use lastVisitedTimeInterval rather than _lastVisitedDate to avoid allocating NSCalendarDates.
12:42 AM Changeset in webkit [23013] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Use RetainPtr instead of explicit release, as this was caused by CFRelease on a null pointer, and REtainPtr is tolerant.
12:29 AM Changeset in webkit [19908] by rwlbuis
  • 34 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12609
Any SVG element will create renderers even when children of HTML elements

Allow creation of svg renderers only when parent is SVG, except for
the <svg> element.

12:10 AM Changeset in webkit [23012] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Feb 27, 2007:

11:55 PM Changeset in webkit [19907] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12913
Markers do not render in webkit when it misses markerWidth or markerHeight attribute

Set defaults for markerWidth/markerHeight so markers that do not specify them render.

9:33 PM Changeset in webkit [19906] by ggaren
  • 2 edits in trunk/LayoutTests

Extending the timeout on this test to see if it fixes the buildbot failure.
(I don't get a failure locally.)

  • fast/leaks/003.html:
9:13 PM Changeset in webkit [23011] by adachan
  • 7 edits
    4 adds in branches/WindowsMerge/WebKitWin
6:04 PM Changeset in webkit [23010] by aliceli1
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Adam, Maciej, and their mothers.

This is a general leaks fix but helps the effort towards fixing
<rdar://4974495> Boomer leaks while running HTML iBench
However, this fix doens't close that bug.

  • WebFrame.cpp: (WebFrame::setTitle):

fix a leak of WebHistory

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLUnicode):

fix a leak of WebHistory

5:17 PM Changeset in webkit [23009] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [19905] by andersca
  • 2 edits in trunk/WebCore
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Remove comment.
5:15 PM Changeset in webkit [19904] by sfalken
  • 1 copy in tags/Safari-521.35.3b

New tag.

5:12 PM Changeset in webkit [23008] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Fix <rdar://problem/5004615> View source menu option is always disabled
when Netscape 8 is installed

The bug was caused by Netscape's npTrident.dll plugin, which registers
itself as a handler for text/html and text/xml.

  • WebFrame.cpp: (WebFrame::canProvideDocumentSource): Explicitly allow viewing the source of HTML and XML documents, rather than disallowing text, image, and plugin documents. Plugins can register themselves as handlers for HTML and XML MIME types, but we still want to display source in those cases.
5:08 PM Changeset in webkit [19903] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

  • editing/inserting/12882-expected.checksum: Added.
  • editing/inserting/12882-expected.png: Added.
  • editing/inserting/12882-expected.txt: Added.
  • editing/inserting/12882.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Don't attempt to merge to or from a position before or after a block because it will be a no-op and lead to infinite recursion. In this case it instead resulted in content loss because of bugs in start/endOfParagraph (5027702).
  • editing/visible_units.cpp: Added two FIXMEs for the problems with start/endOfParagraph.
4:38 PM Changeset in webkit [19902] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

Make resource load delegate methods pass the right document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): Use the resource loader's document loader instead of the active one.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Make it so we send the frame load delegate method before the resource load delegate method. This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader now works, both delegate methods will be called.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::documentLoader): Add document loader pointer to ResourceLoader.
4:26 PM Changeset in webkit [19901] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Follow-up to fixing ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com


Changed Interpreter cache of global constructors and prototypes from
ProtectedPtrs to bare, marked pointers. ProtectedPtrs are inefficient,
and they increase the risk of reference cycles. Also, Darin said something
about ProtectedPtrs giving him warts.


Also changed data members to precise types from generic JSObject*'s.


Layout tests and JS tests pass.

  • kjs/SavedBuiltins.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::initGlobalObject): Moved Identifier::init() call to constructor, for clarity. (KJS::Interpreter::mark):
  • kjs/interpreter.h:
4:21 PM Changeset in webkit [19900] by ggaren
  • 1 edit in trunk/LayoutTests/fast/leaks/003-expected.txt

Oops! Forgot to check in this file.

4:04 PM Changeset in webkit [19899] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/list-marker-expected.checksum: Added.
  • fast/repaint/list-marker-expected.png: Added.
  • fast/repaint/list-marker-expected.txt: Added.
  • fast/repaint/list-marker.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/list-marker.html

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): Add the marker to the visual overflow of all its ancestor blocks up to the list item. This needs to be done here since the marker is positioned only after those blocks have been laid out.
3:38 PM Changeset in webkit [19898] by bdash
  • 3 edits in trunk/WebKit

2007-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4985524> Problem with Blot and ToT WebKit (decoding WebCoreScrollView)

References to WebCoreScrollView as a subview of a WebHTMLView may be present in some NIB
files, so NSUnarchiver must be still able to look up the WebCoreScrollView class.

  • WebKit.exp: Export WebCoreScrollView symbol.
  • WebView/WebHTMLView.mm: Add empty WebCoreScrollView class.
3:27 PM Changeset in webkit [23007] by adachan
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Oops, ChangeLog wasn't saved last time.

3:24 PM Changeset in webkit [23006] by bdakin
  • 4 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Adam.

Make msimg32.lib available to the engine so that we can use
AlphaBlend.

  • WebKit.vcproj/WebKit.vcproj:

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4956528> Implement Pasteboard::writeImage for
Boomer context menus

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Copy a bitmap to the clipboard.
3:22 PM Changeset in webkit [23005] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <​adachan@apple.com>

Fix build.

  • WebFrame.cpp:
3:13 PM Changeset in webkit [19897] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/events/mouseout-dead-node-expected.checksum: Added.
  • fast/events/mouseout-dead-node-expected.png: Added.
  • fast/events/mouseout-dead-node-expected.txt: Added.
  • fast/events/mouseout-dead-node.html: Added.

WebCore:

Reviewed by Hyatt.



If a node dies while mouse is over it, it is still supposed to receive
mouseout event (wasn't case in Tiger webkit). However this event should
not propagate to any other nodes. This patch matches Firefox behavior in
this respect.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
3:10 PM Changeset in webkit [19896] by ggaren
  • 2 edits in trunk/LayoutTests

Bumped up the wiggle room on this test because it's failing on the buildbot.
(We're still well below the ~100 objects you would see in a real failure.)

  • fast/leaks/003.html:
3:09 PM Changeset in webkit [19895] by ggaren
  • 1 edit in trunk/LayoutTests/fast/dom/gc-10.html

Oops! Forgot to commit this file

3:03 PM Changeset in webkit [23004] by oliver
  • 4 edits in branches/WindowsMerge

2007-02-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Lou and Steve.


WebCoreWin:

Add a store for current Cursor to fix <rdar://problem/4788352>

  • platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):


WebKitWin:

<rdar://4983106> Stop/reload button never changes back to
reload when a click on a link spawns a download

  • WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
  • WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method


2:28 PM Changeset in webkit [19894] by ggaren
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Don't GC in the Interpreter destructor. For that to work, the Interpreter
would have to NULL out all of its ProtectedPtrs before calling collect(). But
we've decided that we don't want things to work that way, anyway. We want the
client to be in charge of manual GC so that it can optimize cases when
it will be destroying many interpreters at once
(e.g., ​http://bugs.webkit.org/show_bug.cgi?id=12900).


Also removed Interpreter::collect() because it was redundant with
Collector::collect().

  • JavaScriptCore.exp:
  • kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

LayoutTests:

Reviewed by Maciej Stachowiak.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com


  • fast/leaks/003-expected.txt: Added.
  • fast/leaks/003.html: Added.
  • fast/dom/gc-10.html: Bumped the wiggle room threshold on this test by 2 because it's failing on my machine with the patch applied but, according to the test notes, we're still well within the margin of error.

WebCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Garbage collect in the KJSProxy destructor, after clearing our reference
to the interpreter, because that's when the interpreter has torn down fully.

(Technically speaking, we can't *prove* that we have the only reference to
our interpreter, but that's how it works in practice, and manual garbage
collection is just an opportunistic optimization, so it's OK for it to
work in practice even if it can't be proven in theory.)


Layout tests pass. No leaks reported.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
  • bindings/js/kjs_proxy.h:
  • page/Page.cpp: (WebCore::Page::~Page): Merged pageDestroyed() calls. Moved debug-only code to the bottom.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't call getObject() because globalObject() returns a JSObject* already, and the call can leave a pointer to the Window object on the stack. Don't check for NULL because it is an invariant of JavaScriptCore that no JSObject* can be NULL. Do use a volatile pointer for w because the 'w = 0' assignment just screams to the compiler, "Don't generate any code for me!"
2:26 PM Changeset in webkit [23003] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <​adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4983106> Stop/reload button never changes back to reload when a click on a link spawns a download

WebKitWin:

  • WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
  • WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method
12:50 PM Changeset in webkit [19893] by aroben
  • 2 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/5011905> REGRESSION: "Open Link" contextual menu
item appears twice

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Remove the "Open Link" item from the default menu items array before sending it off to Tiger Mail. (WebContextMenuClient::getCustomMenuFromDefaultItems): Set the representedObject on every NSMenuItem to match our old (correct) API behavior.
12:31 PM Changeset in webkit [19892] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by David Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=4128
!important is ignored in inline styling.

Handle properties with !important flag better in inline
style declarations.

12:13 PM Changeset in webkit [19891] by hyatt
  • 2 edits in trunk/WebCore

Bug 11435. Make sure RenderViews always paintBoxDecorations. They used to before I removed RenderView's
paint method. This fix restores the original behavior.

Reviewed by mitz

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
11:51 AM Changeset in webkit [19890] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird/rare case of empty
plaintext documents (which really are buggy and should be fixed to generate root elements).

Reviewed by mitz

  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView):
10:45 AM Changeset in webkit [19889] by ap
  • 2 edits in trunk/WebCore

2007-02-27 Dex Deacon <​occupant4@gmail.com>

Reviewed by Darin.

Fixed the case where a BackForwardList of capacity==1 would grow without bound.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem):
10:10 AM Changeset in webkit [19888] by ap
  • 2 edits in trunk/WebCore

2007-02-22 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12848
Help cursor should have a white outline

  • Resources/helpCursor.png:
10:00 AM Changeset in webkit [19887] by ap
  • 2 edits in trunk/WebKit

2007-02-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scaleFactor): If the view is not in a window, use the main screen's scale factor as a best guess.
9:48 AM Changeset in webkit [19886] by ap
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12594
REGRESSION: Strange highlight in active input area

No automated test possible.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Restore a check lost in r12792.
8:18 AM Changeset in webkit [19885] by ggaren
  • 2 edits in trunk/WebKitTools

Small tweak to run-webkit-tests.

  • Scripts/run-webkit-tests: Allow people with lots of RAM to run more than 1000 MallocStackLogging tests at a time.
6:08 AM Changeset in webkit [19884] by darin
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Add null checks.
6:05 AM Changeset in webkit [19883] by darin
  • 3 edits in trunk/WebCore

Reviewed by Alexey.

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Add "macroman" as an alias for "macintosh". We have seen that in use in mail, although I'm not sure it's used on the web.
  • platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back as part of the patch for bug 4971226. But by adding it to the this file rather than the ICU codec, we get it only on Mac OS X. And long term we are trying to get rid of the use of TEC entirely, so we want this file to be as empty as possible.
6:05 AM Changeset in webkit [19882] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • test for MacRoman encoding name alias
  • fast/encoding/charset-names-expected.txt: Added.
  • fast/encoding/charset-names.html: Added.
5:02 AM Changeset in webkit [19881] by darin
  • 2 edits in trunk/LayoutTests
  • fast/css/computed-style-expected.txt: Updated test result for Hyatt's addition of -webkit-border-fit.
2:12 AM Changeset in webkit [19880] by rwlbuis
  • 7 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12905
Not all svg shapes should support markers

Restrict marker usage to svg shapes polyline, polygon, line and path.

12:44 AM Changeset in webkit [19879] by adele
  • 6 edits in trunk

LayoutTests:

Reviewed by Lars.

Updated test for ​http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

  • fast/frames/iframe-window-focus-expected.txt:
  • fast/frames/iframe-window-focus.html: Updated test to include insertion of newlines.

WebCore:

Reviewed by Lars.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

Test: fast/frames/iframe-window-focus-2.html

  • page/EventHandler.h: Make focusDocumentView public.
  • page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame, we should set also focus the document view. The bug here was that since the subframe view wasn't the first responder, the key down event was going to the wrong frame.

Feb 26, 2007:

11:54 PM Changeset in webkit [23002] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

To stop the drag image for transparent images from looking
ugly (especially fully transparent images) we render the
image to a white background prior to passing the image on to
Windows


<rdar://problem/5015946>

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageFromImage):
11:19 PM Changeset in webkit [19878] by mjs
  • 3 edits
    20 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • svg/custom/circular-marker-reference-1-expected.checksum: Added.
  • svg/custom/circular-marker-reference-1-expected.png: Added.
  • svg/custom/circular-marker-reference-1-expected.txt: Added.
  • svg/custom/circular-marker-reference-1.svg: Added.
  • svg/custom/circular-marker-reference-2-expected.checksum: Added.
  • svg/custom/circular-marker-reference-2-expected.png: Added.
  • svg/custom/circular-marker-reference-2-expected.txt: Added.
  • svg/custom/circular-marker-reference-2.svg: Added.
  • svg/custom/circular-marker-reference-3-expected.checksum: Added.
  • svg/custom/circular-marker-reference-3-expected.png: Added.
  • svg/custom/circular-marker-reference-3-expected.txt: Added.
  • svg/custom/circular-marker-reference-3.svg: Added.
  • svg/custom/circular-marker-reference-4-expected.checksum: Added.
  • svg/custom/circular-marker-reference-4-expected.png: Added.
  • svg/custom/circular-marker-reference-4-expected.txt: Added.
  • svg/custom/circular-marker-reference-4.svg: Added.
  • svg/custom/non-circular-marker-reference-expected.checksum: Added.
  • svg/custom/non-circular-marker-reference-expected.png: Added.
  • svg/custom/non-circular-marker-reference-expected.txt: Added.
  • svg/custom/non-circular-marker-reference.svg: Added.

WebCore:

Reviewed by Oliver.

  • platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against reference cycles.
9:30 PM Changeset in webkit [19877] by mjs
  • 4 edits in trunk

WebCore:

Reviewed by Kevin McCullough.

  • fix Qt build for earlier SVG changes.
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

WebKitQt:

Reviewed by Kevin McCullough.

  • fix Qt build for earlier SVG changes.
  • WebCoreSupport/EditCommandQt.cpp:
9:23 PM Changeset in webkit [19876] by oliver
  • 2 edits in trunk/WebCore

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fix for <rdar://problem/4827378>: Canvas with large height
uses lots of memory, computer almost stops responding


Put cap on maximum area of canvas, size is similar too the
maximum size allowed by firefox (firefox seems to to cut off
at area == 32767 * 9358).

Also protect renderer against the possibility of a null context
(this was triggering a CG warning)

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext):

Apply maximum canvas area

(WebCore::HTMLCanvasElement::createPlatformImage):

Protect against null CG Context

9:13 PM Changeset in webkit [19875] by bdash
  • 3 edits
    4 adds in trunk

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

Test: fast/lists/list-style-type-dynamic-change.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger updating of the marker.

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

  • fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
  • fast/lists/list-style-type-dynamic-change-expected.png: Added.
  • fast/lists/list-style-type-dynamic-change-expected.txt: Added.
  • fast/lists/list-style-type-dynamic-change.html: Added.
8:04 PM Changeset in webkit [19874] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Lars.


  • set ENABLE_XSLT even when compiling without SVG support, since that is no longer hardcoded into config.h.
  • Scripts/build-webkit:
5:56 PM Changeset in webkit [19873] by kjk
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

  • jscore.bkl:

WebKitTools:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

  • GdkLauncher/gdklauncher.bkl:
5:36 PM Changeset in webkit [19872] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

  • fast/events/submit-reset-nested-bubble-expected.txt: Added.
  • fast/events/submit-reset-nested-bubble.html: Added.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

Test: fast/events/submit-reset-nested-bubble.html

  • dom/EventTargetNode.h: Made handleLocalEvents virtual.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're not in the capture phase, and the target is a different form, and we're handling the submitEvent or the resetEvent, then stop propagation of the event. This matches Firefox behavior. You can only get in this situation if misnested tags cause forms to be nested.
  • html/HTMLFormElement.h: Added handleLocalEvents.
5:32 PM Changeset in webkit [19871] by darin
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • <rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should
  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter): Added a call to ucnv_setFallback(TRUE).
5:16 PM Changeset in webkit [19870] by oliver
  • 3 edits
    4 adds in trunk

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for rdar://problem/5021127

Need to add null check to node -- original Obj-C didn't need
the null check due to the Obj-C null messaging semantics

  • editing/Editor.cpp: (WebCore::Editor::shouldInsertFragment):

Layout tests:

Layout test for rdar://problem/5021127

  • fast/events/standalone-image-drag-to-editable-expected.checksum: Added.
  • fast/events/standalone-image-drag-to-editable-expected.png: Added.
  • fast/events/standalone-image-drag-to-editable-expected.txt: Added.
  • fast/events/standalone-image-drag-to-editable.html: Added.
4:39 PM Changeset in webkit [23001] by aroben
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adele.

  • platform/win/GraphicsContextWin.cpp: Get rid of so-five-hours-ago SVG_SUPPORT.

WebKitWin:

Reviewed by Adele.

Stop bizarre crashes from happening on startup.

  • WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
4:33 PM Changeset in webkit [19869] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin and Geoff

  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): This method was copied from WebBrowser, and it was wrong. Fixed it. This only affects the Dictionary pop-up panel.
4:09 PM Changeset in webkit [19868] by hyatt
  • 2 edits in trunk/WebCore

Make text files render using white-space: pre-wrap instead of white-space: pre.


Reviewed by aroben

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
3:53 PM Changeset in webkit [23000] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix Boomer.

3:24 PM Changeset in webkit [19867] by hyatt
  • 3 edits in trunk/LayoutTests/fast/overflow

Update expected results for overflow test.

3:22 PM Changeset in webkit [19866] by hyatt
  • 7 edits in trunk/WebCore

Back out the change to add fullyClippedContentRect. The layout test
was actually showing more correct results.

  • page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
3:14 PM Changeset in webkit [22999] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • config.h: Remove redundant #define.
  • WebCore.vcproj/WebCore.vcproj: Update to new macros.
2:55 PM Changeset in webkit [19865] by hyatt
  • 2 edits in trunk/WebKit

Update web inspector to account for border-fit.

Reviewed by darin

2:43 PM Changeset in webkit [19864] by ggaren
  • 4 edits in trunk/WebKit

Reviewed by Darin Adler.


Re-arranged things to put deprecated methods at the bottom.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
  • WebKit.xcodeproj/project.pbxproj:
2:42 PM Changeset in webkit [19863] by hyatt
  • 1 edit
    8 adds in trunk/LayoutTests

Land layout test demonstrating border-fit.

Reviewed by darin

  • fast/borders/border-fit-expected.checksum: Added.
  • fast/borders/border-fit-expected.png: Added.
  • fast/borders/border-fit-expected.txt: Added.
  • fast/borders/border-fit.html: Added.
  • fast/borders/resources/Balloon_12641896.tiff: Added.
  • fast/borders/resources/Balloon_8107502.tiff: Added.
  • fast/borders/resources/largePerson.png: Added.
2:40 PM Changeset in webkit [22998] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Ada.

  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Make #if match the header file.
2:36 PM Changeset in webkit [19862] by hyatt
  • 12 edits in trunk/WebCore

Add support for a new property called -webkit-border-fit. This property
has two values: border and lines. The "border" value means the border and
background paint normally at the border box level. The "lines" value indicates
that the border and background should shrink dynamically to snugly hug the
line boxes of normal flow descendants.

Reviewed by darin

fast/borders/border-fit.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::borderFitAdjust):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h: (WebCore::RenderBox::borderFitAdjust):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::borderFit): (WebCore::RenderStyle::setBorderFit): (WebCore::RenderStyle::initialBorderFit):
2:33 PM Changeset in webkit [22997] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Build fix.

  • WebCore.vcproj/build-generated-files.sh: Updated FEATURE_DEFINES.
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Use shiny new ENABLE(SVG).
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Ditto.
2:32 PM Changeset in webkit [19861] by mjs
  • 3 edits in trunk/WebKit

Rubber stamped by Mitz.


  • fix layout tests by fixing discrepancy in feature macros.
  • WebInspector/WebInspector.m: (-_highlightNode:):
  • WebKit.xcodeproj/project.pbxproj:
2:30 PM Changeset in webkit [19860] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Build fix.

  • rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.
1:49 PM Changeset in webkit [19859] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam.

Test for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

  • fast/forms/select-out-of-bounds-index-expected.txt: Added.
  • fast/forms/select-out-of-bounds-index.html: Added.

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

Test: fast/forms/select-out-of-bounds-index.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1. (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable. Rewrote using a simpler for-loop to prevent out-of-bounds errors.
1:11 PM Changeset in webkit [19858] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.
12:49 PM Changeset in webkit [19857] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
​http://bugs.webkit.org/show_bug.cgi?id=12831

12:49 PM Changeset in webkit [19856] by brmorris
  • 2 edits in S60/trunk/WebCore

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
​http://bugs.webkit.org/show_bug.cgi?id=12831

11:29 AM Changeset in webkit [19855] by mjs
  • 676 edits in trunk

JavaScriptCore:

Reviewed by Lars.


  • <rdar://problem/5021698> Disable experimental SVG features (12883)
  • wtf/Platform.h: Add ENABLE() macro similar to HAVE() and USE(), to allow nicer handling of optional WebKit features.

WebCore:

Reviewed by Lars.

  • fixed <rdar://problem/5021698> Disable experimental SVG features (12883)


I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
features, and used it to guard relevant tag names, elements, JS bindings and renderers.


I also converted all the existing optional feature defines to
ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
way to do it in open source projects and works with the handy new
ENABLE() macro.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.pro:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSSVGElementWrapperFactory.cpp:
  • bindings/js/JSSVGElementWrapperFactory.h:
  • bindings/js/JSSVGMatrixCustom.cpp:
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/JSSVGPathSegCustom.cpp:
  • bindings/js/JSSVGPathSegListCustom.cpp:
  • bindings/js/JSSVGPointListCustom.cpp:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _nodeWith:WebCore::]):
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMCustomXPathNSResolver.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMSVGPathSegInternal.mm:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • config.h:
  • css/CSSGrammar.y:
  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
  • css/StyleBase.h:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • css/cssstyleselector.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createElement): (WebCore::Document::implicitClose): (WebCore::Document::recalcStyleSelector): (WebCore::Document::createEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/MappedAttributeEntry.h: (WebCore::):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::end): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • ksvg2/css/SVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/events/JSSVGLazyEventListener.cpp:
  • ksvg2/events/JSSVGLazyEventListener.h:
  • ksvg2/events/SVGZoomEvent.cpp:
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/PointerEventsHitRules.cpp:
  • ksvg2/misc/PointerEventsHitRules.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/misc/SVGTimer.cpp:
  • ksvg2/misc/SVGTimer.h:
  • ksvg2/misc/TimeScheduler.cpp:
  • ksvg2/misc/TimeScheduler.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/ColorDistance.cpp:
  • ksvg2/svg/ColorDistance.h:
  • ksvg2/svg/GradientAttributes.h:
  • ksvg2/svg/LinearGradientAttributes.h:
  • ksvg2/svg/PatternAttributes.h:
  • ksvg2/svg/RadialGradientAttributes.h:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateElement.idl:
  • ksvg2/svg/SVGAnimateMotionElement.cpp:
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.idl:
  • ksvg2/svg/SVGAnimatedPathData.cpp:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.cpp:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.cpp:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.cpp:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::dispatchEvent):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstance.cpp:
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstance.idl:
  • ksvg2/svg/SVGElementInstanceList.cpp:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGElementInstanceList.idl:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGException.h:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEBlendElement.idl:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFECompositeElement.idl:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.idl:
  • ksvg2/svg/SVGFEDistantLightElement.cpp:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.idl:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFloodElement.idl:
  • ksvg2/svg/SVGFEFuncAElement.cpp:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncAElement.idl:
  • ksvg2/svg/SVGFEFuncBElement.cpp:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncBElement.idl:
  • ksvg2/svg/SVGFEFuncGElement.cpp:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncGElement.idl:
  • ksvg2/svg/SVGFEFuncRElement.cpp:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEFuncRElement.idl:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFEImageElement.idl:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeElement.idl:
  • ksvg2/svg/SVGFEMergeNodeElement.cpp:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEOffsetElement.idl:
  • ksvg2/svg/SVGFEPointLightElement.cpp:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFEPointLightElement.idl:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.idl:
  • ksvg2/svg/SVGFESpotLightElement.cpp:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFESpotLightElement.idl:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETileElement.idl:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.idl:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterElement.idl:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGForeignObjectElement.idl:
  • ksvg2/svg/SVGGElement.cpp:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGListTraits.h:
  • ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMPathElement.cpp:
  • ksvg2/svg/SVGMPathElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMetadataElement.cpp:
  • ksvg2/svg/SVGMetadataElement.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.cpp:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGParserUtilities.cpp:
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.cpp:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.cpp:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.cpp:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.cpp:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGRenderingIntent.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.cpp:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.cpp:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::notifyAttributeChange):
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.cpp:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.cpp:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.cpp:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.cpp:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.cpp:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.cpp:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformDistance.cpp:
  • ksvg2/svg/SVGTransformDistance.h:
  • ksvg2/svg/SVGTransformList.cpp:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUnitTypes.h:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGUseElement.idl:
  • ksvg2/svg/SVGViewElement.cpp:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.cpp:
  • ksvg2/svg/SVGZoomAndPan.h:
  • ksvg2/svg/svgtags.in:
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/DOMWindow.idl:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::selectCursor):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes):
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
  • platform/graphics/svg/SVGImage.cpp:
  • platform/graphics/svg/SVGImage.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:
  • platform/graphics/svg/SVGPaintServer.cpp:
  • platform/graphics/svg/SVGPaintServer.h:
  • platform/graphics/svg/SVGPaintServerGradient.cpp:
  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
  • platform/graphics/svg/SVGPaintServerLinearGradient.h:
  • platform/graphics/svg/SVGPaintServerPattern.cpp:
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
  • platform/graphics/svg/SVGPaintServerRadialGradient.h:
  • platform/graphics/svg/SVGPaintServerSolid.cpp:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/SVGResource.cpp:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceFilter.cpp:
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/SVGResourceMarker.cpp:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.cpp:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/CgSupport.cpp:
  • platform/graphics/svg/cg/CgSupport.h:
  • platform/graphics/svg/cg/RenderPathCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
  • platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
  • platform/graphics/svg/filters/SVGDistantLightSource.h:
  • platform/graphics/svg/filters/SVGFEBlend.cpp:
  • platform/graphics/svg/filters/SVGFEBlend.h:
  • platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEColorMatrix.h:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.h:
  • platform/graphics/svg/filters/SVGFEComposite.cpp:
  • platform/graphics/svg/filters/SVGFEComposite.h:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.h:
  • platform/graphics/svg/filters/SVGFEFlood.cpp:
  • platform/graphics/svg/filters/SVGFEFlood.h:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.h:
  • platform/graphics/svg/filters/SVGFEImage.cpp:
  • platform/graphics/svg/filters/SVGFEImage.h:
  • platform/graphics/svg/filters/SVGFEMerge.cpp:
  • platform/graphics/svg/filters/SVGFEMerge.h:
  • platform/graphics/svg/filters/SVGFEMorphology.cpp:
  • platform/graphics/svg/filters/SVGFEMorphology.h:
  • platform/graphics/svg/filters/SVGFEOffset.cpp:
  • platform/graphics/svg/filters/SVGFEOffset.h:
  • platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
  • platform/graphics/svg/filters/SVGFESpecularLighting.h:
  • platform/graphics/svg/filters/SVGFETile.h:
  • platform/graphics/svg/filters/SVGFETurbulence.cpp:
  • platform/graphics/svg/filters/SVGFETurbulence.h:
  • platform/graphics/svg/filters/SVGFilterEffect.cpp:
  • platform/graphics/svg/filters/SVGFilterEffect.h:
  • platform/graphics/svg/filters/SVGLightSource.cpp:
  • platform/graphics/svg/filters/SVGLightSource.h:
  • platform/graphics/svg/filters/SVGPointLightSource.h:
  • platform/graphics/svg/filters/SVGSpotLightSource.h:
  • platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
  • platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
  • platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
  • platform/graphics/svg/filters/cg/SVGFETileCg.mm:
  • platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
  • platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink):
  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp:
  • rendering/RenderPath.h:
  • rendering/RenderSVGBlock.cpp:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGGradientStop.cpp:
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.cpp:
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGTSpan.cpp:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.cpp:
  • rendering/RenderSVGText.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::inheritFrom): (WebCore::RenderStyle::operator==): (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): (WebCore::RenderText::setTextInternal):
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::shouldPreserveNewline): (WebCore::RenderBlock::findNextLineBreak):
  • webcore-base.bkl:
  • xml/NativeXPathNSResolver.cpp:
  • xml/NativeXPathNSResolver.h:
  • xml/XPathEvaluator.cpp:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.cpp:
  • xml/XPathExpression.h:
  • xml/XPathExpressionNode.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h:
  • xml/XPathGrammar.y:
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h:
  • xml/XPathNamespace.cpp:
  • xml/XPathNamespace.h:
  • xml/XPathParser.cpp:
  • xml/XPathParser.h:
  • xml/XPathPath.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp:
  • xml/XPathPredicate.h:
  • xml/XPathResult.cpp:
  • xml/XPathResult.h:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathUtil.cpp:
  • xml/XPathUtil.h:
  • xml/XPathValue.cpp:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.cpp:
  • xml/XPathVariableReference.h:
  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessor.h:
11:18 AM Changeset in webkit [19854] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

11:16 AM Changeset in webkit [19853] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

Feb 25, 2007:

9:31 PM Changeset in webkit [19852] by bdash
  • 3 edits
    4 adds in trunk

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

Test: fast/dynamic/float-withdrawal.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

  • fast/dynamic/float-withdrawal-expected.checksum: Added.
  • fast/dynamic/float-withdrawal-expected.png: Added.
  • fast/dynamic/float-withdrawal-expected.txt: Added.
  • fast/dynamic/float-withdrawal.html: Added.
7:00 PM Changeset in webkit [19851] by hyatt
  • 3 edits in trunk/WebCore

Revert my change to the default fill color. Just set the color to transparent explicitly when
drawing textarea resizer frames.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
6:28 PM Changeset in webkit [19850] by weinig
  • 2 edits in trunk/WebCore

Update forgotten files.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
6:07 PM Changeset in webkit [19849] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

Forgot to land FrameView.cpp in previous commit.

5:29 PM Changeset in webkit [19848] by hyatt
  • 5 edits in trunk/WebCore

Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
to be the initial containing block (represented in our tree by the RenderView). Rework RenderView's layout
to have very few special cases. Now it will just relayout its children when the width/height of the
view actually changes. Positioned elements no longer get a special additional layout, since width/height
adjustments are caught by the base class already anyway.

Reviewed by mjs, darin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
4:47 PM Changeset in webkit [22996] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrolView::fullyClippedContentRect):
4:41 PM Changeset in webkit [19847] by mjs
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

  • fix build breakage
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::fullyClippedContentRect):
3:44 PM Changeset in webkit [19846] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
2:23 PM Changeset in webkit [19845] by andersca
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

  • building/checkout.html: Add Trac link to our SVN repository,

Feb 24, 2007:

11:20 PM Changeset in webkit [22995] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Change #if to #ifdef to match style.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
11:14 PM Changeset in webkit [22994] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix <rdar://problem/5013502> REGRESSION: <select> menus are not
animating smoothly

This was caused by making the menus partially transparent in r12250.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Disable animations.
11:12 PM Changeset in webkit [19844] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Steve.

"Look Up in Dictionary" context menu item should be Mac-only for now,
since it's only implemented on that platform (<rdar://problem/5021468>)

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Wrap all instances of the dictionary menu item in #if PLATFORM(MAC).
8:35 PM Changeset in webkit [22993] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-24 Steve Falkenburg <​sfalken@apple.com>

Pre-emptive build fix.
Removed CGPThreads DLL copy

  • WebKit.vcproj/WebKit.vcproj:
6:14 PM Changeset in webkit [19843] by ggaren
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin Adler.


Layout tests for BidiRun leaks.


  • fast/leaks/001-expected.txt: Added.
  • fast/leaks/001.html: Added.
  • fast/leaks/002-expected.txt: Added.
  • fast/leaks/002.html: Added.

WebCore:

Reviewed by Darin Adler.


Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
running WebKit unit tests


In bidi.cpp, some functions allocate BidiRuns and put them in a global data
structure, while others uses the BidiRuns in the global data structure.
The caller is responsible for knowing which functions may allocate runs
and which may use them, and calling deleteBidiRuns() at the appropriate time.

The fix is to add some calls to deleteBidiRuns() where they were missing.


I also added a BidiRun counter because these two leaks were introduced by
our two bidi.cpp experts, so the odds that leaks will creep in again
in the future seem pretty high.

  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added missing call to deleteBidiRuns(). (WebCore::BidiRunCounter::~BidiRunCounter): (WebCore::BidiRun::operator delete): (WebCore::RenderBlock::layoutInlineChildren): Added missing call to deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to bidiReorderLine(), to emphasize that they go together like new/delete. In theory, the old code was just as good, but I didn't want to rely on theory.

WebKitTools:

Reviewed by Darin Adler.


  • Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're fixed.
6:35 AM Changeset in webkit [19842] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4961431> Image with empty string alt tag should be ignored

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Ignore img element that has an alt attribute, but that string is empty.
5:14 AM Changeset in webkit [19841] by zack
  • 2 edits in trunk/WebKitQt

Adjust the animation a little bit to make it more natural.

3:14 AM Changeset in webkit [19840] by ap
  • 4 edits in trunk/LayoutTests

Reviewed by Anders.

Fix the test not to include any custom content in its auto-generated HTML wrapper.

  • fast/js/resources/select-options-add.js:
  • fast/js/select-options-add-expected.txt:
  • fast/js/select-options-add.html:
12:45 AM Changeset in webkit [19839] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Gdk improvements.

  • platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup. (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
  • platform/network/gdk/ResourceHandleManager.cpp: don't free memory that doesn't belong to us. (WebCore::ResourceHandleManager::downloadTimerCallback):

WebKitTools:

Reviewed by Adam Roben.

Improve gdklauncher: add text field for entering url.

  • GdkLauncher/gdklauncher.bkl:
  • GdkLauncher/main.cpp: (strEmpty): (strEq): (handleGdkEvent): (goToUrlBarText): (goButtonClickedCb): (urlBarEnterCb): (registerRenderingAreaEvents): (frameResizeCb): (frameDestroyCb): (main):

Feb 23, 2007:

11:42 PM Changeset in webkit [19838] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)


There were two problems here:


  • page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
  • platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.
8:35 PM Changeset in webkit [22992] by andersca
  • 2 adds in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.


Make boomer-run-webkit-tests work with our internal setup.


  • Scripts/boomer-run-webkit-tests:
6:55 PM Changeset in webkit [19837] by weinig
  • 4 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.
6:52 PM Changeset in webkit [19836] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):
6:35 PM Changeset in webkit [19835] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/selectstart-during-autoscroll-expected.txt: Added.
  • fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/selectstart-during-autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.
6:22 PM Changeset in webkit [19834] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):
6:21 PM Changeset in webkit [22991] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.


If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

  • plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):
5:25 PM Changeset in webkit [19833] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Correcting ChangeLog

5:22 PM Changeset in webkit [19832] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/directory-drop-on-view.html: Added.
  • platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):
2:35 PM Changeset in webkit [19831] by brmorris
  • 2 edits in S60/trunk/WebKit

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 AM Changeset in webkit [19830] by thatcher
  • 5 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

  • WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins
8:43 AM Changeset in webkit [19829] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Added missing bug numbers.

8:32 AM Changeset in webkit [19828] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • 12.5% speedup on BenchJS test 6


It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.
8:25 AM Changeset in webkit [19827] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • 2% speedup on BenchJS test 6
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Use format() instead of number() followed by append of a constant string.
7:34 AM Changeset in webkit [19826] by staikos
  • 2 edits in trunk/JavaScriptCore

add return values (!!)

7:26 AM Changeset in webkit [19825] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt build.

7:08 AM Changeset in webkit [19824] by zack
  • 2 edits in trunk/WebKitQt

Adding a little bit of eye-candy to the last
commit (animations on hover events)

6:21 AM Changeset in webkit [19823] by zack
  • 7 edits in trunk/WebKitQt

Adding API and code for notification of when the
mouse is hovering over a link and adding code to
the sample app to showcase it.
r=Lars

Feb 22, 2007:

10:54 PM Changeset in webkit [22990] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

rs = adam


Replacing radar numbers from previous patch with one
the isn't fictitious <rdar://problem/5018591>

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor):
10:48 PM Changeset in webkit [19822] by kjk
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben, who never sleeps.

To avoid code duplication, move notImplementedGdk() macro to a separate
header file. Remove existing notImplementedGdk() macros and replace
remaining notImplemented() to notImplementedGdk() in gdk code.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView):
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp:
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp:
  • platform/gdk/NotImplementedGdk.h: Added.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
10:30 PM Changeset in webkit [22989] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Implemented a couple more cursor methods

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): Added radar bug reference <rdar://problem/5018452> (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): Making them return the correct cursor


8:32 PM Changeset in webkit [19821] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12852
Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up

  • Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.
7:48 PM Changeset in webkit [19820] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/remove-event-listener-expected.txt: Added.
  • fast/events/remove-event-listener.html: Added.

WebCore:

Reviewed by Maciej.

and

Problem: RemoveEventListener leaks memory if the listener is not
registered.
Fix: Added Window::findJSEventListener function w/o creating a
JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;

As an enhancement, added a leak counter for EventListeners.

Added a test case, LayoutTests/fast/events/remove-event-listener.html.

  • WebCore/bindings/js/kjs_dom.cpp:
  • WebCore/bindings/js/kjs_window.h:
  • WebCore/bindings/js/kjs_window.cpp:
  • WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
  • WebCore/bindings/js/JSXMLHttpRequest.cpp:
  • LayoutTests/fast/events/remove-event-listener.html:
7:38 PM Changeset in webkit [19819] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4998203>
REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.


(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
Check if the unreachable URL is equal to the document loader's request.


(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Check the provisional document loader's unreachable URL.

6:47 PM Changeset in webkit [22988] by oliver
  • 5 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Removing accessive COMPtr use from ClipboardWin constructors
Adding data verification to ClipoardWin::SetData
Small amount code tidying, and allowing for failure when writing an URL

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Updated for new ClipboardWin constructor
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::writeURL): (WebCore::ClipboardWin::getData): Tidying code, and allowing failure (WebCore::ClipboardWin::setData): Verifying that we're writing a valid url


  • platform/win/ClipboardWin.h:
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
5:13 PM Changeset in webkit [19818] by bdash
  • 4 edits in trunk

Versioning.

4:35 PM Changeset in webkit [19817] by bdash
  • 4 edits in tags/Safari-5522

Versioning.

4:32 PM Changeset in webkit [19816] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19806.

2007-02-22 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
4:29 PM Changeset in webkit [19815] by bdash
  • 3 edits in tags/Safari-5522/JavaScriptGlue

Merge in r19805.

2007-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
4:26 PM Changeset in webkit [19814] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19783.

2007-02-21 Brady Eidson <​beidson@apple.com>

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
4:21 PM Changeset in webkit [19813] by bdash
  • 1 copy in tags/Safari-5522

New tag.

4:12 PM Changeset in webkit [22987] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Updating this file to match WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
4:03 PM Changeset in webkit [19812] by adele
  • 3 edits in trunk/WebKit

Reviewed by John.

Updating this image to match the one in WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
3:59 PM Changeset in webkit [22986] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView.cpp: (WebView::handleContextMenuEvent): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:51 PM Changeset in webkit [19811] by justing
  • 19 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

Added, tests the removal of the use of the
recalc bool from xPosForVerticalArrowNavigation(...):

  • editing/selection/5007143-2-expected.checksum: Added.
  • editing/selection/5007143-2-expected.png: Added.
  • editing/selection/5007143-2-expected.txt: Added.
  • editing/selection/5007143-2.html: Added. Added, demonstrate the changes to modify:
  • editing/selection/5007143-expected.checksum: Added.
  • editing/selection/5007143-expected.png: Added.
  • editing/selection/5007143-expected.txt: Added.
  • editing/selection/5007143.html: Added. Demonstrates a bug (filed 5017312):
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt: Fixed:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-011-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize m_xPosForVerticalArrowNavigation. (WebCore::SelectionController::setSelection): Call the new setter. (WebCore::SelectionController::modifyMovingRightForward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. Use the x position of the *start*, not the end of the selection if there is no saved xPosForVerticalArrowNavigation. This matches TextEdit's behavior. (WebCore::SelectionController::modifyMovingLeftBackward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation for line and paragraph granularities. (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed the recalc bool because it is now always false. (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
  • editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation from Frame.
  • page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
  • page/Frame.h: Ditto.
  • page/FramePrivate.h: Ditto.
3:49 PM Changeset in webkit [19810] by bdakin
  • 6 edits
    1 add in trunk

WebCore:

Reviewed by Adam. Manual test added.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

This problem appeared because of two facets of the current context
menu design. First, all context menu events are now considered to
be "swallowed" since we take care of building up the regular
context menu through the defaultEventHandler(). Second, the context
menu controller holds onto it's context menu until a new one is
created. There would be logistical problems changing this since
AppKit relies on the menu being around for as long as it is
visible on the screen and we don't get any notification once the
menu is popped-down.

This patch fixes the problem by giving WebKit a way to clear the
controller's context menu. WebKit now clears the menu before it
propagates a new context menu event through the DOM.

  • WebCore.exp:
  • manual-tests/DOMContextMenuEvent.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::clearContextMenu):
  • page/ContextMenuController.h:

WebKit:

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:44 PM Changeset in webkit [22985] by oliver
  • 15 edits
    1 move
    4 adds in branches/WindowsMerge

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou, and Steve.

WebKit:

Last of the major changes for drag and drop

  • Move COMPtr.h to WebCore
  • Added WebDragSource, a modified version of SDataSource from the App that can notify a WebView's eventhandler of drag events
  • Implement the last bits of the DragClient
  • As part of drag client added code to draw the "doubled" text used by drag links. May be useful for other parts of WebKit/App


  • COMPtr.h: Removed. Moving to WebCore
  • WebDragClient.cpp: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::dragSourceActionMaskForPoint): (WebDragClient::willPerformDragSourceAction):
Removing WebCore
as i'm now using the WebCore namespace (WebDragClient::startDrag): Implemented client method (allocImage): (dragLabelFont): Helper functions for generating the link dragging image (WebDragClient::createDragImageForLink): Implemented client method
  • WebDropSource.cpp: Added. (WebDropSource::createInstance): (WebDropSource::WebDropSource): (WebDropSource::QueryInterface): (WebDropSource::AddRef): (WebDropSource::Release): (generateMouseEvent): Generates a mouse event for the EventHandler (WebDropSource::QueryContinueDrag): (WebDropSource::GiveFeedback): Copied from SDataObject in the App. Minor changes per suggestions from Ada and Steve (error codes, potential leaks) Also includes logic to notify the source WebView of drag events (moving and drag end)
  • WebDropSource.h: Added. Header for the above
  • WebKit.vcproj/WebKit.vcproj: Removing COMPtr.h, and adding WebDropSource.{h,cpp}
  • WebKitGraphics.cpp: (DrawDoubledTextAtPoint): Utility function for drawing double text, as used by link dragging image
This resolves <rdar://problem/4821407> Cannot drag link to bookmarks bar to create new link <rdar://problem/4869496> User Interaction Essentials: Drag
  • WebCore.vcproj/WebCore.vcproj: Adding new files


  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize): Maximum size of drag image to allow sharp edges is 208x208


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Properly implemented now


  • platform/win/ClipboardWin.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::~ClipboardWin): (WebCore::writeURL): Helper function to write a url to a WCDataObject (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::addMimeTypesForFormat): Helper function for ClipboardWin::types (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::setDragImageElement): General setters, match behaviour of WebKit/Mac (WebCore::ClipboardWin::createDragImage): Creates a drag image for a DOM specified Image is specified can't currently generate an image for an arbitrary element (WebCore::imageToMarkup): Wraps a url in an img tag (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Implement Clipboard required by DragController. Provides read/write DOM Clipboard implementation for dragging, read only when accessing system clipboard.


  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::dataObject): Provide an accessor for the dataObject


  • platform/win/DragDataWin.cpp: (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::DragData::asURL): (WebCore::getPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment): Refactoring and removing of a few static modifiers to allow sharing with Clipboard


  • platform/win/DragImageWin.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::allocImage): (WebCore::createCgContextFromBitmap): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Implement DragImage functions


  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Creating a Clipboard that wraps the system clipboard


  • platform/win/PasteboardWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNBSP): removing 'static'


  • platform/win/WCDataObject.cpp: Added. (WebCore::WCEnumFormatEtc::WCEnumFormatEtc): (WebCore::WCEnumFormatEtc::QueryInterface): (WebCore::WCEnumFormatEtc::AddRef): (WebCore::WCEnumFormatEtc::Release): (WebCore::WCEnumFormatEtc::Next): (WebCore::WCEnumFormatEtc::Skip): (WebCore::WCEnumFormatEtc::Reset): (WebCore::WCEnumFormatEtc::Clone): (WebCore::WCDataObject::createInstance): (WebCore::WCDataObject::WCDataObject): (WebCore::WCDataObject::~WCDataObject): (WebCore::WCDataObject::QueryInterface): (WebCore::WCDataObject::AddRef): (WebCore::WCDataObject::Release): (WebCore::WCDataObject::GetData): (WebCore::WCDataObject::GetDataHere): (WebCore::WCDataObject::QueryGetData): (WebCore::WCDataObject::GetCanonicalFormatEtc): (WebCore::WCDataObject::SetData): (WebCore::WCDataObject::CopyMedium): (WebCore::WCDataObject::EnumFormatEtc): (WebCore::WCDataObject::DAdvise): (WebCore::WCDataObject::DUnadvise): (WebCore::WCDataObject::EnumDAdvise): (WebCore::WCDataObject::clearData): Copied from SDataObject in the App createInstance and clearData are the only new functions. clearData removes any entries in the object with a specified CLIPFORMAT. Have also made a few error and memory handling changes suggested by Steve and Ada
  • platform/win/WCDataObject.h: Added. Header for the above


3:42 PM Changeset in webkit [19809] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin and Adele


  • fixed <rdar://problem/4129417> Need final art for textarea's resize corner


This probably broke some layout pixel tests since the image changed. I'm going to
track those down in a moment (non-trivial since there are a bunch failing for other
reasons).

  • Resources/textAreaResizeCorner.tiff: new art
  • Resources/deleteButton.tiff:
  • Resources/deleteButtonPressed.tiff: these got smaller when I ran compress-tiffs on this directory
3:40 PM Changeset in webkit [19808] by oliver
  • 7 edits in trunk/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou and Steve.

Moving basic components of ClipboardMac to Clipboard,
last of the basic common code merge will come later (namely setting the
drag element/image).


Tidying up in DragController including a few bad PassRefPtr uses and
removing unnecessary accessors. Also initialise fields properly to
fix <rdar:/problems/5014889>

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): New constructor


  • dom/Clipboard.h: (WebCore::Clipboard::isForDragging): (WebCore::Clipboard::dragLocation): (WebCore::Clipboard::dragImage): (WebCore::Clipboard::dragImageElement): Exposing common data


  • page/DragController.cpp: (WebCore::DragController::DragController): Initialise m_isHandlingDrag (oops) (WebCore::documentFragmentFromDragData): (WebCore::DragController::tryDocumentDrag): Fixing PassRefPtr misuse (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doSystemDrag): Make sure we're using the correct coordinate space


  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Reset drag source correctly


  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): update constructor to use new Clipboard constructor
3:07 PM Changeset in webkit [22984] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Make sure we always paint the right size search results icon.

3:02 PM Changeset in webkit [22983] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:00 PM Changeset in webkit [19807] by sfalken
  • 1 copy in tags/Safari-521.35.2b

New tag.

2:20 PM Changeset in webkit [19806] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • fast/events/keypress-insert-tab-expected.txt: Added.
  • fast/events/keypress-insert-tab.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

Reviewed by Darin.

Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2:10 PM Changeset in webkit [19805] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
1:55 PM Changeset in webkit [19804] by brmorris
  • 4 edits in S60/trunk/WebKit

naguo, reviewed by sachin

DESC: Open while downloading UI setting functionality is not working correctly SCHY-6YFQ66
​http://bugs.webkit.org/show_bug.cgi?id=12846

1:25 PM Changeset in webkit [19803] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan, merged by mbradley++

DESC: merge of r19802 to s60 trunk. Cache memory collector is not initialized in 3.2 HZHO-6YMQCK
Fix: Initialize the initial size of cache memory collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:22 PM Changeset in webkit [19802] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

hongzhao, Reviewed by Zalan

DESC: [S60] Cache memory collector is not initialized in 3.1m HZHO-6YMQCK
Fix: Initialze the initial size of cache mem collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:16 PM Changeset in webkit [19801] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen by yongjun

DESC: Merge of r19655 to s60/3.1m. Selection list not shown correctly in www.elisa.fi HMNN-6XQJMX
​http://bugs.webkit.org/show_bug.cgi?id=12719

1:00 PM Changeset in webkit [19800] by thatcher
  • 8 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

  • bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
  • bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
  • dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
  • html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
12:50 PM Changeset in webkit [19799] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
12:19 PM Changeset in webkit [19798] by ggaren
  • 87 edits in trunk

LayoutTests:

Used svn merge -r19786:19785 to roll out previous SVG results produced by
hack to work around SVG painting issue in DRT.


The new work-around preserves the old SVG results -- both text and pixel.
This should fix the ~400 new pixel failures introduced in r19786.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Used svn merge -r19786:19785 to roll out previous hack to work around
SVG painting issue in DRT.


Implemented new work-around, which makes --paint paint *after* dumping
the render tree instead of before, so that painting doesn't influence
the SVG render tree.

This should fix the ~400 new pixel failures introduced in r19786.

  • DumpRenderTree/DumpRenderTree.m: (dump):
  • Scripts/run-webkit-tests:
11:57 AM Changeset in webkit [19797] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/forms/select-initial-position-expected.checksum: Added.
  • fast/forms/select-initial-position-expected.png: Added.
  • fast/forms/select-initial-position-expected.txt: Added.
  • fast/forms/select-initial-position.html: Added.

WebCore:

Reviewed by Darin.


Initiate scroll when selected <option> is added to <select>.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::scrollToSelection):
  • html/HTMLSelectElement.h:
11:32 AM Changeset in webkit [19796] by zack
  • 2 edits in trunk/WebCore

Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

11:18 AM Changeset in webkit [19795] by ggaren
  • 2 edits in trunk/WebKitTools

Resetting --leaks mode default to run 1000 tests at a time because setting it
to 750 didn't stop the stack logging related crashes, and running more tests
at a time is faster. The crashes seem to be a real bug in stack logging,
not an out of memory condition.

  • Scripts/run-webkit-tests:
9:38 AM Changeset in webkit [19794] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


Removed some unused keyView-related code that I happened to run across.
Replacement code is now in WebChromeClient.

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: removed unused stuff
8:52 AM Changeset in webkit [19793] by zack
  • 4 edits in trunk/WebKitQt

Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

8:17 AM Changeset in webkit [19792] by zack
  • 9 edits
    2 deletes in trunk

Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

7:59 AM Changeset in webkit [19791] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix ARM-specific alignment problem in FastMalloc
​http://bugs.webkit.org/show_bug.cgi?id=12841

  • wtf/FastMalloc.cpp: Modify how pageheap_memory is declared to ensure proper alignment on architectures such as ARM
7:45 AM Changeset in webkit [19790] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

This patch also fixes a bug where using the arrow keys while
the suggestion popup is open moves the caret instead of changing the
selection in the popup (for up/down) or accepting the selection and
closing the popup (for left/right).

  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open before the current event, so that the Option-Esc that opens the popup will not close it immediately. (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a chance to intercept keydown events. (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the suggestion popup is open.
7:34 AM Changeset in webkit [19789] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Mark (age 21).

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow SPI that forces the scroll bar to look active. Also replaced a call to the deprecated NSTableView method setAutoresizesAllColumnsToFit: with the new method setColumnAutoresizingStyle: to eliminate console spew.

Feb 21, 2007:

11:20 PM Changeset in webkit [19788] by kjk
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
give it a unique name (so that it doesn't clash with notImplemented()
for other platforms).
Make it print a given warning only once, so that frequently called
functions don't clutter the output.
Don't print the warning if DISABLE_NI_WARNING env variable is set.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::focusPolicy): (Widget::enableFlushDrawing): (Widget::disableFlushDrawing): (Widget::lockDrawingFocus): (Widget::unlockDrawingFocus): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
10:40 PM Changeset in webkit [19787] by staikos
  • 2 adds in trunk/WebKitQt/WebCoreSupport

Add missing files from last commit

10:17 PM Changeset in webkit [19786] by ggaren
  • 86 edits in trunk

LayoutTests:

Reviewed by Adam Roben.


Updated results to new, more correct values produced by painting SVGs
before dumping their render trees.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Reviewed by Adam Roben.


Added hack to force painting when running an SVG test. This is a work-around
for ​http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
paint time instead of style resolution time.

We need this so that --leaks mode, which always paints, doesn't appear to
fail SVG tests. We also need this if we ever want to test style application
in SVG, since many SVGs don't apply style to their renderers until they paint.

  • Scripts/run-webkit-tests:
8:31 PM Changeset in webkit [22982] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix

7:31 PM Changeset in webkit [22981] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders' rubberstamp


  • WebDownload.cpp: (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate so it doesn't affect the original
7:12 PM Changeset in webkit [19785] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12820
REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

add test for caret before <select> case too

  • editing/selection/caret-before-select-expected.checksum: Added.
  • editing/selection/caret-before-select-expected.png: Added.
  • editing/selection/caret-before-select-expected.txt: Added.
  • editing/selection/caret-before-select.html: Added.

WebCore:

Reviewed by Hyatt.

Yet another attempt to figure out exactly who should paint the caret.

  • editing/SelectionController.cpp: (WebCore::SelectionController::isInsideNode):
  • editing/SelectionController.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
7:07 PM Changeset in webkit [22980] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://problem/4964763> - Hookup resume downloads on the engine side


NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires
a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later


  • WebDownload.cpp: (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks (WebDownload::initToResumeWithBundle): Added a real implementation - this now works! (WebDownload::didFinish): Added some logging and fixed up some lifetime issues (extractResumeDataFromBundle): Renamed to imply the modification of the file. Truncate the resume data from the file once it is extracted
6:58 PM Changeset in webkit [19784] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
  • fast/dynamic/staticY-marking-parents-regression.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dynamic/staticY-marking-parents-regression.html

Changed calls to setChildNeedsLayout(true) during layout to
setChildNeedsLayout(true, false). Prior to r19148, the default behavior
of marking containers did not matter because the caller was the container
and was already marked, but r19148 added marking of the parent of
objects with static Y, which can be different from the caller and not
necessarily marked already.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticY):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
6:54 PM Changeset in webkit [19783] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
5:14 PM Changeset in webkit [19782] by thatcher
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin.

  • bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public. Also adds the deprecated selector for getComputedStyle: on DOMDocument.
4:30 PM Changeset in webkit [19781] by andersca
  • 3 edits in trunk/WebKitLibraries

Add new version with WKCGContextIsBitmapContext.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:10 PM Changeset in webkit [19780] by justing
  • 11 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

No new layout tests needed because the new results
for these tests and the removed FIXMEs cover the bug fix:

  • editing/execCommand/indent-list-item.html:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/remove-list-1.html:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:

WebCore:

Reviewed by john


<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

Selection preservation during indent, outdent and list
operations uses rangeFromLocationAndLength. Ranges returned
by rangeFromLocationAndLength were incorrect for locations
just before the line breaks that are emitted after blocks.
This is because TextIterator emitted bad ranges for these line
breaks (ranges that started and ended *after* the block).
The fix corrects the start but not the end. This is acceptible
because there is code in rangeFromLocationAndLength that corrects
the ends of runs using the start of the run and VisiblePosition
creation.


  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Emit a position *inside* the block, after its contents.
2:56 PM Changeset in webkit [19779] by ggaren
  • 2 edits in trunk/WebKitTools

Reduced --leaks mode to running only 750 tests at a time, in the hopes
of fixing intermittent crasher that may be caused by out of memory
conditions.

  • Scripts/run-webkit-tests:
2:32 PM Changeset in webkit [19778] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Made DRT paint when running run-webkit-tests in --leaks mode, to check
for painting leaks.

  • DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since that's the default for statics. (dumpRenderTree): Added --paint command line option, which specifies that DRT should paint at the end of every test. (displayWebView): New function, called by dump() and -[LayoutTestController display].
  • Scripts/run-webkit-tests: Use the --paint command line option when checking for leaks.
  • Scripts/run-webkit-tests: Added a new, painting leak to the ignore list. Removed stale comment about THRD leaks -- we now ignore them reliably.
2:06 PM Changeset in webkit [22979] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Updated for SafariTheme changes.

1:52 PM Changeset in webkit [22978] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj: Added JSHTMLSelectElementCustom.h
1:49 PM Changeset in webkit [19777] by adele
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

  • fast/forms/select-index-setter-expected.txt: Added.
  • fast/forms/select-index-setter.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

Test: fast/forms/select-index-setter.html

Added indexSetter for HTMLSelectElement.

  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Moved code to selectIndexSetter so it can be shared between these classes.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::selectIndexSetter): Added. Moved from JSHTMLOptionsCollection::indexSetter. (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
  • bindings/js/JSHTMLSelectElementCustom.h: Added.
  • html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.
  • bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first, and then call the version of lookupPut that will also try to use the parent's lookup table. This matches the order of our old code, before we autogenerated the JSHTMLSelectElement class.
12:48 PM Changeset in webkit [19776] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


  • Scripts/parse-malloc-history: Enabled multiple merge-regexp command line arguments. Changed command line argument variables from special implicit no-op values to specific empty values that we test explicitly.
12:00 PM Changeset in webkit [19775] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 12834: Drosera should remember scroll position of open files like Xcode
​http://bugs.webkit.org/show_bug.cgi?id=12834

  • Drosera/debugger.js: Implemented scrolling memory
10:55 AM Changeset in webkit [19774] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

brmorris, reviewed by Sachin.

DESC: r19404 caused some regresion, so I'm reverting it. TMCN-6XYSLY
This was a fix for Enhanced Input feature not working in 3.1
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:55 AM Changeset in webkit [19773] by staikos
  • 8 edits in trunk

Add undo/redo support and more editing commands.

5:59 AM Changeset in webkit [19772] by zack
  • 6 edits
    2 adds in trunk/WebCore

Implementing popups for the Qt platform.
r=Lars

4:00 AM Changeset in webkit [19771] by staikos
  • 2 edits in trunk/WebCore

Remove unneeded hack

3:18 AM Changeset in webkit [19770] by zack
  • 2 edits in trunk/WebCore

Fix rendering of lineedits and remove the spurious
padding on push-buttons.
r=Lars

1:13 AM Changeset in webkit [19769] by zack
  • 5 edits in trunk

fixing compilation with Qt

Feb 20, 2007:

11:30 PM Changeset in webkit [19768] by aroben
  • 2 edits in trunk/WebCore

Preemptive build fix.

  • platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
10:20 PM Changeset in webkit [19767] by bdash
  • 4 edits in tags/Safari-421.35

Versioning.

10:11 PM Changeset in webkit [19766] by bdash
  • 1 copy in tags/Safari-421.35

New tag.

10:04 PM Changeset in webkit [22977] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

Some changes needed to match moving writeImage() to the Pasteboard
on the Mac.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeURL): Now takes a bool indicating if the url if for an image. (WebCore::Pasteboard::writeImage): This is just a stub for now. I am putting it here instead of on TemporaryLinkStubs because I plan on implementing it very soon.

WebKitWin:

Reviewed by Maciej.

Move copyImage functionality from the ContextMenuClient to the
Pasteboard.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/PasteboardWin.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

10:02 PM Changeset in webkit [19765] by aroben
  • 2 edits in trunk/WebCore

Fix the build the right way.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Keep all widths as floats.
10:00 PM Changeset in webkit [19764] by bdakin
  • 26 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Implement writeImage() on Pasteboard so that the context menus can
call into the editor for the "Copy image" command instead of
calling across the clients.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::copyImage): Call into the Pasteboard.
  • editing/Editor.h:
  • loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside WebCore.
  • loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ (from Objective-C) since the call into the MIMETypeRegistry will return a Vector. (urlByRemovingComponent): Cast to build as Obj-C++ (urlWithDataRelativeToURL): Same. (vectorContainsString): Helper. (suggestedFilenameWithMIMEType): New function.
  • page/ContextMenuClient.h: Remove copyImageToClipboard()
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the editor instead of the client.
  • page/mac/WebCoreViewFactory.h: New localized String.
  • platform/LocalizedStrings.h: Same.
  • platform/MimeTypeRegistry.h: Expose two additional functions for MIMEType information from WebCore System Interface.
  • platform/Pasteboard.h:
  • platform/SharedBuffer.h: Make platformData() and platformDataSize () public since they are needed to write the image to the pasteboard.
  • platform/mac/LocalizedStringsMac.mm: New localized string. (WebCore::copyImageUnknownFileLabel):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getExtensionsForMIMEType): (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForImage): (WebCore::Pasteboard::writeURL): Write the correct types if the url is for an image. (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage):
  • platform/mac/WebCoreNSStringExtras.h: Added. Some the the NSStringExtras that were in WebKit are now needed by WebCore. To avoid having two copies of these functions, I just moved the implementations to WebCore. The WebKit functions just call into WebCore.
  • platform/mac/WebCoreNSStringExtras.mm: Added. (hasCaseInsensitiveSuffix): (hasCaseInsensitiveSubstring): (filenameByFixingIllegalCharacters):
  • platform/mac/WebCoreSystemInterface.h: wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType are now needed in WebCore as well as WebKit.
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Maciej.

WebKit changes needed to implement writeImage() in WebCore's
Pasteboard class.

  • Misc/WebKitNSStringExtras.m: Call into WebCore for these implementations. (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
  • Misc/WebNSURLExtras.m: Same. (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • WebCoreSupport/WebContextMenuClient.h: Remove copyImageToClipboard()
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebSystemInterface.m: Expose GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to WebCore. (InitWebCoreSystemInterface):
  • WebCoreSupport/WebViewFactory.mm: New localized string for WebCore. (-[WebViewFactory copyImageUnknownFileLabel]):
9:16 PM Changeset in webkit [19763] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Added explicit casts.
9:06 PM Changeset in webkit [22976] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin and Anders.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): Added truncation.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
  • platform/win/WebCoreTextRenderer.h: Ditto.

WebKitWin:

Reviewed by Darin and Anders.

9:03 PM Changeset in webkit [19762] by aroben
  • 10 edits
    2 moves in trunk

WebCore:

Reviewed by Darin and Anders.

Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Updated file names.
  • bridge/mac/WebCoreStringTruncator.h: Removed.
  • bridge/mac/WebCoreStringTruncator.mm: Removed.
  • platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm. (WebCore::textBreakAtOrPreceding): Added. (WebCore::boundedTextBreakFollowing): Added. (WebCore::centerTruncateToBuffer): (WebCore::rightTruncateToBuffer): (WebCore::stringWidth): Now takes a const Font& instead of a Font*. (WebCore::truncateString): (WebCore::StringTruncator::centerTruncate): (WebCore::StringTruncator::rightTruncate): (WebCore::StringTruncator::width):
  • platform/StringTruncator.h: Added.
  • platform/TextBreakIterator.h: Added isTextBreak declaration.
  • platform/TextBreakIteratorICU.cpp: (WebCore::isTextBreak): Implemented.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::isTextBreak): Stubbed out.

WebKit:

Reviewed by Darin and Anders.

Update WebKit for WebCore fix for <rdar://problem/4736215> Make
WebCoreStringTruncator use WebCore types.

  • Misc/WebStringTruncator.m: (defaultMenuFont): Moved from WebCoreStringTruncator.mm. (core): Added. (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.
7:58 PM Changeset in webkit [19761] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

  • editing/pasteboard/5006779-expected.checksum: Added.
  • editing/pasteboard/5006779-expected.png: Added.
  • editing/pasteboard/5006779-expected.txt: Added.
  • editing/pasteboard/5006779.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text


We decided to change the copy/paste behavior in both
the Paste and the Paste and Match Style cases.

  • editing/markup.cpp: (WebCore::createMarkup): Don't add mail blockquote wrappers unless the user selected one or more paragraphs.
5:48 PM Changeset in webkit [19760] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4912899> WebCore project ObjC @property cleanup

  • bindings/objc/DOMObject.h: Add the new style @property
  • bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
  • bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
5:39 PM Changeset in webkit [19759] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Fixes the build!

4:54 PM Changeset in webkit [19758] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Build fix for the no-SVG build.

4:48 PM Changeset in webkit [19757] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

Better build fix, rolling out part of r19579.

4:40 PM Changeset in webkit [19756] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

4:36 PM Changeset in webkit [19755] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


Made parse-malloc-history executable. (Oops!)


Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
output.


Added the ability to merge callstacks by regexp, not just depth, so you
can ask questions like, "How many of these allocations were due to that one
call to ...?"


  • Scripts/parse-malloc-history:
4:12 PM Changeset in webkit [19754] by staikos
  • 2 edits in trunk/WebKitQt

Fix compile

4:07 PM Changeset in webkit [19753] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

<rdar://problem/5007248> need to export symbols for DOM exception constants

  • WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException
3:56 PM Changeset in webkit [19752] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

Fixes the version number returned when using a CFBundleVersion of "420+".

  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): Check the length up to the first non-decimal digit, so this works with versions that have "." and "+".
3:38 PM Changeset in webkit [19751] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4989344> REGRESSION: After clicking on page, Find won't find anything if all hits are before the clicked point


This was caused by a mismatch between WebCore's search code's notion of "selection" and
WebView's search code's notion of "selection". WebCore's search code was starting
just before or just after the "selection", which included collapsed, zero-length
selections. WebKit's search code was only considering non-zero-length selections,
and would not search all of the content when there was a zero-length selection.
The fix was to make WebKit ignore the selection. This has a side effect of increasing
the amount of redundantly-searched content in the case where no matches are found. To
compensate for that, I special-cased the most common case of WebViews with a single frame,
to avoid ever searching redundantly in those.

  • WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): remove startHasSelection ivar; special-case WebViews with only one frame; clarify the code that leads to redundant searching with comments.
3:26 PM Changeset in webkit [19750] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Build fix.

3:26 PM Changeset in webkit [19749] by ggaren
  • 2 edits in trunk/WebKitTools
  • Scripts/parse-malloc-history: Added copyright info.
2:57 PM Changeset in webkit [19748] by brmorris
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by zalan

DESC: Merge of r19731 to s60/trunk: Browser crashes when trying to open rss link HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

2:55 PM Changeset in webkit [22975] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:53 PM Changeset in webkit [19747] by thatcher
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
  • bridge/mac/WebCoreScriptDebugger.mm: (+[WebCoreScriptDebugger initialize]):
  • platform/mac/SharedBufferMac.mm: (+[SharedBufferData initialize]):
  • platform/mac/WebCoreObjCExtras.c: Added. (WebCoreObjCFinalizeOnMainThread):
  • platform/mac/WebCoreObjCExtras.h: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread. Assert in finalize that we
are on the main thread.

  • Carbon/CarbonWindowAdapter.m: (+[CarbonWindowAdapter initialize]): (-[CarbonWindowAdapter finalize]):
  • History/WebBackForwardList.mm: (+[WebBackForwardList initialize]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary finalize]):
  • Plugins/WebBaseNetscapePluginStream.m: (+[WebBaseNetscapePluginStream initialize]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView finalize]):
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage initialize]): (-[WebBasePluginPackage finalize]):
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream finalize]):
  • WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]): (-[WebEditCommand finalize]):
  • WebCoreSupport/WebFrameBridge.mm: (+[WebFrameBridge initialize]): (-[WebFrameBridge finalize]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (+[WebFramePolicyListener initialize]): (-[WebFramePolicyListener finalize]):
  • WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView finalize]):
  • WebView/WebView.mm: (+[WebViewPrivate initialize]): (-[WebViewPrivate finalize]):
2:53 PM Changeset in webkit [19746] by sfalken
  • 1 copy in tags/Safari-521.35.1b

New tag.

2:44 PM Changeset in webkit [19745] by justing
  • 3 edits in trunk/WebKit

Reviewed by darin


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Mail overrides paste: because it has different
preferred pasteboard types, but it should use our
fragment creation code.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Moved fragment creation code into a new method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:]): Moved fragment creation code here.
  • WebView/WebHTMLViewPrivate.h: Exposed _documentFragmentFromPasteboard:forType:inContext: as SPI.
2:32 PM Changeset in webkit [19744] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: removed _webkit_userVisibleBundleVersionFromFullVersion; we decided to do this without adding SPI for it.
  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): new method, moved here from WebKitNSStringExtras, and is now a WebView method rather than an NSString method (-[WebView _computeUserAgent]): updated for method signature change
2:09 PM Changeset in webkit [19743] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script to parse the output from malloc_history, so we can determine
what's using memory in WebKit.

  • Scripts/parse-malloc-history: Added.
1:32 PM Changeset in webkit [19742] by ggaren
  • 2 edits in trunk/WebCore

Not not reviewed by Mitz Pettel.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671>
REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an
immediate effect


Let's just pretend this never happened.


I attempted a layout test but I couldn't get the old code to fail because
there's no obvious way to isolate the ObjC bindings in a test that's
controlled by JS.


  • bindings/objc/WebScriptObject.mm: (_didExecute):
1:21 PM Changeset in webkit [19741] by kjk
  • 14 edits
    2 copies in trunk/WebCore

Reviewed by Maciej S.

Gdk build fixes for recent refactorings.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/gdk/DragControllerGdk.cpp: (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/DragImage.h:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/EditorClientGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/MimeTypeRegistryGdk.cpp: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore):
  • webcore-base.bkl:
1:13 PM Changeset in webkit [19740] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Allow over-writting Product, ProductSub, Vendor and VendorSub
js properties via #define WEBCORE_NAVIGATOR_*

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
12:41 PM Changeset in webkit [19739] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by John.

  • Misc/WebKitNSStringExtras.h: Added _webkit_userVisibleBundleVersionFromFullVersion.
  • Misc/WebKitNSStringExtras.m: (-[NSString _webkit_userVisibleBundleVersionFromFullVersion]): If the version is 4 digits long or longer, then the first digit represents the version of the OS. Our user agent string should not include this first digit, so strip it off and report the rest as the version.
  • WebView/WebView.mm: (-[WebView _computeUserAgent]): Call _webkit_userVisibleBundleVersionFromFullVersion on the CFBundleVersion.
11:33 AM Changeset in webkit [22974] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Added PositionIterator.cpp & h
11:27 AM Changeset in webkit [19738] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog-2006-12-31
10:56 AM Changeset in webkit [22973] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-20 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
10:20 AM Changeset in webkit [22972] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to FrameLoader and DocumentLoader.
10:18 AM Changeset in webkit [19737] by darin
  • 12 edits in trunk

WebCore:

Reviewed by Anders.

  • prepare to fix some "stop loading" bugs by moving state from the FrameLoader class to the DocumentLoader class
  • WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.
  • html/HTMLDocument.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement data members. (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on the document loader.
  • loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and m_plugInStreamLoaders here.
  • loader/DocumentLoader.cpp: (WebCore::cancelAll): Moved here from FrameLoader. (WebCore::setAllDefersLoading): Ditto. (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's mainResourceData function here. (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader and cancelMainResourceLoad with code that works directly on m_mainResourceLoader. Call the stop functions moved from FrameLoader here on ourselves. (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto. (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the main resource data here; it doesn't require separate functions. (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources and instead just check if the m_subresourceLoaders set is empty. (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader. (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto. (WebCore::DocumentLoader::stopLoadingSubresources): Ditto. (WebCore::DocumentLoader::addSubresourceLoader): Ditto. (WebCore::DocumentLoader::removeSubresourceLoader): Ditto. (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto. (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto. (WebCore::DocumentLoader::isLoadingSubresources): Ditto. (WebCore::DocumentLoader::isLoadingPlugIns): Ditto. (WebCore::DocumentLoader::startLoadingMainResource): Ditto. (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.
  • loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources, cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources, mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource, isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders, m_responseRefreshHeader, and m_responseModifiedHeader.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document loaders. (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader and m_responseModifiedHeader. (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response here to get the Refresh, instead of storing it in a data member. (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removePlugInStreamLoader): Ditto. (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and isLoadingPlugIns on the document loader. (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removeSubresourceLoader): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and stopLoadingPlugIns on the document loader. Removed code to set m_responseModifiedHeader. (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and startLoadingMainResource on the document loader.
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call mainResourceData() on the document loader instead of the frame loader.
  • other changes
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.

WebKit:

Reviewed by Anders.

  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Call cancelMainResourceLoad on the document loader instead of the frame loader.
9:24 AM Changeset in webkit [19736] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5009627> REGRESSION: Repro overrelease of WebView in failed load, seen in DumpRenderTree


  • WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): Return early if the identifier can't be found in the map.
9:19 AM Changeset in webkit [19735] by zack
  • 3 edits in trunk/WebCore

Fix focus handling and make the forms
work as expected.
r=Lars

8:00 AM Changeset in webkit [19734] by weinig
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Darin and then Sam.

No test since there is no change in functionality.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
  • WebCoreSources.bkl:
  • dom/Position.cpp: (WebCore::Position::Position): Added converting constructor from PositionIterator. (WebCore::Position::previous): Changed assert() to ASSERT(). (WebCore::Position::next): Ditto. (WebCore::isStreamer): Changed the argument to a PositionIterator. (WebCore::Position::upstream): Changed to use PositionIterator. (WebCore::Position::downstream): Ditto. (WebCore::Position::inRenderedText): Made public. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed into a static member function. (WebCore::Position::nodeIsUserSelectNone): Ditto.
  • dom/Position.h:
  • dom/PositionIterator.cpp: Added. A Position iterator with constant-time increment, decrement, and several predicates on the Position it is at. Conversion to/from Position is O(n) in the offset. (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
  • dom/PositionIterator.h: Added. (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): Changed to use PositionIterator. (WebCore::previousCandidate): Changed to use PositionIterator.
7:43 AM Changeset in webkit [19733] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan

DESC: [S60] - Browser NG, ReTe: Some call links on "cti_attribute.html " page are highlighted incorrectly ESZG-6TU9N9
Fix: Add hover sto a[cti].s
​http://bugs.webkit.org/show_bug.cgi?id=12814

7:39 AM Changeset in webkit [19732] by rwlbuis
  • 30 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12439
SVG parser complains about points attribute in polygon and polyline element

Return true when the parsed points specification is valid.

7:07 AM Changeset in webkit [19731] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Zalan Bujtas (​zbujtas@gmail.com).

DESC: Browser crashes when trying to open rss link hs.fi/rss HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

6:46 AM Changeset in webkit [19730] by zack
  • 10 edits in trunk

Make editing of forms work plus make sure that non-void methods
always return something.
r=Lars

4:30 AM Changeset in webkit [19729] by zack
  • 2 edits
    1 add in trunk/WebCore

Redo form-theming (aka. make Qt pretty, so very, very pretty)
r=Lars

2:33 AM Changeset in webkit [19728] by ap
  • 2 edits in trunk/WebCore

2007-02-19 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12815
Two image files not included in project file

  • WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and notAllowedCursor.png.
2:11 AM Changeset in webkit [19727] by gdennis
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin Adler.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12802
WebKit.framework is built with SVG_SUPPORT for No-SVG build

  • Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.

Feb 19, 2007:

9:35 PM Changeset in webkit [22971] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeSafari.


I just merged some of the code I wrote for RenderThemeMac.


9:33 PM Changeset in webkit [19726] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeMac.


No test case because 'leaks' can't detect these leaks inside DRT, even if
DRT forces the WebView to paint. ('leaks' can detect these leaks inside
Safari. Weird.)


  • rendering/RenderThemeMac.h:
    • Renamed data members to m_*, to match our style guidelines.
    • Renamed *Is* to is, to match our style guidelines.
    • Removed a few unnecessary data members.
    • Made cached values like m_checkbox mutable, since they can change inside functions that don't change the logical state of a RenderTheme object. (The alternative was to make some const functions non-const.)

(WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just
used to leak and placed them in RetainPtrs.
(WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto

Factored inline implementations of lazy initialization into these accessor
functions, for better encapsulation:


(WebCore::RenderThemeMac::checkbox):
(WebCore::RenderThemeMac::radio):
(WebCore::RenderThemeMac::button):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
this initialization used to confuse the retained data member with a local
stack value, causing both a leak and a failure to initialize. Fixed now.
(WebCore::RenderThemeMac::sliderThumbVertical): ditto
(WebCore::RenderThemeMac::resizeCornerImage):

9:19 PM Changeset in webkit [19725] by thatcher
  • 4 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

<rdar://problem/4636301> Deprecate JavaScriptGlue

  • JavaScriptGlue.h: adds DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER to everything
  • JavaScriptGlue.xcodeproj/project.pbxproj: use -Wno-deprecated-declarations to keep the project building
  • config.h: define DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER as empty on other systems
8:38 PM Changeset in webkit [19724] by bdash
  • 3 edits in tags/Safari-521.35

Versioning.

8:33 PM Changeset in webkit [19723] by bdash
  • 2 edits in tags/Safari-521.35/WebCore

Merge in r19665.

8:31 PM Changeset in webkit [19722] by bdash
  • 10 edits in tags/Safari-521.35/WebCore

Merge in r19662.

8:30 PM Changeset in webkit [19721] by bdash
  • 6 edits in tags/Safari-521.35/WebCore

Merge in r19660.

8:24 PM Changeset in webkit [19720] by bdash
  • 1 copy in tags/Safari-521.35

New tag.

7:01 PM Changeset in webkit [19719] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/table-outer-border-expected.checksum: Added.
  • fast/repaint/table-outer-border-expected.png: Added.
  • fast/repaint/table-outer-border-expected.txt: Added.
  • fast/repaint/table-outer-border.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/table-outer-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow after table sections have computed their outer horizontal borders.
6:39 PM Changeset in webkit [19718] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop
  • page/DragController.cpp: (WebCore::DragController::startDrag): Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the raw source HTML text.
5:41 PM Changeset in webkit [19717] by hyatt
  • 60 edits
    4 adds in trunk

Fix for Radar 4981605, regression where button grows randomly when a select is
opened. With the new form controls, the WinIE quirk for using line width
ended up being used for them more.

This patch removes the quirk after verifying that Firefox doesn't implement
the quirk at all. usesLineWidth is being renamed to shrinksToAvoidFloats to
make it clear that the new method only applies to block objects that avoid floats
and that have auto width.

Also fixed a regression where whitespace after a floating <select> at the start
of a block got incorrectly rendered. Make sure skipWhitespace always skips
through floating/positioned elements regardless of the whitespace setting (this
way the white-space:pre value on floating <select>s doesn't cause trouble).

Reviewed by darin

fast/block/float/float-avoidance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats):
  • rendering/RenderObject.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace):
5:22 PM Changeset in webkit [19716] by weinig
  • 5 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

  1. Test for background image with relative url, when base url element is present. .html has a base url, which according to the html spec is supposed to be absolute, is actually a relative url. Absolute url would not work with ​file:// scheme.
  2. Test for base element and @import with relative url. ​http://bugs.webkit.org/show_bug.cgi?id=12214


  • fast/css/background-image-with-baseurl-expected.checksum: Added.
  • fast/css/background-image-with-baseurl-expected.png: Added.
  • fast/css/background-image-with-baseurl-expected.txt: Added.
  • fast/css/background-image-with-baseurl.html: Added.
  • fast/css/import_with_baseurl-expected.checksum: Added.
  • fast/css/import_with_baseurl-expected.png: Added.
  • fast/css/import_with_baseurl-expected.txt: Added.
  • fast/css/import_with_baseurl.html: Added.
  • fast/css/resources/background_image.css: Added.

WebCore:

Reviewed by Darin.

Update stylesheet href, when document's baseUrl changes. It needs
update when the stylesheet is constructed before the parser hits the base tag.
​http://bugs.webkit.org/show_bug.cgi?id=12214

  • css/StyleSheet.h: (WebCore::StyleSheet::setHref):
  • dom/Document.cpp: (WebCore::Document::setBaseURL):
  • dom/Document.h:
5:05 PM Changeset in webkit [19715] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

The FrameLoader's responseMIMEType was not being updated when a page was
brought back from the page cache.


Moved the line that updates the MIME type from commitProvisionalLoad() to
transitionToCommitted().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):
4:01 PM Changeset in webkit [19714] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix.


  • Scripts/check-for-global-initializers: Ignore the global counter I added for SubresourceLoaders.
3:36 PM Changeset in webkit [22970] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru

The fix for the bug was to zero out WebFrame's Frame pointer in
WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
non-null as appropriate. All IWebFrame methods that depend on the Frame
pointer will return E_FAIL if it is null, and everywhere within
WebFrame that wasn't null-checking before will now explicitly ASSERT.

I also changed all uses of d->frame and WebFrame::impl() to use the
core() function for consistency, and so that there is only one code
path for getting from a WebFrame to a Frame.

Additional more specific comments below.

  • WebChromeClient.cpp: (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebFrame.cpp: (kit): Null-check the frame parameter. (core): Added two overloads of this. (WebFrame::DOMDocument): Added argument checking. (WebFrame::currentForm): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null. (WebFrame::provisionalDataSource): Ditto. (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::parentFrame): (WebFrame::renderTreeAsExternalRepresentation): Added argument checking. (WebFrame::firstLayoutDone): Ditto. (WebFrame::loadType): Ditto. (WebFrame::invalidate): (WebFrame::setTextSizeMultiplier): (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT. (WebFrame::setInViewSourceMode): Changed to return an HRESULT. (WebFrame::searchForLabelsBeforeElement): Added argument checking. (WebFrame::matchLabelsAgainstElement): Ditto. (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed. (WebFrame::createFrame): (WebFrame::loadURLIntoChild): Added some assertions. (WebFrame::dispatchWillSubmitForm): (WebFrame::frameLoadCompleted): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchCreatePage): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::windowObjectCleared): (WebFrame::setPrinting): (WebFrame::setInPrintingMode): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding. (WebFrame::spoolPages): (WebFrame::forceLayoutWithPageWidthRange):
  • WebFrame.h:
  • WebView.cpp: (WebView::paint): Silently fail on a null Frame, because this method could be called at any time. (WebView::mouseWheel): Ditto. (WebViewWndProc): Ditto. (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns. (WebView::setInViewSourceMode): Ditto. (WebView::setCustomTextEncodingName): Replaced check for a null FrameLoader with a check for a null Frame, which is equivalent but, as a bonus, won't crash. (WebView::stringByEvaluatingJavaScriptFromString): (WebView::elementAtPoint): Added argument checking. (WebView::selectedText): Ditto. (WebView::centerSelectionInVisibleArea):
3:34 PM Changeset in webkit [22969] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix build.

  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize):
3:32 PM Changeset in webkit [19713] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make DragController::maxDragImageSize a function to get rid of the global initializer.


  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • page/DragController.h:
  • page/mac/DragControllerMac.mm: (WebCore::DragController::maxDragImageSize):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::maxDragImageSize):
3:19 PM Changeset in webkit [22968] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Fix for <rdar://problem/5006882> PlatformScrollbarSafari doesn't support small scroll bars

3:19 PM Changeset in webkit [19712] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/check-for-global-initializers: Delete the linked executable if the check fails. Without this, you only see the global initializer error once, which makes it very easy to miss them.
3:09 PM Changeset in webkit [19711] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView setPreferences:]):
2:47 PM Changeset in webkit [22967] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5008424>
Regression: Crash loading mp3.com


  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Handle null resource errrors.
1:44 PM Changeset in webkit [19710] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader() when loading AFL Ladder widget
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Add missing null check so this fails without crashing when called on an element that's no longer in a frame.
1:39 PM Changeset in webkit [19709] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4868242>
​http://bugs.webkit.org/show_bug.cgi?id=12670
REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)


Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
to object hash map for this.

  • WebView/WebView.mm: (-[WebView _addObject:forIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:41 AM Changeset in webkit [19708] by thatcher
  • 3 edits in trunk/WebKit

Remove two imports of FrameMac.h, fixes clean Mac builds.

7:43 AM Changeset in webkit [19707] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.


  • fast/forms/select-accesskey-expected.checksum: Added.
  • fast/forms/select-accesskey-expected.png: Added.
  • fast/forms/select-accesskey-expected.txt: Added.
  • fast/forms/select-accesskey.html: Added.

WebCore:

Reviewed by Mitz.


Focus the select element too in accessKeyAction.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction):
1:20 AM Changeset in webkit [19706] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


Avoid double painting caret when it is on a block element.


Layout test for this already went in previous try (it only fails in pixel mode) in r19626.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
12:35 AM Changeset in webkit [22966] by aroben
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame): This is no longer an instance method of Frame.
  • bridge/win/FrameWin.h:

WebKitWin:

Build fix.

  • WebFrame.cpp: (WebFrame::computePageRects):
12:13 AM Changeset in webkit [19705] by lars
  • 3 edits in trunk/WebCore

Added a one line patch from Olliej to create the
clipboard on demand (to stop things from crashing),
and added lots of notImplemented() warnings all
over the place.

Feb 18, 2007:

11:58 PM Changeset in webkit [22965] by mjs
  • 20 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • bridge/win/FrameWin.cpp: (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::computePageRects): (WebCore::drawRectIntoContext): (WebCore::imageFromSelection): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • bridge/win/FrameWin.h:
  • page/win/EventHandlerWin.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection):
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::createNullPluginView): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:

WebKitWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • WebChromeClient.cpp: (WebChromeClient::tabsToLinks): (WebChromeClient::windowResizerRect): (WebChromeClient::addToDirtyRegion): (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebChromeClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldChangeSelectedRange): (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
  • WebFrame.cpp: (kit): (WebFrame::initWithWebFrameView): (WebFrame::searchForLabelsBeforeElement): (WebFrame::matchLabelsAgainstElement): (WebFrame::createPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h:
  • WebView.cpp: (WebView::handleEditingKeyboardEvent): (WebView::keyDown): (WebView::generateSelectionImage):
  • WebView.h:
11:58 PM Changeset in webkit [19704] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Oliver

<rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture

  • Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
  • WebView/WebView.mm: (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change
11:57 PM Changeset in webkit [19703] by lars
  • 2 edits in trunk/WebCore

fix compilation.

11:54 PM Changeset in webkit [19702] by mjs
  • 91 edits
    4 adds
    2 deletes in trunk

WebCore:

Reviewed by Maciej.


Additional coding by Maciej, additional review by Oliver.

Get rid of the FrameMac and FrameQt classes. Instead
move all methods into Frame directly, and implement
some platform specific methods in foo/FrameFoo.cpp.

Some general cleanup in Frame:

  • Move some methods out of Frame, to the place where they belong.
  • Unify the different ways of creating the JavaScript wrappers for <object>, <embed> and <applet>
  • Some cleanup of the WebCoreFrameBridge
  • ForwardingHeaders/bindings/NP_jsobject.h: Added.
  • ForwardingHeaders/bindings/npruntime_impl.h: Added.
  • ForwardingHeaders/bindings/runtime_root.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/EditorClient.h:
  • bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateBorder): (WebCore::FrameView::updateDashboardRegions):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • dom/Position.cpp: (WebCore::Position::next):
  • editing/CommandByName.cpp: (WebCore::Frame::execCopy): (WebCore::Frame::execCut): (WebCore::Frame::execPaste):
  • editing/Editor.cpp: (WebCore::Editor::canEdit): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::getInstance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::detachFromParent):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::markedTextRange): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::isContentEditable): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::cleanupScriptObjects): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): (WebCore::EventHandler::keyboardUIMode):
  • page/mac/FrameMac.h: Removed.
  • page/mac/FrameMac.mm: (WebCore::Frame::setBridge): (WebCore::Frame::bridge): (WebCore::Frame::searchForLabelsAboveCell): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::fontAttributesForSelectionStart): (WebCore::Frame::baseWritingDirectionForSelectionStart): (WebCore::Frame::print): (WebCore::Frame::issuePasteCommand): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::textFieldDidBeginEditing): (WebCore::Frame::textFieldDidEndEditing): (WebCore::Frame::textDidChangeInTextField): (WebCore::Frame::textDidChangeInTextArea): (WebCore::Frame::doTextFieldCommandFromEvent): (WebCore::Frame::textWillBeDeletedInTextField): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::setMarkedTextRange): (WebCore::Frame::dashboardRegionsDictionary): (WebCore::Frame::dashboardRegionsChanged): (WebCore::Frame::willPopupMenu): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::windowScriptObject): (WebCore::Frame::cleanupPlatformScriptObjects):
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (createRootObject): (bridge): (-[WebCoreFrameBridge _frame]):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp: (WebCore::Frame::unfocusWindow): (WebCore::Frame::focusWindow): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::print): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • page/qt/FrameQt.h: Removed.
  • platform/MimeTypeRegistry.h:
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript): (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController beginSheetWithFrame:]):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected):
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleManagerQt.cpp:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start):
  • platform/qt/MimeTypeRegistryQt.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewCanvasQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Added implementations for the new callbacks in EditorClient
and ChromeClient (basically moved from WebFrameBridge).
Cleaned up some code paths that are not called anymore
and done fully inside WebCore now.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldChangeSelectedRange):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): (-[WebFrameBridge fini]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchiver.mm:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _updateBackground]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:
  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _isEditable]): (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView scrollWheel:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView selectedAttributedString]):
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView shouldClose]): (-[WebView setEditable:]):

WebKitQt:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Add stubs for the new methods in ChormeClient and EditorClient,
remove all references to FrameQt.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldChangeSelectedRange): (WebCore::EditorClientQt::isEditable):
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::webFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:
11:18 PM Changeset in webkit [19701] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Oops, missed a 'const'

  • platform/qt/ClipboardQt.h:
11:04 PM Changeset in webkit [19700] by oliver
  • 3 edits
    2 adds in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Adding stubbed out implementation of Clipboard for Qt to stop
it crashing whenever someone drags the mouse.

  • WebCore.pro:
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/qt/ClipboardQt.cpp: Added. (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::types): (WebCore::ClipboardQt::dragLocation): (WebCore::ClipboardQt::dragImage): (WebCore::ClipboardQt::setDragImage): (WebCore::ClipboardQt::dragImageElement): (WebCore::ClipboardQt::setDragImageElement): (WebCore::ClipboardQt::createDragImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h: Added. (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::isForDragging):
11:00 PM Changeset in webkit [22964] by adachan
  • 9 edits
    4 adds in branches/WindowsMerge

2007-02-18 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Adam.

Move app text controls to use WebView.

  • added a method to let us render text using WebKit.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/WebCoreTextRenderer.cpp: Added. (WebCore::WebCoreDrawTextAtPoint):
  • platform/win/WebCoreTextRenderer.h: Added.

WebKitWin:

Reviewed by Adam.


Move app text controls to use webview

10:14 PM WebKit Team edited by oliver@apple.com
I appear to be the DnD guy now (diff)
10:07 PM Changeset in webkit [19699] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't even attempt to do a document based drag if there isn't a document
Fixes rdar://problem/4960109

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):

Null check m_document

(WebCore::DragController::tryDHTMLDrag):

ASSERT(m_document) -- tryDocumentDrag is the only
thing that will ever call us, but lets play it safe


4:42 PM Changeset in webkit [22963] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

Fix <rdar://problem/5006918> All selected text is black, even if it is
some other color when not selected

4:28 PM Changeset in webkit [22962] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5006872> <select> popups need Aqua scroll bars

PopupMenuWin now uses a PlatformScrollbar.

4:26 PM Changeset in webkit [19698] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

A little preparation for <rdar://problem/5006872>.

  • platform/PopupMenu.h:
1:07 PM Changeset in webkit [19697] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12807
XPath incorrectly converts NaN to boolean

Test: fast/xpath/nan-to-boolean.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::toBoolean): Convert NaN to false.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
8:15 AM Changeset in webkit [19696] by ap
  • 128 edits
    12 adds in trunk

2007-02-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html
fast/repaint/table-cell-vertical-overflow.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have vertical overflow.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells. (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowHeight): (WebCore::RenderTableSection::overflowTop):
6:23 AM Changeset in webkit [19695] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix for the build fix -- can't call something that isn't a function

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:48 AM Changeset in webkit [19694] by oliver
  • 3 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
project files

Stubbed method for WebCore::notAllowedCursor -- not sure what it should return,
have returned blank cursor, possibly needs to return something else

  • WebCore.pro:
  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:07 AM Changeset in webkit [19693] by oliver
  • 3 edits in trunk/WebKitQt

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix -- adding DragClientQt method stubs

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragSourceAction): (WebCore::DragClientQt::startDrag): (WebCore::DragClientQt::createDragImageForLink):
  • WebCoreSupport/DragClientQt.h:
4:59 AM Changeset in webkit [19692] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Sigh, obnoxious occasional auto conversion from float to int

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::createDragImage):


4:48 AM Changeset in webkit [19691] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12799
REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
redirects to the wrong URL)

Test: http/tests/misc/refresh-meta-with-newline.html

  • platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: In HTML, all characters with codes <= 0x20 are whitespace, while in HTTP, only space and tab are such.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Pass parseHTTPRefresh() a flag telling about the source of data.
4:44 AM Changeset in webkit [19690] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Buld fix -- surprisingly RetainPtr doesn't exist on Qt

  • platform/DragImage.h:


4:35 AM Changeset in webkit [22961] by oliver
  • 10 edits
    1 add in branches/WindowsMerge

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Updated to include stubs for drag and drop methods
Added DragImage[Win].cpp to project file
Now uses platform independent EventHandler::handleDrag

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::Frame::dragImageForSelection): Just wrap the platform specific selectionImage method
  • page/win/DragControllerWin.cpp: Defining constants for drag images -- basically copied the Mac definitions
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Basic implementation -- needs to create an IDataObject to be useful but ClipboardWin is basically unimplemented anyway so not yet a problem
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Stubs
  • platform/win/ClipboardWin.h: Updated interface
  • platform/win/DragImageWin.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Stubs to keep the build going

  • WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink):
  • WebDragClient.h:
4:30 AM Changeset in webkit [19689] by oliver
  • 28 edits
    4 adds in trunk

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

More drag and drop migration, now the entirety of the
drag initiation logic has been rendered platform independent
This has required a number of new interfaces, and a reasonable
amount of logic migration.

As a side effect, this patch also fixes rdar://problem/4945341

There are some basic Qt stubs that should stop the build from failing,
however the absence of ClipboardQt means any attempt to initiate a drag
may cause a crash.

  • WebCore.exp:

Exporting new symbols

  • WebCore.xcodeproj/project.pbxproj:

New files

  • dom/Clipboard.cpp: (WebCore::Clipboard::canSaveAsWebArchive): Migrated from WebKit
  • dom/Clipboard.h: Added more methods to allow Clipboard to be used as a platform independent container for drag and drop
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage): This is a mac only helper function, so i've made it have an empty implementation, that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
  • page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::tryDHTMLDrag): Using RefPtrs now (WebCore::getCachedImage): (WebCore::getImage): Helper functions (WebCore::dragLocForDHTMLDrag): (WebCore::dragLocForSelectionDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): Logic that generates drag images and clipboard content, and initiates the actual system drag operation
  • page/DragController.h: Method and variable declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): handleDrag is now platform independent (WebCore::EventHandler::handleTextInputEvent):

formatting

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseDragged): Forgot to define this stub function
  • page/Frame.h: Declaring dragImageForSelection to provide drag image for selected content
  • page/mac/DragControllerMac.mm: Defining drag images control vars
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard): Migrated old clipboard creation to here
  • page/mac/FrameMac.mm: (WebCore::Frame::dragImageForSelection): Wrap FrameMac::selectionImage
  • page/qt/DragControllerQt.cpp: Defining drag images control vars
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard): stub
  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection): stub
  • platform/DragImage.cpp: Added. (WebCore::fitDragImageToMaxSize): (WebCore::createDragImageForSelection):

Platform independent processing for drag images

  • platform/DragImage.h: Added.

Declaring typedefs and wrapper functions to abstract the handling
of drag images

  • platform/Pasteboard.h: Declaring extracted writeURL and writeSelection methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::willPerformDragSourceAction): (WebCore::SVGEmptyDragClient::startDrag): (WebCore::SVGEmptyDragClient::createDragImageForLink): Stubs FTW!
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::pasteboard): Provide accessor for underlying NSPasteboard
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::hasData): (WebCore::ClipboardMac::writeRange): (WebCore::ClipboardMac::writeURL): (WebCore::ClipboardMac::declareAndWriteDragImage): (WebCore::ClipboardMac::createDragImage):

Implemented new Clipboarid functionality.

(WebCore::ClipboardMac::dragNSImage):

Made this a const method

  • platform/mac/DragImageMac.mm: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):

Implemented platform specific DragImage functions

  • platform/mac/PasteboardMac.mm: (WebCore::writeSelection): (WebCore::Pasteboard::writeSelection): (WebCore::writeURL): (WebCore::Pasteboard::writeURL):

Extracted member implementations of these functions, so that
Clipboard could also make use of this functionality.
Pasteboard methods now call the new non-member implementations.
Also fixed implementations to respect the list of requested types.

  • platform/qt/DragImageQt.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Moving the drag initiation logic to WebCore.
The redundant code in webkit will be moved out in a later patch.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (getTopHTMLView): Helper function (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink): Implemented new DragClient methods (WebDragClient::declareAndWriteDragImage): Helper function for the Mac to allow new drag and drop code to match behaviour


  • WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _dragImageForLinkElement:]): Refactoring old _dragImageForLinkElement function so that the link drag image can be created with just a URL and label, rather than requiring the original element (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Removed logic that is no longer necessary (-[WebHTMLView _mouseDownEvent]): The WebDragClient may need the original mouseDownEvent of a drag when initiating a drag
  • WebView/WebHTMLViewInternal.h: Declaring _mouseDownEvent
  • WebView/WebHTMLViewPrivate.h: Declaring _dragImageForURL



12:48 AM Changeset in webkit [19688] by ap
  • 4 edits in trunk/JavaScriptCore

2007-02-18 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Fix cases where MSVC-specific code was identified as Win32 platform
code. (as it should be compiled for e.g. wx port when using MSVC too)


  • wtf/Assertions.h:
  • wtf/MathExtras.h:
  • wtf/StringExtras.h: changed PLATFORM(WIN) sections to COMPILER(MSVC) as necessary

Feb 17, 2007:

10:28 PM Changeset in webkit [22960] by aroben
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Removed bogus single-file configuration for MimeTypeRegistryWin.cpp.
10:04 PM Changeset in webkit [22959] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-02-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

  • Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
  • WebView.cpp: (WebView::scrollOffset): Add null check (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here) (WebView::visibleContentRect): Added so we can size find overlay appropriately (not including scroll bars)
  • WebView.h: Added scrollBy, visibleContentRect
5:59 PM Changeset in webkit [22958] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Part of the OpenSource fix to make sure the fill color starts off as transparent. Make sure our CG context
has its state properly in sync with the CGContext.

Reviewed by aroben

  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:58 PM Changeset in webkit [19687] by hyatt
  • 2 edits in trunk/WebCore

Fix textarea resizers to not fill with black by making sure the fill color starts off as
transparent instead of black.

Reviewed by aroben

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
5:52 PM Changeset in webkit [22957] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Build fix.

  • platform/win/CursorWin.cpp: (WebCore::notAllowedCursor):
2:23 PM Changeset in webkit [19686] by aroben
  • 2 edits in trunk

Added missing Radar references to ChangeLogs.

2:21 PM Changeset in webkit [19685] by aroben
  • 3 edits
    4 adds in trunk

2007-02-17 Lars Knoll <​lars@trolltech.com>

LayoutTests:

Reviewed by Adam.

test for ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

  • fast/images/image-in-map-expected.checksum: Added.
  • fast/images/image-in-map-expected.png: Added.
  • fast/images/image-in-map-expected.txt: Added.
  • fast/images/image-in-map.html: Added.

WebCore:

Reviewed by Adam.

fix ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

Test: fast/images/image-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD):
2:09 PM Changeset in webkit [19684] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • fast/xpath/namespace-vs-predicate-expected.txt: Added.
  • fast/xpath/namespace-vs-predicate.xhtml: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its resulting type is an expanded name, rather than a string. It is not really possible to store the namespace inside Parser, because it gets used in wrong steps then.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::expandQName):
  • xml/XPathParser.h: Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::Step):
  • xml/XPathStep.h: Added a constructor that takes a namespace.
11:03 AM Changeset in webkit [19683] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
  • fast/loader/simultaneous-reloads-assert-expected.txt: Added.
  • fast/loader/simultaneous-reloads-assert.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/simultaneous-reloads-assert.html

  • loader/Cache.cpp: (WebCore::Cache::remove): Replaced the assertion with a check whether the resource is in the cache. The resource could have been removed from the cache as a result of a reload occurring simultaneously in a different document.
10:58 AM Changeset in webkit [19682] by adele
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12711
Prettier and more distinct cursors

  • Resources/crossHairCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/notAllowedCursor.png: Added.
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::crossCursor): (WebCore::notAllowedCursor):
10:35 AM Changeset in webkit [19681] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/shadow-boundary-crossing-expected.txt: Added.
  • fast/events/shadow-boundary-crossing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/shadow-boundary-crossing.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new eventParentNode() function for constructing the chain of ancestors for capture and bubbling.
  • dom/Node.h: (WebCore::Node::eventParentNode): Added. Returns the node's parent for the purpose of of event capture and bubbling. The base class implementation is to return the parent node.
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble to and can be captured across the shadow DOM boundary, returns the shadow parent for shadow nodes.
1:58 AM Changeset in webkit [22956] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix how resizers invalidate so that there aren't glitches in the lower right corner of the window as you switch pages.

1:50 AM Changeset in webkit [19680] by hyatt
  • 2 edits in trunk/WebCore

Improve textarea resizer painting.

1:07 AM Changeset in webkit [19679] by kjk
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
by Mike Emmel.

  • kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
  • kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
  • wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions

WebCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
from Mike Emmel.

  • platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
  • platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData to the end, to avoid crashes on ARM due to different struct packing.
12:27 AM Changeset in webkit [19678] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

  • fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • fast/forms/input-readonly-autoscroll-expected.png: Added.
  • fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • fast/forms/input-readonly-autoscroll.html: Added.

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

Test: fast/forms/input-readonly-autoscroll.html

Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
12:21 AM Changeset in webkit [22955] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text). This will also reveal the selection properly.
12:14 AM Changeset in webkit [19677] by kjk
  • 7 edits in trunk/WebCore

Reviewed by Adam Roben.

Curl networking improvements inspired by Mike Emmel's patches in
​http://bugs.webkit.org/show_bug.cgi?id=11332.
Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.

  • loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API. (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::willUseArchive):
  • loader/gdk/FrameLoaderClientGdk.h: Ditto.
  • platform/network/ResourceHandleInternal.h: Remember url and custom headers for the request lifetime and free them at the end. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: Ditto. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: url improvements:
  • remove m_useSimple code-path since it wasn't used anywhere
  • don't use hashmap for keeping track of outstanding jobs - curl does it anyway
  • set custom headers from request
  • enable gzip and deflate through Accept-Encoding
  • setup curl to share cookies and DNS cache between requests
  • enable persisting of cookies in a file (if client provides file name for cookies via ResourceHandleManager::setCookieJarFileName()) (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h:
12:09 AM Changeset in webkit [19676] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Gdk fixes.

  • page/gdk/EventHandlerGdk.cpp: Comment out chatty message. (WebCore::EventHandler::handleDrag):
  • platform/gdk/EditorClientGdk.cpp: Enable entering text into text field. (WebCore::EditorClientGdk::shouldInsertText):

Feb 16, 2007:

10:33 PM Changeset in webkit [19675] by kjk
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Move Path implementation from TemporaryLinkStubs.cpp to
its own file.
Implement setLineCap, setLineJoin and setMiterLimit for
cairo's GraphicsContext.

  • WebCoreSources.bkl:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit):
  • platform/graphics/cairo/PathCairo.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::Path::apply):
9:00 PM Changeset in webkit [19674] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix uninitialized variable

8:39 PM Changeset in webkit [19673] by adachan
  • 2 edits in trunk/WebCore

2007-02-16 Ada Chan <​adachan@apple.com>

Reviewed by Adam and Maciej.

Use a RefPtr to store the old hover node.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):


5:15 PM Changeset in webkit [19672] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames

This symptom is specific to Safari, so no layout test.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the text field is focused.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text field is focused. (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast. (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if the text field is focused.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea, textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
5:04 PM Changeset in webkit [19671] by hyatt
  • 2 edits in trunk/WebCore/platform

API tweaks to widget and scrollview.

5:04 PM Changeset in webkit [22954] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix RSS scrollbar.

4:31 PM Changeset in webkit [19670] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4811446> "Check Grammar" checkbox in Spelling+Grammar window doesn't live update with menu change in WebKit
  • WebView/WebView.mm: (-[WebView setGrammarCheckingEnabled:]): Use sekrit AppKit knowledge to tell NSSpellChecker about the change, since there's no API for this yet. Also restructured a little to avoid extra work when the value hasn't changed.
3:59 PM WikiStart edited by Adam Roben
Added login link (diff)
3:58 PM WikiStart edited by Adam Roben
Added registration link (diff)
3:48 PM Changeset in webkit [22953] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

3:21 PM Changeset in webkit [19669] by brmorris
  • 3 edits in S60/trunk/WebKit

wei, reviewed by zalan. reverted and re-merged by mbradley

DESC: Reverts r19963 and re-applies with and updated patch. PNIO-6YFCUT conversion problem w/ google search
​http://bugs.webkit.org/show_bug.cgi?id=12792

3:05 PM Changeset in webkit [19668] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by yongjun

DESC: Browser crash when exited upon loading JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

2:29 PM Changeset in webkit [19667] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4943985>
REGRESSION: Dragging standalone images to Finder fails to download the image file


Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in
ImageDocumentMac.mm


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
2:02 PM Changeset in webkit [22952] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

ScrollView fixes.

1:56 PM Changeset in webkit [19666] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Anders.

  • fix <rdar://problem/5000216> JavaScriptGlue framework started turning all CFNumbers into signed 32bit values

Circumstantial evidence seems to indicate that JavaScriptGlue was depending on a bug
in CFNumber where CFNumberIsFloatType was returning true for 64-bit integer values.

  • JSUtils.cpp: (JSObjectKJSValue): Removed the call to CFNumberIsFloatType in the conversion of numeric values, and always use kCFNumberDoubleType, since double is the internal format of numbers in JavaScriptCore. There's no value to having a separate code path for integers. There's also no reason to check the return value from CFNumberGetValue -- if it returns false it still does the best it can to convert to a double, which is what we want.
  • UserObjectImp.cpp: (UserObjectImp::toString): Removed a similar code path that tried to handle integers separate from double. Instead, always use a double. For compatibility, use a format without a decimal point when CFNumberIsFloatType returns false. Also removed a bogus cast to float; the "%f" format string takes a double, not a float, so all the cast did was cut down on precision.
1:54 PM Changeset in webkit [19665] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)

  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Change the default to log the violations.
12:52 PM Changeset in webkit [19664] by zbujtas
  • 3 edits in S60/branches/3.1m/WebKit

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::LoadUrlL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::SetUrlL):
12:13 PM Changeset in webkit [19663] by brmorris
  • 5 edits in S60/trunk

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

12:07 PM Changeset in webkit [22951] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4993040>
Crash in plugin code watching yahoo news video


Zero out the plugin function struct.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
11:41 AM Changeset in webkit [22950] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebDownload.cpp: (WebDownload::init): (WebDownload::initWithRequest):
11:40 AM Changeset in webkit [19662] by adele
  • 10 edits in trunk/WebCore

Reviewed by Mitz.

Fixed: ​http://bugs.webkit.org/show_bug.cgi?id=12768
<rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field

No test case added. This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.

  • dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
  • dom/Element.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
  • html/HTMLInputElement.h: ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
  • html/HTMLTextAreaElement.h: ditto.
  • page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page. Pass true for the restorePreviousSelection argument.
  • rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView. It shouldn't be null, but if it is, we'll fail silently on release builds. (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::windowClipRect): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
11:16 AM Changeset in webkit [19661] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12788
REGRESSION: Going back one page in history has a noticeable delay


Um...if all elements in two vectors are equal, then I guess we could say that
the two vectors are equal too.


  • wtf/Vector.h: (WTF::):
11:03 AM Changeset in webkit [22949] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Fix build.

Use adoptCF instead of adopt.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
11:00 AM Changeset in webkit [19660] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC

Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.


  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptNSReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adoptCF): (WebCore::::adoptNS):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
10:58 AM WebKit Team edited by sullivan@apple.com
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:52 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:31 AM Changeset in webkit [19659] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao, Reviewed by Yongjun.

DESC: Merge of 19656 to 3.1m branch (Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query. ISHG-6Q2ST8)
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:27 AM Changeset in webkit [19658] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Browser crash when exited upon loading. JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

8:24 AM Changeset in webkit [19657] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: 3.2:webkit "page not found" problem, which is before TelService be launched (TLUU-6YDPRT)
​http://bugs.webkit.org/show_bug.cgi?id=12771

8:22 AM Changeset in webkit [19656] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by Yongjun

DESC: [S60] Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query.ISHG-6Q2ST8
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:20 AM Changeset in webkit [19655] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Selection list not shown correctly in www.elisa.fi [ TSW ID: HMNN-6XQJMX]
​http://bugs.webkit.org/show_bug.cgi?id=12719

8:18 AM Changeset in webkit [19654] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun

DESC: When application is launched via hyperlink, the cursor stays as wait cursor (TSW EAJA-6VDH84)
​http://bugs.webkit.org/show_bug.cgi?id=12715

3:35 AM Changeset in webkit [22948] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Oliver.

Implemented square button look.

Feb 15, 2007:

9:19 PM Changeset in webkit [19653] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Lost Objective-C Hippyness (or hippiness)

Oh boy, did I ever botch this one up...

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Null check the FrameView
8:44 PM Changeset in webkit [19652] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam's complaint

aroben wanted me to do an early return, instead.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
8:40 PM Changeset in webkit [19651] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele

Forgot to bring the null check with me when I backed this code out of
the FrameLoaderClient

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): null check the HistoryItem
8:19 PM Changeset in webkit [22947] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5001181> Crash: autofilling empty page


Return an error from WebFrame::DOMDocument if there's no document

  • WebFrame.cpp: (WebFrame::DOMDocument): null document now maps to E_FAIL
8:13 PM Changeset in webkit [22946] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://4778394> - Save scroll position in the back/forward list


  • WebFrame.cpp: (WebFrame::restoreViewState): Renamed, as scroll position was pushed to WebCore (WebFrame::saveViewStateToItem): Ditto
  • WebFrame.h:
8:11 PM Changeset in webkit [19650] by beidson
  • 11 edits in trunk

WebCore:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Actually save the scroll position here instead of asking the FrameLoaderClient (WebCore::FrameLoader::restoreScrollPositionAndViewState): Ditto
  • loader/FrameLoaderClient.h: Renamed/repurposed 2 methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::restoreViewState): Ditto (WebCore::SVGEmptyFrameLoaderClient::saveViewStateToItem): Ditto

WebKit:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • WebCoreSupport/WebFrameLoaderClient.h: Renamed the save/restore methods
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::saveViewStateToItem): Save viewstate only (WebFrameLoaderClient::restoreViewState): Restore viewstate only

WebKitQt:

Reviewed by Adam

Moved scroll state down into the cross platform FrameLoader -
Blind attempt at keeping Qt building

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::restoreViewState): (WebCore::FrameLoaderClientQt::saveViewStateToItem):
  • WebCoreSupport/FrameLoaderClientQt.h:
8:00 PM Changeset in webkit [19649] by bdash
  • 2 edits in trunk/WebKitTools

2007-02-16 Mark Rowe <​mrowe@apple.com>

Not reviewed.

<rdar://problem/4982312> leaks bot should run in normal mode, rather than quiet mode

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Switch back to default verbosity for output of leaks tests.
6:35 PM Changeset in webkit [19648] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

Added:

  • editing/pasteboard/4989774-expected.checksum: Added.
  • editing/pasteboard/4989774-expected.png: Added.
  • editing/pasteboard/4989774-expected.txt: Added.
  • editing/pasteboard/4989774.html: Added. Equivalent trees:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

<span><img><span><img></span></span> will appear as two
images on different lines because of a layout/rendering
bug. This patch avoids the bug by producing cleaner
markup so that the paste code can safely remove the style
spans.

  • editing/markup.cpp: (WebCore::createMarkup): Get the default style from the editable root or body instead of the document element. This produces cleaner markup since we don't inline the root's styles.
5:47 PM Changeset in webkit [19647] by kjk
  • 3 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Add gdk version of ContextMenuClient based on qt version.

  • WebCoreSources.bkl:
  • page/gdk/ContextMenuClientGdk.cpp: Added. (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/ContextMenuClientGdk.h: Added.
  • webcore-base.bkl: curl is needed when building webcore_base files.
5:07 PM Changeset in webkit [22945] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix <rdar://problem/4968731> Printing scales frames to page width
instead of doing a layout at that width

  • Interfaces/IWebFramePrivate.idl: Added setInPrintingMode method.
  • WebFrame.cpp: (WebFrame::WebFrame): Initialize new member. (printerRect): New helper function. (WebFrame::setPrinting): Ported from WebHTMLView. (WebFrame::setInPrintingMode): Implemented. (WebFrame::computePageRects): Changed to store the page rects. (WebFrame::getPrintedPageCount): Added an ASSERT and updated for change to computePageRects. (WebFrame::spoolPages): Use the stored page rects, and set mediaBox's size using the print rect instead of the page rect so we will scale the pages to the full width of the print DC. (WebFrame::forceLayoutWithPageWidthRange): Ported from WebFrameBridge.
  • WebFrame.h: Updated declarations.
3:58 PM Changeset in webkit [22944] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:57 PM Changeset in webkit [19646] by sfalken
  • 1 copy in tags/Safari-521.34.5b

New tag.

2:35 PM Changeset in webkit [22943] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Add the default Flash plugin location to the list of plugin paths.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addFlashPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths):
2:13 PM Changeset in webkit [22942] by sfalken
  • 6 edits in branches/WindowsMerge

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • WebKit.vcproj/WebKit.vcproj:
  • WebPreferences.cpp: (WebPreferences::setFontSmoothing):
  • WebView.cpp: (WebViewWndProc):

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

Added WebKitSystemInterfaceWin

2:10 PM Changeset in webkit [19645] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Fixed: <rdar://problem/4983883> Background of a .mov window should not be white

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Set a background color of gray for full frame plug-ins, which makes it easier on the eyes. It's also the same gray that PDFKit uses, too.
2:05 PM Changeset in webkit [19644] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

The problem was that selectionRect() was being called on a render tree that
had pending style changes. The changes were committed as a side effect in
the middle of traversing the render tree, and the current object got
deleted as a result. The solution is to update the render tree before
starting to traverse it.

The inspector was affected because it makes style changes in response to
an AppKit notification that's sent right before the windowDidResignKey:
notification, under which WebKit calls selectionRect(). I couldn't recreate
the same conditions (having uncommitted style changes in the tree when the
window becomes inactive) using HTML/JS in Safari, hence the lack of
a regression test to go with this patch.

  • rendering/RenderView.cpp: (WebCore::RenderView::selectionRect): Added call to updateRendering().
1:03 PM Changeset in webkit [19643] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Document::removeMarkers() was using a Vector iterator (which is just a
pointer) and inserting into the Vector at the same time, which made the
iterator invalid as the Vector's data buffer was relocated.


Replaced all instances of Vector<DocumentMarker>::iterator with indices.

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):
12:51 PM Changeset in webkit [22941] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4987529>
Regression: first clicks don't work at flash-based Nokia.com

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Don't set buttons for mouse move. Also, ignore unknown mouse events.
11:00 AM Changeset in webkit [19642] by darin
  • 2 edits in trunk/WebKitSite
  • projects/performance/index.html: Fix i-Bench link.
10:46 AM Changeset in webkit [19641] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • tables/mozilla/bugs/bug45486-expected.checksum:
  • tables/mozilla/bugs/bug45486-expected.png:
  • tables/mozilla/bugs/bug45486-expected.txt:
  • tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Darin.

Fixes existing layout tests: tables/mozilla/bugs/bug45486.html

tables/mozilla_expected_failures/core/col_span2.html

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): Fixed a mismatch between which columns count as percentage columns when adding up the total percent and which columns count as percentage columns when converting non-percentage columns to effectively-percentage.
10:21 AM Changeset in webkit [19640] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


  • DumpRenderTree/DumpRenderTree.m: Don't ignore NSAttributedString WebCore::Node leaks anymore, either, since r19486 fixed them, too. (shouldIgnoreWebCoreNodeLeaks):
9:47 AM Changeset in webkit [19639] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't ignore NSAttributedString leaks any more. Those were fixed by change 19486.
9:29 AM Changeset in webkit [19638] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:

Feb 14, 2007:

9:51 PM Changeset in webkit [19637] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-02-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig!

  • manual-tests/background-image-change-in-page-cache.html: Added.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Bail out if the object is not in a view, which can happen if the document is in the page cache and the same cached image used for its background is also being used in another document that is currently in view.
7:17 PM Changeset in webkit [19636] by aroben
  • 10 edits
    1 copy
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

  • fast/events/frame-programmatic-focus-expected.txt: Added.
  • fast/events/frame-programmatic-focus.html: Added.
  • fast/forms/focus2-expected.txt: Updated results to now-correct behavior.

WebCore:

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

Test: fast/events/frame-programmatic-focus.html

  • dom/Element.cpp: (WebCore::Element::focus): Call FocusController::setFocusedNode to set the focus for the whole page.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Send the textInput event to the same target that was sent the keypress event before it.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Added a FIXME. (WebCore::FocusController::setFocusedNode): Added. Sets the focused node for a whole page.
  • page/FocusController.h: Added declaration.
  • platform/cf/RetainPtr.h: Removed unused pointer_cast functions.
5:15 PM Changeset in webkit [19635] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/execCommand/4976800-expected.txt: Added.
  • editing/execCommand/4976800.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): Add line breaks if removing the indented node causes content before or after it to collapse into the same paragraph as its content.
5:11 PM Changeset in webkit [19634] by justing
  • 2 edits
    8 adds in trunk

Reviewed by adele


<rdar://problem/4960120>
REGRESSION: First Enter key ignored on initial focus of textarea after page load (11967)


We'd insert a newline, but into an empty div. We need two newlines
in that case.

  • editing/InsertLineBreakCommand.cpp: (WebCore::lineBreakExistsAtPosition): Returns true if there is a br or a '\n' in text that preserves newlines at the incoming position. (WebCore::InsertLineBreakCommand::doApply): Fixed to handle the empty block case, the anonymous block case.
4:35 PM Changeset in webkit [19633] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/forms/select-enter-key-expected.txt: Added.
  • fast/forms/select-enter-key.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/forms/select-enter-key.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Add code to submit when someone hits the Enter key.
3:50 PM Changeset in webkit [19632] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4960112>
​http://bugs.webkit.org/show_bug.cgi?id=12417
REGRESSION: "Are you sure you want to send a form again?" sheet is displayed twice (validator.w3.org)


The problem was that doing a reload would cause the "Cache-Control" HTTP header to be set on the request _after_ the first
navigation policy delegate callback was called. This would break the request equality check that's used to prevent multiple policy
delegate callbacks from getting called for the same request. The solution is to set the header as early as possible.


This patch also fixes some bugs in the ResourceRequest equality operator.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Set the "Cache-Control" header field on the request here.


  • platform/network/FormData.h: (WebCore::operator==): Short-circuit if the pointers are the same.


  • platform/network/ResourceRequest.cpp: (WebCore::operator==): Check the equality of the objects, not the pointers.
3:42 PM Changeset in webkit [19631] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add new canCompareWithMemcmp vector trait and use it to determine whether
operator== can use memcmp.


  • wtf/Vector.h: (WTF::): (WTF::VectorTypeOperations::compare): (WTF::operator==):
  • wtf/VectorTraits.h: (WTF::):
3:31 PM Changeset in webkit [19630] by hyatt
  • 3 edits
    1 delete in trunk/WebCore

Move setPlatformData out of FontFallbackListMac.mm and delete the file. The function was completely
cross-platform already.

Reviewed by Ada

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontFallbackList.cpp: (WebCore::FontFallbackList::setPlatformFont):
2:29 PM Changeset in webkit [19629] by hyatt
  • 4 edits in trunk/WebCore

Make the Font constructor that takes a FontPlatformData cross-platform, since the implementation was already
completely cross-platform.

Reviewed by Ada

  • platform/Font.cpp: (WebCore::Font::Font):
  • platform/Font.h:
  • platform/mac/FontMac.mm:
1:44 PM Changeset in webkit [19628] by antti
  • 2 edits in trunk/WebCore

Reverting ​http://bugs.webkit.org/show_bug.cgi?id=11974, it causes repainting problems in some cases.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::avoidsFloats):
12:44 PM Changeset in webkit [19627] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Darin Adler, tweaked and committed by Geoff Garen.


Reverting my fix for find-after-replace.html and committing this one because
its results don't rely on an editing bug and because stomping bugzilla patches
is just plain uncivilized.

  • editing/execCommand/find-after-replace.html: Use the frame's onload handler instead of relying on a timeout. Force a layout to get a correct render tree when dumping. (This requirement may be an editing bug.)
11:02 AM Changeset in webkit [19626] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/textfield-overflow-expected.checksum: Added.
  • fast/forms/textfield-overflow-expected.png: Added.
  • fast/forms/textfield-overflow-expected.txt: Added.
  • fast/forms/textfield-overflow.html: Added.

WebCore:

Reviewed by Maciej.



Set controlClip for non-search text controls.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):
10:01 AM Changeset in webkit [19625] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Check for possible conversion failure.
9:17 AM Changeset in webkit [19624] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:
9:15 AM Changeset in webkit [19623] by brmorris
  • 2 edits in S60/trunk/WebKit

DESC: add widget registry client dll to rom image via webkit.iby
​http://bugs.webkit.org/show_bug.cgi?id=12765

9:13 AM Changeset in webkit [19622] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Beth Dakin.


Blind attempt to make this test more reliable. (It fails intermittently
on the buildbot.)

  • editing/execCommand/find-after-replace-expected.checksum:
  • editing/execCommand/find-after-replace-expected.png:
  • editing/execCommand/find-after-replace-expected.txt:
  • editing/execCommand/find-after-replace.html: Use a load event handler instead of a 100ms timer. There's no guarantee that everything will be done loading in under 100ms (and there's no reason to wait that long all the time, either!).
6:10 AM Changeset in webkit [19621] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/text/break-word-expected.checksum: Added.
  • fast/text/break-word-expected.png: Added.
  • fast/text/break-word-expected.txt: Added.
  • fast/text/break-word.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/text/break-word.html

The wrapW variable used to keep track of the width of the characters scanned
so far by adding up the widths of individual characters. Because of the
rounding hack, the total ended up being bigger than the width of the same characters
when measured together as a single run.

The fix is to use wrapW only as an upper bound, and once it overflows the line's width,
fall back on measuring everything from the beginning of the line as one run.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Implemented the above fix, including not measuring additional single characters once wrapW overflows the line. Also moved the assignment to breakNBSP out of the loop since it is constant for the entire text object, made breakWords and midWordBreak update only when they might change, and cleaned up a few things.
2:52 AM Changeset in webkit [19620] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/forms/password-placeholder-expected.checksum: Added.
  • fast/forms/password-placeholder-expected.png: Added.
  • fast/forms/password-placeholder-expected.txt: Added.
  • fast/forms/password-placeholder.html: Added.

WebCore:

Reviewed by Hyatt.


Disable textSecurity when placeholder is visible.


  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updatePlaceholder):

Feb 13, 2007:

10:31 PM Changeset in webkit [22940] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Send tab keypresses to IWebFormDelegate::doCommandBySelector.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
9:23 PM Changeset in webkit [19619] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=12763
REGRESSION: button title is displayed incorrectly at quotes.burntelectrons.org

Test: fast/parser/entities-in-attributes.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Set a correct type for the found entity (I'm not really sure if XML_INTERNAL_GENERAL_ENTITY is _the_ correct one, but it fixes the problem).
8:10 PM Changeset in webkit [22939] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

Switch permanently from CFStreamError to CFErrorRef in ResourceHandleCF

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::start):
7:11 PM Changeset in webkit [19618] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • fast/dom/Window/window-properties-expected.txt: Update results.
6:05 PM Changeset in webkit [19617] by darin
  • 10 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed some bogus names (Hyatt smacked me since this doesn't fix a P1)
  • dom/EventNames.h: Removed half-implemented khtmlDragdrop and khtmlMove (you could add listeners, but nobody ever sent the events). Renamed the other two khtml-prefixed internal event names to use the webkit prefix.
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): Removed ondragdrop and onmove. (KJS::DOMEventTargetNode::putValueProperty): Ditto.
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::put): Ditto.
  • bindings/js/kjs_window.h:
  • dom/BeforeTextInsertedEvent.cpp: (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent): Renamed to webkit.
  • editing/Editor.cpp: (WebCore::dispatchEditableContentChangedEvents): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Ditto.
5:39 PM Changeset in webkit [19616] by darin
  • 2 edits in trunk/WebCore

Rubber stamped by Maciej.

  • dom/EventNames.h: Resort names. Removed unused names.
5:24 PM Changeset in webkit [22938] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:23 PM Changeset in webkit [19615] by sfalken
  • 1 copy in tags/Safari-521.34.4b

New tag.

2:57 PM Changeset in webkit [19614] by oliver
  • 2 edits in trunk/WebKit

2007-02-13 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Modify entry point ASSERTs for dragging functions to allow for the case
where a load has occurred mid-drag. The load may detach the HTMLView
from the WebView so it is no longer possible to check _isTopHTMLView.

The assertion changes match that of revision 14897 which fixed the
more common case ([WebHTMLView draggedImage:endedAt:operation:])

It's also necessary to check for a null Page now prior to accessing
the DragController, which is necessary in all of these methods.

See rdar://problem/4994870


  • WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2:44 PM Changeset in webkit [22937] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Remove SVGDOMImplementation.(cpp|h)
2:19 PM Changeset in webkit [19613] by beidson
  • 2 edits in trunk/JavaScriptCore

Tweaked Vector a bit

1:47 PM Changeset in webkit [19612] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

  • http/tests/misc/redirect-to-about-blank-expected.txt: Added.
  • http/tests/misc/redirect-to-about-blank.html: Added.
  • http/tests/misc/resources/redirect-to-about-blank.php: Added.

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

The problem is that redirecting to about:blank causes the delegate to be released even though the load wasn't finished.
This is usally not a problem since NSURLConnection retains its delegate. However, the proxy delegate does not retain _it's_
delegate. The solution is to make releaseDelegate clear out the proxy delegate's delegate.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::releaseDelegate): If there's a proxy, nil out its delegate too.
1:28 PM Changeset in webkit [19611] by brmorris
  • 5 edits in S60/branches/3.1m/WebCore

bujtas, reviewed by yongjun

DESC: merging trunk r16319 to s60/3.1m PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

1:11 PM Changeset in webkit [19610] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Correcting ChangeLog entry (thx Mitz!).

1:06 PM Changeset in webkit [19609] by ap
  • 1 edit
    4 deletes in trunk/LayoutTests

Actually removed pixel results that were supposed to be removed three
weeks ago, in r12290.

  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.
  • fast/parser/head-comment-expected.png: Removed.
11:31 AM Changeset in webkit [19608] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Use kCFStringEncodingUTF8.
11:23 AM Changeset in webkit [19607] by beidson
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by The Spirit of Layout Test Fixing!

Re-added a directory and some files Darin removed that one of my layout tests
relied on.

  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added.
10:32 AM Changeset in webkit [19606] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/Vector.h: fixed comparison operators (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Darin.

  • rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion. The only reason this compiled before was that the comparing two vectors with a != was simply comparing the pointers.
10:16 AM Changeset in webkit [19605] by darin
  • 519 edits
    1 delete in trunk/LayoutTests
  • update test results for Hyatt's focus node enhancement (fix for 12149) 518 of tests had extra "begin editing" delegate callbacks.
  • editing: Updated test results of many tests in this directory.
  • removed tests for rolled-out fix for rdar://problem/4922454
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Removed.
  • http/tests/security/local-JavaScript-from-remote.html: Removed.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Removed.
  • http/tests/security/local-iFrame-from-remote.html: Removed.
  • http/tests/security/local-image-from-remote-expected.txt: Removed.
  • http/tests/security/local-image-from-remote.html: Removed.
  • http/tests/security/resources/compass.jpg: Removed.
  • http/tests/security/resources/green250x50.png: Removed.
  • http/tests/security/resources/localPage.html: Removed.
  • http/tests/security/resources/localScript.js: Removed.
  • http/tests/security/resources/red200x100.png: Removed.
  • http/tests/security/resources/showRefererImage.php: Removed.
10:11 AM Changeset in webkit [19604] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix wording of a change log comment.

9:58 AM Changeset in webkit [19603] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fix a bug where --reset-results output would all go in one giant line.
9:52 AM Changeset in webkit [19602] by darin
  • 2 edits in trunk/WebCore
  • roll out fix for <rdar://problem/4874059> REGRESSION: Painter IX:register -
Crash in WebCore
ResourceLoader::willSendRequest()

This fix was causing a crash in at least one layout test.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
5:09 AM Changeset in webkit [19601] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/lists/item-not-in-list-line-wrapping-expected.checksum: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.png: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/lists/item-not-in-list-line-wrapping.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Use the list marker's isInside() instead of looking at its style()->listStylePosition(), since if the list item is not in a list, the marker is inside regardless of the style.
3:02 AM Changeset in webkit [19600] by rwlbuis
  • 13 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12578
WebKit incorrectly strokes zero-width/height rectangles

Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.

2:05 AM Changeset in webkit [19599] by rwlbuis
  • 3 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove SVGDOMImplementation from the project.

1:52 AM Changeset in webkit [19598] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.


  • fixed to still be a valid test (wouldn't crash without the relevant fix).
  • fast/text/text-shadow-extreme-value.html:
12:59 AM Changeset in webkit [19597] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Adam

Fixes <rdar://problem/4985497> - Crash when opening a new window to "Same Page"

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null check documentLoader() since if we're a brand new WebView, cloning the history of another view, we have no documentLoader()
12:55 AM Changeset in webkit [19596] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

-fix REGRESSION: <select disabled size="5"> listbox cannot be scrolled
​http://bugs.webkit.org/show_bug.cgi?id=11852
<rdar://problem/4960129>


Pass mouse press events to scrollbars even if event is swallowed.


No layout test, DumpRenderTree eventSender can't hit scrollbars.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):

Feb 12, 2007:

8:49 PM Changeset in webkit [19595] by hyatt
  • 7 edits in trunk/WebCore

Fix for bug 12149 (Radar Bug#4928692), external CSS causes incomplete
text field focus.

Make sure to clear out the focus node in willRemove() rather than in
detach(), since detach/attach caused by style recalc should not affect
the focused node.

Reviewed by aroben

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):
  • dom/Document.cpp: (WebCore::Document::focusedNodeRemoved): (WebCore::Document::setFocusedNode):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Node.cpp: (WebCore::Node::willRemove): (WebCore::Node::detach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance):
8:46 PM Changeset in webkit [19594] by bdash
  • 2 edits in trunk/WebKit

2007-02-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Timothy Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12745
Bug 12745: REGRESSION: Webkit will not load a plugin that Safari can load (symbol missing _objc_msgSend_fpret)

Treat libobjc as a sub-library of WebKit in Debug/Release so that plugins and applications linked against an
umbrella framework version of WebKit that expect to find libobjc symbols in WebKit can do so.

  • WebKit.xcodeproj/project.pbxproj:
5:41 PM Changeset in webkit [19593] by bdash
  • 118 edits
    8 deletes in trunk

Rolling out r19588 as it caused a build failure and a hang in layout tests after the obvious build fix was applied.

5:37 PM Changeset in webkit [19592] by bdash
  • 1 edit in tags/Safari-521.34.1/WebKit/Info.plist

Versioning.

5:35 PM Changeset in webkit [19591] by bdash
  • 2 edits in tags/Safari-521.34.1/WebKit

Merge in r19484.

5:35 PM Changeset in webkit [19590] by kmccullo
  • 21 edits
    6 deletes in trunk

LayoutTests:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • fast/loader/local-JavaScript-from-local-expected.txt: Removed.
  • fast/loader/local-JavaScript-from-local.html: Removed.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Removed.
  • fast/loader/local-iFrame-source-from-local.html: Removed.
  • fast/loader/local-image-from-local-expected.txt: Removed.
  • fast/loader/local-image-from-local.html: Removed.

WebCore:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • bindings/objc/DOM.mm: (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender): (WebCore::CachedImage::isErrorImage):
  • loader/CachedResource.h:
  • loader/CachedScript.h: (WebCore::CachedScript::errorOccurred):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: (WebCore::RenderImage::isErrorImage):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::isImage):

WebKit:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
5:23 PM Changeset in webkit [19589] by bdash
  • 1 copy in tags/Safari-521.34.1

New tag.

3:57 PM Changeset in webkit [22936] by adachan
  • 12 edits in branches/WindowsMerge

2007-02-12 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Steve.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Frame::doTextFieldCommandFromEvent()'s signature has changed from taking in a PlatformKeyboardEvent
to KeyboardEvent. Match that in FrameWin.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::doTextFieldCommandFromEvent):
  • bridge/win/FrameWin.h:


WebKitWin:

Reviewed by Steve.


Also, checked in a fix in WebContextMenuClient that Adam made on my machine, reviewed by me.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Inform form delegate about delete key press.


DOM event fixes:

  • Removed DOMEventTarget class.
  • IDOMEventTarget no longer extends IDOMObject
  • DOMNode now implements IDOMEventTarget
  • DOMEvent::CoCreateInstance creates the correct subclasses of DOMEvents based on the type of event
  • Added IDOMDocumentEvent interface, which DOMDocument implements.
  • Fixed the out parameter in IDOMUIEvent::view to be IDOMWindow


Implemented DOMHTMLDocument::body and DOMHTMLElement::setInnerText.

  • DOMCoreClasses.cpp: (DOMNode::addEventListener): added as DOMNode now needs to implement IDOMEventTarget (DOMNode::removeEventListener): ditto above (DOMNode::dispatchEvent): ditto above (DOMDocument::QueryInterface): DOMDocument now also implements IDOMDocumentEvent (DOMDocument::createEvent): added as DOMDocument implements IDOMDocumentEvent (DOMElement::focus): implemented
  • DOMCoreClasses.h:
  • DOMEventsClasses.cpp: (DOMEvent::DOMEvent): The data member m_event is now a RefPtr, and the WebCore::Event is now passed into the constructor via a PassRefPtr. (DOMEvent::~DOMEvent): No longer need to deref m_event since we are using a RefPtr. (DOMEvent::createInstance): instantiate the correct DOMEvent subclass based on event type. (DOMEvent::QueryInterface): be able to QI IID_DOMEvent, which returns back the DOMEvent type. (DOMUIEvent::view): fixed the API (DOMKeyboardEvent::ctrlKey): call .get() on RefPtr (DOMKeyboardEvent::shiftKey): ditto above (DOMKeyboardEvent::altKey): ditto above (DOMKeyboardEvent::metaKey): ditto above (DOMKeyboardEvent::altGraphKey): ditto above (DOMMouseEvent::ctrlKey): ditto above (DOMMouseEvent::shiftKey): ditto above (DOMMouseEvent::altKey): ditto above (DOMMouseEvent::metaKey): ditto above
  • DOMEventsClasses.h: (DOMEvent::coreEvent): Added an API to get the WebCore::Event out of a DOMEvent. Used in DOMNode::dispatchEvent. (DOMUIEvent::DOMUIEvent): made public so it can be called in DOMEvent::createInstance (DOMKeyboardEvent::DOMKeyboardEvent): ditto above (DOMKeyboardEvent::view): fixed API (DOMMouseEvent::DOMMouseEvent): made public so it can be called in DOMEvent::createInstance (DOMMouseEvent::view): fixed API (DOMMutationEvent::DOMMutationEvent): made public so it can be called in DOMEvent::createInstance (DOMOverflowEvent::DOMOverflowEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::DOMWheelEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::view): fixed API
  • DOMHTMLClasses.cpp: (DOMHTMLDocument::body): (DOMHTMLElement::setInnerText):
  • Interfaces/DOMEvents.idl: IDOMEventTarget no longer extends IDOMObject. Added IDOMDocumentEvent.
  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): check for error from calling contextMenuItemsForElement.
  • WebFrame.cpp: (WebFrame::textWillBeDeletedInTextField): call form delegate callback doCommandBySelector with VK_BACK when deleting text.


3:52 PM Changeset in webkit [19588] by bdash
  • 120 edits
    8 adds in trunk

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • css1/formatting_model/inline_elements-expected.checksum:
  • css1/formatting_model/inline_elements-expected.png:
  • css1/formatting_model/inline_elements-expected.txt:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • css2.1/t0905-c414-flt-02-c-expected.txt:
  • css2.1/t0905-c414-flt-03-c-expected.txt:
  • css2.1/t0905-c414-flt-04-c-expected.txt:
  • css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • fast/block/float/008-expected.txt:
  • fast/block/float/013-expected.checksum:
  • fast/block/float/013-expected.txt:
  • fast/block/float/029-expected.txt:
  • fast/block/float/031-expected.txt:
  • fast/block/float/float-in-float-painting-expected.txt:
  • fast/block/margin-collapse/059-expected.checksum:
  • fast/block/margin-collapse/059-expected.png:
  • fast/block/margin-collapse/059-expected.txt:
  • fast/block/margin-collapse/062-expected.txt:
  • fast/block/margin-collapse/063-expected.txt:
  • fast/box-shadow/basic-shadows-expected.txt:
  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/floating-textfield-relayout-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/media/mq-relative-constraints-08-expected.txt:
  • fast/multicol/float-multicol-expected.txt:
  • fast/repaint/float-overflow-expected.checksum: Added.
  • fast/repaint/float-overflow-expected.png: Added.
  • fast/repaint/float-overflow-expected.txt: Added.
  • fast/repaint/float-overflow-right-expected.checksum: Added.
  • fast/repaint/float-overflow-right-expected.png: Added.
  • fast/repaint/float-overflow-right-expected.txt: Added.
  • fast/repaint/float-overflow-right.html: Added.
  • fast/repaint/float-overflow.html: Added.
  • fast/table/009-expected.checksum:
  • fast/table/009-expected.png:
  • fast/table/009-expected.txt:
  • fast/text/text-shadow-extreme-value.html:
  • fast/text/whitespace/012-expected.txt:
  • tables/mozilla/bugs/bug120364-expected.txt:
  • tables/mozilla/bugs/bug196870-expected.checksum:
  • tables/mozilla/bugs/bug196870-expected.png:
  • tables/mozilla/bugs/bug196870-expected.txt:
  • tables/mozilla/bugs/bug45055-2-expected.txt:
  • tables/mozilla/bugs/bug72359-expected.txt:
  • tables/mozilla/marvin/x_table_align_left-expected.txt:
  • tables/mozilla/marvin/x_table_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
3:36 PM Changeset in webkit [19587] by darin
  • 16 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • update pixel results in cases where overline and line-through were used, because our old code put them 1px too low
  • css1/cascade/cascade_order-expected.checksum: Updated because this has line-through style.
  • css1/cascade/cascade_order-expected.png: Ditto.
  • css1/text_properties/text_decoration-expected.checksum: Updated because this has overline and line-through.
  • css1/text_properties/text_decoration-expected.png: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Ditto.
  • fast/text/stroking-decorations-expected.checksum: Ditto.
  • fast/text/stroking-decorations-expected.png: Ditto.
  • added some missing pixel-test results
  • fast/forms/disabled-select-change-index-expected.checksum: Added.
  • fast/forms/disabled-select-change-index-expected.png: Added.

WebCore:

Reviewed by Hyatt.

  • fix bug where overline and line-through were 1px lower than we intended
  • platform/graphics/GraphicsContext.h: Removed unneeded y offset parameter.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText): Removed bogus y offset and +1.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): Added the "+1" that used to be inside drawLineForText to the underline-drawing code. Changed the other callers of drawLineForText to include the y offset in the y coordinate.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Ditto. Also renamed _tx and _ty to remove the gratuitious underscores. (WebCore::InlineTextBox::paintMarkedTextUnderline): Made the default thickness be 1px instead of 0 (which ends up being roughly 1px in the CG code path anyway). Fixed the code computing the position to put the underline at the bottom of the line (different from regular underlines which are put 1px under the baseline). The old code used to put the underline 1px further down in the thick case, and 2px further down in the non-thick case. Both of those are bad, because they could be completely clipped out in many cases.
3:35 PM Changeset in webkit [19586] by brmorris
  • 5 edits in S60/trunk/WebCore

zalan, Reviewed by yongjun.

DESC: merging WebKit/trunk r16319 to s60/trunk PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. See ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

3:31 PM Changeset in webkit [19585] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.

DESC: [S60] Web page teamwork.com not displayed on 3.1 browser AKKO-6XGJZT
Fix: Insert html node if the main document element is not available (document starts

with comment element)

​http://bugs.webkit.org/show_bug.cgi?id=12683

3:24 PM Changeset in webkit [19584] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • fast/dom/Document/replace-child-expected.txt: Added.
  • fast/dom/Document/replace-child.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Call checkReplaceChild here.


  • dom/Document.cpp: (WebCore::Document::canReplaceChild):
  • dom/Document.h: Add implementation of canReplaceChild that makes sure that doing the replacement won't cause more than one element and document type node to end up in the document.


  • dom/Node.cpp: (WebCore::Node::canReplaceChild): Base implementation of canReplaceChild.


(WebCore::Node::checkReplaceChild):
New function that does what checAddChild does but calls canReplaceChild.

3:01 PM Changeset in webkit [19583] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4874059> REGRESSION: Painter IX:register - …
ResourceLoader::willSendRequest() What happened here was that a WebDataSource was being dealloced *while* a load for that resource is still in progress.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): Calling stopAllLoaders cancels loads and informs the frame load delegate accordingly. The delegate however may decide to kick off a new provisional load as the result of the cancel. Therefore a local variable for the provisional and main doucment loader is introduced, and we now only nil out the provisional loader if the local and member provisional variables represent the exact same load. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Added the same check here, too.
1:41 PM Changeset in webkit [19582] by lars
  • 8 edits
    2 adds in trunk

Reviewed by Mitz.

Do not create child renderers for table column groups
if the child has not a table column display type.

12:28 PM Changeset in webkit [19581] by antti
  • 2 edits in trunk/WebCore

Reviewed by Mitz

Fix assertion failure in layout test.

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
11:58 AM Changeset in webkit [19580] by kmccullo
  • 3 edits in trunk/WebCore

Reviewed by Brady.

  • Fixing a performance regression caused by r19500. The heart of the matter is that we now call canLoad on every resource request even ones in the cache, to avoid a security issue. So I could not take out the canLoad call, but I but I could try to make it more efficient.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
11:05 AM Changeset in webkit [19579] by darin
  • 29 edits in trunk

WebCore:

Reviewed by Oliver.

This area still needs work because keypress events are being sent for all the
events before they go to the input methods, and it seems that this is not
compatible with what other browsers do and with what sites assume. That's covered
by this bug:

​http://bugs.webkit.org/show_bug.cgi?id=10871
<rdar://problem/4823129> REGRESSION: IME key events different in nightly (10871)

which is still open.

  • bindings/objc/ExceptionHandlers.h: Remove selectRange helper that doesn't really belong here, and also isn't needed since the callers don't want to raise ObjC exceptions.
  • bindings/objc/ExceptionHandlers.mm: Ditto. Also removed unneeded external globals that aren't exported anyway and unneeded includes.
  • bridge/EditorClient.h: Added Mac-specific function, markedTextAbandoned. Long term this might move into platform instead, but it's fine to have it on the client for now as long as it doesn't cause trouble for platforms other than Mac.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Since all the event handling code in this function is intended to run on the node itself, not parent nodes, check and do nothing if this event is bubbling up from another node. Added code to call a function on EventHandler for default handling of text input events.
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.cpp: (WebCore::findKeyboardEvent): Added. Just like the findUIEventWithKeyState function, but specific to keyboard events.
  • dom/TextEvent.h: Added isLineBreak and isBackTab flags so that we can carry additional information about what a text input event is trying to do, but still go through the DOM event machinery.
  • dom/TextEvent.cpp: Ditto.
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::canEdit): Ditto. (WebCore::Editor::canEditRichly): Ditto. (WebCore::Editor::canPaste): Changed to call canEdit for brevity. (WebCore::Editor::replaceSelectionWithText): Changed to take a const String&. (WebCore::Editor::shouldInsertText): Ditto. (WebCore::hasEditableSelection): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::Editor): Initialize the new m_ignoreMarkedTextSelectionChange flag. Moved here from WebHTMLView. (WebCore::Editor::insertText): Moved most of the code from -[WebHTMLView insertText:] here, since this needs to be done in response to a text input event and we don't want to go back over the WebKit side for that. (WebCore::Editor::insertLineBreak): Added. Moved here from -[WebHTMLView insertLineBreak:] for the same reason -- needs to be done in response to text input events. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::selectMarkedText): Added. Used by insertText. (WebCore::Editor::discardMarkedText): Added. Used by insertText. (WebCore::Editor::unmarkText): Added. Used by insertText.
  • editing/mac/EditorMac.mm: (WebCore::Editor::unmarkText): Added. Used by insertText.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): Changed to use isTextField to avoid repeating the switch statement. (WebCore::HTMLInputElement::selectionStart): Ditto. (WebCore::HTMLInputElement::selectionEnd): Ditto. (WebCore::HTMLInputElement::setSelectionStart): Ditto. (WebCore::HTMLInputElement::setSelectionEnd): Ditto. (WebCore::HTMLInputElement::select): Ditto. (WebCore::HTMLInputElement::setSelectionRange): Ditto. (WebCore::HTMLInputElement::createRenderer): Resorted cases alphaebtically. (WebCore::HTMLInputElement::defaultEventHandler): Added code to make hitting return cause the form to be submitted when it comes through as a text input event. This is now the normal case on Macintosh, because enter key presses normally turn into this. In addition, change the other event handling to run only after trying the base defaultEventHandler. That makes the key handling done in EventTargetNode take precedence over the event handling here for editable text fields, which is what we want. This gets rid of the need for the hack where we check inputManagerHasMarkedText and suppress the handling of the enter key.
  • page/EventHandler.h: Removed unneeded includes. Moved EventHandlerDragState down into the private part of the class. Changed sendContextMenuEvent to take a const&. Added new handleTextInputEvent and defaultTextInputEventHandler functions. Made eventLoopHandleMouseUp and eventLoopHandleMouseDragged private. Added private defaultTabEventHandler function.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Changed parameter to be a const&. (WebCore::EventHandler::defaultKeyboardEventHandler): Rearranged things so that the key bindings handling in handleKeyPress comes before special tab event handling. In cases where the tab turns into text to insert, we now handle it in the text input event handler. (WebCore::EventHandler::handleTextInputEvent): Added. Creates and dispatches a text input event. (WebCore::EventHandler::defaultTextInputEventHandler): Added. Inserts text, but has special cases for the tab and newline character cases. (WebCore::EventHandler::defaultTabEventHandler): Added. Shared by the tab-handling code in the keyboard event and text input event handlers.
  • page/mac/EventHandlerMac.mm: Tweak formatting, remove some unused functions.
  • page/FocusController.h: Removed unnneded includes and forwards, and added an overload of advanceFocus that takes a FocusDirection parameter.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Changed to allow a 0 for the event pointer. Also added a version where the direction is passed explicitly, to be used for cases where we want to tab backward even if the event doesn't have a shift modifier key set.
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to EditorClient. This should really probably just use 0 for the EditorClient.
  • WebCore.exp: Update both for newly used and no-longer-used entry points.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed two unused methods.

WebKit:

Reviewed by Oliver.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::markedTextAbandoned): Added.
  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Added explicit constructor needed now that the function takes a const&. (-[WebHTMLView becomeFirstResponder]): Removed fake event code, no longer needed since advanceFocus now works fine with 0 for a DOM event. (-[WebHTMLView _expandSelectionToGranularity:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView insertTab:]): Changed to call bottleneck that receives the DOM event. (-[WebHTMLView insertBacktab:]): Ditto. (-[WebHTMLView insertNewline:]): Ditto. (-[WebHTMLView insertLineBreak:]): Ditto. (-[WebHTMLView insertParagraphSeparator:]): Ditto. (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): Ditto. (-[WebHTMLView insertTabIgnoringFieldEditor:]): Ditto. (-[WebHTMLView yank:]): Updated to call Editor directly since the insertText code now works via a text input event which is not what we want for paste-like things such as yank. (-[WebHTMLView yankAndSelect:]): Ditto. (-[WebHTMLView selectToMark:]): Changed to use the normal selection controller function instead of selectRange, which also allows us to remove the ObjC exception handling code. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView transpose:]): Ditto. (-[WebHTMLView unmarkText]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Moved the actual work into the Editor class in WebCore and just call that from here. (-[WebHTMLView _selectRangeInMarkedText:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView setMarkedText:selectedRange:]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Also changed the ignoreMarkedTextSelectionChange to use the flag over on the WebCore side, since we moved it there and to call selectMarkedText over on the WebCore side too. (-[WebHTMLView doCommandBySelector:]): Added special cases for newline and tab selectors so that the event is passed along. These selectors are special because they are ones that turn into text input events. (-[WebHTMLView _discardMarkedText]): Moved the body of this function into the Editor class in WebCore and just call that from here. (-[WebHTMLView insertText:]): Added code to send a text input event instead of calling the editor to do text insertion. The insertion is then done in the default handler for the text input event. (-[WebHTMLView _insertNewlineWithEvent:isLineBreak:]): Added. Sends a text input event. (-[WebHTMLView _insertTabWithEvent:isBackTab:]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the ignoreMarkedTextSelectionChange flag in Editor now that the one here is gone.
  • WebView/WebHTMLViewInternal.h: Remove ignoreMarkedTextSelectionChange field.
  • WebView/WebView.mm: (-[WebView setSelectedDOMRange:affinity:]): Changed to use the normal selection controller function instead of selectRange.
10:07 AM Changeset in webkit [19578] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin

  • fast/images/imagemap-case-expected.checksum: Added.
  • fast/images/imagemap-case-expected.png: Added.
  • fast/images/imagemap-case-expected.txt: Added.
  • fast/images/imagemap-case.html: Added.

WebCore:

Reviewed by Darin.


Make imagemap names case insensitive in HTML mode

  • dom/Document.cpp: (WebCore::Document::getImageMap):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
9:15 AM Changeset in webkit [19577] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results for this failing test. It looks like Maciej generated
the original results before he made the test "dump as text."

  • fast/text/text-shadow-extreme-value-expected.txt:
7:28 AM Changeset in webkit [19576] by brmorris
  • 5 edits in S60/trunk/WebKit

bujtas, Reviewed by Yongjun, merged by Brad.

DESC: Merge of r19540 to s60/trunk: Can not open the Browser application ALES-6Y9GG7
fix: delay formmanager construct
​http://bugs.webkit.org/show_bug.cgi?id=12714

6:59 AM Changeset in webkit [19575] by brmorris
  • 3 edits in S60/trunk/WebKit

yaharon, reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

6:56 AM Changeset in webkit [19574] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, reviewed by <​yongjun.zhang@nokia.com>.

DESC: Squares are displayed instead of characters for Greek web pages.
​http://bugs.webkit.org/show_bug.cgi?id=11469

3:59 AM Changeset in webkit [19573] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Antti.



  • fast/text/text-shadow-extreme-value.html: Added.
  • fast/text/text-shadow-extreme-value-expected.txt: Added.

WebCore:

Reviewed by Antti.


Test: fast/text/text-shadow-extreme-value.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to make CG unhappy.

Feb 11, 2007:

11:37 PM Changeset in webkit [19572] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Maciej

First in what will be a series of HistoryItem enhancements to help debugging

  • history/HistoryItem.cpp: (WebCore::HistoryItem::showTree): (WebCore::HistoryItem::showTreeWithIndent): (showTree): Outside of WebCore namespace, and extern "C" - to make even the DWARF debugger able to find it... *sigh*
  • history/HistoryItem.h:
11:21 PM Changeset in webkit [19571] by mjs
  • 7 edits
    2 adds in trunk

LayoutTests:

Test case not reviewed; based on manual test by David Kilzer.


  • svg/custom/use-events-crash.svg: Added.

WebCore:

Reviewed by Anders.


Test: svg/cust/use-events-crash.svg

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::toNode):
  • ksvg2/svg/SVGElementInstance.h:

WebKitTools:

Reviewed by Mitz.


  • add contextClick() operation to eventSender to be able to test this
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController contextClick]):
11:06 PM Changeset in webkit [19570] by bdash
  • 13 edits
    3 adds in trunk/LayoutTests

Binary portion of patch landed in r19490 that I forgot to land.

8:47 PM Changeset in webkit [22935] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Fixing line endings.

  • WebResource.cpp:
  • WebResource.h:
8:06 PM Changeset in webkit [19569] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/text/delete-hard-break-character-expected.checksum: Added.
  • fast/text/delete-hard-break-character-expected.png: Added.
  • fast/text/delete-hard-break-character-expected.txt: Added.
  • fast/text/delete-hard-break-character.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/text/delete-hard-break-character.html

The bug was caused by not updating a line whose line break object and offset
has been deleted. When deleting text, all lines containing the deleted text
are marked dirty. However, if the first character being deleted is a newline
which serves as a hard line break for the previous line, then that line will
not be marked, and since it will be a clean line ending with a line break,
relayout will begin at the next line. The fix is to check for this when
determining where to relayout from.

  • rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Changed the condition for including the last clean line in relayout to include the case where the last clean line ends with a line break, but that line break is a newline that has been deleted.
5:19 PM Changeset in webkit [19568] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Mark.

Switch the initial value of box-sizing property from "border-box" to "content-box".

4:18 PM Changeset in webkit [19567] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: Google Calendar cell highlight misplaced
​http://bugs.webkit.org/show_bug.cgi?id=12687

  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: Google Calendar cell highlight misplaced
​http://bugs.webkit.org/show_bug.cgi?id=12687


Make offsetLeft/offsetTop/offsetParent behavior match Firefox.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop): (WebCore::RenderObject::offsetParent):
3:50 PM Changeset in webkit [19566] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: No day/week scrollbar in Google Calendar
​http://bugs.webkit.org/show_bug.cgi?id=11985

  • fast/layers/overflow-scroll-auto-switch-expected.checksum: Added.
  • fast/layers/overflow-scroll-auto-switch-expected.png: Added.
  • fast/layers/overflow-scroll-auto-switch-expected.txt: Added.
  • fast/layers/overflow-scroll-auto-switch.html: Added.

WebCore:

Reviewed by Maciej.

Make sure overflow:auto scrollbars are always enabled. If they were overflow:scroll
and dynamically changed to auto they might still be disabled.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
10:28 AM Changeset in webkit [19565] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/check-for-global-initializers: Fix case where executable doesn't exist at all so it doesn't give a perl exception (happens in clean builds, for example).
1:05 AM Changeset in webkit [19564] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12581
XPath title shouldn't match <title> in XHTML

Test: fast/xpath/ensure-null-namespace.xhtml

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Only let a null namespace match any for HTML.
12:28 AM Changeset in webkit [19563] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12701
REGRESSION: After javascript, onChange not triggered when selecting same option

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Remember m_lastOnChangeIndex value, as it can change from setSelected() now. (WebCore::HTMLSelectElement::notifyOptionSelected): Update m_lastOnChangeIndex.
  • manual-tests/select-onchange-after-js.html: Added. Also tests for bug 11402.

Feb 10, 2007:

11:31 PM Changeset in webkit [22934] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Oliver.

10:01 PM Changeset in webkit [22933] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4989705> Loading eBay puts many items into back list

The bug was that WebFrame::createFrame was calling loadRequest on the
new child frame, which would initiate a load of FrameLoadTypeStandard,
when in fact we wanted to do a FrameLoadTypeInternal load. I ported
-[WebFrame _loadURL:referrer:intoChild:] to WebFrame, which contains
the logic we need.

  • WebFrame.cpp: (WebFrame::createFrame): Use a COMPtr to manage the new WebFrame, and call loadURLIntoChild instead of just calling loadRequest. (WebFrame::loadURLIntoChild): Ported from Mac WebFrame.
  • WebFrame.h: Added declaration.
6:59 PM Changeset in webkit [19562] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

  • Scripts/svn-create-patch: (findSourceFileAndRevision($)): Use File::Spec->abs2rel() instead of substr() to generate a relative path to the copied file.
6:32 PM Changeset in webkit [19561] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

  • Drosera/Drosera.icns: updated the icon with 512px and 256px variants
6:29 PM Changeset in webkit [19560] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy.

  • Scripts/svn-apply: Binary patches don't need a trailing newline after the base64 encoded text.
6:17 PM Changeset in webkit [19559] by ddkilzer
  • 5 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • bindings/jni/jni_utility.h: added new type for array, array_type
  • bindings/jni/jni_runtime.cpp: add support for new array type (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_utility.cpp: add support for new array type (KJS::Bindings::callJNIMethod): (KJS::Bindings::callJNIStaticMethod): (KJS::Bindings::callJNIMethodIDA): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertArrayInstanceToJavaArray): new method converts the Javascript array to the requested Java array. (KJS::Bindings::convertValueToJValue):

WebCore:

Reviewed by Maciej.

Manual tests for ​http://bugs.webkit.org/show_bug.cgi?id=12636
Call different Java methods that take a variety of Array parameters
from Javascript, passing a Javascript array.

  • manual-tests/liveconnect-applet-array-parameters.html: Added.
  • manual-tests/resources/ArrayParameterTestApplet.class: Added.
  • manual-tests/resources/ArrayParameterTestApplet.java: Added.
6:06 PM Changeset in webkit [19558] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

Test adapted from Python-based 4XPath test suite,
<​http://sourceforge.net/projects/foursuite/>

  • fast/xpath/namespace-nodes-expected.txt: Added.
  • fast/xpath/namespace-nodes.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Namespace axis enumeration was broken in that it crashed, and also in that it returned attribute nodes instead of XPath namespace ones. Removed it altogether.
5:05 PM Changeset in webkit [19557] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): Changed the string length math to avoid truncating the last character of each value.
  • manual-tests/svg-animation-parseValues.svg: Added.
5:01 PM Changeset in webkit [19556] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

No automated test case because dumping the render tree updates layer positions anyway.

  • manual-tests/slider-thumb-tracking.html: Added.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setCurrentPosition): Added call to updateLayerPosition() for the thumb's layer.
4:52 PM Changeset in webkit [19555] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Adam.

  • fast/events/frame-click-focus-expected.txt: Update results to include main frame blur.
  • fast/events/frame-click-focus.html: Update to click in main frame first.
6:00 AM Changeset in webkit [19554] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebInspector/webInspector/inspector.css: Added the search field to the undraggable dashboard-region.
2:38 AM Changeset in webkit [19553] by beidson
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

Added a new category of http tests - "local" where the test is run as a local file but
the test involves remote resources from the httpd.
This test had to be done with cached subresources to tickle the code path that was failing before,
hence the bizarre different-sized images instead of simple success/failure text

  • http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • http/tests/local/file-url-sent-as-referer.html: Added - document.writes an img source that ends up testing the http-referer
  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added - By scanning the referrer, sends back either the success or failure image

WebCore:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): In SubresourceLoader::create(), we make a copy of the original request to use for the load. We then call FrameLoader::canLoad() which tells us if we should hide the referer. Before this fix if it said to hide the referrer, we would simply not apply a new referrer to our copy of the request. But if the original request already had a referrer, so did our copy. We simply have to clear the referrer from the copied request.

WebKitTools:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • Scripts/run-webkit-tests: Enhanced the http tests so that we can run layout tests on local files, but have an httpd for remote resources
2:35 AM Changeset in webkit [19552] by mjs
  • 3 edits
    1 add in trunk/LayoutTests
  • add missing result and update tests to work right from DumpRenderTree
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt: Added.
  • fast/dom/Window/window-appendages-cleared.html:
1:12 AM Changeset in webkit [19551] by mjs
  • 4 edits
    2 adds in trunk

LayoutTests:

Regression not reviewed, based loosely on test case from Ian Eng.

  • test case for <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


  • fast/dom/Window/resources/window-appendages-cleared-results.html: Added.
  • fast/dom/Window/window-appendages-cleared.html: Added.

WebCore:

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:

Feb 9, 2007:

9:15 PM Changeset in webkit [22932] by sfalken
  • 7 edits in branches/WindowsMerge/WebKitWin

Land Maciej's patch so I can check in.
(Looks like he forgot, since he did move the bug to integrate)

5:57 PM Changeset in webkit [22931] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): The scrollview's scrolloffset wasn't getting set in cases where there were no scrollbars You can have a scrolloffset even if you don't have scrollbars

WebKitWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
fix depends on corresponding fix in WebCoreWin

  • WebView.cpp: (WebViewWndProc): call the editor to handle inserting text and scrolling/focus changes
5:39 PM Changeset in webkit [19550] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4985497> - Plugs a potential null DocumentLoader deref when
transitioning out of the Bookmarks View

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveGoToItem): add a null check
4:58 PM Changeset in webkit [19549] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin & Maciej.

Fixed: <rdar://problem/4930688> REGRESSION: missing images when reloading webarchives (11962)


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canUseArchivedResource): The bug here is that because a reload sets a cache policy of NSURLRequestReloadIgnoringCacheData (rightfully so), this method was refusing to load subresources in WebArchives. It's OK to use archive subresources for the NSURLRequestReloadIgnoringCacheData cache policy because we're not worried about the actual contents of a WebArchive changing on disk.
4:15 PM Changeset in webkit [19548] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the build when using buildit.

3:53 PM Changeset in webkit [19547] by bdakin
  • 2 edits in trunk/WebCore

Rubber-stamped by John . . . and Adam.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Missing break.
3:27 PM Changeset in webkit [19546] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

  • editing/selection/4975120-expected.checksum: Added.
  • editing/selection/4975120-expected.png: Added.
  • editing/selection/4975120-expected.txt: Added.
  • editing/selection/4975120.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • page/mac/WebCoreFrameBridge.h: Removed two unused methods left over from the old form control implementation.

WebKit:

Reviewed by darin


<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • WebCoreSupport/WebFrameBridge.mm: Removed unused methods.
  • WebView/WebHTMLView.mm: Ditto. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Don't appear focused if a descendant view is firstResponder. (-[WebHTMLView _updateActiveState]): Removed the check for a BOOL that was always false.
  • WebView/WebHTMLViewInternal.h: Removed a BOOL that's always false.
2:51 PM Changeset in webkit [19545] by sullivan
  • 2 edits in trunk/WebCore
  • rendering/bidi.cpp: (WebCore::bidiNext): At Darin's suggestion, moved the "next = 0" line from my previous patch to the start of the loop body
2:37 PM Changeset in webkit [19544] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

2:35 PM Changeset in webkit [19543] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/selection/4960116-expected.checksum: Added.
  • editing/selection/4960116-expected.png: Added.
  • editing/selection/4960116-expected.txt: Added.
  • editing/selection/4960116.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/SelectionController.cpp: (WebCore::SelectionController::xPosForVerticalArrowNavigation): Null check. VisiblePosition creation can fail if a node that contains the selection was made invisible after the selection was made and before this function is called during a selection modification operation.
2:25 PM Changeset in webkit [19542] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line


  • editing/selection/4983858-expected.checksum: Added.
  • editing/selection/4983858-expected.png: Added.
  • editing/selection/4983858-expected.txt: Added.
  • editing/selection/4983858.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::exitNode): We recently split shouldEmitNewlineForNode into shouldEmitNewline{Before, After}Node, so this function now needs an implementation that is different from SimplifiedBackwardsTextIterator::handleNonTextNode. The difference is that we must call shouldEmit*BeforeNode instead of shouldEmit*AfterNode since we are a) exiting nodes and b) moving backward.
2:11 PM Changeset in webkit [19541] by justing
  • 13 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration


Added:

  • editing/execCommand/4916541-expected.checksum: Added.
  • editing/execCommand/4916541-expected.png: Added.
  • editing/execCommand/4916541-expected.txt: Added.
  • editing/execCommand/4916541.html: Added. Fixed:
  • editing/execCommand/4641880-2-expected.checksum:
  • editing/execCommand/4641880-2-expected.png:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/indent-selection-expected.txt: Added a FIXME:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-list-item.html:

WebCore:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration

  • editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Added. (WebCore::IndentOutdentCommand::indentRegion): Use rangeLength and rangeFromLocationAndLength to restore the selection after the repeated moveParagraph calls necessary to perform indent are finished.
2:05 PM Changeset in webkit [19540] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, Reviewed by Yongjun.

DESC: Can not open the Browser application. fix: delay formmanager construct ALES-6Y9GG7
​http://bugs.webkit.org/show_bug.cgi?id=12714

2:05 PM Changeset in webkit [19539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker


  • fixed <rdar://problem/4960095> REPRODUCIBLE HANG: WebKit freezes when printing as PDF a certain kind of code (12449)


No test case because I don't know how to make the bug occur without printing.

  • rendering/bidi.cpp: (WebCore::bidiNext): reset loop's "next" variable after using it; we were setting "current" to the same value of "next" each subsequent time through the loop, which is not helpful.
1:50 PM Changeset in webkit [22930] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • WebCore.vcproj/WebCore.vcproj: Add new files, remove obsolete files.
1:49 PM Changeset in webkit [19538] by darin
  • 14 edits
    3 adds
    4 deletes in trunk/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add new files, remove obsolete files.
  • DerivedSources.make: Add TextEvent to the Objective-C and JavaScript bindings lists.
  • WebCore.exp: Export DOMTextEvent Objective-C wrapper.
  • bindings/js/kjs_events.cpp: (KJS::toJS): Added TextEvent to the list of Event subclasses so we make the right kind of JS wrapper.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): Same thing, for Objective-C.
  • bindings/objc/DOMInternal.h: Added DOMTextEventInternal.h.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Added "TextEvents", "3.0" to the list of things we'll answer true for (as specified in the DOM Level 3 documentation). This isn't so great until we actually send textInput events, but that's coming soon.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add "TextEvent" as a way to make a TextEvent (as specified in the DOM Level 3 documentation).
  • dom/Event.h:
  • dom/Event.cpp: (WebCore::Event::isTextEvent): Added virtual function to be used for runtime type checking of Event objects (as for other event types).
  • dom/TextEvent.cpp: Added.
  • dom/TextEvent.h: Added.
  • dom/TextEvent.idl: Added.
  • platform/mac/WebCoreWidgetHolder.h: Removed.
  • rendering/CounterListItem.h: Removed.
  • rendering/CounterResetNode.cpp: Removed.
  • rendering/CounterResetNode.h: Removed.
1:16 PM Changeset in webkit [22929] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Add the stream to the m_streams hash set.
12:33 PM Changeset in webkit [19537] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
WebDataSource to be reattached and thus causing a crash.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove extra call to setPolicyDocumentLoader.
12:06 PM Changeset in webkit [19536] by bdakin
  • 8 edits in trunk

WebCore:

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Acrobat 8 was relying on a WebKit bug that was fixed about a year
ago with r12753. The bug was that we would not reload a page if the
source of an iframe was set to the same value it already was. Now
that we have fixed the bug, Acrobat constantly reloads their EULA,
making it blinky and impossible to read.

No layout test since the fix is to add an Acrobat-specific quirk.

  • WebCore.exp:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setLocation): If the new url is the same as the old one and we are honoring the Acrobat quirk, don't do anything.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAcrobatFrameReloadingQuirk):
  • page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Darin.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Allow quirk if the Application was linked before 3.0 and if the
application is Adobe Acrobat.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
12:00 PM Changeset in webkit [19535] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Dave Harrison

Disable the thread-check assertion in WebCore, as well as Webkit

  • WebCore.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [19534] by andersca
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4930614>
Safari complains about "Slow Script" if GMail is left open and machine is busy


<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


<rdar://problem/4963589>
Slow script warning is displayed after closing of PROMPT or PRINT dialog


Re-do the way script timeouts are handled. No longer use a unix timer that sends signals. Instead, add a
tick count and increment it in loop bodies. If the tick count reaches a threshold, do a timeout check. If the total time executing
is higher than the timeout value, (possibly) interrupt the script. The timeout checker also adjusts the threshold dynamically
to prevent doing the timeout check too often.



  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add winmm.lib.
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::startTimeoutCheck): (KJS::Interpreter::stopTimeoutCheck): (KJS::Interpreter::resetTimeoutCheck): (KJS::getCurrentTime): (KJS::Interpreter::checkTimeout):
  • kjs/interpreter.h: (KJS::Interpreter::timedOut):
  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute):

WebCore:

Reviewed by Geoff.

No need to pause timeout checks anymore.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
11:07 AM Changeset in webkit [19533] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun.

DESC: Input element deactivation methods not working (TSW TMCN-6XYRVX)
​http://bugs.webkit.org/show_bug.cgi?id=12699

11:04 AM Changeset in webkit [19532] by brmorris
  • 3 edits in S60/trunk/WebCore

yaharon, reviewed by zalan

DESC: [S60] Browser crashes when selecting the left Soft key Options when the cursor is in textarea field (SCHY-6Y7SHD)
​http://bugs.webkit.org/show_bug.cgi?id=12706

10:48 AM Changeset in webkit [19531] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebKit.exp: Add WebBaseNetscapePluginView to the export list.
10:44 AM Changeset in webkit [19530] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/EventSendingController.m

Build fix. Use 0 or 0.0 instead of nil to prevent a compile warning.

8:50 AM Changeset in webkit [22928] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth

  • WebKitWin part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • Interfaces/IWebUIDelegate.idl: bumped enum value for new SPI tags to match change in WebCore/WebKit
8:48 AM Changeset in webkit [19529] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Beth


  • WebCore part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • platform/ContextMenuItem.h: (WebCore::): Tweaked comment; bumped enum value for new SPI tags to avoid conflict with pre-3.0 SPI tag values.

WebKit:

Reviewed by Beth

  • WebKit part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • WebKit.xcodeproj/project.pbxproj: Changed DYLIB_CURRENT_VERSION to 2 (was 1)
  • Misc/WebKitVersionChecks.h: Added constant WEBKIT_FIRST_VERSION_WITH_3_0_CONTEXT_MENU_TAGS, which is 2 but in the weird format that these version checks use.
  • WebView/WebUIDelegatePrivate.h: Tweaked comments; included the old values for three tags for context menu items that changed from SPI to API in 3.0; renamed WEBMENUITEMTAG_SPI_START to WEBMENUITEMTAG_WEBKIT_3_0_SPI_START for clarity, and bumped its value to avoid conflict with the three old values
  • WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): new helper function that checks the bundle identifier (fixMenusToSendToOldClients): Removed return value for clarity; now checks linked-on version and also makes special case for Mail; now replaces three API tags with their old SPI values for clients that linked against old WebKit version, in addition to replacing new API with WebMenuItemTagOther for items that had no specific tag before. (fixMenusReceivedFromOldClients): Removed return value for clarity; removed defaultMenuItems parameter because it's no longer necessary; removed code that tried to recognize menus that got confused by the SPI -> API change (we now pass the old SPI values to these clients to avoid confusing them); now restores the tags for the items whose tags were replaced in fixMenusToSendToOldClients (this used to restore the tags of the default items rather than the new items, which was incorrect but happened to work since the clients we tested were using the objects from the default items array in their new items array) (WebContextMenuClient::getCustomMenuFromDefaultItems): Updated to account for the removed return values for the two fix-up methods; moved the autorelease of newItems here, which is clearer and was the source of a leak before.
5:55 AM Changeset in webkit [19528] by bdash
  • 6 edits
    18 adds in trunk

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors
Test results show red indicating property unsupported
Previous behaviour was to erroneously make everything green

  • css3/expected_failures/css3-modsel-33-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-33-expected.png: Added.
  • css3/expected_failures/css3-modsel-33-expected.txt: Added.
  • css3/expected_failures/css3-modsel-33.html: Added.
  • css3/expected_failures/css3-modsel-35-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-35-expected.png: Added.
  • css3/expected_failures/css3-modsel-35-expected.txt: Added.
  • css3/expected_failures/css3-modsel-35.html: Added.
  • css3/expected_failures/css3-modsel-36-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-36-expected.png: Added.
  • css3/expected_failures/css3-modsel-36-expected.txt: Added.
  • css3/expected_failures/css3-modsel-36.html: Added.
  • css3/expected_failures/css3-modsel-37-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-37-expected.png: Added.
  • css3/expected_failures/css3-modsel-37-expected.txt: Added.
  • css3/expected_failures/css3-modsel-37.html: Added.
5:24 AM Changeset in webkit [19527] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mark.

<rdar://problem/4980176>

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Since this frame is getting disconnected from its page, ensure it is not the focus node.
2:57 AM Changeset in webkit [19526] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

gdklauncher crashes when compiled with NDEBUG defined.

  • Projects/gdk/webcore-gdk.bkl:
2:44 AM Changeset in webkit [19525] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/4971224> REGRESSION: ASSERT in WebCore with Mail (12491)
​http://bugs.webkit.org/show_bug.cgi?id=12491

No test case. Not testable since there is no way to do substitute
data loads from layout tests.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Don't dispatch data load callback when loading empty data.
12:50 AM Changeset in webkit [19524] by bdash
  • 4 edits in trunk/WebCore

2007-02-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12705
REGRESSION: Crash with user stylesheet set

Allow the Frame::canLoad check to skipped so that user stylesheets can be loaded in remote documents.

  • ChangeLog:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Skip canLoad check if this is a user stylesheet. (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestResource): Allow canLoad check to be skipped.
  • loader/DocLoader.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):

Feb 8, 2007:

10:49 PM Changeset in webkit [19523] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl: Account for file renaming.
  • platform/gdk/KeyEventGdk.cpp: Make gdk's tab key recognized as tab so that keyboard link walking works on gdk. (WebCore::keyIdentifierForGdkKeyCode):
10:29 PM Changeset in webkit [19522] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

  • fast/frames/iframe-window-focus-expected.txt: Added.
  • fast/frames/iframe-window-focus.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

When a frame's window was focused, the page didn't get updated about the new frame getting focus.
This was causing handleKeyPress to fail because it kept getting a selection for the wrong frame (which wasn't editable).

Test: fast/frames/iframe-window-focus.html

  • page/Frame.cpp: (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow):
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
10:29 PM Changeset in webkit [22927] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

This also fixes a bug where when you called window.focus() on a background window, it did not come to the front.

  • bridge/win/FrameWin.h: Removed focusWindow() and unfocusWindow() stubs since there are now implementations in the base class.
  • platform/win/TemporaryLinkStubs.cpp:
9:44 PM Changeset in webkit [22926] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • WebView.cpp: (WebView::searchFor): Ever since 11396, the widget no longer handles frame focus changes. This is now the page's focus controller responsibility
9:43 PM Changeset in webkit [19521] by bdash
  • 2 edits in trunk/WebKitSite

2007-02-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

  • nav.inc: Add link to very work-in-progress DOM documentation.
9:28 PM Changeset in webkit [22925] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Initial checkin for resume support (compiles everywhere, needs ToT CFnetwork to actually work)

8:20 PM Changeset in webkit [19520] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

  • fast/forms/listbox-deselect-scroll-expected.checksum: Added.
  • fast/forms/listbox-deselect-scroll-expected.png: Added.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

Test: fast/forms/listbox-deselect-scroll.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::activeSelectionStartListIndex): Added. Returns the index for the active selection. If there is no active selection, it returns the first selected index. (WebCore::HTMLSelectElement::activeSelectionEndListIndex): Added. If there is no active selection, it returns the last selected index.
  • html/HTMLSelectElement.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealSelection): Instead of using the first and last selected indices, use the active selection indices to determine which item to reveal. This way, when you're selecting with the keyboard, or the mouse, no unnecessary scrolling will occur if the end of your active selection is already visible.
7:45 PM Changeset in webkit [19519] by brmorris
  • 3 edits in S60/branches/3.1m/WebCore

yaharon, Reviewed by zalan

DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
​http://bugs.webkit.org/show_bug.cgi?id=12706

6:24 PM Changeset in webkit [19518] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

  • fast/forms/select-block-background-expected.checksum: Added.
  • fast/forms/select-block-background-expected.png: Added.
  • fast/forms/select-block-background-expected.txt: Added.
  • fast/forms/select-block-background.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

Test: fast/forms/select-block-background.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Paint the item backgrounds during the PaintPhaseChildBlockBackground or PaintPhaseChildBlockBackgrounds phase.
6:21 PM Changeset in webkit [19517] by bdash
  • 7 edits
    4 adds in trunk

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


Test: fast/forms/select-empty-option-height.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setText): If the option text is empty, use a RenderBR as inner text, to ensure that the inner div has line height.

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/select-baseline-expected.txt:
  • fast/forms/select-empty-option-height-expected.checksum: Added.
  • fast/forms/select-empty-option-height-expected.png: Added.
  • fast/forms/select-empty-option-height-expected.txt: Added.
  • fast/forms/select-empty-option-height.html: Added.
  • fast/replaced/three-selects-break-expected.txt:
5:48 PM Changeset in webkit [19516] by ggaren
  • 5 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Added a hard counter for SubresourceLoaders because the leaks tool now
ignores them.


  • loader/SubresourceLoader.cpp: (WebCore::): (WebCore::SubresourceLoaderCounter::~SubresourceLoaderCounter): (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: Removed unnecessary #define

WebKitTools:

Reviewed by Beth Dakin.


Ignore another false leak report.

  • Scripts/run-webkit-tests:
5:45 PM Changeset in webkit [22924] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4955068>
PluginViewWin leaks memory.


Make streams ref-counted. Remove streams from the hash set once they're done loading.


Don't try to paint if painting is disabled.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::disconnectStream):
  • plugins/win/PluginViewWin.h:
5:44 PM Changeset in webkit [19515] by ggaren
  • 4 edits in trunk

LayoutTests:

Reviewed by Beth Dakin.


Updated results now that we actually return the correct ones.

  • fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4982374> CSSComputedStyleDeclaration::getPropertyCSSValue
leak reported by buildbot


The leak was a typo: "new" instead of "return new". I also generously
deployed RefPtr in places that were holding ref-counted objects in
bare pointers.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4:49 PM Changeset in webkit [22923] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Fix scrollbar painting.

3:07 PM Changeset in webkit [19514] by kjk
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • GdkLauncher/main.cpp: Add -exit-after-loading and -dump-render-tree as debugging aid. (strEq): (main):
3:01 PM Changeset in webkit [19513] by ggaren
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

build fix, oops!

2:59 PM Changeset in webkit [19512] by kjk
  • 4 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: Added. Based on qt version. (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::shouldShowDeleteInterface): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::toggleGrammarChecking): (WebCore::EditorClientGdk::handleKeyPress): (WebCore::EditorClientGdk::EditorClientGdk): (WebCore::EditorClientGdk::setPage):
  • platform/gdk/EditorClientGdk.h: Added. Ditto.
  • platform/gdk/FrameGdk.cpp: Add exitAfterLoading and dumpRenderTreeAfterLoading as small debugging features. Remove FrameGdkClient as no other platform has Frame*Client anymore. Adjust for new APIs. (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::onDidFinishLoad): (WebCore::FrameGdk::dumpRenderTree): (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::FrameGdk::focusWindow): (WebCore::FrameGdk::unfocusWindow): (WebCore::FrameGdk::getObjectInstanceForWidget): (WebCore::FrameGdk::getEmbedInstanceForWidget): (WebCore::FrameGdk::bindingRootObject): (WebCore::FrameGdk::print): (WebCore::FrameGdk::getAppletInstanceForWidget): (WebCore::FrameGdk::issueCutCommand): (WebCore::FrameGdk::issueCopyCommand): (WebCore::FrameGdk::issuePasteCommand): (WebCore::FrameGdk::issueTransposeCommand): (WebCore::FrameGdk::issuePasteAndMatchStyleCommand): (WebCore::FrameGdk::markedTextRange): (WebCore::FrameGdk::shouldChangeSelection): (WebCore::FrameGdk::respondToChangedSelection): (WebCore::FrameGdk::mimeTypeForFileName):
  • platform/gdk/FrameGdk.h: Ditto. (WebCore::FrameGdk::setExitAfterLoading): (WebCore::FrameGdk::exitAfterLoading): (WebCore::FrameGdk::setDumpRenderTreeAfterLoading): (WebCore::FrameGdk::dumpRenderTreeAfterLoading): (WebCore::GdkFrame):
  • platform/gdk/TemporaryLinkStubs.cpp: Adjust to new APIs. Small cleanups. (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::enableFlushDrawing): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findWordBoundary): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (Path::apply): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenu::setPlatformDescription): (ContextMenu::platformDescription): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::systemBeep): (WebCore::userIdleTime):
2:37 PM Changeset in webkit [22922] by andersca
  • 6 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4972772>
Implement IWebResource::Data.


<rdar://problem/4972777>
Implement IWebDataSource::subresourceForURL.


  • MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
  • MemoryStream.h: Remove notion of buffer owner, it's not needed now that the buffer itself is reference counted.


  • WebDataSource.cpp: (WebDataSource::subresourceForURL): Implement this.


  • WebKit.vcproj/WebKit.vcproj: Add WebResource.cpp and WebResource.h


  • WebResource.cpp: Added. (WebResource::WebResource): (WebResource::~WebResource): (WebResource::createInstance): (WebResource::QueryInterface): (WebResource::AddRef): (WebResource::Release): (WebResource::initWithData): (WebResource::data): (WebResource::URL): (WebResource::MIMEType): (WebResource::textEncodingName): (WebResource::frameName):
  • WebResource.h: Added.


  • WebView.cpp: (WebView::formDelegate): Return E_FAIL if there's no form delegate.
2:37 PM Changeset in webkit [19511] by kjk
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/GlyphPageTreeNode.h: Fix header guard name.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor):
  • platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gdk/PageGdk.cpp: Removed. No longer used.
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::getThemeData): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::adjustTextFieldStyle): (WebCore::RenderThemeGdk::paintTextField): (WebCore::RenderThemeGdk::paintTextArea): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
2:33 PM Changeset in webkit [19510] by ggaren
  • 2 edits in trunk/WebKitTools

Minor fixup based on Maciej's review last night.


  • Scripts/run-webkit-tests: Use normal "increment at end of loop" behavior, and do a little math to make it work.
2:31 PM Changeset in webkit [22921] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:30 PM Changeset in webkit [19509] by sfalken
  • 1 copy in tags/Safari-521.34.2b

New tag.

2:15 PM Changeset in webkit [19508] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for cairo.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::toCairoOperator): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):
2:07 PM Changeset in webkit [19507] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • webcore-base.bkl:

WebKitTools:

Reviewed by Adam Roben..

Linux/gdk build fixes.

  • GdkLauncher/gdklauncher.bkl:
1:03 PM Changeset in webkit [22920] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Remove unused stub.


  • platform/win/TemporaryLinkStubs.cpp:
1:01 PM Changeset in webkit [19506] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher

Tweaked the thread violation behavior to be disabled by default, and to provide
an easy breakpoint to set.
The possibilities for the "WebCoreThreadCheck" user defaults key are -

  • The value "None" disables thread checking
  • The value "Log" causes an NSLog on a violation
  • The value "Exception" causes exceptions to be raised on a violation
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation): In the global namespace, making breakpoints cake!
12:56 PM Changeset in webkit [19505] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben, Darin Adler.


Updated results for tests that started failing after my run-webkit-tests
check-in.


These failures were not regressions. My check-in just caused the regular
bot to behave more like the leaks bot, so it started reporting the results
that the leaks bot had been reporting all along.

There does seem to be an underlying bug in the way XHTML documents report
line numbers for JavaScript exceptions. I've file that bug along with a
reduction:


​http://bugs.webkit.org/show_bug.cgi?id=12700
JavaScript errors in XML documents have incorrect line numbers


However, that bug is not a regression, so I think we should treat it separately.

  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.txt:
12:45 PM S60Webkit edited by franklin.davis@nokia.com
(diff)
12:42 PM S60Reindeer edited by franklin.davis@nokia.com
(diff)
12:38 PM S60Webkit edited by bradley.morrison@nokia.com
minor update to urls on s60webkit page (diff)
12:23 PM Changeset in webkit [19504] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by

  • Fix layout test failures.
  • Scripts/run-webkit-tests:
11:59 AM Changeset in webkit [22919] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add shouldInterruptJavaScript to the API.


  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::addMessageToConsole): (WebChromeClient::shouldInterruptJavaScript):
11:58 AM Changeset in webkit [19503] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4983515> Need mechanism to protect against WebKit calls from secondary threads
This initial landing is a conservative move until we can be certain of performance impact.
By writing to the user defaults key @"WebCoreThreadCheck" for the WebKit app you're running -

  • The value "None" disables thread checking
  • The value "Exception" causes exceptions to be raised on a violation
  • The default is to do the check, and NSLog each violation
  • bindings/objc/ExceptionHandlers.h: Add a "Is Main Thread" assert macro
  • bindings/scripts/CodeGeneratorObjC.pm: Use new mechanism in allocs and deallocs for now
  • platform/Logging.h: Added WebCoreThreadViolationCheck macro
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Check for main-threadedness, and do some stuff
11:48 AM Changeset in webkit [22918] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

<rdar://problem/4888871>
Need to support synchronous XMLHttpRequest.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
11:19 AM Changeset in webkit [19502] by kmccullo
  • 2 edits in trunk/WebKit

Reviewed by

  • fixing a build breakage.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
10:52 AM Changeset in webkit [19501] by brmorris
  • 8 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19464, r19466, r19472 & r19499

10:39 AM Changeset in webkit [19500] by kmccullo
  • 18 edits
    17 adds in trunk

LayoutTests:

Reviewed by Maciej, Darin and Mark.

rdar://problem/4922454

  • No longer allow remote sites to access local resources.
  • fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • fast/loader/local-JavaScript-from-local.html: Added.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Added.
  • fast/loader/local-iFrame-source-from-local.html: Added.
  • fast/loader/local-image-from-local-expected.txt: Added.
  • fast/loader/local-image-from-local.html: Added.
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
  • http/tests/security/local-JavaScript-from-remote.html: Added.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Added.
  • http/tests/security/local-iFrame-from-remote.html: Added.
  • http/tests/security/local-image-from-remote-expected.txt: Added.
  • http/tests/security/local-image-from-remote.html: Added.
  • http/tests/security/resources/compass.jpg: Added.
  • http/tests/security/resources/localPage.html: Added.
  • http/tests/security/resources/localPage.html.orig: Added.
  • http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Maciej, Darin, and Mark.

rdar://problem/4922454

  • Prevents remote sites from executing local scripts.
  • bindings/objc/DOM.mm: - renamed a function that is now in the base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: - removed needless asserts (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: - renamed a function that is now in the base class (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: - removed needless asserts (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: - renamed a function that is now in the base class (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: - return early if an error occured (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: - renamed a function that is now in the base class (WebCore::CachedImage::canRender):
  • loader/CachedResource.h: - renamed a function that is now in the base class (WebCore::CachedResource::errorOccurred):
  • loader/CachedScript.h: - renamed a function that is now in the base class (WebCore::CachedScript::schedule):
  • loader/DocLoader.cpp: - The heart of the fix, prevents resources from being created or retrieved from the cache if a remote site is requesting the local resource. (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • page/EventHandler.cpp: - renamed a function that is now in the base class (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: - renamed a function that is now in the base class (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: - renamed a function that is now in the base class (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: - renamed a function that is now in the base class (WebCore::RenderImage::errorOccurred):
  • rendering/RenderListItem.cpp: - renamed a function that is now in the base class (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: - renamed a function that is now in the base class (WebCore::RenderListMarker::isImage):
10:28 AM Changeset in webkit [19499] by brmorris
  • 4 edits in S60/branches/3.1m/WebKit

yaharon, reviewed by yongjun.

DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
​http://bugs.webkit.org/show_bug.cgi?id=12696

10:19 AM Changeset in webkit [19498] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/check-for-global-initializers: For speed, only check files that have been modified since the last time we linked. For tidiness, capture stderr from nm, and prevent "nm: no name list" messages from going out.
12:43 AM Changeset in webkit [22917] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontCacheWin.cpp

Remove my garbled fixme that I didn't intend to leave in. :)

12:42 AM Changeset in webkit [19497] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak, Adam Roben.


Added 'nthly' support to run-webkit-tests. It's like 'singly', for an
arbitrary number n.


Plus some renames:

  • DumpRenderTree => "dumpTool" (to match abstraction elsewhere)
  • checkLeaks => "shouldCheckLeaks" (to match style guidelines)
  • tool => dumpTool (to match abstraction elsewhere)
  • httpdOpen => isHttpdOpen (to match style guidelines)


Plus a few logic fixups:

  • Don't check isDumpToolOpen when we know we've called openDumpTool().
  • Use a single code path to decide when to shut down dumpTool and when to check for leaks, since the operations are coincidental.
  • Use a single code path for running the leaks tool, since the only thing that varies between configurations is the output file name.
  • Increment $count after each test finishes, instead of at the end of the loop, to help with comparing to the length of the array and %-ing by n.
  • Use a more robust test inside the loop to determine if we need to close dumpTool, instead of copying the closing code outside the loop.


Layout tests pass.

  • Scripts/run-webkit-tests:
12:40 AM Changeset in webkit [22916] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore/platform/win

Make Lucida Grande bold work in the engine. Required sick special case hackery for now. Also fix the validity check for initial font construction. r=aroben

Feb 7, 2007:

11:56 PM Changeset in webkit [22915] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Fix mini search field painting.

10:29 PM Changeset in webkit [19496] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Add updateGeometry() to gdk's ScrollView. Needed to fix resizing of the window
in gdk.

  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setDrawable):
10:25 PM Changeset in webkit [19495] by kjk
  • 3 edits
    1 move
    1 delete in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes.

  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
  • platform/gdk/PopupMenuGdk.cpp: Added. Renamed from RenderPopupMenuGdk.cpp for consistency with other platforms. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
  • platform/gdk/RenderPopupMenuGdk.cpp: Removed.
  • platform/gdk/RenderPopupMenuGdk.h: Removed.
10:24 PM Changeset in webkit [22914] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Draw a single down arrow for styled menu lists.

9:41 PM Changeset in webkit [19494] by aroben
  • 2 edits in trunk/WebKit

2007-02-07 Charles Ying <​charles_ying@yahoo.com>

Reviewed by Adam.

Code suggestion by aroben


Fix ​http://bugs.webkit.org/show_bug.cgi?id=12688

REGRESSION (r19469): ASSERT when right clicking on hyperlinks! in TOT webkit


  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):
  • fixMenusReceivedFromOldClients was hitting an ASSERT incorrectly because it could not match [item title] to any of the contentMenuItemTags using pointer comparison ==. Instead, it needs to do a string comparison between [item title] and the various contentMenuItemTags using isEqualToString instead of ==. You would encounter this whenever the context menu was activated, e.g., from a hyperlink right click (or control click).
9:19 PM Changeset in webkit [22913] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

rs=adam

9:12 PM Changeset in webkit [19493] by bdash
  • 3 edits
    4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/block/float/nowrap-clear-min-width.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlineMinMaxWidth):

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/block/float/nowrap-clear-min-width-expected.checksum: Added.
  • fast/block/float/nowrap-clear-min-width-expected.png: Added.
  • fast/block/float/nowrap-clear-min-width-expected.txt: Added.
  • fast/block/float/nowrap-clear-min-width.html: Added.
9:10 PM Changeset in webkit [19492] by bdash
  • 8 edits
    4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/intermediate-layout-position.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Adjust the old bounds by the layout delta, to get the block's absolute bounds as they were before its ancestors moved it during layout. (WebCore::RenderBlock::collapseMargins): Update the layout delta for the child when moving it. (WebCore::RenderBlock::clearFloatsIfNeeded): Ditto. (WebCore::RenderBlock::determineHorizontalPosition): Ditto. (WebCore::RenderBlock::layoutBlockChildren): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Adjust the old bounds by the current layout delta.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Ditto.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.
  • rendering/RenderView.h: (WebCore::RenderView::layoutDelta): Added. Keeps track of the offset between the position of the object currently being laid out and its position at the end of the last layout. (WebCore::RenderView::addLayoutDelta): Added.

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/intermediate-layout-position-expected.checksum: Added.
  • fast/repaint/intermediate-layout-position-expected.png: Added.
  • fast/repaint/intermediate-layout-position-expected.txt: Added.
  • fast/repaint/intermediate-layout-position.html: Added.
9:06 PM Changeset in webkit [19491] by bdash
  • 2 edits in trunk/WebCore

2007-02-07 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=6286
Very large (~500MB) images cause reproducible Safari crash

  • loader/CachedImage.cpp: (WebCore::CachedImage::bufferData): Detect failure to create a large Vector<> and call error() when that happens.
8:56 PM Changeset in webkit [19490] by bdash
  • 25 edits
    6 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/backgrounds/repeat/negative-offset-repeat.html

Test: fast/repaint/table-col-background.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Added. Finds the border and/or background layer(s) that use the image and invalidates only the rect in which the image actually paints. There are two special cases in this function: 1) for the body element, the background is propagated to the root; 2) inline flows do a full repaint. (WebCore::RenderBox::calculateBackgroundImageGeometry): Added. Factored out, simplified and corrected the calculation of the rectangle into which the background image paints, the tile size and the pattern phase. (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::imageChanged): Moved the implementation to RenderBox.
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::getAbsoluteRepaintRect): Overridden to return the table's repaint rect. (WebCore::RenderTableCol::imageChanged): Overridden to do a full repaint, which currently repaints the entire table.
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::imageChanged): Overridden to do a full repaint of the row, since the backgrounds are painted by the cells.
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::imageChanged): Overridden to do a full repaint of the section, since the backgrounds are painted by the cells.
  • rendering/RenderTableSection.h:

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.


  • fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • fast/backgrounds/repeat/negative-offset-repeat-expected.txt: Added.
  • fast/backgrounds/repeat/negative-offset-repeat.html: Added. Based on a test by Mark Rowe.
  • fast/backgrounds/repeat/resources/gradient.gif: Added.
  • fast/repaint/table-col-background-expected.checksum: Added.
  • fast/repaint/table-col-background-expected.png: Added.
  • fast/repaint/table-col-background-expected.txt: Added.
  • fast/repaint/table-col-background.html: Added.
  • tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • tables/mozilla/marvin/backgr_position-table-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
7:58 PM Changeset in webkit [19489] by darin
  • 2 edits in trunk/JavaScriptCore
7:32 PM Changeset in webkit [22912] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Rubberstamped by Maciej.

Turn on SafariTheme so we can try it out.

  • WebCore.vcproj/WebCore.vcproj:
7:22 PM Changeset in webkit [22911] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin
  • WebChromeClient.cpp:
  • WebChromeClient.h: Build fix.
7:07 PM Changeset in webkit [19488] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the Qt build.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
7:05 PM Changeset in webkit [19487] by andersca
  • 14 edits in trunk

WebCore:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):

WebKit:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebFrameBridge.mm:
6:46 PM Changeset in webkit [22910] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

6:20 PM Changeset in webkit [19486] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • <rdar://problem/4826861> WebKit tests show memory leaks in NSHTMLReader, caused by method named "hash"
  • bindings/scripts/CodeGeneratorObjC.pm: Added a list of method names we should never use, since they are in base classes WebScriptObject and NSObject. Luckily, only "hash" is causing trouble. Added "hash" to the existing special case for "id". Now "hash" is "hashName" just as "id" is "idName".
5:35 PM Changeset in webkit [19485] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed all places in WebKit where _web_userVisibleString was used where _web_originalDataAsString should have been used instead.
  • History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): use _web_originalDataAsString when writing since these aren't displayed to the user (+[WebURLsWithTitles URLsFromPasteboard:]): use _web_URLWithDataAsString when reading, to match what we used when writing
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeURL:andTitle:types:]): use _web_originalDataAsString when writing the NSURL type; continue using _web_userVisibleString when writing the plain text type
  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): added comment about why _web_userVisibleString is appropriate here (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): use _web_originalDataAsString when setting the href attribute of an anchor tag
5:29 PM Changeset in webkit [19484] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4943650> REGRESSION: insertion point blink redraws entire web page, making everything slow

Problem is that AppKit recently changed NSControl to trigger a full redraw if the control has a focus ring.
WebHTMLView is a subclass of NSControl, but the focus ring type was the default value, though we actually
draw no focus ring. Fix is to formally set our focus ring type.


  • WebView/WebHTMLView.mm: (-[WebHTMLView initWithFrame:]): Send [self setFocusRingType:NSFocusRingTypeNone].
4:49 PM Changeset in webkit [19483] by sullivan
  • 2 edits in trunk/WebKit

Undid changes that I hadn't intended to check in

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
4:41 PM Changeset in webkit [19482] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ollie and Geoff

  • fixed <rdar://problem/4982345> KURL::createCFURL leak inside -[WebFrameBridge startDraggingImage...] reported by buildbot

(-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
don't retain the imageURL we pass to the drag controller -- it's just automagically
converted to a KURL anyway

3:09 PM Changeset in webkit [19481] by kjk
  • 4 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for graphics-related stuff.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::drawPattern):
2:54 PM Changeset in webkit [19480] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • fixed <rdar://problem/4974420> REGRESSION: Dragging a saved image into the browser window displays a error (No File exists at the address "null") (12662)
  • WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::urlFromPasteboard): use _web_originalDataAsString instead of _web_userVisibleString, since _web_userVisibleString can return a string with non-ASCII characters -- suitable for display but not for code
2:35 PM Changeset in webkit [19479] by kjk
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes related to networking.

  • platform/network/ResourceHandleInternal.h: Add accessor for m_client. (WebCore::ResourceHandleInternal::client):
  • platform/network/gdk/ResourceHandleCurl.cpp: Add missing functions and massage for changed APIs. (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: Rename get() to sharedInstance(). Massaged for changed APIs. (WebCore::ResourceHandleManager::sharedInstance): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):
  • platform/network/gdk/ResourceHandleManager.h: Ditto.
2:16 PM Changeset in webkit [19478] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Mismatched type of alloc/free function crashes gdk build.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::close):
2:11 PM Changeset in webkit [19477] by kjk
  • 2 edits
    1 copy in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add file based on qt implementation.

  • platform/DragData.h:
  • platform/gdk/DragDataGdk.cpp: Added.
1:53 PM Changeset in webkit [19476] by kjk
  • 1 edit
    2 copies
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on qt implementation.

  • page/gdk/DragControllerGdk.cpp: Added. (WebCore::DragController::dragOperation):
  • page/gdk/EventHandlerGdk.cpp: Added. (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::eventActivatedView):
1:32 PM Changeset in webkit [19475] by kjk
  • 1 edit
    3 copies
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on Qt implementation.

  • loader/gdk/DocumentLoaderGdk.cpp: Added. (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: Added. (WebCore::FrameLoaderClientGdk::FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::frame): (WebCore::FrameLoaderClientGdk::userAgent): (WebCore::FrameLoaderClientGdk::createDocumentLoader): (WebCore::FrameLoaderClientGdk::dispatchWillSubmitForm): (WebCore::FrameLoaderClientGdk::committedLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::postProgressStartedNotification): (WebCore::FrameLoaderClientGdk::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientGdk::postProgressFinishedNotification): (WebCore::FrameLoaderClientGdk::frameLoaderDestroyed): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::setMainFrameDocumentReady): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoad): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::didChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
  • loader/gdk/FrameLoaderClientGdk.h: Added. (WebCore::FrameLoaderClientGdk::~FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::setFrame):
12:52 PM Changeset in webkit [19474] by kjk
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk fixes related to fonts.

  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): remove a work-around for older cairo versions since Ubuntu 6.10 ships with cairo that is new enough
  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
  • platform/gdk/FontPlatformDataGdk.cpp: Remove unused variables. (WebCore::FontPlatformData::FontPlatformData):
12:15 PM Changeset in webkit [19473] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12582
REGRESSION: Unclosed <title> makes the window display garbage or empty title

Automatic testing is not possible, and manual testing probably doesn't make sense.

  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Bail out early if the passed in string is all whitespace.
12:08 PM Changeset in webkit [19472] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

yadavall, Reviewed by Zalan

DESC: Unclosed object tag causing problem MPAK-6XC86M
​http://bugs.webkit.org/show_bug.cgi?id=12680

12:02 PM Changeset in webkit [19471] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • another build fix; this time for sure
  • pcre/pcre_exec.c: (match): The compiler caught an incorrect use of the othercase variable across a call to RMATCH in character repeat processing. Local variables can change in the crazy NO_RECURSE mode that we use, so we instead need the value in othercase to be in one of the special stack frame variables. Added a new stack frame variable for this purpose named repeat_othercase. Also noted a similar error in the non-UTF-16 side of the #ifdef, but didn't try to fix that one. Also removed a SUPPORT_UCP #ifdef from the PCRE_UTF16 side; that code doesn't work without the Unicde properties table, and we don't try to use it that way.
11:49 AM Changeset in webkit [19470] by andersca
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4977952>
REGRESSION: Yahoo Messenger IM is totally blank


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): Don't ask the policy delegate for content that has valid substitute data.


(WebCore::FrameLoader::checkNavigationPolicy):
If the loader has substitute data but doesn't have an unreachable URL, let the policy
delegate decide what to do.

11:48 AM Changeset in webkit [19469] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • added some clarity to some menu-handling shenanigans
  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): renamed from fixMenusForOldClients; added comments, FIXME, and assertion (fixMenusReceivedFromOldClients): renamed from fixMenusFromOldClients; added comments, FIXME, and assertion (WebContextMenuClient::getCustomMenuFromDefaultItems): updated for name changes
11:46 AM Changeset in webkit [19468] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Restoring some of the functionality I removed in r19445. It's insufficient for
each page to cancel keepAlive only for its child frames, because a frame
can be removed from the page before we get a chance to cancel its keepAlive.
So, the page destructor has to cancel keepAlive for all frames. This is safe
because we prohibit closing a WebView while JavaScript is executing.

  • page/Frame.cpp: (WebCore::keepAliveSet): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::lifeSupportTimerFired):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page):
10:58 AM Changeset in webkit [19467] by ap
  • 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12603
A crash when trying to use XPath functions normalize-space(), string-length() and number()

Test: fast/xpath/implicit-node-args.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunNumber::doEvaluate): Implemented zero parameter case. (WebCore::XPath::FunctionMapping::): Corrected descriptions of these functions, as they do allow zero parameters. (WebCore::XPath::createFunction): Combined the two failure cases to ensure that this function never returns 0.
8:11 AM Changeset in webkit [19466] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yngjun.

DESC: Highlighting lost when browser toolbar is dismissed TMCN-6XWLEC


Toolbar consumes the keyrelease event and the webcore gets stuck in a keypressed state.
fix: send keyrelease event to the webcore


​http://bugs.webkit.org/show_bug.cgi?id=12642

8:06 AM Changeset in webkit [19465] by zack
  • 2 edits in trunk/WebCore

Fix compilation of the Qt code.

8:04 AM Changeset in webkit [19464] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

rathnasa, reviewed by Zalan Bujtas.

DESC: [S60] EMGH-6XTG9Y: Browser: Bookmarks with an URL containing spaces do not work
​http://bugs.webkit.org/show_bug.cgi?id=12635

Feb 6, 2007:

11:41 PM Changeset in webkit [22909] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

Fix for <rdar://4973323> PageUp/PageDown don't move the caret in textareas

  • WebView.cpp: (WebView::keyDown): added key entry for function to scroll by page and move caret in scrolling editable regions
11:40 PM Changeset in webkit [19463] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Added editing command functions for scrolling by page and moving the caret

  • editing/Editor.cpp: (WebCore::execMoveUpByPageAndModifyCaret): (WebCore::execMoveDownByPageAndModifyCaret): (WebCore::CommandEntry::):
10:59 PM Changeset in webkit [19462] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin, evil twin to Bethany P. Dakin.


Ignore known leaks in CFRunLoop. Exclude THRD leaks by type so that we can
catch all reports of them, not just those inside pthread_create.


Also, use "
" instead of "\" because we need the actual \ to get into the
regexp string if it's going to do any escaping. (Oops!)

  • Scripts/run-webkit-tests:
10:18 PM Changeset in webkit [19461] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.


The 's' is optional when the leaks tool reports 'leaks'.


  • Scripts/run-leaks:
9:45 PM Changeset in webkit [19460] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.


Hooked up run-webkit-tests to the run-leaks script. No change in behavior yet.

  • Scripts/run-webkit-tests: Changed symbol names to valid regular expressions.
8:27 PM Changeset in webkit [19459] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/forms

Re-enabling this test. It doesn't seem to be failing for me (or the buildbot) afterall.

7:50 PM Changeset in webkit [19458] by kdecker
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject


Reviewed by Anders.

  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase sharedDatabase]): Removed NSApplicationWillTerminateNotification observer and thus also removed code that would unload the entire plug-in database when receiving that notification.


The bug here was that this notification callback would happen first before anything else thus unloading
plug-ins and releasing plug-in memory. That was crash prone because the JavaScriptCore collector would at
a later time attempt to release its CInstance references (references that point to plug-in memory)
without knowing WebKit already unloaded the plug-in out from underneath it. The WebPluginDatabase simply
does not have enough context to make this decision.


  • WebView/WebView.mm: Added two statics: applicationIsTerminating, pluginDatabaseClientCount. (+[WebView initialize]): Added NSApplicationWillTerminateNotification observer. (+[WebView _applicationWillTerminate]): Added. (-[WebView _close]): WebKit has both a global plug-in database and a separate, per WebView plug-in database. We need to release both sets of plug-ins because Netscape plug-ins have "destructor functions" that should be called when the browser unloads the plug-in. These functions can do important things, such as closing/deleting files so it is important to ensure that they are properly called when the application terminates.


The new change is that on app shutdown, we unload WebKit's global plug-in database if and only if the last WebView
was closed. To do so otherwise would unload plug-ins out from underneath other WebViews.

7:36 PM Changeset in webkit [19457] by brmorris
  • 2 edits in S60/trunk/WebCore

yaharon, reviewed by zalan. merged to s60/trunk by brad.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:33 PM Changeset in webkit [19456] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

yaharon, reviewed by zalan.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:19 PM Changeset in webkit [19455] by brmorris
  • 2 edits in S60/trunk/S60Tools

brmorris, reviewed by sasha

DESC: small update to s60tools\prepare-changelog as r19440 accidentally bumped the Perl version :/

  • prepare-ChangeLog.bat:
7:12 PM Changeset in webkit [22908] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:12 PM Changeset in webkit [19454] by sfalken
  • 1 copy in tags/Safari-521.34.1b

New tag.

6:57 PM Changeset in webkit [19453] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/forms

Disabling this test while I investigate its failure.

6:40 PM Changeset in webkit [19452] by justing
  • 22 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line


Added:

  • editing/deleting/4922367-expected.checksum: Added.
  • editing/deleting/4922367-expected.png: Added.
  • editing/deleting/4922367-expected.txt: Added.
  • editing/deleting/4922367.html: Added.


Fixed:

  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/inserting/insert-paragraph-02-expected.txt:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/7152-1-expected.txt:
  • editing/selection/7152-2-expected.txt:
  • editing/selection/click-before-and-after-table-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/style/apple-style-editable-mix-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-type-after-expected.txt:
  • editing/unsupported-content/table-type-before-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line

  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Don't ASSERT when manipulating non-editable content that is embedded in editable content. We'll do this kind of manipulation when removing redundant style spans after pasting content that has non-editable pieces.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
  • editing/htmlediting.cpp: (WebCore::isContentEditable): Added, wrapper for Node::isContentEditable (WebCore::rangeCompliantEquivalent): Although legal, [{table, select, etc.}, {0, numChildren}] don't refer to children of the element, but positions before and after the element. So, rangeCompliantEquivalent is really responsible for converting illegal positions *and* legal positions that have a special meaning internally.
  • editing/htmlediting.h:
5:57 PM Changeset in webkit [19451] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • platform/String.cpp: (WebCore::String::ascii): Fix dumping null Strings.
4:28 PM Changeset in webkit [19450] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix <rdar://problem/4979484>


  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Do the range check before calling isalpha or isalnum.
3:55 PM Changeset in webkit [19449] by darin
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Misc/WebKitNSStringExtras.m: (canUseFastRenderer): Fix code that mistakenly used the slow renderer for strings that have a direction of "other neutral", which includes the "@" character. (-[NSString _web_drawAtPoint:font:textColor:]): Add code to make the baseline of the text in the status bar right. AppKit's rule for rounding is complicated enough that this is obviously not perfectly correct, but it does make both code paths use the same baseline in all the places this is currently used in AppKit.
3:38 PM Changeset in webkit [19448] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • svg/custom/use-elementInstance-event-target-expected.png:
3:35 PM Changeset in webkit [19447] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12566
[Drosera] Console history fixups

  • Drosera/console.js: assorted cleanups and fixes
3:31 PM Changeset in webkit [19446] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Disable testkjs in sln until we figure out mysterious compiler warning.

2:57 PM Changeset in webkit [19445] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed Frame/RenderObject/Node leak report seen while running SVG image tests.
(We'll need this fix if we ever re-enable SVG image.)


The extra reference belonged to the Frame keepAlive timer (so this was
not a "real" leak, in the end). The Page destructor has code to cancel all
Frame keepAlive timers upon the destruction of the last Page, but an SVG
image puts a Page within a Page, making this condition impossible to meet.


The fix here is to have each individual page cancel the keepAlive timers
belonging to its child frames.


  • page/Frame.cpp: Changed the FrameCounter to use WTF logging. (WebCore::): Nixed the lifeSupportSet, since it's no longer used. (WebCore::Frame::cancelKeepAlive): Renamed from "endLifeSupport" to match the name "keepAlive".
  • page/Page.cpp: (WebCore::Page::~Page): Made each page cancel its child keepAlive timers and clear its mainFrame, since we may never reach the condition of having 0 Pages.
2:38 PM Changeset in webkit [19444] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Build fix by ggaren

  • pcre/pcre_exec.c: (match):
2:36 PM Changeset in webkit [22907] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Updated for log channel rename.

  • platform/win/GDIObjectCounter.cpp: (WebCore::GDIObjectCounter::~GDIObjectCounter):
2:35 PM Changeset in webkit [19443] by aroben
  • 3 edits in trunk/WebCore

Rubberstamped by Brady.

Revert the log channel constants to their old values for all you pretty
people out there who were using the old ones. I also renamed
LogResources to LogPlatformLeaks to be a bit more specific.

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
2:28 PM Changeset in webkit [19442] by justing
  • 1 edit in trunk/WebCore/editing/htmlediting.cpp

Backing out some changes I accidently checked in.

2:17 PM Changeset in webkit [19441] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode

  • editing/inserting/4959067-expected.checksum: Added.
  • editing/inserting/4959067-expected.png: Added.
  • editing/inserting/4959067-expected.txt: Added.
  • editing/inserting/4959067.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode


Do not expand the selection to include fully selected
special elements when insering text over a selection.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Pass expandForSpecialElements through to DeleteSelectionCommand's constructor. (WebCore::CompositeEditCommand::moveParagraphs): Use the convenience function.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Do not expand the selection to be deleted for special elements.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME about when we should expand the selection.
2:03 PM Changeset in webkit [19440] by brmorris
  • 16 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19429, r19430, r19431, r19432 and r19433

2:01 PM Changeset in webkit [19439] by darin
  • 2 edits in trunk/WebKit

Spotted by Steve F.

  • Misc/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Fix obvious logic mistake I introduced back in revision 8255. I can't see how to exercise this code path, but I also can't bear to leave this obviously-broken code as-is.
1:55 PM Changeset in webkit [19438] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • fix <rdar://problem/4979089> PCRE should avoid setjmp/longjmp even when compiler is not GCC

Added a new code path that's slower and way uglier but doesn't rely on GCC's
computed gotos.

  • pcre/pcre_exec.c: Added a numeric parameter to the RMATCH function. It must be different at every RMATCH call site. Changed the non-GCC NO_RECURSE version of the macro to use a label incorporating the number. Changed the RRETURN macro to use a goto instead of longjmp. (match): Added a different number at each callsite, using a perl script for the first-time task. Going forward it should be easy to maintain by hand. Added a switch statement at the bottom of the function. We'll get compile time errors if we have anything in the switch statement that's never used in an RMATCH, but errors in the other direction are silent except at runtime.
1:26 PM Changeset in webkit [19437] by ggaren
  • 2 edits
    1 move in trunk/LayoutTests

At Darin's request, checked in new (failing) results instead of disabling test.

  • fast/images/svg-as-image-expected.txt:
1:21 PM Changeset in webkit [22906] by andersca
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Darin and Geoff.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Call OleInitialize.


(runTest):
Use CF for creating the URLs passed in.


(initializePreferences):
Don't autosave the preferences.


(main):

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link with CF.
1:14 PM Changeset in webkit [19436] by ggaren
  • 3 edits
    1 move in trunk

LayoutTests:

Reviewed by Anders Carlsson.


Disabled support for SVG image because it crashes all the time.

  • fast/images/svg-as-image.html: Removed.
  • fast/images/svg-as-image.html-disabled: Moved to here.

WebCore:

Reviewed by Anders Carlsson.


Disabled support for SVG image because it crashes all the time.

  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
12:58 PM Changeset in webkit [22905] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added support for radio buttons and checkboxes.

12:26 PM Changeset in webkit [19435] by ap
  • 3 edits
    2 adds in trunk

2007-02-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/layers/generated-layer-scrollbar-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Changed element()->document() to document() to work with anonymous objects. (WebCore::RenderLayer::updateOverflowStatus): Ditto.
11:42 AM Changeset in webkit [19434] by darin
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by John.

  • fix <rdar://problem/4687840> 9A241: JavaScript RegExp 25-30x slower than on 10.4.7

I used Shark to figure out what to do. The test case is now 15% faster than with
stock Safari. Some other regular expression cases might still be a few % slower
than before, but the >10x slowdown is now completely gone.

1) Fix slowness caused by setjmp/longjmp by using computed goto instead.

Use GCC extensions - locally declared labels, labels as values, and computed goto -
instead of using setjmp/longjmp to implemement non-recursive version of the regular
expression system. We could probably make this even faster if we reduced the use
of malloc a bit too.

2) Fix slowness caused by allocating heapframe objects by allocating the first

16 of them from the stack.

3) Speed up use of malloc and free in PCRE by making it use fastMalloc and fastFree.

4) Speed up the test case by adding a special case to a UString function.

5) Made a small improvement to the innermost hottest loop of match by hoisting

the conversion from int to pcre_uchar out of the loop.

  • JavaScriptCore.xcodeproj/project.pbxproj: Compile FastMallocPCRE.cpp, and don't compile pcre_globals.c.
  • wtf/FastMallocPCRE.cpp: Added. A copy of pcre_globals.c that uses FastMalloc.h. This is better than code that sets the PCRE allocation globals because by doing it this way there's guaranteed to be no problem with order of initialization.
  • kjs/ustring.cpp: (KJS::UString::spliceSubstringsWithSeparators): Add a fast special case when this is called for only one subrange and no seaprators. This was happening a lot in the test case and it seems quite reasonable to optimize this.
  • pcre/pcre_exec.c: Create a copy of the RMATCH and RRETURN macros that use goto instead of setjmp/longjmp. Change code that calls pcre_stack_malloc to first use storage on the stack inside the match function. (match): Move initialization of utf8 up a couple lines to avoid "possibly used uninitialized" warning. Use a local variable so we compare with pcre_uchar instead of with int inside the inner "find a character" loop.
9:17 AM Changeset in webkit [19433] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>

DESC: Should check meta for charset if meta exists EHSN-6UQ6CM
​http://bugs.webkit.org/show_bug.cgi?id=12225

8:50 AM Changeset in webkit [19432] by brmorris
  • 4 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] OSS Browser crashes when accessing cnn.com, yahoo.com with Load images & sounds turned off.(SLON-6XY8JM )
​http://bugs.webkit.org/show_bug.cgi?id=12622

8:46 AM Changeset in webkit [19431] by brmorris
  • 4 edits in S60/branches/3.1m

yongjzha, Reviewed by Zalan.

DESC: enable drawing 1px transparent image with EGray256 mask
​http://bugs.webkit.org/show_bug.cgi?id=12621

8:41 AM Changeset in webkit [19430] by brmorris
  • 7 edits in S60/branches/3.1m

vbradley, reviewed by Yongjun.

DESC: Fixed the stack size and pcre stack overflow ALAA-6XSF7U
Limit the number recursions that are allowed in match().
​http://bugs.webkit.org/show_bug.cgi?id=12611

8:34 AM Changeset in webkit [19429] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yongjun.

DESC: closing the window while the page is loading still crashes the browser TMCN-6XRQP2
fix: do not let new transactions get sumbited while cancel is in progress

8:30 AM Changeset in webkit [19428] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

winship, reviewed by yongjun

DESC: MLIO-6XGEMQ BrowserNG: Toolbar positioned out of screen after closing PDA
​http://bugs.webkit.org/show_bug.cgi?id=12544

7:34 AM Changeset in webkit [19427] by eseidel
  • 13 edits in trunk

2007-02-06 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

WebKit ignores floating point values for stroke-miterlimit
​http://bugs.webkit.org/show_bug.cgi?id=12577

Test: svg/W3C-SVG-1.1/painting-stroke-07-t.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h: (WebCore::StyleStrokeData::operator!=):
1:08 AM Changeset in webkit [22904] by aroben
  • 5 edits
    2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Oliver.

Add a GDIObjectCounter class that informs us of GDI leaks.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/GDIObjectCounter.cpp: Added. (WebCore::GDIObjectCounter::GDIObjectCounter): (WebCore::GDIObjectCounter::init): (WebCore::GDIObjectCounter::~GDIObjectCounter): (WebCore::GDIObjectCounter::currentGDIObjectsInUse):
  • platform/win/GDIObjectCounter.h: Added.

WebKitWin:

Reviewed by Ada and Oliver.


Add some GDI object logging to help catch leaks.

  • WebFrame.cpp: (WebFrame::layoutIfNeeded):
  • WebView.cpp: (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::paintIntoBackingStore): (WebView::paintIntoWindow):
1:07 AM Changeset in webkit [19426] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Ada and Oliver.

Adding a new LogResources channel for tracking platform resource usage.

  • platform/Logging.cpp: Added new channel, cleaned up constants to be more readable.
  • platform/Logging.h: Declare new channel.
Note: See TracTimeline for information about the timeline view.