Context Navigation

Re-applying fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
http://bugs.webkit.org/show_bug.cgi?id=13263

We don't need to call interpretKeyEvents for cmd-key events as
they events will be interpreted by performKeyEquivalent.

WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):

7:26 PM Changeset in webkit [21345] by bdash

1 copy in tags/WebKit-419.2

New tag.

7:11 PM Changeset in webkit [21344] by oliver

1 edit in trunk/LayoutTests/ChangeLog

Remove random characters from changelog

7:08 PM Changeset in webkit [21343] by oliver

2 edits in trunk/LayoutTests

Reviewed by Adam.

Workaround for rdar://problem/5114296 need to allow for
download occuring, and thus not triggering subframeLoaded()

fast/encoding/char-encoding.html:

3:16 PM Changeset in webkit [21342] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed #includes of JSStringRefCF.h and use of CF datatypes. I think I
misunderstood this issue before.

API/JavaScriptCore.h: #include JSStringRefCF.h. Platforms that don't want this behavior can just #include individual headers, instead of the umbrella framework header. But we definitely want Mac OS X clients to get the #include of JSStringRefCF.h "for free."
API/minidom.c: Don't #include JSStringRefCF.h. (Don't need to #include JavaScriptCore.h, either.)
API/testapi.c: Don't #include JSStringRefCF.h. Do use CF datatypes regardless of whether APPLE is defined. Platforms that don't support CF just shouldn't compile this file. (main):

3:04 PM Changeset in webkit [21341] by bdash

1 copy in branches/feature-branch

Branch for feature development.

2:42 PM Changeset in webkit [21340] by bdash

4 edits
1 add in trunk

2007-05-09 Holger Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

Gdk build fix with SVG enabled. Stub out ImageBufferCairo.

WebCore.pro: Build ImageBufferCairo.cpp
platform/graphics/cairo/ImageBufferCairo.cpp: Added. (WebCore::ImageBuffer::create): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context):

2007-05-09 Holger Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

GdkLauncher/main.cpp: Always include config.h.

1:37 PM BuildBot edited by bdash@webkit.org

(diff)

1:22 PM Changeset in webkit [21339] by zbujtas

2 edits in S60/trunk/WebCore

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Web Browser crashes when trying to browse to Hertz.com
http://bugs.webkit.org/show_bug.cgi?id=13616

12:59 PM Changeset in webkit [21338] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

Demonstrates the bug:

editing/style/5017613-1-expected.checksum: Added.
editing/style/5017613-1-expected.png: Added.
editing/style/5017613-1-expected.txt: Added.
editing/style/5017613-1.html: Added.

Tests to make sure that a plaintext-only region
will only be styled if it is fully selected:

editing/style/5017613-2-expected.checksum: Added.
editing/style/5017613-2-expected.png: Added.
editing/style/5017613-2-expected.txt: Added.
editing/style/5017613-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use a for loop instead of while(1). Simplify loop termination using Range::pastEndNode. Don't handle the start.node() == end.node() case specially, it's unnecessary. Apply the style change to fully selected plaintext-only regions, not with wrapper spans inside the region, but by changing the element's inline style declaration. Don't descend into nodes whose children we should ignore.

11:45 AM Changeset in webkit [21337] by adele

7 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated results for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

fast/block/float/032-expected.txt:
fast/forms/input-text-word-wrap-expected.checksum:
fast/forms/input-text-word-wrap-expected.png:
fast/forms/input-text-word-wrap-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

For plain text fields, don't stretch the inner text box. Center it vertically in the field.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::layout):

7:57 AM Changeset in webkit [21336] by darin

1 edit
1 add in trunk/LayoutTests

checked in a file that was accidentally left out of the last check-in

fast/js/cyclic-prototypes-expected.txt: Added.

7:39 AM Changeset in webkit [21335] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
http://bugs.webkit.org/show_bug.cgi?id=13627

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):

7:36 AM Changeset in webkit [21334] by spadma

2 edits in S60/trunk/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
http://bugs.webkit.org/show_bug.cgi?id=13627

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):

7:00 AM Changeset in webkit [21333] by yongjzha

2 edits in S60/branches/3.1m/WebKit

2007-05-07 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Browser back goes to the beginning of the previous page
http://bugs.webkit.org/show_bug.cgi?id=13394
TSW ID : TMCN-6YDJDU

BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

3:36 AM Changeset in webkit [21332] by eseidel

3 edits
2 adds in trunk

2007-05-09 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

http://bugs.webkit.org/show_bug.cgi?id=6985
Cyclic proto values cause WebKit to hang

kjs/object.cpp: (KJS::JSObject::put): do a cycle check before setting proto

3:35 AM Changeset in webkit [21331] by bdash

2 edits in trunk/WebCore

2007-05-09 Atul Mehrotra <atul.mehrotra@celunite.com>

Gdk build fix.

platform/gdk/TemporaryLinkStubs.cpp: (Editor::newGeneralClipboard):

1:20 AM Changeset in webkit [21330] by bdash

2 edits in branches/Safari-2-0-branch/WebKit

Merge r21322.

12:52 AM Changeset in webkit [21329] by bdash

3 edits in trunk/WebCore

2007-05-09 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13037 REGRESSION: Copy-on-scroll not reset properly after back/forward navigation

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Moved initialization of m_slowRepaintObjectCount here. (WebCore::FrameViewPrivate::reset): Do not reset the slow repaint object count here. (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): Added an assertion that the object count is positive.
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Corrected a mix up between old and new style, which caused the object count to be decremented when it was supposed to be incremented and vice versa.

12:48 AM Changeset in webkit [21328] by bdash

2 edits in trunk/WebCore

2007-05-09 Peter Müller <pm@one.com>

Reviewed by Dave Hyatt.

Changed the hardcoded colors that are used for CSS 2.1 system colors.
Previous colors had numerous conflicts in semantic pairs, which
made text invisible in highlight, info and menu colored areas.
The new hardcoded colors are inspired by Aqua.

Ideally these colors should be fetched through AppKit instead,
though I am not sure if it is possible to make a 1:1 mapping
between CSS2.1 system colors and Mac OS X.

css/cssstyleselector.cpp: (WebCore::):

12:32 AM Changeset in webkit [23351] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebCoreLocalizedStrings.cpp

Fix build.

12:16 AM Changeset in webkit [21327] by lars

2 edits in trunk/WebCore

Fix the Qt build.

May 8, 2007:

11:04 PM Changeset in webkit [21326] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21322 and 21323.

10:59 PM Changeset in webkit [21325] by bdash

3 edits in branches/Safari-522/WebKit

Merge r20668.

10:28 PM Changeset in webkit [21324] by ggaren

9 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Added test to verify that you get back the same JS/ObjC wrapper when
you access the same object twice.

fast/dom/wrapper-identity-expected.txt: Added.
fast/dom/wrapper-identity.html: Added.

WebCore:

Reviewed by Darin Adler.

More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore to WebScriptObject.

Fixed WebScriptObject bridging so that you always get the same WebScriptObject for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a lot more coherent as an API.

bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache to distinguish from the JSWrapperCache. Added typedef for readability. (WebCore::getDOMWrapper): (WebCore::addDOMWrapper): (WebCore::removeDOMWrapper):
bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just like the DOMWrapperCache. (WebCore::getJSWrapper): (WebCore::addJSWrapper): (WebCore::removeJSWrapper): (WebCore::createJSWrapper): (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts to return a specific DOM wrapper object, or, barring that, it returns a generic WebScriptObject. (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Added this method to support our old WebScriptObject security and leak checking model, even though it doesn't work very well. (-[WebScriptObject _setImp:originRootObject:rootObject:]): (-[WebScriptObject dealloc]): (-[WebScriptObject finalize]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
bindings/objc/WebScriptObjectPendingPublic.h:
bindings/objc/WebScriptObjectPrivate.h:
page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Changed to use the new API. This fixes a bug where the object sent to -windowScriptObjectAvailable: and returned from -windowScriptObject could not be round-tripped.

WebKitTools:

Reviewed by Darin Adler.

Added support for testing ObjC object identity.

Added ASSERT to verify that you can round-trip the object passed to you
in -didClearWindowObject:forFrame:.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController objCIdentityIsEqual::]):

10:15 PM Changeset in webkit [21323] by bdash

2 edits in trunk/WebKit

2007-05-09 Mark Rowe <mrowe@apple.com>

Build fix to keep the buildbot happy.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:09 PM Changeset in webkit [21322] by bdash

2 edits in trunk/WebKit

2007-05-08 Bruce Q Hammond <bruceq@apple.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13578
Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not correct

Now we have correct handling of the origin when QD plugins draw to
offscreen bitmaps.
Also the clipping code for this path was doing unnecessary work which
caused incorrect results; it has been removed.

This change should not affect Safari and in general will only affect
plugins (e.g. Flash) drawing to a CGBitmapContext.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:07 PM Changeset in webkit [21321] by bdash

2 edits in trunk/WebCore

2007-05-09 Mark Rowe <mrowe@apple.com>

Build fix.

editing/Editor.cpp: (WebCore::findFirstGrammarDetailInRange): Use unsigned rather than int. (WebCore::findFirstBadGrammarInRange): Cast to unsigned in assertion. (WebCore::isRangeUngrammatical): Remove unused variables.

8:11 PM Changeset in webkit [21320] by eseidel

3 edits
3 adds in trunk

2007-05-08 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by darin. Landed by eseidel.

http://bugs.webkit.org/show_bug.cgi?id=10880 (Do..while loop gains a semicolon each time it is toStringed) Grammar in Ecma-66262, 12.6: "do Statement while ( Expression );" EmptyStatement was created after every do..while(expr) which had semicolon at the end.

kjs/grammar.y: Require semicolon at the end of do..while

6:45 PM Changeset in webkit [21319] by kevino

10 edits in branches/wx-port-alpha/trunk

Get WEBKITOUTPUTDIR working for the wx port and use it to store build files. Also add a way to specify custom args to make, and have the build script point users to the demo and JSCore tests upon completion.

6:14 PM Changeset in webkit [23350] by sfalken

2 edits in branches/WindowsMerge/WebCore

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Rubber-stamped by Geoff.

Moved shared EditorWin code to Editor.cpp in open source.

platform/win/EditorWin.cpp: Deleted (moved) most of this file.

6:02 PM Changeset in webkit [21318] by sfalken

6 edits in trunk

Reviewed by Darin.

Implemented spelling/grammar related WebEditorClient methods.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::ignoreWordInSpellDocument): Added. Call through to NSSpellChecker. (WebEditorClient::learnWord): Added. Call through to NSSpellChecker. (WebEditorClient::checkSpellingOfString): Added. Call through to NSSpellChecker. (WebEditorClient::checkGrammarOfString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithGrammarString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithMisspelledWord): Added. Call through to NSSpellChecker. (WebEditorClient::showSpellingUI): Added. Call through to NSSpellChecker. (WebEditorClient::spellingUIIsShowing): Added. Call through to NSSpellChecker. (WebEditorClient::getGuessesForWord): Added. Call through to NSSpellChecker.

Reviewed by Darin.

Moved most spelling/grammar logic to C++. Now calls through to
WebKit to actually invoke NSSpellChecker.

editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Added (ported from EditorMac). (WebCore::Editor::learnSpelling): Added (ported from EditorMac). (WebCore::findFirstMisspellingInRange): Added (ported from EditorMac). (WebCore::paragraphAlignedRangeForRange): Added (ported from EditorMac). (WebCore::findFirstGrammarDetailInRange): Added (ported from EditorMac). (WebCore::findFirstBadGrammarInRange): Added (ported from EditorMac). (WebCore::Editor::advanceToNextMisspelling): Added (ported from EditorMac). (WebCore::Editor::isSelectionMisspelled): Added (ported from EditorMac). (WebCore::isRangeUngrammatical): Added (ported from EditorMac). (WebCore::Editor::isSelectionUngrammatical): Added (ported from EditorMac). (WebCore::Editor::guessesForUngrammaticalSelection): Added (ported from EditorMac). (WebCore::Editor::guessesForMisspelledSelection): Added (ported from EditorMac). (WebCore::Editor::showSpellingGuessPanel): Added (ported from EditorMac). (WebCore::Editor::spellingPanelIsShowing): Added (ported from EditorMac). (WebCore::Editor::markMisspellingsAfterTypingToPosition): Added (ported from EditorMac). (WebCore::markAllMisspellingsInRange): Added (ported from EditorMac). (WebCore::markAllBadGrammarInRange): Added (ported from EditorMac). (WebCore::markMisspellingsOrBadGrammar): Added (ported from EditorMac). (WebCore::Editor::markMisspellings): Added (ported from EditorMac). (WebCore::Editor::markBadGrammar): Added (ported from EditorMac).
editing/mac/EditorMac.mm: Removed Objective C version of spelling/grammar calls.

5:44 PM Changeset in webkit [21317] by kevino

2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Update code to work with WebKit changes in the last update.

5:42 PM Changeset in webkit [23349] by sfalken

6 edits
1 add in branches/WindowsMerge

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Added UI_STRING versions of localized WebCore strings.

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Removed localized string stubs.

platform/win/TemporaryLinkStubs.cpp:

4:14 PM Changeset in webkit [21316] by oliver

3 edits
2 adds in trunk

LayoutTests:

Reviewed by darin.

Test for <rdar://problem/5188938> arc method on
Canvas causes hang or crash work around.

fast/canvas/arc-crash-expected.txt: Added.
fast/canvas/arc-crash.html: Added.

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5188938> arc method on Canvas causes hang or crash

Workaround bad behaviour of CGPathAddArc when passed inf as start or
end angles.

platform/graphics/cg/PathCG.cpp: (WebCore::Path::addArc):

3:51 PM Changeset in webkit [21315] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt and Hatcher.

fix auto-activation code path so Tiger and Leopard aren't different

platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Do the auto-activation dance first before doing anything else, and ignore the font that it returns.

3:43 PM Changeset in webkit [21314] by brmorris

2 edits in S60/trunk/WebKit

bradley, reviewed by nobody

DESC: fix bustage by wrapping EAknEditorFlagDeliverVirtualKeyEv

BrowserCore/Formcontrols/src/FControlInputWidget.cpp

2:58 PM Changeset in webkit [21313] by spadma

3 edits in S60/trunk/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: recogniser enhancement.
http://bugs.webkit.org/show_bug.cgi?id=13628

BrowserRecognizers/inc/BrowserRec.h:
BrowserRecognizers/src/BrowserRec.cpp: (:CApaDataRecognizerType): (CBrowserRecognizer::PreferredBufSize): (CBrowserRecognizer::SupportedDataTypeL): (CBrowserRecognizer::DoRecognizeL): (CBrowserRecognizer::CheckForOPML): (CBrowserRecognizer::CreateRecognizerL):

1:11 PM Changeset in webkit [21312] by yongjzha

3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:
pcre/pcre.c: (compile_branch): (pcre_compile):

12:41 PM Changeset in webkit [23348] by sfalken

8 edits in branches/WindowsMerge

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Update editing delegate

Interfaces/IWebEditingDelegate.idl:
WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString):
WebEditorClient.h:

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Updated for new editor interface.

platform/win/EditorWin.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::isRangeUngrammatical):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Update to new editing delegate interface.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::updateSpellingUIWithGrammarString):

12:27 PM Changeset in webkit [21311] by sfalken

10 edits in trunk

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

bridge/EditorClient.h:
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
WebCoreSupport/EditorClientQt.h:

11:31 AM Changeset in webkit [21310] by ggaren

2 edits in trunk/JavaScriptCore

Build fix -- this time for sure.

APICast.h, being private, ends up in a different folder than JSValueRef.h,
so we can't include one from the other using "". Instead, just forward
declare the relevant data types.

API/APICast.h:

10:54 AM Changeset in webkit [21309] by ggaren

2 edits in trunk/JavaScriptCore

Build fix: export APICast.h for WebCore and WebKit.

JavaScriptCore.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [21308] by ap

15 edits
2 adds in trunk

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13480
window.Attr is undefined

Test: fast/dom/Window/attr-constructor.html

dom/Attr.idl:
dom/CDATASection.idl:
dom/CharacterData.idl:
dom/Comment.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Entity.idl:
dom/EntityReference.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl: Added GenerateConstructor.

page/DOMWindow.idl: Added constructor properties for DOM interfaces.

10:34 AM Changeset in webkit [21307] by ggaren

13 edits
1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added support for new -[WebScriptObject JSObject] and -[WebFrame globalContext]
APIs.

Also fixed some more cases of <rdar://problem/4395622> API:
WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript
returns NO by default, and generally cleaned up that documentation.

WebCore.exp: A lot of the diff here is from sorting.
WebCore.xcodeproj/project.pbxproj:
bindings/objc/WebScriptObject.h:
bindings/objc/WebScriptObject.mm: (-[WebScriptObject JSObject]):
bindings/objc/WebScriptObjectPendingPublic.h: Added.

WebKit:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added -[WebFrame windowObject] and -[WebFrame globalContext], along with
a new frame load delegate method, - (void)webView:(WebView *)webView
didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame.
This is all to support briding between the WebScriptObject and JavaScriptCore
APIs.

Also fixed more of <rdar://problem/4395622> API: WebScriptObject.h incorrectly
reports that -isSelectorExcludedFromWebScript returns NO by default, and
generally cleaned up the WebScriptObject headerdoc.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]):
WebView/WebFrame.mm: (-[WebFrame windowObject]): (-[WebFrame globalContext]):
WebView/WebFramePrivate.h:
WebView/WebViewPrivate.h:

WebKitTools:

Reviewed by Maciej Stachowiak.

Added tests for new APIs: -[WebFrame windowObject], -[WebFrame globalContext],
and - (void)webView:(WebView *)webView didClearWindowObject:(WebScriptObject *)windowObject
forFrame:(WebFrame *)frame, in the form of ASSERTs.

DumpRenderTree/DumpRenderTree.m: (runJavaScriptThread): Fixed quote mismatch that prepare-changelog likes to complain about.

(-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
(-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

9:40 AM Changeset in webkit [21306] by thatcher

4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5180384> webView:validateUserInterfaceItem:defaultValidation: does not get called on WebUIDelegates

Call the delegate when the one of our views gets a validateUserInterfaceItem: call.

WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebHTMLView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebPDFView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
WebView/WebView.mm: (-[WebView _responderValidateUserInterfaceItem:]): Call validateUserInterfaceItemWithoutDelegate: to prevent asking the delegate twice. (-[WebView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.

7:47 AM Changeset in webkit [21305] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-05-07 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Web Browser crashes when trying to browse to Hertz.com
http://bugs.webkit.org/show_bug.cgi?id=13616

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):

7:35 AM Changeset in webkit [21304] by spadma

2 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: KPOY-72NW5X - Memory Testing: Phone resets while running

browser memory testing. Return from foreground event
without processing if in performance mode

http://bugs.webkit.org/show_bug.cgi?id=13589

BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):

7:31 AM Changeset in webkit [21303] by spadma

10 edits
2 adds in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: S60 3.2 Touch: Scrolling initial implementatoin
http://bugs.webkit.org/show_bug.cgi?id=13561

BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL):
BrowserView/inc/PointerEventHandler.h:
BrowserView/inc/ScrollingIndicatorDrawer.h: Added.
BrowserView/inc/WebKitView.h:
BrowserView/src/PointerEventHandler.cpp: (ContentScrollCallback): (CPointerEventHandler::~CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::CheckSmartTextEntry): (CPointerEventHandler::GetFrameAt): (CPointerEventHandler::HandleScrollingPointerEventL): (CPointerEventHandler::HandleShouldStartScrollingL): (CPointerEventHandler::HandleDragL): (CPointerEventHandler::HandleContentScroll): (CPointerEventHandler::UpdateCursor):
BrowserView/src/ScrollingIndicatorDrawer.cpp: Added. (CScrollingIndicatorDrawer::NewL): (CScrollingIndicatorDrawer::CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::~CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::ConstructSprite): (CScrollingIndicatorDrawerEdge::CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::ConstructL): (CScrollingIndicatorDrawerEdge::~CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::UpdateBitmapPositionL): (CScrollingIndicatorDrawerEdge::CreateBitmapAndContextL): (CScrollingIndicatorDrawerEdge::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::ConstructL): (CScrollingIndicatorDrawerAccelerated::~CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::UpdateBitmapPositionL): (CScrollingIndicatorDrawerAccelerated::CheckNeedRefrech): (CScrollingIndicatorDrawerAccelerated::CreateBitmapAndContextL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskExL):
BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
BrowserView/src/WebKitView.cpp: (CWebKitView::ContentIsScrolling):
ChangeLog:
Plugin/inc/PluginWin.h:
Plugin/src/PluginWin.cpp: (CPluginWin::PluginConstructedL): (CPluginWin::ForceRedraw): (CPluginWin::HitRegionContains):
group/BrowserView.mmp:

7:05 AM Changeset in webkit [21302] by lars

14 edits in trunk

Reviewed by Zack.

Adjust tests that have console output, now that it's added by
DumpRenderTree.

Dump JavaScript console messages as well. Also requires a slight
change in run-webkit-tests, so we still correctly differentiate
between text only and rendertree tests.

4:40 AM Changeset in webkit [21301] by lars

15 edits
5 adds in trunk/LayoutTestResults

Update the baseline for traversal/ and add a few missing results in
tables/

3:57 AM Applications using WebKit edited by joe@funkeemonk.com

Added listing to FunkeeStory (diff)

3:26 AM Changeset in webkit [21300] by lars

3 edits in trunk/WebKitTools

Reviewed by Zack

Specify what the serif, sans-serif and monospace aliases
should map to and explicitly select the Gui style of
DRT to be plastique.

Fixes most of the test failures still seen on the build bot.

1:29 AM Changeset in webkit [21299] by lars

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix valgrind reported uninitialized memory read.

1:22 AM Changeset in webkit [21298] by justing

3 edits
12 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

This tests to see that the focus of a focusable node
inside an already focused node is delayed until mouse up:

editing/selection/4895428-2-expected.checksum: Added.
editing/selection/4895428-2-expected.png: Added.
editing/selection/4895428-2-expected.txt: Added.
editing/selection/4895428-2.html: Added.

We delay focus until mouse up, but only if that node is
inside an already focused node:

editing/selection/4895428-3-expected.checksum: Added.
editing/selection/4895428-3-expected.png: Added.
editing/selection/4895428-3-expected.txt: Added.
editing/selection/4895428-3.html: Added.

This demonstrates the bug:

editing/selection/4895428-4-expected.checksum: Added.
editing/selection/4895428-4-expected.png: Added.
editing/selection/4895428-4-expected.txt: Added.
editing/selection/4895428-4.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

The user tries to drag a selection by mousing down
on the editable part of a ToDo, which is focusable,
since it is an editable node within non-editable
content. But we focus focusable elements on mouse
down, and focusing the editable piece blows away
the selection and prevents the drag. This is how
IE behaves, but content seems generally difficult
to drag in IE, so this doesn't make it any worse.

Since focus doesn't appear to be cancelable, either
with a DOM event or an editing delegate, I fixed this
by delaying the focus of focusable nodes that are
selected and inside an already focused node. The
node will be focused if the user mouses up without
doing any dragging because the mouse up sets a
selection, which calls setFocusNodeIfNeeded.

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):

1:07 AM Changeset in webkit [21297] by bdash

4 edits in trunk

Versioning.

1:03 AM Changeset in webkit [21296] by bdash

1 copy in tags/Safari-5522.7

New tag.

May 7, 2007:

10:41 PM Changeset in webkit [21295] by oliver

2 edits in trunk/WebCore

2007-05-07 Atul Mehrotra <atul.mehrotra@celunite.com>

Reviewed by Maciej.

GDK Build fix

platform/gdk/TemporaryLinkStubs.cpp:

9:59 PM Changeset in webkit [21294] by oliver

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test the behaviour of canvas methods called with inf/nan parameters

fast/canvas/canvas-with-incorrect-args-expected.txt: Added.
fast/canvas/canvas-with-incorrect-args.html: Added.

WebCore:

Reviewed by Maciej.

Correcting comparisons to handle NaN in the same manner
as other Canvas methods.

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): Correcting arc/arcTo to match the WHAT WG draft. (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

5:57 PM Changeset in webkit [21293] by hyatt

4 edits in trunk/WebCore

Add some comments to the glyph/font code (patch from MarvinD, tweaked by
me to correct a few bits and to make it forward-compatible with the work
going on in 3315.

Reviewed by me

ChangeLog:
platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
platform/GlyphPageTreeNode.h:

4:55 PM Changeset in webkit [21292] by justing

2 edits in trunk/WebCore

Fix layout test failures.

editing/SelectionController.cpp: (WebCore::SelectionController::contains): Use comparePositions instead of Range::comparePoint, because comparePositions can handle positions inside shadow trees.

4:37 PM Changeset in webkit [23347] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-05-07 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix typo in prefs code.

WebPreferences.cpp: (WebPreferences::preferencesPath): Fix typo in error handling.

4:01 PM Changeset in webkit [23346] by aliceli1

5 edits
2 adds in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
into ClipboardUtilitiesWin.h/cpp.

WebCore.vcproj/WebCore.vcproj:
platform/win/ClipboardUtilitiesWin.cpp: Added. (WebCore::cfHDropFormat): (WebCore::getWebLocData): (WebCore::extractURL): (WebCore::texthtmlFormat): (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCF_HTML): (WebCore::fragmentFromHTML): (WebCore::containsHTML):
platform/win/ClipboardUtilitiesWin.h: Added.
platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeRange):
platform/win/DragDataWin.cpp:
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):

3:15 PM Changeset in webkit [21291] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

editing/selection/4895428-1-expected.checksum: Added.
editing/selection/4895428-1-expected.png: Added.
editing/selection/4895428-1-expected.txt: Added.
editing/selection/4895428-1.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

The code in SelectionController::contains returned false
incorrectly if the selection end just after a table
and the position was inside that table.

editing/SelectionController.cpp: (WebCore::SelectionController::contains): Compare the position with the ends of the selection and then use Range::comparePoint.

3:09 PM Changeset in webkit [21290] by beidson

2 edits in trunk/WebKit

Actually finish the code move from my last checkin

History/WebHistoryItem.mm: (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):

2:57 PM Changeset in webkit [21289] by beidson

4 edits in trunk/WebKit

Rubberstamped by Kevin (Sarge)

Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

History/WebHistoryItemInternal.h:
History/WebHistoryItemPrivate.h:

1:23 PM Changeset in webkit [23345] by sfalken

1 add in branches/WindowsMerge/WebCore/platform/win/TextBreakIteratorInternalICUWin.cpp

Forgot to check in this file.

10:25 AM Changeset in webkit [21288] by darin

2 deletes in trunk/LayoutTests/fast/dom/HTMLElement

Removed files. Not sure why they didn't get removed before.

9:25 AM Changeset in webkit [21287] by darin

4 edits in trunk

LayoutTests:

rolling out setInnerHTML optimization until I can figure out why tests are failing

WebCore:

rolling out setInnerHTML optimization until I can figure out why tests are failing

8:34 AM Changeset in webkit [21286] by brmorris

1 edit
1 delete in S60/trunk/LayoutTests

brmorris, reviewed by nobody

DESC: This is actually a resource file, not a test case.

fast/js/new-location.html: Removed.

8:04 AM Changeset in webkit [21285] by lars

912 edits in trunk/LayoutTestResults

Reviewed by Zack.

New baseline for the table tests.
Skip the fast tests for now.

7:45 AM Changeset in webkit [21284] by darin

4 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html

html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.

dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.

6:56 AM Changeset in webkit [21283] by lars

8 edits
6 adds in trunk

Change 5 results in css2.1 that were wrong due to a Qt bug.
Add css3 baseline.

Fix the default font in DRT to 9pt Sans Serif.

12:07 AM Changeset in webkit [21282] by lars

486 edits in trunk/LayoutTestResults

New baseline for the css2.1 tests.

May 6, 2007:

8:07 PM Changeset in webkit [21281] by darin

2 edits in trunk/WebCore

blind try at fixing the Qt build

platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator): Added a placeholder.

8:03 PM Changeset in webkit [21280] by darin

5 edits
2 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13537

fast/canvas/drawImage-with-invalid-args.html: Changed to a dumpAsText test. Added logging and a negative-size test.
fast/canvas/drawImage-with-invalid-args-expected.txt: Updated.

fast/canvas/drawImage-with-invalid-args-expected.checksum: Removed.
fast/canvas/drawImage-with-invalid-args-expected.png: Removed.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13537 Canvex example starts rendering strangely after a while

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Don't raise an exception if the source or destination rectangle is empty.

7:57 PM Changeset in webkit [21279] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page header are drawn with too-large font and clipped

Doesn't affect text within web pages, so no layout test.

platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Base the substitute font on the FontPlatformData rather than the FontDescription. Before, it was a mix of both. This works properly for fonts where we have no FontDescription and is also more internally consistent.

7:56 PM Changeset in webkit [21278] by darin

12 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13606 some functions are virtual that don't need to be

dom/Node.h: Made first/lastChild be inline functions that call virtual functions. This lets us hide the functions with another inline function in a derived class, yet still override the behavior here in the base class by overriding the virtual functions too.
dom/Node.cpp: (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now non-virtual inline functions that call these virtual functions. (WebCore::Node::virtualLastChild): Ditto.

dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones inherited from the Node class; these also replace the fastFirst/LastChild functions, and transparently give callers the faster form if they have a pointer of the right type. But still override the virtual functions named virtualFirst/LastChild, because those can still be called through a Node*. Removed the "fast" from the names of fastSetFirst/LastChild.
dom/ContainerNode.cpp: (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now also non-virtual inline versions. (WebCore::ContainerNode::virtualLastChild): Ditto.

dom/CharacterData.cpp: Removed implementations of data and length functons.
dom/CharacterData.h: Made data, setData, length, substringData, appendData, insertData, deleteData, and replaceData all non-virtual, and made data and length both be inline.

dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check from this function. If the length of the map is known to be greater than 0, then the null check isn't needed. But if the length of the map hasn't been checked at all, then it's unsafe to call this function since it doesn't range check the array index. Thus the null check is never needed. I also looked at all callers.

dom/Attr.cpp: (WebCore::Attr::createTextChild):
dom/Document.cpp: (WebCore::Document::recalcStyle):
dom/Element.cpp: (WebCore::Element::recalcStyle):
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::haveLoadedRequiredResources): Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld. It's not needed any more -- you still get fast behavior if the pointer has a type that's ContainerNode or derived from it.

7:36 PM Changeset in webkit [21277] by bdash

3 edits in trunk

2007-05-06 Erik Bunce <kde@bunce.us>

Reviewed by Mark Rowe.

WebKit.pri: Removed unnecessary dependency on MacPorts (/opt/local)

2007-05-06 Erik Bunce <kde@bunce.us>

Reviewed by Mark Rowe.

WebCore.pro: Removed unnecessary dependency on MacPorts (/opt/local)

9:42 AM Changeset in webkit [21276] by ap

4 edits
4 adds in trunk

2007-05-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13557 Crash when dragging selection over absolutely positioned generated content on block element

Test: fast/css-generated-content/positioned-background-hit-test-crash.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer(). (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346> from r6106 to the self hit test as well, namely: return the enclosing element for generated positioned content.
rendering/RenderLayer.h:

9:05 AM Changeset in webkit [21275] by ap

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13584
<script> code wrongly assumes requests can't fail

Test: fast/loader/unloadable-script.html

html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): Check the return value of requestScript().

May 5, 2007:

10:17 PM Changeset in webkit [21274] by ap

5 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13304
REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences

Implemented a notification observer that invalidates cached system colors.

No automated test possible.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionBackgroundColor): (WebCore::RenderTheme::inactiveSelectionBackgroundColor): (WebCore::RenderTheme::platformColorsDidChange):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (WebCore::theme): (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac): (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::button): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):

4:23 PM Changeset in webkit [21273] by kevino

1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Run *-config scripts when running make, not when generating the makefiles.

3:53 AM Changeset in webkit [21272] by rwlbuis

28 edits in trunk/WebCore

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13592
parseMappedAttribute inconsistency

Do not use local vars in parseMappedAttribute for attr name and value.

12:10 AM Changeset in webkit [21271] by oliver

2 edits in trunk/WebCore

Reviewed by Hyatt.

Initialise default fill with Color::black rather than parsing
the string "black"

ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill):

May 4, 2007:

9:19 PM Changeset in webkit [23344] by sfalken

5 edits in branches/WindowsMerge

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebView.cpp: (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.

9:08 PM Changeset in webkit [21270] by sfalken

9 edits
2 adds in trunk/WebCore

Reviewed by Oliver.

Use TextBreakIterator for sentence breaking instead of TextBoundaries.

WebCore.xcodeproj/project.pbxproj: Added TextBreakIeratorInternalICUMac.mm
editing/visible_units.cpp: (WebCore::startSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::endSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::previousSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::nextSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
platform/TextBoundaries.h: Removed findSentenceBoundary, findNextSentenceFromIndex.
platform/TextBreakIterator.h: Added sentenceBreakIterator.
platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Add locale parameter (needed to maintain functionality that TextBoundaries code had). (WebCore::characterBreakIterator): Pass en_us for locale (same as old code). (WebCore::wordBreakIterator): Pass en_us for locale (same as old code). (WebCore::lineBreakIterator): Pass en_us for locale (same as old code). (WebCore::sentenceBreakIterator): Added.
platform/TextBreakIteratorInternalICU.h: Added.
platform/gdk/TemporaryLinkStubs.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary. (WebCore::currentTextBreakLocaleID): Added stub.
platform/mac/TextBoundaries.mm: Removed currentTextBreakLocaleID, findSentenceBoundary, findNextSentenceFromIndex.
platform/mac/TextBreakIteratorInternalICUMac.mm: Added. (WebCore::currentTextBreakLocaleID): Moved from TextBoundaries.mm
platform/qt/TextBoundaries.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.

5:17 PM Changeset in webkit [21269] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5116871> REGRESSION: Can't select options in widget's listbox

Don't use user-select to determine whether or not options can be selected in listboxes.
This will match Firefox behavior for -moz-user-select.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

4:50 PM Changeset in webkit [21268] by thatcher

1 edit in tags/JavaScriptCore-418.5/JavaScriptCore/Info.plist

Versioning

4:49 PM Changeset in webkit [21267] by thatcher

1 copy in tags/JavaScriptCore-418.5

New tag.

4:47 PM Changeset in webkit [21266] by thatcher

1 edit in branches/Safari-2-0-branch/JavaScriptCore/kjs/collector.cpp

Build fix.

4:46 PM Changeset in webkit [21265] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Reverting commit to the wrong tag.

4:43 PM Changeset in webkit [21264] by thatcher

1 delete in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

Removing bad tag.

4:40 PM Changeset in webkit [21263] by thatcher

1 edit in tags/JavaScriptCore-418.4/JavaScriptCore/kjs/collector.cpp

Build fix.

4:39 PM Changeset in webkit [21262] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Versioning

4:39 PM Changeset in webkit [21261] by ggaren

8 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

WebCore.exp:
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
history/HistoryItem.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::purgePageCache):

WebKit:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

I left -setAlwaysAttemptToUsePageCache: as an empty stub because we don't
want to break Safari 2.0, but I removed its header declaration so nobody
else starts using it.

History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
History/WebHistoryItemPrivate.h:

4:38 PM Changeset in webkit [21260] by thatcher

1 copy in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

New tag.

4:38 PM Changeset in webkit [21259] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Merge fix from r16614 (with build fix).

2:15 PM Changeset in webkit [21258] by ggaren

10 edits in trunk

WebCore:

Reviewed by Brady Eidson.

Removed export of clearPageCache(), since it was unused externally. I plan
to remove its use from WebCore eventually, too.

Removed usesPageCache(), since it was unused and it duplicated pageCacheSize().

WebCore.exp:
history/BackForwardList.cpp:
history/BackForwardList.h: Moved statics to the top of the class definition.
loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):

WebKit:

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

Unified naming of WebKit/WebCore b/f lists -- instead of the potpourri
of webBackForwardList, backForwardList, list, kitList, coreList, listWrapper,
and webCoreBackForwardList, we use webBackForwardList for WebKit and
backForwardList for WebCore, matching their respective class names.

Removed "private" versions of kit() and core() -- kit() and core() are
canonically used for converting between WebKit API objects and WebCore
API objects. I think it's clearer to have only one way to do this.

Removed COMPUTE_DEFAULT_PAGE_CACHE_SIZE, since it was unused.

Removed _clearPageCache, since it was unused and it duplicated -setPageCacheSize:0.

Removed _usesPageCache, since it was unused and it duplicated -pageCacheSize.

11:19 AM Changeset in webkit [23343] by aliceli1

3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()

platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):

10:38 AM Changeset in webkit [21257] by darin

2 edits in trunk

Added bugs.webkit.org URL.

10:14 AM Changeset in webkit [21256] by darin

5 edits in trunk

JavaScriptCore:

Reviewed by Adele.

fix <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Added a call to fabs before calling log10.

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

fast/js/kde/resources/Number.js: Added negative number versions of some tests of toFixed, toExponential, toPrecision, etc.
fast/js/kde/Number-expected.txt: Updated, new tests all passing.

10:13 AM Changeset in webkit [21255] by beidson

2 edits in trunk/WebKit

Reviewed by Mark Rowe

Added main thread assertion to WebHTMLView to help make sure 3rd party clients aren't trying
to draw on secondary threads

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Added ASSERT_MAIN_THREAD()

9:42 AM Changeset in webkit [21254] by bdash

7 edits in trunk

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

Restore behavior to matching release WebKit by adding a response URL to SubstituteData. If a nil base URL is
passed, set the _request_ URL to "about:blank", but the response URL to a generated "applewebdata" URL.

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): First, check for the SubstituteData's response URL.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
No need to special case applewebdata URLs here, they're only used in the response.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): If the substitute data has a response URL, use it.

(WebCore::MainResourceLoader::loadNow):
Only load "about:blank" as an empty document if there's no substitute data.

loader/SubstituteData.h: (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::responseURL): Add responseURL member to SubstituteData.

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If the base URL is nil, set it to "about:blank", and set the response URL to a generated applewebdata URL.

WebView/WebView.mm: (+[WebView _canHandleRequest:]): No need to special-case applewebdata URLs here anymore, they're only used in responses.

5:25 AM Changeset in webkit [21253] by lars

2 edits in trunk/WebKitTools

Reviewed by Zack

Revert on line of the last commit. We still want to keep the RPATH
support in the pro file.

4:41 AM Changeset in webkit [21252] by lars

112 edits
1 add
15 deletes in trunk

Reviewed by Zack

Remove the old bitmap fonts I tried using to get reliable results from
DumpRenderTree on X11. Instead we now use the URW Type1 fonts from
ghostscript. I've added a mirror to simply check them out at
svn://labs.trolltech.com/svn/webkit/testfonts.

Fixed DumpRenderTree to make sure these fonts are the only ones we use
on X11 and added a fonts.conf file to get a well defined fontconfig
configuration.

Made sure run-webkit-tests forwards the WEBKIT_TESTFONTS environment variable
I use to find the fonts to DumpRenderTree.

Updated results for css1 to work with the new set of fonts.
Will update the other results once I see this works on all
machines we have.

1:07 AM Changeset in webkit [21251] by bdash

2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Versioning.

1:05 AM Changeset in webkit [21250] by bdash

2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Merge r16614.

12:56 AM Changeset in webkit [21249] by bdash

1 copy in tags/JavaScriptCore-418.4

New tag.

12:52 AM Changeset in webkit [21248] by bdash

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merge r16614.

12:43 AM Changeset in webkit [21247] by bdash

3 edits in branches/Safari-2-0-branch/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

May 3, 2007:

11:59 PM Changeset in webkit [23342] by sfalken

8 edits in branches/WindowsMerge

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

Spelling panel is now partially functional with this check-in.
Learn/Ignore not yet implemented, Find Next, Correct, language
selection, grammar toggle works.

Grammar checking is functional with this check-in.

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
WebEditorClient.h:
WebView.cpp: (WebView::replaceSelectionWithText): Implemented.

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

platform/win/EditorWin.cpp: (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake). (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error. (WebCore::isRangeUngrammatical): Include user description with spelling error.

11:44 PM Changeset in webkit [21246] by sfalken

10 edits in trunk

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

bridge/EditorClient.h:
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
WebCoreSupport/EditorClientQt.h:

11:14 PM Changeset in webkit [23341] by aliceli1

3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted

platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment):

11:05 PM Changeset in webkit [23340] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Steve

Fix misuse of GlobalLock.

platform/win/PasteboardWin.cpp: (WebCore::createGlobalData):

9:35 PM Changeset in webkit [21245] by beidson

6 edits in trunk/WebCore

Reviewed by Oliver

Resolve an outstanding FIXME in Loader::numRequests()

Before, numRequests() would iterate through the list of requests pending load and the list of currently
loading requests and tally up a count matching the current DocLoader.

I noticed while studying and cleaning up the loader code that numRequests() is potentially very hot!
Indeed load a complex site with many resources and multiple frames, and this method gets called very often,
tallying up this number every time.

The FIXME was to keep a collection of Requests mapped to each DocLoader. In reality, since this map would
simply be used for retrieving a count, that was overkill. Keeping a request count in the DocLoader itself
along with maintaining that count in Loader as requests come and go is a much better way to do this.

loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::incrementRequestCount): (WebCore::DocLoader::decrementRequestCount): (WebCore::DocLoader::requestCount): Emulate the defunct Loader::numRequests()
loader/DocLoader.h:

loader/FrameLoader.cpp: (WebCore::numRequests): Call DocLoader::requestCount() directly (WebCore::FrameLoader::checkCompleted): Use numRequests()

loader/loader.cpp: (WebCore::Loader::load): Increment the DocLoader's request count (WebCore::Loader::servePendingRequests): If the SubresourceLoader failed to create, decrement the count (WebCore::Loader::didFinishLoading): If the Request is not Multipart, decrement the count (WebCore::Loader::didFail): If the Request is not Multipart, decrement the count (WebCore::Loader::didReceiveResponse): If the Request becomes Multipart, decrement the count (WebCore::Loader::cancelRequests): Decrement the count for the pending requests being tossed, and ASSERT the count is zero after all requests have been cancelled
loader/loader.h:

9:34 PM Changeset in webkit [23339] by oliver

3 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Steve.

Add logic to draw underlines for grammar and spelling errors.
(rdar://problem/4769832)

platform/win/GraphicsContextWin.cpp: (WebCore::spellingPatternColor): (WebCore::grammarPatternColor): Can't define global const with constructor so use function scoped globals instead. (WebCore::setCGStrokeColor): Utility function pulled over from GraphicsContextCG (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):

platform/win/TemporaryLinkStubs.cpp: Remove old drawLineForMisspellingOrBadGrammar stub

8:55 PM Changeset in webkit [21244] by ggaren

3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Moved "Can I cache this page?" logic to canCachePage(). Moved "I am caching this page" logic to cachePageToHistoryItem(). (WebCore::FrameLoader::canCachePage): Moved above logic here. (WebCore::FrameLoader::cachePageToHistoryItem): Removed bogus NULL check and failure return value. Moved above logic here. Don't call setCachedPage() until the CachedPage is fully constructed. (WebCore::FrameLoader::purgePageCache): Removed comment that duplicated the function name.
loader/FrameLoader.h:

6:54 PM Changeset in webkit [21243] by harrison

2 edits in trunk/WebCore

Reviewed by harrison.

<rdar://problem/5120281> CrashTracer: [USER] 1 crash in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties() const

Problem is that checkAncestor and lastClosed can be nil when createMarkup is called unrendered nodes, and that was not checked for.

editing/markup.cpp: (WebCore::createMarkup): Nil-check checkAncestor and lastClosed.

5:51 PM Changeset in webkit [21242] by bdash

1 copy in tags/Safari-4522.7

New tag.

5:50 PM Changeset in webkit [21241] by bdash

4 edits in branches/Safari-522

Versioning.

4:08 PM Changeset in webkit [21240] by thatcher

2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/4975212> REGRESSION: With NetNewsWire 2.1.1, the contextual menu shows extra menu items when focus
is placed in input or textarea field

The NetNewsWire UI delegate isn't expecting calls for form controls, so we need to do a linked-on-or-after check.
If the application was linked against Tiger or earlier and the element is a text form control, just return the
default menu items and bypass the delegate call completely.

WebCoreSupport/WebContextMenuClient.mm: (isPreVersion3Client): Cache the result of the WebKitLinkedOnOrAfter call (fixMenusToSendToOldClients): Call the new isPreVersion3Client() (fixMenusReceivedFromOldClients): Ditto. (WebContextMenuClient::getCustomMenuFromDefaultItems): Return the default menu items if the element is a text form control.

3:50 PM Changeset in webkit [21239] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21238.

3:48 PM Changeset in webkit [21238] by bdash

2 edits in trunk/WebKit

2007-05-03 Mark Rowe <mrowe@apple.com>

Reviewed by Geoff and Kevin.

<rdar://problem/5141290> WebAssertions.h is still needed by some internal clients

Second shot at fixing this error. Stub out the macros rather than forwarding to JavaScriptCore, which would
leave clients using this header trying to resolve JavaScriptCore symbols against WebKit when linking. This
should only happen in production builds when assertions should be disabled anyway as anyone building a
development configuration should be in a position to move away from using this header.

Misc/WebAssertions.h:

3:23 PM Changeset in webkit [21237] by thatcher

2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/5016318> Contextual menu item for opening links is missing in compose windows but present in viewer

Add the Open Link, Open Link in New Window, Download Linked File and Copy Link menu
items to the content editable context menu.

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

3:10 PM Changeset in webkit [21236] by brmorris

2 edits in S60/trunk/WebKit

brmorris, reviewed by sachin

DESC: stub this out in SDK development environment:

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):

3:04 PM Changeset in webkit [21235] by hausmann

14 edits
1 add in trunk

Gdk build fixes using the Qt build's qmake tool from Holger Freyther, reviewed by Zack.

2:50 PM Changeset in webkit [21234] by thatcher

2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5067707> REGRESSION: "Open Link" contextual menu item appears twice in Mail

Remove the check for Mail in fixMenusToSendToOldClients and fixMenusReceivedFromOldClients
when linked on or after Leopard. The isAppleMail() function is still used for Tiger Mail fixups.

WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): (fixMenusReceivedFromOldClients):

2:37 PM Changeset in webkit [21233] by adele

2 edits in trunk/WebCore

Use BUILDING_ON_TIGER.

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):

2:35 PM Changeset in webkit [21232] by beidson

3 edits in trunk/WebCore

Reviewed by Darin

Some more minor cleanup that resolves a FIXME and ditches another pointless method

No change in functionality == no layout test

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Updated a comment (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Folded startLoading() into this method (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): continueAfterWillSubmitForm becomes continueLoadAfterWillSubmitForm
loader/FrameLoader.h: Removed startLoading()

2:30 PM Changeset in webkit [21231] by brmorris

3 edits in S60/trunk/S60Internals

brmorris, reviewed by rasvcan

DESC: land some changes to wmlengine that i forgot to commit :(

S60DynamicLibs.zip: updated wmlengine.lib
S60Headers.zip: updated wmlengineinterface.h

2:29 PM Changeset in webkit [21230] by adele

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4727607> REGRESSION: KeyScript is deprecated, need a new solution for forcing Roman input for password fields on Leopard

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Use TSMSetDocumentProperty and TSMRemoveDocumentProperty on Leopard disable and enable non-ascii input sources.

11:50 AM Changeset in webkit [21229] by beidson

3 edits in trunk/WebCore

Reviewed by Anders

commitProvisionalLoad() was the name of two methods.
One of them was private and only called from one other private place.
This was driving me crazy. I had to change that.

No change in functionality == no layout test

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): roll commitProvisionalLoad() into this method
loader/FrameLoader.h: Removed commitProvisionalLoad()

11:37 AM Changeset in webkit [21228] by ggaren

2 edits in trunk/WebKitTools

Build fix: Add AllInOneFile.o to the ignore list, since it includes files
in the ignore list.

Scripts/check-for-global-initializers:

9:23 AM Changeset in webkit [21227] by darin

6 edits in trunk/WebCore

Reviewed by Anders.

make ICU initialization lazy to speed up application start-up time (when it includes an initial webpage load)

platform/TextCodecICU.h: Replaced registerEncodingNames and registerCodecs with registerBaseEncodingNames, registerBaseCodecs, registerExtendedEncodingNames, and registerExtendedCodecs.
platform/TextCodecICU.cpp: (WebCore::newTextCodecICU): Moved up to the top of the file. (WebCore::TextCodecICU::registerBaseEncodingNames): Added. Registers just UTF-8. (WebCore::TextCodecICU::registerBaseCodecs): Ditto. (WebCore::TextCodecICU::registerExtendedEncodingNames): Renamed. (WebCore::TextCodecICU::registerExtendedCodecs): Ditto. (WebCore::TextCodecICU::createICUConverter): Compare with the name "GBK" in a way that does not require extending the maps.

platform/TextEncoding.cpp: (WebCore::TextEncoding::usesVisualOrdering): Added code so this will just return false if we haven't used any extended encoding names yet. The result will be correct, and we won't ask for an encoding name that will require registering the extended encoding names. (WebCore::TextEncoding::isJapanese): Ditto. (WebCore::TextEncoding::backslashAsCurrencySymbol): Ditto, but return a backslash instead of false.

platform/TextEncodingRegistry.h: Added a new function named noExtendedTextEncodingNameUsed.
platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added. Registers the base encodings, including Latin-1 because it's the default, and the UTF encodings. (WebCore::extendTextCodecMaps): Added. Registers all the other encodings. (WebCore::newTextCodec): Removed the all to buildTextCodecMap because we always build the map when making the canonical encoding name. (WebCore::atomicCanonicalTextEncodingName): Changed code to build only the base maps at first, then extend the maps the first time we run into a name we don't know. (WebCore::noExtendedTextEncodingNameUsed): Added.

May 2, 2007:

9:39 PM Changeset in webkit [21226] by bdash

2 edits in trunk/WebCore

2007-05-03 Mark Rowe <mrowe@apple.com>

Qt build fix. In r21185 the Qt version of WebCore::scaleDragImage was
updated to have the incorrect signature.

platform/qt/DragImageQt.cpp: (WebCore::scaleDragImage):

3:27 PM Changeset in webkit [21225] by bdakin

2 edits in trunk/WebCore

dom/Node.h: Just fixing a variable name because it's driving me mad.

3:16 PM Changeset in webkit [21224] by bdakin

15 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4513966> Never-ending identical repaint @
orbitz.com (Safari eating 85% CPU)

We need to be a little bit more savvy about when we do a FULL style
recalc since it can be unnecessary and expensive.

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setChanged): Now takes a StyleChangeType as a parameter. (WebCore::CSSMutableStyleDeclaration::setProperty): Send InlineStyleChange as the paramter. This is the optimization!
css/CSSMutableStyleDeclaration.h: setChanged takes a StyleChangeType as a parameter.
dom/Document.cpp: setChanged now takes a StyleChangeType instead of a bool. (WebCore::Document::recalcStyle): Same.
dom/Element.cpp: (WebCore::Element::recalcStyle): This is the fix!! Only set change to Force is we use descendant rules AND it's a FullStyleChange.
dom/Node.cpp: m_hasStyle was an unused bit on Node, so this patch gets rid of it and uses that extra bit for m_changed to be a StyleChangeType instead of a bool. (WebCore::Node::Node): (WebCore::Node::setChanged): (WebCore::Node::dump):
dom/Node.h: Same. (WebCore::): Define the StyleChangeType enum. (WebCore::Node::hasClass): (WebCore::Node::changed): (WebCore::Node::styleChangeType): (WebCore::Node::setHasClass):
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't bother calling setHasStyle() since m_hasStyle is gone now. It was never used, and this was the only place it was set.
dom/Text.cpp: (WebCore::Text::recalcStyle): setChanged now takes a StyleChangeType instead of a bool.
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Same.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::restoreState): Same. (WebCore::HTMLSelectElement::reset): Same.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Same.
ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::applyAnimations): Same.
ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle): Same.
platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::repaintClients): Same.

12:36 PM Changeset in webkit [21223] by andersca

2 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5151113> Assertion firing in [FrameProgressEntry addChild:forDataSource:] when navigating cnn.com

The assertion fired because a plug-in was trying to load a subresource when a new load had started but not yet
committed. The check that would have prevented this was removed in order to fix <rdar://problem/5085897>.

This puts back the check but changes it to allow loads where the target is the same frame as the plugin's parent frame.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

7:54 AM Changeset in webkit [21222] by harrison

3 edits in trunk/WebCore

Reviewed by Antti.

<rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence

Restore the remainder of the original fix now that blocking bug rdar://5174862 is addressed.

John made the original patch on 2007-04-10, but this fell prey to rdar://5157329.
Justin backed out the whole patch on 2007-04-30 to avoid the crash.
Justin then restored most of the original patch, but used word granularity instead, to keep the build working.
I just addressed the root cause of rdar://5157329 in rdar://5174862.
This patch switches the temp uses of word granularity back to sentence granularity.

editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

6:11 AM Changeset in webkit [21221] by harrison

6 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Added insertion support for more than one value.

wtf/Vector.h: (WTF::::insert): Added support for inserting multiple values.

(WTF::::prepend):
New. Insert at the start of vectors. Convenient for vectors used as strings.

LayoutTests:

Reviewed by Antti.

test for <rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

editing/selection/move-by-sentence-001-expected.checksum: Added.
editing/selection/move-by-sentence-001-expected.png: Added.
editing/selection/move-by-sentence-001-expected.txt: Added.
editing/selection/move-by-sentence-001.html: Added.

WebCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Test added: editing/selection/move-by-sentence-001.html

editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): Use a UChar Vector instead of DeprecatedString. Avoid creating an extra string for secure bullet replacement unless it is actually needed.

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::insert): Call forceUnicode() before setLength(), so that only the unicode buffer is resized.

(WebCore::DeprecatedString::setLength):

Adjust the unicode buffer even if the ascii buffer is valid.

2:21 AM Changeset in webkit [21220] by bdash

3 edits in trunk/WebKitTools

2007-05-02 Holger Freyther <freyther@kde.org>

Reviewed by Mark Rowe.

Scripts/build-webkit: Remove the CMake call.
Scripts/webkitdirs.pm: Remove isQtWithQMake as QMake is now the only buildsystem for the Qt port.

2:20 AM Changeset in webkit [21219] by bdash

6 edits in trunk/WebCore

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=13564 Remove friend class FrameLoader from Frame

No test added since there is no change in functionality.

loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
loader/FrameLoader.h: Made clear() private.
page/Frame.cpp: (WebCore::Frame::setDocument): Changed the argument into a PassRefPtr.
page/Frame.h:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

2:17 AM Changeset in webkit [21218] by bdash

3 edits
5 adds in trunk

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

Test: fast/replaced/image-resize-width.html

rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Moved the call to dirtyPrefWidths() before the call to calcWidth().

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

fast/replaced/image-resize-width-expected.checksum: Added.
fast/replaced/image-resize-width-expected.png: Added.
fast/replaced/image-resize-width-expected.txt: Added.
fast/replaced/image-resize-width.html: Added.
fast/replaced/resources/rectangle-red-200x100.png: Added.

1:44 AM Changeset in webkit [21217] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for dashboard bug.

1:39 AM Changeset in webkit [21216] by hyatt

2 edits in trunk/WebCore

Fix for bug 13566, broken Dashboard widgets. setPrefWidthsDirty did
the wrong thing for text children of a positioned element.

Reviewed by mitz

fast/block/positioning/pref-width-change.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty):

May 1, 2007:

6:40 PM Changeset in webkit [21215] by darin

2 edits in trunk/WebCore

rendering/RenderReplaced.cpp: Fix typo in a comment.

3:31 PM Changeset in webkit [21214] by hyatt

4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for 13558.

3:27 PM Changeset in webkit [21213] by hyatt

2 edits in trunk/WebCore

Fix for 13558, crash when using absolutely positioned generated content
inside an inline.

Reviewed by darin

fast/css-generated-content/absolute-position-inside-inline.html

rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):

3:20 PM Changeset in webkit [21212] by justing

12 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Demonstrates the bug:

editing/inserting/5002441-expected.checksum: Added.
editing/inserting/5002441-expected.png: Added.
editing/inserting/5002441-expected.txt: Added.
editing/inserting/5002441.html: Added.

Fixed. Spaces passed to execCommand("InsertText", ...)
are no longer collapsed:

editing/inserting/editable-html-element-expected.checksum:
editing/inserting/editable-html-element-expected.png:
editing/inserting/editable-html-element-expected.txt:
editing/pasteboard/4989774-expected.checksum:
editing/pasteboard/4989774-expected.png:
editing/pasteboard/4989774-expected.txt:
editing/selection/4983858-expected.checksum:
editing/selection/4983858-expected.png:
editing/selection/4983858-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Inserting a space under these circumstances inserts a single
text node containing a regular space and then does a layout.
That space isn't rendered (which is correct). Whitespace
rebalancing is supposed to correct it but failed. It replaces
the space with a non-breaking space, but that change doesn't
dirty line boxes (9441) and so the space isn't rendered.

This workaround turns all incoming spaces into non-breaking
spaces before they're inserted (they're rebalanced after
insertion and turned back into regular spaces if possible).

editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed an old irrelevant FIXME. (WebCore::InsertTextCommand::input): Turn incoming spaces into non breaking spaces before inserting them.

3:10 PM Changeset in webkit [21211] by darin

14 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
fast/canvas/canvas-size-change-after-layout-expected.png: Added.
fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
fast/canvas/canvas-size-change-after-layout.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

remove intrinsicWidth/Height functions from RenderObject

Test: fast/canvas/canvas-size-change-after-layout.html

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): Removed code to set the intrinsic size, because the renderer now takes care of this in its constructor. (WebCore::HTMLCanvasElement::reset): Instead of calling the setIntrinsicWidth/Height functions, call canvasSizeChanged, which takes care of layout, but only if the size actually changed. Also call repaint if the contents of the canvas changed.

rendering/RenderApplet.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicSize): Override the new intrinsicSize function. This override still doesn't make sense, so left a FIXME in here.

rendering/RenderBox.h: Added an intrinsicSize function here to replace the intrinsicWidth/Height functions removed from RenderObject.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing): Use intrinsicSize instead of intrinsicWidth. (WebCore::RenderBox::calcReplacedHeightUsing): Ditto, but for height.

rendering/RenderHTMLCanvas.h: Changed the constructor parameter to be an HTMLCanvasElement* instead of Node*. Also added a canvasSizeChanged function.
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Pass an initial intrinsic size based on the current size of the canvas element. This is now the responsibility of the renderer and the DOM element calls the canvasSizeChanged function when the size changes. (WebCore::RenderHTMLCanvas::paint): Removed checks of the type of the element, and used the node() function because we don't have to worry about the anonymous case in this class. (WebCore::RenderHTMLCanvas::canvasSizeChanged): Added. Changes the size and then calls setNeedsLayout and setPrefWidthsDirty as needed. I based the logic here on careful reading of RenderImage::imageChanged.

rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Pass a default intrinsic size of 0,0 instead of calling setIntrinsicWidth/Height. (WebCore::RenderImage::setImageSizeForAltText): Call the new intrinsic size functions instead of the width/height ones. Simplifies the logic since we handle both dimensions at once. (WebCore::RenderImage::imageChanged): Ditto. (WebCore::RenderImage::layout): Ditto. (WebCore::RenderImage::calcAspectRatioWidth): Ditto. (WebCore::RenderImage::calcAspectRatioHeight): Ditto.

rendering/RenderObject.h: Removed intrinsicWidth/Height virtual functions.

rendering/RenderReplaced.h: Replaced intrinsicWidth, intrinsicHeight, setIntrinsicWidth, setIntrinsicHeight, m_intrinsicWidth, and m_intrinsicHeight with intrinsicSize, setIntrinsicSize, and m_intrinsicSize.
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Added a second contructor that takes an intrinsic size parameter. Also updated constructor since the intrinsic size is now an IntSize instead of two integers. (WebCore::RenderReplaced::intrinsicSize): Added. No point in making this inline because it's a virtual function. (WebCore::RenderReplaced::setIntrinsicSize): Added. Didn't make this inline, partly because in the future we might want this to be more than just a simple setter function, factoring in common code used in both RenderImage and RenderHTMLCanvas.

rendering/RenderWidget.h: Removed a stray using declaration that wasn't needed.

2:37 PM Changeset in webkit [21210] by spadma

2 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin.padma@nokia.com>

DESC: Toolbar should be activated only on long keypress
http://bugs.webkit.org/show_bug.cgi?id=12816

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):

1:44 PM Changeset in webkit [23338] by sfalken

4 edits in branches/WindowsMerge

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix usage errors in COM enumeration.

WebEditorClient.cpp: (WebEditorClient::checkGrammarOfString): Call Next correctly. (WebEditorClient::getGuessesForWord): Call Next correctly.

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix crash when retrieving title of context menu after it has been selected.
Necessary to get spelling corrections code working.

platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.

1:11 PM Changeset in webkit [21209] by hyatt

4 edits in trunk/WebCore

Fix for hang when incorrectly trying to add before/after content to
a <select>. Disallow generated content in all selects and also turn it
off for <input> buttons.

Reviewed by aroben

rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
rendering/RenderButton.cpp: (WebCore::RenderButton::canHaveChildren):
rendering/RenderButton.h:

12:59 PM Changeset in webkit [21208] by darin

114 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

added a test for <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

fast/css/child-selector-implicit-tbody.html: Added.
fast/css/child-selector-implicit-tbody-expected.txt: Added.

updated test results for <rdar://problem/5172607> XML parser is creating implicit tbody elements; the only change is the tag name that's dumped

fast/table/037-expected.txt:
tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
tables/mozilla/marvin/x_caption_align_top-expected.txt:
tables/mozilla/marvin/x_caption_class-expected.txt:
tables/mozilla/marvin/x_caption_id-expected.txt:
tables/mozilla/marvin/x_caption_style-expected.txt:
tables/mozilla/marvin/x_col_align_center-expected.txt:
tables/mozilla/marvin/x_col_align_char-expected.txt:
tables/mozilla/marvin/x_col_align_justify-expected.txt:
tables/mozilla/marvin/x_col_align_left-expected.txt:
tables/mozilla/marvin/x_col_align_right-expected.txt:
tables/mozilla/marvin/x_col_span-expected.txt:
tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
tables/mozilla/marvin/x_col_valign_middle-expected.txt:
tables/mozilla/marvin/x_col_valign_top-expected.txt:
tables/mozilla/marvin/x_col_width_pct-expected.txt:
tables/mozilla/marvin/x_col_width_px-expected.txt:
tables/mozilla/marvin/x_col_width_rel-expected.txt:
tables/mozilla/marvin/x_colgroup_align_center-expected.txt:
tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
tables/mozilla/marvin/x_colgroup_align_justify-expected.txt:
tables/mozilla/marvin/x_colgroup_align_left-expected.txt:
tables/mozilla/marvin/x_colgroup_align_right-expected.txt:
tables/mozilla/marvin/x_colgroup_span-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
tables/mozilla/marvin/x_table_align_center-expected.txt:
tables/mozilla/marvin/x_table_align_left-expected.txt:
tables/mozilla/marvin/x_table_align_right-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_table_cellpadding-expected.txt:
tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
tables/mozilla/marvin/x_table_cellspacing-expected.txt:
tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
tables/mozilla/marvin/x_table_class-expected.txt:
tables/mozilla/marvin/x_table_id-expected.txt:
tables/mozilla/marvin/x_table_style-expected.txt:
tables/mozilla/marvin/x_table_width_pct-expected.txt:
tables/mozilla/marvin/x_table_width_px-expected.txt:
tables/mozilla/marvin/x_td_align_center-expected.txt:
tables/mozilla/marvin/x_td_align_char-expected.txt:
tables/mozilla/marvin/x_td_align_justify-expected.txt:
tables/mozilla/marvin/x_td_align_left-expected.txt:
tables/mozilla/marvin/x_td_align_right-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_td_class-expected.txt:
tables/mozilla/marvin/x_td_colspan-expected.txt:
tables/mozilla/marvin/x_td_height-expected.txt:
tables/mozilla/marvin/x_td_id-expected.txt:
tables/mozilla/marvin/x_td_nowrap-expected.txt:
tables/mozilla/marvin/x_td_rowspan-expected.txt:
tables/mozilla/marvin/x_td_style-expected.txt:
tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
tables/mozilla/marvin/x_td_valign_middle-expected.txt:
tables/mozilla/marvin/x_td_valign_top-expected.txt:
tables/mozilla/marvin/x_td_width-expected.txt:
tables/mozilla/marvin/x_th_align_center-expected.txt:
tables/mozilla/marvin/x_th_align_char-expected.txt:
tables/mozilla/marvin/x_th_align_justify-expected.txt:
tables/mozilla/marvin/x_th_align_left-expected.txt:
tables/mozilla/marvin/x_th_align_right-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_th_class-expected.txt:
tables/mozilla/marvin/x_th_colspan-expected.txt:
tables/mozilla/marvin/x_th_height-expected.txt:
tables/mozilla/marvin/x_th_id-expected.txt:
tables/mozilla/marvin/x_th_nowrap-expected.txt:
tables/mozilla/marvin/x_th_rowspan-expected.txt:
tables/mozilla/marvin/x_th_style-expected.txt:
tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
tables/mozilla/marvin/x_th_valign_middle-expected.txt:
tables/mozilla/marvin/x_th_valign_top-expected.txt:
tables/mozilla/marvin/x_th_width-expected.txt:
tables/mozilla/marvin/x_tr_align_center-expected.txt:
tables/mozilla/marvin/x_tr_align_char-expected.txt:
tables/mozilla/marvin/x_tr_align_justify-expected.txt:
tables/mozilla/marvin/x_tr_align_left-expected.txt:
tables/mozilla/marvin/x_tr_align_right-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_tr_class-expected.txt:
tables/mozilla/marvin/x_tr_id-expected.txt:
tables/mozilla/marvin/x_tr_style-expected.txt:
tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
tables/mozilla/marvin/x_tr_valign_top-expected.txt:
tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:

WebCore:

Reviewed by Hyatt.

removed the m_implicit bit from Node, freeing up a bit

fixed <rdar://problem/5172607> XML parser is creating implicit tbody elements
fixed <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

Test: fast/css/child-selector-implicit-tbody.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Removed code that used to look at implicitNode(), which no longer exists.

css/html4.css: Added a style rule to handle cases where we have a tr inside a table with no intervening table section.

dom/Node.h: Removed the bit.
dom/Node.cpp: (WebCore::Node::Node): Don't initialize the bit. (WebCore::Node::dump): Don't dump the bit.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Remove the code that made a table body element. This is handled in the render tree, the DOM tree should not be mangled. (WebCore::XMLTokenizer::endElementNs): Removed code that used to look at implicitNode(), which no longer exists.

html/HTMLElementFactory.cpp: (WebCore::tableSectionConstructor): Removed boolean parameter that was passed to the HTMLTableSectionElement constructor.
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::createTHead): Ditto. (WebCore::HTMLTableElement::createTFoot): Ditto. (WebCore::HTMLTableElement::insertRow): Changed to return a PassRefPtr, because it's possible the row could be removed from the table by JavaScript code responding to DOM mutation events before the function returns. Just something I noticed by code inspection.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::HTMLTableSectionElement): Removed boolean "implicit" parameter to the constructor. (WebCore::HTMLTableSectionElement::insertRow): Changed to return a PassRefPtr for the same reason cited above.

html/HTMLTableElement.h: Changed the return value of insertRow to be a PassRefPtr.
html/HTMLTableSectionElement.h: Ditto.

12:04 PM Changeset in webkit [21207] by sfalken

1 copy in tags/Safari-522.6.4b

New tag.

10:21 AM Changeset in webkit [21206] by bdash

1 edit in tags/WebKit-419.1/WebKit/Info.plist

Versioning.

10:20 AM Changeset in webkit [21205] by bdash

1 edit in tags/WebKit-419.1/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m

Reinstate a small portion of r20042 that was lost during the merge in r21111.

6:48 AM Changeset in webkit [21204] by bdash

10 edits
4 copies in branches/Safari-522

Merge r20923.

6:38 AM Changeset in webkit [21203] by bdash

3 edits
4 copies in branches/Safari-522

Merge r21062.

6:22 AM Changeset in webkit [21202] by bdash

3 edits
4 copies in branches/Safari-522

Merge r20490.

6:04 AM Changeset in webkit [21201] by bdash

3 edits
2 copies in branches/Safari-522

Merge r21175.

2:03 AM Changeset in webkit [21200] by ap

3 edits in trunk/JavaScriptCore

2007-05-01 Jungshik Shin <jungshik.shin@gmail.com>

Reviewed by Alexey.

get rid of non-ASCII lteral characters : suppress compiler warnings http://bugs.webkit.org/show_bug.cgi?id=13551

kjs/testkjs.cpp:
pcre/pcre_compile.c:

Apr 30, 2007:

11:05 PM Changeset in webkit [23337] by aliceli1

7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): As a consequence of <rdar://5126201>, removed call to webView->close() and patched leak resulting from that change.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
Basically this fix involved one thing, which lead to another thing. First, the crash
was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
WebViewWndProc when WM_DESTROY message is processed. We now want only WebKit handling
the closure of a WebView, so all calls to WebView::close have been removed, save for
the one call in WebViewWndProc.

Interfaces/IWebView.idl: removed close() from public interface
WebInspector/WebInspector.cpp: (WebInspector::onDestroy): removed call to close()
WebView.cpp: (WebView::~WebView): move the deleting of m_page down a bit to avoid a crash (WebView::close): changed from public API to just a public function (WebViewWndProc): webView->close() was moved here from SearchableWebView::onDestroy
WebView.h: changed close() to a public function not exposed in the WebKit interface

9:57 PM Changeset in webkit [21199] by hyatt

38 edits
4 adds in trunk

LayoutTests:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

fast/css-generated-content/table-cell-before-content-expected.checksum: Added.
fast/css-generated-content/table-cell-before-content-expected.png: Added.
fast/css-generated-content/table-cell-before-content-expected.txt: Added.
fast/css-generated-content/table-cell-before-content.html: Added.

WebCore:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

Added fast/css-generated-content/table-cell-before-content.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
rendering/RenderButton.h:
rendering/RenderContainer.cpp: (WebCore::RenderContainer::beforeAfterContainer): (WebCore::RenderContainer::updateBeforeAfterContent): (WebCore::RenderContainer::updateBeforeAfterContentForObject):
rendering/RenderContainer.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines):

9:32 PM Changeset in webkit [21198] by justing

2 edits in trunk/WebCore

Reviewed by justin

<http://bugs.webkit.org/show_bug.cgi?id=13552>
comment to Range::comparePoint in dom/Range.cpp has
'0xD0' in place of '-': leading to a compiler warning

dom/Range.cpp: (WebCore::Range::comparePoint):

4:45 PM Changeset in webkit [21197] by justing

7 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4875189> List gets deleted when replacing contents

Replacing the contents of a list:

editing/inserting/4875189-1-expected.checksum: Added.
editing/inserting/4875189-1-expected.png: Added.
editing/inserting/4875189-1-expected.txt: Added.
editing/inserting/4875189-1.html: Added. Of a floating div:
editing/inserting/4875189-2-expected.checksum: Added.
editing/inserting/4875189-2-expected.png: Added.
editing/inserting/4875189-2-expected.txt: Added.
editing/inserting/4875189-2.html: Added. Pasting a list on top of itself now creates a nested list:
editing/pasteboard/paste-4039777-fix-expected.checksum:
editing/pasteboard/paste-4039777-fix-expected.png:
editing/pasteboard/paste-4039777-fix-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/4875189> List gets deleted when replacing contents

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't expand to include elements, like lists, when deleting a selection to replace it.

3:06 PM Changeset in webkit [21196] by justing

4 edits in trunk/WebCore

Reviewed by ggaren

Buildfix. Leave in grammar checking machinery to
keep WebKit building on other platforms but don't
operate on sentence sized chunks so that we don't
re-introduce 5157329.

editing/Editor.h:
editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

2:14 PM Changeset in webkit [21195] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5168598> Crash when deleting a link inside an input field

editing/deleting/5168598-expected.checksum: Added.
editing/deleting/5168598-expected.png: Added.
editing/deleting/5168598-expected.txt: Added.
editing/deleting/5168598.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5168598>
Crash when deleting a link inside an input field

Deletion code tries to update one of its positions to keep
it valid and nullifies it. Later in mergeParagraphs we try
to find out if it's valid by checking to see if it's still in
the document and crash.

The fix is just to not bother keeping the position,
m_upstreamStart, valid, since after the point in the code
under examination, it doesn't need to be valid anymore.
Besides, code to update DeleteSelectionCommand's positions
should go in the functions that handle the content removal
that might invalid them (there are already FIXMEs about this).

Also, users shouldn't be able to insert links (or any rich content)
into plaintext-only regions like text fields, even if those
text fields are inside richly editable regions. This is a
separate bug and is filed as 5171552.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Don't bother updating m_upstreamStart.

2:03 PM Changeset in webkit [21194] by pyeh

7 edits
1 add in trunk/WebCore

<rdar://problem/5108546> REGRESSION: Zoom follows keyboard focus does not work

WebCore.xcodeproj/project.pbxproj: Add new file SelectionControllerMac.mm
dom/Document.cpp: (WebCore::Document::updateSelection): Move the code to fire off AXSelectedTextChanged notification to a new method notifyAccessibilityForSelectionChange in SelectionControllerMac.mm
editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): call notifyAccessibilityForSelectionChange to handle firing of accessibility notification and zoomFocusChange
editing/SelectionController.h: Add notifyAccessibilityForSelectionChange method for Mac platform
platform/Widget.h:
platform/mac/WidgetMac.mm: (WebCore::Widget::convertToScreenCoordinate): Add a helper routine that takes IntPoint in local coordinate and convert that to screen coordinate

12:43 PM Changeset in webkit [21193] by justing

4 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/5157329>
REGRESSION: Crash at WTF::fastFree() when arrowing or deleting backward through editable text (13493)

Backing out the changes for 4859132.

editing/Editor.h:
editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellings):
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

10:43 AM Changeset in webkit [21192] by kmccullo

2 edits in trunk/WebKitTools

Removed debugging statements and took out the removal of the deletion of the symlink. This is because multiple instances of run-webkit-tests can be running at the same time.
Scripts/run-webkit-tests:

7:40 AM Changeset in webkit [21191] by spadma

2 edits in S60/trunk/WebKit

raalexan, reviewed by <sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

ResourceLoader/src/AboutTransaction.cpp:

7:40 AM Changeset in webkit [21190] by spadma

2 edits in S60/branches/3.1m/WebKit

raalexan, reviewed by <sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

ResourceLoader/src/AboutTransaction.cpp:

7:35 AM Changeset in webkit [21189] by yongjzha

4 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: can't do the chinese keyword searching on the brower
http://bugs.webkit.org/show_bug.cgi?id=13418
TSW ID: RLEA-6ZFCBF

BrowserCore/Formcontrols/inc/FControlInputSkin.h:
BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):

3:44 AM Changeset in webkit [21188] by antti

4 edits in trunk/WebCore

Reviewed by Oliver.

Fix <rdar://problem/5169261>
REGRESSION: Google Maps zooming too sensitive when using two fingers on trackpad

Use line based delta values when generating DOM wheel events, use pixel deltas
for scrolling only.

No test case, requires user interaction and specific hardware.

page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::continuousDeltaX): (WebCore::PlatformWheelEvent::continuousDeltaY):
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Apr 29, 2007:

11:27 PM Changeset in webkit [21187] by oliver

2 edits in trunk/WebCore

Reviewed by Brady.

Build fix for experimental features build

rendering/RenderForeignObject.cpp:

8:29 PM Changeset in webkit [21186] by bdash

3 edits
4 adds in trunk

2007-04-29 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13544 REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers

Test: fast/repaint/layer-hide-when-needs-layout.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If we get a layout hint, we count on layout() or updateLayerPositions() to repaint. In the case of a layer going invisible, however, we need to repaint here since neither of the above will do it.

2007-04-29 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=13544 REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers

fast/repaint/layer-hide-when-needs-layout-expected.checksum: Added.
fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
fast/repaint/layer-hide-when-needs-layout.html: Added.

5:24 PM Changeset in webkit [23336] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix after r21183.

WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).

3:40 PM Changeset in webkit [23335] by oliver

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)

Prevent build bustage from opensource changes, correct scaling

platform/win/DragImageWin.cpp: (WebCore::scaleDragImage):

3:31 PM Changeset in webkit [21185] by oliver

7 edits in trunk/WebCore

Reviewed by Steve.

Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)

Added logic to ensure that when we create the drag image
we're looking at the rendered image size.

page/DragController.cpp: (WebCore::DragController::doImageDrag): Pass the rendered image size to fitDragImageToMaxSize

platform/DragImage.cpp: (WebCore::fitDragImageToMaxSize):

Need to do scaling relative to rendered image size

platform/DragImage.h:

scaleDragImage needs x and y scales to allow for them to be
scaled seperately on a page

platform/gdk/DragImageGdk.cpp: (WebCore::scaleDragImage):

Prevent build bustage

platform/mac/DragImageMac.mm: (WebCore::scaleDragImage):

scale width and height independently

platform/qt/DragImageQt.cpp: (WebCore::scaleDragImage):

Prevent build bustage

1:32 PM Changeset in webkit [21184] by darin

18 edits in trunk/WebCore

Reviewed by Adele.

fix the Gmail part of http://bugs.webkit.org/show_bug.cgi?id=12798 and <rdar://problem/4118559>

This patch changes things so that resizing can make things larger than their
initial size, but not smaller. I believe this resolves the problem for Gmail,
but you can still get strange behavior if you have a small right-aligned <textarea>.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Rewrote to use more IntPoint and IntSize and add in a new minimum-size algorithm. This function now has the side effect of storing a new minimumSizeForResizing in the element being resized, and respects any existing minimum as well. (WebCore::RenderLayer::offsetFromResizeCorner): Reversed this so it converts the point into coordinates relative to the resize corner, hence negative numbers mean the point is above and to the left. This is used only in the algorithm above.

dom/Element.h: Removed unneeded include of Attr.h, and added forward declarations as needed. Removed all friend declarations; there was no need for any of them. Tweaked formatting of various declarations and removed unneeded parameter names. Made as much as possible private, and a couple things public to avoid the need for friend classes. Added minimumSizeForResizing, setMinimumSizeForResizing, rareData, and createRareData functions.

dom/Element.cpp: (WebCore::rareDataMap): Added. Function to return the single global map. (WebCore::rareDataFromMap): Added. For use by inlined functions to get the data from the map in the case where it's present. (WebCore::ElementRareData::ElementRareData): Added. (WebCore::Element::~Element): Added code to delete the element from the rare data map when appropriate. (WebCore::Element::rareData): Added. (WebCore::Element::createRareData): Added. (WebCore::Element::setAttributeNodeNS): Got rid of the old inline version of this, since it was the sole reason we had to include Attr.h in Element.h. (WebCore::Element::minimumSizeForResizing): Added. Accesses rare data. (WebCore::Element::setMinimumSizeForResizing): Ditto.

dom/Node.h: Renamed the m_specified bit since it's now used for two purposes. Its new long name is m_attrWasSpecifiedOrElementHasRareData.

dom/Attr.cpp: (WebCore::Attr::Attr): Updated for bit name change.
dom/Attr.h: (WebCore::Attr::specified): Ditto. (WebCore::Attr::setSpecified): Added, since setting the bit directly is pretty ugly now.
dom/Document.cpp: (WebCore::Document::adoptNode): Updated for bit name change.
dom/Node.cpp: (WebCore::Node::Node): Ditto. (WebCore::Node::dump): Ditto.

dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::isReadOnlyNode): Moved out of line, since this was the sole reason we had to include Element.h in NamedAttrMap.h.

html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Changed to use tagQName() since that's a public way to do something that's now private. (WebCore::HTMLElement::cloneNode): Ditto.

dom/Attribute.cpp:
dom/NamedAttrMap.h:
dom/NamedMappedAttrMap.cpp:
dom/StyledElement.h:
html/HTMLTokenizer.h:
xml/XPathFunctions.cpp:
xml/XPathStep.cpp: Updated includes, and other administrivia.

1:09 PM Changeset in webkit [21183] by weinig

31 edits
6 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13487 Implement O(1) absoluteClippedOverflowRect and absoluteOutlineBox during layout for a possible speed gain

fast/repaint/bugzilla-3509-expected.checksum:
fast/repaint/bugzilla-3509-expected.png:
fast/repaint/intermediate-layout-position-clip-expected.checksum: Added.
fast/repaint/intermediate-layout-position-clip-expected.png: Added.
fast/repaint/intermediate-layout-position-clip-expected.txt: Added.
fast/repaint/intermediate-layout-position-clip.html: Added.
fast/repaint/intermediate-layout-position-expected.checksum:
fast/repaint/intermediate-layout-position-expected.png:

WebCore:

Reviewed by Darin and Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13487 Implement O(1) absoluteClippedOverflowRect and absoluteOutlineBox during layout for a possible speed gain

Test for a bug fixed by this patch: fast/repaint/intermediate-layout-position-clip.html

By keeping track of the total translation and clip during layout, absolutePosition and
computeAbsoluteRepaintRect become O(1).

WebCore.pro: Added LayoutState.cpp
WebCore.vcproj/WebCore/WebCore.vcproj: Added LayoutState.{cpp,h}
WebCore.xcodeproj/project.pbxproj: Added LayoutState.{cpp,h}
WebCoreSources.bkl: Added LayoutState.cpp
page/FrameView.cpp: (WebCore::FrameView::layout): When doing subtree layout, push an initial layout state for the layout root.
rendering/LayoutState.cpp: Added. A LayoutState corresponding to a box consists of the origin of its coordinate system in view coordinates and possibly the clip rect, in view coordinates, which applies to its children. (WebCore::LayoutState::LayoutState): (WebCore::LayoutState::destroy): (WebCore::throw): (WebCore::LayoutState::operator delete):
rendering/LayoutState.h: Added. (WebCore::LayoutState::LayoutState):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added code to push/pop LayoutState, unless we have columns, in which case we disable/enable LayoutState. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox(). (WebCore::RenderBlock::layoutOnlyPositionedObjects): Added this helper function that checks for and handles the case where only positioned objects need layout. Returns true in that case. (WebCore::RenderBlock::repaintOverhangingFloats): Disabled LayoutState when repainting floats, since they may belong to other containers. (WebCore::RenderBlock::updateFirstLetter): Disabled LayoutState when adding and removing from the first letter container, since it may be different than ourselves.
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderBox::offsetForPositionedInContainer): Added. Factored out common code from absolutePosition, computeAbsoluteRepaintRect and RenderLayer::updateLayerPosition into this function. (WebCore::RenderBox::absolutePosition): Added an O(1) code path when this function is called during layout (and LayoutState has not been disabled). Factored out some code into offsetForPositionedInContainer. (WebCore::RenderBox::absoluteClippedOverflowRect): Added the layout delta here, so callers don't need to. (WebCore::RenderBox::computeAbsoluteRepaintRect): Added an O(1) code path when this function is called during layout (and LayoutState has not been disabled). Factored out some code into offsetForPositionedInContainer.
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Added LayoutState push/pop.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): Added an ASSERT.
rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout): Disabled LayoutState because it is incompatible with arbitrary affine transforms.
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Added ASSERTs. Factored out some code into RenderBox::offsetForPositionedInContainer. (WebCore::RenderLayer::updateScrollInfoAfterLayout): Disabled LayoutState around the call to scrollToOffset.
rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation): Disabled LayoutState when moving the list marker, since it can trigger repainting in other containers.
rendering/RenderObject.cpp: (WebCore::RenderObject::isRoot): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderObject::computeAbsoluteRepaintRect): Removed 'return' at the end of the function. (WebCore::RenderObject::container): Reordered to avoid calling isText() twice. (WebCore::RenderObject::absoluteOutlineBox): Added the layout delta here, so callers don't need to.
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): Disabled LayoutState because it is incompatible with arbitrary affine transforms.
rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absoluteClippedOverflowRect): Added the layout delta here, so callers don't need to. (WebCore::RenderTableCell::computeAbsoluteRepaintRect): For the O(1) code path, skipped the correction for the parent row, because RenderTableRow doesn't push a translation into LayoutState. (WebCore::RenderTableCell::absolutePosition): Ditto.
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout): Added LayoutState push/pop.
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Added LayoutState push/pop if cells are repainted or receive layout. (WebCore::RenderTableSection::calcRowHeight): Ditto. (WebCore::RenderTableSection::layoutRows): Added LayoutState push/pop.
rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout): Added initial LayoutState setup for the layout. (WebCore::RenderView::paintBoxDecorations): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderView::repaintViewRectangle): Ditto. (WebCore::RenderView::pushLayoutState): Added. Pushes initial layout state for subtree layout.
rendering/RenderView.h: (WebCore::RenderView::pushLayoutState): (WebCore::RenderView::popLayoutState): (WebCore::RenderView::layoutState): (WebCore::RenderView::disableLayoutState): (WebCore::RenderView::enableLayoutState):

3:33 AM Changeset in webkit [21182] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for previous checkin.

3:30 AM Changeset in webkit [21181] by hyatt

2 edits in trunk/WebCore

Fix for bugzilla 13535, regression from positioning cleanup a while
back. Some code got added to compute available width for a relpositioned
inline, only the code meant to be used for inline flows and not inline blocks.

Reviewed by mjs

fast/block/positioning/inline-block-relposition.html

rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):

3:17 AM Changeset in webkit [21180] by oliver

12 edits in trunk

2007-04-29 Oliver Hunt <oliver@apple.com>

Drag and drop support for WebKit/Qt

WebCore:

Reviewed by Zack.

Implement basic drag and drop support for qt
this allows content and link dragging but does not
provide the DOM data access methods.

platform/DragData.h:
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
platform/qt/DragDataQt.cpp: (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment):

WebKitQt:

Reviewed by Zack.

Tie QT drag events to the DragController logic
to allow drag and drop events to be handled by
webkit.

Api/qwebframe.cpp:
Api/qwebframe.h:
Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::QWebPage): (dropActionToDragOp): (dragOpToDropAction): (QWebPage::dragEnterEvent): (QWebPage::dragLeaveEvent): (QWebPage::dragMoveEvent): (QWebPage::dropEvent):
Api/qwebpage.h:
WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):
WebCoreSupport/DragClientQt.h: (WebCore::DragClientQt::DragClientQt):

12:33 AM Changeset in webkit [21179] by mjs

22 edits in trunk/WebCore

Reviewed by Darin and Oliver.

change Document to hold onto Frame* instead of FrameView*

This is an architectural cleanup and a prerequisite to fixing citibank login
in an architecturally sound way.

Some fixups for the page cache:

history/CachedPage.cpp: (WebCore::CachedPage::restore): Add an assert that the document's view matches the cached page's view - this needs to be true by the time this function is called. (WebCore::CachedPage::clear): Change assert to require frame matching, not view matching.
history/CachedPage.h: (WebCore::CachedPage::view): Add a way to get the view out.
loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): pass Frame, not FrameView, when creating document (WebCore::FrameLoader::open): restore view based on CachedPage, not Document.

Remaining changes are just straightforward updates based on which
pointer is held or passed:

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
dom/DOMImplementation.h:
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::view): (WebCore::Document::frame): (WebCore::Document::recalcStyle): (WebCore::Document::updateLayout): (WebCore::Document::attach): (WebCore::Document::detach): (WebCore::Document::createTokenizer): (WebCore::Document::recalcStyleSelector): (WebCore::Document::setInPageCache): (WebCore::Document::applyXSLTransform):
dom/Document.h:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
html/HTMLDocument.h:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
html/HTMLViewSourceDocument.h:
ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument):
ksvg2/svg/SVGDocument.h:
loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument):
loader/ImageDocument.h:
loader/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument):
loader/PluginDocument.h:
loader/TextDocument.cpp: (WebCore::TextDocument::TextDocument):
loader/TextDocument.h:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::XSLTProcessor::transformToDocument):
xml/XSLTProcessor.h:

Apr 28, 2007:

11:42 PM Changeset in webkit [21178] by bdash

2 edits in trunk/JavaScriptCore

2007-04-28 Jungshik Shin <jungshik.shin@gmail.com>

Reviewed by Sam Weinig.

Replace copyright sign in Latin-1 (0xA9) with '(C)' http://bugs.webkit.org/show_bug.cgi?id=13531

bindings/npruntime.h:

10:32 PM Changeset in webkit [21177] by adele

3 edits
2 adds in trunk

LayoutTests:

Added test to cover updated fix for <rdar://problem/5152299>

fast/events/no-blur-on-enter-button-expected.txt: Added.
fast/events/no-blur-on-enter-button.html: Added.

WebCore:

RS by Darin.

Update to fix for <rdar://problem/5152299>

Test: fast/events/no-blur-on-enter-button.html

html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't blur the button when handling the enter key. This matches our new behavior for input elements.

9:35 PM Changeset in webkit [21176] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Improved the ChangeLog comment. Maybe the code needs a comment like this too.

9:25 PM Changeset in webkit [21175] by darin

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

fix <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet

Test: fast/forms/add-remove-form-elements-stress-test.html

wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Initialize m_isDoneWithInitialFreeList to false. (WTF::ListHashSetNodeAllocator::allocate): Added assertions based on a debug-only m_isAllocated flag that make sure we don't allocate a block that's already allocated. These assertions helped pinpoint the bug. Set m_isDoneWithInitialFreeList when we allocate the last block of the initial free list. Once we're done with the initial free list, turn off the rule that says that the next node in the pool after the last node in the free list is also free. This rule works because any free nodes are added to the head of the free list, so a node that hasn't been allocated even once is always at the tail of the free list. But it doesn't work any longer once the entire pool has been used at least once. (WTF::ListHashSetNodeAllocator::deallocate): Set the node's m_isAllocated to false. (WTF::ListHashSetNodeAllocator::pastPool): Added. Used above. (WTF::ListHashSetNodeAllocator::inPool): Changed to use the pastPool function. (WTF::ListHashSetNode::ListHashSetNode): Initialize m_isAllocated to true. (WTF::ListHashSetNode::operator new): Removed variable name for unused size parameter. (WTF::ListHashSetNode::destroy): Changed to call the destructor rather than delete -- this gets rid of the need to define an operator delete.

LayoutTests:

Reviewed by Maciej.

test for <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet

fast/forms/add-remove-form-elements-stress-test-expected.txt: Added.
fast/forms/add-remove-form-elements-stress-test.html: Added.

9:09 PM Changeset in webkit [21174] by adele

4 edits
4 adds in trunk

LayoutTests:

Tests for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

fast/forms/button-enter-click-expected.txt: Added.
fast/forms/button-enter-click.html: Added.
fast/forms/button-spacebar-click-expected.txt: Added.
fast/forms/button-spacebar-click.html: Added.

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

Tests:
fast/forms/button-spacebar-click.html
fast/forms/button-enter-click.html

html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::): Made type enum private. Removed unnecessary m_value and m_currValue, and unused m_dirty.
html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Removed initialization of m_dirty. (WebCore::HTMLButtonElement::parseMappedAttribute): Removed case to parse value and accesskey attributes, which don't do anything. (WebCore::HTMLButtonElement::defaultEventHandler): Removed unnecessary check for button type. Added cases to handle spacebar and enter keys in the same way that they're handled for <input type=button/reset/submit> buttons. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Shortened comment. (WebCore::HTMLButtonElement::appendFormData): Use value() instead of m_currValue. Renamed encoding argument to formData.

6:36 PM Changeset in webkit [21173] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13501 REGRESSION (r21093): Pasting into text field fails and makes the caret disappear

fast/dynamic/anonymous-block-layer-lost-expected.checksum: Added.
fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
fast/dynamic/anonymous-block-layer-lost-expected.txt: Added.
fast/dynamic/anonymous-block-layer-lost.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13501 REGRESSION (r21093): Pasting into text field fails and makes the caret disappear

Test: fast/dynamic/anonymous-block-layer-lost.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): Avoid cutting off layers when removing the anonymous block.

6:34 PM Changeset in webkit [21172] by darin

3 edits
1 add in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13471 REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by submitting

loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced direct access to Frame's d->m_doc with a call to Frame::setDocument. (WebCore::FrameLoader::begin): Ditto. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Ditto. (WebCore::FrameLoader::canCachePage): Added a comment.
manual-tests/secure-keyboard-enabled-after-submit.html: Added.
page/Frame.cpp: (WebCore::Frame::setDocument): Reset secure keyboard entry, in case the old document's focused node has set it.

6:30 PM Changeset in webkit [21171] by darin

2 edits
1 add in trunk/WebCore

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13379 REGRESSION: Cannot add an option to a selected popup

manual-tests/update-empty-popup.html: Added.
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a call to the client's hidePopup() callback before returning in the case that the menu is empty. Otherwise the client thinks that the menu stayed open.

12:00 PM Changeset in webkit [21170] by adele

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

fast/history/history_reload-expected.txt: Added.
fast/history/history_reload.html: Added.
fast/history/resources/history_reload_window.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

Test: fast/history/history_reload.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): We avoid doing a redirection when going to the same url in a history navigation, but we have to still schedule a redirection when the number of steps is zero so we can force a reload.

11:29 AM Changeset in webkit [21169] by ap

5 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13514
REGRESSION (r20997-21003): Crash in WebCore::Node::document

Test: fast/dom/NodeList/childNodes-reset-cache.html

dom/Node.cpp: (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node lists. We cannot rely on notifications, since there may be no list objects left around.

dom/ChildNodeList.cpp: (WebCore::ChildNodeList::rootNodeChildrenChanged):
dom/ChildNodeList.h: Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset in Node::notifyLocalNodeListsChildrenChanged().

4:36 AM Changeset in webkit [21168] by bdash

2 edits in trunk/WebCore

2007-04-28 Mark Rowe <mrowe@apple.com>

Build fix. Change use of nil to 0 in C++ source file.

editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered):

1:11 AM Changeset in webkit [21167] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test for http://bugs.webkit.org/show_bug.cgi?id=6216 REGRESSION: getElementsByTagNameNS with empty namespace doesn't work

fast/dom/namespaces-1-expected.txt: Added.
fast/dom/namespaces-1.html: Added.

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=6216 REGRESSION: getElementsByTagNameNS with empty namespace doesn't work

dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting. (WebCore::TagNodeList::item): Tweaked formatting. (WebCore::TagNodeList::nodeMatches): Tweaked formatting. (WebCore::Node::setPrefix): Tweaked formatting. (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into null namespaces.

1:07 AM Changeset in webkit [21166] by darin

4 edits in trunk

LayoutTests:

Reviewed by Kevin Decker.

update test result for fix for <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)

fast/lists/w3-list-styles-expected.txt: Updated. The new test results match the behavior of Firefox.

WebCore:

Reviewed by Kevin Decker.

fix <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)

Covered by an existing regression test, which had wrong results checked in.

Hyatt told me not to use the algorithm in the CSS 3 specification, but I didn't listen!
This corrects mistakes there and makes our results match current Firefox.

rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Added code to strip off trailing zero digits. Added special case for zero, since that's the one case where we don't want to strip off trailing zero digits. Fixed mixed-up logic that would put the digits in each group backwards. (WebCore::listMarkerText): Corrected character values for the CJK_IDEOGRAPHIC case.

1:02 AM Changeset in webkit [21165] by darin

2 edits in trunk/WebCore

Reviewed by Oliver.

fix <rdar://problem/5138250> REGRESSION (r18245): Changing any one aspect of a font applies all the aspects to selected text

Since this bug is only visible with the font panel, I don't
think there's any way to make a DumpRenderTree-driven test.

editing/Editor.cpp: (WebCore::Editor::fontForSelection): Set hasMultipleFonts properly. The old code had an early exit that was left over from when hasMultipleFonts was a pointer.

Apr 27, 2007:

11:57 PM Changeset in webkit [21164] by aroben

2 edits in trunk/WebKitTools

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.

11:48 PM Changeset in webkit [21163] by bdash

5 edits in trunk/LayoutTests

2007-04-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Antti.

http://bugs.webkit.org/show_bug.cgi?id=13521 Update fast/css/percentage-non-integer for the new empty table cell behavior

fast/css/percentage-non-integer-expected.checksum:
fast/css/percentage-non-integer-expected.png:
fast/css/percentage-non-integer-expected.txt:
fast/css/percentage-non-integer.html:

11:40 PM Changeset in webkit [21162] by bdash

3 edits in trunk/WebCore

2007-04-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13525 Repainting a listbox schedules a relayout

No test possible as there is no change to functionality.

fix the root cause of http://bugs.webkit.org/show_bug.cgi?id=10862 REGRESSION: Collapsing form input on www.myspace.com

No test possible since text fields are no longer implemented as flexboxes.

rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.

10:04 PM Changeset in webkit [21161] by thatcher

1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Add back in WebInspectorPanel.

9:54 PM Changeset in webkit [21160] by thatcher

2 edits in trunk/WebKit

Revert some unintended changes and fix the build.

9:48 PM Changeset in webkit [21159] by thatcher

8 edits
2 deletes in trunk/WebKit

2007-04-27 Timothy Hatcher <timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
WebKit/WebView/WebViewInternal.h: Ditto.
WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.

6:41 PM Changeset in webkit [21158] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.

6:04 PM Changeset in webkit [21157] by harrison

14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

WebCore.exp:
editing/Editor.h:
editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.

in many other functions, condense the check for nil client().

editing/InsertListCommand.h:
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.

editing/ModifySelectionListLevel.h:
editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.

(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.

(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)

5:48 PM Changeset in webkit [21156] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):

2:59 PM Changeset in webkit [21155] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

editing/execCommand/5164796-expected.checksum: Added.
editing/execCommand/5164796-expected.png: Added.
editing/execCommand/5164796-expected.txt: Added.
editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
editing/JSEditor.cpp: Enable CreateLink for caret selections.

1:03 PM Changeset in webkit [21154] by brmorris

2 edits in S60/branches/3.1m/WebKit

hongzhao <hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 PM Changeset in webkit [21153] by zbujtas

2 edits in S60/trunk/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

reviewed by Zalan <zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):

12:56 PM Changeset in webkit [21152] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

reviewed by Zalan <zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):

12:48 PM Changeset in webkit [21151] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/rendering/render_object.cpp: (RenderObject::drawBorder):

12:23 PM Changeset in webkit [21150] by zbujtas

9 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/ecma/kjs_window.cpp: (Window::get):

10:02 AM Changeset in webkit [21149] by beidson

2 edits in trunk/WebKit

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:

7:55 AM Changeset in webkit [21148] by bdash

2 edits in trunk/WebKitTools

2007-04-27 Nazar Kulyk <schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):

6:08 AM Changeset in webkit [21147] by antti

1 edit
1 add in trunk/LayoutTests

Forgot this png from previous commit.

fast/table/empty-cells-expected.png: Added.

5:36 AM Changeset in webkit [21146] by bdash

2 edits in trunk/WebKitTools

2007-04-28 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):

4:32 AM Changeset in webkit [21145] by antti

38 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin, Hyatt.

Test for http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>

Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

fast/block/positioning/negative-right-pos-expected.txt:
fast/css/acid2-expected.txt:
fast/css/acid2-pixel-expected.txt:
fast/css/percentage-non-integer-expected.checksum:
fast/css/percentage-non-integer-expected.png:
fast/css/percentage-non-integer-expected.txt:
fast/repaint/table-cell-move-expected.checksum:
fast/repaint/table-cell-move-expected.png:
fast/repaint/table-cell-move-expected.txt:
fast/table/012-expected.txt:
fast/table/032-expected.txt:
fast/table/empty-cells-expected.checksum: Added.
fast/table/empty-cells-expected.txt: Added.
fast/table/empty-cells.html: Added.
fast/table/empty-section-crash-expected.txt:
http/tests/misc/acid2-expected.txt:
http/tests/misc/acid2-pixel-expected.txt:
tables/mozilla/bugs/bug100334-expected.txt:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug16012-expected.checksum:
tables/mozilla/bugs/bug16012-expected.png:
tables/mozilla/bugs/bug16012-expected.txt:
tables/mozilla/bugs/bug1818-6-expected.txt:
tables/mozilla/bugs/bug222336-expected.txt:
tables/mozilla/bugs/bug222467-expected.txt:
tables/mozilla/bugs/bug78162-expected.txt:
tables/mozilla/core/misc-expected.checksum:
tables/mozilla/core/misc-expected.png:
tables/mozilla/core/misc-expected.txt:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
tables/mozilla_expected_failures/bugs/bug72393-expected.png:
tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.

Fix http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>

To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):

4:20 AM Changeset in webkit [21144] by rwlbuis

4 edits
4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

1:43 AM Changeset in webkit [21143] by mjs

2 edits in trunk/WebKit

Reviewed by Mark.

<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
http://bugs.webkit.org/show_bug.cgi?id=13462

WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.

1:40 AM Changeset in webkit [21142] by bdash

2 edits in trunk/WebCore

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

WebCore.pro: Remove non-existent paths from qmake files.

1:10 AM Changeset in webkit [21141] by andersca

2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown

Return YES for applewebdata URLs.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

12:52 AM Changeset in webkit [21140] by bdash

5 edits in trunk/WebCore

2007-04-25 Lars Naesbye Christensen <lars@naesbye.dk>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

Resources/cellCursor.png:
Resources/contextMenuCursor.png:
Resources/helpCursor.png:
platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):

12:44 AM Changeset in webkit [21139] by bdash

1 edit
3 copies
2 adds
1 delete in trunk/JavaScriptCore

2007-04-27 Christopher Brichford <chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
http://bugs.webkit.org/show_bug.cgi?id=13211

JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.

12:37 AM Changeset in webkit [21138] by bdash

7 edits
7 deletes in trunk

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.
pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

QtLauncher/CMakeLists.txt: Removed.
WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
Scripts/build-webkit: Remove references to CMake.
Scripts/webkitdirs.pm: Remove references to CMake.

Apr 26, 2007:

11:03 PM Changeset in webkit [21137] by bdash

4 edits in trunk

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking dftables as a dependency of Generate Derived Sources rather than of JavaScriptCore itself.

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking JavaScriptGlue as a dependency of testjsglue.

10:48 PM Changeset in webkit [21136] by bdash

2 edits in trunk/WebCore

2007-04-26 Matt Perry <mpComplete@gmail.com>

Reviewed by Maciej.

Added a version check to hackAroundLibXMLEntityBug, since that bug has
been fixed in recent versions of libxml2.

dom/XMLTokenizer.cpp: (WebCore::hackAroundLibXMLEntityBug):

10:36 PM Changeset in webkit [21135] by bdash

1 edit
7 adds in trunk/WebCore

2007-04-26 Christopher Brichford <chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for Bug 13204: Submit initial version of mac project files for apollo port of WebCore http://bugs.webkit.org/show_bug.cgi?id=13204

WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.

10:11 PM Changeset in webkit [21134] by bdash

2 edits in trunk/WebCore

2007-04-26 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=13505
Cast loses precision on x86_64

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): Use a stack of opacity values instead of Cairo user data.

10:09 PM Changeset in webkit [21133] by bdash

2 edits in trunk/WebKitTools

2007-04-26 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

GdkLauncher/main.cpp: (main): Avoid use of deprecated API.

10:00 PM Changeset in webkit [21132] by bdash

3 edits
4 adds in trunk

2007-04-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13500 REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

Test: fast/forms/listbox-scrollbar-incremental-load.html

The scroller position was not updated correctly during insertion, since
scrollbar proportions are updated only during layout

rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the selection until after layout if m_optionsChanged is set. Layout is guaranteed to happen soon when the flag is set.

2007-04-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13500 REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
fast/forms/listbox-scrollbar-incremental-load.html: Added.

6:41 PM Changeset in webkit [21131] by ggaren

5 edits in trunk/JavaScriptCore

Build fix -- added #includes that we used to get implicitly through
JSStringRef.h.

API/JSNode.c:
API/JSNodeList.c:
API/minidom.c:
API/testapi.c:

6:15 PM Changeset in webkit [21130] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Adam Roben.

Fixed
<rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
<rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

API/JSStringRef.h: Removed #include -- no clients need it anymore.

5:36 PM Changeset in webkit [21129] by hyatt

1 edit in trunk/LayoutTests/fast/dom/Range/surroundContents-1-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:35 PM Changeset in webkit [21128] by hyatt

1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:34 PM Changeset in webkit [21127] by hyatt

3 edits in trunk/LayoutTests/editing/execCommand

Fix layout test results jnow that we no longer make empty render texts.

5:33 PM Changeset in webkit [21126] by hyatt

3 edits in trunk/LayoutTests/editing/deleting

Fix layout test results jnow that we no longer make empty render texts.

5:30 PM Changeset in webkit [21125] by hyatt

4 edits in trunk/WebCore

Fix for 13511, crash on a counters page. Make sure that RenderTexts
never get a null StringImpl. I would have added an assert that the length
had to be nonzero also, but unfortunately editing creates empty RenderTexts
because of its EditingText DOM subclass that always forces renderers to be
made. I suppose there is a good reason for this...

Reviewed by aroben

dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData):
rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter):
rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText):

4:21 PM Changeset in webkit [21124] by aliceli1

2 edits in trunk/WebCore

Reviewed by Oliver.

editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): adding null check

2:53 PM Changeset in webkit [21123] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5120591> Crash when creating a link in Leopard wiki server

editing/execCommand/5120591-expected.checksum: Added.
editing/execCommand/5120591-expected.png: Added.
editing/execCommand/5120591-expected.txt: Added.
editing/execCommand/5120591.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5120591>
Crash when creating a link in Leopard wiki server

editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Use a RefPtr, setting the anchor's href can destroy it if there is an ancestor with a subtree modified event listener.

2:15 PM Changeset in webkit [21122] by ddkilzer

2 edits in trunk/JavaScriptCore

2007-04-25 David Kilzer <ddkilzer@apple.com>

Reviewed by Maciej.

Add assertions for debug builds.

kjs/JSLock.cpp: (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds. (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.

1:37 PM Changeset in webkit [21121] by kmccullo

2 edits in trunk/WebKitTools

Changed debugging statements for more information.

Scripts/run-webkit-tests:

12:51 PM Changeset in webkit [21120] by hyatt

7 edits in trunk/WebCore

Reviewed by hyatt

http://bugs.webkit.org/show_bug.cgi?id=13496 Eliminate repaintObjectsBeforeLayout

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
rendering/RenderBlock.h:
rendering/RenderObject.cpp:
rendering/RenderObject.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.

12:24 PM Changeset in webkit [21119] by hyatt

2 edits in trunk/WebCore

Fix for 13509. Don't recur to parent inline flows if they have been
marked as needing layout themselves.

Reviewed by adele

rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):

12:21 PM Changeset in webkit [21118] by ap

3 edits
3 adds in trunk

2007-04-26 Matt Perry <mpComplete@gmail.com>

Reviewed and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=13495
Crash when referencing an undefined entity in an XHTML document

Test: fast/parser/badentity.xhtml

dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity

11:37 AM Changeset in webkit [21117] by andersca

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window

On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

11:30 AM Changeset in webkit [21116] by hyatt

4 edits in trunk/WebCore

Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
nesting PLT. Avoid O(n^{2) behavior by including inlines in the minmax

dirty chain.}

Reviewed by kevin

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainerPrefWidths):
rendering/RenderObject.h:

11:11 AM Changeset in webkit [21115] by kmccullo

2 edits in trunk/WebKitTools

Adding debugging statements to see why these tests fail. These will be removed.

Scripts/run-webkit-tests:

10:37 AM Changeset in webkit [21114] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5067925>
Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)

Ask the document loader whether it's loading the main resource, since there are cases where the frame
loader's variable isn't updated correctly.

In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.

I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
calling submit in the onunload prevents any new tests from loading!

loader/FrameLoader.cpp: (WebCore::FrameLoader::isLoading):

8:52 AM BuildingGdk edited by alp@atoker.com

(diff)

5:48 AM Changeset in webkit [21113] by zbujtas

2 edits in S60/trunk/WebKit

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix build break
http://bugs.webkit.org/show_bug.cgi?id=13497

group/EABI/browserengineU.def:

3:10 AM Changeset in webkit [21112] by bdash

5 edits in tags/WebKit-419.1/WebKit

Merge r10259 and r15845.

2:41 AM Changeset in webkit [21111] by bdash

3 edits in tags/WebKit-419.1/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

2:20 AM Changeset in webkit [21110] by oliver

2 edits in trunk/WebKit

2007-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
to be inserted into message field after dragging

Don't try to create <img> tags for local image files as it results
in the potential to submit forms that look like they have an image,
when in reality they don't.

WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]):

2:19 AM Changeset in webkit [21109] by bdash

1 copy in tags/WebKit-419.1

New tag.

12:09 AM Changeset in webkit [21108] by andersca

2 edits in trunk/WebCore

... and fix the build.

loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

12:06 AM Changeset in webkit [21107] by andersca

2 edits in trunk/WebCore

Revert the previous change - activeDocumentLoader never returns the policy document loader.
Instead, add a null check for the policy document loader.

loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

12:02 AM Changeset in webkit [21106] by andersca

2 edits in trunk/WebCore

Use the active document loader instead of the policy document loader.

loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

Apr 25, 2007:

11:46 PM Changeset in webkit [21105] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Anders.

fix build problems

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable warning that gives often downright incorrect results based on guessing what will happen in 64-bit.

11:37 PM Changeset in webkit [21104] by andersca

4 edits in trunk

WebCore:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL

Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".

loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

WebKit:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL

If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.

WebView/WebFrame.mm: (createUniqueWebDataURL): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

7:10 PM Changeset in webkit [21103] by slewis

2 edits in trunk/WebCore

Fix the build for platforms which overload the abs function

5:26 PM Changeset in webkit [21102] by oliver

2 edits in trunk/WebKit

2007-04-25 Oliver Hunt <oliver@apple.com>

Rubber stamped by Adele.

Roll out WebKit changes from from r21052 to fix regression noted in
<rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):

5:24 PM Changeset in webkit [21101] by zbujtas

18 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: widet menu api implementation
http://bugs.webkit.org/show_bug.cgi?id=13494

4:39 PM Changeset in webkit [23334] by sfalken

5 edits in branches/WindowsMerge

Build fix

4:23 PM BuildingOnWindows edited by pkasting@google.com

(diff)

3:04 PM Changeset in webkit [21100] by hyatt

4 adds in trunk/LayoutTests/fast/block/float

Add another test case that is fixed by the new lazy minmax width code.

2:46 PM Changeset in webkit [21099] by hyatt

3 edits in trunk/WebCore

Fix for bug 13373, make sure to invalidate the pref widths for objects
with percentage padding.

Reviewed by beth

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutPositionedObjects):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

2:44 PM Changeset in webkit [21098] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add padding percent test.

2:36 PM Changeset in webkit [21097] by harrison

2 edits in trunk/WebCore

Comment change. Correct the header name in the endif comment.

editing/FormatBlockCommand.h: Change InsertListCommand_h to FormatBlockCommand_h.

1:25 PM Changeset in webkit [21096] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

tweak the allocator for a small speedup -- Shark showed this was a win, but I can't measure an improvement right now, but it's also clear these changes do no harm

wtf/FastMalloc.cpp: (WTF::LgFloor): Use ALWAYS_INLINE here; in testing I did a while back this was necessary to get this single-instruction function to be inlined. (WTF::SizeClass): Use ALWAYS_INLINE here too for the same reason. Also change the special case for a size of 0 to work without a branch for a bit of extra speed. (WTF::ByteSizeForClass): Use ALWAYS_INLINE here too for the same reason.

1:02 PM Changeset in webkit [21095] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

platform/AtomicString.cpp: (WebCore::AtomicString::add): Removed unnecessary use of strlen to check if a string is empty.

12:59 PM Changeset in webkit [21094] by ddkilzer

2 edits in trunk/WebCore

2007-04-25 Mitz Pettel <mitz@webkit.org>

Build fix.

rendering/RenderListMarker.h: Undeleted the m_text member.

12:24 PM GtkAPIProposal edited by Kimmo Kinnunen

(diff)

12:10 PM Changeset in webkit [21093] by hyatt

40 edits in trunk/WebCore

Rearchitect calcPrefWidths. The calculation is now done lazily only when minPrefWidth
or maxPrefWidth are asked for. The result of the calculation is cached.

The new invalidation scheme for pref width invalidation follows the
containing block hierarchy and knows to halt at positioned objects, since
they cannot influence the size of their containers.

Reviewed by darin

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve):
page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::endOfInline): (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
rendering/RenderBox.h:
rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
rendering/RenderCounter.cpp: (WebCore::RenderCounter::dirtyLineBoxes): (WebCore::RenderCounter::calcPrefWidths):
rendering/RenderCounter.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
rendering/RenderInline.cpp:
rendering/RenderInline.h:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
rendering/RenderListItem.cpp: (WebCore::firstNonMarkerChild): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins):
rendering/RenderListMarker.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::moveChildNode): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainingBlockPrefWidths): (WebCore::RenderObject::information): (WebCore::RenderObject::setStyle):
rendering/RenderObject.h: (WebCore::RenderObject::layer): (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::setHasLayer):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
rendering/RenderSVGContainer.h:
rendering/RenderSVGHiddenContainer.cpp:
rendering/RenderSVGHiddenContainer.h:
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::removeChildNode):
rendering/RenderTable.h:
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChildNode):
rendering/RenderTableSection.h:
rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
rendering/RenderText.h:
rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):

12:01 PM Changeset in webkit [21092] by sfalken

10 edits in trunk

2007-04-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Mac callbacks for new spelling methods in WebEditorClient.
Not used yet.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::updateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Fix spelling error in spelling method name.
Expose new spelling callback methods to all platforms.

bridge/EditorClient.h:
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Fix spelling error in spelling method name.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
WebCoreSupport/EditorClientQt.h:

11:42 AM Changeset in webkit [21091] by ggaren

10 edits in trunk

WebCore:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of -release, since -release is a no-op in a GC world.

WebKit:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

Carbon/CarbonUtils.m: (PoolCleaner): Call -drain instead of -release, since -release is a no-op in a GC world.

Misc/WebKitErrors.m: (registerErrors): Condensed onto one line.

Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -drain instead of -release, since -release is a no-op in a GC world.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):

WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain and then release because drain deallocates the receiver, so the release is an over-release.

WebView/WebView.mm: (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it, because drain deallocates the receiver, so the drain would leave you without any autorelease pool, causing a leak and then an over-release at the bottom of the loop.

11:21 AM Changeset in webkit [21090] by ap

3 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13445
NodeList access by index is slow

dom/ChildNodeList.cpp: (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node or from the last child.
dom/NodeList.h: Make cachedLength unsigned.

11:10 AM BuildingOnWindows edited by pkasting@google.com

(diff)

10:34 AM Changeset in webkit [21089] by bdash

1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Don't try and return a value from a stub function with return type of void.

10:32 AM Changeset in webkit [21088] by bdash

2 edits in trunk/WebCore

2007-04-26 Mark Rowe <mrowe@apple.com>

Gdk build fix. Add missing stub.

platform/gdk/TemporaryLinkStubs.cpp: (Editor::advanceToNextMisspelling):

10:21 AM Changeset in webkit [21087] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12163
SVG text does not appear in a scrolling <div>

Make sure SVG text is painted when scrolling by taking into account the

relative offset of the non-SVG parent in the paintInfo rect.

10:08 AM Changeset in webkit [21086] by bdash

5 edits in trunk/WebCore

2007-04-26 Mark Rowe <mrowe@apple.com>

Fix non-Mac builds after r21081.

Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
for all non-Mac builds.

editing/qt/EditorQt.cpp: (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing):
page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):
platform/gdk/TemporaryLinkStubs.cpp: (Editor::showSpellingGuessPanel): (Editor::spellingPanelIsShowing):
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument): (WebCore::SVGEmptyEditorClient::learnWord): (WebCore::SVGEmptyEditorClient::checkSpellingOfString): (WebCore::SVGEmptyEditorClient::checkGrammarOfString): (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord): (WebCore::SVGEmptyEditorClient::showSpellingUI): (WebCore::SVGEmptyEditorClient::spellingUIIsShowing): (WebCore::SVGEmptyEditorClient::getGuessesForWord):

9:35 AM Changeset in webkit [21085] by andersca

2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5122153>
Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image

Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).

loader/FrameLoader.cpp: (WebCore::FrameLoader::write):

6:57 AM Changeset in webkit [21084] by bdash

2 edits in trunk/WebCore

2007-04-26 Mark Rowe <mrowe@apple.com>

Gdk build fix courtesy of Alp Toker.

make-generated-sources.sh: Remove conditional logic to ensure the script exits with the correct exit code.

5:28 AM BuildingGdk edited by alp@atoker.com

List of build dependencies (diff)

12:47 AM Changeset in webkit [21083] by andersca

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Added.
http/tests/xmlhttprequest/default-content-type-dashboard.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

Use the right MIME type.

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

WebKitTools:

Reviewed by Mitz.

Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
the dashboard compatibility mode.

DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (runTest):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Apr 24, 2007:

11:49 PM Changeset in webkit [21082] by darin

20 edits in trunk/WebCore

Reviewed by Maciej.

second round of preparation for Hyatt's "lazy minMaxWidth" change http://bugs.webkit.org/show_bug.cgi?id=13431

These are small changes that are either safe to do first, or unrelated to the main
change in Hyatt's patch.

Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation in AutoTableLayout.
Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
Save a virtual function call by using a local bool variable for isTableCell().

Fix containingBlock() so it returns 0 for table cells with no parent.

Change all callers who are getting at layer() as a boolean to use hasLayer().
Change if statements to max() function calls (only the ones Hyatt had in his patch).
Remove some old kdDebug calls.
Tweak formatting of some code.
Add const in one place.

bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag):
page/Frame.cpp: (WebCore::Frame::clearTimers):
rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
rendering/AutoTableLayout.h:
rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::hasTextChildren):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::next): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderTreeAsText.cpp: (WebCore::write):

9:35 PM Changeset in webkit [23333] by sfalken

18 edits in branches/WindowsMerge

2007-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

WebEditorClient.cpp: (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::toggleGrammarChecking): (initViewSpecificSpelling): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::udpateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):
WebPreferences.h:

2007-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

Ported code from EditorMac.mm into EditorWin.cpp.
Once this works, I'll move this code into Editor.cpp and remove it
form EditorMac.mm.

platform/win/EditorWin.cpp: (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
platform/win/TemporaryLinkStubs.cpp:

2007-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Add spelling related delegate methods to EditingDelegate.
They are all unimplemented. Necesarry to match the new interfaces.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::ignoreWordInSpellDocument): (EditingDelegate::learnWord): (EditingDelegate::checkSpellingOfString): (EditingDelegate::checkGrammarOfString): (EditingDelegate::udpateSpellingUIWithGrammarString): (EditingDelegate::updateSpellingUIWithMisspelledWord): (EditingDelegate::showSpellingUI): (EditingDelegate::spellingUIIsShowing): (EditingDelegate::guessesForWord): (EditingDelegate::closeSpellDocument): (EditingDelegate::sharedSpellCheckerExists): (EditingDelegate::preflightChosenSpellServer): (EditingDelegate::updateGrammar):

9:22 PM Changeset in webkit [21081] by sfalken

9 edits in trunk

2007-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Refactor spelling codepaths

bridge/EditorClient.h:
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
platform/gdk/EditorClientGdk.h:

2007-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Spelling and grammar stubs

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::ignoreWordInSpellDocument): (WebCore::EditorClientQt::learnWord): (WebCore::EditorClientQt::checkSpellingOfString): (WebCore::EditorClientQt::checkGrammarOfString): (WebCore::EditorClientQt::udpateSpellingUIWithGrammarString): (WebCore::EditorClientQt::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientQt::showSpellingUI): (WebCore::EditorClientQt::spellingUIIsShowing): (WebCore::EditorClientQt::getGuessesForWord):
WebCoreSupport/EditorClientQt.h:

7:11 PM Changeset in webkit [21080] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Oliver.

use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.

The only exception is destructors, since delete doesn't know how to use a custom calling convention.

kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):

6:14 PM Changeset in webkit [21079] by darin

71 edits in trunk/WebCore

Reviewed by Adele.

first round of preparation for Hyatt's "lazy minMaxWidth" change http://bugs.webkit.org/show_bug.cgi?id=13431

This patch limits itself to renaming and making other super-simple
changes so that the above change will be smaller and easier to review
and understand.

Rename:

calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
calcMinMaxWidth -> calcPrefWidths
calcMinMaxWidthInternal -> calcPrefWidthsInternal
calcVerticalMinMaxWidth -> calcVerticalPrefWidths
setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
trimmedMinMaxWidth -> trimmedPrefWidths

RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
RenderObject::minWidth() -> RenderObject::minPrefWidth()

Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
a boolean with the opposite sense.

Convert some uses of if statements into "max".

Change many uses of layer() to hasLayer(). For now it's just a boolean
version of layer(), but Hyatt's patch makes it faster by using a bit.

Added a guard to use of axObjectCache() to make RenderObject destruction
a little faster for the normal case.

Removed some assertions that will be removed in Hyatt's patch.

Made some functions const that will be const in Hyatt's patch.

Put in some revised comments from Hyatt's patch.

Removed an unneeded nil check from RenderListMarker::setStyle.

Moved RootInlineBox::setHorizontalOverflowPositions and
RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
header and marked them inline.

dom/Document.cpp: (WebCore::Document::updateStyleSelector):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth):
rendering/AutoTableLayout.h:
rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcPrefWidths):
rendering/FixedTableLayout.h:
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
rendering/RenderBox.h: (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
rendering/RenderContainer.h: (WebCore::RenderContainer::calcPrefWidths):
rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcPrefWidths):
rendering/RenderCounter.h:
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
rendering/RenderFieldset.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
rendering/RenderFileUploadControl.h:
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::allowedChildFlex):
rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::hasMultipleLines): (WebCore::RenderFlexibleBox::isVertical): (WebCore::RenderFlexibleBox::isHorizontal):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcPrefWidths):
rendering/RenderImage.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::calcPrefWidths):
rendering/RenderInline.h:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
rendering/RenderListBox.h:
rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateValue): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::explicitValueChanged):
rendering/RenderListItem.h:
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::calcWidth):
rendering/RenderListMarker.h:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): (WebCore::RenderMenuList::calcPrefWidths):
rendering/RenderMenuList.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::checkForRepaintDuringLayout): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::destroy): (WebCore::RenderObject::recalcMinMaxWidths):
rendering/RenderObject.h: (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::calcPrefWidths): (WebCore::RenderObject::minPrefWidth): (WebCore::RenderObject::maxPrefWidth):
rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::layout):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
rendering/RenderReplaced.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcPrefWidths): (WebCore::RenderSVGContainer::layout):
rendering/RenderSVGContainer.h:
rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
rendering/RenderSVGHiddenContainer.h:
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
rendering/RenderSlider.h:
rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::calcPrefWidths): (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::appendColumn):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::calcPrefWidths):
rendering/RenderTableCell.h:
rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::calcPrefWidthsInternal): (WebCore::RenderText::setText):
rendering/RenderText.h: (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
rendering/RenderTextControl.h:
rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
rendering/RenderView.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
rendering/RootInlineBox.cpp:
rendering/RootInlineBox.h: (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
rendering/TableLayout.h:

5:51 PM Changeset in webkit [23332] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)

page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWheelEventToWidget): Get rid of passWheelEventToSubframe and pass wheel events to all widgets.

4:50 PM Changeset in webkit [21078] by justing

4 edits
8 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

Test for the crash:

editing/pasteboard/5156401-1-expected.checksum: Added.
editing/pasteboard/5156401-1-expected.png: Added.
editing/pasteboard/5156401-1-expected.txt: Added.
editing/pasteboard/5156401-1.html: Added.

Test inserting at the end of a link where we would previously
insert in the wrong paragraph:

editing/inserting/5156401-2-expected.checksum: Added.
editing/inserting/5156401-2-expected.png: Added.
editing/inserting/5156401-2-expected.txt: Added.
editing/inserting/5156401-2.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Don't avoid the anchor if doing so would skip over a line break, that would put content in the wrong paragraph, which can throw ReplaceSelectionCommand, which relies on moveParagraphs into infinite recursion. Renamed the input position. Don't need to re-fetch the enclosing anchor when preparing to push it down, since it hasn't changed since the top of the function.

3:59 PM Changeset in webkit [21077] by thatcher

3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()

Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]):
editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox):

2:06 PM Changeset in webkit [21076] by oliver

2 edits in trunk/JavaScriptCore

GTK Build fix, ::findEntry->KJS::findEntry

kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):

1:37 PM Changeset in webkit [21075] by spadma

6 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin.padma@nokia.com>

DESC: Windowless plugin support
http://bugs.webkit.org/show_bug.cgi?id=13451

BrowserView/src/PluginContentPlayer.cpp: (CPluginContentPlayer::CPluginContentPlayer): (CPluginContentPlayer::CountComponentControls): (CPluginContentPlayer::Start):
Plugin/inc/PluginWin.h: (CPluginWin::IsPluginWindowed): (CPluginWin::SetWindowedPlugin):
Plugin/src/NpnImplementation.cpp: (NpnGetValue): (NpnSetValue): (NpnInvalidateRect): (NpnForceRedraw):
Plugin/src/PluginSkin.cpp: (CPluginSkin::Draw):
Plugin/src/PluginWin.cpp: (CPluginWin::CPluginWin): (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::NewL): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamToFileL): (CPluginWin::ProcessEventL): (CPluginWin::RefreshPlugin): (CPluginWin::MakeVisible): (CPluginWin::HandleControlEventL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground): (CPluginWin::PluginScriptableObject): (CPluginWin::ForceRedraw): (CPluginWin::IsContentInteractive):

1:28 PM Changeset in webkit [21074] by thatcher

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored

We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse):

1:21 PM Changeset in webkit [21073] by beidson

8 edits in trunk

WebCore:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
whether or not we've ever done the import

WebCore.exp:
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db" (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag (WebCore::IconDatabase::setImported): Store this flag into the DB (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
loader/icon/IconDatabase.h:

WebKit:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
- Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
- Set "imported" to true in the Icons.db
- If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
- Move old icon.db to Icons.db to reflect rename
Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit where to look for the old icons if their location is different from the icon.db
WebKit.exp:

11:12 AM Changeset in webkit [21072] by thatcher

3 edits in trunk/WebKitTools

Setting the valid architectures to 32-bit only, so these projects
will ignore requests to build them 64-bit. Once they can be built 64-bit,
the valid architectures can be updated.

Drosera/Drosera.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

10:37 AM Changeset in webkit [21071] by darin

7 edits
24 adds in trunk

LayoutTests:

Reviewed by Justin.

test for <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character

editing/undo/undo-combined-delete-boundary-expected.checksum: Added.
editing/undo/undo-combined-delete-boundary-expected.png: Added.
editing/undo/undo-combined-delete-boundary-expected.txt: Added.
editing/undo/undo-combined-delete-boundary.html: Added.
editing/undo/undo-combined-delete-expected.checksum: Added.
editing/undo/undo-combined-delete-expected.png: Added.
editing/undo/undo-combined-delete-expected.txt: Added.
editing/undo/undo-combined-delete.html: Added.
editing/undo/undo-delete-boundary-expected.checksum: Added.
editing/undo/undo-delete-boundary-expected.png: Added.
editing/undo/undo-delete-boundary-expected.txt: Added.
editing/undo/undo-delete-boundary.html: Added.
editing/undo/undo-delete-expected.checksum: Added.
editing/undo/undo-delete-expected.png: Added.
editing/undo/undo-delete-expected.txt: Added.
editing/undo/undo-delete.html: Added.
editing/undo/undo-forward-delete-boundary-expected.checksum: Added.
editing/undo/undo-forward-delete-boundary-expected.png: Added.
editing/undo/undo-forward-delete-boundary-expected.txt: Added.
editing/undo/undo-forward-delete-boundary.html: Added.
editing/undo/undo-forward-delete-expected.checksum: Added.
editing/undo/undo-forward-delete-expected.png: Added.
editing/undo/undo-forward-delete-expected.txt: Added.
editing/undo/undo-forward-delete.html: Added.

editing/deleting/delete-and-undo-expected.txt: One of the delegate callbacks has changed in this test's result, because it reflects the selection after undoing a sequence of deletions.

WebCore:

Reviewed by Justin.

fix <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character

Test: editing/undo/undo-combined-delete-boundary.html
Test: editing/undo/undo-combined-delete.html
Test: editing/undo/undo-delete-boundary.html
Test: editing/undo/undo-delete.html
Test: editing/undo/undo-forward-delete-boundary.html
Test: editing/undo/undo-forward-delete.html

editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing braces. I couldn't find any real symptom of this, but I think the fix should go in anyway. All layout tests still pass. (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes back to the beginning of the composite editing operation. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

editing/Selection.h:
editing/Selection.cpp: (WebCore::Selection::setWithoutValidation): Added. Back door to allow setting the ends of a selection without revalidating, because we need to use it on a selection where the endpoints may no longer be valid due to mutations done by earlier pieces of the editing operation.

editing/EditCommand.h: (WebCore::EditCommand::startingSelection): Return a const& for speed. (WebCore::EditCommand::endingSelection): Ditto.

8:06 AM Changeset in webkit [21070] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=13448 REGRESSION: setting an input element's value to JavaScript null gives "null"

fast/forms/input-null-expected.txt: Added.
fast/forms/input-null.html: Added.

WebCore:

Reviewed by Mitz.

fix for http://bugs.webkit.org/show_bug.cgi?id=13448 REGRESSION: setting an input element's value to JavaScript null gives "null"

Test: fast/forms/input-null.html

html/HTMLInputElement.idl: Convert JS null to the empty string on setting DOMString attributes.

5:29 AM Changeset in webkit [21069] by bdash

4 edits
4 adds in trunk

2007-04-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13453 Control clip isn't applied to children's backgrounds, outlines and floats

Test: fast/forms/control-clip.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): Apply the clip in all phases that paint children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into two phases each, applying the clip only to the children.
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the background rather than as a child's background, now that children are clipped out.

2007-04-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13453 Control clip isn't applied to children's backgrounds, outlines and floats

fast/forms/control-clip-expected.checksum: Added.
fast/forms/control-clip-expected.png: Added.
fast/forms/control-clip-expected.txt: Added.
fast/forms/control-clip.html: Added.

5:27 AM Changeset in webkit [21068] by bdash

2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver Hunt.

Changed an apostrophe (') into a right single quotation mark (U+2019).

WebInspector/webInspector/inspector.js:

5:25 AM Changeset in webkit [21067] by bdash

2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Timothy Hatcher.

fix http://bugs.webkit.org/show_bug.cgi?id=13459 The "mapped style" link next to an attribute doesn't work

WebInspector/webInspector/inspector.js: Added a check that the rule is mapped from an attribute.

4:51 AM Changeset in webkit [21066] by bdash

2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

make-generated-sources.sh: Exit with failure status if make fails.

4:49 AM Changeset in webkit [21065] by bdash

2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

Projects/gdk/webcore-gdk.bkl: fail if running any of the commands failed. In particular make-generated-sources.sh

1:44 AM Changeset in webkit [21064] by mjs

4 edits
1 add in trunk/JavaScriptCore

Reviewed by Geoff.

compile most of JavaScriptCore as one file for 4% JS iBench speed improvement

JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
kjs/AllInOneFile.cpp: Added.
kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"

Apr 23, 2007:

11:37 PM Changeset in webkit [21063] by ggaren

1 edit
1 move in trunk/LayoutTests

Rubber Stamped by Mark Rowe.

Disabling this test because it hangs all the time.
(http://bugs.webkit.org/show_bug.cgi?id=13370)

http/tests/plugins/npapi-response-headers.html: Removed.

11:13 PM Changeset in webkit [21062] by bdakin

3 edits
4 adds in trunk

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5155507> REGRESSION: Crash in
RenderLayer::setHasVisibleContent()

rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): Must null-check enclosingLayer() (WebCore::RenderContainer::insertChildNode): Same.

LayoutTests:

Reviewed by Adam.

Test for <rdar://problem/5155507> REGRESSION: Crash in
RenderLayer::setHasVisibleContent()

fast/css-generated-content/visibleContentHiddenParent-expected.checksum: Added.
fast/css-generated-content/visibleContentHiddenParent-expected.png: Added.
fast/css-generated-content/visibleContentHiddenParent-expected.txt: Added.
fast/css-generated-content/visibleContentHiddenParent.html: Added.

9:55 PM Changeset in webkit [21061] by hyatt

7 edits in trunk/WebCore

Fix for bug 13337, deep tag nesting is slow. This patch fixes a number of O(n^{2) issues as well as making

a few performance optimizations based off profiling. Details next to each change below.}

Note that calcMinMaxWidth being slow is a critical separate piece of this puzzle. Until bug 13430 is fixed,
render tree construction will be O(n^{2) (because of the minmaxrecalc bit setting being stupid enough to

always crawl to the root of the tree) and calcMinMaxWidth will waste tons of unnecessary time.}

When these fixes are combined with the calcMinMaxWidth fix in 13430, the penguin page specified in 13337
loads in < 2 seconds (down from an infinite hang before).

Reviewed by aroben, ollie

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle):
css/csstyleselector.h Cap the depth of cousin searching on the shared style optimization. We will be willing to (at most) crawl up the tree the same distance that we were willing to crawl backwards through sibling lists. Leaving it uncapped resulted in pathological style resolution for the case of an infinitely nested chain of singletons.

html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::popBlock): Cap the number of residual style tags that we are willing to reopen. We will reopen at most 200 residual style tags, since the assumption is that once that many tags are on the stack, you're probably already every kind of bold, italic, and color of the rainbow.

rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): absoluteClippedOverflowRect can just return the empty rect when the inline flow has no line boxes instead of doing a bunch of work (and calling containingBlock()) for no reason.

rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): Remove the useless containingBlock() check from addChildToFlow. Obviously every inline's containing block is a block flow.

rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::RenderBlock::createLineBoxes): Cap the depth of individual line trees to 200. Again the assumption is that once that many open inlines exist all on one line that there's no way this would be intentional.

7:47 PM Changeset in webkit [21060] by aroben

2 edits in trunk/WebKitTools

Reviewed by Mark Rowe and David Kilzer.

Scripts/build-webkit: Print the path to the run-safari script when finished building so that users can copy-and-paste the command to execute it.

6:27 PM Changeset in webkit [21059] by hyatt

2 edits in trunk/WebCore

Fix for bug 13430, cap inline splitting for continuations to a maximum depth of 200.

Reviewed by olliej, antti

rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines):

5:59 PM Changeset in webkit [21058] by bdash

2 edits in trunk/WebCore

2007-04-23 Alp Toker <alp@atoker.com>

Gdk build fix. Track EventHandler change made in r21042.

page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):

5:37 PM Changeset in webkit [21057] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5024945> -[DOMRange lineBoxRects] doesn't include start and end nodes that have offsets

rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): Use min(box->len(), end) instead of special-casing UINT_MAX.

5:31 PM Changeset in webkit [21056] by adele

2 edits in trunk/WebCore

Fix by Darin, reviewed by me.

Fix for REGRESSION: Can't upload attachments to bugzilla since the file upload control is reset immediately
http://bugs.webkit.org/show_bug.cgi?id=13461

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Only clear the FileChooser if the value is empty *and* (not or) the filename is empty.

4:48 PM Changeset in webkit [21055] by adele

2 edits in trunk/WebCore

Reviewed by Adam.

Updated fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Use a const int maxSavedResults instead of magic number 256.

4:45 PM Changeset in webkit [21054] by thatcher

1 edit in trunk/WebCore/ChangeLog

Fix the bug number for my last commit.

4:42 PM Changeset in webkit [21053] by thatcher

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5084400> [DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Don't call selectionRect with a -1 end position, instead use the text length.

rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):

4:27 PM Changeset in webkit [21052] by adele

4 edits in trunk

WebCore:

Fixed and reviewed by Darin, Adele, and Oliver.

WebCore part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
http://bugs.webkit.org/show_bug.cgi?id=13263

dom/KeyboardEvent.h: (WebCore::KeypressCommand::isEmpty): Added helper method.

WebKit:

Fixed and reviewed by Darin, Adele, and Oliver.

WebKit part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
http://bugs.webkit.org/show_bug.cgi?id=13263

WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): If we have no command after calling interpretKeyEvents, we assume the input method handled the key. (-[WebHTMLView doCommandBySelector:]): Add noop: to the command vector, but then when actually performing actions, ignore it.

3:56 PM Changeset in webkit [23331] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.

3:51 PM Changeset in webkit [21051] by pyeh

2 edits in trunk/WebCore

<rdar://problem/4938364> Attachment button has different string length between attributeStringForRange and stringForRange

<rdar://problem/4939536> AXLengthForTextMarkerRange returns zero length for the range of an attachment

Reviewed by Darin.

bridge/mac/WebCoreAXObject.mm: (nsStringForReplacedNode): Added helper routine to check if the replaced node should be exposed as an attachment character in string representation. Added an additional check to make sure that text node is not considered a replaced node. Removed helper routine AXAttributedStringAppendReplaced since half of the functions are now taken care by nsStringForReplacedNode. The other half is directly used in the doAXAttributedStringForTextMarkerRange method. (-[WebCoreAXObject doAXStringForTextMarkerRange:]): (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]): Both string and AttrbributedString methods will now utilize the helper routine nsStringForReplacedNode to return replacement characters for range occupied by attachment.

3:14 PM Changeset in webkit [21050] by mjs

2 edits in trunk/JavaScriptCore

Build fix, not reviewed.

kjs/collector.h: Fix struct/class mismatch.

3:10 PM Changeset in webkit [21049] by adele

2 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Enforce a maximum of 256 saved results for the search field.

3:08 PM Changeset in webkit [21048] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.

kjs/collector.cpp:

2:54 PM Changeset in webkit [21047] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

move mark and collectOnMainThreadOnly bits into separate bitmaps

This saves 4 bytes per cell, allowing shrink of cell size to 32,
which leads to a .8% speed improvement on iBench.

This is only feasible because of all the previous changes on the branch.

kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.

2:24 PM Changeset in webkit [21046] by adele

3 edits in trunk/LayoutTests

Reviewed by Adam.

Updating test from last checkin to include test case for select with and without a form element.

fast/events/onchange-select-popup-expected.txt:
fast/events/onchange-select-popup.html:

2:15 PM Changeset in webkit [21045] by adele

11 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt & Adam.

Tests for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event

fast/events/onchange-passwordfield-expected.txt:
fast/events/onchange-passwordfield.html:
fast/events/onchange-searchfield-expected.txt:
fast/events/onchange-searchfield.html:
fast/events/onchange-select-popup-expected.txt: Added.
fast/events/onchange-select-popup.html: Added.
fast/events/onchange-textfield-expected.txt:
fast/events/onchange-textfield.html:
fast/forms/onchange-enter-submit-expected.txt:

WebCore:

Reviewed by Hyatt & Adam.

Fix for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event
Fix for <rdar://problem/5153970> onChange doesn't fire when focusing a popup, using type-ahead to select, and leaving

This previous behavior to blur controls when hitting enter was added to achieve the result of firing the change event. Firefox does not
fire blur- just the change event, so this fix will match Firefox behavior.

This also fixes a bug where we didn't fire the change event when using type-ahead selection with the popup menu.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fire change event instead of blur event when hitting enter.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::dispatchFocusEvent): Now that we have type-ahead selection for popups that can be opened with the arrow keys, we should always save the last selection when a popup gets focus, so it can be compared to the current selection when it loses focus. (WebCore::HTMLSelectElement::dispatchBlurEvent): For the same reasons as above, we should fire onChange for all popups on blur.

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire change event instead of blur event when hitting enter. Removed an unnecessary

check for form() before calling menuListOnChange(). Removed an unnecessary check for renderer() and usesMenuList().

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Remove call to blur. Since list boxes fire the change event immediately after an

action is taken, we don't need to fire anything after hitting enter.

(WebCore::HTMLSelectElement::menuListOnChange): Reset m_lastOnChangeIndex after firing the change event.

2:07 PM Changeset in webkit [21044] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5124364> IB3 crashes when loading a nib containing a WebView that has a WebHTMLView encoded inside

Since WebView's initWithCoder throws away all the decoded subviews, the WebHTMLView gets dealoced while it has a nil _private pointer.
Checking for a nil _private in WehHTMLView's close fixes this crash. No need to implement a full initWithCoder for WebHTMLView since
it will be thrown away by the WebView anyway.

WebView/WebHTMLView.mm: (-[WebHTMLView close]): Return earily if _priviate is nil. (-[WebHTMLView initWithFrame:]): Unrelated change that removes an AppKit version check that predates Tiger.

12:19 PM Changeset in webkit [21043] by zbujtas

2 edits in S60/trunk/WebKit

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix ROM image iby file
http://bugs.webkit.org/show_bug.cgi?id=13419

rom/webkit.iby:

10:07 AM Changeset in webkit [21042] by andersca

4 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)

Pass wheel events to all widgets.

page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
page/EventHandler.h:
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget):

8:32 AM Changeset in webkit [21041] by bdash

2 edits in trunk/WebCore

2007-04-23 Alp Toker <alp@atoker.com>

Reviewed by Mark.

Save and restore the context state when beginning and ending a transparency layer.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer):

8:01 AM Changeset in webkit [21040] by thatcher

2 edits in trunk/WebKit

Reviewed by Mark Rowe.

Remove the "No Selection" message after leaving search mode.
This was a regression caused by the inspector refresh.

WebInspector/webInspector/inspector.js:

7:45 AM Changeset in webkit [21039] by bdash

1 copy in tags/Safari-4522.6.2/JavaScriptGlue

New tag (part 2).

7:45 AM Changeset in webkit [21038] by bdash

1 add in tags/Safari-4522.6.2

New tag (part 1).

7:43 AM Changeset in webkit [21037] by bdash

1 edit in branches/Safari-522/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

7:42 AM Changeset in webkit [21036] by bdash

2 edits in branches/Safari-522/JavaScriptGlue

Merge r20462.

7:16 AM Changeset in webkit [21035] by bdash

2 edits in trunk/WebCore

2007-04-23 Alp Toker <alp@atoker.com>

Reviewed by Mark.

Further implementation and checks. The opacity layer code is not so beautiful
but gets the job done with fewer complications than maintaining our own stack.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):

7:14 AM Changeset in webkit [21034] by andersca

2 edits in trunk/JavaScriptCore

Build fix.

kjs/regexp_object.h: RegExpObjectImpPrivate is a struct, not a class.

6:33 AM Changeset in webkit [21033] by yongjzha

12 edits in S60/trunk/WebKit

winship, reviewed by Yongjun

DESC: move DialogMimeFileSelectLC from DialogProvider API to MWidgetCallBack
http://bugs.webkit.org/show_bug.cgi?id=13406

BrowserControl/inc/BrCtl.h:
BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
BrowserControl/inc/BrCtlDialogsProvider.h: (TBrCtlSelectOptionData::TBrCtlSelectOptionData): (TBrCtlImageCarrier::TBrCtlImageCarrier):
BrowserControl/inc/BrCtlInterface.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::CreateWidgetExtensionL):
BrowserCore/Formcontrols/inc/FControlFileInputSkin.h:
BrowserCore/Formcontrols/src/FControlFileInputSkin.cpp: (TFileDialogWrapper::DialogMimeFileSelectLC): (CFormFileInputSkin::SetAcceptedMimeType): (CFormFileInputSkin::ActivateL):
BrowserView/inc/WidgetExtension.h:
group/BWINSCW/WebKit_30U.def:
group/EABI/browserengineU.def:
group/formcontrols.mmpi:

3:28 AM Changeset in webkit [21032] by mjs

7 edits in trunk/JavaScriptCore

Reviewed by Darin.

shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
kjs/function.h:
kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.

2:45 AM Changeset in webkit [21031] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

shrink RegexpObjectImp by 4 bytes

Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.

kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
kjs/regexp_object.h:

2:27 AM Changeset in webkit [21030] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Oliver.

change to 1-bit bitfields instead of 8-bit, this turns out to lead to a .51% speedup on JS iBench

The 1-bit bitfields are actually faster than just plain bools, at least on Intel (go figure).

kjs/property_map.h:

1:53 AM Changeset in webkit [21029] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

shrink ArrayInstance objects by 4 bytes http://bugs.webkit.org/show_bug.cgi?id=13386

I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

kjs/array_instance.h: (KJS::ArrayInstance::capacity): Get it from the secret stash
kjs/array_object.cpp: (allocateStorage): New function to encapsulate allocating the storage with extra space ahead for the capacity. (reallocateStorage): ditto for realloc (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):

1:47 AM Changeset in webkit [21028] by thatcher

5 edits in trunk/WebKit

Reviewed by Darin.

Bug 6658: World leak when closing inspected window
http://bugs.webkit.org/show_bug.cgi?id=6658 and <rdar://problem/4411863>

Removes over-retains of the inspector WebView, WebInspector and WebInspectorPanel.

WebInspector/WebInspector.m: (+sharedWebInspector): Return the global sharedWebInspector variable. (-window): Release the window after calling setWindow:. (-windowWillClose:): Set the JavaScript Inspector variable to null and expire the current highlight. Also clear the global sharedWebInspector variable and release it if self equals sharedWebInspector. (-showWindow:): Set the JavaScript Inspector variable back to self.
WebInspector/WebInspectorInternal.h: Remove the isSharedInspector member variable.
WebView/WebView.mm: (-[WebView windowScriptObject]): Return nil if core([self mainFrame]) is NULL.

1:38 AM Changeset in webkit [21027] by darin

9 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

fix <rdar://problem/4840688> REGRESSION (r10588, r10621): JavaScript won't parse modifications of non-references (breaks 300themovie.warnerbros.com, fedex.com)

Despite the ECMAScript specification's claim that you can treat these as syntax
errors, doing so creates some website incompatibilities. So this patch turns them back
into evaluation errors instead.

Test: fast/js/modify-non-references.html

kjs/grammar.y: Change makeAssignNode, makePrefixNode, and makePostfixNode so that they never fail to parse. Update rules that use them. Fix a little bit of indenting. Use new PostfixErrorNode, PrefixErrorNode, and AssignErrorNode classes.

kjs/nodes.h: Added an overload of throwError that takes a char* argument. Replaced setExceptionDetailsIfNeeded and debugExceptionIfNeeded with handleException, which does both. Added PostfixErrorNode, PrefixErrorNode, and AssignErrorNode classes.

kjs/nodes.cpp: Changed exception macros to use handleException; simpler and smaller code size than the two functions that we used before. (Node::throwError): Added the overload mentioned above. (Node::handleException): Added. Contains the code from both setExceptionDetailsIfNeeded and debugExceptionIfNeeded. (PostfixErrorNode::evaluate): Added. Throws an exception. (PrefixErrorNode::evaluate): Ditto. (AssignErrorNode::evaluate): Ditto. (ThrowNode::execute): Call handleException instead of debugExceptionIfNeeded; this effectively adds a call to setExceptionDetailsIfNeeded, which may help with getting the correct file and line number for these exceptions.

kjs/nodes2string.cpp: (PostfixErrorNode::streamTo): Added. (PrefixErrorNode::streamTo): Added. (AssignErrorNode::streamTo): Added.

LayoutTests:

Reviewed by Maciej.

test for <rdar://problem/4840688> REGRESSION (r10588, r10621): JavaScript won't parse modifications of non-references (breaks 300themovie.warnerbros.com, fedex.com)

fast/js/modify-non-references-expected.txt: Added.
fast/js/modify-non-references.html: Added.
fast/js/resources/modify-non-references.js: Added.

fast/js/assign-expected.txt: Updated for different exception text.
fast/js/postfix-syntax-expected.txt: Ditto.
fast/js/prefix-syntax-expected.txt: Ditto.

1:27 AM Changeset in webkit [21026] by darin

22 edits in trunk

LayoutTests:

Reviewed by Hyatt.

test changes for rename of box-sizing to -webkit-box-sizing

fast/borders/border-fit.html: Rename.
fast/box-sizing/box-sizing.html: Ditto.
fast/box-sizing/panels-one.html: Added -webkit-box-sizing.
fast/box-sizing/panels-two.html: Ditto.
fast/box-sizing/percentage-height.html: Renamed -khtml-box-sizing to -webkit-box-sizing.
fast/css/computed-style-expected.txt: Updated for different name and place in sorting order.
tables/mozilla/core/box_sizing.html: Rename.

WebCore:

Reviewed by Hyatt.

rename box-sizing to -webkit-box-sizing because of <rdar://problem/4667227> REGRESSION: Shifted table on page at https://us.etrade.com/e/t/home (due to box-sizing)

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Rename.
css/CSSPropertyNames.in: Ditto.
css/cssparser.cpp: (WebCore::CSSParser::parseValue): Rename and take out comment explaining why we aren't prefacing with -webkit.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Rename.
css/html4.css: Rename.
css/quirks.css: Rename.

WebKit:

Reviewed by Hyatt.

rename box-sizing to -webkit-box-sizing

WebInspector/webInspector/inspector.css: Here.
WebInspector/webInspector/inspector.js: And here, in the expected default CSS values list.

WebKitTools:

Reviewed by Hyatt.

rename box-sizing to -webkit-box-sizing

Drosera/console.css: Here.
Drosera/debugger.css: And here.
Drosera/viewer.css: And here.

12:54 AM Changeset in webkit [21025] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

fix test failures / crashes on PPC

kjs/property_map.h: Make the bool fields explicitly 8-bit bitfields, since bool is a full word there otherwise :-(

12:44 AM Changeset in webkit [21024] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

fix more test case failures

bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray): inherit from JSObject instead of ArrayInstance; it turns out that this class only needs the prototype and classInfo from ArrayInstance, not the actual class itself, and it was too big otherwise. (RuntimeArray::getOwnPropertySlot):
bindings/runtime_array.h:

12:15 AM Changeset in webkit [21023] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

fix some test failures

bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl, otherwise this is too big (RuntimeMethod::getOwnPropertySlot):
bindings/runtime_method.h:

12:13 AM Changeset in webkit [21022] by bdash

4 edits in trunk/WebCore

2007-04-23 Alp Toker <alp@atoker.com>

Reviewed by Hyatt.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawConvexPolygon): Fix stroking and filling of ellipses and polygons.
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Make use of a new GraphicsContext function to simplify the code. (WebCore::Image::drawPattern): Now implemented. This makes content with tiled patterns (eg. CSS repeat) render correctly.
platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern): Remove old stub.

Apr 22, 2007:

11:46 PM Changeset in webkit [21021] by bdash

3 edits in trunk/WebCore

2007-04-22 Lars Naesbye Christensen <lars@naesbye.dk>

Reviewed by Tim Hatcher.

Prettier, more modern 'cell' cursor
http://bugs.webkit.org/show_bug.cgi?id=13441
Also updates past ChangeLog entries to new email address

ChangeLog:
ChangeLog-2006-12-31:
Resources/cellCursor.png:

11:17 PM Changeset in webkit [21020] by bdash

2 edits in trunk/WebCore

2007-04-23 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Hyatt.

Rename cMaxPenderingSourceLengthInLowBandwidthDisplay to cMaxPendingSourceLengthInLowBandwidthDisplay.

loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):

9:16 PM Changeset in webkit [21019] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by Darin.

discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup) http://bugs.webkit.org/show_bug.cgi?id=13385

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.

This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.

Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).

kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
kjs/function.h:
kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

9:10 PM Changeset in webkit [21018] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by Darin.

shrink PropertyMap by 8 bytes and therefore shrink CELL_SIZE to 40 (for 32-bit; similar shrinkage for 64-bit) http://bugs.webkit.org/show_bug.cgi?id=13384

Inspired by similar changes by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.

This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.

kjs/collector.cpp: (KJS::):
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):

9:01 PM Changeset in webkit [21017] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

change blocks to 64k in size, and use various platform-specific calls to allocate at 64k-aligned addresses http://bugs.webkit.org/show_bug.cgi?id=13383

kjs/collector.cpp: (KJS::allocateBlock): New function to allocate 64k of 64k-aligned memory (KJS::freeBlock): Corresponding free (KJS::Collector::allocate): (KJS::Collector::collect):

8:29 PM Changeset in webkit [21016] by mjs

1 edit in trunk/WebCore/ChangeLog

Added bugzilla URL to earlier commit.

8:28 PM Changeset in webkit [21015] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

remove the concept of oversize objects, now that there aren't any (for now only enforced with an assert). http://bugs.webkit.org/show_bug.cgi?id=13382

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.

kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.

8:09 PM Changeset in webkit [21014] by mjs

4 edits in trunk/WebCore

Reviewed by Darin and Geoff.

move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it

It was the only remaining JSObject subclass to use the oversize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.

No significant effect on JS iBench.

bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
bindings/js/kjs_window.h:

8:08 PM Changeset in webkit [21013] by hyatt

2 edits in trunk/WebCore

Fix 1% regression on the PLT. Make sure roundToDevicePixels does no
work when no scale is in effect.

Reviewed by mjs

5:44 PM Changeset in webkit [21012] by darin

3 edits in trunk/WebCore

Reviewed by Oliver.

fix small things noticed while looking into a font subsitution bug

platform/Font.h: (WebCore::Font::operator==): Corrected a misleading comment.

platform/Font.cpp: (WebCore::Font::Font): Initialize m_pageZero to 0 in the empty constructor instead of leaving it uninitialized. Initialize m_fontList for tighter code. Remove unneeded initialization of RefPtr members to 0. Changed the copy constructor to use initialization for tighter code. (WebCore::Font::operator=): Sorted to match the order from the header and the copy constructor, and removed the uneeded self-assignment check.

5:38 PM Changeset in webkit [21011] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

The fix for <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject
was #ifdefed out in Production builds.

WebView/WebView.mm: (+[WebView initialize]): Move the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM inside initialize around the specific code (+[WebView _applicationWillTerminate]): Moved outside the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM block

4:14 PM Changeset in webkit [21010] by darin

5 edits
1 add in trunk/WebCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=5196 <rdar://problem/4537384> input type=file fields with style=display:none do not post their values (5196)

fix http://bugs.webkit.org/show_bug.cgi?id=8248 Can not clear file input field

manual-tests/clear-input-file.html: Added.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Remove check that prevents submission of form data when there is no renderer or the renderer is invisible. While well-intentioned, the rule does not match the behavior of other web browsers. (WebCore::HTMLInputElement::setValue): Instead of disallowing all value changes for file type, allow changes to the empty string. (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Made file type return true for this. 1) The file type does store its value separate from the value attribute. 2) The code in setInputType() should do the right thing given this new value, according to my inspection of the code. 3) The code in both reset() and setValue() will work properly if this is true, which was the motivation for changing it.

platform/FileChooser.h: Added a clear function.
platform/FileChooser.cpp: (WebCore::FileChooser::clear): Clear the filename and the icon.

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Used a local variable to make the code a little bit more readable (and match the change below). (WebCore::RenderFileUploadControl::updateFromElement): Used local variables a bit more in the old code. Added code that will call clear on the FileChooser and repaint if the DOM element has an empty value and the FileChooser does not.

4:12 PM Changeset in webkit [21009] by darin

9 edits in trunk/WebCore

Reviewed by Hyatt.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12279
Implemented two pass loading. Enabled by WTF_USE_LOW_BANDWIDTH_DISPLAY flag.

dom/Document.cpp: (WebCore::Document::Document): initialize member variable m_inLowBandwidthDisplay

dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): while in low bandwidth display mode, ignore pending style sheets (WebCore::Document::setDocLoader): (WebCore::Document::inLowBandwidthDisplay): (WebCore::Document::setLowBandwidthDisplay):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): while in low bandwidth display mode, don't execute JavaScript

loader/Cache.cpp: (WebCore::Cache::requestResource): while in low bandwidth display mode, don't let style sheet and JavaScript block

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): add notifyFinished() as client may need "this" pointer

loader/DocLoader.h: (WebCore::DocLoader::replaceDocument):
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): while in low bandwidth display mode, don't load sub-frame (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): set to low bandwidth display mode if the top frame is HTML document (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::checkCompleted): while in low bandwidth display mode, don't set complete (WebCore::FrameLoader::requestObject): while in low bandwidth display mode, don't care Object (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::removeAllLowbandwidthDisplayRequests): (WebCore::FrameLoader::notifyFinished): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
loader/FrameLoader.h: (WebCore::FrameLoader::FrameLoader::needToSwitchOutLowBandwidthDisplay): (WebCore::FrameLoader::FrameLoader::setUseLowBandwidthDisplay): (WebCore::FrameLoader::FrameLoader::useLowBandwidthDisplay):

3:57 PM Changeset in webkit [21008] by darin

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

test for http://bugs.webkit.org/show_bug.cgi?id=13439 4 problems found in dashboard-region parser and serializer

fast/css/dashboard-region-parser.html: Added.
fast/css/dashboard-region-parser-expected.txt: Added.

fast/css/dashboard-regions-attr-crash.html: Updated bug URL to point to bugs.webkit.org instead of bugzilla.opendarwin.org. At some point we should do this for the roughly 100 other tests that have the old URL.
fast/css/dashboard-regions-attr-crash-expected.txt: Ditto.

WebCore:

Reviewed by Tim Hatcher.

fix http://bugs.webkit.org/show_bug.cgi?id=13439 4 problems found in dashboard-region parser and serializer

Test: fast/css/dashboard-region-parser.html

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Fix code that overwrote each additional region with the previous one to instead build a space-separated list. Check for the case of an identifier that's invalid, since that's (accidentally) how we represent a region value that doesn't have explicit top/right/bottom/left values. The old code would end up writing out four spaces after the region type.

css/cssparser.cpp: (WebCore::CSSParser::parseDashboardRegions): Fail to parse if there is something after the "none" identifier or after the arguments inside the dashboard-region "function". Also replaced code that produced a identifier with CSS_VAL_INVALID in a roundabout way with code that does it explicitly.

3:12 PM Changeset in webkit [21007] by thatcher

2 edits in trunk/WebKit

Reviewed by Mitz.

Bug 13436: Make Option-clicking a disclosure triangle expand the entire subtree
http://bugs.webkit.org/show_bug.cgi?id=13436

Makes option-click recursively expand and collapse the sub-tree. Pressing option-left
and -right also recursively expands and collapses the sub-tree.

WebInspector/webInspector/treeoutline.js:

3:05 PM Changeset in webkit [21006] by thatcher

2 edits in trunk/WebKit

Reviewed by Mitz.

Bug 13437: Inspector does not update when navigating to a different page
http://bugs.webkit.org/show_bug.cgi?id=13437

WebInspector/webInspector/inspector.js: Correctly update to a new root node if the new focus node and the old focus node don't have a common ancestor.

1:28 PM Changeset in webkit [21005] by kevino

4 edits
1 add in branches/wx-port-alpha/trunk

Get JavaScriptCore tests running on the wxWebKit branch. (use run-wxwebkit-tests to run them)

10:24 AM Changeset in webkit [23330] by darin

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added a new test that requires emacs key bindings that we don't have implemented in Boomer.

10:17 AM Changeset in webkit [21004] by darin

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/5100240> REGRESSION: Control-O broken

editing/input/emacs-ctrl-o-expected.checksum: Added.
editing/input/emacs-ctrl-o-expected.png: Added.
editing/input/emacs-ctrl-o-expected.txt: Added.
editing/input/emacs-ctrl-o.html: Added.

WebCore:

Reviewed by Adele.

support for fix for <rdar://problem/5100240> REGRESSION: Control-O broken

dom/KeyboardEvent.h: Include a vector of command names in the KeypressCommand object instead of a single command name.

WebKit:

Reviewed by Adele.

fix for <rdar://problem/5100240> REGRESSION: Control-O broken

WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Update to handle a vector of command names instead of a single command. (-[WebHTMLView doCommandBySelector:]): Change logic so that we add the command to a vector and also so that the interpretKeyEvents parameters are still intact for a second call to doCommandBySelector:, since the key bindings mechanism can do more than one. (-[WebHTMLView insertText:]): Added comment.

1:23 AM Changeset in webkit [21003] by ap

7 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13115
REGRESSION: 1000% performance regression in DOM access by index, which was already slow

dom/NodeList.h: Move cached data into a separate class, so it can be shared.

dom/Node.h: Replace the set of registered NodeLists with a struct that also contains a shared NodeList::Caches (so the size of Node doesn't change).

dom/NodeList.cpp: (WebCore::NodeList::NodeList): (WebCore::NodeList::~NodeList): (WebCore::NodeList::recursiveLength): (WebCore::NodeList::itemForwardsFromCurrent): (WebCore::NodeList::itemBackwardsFromCurrent): (WebCore::NodeList::recursiveItem): (WebCore::NodeList::itemWithName): (WebCore::NodeList::rootNodeChildrenChanged): (WebCore::NodeList::NodeListInfo::NodeListInfo): (WebCore::NodeList::NodeListInfo::reset):
dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): (WebCore::ChildNodeList::length): (WebCore::ChildNodeList::item): (WebCore::ChildNodeList::nodeMatches):
dom/ChildNodeList.h:
dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): Adjust for the above changes.

Apr 21, 2007:

8:15 PM Changeset in webkit [21002] by andrew

3 edits
4 adds in trunk

LayoutTests:
2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=13391 REGRESSION (r18819): Incomplete repaint of button text

fast/repaint/control-clip-expected.checksum: Added.
fast/repaint/control-clip-expected.png: Added.
fast/repaint/control-clip-expected.txt: Added.
fast/repaint/control-clip.html: Added.

WebCore:
2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13391 REGRESSION (r18819): Incomplete repaint of button text

Test: fast/repaint/control-clip.html

Ignore controls' lightweight clip in repaint rect computation for now.

rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):

6:41 PM Changeset in webkit [21001] by darin

2 edits in trunk/WebCore

Reviewed by Adam.

fix <rdar://problem/4816343> :-khtml-drag CSS pseudo-class changed to :-webkit-drag, need alias

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Since Apple documentation claims "-khtml-drag" works, we need to keep it working, so add it back as an alias.

4:46 PM Changeset in webkit [21000] by darin

3 edits in trunk/WebKit

Reviewed by Oliver.

fix some problems I ran into using the inspector

WebInspector/webInspector/inspector.js: Add some null checks.

4:46 PM Changeset in webkit [20999] by darin

2 edits in trunk/WebCore

Reviewed by Oliver.

fix <rdar://problem/4782422> REGRESSION: -[stringByEvaluatingJavaScriptFromString] returns an empty string instead of nil for non-string results

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Added a call to nsStringNilIfEmpty to restore the old behavior. It might be nice to distinguish the empty string from a non-string result, but there's no obvious way to do that, and for compatibility it's probably best to just restore the old behavior instead.

3:31 PM Changeset in webkit [20998] by hyatt

3 edits in trunk/WebCore

Fix for bug 13432, determineFlowSpacing is O(n^2).

Reviewed by aroben

rendering/InlineBox.cpp: (WebCore::InlineBox::nextOnLineExists): (WebCore::InlineBox::prevOnLineExists):
rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):

2:38 AM Changeset in webkit [20997] by ap

8 edits
2 adds in trunk

2007-04-21 Lamar Goddard <lamargoddard@gmail.com>

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=5262
<rdar://problem/5018778>
XMLSerializer drops Namespace information

WebCore:

Updated WebCore::markup to output namespace information for elements/attributes whose namespace information
doesn't appear in its scope in the output.

WebCore/editing/markup.cpp: (WebCore::createMarkup(const Node*, ...)): Changed call to WebCore::markup to match parameters (WebCore::markup): Changed recursive call to match tree structure, removed ASSERT and no longer needed includeSiblings parameter. (WebCore::startMarkup): Added optional parameter to track namespaces in the current scope. (WebCore::addNamespace): Function to add namespace information to markup. (WebCore::shouldAddNamespaceAttr): (WebCore::shouldAddNamespaceElem): Functions that test whether namespace information should be added for a given node.
WebCore/dom/Document.idl: (createElementNS): (createAttributeNS): (getElementsByTagNameNS): Added [ConvertNullToNullString] to namespaceURI parameter.
WebCore/dom/Node.cpp: (Node::getElementsByTagNameNS): removed test for namespaceURI being null as null can be a valid namespace.

LayoutTests:

fast/dom/serialize-nodes-expected.txt: Added.
fast/dom/serialize-nodes.xhtml: Added.
dom/xhtml/level3/core/nodeisequalnode14-expected.txt: This test fails because createAttribute is supposed to create an Attr with localName of null.
dom/xhtml/level3/core/nodeisequalnode15-expected.txt: Now succeeds.
fast/innerHTML/004-expected.txt: Added namespace information to head and body nodes as xhtml nodes now serialize with namespace information.

1:50 AM Changeset in webkit [20996] by ap

4 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13300
Reproducible crash opening anekdot.ru

WebCore:

html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::getNode): (WebCore::HTMLParser::handleIsindex):
html/HTMLParser.h: Made HTMLParser::form a RefPtr, and renamed it to m_currentFormElement. Made m_currentMapElement a RefPtr.

LayoutTests:

fast/parser/rewrite-form-expected.txt: Added.
fast/parser/rewrite-form.html: Added.
fast/parser/rewrite-map-expected.txt: Added.
fast/parser/rewrite-map.html: Added.

1:20 AM Changeset in webkit [20995] by bdash

9 edits
4 adds in trunk

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13353 REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present

Test: fast/overflow/hit-test-overflow-controls.html

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Avoid activating scrollbars during layer resize.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): Renamed isPointInScrollbar to this, to reflect that it returns true for points in the resize corner as well. Changed it to call the layer to do the actual work. (WebCore::RenderBlock::nodeAtPoint): Updated for the above rename.
rendering/RenderBlock.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): Fixed typo in this function's name (it was horizontaScrollbarWidget). (WebCore::RenderLayer::hitTestOverflowControls): Added. Returns whether the hit point is in one of the scrollbars or the resize corner, and updates the platform scrollbar in the hit test result if a scrollbar was hit.
rendering/RenderLayer.h:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): Rename.
rendering/RenderListBox.h:

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13353 REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present

fast/overflow/hit-test-overflow-controls-expected.checksum: Added.
fast/overflow/hit-test-overflow-controls-expected.png: Added.
fast/overflow/hit-test-overflow-controls-expected.txt: Added.
fast/overflow/hit-test-overflow-controls.html: Added.

1:17 AM Changeset in webkit [20994] by bdash

6 edits in trunk

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13350 Build Ahem into DumpRenderTree

DumpRenderTree/DumpRenderTree.m: (activateAhemFont): Added. Activates the copy of Ahem included in the DumpRenderTree binary. (dumpRenderTree): Replaced the check that Ahem is available with a call to activateAhemFont().
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker options to include Ahem in the data section of the DumpRenderTree binary.

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13350 Build Ahem into DumpRenderTree

quality/testing.html: Removed the requirement to download and install Ahem for running the tests.
quality/testwriting.html: Added information about Ahem.

1:14 AM Changeset in webkit [20993] by bdash

3 edits
2 adds in trunk

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13417 Repro crash when the first argument to getMatchedCSSRules is not an element

Test: fast/dom/Window/getMatchedCSSRules-null-crash.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13417 Repro crash when the first argument to getMatchedCSSRules is not an element

fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt: Added.
fast/dom/Window/getMatchedCSSRules-null-crash.html: Added.

1:12 AM Changeset in webkit [20992] by bdash

3 edits in trunk/WebCore

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13416 Repro crash after referencing the user stylesheet from JavaScript

No test included because DumpRenderTree does not support setting the user stylesheet.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::~CSSStyleSelector):
css/cssstyleselector.h: Made m_userSheet a RefPtr.

1:09 AM Changeset in webkit [20991] by bdash

2 edits in trunk/JavaScriptCore

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=13428 REGRESSION (r20973-r20976): Failing ecma/Array/15.4.4.5-3.js

fix http://bugs.webkit.org/show_bug.cgi?id=13429 REGRESSION (r20973-r20976): Crashing in fast/dom/plugin-attributes-enumeration.html

kjs/array_object.cpp: (ArrayInstance::sort): Free the old storage, not the new one.

1:08 AM Changeset in webkit [20990] by bdash

2 edits in trunk/WebCore

2007-04-21 MorganL <morganl.webkit@yahoo.com>

Reviewed by Adam.

NPObject should be forward declared using 'struct' instead of 'class'

page/Frame.h:

12:51 AM Changeset in webkit [20989] by bdash

2 edits in trunk/WebCore

2007-04-21 Alp Toker <alp@atoker.com>

Gdk build fix.

platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Use the correct casts.

Apr 20, 2007:

11:43 PM Changeset in webkit [20988] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Fixes the build.

11:19 PM Changeset in webkit [20987] by thatcher

1 delete in branches/WebInspectorRefresh

Remove the branch now that the changes were merged over to source:trunk in r20986.

11:14 PM Changeset in webkit [20986] by thatcher

2 edits
11 copies
2 deletes in trunk/WebKit

Reviewed by Darin.

Merge over the WebInspectorRefresh branch. This change removes the NSOutlineView and
is replaced with a HTML/JavaScript tree. Most of the inspector logic is now in the JavaScript.

A few bugs are fixed by these changes:

Bug 6615: Parent node drop-down list is upside-down
http://bugs.webkit.org/show_bug.cgi?id=6615

Bug 6643: REGRESSION: Tree view repaints lines without erasing them first
http://bugs.webkit.org/show_bug.cgi?id=6643

Bug 6650: Web Inspector HTML Hierarchy can't be scrolled with scrollwheel
http://bugs.webkit.org/show_bug.cgi?id=6650

Bug 6677: Can't drag inspector when tree view has focus
http://bugs.webkit.org/show_bug.cgi?id=6677

Bug 7326: Web Inspector tree scrollbar always shows up when resizing the top pane down
http://bugs.webkit.org/show_bug.cgi?id=7326

WebInspector/WebInspector.h: Removed the searchQuery methods.
WebInspector/WebInspector.m: Removed the DOMNode category and code for the old outline view.
WebInspector/WebInspectorOutlineView.h: Removed.
WebInspector/WebInspectorOutlineView.m: Removed.
WebInspector/WebInspectorInternal.h: Remove some methods and instance variables.
WebInspector/webInspector/Images/resize.png: Added.
WebInspector/webInspector/inspector.css:
WebInspector/webInspector/inspector.html: Include the new classes and remove the plugin.
WebInspector/webInspector/inspector.js: Changes to use the new tree outline and other fixes.
WebInspector/webInspector/scrollarea.js: Copied from the Dashboard widget resources.
WebInspector/webInspector/scrollbar.js: Ditto.
WebInspector/webInspector/treeoutline.js: New tree outline class.
WebInspector/webInspector/utilities.js: DOM and String prototype additions.
WebKit.xcodeproj/project.pbxproj: Remove WebInspectorOutlineView.

7:00 PM Changeset in webkit [20985] by bdash

1 copy in tags/Safari-4522.6.1

New tag.

6:49 PM Changeset in webkit [20984] by bdash

4 edits in branches/Safari-522

Versioning.

6:46 PM Changeset in webkit [20983] by bdash

8 edits in branches/Safari-522

Merge r20445.

6:00 PM Changeset in webkit [20982] by bdakin

1 edit
2 adds in trunk/LayoutTests

Reviewed by Adam.

Test I meant to check in a while ago.

fast/events/fire-scroll-event-expected.txt: Added.
fast/events/fire-scroll-event.html: Added.

5:58 PM Changeset in webkit [23329] by adachan

11 edits in branches/WindowsMerge

5:55 PM Changeset in webkit [23328] by bdakin

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5089822> Boomer does not send scroll events

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged):

5:26 PM Changeset in webkit [20981] by beidson

6 edits in trunk

WebCore:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

WebCore.exp:
history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList): Set the flag to true by default (WebCore::BackForwardList::addItem): Check the flag and bail if its false (WebCore::BackForwardList::setCapacity): More correct if it set the m_current to NoCurrentItemIndex if we're setting capacity to 0 (WebCore::BackForwardList::enabled): (WebCore::BackForwardList::setEnabled): If we're disabling, cycle capacity to 0 and back to flush things out
history/BackForwardList.h: Add enabled(), setEnabled(bool), and m_enabled

WebKit:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

WebView/WebView.mm: Remove _private->useBackForwardList (-[WebView _setInitiatedDrag:]): Use _private->page instead of [self page] (-[WebView initWithCoder:]): Manipulate the flag that is now in WebCore::BackForwardList (-[WebView encodeWithCoder:]): Ditto (-[WebView backForwardList]): Use _private->page instead of [self page] (-[WebView setMaintainsBackForwardList:]): Manipulate the flag that is now in WebCore::BackForwardList

5:24 PM Changeset in webkit [20980] by hyatt

5 edits in trunk/WebCore

Bug 13424, firstLineStyle and verticalPositionHint together take
33% of the time on the new tag nesting PLT. Don't waste time even
looking for first-line styles if no stylesheet used them.

Reviewed by beth

css/CSSGrammar.y:
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::usesFirstLineRules): (WebCore::Document::setUsesFirstLineRules):
rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::firstLineStyle):

5:14 PM Changeset in webkit [20979] by thatcher

1 copy in tags/Safari-4522.6

New tag.

5:13 PM Changeset in webkit [20978] by thatcher

4 edits in branches/Safari-522

Versioning

3:50 PM Changeset in webkit [20977] by mjs

2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

fix build problem with last change - -O3 complains more about uninitialized variables

pcre/pcre_compile.c: (compile_branch): (pcre_compile2):

3:33 PM Changeset in webkit [20976] by aroben

2 edits in trunk/WebKitTools

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13421
Bug 13421: prepare-ChangeLog should use svn-create-patch when spewing diffs

Scripts/prepare-ChangeLog: Use svn-create-patch instead of svn diff.

3:26 PM Changeset in webkit [20975] by oliver

2 edits in trunk/WebCore

2007-04-20 Peter Kasting <pkasting@google.com>

Reviewed by Oliver.

fix http://bugs.webkit.org/show_bug.cgi?id=13420

platform/TextEncodingRegistry.cpp: (WebCore::addToTextEncodingNameMap): Change a pointer comparison to a strcmp(), since the strings here are not necessarily pointer-equivalent.

3:20 PM Changeset in webkit [23327] by aroben

2 edits in branches/WindowsMerge/WebKitTools

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Use WebKitConfigSuffix instead of ConfigSuffix.

3:20 PM Changeset in webkit [20974] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)

kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
kjs/config.h:

3:00 PM Changeset in webkit [20973] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

bump optimization flags up to -O3 for 1% JS iBench speed improvement

Configurations/Base.xcconfig:

2:52 PM Changeset in webkit [20972] by darin

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff Garen and John Sullivan.

test changes for <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

fast/dom/iframe-document-expected.txt: Added.
fast/dom/iframe-document.html: Added.

fast/dom/attr_dead_doc.html: Changed to use contentDocument instead of relying on the document property on HTMLIFrameElement.
fast/events/mouseover-mouseout.html: Ditto.
fast/frames/repaint-display-none-crash.html: Ditto.

WebCore:

Reviewed by Geoff Garen and John Sullivan.

fix <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

Test: fast/dom/iframe-document.html

bindings/js/kjs_html.h: Removed IFrameDocument.
bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::iFrameGetter): Ditto.

12:49 PM GtkAPIProposal edited by Kimmo Kinnunen

(diff)

12:47 PM GtkAPIProposal edited by Kimmo Kinnunen

(diff)

2:25 AM BuildingGdk edited by alp@atoker.com

Updated roadmap (diff)

2:01 AM Changeset in webkit [23326] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Explicitly link DRT against some Win32 libs because VC++ Express
doesn't link against them by default.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

1:47 AM Changeset in webkit [20971] by bdash

2 edits in trunk/JavaScriptCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Fix bogus optimisation in the generic pthread code path.

kjs/collector.cpp: (KJS::currentThreadStackBase):

12:50 AM Changeset in webkit [20970] by bdash

2 edits in trunk/JavaScriptCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

Improve FreeBSD compatibility, as suggested by Alexander Botero-Lowry.

kjs/collector.cpp: (KJS::currentThreadStackBase): FreeBSD requires that pthread_attr_t's are initialized via pthread_attr_init before being used in any context.

12:13 AM Changeset in webkit [20969] by andersca

2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5085897> REGRESSION: Some Flash links at www.jumpskyhigh.com just reload the page

Get rid of the check that would prevent plugin requests from being loaded if a new page load was underway.
www.jumpskyhigh.com had a flash movie that was embedded inside an <a> tag and clicking on the plug-in would cause the
URL pointed to by the <a> tag to start loading and thus preventing the plug-in from loading the real URL.

This check was added by Maciej and we should be able to remove it with the loader changes that have happened now,
(mainly the fact that resource loaders are handled by the document loader instead of the frame loader).

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

Apr 19, 2007:

11:54 PM Changeset in webkit [20968] by bdash

3 edits in trunk/WebCore

2007-04-19 Alp Toker <alp@atoker.com>

Reviewed by Mark.

platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix font support in Gdk port.

10:43 PM Changeset in webkit [23325] by aroben

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Removed empty filter.

10:40 PM Changeset in webkit [23324] by aroben

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Removed unused files.

10:37 PM Changeset in webkit [23323] by aroben

1 delete in branches/WindowsMerge/WebCore/kcanvas

Removed empty directory.

10:02 PM Changeset in webkit [20967] by hyatt

11 edits
4 adds in trunk

Fix for bug 13208, implement word-break. This patch produces a partial
implementation of word-break. word-break: break-all is implemented. In
addition, a custom value, word-break: break-word is added that is a hybrid
of word-wrap: break-word and word-break: break-all (and more useful than
either).

Reviewed by beth

Added fast/text/word-break.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/RenderStyle.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::breakWords): (WebCore::RenderStyle::wordBreak): (WebCore::RenderStyle::setWordBreak): (WebCore::RenderStyle::initialWordBreak): (WebCore::RenderStyle::initialWordWrap):
rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidthInternal):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::calcHeight):
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

9:59 PM Changeset in webkit [20966] by bdash

2 edits in trunk/WebCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Qt build fix for FreeBSD.

WebCore.pro: FreeBSD needs HAVE_PTHREAD_NP_H defined.

9:06 PM BuildingQtOnLinux edited by bdash@webkit.org

Info about another build error. (diff)

8:02 PM Changeset in webkit [23322] by aroben

6 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

Get rid of all uses of ATL CString in DumpRenderTree.

Also fixed a couple of bugs related to SAFEARRAY usage.

Unless otherwise noted, changes are simple converting CString usage to
std::wstring.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): (dumpFrameScrollPosition): The bounds of a SAFEARRAY are inclusive, so the length is upper - lower + 1. (compareHistoryItems): The vector we're sorting now holds COMPtrs, so changed to reflect that. (dumpHistoryItem): Use a Vector of COMPtrs to hold the child items, and fixed length calculation. (dumpBackForwardList): Use a Vector of COMPtrs to hold the items so that they are retained properly. (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (jsValueToWString): (queueLoadCallback): (queueScriptCallback):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: (LoadItem::invoke): (ScriptItem::invoke):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script):

7:50 PM Changeset in webkit [20965] by oliver

2 edits in trunk/WebKit

2007-04-19 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/4960912> -- REGRESSION: Content-Disposition:
filename is ignored for drag-and-drop.

WebView/WebResource.mm: (-[WebResource _fileWrapperRepresentation]): When creating the NSFileWrapper check the response for a preferred filename, rather than just blindly hoping for the best.

7:09 PM Changeset in webkit [20964] by bdash

2 edits in trunk/WebCore

2007-04-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13403 REGRESSION (r18875-r18899): Can no longer type into search form field after searching and then clicking "back"

The problem was that the page was loaded from the page cache with a subtree
marked for layout and the layout timer stopped (having been stopped when the
page entered the page cache). FrameView::needsLayout() was returning false
which prevented the pending layout from completing.

page/FrameView.cpp: (WebCore::FrameView::clear): Removed the call to stop the layout timer, since reset() does that already. (WebCore::FrameView::needsLayout): Changed to return true if there's a subtree pending relayout.

7:08 PM Changeset in webkit [20963] by bdash

78 edits
1 add
2 deletes in trunk/LayoutTests

2007-04-19 Mitz Pettel <mitz@webkit.org>

Rubber-stamped by Adam.

http://bugs.webkit.org/show_bug.cgi?id=13412 Replace abe.jpg with a PNG file

editing/abe.jpg: Removed.
editing/deleting/4866671.html:
editing/deleting/delete-3608462-fix.html:
editing/deleting/delete-image-001.html:
editing/deleting/delete-image-002.html:
editing/deleting/delete-image-003.html:
editing/deleting/delete-image-004.html:
editing/execCommand/5080333-1-expected.checksum:
editing/execCommand/5080333-1-expected.png:
editing/execCommand/5080333-1.html:
editing/execCommand/5080333-2-expected.checksum:
editing/execCommand/5080333-2-expected.png:
editing/execCommand/5080333-2.html:
editing/execCommand/createLink-expected.txt:
editing/execCommand/createLink.html:
editing/execCommand/insertImage-expected.checksum:
editing/execCommand/insertImage-expected.png:
editing/execCommand/insertImage.html:
editing/execCommand/unlink-expected.txt:
editing/execCommand/unlink.html:
editing/inserting/12882.html:
editing/inserting/typing-around-image-001.html:
editing/pasteboard/4641033-expected.checksum:
editing/pasteboard/4641033-expected.png:
editing/pasteboard/4641033.html:
editing/pasteboard/4947130-expected.checksum:
editing/pasteboard/4947130-expected.png:
editing/pasteboard/4947130.html:
editing/pasteboard/4989774-expected.checksum:
editing/pasteboard/4989774-expected.png:
editing/pasteboard/4989774.html:
editing/pasteboard/copy-standalone-image.html:
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
editing/pasteboard/drag-selected-image-to-contenteditable.html:
editing/pasteboard/styled-element-markup-expected.checksum:
editing/pasteboard/styled-element-markup-expected.png:
editing/pasteboard/styled-element-markup.html:
editing/resources/abe.jpg: Removed.
editing/resources/abe.png: Added.
editing/selection/4402375-expected.checksum:
editing/selection/4402375-expected.png:
editing/selection/4402375.html:
editing/selection/4932260-1-expected.checksum:
editing/selection/4932260-1-expected.png:
editing/selection/4932260-1.html:
editing/selection/4932260-2-expected.checksum:
editing/selection/4932260-2-expected.png:
editing/selection/4932260-2.html:
editing/selection/4932260-3-expected.checksum:
editing/selection/4932260-3-expected.png:
editing/selection/4932260-3.html:
editing/selection/drag-to-contenteditable-iframe-expected.checksum:
editing/selection/drag-to-contenteditable-iframe-expected.png:
editing/selection/drag-to-contenteditable-iframe.html:
editing/selection/extend-by-character-002-expected.checksum:
editing/selection/extend-by-character-002-expected.png:
editing/selection/extend-by-character-002.html:
editing/selection/extend-by-character-004-expected.checksum:
editing/selection/extend-by-character-004-expected.png:
editing/selection/extend-by-character-004.html:
editing/selection/image-before-linebreak-expected.checksum:
editing/selection/image-before-linebreak-expected.png:
editing/selection/image-before-linebreak.html:
editing/selection/legal-positions.html:
editing/selection/move-by-character-002-expected.checksum:
editing/selection/move-by-character-002-expected.png:
editing/selection/move-by-character-002.html:
editing/selection/move-by-character-004-expected.checksum:
editing/selection/move-by-character-004-expected.png:
editing/selection/move-by-character-004.html:
editing/selection/replaced-boundaries-1-expected.checksum:
editing/selection/replaced-boundaries-1-expected.png:
editing/selection/replaced-boundaries-1.html:
editing/selection/replaced-boundaries-2-expected.checksum:
editing/selection/replaced-boundaries-2-expected.png:
editing/selection/replaced-boundaries-2.html:

6:53 PM Changeset in webkit [20962] by justing

8 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element

editing/deleting/5144139-2-expected.checksum: Added.
editing/deleting/5144139-2-expected.png: Added.
editing/deleting/5144139-2-expected.txt: Added.
editing/deleting/5144139-2.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element

The fact that the br was being inserted at a bad position
(a non-editable position and one inside a table instead of
before it) was fixed in the previous checkin. This change
stops us from inserting a br at all, to fix the bug.

After a delete, we need a placeholder if the selection
started at the start of a paragraph and ended at the end
of a paragraph. But not if it starts just before a table
and ends inside that table. We need placeholders to hold
open emptied out table cells, but that is handled separately.

Also, moved lineBreakExistsAtPosition to htmlediting.cpp
so that it can be used in more places.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/htmlediting.cpp: (WebCore::lineBreakExistsAtPosition):
editing/htmlediting.h:

6:10 PM Changeset in webkit [23321] by sfalken

3 edits in branches/WindowsMerge/WebKitTools

2007-04-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Eliminate more ATL use (CComSafeArray).

In one place, we were using SafeArray for something that was better served
by WTF::Vector. I added WTF to the vcproj as part of this patch.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpHistoryItem): (dumpBackForwardList):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

5:49 PM Changeset in webkit [20961] by sfalken

1 copy in tags/Safari-522.6.2b

New tag.

5:08 PM Changeset in webkit [20960] by justing

13 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/5144139-1-expected.checksum: Added.
editing/execCommand/5144139-1-expected.png: Added.
editing/execCommand/5144139-1-expected.txt: Added.
editing/execCommand/5144139-1.html: Added.

WebCore:

Reviewed by harrison

Fixes some issues found while investigating:
<rdar://problem/5144139> On delete, <BR> inserted into non-editable ToDo <TABLE> element

Move the code to handle inserting content before/after
tables for [table, 0/max] to insertNodeAt, so that
all insertions get it, not just some.
Changed insertNodeAt to take in a position instead of a
node and an offset.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If paragrahStart.node() is an atomic node, insertNodeAt can handle insertion, we don't need to special case it. (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
editing/CompositeEditCommand.h:
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed some dead code that handled insertion at non-editable positions. (WebCore::InsertTextCommand::insertTab):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
editing/ReplaceSelectionCommand.h:

3:35 PM Changeset in webkit [20959] by andrew

7 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13336 REGRESSION (r20646): editing/execCommand/hilitecolor.html crashes under guardMalloc

Avoid calling selectionRect() and selectionGapRects() on a renderer that needs
layout.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects):
rendering/RenderBlock.h: (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
rendering/RenderObject.h: (WebCore::RenderObject::SelectionInfo::SelectionInfo):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

1:27 PM Changeset in webkit [20958] by justing

7 edits
12 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

Tests the change to pushAnchorElementDown, where we remove
the anchor element that has had copies of it pushed down:

editing/execCommand/5142012-1-expected.checksum: Added.
editing/execCommand/5142012-1-expected.png: Added.
editing/execCommand/5142012-1-expected.txt: Added.
editing/execCommand/5142012-1.html: Added.

Demonstrates the crash (fixed by adding nil-checks
to moveParagraphs):

editing/execCommand/5142012-2-expected.checksum: Added.
editing/execCommand/5142012-2-expected.png: Added.
editing/execCommand/5142012-2-expected.txt: Added.
editing/execCommand/5142012-2.html: Added.

Tests the changes to positionAvoidingSpecialElementBoundary,
where we push down anchors before we avoid them so that
we don't also avoid structural elements like lists and paragraphs:

editing/execCommand/5142012-3-expected.checksum: Added.
editing/execCommand/5142012-3-expected.png: Added.
editing/execCommand/5142012-3-expected.txt: Added.
editing/execCommand/5142012-3.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

List creation uses moveParagraphs to push content into list items.
Its fragment creation (using createMarkup) incorrectly uses regular
spaces instead of nbsps for spaces that were rendered (11475), which
causes spaces to be collapsed during the move operation. This results
in a call to rangeFromLocationAndLength with a location past the end
of the document. We use the result from rangeFromLocationAndLength
(null) and crash.

Also when moveParagraphs tries to push content into a list item surrounded
by an anchor, it fails because positionAvoidingSpecialElementBoundary avoids
the anchor, which also avoids the list item. This was fixed by pushing
down anchors before avoiding them.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::pushAnchorElementDown): Remove the old anchor after we push down clones of it, this is what callers expect. (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown): Call the new enclosingAnchorElement, that takes in a position instead of a node. (WebCore::CompositeEditCommand::moveParagraphs): If spaces collapsed as a result of the move, rangeFromLocationAndLength can return null, bail and don't try to preserve the selection in that case. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Moved from htmlediting.cpp. Make sure anchors are pushed down before avoiding them so that we don't also avoid structural elements like lists and blocks.
editing/CompositeEditCommand.h:
editing/TypingCommand.cpp: Moved isFirst/LastPositionBefore/AfterTable to htmlediting.cpp.
editing/htmlediting.cpp: Moved positionAvoidingSpecialElementBoundary so that it could call pushAnchorElementDown. (WebCore::isFirstPositionAfterTable): Moved here. (WebCore::isLastPositionBeforeTable): Moved here. (WebCore::enclosingAnchorElement): Moved here. (WebCore::enclosingListChild): Removed an extraneous space.
editing/htmlediting.h:

12:58 PM Changeset in webkit [20957] by bdakin

21 edits
2 moves
6 adds
6 deletes in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5120889> Sized table cells w/borders not
drawn to correct size

When table cells have children with %-height, the cells were
incorrectly shrinking down to be the size of the child. This
exposed another problem with replaced children and sizing.

rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): The exposed problem. Subtract our borders and padding in the auto or percent table cell containing block case.
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): When our children can flex, do not always set the cellTopExtra and cellBottomExtra to 0! That is bad! We should do the same as the non-flex case.

Layout Tests:

Reviewed by Hyatt.

Series of new/rearranged results after fix for <rdar://problem/
5120889> Sized table cells w/borders not drawn to correct size

These tests are different by tiny, barely noticeable amounts. The
new results are more correct. We didn't catch the problem before
because it was so subtle here:

fast/replaced/width100percent-expected.txt:
fast/table/003-expected.checksum:
fast/table/003-expected.png:
fast/table/003-expected.txt:

This is the test that exposed the other problem with replaced
children. Now we fit snugly inside the border on the bottom, which
is different than Firefox, but seems right.

tables/mozilla/bugs/bug131020-expected.checksum:
tables/mozilla/bugs/bug131020-expected.png:
tables/mozilla/bugs/bug131020-expected.txt:

This test actually always failed and was incorrectly filed as a
success. Moving to failures.

tables/mozilla/bugs/bug137388-2-expected.checksum: Removed.
tables/mozilla/bugs/bug137388-2-expected.png: Removed.
tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
tables/mozilla/bugs/bug137388-2.html: Removed.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Added.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Added.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Added.

This test was actually wrong before, and now it is right!

tables/mozilla/bugs/bug149275-2-expected.checksum:
tables/mozilla/bugs/bug149275-2-expected.png:
tables/mozilla/bugs/bug149275-2-expected.txt:

This was a failing test that now passes. YAY!

tables/mozilla/bugs/bug18440-expected.checksum: Added.
tables/mozilla/bugs/bug18440-expected.png: Added.
tables/mozilla/bugs/bug18440-expected.txt: Added.

tables/mozilla_expected_failures/bugs/bug18440-expected.checksum: Removed.
- tables/mozilla_expected_failures/bugs/bug18440-expected.png: Removed.
- tables/mozilla_expected_failures/bugs/bug18440-expected.txt: Removed.
- tables/mozilla_expected_failures/bugs/bug18440.html: Removed.

This was slightly wrong before and is now correct.

tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug30692-expected.txt:

Still wrong, but slightly more correct.

tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

So much closer to being correct!! But still slightly wrong.

tables/mozilla_expected_failures/bugs/bug19526-expected.txt:

12:57 PM Changeset in webkit [20956] by thatcher

6 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Address review comments Darin made.

12:37 PM Changeset in webkit [20955] by brmorris

2 edits in S60/branches/3.1m/WebKit

brad, reviewed by zalan

DESC: add ContentAccess namespace to StaticImageDecoder.cpp

BrowserCore/Renderers/src/StaticImageDecoder.cpp:

12:19 PM Changeset in webkit [20954] by andersca

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements

fast/dom/HTMLImageElement/image-natural-width-height-expected.txt: Added.
fast/dom/HTMLImageElement/image-natural-width-height.html: Added.

WebCore:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements

html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::naturalWidth): (WebCore::HTMLImageElement::naturalHeight):
html/HTMLImageElement.h:
html/HTMLImageElement.idl:

11:56 AM Changeset in webkit [20953] by pyeh

2 edits in trunk/WebCore

review suggestion for rdar://5145011 code change

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): return early if value attribute is not supported by the attachment view.

11:21 AM Changeset in webkit [20952] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5145011> Allow attachment view of web object to handle accessibility actions

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Only allow asking the attachmentView for value if attachmentView supports this value attribute (-[WebCoreAXObject title]): (-[WebCoreAXObject accessibilityAttributeNames]): Should not return that long list of unrelated attributes for attachmentView. (-[WebCoreAXObject accessibilityActionNames]): (-[WebCoreAXObject accessibilityPerformAction:]): Allow attachmentView a chance to handle actions. (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Should not return that long list of unrelated attributes for attachmentView.

9:47 AM Changeset in webkit [20951] by andersca

3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

WebView/WebFrame.mm: (-[WebFrame DOMDocument]):

8:24 AM GtkAPIProposal edited by bdash@webkit.org

(diff)

8:20 AM GtkAPIProposal created by christian@twotoasts.de

7:47 AM Changeset in webkit [20950] by weinig

532 edits in trunk

LayoutTests:

Reviewed by Hyatt

updated results for http://bugs.webkit.org/show_bug.cgi?id=13291 REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

editing/deleting/4845371-expected.txt:
editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
editing/deleting/delete-3608430-fix-expected.txt:
editing/deleting/delete-3608445-fix-expected.txt:
editing/deleting/delete-3608462-fix-expected.txt:
editing/deleting/delete-3775172-fix-expected.txt:
editing/deleting/delete-3800834-fix-expected.txt:
editing/deleting/delete-3857753-fix-expected.txt:
editing/deleting/delete-3865854-fix-expected.txt:
editing/deleting/delete-3928305-fix-expected.txt:
editing/deleting/delete-3959464-fix-expected.txt:
editing/deleting/delete-4038408-fix-expected.txt:
editing/deleting/delete-4083333-fix-expected.txt:
editing/deleting/delete-after-span-ws-001-expected.txt:
editing/deleting/delete-after-span-ws-002-expected.txt:
editing/deleting/delete-after-span-ws-003-expected.txt:
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-and-undo-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
editing/deleting/delete-at-start-or-end-expected.txt:
editing/deleting/delete-block-contents-001-expected.txt:
editing/deleting/delete-block-contents-002-expected.txt:
editing/deleting/delete-block-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-001-expected.txt:
editing/deleting/delete-block-merge-contents-002-expected.txt:
editing/deleting/delete-block-merge-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-004-expected.txt:
editing/deleting/delete-block-merge-contents-005-expected.txt:
editing/deleting/delete-block-merge-contents-006-expected.txt:
editing/deleting/delete-block-merge-contents-007-expected.txt:
editing/deleting/delete-block-merge-contents-008-expected.txt:
editing/deleting/delete-block-merge-contents-009-expected.txt:
editing/deleting/delete-block-merge-contents-010-expected.txt:
editing/deleting/delete-block-merge-contents-011-expected.txt:
editing/deleting/delete-block-merge-contents-012-expected.txt:
editing/deleting/delete-block-merge-contents-013-expected.txt:
editing/deleting/delete-block-merge-contents-014-expected.txt:
editing/deleting/delete-block-merge-contents-015-expected.txt:
editing/deleting/delete-block-merge-contents-016-expected.txt:
editing/deleting/delete-block-merge-contents-017-expected.txt:
editing/deleting/delete-block-merge-contents-018-expected.txt:
editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-020-expected.txt:
editing/deleting/delete-block-merge-contents-021-expected.txt:
editing/deleting/delete-block-merge-contents-022-expected.txt:
editing/deleting/delete-block-merge-contents-023-expected.txt:
editing/deleting/delete-block-merge-contents-024-expected.txt:
editing/deleting/delete-block-table-expected.txt:
editing/deleting/delete-br-001-expected.txt:
editing/deleting/delete-br-002-expected.txt:
editing/deleting/delete-br-003-expected.txt:
editing/deleting/delete-br-004-expected.txt:
editing/deleting/delete-br-005-expected.txt:
editing/deleting/delete-br-006-expected.txt:
editing/deleting/delete-br-007-expected.txt:
editing/deleting/delete-br-008-expected.txt:
editing/deleting/delete-br-009-expected.txt:
editing/deleting/delete-br-010-expected.txt:
editing/deleting/delete-br-011-expected.txt:
editing/deleting/delete-br-012-expected.txt:
editing/deleting/delete-by-word-001-expected.txt:
editing/deleting/delete-by-word-002-expected.txt:
editing/deleting/delete-character-001-expected.txt:
editing/deleting/delete-contiguous-ws-001-expected.txt:
editing/deleting/delete-first-list-item-expected.txt:
editing/deleting/delete-hr-expected.txt:
editing/deleting/delete-image-001-expected.txt:
editing/deleting/delete-image-002-expected.txt:
editing/deleting/delete-image-003-expected.txt:
editing/deleting/delete-image-004-expected.txt:
editing/deleting/delete-leading-ws-001-expected.txt:
editing/deleting/delete-line-001-expected.txt:
editing/deleting/delete-line-002-expected.txt:
editing/deleting/delete-line-003-expected.txt:
editing/deleting/delete-line-004-expected.txt:
editing/deleting/delete-line-005-expected.txt:
editing/deleting/delete-line-006-expected.txt:
editing/deleting/delete-line-007-expected.txt:
editing/deleting/delete-line-008-expected.txt:
editing/deleting/delete-line-009-expected.txt:
editing/deleting/delete-line-010-expected.txt:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:
editing/deleting/delete-line-013-expected.txt:
editing/deleting/delete-line-014-expected.txt:
editing/deleting/delete-line-015-expected.txt:
editing/deleting/delete-line-016-expected.txt:
editing/deleting/delete-line-017-expected.txt:
editing/deleting/delete-line-end-ws-001-expected.txt:
editing/deleting/delete-line-end-ws-002-expected.txt:
editing/deleting/delete-link-1-expected.txt:
editing/deleting/delete-listitem-001-expected.txt:
editing/deleting/delete-listitem-002-expected.txt:
editing/deleting/delete-mixed-editable-content-001-expected.txt:
editing/deleting/delete-select-all-001-expected.txt:
editing/deleting/delete-select-all-002-expected.txt:
editing/deleting/delete-select-all-003-expected.txt:
editing/deleting/delete-selection-001-expected.txt:
editing/deleting/delete-tab-001-expected.txt:
editing/deleting/delete-tab-002-expected.txt:
editing/deleting/delete-tab-003-expected.txt:
editing/deleting/delete-tab-004-expected.txt:
editing/deleting/delete-to-end-of-paragraph-expected.txt:
editing/deleting/delete-to-select-table-expected.txt:
editing/deleting/delete-trailing-ws-001-expected.txt:
editing/deleting/delete-trailing-ws-002-expected.txt:
editing/deleting/delete-ws-fixup-001-expected.txt:
editing/deleting/delete-ws-fixup-002-expected.txt:
editing/deleting/delete-ws-fixup-003-expected.txt:
editing/deleting/delete-ws-fixup-004-expected.txt:
editing/deleting/forward-delete-expected.txt:
editing/deleting/list-item-1-expected.txt:
editing/deleting/merge-different-styles-expected.txt:
editing/deleting/merge-endOfParagraph-expected.txt:
editing/deleting/merge-into-empty-block-1-expected.txt:
editing/deleting/merge-into-empty-block-2-expected.txt:
editing/deleting/merge-no-br-expected.txt:
editing/deleting/merge-unrendered-space-expected.txt:
editing/deleting/paragraph-in-preserveNewline-expected.txt:
editing/deleting/pruning-after-merge-1-expected.txt:
editing/deleting/pruning-after-merge-2-expected.txt:
editing/deleting/smart-delete-001-expected.txt:
editing/deleting/smart-delete-002-expected.txt:
editing/deleting/smart-delete-003-expected.txt:
editing/deleting/smart-delete-004-expected.txt:
editing/deleting/table-cells-expected.txt:
editing/deleting/transpose-empty-expected.txt:
editing/deleting/whitespace-pre-1-expected.txt:
editing/execCommand/4641880-1-expected.txt:
editing/execCommand/4641880-2-expected.txt:
editing/execCommand/boldSelection-expected.txt:
editing/execCommand/create-list-from-range-selection-expected.txt:
editing/execCommand/create-list-with-hr-expected.txt:
editing/execCommand/createLink-expected.txt:
editing/execCommand/format-block-expected.txt:
editing/execCommand/format-block-from-range-selection-expected.txt:
editing/execCommand/format-block-with-braces-expected.txt:
editing/execCommand/format-block-with-trailing-br-expected.txt:
editing/execCommand/hilitecolor-expected.txt:
editing/execCommand/indent-empty-root-expected.txt:
editing/execCommand/indent-list-item-expected.txt:
editing/execCommand/indent-selection-expected.txt:
editing/execCommand/insert-list-and-stitch-expected.txt:
editing/execCommand/insert-list-with-id-expected.txt:
editing/execCommand/insertHTML-expected.txt:
editing/execCommand/insertHorizontalRule-expected.txt:
editing/execCommand/insertImage-expected.txt:
editing/execCommand/italicizeByCharacter-expected.txt:
editing/execCommand/modifyForeColorByCharacter-expected.txt:
editing/execCommand/nsresponder-indent-expected.txt:
editing/execCommand/nsresponder-outdent-expected.txt:
editing/execCommand/outdent-selection-expected.txt:
editing/execCommand/print-expected.txt:
editing/execCommand/queryCommandState-01-expected.txt:
editing/execCommand/remove-formatting-2-expected.txt:
editing/execCommand/remove-formatting-expected.txt:
editing/execCommand/remove-list-from-range-selection-expected.txt:
editing/execCommand/remove-list-item-1-expected.txt:
editing/execCommand/remove-list-items-expected.txt:
editing/execCommand/selectAll-expected.txt:
editing/execCommand/strikethroughSelection-expected.txt:
editing/execCommand/switch-list-type-expected.txt:
editing/execCommand/unlink-expected.txt:
editing/input/firstrectforcharacterrange-plain-expected.txt:
editing/input/firstrectforcharacterrange-styled-expected.txt:
editing/input/wrapped-line-char-rect-expected.txt:
editing/inserting/4278698-expected.txt:
editing/inserting/before-after-input-element-expected.txt:
editing/inserting/editable-html-element-expected.txt:
editing/inserting/editing-empty-divs-expected.txt:
editing/inserting/insert-3654864-fix-expected.txt:
editing/inserting/insert-3659587-fix-expected.txt:
editing/inserting/insert-3775316-fix-expected.txt:
editing/inserting/insert-3778059-fix-expected.txt:
editing/inserting/insert-3786362-fix-expected.txt:
editing/inserting/insert-3800346-fix-expected.txt:
editing/inserting/insert-3851164-fix-expected.txt:
editing/inserting/insert-3907422-fix-expected.txt:
editing/inserting/insert-after-delete-001-expected.txt:
editing/inserting/insert-at-end-01-expected.txt:
editing/inserting/insert-at-end-02-expected.txt:
editing/inserting/insert-before-link-1-expected.txt:
editing/inserting/insert-br-001-expected.txt:
editing/inserting/insert-br-002-expected.txt:
editing/inserting/insert-br-003-expected.txt:
editing/inserting/insert-br-004-expected.txt:
editing/inserting/insert-br-005-expected.txt:
editing/inserting/insert-br-006-expected.txt:
editing/inserting/insert-br-007-expected.txt:
editing/inserting/insert-br-008-expected.txt:
editing/inserting/insert-br-009-expected.txt:
editing/inserting/insert-br-at-tabspan-001-expected.txt:
editing/inserting/insert-br-at-tabspan-002-expected.txt:
editing/inserting/insert-br-at-tabspan-003-expected.txt:
editing/inserting/insert-br-quoted-001-expected.txt:
editing/inserting/insert-br-quoted-002-expected.txt:
editing/inserting/insert-br-quoted-003-expected.txt:
editing/inserting/insert-br-quoted-004-expected.txt:
editing/inserting/insert-br-quoted-005-expected.txt:
editing/inserting/insert-br-quoted-006-expected.txt:
editing/inserting/insert-div-001-expected.txt:
editing/inserting/insert-div-002-expected.txt:
editing/inserting/insert-div-003-expected.txt:
editing/inserting/insert-div-004-expected.txt:
editing/inserting/insert-div-005-expected.txt:
editing/inserting/insert-div-006-expected.txt:
editing/inserting/insert-div-007-expected.txt:
editing/inserting/insert-div-008-expected.txt:
editing/inserting/insert-div-009-expected.txt:
editing/inserting/insert-div-010-expected.txt:
editing/inserting/insert-div-011-expected.txt:
editing/inserting/insert-div-012-expected.txt:
editing/inserting/insert-div-013-expected.txt:
editing/inserting/insert-div-014-expected.txt:
editing/inserting/insert-div-015-expected.txt:
editing/inserting/insert-div-016-expected.txt:
editing/inserting/insert-div-017-expected.txt:
editing/inserting/insert-div-018-expected.txt:
editing/inserting/insert-div-019-expected.txt:
editing/inserting/insert-div-020-expected.txt:
editing/inserting/insert-div-021-expected.txt:
editing/inserting/insert-div-022-expected.txt:
editing/inserting/insert-div-023-expected.txt:
editing/inserting/insert-div-024-expected.txt:
editing/inserting/insert-div-025-expected.txt:
editing/inserting/insert-div-026-expected.txt:
editing/inserting/insert-div-027-expected.txt:
editing/inserting/insert-paragraph-01-expected.txt:
editing/inserting/insert-paragraph-02-expected.txt:
editing/inserting/insert-paragraph-03-expected.txt:
editing/inserting/insert-paragraph-04-expected.txt:
editing/inserting/insert-space-in-empty-doc-expected.txt:
editing/inserting/insert-tab-001-expected.txt:
editing/inserting/insert-tab-002-expected.txt:
editing/inserting/insert-tab-003-expected.txt:
editing/inserting/insert-tab-004-expected.txt:
editing/inserting/insert-text-at-tabspan-001-expected.txt:
editing/inserting/insert-text-at-tabspan-002-expected.txt:
editing/inserting/insert-text-at-tabspan-003-expected.txt:
editing/inserting/insert-text-with-newlines-expected.txt:
editing/inserting/line-break-expected.txt:
editing/inserting/multiple-lines-selected-expected.txt:
editing/inserting/paragraph-separator-01-expected.txt:
editing/inserting/paragraph-separator-02-expected.txt:
editing/inserting/paragraph-separator-03-expected.txt:
editing/inserting/paragraph-separator-in-table-1-expected.txt:
editing/inserting/paragraph-separator-in-table-2-expected.txt:
editing/inserting/redo-expected.txt:
editing/inserting/return-key-with-selection-001-expected.txt:
editing/inserting/return-key-with-selection-002-expected.txt:
editing/inserting/return-key-with-selection-003-expected.txt:
editing/inserting/typing-001-expected.txt:
editing/inserting/typing-002-expected.txt:
editing/inserting/typing-003-expected.txt:
editing/inserting/typing-around-br-001-expected.txt:
editing/inserting/typing-around-image-001-expected.txt:
editing/pasteboard/3976872-expected.txt:
editing/pasteboard/4076267-2-expected.txt:
editing/pasteboard/4076267-3-expected.txt:
editing/pasteboard/4076267-expected.txt:
editing/pasteboard/4242293-1-expected.txt:
editing/pasteboard/4242293-expected.txt:
editing/pasteboard/4631972-expected.txt:
editing/pasteboard/4641033-expected.txt:
editing/pasteboard/4700297-expected.txt:
editing/pasteboard/4744008-expected.txt:
editing/pasteboard/8145-1-expected.txt:
editing/pasteboard/8145-2-expected.txt:
editing/pasteboard/8145-3-expected.txt:
editing/pasteboard/bad-placeholder-expected.txt:
editing/pasteboard/block-wrappers-necessary-expected.txt:
editing/pasteboard/copy-in-password-field-expected.txt:
editing/pasteboard/copy-standalone-image-expected.txt:
editing/pasteboard/cut-text-001-expected.txt:
editing/pasteboard/displaced-generic-placeholder-expected.txt:
editing/pasteboard/displaced-placeholder-expected.txt:
editing/pasteboard/display-block-on-spans-expected.txt:
editing/pasteboard/drag-drop-modifies-page-expected.txt:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
editing/pasteboard/drop-link-expected.txt:
editing/pasteboard/emacs-cntl-y-001-expected.txt:
editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
editing/pasteboard/interchange-newline-1-expected.txt:
editing/pasteboard/interchange-newline-2-expected.txt:
editing/pasteboard/interchange-newline-3-expected.txt:
editing/pasteboard/interchange-newline-4-expected.txt:
editing/pasteboard/merge-after-delete-1-expected.txt:
editing/pasteboard/merge-after-delete-2-expected.txt:
editing/pasteboard/merge-after-delete-expected.txt:
editing/pasteboard/merge-end-3-expected.txt:
editing/pasteboard/merge-end-4-expected.txt:
editing/pasteboard/merge-end-5-expected.txt:
editing/pasteboard/merge-end-blockquote-expected.txt:
editing/pasteboard/merge-end-borders-expected.txt:
editing/pasteboard/merge-end-list-expected.txt:
editing/pasteboard/merge-end-table-expected.txt:
editing/pasteboard/merge-start-blockquote-expected.txt:
editing/pasteboard/merge-start-list-expected.txt:
editing/pasteboard/nested-blocks-with-text-area-expected.txt:
editing/pasteboard/nested-blocks-with-text-field-expected.txt:
editing/pasteboard/paste-4035648-fix-expected.txt:
editing/pasteboard/paste-4038267-fix-expected.txt:
editing/pasteboard/paste-4039777-fix-expected.txt:
editing/pasteboard/paste-RTFD-expected.txt:
editing/pasteboard/paste-TIFF-expected.txt:
editing/pasteboard/paste-line-endings-001-expected.txt:
editing/pasteboard/paste-line-endings-002-expected.txt:
editing/pasteboard/paste-line-endings-003-expected.txt:
editing/pasteboard/paste-line-endings-004-expected.txt:
editing/pasteboard/paste-line-endings-005-expected.txt:
editing/pasteboard/paste-line-endings-006-expected.txt:
editing/pasteboard/paste-line-endings-007-expected.txt:
editing/pasteboard/paste-line-endings-008-expected.txt:
editing/pasteboard/paste-line-endings-009-expected.txt:
editing/pasteboard/paste-line-endings-010-expected.txt:
editing/pasteboard/paste-list-001-expected.txt:
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-match-style-002-expected.txt:
editing/pasteboard/paste-pre-001-expected.txt:
editing/pasteboard/paste-pre-002-expected.txt:
editing/pasteboard/paste-table-001-expected.txt:
editing/pasteboard/paste-table-002-expected.txt:
editing/pasteboard/paste-table-003-expected.txt:
editing/pasteboard/paste-text-001-expected.txt:
editing/pasteboard/paste-text-002-expected.txt:
editing/pasteboard/paste-text-003-expected.txt:
editing/pasteboard/paste-text-004-expected.txt:
editing/pasteboard/paste-text-005-expected.txt:
editing/pasteboard/paste-text-006-expected.txt:
editing/pasteboard/paste-text-007-expected.txt:
editing/pasteboard/paste-text-008-expected.txt:
editing/pasteboard/paste-text-009-expected.txt:
editing/pasteboard/paste-text-010-expected.txt:
editing/pasteboard/paste-text-011-expected.txt:
editing/pasteboard/paste-text-012-expected.txt:
editing/pasteboard/paste-text-013-expected.txt:
editing/pasteboard/paste-text-014-expected.txt:
editing/pasteboard/paste-text-015-expected.txt:
editing/pasteboard/paste-text-016-expected.txt:
editing/pasteboard/paste-text-017-expected.txt:
editing/pasteboard/paste-text-018-expected.txt:
editing/pasteboard/paste-text-019-expected.txt:
editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
editing/pasteboard/paste-xml-expected.txt:
editing/pasteboard/pasting-object-expected.txt:
editing/pasteboard/pasting-tabs-expected.txt:
editing/pasteboard/prevent-block-nesting-01-expected.txt:
editing/pasteboard/quirks-mode-br-1-expected.txt:
editing/pasteboard/quirks-mode-br-2-expected.txt:
editing/pasteboard/smart-paste-001-expected.txt:
editing/pasteboard/smart-paste-002-expected.txt:
editing/pasteboard/smart-paste-003-expected.txt:
editing/pasteboard/smart-paste-004-expected.txt:
editing/pasteboard/smart-paste-005-expected.txt:
editing/pasteboard/smart-paste-006-expected.txt:
editing/pasteboard/smart-paste-007-expected.txt:
editing/pasteboard/smart-paste-008-expected.txt:
editing/pasteboard/styled-element-markup-expected.txt:
editing/pasteboard/subframe-dragndrop-1-expected.txt:
editing/pasteboard/testcase-9507-expected.txt:
editing/pasteboard/undoable-fragment-removes-expected.txt:
editing/pasteboard/unrendered-br-expected.txt:
editing/selection/3690703-2-expected.txt:
editing/selection/3690703-expected.txt:
editing/selection/3690719-expected.txt:
editing/selection/4397952-expected.txt:
editing/selection/4932260-1-expected.txt:
editing/selection/4932260-2-expected.txt:
editing/selection/4932260-3-expected.txt:
editing/selection/4947387-expected.txt:
editing/selection/6476-expected.txt:
editing/selection/7152-1-expected.txt:
editing/selection/7152-2-expected.txt:
editing/selection/after-line-wrap-expected.txt:
editing/selection/caret-rtl-2-expected.txt:
editing/selection/caret-rtl-expected.txt:
editing/selection/click-before-and-after-table-expected.txt:
editing/selection/click-start-of-line-expected.txt:
editing/selection/designmode-no-caret-expected.txt:
editing/selection/editable-links-expected.txt:
editing/selection/editable-non-editable-crash-expected.txt:
editing/selection/end-of-document-expected.txt:
editing/selection/expanding-selections-expected.txt:
editing/selection/expanding-selections2-expected.txt:
editing/selection/extend-by-character-001-expected.txt:
editing/selection/extend-by-character-002-expected.txt:
editing/selection/extend-by-character-003-expected.txt:
editing/selection/extend-by-character-004-expected.txt:
editing/selection/extend-by-character-005-expected.txt:
editing/selection/extend-by-character-006-expected.txt:
editing/selection/extend-by-sentence-001-expected.txt:
editing/selection/extend-by-word-001-expected.txt:
editing/selection/extend-by-word-002-expected.txt:
editing/selection/fake-doubleclick-expected.txt:
editing/selection/fake-drag-expected.txt:
editing/selection/iframe-expected.txt:
editing/selection/image-before-linebreak-expected.txt:
editing/selection/inline-table-expected.txt:
editing/selection/leave-requested-block-expected.txt:
editing/selection/mixed-editability-1-expected.txt:
editing/selection/mixed-editability-3-expected.txt:
editing/selection/mixed-editability-4-expected.txt:
editing/selection/mixed-editability-5-expected.txt:
editing/selection/move-3875618-fix-expected.txt:
editing/selection/move-3875641-fix-expected.txt:
editing/selection/move-backwords-by-word-001-expected.txt:
editing/selection/move-between-blocks-no-001-expected.txt:
editing/selection/move-between-blocks-yes-001-expected.txt:
editing/selection/move-by-character-001-expected.txt:
editing/selection/move-by-character-002-expected.txt:
editing/selection/move-by-character-003-expected.txt:
editing/selection/move-by-character-004-expected.txt:
editing/selection/move-by-character-005-expected.txt:
editing/selection/move-by-character-6-expected.txt:
editing/selection/move-by-line-001-expected.txt:
editing/selection/move-by-line-002-expected.txt:
editing/selection/move-by-word-001-expected.txt:
editing/selection/previous-line-position-expected.txt:
editing/selection/replace-selection-1-expected.txt:
editing/selection/replaced-boundaries-1-expected.txt:
editing/selection/replaced-boundaries-2-expected.txt:
editing/selection/replaced-boundaries-3-expected.txt:
editing/selection/select-all-001-expected.txt:
editing/selection/select-all-002-expected.txt:
editing/selection/select-all-003-expected.txt:
editing/selection/select-all-004-expected.txt:
editing/selection/select-all-005-expected.txt:
editing/selection/select-all-006-expected.txt:
editing/selection/select-all-iframe-expected.txt:
editing/selection/select-box-expected.txt:
editing/selection/select-element-paragraph-boundary-expected.txt:
editing/selection/select-missing-image-expected.txt:
editing/selection/selection-3748164-fix-expected.txt:
editing/selection/skip-non-editable-1-expected.txt:
editing/selection/skip-non-editable-2-expected.txt:
editing/selection/table-caret-1-expected.txt:
editing/selection/table-caret-2-expected.txt:
editing/selection/table-caret-3-expected.txt:
editing/selection/triple-click-in-pre-expected.txt:
editing/selection/unrendered-001-expected.txt:
editing/selection/unrendered-002-expected.txt:
editing/selection/unrendered-003-expected.txt:
editing/selection/unrendered-004-expected.txt:
editing/selection/unrendered-005-expected.txt:
editing/selection/unrendered-space-expected.txt:
editing/spelling/spelling-expected.txt:
editing/style/apple-style-editable-mix-expected.txt:
editing/style/block-style-001-expected.txt:
editing/style/block-style-002-expected.txt:
editing/style/block-style-003-expected.txt:
editing/style/block-style-004-expected.txt:
editing/style/block-style-005-expected.txt:
editing/style/block-style-006-expected.txt:
editing/style/block-styles-007-expected.txt:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-005-expected.txt:
editing/style/create-block-for-style-006-expected.txt:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-008-expected.txt:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.txt:
editing/style/designmode-expected.txt:
editing/style/non-inheritable-styles-expected.txt:
editing/style/relative-font-size-change-001-expected.txt:
editing/style/relative-font-size-change-002-expected.txt:
editing/style/relative-font-size-change-003-expected.txt:
editing/style/relative-font-size-change-004-expected.txt:
editing/style/remove-underline-across-paragraph-expected.txt:
editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
editing/style/remove-underline-after-paragraph-expected.txt:
editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
editing/style/remove-underline-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/remove-underline-in-bold-expected.txt:
editing/style/smoosh-styles-001-expected.txt:
editing/style/smoosh-styles-002-expected.txt:
editing/style/smoosh-styles-003-expected.txt:
editing/style/style-3681552-fix-001-expected.txt:
editing/style/style-3681552-fix-002-expected.txt:
editing/style/style-3690704-fix-expected.txt:
editing/style/style-3998892-fix-expected.txt:
editing/style/style-boundary-001-expected.txt:
editing/style/style-boundary-002-expected.txt:
editing/style/style-boundary-003-expected.txt:
editing/style/style-boundary-004-expected.txt:
editing/style/style-boundary-005-expected.txt:
editing/style/table-selection-expected.txt:
editing/style/typing-style-001-expected.txt:
editing/style/typing-style-002-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/style/unbold-in-bold-expected.txt:
editing/style/underline-expected.txt:
editing/undo/4063751-expected.txt:
editing/undo/redo-typing-001-expected.txt:
editing/undo/undo-iframe-location-change-expected.txt:
editing/undo/undo-misspellings-expected.txt:
editing/undo/undo-typing-001-expected.txt:
editing/unsupported-content/list-delete-001-expected.txt:
editing/unsupported-content/list-delete-002-expected.txt:
editing/unsupported-content/list-delete-003-expected.txt:
editing/unsupported-content/list-type-after-expected.txt:
editing/unsupported-content/list-type-before-expected.txt:
editing/unsupported-content/table-delete-001-expected.txt:
editing/unsupported-content/table-delete-002-expected.txt:
editing/unsupported-content/table-delete-003-expected.txt:
editing/unsupported-content/table-type-after-expected.txt:
editing/unsupported-content/table-type-before-expected.txt:
fast/forms/focus-selection-input-expected.txt:

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13291 REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

Covered by editing tests.

dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing() back into here.
dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.

7:02 AM Changeset in webkit [20949] by bdash

3 edits
3 adds in trunk

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function

kjs/array_object.cpp: (ArrayInstance::sort): Save/restore the static variables around calls to qsort to ensure nested calls to ArrayInstance::sort behave correctly.

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function

fast/js/array-sort-reentrance-expected.txt: Added.
fast/js/array-sort-reentrance.html: Added.
fast/js/resources/array-sort-reentrance.js: Added.

6:09 AM Changeset in webkit [20948] by weinig

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=12249 FCKeditor: <hr>, <ul> and <ol> have id="undefined"

editing/execCommand/arguments-combinations-expected.txt: Added.
editing/execCommand/arguments-combinations.html: Added.

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12249 FCKeditor: <hr>, <ul> and <ol> have id="undefined"

Convert undefined and null to a null string for third argument of
execCommand();

Test: editing/execCommand/arguments-combinations.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_binding.cpp: (KJS::valueToStringWithUndefinedOrNullCheck):
bindings/js/kjs_binding.h:
bindings/scripts/CodeGeneratorJS.pm:
dom/Document.idl:

5:58 AM Changeset in webkit [20947] by bdash

1 copy in tags/Safari-4522.5.6/WebKit

New tag (part 2).

5:56 AM Changeset in webkit [20946] by bdash

1 add in tags/Safari-4522.5.6

New tag (part 1).

5:54 AM Changeset in webkit [20945] by bdash

1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

1:53 AM Changeset in webkit [23320] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added a crasher.

1:51 AM Changeset in webkit [20944] by andrew

2 edits in trunk/WebCore

Reviewed by hyatt.

WebCoreSources.bkl: Remove obsolete source file from build.

1:23 AM Changeset in webkit [23319] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added back the test that wouldn't die.

Apr 18, 2007:

10:54 PM Changeset in webkit [23318] by aroben

4 edits in branches/WindowsMerge

LayoutTestsWin:

win/Skipped: Updated.

WebCoreWin:

Reviewed by Oliver.

Added an equality operator to COMPtr.

platform/win/COMPtr.h: (operator==): (operator!=):

9:07 PM Changeset in webkit [20943] by bdash

1 edit in trunk/WebKit/ChangeLog

Add in a missing word.

8:57 PM Changeset in webkit [23317] by beidson

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added a new test I added today that is Mac-only SPI

8:47 PM Changeset in webkit [23316] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added back a test that I shouldn't have removed because it fails.

8:21 PM Changeset in webkit [23315] by aroben

3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Make development builds use the same CLSIDs as archive builds, and get
rid of the now-unused set of CLSIDs.

Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not doing a production build.
WebKit.vcproj/Interfaces.vcproj: Don't define ARCHIVE_BUILD because it's not used anymore.

8:09 PM Changeset in webkit [20942] by bdash

2 edits
1 copy in branches/Safari-522/WebKit

Merge r20941.

8:02 PM Changeset in webkit [20941] by bdash

2 edits
1 add in trunk/WebKit

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver and Adam.

<rdar://problem/5141290> WebAssertions.h is still needed some internal clients.

Misc/WebAssertions.h: Added.
WebKit.xcodeproj/project.pbxproj:

7:27 PM Changeset in webkit [23314] by aroben

2 edits in branches/WindowsMerge/WebKitTools

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added a Debug_Internal configuration.

6:07 PM Changeset in webkit [23313] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Commented out a comment and removed a test that passes.

5:59 PM Changeset in webkit [23312] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-04-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Allow images to be dragged from page and dropped as files.
This is the remainder of the fix for <rdar://problem/5035948>

-- Dragging image or link from boomer doesn't create webloc

or image file.

platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Make name generation nicer, and better match Firefox

(WebCore::createGlobalURLContent):

rename function

(WebCore::createGlobalImageFileContent):

Copies image data into global store

(WebCore::createGlobalUrlFileDescriptor):

Rename function
Updated for parameter change on filesystemPathFromUrlOrTitle

(WebCore::createGlobalImageFileDescriptor):

Set up file descriptor for image drag

(WebCore::getCachedImage):

Helper function

(WebCore::writeImageToDataObject):

Attempts to build and insert data for image->file drag

(WebCore::ClipboardWin::declareAndWriteDragImage):

Attempts to build and insert data for image->file drag

(WebCore::ClipboardWin::writeURL):

Add call to imageDataToDataObject

5:57 PM Changeset in webkit [20940] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20513.

5:48 PM Changeset in webkit [20939] by bdash

4 edits in trunk/WebCore

2007-04-18 Alp Toker <alp@atoker.com>

Gdk build fix. Reviewed by Sam Weinig.

Track changes to make GdkLauncher work again.

WebCoreSources.bkl:
platform/gdk/ChromeClientGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (Editor::markBadGrammar):

5:42 PM Changeset in webkit [20938] by beidson

1 edit in trunk/WebCore/platform/graphics/svg/SVGImageEmptyClients.h

Removed unintentional garbage left after an #endif in my previous patch

5:39 PM Changeset in webkit [20937] by beidson

15 edits
3 adds in trunk

LayoutTests:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
http/tests/misc/willCacheResponse-delegate-callback.html: Added.

WebCore:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

WebCore.xcodeproj/project.pbxproj: Added ResourceLoaderMac.mm

loader/FrameLoaderClient.h: Add the willCacheResponse SPI for WebKit to implement

loader/ResourceLoader.h:
loader/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoader::willCacheResponse): Return the new cachedResponse from the client

platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::willCacheResponse): Stub

platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willCacheResponse): Return the new cachedResponse from the client

platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Call to get the new cachedURLResponse before calling for the cache policy

WebKit:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willCacheResponse): Call [WebResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:];

WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): Pull out the willCacheResponse impl

WebView/WebViewPrivate.h: Add WebResourceLoadDelegatePrivate category for this new SPI

WebKitTools:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): Add the willCacheResponse delegate call

5:33 PM Changeset in webkit [20936] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13375 REGRESSION (r20901): failing fast/overflow/scrollRevealButton.html

dom/Document.cpp: (WebCore::Document::updateLayout): If we have a parent frame, update its layout too.

4:59 PM Changeset in webkit [20935] by aroben

2 edits in trunk/WebKitTools

Reviewed by David Kilzer.

Scripts/webkitdirs.pm: (sub setConfiguration): Added an optional argument to set the configuration instead of parsing it from ARGV.

4:35 PM Changeset in webkit [23311] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Fixed some file extensions and removed duplicated tests.

3:46 PM Changeset in webkit [23310] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Continued sorting and filing bugs, and added new failures that may be related to the switch to Release on the build bot. Because file extensions are unknown in the results page, I guessed that these would all be .html and failures I will investigate after the new list is generated.

3:25 PM Changeset in webkit [23309] by aroben

3 edits
1 add in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Use different ProgIDs for production builds.

ProgIDMacros.h: Added.
WebKit.vcproj/WebKit.vcproj: Defined the BUILDBOT macro and added a new header which is copied in the post-build step.
WebKitDLL.cpp: Macro-ized the declaration of the registry keys to install.

2:11 PM Changeset in webkit [20934] by sullivan

2 edits in trunk/WebKit

Reviewed by Adam

fixed <rdar://problem/5103009> REGRESSION: Activity window shows blank name for untitled pages

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation title]): return nil for empty string, to match old behavior

1:30 PM Changeset in webkit [23308] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added some tests and removed some as a test to see if they are really failing.

1:05 PM Changeset in webkit [20933] by kmccullo

3 edits
2 deletes in trunk/LayoutTests

Reviewed by AP.

Consolidated encoding tests.

fast/encoding/char-decoding-expected.txt:
fast/encoding/char-decoding.html:
fast/encoding/charset-x-nextstep-expected.txt: Removed.
fast/encoding/charset-x-nextstep.html: Removed.

8:37 AM BuildingQtOnLinux edited by bdash@webkit.org

Add info about some common build errors encountered while … (diff)

7:55 AM Changeset in webkit [20932] by bdash

4 edits in trunk/WebCore

2007-04-18 Alp Toker <alp@atoker.com>

Gdk build fix. Reviewed by Mark.

loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
loader/gdk/FrameLoaderClientGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (CachedPage::close): Track PageCache to CachedPage refactoring.

Apr 17, 2007:

11:30 PM Changeset in webkit [23307] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Oliver.

platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary include.

11:16 PM Changeset in webkit [23306] by sfalken

6 edits in branches/WindowsMerge/WebKitTools

2007-04-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Hyatt.

Eliminate more ATL use (CComBSTR)

10:06 PM Changeset in webkit [23305] by sfalken

10 edits in branches/WindowsMerge/WebKitTools

2007-04-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Eliminate some ATL use in our future open source tree.

ATL headers are not included in any free download, so we'll need to
remove all use of ATL from our open source for compatibility with
Visual Studio Express.

Replace CComPtr and CComQIPtr with COMPtr.

9:58 PM Changeset in webkit [20931] by bdash

3 edits
4 adds in trunk

2007-04-17 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13369 REGRESSION (r13366): Invisible table cell background is painted

Test: fast/table/invisible-cell-background.html

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any background if the cell is not visible. This behavior matches WinIE and Opera.

2007-04-17 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13369 REGRESSION (r13366): Invisible table cell background is painted

fast/table/invisible-cell-background-expected.checksum: Added.
fast/table/invisible-cell-background-expected.png: Added.
fast/table/invisible-cell-background-expected.txt: Added.
fast/table/invisible-cell-background.html: Added.

8:50 PM Changeset in webkit [20930] by justing

6 edits in trunk

Rolling out my previous checkin, as the compiler bug still exists on Leopard.

8:22 PM Changeset in webkit [20929] by aroben

2 edits in trunk/WebKitTools

Scripts/find-included-framework-headers: Search Obj-C and Obj-C++ files as well.

8:18 PM Changeset in webkit [20928] by aroben

1 edit
1 add in trunk/WebKitTools

Added a simple shell script to find all the headers from a specified
framework or frameworks that are included by files beneath the working
directory.

Scripts/find-included-framework-headers: Added.

7:23 PM Changeset in webkit [20927] by justing

6 edits in trunk

WebCore:

Reviewed by adam

Removed workarounds for compiler bug 4213314.

platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Reviewed by adam

Removed workarounds for compiler bug 4213314.

Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]):
WebKit.xcodeproj/project.pbxproj:

6:20 PM Changeset in webkit [20926] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo

editing/execCommand/5119244-expected.checksum: Added.
editing/execCommand/5119244-expected.png: Added.
editing/execCommand/5119244-expected.txt: Added.
editing/execCommand/5119244.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo

indentRegion() was using the old (incorrect) editable root
getter, which returned null for a valid, editable position,
causing the crash.

editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): The editable root for a position is editableRootForPosition(p), not p.node()->rootEditableElement(), because of VisiblePositions before/after tables, replaced elements and others.

5:13 PM Changeset in webkit [20925] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by hyatt

<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted

Demonstrates the bug:

editing/execCommand/5138441-expected.checksum: Added.
editing/execCommand/5138441-expected.png: Added.
editing/execCommand/5138441-expected.txt: Added.
editing/execCommand/5138441.html: Added.

Added inline style declarations for indent blockquotes
to match those that the engine creates:

editing/execCommand/indent-selection.html:
editing/execCommand/outdent-selection.html:

WebCore:

Reviewed by hyatt

<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted

GoogleDocs uses FormatBlock, blockquotes and a style rule
for blockquotes to implement a "Quote Text" feature. Styles
intended only for those blockquotes were added to the
blockquotes that we use for indenting.

css/html4.css: Removed the webkit-indent-blockquote class rule.
editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Use custom margins and turn off border and padding to override author rules for blockquotes.

4:04 PM Changeset in webkit [23304] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-04-17 Oliver Hunt <oliver@apple.com>

Whoops, had code commented out from manual failure test.
Also fixed date of previous changelog entry

platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):

4:00 PM Changeset in webkit [20924] by sullivan

3 edits in trunk/WebKit

Reviewed by Tim Hatcher

fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode

Some of the user interactions that could change the PDF scale and display mode were not going through
the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
in order to catch the other cases.

WebView/WebPDFView.h: new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars

WebView/WebPDFView.mm: (-[WebPDFView setPDFDocument:]): ignore scale and display mode notifications while we're setting up a fresh document (-[WebPDFView dealloc]): cancel the new timer (which releases it) (-[WebPDFView viewDidMoveToWindow]): listen for two PDFKit notifications (-[WebPDFView viewWillMoveToWindow:]): stop listening to the two PDFKit notifications (-[WebPDFView _applyPDFDefaults]): white space change (-[WebPDFView _cancelUpdatePreferencesTimer]): invalidate, release, and nil out the timer (-[WebPDFView _scaleOrDisplayModeChanged:]): update preferences soon, unless deliberately ignoring these notifications (-[WebPDFView _updatePreferencesNow]): cancel timer, then save data to preferences (code for saving the data was extracted from -[PDFPrefUpdatingProxy forwardInvocation:]) (-[WebPDFView _updatePreferencesSoon]): use timer to consolidate multiple calls into one action; formerly we were setting preferences multiple times for some atomic user actions (-[PDFPrefUpdatingProxy forwardInvocation:]): call _updatePreferencesSoon where we used to immediately set preferences

3:31 PM Changeset in webkit [23303] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-04-16 Oliver Hunt <oliver@apple.com>

Reviewed by Ada.

Partial fix for <rdar://problem/5035948> -- Dragging image
or link from boomer doesn't create webloc or image file.

Add all the ground work to set up FileDescriptors and FileContent
for allowing files to be created from drag and drop actions,
and hook up logic for links to create WebLoc data for drag and drop.

platform/win/ClipboardWin.cpp: (WebCore::fileDescriptorFormat): (WebCore::fileContentFormat): Clipboard formats

(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):

Helper functions for create filenames

(WebCore::createGlobalDataForURLContent):

Create the WebLoc content

(WebCore::createGlobalDataForUrlFileDescriptor):

Create a file descriptor for the WebLoc data

(WebCore::writeFileToDataObject):

Basic helper function to push generated file info
into the target DataObject

(WebCore::ClipboardWin::writeURL):

Now puts WebLoc file onto the Clipboard

1:27 PM Changeset in webkit [20923] by justing

10 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list

Demonstrates the bug:

editing/execCommand/5136770-expected.checksum: Added.
editing/execCommand/5136770-expected.png: Added.
editing/execCommand/5136770-expected.txt: Added.
editing/execCommand/5136770.html: Added.

Added placeholders in empty list items:

editing/execCommand/4747450-expected.txt:
editing/execCommand/insert-list-empty-div-expected.txt:
editing/execCommand/4917055-expected.txt:

A horizontal rule pushed into a list item appears *before*
the list marker in the render tree, although, the new results
look more correct (13376):

editing/execCommand/create-list-with-hr-expected.checksum:
editing/execCommand/create-list-with-hr-expected.png:
editing/execCommand/create-list-with-hr-expected.txt:
editing/execCommand/create-list-with-hr.html:

WebCore:

Reviewed by darin

<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list

When InsertListCommand pushes content into list items,
it creates an empty list item and then calls moveParagraphs.
But moveParagraphs' selection preservation code fails when
it encounters empty list items (list items w/o placeholders).
This causes InsertListCommand to lose track of where it has
already been performed, which causes the hang.

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Use brs to hold open empty list items.

1:03 PM Changeset in webkit [20922] by sfalken

1 copy in tags/Safari-522.6.1b

New tag.

12:58 PM Changeset in webkit [20921] by darin

6 edits in trunk/WebCore

Oops, rolled that last change out. I'll redo it again later after making
som additional refinments.

12:00 PM Changeset in webkit [20920] by sullivan

2 edits in trunk/WebKit

Reviewed by Kevin Decker

fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages

WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so (-[WebPDFView _canLookUpInDictionary]): use respondsToSelector to test whether the current version of PDFKit supports this non-API feature (-[WebPDFView _lookUpInDictionaryFromMenu:]): implement this method, which WebKit includes in the context menu when there's selected text (-[WebPDFView _menuItemsFromPDFKitForEvent:]): updated comment for this change

11:44 AM Changeset in webkit [20919] by darin

6 edits in trunk/WebCore

Reviewed by Brady.

a few baby steps to try to make lockHistory and userGesture less confusing

page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture to true. (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having a getter that sounds like a verb phrase. (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto. (WebCore::FrameLoadRequest::isUserGesture): Added. (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.

loader/FrameLoader.h: Remove userGesture parameter from load that takes FrameLoadRequest. Remove default values for lockHistory and userGesture parameters, since that just makes it more likely we'll forget to pass them in. Remove one of the overloads of urlSelected, since it's only called one place.

loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on the true default in FrameLoadRequest. (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected overload since this was the only place it was called. (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true default in FrameLoadRequest. In the other overload, clean up logic to eliminate the argsReferrer variable and get rid of the userGesture parameter, using the value from FrameLoadRequest. (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value in the FrameLoadRequest. This actually changes behavior.

bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass false for userGesture explicitly instead of relying on default argument.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Remove userGesture parameter, relying on the true default in FrameLoadRequest.

10:49 AM Changeset in webkit [20918] by thatcher

1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginStream.mm

More elegant fix for the 64-bit build failure.

7:45 AM Changeset in webkit [20917] by yongjzha

5 edits in S60/branches/3.1m/WebKit

2007-04-11 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY] fix for chinese variant
http://bugs.webkit.org/show_bug.cgi?id=12533

BrowserCore/Formcontrols/inc/FControlInputSkin.h:
BrowserCore/Formcontrols/inc/FControlInputWidget.h:
BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage): (CFormInputSkin::ActivateL):
BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetCursorPositionL): (CControlInputWidget::SetWebKitCursorPosition):

7:00 AM Changeset in webkit [20916] by yongjzha

2 edits in S60/trunk/WebCore

2007-04-17 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
http://bugs.webkit.org/show_bug.cgi?id=13372

khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):

6:59 AM Changeset in webkit [20915] by yongjzha

2 edits in S60/branches/3.1m/WebCore

2007-04-17 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
http://bugs.webkit.org/show_bug.cgi?id=13372

khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):

Apr 16, 2007:

11:23 PM Changeset in webkit [23302] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.

11:22 PM Changeset in webkit [23301] by aroben

2 edits in branches/WindowsMerge/WebKitWin

9:43 PM Changeset in webkit [23300] by aroben

2 edits in branches/WindowsMerge/WebKitWin

WebKit.vcproj/WebKit.sln: Added WTF to the solution.

7:13 PM Changeset in webkit [23299] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Fixed a path.

7:10 PM Changeset in webkit [23298] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed a fixed test.

6:46 PM Changeset in webkit [23297] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Continued sorting/filing bugs.

6:15 PM Changeset in webkit [20914] by ddkilzer

1 edit
1 move in trunk/WebCore

WebCore:

Reviewed by NOBODY (fixed misspelling).

manual-tests/containing-block-position-chage.html: Removed.
manual-tests/containing-block-position-change.html: Added.

5:25 PM Changeset in webkit [20913] by thatcher

1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginStream.mm

64-bit build fix.

4:05 PM Changeset in webkit [23296] by sfalken

7 edits in branches/WindowsMerge

2007-04-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Visual Studio Express compatibility for WebKit build (except for DRT)

WebDragClient.cpp: Removed unused header (atlsafe.h)
WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
WebView.cpp: Removed unused header (atldef.h)

2:06 PM Changeset in webkit [20912] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

Demonstrates the bug:

editing/pasteboard/5134759-expected.checksum: Added.
editing/pasteboard/5134759-expected.png: Added.
editing/pasteboard/5134759-expected.txt: Added.
editing/pasteboard/5134759.html: Added.

A unnecessary extra space was added to an element's
inline style declaration, because of the way cssText behaves:

editing/pasteboard/paste-table-002-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

The moveParagraphs call that ReplaceSelectionCommand
performs must receive only inline content from createMarkup,
or else it will result in another call to moveParagraphs
when it performs the move, resulting in infinite recursion.

editing/markup.cpp: (WebCore::startMarkup): We were only converting a block to an inline if it had an inline style declaration or styles coming from matched rules. Cleaned up this code a bit by handling an element's style separately from its other attributes.

1:29 PM Changeset in webkit [20911] by spadma

5 edits in S60/trunk

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

BrowserControl/inc/BrCtl.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):

1:28 PM Changeset in webkit [20910] by spadma

5 edits in S60/branches/3.1m/WebKit

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

BrowserControl/inc/BrCtl.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):

11:39 AM Changeset in webkit [23295] by aroben

2 edits in branches/WindowsMerge/WebCore

11:38 AM Changeset in webkit [20909] by spadma

3 edits in S60/trunk/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

Plugin/inc/PluginHandler.h:
Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):

11:38 AM Changeset in webkit [20908] by spadma

3 edits in S60/branches/3.1m/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

Plugin/inc/PluginHandler.h:
Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):

11:31 AM Changeset in webkit [20907] by thatcher

2 edits in trunk/WebKitTools

Drosera/debugger.css: hide the borders for iframes

11:29 AM Changeset in webkit [20906] by darin

2 edits in trunk/WebKit

Rubber stamped by Tim Hatcher.

WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message for the "version number ending in 4" check so folks from Apple can find the original bug that motivated for this. To summarize what's in that bug, it says that <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu, and that some other affected sites were not using OpenCube (so the error is presumably more widespread).

11:07 AM Changeset in webkit [20905] by yongjzha

2 edits in S60/trunk/JavaScriptCore

rathnasa, reviewed by yongjun

DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.
http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:

11:04 AM Changeset in webkit [20904] by yongjzha

2 edits in S60/branches/3.1m/JavaScriptCore

2007-04-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:

10:26 AM Changeset in webkit [20903] by brmorris

2 edits in S60/trunk/WebKit

bradley, rs'd by padma

DESC: move ContentAcceess namespace declaration

BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::DecodeDRMImageContentL):

10:17 AM Changeset in webkit [23294] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Merge in r20872.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js:

10:14 AM Changeset in webkit [23293] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Merge in r20861.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js:

10:11 AM Changeset in webkit [23292] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20845.

WebInspector/webInspector/inspector.js:

10:06 AM Changeset in webkit [23291] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20844.

WebInspector/webInspector/inspector.js:

10:05 AM Changeset in webkit [23290] by aroben

5 edits in branches/WindowsMerge/WebKitWin

Merge in r20843.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/scrollarea.js:
WebInspector/webInspector/scrollbar.js:
WebInspector/webInspector/utilities.js:

10:04 AM Changeset in webkit [23289] by aroben

3 edits
1 add in branches/WindowsMerge/WebKitWin

Merge in r20842.

WebInspector/webInspector/inspector.html:
WebInspector/webInspector/inspector.js:
WebInspector/webInspector/utilities.js: Added.

10:02 AM Changeset in webkit [23288] by aroben

3 edits
1 add in branches/WindowsMerge/WebKitWin

Merge in r20840.

WebInspector/webInspector/inspector.html:
WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js: Added.

9:52 AM Changeset in webkit [20902] by darin

2 edits in trunk/WebCore

get layout tests going again

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Replace assertion with a runtime check. We can consider changing it back to an assertion some day, but it's not important.

9:51 AM Changeset in webkit [23287] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed another non-crasher.

9:39 AM Changeset in webkit [23286] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed two tests that no longer crash.

8:41 AM Changeset in webkit [20901] by darin

13 edits in trunk

WebCore:

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13303 <rdar://problem/5126341> REGRESSION: controls in a background Safari window maintain active appearance if the address bar has focus (13303)

fix a related problem where elements could look focused in non-active windows

simplify secure keyboard entry logic in Frame::setIsActive

WebCore.exp: Add two new symbols for use by WebKit.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active. (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.

page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls setUseSecureKeyboardEntry only if the frame is active, but also stores away the state, so that the setIsActive function doesn't have to recompute it. (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code to manage control tints, which are not based on the whether the frame is active but rather on AppKit's concept of whether the window should have "key appearance". Simplified the logic about when to call setUseSecureKeyboardEntry by using the value of m_useSecureKeyboardEntryWhenActive. (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
page/Frame.h: Made setSecureKeyboardEntry private and renamed it to setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and added a public setUseSecureKeyboardEntryWhenActive.
page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion, and removed isSecureKeyboardEntry().

page/FrameView.h: Added updateControlTints.
page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved here from setIsActive for two reasons: (1) it makes more sense in the view class, and (2) it needs to be called at the appropriate time for AppKit, not when active changes.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive check here to match the logic in the implementation of the CSS pseudo-state.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of repeating the logic here. Removed the "need to add a key window test here" comment. (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.

WebKit:

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13303 <rdar://problem/5126341> REGRESSION: controls in a background Safari window maintain active appearance if the address bar has focus (13303)

WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]): Added. Calls FrameView::updateControlTints.

8:15 AM Changeset in webkit [20900] by darin

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13227 StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)

platform/StringImpl.cpp: (WebCore::StringImpl::isLower): Based on test application results, changed to use && instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters outside the BMP. Improved comments. (WebCore::StringImpl::lower): Improved comments. (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid branches. Improved comments. Added an assertion about the assumption we're making that characters in the char* are all ASCII.

Apr 15, 2007:

10:25 PM Changeset in webkit [20899] by kevino

5 edits in branches/wx-port-alpha/trunk

Get wxWebKit branch compiling on Windows again, now all major ports are building.

10:22 PM Applications using WebKit edited by sengan@ansemond.com

Added Find It! Keep It! by Ansemond LLC (diff)

5:51 PM Changeset in webkit [20898] by kevino

167 edits
107 copies
11 deletes in branches/wx-port-alpha/trunk

Update wxWebKit SVN revision, and restore the build.

12:34 PM Changeset in webkit [20897] by kevino

1 add in branches/wx-port-alpha/trunk/JavaScriptCore/WTFSources.bkl

Add missing Bakefile to wxWebKit branch.

10:35 AM Changeset in webkit [20896] by kevino

4 edits
22 adds in branches/wx-port-alpha/trunk

Adding wx API, wxBrowser sample, and build script to wxWebKit branch.

Apr 14, 2007:

10:01 PM Changeset in webkit [23285] by aroben

4 edits
1 copy in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Steve.

Added a Debug_Internal configuration to DRT to match WebKit/WebCore.
Debug now compiles against release CoreGraphics.lib and pthreadVC2.lib.

9:40 PM Changeset in webkit [23284] by aroben

2 edits in branches/WindowsMerge/WebKitWin

WebKit.vcproj/WebKitGUID.vcproj: Need to use WebKitConfigSuffix instead of ConfigSuffix now.

9:11 PM Changeset in webkit [23283] by aroben

4 edits in branches/WindowsMerge

7:28 PM Changeset in webkit [23282] by aroben

2 edits in branches/WindowsMerge/WebCore

Small correctness fix that is needed for building OpenSource.

platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.

6:05 PM Changeset in webkit [20895] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/WebInspector.m

Remove some more isSameNode checks, since the JavaScript does this.

5:51 PM Changeset in webkit [20894] by thatcher

4 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Move more code to JavaScript. The JavaScript now holds the focused and root nodes in global variables.

3:33 PM Changeset in webkit [20893] by kevino

46 edits
55 adds in /

Adding wx sources and changes to wxWebKit branch.

3:16 PM Changeset in webkit [20892] by kevino

3 edits in branches/wx-port-alpha/trunk/Bakefiles

Bakefiles changes for wxWebKit branch.

3:13 PM Changeset in webkit [20891] by kevino

7 edits in branches/wx-port-alpha/trunk/JavaScriptCore

JavaScriptCore changes needed for wxWebKit branch.

3:03 PM Changeset in webkit [20890] by kevino

1 add in branches/wx-port-alpha/trunk/TOTRevision.txt

Adding TOT revision info.

Apr 13, 2007:

6:26 PM Changeset in webkit [20889] by ddkilzer

12 edits
4 moves
8 adds in trunk

LayoutTests:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
it was moved to tables/mozilla/bugs/bug11384s.html.

fast/css/table-text-align-quirk-expected.checksum: Added.
fast/css/table-text-align-quirk-expected.png: Added.
fast/css/table-text-align-quirk-expected.txt: Added.
fast/css/table-text-align-quirk.html: Added.
fast/css/table-text-align-strict-expected.checksum: Added.
fast/css/table-text-align-strict-expected.png: Added.
fast/css/table-text-align-strict-expected.txt: Added.
fast/css/table-text-align-strict.html: Added.
fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center" style with "text-align: center" style.
tables/mozilla/bugs/bug11384s-expected.checksum: Added.
tables/mozilla/bugs/bug11384s-expected.png: Added.
tables/mozilla/bugs/bug11384s-expected.txt: Added.
tables/mozilla/bugs/bug11384s.html: Added.
tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test: fast/css/table-text-align-quirk.html

fast/css/table-text-align-strict.html

Previous commit (r20731) removed the wrong property from WebCore/css/html4.css. However,
when the correct property was removed, it caused tables to inherit alignment properties
from tags like <center> and <div align="center">. This is fixed in
WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
text-align property.

css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ditto.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center, -webkit-left or -webkit-right values for text-align, so reset them back to auto.
css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector. It was previously added to css/quirks.css in r20731.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcHorizontalMargins): Ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Ditto.
rendering/RenderStyle.h: Ditto. (WebCore::):
rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.

5:57 PM Changeset in webkit [20888] by oliver

2 edits in trunk/WebKit

2007-04-13 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Due to rdar://problem/5133910 -- WebArchives should not be constructed
using resource from the cache -- We may try to create a potentially
incorrect WebArchive when dragging an image multiple times.

This patch retains the assertion for invalid behaviour, but adds a
branch to make sure we don't try to do anything with the WebArchive
in release builds.

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):

5:47 PM Changeset in webkit [23281] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

Sync our config.h with the OpenSource version so we can merge ours in
later.

config.h: Added #defines from the OpenSource version, moved Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid of assert.h
platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use ASSERT instead of assert.

5:15 PM Changeset in webkit [23280] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Continued filtering.

3:45 PM Changeset in webkit [20887] by bdash

1 copy in tags/Safari-4522.5.5/WebKit

New tag (part 2).

3:45 PM Changeset in webkit [20886] by bdash

1 add in tags/Safari-4522.5.5

New tag (part 1).

3:44 PM Changeset in webkit [20885] by bdash

1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

3:42 PM Changeset in webkit [20884] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20869.

2:56 PM Changeset in webkit [23279] by beidson

1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Updated to reflect new location of the history test which is now http

2:47 PM Changeset in webkit [20883] by beidson

1 edit
4 adds
1 delete in trunk/LayoutTests

Reviewed by a sanity check

My layout test *has* to be http, since dumping history in DRT with hard coded file paths
will never match up to expected results across machines.

Lame

history/new-window-redirect-history-expected.txt: Removed.
history/new-window-redirect-history.html: Removed.
history/resources/redirect-1.html: Removed.
history/resources/redirect-2.html: Removed.
http/tests/navigation/new-window-redirect-history-expected.txt: Added.
http/tests/navigation/new-window-redirect-history.html: Added.
http/tests/navigation/resources/redirect-1.html: Added.
http/tests/navigation/resources/redirect-2.html: Added.

2:45 PM Changeset in webkit [23278] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Re-enabled the tests that are actual failures.

2:33 PM Changeset in webkit [20882] by thatcher

1 copy in tags/Safari-4522.5.4/WebKit

New tag (part 2).

2:32 PM Changeset in webkit [20881] by thatcher

1 add in tags/Safari-4522.5.4

New tag (part 1).

2:27 PM Changeset in webkit [20880] by thatcher

4 edits in branches/Safari-522

Versioning.

1:48 PM Changeset in webkit [23277] by beidson

1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Added history/new-window-redirect-history.html to the skipped file pending addition of multiple windows to DRT

1:39 PM Changeset in webkit [23276] by aroben

2 edits
1 delete in branches/WindowsMerge/WebCore

Rubberstamped by Tim.

Removed the loader/win directory since it only contains empty files.

WebCore.vcproj/WebCore.vcproj: Removed empty files.
loader/win/FrameLoaderWin.cpp: Removed.
loader/win/ResourceLoaderWin.cpp: Removed.

1:34 PM Changeset in webkit [20879] by aroben

2 edits in trunk/WebKitTools

Rubberstamped by Anders.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include stdio.h so that snprintf is defined.

1:31 PM Changeset in webkit [23275] by andersca

2 edits in branches/WindowsMerge/WebKitTools

Fix the release build too!

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj:

1:28 PM Changeset in webkit [20878] by beidson

4 edits
6 adds in trunk

LayoutTests:

Reviewed by Geoose

<rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

Layout test that covers opening an empty new window, then starting to navigate around in it

history/new-window-redirect-history-expected.txt: Added.
history/new-window-redirect-history.html: Added.
history/resources/redirect-1.html: Added.
history/resources/redirect-2.html: Added.

WebCore:

Reviewed by Black Sheep

<rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

When you click on a link that opens in a new window from within gmail, they first create a new window
with an empty URL, then immediately document.write() into the window to schedule a redirect.

Since the initial page doesn't have a URL associated with it, a history item never gets created. The
reasonable solution? To actually create the history item after the redirect (in updateHistoryForInternalLoad)

loader/FrameLoader.cpp: (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already a current history item
loader/FrameLoader.h:

1:09 PM Changeset in webkit [20877] by beidson

2 edits in trunk/WebKitTools

Reviewed by Anders

Add the ability to dump the back/forward history of all windows open at the end of a test

DumpRenderTree/DumpRenderTree.m: (dumpBackForwardListForWebView): Dump B/F list for the given WebView (dump): Call dumpBackForwardListForWebView for each WebView open after the test

12:54 PM Changeset in webkit [20876] by andersca

4 edits in trunk

LayoutTests:

Reviewed by Brady.

plugins/open-and-close-window-with-plugin.html: Manage open windows manually for this test.

WebKitTools:

Reviewed by Brady.

By default, close any windows that have been opened during a test. This can be overridden by
calling setCloseRemainingWindowsWhenComplete(false).

Change the windows set to an array so we can gurantee the enumeration order.

DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (runTest): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]):

12:14 PM Changeset in webkit [20875] by thatcher

2 edits in branches/Safari-522/WebKit

Merge fix from r20874.

12:13 PM Changeset in webkit [20874] by thatcher

2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/5132727> Soho Mail build fails because of renamed SPI

WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb

12:12 PM Changeset in webkit [20873] by ggaren

2 edits in trunk/WebKitTools

Build fix.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (handleCallback): Explicitly cast the void* returned by malloc.

11:42 AM Changeset in webkit [23274] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Commented out some that may not be actually failing.

10:54 AM Changeset in webkit [23273] by andersca

2 edits in branches/WindowsMerge/WebKitTools

Fix build.

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: #define snprintf to be _snprintf and dd two defines to disable warnings for strdup and _snprintf.

10:02 AM Changeset in webkit [20872] by thatcher

2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Share more code between the TreeOutline and TreeElement classes. Remember the expanded state for elements when the tree is rebuilt with the same represented objects. Toggling ignore whitespace correct repopulates the tree again.

9:59 AM Changeset in webkit [20871] by sfalken

2 edits in branches/Safari-522/WebCore

Merged fix from r20847

9:54 AM BuildingQtOnLinux edited by ed@uping.com

Updating dependencies (diff)

5:59 AM Changeset in webkit [20870] by zbujtas

2 edits in S60/trunk/WebCore

anapatil <anand.1.patil@nokia.com>

Reviewed by zbujtas@gmail.com
DESC: Fix for : Browser - extra content seen when browsing www.kartta.ouka.fi

http://bugs.webkit.org/show_bug.cgi?id=13308
TSW ID : MRAA-6X4FVQ

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/rendering/render_frames.cpp:

12:56 AM Changeset in webkit [20869] by bdash

2 edits in trunk/WebKit

2007-04-13 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

Apr 12, 2007:

11:38 PM Changeset in webkit [20868] by oliver

2 edits in trunk/WebCore

2007-04-12 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

This fixes <rdar://problem/5060766> -- Frameset with
an empty frame crashes due to null document. Debug
builds hit the frame->document() assertion in
EventHandler::prepareMouseEvent

This null check seems necessary now, having run through
all the logic on the path to this crash it appears that
we can't avoid this null check.

page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):

9:32 PM Changeset in webkit [20867] by ggaren

13 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
This doesn't actually change JavaScriptCore, but that's where npapi.h is.

bindings/npapi.h: Add headers member to NPStream struct. Also increase NP_VERSION_MINOR to 18. Increasing to >= 17 allows plug-ins to safely detect whether to look for NPStream::headers. Increasing from 17 to 18 reflects presence of NPObject enumeration, which was added in a prior patch, and which has been agreed to constitute version 18 by the plugin-futures list. Also add other missing bits of npapi.h to catch up from 14 to 18. This includes features that are not implemented in WebKit, but those are safely stubbed.

LayoutTests:

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

http/tests/plugins/npapi-response-headers-expected.txt: Added.
http/tests/plugins/npapi-response-headers.html: Added.
http/tests/plugins/resources/load-me-1.txt: Added.
http/tests/plugins/resources/load-me-2.txt: Added.

WebKit:

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

Plugins/WebBaseNetscapePluginStream.h: declarations.
Plugins/WebBaseNetscapePluginStream.mm: main implementation. (-[WebBaseNetscapePluginStream dealloc]): cleanup. (-[WebBaseNetscapePluginStream finalize]): cleanup. (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): Pass headers along. (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Main work is here. Extract headers from NSHTTPURLResponse object into a byte sequence. See comments here about how it would be nice to have low-level access to the HTTP response. (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Conform to new startStream params. Not applicable here, pass nil.

WebKitTools:

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
Changes in WebKitTools are only for the NPAPI test plugin.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic. (pluginInvoke): support null window argument for NPStream creation. (pluginAllocate): initialization. (pluginDeallocate): cleanup. (handleCallback): add second JS callback arg: header dump. (notifyStream): added; hook from NPP_NewStream to record headers.
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook. (NPP_NewStream): call new header hook.

9:15 PM Changeset in webkit [23272] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added a pre-existing radar reference.

9:05 PM Changeset in webkit [23271] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff, Adam.

Changes required for search history content.

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp: (WebFrame::isFrameSet): Added (WebFrame::string): Added
WebFrame.h:

8:47 PM Changeset in webkit [23270] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Filed some more bugs.

6:10 PM Changeset in webkit [20866] by justing

3 edits
16 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo

editing/selection/5131716-1-expected.checksum: Added.
editing/selection/5131716-1-expected.png: Added.
editing/selection/5131716-1-expected.txt: Added.
editing/selection/5131716-1.html: Added.
editing/selection/5131716-2-expected.checksum: Added.
editing/selection/5131716-2-expected.png: Added.
editing/selection/5131716-2-expected.txt: Added.
editing/selection/5131716-2.html: Added.
editing/selection/5131716-3-expected.checksum: Added.
editing/selection/5131716-3-expected.png: Added.
editing/selection/5131716-3-expected.txt: Added.
editing/selection/5131716-3.html: Added.
editing/selection/5131716-4-expected.checksum: Added.
editing/selection/5131716-4-expected.png: Added.
editing/selection/5131716-4-expected.txt: Added.
editing/selection/5131716-4.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo

rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Consider clicks inside the blocks padding, instead of incorrectly sending them to the position before the block.

5:55 PM Changeset in webkit [23269] by aroben

4 edits
1 copy
1 delete in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Steve.

Removed unused file.

WebCore.vcproj/WebCore.sln: Removed.

WebKitWin:

Rubberstamped by Steve.

Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
WebKit.sln so that opensource contributors can use it to build a
working WebKit.

WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore, DumpRenderTree projects.
WebKit.vcproj/WebKit.submit.sln: Added.

5:40 PM Changeset in webkit [23268] by aroben

2 edits in branches/WindowsMerge/WebCore

Didn't mean to commit this.

WebCore.vcproj/WebCore.vcproj:

5:28 PM Changeset in webkit [23267] by aroben

8 edits
2 copies in branches/WindowsMerge

1:33 PM Changeset in webkit [23266] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Continued to organize the list and file bugs for failures that do not have radars.

12:14 PM Changeset in webkit [20865] by brmorris

2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: removed const from CWmlDispatcher::HeadersL
http://bugs.webkit.org/show_bug.cgi?id=13206

12:01 PM Changeset in webkit [23265] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Organized the Skipped. Failed tests are either filed under existing bugs, filed under new bugs, or are grouped by failure but do not have a bug yet.

10:27 AM Changeset in webkit [20864] by brmorris

2 edits in S60/trunk/WebKit

borges, reviewed by spadma

DESC: related to S60 task 15118 for ccb - Fix for Symbian wk14 update related to ContentAccess class
http://bugs.webkit.org/show_bug.cgi?id=13331

9:56 AM Changeset in webkit [20863] by beidson

3 edits in trunk/WebKit

Build fix for case sensitive file systems

Misc/WebNSPasteboardExtras.mm:
WebCoreSupport/WebPasteboardHelper.mm:

9:19 AM Changeset in webkit [23264] by sullivan

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

Interfaces/IWebUIDelegate.idl: added new PDF-related context menu items to enum to keep it in sync with WebCore

9:12 AM Changeset in webkit [20862] by sullivan

8 edits
2 adds in trunk

WebCore:

Reviewed by Anders

WebCore part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

platform/ContextMenuItem.h: (WebCore::): add two PDF-related context menu items to enum to keep it in sync with WebKit

platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): add the new context menu items to the do-nothing case of a big switch statement

WebKit:

Reviewed by Anders

WebKit part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

Misc/WebNSArrayExtras.h: Added.
Misc/WebNSArrayExtras.m: Added. (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): New file, includes this method to strip leading, trailing, and duplicate separators from arrays of NSMenuItems (copied from Safari)

WebView/WebUIDelegatePrivate.h: new MenuItemTag enum values for new PDFKit context menu items

WebKit.xcodeproj/project.pbxproj: updated for new files

WebView/WebPDFView.mm: (-[WebPDFView _anyPDFTagsFoundInMenu:]): check for new PDFKit context menu items (-[WebPDFView _menuItemsFromPDFKitForEvent:]): associate new PDFKit context menu item selectors with the new tags; skip certain selectors that correspond to menu items that WebKit already includes; remove useless menu item separators when we're done, since we might have removed arbitrarily-placed menu items

8:40 AM Changeset in webkit [20861] by thatcher

2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Make removeChildren not a recursive removeChildren. Also resue root tree elements when building the root, to keep items that are already visible and prevent rebuilding the tree as much.

8:28 AM Changeset in webkit [20860] by hausmann

2 edits in trunk/WebCore

Fixed drawing of justified text in the Qt port.

7:53 AM Changeset in webkit [20859] by yongjzha

3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: Connection shown as Normal in secure page
http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):

Apr 11, 2007:

11:42 PM Changeset in webkit [20858] by oliver

13 edits in trunk

2007-04-11 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

WebCore:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

Also made the Pasteboard::m_pasteboard a RetainPtr although it
shouldn't be necessary as the only NSPasteboard instances that
should ever be inserted are the system clipboard and dragging
pasteboard. Neither of which should ever be collected.

page/mac/WebCoreFrameBridge.mm: (_getPreSmartSet): (_getPostSmartSet):
platform/Pasteboard.h:
platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
platform/mac/PasteboardMac.mm: (WebCore::writableTypesForURL): (WebCore::writableTypesForImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

WebKit:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

This fixes <rdar://problem/5058731> -- Crash in
WebCore::DragData::containsCompatibleContent due to early release
of types array

9:45 PM Changeset in webkit [20857] by bdash

5 edits
4 adds in trunk

2007-04-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=11362 Native popup with size="1" wraps options

Test: fast/forms/menulist-option-wrap.html

css/html4.css: Added white-space declaration for select[size="0"] and select[size="1"]. Added border-radius declaration for select.

2007-04-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=11362 Native popup with size="1" wraps options

fast/forms/menulist-option-wrap-expected.checksum: Added.
fast/forms/menulist-option-wrap-expected.png: Added.
fast/forms/menulist-option-wrap-expected.txt: Added.
fast/forms/menulist-option-wrap.html: Added.
fast/forms/select-empty-option-height-expected.checksum:
fast/forms/select-empty-option-height-expected.png:

9:28 PM Changeset in webkit [23263] by bdash

3 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Mark Rowe <mrowe@apple.com>

Not reviewed. Internal counterpart to open-source r20856.

WebChromeClient.cpp: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
WebChromeClient.h:

9:21 PM Changeset in webkit [20856] by bdash

15 edits in trunk

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
page/Chrome.cpp: (WebCore::Chrome::createWindow): (WebCore::Chrome::createModalDialog):
page/Chrome.h:
page/ChromeClient.h:
page/ContextMenuController.cpp: (WebCore::openNewWindow):
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): (WebCore::SVGEmptyChromeClient::createModalDialog):

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

COM/ChromeClientWin.cpp: (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog):
COM/ChromeClientWin.h:
WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog):
WebCoreSupport/ChromeClientQt.h:

6:38 PM Changeset in webkit [20855] by beidson

2 edits in trunk/WebCore

Reviewed by Ada

<rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const

This was free nil checking lost during the ObjC -> C++ conversion

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader

6:25 PM Changeset in webkit [20854] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

editing/deleting/5126166-expected.checksum: Added.
editing/deleting/5126166-expected.png: Added.
editing/deleting/5126166-expected.txt: Added.
editing/deleting/5126166.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

If a selection ends in a table cell, we shouldn't perform
a merge after deleting that selection. We have code in
place to prevent those merges, but it failed here.

It fails because the end of the selection was [tableCell, 0],
(normally not a valid VisiblePosition, but valid here
because the table cell is empty). We prevent the merge
if the node of the position at the end of the selection
has an enclosingTableCell. Even though [tableCell, 0] has
an enclosing table cell, the node tableCell doesn't, so
the check fails.

Fixed this by changing enclosingTableCell to take in
a position, instead of a node. The other enclosing element
getters should be changed in this way as well.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Call the new enclosingTableCell.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
editing/htmlediting.cpp: (WebCore::enclosingTableCell): Take in a position instead of a node.
editing/htmlediting.h:

5:37 PM Changeset in webkit [23262] by aroben

3 edits
1 move
1 add
1 delete in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Tim.

Moved the Skipped file into win/Skipped in anticipation of the opensource merge.

Skipped: Removed.

WebCoreWin:

Reviewed by Tim.

Get rid of FrameViewWin.cpp, since it's empty.

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameViewWin.cpp: Removed.

5:33 PM Changeset in webkit [20853] by bdash

1 edit in tags/WebKit-5522.6.1/WebKit/Configurations/Version.xcconfig

Versioning.

5:32 PM Changeset in webkit [20852] by bdash

1 edit in tags/WebKit-5522.6.1/WebKit/Plugins/WebBaseNetscapePluginView.mm

Merge in r20765.

5:30 PM Changeset in webkit [20851] by bdash

1 copy in tags/WebKit-5522.6.1/WebKit

New tag (part 2).

5:29 PM Changeset in webkit [20850] by bdash

1 add in tags/WebKit-5522.6.1

New tag (part 1).

5:11 PM Changeset in webkit [23261] by adachan

2 edits in branches/WindowsMerge/WebKitWin

2007-04-11 Ada Chan <adachan@apple.com>

Reviewed by Steve.

<rdar://4919560> Implement reopen last window, last session

WebKitWin:

Implemented WebHistoryItem::originalURLString(). Added parameter checks to other methods.

WebHistoryItem.cpp: (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):

2:30 PM Changeset in webkit [20849] by bdash

3 edits in trunk/WebKitQt

2007-04-12 Mark Rowe <mrowe@apple.com>

Second part of Qt build fix.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::loadedFromCachedPage): (WebCore::FrameLoaderClientQt::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientQt::saveDocumentViewToCachedPage):
WebCoreSupport/FrameLoaderClientQt.h:

1:58 PM Changeset in webkit [20848] by bdash

3 edits
1 move in trunk/WebCore

2007-04-12 Mark Rowe <mrowe@apple.com>

Qt build fix.

WebCore.pro:
editing/qt/EditorQt.cpp: (WebCore::Editor::markBadGrammar):
history/qt/CachedPageQt.cpp: Added. (WebCore::CachedPage::close):
history/qt/PageCacheQt.cpp: Removed.

11:22 AM Changeset in webkit [20847] by beidson

2 edits in trunk/WebCore

Reviewed by Antti

<rdar://problem/5125648> and http://bugs.webkit.org/show_bug.cgi?id=13326

Crash opening a link in a new window from Gmail

Problem here is that the currentHistoryItem in the new window is null. This *shouldn't* be the case,
and is the cause of a very long standing bug -
http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail

For now, adding a null check prevents this crash and restores the original, long standing regression

loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check

10:58 AM Changeset in webkit [23260] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Update for changes to Pasteboard.

platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

10:51 AM Changeset in webkit [20846] by aroben

6 edits in trunk/WebCore

Reviewed by Anders.

Made image document copying more cross-platform.

All layout tests pass.

editing/Editor.cpp: (WebCore::imageNodeFromImageDocument): Added. (WebCore::Editor::canCopy): Called imageNodeFromImageDocument. (WebCore::Editor::copy): Ditto. (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
platform/Pasteboard.h: Made writeImage more general, which allowed getting rid of its second incarnation.
platform/gdk/TemporaryLinkStubs.cpp:
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Collapsed logic from the two writeImage methods into one. (Pasteboard::writeImage): Updated for Pasteboard changes.
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.

7:31 AM Changeset in webkit [20845] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Properly reveal and select the focused node when the tree is updated.

6:54 AM Changeset in webkit [20844] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Update the disabled state of the traverse buttons when selection changes.

6:28 AM Changeset in webkit [20843] by thatcher

4 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Use the script equality operator in almost all cases. Other various cleanup.

5:59 AM Changeset in webkit [20842] by thatcher

2 edits
1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move DOM and String prototype additions to utilities.js.

12:50 AM Changeset in webkit [20841] by darin

2 edits in trunk/WebCore

css/CSSValueKeywords.in: Fix a comment.

12:28 AM Changeset in webkit [23259] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Skipped: Consolidated some failures that have the same underlying cause, and removed some tests that were duplicated in this file.

12:16 AM Changeset in webkit [20840] by thatcher

2 edits
1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Factored out the tree outline control into a generic JavaScript class. This fixed a couple of issues with the previous implementation.

Apr 10, 2007:

7:43 PM Changeset in webkit [20839] by justing

5 edits
14 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

Forgot to check these in in my previous checkin:

editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.

Tests for a bug where replaced elements would act
as sentence boundaries:

editing/selection/4932260-1-expected.checksum: Added.
editing/selection/4932260-1-expected.png: Added.
editing/selection/4932260-1-expected.txt: Added.
editing/selection/4932260-1.html: Added.

Tests to see that replaced elements do not act as word
boundaries when moving forward through the document:

editing/selection/4932260-2-expected.checksum: Added.
editing/selection/4932260-2-expected.png: Added.
editing/selection/4932260-2-expected.txt: Added.
editing/selection/4932260-2.html: Added.

Ditto but tests moving backward:

editing/selection/4932260-3-expected.checksum: Added.
editing/selection/4932260-3-expected.png: Added.
editing/selection/4932260-3-expected.txt: Added.
editing/selection/4932260-3.html: Added.

No way to test accessibility APIs atm, and had trouble
making a test for selection creation with double-click
and drag.

WebCore:

Reviewed by harrison

<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

By default, text iterators don't emit anything for replaced
elements. Boundary finding code works around this but has
bugs: replaced elements act as sentence boundaries and the
above bug, where previousBoundary moves past the start of a
word if there is a replaced element just before it. This
patch fixes these issues by treating replaced elements as
punctuation for boundary finding.

editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Set m_pastStartNode, the node after (in a reverse pre-order traversal) the last one that should be processed. (WebCore::SimplifiedBackwardsTextIterator::advance): Stop at m_pastStartNode. Iterate over nodes in reverse pre-order (TextIterator traverses in pre-orer). This makes knowing when to emit characters after nodes vs. when to emit characters before nodes easier. Remove the special case for entering a new block, emitting characters after nodes can now be handled generally, in handleNonTextNode(), because of the way we traverse. Set m_handledChildren to false every iteration since we now do traverse in reverse pre-order. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Emit a comma for replaced elements. We only use this kind of iterator for finding boundaries, so we can do this unconditionally. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Don't use emitNewline, instead specify where the newline should be positioned. A node is handled before its children, so characters emitted here should be positioned after the node, not before it. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Don't use emitNewline, instead specify where the newline should be positioned. (WebCore::CharacterIterator::CharacterIterator): Create a TextIterator that emits content for replaced elements, if requested.
editing/TextIterator.h:
editing/visible_units.cpp: (WebCore::previousBoundary): Removed replaced element handling code. If the start of the chunk that contained the boundary was in a non-text node, then the boundary is not necessarily in that node. Particularly because it is only the end of the chunk that is guaranteed to be a valid position in those cases. We must iterate backwards by character from the end of the chunk to find the boundary. (WebCore::nextBoundary): Removed replaced element handling code.

6:46 PM Changeset in webkit [23258] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

Skipped: Added last tests to make build bot green.

6:00 PM Changeset in webkit [20838] by sfalken

1 copy in tags/Safari-522.5.6b

New tag.

5:02 PM Changeset in webkit [23257] by beidson

6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Changed a TemporaryLinkStub and updated the project file

WebCore.vcproj/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp: (CachedPage::close):

WebKitWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Basically updated client methods for the new names and signatures

WebFrame.cpp: (WebFrame::loadedFromCachedPage): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::saveDocumentViewToCachedPage):
WebFrame.h:

4:55 PM Changeset in webkit [20837] by beidson

22 edits
3 moves
2 deletes in trunk

WebCore:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

These two objects are a relic of when the PageCache was split between WebCore and WebKit
It just makes good sense to combine them now, and the new object is more appropriately
called "CachedPage"

This patch is vast in scope, but simple in depth - anywhere a PageCache or PageState object
was used has been adjusted to use a CachedPage object instead. The most notable change is
that HistoryItem - which always used to have a PageCache object which may or may not have
had a PageState - now may or may not have a CachedPage. This actually simplifies the
HistoryItem code a bit while making the role of CachedPage much more clear.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:

history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::close):

history/PageCache.cpp: Removed.
history/PageCache.h: Removed.
page/PageState.cpp: Removed.
page/PageState.h: Removed.
history/CachedPage.cpp: Added. (WebCore::CachedPage::create): (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear): (WebCore::CachedPage::setDocumentLoader): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::setTimeStamp): (WebCore::CachedPage::setTimeStampToNow): (WebCore::CachedPage::timeStamp):
history/CachedPage.h: Added. (WebCore::CachedPage::document): (WebCore::CachedPage::mousePressNode): (WebCore::CachedPage::URL):

history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setCachedPage): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::alwaysAttemptToUseCachedPage): (WebCore::HistoryItem::setAlwaysAttemptToUseCachedPage): (WebCore::HistoryItem::cachedPage): (WebCore::cachedPagesPendingRelease): (WebCore::HistoryItem::releaseCachedPagesOrReschedule): (WebCore::HistoryItem::releaseAllPendingCachedPages): (WebCore::HistoryItem::scheduleCachedPageForRelease):
history/HistoryItem.h:
history/mac/HistoryItemMac.mm:

history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleaseCachedPagesOrReschedule):
history/HistoryItemTimer.h:

history/mac/PageCacheMac.mm: Removed.
history/mac/CachedPageMac.mm: Added. (WebCore::CachedPage::close): (WebCore::CachedPage::setDocumentView): (WebCore::CachedPage::documentView):

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::loadFromCachedPage): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):
loader/DocumentLoader.h:

loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::cachePageToHistoryItem): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemCachedPage): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:

page/mac/WebCoreFrameBridge.h: Got rid of unused WebCorePageCacheStateKey
page/mac/WebCoreFrameBridge.mm: Ditto

platform/graphics/svg/SVGImage.cpp:
platform/graphics/svg/SVGImageEmptyClients.h: Update to reflect the new names (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemCachedPage): (WebCore::SVGEmptyFrameLoaderClient::loadedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToCachedPage):

WebKit:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

WebKit side of the change to reflect the new object name of CachedPage and new Client method names

History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromCachedPage): (WebFrameLoaderClient::loadedFromCachedPage): (WebFrameLoaderClient::saveDocumentViewToCachedPage):

3:40 PM Changeset in webkit [20836] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Fixed last check-in to print in release builds, too.

kjs/collector.cpp: (KJS::getPlatformThreadRegisters):

3:28 PM Changeset in webkit [23256] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

Skipped: Re-enabled some tests that no longer crash and added other failures, for which radars will be filed, so that the build bot will be green, and will be usefull in identifying new breakages. Currently it is not.

3:27 PM Changeset in webkit [20835] by ggaren

3 edits in trunk/JavaScriptCore

Reviewed by John Sullivan, Darin Adler.

Fixed <rdar://problem/5121899> JavaScript garbage collection leads to
later crash under Rosetta (should abort or leak instead?)

Log an error message and crash if the kernel reports failure during GC.
We decided to do this instead of just leaking because we don't want people
to get the mistaken impression that running in Rosetta is a supported
configurtion.

The CRASH macro will also hook into CrashReporter, which will tell us if
many (any?) users run into this issue.

kjs/collector.cpp: (KJS::getPlatformThreadRegisters):

2:44 PM Changeset in webkit [20834] by antti

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Layout test for <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

fast/flexbox/flex-hang-expected.checksum: Added.
fast/flexbox/flex-hang-expected.png: Added.
fast/flexbox/flex-hang-expected.txt: Added.
fast/flexbox/flex-hang.html: Added.

WebCore:

Reviewed by Hyatt.

Fix <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

Forcibly distribute remaining pixels if the algorithm is not advancing.

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):

2:37 PM Changeset in webkit [20833] by bdash

2 edits in trunk/WebCore

2007-04-11 Mark Rowe <mrowe@apple.com>

Build fix.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]):

2:21 PM Changeset in webkit [20832] by sfalken

3 edits in branches/Safari-522/WebCore

Merged fix from r20685

2:19 PM Changeset in webkit [20831] by sfalken

2 edits in branches/Safari-522/WebCore

Merged fix from r20675

2:14 PM Changeset in webkit [20830] by sfalken

7 edits
3 copies in branches/Safari-522

Merge fix from r20813

2:14 PM Changeset in webkit [20829] by brmorris

2 edits in S60/trunk/WebKit

bradley, reviewed by SuperMario

DESC: remove Rendundant include to save a warning :)

BrowserView/src/WebKitControl.cpp:

2:14 PM Changeset in webkit [20828] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):

2:11 PM Changeset in webkit [20827] by spadma

2 edits in S60/trunk/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):

2:08 PM Changeset in webkit [20826] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):

2:04 PM Changeset in webkit [20825] by spadma

2 edits in S60/trunk/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):

2:00 PM Changeset in webkit [20824] by pyeh

3 edits in trunk/WebCore

<rdar://problem/5122276> Allow focused frame to fire off notification
Improve accessibility support for Mail WebView embedded Notes.

bridge/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postNotification):
The focused document with the selection change should fire the selection changed notification, not the top level document

bridge/mac/WebCoreAXObject.mm:

(-[WebCoreAXObject accessibilityDescription]):
Allow the name attribute of the html body to be used as the accessibility description

1:26 PM Changeset in webkit [20823] by brmorris

3 edits in S60/trunk/WebKit

bradley, reviewed by nobody (build fix)

DESC: flagged out some includes.

BrowserView/src/WebKitControl.cpp:
ResourceLoader/src/HttpLoaderAcceptHeader.cpp:

1:12 PM Changeset in webkit [20822] by yongjzha

2 edits in S60/branches/3.1m/WebCore

w3liu, reviewed by <yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/css/cssparser.cpp: (CSSParser::parseSheet):

1:11 PM Changeset in webkit [20821] by yongjzha

2 edits in S60/trunk/WebCore

w3liu, reviewed by <yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/css/cssparser.cpp: (CSSParser::parseSheet):

11:19 AM Changeset in webkit [20820] by ggaren

16 edits in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Support for fixing fast/forms/textarea-paste-newline.html.

Changed clients to use new preference specifying whether a Page should
allow pasting through the DOM API, instead of a global flag.

Removed old behavior of always allowing DOM paste in debug builds. In
light of the new preference-based API, that behavior makes no sense anymore.
Instead, developers who want to test paste inside Safari can set the
preference for themselves.

WebCore.exp:
editing/CommandByName.cpp: Removed crazy hack to keep an identically named but invalid copy of the global "pate allowed" flag in this file. (WebCore::Frame::enabledPaste):
editing/JSEditor.cpp: Removed "always allow" behavior for debug builds. (WebCore::JSEditor::queryCommandSupported):
editing/JSEditor.h:
page/Settings.cpp: (WebCore::Settings::setDOMPasteAllowed):
page/Settings.h: (WebCore::Settings::isDOMPasteAllowed):
rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Removed crazy hack to allow DOM paste after this function has been called.

WebKit:

Reviewed by Maciej Stachowiak.

Support for fixing fast/forms/textarea-paste-newline.html.

Added SPI for specifying whether a WebView should allow pasting through the
DOM API.

ChangeLog:
WebKit.xcodeproj/project.pbxproj:
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences standardPreferences]): (-[WebPreferences isDOMPasteAllowed]): (-[WebPreferences setDOMPasteAllowed:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKitTools:

Reviewed by Maciej Stachowiak.

Fixed fast/forms/textarea-paste-newline.html.

This failure was pretty funny. run-webkit-tests kills and respawns
DumpRenderTree once every 1000 runs. Adding a few tests caused
textarea-paste-newline.html to run right at the beginning of DumpRenderTree's
lifetime, before any render tree dumps had occurred. However, WebCore
used a render tree dump as the hook that set a global flag to allow
pasting through the DOM API, so running before any render tree dumps had
occurred caused this test to fail.

DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Explicitly tell WebKit to allow pasting through the DOM API, instead of hoping it will read the tea leaves.

9:36 AM Changeset in webkit [23255] by sullivan

2 edits in branches/WindowsMerge/WebCore

platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markBadGrammar): Keep build going: added stub for this new method

9:28 AM Changeset in webkit [20819] by sullivan

4 edits in trunk/WebCore

Reviewed by Tim Hatcher

fixed <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence

editing/Editor.h: add markBadGrammar, now distinct from markMisspellings

editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): call markMisspellings on one word, and markBadGrammar on entire sentence (WebCore::markMisspellingsOrBadGrammar): new static function, extracted from markMisspellings (WebCore::Editor::markMisspellings): now calls extracted function (WebCore::Editor::markBadGrammar): new method, calls extracted function

page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): update grammar markers for entire new and old sentences

2:35 AM Changeset in webkit [23254] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Fix <rdar://problem/5119803> Web Inspector has no options menu

WebInspector/WebInspector.cpp: (interpreterForFrame): Added. (WebInspector::showOptionsMenu): Implemented. (WebInspector::onCommand): Added. (WebInspector::toggleIgnoreWhitespace): Implemented. (WebInspector::toggleShowUserAgentStyles): Implemented. (WebInspectorWndProc): Added case for WM_COMMAND.
WebInspector/WebInspector.h:

2:23 AM Changeset in webkit [23253] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5056988>
Can not open player on http://radioalice.com

Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past
a '?' character because that would be parsed as the query part of the URL.

plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Make this be more like the mac, chopping off the first 12 characters ("javascript:") and then decoding the remaining characters.

1:59 AM Changeset in webkit [23252] by andersca

2 edits in branches/WindowsMerge/WebCore

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): Initialize m_status.

12:54 AM Changeset in webkit [20818] by mjs

2 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.

kjs/collector.cpp:

12:52 AM Changeset in webkit [20817] by mjs

4 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

move mark and collectOnMainThreadOnly bits into separate bitmaps

This saves 4 bytes per word, allowing shrink of cell size 32,
which leads to a .8% speed improvement on iBench.

This is only feasible because of all the previous changes on the branch.

kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.

12:49 AM Changeset in webkit [23251] by andersca

11 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.

Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
loaded successfully or not.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.

CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Read): (CFDictionaryPropertyBag::Write): Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.

Interfaces/IWebError.idl: Add user info keys.

MarshallingHelpers.cpp: (MarshallingHelpers::LPCOLESTRToCFStringRef):
MarshallingHelpers.h: New function.

WebError.cpp: (WebError::WebError): (WebError::createInstance): Take a property bag.

(WebError::userInfo):
Return the property bag.

WebFrame.cpp: (WebFrame::createPlugin): If the plug-in wasn't found or failed to load, create a WebError with the right user info and call IWebResourceLoadDelegate::plugInFailedWithError.

12:37 AM Changeset in webkit [20816] by mjs

6 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
kjs/function.h:
kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):

Apr 9, 2007:

6:36 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org

(diff)

6:05 PM Changeset in webkit [20815] by adele

1 edit
1 add in trunk/WebKitSite

blog/wp-content/chrome.jpg: Added.

5:55 PM Changeset in webkit [23250] by beidson

4 edits in branches/WindowsMerge

Build fix for my recent OpenSource checkin

5:06 PM Changeset in webkit [20814] by andersca

4 edits in trunk

WebCore:

Reviewed by John.

WebCore.exp: Add ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

Reviewed by John.

<rdar://problem/5081860>
REGRESSION: Select All for standalone image has no visible effect but does change state

<rdar://problem/5081840>
REGRESSION: context menu in white space beyond standalone image is different after Select All

Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:

For full-frame plugins, always return false.
For images, only return true if the selector is copy: and the image has finished loading.

WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]):

5:00 PM Changeset in webkit [20813] by beidson

7 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin

Layout test for the fix for <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

http/tests/navigation/multiple-back-forward-entries-expected.txt: Added.
http/tests/navigation/multiple-back-forward-entries.html: Added.
http/tests/navigation/resources/slow-resource.pl: Added.

WebCore:

Reviewed by Darin

Fixes <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

The original regression was to claim that more loads were the result of a "user gesture" than really
were. A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it
wasn't properly propagated and respected where it should've been.

This patch cleans much of that up. One loose end is the "treatAsUserGesture" flag which is a stop
gap measure to keep "slow redirects" working to create a new history item. In the future, we need
to cleanup the meaning and use of "userGesture" and "lockHistory." This includes integrating them
in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
the Frame load process.

dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true

ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true

loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the delay here, instead of at 3 other different sites that call this method (WebCore::FrameLoader::changeLocation): Set userGesture correctly (WebCore::FrameLoader::urlSelected): Propagate userGesture down (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly (WebCore::FrameLoader::load): (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect, handle the case where we *are* a redirect by updating the previous history item
loader/FrameLoader.h:

4:31 PM Changeset in webkit [20812] by andersca

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail

WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.

3:52 PM Changeset in webkit [20811] by andersca

3 edits in trunk/WebKit

Reviewed by Geoff, Ada and John.

<rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

WebView/WebFrame.mm: (-[WebFrame _isDisplayingStandaloneImage]):
WebView/WebFramePrivate.h: Add _isDisplayingStandaloneImage SPI.

3:30 PM Changeset in webkit [23249] by thatcher

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20810.

<rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
Also makes selecting rows in the style pane happen on mousedown for consistency.

WebInspector/webInspector/inspector.js:

3:14 PM Changeset in webkit [20810] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior. Also makes selecting rows in the style pane happen on mousedown for consistency.

3:11 PM Changeset in webkit [20809] by andersca

1 edit in trunk/LayoutTests/ChangeLog

Add bug number to ChangeLog.

1:07 PM Changeset in webkit [20808] by justing

31 edits in trunk/LayoutTests

Reviewed by ggaren

These were never checked in:

editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.

New results were never checked in after some selection
gap filling fixes:

editing/style/remove-underline-across-paragraph-expected.checksum:
editing/style/remove-underline-across-paragraph-expected.png:
editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
editing/style/remove-underline-across-paragraph-in-bold-expected.png:
editing/style/style-3690704-fix-expected.checksum:
editing/style/style-3690704-fix-expected.png:
editing/style/table-selection-expected.checksum:
editing/style/table-selection-expected.png:
editing/undo/4063751-expected.checksum:
editing/undo/4063751-expected.png:
editing/style/apple-style-editable-mix-expected.checksum:
editing/style/apple-style-editable-mix-expected.png:
editing/inserting/paragraph-separator-in-table-1-expected.checksum:
editing/inserting/paragraph-separator-in-table-1-expected.png:
editing/inserting/paragraph-separator-in-table-2-expected.checksum:
editing/inserting/paragraph-separator-in-table-2-expected.png:

Checking in incorrect results and adding a FIXME that references the
bug that this test demonstrates:

editing/style/smoosh-styles-003-expected.checksum:
editing/style/smoosh-styles-003-expected.png:
editing/style/smoosh-styles-003-expected.txt:
editing/style/smoosh-styles-003.html:

Misspelling marker correctly removed:

editing/deleting/delete-to-select-table-expected.checksum:
editing/deleting/delete-to-select-table-expected.png:

Horizontal rules and parts of table borders were made very slightly
darker, and these results were never updated:

editing/inserting/4278698-expected.checksum:
editing/inserting/4278698-expected.png:
editing/unsupported-content/table-type-after-expected.checksum:
editing/unsupported-content/table-type-after-expected.png:
editing/unsupported-content/table-type-before-expected.checksum:
editing/unsupported-content/table-type-before-expected.png:
editing/deleting/table-cells-expected.checksum:
editing/deleting/table-cells-expected.png:

12:51 PM Changeset in webkit [20807] by andersca

2 edits in trunk/LayoutTests

Reviewed by Mitz.

plugins/resources/open-and-close-window-with-plugin.html: Try to fix the ASSERT on the build bot by scheduling a timeout that schedules a timeout.

11:48 AM Changeset in webkit [20806] by spadma

5 edits in S60/trunk/WebKit

raalexan, reviewed by <spadma>

DESC: removed the webkit warnings
http://bugs.webkit.org/show_bug.cgi?id=13143

BrowserView/src/PluginContentPlayer.cpp:
BrowserView/src/WebKitLoader.cpp:
BrowserView/src/WebKitView.cpp:
ResourceLoader/CacheSrc/HttpCacheManager.cpp:

11:40 AM Changeset in webkit [23248] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Fixed copyrights.

WebInspector/WebInspector.cpp:
WebInspector/WebInspector.h:

11:19 AM Changeset in webkit [20805] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5120801>
http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)

fast/dom/Window/setting-properties-on-closed-window-expected.txt: Added.
fast/dom/Window/setting-properties-on-closed-window.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5120801>
http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)

bindings/js/kjs_window.cpp: (KJS::Window::put): Return early if m_frame is null. A closed window only has one property, "closed" so no properties should be settable in that case.

11:13 AM Changeset in webkit [23247] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Fix two Web Inspector bugs:

The WebView wasn't focused when the inspector first appeared.
Resizing the upper pane did not resize the whole window.

WebInspector/WebInspector.cpp: (WebInspector::show): Focus the WebView. (WebInspector::setFrame): Implemented. (WebInspector::webViewFrame): Implemented.
WebInspector/WebInspector.h:

10:48 AM Changeset in webkit [20804] by spadma

4 edits in S60/trunk/WebKit

borges, reviewed by <sachin>

DESC: Part of S60 task 15095: Removed exporting of header files RecentUrlStore.h. Moved all keys from BrowserUiInternalCRKeys.h to BrowserUiSDKCRKeys.h
http://bugs.webkit.org/show_bug.cgi?id=13310

BrowserView/src/WebKitControl.cpp:
Plugin/src/PluginSkin.cpp:
ResourceLoader/src/HttpLoaderAcceptHeader.cpp:

10:27 AM Changeset in webkit [23246] by aroben

2 edits in branches/WindowsMerge/WebKitWin

WebInspector/WebInspector.cpp: (WebInspector::WebInspector): Removed two fixed FIXMEs and some commented-out code.

10:19 AM Changeset in webkit [23245] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

7:33 AM Changeset in webkit [20803] by yongjzha

2 edits in S60/branches/3.1m/WebCore

2007-04-05 winship <steven.winship@nokia.com>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: ASAA-6Y2BLC - Crash when opening NT dialog twice

fix: set pointer to null so static data is re-initialized

http://bugs.webkit.org/show_bug.cgi?id=13288

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQTextCodec.cpp: (QTextCodec::PrepareForExit):

4:48 AM Changeset in webkit [20802] by andrew

8 edits
4 adds in trunk

2007-04-09 Andrew Wellington <proton@wiretapped.net>

Reviewed by Justin Garcia.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

editing/pasteboard/copy-standalone-image-expected.checksum: Added.
editing/pasteboard/copy-standalone-image-expected.png: Added.
editing/pasteboard/copy-standalone-image-expected.txt: Added.
editing/pasteboard/copy-standalone-image.html: Added.

2007-04-09 Andrew Wellington <proton@wiretapped.net>

Reviewed by Justin Garcia.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

dom/Document.h: Add support for determining if a document is an image (WebCore::Document::isImageDocument):
editing/Editor.cpp: (WebCore::Editor::canCopy): Image documents are copyable (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
loader/ImageDocument.h: (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
platform/Pasteboard.h: Add new writeImage function to pasteboard
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed