Context Navigation

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAllCollection.h: Added. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): (WebCore::JSHTMLAllCollection::toBoolean): (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
bindings/js/JSHTMLCollectionCustom.cpp: Added. (WebCore::getNamedItems): (WebCore::JSHTMLCollection::callAsFunction): (WebCore::JSHTMLCollection::implementsCall): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all):
bindings/js/JSXMLHttpRequest.cpp:
bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp): (WebCore::ImageConstructorImp::construct):
bindings/js/kjs_html.h: (WebCore::ImageConstructorImp::implementsConstruct):
bindings/js/kjs_window.cpp: (KJS::Window::namedItemGetter):
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLCollection.cpp: (WebCore::HTMLCollection::tags):
html/HTMLCollection.h: (WebCore::HTMLCollection::collectionType):
html/HTMLCollection.idl:
html/HTMLOptionsCollection.idl:

8:13 PM Changeset in webkit [22079] by sfalken

1 copy in tags/Safari-522.11.1b

New tag.

8:12 PM Changeset in webkit [22078] by sfalken

1 delete in tags/Safari-522.11.1b

Remove unnecessary tag.

8:07 PM Changeset in webkit [22077] by sfalken

1 copy in tags/Safari-522.11.1b

New tag.

7:46 PM Changeset in webkit [23458] by adachan

2 edits in branches/WindowsMerge/WebKitWin

2007-06-08 Ada Chan <adachan@apple.com>

Reviewed by Hyatt, Adam, and Steve.

Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.

WebView.cpp: (WebView::selectedText):

6:12 PM Changeset in webkit [23457] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Get rid of the Safari part of the query string used for Google searches.

Reviewed by Steve and Ada.

WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

5:25 PM Changeset in webkit [23456] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

If both the old and new WMP plugins are present, remove the old one
so we won't end up choosing it.

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths):

4:37 PM Changeset in webkit [23455] by kmccullo

49 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker, and Sam.

Added and updated licenses.

4:10 PM Changeset in webkit [23454] by hyatt

63 edits in branches/WindowsMerge/WebCore

Update licenses/copyrights for WebCoreWin.

Reviewed by mccullough

3:54 PM Changeset in webkit [23453] by kmccullo

4 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Hyatt.

Added license.
win/Skipped:

WebKitToolsWin:

Reviewed by Hyatt.

Updated license.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h:

1:03 PM Changeset in webkit [22076] by bdakin

2 edits in trunk/LayoutTests

Reviewed by Brady.

Fix for http://trac.webkit.org/projects/webkit/changeset/21738

This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.

http/tests/navigation/relativeanchor-goback-expected.txt:

11:10 AM Changeset in webkit [22075] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

editing/selection/5232159-expected.checksum: Added.
editing/selection/5232159-expected.png: Added.
editing/selection/5232159-expected.txt: Added.
editing/selection/5232159.html: Added.

WebCore:

Reviewed by John.

<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.

9:38 AM Changeset in webkit [22074] by sullivan

2 edits in trunk/WebKit

WebView/WebViewPrivate.h: Added a FIXME

9:37 AM Changeset in webkit [22073] by kevino

4 edits in branches/wx-port-alpha/trunk

Set <debug-runtime-libs> usually defers to <debug-info> for its setting, but in case we have release wx libs, or wxPython libs, we have to adjust the settings to match those.

9:09 AM Changeset in webkit [22072] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Check to make sure the window is fully initialized before running.

8:17 AM Changeset in webkit [22071] by andersca

3 edits in trunk/WebCore

Reviewed by Geoff.

Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction

page/Frame.cpp: (WebCore::Frame::createRootObject): (WebCore::Frame::cleanupScriptObjects):
page/FramePrivate.h:

6:01 AM Changeset in webkit [22070] by lars

2 edits in trunk/WebCore

Forgot to checkin this part in my last submit.

5:44 AM Changeset in webkit [22069] by lars

8 edits
2 adds in trunk/WebKitQt

Reviewed by Zack.

Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.

4:40 AM Changeset in webkit [22068] by rwlbuis

8 edits in branches/feature-branch/WebCore

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12122
SVGPathElement should not inherit from SVGPathParser

Use path builders for building Path and PathSegLists.

3:08 AM Changeset in webkit [22067] by zack

3 edits in trunk/JavaScriptCore

Fix the Qt build

2:18 AM Changeset in webkit [22066] by eseidel

4 edits in branches/feature-branch/WebCore

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.
http://bugs.webkit.org/show_bug.cgi?id=8823

Layout test is blocked by http://bugs.webkit.org/show_bug.cgi?id=14027

css/svg.css:
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
ksvg2/svg/SVGAElement.h:

12:17 AM Changeset in webkit [22065] by justing

7 edits in trunk

WebCore:

Reviewed by Tristan.

<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

WebCore.exp: Added clearUndoRedoOperations.
page/Page.cpp: (WebCore::Page::clearUndoRedoOperations): Added.
page/Page.h:

WebKit:

Reviewed by Tristan.

<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

WebView/WebView.mm: (-[WebView _clearUndoRedoOperations]): Added.
WebView/WebViewPrivate.h:

Jun 7, 2007:

11:50 PM Changeset in webkit [22064] by bdash

3 edits in trunk/WebKitSite

2007-06-08 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Hyatt.

Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
than doing server-side user agent checks. This resolves an issue some people were seeing where
caching would lead to a page generated for an Internet Explorer user being served to a Safari
user. The visible symptom of this was many of the graphics were missing.

blog/wp-content/themes/webkit/header.php:
header.inc:

11:38 PM Changeset in webkit [22063] by oliver

2 edits in trunk/WebKit

Reviewed by Sam "The Intern" Weinig.

Don't be overzealous with the input checks, firstRectForCharacterRange
can be determined even when there is not an active editable region.

This unbreaks editing/input/range-for-empty-document which was broken
by aforementioned overzealousness.

WebView/WebHTMLView.mm: (-[WebHTMLView firstRectForCharacterRange:]):

10:25 PM Changeset in webkit [22062] by hyatt

2 edits in trunk/WebCore

Fix crash. Null check layer. Bug 13984.

Reviewed by andersca

WebCore.xcodeproj/project.pbxproj:
page/FrameView.cpp: (WebCore::FrameView::windowClipRectForLayer):

9:16 PM Changeset in webkit [22061] by sfalken

1 copy in tags/Safari-522.10.2b

New tag.

9:15 PM Changeset in webkit [22060] by sfalken

1 delete in tags/Safari-522.10.2b

Remove unnecessary tag.

9:14 PM Changeset in webkit [22059] by sfalken

1 copy in tags/Safari-522.10.2b

New tag.

8:07 PM Changeset in webkit [22058] by oliver

4 edits in trunk

WebCore:

Reviewed by Justin.

Remove incorrect assertions.

These assertions were made on the assumption that
TSM would always call with a range that was contained
by an editable region.

TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
event that is otherwise unrelated to editing, which may
be outside the current editing region, triggering these
assertions.

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]):

WebKit:

Reviewed by Justin.

Add checks to make sure we don't try to create, use
or return invalid ranges to TSM when it calls us despite
not currently being in an editable region.

WebView/WebHTMLView.mm: (isTextInput): (-[WebHTMLView textStorage]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView attributedSubstringFromRange:]):

5:02 PM Changeset in webkit [22057] by justing

8 edits in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)

Corrected the description and added a FIXME:

editing/unsupported-content/table-delete-003-expected.checksum:
editing/unsupported-content/table-delete-003-expected.png:
editing/unsupported-content/table-delete-003-expected.txt:
editing/unsupported-content/table-delete-003.html:

WebCore:

Reviewed by John.

<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): We wouldn't expand the selection to include a special element at the start of the selection unless the end of the selection was at the end of a special element. Avoid a special element at the start as long as it's fully selected. Ditto for the end.
editing/htmlediting.cpp: (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement):

4:16 PM Changeset in webkit [22056] by andersca

10 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.

bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::CInstance):
bindings/c/c_instance.h:
bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance):
bindings/jni/jni_instance.h:
bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance):
bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance):
bindings/runtime.h:

3:31 PM Changeset in webkit [22055] by andersca

4 edits in trunk/JavaScriptCore

Reviewed by Adam.

Don't use a JavaInstance to store the field when all we want to do is to keep the field
from being garbage collected. Instead, use a JObjectWrapper.

bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaField::JavaField): (KJS::Bindings::JavaField::operator=):

2:32 PM Changeset in webkit [22054] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

GetRect()'s x and y are relative to the WebView's position in the parent control, but for the DC we just want the bounds local to the control itself.

2:28 PM Changeset in webkit [23452] by weinig

2 edits in branches/WindowsMerge/WebCore

Fix build.

WebCore.vcproj/WebCore.vcproj:

2:27 PM Changeset in webkit [22053] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Now that each unimplemented call fires only once, re-enable ones that used to fire often.

2:26 PM Changeset in webkit [22052] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

Disable frames support until I can track down what is causing the google.com iframe not to be destroyed.

2:25 PM Changeset in webkit [22051] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Use the existing gc to ensure the context is setup properly.

2:24 PM Changeset in webkit [22050] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Improved clipping when dealing with frames.

2:23 PM Changeset in webkit [22049] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/page/FrameView.cpp

Remove the midLayout assert as done in TOT.

1:58 PM Changeset in webkit [22048] by weinig

22 edits
1 delete in trunk

LayoutTests:

Reviewed by Anders.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.

WebCore:

Reviewed by Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
bindings/js/JSHTMLElementWrapperFactory.h:
bindings/js/JSHTMLOptionElementConstructor.cpp:
bindings/js/JSNamedNodeMapCustom.cpp:
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::mark): (WebCore::toJS):
bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
bindings/js/JSSVGElementWrapperFactory.h:
bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):
bindings/js/kjs_binding.h:
bindings/js/kjs_dom.cpp: (WebCore::toAttr):
bindings/js/kjs_dom.h:
bindings/js/kjs_domnode.h: Removed.
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
dom/Node.h: (WebCore::Node::parentElement):
dom/Node.idl:

1:36 PM Changeset in webkit [22047] by sfalken

1 copy in tags/Safari-522.10.1b

New tag.

1:35 PM Changeset in webkit [22046] by sfalken

1 delete in tags/Safari-522.10.1b

Remove unnecessary tag.

1:18 PM Changeset in webkit [22045] by sfalken

1 copy in tags/Safari-522.10.1b

New tag.

11:34 AM Changeset in webkit [22044] by adele

1 edit in trunk/WebKitSite/coding/lgpl-license.html

10:00 AM Changeset in webkit [23451] by andersca

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Correct bug number

9:56 AM Changeset in webkit [23450] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

<rdar://problem/5252908>
Shockwave plug-in content crashes.

Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave
does not use CallWndProc but instead treats the WNDPROC as a function.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::quirks):

1:39 AM Changeset in webkit [23449] by weinig

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam Roben.

Make the inspector compile again.

WebInspector/WebInspector.cpp: (setFocusedDOMNodeCallback): (focusedDOMNodeCallback): (setRootDOMNodeCallback): (rootDOMNodeCallback):

1:07 AM Changeset in webkit [22043] by weinig

2 edits in trunk/WebCore

Another Gdk and Qt build fix.

WebCore.pro:

12:59 AM Changeset in webkit [23448] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix for the build fix.

WebCore.vcproj/WebCore.vcproj:

12:48 AM Changeset in webkit [22042] by weinig

2 edits in trunk/WebCore

Gdk and Qt build fix.

WebCore.pro:

12:05 AM Changeset in webkit [23447] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

Jun 6, 2007:

10:52 PM Changeset in webkit [22041] by bdash

1 copy in tags/Safari-4522.10.1

New tag.

10:51 PM Changeset in webkit [22040] by bdash

1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

9:33 PM Changeset in webkit [23446] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
<rdar://problem/5243655> Flash download page doesn't recognize Boomer

Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
This fixes the Acrobat Reader download.

WebView.cpp: (WebView::userAgentForKURL):

9:28 PM Changeset in webkit [22039] by weinig

33 edits
10 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

Autogenerate JSNodeList and JSNamedNodeMap.
Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor into their own files.
Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere to convention and allow easier code generation.
Add JS constructors for JSNodeList and JSNamedNodeMap.
Moved more toJS methods into the correct (corresponding) header files.
Cleaned up code in order for changes to work.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMExceptionConstructor.cpp: Added. (WebCore::): (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor): (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot): (WebCore::JSDOMExceptionConstructor::getValueProperty): (WebCore::getDOMExceptionConstructor):
bindings/js/JSDOMExceptionConstructor.h: Added. (WebCore::JSDOMExceptionConstructor::classInfo):
bindings/js/JSDOMWindowCustom.cpp: Added. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): (WebCore::toJS):
bindings/js/JSEventTargetNode.cpp: Added. (WebCore::JSEventTargetNode::JSEventTargetNode): (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty): (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::pushEventHandlerScope): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction): (WebCore::toEventTargetNode):
bindings/js/JSEventTargetNode.h: Added. (WebCore::JSEventTargetNode::):
bindings/js/JSHTMLElementCustom.cpp:
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
bindings/js/JSHTMLOptionElementConstructor.cpp:
bindings/js/JSNamedNodeMapCustom.cpp: Added. (WebCore::JSNamedNodeMap::canGetItemsForName): (WebCore::JSNamedNodeMap::nameGetter):
bindings/js/JSNamedNodesCollection.cpp: Added. (WebCore::): (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter): (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
bindings/js/JSNamedNodesCollection.h: Added. (WebCore::JSNamedNodesCollection::classInfo):
bindings/js/JSNodeCustom.cpp: Added. (WebCore::toJS):
bindings/js/JSNodeListCustom.cpp: Added. (WebCore::JSNodeList::callAsFunction): (WebCore::JSNodeList::implementsCall): (WebCore::JSNodeList::canGetItemsForName): (WebCore::JSNodeList::nameGetter):
bindings/js/kjs_dom.cpp:
bindings/js/kjs_dom.h:
bindings/js/kjs_domnode.h:
bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_html.cpp: (KJS::JSHTMLCollection::getNamedItems):
bindings/js/kjs_html.h:
bindings/js/kjs_window.cpp: (WebCore::toJS):
bindings/js/kjs_window.h:
bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
bridge/mac/WebCoreAXObject.mm:
dom/Attr.idl:
dom/CharacterData.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:
dom/NodeList.idl:
page/DOMWindow.idl:

8:59 PM Changeset in webkit [23445] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

8:42 PM Changeset in webkit [22038] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Oliver.

editing/pasteboard/5245519-expected.checksum: Added.
editing/pasteboard/5245519-expected.png: Added.
editing/pasteboard/5245519-expected.txt: Added.
editing/pasteboard/5245519.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()

If the user pastes something into a region that ends up being
invisible, or if the pasted content contains style spans
that are render-less, we'll crash when we try to remove
redundant styles from style spans.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Add null checks.

8:11 PM Changeset in webkit [22037] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

editing/selection/4889598-expected.checksum: Added.
editing/selection/4889598-expected.png: Added.
editing/selection/4889598-expected.txt: Added.
editing/selection/4889598.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

The caret would disappear when moving from content above or below
a ToDo if that ToDo doesn't have any content in it with the same
x position as the caret. That's because closestLeafChildForXPos
would return non-editable leaves, and which turn into non-editable
VisiblePositions, which are invisible.

editing/visible_units.cpp: (WebCore::previousLinePosition): Ask closestLeafForXPos to only return editable leaves. (WebCore::nextLinePosition): Ditto.
rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf): Added. (WebCore::RootInlineBox::closestLeafChildForXPos): If requested, return the closest editable leaf. Removed an early return if the position is before the first leaf, it's not really much of an optimization.
rendering/RootInlineBox.h:

7:36 PM Changeset in webkit [22036] by weinig

2 edits in trunk/WebCore

Reviewed by Anders.

Fix release build.

bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.

5:54 PM Changeset in webkit [22035] by weinig

13 edits
2 moves
1 add in trunk

LayoutTests:

Reviewed by Hyatt.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

Completely generate JSNodeFilter.
Move JSNodeFilterCondition into its own file

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
bindings/js/JSNodeFilterCustom.cpp: Added. (WebCore::JSNodeFilter::mark): (WebCore::toNodeFilter):
bindings/js/kjs_dom.cpp:
bindings/js/kjs_traversal.cpp: Removed.
bindings/js/kjs_traversal.h: Removed.
bindings/js/kjs_window.cpp:
bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
bindings/scripts/CodeGeneratorJS.pm:
dom/Document.cpp: (WebCore::Document::createNodeIterator): (WebCore::Document::createTreeWalker):
dom/Document.h:
dom/NodeFilter.idl:

4:40 PM WebKit Team edited by tristan@otierney.net

(diff)

4:34 PM Changeset in webkit [22034] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20951.

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

WebView/WebFrame.mm: (-[WebFrame DOMDocument]):

3:37 PM Changeset in webkit [22033] by hyatt

4 edits in trunk/WebKit

Make sure to hand back a script object for webkit plugins (the container
view forwards to its plugin child).

Reviewed by sullivan

Plugins/WebKitPluginContainerView.h:
Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView objectForWebScript]):

12:40 PM Changeset in webkit [22032] by eseidel

8 edits
4 adds in branches/feature-branch

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Make SVG (mostly) support CSS outline property (and thus focus rings)
http://bugs.webkit.org/show_bug.cgi?id=10849

Test: svg/custom/focus-ring.svg

rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
rendering/RenderPath.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::addFocusRingRects):
rendering/RenderSVGImage.h:

11:42 AM Changeset in webkit [22031] by weinig

2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
[Drosera] Items in the file list don't get un-highlighted when
files are selected from the file drop-down

Drosera/debugger.js: currentFile was getting modified before file in the file browser got un-highlighted. Changed the order in which the functions execute.

11:14 AM Changeset in webkit [22030] by weinig

2 edits in trunk/WebCore

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=14017
Cairo: Unwanted gradient effect for small stretched images

platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to work around the issue. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):

11:02 AM Changeset in webkit [22029] by brmorris

2 edits in S60/trunk/WebCore

brmorris, reviewed by nobody

DESC: regen WebCore_sdkU.DEF

BWINS/WebCore_sdkU.DEF:

10:46 AM Changeset in webkit [23444] by andersca

6 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info

win/Skipped: Remove tests that now succeed, move one test that fails for another reason.

WebKitToolsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Use different plugin dirs depending on the build configuration, so that a release build of WebKit won't end up loading a debug build of the test plugin.

Print out an error message if the WebView can't be created.

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Use an rc file that's been generated by Visual C++, since the previous hand-written one had some problem.

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Put the plugin in a different directory depending on the release configuration.

10:25 AM Changeset in webkit [22028] by eseidel

7 edits
2 adds in branches/feature-branch/WebCore

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by weinig.

Break out common SVG rendering logic into prepareToRenderSVGContent in SVGRenderSupport

No test cases should be changed by this.

WebCore.xcodeproj/project.pbxproj:
rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): (WebCore::RenderPath::paint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::requiresLayer): (WebCore::RenderSVGContainer::isOutermostSVG): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::applyContentTransforms): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::viewportTransform): (WebCore::RenderSVGContainer::absoluteTransform):
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translationForAttributes):
rendering/SVGRenderSupport.cpp: Added. (WebCore::prepareToRenderSVGContent):
rendering/SVGRenderSupport.h: Added.
rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes):

7:47 AM Changeset in webkit [22027] by lars

11 edits
3 adds in trunk

Reviewed by Zack

Add an API to create and load plugins.
Don't include moc files by hand anymore, rather let
qmake handle them.

3:55 AM Changeset in webkit [22026] by bdash

2 edits in trunk/WebKitTools

2007-06-06 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=13988
Bug 13988: Colon in file path crashes WebKit Nightly

The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
the bundled WebKit framework. Both of these variables are interpreted as containing a
colon-delimited list of paths. There is no escaping mechanism defined, so if we detect
a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
when we execute Safari.

WebKitLauncher/main.m: (main):

3:11 AM Changeset in webkit [22025] by rwlbuis

6 edits
4 adds in branches/feature-branch

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=13976
getPresentationAttribute not implemented

Implement getPresentationAttribute.

2:45 AM Changeset in webkit [22024] by bdash

2 edits in trunk/WebCore

2007-06-06 Mark Rowe <mrowe@apple.com>

Qt build fix.

rendering/RenderTextControl.cpp: Fix case of #include filename.

2:01 AM Changeset in webkit [22023] by lars

4 edits
2 adds in trunk/WebCore

Reviewed by Maciej.

Define WTF_USE_NPOBJECT for Qt. Fix includes
in HTMLPluginElement and add proper forwarding headers
from JavaScriptCore.

1:46 AM Changeset in webkit [22022] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

Remove bogus assert that is hit depressingly often.

12:24 AM Changeset in webkit [22021] by eseidel

6 edits in branches/feature-branch/WebCore

2007-06-06 Rob Buis <buis@kde.org>

Reviewed by olliej and eric.

http://bugs.webkit.org/show_bug.cgi?id=12430
SVG has two transform parsers when it should have one.

Refactor SVGTransformable parser so SVGAnimateTransformElement can reuse it better.

ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGTransformable.cpp: (WebCore::): (WebCore::SVGTransformable::parseTransformValue): (WebCore::SVGTransformable::parseTransformAttribute):
ksvg2/svg/SVGTransformable.h:

12:05 AM Changeset in webkit [22020] by hyatt

2 edits in trunk/WebCore

Bulletproof windowClipRect, since it can be called at crazy times.
Part of fix for 13972.

Reviewed by olliej

bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):

12:04 AM Changeset in webkit [22019] by hyatt

6 edits
2 adds in trunk/WebKit

Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
Make sure that calls to [NSView visibleRect] will do the right thing for both
Netscape plugins and WebKit plugins.

Reviewed by olliej

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView isOpaque]):
Plugins/WebKitPluginContainerView.h: Added.
Plugins/WebKitPluginContainerView.mm: Added. (-[WebKitPluginContainerView initWithFrame:DOMElement:]): (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
Plugins/WebPluginController.mm: (-[WebPluginController destroyAllPlugins]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):

Jun 5, 2007:

9:27 PM Changeset in webkit [22018] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageWx.cpp

Fix typo.

9:17 PM Changeset in webkit [22017] by bdash

2 edits in trunk/WebCore

2007-06-05 MorganL <morganl.webkit@yahoo.com>

Reviewed by Dave Hyatt.

Fixes http://bugs.webkit.org/show_bug.cgi?id=14008

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):

8:17 PM Changeset in webkit [22016] by bdash

1 copy in tags/Safari-4522.10

New tag.

8:14 PM Changeset in webkit [22015] by bdash

3 edits in branches/Safari-522

Versioning.

7:36 PM Changeset in webkit [22014] by kmccullo

1 edit in trunk/WebCore/ChangeLog

Reviewed by.

Respelling Oliver's name right.

7:32 PM Changeset in webkit [22013] by kmccullo

3 edits in trunk/WebCore

Reviewed by Mark and Olliver.

http://bugs.webkit.org/show_bug.cgi?id=13352 REGRESSION: Gmail hangs on send message.
Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary

html/HTMLFormElement.cpp: (WebCore::getUniqueBoundaryString):

7:29 PM Changeset in webkit [22012] by bdash

3 edits in branches/Safari-522/WebCore

2007-06-06 Mark Rowe <mrowe@apple.com>

Build fix. Merge in a portion of r20802 that a merged change appears to depend on.

6:05 PM Changeset in webkit [22011] by sfalken

1 copy in tags/Safari-522.9.1b

New tag.

5:30 PM Changeset in webkit [22010] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21623.

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

5:30 PM Changeset in webkit [22009] by bdash

3 edits in branches/Safari-522/WebCore

Merge in r21480.

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.

This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.

5:29 PM Changeset in webkit [22008] by bdash

3 edits
2 adds in branches/Safari-522

Merge r21423.

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Layout test for x-mac-roman character encoding.

fast/encoding/xmacroman-encoding-test-expected.txt: Added.
fast/encoding/xmacroman-encoding-test.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/5195473> REGRESSION: "Curly quote" fails to
be displayed correctly even when META tag specifies charset=x-mac-roman

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the xmacroman encoding

5:29 PM Changeset in webkit [22007] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20812.

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail

WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.

5:28 PM Changeset in webkit [22006] by bdash

2 edits in branches/Safari-522/WebCore

Merge r21117.

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window

On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

5:28 PM Changeset in webkit [22005] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21080.

Reviewed by Oliver.

use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.

The only exception is destructors, since delete doesn't know how to use a custom calling convention.

kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):

5:28 PM Changeset in webkit [22004] by bdash

4 edits
1 add in branches/Safari-522/JavaScriptCore

Merge r21064.

Reviewed by Geoff.

compile most of JavaScriptCore as one file for 4% JS iBench speed improvement

JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
kjs/AllInOneFile.cpp: Added.
kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"

5:27 PM Changeset in webkit [22003] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21050.

Build fix, not reviewed.

kjs/collector.h: Fix struct/class mismatch.

5:27 PM Changeset in webkit [22002] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21048.

Reviewed by Darin.

raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.

kjs/collector.cpp:

5:27 PM Changeset in webkit [22001] by bdash

4 edits in branches/Safari-522/JavaScriptCore

Merge r21047.

Reviewed by Darin and Geoff.

move mark and collectOnMainThreadOnly bits into separate bitmaps

This saves 4 bytes per cell, allowing shrink of cell size to 32,
which leads to a .8% speed improvement on iBench.

This is only feasible because of all the previous changes on the branch.

kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.

5:27 PM Changeset in webkit [22000] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21034.

Build fix.

kjs/regexp_object.h: RegExpObjectImpPrivate is a struct, not a class.

5:26 PM Changeset in webkit [21999] by bdash

7 edits in branches/Safari-522/JavaScriptCore

Merge r21032.

Reviewed by Darin.

shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
kjs/function.h:
kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.

5:26 PM Changeset in webkit [21998] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21031.

Reviewed by Darin.

shrink RegexpObjectImp by 4 bytes

Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.

kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
kjs/regexp_object.h:

5:26 PM Changeset in webkit [21997] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21030.

Reviewed by Oliver.

change to 1-bit bitfields instead of 8-bit, this turns out to lead to a .51% speedup on JS iBench

The 1-bit bitfields are actually faster than just plain bools, at least on Intel (go figure).

kjs/property_map.h:

5:25 PM Changeset in webkit [21996] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21029.

Reviewed by Darin.

shrink ArrayInstance objects by 4 bytes http://bugs.webkit.org/show_bug.cgi?id=13386

I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

kjs/array_instance.h: (KJS::ArrayInstance::capacity): Get it from the secret stash
kjs/array_object.cpp: (allocateStorage): New function to encapsulate allocating the storage with extra space ahead for the capacity. (reallocateStorage): ditto for realloc (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):

5:25 PM Changeset in webkit [21995] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21025.

Reviewed by Darin.

fix test failures / crashes on PPC

kjs/property_map.h: Make the bool fields explicitly 8-bit bitfields, since bool is a full word there otherwise :-(

5:25 PM Changeset in webkit [21994] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21024.

Reviewed by Darin.

fix more test case failures

bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray): inherit from JSObject instead of ArrayInstance; it turns out that this class only needs the prototype and classInfo from ArrayInstance, not the actual class itself, and it was too big otherwise. (RuntimeArray::getOwnPropertySlot):
bindings/runtime_array.h:

5:25 PM Changeset in webkit [21993] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21023.

Reviewed by Darin.

fix some test failures

bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl, otherwise this is too big (RuntimeMethod::getOwnPropertySlot):
bindings/runtime_method.h:

5:24 PM Changeset in webkit [21992] by bdash

6 edits in branches/Safari-522/JavaScriptCore

Merge r21019.

Reviewed by Darin.

discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup) http://bugs.webkit.org/show_bug.cgi?id=13385

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.

This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.

Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).

kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
kjs/function.h:
kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

5:24 PM Changeset in webkit [21991] by bdash

4 edits in branches/Safari-522/JavaScriptCore

Merge r21018.

Reviewed by Darin.

shrink PropertyMap by 8 bytes and therefore shrink CELL_SIZE to 40 (for 32-bit; similar shrinkage for 64-bit) http://bugs.webkit.org/show_bug.cgi?id=13384

Inspired by similar changes by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.

This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.

kjs/collector.cpp: (KJS::):
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):

5:24 PM Changeset in webkit [21990] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21017.

Reviewed by Darin.

change blocks to 64k in size, and use various platform-specific calls to allocate at 64k-aligned addresses http://bugs.webkit.org/show_bug.cgi?id=13383

kjs/collector.cpp: (KJS::allocateBlock): New function to allocate 64k of 64k-aligned memory (KJS::freeBlock): Corresponding free (KJS::Collector::allocate): (KJS::Collector::collect):

5:23 PM Changeset in webkit [21989] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21015.

Reviewed by Darin and Geoff.

remove the concept of oversize objects, now that there aren't any (for now only enforced with an assert). http://bugs.webkit.org/show_bug.cgi?id=13382

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.

kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.

5:23 PM Changeset in webkit [21988] by bdash

4 edits in branches/Safari-522/WebCore

Merge r21014.

Reviewed by Darin and Geoff.

move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it

It was the only remaining JSObject subclass to use the oversize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.

No significant effect on JS iBench.

bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
bindings/js/kjs_window.h:

5:22 PM Changeset in webkit [21987] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20991.

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=13428 REGRESSION (r20973-r20976): Failing ecma/Array/15.4.4.5-3.js

fix http://bugs.webkit.org/show_bug.cgi?id=13429 REGRESSION (r20973-r20976): Crashing in fast/dom/plugin-attributes-enumeration.html

kjs/array_object.cpp: (ArrayInstance::sort): Free the old storage, not the new one.

5:22 PM Changeset in webkit [21986] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20977.

Not reviewed, build fix.

fix build problem with last change - -O3 complains more about uninitialized variables

pcre/pcre_compile.c: (compile_branch): (pcre_compile2):

5:22 PM Changeset in webkit [21985] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r20974.

Reviewed by Darin.

<rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)

kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
kjs/config.h:

5:21 PM Changeset in webkit [21984] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20973.

Reviewed by Darin.

bump optimization flags up to -O3 for 1% JS iBench speed improvement

Configurations/Base.xcconfig:

5:09 PM Changeset in webkit [21983] by sfalken

2 edits in branches/Safari-522/WebCore

Merged fix from r21975.

2:01 PM Changeset in webkit [21982] by andersca

2 edits in trunk/WebCore

Build fix.

xml/xmlhttprequest.cpp: (WebCore::isValidToken):

1:47 PM Changeset in webkit [21981] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
fast/dom/xmlhttprequest-invalid-values.html: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

xml/xmlhttprequest.cpp: (WebCore::isValidToken): (WebCore::isValidHeaderValue): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::setRequestHeader):

1:39 PM Changeset in webkit [21980] by spadma

26 edits in S60/trunk

w3liu, reviewed by Sachin

DESC: 3.2 widget flag changes.
http://bugs.webkit.org/show_bug.cgi?id=13939

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::CreateWidgetExtensionL):
BrowserCore/Formcontrols/src/FControlFileInputSkin.cpp: (CFormFileInputSkin::ActivateL):
BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
BrowserView/inc/webkitbridge.h:
BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::FormDataManagerHandlerL): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL): (CWebKitControl::CWebKitControl): (CWebKitControl::ConstructL): (CWebKitControl::~CWebKitControl): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::SyncCancelL): (CWebKitControl::HistoryView): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ForegroundEvent): (CWebKitControl::CreateWidgetExtensionL):
BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
BrowserView/src/webkitbridge.cpp: (CWebKitBridge::createWidgetMenuItemObject):
Plugin/inc/PluginHandler.h:
Plugin/inc/PluginSkin.h:
Plugin/inc/PluginWin.h:
Plugin/inc/npapi.h:
Plugin/src/NpnImplementation.cpp: (NpnGetValue):
Plugin/src/PluginHandler.cpp:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::PluginScriptableObject):
Plugin/src/PluginWin.cpp: (CPluginWin::PluginScriptableObject):
group/BrowserView.mmp:
group/Plugin.mmp:
group/formcontrols.mmpi:
group/webkit.mmp:

1:33 PM Changeset in webkit [21979] by weinig

11 edits in trunk/WebCore

Reviewed by Geoff.

Optimize JSCSSStyleDeclaration after performance regression in r21854.

Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName() functions.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::canGetItemsForName):
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::canGetItemsForName):
bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::canGetItemsForName):
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):
bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::canGetItemsForName):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSStyleDeclaration.idl:

12:53 PM BuildingGdk edited by alp@atoker.com

Update "Code layout" section (diff)

12:20 PM Changeset in webkit [21978] by eseidel

4 edits in branches/feature-branch/WebCore

2007-06-05 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Commit files missing from previous commit, oops!

platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

Jun 4, 2007:

7:49 PM Changeset in webkit [21977] by sfalken

1 copy in tags/Safari-522.8.10b

New tag.

6:09 PM BuildingGdk edited by jdahlin@async.com.br

(diff)

5:15 PM Changeset in webkit [21976] by oliver

3 edits in trunk/WebKit

Reviewed by Geoff and Justin.

Fix for <rdar://problem/5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/5245964> Safari hangs for several
seconds when trying to select text using mouse

This is a by product of the textStorage hack used to fix
rdar://problem/5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.

This check should really have been present in the original
patch.

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):

5:10 PM Changeset in webkit [21975] by andersca

2 edits in trunk/WebCore

Reviewed, tweaked and landed by Anders.

<rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted

Null check the provisional document loader. If an application stops the load
inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

4:43 PM Changeset in webkit [21974] by bdash

6 edits in trunk/WebCore

2007-06-04 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=13986
Cairo graphics fixes and cleanups

platform/graphics/ImageBuffer.h:
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::surface): Provide surface() accessor.
platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::rotate): Convert from degrees to radians to fix rotation.
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Add save/restore. (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to avoid further confusion.
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do not describe a point/size but rather the two control points of the rectangular region. (WebCore::Path::contains): Remove needless casts.

4:40 PM Changeset in webkit [21973] by bdash

2 edits in trunk/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.

4:37 PM Changeset in webkit [21972] by bdash

2 edits in tags/Safari-5522.8.3/WebKitTools

Roll out change landed in the wrong place.

4:36 PM Changeset in webkit [21971] by bdash

2 edits in tags/Safari-5522.8.3/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.

2:49 PM Changeset in webkit [21970] by yongjzha

2 edits in S60/trunk/WebKit

yadavall, reviewed by <yongjun.zhang@nokia.com>

DESC: Remove circular dependency between UI RSS file and engine
http://bugs.webkit.org/show_bug.cgi?id=13994

BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::NewL): (CWidgetExtension::~CWidgetExtension): (CWidgetExtension::LaunchApplicationL): (CWidgetExtension::OpenApplication): (CWidgetExtension::SetPreferenceForKey): (CWidgetExtension::AddOptionMenuItemsL): (CWidgetExtension::MenuItemSelected): (CWidgetExtension::SetParamL): (CWidgetExtension::AddOptionsMenuItem): (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::Append): (CWidgetExtension::DeleteMenuItem): (CWidgetExtension::ReplaceMenuItem): (CWidgetExtension::MenuItem): (CWidgetExtension::GetFromMenuItemCollection): (CWidgetExtension::SetDimmed): (CWidgetExtension::SetMenuItemObserver): (CWidgetExtension::MenuItemObserver): (CWidgetExtension::MenuObserver): (CWidgetExtension::RightKeyObserver): (CWidgetExtension::FindNodeById): (CWidgetExtension::FindNodeByText):

2:27 PM Changeset in webkit [21969] by weinig

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix the buildbot.

rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):

11:39 AM Changeset in webkit [21968] by justing

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Demonstrates bug:

editing/selection/5241148-expected.txt: Added.
editing/selection/5241148.html: Added. Updated to reflect new equivalents for positions before/after tables:
editing/selection/click-before-and-after-table-expected.txt:
editing/selection/click-before-and-after-table.html:

WebCore:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Return valid equivalents from these methods (no [img, 1] for
example). ActivEdit was using positions returned from these
methods to create new DOM Ranges.

editing/SelectionController.cpp: (WebCore::SelectionController::baseNode): (WebCore::SelectionController::baseOffset): (WebCore::SelectionController::extentNode): (WebCore::SelectionController::extentOffset): (WebCore::SelectionController::anchorNode): (WebCore::SelectionController::anchorOffset): (WebCore::SelectionController::focusNode): (WebCore::SelectionController::focusOffset):
editing/SelectionController.h:

9:17 AM BuildingQtOnLinux edited by bero@arklinux.org

Add gcc 4.2 incompatibility workaround (diff)

6:41 AM Changeset in webkit [21967] by rwlbuis

2 edits in trunk/WebCore

Fix the svg experimental build.

5:15 AM BuildingQtOnLinux edited by bero@arklinux.org

Add qmake build dependency and note about having qmake in the PATH (diff)

5:01 AM BuildingQtOnLinux edited by bero@arklinux.org

Add flex to list of build deps (diff)

4:51 AM BuildingQtOnLinux edited by bero@arklinux.org

update headline to reflect the fact that Ark instructions are included (diff)

3:43 AM BuildingQtOnLinux edited by bero@arklinux.org

Add Ark Linux build instructions where they differ from *ubuntu's … (diff)

2:41 AM Changeset in webkit [21966] by bdash

86 edits
428 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Upgrade to WordPress 2.2. I didn't go to the effort of tracking down files
present in the old version which have since been removed, but it's unlikely
they'll ever cause a problem.

1:30 AM Changeset in webkit [21965] by bdash

1 edit
11 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Add graphics used by existing blog posts into SVN.

blog/wp-content/rotate.png: Added.
blog/wp-content/drosera.png: Added.
blog/wp-content/hitlist.png: Added.
blog/wp-content/svgtextmini.png: Added.
blog/wp-content/svgtextmini_01.png: Added.
blog/wp-content/textfield_screenshot.jpg: Added.
blog/wp-content/Picture9.png: Added.
blog/wp-content/svgtext.png: Added.
blog/wp-content/webInspector.png: Added.
blog/wp-content/rotate.svg: Added.
blog/wp-content/chucknorris.png: Added.

1:04 AM Changeset in webkit [21964] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6170
CSS1: Properties for :first-letter aren't recalculated on color change

Mark styles with first-letter as unique.

Jun 3, 2007:

10:46 PM Changeset in webkit [23443] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/5246665> Drop down lists are not drawn on volvocars.us

WebView.cpp: (WebView::userAgentForKURL):

7:05 PM Changeset in webkit [21963] by sfalken

1 copy in tags/Safari-522.8.8b

New tag.

5:52 PM Changeset in webkit [21962] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageWx.cpp

We need to clip ourselves when drawing tiled (e.g. background) images.

5:16 PM Changeset in webkit [23442] by sfalken

3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Update to last fix.
Invalidate a list of rects rather than unioning them.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): (WebCore::PluginViewWin::invalidateRect):
plugins/win/PluginViewWin.h:

4:28 PM Changeset in webkit [21961] by kevino

4 edits in branches/wx-port-alpha/trunk

For Windows, match the debug-runtime-libs setting with the one the wx build is using.

4:25 PM Changeset in webkit [21960] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

Send the load complete message when the document load completes, as wxWebView currently only monitors overall load progress.

2:01 PM Changeset in webkit [23441] by sfalken

3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

<rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com

Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
starving other HWNDs.

This code defers the invalidate through a WebCore::Timer. We could have used a Windows ::SetTimer
to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): Added. (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash. (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
plugins/win/PluginViewWin.h:

1:31 PM Changeset in webkit [21959] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Remove debugging statement.

1:25 PM Changeset in webkit [21958] by kevino

3 edits in branches/wx-port-alpha/trunk/JavaScriptCore

Fixing a couple defines, and removing an unused sources tag in JSCore project file.

1:05 PM Changeset in webkit [21957] by kevino

4 edits in branches/wx-port-alpha/trunk/WebKit/wx

Better support for page load progress indicators, along with support for getting the page title.

Jun 2, 2007:

7:56 PM Changeset in webkit [23440] by sfalken

3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update last fix to use startsWith instead of strcmpi.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL):

5:21 PM WikiStart edited by pewtermoose@gmail.com

(diff)

5:20 PM FAQ created by pewtermoose@gmail.com

11:05 AM Changeset in webkit [23439] by sfalken

3 edits in branches/WindowsMerge/WebCore

Reviewed by gramps.

Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
Make "javascript" URL scheme string compare case insensitive.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Use strcmpi.
plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.

Jun 1, 2007:

10:57 PM Changeset in webkit [21956] by sfalken

1 copy in tags/Safari-522.8.7b

New tag.

8:30 PM Changeset in webkit [21955] by bdash

1 edit in tags/Safari-5522.8.3/WebCore/Configurations/Version.xcconfig

Versioning.

8:20 PM Changeset in webkit [21954] by bdash

1 copy in tags/Safari-5522.8.3

New tag.

8:12 PM Changeset in webkit [21953] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21952.

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.

7:37 PM Changeset in webkit [21952] by andersca

2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.

6:58 PM Changeset in webkit [21951] by kevino

3 edits in branches/wx-port-alpha/trunk

Don't require a debug build of wxWidgets to be used with wxWebKit.

4:54 PM Changeset in webkit [21950] by weinig

2 edits in trunk/WebCore

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13958 REGRESSION: Form select menu in iframe destroys form select menu on page

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling the event handler methods directly, post the fake event on the application event queue. This ensures that the fake event is handled only after handling of the initiating event has ended, and is seen by ancestor frames' event handlers.

3:27 PM Changeset in webkit [21949] by sfalken

1 copy in tags/Safari-522.8.6b

New tag.

3:10 PM Changeset in webkit [23438] by kmccullo

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Uncommenting some functions that should not be commented out. I needed them for the Drosera port.

WebKit.vcproj/WebKit_debug.def:

3:07 PM Changeset in webkit [23437] by kmccullo

3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

3:00 PM Changeset in webkit [21948] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/StringWx.cpp

More robust string conversion, courtesy of Vaclav Slavik.

2:52 PM Changeset in webkit [23436] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

If the value exists but is empty, return an empty String.

plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo):

2:28 PM Changeset in webkit [21947] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Add explicit cast (some users reported 'ambiguous call' errors without it).

2:26 PM Changeset in webkit [21946] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/WebCoreSources.bkl

Remove duplicate file entry.

2:23 PM Changeset in webkit [21945] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/page/Frame.h

Remove unused variable.

2:12 PM Changeset in webkit [21944] by eseidel

14 edits in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
http://bugs.webkit.org/show_bug.cgi?id=12568

This is covered by the W3C tests (including mask-intro01)

ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
ksvg2/svg/SVGMaskElement.h:
ksvg2/svg/SVGMaskElement.idl:
platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

2:05 PM Changeset in webkit [21943] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21933.

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

2:05 PM Changeset in webkit [21942] by bdash

3 edits in branches/Safari-5522/WebCore

Merge r21905.

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.

2:05 PM Changeset in webkit [21941] by bdash

5 edits
4 adds in branches/Safari-5522

Merge r21902.

LayoutTests:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

fast/dom/frame-contentWindow-crash-expected.txt: Added.
fast/dom/frame-contentWindow-crash.html: Added.
fast/dom/iframe-contentWindow-crash-expected.txt: Added.
fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLIFrameElement.idl:

2:04 PM Changeset in webkit [21940] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21897.

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):

1:55 PM Changeset in webkit [23435] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker.

Remove unnecessary user agent spoofs, now that we have the final UA in place.
Added spoof to allow Flash downloads from adobe.com

WebView.cpp: (WebView::userAgentForKURL):

12:09 PM Changeset in webkit [23434] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Add the default path for the new WMP Firefox plugin.

plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginPath):

11:01 AM Changeset in webkit [21939] by andersca

15 edits in branches/Safari-522

Merge r20613 and the subsequent build fix, r20614

5:47 AM Changeset in webkit [21938] by staikos

2 edits in trunk/WebCore

2007-06-01 George Staikos <staikos@kde.org>

Reviewed by bdash.

Redo the build fix again after it was backed out

WebCore.pro: add an include guard around CSSGrammar.h

5:40 AM BuildingOnWindows edited by todd.fisher@revolution.com

(diff)

5:39 AM BuildingOnWindows edited by todd.fisher@revolution.com

(diff)

4:20 AM Changeset in webkit [21937] by eseidel

2 edits
1 add in branches/feature-branch/WebCore

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by lars.

Cursor does not change to hand over links containing <use>
http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

manual-tests/svg-link-hover-use.svg: Added.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode

2:59 AM Changeset in webkit [21936] by eseidel

5 edits
4 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):

2:34 AM Changeset in webkit [21935] by bdash

2 edits in trunk/WebCore

Roll out r21916 as it did nothing to fix the build.

1:13 AM Changeset in webkit [21934] by eseidel

4 edits
5 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):

12:25 AM Changeset in webkit [21933] by ggaren

3 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

May 31, 2007:

10:57 PM Changeset in webkit [21932] by hyatt

8 edits in trunk

WebCore:

Fix for 11768, Flash plugin does not respect clips set via CSS.

Reviewed by olliej

bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
bindings/objc/DOMPrivate.h:
page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::windowClipRectForLayer):
platform/ScrollView.h: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Fix for 11768, Flash plugin does not respect clips set by CSS.

Reviewed by olliej

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

10:46 PM Changeset in webkit [21931] by weinig

3 edits in trunk/LayoutTests

Reviewed by Adam.

Update test to reflect new correct result.

fast/dom/Window/atob-btoa-expected.txt:
fast/dom/Window/atob-btoa.html:

10:45 PM Changeset in webkit [21930] by weinig

2 edits in trunk/WebCore

Reviewed by Adam.

Fix build bot.

ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):

9:49 PM Changeset in webkit [21929] by kevino

1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Correct fix to deal with variadic macros on MSVC7.

9:34 PM Changeset in webkit [23433] by weinig

2 edits in branches/WindowsMerge/WebCore

Fixed build.

WebCore.vcproj/WebCore.vcproj:

8:19 PM Changeset in webkit [21928] by weinig

2 edits in trunk/WebCore

Fix Qt and Gdk builds.

WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp

8:13 PM Changeset in webkit [21927] by weinig

16 edits
2 adds
1 delete in trunk

LayoutTests:

Reviewed by Geoff.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Adds a new test to test overriding toString and valueOf for multiple objects.
Update tests to reflect the correction of the toString architecture.

editing/selection/getRangeAt-expected.txt:
fast/dom/Window/atob-btoa-expected.txt:
fast/js/toString-and-valueOf-override-expected.txt: Added.
fast/js/toString-and-valueOf-override.html: Added.

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Remove all overrides of JSObject::toString and JSObject::toPrimitive
which is a bad practice. Instead, if an object, like the
HTMLAnchorElement, needs to override to toString, it should add
a function to the JS object which will be called when needed. This
also allows developers to override toString and valueOf from within JS.

Test: fast/js/toString-and-valueOf-override.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
bindings/js/kjs_binding.cpp:
bindings/js/kjs_binding.h:
bindings/js/kjs_dom.cpp:
bindings/js/kjs_dom.h:
bindings/js/kjs_domnode.h:
bindings/js/kjs_window.cpp: (KJS::History::): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction):
bindings/js/kjs_window.h:
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::toString):
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:

7:35 PM Changeset in webkit [21926] by kevino

1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Add a note about variadic macros on MSVC7, and enable any macros which don't use variadic args.

6:52 PM Changeset in webkit [21925] by weinig

9 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::zoomEnabled): (WebCore::SVGDocument::startPan): (WebCore::SVGDocument::updatePan):
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::setCurrentTranslate):
ksvg2/svg/SVGSVGElement.h:
page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
page/EventHandler.h:
page/Frame.cpp: (WebCore::Frame::setZoomFactor):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteTransform):
rendering/RenderSVGContainer.h:

6:35 PM Changeset in webkit [21924] by weinig

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Niko.

Test for fix: http://bugs.webkit.org/show_bug.cgi?id=12570

svg/custom/prevent-default-expected.checksum: Added.
svg/custom/prevent-default-expected.png: Added.
svg/custom/prevent-default-expected.txt: Added.
svg/custom/prevent-default.svg: Added.

WebCore:

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570

Test: svg/custom/prevent-default.svg

html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

5:21 PM Changeset in webkit [21923] by mjs

1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

editing/style/table-selection-expected.txt: Updated selection delegate output.

5:19 PM Changeset in webkit [21922] by mjs

4 edits in trunk

LayoutTests:

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

editing/style/table-selection-expected.txt: Updated selection delegate output.

WebCore:

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
but the font delta style change command would wrap them in spans, creating extra anonymous table
cells.

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node is not rendered.

4:50 PM Changeset in webkit [21921] by weinig

4 edits
1 move in trunk

top level:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

WebKit.pri:

WebCore:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

WebCore.pro:

1:53 PM Changeset in webkit [21920] by eseidel

4 edits
4 adds in branches/feature-branch

2007-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570

Test: svg/custom/prevent-default.svg

html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

1:33 PM Changeset in webkit [21919] by weinig

2 edits in trunk/WebCore

Reviewed by Niko.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
GraphicsContextCairo enhancements necessary for SVG support

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):

1:20 PM Changeset in webkit [21918] by kevino

43 edits
4 copies
17 adds in branches/wx-port-alpha/trunk

Merge with TOT and add files that weren't automatically added during the last merge.

12:49 PM Changeset in webkit [21917] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Convert the url string to an NSURL before returning as the AXURLAttribute

12:44 PM Changeset in webkit [21916] by staikos

2 edits in trunk/WebCore

2007-05-31 George Staikos <staikos@kde.org>

Reviewed by Nikolas.

Compile again - Qt build.

WebCore.pro: header guard added to CSSGrammar.h

11:32 AM Changeset in webkit [21915] by spadma

2 edits in S60/trunk/WebKit

spadma, reviewed by zalan

DESC: Browser control API, CBrCtlInterface: ContentSize() does not return correct content size. http://bugs.webkit.org/show_bug.cgi?id=13954

BrowserControl/src/BrCtl.cpp: (CBrCtl::ContentSize):

11:31 AM Changeset in webkit [21914] by spadma

2 edits in S60/branches/3.1m/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):

11:30 AM Changeset in webkit [21913] by spadma

2 edits in S60/trunk/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):

9:52 AM Changeset in webkit [21912] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Make sure the build completed output only happens when doing a build.

12:04 AM Changeset in webkit [23432] by weinig

2 edits in branches/WindowsMerge/WebCore

Fixed build.

WebCore.vcproj/WebCore.vcproj:

May 30, 2007:

10:21 PM Changeset in webkit [21911] by weinig

14 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
bindings/js/kjs_css.cpp:
bindings/js/kjs_css.h:
bindings/scripts/CodeGeneratorJS.pm:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::cssRules):
css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::rules): (WebCore::CSSStyleSheet::removeRule):
css/CSSStyleSheet.idl:
page/DOMWindow.idl:

10:05 PM Changeset in webkit [21910] by weinig

9 edits
1 add in trunk/WebCore

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13937
Autogenerate the JS bindings for the CSSValue

WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSValueCustom.cpp: Added. (WebCore::toJS):
bindings/js/kjs_css.cpp:
bindings/js/kjs_css.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSValue.h: (WebCore::CSSValue::setCssText):
css/CSSValue.idl:

8:36 PM Changeset in webkit [21909] by weinig

7 edits in trunk

LayoutTests:

Reviewed by Oliver the Hun.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver the Hun.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

css/CSSRuleList.idl:
css/CSSValueList.idl:
css/Counter.idl:
page/DOMWindow.idl:

8:12 PM BuildingGdk edited by alp@atoker.com

Update Gdk tasks (diff)

6:24 PM BuildingGdk edited by alp@atoker.com

(diff)

5:39 PM Changeset in webkit [21908] by justing

3 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13915
REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)

After r21687, SimplifiedBackwardsTextIterator was no longer
emitting a '\n' as it left the first block of a range ending
at [block, 0]. So, foo<div>^{<br></div> looked like foo} to
spell checking (foo wasn't marked as misspelled).

After r21687, SBTI stopped emitting '\n's in the above case
because 1) we stopped incorrectly emitting '\n's for nodes as
we entered them and 2) we were and still are incorrectly calling
code that should only be called when entering nodes as we leave
them and 3) we don't call exitNode(), which is responsible
for emitting the '\n' in the above testcase, when we should.

Before and after r21687, we'd call exitNode() for a node as
we traversed in reverse pre-order from its first descendant
out to its sibling or one of its ancestors' siblings. We
weren't calling it a) after we'd enter a node that could
have children but had none and b) when leaving a container
that contained the end of the range used to create the iterator.

editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we leave a childless container node and a node where the range ended.
editing/TextIterator.h: Track the end of the range used to create the SimplifiedBackwardsTextIterator.

5:23 PM Changeset in webkit [21907] by weinig

3 edits in trunk

Update ChangeLogs with correct Bugzilla URLs.

5:16 PM Changeset in webkit [21906] by weinig

8 edits
1 add in trunk

JavaScriptCore:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

wtf/Assertions.cpp:
wtf/Assertions.h: Add WTFLogVerbose which also logs the file, line number and function.

WebCore:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

WebCore.pro:
platform/NotImplemented.h: Changed to use WTFLogVerbose.
platform/gdk/LoggingGdk.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKitTools:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

GdkLauncher/main.cpp: (main):

4:03 PM Changeset in webkit [21905] by bdakin

3 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.

3:06 PM Changeset in webkit [21904] by justing

5 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5096134> VO gets stuck on Howto.apple.com
http://bugs.webkit.org/show_bug.cgi?id=8622
VisiblePositions aren't canonicalized in some cases

No new test cases added: can't write automated tests
for VO.

editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): VisiblePositions must be recomputed after nodes that may have effected their canonicalization are removed.
editing/VisiblePosition.cpp: (WebCore::canonicalizeCandidate): Added. (WebCore::VisiblePosition::canonicalPosition): Canonicalize the candidates returned by next/previousCandidate before returning them.
editing/VisiblePosition.h: (WebCore::operator==): Remove the workaround for 8622.
editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto.

3:02 PM Changeset in webkit [21903] by kevino

230 edits
3 copies
1 delete in branches/wx-port-alpha/trunk

Sync with TOT to get the curl, NotImplemented, etc. goodies.

2:36 PM Changeset in webkit [23431] by adachan

2 edits in branches/WindowsMerge/WebCore

2007-05-30 Ada Chan <adachan@apple.com>

Reviewed by Adam.

Fixed build.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):

2:08 PM Changeset in webkit [21902] by weinig

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

fast/dom/frame-contentWindow-crash-expected.txt: Added.
fast/dom/frame-contentWindow-crash.html: Added.
fast/dom/iframe-contentWindow-crash-expected.txt: Added.
fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLIFrameElement.idl:

1:56 PM Changeset in webkit [21901] by sfalken

1 copy in tags/Safari-522.8.5b

New tag.

12:16 PM Changeset in webkit [21900] by bdash

9 edits
4 adds in trunk

2007-05-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13775 REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu

Test: fast/forms/select-writing-direction-natural.html

platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural which says whether items in the popup ignore the CSS text-align and direction properties and instead are left-aligned and use natural writing direction.
platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
platform/win/TemporaryLinkStubs.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
platform/wx/TemporaryLinkStubs.cpp: (PopupMenu::itemWritingDirectionIsNatural):
rendering/RenderMenuList.cpp: (WebCore::textDirectionForParagraph): Added this helper function that uses the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction of text. (WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction adjustment conditional on the popup implementation. (WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since the style depends on the text when natural writing direction is used.

2007-05-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13775 REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu

fast/forms/select-writing-direction-natural-expected.checksum: Added.
fast/forms/select-writing-direction-natural-expected.png: Added.
fast/forms/select-writing-direction-natural-expected.txt: Added.
fast/forms/select-writing-direction-natural.html: Added.

11:57 AM Changeset in webkit [21899] by weinig

1 edit in trunk/LayoutTests/ChangeLog

Add radar to ChangeLog.

11:56 AM Changeset in webkit [23430] by adachan

5 edits in branches/WindowsMerge/WebKitWin

2007-05-30 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Implemented the mechanism to associate a WebPreferences instance with an identifier.

WebIconDatabase.cpp: (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): implemented (WebPreferences::setInstance): implemented (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be released has only one ref left, remove it from the s_webPreferencesInstances dictionary. (WebPreferences::load): don't need to reread in the default preferences if we have done so. (WebPreferences::initWithIdentifier): update the m_identifier data member with the passed in identifier string, and store the identifier to WebPreferences instance mapping in s_webPreferencesInstances dictionary. (WebPreferences::identifier): implemented
WebPreferences.h:
WebView.cpp: (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification since it's already done in close(). (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::setPreferences): implemented (WebView::onNotify): used COMPtr to fix a missing release

11:45 AM Changeset in webkit [21898] by weinig

2 edits in trunk/LayoutTests

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13932 REGRESSION: fast/dynamic/containing-block-change is failing

fast/dynamic/containing-block-change.html: Removed whitespace that got turned into text nodes, thereby making lastNode be not what the script expected it to be.

11:30 AM Changeset in webkit [23429] by weinig

2 edits in branches/WindowsMerge/WebCore

Build Fix.

WebCore.vcproj/WebCore.vcproj:

11:11 AM Changeset in webkit [21897] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):

10:43 AM Changeset in webkit [21896] by weinig

26 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13919 Autogenerate the JS bindings for the CSSRule and its subclasses

fast/dom/Window/window-properties-expected.txt: adds new constructors
fast/dom/wrapper-classes-expected.txt: CSSStyleRule now passes!!

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13919
Autogenerate the JS bindings for the CSSRule and its subclasses

subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule CSSMediaRule, CSSPageRule and CSSStyleRule.

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleCustom.cpp: Added. (WebCore::toJS):
bindings/js/kjs_css.cpp:
bindings/js/kjs_css.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::setEncoding):
css/CSSCharsetRule.idl:
css/CSSFontFaceRule.idl:
css/CSSImportRule.idl:
css/CSSMediaRule.idl:
css/CSSPageRule.cpp: (WebCore::CSSPageRule::setSelectorText):
css/CSSPageRule.h:
css/CSSPageRule.idl:
css/CSSRule.cpp: (WebCore::CSSRule::setCssText):
css/CSSRule.h:
css/CSSRule.idl:
css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText):
css/CSSStyleRule.h:
css/CSSStyleRule.idl:
page/DOMWindow.idl: add new constructors.

10:21 AM Changeset in webkit [21895] by rwlbuis

9 edits in branches/feature-branch/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

7:40 AM Changeset in webkit [21894] by zbujtas

11 edits in S60/trunk

2007-05-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
http://bugs.webkit.org/show_bug.cgi?id=13906

6:28 AM Changeset in webkit [21893] by bdash

5 edits
2 adds in trunk

2007-05-30 Mark Rowe <mrowe@apple.com>

Build fixes after r21889. Add missing #includes.

ForwardingHeaders/kjs/function.h: Added.
bindings/js/kjs_binding.h:
bindings/js/kjs_dom.h:
bindings/js/kjs_window.h:

2007-05-30 Mark Rowe <mrowe@apple.com>

Build fixes after r21889.

ForwardingHeaders/kjs/function.h: Added.

6:20 AM Changeset in webkit [21892] by zbujtas

11 edits in S60/branches/3.1m

2007-05-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
http://bugs.webkit.org/show_bug.cgi?id=13906

6:15 AM Changeset in webkit [21891] by zimmermann

13 edits in branches/feature-branch

Reviewed by Oliver.
Fix regression: gradient on fill of text works again!

5:27 AM Changeset in webkit [21890] by bdash

2 edits in trunk/JavaScriptCore

2007-05-30 Mark Rowe <mrowe@apple.com>

Mac build fix. Update #include.

API/JSCallbackFunction.h:

5:19 AM Changeset in webkit [21889] by bdash

9 edits in trunk/JavaScriptCore

2007-05-30 Luciano Montanaro <mikelima@cirulla.net>

Reviewed by Maciej.

cross-port Harri Porten's commits 636099 and 636108 from KJS: "publish a class anyway public already" and "class is being used from outside for quite some time" in preparation for further syncronizations

kjs/context.h:
kjs/date_object.cpp:
kjs/date_object.h:
kjs/function.h: (KJS::): (KJS::InternalFunctionImp::classInfo): (KJS::InternalFunctionImp::functionName):
kjs/function_object.h:
kjs/internal.h:
kjs/lookup.h: (KJS::getStaticPropertySlot): (KJS::getStaticFunctionSlot): (KJS::getStaticValueSlot):
kjs/object_object.h:

3:36 AM Changeset in webkit [21888] by oliver

3 edits in trunk/LayoutTests

2007-05-30 Oliver Hunt <oliver@apple.com>

Reviewed by Mitz.

Remove reference to SVG node from test -- otherwise this test incorrectly appears
to fail in non-SVG builds

http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt:
http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html:

12:27 AM Changeset in webkit [21887] by bdash

2 edits in trunk/WebCore

2007-05-30 Mark Rowe <mrowe@apple.com>

Gdk build fix. Update WidgetGdk to use NotImplemented.h.

platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):

May 29, 2007:

11:24 PM Changeset in webkit [21886] by bdash

8 edits in trunk

2007-05-29 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

Make ScrollView use a GtkLayout. This class matches QScrollView the most and promises
to ease the implementation of ScrollView::addChild. GtkLayout should be resource friendly
even with huge width and heights of frames.
Make Widget aware of GtkLayout to use the right GdkWindow as drawable. For GtkLayout one must
draw on the bin_window.
Remove the layer violation from FrameGdk.cpp and ScrollView. FrameGdk is no longer responsible to
implement scrolling on keyboard events. ScrollView is no longer required to know that it could be
a FrameView and handles scrolling of Frames magically.

platform/ScrollView.h:
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent):
platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setGtkWidget): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
platform/gdk/TemporaryLinkStubs.cpp: Move Widget methods to WidgetGdk.cpp
platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setGtkWidget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):

2007-05-29 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

Create a GtkLayout and pass it to the FrameView/ScrollView. Embed the GtkLayout into a GtkScrolledWindow
to provide ScrollBars for the FrameView.

GdkLauncher/main.cpp: (registerRenderingAreaEvents): (layout_realize_callback): Only after realization we can access the GtkLayout::bin_window (frameResizeCallback): Inform the ScrollView about its new viewport size, and ask the FrameView to adjust (main):

11:15 PM Changeset in webkit [23428] by weinig

2 edits in branches/WindowsMerge/WebCore

Fix the build.

WebCore.vcproj/WebCore.vcproj:

11:12 PM Changeset in webkit [21885] by bdash

5 edits in trunk/WebCore

2007-05-29 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Curl (linux/gdk) networking improvements:
a) POST support
b) don't use CURL in a re-entrant way.
c) turn on curl's internal debugging support in a debug build if the DEBUG_CURL environment variable is set.

platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::removeScheduledJob): (WebCore::ResourceHandleManager::startScheduledJobs): (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel):
platform/network/gdk/ResourceHandleManager.h: (WebCore::ResourceHandleList::ResourceHandleList): (WebCore::ResourceHandleList::next): (WebCore::ResourceHandleList::job): (WebCore::ResourceHandleList::setRemoved): (WebCore::ResourceHandleList::removed):

11:08 PM Changeset in webkit [21884] by weinig

2 edits in trunk/WebCore

Fix the Qt and Gdk builds.

WebCore.pro:

10:55 PM Changeset in webkit [21883] by adele

2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5109711> REGRESSION: Focus ring artifacts appear around a widget's search field at times (Address Book, Dictionary)

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchField): We only need this hack for drawing the search field focus ring on Tiger. On Leopard, drawWithFrame correctly draws the cell's focus ring.

10:53 PM Changeset in webkit [21882] by bdash

2 edits in trunk/WebCore

2007-05-29 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13899

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::strokeArc): Use cairo_arc_negative() to fix CSS rounded borders. (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): save/restore is redundant. push/pop group does this implicitly.

10:47 PM Changeset in webkit [21881] by weinig

11 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

fast/dom/Window/window-properties-expected.txt: new constructors added.

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_css.cpp:
bindings/js/kjs_css.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
css/MediaList.idl:
page/DOMWindow.idl: Add constructor.

10:41 PM Changeset in webkit [21880] by bdash

3 edits in trunk/WebCore

2007-05-29 Matt Perry <mpComplete@gmail.com>

Reviewed by Maciej.

Fixed some rendering issues for <select>s on Windows.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::RenderThemeWin::paintMenuList):
rendering/RenderThemeWin.h:

10:32 PM Changeset in webkit [21879] by hyatt

4 edits in trunk/WebCore

Fold the invalidateVerticalPositions crawl into the bidi iteration.
This makes it more correct (since we won't drill into elements that
did not need to be reset) and cuts out an extra walk of all our children.
We're still O(n^{2) as new content streams in, but this at least cuts

out one separate O(n}2) crawl.

Reviewed by olliej

rendering/RenderObject.cpp:
rendering/RenderObject.h: (WebCore::RenderObject::invalidateVerticalPosition):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

10:14 PM Changeset in webkit [21878] by bdash

2 edits in tags/Safari-5522.8.2

Versioning.

10:10 PM Changeset in webkit [21877] by bdash

1 copy in tags/Safari-5522.8.2

New tag.

10:08 PM Changeset in webkit [21876] by bdash

31 edits in branches/Safari-5522

Merge r21793.

10:01 PM Changeset in webkit [21875] by bdash

2 edits in branches/Safari-5522/WebKitTools

Merge r21839 to ease building of the branch.

10:00 PM Changeset in webkit [21874] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

MSVC build fix for non-wxGC build mode.

9:45 PM Changeset in webkit [21873] by weinig

11 edits
1 add in trunk

LayoutTests:

Reviewed by Oliver.

Update results after http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

fast/dom/Window/window-properties-expected.txt: Adds StyleSheet constructor

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSStyleSheetCustom.cpp: Added. (WebCore::toJS): (WebCore::JSStyleSheet::toBoolean):
bindings/js/kjs_css.cpp: (KJS::): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheet::getOwnPropertySlot):
bindings/js/kjs_css.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
css/StyleSheet.idl:
page/DOMWindow.idl: Add new constructor.

9:28 PM Changeset in webkit [21872] by kevino

4 edits in branches/wx-port-alpha/trunk

Use the wxGCDC bridge class to make it easier to support the new, modern platform graphics APIs where available, while still supporting the old APIs elsewhere.

8:58 PM Changeset in webkit [21871] by hyatt

2 edits in trunk/WebCore

Make sure <embed> does not allow an end tag.

Reviewed by olliej

html/HTMLEmbedElement.h: (WebCore::HTMLEmbedElement::endTagRequirement):

7:46 PM Changeset in webkit [21870] by sfalken

1 copy in tags/Safari-522.8.4b

New tag.

6:31 PM BuildingGdk edited by alp@atoker.com

Remove Bakefile instructions completely (diff)

6:28 PM BuildingGdk edited by alp@atoker.com

Update TODO (diff)

6:21 PM BuildingGdk edited by alp@atoker.com

(diff)

6:17 PM BuildingGdk edited by alp@atoker.com

Update to describe the gdk port qmake4 build (diff)

5:36 PM Changeset in webkit [21869] by adele

7 edits in trunk

LayoutTests:

Reviewed by Brady.

Updated tests for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

fast/dom/HTMLInputElement/input-hidden-value-expected.txt:
fast/dom/HTMLInputElement/input-text-reset-expected.txt:
fast/dom/HTMLInputElement/input-text-reset.html:

WebCore:

Reviewed by Brady.

Fix for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

Roll out updated fix for 11866 that tried to make reset work for hidden inputs. Since
all browsers update the value attribute when setting the value, it doesn't really make sense to reset.
Its true that IE does support resetting these controls, but in this case, it doesn't really make sense to have
another place to store an alternate version of the value.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset):
html/HTMLInputElement.h:

4:52 PM Changeset in webkit [23427] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.

Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
WebBackForwardList.cpp: Removed unnecessary methods.
WebBackForwardList.h: Removed unnecessary methods.

4:23 PM Changeset in webkit [21868] by darin

5 edits in trunk

LayoutTests:

Reviewed by Anders.

updated results since I removed many cases of the innerHTML optimization

fast/dom/HTMLElement/set-inner-outer-optimization.html: Updated.

WebCore:

Reviewed by Anders.

removed the general case optimization for innerHTML because some sites rely on setting innerHTML to trigger loading plug-ins for example; we could consider bringing it back some day, perhaps with a list of element types to exclude

dom/CharacterData.cpp: (WebCore::CharacterData::setData): Do nothing if the old data is identical to the new data.

html/HTMLElement.cpp: (WebCore::replaceChildrenWithFragment): Remove childrenAreEqual optimization. (WebCore::replaceChildrenWithText): Remove optimization for cases where the text data is identical to the new data, since CharacterData handles that now. (WebCore::HTMLElement::setOuterHTML): Remove childrenAreEqual optimization.

4:07 PM Changeset in webkit [21867] by weinig

2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Cleanup function and fix to match comparison API.

kjs/string_object.cpp: (KJS::substituteBackreferences): (KJS::localeCompare):

3:56 PM Changeset in webkit [23426] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added another failing test.

3:09 PM Changeset in webkit [21866] by hyatt

1 edit in trunk/WebCore/html/HTMLHeadElement.cpp

Tweak my noscript fix to just always allow it inside the head.

2:49 PM Changeset in webkit [23425] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://4782915> plugin is not in the right place at jumble.com/play.html

Pass the plugin window coordinates for windowed plugins too.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setNPWindowRect):

2:36 PM Changeset in webkit [21865] by weinig

6 edits in trunk

LayoutTests:

Reviewed by Maciej.

updated results for http://bugs.webkit.org/show_bug.cgi?id=13904

fast/forms/box-shadow-override-expected.checksum:
fast/forms/box-shadow-override-expected.png:

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=13904 REGRESSION: Search fields with a results popup do not always draw the popup arrow

Covered by fast/forms/box-shadow-override.html

The search button draws a popup arrow depending on whether the
search menu template is set, rather than on the maximum number of recent
search strings.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Removed the call to -setMaxmiumRecents:. (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Replaced calling -setMaximumRecents: with setting the search menu template. (WebCore::RenderThemeMac::search): Removed initialization of the menu. (WebCore::RenderThemeMac::searchMenuTemplate): Added. Returns an empty NSMenu to be used as the search menu template.

2:32 PM Changeset in webkit [21864] by hyatt

5 edits in trunk/WebCore

Fix for bug 13907, <noscript> should be allowed inside <head> when
scripting is enabled.

Reviewed by aroben

html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::checkDTD):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h:

2:00 PM Changeset in webkit [21863] by zimmermann

3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Fix "jumpy" selection by correcting the way svgCharacterHitsPosition works.
I basically mixed up the "closest character to position" logic.

1:49 PM Changeset in webkit [23424] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
<rdar://problem/5131528> play button on Flash in ESPN front page does not start movie

Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a
quirk for that.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
plugins/win/PluginViewWin.h: (WebCore::):

1:36 PM Changeset in webkit [23423] by weinig

15 edits
1 delete in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam Roben.

Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
Fixes remaining uses of old macro to use the new notImplemented() one.

WebCore.vcproj/WebCore.vcproj:
page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
platform/win/NotImplemented.h: Removed.
platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (GraphicsContextPlatformPrivate::clip): (WebCore::FrameView::updateBorder): (Widget::setIsSelected): (ScrollView::inWindow): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles): (FrameLoader::overrideMediaType): (DocumentLoader::getResponseModifiedHeader): (ResourceHandle::willLoadFromCache): (WebCore::userIdleTime): (CachedPage::close): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::setValue):

WebKitWin:

Reviewed by Adam Roben.

Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
Fixes remaining uses of old macro to use the new notImplemented() one.

WebChromeClient.cpp: (WebChromeClient::createModalDialog): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible):
WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary): (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
WebDownload.cpp: (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType): (WebDownload::cancelAuthenticationChallenge): (WebDownload::continueWithoutCredentialForAuthenticationChallenge): (WebDownload::useCredential): (WebDownload::didReceiveAuthenticationChallenge):
WebEditorClient.cpp: (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::respondToChangedSelection): (WebEditorClient::didEndEditing): (WebEditorClient::didWriteSelectionToPasteboard): (WebEditorClient::didSetSelectionTypesForPasteboard): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldChangeSelectedRange):
WebFrame.cpp: (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::setCopiesOnScroll): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromCachedPage): (WebFrame::dispatchDidLoadMainResource): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::restoreViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::shouldGoToHistoryItem): (WebFrame::saveViewStateToItem): (WebFrame::saveDocumentViewToCachedPage): (WebFrame::canCachePage): (WebFrame::setMainDocumentError): (WebFrame::cannotShowURLError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::willUseArchive): (WebFrame::dispatchDidLoadResourceFromMemoryCache): (WebFrame::startDownload): (WebFrame::overrideMediaType): (WebFrame::addInspector): (WebFrame::removeInspector):

1:33 PM Changeset in webkit [21862] by weinig

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

test for http://bugs.webkit.org/show_bug.cgi?id=13792 REGRESSION: WebKit doesn't show this javascript screenshot page (and crashes after click on its "hidden link")

fast/frames/removal-before-attach-crash-expected.txt: Added.
fast/frames/removal-before-attach-crash.html: Added.

WebCore:

Reviewed by Maciej.

fix crash in http://bugs.webkit.org/show_bug.cgi?id=13792 REGRESSION: WebKit doesn't show this javascript screenshot page (and crashes after click on its "hidden link")

Test: fast/frames/removal-before-attach-crash.html

Delayed the queueing of the post-attach callback until attach().

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): (WebCore::HTMLFrameElementBase::parseMappedAttribute): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLFrameElementBase::insertedIntoDocument): Instead of queueing the post-attach callback here, just set a flag telling us to do so at the beginning of attach(). (WebCore::HTMLFrameElementBase::removedFromDocument): Reset the above flag. (WebCore::HTMLFrameElementBase::attach): If this is the first attach() after being inserted into the document, queue a post-attach callback to load the frame. (WebCore::HTMLFrameElementBase::willRemove): Changed to call up to the correct parent class. (WebCore::HTMLFrameElementBase::setFocus): Ditto.
html/HTMLFrameElementBase.h:
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::mapToEntry): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLPlugInElement::parseMappedAttribute): Ditto. (WebCore::HTMLPlugInElement::checkDTD): Ditto. (WebCore::HTMLPlugInElement::detach): Ditto.

12:39 PM Changeset in webkit [21861] by darin

14 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

test for http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

editing/execCommand/copy-without-selection.html: Added missing preventDefault calls to prevent this from being a double-paste test.

fast/css/first-letter-detach-expected.checksum: Updated.
fast/css/first-letter-detach-expected.png: Updated.
fast/css/first-letter-detach-expected.txt: Updated.
fast/css/first-letter-detach.html: Updated to test three different ways of setting the text of the first-letter element; setInnerHTML and two other ways.

fast/events/updateLayoutForHitTest-expected.txt: Updated result that changed slightly due to setInnerHTML improvement.
fast/forms/textarea-setinnerhtml-expected.txt: Ditto.

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

fix first-letter when the text of the affected text node is changed

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
Test: fast/css/first-letter-detach.html

html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::childrenAreEqual): Added. Helper functions that compare children of nodes. (WebCore::hasOneChild): Added. Helper function. (WebCore::hasOneTextChild): Added. Helper function. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.

dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Set first-letter after the setStyle call so calls to setTextInternal inside setStyle don't clear it.

rendering/RenderText.h: Made setTextInternal virtual so that RenderTextFragment can do appropriate work when the text changes.

rendering/RenderTextFragment.h: Added an override of setTextInternal. Removed the firstLetter parameter to the constructor and made it a separate setter. Also changed m_generatedContentStr to m_contentString to match the getter function.
rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment): Removed firstLetter parameter. (WebCore::RenderTextFragment::setTextInternal): When the text changes, destroy the first-letter node and reset the fragment values so that RenderBlock::updateFirstLetter, which will run during layout, will create a new first-letter child. Otherwise we end up with the first letter of the old text.

11:53 AM Changeset in webkit [21860] by weinig

2 edits in trunk/WebCore

Fix Qt build.

platform/NotImplemented.h:

11:46 AM Changeset in webkit [23422] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed some fixed tests, and added some failing ones.

11:41 AM Changeset in webkit [21859] by ddkilzer

2 edits in trunk/WebKitTools

2007-05-29 David Kilzer <ddkilzer@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13901 run-pageloadtest does not obey testName on command-line

Scripts/run-pageloadtest: Grab $testName from the command-line if it is present, otherwise default to "svg". Added dummy check to make sure $testName.pltsuite exists.

11:37 AM Changeset in webkit [21858] by weinig

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Consolidate platform dependent notImplemented() macros
into one platform independent macro that uses WTFLog.

platform/NotImplemented.h:

11:30 AM Changeset in webkit [21857] by ddkilzer

3 edits in trunk/WebKitTools

2007-05-29 David Kilzer <ddkilzer@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13900 svnStatus($) subroutine in svn-[un]apply does not work properly with directories

This patch also fixes an instance of the "broken pipe" warning that happened when
a directory contained modified files that were not part of an applied or unapplied
patch.

Scripts/svn-apply: (svnStatus($)): If we're trying to get status on a directory (instead of a file), make sure we actually get the directory's status (if it has one), not the first file's status reported within the directory. Fix "broken pipe" warnings by reading all of the output from the SVN filehandle before closing it.
Scripts/svn-unapply: (svnStatus($)): Ditto.

10:41 AM Changeset in webkit [21856] by darin

11 edits in trunk/WebCore

Reviewed by Sam.

a clean-up pass on form-related aspects of the recent JSHTMLElement patch

bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): Replace the call to formForEventHandlerScope() with a call to the new form() function. And removed the now-uneeded code to search for a form ancestor.

html/HTMLElement.h: Added a general-purpose form() function. The intent is to return the form ancestor if any, but return the associated form for a form control, which isn't always an ancestor of the control. To keep form() efficient for form controls, it's an inline that calls a virtual, allowing a derived class to override it with an inline. This replaces formForEventHandlerScope(). Also added findFormAncestor() to use here and to replace the multiple loops found elsewhere to search for the nearest form ancestor.
html/HTMLElement.cpp: (WebCore::HTMLElement::findFormAncestor): Added. (WebCore::HTMLElement::virtualForm): Added. Calls findFormAncestor().

html/HTMLGenericFormElement.h: Suggested name change to HTMLFormControlElement. Removed the confusing getForm() function, which is superceded by findFormAncestor. Removed the unused onSelect() function. Removed the override of formForEventHandlerScope(), replacing it with an override of virtualForm().
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::HTMLGenericFormElement): Use findFormAncestor instead of getForm. (WebCore::HTMLGenericFormElement::insertedIntoTree): Ditto. (WebCore::HTMLGenericFormElement::virtualForm): Added.

html/HTMLLabelElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Renamed formElement() to correspondingControl(), since that's the terminology used elsewhere in the code, and the old name was unnecessarily confusing.
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::correspondingControl): Renamed. Removed unnecessary special case for empty ID, since getElementById already returns 0 for that case. (WebCore::HTMLLabelElement::setActive): Updated for name change. (WebCore::HTMLLabelElement::setHovered): Ditto. (WebCore::HTMLLabelElement::defaultEventHandler): Ditto. (WebCore::HTMLLabelElement::focus): Ditto. (WebCore::HTMLLabelElement::accessKeyAction): Ditto.

html/HTMLObjectElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Also removed forward declaration of KJS::Bindings::Instance -- since the type is the return value of a function from the base class, it's guaranteed to be declared in the base class header.
html/HTMLObjectElement.cpp: Ditto.

bridge/mac/WebCoreAXObject.mm: (labelForElement): Updated for name change.

9:01 AM Changeset in webkit [23421] by andersca

2 edits in branches/WindowsMerge/WebCore

Build fix.

8:36 AM Changeset in webkit [23420] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Port code from open source changeset 21808, fixing
http://bugs.webkit.org/show_bug.cgi?id=13871

8:30 AM Changeset in webkit [23419] by adachan

2 edits in branches/WindowsMerge/WebCore

2007-05-29 Ada Chan <adachan@apple.com>

Build fix.

Added "$(ProjectDir)..\platform\win" to include paths
Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project

WebCore.vcproj/WebCore.vcproj:

7:26 AM Changeset in webkit [21855] by zack

2 edits in trunk/WebCore

Making the convenience method notImplemented convenient
for the Qt port.

Reviewed by George and Niko

May 28, 2007:

9:49 PM Changeset in webkit [21854] by weinig

9 edits
1 add in trunk/WebCore

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13902 Autogenerate the JS bindings for the CSSStyleDeclaration

WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSStyleDeclarationCustom.cpp: Added. (WebCore::cssPropertyName): (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::canGetItemsForName): (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
bindings/js/kjs_binding.h:
bindings/js/kjs_css.cpp:
bindings/js/kjs_css.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSStyleDeclaration.idl:

9:22 PM Changeset in webkit [21853] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Navigation and special keys still send EVT_CHAR events, so make sure we don't call insertText for common navigation keys.

6:24 PM Changeset in webkit [21852] by kevino

2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics

Workaround for the issue that there's no wx API for saving/restoring the clip region for the older wxDC APIs.

6:06 PM Changeset in webkit [21851] by kevino

4 edits in branches/wx-port-alpha/trunk

Only call insertText on wxEVT_CHAR events, this fixes problems with all-uppercase text on Win/Linux, and also, use execCommand("InsertLineBreak") instead of the insertLineBreak() function so that the return key will always be properly handled.

1:48 PM Changeset in webkit [21850] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=10342 prepare-ChangeLog only shows removed files but not added files when files are moved
fix prepare-ChangeLog part of http://bugs.webkit.org/show_bug.cgi?id=13408 prepare-ChangeLog and svn-create-patch don't show replaced files

Switched method used to find list of changed files from "diff" to "status". This
makes added and replaced files with history appear in the changed file list for svn.
Added check for "+" in output from the svn status command to detect file history, and
handle it in the generateFileList(\@\@\%) and in statusDescription($$) subroutines.

Scripts/prepare-ChangeLog: (diffCommand(@)): Switched argument from hash ref to array to match statusCommand(@). (statusCommand(@)): Switched argument from array ref to array. Necessary to use the output of "keys $paths" without creating a temporary array variable. (findOriginalFileFromSvn($)): Added. Based on findSourceFileAndRevision($) subroutine in svn-create-patch. (generateFileList(\@\@\%)): Added. Extracted from main body of script. Runs status command using command-line arguments instead of list of changed files from the diff command. Changed svn regex to only accept file statuses that we know how to handle. Identify original file when an added/replaced status with history is present. (statusDescription($$)): Handled added/replaced statuses with history. Added fall-through return statement.

1:45 PM Changeset in webkit [21849] by kevino

2 edits in branches/wx-port-alpha/trunk

Make using wxGraphicsContext an option in the build script, rather than hardcoding it.

1:36 PM Changeset in webkit [23418] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

1:18 PM Changeset in webkit [21848] by weinig

4 edits
12 adds in trunk/WebKitTools

Reviewed by Mark Rowe.

Add scripts and data to generate a coverage data for WebKit.

CodeCoverage/README: Added.
CodeCoverage/amber.png: Added.
CodeCoverage/cov.py: Added.
CodeCoverage/emerald.png: Added.
CodeCoverage/gcov.css: Added.
CodeCoverage/glass.png: Added.
CodeCoverage/regenerate-coverage-display: Added.
CodeCoverage/ruby.png: Added.
CodeCoverage/run-generate-coverage-data: Added.
CodeCoverage/snow.png: Added.
Scripts/build-webkit: Add --coverage by Niko
Scripts/check-for-global-initializers: Skip the check on coverage builds
Scripts/generate-coverage-data: Added.
Scripts/run-javascriptcore-tests: Add --coverage by Niko

1:15 PM Changeset in webkit [21847] by weinig

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13896 REGRESSION (NativePopup): Reproductible crasher on Google Coop control panel

fast/forms/select-display-none-style-resolve-expected.checksum: Added.
fast/forms/select-display-none-style-resolve-expected.png: Added.
fast/forms/select-display-none-style-resolve-expected.txt: Added.
fast/forms/select-display-none-style-resolve.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13896 REGRESSION (NativePopup): Reproductible crasher on Google Coop control panel

Test: fast/forms/select-display-none-style-resolve.html

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Do not compute style if the parent does not have style.
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.

1:12 PM Changeset in webkit [21846] by bdash

1 edit in tags/Safari-5522.8.1/WebKit/Configurations/Version.xcconfig

Versioning.

1:10 PM Changeset in webkit [21845] by bdash

1 copy in tags/Safari-5522.8.1

New tag.

1:08 PM Changeset in webkit [21844] by bdash

6 edits in branches/Safari-5522/WebKit

Merge r21840.

12:55 PM Changeset in webkit [21843] by weinig

2 edits in trunk/WebCore

Fix Gdk and Qt builds.

WebCore.pro:

12:38 PM Changeset in webkit [21842] by weinig

78 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

Corrects prototype chain for all HTMLElement subclasses which now only have one HTMLElement prototype and not two.

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

Now that all of the subclasses of JSHTMLElement are autogenerated and no longer rely on the legacy parent, we can remove it and update all the HTML idl files to reflect so.

Also adds JSHTMLBlockquoteElement's JS constructor which was mistakingly missing.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp: (WebCore::JSHTMLAnchorElement::toString):
bindings/js/JSHTMLElementCustom.cpp: Added. (WebCore::JSHTMLElement::pushEventHandlerScope):
bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
bindings/js/JSHTMLInputElementBase.cpp: (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): (WebCore::JSHTMLInputElementBase::put):
bindings/js/JSHTMLInputElementBase.h:
bindings/js/JSHTMLSelectElementCustom.cpp:
bindings/js/kjs_html.cpp: (KJS::runtimeObjectCustomGetOwnPropertySlot):
bindings/js/kjs_html.h:
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLAnchorElement.idl:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBRElement.idl:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLCanvasElement.idl:
html/HTMLDListElement.idl:
html/HTMLDirectoryElement.idl:
html/HTMLDivElement.idl:
html/HTMLElement.cpp: (WebCore::HTMLElement::formForEventHandlerScope):
html/HTMLElement.h:
html/HTMLElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::formForEventHandlerScope):
html/HTMLGenericFormElement.h:
html/HTMLHRElement.idl:
html/HTMLHeadElement.idl:
html/HTMLHeadingElement.idl:
html/HTMLHtmlElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLIsIndexElement.idl:
html/HTMLLIElement.idl:
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::form): (WebCore::HTMLLabelElement::formForEventHandlerScope):
html/HTMLLabelElement.h:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMapElement.idl:
html/HTMLMarqueeElement.idl:
html/HTMLMenuElement.idl:
html/HTMLMetaElement.idl:
html/HTMLModElement.idl:
html/HTMLOListElement.idl:
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::formForEventHandlerScope):
html/HTMLObjectElement.h:
html/HTMLObjectElement.idl:
html/HTMLOptGroupElement.idl:
html/HTMLOptionElement.idl:
html/HTMLParagraphElement.idl:
html/HTMLParamElement.idl:
html/HTMLPreElement.idl:
html/HTMLQuoteElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLTitleElement.idl:
html/HTMLUListElement.idl:
page/DOMWindow.idl:

12:37 PM Changeset in webkit [21841] by ggaren

2 edits in trunk/JavaScriptCore

Slight clarification to an exception message.

API/JSCallbackObject.cpp: (KJS::JSCallbackObject::put):

12:29 PM Changeset in webkit [21840] by bdash

6 edits in trunk/WebKit

2007-05-29 Mark Rowe <mrowe@apple.com>

Reviewed by Geoff.

64-bit build fix. Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.

DefaultDelegates/WebScriptDebugServer.h:
DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:
History/WebBackForwardList.mm: (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]):
WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):

11:47 AM Changeset in webkit [21839] by bdash

2 edits in trunk/WebKitTools

2007-05-29 Mark Rowe <mrowe@apple.com>

Build fix after r21745.

Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.

10:55 AM Changeset in webkit [21838] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Use wxAutoBufferedPaintDC with theme controls too.

8:13 AM Changeset in webkit [21837] by bdash

1 copy in branches/Safari-5522

New branch.

6:53 AM Changeset in webkit [21836] by zack

7 edits
2 adds in trunk

Implementing public settings Api for the Qt port.

Adds value based QWebSettings object which is settable on
a QWebPage. Done after discussions with Lars and Simon.

r=andersca,simon

6:15 AM Changeset in webkit [21835] by ddkilzer

2 edits
15 moves in trunk

LayoutTestResults:

Reviewed by NOBODY (newly passing tests).

http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
qt/tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.

LayoutTests:

Reviewed by NOBODY (newly passing tests).

http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

tables/mozilla/marvin/colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum.
tables/mozilla/marvin/colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png.
tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
tables/mozilla/marvin/colgroup_width_pct.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct.html.
tables/mozilla/marvin/colgroup_width_px-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum.
tables/mozilla/marvin/colgroup_width_px-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png.
tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
tables/mozilla/marvin/colgroup_width_px.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px.html.
tables/mozilla/marvin/x_colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum.
tables/mozilla/marvin/x_colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png.
tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
tables/mozilla/marvin/x_colgroup_width_pct.xml: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml.
tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_pct.html: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/colgroup_width_px.html: Removed.
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png: Removed.
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml: Removed.

May 27, 2007:

10:48 PM Changeset in webkit [23417] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

10:22 PM Changeset in webkit [21834] by kevino

2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Remove unused code and fix keyboard event handling.

9:47 PM Changeset in webkit [21833] by weinig

2 edits in trunk/WebCore

Qt and Gdk build fix.

WebCore.pro:

9:40 PM Changeset in webkit [21832] by weinig

14 edits
3 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

account for the new JSHTMLObjectElement and JSHTMLEmbedElement that are being autogenerated and can now produce constructors.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAppletElementCustom.cpp: Added. (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot): (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::implementsCall): (WebCore::JSHTMLAppletElement::callAsFunction): (WebCore::JSHTMLAppletElement::canGetItemsForName): (WebCore::JSHTMLAppletElement::nameGetter):
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/JSHTMLEmbedElementCustom.cpp: Added. (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot): (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::implementsCall): (WebCore::JSHTMLEmbedElement::callAsFunction): (WebCore::JSHTMLEmbedElement::canGetItemsForName): (WebCore::JSHTMLEmbedElement::nameGetter):
bindings/js/JSHTMLObjectElementCustom.cpp: Added. (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot): (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::implementsCall): (WebCore::JSHTMLObjectElement::callAsFunction): (WebCore::JSHTMLObjectElement::canGetItemsForName): (WebCore::JSHTMLObjectElement::nameGetter):
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::toString): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::runtimeObjectGetter): (KJS::runtimeObjectPropertyGetter): (KJS::runtimeObjectCustomGetOwnPropertySlot): (KJS::runtimeObjectCustomPut): (KJS::runtimeObjectImplementsCall): (KJS::runtimeObjectCallAsFunction):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::classInfo):
bindings/scripts/CodeGeneratorJS.pm: Add support for CustomGetOwnPropertySlot, CustomPutFunction, CustomCall, and SVGCheckSecurityDocument properties.
html/HTMLAppletElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLObjectElement.idl:
page/DOMWindow.idl: Uncomment constructors.

7:23 PM Changeset in webkit [21831] by weinig

2 edits in trunk/WebCore

Reviewed by Oliver.

Gdk build fix.

platform/graphics/Path.h:

7:09 PM Changeset in webkit [21830] by weinig

2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

wtf/Platform.h: Move Gdk up to allow building WebKit/Gdk on Darwin

6:46 PM Changeset in webkit [21829] by weinig

6 edits in trunk/WebCore

Gdk build fix. Forgot to update a few instances of notImplementedGdk() to notImplemented().

page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToScrollbar):
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged):
platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion):
platform/gdk/TemporaryLinkStubs.cpp: (Widget::setEnabled): (Widget::isEnabled): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect):

6:24 PM Changeset in webkit [21828] by weinig

4 edits
1 add in trunk/WebCore

Reviewed by Sam and Oliver.

Implement PathCairo. This patch is based on changes in Mike Emmel's
WebKit fork with some additional clean-ups and updates.

platform/graphics/Path.h:
platform/graphics/cairo/CairoPath.h: Added. (CairoPath::CairoPath): (CairoPath::~CairoPath):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::translate): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addRect): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArc): (WebCore::Path::addArcTo): (WebCore::Path::addEllipse): (WebCore::Path::closeSubpath): (WebCore::Path::boundingRect): (WebCore::Path::contains): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString):

5:39 PM Changeset in webkit [21827] by kevino

50 edits
1 add
1 delete in trunk

WebCore:

Reviewed by Sam Weinig.

Consolidate all notImplemented() macro definitions into
one header file for all platforms.

loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::blockedError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
loader/qt/DocumentLoaderQt.cpp:
page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
page/qt/EventHandlerQt.cpp:
page/qt/FrameQt.cpp:
platform/NotImplemented.h: Added.
platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::respondToChangedSelection): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::handleInputMethodKeypress): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
platform/gdk/NotImplementedGdk.h: Removed.
platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
platform/gdk/ScreenGdk.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (WebCore::findNextWordFromIndex): (WebCore::currentTextBreakLocaleID): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (SearchPopupMenu::enabled): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::selectionRectForComplexText): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (CachedPage::close): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
platform/graphics/cairo/GraphicsContextCairo.cpp:
platform/graphics/cairo/ImageBufferCairo.cpp:
platform/graphics/cairo/PathCairo.cpp:
platform/graphics/gdk/ImageGdk.cpp:
platform/graphics/qt/GraphicsContextQt.cpp:
platform/graphics/qt/IconQt.cpp:
platform/graphics/qt/ImageQt.cpp:
platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
platform/network/qt/ResourceHandleQt.cpp:
platform/qt/ClipboardQt.cpp:
platform/qt/CursorQt.cpp:
platform/qt/DragDataQt.cpp:
platform/qt/FileChooserQt.cpp:
platform/qt/MimeTypeRegistryQt.cpp:
platform/qt/PasteboardQt.cpp:
platform/qt/PlatformScrollBarQt.cpp:
platform/qt/PopupMenuQt.cpp:
platform/qt/ScrollViewQt.cpp:
platform/qt/TemporaryLinkStubs.cpp:
platform/qt/TextBoundaries.cpp:
platform/qt/WidgetQt.cpp:
platform/win/FontWin.cpp:
platform/win/TemporaryLinkStubs.cpp:
platform/wx/ClipboardWx.cpp:
platform/wx/FontWx.cpp:
platform/wx/ScrollViewWx.cpp:
platform/wx/SharedTimerWx.cpp:
platform/wx/TemporaryLinkStubs.cpp:

WebKitQt:

Reviewed by Sam Weinig.

Consolidate all notImplemented() macro definitions into
one header file for all platforms.

WebCoreSupport/ChromeClientQt.cpp:
WebCoreSupport/ContextMenuClientQt.cpp:
WebCoreSupport/EditorClientQt.cpp:
WebCoreSupport/FrameLoaderClientQt.cpp:

4:37 PM Changeset in webkit [21826] by kevino

2 edits in branches/wx-port-alpha/trunk

Use wxAutoBufferedPaintDC to make sure we don't get any flicker on Windows. (It doesn't buffer on platforms whose drawing is already double-buffered.)

4:31 PM Changeset in webkit [21825] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageSourceWx.cpp

Remove unused code.

3:40 PM Changeset in webkit [21824] by darin

2 edits in trunk/JavaScriptCore

fix a couple ifdefs that said WIN instead of WIN_OS

kjs/collector.cpp: (KJS::allocateBlock): WIN -> WIN_OS (KJS::freeBlock): Ditto.

3:07 PM Changeset in webkit [21823] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/FontWx.cpp

Calculate the correct y position to draw the text.

12:59 PM Changeset in webkit [21822] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp

Improve detection of invalid values for the shared timer, and assert if the timer interval == 0.

7:52 AM Changeset in webkit [21821] by kevino

1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/kjs/collector.cpp

Use Windows virtual memory functions on Windows even when not building the Windows port.

2:49 AM Changeset in webkit [21820] by rwlbuis

4 edits
4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13828
x/y values on rootmost <svg> elements should be ignored

Make sure that root-most <svg> elements do not take into account x/y.

May 26, 2007:

11:09 PM Changeset in webkit [21819] by hyatt

5 edits
6 adds in trunk

Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
Improve <object> error handling so that it recovers properly when
<td> is used inside it.

Reviewed by olliej

Added fast/invalid/td-inside-object.html

html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::tagPriority):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h:

10:01 PM Changeset in webkit [21818] by hyatt

2 edits in trunk/WebCore

Don't compare the "isset" variables in background layers, since they
lead us to turn off the Aqua look incorrectly, even when the background
matches the default.

Reviewed by olliej

rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::operator==):

9:56 PM Changeset in webkit [21817] by hyatt

3 edits in trunk/WebCore

Improve the </p> -> <p></p> error message to not spew two errors.
Fix a bug where errors reported inside document.write didn't get
reported as such because of a mistake in the notation of SegmentedString.

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::processCloseTag):
platform/SegmentedString.h: (WebCore::SegmentedSubstring::clear):

9:53 PM Changeset in webkit [21816] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 13887.

9:52 PM Changeset in webkit [21815] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Make sure the function returns a value.

9:51 PM Changeset in webkit [21814] by hyatt

2 edits in trunk/WebCore

Fix for bug 13887, percentage height block not sized correctly inside
positioned percentage height containing block.

Reviewed by mitz

fast/block/positioning/complex-percentage-height.html

rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):

8:45 PM Changeset in webkit [21813] by kevino

16 adds in branches/wx-port-alpha/trunk/WebCore

More additions, hopefully the last batch.

8:34 PM Changeset in webkit [21812] by kevino

3 adds in branches/wx-port-alpha/trunk/WebCore/rendering

More files the merge didn't mark as added.

8:31 PM Changeset in webkit [21811] by kevino

1 add in branches/wx-port-alpha/trunk/WebCore/rendering/LayoutState.h

Another merge file that wasn't marked for addition to the branch

8:27 PM Changeset in webkit [21810] by kevino

3 adds in branches/wx-port-alpha/trunk/WebCore/html

The merge didn't properly mark these files as added on the branch, so add them ourselves.

7:35 PM Changeset in webkit [21809] by kevino

732 edits
2 copies
35 deletes in branches/wx-port-alpha/trunk

Sync wx port with TOT, and fix a bug with iconv detection in install-unix-extras.

4:09 PM Changeset in webkit [21808] by andersca

3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

finish fixing http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls

Covered by fast/forms/box-shadow-override.html

I forgot to include adjustSliderThumbStyle in the previous patch and the
test didn't detect it because of a bug introduced in r21739.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle):

3:09 PM Changeset in webkit [21807] by weinig

11 edits in trunk

LayoutTests:

Reviewed by Hyatt.

updated tests for http://bugs.webkit.org/show_bug.cgi?id=13876 Box-Shadow disappears if shadow doesn't fit in the window size

fast/repaint/box-shadow-h-expected.checksum:
fast/repaint/box-shadow-h-expected.png:
fast/repaint/box-shadow-h-expected.txt:
fast/repaint/box-shadow-h.html:
fast/repaint/box-shadow-v-expected.checksum:
fast/repaint/box-shadow-v-expected.png:
fast/repaint/box-shadow-v-expected.txt:
fast/repaint/box-shadow-v.html:

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13876 Box-Shadow disappears if shadow doesn't fit in the window size

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

rendering/RenderTable.cpp: (WebCore::RenderTable::layout):

2:57 PM Changeset in webkit [21806] by weinig

5 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

special case calling String.localeCompare() with no parameters to return 0.

kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

Update tests http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

update tests and results to match kde.

fast/js/kde/StringObject-expected.txt:
fast/js/kde/resources/StringObject.js:

10:38 AM Changeset in webkit [21805] by bdash

4 edits in trunk

Versioning.

10:26 AM Changeset in webkit [21804] by bdash

1 copy in tags/Safari-5522.8

New tag.

8:36 AM Changeset in webkit [21803] by ap

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13605
REGRESSION: Browser crashes when switching Kotoeri input modes

The problem could no longer be reproduced with Kotoeri thanks to
a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
but we still need to protect from invalid ranges passed from
input methods.

Test: editing/input/replace-invalid-range.html

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectNSRange:]): Added a null check.

8:26 AM Changeset in webkit [21802] by darin

1 edit in trunk/WebKit/ChangeLog

"on this makefile itself"

8:24 AM Changeset in webkit [21801] by darin

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

MigrateHeaders.make: Added dependency on this header file itself, which is useful when you change the sed command or other aspect of this file. My build failed until I made this fix.

7:40 AM Changeset in webkit [21800] by darin

2 edits in trunk/WebCore

platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Alexey pointed out that I was wrong about object lifetime, so rolling this change out.

7:32 AM Changeset in webkit [21799] by darin

2 edits in trunk/WebCore

Reviewed by Anders.

platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Fixed code where a temporary String is used after destroyed.

6:36 AM Changeset in webkit [21798] by bdash

2 edits in trunk/WebCore

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13842 Simplify Color::light() and Color::dark()

Not testable.

platform/graphics/Color.cpp: (WebCore::Color::light): (WebCore::Color::dark):

6:32 AM Changeset in webkit [21797] by bdash

7 edits in trunk

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13870 RenderFrameSet should only allow frame and frameset children

Covered by fast/frames/inline-object-inside-frameset.html

rendering/RenderFrame.h: (WebCore::RenderFrame::isFrame): Added.
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): Removed check for inline objects that is no longer needed. (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only if it is a frame or another frameset.
rendering/RenderFrameSet.h:
rendering/RenderObject.h: (WebCore::RenderObject::isFrame): Added.

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

updated test results for http://bugs.webkit.org/show_bug.cgi?id=13870 RenderFrameSet should only allow frame and frameset children

fast/frames/inline-object-inside-frameset-expected.txt:

6:29 AM Changeset in webkit [21796] by bdash

5 edits
4 adds in trunk

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls

Test: fast/forms/box-shadow-override.html

rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls

fast/forms/box-shadow-override-expected.checksum: Added.
fast/forms/box-shadow-override-expected.png: Added.
fast/forms/box-shadow-override-expected.txt: Added.
fast/forms/box-shadow-override.html: Added.

6:14 AM Changeset in webkit [21795] by bdash

2 edits in trunk/WebCore

2007-05-26 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

platform/gdk/FrameGdk.cpp: Catch up to make it compile (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page

12:05 AM Changeset in webkit [23416] by oliver

2 edits in branches/WindowsMerge/WebKitWin

2007-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.

Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)

WebFrame.cpp: (WebFrame::objectContentType):

May 25, 2007:

8:06 PM Changeset in webkit [21794] by weinig

2 edits in trunk/WebCore

Reviewed by Oliver of the Hunt.

Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in
Leopard because they are being interpreted as html

Adds a work around for <rdar://problem/5230154> which explicitly
sets local .xhtml files to have the MIME type application/xhtml+xml.

platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse):

7:49 PM Changeset in webkit [23415] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Corrected a filename and commented out a disabled test.

7:31 PM Changeset in webkit [23414] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed tests that fail on Mac as well to keep the list Windows-specific.

7:20 PM Changeset in webkit [23413] by ggaren

3 edits in branches/WindowsMerge/WebKitWin

Build fix -- forgot to commit a little bit in my last patch.

5:58 PM Changeset in webkit [23412] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Finish adding all currently failing tests.

5:40 PM Changeset in webkit [23411] by ggaren

11 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin Adler, Adam Roben.

Fixed <rdar://problem/5055182> The page cache has no global cap.

The main WebKit changes are:

Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: pageCacheSize because they're deprecated on Mac now. I didn't remove them, though, because doing so can cause COM badness.

Added IWebPreferences::setUsesPageCache IWebPreferences:: usesPageCache because that's the new Mac API. I added them to the end of IWebPreferences to avoid COM badness.

Centralized calculation of object cache and page cache sizes inside WebPreferences.

Changed our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98.)

5:28 PM Changeset in webkit [21793] by ggaren

31 edits in trunk

WebCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.

Beefed up the PageCache class to track which HistoryItems are
cached, and decide how to evict old HistoryItems as new ones are
added.

history/BackForwardList.cpp: Removed support for managing the page cache through the BackForwardList since this is deprecated in Mac's WebBackForwardList, and doesn't exist on other platforms.

Added a Page* back pointer so that Mac WebBackForwardList can still support
its deprecated API, using the new hotness. This isn't a big burden, since
Page is responsible for calling BackForwardList::close upon destruction,
anyway.

history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells you whether you're in the page cache. This prevents us from having more than one persistent repository for cached pages.

history/PageCache.cpp: If you're playing along at home, this code is the reason for the patch.

loader/FrameLoader.cpp: If you're playing along at home, the minuses in this file are the reason for the patch.

Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
implementation because WebCore calling itself through WebKit is uncivilized.

page/Settings.cpp: Added support for removing a Page's HistoryItems from the page cache.

WebKit:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.

The main WebKit changes are:

Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList pageCacheSize] to accomodate the new global page cache model, updating their documentation.

Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences shouldUsePageCache] as pending public API.

Centralized calculation of object cache and page cache sizes inside WebPreferences.

Cchanged our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98. ???)

WebView/WebView.mm: Added support for two flags to determine whether to use the page cache. If either -[WebBackForwardList setPageCacheSize:0] or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use the page cache.

5:23 PM Changeset in webkit [23410] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Added a bunch more failing tests.

4:56 PM Changeset in webkit [21792] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp

Never fire the timer immediately, even with a 0 second delay, in order to give the calling function time to complete.

4:53 PM Changeset in webkit [21791] by andersca

1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735

fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):

4:50 PM Changeset in webkit [21790] by darin

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13456 REGRESSION: setTimeout "arguments" object gets shadowed by a local variable

Add a explicit check for arguments. Previously check was done with getDirect, but since the arguments is created on-demand in ActivationImp, it doesn't show up in the test. 'arguments' should always be in the VarDeclNode's evaluation scope.

kjs/nodes.cpp: (VarDeclNode::evaluate): Additional check if the var decl identifier is 'arguments'

LayoutTests:

Reviewed by Darin.

Test cases for http://bugs.webkit.org/show_bug.cgi?id=13456 REGRESSION: setTimeout"arguments" object gets shadowed by a local variable

fast/js/resources/vardecl-preserve-arguments.js: Added.
fast/js/vardecl-preserve-arguments-expected.txt: Added.
fast/js/vardecl-preserve-arguments.html: Added.

4:45 PM Changeset in webkit [21789] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735

Added a test that ::-webkit-slider-thumb style is actually applied.

fast/forms/slider-thumb-stylability-expected.checksum: Added.
fast/forms/slider-thumb-stylability-expected.png: Added.
fast/forms/slider-thumb-stylability-expected.txt: Added.
fast/forms/slider-thumb-stylability.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735

fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):

4:33 PM Changeset in webkit [21788] by mjs

1 edit
3 moves in trunk/LayoutTests

Reviewed by Geoff.

fix layout test that is failing due to hardcoded file paths in the results by moving it to the http tests

fast/history/redirect-load-no-form-restoration-expected.txt: Removed.
fast/history/redirect-load-no-form-restoration.html: Removed.
fast/history/resources/redirect-load.html: Removed.
http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Added.
http/tests/redirect-load-no-form-restoration.html: Removed.
http/tests/resources/redirect-load.html: Removed.

4:27 PM Changeset in webkit [21787] by kmccullo

2 edits in trunk

LayoutTests:

Reviewed by .

updating previous comment.

ChangeLog:

WebCore:

Reviewed by.

Updating previous comment.

ChangeLog:

4:21 PM Changeset in webkit [21786] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

editing/style/5228141-expected.checksum: Added.
editing/style/5228141-expected.png: Added.
editing/style/5228141-expected.txt: Added.
editing/style/5228141.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use range compliant equivalents when creating the Range used to compute pastEndNode(), otherwise Range's constructor ASSERTs and pastEndNode() returns null. Added a testcase. If the incoming Range is collapsed at [br, 0], callers want the style to be applied to the br, so expand the Range to include it. We got away without expanding before because pastEndNode of a Range from [br, 0] to [br, 0] is the node after the br. Using range compliant equivalents changed that. There's already test coverage for this change. Changed while loop termination for finding the end of a run so that we don't process pastEnd. end.node() may now be non-atomic and we'd blow past it. There's already test coverage for this change.

4:02 PM Changeset in webkit [21785] by bdakin

2 edits in trunk/WebCore

Rubber stamped by Hyatt

Adding an ASSERT for good measure.

page/FrameView.cpp: (WebCore::FrameView::layout):

3:59 PM Changeset in webkit [21784] by kmccullo

4 edits
8 copies
2 adds in trunk

LayoutTests:

Reviewed by Geoff.

rdar://problem/5183523
Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
These tests do not dumpAsText since DRT doesn't seem to be able to handle text in frames. If it is in the future then these tests already have sufficient text to change to that output and give correct results.

fast/dom/frame-loading-via-document-write-expected.txt: Added.
fast/dom/frame-loading-via-document-write.html: Added.
fast/dom/resources/abe.png: Added.
http/tests/security/frame-loading-via-document-write-expected.txt: Added.
http/tests/security/frame-loading-via-document-write.html: Added.
http/tests/security/resources/abe.png: Added.

WebCore:

Reviewed by Geoff.

rdar://problem/5183523
Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad):
loader/FrameLoader.h:

3:45 PM Changeset in webkit [21783] by staikos

2 edits in trunk/JavaScriptCore

2007-05-25 George Staikos <staikos@kde.org>

Reviewed by Maciej.

Use COMPILER(GCC), not PLATFORM(GCC) - as Platform.h defines

wtf/FastMalloc.h:

3:43 PM Changeset in webkit [21782] by andersca

5 edits in trunk/WebCore

Reviewed by Brady.

<rdar://problem/5209536>
http://bugs.webkit.org/show_bug.cgi?id=13757
REGRESSION: Leaks seen on buildbot after r21497.

Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set
is not considered when asking a document loader if it's currently loading.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Always stop the multipart subresource loaders here.

(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.

loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress): If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.

loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.

3:20 PM Changeset in webkit [21781] by thatcher

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/5219089> Changes for migration of DictionaryServices

WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox

2:52 PM Changeset in webkit [21780] by pyeh

2 edits in trunk/WebCore

<rdar://problem/4918397> Exception raise inspecting note contents in the background

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Only allow asking the attachmentView for description if attachmentView supports this description attribute

2:51 PM Changeset in webkit [21779] by ggaren

3 edits in trunk/WebKit

Reviewed by Oliver Hunt.

Fixed global initializer (like you fix a dog).

I'm not sure how our script missed this. I tested, and it generally doesn't
seem to work very well.

WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of a global initializer. (promisedDataClient): (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):

2:44 PM Changeset in webkit [21778] by bdakin

2 edits in trunk/WebCore

Reviewed by Oliver and Hyatt.

Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to
create a To Do results in a crash

This regressed with r21635. Now that -boundingBox updates layout if
it is needed, we infinitely recurse when Mail draws a custom
highlight. The fix is to put a guard around laying out the render
tree.

page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):

2:06 PM Changeset in webkit [23409] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Updated the underlying bug for a test.

2:04 PM Changeset in webkit [21777] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsAttributeSettable:]): Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so this attribute can actually announce its settability.

1:37 PM Changeset in webkit [21776] by beidson

2 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty

This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
made applewebdata urls result in check.call(false) instead of check.call(true)

Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
really is rooted in WebView

<rdar://problem/5229587> tracks adding a layout test

WebView/WebView.mm: (+[WebView _canHandleRequest:]): Return true for applewebdata URLs

1:24 PM Changeset in webkit [21775] by darin

3 edits in trunk/LayoutTests

updated tests results that were affected by Hyatt's change to turn the odious <script/> quirk back on

fast/parser/script-tag-with-trailing-slash-expected.txt: Updated test result to reflect now-expected failure. It would be good some day to change the test to be more clear that this is working as designed.

fast/tokenizer/script_extra_close-expected.txt: Updated.

1:19 PM Changeset in webkit [21774] by darin

1 edit
4 deletes in trunk/LayoutTests

Hixie (who originally wrote this test) and Hyatt say that this test is invalid, and should be removed -- and it's failing too so gotta remove it

fast/block/basic/017-expected.checksum: Removed.
fast/block/basic/017-expected.png: Removed.
fast/block/basic/017-expected.txt: Removed.
fast/block/basic/017.html: Removed.

1:00 PM Changeset in webkit [21773] by darin

2 edits in trunk/WebCore

Reviewed by Alice.

fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't immediately inserted when tabbing into or clicking in the message body

This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
which removed some code that did extra work whenever setCaretVisible made the caret visible.

page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect when turning the caret on. All other call sites that touched m_caretPaint were doing this, but this was not.

12:34 PM Changeset in webkit [21772] by yongjzha

3 edits in S60/trunk/JavaScriptCore

2007-05-23 malaiya,

reviewed by Yongjun
DESC: disabled 'SUPPORT_UTF8'flag support in prce
http://bugs.webkit.org/show_bug.cgi?id=13847
TSW ID : ELWI-6Z2AAU

pcre/pcre-config.h:
pcre/pcre.c: (pcre_compile):

12:13 PM Changeset in webkit [21771] by darin

2 edits in trunk/WebCore

Reviewed by Harrison.

DerivedSources.make: Tweaked spelling.

12:11 PM Changeset in webkit [21770] by thatcher

1 edit in trunk/WebCore/css/CSSGrammar.y

Touching this to force DerivedSources.make to rebuild.

12:07 PM Changeset in webkit [21769] by darin

5 edits in trunk/LayoutTests

updated some test results that were affected by Anders's change to make image documents use quirks mode

dom/xhtml/level2/html/frame-expected.txt: Updated.
dom/xhtml/level2/html/iframe-expected.txt: Updated.
editing/pasteboard/copy-standalone-image-expected.txt: Updated.
fast/events/standalone-image-drag-to-editable-expected.txt: Updated.

11:59 AM Changeset in webkit [21768] by ggaren

5 edits in trunk/WebKit

Reviewed by Darin Adler, Tim Hatcher.

"unsigned" => "WebNSUInteger" in public API.

History/WebBackForwardList.h:
WebView/WebScriptDebugDelegate.h:
WebView/WebUIDelegate.h:
WebView/WebViewPrivate.h:

11:51 AM Changeset in webkit [21767] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13872 REGRESSION: An empty search field can have a cancel button

fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
fast/forms/search-cancel-button-style-sharing-expected.png: Added.
fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
fast/forms/search-cancel-button-style-sharing.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13872 REGRESSION: An empty search field can have a cancel button

Test: fast/forms/search-cancel-button-style-sharing.html

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of the cancel button style between search fields that share style, because each search field mutates the style to show and hide the cancel button.

11:39 AM Changeset in webkit [21766] by andersca

3 edits in trunk/WebKitTools

Fix build.

DumpRenderTree/DumpRenderTree.m:
DumpRenderTree/FrameLoadDelegate.m:

11:04 AM Changeset in webkit [21765] by harrison

3 edits in trunk/WebCore

Reviewed by Kevin and Geoff.

DerivedSources.make: Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not

css/maketokenizer: Unconditionally define the flex basic types that are not part of newer versions of flex. Was only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.

10:50 AM Changeset in webkit [21764] by ggaren

11 edits
1 delete in trunk

WebCore:

Reviewed by Darin Adler.

Moved JavaScriptCore-related pending public API to public API.

Moved -JSObject

bindings/objc/WebScriptObjectPendingPublic.h: from here
bindings/objc/WebScriptObject.h: to here
bindings/objc/WebScriptObject.mm: and out of its temporary category

WebKit:

Reviewed by Darin Adler.

Moved JavaScriptCore-related pending public API to public API.

MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from automatically converting to <WebKit/JSBase.h>

Moved -windowObject and -globalContext

WebView/WebFramePrivate.h: from here
WebView/WebFrame.h: to here
WebView/WebFrame.mm: and out of its temporary category

Moved -didClearWindowObject:forFrame:

WebView/WebViewPrivate.h: from here
WebView/WebFrameLoadDelegate.h: to here

10:43 AM Changeset in webkit [21763] by darin

2 edits in trunk/LayoutTests

fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success. A recent check-in fixed this test, but nobody checked in updated results.

10:27 AM Changeset in webkit [21762] by darin

8 edits in trunk/LayoutTests

updated some test results that were affected by Hyatt's fix for <rdar://problem/5208440> REGRESSION: Raw text needs to be pulled outside of tables (13753)

The whitespace in the DOM has changed the child indices of various elements,
which shows up in the caret and selection logging.

editing/deleting/5026848-2-expected.txt: Updated.
editing/deleting/5026848-3-expected.txt: Updated.
editing/deleting/5126166-expected.txt: Updated.
editing/deleting/delete-block-table-expected.txt: Updated.
fast/forms/input-double-click-selection-gap-bug-expected.txt: Updated.
fast/replaced/selection-rect-in-table-cell-expected.txt: Updated.
fast/text/textIteratorNilRenderer-expected.txt: Updated.

10:26 AM Changeset in webkit [21761] by weinig

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
Create the error node based on the actual node, not the node inside parenthesis
Fix applies to postfix, prefix and typeof operators
Produces run-time ReferenceError like other non-lvalue assignments etc.

kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node, not the based on the node returned by "nodeInsideAllParens()". Same for TypeOfValueNode.

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
Contains tests for grouping expression that is inside typeof or prefix/postfix expression

fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
fast/js/toString-prefix-postfix-preserve-parens.html: Added.

10:14 AM Changeset in webkit [21760] by weinig

6 edits
5 adds in trunk

LayoutTests:

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13767 REGRESSION: Multipart image documents are garbled

http/tests/multipart/invalid-image-data-standalone-expected.checksum: Added.
http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
http/tests/multipart/invalid-image-data-standalone.html: Added.
http/tests/multipart/resources/green-100x100.png: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13767 REGRESSION: Multipart image documents are garbled

Test: http/tests/multipart/invalid-image-data-standalone.html

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
loader/DocumentLoader.h:
loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy of the current part instead of using the resource data, which is going to be overwritten by the next part.
loader/MainResourceLoader.h: (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.

9:52 AM Changeset in webkit [21759] by andersca

2 edits in trunk/WebCore

Fix no-svg build.

bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):

9:15 AM Changeset in webkit [21758] by andersca

2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass

One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
after it has been zoomed in.

loader/ImageDocument.cpp: (WebCore::ImageDocument::windowSizeChanged):

9:06 AM Changeset in webkit [21757] by sullivan

2 edits in trunk/WebKit

Reviewed by Anders and Tim

fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply

WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkGrammarOfString): Fixed recently-introduced false assumption that NSNotFound == -1

9:06 AM Changeset in webkit [21756] by sullivan

2 edits in trunk/WebCore

Reviewed by Anders and Tim

WebCore change for: <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply

editing/Editor.cpp: (WebCore::findFirstBadGrammarInRange): Use the more obvious way to check whether a range is empty. In this case the more obvious way would also have caused no problem to occur. Also added an assertion. Though this change is enough to fix the symptom of the bug, the real fix is in WebKit.

8:51 AM Changeset in webkit [21755] by andersca

2 edits in trunk/WebCore

Reviewed by Darin (Sorta).

loader/ImageDocument.cpp: (WebCore::ImageDocument::restoreImageSize): Use removeProperty here.

8:37 AM Changeset in webkit [21754] by staikos

2 edits in trunk/WebKitQt

The http loader should only ask for http cookies. (not, for example, data: cookies)

7:47 AM Changeset in webkit [21753] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl

Relink wxWebKit if webcore or jscore dependencies change.

6:37 AM Changeset in webkit [21752] by hausmann

4 edits in trunk/WebKitTools

For the keyDown binding use QStringList instead of QList<QString>. The former is a default
registered metatype. Also print out critical messages in dumprendertree's qt message handler.

6:37 AM Changeset in webkit [21751] by hausmann

3 edits in trunk/JavaScriptCore

Fix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
registered with QMetaType.

2:46 AM Changeset in webkit [21750] by ggaren

4 edits in trunk/WebCore

Reviewed by Darin Adler.

Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache
has no global cap.

loader/Cache.cpp: Removed destructor to help identify this class as a singleton.

loader/Cache.h: Made constructor and destructor private to match the singleton model of PageCache.

Put structs related to Cache inside its declaration to fix some namespace
conflicts I had while writing my patch. (They don't exist anymore, but
I figured this might help future development.)

2:35 AM Changeset in webkit [23408] by ggaren

1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

removing conflict markers from ChangeLog

2:27 AM Changeset in webkit [23407] by ggaren

4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

2:13 AM Changeset in webkit [21749] by ggaren

38 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.

css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It held a number of back pointers that were not guaranteed. I removed the Settings*, Frame*, and FrameView* back pointers, but others could probably go, too. I replaced them with a single Document* pointer, which is guaranteed because the Document owns the CSSStyleSelector.

page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the Settings object is now a proper subcontroller of Page, so it doesn't need to use a global table to find its page anymore. Also, this function confusingly implied that the Frames in a page can have heterogeneous settings, which is not true.

12:42 AM Changeset in webkit [21748] by bdakin

4 edits in trunk/WebKit

Reviewed by Geoff.

Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash
after closing QuickBooks Tutorial Center with Leopard9A377

We can hit a race condition where drawRect will be called after the
WebView has closed. Quickbooks does not properly close the WebView
and set the UIDelegate to nil, so the UIDelegate is stale and we
crash. This is a regression because the code that uses the
UIDelegate in the drawRect code path was only added recently. The
method that the UIDelegate calls into is new -- it does not exist
on Tiger -- so there is no harm in not running this code for
applications linked against older WebKits. Other applications may
run into this same bug so I am not doing a bundle
check...particularly because, as I mentioned, the new UIDelegate
call would not be implemented by older clients anyway.

Misc/WebKitVersionChecks.h:
WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]):

12:10 AM Web Inspector edited by smith@sideshowbarker.net

HUD = Heads-Up Display (diff)

12:07 AM Changeset in webkit [21747] by hyatt

2 edits in trunk/WebCore

Make sure -webkit-border-fit accounts for padding as well as border.

Reviewed by aroben

rendering/RenderBlock.cpp: (WebCore::RenderBlock::borderFitAdjust):

12:02 AM Web Inspector edited by smith@sideshowbarker.net

added link to Surfin' Safari blog entry (diff)

May 24, 2007:

11:58 PM Changeset in webkit [21746] by hyatt

8 edits in trunk/WebCore

Rework line numbering (again). This time I finally think I have
it right for all the document.write insanity that can occur.

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserDocumentWriteMessage):
html/HTMLParserErrorCodes.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr): (WebCore::HTMLTokenizer::processingContentWrittenByScript):
platform/SegementedSring.cpp (WebCore::SegmentedString::setExcludeLineNumbers):
platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::clear): (WebCore::SegmentedSubstring::excludeLineNumbers): (WebCore::SegmentedSubstring::setExcludeLineNumbers): (WebCore::SegmentedString::excludeLineNumbers): (WebCore::SegmentedString::advance):

11:56 PM Web Inspector edited by smith@sideshowbarker.net

boldface Inspect Element (diff)

11:48 PM Web Inspector edited by smith@sideshowbarker.net

added WI UI image (diff)

11:13 PM Changeset in webkit [21745] by ggaren

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Added a debug-only CachedPage counter. This helped me track down an SVG
timer bug in my recent page cache work.

history/CachedPage.cpp:

11:05 PM Changeset in webkit [21744] by sfalken

1 copy in tags/Safari-522.8.3b

New tag.

9:42 PM Changeset in webkit [21743] by hyatt

4 edits in trunk/WebCore

Improve <form> error reporting to catch <form>s inside table parts.
Tweak the wording of some of the error messages to be a bit better.

Reviewed by olliej

html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h:

6:28 PM Changeset in webkit [21742] by weinig

6 edits
8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test cases for:
http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

fast/css/first-letter-hover-expected.checksum: Added.
fast/css/first-letter-hover-expected.png: Added.
fast/css/first-letter-hover-expected.txt: Added.
fast/css/first-letter-hover.html: Added.
fast/css/first-letter-visibility-expected.checksum: Added.
fast/css/first-letter-visibility-expected.png: Added.
fast/css/first-letter-visibility-expected.txt: Added.
fast/css/first-letter-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

Update first letter when RenderBlock::setStyle is called.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
dom/Document.h: (WebCore::Document::usesFirstLetterRules): (WebCore::Document::setUsesFirstLetterRules):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle): (WebCore::RenderBlock::updateFirstLetter):

6:15 PM Changeset in webkit [21741] by kevino

5 edits in branches/wx-port-alpha/trunk/WebCore/platform

Fix crash caused by Widget::setCursor not checking for a null implementation. This can happen because we don't implement image cursors yet. Also add a wxBitmap accessor to BitmapImage to make it easier to add such support in the future.

5:09 PM Creating and Submitting Layout Tests and Patches created by KWhiteRight@gmail.com

4:57 PM Changeset in webkit [21740] by weinig

5 edits in trunk/LayoutTests

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13823 REGRESSION: fast/forms/select-item-background-clip.html failing pixel test

Updated the test and the results.

fast/forms/select-item-background-clip-expected.checksum:
fast/forms/select-item-background-clip-expected.png:
fast/forms/select-item-background-clip-expected.txt:
fast/forms/select-item-background-clip.html:

4:51 PM Changeset in webkit [21739] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider

fast/forms/slider-thumb-shared-style-expected.checksum: Added.
fast/forms/slider-thumb-shared-style-expected.png: Added.
fast/forms/slider-thumb-shared-style-expected.txt: Added.
fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider

Test: fast/forms/slider-thumb-shared-style.html

RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.

rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.

4:48 PM Changeset in webkit [21738] by adele

6 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

fast/history/redirect-load-no-form-restoration-expected.txt: Added.
fast/history/redirect-load-no-form-restoration.html: Added.
fast/history/resources/redirect-load.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

Test: fast/history/redirect-load-no-form-restoration.html

history/HistoryItem.cpp: (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem. (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url. This might not be the best way to do this, but it works for now.
history/HistoryItem.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.

4:36 PM WikiStart edited by KWhiteRight@gmail.com

(diff)

4:35 PM Changeset in webkit [21737] by kevino

1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Remove tabs that accidently got into the file.

4:28 PM Changeset in webkit [21736] by weinig

5 edits in trunk/JavaScriptCore

Reviewed by Darin

Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
Port patch 666176 to JavaScriptCore

Renamed JSValue::downcast() to JSValue::asCell() which makes the function meaning cleaner. It's modeled after Harri Porten change in KDE trunk.

kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly):
kjs/object.h: (KJS::JSValue::isObject):
kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString): (KJS::JSValue::toObject):

4:20 PM Changeset in webkit [21735] by hyatt

59 edits in trunk/LayoutTests/tables

Update results for better whitespace handling in framesets and tables.

4:05 PM Changeset in webkit [21734] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test for http://bugs.webkit.org/show_bug.cgi?id=13857 REGRESSION: onChange function applied to select element executes twice when focus is set

fast/forms/select-double-onchange-expected.txt: Added.
fast/forms/select-double-onchange.html: Added.

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13857 REGRESSION: onChange function applied to select element executes twice when focus is set

Test: fast/forms/select-double-onchange.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex before dispatching the change event to avoid reentrancy.

3:58 PM Changeset in webkit [21733] by hyatt

3 edits in trunk/LayoutTests/webarchive

Update results for better whitespace handling in framesets and tables.

3:56 PM Changeset in webkit [21732] by darin

13 edits in trunk/WebCore

Reviewed by Hyatt.

fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes are missing the lines on the side

This patch fixes three problems:

1) makes the "skip canLoad check" boolean also skip the check

that prevents any loads while the document is in provisional
state; this is the proximate cause of the bug

loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Don't check the frame's state if skipCanLoadCheck is true.

2) moves the "skip canLoad check" boolean to the Request object;

the old implementation would cause that flag to affect the
new request we served, which might not be the resource with
that flag set

3) fixes error-handling code path that would leak requests

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Pass false to the CachedImage constructor to indicate we are not making this object for the cache.

loader/Cache.cpp: (WebCore::createResource): Pass true to the CachedImage constructor to indicate we are making this object for the cache. (WebCore::Cache::requestResource): Add new code that assumes the object will already have the inCache bit set, and that will delete the object and return 0 if the cache is disabled and the load failed.

loader/CachedImage.h:
loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Added a forCache boolean parameter. Always false for the constructor that's only used outside the cache code, and passed in as a boolean for the constructor that's used both in cache and outside cache.

loader/CachedResource.h:
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): Added a forCache boolean parameter that determines the initial state of the m_inCache flag. This is needed to prevent a resource from being destroyed if an error occurs during the initial load.

loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME. (WebCore::DocLoader::setLoadInProgress): Added null check.

loader/Request.h:
loader/Request.cpp: (WebCore::Request::Request): Added a shouldSkipCanLoadCheck boolean here, since we need to track this for each request.

loader/loader.h:
loader/loader.cpp: (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the Request constructor rather than to the servePendingRequests function. (WebCore::Loader::servePendingRequests): Add a loop so we can handle cases where the request fails immediately without leaking the request and thinking that we're loading forever.

3:29 PM Changeset in webkit [21731] by hyatt

4 edits in trunk/WebCore

Add error reporting for residual style.

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h:

3:13 PM Changeset in webkit [21730] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

2:49 PM Changeset in webkit [21729] by hyatt

24 edits in trunk/LayoutTests/dom/xhtml/level2/html

Land updated tests.

1:57 PM Changeset in webkit [21728] by oliver

2 edits in trunk/WebKit

2007-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Adam, Darin, and Geoff.

Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
function returns incorrect symbol due to inconsistent range
domains in TSM

Text Services Management uses ranges provided by the
NSTextInput API to index into the string return by
-[WebHTMLView string]. As a result some input methods
incorrectly get their candidate text from the beginning
of the document instead of from the input element.

TSM prefers to query -textStorage over -string so as a
workaround we provide an implementation of -textStorage that
returns the content of the current text input. TSM only ever
queries the result of textStorage as an NSAttributedString so
we do not need to implement a fake NSTextStorage class

This should not cause harm to anything else as textStorage is
actually a method on NSTextView, which we clearly are not. TSM
only queries the method because it uses respondsToSelector to
control behaviour.

WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):

1:45 PM Changeset in webkit [21727] by hyatt

4 edits in trunk/WebCore

Report <script/> as a warning instead of an error for now, since we
actually do close it. (Sigh.)

Reviewed by beth

html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate): (WebCore::isWarning):
html/HTMLParserErrorCodes.h:

1:26 PM Changeset in webkit [21726] by hyatt

5 edits in trunk/WebCore

Add error reporting for the </p> -> <p></p> quirk.

Add error reporting when a stray close tag is encountered with no
corresponding open tag.

Reviewed by adele

html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
html/HTMLParser.h: (WebCore::HTMLParser::popBlock):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h:

1:16 PM Changeset in webkit [21725] by kmccullo

2 edits in trunk/LayoutTests

Reviewed by.

Do you ever feel like Charlie Brown? *sigh*

fast/dom/HTMLHeadElement/resources/head-check.js:

1:06 PM Changeset in webkit [21724] by kmccullo

5 edits
9 deletes in trunk

LayoutTests:

Reviewed by.

Rolling back change to fix the build until I have a good fix for data: urls.

ChangeLog:
fast/dom/HTMLHeadElement/resources/head-check.js:
fast/dom/frame-loading-via-document-write-expected.txt: Removed.
fast/dom/frame-loading-via-document-write.html: Removed.
fast/dom/resources/frame-loading-via-document-write.js: Removed.
fast/dom/resources/green250x50.png: Removed.
fast/dom/resources/success.html: Removed.
http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
http/tests/security/frame-loading-via-document-write.html: Removed.
http/tests/security/resources/frame-loading-via-document-write.js: Removed.
http/tests/security/resources/success.html: Removed.

WebCore:

Reviewed by.

Rolling back change to fix the build until I have a good fix for data: urls.

ChangeLog:
loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
platform/String.cpp:

12:54 PM Changeset in webkit [21723] by hyatt

6 edits in trunk/WebCore

Add two more error messages to the HTMLParser.

Report when the </br> -> <br> quirk is triggered.

Also report whenever the broken XML self-closing tag syntax is used on
tags that can actually have an end tag (either optional or required).

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h: (WebCore::):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
html/HTMLTokenizer.h: (WebCore::Token::reset):

12:47 PM Changeset in webkit [21722] by spadma

2 edits in S60/trunk/WebKit

deepa, reviewed by Sachin

DESC: [S60] Scrollbar covers some parts of web page in RTL mode (MNAN-734F5H)
http://bugs.webkit.org/show_bug.cgi?id=13831

BrowserControl/src/BrCtl.cpp:

11:47 AM Changeset in webkit [23406] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

Build fix.

WebCore.vcproj/WebCore.vcproj:

11:34 AM Changeset in webkit [23405] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://5211882>
Need to relaunch Boomer to recognize newly installed QT plug-in

<rdar://5061867>
After installing Flash, Safari would still not display pages that needed it

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::refresh): Return whether the plugin database changed or not.

(WebCore::PluginDatabaseWin::findPlugin):
New function that tries to find a plug-in given its url and MIME type.

(WebCore::PluginDatabaseWin::createPluginView):
If no plugin is found, refresh the database and search for the plugin again if the database changed.

11:30 AM Changeset in webkit [21721] by weinig

2 edits
1 move in trunk/WebCore

Reviewed by Anders.

Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
for consistency.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.

11:26 AM Changeset in webkit [21720] by hyatt

6 edits in trunk/WebCore

Fix for <rdar://problem/5208440> (13753)

REGRESSION: Raw text needs to be pulled outside of tables

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::checkDTD):
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::checkDTD):
html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::checkDTD):
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::checkDTD):

10:55 AM Changeset in webkit [23404] by adele

2 edits in branches/WindowsMerge/WebCore

fix http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.

10:45 AM Changeset in webkit [21719] by adele

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.

fast/forms/menulist-separator-painting-expected.checksum: Added.
fast/forms/menulist-separator-painting-expected.png: Added.
fast/forms/menulist-separator-painting-expected.txt: Added.
fast/forms/menulist-separator-painting.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.

Test: fast/forms/menulist-separator-painting.html

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to actually do both filling and stroking when needed, even though all existing callers set the stroke to none.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke style and thickness when painting the arrows and the separator.

10:40 AM Changeset in webkit [21718] by thatcher

3 edits in trunk/WebCore

Reviewed by Sam Weinig.

Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.

bindings/objc/DOMObject.h:
bindings/scripts/CodeGeneratorObjC.pm:

10:36 AM Changeset in webkit [21717] by spadma

1 edit in S60/trunk/S60Internals/S60Headers.zip

Update S60Headers.zip for font access

10:20 AM Changeset in webkit [21716] by weinig

5 edits in trunk

LayoutTests:

Reviewed by Anders.

update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Anders.

Uncomment HTMLFramesSetElement constructor now that it exists.

page/DOMWindow.idl:

10:04 AM Changeset in webkit [21715] by andersca

2 edits in trunk/WebCore

Try fixing the buildbot build.

loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::imageClicked):

9:57 AM Changeset in webkit [23403] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

9:39 AM Changeset in webkit [21714] by weinig

8 edits
1 add in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
Autogenerate the JS bindings for the HTMLFrameSetElement

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/JSHTMLFrameSetCustom.cpp: Added. (WebCore::JSHTMLFrameSetElement::canGetItemsForName): (WebCore::JSHTMLFrameSetElement::nameGetter):
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLFrameSetElement.idl:

9:25 AM Changeset in webkit [21713] by ddkilzer

1 edit in trunk/LayoutTests/ChangeLog

Remove conflict markers.

9:06 AM Changeset in webkit [21712] by spadma

14 edits in S60/trunk

yongjzha, reviewed by sachin

DESC: enable font access api.
http://bugs.webkit.org/show_bug.cgi?id=13832

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreTextRendererFactory.h:
khtml/rendering/font.cpp: (Font::update):
kwq/KWQFont.cpp: (QFont::QFont): (QFont::operator= ): (QFont::Renderer): (QFont::setGenericFamily):
kwq/KWQFont.h:

8:41 AM Changeset in webkit [21711] by zack

2 edits in trunk/WebCore

Fixing check for incorrent font size - it should
check fixed not normal.

r=andersca

8:11 AM Changeset in webkit [21710] by harrison

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()

_private->loader->frameLoader() was not being nil checked.

WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()

7:10 AM Changeset in webkit [21709] by hausmann

2 edits in trunk/WebKitQt

Fix multipart HTTP POSTs in the Qt port

5:37 AM Changeset in webkit [21708] by bdash

2 edits in trunk/WebCore

Speculative buildbot build fix.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

2:53 AM Changeset in webkit [21707] by aroben

1 edit in trunk/WebCore/page/Chrome.cpp

Didn't mean to commit this

2:42 AM Changeset in webkit [21706] by aroben

11 edits in trunk/WebCore

Made Chrome::addMessageToConsole more flexible

addMessageToConsole now takes two additional parameters to specify the
message source (HTML, JS, CSS, XML) and level (error, warning, log). To
maintain our old behavior, all current messages were given
JSMessageSource and ErrorMessageLevel parameters. Messages matching
these characteristics are passed up to the ChromeClient.

Reviewed by Hyatt.

2:42 AM Changeset in webkit [21705] by zimmermann

630 edits in branches/feature-branch

Reviewed by Oliver.

Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.

1:56 AM Changeset in webkit [21704] by hyatt

8 edits in trunk/WebCore

Rework how HTML handles line numbering so that it is not fooled by
\r without a following \n and so that document.write doesn't lead
to line numbering confusion.

Reviewed by aroben

html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::setSrc):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addLine):
loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::clear):
platform/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):

1:47 AM Changeset in webkit [21703] by hyatt

2 edits in trunk/LayoutTests/fast/css

Update some tests that darin missed.

1:46 AM Changeset in webkit [21702] by hyatt

1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext-expected.txt

Land corrected background shorthand test now that I yanked the bogus alert.

12:47 AM Changeset in webkit [21701] by hausmann

4 edits in trunk/WebKitQt

Share WebCoreHttp and therefore HTTP connections among multiple
QWebNetworkInterface instances by moving the code into
QWebNetworkManager.

12:01 AM Changeset in webkit [23402] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Added IWebFramePrivate::isDescendantOfFrame.

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp: (WebFrame::isDescendantOfFrame):
WebFrame.h:

May 23, 2007:

11:01 PM Changeset in webkit [21700] by hyatt

1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext.html

Remove a stray alert in a testcase that I wrote a while back.

10:58 PM Changeset in webkit [21699] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add a table test for comment nodes.

10:48 PM Changeset in webkit [21698] by hyatt

3 edits in trunk/WebCore

Make the delete/InsertRows/Cells methods as well as the rowIndex method
able to work properly even when whitespace or comment nodes are present.

Reviewed by aroben

fast/table/rowindex-comment-nodes.html

html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex): (WebCore::HTMLTableRowElement::insertCell): (WebCore::HTMLTableRowElement::deleteCell):
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableSectionElement::deleteRow):

10:39 PM Changeset in webkit [21697] by hyatt

4 adds in trunk/LayoutTests/fast/forms

Land optgroup DTD test.

10:36 PM Changeset in webkit [21696] by hyatt

3 edits in trunk/WebCore

<optgroup> should allow <script> and text nodes inside it, just like
<select> does.

Reviewed by aroben

fast/forms/stuff-on-my-optgroup.html

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::checkDTD):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::checkDTD):

10:33 PM Changeset in webkit [21695] by hyatt

4 adds in trunk/LayoutTests/fast/layers

Add gigantic z-index test.

10:23 PM Changeset in webkit [21694] by hyatt

2 edits in trunk/WebCore

Framesets should allow whitespace text nodes as children.

Reviewed by aroben

html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::checkDTD):

9:06 PM Changeset in webkit [23401] by aliceli1

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

win/Skipped: remove fixed tests

8:28 PM Changeset in webkit [21693] by bdash

2 edits in trunk/WebCore

Fix the Qt build after r21685.

platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

8:23 PM Changeset in webkit [21692] by bdash

2 edits in trunk/WebCore

Reviewed by Adam.

Fix the gdk build following changes in r21685.

platform/gdk/CursorGdk.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

8:07 PM Changeset in webkit [21691] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
http://buymeasoda.com/dev/issues/image_onload/image_onload.html

Clamp z-index so that values that exceed maxint (or that are below minint)
are clamped to those values.

Reviewed by darin

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

7:13 PM Changeset in webkit [23400] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

6:46 PM Changeset in webkit [21690] by ddkilzer

4 edits
4 adds in trunk

LayoutTests:

Reviewed by David Hyatt.

tests for http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail

fast/css/stale-style-selector-crash-1-expected.txt: Added.
fast/css/stale-style-selector-crash-1.html: Added.
fast/css/stale-style-selector-crash-2-expected.txt: Added.
fast/css/stale-style-selector-crash-2.html: Added.

WebCore:

Reviewed by David Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail

Tests: fast/css/stale-style-selector-crash-1.html

fast/css/stale-style-selector-crash-2.html

dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector.
dom/Document.h:

6:43 PM Changeset in webkit [21689] by andersca

3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents

WebCore.xcodeproj/project.pbxproj: Install the zoom cursors.

loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): Set the cursor to the zoom in cursor.

(WebCore::ImageDocument::restoreImageSize):
If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.

6:36 PM Changeset in webkit [21688] by andersca

5 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window

Add new WebPreferences SPI.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences enableAutomaticImageResizing]): (-[WebPreferences setEnableAutomaticImageResizing:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

6:11 PM Changeset in webkit [21687] by darin

1234 edits in trunk

LayoutTests:

Reviewed by Hyatt.

updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered

WebCore:

Reviewed by Hyatt.

fix problems where unrendered nodes were affecting on plain text serialization

editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document.

6:04 PM Changeset in webkit [23399] by andersca

2 edits in branches/WindowsMerge/WebCore

Fix build.

platform/win/CursorWin.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

6:01 PM Changeset in webkit [21686] by andersca

6 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window

WebCore.exp: Add new settings method.

loader/ImageDocument.cpp: (WebCore::ImageEventListener::ImageEventListener): New class that handles resize events and click events and forwards them to the image document.

(WebCore::ImageTokenizer::ImageTokenizer):
(WebCore::ImageTokenizer::writeRawData):
(WebCore::ImageTokenizer::finish):
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::cachedImage):
Let the ImageDocument class keep track of its document structure.

(WebCore::ImageDocument::scale):
Returns the scale that should be used when resizing the image.

(WebCore::ImageDocument::resizeImage):
Update the image size.

(WebCore::ImageDocument::imageClicked):
Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
the mouse stays the same.

(WebCore::ImageDocument::imageChanged):
When the image size is known, resize the image if needed.

(WebCore::ImageDocument::restoreImageSize):
Restore the image size.

(WebCore::ImageDocument::imageNeedsResizing):
Return whether the image is too big for its window or not.

(WebCore::ImageDocument::windowSizeChanged):
Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.

(WebCore::ImageEventListener::handleEvent):
Forward events to the image document.

page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setEnableAutomaticImageResizing):
page/Settings.h: (WebCore::Settings::enableAutomaticImageResizing): Add new setting.

5:50 PM Changeset in webkit [21685] by andersca

7 edits
2 adds in trunk/WebCore

Reviewed by Darin.

Add -webkit-zoom-in and -webkit-zoom-out cursors.

Resources/zoomInCursor.png: Added.
Resources/zoomOutCursor.png: Added.
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
page/EventHandler.cpp: (WebCore::selectCursor):
platform/Cursor.h:
platform/mac/CursorMac.mm: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
rendering/RenderStyle.h: (WebCore::):

5:01 PM Changeset in webkit [21684] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Define rint ourselves for MSVS 2005 too, as it doesn't seem to be defined there either.

4:32 PM Changeset in webkit [21683] by weinig

6 edits in trunk/WebCore

Reviewed by Darin.

Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

Just the HTMLElement part.

bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::putValueProperty):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLElement.idl:

4:19 PM Changeset in webkit [21682] by kmccullo

4 edits
9 adds in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.

fast/dom/prototype-chain-expected.txt:
fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

rdar://problem/5183523
We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.

loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
platform/PlatformString.h: (WebCore::debugPrintString):

4:00 PM Changeset in webkit [21681] by weinig

20 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.

fast/dom/prototype-chain-expected.txt:
fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

Just the HTMLDocument part.

WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear):
bindings/js/kjs_dom.cpp: (KJS::toJS):
bindings/js/kjs_dom.h:
bindings/js/kjs_html.cpp:
bindings/js/kjs_html.h:
bindings/objc/DOMPrivate.h:
bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain
dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings
dom/Document.h:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents):
html/HTMLDocument.h:
html/HTMLDocument.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
WebKit.xcodeproj/project.pbxproj:

3:58 PM Changeset in webkit [21680] by hyatt

1 edit in trunk/WebCore/html/HTMLTokenizer.cpp

3:55 PM Changeset in webkit [21679] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
window at mac.com.

Back out the change to make self-closed <script/> into a Dashboard quirk
only.

Reviewed by aroben

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):

1:53 PM Changeset in webkit [21678] by oliver

2 edits in trunk/WebKit

Reviewed by Geoff.

Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

The main resource for a standalone image webarchive has the same mimetype as the
underlying image.

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):

1:28 PM Changeset in webkit [21677] by thatcher

2 edits in tags/WebCore-418.22/WebCore

Versioning.

1:27 PM Changeset in webkit [21676] by thatcher

2 edits in tags/WebCore-418.22/WebCore

Merge fix r21674.

1:26 PM Changeset in webkit [21675] by thatcher

1 copy in tags/WebCore-418.22

New tag.

1:24 PM Changeset in webkit [21674] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.

1:22 PM Changeset in webkit [21673] by thatcher

2 edits in tags/WebCore-418.21/WebCore

Rolling out a commit on the wrong tag.

1:17 PM Changeset in webkit [21672] by thatcher

2 edits in tags/WebCore-418.21/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.

10:19 AM Changeset in webkit [21671] by kmccullo

1 edit
2 adds in trunk/LayoutTests

Reviewed by.

Fixed build breakage.

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.

10:11 AM Changeset in webkit [21670] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range

Floating objects, such as aligned images, are not included as part of any line. So when the given
text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating
object resides. Character/word methods report floating object at the beginning of the text line(s). Yet
line methods never present floating objects anywhere.
To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
when determining the line range/position. That way, assistive apps won't get stuck using the line methods
to read line-by-line

bridge/mac/WebCoreAXObject.mm: (updateAXLineStartForVisiblePosition): Added a helper method to adjust line start position to account for floating objects (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]): Fixed up line routines to include floating object nodes in line position calculation. startOfLine/endOLine may return null for position next to a floating position. So now there's extra checks to prevent returning null line position/ranges back to AX.

10:02 AM Changeset in webkit [21669] by kmccullo

1 edit
2 deletes in trunk/LayoutTests

Reviewed by.

Removing failing tests until I've fixed them.

fast/dom/open-and-close-by-DOM-expected.txt: Removed.
fast/dom/open-and-close-by-DOM.html: Removed.

9:22 AM Changeset in webkit [21668] by hausmann

9 edits in trunk

Added support for per-QWebPage network interface handlers, clean up the
http and file loading and fixed a bug in the HTTP redirect handling.

8:45 AM Changeset in webkit [23398] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Build fix. Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.

WebKit.vcproj/Interfaces.vcproj:

7:00 AM Changeset in webkit [21667] by rwlbuis

10 edits
4 adds in trunk

Reviewed by Dave Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13174
line-height in font shorthand does not override a previously stated line-height property

Make sure line-height is calculated against definite font-size and
uses the last set line-height, ie. directly or through font shorthand.

5:14 AM Changeset in webkit [21666] by lars

4 edits in trunk/WebKitQt

Reviewed by Zack

Don't do HTTP downloads in a second thread. Simplifies
the code significantly and fixes crashes on some
Web pages.

4:07 AM Changeset in webkit [21665] by lars

2 edits in trunk/WebCore

Reviewed by Zack and Valgrind

Initialize variable.

4:04 AM Changeset in webkit [21664] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13784
REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas

Fix crash by testing for zero stops, and returning transparent black
in this case.

3:48 AM Changeset in webkit [21663] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13801
Crash when loading nonexisting symbol

Check for referenced element and when not found just return.

3:01 AM Changeset in webkit [21662] by lars

3 edits in trunk/WebKitQt

Fix Host: line in HTTP headers and resolving of relative URLs
when redirecting and clean up qHash forward declaration a bit.

1:48 AM Changeset in webkit [21661] by hausmann

2 edits in trunk/WebKitQt

Fix signal/slot connection for load progress.

May 22, 2007:

10:37 PM Changeset in webkit [23397] by aliceli1

5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Enabling smartInsertDelete to resolve
<rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail

Interfaces/IWebView.idl:
WebEditorClient.cpp: (WebEditorClient::smartInsertDeleteEnabled):
WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (WebView::toggleSmartInsertDelete): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled):
WebView.h:

10:02 PM Changeset in webkit [21660] by bdash

1 edit in tags/Safari-5522.7.1/WebKit/Configurations/Version.xcconfig

Versioning.

9:52 PM Changeset in webkit [21659] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21576.

9:46 PM Changeset in webkit [21658] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21569.

9:05 PM Changeset in webkit [21657] by bdash

1 copy in tags/Safari-5522.7.1

New tag.

8:38 PM Changeset in webkit [21656] by weinig

2 edits in trunk/WebCore

Rubber stamped by Adam.

Fix license.

bindings/js/JSHTMLAnchorElementCustom.cpp:

6:26 PM Changeset in webkit [21655] by weinig

13 edits in trunk

LayoutTests:

Reviewed by Adam.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement

WebCore:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (WebCore::createElementClassMap):
bindings/objc/DOMHTML.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

MigrateHeaders.make:

6:19 PM Changeset in webkit [21654] by justing

3 edits
7 adds in trunk

LayoutTests:

Reviewed by darin

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

editing/selection/13804-expected.checksum: Added.
editing/selection/13804-expected.png: Added.
editing/selection/13804-expected.txt: Added.
editing/selection/13804.html: Added. These were missing:
editing/selection/5076323-1-expected.png: Added.
editing/selection/5076323-2-expected.png: Added.
editing/selection/5076323-3-expected.png: Added.

WebCore:

Reviewed by darin, who found the fix independently.

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

r21611 exposed a bug in the way removeMarkers computes
the end of the range to remove markers from. It also
introduced a bug: removeMarkers expects a startOffset
and a length, not a startOffset and an endOffset (added
a layout test).

dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation.

5:55 PM Changeset in webkit [21653] by hyatt

2 adds in trunk/LayoutTests/fast/dom

Add layout test for better background dumping.

5:43 PM Changeset in webkit [21652] by hyatt

6 edits in trunk/WebCore

Fix for bug 13802, background colors can't be reset to default
color. Fix the value cssText method to do the right thing for background
and background-position values.

Reviewed by beth

fast/dom/background-shorthand-csstext.html

css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
css/CSSMutableStyleDeclaration.h:
css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue):
css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand):

4:47 PM Changeset in webkit [21651] by darin

10 edits in trunk

LayoutTests:

Reviewed by Geoff.

test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

fast/dom/iframe-document.html: Updated test to expect no document property.
fast/dom/iframe-document-expected.txt: Updated.

fast/forms/focus2.html: Changed test to use ownerDocument instead of document.

WebCore:

Reviewed by Geoff.

fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

The code on ebay was looking for the "document" property on a iframe.
We changed that to be the ownerDocument rather than the contentDocument,
which was not what ebay was expecting. The best fix seems to be removing
the document property altogether.

Test: fast/dom/iframe-document.html

bindings/js/kjs_html.h: Remove ElementDocument.
bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.

WebKit:

Reviewed by Geoff.

WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property.

4:43 PM Changeset in webkit [21650] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

A little cleanup from my last checkin.

page/Chrome.h: Formatting change.
page/mac/ChromeMac.mm: Fixed copyright.

4:21 PM Changeset in webkit [21649] by adele

6 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

fast/frames/frame-display-none-focus-expected.txt: Added.
fast/frames/frame-display-none-focus.html: Added.
fast/frames/resources/iframe-focus.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

Test: fast/frames/frame-display-none-focus.html

WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
page/Chrome.h:
page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.

4:18 PM Changeset in webkit [21648] by justing

10 edits
4 adds
4 deletes in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters

Moved from unsupported-content because we've supported editing lists
for a while now:

editing/deleting/4875189-expected.checksum: Added.
editing/deleting/4875189-expected.png: Added.
editing/deleting/4875189-expected.txt: Added.
editing/deleting/4875189.html: Added.
editing/unsupported-content/list-delete-002-expected.checksum: Removed.
editing/unsupported-content/list-delete-002-expected.png: Removed.
editing/unsupported-content/list-delete-002-expected.txt: Removed.
editing/unsupported-content/list-delete-002.html: Removed.

Reflects new behavior:

editing/deleting/delete-select-all-003-expected.checksum:
editing/deleting/delete-select-all-003-expected.png:
editing/deleting/delete-select-all-003-expected.txt:

Ditto and also removed a FIXME:

editing/deleting/list-item-1-expected.checksum:
editing/deleting/list-item-1-expected.png:
editing/deleting/list-item-1-expected.txt:
editing/deleting/list-item-1.html:

WebCore:

Reviewed by darin

<rdar://problem/4875189>
List is deleted when replacing contents with Chinese/Japanese characters

editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region.

4:02 PM Changeset in webkit [21647] by adele

2 edits in trunk/WebKit

Reviewed by Darin.

Adding some asserts to help detect other cases of <rdar://problem/5171145>

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):

3:59 PM Changeset in webkit [21646] by darin

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
html/HTMLIFrameElement.idl: Ditto.

3:53 PM Changeset in webkit [23396] by adachan

2 edits in branches/WindowsMerge/WebCore

2007-05-22 Ada Chan <adachan@apple.com>

Fix build.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

3:52 PM Changeset in webkit [21645] by kmccullo

1 edit
4 adds in trunk/LayoutTests

Reviewed by.

Forgot to checkin for fix for rdar://problem/4981886

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.
fast/dom/resources/close.html: Added.
fast/dom/resources/middle.html: Added.
http/tests/security/local-image-from-remote.html:

2:57 PM Changeset in webkit [23395] by aliceli1

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

win/Skipped: removed fixed tests

2:38 PM Changeset in webkit [23394] by justing

4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by oliver

Build fix.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

WebKitWin:

Reviewed by oliver

Build fix.

WebView.cpp: (WebView::clearFocusNode):

2:17 PM Changeset in webkit [23393] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada.

Added 3 view-related methods to IWebFramePrivate.

Interfaces/IWebFramePrivate.idl: Added 3 new methods
WebFrame.cpp: (WebFrame::hasScrollBars): Added. (WebFrame::contentBounds): Added. (WebFrame::frameBounds): Added.
WebFrame.h:

1:49 PM Changeset in webkit [21644] by yongjzha

4 edits in S60/trunk/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

1:43 PM Changeset in webkit [21643] by yongjzha

4 edits in S60/branches/3.1m/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

12:02 PM Changeset in webkit [21642] by justing

11 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

Demonstrates bug:

editing/selection/5213963-expected.checksum: Added.
editing/selection/5213963-expected.png: Added.
editing/selection/5213963-expected.txt: Added.
editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired):
fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame.
page/FocusController.h:

12:02 PM Changeset in webkit [21641] by beidson

2 edits in trunk/WebKit

Reviewed by Kevin (Sarge)

<rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/

This regressed in http://trac.webkit.org/projects/webkit/changeset/21618

WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader

8:11 AM Changeset in webkit [21640] by staikos

2 edits in trunk/WebKitQt

back this out for zack

1:53 AM Changeset in webkit [21639] by zack

2 edits in trunk/WebCore

Path implementing more Cliboard from Marius Bugge Monsen.

Adding implementations of some of the missing methods.
r=me

12:31 AM Changeset in webkit [21638] by hausmann

2 edits in trunk/WebKitQt

Fix http headers for POST.

May 21, 2007:

11:53 PM Changeset in webkit [21637] by justing

2 edits in trunk/LayoutTests/editing/execCommand

Updating expected results for r21074.

8:50 PM Changeset in webkit [23392] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam, Ada.

Added IWebFramePrivate::size().

Interfaces/IWebFramePrivate.idl: Added size.
WebFrame.cpp: (WebFrame::size): Added.
WebFrame.h: Added size.

8:10 PM Changeset in webkit [21636] by oliver

4 edits
4 adds in trunk

2007-05-21 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Sam.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789

svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
svg/custom/getscreenctm-in-mixed-content.xhtml: Added.

WebCore:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13789
-- SVGLocatable::getScreenCTM() faulty

Needed to update SVGLength to handle the case where the SVGElement is
not the root document element -- we do this by falling back on the
renderer for the context.

For <svg> elements embedded as mixed content in xhtml we consider the
absolutePosition of the parent to be the origin for the <svg> element.

ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):

7:14 PM Changeset in webkit [23391] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Build fix.

WebCore.vcproj/WebCore.vcproj:

7:14 PM Changeset in webkit [21635] by thatcher

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):

6:42 PM Changeset in webkit [21634] by weinig

2 edits in trunk/WebCore

Reviewed by George Staikos.

Fix Qt build.

WebCore.pro: add missing IDL files.

6:29 PM Changeset in webkit [21633] by weinig

14 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803 to account for the new JSHTMLMarquee that is being autogenerated and can now produce a constructor.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/element-constructors-on-window.html:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
Autogenerate the JS bindings for the HTMLMarqueeElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue.
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
html/HTMLMarqueeElement.h: Add start() and stop() functions.
html/HTMLMarqueeElement.idl: Added.
page/DOMWindow.idl: Add marquee constructor.

5:08 PM Changeset in webkit [21632] by adele

4 edits in trunk

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto.

WebKit:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.

4:13 PM Changeset in webkit [21631] by weinig

4 edits in trunk/LayoutTests

3:03 PM Changeset in webkit [21630] by hyatt

3 edits in trunk/WebCore

Make a line gutter backdrop so that tiny view source docs don't look
bad.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):

2:45 PM Changeset in webkit [23390] by adachan

4 edits in branches/WindowsMerge/WebKitWin

2007-05-21 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Added IWebViewPrivate::loadBackForwardListFromOtherView(). It replicates the backforward
list from another webview and loads that in the current webview.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::loadBackForwardListFromOtherView):
WebView.h:

2:32 PM Changeset in webkit [21629] by hyatt

4 edits in trunk/WebCore

Make sure to distinguish between links to internal resources and
real links (anchors) in view source mode.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

1:00 PM Changeset in webkit [23389] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build fix.

WebCore.vcproj/WebCore.vcproj:

12:37 PM S60CheckoutAndBuild edited by bradley.morrison@nokia.com

(diff)

12:35 PM S60IDE created by bradley.morrison@nokia.com

initial revision

12:07 PM Changeset in webkit [21628] by beidson

2 edits in trunk/WebKit

Making the importance of my last change more clear

WebView/WebViewPrivate.h: "Leave for Dashboard, people!"

11:55 AM S60ConfigureComputer edited by bradley.morrison@nokia.com

link to s60IDE page (diff)

11:45 AM Changeset in webkit [21627] by beidson

3 edits in trunk/WebKit

Reviewed by Kevin (Sarge)

<rdar://problem/5217124> - Re-add mistakenly removed SPI

WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
WebView/WebViewPrivate.h:

11:32 AM Changeset in webkit [21626] by spadma

2 edits in S60/branches/3.1m/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:32 AM Changeset in webkit [21625] by spadma

2 edits in S60/trunk/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:19 AM Changeset in webkit [21624] by weinig

17 edits in trunk

LayoutTests:

Reviewed by Adam and Darin.

update results for http://bugs.webkit.org/show_bug.cgi?id=13791 to account for new JSHTMLElements that are being autogenerated and can now produce constructors.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location):
html/HTMLFrameElementBase.h:
html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow):
html/HTMLIFrameElement.idl:
page/DOMWindow.idl:

10:57 AM Changeset in webkit [21623] by andersca

2 edits in trunk/WebKit

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

6:57 AM Changeset in webkit [21622] by lars

8 edits
6 adds in trunk/LayoutTestResults

Updating and adding test cases.

6:36 AM Changeset in webkit [21621] by lars

4 edits in trunk/WebKitQt

Reviewed by Simon

Remove the userHandle methods from QWebnetworkJob again.
They don't really give us anything and just clutter the API.

6:09 AM Changeset in webkit [21620] by hausmann

2 edits in trunk/WebKitQt

Export the new qt network API.

5:33 AM Changeset in webkit [21619] by lars

5 edits
3 adds
4 deletes in trunk

Reviewed by Zack.

Add an API layer for network downloads. Basically QWebnetworkInterface
is an interface class for downloading resources. QWebnetworkJob describes
the actual object to download.

QWebNetworkInterface has a default implementation that replaces the
old ResourceHandleManager class in the Qt port.

Remove the ResourceHandleManager class, it is now part of
QWebNetworkInterface. Adapt ResourceHandle to the new way
of things.

4:04 AM Changeset in webkit [21618] by mjs

15 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit

The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
empty initial document. However, WebKit still needs the real data source internally, so I also
added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]):
Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::canCachePage):
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory bridgeForView:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebArchiver.mm: (+[WebArchiver archiveFrame:]): (+[WebArchiver archiveMainResourceForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveSelectionInFrame:]):
WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _addChild:]): (-[WebFrame _dataSource]): (-[WebFrame DOMDocument]): (-[WebFrame dataSource]):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]):
WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): (-[WebView mainFrameURL]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView _isLoading]): (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): (-[WebView _notifyTextSizeMultiplierChanged]):

12:40 AM Changeset in webkit [21617] by hyatt

28 edits in trunk/LayoutTests/tables

Update test results for improved colgroup span handling.

12:31 AM Changeset in webkit [21616] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add new layout test for spanning colgroup rules=groups bug.

12:30 AM Changeset in webkit [21615] by hyatt

5 edits in trunk/WebCore

Second half of fix for 13793, make sure rules=groups works properly with
spanning colgroups.

Also make sure colgroups get an actual span of 1 (instead of incorrectly
giving them a span of 0).

Reviewed by mitz

fast/table/colgroup-spanning-groups-rules.html

html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement):
rendering/RenderTable.cpp: (WebCore::RenderTable::colElement):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder):

May 20, 2007:

11:29 PM Changeset in webkit [21614] by hyatt

2 edits in trunk/WebCore

Half of a fix for 13793, make sure rules=groups and border behave properly
together.

Reviewed by mitz

No tests added, two Mozilla table tests now pass that failed before.

html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

5:44 PM Changeset in webkit [21613] by bdash

1 edit in trunk/WebCore/loader/icon/IconLoader.cpp

Fix spelling.

3:55 PM Changeset in webkit [21612] by beidson

3 edits in trunk/WebCore

Reviewed by Geoose Garen

<rdar://problem/4758919> - Incorrect favicon shown for URL after going back

When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
shenanigans with the icon url -> page url mapping.

loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)

loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down

2:14 PM Changeset in webkit [21611] by darin

6 edits in trunk/WebCore

Reviewed by Oliver Hunt.

fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow

dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient.

page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled.

platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto.

platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out.

editing/visible_units.cpp: Added lots of FIXME comments, but no code change.

11:36 AM Changeset in webkit [21610] by staikos

2 edits in trunk/WebCore

add -f to cp for some obscure build systems.

10:45 AM Changeset in webkit [21609] by staikos

2 edits in trunk/WebCore

Add missing include for auto_ptr

7:12 AM Changeset in webkit [21608] by ddkilzer

3 edits in trunk/WebKitTools

2007-05-20 David Kilzer <ddkilzer@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=13565 Change svn-create-patch to put LayoutTests in the end

In addition to reordering test files under the LayoutTests directory so that they
appear after source code files, this patch fixes an issue with prepare-ChangeLog
if the first argument passed to it is a file name instead of a directory name.

Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto.
Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files.

May 19, 2007:

6:19 PM Changeset in webkit [21607] by zimmermann

23 edits
134 adds in branches/feature-branch

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.

5:20 PM Changeset in webkit [21606] by hyatt

2 edits in trunk/WebCore

Fix for bug 13785, O(n^{2) counter creation.}

Reviewed by darin

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::originalText):

5:16 PM Changeset in webkit [21605] by bdash

12 edits
12 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

Tests: fast/repaint/box-shadow-dynamic.html

fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for the "exterior" extreme position, add box shadow. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint the box shadow when an edge with a shadow moves. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function that expands a given rectangle to encompass outline and box shadow. (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
rendering/RenderObject.h:

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

fast/box-shadow/basic-shadows-expected.checksum:
fast/box-shadow/basic-shadows-expected.png:
fast/box-shadow/basic-shadows-expected.txt:
fast/repaint/box-shadow-dynamic-expected.checksum: Added.
fast/repaint/box-shadow-dynamic-expected.png: Added.
fast/repaint/box-shadow-dynamic-expected.txt: Added.
fast/repaint/box-shadow-dynamic.html: Added.
fast/repaint/box-shadow-h-expected.checksum: Added.
fast/repaint/box-shadow-h-expected.png: Added.
fast/repaint/box-shadow-h-expected.txt: Added.
fast/repaint/box-shadow-h.html: Added.
fast/repaint/box-shadow-v-expected.checksum: Added.
fast/repaint/box-shadow-v-expected.png: Added.
fast/repaint/box-shadow-v-expected.txt: Added.
fast/repaint/box-shadow-v.html: Added.

4:42 PM Changeset in webkit [21604] by bdash

4 edits in trunk/LayoutTests

2007-05-20 Mark Rowe <mrowe@apple.com>

Update test results after r21597.

fast/frames/viewsource-attribute-expected.checksum:
fast/frames/viewsource-attribute-expected.png:
fast/frames/viewsource-attribute-expected.txt:

4:11 PM Changeset in webkit [21603] by bdash

2 edits in trunk/WebCore

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13783 REGRESSION (r21120): Frame resizers not repainted properly when dragged

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):

4:09 PM Changeset in webkit [21602] by bdash

4 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

Test: fast/table/stale-grid-crash.html

rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto.
rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

fast/table/stale-grid-crash-expected.checksum: Added.
fast/table/stale-grid-crash-expected.png: Added.
fast/table/stale-grid-crash-expected.txt: Added.
fast/table/stale-grid-crash.html: Added.

3:54 PM Changeset in webkit [21601] by bdash

9 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

Test for a rendering bug fixed by this patch:

fast/box-shadow/border-radius-big.html

No test for the performance ingredient.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect.
platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path.
platform/graphics/Path.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

fast/box-shadow/border-radius-big-expected.checksum: Added.
fast/box-shadow/border-radius-big-expected.png: Added.
fast/box-shadow/border-radius-big-expected.txt: Added.
fast/box-shadow/border-radius-big.html: Added.

6:14 AM Changeset in webkit [21600] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

fast/frames/inline-object-inside-frameset-expected.txt: Added.
fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/frames/inline-object-inside-frameset.html

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

Don't paint inline objects.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):

12:42 AM Changeset in webkit [21599] by hyatt

6 edits in trunk/WebCore

Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
CSS/JS will eventually tokenize via their own special tokenizers so that
they can also be syntax-highlighted, but for now just treat them as
plain text.

Reviewed by aroben

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceText): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:
loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write):
loader/TextDocument.h: (WebCore::TextTokenizer::checkBuffer):

May 18, 2007:

11:48 PM Changeset in webkit [21598] by hyatt

2 edits in trunk/WebCore

Fix a glitch in view source mode attribute names.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

10:16 PM Changeset in webkit [21597] by hyatt

4 edits in trunk/WebCore

"Linkify" view source mode links.

Reviewed by andersca

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

7:05 PM Changeset in webkit [21596] by oliver

10 edits in trunk

2007-05-18 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode

r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.

This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.

Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement

WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):

WebKit.xcodeproj/project.pbxproj:

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source

WebView/WebHTMLViewInternal.h:
WebView/WebHTMLViewPrivate.h:

4:32 PM Changeset in webkit [21595] by hyatt

1 edit in trunk/LayoutTests/http/tests/security/local-JavaScript-from-remote.html

Fix more malformed test cases.

4:32 PM Changeset in webkit [21594] by hyatt

2 edits in trunk/LayoutTests/fast/tokenizer

Fix more malformed test cases.

4:31 PM Changeset in webkit [21593] by hyatt

2 edits in trunk/LayoutTests/fast/parser

Fix more malformed test cases.

4:29 PM Changeset in webkit [21592] by hyatt

1 edit in trunk/LayoutTests/fast/loader/local-JavaScript-from-local.html

Fix more malformed test cases.

4:26 PM Changeset in webkit [21591] by hyatt

2 edits in trunk/LayoutTests/fast/dom/HTMLScriptElement

Fix more malformed test cases.

4:12 PM Changeset in webkit [21590] by hyatt

26 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:06 PM Changeset in webkit [21589] by hyatt

1 edit in trunk/LayoutTests/http/tests/navigation/resources/frameset.pl

Beating my head against these malformed http/navigation tests still.

4:04 PM Changeset in webkit [21588] by hyatt

2 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:03 PM Changeset in webkit [21587] by hyatt

2 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:03 PM Changeset in webkit [21586] by hyatt

5 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:01 PM Changeset in webkit [21585] by hyatt

1 edit in trunk/LayoutTests/http/tests/navigation/resources/success200.html

Beating my head against these malformed http/navigation tests still.

3:50 PM Changeset in webkit [21584] by hyatt

6 edits in trunk/LayoutTests/http/tests/navigation

Fixing broken http/navigation test cases that were written with malformed HTML.

3:48 PM Changeset in webkit [21583] by hyatt

4 edits in trunk/LayoutTests/http/tests/navigation

Fixing broken http/navigation test cases that were written with malformed HTML.

3:46 PM Changeset in webkit [21582] by tristan

1 edit in trunk/WebKit/WebCoreSupport/WebFrameLoaderClient.mm

Fixed potential crash with ASSERT in download due to previous commit.

3:44 PM Changeset in webkit [21581] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
HTML tokenization (13780).

Reviewed by ggaren

html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):

3:40 PM Changeset in webkit [21580] by beidson

1 edit in trunk/WebCore/ChangeLog

Added bugzilla link

3:38 PM Changeset in webkit [21579] by tristan

3 edits in trunk/WebKit

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): asked the webframeloaderclient for its webview's history and injected the originated url into the created WebDownload

3:38 PM Changeset in webkit [21578] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/5166149> - window.open() causes server to be hit twice

This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
That patch was to fix broken behavior when opening an already existant window.
The unfortunate side effect was to cause the server to be hit twice.
Once during the call to frame->loader()->createWindow(), and again via a
scheduled redirection.

I decided to restore the original de-facto behavior by making the new window
open via a scheduled redirection - there is a FIXME that was already here that
explains the reason why we have to do it this way for now.

Additionally, there were two distinct places that had their own logic to open
a new window - the logic for window.open() and the logic for
window.showModalDialog(). The logic was almost identical so I condensed them
into one utility function that takes a flag to handle the slight difference.

A layout test is not possible at this time since it would involve capturing
server logs (the 1st connection does not exist long enough to result in any
delegate callbacks). That task is documented in
http://bugs.webkit.org/show_bug.cgi?id=13769

bindings/js/kjs_window.cpp: (KJS::createWindow): Merged the two slightly different versions of "creating a window" logic here. For the modal dialog case the load is an immediate call to changeLocation(), which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange() (KJS::showModalDialog): Call createWindow() (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call createWindow() for all others

3:23 PM Changeset in webkit [23388] by sfalken

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build.

2:45 PM Changeset in webkit [23387] by sfalken

4 edits
1 add in branches/WindowsMerge/WebCore

2:43 PM Changeset in webkit [23386] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fixing the vcproj paths.

WebCore.vcproj/WebCore.vcproj:

2:32 PM Changeset in webkit [23385] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

Build fix after r21577.

WebCore.vcproj/WebCore.vcproj:

2:06 PM Changeset in webkit [21577] by weinig

17 edits in trunk

LayoutTests:

Reviewed by Geoff.

update results to account for new JSHTMLElements that are being auto-generated and can now produce Constructors.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

DerivedSources.make:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
page/DOMWindow.idl:

1:47 PM Changeset in webkit [21576] by sullivan

3 edits in trunk/WebKit

Reviewed by Kevin Decker

Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
a couple of hours more modern.)

WebView/WebUIDelegatePrivate.h: add showPanel: parameter to just-introduced delegate method webView:saveFrameView:

WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): pass NO for new showPanel: parameter, and update comment

1:33 PM Changeset in webkit [21575] by mjs

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars

No test because the bug requires calling setAllowsScrolling: to reproduce.

WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded a document.

1:32 PM Changeset in webkit [21574] by mjs

5 edits in trunk/LayoutTests

Not Reviewed, buildbot test fix.

updated results for the last fiew checkins.

fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
fast/dom/replaceChild-expected.txt:
http/tests/loading/bad-scheme-subframe-expected.txt:
webarchive/loading/test-loading-archive-expected.txt:

1:03 PM Changeset in webkit [21573] by sfalken

1 copy in tags/Safari-522.8.1b

New tag.

12:14 PM Changeset in webkit [21572] by oliver

4 edits in trunk/WebCore

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5211122> DRT crash below
SVGTimer::applyAnimations when page cache is enabled
(SVG animation timers do not properly cancel themselves)

There were still a few paths in the SVG Animation code
that could cause timers to be created and used. This
patch inserts addition SVG_EXPERIMENTAL blocks to prevent
these timers from being used.

ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):
ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::SVGTimer::applyAnimations): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify):
ksvg2/misc/TimeScheduler.cpp: (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired):
ksvg2/svg/SVGAnimationElement.h:

11:58 AM Changeset in webkit [21571] by ggaren

2 edits in trunk/WebKit

Fixed spelling error.

WebView/WebViewPrivate.h:

11:22 AM Changeset in webkit [23384] by aroben

5 edits in branches/WindowsMerge/WebCore

Build fix after r21562.

platform/win/TemporaryLinkStubs.cpp:
platform/win/WidgetWin.cpp:
plugins/win/PluginViewWin.cpp:
plugins/win/PluginViewWin.h:

11:12 AM Changeset in webkit [23383] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Build-related fix: stamp version resource properly.

WebKit.vcproj/WebKit.rc: Fix version resource

10:52 AM Changeset in webkit [21570] by weinig

4 edits in trunk/LayoutTests

Reviewed by Mitz.

Update test results after Hyatt's update of view-source
to include line numbers and a gutter.

fast/frames/viewsource-attribute-expected.checksum:
fast/frames/viewsource-attribute-expected.png:
fast/frames/viewsource-attribute-expected.txt:

10:05 AM Changeset in webkit [21569] by sullivan

3 edits in trunk/WebKit

Reviewed by Kevin Decker

WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)

Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
changed from a notification to a delegate method. The notification was new to
Leopard, so removing it doesn't affect clients in the field.

WebView/WebUIDelegatePrivate.h: Declared new UI delegate method webView:saveFrameView:, analogous to the existing webView:printFrameView:

WebView/WebPDFView.mm: removed declaration of _webkit_PDFKitLaunchNotification (-[WebPDFView viewDidMoveToWindow]): don't observe _webkit_PDFKitLaunchNotification (-[WebPDFView viewWillMoveToWindow:]): ditto (-[WebPDFView PDFViewOpenPDFInNativeApplication:]): new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): new PDFKit delegate method, calls through to new WebKit UI delegate method

8:36 AM Changeset in webkit [21568] by zack

2 edits in trunk/WebCore

Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

7:17 AM Changeset in webkit [21567] by hausmann

4 edits in trunk/WebKitQt

Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

5:11 AM Changeset in webkit [21566] by zack

2 edits in trunk/WebKitQt

Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

3:15 AM Changeset in webkit [21565] by oliver

2 edits in trunk/LayoutTests

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Mark.

Fix capitalisation of resources referenced by test case.

svg/carto.net/window.svg:

2:50 AM Changeset in webkit [21564] by bdash

3 edits in trunk/WebKitTools

2007-05-18 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

Scripts/svn-create-patch:
Scripts/webkitdirs.pm:

2:21 AM Changeset in webkit [21563] by bdash

3 edits in trunk/WebCore

2007-05-18 Mark Rowe <mrowe@apple.com>

Attempt to fix the Gdk build after r21562.

platform/gdk/TemporaryLinkStubs.cpp: (Widget::isEnabled):
platform/gdk/WidgetGdk.cpp:

1:49 AM Changeset in webkit [21562] by lars

4 edits in trunk/WebCore

2007-05-18 Adam Treat <treat@kde.org>

Reviewed by Lars

Remove dead code.

platform/Widget.h:
platform/mac/WidgetMac.mm:
platform/qt/WidgetQt.cpp:

1:44 AM Changeset in webkit [21561] by bdash

2 edits in trunk/WebCore

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Return true to make loading of pages working again

loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::canHandleRequest):

1:41 AM Changeset in webkit [21560] by bdash

10 edits
1 add in trunk

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Make WebCore::Widget use GtkWidget to fix focus handling.

WebCore.pro: Add PlatformScrollBar
platform/ScrollView.h: Gtk stuff
platform/Widget.h: Take a GtkWidget
platform/gdk/PlatformScrollBarGdk.cpp: Added. (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect):
platform/gdk/ScreenGdk.cpp: Implement depth handling (WebCore::screenDepth):
platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable (WebCore::ScrollView::setGtkWidget):
platform/gdk/TemporaryLinkStubs.cpp:
platform/gdk/WidgetGdk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::gtkWidget): (WebCore::Widget::setGtkWidget): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus):

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

GdkLauncher/main.cpp: Call setGtkWidget (main):

1:38 AM Changeset in webkit [21559] by lars

3 edits in trunk/WebCore

Reviewed by Zack

Correctly implement initialiseSupportedImageMIMETypes.

1:34 AM Changeset in webkit [21558] by bdash

2 edits in trunk/WebCore

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Build fix for non-Qt and non-Mac ports.

html/HTMLCanvasElement.h:

1:29 AM Changeset in webkit [21557] by bdash

9 edits in trunk

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

No test added as this is hard to time.

platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout() is needed.

(WebCore::FrameGdk::dumpRenderTree):
(WebCore::FrameGdk::handleGdkEvent):

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

GdkLauncher/main.cpp: (main): Call Frame::init to catch up with Maciej's changes.
Scripts/run-javascriptcore-tests: Remove --gdk from the command line passed to the helper scripts.

1:13 AM Changeset in webkit [23382] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4914940> Some plugins won't redraw correctly when scrolling

This patch does two things:

It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.

It lets Windows handle its invalid region when moving the window and setting its new window region.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):

12:54 AM Changeset in webkit [21556] by hausmann

2 edits in trunk/WebCore

Generate pkgconfig files for the Qt build.

12:50 AM Changeset in webkit [23381] by aroben

4 edits in branches/WindowsMerge

WebCoreWin:

Build fix after r21555.

page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe):

WebKitWin:

Build fix after r21555.

WebView.cpp:

12:09 AM Changeset in webkit [21555] by lars

8 edits in trunk/WebCore

Reviewed by Hyatt.

Remove unused handleMouseEvent methods in the Widget
and derived classes.

12:00 AM Changeset in webkit [21554] by staikos

2 edits in trunk/WebCore

Use the proper clipping algorithm

May 17, 2007:

11:54 PM Changeset in webkit [23380] by sfalken

1 add in branches/WindowsMerge/WebCore/WebCorePrefix.h

Merged from OpenSource/WebCore/WebCorePrefix.h r20496

11:40 PM Changeset in webkit [23379] by adachan

7 edits in branches/WindowsMerge/WebKitWin

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Implemented IWebHTTPURLResponse::localizedStringForStatusCode().

11:36 PM Changeset in webkit [21553] by weinig

2 edits in trunk/WebCore

Reviewed by George Staikos.

Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

WebCore.pro:

11:32 PM Changeset in webkit [21552] by staikos

2 edits in trunk/WebKitQt

patch from Adam Treat to implement frameLoadCompleted()
build fix from George Staikos

11:08 PM Changeset in webkit [21551] by staikos

2 edits in trunk/WebCore

Fix preprocessor logic for CG/QT

10:32 PM Changeset in webkit [21550] by staikos

2 edits in trunk/WebKitQt

Implement forceLayoutForNonHTML

10:28 PM Changeset in webkit [21549] by staikos

2 edits in trunk/WebKitQt

Implement canShowMIMEType

10:07 PM Changeset in webkit [21548] by hyatt

5 edits in trunk/WebCore

Add a line gutter to view source mode. The gutter uses counters, and this exposed the fact
that pseudoStyleForElement was not walking all UA rules properly.

Reviewed by aroben

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement):
css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText):
html/HTMLViewSourceDocument.h:

9:17 PM Changeset in webkit [21547] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

editing/selection/5209984-expected.txt: Added.
editing/selection/5209984.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

comparePositions() expects non-null positions. It's
given a null position by contains() if the current
selection is a range selection but contains only invisible
content *and* visible positions cannot be created from its
end points. This can happen when there is a range selection
inside shadow content (like that inside text fields) that
is made invisible.

editing/SelectionController.cpp: (WebCore::SelectionController::contains): Check for invisible end points.

8:05 PM Changeset in webkit [23378] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build Fix after <rdar://problem/5201423>

WebCore.vcproj/WebCore.vcproj:

7:50 PM Changeset in webkit [21546] by weinig

5 edits
3 adds in trunk

LayoutTests:

Reviewed by Adam.

Tests for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

fast/dom/anchor-toString-expected.txt: Added.
fast/dom/anchor-toString.html: Added.
fast/forms/focus2.html:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

Anchor elements need to have the same behavior for implicit and
explicit toString() calls.

Test: fast/dom/anchor-toString.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp: Added. (WebCore::JSHTMLAnchorElement::toString):
html/HTMLAnchorElement.idl:

4:38 PM Changeset in webkit [21545] by ggaren

2 edits in trunk/WebCore

Build fix.

4:24 PM Changeset in webkit [23377] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Use the clientStyle to determine how to handle bidi text. For popup buttons, which we restrict to LTR, we will match the button text.

4:15 PM Changeset in webkit [21544] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Update RenderMenuList PopupClient methods to consider style of inner block.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::clientStyle):

4:10 PM Changeset in webkit [23376] by adachan

3 edits in branches/WindowsMerge/WebKitWin

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Changed the context menu title "Search in Google" to "Search with Google".

3:57 PM Changeset in webkit [21543] by mjs

2 edits in trunk/WebCore

Not reviewed, emergency test fix.

avoid crash on layout tests.

Patched up my last change so that widgets don't crash.

loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError):

3:25 PM Changeset in webkit [21542] by antti

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).

Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
unclear if WebCore's definition of offsets is the same as other browsers.

bindings/js/kjs_window.cpp:
WebCore/editing/SelectionController.cpp:
WebCore/editing/SelectionController.h:
WebCore/editing/VisiblePosition.cpp:

2:42 PM Changeset in webkit [21541] by adele

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

fast/text/international/bidi-menulist-expected.checksum: Added.
fast/text/international/bidi-menulist-expected.png: Added.
fast/text/international/bidi-menulist-expected.txt: Added.
fast/text/international/bidi-menulist.html: Added.

WebCore:

Reviewed by Mitz.

Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

Test: fast/text/international/bidi-menulist.html

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left. This means that we will ignore those settings in the button to match the way the text is displayed in the popup menu. (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle. (WebCore::RenderMenuList::setStyle): ditto.
rendering/RenderMenuList.h: Added adjustInnerStyle.

2:16 PM Changeset in webkit [21540] by justing

3 edits in trunk/LayoutTests/editing/execCommand

I accidently mucked around with these tests after generating results.
Correcting them.

2:06 PM Changeset in webkit [21539] by justing

3 edits
12 adds in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/4924441-expected.checksum: Added.
editing/execCommand/4924441-expected.png: Added.
editing/execCommand/4924441-expected.txt: Added.
editing/execCommand/4924441.html: Added.
editing/execCommand/5207369-expected.checksum: Added.
editing/execCommand/5207369-expected.png: Added.
editing/execCommand/5207369-expected.txt: Added.
editing/execCommand/5207369.html: Added.
editing/execCommand/5210032-expected.checksum: Added.
editing/execCommand/5210032-expected.png: Added.
editing/execCommand/5210032-expected.txt: Added.
editing/execCommand/5210032.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4924441> List becomes nested when changing its type
<rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
<rdar://problem/5207369> Crash when removing ordering from a nested list

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): The outermostEnclosingList of the position before the start isn't the previousList if it contains the start. Ditto for the position after the end and the nextList. If we're putting the newly created list item into the next list, insert it at the start of that list, not the end (don't append). Avoid nesting newly created lists inside list items.

11:35 AM Changeset in webkit [21538] by pyeh

2 edits in trunk/WebCore

<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream(). A more accurate way to determine the order from selection is to ask directly for isBaseFirst(). In addition, if the two visible positions given are the same position but different affinity, we need to handle it here rather than depend on the selection. This is because selection does not retain the affinity of both selection start/end visible positions as part of the selection validation.

10:57 AM Changeset in webkit [21537] by spadma

75 edits
17 adds in S60/branches/3.1m

2007-05-15 yyadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (Sachin.Padma@nokia.com).
DESC: Back port widget to 3.1 branch
http://bugs.webkit.org/show_bug.cgi?id=13657

WARNING: NO TEST CASES ADDED OR CHANGED

BWINS/WEBCOREU.DEF:
EABI/WebCoreU.DEF:
bridge/WebCoreBridge.cpp: (CWebCoreBridge::WindowScriptNPObject):
bridge/WebCoreBridge.h:
bridge/WebCoreFormControls.h:
bridge/WebCoreWidget.h: (MWebCoreWidget::PluginScriptableObject):
group/KHTML.mmp:
group/KWQ.mmp:
group/WebCore.mmp:
khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (DOMNode::mark): (DOMNode::getValueProperty): (DOMNodeList::call): (DOMDocument::DOMDocument): (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (DOMCharacterData::DOMCharacterData): (DOMCharacterDataProtoFunc::tryCall): (DOMText::DOMText):
khtml/ecma/kjs_window.cpp: (Window::Window): (Window::mark): (Window::get): (ScheduledAction::execute):
khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Selection::):
khtml/ecma/kjs_window.lut.h: (KJS::):
khtml/html/html_formimpl.cpp: (DOM::):
khtml/html/html_formimpl.h:
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::getEmbedInstance):
khtml/html/html_objectimpl.h:
khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
kwq/KWQFileButton.cpp: (KWQFileButton::KWQFileButton): (KWQFileButton::setFont): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::HandleEvent): (KWQFileButton::setAccept):
kwq/KWQFileButton.h:
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects): (KWQKHTMLPart::createWidgetObject): (KWQKHTMLPart::createWidgetMenuObject): (KWQKHTMLPart::createWidgetMenuItemObject): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView): (KWQKHTMLPart::windowScriptNPObject):
kwq/KWQKHTMLPart.h: (KWQKHTMLPart::getAppletInstanceForView):

10:56 AM Changeset in webkit [23375] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5210600> New WMP plugin doesn't show any contents

Call NPP_SetWindow after the window's size has been updated.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):

10:52 AM Changeset in webkit [21536] by beidson

3 edits
1 move
10 adds
3 deletes in trunk

LayoutTests:

Reviewed by Brady

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13759 REGRESSION (r20182-r20184): Incorrect rendering of multipart images

Created http/tests/multipart and moved the existing multipart test there.

http/tests/misc/multipart-expected.txt: Removed.
http/tests/misc/multipart.html: Removed.
http/tests/misc/resources/1x1-blue.png: Removed.
http/tests/misc/resources/multipart.php: Removed.
http/tests/multipart/invalid-image-data-expected.checksum: Added.
http/tests/multipart/invalid-image-data-expected.png: Added.
http/tests/multipart/invalid-image-data-expected.txt: Added.
http/tests/multipart/invalid-image-data.html: Added.
http/tests/multipart/resources/2x2-green.png: Added. Shared by both multipart tests.
http/tests/multipart/resources/abe.png: Added.
http/tests/multipart/resources/multipart.php: Added. Shared by both multipart tests.
http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

Reviewed by Brady

fix http://bugs.webkit.org/show_bug.cgi?id=13759 REGRESSION (r20182-r20184): Incorrect rendering of multipart images

Test: http/tests/multipart/invalid-image-data.html

loader/loader.cpp: (WebCore::Loader::didReceiveData): Make a copy of the current part's data instead of using the resource data, because the latter is going to be overwritten by the new part being received.

9:47 AM Changeset in webkit [23374] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

<rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension

Return null if the extension is null.

platform/win/MimeTypeRegistryWin.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

8:11 AM Changeset in webkit [23373] by andersca

2 edits in branches/WindowsMerge/WebKitWin

Fix build.

WebFrame.cpp: (WebFrame::loadURLIntoChild):

4:32 AM Changeset in webkit [21535] by oliver

5 edits in trunk

2007-05-17 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
across to WebKit as private headers.

WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

This patch fixes this bug by manually creating an NSFileWrapper from
the TIFF promise data for a drag if it is available. This bypasses
the problem of the required resource no longer being held due to page
loads or other constraints.

We need to leave the old path in place to allow for the case where
the promised data is not available.

WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): Always use the top WebHTMLView as the pasteboard owner, this is safe as we only use the owner for resolving promised types.
WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView writeSelectionToPasteboard:types:]): Always use the top WebHTMLView as the pasteboard owner. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Add path to create NSFileWrapper from promise data.

3:46 AM Changeset in webkit [21534] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

Demonstrates bug:

editing/execCommand/5190926-expected.checksum: Added.
editing/execCommand/5190926-expected.png: Added.
editing/execCommand/5190926-expected.txt: Added.
editing/execCommand/5190926.html: Added.

Avoided some nesting:

editing/execCommand/5142012-2-expected.txt:
editing/execCommand/switch-list-type-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/5190926>
Gmail Editor: Crash when removing list style from underlined, multi-item list

The user underlined some text, then created a list.
The list was placed inside the inline element carrying
the underline style, so, that element surrounded the
list instead of being at the lowest level (just above
text nodes). This kind of markup is more difficult to
edit. Filed 5192089 and added a workaround so that we
don't produce this kind of markup.

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Avoid inline elements when inserting the new list.

1:54 AM Changeset in webkit [21533] by oliver

8 edits in trunk/WebKit

2007-05-17 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image

out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)

This patch causes the construction of the RTF and TIFF data to be delayed until requested.

We delay TIFF construction from a DOMElement as this may require generating TIFF data
from the CachedImage, which is slow. To allow the TIFF data to be created later the
it's necessary to add a reference to the source DOMElement to the view.

Misc/WebNSPasteboardExtras.h:
Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]): Implements the delayed write of RTF data (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Set up the pasteboard to allow the data writing to be delayed (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): Clear the dragging pasteboard once the drag has ended to ensure we don't hold references to anything longer than we need to. (WebDragClient::declareAndWriteDragImage):

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): Make sure we clear out the DOMElement reference once it is no longer needed (-[WebHTMLView pasteboard:provideDataForType:]): Provide delayed data (-[WebHTMLView _writeSelectionToPasteboard:]): Make sure we set pasteboard ownership correctly (-[WebHTMLView promisedDragTIFFDataSource]): (-[WebHTMLView setPromisedDragTIFFDataSource:]): (-[WebHTMLView writeSelectionToPasteboard:types:]):
WebView/WebHTMLViewInternal.h:
WebView/WebHTMLViewPrivate.h:

WebView/WebView.mm: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):

1:52 AM Changeset in webkit [21532] by hyatt

4 edits in trunk/WebCore

Allow redundant attributes with the same name in view source mode.

Reviewed by aroben

dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):

1:48 AM Changeset in webkit [21531] by andersca

1 edit
1 add in trunk/WebCore

1:46 AM Changeset in webkit [21530] by staikos

2 edits in trunk/WebCore

Back out last patch based on discussion with Zack

1:38 AM Changeset in webkit [21529] by andersca

5 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

This happens because the form delegate gets passed the wrong source frame during the second submit().
If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
This causes the found frame to be used as the source frame, which is wrong.

The fix is to create the form state object before checking what frame to load the new request in.

WebCore.exp:
loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy):
loader/FrameLoader.h:
manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

Update for WebCore changes.

WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

May 16, 2007:

11:52 PM Changeset in webkit [21528] by mjs

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479

loader/FrameLoader.cpp: (WebCore::FrameLoader::frameHasLoaded):

11:28 PM Changeset in webkit [21527] by hyatt

1 edit in trunk/LayoutTests/fast/frames/viewsource-attribute-expected.txt

Update the lone view source mode layout test.

11:27 PM Changeset in webkit [21526] by hyatt

5 edits in trunk/WebCore

Improve the syntax-highlighted view source mode. It now preserves all whitespace properly
and highlights doctypes and comments (in addition to all the stuff it could highlight before).

Reviewed by aroben

html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:

10:37 PM Changeset in webkit [21525] by beidson

2 edits in trunk/WebKitTools

Build fix for some dev configurations

DumpRenderTree/DumpRenderTree.m:

9:47 PM Changeset in webkit [21524] by mjs

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
<rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
http://bugs.webkit.org/show_bug.cgi?id=13683
<rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
http://bugs.webkit.org/show_bug.cgi?id=13694
<rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list

loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall load completed, even if we think the current frame load is already complete.

9:21 PM Changeset in webkit [21523] by mjs

9 edits
13 adds in trunk

LayoutTests:

Reviewed by Justin.

added a bunch of layout tests using the new load delegate testing mechanism

http/tests/loading/bad-scheme-subframe-expected.txt: Added.
http/tests/loading/bad-scheme-subframe.html: Added.
http/tests/loading/bad-server-subframe-expected.txt: Added.
http/tests/loading/bad-server-subframe.html: Added.
http/tests/loading/basic-expected.txt: Added.
http/tests/loading/basic.html: Added.
http/tests/loading/empty-subframe-expected.txt: Added.
http/tests/loading/empty-subframe.html: Added.
http/tests/loading/simple-subframe-expected.txt: Added.
http/tests/loading/simple-subframe.html: Added.

WebKitTools:

Reviewed by Justin.

created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"

The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
that happen before the load commits.

Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
optional logging for every FrameLoadDelegate callback, including SPI callbacks.

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (shouldLogFrameLoadDelegates): (runTest): (displayWebView): (+[DumpRenderTreeEvent mouseLocation]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeDraggingInfo.m: (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
DumpRenderTree/FrameLoadDelegate.h: Added.
DumpRenderTree/FrameLoadDelegate.m: Added. (-[WebFrame _drt_descriptionSuitableForTestResult]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
DumpRenderTree/ResourceLoadDelegate.m: (-[NSURL _drt_descriptionSuitableForTestResult]):
DumpRenderTree/UIDelegate.m: (-[UIDelegate webViewFocus:]):

5:34 PM Changeset in webkit [23372] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix for:

<rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
<rdar://problem/5205654> Select popup menus should always be ltr to match the mac

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align. (WebCore::PopupMenu::calculatePositionAndSize): ditto. (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.

2:47 PM Changeset in webkit [21522] by bdakin

15 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Changes for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

New test:

fast/table/tableInsideCaption-expected.checksum: Added.
fast/table/tableInsideCaption-expected.png: Added.
fast/table/tableInsideCaption-expected.txt: Added.
fast/table/tableInsideCaption.html: Added.

Good changes.

tables/mozilla/bugs/bug48028-1-expected.checksum:
tables/mozilla/bugs/bug48028-1-expected.png:
tables/mozilla/bugs/bug48028-1-expected.txt:
tables/mozilla_expected_failures/core/captions1- expected.checksum:
tables/mozilla_expected_failures/core/captions1-expected.png:
tables/mozilla_expected_failures/core/captions1-expected.txt:

Not great changes. These changes expose other bugs. Filing reports
for these.

tables/mozilla/bugs/bug48028-2-expected.txt:
tables/mozilla/bugs/bug55789-expected.checksum:
tables/mozilla/bugs/bug55789-expected.png:
tables/mozilla/bugs/bug55789-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

Hyatt's http://trac.webkit.org/projects/webkit/changeset/21428
exposed this bug. We were not handling error cases with <caption>
correctly. This patch makes them do the same thing as colgroup.

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLParserErrorCodes.cpp: No need any more for caption- specific errors. (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h: (WebCore::):

2:30 PM Changeset in webkit [23371] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by .

win/Skipped: Added a new test that requires DRT to be able to handle multiple windows.

1:57 PM Changeset in webkit [21521] by kmccullo

7 edits in trunk

LayoutTests:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Added tests for allowing JS to close a window that was opened by the DOM.

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.
fast/dom/resources/close.html: Added.
fast/dom/resources/middle.html: Added.

WebCore:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Now windows opened by the DOM can be closed by JS.

bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::openedByDOM): (WebCore::FrameLoader::setOpenedByDOM): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
loader/FrameLoader.h:

WebKitTools:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Now windows opened by the DOM can be closed by JS.

DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController windowCount]):

1:15 PM Changeset in webkit [21520] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

fast/css/fieldset-display-row-expected.checksum: Added.
fast/css/fieldset-display-row-expected.png: Added.
fast/css/fieldset-display-row-expected.txt: Added.
fast/css/fieldset-display-row.html: Added.

WebCore:

Reviewed by Hyatt.

fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

Test: fast/css/fieldset-display-row.html

rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Change all decision making about special handling for new children to use the class of the render object instead of the style, except for the cases where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION). Thus a RenderFieldset with table-row style won't get handled as if it was a table row.

rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing. Except that here the styles that we ahave to look at are TABLE_CAPTION, TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.

12:53 PM Changeset in webkit [21519] by spadma

3 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

Plugin/inc/PluginSkin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):

12:52 PM Changeset in webkit [21518] by spadma

3 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

Plugin/inc/PluginSkin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):

6:53 AM Changeset in webkit [21517] by zack

5 edits in trunk/WebCore

Implement Canvas element in the Qt port.

Implementation of Context2D was completely missing in the
Qt port. This commit adds bigger parts of it.
r=Lars

6:50 AM Changeset in webkit [21516] by zack

2 edits in trunk/WebCore

Fix shared timers.

Make the timers correctly use miliseconds. Based on a patch
from George.

4:12 AM Changeset in webkit [21515] by lars

2 edits in trunk/WebKitQt

Reviewed by Zack

pass the mouse events to the event handler, not the frameview.

4:05 AM Changeset in webkit [21514] by lars

2 edits in trunk/LayoutTestResults

Update layout tests for error handling changes.

2:25 AM Changeset in webkit [21513] by hyatt

1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Update layout tests for error handling changes.

1:47 AM Changeset in webkit [21512] by hyatt

1 edit in trunk/WebCore/WebCore.pro

Fix Qt build.

1:22 AM Changeset in webkit [23370] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Add new HTMLParserErrorCodes files.

1:11 AM Changeset in webkit [21511] by hyatt

5 edits
2 adds in trunk/WebCore

Add rudimentary error reporting to the HTML parser. This is disabled
for now until it gets beefed up a bit more (and until we work out how
best to pass the messages up without hurting perf).

Clean up and remove dead error handling code and incorrect error handling
code as well.

Reviewed by mjs

WebCore.xcodeproj/project.pbxproj:
html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLParser.h: (WebCore::HTMLParser::reportError):
html/HTMLParserErrorCodes.cpp: Added. (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h: Added. (WebCore::):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::tagStartLineNumber):

May 15, 2007:

11:22 PM Changeset in webkit [21510] by hyatt

2 edits in trunk/WebCore

Make FrameLoader write "<html><body>" instead of just "<body>".

Reviewed by aroben

loader/FrameLoader.cpp: (WebCore::FrameLoader::init):

10:04 PM Changeset in webkit [21509] by staikos

1 edit in trunk/WebCore/ChangeLog

repair changelog

9:47 PM Changeset in webkit [21508] by staikos

2 edits in trunk/WebCore

Make the loader pass cookies through

9:25 PM Changeset in webkit [21507] by staikos

2 edits in trunk/WebCore

2007-05-15 Adam Treat <adam@staikos.net>

Reviewed by George Staikos.

Implement drawArc with proper units.

9:19 PM Changeset in webkit [21506] by staikos

2 edits in trunk/WebCore

2007-05-15 Adam Treat <adam@staikos.net>

Reviewed by George Staikos.

Add missing paint for nested subframes.

8:35 PM Changeset in webkit [21505] by weinig

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Yet more tests for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Tests for SVG attributes that take a DOMString.

fast/dom/svg-element-attribute-js-null-expected.txt: Added.
fast/dom/svg-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Convert JS null to null string for SVG attributes.

Test: fast/dom/svg-element-attribute-js-null.xhtml

ksvg2/svg/SVGAngle.idl:
ksvg2/svg/SVGElement.idl:
ksvg2/svg/SVGLength.idl:
ksvg2/svg/SVGScriptElement.idl:

8:24 PM Changeset in webkit [21504] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver.

More Tests for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Tests for CanvasRenderingContext2D attributes that take a DOMString.

fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Added.
fast/dom/canvasContext2d-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Convert JS null to null string for CanvasRenderingContext2D attributes.

Test: fast/dom/canvasContext2d-element-attribute-js-null.html

html/CanvasRenderingContext2D.idl:

7:57 PM Changeset in webkit [21503] by oliver

6 edits in trunk

2007-05-15 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam and Geoff.

Removing dead code left behind from drag and drop refactoring.

page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Sam and Geoff.

Removing dead code left behind from drag and drop refactoring.

WebCoreSupport/WebFrameBridge.mm:
WebView/WebHTMLView.mm:
WebView/WebHTMLViewPrivate.h:

7:22 PM Changeset in webkit [21502] by weinig

9 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver.

More Tests for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Tests for CSSOM attributes that take a DOMString.

fast/dom/css-element-attribute-js-null-expected.txt: Added.
fast/dom/css-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Second Patch for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Convert JS null to null string for remaining CSSOM attributes.

Test: fast/dom/css-element-attribute-js-null.html

bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMMediaList::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSValue::put):
css/CSSPageRule.idl:
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl:
css/CSSValue.idl:
css/MediaList.idl:

5:44 PM Changeset in webkit [23369] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

WebLocalizableStrings.cpp: (WebLocalizedString): Make failure to load a localized string slightly less fatal

4:35 PM Changeset in webkit [21501] by aroben

2 edits in trunk/WebKitTools

Reviewed by David Kilzer.

http://bugs.webkit.org/show_bug.cgi?id=13732
prepare-ChangeLog should work with git

Scripts/prepare-ChangeLog: Added support for Git.

4:19 PM Changeset in webkit [21500] by bdash

2 edits in trunk/WebKit

2007-05-15 Bruce Q Hammond <bruceq@apple.com>

Reviewed by Darin.

Correction of previous patch for http://bugs.webkit.org/show_bug.cgi?id=13578
This corrects the sign of the Y-Axis origin adjustment.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

4:15 PM Changeset in webkit [23368] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

<rdar://problem/4956541> Need to implement preference for how much History is maintained

WebHistory.cpp: (WebHistory::ageLimitDate): Remove extra +30 from history age in days.

3:35 PM Changeset in webkit [21499] by justing

95 edits in trunk/LayoutTests

Updating expected results for r21074.

css1/cascade/cascade_order-expected.checksum:
css1/cascade/cascade_order-expected.png:
css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum:
css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
css2.1/t0505-c16-descendant-01-e-expected.checksum:
css2.1/t0505-c16-descendant-01-e-expected.png:
css2.1/t050803-c14-classes-00-e-expected.checksum:
css2.1/t050803-c14-classes-00-e-expected.png:
css2.1/t0509-c15-ids-01-e-expected.checksum:
css2.1/t0509-c15-ids-01-e-expected.png:
css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
css2.1/t0805-c5518-brdr-t-01-e-expected.png:
css2.1/t0805-c5519-brdr-r-02-e-expected.checksum:
css2.1/t0805-c5519-brdr-r-02-e-expected.png:
css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
css2.1/t0805-c5520-brdr-b-01-e-expected.png:
css2.1/t0805-c5521-brdr-l-02-e-expected.checksum:
css2.1/t0805-c5521-brdr-l-02-e-expected.png:
css2.1/t1205-c563-list-type-00-b-expected.checksum:
css2.1/t1205-c563-list-type-00-b-expected.png:
css2.1/t1205-c564-list-img-00-b-g-expected.checksum:
css2.1/t1205-c564-list-img-00-b-g-expected.png:
fast/backgrounds/repeat/noRepeatCorrectClip-expected.checksum:
fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
fast/block/float/014-expected.checksum:
fast/block/float/014-expected.png:
fast/css/001-expected.checksum:
fast/css/001-expected.png:
fast/css/css2-system-fonts-expected.checksum:
fast/css/css2-system-fonts-expected.png:
fast/doctypes/001-expected.checksum:
fast/doctypes/001-expected.png:
fast/doctypes/002-expected.checksum:
fast/doctypes/002-expected.png:
fast/doctypes/003-expected.checksum:
fast/doctypes/003-expected.png:
fast/doctypes/004-expected.checksum:
fast/doctypes/004-expected.png:
fast/dom/Window/window-onFocus-expected.checksum:
fast/dom/Window/window-onFocus-expected.png:
fast/events/keydown-1-expected.checksum:
fast/events/keydown-1-expected.png:
fast/lists/002-expected.checksum:
fast/lists/002-expected.png:
fast/lists/003-expected.checksum:
fast/lists/003-expected.png:
fast/lists/005-expected.checksum:
fast/lists/005-expected.png:
fast/lists/007-expected.checksum:
fast/lists/007-expected.png:
fast/lists/008-expected.checksum:
fast/lists/008-expected.png:
fast/lists/big-list-marker-expected.checksum:
fast/lists/big-list-marker-expected.png:
fast/lists/dynamic-marker-crash-expected.checksum:
fast/lists/dynamic-marker-crash-expected.png:
fast/lists/item-not-in-list-line-wrapping-expected.checksum:
fast/lists/item-not-in-list-line-wrapping-expected.png:
fast/lists/marker-image-error-expected.checksum:
fast/lists/marker-image-error-expected.png:
fast/lists/ol-display-types-expected.checksum:
fast/lists/ol-display-types-expected.png:
fast/lists/scrolled-marker-paint-expected.checksum:
fast/lists/scrolled-marker-paint-expected.png:
fast/overflow/overflow-rtl-expected.checksum:
fast/overflow/overflow-rtl-expected.png:
fast/repaint/list-marker-2-expected.checksum:
fast/repaint/list-marker-2-expected.png:
fast/repaint/list-marker-expected.checksum:
fast/repaint/list-marker-expected.png:
fast/selectors/001-expected.checksum:
fast/selectors/001-expected.png:
fast/selectors/013-expected.checksum:
fast/selectors/013-expected.png:
fast/selectors/015-expected.checksum:
fast/selectors/015-expected.png:
fast/selectors/166-expected.checksum:
fast/selectors/166-expected.png:
tables/mozilla/bugs/bug23235-expected.checksum:
tables/mozilla/bugs/bug23235-expected.png:
tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug3191-expected.checksum:
tables/mozilla/bugs/bug3191-expected.png:
tables/mozilla/marvin/backgr_index-expected.checksum:
tables/mozilla/marvin/backgr_index-expected.png:
tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
tables/mozilla/marvin/backgr_layers-opacity-expected.png:
tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
tables/mozilla_expected_failures/bugs/bug1010-expected.png:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:

3:19 PM Changeset in webkit [21498] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

css/html4.css: Remove wbr style rule -- not needed any more.

3:03 PM Changeset in webkit [21497] by beidson

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Brady

test for http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page

http/tests/misc/multipart-expected.txt: Added.
http/tests/misc/multipart.html: Added.
http/tests/misc/resources/1x1-blue.png: Added.
http/tests/misc/resources/multipart.php: Added.

WebCore:

Reviewed by Brady

fix http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page

Test: http/tests/misc/multipart.html

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFail): Avoid calling didFailToLoad() if didFinishLoad() has already been called (when the first part of a multipart resource arrived). (WebCore::ResourceLoader::didCancel): Ditto.

2:42 PM Changeset in webkit [21496] by bdash

1 copy in tags/Safari-4522.8

New tag.

2:39 PM Changeset in webkit [21495] by bdash

4 edits in branches/Safari-522

Versioning.

12:04 PM Changeset in webkit [21494] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Adele Peterson.

It helps if you swap the right variable.

wtf/HashSet.h: (WTF::::operator):

11:21 AM Changeset in webkit [21493] by spadma

2 edits in S60/trunk/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

11:20 AM Changeset in webkit [21492] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

11:11 AM Changeset in webkit [21491] by spadma

2 edits in S60/trunk/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

11:10 AM Changeset in webkit [21490] by spadma

2 edits in S60/branches/3.1m/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

10:53 AM Changeset in webkit [21489] by weinig

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Tests for Core DOM attributes.

fast/dom/coreDOM-element-attribute-js-null-expected.txt: Added.
fast/dom/coreDOM-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Convert JS null to null string for remaining Core DOM attributes.

Test: fast/dom/coreDOM-element-attribute-js-null.xhtml

dom/Attr.cpp: (WebCore::Attr::setValue): Don't throw an expection for null values as this is not in the spec and Firefox does not do it either.
dom/Attr.idl:
dom/CharacterData.idl:
dom/ProcessingInstruction.idl:

10:50 AM Changeset in webkit [21488] by sfalken

6 edits in branches/Safari-522/WebCore

Merged fix from r21227.

9:47 AM Changeset in webkit [21487] by ggaren

7 edits
2 deletes in trunk/WebKit

Reviewed by Maciej Stachowiak.

Patch: fixed <rdar://problem/5198890> .5% performance regression caused
by r21307

The only code r21307 added that runs during the PLT is a frame load delegate
-respondsToSelector: call inside windowObjectCleared(), so it seems like
our message dispatch overhead for the frame load delegate is significant.

This patch is a straight port of Maciej's fix for the same problem in the
resource load delegate. The solution is simple enough: don't use Objective-C.
Instead, use a special structure that caches which methods the delegate
implements, along with pointers to those methods.

I verified each frame load delegate callback in the debugger, except for
-webView:didFailLoadWithError:forFrame:, which is not implemented by Safari
or DumpRenderTree.

WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.h: Removed.
WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.m: Removed.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]): I also removed a misleading comment here. The JS debugger caches the windowScriptObject, so you do need to re-create the debugger every time you invalidate the old WebScriptObject wrapper for the window object and create a new one, or the debugger will stop working. We could fix this in a number of ways, but <rdar://problem/4608404> is not the key issue.

7:38 AM Changeset in webkit [21486] by lars

2 edits in trunk/LayoutTestResults

Update test result now that we have the eventSender object.

6:40 AM Changeset in webkit [21485] by lars

10 edits
1 add in trunk

Extend the QObject JavaScript bindings to work for slots with
arguments.

Add the EventSender object to DRT. Currently it implements
mouseDown, mouseUp and mouseMoveTo.

Make run-webkit-tests --strict work somewhat better for form elements.

one more test passing for Qt, the first one that uses
the eventSender in DRT.

5:45 AM Changeset in webkit [21484] by justing

67 edits in trunk/LayoutTests

Updating expected results for r21074.

editing/deleting/4866671-expected.checksum:
editing/deleting/4866671-expected.png:
editing/deleting/delete-first-list-item-expected.checksum:
editing/deleting/delete-first-list-item-expected.png:
editing/deleting/delete-listitem-002-expected.checksum:
editing/deleting/delete-listitem-002-expected.png:
editing/deleting/list-item-1-expected.checksum:
editing/deleting/list-item-1-expected.png:
editing/deleting/merge-into-empty-block-2-expected.checksum:
editing/deleting/merge-into-empty-block-2-expected.png:
editing/execCommand/4641880-1-expected.checksum:
editing/execCommand/4641880-1-expected.png:
editing/execCommand/4747450-expected.checksum:
editing/execCommand/4747450-expected.png:
editing/execCommand/4916402-expected.checksum:
editing/execCommand/4916402-expected.png:
editing/execCommand/4916583-expected.checksum:
editing/execCommand/4916583-expected.png:
editing/execCommand/5142012-2-expected.checksum:
editing/execCommand/5142012-2-expected.png:
editing/execCommand/5144139-1-expected.checksum:
editing/execCommand/5144139-1-expected.png:
editing/execCommand/create-list-with-hr-expected.checksum:
editing/execCommand/create-list-with-hr-expected.png:
editing/execCommand/indent-list-item-expected.checksum:
editing/execCommand/indent-list-item-expected.png:
editing/execCommand/indent-selection-expected.checksum:
editing/execCommand/indent-selection-expected.png:
editing/execCommand/insert-list-empty-div-expected.checksum:
editing/execCommand/insert-list-empty-div-expected.png:
editing/execCommand/remove-list-item-1-expected.checksum:
editing/execCommand/remove-list-item-1-expected.png:
editing/inserting/4959067-expected.checksum:
editing/inserting/4959067-expected.png:
editing/pasteboard/4861080-expected.checksum:
editing/pasteboard/4861080-expected.png:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
editing/pasteboard/drop-link-expected.checksum:
editing/pasteboard/drop-link-expected.png:
editing/pasteboard/innerText-inline-table-expected.checksum:
editing/pasteboard/innerText-inline-table-expected.png:
editing/pasteboard/input-field-1-expected.checksum:
editing/pasteboard/input-field-1-expected.png:
editing/pasteboard/merge-end-list-expected.checksum:
editing/pasteboard/merge-end-list-expected.png:
editing/pasteboard/merge-start-list-expected.checksum:
editing/pasteboard/merge-start-list-expected.png:
editing/pasteboard/select-element-1-expected.checksum:
editing/pasteboard/select-element-1-expected.png:
editing/selection/drag-to-contenteditable-iframe-expected.checksum:
editing/selection/drag-to-contenteditable-iframe-expected.png:
editing/selection/extend-by-word-002-expected.checksum:
editing/selection/extend-by-word-002-expected.png:
editing/selection/select-all-iframe-expected.checksum:
editing/selection/select-all-iframe-expected.png:
editing/selection/selectNode-expected.checksum:
editing/selection/selectNode-expected.png:
editing/selection/selectNodeContents-expected.checksum:
editing/selection/selectNodeContents-expected.png:
editing/unsupported-content/list-delete-001-expected.checksum:
editing/unsupported-content/list-delete-001-expected.png:
editing/unsupported-content/list-type-after-expected.checksum:
editing/unsupported-content/list-type-after-expected.png:
editing/unsupported-content/list-type-before-expected.checksum:
editing/unsupported-content/list-type-before-expected.png:

3:00 AM Changeset in webkit [21483] by andrew

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13718 REGRESSION (r21093): editing/execCommand/5136770.html failing pixel test

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Moved the code that clears the selection when moving a selection border into the fast path.

2:31 AM Changeset in webkit [21482] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6487
"Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

Ignore Make Text Bigger/Smaller for SVG text.

2:28 AM Changeset in webkit [21481] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Add tests.

fast/dom/getter-on-window-object-expected.txt: Added.
fast/dom/getter-on-window-object.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Handle the case where the value returned is a getter/setter object.

bindings/js/kjs_window.cpp: (KJS::Window::getOverridePropertySlot):

1:27 AM Changeset in webkit [21480] by andersca

3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.

This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.

1:24 AM Changeset in webkit [21479] by mjs

6 edits in trunk

WebCore:

Reviewed by Hyatt and Lars.

fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window

WebCore.exp: export new symbol
loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): move marker that we committed a real doc load from here... (WebCore::FrameLoader::transitionToCommitted): ...to here (WebCore::FrameLoader::frameHasLoaded): check that we have at least started loading something besides the initial empty doc.
loader/FrameLoader.h:

WebKit:

Reviewed by Hyatt and Lars.

fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window

WebView/WebDataSource.mm: (-[WebDataSource request]): Return nil when we are still showing the initial empty doc

12:37 AM Changeset in webkit [21478] by lars

2 edits
461 adds in trunk/LayoutTestResults

5319 -> 5879 passing test cases for the Qt build.

12:31 AM Changeset in webkit [21477] by justing

5 edits in trunk/LayoutTests

Spelling markers fixed:

editing/deleting/delete-block-table-expected.checksum:
editing/deleting/delete-block-table-expected.png:
editing/selection/move-by-line-001-expected.checksum:
editing/selection/move-by-line-001-expected.png:

May 14, 2007:

11:15 PM Changeset in webkit [21476] by justing

5 edits in trunk

LayoutTests:

Reviewed by ggaren

Updated these expected results. We now clear the
selection inside a focused node *after* firing the
mousedown event handler, which matches FF:

fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by ggaren

<http://bugs.webkit.org/show_bug.cgi?id=13716>
REGRESSION: Three new layout test failures

Two failures are correct. Updated their expected results.

In fast/events/frame-tab-focus.html, as we advance
through focusable nodes, we descend into a subframe
to focus a node and then ascend out of it into the
main frame to focus the next. When we focus the main
frame, the node in that frame that was previously
focused and contains an inactive selection is focused
momentarily because setCaretVisible tries to focus the
node containing the caret.

page/Frame.cpp: (WebCore::Frame::setCaretVisible): Don't focus the node containing the caret. FocusController will focus the previously focused node (which will contain the caret) if necessary when the frame gains focus.

10:59 PM Changeset in webkit [21475] by justing

17 edits in trunk/LayoutTests

Reviewed by ggaren

Spelling markers fixed:

editing/deleting/delete-to-select-table-expected.checksum:
editing/deleting/delete-to-select-table-expected.png:
editing/selection/end-of-document-expected.checksum:
editing/selection/end-of-document-expected.png:
editing/inserting/insert-paragraph-02-expected.checksum:
editing/inserting/insert-paragraph-02-expected.png:

Focus halo now painted:

editing/execCommand/format-block-with-braces-expected.checksum:
editing/execCommand/format-block-with-braces-expected.png:

Needed FIXMEs removed after fixing 4714993:

editing/pasteboard/merge-end-1-expected.checksum:
editing/pasteboard/merge-end-1-expected.png:
editing/pasteboard/merge-end-1-expected.txt:
editing/pasteboard/merge-end-1.html:
editing/pasteboard/merge-end-2-expected.checksum:
editing/pasteboard/merge-end-2-expected.png:
editing/pasteboard/merge-end-2-expected.txt:
editing/pasteboard/merge-end-2.html:

10:53 PM Changeset in webkit [21474] by mjs

3 edits
5 adds in trunk

LayoutTests:

Reviewed by Brady.

Test case for <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

http/tests/incremental/slow-utf8-html.pl:
http/tests/navigation/back-to-slow-frame.html: Added.
http/tests/navigation/back-to-slow-frame-expected.txt: Added.
http/tests/navigation/resources/back-to-slow-frame-2.html: Added.
http/tests/navigation/resources/back-to-slow-frame-3.html: Added.
http/tests/navigation/resources/slow-resource-1-sec.pl: Added.

WebCore:

Reviewed by Brady.

fixed <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

Test: http/tests/navigation/back-to-slow-frame.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Add needed early return.

9:17 PM Changeset in webkit [23367] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.

If the image does not already have a title, fall back to the
name suggested by Content-Disposition.

platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):

8:49 PM Changeset in webkit [23366] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)

Null terminate manually to prevent us from dereferencing null.

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData):

7:05 PM Changeset in webkit [23365] by oliver

4 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Windows side of fix for
<rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::cfHDropFormat): Need to be able to access externally

platform/win/ClipboardUtilitiesWin.h: Declare cfHDropFormat

platform/win/DragDataWin.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): Add implementation of containsFiles and asFilenames

6:53 PM Changeset in webkit [21473] by bdash

3 edits
3 adds in trunk

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

kjs/nodes2string.cpp: (ArrayNode::streamTo): print extra ',' in case there was elision commas (check opt member var) and array elements present in the array expression

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for fix to http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

fast/js/resources/toString-elision-trailing-comma.js: Added.
fast/js/toString-elision-trailing-comma-expected.txt: Added.
fast/js/toString-elision-trailing-comma.html: Added.

6:41 PM Changeset in webkit [21472] by bdash

3 edits
2 adds in trunk

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13603 style leaks in washingtonpost.com also known as http://bugs.webkit.org/show_bug.cgi?id=8750 w3c.org: incorrect recovery from unclosed <a> elements also known as http://bugs.webkit.org/show_bug.cgi?id=12808 Handling of misnested tags results in entire page appearing as link also known as http://bugs.webkit.org/show_bug.cgi?id=12861 Post text renders as link

Test: fast/parser/residual-style-close-across-n-blocks.html

html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Changed to deal with multiple block crossings instead of bailing out, by doing multiple reparenting passes, starting from the outermost block.

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13603 style leaks in washingtonpost.com

fast/parser/residual-style-close-across-n-blocks-expected.txt: Added.
fast/parser/residual-style-close-across-n-blocks.html: Added.

6:39 PM Changeset in webkit [21471] by bdash

4 edits in trunk/WebCore

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13711 REGRESSION - Bookmark Bar text rendering changed

No test possible since this patch affects only Safari chrome.

platform/Font.cpp: (WebCore::Font::Font): Initialize m_isPlatformFont according to whether the Font object is derived from a FontPlatformData or not.
platform/Font.h: (WebCore::Font::isPlatformFont): Added. Returns whether this Font was derived from a platform font.
platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to not enable synthetic bold and italic in the fallback fonts if the original font was derived from a platform font.

6:32 PM Changeset in webkit [21470] by weinig

58 edits
4 adds
2 deletes in trunk

LayoutTests:

Reviewed by Alice.

Tests for http://bugs.webkit.org/show_bug.cgi?id=13541 REGRESSION: Setting a DOMString attribute to JS null in the JS bindings should default to converting to the empty string

fast/dom/document-attribute-js-null-expected.txt: Added.
fast/dom/document-attribute-js-null.html: Added.
fast/dom/element-attribute-js-null-expected.txt: Added.
fast/dom/element-attribute-js-null.html: Added.
fast/forms/input-null-expected.txt: Removed.
fast/forms/input-null.html: Removed.

WebCore:

Reviewed by Alice!

Patch for http://bugs.webkit.org/show_bug.cgi?id=13541 REGRESSION: Setting a DOMString attribute to JS null in the JS bindings should default to converting to the empty string

Convert JS null to the empty string when passing it to an attribute that takes
a DOMString.

Test: fast/dom/document-attribute-js-null.html
Test: fast/dom/element-attribute-js-null.html

bindings/js/kjs_dom.cpp: (KJS::DOMNode::putValueProperty):
bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::objectSetter): (KJS::JSHTMLElement::embedSetter): (KJS::JSHTMLElement::tableSetter): (KJS::JSHTMLElement::tableCaptionSetter): (KJS::JSHTMLElement::tableColSetter): (KJS::JSHTMLElement::tableSectionSetter): (KJS::JSHTMLElement::tableRowSetter): (KJS::JSHTMLElement::tableCellSetter): (KJS::JSHTMLElement::frameSetSetter): (KJS::JSHTMLElement::frameSetter): (KJS::JSHTMLElement::iFrameSetter): (KJS::JSHTMLElement::marqueeSetter): (KJS::JSHTMLElement::putValueProperty):
bindings/js/kjs_html.h:
dom/Document.idl:
dom/Node.idl:
html/HTMLAnchorElement.idl:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBRElement.idl:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLDivElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLHRElement.idl:
html/HTMLHeadElement.idl:
html/HTMLHeadingElement.idl:
html/HTMLHtmlElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLIsIndexElement.idl:
html/HTMLLIElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMapElement.idl:
html/HTMLMetaElement.idl:
html/HTMLModElement.idl:
html/HTMLOListElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOptGroupElement.idl:
html/HTMLOptionElement.idl:
html/HTMLParagraphElement.idl:
html/HTMLParamElement.idl:
html/HTMLQuoteElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLTitleElement.idl:
html/HTMLUListElement.idl:

5:24 PM Changeset in webkit [21469] by ggaren

2 edits in trunk/WebCore

Trying to fix the Qt build.

WebCore.pro:

5:20 PM Changeset in webkit [21468] by ggaren

5 edits in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.

Added HashMap::swap and HashSet::swap. WebCore now uses HashSet::swap.
I figured while I was in the neighborhood I might as well add HashMap::swap,
too.

wtf/HashMap.h: (WTF::::operator): (WTF::::swap):
wtf/HashSet.h: (WTF::::operator): (WTF::::swap):

WebCore:

Reviewed by Oliver Hunt.

Some improvements on my last patch, suggested by Darin.

history/PageCache.cpp: (WebCore::PageCache::autoreleaseNow): Swap with an empty set instead of building up an array and then calling clear(). This is slightly more efficient and the code is cleaner.

4:19 PM Changeset in webkit [23364] by ggaren

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

2:37 PM Changeset in webkit [21467] by justing

7 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5136696> Selection is removed when focusing a node in another frame

Demonstrates bug:

editing/selection/5136696-expected.checksum: Added.
editing/selection/5136696-expected.png: Added.
editing/selection/5136696-expected.txt: Added.
editing/selection/5136696.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5136696> Selection is removed when focusing a node in another frame
<rdar://problem/5192388> WordPress: Can't insert links/images

Don't clear a selection when changing focus if the new
focus node is in a different frame than the old selection.

dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved code to clear selections to the FocusController, since it is Page level and will know about the frame/document that contained the old selection. Moved code to call shouldEndEditing to the FocusController because selections are now cleared before calling Document::setFocusedNode and shouldEndEditing must be called before selections are cleared.
dom/Element.cpp: (WebCore::Element::blur): Call FocusController::setFocusNode instead of Document::setFocusNode, if possible.
page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Ditto.
page/FocusController.cpp: (WebCore::relinquishesEditingFocus): Moved from Document.cpp. (WebCore::clearSelectionIfNeeded): Ditto. Don't clear if the old selection is in a frame that's different than the one that contains the new focus node. (WebCore::FocusController::setFocusedNode): Moved code here from Document::setFocusedNode.
page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Call FocusController::setFocusNode.

2:37 PM Changeset in webkit [21466] by spadma

2 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):

2:36 PM Changeset in webkit [21465] by spadma

2 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):

2:29 PM Changeset in webkit [21464] by ggaren

8 edits
2 adds
2 deletes in trunk

WebCore:

Reviewed by Darin Adler.

Next step toward fixing <rdar://problem/5055182> The back cache has no
global cap.

Created a PageCache singleton. Right now, it only handles the timer-based
deallocation of cached pages. I plan to add HistoryItem->CachedPage tracking
and eviction logic in later patches.

Updated for renames and file changes:

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
history/BackForwardList.cpp: (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache):

Removed global timed release code, moved into new PageCache class, since
it's eventually going to be in charge of deciding when things are released:

history/HistoryItem.cpp: (WebCore::HistoryItem::setCachedPage):
history/HistoryItem.h:

Folded into PageCache:

history/HistoryItemTimer.cpp: Removed.
history/HistoryItemTimer.h: Removed.

New singleton. Right now, it just handles timed release of cached pages:

history/PageCache.cpp: Added. (WebCore::pageCache): (WebCore::PageCache::PageCache): (WebCore::PageCache::autoreleaseNowOrReschedule): (WebCore::PageCache::autoreleaseNow): (WebCore::PageCache::autorelease):
history/PageCache.h: Added.

WebKit:

Reviewed by Darin Adler.

Updated for WebCore move to PageCache singleton. Also removed some WebCore: prefixes and replaced them with 'using namespace WebCore'.

History/WebHistoryItem.mm: (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):

2:16 PM Changeset in webkit [21463] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload

platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.

1:57 PM Changeset in webkit [21462] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Remove incorrect assertion.

page/FrameView.cpp: (WebCore::FrameView::setContentsPos):

1:43 PM Changeset in webkit [21461] by lars

2 edits
405 adds
6 deletes in trunk/LayoutTestResults

Add another 1000 tests that we pass for the Qt build.

12:20 PM Changeset in webkit [21460] by lars

284 edits
21 adds
9 deletes in trunk/LayoutTestResults

Add another 300 test cases, that are ok on the Qt build.
Add a few more tests that need examination to the Skipped list.

12:05 PM Changeset in webkit [23363] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported

plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::forceRedraw): Make these work with windowed plugins.

11:53 AM Changeset in webkit [21459] by andersca

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5172056> Regression: cannot open txt file, get broken image

Never let plug-ins override text/plain.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):

9:34 AM Changeset in webkit [23362] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:

8:34 AM Changeset in webkit [21458] by spadma

4 edits in S60/branches/3.1m/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

Plugin/inc/PluginWin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):

8:33 AM Changeset in webkit [21457] by spadma

4 edits in S60/trunk/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

Plugin/inc/PluginWin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):

7:39 AM Changeset in webkit [21456] by zack

2 edits in trunk/WebCore

Fix dependcy tracking in project files.

Add dependpath to project to get better dependency tracking for header
files in the qmake project files.

r=simon

6:41 AM Changeset in webkit [21455] by lars

10 edits in trunk

Reviewed by Zack

Updates after Maciej's frame change.

This gets things to run again. The #ifdef PLATFORM(QT)
in the FrameLoader should not be needed (and adding the line
inside on the mac doesn't seem to trigger any failures there).
I'm submitting with it to be on the safe side for now, since I
really need our tests to run again.

Btw, post-commit-linux-qt should show up green on with this submit :))

6:30 AM Changeset in webkit [21454] by darin

6 edits in trunk/WebCore

Reviewed by Antti.

fix <rdar://problem/3109180> VIP: after go back, page jumps after loading even if I scrolled while loading

history/CachedPage.cpp: (WebCore::CachedPage::clear): Call clearFrame rather than clearPart -- the "part" term was leftover prehistoric terminology.

loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Call setWasScrolledByUser(false) on the page, so that we can detect any user scrolling that happens during the "go back" process. (WebCore::FrameLoader::restoreScrollPositionAndViewState): Don't scroll if the view's wasScrolledByUser flag is set. (WebCore::FrameLoader::loadItem): Call setWasScrolledByUser(false) false when we do a new "load" (actually just a scroll) using the same frame. Also moved the line of code that sets m_currentHistoryItem to make this code path mroe similar to recursiveGoToItem. (WebCore::FrameLoader::recursiveGoToItem): Ditto.

page/Frame.cpp: (WebCore::Frame::~Frame): Call clearFrame rather than stting m_frame directly. (WebCore::Frame::sendScrollEvent): Call setWasScrolledByUser(true) on FrameView. The FrameView itself knows to ignore this if the scrolling is being done programmatically instead of by the user.

page/FrameView.h: Added wasScrolledByUser and setWasScrolledByUser. Also removed unneeded include and class forward declarations, renamed clearPart to clearFrame, removed uneeded function haveDelayedLayoutScheduled, and removed unneeded friend declarations.
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_inProgrammaticScroll and m_wasScrolledByUser. (WebCore::FrameViewPrivate::reset): Set m_wasScrolledByUser to false. (WebCore::FrameView::clearFrame): Renamed from clearPart. (WebCore::FrameView::scrollRectIntoViewRecursively): Added code to set the m_inProgrammaticScroll flag. (WebCore::FrameView::setContentsPos): Ditto. (WebCore::FrameView::wasScrolledByUser): Added. (WebCore::FrameView::setWasScrolledByUser): Added. Does nothing if called when m_inProgrammaticScroll is true.

6:26 AM Changeset in webkit [21453] by darin

3 edits in trunk/LayoutTests

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

Test all the different forms of expressions that can contain
a dot following a number literal.
Includes new tests for PrefixDotNode, PostfixDotNode, DeleteDotNode,
AssignDotNode and FunctionCallParenDotNode.

fast/js/resources/toString-number-dot-expr.js:
fast/js/toString-number-dot-expr-expected.txt: Updated.

6:13 AM Changeset in webkit [23361] by andersca

2 edits in branches/WindowsMerge/WebKitWin

6:12 AM Changeset in webkit [21452] by darin

2 edits in trunk/WebCore

Reviewed by Antti.

<rdar://problem/4865655> REGRESSION: find function does not work for the character ß

The trick was to fold case consistently in the CircularSearchBuffer class.

The problem was that we were folding the search target string with full case folding and
the characters of the text we were searching with simple case folding. We now use full
case folding in both cases.

editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed the buffer to be a Vector<UChar>. Added a Vector<bool> to record which characters were starts of characters in the text we are searching. Changed the cursor to be an int rather than a pointer. (WebCore::CircularSearchBuffer::append): New function that knows how to append multiple characters when folding case turns one character into many -- uses the full foldCase rather than the simplified single-character foldCase. Also removed the append function that did multiple characters at once; that was part of an optimization we don't need. (WebCore::CircularSearchBuffer::isMatch): Instead of asserting that the buffer is full, changed this to return false if it's not full, which lets us fill up the buffer with the normal loop. Also return false if the start of the buffer is half-way through a case-folded character and updated this since m_cursor is now an integer. (WebCore::CircularSearchBuffer::length): This returns the length in non-case-folded characters of the characters that were appended, which may not be the same as the length of the original target string. To do that we have to total up the character start booleans for the current state of the circular buffer. (WebCore::findPlainText): Streamlined the logic in a few ways: 1) Moved more of the return value setup to the top of the function so it could be shared with the early error exit. 2) Removed the separate "fill the buffer" logic, which allowed me to remove some of the functions from CircularSearchBuffer and eliminated the need for two nested loops. 3) Replaced the CharacterIterator and bool that were used to record the location we found with integers matchStart and matchLength. 4) Got rid of the use of goto since we don't have two nested loops any more.

5:16 AM Changeset in webkit [21451] by andrew

2 edits in trunk/WebCore

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=13275
Safari crashed when trying to login using the windows live contact control

Check for cleared windowObj in JSAbstractEventListener::handleEvent

bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):

4:16 AM Changeset in webkit [23360] by andersca

2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Antti.

Report an error to the resource load delegate if the Java plugin can't be loaded.

WebFrame.cpp: (WebFrame::createJavaAppletWidget):

12:17 AM Changeset in webkit [21450] by lars

2 edits in trunk/LayoutTestResults

Skip a test that currently hangs

May 13, 2007:

10:13 PM Changeset in webkit [21449] by kevino

5 edits in branches/wx-port-alpha/trunk

Restore the Windows build after WEBKITOUTPUTDIR changes, and also copy over dependency dlls to product dir so that testkjs and the sample app won't complain about missing dlls.

9:45 PM Changeset in webkit [21448] by ap

4 edits
2 adds
2 deletes in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13690
JavaScript Form Validation issue on Banco do Brasil site

Test: fast/forms/input-setvalue-selection.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): In other browsers, changing textInput.value always moves the insertion point past the text. In 10.4.9 WebKit, this only worked for inactive controls, and it never worked in ToT.

11:43 AM Changeset in webkit [23359] by darin

2 edits in branches/WindowsMerge/WebCore

Requested by Hyatt.

internal part of http://bugs.webkit.org/show_bug.cgi?id=13529 DOM3 keyIdentifier text is incorrect

platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.

8:28 AM Changeset in webkit [21447] by beidson

5 edits in trunk/WebCore

Reviewed by Mitz

http://bugs.webkit.org/show_bug.cgi?id=13701

Since HTMLInputElements register themselves with their Document for special handling, if their document
ever changes then bad things can happen.

Unfortunately, with adoptNode, the document can change. This has been a long standing crasher with all
input fields but was given recent high visibility by r21430

The solution is to add functionality for a Node to react to its owner document changing via a pair of
virtual callbacks. Then we can tap into those callbacks in HTMLInputElement.

No layout test possible until http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved

dom/Node.cpp: (WebCore::Node::setDocument): Call willMoveToNewOwnerDocument and didMoveToNewOwnerDocument

dom/Node.h: (WebCore::Node::willMoveToNewOwnerDocument): Virtual callback to a node for before an owner document change (WebCore::Node::didMoveToNewOwnerDocument): Virtual callback to a node for after an owner document change

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Unconditionally unregister both for both form state and the cache restoration callback (WebCore::HTMLInputElement::setInputType): Change registration with the document only if we're in one (WebCore::HTMLInputElement::attach): Don't bother registering for the callback here - that will be handled by setInputType() or by a change in owner document (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Unregister with the old owner document (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): Register with the new owner document
html/HTMLInputElement.h:

7:05 AM Changeset in webkit [21446] by darin

2 edits in trunk/WebCore

platform/mac/TextBreakIteratorInternalICUMac.mm: Fix comment typo.

7:00 AM Changeset in webkit [21445] by rwlbuis

21 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13529
DOM3 keyIdentifier text is incorrect

Use 4 digits for the Unicode based key identifiers.

6:21 AM Changeset in webkit [21444] by darin

2 edits in trunk/WebKit

one more retain/release for a tiny bit more robustness

WebView/WebPDFView.mm: (-[WebPDFView _updatePreferences:]): [prefs release] (-[WebPDFView _updatePreferencesSoon]): [prefs retain]

6:16 AM Changeset in webkit [21443] by darin

3 edits in trunk/WebKit

Reviewed by Geoff.

fix <rdar://problem/5188400> Webkit crashes going back from PDF at perl.org site

WebView/WebPDFView.h: Replace _updatePreferencesTimer with _willUpdatePreferencesSoon BOOL. Also remove unneeded @public that gives other classes access to our dataSource member.

WebView/WebPDFView.mm: Rearrange top of file a bit, remove forward declaration of the _cancelUpdatePreferencesTimer method. (-[WebPDFView dealloc]): Removed call to _cancelUpdatePreferencesTimer. (-[WebPDFView _updatePreferencesNow:]): Added WebPreferences parameter. This sidesteps problems where the dataSource is no longer present by not looking at the dataSource field at all. Also removed the call to _cancelUpdatePreferencesTimer, added code to set _willUpdatePreferencesSoon to NO and added a release to balance a retain I did in _updatePreferencesSoon. (-[WebPDFView _updatePreferencesSoon]): Changed to use performSelectorAfterDelay instead of an NSTimer. Pass in the preferences object as a parameter, since we might not be able to get to the dataSource when the timer fires.

5:55 AM Changeset in webkit [21442] by darin

2 edits in trunk/WebCore

Reviewed by Antti.

fix <rdar://problem/5174903> Safari crashes opening the attached webarchive (made by OmniWeb)

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Check ResourceHandle for nil before calling url() on it. (WebCore::IconLoader::didFail): Ditto. (WebCore::IconLoader::didFinishLoading): Ditto.

12:25 AM Changeset in webkit [21441] by rwlbuis

6 edits in trunk/WebCore

Reviewed by Oliver.

Cleanup, get rid of the SVGStyledElement::view() call.

May 12, 2007:

11:02 PM Changeset in webkit [21440] by hyatt

4 adds in trunk/LayoutTests/fast/invalid

Add layout tests for residual style fix.

11:01 PM Changeset in webkit [21439] by hyatt

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13680 Incomplete repaint of focus ring around continuation

Test: fast/repaint/continuation-after-outline.html

rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):

10:50 PM Changeset in webkit [21438] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=13680 Incomplete repaint of focus ring around continuation

fast/repaint/continuation-after-outline-expected.checksum: Added.
fast/repaint/continuation-after-outline-expected.png: Added.
fast/repaint/continuation-after-outline-expected.txt: Added.
fast/repaint/continuation-after-outline.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13680 Incomplete repaint of focus ring around continuation

Test: fast/repaint/continuation-after-outline.html

rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):

10:26 PM Applications using WebKit edited by christian@twotoasts.de

Added Midori web browser. (diff)

10:21 PM Changeset in webkit [23358] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-12 Oliver Hunt <oliver@apple.com>

rs=hyatt.

Stubs to prevent build bustage

platform/win/DragDataWin.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

10:15 PM Changeset in webkit [21437] by oliver

13 edits
2 adds in trunk

2007-05-12 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Add test to verify files can be dragged to <input type="file">

fast/forms/dragging-to-file-input-expected.txt: Added.
fast/forms/dragging-to-file-input.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

This patch allows a file to be dropped on to a file input field. There
are a few changes for data handling and a few to allow the data to be
threaded to the appropriate places.

page/DragController.cpp: (WebCore::asFileInput):

When dropping a file onto a file input we may mouse over either
the element itself, or the contained button element. This method
returns the base element for the file input in either of these
cases.

(WebCore::DragController::tryDocumentDrag):

Don't try to set the drag caret to a file input.

(WebCore::DragController::concludeDrag):

Handle dropping onto a file input element.

(WebCore::DragController::canProcessDrag):

We can now process a file being dragged onto a file input element.

platform/DragData.h:

New accessors

platform/gdk/DragDataGdk.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Link stubs.

platform/mac/DragDataMac.mm: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Implement new accessors

(WebCore::DragData::containsCompatibleContent):

Update containsCompatibleContent to allow standalone files.

platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Link stubs

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::receiveDroppedFile):
rendering/RenderFileUploadControl.h:

For security reasons we don't have an api to allow us to set
a value directly on a file input -- attempts to do so are
blocked. By adding a method to set the target through the
render we bypass such restrictions, and ensure the renderer
is updated correctly.

WebKitTools:

Reviewed by Hyatt.

Add new api to DRT to allow us to test a file being dragged
onto <input type="file">

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController addFileToPasteboardOnDrag]): (runTest):
DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

7:31 PM Changeset in webkit [21436] by weinig

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13695 REGRESSION (r21387): Replaced elements' highlight rects are wrongly positioned

fast/replaced/selection-rect-expected.checksum: Added.
fast/replaced/selection-rect-expected.png: Added.
fast/replaced/selection-rect-expected.txt: Added.
fast/replaced/selection-rect.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13695 REGRESSION (r21387): Replaced elements' highlight rects are wrongly positioned

Test: fast/replaced/selection-rect.html

Also fixes the same problem with list markers, covered by existing test
fast/lists/markers-in-selection.html.

rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):

7:12 PM Changeset in webkit [21435] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

fast/repaint/text-selection-rect-in-overflow-expected.checksum: Added.
fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
fast/repaint/text-selection-rect-in-overflow.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

Test: fast/repaint/text-selection-rect-in-overflow.html

rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

5:50 PM Changeset in webkit [21434] by kevino

7 edits in branches/wx-port-alpha/trunk

Have Bakefile internally refer to WEBKITOUTPUTDIR and WEBKIT_ROOT using different names to avoid collisions when those are defined as environment variables on the user's machine.

5:39 PM Changeset in webkit [21433] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Don't schedule a relayout, that triggers the if (root->needsLayout()) code path in FrameView::layout(). See #13455 for why this is a problem. Also, if frameView->needsLayout() is true, make sure to layout before painting rather than bailing out of the paint event.

3:24 PM Changeset in webkit [21432] by mjs

3 edits in trunk/WebKitQt

Reviewed by Rob Buis.

call Frame::init as needed - this prevents crashes but pages don't appear.

Api/qwebframe.cpp: (QWebFramePrivate::init):
WebKitPart/WebKitPart.cpp: (WebKitPart::initView):

2:56 PM Changeset in webkit [21431] by beidson

2 edits in trunk/WebCore

Rubber stamped by Mitz

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): unregister->register - I screwed this one up in last minute renaming before committing :(

2:22 PM Changeset in webkit [21430] by beidson

12 edits in trunk/WebCore

Reviewed by Darin and Geoff

Fix for http://bugs.webkit.org/show_bug.cgi?id=13630
and
<rdar://problem/4873628>

Back/Forward cache should work with pages with login fields.

First change is to relocate the "useSecureKeyboardEntry" flag to the document. This lets
it persist through page cache transitions and it is truly a per-document concept more than
per-frame anyways since its the document that has a password field, not the frame.

Second change is to introduce the concept of an Element getting a "didRestoreFromCache()" callback.
The idea is for elements to register with the document if they need work to be done when the
page comes out of the back/forward cache. Currently the only client of this service is
HTMLInputElements that are input type == PASSWORD. Such an element's implementation for this
method is to call reset()

Finally, after a page is restored from the cache we have the document send the didRestoreFromCache()
callback to its registered Elements. The whole design is to clear the password fields after
restoring the page instead of when caching the page because we want to defer work for the common
case - there shouldn't be extra work here just to navigate away from a page when the common case
is that you'll never go back!

No layout tests possible until http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::registerForDidRestoreFromCacheCallback): Add an Element to the special page-restoration callback list (WebCore::Document::unregisterForDidRestoreFromCacheCallback): Remove such an element (WebCore::Document::didRestoreFromCache): Called by FrameLoader - dispatch to all the registered elements (WebCore::Document::setUseSecureKeyboardEntryWhenActive): Set the local flag and call updateSecureKeyboardEntryIfActive on the Frame (WebCore::Document::useSecureKeyboardEntryWhenActive): Return the flag

dom/Document.h: (WebCore::Document::unregisterFormElementWithState): Renamed

dom/Element.h: (WebCore::Element::didRestoreFromCache): Added virtual base method

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Deregister from the document if inputType == PASSWORD (WebCore::HTMLInputElement::dispatchFocusEvent): Set the flag on the document, not the frame (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto (WebCore::HTMLInputElement::setInputType): If changing to/from PASSWORD, register/deregister in the document accordingly (WebCore::HTMLInputElement::attach): Call registerForDidRestoreFromCacheCallback(this) instead of passwordFieldAdded() (WebCore::HTMLInputElement::didRestoreFromCache): Call reset();
html/HTMLInputElement.h:

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::~HTMLSelectElement): Renamed deregisterFormElementWithState to unregisterFormElementWithState
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): Ditto

loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage): Remove the check for password fields - they're allowed now! (WebCore::FrameLoader::opened): Tell the document to dispatch to the registered elements (WebCore::FrameLoader::saveDocumentState): Remove the check for password fields. Turns out that when we grab a copy a the form state we're only copying the state of form elements that are registered with the Document - and that set explicitly excludes Password elements

page/Frame.cpp: (WebCore::Frame::setDocument): If the frame is active, set the setUseSecureKeyboardEntry based on the setting contained in the new document (WebCore::Frame::updateSecureKeyboardEntryIfActive): Notification for the secure entry flag changing - if the Frame is active, then update to the new setting from the document (WebCore::Frame::setIsActive): Grab the useSecureKeyboardEntry flag from the document instead of FramePrivate (WebCore::FramePrivate::FramePrivate):
page/Frame.h:
page/FramePrivate.h:

2:18 PM Changeset in webkit [21429] by hyatt

28 edits
4 adds in trunk/LayoutTests/fast/invalid

Update existing invalid tests and add new test for 12740.

2:15 PM Changeset in webkit [21428] by hyatt

2 edits in trunk/WebCore

Fix for bug 12740, bmw.com doesn't work. We were missing a rule that is covered by the HTML5
parsing spec. A <table> encountered while inside stray table content should close up the
table responsible for the stray content and start the new table as a sibling of the first.

Reviewed by mjs

fast/invalid/table-inside-stray-table-content.html

1:35 AM Changeset in webkit [21427] by eseidel

2 edits in trunk/WebCore

2007-05-12 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

Crash starting Safari with JavaScript disabled.
http://bugs.webkit.org/show_bug.cgi?id=13691

Test: none possible.

page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): NULL check d->m_script

May 11, 2007:

11:43 PM Changeset in webkit [21426] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add layout test for colloquy display table baseline issue.

11:40 PM Changeset in webkit [21425] by hyatt

3 edits in trunk/WebCore

Fix for http://bugs.webkit.org/show_bug.cgi?id=13688, Colloquy is broken!

Make sure to adjust the baseline of a percentage height table cell's row if the
cell flexes (and lowers the baseline).

Reviewed by olliej

fast/tables/vertical-align-baseline-readjust.html

(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):

rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline):

5:26 PM Changeset in webkit [23357] by sfalken

88 edits
3 adds
1 delete in branches/WindowsMerge

2007-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Ada.

WebKit DCOM compatibility.
When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
is registered to allow creation across processes. This is for future compatibility with
Drosera.

Added new exported function: RunAsLocalServer.
This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
will allow Drosera to connect to it via DCOM.

We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
based on type libraries, so as part of this change, I've done some work on making our
interfaces compatible with this marshaller.

Updated for compatibility w/ COM automation, and fixed up our type library.
Added type library registration/unregistration code.
Marked methods not compatible w/ automation/marshalling as [local].

As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
assembly to theoretically allow WebKit to be invoked from .NET apps. I haven't
tried this. It could end up being useful to drive API testing.

To test, I wrote a small app that calls:
::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void)&viewUnknown);
Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
source, title, URL, etc.

2007-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Ada.

Updated for COM Automation changes in WebKit.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Updated for WebKit API changes. (main): Updated for WebKit API changes.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (doMouseUp): Updated for WebKit API changes. (doMouseMove): Updated for WebKit API changes.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveIcon): Updated for WebKit API changes. (WaitUntilDoneDelegate::webViewFirstResponder): Updated for WebKit API changes. (WaitUntilDoneDelegate::makeFirstResponder): Updated for WebKit API changes. (WaitUntilDoneDelegate::contextMenuItemsForElement): Updated for WebKit API changes. (WaitUntilDoneDelegate::trackCustomPopupMenu): Updated for WebKit API changes. (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): Updated for WebKit API changes. (WaitUntilDoneDelegate::addCustomMenuDrawingData): Updated for WebKit API changes. (WaitUntilDoneDelegate::webViewLostFocus): Updated for WebKit API changes.

5:17 PM Changeset in webkit [21424] by hyatt

2 edits in trunk/WebCore

Make sure focus rings are always using the exterior style, regardless
of what the OS default is.

Reviewed by beth

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):

5:07 PM Changeset in webkit [21423] by oliver

3 edits
2 adds in trunk

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Layout test for x-mac-roman character encoding.

fast/encoding/xmacroman-encoding-test-expected.txt: Added.
fast/encoding/xmacroman-encoding-test.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/5195473> REGRESSION: "Curly quote" fails to
be displayed correctly even when META tag specifies charset=x-mac-roman

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the xmacroman encoding

4:05 PM Changeset in webkit [21422] by ggaren

1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:59 PM Changeset in webkit [21421] by mjs

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5193517> FrameLoader::canCachePage() might walk the entire DOM
http://bugs.webkit.org/show_bug.cgi?id=13662

loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Remove some useless and now harmful code - there's no need to clear in this case.

3:44 PM Changeset in webkit [23356] by adele

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: (WebView::selectionImageRect):

3:06 PM Changeset in webkit [21420] by oliver

2 edits in trunk/WebCore

GDK Build fix

ChangeLog:
dom/Document.cpp: (WebCore::Document::importNode):

3:03 PM Changeset in webkit [21419] by mjs

2 edits in trunk/WebCore

Reviewed by Geoff.

fixed <rdar://problem/5197621> closing second window crashed webkit (13660) http://bugs.webkit.org/show_bug.cgi?id=13660

No test case; not testable.

page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): Check if the interpreter is null; if so, we don't want to do work that may lazily create it while the Frame is being destroyed.

2:54 PM Changeset in webkit [21418] by oliver

5 edits
11 adds in trunk

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Brady.

Layout tests for <rdar://problem/5017375> WebKit should disable SVG in Dashboard
Tests attempt to use SVG in a number of ways, both direct and indirect.

http/tests/xmlhttprequest/resources/svgtest.svg: Added. Small test SVG

http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Added.
http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html: Added. Attempts to use an SVG doc created with XHR as content

svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/embedded-svg-disallowed-in-dashboard.xml: Added. Attempts to use SVG by embedding it in an SVG doc.

svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html: Added. Attempts to use SVG by using a DOMParser to manually parse XHMTL with embedded SVG

svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/manually-parsed-svg-disallowed-in-dashboard.html: Added. Attempts to use SVG by using a DOMParser to manually create an SVG doc from a string

svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Added.
svg/custom/svg-disallowed-in-dashboard-object.html: Added. Attempts to embed SVG with <embed>, <object>, and <iframe>

WebCore:

Reviewed by Brady.

<rdar://problem/5017375> WebKit should disable SVG in Dashboard

Prevents an SVG document or element from being created when in
dashboard compatibility mode.

Manually parsing, or using XHR to created a document removes our
ability to detect Dashboard compatibility mode, so we also perform
the check when importing nodes from one document into another.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Don't create an SVGDocument if we're in dashboard compatibility mode

dom/Document.cpp: (WebCore::Document::importNode): Don't import SVG nodes if we're in dashboard compatibility mode

ksvg2/scripts/make_names.pl: Don't create SVG elements for documents that are in dashboard compatibility mode

1:44 PM Changeset in webkit [21417] by bdash

2 edits in trunk/LayoutTests

2007-05-11 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Oliver.

fast/encoding/char-encoding.html: Change from a 5 millisecond timeout to a 500 millisecond timeout to work around occasional timing-related test failures.

1:29 PM Changeset in webkit [21416] by bdash

2 edits in trunk/WebKitTools

2007-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Bug 13656: [gdk] Resize the drawing area of the GdkLauncher
http://bugs.webkit.org/show_bug.cgi?id=13656

GdkLauncher/main.cpp: Handle resizing the drawing area (frameResizeCallback): (main):

1:27 PM Changeset in webkit [21415] by bdash

3 edits in trunk/WebCore

2007-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Bug 13676: [cairo/gdk] Provide implementation for ImageBufferCairo
http://bugs.webkit.org/show_bug.cgi?id=13676

There are no test cases that explicitly cover platform/graphics at present.

platform/graphics/ImageBuffer.h: Add cairo bits
platform/graphics/cairo/ImageBufferCairo.cpp: Untested implementation of the ImagerBuffer using the image_surface (WebCore::ImageBuffer::create): Create a reasonable sized surface (WebCore::ImageBuffer::ImageBuffer): Use a cairo_surface and create a GraphicsContext. GraphicsContext takes the cairo_t ownership (WebCore::ImageBuffer::~ImageBuffer): Unref the surface (WebCore::ImageBuffer::context): simply return the GraphicsContext, it should be possible to directly draw on it.

1:12 PM Changeset in webkit [21414] by bdash

2 edits in trunk/WebCore

2007-05-11 Mitz Pettel <mitz@webkit.org>

Release build fix.

platform/mac/ShapeArabic.c: (shapeArabic):

12:43 PM Changeset in webkit [21413] by ggaren

7 edits in trunk

LayoutTests:

Reviewed by Darin Adler.

Updated test a little bit now that +[WebScriptObject scriptObjectForJSObject:frame:]
is gone.

fast/dom/wrapper-round-tripping.html:

WebCore:

Reviewed by Darin Adler.

Removed +[WebScriptObject scriptObjectForJSObject:frame:] because the
WebScriptObject API has some serious limitations that make it not ready
to be used everywhere the C API is used. Hopefully we can add a good
ObjC API in the future that doesn't suffer from this problem.

Preliminary notes about these limitations are in <rdar://problem/4876466>.

bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPendingPublic.h:

WebKitTools:

Reviewed by Darin Adler.

Updated test now that +[WebScriptObject scriptObjectForJSObject:frame:]
is gone.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController testWrapperRoundTripping:]):

12:04 PM Changeset in webkit [21412] by brmorris

7 edits in S60/trunk

joe, reviewed by brad

DESC: new stub for CancelResetEntryPositionL

group/Bwinscw/HistoryProvider_sdkU.def:
inc/HistoryController.h:
src/HistoryController.cpp: (CHistoryController::CancelResetEntryPositionL):

11:26 AM Changeset in webkit [21411] by beidson

1 edit in trunk/WebCore/platform/mac/ShapeArabic.c

Build fix for case-sensitve file systems (which you should all be using!!!)

9:49 AM Changeset in webkit [21410] by bdash

6 edits
3 adds in trunk

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13635 REGRESSION: Cannot log in to webmail.co.za account

Test: fast/dom/HTMLOptionElement/option-text.html

Despite the specification that the 'text' attribute of HTMLOptionElement
is "the text contained within the option element", other browsers return
the text as displayed in the list box or popup, which is without leading,
trailing and collapsible whitespace.

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text): Moved the code to trim and collapse whitespace and replace backslashes with the currency symbol into this function. (WebCore::HTMLOptionElement::optionText): Left only the code that adds the leading spaces for grouped options. Removed code that, in quirks mode, displayed the label if the option element contained no text. That behavior did not match WinIE and the description of the expected behavior in fast/forms/HTMLOptionElement_label06.html.

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13635 REGRESSION: Cannot log in to webmail.co.za account

fast/dom/HTMLOptionElement/option-text-expected.txt: Added.
fast/dom/HTMLOptionElement/option-text.html: Added.
fast/forms/HTMLOptionElement_label06-expected.checksum:
fast/forms/HTMLOptionElement_label06-expected.png:
fast/forms/HTMLOptionElement_label06-expected.txt:

9:45 AM Changeset in webkit [21409] by bdash

3 edits
3 adds in trunk

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fix for bug http://bugs.webkit.org/show_bug.cgi?id=13620 Bogus decompilation of "for (var j = 1 in [])"
ForInNode toString()'ed to syntax error if there was var decl and initializer
ForNode toStringed()'ed lost 'var ' if it was present

kjs/nodes2string.cpp: (VarDeclListNode::streamTo): Print "var " here (VarStatementNode::streamTo): Don't print "var " here (ForNode::streamTo): Remove TODO comment, VarDeclListNode will stream the "var " (ForInNode::streamTo): ForIn initializer is printed by VarDeclNode

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for bug http://bugs.webkit.org/show_bug.cgi?id=13620 Bogus decompilation of "for (var j = 1 in [])"

Testcase covers toString()ing functions with
for-statements of form for (var j = 1 in []) and for (var j=0;j<10;j++)

fast/js/resources/toString-for-var-decl.js: Added.
fast/js/toString-for-var-decl-expected.txt: Added.
fast/js/toString-for-var-decl.html: Added.

9:25 AM Changeset in webkit [21408] by bdash

3 edits
2 adds in trunk/WebCore

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13572 Arabic characters are not correctly joined when using Arial

No tests added because standard fonts do not use the character-based shaping
code path.

Added shapeArabic(), a private version of u_shapeArabic() from ICU,
patched to shape Arabic characters used in Persian, Urdu, Sindhi, etc.
(whose contextual forms belong to the Arabic Presentation Forms-A block).

WebCore.xcodeproj/project.pbxproj: Added ShapeArabic.{c,h}.
platform/mac/FontMac.mm: (WebCore::shapeArabic): Changed to call shapeArabic() instead of u_shapeArabic().
platform/mac/ShapeArabic.c: Added. Based on ushape.c from ICU, with additional shaping data and logic for Arabic Presentation Forms-A. Removed many options that are not used in WebKit and code that malloc()ed a temporary buffer and reversed the string. (changeLamAlef): (specialChar): (getLink): (isTashkeelChar): (shapeUnicode): (shapeArabic):
platform/mac/ShapeArabic.h: Added.

9:17 AM Changeset in webkit [21407] by bdash

1 edit
3 adds in trunk/LayoutTests

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

fast/js/resources/toString-number-dot-expr.js: Added.
fast/js/toString-number-dot-expr-expected.txt: Added.
fast/js/toString-number-dot-expr.html: Added.

9:15 AM Changeset in webkit [21406] by bdash

2 edits in trunk/JavaScriptCore

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=10878 (Incorrect decompilation for "4..x")
Group numbers in dotted expressions in toString() output, so we avoid the 4.x constructs when the original input is 4..x. 4..x means the same as 4. .x or (4).x or Number(4).x

kjs/nodes2string.cpp: (KJS::SourceStream::): Add boolean flag to indicate that if next item is a number, it should be grouped. Add new formatting enum which turns on the boolean flag. (KJS::SourceStream::SourceStream): Added. Initialize the flag. (SourceStream::operator<<): Added. New overloaded operator with double value as parameter. (NumberNode::streamTo): Use the double operator (ArrayNode::streamTo): (DotAccessorNode::streamTo): (FunctionCallDotNode::streamTo): (FunctionCallParenDotNode::streamTo): (PostfixDotNode::streamTo): (DeleteDotNode::streamTo): (PrefixDotNode::streamTo): (AssignDotNode::streamTo): Use the new formatting enum to turn on the grouping flag.

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

fast/js/resources/toString-number-dot-expr.js: Added.
fast/js/toString-number-dot-expr-expected.txt: Added.
fast/js/toString-number-dot-expr.html: Added.

8:56 AM Changeset in webkit [23355] by darin

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.

8:47 AM Changeset in webkit [21405] by darin

12 edits
16 adds in trunk

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=7452 <rdar://problem/3211749> line breaks ignored after <wbr> in <pre> block (affects livejournal.com)

fast/text/wbr-pre-expected.checksum: Added.
fast/text/wbr-pre-expected.png: Added.
fast/text/wbr-pre-expected.txt: Added.
fast/text/wbr-pre.html: Added.

test for http://bugs.webkit.org/show_bug.cgi?id=10657 <rdar://problem/4274588> <wbr> tags are ignored

fast/text/wbr-expected.checksum: Added.
fast/text/wbr-expected.png: Added.
fast/text/wbr-expected.txt: Added.
fast/text/wbr.html: Added.

test for http://bugs.webkit.org/show_bug.cgi?id=12689 <wbr> :before/:after content causes line break

fast/css-generated-content/wbr-with-before-content-expected.checksum: Added.
fast/css-generated-content/wbr-with-before-content-expected.png: Added.
fast/css-generated-content/wbr-with-before-content-expected.txt: Added.
fast/css-generated-content/wbr-with-before-content.html: Added.

test for <rdar://problem/5127366> DOM tree isn't correct when parsing with <wbr>

fast/invalid/021-expected.txt: Updated result.
fast/parser/parse-wbr-expected.txt: Added.
fast/parser/parse-wbr.html: Added.

WebCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=7452 <rdar://problem/3211749> line breaks ignored after <wbr> in <pre> block (affects livejournal.com)

fix http://bugs.webkit.org/show_bug.cgi?id=10657 <rdar://problem/4274588> <wbr> tags are ignored

fix http://bugs.webkit.org/show_bug.cgi?id=12689 <wbr> :before/:after content causes line break

fix <rdar://problem/5127366> DOM tree isn't correct when parsing with <wbr>

Test: fast/text/wbr-pre.html
Test: fast/text/wbr.html
Test: fast/css-generated-content/wbr-with-before-content.html
Test: fast/parser/parse-wbr.html

html/HTMLElement.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): Use the same end tag requirement for a <wbr> element as for a <br> element, TagStatusForbidden. (WebCore::HTMLElement::tagPriority): Use the same priority for a <wbr> element as for a <br> element, 0. (WebCore::HTMLElement::createRenderer): Added. Create a RenderWordBreak to trigger the new rendering code paths.

rendering/RenderFlow.h: Add a virtual isWordBreak so we can detect RenderWordBreak.

rendering/RenderWordBreak.h: Added.
rendering/RenderWordBreak.cpp: Added.

WebCore.pro: Added new files.
WebCore.xcodeproj/project.pbxproj: Added new files.
WebCoreSources.bkl: Added new files.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Reset the line when we hit a <wbr>.
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Add a line break when we hit a <wbr>.

dom/Node.cpp: (Node::createRendererIfNeeded): Fix a null check for the case where createRenderer returns 0 even though rendererIsNeeded returned true. I can't reproduce it on demand, but while running layout tests I hit this once. Since there was already a null check here, I rearranged it so it guards all the code that uses the renderer. Later we might want to figure out under exactly what circumstances rendererIsNeeded will return true but createRenderer return 0 and consider eliminating them.

8:09 AM Changeset in webkit [21404] by zbujtas

6 edits in S60/trunk

2007-05-11 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
DESC: disabled widgets should not get activated. add dimmed checkbox and radiobutton.
http://bugs.webkit.org/show_bug.cgi?id=13678

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor): (CWebCoreBridge::NodeTypeB):
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

8:02 AM Changeset in webkit [21403] by zbujtas

6 edits in S60/branches/3.1m

2007-05-11 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
DESC: disabled widgets should not get activated. add dimmed checkbox and radiobutton.
http://bugs.webkit.org/show_bug.cgi?id=13678

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor): (CWebCoreBridge::NodeTypeB):
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

7:37 AM Changeset in webkit [21402] by yongjzha

2 edits in S60/trunk/WebKit

raalexan, <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Browser back goes to the beginning of the previous page
http://bugs.webkit.org/show_bug.cgi?id=13394
TSW ID : TMCN-6YDJDU

BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

7:11 AM Changeset in webkit [21401] by yongjzha

3 edits in S60/trunk/WebKit

2007-05-09 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjun.
DESC: EAMO-6YSHHQ - Fonts overlap in browser
http://bugs.webkit.org/show_bug.cgi?id=13647

BrowserCore/Renderers/inc/TextRendererFactory.h: (CTextRendererFactory::Apac):
BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::LineSpacing):

7:08 AM Changeset in webkit [21400] by yongjzha

3 edits in S60/branches/3.1m/WebKit

2007-05-09 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjun.
DESC: EAMO-6YSHHQ - Fonts overlap in browser
http://bugs.webkit.org/show_bug.cgi?id=13647

BrowserCore/Renderers/inc/TextRendererFactory.h: (CTextRendererFactory::Apac):
BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::LineSpacing):

3:04 AM Changeset in webkit [21399] by bdash

3 edits
3 deletes in trunk

Roll out r21393 due to the JavaScriptCore test failure it introduced.

2:41 AM Changeset in webkit [21398] by hyatt

8 edits in trunk/LayoutTests/fast/inline

Tweak continuation tests to make sure the no content after case is covered.

2:36 AM Changeset in webkit [21397] by hyatt

6 edits in trunk/WebCore

Fix for bug 13675, focus rings don't repaint properly on editable
continuations.

Reviewed by olliej

(WebCore::InlineFlowBox::paint):

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::continuationOutlineTable): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::paintContinuationOutlines):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect):
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::absoluteOutlineBox):

2:31 AM Changeset in webkit [21396] by hyatt

8 edits
4 adds in trunk/LayoutTests/fast/inline

Land new layout tests for continuation repainting fix.

2:27 AM Changeset in webkit [21395] by rwlbuis

4 edits in trunk/WebCore

Reviewed by Oliver.

Cleanups mostly inspired by Coverage results.

2:01 AM Changeset in webkit [21394] by bdash

4 edits in trunk

2007-05-11 Holger Freyther <freyther@kde.org>

Reviewed by Mark Rowe.

Move libcurl configuration into WebKit.pri so it will be used by GdkLauncher.

WebCore.pro:

2007-05-11 Holger Freyther <freyther@kde.org>

Reviewed by Mark Rowe.

Move libcurl configuration into WebKit.pri so it will be used by GdkLauncher,
and add ICU configuration to QMAKE_CXXFLAGS.

WebKit.pri:

1:51 AM Changeset in webkit [21393] by bdash

3 edits
3 adds in trunk

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

kjs/grammar.y: Add the comma that parser consumes in elision when the array has trailing commas.

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for fix to http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

fast/js/resources/toString-elision-trailing-comma.js: Added.
fast/js/toString-elision-trailing-comma-expected.txt: Added.
fast/js/toString-elision-trailing-comma.html: Added.

May 10, 2007:

10:36 PM Changeset in webkit [21392] by justing

1 edit in trunk/LayoutTests/editing/selection/5195166-1.html

This tests behaves differently when it isn't run by itself because
of a bug. Filed it (13673) and added a workaround.

10:17 PM Changeset in webkit [21391] by hyatt

2 edits in trunk/WebCore

<rdar://problem/5015522> Bounds rectangle of unloaded images is
drawn briefly while loading

When the image is null and has no size, don't draw the grey
rectangles or alt text any more. Wait for an actual error to
occur with the image before we start showing alt text and borders.

(Images with no source set at all will continue to show alt text and
borders immediately.)

Reviewed by bradee-oh

rendering/RenderImage.cpp: (WebCore::RenderImage::paint):

9:49 PM Changeset in webkit [21390] by thatcher

8 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

repaint test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13655 Incomplete repaint when text-shadow is used in a render layer with explicit height

fast/repaint/layer-full-repaint-expected.checksum: Added.
fast/repaint/layer-full-repaint-expected.png: Added.
fast/repaint/layer-full-repaint-expected.txt: Added.
fast/repaint/layer-full-repaint.html: Added.
fast/repaint/repaint-resized-overflow-expected.checksum:
fast/repaint/repaint-resized-overflow-expected.png:

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13655 Incomplete repaint when text-shadow is used in a render layer with explicit height

Test: fast/repaint/layer-full-repaint.html

Removed custom repaint logic from RenderLayer. repaintAfterLayoutIfNeeded()
knows how to do everything we need now. The only catch is that we cannot
rely on its "do a full repaint if the object needs layout" behavior, since
by the time we call it, the needs layout flag has been reset. The solution
is to cache the need for a full repaint in the layer.

page/FrameView.cpp: (WebCore::FrameView::layout): Removed call to checkForRepaintOnResize().
rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Removed. (WebCore::RenderLayer::RenderLayer): Replaced the m_repaintOverflowOnResize flag with a m_needsFullRepaint flag, which indicates that the layer needs to do a full repaint in the next call to updateLayerPositions(). (WebCore::RenderLayer::updateLayerPositions): Simplified the repaint logic. Either call repaintAfterLayoutIfNeeded() or do a full repaint, depending on m_needsFullRepaint.
rendering/RenderLayer.h: (WebCore::RenderLayer::setNeedsFullRepaint):
rendering/RenderObject.cpp: (WebCore::RenderObject::setNeedsLayout): Mark the layer for full repaint.

8:51 PM Changeset in webkit [21389] by justing

5 edits
8 adds in trunk

LayoutTests:

Reviewed by ggaren

<rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate

editing/selection/5195166-1-expected.checksum: Added.
editing/selection/5195166-1-expected.png: Added.
editing/selection/5195166-1-expected.txt: Added.
editing/selection/5195166-1.html: Added.
editing/selection/5195166-2-expected.checksum: Added.
editing/selection/5195166-2-expected.png: Added.
editing/selection/5195166-2-expected.txt: Added.
editing/selection/5195166-2.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate

In setModifyBias, we must cache the start and the end
because the calls to setBase and setExtent can modify
them (added a testcase).
The temporary SelectionController that we use in modify() to
produce the proposed range that will be passed to
shouldChangeSelectedDOMRange must have the same m_modifyBias
as the original SelectionController, or else when the
modification is performed, setModifyBias can swap the base
and the extent incorrectly (added a testcase).
Renamed m_modifyBias to m_lastChangeWasHorizontalExtension.
Renamed setModifyBias to willBeModified.

editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::willBeModified): (WebCore::SelectionController::modify):
editing/SelectionController.h: (WebCore::SelectionController::setLastChangeWasHorizontalExtension):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDragOverPosition):

7:09 PM Changeset in webkit [23354] by ggaren

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin Adler.

"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.

7:01 PM Changeset in webkit [21388] by ggaren

11 edits in trunk

WebCore:

Reviewed by Darin Adler.

"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness,
in the style of WebCore::cache().

WebCore.exp:
history/HistoryItem.cpp: Removed retainIconInDatabase because calling "retain" in order to release something is really confusing and, now that iconDatabase() is more terse, we don't need this helper to shorten the syntax. (The isEmpty() check is also done by the database, so we don't need it either.)

(WebCore::IconDatabase::~IconDatabase): ASSERT that our destructor isn't
called. We're a singleton, so it's confusing to have tear-down code.

WebKit:

Reviewed by Darin Adler.

"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.

5:39 PM Changeset in webkit [23353] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect

5:26 PM Changeset in webkit [21387] by adele

24 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
fast/overflow/scroll-nested-positioned-layer-in-overflow.html: Added.

WebCore:

Reviewed by Hyatt.

WebCore part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

Test: fast/overflow/scroll-nested-positioned-layer-in-overflow.html

Merged visibleSelectionRect into selectionRect. selectionRect() now takes an argument to determine
whether or not to return a rect that clips to the visible content. This change makes all of the implementations of selectionRect
consistent by having them all consider the repaint rect when clipping to visible content.

page/Frame.cpp: (WebCore::Frame::revealSelection): Call selectionRect with clipToVisibleContent = false, so we can get a rect that's not visible to reveal. (WebCore::Frame::selectionRect): Added clipToVisibleContent argument, and merged visibleSelectionRect into this method. (WebCore::Frame::setIsActive): Use selectionRect instead of visibleSelectionRect.
page/Frame.h:
page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): Update layout before creating the image. Use selectionRect instead of visibleSelectionRect.
page/DragController.cpp: (WebCore::dragLocForSelectionDrag): Use selectionRect instead of visibleSelectionRect.

rendering/RenderBR.h: (WebCore::RenderBR::selectionRect): Updated argument.
rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRect): ditto.
rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRect): ditto.
rendering/RenderSVGInlineText.h: ditto.
rendering/RenderObject.h: (WebCore::RenderObject::selectionRect): ditto. (WebCore::RenderObject::SelectionInfo::SelectionInfo): ditto.
rendering/RenderView.cpp: (WebCore::RenderView::selectionRect): ditto. (WebCore::RenderView::setSelection): ditto.
rendering/RenderView.h:

rendering/RenderText.h:
rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Only call computeAbsoluteRepaintRect when clipping to visible content. Otherwise, just adjust the rect to the correct position.
rendering/RenderListMarker.h:
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect): To match what we do in RenderText, if we're trying to clip to visible content, just call computeAbsoluteRepaintRect.
rendering/RenderReplaced.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): ditto.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Check for a parent layer at the beginning, so we can try to scroll all of our parent layers first, before trying to scroll the top level view. Also, don't try to scroll overflow layers that have -webkit-line-clamp restricting the height. This will prevent us from revealing text hidden by the slider in Safari RSS.

WebCore.exp: Update symbols for WebKit.

WebKit:

Reviewed by Hyatt.

WebKit part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

Updated to use selectionRect instead of visibleSelectionRect. selectionRect() now returns the visible rect by default.

WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView selectionImageRect]):

4:10 PM Changeset in webkit [21386] by hyatt

2 edits in trunk/LayoutTests/fast/inline

Land updated continuations outline test.

3:59 PM Changeset in webkit [21385] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/5195272> REGRESSION: broke outline rings for continuations
with empty inline containers

http://bugs.webkit.org/show_bug.cgi?id=13667

Make sure to only include collapsed top/bottom margins of the block portion
of the continuation if we know for sure that we have inline line boxes before
and after that would prevent the collapse from going further.

In plain English: the focus rings were too tall. :)

Reviewed by beth

rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):

3:08 PM Changeset in webkit [21384] by hyatt

1 edit in trunk/WebCore/rendering/RenderText.cpp

Back out tweak to add PRE_LINE. Was not part of bug fix and is actually wrong.

3:07 PM Changeset in webkit [21383] by hyatt

155 edits
4 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for pre-wrap minwidth when a newline is present.

3:02 PM Changeset in webkit [21382] by spadma

6 edits in S60/trunk/WebKit

naguo, reviewed by sachin

DESC: BrowserNG - Find phonenumber doesn't make a call
http://bugs.webkit.org/show_bug.cgi?id=13614

TSW ID : ISHG-6YFNME

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
BrowserView/inc/SmartLinkHandler.h:
BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::HandleMakeCallL):
group/webkit.mmp:

2:55 PM Changeset in webkit [21381] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/5067235> REGRESSION: Excessively wide table, impossible to resize

The table used white-space: pre-wrap, which is supported only by WebKit. There
was a bug with the computation of min pref width for pre-wrap text.

Reviewed by mitzpettel

fast/text/white-space/pre-wrap-line-test.html

rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths):

2:37 PM Changeset in webkit [21380] by beidson

5 edits in trunk/WebCore

Reviewed by Oliver

Cleanup from my earlier Java Applet patch. We should keep a central location to query if
a mime type counts as a Java Applet

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet): Query MimeTypeRegistry on the type

platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): Update style (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): Ditto (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): Ditto (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Perform the Java Applet check
platform/MimeTypeRegistry.h:

rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Query MimeTypeRegistry on the type

1:58 PM Changeset in webkit [21379] by spadma

2 edits in S60/trunk/WebKit

2007-05-09 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Added a CancelResetEntryPositionL to the history provider to handle cancelled requests
http://bugs.webkit.org/show_bug.cgi?id=13651

BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL):

1:58 PM Changeset in webkit [21378] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-05-09 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Added a CancelResetEntryPositionL to the history provider to handle cancelled requests
http://bugs.webkit.org/show_bug.cgi?id=13651

BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL):

12:17 PM Changeset in webkit [21377] by bdakin

2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/5191941> Leopard: Adobe Acrobat 8:
Distiller 8 needs same check fix as 4992521

WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]): Adobe Distiller needs the same quirk.

11:57 AM Changeset in webkit [21376] by pyeh

3 adds in trunk/LayoutTests/editing/selection

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines
Add expected result for move-by-sentence-linebreak test case.

11:54 AM Changeset in webkit [21375] by pyeh

1 add in trunk/LayoutTests/editing/selection/move-by-sentence-linebreak.html

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines
Add a testcase to exercise moving insertion point forward by sentence across lines of text that
includes empty lines.

11:50 AM Changeset in webkit [21374] by pyeh

3 edits in trunk/WebCore

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): When a marker position is given, the sentence ax methods automatically shift position by one to make sure not to ask for the current sentence again. This is generally fine except when the position shift over an empty line break, which is should be considered a separate sentence. In this case, if we used the shifted position to ask for sentence boundary, ICU parser is not given the text data containing the newline to correctly determine the sentence boundary. Since the ax sentence method is explicitly shifting the position to ask for sentence boundary, it should make sure not to skip over important character that can be a standalone sentence.
editing/visible_units.cpp: (WebCore::nextBoundary): When determining boundary, don't stop on a collapsed range, such as newline. Just pick the next valid position to use as boundary.

7:54 AM Changeset in webkit [21373] by zbujtas

3 edits in S60/trunk/JavaScriptCore

2007-05-09 bujtas <zbujtas@gmail.com>

Reviewed by Sriram
DESC: stack overflow while destroying a huge array. remove ElementNode recursive destruction.
http://bugs.webkit.org/show_bug.cgi?id=13649

kjs/nodes.cpp: (ElementNode::~ElementNode):
kjs/nodes.h:

7:42 AM Changeset in webkit [21372] by zbujtas

3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-09 bujtas <zbujtas@gmail.com>

Reviewed by Sriram
DESC: stack overflow while destroying a huge array. remove ElementNode recursive destruction.
http://bugs.webkit.org/show_bug.cgi?id=13649

kjs/nodes.cpp: (ElementNode::~ElementNode):
kjs/nodes.h:

7:36 AM Changeset in webkit [21371] by lars

2 edits in trunk/JavaScriptCore

Reviewed by Zack

Fix our last three test failures in the JavaScript
tests.

Without change 21367 we would have been at 0 failures
in javascript and layout tests now... ;-)

7:16 AM Changeset in webkit [21370] by spadma

3 edits in S60/branches/3.1m/WebKit

vbradley, reviewed by Zalan

DESC: MLIO-6ZGAN6 - Browser doesn't update loading status
http://bugs.webkit.org/show_bug.cgi?id=13346

BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::ProgressCompleted): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::IncrementProgressForLoadComplete): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ProgressUpdate):

7:16 AM Changeset in webkit [21369] by spadma

3 edits in S60/trunk/WebKit

vbradley, reviewed by Zalan

DESC: MLIO-6ZGAN6 - Browser doesn't update loading status
http://bugs.webkit.org/show_bug.cgi?id=13346

BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::ProgressCompleted): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::IncrementProgressForLoadComplete): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ProgressUpdate):

5:48 AM Changeset in webkit [21368] by eseidel

3 edits
4 adds in branches/feature-branch

2007-05-10 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

http://bugs.webkit.org/show_bug.cgi?id=11931
PathCG fails to hit on unclosed sub-paths

Test: svg/custom/hit-test-unclosed-subpaths.svg

platform/graphics/cg/PathCG.cpp: (WebCore::copyClosingSubpathsApplierFunction): (WebCore::copyCGPathClosingSubpaths): (WebCore::Path::contains): use new copy & close function

5:31 AM Changeset in webkit [21367] by mjs

41 edits
4 adds in trunk

LayoutTests:

Reviewed by Oliver.

new test case for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

(The test case covers both scenarios.)

http/tests/misc/frame-access-during-load-expected.checksum: Added.
http/tests/misc/frame-access-during-load-expected.png: Added.
http/tests/misc/frame-access-during-load-expected.txt: Added.
http/tests/misc/frame-access-during-load.html: Added.

test results beneficially or harmlessly changed as a result of the above fixes

css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
css2.1/t0801-c412-hz-box-00-b-a-expected.png:
css2.1/t0801-c412-hz-box-00-b-a-expected.txt: This reflects an <object> containing an image now creating an image renderer.

dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: This is updated to a slightly less bad failure for access to a frame that's not loaded yet.

The following test results now reflect the frame removal that the test was testing:

fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum:
fast/dom/clientWidthAfterDocumentIsRemoved-expected.png:
fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
fast/dom/replaceChild-expected.checksum:
fast/dom/replaceChild-expected.png:
fast/dom/replaceChild-expected.txt:

The following tests results now reflect empty document content for iframes that never load anything:

fast/events/focusingUnloadedFrame-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:

WebCore:

Reviewed by Oliver.

WebCore part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.

However, this caused many regressions so I had to fix the fallout.

WebCore.exp: fix symbol exports
bindings/js/kjs_window.cpp: (KJS::createNewWindow): useless "created" bool (we don't need it here) (KJS::WindowFunc::callAsFunction): detect if we created a new frame, because if so, we need to initialize the domain (can't count on it not having a document), also don't try to make a new document for it. Also, stop properly.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): don't count on document having a view here
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Ask client, to match how other <object> renderer decisions are made.
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Initialize new data members (WebCore::FrameLoader::init): Do the slightly tricky sequence of steps to properly make an empty document with everything hooked up. (WebCore::FrameLoader::createWindow): Added "created" bool. (WebCore::FrameLoader::stopLoading): (whitespace change) (WebCore::FrameLoader::begin): Don't try to create an empty document. (WebCore::FrameLoader::finishedParsing): If creating an initial empty document, don't do any of this work. (WebCore::FrameLoader::checkCompleted): Do checkLoadComplete() as well. (WebCore::FrameLoader::baseURL): don't check for null document (WebCore::FrameLoader::baseTarget): ditto (WebCore::FrameLoader::completeURL): ditto (WebCore::FrameLoader::didTellBridgeAboutLoad): ditto (WebCore::FrameLoader::scheduleLocationChange): determine duringLoad differently; doc won't be null. (WebCore::FrameLoader::gotoAnchor): don't check for null document (WebCore::FrameLoader::canTarget): don't check for null document (WebCore::FrameLoader::stopForUserCancel): new method for explicit stops like window.stop(). (WebCore::FrameLoader::transitionToCommitted): check for pre-loaded state properly (WebCore::FrameLoader::createEmptyDocument): removed (WebCore::FrameLoader::checkLoadCompleteForThisFrame): don't send delegate callbacks when making initial doc. (WebCore::FrameLoader::tokenizerProcessedData): Assume document; just checkCompleted now that it does checkLoadComplete. (WebCore::FrameLoader::receivedMainResourceError): assume document (WebCore::FrameLoader::saveDocumentState): Assume there's a document except during initial load (WebCore::FrameLoader::mainReceivedCompleteError): do checkCompleted, not checkLoadComplete (WebCore::FrameLoader::continueLoadWithData): assume document
loader/FrameLoader.h:
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Add more ref protection and do things in a slightly different order.
page/DOMWindow.cpp: (WebCore::DOMWindow::document): don't force document creation, just assert there is one.
page/Frame.cpp: (WebCore::Frame::init): Added init method. (WebCore::Frame::pageDestroyed): when a frame is removed, make sure to check if the parent is done loading.
page/Frame.h:
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): No need to force document. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): ditto
platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): init the frame
rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition): If a subframe needs layout, then lay it out even if the bounds did not change; the content size might be wrong.
rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Don't crash if the frame lacks a view.

WebKit:

Reviewed by Oliver.

WebKit part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.

However, this caused many regressions so I had to fix the fallout.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::takeFocus): Avoid focus cycle problems (can happen in DumpRenderTree with initial empty document now).
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): init the frame. (-[WebFrameBridge determineObjectFromMIMEType:URL:]): return image type when appropriate
WebView/WebFrame.mm: (-[WebFrame stopLoading]): use stopForUserCancel().
WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): assume html when no mime type available.
WebView/WebView.mm: (-[WebView becomeFirstResponder]): Track whether we are becoming first responder from outside the view. (-[WebView _becomingFirstResponderFromOutside]): Return this value.
WebView/WebViewInternal.h:

WebKitTools:

Reviewed by Oliver.

don't clear events whenever an EventSendingController goes away, only do it at predictable times, since destroying a subframe can make one go away

(Discovered while fixing:

<rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
<rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

DumpRenderTree/DumpRenderTree.m: (runTest): explicitly clear saved events after every page load
DumpRenderTree/EventSendingController.h:
DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): don't clear saved events here... (+[EventSendingController clearSavedEvents]): do it here
Scripts/check-for-global-initializers:

5:08 AM Changeset in webkit [21366] by hyatt

4 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for 13654.

5:08 AM Changeset in webkit [23352] by mjs

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

WebKitWin part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.

However, this caused many regressions so I had to fix the fallout.

WebFrame.cpp: (WebFrame::createFrame): init frame
WebView.cpp: (WebView::initWithFrame): init frame (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document

5:06 AM Changeset in webkit [21365] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/5146757> REGRESSION: div that wrapped to screen width in
tiger no longer wraps

http://bugs.webkit.org/show_bug.cgi?id=13654

Reviewed by mitz

fast/text/whitespace/normal-after-nowrap-breaking.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):

3:48 AM Changeset in webkit [21364] by bdash

2 edits in trunk/WebKitTools

2007-05-10 Mark Rowe <mrowe@apple.com>

Build fix for DumpRenderTree. Enable Objective-C exceptions in Release configuration.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

3:14 AM Changeset in webkit [21363] by hyatt

3 edits in trunk/WebCore

Fix for:

<rdar://problem/4778099> Links with nested continuations fail to
paint their outlines (11255)

http://bugs.webkit.org/show_bug.cgi?id=11255

Fix multiple bugs with outline painting of continuations to ensure that
all combos work (empty/full inline - block with/without margins -
empty/full inline).

Reviewed by mitz

fast/inline/continuation-outlines.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):

3:13 AM Changeset in webkit [21362] by hyatt

4 adds in trunk/LayoutTests/fast/inline

Add continuation outline drawing test.

2:29 AM Changeset in webkit [21361] by hyatt

4 adds in trunk/LayoutTests/fast/overflow

Add layout test to cover RTL overflow issue.

2:28 AM Changeset in webkit [21360] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/5193529> REGRESSION: RTL Overflows scrollbar not showing
when they should be

Fallout from fix for bug 11926. Make sure to restrict the fix to the
RenderView for now, since the full-blown overflow case is pretty involved.

Reviewed by mitzpettel

fast/overflow/unreachable-content-bug-rtl.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):

1:55 AM Changeset in webkit [21359] by beidson

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver

Fix for http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>

When creating the applets collection, be sure to only count Objects if they contain
a java applet

dom/html/level2/html/AppletsCollection-expected.txt: Added.
dom/html/level2/html/AppletsCollection.html: Added.

WebCore:

Reviewed by Oliver

Fix for http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>

When creating the applets collection, be sure to only count Objects if they contain
a java applet

html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem): Add the qualifier for Objects that containsJavaApplet() must be true

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet): Check this Object element and inner nodes for any Java applets
html/HTMLObjectElement.h:

1:52 AM Changeset in webkit [21358] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/4694859> SAP: HTML tags with overflow:hidden consume
space on page, do not consume space in Firefox (11926)

http://bugs.webkit.org/show_bug.cgi?id=11926

Make sure that unreachable objects along one axis (e.g., top/left) do not
contribute to the scrollable area in the opposite axis (e.g., right/bottom).

Reviewed by olliej

fast/overflow/unreachable-content-test.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):

1:50 AM Changeset in webkit [21357] by hyatt

4 adds in trunk/LayoutTests/fast/overflow

Add layout test for bug 11926.

1:09 AM Changeset in webkit [21356] by hyatt

150 edits
4 adds in trunk/LayoutTests/fast/text

Add layout test for opacity/letter-spacing bug.

1:09 AM Changeset in webkit [21355] by hyatt

2 edits in trunk/WebCore

Fix for:

<rdar://problem/4656825> REGRESSION: Japanese TV time table widget:
part of the number in background has been cut off.

Now that opacity uses a tight bounding box to clip, we need to make sure
to factor spillout caused by negative letter spacing into our right
overflow. Latch on to the code that does this already for text-stroke
and text-shadow.

Reviewed by olliej

fast/text/letter-spacing-negative-opacity.html

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):

1:00 AM Changeset in webkit [21354] by ggaren

11 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.

Tests for more fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html: Added cases to test the wrapper classes for different data types sent across the JS/ObjC bridge.
fast/dom/wrapper-round-tripping-expected.txt: Added.
fast/dom/wrapper-round-tripping.html: Added. New test to verify that you can round-trip between a JSObjectRef and a WebScriptObject.

WebCore:

Reviewed by Maciej Stachowiak.

More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

bindings/objc/WebScriptObject.h: Fully specified the surprising rules for type conversion between JavaScript and ObjC.
bindings/objc/WebScriptObject.mm: Added up-call accessor to WebFrame. This is kind of stinky, but I'm OK with it because eventually all of this code should move up into WebKit. (+[WebScriptObject scriptObjectForJSObject:frame:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject JSObject]):
- Added _rootObject check because if _rootObject returns NULL it means that _imp is no longer GC protected, so it's not safe to use.
- Added _isSafeScript check because that's what WebScriptObject methods typically do, even though the value of doing so isn't clear to me.
bindings/objc/WebScriptObjectPendingPublic.h: Added WebFrame* parameter to -scriptObjectForJSObject:. This is required to wrap JS objects that are not already in the wrapper cache. It would be nice to remove this limitation of WebScriptObject some day.
page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): Force removal of m_windowScriptObject from the cache, to avoid retrieving the m_windowScriptObject from the previous page on a new page load. (It would be non-functional in that case.)

WebKitTools:

Reviewed by Maciej Stachowiak.

Added support for testing ObjC/JS type bridging.

Added ASSERT that -JSObject returns nil when the underlying JSObject
is no longer GC protected.

DumpRenderTree/DumpRenderTree.m: (returnThisCallback): (returnThisClass): (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController testWrapperRoundTripping]): (-[LayoutTestController objCClassNameOf:]): (-[LayoutTestController objCObjectOfClass:]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

12:50 AM Changeset in webkit [21353] by lars