Timeline
Nov 11, 2007:
- 10:44 PM Changeset in webkit [27710] by
-
- 4 edits in trunk/JavaScriptCore
Fix <rdar://5578982> ASSERT in HashTable::checkTableConsistencyExceptSize beneath WebNotificationCenter
The bug was due to a mismatch between HashMap::remove and
HashTable::checkTableConsistency. HashMap::remove can delete the value
stored in the HashTable (by derefing it), which is not normally
allowed by HashTable. It's OK in this case because the value is about
to be removed from the table, but HashTable wasn't aware of this.
HashMap::remove now performs the consistency check itself before
derefing the value.
Darin noticed that the same bug would occur in HashSet, so I've fixed
it there as well.
Reviewed by Darin.
- wtf/HashMap.h: (WTF::HashMap::remove): Perform the HashTable consistency check manually before calling deref.
- wtf/HashSet.h: (WTF::HashSet::remove): Ditto.
- wtf/HashTable.h: Made checkTableConsistency public so that HashMap and HashSet can call it. (WTF::HashTable::removeAndInvalidateWithoutEntryConsistencyCheck): Added. (WTF::HashTable::removeAndInvalidate): Added. (WTF::HashTable::remove): (WTF::HashTable::removeWithoutEntryConsistencyCheck): Added.
- 10:16 PM Changeset in webkit [27709] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r27708 as it breaks the Mac PowerPC build.
- 10:00 PM Changeset in webkit [27708] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-11 Mike Hommey <mh+webkit@glandium.org>
Reviewed by Maciej.
Fix http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock): Change constraint from o to m.
- 9:54 PM Changeset in webkit [27707] by
-
- 5 edits in trunk/WebCore
2007-11-11 Justin Haygood <jhaygood@reaktix.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15939
Adds a currentThread API for use by SQLiteDatabase, etc.
- platform/Threading.h:
- platform/ThreadingNone.cpp: (WebCore::currentThread):
- platform/gtk/ThreadingGtk.cpp: (WebCore::identifierByGthreadHandle): (WebCore::):
- platform/pthreads/ThreadingPthreads.cpp: (WebCore::identifierByPthreadHandle): (WebCore::currentThread):
- 9:40 PM Changeset in webkit [27706] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=15942 REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
Test: editing/selection/cleared-by-relayout.html
- editing/Selection.cpp: (WebCore::Selection::toRange): Check if the selection has been cleared by updating layout.
LayoutTests:
Reviewed by Adam Roben.
- test for http://bugs.webkit.org/show_bug.cgi?id=15942 REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
- editing/selection/cleared-by-relayout-expected.txt: Added.
- editing/selection/cleared-by-relayout.html: Added.
- 8:51 PM Changeset in webkit [27705] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix line numbers that were off since my recent patch
- platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): Reversed the sense of m_excludeLineNumbers and rename it to m_doNotExcludeLineNumbers. (WebCore::SegmentedSubstring::excludeLineNumbers): Updated. (WebCore::SegmentedSubstring::doNotExcludeLineNumbers): Added. (WebCore::SegmentedSubstring::setExcludeLineNumbers): Updated. (WebCore::SegmentedString::advance): Use doNotExcludeLineNumbers to reverse the sense and fix the regression, but keep the speediness. I accidentally had removed a ! here.
- platform/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase): Use doNotExcludeLineNumbers.
- 8:48 PM Changeset in webkit [27704] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/5585334>
Reviewed by Darin.
Fix for <rdar://problem/5585334> numfuzz: integer overflows opening
malformed SVG file in WebCore::ImageBuffer::create. Add protection
against a potential overflow.
- 8:37 PM Changeset in webkit [27703] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-11 Mark Rowe <mrowe@apple.com>
Build fix. Use the correct filename case.
- kjs/nodes.h:
- 8:27 PM Changeset in webkit [27702] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15902
15% of string-validate-input.js is spent compiling the same regular expression
Store a compiled representation of the regular expression in the AST.
Only a .2% SunSpider speedup overall, but a 10.6% speedup on
string-validate-input.js.
- kjs/nodes.cpp: (KJS::RegExpNode::evaluate):
- kjs/nodes.h: (KJS::RegExpNode::):
- kjs/nodes2string.cpp: (KJS::RegExpNode::streamTo):
- kjs/regexp.cpp: (KJS::RegExp::flags):
- kjs/regexp.h: (KJS::RegExp::pattern):
- kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): (KJS::RegExpObjectImp::createRegExpImp):
- kjs/regexp_object.h:
- 8:26 PM Changeset in webkit [27701] by
-
- 11 edits in trunk/WebCore
Reviewed by Darin.
Fix a bunch of cases where the exception code is checked by the function but is not zeroed first.
- bindings/js/kjs_binding.cpp: (KJS::setDOMException):
- dom/Attr.cpp: (WebCore::Attr::setPrefix):
- dom/Document.cpp: (WebCore::Document::createElement):
- dom/Element.cpp: (WebCore::Element::setPrefix):
- dom/Range.cpp: (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::deleteContents): (WebCore::Range::processContents): (WebCore::Range::extractContents): (WebCore::Range::insertNode): (WebCore::Range::setStartAfter): (WebCore::Range::setEndBefore): (WebCore::Range::setEndAfter): (WebCore::Range::selectNode): (WebCore::Range::surroundContents): (WebCore::Range::setStartBefore):
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::setOption):
- xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::evaluate):
- 8:14 PM Changeset in webkit [27700] by
-
- 3 edits in trunk/WebCore
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15945 speed up GraphicsContextCG typical case by skipping roundToDevicePixels
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::restorePlatformState): Clear the flag since we no longer know if the transform is identity or not. (WebCore::GraphicsContext::strokeArc): Removed an extra set of redundant CGContextSave/RestoreGState. (WebCore::GraphicsContext::beginTransparencyLayer): Clear the flag since we no longer know if the transform is identity or not. (WebCore::GraphicsContext::endTransparencyLayer): Ditto. (WebCore::GraphicsContext::scale): Ditto. (WebCore::GraphicsContext::rotate): Ditto. (WebCore::GraphicsContext::translate): Ditto. (WebCore::GraphicsContext::concatCTM): Ditto. (WebCore::GraphicsContext::roundToDevicePixels): Return quickly if the transform is known to be identity, and record that fact when we discover it otherwise.
- platform/graphics/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Added a m_userToDeviceTransformKnownToBeIdentity flag, initialized to false.
- 8:09 PM Changeset in webkit [27699] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15944 streamline SegmentedString to speed up parsing
I measured a speed-up of the page load test while developing this patch. I don't
have a precise figure, though.
- html/HTMLTokenizer.h: Removed unneeded lineNumberPtr() function. Also renamed lineno to m_lineNumber.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): Don't pass 0 to the advance function since we don't want to update a line number. (WebCore::HTMLTokenizer::parseSpecial): Ditto. (WebCore::HTMLTokenizer::parseComment): Pass the line number data member directly instead of lineNumberPtr() since the advance function now takes a reference. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. (WebCore::HTMLTokenizer::write): Ditto.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::write):
- loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Don't pass 0 to the advance function.
- platform/SegmentedString.h: (WebCore::SegmentedString::advance): Streamlined the most common case, and pushed less common cases into a separate function that is not inlined. Also got rid of a branch by separating the case with a line number from the case without one.
- platform/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase): Added. The aforementioned less common cases are here.
- 7:36 PM Changeset in webkit [27698] by
-
- 2 edits in trunk/JavaScriptCore
Partial fix for <rdar://problem/5585334> numfuzz: integer overflows opening malformed SVG file in WebCore::ImageBuffer::create
Reviewed By Eric.
Unfortunately this is a very slight regression, but is unavoidable.
- 6:02 PM Changeset in webkit [27697] by
-
- 2 edits in trunk/WebCore
Forgot to do this review change (and test HTTP commit).
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::play):
- 5:54 PM Changeset in webkit [27696] by
-
- 7 edits8 adds in trunk
WebCore:
Reviewed by Darin.
- Update play() and pause() to match current HTML5 draft
- send events asynchronously
- add timeupdate event to pause
- rethrow load() exception, not others
- Use list for async events to get ordering right
Tests: media/video-pause-empty-events.html
media/video-play-empty-events.html
media/video-play-pause-events.html
media/video-play-pause-exception.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEventAsync): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause):
- html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Darin.
Add tests for play() and pause() events.
Update one test to match new behavior.
- media/video-currentTime-expected.txt:
- media/video-currentTime.html:
- media/video-pause-empty-events-expected.txt: Added.
- media/video-pause-empty-events.html: Added.
- media/video-play-empty-events-expected.txt: Added.
- media/video-play-empty-events.html: Added.
- media/video-play-pause-events-expected.txt: Added.
- media/video-play-pause-events.html: Added.
- media/video-play-pause-exception-expected.txt: Added
- media/video-play-pause-exception.html: Added
- media/video-test.js:
- 4:34 PM Changeset in webkit [27695] by
-
- 13 edits in trunk
2007-11-10 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add simple type inferencing to the parser, and create custom
AddNode and LessNode subclasses based on inferred types.
http://bugs.webkit.org/show_bug.cgi?id=15884
SunSpider claims this is at least a 0.5% speedup.
- JavaScriptCore.exp:
- kjs/grammar.y:
- kjs/internal.cpp: (KJS::NumberImp::getPrimitiveNumber): (KJS::GetterSetterImp::getPrimitiveNumber):
- kjs/internal.h:
- kjs/lexer.cpp: (KJS::Lexer::lex):
- kjs/nodes.cpp: (KJS::Node::Node): (KJS::StringNode::evaluate): (KJS::StringNode::evaluateToNumber): (KJS::StringNode::evaluateToBoolean): (KJS::RegExpNode::evaluate): (KJS::UnaryPlusNode::optimizeVariableAccess): (KJS::AddNode::evaluate): (KJS::AddNode::evaluateToNumber): (KJS::AddNumbersNode::inlineEvaluateToNumber): (KJS::AddNumbersNode::evaluate): (KJS::AddNumbersNode::evaluateToNumber): (KJS::AddStringsNode::evaluate): (KJS::AddStringLeftNode::evaluate): (KJS::AddStringRightNode::evaluate): (KJS::lessThan): (KJS::lessThanEq): (KJS::LessNumbersNode::evaluate): (KJS::LessStringsNode::evaluate):
- kjs/nodes.h: (KJS::ExpressionNode::): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::TypeOfResolveNode::): (KJS::LocalVarTypeOfNode::): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::AddNumbersNode::): (KJS::AddStringLeftNode::): (KJS::AddStringRightNode::): (KJS::AddStringsNode::): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
- kjs/nodes2string.cpp: (KJS::StringNode::streamTo):
- kjs/object.cpp:
- kjs/object.h:
- kjs/value.h: (KJS::JSValue::getPrimitiveNumber):
- 4:25 PM Changeset in webkit [27694] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-11 Alp Toker <alp@atoker.com>
Reviewed by Anders.
Initialize m_userAgent.
Fix typos in GDK_WINDOWING conditionals.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::agentPlatform):
- 2:36 PM Changeset in webkit [27693] by
-
- 1 edit in trunk/WebCore/ChangeLog
Forgot to commit ChangeLog, in my last commit.
- 2:33 PM Changeset in webkit [27692] by
-
- 2 edits9 adds in trunk
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=6424 (<text>, <tspan> dominant-baseline attribute is not respected)
Add (basic) support for dominant-baseline / alignment-baseline text properties.
Note: there are no official testcases, and no-one implemented it before. Only ASV3
supported dominant-baseline, but not correct it seems.
- 12:51 PM Changeset in webkit [27691] by
-
- 7 edits in trunk
Fix <rdar://5133816> keepWebHistory is not implemented
WebCore:
Add wrappers around CoCreateInstance to COMPtr
I followed the example of the Query constructor and query method by
adding a Create constructor and create method.
Reviewed by Darin.
- platform/win/COMPtr.h: (COMPtr::COMPtr): Added a new constructor that calls CoCreateInstance. (COMPtr::create): Added. (COMPtr::createInstance): Added.
WebKitTools:
Fix <rdar://5133816> keepWebHistory is not implemented
Fixes fast/history/clicked-link-is-visited.html.
Reviewed by Darin.
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Clear the optionalSharedHistory.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Darin.
- platform/win/Skipped:
- 12:28 PM Changeset in webkit [27690] by
-
- 32 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15896
More editing cleanup
No functionality changes.
- dom/Node.h: Moved several editing-related methods elsewhere.
- dom/Node.cpp: (WebCore::Node::maxCharacterOffset): Renamed from maxOffset() to highlight that it is a match to offsetInCharacters(), and much different from other offset-related methods. Added ASSERT_NOT_REACHED(), as callers are supposed to check offsetInCharacters() before calling this.
- dom/CharacterData.cpp: (WebCore::CharacterData::maxCharacterOffset):
- dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode): Updated for above renamings.
- dom/Comment.{h,cpp}: Removed an override for offsetInCharacters(), which is already present in CharacterData.
- dom/Document.{h,cpp}: Folded updateSelection() into Frame::selectionLayoutChanged().
- dom/Position.h:
- dom/Position.cpp: (WebCore::Position::uncheckedPreviousOffset): Moved from Node::previousOffset(). (WebCore::Position::uncheckedNextOffset): Moved from Node::NextOffset(). (WebCore::Position::previous): Adapted to the above move. (WebCore::Position::next): Ditto. (WebCore::Position::upstream): Removed an isBR() check, since a non-BR element cannot have a BR renderer (I think), and BR elements are covered by editingIgnoresContent(). (WebCore::Position::downstream): Ditto. (WebCore::caretMaxRenderedOffset): Moved from Node::caretMaxRenderedOffset(). (WebCore::Position::rendersInDifferentPosition): Updated for the above moves.
- dom/PositionIterator.h: Added a comment describing this class from the original check-in.
- dom/PositionIterator.cpp: (WebCore::PositionIterator::increment): Updated for the above moves. (WebCore::PositionIterator::decrement): Ditto.
- dom/ProcessingInstruction.h:
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::maxCharacterOffset): ProcessingInstruction was already returning true from offsetInCharacters(), but didn't override maxCharacterOffset(). I think that implementing it has no actual effect, as PIs are not rendered, but it looks cleaner this way.
- dom/Range.cpp: (WebCore::Range::selectNodeContents):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::maxRangeOffset): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::insertTab):
- editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): Updated for the above moves.
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Added a missing rangeCompliantEquivalent() call.
- editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Changed the condition to obviously match a maxCharacterOffset() call made after it; hopefully, this doesn't break any border cases. (WebCore::SimplifiedBackwardsTextIterator::advance): Updated for the above moves.
- editing/htmlediting.h:
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Removed a bogus comment: I don't thin BRs have a special ability to accept child nodes, other than via DOM manipulation, which is not specific to BRs. (WebCore::rangeCompliantEquivalent): Removed a check for BR, which is already covered by editingIgnoresContent(). (WebCore::maxDeepOffset): Ditto. (WebCore::caretMinOffset): Moved from Node. Changed some runtime checks that seemingly cannot fail into assertions. (WebCore::caretMaxOffset): Ditto.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): Pass 0 to VisiblePosition constructor instead of caretMinOffset. I didn't want to include htmlediting.h here, and I think that VisiblePosition constructor will take care of adjusting the offset.
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Folded Document::updateSelection() here.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): Added missing rangeCompliantEquivalent() calls.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForRenderer): Changed to not round-trip via editing. Changed some runtime checks that seemingly cannot fail into assertions.
- 11:24 AM Changeset in webkit [27689] by
-
- 6 edits in trunk/JavaScriptCore
- try another way of fixing dftables builds -- refactor pcre_internal.h a bit
- pcre/pcre_internal.h: Make most of this header do nothing when DFTABLES is set. Later we can break it into two files.
- JavaScriptCore.vcproj/dftables/dftables.vcproj: Take out now-unneeded include paths.
- pcre/dftables.cpp: Set DFTABLES. Use delete instead of free.
- pcre/dftables.pro: Take out now-unneeded include paths.
- pcre/pcre_maketables.cpp: Use new instead of malloc.
- 11:05 AM Changeset in webkit [27688] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/dftables.pro: Try fixing Qt builds (I looked at qt-win) by adding another include path.
- 11:03 AM Changeset in webkit [27687] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.xcodeproj/project.pbxproj: Try fixing Mac Tiger builds by adding another include path.
- 10:56 AM Changeset in webkit [27686] by
-
- 22 edits9 moves4 deletes in trunk
Reviewed by Sam.
- http://bugs.webkit.org/show_bug.cgi?id=15924 next round of changes to JSRegExp (formerly PCRE)
This is a combination of converting to C++, tweaking the API, and adding
some additional optimizations.
Future steps will involve getting rid of the use of UTF-8 completely
(we'll use UTF-16 exclusively instead), eliminating more source files,
and some more speed-ups.
SunSpider says the current round is an 0.9% speed-up overall, and a
5.3% speed-up for regexp.
- JavaScriptCore.exp: Updated for new entry points.
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/dftables/dftables.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- jscore.bkl: Updated for new source file names and ForwardingHeaders.
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to use the error message without calling strdup on it and to pass the new types and options. (KJS::RegExp::~RegExp): Removed the now-unneeded free of the error message. (KJS::RegExp::match): Pass the new types and options.
- kjs/regexp.h: Update type of m_constructionError.
- pcre/AUTHORS: Update to reflect the status of the project -- we don't include the Google parts, and this isn't the PCRE library, per se.
- pcre/COPYING: Ditto.
- pcre/dftables.cpp: Copied from JavaScriptCore/pcre/dftables.c. (main): Removed unneeded ctype_digit.
- pcre/pcre.h: Convert to C++, tweak API a bit. Use UChar instead of JSRegExpChar.
- pcre/pcre_compile.cpp: Copied from JavaScriptCore/pcre/pcre_compile.c. Moved a lot of private stuff used only within this file here from pcre_internal.h. Renumbered the error codes. (error_text): Use a single string with embedded nulls for the error text (I got this idea from newer versions of PCRE). (check_escape): Changed return type to be enum instead of int. Replaced ctype_digit uses with isASCIIDigit. (is_counted_repeat): Ditto. (read_repeat_counts): Ditto. (first_significant_code): Ditto. (find_fixedlength): Ditto. (could_be_empty_branch): Ditto. (compile_branch): Ditto. Also removed some code that handles changing options. JavaScript doesn't have any of the features that allow options to change. (compile_regex): Updated for change to options parameter. (is_anchored): Ditto. (find_firstassertedchar): Ditto. (jsRegExpCompile): Changed to take separate flags instead of an options int. Also changed to call new/delete instead of pcre_malloc/free. (jsRegExpFree): Ditto.
- pcre/pcre_exec.cpp: Copied from JavaScriptCore/pcre/pcre_exec.c. Added a case that uses computed goto for the opcode loop, but did not turn it on. Changed the RMATCH macro to handle returns more efficiently by putting the where pointer in the new frame instead of the old one, allowing us to branch to the return with a single statement. Switched to new/delete from pcre_malloc/free. Changed many RRETURN callers to not set the return value since it's already set correctly. Replaced the rrc variable with an is_match variable. Values other than "match" and "no match" are now handled differently. This allows us to remove the code to check for those cases in various rules. (match): All the case statements use a macro BEGIN_OPCODE instead. And all the continue statements, or break statements that break out of the outer case use a macro NEXT_OPCODE instead. Replaced a few if statements with assertions. (jsRegExpExecute): Use new/delete instead of pcre_malloc/free. Removed unused start_match field from the match block.
- pcre/pcre_internal.h: Moved the last few configuration macros from pcre-config.h in here. Removed various unused types. Converted from JSRegExpChar to UChar. Eliminated pcre_malloc/free. Replaced the opcode enum with a macro that can be used in multiple places. Unfortunately we lose the comments for each opcode; we should find a place to put those back. Removed ctype_digit.
- pcre/pcre_maketables.cpp: Copied from JavaScriptCore/pcre/pcre_maketables.c. (pcre_maketables): Got rid of the conditional code that allows this to be compiled in -- it's only used for dftables now (and soon may be obsolete entirely). Changed code for cbit_digit to not use isdigit, and took the "_" case out of the loop. Removed ctype_digit.
- pcre/pcre_ord2utf8.cpp: Copied from JavaScriptCore/pcre/pcre_ord2utf8.c.
- pcre/pcre_tables.cpp: Copied from JavaScriptCore/pcre/pcre_tables.c. Moved _pcre_OP_lengths out of here into pcre_exec.cpp.
- pcre/pcre_ucp_searchfuncs.cpp: Copied from JavaScriptCore/pcre/pcre_ucp_searchfuncs.c. Updated for other file name changes.
- pcre/pcre_xclass.cpp: Copied from JavaScriptCore/pcre/pcre_xclass.c.
- pcre/ucpinternal.h: Updated header.
- pcre/ucptable.cpp: Copied from JavaScriptCore/pcre/ucptable.c.
- wtf/ASCIICType.h: (WTF::isASCIIDigit): Removed a branch by changing from && to & for this operation. Also added an overload that takes an int because that's useful for PCRE. Later we could optimize for int and overload other functions in this file; stuck to this simple one for now.
- wtf/unicode/icu/UnicodeIcu.h: Removed unused isUpper.
- wtf/unicode/qt4/UnicodeQt4.h: Ditto.
- pcre/LICENCE: Removed.
- pcre/pcre-config.h: Removed.
- wtf/FastMallocPCRE.cpp: Removed.
- pcre/dftables.c: Renamed to cpp.
- pcre/pcre_compile.c: Ditto.
- pcre/pcre_exec.c: Ditto.
- pcre/pcre_maketables.c: Ditto.
- pcre/pcre_ord2utf8.c: Ditto.
- pcre/pcre_tables.c: Ditto.
- pcre/pcre_ucp_searchfuncs.c: Ditto.
- pcre/pcre_xclass.c: Ditto.
- pcre/ucptable.c: Ditto.
WebCore:
Reviewed by Sam.
- updated for JSRegExp function changes
- platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):
- 1:32 AM Changeset in webkit [27685] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-11 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Mention Safari in the UserAgent string to improve site compatibility.
Also bump the hard-coded AppleWebKit version number.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::composeUserAgent):
- 12:34 AM Changeset in webkit [27684] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-11 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Add KJS_CHECKEXCEPTIONBOOLEAN to match rest of nodes.cpp
- kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToBoolean): (KJS::LessNode::evaluateToBoolean): (KJS::GreaterNode::evaluateToBoolean): (KJS::LessEqNode::evaluateToBoolean): (KJS::GreaterEqNode::evaluateToBoolean): (KJS::InstanceOfNode::evaluateToBoolean): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::evaluateToBoolean): (KJS::NotEqualNode::evaluateToBoolean): (KJS::StrictEqualNode::evaluateToBoolean): (KJS::NotStrictEqualNode::evaluateToBoolean): (KJS::LogicalAndNode::evaluateToBoolean): (KJS::LogicalOrNode::evaluateToBoolean): (KJS::ConditionalNode::evaluateToBoolean):
Nov 10, 2007:
- 8:05 PM Changeset in webkit [27683] by
-
- 2 edits in trunk/WebCore
2007-11-10 Mark Rowe <mrowe@apple.com>
Qt Linux build fix.
- platform/UnicodeRange.h:
- 7:52 PM Changeset in webkit [27682] by
-
- 2 edits in trunk/WebCore
2007-11-10 Mark Rowe <mrowe@apple.com>
Qt Windows build fix.
- platform/UnicodeRange.h:
- 7:33 PM Changeset in webkit [27681] by
-
- 2 edits in trunk/LayoutTests
- platform/win/fast/dom/Window/window-properties-expected.txt: Update for fix for http://bugs.webkit.org/show_bug.cgi?id=15922.
- 6:12 PM Changeset in webkit [27680] by
-
- 24 edits in trunk
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15937 (Add glyph-orientation-horizontal/vertical support)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13971 (text-anchor support on vertical text seems slightly off)
Add glyph-orientation-* support for text & textPath. (90/180/270 and 'auto')
Also fix all vertical text handling - for text & textPath! (especially latin1 characters auto orientation in vertical writing modes)
- 5:38 PM Changeset in webkit [27679] by
-
- 9 edits in trunk/LayoutTests
Rubberstamped by Eric.
Update some SVG pixel test results - which show changes lately -> repainting fixes.
- 5:07 PM Changeset in webkit [27678] by
-
- 4 edits3 adds in trunk
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15927 REGRESSION(r27487): delete a.c followed by defineGetter("c", ...) incorrectly deletes another property and <rdar://problem/5586384> REGRESSION (r27487): Can't switch out of Edit HTML Source mode on Leopard Wiki
Test: fast/js/delete-then-put.html
- kjs/property_map.cpp: (KJS::PropertyMap::put): Added a missing "- 1"; code to find an empty slot was not working. (KJS::PropertyMap::checkConsistency): Added a missing range check that would have caught this problem before.
- roll out a last-minute change to my evaluateToBoolean patch that was incorrect.
- kjs/nodes.h: (KJS::ExprStatementNode::ExprStatementNode): Take out call to optimizeForUnnecessaryResult, since the result is used in some cases.
LayoutTests:
Reviewed by Sam.
- test for http://bugs.webkit.org/show_bug.cgi?id=15927 delete a.c followed by defineGetter("c", ...) incorrectly deletes another property
- fast/js/delete-then-put-expected.txt: Added.
- fast/js/delete-then-put.html: Added.
- fast/js/resources/delete-then-put.js: Added.
- 4:49 PM Changeset in webkit [27677] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- page/inspector/StylesSidebarPane.js: Fix the wording of a comment and switch over to use getUniqueProperties in another place.
- 4:30 PM Changeset in webkit [27676] by
-
- 8 edits2 adds in trunk
WebKitTools:
Reviewed by Tim Hatcher.
Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
is turned on)
- Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
Added test: http/tests/security/cross-frame-access-private-browsing.html
- DumpRenderTree/LayoutTestController.cpp: (setPrivateBrowsingEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Default to private browsing disabled.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPrivateBrowsingEnabled):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPrivateBrowsingEnabled):
LayoutTests:
Reviewed by Tim Hatcher.
Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
is turned on)
Test using the new LayoutTestController.setPrivateBrowsingEnabled(bool)
- http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
- http/tests/security/cross-frame-access-private-browsing.html: Added.
- platform/win/Skipped: Add new test to windows skip list until we have an implementation of LayoutTestController.setPrivateBrowsingEnabled(bool) for it.
- 3:38 PM Changeset in webkit [27675] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig
Rest of fix for 5394877
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Don't log unsafe JavaScript attempts in the other version of isSafeScript() if in private browsing mode either.
- 3:16 PM Changeset in webkit [27674] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Fix function name difference - header said 'unicodeRangeForCharacter', actually
implemented function is 'findCharUnicodeRange'. They are not compiled yet.
- 2:24 PM Changeset in webkit [27673] by
-
- 2 edits in trunk/WebKit/qt
When populating the context menu with sub-menus don't add sub-menus if they're empty.
Signed-off-by: Nikolas
- 2:24 PM Changeset in webkit [27672] by
-
- 3 edits in trunk/WebKit/qt
Added support for the Bold/Italic/Underline toggle actions.
Signed-off-by: Nikolas
- 2:24 PM Changeset in webkit [27671] by
-
- 3 edits in trunk/WebKit/qt
Before adding an action to the context menu call checkOrEnableIfNeeded for each action
to update the enable/checked state correctly.
Signed-off-by: Nikolas
- 2:24 PM Changeset in webkit [27670] by
-
- 2 edits in trunk/WebKit/qt
Mark the text direction actions as checkable actions.
Signed-off-by: Nikolas
- 2:18 PM Changeset in webkit [27669] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
Roll out some changes that were (seemingly accidentally) checked in
with r27664.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 1:12 PM Changeset in webkit [27668] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5450655> Control-clicking text in a link can surprisingly select only part of the link, should select entire link
No test because context menu events cannot be tested in DumpRenderTree.
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Added. If the click occurred in an active link, selects the entire link element. Otherwise selects the closest word. (WebCore::EventHandler::sendContextMenuEvent): Call selectClosestWordOrLinkFromMouseEvent().
- page/EventHandler.h:
- 1:08 PM Changeset in webkit [27667] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher
- fixed <rdar://problem/5394877> Safari should not log unsafe JavaScript attempts when in private browsing mode (only an issue if Log JavaScript Exceptions is turned on)
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Don't log unsafe JavaScript attempts to console or chromeClient if in private browsing mode
- 12:29 PM Changeset in webkit [27666] by
-
- 8 edits8 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15922
Implement more of Mozilla Selection API
Tests: editing/selection/containsNode.html
editing/selection/deleteFromDocument.html
editing/selection/extend.html
editing/selection/selectAllChildren.html
- editing/SelectionController.cpp: (WebCore::SelectionController::deleteFromDocument): (WebCore::SelectionController::containsNode): (WebCore::SelectionController::selectAllChildren): (WebCore::SelectionController::extend):
- editing/SelectionController.h: Added deleteFromDocument(), containsNode(), and selectAllChildren(). Reimplemented extend(), which existed, but didn't match Firefox behavior and wasn't exposed via bindings. Removed a comment mentioning removeRange(), as this method makes no sense without multiple selection range support.
- page/DOMSelection.cpp: (WebCore::DOMSelection::extend): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::selectAllChildren):
- page/DOMSelection.h:
- page/DOMSelection.idl: Exposed the new methods.
- 12:24 PM Changeset in webkit [27665] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15892
DOM Range operations are not implemented for ProcessingInstruction nodes
Test: fast/dom/Range/range-processing-instructions.html
- dom/Range.cpp: (WebCore::Range::processContents): Implemented ProcessingInstruction cases. (WebCore::Range::checkNodeWOffset): Removed a FIXME - yes, I think that we are supposed to use ProcessingInstruction.data.
- 10:29 AM Changeset in webkit [27664] by
-
- 7 edits3 adds in trunk/JavaScriptCore
Reviewed by Sam.
- http://bugs.webkit.org/show_bug.cgi?id=15915 add an evaluation path for booleans like the one we have for numbers
Gives 1.1% on SunSpider.
- kjs/grammar.y: Create TrueNode and FalseNode instead of BooleanNode.
- kjs/nodes.h: Changed to use Noncopyable. Moved optimizeForUnnecessaryResult down from Node to ExpressionNode. Changed some classes to not inherit from ExpressionNode where not necessary, and removed unnneeded evaluate functions as well as evaluate functions that need not be virtual. Call the optimizeForUnnecessaryResult function on the start of a for loop too.
- kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToBoolean): Added. (KJS::FalseNode::evaluate): Added. (KJS::TrueNode::evaluate): Added. (KJS::NumberNode::evaluateToBoolean): Added. (KJS::StringNode::evaluateToBoolean): Added. (KJS::LocalVarAccessNode::evaluateToBoolean): Added. (KJS::BracketAccessorNode::evaluateToBoolean): Added. (KJS::LogicalNotNode::evaluate): Changed to call evaluateToBoolean. (KJS::LogicalNotNode::evaluateToBoolean): Added. (KJS::lessThan): Changed to return bool. (KJS::lessThanEq): Ditto. (KJS::LessNode::evaluate): Changed since lessThan returns bool. (KJS::LessNode::evaluateToBoolean): Added. (KJS::GreaterNode::evaluate): Changed since lessThanEq returns bool. (KJS::GreaterNode::evaluateToBoolean): Added. (KJS::LessEqNode::evaluate): Changed since lessThanEq returns bool. (KJS::LessEqNode::evaluateToBoolean): Added. (KJS::GreaterEqNode::evaluate): Changed since lessThan returns bool. (KJS::GreaterEqNode::evaluateToBoolean): Added. (KJS::InstanceOfNode::evaluateToBoolean): Added. (KJS::InNode::evaluateToBoolean): Added. (KJS::EqualNode::evaluateToBoolean): Added. (KJS::NotEqualNode::evaluateToBoolean): Added. (KJS::StrictEqualNode::evaluateToBoolean): Added. (KJS::NotStrictEqualNode::evaluateToBoolean): Added. (KJS::ConditionalNode::evaluate): Changed to call evaluateToBoolean. (KJS::IfNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ForNode::execute): Ditto.
- kjs/nodes2string.cpp: (KJS::FalseNode::streamTo): Added. (KJS::TrueNode::streamTo): Added.
- 5:01 AM Applications using WebKit edited by
- (diff)
- 12:02 AM Changeset in webkit [27663] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
Bug 12054: Ability to serialize an element subtree (into clipboard?) from the DOM inspector
http://bugs.webkit.org/show_bug.cgi?id=12054
- Add support code for routing copy events to the focused element.
- Implement copying the currently selected DOM node. The node and it's subtree is copied to the clipboard. If the node has no outerHTML, the nodeValue is copied (text nodes, etc.)
- Implement copy for the resource sidebar. The URL is copied for the currently selected resource.
- page/inspector/DocumentPanel.js:
- page/inspector/inspector.js:
Nov 9, 2007:
- 11:50 PM Changeset in webkit [27662] by
-
- 2 edits in trunk/SunSpider
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15925
SunSpider should check for Shark being installed
- sunspider: Explicitly test that shark command line tool is installed.
- 6:28 PM Changeset in webkit [27661] by
-
- 2 edits in trunk/WebKit/win
2007-11-09 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Sam.
<rdar://5585900>: Safari crashes when selected in context menu to open
audio format files (au, aif) with QT 7.3
The crash occurred on a machine where QT 7.3 was failing to initialize.
The fix is to avoid sending streams to full-page plugins that've failed
to load
- WebFrame.cpp: (WebFrame::finishedLoading): Check plugin status before calling manual stream methods (WebFrame::setMainDocumentError): Same (WebFrame::committedLoad): Same
- 5:53 PM Changeset in webkit [27660] by
-
- 1 edit2 adds in trunk/WebKitSite
Rubber stamped by bdash.
Add directory for blog resources (and one image).
- blog-files: Added.
- blog-files/touch-poster.png: Added.
- 4:59 PM Changeset in webkit [27659] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
Fix occasional blank video with poster attribute.
- ChangeLog:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::didRestoreFromCache): Just calling updateFromElement() does the right thing for both poster image and video.
- 4:29 PM Changeset in webkit [27658] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-09 Xan Lopez <xan@gnome.org>
Reviewed by Alp.
Fix http://bugs.webkit.org/show_bug.cgi?id=15926
[GTK] WebKitPage map handler is redundant.
- Api/webkitgtkpage.cpp: The map handler for WebKitPage is redundant, GtkContainer does the same (and more correctly).
- 3:51 PM Changeset in webkit [27657] by
-
- 1 edit1 move in trunk/LayoutTests
Reviewed by Sam Weinig.
- fast/dom/Window/window-resize-nan.html: Removed.
- fast/dom/Window/window-resize-nan.html-disabled: Copied from fast/dom/Window/window-resize-nan.html.
Disabled nan test until window resize issues can be resolved.
- 3:34 PM Changeset in webkit [27656] by
-
- 2 edits in trunk/WebKit/win
Rubber stamped by Oliver.
Make WebCore a dependency of Interfaces.
- WebKit.vcproj/WebKit.sln:
- 3:04 PM Changeset in webkit [27655] by
-
- 8 edits11 adds in trunk
WebCore:
Reviewed by Adam Roben.
<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings
Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.
The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.
This commit includes:
- Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
- Generating all of the Core DOM and most of HTML and CSS
- Generating Event, EventTarget, and EventListener
- WebCore.vcproj/MigrateIDLAndScripts.make: Added.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/migrate-idls.sh: Added.
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorCOM.pm: Added.
- dom/EventListener.h: Make the isWindowEvent parameter default to false to allow autogeneration based on the IDL.
WebKit/win:
Reviewed by Adam Roben.
<rdar://problem/5435940>
The COM bindings for the DOM should be autogenerated like the other DOM bindings
Initial commit of the autogeneration of the COM DOM Bindings. No behavior change
is being introduced in this patch and to insure that no conflicts arise, a temporary
prefix of "GEN_" has been used for all the new classes.
The build architecture for these bindings differs slightly from the other autogenerated
bindings. Instead of building in WebCore and migrating the resuting code to WebKit (as
is done for the Objective-C bindigs currently), the IDLs and generation scripts are
migrated to WebKit and built there. This is done with a series of scripts and Makefiles.
This commit includes:
- Hand rolled root class/Interface GEN_DOMObject used to facilated object creation and ref-counting.
- Generating all of the Core DOM and most of HTML and CSS
- Generating Event, EventTarget, and EventListener
- DOMCreateInstance.cpp: Added. (domWrapperCache): (getDOMWrapper): (setDOMWrapper): (removeDOMWrapper): (GEN_DOMNode::createInstance): (GEN_DOMImplementation::createInstance): (GEN_DOMCSSRule::createInstance): (GEN_DOMStyleSheet::createInstance): (GEN_DOMCSSValue::createInstance):
- DOMCreateInstance.h: Added. Temporary location for createInstance/object caching methods. This will be broken up into seperate files in the near future.
- GEN_DOMObject.cpp: Added. (GEN_DOMObject::GEN_DOMObject): (GEN_DOMObject::~GEN_DOMObject): (GEN_DOMObject::QueryInterface): (GEN_DOMObject::AddRef): (GEN_DOMObject::Release):
- GEN_DOMObject.h: Added. Hand rolled base class.
- Interfaces/IGEN_DOMObject.idl: Added. Hand rolled base interface.
- WebKit.vcproj/DerivedSources.make: Added.
- WebKit.vcproj/FixMIDLHeaders.pl: Added. This script is required because MIDL is producing un-buildable code due to circular dependencies.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
- WebKit.vcproj/build-generated-files.sh: Added.
- 2:54 PM Changeset in webkit [27654] by
-
- 5 edits in trunk
mac:
Reviewed by Timothy Hatcher.
This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Pass up the new preferredType parameter as a string.
WebCore:
Reviewed by Timothy Hatcher.
This patch is for the WebKit side of <rdar://problem/5591115>.
We need a way to tell context menu navigations, such as "Open in New Window"
to override any sort of browser preference for tab based navigation.
- bridge/WindowFeatures.h: (WebCore::WindowFeatures::WindowFeatures): Added a new struct member var, preferredType and an accompanying enum type PreferredType to send a window type recommendation up to the Chrome.
- page/ContextMenuController.cpp: (WebCore::openNewWindow): Set the window features to recommend a new Window for "Open in New Window" context menu action.
- 2:25 PM Changeset in webkit [27653] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by John.
<rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
Extend the linked on or after check to every application when a script passed to
stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
was limited to VitalSource Bookshelf, but other developers are running into this.
- Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
- WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
- WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
- 1:43 PM SpecSupport edited by
- (diff)
- 1:39 PM SpecSupport edited by
- (diff)
- 1:36 PM SpecSupport edited by
- (diff)
- 1:31 PM SpecSupport edited by
- (diff)
- 1:31 PM SpecSupport edited by
- (diff)
- 1:27 PM SpecSupport edited by
- (diff)
- 1:23 PM SpecSupport edited by
- (diff)
- 1:11 PM SpecSupport edited by
- (diff)
- 12:04 PM Changeset in webkit [27652] by
-
- 4 edits2 adds in trunk
Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick
LayoutTests:
Add a test for <rdar://5483519> Pressing Enter on selected buttons should fire onclick
Reviewed by Adele.
- fast/forms/enter-clicks-buttons-expected.txt: Added.
- fast/forms/enter-clicks-buttons.html: Added.
WebCore:
Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick
We now match the behavior of Firefox and IE, which is to always just
send a click event to the focused button when the Enter key is pressed
(previously we were submitting forms directly in some cases).
Reviewed by Adele.
Test: fast/forms/enter-clicks-buttons.html
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't do anything fancy when Enter is pressed on a <button type=button> -- just send a click event like we do for other button types.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Treat type=button the same way we treat type=submit and type=reset: just send a click event when Enter is pressed.
- 12:03 PM Changeset in webkit [27651] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Antti Koivisto.
- fix a bug in invisible layer culling: dynamically changing a descendant of an invisible layer to be visible did not work
Test: fast/layers/layer-content-visibility-change.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): If we got visible content, make sure that our stacking context rebuilds its z-order lists to include us.
LayoutTests:
Reviewed by Antti Koivisto.
- test that dynamically changing a descendant of an invisible layer to be visible works
- fast/layers/layer-content-visibility-change.html: Added.
- platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
- platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
- platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
- 11:57 AM Changeset in webkit [27650] by
-
- 3 edits in trunk/WebCore
Clean up matrix() parsing. Make sure the first four arguments can be lengths or numbers. The last two
args can be lengths or numbers or percents.
Reviewed by Beth
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
- rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):
- 11:05 AM Changeset in webkit [27649] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems
Transform matrices accept the first four parameters as CSS lengths.
CSS lengths get mapped into WebCore::Lengths as percents by
WebCore::convertToLength(). Percent lengths cannot call value(). It
does not yield a correct result and it asserts on Debug builds.
- rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply): Instead of calling value() on the lengths, call calcValue. This fixes the assert and the bad rendering.
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/5586370> CSS Transform - incorrect matrix
math leads to crazy problems
- fast/transforms/identity-matrix.html: Added.
- platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
- platform/mac/fast/transforms/identity-matrix-expected.png: Added.
- platform/mac/fast/transforms/identity-matrix-expected.txt: Added.
- 9:56 AM Changeset in webkit [27648] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
Reviewed by Darin.
- kjs/value.h: (KJS::jsNumber): Add some explicit casts.
- 9:16 AM Changeset in webkit [27647] by
-
- 2 edits in trunk/WebCore
Roll out r27641 since the same bug was already fixed by r27568.
- 7:35 AM SpecSupport edited by
- (diff)
- 7:26 AM SpecSupport edited by
- (diff)
- 6:44 AM WikiStart edited by
- (diff)
- 6:41 AM SpecSupport edited by
- (diff)
- 6:40 AM SpecSupport edited by
- (diff)
- 6:36 AM SpecSupport created by
- 6:33 AM Changeset in webkit [27646] by
-
- 2 edits in trunk/WebCore
userIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't
define it twice for the Qt/Windows build.
- 5:09 AM Changeset in webkit [27645] by
-
- 3 edits in trunk/WebKit/qt
Implemented the webcore actions for changing the text direction.
Signed-off-by: Holger
- 5:09 AM Changeset in webkit [27644] by
-
- 9 edits in trunk
Fix ContextMenu allocation in the Qt port.
Store all items and submenus value based in ContextMenu and ContextMenuItem.
That fixes the crashes when the context menu was populated with sub-menus because
of the use of temporary ContextMenu objects like this:
ContextMenu subMenu(...);
subMenu.appendItem(...);
subMenu.appendItem(...);
subMenuItem.setSubMenu(&subMenu); temporary pointer, need to _copy_ contents
Signed-off-by: Holger
- 5:09 AM Changeset in webkit [27643] by
-
- 3 edits in trunk/WebKit/qt
Renamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and fixed its value.
Signed-off-by: Holger
- 4:51 AM Changeset in webkit [27642] by
-
- 2 edits in trunk/WebCore
2007-11-09 Peter Kasting <zerodpx@gmail.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15909
Malformed GIFs should not result in memory corruption.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
- 1:01 AM Changeset in webkit [27641] by
-
- 2 edits in trunk/WebCore
Initialize WindowFeatures struct before using it.
Reviewed by Oliver.
- page/ContextMenuController.cpp: (WebCore::openNewWindow):
- 12:29 AM Changeset in webkit [27640] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Adam.
- This patch does two main things. 1) It adds pragma warning guards around WebCore includes in WebKit files that were previously overlooked. 2) It implements almost the entireity of WebScriptDebugger. Only one function remains and that implementation is dependent on finishing the implementation of WebScriptScope.
- WebScriptCallFrame.h:
- WebScriptDebugServer.h:
- WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::enterFrame): (WebScriptDebugger::leaveFrame):
- WebScriptDebugger.h:
- 12:26 AM Changeset in webkit [27639] by
-
- 4 edits5 adds in trunk/WebKitTools
Reviewed by Adam.
- Changed the vcproj file to use Drosera's ForwardingHeaders and not WebCore's!
- Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
- Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
- Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
- Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
- Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
- Drosera/win/Drosera.cpp:
- Drosera/win/Drosera.vcproj/Drosera.vcproj:
Nov 8, 2007:
- 11:06 PM Changeset in webkit [27638] by
-
- 2 edits in trunk/WebCore
2007-11-08 Timothy Hatcher <timothy@apple.com>
Reviewed by Sam Weinig.
Some Web Inspector CSS editing changes.
- Only delete the property if all the text is delete or the new user input correctly parses. This prevents deleting the existing property if the new text is invalid.
- Intercept the Escape key and cancel editing, not saving any changes.
- page/inspector/StylesSidebarPane.js:
- 9:57 PM Changeset in webkit [27637] by
-
- 4 edits in trunk/JavaScriptCore
- fix build
- kjs/grammar.y:
- kjs/nodes.h:
- kjs/property_map.cpp:
- 9:56 PM Changeset in webkit [27636] by
-
- 2 edits in trunk/JavaScriptCore
- roll out accidentally-checked in changes
- kjs/nodes.cpp: Back to previous version.
- kjs/nodes.h: Ditto.
- kjs/grammar.y: Ditto.
- 9:55 PM Changeset in webkit [27635] by
-
- 3 edits in trunk/JavaScriptCore
- roll out accidentally-checked in changes
- kjs/nodes.cpp: Back to previous version.
- kjs/nodes.h: Ditto.
- 9:51 PM Changeset in webkit [27634] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15912 fasta spends a lot of time in qsort
- kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): Use insertion sort instead of qsort for small sets of property names. We can probably do some even-better speedups of for/in, but this nets 0.6% overall and 6.7% on fasta.
- 9:50 PM Changeset in webkit [27633] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15906 getting characters by indexing into a string is very slow
This fixes one source of the slowness -- the conversion to an unused
Identifier as we call the get function from the slot -- but doesn't
fix others, such as the fact that we have to allocate a new UString::Rep
for every single character.
Speeds up string-base64 30%, and at least 0.5% overall.
But does slow down access-fannkuch quite a bit. Might be worth
revisiting in the future to see what we can do about that (although
I did look at a profile for a while).
- kjs/property_slot.h: Add a new marker for "numeric" property slots; slots where we don't need to pass the identifier to the get function. (KJS::PropertySlot::getValue): Added code to call the numeric get function. (KJS::PropertySlot::setCustomNumeric): Added.
- kjs/string_object.cpp: (KJS::StringInstance::indexGetter): Changed to use substr() instead of constructing a wholly new UString each time. (KJS::stringInstanceNumericPropertyGetter): Added. Like indexGetter, but takes advantage of setCustomNumeric to avoid creating an Identifier. (KJS::StringInstance::getOwnPropertySlot): Changed to use setCustomNumeric.
- 9:48 PM Changeset in webkit [27632] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=15904 more speed-ups possible by tightening up int version of JSImmediate
1% improvement of SunSpider
- kjs/JSImmediate.h: Eliminate the now-unneeded FPBitValues struct template. (KJS::JSImmediate::from): Overload for most numeric types; many types can do fewer branches and checks. (KJS::JSImmediate::getUInt32): Removed unneeded check for undefined. (KJS::JSImmediate::getTruncatedInt32): Ditto. (KJS::JSImmediate::getTruncatedUInt32): Ditto. There's no difference any more between getUInt32 and getTruncatedUInt32, so that's worth a rename and merge later.
- kjs/grammar.y: Update since fromDouble is now just from.
- kjs/nodes.h: Ditto.
- kjs/value.h: (KJS::jsNumber): Overload for most numeric types.
- 9:38 PM Changeset in webkit [27631] by
-
- 3 edits37 adds in trunk
Adding Bakefiles for JSCore, WebCore, and WebKit, and adding wxWebKit implementation.
Reviewed by Mark Rowe
- 8:32 PM Changeset in webkit [27630] by
-
- 3 edits2 adds in trunk
Fix regression caused by earlier bitwise and optimisation. 1 & undefined != 1.
Reviewed by Maciej.
The implementation of JSImmediate::areBothImmediateNumbers relies on
(JSImmediate::getTag(immediate1) & JSImmediate::getTag(immediate2)) having
a unique result when both immediate values are numbers.
The regression was due to UndefinedType & NumberType returning NumberType (3 & 1).
By swapping the value of NumberType and UndefinedType this ceases to be a problem.
- 7:13 PM Changeset in webkit [27629] by
-
- 3 edits in trunk/WebCore
2007-11-08 Justin Haygood <jhaygood@reaktix.com>
Reviewed by Mark Rowe.
Fix builds with HTML 5 Storage support disabled.
ENABLE(DATABASE) needs to be added in a few places.
- page/InspectorController.cpp:
- storage/Database.h:
- 6:03 PM Changeset in webkit [27628] by
-
- 3 edits in trunk/WebKit/win
Bump versions for submit
- 5:48 PM Changeset in webkit [27627] by
-
- 4 edits in trunk
Versioning.
- 5:39 PM Changeset in webkit [27626] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fix typo in ChangeLog.
- 5:32 PM Changeset in webkit [27625] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/5491463> Wrong dates shown in History menu.
Fix off-by-one error in Windows epoch.
For the Windows DATE type, 1/1/1900 should be 2.0, not 1.0.
DATE is the number of dates since 12/30/1899.
Reviewed by Ada.
- MarshallingHelpers.cpp: (MarshallingHelpers::windowsEpochAbsoluteTime):
- 5:13 PM Changeset in webkit [27624] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-08 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15653
[GTK] Text editor does not handle common keystrokes
Handle more keystrokes in EditorClientGtk. Note that this is a
temporary measure pending a proper solution using GtkBindingSet (see
http://bugs.webkit.org/show_bug.cgi?id=15911).
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
- 5:04 PM Changeset in webkit [27623] by
-
- 2 edits in trunk/JavaScriptCore
- fix build
- kjs/nodes.h: Add missing parameter name.
- 4:43 PM Changeset in webkit [27622] by
-
- 4 edits in trunk/JavaScriptCore
2007-11-08 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add ExpressionNode subclass of Node, use it.
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::ForInNode::ForInNode):
- kjs/nodes.h: (KJS::ExpressionNode::): (KJS::NullNode::): (KJS::NullNode::precedence): (KJS::BooleanNode::): (KJS::BooleanNode::precedence): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::ThisNode::): (KJS::ThisNode::precedence): (KJS::ResolveNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNode::): (KJS::PropertyNode::precedence): (KJS::PropertyNode::name): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::ObjectLiteralNode::precedence): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::DotAccessorNode::precedence): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::NewExprNode::precedence): (KJS::FunctionCallValueNode::): (KJS::FunctionCallValueNode::precedence): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallBracketNode::precedence): (KJS::FunctionCallDotNode::): (KJS::FunctionCallDotNode::precedence): (KJS::PrePostResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixBracketNode::precedence): (KJS::PostIncBracketNode::): (KJS::PostIncBracketNode::isIncrement): (KJS::PostDecBracketNode::): (KJS::PostDecBracketNode::isIncrement): (KJS::PostfixDotNode::): (KJS::PostfixDotNode::precedence): (KJS::PostIncDotNode::): (KJS::PostIncDotNode::isIncrement): (KJS::PostDecDotNode::): (KJS::PostDecDotNode::isIncrement): (KJS::PostfixErrorNode::): (KJS::PostfixErrorNode::precedence): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteBracketNode::precedence): (KJS::DeleteDotNode::): (KJS::DeleteDotNode::precedence): (KJS::DeleteValueNode::): (KJS::DeleteValueNode::precedence): (KJS::VoidNode::): (KJS::VoidNode::precedence): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixBracketNode::): (KJS::PrefixBracketNode::precedence): (KJS::PreIncBracketNode::): (KJS::PreIncBracketNode::isIncrement): (KJS::PreDecBracketNode::): (KJS::PreDecBracketNode::isIncrement): (KJS::PrefixDotNode::): (KJS::PrefixDotNode::precedence): (KJS::PreIncDotNode::): (KJS::PreIncDotNode::isIncrement): (KJS::PreDecDotNode::): (KJS::PreDecDotNode::isIncrement): (KJS::PrefixErrorNode::): (KJS::PrefixErrorNode::precedence): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::NegateNode::): (KJS::NegateNode::precedence): (KJS::BitwiseNotNode::): (KJS::BitwiseNotNode::precedence): (KJS::LogicalNotNode::): (KJS::LogicalNotNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::LeftShiftNode::): (KJS::LeftShiftNode::precedence): (KJS::RightShiftNode::): (KJS::RightShiftNode::precedence): (KJS::UnsignedRightShiftNode::): (KJS::UnsignedRightShiftNode::precedence): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::GreaterNode::): (KJS::GreaterNode::precedence): (KJS::LessEqNode::): (KJS::LessEqNode::precedence): (KJS::GreaterEqNode::): (KJS::GreaterEqNode::precedence): (KJS::InstanceOfNode::): (KJS::InstanceOfNode::precedence): (KJS::InNode::): (KJS::InNode::precedence): (KJS::EqualNode::): (KJS::EqualNode::precedence): (KJS::NotEqualNode::): (KJS::NotEqualNode::precedence): (KJS::StrictEqualNode::): (KJS::StrictEqualNode::precedence): (KJS::NotStrictEqualNode::): (KJS::NotStrictEqualNode::precedence): (KJS::BitAndNode::): (KJS::BitAndNode::precedence): (KJS::BitOrNode::): (KJS::BitOrNode::precedence): (KJS::BitXOrNode::): (KJS::BitXOrNode::precedence): (KJS::LogicalAndNode::): (KJS::LogicalAndNode::precedence): (KJS::LogicalOrNode::): (KJS::LogicalOrNode::precedence): (KJS::ConditionalNode::): (KJS::ConditionalNode::precedence): (KJS::ReadModifyResolveNode::): (KJS::ReadModifyResolveNode::precedence): (KJS::AssignResolveNode::): (KJS::AssignResolveNode::precedence): (KJS::ReadModifyBracketNode::): (KJS::ReadModifyBracketNode::precedence): (KJS::AssignBracketNode::): (KJS::AssignBracketNode::precedence): (KJS::AssignDotNode::): (KJS::AssignDotNode::precedence): (KJS::ReadModifyDotNode::): (KJS::ReadModifyDotNode::precedence): (KJS::AssignErrorNode::): (KJS::AssignErrorNode::precedence): (KJS::CommaNode::): (KJS::CommaNode::precedence): (KJS::AssignExprNode::): (KJS::AssignExprNode::precedence): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::ThrowNode::): (KJS::ParameterNode::): (KJS::CaseClauseNode::): (KJS::CaseClauseNode::precedence): (KJS::ClauseListNode::): (KJS::SwitchNode::):
- 4:09 PM Changeset in webkit [27621] by
-
- 2 edits in trunk
Correct ChangeLogs to reflect that the speedup was 1% not .5%. Turns out you are not supposed to test in Debug builds.
- 3:51 PM Changeset in webkit [27620] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixed bug title in old check-in.
- 3:49 PM Changeset in webkit [27619] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5524082> Allow images to be dragged out directly into other apps
We weren't including CF_HDROP in our image drops. This broke drag of
images out of the browser window directly into other apps (examples
include notepad, mspaint, msword).
Reviewed by Oliver, Ada.
- platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileContent): Removed unused variable. (WebCore::createGlobalHDropContent): Added (WebCore::writeFileToDataObject): Write HDROP data if available. (WebCore::writeImageToDataObject): Write HDROP for dragged images. (WebCore::ClipboardWin::writeURL): Don't write HDROP for dragged URLs.
- 3:31 PM Changeset in webkit [27618] by
-
- 3 edits in trunk/WebCore
2007-11-08 Xan Lopez <xan@gnome.org>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15908
Use g_object_ref_sink when available
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- 2:59 PM Changeset in webkit [27617] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Beth Dakin.
- fix <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely
Test: fast/dom/length-attribute-mapping.html
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSLength): Changed the garbage-stripping logic to stop after the first "%" or "*" in the string. This allows for "100%25" to be mapped to "100%" like it is in Firefox and WinIE.
LayoutTests:
Reviewed by Beth Dakin.
- test for <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely
- fast/dom/length-attribute-mapping-expected.txt: Added.
- fast/dom/length-attribute-mapping.html: Added.
- 2:26 PM Changeset in webkit [27616] by
-
- 4 edits in trunk
WebCore:
- Build fix.
- loader/FrameLoaderClient.h:
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::windowObjectCleared):
WebKit/mac:
Build Fix.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::windowObjectCleared):
- 2:23 PM Changeset in webkit [27615] by
-
- 4 edits in trunk/JavaScriptCore
Add a fast path for bitwise-and of two immediate numbers for a 0.7% improvement in SunSpider (4% bitop improvement).
Reviewed by Sam.
This only improves bitwise-and performance, as the additional logic required
for similar code paths on or, xor, and shifting requires additional operations
and branches that negate (and in certain cases, regress) any advantage we might
otherwise receive.
This improves performance on all bitop tests, the cryptography tests, as well as
the string-base64 and string-unpack-code tests. No significant degradation on
any other tests.
- 1:49 PM Changeset in webkit [27614] by
-
- 2 edits in trunk/JavaScriptCore
Stop using KJS inside of MathExtras.h
Reviewed by Darin.
- wtf/MathExtras.h: Removed an unused header, and a now-unused forward-declaration. (wtf_atan2): Use std::numeric_limits intead of KJS.
- 1:45 PM Changeset in webkit [27613] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Sam.
- Use the new IWebFrame [local] function signature and get the shared server correctly.
- Drosera/win/DebuggerClient.cpp: (DebuggerClient::didFinishLoadForFrame):
- Drosera/win/ServerConnection.cpp: (ServerConnection::attemptToCreateServerConnection):
- 1:43 PM Changeset in webkit [27612] by
-
- 24 edits2 adds in trunk
WebCore:
Reviewed by Sam.
- windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
- loader/FrameLoaderClient.h:
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::windowObjectCleared):
WebKit/gtk:
Reviewed by Sam.
- windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/qt:
Reviewed by Sam.
- windowObjectCleared() is no longer const. It needs to setup the script debugger and cannot be const to do so.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::windowObjectCleared):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam.
- With this change Drosera can now get the source of a website and the listings of the sources it gets. This also lays the foundation for letting Drosera show the scope chain of the JavaScript stack.
- Interfaces/IWebFrame.idl: Changed the signature of the local function, globalContext(), because COM was unable to marshal this object with the other signature.
- Interfaces/IWebScriptDebugServer.idl: Of course adding and removing a listener cannot be done in a const function.
- WebChromeClient.h: Added accessor to the WebView for the new added kit() function in WebFrame. (WebChromeClient::webView):
- WebFrame.cpp: Added a script debugger object and the necessary functions to attach and communicate with it. Also needed to change the local function, globalContext(), because of a COM issue. (kit): (WebFrame::WebFrame): (WebFrame::globalContext): (WebFrame::loadData): (WebFrame::attachScriptDebugger): (WebFrame::detachScriptDebugger): (WebFrame::dispatchDidLoadMainResource): (WebFrame::windowObjectCleared):
- WebFrame.h: Ditto.
- WebHTMLRepresentation.cpp: Implemented documentSource so Drosera has some source code to display. (WebHTMLRepresentation::WebHTMLRepresentation): (WebHTMLRepresentation::documentSource):
- WebKit.vcproj/WebKit.vcproj: Added the new WebScriptDebugger class.
- WebScriptCallFrame.cpp: Implemented much of this class' functionality. (EnumScopes::EnumScopes): Made an EnumScopes class to create an IEnumVARIANT to wrap a ScopeChain for Drosera. (EnumScopes::QueryInterface): (EnumScopes::AddRef): (EnumScopes::Release): (EnumScopes::Next): (EnumScopes::Skip): (EnumScopes::Reset): (EnumScopes::Clone): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
- WebScriptCallFrame.h: Added member data needed for the above functions
- WebScriptDebugServer.cpp: Began implementing. (WebScriptDebugServer::listenerCount): (EnumViews::QueryInterface): (EnumViews::AddRef): (EnumViews::Release): (EnumViews::Next): (EnumViews::Skip): (EnumViews::Reset): (EnumViews::Clone): (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::sharedWebScriptDebugServer): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused): (WebScriptDebugServer::suspendProcessIfPaused): (WebScriptDebugServer::didLoadMainResourceForDataSource): (WebScriptDebugServer::didParseSource): (WebScriptDebugServer::failedToParseSource): (WebScriptDebugServer::didEnterCallFrame): (WebScriptDebugServer::willExecuteStatement): (WebScriptDebugServer::willLeaveCallFrame): (WebScriptDebugServer::exceptionWasRaised):
- WebScriptDebugServer.h: Began implementing.
- WebScriptDebugger.cpp: Added. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed):
- WebScriptDebugger.h: Added.
- WebScriptScope.cpp: Make this class use createInstance which is more in line with our guidelines. (WebScriptScope::WebScriptScope): (WebScriptScope::createInstance):
- WebScriptScope.h:
- 1:27 PM Changeset in webkit [27611] by
-
- 2 edits in trunk/WebCore
Hopeful Windows build fix
- rendering/RenderObject.cpp: Touch this file to make it recompile.
- 1:26 PM Changeset in webkit [27610] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/date_object.cpp: (KJS::DateProtoFuncToLocaleString::callAsFunction): Fix unused arg warning. (KJS::DateProtoFuncToLocaleDateString::callAsFunction): ditto (KJS::DateProtoFuncToLocaleTimeString::callAsFunction): ditto
- 1:03 PM Changeset in webkit [27609] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-08 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/lookup.h: Add missing include.
- 12:31 PM Changeset in webkit [27608] by
-
- 29 edits in trunk
Reviewed by Darin.
Convert JavaScript internal function objects to use one class per
function. This avoids a switch statement inside what used to be
the shared function classes and will allow Shark to better analyze
the code.
To make this switch, the value property of the HashEntry was changed
to a union of an intptr_t (which is used to continue handle valueGetters)
and function pointer which points to a static constructor for the
individual new function objects.
SunSpider claims this is a 0.5% speedup.
- kjs/array_object.cpp: (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::getProperty): (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncPush::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncForEach::callAsFunction): (KJS::ArrayProtoFuncSome::callAsFunction): (KJS::ArrayProtoFuncIndexOf::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction):
- kjs/array_object.h: (KJS::ArrayPrototype::classInfo):
- kjs/create_hash_table:
- kjs/date_object.cpp: (KJS::DatePrototype::getOwnPropertySlot): (KJS::DateProtoFuncToString::callAsFunction): (KJS::DateProtoFuncToUTCString::callAsFunction): (KJS::DateProtoFuncToDateString::callAsFunction): (KJS::DateProtoFuncToTimeString::callAsFunction): (KJS::DateProtoFuncToLocaleString::callAsFunction): (KJS::DateProtoFuncToLocaleDateString::callAsFunction): (KJS::DateProtoFuncToLocaleTimeString::callAsFunction): (KJS::DateProtoFuncValueOf::callAsFunction): (KJS::DateProtoFuncGetTime::callAsFunction): (KJS::DateProtoFuncGetFullYear::callAsFunction): (KJS::DateProtoFuncGetUTCFullYear::callAsFunction): (KJS::DateProtoFuncToGMTString::callAsFunction): (KJS::DateProtoFuncGetMonth::callAsFunction): (KJS::DateProtoFuncGetUTCMonth::callAsFunction): (KJS::DateProtoFuncGetDate::callAsFunction): (KJS::DateProtoFuncGetUTCDate::callAsFunction): (KJS::DateProtoFuncGetDay::callAsFunction): (KJS::DateProtoFuncGetUTCDay::callAsFunction): (KJS::DateProtoFuncGetHours::callAsFunction): (KJS::DateProtoFuncGetUTCHours::callAsFunction): (KJS::DateProtoFuncGetMinutes::callAsFunction): (KJS::DateProtoFuncGetUTCMinutes::callAsFunction): (KJS::DateProtoFuncGetSeconds::callAsFunction): (KJS::DateProtoFuncGetUTCSeconds::callAsFunction): (KJS::DateProtoFuncGetMilliSeconds::callAsFunction): (KJS::DateProtoFuncGetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncGetTimezoneOffset::callAsFunction): (KJS::DateProtoFuncSetTime::callAsFunction): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction): (KJS::DateProtoFuncSetYear::callAsFunction): (KJS::DateProtoFuncGetYear::callAsFunction):
- kjs/date_object.h:
- kjs/lookup.cpp: (KJS::Lookup::find):
- kjs/lookup.h: (KJS::HashEntry::): (KJS::staticFunctionGetter): (KJS::staticValueGetter): (KJS::getStaticPropertySlot): (KJS::getStaticFunctionSlot): (KJS::lookupPut):
- kjs/math_object.cpp: (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathProtoFuncAbs::callAsFunction): (KJS::MathProtoFuncACos::callAsFunction): (KJS::MathProtoFuncASin::callAsFunction): (KJS::MathProtoFuncATan::callAsFunction): (KJS::MathProtoFuncATan2::callAsFunction): (KJS::MathProtoFuncCeil::callAsFunction): (KJS::MathProtoFuncCos::callAsFunction): (KJS::MathProtoFuncExp::callAsFunction): (KJS::MathProtoFuncFloor::callAsFunction): (KJS::MathProtoFuncLog::callAsFunction): (KJS::MathProtoFuncMax::callAsFunction): (KJS::MathProtoFuncMin::callAsFunction): (KJS::MathProtoFuncPow::callAsFunction): (KJS::MathProtoFuncRandom::callAsFunction): (KJS::MathProtoFuncRound::callAsFunction): (KJS::MathProtoFuncSin::callAsFunction): (KJS::MathProtoFuncSqrt::callAsFunction): (KJS::MathProtoFuncTan::callAsFunction):
- kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
- kjs/string_object.cpp: (KJS::StringPrototype::getOwnPropertySlot): (KJS::StringProtoFuncToString::callAsFunction): (KJS::StringProtoFuncValueOf::callAsFunction): (KJS::StringProtoFuncCharAt::callAsFunction): (KJS::StringProtoFuncCharCodeAt::callAsFunction): (KJS::StringProtoFuncConcat::callAsFunction): (KJS::StringProtoFuncIndexOf::callAsFunction): (KJS::StringProtoFuncLastIndexOf::callAsFunction): (KJS::StringProtoFuncMatch::callAsFunction): (KJS::StringProtoFuncSearch::callAsFunction): (KJS::StringProtoFuncReplace::callAsFunction): (KJS::StringProtoFuncSlice::callAsFunction): (KJS::StringProtoFuncSplit::callAsFunction): (KJS::StringProtoFuncSubstr::callAsFunction): (KJS::StringProtoFuncSubstring::callAsFunction): (KJS::StringProtoFuncToLowerCase::callAsFunction): (KJS::StringProtoFuncToUpperCase::callAsFunction): (KJS::StringProtoFuncToLocaleLowerCase::callAsFunction): (KJS::StringProtoFuncToLocaleUpperCase::callAsFunction): (KJS::StringProtoFuncLocaleCompare::callAsFunction): (KJS::StringProtoFuncBig::callAsFunction): (KJS::StringProtoFuncSmall::callAsFunction): (KJS::StringProtoFuncBlink::callAsFunction): (KJS::StringProtoFuncBold::callAsFunction): (KJS::StringProtoFuncFixed::callAsFunction): (KJS::StringProtoFuncItalics::callAsFunction): (KJS::StringProtoFuncStrike::callAsFunction): (KJS::StringProtoFuncSub::callAsFunction): (KJS::StringProtoFuncSup::callAsFunction): (KJS::StringProtoFuncFontcolor::callAsFunction): (KJS::StringProtoFuncFontsize::callAsFunction): (KJS::StringProtoFuncAnchor::callAsFunction): (KJS::StringProtoFuncLink::callAsFunction):
- kjs/string_object.h:
WebCore:
Reviewed by Darin.
Convert JavaScript internal function objects to use one class per
function. This avoids a switch statement inside what used to be
the shared function classes and will allow Shark to better analyze
the code.
To make this switch, the value property of the HashEntry was changed
to a union of an intptr_t (which is used to continue handle valueGetters)
and function pointer which points to a static constructor for the
individual new function objects.
SunSpider claims this is a 0.5% speedup.
- On the WebCore side, I updated CodeGeneratorJS.pm to generate the new classes and hand updated the remain non-generated (groan) classes.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNodePrototypeFunctionAddEventListener::callAsFunction): (WebCore::JSEventTargetNodePrototypeFunctionRemoveEventListener::callAsFunction): (WebCore::JSEventTargetNodePrototypeFunctionDispatchEvent::callAsFunction):
- bindings/js/JSEventTargetNode.h:
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBaseFunctionSetSelectionRange::callAsFunction): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
- bindings/js/JSHTMLInputElementBase.h: (WebCore::JSHTMLInputElementBase::):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunctionAbort::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionGetAllResponseHeaders::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionGetResponseHeader::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionOpen::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionSend::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionSetRequestHeader::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionOverrideMIMEType::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionAddEventListener::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionRemoveEventListener::callAsFunction): (KJS::JSXMLHttpRequestPrototypeFunctionDispatchEvent::callAsFunction):
- bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::impl):
- bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessorPrototypeFunctionImportStylesheet::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionTransformToFragment::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionTransformToDocument::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionSetParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionGetParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionRemoveParameter::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionClearParameters::callAsFunction): (KJS::JSXSLTProcessorPrototypeFunctionReset::callAsFunction):
- bindings/js/JSXSLTProcessor.h:
- bindings/js/kjs_events.cpp: (WebCore::JSClipboardPrototypeFunctionClearData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionGetData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionSetData::callAsFunction): (WebCore::JSClipboardPrototypeFunctionSetDragImage::callAsFunction):
- bindings/js/kjs_events.h:
- bindings/js/kjs_navigator.cpp: (KJS::Plugins::): (KJS::Navigator::getOwnPropertySlot): (KJS::Plugins::getOwnPropertySlot): (KJS::PluginsFunctionRefresh::callAsFunction): (KJS::NavigatorProtoFuncJavaEnabled::callAsFunction):
- bindings/js/kjs_navigator.h: (KJS::Navigator::):
- bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncScrollBy::callAsFunction): (KJS::WindowProtoFuncScrollTo::callAsFunction): (KJS::WindowProtoFuncMoveBy::callAsFunction): (KJS::WindowProtoFuncMoveTo::callAsFunction): (KJS::WindowProtoFuncResizeBy::callAsFunction): (KJS::WindowProtoFuncResizeTo::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
- bindings/js/kjs_window.h: (KJS::Window::):
- bindings/scripts/CodeGeneratorJS.pm:
- 12:22 PM Changeset in webkit [27607] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
Reviewed by Sam and Ada.
- wtf/MathExtras.h: Get rid of a circular #include dependency to fix the build.
- 11:58 AM Changeset in webkit [27606] by
-
- 2 edits in trunk/JavaScriptCore
Fix a precedence warning on Windows
- kjs/JSImmediate.h: (KJS::JSImmediate::toBoolean):
- 11:49 AM Changeset in webkit [27605] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-08 Mark Rowe <mrowe@apple.com>
Build fix for JavaScriptGlue.
- wtf/MathExtras.h: Include stdlib.h for srand and RAND_MAX.
- 11:45 AM Changeset in webkit [27604] by
-
- 1 edit1 add in trunk/JavaScriptGlue
2007-11-08 Mark Rowe <mrowe@apple.com>
Build fix.
- ForwardingHeaders/wtf/MathExtras.h: Copied from WebCore/ForwardingHeaders/wtf/MathExtras.h.
- 11:38 AM Changeset in webkit [27603] by
-
- 2 edits in trunk/JavaScriptCore
- Windows build fix
- kjs/JSImmediate.h: Include MathExtras.h rather than math.h since this file uses "signbit".
- 10:27 AM Changeset in webkit [27602] by
-
- 3 edits in trunk/JavaScriptCore
Replace the use of floats for immediate values with the use of integers for a 4.5% improvement in SunSpider.
Reviewed by Darin.
Unfortunately this change results in NaN, +Inf, -Inf, and -0 being heap allocated now, but
we should now have faster array access, faster immediate to double conversion, and the
potential to further improve bitwise operators in future.
This also removes the need for unions to avoid strict aliasing problems when extracting
a value from immediates.
- kjs/JSImmediate.h:
(KJS::):
(KJS::JSImmediate::trueImmediate):
(KJS::JSImmediate::falseImmediate):
(KJS::JSImmediate::undefinedImmediate):
(KJS::JSImmediate::nullImmediate):
(KJS::JSImmediate::toBoolean):
- kjs/value.h:
(KJS::jsNaN):
- 9:18 AM Changeset in webkit [27601] by
-
- 4 edits in trunk/WebCore
2007-11-08 Mark Rowe <mrowe@apple.com>
Fix the Gtk, Qt and Wx builds.
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/qt/TemporaryLinkStubs.cpp:
- platform/wx/TemporaryLinkStubs.cpp:
- 8:50 AM Changeset in webkit [27600] by
-
- 3 edits in trunk/WebCore
2007-11-08 Mark Rowe <mrowe@apple.com>
Not reviewed. Fix two instances of includes using the wrong case in the filename.
- platform/graphics/mac/MoviePrivateQTKit.mm:
- platform/wx/MimeTypeRegistryWx.cpp:
- 7:42 AM Changeset in webkit [27599] by
-
- 5 edits in trunk
WebCore:
Reviewed by Adam.
- fix <rdar://problem/5552943> accesskey does not focus <button> elements
Test: fast/forms/access-key.html
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Added a call to focus.
LayoutTests:
Reviewed by Adam.
- test changes for <rdar://problem/5552943> accesskey does not focus <button> elements
- fast/forms/access-key.html: Check for both focus and click events on all elements, but resisted the urge to switch to the American spelling for "focused".
- fast/forms/access-key-expected.txt: Updated to reflect the bug fix ("1 button focussed"), the fact that <input type=button>, <input type=checkbox>, <input type=submit>, and <input type=reset> are all both focused and clicked ("2 input type button clicked", "3 input type checkbox clicked", "5 input type submit focussed", and "6 input type reset focussed"). Unfortunately this now also demonstrates that we don't send a click to <input type=text> and Gecko does. And there are still quite a few types that are not covered.
- 7:40 AM Changeset in webkit [27598] by
-
- 31 edits3 deletes in trunk
WebCore:
Reviewed by Steve.
- cut down on notImplemented() functions on Windows
- bridge/AXObjectCache.h: Put #if around the accessibility global.
- bridge/win/FrameWin.cpp: (WebCore::Frame::setNeedsReapplyStyles): Moved here from TemporaryLinkStubs.
- dom/Document.cpp: (WebCore::Document::lastModified): Re-implemented using the ResourceResponse that's now available from the DocumentLoader.
- editing/JSEditor.cpp: (execTranspose): Changed to call transpose() on the Editor instead of the obsolete one on the Frame.
- loader/DocumentLoader.h: Removed getResponseModifiedHeader.
- loader/FrameLoader.h: Removed overrideMediaType.
- loader/gtk/DocumentLoaderGtk.cpp: Removed.
- loader/mac/DocumentLoaderMac.mm: Removed.
- loader/qt/DocumentLoaderQt.cpp: Removed.
- page/Frame.cpp: Removed transpose.
- page/Frame.h: Ditto.
- page/FrameView.h: Removed updateBorder.
- page/gtk/FrameGtk.cpp: Removed issueTransposeCommand.
- page/mac/FrameMac.mm: Ditto.
- page/mac/WebCoreFrameBridge.h: Removed issueTransposeCommand and overrideMediaType.
- page/qt/FrameQt.cpp: Removed issueTransposeCommand.
- platform/gtk/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled.
- platform/qt/TemporaryLinkStubs.cpp: Ditto.
- platform/win/TemporaryLinkStubs.cpp: Removed or moved all but 3 of the stubs.
- platform/wx/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled, issueTransposeCommand, and overrideMediaType.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadsBlocked): Moved here from TemporaryLinkStubs. (WebCore::ResourceHandle::willLoadFromCache): Ditto.
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::clip): Ditto.
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::inWindow): Ditto.
- platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): Ditto.
- platform/win/WidgetWin.cpp: (WebCore::Widget::setIsSelected): Ditto.
- WebCore.pro: Updated for removed files.
- WebCore.xcodeproj/project.pbxproj: Updated for removed file.
WebKit/mac:
Reviewed by Steve.
- removed some unused WebCore bridge methods
- WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of using the bridge object.
WebKit/win:
Reviewed by Steve.
- Interfaces/IWebUIDelegate.idl: Added the functions needed below.
- WebChromeClient.cpp: (WebChromeClient::setMenubarVisible): Eliminated the notImplemented() here by calling through the UI delegate. (WebChromeClient::menubarVisible): Ditto. (WebChromeClient::runDatabaseSizeLimitPrompt): Ditto.
- 7:12 AM Changeset in webkit [27597] by
-
- 3 edits in trunk/WebCore
2007-11-08 Mark Rowe <mrowe@apple.com>
Build fix for case-sensitive file systems. Fix case of file names
in #include's.
- html/HTMLMediaElement.cpp:
- platform/graphics/Movie.cpp:
- 6:18 AM Changeset in webkit [27596] by
-
- 2 edits in trunk/WebKit/qt
Build fix for Qt 4.3.
- 12:20 AM Changeset in webkit [27595] by
-
- 2 edits in trunk/WebCore
Remove some warnings about not implemented methods.
- ResourceHandle::loadsBlocked and ResourceHandle::supportsBufferedData are specific to the NS API and won't be implemented on Qt.
- ResourceHandle::bufferedData can not be reached as we return false in ResourceHandle::supportsBufferedData.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 12:20 AM Changeset in webkit [27594] by
-
- 4 edits in trunk
Cleanup checking for the request method.
- Check the request method only in QWebNetworkManager::add.
- Currently HEAD, GET, POST are allowed and for everything else QWebNetworkManager::add returns false.
- Returning false is compatible with ResourceHandle::start and it can be used in ResourceHandle::loadResourceSynchronously to generate a ResourceError
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 12:20 AM Changeset in webkit [27593] by
-
- 2 edits in trunk/WebCore
Implement WebCore::callOnMainThread
Implemented using a global QObject, that is moved to the main thread
and then sending a custom event to it.
Picked a number below QEvent::User but above any other documented value.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 12:20 AM Changeset in webkit [27592] by
-
- 3 edits in trunk/WebKit/qt
Fix bug in the implementation of synchronous network jobs.
- George (pmax) reviewed the networking patches and found the following bug (thanks for reviewing)
- if (jobMode == AsynchronousJob) {
+ if (jobMode == SynchronousJob) {
add job to synchronous list/hash
- Just applying the above change will lead to crashes because we can finish jobs before we started them.
- Avoid these issues by saving all work (starting a job, sending data and finishing it) inside one list. JobWork will contain any of the above three work types and doWork will just work on this list (m_pendingWork). As foreach takes a copy of the list calling started, data and finished will not add new work and we gurantee that if we have JobStarted it will be in the list before JobData and JobFinished.
- Observation: We might just kill the code to handle sync jobs.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 12:20 AM Changeset in webkit [27591] by
-
- 2 edits in trunk/WebCore
Avoid problems with calling QPainter::begin() on an already active paintdevice
- Partial pick from 6200e04c3e0a77873c3b3f3969b65bc701020326 to avoid getting crashes on Qt/Mac 4.4 with QPainter::begin to fail because we already draw.
- If we are in a layout or need one do not paint. This can happen for the PlatformScrollBar used by the ScrollView on a layout triggered by QWebPage::paintEvent.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 12:03 AM Changeset in webkit [27590] by
-
- 2 edits in trunk/WebCore
2007-11-08 Eric Seidel <eric@webkit.org>
No review.
- ksvg2/svg/SVGPathElement.h: remove old comment
Nov 7, 2007:
- 11:58 PM Changeset in webkit [27589] by
-
- 5 edits in trunk/JavaScriptCore
2007-11-07 Eric Seidel <eric@webkit.org>
Reviewed by Darin and Oliver.
Add evaluateToNumber parallel evaluation tree to speed up number operations.
Make ImmediateNumberNode a subclass of NumberNode.
Share evaluate logic between evaluate and evaluateToNumber using inline functions
There is still a lot of improvement to be made here.
SunSpider claims this is a 1.0% speedup overall (nbody 7.9%), base64 slowing 2.0%
Given the huge win that this prepares us for with simple type inferencing I see the small
regression in base64 being worth the substantial overall improvement.
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::Node::evaluateToNumber): (KJS::NumberNode::evaluate): (KJS::NumberNode::evaluateToNumber): (KJS::StringNode::evaluateToNumber): (KJS::LocalVarAccessNode::inlineEvaluate): (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarAccessNode::evaluateToNumber): (KJS::BracketAccessorNode::inlineEvaluate): (KJS::BracketAccessorNode::evaluate): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::NegateNode::evaluate): (KJS::NegateNode::evaluateToNumber): (KJS::MultNode::inlineEvaluateToNumber): (KJS::MultNode::evaluate): (KJS::MultNode::evaluateToNumber): (KJS::DivNode::inlineEvaluateToNumber): (KJS::DivNode::evaluate): (KJS::DivNode::evaluateToNumber): (KJS::ModNode::inlineEvaluateToNumber): (KJS::ModNode::evaluate): (KJS::ModNode::evaluateToNumber): (KJS::throwOutOfMemoryErrorToNumber): (KJS::addSlowCaseToNumber): (KJS::add): (KJS::addToNumber): (KJS::AddNode::evaluateToNumber): (KJS::SubNode::inlineEvaluateToNumber): (KJS::SubNode::evaluate): (KJS::SubNode::evaluateToNumber): (KJS::valueForReadModifyAssignment): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::ReadModifyDotNode::evaluate): (KJS::ReadModifyBracketNode::evaluate):
- kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::): (KJS::ImmediateNumberNode::): (KJS::AddNode::precedence):
- kjs/nodes2string.cpp: (KJS::NumberNode::streamTo):
- 11:40 PM Changeset in webkit [27588] by
-
- 3 edits in trunk/WebKit/win
Added IWebDocumentText available via QI from WebFrame.
Reviewed by Sam.
- WebFrame.cpp: (WebFrame::QueryInterface): Added IID_IWebDocumentText. (WebFrame::supportsTextEncoding): Stubbed out. (WebFrame::selectedString): Implemented. (WebFrame::selectAll): Stubbed out. (WebFrame::deselectAll): Stubbed out.
- WebFrame.h:
- 10:13 PM Changeset in webkit [27587] by
-
- 2 edits in trunk/WebCore
Reviewed by Ollie.
Ensure video renderer has correct size if video has already been loaded
when it is constructed.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):
- 8:24 PM Changeset in webkit [27586] by
-
- 2 edits in trunk/WebCore
Reviewed by Ollie.
Ensure video is visible when it should be.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updateMovie):
- 5:54 PM Changeset in webkit [27585] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5523503> Safari crashes clicking scroll bar in FaceBook 'Trips'
Layers and listboxes are two kinds of ScrollBarClient that can be
removed while the scrollbar is tracking the mouse. The scrollbar is not
destroyed until later, and meanwhile it can try to call the client,
which results in a crash.
- manual-tests/stale-scrollbar-client-crash.html: Added.
- platform/ScrollBar.h: (WebCore::Scrollbar::setClient): Added.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar): Call Scrollbar::setClient().
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): Ditto.
- 5:45 PM Changeset in webkit [27584] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Darin Adler.
- add an option to run-webkit-tests to ignore pixel test failures where all pixels differ by no more than a specified threshold
- DumpRenderTree/mac/ImageDiff.m: (main): (compareImages): (computePercentageDifferent):
- Scripts/run-webkit-tests:
- 3:45 PM Changeset in webkit [27583] by
-
- 4 edits in trunk
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
WebCore:
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
Reviewed by Sam.
No test possible.
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Bail if we get an empty path, because _wfopen_s will crash if we pass it a null pointer.
WebKit/win:
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
Reviewed by Sam.
- WebView.cpp: (WebView::initWithFrame): Set the ftpDirectoryTemplatePath for every Page, not just the first one.
- 3:09 PM Changeset in webkit [27582] by
-
- 1 edit1 add in trunk/WebKit
2007-11-07 Mark Rowe <mrowe@apple.com>
Reviewed by Kevin Decker.
Fix 64-bit Mac build.
- WebKit.xcodeproj/project.pbxproj: Change paths specified relative to SRCROOT to be relative to PROJECT_DIR. PROJECT_DIR takes into account the projectDirPath setting of the project, which in this instance includes the necessary "mac" subdirectory.
- 1:54 PM Changeset in webkit [27581] by
-
- 3 edits7 adds in trunk
WebCore:
WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>
Reviewed by Darin.
Tests: fast/css/device-aspect-ratio.html
fast/css/max-device-aspect-ratio.html
fast/css/min-device-aspect-ratio.html
- css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v. (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from a/b to h/v. Switched first two arguments of the call to cmpvalue() to fix the bug.
LayoutTests:
WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>
Reviewed by Darin.
Each of the following tests creates a <link> element and dynamically sets its
media query based on the aspect ratio (width/height) of the current screen.
When the <link> element is attached to the <head> node, the test expects the
stylesheet to be loaded for the test to pass.
- fast/css/device-aspect-ratio-expected.txt: Added.
- fast/css/device-aspect-ratio.html: Added.
This test sets the device-aspect-ratio to the current size of the screen.
NOTE: This test passed before the fix.
- fast/css/max-device-aspect-ratio-expected.txt: Added.
- fast/css/max-device-aspect-ratio.html: Added.
This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
1/1 for portrait (or square) monitors.
NOTE: This test failed before the fix.
- fast/css/min-device-aspect-ratio-expected.txt: Added.
- fast/css/min-device-aspect-ratio.html: Added.
This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
1/100 for portrait (or square) monitors.
NOTE: This test failed before the fix.
- fast/css/resources/device-aspect-ratio.css: Added.
- 1:44 PM Changeset in webkit [27580] by
-
- 2 edits in trunk/WebCore
Roll out r27578 as it is not necessary.
- 12:59 PM Changeset in webkit [27579] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
Test: fast/css/display-none-inline-style-change-crash.html
- dom/Element.cpp: (WebCore::Element::recalcStyle): Fixed the crash by null-checking the current style and removed other checks that are not strictly necessary.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
- fast/css/display-none-inline-style-change-crash-expected.txt: Added.
- fast/css/display-none-inline-style-change-crash.html: Added.
- 12:11 PM Changeset in webkit [27578] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker.
Build fix for Leopard. Cast a size() as int to unsigned for proper
comparison.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper): Casted an int to unsigned for an unsigned to unsigned comparison.
- 11:31 AM Changeset in webkit [27577] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Sam
Remove FrameLoaderClient methods from SVG that were pruned awhile ago
- platform/graphics/svg/SVGImageEmptyClients.h:
- 10:52 AM Changeset in webkit [27576] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix a bug where CSS rules with :hover in the ancestor chain stopped working after changing the inline style declaration of the ancestor
Test: fast/css/affected-by-hover-after-style-change.html
- dom/Element.cpp: (WebCore::Element::recalcStyle): If we are not forcing style recalculation for all descendants, preserve any "affected by {hover|active|drag} bits that we may have acquired from them. Also renamed _style to currentStyle.
WebKitSite:
Reviewed by Darin Adler.
- removed a workaround for the bug fixed in the WebCore part of this patch
- misc/DatabaseExample.html:
LayoutTests:
Reviewed by Darin Adler.
- test that CSS rules with :hover in the ancestor chain continue to work after changing the inline style declaration of the ancestor
- fast/css/affected-by-hover-after-style-change.html: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.
- 9:56 AM Changeset in webkit [27575] by
-
- 10 edits in trunk/WebCore
Reviewed by Adam.
Bug 11920: Web Inspector should have Firebug-like CSS editing
http://bugs.webkit.org/show_bug.cgi?id=11920
- css/CSSComputedStyleDeclaration.h: (WebCore::CSSComputedStyleDeclaration::isPropertyImplicit): Return false. I'm not sure why this was true, but computed style has no concept of implicit. So false makes more sense and makes the code simpler in the inspector. This function was added for the inspector, so this isn't a compatibility change.
- page/inspector/PropertiesSection.js: Add a getter/setter to reset populated status.
- page/inspector/StylesSidebarPane.js: Some refactoring along with the main support for style editing.
- page/inspector/inspector.css: Style changes for propery editing and focus correctness.
- page/inspector/inspector.js: Look for a handleKeyEvent function of the focus element before trying to call a function based on the element's id. Call focused and blurred on the focused element when currentFocusElement is changed. Use the new listItemElement getter instead of the private property.
- page/inspector/treeoutline.js: No longer expand on double click if ondblclick is implemented. Shrink the toggle zone to 10px to better match the size of the arrow. Add an onattach call to allow generation of the title using the DOM element. Add listItemElement and childrenListElement getters.
- page/inspector/utilities.js: Add new helper prototype methods on CSSStyleDeclaration.
- page/inspector/DocumentPanel.js: Use the new listItemElement getter instead of the private property. Also expand the DOM node on double click now that the TreeOutline dosen't do it.
- page/inspector/Resource.js: Use the new listItemElement and childrenListElement getters instead of the private properties.
- 9:54 AM Changeset in webkit [27574] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-07 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Fix up initialization after being mangled in r27572, and remove the
ternary expression as extraCost will always be zero for the numeric
heap.
- kjs/collector.cpp: (KJS::Collector::heapAllocate):
- 9:54 AM Changeset in webkit [27573] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/regexp_object.cpp:
- 9:52 AM JavaScript performance improvement ideas edited by
- (diff)
- 9:32 AM Changeset in webkit [27572] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Eliminated a bogus (though compiled-out) branch in the collector.
- kjs/collector.cpp: (KJS::Collector::heapAllocate):
- 9:18 AM Changeset in webkit [27571] by
-
- 9 edits in trunk
Reviewed by Darin Adler.
Fixed part of http://bugs.webkit.org/show_bug.cgi?id=15861
15% of string-validate-input.js is spent compiling the same regular expression.
Put RegExpImp properties into a static hashtable to avoid a slew of
PropertyMap churn when creating a RegExpImp.
Factored important bits of regular expression implementation out of
RegExpImp (the JS object) and into RegExp (the PCRE wrapper class),
making RegExp a ref-counted class. (This will help later.)
Removed PCRE_POSIX support because I didn't quite know how to test it
and keep it working with these changes.
1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.
- kjs/regexp.h: A few interface changes:
- Renamed "subpatterns()" => "numSubpatterns()"
- Made flag enumeration private and replaced it with public getters for specific flags.
- Made RegExp ref-counted so RegExps can be shared by RegExpImps.
- Made RegExp take a string of flags instead of an int, eliminating duplicated flag parsing code elsewhere.
- kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile:
- Fixed a bug where compile(undefined) would throw an exception.
- Removed some now-redundant code.
- Used RegExp sharing to eliminate an allocation and a bunch of PropertyMap thrash. (Not a big win since compile is a deprecated function. I mainly did this to test the plubming.)
LayoutTests:
Reviewed by Darin Adler.
Beefed up the RegExp.compile testcase to cover a mistake in the
original check-in and a mistake I made while developing my new patch.
- fast/js/resources/regexp-compile.js:
- 8:36 AM Changeset in webkit [27570] by
-
- 2 edits in trunk/JavaScriptCore
JavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
testkjs.pro, too, where it's included from.
- 8:14 AM Changeset in webkit [27569] by
-
- 2 edits in trunk/WebCore
Coding style fix.
- 7:52 AM Changeset in webkit [27568] by
-
- 2 edits in trunk/WebCore
For safety provide a default constructor for WindowFeatures().
ContextMenuController.cpp: createNewWindow as well as QWebPage need to
create a default initialized WindowFeatures object on the fly.
- 7:35 AM Changeset in webkit [27567] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build.
- 6:45 AM Changeset in webkit [27566] by
-
- 5 edits in trunk
Fix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that ends with the correct type of slash/backslash depending on the choice of compiler/make tool.
- 6:32 AM Changeset in webkit [27565] by
-
- 7 edits in trunk
Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
- 6:32 AM Changeset in webkit [27564] by
-
- 3 edits in trunk/WebKit/qt
Changed QWebPageHistory::goToItem to take a value instead of a pointer.
- 6:32 AM Changeset in webkit [27563] by
-
- 2 edits in trunk/WebKit/qt
Removed unimplemented QWebHistoryItem::children() function
- 6:32 AM Changeset in webkit [27562] by
-
- 2 edits in trunk/WebKit/qt
Changed the getter functions in QWebSettings to transparently resolve against the default settings.
- 6:31 AM Changeset in webkit [27561] by
-
- 3 edits in trunk/WebKit/qt
Added explicit functions for resetting the font sizes and font families.
- 6:31 AM Changeset in webkit [27560] by
-
- 3 edits in trunk/WebKit/qt
Combined the font sizes accessors/setters under one setter/getter with an enum.
- 6:31 AM Changeset in webkit [27559] by
-
- 4 edits in trunk/WebKit/qt
Renamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);
- 6:31 AM Changeset in webkit [27558] by
-
- 3 edits in trunk/WebKit/qt
Renamed QWebPage::webActionTriggered to QWebPage::triggerAction
- 6:31 AM Changeset in webkit [27557] by
-
- 4 edits in trunk/WebKit/qt
Changed the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal instead.
- 6:31 AM Changeset in webkit [27556] by
-
- 4 edits in trunk/WebKit/qt
Renamed QWebPage::webAction() to QWebPage::action()
- 6:31 AM Changeset in webkit [27555] by
-
- 3 edits in trunk/WebKit/qt
Removed a bunch of slots/functions that are now available through the new actions API.
- 6:31 AM Changeset in webkit [27554] by
-
- 2 edits in trunk/WebKit/qt
Added some more comments to the API after another round of API review with Lars.
- 6:31 AM Changeset in webkit [27553] by
-
- 5 edits in trunk/WebKit/qt
Moved QWebFrame::selectedText() to QWebPage::selectedText().
The currently selected text is a property of the page as a whole.
- 6:31 AM Changeset in webkit [27552] by
-
- 3 edits in trunk/WebKit/qt
Implemented support for settings propagation.
If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.
- 6:31 AM Changeset in webkit [27551] by
-
- 9 edits in trunk
Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
- 6:30 AM Changeset in webkit [27550] by
-
- 5 edits in trunk
Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.
- 6:30 AM Changeset in webkit [27549] by
-
- 4 edits in trunk
Moved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp to ImageQt.cpp and made it static.
- 6:30 AM Changeset in webkit [27548] by
-
- 3 edits in trunk/WebKit/qt
Changed the icondatabase accessor to be a static function because it doesn't change the QWebSettings object.
- 6:30 AM Changeset in webkit [27547] by
-
- 2 edits in trunk/WebKit/qt
Changed the webAction() accessor to not be a slot but just a public function.
- 6:30 AM Changeset in webkit [27546] by
-
- 2 edits in trunk/WebKit/qt
Implemented createWindow() in QtLauncher.
- 6:30 AM Changeset in webkit [27545] by
-
- 2 edits in trunk/WebKit/qt
Implemented opening links in new windows
- 6:30 AM Changeset in webkit [27544] by
-
- 3 edits in trunk/WebKit/qt
Added and implemented the "OpenLink" action.
- 6:30 AM Changeset in webkit [27543] by
-
- 2 edits in trunk/WebKit/qt
Adjust the state of the reload action correctly.
- 6:30 AM Changeset in webkit [27542] by
-
- 3 edits in trunk/WebKit/qt
Initialize the undo/redo actions from QUndoStack. That automatically takes care of enabling/disabling them as well as the activation/trigger.
- 6:30 AM Changeset in webkit [27541] by
-
- 2 edits in trunk/WebKit/qt
Added undo/redo toolbar buttons, moved the location line edit into a separate toolbar.
- 6:30 AM Changeset in webkit [27540] by
-
- 4 edits in trunk/WebKit/qt
Update the editor actions when the selection changes.
- 6:29 AM Changeset in webkit [27539] by
-
- 2 edits in trunk/WebKit/qt
Added cut/copy/paste actions to the toolbar of QtLauncher
- 6:29 AM Changeset in webkit [27538] by
-
- 4 edits in trunk/WebKit/qt
Started working on keeping the state of the navigation actions up-to-date.
- 6:29 AM Changeset in webkit [27537] by
-
- 2 edits in trunk/WebKit/qt
Use the navigational web actions in the toolbar
- 6:29 AM Changeset in webkit [27536] by
-
- 4 edits in trunk/WebKit/qt
Store a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
Added QWebPageContext to hold context sensitive information (for example used by the context menu).
- 6:29 AM Changeset in webkit [27535] by
-
- 3 edits in trunk/WebKit/qt
Moved the editing actions implemented in keyPressEvent into webActionTriggered.
- 6:29 AM Changeset in webkit [27534] by
-
- 3 edits in trunk/WebKit/qt
Introduced a central virtual void webActionTriggered(WebAction action) method that is called from various
convenience methods such as cut()/copy()/paste().
- 6:29 AM Changeset in webkit [27533] by
-
- 9 edits in trunk
Restructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem don't store
QActions/QMenus anymore but just store the action type, tag, title and optionally submenu as created
in ContextMenu::populate().
For the actual Qt context menu we traverse this structure after sendContextMenuEvent and create a QMenu
out of it. That menu is currently not functional anymore though.
- 6:29 AM Changeset in webkit [27532] by
-
- 5 edits in trunk
Changed ContextMenu::setPlatformDescription for the Qt port to not show the qmenu right away
but instead just behave as a normal setter that takes ownership of the platform menu description (the qmenu).
Instead now QWebPage::contextMenuEvent() retrieves the QMenu after calling sendContextMenuEvent and calls exec()
on it.
- 6:29 AM Changeset in webkit [27531] by
-
- 6 edits in trunk
Changed to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
Call sendContextMenuEvent on the event handler from a QWidget::contextMenuEvent re-implementation instead of in mousePressEvent.
- 6:28 AM Changeset in webkit [27530] by
-
- 4 edits in trunk/WebKit/qt
Turned onLoadProgressChanged into a real private slot.
- 6:28 AM Changeset in webkit [27529] by
-
- 8 edits in trunk
Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
- 6:23 AM Changeset in webkit [27528] by
-
- 2 edits in trunk/WebKit/qt
comments on API changes that we'd like to do.
- 6:21 AM Changeset in webkit [27527] by
-
- 7 edits in trunk
Add a QWebPage::frameCreated() signal and fix DRT
The removal of createFrame in QWebPage broke the re-implementation
in DumpRenderTree. Instead emit a frameCreated() signal and
connect to it in DumpRenderTree.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 6:19 AM Changeset in webkit [27526] by
-
- 4 edits in trunk/WebKit/qt
Remove QWebPage::createFrame()
now that QWebFrame doesn't have virtual methods anymore, there
is no need for a createFrame() factory method in QWebpage.
- 6:17 AM Changeset in webkit [27525] by
-
- 8 edits in trunk
Moved all the event handlers from QWebFrame into QWebPage.
This cleans up the public API and allows us to remove the
HackWebFrame hack in DumpRenderTree.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 6:01 AM Changeset in webkit [27524] by
-
- 5 edits1 add in trunk
don't put nbsp's into the plan text paste
Fix both ClipboardQt and PasteboardQt to replace
nbsp's with spaces before putting the text onto the
native clipboard. This is consistent with Mac and Win
and fixes at least editing/pasteboard/4076267-3.html
- 6:01 AM Changeset in webkit [27523] by
-
- 1 edit110 adds in trunk/LayoutTests/platform/qt
Add now passing tests
The fix of umemcasecmp in UnicodeQt4.h fixed quite a lot
of test falures. Add these to our regression tests.
- 6:01 AM Changeset in webkit [27522] by
-
- 32 edits in trunk/LayoutTests
update test results after the last commit.
- 6:01 AM Changeset in webkit [27521] by
-
- 2 edits in trunk/JavaScriptCore
fix umemcasecmp
Pretty embarrassing bug. Has the potential to fix quite a few test failures.
- 6:00 AM Changeset in webkit [27520] by
-
- 2 edits in trunk/LayoutTests
Update the list of skipped tests.
Three more tests are passing.
- 5:45 AM Changeset in webkit [27519] by
-
- 2 edits in trunk/WebCore
Implement Pasteboard::writeImage()
- Pasteboard is now fully implemented. Copying of Images into the Clipboard is now supported.
- As with URLs we only copy into the Clipboard (and not additionally to the Selection)
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27518] by
-
- 2 edits in trunk/WebCore
Apple CodingStyle fixes
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27517] by
-
- 2 edits in trunk/WebCore
Implement Pasteboard::writeURL()
- The URL currently gets written as text/plain and text/uri-list. The win and mac port have some more types which we currently do not support. When supporting them we can use the 'titleString' as well.
- As with writeSelection we only copy into the Clipboard. We could consider copying into the Selection as well.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27516] by
-
- 2 edits in trunk/WebCore
Kill whitespace
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27515] by
-
- 2 edits in trunk/WebKit/qt
Use correct UserAgent string.
- Only have one User Agent String and this place is QWebPage
- QWebPage::open -> QWebNetworkRequest -> QWebPage::open -> ResourceRequest -> FrameLoader::load -> QWebNetworkRequest
- ResourceRequest is != 0 when getting called from WebCore, we will only do requests when coming from WebCore and then we can use the User-Agent set with the help of the FrameLoaderClient
- We might want to change QWebNetworkRequest a bit
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:18 AM Changeset in webkit [27514] by
-
- 2 edits in trunk/WebKitTools
Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
to prevent the default implementation from popping up messageboxes.
- 4:47 AM Changeset in webkit [27513] by
-
- 2 edits131 adds in trunk/LayoutTests
add more passing test cases.
- 4:47 AM Changeset in webkit [27512] by
-
- 3 edits in trunk/WebCore
Use the correct function calls to convert a selection to
HTML or plain text.
- 4:47 AM Changeset in webkit [27511] by
-
- 2 edits in trunk/WebKit/qt
remove two notImplemented() warnings, as I believe we don't
have to implement these methods. Add some (commented out)
debug code in one place.
- 4:44 AM Changeset in webkit [27510] by
-
- 2 edits in trunk
Add WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
That means that changes to the public API of the Qt port also trigger a rebuild of the tools.
- 4:33 AM Changeset in webkit [27509] by
-
- 2 edits in trunk/WebCore
Some more clipboard fixes.
We have to set things immediately on the QClipBoard if the
Clipboard object is not for dragging.
This is due to the fact that the Clipboard object might be
rather long lived if accessed through javascript (it'll only
get deleted by JS garbage collection). We have to transfer
the data over to the QClipboard before that to make things work.
Fixes editing/execCommand/copy-without-selection.html
- 2:32 AM Changeset in webkit [27508] by
-
- 2 edits in trunk/WebCore
Fix compilation on Windows with non-cygwin perl.
- 2:14 AM Changeset in webkit [27507] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Remove conflict marker.
- 1:53 AM Changeset in webkit [27506] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Corrected ChangeLog grammar.
- 1:52 AM Changeset in webkit [27505] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
because it couldn't find its resources.
- editing/resources/plaintext-pasteboard-data.dat: Removed.
- platform/mac/editing/resources: Added.
- platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.
- 12:11 AM Changeset in webkit [27504] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Brady Eidson.
- fix http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website
Test: fast/block/float/overhanging-after-height-decrease-offsets.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
LayoutTests:
Reviewed by Brady Eidson.
- test for http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website
- fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
- platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.
Nov 6, 2007:
- 11:23 PM Changeset in webkit [27503] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric.
- only collect when the heap is full, unless we have lots of extra cost garbage
1.1% SunSpider speedup.
This shouldn't hit memory use much since the extra space in those
blocks hangs around either way.
- kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::Collector::collect): Fix logic error that reversed the sense of collect's return value.
- 11:00 PM Changeset in webkit [27502] by
-
- 1 edit1 move in trunk/LayoutTests
Move a Mac-specific test to platform/mac
- editing/pasteboard/5583362.html: Removed.
- platform/mac/editing/pasteboard/5583362.html: Added.
- 10:03 PM Changeset in webkit [27501] by
-
- 3 edits in trunk/JavaScriptCore
Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider
Reviewed by Maciej
We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.
- 9:44 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:41 PM Changeset in webkit [27500] by
-
- 2 edits in trunk/WebKitTools
2007-11-06 Eric Seidel <eric@webkit.org>
- Scripts/build-testkjs: build fix... too many $$
- 9:31 PM Changeset in webkit [27499] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Sam.
<rdar://problem/5575812> REGRESSION:When using absolute positioning
with overflow:auto div, WebKit seems to add an additional 15px
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): We need to subtract off the vertical scrollbar width too.
LayoutTests:
Reviewed by Sam.
New test for <rdar://problem/5575812> REGRESSION:When using
absolute positioning with overflow:auto div, WebKit seems to add an
additional 15px
- fast/overflow/overflow-auto-position-absolute.html: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.
Test with changed results. The measurements in the rtl example now
more closely mirror the ltr example.
- platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- 9:29 PM Changeset in webkit [27498] by
-
- 5 edits in trunk/WebKit/win
Change WebLocalizableStrings to take UTF-8 C strings
This matches the way things work on the Mac, and will allow source
files containing localizable strings to be shared between Mac and
Windows. The old functions have not been removed for compatibility
reasons, but are now just wrappers around the new UTF-8 functions.
Reviewed by Ada.
- WebKit.vcproj/WebKit.def: Added new functions.
- WebKit.vcproj/WebKit_debug.def: Ditto.
- WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): Changed to take a WebCore::String representing the key. (localizedString): Refactored from WebLocalizedString. Takes a WebCore::String representing the key. (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR. (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key. (WebLocalizedLPCTSTRUTF8): Ditto. (WebLocalizedString): Changed to call localizedString. (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
- WebLocalizableStrings.h: Changed macros to use the new UTF-8 functions.
- 9:24 PM Changeset in webkit [27497] by
-
- 2 edits in trunk/WebKitTools
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
- 9:00 PM JavaScript performance improvement ideas edited by
- (diff)
- 7:01 PM Changeset in webkit [27496] by
-
- 2 edits24 moves1 add in trunk/WebKit
Move Mac files from WebKit into WebKit/mac.
- 5:13 PM Changeset in webkit [27495] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Dan Bernstein.
<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
- editing/markup.cpp: (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block that encloses the input context, unless that block is the body, which shouldn't be cloned. In that case, use regular divs, as we did before r27369.
LayoutTests:
Reviewed by Dan Bernstein.
<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
- editing/pasteboard/5583362.html: Added.
- editing/resources/plaintext-pasteboard-data.dat: Added.
- platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
- platform/mac/editing/pasteboard/5583362-expected.png: Added.
- platform/mac/editing/pasteboard/5583362-expected.txt: Added.
- 5:03 PM Changeset in webkit [27494] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by darin.
This fixes a regressed layout test for string + object
SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.
- kjs/nodes.cpp: (KJS::add): remove erroneous "fast path" for string + *
- 4:17 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:12 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:11 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:06 PM Changeset in webkit [27493] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Eric Seidel.
Added toJSNumber, a fast path for converting a JSValue to a JS number,
and deployed it in postfix expressions. In the fast case this
eliminates a call to jsNumber.
0.4% speedup on SunSpider.
- ChangeLog:
- kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::PostIncBracketNode::evaluate): (KJS::PostDecBracketNode::evaluate): (KJS::PostIncDotNode::evaluate): (KJS::PostDecDotNode::evaluate): (KJS::UnaryPlusNode::evaluate):
- kjs/value.h: (KJS::JSValue::toJSNumber):
- 4:04 PM Changeset in webkit [27492] by
-
- 2 edits in trunk/WebCore
2007-11-06 Christian Dywan <christian@twotoasts.de>
Reviewed by Darin.
Fix http://bugs.webkit.org/show_bug.cgi?id=15828
Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory
- WebCore.pro: Use sane default install paths for the gtk port.
- 4:02 PM Changeset in webkit [27491] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-06 Rodney Dawes <dobey@wayofthemonkey.com>
Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view
Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes
FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
to determine whether the given MIME type is displayable as an image or non-image.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (FrameLoaderClient::objectContentType): Change logic to match that in the Windows and Mac ports.
- 3:19 PM Changeset in webkit [27490] by
-
- 2 edits in trunk/LayoutTests
Correct test results.
- platform/mac/fast/layers/layer-visibility-expected.txt:
- 3:00 PM Changeset in webkit [27489] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Hyatt.
Update test to cover
<rdar://problem/5521068>
Visibility not propagated correctly for children of a layer with z-index
The fix for this was (accidentally) already checked in with r27277,
with retroactive r=hyatt.
- fast/layers/layer-visibility.html:
- platform/mac/fast/layers/layer-visibility-expected.checksum:
- platform/mac/fast/layers/layer-visibility-expected.png:
- platform/mac/fast/layers/layer-visibility-expected.txt:
- 2:28 PM Changeset in webkit [27488] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5576619>
REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including both of the other deletion commands, call typingAddedToOpenCommand(), which takes the command's endingSelection and sets it as selection.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
- platform/mac/editing/input/5576619-expected.checksum: Added.
- platform/mac/editing/input/5576619-expected.png: Added.
- platform/mac/editing/input/5576619-expected.txt: Added.
- platform/mac/editing/input/5576619.html: Added.
- platform/mac/editing/input/text-input-controller-expected.txt:
- 1:37 PM Changeset in webkit [27487] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15846 REGRESSION (r27387): Memory corruption when running fast/js/kde/delete.html
There was a mistake in the algorithm used to find an empty slot in the property
map entries vector; when we were putting in a new property value and not overwriting
an existing deleted sentinel, we would enlarge the entries vector, but would not
overwrite the stale data that's in the new part. It was easy to pin this down by
turning on property map consistency checks -- I never would have landed with this
bug if I had run the regression tests once with consistency checks on!
- kjs/property_map.cpp: (KJS::PropertyMap::put): Changed logic for the case where foundDeletedElement is false to always use the item at the end of the entries vector. Also allowed me to merge with the logic for the "no deleted sentinels at all" case.
- 1:03 PM Changeset in webkit [27486] by
-
- 4 edits6 adds in trunk
WebCore:
Reviewed by Antti Koivisto and Dave Hyatt.
- fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
Test: fast/block/float/overhanging-after-height-decrease.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): If after calculating the height it turns out that there are overhanging floats that were not overhanging before, rescan children with overhanging floats and add them. (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that returns the lowest float bottom of any of the children. (WebCore::RenderBlock::addOverhangingFloats): Changed to return the lowest float bottom.
- rendering/RenderBlock.h:
LayoutTests:
Reviewed by Antti Koivisto and Dave Hyatt.
- test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
- fast/block/float/overhanging-after-height-decrease.html: Added.
- platform/mac-leopard/fast/block: Added.
- platform/mac-leopard/fast/block/float: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
- platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.
- 11:53 AM Changeset in webkit [27485] by
-
- 8 edits4 adds in trunk
WebCore:
Reviewed by Darin.
Switched all uses of HTMLImageLoader to use OwnPtrs.
- html/HTMLInputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
- html/HTMLObjectElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach):
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::detach): (WebCore::HTMLVideoElement::parseMappedAttribute):
LayoutTests:
Reviewed by Darin.
Added test for poster attribute.
- media/content/abe.png: Added.
- media/content/greenbox.png: Added.
- media/video-poster-expected.txt: Added.
- media/video-poster.html: Added.
- 11:49 AM Changeset in webkit [27484] by
-
- 2 edits in trunk/JavaScriptCore
Fix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.
RS=Darin
- 11:34 AM Changeset in webkit [27483] by
-
- 2 edits in trunk/JavaScriptCore
Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.
Reviewed by Darin
- 10:56 AM Changeset in webkit [27482] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by darin.
SunSpider claims this is a 1.1% speedup.
- kjs/nodes.cpp: (KJS::throwOutOfMemoryError): Added, non inline. (KJS::addSlowCase): renamed from add(), non inline. (KJS::add): add fast path for String + String, Number + Number and String + *
- 10:43 AM Changeset in webkit [27481] by
-
- 4 edits in trunk/WebKit/win
Reviewed by Adam and Steve.
- added hooks needed to implement showModalDialog on Windows
- Interfaces/IWebUIDelegate.idl: Added canRunModal, createModalDialog, and runModal functions to the end of IWebUIDelegate3.
- WebChromeClient.h: Added uiDelegate and uiDelegate2 helper functions, so it's easier to write client functions.
- WebChromeClient.cpp: (WebChromeClient::createWindow): Implemented dialog case. Calls IWebUIDelegate3. (WebChromeClient::canRunModal): Implemented. Calls IWebUIDelegate3. (WebChromeClient::runModal): Ditto. (WebChromeClient::uiDelegate): Added. (WebChromeClient::uiDelegate2): Added. (WebChromeClient::uiDelegate3): Added.
- 10:11 AM Changeset in webkit [27480] by
-
- 5 edits6 adds in trunk
WebCore:
Reviewed by Darin.
Trigger media load on on src attribute changes as specified in new HTML5 draft.
Tests: media/video-src-change.html
media/video-src-remove.html
media/video-src-set.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged):
- html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Darin.
Tests for media src attribute changes.
- media/video-src-change-expected.txt: Added.
- media/video-src-change.html: Added.
- media/video-src-remove-expected.txt: Added.
- media/video-src-remove.html: Added.
- media/video-src-set-expected.txt: Added.
- media/video-src-set.html: Added.
- media/video-test.js:
- 10:10 AM Changeset in webkit [27479] by
-
- 2 edits in trunk/WebKit/win
Rubber-stamped by Adam Roben.
Windows build fix.
- WebFrame.cpp: (WebFrame::string): plainText() returns a String now.
- 9:48 AM Changeset in webkit [27478] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=15838 Incomplete repaint toggling "How you know this person" on Facebook
Test: fast/repaint/make-children-non-inline.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This is needed because the inline children may be repositioned as they move into new anonymous blocks, but those blocks have no knowledge of where their children used to be, so they cannot invalidate those areas.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=15838 Incomplete repaint toggling "How you know this person" on Facebook
- fast/repaint/make-children-non-inline.html: Added.
- platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
- platform/mac-leopard/fast/repaint: Added.
- platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
- 8:07 AM Changeset in webkit [27477] by
-
- 10 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15847
Some editing cleanup
No change in functionality.
WebCore:
- editing/TextIterator.cpp: (WebCore::plainText):
- editing/TextIterator.h: Made WebCore::plainText() return String instead of DeprecatedString.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textUnderElement]): (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Updated for the above change. There is no need to explicitly convert to NSString now.
- editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually initialized in constructor body, so the work done in initializer list was wasted.
(WebCore::EditCommand::apply): Moved some stars.
(WebCore::EditCommand::unapply): Ditto.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
removed one of the checks.
- editing/SelectionController.cpp: (WebCore::SelectionController::toString): plainText() result type now matches what we need here.
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm: Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].
WebKit:
- WebView/WebHTMLView.mm: (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToEndOfParagraph:]): WebCore had a duplicate of the same logic already. We are passing a boundary value to a function that expects granularity, this may need to be straightened out in the future.
- 1:08 AM Changeset in webkit [27476] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Avoid more UString creation.
SunSpider claims this is a 0.4% speedup.
- kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): use UString::find(UChar)
Nov 5, 2007:
- 11:47 PM Changeset in webkit [27475] by
-
- 2 edits in trunk/WebCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Mac build fix.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper):
- 11:30 PM Changeset in webkit [27474] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Mac build fix.
- kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction):
- 11:20 PM Changeset in webkit [27473] by
-
- 3 edits in trunk/WebCore
Don't crash if SafariTheme can't be loaded
PlatformScrollBarSafari and RenderThemeSafari were not checking
whether SafariTheme was successfully loaded. All other uses of
SafariTheme already check this.
Reviewed by Steve.
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
- 11:20 PM Changeset in webkit [27472] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- kjs/list.h:
- 11:09 PM Changeset in webkit [27471] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Build fix. Add missing #include.
- kjs/operations.cpp:
- 10:48 PM Changeset in webkit [27470] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Remove another call to toString(exec)
SunSpider claims this is a 0.5% speedup.
- kjs/operations.cpp: (KJS::equal): remove another toString
- 10:39 PM Changeset in webkit [27469] by
-
- 1 edit6 adds in trunk/WebCore
Adding the rest of wx port's graphics impl.
Rubber-stamped by Maciej Stachowiak.
- 10:24 PM Changeset in webkit [27468] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
- kjs/operations.cpp: (KJS::equal): correct broken change.
- 10:17 PM Changeset in webkit [27467] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Remove one more call to toString(exec).
SunSpider claims this is a 0.7% speedup.
- kjs/operations.cpp: (KJS::equal): remove a call to toString()
- 9:52 PM Changeset in webkit [27466] by
-
- 11 edits4 adds in trunk/WebCore
wx port bug fixes and new files to get platform/wx building on trunk.
Rubber-stamped by Maciej Stachowiak.
- 9:43 PM Changeset in webkit [27465] by
-
- 12 edits in trunk/WebCore
Reviewed by Maciej.
Fix for <rdar://problem/5579999> Add poster attribute for video element
- html/HTMLAttributeNames.in: Added poster attribute.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Calls imageSourceAttributeName instead of having special cases for the different kinds of elements.
- dom/Element.cpp: (WebCore::Element::imageSourceAttributeName): Added.
- dom/Element.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::imageSourceAttributeName): Added.
- html/HTMLObjectElement.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieNetworkStateChanged): Calls updatePosterImage when the network state is empty and when the first frame has been loaded.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::rendererIsNeeded): Made this inline. HTMLVideoElement now also implements this.
- html/HTMLVideoElement.idl: Added case for poster attribute.
- html/HTMLVideoElement.h: Added image loader and flag to keep track of whether or not the poster image should be shown.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Initialize m_imageLoader and m_shouldShowPosterImage. (WebCore::HTMLVideoElement::rendererIsNeeded): Calls HTMLElement::rendererIsNeeded since HTMLMediaElements have renderer by default. (WebCore::HTMLVideoElement::createRenderer): Create a RenderImage or RenderVideo depending on whether or not the poster image should be shown. (WebCore::HTMLVideoElement::attach): Set up image loader and RenderImage if necessary. (WebCore::HTMLVideoElement::detach): Delete image loader if its no longer needed. (WebCore::HTMLVideoElement::parseMappedAttribute): Added case to process poster attribute. (WebCore::HTMLVideoElement::poster): Added getter for poster attribute. (WebCore::HTMLVideoElement::setPoster): Added setter for poster attribute. (WebCore::HTMLVideoElement::isURLAttribute): Added. (WebCore::HTMLVideoElement::imageSourceAttributeName): Added. (WebCore::HTMLVideoElement::updatePosterImage): Added. Updates m_shouldShowPosterImage and if its changed, detaches and attaches so the renderer is correct.
- 9:39 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:25 PM Changeset in webkit [27464] by
-
- 5 edits in trunk
Fix <rdar://5563572> SVG image support is turned off
WebCore:
Fix <rdar://5563572> SVG image support is turned off
Turned on SVG images for all platforms.
Reviewed by Eric.
- WebCore.vcproj/WebCore.vcproj: Added SVGImage.{cpp,h}
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Removed platform checks for SVGImage.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Eric.
- platform/win/Skipped:
- 8:55 PM Changeset in webkit [27463] by
-
- 2 edits in trunk/WebCore
Fix spelling errors in ChangeLogs, no review
- 8:43 PM Changeset in webkit [27462] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
QTMovieView can generate callbacks during paint. This can lead to crashes.
Delay callbacks so they get handled after painting is completed. No test case,
I don't know how to reliably reproduce this.
- platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::paint): (-[WebCoreMovieObserver initWithCallback:WebCore::]): (-[WebCoreMovieObserver disconnect]): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setDelayCallbacks:]):
- 8:12 PM Changeset in webkit [27461] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam.
Add some missing WebCore* prefixes to ObjC classes
- platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::createCFData):
- platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
- 6:53 PM Changeset in webkit [27460] by
-
- 3 edits in trunk/WebKit/gtk
2007-11-05 Christian Dywan <christian@twotoasts.de>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15409
FrameLoaderClientGtk hardcodes data, including platform to Linux i686
Compute a proper user agent string.
Patch includes fixes by Alp.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::agentPlatform): (WebKit::agentOS): (WebKit::composeUserAgent): (WebKit::FrameLoaderClient::userAgent):
- WebCoreSupport/FrameLoaderClientGtk.h:
- 6:10 PM Changeset in webkit [27459] by
-
- 6 edits in trunk
<rdar://problem/5579772> Regression: AltGr does not work
Testing whether alt-key is down is not the right test for system key event.
Added a m_isSystemKey flag in PlatformKeyboardEvent to keep track of whether
this is a system key event, check that flag instead in handleEditingKeyboardEvent().
Reviewed by Oliver.
- 4:35 PM Changeset in webkit [27458] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- pcre/pcre.pri:
- 4:02 PM Changeset in webkit [27457] by
-
- 2 edits in trunk/WebKit/win
Build fix.
Reviewed by Tristan.
- WebChromeClient.h:
- 3:56 PM Changeset in webkit [27456] by
-
- 3 edits in trunk/WebKitLibraries
Reviewed by Sam.
Update WKQTMovieViewSetDrawSynchronously.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:21 PM Changeset in webkit [27455] by
-
- 2 edits in trunk/WebKit
- WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
Teeny style tweak to test svn access on other machine
- 3:12 PM Changeset in webkit [27454] by
-
- 2 edits in trunk/WebKit
- WebView/WebView.mm: (-[WebView computedStyleForElement:pseudoElement:]):
Teeny style tweak to test svn access
- 3:05 PM Changeset in webkit [27453] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/list.cpp:
- 2:43 PM Changeset in webkit [27452] by
-
- 23 edits in trunk
qt:
Reviewed by Darin Adler.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
- WebCoreSupport/ChromeClientQt.h: Revised to use new WebCore ChromeClient createWindow API.
WebCore:
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Set WindowFeatures.h as a Private header.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Revised to use a single createWindow function instead of two createWindow functions and one createModalDialog function. The logic for this is now addressed in WebKit in an effort to make this easier to follow.
- page/Chrome.cpp: (WebCore::Chrome::createWindow):
- page/Chrome.h:
- page/ChromeClient.h:
- page/ContextMenuController.cpp: (WebCore::openNewWindow):
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): Revised to take new additional windowFeatures parameter.
WebKit:
Reviewed by Darin Adler.
- DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]): Forward the UI delegate to call webView:createWebViewWithRequest: if this method doesn't exist.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
- WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome. Removed createModalDialog to use new createWindow function.
- WebView/WebUIDelegatePrivate.h: Added new webView:createWebViewWithRequest:windowFeatures: method.
win:
Reviewed by Darin Adler.
Part of the WebKit/WebCore API changes for
<rdar://problem/5368188>
- WebChromeClient.cpp: (WebChromeClient::createWindow): Removed usage of createModalDialog and revised to use new createWindow ChromeClient API.
- 2:02 PM Changeset in webkit [27451] by
-
- 2 edits in trunk/JavaScriptCore
Touched a file to test my new HTTP access.
- kjs/scope_chain.cpp:
- 1:56 PM Changeset in webkit [27450] by
-
- 1 edit1 add in trunk/JavaScriptGlue
Build fix.
- ForwardingHeaders/kjs/value.h: Added.
- 1:35 PM Changeset in webkit [27449] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Alp Toker <alp@atoker.com>
Unreviewed build fix for qmake-based ports.
Someone with a better understanding of qmake still needs to sort out
the INCLUDEPATH/DEPENDPATH mess.
- JavaScriptCore.pri:
- 1:27 PM Changeset in webkit [27448] by
-
- 15 edits1 add in trunk
Reviewed by Darin Adler.
Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.
Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.
- kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function calls and memory accesses.
- kjs/bool_object.cpp: (BooleanObjectImp::construct): Removed questionable use of iterator.
- kjs/list.cpp:
- kjs/list.h: New List class, implemented in terms of Vector. Two
interesting differences:
- The inline capacity is 8, not 5. Many of the Lists constructed during a SunSpider run are larger than 5; almost none are larger than 8.
- The growth factor is 4, not 2. Since we can guarantee that Lists aren't long-lived, we can grow them more aggressively, to avoid excessive copying.
- kjs/regexp_object.cpp: (RegExpObjectImp::construct): Removed redundant function calls.
- kjs/string_object.cpp: (KJS::StringObjectImp::construct): Removed questionable use of iterator.
- wtf/Vector.h: (WTF::::uncheckedAppend): Added a fast, unchecked version of append.
WebCore:
Reviewed by Darin Adler.
Small adaptations to new KJS::List class.
- bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::ScheduledAction):
WebKit:
Reviewed by Darin Adler.
Small adaptations to new KJS::List class.
- ForwardingHeaders/kjs/value.h: Added.
- 1:09 PM Changeset in webkit [27447] by
-
- 3 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.
- JavaScriptCore.pri:
- pcre/pcre.pri:
- 10:57 AM Changeset in webkit [27446] by
-
- 3 edits in trunk/WebKitTools
Add support on Windows for WEBKIT_TESTFONTS
This environment variable lets you specify where the fonts to be used
by DumpRenderTree reside. The Qt port is already using this, so I'm
just following their lead.
Reviewed by Darin.
- DumpRenderTree/win/DumpRenderTree.cpp: (exePath): Refactored code out of initialize(). (fontsPath): Returns either $WEBKIT_TESTFONTS or DumpRenderTree.resources. (initialize): Use the new fontsPath function. (main): Use the new exePath function.
- Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment variable to DRT, like Qt does.
- 10:57 AM Changeset in webkit [27445] by
-
- 4 edits in trunk/WebKit/win
Add IWebCache::disabled
This matches the Mac WebCache class.
Reviewed by Sam.
- Interfaces/IWebCache.idl:
- WebCache.cpp: (WebCache::disabled):
- WebCache.h:
- 10:57 AM Changeset in webkit [27444] by
-
- 9 edits3 adds in trunk
Add IWebInspector and a way to get one from a WebView
WebCore:
Allow passing a base class pointer to COMPtr::copyRefTo
Reviewed by Sam.
- platform/win/COMPtr.h:
WebKit/win:
Add IWebInspector and a way to get one from a WebView
This API matches the Mac one added in r27266.
Reviewed by Sam.
- Interfaces/IWebInspector.idl: Added.
- Interfaces/IWebViewPrivate.idl: Added a new inspector method to match Mac.
- WebInspector.cpp: Added. (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::~WebInspector): (WebInspector::webViewClosed): (WebInspector::QueryInterface): (WebInspector::AddRef): (WebInspector::Release): (WebInspector::show): (WebInspector::showConsole): (WebInspector::showTimeline): (WebInspector::close): (WebInspector::attach): (WebInspector::detach):
- WebInspector.h: Added.
- WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
- WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
- WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
- WebView.cpp: (WebView::close): Notify the WebInspector that we're closing. (WebView::inspector): Added.
- WebView.h:
- 10:56 AM Changeset in webkit [27443] by
-
- 2 edits in trunk/WebKit/win
Cache strings that come directly from WebLocalizedString
Reviewed by Steve.
- WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): This used to be WebLocalizedString, but is now just a static helper function. (findCachedStringInMap): Added static helper. (findCachedString): Refactored and cleaned up code from WebLocalizedLPCTSTR. (cacheString): Ditto. (WebLocalizedString): Rewrote to use the new helper functions. (WebLocalizedLPCTSTR): Changed to use the new helper functions.
- 10:55 AM Changeset in webkit [27442] by
-
- 2 edits in trunk/WebKit/win
Only override the default user agent string if we're actually given a custom one
Reviewed by Sam.
- WebView.cpp: (WebView::setCustomUserAgent):
- 10:52 AM Changeset in webkit [27441] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace
Test: fast/dom/class-all-whitespace.html
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Check if there is any non-whitespace character in the class attribute.
LayoutTests:
Reviewed by Oliver Hunt.
- test that an all-whitespace class attribute does not cause an assertion failure
- fast/dom/class-all-whitespace-expected.txt: Added.
- fast/dom/class-all-whitespace.html: Added.
- 10:23 AM Changeset in webkit [27440] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam
Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
of the sql storage API
- storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::allowTransaction):
- storage/DatabaseAuthorizer.h:
- 8:34 AM Changeset in webkit [27439] by
-
- 2 edits in trunk/WebCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Have getMIMETypeForExtension return a null string when no MIME type is known
for the extension rather than returning "text/plain". This prevents plugin data
being dumped into object elements when plugins are disabled.
- platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 7:01 AM Changeset in webkit [27438] by
-
- 2 edits in trunk/WebKitTools
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
- GtkLauncher/main.cpp: (goToURLBarText): (main):
- 6:39 AM Changeset in webkit [27437] by
-
- 3 edits in trunk/WebKit/gtk
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove unused m_firstData member from FrameLoaderClientGtk.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
- 6:39 AM Changeset in webkit [27436] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Fix http://bugs.webkit.org/show_bug.cgi?id=15842
Bug 15842: [Gtk] about:blank doesn't work
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to get work done that is normally done when the first bit of data is received, even in the case of a document with no data (like about:blank).
- 6:30 AM Changeset in webkit [27435] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc
- fast/dom/Document/early-document-access.html: Don't check for open() timeout; wait for popup window to close as long as it takes.
Nov 4, 2007:
- 10:38 PM Changeset in webkit [27434] by
-
- 2 edits in trunk/WebKitTools
bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<http://bugs.webkit.org/show_bug.cgi?id=15830>
Reviewed by Timothy.
Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.
Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer
Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer
- Scripts/bisect-builds: (findMacOSXVersion): Added. (makeNightlyList): Added argument to provide version of Mac OS X. Restrict range of nightly builds based on Safari and Mac OS X versions.
- 5:37 PM Changeset in webkit [27433] by
-
- 4 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
- platform/SecurityOrigin.h:
- 4:20 PM Changeset in webkit [27432] by
-
- 1 edit29 adds in trunk/WebKitSite
Land the HTML Editing Toolbar demo from WWDC 2007.
- demos: Added.
- demos/editingToolbar: Added.
- demos/editingToolbar/FancyToolbar.css: Added.
- demos/editingToolbar/FancyToolbar.js: Added.
- demos/editingToolbar/FancyToolbarImages: Added.
- demos/editingToolbar/FancyToolbarImages/button.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/camera.png: Added.
- demos/editingToolbar/FancyToolbarImages/link.png: Added.
- demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
- demos/editingToolbar/content.html: Added.
- demos/editingToolbar/images: Added.
- demos/editingToolbar/images/safari.png: Added.
- demos/editingToolbar/index.html: Added.
- 4:09 PM Changeset in webkit [27431] by
-
- 7 edits3 adds in trunk/WebCore
Reviewed by Adam.
Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=15834
- Broke up DocumentPanel and added three SidebarPane sub-classes.
- Fixed many Style pane bugs, including:
- Poor handling of duplicate properties in the same rule. Some of this can't be fixed since we can't only get the "winning" value for duplicate properties. So we should only show one entry per unique property name.
- Computed style does not show font shorthand sub-properties if 'font' was used.
- Property priority was broken, the wrong properties were crossed out.
- The 'border' shorthand shows null for the shorthand value.
- Shorthands didn't show their priority (e.g. !important).
- HSL and HTML hex colors didn't have preview swatch blocks.
- Code refactoring, making it easier to reuse for console.log later.
- page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate classes in new files.
- page/inspector/MetricsSidebarPane.js: Added.
- page/inspector/Panel.js: Remove an InspectorController.log() call.
- page/inspector/PropertiesSection.js: Add the section to the TreeOutline. So TreeElements can access properties on their section.
- page/inspector/PropertiesSidebarPane.js: Added.
- page/inspector/SidebarPane.js: Remove the explicit asignment of the onexpand and oncollapse to null. These were hiding prototypes.
- page/inspector/StylesSidebarPane.js: Added.
- page/inspector/inspector.html: Include the new script files.
- page/inspector/treeoutline.js: If a null representedObject is passed in just use a empty object.
- 2:36 PM Changeset in webkit [27430] by
-
- 9 edits in trunk/WebKitTools
Reviewed by Maciej.
- This patch involves several changes, all of them were noticed that they were needed by the work being done in WebKit to get Drosera and WebKit working together on Windows.
- The changes are: 1) Added a debugger console for output messages. 2) Drosera now listens for the WebKit server (before, the server would have to be running before Drosera was started.) 3) Fixed a bug where the WebView started out as 0x0 pixels. 4) Fixed a bug when there is no scope. 5) Added the HTML, JS, and CSS to the project file to make them easy to find. 6) Made the ServerConnection functions virtual.
- Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens for the WebKit server. (DebuggerClient::DebuggerClient): (DebuggerClient::~DebuggerClient): (DebuggerClient::didFinishLoadForFrame): (DebuggerClient::serverConnected): (DebuggerClient::attemptToCreateServerConnection):
- Drosera/win/DebuggerClient.h: Ditto.
- Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no scope. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
- Drosera/win/Drosera.cpp: (_tWinMain): Added a console in debug for output messages. (Drosera::Drosera): Listen for server. (Drosera::initUI): The server now Initializes COM. (Drosera::serverConnected): Part of the listening for the server. (Drosera::attemptToCreateServerConnection): Ditto.
- Drosera/win/Drosera.h: New interface for listening for the server.
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS files to the VS project.
- Drosera/win/ServerConnection.cpp: Part of listening for the server connection. (ServerConnection::ServerConnection): (ServerConnection::attemptToCreateServerConnection):
- Drosera/win/ServerConnection.h: Ditto and virtualized the Interface methods. (ServerConnection::serverConnected):
- 2:30 PM Changeset in webkit [27429] by
-
- 1 edit in trunk/WebKitTools/FindSafari
Add svn:ignore for vcproj temp files under FindSafari.
- 12:27 PM Changeset in webkit [27428] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone
Check for !done before using objects that can be already deallocated.
- DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
- 8:46 AM Changeset in webkit [27427] by
-
- 2 edits in trunk/WebCore
Fix build when spaces appear in the WebKit source path.
Reviewed by Mark Rowe.
- bindings/scripts/IDLParser.pm: Use safer open() method which lists arguments individually and prevents the need to work around spaces in the path.
- 8:13 AM Changeset in webkit [27426] by
-
- 2 edits in trunk/WebKitSite
CIA has changed its hostname from cia.navi.cx to cia.vc
<http://bugs.webkit.org/show_bug.cgi?id=15829>
Reviewed by Mitz.
- contact.html: Updated links to CIA.
- 7:03 AM Changeset in webkit [27425] by
-
- 2 edits in trunk/WebCore
2007-11-04 Alp Toker <alp@atoker.com>
Reviewed by Alexey Proskuryakov.
Fix a crash when no clipboard text is available
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::plainText):
- 1:48 AM Changeset in webkit [27424] by
-
- 2 edits in trunk/WebKitTools
2007-11-04 Mark Rowe <mrowe@apple.com>
Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Nov 4, 2007:
- 1:58 AM Changeset in webkit [27423] by
-
- 3 edits in trunk/SunSpider
- hosted/sunspider.html: Tweaked formatting a bit.
- 1:28 AM Changeset in webkit [27422] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15826 optimize opcode loop and case insensitive ASCII compares for a 30% speedup
SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.
- pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
- pcre/pcre_compile.c: (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also added OP_NOT since there was no reason it should not be in here. (could_be_empty_branch): Ditto. (compile_branch): Streamlined all the single-character cases; there was a bit of duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed. But in particular, compile to those opcodes when the single character match is ASCII. (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
- pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from the matchframe, after I discovered that none of them needed to be saved and restored across recursive match calls. Also eliminated the ignored result field from the matchframe, since I discovered that rrc ("recursive result code") was already the exact same thing. Moved the handling of opcodes higher than OP_BRA into the default statement of the switch instead of doing them before the switch. This removes a branch from each iteration of the opcode interpreter, just as removal of "op" removed at least one store from each iteration. Last, but not least, add the OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a surrogate pair and the letter case can be handled efficiently.
- 12:54 AM Changeset in webkit [27421] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.
Nov 3, 2007:
- 11:18 PM Changeset in webkit [27420] by
-
- 7 edits4 deletes in trunk/JavaScriptCore
- fix non-Mac builds; remove some more unused PCRE stuff
- pcre/pcre_compile.c: (compile_branch): Removed branch chain and some unused ESC values. (compile_regex): Ditto. (jsRegExpCompile): Ditto.
- pcre/pcre_exec.c: (match): Removed unused branch targets. Don't use macros any more. (jsRegExpExecute): More of the same.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- pcre/pcre.pri: Ditto.
- pcre/MERGING: Removed.
- pcre/pcre_fullinfo.c: Removed.
- pcre/pcre_get.c: Removed.
- pcre/pcre_internal.h:
- pcre/ucp.h: Removed.
- 10:22 PM Changeset in webkit [27419] by
-
- 24 edits in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15821 remove unused PCRE features for speed
A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.
Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.
There's probably additional unused stuff that I haven't
deleted yet.
This does mean that our PCRE is now a fork, but I think that's
not really a big deal.
- JavaScriptCore.exp: Remove the 5 old entry points and add the 3 new entry points for WebCore's direct use of the regular expression engine.
- kjs/config.h: Remove the USE(PCRE16) define. I decided to flip its sense and now there's a USE(POSIX_REGEX) instead, which should probably not be set by anyone. Maybe later we'll just get rid of it altogether.
- kjs/regexp.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Switch to new jsRegExp function names and defines. Cut down on the number of functions used. (KJS::RegExp::~RegExp): Ditto. (KJS::RegExp::match): Ditto.
- pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta, which are unused.
- pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const, size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE, POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8, and JAVASCRIPT. These are all no longer configurable in our copy of the library.
- pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE, the include of <stdlib.h>, and most of the constants and functions defined in this header. Changed the naming scheme to use a JSRegExp prefix rather than a pcre prefix. In the future, we'll probably change this to be a C++ header.
- pcre/pcre_compile.c: Removed all unused code branches, including many whole functions and various byte codes. Kept changes outside of removal to a minimum. (check_escape): (first_significant_code): (find_fixedlength): (find_recurse): (could_be_empty_branch): (compile_branch): (compile_regex): (is_anchored): (is_startline): (find_firstassertedchar): (jsRegExpCompile): Renamed from pcre_compile2 and changed the parameters around a bit. (jsRegExpFree): Added.
- pcre/pcre_exec.c: Removed many unused opcodes and variables. Also started tearing down the NO_RECURSE mechanism since it's now the default. In some cases there were things in the explicit frame that could be turned into plain old local variables and other small like optimizations. (pchars): (match_ref): (match): Changed parameters quite a bit since it's now not used recursively. (jsRegExpExecute): Renamed from pcre_exec.
- pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR, PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED, PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS, PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes, _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop, and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
- pcre/pcre_maketables.c: Changed to only compile in dftables. Also got rid of many of the tables that we don't use.
- pcre/pcre_tables.c: Removed the unused Unicode property tables.
- pcre/pcre_ucp_searchfuncs.c: Removed everything except for _pcre_ucp_othercase.
- pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support for classes based on Unicode properties.
- wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good to eliminate this completely, but we need the regular expression code to be C++ first.
- pcre/pcre_fullinfo.c:
- pcre/pcre_get.c:
- pcre/ucp.h: Files that are no longer needed. I didn't remove them with this check-in, because I didn't want to modify all the project files.
WebCore:
Reviewed by Maciej.
- WebCore part of http://bugs.webkit.org/show_bug.cgi?id=15821 remove unused PCRE features for speed
- page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
- page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Remove use of ":digit:" syntax. This hasn't worked for some time. Use "\d" instead.
- platform/RegularExpression.h: Remove the unused cap function. We can add it back later if we find we need it.
- platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore regular expression entry point changes. (WebCore::RegularExpression::Private::~Private): Ditto. (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL. This means that regular expressions with metacharactesr like in them won't work any more with non-whole-string searches, but we don't use any regular expressions like that.
- 10:15 PM Changeset in webkit [27418] by
-
- 2 edits in trunk/WebCore
Update the link stubs to match the current build, and fix coding style issues.
Reviewed by Mark Rowe.
- 9:17 PM Changeset in webkit [27417] by
-
- 2 edits in trunk/JavaScriptGlue
Build-fix.
- UserObjectImp.cpp:
- 8:37 PM Changeset in webkit [27416] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup
It turns out that doing this check costs more than it saves.
- kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble):
- 7:21 PM Changeset in webkit [27415] by
-
- 1 edit3 adds in trunk/WebCore
wx <-> WebKit conversions for IntPoint, IntRect and FloatRect
Reviewed by Mark Rowe.
- 7:05 PM Changeset in webkit [27414] by
-
- 1 edit3 adds in trunk/WebCore
wx <-> WebKit data type conversions for Pen and Color.
Reviewed by Darin Adler.
- 6:08 PM Changeset in webkit [27413] by
-
- 31 edits in trunk
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
- API/JSCallbackConstructor.cpp: (KJS::):
- API/JSCallbackFunction.cpp: (KJS::):
- API/JSCallbackObject.cpp: (KJS::):
- bindings/objc/objc_runtime.mm:
- bindings/runtime_array.cpp:
- bindings/runtime_object.cpp:
- kjs/array_instance.cpp: (KJS::):
- kjs/array_object.cpp: (KJS::):
- kjs/bool_object.cpp:
- kjs/date_object.cpp: (KJS::):
- kjs/error_object.cpp:
- kjs/function.cpp: (KJS::):
- kjs/internal.cpp: (KJS::):
- kjs/lookup.h:
- kjs/math_object.cpp:
- kjs/number_object.cpp:
- kjs/object.h:
- kjs/regexp_object.cpp:
- kjs/string_object.cpp: (KJS::):
WebCore:
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
- bindings/js/JSDOMExceptionConstructor.cpp: (WebCore::):
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::):
- bindings/js/JSXSLTProcessor.cpp: (KJS::):
- bindings/js/kjs_css.cpp: (WebCore::):
- bindings/js/kjs_events.cpp: (WebCore::):
- bindings/js/kjs_navigator.cpp: (KJS::):
- bindings/js/kjs_window.cpp: (KJS::):
- bindings/scripts/CodeGeneratorJS.pm:
- 4:52 PM Changeset in webkit [27412] by
-
- 2 edits in trunk/JavaScriptCore
- Updated testkjs results to make the build bots green until we can fix the tests that are failing. The new failures are in DST.
- tests/mozilla/expected.html:
- 3:58 PM Changeset in webkit [27411] by
-
- 6 edits1 add in trunk/SunSpider
Reviewed by Darin.
- Add compare mode and a description of the benchmark to the hosted version.
- hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
- hosted/sunspider.html: Added intro text.
- make-hosted: Copy new file.
- resources/sunspider-compare-results.js: Made more reusable by putting the implementation in a function.
- resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode expects.
- sunspider-compare-results: Use sunspider-standalone-compare.js.
- 2:13 PM Changeset in webkit [27410] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam.
- don't print the var twice for ForInNodes with a var declaration
- kjs/nodes2string.cpp: (KJS::ForInNode::streamTo):
- 1:54 PM Changeset in webkit [27409] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Adam.
- Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 9:44 AM Changeset in webkit [27408] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of C-incompatible declaration.
- 9:42 AM Changeset in webkit [27407] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-03 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/nodes.cpp: Add missing include.
- 9:40 AM Changeset in webkit [27406] by
-
- 8 edits in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15814 <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails
These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.
- kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its new strict mode, throwing an exception if there are malformed UTF-16 surrogate pairs in the text.
- kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
- kjs/ustring.cpp: (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while those might be illegal in some sense, they aren't supposed to get any special handling in the place where this function is currently used. (KJS::UString::UTF8String): Added the strictness.
LayoutTests:
Reviewed by Maciej.
- updates for http://bugs.webkit.org/show_bug.cgi?id=15814 <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails
- fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better, and use the should functions in a way that makes failures easier to understand.
- fast/js/kde/encode_decode_uri-expected.txt: Updated.
- 9:28 AM Changeset in webkit [27405] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15812 some JavaScript tests (from the Mozilla test suite) are failing
Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.
- kjs/interpreter.h: (KJS::Interpreter::builtinRegExp): Made this inline and gave it a more specific type. Some day we should probably do that for all of these -- might even get a bit of a speed boost from it.
- kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's inline in the header.
- kjs/regexp_object.h:
- kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the switch statement into the RegExpImp object, so they can be shared with RegExpImp::callAsFunction. (KJS::RegExpImp::match): Added. Common code used by both test and exec. (KJS::RegExpImp::test): Added. (KJS::RegExpImp::exec): Added. (KJS::RegExpImp::implementsCall): Added. (KJS::RegExpImp::callAsFunction): Added. (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize lastInput to null rather than empty string -- we take advantage of the difference in RegExpImp::match. (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables just to get at a field like this.
- pcre/pcre_compile.c: (check_escape): Changed the \u handling to match the JavaScript specification. If there are not 4 hex digits after the \u, then it's processed as if it wasn't an escape sequence at all.
- pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition for JavaScript (4 specific Unicode values).
- pcre/pcre_exec.c: (match): Changed all call sites to use IS_NEWLINE. (pcre_exec): Ditto.
- tests/mozilla/expected.html: Updated to expect 7 more successful tests.
- 8:52 AM Changeset in webkit [27404] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Mark Rowe.
Restore correct double and triple click behaviour
We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.
- 8:26 AM Changeset in webkit [27403] by
-
- 8 edits in trunk/WebCore
Build fixes to get wx impls. building on trunk.
Reviewed by Mark Rowe.
- 8:10 AM Changeset in webkit [27402] by
-
- 14 edits in trunk
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- WebCore.xcodeproj/project.pbxproj:
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- WebKit.xcodeproj/project.pbxproj:
WebKitTools:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- Drosera/mac/Drosera.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 7:57 AM Changeset in webkit [27401] by
-
- 4 edits in trunk/WebCore
Coding style fixes for platform/wx files.
Reviewed by Mark Rowe.
- 7:33 AM Changeset in webkit [27400] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
Implement platform scrollbar static width/height getters
- 7:33 AM Changeset in webkit [27399] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Cast function pointers to gpointer.
- 7:33 AM Changeset in webkit [27398] by
-
- 4 edits2 adds in trunk/WebCore
Reviewed by Adam Roben.
RenderThemeGtk implementation based on Mozilla's GTK+ style code
There is still work needed to complete this feature.
- 7:33 AM Changeset in webkit [27397] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Do not allow scrollbars to handle wheel events
We bubble the wheel event up so the parent can handle it instead.
- 7:32 AM Changeset in webkit [27396] by
-
- 7 edits in trunk
Reviewed by Mark Rowe.
Frame scrolling and invalidation fixes
Make upward scroll events have a positive delta to match other ports.
Fix the invalidation rect offset for frames so that scrolling works properly.
Avoid allocating negative sizes to widgets to avoid GTK+ warnings.
Allow tabbing to all widgets and links.
Fix event returns, improving the focus situation and correcting scroll wheel
behavior.
- 6:35 AM Changeset in webkit [27395] by
-
- 27 edits in trunk
WebCore:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
- bindings/js/JSSVGTransformListCustom.cpp:
- ksvg2/svg/SVGException.idl:
- ksvg2/svg/SVGTextPathElement.cpp:
- ksvg2/svg/SVGTextPathElement.h:
- ksvg2/svg/SVGViewSpec.cpp:
- ksvg2/svg/SVGViewSpec.h:
- platform/mac/FontCustomPlatformData.cpp:
- platform/mac/FontCustomPlatformData.h:
- platform/mac/FontPlatformDataMac.mm:
- platform/win/FontCustomPlatformData.cpp:
- platform/win/FontCustomPlatformData.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTextPath.cpp:
- rendering/RenderSVGTextPath.h:
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp:
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGCharacterLayoutInfo.cpp:
- rendering/SVGCharacterLayoutInfo.h:
- rendering/SVGRenderSupport.cpp:
- rendering/SVGRenderSupport.h:
WebKitSite:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
- blog/wp-includes/class-snoopy.php:
- blog/wp-includes/gettext.php:
- blog/wp-includes/streams.php:
- 3:09 AM Changeset in webkit [27394] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::VarDeclNode::optimizeVariableAccess): (KJS::VarDeclNode::getDeclarations): (KJS::VarDeclNode::handleSlowCase): (KJS::VarDeclNode::evaluateSingle): (KJS::VarDeclNode::evaluate): (KJS::VarStatementNode::execute):
- kjs/nodes.h: (KJS::VarDeclNode::): (KJS::VarStatementNode::):
- kjs/nodes2string.cpp: (KJS::VarDeclNode::streamTo):
- 1:36 AM Changeset in webkit [27393] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks
- kjs/regexp_object.h: (KJS::RegExpImp::setRegExp): (KJS::RegExpImp::regExp): (KJS::RegExpImp::classInfo):
- kjs/regexp_object.cpp: (RegExpImp::RegExpImp): (RegExpImp::~RegExpImp): Renamed reg member variable to m_regExp, changed it to use OwnPtr.
- 12:27 AM Changeset in webkit [27392] by
-
- 4 edits in trunk
Versioning.
Nov 2, 2007:
- 11:58 PM Changeset in webkit [27391] by
-
- 1 edit1 add in trunk/WebKitTools
Script to sort "files(...);" sections in Xcode project.pbxproj files.
Rubber-stamped by Darin.
- Scripts/sort-Xcode-project-file: Added.
- 9:17 PM Changeset in webkit [27390] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Adam.
Add video width/height DOM and content attributes from latest HTML5 draft.
Test: media/video-width-height.html
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): (WebCore::HTMLVideoElement::width): (WebCore::HTMLVideoElement::setWidth): (WebCore::HTMLVideoElement::height): (WebCore::HTMLVideoElement::setHeight):
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.idl:
LayoutTests:
Reviewed by Adam.
Test for video width/height DOM and content attributes.
- media/video-width-height-expected.txt: Added.
- media/video-width-height.html: Added.
- 8:24 PM Changeset in webkit [27389] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStacks): (KJS::statementListInitializeVariableAccessStack): (KJS::statementListExecute): (KJS::BlockNode::BlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::ProgramNode::ProgramNode):
- kjs/nodes.h: (KJS::CaseClauseNode::):
- 5:48 PM Changeset in webkit [27388] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- DerivedSources.make: Remove a few explicit filenames from some rules by using make variables a little more.
- WebCore.LP64.exp: Fix typo, grammar.
- 5:46 PM Changeset in webkit [27387] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15791 change property map data structure for less memory use, better speed
The property map now has an array of indices and a separate array of
property map entries. This slightly slows down lookup because of a second
memory acess, but makes property maps smaller and faster to iterate in
functions like mark().
SunSpider says this is 1.2% faster, although it makes the bitwise-end test
more than 10% slower. To fix that we'll need to optimize global variable lookup.
- kjs/property_map.cpp: (KJS::PropertyMapEntry::PropertyMapEntry): (KJS::PropertyMapHashTable::entries): (KJS::PropertyMapHashTable::allocationSize): (KJS::SavedProperties::SavedProperties): (KJS::SavedProperties::~SavedProperties): (KJS::PropertyMap::checkConsistency): (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::createTable): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::comparePropertyMapEntryIndices): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::restore):
- kjs/property_map.h:
- 5:39 PM Changeset in webkit [27386] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed by Darin.
Update to add WKQTMovieViewSetDrawSynchronously
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 5:30 PM Changeset in webkit [27385] by
-
- 10 edits in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15807 HashMap needs a take() function that combines get and remove
- wtf/HashMap.h: Added take function. Simplistic implementation for now, but still does only one hash table lookup.
- kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than a find followed by a remove.
WebCore:
Reviewed by Maciej.
- use the new HashMap::take function where appropriate
- bindings/js/kjs_binding.cpp: (KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad. (KJS::removeWrapper): Ditto. (KJS::removeWrappers): Ditto. (KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead of remove -- in theory ever so slightly less efficient, but I think it's fine. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove. (KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.
- bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
- bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
- page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Ditto. (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
- rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.
- 5:23 PM Changeset in webkit [27384] by
-
- 7 edits in trunk
WebCore:
Reviewed by Darin.
Enable video composition.
- WebCore.base.exp:
- platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Darin.
Add method to enable video composition.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 5:20 PM Changeset in webkit [27383] by
-
- 4 edits in trunk
SunSpider:
- sunspider: Changed "--base" to "--set-baseline".
WebKitTools:
- Scripts/run-sunspider: Changed "--base" to "--set-baseline".
- 5:15 PM Changeset in webkit [27382] by
-
- 6 edits in trunk
SunSpider:
Reviewed by Maciej.
- sunspider: Added a "--base" option that records the current test as a baseline. Moved the code to find the newest .mshark file into a function (since I needed to use it in the other script and I prefer to copy/paste a function).
- sunspider-compare-results: Added logic to compare the baseline with the last run when you don't pass any parameters.
WebKitTools:
Reviewed by Maciej.
- Scripts/run-sunspider: Pass the "--base" option through.
- Scripts/sunspider-compare-results: Don't check the number of parameters; let the real script do that. Default configuration to Release to match run-sunspider so we don't end up building Debug just to compare results.
- 4:16 PM Changeset in webkit [27381] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
Fix compiler warning "warning: suggest parentheses around && within " - kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.
- 4:13 PM Changeset in webkit [27380] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=15806 <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements
Test: fast/forms/remove-radio-button-assert.html
- html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm): Added protected function to be used by derived classes that need to do the same sort of removal from form that's automatically done by the base class in certain circumstances.
- html/HTMLGenericFormElement.h: Added removeFromForm.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Call removeFromForm here so the element is removed before we destroy the HTMLInputElement part of this object. By the time we get to the base class's destructor it's too late. The problem is specific to radio buttons so we don't have to worry about other classes derived from HTMLGenericFormElement.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=15806 <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements
- fast/forms/remove-radio-button-assert-expected.txt: Added.
- fast/forms/remove-radio-button-assert.html: Added.
- 4:11 PM Changeset in webkit [27379] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
- speculative fix for http://bugs.webkit.org/show_bug.cgi?id=15805 <rdar://problem/5510779> crashes in isLoadingMultipartContent
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Instead of asserting the frame loader is non-0, return false if it is 0.
- 4:08 PM Changeset in webkit [27378] by
-
- 10 edits in trunk
WebCore:
Reviewed by Mitz.
- fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
Already covered by existing tests (that had incorrect results).
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate failure when both URL and MIME type are empty. The old code would not attempt a load, but it would indicate success.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove non-helpful early exit for the case where there is no URL and no type. Returning early prevents the fallback code from running.
WebKit:
Reviewed by Mitz.
- fix problem I ran into while doing some testing on Mac for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.
- Plugins/WebNullPluginView.h: Removed some unneeded declarations, including the didSendError local variable. Instead we just set the error to nil once we've sent it.
- Plugins/WebNullPluginView.mm: (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that the null plug-in image code is separate from the rest of the function and so that the whole thing is not inside an if statement. Also don't hold a reference to the DOM element if there is no error to report. (-[WebNullPluginView reportFailure]): Added. Does the actual delegate callback. Happens back at the top level of the run loop so it doesn't fire deep inside layout. Also wrote this so that it is guaranteed not to reenter and so that it can handle the case where the delegate destroys the world (including this object). NOTE: This is not a real, general solution to the problem of plug-ins that do work inside layout. We will need a more general fix that works for other plug-ins, and we'll track that with a separate bug report. (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code; changed so it just does a performSelector:afterDelay:0.
LayoutTests:
Reviewed by Mitz.
- update tests affected by fix for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
- dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
- fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank space renders now.
- platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.
- 2:51 PM Changeset in webkit [27377] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
Include Cairo headers properly
- 7:07 AM Changeset in webkit [27376] by
-
- 2 edits in trunk/WebKit
2007-11-02 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates in the page coordinate system rather than the client area coordinate system.
Nov 1, 2007:
- 11:51 PM Changeset in webkit [27375] by
-
- 4 edits in trunk
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
WebCore:
Reviewed by Alexey.
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
- platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
WebKit/win:
Reviewed by Alexey.
Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.
- WebView.cpp: (WebView::keyDown): (WebView::keyUp):
- 11:27 PM Changeset in webkit [27374] by
-
- 2 edits in trunk/WebKit
Reviewed by Oliver Hunt.
- fix an assertion failure when Command-Tabbing out of Safari
- WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to webCore.
- 5:14 PM Changeset in webkit [27373] by
-
- 17 edits in trunk
Reviewed by Maciej Stachowiak.
In preparation for making List a simple stack-allocated Vector:
Removed all instances of List copying and/or assignment, and made List
inherit from Noncopyable.
Functions that used to return a List by copy now take List& out
parameters.
Layout tests and JS tests pass.
- kjs/list.cpp: (KJS::List::slice): Replaced copyTail with a more generic slice alternative. (JavaScriptCore only calls slice(1), but WebCore calls slice(2)).
WebCore:
Reviewed by Maciej Stachowiak.
In preparation for making List a simple stack-allocated Vector:
Removed all instances of List copying, assignment, and/or storage.
Layout tests and JS tests pass.
- bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Stores a Vector of protected JSValue*'s instead of a List now. Converts to List on the fly when calling the timer function. This is slightly less efficient, but the common case is 0-2 arguments, so it's no biggie.
(HTML iBench shows no regression. PLT does not use JS timers.)
(KJS::ScheduledAction::execute): Uses the more efficient and non-copying
List::slice now.
(KJS::ScheduledAction::ScheduledAction): ditto
- bindings/objc/WebScriptObject.mm: (getListFromNSArray): Takes a List out parameter now, to avoid copying.
- 4:30 PM Changeset in webkit [27372] by
-
- 9 edits in trunk
Correct event behaviour on certain control keys
Reviewed by Geoff
Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.
- 4:10 PM Changeset in webkit [27371] by
-
- 1 edit in trunk/WebCore/page/inspector/inspector.css
Forgot part of the patch for my last change.
- 4:00 PM Changeset in webkit [27370] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- page/inspector/inspector.css: Use the white disclosure triangles when a parent DOM element is sepected.
- 3:58 PM Changeset in webkit [27369] by
-
- 5 edits in trunk
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting into a plaintext-only region, since when we build the fragment to insert from plain text, we don't put any style information on it, so it will automatically match style with no intervention.
- editing/markup.cpp: (WebCore::createFragmentFromText): Place paragraphs into clones of the block being inserted into, instead of default paragraph elements, so that when inserted content will match the surrounding paragraph style. This was broken before, but I haven't added a layout test yet because there currently isn't a way to get only plain text onto the pasteboard in a layout test.
WebKit:
Reviewed by Oliver Hunt.
<rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
No need to match style when pasting plain text, since the fragment we build for plain text
won't have any style information on it.
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no longer a need to know whether this function chosePlaintext. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _documentFragmentFromPasteboard:]):
- 3:54 PM Changeset in webkit [27368] by
-
- 2 edits in trunk/WebKit/win
- Fixed a build failure
- WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
- 3:31 PM Changeset in webkit [27367] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Add a releaseRef method to COMPtr which matches the behavior
of the method by the same name in PassRefPtr. This is in
preparation of adding autogenerated COM DOM bindings.
- platform/win/COMPtr.h: (COMPtr::releaseRef):
- 3:28 PM Changeset in webkit [27366] by
-
- 2 edits4 moves in trunk
WebCore:
wx impl. for DragController and EventHandler interfaces.
Reviewed by Adam Roben.
- page/wx: Added.
- page/wx/DragControllerWx.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
- page/wx/EventHandlerWx.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard):
LayoutTests:
- fix typo in test name
- fast/repaint/layout-state-only-posiitoned.html: Removed.
- fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
- platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
- platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
- platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.
- 2:43 PM Changeset in webkit [27365] by
-
- 1 edit3 adds in trunk/WebCore
wx impl. for DragController and EventHandler interfaces.
Reviewed by Adam Roben.
- 2:36 PM Changeset in webkit [27364] by
-
- 1 edit2 adds in trunk/WebCore
Adding files for wx impl. of editing interfaces.
Reviewed by Adam Roben.
- 2:33 PM Changeset in webkit [27363] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam Roben.
Make implicit conversions from LPCSTRs and BSTRs to WebCore string
types possible in preparation of adding autogenerated COM DOM bindings.
- platform/AtomicString.cpp: (WebCore::AtomicString::add):
- platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
- platform/PlatformString.h:
- platform/win/BString.cpp: (WebCore::BString::BString):
- platform/win/BString.h:
- 2:15 PM Changeset in webkit [27362] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders
Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::SQLiteTransaction): (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin): (WebCore::SQLiteTransaction::commit): (WebCore::SQLiteTransaction::rollback):
- platform/sql/SQLiteTransaction.h: (WebCore::SQLiteTransaction::inProgress):
- 2:01 PM Changeset in webkit [27361] by
-
- 2 edits in trunk/WebCore
Remove all duplicate xcopy commands from WebCore's post-build step
Also add the /d option to the copy of platform/sql.
Rubberstamped by Sam.
- WebCore.vcproj/WebCore.vcproj:
- 2:00 PM Changeset in webkit [27360] by
-
- 2 edits in trunk/WebKitTools
Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
Reviewed by Sam.
- Scripts/commit-log-editor: Show all the directories beneath the source root, instead of just the last one.
- 1:50 PM Changeset in webkit [27359] by
-
- 5 edits2 adds in trunk
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com
Reverted a small portion of my last check-in. (The speedup and the List
removal are still there, though.)
ActivationImp needs to hold a pointer to its function, and mark that
pointer (rather than accessing its function through its ExecState, and
counting on the active scope to mark its function) because a closure
can cause an ActivationImp to outlive its ExecState along with any
active scope.
- kjs/ExecState.cpp: (KJS::ExecState::ExecState):
- kjs/function.cpp: (KJS::FunctionImp::~FunctionImp): (KJS::ActivationImp::ActivationImp):
- kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):
Also made HashTable a little more crash-happy in debug builds, so
problems like this will show up earlier:
- wtf/HashTable.h: (WTF::HashTable::~HashTable):
LayoutTests:
Reviewed by Maciej Stachowiak.
Layout test for http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com
- fast/js/activation-object-function-lifetime-expected.txt: Added.
- fast/js/activation-object-function-lifetime.html: Added.
- 1:35 PM Changeset in webkit [27358] by
-
- 2 edits in trunk/WebKitSite
Rubber-stamped by Tim Hatcher.
- misc/DatabaseExample.html: Speed up default close speed to .25s
- 1:28 PM Changeset in webkit [27357] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Adam Roben.
- Don't show the close button on the notes unless hovering over the note.
- Do transformation and fade when closing a note using the new transition properties.
- misc/DatabaseExample.html:
- 1:23 PM Changeset in webkit [27356] by
-
- 3 edits in trunk/WebKit/win
Fix the parameter type of WebLocalizedString to match the UI_STRING macro
Reviewed by Sam.
- WebLocalizableStrings.cpp: (WebLocalizedString): (WebLocalizedLPCTSTR):
- WebLocalizableStrings.h:
- 12:01 PM Changeset in webkit [27355] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Add support for the animation of the -webkit-border-raduis properties.
- page/AnimationController.cpp: (WebCore::blendFunc): Added for IntSize. (WebCore::ImplicitAnimation::animate): Added cases for border radius properties.
- 11:37 AM Changeset in webkit [27354] by
-
- 2 edits in trunk/WebCore
2007-11-01 Alp Toker <alp@atoker.com>
Reviewed by Mitz Pettel.
Fix an unbalanced save/restore.
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 11:28 AM Changeset in webkit [27353] by
-
- 2 edits in trunk/WebCore
Add support for the animation of the visibility property.
Reviewed by oliver, aroben
- page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
- 10:13 AM Changeset in webkit [27352] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- Made COMPtr be able to be used by certain other templates, specifically HashSet.
- platform/win/COMPtr.h: (WTF::):
- 8:30 AM Changeset in webkit [27351] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15015 <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
Test: fast/repaint/overflow-clip-subtree-layout.html
This patch does not address the bigger issue of doing a full relayout
of inline flows containing floats, but it addresses the problem on
aol.com, where the changes that trigger layout are confined to an
overflow area inside the float.
- page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old layout roots are different but one descends from the other, make (or keep) the ancestor as the layout root.
- rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Made boxes with overflow clipping and non-auto width and height relayout boundaries.
LayoutTests:
Reviewed by Dave Hyatt.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=15015 <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
- fast/repaint/overflow-clip-subtree-layout.html: Added.
- platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
- platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
- platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
- 8:01 AM Changeset in webkit [27350] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Fixed line endings that got confused in this file somehow.
- platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isAttachment):
- 2:58 AM Changeset in webkit [27349] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam Roben.
Addressed some of Darin's review comments.
Used perl -p, which is the shorthand while(<>) {}.
Made sure not to suppress bison's output.
Added line to removed bison_out.txt, since this script removes other
intermediate files, too.
- DerivedSources.make:
- 2:30 AM Changeset in webkit [27348] by
-
- 3 edits in trunk/WebKitTools
2007-11-01 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Adam Roben.
Print out an error message when the Windows build fails
and provide guidance on how to find out what went wrong.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 2:30 AM Changeset in webkit [27347] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Add some more tests that r27343 fixed
- 2:29 AM Changeset in webkit [27346] by
-
- 3 edits in trunk/WebCore
2007-11-01 Peter Kasting <zerodpx@gmail.com>
Reviewed by Dave Hyatt.
http://bugs.webkit.org/show_bug.cgi?id=15778
Malformed GIFs should not result in memory corruption.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::output_row): (GIFImageReader::read):
- 2:21 AM Changeset in webkit [27345] by
-
- 4 edits in trunk
Rubber-stamped by Adam Roben.
Rolled out r27326 - debug CRT seems to cause no problems after all.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- 1:36 AM Changeset in webkit [27344] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Removed List from ActivationImp, in preparation for making all lists
stack-allocated.
Tests pass.
1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.
- kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
- kjs/function.cpp: (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::createArgumentsObject):
- kjs/function.h: (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):
- 1:28 AM Changeset in webkit [27343] by
-
- 3 edits in trunk/JavaScriptCore
Use jsNumberCell instead of jsNumber when converting double constants to JSValues
This fixes fast/js/math.html, which was suffering from a bug in MSVC.
It also gets rid of an MSVC warning that we previously had to silence.
Reviewed by Geoff.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn back on the "overflow in constant arithmetic" warning.
- kjs/number_object.cpp: (NumberObjectImp::getValueProperty): Use jsNumberCell instead of jsNumber.
Oct 31, 2007:
- 11:50 PM Changeset in webkit [27342] by
-
- 1 edit4 adds in trunk/LayoutTests
Add Windows-specific results for window-properties
HTML Timed Media elements aren't implemented yet on Windows.
- platform/win/fast/dom/Window/window-properties-expected.txt: Added.
- 11:20 PM Changeset in webkit [27341] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- kjs/ExecState.h:
- 10:05 PM Changeset in webkit [27340] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix ChangeLog entry.
- 10:02 PM Changeset in webkit [27339] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- shave some cycles off of local storage access for a 1% SunSpider speedup
Keep the LocalStorage pointer in the ExecState, not
- kjs/ExecState.cpp: (KJS::ExecState::updateLocalStorage):
- kjs/ExecState.h: (KJS::ExecState::localStorage):
- kjs/nodes.cpp: (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PreIncLocalVarNode::evaluate): (KJS::PreDecLocalVarNode::evaluate): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::AssignLocalVarNode::evaluate): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
- 8:51 PM Changeset in webkit [27338] by
-
- 3 edits2 adds in trunk
Fix a crash when parsing a cubic-bezier function
WebCore:
Fix a crash when parsing a cubic-bezier function
Reviewed by Hyatt.
Test: fast/css/parse-timing-function-crash.html
- WebCore.vcproj/WebCore.vcproj:
- css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): Don't walk off the end of the ValueList.
LayoutTests:
New test for a crash when parsing a cubic-bezier function
Reviewed by Hyatt.
- fast/css/parse-timing-function-crash-expected.txt: Added.
- fast/css/parse-timing-function-crash.html: Added.
- 8:05 PM Changeset in webkit [27337] by
-
- 2 edits in trunk/WebCore
Fix a merge error from when I applied my patch to ToT. A couple of lines should be part of an if.
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):
- 6:22 PM Changeset in webkit [27336] by
-
- 4 edits in trunk/JavaScriptCore
Fix a crash on launch due to a static initializer race
We now use fast inline assembler spinlocks which can be statically
initialized at compile time.
As a side benefit, this speeds up SunSpider by 0.4%.
Reviewed by Oliver.
- wtf/FastMalloc.cpp:
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
- wtf/TCSystemAlloc.cpp:
- 6:16 PM Changeset in webkit [27335] by
-
- 3 edits22 adds in trunk/WebCore
Reviewed by Sam.
Add new SQL callback interfaces and JS implementations of them.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomSQLStatementCallback.cpp: Added. (WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback): (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.h: Added.
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: Added. (WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback): (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.h: Added.
- bindings/js/JSCustomSQLTransactionCallback.cpp: Added. (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.h: Added.
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Added. (WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback): (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h: Added.
- storage/JSCustomSQLStatementCallback.h: Added.
- storage/JSCustomSQLStatementErrorCallback.h: Added.
- storage/JSCustomSQLTransactionCallback.h: Added.
- storage/JSCustomSQLTransactionErrorCallback.h: Added.
- storage/SQLStatementCallback.h: Added. (WebCore::SQLStatementCallback::~SQLStatementCallback):
- storage/SQLStatementCallback.idl: Added.
- storage/SQLStatementErrorCallback.h: Added. (WebCore::SQLStatementErrorCallback::~SQLStatementErrorCallback):
- storage/SQLStatementErrorCallback.idl: Added.
- storage/SQLTransaction.h: Added.
- storage/SQLTransaction.idl: Added.
- storage/SQLTransactionCallback.h: Added. (WebCore::SQLTransactionCallback::~SQLTransactionCallback):
- storage/SQLTransactionCallback.idl: Added.
- storage/SQLTransactionErrorCallback.h: Added. (WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):
- storage/SQLTransactionErrorCallback.idl: Added.
- 5:06 PM Changeset in webkit [27334] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- Corrected spelling.
- wtf/HashTraits.h:
- 4:23 PM Changeset in webkit [27333] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Harrison.
<rdar://problem/5569741> Pasting content with a line break into a list can remove the list
- editing/htmlediting.cpp: (WebCore::enclosingEmptyListItem): A single list item can contain multiple paragraphs, so if the incoming VisiblePosition is in an empty paragraph in a list item, that list item isn't necessarily empty.
LayoutTests:
Reviewed by Dave Harrison.
- editing/execCommand/5569741.html: Added.
- platform/mac/editing/execCommand/5569741-expected.checksum: Added.
- platform/mac/editing/execCommand/5569741-expected.png: Added.
- platform/mac/editing/execCommand/5569741-expected.txt: Added.
- 4:12 PM Changeset in webkit [27332] by
-
- 6 edits in trunk/WebKit
Reviewed by John Sullivan.
Move the developer extras preference to WebPreferences.
- WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
- WebView/WebPreferences.m: (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO. (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey. (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
- WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
- WebView/WebView.mm: (+[WebView _developerExtrasEnabled]): Removed. (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
- WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
- 2:19 PM Changeset in webkit [27331] by
-
- 2 edits in trunk/WebCore
Disable style sharing for animating styles.
Reviewed by mitzpettel
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
- 1:58 PM Changeset in webkit [27330] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix intermediate length calculation
- rendering/Length.h: (WebCore::Length::blend):
- 1:54 PM Changeset in webkit [27329] by
-
- 1 edit10 deletes in trunk/LayoutTests
Remove timing dependent, occasionally failing cue point tests.
Cue points will be replaced with cue ranges soon anyway.
- media/video-cuepoint-pause-expected.txt: Removed.
- media/video-cuepoint-remove-multiple-expected.txt: Removed.
- media/video-cuepoint-multiple-expected.txt: Removed.
- media/video-cuepoint-remove-expected.txt: Removed.
- media/video-cuepoint-pause.html: Removed.
- media/video-cuepoint-remove-multiple.html: Removed.
- media/video-cuepoint-multiple.html: Removed.
- media/video-cuepoint-remove.html: Removed.
- media/video-cuepoint-add-expected.txt: Removed.
- media/video-cuepoint-add.html: Removed.
- 1:07 PM Changeset in webkit [27328] by
-
- 4 edits2 adds in trunk/WebCore
Reviewed by Darin.
Add new SQLError implementation.
- DerivedSources.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/SQLError.h: Added. (WebCore::SQLError::SQLError): (WebCore::SQLError::code): (WebCore::SQLError::message):
- storage/SQLError.idl: Added.
- 11:46 AM Changeset in webkit [27327] by
-
- 2 edits in trunk/WebCore
Change the initial value of transition-property to all. Change the initial value of
transition-duration to 0.
Reviewed by antti
- rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionProperty):
- 11:33 AM Changeset in webkit [27326] by
-
- 4 edits in trunk
Switch the Debug configuration to using the non-debug CRT
WebKitTools:
Switch the Debug configuration to using the non-debug CRT
This matches WebKit.
Reviewed by Steve.
- DumpRenderTree/win/DumpRenderTree.vcproj:
WebKit/win:
Switch the Debug configuration to using the non-debug CRT
The debug CRT conflicts with what Safari uses, which causes loading
problems.
Reviewed by Steve.
- WebKit.vcproj/WebKit.vcproj:
- 9:23 AM Changeset in webkit [27325] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
The new Color must be marked valid.
- 8:16 AM Changeset in webkit [27324] by
-
- 2 edits in trunk/WebKitTools
Reviewed by bdash.
Disable media tests when doing leak checking on Tiger.
They crash in QuickTime (rdar://problem/5537157).
- Scripts/run-webkit-tests:
- 8:05 AM Changeset in webkit [27323] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-31 Mark Rowe <mrowe@apple.com>
Further Gtk build fixage.
- kjs/regexp_object.cpp:
- 7:59 AM Changeset in webkit [27322] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-31 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/regexp.h:
- 7:52 AM Changeset in webkit [27321] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Tweaked formatting of the ChangeLog a bit.
- 7:46 AM Changeset in webkit [27320] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15749 RegExp/RegExpObjectImp cause needless UString creation
Speeds things up 0.4% according to SunSpider.
- kjs/config.h: Define USE(PCRE16) instead of HAVE(PCREPOSIX), because this library doesn't use the real PCRE -- it uses its own PCRE that works on UTF-16.
- kjs/regexp.h: Removed a few unused functions. Changed the ifdef. Use Noncopyable. Change the return value of match.
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Call pcre_compile2, for a slight speed boost. (KJS::RegExp::~RegExp): PCRE16 rather than PCREPOSIX. (KJS::RegExp::match): Change to return the position as an int and the ovector as a OwnArrayPtr<int> for efficiency and clearer storage management.
- kjs/regexp_object.h: Change performMatch and arrayOfMatches to no longer require a result string.
- kjs/regexp_object.cpp: (RegExpProtoFunc::callAsFunction): Update for new signature of performMatch. (RegExpObjectImp::performMatch): Change so it doesn't return a string. (RegExpObjectImp::arrayOfMatches): Simplify by unifying the handling of the main result with the backreferences; now it doesn't need to take a result parameter. (RegExpObjectImp::getBackref): Minor tweaks. (RegExpObjectImp::getLastParen): Ditto. (RegExpObjectImp::getLeftContext): Ditto. (RegExpObjectImp::getRightContext): Ditto. (RegExpObjectImp::getValueProperty): Change LastMatch case to call getBackref(0) so we don't need a separate getLastMatch function.
- kjs/string_object.cpp: (KJS::replace): Update to use new performMatch, including merging the matched string section with the other substrings. (KJS::StringProtoFunc::callAsFunction): Update functions to use the new performMatch and match. Also change to use OwnArrayPtr.
- 4:42 AM Changeset in webkit [27319] by
-
- 2 edits in trunk/WebCore
Build fix for non-Qt builds.
- 4:18 AM Changeset in webkit [27318] by
-
- 2 edits in trunk/WebCore
Fix dependency path to header files of the public API of the Qt port.
- 4:15 AM Changeset in webkit [27317] by
-
- 3 edits in trunk/WebCore
- QXmlStreamNamespaceDeclaration doesn't have the constructor we want to use for Qt4.3. Reenable the old code path which is likely to be dead as I have not checked if m_prefixToNamespaceMap is actually used.
- Guard the entity resolver with the QT_VERSION as well.
- Partially reverts 369506279abdaa863e15efed649ca19e062f2c30 and d2b54d0fc1b07a2480f4f7a1417abd7a636b0107 for Qt4.3.
- 4:13 AM Changeset in webkit [27316] by
-
- 2 edits in trunk/WebCore
- QMimeData::removeData will be new in Qt4.4, don't use it for Qt4.3
- Provide a bad fallback implementation to filter the format list.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 4:09 AM Changeset in webkit [27315] by
-
- 2 edits in trunk/WebCore
add an entitiy resolver to QXmlStream.
Fixes fast/parser/entities-in-attributes.xhtml.
- 4:09 AM Changeset in webkit [27314] by
-
- 5 edits2 deletes in trunk
Fixes in the XML tokenizer when using QXmlStream.
Use new functionality of QXmlStream in Qt 4.4 to simplify
the code (but keep the old code for now to still support Qt 4.3).
Add proper support for namespace handling when parsing into
a document fragment.
- 4:08 AM Changeset in webkit [27313] by
-
- 4 edits in trunk/WebCore
add support for dragging images.
- 4:08 AM Changeset in webkit [27312] by
-
- 7 edits in trunk
fix most of the issues I found with Clipboard and DnD.
- 4:08 AM Changeset in webkit [27311] by
-
- 2 edits in trunk/WebKit/qt
QDrag objects need to be created on the heap.
- 4:08 AM Changeset in webkit [27310] by
-
- 2 edits in trunk/WebKit/qt
a dragLeave event is not the same as cancelling a drag.
- 4:02 AM Changeset in webkit [27309] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by NOBODY (qt buildfix)
- kjs/nodes.h: include OwnPtr.h
- 3:54 AM Changeset in webkit [27308] by
-
- 5 edits in trunk/JavaScriptCore
Remove SourceCodeElement class and replaced with a Vector for a 0.8% gain on sunspider
Reviewed by Maciej
- 3:52 AM Changeset in webkit [27307] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Oliver hasn't changed his name to ChangeLog.
- 2:47 AM Changeset in webkit [27306] by
-
- 3 edits in trunk/WebCore
2007-10-30 Mark Rowe <mrowe@apple.com>
Fix the Gtk and Qt builds by stubbing out PlatformKeyboardEvent::currentCapsLockState.
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- 2:33 AM Changeset in webkit [27305] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-30 Mark Rowe <mrowe@apple.com>
Build fix for non-Mac ports.
- kjs/property_map.cpp:
- 2:17 AM Changeset in webkit [27304] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
- fix builds
- kjs/property_map.cpp: Include HashTable.h the right way.
- 1:29 AM Changeset in webkit [27303] by
-
- 5 edits3 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11001
WebKit doesn't support RegExp.compile method
Test: fast/js/regexp-compile.html
- kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::callAsFunction):
- kjs/regexp_object.h: (KJS::RegExpProtoFunc::): Added RegExp.compile.
- tests/mozilla/expected.html: js1_2/regexp/compile.js now passes.
- 1:22 AM Changeset in webkit [27302] by
-
- 5 edits in trunk
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=15762
XSLStylesheet loads subresources from a wrong URL
Covered by corrected existing tests.
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Pass stylesheet URL, not the document one.
- 1:22 AM Changeset in webkit [27301] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by ChangeLog.
- get rid of integer divide in PropertyMap and HashTable for 1% SunSpider speedup
Integer divide sucks. Fortunately, a bunch of shifts and XORs
biased towards the high bits is sufficient to provide a good
double hash. Besides the SunSpider win, I used the dump statistics
mode for both to verify that collisions did not increase and that
the longest collision chain is not any longer.
- kjs/property_map.cpp: (KJS::doubleHash): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
- wtf/HashTable.h: (WTF::doubleHash): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
- 1:20 AM Changeset in webkit [27300] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10818
String::append does 2 full copies instead of 1 (or zero!)
No change in functionality, thus no test.
- platform/String.cpp: (WebCore::String::append): Rewrote to copy once. Also removed an ancient FIXME that doesn't seem to make any sense. Note that append() behavior doesn't match documented String behavior ("modifications to one instance will also modify all others"), but there are a lot of methods that don't.
- 12:54 AM Changeset in webkit [27299] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Add [JS]ProgressEvent.{cpp,h} files.
- 12:24 AM Changeset in webkit [27298] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- kjs/collector.h: Make HeapType public.
- 12:20 AM Changeset in webkit [27297] by
-
- 4 edits in trunk/JavaScriptCore
Change ALWAYS_INLINE and WTF_PRIVATE_INLINE to use forceinline on Windows
Speeds up SunSpider by 0.4%.
Reviewed by Steve and Maciej.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable a warning during LTCG in release builds about double -> float conversion.
- wtf/AlwaysInline.h:
- wtf/FastMalloc.h:
- 12:19 AM Changeset in webkit [27296] by
-
- 2 edits in trunk/JavaScriptCore
Use GetCurrentThreadId instead of pthread_self in FastMalloc
Speeds up SunSpider by 0.3%.
Reviewed by Steve.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitTSD): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 12:19 AM Changeset in webkit [27295] by
-
- 4 edits in trunk/JavaScriptCore
Switch to a Win32 critical section implementation of spinlocks
Speeds up SunSpider by 0.4%.
Reviewed by Steve.
- wtf/FastMalloc.cpp:
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::TCMalloc_SpinLock): (TCMalloc_SpinLock::Init): (TCMalloc_SpinLock::Finalize): (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock):
- wtf/TCSystemAlloc.cpp:
- 12:18 AM Changeset in webkit [27294] by
-
- 2 edits in trunk/JavaScriptCore
Fix Bug 15586: REGRESSION (r26759-r26785): Windows nightly builds crash with Safari 3 Public Beta
Also fixes: <rdar://5565303> Cannot use regsvr32.exe to register WebKit.dll
Use Win32 TLS functions instead of declspec(thread), which breaks
delay-loading.
Reviewed by Steve.
- wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::TCMalloc_ThreadCache::InitModule):
Oct 30, 2007:
- 11:57 PM Changeset in webkit [27293] by
-
- 3 edits in trunk/WebCore
Windows build fixes
I'm not completely sure why these const issues weren't caught by GCC,
but MSVC was certainly not happy with them.
- editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote):
- editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl):
- 11:09 PM Changeset in webkit [27292] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- allocate numbers in half-size cells, for an 0.5% SunSpider speedup http://bugs.webkit.org/show_bug.cgi?id=15772
We do this by using a single mark bit per two number cells, and
tweaking marking.
Besides being an 0.5% win overall, this is a 7.1% win on morph.
- kjs/collector.cpp: (KJS::): (KJS::Collector::heapAllocate): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::sweep):
- kjs/collector.h: (KJS::SmallCollectorCell::):
- 8:55 PM Changeset in webkit [27291] by
-
- 7 edits in trunk/WebCore
transition-property was defaulting to all when it should default to none.
It was taking a string type. I figured out how to make it take an ident instead, so you can write:
transition-property: opacity
instead of
transition-property: "opacity"
Transition layers also weren't properly repeating patterns the way they were supposed to. I fixed that.
Finally, I fixed a bug in the code to fix up transition layers where something was misplaced that should have been inside a null check.
Reviewed by aroben
- css/CSSHelper.h:
- css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
- page/AnimationController.cpp: (WebCore::ImplicitAnimation::animate):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::adjustTransitions):
- rendering/RenderStyle.h: (WebCore::RenderStyle::initialTransitionProperty):
- 8:30 PM Changeset in webkit [27290] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Leak fix
- platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::getSupportedTypes):
- 8:04 PM Changeset in webkit [27289] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Adam Roben, Sam Weinig.
Made conflicts in grammar.y a persistent build failure.
- DerivedSources.make:
- 7:47 PM Changeset in webkit [27288] by
-
- 2 edits in trunk/WebCore
Reviewed by Stephanie Lewis.
- fix <rdar://problem/5547237> REGRESSION (304-ToT): Repro font-related crash in fontdatawin.cpp Line 93 (many sites)
- platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): Handle the case where the font has no glyphs on page zero.
- 7:36 PM Changeset in webkit [27287] by
-
- 1 edit in trunk/WebCore/page/AnimationController.cpp
Fix Qt bustage in AnimationController.cpp
- 7:35 PM Changeset in webkit [27286] by
-
- 4 edits85 adds in trunk/LayoutTests
Reviewed by Maciej.
Media tests from feature branch.
- fast/dom/Window/window-properties-expected.txt: Replaced.
- fast/dom/Window/window-properties.html: Replaced.
- media: Added.
- media/audio-constructor-expected.txt: Added.
- media/audio-constructor-src-expected.txt: Added.
- media/audio-constructor-src.html: Added.
- media/audio-constructor.html: Added.
- media/content: Added.
- media/content/test.mp4: Added.
- media/content/test.wav: Added.
- media/progress-event-expected.txt: Added.
- media/progress-event.html: Added.
- media/video-append-source-expected.txt: Added.
- media/video-append-source.html: Added.
- media/video-autoplay-expected.txt: Added.
- media/video-autoplay.html: Added.
- media/video-buffered-expected.txt: Added.
- media/video-buffered.html: Added.
- media/video-cuepoint-add-expected.txt: Added.
- media/video-cuepoint-add.html: Added.
- media/video-cuepoint-multiple-expected.txt: Added.
- media/video-cuepoint-multiple.html: Added.
- media/video-cuepoint-pause-expected.txt: Added.
- media/video-cuepoint-pause.html: Added.
- media/video-cuepoint-remove-expected.txt: Added.
- media/video-cuepoint-remove-multiple-expected.txt: Added.
- media/video-cuepoint-remove-multiple.html: Added.
- media/video-cuepoint-remove.html: Added.
- media/video-currentTime-expected.txt: Added.
- media/video-currentTime-set-expected.txt: Added.
- media/video-currentTime-set.html: Added.
- media/video-currentTime-set2-expected.txt: Added.
- media/video-currentTime-set2.html: Added.
- media/video-currentTime.html: Added.
- media/video-dom-autoplay-expected.txt: Added.
- media/video-dom-autoplay.html: Added.
- media/video-dom-end-expected.txt: Added.
- media/video-dom-end.html: Added.
- media/video-dom-loopcount-expected.txt: Added.
- media/video-dom-loopcount.html: Added.
- media/video-dom-loopend-expected.txt: Added.
- media/video-dom-loopend.html: Added.
- media/video-dom-loopstart-expected.txt: Added.
- media/video-dom-loopstart.html: Added.
- media/video-dom-src-expected.txt: Added.
- media/video-dom-src.html: Added.
- media/video-dom-start-expected.txt: Added.
- media/video-dom-start.html: Added.
- media/video-end-expected.txt: Added.
- media/video-end.html: Added.
- media/video-error-abort-expected.txt: Added.
- media/video-error-abort.html: Added.
- media/video-error-does-not-exist-expected.txt: Added.
- media/video-error-does-not-exist.html: Added.
- media/video-load-networkState-expected.txt: Added.
- media/video-load-networkState.html: Added.
- media/video-load-readyState-expected.txt: Added.
- media/video-load-readyState.html: Added.
- media/video-loopcount-expected.txt: Added.
- media/video-loopcount.html: Added.
- media/video-loopend-expected.txt: Added.
- media/video-loopend.html: Added.
- media/video-loopstart-expected.txt: Added.
- media/video-loopstart.html: Added.
- media/video-muted-expected.txt: Added.
- media/video-muted.html: Added.
- media/video-no-autoplay-expected.txt: Added.
- media/video-no-autoplay.html: Added.
- media/video-seekable-expected.txt: Added.
- media/video-seekable.html: Added.
- media/video-size-expected.txt: Added.
- media/video-size.html: Added.
- media/video-source-expected.txt: Added.
- media/video-source-media-expected.txt: Added.
- media/video-source-media.html: Added.
- media/video-source-type-expected.txt: Added.
- media/video-source-type.html: Added.
- media/video-source.html: Added.
- media/video-src-expected.txt: Added.
- media/video-src-source-expected.txt: Added.
- media/video-src-source.html: Added.
- media/video-src.html: Added.
- media/video-start-expected.txt: Added.
- media/video-start.html: Added.
- media/video-test.js: Added.
- media/video-volume-expected.txt: Added.
- media/video-volume.html: Added.
- platform/qt/Skipped:
- platform/win/Skipped:
- 7:35 PM Changeset in webkit [27285] by
-
- 1 edit in trunk/WebCore/rendering/RenderStyle.cpp
Remove unused blendLengths function.
- 7:32 PM Changeset in webkit [27284] by
-
- 2 edits in trunk/WebCore
Eliminate rounding from int-based animation blending.
- 7:30 PM Changeset in webkit [27283] by
-
- 6 edits in trunk/WebCore
Make sure CSS transforms can be animated using the CSS transition property.
Reviewed by Dan and Antti
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/AnimationController.cpp: (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate):
- rendering/Length.h: (WebCore::Length::blend):
- rendering/RenderStyle.cpp: (WebCore::StyleTransformData::operator==): (WebCore::TransformOperations::operator==): (WebCore::blendLengths): (WebCore::ScaleTransformOperation::blend): (WebCore::RotateTransformOperation::blend): (WebCore::SkewTransformOperation::blend): (WebCore::TranslateTransformOperation::blend): (WebCore::MatrixTransformOperation::blend):
- rendering/RenderStyle.h: (WebCore::TransformOperations::operator!=): (WebCore::TransformOperations::isEmpty): (WebCore::TransformOperations::size): (WebCore::TransformOperations::operator[]): (WebCore::TransformOperations::append): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):
- 7:11 PM Changeset in webkit [27282] by
-
- 2 edits in trunk/WebCore
Another Qt/GTK build fix.
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- 6:51 PM Changeset in webkit [27281] by
-
- 2 edits in trunk/WebCore
Attempt to fix Qt/GTK build.
- WebCore.pro:
- 6:27 PM Changeset in webkit [27280] by
-
- 11 edits10 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData
We were trying to insert a tab into a br, after the br incorrectly ended up inside
a tab span.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): Changed to take in a const Node* instead of a Node*.
- editing/DeleteSelectionCommand.cpp: (WebCore::isTableRow): Ditto.
- editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): Ditto. (WebCore::isListOrIndentBlockquote): Ditto.
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Added, moved code from doApply here. (WebCore::InsertLineBreakCommand::doApply): Don't upstream() the insertion position. upstream()ing it will only have an effect when the insertion position is the first in its paragraph (since we canonicalize VisiblePositions to the upstream() candidate). In this start of paragraph case, upstream() can move outside inline elements like tab spans or elements that might have a different whitespace mode (added two test cases to cover these). Moved code to decide whether to insert a br or a '\n' to its own method. Removed special case code for inserting at a position inside a tab span. We instead adjust the insertion position before insertion if it is inside a tab span and handle insertion in the appropriate if-block. This fixes a bug where we would only insert one line break when two were needed (added a testcase). Removed special case code for inserting before and after tables and horizontal rules. We handle these insertions in the appropriate if-block.
- editing/InsertLineBreakCommand.h:
- editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Change to take in a const Node*.
- editing/htmlediting.cpp: (WebCore::isContentEditable): Ditto. (WebCore::isBlock): Ditto. (WebCore::enclosingNodeOfType): Changed to take a function pointer to a function that takes in a const Node*. (WebCore::isTabSpanTextNode): Check to see that the node actually a text node, and not, say, a br.
- editing/htmlediting.h:
- editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Changed to take in a const Node*. (WebCore::elementHasTextDecorationProperty): Ditto.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData
- editing/inserting/5549929-1-expected.txt: Added.
- editing/inserting/5549929-1.html: Added.
- editing/inserting/5549929-2.html: Added.
- editing/inserting/5549929-3.html: Added.
- platform/mac/editing/inserting/5549929-2-expected.checksum: Added.
- platform/mac/editing/inserting/5549929-2-expected.png: Added.
- platform/mac/editing/inserting/5549929-2-expected.txt: Added.
- platform/mac/editing/inserting/5549929-3-expected.checksum: Added.
- platform/mac/editing/inserting/5549929-3-expected.png: Added.
- platform/mac/editing/inserting/5549929-3-expected.txt: Added.
- 6:23 PM Changeset in webkit [27279] by
-
- 1 edit3 adds in trunk/WebCore
Reviewed by NOBODY.
Add files missing from previous commit.
- html/VoidCallback.cpp: Added. (VoidCallback::VoidCallback): (VoidCallback::~VoidCallback): (VoidCallback::handleEvent): (VoidCallback::execute): (VoidCallback::operator==): (WebCore::toVoidCallback):
- html/VoidCallback.h: Added.
- html/VoidCallback.idl: Added.
- 6:08 PM Changeset in webkit [27278] by
-
- 5 edits in trunk
WebCore:
Generated files missing from WebCore's Xcode project file
<http://bugs.webkit.org/show_bug.cgi?id=15406>
Reviewed by Darin.
Added the following files to the Xcode project file (note that
JSHTMLInputElementBaseTable.cpp is used as a header file):
- DOMCSSStyleSheetPrivate.h
- DOMEventPrivate.h
- DOMHTMLCollectionPrivate.h
- DOMHTMLEmbedElementPrivate.h
- DOMHTMLIFrameElementPrivate.h
- DOMHTMLObjectElementPrivate.h
- DOMHTMLSelectElementPrivate.h
- DOMTextEventInternal.h
- JSHTMLInputElementBaseTable.cpp
- DerivedSources.make: Removed DOMSVGException.h and JSSVGAnimatedPoints.h since their generated code was not used.
- WebCore.xcodeproj/project.pbxproj: Added missing header files.
WebKit:
Generated files missing from WebCore's Xcode project file
<http://bugs.webkit.org/show_bug.cgi?id=15406>
Reviewed by Darin.
Added the following private header files to MigrateHeaders.make:
- DOMCSSStyleSheetPrivate.h
- DOMEventPrivate.h
- DOMHTMLCollectionPrivate.h
- DOMHTMLEmbedElementPrivate.h
- DOMHTMLIFrameElementPrivate.h
- DOMHTMLObjectElementPrivate.h
- DOMHTMLSelectElementPrivate.h
- MigrateHeaders.make:
- 6:03 PM Changeset in webkit [27277] by
-
- 31 edits28 adds in trunk/WebCore
Rubber stamped by Adele.
Initial media (<video> and <audio>) support from feature branch and
QTKit based platform implementation.
This will need to be updated to match current draft specification.
- Configurations/WebCore.xcconfig:
- DerivedSources.make:
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLAudioElementConstructor.cpp: Added. (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor): (WebCore::JSHTMLAudioElementConstructor::implementsConstruct): (WebCore::JSHTMLAudioElementConstructor::construct):
- bindings/js/JSHTMLAudioElementConstructor.h: Added.
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- bindings/js/kjs_window.h: (KJS::Window::):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.cpp: (WebCore::Document::createEvent): (WebCore::Document::willSaveToCache): (WebCore::Document::didRestoreFromCache): (WebCore::Document::registerForCacheCallbacks): (WebCore::Document::unregisterForCacheCallbacks):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::setBooleanAttribute):
- dom/Element.h: (WebCore::Element::willSaveToCache):
- dom/Event.cpp: (WebCore::Event::isProgressEvent):
- dom/Event.h:
- dom/EventNames.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchProgressEvent):
- dom/EventTargetNode.h:
- dom/ProgressEvent.cpp: Added. (WebCore::ProgressEvent::ProgressEvent): (WebCore::ProgressEvent::initProgressEvent): (WebCore::ProgressEvent::initProgressEventNS):
- dom/ProgressEvent.h: Added. (WebCore::ProgressEvent::lengthComputable): (WebCore::ProgressEvent::loaded): (WebCore::ProgressEvent::total): (WebCore::ProgressEvent::isProgressEvent):
- dom/ProgressEvent.idl: Added.
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
- html/HTMLAttributeNames.in:
- html/HTMLAudioElement.cpp: Added. (WebCore::HTMLAudioElement::HTMLAudioElement):
- html/HTMLAudioElement.h: Added. (WebCore::HTMLAudioElement::tagPriority):
- html/HTMLAudioElement.idl: Added.
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::createFunctionMap):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
- html/HTMLMediaElement.cpp: Added. (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::checkDTD): (WebCore::HTMLMediaElement::rendererIsNeeded): (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::insertedIntoDocument): (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::scheduleLoad): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::dispatchEventAsync): (WebCore::HTMLMediaElement::loadTimerFired): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::serializeTimeOffset): (WebCore::parseTimeOffset): (WebCore::HTMLMediaElement::getTimeOffsetAttribute): (WebCore::HTMLMediaElement::setTimeOffsetAttribute): (WebCore::HTMLMediaElement::error): (WebCore::HTMLMediaElement::src): (WebCore::HTMLMediaElement::HTMLMediaElement::setSrc): (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::networkState): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::movieReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::readyState): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::setCurrentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::paused): (WebCore::HTMLMediaElement::defaultPlaybackRate): (WebCore::HTMLMediaElement::setDefaultPlaybackRate): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::autoplay): (WebCore::HTMLMediaElement::setAutoplay): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::loopCount): (WebCore::HTMLMediaElement::setLoopCount): (WebCore::HTMLMediaElement::start): (WebCore::HTMLMediaElement::setStart): (WebCore::HTMLMediaElement::end): (WebCore::HTMLMediaElement::setEnd): (WebCore::HTMLMediaElement::loopStart): (WebCore::HTMLMediaElement::setLoopStart): (WebCore::HTMLMediaElement::loopEnd): (WebCore::HTMLMediaElement::setLoopEnd): (WebCore::HTMLMediaElement::currentLoop): (WebCore::HTMLMediaElement::setCurrentLoop): (WebCore::HTMLMediaElement::controls): (WebCore::HTMLMediaElement::setControls): (WebCore::HTMLMediaElement::volume): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::muted): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieVolumeChanged): (WebCore::HTMLMediaElement::movieDidEnd): (WebCore::HTMLMediaElement::movieCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::removeCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::played): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::activelyPlaying): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
- html/HTMLMediaElement.h: Added. (WebCore::HTMLMediaElement::movie): (WebCore::HTMLMediaElement::isVideo): (WebCore::HTMLMediaElement::): (WebCore::HTMLMediaElement::CallbackEntry::CallbackEntry):
- html/HTMLMediaElement.idl: Added.
- html/HTMLSourceElement.cpp: Added. (WebCore::HTMLSourceElement::HTMLSourceElement): (WebCore::HTMLSourceElement::~HTMLSourceElement): (WebCore::HTMLSourceElement::insertedIntoDocument): (WebCore::HTMLSourceElement::src): (WebCore::HTMLSourceElement::setSrc): (WebCore::HTMLSourceElement::media): (WebCore::HTMLSourceElement::setMedia): (WebCore::HTMLSourceElement::type): (WebCore::HTMLSourceElement::setType):
- html/HTMLSourceElement.h: Added. (WebCore::HTMLSourceElement::endTagRequirement): (WebCore::HTMLSourceElement::tagPriority):
- html/HTMLSourceElement.idl: Added.
- html/HTMLTagNames.in:
- html/HTMLVideoElement.cpp: Added. (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
- html/HTMLVideoElement.h: Added. (WebCore::HTMLVideoElement::tagPriority): (WebCore::HTMLVideoElement::isVideo):
- html/HTMLVideoElement.idl: Added.
- html/MediaError.h: Added. (WebCore::MediaError::): (WebCore::MediaError::MediaError): (WebCore::MediaError::code):
- html/MediaError.idl: Added.
- html/TimeRanges.cpp: Added. (TimeRanges::TimeRanges): (TimeRanges::start): (TimeRanges::end): (TimeRanges::add): (TimeRanges::contain):
- html/TimeRanges.h: Added. (WebCore::TimeRanges::TimeRanges): (WebCore::TimeRanges::length): (WebCore::TimeRanges::Range::Range):
- html/TimeRanges.idl: Added.
- page/DOMWindow.idl:
- platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
- platform/MIMETypeRegistry.h:
- platform/graphics/Movie.cpp: Added. (WebCore::Movie::Movie): (WebCore::Movie::~Movie): (WebCore::Movie::load): (WebCore::Movie::cancelLoad): (WebCore::Movie::play): (WebCore::Movie::pause): (WebCore::Movie::duration): (WebCore::Movie::currentTime): (WebCore::Movie::seek): (WebCore::Movie::paused): (WebCore::Movie::seeking): (WebCore::Movie::naturalSize): (WebCore::Movie::hasVideo): (WebCore::Movie::networkState): (WebCore::Movie::readyState): (WebCore::Movie::volume): (WebCore::Movie::setVolume): (WebCore::Movie::rate): (WebCore::Movie::setRate): (WebCore::Movie::muted): (WebCore::Movie::setMuted): (WebCore::Movie::dataRate): (WebCore::Movie::setEndTime): (WebCore::Movie::addCuePoint): (WebCore::Movie::removeCuePoint): (WebCore::Movie::clearCuePoints): (WebCore::Movie::maxTimeBuffered): (WebCore::Movie::maxTimeSeekable): (WebCore::Movie::bytesLoaded): (WebCore::Movie::totalBytesKnown): (WebCore::Movie::totalBytes): (WebCore::Movie::setRect): (WebCore::Movie::visible): (WebCore::Movie::setVisible): (WebCore::Movie::paint): (WebCore::Movie::getSupportedTypes): (WebCore::Movie::networkStateChanged): (WebCore::Movie::readyStateChanged): (WebCore::Movie::volumeChanged): (WebCore::Movie::didEnd): (WebCore::Movie::cuePointReached):
- platform/graphics/Movie.h: Added. (WebCore::MovieClient::~MovieClient): (WebCore::MovieClient::movieNetworkStateChanged): (WebCore::MovieClient::movieReadyStateChanged): (WebCore::MovieClient::movieVolumeChanged): (WebCore::MovieClient::movieDidEnd): (WebCore::MovieClient::movieCuePointReached): (WebCore::Movie::parentWidget): (WebCore::Movie::setParentWidget): (WebCore::Movie::rect): (WebCore::Movie::):
- platform/graphics/mac/MoviePrivateQTKit.h: Added.
- platform/graphics/mac/MoviePrivateQTKit.mm: Added. (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::createQTMovie): (WebCore::MoviePrivate::createQTMovieView): (WebCore::MoviePrivate::createQTTime): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setCallback:WebCore::]):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::collectLayers):
- rendering/RenderVideo.cpp: Added. (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::movie): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paint): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updateMovie): (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified): (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcReplacedHeight): (WebCore::RenderVideo::calcAspectRatioWidth): (WebCore::RenderVideo::calcAspectRatioHeight): (WebCore::RenderVideo::calcPrefWidths):
- rendering/RenderVideo.h: Added. (WebCore::RenderVideo::renderName):
- 6:02 PM Changeset in webkit [27276] by
-
- 105 edits in trunk/WebCore
Reviewed by Adam Roben.
Add Interface and Class UUIDs to the IDLs in preparation of adding
autogeneration of the COM DOM bindings.
- bindings/scripts/IDLParser.pm: Relax parsing rules to allow newlines as whitespace.
- css/CSSCharsetRule.idl:
- css/CSSFontFaceRule.idl:
- css/CSSImportRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPageRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSStyleSheet.idl:
- css/CSSUnknownRule.idl:
- css/CSSValue.idl:
- css/CSSValueList.idl:
- css/Counter.idl:
- css/MediaList.idl:
- css/RGBColor.idl:
- css/Rect.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/Attr.idl:
- dom/CDATASection.idl:
- dom/CharacterData.idl:
- dom/Comment.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/EntityReference.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- dom/Text.idl:
- html/CanvasGradient.idl:
- html/CanvasPattern.idl:
- html/CanvasRenderingContext2D.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBRElement.idl:
- html/HTMLBaseElement.idl:
- html/HTMLBaseFontElement.idl:
- html/HTMLBlockquoteElement.idl:
- html/HTMLBodyElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDListElement.idl:
- html/HTMLDirectoryElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFontElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLHRElement.idl:
- html/HTMLHeadElement.idl:
- html/HTMLHeadingElement.idl:
- html/HTMLHtmlElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLIsIndexElement.idl:
- html/HTMLLIElement.idl:
- html/HTMLLabelElement.idl:
- html/HTMLLegendElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMapElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMenuElement.idl:
- html/HTMLMetaElement.idl:
- html/HTMLModElement.idl:
- html/HTMLOListElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptGroupElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLParagraphElement.idl:
- html/HTMLParamElement.idl:
- html/HTMLPreElement.idl:
- html/HTMLQuoteElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLStyleElement.idl:
- html/HTMLTableCaptionElement.idl:
- html/HTMLTableCellElement.idl:
- html/HTMLTableColElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/HTMLUListElement.idl:
- 6:01 PM Changeset in webkit [27275] by
-
- 6 edits in trunk
Reviewed by Adam and Geoff.
- Added a new cast so all the casts are in the same place.
- API/APICast.h: (toGlobalRef):
win:
Reviewed by Adam and Geoff.
- Added the globalContext method so Drosera can ask a WebFrame for its context.
- Interfaces/IWebFrame.idl:
- WebFrame.cpp:
- WebFrame.h:
- 5:58 PM Changeset in webkit [27274] by
-
- 2 edits in trunk/WebCore
RS by Darin.
- page/AnimationController.cpp: (WebCore::blendFunc): Use lround instead of round.
- 5:48 PM Changeset in webkit [27273] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Maciej.
Build media support by default on OSX only.
- Scripts/build-webkit:
- 5:45 PM Changeset in webkit [27272] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
Some SPIs for media support.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 4:19 PM Changeset in webkit [27271] by
-
- 1 edit in trunk/WebKit/StringsNotToBeLocalized.txt
Update WebKit/StringsNotToBeLocalized.txt.
- 4:15 PM Changeset in webkit [27270] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Fixed <rdar://problem/5567504> shift/reduce conflict introduced in r24457
JS tests, including
ecma_2/Statements/dowhile-001.js
ecma_2/Statements/dowhile-002.js
ecma_2/Statements/dowhile-003.js
ecma_2/Statements/dowhile-004.js
ecma_2/Statements/dowhile-005.js
ecma_2/Statements/dowhile-006.js
ecma_2/Statements/dowhile-007.js
js1_2/statements/do_while.js
and layout tests, including
do-while-expression-value.html
do-while-semicolon.html
do-while-without-semicolon.html
pass.
- kjs/grammar.y: Use the explicit "error" production, as we do with other automatic semicolon insertions, to disambiguate "do { } while();" from "do { } while()" followed by ";" (the empty statement).
- 4:05 PM Changeset in webkit [27269] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
- Made Adam the reviewer for a previous checkin. Not sure how it didn't get caught by the pre-commit hooks.
- 3:54 PM Changeset in webkit [27268] by
-
- 8 edits1 delete in trunk/WebKitTools
Reviewed by Adam.
- This is a collection of relatively unrelated changes and cleanups to Drosera to prepare it for interacting with WebKit. A lot of these changes are just correcting mistakes, for example removing included headers that are no longer needed.
- Drosera/DebuggerDocument.h: Added accessor for the ServerConnection this will be needed by the DebuggerClient. (DebuggerDocument::server):
- Drosera/win/BaseDelegate.h: Removed unnecessary include.
- Drosera/win/DebuggerClient.cpp: (DebuggerClient::didFinishLoadForFrame): Finished implementing. (DebuggerClient::didReceiveTitle): Added comment about its purpose. (DebuggerClient::createWebViewWithRequest): Added comment about its purpose.
- Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward declarations. (DebuggerClient::webViewLoaded): Moved.
- Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions file, since this was the only place it was used. (cfStringToBSTR):
- Drosera/win/Drosera.h: Cleaned up the includes.
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
- Drosera/win/HelperFunctions.h: Removed.
- 3:52 PM JavaScript performance improvement ideas edited by
- (diff)
- 3:46 PM JavaScript performance improvement ideas edited by
- (diff)
- 3:12 PM Changeset in webkit [27267] by
-
- 3 edits in trunk/WebKitTools
Reviewed by NOBODY (OOPS!).
- Small cleanup in the ServerConnection class.
- Drosera/win/ServerConnection.cpp: Added comments, moved some functions and added an include. (ServerConnection::currentFrame): (ServerConnection::getCallerFrame):
- Drosera/win/ServerConnection.h: Added comments, moved some functions, made a pointer into a COMPtr, and cleaned up the includes.
- 2:26 PM Changeset in webkit [27266] by
-
- 17 edits in trunk
WebCore:
Reviewed by John Sullivan.
- Allow showing and closing the inspector programatically.
- Add showConsole() and showTimeline() methods.
- WebCore.base.exp: Add exports for WebKit.
- page/InspectorController.cpp: (WebCore::callSimpleFunction): Renamed from callClearFunction(). (WebCore::unloading): Renamed to close(). (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): Moved showing code to show(). (WebCore::InspectorController::setWindowVisible): Show the timeline or console if needed. (WebCore::InspectorController::show): Code factored out of inspect(). (WebCore::InspectorController::showConsole): Call show() and the JS showConsole(). (WebCore::InspectorController::showTimeline): Call show() and the JS showTimeline(). (WebCore::InspectorController::close): (WebCore::InspectorController::clearScriptResources): Call the new callSimpleFunction. (WebCore::InspectorController::clearDatabaseScriptResources): Ditto. (WebCore::InspectorController::clearScriptConsoleMessages): Ditto. (WebCore::InspectorController::clearNetworkTimeline): Ditto.
- page/InspectorController.h: Add and rename methods.
- page/inspector/inspector.js: Add showConsole() and showTimeline().
WebKit:
Reviewed by John Sullivan.
Various semi-related changes:
- A WebView can now be asked for it's WebInspector. There is one WebInspector per WebView.
- Refactor the WebInspector class and move obsolete methods to a special category.
- Add new WebInspector methods to show, hide and show the console/timeline panels.
- Add an isDisabled method to WebCache.
- Allow WebLocalizableStrings.h to be used in C files.
- Misc/WebCache.h: Add isDisabled.
- Misc/WebCache.mm: (+[WebCache isDisabled]): New method.
- Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): Call super if already visible so the window will be ordered front. (-[WebInspectorWindowController showWebInspector:]): Method used by menu items, so they are enabled and work when the Inspector window is key. (-[WebInspectorWindowController showErrorConsole:]): Ditto. (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
- WebInspector/WebInspector.h: Add and remove methods.
- WebInspector/WebInspector.mm: (-webViewClosed): Called when the WebView is closed/dealloced. Clears the _webView pointer. (-show:): Calls thru to the Page's InspectorController. (-showConsole:): Ditto. (-showTimeline:): Ditto. (-close:): Ditto. (-attach:): Ditto. (-detach:): Ditto. (+sharedWebInspector): Moved to the obsolete category. (+webInspector): Ditto. (-setWebFrame:): Ditto. (-window): Ditto. (-showWindow:): Ditto.
- WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the WebInspector. (-[WebView _close]): Call webViewClosed on the WebInspector. (-[WebView inspector]): Create a WebInspector if needed and return it.
- WebView/WebViewPrivate.h: Add the inspector method.
WebKitTools:
Reviewed by John Sullivan.
- Place the Localizable.strings file in mac or win directories if that location exists.
- Also look for UI_STRING in .c files.
- Scripts/extract-localizable-strings:
- 2:18 PM Changeset in webkit [27265] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
Build fix.
- page/AnimationController.cpp: (WebCore::blendFunc):
- 2:05 PM Changeset in webkit [27264] by
-
- 21 edits1 add in trunk
WebCore:
Reviewed by Darin.
WebCore part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
Test: manual-tests/password-caps-lock.html
- WebCore.base.exp: Added symbol for capsLockStateMayHaveChanged.
- page/Frame.cpp: (WebCore::Frame::setIsActive): Calls capsLockStateMayHaveChanged.
- page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged): Added. Tells the focused node's renderer that the capsLockStateMayHaveChanged.
- page/EventHandler.h:
- platform/PlatformKeyboardEvent.h:
- platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.
- platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Added.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::paint): Added. If m_shouldDrawCapsLockIndicator is true, paints the caps lock indicator after the background. (WebCore::RenderTextControl::forwardEvent): When the control gets and loses focus, update the caps lock state. (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Added. Updates m_shouldDrawCapsLockIndicator, which is true if the field is a password field, and the frame is active, and the element is focused, and the caps lock is on. Causes a repaint when m_shouldDrawCapsLockIndicator changes state.
- rendering/RenderTextControl.h: Added m_shouldDrawCapsLockIndicator.
- rendering/RenderObject.h: (WebCore::RenderObject::capsLockStateMayHaveChanged): Added.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintCapsLockIndicator): Added.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCapsLockIndicator): Added. Calls wkDrawCapsLockIndicator.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCapsLockIndicator): Added. Calls paintThemePart for the CapsLockPart.
- rendering/RenderThemeSafari.h:
WebKit:
Reviewed by Darin.
WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
- WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field. (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged. (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
win:
Reviewed by Darin.
WebKitWin part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
<rdar://problem/5110427> REGRESSION: Caps lock icon should show in password fields
- WebView.cpp: (WebView::keyDown): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
- 1:20 PM Changeset in webkit [27263] by
-
- 16 edits in trunk/WebCore
Land support for implicit animation in CSS.
Reviewed by mitz, darin
- css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
- css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::x1): (WebCore::CSSTimingFunctionValue::y1): (WebCore::CSSTimingFunctionValue::x2): (WebCore::CSSTimingFunctionValue::y2):
- dom/Element.cpp: (WebCore::Element::styleForRenderer): (WebCore::Element::createRenderer):
- dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::setRenderStyle):
- page/AnimationController.cpp: (WebCore::CurveData::CurveData): (WebCore::CurveData::sampleCurveX): (WebCore::CurveData::sampleCurveY): (WebCore::CurveData::sampleCurveDerivativeX): (WebCore::CurveData::solveCurveX): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::ImplicitAnimation::finished): (WebCore::CompositeImplicitAnimation::~CompositeImplicitAnimation): (WebCore::CompositeImplicitAnimation::hasAnimationForProperty): (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::reset): (WebCore::ImplicitAnimation::progress): (WebCore::blendFunc): (WebCore::ImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animating): (WebCore::CompositeImplicitAnimation::reset): (WebCore::AnimationControllerPrivate::hasImplicitAnimations): (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::get): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateTimer): (WebCore::AnimationControllerPrivate::timerFired): (WebCore:::m_data): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelImplicitAnimations): (WebCore::AnimationController::updateImplicitAnimations): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
- page/AnimationController.h:
- page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): (WebCore::RenderObject::destroy):
- rendering/RenderObject.h:
- rendering/RenderStyle.h: (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::TimingFunction::x1): (WebCore::TimingFunction::y1): (WebCore::TimingFunction::x2): (WebCore::TimingFunction::y2): (WebCore::TimingFunction::type): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionProperty): (WebCore::RenderStyle::initialTransitionProperty):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
- 11:41 AM Changeset in webkit [27262] by
-
- 9 edits in trunk/WebKitTools
Reviewed by Adam.
- Set the eol-style to native and made all the line endings the same so that I avoid messy diffs that show eol changes.
- Drosera/win/ServerConnection.cpp: (ServerConnection::didParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
- 11:15 AM Changeset in webkit [27261] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Adam.
- Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the functionality that could not have existed previously without the new interfaces. (JSValueRefCreateWithBSTR): Added a helper function to easily convert from a BSTR to a JSValueRef. (DebuggerDocument::platformEvaluateScript): Implemented. (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): Implemented. (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
- Drosera/win/HelperFunctions.h: Cleaned up some comments.
- Drosera/win/ServerConnection.cpp: Added a helper function. (ServerConnection::getCallerFrame):
- Drosera/win/ServerConnection.h: Added a helper function.
- 10:49 AM Changeset in webkit [27260] by
-
- 2 edits in trunk/LayoutTests
Add another failing test to the Windows Skipped file
- platform/win/Skipped:
- 10:39 AM Changeset in webkit [27259] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Update test to not intermittently fail.
- http/tests/security/host-compare-case-insensitive-expected.txt:
- http/tests/security/host-compare-case-insensitive.html:
- http/tests/security/resources/cross-frame-iframe.html:
- http/tests/security/resources/localhost-accesssor.html:
- 10:29 AM Changeset in webkit [27258] by
-
- 2 edits2 adds in trunk/LayoutTests
Rubber stamped by Geoff.
This test needed updated results from my patch last night. It has
<parsererror> tags, which are now block instead on inline.
- platform/mac/fast/frames/onlyCommentInIFrame-expected.checksum: Replaced.
- platform/mac/fast/frames/onlyCommentInIFrame-expected.png: Replaced.
- platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
- 8:16 AM Changeset in webkit [27257] by
-
- 2 edits1 add in trunk/LayoutTests
Rubber stamped by Geoff.
Fixing two layout test mixups from my patch last night.
I added this test, but checked in old results:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
I removed the results of this test by accident:
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Added.
Oct 29, 2007:
- 11:29 PM Changeset in webkit [27256] by
-
- 1 edit1 add in trunk/SunSpider
Reviewed by Eric.
- Added list of ECMAScript3 features that SunSpider does not cover currently.
- UNCOVERED: Added.
- 10:36 PM Changeset in webkit [27255] by
-
- 5 edits in trunk/JavaScriptCore
Debranching remaining assignment nodes, and miscellaneous cleanup
Reviewed by Maciej.
Split read-modify code paths out of AssignBracketNode and AssignDotNode
Removed now unnecessary check for write-only assignment in ReadModifyLocalVarNode
and ReadModifyResolveNode evaluate methods
Leads to a 1% gain in SunSpider.
- 10:27 PM Changeset in webkit [27254] by
-
- 11 edits30 adds1 delete in trunk
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5399614> anchor tag is not rendered without
text content, works in Firefox with CSS background-image (13237)
This patch allows empty inlines that have box decorations or width
from border/padding/margin to have line boxes.
- rendering/bidi.cpp: (WebCore::inlineFlowAllowsLineBox): Convenience function that defines when we allow an inline flow to have a line box. (WebCore::requiresLineBox): Call inlineFlowAllowsLineBox. (WebCore::shouldSkipWhitespaceAfterStartObject): New function to merge some shared code between list markers and empty inline flows that fall at the beginning of a line. (WebCore::RenderBlock::findNextLineBreak): Make flows more like list markers.
One interesting side effect of this bug appeared in our xhtml/svg
tests that generate parser error tags. The tag we generate was
actually an empty inline with box decorations. This patch causes
those inlines to draw now, and the parser errors looked strange. So
I changed it so that the parsererror tag is display:block. This
matches Firefox, and I think was the original intent of the tag
since that causes its red background and border to show up.
- dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader):
LayoutTests:
Reviewed by Hyatt.
New tests and new results for old tests for <rdar://problem/
5399614> anchor tag is not rendered without text content, works in
Firefox with CSS background-image (13237)
New tests:
- fast/inline/drawStyledEmptyInlines.html: Added.
- fast/inline/drawStyledEmptyInlinesWithWS.html: Added.
- fast/inline/emptyInlinesWithinLists.html: Added.
- fast/inline/styledEmptyInlinesWithBRs.html: Added.
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum: Added.
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.png: Added.
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum: Added.
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum: Added.
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.png: Added.
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt: Added.
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum: Added.
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png: Added.
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.txt: Added.
New results for tests with <paserererrors> since <parsererror> is
now block.
- platform/mac/fast/invalid/junk-data-expected.checksum: Replaced.
- platform/mac/fast/invalid/junk-data-expected.png: Replaced.
- platform/mac/fast/invalid/junk-data-expected.txt:
- platform/mac/fast/invalid/missing-end-tag-expected.checksum: Replaced.
- platform/mac/fast/invalid/missing-end-tag-expected.png: Replaced.
- platform/mac/fast/invalid/missing-end-tag-expected.txt:
- platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum: Replaced.
- platform/mac/fast/parser/xhtml-alternate-entities-expected.png: Replaced.
- platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum: Replaced.
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png: Replaced.
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Removed.
- platform/mac/svg/custom/junk-data-expected.checksum: Replaced.
- platform/mac/svg/custom/junk-data-expected.png: Replaced.
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.checksum: Replaced.
- platform/mac/svg/custom/missing-xlink-expected.png: Replaced.
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/hixie/error/012-expected.checksum: Replaced.
- platform/mac/svg/hixie/error/012-expected.png: Replaced.
- platform/mac/svg/hixie/error/012-expected.txt:
- 8:48 PM Changeset in webkit [27253] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix crashing tests fast/frames/inline-object-inside-frameset.html and fast/forms/form-hides-table.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::destroy):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
- 8:14 PM Changeset in webkit [27252] by
-
- 6 edits in trunk/JavaScriptCore
Debranching various Node::evaluate implementations
Reviewed by Maciej.
Split the read-modify-write assignment cases out of AssignResolveNode and into ReadModifyResolveNode
Split the increment and decrement cases for Prefix- and Postfix- ResolveNode, BracketNode, and DotNode
Gains 1.6% on SunSpider
- 7:56 PM Changeset in webkit [27251] by
-
- 4 edits5 adds in trunk
WebCore:
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=15750 REGRESSION(r27173): Web Inspector freezes beneath Image::drawPattern()
Test: fast/backgrounds/size/zero.html
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern): Added an ASSERT and an early return to guard against singular pattern transforms.
- rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Changed to ensure a minimum tile size of 1x1.
LayoutTests:
Reviewed by Adam Roben.
- test for http://bugs.webkit.org/show_bug.cgi?id=15750 REGRESSION(r27173): Web Inspector freezes beneath Image::drawPattern()
- fast/backgrounds/size/zero.html: Added.
- platform/mac/fast/backgrounds/size/zero-expected.checksum: Added.
- platform/mac/fast/backgrounds/size/zero-expected.png: Added.
- platform/mac/fast/backgrounds/size/zero-expected.txt: Added.
- 7:44 PM Changeset in webkit [27250] by
-
- 8 edits3 adds in trunk/WebKit/win
Reviewed by Adam and Maciej.
- Added the IWebScriptScope interface which is used by Drosera to get information and run contextually significant code with respect to the current JS stack frame.
- Interfaces/IWebScriptCallFrame.idl: Line endings changed, not sure why but the real changes were to change the return type of scopeChain() and the return type and name of evaluateWebScript() to stringByEvaluatingJavaScriptFromString().
- Interfaces/IWebScriptScope.idl: Added.
- WebKit.vcproj/Interfaces.vcproj: Added the new interface.
- WebKit.vcproj/WebKit.vcproj: Added the files for the new class.
- WebKit.vcproj/WebKitGUID.vcproj: Added the new interfaces.
- WebScriptCallFrame.cpp: Changed the return type to E_NOTIMPL and asserted so it would be obvious if I accidentally try to use one of these functions before it's implemented. (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
- WebScriptCallFrame.h: Changed the return types mentioned above.
- WebScriptDebugServer.cpp: Also changed the return type to E_NOTIMPL. (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
- WebScriptScope.cpp: Added. (WebScriptScope::WebScriptScope): (WebScriptScope::~WebScriptScope): (WebScriptScope::QueryInterface): (WebScriptScope::AddRef): (WebScriptScope::Release): (WebScriptScope::getVariableNames): (WebScriptScope::getValueForVariable):
- WebScriptScope.h: Added.
- 7:18 PM Changeset in webkit [27249] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
- Include Vector.h in a way that actually works.
- kjs/LocalStorage.h:
- 7:12 PM Changeset in webkit [27248] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, build fix.
- Install LocalStorage.h as a private header.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 6:55 PM Changeset in webkit [27247] by
-
- 2 edits in trunk/SunSpider
Reviewed by Oliver.
- Give better error messages when sunspider-compare-results fails
- sunspider-compare-results:
- 6:54 PM Changeset in webkit [27246] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Maciej.
Do not allow control to reach end of non-void functions
- 6:46 PM Changeset in webkit [27245] by
-
- 1 edit in trunk/WebCore/ChangeLog
ChangeLog entry for r27244
- 6:44 PM Changeset in webkit [27244] by
-
- 4 edits3 adds in trunk/WebCore
Reviewed by Maciej.
Add GTK+ convenience conversions for various primitives
- 6:37 PM Changeset in webkit [27243] by
-
- 3 edits in trunk/SunSpider
Reviewed by Darin.
- fix Date tests to work in command-line SpiderMonkey
- tests/date-format-tofte.js:
- tests/date-format-xparb.js:
- 6:34 PM Changeset in webkit [27242] by
-
- 5 edits1 add in trunk/JavaScriptCore
Reviewed by Darin.
- Define good VectorTraits for LocalStorage entry for 0.5% speed improvement on SunSpider.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/LocalStorage.h: Added. (KJS::LocalStorageEntry::LocalStorageEntry): (WTF::):
- kjs/function.h:
- kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
- 6:31 PM Changeset in webkit [27241] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
updated reviewers for my previous changelog.
- 6:30 PM Changeset in webkit [27240] by
-
- 6 edits in trunk/WebKitTools
Reviewed by Maciej and Adam.
- Minor mac-side improvements including moving a function to a more appropriate location, fixing a warning, and correctly checking exceptions.
- Drosera/DebuggerDocument.cpp: Corrected the exception checking. (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
- Drosera/mac/DebuggerClient.mm: Fixes a warning.
- Drosera/mac/DebuggerDocumentPlatform.mm: Moved webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform because it doesn't require the ServerConnection at all. (NSStringCreateWithJSStringRef): Made an argument const. (JSValueRefCreateWithNSString): Made an argument const. (+[WebScriptObject webScriptAttributeKeysForScriptObject:]): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
- Drosera/mac/ServerConnection.h: Moved aforementioned function.
- Drosera/mac/ServerConnection.mm: Ditto. (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
- 5:49 PM Changeset in webkit [27239] by
-
- 17 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Simplify the dataURL xxs tests.
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html:
- http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html:
- 5:34 PM Changeset in webkit [27238] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam Roben.
Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (getGlobalFlagCallback): (setGlobalFlagCallback): (LayoutTestController::getJSClass): (LayoutTestController::staticValues):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
- 5:28 PM Changeset in webkit [27237] by
-
- 4 edits in trunk
SunSpider:
Reviewed by Maciej.
- sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.
WebKitTools:
Reviewed by Maciej.
- Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.
- 4:13 PM Changeset in webkit [27236] by
-
- 4 edits in trunk/WebCore
2007-10-29 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
Speculative fix for <rdar://5538489> Safari 3.0.4 seed hangs at
http://tgmonline.futuregamer.it/ (works fine on Safari 2.0.4 and Safari
Beta for Mac)
I cannot reproduce this hang, but it is likely due to our not limiting
WM_USER+1 messages or InvalidateRect calls for a plugin with initially-
unknown MIME type. The embed tag on the page is missing a type
attribute, so as fallback, we choose to load the Flash plugin based on
the file extension of "swf." However, we do not record this determined
MIME type, and so our quirks cannot be established.
Changed findPlugin() so that, if it fails to find a plugin for the
given MIME type, it will lookup the MIME type for the file extension -
overwriting its passed MIME type parameter - and search for a plugin
for that MIME type.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::pluginForMIMEType): Added an early return if the MIME type is empty (WebCore::PluginDatabaseWin::MIMETypeForExtension): Added to replace pluginForExtension. Returns a String with the MIME type for the file extension. Also, changed to use case-insensitive compares (WebCore::PluginDatabaseWin::findPlugin): If we fail to find a plugin for the given extension, overwrite the incoming MIME type parameter with the MIME type for the file extension, and search for a plugin for that MIME type. Also, changed the way that the extension is determined (WebCore::PluginDatabaseWin::createPluginView): Pass a mutable String to findPlugin() so that it can be updated if necessary
- plugins/win/PluginDatabaseWin.h: Changed findPlugin() to take a non- const String, removed definition of pluginForExtension, added definition for MIMETypeForExtension
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Store the MIME type in lowercase for easier compares
- 3:55 PM Changeset in webkit [27235] by
-
- 2 edits in trunk/WebCore
Not reviewed - build fix
Fix Mac Build.
WebKit/WebCore/xml/XSLTProcessor.cpp:79: warning: 'level' may be used uninitialized
in this function
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):
- 3:28 PM Changeset in webkit [27234] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15725
[GTK] WebCore.pro header dependencies are incorrect
Fix header dependencies in the build system
INCLUDEPATH and DEPENDPATH are now up to date.
- 3:16 PM Changeset in webkit [27233] by
-
- 180 edits62 adds99 deletes in trunk/WebKitSite
Upgrade WordPress.
- 2:46 PM Changeset in webkit [27232] by
-
- 2 edits6 adds in trunk/WebKitSite
Files that have been added or modified on the server without making it in to SVN.
- 12:17 PM Changeset in webkit [27231] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Some small tweaks that I notice while reviewing Oliver's last patch.
Includes removal of an unnecessary KJS_CHECKEXCEPTIONVALUE.
No change in SunSpider because SunSpider doesn't take the code path that
would execute the unnecessary KJS_CHECKEXCEPTIONVALUE much.
- kjs/nodes.cpp: (KJS::LocalVarPostfixNode::evaluate): (KJS::TypeOfResolveNode::optimizeVariableAccess): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PrefixResolveNode::optimizeVariableAccess): (KJS::LocalVarPrefixNode::evaluate): (KJS::AssignResolveNode::optimizeVariableAccess): (KJS::LocalVarAssignNode::evaluate):
- kjs/nodes.h: (KJS::LocalVarTypeOfNode::): (KJS::PrefixResolveNode::): (KJS::LocalVarPrefixNode::): (KJS::AssignResolveNode::): (KJS::LocalVarAssignNode::):
- 11:57 AM Changeset in webkit [27230] by
-
- 1 edit in trunk/WebCore/css/CSSParser.cpp
A better build fix.
- 11:50 AM Changeset in webkit [27229] by
-
- 3 edits in trunk/WebCore
Build fix.
- css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionTimingFunction):
- 11:22 AM Changeset in webkit [27228] by
-
- 21 edits4 adds in trunk/WebCore
Land the back end for CSS animated property transitions. I am landing this in stages, so the AnimationController
class is deliberately left empty.
Reviewed by darin/aroben
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPropertyNames.in:
- css/CSSTimingFunctionValue.cpp: Added. (WebCore::CSSTimingFunctionValue::cssText):
- css/CSSTimingFunctionValue.h: Added. (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::firstPoint): (WebCore::CSSTimingFunctionValue::secondPoint):
- css/CSSValueKeywords.in:
- history/CachedPage.cpp: (WebCore::CachedPage::restore):
- page/AnimationController.cpp: Added. (WebCore::AnimationController::AnimationController): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelTransitions): (WebCore::AnimationController::updateTransitions): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
- page/AnimationController.h: Added.
- page/Frame.cpp: (WebCore::Frame::animationController): (WebCore::Frame::clearTimers):
- page/Frame.h:
- page/FramePrivate.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
- rendering/RenderObject.cpp: (WebCore::RenderObject::animationController):
- rendering/RenderObject.h:
- rendering/RenderStyle.cpp: (WebCore::Transition::Transition): (WebCore::Transition::~Transition): (WebCore::Transition::operator=): (WebCore::Transition::operator==): (WebCore::Transition::fillUnsetProperties): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::transitionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessTransitions):
- rendering/RenderStyle.h: (WebCore::BackgroundLayer::next): (WebCore::): (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::Transition::next): (WebCore::Transition::isTransitionDurationSet): (WebCore::Transition::isTransitionRepeatCountSet): (WebCore::Transition::isTransitionTimingFunctionSet): (WebCore::Transition::isTransitionPropertySet): (WebCore::Transition::isEmpty): (WebCore::Transition::clearTransitionDuration): (WebCore::Transition::clearTransitionRepeatCount): (WebCore::Transition::clearTransitionTimingFunction): (WebCore::Transition::clearTransitionProperty): (WebCore::Transition::transitionDuration): (WebCore::Transition::transitionRepeatCount): (WebCore::Transition::transitionTimingFunction): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionDuration): (WebCore::Transition::setTransitionRepeatCount): (WebCore::Transition::setTransitionTimingFunction): (WebCore::Transition::setTransitionProperty): (WebCore::Transition::setNext): (WebCore::Transition::operator!=): (WebCore::RenderStyle::transitions): (WebCore::RenderStyle::clearTransitions): (WebCore::RenderStyle::inheritTransitions): (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionRepeatCount): (WebCore::RenderStyle::initialTransitionTimingFunction): (WebCore::RenderStyle::initialTransitionProperty):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
- 10:02 AM Changeset in webkit [27227] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6040
XSLT does not report errors to the user
Made parseErrorFunc a static member function of XSLTProcessor to be reusable from XSLStylesheet.
Switched to xmlSetStructuredErrorFunc to get an error structure instead of pre-formatted console
output. Got rid of DeprecatedString in XSLTProcessor.
- dom/Document.cpp: (WebCore::Document::applyXSLTransform):
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc): (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::writeToString): (WebCore::saveResultToString): (WebCore::transformTextStringToXHTMLDocumentString): (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray): (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::createFragmentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode): (WebCore::resultMIMEType): (WebCore::XSLTProcessor::transformToString): (WebCore::XSLTProcessor::transformToDocument): (WebCore::XSLTProcessor::transformToFragment):
- xml/XSLTProcessor.h: (WebCore::XSLTProcessor::setXSLStylesheet): (WebCore::XSLTProcessor::importStylesheet): (WebCore::XSLTProcessor::xslStylesheet):
- 9:34 AM Changeset in webkit [27226] by
-
- 2 edits in trunk/WebKitTools
Fixed showStatus() to print status for successfully resolved conflicts when using git.
Reviewed by Mark Rowe.
Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
was successfully resolved, but this would not show any status because the change had
already been cached in the index using "git add". The solution is to add an optional
second argument to showStatus() which adds the "--cached" switch to the command.
- Scripts/resolve-ChangeLogs: (showStatus):
- 9:28 AM Changeset in webkit [27225] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Mitz.
Test for http://bugs.webkit.org/show_bug.cgi?id=10030
Star Alliance site is opened without the main frame
- fast/frames/location-change-expected.txt: Added.
- fast/frames/location-change.html: Added.
- fast/frames/resources/location-change-frame-1.html: Added.
- fast/frames/resources/location-change-frame-2.html: Added.
- 9:02 AM Changeset in webkit [27224] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
Test: fast/repaint/layout-state-only-posiitoned.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutOnlyPositionedObjects): Pop layout state before updating scroll info, which possibly repaints us.
LayoutTests:
Reviewed by John Sullivan,
- repaint test for <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
- fast/repaint/layout-state-only-posiitoned.html: Added.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Added.
- platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Added.
- 3:31 AM Changeset in webkit [27223] by
-
- 3 edits5 adds in trunk
WebCore:
REGRESSION (r17701): Favicons should be viewable as image documents
<http://bugs.webkit.org/show_bug.cgi?id=15640>
Reviewed by Darin.
On Tiger and Leopard, the image/x-icon MIME type is not returned from
CGImageSourceCopyTypeIdentifiers(), so opening a URL to a favicon caused
the icon to be downloaded instead being displayed in an image document.
Test: fast/images/favicon-as-image.html
- platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): Manually add image/x-icon to supportedImageMIMETypes and supportedImageResourceMIMETypes. Also fixed comment about the image/bmp MIME type since it applies to both Tiger and Leopard.
LayoutTests:
Test for: REGRESSION (r17701): Favicons should be viewable as image documents
<http://bugs.webkit.org/show_bug.cgi?id=15640>
Reviewed by Darin.
- fast/images/favicon-as-image.html: Added.
- fast/images/resources/favicon.ico: Added.
- platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
- platform/mac/fast/images/favicon-as-image-expected.png: Added.
- platform/mac/fast/images/favicon-as-image-expected.txt: Added.
- 2:14 AM Changeset in webkit [27222] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-29 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
SunSpider claims this was a 0.7% speedup.
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): avoid mallocing a jsString in the common case
- 1:44 AM Changeset in webkit [27221] by
-
- 7 edits in trunk
Reviewed by Mark.
- re-enable asserts for access to empty or deleted keys
- wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
WebCore:
Reviewed by Mark.
- fixed assertion failures detected by the new assertions
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): Clear _internal before calling [super dealloc] because it's not a pointer and shouldn't be in the normal wrapper cache.
- dom/Document.cpp: (WebCore::Document::addImageMap): Don't access hashmap if name is null. (WebCore::Document::removeImageMap): ditto
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't claim we have a class when the class attribute is empty.
- platform/TextCodecICU.cpp: (WebCore::gbkCallbackEscape): Don't look up 0 code points.
- 1:32 AM Changeset in webkit [27220] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-29 Eric Seidel <eric@webkit.org>
Build fix only, no review.
- JavaScriptCore.exp: Export symbol for new StringInstance::getOwnPropertySlot
- 1:31 AM Changeset in webkit [27219] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-29 Mark Rowe <mrowe@apple.com>
Gtk build fix. Move struct declarations into nodes.h.
- kjs/grammar.y:
- kjs/nodes.h:
- 12:55 AM Changeset in webkit [27218] by
-
- 4 edits in trunk/JavaScriptCore
2007-10-29 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Give StringInstance a getOwnPropertySlot(ExecState, unsigned, PropertySlot) fastpath, just like Arrays.
Make it a compile time error to use toString(ExecState) on a StringInstance
SunSpider claims this was a 6.6% speedup overall (22% on string-base64)
- kjs/internal.h: (KJS::StringImp::getLength):
- kjs/string_object.cpp: (KJS::StringInstance::lengthGetter): (KJS::StringInstance::inlineGetOwnPropertySlot): (KJS::StringInstance::getOwnPropertySlot):
- kjs/string_object.h:
- 12:21 AM Changeset in webkit [27217] by
-
- 5 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10734
Made HTMLOptionElement.index read-only, matching IE and DOM standard.
Test: fast/dom/HTMLOptionElement/set-option-index-text.html
- html/HTMLOptionElement.idl: Marked index as readonly.
- html/HTMLOptionElement.cpp:
- html/HTMLOptionElement.h: Removed setIndex().
- 12:05 AM Changeset in webkit [27216] by
-
- 3 edits in trunk/JavaScriptCore
Added nodes to allow Assignment, TypeOf, and prefix operators to
make use of the new optimised local variable look up.
5% gain on sunspider
Reviewed by Darin
Oct 28, 2007:
- 11:49 PM Changeset in webkit [27215] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Darin.
- avoid creating and then breaking circular lists in the parser, instead track head and tail pointers at parse time http://bugs.webkit.org/show_bug.cgi?id=15748
Not a significant speedup or slowdown on SunSpider.
- kjs/Parser.cpp: (KJS::clearNewNodes):
- kjs/Parser.h:
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::BlockNode::BlockNode): (KJS::CaseBlockNode::CaseBlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::SourceElementsNode::SourceElementsNode): (KJS::ProgramNode::ProgramNode):
- kjs/nodes.h: (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::ForNode::): (KJS::ParameterNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::):
- 11:25 PM Changeset in webkit [27214] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-28 Mark Rowe <mrowe@apple.com>
Disable assertions in a manner that doesn't break the Qt Windows build.
- wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting):
- 11:14 PM Changeset in webkit [27213] by
-
- 2 edits in trunk/JavaScriptCore
Temporarily disabling some ASSERTs I introduced in my last check-in
because of http://bugs.webkit.org/show_bug.cgi?id=15747
Lots of layout tests fail the !HashTranslator::equal(KeyTraits::emptyValue() ASSERT
- wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
- 11:13 PM Changeset in webkit [27212] by
-
- 2 edits in trunk/SunSpider
Fix SunSpider on Windows
Reviewed by Eric.
- sunspider: Don't use colons in filenames.
- 10:53 PM Changeset in webkit [27211] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15746
#ifndef ASSERT_DISABLED is no good!
Replaced with #if !ASSERT_DISABLED.
- wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
- 10:32 PM Changeset in webkit [27210] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode
to the AST transfom that replaces slow resolve nodes with fast local
variable alternatives.
2.5% speedup on SunSpider.
Also added some missing copyright notices.
- kjs/nodes.cpp: (KJS::FunctionCallResolveNode::optimizeVariableAccess): (KJS::FunctionCallResolveNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostfixResolveNode::optimizeVariableAccess): (KJS::PostfixResolveNode::evaluate): (KJS::LocalVarPostfixNode::evaluate): (KJS::DeleteResolveNode::optimizeVariableAccess): (KJS::DeleteResolveNode::evaluate): (KJS::LocalVarDeleteNode::evaluate):
- kjs/nodes.h: (KJS::FunctionCallResolveNode::): (KJS::LocalVarFunctionCallNode::LocalVarFunctionCallNode): (KJS::PostfixResolveNode::): (KJS::LocalVarPostfixNode::LocalVarPostfixNode): (KJS::DeleteResolveNode::): (KJS::LocalVarDeleteNode::LocalVarDeleteNode):
- 9:53 PM Changeset in webkit [27209] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Inline UString::Rep::deref() for a 0.8% improvement in SunSpider
Add virtual keyword to a few virtual functions previously unmarked.
- kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
- kjs/ustring.h: (KJS::UString::Rep::deref):
- 9:37 PM Changeset in webkit [27208] by
-
- 3 edits in trunk/JavaScriptCore
- fix "broken everything" from the storage leak fix
- wtf/RefPtr.h: (WTF::RefPtr::RefPtr): Added a PlacementNewAdopt constructor.
- kjs/ustring.h: (KJS::UString::UString): Pass PlacementNewAdopt along to RefPtr.
- 9:31 PM Changeset in webkit [27207] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Adam.
- turn on unused parameter waring on Mac OS X because it's already on elsewhere
- Configurations/Base.xcconfig: Took out -wno-unused-parameter.
- API/JSNode.c:
- API/JSNodeList.c:
- API/minidom.c:
- API/testapi.c: Fixed unused variables by using them or marked them with UNUSED_PARAM.
- kjs/CollectorHeapIntrospector.h: (KJS::CollectorHeapIntrospector::zoneCalloc): Removed parameter names to indicate they are unused.
- 9:11 PM Changeset in webkit [27206] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fix a storage leak where we ref the UString every time we replace a ResolveNode with a LocalVarAccessNode
- kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor that takes PlacementNewAdopt.
- kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident with PlacementNewAdopt instead of the old value of ident.
- kjs/ustring.h: (KJS::UString::UString): Added a constructor that takes PlacementNewAdopt.
- 9:04 PM Changeset in webkit [27205] by
-
- 2 edits in trunk/LayoutTests
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
- platform/mac/svg/custom/path-bad-data-expected.txt: updated to better results
- 9:02 PM Changeset in webkit [27204] by
-
- 3 edits in trunk/JavaScriptCore
- Windows build fix; get rid of unused parameter
- kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess): Don't pass it.
- kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode): Remove it. The assertions weren't all that helpful.
- 8:48 PM Changeset in webkit [27203] by
-
- 5 edits in trunk/WebCore
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Fix leaks on TOT and prevent Path code from logging to console so frequently
- platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilterPlatformData::SVGResourceFilterPlatformData): (WebCore::SVGResourceFilterPlatformData::~SVGResourceFilterPlatformData):
- platform/graphics/svg/cg/CgSupport.cpp: (WebCore::strokeBoundingBox):
- platform/graphics/svg/cg/SVGResourceFilterCg.mm:
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
- 8:00 PM Changeset in webkit [27202] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-28 Mark Rowe <mrowe@apple.com>
Gtk build fix. Add include of MathExtras.h.
- kjs/string_object.cpp:
- 7:52 PM Changeset in webkit [27201] by
-
- 14 edits in trunk
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej and Tim.
Replace uses of isNaN and isInf with isnan and isinf, and
remove isNaN and isInf.
- kjs/config.h: Remove unused HAVE_'s
- kjs/date_object.cpp: (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction):
- kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
- kjs/math_object.cpp: (MathFuncImp::callAsFunction):
- kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber):
- kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
- kjs/operations.cpp:
- kjs/operations.h:
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
- kjs/ustring.cpp: (KJS::UString::from):
- kjs/value.cpp: (KJS::JSValue::toInteger): (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Replace uses of isNaN and isInf with isnan and isinf.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):
- 7:08 PM Changeset in webkit [27200] by
-
- 3 edits in trunk/JavaScriptCore
Build fix: use the new-fangled missingSymbolMarker().
- kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess):
- kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode):
- 7:00 PM Changeset in webkit [27199] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak, Darin Adler.
Much supporting work done by Maciej Stachowiak, Maks Orlovich, and
Cameron Zwarich.
AST transfom to replace slow resolve nodes with fast local variable
alternatives that do direct memory access. Currently, only ResolveNode
provides a fast local variable alternative. 6 others are soon to come.
16.7% speedup on SunSpider.
Most of this patch is just scaffolding to support iterating all the
resolve nodes in the AST through optimizeResolveNodes(). In
optimizeResolveNodes(), most classes just push their child nodes onto
the processing stack, while ResolveNodes actually replace themselves in
the tree with more optimized alternatives, if possible.
Here are the interesting bits:
- kjs/nodes.h: Added PlacementNewAdoptTag, along with implementations in Node and ResolveNode. This tag allows you to use placement new to swap out a base class Node in favor of a subclass copy that holds the same data. (Without this tag, default initialization would NULL out RefPtrs, change line numbers, etc.)
- kjs/nodes.cpp: (KJS::ResolveNode::evaluate): Since we're taking the slow path, ASSERT that the fast path is impossible, to make sure we didn't leave anything on the table.
(KJS::FunctionBodyNode::optimizeResolveNodes): Here's where the AST
transformation happens.
(KJS::ResolveNode::optimizeResolveNodes): Here's where the ResolveNode
optimization happens.
- kjs/function.h: Added symbolTable() accessor for, for the sake of an ASSERT.
- 6:56 PM Changeset in webkit [27198] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Fix "AllInOneFile.o has a global initializer in it".
Some versions of gcc generate a global initializer for std::numeric_limits<size_t>::max().
We can avoid this by moving it inside an inline function.
- kjs/SymbolTable.h: (KJS::missingSymbolMarker):
- kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):
- 6:50 PM Changeset in webkit [27197] by
-
- 2 edits in trunk/WebKitTools
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Maciej and Geoff, in unison.
- Scripts/run-webkit-tests: remove broken --svg option
- 6:29 PM Changeset in webkit [27196] by
-
- 4 edits1 add in trunk
Reviewed by Mark.
- Added assertions to protect against adding empty or deleted keys to a HashTable
- wtf/HashTable.h: (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::fullLookupForWriting): (WTF::HashTable::add):
WebCore:
Reviewed by Mark.
- fixed REGRESSION(r27176): Reproducible crash while trying to order dinner makes bdash sad http://bugs.webkit.org/show_bug.cgi?id=15731
- bindings/js/kjs_window.cpp: (KJS::Window::installTimeout): Avoid putting in or accessing empty or deleted keys. (KJS::Window::clearTimeout): ditto
- manual-tests/bad-clearTimeout-crash.html: Added. Automated test not possible.
- 5:14 PM Changeset in webkit [27195] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Remove IDLs from the Copy Bundle Resources phase.
- 4:08 PM Changeset in webkit [27194] by
-
- 4 edits in trunk/SunSpider
Reviewed by Adam.
- resources/sunspider-analyze-results.js: Tweak the output format a little. Change so that when there's only one run we don't write out confidence intervals at all rather than writing "NaN" over and over again.
- sunspider: Use the time and date as a suffix on the results file, that way all the results are left behind in the tmp directory. This will make it easy for us to add features that compare past results in the future. Also rename the .mshark files using the same scheme.
- sunspider-compare-results: Relax the parsing rules so we can parse the results file exactly as it's emitted from sunspider.
- 4:06 PM Changeset in webkit [27193] by
-
- 2 edits in trunk/JavaScriptCore
- fix GTK build
- kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber): Use isNaN and isInf instead of isnan and isinf.
- 4:00 PM Changeset in webkit [27192] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam.
- Scripts/run-sunspider: Default to "Release" configuration rather than defaulting to the last configuration used as other scripts do. This can still be overriden on the command line with "--debug" if there's some reason to do so. Also fix a typo.
- Scripts/sunspider-compare-results: Fix a typo.
- 3:50 PM Changeset in webkit [27191] by
-
- 8 edits6 adds in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15735 remove GroupNode to simplify AST and possibly get a modest speedup
This patch removes 4 node types: GroupNode, PropertyNameNode,
FunctionCallParenBracketNode, and FunctionCallParenDotNode.
To remove GroupNode, we add knowledge of precedence to the tree nodes,
and use that when serializing to determine where parentheses are needed.
This means we no longer have to represent parentheses in the tree.
The precedence values are named after productions in the grammar from the
JavaScript standard.
SunSpider says this is an 0.4% speedup.
- kjs/function.h:
- kjs/function.cpp: Removed escapeStringForPrettyPrinting -- it's part of serialization, so I moved it to the file that takes care of that.
- kjs/grammar.y: Changed makeGetterOrSetterPropertyNode to use 0 to indicate failure instead of a separate boolean. Got rid of PropertyNameNode by merging the PropertyName rule into the Property rule (which was easier than figuring out how to pass the Identifier from one node to another). Got rid of GroupNode, nodeInsideAllParens(), FunctionCallParenBracketNode, and FunctionCallParenDotNode.
- kjs/nodes.h: Removed unused forward declarations and Operator values. Added Precedence enum, and precedence function to all nodes. Removed nodeInsideAllParens. Added streamBinaryOperator function for serialization. Removed GroupNode and PropertyNameNode. Made PropertyNode store an Identifier. Removed FunctionCallParenBracketNode and FunctionCallParenDotNode.
- kjs/nodes.cpp: Removed Node::nodinsideAllParens, GroupNode, and PropertyNameNode. (KJS::PropertyListNode::evaluate): Changed code to get name directly instead of converting it from an Identifier to a jsString then back to a UString then into an Identifier again!
- kjs/nodes2string.cpp: Changed special-token implementation to use a separate function for each of Endl, Indent, Unindent, and DotExpr instead of using a single function with a switch. Added a precedence that you can stream in, to cause the next node serialized to add parentheses based on that precedence value. (KJS::operatorString): Moved to the top of the file. (KJS::escapeStringForPrettyPrinting): Moved here from function.cpp. Removed old workaround for snprintf, since StringExtras.h takes care of that. (KJS::operator<<): Made the char and char* versions faster by using UString's character append functions instead of constructing a UString. Added the logic to the Node* version to add parentheses if needed. (KJS::Node::streamLeftAssociativeBinaryOperator): Added helper function. (KJS::ElementNode::streamTo): Use PrecAssignment for the elements. (KJS::BracketAccessorNode::streamTo): Use PrecCall for the expression before the bracket. (KJS::DotAccessorNode::streamTo): Use PrecCall for the expression before the dot. (KJS::ArgumentListNode::streamTo): Use PrecAssignment for the arguments. (KJS::NewExprNode::streamTo): Use PrecMember for the expression. (KJS::FunctionCallValueNode::streamTo): Use PrecCall. (KJS::FunctionCallBracketNode::streamTo): Ditto. (KJS::FunctionCallDotNode::streamTo): Ditto. (KJS::PostfixBracketNode::streamTo): Ditto. (KJS::PostfixDotNode::streamTo): Ditto. (KJS::PostfixErrorNode::streamTo): Use PrecLeftHandSide. (KJS::DeleteBracketNode::streamTo): Use PrecCall. (KJS::DeleteDotNode::streamTo): Ditto. (KJS::DeleteValueNode::streamTo): Use PrecUnary. (KJS::VoidNode::streamTo): Ditto. (KJS::TypeOfValueNode::streamTo): Ditto. (KJS::PrefixBracketNode::streamTo): Use PrecCall. (KJS::PrefixDotNode::streamTo): Ditto. (KJS::PrefixErrorNode::streamTo): Use PrecUnary. (KJS::UnaryPlusNode::streamTo): Ditto. (KJS::NegateNode::streamTo): Ditto. (KJS::BitwiseNotNode::streamTo): Ditto. (KJS::LogicalNotNode::streamTo): Ditto. (KJS::MultNode::streamTo): Use streamLeftAssociativeBinaryOperator. (KJS::DivNode::streamTo): Ditto. (KJS::ModNode::streamTo): Ditto. (KJS::AddNode::streamTo): Ditto. (KJS::SubNode::streamTo): Ditto. (KJS::LeftShiftNode::streamTo): Ditto. (KJS::RightShiftNode::streamTo): Ditto. (KJS::UnsignedRightShiftNode::streamTo): Ditto. (KJS::LessNode::streamTo): Ditto. (KJS::GreaterNode::streamTo): Ditto. (KJS::LessEqNode::streamTo): Ditto. (KJS::GreaterEqNode::streamTo): Ditto. (KJS::InstanceOfNode::streamTo): Ditto. (KJS::InNode::streamTo): Ditto. (KJS::EqualNode::streamTo): Ditto. (KJS::NotEqualNode::streamTo): Ditto. (KJS::StrictEqualNode::streamTo): Ditto. (KJS::NotStrictEqualNode::streamTo): Ditto. (KJS::BitAndNode::streamTo): Ditto. (KJS::BitXOrNode::streamTo): Ditto. (KJS::BitOrNode::streamTo): Ditto. (KJS::LogicalAndNode::streamTo): Ditto. (KJS::LogicalOrNode::streamTo): Ditto. (KJS::ConditionalNode::streamTo): Ditto. (KJS::AssignResolveNode::streamTo): Use PrecAssignment for the right side. (KJS::AssignBracketNode::streamTo): Use PrecCall for the expression before the bracket and PrecAssignment for the right side. (KJS::AssignDotNode::streamTo): Ditto. (KJS::AssignErrorNode::streamTo): Use PrecLeftHandSide for the left side and PrecAssignment for the right side. (KJS::CommaNode::streamTo): Use PrecAssignment for both expressions. (KJS::AssignExprNode::streamTo): Use PrecAssignment.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=15735 remove GroupNode to simplify AST and possibly get a modest speedup
One test is a start at testing that parentheses are added when needed.
The other test checks some aspects of object literals, since I changed
the way the property names is handled in those. More tests are needed.
- fast/js/function-toString-object-literals-expected.txt: Added.
- fast/js/function-toString-object-literals.html: Added.
- fast/js/function-toString-parentheses-expected.txt: Added.
- fast/js/function-toString-parentheses.html: Added.
- fast/js/resources/function-toString-object-literals.js: Added.
- fast/js/resources/function-toString-parentheses.js: Added.
- 2:27 PM Changeset in webkit [27190] by
-
- 12 edits in trunk/WebCore
wx port defines for graphics and network layers.
- 2:09 PM Changeset in webkit [27189] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders Carlsson.
http://bugs.webkit.org/show_bug.cgi?id=14124
[CURL] Support data URLs
Add data URL support (both Base64 and percent-encoded formats).
Inspired by code from the Qt port.
- 1:23 PM Changeset in webkit [27188] by
-
- 2 edits in trunk/WebCore
http://bugs.webkit.org/show_bug.cgi?id=15701
The curl http backend does not deal properly with redirects
Implement http redirect support.
- 12:18 PM Changeset in webkit [27187] by
-
- 25 edits in trunk
Add the defines, platform types and options needed for the wx port.
- 11:20 AM Changeset in webkit [27186] by
-
- 10 edits in trunk
2007-10-28 Mark Rowe <mrowe@apple.com>
We don't include "config.h" in headers.
- bindings/jni/jni_instance.h:
- kjs/regexp.h:
- wtf/TCPageMap.h:
- wtf/TCSpinLock.h:
2007-10-28 Mark Rowe <mrowe@apple.com>
We don't include "config.h" in headers.
- dom/XMLTokenizer.h:
- platform/graphics/svg/SVGResourceFilter.h:
- platform/image-decoders/ImageDecoder.h:
- platform/wx/FontPlatformData.h:
- 10:53 AM UsingSafari2WithSafari3PublicBetaInstalled edited by
- Self-contained Safari 3 (diff)
- 10:41 AM Changeset in webkit [27185] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removed some "Reviewed by NOBODY".
- 10:37 AM Changeset in webkit [27184] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Removed some "Reviewed by NOBODY".
- 10:36 AM Changeset in webkit [27183] by
-
- 1 edit in trunk/WebKitLibraries/ChangeLog
Removed some "Reviewed by NOBODY".
- 10:31 AM Changeset in webkit [27182] by
-
- 2 edits in trunk/WebCore
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: We don't include "config.h" in headers. Hope this desn't break the non-SVG build again.
- 10:22 AM Changeset in webkit [27181] by
-
- 2 edits in trunk/WebKit/win
- try to fix Windows build
- WebKit.vcproj/WebKit.vcproj: Suppress warning 4800 (conversion to bool), since we don't want to add !! everywhere, and because HashTable.h has a conversion to bool of this type now.
- 4:47 AM Changeset in webkit [27180] by
-
- 3 edits in trunk/WebCore
2007-10-28 Eric Seidel <eric@webkit.org>
Build fix for non-SVG build, no review.
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm:
- 3:34 AM Changeset in webkit [27179] by
-
- 58 edits3 adds in trunk/WebCore
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Push SVGResourceFilter platform specific data down into m_platformData
in preparation for implementing a non-mac filter solution.
Also update a very old email address in copyright headers
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::FloatPoint3D):
- platform/graphics/FloatPoint3D.h:
- platform/graphics/svg/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
- platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilter::platformData): (WebCore::SVGResourceFilter::effects):
- platform/graphics/svg/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::createPlatformData):l (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- platform/graphics/svg/filters/SVGDistantLightSource.h:
- platform/graphics/svg/filters/SVGFEBlend.cpp:
- platform/graphics/svg/filters/SVGFEBlend.h:
- platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
- platform/graphics/svg/filters/SVGFEColorMatrix.h:
- platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
- platform/graphics/svg/filters/SVGFEComponentTransfer.h:
- platform/graphics/svg/filters/SVGFEComposite.cpp:
- platform/graphics/svg/filters/SVGFEComposite.h:
- platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
- platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
- platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
- platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
- platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
- platform/graphics/svg/filters/SVGFEDisplacementMap.h:
- platform/graphics/svg/filters/SVGFEFlood.cpp:
- platform/graphics/svg/filters/SVGFEFlood.h:
- platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
- platform/graphics/svg/filters/SVGFEGaussianBlur.h:
- platform/graphics/svg/filters/SVGFEImage.cpp:
- platform/graphics/svg/filters/SVGFEImage.h:
- platform/graphics/svg/filters/SVGFEMerge.cpp:
- platform/graphics/svg/filters/SVGFEMerge.h:
- platform/graphics/svg/filters/SVGFEMorphology.cpp:
- platform/graphics/svg/filters/SVGFEMorphology.h:
- platform/graphics/svg/filters/SVGFEOffset.cpp:
- platform/graphics/svg/filters/SVGFEOffset.h:
- platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
- platform/graphics/svg/filters/SVGFESpecularLighting.h:
- platform/graphics/svg/filters/SVGFETile.h:
- platform/graphics/svg/filters/SVGFETurbulence.cpp:
- platform/graphics/svg/filters/SVGFETurbulence.h:
- platform/graphics/svg/filters/SVGFilterEffect.cpp:
- platform/graphics/svg/filters/SVGFilterEffect.h:
- platform/graphics/svg/filters/SVGLightSource.cpp:
- platform/graphics/svg/filters/SVGLightSource.h:
- platform/graphics/svg/filters/SVGPointLightSource.h:
- platform/graphics/svg/filters/SVGSpotLightSource.h:
- platform/graphics/svg/filters/cg/SVGFEBlendCg.mm: (WebCore::SVGFEBlend::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: (WebCore::SVGFEColorMatrix::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm: (WebCore::SVGFEComponentTransfer::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFECompositeCg.mm: (WebCore::SVGFEComposite::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm: (WebCore::SVGFEDiffuseLighting::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm: (WebCore::SVGFEDisplacementMap::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEFloodCg.mm: (WebCore::SVGFEFlood::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
- platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEMergeCg.mm: (WebCore::SVGFEMerge::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm: (WebCore::SVGFESpecularLighting::getCIFilter):
- platform/graphics/svg/mac: Added.
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: Added.
- platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm: Added. (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::~SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::getCIFilterStack): (WebCore::alphaImageForImage): (WebCore::SVGResourceFilterPlatformDataMac::imageForName): (WebCore::SVGResourceFilterPlatformDataMac::setImageForName): (WebCore::SVGResourceFilterPlatformDataMac::setOutputImage): (WebCore::SVGResourceFilterPlatformDataMac::inputImage):
- 3:19 AM Changeset in webkit [27178] by
-
- 3 edits in trunk/JavaScriptCore
Rubber stamped by Mark.
- avoid using non-portable SIZE_T_MAX in favor of std::numeric_limits
- kjs/SymbolTable.h: (KJS::SymbolTableIndexHashTraits::emptyValue):
- kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):
- 2:20 AM Changeset in webkit [27177] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Eric.
- switch SymbolTable to be a HashMap instead of a PropertyMap for 3% SunSpider speedup
- kjs/SymbolTable.h: (KJS::IdentifierRepHash::hash): Special hash function for identifier reps. (KJS::IdentifierRepHash::equal): ditto (KJS::SymbolTableIndexHashTraits::emptyValue): Special HashTraits for the index value. (KJS::SymbolTable): change to a typedef for a HashMap.
- kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): Adjusted for new SymbolTable API. (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto
- kjs/nodes.cpp: (KJS::FunctionBodyNode::initializesymbolTable): Adjusted, since you now have to store a UString::rep, not an identifier.
- 1:17 AM Changeset in webkit [27176] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- numerous HashTable performance improvements
This does not quite add up to a measurable win on SunSpider, but it allows a
follow-on > 3% improvement and probably helps WebCore too.
I made the following improvements, among others:
- Made HashFunctions note whether it is ok to compare a real value with the equal() function to the empty or deleted value, and used this to optimize the comparisons done in hash lookup.
- Specialized lookup so it doesn't have to do so many extra branches and build so many extra std::pairs for cases that don't need them. There are now four versions, one for read-only access, two for writing, and one folded directly into add() (these all were improvments).
- Made HashMap::get() use lookup() directly instead of find() to avoid having to build iterators.
- Made a special constructor for iterators that knows it points to a valid filled cell and so skips updating itself.
- Reordered memory accesses in the various lookup functions for better codegetion
- Made simple translators avoid passing a hash code around
- Other minor tweaks
- wtf/HashTable.h: (WTF::): (WTF::HashTableConstIterator::HashTableConstIterator): (WTF::HashTableIterator::HashTableIterator): (WTF::IdentityHashTranslator::translate): (WTF::HashTable::end): (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::makeKnownGoodIterator): (WTF::HashTable::makeKnownGoodConstIterator): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add): (WTF::::addPassingHashCode): (WTF::::reinsert): (WTF::::find): (WTF::::contains):
- kjs/identifier.cpp: (WTF::):
- wtf/HashFunctions.h: (WTF::):
- wtf/HashMap.h: (WTF::): (WTF::::get):
- wtf/HashSet.h: (WTF::): (WTF::::add):
- wtf/ListHashSet.h: (WTF::ListHashSetTranslator::translate):
- 1:02 AM Changeset in webkit [27175] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15217
Plugin complains that xpcom_core.dll missing
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isPluginBlacklisted): Blacklist npmozax.dll.
- 12:32 AM Changeset in webkit [27174] by
-
- 3 edits in trunk/WebCore
Reviewed by Adam.
Pass the Document's domain to InspectorController:didOpenDatabase. This matches
what the Inspector shows for other resources.
- storage/Database.cpp: (WebCore::Database::openDatabase):
- dom/Document.h: Remove KURL.h, no longer needed.
- 12:08 AM Changeset in webkit [27173] by
-
- 14 edits in trunk/WebCore
Reviewed by Adam.
Bug 15728: Selected Resource background image gradient has banding
http://bugs.webkit.org/show_bug.cgi?id=15728
- Reduced images to 1px wide that are tiled horizontally in CSS.
- Corrected the -webkit-background-size usage to specify auto for the width.
- page/inspector/Images/attachedShadow.png:
- page/inspector/Images/bottomShadow.png:
- page/inspector/Images/darkShadow.png:
- page/inspector/Images/gradient.png:
- page/inspector/Images/gradientHighlight.png:
- page/inspector/Images/gradientHighlightBottom.png:
- page/inspector/Images/sidebarSelection.png:
- page/inspector/Images/sidebarSelectionBlurred.png:
- page/inspector/Images/sidebarSelectionBlurredTall.png:
- page/inspector/Images/sidebarSelectionGray.png:
- page/inspector/Images/sidebarSelectionGrayTall.png:
- page/inspector/Images/sidebarSelectionTall.png:
- page/inspector/inspector.css:
- 12:04 AM Changeset in webkit [27172] by
-
- 2 edits in trunk/LayoutTests
Re-enable a bunch of passing tests on Windows
Reviewed by NOBODY.
- platform/win/Skipped:
Oct 27, 2007:
- 11:45 PM Changeset in webkit [27171] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam.
Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
http://bugs.webkit.org/show_bug.cgi?id=15727
Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.
- page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when the panel is shown and when resizing the DOM sidebar.
- page/inspector/FontPanel.js: Implement resize.
- page/inspector/NetworkPanel.js: Ditto.
- page/inspector/inspector.js: Add a window resize listener.
- 11:31 PM Changeset in webkit [27170] by
-
- 11 edits in trunk/WebCore
Reviewed by Oliver.
- update for HashTable changes
- bindings/js/JSSVGPODTypeWrapper.h:
- dom/Document.h:
- dom/QualifiedName.cpp:
- dom/StyledElement.cpp:
- ksvg2/svg/SVGAnimatedTemplate.h:
- platform/FontCache.cpp:
- platform/StringHash.h: (WTF::):
- platform/TextEncodingRegistry.cpp:
- platform/graphics/IntSizeHash.h: (WTF::):
- plugins/win/PluginPackageWin.h:
- 10:34 PM Changeset in webkit [27169] by
-
- 5 edits in trunk/WebCore
2007-10-28 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15646
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp
Abstract caretBlinkFrequency to RenderTheme.
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretShouldBlink): (WebCore::RenderThemeGtk::caretBlinkFrequency):
- platform/gtk/RenderThemeGtk.h:
- rendering/RenderTheme.h:
- 10:22 PM Changeset in webkit [27168] by
-
- 2 edits in trunk/WebKit/gtk
2007-10-28 Lars Lindner <lars.lindner@gmail.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15466
[gtk] widget does not take focus on mouse click
Grab widget focus in mouse press callback.
- Api/webkitgtkpage.cpp:
- 10:02 PM Changeset in webkit [27167] by
-
- 2 edits in trunk/LayoutTests
Updated Windows Skipped file for currently failing tests
Reviewed by NOBODY.
- platform/win/Skipped:
- 9:38 PM Changeset in webkit [27166] by
-
- 1 edit5 adds1 delete in trunk/LayoutTests
Fix HTMLDocument12.xhtml on Leopard/Windows
<rdar://5313535> and <rdar://5539816>
The test succeeds on Leopard and Windows, but fails on Tiger. For some
reason, failing expected results had been checked in to
platform/mac-leopard. The test seems to be passing now, so I moved the
failing results to platform/mac-tiger.
Reviewed by Maciej and Sam.
- platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
- platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Moved from platform/mac-leopard.
- 9:24 PM Changeset in webkit [27165] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Don't print the line number in the Inspector Console if it is Zero.
- page/inspector/ConsolePanel.js:
- 8:31 PM Changeset in webkit [27164] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric.
- fix ASCIICType.h for some Windows compiles
- wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
- 8:12 PM Changeset in webkit [27163] by
-
- 1 edit2 adds in trunk/LayoutTests
Hit with the rubber-stamp of Timothy Hatcher.
Tests for window.console's functions.
- fast/dom/Window/console-functions-expected.txt: Added.
- fast/dom/Window/console-functions.html: Added.
- 7:52 PM Changeset in webkit [27162] by
-
- 2 edits1 add in trunk/LayoutTests
Reviewed by Tim Hatcher.
Speculative fix for an intermittently failing test
- fast/dom/Window/resources/opened-window.html: Added.
- fast/dom/Window/window-early-properties.html: Use onload for opened window and use a local file instead of a data: URL to avoid same origin check issues.
- 7:11 PM Changeset in webkit [27161] by
-
- 13 edits3 adds in trunk
WebCore:
Reviewed by Adam Roben.
Fix http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore
- Adds a window.console object that has 4 methods (log, info, warn, and error) that send messages to the Chrome. This moves functionality that was in the app down into WebCore.
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm: Add extended attribute to mark attributes as [Replacable] which indicates they can overridden when set.
- page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Allow all messages to go up to the ChromeClient.
- page/Console.cpp: Added. (WebCore::Console::Console): (WebCore::Console::disconnectFrame): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::warn):
- page/Console.h: Added.
- page/Console.idl: Added.
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::console):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Reviewed by Adam Roben.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore
- fast/dom/Window/window-properties-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt:
- 5:47 PM Changeset in webkit [27160] by
-
- 2 edits in trunk/LayoutTests
Update results
- 5:02 PM Changeset in webkit [27159] by
-
- 2 edits in trunk/LayoutTests
Speculative fix for an intermittently failing test
Reviewed by Sam and Eric.
- http/tests/local/style-access-before-stylesheet-loaded.html: Use waitUntilDone/notifyDone.
- 4:53 PM Changeset in webkit [27158] by
-
- 20 edits in trunk/WebCore
2007-10-27 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)
No functional changes, thus no tests.
- ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::filterEffect):
- ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
- ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::filterEffect):
- ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::filterEffect):
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
- ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::filterEffect):
- ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
- ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::filterEffect):
- ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::filterEffect):
- ksvg2/svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::filterEffect):
- ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::filterEffect):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
- ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::filterEffect):
- ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::filterEffect):
- platform/graphics/svg/SVGResourceFilter.h:
- platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
- platform/graphics/svg/cg/SVGResourceFilterCg.mm:
- platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
- 4:31 PM Changeset in webkit [27157] by
-
- 2 edits in trunk/LayoutTests
Add some more failing tests to the Windows Skipped file
Reviewed by NOBODY.
- platform/win/Skipped:
- 4:26 PM Changeset in webkit [27156] by
-
- 3 edits2 adds in trunk/WebKit/win
Reviewed by Adam.
- Stubbed out IWebScriptCallFrame for Drosera.
- Interfaces/IWebScriptCallFrame.idl: Added function declarations.
- WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
- WebScriptCallFrame.cpp: Added. (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::~WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::QueryInterface): (WebScriptCallFrame::AddRef): (WebScriptCallFrame::Release): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::evaluateWebScript):
- WebScriptCallFrame.h: Added.
- 4:25 PM Changeset in webkit [27155] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix a crash when opening Zenoss server history view <rdar://problem/5530657>
Test: fast/table/colgroup-relative.html
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Added a hasLayer() check before accessing layer().
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/5530657>
- fast/table/colgroup-relative-expected.txt: Added.
- fast/table/colgroup-relative.html: Added.
- 3:45 PM Changeset in webkit [27154] by
-
- 2 edits in trunk/JavaScriptCore
- BuildFix
- Forgot to change the build step when I changed the filename.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 12:20 PM Changeset in webkit [27153] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
computedHash()"
http://bugs.webkit.org/show_bug.cgi?id=15718
- kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a hash value. Also changed O(n) strlen to O(1) check for empty string. (KJS::Identifier::add):
- kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string. (KJS::UString::UString): (KJS::UString::operator=):
- 12:10 PM Changeset in webkit [27152] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Eric.
- a couple of Windows fixes
- wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has a "pow" function that does not properly handle the case where arg1 is NaN and arg2 is 0.
- kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity specify "::pow" -- just "pow" is fine.
- wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
- 11:51 AM Changeset in webkit [27151] by
-
- 4 edits2 adds in trunk
2007-10-27 Julien <julien.chaffraix@gmail.com>
Reviewed by Alexey.
http://bugs.webkit.org/show_bug.cgi?id=13141
XMLHttpRequest should set readyState to 0 after abort()
Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort):
- 9:54 AM Changeset in webkit [27150] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix rotated border images by using a temporary subimage containing only the part we want to tile
Test: fast/borders/border-image-rotate-transform.html
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
LayoutTests:
Reviewed by Dave Hyatt.
- rotated border image test
- fast/borders/border-image-rotate-transform.html: Added.
- platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
- platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
- platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.
- 7:48 AM Changeset in webkit [27149] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15711 force JSImmediate to be inlined for roughly 1.2% SunSpider speedup
- kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.
- kjs/object.h: Removed redundant includes.
- kjs/value.h: Ditto.
- 3:46 AM Changeset in webkit [27148] by
-
- 2 edits in trunk/WebKit
2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
Reviewed by Darin.
Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- 3:39 AM Changeset in webkit [27147] by
-
- 3 edits in trunk/WebCore
2007-10-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15722
[GTK] Refactor gtk/RenderThemeGtk and implement a few more methods
Refactor/enhance GTK RenderTheme
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::getThemeData):
- platform/gtk/RenderThemeGtk.h: (WebCore::RenderThemeGtk::supportsControlTints):
- 3:23 AM Changeset in webkit [27146] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark.
- fixed "ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash()" http://bugs.webkit.org/show_bug.cgi?id=15718
- kjs/identifier.cpp: (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed, now that we count on all Identifiers already having one.
- 1:40 AM Changeset in webkit [27145] by
-
- 6 edits5 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15555
XMLHttpRequest does not support charset "x-user-defined", which can
facilitate loading of binary data
Test: http/tests/xmlhttprequest/binary-x-user-defined.html
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/TextCodecUserDefined.cpp: Added. (WebCore::TextCodecUserDefined::registerEncodingNames): (WebCore::newStreamingTextDecoderUserDefined): (WebCore::TextCodecUserDefined::registerCodecs): (WebCore::TextCodecUserDefined::decode): (WebCore::encodeComplexUserDefined): (WebCore::TextCodecUserDefined::encode):
- platform/TextCodecUserDefined.h: Added.
- platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
- 1:16 AM Changeset in webkit [27144] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15467
Setting innerHTML to blank string in application/xhtml+xml mode
throws DOM Exception 7
Test: fast/dom/blank-innerHTML.xhtml
- dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Bail out early if the input string is empty.
- 1:11 AM Changeset in webkit [27143] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-27 Mark Rowe <mrowe@apple.com>
Silence a warning.
- kjs/SymbolTable.h:
- 1:08 AM Changeset in webkit [27142] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-27 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/function.h:
Oct 26, 2007:
- 9:42 PM Changeset in webkit [27141] by
-
- 5 edits in trunk/WebCore
Enable dragging the left sidebar using the separator.
Reviewed by Anders (unless Mitz says otherwise).
- page/inspector/DocumentPanel.js:
- page/inspector/inspector.css:
- page/inspector/inspector.html:
- page/inspector/inspector.js:
- 8:40 PM Changeset in webkit [27140] by
-
- 2 edits in trunk/WebCore
Fix an off by one error when resizing the Inspector find window.
Reviewed by Hyatt.
- page/inspector/inspector.js:
- 7:56 PM Changeset in webkit [27139] by
-
- 2 edits in trunk/WebCore
2007-10-26 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
Fix fallout from r26072, which leads to all plugin streams for local
resources being cancelled
- loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this is an HTTP response before checking the HTTP response code
- 7:50 PM Changeset in webkit [27138] by
-
- 2 edits4 adds in trunk
Fix for http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
when only translation changes.
Move the updating of the transform to in between the old repaint and the new repaint.
Reviewed by mitz
fast/repaint/transform-translate.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- 6:45 PM Changeset in webkit [27137] by
-
- 2 edits2 moves in trunk/JavaScriptCore
Rubber stamp by Adam.
- Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the files contain are functions that operate on BSTRs.
- API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
- API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
- API/JSStringRefCOM.cpp: Removed.
- API/JSStringRefCOM.h: Removed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 6:38 PM Changeset in webkit [27136] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam.
- Implemented the WebScriptDebugListener functions now that the WebScriptDebugServer exists
- Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener functions. (ServerConnection::currentFrame): (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::didParseSource): (ServerConnection::failedToParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
- Drosera/win/ServerConnection.h: Removed unused arguments from the members arguments list.
- 6:37 PM Changeset in webkit [27135] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam.
- Made JSStringCreateWithBSTR capable of handling null BSTRs.
- API/JSStringRefCOM.cpp: (JSStringCreateWithBSTR):
- 6:01 PM Changeset in webkit [27134] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/SymbolTable.h: Add header gaurd.
- kjs/nodes.h: #include "SymbolTable.h"
- 4:33 PM Changeset in webkit [27133] by
-
- 2 edits in trunk/JavaScriptCore
Suggested by Anders Carlsson.
Fixed tyop.
- kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
- 4:31 PM Changeset in webkit [27132] by
-
- 2 edits in trunk/JavaScriptCore
Suggested by Darin Adler.
Use computedHash(), which is safer than just directly accessing _hash.
- kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
- 4:07 PM Changeset in webkit [27131] by
-
- 5 edits in trunk/WebCore
2007-10-26 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://5557379> Crash in Silverlight when opening microsoft.com
The crash is within Silverlight, and the latest version of the plugin
does not exhibit this crash, so just avoid loading this version of the
plugin.
- plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and constants silverlightPluginMinRequiredVersionMSDWORD and silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from the version info of Silverlight 1.0.20926.0, which is a version known not to exhibit this crash (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether this plugin is blacklisted
- plugins/win/PluginDatabaseWin.h:
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion* (WebCore::PluginPackageWin::getFileVersion): (WebCore::PluginPackageWin::storeFileVersion): Read version info for the plugin, and store the file version (WebCore::PluginPackageWin::fetchInfo): After determining the name, description, and file version, determine whether this plug-in is blacklisted. If so, return false so this plug-in isn't loaded
- plugins/win/PluginPackageWin.h:
- 3:59 PM Changeset in webkit [27130] by
-
- 1 edit1 add in trunk/JavaScriptCore
Build fix: svn add SymbolTable.h
- kjs/SymbolTable.h: Added. (KJS::SymbolTable::set): (KJS::SymbolTable::get):
- 3:54 PM Changeset in webkit [27129] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: export SymbolTable.h to WebCore.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 3:47 PM Changeset in webkit [27128] by
-
- 2 edits in trunk/JavaScriptCore
Comment tweak suggested by Maciej.
- kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
- 3:45 PM Changeset in webkit [27127] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.
- kjs/property_map.cpp: Use a special no branch accessor to the UString's hash value. Also, return immediately instead of branching to the end of the loop if the value is not found. (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
- kjs/ustring.h: (KJS::UString::Rep::computedHash): Special no branch accessor to the UString's hash value. Used when the caller knows that the hash value has already been computed. (For example, if the caller got the UString from an Identifier.)
- 3:43 PM Changeset in webkit [27126] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Switched ActivationImp to using a symbol table. For now, though, all
clients take the slow path.
Net .6% speedup on SunSpider.
Slowdowns:
- ActivationImp now mallocs in its constructor
- Local variable hits use an extra level of indirection to retrieve data
- Local variable misses do two lookups
Speedups:
- Fast initialization of local variables upon function entry
- JavaScriptCore.xcodeproj/project.pbxproj: Added SymbolTable.h
- kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold data that won't fit in a JSCell. (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for lookup. (KJS::ActivationImp::getOwnPropertySlot): ditto (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto (KJS::ActivationImp::createArgumentsObject): ditto
(KJS::ActivationImp::mark): Call JSObject::mark first so that one of
our properties doesn't try to recursively mark us. (This caused a crash
in earlier testing. Not sure why we haven't run into it before.)
- kjs/nodes.cpp: Functions now build a symbol table the first time they're called. (KJS::VarDeclNode::evaluate): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode): (KJS::FunctionBodyNode::processDeclarationsForProgramCode):
- kjs/nodes.h: (KJS::FunctionBodyNode::symbolTable):
- wtf/Forward.h: Added Vector.
- 2:44 PM Changeset in webkit [27125] by
-
- 8 edits in trunk/WebCore
Reviewed by Adele Peterson.
Fix for <rdar://problem/5421754>
m_frameName member variable in HTMLPlugInElement unnecessary
- Refactor the willRemove() method down into HTMLFrameOwnerElement now that we no longer need to use the m_frameName variable.
- html/HTMLFrameElementBase.cpp:
- html/HTMLFrameElementBase.h:
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
- html/HTMLFrameOwnerElement.h:
- html/HTMLPlugInElement.cpp:
- html/HTMLPlugInElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
- 2:28 PM Changeset in webkit [27124] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
- Corrected function name mistake in this changelog.
- 2:19 PM Changeset in webkit [27123] by
-
- 6 edits2 adds in trunk
Reviewed by Sam and Steve.
- Added convenience methods for converting between BSTR and JSStringRefs
- API/JSStringRefCOM.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString):
- API/JSStringRefCOM.h: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
win:
Reviewed by Sam and Steve.
- Added convenience methods for converting between BSTR and JSSTringRefs
- Added WebKit_debug.def to the project.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKit_debug.def:
- 2:03 PM Changeset in webkit [27122] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Reverting an unintentional added symbol
- 1:55 PM Changeset in webkit [27121] by
-
- 2 edits in trunk/WebCore
Export _wkDrawCapsLockIndicator.
- WebCore.base.exp:
- 1:28 PM Changeset in webkit [27120] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by Tim Hatcher.
Updating header too for WKDrawCapsLockIndicator.
- WebKitSystemInterface.h:
- 12:52 PM Changeset in webkit [27119] by
-
- 8 edits in trunk
WebCore:
Reviewed by Oliver.
Adding WebKitSystemInterface support for the caps lock indicator
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Oliver.
Adding WebKitSystemInterface support for the caps lock indicator
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Oliver.
Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 12:22 PM Changeset in webkit [27118] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening http://research.microsoft.com/users/darkok/
The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
but failed to account for bounds checking (instead replaced with bounds clipping). This caused issues
when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
setting window bounds to NaN before an update occurs.
Test: fast/dom/Window/window-resize-nan.html
- bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): Added a new parameter, pendingChanges, which takes pending changes to the window rect, and if they are valid (not NaN) sets them on window.
(KJS::WindowFunc::callAsFunction):
Adjusted uses of adjustWindowRect to take new update parameter.
LayoutTests:
Reviewed by Darin Adler.
Added new test cases to handle non-number input to window adjusting
functions like resizeTo, resizeBy, moveTo, and moveBy for
<rdar://problem/5555053>.
- fast/dom/Window/window-resize-nan-expected.txt: Added.
- fast/dom/Window/window-resize-nan.html: Added.
- 11:39 AM Changeset in webkit [27117] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15175
Cannot copy text of errors from Web Inspector from Console view
- page/inspector/inspector.css: add -webkit-user-select: text for console messages.
- 11:17 AM Changeset in webkit [27116] by
-
- 4 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15446
Web Inspector find window is not resizable
- Adds ability to resize the find window.
- Fixes bug that messed up the find window when resizing the left sidebar.
- page/inspector/inspector.css:
- page/inspector/inspector.html:
- page/inspector/inspector.js:
- 10:15 AM Changeset in webkit [27115] by
-
- 1 copy in tags/Safari-523.12.9b
New tag.
- 10:15 AM Changeset in webkit [27114] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 9:34 AM Changeset in webkit [27113] by
-
- 2 edits in trunk/WebCore
Update m_current index after we've removed an item:
- if item removed is before m_current, decrement m_current
- if the current item is removed, make sure m_current is within bounds.
Reviewed by Darin.
- history/BackForwardList.cpp: (WebCore::BackForwardList::removeItem):
- 8:38 AM Changeset in webkit [27112] by
-
- 3 edits1 add in trunk/WebKitTools
prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
<http://bugs.webkit.org/show_bug.cgi?id=15600>
Reviewed by Darin.
The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
a patch of the local changes and applying it with a fuzz level of 3 to the new file.
If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
file. Note that it may also be used as a stand-alone script.
- Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
- Scripts/resolve-ChangeLogs: Added.
- Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
- 6:34 AM Changeset in webkit [27111] by
-
- 1 edit in trunk/JavaScriptCore/kjs/collector.cpp
Restore the semicolon.
- 6:31 AM Changeset in webkit [27110] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Windows build fix.
- kjs/collector.cpp: (KJS::Collector::collect):
- 5:22 AM Changeset in webkit [27109] by
-
- 2 edits in trunk/WebKit/qt
2007-10-26 Mark Rowe <mrowe@apple.com>
Build fix. Add missing #include of Platform.h.
- Api/qwebhistoryinterface.cpp:
- 5:07 AM Changeset in webkit [27108] by
-
- 2 edits in trunk/WebCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Debug build fix.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
- 5:06 AM Changeset in webkit [27107] by
-
- 6 edits in trunk/JavaScriptCore
Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.
Reviewed by Maciej
- kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::init): (KJS::CollectorHeapIntrospector::enumerate):
- kjs/CollectorHeapIntrospector.h:
- kjs/collector.cpp: (KJS::Collector::recordExtraCost): (KJS::Collector::heapAllocate): (KJS::Collector::allocate): (KJS::Collector::allocateNumber): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::sweep): (KJS::Collector::collect):
- kjs/collector.h:
- kjs/internal.h: (KJS::NumberImp::operator new): Force numbers to be allocated in the secondary heap.
- 4:53 AM Changeset in webkit [27106] by
-
- 2 edits in trunk/WebCore
No review, build fix.
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):
- 4:50 AM Changeset in webkit [27105] by
-
- 1 edit in trunk/WebCore/ChangeLog
Rubber Stamped by Mark.
- fix build
- bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
- 4:48 AM Changeset in webkit [27104] by
-
- 2 edits in trunk/WebCore
Rubber Stamped by Oliver.
- fix build
- bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
- 4:46 AM Changeset in webkit [27103] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.
- kjs/value.h: (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): (KJS::JSValue::toNumber):
- wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr):
- wtf/RefPtr.h: (WTF::RefPtr::operator->):
- 3:45 AM Changeset in webkit [27102] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix ChangeLog ordering.
- 3:44 AM Changeset in webkit [27101] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/ExecState.h:
- 3:36 AM Changeset in webkit [27100] by
-
- 8 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:38 AM Changeset in webkit [27099] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:38 AM Changeset in webkit [27098] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- JavaScriptCore.pri:
- kjs/ExecState.cpp:
- 1:32 AM Changeset in webkit [27097] by
-
- 17 edits1 add2 deletes in trunk
Reviewed by Oliver.
- moved Context class into ExecState.{h,cpp} in preparation for merging ExecState and Context classes.
- kjs/ExecState.h: Moved CodeType enum and Context class here in preparation for merging ExecState and Context.
- kjs/ExecState.cpp: Moved Context class here from Context.cpp. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
- kjs/context.h: Removed.
- kjs/Context.cpp: Removed.
- kjs/function.h: Removed CodeType enum.
- kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
- kjs/internal.h: Removed LabelStack.
- JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
- kjs/collector.cpp: Fixed includes.
- kjs/function.cpp: ditto
- kjs/internal.cpp: ditto
- kjs/interpreter.cpp: ditto
- kjs/lookup.h: ditto
- kjs/nodes.cpp: ditto
WebCore:
Reviewed by Oliver.
- update for JavaScriptCore header changes
- bindings/objc/WebScriptObject.mm:
- bridge/mac/WebCoreScriptDebugger.mm:
- 1:13 AM Changeset in webkit [27096] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-26 Mark Rowe <mrowe@apple.com>
Windows build fix.
- kjs/string_object.cpp: (KJS::StringObjectFuncImp::callAsFunction):
- 12:51 AM Changeset in webkit [27095] by
-
- 14 edits in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15703 fix numeric functions -- improve correctness and speed
Gives about 1% gain on SunSpider.
- kjs/value.h: Added toIntegerPreserveNan, removed toUInt16. (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works with both immediate and number values. (KJS::JSValue::toUInt32): Ditto.
- kjs/value.cpp: (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple differences. One is that it now correctly returns 0 for NaN, and another is that there's no special case for 0 or infinity, since the general case already handles those correctly. (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the check for NaN. (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The truncation done by the typecast already does the necessary truncation that roundValue was doing. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Removed.
- kjs/internal.h: Removed roundValue.
- kjs/internal.cpp: Ditto.
- kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded code to handle NaN in Array.slice; toInteger now never returns NaN as specified.
- kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to toNumber as specified. (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue with a call to toNumber and timeClip as specified. (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases where the default behavior of toInt32 (returning 0) was already correct. Replaced call to roundValue with a call to toNumber as specified. (KJS::DateObjectFuncImp::callAsFunction): Ditto.
- kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special cases for the pow function that the library already handles correctly.
- kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to call toIntegerPreserveNaN, so we can continue to handle the NaN case differently. The real toInteger now returns 0 for NaN. Took out unneeded special case in ToFixed for undefined; was only needed because our toInteger was wrong. Same thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special cases for undefined that were only needed because toInteger was wrong. Same in IndexOf, and was able to remove some special cases. In LastIndexOf, used toIntegerPreserveNaN, but was able to remove some special cases there too. Changed Substr implementation to preserve correct behavior with the change to toInteger and match the specification. Also made sure we weren't converting an out of range double to an int. (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's no reason to have toUInt16 as a second, less-optimized function that's only called at this one call site.
- wtf/MathExtras.h: Added trunc function for Windows.
LayoutTests:
Reviewed by Maciej.
- test changes for http://bugs.webkit.org/show_bug.cgi?id=15703 fix numeric functions -- improve correctness and speed
- fast/js/resources/char-at.js: Updated test to expect that we get the first character if we pass NaN to charAt and charCodeAt; it's what the specification asks for and matches other browsers too.
- fast/js/char-at-expected.txt: Updated.
Oct 25, 2007:
- 11:58 PM Changeset in webkit [27094] by
-
- 2 edits in trunk/LayoutTests
2007-10-26 Mark Rowe <mrowe@apple.com>
Update expected results.
- platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- 11:55 PM Changeset in webkit [27093] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Tweaked the inner hashtable lookup loop to remove a branch in the "not
found" case. .5% speedup on SunSpider.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/HashTable.h: (WTF::::lookup):
- 11:55 PM Changeset in webkit [27092] by
-
- 2 edits in trunk/WebKitTools
2007-10-26 Mark Rowe <mrowe@apple.com>
Qt build fix. r27084 added a destructor implementation for LayoutTestController
to the Qt port on the assumption that it was an implementation of the cross-platform
LayoutTestController class. It is not, so it did not need to be changed.
- DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
- 11:36 PM Changeset in webkit [27091] by
-
- 2 edits in trunk/WebKitTools
2007-10-25 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Fix builds with code coverage enabled.
- Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
- 11:19 PM Changeset in webkit [27090] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
- Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
- Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
- 11:09 PM Changeset in webkit [27089] by
-
- 2 moves in releases/Apple
Rename 10.4 and 10.5 release tags.
- 10:25 PM Changeset in webkit [27088] by
-
- 4 copies2 adds in releases/Apple/Leopard
Release tags for Mac OS X 10.5.
- 10:01 PM Changeset in webkit [27087] by
-
- 2 edits in trunk/WebKitTools
build Fix
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 9:10 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:06 PM JavaScript performance improvement ideas edited by
- (diff)
- 8:58 PM Changeset in webkit [27086] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider
- kjs/nodes.cpp: (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not adding any value over toNumber() here. (KJS::valueForReadModifyAssignment): Ditto. (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls and branches. (KJS::lessThanEq): Ditto.
- JavaScriptCore.exp: Export new functions as needed.
- kjs/value.h: (KJS::JSValue::toPrimitive): Fixed formatting. (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts to number and tells you whether a toPrimitive() conversion with a Number hint would have given a string.
- kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Implemented. (KJS::NumberImp::getPrimitiveNumber): ditto (KJS::GetterSetterImp::getPrimitiveNumber): ditto (KJS::StringImp::toPrimitive): Fixed formatting. (KJS::NumberImp::toPrimitive): ditto (KJS::GetterSetterImp::toPrimitive): ditto
- kjs/internal.h:
- kjs/object.cpp: (KJS::JSObject::getPrimitiveNumber): Implemented.
- kjs/object.h:
- 8:42 PM Changeset in webkit [27085] by
-
- 2 edits in trunk/WebKitTools
Weak link against WebCore so DumpRenderTree can be bundled with production roots.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 8:09 PM Changeset in webkit [27084] by
-
- 7 edits in trunk/WebKitTools
Reviewed by Adam.
Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
Moving destructor into platform-specific files
- DumpRenderTree/LayoutTestController.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::~LayoutTestController):
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::~LayoutTestController):
LayoutTestController wasn't being destroyed
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
Added declspec
- DumpRenderTree/win/EditingDelegate.h:
Reset certain values on the webview (or related delegate) that might
have changed while running a test
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::~LayoutTestController):
- 7:46 PM Changeset in webkit [27083] by
-
- 2 edits in trunk/WebCore
2007-10-26 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15693
[GTK] Paging does not work when widget is added to a GtkScrolledWindow
Eliminate MagicGtkScrollConstant in favour of the same calculations as
GtkTextView for step and page increments. This also makes paging work,
as the page increment was previously always 0.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
- 6:44 PM Changeset in webkit [27082] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj
Fix the windows build for real
- 6:11 PM Changeset in webkit [27081] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam Roben.
Make debug builds run again.
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 6:09 PM Changeset in webkit [27080] by
-
- 4 edits in trunk/WebKitLibraries
Add wkSetPatternBaseCTM.
Reviewed by NOBODY.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 6:09 PM Changeset in webkit [27079] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
Remove JSStringRefCFHack from windows as it is no longer needed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
win:
Reviewed by Adam Roben.
Remove JSStringRefCFHack.
- WebKit.vcproj/WebKit.vcproj:
- 5:10 PM Changeset in webkit [27078] by
-
- 10 edits2 adds in trunk/WebKit/win
Reviewed by Steve Falkenburg.
Fix for <rdar://problem/5463608>
Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)
- Interfaces/IWebPreferences.idl: Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.
- Interfaces/IWebPreferencesPrivate.idl: Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel
- WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Implement based on the mac version.
- WebKit.vcproj/WebKit.vcproj:
- WebKitSystemBits.cpp: Added. (WebMemorySize): Moved and renamed from WebPreferences.cpp (WebVolumeFreeSize): Added.
- WebKitSystemBits.h: Added.
- WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.
- WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): (WebPreferences::WebPreferences): (WebPreferences::initializeDefaultSettings): Added default for cacheModel. (WebPreferences::webPreferencesChangedNotification): (WebPreferences::webPreferencesRemovedNotification): (WebPreferences::initWithIdentifier): Post a preferences change notification. (WebPreferences::pageCacheSize): Deprecated. (WebPreferences::objectCacheSize): Deprecated. (WebPreferences::cacheModel): Added. (WebPreferences::setCacheModel): Added. (WebPreferences::setAutomaticallyDetectsCacheModel): Added. (WebPreferences::automaticallyDetectsCacheModel): Added. (WebPreferences::willAddToWebView): Added. (WebPreferences::didRemoveFromWebView): Added.
- WebPreferences.h:
- WebView.cpp: (PreferencesChangedOrRemovedObserver::PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::~PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::QueryInterface): (PreferencesChangedOrRemovedObserver::AddRef): (PreferencesChangedOrRemovedObserver::Release): (PreferencesChangedOrRemovedObserver::sharedInstance): (PreferencesChangedOrRemovedObserver::onNotify): (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged): (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved): This singleton class updates static properties for all webviews when preferenceChange or preferenceRemoved notifications are fired for any WebPreference. (WebView::WebView): (WebView::~WebView): (initializeStaticObservers): (allWebViewsSet): (WebView::addToAllWebViewsSet): (WebView::removeFromAllWebViewsSet): (WebView::setCacheModel): (WebView::cacheModel): (WebView::didSetCacheModel): (WebView::maxCacheModelInAnyInstance): (WebView::close): (WebViewWndProc): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::setPreferences): (WebView::preferences): (WebView::onNotify): (WebView::notifyPreferencesChanged): (updateSharedSettingsFromPreferencesIfNeeded):
- WebView.h: Match the macs behavior by using explicit postings of notifications to update the preferences.
- 4:38 PM Changeset in webkit [27077] by
-
- 2 edits in trunk/WebKitTools
Make sunspider-compare-results work with relative paths
Reviewed by Sam.
- Scripts/sunspider-compare-results: Convert arguments to absolute paths before we chdir.
- 4:33 PM Changeset in webkit [27076] by
-
- 1 edit in trunk/WebCore/platform/graphics/cg/ImageCG.cpp
Fix unbalanced save/restore on Leopard only.
- 4:23 PM Changeset in webkit [27075] by
-
- 2 edits in trunk/SunSpider
Strip carriage returns from results
Carriage returns were screwing up sunspider-compare-results on
Windows.
Rubberstamped by Oliver.
- sunspider:
- 4:17 PM Changeset in webkit [27074] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt and Sam Weinig.
Build fix
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- 4:16 PM Changeset in webkit [27073] by
-
- 3 edits in trunk/WebKitLibraries
Fix the windows build.
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 3:29 PM Changeset in webkit [27072] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Rolled out my last patch. It turns out that I needed 2 words, not 1,
so it didn't help.
- 3:23 PM Changeset in webkit [27071] by
-
- 4 edits in trunk/WebKitLibraries
Add WKSetPatternBaseCTM.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:13 PM Changeset in webkit [27070] by
-
- 1 delete in trunk/WebKitQt
Remove the empty WebKitQt folders.
- 2:56 PM Changeset in webkit [27069] by
-
- 2 edits in trunk/WebCore
2007-10-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): Implemented.
- 2:37 PM Changeset in webkit [27068] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15694
Shrink the size of an activation object by 1 word
This is in preparation for adding a symbol table to the activation
object.
The basic strategy here is to rely on the mutual exclusion between
the arguments object pointer and the function pointer (you only need
the latter in order to create the former), and store them in the same
place. The LazyArgumentsObject class encapsulates this strategy.
Also inlined the ArgumentsImp constructor, for good measure.
SunSpider reports no regression. Regression tests pass.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Context.cpp: (KJS::Context::~Context):
- kjs/function.cpp: (KJS::ActivationImp::LazyArgumentsObject::createArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::mark): (KJS::): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::mark):
- kjs/function.h: (KJS::ActivationImp::LazyArgumentsObject::LazyArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::getOrCreate): (KJS::ActivationImp::LazyArgumentsObject::resetArguments): (KJS::ActivationImp::LazyArgumentsObject::setArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::argumentsObject): (KJS::ActivationImp::LazyArgumentsObject::setFunction): (KJS::ActivationImp::LazyArgumentsObject::function): (KJS::ActivationImp::LazyArgumentsObject::createdArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::): (KJS::ActivationImp::ActivationImp::ActivationImp): (KJS::ActivationImp::resetArguments):
- 2:32 PM Changeset in webkit [27067] by
-
- 1 edit in trunk/WebCore/ChangeLog
Weinig also reviewed this patch, and wanted Changelog credit for it
- 2:26 PM Changeset in webkit [27066] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Sam.
- Implemented server calls now the WebScriptDebugServer exists.
- Also removed no longer needed call to initialize CG.
- Drosera/win/Drosera.cpp: No longer initializes CG because this happens automatically now. (_tWinMain):
- Drosera/win/ServerConnection.cpp: Now uses the COM class. (ServerConnection::ServerConnection): (ServerConnection::~ServerConnection): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie):
- Drosera/win/ServerConnection.h: Now uses the COM class.
- 2:12 PM Changeset in webkit [27065] by
-
- 3 adds in trunk/LayoutTests/platform/mac/fast/borders
Add border image transforms test.
- 2:11 PM Changeset in webkit [27064] by
-
- 1 add in trunk/LayoutTests/fast/borders/border-image-scale-transform.html
Add border image transforms test.
- 2:09 PM Changeset in webkit [27063] by
-
- 3 adds in trunk/LayoutTests/platform/mac/fast/backgrounds/repeat
Add background transform test.
- 2:08 PM Changeset in webkit [27062] by
-
- 1 add in trunk/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed.html
Add background transform test.
- 2:03 PM Changeset in webkit [27061] by
-
- 9 edits1 delete in trunk
Fix some JavaScriptCore build issues
Change JavaScriptCore.vcproj to use DerivedSources.make
We were trying to emulate the logic of make in
build-generated-files.sh, but we got it wrong. We now use a
build-generated-files very much like the one that WebCore uses to
invoke make.
We also now only have a Debug configuration of dftables which we build
even when doing a Release build of JavaScriptCore. dftables also no
longer has the "_debug" name suffix.
Changes mostly made by Darin, reviewed by me.
- DerivedSources.make: Add a variable to set the extension used for the dftables executable.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug dftables in Release configurations.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Updated include path to point to the new location of the derived sources.
- Modified pre-build event to pass the right arguments to build-generated-files.sh and not call dftables directly.
- Added the derived source files to the project.
- Removed grammarWrapper.cpp, which isn't needed now that we're compiling grammar.cpp directly.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Slightly modified from the WebCore version.
- JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
- JavaScriptCore.vcproj/dftables/dftables.vcproj:
- Changed the output location to match Mac.
- Removed the Release configuration.
- Removed the _debug suffix.
win:
Update WebKit.sln for the removal of Release dftables
Reviewed by NOBODY.
- WebKit.vcproj/WebKit.sln:
- 2:03 PM Changeset in webkit [27060] by
-
- 9 edits in trunk
WebCore:
Fix for bug 15672, background images don't tile properly inside transforms. This patch fixes background
tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.
Reviewed by aroben and mitz
- WebCore.base.exp:
- platform/graphics/Image.cpp: (WebCore::Image::setData):
- platform/graphics/cg/ImageCG.cpp: (WebCore::ImageInfo::ImageInfo): (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit:
Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.
Reviewed by aroben and mmitz
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- WebKit.xcodeproj/project.pbxproj:
- 1:46 PM Changeset in webkit [27059] by
-
- 5 edits in trunk/WebKit
Reviewed by Tim Hatcher
Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.
- WebView/WebPreferencesPrivate.h: removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with a comment that says that they can be removed when no longer needed. That time is now.
- WebView/WebPreferences.m: (+[WebPreferences initialize]): removed WebKitUsePDFPreviewViewPreferenceKey (-[WebPreferences _usePDFPreviewView]): removed (-[WebPreferences _setUsePDFPreviewView:]): removed
- WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): don't check _usePDFPreviewView
- WebView/WebPreferenceKeysPrivate.h: removed WebKitUsePDFPreviewViewPreferenceKey
- 1:37 PM Changeset in webkit [27058] by
-
- 4 edits in trunk/WebKit/win
Rubber stamped by Geoff.
- Stubbed out the WebScriptDebugServer methods to give Drosera something to connect to and now the signature of the interface matches the mac.
- Interfaces/IWebScriptDebugServer.idl:
- WebScriptDebugServer.cpp: (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
- WebScriptDebugServer.h:
- 1:17 PM Changeset in webkit [27057] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by Adam.
Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.
- libWebKitSystemInterfaceLeopard.a:
- 12:37 PM Changeset in webkit [27056] by
-
- 2 edits in trunk/WebCore
Blind build fix attempt
- WebCore.pro:
- 12:26 PM Changeset in webkit [27055] by
-
- 4 edits in trunk/WebKitLibraries
Added wrapper for getting the foundation cache directory.
Reviewed by Adam Roben.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 12:26 PM Changeset in webkit [27054] by
-
- 11 edits8 moves in trunk/WebCore
Reviewed by Anders
Bulk rename of platform/sql/SQL* to platform/sql/SQLite*
This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
the HTML5 database API which we are adopting.
- 11:47 AM Changeset in webkit [27053] by
-
- 9 edits3 moves in trunk/WebKit/win
Reviewed by Darin.
- Renamed WebDebugProgram to WebScriptDebugServer to match the naming scheme on the mac.
- Interfaces/IWebDebugProgram.idl: Removed.
- Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
- Interfaces/WebKit.idl:
- WebDebugProgram.cpp: Removed.
- WebDebugProgram.h: Removed.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
- WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
- WebKitDLL.cpp: (RunAsLocalServer):
- WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::~WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::QueryInterface): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::viewAdded): (WebScriptDebugServer::viewRemoved): (WebScriptDebugServer::attach): (WebScriptDebugServer::detach): (WebScriptDebugServer::statistics): (WebScriptDebugServer::webViews):
- WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
- WebView.cpp: (WebView::WebView): (WebView::~WebView):
- 11:31 AM Changeset in webkit [27052] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15650
XML attribute nodes are not importable
Tests: fast/dom/import-attribute-node.html
fast/dom/import-document-fragment.html
- dom/Document.cpp: (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.
- 11:23 AM Changeset in webkit [27051] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
Test: fast/dynamic/insert-before-table-part-in-continuation.html
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
- fast/dynamic/insert-before-table-part-in-continuation.html: Added.
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
- 11:21 AM Changeset in webkit [27050] by
-
- 4 edits in trunk
2007-10-25 Alp Toker <alp@atoker.com>
Reviewed by Brady.
http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem
Re-enable database support in the GTK+ port, with a fix.
Initialize GLib threading as early as possible.
- 10:51 AM Changeset in webkit [27049] by
-
- 5 edits in branches/Safari-3-branch/WebCore
Merged fix from r27048.
- 10:35 AM Changeset in webkit [27048] by
-
- 5 edits in trunk/WebCore
2007-10-25 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Steve.
<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
Previous patch erroneously compared a path and a
path-including-filename. This corrects that. It also caches the result
of safariPluginsPath() and uses shell API funcs for determining filename
and parent directory from a full path.
- ChangeLog:
- plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Cache return value. Use API functions to build the path (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's parent directory, not full path (WebCore::PluginDatabaseWin::pluginForExtension): Same
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
- plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::parentDirectory):
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
- 8:00 AM Changeset in webkit [27047] by
-
- 4 edits in trunk
2007-10-25 Alp Toker <alp@atoker.com>
Unreviewed fix to make the GTK+ port run.
http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem
http://bugs.webkit.org/show_bug.cgi?id=15688
[GTK] Make it possible to disable database support
Disable database support until #15686 is fixed.
- 6:44 AM Changeset in webkit [27046] by
-
- 2 edits in trunk/WebCore
Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.
- 6:41 AM Changeset in webkit [27045] by
-
- 7 edits in trunk
- We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
- libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
- This is causing some regressions...
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:41 AM Changeset in webkit [27044] by
-
- 4 edits1 delete in trunk
- Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
- We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:41 AM Changeset in webkit [27043] by
-
- 6 edits in trunk
- fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
- Use the error message from Qt. It might or might not be translated.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:41 AM Changeset in webkit [27042] by
-
- 2 edits in trunk/WebKit/qt
- Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
- We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:41 AM Changeset in webkit [27041] by
-
- 4 edits in trunk/WebKit/qt
- No need to initialize values in the QWebNetworkJob c'tor
- Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:41 AM Changeset in webkit [27040] by
-
- 2 edits in trunk/WebKit/qt
- Consistency: Always name the jobs job.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:40 AM Changeset in webkit [27039] by
-
- 8 edits in trunk
- Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
- This should be thread-safe besides QWebNetworkJob::{ref,deref}
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 6:40 AM Changeset in webkit [27038] by
-
- 4 edits in trunk
- Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
- Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
- We pass the char-decoding.html test now
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 5:36 AM Changeset in webkit [27037] by
-
- 3 edits in trunk/WebCore
2007-10-25 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Add support for list box theme colors and styled menu list buttons.
Remove obsolete FIXMEs.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkTreeView):
- platform/gtk/RenderThemeGtk.h:
- 4:55 AM Changeset in webkit [27036] by
-
- 1 edit in trunk/WebKitSite/ChangeLog
Corrected ChangeLog entry.
- 4:53 AM Changeset in webkit [27035] by
-
- 2 edits in trunk/WebKitSite
Rubber-stamped by Mark Rowe.
- images/download.png: Updated to say "Nightly builds" instead of
"Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
download link anyway.
- 4:36 AM Changeset in webkit [27034] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r27033 as it broke the JavaScriptCore tests.
- 2:59 AM Changeset in webkit [27033] by
-
- 2 edits in trunk/JavaScriptCore
HackTop [30311:JavaScriptCore]% less ChangeLog Stuff/Projects/WebKit/JavaScriptCore
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Start work on long-running-mode from the perl-script side of things.
jsDriver.pl will likely be removed (and replaced by something better)
But for now, I'm just hacking it down to something smaller.
- tests/mozilla/jsDriver.pl: Remove lots of unused code.
- 2:25 AM Changeset in webkit [27032] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric Seidel.
Slightly elaborated the differences between declaration procesing in
Function Code and Program Code.
.3% speedup on SunSpider.
- kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a minimum set of attributes instead of recomputing all the time. Also, ignore m_parameters, since programs don't have arguments.
- 2:08 AM Changeset in webkit [27031] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
More preparation work before adding long-running mode to testkjs.
- kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (prettyPrintScript): (runWithScripts): (parseArguments): (kjsmain): (fillBufferWithContentsOfFile):
- 1:53 AM Changeset in webkit [27030] by
-
- 1 add in trunk/WebKit/win/Interfaces/IWebTextRenderer.idl
Forgot to check in this file in r27019
- 1:37 AM Changeset in webkit [27029] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Bring testkjs code out of the dark ages in preparation for more
radical improvements (like long-running testing support!)
- kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (setupInterpreter): (doIt): (fillBufferWithContentsOfFile):
- 1:11 AM Changeset in webkit [27028] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Make a fast path for declaration processing inside Function Code.
Lifted declaration processing code up from individual declaration nodes
and into processDeclarations.
Broke out processDeclarations into two cases, depending on the type of
code. This eliminates 2 branches, and facilitates more radical
divergeance in the future.
2.5% SunSpider speedup.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/nodes.cpp: (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): (KJS::FunctionBodyNode::execute): (KJS::FuncDeclNode::makeFunction):
- kjs/nodes.h: (KJS::):
- 12:26 AM JavaScript performance improvement ideas edited by
- (diff)
- 12:16 AM Changeset in webkit [27027] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Adam.
- add header includes needed on platforms that don't use AllInOneFile.cpp
- API/JSCallbackObject.cpp:
- kjs/Context.cpp:
- kjs/ExecState.cpp:
- kjs/array_instance.cpp:
- kjs/function_object.cpp:
- kjs/interpreter.cpp:
- kjs/nodes.cpp:
- 12:14 AM Changeset in webkit [27026] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Geoff.
- JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private
- 12:09 AM Changeset in webkit [27025] by
-
- 6 edits4 adds in trunk
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15683
Re-order declaration initialization to avoid calling hasProperty inside
VarDeclNode::processDeclaration
.7% speedup on SunSpider.
- kjs/function.h:
- kjs/function.cpp: Merged parameter processing into FunctionBodyNode's other processing of declared symbols, so the order of execution could change.
- kjs/nodes.cpp: (KJS::VarDeclNode::getDeclarations): Added special case for the "arguments" property name, explained in the comment.
(KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
in the case of function code, since we know the declared symbol
management will resolve conflicts between symbols. Yay!
(KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
implementation of getDeclarations is non-trivial, we can't take a
short-cut here any longer -- we need to put the VarDecl node on the
stack so it gets processed normally.
(KJS::FunctionBodyNode::processDeclarations): Changed the order of
processing to enforce mutual exclusion rules.
- kjs/nodes.h: (KJS::DeclarationStacks::DeclarationStacks): Structure includes an ExecState now, for fast access to the "arguments" property name.
LayoutTests:
Layout tests for bugs that might result from changes like
http://bugs.webkit.org/show_bug.cgi?id=15683
- fast/js/vardecl-preserve-parameters-expected.txt: Added.
- fast/js/vardecl-preserve-parameters.html: Added.
- fast/js/vardecl-preserve-vardecl-expected.txt: Added.
- fast/js/vardecl-preserve-vardecl.html: Added.
- 12:08 AM Changeset in webkit [27024] by
-
- 2 edits in trunk/WebCore
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Geoff.
- bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/
- 12:07 AM Changeset in webkit [27023] by
-
- 4 edits in trunk/JavaScriptGlue
2007-10-25 Eric Seidel <eric@webkit.org>
Reviewed by Geoff.
Make JSG build again after JSGlobalObject change.
- JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
- JSRun.h: (JSInterpreter::JSInterpreter):
- JSUtils.h:
Oct 24, 2007:
- 11:38 PM Changeset in webkit [27022] by
-
- 31 edits1 copy1 add in trunk
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Add a JSGlobalObject class and remove the InterpreterMap
http://bugs.webkit.org/show_bug.cgi?id=15681
This required making JSCallbackObject a template class to allow for
JSGlobalObjects with JSCallbackObject functionality.
SunSpider claims this was a 0.5% speedup.
- API/JSCallbackObject.cpp: (KJS::):
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp. (KJS::::JSCallbackObject): (KJS::::init): (KJS::::~JSCallbackObject): (KJS::::initializeIfNeeded): (KJS::::className): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::implementsConstruct): (KJS::::construct): (KJS::::implementsHasInstance): (KJS::::hasInstance): (KJS::::implementsCall): (KJS::::callAsFunction): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::setPrivate): (KJS::::getPrivate): (KJS::::inherits): (KJS::::cachedValueGetter): (KJS::::staticValueGetter): (KJS::::staticFunctionGetter): (KJS::::callbackGetter):
- API/JSClassRef.cpp: (OpaqueJSClass::prototype):
- API/JSContextRef.cpp: (JSGlobalContextCreate):
- API/JSObjectRef.cpp: (JSObjectMake): (JSObjectGetPrivate): (JSObjectSetPrivate):
- API/JSValueRef.cpp: (JSValueIsObjectOfClass):
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
- bindings/jni/jni_jsobject.cpp:
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
- kjs/Context.cpp: (KJS::Context::Context):
- kjs/ExecState.cpp: (KJS::ExecState::lexicalInterpreter):
- kjs/JSGlobalObject.h: Added. (KJS::JSGlobalObject::JSGlobalObject): (KJS::JSGlobalObject::isGlobalObject): (KJS::JSGlobalObject::interpreter): (KJS::JSGlobalObject::setInterpreter):
- kjs/array_instance.cpp:
- kjs/context.h:
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
- kjs/interpreter.cpp: (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::evaluate):
- kjs/interpreter.h:
- kjs/lookup.h: (KJS::cacheGlobalObject):
- kjs/object.h: (KJS::JSObject::isGlobalObject):
- kjs/testkjs.cpp:
- 11:26 PM JavaScript performance improvement ideas edited by
- (diff)
- 10:38 PM JavaScript performance improvement ideas edited by
- (diff)
- 10:33 PM Changeset in webkit [27021] by
-
- 2 edits in trunk/WebKitTools
unbreak Qt build
- 10:23 PM Changeset in webkit [27020] by
-
- 7 edits2 adds in trunk
Fix <rdar://5549919> Add font database initialization code to WebCore and call it from WebKit
WebCore:
Add font database initialization code to WebCore
Reviewed by Ada.
- WebCore.vcproj/WebCore.vcproj: Added FontDatabase.{cpp,h}.
- platform/win/FontDatabase.cpp: Added. (WebCore::systemFontsDirectory): (WebCore::fontsPlistPath): (WebCore::systemHasFontsNewerThanFontsPlist): (WebCore::readFontPlist): (WebCore::populateFontDatabaseFromPlist): (WebCore::populateFontDatabaseFromFileSystem): (WebCore::writeFontDatabaseToPlist): (WebCore::populateFontDatabase): This is the only function callable from outside this file. It populates the font database once, either from the fonts plist, or from the filesystem (and then saves a new fonts plist).
- platform/win/FontDatabase.h: Added.
WebKitTools:
Remove now-unnecessary call to InitializeCoreGraphics
WebKit takes care of this now.
Reviewed by Ada.
- DumpRenderTree/win/DumpRenderTree.cpp: (initialize):
WebKit/win:
Fix <rdar://5549919> Initialize the font database before any font code is invoked
We initialize the database in two places:
- When instantiating WebKitClassFactory, which is guaranteed to happen before any WebView is instantiated.
- When making a WebCore::Font in WebKitGraphics.
This ensures that the font database will be populated before any font
code is invoked. We rely on WebCore to only populate the database
once.
Reviewed by Ada.
- WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Populate the font database.
- WebKitGraphics.cpp: (makeFont): Ditto.
- 10:22 PM Changeset in webkit [27019] by
-
- 9 edits2 copies in trunk
Add [I]WebTextRenderer
WebKitTools:
Use WebTextRenderer in DRT
Reviewed by Ada.
- DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Use WebTextRenderer instead of using InitializeCoreGraphics/AddFontResourceEx.
WebKit/win:
Add [I]WebTextRenderer
Right now this class can only be used to add private fonts for use by
the running process, but will eventually be the home of the
WebKitGraphics functions.
Reviewed by Ada.
- ForEachCoClass.h: Added WebTextRenderer.
- Interfaces/WebKit.idl: Ditto.
- WebKit.vcproj/Interfaces.vcproj: Ditto.
- WebKit.vcproj/WebKit.vcproj: Ditto.
- WebKit.vcproj/WebKitGUID.vcproj: Ditto.
- WebKitClassFactory.cpp: Ditto.
- WebTextRenderer.cpp: Added. (WebTextRenderer::createInstance): (WebTextRenderer::WebTextRenderer): (WebTextRenderer::~WebTextRenderer): (WebTextRenderer::QueryInterface): (WebTextRenderer::AddRef): (WebTextRenderer::Release): (WebTextRenderer::registerPrivateFont):
- WebTextRenderer.h: Added.
- 10:22 PM Changeset in webkit [27018] by
-
- 4 edits in trunk/WebKit/win
Use FOR_EACH_COCLASS in WebKitClassFactory
Reviewed by Ada.
- WebError.cpp: (WebError::createInstance): Added an overload that takes no arguments to make the macro used in WebKitClassFactory work.
- WebError.h:
- WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Use FOR_EACH_COCLASS.
- 10:22 PM Changeset in webkit [27017] by
-
- 3 edits1 add in trunk/WebKit/win
Put FOR_EACH_COCLASS macro into its own file and export it
The macro used to be called FOR_EACH_CLASS and lived in WebKitDLL.cpp.
This way we will be able to use the macro in more places that care
about all WebKit's COM classes.
Reviewed by Ada.
- ForEachCoClass.h: Added.
- WebKit.vcproj/WebKit.vcproj: Copy ForEachCoClass.h to WebKitOutputDir, and added it to the project.
- WebKitDLL.cpp: Updated for macro rename, and changed to #undef the macros we pass to FOR_EACH_COCLASS after we're done with them.
- 10:20 PM Changeset in webkit [27016] by
-
- 4 edits in trunk/WebKitLibraries
Added some font-related functions needed for <rdar://5549919>
Reviewed by Ada.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 10:01 PM Changeset in webkit [27015] by
-
- 3 edits in trunk/WebKitTools
2007-10-24 Sven Herzberg <sven@imendio.com>
Reviewed by Mark Rowe.
Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
Bug 15614: [GTK] qmake based backends don't build on OS X
- Scripts/build-webkit: set QMAKESPEC correctly if building the QT or GTK backend on a Mac
- Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into isDarwin() to make it reusable in other places (like the workaround- for-prebuilt-qmake in build-webkit)
- 8:51 PM Changeset in webkit [27014] by
-
- 2 edits in trunk/WebKitTools
Refurbish update-webkit script.
Reviewed by Adam.
Scripts/update-webkit: Add -hhelp switch and usage statement. Check result of GetOptions() call. Fix -qquiet switch to be passed to svn command properly. Use multi-argument version of system() for flexibility and security. Check for existence
of Internal directory using -d test instead of -x.
- 8:50 PM Changeset in webkit [27013] by
-
- 2 edits in trunk/WebKitTools
Minor clean-up of prepare-ChangeLog script.
Reviewed by Adam.
- Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead of a string. Use multi-argument versions of open() and system() for flexibility and security.
- 7:40 PM Changeset in webkit [27012] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/5552221> REGRESSION(310A24-ToT): Shortcut key disable. (15604)
Reviewed by Adam.
- WebView.cpp: (WebView::handleEditingKeyboardEvent): don't handle system key events as text input (WebView::keyDown): only remove WM_SYSCHAR message from the queue if we handle it. For WM_SYSCHAR message that we don't handle, let it stay in the queue and return false to let windows handle it.
- 6:19 PM Changeset in webkit [27011] by
-
- 15 edits in trunk
Touch all files that include *.lut.h to fix Windows builds
- 6:16 PM Changeset in webkit [27010] by
-
- 2 edits in trunk/WebKit/gtk
2007-10-24 Mark Rowe <mrowe@apple.com>
Gtk build fix. Track WebCore changes in r27004.
- Api/webkitgtkglobal.cpp:
- 5:58 PM Changeset in webkit [27009] by
-
- 6 edits in trunk
WebCore:
Reviewed by Darin Adler.
Correcting the fix for:
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
Made removal of the previous composition part of the current Undo step in the
case where the new composition is the empty string, too.
- editing/Editor.cpp: (WebCore::Editor::confirmComposition): Call the new TypingCommand::deleteSelection, which either has the currently open typing command delete the current selection, or opens a new typing command (of type DeleteSelection) if one is not already open. (WebCore::Editor::setComposition): Ditto.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Added. (WebCore::TypingCommand::doApply): Handle DeleteSelection. (WebCore::TypingCommand::deleteKeyPressed): Clarified which deleteSelection is called. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::preservesTypingStyle): Handle DeleteSelection.
- editing/TypingCommand.h:
LayoutTests:
Reviewed by Darin.
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
- platform/mac/editing/input/text-input-controller-expected.txt: The delete we were using previously to remove the old composition makes fewer calls to the editing delegate.
- 5:30 PM Changeset in webkit [27008] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 5:10 PM Changeset in webkit [27007] by
-
- 1 edit in trunk/WebKitTools/Scripts/build-webkit
Build fix.
- 4:55 PM Changeset in webkit [27006] by
-
- 4 edits2 adds1 delete in trunk
WebKit:
Reviewed by Mark Rowe.
<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
Use the WebKitSystemInterface that matches the system version.
- Configurations/DebugRelease.xcconfig:
- WebKit.xcodeproj/project.pbxproj:
WebKitLibraries:
Reviewed by Mark Rowe.
<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
Add system specific versions of WebKitSystemInterface.
- libWebKitSystemInterface.a: Removed.
- libWebKitSystemInterfaceLeopard.a: Added.
- libWebKitSystemInterfaceTiger.a: Added.
- 4:29 PM Changeset in webkit [27005] by
-
- 7 edits in trunk
WebCore:
Reviewed by Oliver.
Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
- page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Some mouse move events are actually drags, which on mac return early from this function. Adding the same logic to its Windows equivalent.
WebKitTools:
Reviewed by Oliver.
Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
replay the saved events when we're still processing the mousedown that starts the drag
- DumpRenderTree/win/EventSender.cpp: (doMouseMove):
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop):
LayoutTests:
Removing fixed test
- platform/win/Skipped:
- 4:02 PM Changeset in webkit [27004] by
-
- 10 edits2 adds in trunk
WebCore:
Reviewed by Anders
<rdar://5554130> DatabaseTracker.o has a global initializer
Since DatabaseTracker is a singleton, it makes much more sense to keep the database path as a member variable.
Now constructing the shared DatabaseTracker no longer implicitly opens it - It is only opened when the databases
path is set.
- WebCore.vcproj/WebCore.vcproj: Copy WebCore/storage headers for WebKit build
- storage/Database.cpp: (WebCore::Database::~Database): Remove bogus assertion
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Does nothing now! Move this code to openTrackerDatabase (WebCore::DatabaseTracker::setDatabasePath): Set the member variable, also closing/opening the database if needed (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::openTrackerDatabase): To open and validate the Databases db, moved from the c'tor (WebCore::DatabaseTracker::fullPathForDatabase): Return the member variable
- storage/DatabaseTracker.h:
WebKit/win:
Reviewed by Anders
Windows portion of <rdar://5554130>
Slowly introduce Windows WebKit portion of the Database API that sets the
on-disk location for databases
- WebDatabaseManager.cpp: Added. (WebKitSetWebDatabasesPathIfNecessary):
- WebDatabaseManager.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- WebView.cpp: (WebView::initWithFrame): Call WebKitSetWebDatabasesPathIfNecessary()
WebKit:
Reviewed by Anders
<rdar://problem/5554130> DatabaseTracker.o has a global initializer
- Misc/WebDatabaseManager.mm: (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
- 4:00 PM Changeset in webkit [27003] by
-
- 11 edits2 adds in trunk
WebKitTools:
Reviewed by Sam, Steve and Darin.
- Stubbed out the WebScriptDebugListener functionality in the Server Connection class to prepare it for receiving those callbacks.
- Also I changed the instantiation of DebuggerClient, DebuggerDocument and the ServerConnection to not need to be initialized with a server name, since that is not the way we connect to the WebKit server.
- Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging no exception. Now it only loggs when there is an exception (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
- Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection to be instantiated with a server's name. (DebuggerClient::DebuggerClient): (DebuggerClient::didFinishLoadForFrame):
- Drosera/win/DebuggerClient.h: Removed unsued variable.
- Drosera/win/Drosera.cpp: Client no longer needs to be initialized with a server name. (Drosera::init): (Drosera::initServer):
- Drosera/win/Drosera.h: No longer need the ServerConnection to be instantiated with a server's name.
- Drosera/win/ServerConnection.cpp: (ServerConnection::ServerConnection): No longer needs a server name (ServerConnection::~ServerConnection): Only release the global context if there is one. (ServerConnection::serverConnectionDidDie): Stub for IWebScriptDebugListener (ServerConnection::QueryInterface): ditto (ServerConnection::AddRef): ditto (ServerConnection::Release): ditto (ServerConnection::didLoadMainResourceForDataSource): ditto (ServerConnection::didParseSource): ditto (ServerConnection::failedToParseSource): ditto (ServerConnection::didEnterCallFrame): ditto (ServerConnection::willExecuteStatement): ditto (ServerConnection::willLeaveCallFrame): ditto (ServerConnection::exceptionWasRaised): ditto
- Drosera/win/ServerConnection.h: Stubbed out the IWebScriptDebugListener functions, and this class no longer needs to be instantiated with a server name.
win:
Reviewed by Sam, Steve and Darin.
- Added stubs for what will be neede to let Drosera attach to the WebKit process and debug it.
- Interfaces/IWebScriptCallFrame.idl: Added.
- Interfaces/IWebScriptDebugListener.idl: Added.
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
- 3:10 PM Changeset in webkit [27002] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-24 Eric Seidel <eric@webkit.org>
Build fix for Gtk, no review.
- kjs/collector.cpp: #include "context.h"
- 2:31 PM Changeset in webkit [27001] by
-
- 5 edits2 adds in trunk
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Stop checking isOutOfMemory after every allocation, instead let the collector
notify all ExecStates if we ever hit this rare condition.
SunSpider claims this was a 2.2% speedup.
- kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::reportOutOfMemoryToAllInterpreters):
- kjs/collector.h:
- kjs/nodes.cpp: (KJS::TryNode::execute):
- 1:33 PM Changeset in webkit [27000] by
-
- 3 edits in trunk/WebCore
Don't try to gap fill transformed selections. Fix the invalidation of selection to use the clip to visible content
code path so that it works with multi-column layouts and transforms.
Reviewed by aroben
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillSelectionGaps):
- rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
- 1:25 PM Changeset in webkit [26999] by
-
- 3 edits in trunk/WebCore
2007-10-24 Eric Seidel <eric@webkit.org>
No review, I want to tickle the CIA bot to test changes,
and took this as an opportunity to clean up some old change logs.
- ChangeLog-2005-08-23: update email address
- ChangeLog-2006-12-31: fix spelling mistakes
- 11:45 AM Changeset in webkit [26998] by
-
- 140 edits in trunk
WebCore:
Reviewed by Oliver Hunt.
- add "(anonymous)" to the renderName of anonymous table cells, rows and sections
- rendering/RenderTableCell.h: (WebCore::RenderTableCell::renderName):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::renderName):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName):
LayoutTests:
Reviewed by Oliver Hunt.
- updated results to reflect which table parts are anonymous
- 11:41 AM Changeset in webkit [26997] by
-
- 3 edits in trunk/WebCore
Reviewed by Adam.
Bug 15476: DOM tree fully expands some elements when arrowing up
http://bugs.webkit.org/show_bug.cgi?id=15476
Add a new expandTreeElementsWhenArrowing option to TreeOutline. This option
is used only for the sidebar and search results.
- page/inspector/inspector.js: Opt-in for the sidebar and search results.
- page/inspector/treeoutline.js: Add expandTreeElementsWhenArrowing and pass this option to traverseNextTreeElement and traversePreviousTreeElement.
- 11:30 AM Changeset in webkit [26996] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-24 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/identifier.h: Remove extra qualification.
- 11:04 AM Changeset in webkit [26995] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Disable ALWAYS_INLINE in debug builds, since it drives the debugger
crazy.
- wtf/AlwaysInline.h:
- 11:02 AM Changeset in webkit [26994] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Inlined the fast path for creating an Identifier from an Identifier.
This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.
(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)
- JavaScriptCore.exp:
- kjs/identifier.cpp: (KJS::Identifier::addSlowCase):
- kjs/identifier.h: (KJS::Identifier::Identifier::add):
- 10:58 AM Changeset in webkit [26993] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog.
- 10:56 AM Changeset in webkit [26992] by
-
- 6 edits in trunk/WebCore
Reviewed by Geoff and Mitz.
<rdar://problem/5493833>
REGRESSION: ~5MB of image data leaked @ cuteoverload.com (often seen while browsing other sites, too)
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): If an image element that is currently loading an image is not in the document, it should still be marked.
- bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::construct): Force the document wrapper to be created.
- html/HTMLImageElement.h: (WebCore::HTMLImageElement::haveFiredLoadEvent): New method which calls down to the image loader.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::setLoadingImage): (WebCore::HTMLImageLoader::dispatchLoadEvent): Remove code that's not needed anymore.
- html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): Make this public.
- 10:27 AM Changeset in webkit [26991] by
-
- 6 edits in trunk
Move Windows safe file creation code into WebCore from WebPreferences
WebCore:
Move Windows safe file creation code into WebCore from WebPreferences
Reviewed by Brady.
- platform/FileSystem.h:
- platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile): Moved here from WebKit/win/WebPreferences.cpp.
WebKit/win:
Move safe file creation code to WebCore
Reviewed by Brady.
- WebPreferences.cpp: (preferencesPath): Made into a static helper function. (WebPreferences::save): Now calls WebCore's safeCreateFile function. (WebPreferences::load): Uses String/CString to handle the UTF-8 conversion.
- WebPreferences.h: Removed preferencesPath and safeCreateFileWithData.
- 10:27 AM Changeset in webkit [26990] by
-
- 6 edits in trunk
Reduce code duplication by using WebCore's FileSystem functions
WebCore:
Add methods to FileSystemWin to get some user profile directories
These directories are used to hold things like preferences, caches,
etc.
Reviewed by Brady.
- platform/FileSystem.h: Added new method declarations for Windows only.
- platform/win/FileSystemWin.cpp: (WebCore::bundleName): Added. (WebCore::storageDirectory): Added. (WebCore::cachedStorageDirectory): Added. (WebCore::localUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should stay local to the current machine (i.e., shouldn't be stored in a roaming profile). (WebCore::roamingUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should move with the user from machine to machine (i.e., should be stored in a roaming profile).
WebKit/win:
Reduce code duplication by using WebCore's FileSystem functions
Reviewed by Brady.
- WebIconDatabase.cpp: Removed a now-unused function and a fixed FIXME. (WebIconDatabase::init): Changed to use FileSystem functions.
- WebPreferences.cpp: (WebPreferences::preferencesPath): Ditto.
- 6:28 AM Changeset in webkit [26989] by
-
- 3 edits in trunk/LayoutTests
2007-10-24 Mark Rowe <mrowe@apple.com>
Fix incorrect test results landed with r26986.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt:
- 6:21 AM Changeset in webkit [26988] by
-
- 13 edits18 adds in trunk/LayoutTests
update some test results for the Qt port.
- 6:06 AM Changeset in webkit [26987] by
-
- 2 edits in trunk/WebCore
2007-10-24 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15659
InlineTextBox does not setStrokeStyle() as needed
GraphicsContextCairo workaround to support a GraphicsContextCG quirk:
Save and restore the StrokeStyle manually.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
- 5:49 AM Changeset in webkit [26986] by
-
- 5 edits6 adds in trunk
2007-10-24 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=15356
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions
- getAllResponseHeaders and getResponseHeader throws INVALID_STATE_ERR exception as specified in the specification
- Add the check to field-name production in getResponseHeader (call to isValidToken) and returns an empty string if the header is not valid (Opera and IE behaviour)
- Updated XMLHttpRequest::responseMIMEType() to keep its behaviour
Tests: http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseMIMEType):
- xml/XMLHttpRequest.h:
2007-10-24 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=15356
getResponseHeader and getAllResponseHeaders do not throw exceptions
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Added.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Added.
- http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Added.
- 5:33 AM Changeset in webkit [26985] by
-
- 2 edits3 adds in trunk/LayoutTests
these tests don't crash anymore :)
- 5:33 AM Changeset in webkit [26984] by
-
- 2 edits in trunk/WebKit/qt
- Stop crashing on fast/events/frame-tab-focus.html the keyEvent can be 0.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:33 AM Changeset in webkit [26983] by
-
- 2 edits in trunk/WebCore
implement most of DragData.
- 5:33 AM Changeset in webkit [26982] by
-
- 4 edits in trunk
add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
- 5:33 AM Changeset in webkit [26981] by
-
- 2 edits511 adds in trunk/LayoutTests
we're passing most editing tests now. Commit them.
- 5:33 AM Changeset in webkit [26980] by
-
- 2 edits in trunk/WebKitTools
add another command.
- 5:32 AM Changeset in webkit [26979] by
-
- 2 edits1 add3 deletes in trunk/LayoutTests
convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.
- 5:32 AM Changeset in webkit [26978] by
-
- 2 edits in trunk/WebKit/qt
remove some notImplemented() warnings.
- 5:32 AM Changeset in webkit [26977] by
-
- 3 edits in trunk/WebKitTools
add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
- 5:32 AM Changeset in webkit [26976] by
-
- 2 edits in trunk/WebCore
remove a stupid notImplemented() warning and implement PasteBoad::clear().
- 5:32 AM Changeset in webkit [26975] by
-
- 2 edits in trunk/WebKit/qt
allow paste from DOM so we pass more test cases.
- 5:32 AM Changeset in webkit [26974] by
-
- 2 edits in trunk/WebCore
implement Pasteboard::documentFragment(), and fix a mem leak.
- 5:32 AM Changeset in webkit [26973] by
-
- 2 edits in trunk/WebKitTools
implement eventSender.keyDown().
- 5:32 AM Changeset in webkit [26972] by
-
- 3 edits in trunk/JavaScriptCore
some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.
- 5:32 AM Changeset in webkit [26971] by
-
- 5 edits in trunk
Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.
- 5:32 AM Changeset in webkit [26970] by
-
- 5 edits in trunk
some smaller fixes to the editing support in DRT. Makes another few tests pass.
- 5:32 AM Changeset in webkit [26969] by
-
- 2 edits in trunk/LayoutTests
explicitly add some tests that currently cause DRT to hang.
- 5:32 AM Changeset in webkit [26968] by
-
- 5 edits in trunk/WebKitTools
first bit of implementation for the textinputcontroller.
- 5:32 AM Changeset in webkit [26967] by
-
- 2 edits in trunk/WebKit/qt
implemented support for most editing shortcuts to make contentEditable usable.
- 5:32 AM Changeset in webkit [26966] by
-
- 2 edits in trunk/WebKit/qt
no need to call setIsActive ourselves on the frame, as the focus controller does it for us.
- 5:32 AM Changeset in webkit [26965] by
-
- 2 edits in trunk/WebKitTools
make the man webpage believe it has focus, so the editing tests work correctly.
- 5:32 AM Changeset in webkit [26964] by
-
- 3 edits in trunk/WebKitTools
implement layoutTestController.dumpEditingCallbacks() correctly.
- 5:32 AM Changeset in webkit [26963] by
-
- 3 edits in trunk/WebCore
use the new QTextBoundaryFinder class in Qt.
- 5:32 AM Changeset in webkit [26962] by
-
- 4 edits in trunk
Implement support for testing editing.
- 1:53 AM Changeset in webkit [26961] by
-
- 4 edits in trunk/JavaScriptCore
Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider
Reviewed by Darin
- 1:50 AM Changeset in webkit [26960] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
- kjs/nodes.h: (KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)
- 1:21 AM Changeset in webkit [26959] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric.
- kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little Identifier ref/deref for what SunSpider claims is a 0.4% speedup.
- 1:14 AM Changeset in webkit [26958] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- separate out the code to create a hash table the first time from the code to rehash
SunSpider claims this was a 0.7% speedup.
- kjs/property_map.cpp: (KJS::PropertyMap::expand): Changed to call either createTable or rehash. (KJS::PropertyMap::createTable): Added. For the case where we had no table. (KJS::PropertyMap::rehash): Removed code needed only in the case where we had no table.
- kjs/property_map.h: Added createTable.
- 1:06 AM Changeset in webkit [26957] by
-
- 5 edits in trunk/JavaScriptCore
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::NumberNode::evaluate): (KJS::ImmediateNumberNode::evaluate):
- kjs/nodes.h: (KJS::Node::): (KJS::ImmediateNumberNode::):
- kjs/nodes2string.cpp: (ImmediateNumberNode::streamTo):
- 1:03 AM Changeset in webkit [26956] by
-
- 6 edits in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657 change static hash tables to use powers of two for speed
Seems to give 0.7% SunSpider speedup.
- kjs/create_hash_table: Updated to generate new format.
- kjs/lookup.cpp: (KJS::keysMatch): Took out unneeded typecast. (KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert. Replaced the modulus with a bit mask. (KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed their hash -- saves a branch. (KJS::Lookup::find): Ditto.
- kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.
WebCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657 change static hash tables to use powers of two for speed
- bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.
- 12:59 AM Changeset in webkit [26955] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
- remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup
- kjs/nodes.cpp: (KJS::DoWhileNode::execute): (KJS::WhileNode::execute): (KJS::ForNode::execute): (KJS::ForInNode::execute): (KJS::SourceElementsNode::execute):
- 12:41 AM Changeset in webkit [26954] by
-
- 3 edits in trunk/SunSpider
Reviewed by Eric.
- sunspider: Open the profile in shark after completing a run.
- sunspider-compare-results: Tiny perl tweaks.
- 12:40 AM Changeset in webkit [26953] by
-
- 2 edits in trunk/WebCore
Fix pathByAppendingComponent for the Qt port.
Oct 23, 2007:
- 11:52 PM Changeset in webkit [26952] by
-
- 2 edits in trunk/WebCore
Make repainting work with transforms.
Reviewed by John Sullivan
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
- 11:41 PM Changeset in webkit [26951] by
-
- 1 edit in trunk/SunSpider/hosted
Ignore files generated by the make-hosted script.
- 11:19 PM Changeset in webkit [26950] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- kjs/JSImmediate.h: (KJS::JSImmediate::getUInt32): Changed an && to an & for a 1% gain in SunSpider.
- 9:40 PM Changeset in webkit [26949] by
-
- 4 edits in trunk/WebCore
2007-10-23 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14412
[GDK] Clipboard support
Initial clipboard implementation for the GTK+ port.
- platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard):
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::plainText):
- platform/gtk/TemporaryLinkStubs.cpp:
- 9:35 PM Changeset in webkit [26948] by
-
- 3 edits in trunk/WebCore
Reviewed by Adam.
Fixes the Network panel so that it refreshes as needed.
- page/inspector/ConsolePanel.js: Call the base class show() and hide() first.
- page/inspector/NetworkPanel.js: Add refreshNeeded and refreshIfNeeded back. Ditto.
- 8:47 PM Changeset in webkit [26947] by
-
- 2 edits in trunk/WebKitTools
Check for null BSTR that can be passed to the UIDelegate methods
from javascript null and undefined. Fixes a failing test case on
Windows (fast/dom/Window/alert-undefined.html)
Reviewed by Eric Seidel.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):
- 7:15 PM Changeset in webkit [26946] by
-
- 6 edits in trunk/WebCore
Rolled out r26941 because it of layout test failures.
- 7:01 PM Changeset in webkit [26945] by
-
- 4 edits in trunk/JavaScriptCore
Reduce branching in implementations of some operator implementations, yielding 1.3% boost to SunSpider.
Reviewed by Maciej
- kjs/nodes.cpp: (KJS::MultNode::evaluate): (KJS::DivNode::evaluate): (KJS::ModNode::evaluate): (KJS::add): (KJS::sub): (KJS::AddNode::evaluate): (KJS::SubNode::evaluate): (KJS::valueForReadModifyAssignment):
- kjs/operations.cpp:
- kjs/operations.h:
- 6:59 PM Changeset in webkit [26944] by
-
- 4 edits in trunk/LayoutTests
Fixing an accidental change made in r25484.
- editing/pasteboard/quirks-mode-br-1.html:
- platform/mac/editing/pasteboard/quirks-mode-br-1-expected.checksum:
- platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
- 6:56 PM Changeset in webkit [26943] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Oliver Hunt.
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
- platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
- platform/mac/editing/input/text-input-controller-expected.txt:
- platform/mac/editing/input/wrapped-line-char-rect-expected.txt:
- 6:53 PM Changeset in webkit [26942] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
No layout test for now because I'm having trouble getting Undo during a layout
test to only undo the last Undo step, and I want to write a test that fails
without the code change.
- editing/Editor.cpp: (WebCore::Editor::confirmComposition): When we replace the previous composition, delete it with a sub-command of the command used to insert the new composition, instead of with a separate command. No new code was added because insertText already deletes the current selection. (WebCore::Editor::setComposition): Ditto.
- 6:51 PM Changeset in webkit [26941] by
-
- 5 edits1 add in trunk/WebCore
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=15405 ASSERTION FAILED: d->m_view && !d->m_view->needsLayout() in Frame::Paint
Calling updateWidget() during attach() led to arbitrary (plugin and resource load delegate)
code execution under attach(). The fix is to use the mechanism that's already in place for
deferring updateWidget() until after layout.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach): Replaced call to updateWidget() with call to updateWidgetSoon()
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Ditto.
- manual-tests/paint-during-plugin-attach.html: Added.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidgetSoon): Added this function that schedules the updateWidget() call for after the next layout.
- rendering/RenderPartObject.h:
- 6:36 PM Changeset in webkit [26940] by
-
- 3 edits in trunk/WebKit/win
Make the WebNotificationCenter work with null (wildcard) and specific
observed objects, matching NSNotificationCenter.
- Removes the ObserverKey, ObserverHash, and ObserverKeyTraits as we now hash against the notification name only and check the object on notification posting.
- Use OwnPtr for the WebNotificationCenterPrivate member variable.
Reviewed by Adam Roben.
- WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter): (WebNotificationCenter::~WebNotificationCenter): (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::addObserver): (WebNotificationCenter::postNotification): (WebNotificationCenter::postNotificationName): (WebNotificationCenter::removeObserver):
- WebNotificationCenter.h:
- 6:33 PM Changeset in webkit [26939] by
-
- 1 copy in tags/Safari-523.12.8b
New tag.
- 6:33 PM Changeset in webkit [26938] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 6:30 PM Changeset in webkit [26937] by
-
- 2 edits in trunk/WebCore
Fix the behavior of pathByAppendingComponent when path is empty
We now use the Windows Shell API function PathAppendW instead of
rolling our own broken implementation.
Reviewed by Anders.
- platform/win/FileSystemWin.cpp: (WebCore::pathByAppendingComponent):
- 5:56 PM Changeset in webkit [26936] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Don't print a massive pile of setenvs from tools that automatically build testkjs.
- Scripts/build-testkjs:
- 5:40 PM Changeset in webkit [26935] by
-
- 3 edits1 add in trunk
SunSpider:
Reviewed by Darin.
- Don't hardcode my path to testkjs
- sunspider-compare-results:
WebKitTools:
Reviewed by Darin.
- add wrapper that finds the right copy of testkjs
- Scripts/sunspider-compare-results: Added.
- 5:12 PM Changeset in webkit [26934] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
Test: fast/forms/textfield-onchange-deletion.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
- fast/forms/textfield-onchange-deletion-expected.txt: Added.
- fast/forms/textfield-onchange-deletion.html: Added.
- 5:08 PM Changeset in webkit [26933] by
-
- 8 edits7 adds in trunk/WebCore
Reviewed by Sam Weinig.
- Made seperate files for the various classes in ResourcePanel.js.
- Broke up ResourcePanel.js and created seperate panel classes for different resource types.
- Moved View code down to the Panel base-class.
- Reduced code duplication in DatabasePanel.js by sub-classing from the new ResourcePanel.
- page/inspector/DatabasePanel.js:
- page/inspector/DocumentPanel.js: Added.
- page/inspector/FontPanel.js: Added.
- page/inspector/ImagePanel.js: Added.
- page/inspector/Panel.js: Added.
- page/inspector/PropertiesSection.js: Added.
- page/inspector/Resource.js:
- page/inspector/ResourcePanel.js:
- page/inspector/SidebarPane.js: Added.
- page/inspector/SourcePanel.js: Added.
- page/inspector/inspector.css:
- page/inspector/inspector.html:
- page/inspector/inspector.js:
- 4:47 PM Changeset in webkit [26932] by
-
- 2 edits in trunk/WebCore
Correct the version #if check.
- platform/sql/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction):
- 4:40 PM Changeset in webkit [26931] by
-
- 3 edits in branches/Safari-3-branch/WebCore
Reviewed by Anders.
<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
- plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path
- 4:30 PM Changeset in webkit [26930] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Fix build.
- plugins/win/PluginViewWin.cpp:
- 4:16 PM Changeset in webkit [26929] by
-
- 3 edits in trunk/WebCore
2007-10-23 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
- plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path
- 4:14 PM Changeset in webkit [26928] by
-
- 5 edits in trunk/WebKit/win
<rdar://problem/5244261> SafariWin ignores cookie policy setting "never" in the preferences
Custom WebPreferences (not the shared WebPreferences) could override the cookie accept
policy setting on the default cookie storage. To fix that, I added a new method in
WebView called updateGlobalSettingsFromPreferences() to handle updating the global pref
options such as cookie accept policy, and it's only called to update changes from
the shared WebPreferences.
Use CLSID_WebPreferences and remove IID_WebPreferences.
Reviewed by Darin and Adam.
- WebPreferences.cpp: (WebPreferences::QueryInterface):
- WebPreferences.h:
- WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): (WebView::updateGlobalSettingsFromPreferences): (WebView::updateSettingsFromPreferences): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::onNotify):
- WebView.h:
- 4:11 PM Changeset in webkit [26927] by
-
- 6 edits in trunk/WebKitTools
Reviewed by Sam.
- After talking with Steve I now see that the WebKit server must be running for DCOM to create the distributed objects, which makes sense and currently WebKit only allows one instance to be running at a time which avoids accidentally connecting to the wrong server
- In light of this I have removed the code for the attach box and NotificationServer and known server names, since they are all extranious now.
- Drosera/win/Drosera.cpp: Removed notification classes and known server names. (_tWinMain): Uses init instead of initUI. (droseraWndProc): No longer creats an attach dialog box. (Drosera::Drosera): Does the OleInitialize so COM is ready to go and it's not manditory to call init before doing COM stuff. (Drosera::init): calls initUI and will call attach when the functionality exists. (Drosera::initUI): Has changed very little. (Drosera::attach): Changed the signature to reflect that we no longer need the dictionary of known server names.
- Drosera/win/Drosera.h: Removed notification classes and known server names. Also renamed and moved some functions.
- Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the headers to the resources folder.
- Drosera/win/resource.h: Removed the Attach box.
- 3:27 PM Changeset in webkit [26926] by
-
- 2 edits2 adds in trunk/SunSpider
Reviewed by Darin.
- Add a compare script to compare results, and improve formatting of standard results a bit.
- resources/sunspider-analyze-results.js:
- resources/sunspider-compare-results.js: Added.
- sunspider-compare-results: Added.
- 2:25 PM Changeset in webkit [26925] by
-
- 6 edits in trunk/JavaScriptCore
Separating all of the simple binary expression nodes into multiple classes
Reviewed by Maciej
Separating all of the simple (eg. non-read-modify-write) binary operators into separate classes in preparation for further JS optimisations.
Happily this produces a 0.8% to 1.0% performance increase in SunSpider with no further work.
- 12:29 PM Changeset in webkit [26924] by
-
- 2 edits in trunk/WebCore
2007-10-23 Jasper Bryant-Greene <m@ni.ac.nz>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly
Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.
Coding style fix by Alp.
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 12:05 PM BuildingGtk edited by
- (diff)
- 11:25 AM Changeset in webkit [26923] by
-
- 2 edits in trunk/LayoutTests
Add some SVG tests to the Windows Skipped file
Reviewed by Oliver.
- platform/win/Skipped:
- 11:11 AM Changeset in webkit [26922] by
-
- 5 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Add resizing of the DOM view right sidebar. This allows us to actually see the values now.
- page/inspector/ResourcePanel.js:
- page/inspector/inspector.css:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 8:52 AM Changeset in webkit [26921] by
-
- 9 edits in trunk/WebCore
Get basic hit testing right for transforms.
Reviewed by ollliej
- platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::mapPoint):
- platform/graphics/AffineTransform.h:
- rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
- rendering/RenderObject.h:
- 8:49 AM Changeset in webkit [26920] by
-
- 3 edits in trunk/LayoutTests
- removed numeric results so the test is more platform-independent
- fast/js/math-expected.txt: Updated.
- fast/js/resources/math.js: Updated.
- 7:12 AM Changeset in webkit [26919] by
-
- 3 edits3 adds in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15639 fix Math.abs(0), Math.ceil(-0), and Math.floor(-0)
Test: fast/js/math.html
- kjs/math_object.cpp: (MathFuncImp::callAsFunction): Fix abs to look at the sign bit. Add a special case for values in the range between -0 and -1 and a special case for ceil and for -0 for floor.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=15639 Math functions
- fast/js/math-expected.txt: Added.
- fast/js/math.html: Added.
- fast/js/resources/math.js: Added.
- 5:11 AM Changeset in webkit [26918] by
-
- 2 edits in trunk/WebKit
2007-10-23 Mark Rowe <mrowe@apple.com>
Build fix for Eric's build fix in r26916.
- MigrateHeaders.make:
- 2:44 AM Changeset in webkit [26917] by
-
- 2 edits in trunk/WebCore
2007-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leaks seen on TOT from new font-face code.
- ksvg2/svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): use a stack allocated CSSProperty instead of mallocing
- 1:33 AM Changeset in webkit [26916] by
-
- 3 edits in trunk/WebCore
2007-10-23 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Sacrifice three virgin hours upon the altar of the heathen XCode gods
and pray that our build troubles are finally over. :(
- DerivedSources.make: add DOMSVGException.h
- WebCore.xcodeproj/project.pbxproj: Remove DOMSVG*Interal.h files from "Copy Generated Headers" phase. Why? Who knows.
- 12:07 AM Changeset in webkit [26915] by
-
- 3 edits in trunk/SunSpider
Reviewed by Darin.
- resources/sunspider-analyze-results.js: Do the error range properly, using the t-distribution instead of 1.96 (which was based on the normal distribution).
- sunspider: Print results in a way that will be friendlier to the soon-to-come compare mode.
- 12:00 AM Changeset in webkit [26914] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Eric.
- streamline exception handling code for a >1% speed-up of SunSpider
- kjs/nodes.cpp: Changed macros to use functions for everything that's not part of normal execution. We'll take function call overhead when propagating an exception or out of memory. (KJS::createOutOfMemoryCompletion): Added. (KJS::substitute): Use append instead of the relatively inefficient + operator. (KJS::Node::rethrowException): Added.
- kjs/nodes.h: Added rethrowException.
Oct 22, 2007:
- 11:45 PM Changeset in webkit [26913] by
-
- 2 edits in trunk/WebCore
Fix build.
- plugins/win/PluginViewWin.cpp:
- 11:44 PM Changeset in webkit [26912] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15636 some JavaScriptCore regression tests are failing due to numeric conversion
This should restore correctness and make speed better too, restoring some
of the optimization we lost in my last check-in.
- kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Added. Uses the range checking idiom I used in my patch yesterday. (KJS::JSImmediate::getTruncatedUInt32): Ditto.
- kjs/internal.h: Removed getInt32 and added getTruncatedInt/UInt32.
- kjs/internal.cpp: (KJS::NumberImp::getUInt32): Changed to always use double, since I can't find a way to write this more efficiently for float. (KJS::NumberImp::getTruncatedInt32): Added. (KJS::NumberImp::getTruncatedUInt32): Added.
- kjs/value.h: Removed getInt32 and added getTruncatedInt/UInt32. (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): Added. (KJS::JSValue::getTruncatedUInt32): Added. (KJS::JSValue::toInt32): Changed getInt32 call to getTruncatedInt32. (KJS::JSValue::toUInt32): Changed getUInt32 call to getTruncatedUInt32.
- kjs/value.cpp: (KJS::JSCell::getTruncatedInt32): Added. (KJS::JSCell::getTruncatedUInt32): Added. (KJS::JSValue::toInteger): Changed getUInt32 call to getTruncatedInt32. (KJS::JSValue::toInt32SlowCase): Removed extra getInt32 call I accidentally had left in here. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Changed getUInt32 call to getTruncatedUInt32.
- JavaScriptCore.exp: Updated.
- 11:28 PM Changeset in webkit [26911] by
-
- 2 edits in trunk/WebCore
2007-10-22 Eric Seidel <eric@webkit.org>
Build fix only, no review.
- WebCore.xcodeproj/project.pbxproj: re-add all DOMSVG headers to copy-files phase to make sure.
- 11:22 PM Changeset in webkit [26910] by
-
- 2 edits in trunk/WebCore
2007-10-22 Eric Seidel <eric@webkit.org>
Build fix only, no review.
- WebCore.xcodeproj/project.pbxproj: make sure DOMSVGAnimateElement.h is copied into headers.
- 11:07 PM Changeset in webkit [26909] by
-
- 1 edit in trunk/WebCore/ksvg2/svg/SVGAnimateElement.idl
Touch SVGAnimateElement.idl to force to bots to rebuild *SVGAnimateElement.*
- 9:19 PM Changeset in webkit [26908] by
-
- 2 edits7 adds in trunk/SunSpider
Reviewed by Review.
- add more tests (probably the final set for now)
Already balanced. Added date, regexp, control flow, and a few
more string and object/array access tests.
- tests/LIST:
- tests/access-fannkuch.js: Added.
- tests/access-nbody.js: Added.
- tests/controlflow-recursive.js: Added.
- tests/date-format-tofte.js: Added.
- tests/date-format-xparb.js: Added.
- tests/regexp-dna.js: Added.
- tests/string-validate-input.js: Added.
- 8:49 PM Changeset in webkit [26907] by
-
- 12 edits2 adds in trunk
2007-10-22 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix build by properly exposing SVG font-face dom bindings.
- DerivedSources.make:
- WebCore.vcproj/WebCore.vcproj: add font-face files to build
- WebCore.xcodeproj/project.pbxproj: add missing DOM bindings files
- bindings/js/JSSVGElementWrapperFactory.cpp:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- ksvg2/svg/SVGDefinitionSrcElement.idl: inherit from SVGElement
- 7:44 PM Changeset in webkit [26906] by
-
- 2 edits in trunk/WebCore
2007-10-22 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- WebCore.pro:
- 7:30 PM Changeset in webkit [26905] by
-
- 3 edits in trunk/WebCore
- a first cut at fixing the Qt and GTK builds
- WebCore.pro: Add new .idl and .cpp files.
- DerivedSources.make: Re-sorted.
- 6:02 PM JavaScript performance improvement ideas edited by
- (diff)
- 5:50 PM JavaScript performance improvement ideas edited by
- (diff)
- 5:38 PM Changeset in webkit [26904] by
-
- 15 edits28 adds in trunk
2007-10-22 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Implement <font-face> and friends for SVG.
http://bugs.webkit.org/show_bug.cgi?id=10652
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGElementWrapperFactory.cpp:
- dom/Document.cpp: (WebCore::Document::mappedElementSheet): (WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- ksvg2/scripts/make_names.pl:
- ksvg2/svg/SVGDefinitionSrcElement.cpp: Added. (WebCore::SVGDefinitionSrcElement::SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::~SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::childrenChanged):
- ksvg2/svg/SVGDefinitionSrcElement.h: Added.
- ksvg2/svg/SVGDefinitionSrcElement.idl: Added.
- ksvg2/svg/SVGFontFaceElement.cpp: Added. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::cssPropertyIdForName): (WebCore::mapAttributeToCSSProperty): (WebCore::cssPropertyIdForSVGAttributeName): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):
- ksvg2/svg/SVGFontFaceElement.h: Added.
- ksvg2/svg/SVGFontFaceElement.idl: Added.
- ksvg2/svg/SVGFontFaceFormatElement.cpp: Added. (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::~SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::childrenChanged):
- ksvg2/svg/SVGFontFaceFormatElement.h: Added.
- ksvg2/svg/SVGFontFaceFormatElement.idl: Added.
- ksvg2/svg/SVGFontFaceNameElement.cpp: Added. (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::~SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::srcValue):
- ksvg2/svg/SVGFontFaceNameElement.h: Added.
- ksvg2/svg/SVGFontFaceNameElement.idl: Added.
- ksvg2/svg/SVGFontFaceSrcElement.cpp: Added. (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::~SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::srcValue): (WebCore::SVGFontFaceSrcElement::childrenChanged):
- ksvg2/svg/SVGFontFaceSrcElement.h: Added.
- ksvg2/svg/SVGFontFaceSrcElement.idl: Added.
- ksvg2/svg/SVGFontFaceUriElement.cpp: Added. (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::srcValue): (WebCore::SVGFontFaceUriElement::childrenChanged):
- ksvg2/svg/SVGFontFaceUriElement.h: Added.
- ksvg2/svg/SVGFontFaceUriElement.idl: Added.
- ksvg2/svg/svgtags.in:
- 5:33 PM Changeset in webkit [26903] by
-
- 2 edits in trunk/WebKitTools
Windows build fix
Reviewed by NOBODY.
- Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
- 5:28 PM Changeset in webkit [26902] by
-
- 1 copy in tags/Safari-523.12.7b
New tag.
- 5:28 PM Changeset in webkit [26901] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 5:26 PM Changeset in webkit [26900] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26898.
- 4:36 PM Changeset in webkit [26899] by
-
- 7 edits in trunk
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=15632 js1_5/Array/array-001.js test failing
One of the JavaScriptCore tests was failing; it failed because of
my change to NumberImp::getUInt32. The incorrect code I copied was
from JSImmediate::getUInt32, and was a pre-existing bug.
This patch fixes correctness, but will surely slow down SunSpider.
We may be able to code this tighter and get the speed back.
- kjs/JSImmediate.h: (KJS::JSImmediate::getInt32): Renamed from toInt32 to more accurately reflect the fact that this function only returns true if the value is accurate (no fractional part, etc.). Changed code so that it returns false when the value has a fraction. (KJS::JSImmediate::getUInt32): Ditto.
- kjs/internal.cpp: (KJS::NumberImp::getInt32): Changed code so that it returns false when the value has a fraction. Restores the old behavior. (KJS::NumberImp::getUInt32): Ditto.
- kjs/value.h: (KJS::JSValue::getInt32): Updated for name change. (KJS::JSValue::getUInt32): Ditto. (KJS::JSValue::toInt32): Ditto. (KJS::JSValue::toUInt32): Ditto.
LayoutTests:
Reviewed by Geoff.
Added tests for cases where you use something that looks like an array
index, but it has a fractional part.
- fast/js/kde/resources/Array.js: Added tests.
- fast/js/kde/Array-expected.txt: Updated.
- 4:29 PM Changeset in webkit [26898] by
-
- 2 edits in trunk/WebCore
2007-10-22 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
We purposefully do not destroy our Java VM when its reference count
reaches 0, but we were unloading our JavaPlugin.dll when its reference
count reached 0, which lost the reference to the VM. This led to our
process trying to create a new VM the next time a page using Java was
loaded, and the JNI spec states that a single process is not allowed to
create more than one VM. The fix is to avoid unloading the Java plugin
via our PluginQuirkDontUnloadPlugin.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):
- 3:18 PM Changeset in webkit [26897] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Brady.
- fix crash seen when running JavaScriptCore tests
- kjs/array_instance.cpp: (KJS::ArrayInstance::mark): Copy and paste error: I accidentally had code here that was making a copy of the HashMap -- that's illegal inside a mark function and was unnecessary. The other callsite was modifying the map as it iterated it, but this function is not.
- 2:32 PM Changeset in webkit [26896] by
-
- 6 adds in trunk/LayoutTests/platform/mac/fast/transforms
Add results for new layout tests for transforms.
- 2:32 PM Changeset in webkit [26895] by
-
- 2 adds in trunk/LayoutTests/fast/transforms
Add two new layout tests for transforms.
- 2:29 PM Changeset in webkit [26894] by
-
- 4 edits in trunk/WebCore
Fix for bug 15624, make transforms work properly with opacity.
Make sure a unitless 0 is allowed as an angle argument to rotation/skew.
Reviewed by Mitz Pettel
fast/transforms/transforms-with-opacity.html
fast/transforms/skew-with-unitless-zero.html
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h: (WebCore::RenderLayer::transform):
- 2:26 PM Changeset in webkit [26893] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider http://bugs.webkit.org/show_bug.cgi?id=15627
- kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): Avoid moving floats to integer registers since this is very slow.
- 11:39 AM Changeset in webkit [26892] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Eric Seidel.
- http://bugs.webkit.org/show_bug.cgi?id=15617 improve speed of integer conversions
Makes SunSpider 6% faster.
- kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for 32-bit and 64-bit.
- kjs/value.h: (KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.
- kjs/internal.h: Added getInt32.
- kjs/internal.cpp: (KJS::NumberImp::getInt32): Added. (KJS::NumberImp::getUInt32): Replaced with more-optimal implementation stolen from JSValue.
- kjs/value.h: (KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting inlined. (KJS::JSValue::getInt32): Added. (KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32 to avoid converting from float to double. (KJS::JSValue::toInt32): Made inline, separated out the slow case. (KJS::JSValue::toUInt32): Ditto.
- kjs/value.cpp: (KJS::JSCell::getInt32): Added. (KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the new getInt32. Added a faster case for in-range numbers. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Added a faster case for in-range numbers.
- JavaScriptCore.exp: Updated for changes.
- 11:02 AM Changeset in webkit [26891] by
-
- 2 edits in trunk/WebKitTools
- Removed a leak that was fixed.
- Scripts/run-webkit-tests:
- 10:48 AM Changeset in webkit [26890] by
-
- 6 edits in trunk/WebKitTools
Reviewed by Darin.
- Changed the Client so that the DebuggerDocument now own the ServerConnection. This simplifies ownership and cleanup.
- Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the ServerConnection. (DebuggerClient::initWithServerName): (DebuggerClient::didFinishLoadForFrame):
- Drosera/win/DebuggerClient.h: DebuggerDocument now owns the ServerConnection.
- Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to until after we have a server which we are attached to. (Drosera::initUI): (Drosera::attach):
- Drosera/win/Drosera.h: Removed two needless pointers I forgot to take out previously.
- 10:43 AM Changeset in webkit [26889] by
-
- 5 edits in trunk
Windows build fix
Windows build fix
Reviewed by NOBODY.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn off warning about implicit conversion to bool.
WebCore:
Windows build fix
Reviewed by NOBODY.
- WebCore.vcproj/WebCore.vcproj: Copy header files from platform/sql.
- page/Page.cpp: Touched to force the header files to be copied.
- 10:14 AM Changeset in webkit [26888] by
-
- 4 edits in trunk/WebCore
Reviewed by Simon.
Move textPath related SVGChar data in it's own structure SVGCharOnPath.
Store a pointer to that datastructure inside SVGChar, instead of 4 floats & one bool.
Saves space for the common case. And allows me to add more data (another float) to support
glyph-orientation-* on textPath later on...
- 9:29 AM QtWebKit edited by
- (diff)
- 9:21 AM BuildingQtOnWindows edited by
- (diff)
- 9:01 AM Changeset in webkit [26887] by
-
- 2 edits in trunk/WebKitTools
When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
- 8:06 AM Changeset in webkit [26886] by
-
- 6 edits in trunk/WebCore
2007-10-22 Alp Toker <alp@atoker.com>
Reviewed by Nikolas Zimmermann.
Implement more GraphicsContextCairo stubs.
Remove a hack "to work around no current point bug" that was breaking
canvas tests.
Fix warnings.
- platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty):
- platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
- platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):
- 7:54 AM Changeset in webkit [26885] by
-
- 9 edits in trunk/WebKitTools
Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
- 7:53 AM Changeset in webkit [26884] by
-
- 3 edits in trunk/WebCore
Fix compilation from a clean build with the database feature disabled.
JSCustomVersionChangeCallback.cpp doesn't actually need the SQL header file, just ScriptInterpreter.
- 6:56 AM Changeset in webkit [26883] by
-
- 2 edits in trunk/JavaScriptCore
2007-10-22 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/array_instance.cpp:
- 6:46 AM Changeset in webkit [26882] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
- fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox, because Firefox incorrectly inserts undefined values rather than missing values in array literals with extra commas.
- fast/js/kde/Array-expected.txt: Updated with results.
- 6:35 AM Changeset in webkit [26881] by
-
- 11 edits1 copy in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15606 make cut-off for sparse vs. dense arrays smarter for speed with large arrays
Makes the morph test in SunSpider 26% faster, and the overall
benchmark 3% faster.
This also fixes some small problems we had with the distinction
between nonexistent and undefined values in arrays.
- kjs/array_instance.h: Tweaked formatting and naming.
- kjs/array_instance.cpp: Copied from kjs/array_object.cpp. (KJS::storageSize): Added. Computes the size of the storage given a vector length. (KJS::increasedVectorLength): Added. Implements the rule for resizing the vector. (KJS::isDenseEnoughForVector): Added. (KJS::ArrayInstance::ArrayInstance): Initialize the new fields. (KJS::ArrayInstance::~ArrayInstance): Since m_storage is now never 0, delete it. (KJS::ArrayInstance::getItem): Updated for name changes. (KJS::ArrayInstance::lengthGetter): Ditto. (KJS::ArrayInstance::inlineGetOwnPropertySlot): Added. Allows both versions of getOwnPropertySlot to share more code. (KJS::ArrayInstance::getOwnPropertySlot): Just refactored, no code change. (KJS::ArrayInstance::put): Added logic for extending the vector as long as the array is dense enough. Also keep m_numValuesInVector up to date. (KJS::ArrayInstance::deleteProperty): Added code to keep m_numValuesInVector up to date. (KJS::ArrayInstance::getPropertyNames): Fixed bug where this would omit names for array indices with undefined values. (KJS::ArrayInstance::increaseVectorLength): Renamed from resizeStorage. Also simplified to only handle getting larger. (KJS::ArrayInstance::setLength): Added code to update m_numValuesInVector, to zero out the unused part of the vector and to delete the map if it's no longer needed. (KJS::ArrayInstance::mark): Tweaked formatting. (KJS::compareByStringForQSort): Ditto. (KJS::ArrayInstance::sort): Ditto. (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): Ditto. (KJS::compareWithCompareFunctionForQSort): Ditto. (KJS::ArrayInstance::compactForSorting): Fixed bug where this would turn undefined values into nonexistent values in some cases.
- kjs/array_object.h: Removed MAX_ARRAY_INDEX.
- kjs/array_object.cpp: Removed ArrayInstance. Moved to a separate file.
- JavaScriptCore.pri: Added array_instance.cpp.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- kjs/AllInOneFile.cpp: Ditto.
LayoutTests:
- fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox.
- fast/js/kde/Array-expected.txt: Updated with results.
- 5:56 AM Changeset in webkit [26880] by
-
- 10 edits in trunk
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
- Configurations/JavaScriptCore.xcconfig:
WebCore:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
- Configurations/WebCore.xcconfig:
- WebCore.pro:
- WebCore.vcproj/build-generated-files.sh:
WebKit:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
- Configurations/WebKit.xcconfig:
WebKitTools:
Reviewed by Mark Rowe.
Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
- Scripts/build-webkit:
- 4:39 AM Changeset in webkit [26879] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for the non-qmake builds.
- 4:28 AM Changeset in webkit [26878] by
-
- 2 edits in trunk/WebCore
Disable the database feature in the qmake build for now.
- 4:22 AM Changeset in webkit [26877] by
-
- 9 edits in trunk/WebCore
Make disabling the database feature (ENABLE_DATABASE=0) work by
placing various #ifdefs into the code and making the compilation of
some files optional.
- 3:41 AM Changeset in webkit [26876] by
-
- 6 edits in trunk
2007-10-22 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15611
[GTK] Text selection behaviour different in Debug and Release builds
http://bugs.webkit.org/show_bug.cgi?id=15578
[GTK] Text editor caret does not blink
Never allow control to reach the end of non-void functions.
Return more sensible values, or in some cases, nulls.
- 2:35 AM Changeset in webkit [26875] by
-
- 2 edits in trunk/WebCore
Implement ResourceHandle::loadResourceSynchronously using ResourceHandle and a special ResourceHandleClient. This approach has the possible danger of reentrancy.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 2:33 AM Changeset in webkit [26874] by
-
- 5 edits in trunk
- Do not build testkjs as an application bundle. This is
needed for run-javascriptcore-tests on OSX.
- Also, based on r26633, allow to test the WebKit/Qt port on OSX.
- Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
as we do not have -rpath on OSX.
Signed-off-by: Simon Hausmann <hausmann@kde.org>
- 2:24 AM Changeset in webkit [26873] by
-
- 2 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Style fix. It is allowed to attempt to delete 0.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:24 AM Changeset in webkit [26872] by
-
- 2 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Make it actually localizable....
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:24 AM Changeset in webkit [26871] by
-
- 2 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Adjust the code to obey the Coding Style.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:24 AM Changeset in webkit [26870] by
-
- 2 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Return a non empty string in more functions.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:24 AM Changeset in webkit [26869] by
-
- 3 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Shrink the TemporaryLinkStubs and move the
Frame::setNeedsReapplyStyles stub to FrameQt.cpp
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:18 AM Changeset in webkit [26868] by
-
- 3 edits in trunk/WebCore
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Implement the WebCore::fileSize function. The
implementation assumes that QFileInfo will cache
the result of the stat so that info.size() and
info.exists() use the same stat result.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 2:15 AM Changeset in webkit [26867] by
-
- 3 edits1 move1 add in trunk/WebCore
2007-10-21 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Use the portable GLib time function.
Use event timestamps rather than the current time where available.
Rename SharedTimerLinux.cpp since it isn't Linux-specific.
- WebCore.pro:
- platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/gtk/SystemTimeGtk.cpp: Added. (WebCore::currentTime):
- platform/gtk/SharedTimerGtk.cpp: Copied from platform/gtk/SharedTimerLinux.cpp.
- platform/gtk/SharedTimerLinux.cpp: Removed.
- 1:42 AM Changeset in webkit [26866] by
-
- 2 edits in trunk/WebKitTools
Fix support for Signed-off-by detection in prepare-ChangeLog
--git-commit. The Signed-off-by tag does not appear in the header
but usually at the end.
- 12:31 AM Changeset in webkit [26865] by
-
- 2 edits in trunk/WebCore
Fix for 15596, regression from my transform changes. Preserve null checks on the clip rects calls for parent(),
since the method is called on orphaned layers. This is not very well understood.
Reviewed by eric
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
Oct 21, 2007:
- 11:26 PM Changeset in webkit [26864] by
-
- 8 edits in trunk
2007-10-21 Mark Rowe <mrowe@apple.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15575
Bug 15575: [GTK] Implement threading using GThread
- wtf/Platform.h: Do not enable pthreads for Gtk.
2007-10-21 Mark Rowe <mrowe@apple.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15575
Bug 15575: [GTK] Implement threading using GThread
- WebCore.pro: Remove ThreadingPthreads.cpp from the Gtk build and link against libgthreads.
- loader/icon/IconDatabase.cpp: Initialize threading before the mutex is created to be compatible with gthreads. (WebCore::iconDatabase): (WebCore::IconDatabase::open):
- platform/Threading.h:
- platform/gtk/ThreadingGtk.cpp: Threading implementation in terms of GThread, based heavily on the pthreads implementation. (WebCore::initializeThreading): (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::establishIdentifierForThread): (WebCore::threadForIdentifier): (WebCore::clearThreadForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
- storage/Database.cpp: (WebCore::Database::Database): Initialize threading when Database is used so that it will be initialized even if the icon database is compiled out
- 11:08 PM Changeset in webkit [26863] by
-
- 2 edits in trunk/SunSpider
2007-10-21 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
- sunspider: make --shark only sample from testkjs
- 10:44 PM Changeset in webkit [26862] by
-
- 5 edits in trunk
2007-10-21 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=15603
Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript
- kjs/array_object.cpp: (KJS::freeStorage): Reinstate null-check that was removed in r26847.
2007-10-21 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Test for http://bugs.webkit.org/show_bug.cgi?id=15603
Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript
- fast/js/kde/Array-expected.txt:
- fast/js/kde/resources/Array.js: Update to cover sorting an empty array.
- 8:57 PM Changeset in webkit [26861] by
-
- 1 copy in tags/Safari-523.12.6b
New tag.
- 8:57 PM Changeset in webkit [26860] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 8:16 PM Changeset in webkit [26859] by
-
- 2 edits in trunk/WebKitTools
2007-10-21 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Fix run-javascriptcore-tests for Gtk.
- Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
- 8:13 PM Changeset in webkit [26858] by
-
- 2 edits3 adds in trunk/SunSpider
Rubber stamped by Eric.
- added crypto tests (already balanced)
- tests/LIST:
- tests/crypto-aes.js: Added.
- tests/crypto-md5.js: Added.
- tests/crypto-sha1.js: Added.
- 7:26 PM Changeset in webkit [26857] by
-
- 2 edits in trunk/WebCore
2007-10-21 Mark Rowe <mrowe@apple.com>
Build fix.
- ksvg2/css/SVGCSSStyleSelector.cpp: Use fabsf when dealing with a float to prevent the implicit conversion warning.
- 7:09 PM BuildBot edited by
- (diff)
- 7:06 PM BuildBot edited by
- (diff)
- 7:05 PM Changeset in webkit [26856] by
-
- 2 edits in trunk/WebCore
2007-10-21 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Implement spelling and grammar mistake underlining with Pango/Cairo.
This change does not add any actual support for spelling or grammar
checking to any port.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- 4:16 PM Changeset in webkit [26855] by
-
- 7 edits in trunk/SunSpider
Reviewed by Adam.
- rebalance new tests
Scaled the new tests so they take 400-600ms on a reasonably normal user setup:
Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M
This balances them with the existing tests.
- tests/access-binary-trees.js:
- tests/access-nsieve.js:
- tests/bitops-nsieve-bits.js:
- tests/math-partial-sums.js:
- tests/math-spectral-norm.js:
- tests/string-fasta.js:
- 3:44 PM Changeset in webkit [26854] by
-
- 5 edits in trunk/WebCore
2007-10-21 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Cairo canvas fixes:
Fix a refcounting issue leading to leaks and crashes on canvas
content.
Delegate memory management of canvas images to Cairo.
Mark unhandled conditions with notImplemented() instead of silently
ignoring them.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
- html/CanvasStyle.h:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
- 2:17 PM Changeset in webkit [26853] by
-
- 3 edits in trunk/LayoutTests
Not reviewed.
Forgot to land the new computed style results in fast/css - after the addition of glyph-orientation-*.
- 1:35 PM Changeset in webkit [26852] by
-
- 10 edits2 adds in trunk
Reviewed by Eric.
Handle glyph-orientation-vertical / glyph-orientation-horizontal SVG CSS properties.
The SVG layouting code itself doesn't handle these properties yet,
it's just about recognizing them in the SVG CSS engine.
- 11:40 AM Changeset in webkit [26851] by
-
- 2 edits in trunk/WebKitSite
WebKitSite:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=15592 DOM Exception opening up client-side database example for the first time
There was a race condition when creating the WebKitStickyNotes table for the
first time in which the loaded() function (renamed to loadNotes()) could be
called before the table was created. Prevent this by only calling loadNotes()
in an executeSql() callback after we know the table exists, or after we know
the table has been created.
- misc/DatabaseExample.html: Renamed loaded() function to loadNotes(). Created a new loaded() function.
- 11:37 AM Changeset in webkit [26850] by
-
- 3 edits in trunk/JavaScriptCore
- fix Windows build
- kjs/array_instance.h: Removed unused ExecState parameter.
- kjs/array_object.cpp: (KJS::ArrayInstance::put): Ditto. (KJS::ArrayInstance::setLength): Ditto.
- 11:36 AM Changeset in webkit [26849] by
-
- 2 edits in trunk/WebCore
2007-10-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15589
Use glib's path separator on gtk
- platform/gtk/FileSystemGtk.cpp: (WebCore::pathByAppendingComponent):
- 9:53 AM Changeset in webkit [26848] by
-
- 2 edits in trunk/JavaScriptCore
- kjs/array_object.cpp: (KJS::ArrayInstance::put): Add missing assignment that was causing regression test crash.
- 8:12 AM Changeset in webkit [26847] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15585 speed up sparse arrays by using a custom map
Speeds up SunSpider by 10%.
- kjs/array_object.cpp: (allocateStorage): Leave room for an additional pointer. (reallocateStorage): Ditto. (freeStorage): Ditto. (ArrayInstance::~ArrayInstance): Delete the overflow map if present. (ArrayInstance::getItem): Read values from the overflow map if present. Removed the check of length, since it slows down the common case. (ArrayInstance::getOwnPropertySlot): Ditto. Also removed the fallback to the property map. (ArrayInstance::put): Write values into the overflow map as needed. Also create overflow map when needed. (ArrayInstance::deleteProperty): Remove values from the overflow map as appropriate. (ArrayInstance::getPropertyNames): Add a name for each identifier in the property map. This is extremely inefficient. (ArrayInstance::setLength): Remove any values in the overflow map that are past the new length, as we formerly did with the property map. (ArrayInstance::mark): Mark any values in the overflow map. (compareByStringForQSort): Removed unneeded undefined case, since compactForSorting guarantees we will have no undefined values. (compareWithCompareFunctionForQSort): Ditto. (ArrayInstance::compactForSorting): Copy all the values out of the overflow map and destroy it.
- kjs/property_map.h: Removed now-unused getSparseArrayPropertyNames.
- kjs/property_map.cpp: Ditto.
- 12:10 AM Changeset in webkit [26846] by
-
- 6 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15259 <rdar://problem/5499902> REGRESSION: Text overflows when using word spacing and centering (affects myspace.com music videos page)
Test: fast/text/word-space.html
- rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Added word-spacing to the width of the space being stripped out.
- rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Changed handling of leading space. Since Font::width includes leading space width but not leading word spacing, this method needs to either remove the width of a space character or add word spacing, depending on stripFrontSpaces. (WebCore::RenderText::calcPrefWidths): Corrected the check for adding trailing word spacing so that it would work in the case where the last space is ignored.
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to actually add word spacing to the total width.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15259 <rdar://problem/5499902> REGRESSION: Text overflows when using word spacing and centering (affects myspace.com music videos page)
- fast/text/word-space.html: Added.
- platform/mac/fast/css/word-space-extra-expected.txt: Updated result.
- platform/mac/fast/text/word-space-expected.checksum: Added.
- platform/mac/fast/text/word-space-expected.png: Added.
- platform/mac/fast/text/word-space-expected.txt: Added.
Oct 20, 2007:
- 11:48 PM Changeset in webkit [26845] by
-
- 4 adds in trunk/LayoutTests/platform/mac/fast/transforms
Add new transforms directory along with an initial layout test.
- 11:44 PM Changeset in webkit [26844] by
-
- 2 adds in trunk/LayoutTests/fast/transforms
Add new transforms directory along with an initial layout test.
- 11:39 PM Changeset in webkit [26843] by
-
- 9 edits in trunk/WebCore
Land support for the transform CSS property. Basic painting now works properly. There are many open issues
that will have to be covered by individual bugs.
Reviewed by olliej
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseTransform):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateTransform): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::boundingBox):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
- rendering/RenderStyle.h: (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::MatrixTransformOperation::isMatrixOperation):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
- rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):
- 11:36 PM Changeset in webkit [26842] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam.
Add basic @font-face to the Web Inspector.
- page/InspectorController.cpp: (WebCore::InspectorResource::type): Check for CachedResource::FontResource.
- page/inspector/Resource.js: Add support for Font types and font preview in the icon.
- page/inspector/ResourcePanel.js: Show a font preview for font resources.
- page/inspector/inspector.css: Style for the font preview and font icon.
- page/inspector/inspector.js: Add font mime types.
- 10:19 PM Changeset in webkit [26841] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Fixes:
- http://bugs.webkit.org/show_bug.cgi?id=14393 Column on the left side of the Web Inspector should have a smaller minimum width for resizing
- http://bugs.webkit.org/show_bug.cgi?id=14394 Left pane of the Web Inspector "shakes" when resizing it to maximum width
- page/inspector/inspector.js: Change the constraint logic to only enforce a 100px min-width and window.innerWidth - 100 max-width for the sidebar. The change also makes the viewbuttons move with the sidebar.
- 9:00 PM Changeset in webkit [26840] by
-
- 7 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15208 display:table causes the collapsed text to show at a different position when expanded
Test: fast/table/insert-before-anonymous-ancestors.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever that change was supposed to accomplish has since been done in other places in the code.
LayoutTests:
Reviewed by Dave Hyatt.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=15208 display:table causes the collapsed text to show at a different position when expanded
- fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
- fast/table/form-in-table-before-misnested-text-crash-expected.txt:
- fast/table/insert-before-anonymous-ancestors.html: Added.
- fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
- fast/table/section-in-table-before-misnested-text-crash-expected.txt:
- platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
- platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
- platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.
- 8:06 PM Changeset in webkit [26839] by
-
- 2 edits in trunk/WebKitTools
2007-10-20 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
- Scripts/find-extra-includes: fix path matching regex to not match ".patch"
- 7:43 PM Changeset in webkit [26838] by
-
- 8 edits1 add in trunk
2007-10-20 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add improved argument handling to run-sunspider, including
--runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
Also re-factor code into subroutines
- Scripts/build-dumprendertree: removed bogus comments
- Scripts/build-testkjs: Added.
- Scripts/run-javascriptcore-tests: use build-testkjs
- Scripts/run-sunspider: improved argument handling, abstraction
- Scripts/run-webkit-tests: improved abstraction
- 7:41 PM Changeset in webkit [26837] by
-
- 2 edits in trunk/WebCore
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
Fix http://bugs.webkit.org/show_bug.cgi?id=15584
Bug 15584: REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance
- platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): If the fallback page exists but does not have a glyph for the character, fall back to the missing glyph data rather than returning an invalid GlyphData.
- 4:01 PM Changeset in webkit [26836] by
-
- 3 edits6 adds in trunk/SunSpider
Reviewed by Mark.
- Add more new tests, mostly from the computer language shootout. Not normalized yet.
- TODO:
- tests/LIST:
- tests/access-binary-trees.js: Added.
- tests/access-nsieve.js: Added.
- tests/bitops-nsieve-bits.js: Added.
- tests/math-partial-sums.js: Added.
- tests/math-spectral-norm.js: Added.
- tests/string-fasta.js: Added.
- 3:54 PM Changeset in webkit [26835] by
-
- 2 edits in trunk/WebCore
2007-10-20 Jasper Bryant-Greene <m@ni.ac.nz>
Reviewed by Maciej.
Changed the hard-coded scroll delta in WheelEventGtk from 120 to 0.25,
as suggested by George Wright in #15108 (which this patch will
resolve).
This gives a more sane scrolling behaviour, rather than the
jumping to the end or start of the document as occurred previously.
- platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 3:43 PM Changeset in webkit [26834] by
-
- 1 edit in trunk/SunSpider/ChangeLog
Fix reviewer in ChangeLog.
- 3:42 PM Changeset in webkit [26833] by
-
- 9 edits in trunk/SunSpider
Reviewed by Eric.
- TODO: Updated to note areas that are now well-covered.
- Change the tests and the driver to avoid leaving large object graphs hanging around, since that throws off the subsequent tests.
- resources/sunspider-standalone-driver.js:
- tests/3d-cube.js:
- tests/3d-morph.js:
- tests/3d-raytrace.js:
- tests/bitops-bitwise-and.js:
- tests/string-base64.js:
- tests/string-tagcloud.js:
- 3:38 PM Changeset in webkit [26832] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15579 stop churning identifier reference counts copying Completion objects
- kjs/completion.h: Replace the Identifier with an Identifier*.
- kjs/nodes.cpp: (ForInNode::execute): Update for change to Completion constructor. (ContinueNode::execute): Ditto. (BreakNode::execute): Ditto.
- 3:10 PM Changeset in webkit [26831] by
-
- 4 edits1 move2 adds in trunk/WebCore
2007-10-20 Alp Toker <alp@atoker.com>
Reviewed by Eric.
Support text boundary detection.
Move TextBoundariesWin.cpp to platform/ since it's portable and useful.
Split out and implement some TemporaryLinkStubs.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- platform/TextBoundariesICU.cpp: Copied from WebCore/platform/win/TextBoundariesWin.cpp.
- platform/gtk/Language.cpp: Added. (WebCore::defaultLanguage):
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/gtk/TextBreakIteratorInternalICUGtk.cpp: Added. (WebCore::currentTextBreakLocaleID):
- platform/win/TextBoundariesWin.cpp: Removed.
- 2:00 PM Changeset in webkit [26830] by
-
- 2 edits in trunk/WebCore
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Workaround for http://bugs.webkit.org/show_bug.cgi?id=15574
Bug 15574: Web Inspector doesn't work with the new Database feature
The executeSql callback is executed in the security domain of the web page that owns the database,
while the inspector's window object is in the callback functions scope chain. This is leading to a
security violation when the callback attempts to access "document". We can work around this by
ensuring that "document" can be found in the scope chain before the window object.
- page/inspector/DatabasePanel.js:
- 11:57 AM Changeset in webkit [26829] by
-
- 2 edits in trunk/WebKitTools
Windows build fix
- 11:25 AM Changeset in webkit [26828] by
-
- 2 edits2 adds2 deletes in trunk/WebKitSite
2007-10-20 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Adam.
Convert TIFFs to PNGs so that the demo page is fully-functional in the Gtk port.
- misc/DatabaseExample.html:
- misc/deleteButton.png: Added.
- misc/deleteButton.tiff: Removed.
- misc/deleteButtonPressed.png: Added.
- misc/deleteButtonPressed.tiff: Removed.
- 10:30 AM Changeset in webkit [26827] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15567 speed up hashing const char* by removing call to strlen
This includes one other fix as well. Both were from a day where I did some
profiling to find hot spots when running the page load test.
- platform/StringImpl.cpp: (WebCore::StringImpl::computeHash): Compute the hash without calling strlen. Also change the argument names to not confusingly use m_ prefixes. (WebCore::StringImpl::createStrippingNull): Added a faster case for strings that don't have null.
- 10:29 AM Changeset in webkit [26826] by
-
- 5 edits in trunk
WebKitTools:
Reviewed by Tim Hatcher.
- http://bugs.webkit.org/show_bug.cgi?id=15544 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to not rely on Apple-specific key codes
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): Added named key "rightArrow". Later we could have a whole table of these. Also tweaked modifiers code a little.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
LayoutTests:
Reviewed by Tim Hatcher.
- http://bugs.webkit.org/show_bug.cgi?id=15544 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to not rely on Apple-specific key codes
- fast/events/arrow-navigation.html: Use "rightArrow" instead.
- 10:26 AM Changeset in webkit [26825] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Eric.
- http://bugs.webkit.org/show_bug.cgi?id=15566 possible fix for leak seen in DumpRenderTree
- DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue): Delete the item if it's not put on the queue, since the caller has no way of knowing that. Would be better to have the parameter type be auto_ptr to express the fact that we take ownership.
- unrelated change
- Drosera/mac/main.m: Add missing include.
- 6:54 AM Changeset in webkit [26824] by
-
- 7 edits in trunk
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Alp.
Gtk changes needed to enable HTML 5 client-side database storage.
- wtf/Platform.h: Have Gtk use pthreads for now.
WebCore:
- WebCore.pro: Have Gtk use ThreadingPthreads.cpp.
- platform/pthreads/ThreadingPthreads.cpp: Include errno so that EDEADLK and EBUSY are available.
WebKit/gtk:
- Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory. This should become configurable by client applications in the future.
- 6:01 AM Changeset in webkit [26823] by
-
- 3 edits1 add in trunk/WebCore
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Alp.
Implement callOnMainThread for Gtk+ via a one-shot zero-delay timer that will be dispatched
from the main event loop.
- WebCore.pro:
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/gtk/ThreadingGtk.cpp: Added. (WebCore::callFunctionOnMainThread): (WebCore::callOnMainThread):
- 6:00 AM Changeset in webkit [26822] by
-
- 2 edits in trunk/WebKit/gtk
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Don't allow control characters to be inserted into editable regions.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
- 5:55 AM Changeset in webkit [26821] by
-
- 13 edits in trunk
Reviewed by Eric.
Fix non-functional display="inline" / display="none" for SVG text.
Fixes: svg/W3C-SVG-1.1/animate-elem-39-t.svg (display="inline" support)
Fixes: svg/batik/text/textProperties2.svg (display="inline/none" support)
Fixes: svg/carto.net/tabgroup.svg (display="none" support, stray content before layouting)
- 4:17 AM Changeset in webkit [26820] by
-
- 2 edits1 add in trunk/WebCore
2007-10-20 Mark Rowe <mrowe@apple.com>
Reviewed by Alp.
Replace #ifdef'd code with the appropriate use of a forwarding header.
- ForwardingHeaders/kjs/array_instance.h: Added.
- bindings/js/JSDatabaseCustom.cpp:
- 3:37 AM Changeset in webkit [26819] by
-
- 21 edits in trunk
Reviewed by Oliver.
Add support for 'kerning' property in SVG text layout code.
Support all textLength/lengthAdjust modes on normal text & textPaths.
Support letter & word spacing on textPath.
Fix text selection when any spacing (letter/word/kerning) is involved.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15571
Fixes: svg/batik/text/textOnPathSpaces.svg (spacing)
svg/batik/text/textLayout.svg (kerning support)
svg/text/text-spacing-01-b.svg (text selection)
- 3:37 AM Changeset in webkit [26818] by
-
- 1 edit in trunk/WebKitSite/misc/DatabaseExample.html
Fix typo
- 3:30 AM Changeset in webkit [26817] by
-
- 2 edits2 adds in trunk/WebKitSite
Make the notes sticky!
Reviewed by Mark.
- misc/DatabaseExample.html:
- misc/deleteButton.tiff: Added.
- misc/deleteButtonPressed.tiff: Added.
- 3:20 AM Changeset in webkit [26816] by
-
- 10 edits in trunk/WebCore
2007-10-20 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewd by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15563
Fix conflict with X11 Window type in WebCore
- WebCore/bindings/js/JSDocumentCustom.cpp:
- WebCore/bindings/js/JSHTMLDocumentCustom.cpp:
- WebCore/bindings/js/JSHTMLFrameSetElementCustom.cpp:
- WebCore/bindings/js/kjs_dom.cpp:
- WebCore/bindings/js/kjs_events.cpp:
- WebCore/bindings/js/kjs_proxy.cpp:
- WebCore/history/CachedPage.cpp:
- WebCore/page/Chrome.cpp:
- WebCore/page/Frame.cpp:
- 2:45 AM Changeset in webkit [26815] by
-
- 2 edits in trunk/WebCore
Fix the Qt build.
- 1:51 AM Changeset in webkit [26814] by
-
- 10 edits in trunk/SunSpider
Reviewed by Nikolas.
- Rebalance test complexity.
Scaled all the tests so they take 400-600ms on a reasonably normal user setup:
Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M
However, for some tests, IE7 was a huge outlier compared to other
major browsers. For those tests, I used Firefox 2.0.0.8 on the
same OS and hardware as a normalization basis.
- tests/3d-morph.js:
- tests/3d-raytrace.js:
- tests/bitops-3bit-bits-in-byte.js:
- tests/bitops-bits-in-byte.js:
- tests/bitops-bitwise-and.js:
- tests/math-cordic.js:
- tests/string-base64.js:
- tests/string-tagcloud.js:
- tests/string-unpack-code.js:
- 1:11 AM Changeset in webkit [26813] by
-
- 2 edits in trunk/SunSpider
Reviewed by Oliver.
- Fix the browser-hosted driver to be compatible with Safari 2
- hosted/sunspider-driver.html:
- 1:05 AM Changeset in webkit [26812] by
-
- 2 edits in trunk/SunSpider
Rubber stamped by Hyatt.
- Add BSD license notice to cordic test, the original author said to do so.
- tests/math-cordic.js:
- 12:11 AM Changeset in webkit [26811] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15570
Store gathered declaration nodes in the function body node.
This means that you only have to gather the declaration nodes the first
time the function executes. Performance gain of 2.10% on SunSpider,
0.90% on command-line JS iBench.
- kjs/nodes.cpp: Split declaration stack initialization code off into initializeDeclarationStacks(). (FunctionBodyNode::FunctionBodyNode): (FunctionBodyNode::initializeDeclarationStacks): (FunctionBodyNode::processDeclarations):
- kjs/nodes.h: Changed DeclarationStacks structure to hold references, since the actual Vectors are now stored either on the stack or in the function body node.
Oct 19, 2007:
- 10:37 PM Changeset in webkit [26810] by
-
- 10 edits in trunk
2007-10-19 Alp Toker <alp@atoker.com>
Reviewed by Oliver.
GTK+ build fix enabling the new local database storage feature.
There is also a prospective Qt build fix.
- 10:20 PM Changeset in webkit [26809] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Added Bugzilla link to ChangeLog
- 10:18 PM Changeset in webkit [26808] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
- kjs/function.h:
- kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
- kjs/nodes.cpp: (FunctionBodyNode::execute):
- kjs/nodes.h:
- 9:39 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:35 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:10 PM Changeset in webkit [26807] by
-
- 2 edits in branches/Safari-3-branch/WebKitTools
Merge r26766
- 9:08 PM Changeset in webkit [26806] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson.
Mac build fix.
- WebCore.xcodeproj/project.pbxproj:
- 8:09 PM Changeset in webkit [26805] by
-
- 2 edits in trunk/LayoutTests
Updating window properties to include new features from HTML5 database support
RS=Mark
- fast/dom/Window/window-properties-expected.txt:
- 7:20 PM Changeset in webkit [26804] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Mark Rowe.
Fix a couple of exceptions for first time users.
- misc/DatabaseExample.html:
- 6:48 PM Changeset in webkit [26803] by
-
- 3 edits in trunk/WebCore
2007-10-19 Alp Toker <alp@atoker.com>
Reviewed by Oliver.
Use platform colors for text selection.
Update the cache when the GTK style is changed.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkStyleSet): (WebCore::RenderThemeGtk::gtkEntry):
- platform/gtk/RenderThemeGtk.h:
- 6:18 PM Changeset in webkit [26802] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Beth.
Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
Test: fast/forms/menulist-no-overflow.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.
LayoutTests:
Reviewed by Beth.
Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
- fast/forms/menulist-no-overflow.html: Added.
- platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
- platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
- platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.
- 6:06 PM Changeset in webkit [26801] by
-
- 3 edits6 moves in trunk/WebCore
Reviewed by Brady.
Move some SQL-related classes to platform/sql.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/icon/SQLDatabase.cpp: Removed.
- loader/icon/SQLDatabase.h: Removed.
- loader/icon/SQLStatement.cpp: Removed.
- loader/icon/SQLStatement.h: Removed.
- loader/icon/SQLTransaction.cpp: Removed.
- loader/icon/SQLTransaction.h: Removed.
- platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
- platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
- platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
- platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
- platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
- platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.
- 5:49 PM Changeset in webkit [26800] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Brady.
Make example actually work.
- misc/DatabaseExample.html:
- 5:45 PM Changeset in webkit [26799] by
-
- 6 edits in trunk
WebCore:
Reviewed by Adam.
Update to match the latest version of the spec. Now, executeSQL takes an array
of SQL parameters instead of them being passed as arguments.
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::executeSql):
- page/inspector/DatabasePanel.js:
- storage/Database.idl:
WebKitSite:
Reviewed by Adam.
Update example.
- misc/DatabaseExample.html:
- 5:38 PM Changeset in webkit [26798] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
- This change should be identical but for some reason was not working on my machine.
- Scripts/prepare-ChangeLog:
- 5:22 PM Changeset in webkit [26797] by
-
- 6 edits in trunk
WebCore:
Reviewed by Tim
Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker):
WebKitSite:
Reviewed by Tim
Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
- misc/DatabaseExample.html:
- 4:57 PM Changeset in webkit [26796] by
-
- 2 edits in trunk/WebCore
Release build fix.
- WebCore.vcproj/WebCore.vcproj:
- 4:42 PM Changeset in webkit [26795] by
-
- 1 copy in tags/Safari-523.12.5b
New tag.
- 4:42 PM Changeset in webkit [26794] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 4:37 PM Changeset in webkit [26793] by
-
- 2 edits in trunk/WebCore
Remove stray printfs
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
- 4:36 PM Changeset in webkit [26792] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
already been locked, so lock the mutex first.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
- 4:34 PM Changeset in webkit [26791] by
-
- 2 edits in trunk/WebCore
Better build fix
- loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): Definite works by 3.3.13
- 4:25 PM Changeset in webkit [26790] by
-
- 2 edits in trunk/WebCore
Build fix
- loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were added to SQLite, but I know they were by 3.4.0
- 3:55 PM Changeset in webkit [26789] by
-
- 1 copy in tags/Safari-523.12.4b
New tag.
- 3:55 PM Changeset in webkit [26788] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 3:50 PM Changeset in webkit [26787] by
-
- 48 edits24 copies34 adds in trunk
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Sam
Queue -> Deque! and small style tweaks
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
- wtf/Deque.h: Added. (WTF::DequeNode::DequeNode): (WTF::Deque::Deque): (WTF::Deque::~Deque): (WTF::Deque::size): (WTF::Deque::isEmpty): (WTF::Deque::append): (WTF::Deque::prepend): (WTF::Deque::first): (WTF::Deque::last): (WTF::Deque::removeFirst): (WTF::Deque::clear):
- wtf/Queue.h: Removed.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver
Added a simple LinkedList based Queue to wtf
We can make a better, more sophisticated an efficient one later, but have
needed one for some time, now!
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Queue.h: Added. (WTF::QueueNode::QueueNode): (WTF::Queue::Queue): (WTF::Queue::~Queue): (WTF::Queue::size): (WTF::Queue::isEmpty): (WTF::Queue::append): (WTF::Queue::prepend): (WTF::Queue::first): (WTF::Queue::last): (WTF::Queue::removeFirst): (WTF::Queue::clear):
WebCore:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Windows specific changes, as well as renaming Queue -> Deque
- ForwardingHeaders/wtf/Deque.h: Added.
- ForwardingHeaders/wtf/Queue.h: Removed.
- platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath):
- storage/Database.h:
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::documentGoingAway): (WebCore::DatabaseThread::databaseGoingAway): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask):
- storage/DatabaseThread.h:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim and Anders
Preliminary support for HTML5 local database storage (http://www.whatwg.org/specs/web-apps/current-work/)
The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
this implementation even while filing bugs to track changes in the spec as it becomes more final
There are some implementation details in this patch that seem unused or useless, but they remain in place
while the spec is in flux and might go one way or another.
- platform/Logging.cpp: Add StorageAPI logging channel
- platform/Logging.h:
- storage/Database.cpp: Added. (WebCore::Database::databaseInfoTableName): (WebCore::databaseVersionKey): (WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::retrieveTextResultFromDatabase): (WebCore::Database::getVersionFromDatabase): (WebCore::setTextValueInDatabase): (WebCore::Database::setVersionInDatabase): (WebCore::Database::databaseThreadGoingAway): May be removed in the future (WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions (WebCore::Database::enableAuthorizer): (WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker. The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future (WebCore::Database::resetAuthorizer): (WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage (WebCore::Database::scheduleDatabaseCallback): (WebCore::Database::performOpenAndVerify): (WebCore::Database::performChangeVersion): (WebCore::Database::performExecuteSql): (WebCore::Database::performCloseTransaction): (WebCore::Database::performGetTableNames): (WebCore::Database::version): C++ version of the javascript API (WebCore::Database::changeVersion): Ditto (WebCore::Database::executeSql): Ditto (WebCore::Database::closeTransaction): Ditto (WebCore::Database::tableNames): For internal (WebInspector) use (WebCore::Database::deliverAllPendingCallbacks): (WebCore::Database::deliverPendingCallbacks):
- storage/Database.h: Added. (WebCore::Database::databaseDebugName): For debug logging purposes
- storage/Database.idl: Added.
- storage/DatabaseAuthorizer.cpp: Added. The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as tracking when effects certain sql statements might have (such as increasing the size of the database) (WebCore::DatabaseAuthorizer::DatabaseAuthorizer): (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::createTempTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::dropTempTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTempIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::dropTempIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createTempTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::dropTempTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::allowRead): (WebCore::DatabaseAuthorizer::allowAnalyze): (WebCore::DatabaseAuthorizer::allowPragma): (WebCore::DatabaseAuthorizer::allowAttach): (WebCore::DatabaseAuthorizer::allowDetach): (WebCore::DatabaseAuthorizer::allowFunction): (WebCore::DatabaseAuthorizer::disable): (WebCore::DatabaseAuthorizer::enable): (WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the WebKit meta info table as it should be invisible to scripts
- storage/DatabaseAuthorizer.h: Added. (WebCore::DatabaseAuthorizer::lastActionWasInsert): (WebCore::DatabaseAuthorizer::lastActionIncreasedSize):
- storage/DatabaseCallback.cpp: Added. Generic item to queue up for callbacks on the main thread for database activities that take place on a secondary thread (WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback): (WebCore::DatabaseChangeVersionCallback::performCallback): (WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback): (WebCore::DatabaseExecuteSqlCallback::performCallback):
- storage/DatabaseCallback.h: Added. (WebCore::DatabaseCallback::~DatabaseCallback): (WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback): (WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):
- storage/DatabaseTask.h: Added. Generic work-item to be queued up on the background database thread (WebCore::DatabaseTask::isComplete): (WebCore::DatabaseOpenTask::exceptionCode): (WebCore::DatabaseOpenTask::openSuccessful): (WebCore::DatabaseTableNamesTask::tableNames):
- storage/DatabaseTask.cpp: Added. (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::~DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished synchronously (WebCore::DatabaseTask::waitForSynchronousCompletion):
(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
(WebCore::DatabaseExecuteSqlTask::doPerformTask):
(WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
(WebCore::DatabaseChangeVersionTask::doPerformTask):
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):
- storage/DatabaseThread.cpp: Added. The current design is that each Document will have its own DatabaseThread. This makes scripts on each individual document more response at the cost of adding more threads and potentially creating concurrency issues when the same database is open twice from two different documents (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::~DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed (WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database (WebCore::DatabaseThread::databaseThreadStart): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when the main thread requires a task be performed synchronously (WebCore::DatabaseThread::wakeWorkThread):
- storage/DatabaseThread.h: Added.
- storage/DatabaseTracker.cpp: Added. The DatabaseTracker is the master management of all databases. It will keep track of the filename for a given unique database, keep track of the total disk usage per-origin, and policys per database/origin (WebCore::DatabaseTracker::setDatabasePath): (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::tracker): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
- storage/DatabaseTracker.h: Added.
- storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback (WebCore::SQLCallback::~SQLCallback):
- storage/SQLCallback.idl: Added.
- storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object (WebCore::SQLResultSet::SQLResultSet): (WebCore::SQLResultSet::insertId): (WebCore::SQLResultSet::rowsAffected): (WebCore::SQLResultSet::errorCode): (WebCore::SQLResultSet::error): (WebCore::SQLResultSet::rows): (WebCore::SQLResultSet::setInsertId): (WebCore::SQLResultSet::setRowsAffected): (WebCore::SQLResultSet::setErrorCode): (WebCore::SQLResultSet::setErrorMessage):
- storage/SQLResultSet.h: Added.
- storage/SQLResultSet.idl: Added.
- storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object (WebCore::SQLResultSetRowList::length):
- storage/SQLResultSetRowList.h: Added. (WebCore::SQLResultSetRowList::columnNames): (WebCore::SQLResultSetRowList::values): (WebCore::SQLResultSetRowList::addColumn): (WebCore::SQLResultSetRowList::addResult):
- storage/SQLResultSetRowList.idl: Added.
- storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback (WebCore::VersionChangeCallback::~VersionChangeCallback):
- storage/VersionChangeCallback.idl: Added.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver + Same
Forwarding header for the new wtf/Queue.h
- ForwardingHeaders/wtf/Queue.h: Added.
2007-10-19 Anders Carlsson <beidson@apple.com>
Reviewed by Sam Weinig
Most of the Javascript binding support for the Storage API
- bindings/js/JSCustomSQLCallback.cpp: Added. (WebCore::JSCustomSQLCallback::JSCustomSQLCallback): (WebCore::JSCustomSQLCallback::handleEvent):
- bindings/js/JSCustomSQLCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
- bindings/js/JSCustomVersionChangeCallback.cpp: Added. (WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback): (WebCore::JSCustomVersionChangeCallback::handleEvent):
- bindings/js/JSCustomVersionChangeCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
- bindings/js/JSDatabaseCustom.cpp: Added. (WebCore::JSDatabase::executeSql): Custom implementation of executeSql that takes an array of parameters.
(WebCore::JSDatabase::changeVersion):
Custom implementation of changeVersion.
- bindings/js/JSSQLResultSetRowListCustom.cpp: Added. (WebCore::JSSQLResultSetRowList::item): Custom method that returns a JS object that corresponds to a given row in the database.
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl: Add openDatabase implementation.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver
Added tons of utility to the FileSystem abstractions, including moving
some stuff over from IconDatabase
- platform/FileSystem.h:
- platform/cf/FileSystemCF.cpp: Added. (WebCore::fileSystemRepresentation):
- platform/mac/FileSystemMac.mm:
- platform/posix/FileSystemPOSIX.cpp: Added. (WebCore::fileExists): (WebCore::deleteFile): (WebCore::fileSize): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories):
2007-10-19 Timothy Hatcher <timothy@apple.com>
Reviewed by Adam Roben
Preliminary Web Inspector support for the Storage API
(This patch does not include the support artwork)
- page/InspectorController.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::setScriptObject): (WebCore::databaseTableNames): Return the table names for a Database object. (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database. (WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database. (WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources. (WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources(). (WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
- page/InspectorController.h:
- page/inspector/Database.js: Added.
- page/inspector/DatabasePanel.js: Added.
- page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
- page/inspector/inspector.css: Add styles for the database panel.
- page/inspector/inspector.html: Include DatabasePanel.js
- page/inspector/inspector.js: Support for adding and removing Database resources.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Added support for Chrome prompts required by the Storage API
- page/Chrome.cpp: (WebCore::Chrome::runDatabaseSizeLimitPrompt):
- page/Chrome.h:
- page/ChromeClient.h:
- platform/graphics/svg/SVGImageEmptyClients.h:
2007-10-19 Brady Eidson <beidson@apple.com>
Contributions and Review by Anders
Various SQLite tweaks in preparation for the storage API
- loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::~SQLDatabase): (WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions (WebCore::SQLDatabase::setAuthorizer): (WebCore::SQLDatabase::lock): (WebCore::SQLDatabase::unlock):
- loader/icon/SQLDatabase.h:
- loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Switch to prepare16_v2 (WebCore::SQLStatement::bindDouble): Added (WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later) (WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
- loader/icon/SQLStatement.h: (WebCore::SQLStatement::isPrepared):
- platform/sql/SQLAuthorizer.cpp: Added. Fully virtual interface to implement your own SQLite authorizer
- platform/sql/SQLAuthorizer.h: Added. (WebCore::SQLAuthorizer::~SQLAuthorizer): (WebCore::SQLAuthorizer::createTable): (WebCore::SQLAuthorizer::createTempTable): (WebCore::SQLAuthorizer::dropTable): (WebCore::SQLAuthorizer::dropTempTable): (WebCore::SQLAuthorizer::allowAlterTable): (WebCore::SQLAuthorizer::createIndex): (WebCore::SQLAuthorizer::createTempIndex): (WebCore::SQLAuthorizer::dropIndex): (WebCore::SQLAuthorizer::dropTempIndex): (WebCore::SQLAuthorizer::createTrigger): (WebCore::SQLAuthorizer::createTempTrigger): (WebCore::SQLAuthorizer::dropTrigger): (WebCore::SQLAuthorizer::dropTempTrigger): (WebCore::SQLAuthorizer::createView): (WebCore::SQLAuthorizer::createTempView): (WebCore::SQLAuthorizer::dropView): (WebCore::SQLAuthorizer::dropTempView): (WebCore::SQLAuthorizer::createVTable): (WebCore::SQLAuthorizer::dropVTable): (WebCore::SQLAuthorizer::allowDelete): (WebCore::SQLAuthorizer::allowInsert): (WebCore::SQLAuthorizer::allowUpdate): (WebCore::SQLAuthorizer::allowTransaction): (WebCore::SQLAuthorizer::allowSelect): (WebCore::SQLAuthorizer::allowRead): (WebCore::SQLAuthorizer::allowAttach): (WebCore::SQLAuthorizer::allowDetach): (WebCore::SQLAuthorizer::allowReindex): (WebCore::SQLAuthorizer::allowAnalyze): (WebCore::SQLAuthorizer::allowFunction):
- platform/sql/SQLValue.cpp: Added. Contains a value for a SQLite database that can be one of a few types. For now, just a String or a double (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::string): (WebCore::SQLValue::number):
- platform/sql/SQLValue.h: Added. (WebCore::SQLValue::): (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::type):
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Maciej
Changed IconDatabase over to use new FileSystem apis
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
WebKit:
Reviewed by Tim Hatcher
Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path
- Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and remove the current available databases
- Misc/WebDatabaseManager.mm: Added. (+[WebDatabaseManager origins]): (+[WebDatabaseManager databasesWithOrigin:]): (+[WebDatabaseManager deleteAllDatabases]): (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]): (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
- Misc/WebDatabaseManagerPrivate.h: Added.
- WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for an origin exceeding its size limit
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runDatabaseSizeLimitPrompt):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebUIDelegate.h:
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
- WebView/WebViewInternal.h:
WebKitSite:
Reviewed by Tim Hatcher
Sample database API usage
- misc/DatabaseExample.html: Added.
WebKit/win:
Reviewed by Anders
Keep windows building with new Chrome additions
- WebChromeClient.cpp:
- WebChromeClient.h:
- 3:21 PM Changeset in webkit [26786] by
-
- 7 edits in trunk/WebKitTools
Reviewed by Oliver and Tim.
- Made use of RetainPtr to avoid retain and release issues and moved the log function to DebuggerDocumentPlatform, which seems to be a more logical place for it to live.
- Also moved knownServers from the ServerConnection to DebuggerApplication to match the Windows code and because it makes sense that a connection knows its own server but not all of them.
- Drosera/mac/DebuggerClient.h: Moved the log function to DebuggerDocumentPlatform.
- Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server Because it's owned by an own Ptr in DebuggerDocument. Also moved the call for the server name up from the ServerConnection class. (-[DebuggerClient dealloc]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call for the server name up from the ServerConnection.
- Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog): Log directly from here. No need to call DebuggerClient.
- Drosera/mac/ServerConnection.h: Removed the knownServers function. The way I see it, a ServerConnection should only know about its connection and the group of all possible servers should be kept by the application.
- Drosera/mac/ServerConnection.mm: Removed knownServer but added currentServerName, it makes sense that the connection should know that name. (-[ServerConnection currentServerName]):
- 3:00 PM Changeset in webkit [26785] by
-
- 2 edits in trunk/WebCore
Fix for ebay parser crash.
Reviewed by Beth
fast/invalid/table-residual-style-crash.html added as a test
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
- 2:58 PM Changeset in webkit [26784] by
-
- 4 adds in trunk/LayoutTests
Add new layout test for parser crash.
- 2:25 PM Changeset in webkit [26783] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Anders.
Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.
- 2:17 PM Changeset in webkit [26782] by
-
- 3 edits in trunk/WebCore
Fix Windows, Qt and GTK builds.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 2:03 PM Changeset in webkit [26781] by
-
- 59 edits in trunk/LayoutTests
Rubberstamped by Oliver.
Land tiger baseline matching my MBP, as discussed with Oliver.
Mostly differences regarding the size of "(" / ")" characters.
- 1:53 PM Changeset in webkit [26780] by
-
- 21 edits2 adds in trunk
WebCore:
Reviewed by Darin.
Encapsulate the same origin check into the new SecurityOrigin class.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultEventHandler):
- dom/Document.h: (WebCore::Document::securityOrigin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::setOpener):
- loader/FrameLoader.h:
- platform/SecurityOrigin.cpp: Added. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::clear): (WebCore::SecurityOrigin::isEmpty): (WebCore::SecurityOrigin::setForFrame): (WebCore::SecurityOrigin::setDomainFromDOM): (WebCore::SecurityOrigin::allowsAccessFrom): (WebCore::SecurityOrigin::isSecureTransitionTo):
- platform/SecurityOrigin.h: Added.
LayoutTests:
Reviewed by Darin.
Update results after changing the warning message in isSafeScript to print the frame URL
rather than the security domain URL. This now also prints the warning when using data:
URLs because we no longer return early.
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:
- 1:04 PM Changeset in webkit [26779] by
-
- 9 edits3 adds2 deletes in trunk/WebKitTools
Reviewed by Adam.
- Integrated changes from mac drosera. Recently I've encapsulated out the server connection object from the rest of Drosera because it is very platform dependent right now and RPC is not implemented on windows. This functionality, of communicating with the WebKit server is the next area I will be focusing on in Windows.
- Other changes and cleanup were made to organize the code and add notes on which parts still need work. Also some mac code is added and commented out, to act as pseudocode for the logic of those parts.
- Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart pointer.
- Drosera/config.h: Added whitespace.
- Drosera/win/DebuggerApplication.cpp: Removed. The functionality of these files got moved into Drosera.h/cpp
- Drosera/win/DebuggerApplication.h: Removed.
- Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring happened here to better match the logic flow of the same code on the mac side and to use the new ServerConnection class. (DebuggerClient::DebuggerClient): Constructor that takes a server name. (DebuggerClient::initWithServerName): Initializer that will set up the class to use a ServerConnection object. This was necessary so I could create a DebuggerClient without having to initilaize it at construction. (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client will be the UIDelegate and FrameLoadDelegate. (DebuggerClient::AddRef): For IUnknown. (DebuggerClient::Release): For IUnknown. (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate this still needs to set the global context of the server, but IWebFrame does not have an accessor for the global context yet. (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate this is a pass through for the same function in the document. (DebuggerClient::didReceiveTitle): Unimplemented part of FrameLoadDelegate this would change the title of the window. (DebuggerClient::createWebViewWithRequest): Part of the FrameLoadDelegate. This is about new windows via Window.open() and how their delegates are set. (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the UIDelegate. Just a debug function for printing messages.
- Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h because the Client should be the UIDelegate and FrameLoadDelegate to match the delegates on mac. (DebuggerClient::webViewLoaded): Added accessor method.
- Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently forgotten to add this file before. This is where the platform dependent versions of the Documents functions live. Most of these are unimplemented because some piece of functionality does not exist on Windows yet. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
- Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate responsibilities becaue they belong in the Client. Also I laid the groundwork for attaching Drosera to a WebKit process (attachWndProc): Now if a server is selected the Client becomes it's delegate. (Drosera::Drosera): Added the construction of the Client and dictionary of server names. (Drosera::initUI): This is no longer the delegates, the Client is. (Drosera::webViewLoaded): Now asks the Client instead of holding local state. (Drosera::applicationDidFinishLaunching): Placeholder for needed notification registration when it's possible to implement. (Drosera::serverLoaded): Ditto (Drosera::serverUnloaded): Ditto (Drosera::attach): Attach Drosera to the WebKit server.
- Drosera/win/Drosera.h: Ditto for Drosera.cpp comment. (Drosera::getInst): (Drosera::setInst): (Drosera::knownServers):
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication and added the ServerConnection.
- Drosera/win/DroseraPrefix.h: Added an ifndef check.
- Drosera/win/ServerConnection.cpp: Added. This is the interesting part Most of the functions are completely unimlemented because they cannot connect with the WebKit server, because one does not exist on Windows yet. (ServerConnection::initWithServerName): (ServerConnection::~ServerConnection): (ServerConnection::setGlobalContext): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::switchToServerNamed): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie): (ServerConnection::currentFrame):
- Drosera/win/ServerConnection.h: Added. Ditto. (ServerConnection::ServerConnection):
- 11:12 AM Changeset in webkit [26778] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Reviewed by Darin.
Fix for these broken layout tests on Windows:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html
fast/forms/select-accesskey.html
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
- 11:05 AM Changeset in webkit [26777] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
- 10:51 AM Changeset in webkit [26776] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher
- fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
- History/WebHistory.mm: (-[WebHistoryPrivate removeAllItems]): This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition to the other places where it's cleared.
- 10:33 AM Changeset in webkit [26775] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
removing a commented-out test and a test that no longer fails
- platform/mac-leopard/Skipped:
- 10:14 AM Changeset in webkit [26774] by
-
- 2 edits1 copy in trunk/LayoutTests
LayoutTests:
Reviewed by Darin.
Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().
- fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
- fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js. Modified to create isSuccessfullyParsed() function.
- 8:13 AM Changeset in webkit [26773] by
-
- 4 edits in trunk
Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.
- 7:46 AM Changeset in webkit [26772] by
-
- 2 edits in trunk/WebCore
Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.
- 7:14 AM Changeset in webkit [26771] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.
- 4:28 AM Changeset in webkit [26770] by
-
- 2 edits in trunk/JavaScriptCore
Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.
- 4:12 AM Changeset in webkit [26769] by
-
- 3 edits in trunk/WebKit/qt
Fix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.
- 3:38 AM Changeset in webkit [26768] by
-
- 2 edits in trunk/WebCore
Fix the qt/windows build.
- 1:58 AM Changeset in webkit [26767] by
-
- 2 edits in trunk/WebKitTools
2007-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Make the GtkLauncher code slightly more readable.
- GtkLauncher/main.cpp: (setupMainMenu): Added. (setupMainWindowUI): Added. (main):
- 1:01 AM Changeset in webkit [26766] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Adam.
- don't delay-load WebKit in DumpRenderTree.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 12:44 AM Manual Testing created by
- Random manual tests
Oct 18, 2007:
- 10:10 PM Changeset in webkit [26765] by
-
- 1 copy in tags/Safari-523.12.3b
New tag.
- 10:10 PM Changeset in webkit [26764] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 10:09 PM Changeset in webkit [26763] by
-
- 2 edits in branches/Safari-3-branch/JavaScriptCore
Merged fix from r26760.
- 7:45 PM Changeset in webkit [26762] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
removing tests that no longer fail
- platform/mac-leopard/Skipped:
- 7:19 PM Changeset in webkit [26761] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Kevin McCullough.
<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
- editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character between every VisiblePosition. We weren't emitting a space after some tables, because we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline was emitted.
LayoutTests:
Reviewed by Kevin McCullough.
<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
Demonstrates fix for the hang:
- editing/execCommand/5483526-expected.txt: Added.
- editing/execCommand/5483526.html: Added.
Fixed selection endpoint (problems with selection painting prevent this
from being reflected in the pixel test results):
- platform/mac/editing/execCommand/5432254-2-expected.txt:
- 7:14 PM Changeset in webkit [26760] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam.
- use declspec(thread) for fast thread-local storage on Windows
- 2.2% speedup on sunspider (on Windows)
- 7% speedup on the string section
- 6% speedup on JS iBench
- fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
- fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10
- wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::setThreadHeap): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 5:49 PM Changeset in webkit [26759] by
-
- 2 edits in trunk/WebKit
Tiger build fix.
- WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]):
- 5:33 PM Changeset in webkit [26758] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam Roben.
- fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Work around <rdar://problem/5321972> by testing for the case of a response with a MIME type of application/octet-stream and a Content-Type header starting with text/plain and setting the MIME type to text/plain in that case.
WebKit:
Reviewed by Adam Roben.
- fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
- WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse with a MIMEType of application/octet-stream and a Content-Type header starting with text/plain and returning text/plain as the MIME type in that case. (-[WebDataSource _responseMIMEType]): Added. Used to get the correct response MIME type. (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType. (-[WebDataSource _makeRepresentation]): Ditto. (-[WebDataSource mainResource]): Ditto. (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and pass the MIME type explicitly. (-[WebDataSource subresourceForURL:]): Ditto.
- WebView/WebDataSourcePrivate.h:
- WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use _responseMIMEType.
- WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this method to take a MIME type instead of extracting it from the response, so that WebDataSource could pass the correct MIME type.
- WebView/WebResourcePrivate.h:
WebKitTools:
Reviewed by Adam Roben.
- fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): Changed to use _responseMIMEType.
LayoutTests:
Reviewed by Adam Roben.
- removing fixed test
- platform/mac-leopard/Skipped:
- 4:11 PM Changeset in webkit [26757] by
-
- 2 edits in trunk/WebCore
2007-10-18 Mark Rowe <mrowe@apple.com>
Fix the no-SVG build.
- css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for LineCap, LineJoin and WindRule inside #if ENABLE(SVG).
- 2:59 PM Changeset in webkit [26756] by
-
- 5 edits in trunk/WebCore
Reviewed by Anders.
- some small tweaks to the threading implementation
I had trouble building on Windows. Either the problem went away by itself
or one of these changes fixed it.
- platform/Threading.h: Eliminated the use of friend, and shared a single declaration for the initializeThreading function.
- platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait): Call impl() here.
- platform/win/ThreadingWin.cpp: Got rid of two globals here with static constructors. Also added a typedef for the type of the function queue. (WebCore::functionQueueMutex): Added function. (WebCore::functionQueue): Ditto. (WebCore::callFunctionsOnMainThread): Use functions instead of using the globals directly. (WebCore::callOnMainThread): Ditto.
- css/CSSParser.cpp: Had to touch this file to make things build.
- 2:35 PM Changeset in webkit [26755] by
-
- 2 edits in trunk/WebKit/win
Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings
Reviewed by Adele.
- ProgIDMacros.h: Always use wide strings instead of relying on the TEXT macro.
- 1:43 PM Changeset in webkit [26754] by
-
- 1 copy in tags/Safari-523.12.2b
New tag.
- 1:43 PM Changeset in webkit [26753] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 1:29 PM Changeset in webkit [26752] by
-
- 3 edits1 add in branches/Safari-3-branch/WebCore
Merge r26751
- 1:26 PM Changeset in webkit [26751] by
-
- 3 edits1 add in trunk/WebCore
Fix <rdar://5547462> Need to copy Inspector resources in Production builds
I also added an excludes file for the xcopy command to avoid copying
.svn folders.
Reviewed by Geoff.
- WebCore.vcproj/WebCore.make: Make sure we copy the Inspector resources.
- WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to xcopy.
- WebCore.vcproj/xcopy.excludes: Added.
- 10:00 AM Changeset in webkit [26750] by
-
- 4 edits in trunk
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15541 REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply
- page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.
LayoutTests:
Reviewed by Sam.
- test update for http://bugs.webkit.org/show_bug.cgi?id=15541 REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply
- fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.
- 9:44 AM Changeset in webkit [26749] by
-
- 2 edits in trunk/WebCore
Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.
- 9:27 AM Changeset in webkit [26748] by
-
- 1 copy in tags/Safari-523.12.1b
New tag.
- 9:27 AM Changeset in webkit [26747] by
-
- 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION
Bump versions for submit
- 9:21 AM Changeset in webkit [26746] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Nikolas Zimmermann.
- fix http://bugs.webkit.org/show_bug.cgi?id=15367 Assertion failure inspecting a document including soft hyphen code (0xad)
Test: fast/text/word-break-soft-hyphen.html
- rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as word boundaries. This fixes the bug and is consistent with the fact that run rounding does occur at soft hyphens.
LayoutTests:
Reviewed by Nikolas Zimmermann.
- test for http://bugs.webkit.org/show_bug.cgi?id=15367 Assertion failure inspecting a document including soft hyphen code (0xad)
- fast/text/word-break-soft-hyphen.html: Added.
- platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
- platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
- platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.
- 8:19 AM Changeset in webkit [26745] by
-
- 10 edits in trunk
Reviewed by Anders.
Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"
Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)
- 2:57 AM Changeset in webkit [26744] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.
- 1:57 AM Changeset in webkit [26743] by
-
- 2 edits in trunk/WebCore
Release build fix.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 1:39 AM Changeset in webkit [26742] by
-
- 8 edits1 add in trunk/WebCore
Reviewed by Darin.
Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::init):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSPrimitiveValueMappings.h: Added. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EBorderStyle): (WebCore::CSSPrimitiveValue::operator CompositeOperator): (WebCore::CSSPrimitiveValue::operator EAppearance): (WebCore::CSSPrimitiveValue::operator EBackgroundBox): (WebCore::CSSPrimitiveValue::operator EBackgroundRepeat): (WebCore::CSSPrimitiveValue::operator EBoxAlignment): (WebCore::CSSPrimitiveValue::operator EBoxDirection): (WebCore::CSSPrimitiveValue::operator EBoxLines): (WebCore::CSSPrimitiveValue::operator EBoxOrient): (WebCore::CSSPrimitiveValue::operator ECaptionSide): (WebCore::CSSPrimitiveValue::operator EClear): (WebCore::CSSPrimitiveValue::operator ECursor): (WebCore::CSSPrimitiveValue::operator EDisplay): (WebCore::CSSPrimitiveValue::operator EEmptyCell): (WebCore::CSSPrimitiveValue::operator EFloat): (WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak): (WebCore::CSSPrimitiveValue::operator EListStylePosition): (WebCore::CSSPrimitiveValue::operator EListStyleType): (WebCore::CSSPrimitiveValue::operator EMarginCollapse): (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior): (WebCore::CSSPrimitiveValue::operator EMarqueeDirection): (WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor): (WebCore::CSSPrimitiveValue::operator ENBSPMode): (WebCore::CSSPrimitiveValue::operator EOverflow): (WebCore::CSSPrimitiveValue::operator EPageBreak): (WebCore::CSSPrimitiveValue::operator EPosition): (WebCore::CSSPrimitiveValue::operator EResize): (WebCore::CSSPrimitiveValue::operator ETableLayout): (WebCore::CSSPrimitiveValue::operator ETextAlign): (WebCore::CSSPrimitiveValue::operator ETextSecurity): (WebCore::CSSPrimitiveValue::operator ETextTransform): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): (WebCore::CSSPrimitiveValue::operator EUserDrag): (WebCore::CSSPrimitiveValue::operator EUserModify): (WebCore::CSSPrimitiveValue::operator EUserSelect): (WebCore::CSSPrimitiveValue::operator EVisibility): (WebCore::CSSPrimitiveValue::operator EWhiteSpace): (WebCore::CSSPrimitiveValue::operator EWordBreak): (WebCore::CSSPrimitiveValue::operator EWordWrap): (WebCore::CSSPrimitiveValue::operator LineCap): (WebCore::CSSPrimitiveValue::operator LineJoin): (WebCore::CSSPrimitiveValue::operator TextDirection): (WebCore::CSSPrimitiveValue::operator WindRule): (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline): (WebCore::CSSPrimitiveValue::operator EColorInterpolation): (WebCore::CSSPrimitiveValue::operator EColorRendering): (WebCore::CSSPrimitiveValue::operator EDominantBaseline): (WebCore::CSSPrimitiveValue::operator EImageRendering): (WebCore::CSSPrimitiveValue::operator EPointerEvents): (WebCore::CSSPrimitiveValue::operator EShapeRendering): (WebCore::CSSPrimitiveValue::operator ETextAnchor): (WebCore::CSSPrimitiveValue::operator ETextRendering): (WebCore::CSSPrimitiveValue::operator EWritingMode):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
- ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- 1:01 AM Changeset in webkit [26741] by
-
- 3 edits in trunk/SunSpider
Reviewed by Eric.
- Support Windows and Windows browsers.
- hosted/sunspider-results.html: Display results correctly in IE.
- sunspider: tweaks to work on Windows, and with spaces in the path.
- 12:30 AM Changeset in webkit [26740] by
-
- 6 edits2 adds in trunk
2007-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix crashers in SVGViewSpec::parseViewSpec
http://bugs.webkit.org/show_bug.cgi?id=15504
Test is blocked by bug 15503, landed as:
- svg/dom/viewspec-parser.html-disabled
- bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
- ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
- ksvg2/svg/SVGViewSpec.idl: Added.
- 12:27 AM Changeset in webkit [26739] by
-
- 2 edits in trunk/SunSpider
Rubber stamped by Oliver.
- tests/string-tagcloud.js: Remove stray print()
- 12:17 AM Changeset in webkit [26738] by
-
- 2 edits3 adds in trunk/SunSpider
Reviewed by Oliver.
Add some string test cases.
- tests/string-base64.js: Added. Does base64 encoding and decoding.
- tests/string-tagcloud.js: Added. Parses a JSON string and generates tagcloud HTML markup based on the data.
- tests/string-unpack-code.js: Added. Unpack compressed versions of four of the most popular JavaScript libraries.
- tests/LIST: Added the new tests.
Oct 17, 2007:
- 10:50 PM Changeset in webkit [26737] by
-
- 3 edits in branches/Safari-3-branch/WebKitTools
Merge r26733
- 9:03 PM Changeset in webkit [26736] by
-
- 1 copy in tags/Safari-523.12b
New tag.
- 9:03 PM Changeset in webkit [26735] by
-
- 2 edits in branches/Safari-3-branch/WebKit/win
Bump versions for submit
- 8:56 PM Changeset in webkit [26734] by
-
- 2 edits in trunk/WebKitTools
Make it possible to have Windows-specific tests and results
When searching for tests to run and the Skipped file, we will only
look in platform/win and the cross-platform directory. When looking
for expected results, we will look in platform/win, then
platform/mac-leopard, then platform/mac, then finally the
cross-platform directory.
Reviewed by Sam.
- Scripts/run-webkit-tests: (sub expectedDirectoryForTest): Search in mac-leopard and mac before searching in the cross-platform directory. (sub buildPlatformHierarchy): Removed some unneeded calls to dirname/basename.
- 8:53 PM Changeset in webkit [26733] by
-
- 3 edits in trunk/WebKitTools
Add back the call to register WebKit that we had before WebKitInitializer existed
This is needed to ensure that the right WebKit is used when
instantiating COM objects.
Reviewed by Oliver.
- DumpRenderTree/win/debug_internal.vsprops: Define DEBUG_WEBKIT_HAS_SUFFIX.
- DumpRenderTree/win/DumpRenderTree.cpp: (initialize):
- 8:28 PM Changeset in webkit [26732] by
-
- 4 edits1 add in trunk
WebCore:
Reviewed by Darin, Adam, and Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first
Reset the element id cache when an id is added and there is a duplicate for that id.
- dom/Document.cpp: (WebCore::Document::addElementById):
LayoutTests:
Reviewed by Darin, Adam, and Maciej.
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first
- fast/dom/duplicate-ids-document-order.html: Added.
- 8:20 PM Changeset in webkit [26731] by
-
- 2 edits in branches/Safari-3-branch/WebKitTools
Merge r26730
- 8:17 PM Changeset in webkit [26730] by
-
- 2 edits in trunk/WebKitTools
Import File::Basename in webkitdirs since we use it
Reviewed by NOBODY.
- Scripts/webkitdirs.pm:
- 6:07 PM Changeset in webkit [26729] by
-
- 2 edits in trunk/WebKitTools
- Updated the tiger leaks list to make the internal bots green.
- Scripts/run-webkit-tests:
- 5:18 PM Changeset in webkit [26728] by
-
- 2 edits in branches/Safari-3-branch/WebKitTools
Merge r26727
- 5:15 PM Changeset in webkit [26727] by
-
- 2 edits in trunk/WebKitTools
Build fix for VC++ Express
Reviewed by NOBODY.
- FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib and ole32.lib.
- 5:10 PM Changeset in webkit [26726] by
-
- 2 edits in trunk/WebCore
Fix an ASSERT on launch on Windows
Fix dictated to me by Brady.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncThreadMainLoop): Make sure we hold m_syncLock before going into the loop.
- 4:51 PM Changeset in webkit [26725] by
-
- 2 edits in trunk/WebCore
2007-10-17 Mark Rowe <mrowe@apple.com>
Mac build fix.
- Configurations/WebCore.xcconfig: Make it possible to include CoreGraphics header files.
- 4:39 PM Changeset in webkit [26724] by
-
- 2 edits in trunk/WebKit/win
Fix for clean builds needed after r26683
Reviewed by NOBODY.
- WebView.cpp: Remove #include of non-existant file.
- 4:10 PM Changeset in webkit [26723] by
-
- 3 edits in trunk/WebCore
Windows build fix
Reviewed by NOBODY.
- platform/graphics/AffineTransform.h: Don't #include ApplicationServices.h.
- platform/graphics/cg/GraphicsContextCG.cpp: Add an #include that's needed now that we're not #including ApplicationServices.h.
- 3:57 PM Changeset in webkit [26722] by
-
- 3 edits1 add in trunk/WebCore
2007-10-17 Mark Rowe <mrowe@apple.com>
Gtk build fix. Move non-pthread stubs from Threading.h to ThreadingNone.cpp to prevent
multiple-definition link errors.
- WebCore.pro:
- platform/Threading.h:
- platform/ThreadingNone.cpp: Added. (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::ThreadCondition::ThreadCondition):
- 3:37 PM Changeset in webkit [26721] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by Adele.
Correct uses of initKeyboardEvent for tests that test accesskey.
Accesskey modifier is ctrl for mac and alt for other platforms.
- fast/events/access-key-self-destruct.html:
- fast/forms/access-key.html:
- fast/forms/legend-access-key.html:
- 2:25 PM Changeset in webkit [26720] by
-
- 3 edits3 adds in trunk
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=15543 <rdar://problem/5545639> REGRESSION (r26697): GoogleDocs: Can't create new documents or open existing ones
Test: fast/js/regexp-non-character.html
- pcre/pcre_compile.c: (check_escape): Take out the checks for valid characters in the \u sequences -- not needed and actively harmful.
LayoutTests:
Reviewed by Mark Rowe.
- test for http://bugs.webkit.org/show_bug.cgi?id=15543 <rdar://problem/5545639> REGRESSION (r26697): GoogleDocs: Can't create new documents or open existing ones
- fast/js/regexp-non-character-expected.txt: Added.
- fast/js/regexp-non-character.html: Added.
- fast/js/resources/regexp-non-character.js: Added.
- 2:24 PM Changeset in webkit [26719] by
-
- 6 edits in branches/Safari-2.0-dashboard/WebCore
Fixed merge of r24938 and r24946 by initializing the security policy URL
in the right place. Tests from Aaron Sigel now pass.
<rdar://problem/5471815> [WebKitForDashboard clone] data: URLs can gain access to frames in foreign domains
- khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
- khtml/khtml_part.cpp: (KHTMLPart::begin): (KHTMLPart::URL): (KHTMLPart::setOpener):
- khtml/khtml_part.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::initSecurityPolicyURL):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::securityPolicyURL):
- 2:15 PM Changeset in webkit [26718] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Remove stray change marker.
- 2:13 PM Changeset in webkit [26717] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove stray merge marker.
- 2:05 PM Changeset in webkit [26716] by
-
- 10 edits2 adds in trunk
Reviewed by Oliver.
- wtf/Platform.h: #define USE_PTHREADS on Mac.
WebCore:
Reviewed by Oliver.
- WebCore.xcodeproj/project.pbxproj:
- WebCore.vcproj/WebCore.vcproj:
- config.h: #define USE_PTHREADS on Windows.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::getOrCreatePageURLRecord): Update for mutex changes.
- platform/Threading.h: (WebCore::): (WebCore::ThreadSafeShared::ThreadSafeShared): (WebCore::ThreadSafeShared::ref): (WebCore::ThreadSafeShared::deref): (WebCore::ThreadSafeShared::hasOneRef): (WebCore::ThreadSafeShared::refCount): (WebCore::ThreadSafeShared::isThreadSafe): Add a new Shared base class that uses a mutex to manage its refcount.
(WebCore::createThread):
(WebCore::waitForThreadCompletion):
(WebCore::detachThread):
New functions for thread creation.
(WebCore::Mutex::Mutex):
(WebCore::Mutex::~Mutex):
(WebCore::Mutex::lock):
(WebCore::Mutex::tryLock):
(WebCore::Mutex::unlock):
Move the definitions to ThreadingPthreads.cpp
(WebCore::ThreadCondition::ThreadCondition):
(WebCore::ThreadCondition::~ThreadCondition):
(WebCore::ThreadCondition::wait):
(WebCore::ThreadCondition::signal):
(WebCore::ThreadCondition::broadcast):
Move the definitions to ThreadingPthreads.cpp
- platform/pthreads: Added.
- platform/pthreads/ThreadingPthreads.cpp: Added. Add pthread specific implementation of the thread creation functions, Mutex and ThreadCondition.
win:
Update for locking primitive changes.
- WebIconDatabase.cpp: (WebIconDatabase::scheduleNotificationDelivery):
- 2:01 PM Changeset in webkit [26715] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Merged DeclaredFunctionImp into FunctionImp (the base class) because
the distinction between the two was unused.
Removed codeType() from FunctionImp because FunctionImp and its
subclasses all returned FunctionCode, so it was unused, practically
speaking.
Removed a different codeType() from GlobalFuncImp because it was unused.
(Perhaps it was vestigial from a time when GlobalFuncImp used to
inherit from FunctionImp.)
- bindings/runtime_method.cpp:
- bindings/runtime_method.h:
- kjs/function.cpp: (KJS::): (KJS::FunctionImp::FunctionImp): (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::construct): (KJS::FunctionImp::execute): (KJS::FunctionImp::processVarDecls):
- kjs/function.h: (KJS::FunctionImp::implementsConstruct): (KJS::FunctionImp::scope):
- kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
- kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
- 1:29 PM Changeset in webkit [26714] by
-
- 2 edits1 add in branches/Safari-3-branch/WebKitTools
Merge r26708
- 1:29 PM Changeset in webkit [26713] by
-
- 13 edits6 deletes in branches/Safari-3-branch
Merge r26707
- 1:29 PM Changeset in webkit [26712] by
-
- 4 edits3 adds in branches/Safari-3-branch
Merge r26706
- 1:28 PM Changeset in webkit [26711] by
-
- 18 edits in branches/Safari-3-branch
Merge r26684
- 1:28 PM Changeset in webkit [26710] by
-
- 9 edits in trunk/WebCore
Add support for creating a layer when a transform is in effect. Add support to RenderStyle for
handing back a computed AffineTransform.
Reviewed by Mitz Pettel
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle):
- rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasTransform):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
- rendering/RenderStyle.h: (WebCore::RenderStyle::hasTransform):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
- 1:24 PM Changeset in webkit [26709] by
-
- 2 edits in trunk/WebKit
Reviewed by Mark Rowe.
- fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object. It's safe to do that for functions that return integers or pointers, but not structures.
- 1:12 PM Changeset in webkit [26708] by
-
- 2 edits1 add in trunk/WebKitTools
Add a new nightly launcher script for Windows
This new script is for versions of Safari that don't delay-load
WebKit. I had to make FindSafari be able to print out the nightly
launcher script on stdout because Windows shell scripts can't capture
the output from a command into an environment variable.
Reviewed by Steve.
- FindSafari/FindSafari.cpp: (_tmain): Added /printSafariLauncher option.
- Scripts/run-webkit-nightly.cmd: Added.
- 1:12 PM Changeset in webkit [26707] by
-
- 13 edits6 deletes in trunk
Stop delay-loading WebKit in DRT and teskjs
Make testkjs not delay-load WebKit
Soon, delay-loading WebKit will be impossible (because we will be
using declspec(thread) for thread-local storage). This change
prepares testkjs for the future.
Reviewed by Sam.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Removed WebKitInitializer, added FindSafari.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
- kjs/testkjs.cpp: Don't use WebKitInitializer.
WebKitTools:
Replace WebKitInitializer with FindSafari
We now rely on setting the PATH environment variable to tell Windows
where to find WebKit and its dependencies (similar to
DYLD_FRAMEWORK_PATH on Mac).
This change also make DumpRenderTree no longer delay-load WebKit.
Reviewed by Sam.
- DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added FindSafari.
- DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
- DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
- Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
- Scripts/run-webkit-tests: Ditto.
- Scripts/webkitdirs.pm: (sub setPathForRunningWebKitApp): Added.
- WebKitInitializer/WebKitInitializer.cpp: Removed.
- WebKitInitializer/WebKitInitializer.h: Removed.
- WebKitInitializer/WebKitInitializer.vcproj: Removed.
- WebKitInitializer/debug.vsprops: Removed.
- WebKitInitializer/debug_internal.vsprops: Removed.
- WebKitInitializer/release.vsprops: Removed.
WebKit/win:
Remove WebKitInitializer
Reviewed by Sam.
- WebKit.vcproj/WebKit.sln:
- 1:11 PM Changeset in webkit [26706] by
-
- 4 edits3 adds in trunk
Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
WebKitTools:
Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
FindSafari simply prints the location of an installed Safari.exe on
stdout.
Reviewed by Darin.
- FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp. (getStringValue): (getWebViewCLSID): (getInstalledWebKitDirectory): (_tmain):
- FindSafari/FindSafari.vcproj: Added.
- Scripts/webkitdirs.pm: (sub installedSafariPath): Added. Calls FindSafari on Windows.
WebKit/win:
Add FindSafari
Reviewed by Darin.
- WebKit.vcproj/WebKit.sln:
- 12:47 PM Changeset in webkit [26705] by
-
- 8 edits in trunk/WebCore
Add support for mapping of the transform CSS property into RenderStyles. Everything is now ready for the front
end to use.
Reviewed by Mitz Pettel
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSTransformValue.h: (WebCore::CSSTransformValue::type): (WebCore::CSSTransformValue::values):
- platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::skew):
- platform/graphics/AffineTransform.h:
- rendering/RenderStyle.cpp: (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleTransformData::operator==): (WebCore::StyleTransformData::transformDataEquivalent):
- rendering/RenderStyle.h: (WebCore::TransformOperation::~TransformOperation): (WebCore::TransformOperation::operator!=): (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::ScaleTransformOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::ScaleTransformOperation::operator==): (WebCore::ScaleTransformOperation::apply): (WebCore::RotateTransformOperation::RotateTransformOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::RotateTransformOperation::operator==): (WebCore::RotateTransformOperation::apply): (WebCore::SkewTransformOperation::SkewTransformOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::SkewTransformOperation::operator==): (WebCore::SkewTransformOperation::apply): (WebCore::TranslateTransformOperation::TranslateTransformOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::TranslateTransformOperation::operator==): (WebCore::TranslateTransformOperation::apply): (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::isMatrixOperation): (WebCore::MatrixTransformOperation::operator==): (WebCore::MatrixTransformOperation::apply): (WebCore::StyleTransformData::operator!=): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):
- 12:30 PM Changeset in webkit [26704] by
-
- 6 edits in trunk
Windows build fix part 2.
Windows build fix part 2.
Fix was by Darin, reviewed by Anders and Adam.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add FastMallocPCRE.cpp to the project, and let Visual Studio have its way with the post-build step.
- pcre/pcre.h: Don't DLL export the entry points just because this is Win32 -- this is an internal copy of PCRE and should be private.
- pcre/pcre_compile.c: Fix an uninitialized variable warning -- there's no real problem but it's better to quiet the compiler by tweaking the code slightly than turn off the warning entirely.
WebCore:
- page/Frame.cpp: I had to touch this file when fixing the Windows build. Checking it in in case it helps others, too.
- 11:33 AM Changeset in webkit [26703] by
-
- 2 edits in trunk/WebCore
2007-10-17 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Remove a couple more uses of svg_dynamic_cast.
No functional changes, no tests.
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- 11:05 AM Changeset in webkit [26702] by
-
- 2 edits in trunk/WebCore
2007-10-17 Mark Rowe <mrowe@apple.com>
Reviewed by Eric and Geoff.
<rdar://problem/5453743> Repro ASSERT in CachedResource::setEncodedSize() loading image in background tab
http://bugs.webkit.org/show_bug.cgi?id=15191
- loader/DocLoader.cpp: (WebCore::DocLoader::setAutoLoadImages): Don't start a load if the CachedImage is already loading.
- 10:54 AM Changeset in webkit [26701] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
Reviewed by Anders.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable some mismatched signed/unsigned comparison warnings.
- pcre/pcre_exec.c: (match): #if-out some labels that don't seem to exist.
- 10:51 AM Changeset in webkit [26700] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Harrison.
<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice
Fixed by fixing problems with the selection preservation done by IndentOutdentCommand.
It is now more difficult to create selections that cause hangs. Those are covered by:
<rdar://problem/5543472>
- editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Compute indices from the first VisiblePosition in the document, instead of the first Position. Use rangeCompliantEquivalents when creating the Range that we pass to rangeLength. Tell TextIterator::rangeLength that we're doing selection preservation, so that it will emit characters between all VisiblePositions. (WebCore::IndentOutdentCommand::indentRegion): Fixed a bug where the range and location passed to rangeFromLocationAndLength were reversed. Tell rangeFromLocationAndLength that we're doing doing selection preservation, as above.
- editing/TextIterator.cpp: (WebCore::CharacterIterator::CharacterIterator): (WebCore::TextIterator::rangeLength): Rename emitSpacesForReplacedElements to forSelectionPreservation, to match the name of the boolean inside TextIterator and to match its meaning after r25522. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice
- editing/execCommand/5481523.html: Added.
- platform/mac/editing/execCommand/5481523-expected.checksum: Added.
- platform/mac/editing/execCommand/5481523-expected.png: Added.
- platform/mac/editing/execCommand/5481523-expected.txt: Added.
- 12:45 AM Changeset in webkit [26699] by
-
- 3 edits in trunk/JavaScriptCore
2007-10-17 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- JavaScriptCore.pri: Add FastMallocPCRE.cpp.
- pcre/pcre_get. #if out two functions that depend on pcre_get_stringnumber, which is currently unavailable for UTF-16.
- 12:12 AM Changeset in webkit [26698] by
-
- 4 edits3 adds in trunk/SunSpider
Reviewed by Anders.
- TODO: Updated with info on how to do the stats properly.
- hosted/sunspider-driver.html: Reduce timeout from 500 to 200 to avoid overly slowing down the benchmark.
Added some 3D-related test cases.
- tests/3d-cube.js: Added.
- tests/3d-morph.js: Added.
- tests/3d-raytrace.js: Added.
- tests/LIST:
Oct 16, 2007:
- 10:38 PM Changeset in webkit [26697] by
-
- 22 edits1 move8 deletes in trunk/JavaScriptCore
Reviewed by Geoff.
- merged PCRE changes between 6.4 and 6.5
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Removed pcre_config.c, pcre_globals.c, pcre_info.c, pcre_maketables.c, pcre_printint.src, pcre_refcount.c, pcre_study.c, pcre_try_flipped.c, pcre_ucp_findchar.c, pcre_version.c, and ucptable.c. Added pcre_ucp_searchfuncs.c.
- pcre/AUTHORS:
- pcre/LICENCE:
- pcre/MERGING:
- pcre/dftables.c:
- pcre/pcre-config.h:
- pcre/pcre.h:
- pcre/pcre.pri:
- pcre/pcre_compile.c:
- pcre/pcre_exec.c:
- pcre/pcre_fullinfo.c:
- pcre/pcre_get.c:
- pcre/pcre_internal.h:
- pcre/pcre_maketables.c:
- pcre/pcre_ord2utf8.c:
- pcre/pcre_tables.c:
- pcre/pcre_ucp_searchfuncs.c: Copied from pcre/pcre_ucp_findchar.c.
- pcre/pcre_xclass.c:
- pcre/ucp.h:
- pcre/ucpinternal.h:
- pcre/ucptable.c: Updated with new versions from the PCRE 6.5 release, merged with changes.
- pcre/pcre_config.c: Removed.
- pcre/pcre_globals.c: Removed.
- pcre/pcre_info.c: Removed.
- pcre/pcre_printint.src: Removed.
- pcre/pcre_refcount.c: Removed.
- pcre/pcre_study.c: Removed.
- pcre/pcre_try_flipped.c: Removed.
- pcre/pcre_ucp_findchar.c: Removed.
- pcre/pcre_version.c: Removed.
- 9:51 PM Changeset in webkit [26696] by
-
- 5 edits in trunk/WebCore
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=15536 need to cache missing glyph so we're not slow on pages that show missing glyphs
- <rdar://problem/5404359> UI thread stall (>60sec) in MLANG running stress test (related to font data caching)
- platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): Check for a null value for fontData rather than for glyph to detect non-cached entries in the glyph data.
- platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- platform/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
- platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Set fontData to 0 for missing glyph entries. Also fixed the Windows and GTK versions to return the proper value for haveGlyphs.
- 8:47 PM Changeset in webkit [26695] by
-
- 3 edits in trunk/WebCore
2007-10-16 Mark Rowe <mrowe@apple.com>
Gtk build fix. Replace use of assert with ASSERT_NOT_REACHED.
- platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::platformInit):
- 7:02 PM Changeset in webkit [26694] by
-
- 2 edits in trunk/WebKit
WebCore:
Reviewed by Timothy.
<rdar://problem/5544354> Wrong delegate method called in WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
- 5:57 PM Changeset in webkit [26693] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Sam.
- Minor mac improvements based on observations I made while implementing the Windows code.
- Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server then hand it to the Client who will retain it, it should just be the client who creates and owns the server. (-[DebuggerApplication attach:]):
- Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
- Drosera/mac/DebuggerClient.mm: Creates the server. (-[DebuggerClient initWithServerName:]):
- Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but can instead forward declare what it needs.
- 5:36 PM Changeset in webkit [26692] by
-
- 2 edits in trunk/LayoutTests
removing fixed tests
- platform/win/Skipped:
- 4:52 PM Changeset in webkit [26691] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15534 WebScriptObject.h has some formatting and editorial mistakes
- bindings/objc/WebScriptObject.h: Fix wording and formatting.
- 4:35 PM Changeset in webkit [26690] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Removed KJS_VERBOSE because it was getting in the way of readability,
and the messages didn't seem very helpful.
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters):
- kjs/lookup.h: (KJS::lookupPut):
- kjs/object.cpp: (KJS::JSObject::put):
- kjs/value.h:
- 4:29 PM Changeset in webkit [26689] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Removed the Parameter class because it was a redundant wrapper around
Identifier.
- kjs/function.cpp: (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::getParameterName):
- kjs/nodes.cpp: (FunctionBodyNode::addParam):
- kjs/nodes.h: (KJS::FunctionBodyNode::):
- 4:25 PM Changeset in webkit [26688] by
-
- 34 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Global replace of assert with ASSERT.
- 3:34 PM Changeset in webkit [26687] by
-
- 6 edits in trunk/LayoutTests
Rubber-stamped by Adele.
fixing incorrect usage of JS String search method.
- editing/deleting/delete-by-word-001.html:
- editing/deleting/delete-by-word-002.html:
- fast/forms/input-text-option-delete.html:
- fast/forms/listbox-onchange.html:
- fast/forms/listbox-selection.html:
- 3:02 PM Changeset in webkit [26686] by
-
- 2 edits in trunk/WebCore
- try to fix the Qt build
- config.h: Don't use DisallowCType.h, since it's incompatible with some C++ headers that are used in some Qt-specific source files.
- 2:53 PM Changeset in webkit [26685] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Geoff Garen.
- Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you want to turn failing tests into platform-specific test results. Also did a number of tweaks, including fixing a potential bug where expectedDirectoryForTest would take the type of results into account only some of the time.
- 2:43 PM Changeset in webkit [26684] by
-
- 18 edits in trunk
Rename WebKit_debug.dll to WebKit.dll for the Debug configuration
Updated testkjs for the rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
Reviewed by Kevin McCullough.
- JavaScriptCore.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
- JavaScriptCore.vcproj/debug_internal.vsprops: Ditto.
- JavaScriptCore.vcproj/release.vsprops: Ditto.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Use WebKitDLLConfigSuffix when referring to WebKit.dll, and fixed a typo in the name of icuuc36[_debug].dll.
WebKitTools:
Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
Reviewed by Kevin McCullough.
- DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix when referring to WebKit.dll.
- DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
- DumpRenderTree/win/debug_internal.vsprops: Ditto.
- DumpRenderTree/win/release.vsprops: Ditto.
- Scripts/run-safari: Don't pass /debug to Safari anymore because we never have a _debug suffix on WebKit.dll.
- WebKitInitializer/WebKitInitializer.cpp: (initializeWebKit): Only use the _debug suffix for WebKit.dll when specified.
- WebKitInitializer/debug_internal.vsprops: Added DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
WebKit/win:
Rename WebKit_debug.dll to WebKit.dll for the Debug configuration
This is needed so that we can stop having Safari delay-load WebKit,
which in turn is needed so that Maciej can land a JavaScript speedup
which breaks delay-loading.
Reviewed by Kevin McCullough.
- WebKit.vcproj/WebKit.vcproj: Use WebKitDLLConfigSuffix for the name of our DLL and module definition file.
- WebKit.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
- WebKit.vcproj/debug_internal.vsprops: Ditto.
- WebKit.vcproj/release.vsprops: Ditto.
- 2:40 PM Changeset in webkit [26683] by
-
- 13 edits2 deletes in trunk
WebCore:
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=15525 transpose (control-T) should do the last two characters on a line if at end of line
- remove unused CommandByName class
- move transpose command implementation here from Mac OS X WebKit
- editing/Editor.h:
- editing/Editor.cpp: (WebCore::execTranspose): Added. (WebCore::Editor::transpose): Added. This has the transpose implementation from WebCoreFrameBridge and WebHTMLView, translated into WebCore-style C++ and with a special case for the end of a paragraph.
- page/Frame.h: Removed unused command() function member.
- page/FramePrivate.h: Removed unused m_command data member.
- page/Frame.cpp: Ditto.
- page/mac/WebCoreFrameBridge.h: Removed rangeOfCharactersAroundCaret method.
- page/mac/WebCoreFrameBridge.mm: Ditto.
- WebCore.pro: Removed CommandByName.h/cpp.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- editing/CommandByName.cpp: Removed.
- editing/CommandByName.h: Removed.
WebKit:
Reviewed by Adele.
- moved transpose command implementation into WebCore
- WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
- 2:35 PM Changeset in webkit [26682] by
-
- 8 edits4 adds in trunk
Reviewed by Maciej Stachowiak.
Re-structured variable and function declaration code.
Command-line JS iBench shows no regression.
Here are the changes:
- Function declarations are now processed at the same time as var declarations -- namely, immediately upon entry to an execution context. This does not match Firefox, which waits to process a function declaration until the declaration's containing block executes, but it does match IE and the ECMA spec. (10.1.3 states that var and function declarations should be processed at the same time -- namely, "On entering an execution context." 12.2 states that "A Block does not define a new execution scope.")
- Declaration processing proceeds iteratively now, rather than recursively, storing the nodes is finds in stacks. This will later facilitate an optimization to hold on to the gathered declaration nodes, rather than re-fetching them in every function call. [ http://bugs.webkit.org/show_bug.cgi?id=14868 ]
Modified these tests because they expected the incorrect Mozilla
behavior described above:
- tests/mozilla/ecma_3/Function/scope-001.js:
- tests/mozilla/js1_5/Scope/regress-184107.js:
LayoutTests:
Reviewed by Maciej Stachowiak.
Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15478
Declare vars and functions iteratively upon entering an execution context
- fast/js/function-declarations-expected.txt: Added.
- fast/js/function-declarations.html: Added.
- fast/js/var-declarations-expected.txt: Added.
- fast/js/var-declarations.html: Added.
- 2:18 PM Changeset in webkit [26681] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adele.
Fix <rdar://5134108> "fast/forms/select-accesskey.html and focus-selection-input.html fail on Windows"
Adding code to choose the right accesskey modifier based on a useragent check for existance of mac platform.
- fast/forms/focus-selection-input.html:
- fast/forms/select-accesskey.html:
- 1:53 PM Changeset in webkit [26680] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the GTK build
- kjs/ustring.cpp: Include ASCIICType.h, not ASCIICtype.h.
- 1:44 PM Changeset in webkit [26679] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the Windows build
- kjs/date_object.cpp: (KJS::parseDate): A couple instances of isspace were in here. Not sure why it wasn't failing elsewhere. Changed to isASCIISpace.
- 1:34 PM Changeset in webkit [26678] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the GTK build
- kjs/ustring.cpp: Include ASCIICType.h.
- 1:28 PM Changeset in webkit [26677] by
-
- 9 edits in trunk
WebKitTools:
Reviewed by Adele.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Remove now-unneeded control/alt key hack; the tests have been updated.
LayoutTests:
Reviewed by Adele.
- http://bugs.webkit.org/show_bug.cgi?id=15533 some tests have hard-coded Mac-specific modifier keys
- <rdar://problem/5102974> Layout tests fail on Windows because they have hard-coded Mac-specific modifier keys
- <rdar://problem/5075449> fast/forms/listbox-onchange.html is failing on Windows due to modifier key differences
- <rdar://problem/5134134> test 12 in fast/forms/listbox-selection.html fails on Windows
- editing/deleting/delete-by-word-001.html: Use control key instead of alt key to delete a word on non-Mac platforms. Also use character 8 instead of 127.
- editing/deleting/delete-by-word-002.html: Ditto.
- fast/forms/input-text-option-delete.html: Ditto.
- fast/forms/listbox-onchange.html: Use control key instead of meta key to toggle a single list item on non-Mac platforms.
- fast/forms/listbox-selection.html: Ditto.
- 1:13 PM Changeset in webkit [26676] by
-
- 31 edits6 adds in trunk
Reviewed by Maciej and Geoff (and looked over by Eric).
- http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII
- wtf/ASCIICType.h: Added.
- wtf/DisallowCType.h: Added.
- kjs/config.h: Include DisallowCType.h.
- kjs/date_object.cpp: (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate):
- kjs/function.cpp: (KJS::decode):
- kjs/ustring.cpp: (KJS::UString::toDouble): Use ASCIICType.h functions instead of ctype.h ones.
WebCore:
Reviewed by Maciej and Geoff (and looked over by Eric).
- http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII
- ForwardingHeaders/wtf/ASCIICType.h: Added.
- ForwardingHeaders/wtf/DisallowCType.h: Added.
- WebCorePrefix.h: Get rid of inclusion of <ctype.h>.
- config.h: Include DisallowCType.h.
- css/CSSParser.cpp: (WebCore::ParseString::lower):
- css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier):
- css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
- html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
- html/HTMLTokenizer.cpp: (WebCore::tagMatch):
- loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
- platform/DeprecatedCString.cpp: (WebCore::DeprecatedCString::lower): (WebCore::DeprecatedCString::upper): (WebCore::DeprecatedCString::find): (WebCore::DeprecatedCString::contains):
- platform/DeprecatedString.cpp: (WebCore::equalCaseInsensitive): (WebCore::isCharacterAllowedInBase): (WebCore::DeprecatedString::find): (WebCore::DeprecatedString::contains): (WebCore::toIntegralType):
- platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
- platform/KURL.cpp: (WebCore::KURL::parse):
- platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::containsOnlyWhitespace): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::find): (WebCore::StringImpl::reverseFind): (WebCore::equalIgnoringCase):
- platform/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): (WebCore::TextEncodingNameHash::hash): (WebCore::atomicCanonicalTextEncodingName):
- platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
- platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
- platform/win/PopupMenuWin.cpp: (WebCore::isASCIIPrintable): (WebCore::PopupWndProc):
- plugins/win/PluginViewWin.cpp: (WebCore::capitalizeRFC822HeaderFieldName):
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Use ASCIICType.h functions instead of ctype.h ones.
WebKit:
Reviewed by Maciej and Geoff (and looked over by Eric).
- http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII
- ForwardingHeaders/wtf/ASCIICType.h: Added.
- ForwardingHeaders/wtf/DisallowCType.h: Added.
- WebKitPrefix.h: Include DisallowCType.h.
- Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
- WebView/WebHTMLView.mm: (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper. (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes, instead of using ispunct.
- 1:05 PM Changeset in webkit [26675] by
-
- 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp
Fix build bustage caused by merge with changes to CSSStyleSelector.cpp
- 1:04 PM Changeset in webkit [26674] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15296 REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.
Test: fast/block/float/marquee-shrink-to-avoid-floats.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats): Changed to return 'true' for <marquee>s with auto width.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15296 REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.
- fast/block/float/marquee-shrink-to-avoid-floats.html: Added.
- platform/mac/fast/block: Added.
- platform/mac/fast/block/float: Added.
- platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.checksum: Added.
- platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.png: Added.
- platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: Added.
- 12:51 PM Changeset in webkit [26673] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
Amazon seller page way too small
The font size at Amazon was way too small because the calls to
getComputedStyle and getPropertyValue did not cause the div to
attach because there was a pending stylesheet. The fix is to call
updateLayoutIgnorePendingStylesheets() instead of just
updateLayout().
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Reviewed by Darin.
Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
Amazon seller page way too small
- fast/css/pendingStylesheetFontSize.html: Added.
- platform/mac/fast/css/pendingStylesheetFontSize-expected.checksum: Added.
- platform/mac/fast/css/pendingStylesheetFontSize-expected.png: Added.
- platform/mac/fast/css/pendingStylesheetFontSize-expected.txt: Added.
- 12:48 PM Changeset in webkit [26672] by
-
- 2 edits in branches/Safari-3-branch/WebKit/win
Merged fix from r26667.
- 12:48 PM Changeset in webkit [26671] by
-
- 2 edits in trunk/WebKitTools
- Updated leaks list because our internal bot upgraded it's version of leopard and one of the leaks was fixed between that revision and the bot's previous version of leopard.
- Scripts/run-webkit-tests:
- 12:46 PM Changeset in webkit [26670] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26664.
- 12:46 PM Changeset in webkit [26669] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26662.
- 12:45 PM Changeset in webkit [26668] by
-
- 9 edits2 adds1 delete in trunk/WebKitTools
Reviewed by Tim.
- I encapsulated out the server connecton functionality because it is a specific part of Drosera that will be platform dependant until the WebScriptDebugServer can be moved into WebCore and C++. But if it is encapsulated out it can be easily replaced on Windows. So the majority of this patch is moving preexisting functionality.
- Also I removed the prefix header and changed to use config.h because it is more standard on how we use config.h in windows and it didn't make much sense to keep the prefix header and the config.h
- Drosera/DebuggerDocument.cpp: (DebuggerDocument::DebuggerDocument):
- Drosera/DebuggerDocument.h:
- Drosera/config.h:
- Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
- Drosera/mac/DebuggerClient.h:
- Drosera/mac/DebuggerClient.mm: (-[DebuggerClient initWithServerConnection:]): (-[DebuggerClient dealloc]): (-[DebuggerClient windowDidLoad]): (-[DebuggerClient windowWillClose:]): (-[DebuggerClient webView:didFinishLoadForFrame:]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
- Drosera/mac/DebuggerDocumentPlatform.mm: (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
- Drosera/mac/Drosera.pch: Removed.
- Drosera/mac/Drosera.xcodeproj/project.pbxproj:
- Drosera/mac/ServerConnection.h: Added.
- Drosera/mac/ServerConnection.mm: Added. (-[ServerConnection initWithServerName:]): (-[ServerConnection dealloc]): (-[ServerConnection setGlobalContext:]): (-[ServerConnection pause]): (-[ServerConnection resume]): (-[ServerConnection stepInto]): (-[ServerConnection switchToServerNamed:]): (-[ServerConnection applicationTerminating:]): (-[ServerConnection serverConnectionDidDie:]): (-[ServerConnection webView:didLoadMainResourceForDataSource:]): (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]): (-[ServerConnection currentFrame]): (-[ServerConnection webScriptAttributeKeysForScriptObject:]): (-[ServerConnection knownServers]):
- 12:36 PM Changeset in webkit [26667] by
-
- 2 edits in trunk/WebKit/win
2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
<rdar://5530789>: REGRESSION(303-310A19): Crash opening .wma files with
MediaPlayer for the first time
Failure to setup the stream in PluginView::didReceiveResponse will lead,
in a full-page plugin, to the main document load being cancelled. This
is the case with at least two versions of Windows Media Player, which
cancels the stream and brings up its own "Welcome to Windows Media
Player" dialog.
As part of the main document load cancellation, m_pluginView is set to
null, and the crash came from dereferencing this pointer. This patch
adds a null check.
- WebFrame.cpp: (WebFrame::finishedLoading): Fix some typos (WebFrame::committedLoad): Added a null check
- 12:06 PM Changeset in webkit [26666] by
-
- 4 edits in trunk/WebCore
Get transform-origin(x/y) mapped into the front end RenderStyle. Adds a new StyleTransformData struct that
holds transform-origin (and that will also eventually hold the parsed transform operations as well).
Reviewed by Beth
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderStyle.cpp: (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleTransformData::operator==): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
- rendering/RenderStyle.h: (WebCore::StyleTransformData::operator!=): (WebCore::RenderStyle::transformOriginX): (WebCore::RenderStyle::transformOriginY): (WebCore::RenderStyle::setTransformOriginX): (WebCore::RenderStyle::setTransformOriginY): (WebCore::RenderStyle::initialTransformOriginX): (WebCore::RenderStyle::initialTransformOriginY):
- 11:30 AM Changeset in webkit [26665] by
-
- 4 edits in trunk
WebCore:
Reviewed by Alice.
Fix for <rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): When switching between types of select elements, call setRecalcListItems since recalcListItems updates the default selection in different ways for the different controls.
LayoutTests:
Reviewed by Alice.
Updating with correct results for:
<rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
- 11:22 AM Changeset in webkit [26664] by
-
- 2 edits in trunk/WebCore
rubber-stamped by Darin.
flipping my previous fix around so that mac is special-cased instead of win.
- dom/Document.cpp: (WebCore::Document::defaultEventHandler):
- 11:21 AM Changeset in webkit [26663] by
-
- 3 edits in trunk/WebCore
Clean up transform parsing. Fix a crash, ditch the extra parse context class, and use RefPtr/PassRefPtr more
to simplify the code.
Reviewed by aroben
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseTransform):
- css/CSSParser.h:
- 10:57 AM Changeset in webkit [26662] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
fixed <rdar://5085596> Accesskeys don't work
- dom/Document.cpp: (WebCore::Document::defaultEventHandler): accesskey modifier is platform-depedent.
- 9:55 AM Changeset in webkit [26661] by
-
- 4 edits in trunk/WebKit
Reviewed by Adam Roben
Cleaned up localizable strings
- English.lproj/Localizable.strings: updated
- StringsNotToBeLocalized.txt: updated
- WebKit.xcodeproj/project.pbxproj: StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
- 9:00 AM Changeset in webkit [26660] by
-
- 1 copy in tags/WebCore-419.2.5-dashboard/WebCore
New tag (part 2).
- 8:59 AM Changeset in webkit [26659] by
-
- 1 add in tags/WebCore-419.2.5-dashboard
New tag (part 1).
- 8:57 AM Changeset in webkit [26658] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
Versioning
- 8:57 AM Changeset in webkit [26657] by
-
- 3 edits in branches/Safari-2.0-dashboard/WebCore
2007-10-16 Mark Rowe <mrowe@apple.com>
Reinstate equalIgnoringCase that was added as part of r25691 but subsequently rolled out.
Other merged changes depend on it existing.
- 4:19 AM Changeset in webkit [26656] by
-
- 1 edit in trunk/WebKit/ChangeLog-2007-10-14
Removed conflict markers.
- 12:34 AM Changeset in webkit [26655] by
-
- 3 edits in branches/Safari-3-branch/WebCore
Merged fix from r26651.
- 12:04 AM Changeset in webkit [26654] by
-
- 2 edits1 move2 deletes in trunk/LayoutTests
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15506
editing/pasteboard/paste-into-anchor-text.html accesses an external resource
Removed the external resource reference and made the test dump as text.
- editing/pasteboard/paste-into-anchor-text-expected.txt: Copied from platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt.
- editing/pasteboard/paste-into-anchor-text.html:
- platform/mac/editing/pasteboard/paste-into-anchor-text-expected.checksum: Removed.
- platform/mac/editing/pasteboard/paste-into-anchor-text-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt: Removed.
Oct 15, 2007:
- 10:53 PM Changeset in webkit [26653] by
-
- 1 edit1 add in trunk/WebKitTools
WebKitTools:
Reviewed by Eric.
- fix http://bugs.webkit.org/show_bug.cgi?id=15002 Script to automatically search nightly builds for regressions (bisect-builds)
- Scripts/bisect-builds: Added.
- 10:17 PM Changeset in webkit [26652] by
-
- 2 edits in trunk/WebCore
2007-10-15 Mark Rowe <mrowe@apple.com>
Reviewed by John.
<rdar://problem/5494040> Reproducible assertion failure in WebCore::IconDatabase::iconForPageURL
A race condition between icon database import and Safari asking for an icon for the empty URL
was resulting in a PageURLRecord being created for a URL that can never be retained. By enforcing
that PageURLRecord's cannot be created for the empty URL we can prevent the assertion from failing.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::getOrCreatePageURLRecord): Bail out early if the URL is empty. (WebCore::IconDatabase::performURLImport): Don't create the PageURLRecord if the URL is empty.
- 9:51 PM Changeset in webkit [26651] by
-
- 3 edits in trunk/WebCore
2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
Use OwnPtr for m_deliveryData, and fix a bug where we were memmove()ing
over m_deliveryData instead of its data buffer
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): Don't delete m_deliveryData (WebCore::PluginStreamWin::deliverData): Fix memmove() call (WebCore::PluginStreamWin::didReceiveData): Assign using OwnPtr::set()
- plugins/win/PluginStreamWin.h: Use OwnPtr
- 9:14 PM Changeset in webkit [26650] by
-
- 4 edits in branches/Safari-3-branch
Versioning.
- 9:11 PM Changeset in webkit [26649] by
-
- 1 copy in tags/Safari-4523.12
New tag.
- 8:42 PM Changeset in webkit [26648] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26646.
- 8:39 PM Changeset in webkit [26647] by
-
- 2 edits in branches/Safari-3-branch/WebKit
Merge r26645.
- 8:39 PM Changeset in webkit [26646] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Add missing null check.
- platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
- 8:30 PM Changeset in webkit [26645] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin Adler.
Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
- WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will load during first layout and not attach time. For this plug-in, loading at first layout is expected and is consistent with Safari 2 behavior.
- 7:34 PM Changeset in webkit [26644] by
-
- 3 edits in trunk/WebCore
2007-10-15 Mark Rowe <mrowe@apple.com>
Fix the no-SVG build again. Add new transform CSS properties to the switch statements.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 6:53 PM Changeset in webkit [26643] by
-
- 1 copy in tags/WebCore-419.2.3-dashboard/WebCore
New tag (part 2).
- 6:53 PM Changeset in webkit [26642] by
-
- 1 add in tags/WebCore-419.2.3-dashboard
New tag (part 1).
- 6:51 PM Changeset in webkit [26641] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
Versioning.
- 6:49 PM Changeset in webkit [26640] by
-
- 8 edits in branches/Safari-2.0-dashboard/WebCore
2007-10-15 Mark Rowe <mrowe@apple.com>
- 6:30 PM Changeset in webkit [26639] by
-
- 3 edits21 adds in trunk
Reviewed by Darin.
- fixes for "New JavaScript benchmark" http://bugs.webkit.org/show_bug.cgi?id=15515
- kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): Implement "load" for compatibility with SpiderMonkey. (TestFunctionImp::): ditto (doIt): ditto (kjsmain): Drop useless --> from output.
SunSpider:
Reviewed by Darin.
- New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515
A start on a new JavaScript benchmark, with standalone and
browser-hosted drivers.
The test content is still incomplete and the drivers could use
some more features but there is enough here to make a good start.
The drivers compute a 95% confidence interval on the mean for the
whole test, each category, and each individual test to make it
easier to tell whether differences are statistically
significant. The confidence interval can be narrowed by running
the test more times.
- TODO: Added. Remaining things that need to be done.
- sunspider: Added. Perl script that acts as the standalone test driver.
- resources/sunspider-standalone-driver.js: Added. JavaScript part of standalone test driver.
- resources/sunspider-analyze-results.js: Added. JavaScript statistical analysis code.
- resources/TEMPLATE.html: Added. Template for browser-hosted tests.
- make-hosted: Added. Script to generate browser-hosted tests.
- hosted/sunspider.html: Added. Start page for browser-hosted test.
- hosted/sunspider-driver.html: Added. Driver for browser-hosted tests.
- hosted/sunspider-results.html: Added. Results page for browser-hosted tests.
- hosted/sunspider-record-result.js: Added. Helper file for browser-hosted tests.
- tests/LIST: Added. List of tests to use.
- tests/bitops-3bit-bits-in-byte.js: Added. Some initial test content.
- tests/bitops-bits-in-byte.js: Added. Ditto.
- tests/bitops-bitwise-and.js: Added. Ditto.
- tests/math-cordic.js: Added. Ditto.
WebKitTools:
Reviewed by Darin.
- New JavaScript benchmark http://bugs.webkit.org/show_bug.cgi?id=15515
- Scripts/run-sunspider: Added. Wrapper to run sunspider on the current development or release build of JavaScriptCore.
- 4:54 PM Changeset in webkit [26638] by
-
- 4 edits in trunk/WebCore
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15518 Remove the unused attemptFontSubstitution feature and do some cleanup of glyphDataForCharacter.
- platform/Font.h:
- platform/Font.cpp: (WebCore::WidthIterator::advance): Eliminated uneeded attemptFontSubstitution and cluster parameters to the glyphDataForCharacter function. (WebCore::Font::glyphDataForCharacter): Removed the cluster parameter and attemptFontSubstitution parameter. Removed the isUpper check before calling toUpper in the small caps code path. Split up the inner loop into separate copies for non-small-caps and small caps. Broke out the system fallback page handling so it's not inside the loop. Changed system fallback so it uses the character and breaks it up into UTF-16 as needed, instead of using a passed-in "character cluster".
- platform/TextStyle.h: (WebCore::TextStyle::TextStyle): Removed attemptFontSubstitution. (WebCore::TextStyle::applyWordRounding): Ditto.
- 4:52 PM Changeset in webkit [26637] by
-
- 6 edits in trunk/LayoutTests
Fixed layout test for reals. Changed \r\n to \n, fixing mass confusion.
- fast/js/do-while-expression-value-expected.txt:
- fast/js/do-while-expression-value.html:
- fast/js/nested-function-scope.html:
- fast/js/while-expression-value-expected.txt:
- fast/js/while-expression-value.html:
- 4:18 PM Changeset in webkit [26636] by
-
- 2 edits in trunk/WebCore
2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
Remove an operator precedence warning on Windows
- editing/markup.cpp: (WebCore::escapeContentText): Use (a) | (b) (WebCore::appendEscapedContent): Use (a) | (b)
- 3:59 PM Changeset in webkit [26635] by
-
- 5 edits in trunk
WebCore:
Reviewed by Darin.
- <rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
- Now we take the doc into account when resizing.
- Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.
- bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): (KJS::WindowFunc::callAsFunction):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5238818> window.resizeTo doesn't restrict the resized window to the size of the screen
- Now we take the dock into account when resizing.
- Also I found an issue where we would resize to outside the window, because the resize would be smaller than the window size but the location of the window would make the resize go off-screen. Now we move the window back into the screen.
- fast/dom/Window/window-resize-expected.txt:
- fast/dom/Window/window-resize.html:
- 3:36 PM Changeset in webkit [26634] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26632.
- 3:34 PM Changeset in webkit [26633] by
-
- 2 edits in trunk/WebKitTools
2007-10-15 Mark Rowe <mrowe@apple.com>
Reviewed by Sam.
Fix 'run-webkit-tests --qt' complaining about the --qt argument.
- Scripts/webkitdirs.pm:
- Change checkArgv to remove the options from @ARGV to prevent them from interfering with further option processing.
- Fix logic error in determineIsQt that would prevent it from bailing out early.
- Change isOSX to mean OS X and not Qt or Gtk. Most of our uses of isOSX assume that this is the meaning already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
- 3:27 PM Changeset in webkit [26632] by
-
- 2 edits in trunk/WebCore
2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://5510700> Repro crash loading embedded Windows Media Player
content
Anders noticed that the older Windows Media Player plugin (npdsplay.dll)
will crash if it receives its resource requests out of order, whereas we
were immediately fulfilling untargeted, non-JavaScript requests and
scheduling targeted or JavaScript resource requests. Implement his
suggested fix, which is to schedule PluginRequests for all resource
requests
- plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): If this non-JavaScript request has no target, create a stream for it (WebCore::PluginViewWin::load): Schedule PluginRequests for all resource requests
- 3:12 PM Changeset in webkit [26631] by
-
- 2 edits in trunk/WebCore
2007-10-15 Mark Rowe <mrowe@apple.com>
Gtk and Qt build fix. Add new .cpp file to project.
- WebCore.pro:
- 2:59 PM Changeset in webkit [26630] by
-
- 2 edits in trunk/WebCore
- platform/mac/FontDataMac.mm: D'oh! Added missing #import to fix build
- 2:42 PM Changeset in webkit [26629] by
-
- 4 edits in trunk/WebKit
Reviewed by Geoff Garen
Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
I made the following changes:
- replaced NS_DURING with @try, and added opening brace if there wasn't one
- replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
- removed NS_ENDHANDLER, and added a closing brace if there wasn't one
- in a couple of places, fixed indentation therein
- Misc/WebIconDatabase.mm: (objectFromPathForKey):
- WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView deleteToMark:]):
- WebView/WebView.mm: (-[WebView initWithCoder:]):
- 2:41 PM Changeset in webkit [26628] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff
- platform/mac/FontDataMac.mm: (WebCore::FontData::smallCapsFontData): replace NS_DURING/NS_HANDLER with WebCore-style BEGIN/END_BLOCK_OBJC_EXCEPTIONS
- 2:25 PM Changeset in webkit [26627] by
-
- 2 edits in trunk/LayoutTests
Changed line ending style of results file to fix layout test that was
failing locally on my machine.
- fast/js/nested-function-scope-expected.txt:
- 2:15 PM Changeset in webkit [26626] by
-
- 7 edits2 adds in trunk/WebCore
The CSS WG has been discussing the concept of rotation. In the latest draft specification, two properties
have been introduced: rotation and rotation-point. I believe these properties should be generalized to
allow for arbitrary transformations (e.g., translation, skew, rotate, scale).
This patch adds support for the back-end parsing of two new CSS properties: transform and transform-origin.
They are directly analogous to the properties specified by the CSS WG, except that they are designed to allow
for arbitrary affine transforms rather than just rotation.
Reviewed by Beth Dakin
- WebCore.xcodeproj/project.pbxproj:
- WebCore.vcproj/WebCore.vcproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::TransformParseContext:::m_list): (WebCore::TransformParseContext::list): (WebCore::TransformParseContext::failed): (WebCore::TransformParseContext::addValue): (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::TransformOperationInfo::type): (WebCore::TransformOperationInfo::argCount): (WebCore::TransformOperationInfo::unit): (WebCore::TransformOperationInfo::unknown): (WebCore::TransformOperationInfo::hasCorrectArgCount): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSTransformValue.cpp: Added. (WebCore::CSSTransformValue::CSSTransformValue): (WebCore::CSSTransformValue::~CSSTransformValue): (WebCore::CSSTransformValue::addValue): (WebCore::CSSTransformValue::cssText):
- css/CSSTransformValue.h: Added. (WebCore::CSSTransformValue::):
- 1:58 PM Changeset in webkit [26625] by
-
- 2 edits in trunk/JavaScriptCore
Removed unnecessary #include.
- API/JSObjectRef.cpp:
- 1:57 PM Changeset in webkit [26624] by
-
- 2 edits in trunk/JavaScriptCore
Double-reverse build fix. My tree was out of date.
- kjs/nodes.cpp: (NumberNode::evaluate):
- 1:53 PM Changeset in webkit [26623] by
-
- 3 edits in trunk/WebCore
2007-10-15 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
Fix the no-SVG build.
- DerivedSources.make: Use the correct file as input to generate CSSPropertyNames.h.
- rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary):
- 1:47 PM Changeset in webkit [26622] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- kjs/nodes.cpp: (NumberNode::evaluate):
- 1:44 PM Changeset in webkit [26621] by
-
- 5 edits2 adds in trunk
Reviewed by Darin Adler.
Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.
There were a few reasons to remove this "hack:"
- It contradicted FF, IE, and the ECMA spec.
- It incurred a performance penalty, since merely parsing a function required parsing its body for nested functions (and so on).
- SVN history contains no explanation for why it was added. It was just legacy code in a large merge a long, long time ago.
[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
- kjs/nodes.cpp: (FuncDeclNode::processFuncDecl):
LayoutTests:
Reviewed by Darin Adler.
Removed surprising self-named "hack" that made nested functions
available as named properties of their containing functions, and placed
containing function objects in the scope chains of nested functions.
[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
Changed this test to reflect correct behavior:
- fast/js/kde/function-expected.txt:
- fast/js/kde/resources/function.js: (Also removed tab characters.)
Added this test to flesh out the behavior more:
- fast/js/nested-function-scope-expected.txt: Added.
- fast/js/nested-function-scope.html: Added.
- 1:41 PM Changeset in webkit [26620] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Removed the concept of AnonymousCode. It was unused, and it doesn't
exist in the ECMA spec.
[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
- kjs/Context.cpp: (KJS::Context::Context):
- kjs/function.h: (KJS::):
- kjs/nodes.cpp: (ReturnNode::execute):
- 1:40 PM Changeset in webkit [26619] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
Made function parameters DontDelete. This matches FF and the vague
description in ECMA 10.1.3. It's also required in order to make
symbol table based lookup of function parameters valid. (If the
parameters aren't DontDelete, you can't guarantee that you'll find
them later in the symbol table.)
[ Patch broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
- kjs/function.cpp: (KJS::FunctionImp::passInParameters):
LayoutTests:
Committed revision 26618.
Made function parameters DontDelete.
- fast/js/delete-function-parameter-expected.txt: Added.
- fast/js/delete-function-parameter.html: Added.
- 1:39 PM Changeset in webkit [26618] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Some Vector optimizations. These are especially important when using
Vector as a stack for implementing recursive algorithms iteratively.
[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
- Added shrink(), which is a version of resize() that you can call to save a branch / improve code generation and inlining when you know that the vector is not getting bigger.
- Changed subclassing relationship in VectorBuffer to remove a call to fastFree() in the destructor for the inlineCapacity != 0 template specialization. This brings inline Vectors one step closer to true stack-allocated arrays.
Also changed abort() to CRASH(), since the latter works better.
- wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::VectorBufferBase::deallocateBuffer): (WTF::VectorBufferBase::VectorBufferBase): (WTF::VectorBufferBase::~VectorBufferBase): (WTF::): (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::~VectorBuffer): (WTF::VectorBuffer::deallocateBuffer): (WTF::VectorBuffer::releaseBuffer): (WTF::Vector::clear): (WTF::Vector::removeLast): (WTF::::operator): (WTF::::fill): (WTF::::shrink):
- 1:36 PM Changeset in webkit [26617] by
-
- 4 edits4 adds in trunk
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547).
[ Broken off from http://bugs.webkit.org/show_bug.cgi?id=14868 ]
This patch is a merge of KDE r670547, with substantial modification
for performance.
It fixes do-while statements to evaluate to a value. (They used
to evaluate to the empty value in all cases.)
It also fixes SourceElementsNode to maintain the value of abnormal
completions like "break" and "continue."
It also re-works the main execution loop in SourceElementsNode so that
it (1) makes a little more sense and (2) avoids unnecessary work. This
is a .28% speedup on command-line JS iBench.
- kjs/nodes.cpp: (DoWhileNode::execute): (SourceElementsNode::execute):
LayoutTests:
Reviewed by Maciej Stachowiak.
Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15490
Iteration statements sometimes incorrectly evaluate to the empty value
(KDE r670547)
- fast/js/do-while-expression-value-expected.txt: Added.
- fast/js/do-while-expression-value.html: Added.
- fast/js/while-expression-value-expected.txt: Added.
- fast/js/while-expression-value.html: Added.
- 12:02 PM Changeset in webkit [26616] by
-
- 5 edits in trunk
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert
Test: fast/dom/Window/alert-undefined.html
- page/DOMWindow.idl: Remove ConvertUndefinedOrNullToNullString from alert, confirm, and prompt. It turns out that the default behavior is what the other browsers do (browsers tested: IE 7, Firefox 2).
LayoutTests:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15520 alert(undefined) should say "undefined" in the alert
- fast/dom/Window/alert-undefined.html: Added tests of null and both confirm and prompt.
- fast/dom/Window/alert-undefined-expected.txt: Updated.
- 11:47 AM Changeset in webkit [26615] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Sam.
- added logging of window.prompt and window.confirm
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Implement the recommended delegate rather than the deprecated one. (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Added. (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Added.
- DumpRenderTree/win/UIDelegate.h:
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string. (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added. (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added. (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
- 11:39 AM Changeset in webkit [26614] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): If the scrollbar is disabled, make sure the scroll offset gets reset to 0. In general, we don't want to unnecessarily adjust the scroll offset, but in this case, there won't be an obvious way for the user to adjust the scroller position once it's disabled.
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=15252
<rdar://problem/5498184> REGRESSION: <select multiple> doesn't scroll to top when old options are removed and new ones are added, leaving listbox empty-looking
- fast/forms/listbox-scroll-after-options-removed-expected.txt: Added.
- fast/forms/listbox-scroll-after-options-removed.html: Added.
- 11:17 AM Changeset in webkit [26613] by
-
- 1 edit in branches/Safari-3-branch/WebCore/ChangeLog
Merged fix from r26610.
- 11:16 AM Changeset in webkit [26612] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26608.
- 11:15 AM Changeset in webkit [26611] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merged fix from r26607.
- 11:01 AM Changeset in webkit [26610] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing a date in the ChangeLog
- 10:25 AM Changeset in webkit [26609] by
-
- 10 edits4 adds in trunk
WebKitTools:
Reviewed by Sam Weinig.
Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Like on mac, before running each test, set the webview's policy delegate to null (main): allocate the global policy delegate for DRT's custom use
- DumpRenderTree/win/DumpRenderTree.vcproj: Adding files to project
- DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): set the webview's policy delegate to DRT's custom one if the test requests it.
- DumpRenderTree/win/PolicyDelegate.cpp: Added. Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm (PolicyDelegate::PolicyDelegate): (PolicyDelegate::QueryInterface): (PolicyDelegate::AddRef): (PolicyDelegate::Release): (PolicyDelegate::decidePolicyForNavigationAction):
- DumpRenderTree/win/PolicyDelegate.h: Added. (PolicyDelegate::decidePolicyForNewWindowAction): (PolicyDelegate::decidePolicyForMIMEType): (PolicyDelegate::unableToImplementPolicyWithError):
win:
Reviewed by Sam Weinig.
Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
- DefaultPolicyDelegate.cpp: Added. Implementation is a direct port of WebKit/DefaultDelegates/WebDefaultPolicyDelegate.m (DefaultPolicyDelegate::DefaultPolicyDelegate): (DefaultPolicyDelegate::~DefaultPolicyDelegate): (DefaultPolicyDelegate::sharedInstance): (DefaultPolicyDelegate::createInstance): (DefaultPolicyDelegate::QueryInterface): (DefaultPolicyDelegate::AddRef): (DefaultPolicyDelegate::Release): (DefaultPolicyDelegate::decidePolicyForNavigationAction): (DefaultPolicyDelegate::decidePolicyForNewWindowAction): (DefaultPolicyDelegate::decidePolicyForMIMEType): (DefaultPolicyDelegate::unableToImplementPolicyWithError):
- DefaultPolicyDelegate.h: Added.
- WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNavigationAction): Implemented default action
- WebKit.vcproj/WebKit.vcproj: Adding files to project
LayoutTests:
removing fixed test
- platform/win/Skipped:
- 10:20 AM Changeset in webkit [26608] by
-
- 2 edits in trunk/WebCore
2007-10-12 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Maciej.
Return a more appropriate error from NPN_RequestRange, which is
currently unimplemented
- plugins/win/npapi.cpp: return NPERR_STREAM_NOT_SEEKABLE (NPN_RequestRead):
- 10:15 AM Changeset in webkit [26607] by
-
- 2 edits in trunk/WebCore
2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Maciej.
Add a missing function pointer to the m_browserFuncs structure
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
- 9:46 AM Changeset in webkit [26606] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Sam.
- <rdar://problem/5536630> fast/dom/Window/new-window-opener.html fails
- This test used to pass because of a mistake in js-test-pre.js. Now that the js file has been fixed this test has been updated, some of the test cases fail because DRT does not implement delegate methods for the bars for each WebView.
- See <rdar://problem/5538752> DumpRenderTree does not have a UIDelegate for each WebView.
- Also changed the test to correctly wait for the window to close before starting a new testcase. This is necessary because all the windows have the same name and cannot override the settings of a pre-existing window.
- fast/dom/Window/new-window-opener-expected.txt:
- fast/dom/Window/new-window-opener.html:
- 8:59 AM Changeset in webkit [26605] by
-
- 4 edits6 adds in trunk/WebCore
Fix the compilation of the Font code in the Qt port by adding the necessary stubs to support downloadable fonts through the @font-face rules.
- 8:58 AM Changeset in webkit [26604] by
-
- 4 edits in trunk/WebCore
Adapt to the latest API changes in the SVG API/Code.
- 8:58 AM Changeset in webkit [26603] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation with gcc 4.3 by including 'limits' due to the use of std::numeric_limits.
- 3:04 AM Changeset in webkit [26602] by
-
- 164 edits76 adds71 deletes in trunk/LayoutTests
Reset svg pixel tests to a tiger baseline and move them to platform/mac
RS=Maciej
Oct 14, 2007:
- 4:46 PM Changeset in webkit [26601] by
-
- 2 edits17 adds in trunk/LayoutTests
- added exceptions for all the tests failing on my personal Leopard machine
This may or may not get the buildbot green. I'll file separate bugs for each
of the tests with changed results.
- platform/mac-leopard/dom: Added.
- platform/mac-leopard/dom/xhtml: Added.
- platform/mac-leopard/dom/xhtml/level2: Added.
- platform/mac-leopard/dom/xhtml/level2/html: Added.
- platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Added.
- platform/mac-leopard/editing: Added.
- platform/mac-leopard/editing/pasteboard: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Added.
- platform/mac-leopard/http: Added.
- platform/mac-leopard/http/tests: Added.
- platform/mac-leopard/http/tests/security: Added.
- platform/mac-leopard/http/tests/security/dataURL: Added.
- platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
- platform/mac-leopard/svg/custom: Added.
- platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
- platform/mac-leopard/webarchive: Added.
- platform/mac-leopard/webarchive/test-xml-stylesheet-expected.txt: Added.
- platform/mac-leopard/security/block-test-expected.txt: Changed results.
- 4:20 PM Changeset in webkit [26600] by
-
- 1 edit3 copies1 delete in trunk/LayoutTests
- moved a test that somehow ended up doubly-nested in platform/mac
- platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum.
- platform/mac/fast/text/justified-text-rect-expected.png: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.png.
- platform/mac/fast/text/justified-text-rect-expected.txt: Copied from platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt.
- platform/mac/platform: Removed.
- platform/mac/platform/mac: Removed.
- platform/mac/platform/mac/fast: Removed.
- platform/mac/platform/mac/fast/text: Removed.
- platform/mac/platform/mac/fast/text/justified-text-rect-expected.checksum: Removed.
- platform/mac/platform/mac/fast/text/justified-text-rect-expected.png: Removed.
- platform/mac/platform/mac/fast/text/justified-text-rect-expected.txt: Removed.
- 3:30 PM Changeset in webkit [26599] by
-
- 13 edits1661 adds1634 deletes in trunk/LayoutTests
Revert "Rubberstamped by Eric."
This reverts commit 4ae99caea8eb153f9b85e86d1819b19b4af12fb4.
RS=Niko
Revert layout test move.
Filed http://bugs.webkit.org/show_bug.cgi?id=15513 to track correction for even earlier change
Conflicts:
- 1:15 PM Changeset in webkit [26598] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Not reviewed. Don't list all individual files in the ChangeLog -> make Mark happy
- 12:09 PM Changeset in webkit [26597] by
-
- 13 edits1 move5 deletes in trunk/LayoutTests
Rubberstamped by Eric.
Move current layout tests results from platform/mac/svg to platform/mac-tiger/svg.
The problem is that the current results have accidently been generated with Leopard,
I'm still moving this to mac-tiger so we don't loose the history for all the results.
After this commit, the baseline will be regenerated in mac-tiger/svg, and someone with
Leopard needs to generate new results in mac-leopard/svg.
- 10:51 AM Changeset in webkit [26596] by
-
- 2 edits in branches/Safari-3-branch/WebKit/win
Merged fix from r26594.
- 10:45 AM Changeset in webkit [26595] by
-
- 10 edits1 delete in trunk/WebCore
Reviewed by Eric.
Fix bad abstraction in ImageBuffer class.
While the class itself is platform-aware and thus it's location in platform/graphics
is fine, it contains the "renderSubtreeToImage" method which operates on RenderObject.
As it's SVG specific I decided to move this method into SVGRenderSupport, to avoid
implicit platform/ <-> rendering/ dependencies.
- 10:40 AM Changeset in webkit [26594] by
-
- 2 edits in trunk/WebKit/win
Move pthreads up in the linker order and don't mark it for delay load.
Fixes crash during regsvr32 of WebKit (currently repro if you do a spade ti).
Reviewed by Darin, Ada.
- WebKit.vcproj/WebKit.vcproj:
- 6:27 AM BuildingQtOnLinux edited by
- (diff)
- 6:02 AM Changeset in webkit [26593] by
-
- 2 edits in trunk/WebKitTools
2007-10-14 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark.
- Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line when querying for QMAKE_MKSPECS.
- 5:52 AM BuildingGtk edited by
- (diff)
- 5:06 AM Changeset in webkit [26592] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam Roben.
Fix run-webkit-tests is too greedy calculating platform hierarchy
http://bugs.webkit.org/show_bug.cgi?id=15465
Fix run-webkit-tests being too greedy in trying to split the platform name up
causing it to try and find tests in every directory above the first "-" in the
path to the LayoutTests
- Scripts/run-webkit-tests:
- 4:59 AM Changeset in webkit [26591] by
-
- 2 edits in trunk/WebCore
2007-10-14 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15210
Draw the image outline even for broken images.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
- 4:58 AM Changeset in webkit [26590] by
-
- 3 edits in trunk/WebKit/gtk
2007-10-14 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=15299
Fix "hovering_over_link" signal not emitted when consecutive links
are hovered.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- WebCoreSupport/ChromeClientGtk.h:
- Remove m_didSendLinkSignal as it is superseded by m_hoveredLinkURL
- 4:55 AM Changeset in webkit [26589] by
-
- 12 edits in trunk
2007-10-14 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Adam.
Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.
- dom/XMLTokenizer.cpp:
- page/FrameTree.cpp:
- platform/StaticConstructors.h:
- platform/String.cpp:
2007-10-5 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Adam.
Add support for MSVC7, and fix cases where PLATFORM(WIN) should
be PLATFORM(WIN_OS) for other ports building on Windows.
- kjs/DateMath.cpp: (KJS::getDSTOffsetSimple):
- kjs/JSImmediate.h:
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/Platform.h:
- wtf/StringExtras.h: (snprintf): (vsnprintf):
- 4:49 AM Changeset in webkit [26588] by
-
- 2 edits in trunk/WebCore
2007-10-14 Maxime Britto <mbritto@pleyo.com>
Reviewed by Mitz.
Fix an error in the goBackOrForward() function : confusion between forwardListCount and backListCount.
http://bugs.webkit.org/show_bug.cgi?id=15212
- loader/FrameLoader.cpp: (WebCore::FrameLoader::goBackOrForward):
- 4:44 AM Changeset in webkit [26587] by
-
- 4 edits4 adds in trunk
2007-10-14 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=15181 text-transform: uppercase not working in input (submit, reset, button) elements <rdar://problem/5474647>
Test: fast/forms/button-text-transform.html
Text transformations require access to the original text. The button's inner
text was an anonymous RenderText, meaning it did not have a node to retrieve
the original text from. The patch fixes this by changing the inner text into a
RenderTextFragment, which stores its own original text.
- rendering/RenderButton.cpp: (WebCore::RenderButton::setText):
- rendering/RenderButton.h:
2007-10-14 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=15181 text-transform: uppercase not working in input (submit, reset, button) elements <rdar://problem/5474647>
- fast/forms/button-text-transform.html: Added.
- platform/mac/fast/forms/button-text-transform-expected.checksum: Added.
- platform/mac/fast/forms/button-text-transform-expected.png: Added.
- platform/mac/fast/forms/button-text-transform-expected.txt: Added.
- 4:42 AM Changeset in webkit [26586] by
-
- 3 edits in trunk/WebKitTools
2007-10-14 Oleg Sukhodolsky <son.two@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15006
Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
to reduce code duplication.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm: buildQMakeProject() renamed to buildQMakeQtProject(). buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory), unused $colorize has been removed.
- 4:39 AM Changeset in webkit [26585] by
-
- 3 edits2 adds in trunk
2007-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
REGRESSION: Javascript bug in getElementsByName
http://bugs.webkit.org/show_bug.cgi?id=15274
Test: fast/dom/getelementbyname-invalidation.html
- dom/NameNodeList.h: remove empty rootNodeChildrenChanged override
2007-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Test for http://bugs.webkit.org/show_bug.cgi?id=15274
REGRESSION: Javascript bug in getElementsByName
- fast/dom/getelementbyname-invalidation-expected.txt: Added.
- fast/dom/getelementbyname-invalidation.html: Added.
- 4:35 AM Changeset in webkit [26584] by
-
- 3 edits in trunk/WebCore
2007-10-14 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15303 Remove now-redundant code to restore dialog arguments after clear
This patch reverts the kjs_window.* parts of r25576 because following
r25783, window properties, including dialog arguments, are not cleared
when the newly created modal dialog transitions to the document.
- bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::setReturnValueSlot):
- bindings/js/kjs_window.h:
- 4:33 AM Changeset in webkit [26583] by
-
- 3 edits4 adds in trunk
2007-10-14 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15309 <rdar://problem/5512020> Crash due to infinite recursion in RenderTable::addChild
Test: fast/table/generated-caption.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Changed to make sure that the child is not added into generated after content. Also made adding a child before a table caption work correctly instead of adding the child after the caption.
2007-10-14 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15309 <rdar://problem/5512020> Crash due to infinite recursion in RenderTable::addChild
- fast/table/generated-caption.html: Added.
- platform/mac/fast/table/generated-caption-expected.checksum: Added.
- platform/mac/fast/table/generated-caption-expected.png: Added.
- platform/mac/fast/table/generated-caption-expected.txt: Added.
- 4:31 AM Changeset in webkit [26582] by
-
- 8 edits in trunk
2007-10-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Adds NegateNode optimization from KJS. The relevant revision in KDE
is 666736.
- kjs/grammar.y:
- kjs/nodes.cpp: (NumberNode::evaluate):
- kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::):
- kjs/nodes2string.cpp: (NumberNode::streamTo):
2007-10-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Adds serialization test cases for NegateNode optimization from KDE.
- fast/js/function-decompilation-operators-expected.txt:
- fast/js/function-decompilation-operators.html:
- 4:30 AM Changeset in webkit [26581] by
-
- 3 edits3 adds in trunk
2007-10-14 Jason Foreman <jason@threeve.org>
Reviewed by Maciej.
Ensure that if adjusting n to minimize the difference of n*intPow10(e-p+1) to x,
that the property n < intPow10(p) is maintained.
- kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
2007-10-14 Jason Foreman <jason@threeve.org>
Reviewed by Maciej.
Adding test for http://bugs.webkit.org/show_bug.cgi?id=15145.
- ChangeLog:
- fast/js/number-toprecision-expected.txt: Added.
- fast/js/number-toprecision.html: Added.
- fast/js/resources/number-toprecision.js: Added.
- 4:28 AM Changeset in webkit [26580] by
-
- 2 edits in trunk/WebCore
2007-10-14 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15141
Feed GIF reader data from the point in the stream it expects. Also,
mirror the reader's failure state up to the wrapping decoder.
- platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
- 4:27 AM Changeset in webkit [26579] by
-
- 2 edits in trunk/WebCore
2007-10-14 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15142
Return correct frame count in GIFImageDecoder::frameBufferAtIndex(),
even if more data has arrived since the last decoding pass.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex):
- 4:25 AM Changeset in webkit [26578] by
-
- 2 edits in trunk/LayoutTests
2007-10-14 Feng Qian <ian.eng.webkit@gmail.com>
Reviewed by Maciej.
- fast/events/window-events-bubble2.html:
- 4:17 AM Changeset in webkit [26577] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Bad Mark, wrong branch.
- 4:16 AM Changeset in webkit [26576] by
-
- 2 edits in branches/Safari-3-branch/WebCore
2007-10-14 Satoshi Ueyama <gyuque@gmail.com>
Reviewed by Adam Roben.
- ksvg2/scripts/cssmakevalues: Replaced chomp with regexp. chomp doesn't work well with CR-LF endings.
- 4:11 AM Changeset in webkit [26575] by
-
- 4 copies4 adds in branches/Safari-3-branch
Roll over ChangeLogs for JavaScriptCore, LayoutTests, WebCore and WebKit.
- 4:02 AM Changeset in webkit [26574] by
-
- 4 copies4 adds in trunk
Roll over ChangeLogs for JavaScriptCore, LayoutTests, WebCore and WebKit.
- 2:03 AM Changeset in webkit [26573] by
-
- 2 edits in trunk/WebCore
2007-10-14 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
Remove senseless malloc from paintOutline
No tests needed, no functional change.
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline): remove unneeded malloc
Oct 13, 2007:
- 9:12 PM Changeset in webkit [26572] by
-
- 4 edits7 adds in trunk/LayoutTests
Adding leopard specific results to a few SVG specific tests
RS=Maciej.
- platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.
- platform/mac-leopard/svg/batik/text/textBiDi-expected.txt: Added.
- platform/mac-leopard/svg/hixie/text/003-expected.txt:
- platform/mac-leopard/svg/hixie/text/003a-expected.txt:
- platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
- platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- platform/mac-leopard/svg/text/text-path-01-b-expected.txt: Added.
- 7:07 PM Changeset in webkit [26571] by
-
- 3 edits in trunk/WebCore
2007-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix SVGSVGElement::currentView() to not leak by using an OwnPtr.
This fix is incompatible with changes eventually needed for supporting
SVGSVGElement.currentView in the bindings (that needs a ref'd object)
There are also several parser crashers in SVGViewSpec, but those will be fixed
in my next patch.
Leak fix only, no additional tests needed.
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentView): call .get() and .set()
- ksvg2/svg/SVGSVGElement.h: use OwnPtr
- 3:36 PM Changeset in webkit [26570] by
-
- 5 edits in trunk/LayoutTests
Make svg/batik/text/textDecoration2.svg use Lucida Grande
RS=Eric.
This test case used to use Lucida Sans which is apparently available on some
systems, but not all. Switching to Lucida Grande results in a slight change
but we'll be testing with a font that everyone has.
- svg/batik/text/textDecoration2-expected.checksum:
- svg/batik/text/textDecoration2-expected.png:
- svg/batik/text/textDecoration2-expected.txt:
- svg/batik/text/textDecoration2.svg:
- 2:41 PM Changeset in webkit [26569] by
-
- 9 edits in trunk/WebCore
Fixing a few testcases by enabling SVG_EXPERIMENTAL on windows, and making the required fixes and corrections.
Reviewed by Maciej
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/build-generated-files.sh:
- bindings/scripts/CodeGeneratorJS.pm:
- ksvg2/scripts/make_names.pl:
- ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):
- page/DOMWindow.idl:
- platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
- platform/win/WebCoreTextRenderer.cpp:
Oct 12, 2007:
- 6:16 PM Changeset in webkit [26568] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Darin.
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt: Update results to reflect current tree. Reopening <rdar://problem/5483567> (see below) to note the potential bug.
- 6:11 PM Changeset in webkit [26567] by
-
- 1 edit2 moves in trunk/LayoutTests
Reviewed by Oliver Hunt.
- change test that was accidentally detecting changes in frame load delegate calls to run in a directory where we do not log frame load delegate calls
At some point we may want to test them (and so re-add the test that is
currently intermittently giving different results), but this test is about
the DOMContentLoaded event and we want to test just that.
- http/tests/loading/DOMContentLoaded-event-expected.txt: Removed.
- http/tests/loading/DOMContentLoaded-event.html: Removed.
- http/tests/misc/DOMContentLoaded-event-expected.txt: Copied from http/tests/loading/DOMContentLoaded-event-expected.txt.
- http/tests/misc/DOMContentLoaded-event.html: Copied from http/tests/loading/DOMContentLoaded-event.html.
- 6:08 PM Changeset in webkit [26566] by
-
- 1 copy in tags/WebCore-419.2.2-dashboard/WebCore
New tag (part 2).
- 6:07 PM Changeset in webkit [26565] by
-
- 1 add in tags/WebCore-419.2.2-dashboard
New tag (part 1).
- 6:03 PM Changeset in webkit [26564] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Stephanie and Oliver.
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt: Update result to reflect current behavior. This is a bug and we wrote a bug report in Radar, <rdar://problem/5538793>.
- 6:01 PM Changeset in webkit [26563] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
Versioning.
- 5:59 PM Changeset in webkit [26562] by
-
- 2 edits in branches/Safari-3-branch/LayoutTests
Reviewed by Darin.
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt: Update results to reflect current tree. Reopening <rdar://problem/5483567> (see below) to note the potential bug.
- 5:50 PM Changeset in webkit [26561] by
-
- 4 edits in branches/Safari-3-branch
Versioning.
- 5:47 PM Changeset in webkit [26560] by
-
- 1 copy in tags/Safari-4523.11
New tag.
- 5:44 PM Changeset in webkit [26559] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- more float/int conversion (to try to get the old builbot up)
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Cast to int. (WebCore::RenderSVGRoot::applyContentTransforms): Ditto. (WebCore::RenderSVGRoot::nodeAtPoint): Ditto.
- 5:40 PM Changeset in webkit [26558] by
-
- 5 edits7 adds1 delete in trunk
WebCore:
Reviewed by Harrison.
<rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
<rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply):
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
<rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table
- editing/deleting/5483370.html: Added.
- editing/pasteboard/5483567.html-disabled: Removed.
- editing/execCommand/5482524.html: Added.
- platform/mac/editing/deleting/5483370-expected.checksum: Added.
- platform/mac/editing/deleting/5483370-expected.png: Added.
- platform/mac/editing/deleting/5483370-expected.txt: Added.
- platform/mac/editing/execCommand/5482524-expected.checksum: Added.
- platform/mac/editing/execCommand/5482524-expected.png: Added.
- platform/mac/editing/execCommand/5482524-expected.txt: Added.
- 5:17 PM Changeset in webkit [26557] by
-
- 2 edits in trunk/WebCore
- fix another float/int conversion
- platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask): Explicitly cast to int.
- 4:41 PM Changeset in webkit [26556] by
-
- 2 edits1 move in trunk/LayoutTests
Reviewed by Oliver Hunt.
- more work toward getting layout tests passing
- fast/images/svg-background-crash-on-refresh.html: Removed.
- fast/images/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html. Needed to disable this test because it causes a hang; not necessarily right after this test, sometimes quite a few tests later.
- platform/mac-leopard/Skipped: Re-enabled a test that's fixed.
- 4:41 PM Changeset in webkit [26555] by
-
- 2 edits in trunk/LayoutTests
- fast/css/computed-style-expected.txt: Again, but right this time.
- 4:03 PM Changeset in webkit [26554] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix float/int conversions that cause warnings on older versions of gcc (like the version currently being used on the PowerPC buildbot slave)
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint): Explicitly cast to int. (WebCore::RenderPath::addFocusRingRects): Use enclosingIntRect to convert a FloatRect to an IntRect.
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): Use 0 for the initial value of an int, rather than 0.0f. (WebCore::svgTextStyleForInlineTextBox): Explicitly cast to int. (WebCore::applyTextAnchorToTextChunk): Ditto.
- 2:19 PM Changeset in webkit [26553] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Oliver Hunt.
- fast/css/computed-style-expected.txt: Added SVG CSS properties.
- fast/css/computed-style-without-renderer-expected.txt: Ditto.
- 1:54 PM Changeset in webkit [26552] by
-
- 5 edits in trunk
Correct date in merge markers
RS=Darin
- 1:47 PM Changeset in webkit [26551] by
-
- 1 move in branches/old/feature-branch-2007-10-12
Move old feature branch away
- 1:40 PM Changeset in webkit [26550] by
-
- 2 edits in trunk/WebCore
Cast zoom factor to int as the original patch did. This is necessary to appease some versions of gcc.
Reviewed by Mark.
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
- 1:13 PM Changeset in webkit [26549] by
-
- 7 edits in trunk/WebCore
2007-10-12 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leaks in SVG code from feature-branch.
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
- ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::buildStops):
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::resolveStyle): always refs style
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::create): fastFree buffer if CG Context creation fails
- 12:37 PM Changeset in webkit [26548] by
-
- 7 edits in branches/feature-branch/WebCore
2007-10-12 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leaks in SVG code from feature-branch.
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
- ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::buildStops):
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::resolveStyle): always refs style
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::create): fastFree buffer if CG Context creation fails
- 11:58 AM Changeset in webkit [26547] by
-
- 1 edit2 moves4 deletes in trunk/LayoutTests
More Layout test tidying
RS=Alexey
Move dom/xhtml/level2/html/HTMLBaseElement0[12].xhtml expected output
to cross platform directory, remove unnecessary pixel results.
- dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Added.
- dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Added.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.
- 11:35 AM Changeset in webkit [26546] by
-
- 4 edits in trunk/LayoutTests
Correct expected output of a few test cases
RS=Eric
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
- platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
- platform/mac/fast/dom/dom-parse-serialize-expected.txt:
- 10:32 AM Changeset in webkit [26545] by
-
- 3 edits in trunk/WebCore
2007-10-12 Mark Rowe <mrowe@apple.com>
Windows, Gtk and Qt build fixes. Add new files to projects.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 8:41 AM Changeset in webkit [26544] by
-
- 9 edits in trunk
Add merge markers
- 8:41 AM Changeset in webkit [26543] by
-
- 63 edits in trunk
Fix Bug 15469: feature branch has 100's of implicit double -> float conversions
Reviewed by Sam.
Re-enable -Wshorten-64-to-32, and make required code changes to make us build sanely again.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::updateAnimatedValue): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines):
- ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
- ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::parseMappedAttribute):
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
- ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute):
- ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
- ksvg2/svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::parseMappedAttribute):
- ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::parseMappedAttribute):
- ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::parseMappedAttribute):
- ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
- ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute):
- ksvg2/svg/SVGFitToViewBox.h:
- ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): (WebCore::SVGLength::PercentageOfViewport):
- ksvg2/svg/SVGNumber.idl:
- ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
- ksvg2/svg/SVGNumberList.h:
- ksvg2/svg/SVGParserUtilities.cpp: (WebCore::_parseNumber): (WebCore::parseNumber): (WebCore::pointsListFromSVGData): (WebCore::PathBuilder::svgMoveTo): (WebCore::PathBuilder::svgLineTo): (WebCore::PathBuilder::svgCurveToCubic): (WebCore::SVGPathSegListBuilder::svgMoveTo): (WebCore::SVGPathSegListBuilder::svgLineTo): (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): (WebCore::SVGPathSegListBuilder::svgLineToVertical): (WebCore::SVGPathSegListBuilder::svgCurveToCubic): (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::svgArcTo):
- ksvg2/svg/SVGParserUtilities.h:
- ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement):
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
- ksvg2/svg/SVGSVGElement.h:
- ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
- ksvg2/svg/SVGTransformDistance.h:
- ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformValue):
- ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
- platform/graphics/svg/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
- platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
- platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup):
- platform/graphics/svg/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::applyFilter):
- platform/graphics/svg/filters/SVGFEComponentTransfer.h: (WebCore::SVGComponentTransferFunction::SVGComponentTransferFunction):
- platform/graphics/svg/filters/SVGFEComposite.cpp: (WebCore::SVGFEComposite::SVGFEComposite):
- platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp: (WebCore::SVGFEConvolveMatrix::SVGFEConvolveMatrix):
- platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp: (WebCore::SVGFEDiffuseLighting::SVGFEDiffuseLighting):
- platform/graphics/svg/filters/SVGFEFlood.cpp: (WebCore::SVGFEFlood::SVGFEFlood):
- platform/graphics/svg/filters/SVGFEGaussianBlur.cpp: (WebCore::SVGFEGaussianBlur::SVGFEGaussianBlur):
- platform/graphics/svg/filters/SVGFEMorphology.cpp: (WebCore::SVGFEMorphology::SVGFEMorphology):
- platform/graphics/svg/filters/SVGFEOffset.cpp: (WebCore::SVGFEOffset::SVGFEOffset):
- platform/graphics/svg/filters/SVGFESpecularLighting.cpp: (WebCore::SVGFESpecularLighting::SVGFESpecularLighting):
- platform/graphics/svg/filters/SVGFETurbulence.cpp: (WebCore::SVGFETurbulence::SVGFETurbulence):
- platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: (WebCore::SVGFEColorMatrix::getCIFilter):
- platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm: (WebCore::getVectorForChannel): (WebCore::getLightVectors):
- platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter):
- rendering/RenderPath.cpp: (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::relativeBBox):
- rendering/RenderSVGTextPath.cpp:
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::calculateBaselineShift): (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo): (WebCore::SVGCharacterLayoutInfo::processedChunk): (WebCore::SVGCharacterLayoutInfo::nextPathLayoutPointAndAngle): (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
- rendering/SVGCharacterLayoutInfo.h:
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::pathForDecoration):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::applyTextAnchorToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- 8:40 AM Changeset in webkit [26542] by
-
- 10 edits in trunk
Reviewed by Eric Seidel.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
"deg2rad has multiple definitions"
Define deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
These are used through WebKit.
Change based on original patch by Rob Buis.
- wtf/MathExtras.h: (deg2rad): (rad2deg): (deg2grad): (grad2deg): (rad2grad): (grad2rad):
WebCore:
Reviewed by Eric Seidel.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
"deg2rad has multiple definitions"
Use deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
from wtf where appropriate.
No test cases as this doesn't change behaviour.
Change based on original patch by Rob Buis.
- ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::calculate): (WebCore::SVGAngle::convertToSpecifiedUnits): (WebCore::SVGAngle::todeg): (WebCore::SVGAngle::torad):
- platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY):
- platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::rotate):
- platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
- platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
- platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
- rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):
- 8:40 AM Changeset in webkit [26541] by
-
- 30 edits1 add in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=6421 (<text> textLength attribute is not respected)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=6422 (<text> lengthAdjust attribute is not respected)
Implement textLength and full lengthAdjust (both 'spacing' & 'spacingAndGlyphs' mode)
for <text> & <tspan> & friends. <textPath> is still todo, as it's special.
Also fix usage of cummulatedGlyphWidth/Height in SVGInlineTextBox, calculateGlyphBoundaries was
supposed to be used in the distance calculations, to take per character transformations into account (ie. rotation).
Fixes: svg/W3C-SVG-1.1/text-text-01-b.svg (complelty fixed the single W3C textLength testcase)
Partly fixed: svg/batik/text/textOnPathSpaces.svg (kerning support missing)
Partly fixed: svg/batik/text/textLayout.svg (word-letter spacing & textLength is todo)
- 8:40 AM Changeset in webkit [26540] by
-
- 8 edits in trunk
Fix for Bug 15468: Parsing of numbers and lists is too lenient in SVG
Reviewed by Niko.
Correct parsing of numbers, number lists, and length lists in SVG.
- ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
- ksvg2/svg/SVGLength.h:
- ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::parse):
- ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber):
- 8:40 AM Changeset in webkit [26539] by
-
- 4 edits4 adds in trunk
2007-10-11 Allan Sandfeld Jensen <sandfeld@kde.org>
Reviewed by Maciej and Eric.
Implement CSS selector combinators nondeterministic matching.
Fixes http://bugs.webkit.org/show_bug.cgi?id=3428
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkSelector): Split the function and make the second part recursive (WebCore::CSSStyleSelector::checkOneSelector): Handle pseodo-elements rules and hoveractive quirks here instead of in checkSelector.
- css/CSSStyleSelector.h:
- 8:39 AM Changeset in webkit [26538] by
-
- 4 edits4 adds in trunk
2007-10-10 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
Fix the SVG dom so that rect.x.baseVal = rect.x.baseVal like it should.
http://bugs.webkit.org/show_bug.cgi?id=14150
Test: svg/dom/animated-tearoff-equlity.xhtml
- ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTypeWrapperKey::SVGAnimatedTypeWrapperKey): (WebCore::SVGAnimatedTypeWrapperKey::operator==): (WebCore::SVGAnimatedTypeWrapperKeyHash::hash): (WebCore::SVGAnimatedTypeWrapperKeyHash::equal): (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::deletedValue): (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::emptyValue): (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate): (WebCore::SVGAnimatedTemplate::wrapperCache): (WebCore::SVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
- ksvg2/svg/SVGElement.h:
- 8:39 AM Changeset in webkit [26537] by
-
- 2 edits in trunk/LayoutTests
Correcting expected output of svg/batik/text/textOnPathSpaces
RS = Eric.
- svg/batik/text/textOnPathSpaces-expected.txt
- 8:39 AM Changeset in webkit [26536] by
-
- 3 edits in trunk/WebCore
Leopard build fix -- SVGDocument should not trty to make read/write properties read-only
Reviewed by Maciej.
Remove those API definitions SVGDocument now inherits from Document
- ksvg2/svg/SVGDocument.idl:
- 8:38 AM Changeset in webkit [26535] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Eric.
- fix assertion failures on quit.
- kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Dynamically alocate function-scope static UStrings to avoid the static destructor getting called later.
- kjs/lookup.h: Dynamically alocate function-scope static Identifiers to avoid the static destructor getting called later.
- 8:38 AM Changeset in webkit [26534] by
-
- 48 edits1 copy4 adds in trunk
2007-10-10 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Make renderers pull localTransform instead of depending on DOM elements to push
This allows for cleaner invalidation code, and makes writing animation easier.
Also fixed a tiny bug in SVGRenderImage focus ring calculations while there
Updated test results for svg/custom/focus-ring.svg
- WebCore.xcodeproj/project.pbxproj:
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::createRenderer):
- ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
- ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
- ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
- ksvg2/svg/SVGElement.h:
- ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::createRenderer):
- ksvg2/svg/SVGImageElement.cpp:
- ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM):
- ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::notifyAttributeChange):
- ksvg2/svg/SVGSVGElement.h:
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::notifyResourceParentIfExistant):
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::style):
- ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute): (WebCore::SVGStyledTransformableElement::notifyAttributeChange): (WebCore::SVGStyledTransformableElement::createRenderer):
- ksvg2/svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
- ksvg2/svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::createRenderer):
- ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
- ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
- ksvg2/svg/SVGTextElement.h:
- ksvg2/svg/SVGTextPathElement.cpp:
- ksvg2/svg/SVGTextPathElement.h:
- ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM):
- ksvg2/svg/SVGTransformable.h:
- ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::createRenderer): (WebCore::SVGUseElement::attachShadowTree):
- platform/graphics/AffineTransform.h: (WebCore::AffineTransform::operator!=):
- platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::setMarker):
- platform/graphics/svg/SVGResourceMarker.h:
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::calculateLocalTransform): (WebCore::RenderForeignObject::layout):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::localTransform): (WebCore::RenderPath::calculateLocalTransform): (WebCore::RenderPath::layout):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::localTransform): (WebCore::RenderSVGContainer::calculateLocalTransform): (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::calculateLocalTransform): (WebCore::RenderSVGText::layout):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::isSVGText): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): (WebCore::RenderSVGTextPath::startOffset): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
- rendering/RenderSVGTextPath.h:
- rendering/RenderSVGTransformableContainer.cpp: Added. (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h: Added.
- rendering/RenderSVGViewportContainer.h:
- 8:38 AM Changeset in webkit [26533] by
-
- 10 edits in trunk/WebCore
Bug 15451: SVGStyledElement must unregister itself from Resources on detach
Reviewed by Eric.
Use a global hashtable to maintain the relationship between the
various SVG resources and their clients, across dom updates, etc.
- ChangeLog:
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::detach):
- ksvg2/svg/SVGStyledElement.h:
- platform/graphics/svg/SVGPaintServer.h:
- platform/graphics/svg/SVGResource.cpp: (WebCore::ResourceSet::ResourceSet): (WebCore::clientMap): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
- platform/graphics/svg/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker):
- platform/graphics/svg/SVGResourceClipper.h: (WebCore::SVGResourceClipper::resourceType):
- platform/graphics/svg/SVGResourceFilter.h:
- platform/graphics/svg/SVGResourceMarker.h:
- platform/graphics/svg/SVGResourceMasker.h:
- 8:37 AM Changeset in webkit [26532] by
-
- 2 edits in trunk/WebCore
2007-10-10 Mark Rowe <mrowe@apple.com>
Windows build fix after r26109.
- WebCore.vcproj/WebCore.vcproj:
- 8:37 AM Changeset in webkit [26531] by
-
- 4 edits in trunk/WebCore
Fix Bug 15433: Filters do not repaint when base resources change/update
Reviewed by Eric.
SVGFEImage now actually responds to image updates, and triggers a repaint.
- platform/graphics/svg/SVGResource.h:
- platform/graphics/svg/filters/SVGFEImage.cpp: (WebCore::SVGFEImage::setCachedImage): Don't re-set the image lest we want to trigger infinite recursion. (WebCore::SVGFEImage::imageChanged): Image change means we need to tell our clients to repaint
- platform/graphics/svg/filters/SVGFEImage.h:
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): make sure that users of filters are registered.
- 8:37 AM Changeset in webkit [26530] by
-
- 2 edits in trunk/WebCore
2007-10-09 Eric Seidel <eric@webkit.org>
Reviewed by Alp.
Track changes in r26109 to fix the Gtk+ build.
- WebCore.pro:
- 8:36 AM Changeset in webkit [26529] by
-
- 3 edits2 adds in trunk
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=15436
Wrong node order for XPath reverse axes
Test: fast/xpath/reverse-axes.html
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Do not prematurely sort reverse axes. Generate preceding axis nodes in reversed document order.
- 8:36 AM Changeset in webkit [26528] by
-
- 5 edits2 adds in trunk
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15437
XPath substring-after function is broken
Test: fast/xpath/substring-after.html
- xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::evaluate): Fix it for real this time, hopefully.
- 8:35 AM Changeset in webkit [26527] by
-
- 409 edits in trunk/LayoutTests
Not reviewed.
Regenerated the SVG test baseline, they have been generated with _trunk_ instead of feature-branch.
Not sure who committed it, but it's wrong - so I'm fixing.
- 8:34 AM Changeset in webkit [26526] by
-
- 4 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=15080
<use> element not refresh after adding objects by script in referrer
Update shadow tree when elements are added/removed from a tree
that is referenced by a <use>.
- 8:34 AM Changeset in webkit [26525] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15088
HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed
Make sure the list items are up to date when there is no renderer.
- 8:33 AM Changeset in webkit [26524] by
-
- 3 edits in trunk/WebKitTools
HackTop [26957:WebKitTools]% less ChangeLog Stuff/Projects/WebKit/WebKitTools
2007-10-08 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/build-webkit: add --help, remove unused --color
- 8:33 AM Changeset in webkit [26523] by
-
- 3 edits2 moves in trunk/WebCore
2007-10-08 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Build fix. Fix circular build rule for CSS*.in files evident on clean build.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- ksvg2/css/CSSPropertyNames.in: Removed.
- ksvg2/css/CSSValueKeywords.in: Removed.
- ksvg2/css/SVGCSSPropertyNames.in: Copied from ksvg2/css/CSSPropertyNames.in.
- ksvg2/css/SVGCSSValueKeywords.in: Copied from ksvg2/css/CSSValueKeywords.in.
- 8:32 AM Changeset in webkit [26522] by
-
- 15 edits4 adds2 deletes in trunk
2007-10-08 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Implement getComputedStyle support for SVG CSS values
http://bugs.webkit.org/show_bug.cgi?id=15422
This also unifies SVG and non-SVG CSS hash lookups. A unified hash
solves correctness problems as well as offers improved speed.
Test: svg/css/getComputedStyle-basic.xhtml
- DerivedSources.make: unify SVG and non-SVG CSS hash files
- WebCore.xcodeproj/project.pbxproj: remove old SVG CSS hash files
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): call getPropertyCSSValue
- css/CSSComputedStyleDeclaration.h: add getPropertyCSSValue
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- ksvg2/css/CSSPropertyNames.in: remove font-size-adjust
- ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: Added. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): added.
- ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
- ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- ksvg2/scripts/cssmakeprops: Removed.
- ksvg2/scripts/cssmakevalues: Removed.
- ksvg2/svg/SVGAnimationElement.cpp:
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): remove font-size-adjust
- 8:32 AM Changeset in webkit [26521] by
-
- 2 edits in trunk
WebCore:
Reviewed by Steve Falkenburg;
Fix for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9
Test: fast/innerHTML/innerHTML-script-tag-crash.xhtml
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::lineNumber): Return 1 when there is no context. (WebCore::XMLTokenizer::columnNumber): ditto.
LayoutTests:
Reviewed by Steve Falkenburg.
Test for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9
- fast/innerHTML/innerHTML-script-tag-crash-expected.txt: Added.
- fast/innerHTML/innerHTML-script-tag-crash.xhtml: Added.
- 8:31 AM Changeset in webkit [26520] by
-
- 2 edits in trunk/WebCore
- platform/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::setFont): Restored one of the -1 checks removed in the previous change - we do need to check m_font!
- 8:30 AM Changeset in webkit [26519] by
-
- 2 edits in trunk/WebKitTools
2007-10-07 Eric Seidel <eric@webkit.org>
Reviewed by darin.
- Drosera/mac/DebuggerDocumentPlatform.mm: (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
- 8:30 AM Changeset in webkit [26518] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15397
Layout tests freeze in HashTable::lookup
Fixes a DRT freeze on PowerPC.
- platform/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): Don't ask for a size of a nil font, the result is undefined. (WebCore::FontPlatformData::setFont): Ditto. Also removed some checks for -1 that were not sufficient, and thus likely unnecessary,
- 8:29 AM Changeset in webkit [26517] by
-
- 13 edits in trunk/LayoutTests
Not reviewed.
Forgot to land some result test changes in my last commit.
- 8:28 AM Changeset in webkit [26516] by
-
- 35 edits in trunk
Reviewed by Eric.
Fix some issues with rotation & baseline-shift, when spanning
across <tspan> elements. Highlighted by the existing batik tests.
- 8:27 AM Changeset in webkit [26515] by
-
- 4 edits2 adds in trunk
2007-10-07 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
http://bugs.webkit.org/show_bug.cgi?id=5122
This is based on a patch by Daniel Peebles (pumpkingod@gmail.com).
Test: http/tests/loading/DOMContentLoaded-event.html
- dom/Document.cpp: (WebCore::Document::finishedParsing): Dispatch the DOMContentLoaded event when parsing completes.
- dom/EventNames.h: Add DOMContentLoaded to the list of events.
2007-10-07 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Test for Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
http://bugs.webkit.org/show_bug.cgi?id=5122
- http/tests/loading/DOMContentLoaded-event-expected.txt: Added.
- http/tests/loading/DOMContentLoaded-event.html: Added.
- 8:27 AM Changeset in webkit [26514] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Mark.
Fix textLength.svg testcase - missed xmlns.
- 8:26 AM Changeset in webkit [26513] by
-
- 4 edits in trunk/JavaScriptCore
2007-10-07 Ed Schouten <ed@fxq.nl>
Reviewed and landed by Alexey Proskuryakov.
Add PLATFORM(FREEBSD), so we can fix the build on FreeBSD-like
systems by including <pthread_np.h>. Also fix some (disabled)
regcomp()/regexec() code; it seems some variable names have
changed.
- kjs/config.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp):
- wtf/Platform.h:
- 8:25 AM Changeset in webkit [26512] by
-
- 1 edit in trunk/JavaScriptCore/tests/mozilla/expected.html
Forgot to commit this with r25958.
- 8:24 AM Changeset in webkit [26511] by
-
- 3 edits4 adds in trunk
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=15368
xsl:import fails when preceded by comment
Test: fast/xsl/import-after-comment.xml
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): It's OK for xsl:import to be preceded by non-element nodes.
- 8:24 AM Changeset in webkit [26510] by
-
- 5 edits6 adds in trunk
2007-10-07 Vincent Ricard <magic@magicninja.org>
Reviewed by Maciej. Landed by eseidel.
http://bugs.webkit.org/show_bug.cgi?id=15062
Implement document.compatMode
Tests: fast/dom/compatMode-AlmostStrict.html
fast/dom/compatMode-Compat.html
fast/dom/compatMode-Strict.html
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::compatMode):
- html/HTMLDocument.h:
- html/HTMLDocument.idl:
- 8:23 AM Changeset in webkit [26509] by
-
- 16 edits1 add in trunk
2007-10-07 Sam Weinig <sam@webkit.org>
Reviewed by Darin & Nikolas. Landed by eseidel.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14455
Autogenerate the JS bindings for the StyleSheetList
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSStyleSheetListCustom.cpp: Added. (WebCore::JSStyleSheetList::canGetItemsForName): (WebCore::JSStyleSheetList::nameGetter):
- bindings/js/kjs_css.cpp:
- bindings/js/kjs_css.h:
- bindings/objc/DOMUtility.mm:
- bindings/scripts/CodeGeneratorJS.pm:
- css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList): (WebCore::StyleSheetList::documentDestroyed): (WebCore::StyleSheetList::getNamedItem):
- css/StyleSheetList.h: Add Document member variable and getNamedItem function to accommodate the odd javascript name getter functionality.
- css/StyleSheetList.idl:
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
- page/DOMWindow.idl: Add StyleSheetListConstructor
- 8:22 AM Changeset in webkit [26508] by
-
- 2 edits in trunk/WebCore
2007-10-07 Lars Naesbye Christensen <lars@naesbye.dk>
Reviewed by Eric Seidel.
make CSS cell cursor more mac-like
http://bugs.webkit.org/show_bug.cgi?id=15325
- Resources/cellCursor.png:
- 8:21 AM Changeset in webkit [26507] by
-
- 3 edits in trunk/WebCore
2007-10-06 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
SVG does not correctly handle onfocusin, onfocusout or onactivate
http://bugs.webkit.org/show_bug.cgi?id=12573
Test: svg/W3C-SVG-1.1/script-handle-02-b.svg
- ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
- ksvg2/svg/svgattrs.in: add onfocusin, onfocusout and onactivate
- 8:20 AM Changeset in webkit [26506] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Never pass null input images to CICrop filter.
- 8:19 AM Changeset in webkit [26505] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Mark.
Remove useless onload/onunload handlers from js-update-container.svg,
causing a console message saying these handlers don't exist.
- 8:18 AM Changeset in webkit [26504] by
-
- 456 edits in trunk/LayoutTests
Rubberstamped by Oliver.
Update SVG baseline with Tiger. No regressions.
- 8:17 AM Changeset in webkit [26503] by
-
- 3 edits in trunk/WebCore
2007-10-06 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Gtk+ build fix and minor code cleanup.
- WebCore.pro:
- platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):
- 8:16 AM Changeset in webkit [26502] by
-
- 3 edits2 adds in trunk
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15380
XPath: id('foo') doesn't resolve correctly
Test: fast/xpath/id-simple.html
- xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Fixed a logic error in id() parameter parsing.
- 8:15 AM Changeset in webkit [26501] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removing a conflict marker.
- 8:14 AM Changeset in webkit [26500] by
-
- 2 edits in trunk/LayoutTests
- fast/dom/xmlhttprequest-get-expected.txt: Updated event properties for changes made in bug 15102.
- 8:13 AM Changeset in webkit [26499] by
-
- 34 edits in trunk
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13707
REGRESSION: JavaScript exceptions on quotes.burntelectrons.org
http://bugs.webkit.org/show_bug.cgi?id=12628
document.body is not supported in XHTML documents
http://bugs.webkit.org/show_bug.cgi?id=14213
On page with MIME type application/xhtml+xml, cookie don't work
WebCore:
Moved a bunch of methods and properties from HTMLDocument down into Document to make
them available for all documents (xml, svg).
What was kept in HTMLDocument:
- some methods and properties that are not in HTML5 (yet?);
- open/write/writeln/close, as they will need to be modified to work on XML documents, and aren't of much use for those anyway;
- designMode, because its definition in HTML5 is incompatible with our implementation.
Covered by existing tests.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation):
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/objc/PublicDOMInterfaces.h:
- dom/Document.cpp: (WebCore::Document::setBody): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::lastModified):
- dom/Document.h: (WebCore::Document::title):
- dom/Document.idl:
- html/HTMLDocument.cpp:
- html/HTMLDocument.h:
- html/HTMLDocument.idl:
LayoutTests:
- dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
- dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
- dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
- dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
- dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
- dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
- dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
- dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
- dom/xhtml/level2/html/HTMLBodyElement07-expected.txt:
- dom/xhtml/level2/html/HTMLBodyElement08-expected.txt:
- dom/xhtml/level2/html/HTMLBodyElement09-expected.txt:
- dom/xhtml/level2/html/HTMLBodyElement10-expected.txt:
- dom/xhtml/level2/html/HTMLBodyElement11-expected.txt:
- dom/xhtml/level2/html/HTMLBodyElement12-expected.txt:
- dom/xhtml/level2/html/HTMLDocument01-expected.txt:
- dom/xhtml/level2/html/HTMLDocument02-expected.txt:
- dom/xhtml/level2/html/HTMLDocument03-expected.txt:
- dom/xhtml/level2/html/HTMLDocument05-expected.txt:
- dom/xhtml/level2/html/HTMLDocument07-expected.txt:
- dom/xhtml/level2/html/HTMLDocument08-expected.txt:
- dom/xhtml/level2/html/HTMLDocument09-expected.txt:
- dom/xhtml/level2/html/HTMLDocument10-expected.txt:
- dom/xhtml/level2/html/HTMLDocument11-expected.txt:
- dom/xhtml/level2/html/HTMLDocument12-expected.txt:
- dom/xhtml/level2/html/HTMLDocument13-expected.txt:
- dom/xhtml/level2/html/HTMLDocument14-expected.txt:
- dom/xhtml/level2/html/doc01-expected.txt: These now pass. Changed HTMLBaseElement* to dump as text.
- fast/dom/Window/window-properties-expected.txt: Added Document.prototype.getElementsByName
- 8:12 AM Changeset in webkit [26498] by
-
- 21 edits in trunk/WebCore
2007-10-06 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
http://bugs.webkit.org/show_bug.cgi?id=15388
This makes the Sun Lively Kernel invalidate only what it should!
No tests possible in DRT.
- ksvg2/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::notifyAttributeChange): replace call to rebuildRenderer (WebCore::SVGImageElement::hasRelativeValues): implemented
- ksvg2/svg/SVGImageElement.h:
- ksvg2/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::notifyAttributeChange): replace call to rebuildRenderer
- ksvg2/svg/SVGStyledElement.cpp:
- ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeValues): default to true instead
- ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform): don't layout if no change
- ksvg2/svg/SVGStyledTransformableElement.h:
- ksvg2/svg/SVGTransform.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::selfWillPaint): return true if have a filter (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::calcViewport): use floats
- 8:11 AM Changeset in webkit [26497] by
-
- 16 edits in trunk/WebCore
Reviewed by Eric.
Use document() instead of ownerDocument() and a few other cleanups.
- 8:09 AM Changeset in webkit [26496] by
-
- 6 edits in trunk/WebCore
2007-10-05 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
SVG invalidates way too much during layout()
http://bugs.webkit.org/show_bug.cgi?id=14003
- ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): simplify if (WebCore::SVGElement::viewportElement): simplify if
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): only layout children if parent changed
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): only layout children when size changes
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): hack to avoid bad RenderBlock::layout code
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): don't use RenderSVGContainer::layout()
- 8:08 AM Changeset in webkit [26495] by
-
- 2 edits in trunk/WebCore
30%+ performance improvement for svg embedded in xhtml
Reviewed by Eric.
Relayout internal to SVG was incorrectly being propagated to
the containing xhtml element, which subsequently resulted in
a full paint of the SVG, rather than just the dirty regions.
- rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):
- 8:07 AM Changeset in webkit [26494] by
-
- 7 edits5 adds in trunk
2007-10-03 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12310
Remove static variables from removeAllChildren causing crash.
removeAllChildren now iterates over the entire tree instead of recursing.
Also (according to Maciej) a possible 1-2% speedboost on HTML iBench.
Test: fast/images/svg-background-crash-on-refresh.html
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::addChildNodesToDeletionQueue): (WebCore::ContainerNode::removeAllChildren): use new addChildNodesToDeletionQueue
- 8:06 AM Changeset in webkit [26493] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix Windows build bustage once and for all. Feature branch builds on Windows now.
- 8:05 AM Changeset in webkit [26492] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix Windows build bustage once and for all. Feature branch builds on Windows now.
- 8:04 AM Changeset in webkit [26491] by
-
- 2 edits in trunk/WebKit
Reviewed by Mark Rowe.
Mac build fix for issue introduced in r26027
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 8:02 AM Changeset in webkit [26490] by
-
- 2 edits in trunk/WebKit/win
Fix Windows build bustage. Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.
- 8:01 AM Changeset in webkit [26489] by
-
- 2 edits in trunk/WebKit/win
Fix Windows build bustage. Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.
- 8:00 AM Changeset in webkit [26488] by
-
- 4 edits in trunk/WebCore
Fix more SVG build bustage on Windows. Remove a deleted file from the project. Remove a const from an unimplemented mask method.
- 7:59 AM Changeset in webkit [26487] by
-
- 1 edit in trunk/WebCore/bindings/js/JSSVGPODTypeWrapper.h
Fix UChar ambiguity in SVG code that keeps Windows from compiling the feature branch.
- 7:57 AM Changeset in webkit [26486] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix windows build bustage on feature branch.
- 7:56 AM Changeset in webkit [26485] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix windows build bustage on feature branch.
- 7:55 AM Changeset in webkit [26484] by
-
- 48 edits1 copy15 adds in trunk/WebCore
Land support for the CSS @font-face rule. This patch allows custom fonts
to be downloaded from the Web and rendered in Web pages. Right now only
TrueType fonts are supported. Proprietary formats like .eot are not
supported.
Reviewed by Eric Seidel
Many tests will be coming in a future landing.
- WebCore.base.exp: Expose some more stuff for WebKit, caused by font restructuring.
- WebCore.xcodeproj/project.pbxproj: Add all the new font face files.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Make sure to ignore the 'src' property of @font-face rules.
- css/CSSFontFace.cpp: Added. (WebCore::CSSFontFace::CSSFontFace): (WebCore::CSSFontFace::~CSSFontFace): (WebCore::CSSFontFace::isLoaded): (WebCore::CSSFontFace::isValid): (WebCore::CSSFontFace::addSource): (WebCore::CSSFontFace::fontLoaded): (WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h: Added. A CSSFontFace is a composite object. It consists of multiple font-face sources, where each source represents either a remote or local file in a @font-face rule's src list.
- css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::setDeclaration): (WebCore::CSSFontFaceRule::cssText):
- css/CSSFontFaceRule.h: The implementation of the @font-face rule itself in the CSS sheet back end.
- css/CSSFontFaceSource.cpp: Added. (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::~CSSFontFaceSource): (WebCore::CSSFontFaceSource::pruneTable): (WebCore::CSSFontFaceSource::isLoaded): (WebCore::CSSFontFaceSource::isValid): (WebCore::CSSFontFaceSource::fontLoaded): (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h: Added. (WebCore::CSSFontFaceSource::string): (WebCore::CSSFontFaceSource::setFontFace): A font face source represents a single remote or local font. If it represents a remote font than it wraps a CachedFont.
- css/CSSFontFaceSrcValue.cpp: Added. (WebCore::CSSFontFaceSrcValue::isSupportedFormat): (WebCore::CSSFontFaceSrcValue::cssText):
- css/CSSFontFaceSrcValue.h: Added. (WebCore::CSSFontFaceSrcValue::m_isLocal): (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue): (WebCore::CSSFontFaceSrcValue::resource): (WebCore::CSSFontFaceSrcValue::format): (WebCore::CSSFontFaceSrcValue::isLocal): (WebCore::CSSFontFaceSrcValue::setFormat): Used in parsing. Represents the parsed form of the src value that can then be used to build up a CSSFontFace.
- css/CSSFontSelector.cpp: Added. (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector): (WebCore::CSSFontSelector::isEmpty): (WebCore::CSSFontSelector::docLoader): (WebCore::hashForFont): (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::CSSFontSelector::fontLoaded): (WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h: Added. The CSS font selector is the object that selects the correct font given a specified font family. It builds up a database of CSSFontFaces that can then be handed back.
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::createFontFaceRule):
- css/CSSParser.h: Modify the CSS grammar to now understand @font-face rules.
- css/CSSPropertyNames.in: Add the src property.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::ensureFontSelector):
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector): The style selector now creates a font selector object and feeds it the appropriate information when @font-face rules are encountered.
- dom/Document.cpp: (WebCore::Document::recalcStyle): Patch the update method now that it takes a font selector argument.
- loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
- loader/Cache.h: Teach the Cache about CachedFonts.
- loader/CachedFont.cpp: Added. (WebCore::CachedFont::CachedFont): (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ref): (WebCore::CachedFont::data): (WebCore::CachedFont::beginLoadIfNeeded): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved): (WebCore::CachedFont::checkNotify): (WebCore::CachedFont::error):
- loader/CachedFont.h: Added. (WebCore::CachedFont::schedule): The implementation of CachedFont. This represents the downloaded resource and has all the raw font data.
- loader/CachedResource.h: (WebCore::CachedResource::):
- loader/CachedResourceClient.h: (WebCore::CachedResourceClient::fontLoaded): Add a new fontLoaded method for clients of cached resources to track when fonts finish downloading.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestFont):
- loader/DocLoader.h: Add the ability to request a font.
- platform/Font.cpp: (WebCore::Font::operator==): (WebCore::Font::update): (WebCore::Font::drawText):
- platform/Font.h:
- platform/FontCache.cpp: (WebCore::FontCache::getFontData):
- platform/FontCache.h:
- platform/FontData.cpp: (WebCore::FontData::FontData):
- platform/FontData.h: (WebCore::FontData::isCustomFont): (WebCore::FontData::isLoading):
- platform/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::fontDataAt):
- platform/FontFallbackList.h: (WebCore::FontFallbackList::loadingCustomFonts): (WebCore::FontFallbackList::fontSelector):
- platform/FontSelector.h: Added. (WebCore::FontSelector::~FontSelector):
- platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::getRoot): (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::~GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::initializePage): (WebCore::GlyphPageTreeNode::getChild): (WebCore::GlyphPageTreeNode::pruneCustomFontData):
- platform/GlyphPageTreeNode.h: (WebCore::GlyphPageTreeNode::GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::page):
- platform/PopupMenuClient.h:
- platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists): (WebCore::FontCache::createFontPlatformData):
- platform/mac/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/mac/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/mac/FontDataMac.mm: (WebCore::initFontData): (WebCore::FontData::platformInit): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::platformWidthForGlyph): (WebCore::FontData::checkShapesArabic):
- platform/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::Font::drawGlyphs):
- platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
- platform/mac/FontPlatformDataMac.mm: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::setFont):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/win/FontCacheWin.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):
- platform/win/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::getData): (WebCore::releaseData): (WebCore::getBytesWithOffset): (WebCore::createFontCustomPlatformData):
- platform/win/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch):
- platform/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
- platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Changes to platform to support rendering of custom fonts. Too large to go into, but for ports, the relevant object to implement is FontCustomPlatformData (to get the data loaded into your native font format), and then you have to patch your other font objects to know how to use the font.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::fontSelector):
- rendering/RenderMenuList.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::fontSelector):
- rendering/RenderTextControl.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::setFontFromControlSize): Patches for update now taking a font selector argument.
- 7:54 AM Changeset in webkit [26483] by
-
- 3 edits in trunk/WebCore
Reviewed by Eric.
Remove unneeded code and other cleanups.
- 7:52 AM Changeset in webkit [26482] by
-
- 3 edits4 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15260
Any styles defined after <element> {<property>:%} style are ignored by Safari
Add dummy rule to skip constructions like width: %.
- 7:51 AM Changeset in webkit [26481] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Olliej.
Adapt to changed location of Ahem font.
- 7:50 AM Changeset in webkit [26480] by
-
- 10 edits in trunk/WebCore
2007-10-03 Mark Rowe <mrowe@apple.com>
Reviewed by Lars.
Get Gtk+ port building on the feature branch.
- WebCore.pro:
- ksvg2/svg/SVGSVGElement.cpp:
- platform/graphics/svg/cairo/RenderPathCairo.cpp: (WebCore::RenderPath::strokeContains):
- platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath):
- platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):
- platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
- rendering/SVGCharacterLayoutInfo.cpp:
- rendering/SVGInlineTextBox.cpp:
- rendering/SVGRootInlineBox.cpp:
- 7:48 AM Changeset in webkit [26479] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15102
XMLHttpRequests should dispatch a readystatechange event.
Test: http/tests/xmlhttprequest/readystatechange.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): Added readystatechange event support. Fixed the function to dispatch the same event to all listeners instead of creating a new copy for each one. Changed bubbling/cancelability of load and readystatechange events to match Firefox.
- 7:47 AM Changeset in webkit [26478] by
-
- 5 edits3 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10370
RegExp fails to match non-ASCII characters against [\S\s]
Test: fast/js/regexp-negative-special-characters.html
- pcre/pcre_compile.c: (compile_branch): Adjust opcode and bitmap as necessary to include (or exclude) character codes >255. Fix suggested by Philip Hazel.
- pcre/pcre_exec.c: (match): Merged fix for PCRE bug 580 (\S\S vs. \S{2}).
- tests/mozilla/expected.html: One test was fixed.
- pcre/MERGING: Added information about this fix.
- 7:45 AM Changeset in webkit [26477] by
-
- 6 edits2 adds in trunk
2007-10-02 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
http://bugs.webkit.org/show_bug.cgi?id=13828
Fixes svg/custom/rootmost-svg-xy-attrs.xhtml
- WebCore.xcodeproj/project.pbxproj: fix warning about SVGDOM.h
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): use new isOutermostSVG() (WebCore::SVGSVGElement::getCTM): use isOutermostSVG() (WebCore::SVGSVGElement::getScreenCTM): use isOutermostSVG() (WebCore::SVGSVGElement::createRenderer): use isOutermostSVG() (WebCore::SVGSVGElement::isOutermostSVG):
- ksvg2/svg/SVGSVGElement.h: add isOutermostSVG
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport): ignore x/y
- 7:44 AM Changeset in webkit [26476] by
-
- 3 edits in trunk/WebCore
Reviewed by Mitz.
- Avoid uselessly serializing CSS property values on replacement for 10% CK DOM speedup http://bugs.webkit.org/show_bug.cgi?id=15340
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): Don't generate return value unless needed. (WebCore::CSSMutableStyleDeclaration::setProperty): Use the no-return version appropriately.
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::removeProperty): New version with no return value.
- 7:43 AM Changeset in webkit [26475] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- skip extra hash lookup and avoid converting char* to UString for 19% speedup on CK JS array test http://bugs.webkit.org/show_bug.cgi?id=15350
- kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement the two mentioned optimizations.
- 7:41 AM Changeset in webkit [26474] by
-
- 8 edits in trunk
WebCore:
Reviewed by Oliver.
- Use Vector<UChar> instead of DeprecatedString for innerHTML, for 35% speedup on CK DOM test http://bugs.webkit.org/show_bug.cgi?id=15339
Rewrote both versions of createMarkup to build based on
Vector<UChar> instead of String. Also other miscellaneous
speedups (mainly content strings are now encoded in a way that
doesn't take a function call per character, and switch is avoided).
This also causes a functional change - we no longer escape '>' since this was unnecessary and it's faster
to avoid testing for it. See updated test results.
- editing/markup.cpp: (WebCore::appendString): (WebCore::appendAttributeValue): (WebCore::escapeContentText): (WebCore::appendEscapedContent): (WebCore::appendDeprecatedString): (WebCore::appendQuotedURLAttributeValue): (WebCore::stringValueForRange): (WebCore::ucharRange): (WebCore::appendUCharRange): (WebCore::appendNamespace): (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::appendEndMarkup): (WebCore::getEndMarkup): (WebCore::appendMarkup): (WebCore::joinMarkups): (WebCore::createMarkup):
- editing/markup.h:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge markupStringFromNode:nodes:]): (-[WebCoreFrameBridge markupStringFromRange:nodes:]):
LayoutTests:
Reviewed by Oliver.
- test updates for "file:///Volumes/Data/mjs/Work/src/Safari/OpenSource/LayoutTests/fast/dom/serialize-attribute.xhtml" http://bugs.webkit.org/show_bug.cgi?id=15339
We no longer entity-escape the '>' character in content or attribute values since this is unnecessary.
- fast/dom/dom-parse-serialize-expected.txt:
- fast/dom/serialize-attribute.xhtml:
- fast/xsl/xslt-processor-expected.txt:
- 7:40 AM Changeset in webkit [26473] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Mark.
- Efficiently handle regexp property identifiers for 19% speedup on Celtic Kane regexp test http://bugs.webkit.org/show_bug.cgi?id=15337
- kjs/CommonIdentifiers.h:
- kjs/regexp_object.cpp: (RegExpProtoFunc::callAsFunction): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::construct):
- 7:38 AM Changeset in webkit [26472] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark.
- Cache global prorotypes more efficiently for 10% speedup on CK AJAX benchmark http://bugs.webkit.org/show_bug.cgi?id=15335
- kjs/lookup.h:
- 7:37 AM Changeset in webkit [26471] by
-
- 1 edit in trunk/WebCore/ChangeLog
Updated last ChangeLog entry to indicate speedup:
(65% speedup on Celtic Kane JS 2007 DOM test)
- 7:35 AM Changeset in webkit [26470] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric.
- fixed "innerHTML updates layout every time (very bad if adding to it in a loop)" http://bugs.webkit.org/show_bug.cgi?id=15326
- editing/markup.cpp: (WebCore::createMarkup): The Node version of this function currently never uses the render tree, so don't bother to update layout. This is the version used for innerHTML.
- 7:34 AM Changeset in webkit [26469] by
-
- 4 edits4 adds in trunk
2007-10-02 Nicholas Shanks <webkit@nickshanks.com>
Reviewed by eseidel & hyatt.
Add support for CSS3 values 'start' and 'end' to text-align property.
- css/cssparser.cpp: (WebCore::CSSParser::parseValue): allow start and end values
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): handle start and end values
- 7:32 AM Changeset in webkit [26468] by
-
- 5 edits4 adds in trunk/LayoutTests
2007-10-02 Eric Seidel <eric@webkit.org>
Rubber-stamped by Maciej.
Updating test results after feature-branch rebase for tests whose new results are more correct.
Also adding a few missing pixel test results.
- fast/dom/attribute-case-sensitivity-expected.txt:
- fast/dom/attribute-case-sensitivity2-expected.txt:
- fast/layers/scroll-rect-to-visible-expected.png:
- fast/text/international/bidi-neutral-run-expected.png:
- platform/mac/editing/pasteboard/5478250-expected.checksum: Added.
- platform/mac/editing/pasteboard/5478250-expected.png: Added.
- svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
- svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
- svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
- svg/W3C-SVG-1.1/text-text-03-b-expected.png:
- svg/batik/text/textEffect-expected.png:
- svg/batik/text/textEffect3-expected.png:
- svg/custom/js-late-gradient-and-object-creation-expected.png:
- svg/custom/use-infinite-recursion-expected.checksum: Added.
- svg/custom/use-infinite-recursion-expected.png: Added.
- 7:31 AM Changeset in webkit [26467] by
-
- 2 edits in trunk/LayoutTests
Correcting expected layout test results
RS = Eric
- fast/dom/Window/window-properties-expected.txt:
- fast/images/svg-as-image-expected.txt:
- 7:29 AM Changeset in webkit [26466] by
-
- 2 edits1 delete in trunk/WebKitTools
Roll out previous change as made layout-test-results unusable with large tables
- 7:27 AM Changeset in webkit [26465] by
-
- 2 edits2 adds in trunk/WebKitTools
2007-10-02 Eric Seidel <eric@webkit.org>
Reviewed by Sam Wenig.
Make layout results table sortable (using sorttable.js)
- Scripts/resources: Added.
- Scripts/resources/sorttable.js: Added.
- Scripts/run-webkit-tests:
- 7:26 AM Changeset in webkit [26464] by
-
- 3 edits in trunk/WebKitTools
2007-10-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Make pixel tests more useful!
Finally fix the image diff 0.00% mystery problem
Highlight any image differences in the image diff.
Add a link from image diffs back to original test file.
- DumpRenderTree/mac/ImageDiff.m: (compareImages): highlight any differences (computePercentageDifferent): round to two decimal places
- Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
- 7:24 AM Changeset in webkit [26463] by
-
- 2 edits in trunk/WebKitTools
2007-10-02 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
- Scripts/run-webkit-tests: print the % image difference on main results page
- 7:23 AM Changeset in webkit [26462] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2007-10-02 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
- BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
- WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
- 7:21 AM Changeset in webkit [26461] by
-
- 4 edits10 adds in trunk
2007-10-01 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
SVG Subresources will not be saved when creating WebArchives
http://bugs.webkit.org/show_bug.cgi?id=15280
Implement _subresourceURLs methods for more SVGElement types
more such methods will be needed as we add support for other
external references (such as use, mpath, tref, etc.)
- DOM/WebDOMOperations.mm: (-[DOMSVGScriptElement _subresourceURLs]): added. (-[DOMSVGCursorElement _subresourceURLs]): added. (-[DOMSVGFEImageElement _subresourceURLs]): added.
- 7:19 AM Changeset in webkit [26460] by
-
- 3 edits3 adds in trunk
2007-10-01 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
WebArchives do not embed stylesheets referenced by xml-stylesheeet
http://bugs.webkit.org/show_bug.cgi?id=15320
- DOM/WebDOMOperations.mm: (-[DOMProcessingInstruction _stylesheetURL]): needed to access [[self sheet] href] (-[DOMProcessingInstruction _subresourceURLs]): call and return _stylesheetURL
- 7:18 AM Changeset in webkit [26459] by
-
- 9 edits2 moves1 add in trunk
2007-10-01 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
This only affects Debug builds, and the ability to save SVGs as WebArchives
neither are testable via DumpRenderTree.
- Configurations/WebCore.xcconfig: change where Xcode looks for WebCore.exp
- DerivedSources.make: adds SVG symbols to WebCore.exp when necessary
- WebCore.SVG.exp: Added.
- WebCore.exp: moved to WebCore.base.exp
- WebCore.xcodeproj/project.pbxproj: updated to reflect moved files
- bindings/objc/DOMSVGExecption.h: moved to DOMSVGException.h
- 7:16 AM Changeset in webkit [26458] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2007-10-01 Mark Rowe <mrowe@apple.com>
- BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
- 7:14 AM Changeset in webkit [26457] by
-
- 6 edits in trunk
Enable Experimental SVG features by default when building from Xcode
Reviewed by Mark
- Configurations/JavaScriptCore.xcconfig:
- Configurations/WebCore.xcconfig:
- Configurations/WebKit.xcconfig:
- 7:13 AM Changeset in webkit [26456] by
-
- 19 edits in trunk/WebCore
2007-10-01 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Make feature-branch build again with ENABLE_SVG_EXPERIMENTAL_FEATURES
Needed a double -> float change to make the new filter types build.
Build fix, no test cases.
- ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
- ksvg2/svg/SVGComponentTransferFunctionElement.h:
- ksvg2/svg/SVGFECompositeElement.cpp:
- ksvg2/svg/SVGFECompositeElement.h:
- ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
- ksvg2/svg/SVGFEDiffuseLightingElement.h:
- ksvg2/svg/SVGFEDisplacementMapElement.cpp:
- ksvg2/svg/SVGFEDisplacementMapElement.h:
- ksvg2/svg/SVGFEGaussianBlurElement.cpp:
- ksvg2/svg/SVGFEGaussianBlurElement.h:
- ksvg2/svg/SVGFELightElement.cpp:
- ksvg2/svg/SVGFELightElement.h:
- ksvg2/svg/SVGFEOffsetElement.cpp:
- ksvg2/svg/SVGFEOffsetElement.h:
- ksvg2/svg/SVGFESpecularLightingElement.cpp:
- ksvg2/svg/SVGFESpecularLightingElement.h:
- ksvg2/svg/SVGFETurbulenceElement.cpp:
- ksvg2/svg/SVGFETurbulenceElement.h:
- 7:11 AM Changeset in webkit [26455] by
-
- 3 edits2 adds in trunk
2007-09-30 Julien <julien.chaffraix@gmail.com>
Reviewed by aroben & eseidel.
getAllResponseHeaders() separates each header with a CR LF according to the specification
Test: http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders):
- 7:09 AM Changeset in webkit [26454] by
-
- 5 edits in trunk
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=13472
Misparsing date in javascript leads to year value of -1
http://bugs.webkit.org/show_bug.cgi?id=14176
Some date values not handled consistently with IE/Firefox
Allow an optional comma between month and year, and year and time.
- 7:07 AM Changeset in webkit [26453] by
-
- 3 edits2 adds in trunk
2007-09-28 Eric Seidel <eric@webkit.org>
Reviewed by Sam Wenig.
ASSERT when dragging <svg:image> with non-null prefix
http://bugs.webkit.org/show_bug.cgi?id=15308
- bindings/objc/DOM.mm: (WebCore::lookupElementClass): added (WebCore::elementClass): use new lookupElementClass function
- 7:06 AM Changeset in webkit [26452] by
-
- 2 edits in trunk/WebCore
2007-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
I managed to break the SVG build when fixing the --no-svg build for
http://bugs.webkit.org/show_bug.cgi?id=15281
This adds the appropriate DOMSVG headers to the copy headers phase
(in fixing the no-svg build I mistakenly re-marked them project-only)
- WebCore.xcodeproj/project.pbxproj:
- 7:04 AM Changeset in webkit [26451] by
-
- 2 edits in trunk/WebKitTools
2007-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
DerivedSources.make was finding "ENABLE_SVG" in the string
"ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
quite correctly.
- Scripts/build-webkit: make --no-svg imply --no-svg-experimental
- 7:02 AM Changeset in webkit [26450] by
-
- 2 edits in trunk/WebCore
2007-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Rob Bius.
Already tested by SVG/W3C-SVG-1.1/linking-a-07-t.svg
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): properly pass along target values
Correct the spelling of Rob's name
- 7:00 AM Changeset in webkit [26449] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2007-09-25 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Eric.
- BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line. This makes it possible to automate nightly builds for the feature-branch.
- 6:58 AM Changeset in webkit [26448] by
-
- 10 edits24 adds in trunk
Reviewed by Oliver.
Rework <pattern> support to take overflow & viewBox into account.
Also fix all possible combinations of patternUnits/patternContentUnits, tested by several batik testcases.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12221 (Webkit ToT fails to render this pattern example)
Reviewed by NOBODY (Build fix).
- platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
- 6:57 AM Changeset in webkit [26447] by
-
- 8 edits1 move8 adds in trunk
Reviewed by Oliver.
Fix <mask> in userSpaceOnUse coordinates. Verified by new testcase taken from Batik.
Reviewed by Anders.
Fix paths to css style sheets in the last added files. Enable smallFonts.svg as it doesn't crash anymore.
Fix paths to external <use> element reference, to make Batik happy. (We don't support it, yet.)
- 6:55 AM Changeset in webkit [26446] by
-
- 20 edits in trunk/WebCore
Reviewed by Oliver.
Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.
This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)
Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).
(Oops, forgot to commit WebCore/ changes!)
Reviewed by Oliver.
Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.
This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)
Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).
- 6:53 AM Changeset in webkit [26445] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz.
Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.
- 6:51 AM Changeset in webkit [26444] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by NOBODY (Build fix).
Initialise iterators to appease gcc
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):
- 6:49 AM Changeset in webkit [26443] by
-
- 10 edits5 adds in trunk
Reviewed by Sam.
http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)
Reuse the css parser as much as possible in setRGBColor.
Rubberstamped by Mark.
Add missing SVG filter testcase (forgot to include in last commit).
- 6:47 AM Changeset in webkit [26442] by
-
- 136 edits in trunk
Reviewed by Oliver.
Large SVG filter rework. Bring it back in a useable state.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)
filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.
In detail:
- flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
- sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
- add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
- WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
- Correctly specify default values for all filter primitives in ksvg2/svg!
- Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
- Fix 'flood-color' initial value (was set to the _stop_ color initial value)
-> both initial values were pointing to 'black' though, so it was no visible problem.
- Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.
-> Correct it's initial from black to white value fixes SVG lighting filters!
- Add diffuseConstant support to feDiffuseLighting filter.
- Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)
- 6:45 AM Changeset in webkit [26441] by
-
- 3 edits4 adds in trunk
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly
Use the bounding box before transformation.
- 6:43 AM Changeset in webkit [26440] by
-
- 24 edits4 adds in trunk
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=14926
WebKit has 'em' length handling problems related to CSS properties
Parse the properties in inline style attributes non-strict for SVG.
- 6:41 AM Changeset in webkit [26439] by
-
- 4 edits4 adds in trunk
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=14927
use element in SVG does not render after parent is displayed off and on
Also detach the shadow tree when detaching the <use>.
- 6:39 AM Changeset in webkit [26438] by
-
- 14 edits2 adds in trunk
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14153
Final, long-awaited RenderSVGContainer split. Make RenderSVGContainer really a simple
container without special cases for inner <svg> elements or <marker>. Create a new
RenderSVGViewportContainer class handling these cases now.
- 6:37 AM Changeset in webkit [26437] by
-
- 25 edits8 adds in trunk
Reviewed by Oliver & Rob.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12501 (SVG Text fails to respect opacity, fill-opacity and stroke-opacity)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14045 (Incorrect support for opacity, fill-opacity and stroke-opacity)
Based on an older patch from Rob, this fixes SVG text opacity as well as group opacity for solid fills & gradients.
The pattern changes are still missing a testcase (need to wait for Antoine Quint for that).
- 6:34 AM Changeset in webkit [26436] by
-
- 4 edits8 adds in trunk
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=11909
Regression: large SVG from Illustrator comes out blank
Fix last issue with the Illustrator file by making relativeBBox
calculation take into account viewBox.
- 6:32 AM Changeset in webkit [26435] by
-
- 44 edits in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14896 (SVG InlineText/Flow box sizes don't take rotated glyphs into account)
Introduce new helper function calculateGlyphBoundaries, which takes into account any per-character transformation.
This fixes box size calculations in svg/W3C-SVG-1.1/text-text-07-t.svg, svg/batik/text/textEffect3.svg (rotated glyphs)
-> These strings can be properly selected now, just as well as text path elements.
- 6:30 AM Changeset in webkit [26434] by
-
- 64 edits in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13909 (SVG text selection doesn't work with RTL text)
Use drawHighlightForText() to draw the selection, instead of my home-brewn solution.
Affected code in SVGRootInlineBox::paintSelectionForTextBox. Removed not anymore needed
helper function cummulatedWidthOfSelectionRange.
Dump all contained InlineTextBox(es) in SVGRenderTreeAsText, take into account multiple
child text boxes in ie. a RenderSVGInlineText objects (which happens for RTL text and
LTR text cases where newlines were involved - see changed testcase results.)
This affects a lot of LTR tests which actually had more than one child text box, that
wasn't taken properly into account before (in terms of selection, not rendering.)
Fix selection for RTL text by taking box start offsets into account in closestCharacterToPosition()
and by offering RTL text selection special cases in svgCharacterHitsPosition().
Centralized the creation of a TextStyle object for text selection/painting in a new helper function
svgTextStyleForInlineTextBox. Add new helper functions calculateGlyphWidth/calculateGlyphHeight to
centralize these calculations -> use these new helpers everywhere to avoid code duplication.
A single fix in bidi.cpp was needed to fix SVG's unicode-bidi/direction handling, to fix text-intro-02-b.svg.
SVG didacts that the 'direction' attribute is ignored if unicode-bidi is set to 'normal' (default).
Discussed with Mitz.
- 6:28 AM Changeset in webkit [26433] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Do not export some symbols for internal functions, saves some bytes.
- 6:25 AM Changeset in webkit [26432] by
-
- 70 edits in trunk
Reviewed by Oliver & Rob.
Enable SVG textPath selection. Actually build chunks for them instead of
ignoring them - was easier than I thought. Respect per-character transformation
when calculating the chunk boundaries for the selection rectangles. Also fixes
selection rect drawing of rotated characters.
Next thing todo is to unify the glyph size calculations, as per-glyph transformations
are not respected when calculating flow box sizes in SVGRootInlineBox.
- 6:23 AM Changeset in webkit [26431] by
-
- 3 edits4 adds in trunk
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=14312
Removing an attribute has no effect on SVG
Update the transform matrix also when transform attribute is empty.
- 6:21 AM Changeset in webkit [26430] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.
- 6:18 AM Changeset in webkit [26429] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam.
Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.
- 6:16 AM Changeset in webkit [26428] by
-
- 12 edits105 adds in trunk
Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)
- 6:13 AM Changeset in webkit [26427] by
-
- 28 edits31 adds in trunk
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=5996
SVG <view> is unimplemented
Implement <view> and refactor the code in the svg renderer container classes.
Build fix. Not reviewed.
Rob forgot to land the changes to SVGResourceMarker in his last commit.
- 6:11 AM Changeset in webkit [26426] by
-
- 8 edits16 adds in trunk
Reviewed by Rob.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13611 (Crash in setAttributeNS setting href of SVG <use> to nonexistent symbol)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14631 (<use> doesn't deep-expand <symbol> elements.)
Rework <use> on <foreignObject> cases, to not just ignore these cases, but actually proceed and skip <fO> objects
from the resulting cloned tree. This fixes parts of "treasure_map.svg" (no bug report availabe on that one, private "testcase").
Fix assertion happening with <use> on <g> containing <symbol>. Introduce expandSymbolElementsInShadowTree()
concept, just like it's done for <use> on <use>, to deep-replace all <symbol> elements by <svg>, as demanded
by the spec. This only worked on <use> on <symbol> direct cases so far.
- 6:08 AM Changeset in webkit [26425] by
-
- 4 edits in trunk
Reviewed by Rob.
Fix invisible-text-after-scrolling.xhtml regression. Scroll offset not
taken into account properly. Also fix RenderSVGInlineText::selectionRect(),
so that SVG text can be selected, when being embedded in XHTML.
- 6:06 AM Changeset in webkit [26424] by
-
- 77 edits8 adds in trunk
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5940 (<svg> inside <body> incorrectly extends over top/bottom borders)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14145 (RenderSVGContainer should not inherit from RenderContainer)
Make RenderSVGContainer inherit from RenderObject directly, instead of RenderContainer.
Itdoes a lot of things that we don't need for SVG, and by removing this inheritance
we can finally fix the differences about SVG object positioning, as we don't need
parent translation (tx/ty). Fixes SVG text rendering within XHTML.
Fix requireLayer() function on RenderSVGRoot, as it can actually be a layer now.
This change is based on Rob's patch at 5940 - fixing z-order indexing.
Change RenderSVGRoot renderName() and update all layout tests, because of this change.
Fix absoluteRects() function for RenderSVGInlineText & RenderSVGTSpan.
Checked extensively using WebInspector, to assure all rects are correctly displayed.
Testcases fixed: junk-data.svg, missing-xlink.svg hixie/013.xml (all regressions!)
(junk-data.svg & missing-xlink.svg previously relied on SVG text painting out of <svg> overflow rect.
Fix these testcases, as within this new RenderSVGContainer concept, that bug is now fixed, and breaks them)
Testcases added: custom/absolute-sized-svg-in-xhtml.xhtml, custom/inline-svg-in-xhtml.xml (Mozilla XTech demo)
- 6:03 AM Changeset in webkit [26423] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Reviewed by Mark.
Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
- 6:01 AM Changeset in webkit [26422] by
-
- 12 edits in trunk
Rubber stamped by Mark.
WebKitTools:
Enable svg experimental features as default here in feature-branch.
LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.
- 5:58 AM Changeset in webkit [26421] by
-
- 33 edits in trunk
WebCore:
Reviewed by Sam.
Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)
This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.
Add bug number reference missing in the last ChangeLog entry.
LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.
Conflicts:
WebCore/bindings/scripts/CodeGeneratorJS.pm
WebCore/ksvg2/svg/SVGPathSegList.cpp
WebCore/ksvg2/svg/SVGPathSegList.h
- 5:55 AM Changeset in webkit [26420] by
-
- 19 edits1 copy4 adds in trunk
Reviewed by Sam.
Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.
Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.
Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg
Forgot to commit the ChangeLog and two files in my last commit!
- 5:53 AM Changeset in webkit [26419] by
-
- 2 edits in trunk/LayoutTests
Correcting the pixel test result that was supposed to go in during r23849.
- 5:50 AM Changeset in webkit [26418] by
-
- 2 edits in trunk/WebKitTools
Add VIDEO build flag
- 5:47 AM Changeset in webkit [26417] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Use intHash to hash floats and doubles too.
- ChangeLog:
- wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
- wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):
- 5:45 AM Changeset in webkit [26416] by
-
- 4 edits4 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image
Keep extra member vars to get width/height as floats for accurate
calculations.
- 5:42 AM Changeset in webkit [26415] by
-
- 4 edits1 move3 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test
Refuse to render zero or negative width/height.
- 5:39 AM Changeset in webkit [26414] by
-
- 8 edits8 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly
Implement fallback for fill and stroke.
- 5:37 AM Changeset in webkit [26413] by
-
- 3 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=14157
Rotated shape has wrong gradient rendering
Use the untransformed bbox in objectBoundingBoxMode. Also
don't do objectBoundingBoxMode should the bbox width ort height
be zero.
- 5:34 AM Changeset in webkit [26412] by
-
- 12 edits20 adds in trunk
Reviewed by Eric & Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14198
Reeanble <foreignObject>. Explicitely disallow <use> on <foreignObject>
as it may lead to bad problems.
While I'm at it disallow <use> on any non-svg element.
Not reviewed.
Forgot to commit new layout tests results, now that <foreignObject> is enabled again.
- 5:31 AM Changeset in webkit [26411] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=14144
All tx/ty (parentX/parentY) usage should be removed from SVG renders
http://bugs.webkit.org/show_bug.cgi?id=13981
<br> prevents click handler from firing
Fix the hit testing issues by making RenderSVGRoot take its m_x, m_y
into account in the absolute transform.
- 5:28 AM Changeset in webkit [26410] by
-
- 19 edits9 adds in trunk
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)
Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)
This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).
- 5:25 AM Changeset in webkit [26409] by
-
- 4 edits4 adds in trunk
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14155
JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.
- 5:22 AM Changeset in webkit [26408] by
-
- 2 edits in trunk/WebCore
2007-06-15 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Fix the release build.
- rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):
- 5:19 AM Changeset in webkit [26407] by
-
- 3 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=14051
<svg:image> fails to position correctly when <svg> is inside an inline <div>
Leave parent translation to the containers.
- 5:16 AM Changeset in webkit [26406] by
-
- 5 edits in trunk/WebCore
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13963
Fix SVG space invaders. It actually highlighted a bad problem with our JSSVGPODTypeWrapper's.
Introduce a new "2nd-level cache" for all readwrite POD properties. Subsequent calls to ie.
myRect.x.baseVal.value don't create a new wrapper everytime, but are properly cached now.
This leads to a massive reduction in created wrappers.
- 5:05 AM Changeset in webkit [26405] by
-
- 4 edits in trunk/WebCore
2007-06-14 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Text gradients are broken on feature branch
http://bugs.webkit.org/show_bug.cgi?id=14142
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
- rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes): (WebCore::SVGRootInlineBox::paintChildInlineTextBox): (WebCore::SVGRootInlineBox::paintChildInlineFlowBox):
- rendering/SVGRootInlineBox.h:
- 5:02 AM Changeset in webkit [26404] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11273
Implement pixelUnitToMillimeterX(), pixelUnitToMillimeterY() in SVGSVGElement.
Use cssPixelsPerInch, just like done in CSSPrimitiveValue & SVGLength.
- 4:59 AM Changeset in webkit [26403] by
-
- 2 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=9752
%-sizing of elements with a html parent is broken
Calculate width/height for length percentages when embedded in xhtml.
- 4:56 AM Changeset in webkit [26402] by
-
- 20 edits2 copies2 deletes in trunk/WebCore
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=12207
RenderSVGContainer should be split into multiple classes
http://bugs.webkit.org/show_bug.cgi?id=14125
KCanvasRenderingStyle should be removed
Introduce the RenderSVGRoot class and kill the KCanvas enums.
Build fix.
- 4:52 AM Changeset in webkit [26401] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric.
Fix regression: SVG images drawn in the wrong paint phase.
- 4:49 AM Changeset in webkit [26400] by
-
- 3 edits4 adds in trunk
Reviewed by weinig.
http://bugs.webkit.org/show_bug.cgi?id=14064
fill property is reported as type SVGColor
Do the checks in the right order.
Change merged into WebCore/bindings/js/JSCSSValueCustom.cpp
- 4:45 AM Changeset in webkit [26399] by
-
- 8 edits in trunk/WebCore
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=12122
SVGPathElement should not inherit from SVGPathParser
Use path builders for building Path and PathSegLists.
- 4:42 AM Changeset in webkit [26398] by
-
- 4 edits in trunk/WebCore
2007-06-06 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.
http://bugs.webkit.org/show_bug.cgi?id=8823
Layout test is blocked by http://bugs.webkit.org/show_bug.cgi?id=14027
- css/svg.css:
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
- ksvg2/svg/SVGAElement.h:
- 4:39 AM Changeset in webkit [26397] by
-
- 9 edits4 adds in trunk
2007-06-06 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Make SVG (mostly) support CSS outline property (and thus focus rings)
http://bugs.webkit.org/show_bug.cgi?id=10849
Test: svg/custom/focus-ring.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::addFocusRingRects):
- rendering/RenderSVGImage.h:
- 4:36 AM Changeset in webkit [26396] by
-
- 7 edits2 adds in trunk/WebCore
2007-06-06 Eric Seidel <eric@webkit.org>
Reviewed by weinig.
Break out common SVG rendering logic into prepareToRenderSVGContent in SVGRenderSupport
No test cases should be changed by this.
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::requiresLayer): (WebCore::RenderSVGContainer::isOutermostSVG): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::applyContentTransforms): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::viewportTransform): (WebCore::RenderSVGContainer::absoluteTransform):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translationForAttributes):
- rendering/SVGRenderSupport.cpp: Added. (WebCore::prepareToRenderSVGContent):
- rendering/SVGRenderSupport.h: Added.
- rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes):
- 4:32 AM Changeset in webkit [26395] by
-
- 6 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=13976
getPresentationAttribute not implemented
Implement getPresentationAttribute.
- 4:29 AM Changeset in webkit [26394] by
-
- 6 edits in trunk/WebCore
2007-06-06 Rob Buis <buis@kde.org>
Reviewed by olliej and eric.
http://bugs.webkit.org/show_bug.cgi?id=12430
SVG has two transform parsers when it should have one.
Refactor SVGTransformable parser so SVGAnimateTransformElement can reuse it better.
- ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
- ksvg2/svg/SVGAnimateTransformElement.h:
- ksvg2/svg/SVGTransformable.cpp: (WebCore::): (WebCore::SVGTransformable::parseTransformValue): (WebCore::SVGTransformable::parseTransformAttribute):
- ksvg2/svg/SVGTransformable.h:
- 4:26 AM Changeset in webkit [26393] by
-
- 10 edits in trunk
2007-06-01 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Add support for maskUnits and maskContentUnits
http://bugs.webkit.org/show_bug.cgi?id=12568
This is covered by the W3C tests (including mask-intro01)
- ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
- ksvg2/svg/SVGMaskElement.h:
- ksvg2/svg/SVGMaskElement.idl:
- platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
- platform/graphics/svg/SVGResourceMasker.h:
- platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
2007-06-05 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Commit files missing from previous commit, oops!
- platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
- platform/graphics/svg/SVGResourceMasker.h:
- platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
- 4:23 AM Changeset in webkit [26392] by
-
- 2 edits1 add in trunk/WebCore
2007-06-01 Eric Seidel <eric@webkit.org>
Reviewed by lars.
Cursor does not change to hand over links containing <use>
http://bugs.webkit.org/show_bug.cgi?id=12630
Test: manual-tests/svg-link-hover-use.svg
- manual-tests/svg-link-hover-use.svg: Added.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode
- 4:19 AM Changeset in webkit [26391] by
-
- 5 edits4 adds in trunk
2007-06-01 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
SVG is not correctly respecting scroll during hit testing
http://bugs.webkit.org/show_bug.cgi?id=13083
Test: svg/custom/scroll-hit-test.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):
- 4:16 AM Changeset in webkit [26390] by
-
- 4 edits5 adds in trunk
2007-06-01 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml
- dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
- dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):
- 4:13 AM Changeset in webkit [26389] by
-
- 3 edits in trunk
2007-05-31 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570
Test: svg/custom/prevent-default.svg
- html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
- ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
- 4:09 AM Changeset in webkit [26388] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement
Allow zooming and panning, thereby implementing the above methods.
- 4:09 AM BuildingQtOnWindows edited by
- (diff)
- 3:57 AM Changeset in webkit [26387] by
-
- 5 edits in trunk
Reviewed by Oliver.
Fix regression: gradient on fill of text works again!
- 3:53 AM Changeset in webkit [26386] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Fix "jumpy" selection by correcting the way svgCharacterHitsPosition works.
I basically mixed up the "closest character to position" logic.
- 3:50 AM Changeset in webkit [26385] by
-
- 41 edits in trunk
Reviewed by Oliver.
Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.
- 3:47 AM Changeset in webkit [26384] by
-
- 23 edits1 copy133 adds in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.
- 3:40 AM Changeset in webkit [26383] by
-
- 4 edits4 adds in trunk
2007-05-10 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
http://bugs.webkit.org/show_bug.cgi?id=11931
PathCG fails to hit on unclosed sub-paths
Test: svg/custom/hit-test-unclosed-subpaths.svg
- platform/graphics/cg/PathCG.cpp: (WebCore::copyClosingSubpathsApplierFunction): (WebCore::copyCGPathClosingSubpaths): (WebCore::Path::contains): use new copy & close function
- 3:36 AM Changeset in webkit [26382] by
-
- 9 edits in trunk
Add initial markers for feature-branch merge
- 3:23 AM Changeset in webkit [26381] by
-
- 1 copy in branches/Safari-3-branch
Start Safari 3 branch
