Timeline
Jan 12, 2008:
- 11:33 PM Changeset in webkit [29445] by
-
- 6 edits in trunk
2008-01-12 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Hide non-public symbols in GTK+/autotools release builds.
- 10:54 PM Changeset in webkit [29444] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.
- 8:52 PM Changeset in webkit [29443] by
-
- 3 edits in trunk/JavaScriptCore
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fix http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
- kjs/JSGlobalObject.h:
- 1:23 PM QtWebKitContrib edited by
- (diff)
- 11:25 AM Changeset in webkit [29442] by
-
- 5 edits in trunk/WebCore
2008-01-12 Rodney Dawes <dobey@wayofthemonkey.com>
Gtk debug build fix. Reviewed by Mark Rowe.
Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.
- WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
- platform/Logging.cpp:
- platform/Logging.h:
- plugins/PluginDebug.h:
- 10:35 AM Changeset in webkit [29441] by
-
- 2 edits in trunk/LayoutTests
Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.
- fast/replaced/image-map-expected.txt:
- 10:19 AM Changeset in webkit [29440] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix Qt Windows build
- pcre/dftables: Remove reliance on the list form of Perl pipes.
- 10:05 AM Changeset in webkit [29439] by
-
- 3 edits in trunk/JavaScriptCore
- try to fix Qt build
- kjs/function.cpp: Added include of scope_chain_mark.h.
- kjs/scope_chain_mark.h: Added multiple-include guards.
- 7:43 AM Changeset in webkit [29438] by
-
- 3 edits in trunk/JavaScriptCore
Roll out r29435 as it introduces many, many crashes.
- 6:25 AM Changeset in webkit [29437] by
-
- 2 edits in trunk/JavaScriptCore
2008-01-12 Mark Rowe <mrowe@apple.com>
Another Windows build fix.
- kjs/Activation.h:
- 6:12 AM Changeset in webkit [29436] by
-
- 3 edits in trunk/JavaScriptCore
2008-01-12 Mark Rowe <mrowe@apple.com>
Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.
- kjs/Activation.h:
- kjs/JSGlobalObject.h:
- 6:06 AM Changeset in webkit [29435] by
-
- 3 edits in trunk/JavaScriptCore
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fixes leaking of ActivationStackNode objects.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
- kjs/JSGlobalObject.h:
- 5:48 AM Changeset in webkit [29434] by
-
- 5 edits1 add in trunk
- Make launching of the WebKit httpd work on GNU/Debian/Linux
The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.
- 5:19 AM Changeset in webkit [29433] by
-
- 2 edits in trunk/WebKitTools
Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
Reviewed by Maciej Stachowiak.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
match the callers expectations that it can take ownership of the string.
- 4:03 AM Changeset in webkit [29432] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej (and also tweaked a little bit).
- more thorough fix for some crashing tests http://bugs.webkit.org/show_bug.cgi?id=16782
- loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL):
- loader/FrameLoader.h:
- 3:03 AM Changeset in webkit [29431] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.
- kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::getOwnPropertySlot):
- 12:37 AM Changeset in webkit [29430] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
- platform/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): (WebCore::SecurityOrigin::SecurityOrigin):
Jan 11, 2008:
- 11:40 PM Changeset in webkit [29429] by
-
- 3 edits in trunk
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
Enable FastMalloc by default in GTK+/autotools and add a configure
switch.
- GNUmakefile.am:
- configure.ac:
- 11:19 PM Changeset in webkit [29428] by
-
- 19 edits2 adds in trunk
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
This bug was caused by var declarations shadowing built-in properties of
the global object.
To match Firefox, we've decided that var declarations will never shadow
built-in properties of the global object or its prototypes. We used to
behave more like IE, which allows shadowing, but walking that line got
us into trouble with websites that sent us down the Firefox codepath.
- kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): New code to support calling hasProperty before the variable object is fully initialized (so you can call it during initialization).
- kjs/nodes.cpp:. (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty check when looking for duplicates, not getDirect, since it only checks the property map, and not hasOwnProperty, since it doesn't check prototypes. (KJS::EvalNode::processDeclarations): ditto
- kjs/property_slot.h: (KJS::PropertySlot::ungettableGetter): Best function name evar.
WebCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Removed the ReadOnly bit from some properties, to match Firefox. Also
removed status-related setters, to allow using their names as variable
names.
- bindings/scripts/CodeGeneratorJS.pm: Added support for properties that are one-way across domain boundaries, to match Firefox.
- bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.
- bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because we don't know that JSObject is our base class.
- page/DOMWindow.idl: Replaced lots of readonly declarations with [Replaceable] declarations.
- page/DOMWindow.h: Removed interfaces for setting status text via the DOM. (They were getting in the way of, e.g., "var status" declarations.) By default, IE 7 and FF disable these interfaces in order to defend against phishing attacks that try to spoof domain names in the statusbar.
- page/DOMWindow.cpp:
LayoutTests:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Added a test. Updated other tests to match new behavior.
- fast/js/var-declarations-shadowing-expected.txt: Added.
- fast/js/var-declarations-shadowing.html: Added.
- fast/dom/HTMLScriptElement/script-load-events.html: Changed this test a bit because the original design made it hard to understand why it was failing.
- fast/dom/HTMLScriptElement/script-load-events-expected.txt:
- fast/dom/Window/get-set-properties.html: Changed this test to expect our new behavior, which matches Firefox.
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/window-property-shadowing.html: Removed some cases that differed from Firefox.
- fast/dom/Window/window-property-shadowing-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt: This test emits more "Unsafe JavaScript attempt" messages now because property sets that used to be prohibited (somewhat accidentally) by the ReadOnly attribute are now prohibited by security checks.
- 9:50 PM Changeset in webkit [29427] by
-
- 3 edits3 adds in trunk
WebCore:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
Test: fast/frames/viewsource-empty-attribute-value.html
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
LayoutTests:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
Add a new regression test for
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
- fast/frames/resources/viewsource-frame-1.html: Added.
- fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
- fast/frames/viewsource-empty-attribute-value.html: Added.
- 6:22 PM Changeset in webkit [29426] by
-
- 2 edits in trunk/WebCore
2008-01-11 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
[Gtk] Uneven glyph spacing with subpixel antialiasing
http://bugs.webkit.org/show_bug.cgi?id=16715
Use cairo font options from the default GDK screen when creating a
scaled font.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 6:08 PM Changeset in webkit [29425] by
-
- 16 edits3 adds in trunk
Reviewed by Maciej.
Optimized ActivationImp allocation, so that activation records are now
first allocated on an explicitly managed stack and only heap allocated
when necessary. Roughly a 5% improvement on SunSpider, and a larger
improvement on benchmarks that use more function calls.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Activation.h: Added. (KJS::ActivationImp::ActivationData::ActivationData): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::classInfo): (KJS::ActivationImp::isActivationObject): (KJS::ActivationImp::isOnStack): (KJS::ActivationImp::d): (KJS::StackActivation::StackActivation):
- kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
- kjs/ExecState.h: (KJS::ExecState::replaceScopeChainTop): (KJS::ExecState::setActivationObject): (KJS::ExecState::setLocalStorage):
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): (KJS::JSGlobalObject::pushActivation): (KJS::JSGlobalObject::checkActivationCount): (KJS::JSGlobalObject::popActivationHelper): (KJS::JSGlobalObject::popActivation): (KJS::JSGlobalObject::tearOffActivation):
- kjs/JSGlobalObject.h:
- kjs/JSVariableObject.h: (KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (KJS::JSVariableObject::JSVariableObject):
- kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::~ActivationImp): (KJS::ActivationImp::init): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::markHelper): (KJS::ActivationImp::mark): (KJS::ActivationImp::ActivationData::ActivationData): (KJS::GlobalFuncImp::callAsFunction):
- kjs/function.h:
- kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PreIncResolveNode::evaluate): (KJS::PreDecResolveNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::AssignResolveNode::evaluate): (KJS::WithNode::execute): (KJS::TryNode::execute): (KJS::FunctionBodyNode::processDeclarations): (KJS::FuncExprNode::evaluate):
- kjs/object.h:
- kjs/scope_chain.h: (KJS::ScopeChain::replace):
- kjs/scope_chain_mark.h: Added. (KJS::ScopeChain::mark):
WebCore:
Reviewed by Maciej.
Added a new forwarding header, because Activation.h has been separated
from function.h
- ForwardingHeaders/kjs/Activation.h: Added.
LayoutTests:
Reviewed by Maciej.
Added a test case that came up when developing the ActivationImp tear-off.
- fast/js/resources/vardecl-preserve-arguments.js:
- fast/js/vardecl-preserve-arguments-expected.txt:
- 5:52 PM Changeset in webkit [29424] by
-
- 5 edits2 adds in trunk/LayoutTests
<rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger
- editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results to reflect the new info included in the test.
- platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
- platform/mac/editing/pasteboard/paste-RTFD-expected.png:
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- 5:36 PM Changeset in webkit [29423] by
-
- 5 edits in trunk/WebCore
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16729
[cURL] Allow multiple files for upload
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): added (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
- platform/network/curl/ResourceHandleManager.h:
- 4:25 PM Changeset in webkit [29422] by
-
- 3 edits in trunk/WebCore
2008-01-11 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
[Gtk] Menu items need underscores
http://bugs.webkit.org/show_bug.cgi?id=16817
Add underscores to appropriate menu labels.
Also adjust strings slightly.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::createNativeMenuItem):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuClearRecentSearchesText):
- 3:56 PM Changeset in webkit [29421] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
when a link to download a file has been clicked.
Reviewed by John and Anders.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad):
- 2:42 PM Changeset in webkit [29420] by
-
- 2 edits in trunk/LayoutTests
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
- platform/win/Skipped: Remove a test that was fixed in r29419.
- 2:38 PM Changeset in webkit [29419] by
-
- 2 edits in trunk/WebCore
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/5683529> plugins/embed-inside-object.html is timing
out/failing
Revert to using FrameTree::find() so that frame aliases like "_self" and
"_current" are interpreted properly
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
- 1:58 PM Changeset in webkit [29418] by
-
- 7 edits2 adds in trunk/WebCore
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Dave Hyatt and Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16089
[GTK] Support custom fonts, CachedFont::platformDataFromCustomData()
Add support for CSS2 @font-face custom/downloadable fonts to the GTK+
port.
- GNUmakefile.am:
- WebCore.pro:
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved):
- platform/graphics/gtk/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
- platform/graphics/gtk/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/gtk/FontPlatformData.h:
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::isFixedPitch):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
- 1:04 PM Changeset in webkit [29417] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
<rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events, as these are only posted because the test window is not a normal visible one, and they confuse drag&drop machinery.
- 12:51 PM Changeset in webkit [29416] by
-
- 2 edits in trunk/WebCore
Remove FrameLoader::committedFirstRealDocumentLoad
This method no longer has any callers.
Reviewed by Hyatt.
- loader/FrameLoader.h:
- 12:50 PM Changeset in webkit [29415] by
-
- 2 edits in trunk/WebKit/win
Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout
<http://bugs.webkit.org/show_bug.cgi?id=16828>
<rdar://5682402>
Now that we have 1) a real loader and 2) multiple FrameViews per
Frame, we no longer need the hackery we had in our WM_PAINT handler
that decided whether or not to paint. We now always want to paint,
letting the swapping of FrameViews that happens in
transitionToCommittedForNewPage handle which document gets painted.
Reviewed by Hyatt.
- WebView.cpp: (WebViewWndProc): Removed hackery that decided sometimes not to paint.
- 12:19 PM Changeset in webkit [29414] by
-
- 1 edit2 adds in trunk/WebCore
Add a standalone version of the blog post video player as a manual test.
- manual-tests/resources/touch-poster.png: Added.
- manual-tests/video-player.html: Added.
- 12:07 PM Changeset in webkit [29413] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
test is failing on trunk-win-release, so putting it back to make it green
- 11:47 AM Changeset in webkit [29412] by
-
- 1 edit6 adds in trunk/WebKitLibraries
Add shared vsprops to help unify our Windows tools settings.
Reviewed by Hyatt.
- win/tools: Added.
- win/tools/WinTools.make: Added.
- win/tools/vsprops: Added.
- win/tools/vsprops/common.vsprops: Added.
- win/tools/vsprops/debug.vsprops: Added.
- win/tools/vsprops/release.vsprops: Added.
- 11:29 AM Changeset in webkit [29411] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
removing test that doesn't fail
- 11:19 AM Changeset in webkit [29410] by
-
- 3 edits in trunk/WebCore
Reviewed by Adam.
Fix <rdar://problem/5682767>
Video does not show up in http://webkit.org/blog/140/html5-media-support/ on Windows
Take care that GWorld is created and deletes when needed as size or visibility changes.
- 10:33 AM Mobile created by
- Add a page on WebKit for mobile devices
- 10:27 AM Changeset in webkit [29409] by
-
- 3 edits in trunk/WebCore
Fix for bug 11188, setting hspace on a table overrides align=center. Fix align=center to be done using
mapped attributes so that it does not get overridden by hspace all the time.
Reviewed by mitz
Added fast/table/table-hspace-align-center.html
- css/html4.css:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
- 10:25 AM Changeset in webkit [29408] by
-
- 4 adds in trunk/LayoutTests
Add layout test for table bug.
- 10:15 AM Changeset in webkit [29407] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
moved couple of tests to a better category
- 10:14 AM Changeset in webkit [29406] by
-
- 3 edits in trunk/WebKitTools
Fix a crash when pathToLocalResource fails and a leak
Reviewed by Darin.
- DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): Dont leak the JSStringRef, and make sure not to pass null to JSValueMakeString.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource): Print an error message if the conversion fails so it's clear what happened.
- 8:32 AM Changeset in webkit [29405] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added some new failures.
- 8:31 AM Changeset in webkit [29404] by
-
- 2 edits in trunk
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16838
[GTK] Bad autotools debug and video options
Fix some configure options.
- configure.ac:
- 4:40 AM Changeset in webkit [29403] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- 4:26 AM Changeset in webkit [29402] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.
- 3:56 AM Changeset in webkit [29401] by
-
- 2 edits in trunk/WebKit/win
Windows build fix. Update to match method name in WebCore.
- 3:53 AM Changeset in webkit [29400] by
-
- 2 edits in trunk/WebCore
Qt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.
- 3:32 AM Changeset in webkit [29399] by
-
- 9 edits4 moves in trunk/WebCore
2008-01-11 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Anders Carlsson.
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779
Add the new shared PluginStream files to the GTK+ and Win32 builds.
Add PluginStreamClient class for the streamDidFinishLoading method.
Add open/close/write methods to FileSystem for temporary file handling.
Add PluginDebug.h and npfunctions.h for shared PluginStream.
Add shared PluginStream.
Remove PluginStreamWin.
Update PluginViewWin to use shared PluginStream and PluginStreamClass.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- platform/FileSystem.h:
- platform/gtk/FileSystemGtk.cpp:
- platform/win/FileSystemWin.cpp:
- plugins/PluginDebug.h:
- plugins/PluginStream.cpp:
- plugins/PluginStream.h:
- plugins/npfunctions.h:
- plugins/win/PluginDebug: Moved to PluginDebug.h.
- plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
- plugins/win/PluginStreamWin.h: Moved to PluginStream.h
- plugins/win/PluginViewWin.cpp:
- plugins/win/PluginViewWin.h:
- plugins/win/npfunctions.h: Moved to npfunctions.h
- 2:09 AM Changeset in webkit [29398] by
-
- 2 edits in trunk/WebCore
Try to fix Mac build: Edit the right .exp file.
- WebCore.base.exp:
- 2:03 AM Changeset in webkit [29397] by
-
- 2 edits in trunk/WebCore
Try to fix Qt build: don't use pthreads if they're not available.
- bindings/js/GCController.cpp:
- 1:52 AM Changeset in webkit [29396] by
-
- 18 edits2 deletes in trunk
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
- kjs/collector.h: Added the ability to distinguish between global objects and GC-protected global objects, since we only consider the latter to be world leaks.
- kjs/collector.cpp:
WebCore:
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
Stupid class, I kill you:
- bridge/JavaScriptStatistics.cpp: Removed.
- bridge/JavaScriptStatistics.h: Removed.
- bindings/js/GCController.h: Adopted the only useful features of JavaScriptStatistics, since they were GC-related.
- bindings/js/GCController.cpp:
WebKit/mac:
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
- Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them.
- Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now.
These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
WebKit/win:
Reviewed by John Sullivan.
Updated for transition away from JavaScriptStatistics, which is gone now.
- WebJavaScriptCollector.cpp: (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
WebKitTools:
Reviewed by John Sullivan.
- DumpRenderTree/mac/GCControllerMac.mm: (GCController::collectOnAlternateThread): Updated for name change.
- 12:22 AM Changeset in webkit [29395] by
-
- 2 edits in trunk/JavaScriptCore
Silence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.
- 12:04 AM Changeset in webkit [29394] by
-
- 2 edits in trunk
Attempt to fix the GTK+ and Qt builds.
Jan 10, 2008:
- 11:50 PM Changeset in webkit [29393] by
-
- 3 edits in trunk/WebKit/win
Not reviewed, build fix.
- more build fixing
- WebDatabaseManager.cpp:
- WebSecurityOrigin.h:
- 11:30 PM Changeset in webkit [29392] by
-
- 3 edits in trunk/WebKit/win
Not reviewed, build fix.
- try to fix build
- WebDatabaseManager.cpp: (WebDatabaseManager::databasesWithOrigin):
- WebSecurityOrigin.h:
- 9:29 PM Changeset in webkit [29391] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Don't build dftables any longer since it's now a Perl script.
- 9:12 PM Changeset in webkit [29390] by
-
- 1 edit in trunk/WebCore/css/CSSGrammar.y
Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y
- 8:42 PM Changeset in webkit [29389] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
No functional changes, only code cleanup.
- css/MediaQueryEvaluator.cpp: (WebCore::compareValue): renamed from cmpvalue (WebCore::colorMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
- 8:19 PM Changeset in webkit [29388] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix a crash when calling alert() from a repeating timer
On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
alert() and other similar functions, which deletes the actual
DOMWindowTimer objects and replaces them with new objects when resuming.
- bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Re-fetch the timer object from the map in case it has been deleted or replaced.
- 7:51 PM Changeset in webkit [29387] by
-
- 2 edits in trunk/WebKit/mac
Not reviewed. Build fix.
- Attempt to fix mac build.
- Storage/WebDatabaseManager.mm:
- 7:36 PM Changeset in webkit [29386] by
-
- 45 edits2 deletes in trunk
WebCore:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
- dom/Document.cpp: (WebCore::Document::domain):
- page/Chrome.cpp: (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation):
- page/Chrome.h:
- page/ChromeClient.h:
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::copy): (WebCore::SecurityOrigin::createFromIdentifier): (WebCore::SecurityOrigin::stringIdentifier):
- platform/SecurityOrigin.h: (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::equal):
- platform/SecurityOriginData.cpp: Removed.
- platform/SecurityOriginData.h: Removed.
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::securityOriginCopy):
- storage/Database.h:
- storage/DatabaseTracker.cpp: (WebCore::SecurityOriginHash::hash): (WebCore::SecurityOriginHash::equal): (WebCore::SecurityOriginTraits::deletedValue): (WebCore::SecurityOriginTraits::emptyValue): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::establishEntryForOrigin): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):
- storage/DatabaseTracker.h:
- storage/DatabaseTrackerClient.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/gtk:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
- WebCoreSupport/ChromeClientGtk.h:
WebKit/mac:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
- Storage/WebDatabaseTrackerClient.h:
- Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
- Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin isEqual:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): (-[WebSecurityOrigin _core]):
- Storage/WebSecurityOriginInternal.h:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKit/qt:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
- WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
- WebChromeClient.h:
- WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin): (WebDatabaseManager::dispatchDidModifyOrigin): (WebDatabaseManager::dispatchDidModifyDatabase):
- WebDatabaseManager.h:
- WebSecurityOrigin.cpp: (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
- WebSecurityOrigin.h:
WebKit/wx:
Reviewed by Sam.
- remove SecurityOriginData and fold its functionality into SecurityOrigin
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientWx::requestQuotaIncreaseForDatabaseOperation):
- WebKitSupport/ChromeClientWx.h:
- 6:48 PM Changeset in webkit [29385] by
-
- 3 edits in trunk/LayoutTests
2008-01-10 Stephanie <Stephanie Lewis>
RS=Oliver.
Move svg/batik/text/smallfonts.svg to the right skip list.
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- 6:09 PM Changeset in webkit [29384] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
Use the correct frame loader load method. Using the old method would not cause a
new window to be open if the frame navigation was not allowed.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 4:55 PM Changeset in webkit [29383] by
-
- 4 edits in trunk
2008-01-10 Alp Toker <alp@atoker.com>
SVG font build fix for GTK+/autotools.
- 4:41 PM Changeset in webkit [29382] by
-
- 1 edit in trunk/JavaScriptCore/pcre/dftables
BUILD FIX: Make dftables executable.
- 4:35 PM Changeset in webkit [29381] by
-
- 10 edits1 move2 deletes in trunk
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>
Reviewed by Darin.
Rewrote the dftables utility in Perl. Attempted to switch all
build systems to call the script directly instead of building
a binary first. Only the Xcode build was able to be tested.
- DerivedSources.make: Added pcre directory to VPATH and changed to invoke dftables directly.
- GNUmakefile.am: Removed build information and changed to invoke dftables directly.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to dftables project.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
- JavaScriptCore.vcproj/dftables: Removed.
- JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
- JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
- jscore.bkl: Removed dftables executable definition.
- pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
- pcre/dftables.cpp: Removed.
- pcre/dftables.pro: Removed.
- pcre/pcre.pri: Removed references to dftables.cpp and changed to invoke dftables directly.
WebKit/win:
dftables should be rewritten as a script
<http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>
Reviewed by Darin.
- WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
- 4:23 PM Changeset in webkit [29380] by
-
- 15 edits7 adds in trunk
WebCore:
Reviewed by Sam Weinig and Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
This patch makes two changes:
1) Java calls FrameLoader::load in a slightly different way than
JavaScript, which previously let a malicious web site bypass the
shouldAllowNavigation check. This patch adds that check to that
code path.
2) FrameLoader now wraps calls to m_frame->tree()->find(name) with
findFrameForNavigation, which calls shouldAllowNavigation. This
treats disallowed frame navigations as if the named frame did not
exist, resulting in a popup window when appropriate.
Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html
- WebCore.base.exp:
- bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncOpen::callAsFunction):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::findFrameForNavigation):
- loader/FrameLoader.h:
WebKit/mac:
Reviewed by Anders Carlsson.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation to ensure the shouldAllowNavigation check is made.
WebKitTools:
Reviewed by Anders Carlsson.
Make DRT track open windows instead of allocated windows so that
we can avoid ASSERTION due to late deallocs out of our control.
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpBackForwardListForAllWindows): (runTest):
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/DumpRenderTreeWindow.h:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm: (+[DumpRenderTreeWindow openWindows]): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow close]):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::windowCount):
LayoutTests:
Reviewed by Anders Carlsson.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>
- http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
- http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
- http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
- platform/win/Skipped:
- 4:10 PM Changeset in webkit [29379] by
-
- 2 edits in trunk/WebCore
Written by Hyatt, reviewed by me
- fixed <rdar://problem/5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display a <video> element that uses controls attribute
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): force the render style to inherit from the media element's style; Hyatt filed 5682383 to cover cleaning up this architecture, but this one-line fix will prevent the crash in the meantime
- 4:02 PM Changeset in webkit [29378] by
-
- 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp
Whoops, did not mean to commit that.
- 4:00 PM Changeset in webkit [29377] by
-
- 2 edits in trunk/WebCore
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
- platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 3:11 PM Changeset in webkit [29376] by
-
- 2 edits in trunk/WebKitTools
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
- 3:11 PM Changeset in webkit [29375] by
-
- 2 edits in trunk/WebCore
Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.
Reviewed by Darin.
- platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 2:17 PM Changeset in webkit [29374] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Removed a test that was fixed in r26826.
- 2:14 PM Changeset in webkit [29373] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Removed a test that was fixed in r28372.
- 1:51 PM Changeset in webkit [29372] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/5455889>
REGRESSION: BumperCar crashes when attempting to load a long invalid URL
Make sure to call FrameLoader::receivedMainResourceError before calling
FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
clearing out the provisional document loader so that we won't call the didFail
ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
- 1:48 PM Changeset in webkit [29371] by
-
- 4 edits in trunk/WebCore
Reviewed by Adele.
Fix <rdar://problem/5658048>
After <video> has finished playing, dragging the scroller on different location of controller starts to play movie
- Move to paused state if the playback had ended and the controller is used to seek to earlier time
- Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::setPausedInternal):
- html/HTMLMediaElement.h:
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- 1:33 PM Changeset in webkit [29370] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
<rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for file:// requests, as CFNetwork doesn't perform extension to MIME type mapping then.
- 1:23 PM Changeset in webkit [29369] by
-
- 9 edits in trunk
Fix many bugs by giving Windows one FrameView per page load
WebCore:
Fixes to allow multiple FrameViews on Windows
Reviewed by Hyatt.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): Added a new constructor that takes an IntSize to specify the FrameView's initial size. (WebCore::FrameView::scheduleRelayout): Added an assertion that our Document is not in the page cache.
- page/FrameView.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
- platform/qt/WidgetQt.cpp: (WebCore::Widget::~Widget): Ditto.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget): Make sure to remove any existing Widget from the Widget hierarchy before deleting it. One instance where this is needed is when setWidget is called during FrameView creation on Windows.
WebKit/win:
Fix many bugs by giving Windows one FrameView per page load
Bugs include:
<rdar://5659200>
Windows back/forward cache causes crashes in the layout tests
<rdar://5659355>
<http://bugs.webkit.org/show_bug.cgi?id=16808>
REGRESSION: PLT broken on Windows due to back/forward cache
<rdar://5663654>
<http://bugs.webkit.org/show_bug.cgi?id=16607>
Random crashes in FrameView::scheduleRelayout while surfing
Thinkgeek
On Windows until now we've only had one FrameView per Frame. Once the
back/forward cache was turned on this started causing assertions to
fail and crashes to occur due to a single FrameView being both in the
back/forward cache (possibly multiple times!) and used by a live
document. We now create a new FrameView for each page load, just as
Mac does.
This has the side-effect of plugging some of the world leaks seen at
the end of the PLT.
Reviewed by Hyatt.
- WebFrame.cpp: (WebFrame::initWithWebFrameView): Don't create the FrameView right away -- it'll be created when the load is committed. (WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no longer calling resetMultipleFormSubmissionProtection here. (WebFrame::transitionToCommittedForNewPage): Ported code from -[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:], -[WebCoreFrameBridge installInFrame:], and moved code here from WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore takes care of resetMultipleFormSubmissionProtection, just like it does on the Mac.
- WebView.cpp: (WebView::initWithFrame): Moved FrameView initialization code to WebFrame::transitionToCommittedForNewPage.
- 1:10 PM Changeset in webkit [29368] by
-
- 2 edits in trunk/WebCore
2008-01-10 Alp Toker <alp@atoker.com>
Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.
- svg/SVGFontFaceElement.cpp:
- 12:40 PM Changeset in webkit [29367] by
-
- 2 edits in trunk/WebCore
Reviewed by Alice Liu.
<rdar://problem/5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
<rdar://problem/5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail
Make sure we have an updated layout before we perform any editing work.
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
- 12:29 PM Changeset in webkit [29366] by
-
- 2 edits in trunk/WebCore
2008-01-10 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Back out r29206 which was causing regressions in curl http job
cancellation.
- platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::cancel):
- 11:33 AM Changeset in webkit [29365] by
-
- 11 edits4 adds in trunk
WebCore:
Reviewed by Darin, Sam, and Adam.
- <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
- link in gmail message displays JavaScript alert falsely complaining about pop-up blocking
- When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
- bindings/js/kjs_window.cpp: - Check the dynamic global object instead of the frame. (KJS::allowPopUp): (KJS::showModalDialog): (KJS::WindowProtoFuncOpen::callAsFunction):
WebKitTools:
Reviewed by Darin, Sam and Adam.
-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking.
- Added the ability to enable the pop-up blocker via the LayoutTestController.
- DumpRenderTree/LayoutTestController.cpp: (setPopupBlockingEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPopupBlockingEnabled):
LayoutTests:
Reviewed by Darin, Sam, and Adam.
-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking
- When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
- fast/events/open-window-from-another-frame-expected.txt: Added.
- fast/events/open-window-from-another-frame.html: Added.
- fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
- fast/events/resources/window-opened.html: Added.
- platform/win/Skipped:
- 11:29 AM Changeset in webkit [29364] by
-
- 2 edits in trunk/WebCore
Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.
Reviewed by adele
Added fast/css/visibility-hit-test.html test case.
- rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
- 11:28 AM Changeset in webkit [29363] by
-
- 4 adds in trunk/LayoutTests
Add new layout test for visibility bug.
- 9:39 AM Changeset in webkit [29362] by
-
- 5 edits1 move in trunk
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16782 <rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
The crash resulted from a native object (DumpRenderTree's
EventSender) causing its wrapper to be invalidated (by clicking a
link that replaced the document in the window) and consequently
deallocated. The fix is to use RefPtrs to protect the native object
from deletion by self-invalidation.
- bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
- bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):
LayoutTests:
Reviewed by Darin Adler.
- re-enable crashing test after fixing http://bugs.webkit.org/show_bug.cgi?id=16782 <rdar://problem/5675331> REGRESSION(r29266): Reproducible crash in fast/replaced/image-map.html
- fast/replaced/image-map-expected.txt: Updated results for the new behavior, which is to replace the document with the success message.
- fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
- fast/replaced/image-map.html-disabled: Removed.
- 8:47 AM Changeset in webkit [29361] by
-
- 3 edits in trunk/WebKit/qt
document QWebHistory
- 8:47 AM Changeset in webkit [29360] by
-
- 2 edits in trunk/WebKit/qt
Make the reset() functions not do anything on the default QWebSettings object.
- 8:47 AM Changeset in webkit [29359] by
-
- 10 edits3 moves in trunk
rename QWebPageHistory to QWebHistory.
- 8:39 AM Changeset in webkit [29358] by
-
- 2 edits in trunk/WebKit/qt
Documentation for QWebSettings
- 8:38 AM Changeset in webkit [29357] by
-
- 2 edits in trunk/WebKit/qt
Document QWebHistoryInterface.
- 8:38 AM Changeset in webkit [29356] by
-
- 4 edits in trunk/WebKit/qt
Documentation for QWebFrame.
- 8:19 AM Changeset in webkit [29355] by
-
- 7 edits in trunk
fix the drawing errors that where introduced due to refactoring.
Correctly clip to the rectangle we want to draw in ScrollView::paint().
Signed-off-by: Simon
- 8:19 AM Changeset in webkit [29354] by
-
- 3 edits in trunk/WebKit/qt
Added a whole bunch of docs for QWebPage and fixed some minor doc glitches in QWebView.
Signed-off-by: Lars
- 8:19 AM Changeset in webkit [29353] by
-
- 2 edits in trunk/WebCore
Temporarily disable gzip decompression in qhttp due to a bug.
Signed-off-by: Lars
- 7:28 AM Changeset in webkit [29352] by
-
- 7 edits in trunk/WebCore
http://bugs.webkit.org/show_bug.cgi?id=16588
Added a (last) Frame argument to ResourceHandle::loadResourceSynchronously.
This allows implementing the synchronous loading correctly for the Qt port where the networking
backend is bound to the page.
Signed-off-by: Lars
- 7:22 AM Changeset in webkit [29351] by
-
- 5 edits in trunk/LayoutTests
Reviewed by John Sullivan.
- make more tests pass on Windows by forcing font fallback to match Mac OS X.
- fast/css/beforeSelectorOnCodeElement.html:
- fast/css/rtl-ordering.html:
- fast/css/text-security.html:
- platform/win/Skipped:
- 12:49 AM Changeset in webkit [29350] by
-
- 2 edits in trunk/WebCore
wx build fix for changes in r29328
Jan 9, 2008:
- 7:48 PM Changeset in webkit [29349] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam.
- refactor SecurityOrigin in preparation for merging with SecurityOriginData
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::createForFrame):
- platform/SecurityOrigin.h:
- 7:03 PM Changeset in webkit [29348] by
-
- 6 edits1 copy1 add in trunk
WebCore:
Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.
Reviewed by Darin.
Test: fast/forms/tabs-with-modifiers.html
- page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): (WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down. Clean up the code a bit.
- page/EventHandler.h:
- page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and no longer needs it.
- page/FocusController.h:
LayoutTests:
Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.
Reviewed by Darin.
- fast/forms/tabs-with-modifiers-expected.txt: Added.
- fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.
- 6:57 PM Changeset in webkit [29347] by
-
- 2 edits in trunk/WebKit/win
Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().
Reviewed by Darin.
- WebView.cpp: (WebView::interpretKeyEvent):
- 6:51 PM Changeset in webkit [29346] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
- add some more renames, adjust some
- Scripts/do-webcore-rename:
- 5:41 PM Changeset in webkit [29345] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=16376
<rdar://problem/5665206>
<video> element fails to play frames when navigating back to page (16376)
Don't make MediaPlayer visible when it is actually in page cache.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
- 5:38 PM Changeset in webkit [29344] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5532361>
CrashTracer: 9840 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance [in-charge deleting] + 35
Clear the frame's plugin root objects so that they don't outlive the plugin bundle.
- page/Frame.cpp: (WebCore::Frame::pageDestroyed):
- 5:37 PM Changeset in webkit [29343] by
-
- 2 edits4 moves1 delete in trunk/LayoutTests
Reviewed by Darin Adler.
- move a WebKit test which was inadvertently added to a test suite directory into a custom test directory and change it to give the same results on Windows.
- css1/text_properties/text-transCapitalize.html: Removed.
- fast/text/capitalize-boundaries.html: Copied from LayoutTests/css1/text_properties/text-transCapitalize.html, updated the Bugzilla URL and added @font-face rules to make Windows results match Mac OS X.
- platform/mac/css1/text_properties/text-transCapitalize-expected.checksum: Removed.
- platform/mac/css1/text_properties/text-transCapitalize-expected.png: Removed.
- platform/mac/css1/text_properties/text-transCapitalize-expected.txt: Removed.
- platform/mac/fast/text/capitalize-boundaries-expected.checksum: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.checksum.
- platform/mac/fast/text/capitalize-boundaries-expected.png: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.png.
- platform/mac/fast/text/capitalize-boundaries-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.txt.
- platform/qt/css1/text_properties/text-transCapitalize-expected.txt: Removed.
- platform/win/Skipped: Removed css1/text_properties/text-transCapitalize.html.
- 3:02 PM Changeset in webkit [29342] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben and Anders Carlsson
- fixed <rdar://problem/5469398> Repro assertion failure in context menu code due to missing-but-expected Reload item
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): use isLoadingInAPISense when deciding whether to include Stop or Reload in context menu, to match the WebKit API
- 12:26 PM Changeset in webkit [29341] by
-
- 4 edits in trunk/WebKit/gtk
2008-01-09 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16802
[GTK] Missing gtk properties
Add missing properties to WebKitViewFrame and WebKitWebView.
- WebView/webkitprivate.h: add some useful defines for param specs
- WebView/webkitwebframe.cpp: (webkit_web_frame_get_property): added (webkit_web_frame_class_init): add name, title and uri read-only properties
- WebView/webkitwebview.cpp: (webkit_web_view_get_property): add editable property read (webkit_web_view_set_property): added for editable property write (webkit_web_view_class_init): add read-write editable property
- 12:13 PM Changeset in webkit [29340] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adam Roben.
<rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
<rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
<rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing
- fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
- platform/win/Skipped: Removed tests that were victims of the above.
- 12:10 PM Changeset in webkit [29339] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adam Roben.
Fix fast/encoding/frame-default-enc.html, which is failing on buildbot.
Internal frame names for this test are changing for no apparent reason (see r25269).
Make the test independent of the names.
- fast/encoding/frame-default-enc-expected.txt:
- fast/encoding/frame-default-enc.html:
- fast/encoding/resources/frame-default-enc-frame.html:
- 10:03 AM Changeset in webkit [29338] by
-
- 2 edits in trunk/WebCore
Fix Windows debug build for opensource developers.
- WebCore.vcproj/QTMovieWin.vcproj: Use the correct library suffix.
- 10:01 AM Changeset in webkit [29337] by
-
- 6 edits in trunk/LayoutTests
Update some test results
Reviewed by Anders.
- fast/dom/Window/window-properties-expected.txt: Updated after r29328.
- platform/win/media/audio-controls-rendering-expected.txt: Regenerated results with the correct fonts.
- platform/win/media/video-aspect-ratio-expected.txt: Ditto.
- platform/win/media/video-controls-rendering-expected.txt: Ditto.
- platform/win/media/video-transformed-expected.txt: Ditto.
- 8:32 AM ApplicationsGtk edited by
- Add a mail client (diff)
- 1:23 AM Changeset in webkit [29336] by
-
- 8 edits16 adds in trunk
Reworked by Eric, Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=9454 Add support for :lang inheritance and xml:lang support.
Tests: fast/selectors/lang-inheritance.html
fast/selectors/lang-inheritance2.html
fast/selectors/lang-vs-xml-lang.html
fast/selectors/lang-vs-xml-lang-xhtml.xhtml
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Do not share style between elements with different LANG-attribute. (WebCore::CSSStyleSelector::checkOneSelector): Change :lang() to recursively check the LANG attribute for all the elements parents and the content-language of the document.
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse MIME Content-Language
- dom/Document.h: (WebCore::Document::contentLanguage): (WebCore::Document::setContentLanguage):
Jan 8, 2008:
- 8:49 PM Changeset in webkit [29335] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
Bug 16678: Unreproducible crash in KJS::JSObject::inherits() after using Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=16678
Add a NULL check for controller before calling JSObjectSetPrivate.
- page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController):
- 8:45 PM Changeset in webkit [29334] by
-
- 2 edits in trunk/WebCore
2008-01-08 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15610
[GTK] Text rendering using Pango
Use Pango to render Complex path text.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8): (WebCore::convertUniCharToUTF8): (WebCore::setPangoAttributes): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 8:35 PM Changeset in webkit [29333] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5665860> With the web inspector displayed, a crash occurs
at WebCore::Frame::document() when navigating back to previous page
This fixes the crash, but the inspector was totally broken with back/forward.
So this also fixes back/forward navigation so the right main resource shows
up in the inspector.
- page/InspectorController.cpp: (WebCore::addSourceToFrame): Add some null checks for the frame when getting the textEncoding. This was the crash. (WebCore::InspectorController::addScriptResource): Create a script object only if needed, and always add it by calling addResource. (WebCore::InspectorController::didCommitLoad): Check if the loader is loading from the page cache, and clear m_mainResource. If the load is normal, then call addAndUpdateScriptResource with the main resource. (WebCore::InspectorController::identifierForInitialRequest): If the load is from the page cache and the resource is the main resource call addAndUpdateScriptResource since didCommitLoad did not do it.
- 8:15 PM Changeset in webkit [29332] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Back out VIDEO by default in the GTK+ qmake build. The build bot
doesn't have the necessary libraries installed.
- WebCore.pro:
- 7:41 PM Changeset in webkit [29331] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r29328.
- WebCore.vcproj/WebCore.vcproj:
- 7:37 PM Changeset in webkit [29330] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Enable VIDEO by default in the GTK+ qmake build.
- WebCore.pro:
- 7:13 PM Changeset in webkit [29329] by
-
- 3 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
GTK+ VIDEO build fix for breakage introduced in r29328.
Issue noticed by Ori_B.
- GNUmakefile.am:
- WebCore.pro:
- 5:41 PM Changeset in webkit [29328] by
-
- 5 edits2 moves2 adds in trunk
WebCore:
Reviewed by Darin.
HTMLAudioElement needs generated constructor. Otherwise video instanceof HTMLAudioElement is true which is
bit strange.
Renamed custom constructor JSHTMLAudioElementConstructor to JSAudioConstructor to avoid name clashes.
Test: media/constructors.html
- ChangeLog:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.cpp. (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::implementsConstruct): (WebCore::JSAudioConstructor::construct):
- bindings/js/JSAudioConstructor.h: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.h.
- bindings/js/JSHTMLAudioElementConstructor.cpp: Removed.
- bindings/js/JSHTMLAudioElementConstructor.h: Removed.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- html/HTMLAudioElement.idl:
LayoutTests:
Reviewed by Darin.
Test that media element constructors behave consistently.
- media/constructors-expected.txt: Added.
- media/constructors.html: Added.
- 4:45 PM Changeset in webkit [29327] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
Don't add the applet widget to the view, that's done later by RenderApplet.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
- 4:35 PM Changeset in webkit [29326] by
-
- 1 edit1 move in trunk/LayoutTests
- fast/replaced/image-map.html: Disabled this until bug 16782 is fixed.
- 4:35 PM Changeset in webkit [29325] by
-
- 3 edits1 delete in trunk
Fix fast/dom/Window/window-properties.html on Windows
WebCore:
- bindings/scripts/CodeGeneratorJS.pm: Touch this so the bindings will rebuild on Windows now that the media elements are enabled.
LayoutTests:
Fix fast/dom/Window/window-properties.html on Windows
Windows now has the same results as other platforms.
- platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
- 4:17 PM Changeset in webkit [29324] by
-
- 2 edits in trunk/LayoutTests
- remove a test from the skipped list
- platform/win/Skipped:
- 4:12 PM Changeset in webkit [29323] by
-
- 5 edits in trunk
WebCore:
Reviewed by Weinig.
Add security check for Audio constructor.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
LayoutTests:
Reviewed by Weinig.
Test cross-frame access to media properties.
- http/tests/security/cross-frame-access-get-expected.txt:
- http/tests/security/cross-frame-access-get.html:
- 3:51 PM Changeset in webkit [29322] by
-
- 5 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/5676515> List of scripts and images missing when opening Web Inspector from new window (16567)
InspectorController::didLoadResourceFromMemoryCache was not being called for
resources that loaded from the memory cache that the FrameLoader's client
has already been notified about. This fix always calls the InspectorController
when loading a memory cached resource. No test possible for the Web Inspector.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Moved most of the logic to FrameLoader::loadedResourceFromMemoryCache so the InspectorController can always be notified.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didTellClientAboutLoad): Renamed from didTellBridgeAboutLoad. (WebCore::FrameLoader::haveToldClientAboutLoad): Renamed from haveToldBridgeAboutLoad. (WebCore::FrameLoader::loadResourceSynchronously): Call the renamed didTellClientAboutLoad. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Only takes a CachedResource now. Always call InspectorController. If the resource's sendResourceLoadCallbacks is false or didTellClientAboutLoad is true, do an early return. Otherwise call the client and call didTellClientAboutLoad. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Removed, work now done in FrameLoader::loadedResourceFromMemoryCache.
- loader/FrameLoader.h: Renamed {didTell,haveTold}BridgeAboutLoad to {didTell,haveTold}ClientAboutLoad. Made loadedResourceFromMemoryCache only take a CachedResource. Renamed m_urlsBridgeKnowsAbout to m_urlsClientKnowsAbout.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): Call the renamed didTellClientAboutLoad.
- 2:11 PM Changeset in webkit [29321] by
-
- 2 edits5 adds in trunk/LayoutTests
Rubber stamped by Darin.
Enable media tests on Windows.
- 1:47 PM Changeset in webkit [29320] by
-
- 5 edits in trunk/WebCore
Rubber-stamped by Sam Weinig.
- prefix all member variables in CSSStyleSelector with m_
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initElementAndPseudoState): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::): (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::append):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable):
- 1:43 PM Changeset in webkit [29319] by
-
- 2 edits in trunk/WebCore
Removed unnecessary files from Copy Bundle Resources build phase.
Reviewed by Sam.
- WebCore.xcodeproj/project.pbxproj: Files removed from build phase: DOMCoreException.idl EventException.idl MessageEvent.idl SVGAElement.idl SVGAngle.idl SVGAnimateColorElement.idl SVGAnimateElement.idl SVGAnimateTransformElement.idl SVGAnimatedAngle.idl SVGAnimatedBoolean.idl SVGAnimatedEnumeration.idl SVGAnimatedInteger.idl SVGAnimatedLength.idl SVGAnimatedLengthList.idl SVGAnimatedNumber.idl SVGAnimatedNumberList.idl SVGAnimatedPathData.idl SVGAnimatedPoints.idl SVGAnimatedPreserveAspectRatio.idl SVGAnimatedRect.idl SVGAnimatedString.idl SVGAnimatedTransformList.idl SVGAnimationElement.idl SVGCSSPropertyNames.in SVGCSSValueKeywords.in SVGCircleElement.idl SVGClipPathElement.idl SVGColor.idl SVGComponentTransferFunctionElement.idl SVGCursorElement.idl SVGDefinitionSrcElement.idl SVGDefsElement.idl SVGDescElement.idl SVGDocument.idl SVGElement.idl SVGElementInstance.idl SVGElementInstanceList.idl SVGEllipseElement.idl SVGException.idl SVGExternalResourcesRequired.idl SVGFEBlendElement.idl SVGFEColorMatrixElement.idl SVGFEComponentTransferElement.idl SVGFECompositeElement.idl SVGFEDiffuseLightingElement.idl SVGFEDisplacementMapElement.idl SVGFEDistantLightElement.idl SVGFEFloodElement.idl SVGFEFuncAElement.idl SVGFEFuncBElement.idl SVGFEFuncGElement.idl SVGFEFuncRElement.idl SVGFEGaussianBlurElement.idl SVGFEImageElement.idl SVGFEMergeElement.idl SVGFEMergeNodeElement.idl SVGFEOffsetElement.idl SVGFEPointLightElement.idl SVGFESpecularLightingElement.idl SVGFESpotLightElement.idl SVGFETileElement.idl SVGFETurbulenceElement.idl SVGFilterElement.idl SVGFilterPrimitiveStandardAttributes.idl SVGFitToViewBox.idl SVGFontElement.idl SVGFontFaceElement.idl SVGFontFaceFormatElement.idl SVGFontFaceNameElement.idl SVGFontFaceSrcElement.idl SVGFontFaceUriElement.idl SVGForeignObjectElement.idl SVGGElement.idl SVGGlyphElement.idl SVGGradientElement.idl SVGImageElement.idl SVGLangSpace.idl SVGLength.idl SVGLengthList.idl SVGLineElement.idl SVGLinearGradientElement.idl SVGLocatable.idl SVGMarkerElement.idl SVGMaskElement.idl SVGMatrix.idl SVGMetadataElement.idl SVGMissingGlyphElement.idl SVGNumber.idl SVGNumberList.idl SVGPaint.idl SVGPathElement.idl SVGPathSeg.idl SVGPathSegArcAbs.idl SVGPathSegArcRel.idl SVGPathSegClosePath.idl SVGPathSegCurvetoCubicAbs.idl SVGPathSegCurvetoCubicRel.idl SVGPathSegCurvetoCubicSmoothAbs.idl SVGPathSegCurvetoCubicSmoothRel.idl SVGPathSegCurvetoQuadraticAbs.idl SVGPathSegCurvetoQuadraticRel.idl SVGPathSegCurvetoQuadraticSmoothAbs.idl SVGPathSegCurvetoQuadraticSmoothRel.idl SVGPathSegLinetoAbs.idl SVGPathSegLinetoHorizontalAbs.idl SVGPathSegLinetoHorizontalRel.idl SVGPathSegLinetoRel.idl SVGPathSegLinetoVerticalAbs.idl SVGPathSegLinetoVerticalRel.idl SVGPathSegList.idl SVGPathSegMovetoAbs.idl SVGPathSegMovetoRel.idl SVGPatternElement.idl SVGPoint.idl SVGPointList.idl SVGPolygonElement.idl SVGPolylineElement.idl SVGPreserveAspectRatio.idl SVGRadialGradientElement.idl SVGRect.idl SVGRectElement.idl SVGRenderingIntent.idl SVGSVGElement.idl SVGScriptElement.idl SVGSetElement.idl SVGStopElement.idl SVGStringList.idl SVGStylable.idl SVGStyleElement.idl SVGSwitchElement.idl SVGSymbolElement.idl SVGTRefElement.idl SVGTSpanElement.idl SVGTests.idl SVGTextContentElement.idl SVGTextElement.idl SVGTextPathElement.idl SVGTextPositioningElement.idl SVGTitleElement.idl SVGTransform.idl SVGTransformList.idl SVGTransformable.idl SVGURIReference.idl SVGUnitTypes.idl SVGUseElement.idl SVGViewElement.idl SVGViewSpec.idl SVGZoomAndPan.idl SVGZoomEvent.idl XMLHttpRequestException.idl XPathException.idl character-sets.txt mac-encodings.txt make-charset-table.pl svgattrs.in svgtags.in xlinkattrs.in
- 1:34 PM Changeset in webkit [29318] by
-
- 2 edits in trunk/WebCore
2008-01-08 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Support copying the selected URL to the clipboard.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL): implemented
- 1:27 PM Changeset in webkit [29317] by
-
- 6 edits in trunk/WebCore
Renamed CharacterData::m_str to m_data
Rubber-stamped by Adam again.
No test cases added since there is no change in behavior.
- dom/CDATASection.cpp:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
- dom/CharacterData.h:
- dom/Comment.cpp:
- dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
- 12:52 PM Changeset in webkit [29316] by
-
- 3 edits in trunk/WebCore
Fix a couple of compiler warnings.
Reviewed by Mitz.
- platform/win/ThreadingWin.cpp:
- platform/win/UniscribeController.cpp: Remove unused function. (WebCore::UniscribeController::advance): Fix bogus warning about un-initialized variable.
- 12:50 PM Changeset in webkit [29315] by
-
- 5 edits in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): After fixing a bug in EventHandler to make sure events always go to the capturing node, this bug was exposed. MouseMove and MouseUp events were going to the thumb element, but not to the slider input element. This change makes the input element the capturing node, and then the input element forwards the mouse events to the thumb element. I also added a missing call to setDefaultHandled for the mousemove event.
LayoutTests:
Reviewed by Darin.
Updated test for:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- fast/forms/slider-mouse-events-expected.txt:
- fast/forms/slider-mouse-events.html: Now tests mousemove events too.
- 12:27 PM Changeset in webkit [29314] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- rendering/RenderThemeSafari.cpp: Use the SafariTheme version number to decide whether or not to paint the media controls in RenderThemeSafari.
- 12:25 PM Changeset in webkit [29313] by
-
- 2 edits in trunk/WebCore
Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after dragging file into window that contains web page ( http://www.econocraft.com/flood_arch.htm )
Reviewed by Adele and John.
We hit this crash if the page reloads between DragController::dragUpdated
and DragController::performDrag, meaning that m_document starts pointing to
a now viewless document. This is picked up by an assertion in performDrag
which I have now replaced with an assignment given that the assertion is
invalid -- it is possible for m_document to be changed between dragUpdated
performDrag
- 11:55 AM Changeset in webkit [29312] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing spaces in ChangeLog.
- 11:52 AM Changeset in webkit [29311] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
<rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
WebCore::Node::setChanged + 96
Test: fast/dom/cssTarget-crash.html
- dom/Node.cpp: (WebCore::Node::removedFromDocument): Check to see if the node being removed is currently set as the Document's cssTarget.
Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.
- 11:42 AM Changeset in webkit [29310] by
-
- 2 edits in trunk/WebCore
- svg/svgtags.in: Touch this again for the sake of the Windows bots.
- 11:40 AM Changeset in webkit [29309] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Use JSRetainPtr in the Web Inspector everywhere we own a JSStringRef.
Also added some #pragma marks to help find places in the file.
- page/InspectorController.cpp: (WebCore::callSimpleFunction): Use JSRetainPtr<JSStringRef>. And return the result of JSObjectCallAsFunction. (WebCore::search): Use JSRetainPtr<JSStringRef>. (WebCore::databaseTableNames): Ditto. (WebCore::localizedStrings): Ditto. (WebCore::InspectorController::~InspectorController): Ditto. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::windowScriptObjectAvailable): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Ditto. (WebCore::InspectorController::addScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. (WebCore::InspectorController::updateScriptResourceRequest): Ditto. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. (WebCore::InspectorController::addScriptConsoleMessage): Ditto.
- 11:14 AM Changeset in webkit [29308] by
-
- 9 edits2 moves in trunk/WebCore
Rubber-stamped by Sam Weinig.
- rename FontDataBaseClass.{cpp,h} back to FontData.{cpp,h}
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- editing/Editor.cpp:
- platform/graphics/FontData.cpp: Copied from WebCore/platform/graphics/FontDataBaseClass.cpp.
- platform/graphics/FontData.h: Copied from WebCore/platform/graphics/FontDataBaseClass.h.
- platform/graphics/FontDataBaseClass.cpp: Removed.
- platform/graphics/FontDataBaseClass.h: Removed.
- platform/graphics/SegmentedFontData.h:
- platform/graphics/SimpleFontData.h:
- 10:51 AM Changeset in webkit [29307] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- DOMCoreClasses.cpp:
- 10:32 AM Changeset in webkit [29306] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Mitz.
<rdar://problem/5667286>
plugins/createScriptableObject-before-start.html is failing due to denied cross-frame access
Use our own test plug-in instead of the Flash plug-in. The Flash plug-in tries to get the URL of the top frame
which will cause a security exception.
- platform/win/Skipped:
- plugins/createScriptableObject-before-start.html:
- 9:56 AM Changeset in webkit [29305] by
-
- 2 edits in trunk/WebCore
Fix a Wx build error.
- platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
- 9:48 AM Changeset in webkit [29304] by
-
- 2 edits in trunk/WebCore
Fix a Qt build error.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
- 9:43 AM Changeset in webkit [29303] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Touch config.h to force a rebuild (apparently changing preprocessor
definitions in the .vcproj doesn't force a rebuild).
- config.h:
- 9:31 AM Changeset in webkit [29302] by
-
- 2 edits in trunk/WebCore
Fix a Wx build failure.
- webcore-wx.bkl:
- 9:27 AM Changeset in webkit [29301] by
-
- 2 edits in trunk/WebCore
Fix a Qt build failure.
- WebCore.pro:
- 9:21 AM Changeset in webkit [29300] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben
- fixed <rdar://problem/5671668> REGRESSION (r28711-r28730): With caret in an empty form field, Delete menu item is enabled but shouldn't be
The enabled logic was incorrect for the Delete menu item. To fix this, I added an EditorCommandSource
parameter to the enabled functions so that they can have parallel logic to the execute functions.
- editing/EditorCommand.cpp: added EditorCommandSource parameter to isEnabled function prototype (WebCore::enabled): added unused EditorCommandSource parameter to these isEnabled functions: (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut):
(WebCore::enabledDelete):
new function, uses logic previously used by Delete command for DOM sources; uses logic in enabledCut
for menu source
added unused EditorCommandSource parameter to these isEnabled functions:
(WebCore::enabledInEditableText):
(WebCore::enabledInRichlyEditableText):
(WebCore::enabledPaste):
(WebCore::enabledRangeInEditableText):
(WebCore::enabledRangeInRichlyEditableText):
(WebCore::enabledRedo):
(WebCore::enabledUndo):
(WebCore::CommandEntry::):
wire up new enabledDelete function as delete function for Delete command
(WebCore::Editor::Command::isEnabled):
pass EditorCommandSource parameter to isEnabled function
- 9:10 AM Changeset in webkit [29299] by
-
- 2 edits in trunk/WebCore
Visual C++ Express build fix
- WebCore.vcproj/QTMovieWin.vcproj: Explicitly link against user32.lib and advapi32.lib. VS implicitly links against these, VC++ Express doesn't.
- 8:45 AM Changeset in webkit [29298] by
-
- 2 edits in trunk/WebCore
- add bug number
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
- 7:34 AM Changeset in webkit [29297] by
-
- 2 edits in trunk/WebCore
Try to fix the Qt build.
- WebCore.pro:
- 7:07 AM Changeset in webkit [29296] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix Qt builds after Timothy's inspector changes.
- 5:31 AM Changeset in webkit [29295] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark.
- remove duplicate definition of getElementById from HTMLDocument IDL (and ObjC bindings)
- bindings/objc/PublicDOMInterfaces.h:
- html/HTMLDocument.idl:
- 5:02 AM Changeset in webkit [29294] by
-
- 6 edits in trunk/WebCore
Renamed CharacterData::str to m_str to match coding style
Rubber-stamped by Adam.
No test cases added since there is no change in behavior.
- dom/CDATASection.cpp:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
- dom/CharacterData.h:
- dom/Comment.cpp:
- dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
- 3:33 AM Changeset in webkit [29293] by
-
- 3 edits in trunk/JavaScriptCore
Turn testIsInteger assertions into compile-time asserts and move them into HashTraits.h where possible.
Reviewed by Maciej Stachowiak.
- kjs/testkjs.cpp:
- wtf/HashTraits.h:
- 1:25 AM Changeset in webkit [29292] by
-
- 2 edits in trunk/WebCore
Set the ENABLE_SVG_FONTS flag in Windows build, now builds.
I'm not sure if it just caused the right files to regenerate,
or if there's some configuration weirdness in the non-SVG-fonts
build.
- 1:11 AM Changeset in webkit [29291] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
- fixed <rdar://problem/5644300> Back/Forward Cache should not include pages with databases
Track whether a document has ever opened a database; if so, exclude it from b/f caching (for now)
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h: (WebCore::Document::setHasOpenDatabases): (WebCore::Document::hasOpenDatabases):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
- storage/Database.cpp: (WebCore::Database::openDatabase):
- 12:04 AM Changeset in webkit [29290] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix leaks seen on the build bot
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Avoid creating a CSSFontFaceSource for SVG font-face elements going into an SVGCSSFontFace because it just leaks them. Avoid adding SVG font- face elements to a CSSFontFace because it will not work as expected.
Jan 7, 2008:
- 11:32 PM Changeset in webkit [29289] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Mark Rowe.
- projects/svg/status.xml: remove fixed bugs.
- 11:27 PM Changeset in webkit [29288] by
-
- 2 edits in trunk/WebKit/win
Try to fix the Windows build.
- 8:13 PM Changeset in webkit [29287] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- 8:07 PM Changeset in webkit [29286] by
-
- 6 edits in trunk
Reviewed by Steve.
Re-enable media support in Windows build.
- 7:56 PM Changeset in webkit [29285] by
-
- 2 edits3 copies1 add in trunk/WebCore
2008-01-07 Steve Falkenburg <sfalken@apple.com>
Add version resource to QTMovieWin.dll
Reviewed by Adam.
- WebCore.vcproj/PRODUCTVERSION: Copied from ../WebKit/win/WebKit.vcproj/PRODUCTVERSION.
- WebCore.vcproj/QTMovieWin.rc: Added.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/VERSION: Copied from ../WebKit/win/WebKit.vcproj/VERSION.
- WebCore.vcproj/auto-version.sh: Copied from ../WebKit/win/WebKit.vcproj/auto-version.sh.
- 7:56 PM Changeset in webkit [29284] by
-
- 5 edits in tags/Safari-5525.2/WebCore
Merged r28972.
- 7:48 PM Changeset in webkit [29283] by
-
- 4 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added. Calls QFontDatabase::removeApplicationFont().
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): Removed the implementation because Qt does not use the WebCore glyph cache.
- 7:38 PM Changeset in webkit [29282] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix an assertion failure in svg/W3C-SVG-1.1/fonts-elem-03-b.svg on Tiger and multiple SVG layout test failures on Leopard.
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::getFontData): Avoid returning an empty SegmentedFontData.
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Avoid creating a font that contains no glyphs. On Leopard, ATS might create such a font given data in an unsupported format (such as SVG).
- 6:38 PM Changeset in webkit [29281] by
-
- 1 edit in tags/Safari-5525.2/WebCore/WebCore.vcproj/WebCore.make
Merged r29280.
- 6:37 PM Changeset in webkit [29280] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make
Build fix.
- 6:32 PM Changeset in webkit [29279] by
-
- 3 edits in tags/Safari-5525.2/WebCore
Merged r29278.
- 6:29 PM Changeset in webkit [29278] by
-
- 3 edits in trunk/WebCore
Build fix.
- WebCore.vcproj/WebCore.sln:
- WebCore.vcproj/WebCore.submit.sln:
- 6:26 PM Changeset in webkit [29277] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: removing fixed test
- 6:23 PM Changeset in webkit [29276] by
-
- 2 edits in trunk/LayoutTests
Temporary results until I fix:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- fast/forms/slider-mouse-events-expected.txt:
- 6:20 PM Changeset in webkit [29275] by
-
- 15 edits4 adds in trunk
Fix painting of SVG <image> when the image must be scaled to retain aspect ratio
Reviewed by Niko
Also added new layout test for this bug, and corrected old expected output
- 5:53 PM Changeset in webkit [29274] by
-
- 2 edits in tags/Safari-5525.2/WebKit/win
Merge r29272.
- 5:53 PM Changeset in webkit [29273] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- 5:49 PM Changeset in webkit [29272] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebKit.vcproj/InterfacesGenerated.vcproj:
- 5:49 PM Changeset in webkit [29271] by
-
- 2 edits in trunk/WebCore
Add missing newline.
- rendering/MediaControlElements.cpp:
- 5:37 PM Changeset in webkit [29270] by
-
- 4 edits in trunk/WebCore
2008-01-07 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Hyatt.
<rdar://problem/5673489> Safari does not render windowless plugins in an
iframe when opacity < 1.0
Plugins in transparency layers handle their own world transforms, so
only apply the horizontal/vertical transform if we are not in a
transparency layer.
- platform/graphics/GraphicsContext.h: Add a Windows-platform-only inTransparencyLayer() function
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Use inTransparencyLayer() (WebCore::GraphicsContext::inTransparencyLayer): (WebCore::GraphicsContext::releaseWindowsContext): Use inTransparencyLayer()
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): When retrieving the HDC, use the rect relative to the window. Pass m_isTransparent to get/releaseWindowsContext(). Only set the world transform if we are not in a transparency layer.
- 5:35 PM Changeset in webkit [29269] by
-
- 3 edits in trunk/WebCore
Build fix. Need to wrap these classes in #if ENABLE(VIDEO)
- rendering/MediaControlElements.cpp:
- rendering/MediaControlElements.h:
- 5:34 PM Changeset in webkit [29268] by
-
- 7 edits in trunk
Reviewed by Mark.
Enable SVG_FONTS by default.
- 5:32 PM Changeset in webkit [29267] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
- 5:30 PM Changeset in webkit [29266] by
-
- 9 edits11 adds in trunk
WebCore:
Reviewed by Sam Weinig
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16523
<rdar://problem/5657447>
When a frame is created with the URL "about:blank" or "", it should
inherit its SecurityOrigin from its opener. However, once it has
decided on that SecurityOrigin, it should not change its mind.
Prior to this patch, several events could induce the frame to change
its SecurityOrigin, permitting an attacker to inject script into an
arbitrary SecurityOrigin.
This patch makes several changes:
1) Documents refuse to change from one SecurityOrigin to another
unless explicitly instructed to do so.
2) Navigating to a JavaScript URL that produces a value
preserves the current SecurityOrigin explicitly instead of
relying on the URL to preserve the origin (which fails for
about:blank URLs and SecurityOrigins with document.domain set).
Ideally, we should not preserve the URL at all. Instead, the
frame's URL should be the JavaScript URL, as in Firefox, but this
would require changes that are too risky for this patch. I'll
file this as a separate issue.
3) Various methods of navigating to JavaScript URLs were not
properly handling JavaScript that returned a value (and should
therefore replace the current document). This patch unifies
those code paths with the path that works.
There are still a handful of bugs relating to the handling of
JavaScript URLs, but I'll file those as separate issues.
Tests: http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
- dom/Document.cpp: (WebCore::Document::initSecurityOrigin):
- dom/Document.h: (WebCore::Document::setSecurityOrigin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL): (WebCore::FrameLoader::begin):
- loader/FrameLoader.h:
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setForURL): (WebCore::SecurityOrigin::createForFrame):
- platform/SecurityOrigin.h:
LayoutTests:
Reviewed by Sam Weinig.
Adds new LayoutTests for scripting from about:blank windows. These
windows should inherit its SecurityOrigin from its opener and should
refuse to change their origins when their opener changes exogenously
(the navigate-opener tests) or explicitly (the set-opener test).
- http/tests/security/aboutBlank: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener.html: Added.
- http/tests/security/resources/innocent-victim-with-notify.html: Added.
- http/tests/security/resources/innocent-victim.html: Added.
- http/tests/security/resources/libwrapjs.js: Added.
- http/tests/security/resources/open-window.html: Added.
- 5:21 PM Changeset in webkit [29265] by
-
- 2 edits in trunk/WebCore
Forgot to check in these changes in my last checkin.
- rendering/RenderThemeSafari.cpp:
- 5:19 PM Changeset in webkit [29264] by
-
- 3 edits in trunk/WebCore
Build fixes.
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getCachedFontData):
- 4:51 PM Changeset in webkit [29263] by
-
- 2 edits in trunk/WebKitLibraries
Update Tiger library to a G3-friendly version.
- 4:48 PM Changeset in webkit [29262] by
-
- 6 edits39 adds16 deletes in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/5674119> Make the Web Inspector toolbar the normal size when not docked
- page/inspector/inspector.css: Changed CSS rules to have the toolbar and buttons be normal height when not docked, and small when docked. Also added some cursor properties prevent showing the text cursor over areas that are not selectable.
- page/inspector/Images: A few images added and old ones removed or renamed.
- 4:42 PM Changeset in webkit [29261] by
-
- 3 edits in trunk/WebCore
2008-01-07 Alp Toker <alp@atoker.com>
Prospective GTK+ autotools/qmake VIDEO build fix for breakage
introduced in r29257.
- GNUmakefile.am:
- WebCore.pro:
- 4:41 PM Changeset in webkit [29260] by
-
- 2 edits in tags/Safari-5525.2/WebCore
Merged r28959.
- 4:40 PM Changeset in webkit [29259] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix reviwer of my last commit. It was the other Mark after all.
- 4:37 PM Changeset in webkit [29258] by
-
- 7 edits in trunk/WebCore
Reviewed by Mark.
Build fix affecting all builds - again related to the unicode-range addition.
Note: There is still a crasher (svg/W3C-SVG-1.1/fonts-elem-03-b.svg) that Dan is about to fix.
- 4:28 PM Changeset in webkit [29257] by
-
- 42 edits2 adds in trunk
WebCore:
Reviewed by Antti, Adam, and Mitz.
WebCore part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCore.base.exp: Added symbols for WebKitSystemInterface drawing methods.
- WebCore.xcodeproj/project.pbxproj: Added MediaControlElements.h/cpp
- WebCore.vcproj/WebCore.vcproj: ditto.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added cases for new appearances.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added cases for new types.
- css/CSSSelector.h: (WebCore::CSSSelector::): Added new pseudo elements.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): ditto.
- css/CSSValueKeywords.in: Added keywords for new control appearance styles.
- css/html4.css: Added new styles for new controls.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlay): Added. Takes loading state into account.
- html/HTMLMediaElement.h:
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Make sure the events always go to the capturing node, if there is one.
- platform/mac/WebCoreSystemInterface.h: Added drawing methods for controls.
- platform/mac/WebCoreSystemInterface.mm: ditto.
- rendering/MediaControlElements.cpp: Added. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Moved from RenderMedia. Made this relatively positioned, instead of absolute. (WebCore::MediaControlInputElement::MediaControlInputElement): Moved from RenderMedia. Removed call to updateFromElement, since its too early to do this here, and causes crashes for the slider. (WebCore::MediaControlInputElement::attachToParent): Moved from RenderMedia. (WebCore::MediaControlInputElement::update): ditto. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Added. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Moved from RenderMedia. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Added. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::seekTimerFired): ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Moved from RenderMedia. (WebCore::MediaControlTimelineElement::defaultEventHandler): ditto. (WebCore::MediaControlTimelineElement::update): ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Added. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
- rendering/MediaControlElements.h: Added. Moved from RenderMedia. (WebCore::MediaControlShadowRootElement::isShadowNode): (WebCore::MediaControlShadowRootElement::shadowParentNode): (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):
- rendering/RenderMedia.cpp: Moved control element classes to MediaControlElements files. (WebCore::RenderMedia::RenderMedia): No need to initialize RefPtrs. (WebCore::RenderMedia::layout): Set the position for the controlsRenderer. (WebCore::RenderMedia::createPanel): Added nil check for the renderer. (WebCore::RenderMedia::createMuteButton): Added. (WebCore::RenderMedia::createSeekBackButton): ditto. (WebCore::RenderMedia::createSeekForwardButton): ditto. (WebCore::RenderMedia::createTimeDisplay): Added nil check for the renderer. (WebCore::RenderMedia::createFullscreenButton): Added. (WebCore::RenderMedia::updateControls): Create, delete, and update new controls when appropriate. (WebCore::RenderMedia::updateControlVisibility): Don't fade controls for audio controls. (WebCore::RenderMedia::forwardEvent): Forward events for new controls.
- rendering/RenderMedia.h: Added new methods for creating new controls.
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): Updated special case for media elements, which are replaced elements, but also can contain children (the controls' container) that may need to look for the containing block.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Added case for MediaSliderAppearance.
- rendering/RenderStyle.h: Added appearance constants and pseudo ids for new controls. (WebCore::): (WebCore::RenderStyle::):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Added cases for new appearances. (WebCore::RenderTheme::paint): ditto.
- rendering/RenderTheme.h: Added new methods for painting new appearances. (WebCore::RenderTheme::paintMediaBackground): (WebCore::RenderTheme::paintMediaFullscreenButton): (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSeekBackButton): (WebCore::RenderTheme::paintMediaSeekForwardButton): (WebCore::RenderTheme::paintMediaSliderThumb):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::~RenderThemeMac): Delete m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::paintCapsLockIndicator): Use LocalCurrentGraphicsContext here too, since we use it in all other painting methods. (WebCore::RenderThemeMac::paintSliderTrack): Added case for MediaSliderAppearance. (WebCore::RenderThemeMac::adjustSliderThumbSize): Added case for MediaSliderThumbAppearance. (WebCore::RenderThemeMac::paintMediaBackground): Draws the new artwork for the controls. (WebCore::RenderThemeMac::paintMediaFullscreenButton): ditto. (WebCore::RenderThemeMac::paintMediaMuteButton): ditto. (WebCore::RenderThemeMac::paintMediaPlayButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekBackButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekForwardButton): ditto. (WebCore::RenderThemeMac::paintMediaSliderThumb): ditto.
- rendering/RenderThemeSafari.cpp: Draws the new artwork on Windows. (WebCore::RenderThemeSafari::paintSliderTrack): (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaBackground): (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderThumb):
- rendering/RenderThemeSafari.h:
WebKit/mac:
Reviewed by Antti, Adam, and Mitz.
WebKit part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Antti, Adam, and Mitz.
WebKitLibraries part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Antti, Adam, and Mitz.
Updated results for:
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- 4:12 PM Changeset in webkit [29256] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix ASSERTION FAILED: dstOffset + srcSegmentLength == static_cast<int>(data.size())
when the replacment string is a different length.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::replace): Move the parenthesis to be around only the subtraction in the Vector size calculation, correcting the order of math operations.
- 4:04 PM Changeset in webkit [29255] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition. NSInteger not available there.
- 4:03 PM Changeset in webkit [29254] by
-
- 2 edits1 add in trunk/LayoutTests
Reviewed by Sam.
checking in platform-specific results. addresses <rdar://5137719>
- platform/win/Skipped:
- platform/win/fast/dom/Window/window-screen-properties-expected.txt: Added.
- 3:54 PM Changeset in webkit [29253] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch & enabling SVG_FONTS by default.
- 3:46 PM Changeset in webkit [29252] by
-
- 4 edits in trunk/WebCore
Not reviewed. Next try to fix wx/mac leopard build.
- 3:36 PM Changeset in webkit [29251] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adele.
- <rdar://problem/5667022> fast/events/mousemove-after-drag-over-scrollbar.html failing (missing a mousemove event)
- Updated test to reflect it's original intention and filed a different bug about the issue that caused the test to fail on Windows.
- fast/events/mousemove-after-drag-over-scrollbar-expected.txt:
- fast/events/mousemove-after-drag-over-scrollbar.html:
- platform/win/Skipped:
- 3:32 PM Changeset in webkit [29250] by
-
- 65 edits7 moves8 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/objc/DOM.mm:
- bridge/mac/WebCoreAXObject.mm:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded): Changed to call the owning segmented font face. (WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace): (WebCore::CSSFontFace::setSegmentedFontFace):
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable): Removed the calls to GlyphPageTreeNode::pruneTreeCustomFontData because the fonts in the font table are not exposed in the glyph page tree. Only the segmented font is, and that is taken care of by the segmented font face. (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to collect @font-face rules with the same family and traits into a single segmented font face, instead of just retaining the most recent one. (WebCore::CSSFontSelector::fontLoaded): (WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h:
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceUnicodeRange): Added. Parses a unicode range value.
- css/CSSParser.h:
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
- css/CSSPropertyNames.in:
- css/CSSSegmentedFontFace.cpp: Added. (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::pruneTable): (WebCore::CSSSegmentedFontFace::isLoaded): (WebCore::CSSSegmentedFontFace::isValid): (WebCore::CSSSegmentedFontFace::fontLoaded): (WebCore::CSSSegmentedFontFace::overlayRange): (WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSSegmentedFontFace.h: Added. (WebCore::FontFaceRange::FontFaceRange): (WebCore::FontFaceRange::from): (WebCore::FontFaceRange::to): (WebCore::FontFaceRange::fontFace): (WebCore::CSSSegmentedFontFace::fontSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSUnicodeRangeValue.cpp: Added. (WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::cssText):
- css/CSSUnicodeRangeValue.h: Added. (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::from): (WebCore::CSSUnicodeRangeValue::to):
- css/SVGCSSFontFace.cpp: (WebCore::SVGCSSFontFace::getFontData):
- css/SVGCSSFontFace.h:
- editing/Editor.cpp: (WebCore::Editor::fontForSelection):
- editing/Editor.h:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]):
- platform/graphics/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::glyphDataForCharacter): (WebCore::Font::primaryFont): Changed to return the simple font data used for the space character. (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::drawGlyphBuffer):
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp: (WebCore::FontCache::getCachedFontData): (WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
- platform/graphics/FontData.cpp: Renamed to SimpleFontData.cpp
- platform/graphics/FontData.h: Renamed to SimpleFontData.cpp.
- platform/graphics/FontDataBaseClass.cpp: Added. This will be renamed FontData.cpp. (WebCore::FontData::~FontData):
- platform/graphics/FontDataBaseClass.h: Added. This will be renamed FontData.h.
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primaryFont):
- platform/graphics/FontSelector.h:
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::add):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::initializePage): Added code to initialize pages for segmented font data. (WebCore::GlyphPageTreeNode::getChild): (WebCore::GlyphPageTreeNode::pruneCustomFontData):
- platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::getRootChild):
- platform/graphics/SegmentedFontData.cpp: Added. (WebCore::SegmentedFontData::~SegmentedFontData): (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters): (WebCore::SegmentedFontData::isCustomFont): (WebCore::SegmentedFontData::isLoading): (WebCore::SegmentedFontData::isSegmented):
- platform/graphics/SegmentedFontData.h: Added. (WebCore::FontDataRange::FontDataRange): (WebCore::FontDataRange::from): (WebCore::FontDataRange::to): (WebCore::FontDataRange::fontData): (WebCore::SegmentedFontData::appendRange): (WebCore::SegmentedFontData::numRanges): (WebCore::SegmentedFontData::rangeAt):
- platform/graphics/SimpleFontData.cpp: Copied from WebCore/platform/graphics/FontData.cpp. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData): (WebCore::SimpleFontData::ascent): (WebCore::SimpleFontData::descent): (WebCore::SimpleFontData::widthForGlyph): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
- platform/graphics/SimpleFontData.h: Copied from WebCore/platform/graphics/FontData.h. (WebCore::SimpleFontData::isCustomFont): (WebCore::SimpleFontData::isLoading):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFont):
- platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/gtk/FontDataGtk.cpp: Renamed to SimpleFontDataGtk.cpp.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: Copied from WebCore/platform/graphics/gtk/FontDataGtk.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/mac/FontDataMac.mm: Renamed to SimpleFontDataMac.mm.
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/mac/SimpleFontDataMac.mm: Copied from WebCore/platform/graphics/mac/FontDataMac.mm. (WebCore::initFontData): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::checkShapesArabic):
- platform/graphics/qt/FontDataQt.cpp: Renamed to SimpleFontDataQt.cpp.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- platform/graphics/qt/SimpleFontDataQt.cpp: Copied from WebCore/platform/graphics/qt/FontDataQt.cpp.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/win/FontDataWin.cpp: Renamed to SimpleFontDataWin.cpp.
- platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/win/SimpleFontDataWin.cpp: Copied from WebCore/platform/graphics/win/FontDataWin.cpp. (WebCore::SimpleFontData::setShouldApplyMacAscentHack): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::scriptFontProperties):
- platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/wx/FontDataWx.cpp: Renamed to SimpleFontDataWx.cpp.
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/wx/SimpleFontDataWx.cpp: Copied from WebCore/platform/graphics/wx/FontDataWx.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/mac/FileChooserMac.mm:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WebCoreTextRenderer.mm:
- platform/win/PopupMenuWin.cpp:
- platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::shapeAndPlaceItem): (WebCore::UniscribeController::shape):
- platform/win/UniscribeController.h:
- svg/SVGFont.cpp: (WebCore::Font::drawGlyphsWithSVGFont):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::collectGlyphs):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::createFontData):
- svg/SVGFontFaceElement.h:
- svg/SVGGlyphElement.cpp:
WebKit/mac:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- Misc/WebNSAttributedStringExtras.mm:
WebKit/win:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- WebView.cpp: (WebView::setShouldApplyMacFontAscentHack):
- 3:15 PM Changeset in webkit [29249] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix mac build by forcing SVGNames regeneration.
- 3:10 PM Changeset in webkit [29248] by
-
- 2 edits in trunk/WebCore
Not reviewed. Proposed build fix for wx.
- 3:03 PM Changeset in webkit [29247] by
-
- 2 edits in trunk/WebCore
64-bit build fix
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Have to use a cast here since FMGetFontFromATSFontRef() is not available on 64-bit.
- 2:56 PM Changeset in webkit [29246] by
-
- 187 edits1 add in trunk
Reviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15741 (REGRESSION: svg/W3C-SVG-1.1/fonts-elem-03-b.svg shows worse behavior on TOT)
Display SVG Fonts, fill svg/SVGFont.cpp with life by adding all needed code to
measure & render glyphs contained in SVG Fonts, including ligature lookup support.
Fixes dozens of testcases, see ChangeLog for details.
- 2:10 PM Changeset in webkit [29245] by
-
- 6 edits1 delete in trunk/JavaScriptCore
Rubber stamped by David Kilzer.
- get rid of empty fpconst.cpp
- GNUmakefile.am: Remove fpconst.cpp.
- JavaScriptCore.pri: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- JavaScriptCoreSources.bkl: Ditto.
- kjs/fpconst.cpp: Removed.
- 2:01 PM Changeset in webkit [29244] by
-
- 4 edits271 moves63 adds12 deletes in trunk/LayoutTests
Rubberstamped by Oliver.
Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.
Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.
- 1:50 PM Changeset in webkit [29243] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by David Kilzer.
- fix alignment problem with NaN and Inf globals
- kjs/fpconst.cpp: Move the contents of this file from here back to value.cpp. The reason this was in a separate file is that the DARWIN version of this used a declaration of the globals with a different type to avoid creating "init routines". That's no longer necessary for DARWIN and was never necessary for the non-DARWIN code path. To make this patch easy to merge, I didn't actually delete this file yet. We'll do that in a separate changeset.
- kjs/value.cpp: If C99's NAN and INFINITY are present, then use them, othrewise use the union trick from fpconst.cpp. I think it would be better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY directly or std::numeric_limits<double>::quiet_nan() and std::numeric_limits<double>::infinity(). But when I tried that, it slowed down SunSpider. Someone else could do that cleanup if they could do it without slowing down the engine.
- 1:46 PM Changeset in webkit [29242] by
-
- 2 edits in trunk/LayoutTests
- Updated to run a test whose failure was only a build bot state issue.
- platform/win/Skipped:
- 1:15 PM Changeset in webkit [29241] by
-
- 3 edits in trunk/WebCore
Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.
Reviewed by Dan
- rendering/RenderBox.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- 12:50 PM Changeset in webkit [29240] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Skip the culprit, not the victim.
- 12:43 PM Changeset in webkit [29239] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JavaScript.h to the project.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Copy JavaScript.h to WEBKITOUTPUTDIR.
- 12:37 PM Changeset in webkit [29238] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by Darin.
Fix Mac build.
- API/JSNode.c:
- API/JSNode.h:
- API/JSNodeList.c:
- API/JSNodeList.h:
- API/JavaScript.h:
- API/JavaScriptCore.h:
- API/minidom.c:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:22 PM Changeset in webkit [29237] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added a few more failures.
- 12:02 PM Changeset in webkit [29236] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove a now incorrect Windows-specific result
This should have been done as part of r29187
- platform/win/fast/dom/wrapper-classes-expected.txt: Removed.
- 11:58 AM Changeset in webkit [29235] by
-
- 2 edits in trunk/WebKitTools
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
DRT doesn't handle platform specific pixel test results correctly.
<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).
- 11:30 AM Changeset in webkit [29234] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2008-01-07 Alp Toker <alp@atoker.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16029
JavaScriptCore.h is not suitable for platforms other than Mac OS X
Introduce a new JavaScriptCore/JavaScript.h public API header. This
should be used by all new portable code using the JavaScriptCore API.
JavaScriptCore/JavaScriptCore.h will remain for compatibility with
existing applications that depend on it including JSStringRefCF.h
which isn't portable.
Also add minidom to the GTK+/autotools build since we can now support
it on all platforms.
- API/JSNode.h:
- API/JSNodeList.h:
- API/JavaScript.h: Added.
- API/JavaScriptCore.h:
- ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
- GNUmakefile.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:16 AM Changeset in webkit [29233] by
-
- 2 edits in trunk/WebCore
- Fix indention
- 11:15 AM Changeset in webkit [29232] by
-
- 2 edits in trunk/WebCore
- The ContextMenuController is going to live longer than the ContextMenu. It is going to live as long as the WebCore::Page is around where the ContextMenu, specially in the case of a SubMenu, is gone before we popup the menu.
- 11:15 AM Changeset in webkit [29231] by
-
- 3 edits in trunk/WebCore
- Fix SubMenu handling
- Do not connect to the activated signal if we are a separator or submenu
- Change our type from ActionType to SubMenuType when we have a submenu
- Initialize the SubMenu
- 11:14 AM Changeset in webkit [29230] by
-
- 9 edits in trunk
- Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable actions.
- Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
- Update the ContextMenuController to accept CheckableActionTypes as well.
- Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable was extracted from ContextMenu::checkOrEnableIfNeeded.
- Update the Qt and Windows port.
- 10:04 AM Changeset in webkit [29229] by
-
- 4 edits in trunk
WebKitTools:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing DRT did not correctly handle printing the '\0' char. Now it does.
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpFramesAsText): (dump):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing. Since they pass now, the two tests are removed from the Skipped list.
- platform/win/Skipped:
- 8:23 AM Changeset in webkit [29228] by
-
- 2 edits in trunk/WebCore
2008-01-07 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16745
[GTK] Context menu doesn't feel or look native - no icons
Use GTK+ stock icons for menu items where possible.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::setAction):
- 7:16 AM Changeset in webkit [29227] by
-
- 3 edits in trunk/WebCore
Reviewed by John Sullivan.
- make the ATSUI code path work with custom fonts rather than crash
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle):
- 5:29 AM Changeset in webkit [29226] by
-
- 2 edits in trunk/WebKit/qt
Build fix for the Windows build. MSVC wants to see the full
declaration of arguments even when just passing them through.
- 3:38 AM Changeset in webkit [29225] by
-
- 5 edits in trunk/WebKit/qt
Added the missing parameters to make it possible to do POST operations from the public API.
This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/
Signed-off-by: Lars
- 3:36 AM Changeset in webkit [29224] by
-
- 2 edits in trunk/WebCore
abort() now emits the signals, so disconnect them before you abort()
Signed-off-by: Simon
- 3:36 AM Changeset in webkit [29223] by
-
- 2 edits in trunk/WebCore
Use a faster and safer way of flattening the form data.
Signed-off-by: Lars
- 3:35 AM Changeset in webkit [29222] by
-
- 28 edits3 adds in trunk
Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
Signed-off-by: Lars
- 2:46 AM Changeset in webkit [29221] by
-
- 2 edits in trunk/WebCore
- Remove m_dirtyRegion as it is not used as we pass every dirty region directly to the ChromeClient
Signed-off-by: Lars
- 2:46 AM Changeset in webkit [29220] by
-
- 2 edits in trunk/WebKit/qt
- Move the QWebPagePrivate methods up to the other private ones
Signed-off-by: Simon
- 2:46 AM Changeset in webkit [29219] by
-
- 3 edits in trunk/WebKit/qt
- Add reimplemented comments for the methods reimplemented in QWebView and QWebPage.
Signed-off-by: Simon
- 2:45 AM Changeset in webkit [29218] by
-
- 2 edits in trunk/WebKit/qt
- This layout is not needed anymore as Widget::invalidateRect will not draw anymore.
Signed-off-by: Lars
Jan 6, 2008:
- 10:06 PM Changeset in webkit [29217] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
Abstract all DateObject.set* functions in preparation for fixing:
http://bugs.webkit.org/show_bug.cgi?id=16753
SunSpider had random changes here and there but was overall a wash.
- kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction):
- 2:52 PM Changeset in webkit [29216] by
-
- 7 edits in trunk/WebCore
Reviewed by Oliver.
Small CG paint server cleanups - use more GraphicsContext method where possible.p
- 2:43 PM Changeset in webkit [29215] by
-
- 5 edits in trunk
Reviewed by Dan.
Add new helper function isArabicChar - SVG Fonts support needs it.
- 2:33 PM Changeset in webkit [29214] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
Test: fast/dom/Range/range-modifycontents.html
- dom/Range.cpp: (WebCore::Range::insertNode):
LayoutTests:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
- fast/dom/Range/range-modifycontents-expected.txt: Added.
- fast/dom/Range/range-modifycontents.html: Added.
- fast/dom/Range/resources/range-modifycontents.js: Added.
- 2:25 PM Changeset in webkit [29213] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing expected result.
- fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.
- 12:35 PM Changeset in webkit [29212] by
-
- 3 edits3 adds in trunk
Reviewed by darin.
Make attr selectors case-insensitive for certain HTML attributes
http://bugs.webkit.org/show_bug.cgi?id=15470
Test: fast/css/html-attr-case-sensitivity.html
- css/CSSStyleSelector.cpp: (WebCore::addLocalNameToSet): (WebCore::createHtmlCaseInsensitiveAttributesSet): (WebCore::htmlAttributeHasCaseInsensitiveValue): (WebCore::CSSStyleSelector::checkOneSelector):
- 11:35 AM Changeset in webkit [29211] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16731
Incorrect node type for whitespace when setting innerHTML in an XHTML document
Test: fast/dom/xhtml-fragment-whitespace.xhtml
- dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Use balancedCharactersHandler for ignorable whitespace.
- 11:33 AM Changeset in webkit [29210] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16701
<rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
causes page load error
Test: http/tests/misc/location-with-space.php
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.
- 11:10 AM Changeset in webkit [29209] by
-
- 2 edits in trunk/JavaScriptCore
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
build. (This is already done correctly in DerivedSources.make.) Issue
noticed by Mikkel when building in Cygwin.
Add a missing slash. This was a hack from the qmake build system that
isn't necessary with autotools.
- GNUmakefile.am:
- 3:35 AM Changeset in webkit [29208] by
-
- 3 edits in trunk/WebKitTools
Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
Reviewed by Alp Toker.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
- 3:27 AM Changeset in webkit [29207] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
Test: fast/dom/Range/range-clone-empty.html
- dom/Range.cpp: (WebCore::Range::processContents):
LayoutTests:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
- fast/dom/Range/range-clone-empty-expected.txt: Added.
- fast/dom/Range/range-clone-empty.html: Added.
- fast/dom/Range/resources/range-clone-empty.js: Added.
- 2:57 AM Changeset in webkit [29206] by
-
- 2 edits in trunk/WebCore
2008-01-06 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Remove curl handles immediately if the timer is not running.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel):
- 12:48 AM Changeset in webkit [29205] by
-
- 2 edits in trunk/WebCore
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Eric.
Cairo canvas refcounting fix. Reference the surface in the constructor
to match its destruction in the destructor.
Fixes a crash triggered by leaving this page:
http://philip.html5.org/tests/canvas/misc/globalalpha-pattern.html
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
- 12:13 AM Changeset in webkit [29204] by
-
- 3 edits4 adds in trunk
Reviewed by Sam.
Fix :checked matching type='text' and add test case
http://bugs.webkit.org/show_bug.cgi?id=16750
Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html
- html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX
Jan 5, 2008:
- 6:36 PM Changeset in webkit [29203] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Eric Seidel.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.
Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
- dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
LayoutTests:
Reviewed by Eric Seidel.
Test for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- fast/dom/TreeWalker: Added.
- fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
- fast/dom/TreeWalker/resources: Added.
- fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.
- 6:24 PM Changeset in webkit [29202] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Some more renaming plans.
- 6:16 PM Changeset in webkit [29201] by
-
- 2 edits in trunk/JavaScriptCore
- API/JSRetainPtr.h: One more file that needed the change below.
- 6:14 PM Changeset in webkit [29200] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.
- 6:12 PM Changeset in webkit [29199] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
Reviewed by Maciej.
- wtf/RetainPtr.h: Use PtrType instead of T* because of the RemovePointer magic.
- 2:46 PM Changeset in webkit [29198] by
-
- 6 edits in trunk/JavaScriptCore
Rubber stamped by Maciej Stachowiak.
- cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RefPtr.h:
- wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.
- 3:44 AM Changeset in webkit [29197] by
-
- 2 edits in trunk
2008-01-05 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Fix configure script output with correct descriptions of the default
configuration options.
- 2:23 AM Changeset in webkit [29196] by
-
- 2 edits in trunk
2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.
- autogen.sh:
- 12:26 AM Changeset in webkit [29195] by
-
- 2 edits in trunk/JavaScriptCore
2008-01-05 Henry Mason <hmason@mac.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset
Gives a 0.4% SunSpider boost and prettier code.
- kjs/collector.cpp: Switched to cell offsets from byte offsets (KJS::Collector::heapAllocate): (KJS::Collector::sweep):
- 12:02 AM Changeset in webkit [29194] by
-
- 3 edits in trunk/JavaScriptCore
Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.
Reviewed by Maciej Stachowiak.
Jan 4, 2008:
- 9:45 PM Changeset in webkit [29193] by
-
- 2 edits in trunk/LayoutTests
- update the list of tests failing on Windows because of font differences and uncomment a test that has been re-enabled on Mac.
- platform/win/Skipped:
- 9:20 PM Changeset in webkit [29192] by
-
- 5 edits in trunk
Fix bounds computation bugs responsible for http://bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.
Reviewed by Beth Dakin.
We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).
I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.
I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(
- 9:13 PM Changeset in webkit [29191] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
Prevent :enabled and :disabled from applying to input type="hidden"
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Rather than allowing :enabled and :disabled to apply to all controls, only allow it to apply to non-"hidden" controls
- dom/Element.h: (WebCore::Element::isInputTypeHidden):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isInputTypeHidden):
LayoutTests:
Reviewed by Oliver.
Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
- fast/forms/hidden-input-not-enabled-expected.txt: Added.
- fast/forms/hidden-input-not-enabled.html: Added.
- 8:05 PM Changeset in webkit [29190] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing expected result.
- fast/images/border-expected.txt: Added.
- 8:04 PM Changeset in webkit [29189] by
-
- 10 edits3 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- Match the spec when calling getFloatValue, getStringValue, getCounterValue, getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions if the type of the CSSPrimitiveValue is not the same as the type requested.
- Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml
Test: fast/css/CSSPrimitiveValue-exceptions.html
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
- css/CSSPrimitiveValue.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Throw exceptions for the CSSPrimitiveValue getters, matching the spec.
- fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
- fast/css/CSSPrimitiveValue-exceptions.html: Added.
- fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
- fast/dom/prototypes.html:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- svg/css/glyph-orientation-rounding-test-expected.txt:
- svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw. This patch also fixes the associated intermittent failure seen in this test.
- 6:32 PM Changeset in webkit [29188] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Windows part of <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Check QuickTime version on Windows too.
- 5:51 PM Changeset in webkit [29187] by
-
- 4 edits1 copy1 add in trunk/LayoutTests
Reviewed by Kevin McCullough.
- Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
- Adds tests for .proto and .constructor to JS wrapper tests.
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
- platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
- platform/win/Skipped:
- 5:45 PM Changeset in webkit [29186] by
-
- 2 edits in trunk/LayoutTests
Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.
- platform/mac-tiger/Skipped:
- 5:11 PM Changeset in webkit [29185] by
-
- 3 edits1 copy2 adds in trunk
WebCore:
Reviewed by Maciej and Alice.
- fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
Test: fast/images/border.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases where the border value is not a number to use the value "0" for the border width instead of not setting the border width and style at all. This matches other browsers, and makes more sense.
LayoutTests:
Reviewed by Maciej and Alice.
- test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
- fast/images/border.html: Added.
- fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- fast/images/resources/border.js: Added.
- 4:32 PM Changeset in webkit [29184] by
-
- 6 edits in trunk
WebKitTools:
Reviewed by Alexey and Darin.
Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
LayoutTests:
Reviewed by Alexey and Darin.
- editing/selection/move-begin-end.html: add a codepath that will test the same kind of functionality for home and end keys
- platform/win/Skipped: removing section of tests that have been resolved
- 4:28 PM Changeset in webkit [29183] by
-
- 2 edits in trunk/WebCore
Try to fix 64-bit build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 4:15 PM Changeset in webkit [29182] by
-
- 2 edits in trunk/WebCore
Fix another stringImpl leak.
- platform/text/StringImpl.cpp: remove an extra allocation (WebCore::StringImpl::StringImpl):
- 3:34 PM Changeset in webkit [29181] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
- platform/graphics/win/FontCacheWin.cpp: fix loop condition that was causing crash
- 2:56 PM Changeset in webkit [29180] by
-
- 1 edit1 move4 adds2 deletes in trunk/LayoutTests
Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform
RS=Adam
- 2:43 PM Changeset in webkit [29179] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector
- page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
- page/inspector/inspector.html: Remove the toggle button.
- page/inspector/inspector.js: Remove code to toggle the status area.
- 2:35 PM Changeset in webkit [29178] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
Restore compatibility with shipping Safari beta.
WebKit:
http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start
- Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.
WebCore:
Temporarily restore BackwardDelete for Windows nightlies to work correctly.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::):
- 2:27 PM Changeset in webkit [29177] by
-
- 8 edits in trunk
Reviewed by Darin.
<rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)
Enable the fix on Windows.
- 2:08 PM Changeset in webkit [29176] by
-
- 2 edits in trunk/WebCore
Fix build.
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- 1:44 PM Changeset in webkit [29175] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin.
Partial fix for <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Disable media support if QuickTime is not current enough (>=7.3).
Windows patch coming soon.
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor):
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::isAvailable):
- platform/graphics/MediaPlayer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 1:02 PM Changeset in webkit [29174] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)
Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.
- page/inspector/PropertiesSidebarPane.js:
- page/inspector/inspector.css:
- 12:54 PM Changeset in webkit [29173] by
-
- 2 edits in trunk
2008-01-04 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.
This obviates the need to pass '--enable-maintainer-mode' to
configure.
- configure.ac:
- 11:31 AM Changeset in webkit [29172] by
-
- 3 edits4 adds in trunk
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
WebKit/win:
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Test: platform/win/editing/selection/shift-page-down-up.html
Reviewed by Oliver.
- WebView.cpp: Correct the commands associated with Shift-PageUp/Shift-PageDown.
LayoutTests:
Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Reviewed by Oliver.
- platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
- platform/win/editing/selection/shift-page-up-down.html: Added.
- 11:25 AM Changeset in webkit [29171] by
-
- 2 edits1 move in trunk/LayoutTests
<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails
Reviewed by Darin
Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.
- 11:23 AM Changeset in webkit [29170] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix synthetic bold and italic on Windows
Covered by an existing test.
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 9:18 AM Changeset in webkit [29169] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added some more failures.
- 6:52 AM Changeset in webkit [29168] by
-
- 4 edits in trunk
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Terminate empty rules.
- 6:49 AM Changeset in webkit [29167] by
-
- 2 edits in trunk/WebKitTools
fix DRT after the changes to QWebPage.
The great thing is that we actually don't have
any regressions from the QWebPage change :)
Signed-off-by: Simon
- 6:49 AM Changeset in webkit [29166] by
-
- 10 edits in trunk
Remove most dependencies of Widget/ScrollView onto native QWidgets.
This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29165] by
-
- 3 edits in trunk/WebKit/qt
- Remove the todo from QWebPage and move the code to QWebView.
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29164] by
-
- 4 edits in trunk/WebKit/qt
- Move the various event methods to QWebPagePrivate. This is similar to QTextControl as well.
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29163] by
-
- 5 edits in trunk/WebKit/qt
- Forward the event from QWebView to QWebPage through QObject::event. This is similar to the way QTextControl is working.
Signed-off-by: Simon
- 6:47 AM Changeset in webkit [29162] by
-
- 16 edits in trunk
make QWebPage a QObject and get things to compile.
Nothing works currently though.
Signed-off-by: Simon
- 4:47 AM QtWebKitGitInstructions edited by
- Joe Doe needs quotes otherwise the name is Joe (diff)
- 4:26 AM Changeset in webkit [29161] by
-
- 3 edits in trunk/WebKit/qt
Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs
Signed-off-by: Lars
- 4:25 AM Changeset in webkit [29160] by
-
- 3 edits in trunk/WebKit/qt
add a viewportSize to QWebPage.
This is required to eventually make it a QObject only.
Signed-off-by: Simon
- 4:25 AM Changeset in webkit [29159] by
-
- 5 edits in trunk
take a QString as identifier in QWebFrame::addToJSWindowObject.
Signed-off-by: Simon
- 4:24 AM Changeset in webkit [29158] by
-
- 2 edits in trunk/WebKit/qt
Call the frame arguments for the javascript callbacks "originatingFrame"
Signed-off-by: Lars
- 4:24 AM Changeset in webkit [29157] by
-
- 4 edits in trunk/WebKit/qt
Moved the QWebPage::addToHistory signal into QWebHistoryInterface
Signed-off-by: Lars
- 4:23 AM Changeset in webkit [29156] by
-
- 7 edits in trunk/WebKit/qt
moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame
Signed-off-by: Simon
- 4:19 AM Changeset in webkit [29155] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bug URL in ChangeLog entry
- 4:18 AM Changeset in webkit [29154] by
-
- 2 edits in trunk/WebCore
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system
Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.
- GNUmakefile.am:
- 2:44 AM Changeset in webkit [29153] by
-
- 2 edits in trunk/WebCore
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Re-use a single static dummy surface rather than creating and
destroying a surface for each CairoPath.
- platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
- 12:16 AM Changeset in webkit [29152] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/Threading.h: The OSAtomic functions take non-volatile pointers on Tiger.
- 12:05 AM Changeset in webkit [29151] by
-
- 2 edits in trunk/WebKitTools
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for breakage introduced in r29149.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::execCommand):
Jan 3, 2008:
- 11:55 PM Changeset in webkit [29150] by
-
- 2 edits in trunk/WebCore
Use platform-provided atomic operations in place of inline assembly to increase portability.
Reviewed by Maciej Stachowiak.
- platform/Threading.h:
(WebCore::atomicIncrement):
(WebCore::atomicDecrement):
- 11:31 PM Changeset in webkit [29149] by
-
- 24 edits in trunk
Reviewed by Darin.
<rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
Added layoutTestController.execCommand to access editor commands that are not available
via document.execCommand.
- 11:15 PM Changeset in webkit [29148] by
-
- 4 edits4 adds in trunk
Fix <rdar://problem/5668517> REGRESSION: Major under painting issues in SVG (carto.net dock example)
Revied by Maciej.
We need to cache the absolute bounds of the <image>,
as there's no reliable way to recompute the old bounding
box one we have started layout.
- 10:34 PM Changeset in webkit [29147] by
-
- 2 edits in trunk/WebKit/gtk
2008-01-03 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16654
[GTK] Signal "navigation-requested" does not react correctly on
return TRUE from callbacks
- WebView/webkitwebview.cpp: use our own accumulator for signals returning WebKitNavigationResponse. The emission will be stopped when any callback returns anything but WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
- 10:23 PM Changeset in webkit [29146] by
-
- 2 edits in trunk/WebCore
2008-01-03 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Support building in Scratchbox, which has a version of make that fails
on wildcard syntax. Use a vpath to match IDL files instead.
- GNUmakefile.am:
- 10:00 PM Changeset in webkit [29145] by
-
- 2 edits in trunk/WebKit
- fix Safari build
- WebKit.xcodeproj/project.pbxproj: Mark header private (fixes Safari build).
- 9:41 PM Changeset in webkit [29144] by
-
- 2 edits in trunk/WebKitLibraries
Update Tiger library to a G3-friendly version.
- 8:38 PM Changeset in webkit [29143] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Sam Weinig.
- skip tests that are failing because font fallback results in a different font being used on Windows than on Mac.
- platform/win/Skipped:
- 8:22 PM Changeset in webkit [29142] by
-
- 3 edits in trunk/WebCore
2008-01-03 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5504775> PDF page will not load first time after Adobe
Reader install, unless browser is relaunched
Refresh and re-search the plugin database if the MIME type is not
registered.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isMIMETypeRegistered):
- plugins/win/PluginDatabaseWin.h:
- 8:03 PM Changeset in webkit [29141] by
-
- 4 edits in trunk/WebKitLibraries
Update libraries for <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 6:04 PM Changeset in webkit [29140] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16548 <rdar://problem/5659452> REGRESSION(r28810): Font style and sizes are weird for Japanese text
- platform/graphics/win/FontCacheWin.cpp: (WebCore::linkedFontEnumProc): Added. This callback is used to fetch a valid LOGFONT for a given family. (WebCore::getLinkedFonts): Added. Returns a vector of font families linked to the given font family by the Windows registry key HKLM\Software\...\FontLink\SystemLink. The registry values typically differ based on the installed language version of Windows. (WebCore::FontCache::getFontDataForCharacters): Changed to not use MLang font mapping, which is Windows code page based, except for characters in the range U+2000..U+200F. Instead, this function gets the font Uniscribe would use for the character. However, that font might not actually contain the character, in which case GDI font linking would substitute a different font. Therefore, this function walks the linked font list until it finds a font that actually contains the character.
- 5:28 PM Changeset in webkit [29139] by
-
- 14 edits in trunk
WebKitTools:
Reviewed by Darin, Mitz.
fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
the clickcount should not increase if the last click was at a different location. it's a new click.
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
- DumpRenderTree/mac/EventSendingController.h:
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]):
LayoutTests:
Reviewed by Darin, Mitz.
updating expected results after fixing clickcount for
<rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/mac/fast/events/objc-event-api-expected.txt:
- platform/mac/fast/inline/dirtyLinesForInline-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/svg/custom/pointer-events-image-expected.txt:
- platform/mac/svg/custom/pointer-events-path-expected.txt:
- platform/mac/svg/custom/pointer-events-text-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- 5:17 PM Changeset in webkit [29138] by
-
- 4 edits5 adds in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=16723 tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
Test: fast/table/border-changes.html
- html/HTMLTableElement.h:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Check the border type before and after parsing attributes, rather than doing this only for the rules attribute. (WebCore::HTMLTableElement::cellBorders): Added. (WebCore::HTMLTableElement::getSharedCellDecl): Changed to use cellBorders to factor out the rule about what type of borders to use.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=16723 tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
- fast/table/border-changes-expected.txt: Added.
- fast/table/border-changes.html: Added.
- fast/table/resources: Added.
- fast/table/resources/TEMPLATE.html: Added.
- fast/table/resources/border-changes.js: Added.
- 5:00 PM Changeset in webkit [29137] by
-
- 2 edits in trunk/WebKit/win
Replaced the use of editor command "ForwardDelete" with "DeleteForward" to be consistent
with our use of "DeleteBackward".
Rubber-stamped by Jon.
- WebView.cpp:
- 4:13 PM Changeset in webkit [29136] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
- Scripts/update-webkit: Make this work a little better for the people at Apple who have a directory named Internal.
- 2:45 PM Changeset in webkit [29135] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Darin.
Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
- Misc/WebNSFileManagerExtras.h:
- Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set "Where from:" metadata information.
- WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
- 2:10 PM Changeset in webkit [29134] by
-
- 39 edits in trunk/WebCore
Reviewed by Darin.
Pass the prototype of WebCore JS objects up the constructor chain
rather than explicitly setting using setPrototype. This removes many
redundant settings of the prototype on construction. To avoid a CG
hazard, the prototype must be constructed before before calling the
constructor of the JS object.
- JS objects that inherit from DOMObject, which all bindings objects (except Window) do, now can't implicitly have a jsNull prototype, but must explicitly pass it up the construction chain.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::JSEventTargetNode):
- bindings/js/JSEventTargetNode.h:
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- bindings/js/JSHTMLAudioElementConstructor.cpp: (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::toJS):
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
- bindings/js/JSHTMLInputElementBase.h:
- bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::JSLocation):
- bindings/js/JSLocation.h:
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
- bindings/js/JSNamedNodesCollection.h:
- bindings/js/JSNodeCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
- bindings/js/JSXMLHttpRequest.h:
- bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessor::JSXSLTProcessor): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp): (KJS::XSLTProcessorConstructorImp::implementsConstruct): (KJS::XSLTProcessorConstructorImp::construct):
- bindings/js/JSXSLTProcessor.h:
- bindings/js/kjs_binding.h: (KJS::DOMObject::DOMObject): (KJS::cacheDOMObject): (KJS::cacheSVGDOMObject):
- bindings/js/kjs_css.cpp: (WebCore::JSRGBColor::JSRGBColor): (WebCore::getJSRGBColor):
- bindings/js/kjs_css.h:
- bindings/js/kjs_events.cpp: (WebCore::JSClipboard::JSClipboard): (WebCore::toJS):
- bindings/js/kjs_events.h:
- bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp):
- bindings/js/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::PluginBase::PluginBase):
- bindings/js/kjs_navigator.h:
- bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::location): (KJS::Window::getValueProperty):
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGeneratorJS.pm:
- 1:40 PM Changeset in webkit [29133] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10909
Hixie's XMLHttpRequest/018.html test fails
This was fixed earlier, just adding a test case.
- http/tests/xmlhttprequest/web-apps/018-expected.txt: Added.
- http/tests/xmlhttprequest/web-apps/018.html: Added.
- http/tests/xmlhttprequest/web-apps/resources: Added.
- http/tests/xmlhttprequest/web-apps/resources/018-test.xml: Added.
- 1:21 PM Changeset in webkit [29132] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin.
This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html
- WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): Have the editor handle all the commands it supports instead of just text commands. If not handled by the editor, the webview will handle the command.
- 11:35 AM Changeset in webkit [29131] by
-
- 3 edits in trunk/WebKit/win
Regression: backspace stopped working on text inputs
- Replaced the use of editor command "BackwardDelete" with "DeleteBackward" since it's no longer supported.
Reviewed by Adam.
- WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
- WebView.cpp:
- 11:00 AM Changeset in webkit [29130] by
-
- 4 edits in trunk/WebCore
2008-01-03 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp.
-This is from http://bugs.webkit.org/show_bug.cgi?id=16115
Change the Gtk ContextMenuItem code to generate the GtkMenuItem
or GtkCheckMenuItem on the fly. Currently we will create a
GtkCheckMenuItem if the ContextMenuItem has been checked. What needs
to be done is to change WebCore to tell the platform code if an item
is checkable or not.
- platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked):
- 10:37 AM Changeset in webkit [29129] by
-
- 2 edits in trunk/WebKitTools
Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
Rubberstamped by Mark.
- Scripts/update-webkit-auxiliary-libs:
- 10:28 AM Changeset in webkit [29128] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
- update the project hierarchy to match the on-disk organization of the platform directory.
- WebCore.vcproj/WebCore.vcproj:
- 10:19 AM Changeset in webkit [29127] by
-
- 2 edits in trunk/WebKitTools
Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
Added a fuzz factor into the Last-Modified comparison for downloading
WebKitAuxiliaryLibrary.zip.
The zip file is served from a set of mirrors who give Last-Modified
times that are off by 1-3 seconds from each other. This was causing
the build bots to redownload WebKitAuxiliaryLibrary for every build,
which would then cause all of WebCore to rebuild each time.
Reviewed by Mark.
- Scripts/update-webkit-auxiliary-libs: Check if the new zip file is at least 30 seconds newer than the old one -- otherwise we assume that the difference in time is due to the mirrors being slightly offset from each other. (sub lastModifiedToUnixTime): Added.
- 9:15 AM Changeset in webkit [29126] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin.
Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
- 7:34 AM Changeset in webkit [29125] by
-
- 2 edits in trunk/WebCore
Fix a buffer overrun and a leak introduced in r29098
Reviewed by Mark.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Only allocate one buffer, and make it be big enough to hold the string contents plus the null terminator.
- 6:40 AM Changeset in webkit [29124] by
-
- 1 edit1 add in trunk/WebKitTools
Windows build fix.
- DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
- 5:53 AM Changeset in webkit [29123] by
-
- 11 edits in trunk
Moved QWebPage::open to QWebFrame::load and added setHtml.
Signed-off-by: Lars
- 5:50 AM Changeset in webkit [29122] by
-
- 13 edits2 adds in trunk
Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
Signed-off-by: Lars
- 5:40 AM Changeset in webkit [29121] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation with gcc 4.3, include limits.h for INT_MAX
- 4:02 AM Changeset in webkit [29120] by
-
- 2 edits in trunk/WebCore
2008-01-03 Alp Toker <alp@atoker.com>
Suggested by Mark Rowe.
Fix indentation and remove trailing whitespace.
- platform/network/curl/ResourceHandleManager.cpp:
- 3:57 AM QtWebKitContrib edited by
- (diff)
- 3:56 AM QtWebKitContrib edited by
- (diff)
- 3:53 AM QtWebKitContrib edited by
- (diff)
- 3:31 AM QtWebKitContrib edited by
- (diff)
- 3:04 AM Changeset in webkit [29119] by
-
- 2 edits in trunk/WebCore
2008-01-03 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
that the two POST methods don't conflict.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
- 1:30 AM QtWebKitTodo edited by
- (diff)
- 12:49 AM Changeset in webkit [29118] by
-
- 2 edits in trunk/JavaScriptCore
- tests/mozilla/expected.html: The fix for bug 16696 also fixed a test case, ecma_3/RegExp/perlstress-002.js, so updated results to expect that test to succeed.
Jan 2, 2008:
- 11:50 PM Changeset in webkit [29117] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Yet more renaming ideas.
- 11:44 PM Changeset in webkit [29116] by
-
- 6 edits in trunk/WebCore
- touched some files to try to get the Windows buildbot building again
- 11:37 PM Changeset in webkit [29115] by
-
- 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename
Oops, fix another.
- 11:37 PM Changeset in webkit [29114] by
-
- 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename
Oops, fix one.
- 11:36 PM Changeset in webkit [29113] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
- 10:47 PM Changeset in webkit [29112] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix small caps rendering
Covered by an existing test,
- platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::smallCapsFontData):
- 10:45 PM Changeset in webkit [29111] by
-
- 5 edits in branches/Safari-3-branch
Merge r27238 to fix a hang during the layout tests.
- 10:39 PM Changeset in webkit [29110] by
-
- 4 edits3 adds in trunk
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=16696 JSCRE fails fails to match Acid3 regexp
Test: fast/regex/early-acid3-86.html
The problem was with the cutoff point between backreferences and octal
escape sequences. We need to determine the cutoff point by counting the
total number of capturing brackets, which requires an extra pass through
the expression when compiling it.
- pcre/pcre_compile.cpp: (CompileData::CompileData): Added numCapturingBrackets. Removed some unused fields. (compileBranch): Use numCapturingBrackets when calling checkEscape. (calculateCompiledPatternLength): Use numCapturingBrackets when calling checkEscape, and also store the bracket count at the end of the compile. (jsRegExpCompile): Call calculateCompiledPatternLength twice -- once to count the number of brackets and then a second time to calculate the length.
LayoutTests:
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=16696 JSCRE fails fails to match Acid3 regexp
- fast/regex/early-acid3-86-expected.txt: Added.
- fast/regex/early-acid3-86.html: Added.
- fast/regex/resources/early-acid3-86.js: Added.
- fast/regex/test1-expected.txt: Updated for a few cases where we now fail. But these "failures" represent us replacing PCRE behavior with semantics that are correct for JavaScript regular expressions.
- 10:11 PM Changeset in webkit [29109] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed and landed by Darin.
- kjs/nodes.cpp: (KJS::DoWhileNode::execute): Added a missing return.
- 7:56 PM Changeset in webkit [29108] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver.
Calculate video position and size within the renderer box in WebCore. This
way the aspect ratio calculation is not needed in each MediaPlayer implementation.
This fixes video aspect ratio on Windows.
Covered by an existing pixel test.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox): (WebCore::RenderVideo::paintReplaced): (WebCore::RenderVideo::updatePlayer):
- rendering/RenderVideo.h:
- 6:33 PM Changeset in webkit [29107] by
-
- 2 edits in trunk/WebCore
Fix windows build.
- WebCore.vcproj/WebCore.vcproj:
- 6:09 PM Changeset in webkit [29106] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein
- fixed <rdar://problem/5579010> REGRESSION: Safari inserts newlines in tab names when U+2028 is present
- loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): in the code that replaces control characters with white space, also replace the unicode line separator and paragraph separator characters
- 6:07 PM Changeset in webkit [29105] by
-
- 3 edits in trunk
2008-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Alp.
Remove GDK_MULTIHEAD_SAFE and GTK_MULTIHEAD_SAFE because they break
the build. At least people doing a debug build on Ubuntu Hardy will see
the breakage. I was asked to leave the flags inside the files to ease future
debugging.
- GNUmakefile.am:
- WebKit.pri:
- 6:05 PM Changeset in webkit [29104] by
-
- 2 edits in trunk/WebKit/gtk
2008-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Darin.
Coding Style fix. Do not use an else because we use a return in the
if branch.
- WebView/webkitwebview.cpp:
- 6:00 PM Changeset in webkit [29103] by
-
- 2 edits in trunk/WebCore
- fix buffer overruns seen on buildbot
- platform/text/StringImpl.cpp: (WebCore::countCharacter): Added this. (WebCore::StringImpl::toCoordsArray): Use countCharacter instead of incorrect find expression. (WebCore::StringImpl::toLengthArray): Ditto. (WebCore::StringImpl::replace): Added assertions.
- 5:29 PM Changeset in webkit [29102] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: removing a fixed test this was fixed with r28836 but was left behind on the skipped list
- 5:25 PM Changeset in webkit [29101] by
-
- 24 edits8 adds in trunk
WebCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16657 Acid3 failure since table.caption and table.thead do not work for nodes added by appendChild
- fix http://bugs.webkit.org/show_bug.cgi?id=16659 Acid3 expects HTMLTableElement.rows to include a <tr> element that is an immediate child of the <table>
Tests: dom/html/level2/html/HTMLCollection07.html
dom/html/level2/html/HTMLCollection08.html
dom/html/level2/xhtml/HTMLCollection07.xhtml
dom/html/level2/xhtml/HTMLCollection08.xhtml
fast/dom/HTMLTableElement/early-acid3-65-excerpt.html
fast/dom/HTMLTableElement/early-acid3-66-excerpt.html
- GNUmakefile.am: Added HTMLTableRowsCollection.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- dom/XMLTokenizer.cpp: Took out stray include.
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter): Removed all the table rows code, since we now use a separate class for that collection. Also got rid of the distinct types for custom collections that don't need them (use Other for both).
- html/HTMLCollection.h: Also made firstItem non-virtual because it doesn't need to be virtual.
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::HTMLFormCollection): Use Other instead of FormElements for the HTMLCollection type.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): Eliminated m_head, m_foot, m_firstBody, and m_caption. (WebCore::HTMLTableElement::caption): Added non-inline version. Finds the caption rather than keeping a pointer to it. (WebCore::HTMLTableElement::setCaption): Rewrote. (WebCore::HTMLTableElement::tHead): Ditto. (WebCore::HTMLTableElement::setTHead): Ditto. (WebCore::HTMLTableElement::tFoot): Ditto. (WebCore::HTMLTableElement::setTFoot): Ditto. (WebCore::HTMLTableElement::createTHead): Ditto. (WebCore::HTMLTableElement::deleteTHead): Ditto. (WebCore::HTMLTableElement::createTFoot): Ditto. (WebCore::HTMLTableElement::deleteTFoot): Ditto. (WebCore::HTMLTableElement::createCaption): Ditto. (WebCore::HTMLTableElement::deleteCaption): Ditto. (WebCore::HTMLTableElement::lastBody): Added. (WebCore::HTMLTableElement::insertRow): Rewrote to use a loop based on code in HTMLTableRowsCollection. This is different from the old code mainly in how it handles rows outside any section. (WebCore::HTMLTableElement::deleteRow): Ditto. (WebCore::HTMLTableElement::addChild): Removed code to set the various members. Keeping pointers to these was a possible source of serious bugs too, including crashes with stale pointers, although I didn't write any test cases to prove those bugs existed. (WebCore::HTMLTableElement::parseMappedAttribute): Changed the rules code to visit all cells, not just the cells of the first body. I believe this fixed rendering on some table tests. I think the code visits too many cells and also the use of recursion is overkill, but I didn't try to fix that. (WebCore::HTMLTableElement::rows): Changed to use the new HTMLTableRowsCollection.
- html/HTMLTableElement.h: Changed functions to return PassRefPtr, which can be important if strange things like DOM mutation events take things ot of the tree before they are safely referenced by JavaScript wrappers. Also changed functions to take PassRefPtr and added exceptions. Removed unneeded firstTBody and setTBody functions and childrenChanged function override, as well as unused Rules and Frame enums. Removed m_head, m_foot, m_firstBody, and m_caption, and added lastBody function. Removed unneeded friend declaration for HTMLTableCellElement.
- html/HTMLTableElement.idl: Allow the setteres for caption, tHead, and tFoot to raise exceptions.
- html/HTMLTableRowsCollection.cpp: Added. Implements the HTML 5 rule for which rows are in the collection in which order.
- html/HTMLTableRowsCollection.h: Added.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): Use the standard insertRow function instead of coming up with our own way of inserting a row. Simplifies things -- we can remove the code to create a tbody element.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=16657 Acid3 failure since table.caption and table.thead do not work for nodes added by appendChild
- test for http://bugs.webkit.org/show_bug.cgi?id=16659 Acid3 expects HTMLTableElement.rows to include a <tr> element that is an immediate child of the <table>
- fast/dom/HTMLTableElement/early-acid3-65-excerpt-expected.txt: Added.
- fast/dom/HTMLTableElement/early-acid3-65-excerpt.html: Added.
- fast/dom/HTMLTableElement/early-acid3-66-excerpt-expected.txt: Added.
- fast/dom/HTMLTableElement/early-acid3-66-excerpt.html: Added.
- fast/dom/HTMLTableElement/resources/early-acid3-65-excerpt.js: Added.
- fast/dom/HTMLTableElement/resources/early-acid3-66-excerpt.js: Added.
- dom/html/level2/html/HTMLCollection07-expected.txt: Updated to reflect success.
- dom/html/level2/html/HTMLCollection08-expected.txt: Updated to reflect success.
- dom/xhtml/level2/html/HTMLCollection07-expected.txt: Updated to reflect success.
- dom/xhtml/level2/html/HTMLCollection08-expected.txt: Updated to reflect success.
- fast/dom/HTMLTableElement/resources/rows.js: Changed to expect HTML 5 behavior for rows outside table sections.
- fast/dom/HTMLTableElement/rows-expected.txt: Updated.
- platform/mac/tables/mozilla/bugs/bug30418-expected.checksum: Updated to reflect better results.
- platform/mac/tables/mozilla/bugs/bug30418-expected.png: Ditto.
- platform/mac/tables/mozilla/bugs/bug30418-expected.txt: Ditto.
- 5:11 PM Changeset in webkit [29100] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix Qt build
- wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::foldCase): Add some missing const.
- 4:58 PM Changeset in webkit [29099] by
-
- 4 edits in trunk/WebCore
Reviewed by Alice and Tim.
- try to fix GTK and Qt builds
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scroll): Improve logic slightly for the case of vertical scrolling when there's no vertical scroll bar.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::scroll): Copy the code from Windows. Maybe this should be factored differently.
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scroll): Ditto.
- 4:32 PM Changeset in webkit [29098] by
-
- 32 edits in trunk/WebCore
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=16712 change StringImpl to take and return PassRefPtr instead of raw pointers
Also eliminated use of const StringImpl. Since StringImpl is immutable there
is no distinction between a const and non-const one at the moment.
- WebCore.base.exp: Updated.
- css/CSSHelper.cpp: (WebCore::parseURL): Make String directly, not by making a StringImpl.
- dom/Attr.cpp: (WebCore::Attr::createTextChild): Convert AtomicString to String with domString, not via StringImpl. (WebCore::Attr::setValue): Remove unneed call to impl() when passing a String to a function that takes a String.
- dom/CDATASection.cpp: Removed unused constructor. (WebCore::CDATASection::cloneNode): Added a now-needed .get(). (WebCore::CDATASection::createNew): Changed function to take a PassRefPtr.
- dom/CDATASection.h:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): Removed unneeded initialization and ref() now that the string is a RefPtr. Also updated to not call "new StringImpl". (WebCore::CharacterData::~CharacterData): Removed unneeded deref() since it's a RefPtr. (WebCore::CharacterData::setData): More of that. (WebCore::CharacterData::substringData): Ditto. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::nodeValue): Ditto. (WebCore::CharacterData::dispatchModifiedEvent): Ditto. (WebCore::CharacterData::dump): Ditto.
- dom/CharacterData.h: Changed to use a RefPtr. I could have used a String instead, but since String adds extra branches to handle 0, I figured it was more conservative to just use RefPtr. Later it would be good to figure out which is preferred style and be more consistent. Maybe we'll phase out StringImpl, or maybe we'll go the other way and use it more since it can be more efficient.
- dom/DOMImplementation.cpp: (WebCore::addString): Changed set to use String rather than StringImpl. (WebCore::isSVG10Feature): Ditto. (WebCore::isSVG11Feature): Ditto. (WebCore::DOMImplementation::createDocument): Replaced custom code to find a colon with a call to String::find.
- dom/Range.cpp: (WebCore::Range::insertNode): Updated since the result of splitText is now a PassRefPtr.
- dom/Text.cpp: (WebCore::Text::splitText): Updated since str is now a RefPtr. Also made the result of this function be a PassRefPtr. (WebCore::Text::createRenderer): Ditto. (WebCore::Text::createNew): Made the parameter and result both be PassRefPtr.
- dom/Text.h:
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Use String::upper.
- html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): Remove now-unneeded const. (WebCore::numCharactersInGraphemeClusters): Ditto.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken): Updated for function name change.
- platform/text/AtomicString.cpp: (WebCore::CStringTranslator::translate): Updated since there is no longer a constructor that takes a string.
- platform/text/PlatformString.h: Added new constructors that take PassRefPtr and RefPtr. Removed misleading comment.
- platform/text/String.cpp: (WebCore::String::String): Changed to use StringImpl::create, which handles the empty string automatically. (WebCore::String::append): Ditto. (WebCore::String::charactersWithNullTermination): Similar. (WebCore::String::format): Ditto.
- platform/text/StringHash.h: Took out unneeded const.
- platform/text/StringImpl.cpp: (WebCore::deleteUCharVector): Changed to take a const pointer since the buffers are now const UChar buffers. (WebCore::StringImpl::StringImpl): Removed some constructors. Got rid of the separate init functions. The constructors are now private and used only in the create functions and one or two other places. (WebCore::StringImpl::containsOnlyWhitespace): Removed now-meaningless const. (WebCore::StringImpl::substring): Ditto. Also changed return value to be a PassRefPtr. (WebCore::StringImpl::characterStartingAt): Ditto. (WebCore::StringImpl::toLength): Ditto. (WebCore::StringImpl::toCoordsArray): Ditto. (WebCore::StringImpl::toLengthArray): Ditto. (WebCore::StringImpl::isLower): Ditto. (WebCore::StringImpl::lower): Ditto. Changed to use Vector and adopt so we don't have to use new directly here. Makes empty string handling more consistent. (WebCore::StringImpl::upper): Ditto. (WebCore::StringImpl::secure): Ditto. (WebCore::StringImpl::foldCase): Ditto. (WebCore::StringImpl::stripWhiteSpace): Ditto. (WebCore::StringImpl::simplifyWhiteSpace): Ditto. (WebCore::StringImpl::capitalize): Ditto. (WebCore::StringImpl::toInt): Removed now-meaningless const. (WebCore::StringImpl::toInt64): Ditto. (WebCore::StringImpl::toUInt64): Ditto. (WebCore::StringImpl::toDouble): Ditto. (WebCore::StringImpl::toFloat): Ditto. (WebCore::StringImpl::find): Ditto. (WebCore::StringImpl::reverseFind): Ditto. (WebCore::StringImpl::endsWith): Ditto. (WebCore::StringImpl::replace): Ditto. (WebCore::equal): Ditto. (WebCore::equalIgnoringCase): Ditto. (WebCore::StringImpl::ascii): Ditto. (WebCore::StringImpl::defaultWritingDirection): Ditto. (WebCore::StringImpl::createStrippingNullCharacters): Ditto. (WebCore::StringImpl::adopt): Added special case so this uses the shared empty string like other functions. Also optimized the common case where the vector happens to already have the right size so we don't do a fastRealloc at all in those cases. (WebCore::StringImpl::create): Added. These are now the public functions for creating new StringImpl objects. They all implement the shared empty string. (WebCore::StringImpl::createWithTerminatingNullCharacter):
- platform/text/StringImpl.h:
- platform/text/cf/StringCF.cpp: (WebCore::String::String): Use StringImpl::create instead of new StringImpl.
- platform/text/cf/StringImplCF.cpp: (WebCore::StringImpl::createCFString): Removed now-obsolete const.
- platform/text/mac/StringImplMac.mm: (WebCore::StringImpl::operator NSString *): Ditto.
- platform/text/mac/StringMac.mm: (WebCore::String::String): Use StringImpl::create instead of new StringImpl.
- platform/text/qt/StringQt.cpp: (WebCore::String::String): Ditto.
- platform/text/wx/StringWx.cpp: (WebCore::String::String): Ditto.
- rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): Ditto.
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::RenderSVGInlineText): Use PassRefPtr.
- rendering/RenderSVGInlineText.h:
- rendering/RenderText.cpp: (WebCore::charactersAreAllASCII): Removed now-unneeded const.
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Use RefPtr.
- 4:07 PM Changeset in webkit [29097] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/5618086> WebInspector does not expand the DOM tree after being closed
Closing the Web Inspector causes the DOM tree outline to be torn down, clearing the
internal element lookup tables. The represented DOM node object still holds the identifier
it was assigned, and a later call to findTreeElement will use that original identifier
against a cleared lookup table. In that case we need to fallback on DOM ancestor lookup.
- page/inspector/treeoutline.js: (TreeOutline.prototype.findTreeElement): If the DOM node already had a treeElementIdentifier, but the TreeOutline no longer has the element in the _knownTreeElements list do an ancestor lookup instead of an early return.
- 3:53 PM Changeset in webkit [29096] by
-
- 6 edits1 add in trunk
Reviewed by Sam Weinig.
need to export ASCIICType.h for use in DRT
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- wtf/ASCIICType.h: (WTF::isASCIIUpper):
WebKitTools:
Reviewed by Sam Weinig.
fixing assertion hit with editing/selection/move-begin-end.html
- DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
- 3:46 PM Changeset in webkit [29095] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Some more name change plans.
- 2:58 PM Changeset in webkit [29094] by
-
- 6 edits4 adds in trunk
WebCore:
Reviewed by Maciej.
Fixed <rdar://5283861> (problems scrolling in gmail message content area)
- platform/ScrollView.h:
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scroll): Changed return value to bool to reflect success of scroll attempt
WebKit/win:
Reviewed by Maciej.
Fixed <rdar://5283861> (problems scrolling in gmail message content area)
- WebView.cpp: (WebView::keyDown): bubble scrolling from a key event
LayoutTests:
Reviewed by Maciej.
Added test for <rdar://5283861> (problems scrolling in gmail message content area)
- fast/frames/iframe-scroll-page-up-down-expected.txt: Added.
- fast/frames/iframe-scroll-page-up-down.html: Added.
- fast/frames/resources/iframe-scroll-page-up-down-1.html: Added.
- fast/frames/resources/iframe-scroll-page-up-down-2.html: Added.
- 2:37 PM Changeset in webkit [29093] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Maciej.
Added handling for page up and page down in EventSender
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
- 2:23 PM Changeset in webkit [29092] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added some more failures.
- 1:32 PM Changeset in webkit [29091] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Cleanup error_object.h/cpp.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
- kjs/error_object.cpp: (KJS::): (KJS::ErrorInstance::ErrorInstance): (KJS::ErrorPrototype::ErrorPrototype): (KJS::ErrorProtoFuncToString::ErrorProtoFuncToString): (KJS::ErrorProtoFuncToString::callAsFunction): (KJS::ErrorObjectImp::ErrorObjectImp): (KJS::ErrorObjectImp::implementsConstruct): (KJS::ErrorObjectImp::construct): (KJS::ErrorObjectImp::callAsFunction): (KJS::NativeErrorPrototype::NativeErrorPrototype): (KJS::NativeErrorImp::NativeErrorImp): (KJS::NativeErrorImp::implementsConstruct): (KJS::NativeErrorImp::construct): (KJS::NativeErrorImp::callAsFunction): (KJS::NativeErrorImp::mark):
- kjs/error_object.h: (KJS::ErrorInstance::classInfo): (KJS::NativeErrorImp::classInfo):
- 1:07 PM Changeset in webkit [29090] by
-
- 2 edits in trunk/WebCore
Fixed a typo (pointed out in review, but I somehow missed it at first).
- editing/EditorCommand.cpp: (WebCore::executeDelete):
- 12:24 PM Changeset in webkit [29089] by
-
- 3 edits in trunk/LayoutTests
Get the Windows bots closer to green
- platform/win/Skipped: Added some new failures.
- platform/win/fast/dom/Window/window-properties-expected.txt: Updated these results.
- 11:14 AM Changeset in webkit [29088] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Fix fast/events/arrow-keys-on-body.html for real.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
- 10:31 AM Changeset in webkit [29087] by
-
- 15 edits6 adds in trunk
Reviewed by Darin.
Resolved several FIXMEs in EditorCommand.
Made recently added commands hidden from JS again.
Removed BackwardDelete implementation, which used to be dead code, but got exposed now.
Tests: editing/execCommand/delete-no-scroll.html
editing/execCommand/forward-delete-no-scroll.html
editing/execCommand/insert-line-break-no-scroll.html
- 9:34 AM Changeset in webkit [29086] by
-
- 4 edits27 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14555
action=mailto + method=get - The generated mailto URI is incorrect and the hvalues are encoded twice
http://bugs.webkit.org/show_bug.cgi?id=14774
Submitted data only includes first input item
Reworked encoding of mailto URLs to match other browsers.
Moved most of related logic from FrameLoader::submitForm() to HTMLFormElement::submit().
Tests: fast/forms/mailto/advanced-get.html
fast/forms/mailto/advanced-put.html
fast/forms/mailto/get-multiple-items-text-plain.html
fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html
fast/forms/mailto/get-multiple-items.html
fast/forms/mailto/get-non-ascii.html
fast/forms/mailto/get-non-ascii-text-plain.html
fast/forms/mailto/get-overwrite-query.html
fast/forms/mailto/post-append-query.html
fast/forms/mailto/post-multiple-items-multipart-form-data.html
fast/forms/mailto/post-multiple-items-text-plain.html
fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html
fast/forms/mailto/post-multiple-items.html
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
- 8:01 AM Changeset in webkit [29085] by
-
- 2 edits in trunk/WebCore
Autotools build fix.
- 7:14 AM Changeset in webkit [29084] by
-
- 2 edits in trunk/WebCore
Add missing dependencies to some GNUmakefile.am rules.
Rubber-stamped by Alp Toker.
- 6:42 AM Changeset in webkit [29083] by
-
- 2 edits in trunk/JavaScriptCore
Autotools fix. Add missing dependency on grammar.y.
Rubber-stamped by Alp Toker.
- 6:42 AM Changeset in webkit [29082] by
-
- 2 edits in trunk/WebCore
Autotools build fix. Make can expand $@ to any of the targets for the rule,
while we always want to use the name of the .cpp file as the output file.
Reviewed by Alp Toker.
- 4:56 AM Changeset in webkit [29081] by
-
- 2 edits in trunk/WebKitTools
2008-01-02 Luca Bruno <lethalman88@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16674
[GTK] run-launcher sets wrong LD_LIBRARY_PATH
- Scripts/run-launcher:
- 3:33 AM QtWebKitContrib edited by
- (diff)
- 2:25 AM Changeset in webkit [29080] by
-
- 7 edits in trunk
2008-01-02 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16115
[GTK] ContextMenu and ContextMenuItem lacks an implementation
Add context menu support.
Based on a patch by Holger Freyther.
- 1:07 AM Changeset in webkit [29079] by
-
- 2 edits in trunk/WebCore
2008-01-02 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Track changes in r29073.
- GNUmakefile.am:
Jan 1, 2008:
- 11:03 PM Changeset in webkit [29078] by
-
- 2 edits in trunk/WebCore
- fix release build
- bindings/js/kjs_binding.cpp: (KJS::setDOMException): Initialize to avoid uninitialized variable warning. Removed default so we get a warning if there's a missing case.
- 10:59 PM Changeset in webkit [29077] by
-
- 5 edits in trunk/WebCore
Scripting MIME Types application/ecmascript, application/javascript not viewable
<http://bugs.webkit.org/show_bug.cgi?id=11063>
Reviewed by Darin.
This patch consolidates the list of acceptable MIME types for JavaScript
source into the MIMETypeRegistry class, and replaces checks for these
types with a call to MIMETypeRegistry::isSupportedJavaScriptMIMEType().
No tests added since viewing JavaScript source is not testable.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Use MIMETypeRegistry::isSupportedJavaScriptMIMEType() instead of a single hard-coded MIME type, "application/x-javascript".
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): Moved list of JavaScript MIME types from here to MIMETypeRegistry::initialiseSupportedJavaScriptMIMETypes().
- platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedJavaScriptMIMETypes): Added. List of MIME types came from HTMLScriptElement::shouldExecuteAsJavaScript(). (WebCore::initialiseSupportedNonImageMimeTypes): Remove single hard-coded MIME type, "application/x-javascript", from the list. (WebCore::initialiseMIMETypeRegistry): Initialise supportedJavaScriptMIMETypes, then pre-populate supportedNonImageMIMETypes with values in supportedJavaScriptMIMETypes. (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): Added.
- platform/MIMETypeRegistry.h: Added isSupportedJavaScriptMIMEType().
- 10:54 PM Changeset in webkit [29076] by
-
- 1 edit in trunk/WebCore/WebCoreSources.bkl
Fix wx build
- 10:44 PM Changeset in webkit [29075] by
-
- 6 edits in trunk
Reviewed by Eric.
- fix for http://bugs.webkit.org/show_bug.cgi?id=16695 JSC allows non-identifier codepoints in identifiers (affects Acid3)
Test: fast/js/kde/parse.html
- kjs/lexer.cpp: (KJS::Lexer::lex): Added additional states to distinguish Unicode escapes at the start of identifiers from ones inside identifiers. Rejected characters that don't pass the isIdentStart and isIdentPart tests. (KJS::Lexer::convertUnicode): Removed incorrect FIXME comment.
- kjs/lexer.h: Added new states to distinguish \u escapes at the start of identifiers from \u escapes inside identifiers.
LayoutTests:
Reviewed by Eric.
- test for http://bugs.webkit.org/show_bug.cgi?id=16695 JSC allows non-identifier codepoints in identifiers (affects Acid3)
- fast/js/kde/parse-expected.txt: Updated.
- fast/js/kde/resources/parse.js: Added tests that cover both the non-ASCII characters themselves and the same characters parsed as \u sequences.
- 10:38 PM Changeset in webkit [29074] by
-
- 1 edit in trunk/WebKit/win/ForEachCoClass.cpp
Fix a stray executable bit.
- 9:46 PM Changeset in webkit [29073] by
-
- 31 edits15 copies1 move6 adds in trunk
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)
- Create JS objects for all the different types of exceptions, each with there own prototype and constructor.
- Abstract all the logic and storage for exception classes in to an ExceptionBase class.
- Move specialized ExceptionCodes into the exception classes. (ie. the EventExceptionCode enum is now in EventException).
Tests: fast/dom/DOMException/EventException.html
fast/dom/DOMException/RangeException.html
fast/dom/DOMException/XPathException.html
http/tests/xmlhttprequest/XMLHttpRequestException.html
svg/custom/SVGException.html
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/kjs_binding.cpp: (KJS::setDOMException):
- bindings/scripts/CodeGeneratorJS.pm: Use the constant values defined in the IDL as the ObjC bindings do.
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/DOMCoreException.cpp: Removed.
- dom/DOMCoreException.h: (WebCore::DOMCoreException::DOMCoreException):
- dom/DOMCoreException.idl:
- dom/Event.h:
- dom/EventException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::EventException::EventException): (WebCore::EventException::):
- dom/EventException.idl: Copied from WebCore/dom/DOMCoreException.idl.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent):
- dom/ExceptionBase.cpp: Copied from WebCore/dom/DOMCoreException.cpp. (WebCore::ExceptionBase::ExceptionBase): (WebCore::ExceptionBase::toString):
- dom/ExceptionBase.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::ExceptionBase::code):
- dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h: (WebCore::):
- dom/Range.cpp: (WebCore::Range::insertNode): (WebCore::Range::checkNodeWOffset): (WebCore::Range::checkNodeBA): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents): (WebCore::Range::surroundContents):
- dom/RangeException.h: (WebCore::RangeException::RangeException): (WebCore::RangeException::):
- dom/RangeException.idl:
- page/DOMWindow.idl:
- svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
- svg/SVGException.h: (WebCore::SVGException::SVGException): (WebCore::SVGException::):
- svg/SVGException.idl:
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getTransformToElement):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XMLHttpRequestException::XMLHttpRequestException): (WebCore::XMLHttpRequestException::):
- xml/XMLHttpRequestException.idl: Copied from WebCore/dom/DOMCoreException.idl.
- xml/XPathEvaluator.h:
- xml/XPathException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XPathException::XPathException): (WebCore::XPathException::):
- xml/XPathException.idl: Copied from WebCore/dom/DOMCoreException.idl.
- xml/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
- xml/XPathResult.cpp: (WebCore::XPathResult::convertTo): (WebCore::XPathResult::numberValue): (WebCore::XPathResult::stringValue): (WebCore::XPathResult::booleanValue): (WebCore::XPathResult::singleNodeValue): (WebCore::XPathResult::snapshotLength): (WebCore::XPathResult::iterateNext): (WebCore::XPathResult::snapshotItem):
LayoutTests:
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)
- fast/dom/DOMException/EventException-expected.txt: Added.
- fast/dom/DOMException/EventException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
- fast/dom/DOMException/RangeException-expected.txt: Added.
- fast/dom/DOMException/RangeException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
- fast/dom/DOMException/XPathException-expected.txt: Added.
- fast/dom/DOMException/XPathException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
- fast/dom/DOMException/resources/EventException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
- fast/dom/DOMException/resources/RangeException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
- fast/dom/DOMException/resources/XPathException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
- fast/dom/Window/window-properties-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt: Added.
- http/tests/xmlhttprequest/XMLHttpRequestException.html: Added.
- svg/custom/SVGException-expected.txt: Added.
- svg/custom/SVGException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
- svg/custom/resources/SVGException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
- 4:38 PM Changeset in webkit [29072] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Dan.
- fix http://bugs.webkit.org/show_bug.cgi?id=16700 Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
- DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of -[NSFileManager fileExistsAtPath:isDirectory:] before using the value of isDirectory.
- 12:44 PM Changeset in webkit [29071] by
-
- 2 edits in trunk/WebCore
Remove JSDomExceptionConstructor.lut.h from clean step
as it no longer exists.
- GNUmakefile.am:
- 12:42 PM Changeset in webkit [29070] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj:
- 11:52 AM Changeset in webkit [29069] by
-
- 3 edits in trunk/WebKit/win
Attempt to fix the Windows bots until they can get the Windows SDK installed.
- 11:47 AM Changeset in webkit [29068] by
-
- 4 edits in trunk/JavaScriptCore
- rolled scope chain optimization out; it was breaking the world
- 11:35 AM Changeset in webkit [29067] by
-
- 13 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- http://bugs.webkit.org/show_bug.cgi?id=16685 eliminate List::empty() to cut down on PIC branches
Also included one other speed-up -- remove the call to reserveCapacity from
FunctionBodyNode::processDeclarations in all but the most unusual cases.
Together these make SunSpider 1.016x as fast.
- JavaScriptCore.exp: Updated.
- kjs/ExecState.cpp: (KJS::globalEmptyList): Added. Called only when creating global ExecState instances. (KJS::ExecState::ExecState): Broke constructor up into three separate functions, for the three separate node types. Also went through each of the three and streamlined as much as possible, removing dead code. This prevents us from having to access the global in the function body version of the constructor.
- kjs/ExecState.h: Added emptyList(). Replaced the constructor with a set of three that are specific to the different node types that can create new execution state objects.
- kjs/array_object.cpp: (KJS::ArrayProtoFuncToLocaleString::callAsFunction): Use exec->emptyList() instead of List::empty(). (KJS::ArrayProtoFuncConcat::callAsFunction): Ditto. (KJS::ArrayProtoFuncSlice::callAsFunction): Ditto. (KJS::ArrayProtoFuncSplice::callAsFunction): Ditto. (KJS::ArrayProtoFuncFilter::callAsFunction): Ditto.
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Updated to call new ExecState constructor. (KJS::GlobalFuncImp::callAsFunction): Ditto (for eval).
- kjs/function_object.cpp: (FunctionObjectImp::construct): Use exec->emptyList() instead of List::empty().
- kjs/list.cpp: Removed List::empty.
- kjs/list.h: Ditto.
- kjs/nodes.cpp: (KJS::ElementNode::evaluate): Use exec->emptyList() instead of List::empty(). (KJS::ArrayNode::evaluate): Ditto. (KJS::ObjectLiteralNode::evaluate): Ditto. (KJS::PropertyListNode::evaluate): Ditto. (KJS::FunctionBodyNode::processDeclarations): Another speed-up. Check the capacity before calling reserveCapacity, because it doesn't get inlined the local storage vector is almost always big enough -- saving the function call overhead is a big deal. (KJS::FuncDeclNode::makeFunction): Use exec->emptyList() instead of List::empty(). (KJS::FuncExprNode::evaluate): Ditto.
- kjs/object.cpp: (KJS::tryGetAndCallProperty): Ditto.
- kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Ditto.
- kjs/string_object.cpp: (KJS::StringProtoFuncSplit::callAsFunction): Ditto.
- 11:16 AM Changeset in webkit [29066] by
-
- 4 edits in trunk
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=16648 REGRESSION (r28165): Yuku.com navigation prints "jsRegExpExecute failed with result -2" <rdar://problem/5646486> REGRESSION (r28165): Layout test fast/regex/test1 fails intermittently
Fixes 34 failing test cases in the fast/regex/test1.html test.
Restored the stack which prevents infinite loops for brackets that match the empty
string; it had been removed as an optimization.
Unfortunately, restoring this stack causes the regular expression test in SunSpider
to be 1.095x as slow and the overall test to be 1.004x as slow. Maybe we can find
a correct optimization to restore the speed!
It's possible the original change was on the right track but just off by one.
- pcre/pcre_exec.cpp: Add back eptrblock, but name it BracketChainNode. (MatchStack::pushNewFrame): Add back the logic needed here. (startNewGroup): Ditto. (match): Ditto.
LayoutTests:
Reviewed by Geoff.
- updated test results for https://bugs.webkit.org/show_bug.cgi?id=16648
- fast/regex/test1-expected.txt: Update results changed by restoring the logic to avoid failing on infinite repeats of brackets that match the empty string.
- 11:13 AM Changeset in webkit [29065] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- http://bugs.webkit.org/show_bug.cgi?id=16683 speed up function calls by making ScopeChain::push cheaper
This gives a 1.019x speedup on SunSpider.
After doing this, I realized this probably will be obsolete when the optimization
to avoid creating an activation object is done. When we do that one we should check
if rolling this out will speed things up, since this does add overhead at the time
you copy the scope chain.
- kjs/object.h: Removed the ScopeChain::release function. It was marked inline, and called in exactly one place, so moved it there. No idea why it was in this header file!
- kjs/scope_chain.cpp: Removed the overload of the ScopeChain::push function that takes another ScopeChain. It was unused. I think we used it over in WebCore at one point, but not any more.
- kjs/scope_chain.h: Changed ScopeChainNode into a struct rather than a class, got rid of its constructor so we can have one that's uninitialized, and moved the refCount into a derived struct, ScopeChainHeapNode. Made _node mutable so it can be changed in the moveToHeap function. Changed the copy constructor and assignment operator to call moveToHeap, since the top node can't be shared when it's embedded in another ScopeChain object. Updated functions as needed to handle the case where the first object isn't on the heap or to add casts for cases where it's guaranteed to be. Changed the push function to always put the new node into the ScopeChain object; it will get put onto the heap when needed later.
- 10:57 AM Changeset in webkit [29064] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Fixed slight logic error in reserveCapacity, where we would reallocate
the storage buffer unnecessarily.
- wtf/Vector.h: (WTF::::reserveCapacity): No need to grow the buffer if newCapacity is equal to capacity().
- 10:14 AM BuildingGtk edited by
- link to ApplicationsGtk (diff)
- 10:12 AM ApplicationsGtk edited by
- added PyWebKitGtk (diff)
- 10:05 AM Changeset in webkit [29063] by
-
- 2 edits in trunk/WebCore
Try again to fix the builds
- DerivedSources.make:
- 9:45 AM Changeset in webkit [29062] by
-
- 4 edits in trunk/WebCore
Fix non-mac builds.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 2:40 AM Changeset in webkit [29061] by
-
- 3 edits2 adds in trunk
Reviewed by Alexey.
Don't replace \ with / in data: urls
http://bugs.webkit.org/show_bug.cgi?id=16692
Test: fast/loader/url-data-replace-backslash.html
- platform/KURL.cpp: (WebCore::KURL::init):
- 1:05 AM Changeset in webkit [29060] by
-
- 4 edits in trunk
2008-01-01 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Track changes in r29051, r29058 and pass the
correct parameter to AM_INIT_AUTOMAKE.
- 12:43 AM Changeset in webkit [29059] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16684 eliminate debugger overhead from function body execution
Speeds SunSpider up 1.003x. That's a small amount, but measurable.
- JavaScriptCore.exp: Updated.
- kjs/Parser.h: (KJS::Parser::parse): Create the node with a static member function named create() instead of using new explicitly.
- kjs/grammar.y: Changed calls to new FunctionBodyNode to use FunctionBodyNode::create().
- kjs/nodes.cpp: (KJS::ProgramNode::create): Added. Calls new. (KJS::EvalNode::create): Ditto. (KJS::FunctionBodyNode::create): Ditto, but creates FunctionBodyNodeWithDebuggerHooks when a debugger is present. (KJS::FunctionBodyNode::execute): Removed debugger hooks. (KJS::FunctionBodyNodeWithDebuggerHooks::FunctionBodyNodeWithDebuggerHooks): Added. (KJS::FunctionBodyNodeWithDebuggerHooks::execute): Calls the debugger, then the code, then the debugger again.
- kjs/nodes.h: Added create functions, made the constructors private and protected.
Dec 31, 2007:
- 7:04 PM Changeset in webkit [29058] by
-
- 10 edits8 adds2 deletes in trunk
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects
- Make DOMException a real JS object.
Test: fast/dom/DOMException/prototype-object.html
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
This is no longer needed as the autogenerated classes now includes the
constructor.
- bindings/js/JSDOMExceptionConstructor.cpp: Removed.
- bindings/js/JSDOMExceptionConstructor.h: Removed.
Create on demand and use the new class for DOMExceptions.
- bindings/js/kjs_binding.cpp: (KJS::setDOMException):
Remove no longer needed custom constructor getter.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.
- bindings/scripts/CodeGeneratorJS.pm:
The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.
- dom/DOMCoreException.cpp: Added. (WebCore::DOMCoreException::DOMCoreException): (WebCore::DOMCoreException::toString):
- dom/DOMCoreException.h: Added. (WebCore::DOMCoreException::): (WebCore::DOMCoreException::code): (WebCore::DOMCoreException::name): (WebCore::DOMCoreException::message):
- dom/DOMCoreException.idl: Added.
- page/DOMWindow.idl:
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects
- fast/dom/DOMException: Added.
- fast/dom/DOMException/prototype-object-expected.txt: Added.
- fast/dom/DOMException/prototype-object.html: Added.
- fast/dom/DOMException/resources: Added.
- fast/dom/DOMException/resources/prototype-object.js: Added.
- fast/dom/Window/window-properties-expected.txt:
- http/tests/xmlhttprequest/connection-error-sync-expected.txt:
- 6:01 PM Changeset in webkit [29057] by
-
- 5 edits in trunk/WebCore
Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.
- WebCore.vcproj/build-generated-files.sh:
- bindings/scripts/CodeGeneratorCOM.pm:
- dom/Document.idl:
- dom/Element.idl:
- 5:45 PM Changeset in webkit [29056] by
-
- 2 edits in trunk/LayoutTests
- fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success. I accdidentally landed an expected failure instead!
- 5:37 PM Changeset in webkit [29055] by
-
- 3 edits in trunk/WebCore
- fix Windows build
- dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing up as pure virtual functions. Sam can fix this later.
- dom/Element.idl: Ditto.
- 5:32 PM Changeset in webkit [29054] by
-
- 21 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=14134 <rdar://problem/5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
Test: fast/dynamic/create-renderer-for-whitespace-only-text.html
- dom/Node.cpp: (WebCore::Node::attach): Added code to check if this node's renderer has become the "previous renderer" of any sibling text node, and if so, ensure that that node gets a renderer if it now needs one. (WebCore::Node::createRendererIfNeeded): Removed the assertion that the node is not attached.
LayoutTests:
Reviewed by Darin Adler.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14134 <rdar://problem/5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
- fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
- fast/dynamic/style-access-late-stylesheet-load-expected.txt:
- platform/mac-leopard/fast/dynamic: Added.
- platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
- platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
- platform/mac/editing/selection/4983858-expected.txt:
- platform/mac/editing/selection/5136696-expected.txt:
- platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
- platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
- platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- 5:17 PM Changeset in webkit [29053] by
-
- 7 edits6 adds in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=16641 Acid3 reveals HTMLFormElement.elements fails to update when element name changes
Test: fast/dom/HTMLFormElement/elements-not-in-document.html
This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Removed bogus comment. (WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion call here, since this code path bypasses the subtree-modified event code.
- dom/Element.cpp: (WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML collections are for things in the document. (WebCore::Element::setAttributeMap): Ditto.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to incDOMTreeVersion here; covers most cases of tree structure changes.
- dom/Node.cpp: (WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer has nothing to do with changes to the DOM tree! (WebCore::Node::detach): Ditto.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion. This is handled at a lower level and doesn't need to be here. (WebCore::HTMLFormElement::removeFormElement): Ditto.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=16641 Acid3 reveals HTMLFormElement.elements fails to update when element name changes
- fast/dom/HTMLFormElement: Added.
- fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
- fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
- fast/dom/HTMLFormElement/resources: Added.
- fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
- fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
- 4:20 PM Changeset in webkit [29052] by
-
- 2 edits in trunk/WebKitTools
Suggested by Antti.
- Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until we get it installed on the build bots.
- 4:18 PM Changeset in webkit [29051] by
-
- 16 edits8 adds in trunk
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging
Test: http/tests/messaging/cross-domain-message-send.html
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the postMessage function. (WebCore::JSDOMWindow::postMessage):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Event.cpp: (WebCore::Event::isMessageEvent):
- dom/Event.h:
- dom/EventNames.h: New event name
- dom/MessageEvent.cpp: Added.
- dom/MessageEvent.h: Added.
- dom/MessageEvent.idl: Added.
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Added.
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging
- fast/dom/Window/window-properties-expected.txt:
- http/tests/messaging: Added.
- http/tests/messaging/cross-domain-message-send-expected.txt: Added.
- http/tests/messaging/cross-domain-message-send.html: Added.
- http/tests/messaging/resources: Added.
- http/tests/messaging/resources/cross-domain-message-receive.html: Added.
- 3:56 PM Changeset in webkit [29050] by
-
- 3 edits in trunk/WebCore
Suggested by Antti.
- turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
- WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
- WebCore.vcproj/build-generated-files.sh: Ditto.
- 4:56 AM ApplicationsGtk edited by
- Add a feed reader app (diff)
Dec 30, 2007:
- 11:48 PM Changeset in webkit [29049] by
-
- 2 edits in trunk/WebCore
2007-12-30 Alp Toker <alp@atoker.com>
Reviewed by Dan Bernstein.
Silence warning.
- dom/NodeList.h:
- 11:06 PM Changeset in webkit [29048] by
-
- 3 edits in trunk/WebKit/win
Reviewed by Darin.
Bug 16578: Windows Web Inspector window needs minimum size
http://bugs.webkit.org/show_bug.cgi?id=16578
- WebInspectorClient.cpp: (WebInspectorClient::onGetMinMaxInfo): (WebInspectorWndProc):
- WebInspectorClient.h:
- 11:03 PM Changeset in webkit [29047] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
More small cleanup to array_object.cpp
- kjs/array_object.cpp: (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction):
- 11:03 PM Changeset in webkit [29046] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
Apply wkstyle to array_object.cpp
- kjs/array_object.cpp: (KJS::ArrayPrototype::ArrayPrototype): (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction): (KJS::ArrayObjectImp::ArrayObjectImp): (KJS::ArrayObjectImp::implementsConstruct): (KJS::ArrayObjectImp::construct): (KJS::ArrayObjectImp::callAsFunction):
- 11:02 PM Changeset in webkit [29045] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Sam.
Remove maxInt/minInt, replacing with std:max/min<int>()
- kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction):
- kjs/operations.cpp:
- kjs/operations.h:
- 11:02 PM Changeset in webkit [29044] by
-
- 4 edits3 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16387
Variable names can be enumerated across domains
<rdar://problem/5640454>
Test: http/tests/security/cross-frame-access-enumeration.html
- bindings/js/kjs_window.cpp: (KJS::Window::getPropertyNames): Override method to test same-origin policy.
- bindings/js/kjs_window.h:
LayoutTests:
Reviewed by Oliver Hunt.
- http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
- http/tests/security/cross-frame-access-enumeration.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html: Added.
- 11:01 PM Changeset in webkit [29043] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Sam.
- Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
- 10:37 PM Changeset in webkit [29042] by
-
- 1 edit1 add in trunk/LayoutTests
- added missing results file
- fast/events/event-instanceof-expected.txt: Added.
- 2:24 PM Changeset in webkit [29041] by
-
- 13 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception
Add JS constructors for all the Event types.
Test: fast/events/event-instanceof.html
- WebCore.xcodeproj/project.pbxproj:
- dom/KeyboardEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/OverflowEvent.idl:
- dom/ProgressEvent.idl:
- dom/TextEvent.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- page/DOMWindow.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Test for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception
- fast/dom/Window/window-properties-expected.txt:
- fast/events/event-instanceof.html: Added.
- fast/events/resources/event-instanceof.js: Added.
- 9:44 AM Changeset in webkit [29040] by
-
- 2 edits in trunk
2007-12-30 Alp Toker <alp@atoker.com>
Build fix for older autoconf versions.
- configure.ac:
- 9:05 AM Changeset in webkit [29039] by
-
- 6 edits8 moves2 adds in trunk
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=15359 JPEG image not shown when height is specified as percentage inside a table
The problem occurs when a replaced element (image, canvas, etc.) with
a percent-height attribute is contained by a table cell with an auto-
or percent-height attribute. If there are no other conditions to cause
the table cell's height to expand, an available height of zero will
always be returned. In these cases, the intrinsic height of the
replaced element should be used if it is greater than the available
height of the table cell.
Tests: fast/replaced/table-percent-height.html
tables/mozilla/bugs/bug137388-1.html
tables/mozilla/bugs/bug137388-2.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing):
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=15359 JPEG image not shown when height is specified as percentage inside a table
This test was added specifically for this bug. It tests the height of
replaced elements (canvas, embed, img, object, button, input, isindex,
select, textarea ) within table cells.
- fast/replaced/table-percent-height-expected.txt: Added.
- fast/replaced/table-percent-height.html: Added.
These test results were updated because they are more correct.
- platform/mac/fast/replaced/width100percent-image-expected.checksum: Updated.
- platform/mac/fast/replaced/width100percent-image-expected.png: Updated.
- platform/mac/fast/replaced/width100percent-image-expected.txt: Updated.
Moved tests and results for these two tests from tables/mozilla_expected_failures/bugs
to tables/mozilla/bugs since these results have been fixed.
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum.
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png.
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt.
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum.
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png.
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Removed.
- tables/mozilla/bugs/bug137388-1.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-1.html.
- tables/mozilla/bugs/bug137388-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-2.html.
- tables/mozilla_expected_failures/bugs/bug137388-1.html: Removed.
- tables/mozilla_expected_failures/bugs/bug137388-2.html: Removed.
- 8:21 AM Changeset in webkit [29038] by
-
- 17 edits in trunk/WebKitSite
2007-12-30 Mark Rowe <mrowe@apple.com>
Unreviewed. Update WordPress to 2.3.2, which includes security fixes.
- blog/wp-admin/admin.php:
- blog/wp-admin/includes/file.php:
- blog/wp-admin/install.php:
- blog/wp-admin/setup-config.php:
- blog/wp-app.php:
- blog/wp-includes/formatting.php:
- blog/wp-includes/functions.php:
- blog/wp-includes/pluggable.php:
- blog/wp-includes/post.php:
- blog/wp-includes/query.php:
- blog/wp-includes/taxonomy.php:
- blog/wp-includes/version.php:
- blog/wp-includes/wp-db.php:
- blog/wp-mail.php:
- blog/wp-settings.php:
- blog/xmlrpc.php:
- 3:52 AM Changeset in webkit [29037] by
-
- 2 edits in trunk/WebCore
2007-12-30 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16099
Crash in CURL for empty POST
We have to set POST even when the data is empty, otherwise cURL will
hang while waiting for a response.
- platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::setupPOST): allow empty POST
- 12:38 AM Changeset in webkit [29036] by
-
- 12 edits1 add in trunk
Reviewed by Sam.
Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.
- kjs/number_object.cpp: (KJS::numberToString):
- kjs/object.cpp: (KJS::Error::create): Remove bogus debug lines.
Dec 29, 2007:
- 10:47 PM Changeset in webkit [29035] by
-
- 4 edits in trunk
2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Enable Database, XPath and XSLT features by default
Move all SVG related stuff inside SVG block. Don't include
SVGNames, SVGElementFactory, and XLinkNames when SVG is not
enabled
- 10:13 PM Changeset in webkit [29034] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14428
FCKEditor: Images disappear on drag/drop and copy/paste
Test: editing/pasteboard/drag-image-in-about-blank-frame.html
- editing/markup.cpp: (WebCore::createFragmentFromMarkup): Don't use "about:blank" as a base URL, just like we don't use an empty one.
- 7:33 PM Changeset in webkit [29033] by
-
- 15 edits in trunk
2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16669
autotools update and fixes
- 4:33 PM Changeset in webkit [29032] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Oliver.
- fix http://bugs.webkit.org/show_bug.cgi?id=16663 leak bot shows createCStringFromNPVariant result leaking
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke): Added a missing free.
- 8:06 AM Changeset in webkit [29031] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey.
Respect horiz-origin-x / horiz-origin-y / vert-origin-x / vert-origin-y properties when drawing SVG Fonts.
(Fixes fonts-elem-05-t.svg in a --svg-fonts build)
- 6:00 AM Changeset in webkit [29030] by
-
- 4 edits in trunk
2007-12-29 Alp Toker <alp@atoker.com>
Fix typo.
- hosted/sunspider.html:
- 5:50 AM Changeset in webkit [29029] by
-
- 7 edits in trunk/WebCore
Reviewed by Oliver.
Further SVG Font work. Parse all <glyph> attributes, using SVGGlyphElement::buildGlyphIdentifier.
SVGFontElement::collectGlyphs() now uses this method. Per character advance values work well now.
- 5:03 AM Changeset in webkit [29028] by
-
- 4 edits in trunk
2007-12-29 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
Provide the current URL in the SunSpider results page. Useful for
copying benchmark results out of browsers without a location bar or
where the location bar can't handle long URLs.
- hosted/sunspider-results.html:
- 4:50 AM Changeset in webkit [29027] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver.
Refactor SVGAnimationElement::parseValues into a generic function parseDelimitedString.
SVGAnimationElement needs to parse semicolon-seperated strings, SVGGlyphElement comma-seperated.
- 3:59 AM Changeset in webkit [29026] by
-
- 7 edits in trunk/WebCore
Reviewed by Maciej.
Add new helper structure SVGFontData - FontData holds this object as OwnPtr.
Store several attribute values there (horiz-adv-x, horiz-origin-x etc..)
To optimize for the common case ('FontData' used for HTML rendering) it feels
better to hold one OwnPtr in FontData, than several floats.
Parse all <font> attributes in SVGFontFaceElement::createFontData.
- 1:31 AM ApplicationsGtk edited by
- Add more applications (diff)
Dec 28, 2007:
- 11:42 PM Changeset in webkit [29025] by
-
- 3 edits in trunk/WebCore
- try to fix Windows and WX builds (broken by SVG Fonts check-in)
- platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent, now that it requires it. I can't see how it can be right to require the font size for ascent and descent, but not for other metrics functions in FontData.
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent and FontData::descent.
- 11:35 PM Changeset in webkit [29024] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15734
fast/xpath/namespace-vs-predicate.xhtml fails unexpectedly in no-SVG build
- fast/xpath/namespace-vs-predicate.xhtml: Use (hopefully) correct code to remove an SVG element.
- 11:27 PM Changeset in webkit [29023] by
-
- 3 edits in trunk/LayoutTests
- checked in these files that were supposed to be part of the previous check-in, but somehow weren't
- fast/js/number-tofixed-expected.txt: Updated.
- fast/js/number-toprecision-expected.txt: Ditto.
- 9:51 PM Changeset in webkit [29022] by
-
- 3 edits in trunk/JavaScriptCore
2007-12-28 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
ASSERT when debugging via Drosera due to missed var lookup optimization.
http://bugs.webkit.org/show_bug.cgi?id=16634
No test case possible.
- kjs/nodes.cpp: (KJS::BreakpointCheckStatement::optimizeVariableAccess):
- kjs/nodes.h:
- 8:19 PM Changeset in webkit [29021] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=16650 <rdar://problem/5664872> REGRESSION (r28278-r28314): ATSUI uses LTR writing direction for all text runs
Covered by existing pixel tests.
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected to maintain the style information in the adjusted text run when passing it to ATSUILayoutParameters. Prior to r28298 the style was passed separately.
- 8:01 PM Changeset in webkit [29020] by
-
- 7 edits5 adds in trunk
Reviewed by Oliver.
Fix (-0).toFixed() and re-factor a little
Fix (-0).toExponential() and printing of trailing 0s in toExponential
Fix toPrecision(nan) handling
- kjs/number_object.cpp: (KJS::numberToFixed): (KJS::fractionalPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
- 7:27 PM Changeset in webkit [29019] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Add wtf/OwnPtr.h include, to fix --svg-fonts build.
- 7:17 PM Changeset in webkit [29018] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
More changes to make number code readable
- kjs/number_object.cpp: (KJS::integer_part_noexp): (KJS::numberToFixed): (KJS::numberToExponential):
- 7:16 PM Changeset in webkit [29017] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
More small cleanups to toPrecision
- kjs/number_object.cpp: (KJS::numberToPrecision):
- 7:16 PM Changeset in webkit [29016] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
More small attempts to make number code readable
- kjs/number_object.cpp: (KJS::exponentialPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
- 7:15 PM Changeset in webkit [29015] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-28 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Break out callAsFunction implementations into static functions
- kjs/number_object.cpp: (KJS::numberToString): (KJS::numberToFixed): (KJS::numberToExponential): (KJS::numberToPrecision): (KJS::NumberProtoFunc::callAsFunction):
- 7:14 PM Changeset in webkit [29014] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam.
Apply wkstyle/astyle and fix placement of *
- kjs/number_object.cpp: (KJS::): (KJS::NumberInstance::NumberInstance): (KJS::NumberPrototype::NumberPrototype): (KJS::NumberProtoFunc::NumberProtoFunc): (KJS::integer_part_noexp): (KJS::intPow10): (KJS::NumberProtoFunc::callAsFunction): (KJS::NumberObjectImp::NumberObjectImp): (KJS::NumberObjectImp::getOwnPropertySlot): (KJS::NumberObjectImp::getValueProperty): (KJS::NumberObjectImp::implementsConstruct): (KJS::NumberObjectImp::construct): (KJS::NumberObjectImp::callAsFunction):
- kjs/object.cpp: (KJS::JSObject::put):
- 6:48 PM Changeset in webkit [29013] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-28 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16642
[GTK] webkit_web_view_has_selection returns the opposite result
Invert the return value.
- WebView/webkitwebview.cpp:
- 6:41 PM Changeset in webkit [29012] by
-
- 48 edits13 adds4 deletes in trunk
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10649 (WebKit SVG needs SVG Fonts support)
Begin implementation of SVG Fonts module. Basic documents using SVG Fonts already work.
Only local, in-document fonts who declare their glyphs using the <glyph d="..."> path syntax
are supported. (<glyph> containing arbitary SVG content as child elements, not supported yet).
- 5:36 PM BuildingOnWindows edited by
- Add info on building in VS (diff)
Dec 27, 2007:
- 11:50 PM Changeset in webkit [29011] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
- fix http://bugs.webkit.org/show_bug.cgi?id=16628 ASSERTION FAILED: m_resizeLayer (running layout tests)
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Avoid calling EventHandler::resizeLayerDestroyed() if the document is being destroyed.
- 11:13 PM ApplicationsGtk created by
- List WebKit/GTK+ applications (feel free to add more)
- 7:22 PM Changeset in webkit [29010] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix http://bugs.webkit.org/show_bug.cgi?id=16603 <rdar://problem/5664199> Crash when resizing text field
Test: fast/layers/resize-layer-deletion-crash.html
The event handler has only a weak reference to the layer that is
currently in resize mode, so it is the layer's responsibility to let
the event handler know if it has been destroyed while in that mode.
- page/EventHandler.cpp: (WebCore::EventHandler::resizeLayerDestroyed): Added. Resets m_resizeLayer to 0.
- page/EventHandler.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Added a call to EventHandler::resizeLayerDestroyed() if the layer is in resize mode.
LayoutTests:
Reviewed by Oliver Hunt.
- test for http://bugs.webkit.org/show_bug.cgi?id=16603 <rdar://problem/5664199> Crash when resizing text field
- fast/layers/resize-layer-deletion-crash-expected.txt: Added.
- fast/layers/resize-layer-deletion-crash.html: Added.
- 5:25 PM Changeset in webkit [29009] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Alice Liu.
- platform/win/Skipped: Remove xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html since it is now passing.
- 4:57 PM Changeset in webkit [29008] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>
The same-origin check was missing in the implementation of
setTimeout, setInterval, addEventListener, and removeEventListener.
Suppose <http://www.badguy.com/> contains an iframe to
<http://www.goodguy.com/>. Now www.badguy.com can steal
www.goodguy.com cookies by running this code:
setTimeout.call(frames[0], "alert(document.cookie)", 1000);
This patch changes the behavior so that setTimeout to does
nothing and returns an undefined value if the caller is not
permitted to script the window whose setTimeout method is being
called. The same applies to setInterval, addEventListener, and
removeEventListener.
Tests: http/tests/security/cross-frame-access-call.html
- bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncSetTimeout::callAsFunction) (KJS::WindowProtoFuncSetInterval::callAsFunction) (KJS::WindowProtoFuncAddEventListener::callAsFunction) (KJS::WindowProtoFuncRemoveEventListener::callAsFunction)
LayoutTests:
Reviewed by Sam Weinig.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>
- http/tests/security/cross-frame-access-call-expected.txt: Added.
- http/tests/security/cross-frame-access-call.html: Added.
- 4:11 PM Changeset in webkit [29007] by
-
- 3 edits8 adds in trunk
WebCore:
Reviewed by Dave Hyatt and Sam Weinig.
- fix <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
Test: fast/layers/add-layer-with-nested-stacking.html
Test: fast/layers/remove-layer-with-nested-stacking.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::addChild): If the new child is overflow-only but has children of its own, dirty the stacking context's z-order lists since the grandchildren might need to be in them. (WebCore::RenderLayer::removeChild): Similarly for the old child.
LayoutTests:
Reviewed by Dave Hyatt and Sam Weinig.
- pixel tests for <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
- fast/layers/add-layer-with-nested-stacking.html: Added.
- fast/layers/remove-layer-with-nested-stacking.html: Added.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.checksum: Added.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
- platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.checksum: Added.
- platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- 3:14 PM Changeset in webkit [29006] by
-
- 6 edits in trunk
2007-12-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16353
[GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.)
Added the flags mentioned in the bug only when doing 'debug'
builds. -DGST_DISABLE_DEPRECATED only added when video is enabled.
- 2:20 PM Changeset in webkit [29005] by
-
- 3 edits3 adds in trunk
Reviewed by Sam.
ASSERT in JavaScriptCore while viewing WICD test case
http://bugs.webkit.org/show_bug.cgi?id=16626
- kjs/nodes.cpp: (KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place
- 1:58 PM Changeset in webkit [29004] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Alice Liu.
- platform/mac-leopard/Skipped: Remove dom/html/level2/html/HTMLDocument12.html from the Skipped list because it is now passing.
- 12:55 PM Changeset in webkit [29003] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typo in ChangeLog
- 12:54 PM Changeset in webkit [29002] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16490 ASSERT in ~FrameView while viewing/reloading WICD test case
Test: fast/dynamic/paused-event-dispatch.html
- page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Changed to always pause event dispatch and always resume event dispatch, regardless of whether the post-layout task time is active. However, if it is active, assert that event dispatch is still paused.
LayoutTests:
Reviewed by Eric Seidel.
- test for http://bugs.webkit.org/show_bug.cgi?id=16490 ASSERT in ~FrameView while viewing/reloading WICD test case
- fast/dynamic/paused-event-dispatch-expected.txt: Added.
- fast/dynamic/paused-event-dispatch.html: Added.
- fast/dynamic/resources/paused-event-dispatch-iframe.html: Added.
- 8:54 AM Changeset in webkit [29001] by
-
- 2 edits in trunk/PlanetWebKit
Add another feed to Planet WebKit.
- 12:34 AM Changeset in webkit [29000] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Maciej.
- platform/win/Skipped: Move cross-frame-access-protocol* tests to show that they are failing because of a lack of ssl on windows.
- 12:28 AM Changeset in webkit [28999] by
-
- 48 edits in trunk/LayoutTests
Rubber-stamped by Maciej.
- Change more tests to use the new layoutTestController.globalFlag style polling instead of the "flag frame hack".
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-port-expected.txt:
- http/tests/security/cross-frame-access-private-browsing-expected.txt:
- http/tests/security/cross-frame-access-protocol-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
- http/tests/security/host-compare-case-insensitive-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-opened-frame.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:
- http/tests/security/protocol-compare-case-insensitive-expected.txt:
- http/tests/security/resources/cross-frame-iframe.html:
- 12:22 AM Changeset in webkit [28998] by
-
- 3 edits10 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14500
need to be more generous about charset declaration with meta tag
http://bugs.webkit.org/show_bug.cgi?id=12526
<rdar://problem/4867183> Safari ignores encoding description "charset=Shift_JIS" in invalid html
<rdar://problem/4892428> Unlike other browsers, WebKit ignores <meta> charset definitions outside the head
<rdar://problem/5643774> REGRESSION: Text is garbled when clicking a link inside an Arabic website
Tests: fast/encoding/ahram-org-eg.html
fast/encoding/bandai-co-jp-releases.html
fast/encoding/floraexpress-ru.html
fast/encoding/hanarei-blog32-fc2-com.html
fast/encoding/yahoo-mail.html
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Don't stop looking for <meta> until we've seen at least 512 bytes of input.
Dec 26, 2007:
- 10:54 PM BuildingGtk edited by
- added autotools documentation (diff)
- 10:05 PM Changeset in webkit [28997] by
-
- 6 edits7 adds in trunk
2007-12-26 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16390
Use autotools or GNU make as the build system for the GTK port
- 8:01 PM Changeset in webkit [28996] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
- re-categorize some SVG tests the are failing on Windows
- platform/win/Skipped:
- 6:33 PM Changeset in webkit [28995] by
-
- 12 edits5 moves in trunk/LayoutTests
Reviewed by Alice Liu.
Re-enable disabled tests with new polling logic using layoutTestController.globalFlag.
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-opened-frame.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-window-location.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled.
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled: Removed.
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled.
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled: Removed.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled: Removed.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled: Removed.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled.
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled: Removed.
- platform/win/Skipped:
- 3:55 PM Changeset in webkit [28994] by
-
- 2 edits in trunk/LayoutTests
removing tests tracked by <rdar://5463489> A number of layout tests should be using
execCommand instead of textInputController
- platform/win/Skipped: removing tests fixed by http://trac.webkit.org/projects/webkit/changeset/28626
- 2:16 PM Changeset in webkit [28993] by
-
- 2 edits1 move2 adds in trunk
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=16609
Make manual-tests/xmlhttprequest-contenttype-empty.html test automatic
- 1:25 AM Changeset in webkit [28992] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- 12:40 AM Changeset in webkit [28991] by
-
- 6 edits8 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=15514
<clipPath> with <use> not respected
http://bugs.webkit.org/show_bug.cgi?id=16557
SVG circle elements have been clipped away completely, instead of partially.
Add toClipPath to get clip path data for the clipping paths. Implement it for <use>, thereby allowing clip paths using use.
Dec 25, 2007:
- 11:25 PM Changeset in webkit [28990] by
-
- 9 edits in trunk/WebCore
Reviewed by Eric Seidel.
Clean up the files relating to NodeLists.
- dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): (WebCore::ChildNodeList::length): (WebCore::ChildNodeList::item): (WebCore::ChildNodeList::nodeMatches):
- dom/ChildNodeList.h:
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemForwardsFromCurrent): (WebCore::DynamicNodeList::itemBackwardsFromCurrent): (WebCore::DynamicNodeList::itemWithName):
- dom/DynamicNodeList.h: (WebCore::DynamicNodeList::needsNotifications):
- dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::rootNodeAttributeChanged): (WebCore::NameNodeList::nodeMatches):
- dom/NameNodeList.h:
- dom/NodeList.h:
- dom/SelectorNodeList.h:
- 10:44 PM Changeset in webkit [28989] by
-
- 4 edits in trunk/WebCore
Fix non-mac builds.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 10:33 PM Changeset in webkit [28988] by
-
- 3 edits2 copies in trunk/WebCore
Rubber stamped by Eric Seidel.
Move TagNodeList into its own file.
- WebCore.xcodeproj/project.pbxproj:
- dom/Node.cpp:
- dom/TagNodeList.cpp: Copied from dom/Node.cpp. (WebCore::TagNodeList::TagNodeList):
- dom/TagNodeList.h: Copied from dom/Node.cpp.
- 10:18 PM Changeset in webkit [28987] by
-
- 8 edits in trunk/WebCore
Reviewed by Eric Seidel.
Simplify the NodeList architecture.
- Rename recursiveItem() to item(), since it is not recursive.
- Make recursiveLength() iterative and rename to length().
- Remove now unneeded overrides of item() and length() that used to call the recursive variants.
- dom/ClassNodeList.cpp:
- dom/ClassNodeList.h:
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::length): (WebCore::DynamicNodeList::item): (WebCore::DynamicNodeList::rootNodeAttributeChanged): Move implementation into the .cpp file since virtual methods can't be inlined.
- dom/DynamicNodeList.h:
- dom/NameNodeList.cpp:
- dom/NameNodeList.h:
- dom/Node.cpp:
- 6:55 PM Changeset in webkit [28986] by
-
- 4 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
More complete GTK+/Qt/Wx/Win build fixes for breakage introduced in
r28981.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 6:33 PM Changeset in webkit [28985] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r28981.
- WebCore.vcproj/WebCore.vcproj:
- 6:30 PM Changeset in webkit [28984] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
Wx build fix for breakage introduced in r28981.
- WebCoreSources.bkl:
- 6:28 PM Changeset in webkit [28983] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
GTK+/Qt build fix for breakage introduced in r28981.
- WebCore.pro:
- 5:05 PM Changeset in webkit [28982] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
- fix an assertion failure when pressing the num lock key
- WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to WebCore.
- 4:46 PM Changeset in webkit [28981] by
-
- 18 edits2 copies1 move4 adds30 deletes in trunk
WebCore:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587 Implement the most useful part of the W3C Selectors API.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.h: Make Node a friend of CSSStyleSelector so it can use checkSelector()
- dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): Change to being a DynamicNodeList
- dom/ChildNodeList.h:
- dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Change to being a DynamicNodeList
- dom/ClassNodeList.h:
- dom/Document.idl: Add the new functions
- dom/DynamicNodeList.cpp: Copied from WebCore/dom/NodeList.cpp. (WebCore::DynamicNodeList::DynamicNodeList): Rename NodeList to DynamicNodeList, to differentiate it from the new StaticNodeList (WebCore::DynamicNodeList::~DynamicNodeList): (WebCore::DynamicNodeList::recursiveLength): (WebCore::DynamicNodeList::itemForwardsFromCurrent): (WebCore::DynamicNodeList::itemBackwardsFromCurrent): (WebCore::DynamicNodeList::recursiveItem): (WebCore::DynamicNodeList::itemWithName): (WebCore::DynamicNodeList::rootNodeChildrenChanged): (WebCore::DynamicNodeList::Caches::Caches): (WebCore::DynamicNodeList::Caches::reset):
- dom/DynamicNodeList.h: Copied from WebCore/dom/NodeList.h. (WebCore::DynamicNodeList::rootNodeAttributeChanged):
- dom/Element.idl: Add the new functions
- dom/NameNodeList.cpp: Change to being a DynamicNodeList (WebCore::NameNodeList::NameNodeList):
- dom/NameNodeList.h: (WebCore::NameNodeList::rootNodeAttributeChanged):
- dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Change to being a DynamicNodeList (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelector): new (WebCore::Node::querySelectorAll): new
- dom/Node.h:
- dom/NodeList.cpp: Removed.
- dom/NodeList.h: This is now an abstract superclass of DynamicNodeList and StaticNodeList (WebCore::NodeList::NodeList): (WebCore::NodeList::~NodeList):
- dom/SelectorNodeList.cpp: Added. (WebCore::SelectorNodeList::SelectorNodeList): New StaticNodeList subclass that filters elements by CSS selector
- dom/SelectorNodeList.h: Added.
- dom/StaticNodeList.cpp: Added. (WebCore::StaticNodeList::length): (WebCore::StaticNodeList::item): (WebCore::StaticNodeList::itemWithName):
- dom/StaticNodeList.h: Added. (WebCore::StaticNodeList::StaticNodeList): (WebCore::StaticNodeList::~StaticNodeList):
LayoutTests:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587 Implement the most useful part of the W3C Selectors API.
- fast/dom/SelectorAPI: Copied from LayoutTests/fast/dom/getElementsByClassName.
- fast/dom/SelectorAPI/dumpNodeList-expected.txt:
- fast/dom/SelectorAPI/dumpNodeList.html: Modified to test querySelector and querySelectorAll instead of getElementsByClassName
- fast/dom/Window/window-properties-expected.txt: Added querySelector and querySelectorAll
- 2:54 PM Changeset in webkit [28980] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- Remove unnecessary redundant check from property setting http://bugs.webkit.org/show_bug.cgi?id=16602
1.3% speedup on SunSpider.
- kjs/object.cpp: (KJS::JSObject::put): Don't do canPut check when not needed; let the PropertyMap handle it. (KJS::JSObject::canPut): Don't check the static property table. lookupPut does that already.
Dec 24, 2007:
- 10:55 PM Changeset in webkit [28979] by
-
- 2 edits in trunk/WebCore
Fix Bug 16596: ThreadSafeShared should be lock-free where possible.
Reviewed by Sam Weinig.
Implement a lock-free ThreadSafeShared for i386, x86_64, ppc and ppc64.
This is a 1.7x as fast as the lock-based implementation on x86 for a single-threaded use
of ThreadSafeShared but is closer to 280x as fast when there is heavy concurrent multi-threaded
access to a single ThreadSafeShared object.
The atomic operations are based on those used by the Boost C++ library's shared_ptr implementation.
- 10:00 PM Changeset in webkit [28978] by
-
- 3 edits in trunk/WebKit/gtk
2007-12-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/attachment.cgi?id=18099
There are no NULL checks for strings in public api
Add missing NULL checks for string parameters.
Provide sensible defaults when NULL is passed for the optional
parameters in webkit_web_view_load_string(). UTF-8 is the default
encoding used by GLib and text/html is a reasonable default content
type.
- WebView/webkitnetworkrequest.cpp:
- WebView/webkitwebview.cpp:
- 5:05 PM Changeset in webkit [28977] by
-
- 3 edits in trunk/WebCore
- platform/text/PlatformString.h: Removed now-incorrect comment. Added a comment about copy().
- platform/text/StringImpl.h: Added a comment about copy().
- 5:02 PM Changeset in webkit [28976] by
-
- 13 edits in trunk/WebCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16550 make StringImpl immutable
I tried to keep the changes to a minimum. In some cases there is
room for optimization -- I didn't try to add in the "single ref count"
optimizations and there might be a tiny bit more string copying than
we had before.
- WebCore.base.exp: Updated.
- dom/CharacterData.cpp: (WebCore::CharacterData::appendData): Changed to use String since StringImpl doesn't have mutating functions any more. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto.
- dom/Text.cpp: (WebCore::Text::splitText): Changed to use substring instead of remove since StringImpl does't have mutating functions any more.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Changed to use String instead of StringImpl so we can use remove.
- platform/text/PlatformString.h: Removed newUninitialized. Added append that takes a character pointer and length.
- platform/text/String.cpp: (WebCore::String::insert): Added an implementation that does not rely on an underlying StringImpl function. (WebCore::String::append): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::charactersWithNullTermination): Added an implementation that uses the new StringImpl null termination feature, which does not require modifying a string.
- platform/text/StringImpl.cpp: (WebCore::isSpace): Fix comment. (WebCore::StringImpl::StringImpl): Added a new constructor that makes a string with a trailing null character. (WebCore::StringImpl::substring): Marked const. (WebCore::StringImpl::replace): Marked const; had to add quite a few const_cast. Also rewrote one of these to work without modifying the existing string.
- platform/text/StringImpl.h: Fixed a mistake where the empty string had m_hasTerminatingNullCharacter uninitialized. Added a type and constructor for creating strings that have a trailing null character. Added a hasTerminatingNullCharacter function. Removed newUninitialized, charactersWithNullTermination, append, insert, truncate, and remove. Marked lots of other functions const.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Rewrote to use a Vector instead of newUninitialized.
- platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Ditto.
- platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Ditto.
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Changed to use String since StringImpl doesn't have mutating functions any more.
- 10:31 AM Changeset in webkit [28975] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-24 Alp Toker <alp@atoker.com>
Fix builds that don't use AllInOneFile.cpp following breakage
introduced in r28973.
- kjs/grammar.y:
- 4:16 AM Changeset in webkit [28974] by
-
- 4 edits in trunk
Reviewed by Oliver.
Fix fast/events/arrow-keys-on-body.html, failing on Windows.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count of 1, even though WebKit currently ignores it.
- 2:13 AM Changeset in webkit [28973] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Eric.
- Optimize variable declarations http://bugs.webkit.org/show_bug.cgi?id=16585
3.5% speedup on SunSpider.
var statements now result in either assignments or empty statements.
This allows a couple of optimization opportunities:
- No need to branch at runtime to check if there is an initializer
- EmptyStatementNodes can be removed entirely (also done in this patch)
- Assignment expressions get properly optimized for local variables
This patch also includes some code cleanup:
- Most of the old VarStatement/VarDecl logic is now only used for const declarations, thus it is renamed appropriately
- AssignExprNode is gone
- JavaScriptCore.exp:
- kjs/NodeInfo.h:
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::SourceElements::append): (KJS::ConstDeclNode::ConstDeclNode): (KJS::ConstDeclNode::optimizeVariableAccess): (KJS::ConstDeclNode::handleSlowCase): (KJS::ConstDeclNode::evaluateSingle): (KJS::ConstDeclNode::evaluate): (KJS::ConstStatementNode::optimizeVariableAccess): (KJS::ConstStatementNode::execute): (KJS::VarStatementNode::optimizeVariableAccess): (KJS::VarStatementNode::execute): (KJS::ForInNode::ForInNode): (KJS::ForInNode::optimizeVariableAccess): (KJS::ForInNode::execute): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::ProgramNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::ProgramNode::processDeclarations): (KJS::EvalNode::processDeclarations):
- kjs/nodes.h: (KJS::DeclarationStacks::): (KJS::StatementNode::): (KJS::ConstDeclNode::): (KJS::ConstStatementNode::): (KJS::EmptyStatementNode::): (KJS::VarStatementNode::): (KJS::ForNode::):
- kjs/nodes2string.cpp: (KJS::ConstDeclNode::streamTo): (KJS::ConstStatementNode::streamTo): (KJS::ScopeNode::streamTo): (KJS::VarStatementNode::streamTo): (KJS::ForNode::streamTo): (KJS::ForInNode::streamTo):
Dec 23, 2007:
- 10:39 PM Changeset in webkit [28972] by
-
- 5 edits in trunk/WebCore
Fix Debug and Release QTMovieWin bulds.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/debug.vsprops:
- WebCore.vcproj/debug_internal.vsprops:
- WebCore.vcproj/release.vsprops: Use LibraryConfigSuffix instead of WebKitConfigSuffix for pthreadVC2. Build release import lib into \lib, not \bin.
- 7:04 PM Changeset in webkit [28971] by
-
- 5 edits in trunk/WebCore
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=15382
[CAIRO] Canvas pattern support
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
Add support for canvas patterns.
Make Image::nativeImageForCurrentFrame() public.
Fix some typos along the way.
The globalAlpha canvas fixes are not included in this patch as
they're slightly more intrusive and may conflict conceptually with
GraphicsContext::setAlpha().
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern): (WebCore::CanvasPattern::createPattern):
- html/CanvasPattern.h: (WebCore::CanvasPattern::platformImage):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
- platform/graphics/Image.h: (WebCore::Image::nativeImageForCurrentFrame):
- 6:09 PM Changeset in webkit [28970] by
-
- 4 edits in trunk/WebCore
Remove getWxBitmap as we have nativeImageForCurrentFrame now, and don't draw a border in fillRect.
- 4:47 PM Changeset in webkit [28969] by
-
- 3 edits in trunk/WebCore
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
This patch is based on initial merging work by Brent Fulgham. Adobe's
code has been modified in a few places to better suit the existing
coding style.
Implement more clipping and drawing functions.
Save and restore the fill rule manually when clipping.
Avoid image surface creation when the image buffer has height zero.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 3:40 PM Changeset in webkit [28968] by
-
- 4 edits in trunk/LayoutTests
- updated results (character used for controls changed in r28945)
- platform/mac/media/audio-controls-rendering-expected.txt: Regenerated.
- platform/mac/media/video-controls-rendering-expected.txt: Regenerated.
- platform/mac/media/video-display-toggle-expected.txt: Regenerated.
- 9:50 AM Changeset in webkit [28967] by
-
- 2 edits in trunk/WebKitTools
wx buildbot fix. Update libpng dl script to the latest version.
- 4:30 AM Changeset in webkit [28966] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark.
Fix wrong placed ifdef - wrapping SVGDefsElement, instead of SVGDefinitionSrcElement in SVG_FONTS block.
- 2:00 AM BuildingQtOnLinux edited by
- Remove info about applying a patch that has since been landed (diff)
Dec 22, 2007:
- 6:18 PM Changeset in webkit [28965] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Use webView, web_view, etc for variable names instead of page, which
was left over from the old API.
- 3:54 PM Changeset in webkit [28964] by
-
- 4 edits in trunk
2007-12-22 Alp Toker <alp@atoker.com>
GTK+ build fix
GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
empty target flags for now.
Check GTK+, not GLib versions, since they are different.
- 3:12 PM Changeset in webkit [28963] by
-
- 9 edits3 adds in trunk
2007-12-22 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16311
[Gtk] Copy rich text to clipboard as text/plain and text/html.
Add copy and paste targets for WebView and implement
WebCore::PasteboardHelper.
- 1:39 PM Changeset in webkit [28962] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15966 (Crash in SVGRootInlineBox::walkTextChunks() on mouse hover)
Add new isSVGRootInlineBox() function to InlineBox to be able to differentiate between RootInlineBox/SVGRootInlineBox.
SVG assumed it's root inline box (for <text> elements) is always of type SVGRootInlineBox, which is not the case
for HTML text in <foreignObject>. Text selection doesn't work so far as line box offsets are wrong - which is visible
in Web Inspector.
- 1:04 PM Changeset in webkit [28961] by
-
- 2 edits in trunk/WebKitTools
Fix a typo.
- 12:03 PM Changeset in webkit [28960] by
-
- 2 edits in trunk/WebCore
2007-12-22 Alp Toker <alp@atoker.com>
LOW_BANDWIDTH_DISPLAY build fix
Track recent KURL DeprecatedString changes.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 8:48 AM Changeset in webkit [28959] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj:
- 8:35 AM Changeset in webkit [28958] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Follow up to http://bugs.webkit.org/show_bug.cgi?id=16144
- WebView/webkitwebview.cpp: Fix signal id arguments for g_signal_emit in clipboard functions.
- 8:34 AM Changeset in webkit [28957] by
-
- 2 edits in trunk/WebCore
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Add missing return 0 to fix a compile warning.
- page/gtk/FrameGtk.cpp: (WebCore::Frame::createScriptInstanceForWidget):
Dec 21, 2007:
- 11:26 PM Changeset in webkit [28956] by
-
- 2 edits in trunk/WebKitSite
At bdash's suggestion, display a message if someone attempts to run the 'native' version of the getElementsByClassName benchmark in a browser that doesn't support that.
- blog-files/gebcnspeedtest.html:
- 11:02 PM Changeset in webkit [28955] by
-
- 1 edit2 adds in trunk/WebKitSite
Add the benchmark from the previous commit as well.
- blog-files/gebcnspeedtest.html: Added.
- blog-files/prototype-for-gebcn-test.js: Added.
- 10:45 PM Changeset in webkit [28954] by
-
- 1 edit1 add in trunk/WebKitSite
Add a graph of benchmark results for an upcoming blog post.
- blog-files/gebcnwebkitonly.png: Added.
- 10:12 PM Changeset in webkit [28953] by
-
- 4 edits in trunk
Versioning.
- 10:11 PM Changeset in webkit [28952] by
-
- 1 copy in tags/Safari-5525.2
New tag.
- 10:11 PM Changeset in webkit [28951] by
-
- 1 copy in tags/Safari-4525.2
New tag.
- 9:54 PM Changeset in webkit [28950] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-21 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
- JavaScriptCore.exp: Remove unused symbol to prevent a weak external symbol being generated in JavaScriptCore.framework.
- 8:40 PM Changeset in webkit [28949] by
-
- 2 edits in trunk/WebKitLibraries
Fix http://bugs.webkit.org/show_bug.cgi?id=16549 (WebKit nightly build failing to launch on PowerPC G3s).
Rubber-stamped by Dan Bernstein.
- libWebKitSystemInterfaceTiger.a: Update to a G3-friendly version.
- 8:18 PM Changeset in webkit [28948] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
- Disable the back/forward cache using the new WebPreferences API instead of through the BackForwardList. This makes us match what we do on Windows.
- DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (setDefaultsToConsistentValuesForTesting):
- 5:39 PM Changeset in webkit [28947] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
- disable the back/forward cache in Windows DumpRenderTree. It is already disabled in Mac DumpRenderTree.
- DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
- 5:09 PM Changeset in webkit [28946] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Darin and Steve.
Add instructions to install the QuickTime SDK for Windows.
- 5:07 PM Changeset in webkit [28945] by
-
- 12 edits7 adds in trunk
Reviewed by Darin, Adam and Steve.
Add media playback support for Windows.
The implementation uses low level QuickTime API. DLL is
needed to work around CF use in both WebKit and QuickTime.
This makes Windows build depend on the QuickTime SDK
but not QuickTime itself.
QTMovieWinTimer contains some copy code from SharedTimerWin. It
is used in the QuickTime access DLL which can't use WebCore
SharedTimer due to dependency problems.
- 5:01 PM Changeset in webkit [28944] by
-
- 5 edits in trunk/WebCore
2007-12-21 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16558
Cairo WebCore Rendering Fails on arc drawing
Fix for bug reported (and patched) by Apollo team in which
arcs were draw in reverse (resulting in inverted images).
Review of the source found that the 'clockwise' term was
actually meant to mean 'anticlockwise' so the IDL and
supporting classes have been changed to match this.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
- html/CanvasRenderingContext2D.idl:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc): (WebCore::Path::addEllipse):
- platform/graphics/Path.h:
- 4:41 PM Changeset in webkit [28943] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-21 Alp Toker <alp@atoker.com>
Documentation typo fix: s/wether/whether
- WebView/webkitwebview.cpp:
- 4:36 PM Changeset in webkit [28942] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16144
[GTK] Clipboard/ selection handling functions
- WebView/webkitprivate.h:
- WebView/webkitwebview.cpp:
- WebView/webkitwebview.h:
- 4:35 PM Changeset in webkit [28941] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adele.
Fix another mistaken duplication, this time in cross-frame-access-parent-explicit-domain.html,
that was causing intermittent failures.
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain.html:
- http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
- 4:01 PM Changeset in webkit [28940] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Dan Bernstein.
Fix mistaken duplication in cross-frame-access-child-explicit-domain.html that was causing
intermittent failures.
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-child-explicit-domain.html:
- http/tests/security/cross-frame-access-custom-expected.txt:
- 3:15 PM Changeset in webkit [28939] by
-
- 2 edits in trunk/WebKit/win
Implemented DOMDocument::getElementById().
Reviewed by Darin.
- DOMCoreClasses.cpp: (DOMDocument::getElementById):
- 2:02 PM Changeset in webkit [28938] by
-
- 2 edits in trunk/JavaScriptCore
Requested by Maciej.
- kjs/nodes.h: Use the new NEVER_INLINE here and eliminate the old KJS_NO_INLINE. We don't want to have two, and we figured it was better to keep the one that's in WTF.
- 1:54 PM Changeset in webkit [28937] by
-
- 12 edits in trunk/JavaScriptCore
Reviewed by Eric.
- http://bugs.webkit.org/show_bug.cgi?id=16561 remove debugger overhead from non-debugged JavaScript execution
1.022x as fast on SunSpider.
- JavaScriptCore.exp: Updated.
- kjs/NodeInfo.h: Renamed SourceElementsStub to SourceElements, since that more accurately describes the role of this object, which is a reference-counted wrapper for a Vector.
- kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Changed parameter type to SourceElements, and use plain assignment instead of set.
- kjs/Parser.h: Changed parameter type of didFinishParsing to a SourceElements. Also changed m_sourceElements; we now use a RefPtr instead of an OwnPtr as well.
- kjs/grammar.y: Got rid of all the calls to release() on SourceElements. That's now handed inside the constructors for various node types, since we now use vector swapping instead.
- kjs/nodes.cpp: (KJS::Node::rethrowException): Added NEVER_INLINE, because this was getting inlined and we want exception handling out of the normal code flow. (KJS::SourceElements::append): Moved here from the header. This now handles creating a BreakpointCheckStatement for each statement in the debugger case. That way we can get breakpoint handling without having it in every execute function. (KJS::BreakpointCheckStatement::BreakpointCheckStatement): Added. (KJS::BreakpointCheckStatement::execute): Added. Contains the code that was formerly in the StatementNode::hitStatement function and the KJS_BREAKPOINT macro. (KJS::BreakpointCheckStatement::streamTo): Added. (KJS::ArgumentListNode::evaluateList): Use KJS_CHECKEXCEPTIONVOID since the return type is void. (KJS::VarStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::BlockNode::BlockNode): Changed parameter type to SourceElements. Changed code to use release since the class now contains a vector rather than a vector point. (KJS::BlockNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::BlockNode::execute): Ditto. (KJS::ExprStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::IfNode::execute): Ditto. (KJS::IfElseNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ContinueNode::execute): Ditto. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::CaseClauseNode::executeStatements): Ditto. (KJS::SwitchNode::execute): Removed KJS_BREAKPOINT. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ScopeNode::ScopeNode): Changed parameter type to SourceElements. (KJS::ProgramNode::ProgramNode): Ditto. (KJS::EvalNode::EvalNode): Ditto. (KJS::FunctionBodyNode::FunctionBodyNode): Ditto. (KJS::ScopeNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer.
- kjs/nodes.h: Removed hitStatement. Renamed SourceElements to StatementVector. Renamed SourceElementsStub to SourceElements and made it derive from ParserRefCounted rather than from Node, hold a vector rather than a pointer to a vector, and changed the release function to swap with another vector rather than the pointer idiom. Updated BlockNode and CaseClauseNode to hold actual vectors instead of pointers to vectors. Added BreakpointCheckStatement.
- kjs/nodes2string.cpp: (KJS::statementListStreamTo): Changed to work on a vector instead of a pointer to a vector. (KJS::BlockNode::streamTo): Ditto. (KJS::CaseClauseNode::streamTo): Ditto.
- wtf/AlwaysInline.h: Added NEVER_INLINE.
- wtf/PassRefPtr.h: Tweaked formatting. Added clear() function that matches the ones in OwnPtr and auto_ptr.
- wtf/RefPtr.h: Ditto.
- 12:17 PM Changeset in webkit [28936] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Steve and Darin.
<rdar://problem/5497037> Win32: Accelerator keys (ctrl-x,c,v,w,q,etc) only fire keyUp,
keyDown/Press consumed by accelerator table (14104)
<rdar://problem/5346299> preventing default behavior for key down does not block accelerators like Ctrl+N
This is WebKit part of a fix, most of which will be in Safari.
- WebView.cpp: (WebViewWndProc): Return our result for WM_(SYS)KEYDOWN to let the client know whether further procesing is desired.
- 7:36 AM Changeset in webkit [28935] by
-
- 2 edits in trunk/JavaScriptCore
- fix broken regression tests
The broken tests were fast/js/do-while-expression-value.html and
fast/js/while-expression-value.html.
- kjs/nodes.cpp: Check in the correct version of this file. I had accidentally landed an old version of my patch for bug 16471. (KJS::statementListExecute): The logic here was backwards. Have to set the value even for non-normal execution results.
- 3:00 AM Changeset in webkit [28934] by
-
- 5 edits1 add in trunk
Reviewed by Oliver.
<rdar://problem/5629995> Incorrect display of Danish characters on web site.
Test: http/tests/xmlhttprequest/response-encoding.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Default to UTF-8 for HTML, too. It's unfortunate that we have to use different rules for main content and XHR responses, but this matches both IE and Firefox.
- 2:57 AM Changeset in webkit [28933] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Correct ChangeLog spelling.
- 2:55 AM Changeset in webkit [28932] by
-
- 2 edits in trunk/WebKit/win
Build fix: cannot use framework-style include for ProgIDMacros.h,
because the file is only created on a leter step.
- ForEachCoClass.h:
- 1:09 AM Changeset in webkit [28931] by
-
- 2 edits in trunk/WebKitTools
Buildbot fix for wx port.
Dec 20, 2007:
- 11:40 PM Changeset in webkit [28930] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy npruntime_internal.h to WebKitBuild.
- 11:21 PM Changeset in webkit [28929] by
-
- 5 edits in trunk/JavaScriptCore
2007-12-17 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Split IfNode into IfNode and IfElseNode for speedup.
http://bugs.webkit.org/show_bug.cgi?id=16470
SunSpider claims this is 1.003x as fast as before.
(This required running with --runs 15 to get consistent enough results to tell!)
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::IfNode::optimizeVariableAccess): (KJS::IfNode::execute): (KJS::IfNode::getDeclarations): (KJS::IfElseNode::optimizeVariableAccess): (KJS::IfElseNode::execute): (KJS::IfElseNode::getDeclarations):
- kjs/nodes.h: (KJS::IfNode::): (KJS::IfElseNode::):
- kjs/nodes2string.cpp: (KJS::IfNode::streamTo): (KJS::IfElseNode::streamTo):
- 10:57 PM Changeset in webkit [28928] by
-
- 2 edits in trunk/WebCore
2007-12-20 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/5655797> REGRESSION(304-306A10) Safari does not find
shockwave plugin on freshly installed OS
Look for Director plugin in its native directory.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths): The Director plugin doesn't start with "np," so special case its filename. (WebCore::addMacromediaPluginPaths): Add Flash and "Shockwave 10" directories to the plugin paths. (WebCore::PluginDatabaseWin::defaultPluginPaths):
- 10:07 PM Changeset in webkit [28927] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver.
- fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
- WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:, deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:, moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:, selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:, and transpose:.
- 10:06 PM Changeset in webkit [28926] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- wtf/OwnPtr.h: (WTF::operator==): Added. (WTF::operator!=): Added.
- 7:56 PM Changeset in webkit [28925] by
-
- 4 edits in trunk/WebCore
2007-12-20 Peter Kasting <zerodpx@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16508
Fix regression in GIFImageDecoder.cpp: "Haeberli hack" led to wrongly
decoded transparent areas.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::output_row):
- 6:55 PM Changeset in webkit [28924] by
-
- 10 edits6 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/5543472> GoogleDocs: Safari hangs when creating a list from a particular selection
Still need to fix similar issues with the other operations that iterate
over selected paragraphs, like FormatBlock, Indent and Outdent (<rdar://problem/5658933>).
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Added a FIXME.
- editing/IndentOutdentCommand.h: Removed an unused function.
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::modifyRange): Renamed visibleStart to startOfSelection and visibleEnd to endOfSelection. Call the new selectionForParagraphIteration, which a) prevents operations like this one from being performed on a table that isn't fully selected (where the selection starts just before the table and ends inside it), and b) helps prevent paragraph iteration from going past the end of the selection. Call the new startOfNextParagraph, instead of using endOfParagraph(v).next(), since when v is in the last paragraph of the last cell of a table, that expression will return the position after the table, not the start of the next paragraph.
- editing/htmlediting.cpp: (WebCore::enclosingListChild): Don't go above a table cell, so that list operations take effect inside the table cell where they are performed. (WebCore::selectionForParagraphIteration): Added, see above. (WebCore::indexForVisiblePosition): Moved from IndentOutdentCommand.cpp.
- editing/htmlediting.h:
- editing/visible_units.cpp: (WebCore::startOfNextParagraph): Added, see above.
- editing/visible_units.h:
- editing/TextIterator.h: (WebCore::TextIterator::exitNode): Added a FIXME.
LayoutTests:
Reviewed by Oliver Hunt.
<rdar://problem/5543472> GoogleDocs: Safari hangs when creating a list from a particular selection
- editing/execCommand/5543472-1-expected.txt: Added.
- editing/execCommand/5543472-1.html: Added.
- editing/execCommand/5543472-2-expected.txt: Added.
- editing/execCommand/5543472-2.html: Added.
- editing/execCommand/5543472-3-expected.txt: Added.
- editing/execCommand/5543472-3.html: Added.
- 6:18 PM Changeset in webkit [28923] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
AST optimization: Avoid NULL-checking ForNode's child nodes.
0.6% speedup on SunSpider.
This is a proof of concept patch that demonstrates how to optimize
grammar productions with optional components, like
for (optional; optional; optional) {
...
}
The parser emits NULL for an optional component that is not present.
Instead of checking for a NULL child at execution time, a node that
expects an optional component to be present more often than not checks
for a NULL child at construction time, and substitutes a viable
alternative node in its place.
(We'd like the parser to start emitting NULL a lot more once we teach
it to emit NULL for certain no-op productions like EmptyStatement and
VariableStatement, so, as a foundation, it's important for nodes with
NULL optional components to be fast.)
- kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Check for NULL SourceElements. Also, moved didFinishParsing into the .cpp file because adding a branch while it was in the header file caused a substantial and inexplicable performance regression. (Did I mention that GCC is crazy?)
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::BlockNode::BlockNode): Check for NULL SourceElements. (KJS::ForNode::optimizeVariableAccess): No need to check for NULL here. (KJS::ForNode::execute): No need to check for NULL here.
- kjs/nodes.h: (KJS::ForNode::): Check for NULL SourceElements. Substitute a TrueNode because it's semantically harmless, and it evaluates to boolean in an efficient manner.
- 5:31 PM Changeset in webkit [28922] by
-
- 2 edits in trunk/LayoutTests
Reviewed by John Sullivan.
- reorganize skipped test list
- platform/win/Skipped:
- 4:33 PM Changeset in webkit [28921] by
-
- 8 edits in trunk
2007-12-20 Alp Toker <alp@atoker.com>
Rubber-stamped by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16542
[GTK] Text is missing with old Pango version
Back out commits r28880, r28876, r28865, r28864 which added Pango font
selection support. These changes caused a regression where no text was
displayed with older Pango versions.
- 4:24 PM Changeset in webkit [28920] by
-
- 4 edits in trunk
2007-12-20 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
- sunspider: increase default number of runs for more accurate numbers
- 3:59 PM Changeset in webkit [28919] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
ChangeLog entry corrections
- 3:46 PM Changeset in webkit [28918] by
-
- 5 edits in trunk/WebCore
Reviewed by Sam Weinig.
<rdar://problem/5604897> Double-clicking on JavaScript console error
won't show the line where it occurred
Make the URLs clickable in the console, since double clicking is used for
word text selection. Makes the word "line" localizable. Messages that don't
have a URL will no longer print "undefined". Messages that have a line number
less than or equal to 0 will no longer be printed.
- English.lproj/InspectorLocalizedStrings.js: Add "%s (line %d)".
- page/inspector/ConsolePanel.js: Tweak how the DOM nodes are created and change the click handler to look for a link with the "console-message-url" class name.
- page/inspector/SourcePanel.js: Call setupSourceFrameIfNeeded() if a line row is needed.
- page/inspector/inspector.css: Update the look of the URL in the console.
- 3:43 PM Changeset in webkit [28917] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-20 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Fix major Array regression introduced by 28899.
SunSpider claims this is at least 1.37x as fast as pre-regression. :)
- kjs/array_instance.cpp: make Array's fast again!
- 3:39 PM Changeset in webkit [28916] by
-
- 2 edits in trunk/JavaScriptCore
Slight logic reordering in JSImmediate::from(double)
Reviewed by Geoff.
This gives a 0.1% improvement in SunSpider.
- 3:30 PM Changeset in webkit [28915] by
-
- 1 copy in tags/Safari-523.15b
New tag.
- 3:30 PM Changeset in webkit [28914] by
-
- 2 edits in branches/Safari-3-branch/WebKit/win
Bump versions for submit
- 2:46 PM Changeset in webkit [28913] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-20 Eric Seidel <eric@webkit.org>
Reviewed by Geoff, then re-rubber-stamped by Geoff after final search/replace and testing.
Small reworking of Date code for 4% speedup on Date tests (0.2% overall)
http://bugs.webkit.org/show_bug.cgi?id=16537
Make msToYear human-readable
Make msToDayInMonth slightly more readable and avoid recalculating msToYear
Remove use of isInLeapYear to avoid calling msToYear
Remove dayInYear call by changing msToDayInMonth to dayInMonthFromDayInYear
Remove more duplicate calls to dayInYear and getUTCOffset for further speedup
- kjs/DateMath.cpp: (KJS::daysFrom1970ToYear): (KJS::msToYear): (KJS::monthFromDayInYear): (KJS::checkMonth): (KJS::dayInMonthFromDayInYear): (KJS::dateToDayInYear): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
- 2:39 PM Changeset in webkit [28912] by
-
- 16 edits4 adds in trunk
WebCore:
Reviewed and landed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=15313
<rdar://problem/5514516>
The same-origin check was incorrect in two cases (both fixed in this
patch):
A) If both the source and the target have set their document.domain
to the same value, the protocol must also match in order for
access to be allowed. Without this requirement, the browser is
vulnerable to the following attack:
1) Suppose there is an HTTPS site (www.example.com) that sets
document.domain = "example.com".
2) A network attacker redirects the browser to http://www.example.com/
a) injects script to set document.domain = "example.com", and
b) opens a window to https://www.example.com/
3) Now the network attacker can inject script into the HTTPS page,
stealing cookies and issuing banking transactions.
B) If only one of the source and target has set document.domain, then
access should be denied. With this behavior, the browser is
vulnerable to the following attack:
1) Suppose http://foo.example.com/ opens an iframe to
http://foo.example.com/frame.html that
a) sets document.domain = "example.com", and
b) opens an iframe to http://bar.example.com/
This is a common usage of document.domain for cross-domain
communication, see for example:
http://www.collinjackson.com/research/papers/fp801-jackson.pdf
2) The inner-most iframe, which is from bar.example.com, sets
document.domain = "example.com".
3) Now the inner-most iframe can inject script into the middle
iframe (say via document.write). This bar.example.com script
now has access to the outer-most frame (from foo.example.com).
Both these changes cause WebKit to match the behavior of Firefox 2 and
IE6 in these cases. This patch includes regression tests for both
issues.
Internet Explorer 7 and Opera 9 are more strict in that they require
the port numbers to match when both pages have document.domain set.
Opera 9 allows access when only one page has set document.domain, but
this is a security vulnerability.
Tests: http/tests/security/cross-frame-access-child-explicit-domain.html
http/tests/security/cross-frame-access-parent-explicit-domain.html
- bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::allowsAccessFrom):
- dom/Document.cpp: (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::initSecurityOrigin):
- dom/Document.h: (WebCore::Document::securityOrigin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::checkCallImplicitClose): (WebCore::FrameLoader::shouldAllowNavigation):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setForURL): (WebCore::SecurityOrigin::createForFrame): (WebCore::SecurityOrigin::canAccess):
- platform/SecurityOrigin.h: (WebCore::SecurityOrigin::domain):
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::securityOriginData):
- storage/Database.h: (WebCore::Database::databaseDebugName):
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
LayoutTests:
Reviewed and landed by Sam Weinig.
Update LayoutTests for http://bugs.webkit.org/show_bug.cgi?id=15313
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt: Added.
- http/tests/security/cross-frame-access-child-explicit-domain.html: Added.
- http/tests/security/cross-frame-access-custom-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt: Added.
- http/tests/security/cross-frame-access-parent-explicit-domain.html: Added.
- http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-protocol-explicit-domain.html:
- 2:17 PM Changeset in webkit [28911] by
-
- 14 edits2 adds in trunk
2007-12-20 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Darin Adler.
Proxy includes of npruntime.h or npapi.h through npruntime_internal.h
Include stdio.h in npapi.h for the use of FILE with XP_UNIX defined
This is for building with X11, as some type and enum names conflict
with #define names in X11 headers.
http://bugs.webkit.org/show_bug.cgi?id=15669
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/NP_jsobject.h:
- bindings/npapi.h:
- bindings/npruntime.cpp:
- bindings/npruntime_impl.h:
- bindings/npruntime_priv.h:
- bindings/npruntime_internal.h:
- bindings/testbindings.cpp:
- bindings/c/c_class.h:
- bindings/c/c_runtime.h:
- bindings/c/c_utility.h:
2007-12-20 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Darin Adler.
Define XP_UNIX when building with plugins on X11.
Use new npruntime_internal.h instead of npruntime.h.
http://bugs.webkit.org/show_bug.cgi?id=15669
- ForwardingHeaders/bindings/npruntime_internal.h
- WebCore.pro:
- html/HTMLPlugInElement.h:
- 2:16 PM Changeset in webkit [28910] by
-
- 10 edits1 add in trunk
WebKit/win:
Reviewed by Steve.
- <rdar://5656485> Drosera: Win: Nightly does not reliably connect to WebKit.
- Drosera and Safari need to use the same ProgIDs in order for CoCreateInstance to work properly. The most robust way to do this is for WebKit to dynamically publish those ProgIDs.
- ForEachCoClass.cpp: Added. (setUseOpenSourceWebKit): (progIDForClass):
- ForEachCoClass.h: Added functionality to publish ProgIDs.
- WebKit.vcproj/WebKit.def: Exposed added functions for applications.
- WebKit.vcproj/WebKit.vcproj: Added ForEachCoClass.cpp
- WebKit.vcproj/WebKit_debug.def: Exposed added functions fori applications.
WebKitTools:
Reviewed by Steve.
- <rdar://5656485> Drosera: Win: Nightly does not reliably connect to WebKit.
- Drosera and Safari need to use the same ProgIDs in order for CoCreateInstance to work properly. The most robust way to do this is for WebKit to dynamically publish those ProgIDs.
- Drosera/win/DebuggerClient.cpp: Use the published ProgIDs (DebuggerClient::createWebViewWithRequest):
- Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some statics. (Drosera::initUI): (Drosera::attach): (Drosera::attemptToCreateServerConnection):
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
- Drosera/win/ServerConnection.cpp: Reformat the connection function and make use of the published ProgIDs. (ServerConnection::attemptToCreateServerConnection):
- 2:10 PM Changeset in webkit [28909] by
-
- 2 edits in trunk/WebKitTools/Scripts
revert script check-ins that I didn't mean to commit
- 2:05 PM Changeset in webkit [28908] by
-
- 6 edits2 adds in trunk
- fix http://bugs.webkit.org/show_bug.cgi?id=16179 | <rdar://problem/5619399>
Any attribute name start with a unicode which like #xx00(x could be any hex number[0-9a-f]) will cause HTMLTokenizer parse error
Actually any unicode characters which great than 255 in attribute name will cause Webkit parse the attribute name wrong. So after comparing
the same scenario in IE 6/7, FireFox 2/3, Opera, we should treat those characters as part of attribute name.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity): Handle Unicode Entity Name by using ASCII version of findEntity. (WebCore::HTMLTokenizer::parseTag): Let type of ptr match type of cBuffer.
- html/HTMLTokenizer.h: Change type of cBuffer from char to UChar.
- 1:57 PM Changeset in webkit [28907] by
-
- 13 edits in trunk/JavaScriptCore
- re-fix http://bugs.webkit.org/show_bug.cgi?id=16471 Completions need to be smaller (or not exist at all)
Same patch as last time with the test failures problem fixed.
- kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Make sure to check the completion type from newExec to see if the execute raised an exception.
- 1:22 PM Changeset in webkit [28906] by
-
- 1 copy in tags/Safari-523.14b
New tag.
- 1:22 PM Changeset in webkit [28905] by
-
- 2 edits in branches/Safari-3-branch/WebKit/win
Bump versions for submit
- 1:21 PM Changeset in webkit [28904] by
-
- 2 edits in tags/Safari-5523.15.1
Versioning.
- 1:21 PM Changeset in webkit [28903] by
-
- 2 edits in tags/Safari-5523.15.1/WebCore
Merge r28057.
- 1:06 PM Changeset in webkit [28902] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders.
Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop writing to the window backing store. The problem was that change-set 28400 introduced an early return which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
- 1:01 PM Changeset in webkit [28901] by
-
- 2 edits in trunk/WebKitTools
- <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
- Build bot and leak fix.
- DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback):
- 12:40 PM Changeset in webkit [28900] by
-
- 1 copy in tags/Safari-5523.15.1
New tag.
- 12:33 PM Changeset in webkit [28899] by
-
- 14 edits in trunk/JavaScriptCore
- roll out that last change -- it was causing test failures; I'll check it back in after fixing them
- 12:10 PM Changeset in webkit [28898] by
-
- 2 edits in tags/Safari-4523.12.2
Versioning.
- 12:10 PM Changeset in webkit [28897] by
-
- 2 edits in tags/Safari-4523.12.2/WebCore
Merge r28057.
- 12:08 PM Changeset in webkit [28896] by
-
- 2 edits in tags/Safari-5523.10.6
Versioning.
- 12:08 PM Changeset in webkit [28895] by
-
- 2 edits in tags/Safari-5523.10.6/WebCore
Merge r28057.
- 12:05 PM Changeset in webkit [28894] by
-
- 2 edits in branches/Safari-3-branch/WebCore
Merge r28057.
- 11:40 AM Changeset in webkit [28893] by
-
- 1 copy in tags/Safari-4523.12.2
New tag.
- 11:40 AM Changeset in webkit [28892] by
-
- 1 copy in tags/Safari-5523.10.6
New tag.
- 11:21 AM Changeset in webkit [28891] by
-
- 10 edits in trunk
2007-12-20 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit claims to support SVG feature strings it shouldn't
http://bugs.webkit.org/show_bug.cgi?id=15480
- dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
- 10:49 AM Changeset in webkit [28890] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver and Geoff
- fix <rdar://problem/5536858> Yellow highlight for find results is sometimes shorter than white "hole" behind it
- rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): respect useSelectionHeight in all cases; we were only respecting it in one of the two cases
- 10:28 AM Changeset in webkit [28889] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5656368> REGRESSION(3.0.4-ToT): Acid2 test fails to render anything
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): Changed back to return the maximum scroll offsets even if scrolling is not allowed, because navigation and scrollTo should still work. (WebCore::ScrollView::wheelEvent): Added early return if scrolling is not allowed.
- 10:09 AM Changeset in webkit [28888] by
-
- 4 edits2 adds in trunk
2007-12-17 Tony Chang <idealisms@gmail.com>
Reviewed by Darin.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=16479 text selection does not always begin at mouse down point Reset the m_dragSrc object on mouse down on all platforms.
Test: fast/text/reset-drag-on-mouse-down.html
- 9:42 AM Changeset in webkit [28887] by
-
- 13 edits in trunk/JavaScriptCore
Reviewed by Eric.
- http://bugs.webkit.org/show_bug.cgi?id=16471 Completions need to be smaller (or not exist at all)
SuSpider shows 2.4% speedup.
Stop using completions in the execution engine.
Instead, the completion type and label target are both
stored in the ExecState.
- API/JSContextRef.cpp: Removed unneeded include of "completion.h".
- bindings/runtime_method.cpp: Removed unused execute function.
- bindings/runtime_method.h: Ditto.
- kjs/ExecState.h: Added completionType, breakOrContinueTarget, setCompletionType, setNormalCompletion, setBreakCompletion, setContinueCompletion, setReturnValueCompletion, setThrowCompletion, setInterruptedCompletion, m_completionType, and m_breakOrContinueTarget.
- kjs/completion.h: Removed constructor and getter for target for break and continue from Completion. This class is now only used for the public API to Interpreter and such.
- kjs/date_object.h: Removed unused execute function.
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Removed some unneeded exception processing. Updated to call the new execute function and to get the completion type from the ExecState. Merged in the execute function, which repeated some of the same logic and was called only from here. (KJS::GlobalFuncImp::callAsFunction): More of the same for eval.
- kjs/function.h: Removed execute.
- kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Added code to convert the result of execut into a Completion.
- kjs/nodes.cpp: (KJS::Node::setErrorCompletion): Renamed from createErrorCompletion. Now sets the completion type in the ExecState. (KJS::Node::rethrowException): Now sets the completion type in the ExecState. (KJS::StatementNode::hitStatement): Now sets the completion type in the ExecState. (KJS::VarStatementNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::statementListExecute): Ditto. Also changed the for loop to use indices instead of iterators. (KJS::BlockNode::execute): Updated return type. (KJS::EmptyStatementNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::ExprStatementNode::execute): Ditto. (KJS::IfNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. Also streamlined the logic a little to make the normal case a little faster and moved the end outside the loop so that "break" can do a break. (KJS::WhileNode::execute): Ditto. (KJS::ForNode::execute): Ditto. (KJS::ForInNode::execute): Ditto. (KJS::ContinueNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::executeStatements): Ditto. Also renamed to have execute in its name to reflect the fact that it's a member of the same family of functions. (KJS::CaseBlockNode::executeBlock): Ditto. (KJS::SwitchNode::execute): Ditto. (KJS::LabelNode::execute): Ditto. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ProgramNode::execute): Ditto. (KJS::EvalNode::execute): Ditto. (KJS::FunctionBodyNode::execute): Ditto. (KJS::FuncDeclNode::execute): Ditto.
- kjs/nodes.h: Renamed setErrorCompletion to createErrorCompletion, made hitStatement protected, changed return value of execute to a JSValue, renamed evalStatements to executeStatements, and evalBlock to executeBlock.
- kjs/number_object.h: Removed unused execute function.
- 5:17 AM QtWebKitTodo edited by
- (diff)
- 2:31 AM Changeset in webkit [28886] by
-
- 2 edits in trunk/JavaScriptCore
Added Radar number.
- kjs/nodes.cpp: (KJS::ProgramNode::processDeclarations):
- 1:41 AM Changeset in webkit [28885] by
-
- 2 edits in trunk/JavaScriptCore
Linux build fix: config.h has to come first.
- kjs/error_object.cpp:
- 1:32 AM Changeset in webkit [28884] by
-
- 35 edits11 adds in trunk
Reviewed by Oliver Hunt.
Optimized global access to global variables, using a symbol table.
SunSpider reports a 1.5% overall speedup, a 6.2% speedup on 3d-morph,
and a whopping 33.1% speedup on bitops-bitwise-and.
- API/JSCallbackObjectFunctions.h: Replaced calls to JSObject:: with calls to Base::, since JSObject is not always our base class. This was always a bug, but the bug is even more apparent after some of my changes.
(KJS::::staticFunctionGetter): Replaced use of getDirect with call to
getOwnPropertySlot. Global declarations are no longer stored in the
property map, so a call to getDirect is insufficient for finding
override properties.
- API/testapi.c:
- API/testapi.js: Added test for the getDirect change mentioned above.
- kjs/ExecState.cpp:
- kjs/ExecState.h: Dialed back the optimization to store a direct pointer to the localStorage buffer. One ExecState can grow the global object's localStorage without another ExecState's knowledge, so ExecState can't store a direct pointer to the localStorage buffer unless/until we invent a way to update all the relevant ExecStates.
- kjs/JSGlobalObject.cpp: Inserted the symbol table into get and put operations. (KJS::JSGlobalObject::reset): Reset the symbol table and local storage, too. Also, clear the property map here, removing the need for a separate call.
- kjs/JSVariableObject.cpp:
- kjs/JSVariableObject.h: Added support for saving localStorage and the symbol table to the back/forward cache, and restoring them.
- kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Renamed progNode to evalNode because it's an EvalNode, not a ProgramNode.
- kjs/lookup.h: (KJS::cacheGlobalObject): Replaced put with faster putDirect, since that's how the rest of lookup.h works. putDirect is safe here because cacheGlobalObject is only used for objects whose names are not valid identifiers.
- kjs/nodes.cpp: The good stuff!
(KJS::EvalNode::processDeclarations): Replaced hasProperty with
the new hasOwnProperty, which is slightly faster.
- kjs/object.h: Nixed clearProperties because clear() does this job now.
- kjs/property_map.cpp:
- kjs/property_map.h: More back/forward cache support.
- wtf/Vector.h: (WTF::::grow): Added fast non-branching grow function. I used it in an earlier version of this patch, even though it's not used anymore.
JavaScriptGlue:
Build fix.
- ForwardingHeaders/wtf/VectorTraits.h: Added.
WebCore:
Reviewed by Oliver Hunt.
Build support:
- ForwardingHeaders/kjs/SymbolTable.h: Added.
- ForwardingHeaders/wtf/VectorTraits.h: Added.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Replaced use of getDirectLocation with getOwnPropertySlot. getDirectLocation is no longer valid, since global declarations are not stored in the property map.
(WebCore::JSDOMWindow::customPut): Replaced use of JSObject::put with
JSGlobalObject::put. JSObject::put is no longer valid, since global
declarations are not stored in the property map.
- bindings/js/kjs_window.cpp: Replaced JSObject:: calls with Base:: calls, since JSObject is not our base class. This was always a bug, but the bug is even more apparent after some of my changes.
(KJS::Window::clear): Removed call to clearProperties because
JSGlobalObject::reset takes care of that now.
- history/CachedPage.cpp:
- history/CachedPage.h: Added support for saving a symbol table and localStorage to the page cache, and restoring it.
WebKit/mac:
Reviewed by Oliver Hunt.
Build fix.
- ForwardingHeaders/kjs/SymbolTable.h: Added.
- ForwardingHeaders/wtf/VectorTraits.h: Added.
LayoutTests:
Reviewed by Oliver Hunt.
Added some tests to verify some of the changes I made while optimizing
global access to global variables.
- fast/dom/Window/resources/window-property-clearing-iframe0.html: Added.
- fast/dom/Window/resources/window-property-clearing-iframe1.html: Added.
- fast/dom/Window/window-property-clearing-expected.txt: Added.
- fast/dom/Window/window-property-clearing.html: Added.
- fast/dom/getter-on-window-object2-expected.txt: Added.
- fast/dom/getter-on-window-object2.html: Added.
Checked in failing results for these const tests. The symbol table
optimization broke const. (We didn't know this before because our only
tests used global variables.)
- fast/js/const-expected.txt:
- fast/js/kde/const-expected.txt:
- fast/js/resources/for-in-avoid-duplicates.js: Fixed a typo I noticed. Not related to this patch.
- fast/dom/Window/window-property-shadowing.html: Changed this test to use "this" instead of "window". The fact that "window" worked before, despite an overriding / shadowing var declaration, was a bug.
Dec 19, 2007:
- 10:40 PM Changeset in webkit [28883] by
-
- 2 edits in trunk/LayoutTests
- remove two more tests that pass now due to changed font fallback
- platform/win/Skipped:
- 10:29 PM BuildingGtk edited by
- added Lunar-Linux's package information. (diff)
- 10:21 PM Changeset in webkit [28882] by
-
- 7 edits in trunk
WebCore:
Reviewed by Darin Adler and Dave Hyatt.
- Substitute the user's preferred standard font for an unknown primary font before falling back on the platform's last resort font
Cannot be tested in DumpRenderTree because it sets the standard font to
Times, which is also the hard-coded last resort font on Mac.
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData): Changed the early bail out condition to allow getting generic font families from settings even if there are not @font-face rules. Fixed a typo that mapped fantasy to cursive. Added a mapping from -webkit-standard to the standard family.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Changed to always create a font selector. (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): Changed to always use the font selector.
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
- platform/graphics/FontCache.cpp: (WebCore::FontCache::getFontData): Try the user's preferred standard font before the platform's last resort font.
LayoutTests:
- remove passing tests following the change to font fallback
- platform/win/Skipped: Removed tests that failed only because they specified as primary font family a font family that was not available on Windows and therefore were rendered using the platform last resort font, Times New Roman. Now they are rendered using the 'standard' font family, which is set to Times on both Mac and Windows when running the tests.
- 8:24 PM Changeset in webkit [28881] by
-
- 3 edits in trunk/WebKitTools
Make svn-apply/svn-unapply work with patches from git-format-patch.
Reviewed by Darin.
- Scripts/svn-apply: (patch): If 'Index:' can't be found in the text passed in, print it out with a warning and return early.
- Scripts/svn-unapply: (patch): Ditto.
- 7:03 PM Changeset in webkit [28880] by
-
- 2 edits in trunk/WebCore
2007-12-19 Sven Herzberg <sven@imendio.com>
Reviewed by Alp Toker.
Scaled font destruction takes place in FontData::platformDestroy(). No
need to do it in FontPlatformData::~FontPlatformData().
Destroying platform data in platformDestroy() is a convention we
borrow from the Mac and Win ports.
- platform/graphics/gtk/FontPlatformDataGtk.cpp:
- 5:12 PM Changeset in webkit [28879] by
-
- 3 edits in trunk/WebCore
build fix (Windows)
Changed uint to unsigned int. uint caused Windows build breakage
- page/Page.cpp: (WebCore::Page::markAllMatchesForText):
- page/Page.h:
- 4:23 PM Changeset in webkit [28878] by
-
- 6 edits in trunk
2007-12-19 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16222
[GTK] Implement inline search and highlighting of matching strings.
- 4:02 PM Changeset in webkit [28877] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig, Dan Bernstein.
Tiger build fix: restored some graphics code still needed on Tiger.
- platform/graphics/GraphicsTypes.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
- 3:22 PM Changeset in webkit [28876] by
-
- 2 edits in trunk/WebCore
2007-12-19 Alp Toker <alp@atoker.com>
Build fix for Pango < 1.18.0 breakage introduced in r28864. Use Fc and
the Pango backend API in these cases.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
- 2:51 PM Changeset in webkit [28875] by
-
- 7 edits2 adds in trunk
WebCore:
Reviewed by Darin.
Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()
Calling Node::willRemove on the focusedNode would immediately tell the document to remove
the focused node, and trigger JS events. This means that the document is mutated while
the engine is trying to tell all child nodes that it's about to removed. To avoid
crashing, we need to hold off on mutating the document until node traversal is finished.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren):
- dom/Node.cpp:
- dom/Node.h: (WebCore::Node::willRemove):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
LayoutTests:
Reviewed by Darin.
Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()
- fast/events/nested-event-remove-node-crash-expected.txt: Added.
- fast/events/nested-event-remove-node-crash.html: Added.
- 1:57 PM Changeset in webkit [28874] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by Dan Bernstein.
Adding tests for canvas compositing modes to make sure the results don't change after:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode
The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly
- fast/canvas/canvas-composite.html: Added.
- platform/mac/fast/canvas/canvas-composite-expected.checksum: Added.
- platform/mac/fast/canvas/canvas-composite-expected.png: Added.
- platform/mac/fast/canvas/canvas-composite-expected.txt: Added.
WebCore:
Reviewed by Dan Bernstein.
Test: fast/canvas/canvas-composite.html
Fix for:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode
This fix makes setCompositeOperation consistent across all platforms that use CG.
The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly
- platform/graphics/GraphicsTypes.h:
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCompositeOperation):
- platform/graphics/mac/GraphicsContextMac.mm:
- platform/win/GraphicsContextWin.cpp:
- 1:45 PM Changeset in webkit [28873] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page
Test: fast/dynamic/subtree-boundary-percent-height.html
- rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Do not allow overflows with percent heights because sometimes they compute to 'auto'.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page
- fast/dynamic/subtree-boundary-percent-height.html: Added.
- platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.checksum: Added.
- platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.png: Added.
- platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
- 1:21 PM Changeset in webkit [28872] by
-
- 1 edit in trunk/WebCore/page/Settings.cpp
Fix unsigned/enum problem on Win32. r=darin.
- 12:26 PM Changeset in webkit [28871] by
-
- 2 edits in trunk/WebCore
Oops! Typo!
- 12:15 PM Changeset in webkit [28870] by
-
- 1 edit in trunk/WebCore/page/Settings.cpp
Fix unsigned/enum problem on Win32. r=darin.
- 12:14 PM Changeset in webkit [28869] by
-
- 3 edits in trunk/WebCore/page
Fix unsigned/enum problem on Win32. r=darin.
- 12:11 PM Changeset in webkit [28868] by
-
- 14 edits in trunk/WebCore
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16511
Speed up ClassNodeList and NamedNodeList by using the caching mechanism employed by ChildNodeList.
- This give a ~2.15x speedup on the native test @ http://ejohn.org/apps/classname/
- dom/ChildNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::ChildNodeList::ChildNodeList):
- dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList):
- dom/ClassNodeList.h:
Move getElementsByName and getElementsByClassName to Node so they
can use easily employ the caching already used by ChildNodeLists. In the case of
getElementsByClassName, this reduces code duplication in Element as well
- dom/Document.cpp:
- dom/Document.h:
Move getElementsByClassName to Node.
- dom/Element.cpp:
- dom/Element.h:
- dom/NameNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item):
- dom/NameNodeList.h:
Add maps of caches for ClassNodeLists and NameNodeList to NodeListsNodeData.
- dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): (WebCore::Node::Node): (WebCore::Node::~Node): (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
- dom/Node.h: Make m_nodeLists an OwnPtr. Moved getElementsByName and getElementsByClassName here
Allow subclasses to choose whether they want to receive the notifications using a new bit.
- dom/NodeList.cpp: (WebCore::NodeList::NodeList):
- dom/NodeList.h: (WebCore::NodeList::needsNotifications):
- 11:24 AM Changeset in webkit [28867] by
-
- 19 edits in trunk/WebCore
Add support for GDI text on Windows.
- 11:13 AM Changeset in webkit [28866] by
-
- 5 edits in trunk/WebKit/win
Add fourth preference value for GDI text font smoothing to WebKit.
- 10:41 AM Changeset in webkit [28865] by
-
- 2 edits in trunk
2007-12-19 Alp Toker <alp@atoker.com>
Remove the cairo-ft pkg-config check. The GTK+ port doesn't use
cairo-ft directly following changes in r28864.
- WebKit.pri:
- 10:00 AM Changeset in webkit [28864] by
-
- 6 edits in trunk/WebCore
2007-12-19 Sven Herzberg <sven@imendio.com>
Reviewed by Alp Toker.
Replace the fontconfig/freetype based font management with a pango
based one. Fixes:
http://bugs.webkit.org/show_bug.cgi?id=15229
- platform/gtk/FontDataGtk.cpp (FontData::platformDestroy()): updated the platform specific destroy code (FontData::containsCharacters()): implemented font coverage with pango
- platform/gtk/FontPlatformData.h: replaced fontconfig specific members with pango-specific ones
- platform/gtk/FontPlatformDataGtk.cpp: added static members for the FontPlatformData class (FontPlatformData::FontPlatformData()): implemented the font-matching with a PangoFontDescription instead of an FcPattern; initialize the scaled font by using the API for PangoCairoFont (FontPlatformData::init()): initialize the PangoFontMap and set up a hash table to translate the font family name into a font family (FontPlatformData::isFixedPitch()): implemented by querying the PangoFontFamily (FontPlatformData::operator==): compare the FontPlatformData by comparing the font pointers or the described fonts
- platform/gtk/GlyphPageTreeNodeGtk.cpp (pango_font_get_glyph()): added a function to query a glyph from a PangoFont (GlyphPage::fill()): implemented the fill function with Pango instead of fontconfig/freetype
- 9:36 AM Changeset in webkit [28863] by
-
- 2 edits in trunk/WebKitTools
wx build process improvements, including added checks and outdated changes after the move to trunk.
Reviewed by Alp Toker
- 9:00 AM Changeset in webkit [28862] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-19 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
Delete when Destroy functions are called to avoid leaks
This matches the Mac port.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ContextMenuClientGtk.cpp:
- WebCoreSupport/InspectorClientGtk.cpp:
- 8:55 AM Changeset in webkit [28861] by
-
- 2 edits in trunk/WebCore
2007-12-19 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
Improve graphics operator approximations
These changes match Cairo's own CG approximations.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::toCairoOperator):
- 8:55 AM Changeset in webkit [28860] by
-
- 2 edits in trunk/WebCore
2007-12-19 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
Check the bounding box before doing a full hit test
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
- 1:10 AM Changeset in webkit [28859] by
-
- 3 edits1 add in trunk/JavaScriptCore
Build fix for non-Mac platforms. Move NodeInfo into its own header so that the YYTYPE declaration in grammar.h is able to declare members of that type.
- 12:41 AM Changeset in webkit [28858] by
-
- 4 edits in trunk/WebCore
Reviewed by Geoff.
Fix for <rdar://problem/5646478>
REGRESSION: fast/events/event-view-toString fails on Leopard
This fixes an issue where we were incorrectly setting the lastInPrototypeChain
for the JSDOMWindow (the global object) before a call to setPrototype overwrote
it. This fixes it by passing the prototype up the constructor chain so that it
is set before any calls can be made.
- bindings/js/kjs_window.cpp: (KJS::Window::Window):
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGeneratorJS.pm:
- 12:13 AM Changeset in webkit [28857] by
-
- 2 edits in trunk/JavaScriptCore
Make appendToVarDeclarationList static
RS=Weinig
Dec 18, 2007:
- 11:53 PM Changeset in webkit [28856] by
-
- 8 edits5 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)
This final part of the work fixes the <img> tag.
This is the real fix.
- rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): Set the container size on the image. Setting the container size only actually sticks if the values are non-zero, so if the container size really was set, use the imageSize that is calculated using the container size. If it did not stick but the image does have relative width (meaning that the container size is 0), set the width to 0 by hand. We want to avoid setting the width before we have a container size or we will end up incorrectly using the default size of 300x150. (WebCore::RenderImage::calcReplacedHeight): Same as above, but for height.
A few more pieces of information have to be exposed through cached
image to make this happen.
- loader/CachedImage.cpp: (WebCore::CachedImage::usesImageContainerSize): As mentioned above, when setContainerSize() is called, the container size is only actually set if the values are non-zero. This call tells you if it was set. (WebCore::CachedImage::imageHasRelativeWidth): (WebCore::CachedImage::imageHasRelativeHeight):
- loader/CachedImage.h:
- platform/graphics/Image.h: (WebCore::Image::usesContainerSize):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::usesContainerSize):
- svg/graphics/SVGImage.h:
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)
- fast/images/resources/green-relative-size-rect.svg: Added.
- fast/images/svg-as-relative-image.html: Added.
- platform/mac/fast/images/svg-as-relative-image-expected.checksum: Added.
- platform/mac/fast/images/svg-as-relative-image-expected.png: Added.
- platform/mac/fast/images/svg-as-relative-image-expected.txt: Added.
- 11:42 PM Changeset in webkit [28855] by
-
- 3 edits in trunk/JavaScriptCore
Remove dead code due to removal of post-parse declaration discovery.
RS=Geoff.
Due to the removal of the declaration discovery pass after parsing we
no longer need any of the logic used for that discovery.
- 11:42 PM Changeset in webkit [28854] by
-
- 7 edits in trunk/JavaScriptCore
Replace post-parse pass to find declarations with logic in the parser itself
Reviewed by Geoff.
Instead of finding declarations in a pass following the initial parsing of
a program, we incorporate the logic directly into the parser. This lays
the groundwork for further optimisations (such as improving performance in
declaration expressions -- var x = y; -- to match that of standard assignment)
in addition to providing a 0.4% performance improvement in SunSpider.
- 9:04 PM Changeset in webkit [28853] by
-
- 4 edits in trunk
Versioning.
- 9:02 PM Changeset in webkit [28852] by
-
- 1 copy in tags/Safari-4525.1
New tag.
- 9:02 PM Changeset in webkit [28851] by
-
- 1 copy in tags/Safari-5525.1
New tag.
- 8:58 PM Changeset in webkit [28850] by
-
- 4 edits in trunk
Fix typo in hosted SunSpider page.
- 8:54 PM Changeset in webkit [28849] by
-
- 2 edits in trunk/WebKitSite
Correct link to Visual Studio Express 2005.
Old link points to 2008.
Reviewed by Mark.
- building/tools.html:
- 7:11 PM Changeset in webkit [28848] by
-
- 2 edits in trunk/WebKitTools
- Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
- 6:58 PM Changeset in webkit [28847] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-18 Xan Lopez <xan@gnome.org>
Reviewed by Geoff.
Fix http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):
Use less strict memory operand constraint on inline asm generation.
PLATFORM(DARWIN) left unpatched due to Apple's GCC bug.
Patch by David Kilzer <ddkilzer@webkit.org>
- 6:12 PM Changeset in webkit [28846] by
-
- 2 edits2 deletes in trunk
Remove outdated and non-functioning project files for the Apollo port. Rubber-stamped by Maciej Stachowiak and Chris Brichford.
- 5:41 PM Changeset in webkit [28845] by
-
- 2 edits in trunk/LayoutTests
Reviewed by John Sullivan.
- remove passing test and reclassify one failing test
- platform/win/Skipped: Removed fast/text/international/002.html.
- 5:12 PM Changeset in webkit [28844] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Geoffrey.
- Temporarily remove calls that are causing subsequent tests in DRT to fail. Filled http://bugs.webkit.org/show_bug.cgi?id=16510 to track the issue.
- http/tests/security/cross-frame-access-history-expected.txt:
- http/tests/security/cross-frame-access-history.html:
- 4:58 PM Changeset in webkit [28843] by
-
- 1 edit1 add in trunk/WebKitTools
Add script to run Drosera as part of the nightly.
Reviewed by Kevin M.
- Scripts/run-drosera.cmd: Added.
- 4:35 PM Changeset in webkit [28842] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Remove a stray K.
- 4:34 PM Changeset in webkit [28841] by
-
- 2 edits in trunk/JavaScriptCore
- fix Windows build
- pcre/pcre_exec.cpp: (jsRegExpExecute): Change back from false/true to 0/1 -- I probably should not have deleted MATCH_MATCH and MATCH_NOMATCH, but I'm going to leave them out.
- 3:40 PM Changeset in webkit [28840] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Plan more renaming.
- 3:38 PM Changeset in webkit [28839] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5649911> REGRESSION (304-306A9): Typing 'p' in popup menu for type-to-select brings up Safari Help
Need to translate the char back into a key code for posting our WM_KEYDOWN.
Reviewed by Ada.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
- 2:56 PM Changeset in webkit [28838] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5651534> REGRESSION(r28764-r28765): GDI leak drawing text when no appropriate font is available
Our captured metafile from Uniscribe may contain multiple calls to CreateFontIndirect.
Only create a font with the last one.
Reviewed by Mitz, Darin.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::FontCache::getFontDataForCharacters):
- 2:32 PM Changeset in webkit [28837] by
-
- 3 edits in trunk/LayoutTests
- fix failing regression test
- fast/regex/resources/TEMPLATE.html: Updated this template -- I accidentally landed the one that was copied without updating the paths.
- fast/regex/slow.html: Regenerated.
- 1:50 PM Changeset in webkit [28836] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Darin.
Fixed <rdar://problem/5646454> REGRESSION: dom/xhtml/level2/html/HTMLDocument12 fails on Leopard
- fast/cookies/local-file-can-set-cookies.html: cookies are matched by domain and path, and since layout tests are file URLs, they all match on domain. setting a cookie without specifying the path will make CFNetwork pick up the path from the URL automatically. Since fast/cookies/local-file-can-set-cookies.html set a specific path of /, that cookie will be set for EVERY local file loaded in Safari. removing that component from the cookie string will fix the problem.
- 1:37 PM Changeset in webkit [28835] by
-
- 5 edits2 adds in trunk/WebCore
2007-12-17 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16464
Modify WebCore to use win32 thread primitives
Updates to support native windows threading primitives
rather than pthreads emulation library.
- WebCore.vcproj/WebCore.vcproj:
- config.h:
- platform/Threading.h:
- platform/win/MutexWin.cpp: Added. (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock):
- platform/win/ThreadConditionWin.cpp: Added. (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
- platform/win/ThreadingWin.cpp: (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::storeThreadHandleByIdentifier): (WebCore::identifierByThreadHandle): (WebCore::threadHandleForIdentifier): (WebCore::clearThreadHandleForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::currentThread):
- 1:36 PM Changeset in webkit [28834] by
-
- 2 edits in trunk/WebCore
2007-12-18 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Darin Adler.
Handle EINTR when set by select() and try the select() again
http://bugs.webkit.org/show_bug.cgi?id=16071
- platform/network/curl/ResourceHandleManager.cpp: (ResourceHandleManager::downloadTimerCallback):
- 11:30 AM Changeset in webkit [28833] by
-
- 4 edits1 copy4 adds in trunk
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=16458 REGRESSION (r28164): regular expressions can now hang due to lack of a match limit <rdar://problem/5636067>
Test: fast/regex/slow.html
Slows down SunSpider a bit (about 1.01x); filed a bug to follow up on that:
http://bugs.webkit.org/show_bug.cgi?id=16503
- pcre/pcre.h: Changed name of error code to not specifically mention "recursion".
- pcre/pcre_exec.cpp: (match): Replaced the depth limit, MATCH_RECURSION_LIMIT, with a total match looping limit, matchLimit. Also eliminated the constants for MATCH_MATCH and MATCH_NOMATCH, since they are just true and false (1 and 0). (jsRegExpExecute): More of the MATCH_MATCH change.
LayoutTests:
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=16458 REGRESSION (r28164): regular expressions can now hang due to lack of a match limit
- fast/regex/resources: Added.
- fast/regex/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- fast/regex/resources/slow.js: Added.
- fast/regex/slow-expected.txt: Added.
- fast/regex/slow.html: Added.
- 10:58 AM Changeset in webkit [28832] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- avoid the simplified Chinese font linking code for characters that are not in any Windows code page
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
- 10:35 AM Changeset in webkit [28831] by
-
- 2 edits in trunk/LayoutTests
Reviewed by John Sullivan.
- remove passing test
- platform/win/Skipped: Removed fast/text/international/wrap-CJK-001.html
- 10:19 AM Changeset in webkit [28830] by
-
- 7 edits in trunk/WebCore
Reviewed by Adele
<rdar://problem/5525770> REGRESSION: HTTP Auth protected favicon request results in a password sheet
Some http-auth protected sites have the main resource(s) unprotected, but many subresources are
protected by authentication. Occasionally one can view the main page of a site but the favicon
is behind the iron curtain - in these cases, we should *not* prompt for a username and password
solely for the favicon.
- loader/ResourceLoader.h: Make didReceiveAuthenticationChallenge virtual
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Now that this method is virtual from ResourceLoader, SubresourceLoader can override. First call to the SubresourceLoaderClient. If they cancel the resource load, return early. Otherwise, let ResourceLoader work its magic (resulting in the auth sheet coming down)
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveAuthenticationChallenge):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveAuthenticationChallenge): Cancel the resource load, since we should never prompt the user for credentials just for a favicon.
- loader/icon/IconLoader.h:
- 9:07 AM Changeset in webkit [28829] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady
- fixed <rdar://problem/5652380> Initial prompt shows "" for databases with no user-visible name
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): pass "name" instead of "displayName" if there's no displayName
- 1:27 AM Changeset in webkit [28828] by
-
- 2 edits in trunk/SunSpider
Reviewed by Eric.
- give an extra digit of precision for small differences.
- resources/sunspider-compare-results.js:
Dec 17, 2007:
- 10:01 PM Changeset in webkit [28827] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
- restore ButtonFace and ThreeDFace to their previous values for non-Mac platforms. The Mac port also uses the same values for now instead of NSColor-based ones.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
- 9:24 PM Changeset in webkit [28826] by
-
- 3 edits in trunk/WebCore
2007-12-17 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Maciej Stachowiak.
Define WTF_USE_NPOBJECT and WTF_USE_JAVASCRIPTCORE_BINDINGS for GTK+
Add required Frame::createScriptInstanceForWidget to FrameGtk
- config.h:
- page/gtk/FrameGtk.cpp (Frame::createScriptInstanceForWidget):
- 8:39 PM Changeset in webkit [28825] by
-
- 4 edits in trunk
SunSpider:
Reviewed by Eric.
- work around IE layout bugs
- hosted/sunspider.css:
WebKitSite:
Reviewed by Eric.
- work around IE layout bugs
- perf/sunspider-0.9/sunspider.css:
- 6:21 PM Changeset in webkit [28824] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Fixed <rdar://5566435> window with no scrollbars can be scrolled
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): corrected maximumScroll() to account for scrolling not allowed. (WebCore::ScrollView::wheelEvent):
- 6:10 PM Changeset in webkit [28823] by
-
- 3 edits2 adds in trunk/LayoutTests
Reviewed by Adam.
Test for <rdar://problem/5566435> window with no scrollbars can still be scrolled with wheelevent
- fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Added.
- fast/events/attempt-scroll-with-no-scrollbars.html: Added.
- platform/mac/Skipped: Adding to mac Skipped list because of <rdar://problem/5643675> window.scrollTo scrolls a window with no scrollbars
- platform/win/Skipped: Adding to win Skipped list because of <rdar://problem/5132009> Windows DRT does not support multiple windows
- 5:30 PM Changeset in webkit [28822] by
-
- 3 edits in trunk/WebKit/win
Reviewed by Sam.
- <rdar://4516170> Back/Forward Cache on Windows
- WebFrame.cpp: (WebFrame::forceLayout): Implemented this. Just calling through to Frame::forceLayout matches the Mac pretty well and should be enough for now. Without this we won't repaint the new page when we go back and forward. (WebFrame::dispatchWillSubmitForm): Use COMPtr's AdoptCOM constructor instead of the adoptRef function. (WebFrame::restoreViewState): Removed unneeded notImplemented() call. This is implemented as much as it needs to be. (WebFrame::shouldGoToHistoryItem): Ditto. (WebFrame::saveViewStateToItem): Ditto. (WebFrame::canCachePage): Ditto, also changed it to return true. This is what was preventing the back/forward cache from running, and there's no need for any additional checks in the Windows version.
- WebView.cpp: (PreferencesChangedOrRemovedObserver::onNotify): Fix backwards null check that was preventing this notification from ever being sent, which in turn meant that page cache had a capacity of 0. (WebView::initWithFrame): Removed unneeded setUsesPageCache(false) code. This actually was ineffective and ended up doing no harm, but we don't need it.
- 5:07 PM Known incompatibilities between open-source WebKit and Safari edited by
- (diff)
- 5:05 PM Known incompatibilities between open-source WebKit and Safari edited by
- (diff)
- 3:10 PM Changeset in webkit [28821] by
-
- 3 edits in tags/Safari-525.3.2b/WebCore
Merged r28816.
- 2:54 PM Changeset in webkit [28820] by
-
- 1 edit1 move in trunk/LayoutTests
- disabling this test until we can find a way to make it pass on diverse machines
- fast/css/css2-system-color.html: Removed.
- fast/css/css2-system-color.html-disabled: Copied from fast/css/css2-system-color.html.
- 1:31 PM Changeset in webkit [28819] by
-
- 1 copy in tags/Safari-525.3.2b
New tag.
- 12:54 PM Changeset in webkit [28818] by
-
- 12 edits2 deletes in trunk
2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16042
[GTK] Eliminate webkit_init()
Move webkit initialization to WebView class init.
- 12:51 PM Changeset in webkit [28817] by
-
- 9 edits in trunk
2007-12-17 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=13542
gdklauncher doesnt change URL in adress GTKEntry.
Let DOMDocument observers do their work before emitting title-changed.
The load-committed signal has been added for both the view and the frame.
- 12:14 PM QtWebKitTodo edited by
- (diff)
- 11:48 AM Changeset in webkit [28816] by
-
- 3 edits in trunk/WebCore
2007-12-17 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5651291> REGRESSION: Flash content doesn't display
(www.adobe.com)
We were passing NPEvent instead of NPEvent* to NPP_HandleEvent.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::dispatchNPEvent): Changed to take NPEvent&, not NPEvent* (WebCore::PluginViewWin::paint): Pass NPEvent, not NPEvent* (WebCore::PluginViewWin::handleKeyboardEvent): same (WebCore::PluginViewWin::handleMouseEvent): same
- plugins/win/PluginViewWin.h:
- 11:44 AM Changeset in webkit [28815] by
-
- 2 edits in trunk/LayoutTests
Fix argument to window.open.
- http/tests/misc/window-open-then-write.html:
- 10:42 AM Changeset in webkit [28814] by
-
- 3 edits in trunk/LayoutTests
2007-12-17 Mark Rowe <mrowe@apple.com>
Update test results after r28812.
- platform/mac-tiger/fast/css/css2-system-color-expected.txt:
- platform/mac/fast/css/css2-system-color-expected.txt:
- 10:34 AM Changeset in webkit [28813] by
-
- 4 edits2 adds in trunk
Reviewed by Darin.
Live to the promise of never making AppKit special character codes visible via DOM.
Test: fast/events/arrow-keys-on-body.html
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Check for empty keypress characters after disambiguation, to let quirks-aware code strip special charactrers.
- platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): If not in keyboard event quirks mode, remove the text if it's a special character.
- 10:21 AM Changeset in webkit [28812] by
-
- 2 edits in trunk/WebCore
2007-12-17 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix incorrect array size and incorrect array index in convertNSColorToColor.
- rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor):
- 9:53 AM Changeset in webkit [28811] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=16468 REGRESSION(r28781): Crash running storage/transaction_callback_exception_crash.html
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database because there's no guarantee it won't lose its last reference otherwise.
- 9:09 AM Changeset in webkit [28810] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/5333260> Some Chinese characters in Text Encoding menu are bold, others are not and <rdar://problem/5280188> Chinese text looks worse on Safari for Windows cf. Safari for Mac
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): To ensure that font linking gives consistent results for characters that are exclusive to the simplified Chinese code page and characters that belong to that code page and other code pages, always ask to map to simplified Chinese alone first.
- 8:18 AM Changeset in webkit [28809] by
-
- 3 edits in trunk/WebCore
2007-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16378
Implement Icon for Gtk
Icon provides a GdkPixbuf containing a themed icon.
The icon theme is probed for an icon name according to the
Icon Naming Specification or conventional Gnome icon names respectively.
See http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
- platform/graphics/Icon.h:
- platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::~Icon): (WebCore::lookupIconName): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
- 3:55 AM Changeset in webkit [28808] by
-
- 1 copy in tags/SunSpider-0.9
Tag SunSpider 0.9.
- 3:55 AM Changeset in webkit [28807] by
-
- 1 delete in tags/SunSpider-0.9
Remove bad tag
- 3:50 AM Changeset in webkit [28806] by
-
- 4 edits in trunk
SunSpider:
Reviewed by Mark.
- fix compare feature
- hosted/sunspider-results.html:
WebKitSite:
Reviewed by Mark.
- fix compare feature
- perf/sunspider-0.9/sunspider-results.html:
- 3:23 AM QtWebKitTodo edited by
- (diff)
- 1:44 AM Changeset in webkit [28805] by
-
- 1 copy in tags/SunSpider-0.9
Tag SunSpider 0.9.
- 1:44 AM Changeset in webkit [28804] by
-
- 1 delete in tags/SunSpider-0.9
Remove bad tag
- 1:44 AM Changeset in webkit [28803] by
-
- 1 edit36 adds in trunk/WebKitSite
Rubber stamped by Mark.
- Add a copy of SunSpider 0.9 to the site
- perf: Added.
- perf/sunspider-0.9: Added.
- perf/sunspider-0.9/3d-cube.html: Added.
- perf/sunspider-0.9/3d-morph.html: Added.
- perf/sunspider-0.9/3d-raytrace.html: Added.
- perf/sunspider-0.9/access-binary-trees.html: Added.
- perf/sunspider-0.9/access-fannkuch.html: Added.
- perf/sunspider-0.9/access-nbody.html: Added.
- perf/sunspider-0.9/access-nsieve.html: Added.
- perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Added.
- perf/sunspider-0.9/bitops-bits-in-byte.html: Added.
- perf/sunspider-0.9/bitops-bitwise-and.html: Added.
- perf/sunspider-0.9/bitops-nsieve-bits.html: Added.
- perf/sunspider-0.9/controlflow-recursive.html: Added.
- perf/sunspider-0.9/crypto-aes.html: Added.
- perf/sunspider-0.9/crypto-md5.html: Added.
- perf/sunspider-0.9/crypto-sha1.html: Added.
- perf/sunspider-0.9/date-format-tofte.html: Added.
- perf/sunspider-0.9/date-format-xparb.html: Added.
- perf/sunspider-0.9/math-cordic.html: Added.
- perf/sunspider-0.9/math-partial-sums.html: Added.
- perf/sunspider-0.9/math-spectral-norm.html: Added.
- perf/sunspider-0.9/regexp-dna.html: Added.
- perf/sunspider-0.9/string-base64.html: Added.
- perf/sunspider-0.9/string-fasta.html: Added.
- perf/sunspider-0.9/string-tagcloud.html: Added.
- perf/sunspider-0.9/string-unpack-code.html: Added.
- perf/sunspider-0.9/string-validate-input.html: Added.
- perf/sunspider-0.9/sunspider-analyze-results.js: Added.
- perf/sunspider-0.9/sunspider-compare-results.js: Added.
- perf/sunspider-0.9/sunspider-driver.html: Added.
- perf/sunspider-0.9/sunspider-record-result.js: Added.
- perf/sunspider-0.9/sunspider-results.html: Added.
- perf/sunspider-0.9/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9/sunspider.css: Added.
- perf/sunspider-0.9/sunspider.html: Added.
- 1:43 AM Changeset in webkit [28802] by
-
- 1 copy in tags/SunSpider-0.9/SunSpider
Tag SunSpider 0.9.
- 1:43 AM Changeset in webkit [28801] by
-
- 3 edits in trunk/SunSpider
Reviewed by Mark.
- Change the format of the output URL to be shorter, to meet IE constraints
- hosted/sunspider-driver.html:
- hosted/sunspider-results.html:
- 1:19 AM Changeset in webkit [28800] by
-
- 1 copy in tags/SunSpider-0.9
Tag SunSpider 0.9.
- 12:56 AM Changeset in webkit [28799] by
-
- 2 edits in trunk/JavaScriptCore
- speculative build fix for non-gcc platforms
- pcre/pcre_exec.cpp: (match): Remove unused cases from return switch.
Dec 16, 2007:
- 11:19 PM Changeset in webkit [28798] by
-
- 10 edits2 copies in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16466
Move the JS Location object to its own file
- Move Location into its own file and rename it JSLocation.
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSLocation.cpp: Copied from WebCore/bindings/js/kjs_window.cpp. (WebCore::): (WebCore::JSLocation::JSLocation): (WebCore::JSLocation::getValueProperty): (WebCore::JSLocation::getOwnPropertySlot): (WebCore::JSLocation::put): (WebCore::JSLocationProtoFuncReplace::callAsFunction): (WebCore::JSLocationProtoFuncReload::callAsFunction): (WebCore::JSLocationProtoFuncAssign::callAsFunction): (WebCore::JSLocationProtoFuncToString::callAsFunction):
- bindings/js/JSLocation.h: Copied from WebCore/bindings/js/kjs_window.h. (WebCore::JSLocation::): (WebCore::JSLocation::frame): (WebCore::JSLocation::classInfo):
- bindings/js/kjs_window.cpp: (KJS::Window::location):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- 10:26 PM Changeset in webkit [28797] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- make 'cursor: copy' and 'cursor: none' work.
Already covered by manual-tests/cursor.html
- rendering/RenderStyle.h: Increase the _cursor_style field to 6 bits, needed for the 33rd and 34th cursor values.
- 10:01 PM Changeset in webkit [28796] by
-
- 2 edits in trunk/JavaScriptCore
Speculative build fix for non-Mac platforms.
- 10:00 PM Changeset in webkit [28795] by
-
- 10 edits2 copies1 move1 delete in trunk
Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
Reviewed by Maciej Stachowiak.
- 8:50 PM Changeset in webkit [28794] by
-
- 9 edits2 copies in trunk/WebCore
Reviewed by Maciej.
Yet more of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move ScheduledAction into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp:
- bindings/js/PausedTimeouts.h:
- bindings/js/ScheduledAction.cpp: Copied from bindings/js/kjs_window.cpp. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h: Copied from bindings/js/kjs_window.h. (WebCore::ScheduledAction::ScheduledAction):
- bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::action): (KJS::DOMWindowTimer::takeAction): (KJS::Window::installTimeout): (KJS::Window::timerFired):
- bindings/js/kjs_window.h:
- 8:19 PM Changeset in webkit [28793] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16438
- removed some more unused code
- changed quite a few more names to WebKit-style
- moved more things out of pcre_internal.h
- changed some indentation to WebKit-style
- improved design of the functions for reading and writing 2-byte values from the opcode stream (in pcre_internal.h)
- pcre/dftables.cpp: (main): Added the kjs prefix a normal way in lieu of using macros.
- pcre/pcre_compile.cpp: Moved some definitions here from pcre_internal.h. (errorText): Name changes, fewer typedefs. (checkEscape): Ditto. Changed uppercase conversion to use toASCIIUpper. (isCountedRepeat): Name change. (readRepeatCounts): Name change. (firstSignificantOpcode): Got rid of the use of OP_lengths, which is very lightly used here. Hard-coded the length of OP_BRANUMBER. (firstSignificantOpcodeSkippingAssertions): Ditto. Also changed to use the advanceToEndOfBracket function. (getOthercaseRange): Name changes. (encodeUTF8): Ditto. (compileBranch): Name changes. Removed unused after_manual_callout and the code to handle it. Removed code to handle OP_ONCE since we never emit this opcode. Changed to use advanceToEndOfBracket in more places. (compileBracket): Name changes. (branchIsAnchored): Removed code to handle OP_ONCE since we never emit this opcode. (bracketIsAnchored): Name changes. (branchNeedsLineStart): More fo the same. (bracketNeedsLineStart): Ditto. (branchFindFirstAssertedCharacter): Removed OP_ONCE code. (bracketFindFirstAssertedCharacter): More of the same. (calculateCompiledPatternLengthAndFlags): Ditto. (returnError): Name changes. (jsRegExpCompile): Ditto.
- pcre/pcre_exec.cpp: Moved some definitions here from pcre_internal.h. (matchRef): Updated names. Improved macros to use the do { } while(0) idiom so they expand to single statements rather than to blocks or multiple statements. And refeactored the recursive match macros. (MatchStack::pushNewFrame): Name changes. (getUTF8CharAndIncrementLength): Name changes. (match): Name changes. Removed the ONCE opcode. (jsRegExpExecute): Name changes.
- pcre/pcre_internal.h: Removed quite a few unneeded includes. Rewrote quite a few comments. Removed the macros that add kjs prefixes to the functions with external linkage; instead renamed the functions. Removed the unneeded typedefs pcre_uint16, pcre_uint32, and uschar. Removed the dead and not-all-working code for LINK_SIZE values other than 2, although we aim to keep the abstraction working. Removed the OP_LENGTHS macro. (put2ByteValue): Replaces put2ByteOpcodeValueAtOffset. (get2ByteValue): Replaces get2ByteOpcodeValueAtOffset. (put2ByteValueAndAdvance): Replaces put2ByteOpcodeValueAtOffsetAndAdvance. (putLinkValueAllowZero): Replaces putOpcodeValueAtOffset; doesn't do the addition, since a comma is really no better than a plus sign. Added an assertion to catch out of range values and changed the parameter type to int rather than unsigned. (getLinkValueAllowZero): Replaces getOpcodeValueAtOffset. (putLinkValue): New function that most former callers of the putOpcodeValueAtOffset function can use; asserts the value that is being stored is non-zero and then calls putLinkValueAllowZero. (getLinkValue): Ditto. (putLinkValueAndAdvance): Replaces putOpcodeValueAtOffsetAndAdvance. No caller was using an offset, which makes sense given the advancing behavior. (putLinkValueAllowZeroAndAdvance): Ditto. (isBracketOpcode): Added. For use in an assertion. (advanceToEndOfBracket): Renamed from moveOpcodePtrPastAnyAlternateBranches, and removed comments about how it's not well designed. This function takes a pointer to the beginning of a bracket and advances to the end of the bracket.
- pcre/pcre_tables.cpp: Updated names.
- pcre/pcre_ucp_searchfuncs.cpp: (kjs_pcre_ucp_othercase): Ditto.
- pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): Ditto. (kjs_pcre_xclass): Ditto.
- pcre/ucpinternal.h: Ditto.
- wtf/ASCIICType.h: (WTF::isASCIIAlpha): Added an int overload, like the one we already have for isASCIIDigit. (WTF::isASCIIAlphanumeric): Ditto. (WTF::isASCIIHexDigit): Ditto. (WTF::isASCIILower): Ditto. (WTF::isASCIISpace): Ditto. (WTF::toASCIILower): Ditto. (WTF::toASCIIUpper): Ditto.
- 8:08 PM Changeset in webkit [28792] by
-
- 4 edits2 adds in trunk/WebCore
2007-12-16 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16356
[GTK] Integrate GStreamer video with the graphics backend
Integrate the GStreamer media backend with the Cairo graphics backend.
There are still some issues: Data is copied more often than necessary,
and repaint() is not called, causing transformed video not to update
sometimes.
- WebCore.pro:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: Added. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_set_caps): (webkit_video_sink_dispose): (webkit_video_sink_finalize): (webkit_video_sink_set_property): (webkit_video_sink_get_property): (webkit_video_sink_stop): (webkit_video_sink_class_init): (webkit_video_sink_new): (webkit_video_sink_set_surface): (plugin_init):
- platform/graphics/gtk/VideoSinkGStreamer.h: Added.
- 6:09 PM Changeset in webkit [28791] by
-
- 2 edits in trunk/WebCore
2007-12-16 Mark Rowe <mrowe@apple.com>
Mac build fix.
- WebCore.xcodeproj/project.pbxproj: Remove NetscapePlugInStreamLoader.cpp from the WebCore target. Mac currently has its own implementation in NetscapePlugInStreamLoaderMac.mm which conflicts with the new shared implementation.
- 5:50 PM Changeset in webkit [28790] by
-
- 3 edits1 delete in trunk/WebCore
2007-12-16 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16389
Bug 16389: Common Implementation of NetscapePlugInStreamLoader
- WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
- loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
- loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.
- 5:35 PM Changeset in webkit [28789] by
-
- 2 edits in trunk/WebKitTools
2007-12-16 Dimitri Glazkov <dimitri@glazkov.com>
Reviewed by Adam Roben.
Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
- FindSafari/FindSafari.cpp: (_tmain):
- 5:33 PM Changeset in webkit [28788] by
-
- 2 edits in trunk/WebKitTools
2007-12-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16315
FindSafari needs a path-only option.
- FindSafari/FindSafari.cpp: (_tmain):
- 5:31 PM Changeset in webkit [28787] by
-
- 2 edits in trunk/LayoutTests
- fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an out-of-date file last time.
- 5:28 PM Changeset in webkit [28786] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
- dom/Document.cpp: (WebCore::Document::Document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 5:26 PM Changeset in webkit [28785] by
-
- 5 edits in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16459 REGRESSION: assertion failure with regexp with \B in a case-ignoring character range <rdar://problem/5646361>
The problem was that \B was not handled properly in character classes.
Test: fast/js/regexp-overflow.html
- pcre/pcre_compile.cpp: (check_escape): Added handling of ESC_b and ESC_B in character classes here. Allows us to get rid of the handling of \b in character classes from all the call sites that handle it separately and to handle \B properly as well. (compileBranch): Remove the ESC_b handling, since it's not needed any more. (calculateCompiledPatternLengthAndFlags): Ditto.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=16459 REGRESSION: assertion failure with regexp with \B in a case-ignoring character range <rdar://problem/5646361>
- fast/js/regexp-overflow-expected.txt: Updated.
- fast/js/resources/regexp-overflow.js: Added test cases.
- 5:26 PM Changeset in webkit [28784] by
-
- 3 edits in trunk/WebCore
2007-12-16 Grace Kloba <klobag@gmail.com>
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
- dom/Document.cpp: (WebCore::Document::Document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 5:20 PM Changeset in webkit [28783] by
-
- 2 edits2 adds in trunk/WebKitSite
2007-12-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej Stachowiak.
- building/debug.html: Update to expand the win32 debugging instructions.
- 5:14 PM Changeset in webkit [28782] by
-
- 2 edits in trunk/JavaScriptCore
Fix http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).
Reviewed by Maciej Stachowiak.
- kjs/array_instance.cpp:
(KJS::compareByStringPairForQSort):
(KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
results. This avoids calling toString twice per comparison, but requires a temporary buffer
so we only use this approach in cases where the array being sorted is not too large.
- 4:24 PM Changeset in webkit [28781] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin.
More of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move PausedTimeouts into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
- bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
- bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- history/CachedPage.h:
- page/Chrome.cpp:
LayoutTests:
Reviewed by Maciej.
- tests for the argument handling of the executeSql function
- storage/execute-sql-args-expected.txt: Added.
- storage/execute-sql-args.html: Added.
- 4:17 PM Changeset in webkit [28780] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
- try to get the system color test passing on the buildbot
I fear this test may be vulnerable to slight platform differences.
- platform/mac-tiger/fast: Added.
- platform/mac-tiger/fast/css: Added.
- platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
- platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
- platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt. Then updated to match what the buildbot says.
- platform/mac/fast/css/css2-system-color-expected.txt: Updated to match results I'm getting locally on my Leopard machine.
- 3:59 PM Changeset in webkit [28779] by
-
- 10 edits2 copies in trunk/WebCore
Reviewed by Darin.
More of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move PausedTimeouts into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
- bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
- bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- history/CachedPage.h:
- page/Chrome.cpp:
- 3:08 PM Changeset in webkit [28778] by
-
- 4 edits10 adds in trunk
WebCore:
Reviewed by Geoff.
Make relative-size SVGs work in border-image.
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):
LayoutTests:
Reviewed by Geoff.
Tests for SVG as border-image.
- fast/borders/resources/green-fixed-size-rect.svg: Added.
- fast/borders/resources/green-relative-size-rect.svg: Added.
- fast/borders/svg-as-border-image-2.html: Added.
- fast/borders/svg-as-border-image.html: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.
- 2:53 PM Changeset in webkit [28777] by
-
- 6 edits1 copy in trunk/JavaScriptCore
Reviewed by Darin Adler and Maciej Stachowiak.
More refactoring to support global variable optimization.
Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
UString::Rep*. With globals, the symbol table can outlast the
declaration node for any given symbol, so the symbol table needs to ref
its symbol names.
In support, specialized HashMaps with RefPtr keys to allow lookup
via raw pointer, avoiding refcount churn.
SunSpider reports a .6% speedup (prolly just noise).
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added new file: wtf/RefPtrHashMap.h
- JavaScriptCore.xcodeproj/project.pbxproj: ditto
- kjs/JSVariableObject.cpp: (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.
- kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a static Rep* for null, which helps compute the deletedValue() trait.
- wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.
- wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions of find(), contains(), get(), set(), add(), remove(), and take() that take raw pointers as keys.
- 12:43 PM QtWebKitTodo edited by
- (diff)
- 12:14 PM Changeset in webkit [28776] by
-
- 2 edits in trunk/WebCore
- fix Tiger build (my fault it was broken)
- rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.
- 11:26 AM Changeset in webkit [28775] by
-
- 10 edits4 adds in trunk
WebCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors
Test: fast/css/css2-system-color.html
Based on original patch by Rob Buis.
System colors are retrieved from NSColor as appropriate. If the color is a pattern color
(and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
color and sample that to get a solid color.
- css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::getSystemColor): (WebCore::RenderThemeMac::platformColorsDidChange): (WebCore::RenderThemeMac::systemColor):
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors
Add layout test for this bug and update tests for new system-derived colors
- fast/css/css2-system-color.html: Added.
- platform/mac/fast/css/css2-system-color-expected.checksum: Added.
- platform/mac/fast/css/css2-system-color-expected.png: Added.
- platform/mac/fast/css/css2-system-color-expected.txt: Added.
- platform/mac/fast/css/css2-system-fonts-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
- 10:40 AM Changeset in webkit [28774] by
-
- 4 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16426 Divs with overflow:auto: scrollbars not correctly updated when contents change
Test: fast/overflow/scrollbar-position-update.html
- platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbProportion): Update the NSScroller's value for the new proportions.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary repaint(). Scrollbars repaint themselves as needed.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=16426 Divs with overflow:auto: scrollbars not correctly updated when contents change
- fast/overflow/scrollbar-position-update.html: Added.
- platform/mac-leopard/fast/overflow: Added.
- platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
- platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
- platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
- 10:13 AM Changeset in webkit [28773] by
-
- 2 edits in trunk/WebKit/wx
- try to fix the build
- WebView.cpp: (wxWebView::OnKeyEvents): Add a WebCore prefix.
- 9:37 AM Changeset in webkit [28772] by
-
- 6 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14140
<rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
WebCore:
- dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): (WebCore::KeyboardEvent::keypressCommands): Change stored command class to preserve complete information about commands.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText: as a command.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.
WebKit:
- WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work when handling keypress, too. (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events. (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also, restore the state for additional commands to be saved correctly.
- 9:31 AM Changeset in webkit [28771] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16162
Problems with float parsing on Linux (locale-dependent parsing was used).
- kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
- kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.
- 9:23 AM QtWebKitTodo edited by
- (diff)
- 8:16 AM Changeset in webkit [28770] by
-
- 9 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16462
REGRESSION: access keys broken on Windows
- 5:20 AM Changeset in webkit [28769] by
-
- 2 edits in trunk/WebCore
2007-12-16 Xan Lopez <xan@gnome.org>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=16454
[GTK] Text input doesn't work consistently on PPC
- platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString):
UChar is 2 bytes (UTF-16), so transform accordingly from
gunichar (UCS-4). Fixes keyboard input on big endian systems.
Dec 15, 2007:
- 10:57 PM Changeset in webkit [28768] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
Fix urlSuitableForTestResult to correctly identify wstring::npos as
the case when wstring.find doesn't find anything.
- DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
- 6:00 PM Changeset in webkit [28767] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
- better build fix for the problem affecting GTK and some other platforms "this time for sure"
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTargetBase.cpp: Move the include of the .lut.h file here.
- bindings/js/JSEventTargetBase.h: Instead of including the .lut.h file in the header, which won't work, declare the tables that are in the .lut.h file in the header.
- 5:54 PM Changeset in webkit [28766] by
-
- 3 edits in trunk/WebCore
Fixed the Wx port's FontPlatformData for use in HashTable.
- 5:33 PM Changeset in webkit [28765] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5636090> Text in Georgia, Armenian, Inuktitut, Cree, or Cherokee (KA, HY, IU, CR, CHR) draws as all missing glyphs
- platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): Added. Called during metafile record enumeration and extracts the font from the create font record. (WebCore::FontCache::getFontDataForCharacters): If font linking fails, let Uniscribe draw the characters and see what font it chooses.
- 5:31 PM Changeset in webkit [28764] by
-
- 2 edits in trunk/WebCore
- WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.
- 5:30 PM Changeset in webkit [28763] by
-
- 285 edits1 move in trunk/LayoutTests
Disabled the smallFonts.svg test, which has been failing for weeks. I heard that Niko
is going to fix this soon. He should rename it back at that time.
Removed the svn:executable flag from many .svg, .png, and .css files that had it set
for no good reason.
- svg/batik/text/smallFonts.svg: Removed.
- svg/batik/text/smallFonts.svg-disabled: Copied from svg/batik/text/smallFonts.svg.
- 5:11 PM Changeset in webkit [28762] by
-
- 2 edits in trunk/WebCore
Another try at a GTK build fix.
- WebCore.pro: Add JSEventTargetBase.cpp to LUT_TABLE_FILES instead of LUT_FILES.
- 4:07 PM Changeset in webkit [28761] by
-
- 3 edits in trunk/WebCore
Force windows to regenerate COM DOM bindings.
- WebCore.vcproj/build-generated-files.sh: Add license.
- bindings/scripts/CodeGeneratorCOM.pm: Use shared WK_ucfirst.
- 3:32 PM Changeset in webkit [28760] by
-
- 3 edits in trunk/WebCore
Fix Windows and wx builds.
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 3:31 PM Changeset in webkit [28759] by
-
- 2 edits in trunk/WebCore
Gtk build fix. Add JSEventTargetBase.cpp to SOURCES.
- 3:24 PM Changeset in webkit [28758] by
-
- 2 edits in trunk/WebCore
Fix wx build.
- WebCoreSources.bkl:
- 3:23 PM Changeset in webkit [28757] by
-
- 2 edits in trunk/WebCore
Not reviewed. Build fix for Qt/Gtk.
- 2:48 PM Changeset in webkit [28756] by
-
- 10 edits2 adds in trunk/WebCore
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16445 (Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch)
Split up JSEventTargetNode in JSEventTargetNode & JSEventTargetBase - where most functionality has been moved down
in the base class. Applied the same refactorization to EventTargetNode.
This makes it possible for the upcoming patch implementing the EventTarget interface for SVGElementInstance
to share as much code as possible with the EventTargetNode classes.
- 12:03 PM Changeset in webkit [28755] by
-
- 6 edits5 adds in trunk
2007-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Width of SVG elements not applied to container elements
http://bugs.webkit.org/show_bug.cgi?id=16305
Added calcPrefWidths for RenderSVGRoot (copied from RenderReplaced)
This is caused by poor factoring in the render tree. RenderContainer probably should be a template.
svg/css/css-box-min-width.html
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths): Added.
- rendering/RenderSVGRoot.h:
- css/SVGCSSStyleSelector::applySVGProperty: fixed ASSERT in debug builds
- 6:46 AM Changeset in webkit [28754] by
-
- 2 edits in trunk/WebCore
Fix comment after isSafeScript() was renamed to allowsAccessFrom().
- bindings/js/kjs_window.cpp: (KJS::createWindow):
- 6:13 AM Changeset in webkit [28753] by
-
- 2 edits in trunk/WebKitTools
2007-12-15 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for GLib < 2.14.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
- 5:40 AM Changeset in webkit [28752] by
-
- 2 edits in trunk/LayoutTests
2007-12-15 Alp Toker <alp@atoker.com>
http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle
Fixed in r28751. Remove these tests from the skip list:
fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html
- platform/gtk/Skipped:
- 5:12 AM Changeset in webkit [28751] by
-
- 2 edits in trunk/WebCore
2007-12-15 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle
Add checks. This matches a similar workaround for a CG bug in the CG
graphics backend: <rdar://problem/5189233>
Fixes:
fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
- 4:39 AM Changeset in webkit [28750] by
-
- 4 edits in trunk/WebKitTools
Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
This prevents many layout tests from hanging while waiting on user responses to dialogs.
Reviewed by Alp Toker.
- 4:39 AM Changeset in webkit [28749] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.
- 3:00 AM Changeset in webkit [28748] by
-
- 6 edits in trunk/WebKitTools
Flesh out DumpRenderTree for Gtk. After these changes, the majority of the tests in fast/js pass.
Reviewed by Alp Toker.
- 1:30 AM Changeset in webkit [28747] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct a mistake in ChangeLog.
- 1:07 AM Changeset in webkit [28746] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16436
Alt+Space works incorrectly
Test: platform/win/fast/events/alt-space-scroll.html
- WebView.cpp: (WebView::keyDown): (WebView::keyPress): We do not handle WM_SYSCHAR events.
- 1:03 AM Changeset in webkit [28745] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16078
Google Maps zooming via the scroll wheel (almost) always zooms IN only.
- dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Ensure that delta is never rounded down to zero - we are getting values less than 1 from many mice on OS X, and Google Maps code assumes scrolling down if event.wheelDelta is zero.
Dec 14, 2007:
- 10:24 PM Changeset in webkit [28744] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-14 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Enable the AllInOneFile.cpp optimization for the GTK+ port.
- JavaScriptCore.pri:
- 8:35 PM Changeset in webkit [28743] by
-
- 2 edits in trunk/JavaScriptCore
Remove commented out fprintf's that were for debugging purposes only.
- 8:31 PM Changeset in webkit [28742] by
-
- 2 edits in trunk/JavaScriptCore
Don't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and is currently untested on other platforms.
Reviewed by Maciej Stachowiak.
- wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease): Return after releasing memory rather than potentially falling
through into another mechanism if multiple are supported.
- 8:21 PM Changeset in webkit [28741] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-14 Alp Toker <alp@atoker.com>
Build fix for GTK+/Qt and ports that don't use AllInOneFile.cpp.
Include UnusedParam.h.
- 7:53 PM Changeset in webkit [28740] by
-
- 2 edits in trunk/JavaScriptCore
Fix build on windows
Reviewd by Stephanie
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
- 7:26 PM Changeset in webkit [28739] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj:
- 7:02 PM Changeset in webkit [28738] by
-
- 2 edits in trunk/WebKit/win
- yet another build fix
- DOMHTMLClasses.cpp: (DOMHTMLDocument::URL):
- 7:00 PM Changeset in webkit [28737] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-14 Alp Toker <alp@atoker.com>
Fix inconsistent indentation in the license header. Maciej was right!
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- 6:51 PM Changeset in webkit [28736] by
-
- 2 edits in trunk/WebCore
2007-12-14 Alp Toker <alp@atoker.com>
GTK+/Qt build fix. Track added files in r28722.
- WebCore.pro:
- 6:16 PM Changeset in webkit [28735] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5647272> Remove user agent string hack for flickr.com
Reviewed by Darin.
- WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
- 6:15 PM Changeset in webkit [28734] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5647261> Remove user agent string hack for yahoo.com
Reviewed by Darin.
- WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
- 6:09 PM Changeset in webkit [28733] by
-
- 2 edits in trunk/JavaScriptCore
- try again to fix the Windows build
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
- 6:00 PM Changeset in webkit [28732] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the Windows build
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
- 5:35 PM Changeset in webkit [28731] by
-
- 2 edits in trunk/WebKit/win
- build fix
- WebIconDatabase.h:
- 5:19 PM Changeset in webkit [28730] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog
- 5:17 PM Changeset in webkit [28729] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Speed up getElementByClassName.
- This makes getElementByClassName take 33% faster on the stress test linked to at http://bugs.webkit.org/show_bug.cgi?id=15760.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::foldCase): Optimize the case when all the characters are ASCII.
- 5:03 PM Changeset in webkit [28728] by
-
- 21 edits in trunk
2007-12-14 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16432
[GTK] Update license headers
Consent has been given by the authors of these files to change license
to the LGPL as outlined in the bug report.
- 4:25 PM Changeset in webkit [28727] by
-
- 3 edits in trunk/JavaScriptCore
Add logic for TCMalloc to release memory to the system
Reviewed by Maciej and Oliver.
Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.
- 3:42 PM Changeset in webkit [28726] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=16442 navigation policy delegate gets called twice for each load
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy. That's handled by FrameLoader.
- loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy and continueAfterNavigationPolicy.
- 3:41 PM Changeset in webkit [28725] by
-
- 3 edits in trunk/WebKit/win
Reviewed by Adele.
- http://bugs.webkit.org/show_bug.cgi?id=16443 implement some missing Windows WebKit functions
- DOMHTMLClasses.cpp: (DOMHTMLDocument::URL): Implemented.
- WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.
- 3:06 PM Changeset in webkit [28724] by
-
- 1 edit1 move in trunk/LayoutTests
- share the results of this test between Tiger and Leopard
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
- platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.
- 2:06 PM Changeset in webkit [28723] by
-
- 6 edits3 adds in trunk
WebCore:
Reviewed by Brady.
Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
return nil in that case.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
WebKitTools:
Reviewed by Brady.
Assert that a web frame that's loading a resource always has either a data source or
a provisional data source.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
LayoutTests:
Reviewed by Brady.
Add test that calls window.open and then immediately writes into the document
of the newly opened window.
- http/tests/misc/resources/compass.jpg: Added.
- http/tests/misc/window-open-then-write-expected.txt: Added.
- http/tests/misc/window-open-then-write.html: Added.
- platform/win/Skipped:
- 1:48 PM Changeset in webkit [28722] by
-
- 17 edits1 move45 adds in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName.
This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
and takes advantage of admitting that it's class-specific to encapsulate class attribute
parsing so it can be shared. It also changes the class to use a Vector, rather than a linked
list to store the class names.
Tests: fast/dom/getElementsByClassName/001.html
fast/dom/getElementsByClassName/002.html
fast/dom/getElementsByClassName/003.html
fast/dom/getElementsByClassName/004.html
fast/dom/getElementsByClassName/005.html
fast/dom/getElementsByClassName/006.html
fast/dom/getElementsByClassName/007.html
fast/dom/getElementsByClassName/008.html
fast/dom/getElementsByClassName/009.html
fast/dom/getElementsByClassName/010.xml
fast/dom/getElementsByClassName/011.xml
fast/dom/getElementsByClassName/012.html
fast/dom/getElementsByClassName/013.html
fast/dom/getElementsByClassName/014.html
fast/dom/getElementsByClassName/array/001.html
fast/dom/getElementsByClassName/array/002.html
fast/dom/getElementsByClassName/array/003.html
fast/dom/getElementsByClassName/array/004.html
fast/dom/getElementsByClassName/dumpNodeList.html
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
- dom/AtomicStringList.h: Removed.
- dom/ClassNames.cpp: Added. (WebCore::ClassNames::contains): (WebCore::ClassNames::parseClassAttribute):
- dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h. (WebCore::ClassNames::ClassNames): (WebCore::ClassNames::size): (WebCore::ClassNames::clear): (WebCore::ClassNames::operator[]): (WebCore::isClassWhitespace):
- dom/ClassNodeList.cpp: Added. (WebCore::ClassNodeList::ClassNodeList): (WebCore::ClassNodeList::length): (WebCore::ClassNodeList::item): (WebCore::ClassNodeList::nodeMatches):
- dom/ClassNodeList.h: Added.
- dom/Document.cpp: (WebCore::Document::getElementsByName): (WebCore::Document::getElementsByClassName):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp: (WebCore::Element::getClassNames): (WebCore::Element::getElementsByClassName):
- dom/Element.h:
- dom/Element.idl:
- dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
- dom/NameNodeList.h:
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): (WebCore::NamedMappedAttrMap::parseClassAttribute):
- dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getClassNames):
- dom/StyledElement.cpp: (WebCore::StyledElement::getClassNames):
- dom/StyledElement.h:
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName
Tests added from http://tc.labs.opera.com/apis/getElementsByClassName/
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/getElementsByClassName: Added.
- fast/dom/getElementsByClassName/001-expected.txt: Added.
- fast/dom/getElementsByClassName/001.html: Added.
- fast/dom/getElementsByClassName/002-expected.txt: Added.
- fast/dom/getElementsByClassName/002.html: Added.
- fast/dom/getElementsByClassName/003-expected.txt: Added.
- fast/dom/getElementsByClassName/003.html: Added.
- fast/dom/getElementsByClassName/004-expected.txt: Added.
- fast/dom/getElementsByClassName/004.html: Added.
- fast/dom/getElementsByClassName/005-expected.txt: Added.
- fast/dom/getElementsByClassName/005.html: Added.
- fast/dom/getElementsByClassName/006-expected.txt: Added.
- fast/dom/getElementsByClassName/006.html: Added.
- fast/dom/getElementsByClassName/007-expected.txt: Added.
- fast/dom/getElementsByClassName/007.html: Added.
- fast/dom/getElementsByClassName/008-expected.txt: Added.
- fast/dom/getElementsByClassName/008.html: Added.
- fast/dom/getElementsByClassName/009-expected.txt: Added.
- fast/dom/getElementsByClassName/009.html: Added.
- fast/dom/getElementsByClassName/010-expected.txt: Added.
- fast/dom/getElementsByClassName/010.xml: Added.
- fast/dom/getElementsByClassName/011-expected.txt: Added.
- fast/dom/getElementsByClassName/011.xml: Added.
- fast/dom/getElementsByClassName/012-expected.txt: Added.
- fast/dom/getElementsByClassName/012.html: Added.
- fast/dom/getElementsByClassName/013-expected.txt: Added.
- fast/dom/getElementsByClassName/013.html: Added.
- fast/dom/getElementsByClassName/014-expected.txt: Added.
- fast/dom/getElementsByClassName/014.html: Added.
- fast/dom/getElementsByClassName/array: Added.
- fast/dom/getElementsByClassName/array/001-expected.txt: Added.
- fast/dom/getElementsByClassName/array/001.html: Added.
- fast/dom/getElementsByClassName/array/002-expected.txt: Added.
- fast/dom/getElementsByClassName/array/002.html: Added.
- fast/dom/getElementsByClassName/array/003-expected.txt: Added.
- fast/dom/getElementsByClassName/array/003.html: Added.
- fast/dom/getElementsByClassName/array/004-expected.txt: Added.
- fast/dom/getElementsByClassName/array/004.html: Added.
- fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
- fast/dom/getElementsByClassName/dumpNodeList.html: Added.
- fast/dom/getElementsByClassName/resources: Added.
- fast/dom/getElementsByClassName/resources/common.js: Added.
- 12:50 PM Changeset in webkit [28721] by
-
- 6 edits in trunk
Reviewed by Sam.
- removed unnecessary includes of "Vector.h"
- wtf/HashMap.h: (WTF::copyKeysToVector): Make the type of the vector be a template parameter. This allows copying keys into a vector of a base class or one with an inline capacity. (WTF::copyValuesToVector): Ditto.
- wtf/HashSet.h: (WTF::copyToVector): Ditto.
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=16351 FontFallbackList.h doesn't include wtf/PassRefPtr.h
- platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
- platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.
- 12:42 PM Changeset in webkit [28720] by
-
- 3 edits in trunk/WebKitTools
- fix mistake causing nearly all tests to fail on Windows
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with npos, not 0. Also pass URL in to URL function rather than passing the entire message.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather than passing the entire message.
- 12:34 PM Changeset in webkit [28719] by
-
- 2 edits in trunk/WebKitTools
- fix Tiger build
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any new-to-Leopard methods.
- 12:25 PM Changeset in webkit [28718] by
-
- 4 edits in trunk
WebKit/mac:
Reviewed by Brady.
- fix http://bugs.webkit.org/show_bug.cgi?id=16296 <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
- WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the a didReceiveIcon method is present.
WebKitTools:
- DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method since it now triggers unwanted icon loading. We only had it because we implemented "all" delegate methods here.
- 12:03 PM Changeset in webkit [28717] by
-
- 38 edits in trunk
WebCore:
Reviewed by Alexey.
- http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand
Add a few more operations to document.execCommand.
Finished up the transition to the new Editor::Command, including removing
the Editor::execCommand function.
- WebCore.base.exp: Added Editor::Command::isSupported.
- editing/Editor.h: Removed execCommand.
- editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): Added. (WebCore::verticalScrollDistance): Added; replaces canScroll. (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by removing the explicit scrolling, and letting it be done automatically by code that makes the caret visible. In some cases the old code would scroll twice which was harmless but unnecessary. (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeMovePageUp): See MovePageDown above. (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeSelectLine): Ditto. (WebCore::executeSelectParagraph): Ditto. (WebCore::executeSelectSentence): Ditto. (WebCore::executeSelectWord): Ditto. (WebCore::executeSwapWithMark): Some small tweaks.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command() instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a bit more, but I didn't do that this time.
- Removed some obsolete unused code.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for NSTextView. This was left over from when we used NSTextField and NSTextView for form elements and is no longer used at all.
- page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side of the bridge or another. We really need to find a time to tear down the rest of the bridge, but that's not this patch.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly instead of using a method. (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Took out obsolete comment about matching enums (we use a single enum now and have for some time). (-[WebCoreFrameBridge selectionGranularity]): Ditto.
WebKit:
- StringsNotToBeLocalized.txt: Updated.
WebKit/gtk:
Reviewed by Alexey.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command instead of Editor::execCommand.
- WebView/webkitwebview.cpp: Ditto.
WebKit/mac:
Reviewed by Alexey.
- Changed a few more editing operations to use WebCore instead of WebKit.
- Removed some obsolete unused code.
- WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both defined and used on the WebKit side to here. These no longer belong on the bridge and should be moved to the WebFrame class (or elsewhere).
- WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
- WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _setMouseDownEvent:]): Ditto. (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:, pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be disambiguated with the word "Move"). Added deleteBackward:, deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:, deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:, pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:, selectParagraph:, selectSentence:, and selectWord: to the list of commands that are forwarded to WebCore. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of operations that we forward to WebCore. Instead, look up any command that WebCore can handle, after any that we handle specially in WebHTMLView. Also fixed a bug where an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:. (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
- WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus, firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and _willMakeFirstResponderForNodeFocus.
WebKit/qt:
Reviewed by Alexey.
- Api/qwebpage.cpp: (QWebPage::triggerAction): Removed some use of Editor member functions we plan to eventually eliminate. Switch from Editor::execCommand to Editor::command.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown.
WebKit/win:
Reviewed by Alexey.
- WebView.cpp: (WebView::execCommand): Switched from Editor::execCommand to Editor:command. Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown. (WebView::copy): Switched from Editor::execCommand to Editor:command. (WebView::cut): Ditto. (WebView::paste): Ditto. (WebView::delete_): Ditto.
WebKit/wx:
Reviewed by Alexey.
- WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand to Edtor::command.
LayoutTests:
Reviewed by Alexey.
- http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand
To avoid changing results at this time, I didn't correct the many tests that now have
misleading "this test cannot be run manually" text or references to "NSResponder" or
uneeded instructions for running the test manually. We can do that on a later pass.
- editing/deleting/5300379.html: Use execCommand instead of doCommand.
- editing/deleting/delete-to-end-of-paragraph.html: Ditto.
- editing/deleting/smart-delete-003.html: Ditto.
- editing/deleting/smart-delete-004.html: Ditto.
- editing/execCommand/nsresponder-indent.html: Ditto.
- editing/execCommand/nsresponder-outdent.html: Ditto.
- editing/selection/4947387.html: Ditto.
- editing/selection/5195166-1.html: Ditto.
- editing/selection/5195166-2.html: Ditto.
- editing/selection/select-line.html: Ditto.
- editing/selection/selection-actions.html: Ditto.
- 11:55 AM Changeset in webkit [28716] by
-
- 8 edits6 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
- editing/CompositeEditCommand.h:
- editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
- editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between it and listNode, if they exists, so that moving listChildNode doesn't put it out of order. Added a test case to cover each change.
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that tries to split a container at a bogus child, and an early return to avoid a hang in that case.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list
- editing/execCommand/5575101-1-expected.txt: Added.
- editing/execCommand/5575101-1.html: Added.
- editing/execCommand/5575101-2-expected.txt: Added.
- editing/execCommand/5575101-2.html: Added.
- editing/execCommand/5575101-3-expected.txt: Added.
- editing/execCommand/5575101-3.html: Added.
- 11:47 AM Changeset in webkit [28715] by
-
- 11 edits3 adds in trunk
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.
The way this used to work was that each NPObject that wrapped a JSObject would have a root object
corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
doing security checks).
This would prevent a plug-in from accessing a frame's window object if it's security origin was different
(some parts of the window, such as the location object, can be accessed from frames with different security
origins, and those checks are being done in WebCore).
Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
Window JSObject being garbage collected and the NPObject pointing to freed memory.
How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
for a plug-in will have the root object of the containing frame of that plug-in.
- bindings/NP_jsobject.cpp: (jsDeallocate): Don't free the origin root object.
(_NPN_CreateScriptObject):
Remove the origin root object parameter.
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
Get rid of all security checks.
- bindings/NP_jsobject.h: Remove originRootObject from the JavaScriptObject struct.
- bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Always use the root object from the ExecState.
WebCore:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
_NPN_CreateScriptObject doesn't take an origin root object anymore.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
- page/Frame.cpp: (WebCore::Frame::windowScriptNPObject):
WebKitTools:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Add property getting methods to the plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):
LayoutTests:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
top-level frame.
- http/tests/plugins/cross-frame-object-access-expected.txt: Added.
- http/tests/plugins/cross-frame-object-access.html: Added.
- http/tests/plugins/resources/cross-frame-object-access.html: Added.
- 11:37 AM Changeset in webkit [28714] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5643663> text-shadow and box-shadow offsets 1px smaller than specified which is the root cause of: http://bugs.webkit.org/show_bug.cgi?id=12943 box-shadow: small values don't affect shadow position http://bugs.webkit.org/show_bug.cgi?id=14736 Safari implementation of text-shadow off by 1px
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude of the offsets passed to CGContextSetShadow* to ensure that the end result after truncation is the desired integer offsets.
- 10:34 AM Changeset in webkit [28713] by
-
- 2 edits1 add in trunk/LayoutTests
Move layout test to mac skipped list until mac frt bug fixed.
Reviewed by Adam.
Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.
- 10:19 AM Changeset in webkit [28712] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
- Layout test fix for mac. When dumped to the console local file paths now only show the name of the resource not the whole path. This is to make the results machine and OS independent.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]):
Dec 13, 2007:
- 10:56 PM Changeset in webkit [28711] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
curl backend build fix for breakage introduced in r28709.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- 9:32 PM Changeset in webkit [28710] by
-
- 4 edits12 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Equip this function to handle editing positions, like [input, 0];
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Pass enclosingBlock a node peeled off of a non-editing position, to fix a bug where the enclosing block of [input, 0] was the input element itself. Insert a <br> when a <form> element is the enclosing block instead of splitting/cloning or nesting a <div>.
LayoutTests:
Reviewed by Oliver Hunt.
<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element
- editing/inserting/5607069-1-expected.checksum: Added.
- editing/inserting/5607069-1-expected.png: Added.
- editing/inserting/5607069-1-expected.txt: Added.
- editing/inserting/5607069-1.html: Added.
- editing/inserting/5607069-2.html: Added.
- editing/inserting/5607069-3.html: Added.
- platform/mac/editing/inserting/5607069-2-expected.checksum: Added.
- platform/mac/editing/inserting/5607069-2-expected.png: Added.
- platform/mac/editing/inserting/5607069-2-expected.txt: Added.
- platform/mac/editing/inserting/5607069-3-expected.checksum: Added.
- platform/mac/editing/inserting/5607069-3-expected.png: Added.
- platform/mac/editing/inserting/5607069-3-expected.txt: Added.
- 7:37 PM Changeset in webkit [28709] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
http://bugs.webkit.org/show_bug.cgi?id=16365
[cURL] Acid2 test segmentation fault
This patch makes the Acid2 test pass.
Defer the cleanup of cancelled jobs and halt further transfer as early
as possible.
Bug found by and initial patch provided by Luca Bruno.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::cancel):
- 7:32 PM Changeset in webkit [28708] by
-
- 4 edits in trunk/WebCore
Reviewed by Mark Rowe.
Fix typos and rename InspectorController::moveByUnrestricted to InspectorController::moveWindowBy.
- page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveWindowBy):
- page/InspectorController.h:
- page/inspector/inspector.js:
- 7:20 PM UsingGitWithWebKit edited by
- (diff)
- 7:19 PM UsingGitWithWebKit edited by
- (diff)
- 7:16 PM UsingGitWithWebKit edited by
- (diff)
- 6:58 PM UsingGitWithWebKit edited by
- (diff)
- 6:40 PM UsingGitWithWebKit edited by
- (diff)
- 6:30 PM UsingGitWithWebKit edited by
- (diff)
- 6:25 PM Changeset in webkit [28707] by
-
- 7 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function
Test: fast/css/transition-timing-function.html
- css/CSSStyleSelector.cpp: Changed the HANDLE_MULTILAYER_VALUE macro to not reject non-primitive non-list values, and instead made sure that the mapping functions rejected them if necessary. This allows non-primitive timing functions to be mapped. (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
- css/CSSTimingFunctionValue.cpp: (WebCore::CSSTimingFunctionValue::cssText): Implemented for use in the regression test.
- css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue): Added. Returns true.
- css/CSSValue.h: (WebCore::CSSValue::isTransitionTimingFunctionValue): Added. Returns false.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function
- fast/css/transition-timing-function-expected.txt: Added.
- fast/css/transition-timing-function.html: Added.
- 6:14 PM Changeset in webkit [28706] by
-
- 5 edits in trunk/SunSpider
Reviewed by Oliver.
- Add some explanatory test and a dumb logo to SunSpider web hosted version
- hosted/sunspider-driver.html:
- hosted/sunspider-results.html:
- hosted/sunspider.css:
- hosted/sunspider.html:
- 6:07 PM Changeset in webkit [28705] by
-
- 12 edits2 adds5 deletes in trunk
WebKitTools:
Reviewed by Adam.
- Layout tests fix. We need a way to remove machine-dependent information from paths in layout test results. The UIDelegate now does this.
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole):
LayoutTests:
Reviewed by Adam.
- Layout tests fix. Removed machine dependant results and generated new results without machine specific information.
- fast/dom/frame-loading-via-document-write-expected.txt: Added.
- http/tests/security/frame-loading-via-document-write-expected.txt: Added.
- http/tests/security/local-CSS-from-remote-expected.txt:
- http/tests/security/local-JavaScript-from-remote-expected.txt:
- http/tests/security/local-iFrame-from-remote-expected.txt:
- http/tests/security/local-image-from-remote-expected.txt:
- platform/mac/fast/dom/frame-loading-via-document-write-expected.checksum: Removed.
- platform/mac/fast/dom/frame-loading-via-document-write-expected.png: Removed.
- platform/mac/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
- platform/mac/http/tests/security: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.checksum: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.png: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
- platform/win/Skipped:
- platform/win/http: Removed.
- platform/win/http/tests: Removed.
- platform/win/http/tests/security: Removed.
- platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
- 5:23 PM Changeset in webkit [28704] by
-
- 10 edits2 adds in trunk
WebCore:
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- WebCore.vcproj/WebCore.make:
- WebCore.vcproj/WebCore.sln:
- WebCore.vcproj/WebCore.submit.sln:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreGenerated.vcproj: Added.
WebKit/win:
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj: Added.
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.submit.sln:
- WebKit.vcproj/build-generated-files.sh:
- 5:22 PM Changeset in webkit [28703] by
-
- 1 edit in trunk/WebCore/editing/ApplyStyleCommand.cpp
Fix the build.
- 5:12 PM Changeset in webkit [28702] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/4145786> Undoing a color change of text in a compose window always changes it back to black
Some of the operations performed in removeHTMLFontStyle were non-undoable.
I'm having trouble writing a layout test for this because I can't get DRT to
perform editing operations in separate Undo steps without adding unacceptably long
wait times between operations. I filed:
<rdar://problem/5646779> Can't get DRT to perform editing operations in separate Undo steps
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
- 5:10 PM Changeset in webkit [28701] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16352
Toolbar dragged inspector cannot be moved beyond screen edges
- page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveByUnrestricted):
- page/InspectorController.h:
- page/inspector/inspector.js:
- 5:07 PM Changeset in webkit [28700] by
-
- 6 edits in trunk
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
WebCore:
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
Windows Media Player has a modal message loop that will deliver
messages to us at inappropriate times and we will crash if we handle
them when they are delivered. In PluginViewWin, we add a quirk for
Media Player to set a flag whenever we give the plugin a chance to
execute code, and in SharedTimerWin we check if the plugin is
executing code and repost messages if so.
Reviewed by Anders.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Repost messages if we're calling a plugin.
- plugins/win/PluginViewWin.cpp: Surround all calls to the plugin with setCallingPlugin(true/false). (WebCore::PluginViewWin::updateWindow): (WebCore::PluginViewWin::dispatchNPEvent): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::bindingInstance): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setCallingPlugin): Added. (WebCore::PluginViewWin::isCallingPlugin): Added.
- plugins/win/PluginViewWin.h: Added a new quirk.
WebKit/win:
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
Reviewed by Anders.
- WebView.cpp: (WebViewWndProc): Repost paint messages and ignore all other messages when we're calling a plugin.
- 4:56 PM Changeset in webkit [28699] by
-
- 2 edits in trunk/WebKitTools
2007-12-13 Alp Toker <alp@atoker.com>
Build fix for DRT breakage introduced in r28690.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pathToLocalResource):
- 4:32 PM Changeset in webkit [28698] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
Add a missing DEPENDPATH. Fixes non-clean builds following networking
header changes.
- WebCore.pro:
- 3:48 PM Changeset in webkit [28697] by
-
- 6 edits2 adds in trunk
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- JavaScriptCore.vcproj/JavaScriptCore.sln:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
WebKit/win:
Fix project dependencies based on JavaScriptCore change.
- WebKit.vcproj/WebKit.sln:
- 2:59 PM Changeset in webkit [28696] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix regression in fast/text/international/bidi-override on Tiger
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Add bidi overrides here too. I forgot to add them when I added them to treatAsZeroWidthSpace in an earlier patch.
- 2:17 PM Changeset in webkit [28695] by
-
- 3 edits2 adds in trunk
Reviewed by Adele.
http://bugs.webkit.org/show_bug.cgi?id=16421
REGRESSION(r28669): Page scrolls down when you hit space key in text area
Test: fast/events/space-scroll-event.html
- WebView.cpp: (WebView::keyDown): (WebView::keyPress): Moved space handliing to keyPress() to fix this bug and to match IE. Scrolling via arrow keys is correctly handled in keyDown().
- 1:32 PM Changeset in webkit [28694] by
-
- 14 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
The code that checks the selected Range to see if it's inside an anchor
checks ancestors of the Range's commonAncestor() but not the
commonAncestor() itself, and so we'd fail to add markup for the enclosing
anchor to the pasteboard.
Some enclosing element getters check the node passed to the getter and some
don't. There were a few places where we incorrectly assumed that enclosing
element getters check the node passed to the getter, but this is the only
case that I'm able to write a test case for at the moment.
In this patch I've:
Changed enclosingNodeWithType and enclosingNodeWithTag to take in positions,
like the newer enclosing element getters. This is important because we must
soon add code to the getters so that they understand that some editing positions
inside nodes don't actually refer to positions inside those nodes but positions
before and after them. Like [table, 0].
Changed enclosingNodeWithType and enclosingNodeWithTag to check nodes starting with
n where [n, o] is the position passed to the getter, instead of starting the the parent
of n. This makes all but a few of the enclosing element getters behave consistently.
Changed enclosingNodeWithType and enclosingNodeWithTag to not return non-editable
nodes if the input position was editable. This fixes a bug that that the above change
exposed.
Changed enclosingTableCell to simply call enclosingNodeWithType. We should do
this for the rest of the getters, or simply remove them in favor of enclosingNodeWithType
unless doing so would affect readability, like it would in the case of enclosingTableCell.
Ditto for enclosingBlock.
- editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
- editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): (WebCore::Editor::selectionOrderedListState):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::outdentParagraph):
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
- editing/TextIterator.cpp:
- editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::enclosingTableCell): (WebCore::isTableCell):
- editing/htmlediting.h:
- editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::createMarkup):
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
- editing/pasteboard/5601583-1.html: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.checksum: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.png: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.txt: Added.
- 12:40 PM Changeset in webkit [28693] by
-
- 13 edits in trunk
Reviewed by Darin.
Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
- 11:38 AM Changeset in webkit [28692] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-13 Alp Toker <alp@atoker.com>
http://bugs.webkit.org/show_bug.cgi?id=16406
[Gtk] JavaScriptCore needs -lpthread
Build fix for Debian and any other platforms that don't implicitly
link to pthread.
Link to pthread on non-Windows platforms until this dependency is
removed from JSC.
- 11:36 AM Changeset in webkit [28691] by
-
- 2 edits in trunk/WebCore
- build fix
- platform/network/cf/ResourceErrorCF.cpp:
- 11:07 AM Changeset in webkit [28690] by
-
- 27 edits4 adds in trunk
WebKitTools:
Reviewed by Alice and Sam.
- <rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
- Implemented pathToLocalResource which exposes the functionality of converting a given unix path to the correct location on Windows.
- DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pathToLocalResource):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource):
LayoutTests:
Reviewed by Alice and Sam.
- <rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
- Updated the following tests to use the new layoutTestController function, pathToLocalResource to get a Windows viable path (when on Windows) to the local resources they are attempting to access.
- Also clarified and updated some results.
- fast/dom/frame-loading-via-document-write.html:
- fast/loader/local-CSS-from-local-expected.txt:
- fast/loader/local-CSS-from-local.html:
- fast/loader/local-JavaScript-from-local-expected.txt:
- fast/loader/local-JavaScript-from-local.html:
- fast/loader/local-iFrame-source-from-local-expected.txt:
- fast/loader/local-iFrame-source-from-local.html:
- fast/loader/local-image-from-local-expected.txt:
- fast/loader/local-image-from-local.html:
- http/tests/security/frame-loading-via-document-write.html:
- http/tests/security/local-CSS-from-remote-expected.txt:
- http/tests/security/local-CSS-from-remote.html:
- http/tests/security/local-JavaScript-from-remote-expected.txt:
- http/tests/security/local-JavaScript-from-remote.html:
- http/tests/security/local-iFrame-from-remote-expected.txt:
- http/tests/security/local-iFrame-from-remote.html:
- http/tests/security/local-image-from-remote-expected.txt:
- http/tests/security/local-image-from-remote.html:
- http/tests/security/local-user-CSS-from-remote.html:
- platform/mac/fast/dom/frame-loading-via-document-write-expected.txt:
- platform/win/Skipped:
- platform/win/http: Added.
- platform/win/http/tests: Added.
- platform/win/http/tests/security: Added.
- platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Added.
- 10:55 AM Changeset in webkit [28689] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Fix <rdar://problem/5605674>
Make <video> display WebKit context menu instead of the QTKit one.
It doesn't really matter where the QTMovieView is.
- ChangeLog:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::setRect):
- 10:45 AM Changeset in webkit [28688] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Adam Roben.
- ensure that Unicode bidi control characters are rendered as zero width spaces
Test: fast/text/international/bidi-control-chars-treated-as-ZWS.html
- platform/graphics/Font.h: (WebCore::Font::treatAsZeroWidthSpace):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
- platform/text/CharacterNames.h:
LayoutTests:
Reviewed by Adam Roben.
- test that Unicode bidi control characters are rendered as zero width spaces
- fast/text/international/bidi-control-chars-treated-as-ZWS.html: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
- 5:51 AM QtWebKitTodo edited by
- (diff)
- 5:50 AM QtWebKitTodo edited by
- (diff)
- 5:50 AM Changeset in webkit [28687] by
-
- 2 edits in tags/Safari-5523.15
Versioning.
- 5:50 AM Changeset in webkit [28686] by
-
- 3 edits in tags/Safari-5523.15/WebCore
Merge r28304.
- 5:49 AM Changeset in webkit [28685] by
-
- 2 edits in tags/Safari-5523.15/WebKit
Merge r28362.
- 5:48 AM Changeset in webkit [28684] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r27379.
- 5:47 AM Changeset in webkit [28683] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r28066.
- 5:46 AM Changeset in webkit [28682] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r28064.
- 5:45 AM Changeset in webkit [28681] by
-
- 4 edits in tags/Safari-5523.15/WebKit
Merge r28081.
- 5:44 AM Changeset in webkit [28680] by
-
- 3 edits2 adds in tags/Safari-5523.15
Merge r27796.
- 4:09 AM Changeset in webkit [28679] by
-
- 1 copy in tags/Safari-5523.15
New tag.
- 1:50 AM Changeset in webkit [28678] by
-
- 5 edits1 add in trunk/SunSpider
Reviewed by Oliver.
- Make the web-hosted version of SunSpider look a little bit less drab.
- hosted/sunspider-driver.html:
- hosted/sunspider-results.html:
- hosted/sunspider.css: Added.
- hosted/sunspider.html:
- resources/TEMPLATE.html:
- 1:18 AM Changeset in webkit [28677] by
-
- 1 copy in tags/Safari-525.3b
New tag.
- 12:24 AM Changeset in webkit [28676] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/wx/TemporaryLinkStubs.cpp:
